2010-06-01 Martin Robinson <mrobinson@igalia.com>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
2
3         Reviewed by Xan Lopez.
4
5         [GTK] css1/color_and_background/background_attachment.html fails on the 32-bit debug bot
6         https://bugs.webkit.org/show_bug.cgi?id=39101
7
8         Work around timing issues for render tree dumps by pumping the
9         main loop before doing the dump. Resize events are asynchronous
10         in GTK+, so sometimes resize requests are still pending when DRT
11         dumps the tree.
12
13         * DumpRenderTree/gtk/DumpRenderTree.cpp:
14         (dump): Pump the main loop before dumping the render tree.
15
16 2010-05-31  Kent Tamura  <tkent@chromium.org>
17
18         Reviewed by Dimitri Glazkov.
19
20         [DRT/Chromium] Fix crash of a test after another test with multiple windows
21         https://bugs.webkit.org/show_bug.cgi?id=39942
22
23         If a test opens multiple windows, focuses on non-main window, and
24         the focused window is closed, TestShell::m_focusedWidget points a
25         deleted object.
26
27         * DumpRenderTree/chromium/TestShell.cpp:
28         (TestShell::closeWindow): Clear m_focusedWidget.
29
30 2010-05-30  Kent Tamura  <tkent@chromium.org>
31
32         Reviewed by Dimitri Glazkov.
33
34         new-run-webkit-tests: Support DRT on Chromium-win
35         https://bugs.webkit.org/show_bug.cgi?id=39810
36
37         Add --test-shell flag to DRT/Chromium, and it changes DRT so that
38         it behaves like test_shell about command analysis, printing
39         format, pixel dumping, and timeout handling.
40
41         chromium.py and chromium_win.py supports the --test-shell flag and
42         DRT/Chromium-win binary names.
43         
44         * DumpRenderTree/DumpRenderTree.gypi: Add new files.
45         * DumpRenderTree/chromium/DumpRenderTree.cpp:
46         (runTest): Support for test_shell-style command.
47         (main): Introduce --test-shell.
48         * DumpRenderTree/chromium/TestEventPrinter.cpp: Added.
49         * DumpRenderTree/chromium/TestEventPrinter.h: Added.
50           TestEventPrinter class manages stdio output and image output.
51           TestEventPrinter.cpp has two implementations; DRTPrinter and
52           TestShellPrinter.
53         * DumpRenderTree/chromium/TestShell.cpp:
54           Some changes for TestEventPrinter.
55         (TestShell::TestShell):
56         (TestShell::runFileTest):
57         (TestShell::testTimedOut):
58         (TestShell::dump):
59         (TestShell::dumpImage):
60         * DumpRenderTree/chromium/TestShell.h:
61         (TestShell::printer):
62         (TestShell::layoutTestTimeout):
63         (TestShell::layoutTestTimeoutForWatchDog):
64         (TestShell::setLayoutTestTimeout):
65         * DumpRenderTree/chromium/TestShellWin.cpp:
66         (watchDogThread): Use TestShell::layoutTestTimeoutForWatchDog().
67         * Scripts/webkitpy/layout_tests/port/chromium.py:
68         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
69
70 2010-05-30  Robert Hogan  <robert@webkit.org>
71
72         Reviewed by Kenneth Rohde Christiansen.
73
74         [Qt] Enhance Qt DRT implementation to support platform scroll wheel events.
75
76         https://bugs.webkit.org/show_bug.cgi?id=36004
77
78         * DumpRenderTree/qt/EventSenderQt.cpp:
79         (EventSender::EventSender): QApplication::setWheelScrollLines(2) in order to match
80                                     Scrollbar::pixelsPerLineStep() for DRT testing.
81         (EventSender::mouseScrollBy): Added
82         (EventSender::continuousMouseScrollBy): Added
83         * DumpRenderTree/qt/EventSenderQt.h:
84
85 2010-05-28  Adam Barth  <abarth@webkit.org>
86
87         Reviewed by David Levin.
88
89         webkit-patch should support CHANGE_LOG_EDIT_APPLICATION
90         https://bugs.webkit.org/show_bug.cgi?id=39546
91
92         One sublty is that we want to wait for the user to finish editing the
93         ChangeLog before moving on to the next step.  That means we want to pass
94         -W to open.  However, if the user is using Xcode to edit the ChangeLog,
95         we don't want them to have to exit the Xcode application.  For this reason,
96         we create a new instance of the application with -n.
97         
98         Overall, xed seems like a better solution, so we recommend that too.
99
100         * Scripts/webkitpy/common/system/user.py:
101         * Scripts/webkitpy/tool/mocktool.py:
102         * Scripts/webkitpy/tool/steps/editchangelog.py:
103
104 2010-05-21  Dirk Pranke  <dpranke@chromium.org>
105
106         Reviewed by Ojan Vafai.
107
108         new-run-webkit-tests: fix handling of Ctrl-C to exit even if some
109         threads are wedged. Also, the script will print the results of the
110         tests completed when the interrupt occurs.
111
112         https://bugs.webkit.org/show_bug.cgi?id=33238
113
114         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
115         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
116         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
117         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
118
119 2010-05-28  Darin Adler  <darin@apple.com>
120
121         Ignore more Python messiness.
122
123         * Scripts/webkitpy/layout_tests/data/platform/test: Added property svn:ignore.
124         * Scripts/webkitpy/layout_tests/layout_package: Added property svn:ignore.
125         * Scripts/webkitpy/layout_tests/test_types: Added property svn:ignore.
126         * Scripts/webkitpy/test: Added property svn:ignore.
127         * Scripts/webkitpy/thirdparty/simplejson: Added property svn:ignore.
128
129 2010-05-28  Chris Fleizach  <cfleizach@apple.com>
130
131         Reviewed by Beth Dakin.
132
133         Adding myself as a reviewer.
134
135         * Scripts/webkitpy/common/config/committers.py:
136
137 2010-05-28  Chris Fleizach  <cfleizach@apple.com>
138
139         Build fix. No review.
140
141         AX: need to catch NSAccessibilityExceptions in DRT
142         https://bugs.webkit.org/show_bug.cgi?id=39881
143
144         It looks like Tiger doesn't like seeing a NSMakeRange inside a @try.
145
146         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
147         (AccessibilityUIElement::rowIndexRange):
148         (AccessibilityUIElement::columnIndexRange):
149         (AccessibilityUIElement::selectedTextRange):
150
151 2010-05-28  Chris Fleizach  <cfleizach@apple.com>
152
153         Reviewed by Darin Adler.
154
155         AX: need to catch NSAccessibilityExceptions in DRT
156         https://bugs.webkit.org/show_bug.cgi?id=39881
157
158         Normally, accessibility exceptions are caught in the AX Runtime on the Mac, but 
159         because DRT is its own AX client, no one is there to catch these otherwise innocuous exceptions.
160   
161         So DRT should wrap exception handlers around its AX related calls.
162
163         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
164         (attributesOfElement):
165         (AccessibilityUIElement::getLinkedUIElements):
166         (AccessibilityUIElement::getDocumentLinks):
167         (AccessibilityUIElement::getChildren):
168         (AccessibilityUIElement::getChildrenWithRange):
169         (AccessibilityUIElement::ariaOwnsElementAtIndex):
170         (AccessibilityUIElement::ariaFlowToElementAtIndex):
171         (AccessibilityUIElement::disclosedRowAtIndex):
172         (AccessibilityUIElement::selectedRowAtIndex):
173         (AccessibilityUIElement::titleUIElement):
174         (AccessibilityUIElement::parentElement):
175         (AccessibilityUIElement::disclosedByRow):
176         (AccessibilityUIElement::stringAttributeValue):
177         (AccessibilityUIElement::boolAttributeValue):
178         (AccessibilityUIElement::isAttributeSettable):
179         (AccessibilityUIElement::isAttributeSupported):
180         (AccessibilityUIElement::role):
181         (AccessibilityUIElement::subrole):
182         (AccessibilityUIElement::roleDescription):
183         (AccessibilityUIElement::title):
184         (AccessibilityUIElement::description):
185         (AccessibilityUIElement::orientation):
186         (AccessibilityUIElement::stringValue):
187         (AccessibilityUIElement::language):
188         (AccessibilityUIElement::helpText):
189         (AccessibilityUIElement::x):
190         (AccessibilityUIElement::y):
191         (AccessibilityUIElement::width):
192         (AccessibilityUIElement::height):
193         (AccessibilityUIElement::clickPointX):
194         (AccessibilityUIElement::clickPointY):
195         (AccessibilityUIElement::intValue):
196         (AccessibilityUIElement::minValue):
197         (AccessibilityUIElement::maxValue):
198         (AccessibilityUIElement::valueDescription):
199         (AccessibilityUIElement::insertionPointLineNumber):
200         (AccessibilityUIElement::isActionSupported):
201         (AccessibilityUIElement::isEnabled):
202         (AccessibilityUIElement::isRequired):
203         (AccessibilityUIElement::isSelected):
204         (AccessibilityUIElement::isExpanded):
205         (AccessibilityUIElement::hierarchicalLevel):
206         (AccessibilityUIElement::ariaIsGrabbed):
207         (AccessibilityUIElement::ariaDropEffects):
208         (AccessibilityUIElement::lineForIndex):
209         (AccessibilityUIElement::boundsForRange):
210         (AccessibilityUIElement::stringForRange):
211         (AccessibilityUIElement::attributesOfColumnHeaders):
212         (AccessibilityUIElement::attributesOfRowHeaders):
213         (AccessibilityUIElement::attributesOfColumns):
214         (AccessibilityUIElement::attributesOfRows):
215         (AccessibilityUIElement::attributesOfVisibleCells):
216         (AccessibilityUIElement::attributesOfHeader):
217         (AccessibilityUIElement::rowCount):
218         (AccessibilityUIElement::columnCount):
219         (AccessibilityUIElement::indexInTable):
220         (AccessibilityUIElement::rowIndexRange):
221         (AccessibilityUIElement::columnIndexRange):
222         (AccessibilityUIElement::cellForColumnAndRow):
223         (AccessibilityUIElement::selectedTextRange):
224         (AccessibilityUIElement::setSelectedTextRange):
225         (AccessibilityUIElement::increment):
226         (AccessibilityUIElement::decrement):
227         (AccessibilityUIElement::showMenu):
228         (AccessibilityUIElement::press):
229         (AccessibilityUIElement::url):
230         (AccessibilityUIElement::hasPopup):
231
232 2010-05-28  Yael Aharon  <yael.aharon@nokia.com>
233
234         Reviewed by Laszlo Gombos.
235
236         [Qt] Pass all web notification layout tests
237         https://bugs.webkit.org/show_bug.cgi?id=39146
238
239         Mimic Chromium's test_shell security model in Qt's DRT.
240         It makes a list of origins which were granted permission to display
241         notifications, and only those origins can display notifications.
242
243         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
244         (WebCore::checkPermissionCallback):
245         (WebCore::requestPermissionCallback):
246         (WebCore::WebPage::WebPage):
247         (WebCore::DumpRenderTree::checkPermission):
248         (WebCore::DumpRenderTree::requestPermission):
249         * DumpRenderTree/qt/DumpRenderTreeQt.h:
250         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
251         (LayoutTestController::reset):
252         (LayoutTestController::grantDesktopNotificationPermission):
253         (LayoutTestController::checkDesktopNotificationPermission):
254         * DumpRenderTree/qt/LayoutTestControllerQt.h:
255
256 2010-05-27  Philippe Normand  <pnormand@igalia.com>
257
258         Reviewed by Shinichiro Hamaji.
259
260         check-webkit-style complains about use of NULL in GTK function calls that require sentinels
261         https://bugs.webkit.org/show_bug.cgi?id=39372
262
263         Don't warn about NULL in g_*() calls. Zero can't be used instead
264         for calls like g_build_filename and g_object_get/set.
265
266         * Scripts/webkitpy/style/checkers/cpp.py:
267         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
268
269 2010-05-27  Luiz Agostini  <luiz.agostini@openbossa.org>
270
271         Reviewed by Kenneth Rohde Christiansen.
272
273         [Qt] Platform plugin example
274         https://bugs.webkit.org/show_bug.cgi?id=39489
275
276         Exempting directory WebKit/qt/examples/ from style guide.
277
278         * Scripts/webkitpy/style/checker.py:
279
280 2010-05-26  Philippe Normand  <pnormand@igalia.com>
281
282         Reviewed by David Levin.
283
284         [style] Allow usage of NULL in gst_*_many()
285         https://bugs.webkit.org/show_bug.cgi?id=39740
286
287         Don't warn if NULL is used by gst_*_many() functions. Zero can't
288         be used for the reason explained in Bug 32858.
289
290         * Scripts/webkitpy/style/checkers/cpp.py:
291         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
292
293 2010-05-27  Adam Barth  <abarth@webkit.org>
294
295         Reviewed by Eric Seidel.
296
297         Update script to run the normal version of the parser tests.
298
299         * Scripts/test-html5-parser:
300
301 2010-05-27  Adam Barth  <abarth@webkit.org>
302
303         Reviewed by Eric Seidel.
304
305         Add HTML5 parser support to run-webkit-tests
306         https://bugs.webkit.org/show_bug.cgi?id=39815
307
308         * Scripts/old-run-webkit-tests:
309
310 2010-05-26  Adam Barth  <abarth@webkit.org>
311
312         Reviewed by Eric Seidel.
313
314         Make HTML5 lexer not ASSERT when resuming partial parses
315         https://bugs.webkit.org/show_bug.cgi?id=39755
316
317         Add webkit-resumer.html to the HTML5 parser test suite.
318
319         * Scripts/test-html5-parser:
320
321 2010-05-24  Tony Chang  <tony@chromium.org>
322
323         Reviewed by Kent Tamura.
324
325         [chromium] setup fonts on chromium linux DRT
326         https://bugs.webkit.org/show_bug.cgi?id=39644
327
328         * DumpRenderTree/chromium/TestShellGtk.cpp:
329         (setupFontconfig):
330         (platformInit):
331         * DumpRenderTree/chromium/WebViewHost.cpp:
332         (WebViewHost::paintRect):  Fix a bug where in release builds, we didn't initialize m_canvas.
333         * DumpRenderTree/chromium/fonts.conf: Added.
334
335 2010-05-24  Dirk Pranke  <dpranke@chromium.org>
336
337         Reviewed by Dimitri Glazkov.
338
339         Re-commit r58765 - it had been rolled out to see if it was causing
340         a perf regression (in r59787 and r59789), but that does not seem to
341         have been the case.
342
343         https://bugs.webkit.org/show_bug.cgi?id=39605
344
345         * DumpRenderTree/chromium/NotificationPresenter.cpp:
346         (NotificationPresenter::show):
347
348 2010-05-25  Ojan Vafai  <ojan@chromium.org>
349
350         Reviewed by Chris Jerdonek.
351
352         remove suppression of rietveld logging
353         https://bugs.webkit.org/show_bug.cgi?id=39693
354
355         Now that we only upload to rietveld explicitly, e.g. on the bot
356         or via webkit-patch post-attachment-to-rietveld, we should print
357         all the rietveld logging. It was suppressed before to avoid making
358         webkit-patch upload too noisy.
359
360         * Scripts/webkitpy/common/net/rietveld.py:
361
362 2010-05-25  Antonio Gomes  <tonikitoo@webkit.org>
363
364         Reviewed by Ojan Vafai.
365
366         [Qt] Expose the editing behavior setting in DRT to test all editing code paths
367         https://bugs.webkit.org/show_bug.cgi?id=39680
368
369         Implement LayoutTestController::setEditingBehavior in Qt's DRT.
370
371         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
372         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
373         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
374         (LayoutTestController::setEditingBehavior):
375
376 2010-05-25  Kevin Ollivier  <kevino@theolliviers.com>
377
378         [wx] Build fix after API change and addition of WebCore/platform/text/transcoder dir. 
379
380         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
381         (LayoutTestController::setEditingBehavior):
382         * wx/build/settings.py:
383
384 2010-05-24  Antonio Gomes  <tonikitoo@webkit.org>
385
386         Reviewed by Eric Seidel and Kent Tamura (for the Chromium part).
387
388         editingBehavior settings needs to be set back to a reasonable default between tests
389         https://bugs.webkit.org/show_bug.cgi?id=39433
390
391         Similarly to r59861, hard code the default setting during reset for Gtk and Chromium,
392         so that the serialized version of the setting stays in sync with expectations.
393
394         * DumpRenderTree/chromium/TestShell.cpp:
395         (TestShell::resetWebSettings):
396         * DumpRenderTree/gtk/DumpRenderTree.cpp:
397         (resetDefaultsToConsistentValues):
398
399 2010-05-24  Eric Seidel  <eric@webkit.org>
400
401         Reviewed by Adam Barth.
402
403         webkit-patch land calls scm.changed_files 4 times!
404         https://bugs.webkit.org/show_bug.cgi?id=39584
405
406         * Scripts/webkitpy/tool/commands/download_unittest.py:
407          - Assert that we don't call modified_changelogs too often.
408         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
409          - Use cached changelogs list instead of calling modified_changelogs directly.
410         * Scripts/webkitpy/tool/steps/validatereviewer.py:
411          - ditto.
412
413 2010-05-24  Kent Tamura  <tkent@chromium.org>
414
415         Reviewed by Dimitri Glazkov.
416
417         [DRT/Chromium] Import layout_test_helper for Windows
418         https://bugs.webkit.org/show_bug.cgi?id=39581
419
420         Import Chromium win/layout_test_helper.cc as LayoutTestHelperWin.cpp.
421         http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/win/layout_test_helper.cc
422
423         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Added.
424
425 2010-05-24  Kent Tamura  <tkent@chromium.org>
426
427         Reviewed by Dimitri Glazkov.
428
429         [DRT/Chromium] Reset frame name
430         https://bugs.webkit.org/show_bug.cgi?id=39586
431
432         This change fixes about 70 unexpected results.
433
434         * DumpRenderTree/chromium/WebViewHost.cpp:
435         (WebViewHost::reset):
436
437 2010-05-24  Marcus Bulach  <bulach@chromium.org>
438
439         Reviewed by Kent Tamura.
440
441         [chromium] Adds WebGeolocationServiceMockImpl to remove public dependency on wtf/HashMap.h
442         https://bugs.webkit.org/show_bug.cgi?id=39587
443
444         * DumpRenderTree/chromium/WebViewHost.cpp:
445         (WebViewHost::geolocationService):
446
447 2010-05-24  Robert Hogan  <robert@webkit.org>
448
449         Reviewed by Laszlo Gombos.
450
451         [Qt] DRT Support for removeOriginAccessWhitelistEntry
452
453         Unskips http/tests/xmlhttprequest/origin-whitelisting-removal.html
454
455         [Qt] DRT Support for removeOriginAccessWhitelistEntry
456         https://bugs.webkit.org/show_bug.cgi?id=39565
457
458         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
459         (LayoutTestController::removeOriginAccessWhitelistEntry):
460
461 2010-05-24  Marcus Bulach  <bulach@google.com>
462
463         Reviewed by Ojan Vafai.
464
465         _svn_branch_has_extra_commits needs to check for ^HEAD instead of ^head.
466         https://bugs.webkit.org/show_bug.cgi?id=39603
467
468         * Scripts/webkitpy/common/checkout/scm.py:
469
470 == Rolled over to ChangeLog-2010-05-24 ==