c46bc0a9abb49429ec843d0bc8f34237ee1d19af
[WebKit-https.git] / WebKitTools / ChangeLog
1 2008-12-03  Adam Roben  <aroben@apple.com>
2
3         Add a Debug_Internal configuration to WinLauncher
4
5         This matches our other projects.
6
7         Reviewed by Sam Weinig.
8
9         * WinLauncher/WinLauncher.vcproj: Added a Debug_Internal
10         configuration, which is identical to Debug except that it also
11         references debug_internal.vsprops. Also removed some settings that we
12         should be picking up from the .vsprops files.
13
14 2008-12-02  Eric Seidel  <eric@webkit.org>
15
16         Reviewed by David Kilzer.
17
18         Hack build-webkit --chromium to use Win32 python instead
19         of using the default cygwin python.  Scons + CYGWIN tries
20         to build with GCC by default, we force MSVC in our file
21         but that just results in errors from Scons.  Until we can fix
22         this latest round of errors, at least make build-webkit --chromium
23         actually "work" under CYGWIN instead of forcing users to use
24         a cmd shell directly.
25         
26         This is working around a Scons bug:
27         http://scons.tigris.org/issues/show_bug.cgi?id=2266
28
29         * Scripts/webkitdirs.pm:
30
31 2008-12-01  David Kilzer  <ddkilzer@apple.com>
32
33         Bug 22466: REGRESSION (35867): Many resources missing when saving webarchive of webkit.org
34
35         <https://bugs.webkit.org/show_bug.cgi?id=22466>
36         <rdar://problem/6403593>
37
38         Reviewed by Brady Eidson.
39
40         * DumpRenderTree/mac/DumpRenderTree.mm:
41         (normalizeHTTPResponseHeaderFields): Added.  Normalizes Date, Etag,
42         Keep-Alive, Last-Modified and Server header fields to prevent false
43         positive test failures.
44         (convertWebResourceResponseToDictionary): Call
45         normalizeHTTPResponseHeaderFields() to noramlize HTTP response
46         header fields.
47
48 2008-12-01  David D. Kilzer  <ddkilzer@webkit.org>
49
50         Bug 22559: Report builds left to test in bisect-builds (like git-bisect)
51
52         <https://bugs.webkit.org/show_bug.cgi?id=22559>
53
54         Reviewed by Adam Roben.
55
56         * Scripts/bisect-builds: Updated status message to report the
57         maximum number of builds left to test after the current one.
58         (max): Added.
59
60 2008-11-27  Alp Toker  <alp@nuanti.com>
61
62         Build GtkLauncher and minidom with the '-ansi' compiler flag to detect
63         API header breakage at build time.
64
65         * GNUmakefile.am:
66
67 2008-11-26  Eric Seidel  <eric@webkit.org>
68
69         Reviewed by Nikolas Zimmermann and Mark Rowe.
70         
71         Add support for build-webkit --chromium
72         https://bugs.webkit.org/show_bug.cgi?id=22515
73         More cleanups changing isCygwin calls to isAppleWinWebKit and deploying isAppleWebKit where necessary.
74
75         * Scripts/build-dumprendertree:
76         * Scripts/build-jsc:
77         * Scripts/build-webkit:
78         * Scripts/gdb-safari:
79         * Scripts/run-webkit-tests:
80         * Scripts/webkitdirs.pm:
81
82 2008-11-26  Eric Seidel  <eric@webkit.org>
83
84         Reviewed by Nikolas Zimmermann.
85
86         Add support for build-webkit --chromium (tested on mac)
87         https://bugs.webkit.org/show_bug.cgi?id=22515
88         Also simplified some code using checkArgv
89
90         * Scripts/build-webkit:
91         * Scripts/webkitdirs.pm:
92
93 2008-11-26  Eric Seidel  <eric@webkit.org>
94
95         Reviewed by Nikolas Zimmermann.
96
97         More pre-work for adding a build-webkit --chromium which works on Mac and Windows
98         https://bugs.webkit.org/show_bug.cgi?id=22515
99         Change a few calls to isCygwin to isAppleWinWebKit and a few calls to isAppleMacWebKit to isDarwin
100         in preparation for having a chromium cygwin and chromium mac build
101
102         * Scripts/build-webkit:
103         * Scripts/webkitdirs.pm:
104
105 2008-11-26  Eric Seidel  <eric@webkit.org>
106
107         Reviewed by Nikolas Zimmermann.
108
109         Pre-work for getting build-webkit --chromium to work
110         https://bugs.webkit.org/show_bug.cgi?id=22515
111         Rename isOSX to isAppleMacWebKit to match what the code does, and add isChromium()
112
113         * Scripts/build-dumprendertree:
114         * Scripts/build-jsc:
115         * Scripts/build-webkit:
116         * Scripts/gdb-safari:
117         * Scripts/run-javascriptcore-tests:
118         * Scripts/run-webkit-tests:
119         * Scripts/webkitdirs.pm:
120
121 2008-11-26  David Kilzer  <ddkilzer@apple.com>
122
123         Bug 22488: Make DRT smarter about charset encoding when post-processing webarchive content
124
125         <https://bugs.webkit.org/show_bug.cgi?id=22488>
126
127         Reviewed by Brady Eidson.
128
129         * DumpRenderTree/mac/DumpRenderTree.mm:
130         (convertWebResourceDataToString): If an IANA charset encoding string
131         is provided, convert it to a CFStringEncoding value and then to an
132         NSStringEncoding value, else fall back to NSUTF8StringEncoding.  We
133         also nil-check dataAsString, so the worst-case scenario is that the
134         data won't be decoded to a string (versus crashing DumpRenderTree).
135
136 2008-11-26  Jan Michael Alonzo  <jmalonzo@webkit.org>
137
138         Reviewed by Holger Freyther.
139
140         [Gtk] add/remove tests from Skipped and fix netscape plugin test
141         https://bugs.webkit.org/show_bug.cgi?id=22484
142
143         Remove print'ing to stderr
144
145         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
146         (NP_Initialize):
147         (NP_Shutdown):
148
149 2008-11-25  Steve Falkenburg  <sfalken@apple.com>
150
151         Windows build fix.
152
153         * DumpRenderTree/cg/PixelDumpSupportCG.h:
154
155 2008-11-25  Steve Falkenburg  <sfalken@apple.com>
156
157         Windows build fix.
158
159         * DumpRenderTree/cg/ImageDiffCG.cpp:
160
161 2008-11-24  Darin Fisher  <darin@chromium.org>
162
163         Fix bustage.
164
165         https://bugs.webkit.org/show_bug.cgi?id=15643
166
167         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
168         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
169
170 2008-11-24  Glenn Wilson  <gwilson@chromium.org>
171
172         Reviewed by Alexey Proskuryakov.
173
174         http://bugs.webkit.org/show_bug.cgi?id=15643
175
176         Added support for changing the "trailing whitespace" work-around
177         in LayoutTestController (so layout tests can verify this functionality)
178
179         * DumpRenderTree/LayoutTestController.cpp:
180         (setSelectTrailingWhitespaceEnabledCallback):
181         (LayoutTestController::staticFunctions):
182         * DumpRenderTree/LayoutTestController.h:
183         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
184         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
185         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
186         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
187
188 2008-11-24  Simon Fraser  <simon.fraser@apple.com>
189
190         Reviewed by Darin Adler
191
192         https://bugs.webkit.org/show_bug.cgi?id=22433
193         
194         Add script that attempts to detect virtual methods
195         whose signatures differ only by constness (which can
196         indicate a programming error).
197         
198         * Scripts/detect-mismatched-virtual-const: Added.
199
200 2008-11-24  Zan Dobersek  <zandobersek@gmail.com>
201
202         Reviewed by Holger Freyther.
203
204         https://bugs.webkit.org/show_bug.cgi?id=22039
205
206         [Gtk+] Implement TestNetscapePlugin for Gtk+ port and add it to the
207         build.
208
209         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
210         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
211         * DumpRenderTree/gtk/DumpRenderTree.cpp:
212         (setDefaultsToConsistentStateValuesForTesting):
213         * DumpRenderTree/gtk/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h: Added.
214         * DumpRenderTree/gtk/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h: Added.
215         * DumpRenderTree/gtk/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h: Added.
216         * GNUmakefile.am:
217
218 2008-11-24  Holger Hans Peter Freyther  <zecke@selfish.org>
219
220         Reviewed by Mark Rowe.
221
222         [Gtk+] Add configure option to enable Web Workers and enable it by default
223
224         Add --enable-workers to the buildsystem (used by build-webkit) add
225         the to be build files to the GNUmakefile.am and change build-webkit
226         to enable Web Workers by default.
227
228         * Scripts/build-webkit:
229
230 2008-11-24  Mark Rowe  <mrowe@apple.com>
231
232         Reviewed by Alexey Proskuryakov.
233
234         Let gdb-safari accept the --debug and --release options once more.
235
236         * Scripts/gdb-safari:
237
238 2008-11-23  Zan Dobersek  <zandobersek@gmail.com>
239
240         Reviewed by Holger Freyther. Landed by Jan Alonzo.
241
242         Get SVG tests tested on GTK port.
243
244         * Scripts/webkitdirs.pm:
245
246 2008-11-19  Greg Bolsinga  <bolsinga@apple.com>
247
248         Reviewed by Darin Adler.
249
250         https://bugs.webkit.org/show_bug.cgi?id=21810
251         Remove use of static C++ objects that are destroyed at exit time (destructors)
252
253         All static C++ objects that create atexit calls are gone. Update script
254         to indicate how to fix the problem should a new one appear.
255         
256         * Scripts/check-for-exit-time-destructors:
257
258 2008-11-18  Alexey Proskuryakov  <ap@webkit.org>
259
260         Reviewed by Darin Adler.
261
262         https://bugs.webkit.org/show_bug.cgi?id=22337
263         Enable workers by default
264
265         * Scripts/build-webkit: Changed the default to enabled.
266
267 2008-11-18  Alexey Proskuryakov  <ap@webkit.org>
268
269         Rubber-stamped by Darin Adler.
270
271         https://bugs.webkit.org/show_bug.cgi?id=22306
272         Disable channel messaging support
273
274         * Scripts/build-webkit: Add an option to enable channel messaging.
275
276 2008-11-17  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
277
278         Reviewed by George Staikos.
279
280         Add --(no-)wml build flags.
281
282         * Scripts/build-webkit:
283         * Scripts/run-webkit-tests:
284         * Scripts/webkitdirs.pm:
285
286 2008-11-17  Geoffrey Garen  <ggaren@apple.com>
287
288         Not reviewed.
289         
290         Try to fix gtk build.
291
292         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
293         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
294         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
295
296 2008-11-17  Pierre-Olivier Latour  <pol@apple.com>
297
298         Reviewed by Maciej.
299
300         Pixel tests should use a default tolerance of 0.1% on Leopard and 1.0%
301         on Tiger.
302
303         https://bugs.webkit.org/show_bug.cgi?id=22271
304
305         * Scripts/run-webkit-tests:
306
307 2008-11-17  Pierre-Olivier Latour  <pol@apple.com>
308
309         Reviewed by Sam Weinig.
310
311         Added new JavaScript API on LayoutController to pause a running
312         CSS transition or animation at a given time.
313
314         https://bugs.webkit.org/show_bug.cgi?id=21261
315
316         * DumpRenderTree/LayoutTestController.cpp:
317         (pauseAnimationAtTimeOnElementWithIdCallback):
318         (pauseTransitionAtTimeOnElementWithIdCallback):
319         (LayoutTestController::staticFunctions):
320         * DumpRenderTree/LayoutTestController.h:
321         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
322         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
323         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
324         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
325         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
326         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
327
328 2008-11-17  Gabor Loki  <loki@inf.u-szeged.hu>
329
330         Reviewed by Darin Adler.
331
332         <https://bugs.webkit.org/show_bug.cgi?id=22309>
333         Pass the remaining options to build system on Qt-port
334
335         * Scripts/build-webkit:
336         * Scripts/webkitdirs.pm:
337
338 2008-11-16  Greg Bolsinga  <bolsinga@apple.com>
339
340         Reviewed by Darin Adler.
341
342         https://bugs.webkit.org/show_bug.cgi?id=21810
343         Remove use of static C++ objects that are destroyed at exit time (destructors)
344
345         Remove .o files from the exclude list that have had their exit-time destructors removed.
346         Handle case when there is no current symbol.
347         
348         * Scripts/check-for-exit-time-destructors:
349
350 2008-11-16  Sam Weinig  <sam@webkit.org>
351
352         * Scripts/do-webcore-rename: Remove now fixed renames.
353
354 2008-11-16  Darin Adler  <darin@apple.com>
355
356         * Scripts/do-webcore-rename: Plan some future renames.
357
358 2008-11-15  Darin Adler  <darin@apple.com>
359
360         Rubber stamped by Geoff Garen.
361
362         - do the long-planned StructureID -> Structure rename
363
364         * Scripts/check-for-global-initializers: Update name of StructureID.o.
365         * Scripts/do-webcore-rename: Renaming script that I used.
366
367 2008-11-15  Greg Bolsinga  <bolsinga@apple.com>
368
369         Reviewed by Darin Adler.
370
371         https://bugs.webkit.org/show_bug.cgi?id=21810
372         Remove use of static C++ objects that are destroyed at exit time (destructors)
373
374         Create DEFINE_STATIC_LOCAL macro. Change static local objects to leak to avoid 
375         exit-time destructor. Update code that was changed to fix this issue that ran 
376         into a gcc bug (<rdar://problem/6354696> Codegen issue with C++ static reference 
377         in gcc build 5465). Also typdefs for template types needed to be added in some 
378         cases so the type could make it through the macro successfully.
379
380         Basically code of the form:
381         static T m;
382         becomes:
383         DEFINE_STATIC_LOCAL(T, m, ());
384
385         Also any code of the form:
386         static T& m = *new T;
387         also becomes:
388         DEFINE_STATIC_LOCAL(T, m, ());
389
390         Remove .o files from the exclude list that have had their exit-time destructors removed.
391         
392         * Scripts/check-for-exit-time-destructors:
393
394 2008-11-14  Kevin Ollivier  <kevino@theolliviers.com>
395
396         wx mac buildbot fix. Also, make sure we don't keep hitting this problem.
397
398         * wx/install-unix-extras:
399
400 2008-11-14  Alp Toker  <alp@nuanti.com>
401
402         GTK DRT build fix for gcc 4.4 snapshot. Add missing stdio include.
403
404         Fixes Debian bug #505723
405         http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=505723
406
407         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
408
409 2008-11-14  Krishna <krishnamurty.podipireddy@nokia.com>
410
411         Reviewed by Simon Hausmann.
412
413         Fix hanging DRT with Qt.
414
415         https://bugs.webkit.org/show_bug.cgi?id=22209
416
417         * DumpRenderTree/qt/DumpRenderTree.cpp:
418         (WebCore::DumpRenderTree::dump):
419         Send empty pixel test data 'block', which is now
420         expected by run-layout-tests.
421
422 2008-11-12  Dmitry Titov  <dimich@chromium.org>
423
424         Reviewed by Alexey Proskuryakov.
425
426         https://bugs.webkit.org/show_bug.cgi?id=22216
427
428         * Scripts/build-webkit:
429         Addes ENABLE_WORKERS to build-webkit so it's possible to build with workers enabled.
430
431 2008-11-06  David Kilzer  <ddkilzer@apple.com>
432
433         BUILD FIX: Backed out r38189 (and r38203) for Xcode 3.0.
434
435         Apparently older versions of gcc have issues with this patch.
436         Backing out a second time until the issues are resolved.
437
438 2008-11-06  David Kilzer  <ddkilzer@apple.com>
439
440         BUILD WAS NOT BROKEN: Rolling r38189 back in.
441
442         Please perform a clean build if you see crashes.
443
444 2008-11-06  David Kilzer  <ddkilzer@apple.com>
445
446         BUILD FIX: Backed out r38189 since it apparently broke the world.
447
448 2008-11-06  Chris Fleizach  <cfleizach@apple.com>
449
450         Reviewed by Beth Dakin.
451
452         Add ability to query an attribute's settable status and the
453         ability to retrieve a single attribute from an AXObject
454
455         * DumpRenderTree/AccessibilityUIElement.cpp:
456         (isAttributeSettableCallback):
457         (attributeValueCallback):
458         (AccessibilityUIElement::getJSClass):
459         * DumpRenderTree/AccessibilityUIElement.h:
460         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
461         (+[NSString stringWithJSStringRef:]):
462         (AccessibilityUIElement::attributeValue):
463         (AccessibilityUIElement::isAttributeSettable):
464         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
465         (AccessibilityUIElement::attributeValue):
466         (AccessibilityUIElement::isAttributeSettable):
467
468 2008-11-06  Greg Bolsinga  <bolsinga@apple.com>
469
470         Reviewed by Darin Adler.
471         
472         Bug 21810: Remove use of static C++ objects that are destroyed at exit time (destructors)
473         https://bugs.webkit.org/show_bug.cgi?id=21810
474         
475         Remove .o files from the exclude list that have had their exit-time destructors removed.
476
477         * Scripts/check-for-exit-time-destructors:
478
479 2008-11-05  Alp Toker  <alp@nuanti.com>
480
481         GTK build script tweak.
482
483         Make the path relative since it will appear in all -I compiler flags.
484         Long argument lists cause bizarre slowdowns in libtool and result
485         in huge build logs.
486
487         * Scripts/webkitdirs.pm:
488
489 2008-11-05  Anders Carlsson  <andersca@apple.com>
490
491         Fix 64-bit build.
492
493         * DumpRenderTree/mac/DumpRenderTree.mm:
494         (setDefaultsToConsistentValuesForTesting):
495
496 2008-11-04  Simon Fraser  <simon.fraser@apple.com>
497
498         Add AccessibilityObject.o to the exclude list for the
499         check for global destructors.
500         
501         * Scripts/check-for-exit-time-destructors:
502
503 2008-11-04  Darin Adler  <darin@apple.com>
504
505         * Scripts/check-for-exit-time-destructors: Fix failures seen on the
506         bot, but for some reason not on my computer.
507
508 2008-11-03  Darin Adler  <darin@apple.com>
509
510         Reviewed by Tim Hatcher.
511
512         - https://bugs.webkit.org/show_bug.cgi?id=22061
513           create script to check for exit-time destructors
514
515         * Scripts/check-for-exit-time-destructors: Added.
516         Started as a copy of check-for-global-initializers.
517
518         * Scripts/check-for-global-initializers: Added code to make
519         this script rerun any time it's modified, and also to properly
520         run again after the first time it reports an error.
521
522 2008-11-03  Pierre-Olivier Latour  <pol@apple.com>
523
524         Reviewed by Dan Bernstein.
525
526         Fixed the override of the "AppleScrollBarVariant" system setting to also work with HIToolbox.
527
528         https://bugs.webkit.org/show_bug.cgi?id=22054
529
530         * DumpRenderTree/mac/DumpRenderTree.mm:
531         (setDefaultsToConsistentValuesForTesting):
532
533 2008-10-31  Cameron Zwarich  <zwarich@apple.com>
534
535         Not reviewed.
536
537         * Scripts/do-webcore-rename:
538
539         Add some renames to contemplate for the future.
540
541 2008-10-31  Darin Adler  <darin@apple.com>
542
543         Requested by Mark Rowe.
544
545         * Scripts/check-for-global-initializers: s/Web Kit/WebKit/.
546
547 2008-10-31  David Kilzer  <ddkilzer@apple.com>
548
549         Bug 21997: prepare-ChangeLog should filter out ChangeLog files
550
551         <https://bugs.webkit.org/show_bug.cgi?id=21997>
552
553         Reviewed by Darin Adler.
554
555         * Scripts/prepare-ChangeLog:
556         (generateFileList): Don't add ChangeLog files to %{$functionLists}.
557         This prevents them from showing up in the new ChangeLog entry.  They
558         were already excluded from @{$changedFiles}.
559
560 2008-10-30  Mark Rowe  <mrowe@apple.com>
561
562         Reviewed by Jon Homeycutt.
563
564         Explicitly default to building for only the native architecture in debug and release builds.
565
566         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
567
568 2008-10-30  Pierre-Olivier Latour  <pol@apple.com>
569
570         Reviewed by Dan Bernstein.
571
572         Fixed 64 bit build failure.
573
574         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
575         (setupMainDisplayColorProfile):
576         (createBitmapContextFromWebView):
577
578 2008-10-28  Alp Toker  <alp@nuanti.com>
579
580         Fix GTK DRT following build breakage in r37928.
581
582         * DumpRenderTree/gtk/DumpRenderTree.cpp:
583         (dump):
584         (runTest):
585         (main):
586
587 2008-10-28  Alp Toker  <alp@nuanti.com>
588
589         Reviewed by Mark Rowe.
590
591         Fix recently introduced double-free crashes in GTK DRT.
592
593         LayoutTestController was made ref-counted in r36606 and Mac/Win DRT
594         were updated to call ->deref() but GTK DRT was still deleting
595         gLayoutTestController manually. This patch updates GTK to match the
596         other ports and resolves the memory allocation issues.
597
598         * DumpRenderTree/gtk/DumpRenderTree.cpp:
599         (runTest):
600
601 2008-10-28  Alp Toker  <alp@nuanti.com>
602
603         Reviewed by Mark Rowe.
604
605         Fix GTK DRT hang when running the tests.
606
607         Update output from the DRT tool to print an additional '#EOF' to match
608         breaking changes that were made in r37434.
609
610         * DumpRenderTree/gtk/DumpRenderTree.cpp:
611         (dump):
612
613 2008-10-28  Adele Peterson  <adele@apple.com>
614
615         Reviewed by Sam Weinig. 
616
617         Specify which Localizable.strings to update since we don't always want to update the file in the same
618         directory where we're searching for the strings to localize.
619         
620         * Scripts/extract-localizable-strings:
621         * Scripts/update-webkit-localizable-strings:
622
623 2008-10-28  Timothy Hatcher  <timothy@apple.com>
624
625         Add support for enabling the profiler, so the profiling tests can continue
626         work now that the profiler is not always enabled.
627
628         https://bugs.webkit.org/show_bug.cgi?id=21927
629
630         <rdar://problem/6211578> Make the JavaScript profiler opt-in, so it does
631         not slow down JavaScript all the time
632
633         Reviewed by Darin Adler and Kevin McCullough.
634
635         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Make the editor use spaces.
636         * DumpRenderTree/LayoutTestController.cpp:
637         (setJavaScriptProfilingEnabledCallback): Added. Calls LayoutTestController::setJavaScriptProfilingEnabled.
638         (LayoutTestController::staticFunctions): Added setJavaScriptProfilingEnabled to the script class.
639         * DumpRenderTree/LayoutTestController.h:
640         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
641         (LayoutTestController::setJavaScriptProfilingEnabled): Stubbed out with a FIXME.
642         * DumpRenderTree/mac/DumpRenderTree.mm:
643         (resetWebViewToConsistentStateBeforeTesting): Disables the developer extras and disables the profiler.
644         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
645         (LayoutTestController::setJavaScriptProfilingEnabled): Toggles the developer extras and profiler.
646         * DumpRenderTree/win/DumpRenderTree.cpp:
647         (resetWebViewToConsistentStateBeforeTesting): Disables the developer extras and disables the profiler.
648         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
649         (LayoutTestController::setJavaScriptProfilingEnabled): Toggles the developer extras and profiler.
650
651 2008-10-28  Pierre-Olivier Latour  <pol@apple.com>
652
653         Reviewed by Dan Bernstein
654
655         Primary changes in DumpRenderTree:
656         - Ensure font smoothing is disabled (this is also called LCD anti-aliasing and
657         is different from regular font CG anti-aliasing) as font-smoothing settings
658         depends on the display and can also be changed by the user
659         - Use a new cleared buffer for each test instead of the reusing same one to
660         avoid potential result corruption across tests
661         - Can now receive the expected pixel hash as a suffix to the test path or
662         url as "path'hash"
663         - Make sure hash is computed in a endian-independent way
664         - Improve the code that sets/restores the screen color profile
665         - Make the code more cross-platformy with std::string goodness
666         - Added an "on-screen" mode where the snapshot will take into account surfaces
667         on the window (like OpenGL content): this uses the new CG APIs on 10.5 or
668         reading from the display framebuffer on 10.4. This mode is not active by
669         default for performance reason, but must be explicitly activated from the test
670         file using the new "testOnscreen()" JS API.
671
672         Primary changes in ImageDiff:
673         - Provide a new comparison algorithm that is more tolerant to "acceptable"
674         failures (i.e. very small differences in font rendering, which --threshold is
675         not really good at handling)
676         - Generate normalized intensity-only diff images
677
678         Primary changes in run-webkit-tests:
679         - Take advantage of hashes for pixel tests which makes them much faster by
680         minimizing image comparisons
681         - Removed repaint options as these should be set from within test files using
682         JS API
683         - Replaced "threshold" option in  by "tolerance" expressed in percents
684         - Added more logging when in "verbose" mode
685
686         https://bugs.webkit.org/show_bug.cgi?id=21322
687         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
688         * DumpRenderTree/ForwardingHeaders/wtf/PassRefPtr.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/PassRefPtr.h.
689         * DumpRenderTree/ForwardingHeaders/wtf/RefPtr.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/RefPtr.h.
690         * DumpRenderTree/LayoutTestController.cpp:
691         (LayoutTestController::LayoutTestController):
692         (testOnscreenCallback):
693         (LayoutTestController::staticFunctions):
694         * DumpRenderTree/LayoutTestController.h:
695         (LayoutTestController::testOnscreen):
696         (LayoutTestController::setTestOnscreen):
697         (LayoutTestController::testPathOrURL):
698         (LayoutTestController::expectedPixelHash):
699         * DumpRenderTree/PixelDumpSupport.h:
700         * DumpRenderTree/cg/ImageDiffCG.cpp:
701         (strtof):
702         (releaseMallocBuffer):
703         (createDifferenceImage):
704         (imageHasAlpha):
705         (main):
706         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
707         (computeMD5HashStringForBitmapContext):
708         (dumpWebViewAsPixelsAndCompareWithExpected):
709         * DumpRenderTree/cg/PixelDumpSupportCG.h:
710         (BitmapContext::createByAdoptingBitmapAndContext):
711         (BitmapContext::~BitmapContext):
712         (BitmapContext::cgContext):
713         (BitmapContext::BitmapContext):
714         * DumpRenderTree/mac/DumpRenderTree.mm:
715         (shouldIgnoreWebCoreNodeLeaks):
716         (setDefaultsToConsistentValuesForTesting):
717         (crashHandler):
718         (initializeGlobalsFromCommandLineOptions):
719         (prepareConsistentTestingEnvironment):
720         (dumpRenderTree):
721         (sizeWebViewForCurrentTest):
722         (dump):
723         (runTest):
724         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
725         (restoreMainDisplayColorProfile):
726         (setupMainDisplayColorProfile):
727         (createBitmapContextFromWebView):
728         * DumpRenderTree/win/DumpRenderTree.cpp:
729         (dump):
730         (runTest):
731         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
732         (getBitmapContextFromWebView):
733         * Scripts/run-webkit-tests:
734
735 2008-10-27  Kevin Ollivier  <kevino@theolliviers.com>
736
737         wx build fix on Linux/GTK. Enable support for #include <JavaScriptCore/XYZ.h> style includes.
738
739         * wx/build-wxwebkit:
740
741 2008-10-24  Anders Carlsson  <andersca@apple.com>
742
743         Try fixing the 64-bit build.
744         
745         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
746         (testGetProperty):
747
748 2008-10-24  Anders Carlsson  <andersca@apple.com>
749
750         Reviewed by Sam Weinig.
751         
752         <rdar://problem/5440917> Support NPN_Construct
753         
754         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
755         (testCallback):
756         Fix a memory leak.
757         
758         (testConstruct):
759         New test method that treats it first argument as a constructor and invokes it with the rest of the arguments.
760         
761         (pluginInvoke):
762         Handle testConstruct.
763         
764         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
765         (testGetProperty):
766         Add objectPointer property.
767         
768         (testEnumerate):
769         Only enumerate the two first properties.
770         
771         (testConstruct):
772         Add a simple construct implementation that just returns the test object.
773
774 2008-10-24  David Kilzer  <ddkilzer@apple.com>
775
776         Bug 21850: svn-apply and svn-unapply should preserve patch line endings
777
778         <https://bugs.webkit.org/show_bug.cgi?id=21850>
779
780         Reviewed by Adam Roben.
781
782         * Scripts/svn-apply: Save end-of-line characters when stripping them
783         off each line of a patch so that they may be restored after
784         processing the line.
785         * Scripts/svn-unapply: Ditto.
786
787 2008-10-23  David Kilzer  <ddkilzer@apple.com>
788
789         Bug 21832: Fix scripts using 'new File::Temp' for Perl 5.10
790
791         <https://bugs.webkit.org/show_bug.cgi?id=21832>
792
793         Reviewed by Sam Weinig.
794
795         * Scripts/bisect-builds: Use imported tempfile() from File::Temp
796         instead of 'new File::Temp' to make the script work with Perl 5.10.
797         * Scripts/sort-Xcode-project-file: Ditto.
798
799 2008-10-22  Brady Eidson  <beidson@apple.com>
800
801         Reviewed by Adam Roben
802         
803         <rdar://6261773> - autocomplete="off" doesn't work on Windows
804
805         Implement LayoutTestController::elementDoesAutoCompleteForElementWithId() on Windows
806         
807         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
808
809 2008-10-22  Darin Adler  <darin@apple.com>
810
811         * Scripts/do-webcore-rename: More renaming plans.
812
813 2008-10-21  Steve Falkenburg  <sfalken@apple.com>
814
815         Exclude strings marked with UNLOCALIZED_STRING or UNLOCALIZED_LPCTSTR.
816
817         * Scripts/extract-localizable-strings:
818
819 2008-10-17  Maciej Stachowiak  <mjs@apple.com>
820
821         Reviewed by Mark Rowe.
822         
823         - default to 1000 tests per dump tool instance again, now that CTI no longer causes
824         excess different stack logs.
825         
826         (Also fix a small bug in my last change.)
827
828         * Scripts/run-webkit-tests:
829
830 2008-10-17  Stephanie Lewis  <slewis@apple.com>
831
832         Reviewed by Mark Rowe.
833
834         Fix layout tests that use prologues and epilogues.
835
836         * Scripts/run-webkit-tests:
837
838 2008-10-17  Maciej Stachowiak  <mjs@apple.com>
839
840         Reviewed by Mark Rowe.
841         
842         - make sure MallocStackLogging is only on for tools we want to
843         leak check, not other random stuff as well.
844
845         * Scripts/run-webkit-tests:
846
847 2008-10-17  Maciej Stachowiak  <mjs@apple.com>
848
849         Reviewed by Stephanie Lewis.
850         
851         - make run-webkit-tests --leaks default to 100 tests per run instead of 1000
852         
853         This should reduce or eliminate crashes on the buildbot due to
854         running out of memory while stack logging.
855
856         * Scripts/run-webkit-tests:
857
858 2008-10-16  Jan Michael Alonzo  <jmalonzo@webkit.org>
859
860         Gtk build fix. Not reviewed.
861
862         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
863         (LayoutTestController::setSmartInsertDeleteEnabled):
864
865 2008-10-15  Glenn Wilson  <gwilson@google.com>
866
867         Added new method to allow tests to disable smart editing in the course of a test.
868         This is a possible solution to bug .20655
869
870         Reviewed by Tim Hatcher.
871
872         * DumpRenderTree/LayoutTestController.cpp:
873         (setSmartInsertDeleteEnabledCallback): new method
874         (LayoutTestController::staticFunctions): added new method to static list of callbacks
875         * DumpRenderTree/LayoutTestController.h: added signature of new method
876         * DumpRenderTree/mac/DumpRenderTree.mm:
877         (resetWebViewToConsistentStateBeforeTesting): added state resetting
878         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
879         (LayoutTestController::setSmartInsertDeleteEnabled): added new method
880         * DumpRenderTree/win/DumpRenderTree.cpp:
881         (resetWebViewToConsistentStateBeforeTesting): added state resetting
882         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
883         (LayoutTestController::setSmartInsertDeleteEnabled): added new method
884
885 2008-10-14  Ada Chan  <adachan@apple.com>
886
887         Fix windows build.
888
889         Reviewed by Sam Weinig.
890
891         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
892         * DumpRenderTree/config.h:
893         * DumpRenderTree/win/DumpRenderTreeWin.h:
894         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
895         * DumpRenderTree/win/UIDelegate.cpp:
896
897 2008-10-13  Timothy Hatcher  <timothy@apple.com>
898
899         Make prepare-ChangeLog populate the changed functions for JavaScript files.
900
901         https://bugs.webkit.org/show_bug.cgi?id=21567
902
903         Reviewed by David Kilzer.
904
905         * Scripts/prepare-ChangeLog:
906         (get_function_line_ranges): Call get_function_line_ranges_for_javascript for
907         files that end with ".js".
908         (get_function_line_ranges_for_javascript): Find functions, anonymous functions
909         and getters/setters.
910
911 2008-10-14  Alp Toker  <alp@nuanti.com>
912
913         Reviewed by Sam Weinig.
914
915         https://bugs.webkit.org/show_bug.cgi?id=16299
916         Add a config.h file to DRT
917
918         Add a config.h to DumpRenderTree and reduce use of DumpRenderTree.h as
919         an ad-hoc config header.
920
921         * DumpRenderTree/AccessibilityController.cpp:
922         * DumpRenderTree/AccessibilityUIElement.cpp:
923         * DumpRenderTree/AccessibilityUIElement.h:
924         * DumpRenderTree/DumpRenderTree.h:
925         * DumpRenderTree/GCController.cpp:
926         * DumpRenderTree/LayoutTestController.cpp:
927         * DumpRenderTree/WorkQueue.cpp:
928         * DumpRenderTree/config.h: Added.
929         * DumpRenderTree/gtk/DumpRenderTree.cpp:
930         * DumpRenderTree/gtk/GCControllerGtk.cpp:
931         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
932         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
933         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
934         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
935         * DumpRenderTree/win/DumpRenderTree.cpp:
936         * DumpRenderTree/win/DumpRenderTreeWin.h:
937         * DumpRenderTree/win/EditingDelegate.cpp:
938         * DumpRenderTree/win/EventSender.cpp:
939         * DumpRenderTree/win/FrameLoadDelegate.cpp:
940         * DumpRenderTree/win/GCControllerWin.cpp:
941         * DumpRenderTree/win/MD5.cpp:
942         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
943         * DumpRenderTree/win/PolicyDelegate.cpp:
944         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
945         * DumpRenderTree/win/WorkQueueItemWin.cpp:
946         * GNUmakefile.am:
947
948 2008-10-13  Chris Fleizach  <cfleizach@apple.com>
949
950         Reviewed by Beth Dakin.
951
952         Added a method to get the links in a webpage
953
954         * DumpRenderTree/AccessibilityUIElement.cpp:
955         (attributesOfDocumentLinksCallback):
956         (AccessibilityUIElement::getJSClass):
957         * DumpRenderTree/AccessibilityUIElement.h:
958         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
959         (AccessibilityUIElement::getDocumentLinks):
960         (AccessibilityUIElement::attributesOfDocumentLinks):
961         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
962         (AccessibilityUIElement::getDocumentLinks):
963         (AccessibilityUIElement::attributesOfDocumentLinks):
964
965 2008-10-13  David Kilzer  <ddkilzer@apple.com>
966
967         Bug 21457: resolve-ChangeLogs should be able to operate on a git revision range
968
969         <https://bugs.webkit.org/show_bug.cgi?id=21457>
970
971         Reviewed by Adam.
972
973         * Scripts/resolve-ChangeLogs: Added optional parameter to
974         -f|--fix-merged switch to run the script on a revision range.
975         Updated command-line validation checks.
976         (findChangeLog): Fixed long-standing bug that should have used
977         $_[0] instead of $_.
978         (fixMergedChangeLog): Renamed to fixOneMergedChangeLog($).  Updated
979         to work when called from git filter-branch.  It always restores a
980         copy of the previous revision before reapplying the patch.
981         (fixMergedChangeLogs): Added.  Calls itself through git filter-branch
982         to re-merge ChangeLog files across a revision range.  Removes
983         .git/refs/original directory on success.
984         (parseFixMerged): Added.  Custom method to parse the -f|--fix-merged
985         switch.
986         (removeChangeLogArguments): Added.  Removes items from @ARGV when
987         they are ChangeLog paths, and return a list of paths.  This makes it
988         easier to validate the command-line.
989         (resolveChangeLog): Added.  Extracted from main code block.  Runs
990         the traditional single-file merge algorithm.
991         (usageAndExit): Added.  Extracted from main code block.  Prints
992         usage statement and exits with error status.
993
994 2008-10-12  Darin Adler  <darin@apple.com>
995
996         * Scripts/make-js-test-wrappers: Update exceptions list so the script
997         won't overwrite files and mangle tests.
998
999 2008-10-11  Dan Bernstein  <mitz@apple.com>
1000
1001         Reviewed by Sam Weinig and Anders Carlsson.
1002
1003         - update Mac DumpRenderTree to use the new WebView SPI for forcing the
1004           complex text code path
1005         - add --complex-text support to Windows DumpRenderTree
1006
1007         * DumpRenderTree/mac/DumpRenderTree.mm:
1008         (dumpRenderTree):
1009         * DumpRenderTree/win/DumpRenderTree.cpp:
1010         (createWebViewAndOffscreenWindow):
1011         (main):
1012         * Scripts/run-webkit-tests:
1013
1014 2008-10-09  Eric Seidel  <eric@webkit.org>
1015
1016         Reviewed by Oliver Hunt.
1017
1018         https://bugs.webkit.org/show_bug.cgi?id=21498
1019
1020         * Scripts/make-js-test-wrappers: ignore resources/shadow-offset.js
1021
1022 2008-10-09  Cameron Zwarich  <zwarich@apple.com>
1023
1024         Not reviewed.
1025
1026         Add StructureID.o to the exclusion list in the global initializers
1027         script to fix the Debug build.
1028
1029         * Scripts/check-for-global-initializers:
1030
1031 2008-10-08  Mark Rowe  <mrowe@apple.com>
1032
1033         Fix the Windows build after r37434.
1034
1035         * DumpRenderTree/win/DumpRenderTree.cpp:
1036         (dump): Update code to approximate valid C++ syntax.
1037
1038 2008-10-08  Timothy Hatcher  <timothy@apple.com>
1039
1040         Add SVGElementInstance to the list of exceptions that have
1041         global initializers in debug builds.
1042
1043         Rubber-stamped by Mark Rowe.
1044
1045         * Scripts/check-for-global-initializers: Add SVGElementInstance.o.
1046
1047 2008-10-08  Simon Fraser  <simon.fraser@apple.com>
1048
1049         Reviewed by Dan Bernstein
1050
1051         Avoid disconnect between DRT and run-webkit-tests
1052         about whether to expect PNG dumps by having DRT always
1053         print two blocks terminated by #EOF, the second of which
1054         may be empty.
1055         
1056         https://bugs.webkit.org/show_bug.cgi?id=21483
1057         
1058         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1059         (printPNG):
1060         (dumpWebViewAsPixelsAndCompareWithExpected):
1061         * DumpRenderTree/mac/DumpRenderTree.mm:
1062         (dump):
1063         * DumpRenderTree/win/DumpRenderTree.cpp:
1064         (dump):
1065         * Scripts/run-webkit-tests:
1066
1067 2008-10-07  Adam Roben  <aroben@apple.com>
1068
1069         Make sure short functions get included in ChangeLog output for git
1070         repositories
1071
1072         Reviewed by Dave Kilzer.
1073
1074         * Scripts/prepare-ChangeLog:
1075         (sub diffCommand): Pass -U0 to git diff so that each contiguous change
1076         will get its own chunk without any surrounding context.
1077         (sub extractLineRange): Use the line numbers from the chunk header
1078         without modifying them now that they're accurate.
1079
1080 2008-10-04  Mark Rowe  <mrowe@apple.com>
1081
1082         Reviewed by Tim Hatcher.
1083
1084         Update check-for-weak-vtables to check only the final linked image for weak vtables.
1085         This gives more useful results than checking each object file independently.
1086
1087         * Scripts/check-for-weak-vtables:
1088
1089 2008-10-03  Pierre-Olivier Latour <pol@apple.com>
1090
1091         Reviewed by Darin Adler
1092
1093         Render images to RGBA8 bitmaps independently of platform endianness.
1094
1095         Create image difference bitmap in reference image colorspace instead of device colorspace
1096         (which depends on the main display profile), so that no color matching happens.
1097
1098         https://bugs.webkit.org/show_bug.cgi?id=21336
1099
1100         * DumpRenderTree/cg/ImageDiffCG.cpp:
1101         (createDifferenceBitmap):
1102         (computePercentageDifferent):
1103         (compareImages):
1104
1105 2008-10-02  Simon Fraser  <simon.fraser@apple.com>
1106
1107         Reviewed by Darin Adler
1108
1109         Fix hang when running with --pixel --reset, which occurs
1110         because DRT spews PNG data when the script does not expect it.
1111         
1112         https://bugs.webkit.org/show_bug.cgi?id=21323
1113         
1114         * Scripts/run-webkit-tests:
1115
1116 2008-09-30  Mark Rowe  <mrowe@apple.com>
1117
1118         Reviewed by Dan Bernstein.
1119
1120         Add a leak counter for CachedResources since we've had two recent leaks involving them.
1121
1122         * Scripts/check-for-global-initializers:
1123
1124 2008-09-30  Mark Rowe  <mrowe@apple.com>
1125
1126         Rubber-stamped by Dan Bernstein.
1127
1128         Fix many leaks seen on fast/backgrounds/svg-as-background-1.html.
1129
1130         JavaScript wrappers were keeping DOM objects alive, which was leading to the SVG background image
1131         being kept alive in the memory cache past our last attempt to empty the cache prior to quitting.
1132         We need to empty the memory cache after forcing a JavaScript garbage collection to ensure that
1133         any live JavaScript wrappers are collected and their corresponding DOM objects have a chance to be
1134         torn down before we exit.
1135
1136         * DumpRenderTree/mac/DumpRenderTree.mm:
1137         (dumpRenderTree):
1138         (main):
1139
1140 2008-09-30  Simon Fraser  <simon.fraser@apple.com>
1141
1142         Reviewed by Dan Bernstein
1143
1144         Don't run pixel comparison for text-only tests.
1145         https://bugs.webkit.org/show_bug.cgi?id=21124
1146         
1147         * DumpRenderTree/mac/DumpRenderTree.mm:
1148         (dump):
1149         * Scripts/run-webkit-tests:
1150
1151 2008-09-29  Thiago Macieira  <thiago.macieira@nokia.com>
1152
1153         Reviewed by Simon.
1154
1155         Changed copyright from Trolltech ASA to Nokia.
1156         
1157         Nokia acquired Trolltech ASA, assets were transferred on September 26th 2008.
1158         
1159
1160         * DumpRenderTree/qt/DumpRenderTree.cpp:
1161         * DumpRenderTree/qt/jsobjects.cpp:
1162         * DumpRenderTree/qt/jsobjects.h:
1163         * DumpRenderTree/qt/main.cpp:
1164         * DumpRenderTree/qt/testplugin.cpp:
1165         * DumpRenderTree/qt/testplugin.h:
1166
1167 2008-09-28  David Kilzer  <ddkilzer@apple.com>
1168
1169         Bug 21185: resolve-ChangeLogs should be able to fix poorly merged ChangeLog entries after a git svn rebase
1170
1171         <https://bugs.webkit.org/show_bug.cgi?id=21185>
1172
1173         Reviewed by Adam.
1174
1175         * Scripts/resolve-ChangeLogs: Added new -f|--fix-merge switch that
1176         will attempt to reapply the last commit to a ChangeLog file such
1177         that the ChangeLog entry appears at the top of the file.
1178         (findChangeLog): Added prototype and moved method below the exit
1179         statement.
1180         (fixMergedChangeLog): Added.  Method to fix incorrectly merged
1181         ChangeLog entries.
1182
1183 2008-09-27  Anders Carlsson  <andersca@apple.com>
1184
1185         Reviewed by Sam Weinig.
1186         
1187         https://bugs.webkit.org/show_bug.cgi?id=21178
1188         <rdar://problem/6248651>
1189         
1190         Return the result value from getURL.
1191         
1192         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1193         (getURL):
1194
1195 2008-09-26  Matt Lilek  <webkit@mattlilek.com>
1196
1197         Reviewed by Tim Hatcher.
1198
1199         Update FEATURE_DEFINES after ENABLE_CROSS_DOCUMENT_MESSAGING was removed.
1200
1201         * Scripts/build-webkit:
1202
1203 2008-09-26  Alice Liu  <alice.liu@apple.com>
1204
1205         Remove usage of atlstr.h and CString for VCExpress compatibility
1206
1207         Reviewed by Stephanie Lewis.
1208
1209         * record-memory-win/main.cpp:
1210         (ProcessArgs):
1211         (UseImage):
1212         (QueryContinuously):
1213         (OneQuery):
1214         (OneQueryMP):
1215
1216 2008-09-26  Kevin Ollivier  <kevino@theolliviers.com>
1217
1218         wx build fix. Update the version of libpng.
1219
1220         * wx/install-unix-extras:
1221
1222 2008-09-24  Sam Weinig  <sam@webkit.org>
1223
1224         Reviewed by Darin Adler.
1225
1226         Fix for https://bugs.webkit.org/show_bug.cgi?id=21080
1227         <rdar://problem/6243534>
1228         Crash below Function.apply when using a runtime array as the argument list
1229
1230         Add method to ObjCController to return a runtime array.
1231
1232         * DumpRenderTree/mac/ObjCController.m:
1233         (+[ObjCController isSelectorExcludedFromWebScript:]):
1234         (+[ObjCController webScriptNameForSelector:]):
1235         (-[ObjCController testArray]):
1236
1237 2008-09-24  Beth Dakin  <bdakin@apple.com>
1238
1239         Reviewed by Sam Weinig.
1240
1241         Speculative build fix. 
1242
1243         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1244         (AccessibilityUIElement::supportsPressAction):
1245
1246 2008-09-23  Beth Dakin  <bdakin@apple.com>
1247
1248         Reviewed by Sam Weinig.
1249
1250         This patch extends DumpRenderTree's AccessibilityController to ask 
1251         if the focused element supports the press action.
1252
1253         * DumpRenderTree/AccessibilityUIElement.cpp:
1254         (getSupportsPressActionCallback):
1255         (AccessibilityUIElement::getJSClass):
1256         * DumpRenderTree/AccessibilityUIElement.h:
1257         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1258         (AccessibilityUIElement::supportsPressAction):
1259
1260 2008-09-22  Alice Liu  <alice.liu@apple.com>
1261
1262         Adding a stand-alone Windows console application to record a process's memory usage
1263
1264         Reviewed by Steve Falkenburg.
1265
1266         * record-memory-win: Added.
1267         * record-memory-win/main.cpp: Added.
1268         * record-memory-win/record-memory-win.vcproj: Added.
1269
1270 2008-09-22  Chris Fleizach  <cfleizach@apple.com>
1271
1272         Reviewed by Darin Adler.
1273
1274         Support ability to get/set selected text ranges for text controls through AX.
1275
1276         * DumpRenderTree/AccessibilityUIElement.cpp:
1277         (setSelectedTextRangeCallback):
1278         (getSelectedTextRangeCallback):
1279         (AccessibilityUIElement::getJSClass):
1280         * DumpRenderTree/AccessibilityUIElement.h:
1281         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1282         (AccessibilityUIElement::attributesOfRowHeaders):
1283         (AccessibilityUIElement::attributesOfVisibleCells):
1284         (AccessibilityUIElement::rowIndexRange):
1285         (AccessibilityUIElement::columnIndexRange):
1286         (AccessibilityUIElement::cellForColumnAndRow):
1287         (AccessibilityUIElement::selectedTextRange):
1288         (AccessibilityUIElement::setSelectedTextRange):
1289         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1290         (AccessibilityUIElement::selectedTextRange):
1291         (AccessibilityUIElement::setSelectedTextRange):
1292
1293 2008-09-20  Darin Adler  <darin@apple.com>
1294
1295         * DumpRenderTree/mac/DumpRenderTree.mm:
1296         (convertMIMEType): Turn on Stephanie's workaround for Tiger too.
1297
1298 2008-09-19  Alp Toker  <alp@nuanti.com>
1299
1300         Build fix for the 'gold' linker and recent binutils. New behaviour
1301         requires that we link to used libraries explicitly.
1302
1303         * GNUmakefile.am:
1304
1305 2008-09-19  Stephanie Lewis  <slewis@apple.com>
1306
1307         Reviewed by Oliver Hunt.
1308
1309         Implement a workaround for an incorrect mime-type on machines with 
1310         Dashcode 2.0.1.  Dashcode is overriding the UTI type for .js files.
1311         See radar <rdar://problem/6234318>.     
1312
1313         * DumpRenderTree/mac/DumpRenderTree.mm:
1314         (convertMIMEType):
1315
1316 2008-09-19  Chris Fleizach  <cfleizach@apple.com>
1317
1318         Fixed Windows bustage
1319
1320         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1321         (AccessibilityUIElement::titleUIElement):
1322
1323 2008-09-18  Chris Fleizach  <cfleizach@apple.com>
1324
1325         Reviewed by Darin Adler.
1326
1327         Expose titleUIElement call for DumpRenderTree
1328
1329         * ChangeLog:
1330         * DumpRenderTree/AccessibilityUIElement.cpp:
1331         (titleUIElementCallback):
1332         (AccessibilityUIElement::getJSClass):
1333         * DumpRenderTree/AccessibilityUIElement.h:
1334         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1335         (AccessibilityUIElement::titleUIElement):
1336
1337 2008-09-18  Darin Adler  <darin@apple.com>
1338
1339         * Scripts/do-webcore-rename: More renaming plans.
1340
1341 2008-09-18  Mark Rowe  <mrowe@apple.com>
1342
1343         Reviewed by Dan Bernstein.
1344
1345         Clear the main frame's name between tests to get more consistent test results
1346         when running the WebKit tests with --nthly.
1347
1348         * DumpRenderTree/mac/DumpRenderTree.mm:
1349         (resetWebViewToConsistentStateBeforeTesting):
1350         * DumpRenderTree/win/DumpRenderTree.cpp:
1351         (resetWebViewToConsistentStateBeforeTesting):
1352
1353 2008-09-18  Stephanie Lewis  <slewis@apple.com>
1354
1355         Really fix tiger jsc tests.
1356
1357         * Scripts/run-javascriptcore-tests:
1358
1359 2008-09-18  Stephanie Lewis  <slewis@apple.com>
1360
1361         Reviewed by Maciej Stachowiak.
1362
1363         Fix jsc tests on Tiger.  Make jsc tests smarter about when to use the arch flag.
1364
1365         * Scripts/run-javascriptcore-tests:
1366         * Scripts/webkitdirs.pm:
1367
1368 2008-09-18  Mark Rowe  <mrowe@apple.com>
1369
1370         Rubber-stamped by Sam Weinig.
1371
1372         Print warning to stdout rather than stderr when a test attempts to access a remote resource.
1373         This should make it more obvious when a test does this, as stderr output tends to be obscured
1374         by noise in the test results.
1375
1376         Also fixes some coding style issues in ResourceLoadDelegate.mm.
1377
1378         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1379         (-[NSError _drt_descriptionSuitableForTestResult]):
1380         (-[NSURL _drt_descriptionSuitableForTestResult]):
1381         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1382         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1383         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
1384         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
1385         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
1386         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
1387
1388 2008-09-18  Stephanie Lewis  <slewis@apple.com>
1389
1390         Reviewed by Mark Rowe and Maciej Stachowiak..
1391
1392         add a --64-bit option and specify which architecture to run on Mac.
1393
1394         * Scripts/run-javascriptcore-tests:
1395
1396 2008-09-17  Mark Rowe  <mrowe@apple.com>
1397
1398         Reviewed by Sam Weinig.
1399
1400         Fix a crash seen running DumpRenderTree on fast/dom/null-document-window-open-crash.html under guard malloc.
1401
1402         The JS wrapper for LayoutTestController could outlive the wrapped instance, and would crash when
1403         attempting to access the wrapped instance within layoutTestControllerObjectFinalize. We fix this by making
1404         LayoutTestController ref-counted to ensure that it is not outlived by the JS wrapper.
1405
1406         * DumpRenderTree/ForwardingHeaders/wtf/RefCounted.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/RefCounted.h.
1407         * DumpRenderTree/LayoutTestController.cpp:
1408         (LayoutTestController::LayoutTestController):
1409         (notifyDoneCallback): Remove code that is no longer needed now that we must always have a wrapped instance.
1410         (layoutTestControllerObjectFinalize): Deref the wrapped object.
1411         (LayoutTestController::makeWindowObject): Ref the wrapped object.
1412         * DumpRenderTree/LayoutTestController.h: Make LayoutTestController RefCounted.
1413         * DumpRenderTree/mac/DumpRenderTree.mm:
1414         (runTest): Deref the LayoutTestController object rather than explicitly deleting it.
1415         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Remove code that is no longer needed.
1416         * DumpRenderTree/win/DumpRenderTree.cpp:
1417         (runTest): Deref the LayoutTestController object rather than explicitly deleting it.
1418
1419 2008-09-16  Sam Weinig  <sam@webkit.org>
1420
1421         Reviewed by Mark Rowe.
1422
1423         Add flag to disable running sample on tests that timeout.
1424
1425         * Scripts/run-webkit-tests:
1426
1427 2008-09-16  Adam Roben  <aroben@apple.com>
1428
1429         Windows build fix after r36511
1430
1431         Update for rename of layoutTestController to gLayoutTestController.
1432
1433         * DumpRenderTree/LayoutTestController.cpp:
1434         * DumpRenderTree/win/EditingDelegate.cpp:
1435         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1436         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1437         * DumpRenderTree/win/UIDelegate.cpp:
1438
1439 2008-09-16  Adam Roben  <aroben@apple.com>
1440
1441         Add a script to print out the dependency tree of a Visual Studio
1442         solution file
1443
1444         * Scripts/print-msvc-project-dependencies: Added.
1445
1446 2008-09-16  Mark Rowe  <mrowe@apple.com>
1447
1448         Fix the build.
1449
1450         * DumpRenderTree/LayoutTestController.cpp:
1451         (notifyDoneCallback): Call fprintf in a safer manner.
1452
1453 2008-09-16  Simon Fraser  <simon.fraser@apple.com>
1454
1455         Reviewed by Eric Seidel
1456         
1457         Protect against tests that call layoutTestController.notifyDone() 
1458         more than once, which would lead to memory corruption, by nulling
1459         out the LayoutTestController on the JSObjectRef on destruction. Also
1460         add a finalize callback on the class so that if the LTC outlives
1461         the JSObjectRef, the JSObjectRef backpointer on the LTC can be
1462         nulled out.
1463         
1464         https://bugs.webkit.org/show_bug.cgi?id=20875
1465
1466         * DumpRenderTree/LayoutTestController.cpp:
1467         (LayoutTestController::LayoutTestController):
1468         (notifyDoneCallback):
1469         (layoutTestControllerObjectFinalize):
1470         (LayoutTestController::makeWindowObject):
1471         (LayoutTestController::getJSClass):
1472         * DumpRenderTree/LayoutTestController.h:
1473         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1474         (LayoutTestController::~LayoutTestController):
1475
1476 2008-09-16  Simon Fraser  <simon.fraser@apple.com>
1477
1478         Reviewed by Eric Seidel
1479
1480         Step 1 patch: rename global variable for clarity.
1481         https://bugs.webkit.org/show_bug.cgi?id=20875
1482
1483         * DumpRenderTree/DumpRenderTree.h:
1484         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1485         (dumpWebViewAsPixelsAndCompareWithExpected):
1486         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1487         (dumpFramesAsText):
1488         (dump):
1489         (runTest):
1490         (processWork):
1491         (webViewLoadFinished):
1492         (webViewWindowObjectCleared):
1493         * DumpRenderTree/mac/DumpRenderTree.mm:
1494         (allocateGlobalControllers):
1495         (dumpFrameScrollPosition):
1496         (dumpFramesAsText):
1497         (methodNameStringForFailedTest):
1498         (dump):
1499         (runTest):
1500         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1501         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1502         * DumpRenderTree/mac/EditingDelegate.mm:
1503         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
1504         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
1505         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
1506         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
1507         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
1508         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
1509         (-[EditingDelegate webViewDidBeginEditing:]):
1510         (-[EditingDelegate webViewDidChange:]):
1511         (-[EditingDelegate webViewDidEndEditing:]):
1512         (-[EditingDelegate webViewDidChangeTypingStyle:]):
1513         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1514         (-[FrameLoadDelegate processWork:]):
1515         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
1516         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1517         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
1518         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
1519         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
1520         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
1521         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1522         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1523         * DumpRenderTree/mac/UIDelegate.mm:
1524         (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]):
1525         (-[UIDelegate webViewFocus:]):
1526         (-[UIDelegate webViewUnfocus:]):
1527         (-[UIDelegate webView:createWebViewWithRequest:]):
1528         (-[UIDelegate webViewClose:]):
1529         * DumpRenderTree/win/DumpRenderTree.cpp:
1530         (dumpFrameScrollPosition):
1531         (dumpFramesAsText):
1532         (dump):
1533         (runTest):
1534
1535 2008-09-15  Alice Liu  <alice.liu@apple.com>
1536
1537         A change needed to make PPC bots pass accessibility/table-cell-spans.html layout test
1538
1539         Reviewed by Stephanie Lewis.
1540
1541         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1542         Calling -[NSValue rangeValue] on nil object was returning bogus results on PPC, 
1543         but not Intel.  Add a check for nil before calling. 
1544         (AccessibilityUIElement::rowIndexRange):
1545         (AccessibilityUIElement::columnIndexRange):
1546
1547 2008-09-14  Mark Rowe  <mrowe@apple.com>
1548
1549         Build fix.
1550
1551         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1552         (waitUntilDoneWatchdogFired):
1553         * DumpRenderTree/mac/ObjCPlugin.m:
1554
1555 2008-09-08  Dan Bernstein  <mitz@apple.com>
1556
1557         Reviewed by Mark Rowe.
1558
1559         - add an option to run-webkit-tests to always use the complex text code path
1560
1561         * DumpRenderTree/mac/DumpRenderTree.mm:
1562         (initializeGlobalsFromCommandLineOptions):
1563         (dumpRenderTree):
1564         * Scripts/run-webkit-tests:
1565
1566 2008-09-08  Steve Falkenburg  <sfalken@apple.com>
1567
1568         Another Windows nightly build fix.
1569
1570         Reviewed by Sam Weinig.
1571
1572         * FindSafari/FindSafari.cpp:
1573         (_tmain): Delete existing WebKitNightly directory in temp.
1574         * FindSafari/Safari.exe.manifest: Add PROGIDs for each COM class. Remove non-production classes.
1575
1576 2008-09-07  Stephanie Lewis  <slewis@apple.com>
1577
1578         Reviewed by Mark Rowe.
1579
1580         Fix DRT build 
1581
1582         * DumpRenderTree/DumpRenderTreePrefix.h:
1583         * DumpRenderTree/win/DumpRenderTree.vcproj:
1584
1585 2008-09-06  Steve Falkenburg  <sfalken@apple.com>
1586
1587         Fix Windows nightlies.
1588         
1589         Copy WebKit.dll alongside application so registry-free COM can find it.
1590         Update embedded manifest to force use registry-free COM.
1591
1592         Reviewed by Dave Hyatt.
1593
1594         * FindSafari/FindSafari.cpp:
1595         (copyManifest):
1596         (replaceManifest):
1597         (_tmain):
1598         * FindSafari/FindSafari.rc: Added.
1599         * FindSafari/FindSafari.vcproj:
1600         * FindSafari/Safari.exe.manifest: Added.
1601         * FindSafari/resource.h: Added.
1602
1603 === End merge of squirrelfish-extreme ===
1604
1605 2008-08-31  Mark Rowe  <mrowe@apple.com>
1606
1607         Reviewed by Maciej Stachowiak.
1608
1609         Add a --profile flag to run-sunspider.
1610
1611         * Scripts/webkitdirs.pm: Detect --profile or --profiling passed as a command-line argument
1612         to build scripts as indicating that we should use the "Profiling" configuration.  At present
1613         this is only supported by JavaScriptCore, so using this argument to build any other project
1614         will likely result in unexpected behaviour.
1615
1616 2008-08-27  Mark Rowe  <mrowe@apple.com>
1617
1618         Reviewed by Oliver Hunt.
1619
1620         Fix run-webkit-tests to handle DRT exiting early.
1621
1622         * Scripts/run-webkit-tests: Initialize $expectedResultPaths{$base} before it will be used.
1623
1624 === Start merge of squirrelfish-extreme ===
1625
1626 2008-09-04  Mark Rowe  <mrowe@apple.com>
1627
1628         Reviewed by Eric Seidel.
1629
1630         Fix https://bugs.webkit.org/show_bug.cgi?id=20639.
1631         Bug 20639: ENABLE_DASHBOARD_SUPPORT does not need to be a FEATURE_DEFINE
1632
1633         * Scripts/build-webkit: Remove ENABLE_DASHBOARD_SUPPORT-related code.
1634
1635 2008-09-04  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
1636
1637         Reviewed by Oliver Hunt.
1638
1639         Bug 20616: Incorporate V8 benchmarks in testing
1640         <https://bugs.webkit.org/show_bug.cgi?id=20616>
1641
1642         Add support for the --v8 option to run-sunspider.
1643
1644         * Scripts/run-sunspider:
1645
1646 2008-09-04  Kevin Ollivier  <kevino@theolliviers.com>
1647
1648         wx buildbot fix. More robust handling of clean when makefiles are not built or 
1649         are not completely made.
1650
1651         * wx/build-wxwebkit:
1652
1653 2008-09-03  Mark Rowe  <mrowe@apple.com>
1654
1655         More Mac build fixes.
1656
1657         Set ENABLE_DASHBOARD_SUPPORT when building for Mac via build-webkit.
1658         Also set ENABLE_CROSS_DOCUMENT_MESSAGING in order to match the
1659         default configuration specified in the .xcconfig files.
1660
1661         * Scripts/build-webkit:
1662
1663 2008-09-03  Mark Rowe  <mrowe@apple.com>
1664
1665         Mac build fix.  Ensure that dashboard support is enabled.
1666
1667         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1668
1669 2008-08-25  Steve Falkenburg  <sfalken@apple.com>
1670
1671         Build fix. Copy correct version of ICU.
1672
1673         * DumpRenderTree/win/DumpRenderTree.vcproj:
1674
1675 2008-08-25  Holger Hans Peter Freyther  <zecke@selfish.org>
1676
1677         Reviewed by Simon.
1678
1679         [run-webkit-tests] Use QtLauncher to show the results of the tests
1680         konqueror might not be installed, xdg-open might not be installed but the
1681         QtLauncher should be present.
1682
1683         * Scripts/run-webkit-tests:
1684
1685 2008-08-24  Jon Honeycutt  <jhoneycutt@apple.com>
1686
1687         Initial support for accessibility layout tests on Windows.
1688         https://bugs.webkit.org/show_bug.cgi?id=20497
1689
1690         Reviewed by Sam Weinig.
1691
1692         * DumpRenderTree/AccessibilityController.h: Fix typos.
1693         * DumpRenderTree/AccessibilityUIElement.cpp: Change #import to #include.
1694         * DumpRenderTree/AccessibilityUIElement.h: Define _WINSOCKAPI_ to
1695         prevent oleacc.h, which includes windows.h, from including winsock.h.
1696         Fixed typos.
1697         * DumpRenderTree/win/AccessibilityControllerWin.cpp: Added.
1698         (AccessibilityController::AccessibilityController):
1699         (AccessibilityController::~AccessibilityController):
1700         (AccessibilityController::focusedElement): Get the root element, and
1701         request its focused object.
1702         (AccessibilityController::rootElement): Query Windows for the 
1703         accessible client object for the WebView's window.
1704         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Added.
1705         (AccessibilityUIElement::AccessibilityUIElement):
1706         (AccessibilityUIElement::~AccessibilityUIElement):
1707         (AccessibilityUIElement::getLinkedUIElements): Not implemented.
1708         (AccessibilityUIElement::getChildren): Get the child count, and append
1709         each child.
1710         (AccessibilityUIElement::getChildAtIndex): Get the child at the given
1711         index offset by 1. In MSAA, child 0 is the object itself.
1712         (AccessibilityUIElement::allAttributes): Not implemented.
1713         (AccessibilityUIElement::attributesOfLinkedUIElements): Same.
1714         (AccessibilityUIElement::attributesOfChildren): Same.
1715         (AccessibilityUIElement::parameterizedAttributeNames): Same.
1716         (self): Return a VARIANT representing the "self" object. This is used
1717         when calling methods that require a child variant.
1718         (AccessibilityUIElement::role): Get the MSAA role, a long value, and
1719         convert it into a string with GetRoleText().
1720         (AccessibilityUIElement::title): Get the element's title, and convert
1721         it to a JS String.
1722         (AccessibilityUIElement::description): Same, for description.
1723         (AccessibilityUIElement::width):
1724         (AccessibilityUIElement::height):
1725         (AccessibilityUIElement::intValue): Get the object's value as a string,
1726         and convert the string to a double.
1727         (AccessibilityUIElement::minValue): Not implemented.
1728         (AccessibilityUIElement::maxValue): Same.
1729         (AccessibilityUIElement::insertionPointLineNumber): Same.
1730         (AccessibilityUIElement::attributesOfColumnHeaders): Same.
1731         (AccessibilityUIElement::attributesOfRowHeaders): Same.
1732         (AccessibilityUIElement::attributesOfColumns): Same.
1733         (AccessibilityUIElement::attributesOfRows): Same.
1734         (AccessibilityUIElement::attributesOfVisibleCells): Same.
1735         (AccessibilityUIElement::attributesOfHeader): Same.
1736         (AccessibilityUIElement::indexInTable): Same.
1737         (AccessibilityUIElement::rowIndexRange): Same.
1738         (AccessibilityUIElement::columnIndexRange): Same.
1739         (AccessibilityUIElement::lineForIndex): Same.
1740         (AccessibilityUIElement::boundsForRange): Same.
1741         (AccessibilityUIElement::cellForColumnAndRow): Same.
1742         * DumpRenderTree/win/DumpRenderTree.vcproj: Add accessibility files to
1743         project.  Link to oleacc.lib, the MSAA library.
1744         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1745         (FrameLoadDelegate::FrameLoadDelegate): Initialize the accessibility
1746         controller.
1747         (FrameLoadDelegate::didClearWindowObject): Create a new window object
1748         for the accessibility controller.
1749         * DumpRenderTree/win/FrameLoadDelegate.h:
1750
1751 2008-08-21  Simon Fraser  <simon.fraser@apple.com>
1752
1753         Reviewed by Mark Rowe
1754         
1755         Make build-launcher-app work when run from a git repository.
1756         https://bugs.webkit.org/show_bug.cgi?id=20478
1757
1758         * BuildSlaveSupport/build-launcher-app:
1759
1760 2008-08-20  Maxime Britto  <britto@apple.com>
1761
1762         Reviewed by Ada Chan.
1763
1764          rdar://5259746
1765         Mouse events are sent to page while resizing window (affects Gmail)
1766
1767         * DumpRenderTree/win/UIDelegate.h:
1768         (UIDelegate::webViewSendResizeMessage): Add the new interface method, not implemented.
1769
1770 2008-08-19  Chris Fleizach  <cfleizach@apple.com>
1771
1772         Reviewed by Beth Dakin.
1773
1774         Add snowleopard platform in layout tests
1775
1776         Added support for accessing the attributes of
1777         accessibility tables through the accessibility controller
1778         in DumpRenderTree
1779
1780         * DumpRenderTree/AccessibilityUIElement.cpp:
1781         (attributesOfColumnHeadersCallback):
1782         (attributesOfRowHeadersCallback):
1783         (attributesOfColumnsCallback):
1784         (attributesOfRowsCallback):
1785         (attributesOfVisibleCellsCallback):
1786         (attributesOfHeaderCallback):
1787         (indexInTableCallback):
1788         (rowIndexRangeCallback):
1789         (columnIndexRangeCallback):
1790         (childAtIndexCallback):
1791         (cellForColumnAndRowCallback):
1792         (AccessibilityUIElement::getJSClass):
1793         * DumpRenderTree/AccessibilityUIElement.h:
1794         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1795         (convertNSArrayToVector):
1796         (descriptionOfElements):
1797         (AccessibilityUIElement::getLinkedUIElements):
1798         (AccessibilityUIElement::getChildren):
1799         (AccessibilityUIElement::attributesOfLinkedUIElements):
1800         (AccessibilityUIElement::attributesOfChildren):
1801         (AccessibilityUIElement::attributesOfColumnHeaders):
1802         (AccessibilityUIElement::attributesOfRowHeaders):
1803         (AccessibilityUIElement::attributesOfColumns):
1804         (AccessibilityUIElement::attributesOfRows):
1805         (AccessibilityUIElement::attributesOfVisibleCells):
1806         (AccessibilityUIElement::attributesOfHeader):
1807         (AccessibilityUIElement::indexInTable):
1808         (AccessibilityUIElement::rowIndexRange):
1809         (AccessibilityUIElement::columnIndexRange):
1810         (AccessibilityUIElement::cellForColumnAndRow):
1811         * Scripts/run-webkit-tests:
1812
1813 2008-08-19  Alexey Proskuryakov  <ap@webkit.org>
1814
1815         Reviewed by Darin Adler.
1816
1817         Fix run-webkit-tests misreporting crashed tests as timed out ones because DumpRenderTree
1818         is waiting for crash reporter to let it exit.
1819
1820         The fix does not work on Tiger, because the state of the process is indistinguishable from
1821         other waiting processes, at least not with this technique.
1822
1823         * Scripts/run-webkit-tests:
1824
1825 2008-08-18  Alp Toker  <alp@nuanti.com>
1826
1827         Reviewed by Holger Freyther.
1828
1829         https://bugs.webkit.org/show_bug.cgi?id=20350
1830         [GTK] Get DumpRenderTree working
1831
1832         Fixes and enhancements to DumpRenderTree. With these changes, the test
1833         suite can now complete a run producing text and render tree dumps.
1834
1835         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1836         (dumpFramesAsText):
1837         (dump):
1838         (runTest):
1839         (webViewLoadFinished):
1840         (webViewWindowObjectCleared):
1841         (webViewConsoleMessage):
1842         (webViewScriptAlert):
1843         (webViewScriptPrompt):
1844         (webViewScriptConfirm):
1845         (webViewTitleChanged):
1846         (main):
1847         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
1848         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1849         (LayoutTestController::clearBackForwardList):
1850         (LayoutTestController::pathToLocalResource):
1851         (LayoutTestController::setAcceptsEditing):
1852         (LayoutTestController::setUserStyleSheetEnabled):
1853         (LayoutTestController::setUserStyleSheetLocation):
1854         (waitToDumpWatchdogFired):
1855         (LayoutTestController::windowCount):
1856         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
1857         (JSStringCopyUTF8CString):
1858         (ScriptItem::invoke):
1859
1860 2008-08-17  Geoffrey Garen  <ggaren@apple.com>
1861
1862         Reviewed by Cameron Zwarich.
1863         
1864         Updated project files to XCode 3.1.
1865
1866         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
1867         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1868
1869 2008-08-15  Mark Rowe  <mrowe@apple.com>
1870
1871         Rubber-stamped by Geoff Garen.
1872
1873         <rdar://problem/6139914> Please include a _debug version of JavaScriptCore framework
1874
1875         * Scripts/check-for-global-initializers: Ignore initializers when building the debug variant.
1876
1877 2008-08-13  Simon Hausmann  <hausmann@webkit.org>
1878
1879         Rubber-stamped by Holger.
1880
1881         Revert r31585 and disable http tests for the Qt build again unless
1882         explicitly enabled.
1883
1884         Running the http tests unfortunately currently still triggers
1885         failures in non-http tests due to side-effects. Disable them by default for
1886         now, for more reliable results.
1887
1888         * Scripts/run-webkit-tests:
1889
1890 2008-08-10  Jan Michael Alonzo  <jmalonzo@webkit.org>
1891
1892         Reviewed (and updated) by Alp Toker.
1893
1894         https://bugs.webkit.org/show_bug.cgi?id=16620
1895         [GTK] Autotools make dist and make check support
1896
1897         Get make dist working.
1898
1899         Note that not all possible configurations have been tested yet.
1900
1901         * GNUmakefile.am:
1902
1903 2008-08-10  Alp Toker  <alp@nuanti.com>
1904
1905         Remove leftover qmake/GTK+ build files.
1906
1907         * DumpRenderTree/gtk/DumpRenderTree.pro: Removed.
1908         * GtkLauncher/GtkLauncher.pro: Removed.
1909
1910 2008-08-06  Chris Fleizach  <cfleizach@apple.com>
1911
1912         Reviewed by Beth Dakin
1913
1914         AX functions shouldn't return position information because it changes
1915         based on the platform
1916
1917         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1918         (AccessibilityUIElement::boundsForRange):
1919
1920 2008-08-06  Eric Seidel  <eric@webkit.org>
1921
1922         Reviewed by darin.
1923         
1924         Fix leaks seen on build-bot by fixing memory management of AccessibilityUIElement.
1925         <https://bugs.webkit.org/show_bug.cgi?id=20297>
1926         <rdar://problem/6093153>
1927         
1928         I've made AccessibilityUIElement a stack object for now.  It could be
1929         made RefCounted, but I figured that might be overkill for the moment.
1930         Essentially it's just a RefPtr itself. :)
1931         
1932         I also fixed a few typos, such as AccessibilityUIElement() instead of ~AccessibilityUIElement()
1933         which was causing additional leaks. :)
1934         
1935         I added toAXElement to remove a bunch of copy/paste code.
1936
1937         * DumpRenderTree/AccessibilityController.h:
1938         * DumpRenderTree/AccessibilityUIElement.cpp:
1939         (toAXElement):
1940         (allAttributesCallback):
1941         (attributesOfLinkedUIElementsCallback):
1942         (attributesOfChildrenCallback):
1943         (lineForIndexCallback):
1944         (boundsForRangeCallback):
1945         (childAtIndexCallback):
1946         (getRoleCallback):
1947         (getTitleCallback):
1948         (getDescriptionCallback):
1949         (getWidthCallback):
1950         (getHeightCallback):
1951         (getIntValueCallback):
1952         (getMinValueCallback):
1953         (getMaxValueCallback):
1954         (getInsertionPointLineNumberCallback):
1955         (finalize):
1956         * DumpRenderTree/AccessibilityUIElement.h:
1957         (AccessibilityUIElement::platformUIElement):
1958         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1959         (AccessibilityController::focusedElement):
1960         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1961         (AccessibilityUIElement::AccessibilityUIElement):
1962         (AccessibilityUIElement::getLinkedUIElements):
1963         (AccessibilityUIElement::getChildren):
1964         (AccessibilityUIElement::getChildAtIndex):
1965         (AccessibilityUIElement::attributesOfLinkedUIElements):
1966         (AccessibilityUIElement::attributesOfChildren):
1967
1968 2008-08-06  Eric Seidel  <eric@webkit.org>
1969
1970         Reviewed by Cameron Zwarich.
1971
1972         Speculative fix for an error I keep seeing in my Cygwin build
1973
1974         * Scripts/webkitdirs.pm: make determineConfigurationProductDir() always call determineConfiguration() even on cygwin
1975
1976 2008-08-02  Kevin Ollivier  <kevino@theolliviers.com>
1977
1978         Forgot to commit licensing correction in last commit.
1979
1980         * wx/packaging/wxWebKitInstaller.iss.in:
1981
1982 2008-08-02  Kevin Ollivier  <kevino@theolliviers.com>
1983
1984         Reviewed by Eric Seidel.
1985         
1986         Scripts for building a wxWebKit installer for wxPython on Win, eventually will
1987         be used for nightlies.
1988         
1989         https://bugs.webkit.org/show_bug.cgi?id=20036
1990
1991         * wx/packaging: Added.
1992         * wx/packaging/build-win-installer.py: Added.
1993         * wx/packaging/wxWebKitInstaller.iss.in: Added.
1994
1995 2008-07-31  Adam Roben  <aroben@apple.com>
1996
1997         Follow-up to r35500
1998
1999         * WinLauncher/WinLauncher.vcproj: Set the manifest properties for the
2000         Release configuration, too.
2001
2002 2008-07-31  Stefan Landvogt <stefan.landvogt@gmail.com>
2003
2004         Fix Bug 20245: WinLauncher does not start in WebKit-debug right out of
2005         the box
2006
2007         <https://bugs.webkit.org/show_bug.cgi?id=20245>
2008
2009         Reviewed by Adam Roben.
2010
2011         * WinLauncher/WinLauncher.vcproj: adding the following properties to
2012         WinLauncher > Properties > Manifest Tool > Isolated COM
2013         Type Library File: $(WebKitOutputDir)\lib\WebKit.tlb
2014         Component File Name: WebKit$(WebKitDLLConfigSuffix)
2015         Doing the change on "All Configurations"
2016
2017 2008-07-31  Adam Roben  <aroben@apple.com>
2018
2019         Windows build bot fix
2020
2021         * DumpRenderTree/win/ImageDiff.vcproj: Don't fail if files that only
2022         exist for people at Apple can't be found. Also updated the ICU version
2023         to 3.8.
2024
2025 2008-07-31  David Kilzer  <ddkilzer@apple.com>
2026
2027         Fix layout test results for webarchive/test-xml-stylesheet.xml
2028
2029         Reviewed by Darin Adler.
2030
2031         * DumpRenderTree/mac/DumpRenderTree.mm:
2032         (convertMIMEType): Work around the "text/xml" local file type
2033         regression in Leopard using the BUILDING_ON_LEOPARD macro.  Also
2034         stop mangling "application/x-javascript" into "text/javascript".
2035         (convertWebResourceDataToString): When checking whether to dump a
2036         resource as text, also check to see if the MIME type is in the
2037         -[WebHTMLRepresentation supportedNonImageMIMETypes] array.
2038         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added BUILDING_ON_LEOPARD
2039         macro.
2040
2041 2008-07-31  Chris Fleizach  <cfleizach@apple.com>
2042
2043         Reviewed by Alice Liu
2044
2045         Add AX support to get the bounds for a range of text
2046         Add AX support to get the child of an element
2047         Add AX support to get all the parameterized attribute names of an element
2048
2049         * DumpRenderTree/AccessibilityUIElement.cpp:
2050         (parameterizedAttributeNamesCallback):
2051         (boundsForRangeCallback):
2052         (childAtIndexCallback):
2053         (AccessibilityUIElement::getJSClass):
2054         * DumpRenderTree/AccessibilityUIElement.h:
2055         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2056         (AccessibilityUIElement::getChildAtIndex):
2057         (AccessibilityUIElement::parameterizedAttributeNames):
2058         (AccessibilityUIElement::boundsForRange):
2059
2060 2008-07-31  Erik Bunce  <elbunce@thehive.com>
2061
2062         Reviewed by Simon.
2063
2064         Make run-launcher set DYLD_LIBRARY_PATH to make things work on Mac OS X.
2065
2066         * Scripts/run-launcher:
2067
2068 2008-07-30  Jessica Kahn  <jess@apple.com>
2069
2070         Reviewed by Adam Roben.
2071
2072         Slightly stricter checking for previous change, suggested by Adam.
2073         
2074         * Scripts/extract-localizable-strings:
2075
2076 2008-07-30  Jessica Kahn  <jess@apple.com>
2077
2078         Reviewed by Darin Adler.
2079
2080         Added support for UI_STRING and UI_STRING_KEY macros with flexible prefixes.
2081         
2082         * Scripts/extract-localizable-strings:
2083
2084 2008-07-30  Anders Carlsson  <andersca@apple.com>
2085
2086         Reviewed by Adam.
2087
2088         Copy icu38* files instead of icu36* files.
2089         
2090         * DumpRenderTree/win/DumpRenderTree.vcproj:
2091
2092 2008-07-25  Jan Michael Alonzo  <jmalonzo@webkit.org>
2093
2094         DRT/Gtk build fix for r35362
2095
2096         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2097         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
2098
2099 2008-07-25  Brady Eidson  <beidson@apple.com>
2100
2101         Reviewed by Sam
2102
2103         Add the ability to dump whether-or-not an element should have autocomplete enabled, 
2104         from the perspective of the WebKit API
2105
2106         * DumpRenderTree/LayoutTestController.cpp:
2107         (elementDoesAutoCompleteForElementWithIdCallback):
2108         (LayoutTestController::staticFunctions):
2109
2110         * DumpRenderTree/LayoutTestController.h:
2111         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2112         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
2113         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2114         (LayoutTestController::elementDoesAutoCompleteForElementWithId): Stub for now until I can get on Windows
2115
2116 2008-07-25  Chris Fleizach  <cfleizach@apple.com>
2117
2118         Reviewed by Beth Dakin
2119
2120         Add support for AXLineForIndex and AXInsertionPointIndex through the 
2121         accessibility controller
2122
2123         * DumpRenderTree/AccessibilityUIElement.cpp:
2124         (lineForIndexCallback):
2125         (getInsertionPointLineNumberCallback):
2126         (AccessibilityUIElement::getJSClass):
2127         * DumpRenderTree/AccessibilityUIElement.h:
2128         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2129         (AccessibilityUIElement::insertionPointLineNumber):
2130         (AccessibilityUIElement::lineForIndex):
2131
2132 2008-07-25  Adam Roben  <aroben@apple.com>
2133
2134         Try to fix the Windows build bot
2135
2136         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't try to copy files
2137         that don't exist for people outside of Apple.
2138
2139 2008-07-18  Landry Breuil  <landry@openbsd.org>
2140
2141         Bug 19975: [OpenBSD] Patches to enable build of WebKit
2142
2143         <https://bugs.webkit.org/show_bug.cgi?id=19975>
2144
2145         Reviewed by David Kilzer.
2146
2147         * DumpRenderTree/DumpRenderTree.h: OpenBSD doesn't support wide characters.
2148
2149 2008-07-16  Jon Honeycutt  <jhoneycutt@apple.com>
2150
2151         CygwinDownloader fails to install necessary packages
2152         https://bugs.webkit.org/show_bug.cgi?id=20075
2153
2154         Reviewed by Mark Rowe.
2155
2156         * CygwinDownloader/cygwin-downloader.zip: Rebuilt after two broken
2157         mirrors removed in r34116. Set MIME type to application/octet-stream.
2158
2159 2008-07-16  Jon Honeycutt  <jhoneycutt@apple.com>
2160
2161         CygwinDownloader's make-zip.sh script fails
2162         https://bugs.webkit.org/show_bug.cgi?id=20074
2163
2164         Reviewed by Mark Rowe.
2165
2166         * CygwinDownloader/cygwin-downloader.py:
2167
2168 2008-07-15  Sam Weinig  <sam@webkit.org>
2169
2170         Reviewed by Anders Carlsson.
2171
2172         Refactor accessibility testing code.
2173
2174         We now have:
2175         - AccessibilityController
2176           Controller which has access to the WebView and can provide the focused element, root element
2177           and in the future, elementAtPoint.
2178
2179         - AccessibilityUIElement
2180           Object which provides access to the data provided by the Accessibility APIs.
2181
2182         * DumpRenderTree/AccessibilityController.cpp:
2183         (getFocusedElementCallback):
2184         (getRootElementCallback):
2185         (AccessibilityController::getJSClass):
2186         * DumpRenderTree/AccessibilityController.h:
2187         * DumpRenderTree/AccessibilityUIElement.cpp: Added.
2188         (allAttributesCallback):
2189         (attributesOfLinkedUIElementsCallback):
2190         (attributesOfChildrenCallback):
2191         (getRoleCallback):
2192         (getTitleCallback):
2193         (getDescriptionCallback):
2194         (getWidthCallback):
2195         (getHeightCallback):
2196         (getIntValueCallback):
2197         (getMinValueCallback):
2198         (getMaxValueCallback):
2199         (finalize):
2200         (AccessibilityUIElement::makeJSAccessibilityUIElement):
2201         (AccessibilityUIElement::getJSClass):
2202         * DumpRenderTree/AccessibilityUIElement.h: Added.
2203         (AccessibilityUIElement::platformUIElement):
2204         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2205         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2206         (AccessibilityController::AccessibilityController):
2207         (AccessibilityController::~AccessibilityController):
2208         (AccessibilityController::focusedElement):
2209         (AccessibilityController::rootElement):
2210         * DumpRenderTree/mac/AccessibilityUIElementMac.mm: Added.
2211         (AccessibilityUIElement::AccessibilityUIElement):
2212         (descriptionOfValue):
2213         (attributesOfElement):
2214         (nsStringToJSStringRef):
2215         (concatenateAttributeAndValue):
2216         (AccessibilityUIElement::getLinkedUIElements):
2217         (AccessibilityUIElement::getChildren):
2218         (AccessibilityUIElement::attributesOfLinkedUIElements):
2219         (AccessibilityUIElement::attributesOfChildren):
2220         (AccessibilityUIElement::allAttributes):
2221         (AccessibilityUIElement::role):
2222         (AccessibilityUIElement::title):
2223         (AccessibilityUIElement::description):
2224         (AccessibilityUIElement::width):
2225         (AccessibilityUIElement::height):
2226         (AccessibilityUIElement::intValue):
2227         (AccessibilityUIElement::minValue):
2228         (AccessibilityUIElement::maxValue):
2229
2230 2008-07-14  Chris Fleizach  <cfleizach@apple.com>
2231
2232         Reviewed by Beth Dakin
2233
2234         Add support to get attributes of the AXChildren of an objecty
2235
2236         * DumpRenderTree/AccessibilityController.cpp:
2237         (attributesOfChildrenForFocusedElementCallback):
2238         (AccessibilityController::staticFunctions):
2239         * DumpRenderTree/AccessibilityController.h:
2240         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2241         (descriptionOfValue):
2242         (AccessibilityController::attributesOfChildrenForFocusedElement):
2243
2244 2008-07-14  Steve Falkenburg  <sfalken@apple.com>
2245
2246         Build fix.
2247
2248         * DumpRenderTree/win/DumpRenderTree.vcproj:
2249
2250 2008-07-14  Adam Roben  <aroben@apple.com>
2251
2252         Attempted Windows build fix
2253
2254         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Add
2255         CoreFoundation/OSXCompatibilityHeaders[/GNUCompatibility] to the
2256         include path.
2257
2258 2008-07-14  Alexey Proskuryakov  <ap@webkit.org>
2259
2260         Reviewed by Geoff Garen.
2261
2262         Eliminate per-thread JavaScript global data instance support and make arbitrary
2263         global data/global object combinations possible.
2264
2265         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
2266         (runJavaScriptThread): Don't pass a released context reference to JSGarbageCollect.
2267         In this scenario, it was causing crashes after each 10-20 tests, because there was a large
2268         chance for a different thread to cause GC after the context was released.
2269
2270 2008-07-11  Stephanie Lewis  <slewis@apple.com>
2271
2272         Reviewed by Darin Adler.
2273
2274         Make sure we read WebCore Leak messages.  Force full document teardown for DumpRenderTree.
2275
2276         Up timeout limit, some slower machines were timing out before crashtracer finished writing out to disk and quitting DRT.
2277
2278         * DumpRenderTree/mac/DumpRenderTree.mm:
2279         (setDefaultsToConsistentValuesForTesting):
2280         (resetWebViewToConsistentStateBeforeTesting):
2281         * Scripts/run-webkit-tests:
2282
2283 2008-07-10  Steve Falkenburg  <sfalken@apple.com>
2284
2285         Build fix.
2286
2287         * DumpRenderTree/win/DumpRenderTree.vcproj:
2288
2289 2008-07-09  Eric Seidel  <eric@webkit.org>
2290
2291         Reviewed by Mark Rowe.
2292         
2293         Print <div> backgrounds when printing from DRT.
2294
2295         * DumpRenderTree/mac/DumpRenderTree.mm:
2296         (setDefaultsToConsistentValuesForTesting):
2297
2298 2008-07-09  Eric Seidel  <eric@webkit.org>
2299
2300         Reviewed by Mark Rowe.
2301
2302         Fix copying of expected results to correct location
2303
2304         * Scripts/run-webkit-tests:
2305
2306 2008-07-09  Eric Seidel  <eric@webkit.org>
2307
2308         Reviewed by aroben.
2309
2310         * DumpRenderTree/LayoutTestController.cpp:
2311         (LayoutTestController::LayoutTestController):
2312         (dumpAsPDFCallback):
2313         (LayoutTestController::staticFunctions):
2314         * DumpRenderTree/LayoutTestController.h:
2315         (LayoutTestController::dumpAsPDF):
2316         (LayoutTestController::setDumpAsPDF):
2317         * DumpRenderTree/mac/DumpRenderTree.mm:
2318         (dumpFrameAsPDF):
2319         (dump):
2320
2321 2008-07-09  Eric Seidel  <eric@webkit.org>
2322
2323         Reviewed by weinig.
2324
2325         Add Content-Type support to DumpRenderTree and run-webkit-tests
2326         and move expected.txt files to expected.webarchive
2327         
2328         https://bugs.webkit.org/show_bug.cgi?id=15565
2329
2330         * DumpRenderTree/cg/ImageDiffCG.cpp:
2331         (compareImages):
2332         (main):
2333         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2334         (printPNG):
2335         * DumpRenderTree/mac/DumpRenderTree.mm:
2336         (dump):
2337         * Scripts/run-webkit-tests:
2338
2339 2008-07-08  Jon Honeycutt  <jhoneycutt@apple.com>
2340
2341         Reviewed by Anders.
2342
2343         Port r34988 to Mac: allow tests to define JavaScript to execute when
2344         NPP_DestroyStream or NPP_URLNotify is called.
2345
2346         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2347         (NPP_New): Remove initialization that happens in pluginAllocate. Look
2348         for new arguments onStreamDestroy and onURLNotify.
2349         (NPP_Destroy): Free onStreamDestroy and onURLNotify.
2350         (executeScript): Code moved from onStreamLoad.
2351         (NPP_NewStream): Call executeScript.
2352         (NPP_DestroyStream): Same.
2353         (NPP_URLNotify): Same.
2354
2355 2008-07-07  Beth Dakin  <bdakin@apple.com>
2356
2357         Reviewed by Anders.
2358
2359         This patch extends DRT accessibility tests to add the ability to 
2360         query the intValue, minValue, and maxValue of the focused element.
2361
2362         * DumpRenderTree/AccessibilityController.cpp:
2363         (intValueOfFocusedElementCallback):
2364         (minValueOfFocusedElementCallback):
2365         (maxValueOfFocusedElementCallback):
2366         (AccessibilityController::staticFunctions):
2367         * DumpRenderTree/AccessibilityController.h:
2368         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2369         (AccessibilityController::intValueOfFocusedElement):
2370         (AccessibilityController::minValueOfFocusedElement):
2371         (AccessibilityController::maxValueOfFocusedElement):
2372
2373 2008-07-07  Steve Falkenburg  <sfalken@apple.com>
2374
2375         Fix build.
2376
2377         * DumpRenderTree/win/ImageDiff.vcproj:
2378
2379 2008-07-02  Jon Honeycutt  <jhoneycutt@apple.com>
2380
2381         Allow tests to define JavaScript to execute when NPP_DestroyStream or
2382         NPP_URLNotify is called.
2383
2384         Reviewed by Anders.
2385
2386         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add a new
2387         property, "returnErrorFromNewStream." This is to support the test for
2388         <rdar://5983747> Safari crashes trying to load the SilverLight plugin,
2389         caused by WebKit calling NPP_DestroyStream after a plug-in returns an
2390         error from NPP_NewStream.
2391         (pluginGetProperty): 
2392         (pluginSetProperty):
2393         (pluginAllocate):
2394         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Added new
2395         members, onStreamDestroy and onURLNotify.
2396         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
2397         (NPP_New): Remove initialization of onStreamLoad; this was moved to
2398         pluginAllocate. Look for new arguments onStreamDestroy and
2399         onURLNotify, and store their values.
2400         (NPP_Destroy): Free new members.
2401         (executeScript): Code moved from onStreamLoad
2402         (NPP_NewStream): If returnErrorFromNewStream has been set to true,
2403         return a generic error code. If onStreamLoad is set, execute it as
2404         JavaScript.
2405         (NPP_DestroyStream): If onStreamDestroy is set, execute it as JS.
2406         (NPP_URLNotify): Same, for onURLNotify.
2407
2408 2008-07-02  Brady Eidson  <beidson@apple.com>
2409
2410         Reviewed by Mitz Pettel and John Sullivan
2411
2412         Add the ability to tell DRT to call stopLoading on a WebFrame inside of a didStartProvisionalLoadForFrame
2413         load delegate.
2414
2415         Required to add a layout test for the fix for <rdar://problem/5549871>
2416
2417         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2418         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): If stopProvisionalFrameLoads is set, call
2419           [WebFrame stopLoading] to test for the crash reflected in 5549871
2420
2421         All of the following are infrastructure to add the layoutTestController.setStopProvisionalFrameLoads() call:
2422         * DumpRenderTree/LayoutTestController.cpp:
2423         (LayoutTestController::LayoutTestController):
2424         (setStopProvisionalFrameLoadsCallback):
2425         (LayoutTestController::staticFunctions):
2426         * DumpRenderTree/LayoutTestController.h:
2427         (LayoutTestController::stopProvisionalFrameLoads):
2428         (LayoutTestController::setStopProvisionalFrameLoads):
2429
2430 2008-07-01  Chris Fleizach  <cfleizach@apple.com>
2431
2432         Reviewed by Beth Dakin
2433
2434         Support ability to get width and height of an element through accessibility
2435
2436         * DumpRenderTree/AccessibilityController.cpp:
2437         (widthOfFocusedElementCallback):
2438         (heightOfFocusedElementCallback):
2439         (AccessibilityController::staticFunctions):
2440         * DumpRenderTree/AccessibilityController.h:
2441         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2442         (AccessibilityController::widthOfFocusedElement):
2443         (AccessibilityController::heightOfFocusedElement):
2444
2445 2008-06-30  Chris Fleizach  <cfleizach@apple.com>
2446
2447         Reviewed by Beth Dakin
2448
2449         Support the ability to get the linked ui elements of an object
2450
2451         * DumpRenderTree/AccessibilityController.cpp:
2452         (attributesOfLinkedUIElementsForFocusedElementCallback):
2453         (AccessibilityController::staticFunctions):
2454         * DumpRenderTree/AccessibilityController.h:
2455         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2456         (AccessibilityController::attributesOfLinkedUIElementsForFocusedElement):
2457         (AccessibilityController::allAttributesOfFocusedElement):
2458         (attributesOfElement):
2459         (nsStringToJSStringRef):
2460
2461 2008-06-29  Sam Weinig  <sam@webkit.org>
2462
2463         Fix Tiger build.
2464
2465         * DumpRenderTree/mac/EventSendingController.mm:
2466         (eventTypeForMouseButtonAndAction):
2467
2468 2008-06-27  Eric Seidel  <eric@webkit.org>
2469
2470         Reviewed by darin.
2471
2472         Add multi-button mouseevent support to DRT
2473         https://bugs.webkit.org/show_bug.cgi?id=15173
2474         
2475         It's now possible to specify the mouse button with:
2476         eventSender.mouseDown(1); eventSender.mouseUp(1); etc.
2477
2478         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2479         * DumpRenderTree/mac/EventSendingController.h:
2480         * DumpRenderTree/mac/EventSendingController.mm:
2481         (+[EventSendingController isSelectorExcludedFromWebScript:]):
2482         (+[EventSendingController webScriptNameForSelector:]):
2483         (eventTypeForMouseButtonAndAction):
2484         (-[EventSendingController updateClickCountForButton:]):
2485         (-[EventSendingController mouseDown:]):
2486         (-[EventSendingController mouseUp:]):
2487         (-[EventSendingController mouseMoveToX:Y:]):
2488         (-[EventSendingController contextClick]):
2489
2490 2008-06-28  Nikolas Zimmermann  <zimmermann@kde.org>
2491
2492         Reviewed by Oliver.
2493
2494         Copy <test>-expected.png from the right location to /tmp/layout-test-results.
2495         Use $expectedPixelDir instead of $expectedDir. Allows using SVG pixel tests again.
2496
2497         * Scripts/run-webkit-tests:
2498
2499 2008-06-27  Jan Michael Alonzo  <jmalonzo@webkit.org>
2500
2501         Reviewed by Christian Dywan.
2502
2503         [Gtk] Initialize webview settings before running DRT tests
2504         http://bugs.webkit.org/show_bug.cgi?id=19778
2505
2506         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2507         (setDefaultsToConsistentStateValuesForTesting):
2508         (main):
2509
2510 2008-06-26  Darin Adler  <darin@apple.com>
2511
2512         * Scripts/check-for-weak-vtables: Fixed comment.
2513
2514 2008-06-26  Darin Adler  <darin@apple.com>
2515
2516         * Scripts/check-for-weak-vtables: Added.
2517
2518 2008-06-26  Beth Dakin  <bdakin@apple.com>
2519
2520         Reviewed by Sam.
2521
2522         Do not include AXPosition in the dump of all of the accessibility 
2523         attributes since it is screen-specific.
2524
2525         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2526         (AccessibilityController::allAttributesOfFocusedElement):
2527
2528 2008-06-26  Beth Dakin  <bdakin@apple.com>
2529
2530         Reviewed by Anders.
2531
2532         This is a speculative fix for the failing layout test on the build 
2533         bot. It seems that the problem that the Build Bot is having is 
2534         Tiger-specific. On Tiger, [NSValue description] was not very smart. 
2535         So I replaced our call to description with a hand-rolled equivalent 
2536         that will match on both platforms. 
2537
2538         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2539         (descriptionOfValue):
2540
2541 2008-06-25  Beth Dakin  <bdakin@apple.com>
2542
2543         Reviewed by Sam Weinig.
2544
2545         This patch adds support to the AccessibilityController to query the 
2546         following attributes specifically, without a full attribute dump: 
2547         AXRole, AXTitle, and AXDescription.
2548
2549         * DumpRenderTree/AccessibilityController.cpp:
2550         (allAttributesForFocusedElementCallback):
2551         (roleOfFocusedElementCallback):
2552         (titleOfFocusedElementCallback):
2553         (descriptionOfFocusedElementCallback):
2554         (AccessibilityController::staticFunctions):
2555         * DumpRenderTree/AccessibilityController.h:
2556         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2557         (AccessibilityController::allAttributesForFocusedElement):
2558         (concatenateAttributeAndValue):
2559         (AccessibilityController::roleOfFocusedElement):
2560         (AccessibilityController::titleOfFocusedElement):
2561         (AccessibilityController::descriptionOfFocusedElement):
2562
2563 2008-06-24  Dan Bernstein  <mitz@apple.com>
2564
2565         Reviewed by Stephanie Lewis.
2566
2567         - move the linker flags from the debug configuration in the project
2568           to the shared configuration
2569
2570         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2571         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2572
2573 2008-06-24  Dan Bernstein  <mitz@apple.com>
2574
2575         - try to fix the Tiger build
2576
2577         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2578
2579 2008-06-24  Sam Weinig and Beth Dakin  <bdakin@apple.com and sam@webkit.org>
2580
2581         Reviewed by Darin Adler.
2582
2583         Fix for <rdar://problem/5884881> Make DumpRenderTree support 
2584         accessibility tests
2585
2586         This patch adds some basic support for accessibility layout tests 
2587         on the Mac.
2588
2589         * DumpRenderTree/AccessibilityController.cpp: Added.
2590         (AccessibilityController::AccessibilityController):
2591         (AccessibilityController::~AccessibilityController):
2592         (dumpCurrentAttributesCallback):
2593         (AccessibilityController::makeWindowObject):
2594         (AccessibilityController::getJSClass):
2595         (AccessibilityController::staticFunctions):
2596         * DumpRenderTree/AccessibilityController.h: Added.
2597         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2598         * DumpRenderTree/mac/AccessibilityControllerMac.mm: Added.
2599         (descriptionOfValue):
2600         (AccessibilityController::dumpCurrentAttributes):
2601         * DumpRenderTree/mac/DumpRenderTree.mm:
2602         * DumpRenderTree/mac/FrameLoadDelegate.h:
2603         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2604         (-[FrameLoadDelegate init]):
2605         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2606
2607 2008-06-24  John Sullivan  <sullivan@apple.com>
2608
2609         Reviewed by Dan Bernstein
2610
2611         * Scripts/extract-localizable-strings:
2612         add UI_STRING_LOCALIZE_LATER, LPCTSTR_UI_STRING_LOCALIZE_LATER, and LOG_WARNING to the 
2613         list of debugging macros, to avoid noise when keeping the list of localized string 
2614         exceptions up to date
2615
2616 2008-06-24  Dan Bernstein  <mitz@apple.com>
2617
2618         Rubber-stamped by Darin Adler.
2619
2620         - add a font family for testing font-weight
2621
2622         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linker
2623         flags to create data sections for the WeightWatcher fonts.
2624         * DumpRenderTree/fonts: Added.
2625         * DumpRenderTree/fonts/WebKitWeightWatcher100.ttf: Added.
2626         * DumpRenderTree/fonts/WebKitWeightWatcher200.ttf: Added.
2627         * DumpRenderTree/fonts/WebKitWeightWatcher300.ttf: Added.
2628         * DumpRenderTree/fonts/WebKitWeightWatcher400.ttf: Added.
2629         * DumpRenderTree/fonts/WebKitWeightWatcher500.ttf: Added.
2630         * DumpRenderTree/fonts/WebKitWeightWatcher600.ttf: Added.
2631         * DumpRenderTree/fonts/WebKitWeightWatcher700.ttf: Added.
2632         * DumpRenderTree/fonts/WebKitWeightWatcher800.ttf: Added.
2633         * DumpRenderTree/fonts/WebKitWeightWatcher900.ttf: Added.
2634         * DumpRenderTree/mac/DumpRenderTree.mm:
2635         (activateFonts): Renamed activateAhemFont to this and made it activate
2636         the WeightWatcher fonts in addition to Ahem.
2637         (prepareConsistentTestingEnvironment): Adjusted for the name change.
2638         * DumpRenderTree/win/DumpRenderTree.cpp:
2639         (initialize): Added the WeightWatcher fonts.
2640
2641 2008-06-20  Brent Fulgham  <bfulgham@gmail.com>
2642
2643         Reviewed by Darin Adler.
2644
2645         Extend the build-webkit (and set-webkit-configuration) script to
2646         support Cairo-based webkit builds.  (see http://bugs.webkit.org/show_bug.cgi?17952)
2647
2648         * Scripts/build-webkit:  Add --cairo-win32 to the help message
2649         * Scripts/webkitdirs.pm:  Extend the 'determinePassedConfiguration
2650           subroutine to recognize the --cairo-win32 flag.  When present,
2651           the build configuration is changed from Debug/Release to
2652           Debug_Cairo/Release_Cairo.  This flag is only active when the
2653           isCygwin() test is true.
2654
2655 2008-06-17  Dan Bernstein  <mitz@apple.com>
2656
2657         Reviewed by Justin Garcia.
2658
2659         - prefer Leopard results when running on Snow Leopard.
2660
2661         * Scripts/run-webkit-tests: Added a mapping of Snow Leopard to
2662           mac-leopard.
2663         * Scripts/webkitdirs.pm: Added isSnowLeopard().
2664
2665 2008-06-15  Darin Adler  <darin@apple.com>
2666
2667         * Scripts/do-webcore-rename: Updated for the latest round of renaming.
2668
2669 2008-06-15  Darin Adler  <darin@apple.com>
2670
2671         * Scripts/do-webcore-rename: Updated for the latest round of renaming.
2672
2673 2008-06-15  Darin Adler  <darin@apple.com>
2674
2675         * Scripts/do-webcore-rename: Updated for the latest round of renaming.
2676
2677 2008-06-15  Darin Adler  <darin@apple.com>
2678
2679         * Scripts/do-webcore-rename: Updated for the latest round of renaming.
2680
2681 2008-06-15  Darin Adler  <darin@apple.com>
2682
2683         * Scripts/do-file-rename: Updated.
2684         * Scripts/do-webcore-rename: Updated for the latest round of renaming.
2685
2686 2008-06-15  Darin Adler  <darin@apple.com>
2687
2688         * Scripts/do-file-rename: Updated for the latest round of renaming.
2689         * Scripts/do-webcore-rename: Tweaked and reorganized a bit.
2690
2691 2008-06-15  Darin Adler  <darin@apple.com>
2692
2693         * Scripts/create-exports: Added.
2694         * Scripts/do-file-rename: Added some planned renames.
2695         * Scripts/do-webcore-rename: Updated for the latest round of renaming.
2696
2697 2008-06-15  Darin Adler  <darin@apple.com>
2698
2699         * Scripts/do-webcore-rename: Updated for the latest round of renaming.
2700
2701 2008-06-15  Maciej Stachowiak  <mjs@apple.com>
2702
2703         Reviewed by Oliver.
2704         
2705         - rename testkjs to jsc
2706
2707         * Scripts/build-jsc: Copied from Scripts/build-testkjs.
2708         * Scripts/build-testkjs: Removed.
2709         * Scripts/run-javascriptcore-tests:
2710         * Scripts/run-jsc: Copied from Scripts/run-testkjs.
2711         * Scripts/run-sunspider:
2712         * Scripts/run-testkjs: Removed.
2713         * Scripts/sunspider-compare-results:
2714
2715 2008-06-14  Darin Adler  <darin@apple.com>
2716
2717         * Scripts/do-webcore-rename: Moved planned renames into a separate hash
2718         from the actual renames. Removed many renames that are either done or
2719         no longer planned.
2720
2721 2008-06-14  Darin Adler  <darin@apple.com>
2722
2723         * Scripts/do-webcore-rename: Fixed obvious typo.
2724
2725 2008-06-13  Darin Adler  <darin@apple.com>
2726
2727         * Scripts/make-js-test-wrappers: Added three more exceptions.
2728
2729 2008-06-10  Joerg Bornemann  <joerg.bornemann@trolltech.com>
2730
2731         Reviewed by Simon.
2732
2733         For the qmake based build make it possible to build against makespecs where
2734         QMAKE_CC is defined in a configuration file included from qmake.conf.
2735
2736         * Scripts/webkitdirs.pm: Added support for include() statements in
2737         qmake.conf.
2738
2739 2008-06-09  Alp Toker  <alp@nuanti.com>
2740
2741         gcc3/autotools build fix. Add explicit -O2 -fno-strict-aliasing to
2742         each of the tools since these are no longer set globally.
2743
2744         * GNUmakefile.am:
2745
2746 2008-06-08  Darin Adler  <darin@apple.com>
2747
2748         * Scripts/make-js-test-wrappers: Added another exception.
2749
2750 2008-06-07  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
2751
2752         Reviewed by Timothy.
2753
2754         Remove the --squirrelfish option from SunSpider, as it is no longer needed.
2755
2756         * Scripts/run-sunspider:
2757
2758 2008-06-05  Alp Toker  <alp@nuanti.com>
2759
2760         Build fix for r34387.
2761
2762         * GNUmakefile.am:
2763
2764 2008-06-04  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
2765
2766         Reviewed by Oliver.
2767
2768         Add an exception for Opcode.o to the global initializers check so that
2769         we can dump instruction statistics in the JavaScript virtual machine.
2770
2771         * Scripts/check-for-global-initializers:
2772
2773 2008-05-30  Steve Falkenburg  <sfalken@apple.com>
2774
2775         Generate an isolated COM manifest for registry free COM.
2776         
2777         * DumpRenderTree/win/DumpRenderTree.vcproj:
2778
2779 2008-06-02  Anders Carlsson  <andersca@apple.com>
2780
2781         Reviewed by David Hyatt and Mitz.
2782
2783         <rdar://problem/5704119> 
2784         repro crash in WebCore::RenderPart::setWidget (plugin-related?)
2785         
2786         Call -[WebView display] in the "plug-in" failed delegate method, simulating
2787         the sheet that Safari puts up.
2788         
2789         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2790         (-[ResourceLoadDelegate webView:plugInFailedWithError:dataSource:]):
2791
2792 2008-05-30  Timothy Hatcher  <timothy@apple.com>
2793
2794         Made the starting line number of scripts be 1-based throughout the engine.
2795         This cleans up script line numbers so they are all consistent now.
2796
2797         Reviewed by Oliver Hunt.
2798
2799         * DumpRenderTree/mac/ObjCController.m:
2800         (runJavaScriptThread): Pass a line number of 1 instead of 0 to JSEvaluateScript.
2801         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
2802         (runJavaScriptThread): Ditto.
2803         * DumpRenderTree/win/DumpRenderTree.cpp:
2804         (runJavaScriptThread): Ditto.
2805
2806 2008-05-29  Geoffrey Garen  <ggaren@apple.com>
2807
2808         Reviewed by Adam Roben.
2809
2810         Fixed VCSUtils.pm to work with git repositories inside symlinks.
2811
2812         * Scripts/VCSUtils.pm: Compute a relative path from the git repository
2813         root, instead of the root of the filesystem, to work around a bug in
2814         abs2rel when traversing symlinked home directories.
2815
2816 2008-05-29  Kevin Ollivier  <kevino@theolliviers.com>
2817
2818         Reviewed by Darin Adler.
2819         
2820         Restore original behavior of isOSX() referring to the Mac port, not the OS itself.
2821         
2822         https://bugs.webkit.org/show_bug.cgi?id=19311
2823
2824         * Scripts/webkitdirs.pm:
2825
2826 2008-05-29  Alexey Proskuryakov  <ap@webkit.org>
2827
2828         Reviewed by Adam Roben.
2829
2830         Fix run-iexploder-tests and run-mangleme-tests to work with updated shared scripts and
2831         configuration files.
2832
2833         * Scripts/run-iexploder-tests:
2834         * Scripts/run-mangleme-tests:
2835         Renamed runSafari to not conflict with the one in webkitdirs.
2836         Added SSLCertificateFile option for httpd, as now needed.
2837
2838 2008-05-27  Kevin Ollivier  <kevino@theolliviers.com>
2839
2840         wx build fix. Update the sample app after wxWebFrame->wxWebBrowserShell rename.
2841
2842         * wx/browser/browser.cpp:
2843         (MyApp::OnInit):
2844
2845 2008-05-24  Andreia Gaita  <shana@isninja.com>
2846
2847         Reviewed by Alp Toker.
2848
2849         cygwin-downloader.py fixes.
2850
2851         Remove two non-working mirrors. Add a check for missing dependency
2852         packages to avoid bailing out on an inconsistent Cygwin package list.
2853
2854         * CygwinDownloader/cygwin-downloader.py:
2855
2856 2008-05-24  Jan Michael Alonzo  <jmalonzo@webkit.org>
2857
2858         Reviewed by Darin Adler.
2859
2860         Remove useQmake usage. QMake build doesn't support Gtk port
2861         anymore.
2862
2863         Also fix 2 occurences of "Web Kit". Should be WebKit.
2864
2865         * Scripts/build-webkit:
2866         * Scripts/run-javascriptcore-tests:
2867         * Scripts/run-launcher:
2868         * Scripts/run-webkit-tests:
2869         * Scripts/webkitdirs.pm:
2870
2871 2008-05-22  Stephanie Lewis  <slewis@apple.com>
2872
2873         Reviewed by Dan.
2874
2875         implement the beforeUnload UI delegate so that DRT will dispatch beforeunload events.
2876
2877         * DumpRenderTree/mac/UIDelegate.mm:
2878         (-[UIDelegate webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:]):
2879         * DumpRenderTree/win/UIDelegate.cpp:
2880         (SearchableWebViewHost::runBeforeUnloadConfirmPanelWithMessage):
2881
2882 2008-05-21  Adele Peterson  <adele@apple.com>
2883
2884         Reviewed by Adam.
2885
2886         DumpRenderTree support for <rdar://problem/5787733> fast/dom/HTMLDocument/hasFocus.html fails on Windows
2887
2888         * DumpRenderTree/win/UIDelegate.cpp:
2889         (UIDelegate::webViewFocus): Added.
2890         (UIDelegate::webViewUnfocus): Added.
2891         * DumpRenderTree/win/UIDelegate.h:
2892
2893 2008-05-21  Mark Rowe  <mrowe@apple.com>
2894
2895         Rubber-stamped by Stephanie Lewis.
2896
2897         Set the pass_through flag on Getopt so that extra arguments can be passed through to Safari,
2898         rather than trigger an unknown argument message.  This allows run-webkit-tests to display results
2899         once more.
2900
2901         * Scripts/run-safari:
2902
2903 2008-05-21  Stephanie Lewis  <slewis@apple.com>
2904
2905         Reviewed by Maciej, Mark.
2906   
2907         arch doesn't take arguments on tiger.  expand DRT timeout for guardMalloc.
2908
2909         * Scripts/run-webkit-tests:
2910         * Scripts/webkitdirs.pm:
2911
2912 2008-05-20  Mark Rowe  <mrowe@apple.com>
2913
2914         Reviewed by Stephanie Lewis.
2915
2916         Improve the behavior of run-webkit-tests with 64-bit WebKit by automatically inferring whether to run 64-bit.
2917
2918         If --64-bit is not passed to run-webkit-tests, attempt to guess whether we should run 64-bit.
2919         This decision is made based on the 64-bitness of the built WebKit framework if it exists, and
2920         can be manually overridden by passing --64-bit or --no-64-bit.  This removes the need to always
2921         pass an argument to run-webkit-tests after having built with "make x86_64".
2922
2923         * Scripts/gdb-safari:
2924         * Scripts/run-safari:
2925         * Scripts/run-webkit-tests:
2926         * Scripts/webkitdirs.pm: Split the setting of the 64-bit flag, the determination of the
2927         preferred architecture, and exporting of the environment variables for 'arch' out into
2928         separate subroutines.
2929
2930 2008-05-20  Mark Rowe  <mrowe@apple.com>
2931
2932         Fix "make x86_64" by adding x86_64 target to WebKitTools Makefile.
2933
2934         * Makefile:
2935
2936 === End merge of squirrelfish ===
2937
2938 2008-04-14  Maciej Stachowiak  <mjs@apple.com>
2939
2940         Reviewed by Oliver.
2941         
2942         - added support for --ubench mode
2943
2944         * Scripts/run-sunspider:
2945
2946 2008-03-26  Geoffrey Garen  <ggaren@apple.com>
2947
2948         Reviewed by Oliver Hunt.
2949
2950         --squirrelfish mode: pared down tests for squirrelfish to chew on.
2951
2952         * Scripts/run-sunspider:
2953
2954 === Start merge of squirrelfish ===
2955
2956 2008-05-21  Darin Adler  <darin@apple.com>
2957
2958         * Scripts/make-js-test-wrappers: Added another exception.
2959
2960 2008-05-19  Stephanie Lewis  <slewis@apple.com>
2961
2962         Reviewed by Adam.
2963
2964         Explicitly set run mode to 32bit unless overridden to avoid
2965         confusion when running tests
2966
2967         * Scripts/build-dumprendertree:
2968         * Scripts/gdb-safari:
2969         * Scripts/run-webkit-tests:
2970         * Scripts/webkitdirs.pm:
2971
2972 2008-05-16  Stephanie Lewis  <slewis@apple.com>
2973
2974         Reviewed by Steve.
2975
2976         Print out pending unload event count. Also print out main frame name to match Mac.         
2977
2978         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2979         (descriptionSuitableForTestResult):
2980         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
2981
2982 2008-05-16  Timothy Hatcher  <timothy@apple.com>
2983
2984         Remove the Drosera project, code and resources since it has been
2985         replaced with the Web Inspector's debugger. Removes references to
2986         Drosera in various scripts and makefiles.
2987
2988         Rubber-stamped by Mark Rowe.
2989
2990         * BuildSlaveSupport/build-launcher-app:
2991         * Drosera/DebuggerDocument.cpp: Removed.
2992         * Drosera/DebuggerDocument.h: Removed.
2993         * Drosera/Drosera.icns: Removed.
2994         * Drosera/DroseraWin.make: Removed.
2995         * Drosera/English.lproj/Debugger.nib/classes.nib: Removed.
2996         * Drosera/English.lproj/Debugger.nib/info.nib: Removed.
2997         * Drosera/English.lproj/Debugger.nib/keyedobjects.nib: Removed.
2998         * Drosera/English.lproj/MainMenu.nib/classes.nib: Removed.
2999         * Drosera/English.lproj/MainMenu.nib/info.nib: Removed.
3000         * Drosera/English.lproj/MainMenu.nib/keyedobjects.nib: Removed.
3001         * Drosera/ForwardingHeaders/wtf/Assertions.h: Removed.
3002         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Removed.
3003         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Removed.
3004         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Removed.
3005         * Drosera/ForwardingHeaders/wtf/Platform.h: Removed.
3006         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Removed.
3007         * Drosera/Images/Drosera.ico: Removed.
3008         * Drosera/Images/SourceArrow.png: Removed.
3009         * Drosera/Images/SourceArrowBlank.png: Removed.
3010         * Drosera/Images/SourceArrowOpen.png: Removed.
3011         * Drosera/Images/background_stripe.png: Removed.
3012         * Drosera/Images/breakPoint.tif: Removed.
3013         * Drosera/Images/breakPointDisabled.tif: Removed.
3014         * Drosera/Images/breakpointeditor.png: Removed.
3015         * Drosera/Images/close.tif: Removed.
3016         * Drosera/Images/close_active.tif: Removed.
3017         * Drosera/Images/close_hover.tif: Removed.
3018         * Drosera/Images/console.png: Removed.
3019         * Drosera/Images/continue.tif: Removed.
3020         * Drosera/Images/fileIcon.jpg: Removed.
3021         * Drosera/Images/finishFunction.tif: Removed.
3022         * Drosera/Images/glossyFooterFill.tif: Removed.
3023         * Drosera/Images/glossyHeader.png: Removed.
3024         * Drosera/Images/glossyHeaderPressed.png: Removed.
3025         * Drosera/Images/gradientBackground.png: Removed.
3026         * Drosera/Images/gutter.png: Removed.
3027         * Drosera/Images/navLeftDisabled.png: Removed.
3028         * Drosera/Images/navLeftNormal.png: Removed.
3029         * Drosera/Images/navLeftPressed.png: Removed.
3030         * Drosera/Images/navRightDisabled.png: Removed.
3031         * Drosera/Images/navRightNormal.png: Removed.
3032         * Drosera/Images/navRightPressed.png: Removed.
3033         * Drosera/Images/pause.tif: Removed.
3034         * Drosera/Images/popUpArrows.png: Removed.
3035         * Drosera/Images/programCounter.tif: Removed.
3036         * Drosera/Images/programCounterBreakPoint.tif: Removed.
3037         * Drosera/Images/programCounterBreakPointDisabled.tif: Removed.
3038         * Drosera/Images/run.tif: Removed.
3039         * Drosera/Images/siteCollapsed.tif: Removed.
3040         * Drosera/Images/siteExpanded.tif: Removed.
3041         * Drosera/Images/siteIcon.tif: Removed.
3042         * Drosera/Images/small.ico: Removed.
3043         * Drosera/Images/splitterBar.tif: Removed.
3044         * Drosera/Images/splitterDimple.tif: Removed.
3045         * Drosera/Images/step.tif: Removed.
3046         * Drosera/Images/stepOut.tif: Removed.
3047         * Drosera/Images/stepOver.tif: Removed.
3048         * Drosera/Images/stop.tif: Removed.
3049         * Drosera/Images/toolbarBackground.png: Removed.
3050         * Drosera/Images/verticalSplitterBar.tiff: Removed.
3051         * Drosera/Images/verticalSplitterDimple.tiff: Removed.
3052         * Drosera/Makefile: Removed.
3053         * Drosera/breakpointEditor.html: Removed.
3054         * Drosera/config.h: Removed.
3055         * Drosera/console.css: Removed.
3056         * Drosera/console.html: Removed.
3057         * Drosera/console.js: Removed.
3058         * Drosera/debugger.css: Removed.
3059         * Drosera/debugger.html: Removed.
3060         * Drosera/debugger.js: Removed.
3061         * Drosera/mac/DebuggerApplication.h: Removed.
3062         * Drosera/mac/DebuggerApplication.mm: Removed.
3063         * Drosera/mac/DebuggerClient.h: Removed.
3064         * Drosera/mac/DebuggerClient.mm: Removed.
3065         * Drosera/mac/DebuggerDocumentPlatform.mm: Removed.
3066         * Drosera/mac/Drosera.xcodeproj/project.pbxproj: Removed.
3067         * Drosera/mac/Info.plist: Removed.
3068         * Drosera/mac/LauncherInfo.plist: Removed.
3069         * Drosera/mac/Makefile: Removed.
3070         * Drosera/mac/ServerConnection.h: Removed.
3071         * Drosera/mac/ServerConnection.mm: Removed.
3072         * Drosera/mac/launcher.m: Removed.
3073         * Drosera/mac/main.m: Removed.
3074         * Drosera/viewer.css: Removed.
3075         * Drosera/viewer.html: Removed.
3076         * Drosera/win/BaseDelegate.h: Removed.
3077         * Drosera/win/DebuggerClient.cpp: Removed.
3078         * Drosera/win/DebuggerClient.h: Removed.
3079         * Drosera/win/DebuggerDocumentPlatform.cpp: Removed.
3080         * Drosera/win/Drosera.cpp: Removed.
3081         * Drosera/win/Drosera.h: Removed.
3082         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed.
3083         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed.
3084         * Drosera/win/DroseraPrefix.cpp: Removed.
3085         * Drosera/win/DroseraPrefix.h: Removed.
3086         * Drosera/win/Info.plist: Removed.
3087         * Drosera/win/ServerConnection.cpp: Removed.
3088         * Drosera/win/ServerConnection.h: Removed.
3089         * Drosera/win/resource.h: Removed.
3090         * Makefile:
3091         * Scripts/build-drosera: Removed.
3092         * Scripts/gdb-drosera: Removed.
3093         * Scripts/run-drosera: Removed.
3094         * Scripts/run-drosera-nightly.cmd: Removed.
3095         * Scripts/run-drosera.cmd: Removed.
3096         * Scripts/webkitdirs.pm:
3097
3098 2008-05-15  Stephanie Lewis  <slewis@apple.com>
3099
3100         Reviewed by Anders.
3101
3102         Dump the unload count for a frame after parsing is finished.
3103
3104         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3105         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
3106
3107 2008-05-15  Alexey Proskuryakov  <ap@webkit.org>
3108
3109         Reviewed by Dan Bernstein.
3110
3111         https://bugs.webkit.org/show_bug.cgi?id=10707
3112         DumpRenderTree should not be able to access non-local resources
3113
3114         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3115         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3116         Block them, and complain.
3117
3118 2008-05-15  Kevin Ollivier  <kevino@theolliviers.com>
3119
3120         wx build fix. Update the version of libpng to download and instsall.
3121
3122         * wx/install-unix-extras:
3123
3124 2008-05-14  Julien Chaffraix  <jchaffraix@webkit.org>
3125
3126         Reviewed by Eric.
3127
3128         - isDarwin() and isCygwin() returned an empty string if the platform equality check fails.
3129           We now force the return value to be numeric.
3130
3131         - Removed platform checks as it was a work around the previous issue.
3132
3133         - Replaced isDarwin() by isOSX() as they have now the same behaviour.
3134
3135         * Scripts/build-webkit:
3136         * Scripts/webkitdirs.pm:
3137
3138 2008-05-12  Adam Roben  <aroben@apple.com>
3139
3140         Support for testing NPN_PostURL
3141
3142         Reviewed by Anders Carlsson.
3143
3144         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3145         (toCString): Added this helper function.
3146         (testPostURLFile): Added. Writes the passed-in content to the
3147         passed-in file and calls NPN_PostURL with the passed-in URL and
3148         target.
3149         (pluginInvoke): Added a case for testPostURLFile.
3150         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3151         (followShortcuts): Changed to allow paths that don't yet exist.
3152
3153 2008-05-12  Mark Rowe  <mrowe@apple.com>
3154
3155         Reviewed by Sam Weinig.
3156
3157         Minor cleanup of the DRT Xcode project.
3158
3159         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:  Use GCC_OPTIMIZATION_LEVEL rather than
3160         OPTIMIZATION_CFLAGS.  Don't include Info.plist in the "Copy Bundle Resources" build phase as it does
3161         not need to be there.
3162
3163 2008-05-12  Anders Carlsson  <andersca@apple.com>
3164
3165         Reviewed by Adam.
3166
3167         Add support for testing application caches.
3168         
3169         * DumpRenderTree/mac/DumpRenderTree.mm:
3170         (dumpRenderTree):
3171         Empty the cache.
3172         
3173         (resetWebViewToConsistentStateBeforeTesting):
3174         Turn on support for the application cache.
3175
3176 2008-05-09  Mark Rowe  <mrowe@apple.com>
3177
3178         Reviewed by Anders Carlsson.
3179
3180         Update TestNetscapePlugIn to build 64-bit using the Cocoa event model.
3181
3182         It currently does not attempt to print events which means that plugins/mouse-events.html
3183         will fail when run 64-bit.  All other tests that use this plugin pass.
3184
3185         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3186         (testGetIntIdentifier):
3187         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3188         (NPP_New):
3189         (NPP_HandleEvent):
3190
3191 2008-05-09  Brady Eidson  <beidson@apple.com>
3192
3193         Reviewed by Adam Roben
3194
3195         Explicitly call shutDownWebKit() before quitting.
3196
3197         * Drosera/win/Drosera.cpp:
3198         (_tWinMain):
3199
3200         * DumpRenderTree/win/DumpRenderTree.cpp:
3201         (main):
3202
3203 2008-05-09  Mark Rowe  <mrowe@apple.com>
3204
3205         Fix the Tiger build of Drosera.
3206
3207         * Drosera/config.h: Define BUILDING_ON_TIGER when building on Tiger.
3208
3209 2008-05-09  Sam Weinig  <sam@webkit.org>
3210
3211         Rubber-stamped by Mark Rowe.
3212
3213         Remove the ENABLE_CROSS_DOCUMENT_MESSAGING #ifdefs.
3214
3215         * Scripts/build-webkit:
3216
3217 2008-05-08  Mark Rowe  <mrowe@apple.com>
3218
3219         Another attempt at a Tiger build fix.
3220
3221         Use DumpRenderTreeMac.h rather than DumpRenderTree.h as DumpRenderTreePasteboard is not an Obj-C++ file.
3222
3223         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
3224
3225 2008-05-08  Mark Rowe  <mrowe@apple.com>
3226
3227         Tiger build fix.  Include DumpRenderTree.h so that BUILDING_ON_TIGER will be defined.
3228
3229         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
3230
3231 2008-05-08  Mark Rowe  <mrowe@apple.com>
3232
3233         Reviewed by Oliver Hunt and Dan Bernstein.
3234
3235         Update DumpRenderTree to build 64-bit.
3236
3237         The three major changes here are:
3238         1) Use NSInteger in the appropriate places.
3239         2) Use ColorSync API that is available in 64-bit to switch display profiles.
3240         3) Use method-swizzling to achieve similar results to class posing when using the Obj-C 2.0 runtime.
3241
3242         The build of DumpRenderTree will still fail in 64-bit for now as the TestNetscapePlugIn target also
3243         needs updated to successfully build.
3244
3245         * DumpRenderTree/mac/Configurations/Base.xcconfig: Don't prevent Xcode from building 64-bit.
3246         * DumpRenderTree/mac/DumpRenderTree.mm:
3247         (swizzleAllMethods):
3248         (poseAsClass):
3249         (prepareConsistentTestingEnvironment):
3250         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3251         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
3252         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
3253         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3254         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3255         (restoreColorSpace):
3256         (failedGettingCurrentProfile):
3257         (setDefaultColorProfileToRGB):
3258
3259 2008-05-08  Mark Rowe  <mrowe@apple.com>
3260
3261         Reviewed by Darin Adler.
3262
3263         Clean up Drosera so that it will build 64-bit.
3264
3265         * Drosera/mac/DebuggerApplication.mm:
3266         (-[DebuggerApplication numberOfRowsInTableView:]): Use NSInteger rather than int.
3267         (-[DebuggerApplication tableView:objectValueForTableColumn:row:]): Ditto.
3268         * Drosera/mac/Drosera.xcodeproj/project.pbxproj: Use the default value for VALID_ARCHS.
3269
3270 2008-05-07  David Kilzer  <ddkilzer@apple.com>
3271
3272         Use File::Find and Getopt::Long in make-js-test-wrappers
3273
3274         Reviewed by Darin Adler.
3275
3276         * Scripts/make-js-test-wrappers:
3277         - Updated Apple copyright statement.
3278         - Added command-line switch parsing and -h|--help switch.
3279         - Allowed user to pass list of files/directories on which to do
3280           a restricted search for TEMPLATE.html files.  The default
3281           behavior is still to search the entire LayoutTests directory.
3282         - Removed duplicate 'use strict' statement.
3283         - Replaced use of `find` statements with File::Find::find().
3284         - Remove unneeded chomp() calls now that we use File::Find.
3285         (directoryFilter): Added.  Filters .svn directories when used
3286         with File::Find::find().
3287         (findTemplateFiles): Added.  Returns a list of TEMPLATE.html
3288         files found.
3289
3290 2008-05-05  Steve Falkenburg  <sfalken@apple.com>
3291
3292         Copy dependencies of ImageDiff, DumpRenderTree in post-build step.
3293
3294         * DumpRenderTree/win/DumpRenderTree.vcproj:
3295         * DumpRenderTree/win/ImageDiff.vcproj:
3296
3297 2008-05-05  Adele Peterson  <adele@apple.com>
3298
3299         Reviewed by Adam.
3300
3301         Look for the right ImageDiff executable for debug builds.
3302
3303         * Scripts/run-webkit-tests:
3304
3305 2008-05-05  Darin Adler  <darin@apple.com>
3306
3307         * Scripts/run-webkit-tests: Ignore a Java leak showing up in the WebKit
3308         leak tests.
3309
3310 2008-05-05  Ariya Hidayat  <ariya.hidayat@trolltech.com>
3311
3312         Reviewed by Simon.
3313
3314         In the Qt's DumpRenderTree, adjust the web view properly (because W3C SVG 
3315         tests expect to be 480x360)
3316
3317         * DumpRenderTree/qt/DumpRenderTree.cpp:
3318         (WebCore::DumpRenderTree::open):
3319
3320 2008-05-02  Dan Bernstein  <mitz@apple.com>
3321
3322         Reviewed by Adam Roben.
3323
3324         - add an option to svn-apply to set the reviewer name in change logs
3325
3326         * Scripts/svn-apply: Added a [-r|--reviewer name] option.
3327
3328 2008-05-01  David Kilzer  <ddkilzer@apple.com>
3329
3330         Clean up configuration usage in run-webkit-tests
3331
3332         Reviewed by Adam.
3333
3334         * Scripts/run-webkit-tests: Parse configuration switches using
3335         passedConfiguration() from webkitdirs.pm like every other script.
3336         Note that we must still call setConfiguration() afterwards in
3337         case the --configuration switch was used.  Use $configurationOption
3338         when running build-dumprendertree instead of recreating the switch.
3339
3340 2008-04-29  Adam Roben  <aroben@apple.com>
3341
3342         Restore the beloved COMPtr::operator&
3343
3344 2008-04-29  Adam Roben  <aroben@apple.com>
3345
3346         Windows build fixes
3347
3348         Replace COMPtr::operator& with COMPtr::adoptionPointer.
3349
3350 2008-04-25  Alexey Proskuryakov  <ap@webkit.org>
3351
3352         Reviewed by Darin Adler.
3353
3354         Fix run-webkit-tests --threading
3355         and provisionally fix <https://bugs.webkit.org/show_bug.cgi?id=18661>
3356         Proxy server issue in Sunday's Nightly
3357
3358         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
3359         (runJavaScriptThread):
3360         (startJavaScriptThreads):
3361         (stopJavaScriptThreads):
3362         Spawned threads were immediately detached, unlike the original ones, so joining them
3363         made no sense. Now, all threads are created detached, and stopJavaScriptThreads() just
3364         waits for them all to exit.
3365
3366 2008-04-28  Holger Hans Peter Freyther  <zecke@selfish.org>
3367
3368         Reviewed by Simon.
3369
3370         Reset dumping resource load callbacks to false for the next test
3371         
3372
3373         * DumpRenderTree/qt/jsobjects.cpp:
3374         (LayoutTestController::reset):
3375
3376 2008-04-28  Tor Arne Vestbø  <tavestbo@trolltech.com>
3377
3378         Reviewed by Simon.
3379
3380         Adapt to the latest API changes in WebKit/qt/Api.
3381
3382         * DumpRenderTree/qt/DumpRenderTree.cpp:
3383         (WebCore::DumpRenderTree::DumpRenderTree):
3384         * DumpRenderTree/qt/jsobjects.cpp:
3385
3386 2008-04-26  Robin Dunn  <robin@alldunn.com>
3387
3388         Reviewed by Kevin Ollivier.
3389         
3390         Delete the DerivedSources after make clean has been done so that the DerivedSources
3391         don't get re-created. Also, use the proper extension for the Win wxPython extension.
3392         
3393         https://bugs.webkit.org/show_bug.cgi?id=18756
3394
3395         * wx/build-wxwebkit:
3396
3397 2008-04-26  Adam Barth <hk9565@gmail.com>
3398
3399         Reviewed by Adam Roben and Sam Weinig.
3400
3401         Updates LayoutTestController to use host instead of domain.
3402
3403         Collin Jackson <collinj-webkit@collinjackson.com> also contributed to this patch.
3404
3405         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3406         (LayoutTestController::setDatabaseQuota):
3407         * DumpRenderTree/mac/UIDelegate.mm:
3408         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]):
3409
3410 2008-04-26  Kevin Ollivier  <kevino@theolliviers.com>
3411
3412         wx build fix. Need the latest libpng. (Somehow my initial test passed without it.)
3413
3414         * wx/install-unix-extras:
3415
3416 2008-04-26  Robin Dunn  <robin@alldunn.com>
3417
3418         Reviewed by Kevin Ollivier.
3419         
3420         Allow the user to set the path to SWIG using an environment variable.
3421         
3422         https://bugs.webkit.org/show_bug.cgi?id=18660
3423
3424         * wx/build-wxwebkit:
3425
3426 2008-04-26  Kevin Ollivier  <kevino@theolliviers.com>
3427
3428         wx build fix. Download the latest libpng version for building the
3429         dependencies.
3430
3431         * wx/install-unix-extras:
3432
3433 2008-04-25  Holger Hans Peter Freyther  <zecke@selfish.org>
3434
3435         Reviewed by Simon.
3436
3437         Implement dumping of resource load callbacks to pass http/tests/xmlhttprequest/abort-should-cancel-load.html
3438         
3439         Similar to Editing and Frameloading we do the dumping within WebCore
3440         
3441
3442         * DumpRenderTree/qt/jsobjects.cpp:
3443         (LayoutTestController::dumpResourceLoadCallbacks):
3444         * DumpRenderTree/qt/jsobjects.h:
3445
3446 2008-04-24  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
3447
3448         Reviewed by Maciej Stachowiak.
3449
3450         http://bugs.webkit.org/show_bug.cgi?id=18485
3451         Typo and documentation fix for build-webkit
3452
3453         * Scripts/build-webkit:
3454
3455 2008-04-24  Anders Carlsson  <andersca@apple.com>
3456
3457         Reviewed by Sam.
3458
3459         Don't call fprintf from the signal handler.
3460         
3461         * DumpRenderTree/mac/DumpRenderTree.mm:
3462         (crashHandler):
3463
3464 2008-04-23  Adam Roben  <aroben@apple.com>
3465
3466         Make crashes be reported as crashes, not hangs
3467
3468         Reviewed by David Kilzer.
3469
3470         * Scripts/run-webkit-tests:
3471         (top level): Use the new status field of the output from
3472         readFromDumpToolWithTimer to determine if the test crashed or hung.
3473         (sub readFromDumpToolWithTimer):
3474           - If we fail to read a line and $! is not EAGAIN, then we've crashed
3475             and should not try to read any more.
3476           - Changed the timedout field to a more general status field.
3477
3478 2008-04-22  David Kilzer  <ddkilzer@apple.com>
3479
3480         Bug 18683: update-webkit returns 0 even if it fails
3481
3482         <https://bugs.webkit.org/show_bug.cgi?id=18683>
3483
3484         Reviewed by Mitz Pettel.
3485
3486         * Scripts/update-webkit:
3487         (runSvnUpdate): Die if close() fails.
3488
3489 2008-04-21  Adam Roben  <aroben@apple.com>
3490
3491         Flush stdout/stderr after printing every #EOF separator
3492
3493         This fixes a hang when running the pixel tests on Windows
3494
3495         Reviewed by Mitz Pettel.
3496
3497         * DumpRenderTree/win/DumpRenderTree.cpp:
3498         (dump):
3499         (main): We don't have to flush stdout/stderr in the arguments loop
3500         anymore, as runTest flushes for us.
3501
3502 2008-04-21  Adam Roben  <aroben@apple.com>
3503
3504         Fix pixel tests
3505
3506         * Scripts/run-webkit-tests:
3507         (sub readFromDumpToolWithTimer): Use readline instead of read to
3508         ensure that we don't read past the #EOF marker.
3509
3510 2008-04-21  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
3511
3512         Reviewed by Simon.
3513
3514         Build fix for Qt 4.3
3515
3516         * When building WebCore/internal make sure the QT_[BEGIN,END]_NAMESPACE is
3517         always defined. Do this by adding defines to the compiler line
3518
3519         * DumpRenderTree/qt/DumpRenderTree.pro:
3520
3521 2008-04-19  Mike Hommey  <glandium@debian.org>
3522
3523         Reviewed by Alp Toker.
3524
3525         Don't build GtkLauncher and DumpRenderTree with rpath.
3526
3527         * GNUmakefile.am:
3528
3529 2008-04-18  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
3530
3531         Reviewed by Alp Toker.
3532
3533         http://bugs.webkit.org/show_bug.cgi?id=16620
3534         [GTK] Autotools make dist and make check support
3535
3536         Cleanups.
3537
3538         * GNUmakefile.am:
3539
3540 2008-04-18  Adam Roben  <aroben@apple.com>
3541
3542         Drop the hang timer to 30 seconds
3543
3544         This matches what DRT/mac was using.
3545
3546         Reviewed by Mitz Pettel.
3547
3548         * Scripts/run-webkit-tests:
3549
3550 2008-04-18  Adam Roben  <aroben@apple.com>
3551
3552         Get rid of DRT's Watchdog
3553
3554         run-webkit-tests now detects hangs and samples DRT as needed.
3555
3556         Reviewed by Mitz Pettel.
3557
3558         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Removed
3559         Watchdog* files from the project.
3560         * DumpRenderTree/Watchdog.cpp: Removed.
3561         * DumpRenderTree/Watchdog.h: Removed.
3562         * DumpRenderTree/mac/DumpRenderTree.mm: Removed uses of Watchdog
3563         (dumpRenderTree):
3564         (runTest):
3565         * DumpRenderTree/mac/WatchdogMac.h: Removed.
3566         * DumpRenderTree/mac/WatchdogMac.mm: Removed.
3567         * Scripts/run-webkit-tests:
3568         (sub testCrashedOrTimedOut): Call sampleDumpTool() if we timed out.
3569         (sub sampleDumpTool): Added. Writes a sample report to
3570         ~/Library/Logs/DumpRenderTree/HangReport.txt.
3571
3572 2008-04-18  Simon Hausmann  <hausmann@webkit.org>
3573
3574         Reviewed by Holger.
3575
3576         Adapt to the API changes in WebKit/qt
3577
3578         * DumpRenderTree/qt/DumpRenderTree.cpp:
3579         (WebCore::WebPage::WebPage):
3580         (WebCore::DumpRenderTree::DumpRenderTree):
3581         (WebCore::DumpRenderTree::initJSObjects):
3582         (WebCore::DumpRenderTree::dumpFramesAsText):
3583         (WebCore::DumpRenderTree::dump):
3584
3585 2008-04-17  Adam Roben  <aroben@apple.com>
3586
3587         Fix many tests on Windows
3588
3589         * Scripts/run-webkit-tests:
3590         (readFromDumpToolWithTimer):
3591          - Use read instead of sysread to ensure that we don't interfere with
3592            other uses of buffered IO in this script.
3593         (setFileHandleNonBlocking): Actually set the filehandle to blocking
3594         when specified.
3595
3596 2008-04-17  Adam Roben  <aroben@apple.com>
3597
3598         Fix ~10 tests
3599
3600         * Scripts/run-webkit-tests: Only remove the newline after #EOF, not
3601         whatever newline happens to be at the end of what we've read.
3602
3603 2008-04-17  Adam Roben  <aroben@apple.com>
3604
3605         Remove DRT/win's hang timer
3606
3607         run-webkit-tests takes care of this for us now
3608
3609         Reviewed by Anders Carlsson.
3610
3611         * DumpRenderTree/win/DumpRenderTree.cpp:
3612
3613 2008-04-17  Adam Roben  <aroben@apple.com>
3614
3615         Don't wait for the hang timer twice in the case of a hang
3616
3617         Previously we'd wait for a hang while reading both stdout and stderr
3618         from DRT. Now we'll only wait for one or the other.
3619
3620         Reviewed by Anders Carlsson.
3621
3622         * Scripts/run-webkit-tests:
3623         (top level): Don't wait for stderr to time out if stdout already timed
3624         out.
3625         (readFromDumpToolWithTimer): If $dontWaitForTimeOut is true, quit
3626         after the first read that returns no data.
3627
3628 2008-04-17  Adam Roben  <aroben@apple.com>
3629
3630         Don't throw away the output from timed out tests
3631
3632         Reviewed by Anders Carlsson.
3633
3634         * Scripts/run-webkit-tests:
3635         (top level): Updated for changes to readFromDumpToolWithTimer.
3636         (readFromDumpToolWithTimer): Return a hash that contains both the
3637         output and whether or not the test timed out.
3638
3639 2008-04-17  Adam Roben  <aroben@apple.com>
3640
3641         Make the hang timer 60 seconds
3642
3643         * Scripts/run-webkit-tests:
3644
3645 2008-04-17  Adam Roben  <aroben@apple.com>
3646
3647         Get rid of carriage returns in DRT/win's stderr
3648
3649         Reviewed by Eric Seidel.
3650
3651         * DumpRenderTree/win/DumpRenderTree.cpp:
3652         (main): Mark stderr as binary like we already do for stdout.
3653
3654 2008-04-17  Adam Roben  <aroben@apple.com>
3655
3656         Fix Bug 17678: run-webkit-tests should have a watchdog timer (and
3657         timeout long tests)
3658
3659         <https://bugs.webkit.org/show_bug.cgi?id=17678>
3660
3661         We now abort tests that take longer than 60 seconds to produce output.
3662         This matches the watchdog timer in DRT/mac and DRT/win (which we can
3663         now remove).
3664
3665         Reviewed by Eric Seidel.
3666
3667         * Scripts/run-webkit-tests:
3668         (top level): Read DRT's output using the new readFromDumpToolWithTimer
3669         subroutine. If readFromDumpToolWithTimer returns undefined it means
3670         the test timed out, so we register the test as a hang and move on.
3671         (sub testCrashedOrTimedOut): Renamed from testCrashed. Now handles
3672         both crashed and timed out tests. If the test timed out, we kill DRT
3673         before returning.
3674         (sub linksForTimedOutTest): Added. We don't have any output to link to for
3675         tests that timed out.
3676         (sub recordActualResultsAndDiff): Don't call length on undefined.
3677         (sub readFromDumpToolWithTimer): Added. Performs non-blocking reads
3678         from a filehandle until an #EOF is reached or
3679         $maximumSecondsWithoutOutput have elapsed.
3680         (sub setFileHandleNonBlocking): Marks a filehandle as blocking or
3681         non-blocking.
3682
3683 2008-04-17  Adam Roben  <aroben@apple.com>
3684
3685         Refactor test results page generation
3686
3687         Reviewed by Eric Seidel.
3688
3689         * Scripts/run-webkit-tests:
3690         (sub htmlForResultsSection): Added. Takes a set of tests, a
3691         description, and a subroutine to generate the links for each test, and
3692         creates a HTML string containing a table of the tests and their
3693         links.
3694         (sub linksForExpectedAndActualResults): Added. Replaces the
3695         htmlForExpectedAndActualResults subroutine.
3696         (sub linksForMismatchTest): Added.
3697         (sub linksForCrashOrErrorTest): Added.
3698         (sub linksForNewTest): Added.
3699
3700 2008-04-17  Adam Roben  <aroben@apple.com>
3701
3702         Print the extension for all tests in the test results page
3703
3704         Reviewed by Eric Seidel.
3705
3706         * Scripts/run-webkit-tests:
3707
3708 2008-04-17  Adam Roben  <aroben@apple.com>
3709
3710         Move code that counts finished tests into a subroutine
3711
3712         Reviewed by Eric Seidel.
3713
3714         * Scripts/run-webkit-tests:
3715         (sub countFinishedTest): Added.
3716
3717 2008-04-17  Adam Roben  <aroben@apple.com>
3718
3719         Move code that handles a crash into a subroutine
3720
3721         Reviewed by Eric Seidel.
3722
3723         * Scripts/run-webkit-tests:
3724         (sub testCrashed): Added.
3725
3726 2008-04-17  Eric Seidel  <eric@webkit.org>
3727
3728         Reviewed by hyatt.
3729         
3730         Rename RenderView to RenderViewport in the next rename patch.
3731
3732         * Scripts/do-webcore-rename:
3733
3734 2008-04-17  Mario Bensi  <mbensi@pleyo.com>
3735
3736         Reviewed by Alp Toker.
3737
3738         http://bugs.webkit.org/show_bug.cgi?id=18543
3739         DumpRenderTree gtk freeze
3740
3741         fix DumpRenderTree gtk freeze 
3742
3743         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3744         (dump):
3745
3746 2008-04-15  Anders Carlsson  <andersca@apple.com>
3747
3748         Add missing ;
3749         
3750         * Scripts/build-webkit:
3751         
3752 2008-04-15  Anders Carlsson  <andersca@apple.com>
3753
3754         Reviewed by Adam.
3755
3756         Add ENABLE_OFFLINE_WEB_APPLICATIONS to FEATURE_DEFINES.
3757
3758         * Scripts/build-webkit:
3759
3760 2008-04-15  Andre Poenitz  <andre.poenitz@trolltech.com>
3761
3762         Reviewed by Simon.
3763
3764         Fix compilation with Qt namespaces
3765
3766         Qt can be configured to have all of its classes inside a specified namespaces.
3767         This is for example used in plugin/component environments like Eclipse.
3768
3769         This change makes it possible to let the Qt port compile against a namespaced
3770         Qt by the use of macros Qt provides to properly forward declare Qt classes in
3771         the namespace.
3772
3773         * DumpRenderTree/qt/DumpRenderTree.h:
3774
3775 2008-04-08  Kevin Ollivier  <kevino@theolliviers.com>
3776
3777         Reviewed by Darin Adler.
3778
3779         Add a script that propagates any file changes made to the Bakefiles
3780         over to GTK and Qt build systems. Still needs to be wired into
3781         those ports though.
3782
3783         * Scripts/update-sources-list.py: Added.
3784
3785 2008-04-08  Mark Rowe  <mrowe@apple.com>
3786
3787         Clean up after Brady.
3788
3789         * DumpRenderTree/mac/DumpRenderTree.mm: Add an include so that NSInteger can be found.
3790
3791 2008-04-08  Brady Eidson  <beidson@apple.com>
3792
3793         Reviewed by Mitzpettel
3794
3795         Fixed http://bugs.webkit.org/show_bug.cgi?id=18302
3796         -WebArchive subresources dump in random order, intermittent failures
3797
3798         * DumpRenderTree/mac/DumpRenderTree.mm:
3799         (compareResourceURLs): Sorting function based on the resource URLs
3800         (serializeWebArchiveToXML): Sort the subresource array
3801
3802 2008-04-07  Brady Eidson  <beidson@apple.com>
3803
3804         OMG, BUILD - please!
3805
3806         * Scripts/build-webkit:
3807
3808 2008-04-03  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
3809
3810         Reviewed by Simon.
3811
3812         * Enable running http tests for Qt again. Failing tests can be put into the skipped list.
3813         * Running these tests on windows and other platforms might need some work.
3814
3815         * Scripts/run-webkit-tests:
3816
3817 2008-04-03  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
3818
3819         Reviewed by Simon.
3820
3821         * For the http tests we need the output of the FrameLoaderClient. The QtWebKit API
3822         is not exporting enough to create the output in DRT itself. Settle with the approach
3823         Lars has taken for the Editing support and add branches to our FrameLoaderClient code.
3824         * run-webkit-tests http/tests(/loading) can now be executed.
3825         * For tests in loading/ directories we are going to throw away the dirty
3826         QWebPage to start with something clean.
3827         
3828
3829         * DumpRenderTree/qt/DumpRenderTree.cpp:
3830
3831 2008-04-03  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
3832
3833         Reviewed by Simon.
3834
3835         * Treat http and https as special URLs as well. Change the main.cpp and
3836         DumpRenderTree.cpp to handle http and https URIs as input.
3837         * I'm not doing the clean up and merging of these two checks now.
3838         
3839
3840         * DumpRenderTree/qt/DumpRenderTree.cpp:
3841         (WebCore::DumpRenderTree::readStdin):
3842         * DumpRenderTree/qt/main.cpp:
3843         (main):
3844
3845 2008-04-03  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
3846
3847         Reviewed by Simon.
3848
3849         * Remove dumpFrameLoadCallbacks from simple-subframe.html because it is
3850         located in a directory with the name "loading". And this will autoamtically
3851         enable dumping.
3852         * Remove this method from the LayoutTestController as it is unused now and this
3853         avoids adding it to the DRT of the Qt port.
3854         
3855
3856         * DumpRenderTree/LayoutTestController.cpp:
3857         (setPrivateBrowsingEnabledCallback):
3858
3859 2008-04-01  Christian Dywan  <christian@imendio.com>
3860
3861         Build fix for GCC 4.3.
3862
3863         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: include string.h
3864
3865 2008-04-01  Simon Hausmann  <hausmann@webkit.org>
3866
3867         Reviewed by Holger.
3868
3869         Fix Qt DRT run by also printing EOF on stderr, as expected by
3870         run-webkit-tests.
3871
3872         * DumpRenderTree/qt/DumpRenderTree.cpp:
3873         (WebCore::DumpRenderTree::dump):
3874
3875 2008-03-31  Julien Chaffraix  <julien.chaffraix@gmail.com>
3876
3877         Reviewed by Darin Adler.
3878
3879         Bug 17665: determineSourceDir() dies if $sourceDir has a trailing backslash
3880
3881         Remove trailing '/' in $sourceDir in determineSourceDir().
3882
3883         Fix suggested by Dmitriy Kazachkov.
3884
3885         * Scripts/webkitdirs.pm:
3886
3887 2008-03-29  Adam Roben  <aroben@apple.com>
3888
3889         Update for rename of an IWebViewPrivate method
3890
3891         Reviewed by Mitz Pettel.
3892
3893         * DumpRenderTree/win/DumpRenderTree.cpp:
3894         (createWebViewAndOffscreenWindow):
3895
3896 2008-03-26  Antti Koivisto  <antti@apple.com>
3897
3898         Reviewed by Anders.
3899         
3900         Enable SVG animation support by default.
3901
3902         * Scripts/build-webkit:
3903
3904 2008-03-25  Adam Roben  <aroben@apple.com>
3905
3906         Windows build fix
3907
3908         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3909         Add $(WebKitLibrariesDir)\include to the include path so we can find
3910         stdint.h there.
3911
3912 2008-03-24  Eric Seidel  <eric@webkit.org>
3913
3914         Reviewed by Mark.
3915
3916         Clean up SVG features message to be less confusing.
3917
3918         * Scripts/build-webkit:
3919
3920 2008-03-24  Sam Weinig  <sam@webkit.org>
3921
3922         Reviewed by Dave Hyatt.
3923
3924         Add EventSender.zoomPageIn/zoomPageOut support to DRT.
3925
3926         * DumpRenderTree/mac/DumpRenderTree.mm:
3927         (resetWebViewToConsistentStateBeforeTesting):
3928         * DumpRenderTree/mac/EventSendingController.mm:
3929         (+[EventSendingController isSelectorExcludedFromWebScript:]):
3930         (-[EventSendingController zoomPageIn]):
3931         (-[EventSendingController zoomPageOut]):
3932         * DumpRenderTree/win/DumpRenderTree.cpp:
3933         (resetWebViewToConsistentStateBeforeTesting):
3934         * DumpRenderTree/win/EventSender.cpp:
3935         (textZoomInCallback):
3936         (textZoomOutCallback):
3937         (zoomPageInCallback):
3938         (zoomPageOutCallback):
3939
3940 2008-03-24  Dan Bernstein  <mitz@apple.com>
3941
3942         Reviewed by Mark Rowe.
3943
3944         - update bisect-builds for Safari 3.1
3945
3946         * Scripts/bisect-builds: Added Safari 3.1 and the corresponding minimal
3947         revision, r29711.
3948
3949 2008-03-21  Rodney Dawes  <dobey@wayofthemonkey.com>
3950
3951         Reviewed by Holger.
3952
3953         http://bugs.webkit.org/show_bug.cgi?id=17981
3954
3955         Add webcore and javascriptcore cppflags to programs' _CPPFLAGS.
3956
3957         * GNUmakefile.am:
3958
3959 2008-03-21  Adam Roben  <aroben@apple.com>
3960
3961         Remove a non-working mirror from cygwin-downloader and add the ruby package
3962
3963         * CygwinDownloader/cygwin-downloader.py:
3964         * CygwinDownloader/cygwin-downloader.zip: Updated.
3965
3966 2008-03-20  Mark Rowe  <mrowe@apple.com>
3967
3968         Reviewed by Sam Weinig.
3969
3970         Ensure that the defines generated for FEATURE_DEFINES are sorted so that they will match the default settings of each project.
3971         This will prevent the world from being rebuilt if you happen to switch between building in Xcode and with build-webkit on the
3972         command-line.
3973
3974         * Scripts/build-webkit:
3975
3976 2008-03-17  Eric Seidel  <eric@webkit.org>
3977
3978         Reviewed by Dan Bernstein.
3979
3980         Fix bogus argCount check breaking plugin test.
3981
3982         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3983
3984 2008-03-17  Eric Seidel  <eric@webkit.org>
3985
3986         Reviewed by darin.
3987
3988         Cleanup PluginObject.cpp and add support for testing
3989         converting from int -> identifier -> string
3990         and from string -> identifier -> int
3991         as well as round-tripping ints and stings through identifiers
3992
3993         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3994         (pluginGetProperty):
3995         (pluginSetProperty):
3996         (testDOMAccess):
3997         (stringVariantToIdentifier):
3998         (int32VariantToIdentifier):
3999         (doubleVariantToIdentifier):
4000         (variantToIdentifier):
4001         (testIdentifierToString):
4002         (testIdentifierToInt):
4003         (testCallback):
4004         (getURL):
4005         (removeDefaultMethod):
4006         (getURLNotify):
4007         (testInvokeDefault):
4008         (destroyStream):
4009         (testEnumerate):
4010         (testGetIntIdentifier):
4011         (testGetProperty):
4012         (testEvaluate):
4013         (testGetPropertyReturnValue):
4014         (pluginInvoke):
4015         (pluginInvokeDefault):
4016         (pluginInvalidate):
4017         (pluginAllocate):
4018         (pluginDeallocate):
4019         (handleCallback):
4020
4021 2008-03-16  Kevin Ollivier  <kevino@theolliviers.com>
4022
4023         Rubber stamped by Darin Adler.
4024
4025         Add set-webkit-configuration support for wx port, and centralize
4026         build dir location setting.
4027
4028         http://bugs.webkit.org/show_bug.cgi?id=17790
4029
4030         * wx/browser/browser.bkl:
4031         * wx/build-wxwebkit:
4032
4033 2008-03-15  Darin Adler  <darin@apple.com>
4034
4035         * Scripts/commit-log-editor: Include the name line of the change log entry.
4036         A long time ago I designed this script to not include the name because I
4037         thought it was redundant (same as the name of the person checking in), but
4038         nowadays it's more common for someone to check something in done by someone
4039         else.
4040
4041         * Scripts/do-webcore-rename: Added some more planned renames and removed
4042         some that were already done "by hand".
4043
4044 2008-03-13  Brent Fulgham  <bfulgham@gmail.com>
4045
4046         Reviewed by Darin Adler.
4047
4048         Correct paths to vsprops files so they use the environment
4049         variable, rather than hard-coded path.
4050         http://bugs.webkit.org/show_bug.cgi?id=17797.
4051
4052         * WinLauncher/WinLauncher.vcproj:  Correct paths to vsprops.
4053
4054 2008-03-12  Steve Falkenburg  <sfalken@apple.com>
4055
4056         VSExpress build fix
4057
4058         * WinLauncher/WinLauncher.vcproj:
4059
4060 2008-03-12  Holger Hans Peter Freyther  <zecke@selfish.org>
4061
4062         Reviewed by Alp Toker.
4063
4064         Run testkjs in the correct productsDir in the GTK+ port.
4065
4066         * Scripts/run-javascriptcore-tests:
4067
4068 2008-03-11  Brent Fulgham  <bfulgham@gmail.com>
4069
4070         Reviewed by Adam Roben.
4071
4072         Enabled WinLauncher as part of normal Windows build.
4073         http://bugs.webkit.org/show_bug.cgi?id=17715.
4074
4075         * WinLauncher/WinLauncher.vcproj: Update to use vsprops so that
4076           it can find the proper libraries to link against.
4077
4078 2008-03-10  Julien Chaffraix  <julien.chaffraix@gmail.com>
4079
4080         Reviewed and landed by Darin Adler.
4081
4082         http://bugs.webkit.org/show_bug.cgi?id=17581
4083         Bug 17581: Use of uninitialized value in string ne at WebKitTools/Scripts/run-webkit-tests line 1576.
4084
4085         Remove the previous warning which occurs when the --random option is used.
4086
4087         * Scripts/run-webkit-tests: verify that $component[0] is defined before checking for
4088         its inequality
4089
4090 2008-03-07  Simon Hausmann  <hausmann@webkit.org>
4091
4092         Reviewed by Darin Adler.
4093
4094         Done with Lars.
4095
4096         Ported the netscape test plugin to QWebPluginFactory.
4097
4098         * DumpRenderTree/qt/DumpRenderTree.cpp:
4099         (WebCore::WebPage::WebPage):
4100         * DumpRenderTree/qt/main.cpp:
4101         * DumpRenderTree/qt/testplugin.cpp:
4102         (TestPlugin::plugins):
4103         (TestPlugin::create):
4104         * DumpRenderTree/qt/testplugin.h:
4105
4106 2008-03-09  Steve Falkenburg  <sfalken@apple.com>
4107
4108         Stop Windows build if an error occurs in a prior project.
4109
4110         Rubber stamped by Darin Adler.
4111
4112         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
4113         * DumpRenderTree/win/DumpRenderTree.vcproj:
4114         * DumpRenderTree/win/ImageDiff.vcproj:
4115         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
4116
4117 2008-03-08  Julien Chaffraix  <julien.chaffraix@gmail.com>
4118
4119         Reviewed by Mark Rowe.
4120
4121         DRT build fix for Tiger.
4122
4123         * DumpRenderTree/mac/DumpRenderTreeMac.h: Define BUILDING_ON_TIGER.
4124
4125 2008-03-07  Mark Rowe  <mrowe@apple.com>
4126
4127         Reviewed by Oliver Hunt.
4128
4129         Fix WebKit build with GCC 4.2.
4130
4131         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Use correct argument type in method signature.
4132
4133 2008-03-07  Stephanie Lewis <slewis@apple.com>
4134
4135         Reviewed by Oliver.
4136
4137         Add Windows part of <rdar://problem/5693690> 
4138
4139         * DumpRenderTree/win/DumpRenderTree.cpp:
4140         (dump):
4141         (main):
4142
4143 2008-03-07  Alp Toker  <alp@atoker.com>
4144
4145         Back out the r30818, r30819 build fix attempts now the GTK+ build
4146         server has been upgraded.
4147
4148         * Scripts/webkitdirs.pm:
4149
4150 2008-03-07  Stephanie Lewis <slewis@apple.com>
4151
4152         Reviewed by Geoff.
4153
4154         <rdar://problem/5693690> run-webkit-tests swallows STDERR output, including WebCore LEAK messages
4155
4156         * DumpRenderTree/mac/DumpRenderTree.mm:
4157         (dump): push EOF to stderr after every test
4158         * Scripts/run-webkit-tests: collect stderr output and print it
4159
4160 2008-03-07  Steve Falkenburg  <sfalken@apple.com>
4161
4162         Get pdevenv working with Visual Studio Express.
4163         
4164         Reviewed by Adam.
4165
4166         * Scripts/pdevenv:
4167
4168 2008-03-06  Adele Peterson  <adele@apple.com>
4169
4170         Reviewed by Darin Adler.
4171
4172         Updated for testing <rdar://problem/5785895> Implement hasFocus() for HTMLDocument (HTML5)
4173
4174         * DumpRenderTree/mac/UIDelegate.mm:
4175         (-[UIDelegate webViewFocus:]): Remove duplicate code that was also in LayoutTestController::setWindowIsKey
4176         (-[UIDelegate webViewUnfocus:]): Added.  In Safari, the default is to focus another window if there is one.
4177          To easily test cases where the window is unfocused, I made this just call setWindowIsKey(false).
4178
4179 2008-03-06  Matt Lilek  <webkit@mattlilek.com>
4180
4181         Reviewed by Adam Roben.
4182
4183         Bug 17691: REGRESSION: FindSafari doesn't work
4184         http://bugs.webkit.org/show_bug.cgi?id=17691
4185
4186         Swap my change from r30394 to use the Release libraries instead of Debug
4187         since some machines don't have the Debug version.
4188
4189         * FindSafari/FindSafari.vcproj:
4190
4191 2008-03-06  Kevin McCullough  <kmccullough@apple.com>
4192
4193         Reviewed by Sam and Tim.
4194
4195         <rdar://5631450> Drosera: breakpoint indicators disappear after the
4196         script is finished running.
4197         - If there is a pre-existing breakpoint on a line when the file is
4198         updated we need to redraw it.
4199
4200         * Drosera/debugger.js:
4201
4202 2008-03-06  Brady Eidson  <beidson@apple.com>
4203
4204         Tiger build fix...?
4205
4206         * DumpRenderTree/mac/WatchdogMac.mm:
4207
4208 2008-03-06  Brady Eidson  <beidson@apple.com>
4209
4210         Reviewed by Darin
4211
4212         Added a cross-platform Watchdog thread to DRT.
4213
4214         The current watchdog in both DRTWin and DRTMac is Timer based.  Therefore, deadlocks and long running
4215         main thread hangs still affect DRT.
4216
4217         By placing the watchdog on a thread and having DRT "check in" after each test, long-running hangs
4218         and true deadlocks can be caught.
4219
4220         There is one hook for platform specific code.  As I did my development and testing on Mac, and Mac has
4221         `sample` available, the Mac implementation of this hook samples the process before it is killed.
4222
4223         I arbitrarily chose 30 seconds as the timeout for now - this can be tweaked easily if we find a need.
4224
4225         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4226         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added LINKER_DISPLAYS_MANGLED_NAMES
4227
4228         * DumpRenderTree/ForwardingHeaders/wtf/Locker.h: Added.
4229         * DumpRenderTree/ForwardingHeaders/wtf/Threading.h: Added.
4230
4231         * DumpRenderTree/Watchdog.cpp: Added.
4232         (Watchdog::Watchdog):
4233         (Watchdog::~Watchdog):
4234         (Watchdog::start):
4235         (Watchdog::stop):
4236         (Watchdog::checkIn):
4237         (Watchdog::setWatchdogInterval):
4238         (Watchdog::handleHang):
4239         (Watchdog::watchdogThreadStart):
4240         (Watchdog::watchdogThread):
4241         * DumpRenderTree/Watchdog.h: Added.
4242
4243         * DumpRenderTree/mac/WatchdogMac.h: Added.
4244         * DumpRenderTree/mac/WatchdogMac.mm: Added.
4245         (WatchdogMac::handleHang): Sample the process and write it out to a file
4246
4247         * DumpRenderTree/mac/DumpRenderTree.mm:
4248         (dumpRenderTree): Setup and start the watchdog before running any tests
4249         (runTest): Checkin with the watchdog after each test
4250
4251 2008-03-05  Alp Toker  <alp@atoker.com>
4252
4253         Attempt to get the autotools build working again on the bot with
4254         build-webkit.
4255
4256         Force the use of /bin/bash since we seem to have bash-isms in the
4257         configure script right now.
4258
4259         * Scripts/webkitdirs.pm:
4260
4261 2008-03-05  Alp Toker  <alp@atoker.com>
4262
4263         Re-attempt to switch to the autotools build system for GTK+.
4264
4265         Change scripts to continue when distclean fails.
4266
4267         * Scripts/webkitdirs.pm:
4268
4269 2008-03-05  Alp Toker  <alp@atoker.com>
4270
4271         Force qmake for the GTK+ build until we get the build bot to succeed
4272         with autotools (currently dies at make distclean)
4273
4274         * Scripts/webkitdirs.pm:
4275
4276 2008-03-04  Alp Toker  <alp@atoker.com>
4277
4278         Reviewed by Mark Rowe.
4279
4280         Switch the default GTK+ build system from qmake to autotools.
4281
4282         qmake can still be used by defining WEBKIT_BUILD_SYSTEM=qmake
4283
4284         * Scripts/build-webkit:
4285         * Scripts/run-launcher:
4286         * Scripts/run-webkit-tests:
4287         * Scripts/webkitdirs.pm:
4288
4289 2008-03-04  Sam Weinig  <sam@webkit.org>
4290
4291         Reviewed by Darin Adler.
4292
4293         * Scripts/do-webcore-rename: Update renaming plan.
4294
4295 2008-03-02  Brent Fulgham  <bfulgham@gmail.com>
4296
4297         Reviewed by Alp Toker.
4298
4299         Remove some needless LIBS.
4300
4301         * GNUmakefile.am:
4302
4303 2008-03-02  Alp Toker  <alp@atoker.com>
4304
4305         Reviewed by Mark Rowe.
4306
4307         Split the WebKit GTK+ build out of the WebCore build and change the
4308         shared object name to match the package name.
4309
4310         * GNUmakefile.am:
4311
4312 2008-03-01  Mark Rowe  <mrowe@apple.com>
4313
4314         Reviewed by Tim Hatcher.
4315
4316         Update Xcode configuration to support building debug and release from the mysterious future.
4317
4318         * DumpRenderTree/mac/Configurations/Base.xcconfig:
4319
4320 2008-02-29  David Kilzer  <ddkilzer@apple.com>
4321
4322         Pass the correct configuration switch (--Debug|--Release) to build-testkjs.
4323
4324         Reviewed by Dan.
4325
4326         Originally broken in r26838.
4327
4328         * Scripts/run-javascriptcore-tests: Push configuration switch onto @xcodeArgs
4329         not local, unused @args variable.
4330
4331 2008-02-29  David Kilzer  <ddkilzer@apple.com>
4332
4333         Bug 15754: webarchive layout tests fail when WebKit directory path contains symlinks
4334
4335         <http://bugs.webkit.org/show_bug.cgi?id=15754>