c46816530efc23778e5cb4bb99f4a4d6a359c4c5
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-09-15  Philippe Normand  <pnormand@igalia.com>
2
3         Reviewed by Eric Carlson.
4
5         [GTK] enhanced context menu for media elements
6         https://bugs.webkit.org/show_bug.cgi?id=45021
7
8         EventSender::contextClick() now returns an array of js
9         objects. Each object has a title property and a click() method.
10
11         * DumpRenderTree/gtk/EventSender.cpp:
12         (getMenuItemTitleCallback):
13         (setMenuItemTitleCallback):
14         (menuItemClickCallback):
15         (getMenuItemClass):
16         (contextClickCallback):
17
18 2010-09-14  Philippe Normand  <pnormand@igalia.com>
19
20         Reviewed by Eric Carlson and Martin Robinson.
21
22         [GTK] eventSender.contextClick() should return the contents of the context menu
23         https://bugs.webkit.org/show_bug.cgi?id=39102
24
25         Make the eventSender use the new private WebKitGtk+ API to
26         retrieve the context-menu item titles and store them in an array.
27
28         * DumpRenderTree/gtk/EventSender.cpp:
29         (contextClickCallback):
30
31 2010-09-16  Eric Uhrhane  <ericu@chromium.org>
32
33         Reviewed by Jian Li.
34
35         Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
36         https://bugs.webkit.org/show_bug.cgi?id=45798
37
38         * Scripts/build-webkit:
39
40 2010-09-16  Robert Hogan  <robert@webkit.org>
41
42         Reviewed by Antonio Gomes.
43
44         [Qt] Support globalhistory tests
45         https://bugs.webkit.org/show_bug.cgi?id=45774
46
47         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
48         (WebCore::isGlobalHistoryTest):
49         (WebCore::DumpRenderTree::open):
50         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
51         (LayoutTestController::reset):
52         (LayoutTestController::dumpHistoryCallbacks):
53         (LayoutTestController::removeAllVisitedLinks):
54         * DumpRenderTree/qt/LayoutTestControllerQt.h:
55
56 2010-09-10  Tony Chang  <tony@chromium.org>
57
58         Reviewed by Eric Seidel.
59
60         deduplicate-tests should be runnable from any WebKit directory
61         https://bugs.webkit.org/show_bug.cgi?id=44709
62
63         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
64         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
65
66 2010-09-15  Tony Chang  <tony@chromium.org>
67
68         Reviewed by Kent Tamura.
69
70         [chromium] sort testing methods in DRT
71         https://bugs.webkit.org/show_bug.cgi?id=45850
72
73         * DumpRenderTree/chromium/EventSender.cpp:
74         (EventSender::EventSender):
75         * DumpRenderTree/chromium/LayoutTestController.cpp:
76         (LayoutTestController::LayoutTestController):
77         * DumpRenderTree/chromium/TextInputController.cpp:
78         (TextInputController::TextInputController):
79
80 2010-09-15  Mihai Parparita  <mihaip@chromium.org>
81
82         Reviewed by Adam Barth.
83
84         CQ status shows items out of order
85         https://bugs.webkit.org/show_bug.cgi?id=45846
86         
87         Only group consecutive status items with the same patch ID into the same
88         group, so that overall item ordering is preserved.
89         
90         Also don't indent status items that only have a single item in their
91         group.
92
93         * QueueStatusServer/handlers/queuestatus.py:
94         * QueueStatusServer/templates/includes/singlequeuestatus.html: Added.
95         * QueueStatusServer/templates/queuestatus.html:
96
97 2010-09-15  Eric Seidel  <eric@webkit.org>
98
99         Reviewed by Adam Barth.
100
101         Add queue start/stop messages
102         https://bugs.webkit.org/show_bug.cgi?id=45853
103
104         I ended up needing to clean up a bunch of our unit testing
105         in order to test this new code path nicely.
106
107         There are also a few PEP8 changes needed to pass check-webkit-style.
108
109         * Scripts/webkitpy/tool/bot/queueengine.py:
110         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
111         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
112         * Scripts/webkitpy/tool/commands/queues.py:
113         * Scripts/webkitpy/tool/commands/queues_unittest.py:
114         * Scripts/webkitpy/tool/commands/queuestest.py:
115         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
116
117 2010-09-15  Simon Fraser  <simon.fraser@apple.com>
118
119         https://bugs.webkit.org/show_bug.cgi?id=45849
120         WKURLCreateWithCFURL crashes with null url
121         
122         Fix MiniBrowser crash when the url is not parseable.
123
124         * MiniBrowser/mac/BrowserWindowController.m:
125         (-[BrowserWindowController fetch:]):
126
127 2010-09-15  Patrick Gansterer  <paroga@paroga.com>
128
129         Unreviewed.
130
131         Adding myself to the committers list.
132
133         * Scripts/webkitpy/common/config/committers.py:
134
135 2010-09-14  Eric Seidel  <eric@webkit.org>
136
137         Reviewed by Adam Barth.
138
139         Make it possible to run more than one commit-queue instance
140         https://bugs.webkit.org/show_bug.cgi?id=45786
141
142         Mostly we need to make sure the two (or more) instances get
143         different patches to work on.  To do this, I re-worked
144         the code responsible for getting the next work item to
145         round trip through the status server.  The status server only
146         vends patches from the work items list, only if those patches
147         have not had status reported for them in the last hour.
148
149         This is another step towards making all queues go through the
150         status server, thus making it possible to run more than one
151         instance of various EWS bots (as requested in bug 44292).
152
153         The webkitpy changes are already covered by existing unit tests.
154         The QueueStatusSever sadly has no testing infrastructure yet. :(
155
156         * QueueStatusServer/handlers/nextpatch.py: Added.
157         * QueueStatusServer/index.yaml:
158         * QueueStatusServer/main.py:
159         * Scripts/webkitpy/tool/commands/queues.py:
160
161 2010-09-15  Mihai Parparita  <mihaip@chromium.org>
162
163         Reviewed by Tony Chang.
164
165         NRWT fails with UnicodeDecodeError on editing/selection/mixed-editability-10.html
166         https://bugs.webkit.org/show_bug.cgi?id=45791
167
168         Force filenames to be raw bytes before running difflib.unified_diff.
169
170         * Scripts/webkitpy/layout_tests/port/base.py:
171         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
172
173 2010-09-15  Simon Hausmann  <simon.hausmann@nokia.com>
174
175         Reviewed by Tor Arne Vestbø.
176
177         [Qt] QtTestBrowser crashes when enabling QGraphicsView mode after first loading page without it enabled
178         https://bugs.webkit.org/show_bug.cgi?id=35247
179
180         The main issue when changing the views is that the plugins and any other components that
181         depend on view specific attributes such as the native window id are not teared down.
182         Even if we had a tear-down procedure, we'd have to re-initialize the plugin after
183         switching to the new view (QGraphicsWebView). This is a rather uncommon situation, so
184         we decided to work around this in QtTestBrowser by making toggling between QWebView
185         and QGraphicsWebView also re-create the page.
186
187         * QtTestBrowser/launcherwindow.cpp:
188         (LauncherWindow::initializeView):
189         * QtTestBrowser/mainwindow.h:
190
191 2010-09-14  Mihai Parparita  <mihaip@chromium.org>
192
193         Reviewed by Adam Barth.
194
195         Send webkit accessibility notifications to Chromium
196         https://bugs.webkit.org/show_bug.cgi?id=45156
197
198         Move printf inside shouldDumpAccessibilityNotifications check.
199
200         * DumpRenderTree/chromium/WebViewHost.cpp:
201         (WebViewHost::postAccessibilityNotification):
202
203 2010-09-14  Tony Chang  <tony@chromium.org>
204
205         Reviewed by Kent Tamura.
206
207         [chromium] fix http/tests/security/local-user-CSS-from-remote.html
208         https://bugs.webkit.org/show_bug.cgi?id=45788
209
210         * DumpRenderTree/chromium/LayoutTestController.cpp:
211         (LayoutTestController::setUserStyleSheetLocation): use a base64 url like in Chrome
212
213 2010-09-14  Tony Chang  <tony@chromium.org>
214
215         Reviewed by Ojan Vafai.
216
217         [chromium] Remove WebKit::areLayoutTestImagesOpaque since it's no longer needed
218         https://bugs.webkit.org/show_bug.cgi?id=45768
219
220         * DumpRenderTree/chromium/TestShell.cpp:
221         (TestShell::dumpImage): new baselines are checked in and Linux will match Windows going forward.
222
223 2010-09-14  Kevin Ollivier  <kevino@theolliviers.com>
224
225         [wx] Build fix, add newly added directories to the directory list.
226
227         * wx/build/settings.py:
228
229 2010-09-14  Sam Weinig  <sam@webkit.org>
230
231         Reviewed by Anders Carlsson.
232
233         Remove WKBundleNodeRef, replacing uses with WKBundleNodeHandleRef.
234         https://bugs.webkit.org/show_bug.cgi?id=45785
235
236         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
237         (WTR::propertyValue):
238         (WTR::numericWindowPropertyValue):
239         (WTR::dumpPath):
240         (WTR::toStr):
241         (WTR::operator<<):
242         (WTR::InjectedBundlePage::InjectedBundlePage):
243         (WTR::InjectedBundlePage::shouldInsertNode):
244         (WTR::InjectedBundlePage::shouldBeginEditing):
245         (WTR::InjectedBundlePage::shouldEndEditing):
246         (WTR::InjectedBundlePage::shouldInsertText):
247         (WTR::InjectedBundlePage::shouldDeleteRange):
248         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
249         (WTR::InjectedBundlePage::shouldApplyStyle):
250         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
251
252 2010-09-14  Adam Barth  <abarth@webkit.org>
253
254         Fix two typos in commit-queue.  The first is harmless.  The second
255         causes the queue to reject patches when the build is broken.  :(
256
257         * Scripts/webkitpy/tool/commands/queues.py:
258         * Scripts/webkitpy/tool/commands/queues_unittest.py:
259
260 2010-09-14  Chris Guillory   <chris.guillory@google.com>
261
262         Reviewed by Chris Fleizach.
263
264         Send all accessibility notifications to Chromium.
265         https://bugs.webkit.org/show_bug.cgi?id=45156
266
267         * DumpRenderTree/chromium/WebViewHost.cpp:
268         (WebViewHost::postAccessibilityNotification):
269         * DumpRenderTree/chromium/WebViewHost.h:
270
271 2010-09-14  Adam Barth  <abarth@webkit.org>
272
273         Reviewed by Eric Seidel.
274
275         commit-queue is slow during the day
276         https://bugs.webkit.org/show_bug.cgi?id=45780
277
278         Thanks to the new logging, we've noticed that checkout-is-out-of-date
279         errors in the first pass of landing don't retry the land.  Instead,
280         they're treated as failures and cause the commit-queue to do two more
281         builds before really trying to land the patch.  Worse, in the second
282         build, we can get bitten by a flaky test.
283
284         This patch takes a slightly different approach to the commit-queue's
285         main control logic.  We now use a separate subprocess for building and
286         testing and for landing.  This means we should very rarely see the
287         checkout-is-out-of-date error, and when we do see it, we should retry
288         more quickly.  If my understanding is correct, this should be a big
289         speed win for the commit-queue.
290
291         * Scripts/webkitpy/tool/commands/download.py:
292         * Scripts/webkitpy/tool/commands/queues.py:
293         * Scripts/webkitpy/tool/commands/queues_unittest.py:
294
295 2010-09-14  Tony Chang  <tony@chromium.org>
296
297         Reviewed by Dimitri Glazkov.
298
299         [chromium] implement layoutTestController.setDomainRelaxationForbiddenForURLScheme
300         https://bugs.webkit.org/show_bug.cgi?id=45762
301
302         * DumpRenderTree/chromium/LayoutTestController.cpp:
303         (LayoutTestController::LayoutTestController):
304         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
305         * DumpRenderTree/chromium/LayoutTestController.h:
306
307 2010-09-14  Csaba Osztrogonác  <ossy@webkit.org>
308
309         Adding myself as a reviewer.
310
311         * Scripts/webkitpy/common/config/committers.py:
312
313 2010-09-14  Zoltan Horvath  <zoltan@webkit.org>
314
315         Reviewed by Kenneth Rohde Christiansen.
316
317         [Qt] Build-webkit shows a warning when WebKitBuild directory is not exist
318         https://bugs.webkit.org/show_bug.cgi?id=45736
319
320         Build-webkit has showed a warning when WebKitBuild didn't exist, add
321         an additional condition to avoid it.
322
323         * Scripts/build-webkit:
324
325 2010-09-13  Eric Seidel  <eric@webkit.org>
326
327         Reviewed by Adam Barth.
328
329         commit-queue should log when it's retrying due to checkout out of date error
330         https://bugs.webkit.org/show_bug.cgi?id=45725
331
332         This will allow us to better track how often we see these errors
333         and how long it takes the queue to recover from them.
334
335         In order to pass the tests, I had to correct an error
336         from a previous change.  The UnitTestPort should not have
337         ever been using the base port method as that will read
338         a file from disk.  If the unit tests haven't passed the contents
339         it should raise an IOError as though the file doesn't exist.
340
341         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
342         * Scripts/webkitpy/tool/commands/queues.py:
343         * Scripts/webkitpy/tool/commands/queues_unittest.py:
344
345 2010-09-13  Mihai Parparita  <mihaip@chromium.org>
346
347         Reviewed by Adam Barth.
348
349         Upload results when cq patch landing fails
350         https://bugs.webkit.org/show_bug.cgi?id=45683
351         
352         Include script errors when CommitQueue._land fails.
353
354         * Scripts/webkitpy/tool/commands/queues.py:
355
356 2010-09-13  Chris Fleizach  <cfleizach@apple.com>
357
358         Reviewed by David Kilzer.
359
360         AX: accessibilityIsIgnored is returning nil when return value expects a BOOL
361         https://bugs.webkit.org/show_bug.cgi?id=45548
362
363         * DumpRenderTree/AccessibilityUIElement.cpp:
364         (isIgnoredCallback):
365         (AccessibilityUIElement::getJSClass):
366         * DumpRenderTree/AccessibilityUIElement.h:
367         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
368         (AccessibilityUIElement::isIgnored):
369         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
370         (AccessibilityUIElement::isIgnored):
371         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
372         (AccessibilityUIElement::isIgnored):
373
374 2010-09-13  Csaba Osztrogonác  <ossy@webkit.org>
375
376         Reviewed by Andreas Kling.
377
378         jscPath() is incorrect in Windows' cmd.exe shell
379         https://bugs.webkit.org/show_bug.cgi?id=45651
380
381         * Scripts/webkitdirs.pm: Add ".exe" suffix to $jscName on Windows.
382
383 2010-09-13  Chris Fleizach  <cfleizach@apple.com>
384
385         Reviewed by Darin Adler.
386
387         REGRESSION (r64816-r64889): Crash in WebCore::AccessibilityRenderObject
388         https://bugs.webkit.org/show_bug.cgi?id=43807
389
390         * DumpRenderTree/AccessibilityUIElement.cpp:
391         (textMarkerForPointCallback):
392         (AccessibilityUIElement::textMarkerForPoint):
393         (AccessibilityUIElement::getJSClass):
394         * DumpRenderTree/AccessibilityUIElement.h:
395         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
396         (AccessibilityUIElement::textMarkerForPoint):
397
398 2010-09-13  Andreas Kling  <andreas.kling@nokia.com>
399
400         Reviewed by Kenneth Rohde Christiansen.
401
402         [Qt] build-webkit: Add --v8 option to build against V8
403
404         Note that V8 is picked up from QtScript, so this currently requires building
405         against the experimental qt-script-v8 branch.
406
407         * Scripts/build-webkit:
408
409 2010-09-13  Hans Wennborg  <hans@chromium.org>
410
411         Reviewed by Jeremy Orlow.
412
413         Add WebDeviceOrientationClientMock::create() and use it from DRT.
414         https://bugs.webkit.org/show_bug.cgi?id=45650
415
416         Do not use the WebDeviceOrientationClientMock constructor directly,
417         but use the create() member function.
418
419         This should fix the linker errors for the multi-DLL Chromium DRT build.
420
421         * DumpRenderTree/chromium/LayoutTestController.cpp:
422         (LayoutTestController::setMockDeviceOrientation):
423         (LayoutTestController::deviceOrientationClient):
424
425 2010-08-27  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
426
427         Reviewed by Antti Koivisto.
428
429         Add support for testing the viewport meta tag algorithm,
430         based on the following draft spec:
431
432         http://people.opera.com/rune/TR/ED-css-viewport-20100806/
433
434         Add common handling of viewport meta tag based on new Opera spec
435         https://bugs.webkit.org/show_bug.cgi?id=44201
436
437         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
438         (LayoutTestController::dumpConfigurationForViewport):
439         * DumpRenderTree/qt/LayoutTestControllerQt.h:
440
441 2010-09-12  Kent Tamura  <tkent@chromium.org>
442
443         Reviewed by Tony Chang.
444
445         [DRT/Chromium] Remove dependency to base/string16.h and gfx/codec/png_codec.h
446         https://bugs.webkit.org/show_bug.cgi?id=45517
447
448         Use webkit_support_gfx.h for PNG encoding/decoding instead of png_codec.h
449
450         * DumpRenderTree/chromium/ImageDiff.cpp:
451         (Image::craeteFromStdin):
452         (Image::createFromFilename):
453         (diffImages):
454         * DumpRenderTree/chromium/TestShell.cpp:
455         (TestShell::dumpImage):
456
457 2010-09-10  MORITA Hajime  <morrita@google.com>
458
459         Reviewed by Tony Chang.
460
461         [Chromium] Implement textInputController.hasSpellingMarker() for Chromium
462         https://bugs.webkit.org/show_bug.cgi?id=45441
463
464         Added TextInputController::hasSpellingMarker().
465         
466         * DumpRenderTree/chromium/TextInputController.cpp:
467         (TextInputController::TextInputController):
468         (TextInputController::hasSpellingMarker):
469         * DumpRenderTree/chromium/TextInputController.h:
470
471 2010-09-12  Dirk Pranke  <dpranke@chromium.org>
472
473         Unreviewed, build fix.
474
475         My last change accidentally contained a local change to the
476         rebaselinig script; webkit-patch land picked it up without telling
477         me and committed it :(
478
479         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
480
481 2010-09-11  Maciej Stachowiak  <mjs@apple.com>
482
483         Reviewed by Anders Carlsson.
484
485         Attempt to fix Windows MiniBrowser build (untested)
486         https://bugs.webkit.org/show_bug.cgi?id=45609
487
488         * MiniBrowser/win/BrowserView.cpp:
489         (runJavaScriptConfirm):
490         (runJavaScriptPrompt):
491
492 2010-09-11  Sam Weinig  <sam@webkit.org>
493
494         Reviewed by Maciej Stachowiak.
495
496         Fix zoom related tests when testing WebKit2.
497
498         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
499         (WTR::EventSendingController::zoomPageIn): Zoom in and zoom out are not the same.
500
501 2010-09-11  Sam Weinig  <sam@webkit.org>
502
503         Reviewed by Dan Bernstein.
504
505         Implement WebKit2 callback equivalent to - [WebUIDelegate webView:setStatusText:]
506         <rdar://problem/8359252>
507         https://bugs.webkit.org/show_bug.cgi?id=45605
508
509         * MiniBrowser/mac/BrowserWindowController.m:
510         (setStatusText):
511         (contentsSizeChanged):
512         (-[BrowserWindowController awakeFromNib]):
513         * MiniBrowser/win/BrowserView.cpp:
514         (runJavaScriptConfirm):
515         (runJavaScriptPrompt):
516         (setStatusText):
517         (contentsSizeChanged):
518         (BrowserView::create):
519         * WebKitTestRunner/TestController.cpp:
520         (WTR::createOtherPage):
521         (WTR::TestController::initialize):
522
523 2010-09-11  Sam Weinig  <sam@webkit.org>
524
525         Reviewed by Dan Bernstein.
526
527         Add callback mechanism for the getting the source of a frame
528         <rdar://problem/8364681>
529         https://bugs.webkit.org/show_bug.cgi?id=45604
530
531         Add ability to dump the main frame's source to the console.
532
533         * MiniBrowser/mac/BrowserWindowController.h:
534         * MiniBrowser/mac/BrowserWindowController.m:
535         (-[BrowserWindowController dumpSourceToConsole:]):
536         * MiniBrowser/mac/MainMenu.xib:
537
538 2010-09-11  Eric Seidel  <eric@webkit.org>
539
540         Reviewed by Adam Barth.
541
542         Remove unneeded Empty Queue messages
543         https://bugs.webkit.org/show_bug.cgi?id=45602
544
545         We already have a /gc job to delete these.
546         recentstatus.py is already smart enough to use the
547         most recent of the workitems last update or the most recent status,
548         so removing these should not change the _last_status_date() return
549         value more than a few milliseconds.
550
551         These messages just spam the recent status log.
552
553         * Scripts/webkitpy/tool/commands/queues.py:
554
555 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
556
557         Reviewed by Adam Barth.
558
559         Fix Python exception when generating synthetic patch IDs
560         https://bugs.webkit.org/show_bug.cgi?id=45592
561
562         Can't concatenate strings and numbers directly.
563
564         * QueueStatusServer/handlers/queuestatus.py:
565
566 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
567
568         Reviewed by Adam Barth.
569
570         Group statuses in queue status by patch ID
571         https://bugs.webkit.org/show_bug.cgi?id=45588
572
573         Group statuses by patch ID so that the status page is easier
574         to scan.
575
576         * QueueStatusServer/handlers/queuestatus.py:
577         * QueueStatusServer/stylesheets/dashboard.css:
578         (.status-group):
579         (.status-bug):
580         (.status-group ul):
581         (.status-group ul li):
582         (.status-group ul li:hover):
583         (.status-cell):
584         (.status-cell:hover):
585         (.status-cell.pass):
586         (.status-cell.fail):
587         (.status-cell.pending):
588         (.status-cell.error):
589         * QueueStatusServer/templates/dashboard.html:
590         * QueueStatusServer/templates/queuestatus.html:
591
592 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
593
594         Reviewed by Tony Chang.
595
596         Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
597         https://bugs.webkit.org/show_bug.cgi?id=45479
598
599         Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after
600         implementation in ResourceLoadDelegate in the Mac port).
601
602         * DumpRenderTree/chromium/LayoutTestController.cpp:
603         (LayoutTestController::LayoutTestController):
604         (LayoutTestController::dumpResourceResponseMIMETypes):
605         (LayoutTestController::reset):
606         * DumpRenderTree/chromium/LayoutTestController.h:
607         (LayoutTestController::setShouldDumpResourceResponseMIMETypes):
608         (LayoutTestController::shouldDumpResourceResponseMIMETypes):
609         * DumpRenderTree/chromium/TestShell.h:
610         (TestShell::shouldDumpResourceResponseMIMETypes):
611         * DumpRenderTree/chromium/WebViewHost.cpp:
612         (WebViewHost::didReceiveResponse):
613
614 2010-09-11  Eric Seidel  <eric@webkit.org>
615
616         Reviewed by Adam Barth.
617
618         queues.webkit.org should expose /remote_api for data upload/download
619         https://bugs.webkit.org/show_bug.cgi?id=45559
620
621         * QueueStatusServer/app.yaml:
622          - /remote_api is a standard app-engine service which allows use of
623            the bulk uploader for data upload/download.  Exposing this
624            (for admin access only) allows us to use 
625
626 2010-09-10  Sam Weinig  <sam@webkit.org>
627
628         Reviewed by Dan Bernstein.
629
630         Add zoom support to WebKit2 API
631         <rdar://problem/7660657>
632         https://bugs.webkit.org/show_bug.cgi?id=45585
633
634         - Add zoom options to MiniBrowser that mimic Safari's options using
635           the new WebKit2 zoom APIs.
636         - Switch uses of float for the zoom APIs to use double.
637
638         * MiniBrowser/mac/BrowserWindowController.h:
639         * MiniBrowser/mac/BrowserWindowController.m:
640         (-[BrowserWindowController initWithPageNamespace:]):
641         (-[BrowserWindowController validateMenuItem:]):
642         (-[BrowserWindowController validateUserInterfaceItem:]):
643         (-[BrowserWindowController currentZoomFactor]):
644         (-[BrowserWindowController setCurrentZoomFactor:]):
645         (-[BrowserWindowController canZoomIn]):
646         (-[BrowserWindowController zoomIn:]):
647         (-[BrowserWindowController canZoomOut]):
648         (-[BrowserWindowController zoomOut:]):
649         (-[BrowserWindowController canResetZoom]):
650         (-[BrowserWindowController resetZoom:]):
651         (-[BrowserWindowController toggleZoomMode:]):
652         * MiniBrowser/mac/MainMenu.xib:
653         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
654         (WTR::EventSendingController::textZoomIn):
655         (WTR::EventSendingController::textZoomOut):
656         (WTR::EventSendingController::zoomPageIn):
657         (WTR::EventSendingController::zoomPageOut):
658
659 2010-09-10  Robert Hogan  <robert@webkit.org>
660
661         Reviewed by Andreas Kling.
662
663         [Qt] Fix crash in DRT in standalone mode
664
665         https://bugs.webkit.org/show_bug.cgi?id=45454
666
667         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
668         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
669
670 2010-09-10  Sam Weinig  <sam@webkit.org>
671
672         Reviewed by Darin Adler.
673
674         Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom.
675         Precursor to <rdar://problem/7660657>
676         https://bugs.webkit.org/show_bug.cgi?id=45522
677
678         Update for changes to the Bundle API to allow separate control of page and text zoom
679         levels.
680
681         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
682         (WTR::EventSendingController::textZoomIn):
683         (WTR::EventSendingController::textZoomOut):
684         (WTR::EventSendingController::zoomPageIn):
685         (WTR::EventSendingController::zoomPageOut):
686         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
687         (WTR::InjectedBundlePage::reset):
688
689 2010-09-10  Yael Aharon  <yael.aharon@nokia.com>
690
691         Reviewed by Andreas Kling.
692
693         [Qt] Support click event for notifications
694         https://bugs.webkit.org/show_bug.cgi?id=44836
695
696         Add support for simulateDesktopNotificationClick by calling
697         back to DumpRenderTreeSupportQt.cpp.
698
699         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
700         (LayoutTestController::simulateDesktopNotificationClick):
701         * DumpRenderTree/qt/LayoutTestControllerQt.h:
702
703 2010-09-10  Mihai Parparita  <mihaip@chromium.org>
704
705         Reviewed by Eric Seidel.
706
707         Update queue status when patches fail their first land attempt
708         https://bugs.webkit.org/show_bug.cgi?id=45583
709
710         Add a few more _update_status calls to make it more obvious if a patch is 
711         being retried because tests failed.
712
713         * Scripts/webkitpy/tool/commands/queues.py:
714
715 2010-09-10  Balazs Kelemen  <kb@inf.u-szeged.hu>
716
717         Reviewed by Andreas Kling.
718
719         [Qt] MiniBrowser crashes with multiply windows when closing one of them
720         https://bugs.webkit.org/show_bug.cgi?id=45536
721
722         * MiniBrowser/qt/BrowserView.cpp:
723         (BrowserView::BrowserView): Reference the context instead of adopting it
724         because it can be shared across different views.
725
726 2010-09-10  Tony Chang  <tony@chromium.org>
727
728         Unreviewed, rolling out r67241.
729         http://trac.webkit.org/changeset/67241
730         https://bugs.webkit.org/show_bug.cgi?id=44709
731
732         Accidentally committed.
733
734         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
735         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
736
737 2010-09-10  Tony Chang  <tony@chromium.org>
738
739         Reviewed by Ojan Vafai.
740
741         deduplicate-tests should be runnable from any WebKit directory
742         https://bugs.webkit.org/show_bug.cgi?id=44709
743
744         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
745         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
746
747 2010-09-10  Tony Chang  <tony@chromium.org>
748
749         Unreviewed, rolling out r67216.
750         http://trac.webkit.org/changeset/67216
751         https://bugs.webkit.org/show_bug.cgi?id=44709
752
753         Broke
754
755         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
756         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
757
758 2010-09-10  Tony Chang  <tony@chromium.org>
759
760         Reviewed by Ojan Vafai.
761
762         deduplicate-tests should be runnable from any WebKit directory
763         https://bugs.webkit.org/show_bug.cgi?id=44709
764
765         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
766         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
767
768 2010-09-09  Hans Wennborg  <hans@chromium.org>
769
770         Reviewed by Jeremy Orlow.
771
772         Hook up LayoutTestController.setMockDeviceOrientation() in Chromium DumpRenderTree.
773         https://bugs.webkit.org/show_bug.cgi?id=45460
774
775         This enables DumpRenderTree to run layout tests for DeviceOrientation.
776
777         Also declare the LayoutTestController destructor out-of-line.
778         Otherwise the implicit destructor would cause compiler errors because
779         of the OwnPtr<WebKit::WebDeviceOrientationClientMock> member.
780
781         * DumpRenderTree/chromium/LayoutTestController.cpp:
782         (LayoutTestController::~LayoutTestController):
783         (LayoutTestController::setMockDeviceOrientation):
784         (LayoutTestController::deviceOrientationClient):
785         * DumpRenderTree/chromium/LayoutTestController.h:
786         * DumpRenderTree/chromium/WebViewHost.cpp:
787         (WebViewHost::deviceOrientationClient):
788         * DumpRenderTree/chromium/WebViewHost.h:
789
790 2010-09-09  Sheriff Bot  <webkit.review.bot@gmail.com>
791
792         Unreviewed, rolling out r67119.
793         http://trac.webkit.org/changeset/67119
794         https://bugs.webkit.org/show_bug.cgi?id=45505
795
796         Extra newlines in results (Requested by tony^work on #webkit).
797
798         * DumpRenderTree/chromium/LayoutTestController.cpp:
799         (LayoutTestController::LayoutTestController):
800         (LayoutTestController::reset):
801         * DumpRenderTree/chromium/LayoutTestController.h:
802         * DumpRenderTree/chromium/TestShell.h:
803         * DumpRenderTree/chromium/WebViewHost.cpp:
804         (printResponseDescription):
805         (printNodeDescription):
806         (printRangeDescription):
807         (WebViewHost::shouldBeginEditing):
808         (WebViewHost::shouldEndEditing):
809         (WebViewHost::shouldInsertNode):
810         (WebViewHost::shouldChangeSelectedRange):
811         (WebViewHost::shouldDeleteRange):
812         (WebViewHost::shouldApplyStyle):
813         (WebViewHost::didBeginEditing):
814         (WebViewHost::didChangeSelection):
815         (WebViewHost::didChangeContents):
816         (WebViewHost::didEndEditing):
817         (WebViewHost::decidePolicyForNavigation):
818         (WebViewHost::didCancelClientRedirect):
819         (WebViewHost::didStartProvisionalLoad):
820         (WebViewHost::didReceiveServerRedirectForProvisionalLoad):
821         (WebViewHost::didFailProvisionalLoad):
822         (WebViewHost::didCommitProvisionalLoad):
823         (WebViewHost::didFinishDocumentLoad):
824         (WebViewHost::didHandleOnloadEvents):
825         (WebViewHost::didFailLoad):
826         (WebViewHost::didFinishLoad):
827         (WebViewHost::didChangeLocationWithinPage):
828         (WebViewHost::willSendRequest):
829         (WebViewHost::didReceiveResponse):
830         (WebViewHost::didFinishResourceLoad):
831         (WebViewHost::didFailResourceLoad):
832         (WebViewHost::didDisplayInsecureContent):
833         (WebViewHost::didRunInsecureContent):
834         (WebViewHost::printFrameDescription):
835
836 2010-09-09  Michael Saboff  <msaboff@apple.com>
837
838         Unreviewed, adding myself to committers list.
839
840         * Scripts/webkitpy/common/config/committers.py:
841
842 2010-09-09  Mihai Parparita  <mihaip@chromium.org>
843
844         Reviewed by Tony Chang.
845
846         Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
847         https://bugs.webkit.org/show_bug.cgi?id=45479
848
849         Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after
850         implementation in ResourceLoadDelegate in the Mac port).
851
852         * DumpRenderTree/chromium/LayoutTestController.cpp:
853         (LayoutTestController::LayoutTestController):
854         (LayoutTestController::dumpResourceResponseMIMETypes):
855         (LayoutTestController::reset):
856         * DumpRenderTree/chromium/LayoutTestController.h:
857         (LayoutTestController::setShouldDumpResourceResponseMIMETypes):
858         (LayoutTestController::shouldDumpResourceResponseMIMETypes):
859         * DumpRenderTree/chromium/TestShell.h:
860         (TestShell::shouldDumpResourceResponseMIMETypes):
861         * DumpRenderTree/chromium/WebViewHost.cpp:
862         (WebViewHost::didReceiveResponse):
863
864 2010-09-09  Mihai Parparita  <mihaip@chromium.org>
865
866         Reviewed by Daniel Bates.
867
868         svn-apply tries to delete directories it shouldn't
869         https://bugs.webkit.org/show_bug.cgi?id=45424
870
871         isDirectoryEmptyForRemoval had the wrong check. If an item in the
872         directory is itself a directory, then the directory is definitely
873         not empty.
874
875         * Scripts/svn-apply:
876
877 2010-09-09  Chris Fleizach  <cfleizach@apple.com>
878
879         Fixing GTK and windows build failure.
880
881         AX: Support AccessibilityTextMarkers in DRT
882         https://bugs.webkit.org/show_bug.cgi?id=44778
883
884         * DumpRenderTree/AccessibilityTextMarker.h:
885         (AccessibilityTextMarker::platformTextMarker):
886         (AccessibilityTextMarkerRange::platformTextMarkerRange):
887         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
888         (AccessibilityTextMarker::platformTextMarker):
889         (AccessibilityTextMarkerRange::platformTextMarkerRange):
890
891 2010-09-09  Chris Fleizach  <cfleizach@apple.com>
892
893         Reviewed by David Kilzer.
894
895         AX: Support AccessibilityTextMarkers in DRT
896         https://bugs.webkit.org/show_bug.cgi?id=44778
897
898         Add AccessibilityTextMarker and AccessibilityTextMarkerRange which encapsulate the AXTextMarkers 
899         that WebCore uses when vending information about its VisiblePositions through AX.
900
901         There are a few new methods in AccessibilityUIElement to retrieve and use text markers, and some basic
902         methods for encapsulating and checking equality.
903
904         This will allow future bug fixes in the text marker system to be adequately tested.
905
906         * DumpRenderTree/AccessibilityTextMarker.cpp: Added.
907         (toTextMarker):
908         (isMarkerEqualCallback):
909         (markerFinalize):
910         (AccessibilityTextMarker::makeJSAccessibilityTextMarker):
911         (AccessibilityTextMarker::getJSClass):
912         (toTextMarkerRange):
913         (isMarkerRangeEqualCallback):
914         (markerRangeFinalize):
915         (AccessibilityTextMarkerRange::makeJSAccessibilityTextMarkerRange):
916         (AccessibilityTextMarkerRange::getJSClass):
917         * DumpRenderTree/AccessibilityTextMarker.h: Added.
918         (AccessibilityTextMarker::platformTextMarker):
919         (AccessibilityTextMarkerRange::platformTextMarkerRange):
920         (AccessibilityTextMarker::AccessibilityTextMarker):
921         (AccessibilityTextMarker::~AccessibilityTextMarker):
922         (AccessibilityTextMarker::isEqual):
923         (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
924         (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
925         (AccessibilityTextMarkerRange::isEqual):
926         * DumpRenderTree/AccessibilityUIElement.cpp:
927         (textMarkerRangeForElementCallback):
928         (textMarkerRangeLengthCallback):
929         (textMarkerRangeForMarkersCallback):
930         (startTextMarkerForTextMarkerRangeCallback):
931         (endTextMarkerForTextMarkerRangeCallback):
932         (accessibilityElementForTextMarkerCallback):
933         (AccessibilityUIElement::textMarkerRangeForElement):
934         (AccessibilityUIElement::textMarkerRangeLength):
935         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
936         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
937         (AccessibilityUIElement::accessibilityElementForTextMarker):
938         (AccessibilityUIElement::getJSClass):
939         * DumpRenderTree/AccessibilityUIElement.h:
940         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
941         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm: Added.
942         (AccessibilityTextMarker::AccessibilityTextMarker):
943         (AccessibilityTextMarker::~AccessibilityTextMarker):
944         (AccessibilityTextMarker::isEqual):
945         (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
946         (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
947         (AccessibilityTextMarkerRange::isEqual):
948         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
949         (AccessibilityUIElement::textMarkerRangeForElement):
950         (AccessibilityUIElement::textMarkerRangeLength):
951         (AccessibilityUIElement::textMarkerRangeForMarkers):
952         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
953         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
954         (AccessibilityUIElement::accessibilityElementForTextMarker):
955         * DumpRenderTree/win/DumpRenderTree.vcproj:
956
957 2010-08-25  Tony Chang  <tony@chromium.org>
958
959         Reviewed by Ojan Vafai.
960
961         don't delete duplicates needed because of intermediate results
962         https://bugs.webkit.org/show_bug.cgi?id=44653
963
964         Also, output the full path so we can pipe the output to rm.
965
966         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
967         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
968
969 2010-09-09  Balazs Kelemen  <kb@inf.u-szeged.hu>
970
971         Reviewed by Andreas Kling.
972
973         [Qt] MiniBrowser does not starts properly
974         https://bugs.webkit.org/show_bug.cgi?id=45459
975
976         Do not try set up the first window by calling newWindow on a
977         newly created BrowserWindow since it creates a new object.
978         * MiniBrowser/qt/BrowserWindow.cpp:
979         (BrowserWindow::BrowserWindow):
980         * MiniBrowser/qt/main.cpp:
981         (main):
982
983 2010-09-09  Martin Robinson  <mrobinson@igalia.com>
984
985         Reviewed by Xan Lopez.
986
987         [GTK] Get ImageDiff building on Win32
988         https://bugs.webkit.org/show_bug.cgi?id=45353
989
990         * DumpRenderTree/gtk/ImageDiff.cpp:
991         (main): Switch from using strtok to g_strsplit.
992
993 2010-09-09  Zoltan Horvath  <zoltan@webkit.org>
994
995         Reviewed by Andreas Kling.
996
997         [Qt] Modify load method of MiniBrowser's BrowserView class
998         https://bugs.webkit.org/show_bug.cgi?id=45442
999
1000         Modify load method to take a QString as argument, remove unnecessary QT_VERSION_CHECK.
1001
1002         * MiniBrowser/qt/BrowserView.cpp:
1003         (BrowserView::load):
1004         * MiniBrowser/qt/BrowserView.h:
1005         * MiniBrowser/qt/BrowserWindow.cpp:
1006         (BrowserWindow::load):
1007
1008 2010-09-09  Tony Chang  <tony@chromium.org>
1009
1010         Reviewed by Ojan Vafai.
1011
1012         fix show_results in new-run-webkit-tests
1013         https://bugs.webkit.org/show_bug.cgi?id=45413
1014
1015         * Scripts/webkitpy/layout_tests/port/chromium.py:
1016
1017 2010-09-08  Victor Wang  <victorw@chromium.org>
1018
1019         Reviewed by Ojan Vafai.
1020
1021         [Chromium] Fix test results server to make sure
1022         it does not have corrupted data.
1023
1024         results.json file size coulbe be >1M and we split
1025         the data into multiple data store entries in this
1026         case. This patch fixes the issue that the data may
1027         be corrupted if data store error happens in the middle
1028         of saving multiple entries.
1029
1030         https://bugs.webkit.org/show_bug.cgi?id=45063
1031
1032         * TestResultServer/model/datastorefile.py:
1033
1034 2010-09-08  Peter Varga  <pvarga@inf.u-szeged.hu>
1035
1036         Reviewed by Kenneth Rohde Christiansen.
1037
1038         Fix ignoring return value warning in case of gcc 4.4.4
1039         https://bugs.webkit.org/show_bug.cgi?id=45384
1040
1041         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1042         (testPostURLFile):
1043         If fwrite have written zero byte then the testPostURLFile function
1044         returns with false as tempFile can't be opened.
1045         * DumpRenderTree/qt/ImageDiff.cpp:
1046         (main):
1047         Put fwrite function into an if condition without body to avoid
1048         warning. It is safe because this function writes to the stdout.
1049
1050 2010-09-08  Satish Sampath  <satish@chromium.org>
1051
1052         Unreviewed, adding myself to committers list.
1053
1054         * Scripts/webkitpy/common/config/committers.py:
1055
1056 2010-09-08  Hans Wennborg  <hans@chromium.org>
1057
1058         Unreviewed.
1059
1060         Adding myself as a committer in committers.py.
1061
1062         * Scripts/webkitpy/common/config/committers.py:
1063
1064 2010-09-08  Zoltan Horvath  <zoltan@webkit.org>
1065
1066         Reviewed by Simon Hausmann.
1067
1068         [Qt] Refactor MiniBrowser 
1069         https://bugs.webkit.org/show_bug.cgi?id=45173
1070
1071         Split BrowserWindow into two source files and headers. Remove unnecessary header includes.
1072
1073         * MiniBrowser/qt/BrowserView.cpp: Added.
1074         (createNewPage):
1075         (BrowserView::BrowserView):
1076         (BrowserView::resizeEvent):
1077         (BrowserView::load):
1078         (BrowserView::view):
1079         * MiniBrowser/qt/BrowserView.h: Added.
1080         (BrowserView::~BrowserView):
1081         * MiniBrowser/qt/BrowserWindow.cpp:
1082         * MiniBrowser/qt/BrowserWindow.h:
1083         * MiniBrowser/qt/MiniBrowser.pro:
1084
1085 2010-09-08  Adam Barth  <abarth@webkit.org>
1086
1087         Rubber-stamped by Eric Seidel.
1088
1089         Rename DocLoader to CachedResourceLoader because that's what it does.
1090
1091         * Scripts/do-webcore-rename:
1092
1093 2010-09-07  Kinuko Yasuda  <kinuko@chromium.org>
1094
1095         Reviewed by Ojan Vafai.
1096
1097         Enable incremental results.json generation for non-layout tests.
1098         https://bugs.webkit.org/show_bug.cgi?id=45315
1099
1100         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: Enable generate_incremental_results=True by default. (This still keeps to generate results.json.)  Also add a code to upload results json files to the app-engine server.  Need a chromium change to actually start the uploading.
1101
1102         * TestResultServer/model/jsonresults.py: Make sure we save the file with test_type for incremental cases too.
1103
1104
1105 2010-09-07  Dirk Pranke  <dpranke@chromium.org>
1106
1107         Unreviewed, build fix
1108
1109         Missed one test in mac_unittest.py in previous change; for some
1110         reason the method is listed twice. I will fix both for now, but will
1111         figure this out in a later, not-time-sensitive patch.
1112
1113         https://bugs.webkit.org/show_bug.cgi?id=45357
1114
1115         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1116
1117 2010-09-07  Kent Tamura  <tkent@chromium.org>
1118
1119         Reviewed by Tony Chang.
1120
1121         test-webkitpy: Fix load error of
1122         webkitpy/layout_tests/port/factory_unittest.py on Win32 Python
1123         https://bugs.webkit.org/show_bug.cgi?id=45356 Need a short
1124
1125         * Scripts/webkitpy/layout_tests/port/server_process.py:
1126           Avoid to import fcntl on win32. Win32 Python doesn't have fcntl
1127           and we don't use server_process.py on Win32 Python. However
1128           unittest.py tries to load everything in a module.
1129
1130 2010-09-07  Dirk Pranke  <dpranke@chromium.org>
1131
1132         Reviewed by Kent Tamura.
1133
1134         Fix regression introduced in previous change to new-run-webkit-tests
1135         (bug 45090) to not try to run unittests for the Mac implementation
1136         of the Port interface if we aren't running on a Mac.
1137
1138         Also fix the overrides implementation mock in the chromium unittests
1139         to fix the case where there are overrides checked in that cause
1140         problems.
1141
1142         https://bugs.webkit.org/show_bug.cgi?id=45357
1143
1144         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1145         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1146         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1147
1148 2010-09-01  Dirk Pranke  <dpranke@chromium.org>
1149
1150         Reviewed by Ojan Vafai.
1151
1152         new-run-webkit-tests: still more unit tests
1153
1154         Clean up and remove unnecessary code. Biggest notable change is
1155         moving the chromium-specific imagediff code from port/base to
1156         port/chromium.
1157
1158         Add more unit tests for run_webkit_tests.py, port/base.py,
1159         port/factory.py, port/dryrun.py, and
1160         layout_package/dump_render_tree_thread.py
1161
1162         This covers almost all of the generic and test code paths except for
1163         a few error paths involving invalid or port-specific command line
1164         arguments, and the code path for uploading results files to the
1165         buildbots.
1166         
1167         https://bugs.webkit.org/show_bug.cgi?id=45090
1168
1169         * Scripts/webkitpy/layout_tests/data/failures/expected/hang.html: Added.
1170         * Scripts/webkitpy/layout_tests/data/http/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
1171         * Scripts/webkitpy/layout_tests/data/http/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
1172         * Scripts/webkitpy/layout_tests/data/http/tests/ssl/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
1173         * Scripts/webkitpy/layout_tests/data/http/tests/ssl/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
1174         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
1175         * Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
1176         * Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
1177         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1178         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Added.
1179         * Scripts/webkitpy/layout_tests/port/base.py:
1180         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1181         * Scripts/webkitpy/layout_tests/port/chromium.py:
1182         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1183         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1184         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1185         * Scripts/webkitpy/layout_tests/port/port_testcase.py: Added.
1186         * Scripts/webkitpy/layout_tests/port/server_process.py:
1187         * Scripts/webkitpy/layout_tests/port/test.py:
1188         * Scripts/webkitpy/layout_tests/port/webkit.py:
1189         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1190         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1191
1192 2010-09-07  Joseph Pecoraro  <joepeck@webkit.org>
1193
1194         Reviewed by Darin Adler.
1195
1196         Provide a way to trigger a <select multiple> onchange event on changes
1197         https://bugs.webkit.org/show_bug.cgi?id=45192
1198
1199         Adds a selector on ObjCController for testing
1200         -[DOMHTMLSelectElement _activateItemAtIndex:allowMultipleSelection:] and
1201         its different uses.
1202
1203         * DumpRenderTree/mac/ObjCController.m:
1204         (+[ObjCController isSelectorExcludedFromWebScript:]):
1205         (+[ObjCController webScriptNameForSelector:]):
1206         (-[ObjCController setSelectElement:selectedIndex:allowingMultiple:]):
1207
1208 2010-09-07  James Robinson  <jamesr@chromium.org>
1209
1210         Rubber-stamped by Dimitri Glazkov.
1211
1212         Move myself from the committer to the reviewer list.
1213
1214         * Scripts/webkitpy/common/config/committers.py:
1215
1216 2010-09-07  Tony Chang  <tony@chromium.org>
1217
1218         Reviewed by Darin Fisher.
1219
1220         [chromium] Make a public flag for how DRT generates bitmaps on Linux
1221         https://bugs.webkit.org/show_bug.cgi?id=45133
1222
1223         * DumpRenderTree/chromium/TestShell.cpp:
1224         (TestShell::dumpImage):
1225
1226 2010-09-07  Kent Tamura  <tkent@chromium.org>
1227
1228         Reviewed by Dimitri Glazkov.
1229
1230         [DRT/Chromium] Implement --check-layout-test-sys-deps
1231         https://bugs.webkit.org/show_bug.cgi?id=45283
1232
1233         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1234         (main): Check --check-layout-test-sys-deps and call checkLayoutTestSystemDependencies().
1235         * DumpRenderTree/chromium/TestShell.h: Declare checkLayoutTestSystemDependencies().
1236         * DumpRenderTree/chromium/TestShellGtk.cpp:
1237         (checkLayoutTestSystemDependencies): Add an empty implementation.
1238         * DumpRenderTree/chromium/TestShellMac.mm:
1239         (checkLayoutTestSystemDependencies): Add an empty implementation.
1240         * DumpRenderTree/chromium/TestShellWin.cpp:
1241         (checkLayoutTestSystemDependencies): Port similar function of test_shell.
1242
1243 2010-09-07  Jessie Berlin  <jberlin@apple.com>
1244
1245         Unreviewed. Mac build fix.
1246
1247         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1248         (didClearWindowObjectForFrame):
1249
1250 2010-09-07  Jessie Berlin  <jberlin@apple.com>
1251
1252         Reviewed by Darin Adler.
1253
1254         Indicate which one of the ScriptWorlds for a Frame the Window Object has been cleared for
1255         https://bugs.webkit.org/show_bug.cgi?id=45217
1256         
1257         Make WebKitTestRunner work with this change.
1258
1259         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1260         (WTR::InjectedBundlePage::didClearWindowForFrame):
1261         Make sure the ScriptWorld here is the normal world, since that is no longer being done in
1262         WebFrameLoaderClient.
1263         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1264
1265 2010-09-07  Philippe Normand  <pnormand@igalia.com>
1266
1267         Unreviewed, build fix.
1268
1269         webkit-patch command to find the ports covering a specific layout test
1270         https://bugs.webkit.org/show_bug.cgi?id=42832
1271
1272         * Scripts/webkitpy/layout_tests/port/chromium.py: Don't assume the
1273         tests are present when building the expectations. This is needed
1274         for the unittests.
1275
1276 2010-09-06  Philippe Normand  <pnormand@igalia.com>
1277
1278         Reviewed by Adam Barth.
1279
1280         webkit-patch command to find the ports covering a specific layout test
1281         https://bugs.webkit.org/show_bug.cgi?id=42832
1282
1283         To use it: webkit-patch skipped-ports some/layout/test.html
1284
1285         * Scripts/webkitpy/layout_tests/port/base.py:
1286         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1287         * Scripts/webkitpy/layout_tests/port/chromium.py:
1288         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1289         * Scripts/webkitpy/layout_tests/port/factory.py:
1290         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1291         * Scripts/webkitpy/layout_tests/port/test.py:
1292         * Scripts/webkitpy/layout_tests/port/webkit.py:
1293         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1294         * Scripts/webkitpy/tool/commands/queries.py:
1295         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1296         * Scripts/webkitpy/tool/main.py:
1297         * Scripts/webkitpy/tool/mocktool.py:
1298
1299 2010-09-07  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1300
1301         Reviewed by Eric Seidel.
1302
1303         [NRWT] Add temp directory to all running drivers.
1304         https://bugs.webkit.org/show_bug.cgi?id=45261
1305
1306         * Scripts/webkitpy/layout_tests/port/webkit.py:
1307
1308 2010-09-06  Dimitri Glazkov  <dglazkov@chromium.org>
1309
1310         Reviewed by Kent Tamura.
1311
1312         [Chromium/DRT] Empty out user stylesheet after each test run.
1313         https://bugs.webkit.org/show_bug.cgi?id=45282
1314
1315         This should significantly cut down on the number of the mysterious flaky tests
1316         whose diffs looked like the page was blown up to a very lage size. This
1317         was indeed the dirty work of platform/mac/fast/loader/user-stylesheet-fast-path.html,
1318         which set the base body font to 100px.
1319
1320         Since the user stylesheet was never reset, _all_ pixel tests that ran after it in
1321         the same thread failed.
1322
1323         * DumpRenderTree/chromium/TestShell.cpp:
1324         (TestShell::resetWebSettings): Set user stylesheet to an empty URL.
1325
1326 2010-09-06  Kent Tamura  <tkent@chromium.org>
1327
1328         Reviewed by Dimitri Glazkov.
1329
1330         [DRT/Chromium] Do not generate pixel results for text/plain resources
1331         https://bugs.webkit.org/show_bug.cgi?id=45253
1332
1333         * DumpRenderTree/chromium/TestShell.cpp:
1334         (TestShell::dump): Clear shouldGeneratePixelResults flag for text/plain.
1335
1336 2010-09-06  Ojan Vafai  <ojan@chromium.org>
1337
1338         Reviewed by Kent Tamura.
1339
1340         print out correct error when a DRT thread dies in NRWT
1341         https://bugs.webkit.org/show_bug.cgi?id=45281
1342
1343         Not sure why, but with the parens, python 2.6.5 on Linux
1344         gives an error that raise takes 5 arguments and 0 were given.
1345         Didn't test other platforms or python versions, but putting it
1346         all on one line fixes it and correctly prints the exception
1347         from the DRT thread.
1348
1349         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1350
1351 2010-09-06  Eric Seidel  <eric@webkit.org>
1352
1353         Unreviewed, just adding some emails from lists.webkit.org.
1354
1355         Update committers.py to include emails from lists.webkit.org
1356         as found by the validate-committer-lists script.
1357
1358         * Scripts/webkitpy/common/config/committers.py:
1359
1360 2010-09-06  Martin Robinson  <mrobinson@igalia.com>
1361
1362         Reviewed by Xan Lopez.
1363
1364         [GTK] Small code cleanup in DumpRenderTreeGtk.cpp
1365         https://bugs.webkit.org/show_bug.cgi?id=45213
1366
1367         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1368         (initializeFonts): Made this function do nothing for non-X11 platforms, so we don't
1369         have to surround the invocation with #ifdefs.
1370         (useLongRunningServerMode): Added.
1371         (runTestingServerLoop): Added.
1372         (initializeGlobalsFromCommandLineOptions): Added.
1373         (runTest): Removed ifdefs.
1374         (main): Use new helper functions.
1375
1376 2010-09-06  Martin Robinson  <mrobinson@igalia.com>
1377
1378         Reviewed by Xan Lopez.
1379
1380         [GTK] EventSender should support modifier keys with mouseDown and mouseUp events
1381         https://bugs.webkit.org/show_bug.cgi?id=45235
1382
1383         Add support for interpreting the modifier key arguments to the mouseDown and mouseUp
1384         methods of the EventSender.
1385
1386         * DumpRenderTree/gtk/EventSender.cpp:
1387         (prepareMouseButtonEvent): Allow passing in a modifier bitmask, which will be OR'd
1388         with the current modifiers.
1389         (contextClickCallback): Always send no modifiers when preparing the mouse event.
1390         (gdkModifersFromJSValue): Added, converts a JSValue array into a GDK modifier bitmask.
1391         (mouseDownCallback): Send in the requested modifiers to prepareMouseButtonEvent.
1392         (mouseUpCallback): Ditto.
1393
1394 2010-09-05  Peter Kasting  <pkasting@google.com>
1395
1396         Reviewed by Adam Barth.
1397
1398         Make Chromium/Mac generate continuous mousewheel events with the same wheelDelta values as Safari/Mac.
1399         https://bugs.webkit.org/show_bug.cgi?id=45155
1400
1401         * DumpRenderTree/chromium/EventSender.cpp: Modify Chromium DRT mousewheel event generation to match new behavior on Mac.
1402         (EventSender::handleMouseWheel):
1403
1404 2010-09-05  Yury Semikhatsky  <yurys@chromium.org>
1405
1406         Reviewed by Joseph Pecoraro.
1407
1408         Web Inspector: remove WebDevToolsAgentClient::forceRepaint which is not used
1409         https://bugs.webkit.org/show_bug.cgi?id=45179
1410
1411         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1412         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1413
1414 2010-09-05  Andreas Kling  <andreas.kling@nokia.com>
1415
1416         Rubber-stamped by Daniel Bates.
1417
1418         Adding myself as reviewer.
1419
1420         * Scripts/webkitpy/common/config/committers.py:
1421
1422 2010-09-04  Daniel Bates  <dbates@rim.com>
1423
1424         Reviewed by Martin Robinson.
1425
1426         Teach svn-apply/unapply about svn:mergeinfo
1427         https://bugs.webkit.org/show_bug.cgi?id=45236
1428
1429         Recognize the svn:mergeinfo property and ignore it for now.
1430
1431         Currently, svn-apply/unapply recognize only '+' and '-'
1432         property changes within a diff. We should add support
1433         to recognize "Merged" and "Reverse-merged" changes as well.
1434         Because svn:mergeinfo is metadata that is used only by SVN
1435         and tends to be error-prone and/or nuisance (*), we will ignore
1436         it for now.
1437         (*) See "Parting Thoughts" of <http://www.collab.net/community/subversion/articles/merge-info.html>.
1438
1439         * Scripts/VCSUtils.pm:
1440           - Modified parseSvnProperty() to recognize "Merged" and
1441             "Reverse-merged" as the start of a property value.
1442         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
1443           - Added the following unit tests:
1444             "simple: add svn:mergeinfo"
1445             "simple: delete svn:mergeinfo"
1446             "simple: modified svn:mergeinfo"
1447         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
1448           - Added the following unit tests:
1449             "simple: add svn:mergeinfo"
1450             "simple: delete svn:mergeinfo"
1451             "simple: modified svn:mergeinfo"
1452             "simple: modified svn:mergeinfo using SVN 1.4 syntax"
1453             "'Merged' change followed by 'Merged' change"
1454             "'Reverse-merged' change followed by 'Reverse-merged' change"
1455         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
1456           - Added the following unit tests:
1457             "'Merged' change"
1458             "'Reverse-merged' change"
1459             "'Reverse-merged' change followed by 'Merge' change"
1460             "'Merged' change followed by 'Merge' change"
1461             "'Reverse-merged' change followed by 'Reverse-merged' change"
1462             "'Reverse-merged' change followed by 'Reverse-merged' change followed by 'Merged' change"
1463
1464 2010-09-04  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
1465
1466         Reviewed by Kenneth Rohde Christiansen.
1467
1468         [EFL] Move test browser to WebKitTools directory
1469         https://bugs.webkit.org/show_bug.cgi?id=45212
1470
1471         Follow other ports like QT and GTK which moved the test browser to
1472         WebKitTools directory.
1473
1474         * CMakeListsEfl.txt: Added.
1475         * EWebLauncher/main.c: Added.
1476         (print_history):
1477         (zoom_level_set):
1478         (on_ecore_evas_resize):
1479         (title_set):
1480         (viewport_set):
1481         (on_title_changed):
1482         (on_progress):
1483         (on_load_finished):
1484         (on_toolbars_visible_set):
1485         (on_toolbars_visible_get):
1486         (on_statusbar_visible_set):
1487         (on_statusbar_visible_get):
1488         (on_scrollbars_visible_set):
1489         (on_scrollbars_visible_get):
1490         (on_menubar_visible_set):
1491         (on_menubar_visible_get):
1492         (on_tooltip_text_set):
1493         (on_inputmethod_changed):
1494         (on_viewport_changed):
1495         (on_mouse_down):
1496         (on_focus_out):
1497         (on_focus_in):
1498         (on_resized):
1499         (on_key_down):
1500         (on_browser_del):
1501         (on_closeWindow):
1502         (quit):
1503         (browserCreate):
1504         (browserDestroy):
1505         (closeWindow):
1506         (main_signal_exit):
1507         (findThemePath):
1508         (main):
1509
1510 2010-09-03  Simon Fraser  <simon.fraser@apple.com>
1511
1512         Reviewed by Adam Roben.
1513
1514         Set project dependencies so that they build serially. This fixes
1515         issues when running run-webkit-tests if DRT is not built yet.
1516
1517         * DumpRenderTree/DumpRenderTree.sln:
1518
1519 2010-09-03  Dimitri Glazkov  <dglazkov@chromium.org>
1520
1521         Reviewed by Adam Barth.
1522
1523         Fix reading configuraiton in NWRT to work on Windows.
1524         https://bugs.webkit.org/show_bug.cgi?id=45180
1525
1526         * Scripts/webkitpy/layout_tests/port/base.py: Added 'perl' argument, because Windows doesn't know what to do
1527             with the file otherwise.
1528
1529 2010-09-03  Chris Rogers  <crogers@google.com>
1530
1531         Unreviewed
1532
1533         Add myself to the committers list
1534         https://bugs.webkit.org/show_bug.cgi?id=45189
1535
1536         * Scripts/webkitpy/common/config/committers.py:
1537
1538 2010-09-03  Andrey Kosyakov  <caseq@chromium.org>
1539
1540         Reviewed by Yury Semikhatsky.
1541
1542         http/tests/inspector/console-xhr-logging.html and http/tests/inspector/resource-har-conversion.html are failing on chromium win bot
1543         Changed MIME type for .js to application/x-javascript for consistency with apache used on other platforms.
1544         https://bugs.webkit.org/show_bug.cgi?id=45137
1545
1546         * Scripts/webkitpy/layout_tests/port/lighttpd.conf:
1547
1548 2010-09-03  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1549
1550         Reviewed by Eric Seidel.
1551
1552         Add feature detection support to NRWT.
1553         https://bugs.webkit.org/show_bug.cgi?id=41842
1554
1555         * Scripts/webkitpy/layout_tests/port/base.py:
1556         * Scripts/webkitpy/layout_tests/port/qt.py:
1557         * Scripts/webkitpy/layout_tests/port/webkit.py:
1558         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added.
1559
1560 2010-09-03  Hironori Bono  <hbono@chromium.org>
1561
1562         Reviewed by Kent Tamura.
1563
1564         Adds textInputController.hasSpellingMarker() to avoid using pixel tests for spellchecking tests
1565         and implements it for Mac.
1566         https://bugs.webkit.org/show_bug.cgi?id=41832
1567
1568         * DumpRenderTree/mac/TextInputController.m: Added [TextInputController hasSpellingMarker:length:]
1569         and bind it so we can call it from JavaScript.
1570         (+[TextInputController isSelectorExcludedFromWebScript:]):
1571         (+[TextInputController webScriptNameForSelector:]):
1572         (-[TextInputController hasSpellingMarker:length:]):
1573
1574 2010-09-02  Eric Seidel  <eric@webkit.org>
1575
1576         Reviewed by Adam Barth.
1577
1578         Add a unit test for commit-queue retries
1579         https://bugs.webkit.org/show_bug.cgi?id=45162
1580
1581         I think commit-queue retries are not correctly avoiding
1582         build and test on retries.  So I started testing the code.
1583         Unfortunately this test did not find the bug.  But now
1584         that we have the test we might as well keep it.
1585         I also fixed a broken import in validate-committer-lists.
1586
1587         * Scripts/validate-committer-lists:
1588         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1589
1590 2010-09-02  Kent Tamura  <tkent@chromium.org>
1591
1592         Reviewed by Dimitri Glazkov.
1593
1594         [DRT/Chromium] Remove dependency to base/task.h and base/timer.h
1595         https://bugs.webkit.org/show_bug.cgi?id=45091
1596
1597         Task.{cpp,h} introduces a simpler version of Chromium
1598         base/task.h. It doesn't have TupleN and Method.
1599
1600         * DumpRenderTree/DumpRenderTree.gypi:
1601          Add Task.cpp and Task.h
1602         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1603         (DRTDevToolsAgent::DRTDevToolsAgent):
1604         (DRTDevToolsAgent::reset):
1605         (DRTDevToolsAgent::asyncCall):
1606         (DRTDevToolsAgent::frontendLoaded):
1607         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1608         (DRTDevToolsAgent::taskList): Added to use MethodTask<T>.
1609         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1610         (DRTDevToolsClient::DRTDevToolsClient):
1611         (DRTDevToolsClient::~DRTDevToolsClient):
1612         (DRTDevToolsClient::reset):
1613         (DRTDevToolsClient::asyncCall):
1614         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1615         (DRTDevToolsClient::taskList): Added to use MethodTask<T>.
1616         * DumpRenderTree/chromium/EventSender.cpp:
1617         (EventSender::EventSender):
1618         (EventSender::reset):
1619         (EventSender::scheduleAsynchronousClick):
1620         * DumpRenderTree/chromium/EventSender.h:
1621         (EventSender::taskList): Added to use MethodTask<T>.
1622         * DumpRenderTree/chromium/LayoutTestController.cpp:
1623         (LayoutTestController::LayoutTestController):
1624         (LayoutTestController::WorkQueue::processWorkSoon):
1625         (LayoutTestController::waitUntilDone):
1626         (LayoutTestController::notifyDone):
1627         (LayoutTestController::reset):
1628         * DumpRenderTree/chromium/LayoutTestController.h:
1629         (LayoutTestController::taskList): Added to use MethodTask<T>.
1630         (LayoutTestController::WorkQueue::taskList): Added to use MethodTask<T>.
1631         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1632         (deferredDisplayDispatch):
1633         (NotificationPresenter::show):
1634         * DumpRenderTree/chromium/Task.cpp: Added.
1635         * DumpRenderTree/chromium/Task.h: Added.
1636
1637 2010-09-02  Steve Block  <steveblock@google.com>
1638
1639         Reviewed by Adam Barth.
1640
1641         Hook up LayoutTestController.setMockDeviceOrientation() on Mac.
1642         https://bugs.webkit.org/show_bug.cgi?id=43181
1643
1644         * DumpRenderTree/mac/DumpRenderTree.mm:
1645         (createWebViewAndOffscreenWindow):
1646         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1647         (LayoutTestController::setMockDeviceOrientation):
1648
1649 2010-08-31  Adam Roben  <aroben@apple.com>
1650
1651         Fix flashiness when resizing the browser window on Windows
1652
1653         Reviewed by Sam Weinig.
1654
1655         * MiniBrowser/win/BrowserWindow.cpp:
1656         (BrowserWindow::wndProc): Override WM_ERASEBKGND so Windows won't
1657         periodically fill the window with white.
1658
1659 2010-09-02  Peter Kasting  <pkasting@google.com>
1660
1661         Reviewed by Dimitri Glazkov.
1662
1663         Implement [continuous]MouseScrollBy() on Chromium, and partly on GTK.
1664         https://bugs.webkit.org/show_bug.cgi?id=45073
1665
1666         * DumpRenderTree/chromium/EventSender.cpp:
1667         (EventSender::EventSender):
1668         (EventSender::mouseScrollBy):
1669         (EventSender::continuousMouseScrollBy):
1670         (EventSender::sendCurrentTouchEvent):
1671         (EventSender::handleMouseWheel):
1672         * DumpRenderTree/chromium/EventSender.h:
1673         * DumpRenderTree/gtk/EventSender.cpp:
1674         (mouseScrollByCallback):
1675         (continuousMouseScrollByCallback):
1676
1677 2010-09-01  Dirk Pranke  <dpranke@chromium.org>
1678
1679         Reviewed by Tony Chang.
1680
1681         Land a patched version of r66542 - change TestRunner to have an
1682         separate cleanup method and fix the ordering of cleanup between
1683         TestRunner and the printing module, and then wrap everything in a
1684         try/finally block to ensure reliable cleanup without needing to
1685         rely on stuff happening in the destructor of the TestRunner.
1686
1687         Also refactor run_webkit_tests.run() to be much smaller and cleaner
1688         by creating a bunch of helper methods and moving more stuff into
1689         the TestRunner class.
1690
1691         This fixes the crash at the end of the linux test run of
1692         new-run-webkit-tests (and undoes the rollout in 66547).
1693
1694         https://bugs.webkit.org/show_bug.cgi?id=44902
1695
1696         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Added.
1697         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Added.
1698         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Added.
1699         * Scripts/webkitpy/layout_tests/data/passes/error.html: Added.
1700         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
1701         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1702         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1703         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1704         * Scripts/webkitpy/layout_tests/port/base.py:
1705         * Scripts/webkitpy/layout_tests/port/test.py:
1706         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1707         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1708
1709 2010-09-01  Mark Rowe  <mrowe@apple.com>
1710
1711         Reviewed by Adam Roben.
1712
1713         Fix TestNetscapePlugIn to compile without access to QuickDraw private headers.
1714
1715         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1716
1717 2010-09-01  Brian Weinstein  <bweinstein@apple.com>
1718
1719         Reviewed by Adam Roben.
1720
1721         Have kill-old-processes kill debug and release variants of WebKit2WebWebProcess
1722         and WebKitTestRunner.
1723
1724         * BuildSlaveSupport/win/kill-old-processes:
1725
1726 2010-09-01  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1727
1728         Reviewed by Antonio Gomes.
1729
1730         [Qt] Remove obsolete include path from DumpRenderTree.pro
1731
1732         * DumpRenderTree/qt/DumpRenderTree.pro:
1733
1734 2010-09-01  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1735
1736         Reviewed by Laszlo Gombos.
1737
1738         [Qt] QWebPage::allowGeolocationRequest should be async API
1739         https://bugs.webkit.org/show_bug.cgi?id=41364
1740
1741         Implements new async API for geolocation permission similar to
1742         Notification. WebPage maintains list of geolocation permission request
1743         QtWebkit and set's when LayoutTestController gets the access from test JS
1744
1745         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1746         (WebCore::WebPage::WebPage):
1747         (WebCore::WebPage::resetSettings):
1748         (WebCore::WebPage::requestPermission):
1749         (WebCore::WebPage::cancelPermission):
1750         (WebCore::WebPage::permissionSet):
1751         (WebCore::DumpRenderTree::DumpRenderTree):
1752         (WebCore::DumpRenderTree::processLine):
1753         (WebCore::DumpRenderTree::geolocationPermissionSet):
1754         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1755         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1756         (LayoutTestController::reset):
1757         (LayoutTestController::setGeolocationPermission):
1758         (LayoutTestController::setGeolocationPermissionCommon):
1759         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1760
1761 2010-09-01  Andras Becsi  <abecsi@webkit.org>
1762
1763         Reviewed by Antti Koivisto.
1764
1765         [Qt] Auto-generate WebKit2 forwarding headers
1766         https://bugs.webkit.org/show_bug.cgi?id=44692
1767
1768         * MiniBrowser/qt/BrowserWindow.h: use source style includes
1769         * MiniBrowser/qt/MiniBrowser.pro: add missing include paths
1770         * Scripts/enumerate-included-framework-headers: Removed.
1771
1772 2010-08-31  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
1773
1774         Reviewed by Adam Barth.
1775
1776         Allow Ctrl+C inside Bugzilla::fetch_bug_dictionary
1777         https://bugs.webkit.org/show_bug.cgi?id=44789
1778
1779         * Scripts/webkitpy/common/net/bugzilla.py:
1780
1781 2010-08-31  Leandro Pereira  <leandro@profusion.mobi>
1782
1783         Reviewed by Adam Barth.
1784
1785         ews: Add support for EFL-EWS
1786         https://bugs.webkit.org/show_bug.cgi?id=44982
1787
1788         * QueueStatusServer/model/queues.py: Add "efl-ews" to queues list.
1789         * Scripts/webkitpy/common/config/ports.py: Define a EflPort class
1790         and add it to the ports dict.
1791         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: Define a
1792         EflEWS class.
1793         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: Add
1794         a test case for the EFL EWS.
1795
1796 2010-08-31  Alexey Proskuryakov  <ap@apple.com>
1797
1798         Reviewed by Sam Weinig.
1799
1800         https://bugs.webkit.org/show_bug.cgi?id=42195
1801         <rdar://problem/8186761> WebKitTestRunner needs to support layoutTestController.setXSSAuditorEnabled
1802
1803         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1804         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setXSSAuditorEnabled):
1805         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1806         Added setXSSAuditorEnabled, calling through to an WKBundle private method. Calling this method
1807         makes WebProcess use a different value for this preference than UIProcess thinks it uses.
1808
1809         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
1810         Reset xssAuditorEnabled. Even though the value doesn't change, this calls through to WebProcess,
1811         which forgets its override.
1812
1813 2010-08-31  Sam Weinig  <sam@webkit.org>
1814
1815         Reviewed by Gavin Barraclough.
1816
1817         WebKitTestRunner needs layoutTestController.addUserStyleSheet
1818         https://bugs.webkit.org/show_bug.cgi?id=42680
1819
1820         WebKitTestRunner needs layoutTestController.addUserScript
1821         https://bugs.webkit.org/show_bug.cgi?id=42681
1822
1823         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1824         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1825         (WTR::InjectedBundle::beginTesting):
1826         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1827         (WTR::LayoutTestController::addUserScript):
1828         (WTR::LayoutTestController::addUserStyleSheet):
1829         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1830
1831 2010-08-31  Dirk Pranke  <dpranke@chromium.org>
1832
1833         Unreviewed, rolling out r66542.
1834         http://trac.webkit.org/changeset/66542
1835         https://bugs.webkit.org/show_bug.cgi?id=44902
1836
1837         r66542 - the weird logging dependencies in Python stuck again ...
1838
1839         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Removed.
1840         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Removed.
1841         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Removed.
1842         * Scripts/webkitpy/layout_tests/data/passes/error.html: Removed.
1843         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
1844         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1845         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1846         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1847         * Scripts/webkitpy/layout_tests/port/base.py:
1848         * Scripts/webkitpy/layout_tests/port/test.py:
1849         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1850         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1851
1852 2010-08-31  Dumitru Daniliuc  <dumi@chromium.org>
1853
1854         Reviewed by Tony Chang.
1855
1856         Implementing LayoutTestController::markerTextForListItem() in Chromium's DRT.
1857
1858         * DumpRenderTree/chromium/LayoutTestController.cpp:
1859         (LayoutTestController::LayoutTestController):
1860         (LayoutTestController::markerTextForListItem):
1861         * DumpRenderTree/chromium/LayoutTestController.h:
1862
1863 2010-08-31  Dirk Pranke  <dpranke@chromium.org>
1864
1865         Reviewed by Ojan Vafai.
1866
1867         new-run-webkit-tests: add more unit tests
1868
1869         Add more unit tests for new-run-webkit-tests; we now cover all but
1870         the most obscure code paths in the generic code. We still need to
1871         add coverage for the http server and web socket paths, and add better
1872         coverage of the platform-specific logic. Note that the rebaselining
1873         tool is still not well tested.
1874
1875         Also clean up some of the configuration logic for the printing
1876         module and the way it interacts with the Python logging module; that
1877         is a crufty interface, to be certain.
1878         
1879         https://bugs.webkit.org/show_bug.cgi?id=44902
1880
1881         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Added.
1882         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Added.
1883         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Added.
1884         * Scripts/webkitpy/layout_tests/data/passes/error.html: Added.
1885         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
1886         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1887         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1888         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1889         * Scripts/webkitpy/layout_tests/port/base.py:
1890         * Scripts/webkitpy/layout_tests/port/test.py:
1891         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1892         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1893
1894 2010-08-31  Darin Adler  <darin@apple.com>
1895
1896         Reviewed by Anders Carlsson.
1897
1898         * Scripts/check-for-global-initializers: Add a file that ends up having global initializers
1899         in a debug build when built with certain compilers.
1900
1901 2010-08-31  Martin Robinson  <mrobinson@igalia.com>
1902
1903         Reviewed by Gustavo Noronha Silva.
1904
1905         [GTK] Isolate all GTK+ typedefs into one file
1906         https://bugs.webkit.org/show_bug.cgi?id=44900
1907
1908         * DumpRenderTree/gtk/EventSender.h: Remove GTK+ typedefs.
1909
1910 2010-08-31  Eric Seidel  <eric@webkit.org>
1911
1912         Reviewed by Adam Barth.
1913
1914         Show more status on queue status pages
1915         https://bugs.webkit.org/show_bug.cgi?id=44938
1916
1917         I upped the number of status lines from 6 to 15 --
1918         this has been bugging me for a while...
1919
1920         I also disabled showing the chromium-win EWS queue
1921         since it's been down for almost 5 months now.
1922
1923         * QueueStatusServer/handlers/dashboard.py:
1924         * QueueStatusServer/handlers/queuestatus.py:
1925         * QueueStatusServer/model/queues.py:
1926
1927 2010-08-31  Zoltan Horvath  <zoltan@webkit.org>
1928
1929         Reviewed by Antonio Gomes.
1930
1931         [Qt] Read command line arguments and open them as URLs in new windows
1932         https://bugs.webkit.org/show_bug.cgi?id=44944
1933
1934         Extend MiniBrowser to accept command line arguments and open them as URLs in new browser windows.
1935
1936         * MiniBrowser/qt/main.cpp:
1937         (main):
1938
1939 2010-08-31  Adrian Perez  <aperez@igalia.com>
1940
1941         Reviewed by Martin Robinson.
1942
1943         Support scripts to run Buildbot slaves under daemontools (gtk related)
1944         https://bugs.webkit.org/show_bug.cgi?id=40053
1945
1946         * BuildSlaveSupport/gtk: Added.
1947         * BuildSlaveSupport/gtk/README: Added.
1948         * BuildSlaveSupport/gtk/buildbot: Added.
1949         * BuildSlaveSupport/gtk/buildbot/log: Added.
1950         * BuildSlaveSupport/gtk/buildbot/log/run: Added.
1951         * BuildSlaveSupport/gtk/buildbot/run: Added.
1952         * BuildSlaveSupport/gtk/crashmon: Added.
1953         * BuildSlaveSupport/gtk/crashmon/crashmon: Added.
1954         * BuildSlaveSupport/gtk/crashmon/log: Added.
1955         * BuildSlaveSupport/gtk/crashmon/log/run: Added.
1956         * BuildSlaveSupport/gtk/crashmon/run: Added.
1957         * BuildSlaveSupport/gtk/daemontools-buildbot.conf: Added.
1958         * BuildSlaveSupport/gtk/pulseaudio: Added.
1959         * BuildSlaveSupport/gtk/pulseaudio/run: Added.
1960         * BuildSlaveSupport/gtk/xvfb: Added.
1961         * BuildSlaveSupport/gtk/xvfb/log: Added.
1962         * BuildSlaveSupport/gtk/xvfb/log/run: Added.
1963         * BuildSlaveSupport/gtk/xvfb/run: Added.
1964
1965 2010-08-27  John Gregg  <johnnyg@google.com>
1966
1967         Reviewed by David Levin.
1968
1969         Notifications should support a click event.
1970         Adds necessary hooks to chromium's DRT so that clicks on desktop notifications
1971         can be simulated during a layout test.  Requires storing a list of active
1972         notifications so that they can be referred to later for clicking.
1973         https://bugs.webkit.org/show_bug.cgi?id=44800
1974
1975         * DumpRenderTree/chromium/LayoutTestController.cpp:
1976         (LayoutTestController::LayoutTestController):
1977         (LayoutTestController::simulateDesktopNotificationClick):
1978         * DumpRenderTree/chromium/LayoutTestController.h:
1979         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1980         (NotificationPresenter::simulateClick):
1981         (NotificationPresenter::show):
1982         (NotificationPresenter::cancel):
1983         (NotificationPresenter::objectDestroyed):
1984         * DumpRenderTree/chromium/NotificationPresenter.h:
1985
1986 2010-08-30  Alice Liu  <alice.liu@apple.com>
1987
1988         Reviewed by Darin Adler.
1989
1990         Add missing parts of didFinishDocumentLoadForFrame
1991         https://bugs.webkit.org/show_bug.cgi?id=44913
1992
1993         * MiniBrowser/mac/BrowserWindowController.m:
1994         (didFinishDocumentLoadForFrame): Added
1995         (-[BrowserWindowController awakeFromNib]): Updated struct
1996         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1997         (WTR::InjectedBundlePage::InjectedBundlePage): Rearranged function ptr
1998         * WebKitTestRunner/TestController.cpp:
1999         (WTR::TestController::initialize): Updated struct
2000
2001 2010-08-30  Vangelis Kokkevis  <vangelis@chromium.org>
2002
2003         Unreviewed: Add myself to the list of Committers.
2004
2005         * Scripts/webkitpy/common/config/committers.py:
2006
2007 2010-08-30  Kent Tamura  <tkent@chromium.org>
2008
2009         Reviewed by Adam Barth.
2010
2011         Fix fast/notifications/notifications-display-close-events.html failure
2012         https://bugs.webkit.org/show_bug.cgi?id=44585
2013
2014         Apply http://crrev.com/48893. We should dispatch display events
2015         asynchronously.
2016
2017         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2018         (deferredDisplayDispatch):
2019         (NotificationPresenter::show):
2020
2021 2010-08-30  Robert Hogan  <robert@webkit.org>
2022
2023         Reviewed by Simon Hausmann.
2024
2025         allow ports with windowed plugins to support windowless plugin tests
2026
2027         https://bugs.webkit.org/show_bug.cgi?id=40730
2028
2029         Ports that implement plugins windowed by default need to have a way of
2030         supporting plugin tests that assume the plugin is windowless. Add this
2031         feature to the tests and support it in the webkit test plugin. Also
2032         add mouse and keyboard event logging to the webkit-test plugin on Unix.
2033
2034         Unskip the following tests on Qt:
2035
2036         plugins/mouse-events.html
2037         plugins/keyboard-events.html
2038         plugins/mouse-events-fixedpos.html
2039
2040         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2041         (pluginSetProperty):
2042         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2043         (NPP_New):
2044         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2045         (webkit_test_plugin_handle_event):
2046
2047 2010-08-30  Kevin Ollivier  <kevino@theolliviers.com>
2048
2049         [wx] Build fix after addition of fileapi directory in WebCore.
2050
2051         * wx/build/settings.py:
2052
2053 2010-08-30  Alejandro G. Castro  <alex@igalia.com>
2054
2055         Reviewed by Xan Lopez.
2056
2057         Fixed compilation error, now that we have included the
2058         GtkVersioning.h we have to remove some version dependent code from
2059         EventSender.
2060
2061         * DumpRenderTree/gtk/EventSender.cpp:
2062
2063 2010-08-30  Alejandro G. Castro  <alex@igalia.com>
2064
2065         Reviewed by Martin Robinson.
2066
2067         [Gtk] gdk_display_get_core_pointer and gdk_device_get_core_pointer
2068         are deprecated
2069         https://bugs.webkit.org/show_bug.cgi?id=44787
2070
2071         We have replaced GtkVersioning.cpp with GtkVersioning.c and
2072         created a function (getDefaultGDKPointerDevice) to get the pointer
2073         of the window with the new APIs. We added that function to DRT and
2074         copyandpaste unit test.
2075
2076         * DumpRenderTree/gtk/EventSender.cpp:
2077         (prepareMouseButtonEvent):
2078         (mouseMoveToCallback):
2079         (keyDownCallback):
2080         * GNUmakefile.am:
2081
2082 2010-08-30  Zoltan Horvath  <zoltan@webkit.org>
2083
2084         Reviewed by Kenneth Rohde Christiansen.
2085
2086         [Qt] Add new window menu to MiniBrowser
2087
2088         Implement newWindow function and add a menu item for opening new window in MiniBrowser.
2089
2090         * MiniBrowser/qt/BrowserWindow.cpp:
2091         (BrowserWindow::BrowserWindow):
2092         (BrowserWindow::newWindow):
2093         * MiniBrowser/qt/BrowserWindow.h:
2094         * MiniBrowser/qt/main.cpp:
2095         (main):
2096
2097 2010-08-29  James Robinson  <jamesr@chromium.org>
2098
2099         Reviewed by David Levin.
2100
2101         Make failing the download step fail the build
2102         https://bugs.webkit.org/show_bug.cgi?id=44298
2103
2104         If the download step fails on a test bot, this ensures that
2105         the build goes red instead of only the download step going red
2106         and the overall build staying green.
2107
2108         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2109
2110 2010-08-29  Kent Tamura  <tkent@chromium.org>
2111
2112         Reviewed by Dimitri Glazkov.
2113
2114         [DRT/Chromium] Remove dependency to base/keyboard_codes.h
2115         https://bugs.webkit.org/show_bug.cgi?id=44847
2116
2117         * DumpRenderTree/chromium/EventSender.cpp:
2118          Use webkit_support::VKEY_* instead of base::VKEY_*.
2119
2120 2010-08-29  Darin Adler  <darin@apple.com>
2121
2122         https://bugs.webkit.org/show_bug.cgi?id=40589
2123
2124         * Scripts/prepare-ChangeLog: Only prepend namespaces to non-empty
2125         function names.
2126
2127 2010-08-26  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
2128
2129         Reviewed by Darin Adler.
2130
2131         [iExploder] Add new CSS Properties and HTML Attributes
2132         https://bugs.webkit.org/show_bug.cgi?id=44746
2133
2134         Updated the files with the update-iexploder-cssproperties script
2135         and manually readded the -webkit-binding CSS Property to the list.
2136
2137         * iExploder/htdocs/cssproperties.in:
2138         * iExploder/htdocs/htmlattrs.in:
2139         * iExploder/htdocs/htmltags.in:
2140
2141 2010-08-26  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
2142
2143         Reviewed by Darin Adler.
2144
2145         Fix Coverage build after the addition of ANGLE
2146         https://bugs.webkit.org/show_bug.cgi?id=44744
2147
2148         ANGLE is using libtool to build a static library and the version of
2149         libtool on Leopard refuses to handle the -fprofile-arcs and -ftest-coverage
2150         parameters. The easiest way to handle this is to not build ANGLE with
2151         coverage information.
2152
2153         This is achieved by applying the XCode options for each project
2154         separately and exclude ANGLE.
2155
2156         * Scripts/build-webkit: Remove -framework AppKit due link errors.
2157         * Scripts/webkitdirs.pm: Do not apply the XCode options for ANGLE.
2158
2159 2010-08-28  Kevin Ollivier  <kevino@theolliviers.com>
2160
2161         [wx] Build fix after directory addition.
2162
2163         * wx/build/settings.py:
2164
2165 2010-08-28  Chris Guillory   <chris.guillory@google.com>
2166
2167         Reviewed by Chris Fleizach.
2168
2169         Add AX notification for childrenChanged
2170         https://bugs.webkit.org/show_bug.cgi?id=44472
2171
2172         * DumpRenderTree/chromium/AccessibilityController.cpp:
2173         (AccessibilityController::AccessibilityController):
2174         (AccessibilityController::reset):
2175         (AccessibilityController::getRootElement):
2176         (AccessibilityController::dumpAccessibilityNotifications):
2177         * DumpRenderTree/chromium/AccessibilityController.h:
2178         (AccessibilityController::shouldDumpAccessibilityNotifications):
2179         * DumpRenderTree/chromium/WebViewHost.cpp:
2180         (WebViewHost::didChangeAccessibilityObjectChildren):
2181         * DumpRenderTree/chromium/WebViewHost.h:
2182
2183 2010-08-28  Eric Seidel  <eric@webkit.org>
2184
2185         Reviewed by Adam Barth.
2186
2187         Update commit-queue failure message
2188         https://bugs.webkit.org/show_bug.cgi?id=44798
2189
2190         The commit-queue auto-restarts itself and has for a very long time.
2191         No need for people to email me to request a restart anymore.
2192
2193         * Scripts/webkitpy/common/net/bugzilla.py:
2194         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
2195         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2196
2197 2010-07-27  Jer Noble  <jer.noble@apple.com>
2198
2199         Reviewed by Eric Carlson.
2200
2201         Add JavaScript API to allow a page to go fullscreen.
2202         rdar://problem/6867795
2203         
2204         Added basic full screen support to DumpRenderTree: when a webView requests
2205         that DumpRenderTree go "full screen", just call the provided callback listener object's
2206         will/did Enter/Exit full screen methods.  Also, register a new user default which 
2207         enables full screen support.
2208
2209         * DumpRenderTree/mac/DumpRenderTree.mm:
2210         (resetDefaultsToConsistentValues):
2211         * DumpRenderTree/mac/UIDelegate.mm:
2212         (-[UIDelegate webView:supportsFullscreenForElement:]):
2213         (-[UIDelegate webView:enterFullscreenForElement:listener:]):
2214         (-[UIDelegate webView:exitFullscreenForElement:listener:]):
2215
2216 2010-08-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
2217
2218         Unreviewed. Add myself to the committers list.
2219
2220         * Scripts/webkitpy/common/config/committers.py:
2221
2222 2010-08-27  Kent Tamura  <tkent@chromium.org>
2223
2224         Reviewed by Pavel Feldman.
2225
2226         [DRT/Chromium] Fix inspector test failures
2227         https://bugs.webkit.org/show_bug.cgi?id=44748
2228
2229         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2230         (DRTDevToolsAgent::createClientMessageLoop):
2231           Returns a valid WebKitClientMessageLoop instance
2232         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2233
2234 2010-08-26  Jon Honeycutt  <jhoneycutt@apple.com>
2235
2236         Add Windows WebKit2 Tester to buildbot
2237         <rdar://problem/7887703>
2238
2239         Reviewed by Dan Bernstein.
2240
2241         * BuildSlaveSupport/build.webkit.org-config/config.json:
2242
2243 2010-08-26  Philippe Normand  <pnormand@igalia.com>
2244
2245         Reviewed by Martin Robinson.
2246
2247         [GTK] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
2248         https://bugs.webkit.org/show_bug.cgi?id=42152
2249
2250         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
2251         (LoadHTMLStringItem::invoke): Implementation using
2252         webkit_web_frame_load_string().
2253
2254 2010-08-25  Jon Honeycutt  <jhoneycutt@apple.com>
2255
2256         <rdar://problem/8334338> run-webkit-tests sometimes hangs when using
2257         WebKitTestRunner (44331)
2258
2259         Reviewed by Darin Adler.
2260
2261         * WebKitTestRunner/TestController.cpp:
2262         (WTR::TestController::initialize):
2263         The hang occurs when WebKitTestRunner begins launching the WebKit2
2264         web process then exits before it finishes launching. Work around this by
2265         looking for the --print-supported-features argument and exiting without
2266         creating the web process.
2267
2268 2010-08-26  Dirk Pranke  <dpranke@chromium.org>
2269
2270         Reviewed by Tony Chang.
2271
2272         new-run-webkit-tests: add rebaselining tests for test_expectations
2273         
2274         This patch adds more unit tests for the rebaselining code in the
2275         test_expectations module. It doesn't add any tests for
2276         rebaseline_chromium_webkit_tests itself; that will come some other
2277         time.
2278
2279         https://bugs.webkit.org/show_bug.cgi?id=44648
2280
2281         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2282         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2283
2284 2010-08-26  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2285
2286         Reviewed by Martin Robinson.
2287
2288         [GTK] Add HTTP caching support
2289         https://bugs.webkit.org/show_bug.cgi?id=44261
2290
2291         Ignore new soup API that we decided to merge into the soup backend
2292         while it is being cooked. It follows the libsoup style, and will
2293         be removed from WebKit as soon as it is merged into libsoup.
2294
2295         * Scripts/webkitpy/style/checker.py:
2296
2297 2010-08-26  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2298
2299         Reviewed by Kenneth Rohde Christiansen.
2300
2301         [Qt] DumpRenderTree runs only one test from command mode
2302         https://bugs.webkit.org/show_bug.cgi?id=44012
2303
2304         Enables support to run multiple test files and single
2305         folder containing html files in stand alone mode
2306
2307         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2308         (WebCore::DumpRenderTree::DumpRenderTree):
2309         (WebCore::DumpRenderTree::processArgsLine):
2310         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
2311         (WebCore::DumpRenderTree::processLine):
2312         (WebCore::DumpRenderTree::dump):
2313         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2314         (WebCore::DumpRenderTree::setStandAloneMode):
2315         (WebCore::DumpRenderTree::isStandAloneMode):
2316         * DumpRenderTree/qt/main.cpp:
2317         (main):
2318
2319 2010-08-25  Martin Robinson  <mrobinson@igalia.com>
2320
2321         Updating webkitpy test expectations.
2322
2323         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2324
2325 2010-08-25  Ojan Vafai  <ojan@chromium.org>
2326
2327         Reviewed by Eric Seidel.
2328
2329         fix the always squash git config
2330         https://bugs.webkit.org/show_bug.cgi?id=44651
2331
2332         Fix help text and apparently underscores are not allowed
2333         in git config keys.
2334
2335         * Scripts/webkitpy/common/checkout/scm.py:
2336         * Scripts/webkitpy/tool/steps/commit.py:
2337
2338 2010-08-25  Darin Adler  <darin@apple.com>
2339
2340         Reviewed by John Sullivan.
2341
2342         * Scripts/commit-log-editor: Fix perl warning for people who have no
2343         value for SVN_LOG_EDITOR or CVS_LOG_EDITOR.
2344
2345 2010-08-25  Ojan Vafai  <ojan@chromium.org>
2346
2347         Reviewed by Eric Seidel.
2348
2349         stop blocking commits when the bots are red
2350         https://bugs.webkit.org/show_bug.cgi?id=44644
2351
2352         This check currently is just annoying. It doesn't actually
2353         help keep the tree green. We can always add it back later
2354         if we decide the tree is generally more green.
2355
2356         * Scripts/webkitpy/tool/commands/download_unittest.py:
2357         * Scripts/webkitpy/tool/mocktool.py:
2358         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
2359
2360 2010-08-25  Eric Seidel  <eric@webkit.org>
2361
2362         Reviewed by Simon Fraser.
2363
2364         REGRESSION: media/video-loop.html is timing out on the commit-queue Leopard Bot
2365         https://bugs.webkit.org/show_bug.cgi?id=38912
2366
2367         I know of nothing else to do but skip all media tests for the cq.
2368
2369         * Scripts/webkitpy/tool/steps/runtests.py:
2370
2371 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
2372
2373         Reviewed by Ojan Vafai.
2374
2375         new-run-webkit-tests: add more unit tests for test_expectations
2376         This adds unit tests to cover (almost?) all of the non-rebaselining
2377         functionality.
2378
2379         https://bugs.webkit.org/show_bug.cgi?id=44579
2380
2381         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2382         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2383
2384 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
2385
2386         Reviewed by Ojan Vafai.
2387
2388         new-run-webkit-tests: add more unit tests
2389
2390         This change adds more unit tests for the image_diff, test_failures,
2391         and test_files modules, bringing them to 100% coverage (and adds a
2392         couple tests to run_webkit_tests while we're at it).
2393
2394         This test also turns on the "dryrun" port for testing when run on
2395         the mac, increasing coverage in a few other places.
2396
2397         https://bugs.webkit.org/show_bug.cgi?id=44578
2398
2399         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.checksum: Added.
2400         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.png: Added.
2401         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.txt: Added.
2402         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html.
2403         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.png: Added.
2404         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.txt: Added.
2405         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html.
2406         * Scripts/webkitpy/layout_tests/data/failures/expected/timeout.html: Added.
2407         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
2408         * Scripts/webkitpy/layout_tests/data/resources/README.txt: Added.
2409         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
2410         * Scripts/webkitpy/layout_tests/port/test.py:
2411         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2412
2413 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
2414
2415         Reviewed by Ojan Vafai.
2416
2417         new-run-webkit-tests: add more unit tests for layout_package/printing.py
2418
2419         This change adds more unit tests to get the test coverage to 100%
2420         for the printing module. This code is actually pretty crufty and
2421         has some layering violations that need to be cleaned up but I'll
2422         save that for another CL after we get all the unit tests written and
2423         we fix the multithreading issues. At least now we'll be able to tell
2424         if we break things.
2425
2426         https://bugs.webkit.org/show_bug.cgi?id=44576
2427
2428         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2429         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2430
2431 2010-08-25  Ojan Vafai  <ojan@chromium.org>
2432
2433         Reviewed by Adam Barth.
2434
2435         new-run-webkit-tests should respect set-webkit-configuration
2436         https://bugs.webkit.org/show_bug.cgi?id=44633
2437
2438         Moves the getting of the configuration into the base Port so that
2439         chromium ports use it as well. In the downstream chromium port,
2440         this should still just return Release.
2441
2442         * Scripts/webkitpy/layout_tests/port/base.py:
2443         * Scripts/webkitpy/layout_tests/port/webkit.py:
2444
2445 2010-08-25  Tony Chang  <tony@chromium.org>
2446
2447         Not reviewed, changing svn props for a script.
2448
2449         * Scripts/deduplicate-tests: Added properties svn:executable and svn:eol-style.
2450
2451 2010-08-25  Adam Barth  <abarth@webkit.org>
2452
2453         Reviewed by Eric Seidel.
2454
2455         Remove WebKit2 from core builders
2456         https://bugs.webkit.org/show_bug.cgi?id=44625
2457
2458         This builder was added to the core builders by accident.  It doesn't
2459         appear to be green enough to be a core builder yet.
2460
2461         * Scripts/webkitpy/common/net/buildbot.py:
2462         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2463
2464 2010-08-19  Adam Roben  <aroben@apple.com>
2465
2466         Test that NP_Initialize and NP_GetEntryPoints are called in the
2467         correct order
2468
2469         The order differs between Mac and Windows (see r38858).
2470
2471         Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in
2472         NP_Initialize when loading QuickTime when running
2473         plugins/embed-attributes-setting.html in WebKit2 on Windows
2474
2475         Reviewed by John Sullivan.
2476
2477         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and
2478         a boolean to record whether NP_GetEntryPoints has been called.
2479         (NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been
2480         called yet. This matches Flash and QuickTime's behavior.
2481         (NP_GetEntryPoints): Crash on Mac if NP_Initialize hasn't been called
2482         yet. This matches Silverlight's behavior.
2483
2484 2010-08-25  Martin Robinson  <mrobinson@igalia.com>
2485
2486         Reviewed by Gustavo Noronha Silva.
2487
2488         Cairo and EFL port shouldn't depend on glib.
2489         https://bugs.webkit.org/show_bug.cgi?id=44354
2490
2491         Replace occurrences of GRefPtr and adoptGRef with PlatformRefPtr and
2492         adoptPlatformRef.
2493
2494         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2495         (AccessibilityUIElement::isSelected):
2496
2497 2010-08-25  Ojan Vafai  <ojan@chromium.org>
2498
2499         Fix order of Timothy's email address. The script, and
2500         other tools all assume that the first email is the bugzilla address.
2501
2502         * Scripts/webkitpy/common/config/committers.py:
2503
2504 2010-08-24  Kent Tamura  <tkent@chromium.org>
2505
2506         Reviewed by Pavel Feldman.
2507
2508         [DRT/Chromium] Fix 26 inspector test crashes
2509         https://bugs.webkit.org/show_bug.cgi?id=44580
2510
2511         - DRTDevToolsAgent has a reference to the main WebView. So we
2512           should not clear it in closeDevTools() and should clear it in
2513           ~TestShell().
2514         - DRTDevToolsClient has a reference to a DevTools WebView and no
2515           way to update it. So we should delete DRTDevToolsClient instances
2516           in closeDevTools().
2517
2518         * DumpRenderTree/chromium/TestShell.cpp:
2519         (TestShell::~TestShell):
2520         (TestShell::closeDevTools):
2521
2522 2010-08-24  Eric Seidel  <eric@webkit.org>
2523
2524         Reviewed by Adam Barth.
2525
2526         unicode(Exception(\u"0x1234")) is busted in python 2.5, disable tests which hit this
2527         https://bugs.webkit.org/show_bug.cgi?id=44584
2528
2529         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2530
2531 2010-08-24  Eric Seidel  <eric@webkit.org>
2532
2533         Reviewed by Adam Barth.
2534
2535         commit-queue and EWS bots should report all failures
2536         https://bugs.webkit.org/show_bug.cgi?id=41820
2537
2538         Right now commit-queue/EWS only report failures when the
2539         patch under testing fails.  We should report all failures
2540         to the status server so that we can diagnose when the bots
2541         are wedged w/o needing to log into the machines.
2542
2543         I also reduced the amount of data we upload since we've seen
2544         timeouts during status upload.
2545
2546         * Scripts/webkitpy/common/system/executive.py:
2547         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2548         * Scripts/webkitpy/tool/commands/queues.py:
2549         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2550
2551 2010-08-24  Eric Seidel  <eric@webkit.org>
2552
2553         Reviewed by Adam Barth.
2554
2555         Remove HTML5 parser testing infrastructure now that we don't need it
2556         https://bugs.webkit.org/show_bug.cgi?id=44581
2557
2558         * DumpRenderTree/mac/DumpRenderTree.mm:
2559         (resetDefaultsToConsistentValues):
2560         (initializeGlobalsFromCommandLineOptions):
2561         * Scripts/old-run-webkit-tests:
2562         * Scripts/test-html5-parser: Removed.
2563
2564 2010-08-24  Kent Tamura  <tkent@chromium.org>
2565
2566         Reviewed by Dimitri Glazkov.
2567
2568         [DRT/Chromium] Fix 28 inspector test crashes
2569         https://bugs.webkit.org/show_bug.cgi?id=44574
2570
2571         Reset DevToolsClient and DevToolsAgent before closing a DevTools
2572         WebView in order to avoid accessing to a deleted WebView instance.
2573
2574         * DumpRenderTree/chromium/TestShell.cpp:
2575         (TestShell::closeDevTools):
2576
2577 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
2578
2579         Reviewed by Ojan Vafai.
2580
2581         new-run-webkit-tests: clean up code for test_types, test_failures
2582
2583         Add a bunch of unit tests for webkitpy.layout_tests.test_types and
2584         webkitpy.layout_tests.layout_package.test_failures, and remove
2585         some dead code and otherwise clean up things.
2586
2587         https://bugs.webkit.org/show_bug.cgi?id=44559
2588
2589         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2590         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py: Added.
2591         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2592         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2593         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2594         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: Added.
2595         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2596
2597 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
2598
2599         Reviewed by Eric Seidel.
2600
2601         new-run-webkit-tests: revise unit testing strategy for test failures
2602     
2603         This change revamps the way we store test data for new-run-webkit-tests.
2604         Previously we had a few copies of test files from the main test tree.
2605         Now we have a bunch of completely fake test data and use the test
2606         data to generate different kinds of test failures, getting
2607         much better coverage.
2608
2609         https://bugs.webkit.org/show_bug.cgi?id=44556
2610
2611         * Scripts/webkitpy/layout_tests/data/failures/expected/crash.html: Added.
2612         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.checksum: Added.
2613         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.png: Added.
2614         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.txt: Added.
2615         * Scripts/webkitpy/layout_tests/data/failures/expected/image.html: Added.
2616         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.checksum: Added.
2617         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.png: Added.
2618         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.txt: Added.
2619         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html: Added.
2620         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html: Added.
2621         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_text.html: Added.
2622         * Scripts/webkitpy/layout_tests/data/failures/expected/text-expected.txt: Added.
2623         * Scripts/webkitpy/layout_tests/data/failures/expected/text.html: Added.
2624         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.checksum: Added.
2625         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.png: Added.
2626         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.txt: Added.
2627         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum.html: Added.
2628         * Scripts/webkitpy/layout_tests/data/image/canvas-bg.html: Removed.
2629         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.checksum: Removed.
2630         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.png: Removed.
2631         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.txt: Removed.
2632         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom.html: Removed.
2633         * Scripts/webkitpy/layout_tests/data/misc/crash-expected.txt: Removed.
2634         * Scripts/webkitpy/layout_tests/data/misc/crash.html: Removed.
2635         * Scripts/webkitpy/layout_tests/data/misc/missing-expectation.html: Removed.
2636         * Scripts/webkitpy/layout_tests/data/misc/passing-expected.txt: Removed.
2637         * Scripts/webkitpy/layout_tests/data/misc/passing.html: Removed.
2638         * Scripts/webkitpy/layout_tests/data/passes/image-expected.checksum: Added.
2639         * Scripts/webkitpy/layout_tests/data/passes/image-expected.png: Added.
2640         * Scripts/webkitpy/layout_tests/data/passes/image-expected.txt: Added.
2641         * Scripts/webkitpy/layout_tests/data/passes/image.html: Added.
2642         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.checksum: Added.
2643         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.png: Added.
2644         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.txt: Added.
2645         * Scripts/webkitpy/layout_tests/data/passes/platform_image.html: Added.
2646         * Scripts/webkitpy/layout_tests/data/passes/text-expected.txt: Added.
2647         * Scripts/webkitpy/layout_tests/data/passes/text.html: Added.
2648         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.checksum: Removed.
2649         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.png: Removed.
2650         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.txt: Removed.
2651         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.checksum: Added.
2652         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.png: Added.
2653         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.txt: Added.
2654         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
2655         * Scripts/webkitpy/layout_tests/data/text/article-element-expected.txt: Removed.
2656         * Scripts/webkitpy/layout_tests/data/text/article-element.html: Removed.
2657         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2658         * Scripts/webkitpy/layout_tests/port/test.py:
2659         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2660         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2661
2662 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
2663
2664         Reviewed by Eric Seidel.
2665
2666         speed up new-run-webkit-tests unit tests
2667
2668         Add a --no-record-results flag that turns off generating the JSON
2669         results file on every test run. Generating the file requires us to
2670         fetch the old results down from the bots, which can be slow. This
2671         flag is off by default.
2672     
2673         Reduce the sleep time in wait_for_threads_to_finish from 0.1s to 0.01s.
2674     
2675         These changes together shorten the test cycle from ~4.5s to ~1.5s
2676         - a 3x speedup.
2677
2678         https://bugs.webkit.org/show_bug.cgi?id=44553
2679
2680         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2681         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2682
2683 2010-08-24  Tony Chang  <tony@chromium.org>
2684
2685         Reviewed by Eric Seidel.
2686
2687         [chromium] fix the platform result fallback order on mac/win
2688         https://bugs.webkit.org/show_bug.cgi?id=44483
2689
2690         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2691
2692 2010-08-24  Xan Lopez  <xlopez@igalia.com>
2693
2694         Reviewed by Martin Robinson.
2695
2696         Set a device to the event struct when building with GTK+ 3.x, it's
2697         mandatory.
2698
2699         * DumpRenderTree/gtk/EventSender.cpp:
2700         (keyDownCallback):
2701
2702 2010-08-24  Martin Robinson  <mrobinson@igalia.com>
2703
2704         Reviewed by Xan Lopez.
2705
2706         [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
2707         https://bugs.webkit.org/show_bug.cgi?id=44534
2708
2709         Fix two double-frees introduced in my previous commit.
2710
2711         * DumpRenderTree/gtk/EventSender.cpp:
2712         (contextClickCallback): Copy the event before using it again.
2713         (keyDownCallback): Ditto.
2714
2715 2010-08-24  Martin Robinson  <mrobinson@igalia.com>
2716
2717         Reviewed by Xan Lopez.
2718
2719         [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
2720         https://bugs.webkit.org/show_bug.cgi?id=44534
2721
2722         * DumpRenderTree/gtk/EventSender.cpp:
2723         (prepareMouseButtonEvent): Use gdk_event_new and reference the reference the GdkWindow
2724         when setting it on the event. It is dereferenced by gdk_event_free(...).
2725         (contextClickCallback): Ditto.
2726         (mouseDownCallback): Ditto.
2727         (mouseUpCallback): Ditto.
2728         (mouseMoveToCallback): Ditto.
2729         (mouseWheelToCallback): Ditto.
2730         (sendOrQueueEvent): Take a GdkEvent* instead of a GdkEvent.
2731         (dispatchEvent): Ditto. Also free the event when we are done with it.
2732         (keyDownCallback): Use gdk_event_new and reference the GdkWindow.
2733
2734 2010-08-24  Andras Becsi  <abecsi@webkit.org>
2735
2736         [Qt] WebKit2 build fix.
2737
2738         * Scripts/enumerate-included-framework-headers:
2739         Remove stray global option form sed.
2740
2741 2010-08-24  Kent Tamura  <tkent@chromium.org>
2742
2743         Reviewed by Jeremy Orlow.
2744
2745         [DRT/Chromium] Support for IndexedDB tests
2746         https://bugs.webkit.org/show_bug.cgi?id=44490
2747
2748         * DumpRenderTree/chromium/TestShell.cpp:
2749         (TestShell::TestShell): Enable IndexedDB.
2750
2751 2010-08-23  Martin Robinson  <mrobinson@igalia.com>
2752
2753         Reviewed by Gustavo Noronha Silva.
2754
2755         [GTK] The 64-bit Release bot is showing crashes on tests that use mouse buttons
2756         https://bugs.webkit.org/show_bug.cgi?id=44465
2757
2758         Initialize the axes field of mouse button and motion events to null.
2759         This is the value that should be used for events originating from the
2760         mouse device.
2761
2762         * DumpRenderTree/gtk/EventSender.cpp:
2763         (prepareMouseButtonEvent): Initalize button event axes field to null.
2764         (mouseMoveToCallback): Initialize motion event axes field to null.
2765
2766 2010-08-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2767
2768         Unreviewed, rolling out r65703.
2769         http://trac.webkit.org/changeset/65703
2770         https://bugs.webkit.org/show_bug.cgi?id=44460
2771
2772         "Causing lots of crashes on Snow Leopard when running the
2773         layout tests" (Requested by eseidel2 on #webkit).
2774
2775         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2776         (NP_Initialize):
2777         (NP_GetEntryPoints):
2778
2779 2010-08-23  Jon Honeycutt  <jhoneycutt@apple.com>
2780
2781         Layout tests do not run when using WebKitTestRunner in a Debug build.
2782         https://bugs.webkit.org/show_bug.cgi?id=44409
2783
2784         Reviewed by Dan Bernstein.
2785
2786         * WebKitTestRunner/win/TestControllerWin.cpp:
2787         (WTR::TestController::initializeInjectedBundlePath):
2788         Use InjectedBundle_debug.dll when building Debug.
2789
2790 2010-08-23  Xan Lopez  <xlopez@igalia.com>
2791
2792         Reviewed by Martin Robinson.
2793
2794         [GTK] run-launcher fails if WebKitGTK+ compiled with GTK+-3.0 support
2795         https://bugs.webkit.org/show_bug.cgi?id=42026
2796
2797         If a GTK+ 3.x build is present return that as the library to use,
2798         otherwise fallback to the GTK+ 2.x build.
2799
2800         * Scripts/webkitdirs.pm:
2801
2802 2010-08-23  Balazs Kelemen  <kb@inf.u-szeged.hu>
2803
2804         Reviewed by Ariya Hidayat.
2805
2806         [Qt] Find needed forwarding headers for WebKit2 automatically
2807         https://bugs.webkit.org/show_bug.cgi?id=44336
2808
2809         * MiniBrowser/qt/BrowserWindow.cpp: Use normal (not framework style) includes here.
2810         The new script does not satisfy the needs of this file however using normal includes
2811         is generally better here.
2812         * MiniBrowser/qt/MiniBrowser.pro: Added include paths.
2813         * Scripts/enumerate-included-framework-headers: Enumerates headers included from the 
2814         given frameworks by files in the current directory (and subdirectories).
2815         In the future this needs to be rewritten in perl for being able to use on Windows.
2816
2817 2010-08-22  No'am Rosenthal  <noam.rosenthal@nokia.com>
2818
2819         Reviewed by Ariya Hidayat.
2820
2821         [Qt] Qt test browser: enable a QGLWidget viewport with a command line argument
2822         https://bugs.webkit.org/show_bug.cgi?id=43010
2823
2824         * QtTestBrowser/launcherwindow.cpp:
2825         (LauncherWindow::applyPrefs):
2826         * QtTestBrowser/main.cpp:
2827         (LauncherApplication::handleUserOptions):
2828
2829 2010-08-21  Sam Weinig  <sam@webkit.org>
2830
2831         Reviewed by Dan Bernstein.
2832
2833         Remove specialized retain/release functions in favor of a single one for WKTypeRefs
2834         https://bugs.webkit.org/show_bug.cgi?id=44386
2835
2836         * MiniBrowser/mac/AppDelegate.m:
2837         (didRecieveMessageFromInjectedBundle):
2838         (didNavigateWithNavigationData):
2839         (-[BrowserAppDelegate init]):
2840         (-[BrowserAppDelegate applicationWillTerminate:]):
2841         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
2842         (-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
2843         (-[BrowserStatisticsWindowController dealloc]):
2844         * MiniBrowser/mac/BrowserWindowController.m:
2845         (-[BrowserWindowController initWithPageNamespace:]):
2846         (-[BrowserWindowController fetch:]):
2847         (-[BrowserWindowController windowWillClose:]):
2848         (-[BrowserWindowController applicationTerminating]):
2849         (closePage):
2850         (runJavaScriptAlert):
2851         (runJavaScriptConfirm):
2852         (runJavaScriptPrompt):
2853         (-[BrowserWindowController updateProvisionalURLForFrame:]):
2854         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2855         (didClearWindowObjectForFrame):
2856         * MiniBrowser/win/BrowserView.cpp:
2857         (BrowserView::goToURL):
2858         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2859         (WTR::PlatformWebView::~PlatformWebView):
2860
2861 2010-08-20  Benjamin Poulain  <benjamin.poulain@nokia.com>
2862
2863         Reviewed by Kenneth Rohde Christiansen.
2864
2865         WebKit does not build with Python 2.3
2866         https://bugs.webkit.org/show_bug.cgi?id=44373
2867
2868         Replaced the function sorted() by a call to sort()
2869         on the entry list.
2870         The function sorted() has been added to Python 2.4.
2871         The function method sort() of List works with older
2872         versions of Python.
2873
2874         * Scripts/create-html-entity-table:
2875
2876 2010-08-20  Martin Robinson  <mrobinson@igalia.com>
2877
2878         Reviewed by Pavel Feldman.
2879
2880         Web Inspector: Inspector tests were disabled for GTK.
2881         https://bugs.webkit.org/show_bug.cgi?id=43977
2882
2883         * Scripts/old-run-webkit-tests: Set the WEBKIT_INSPECTOR_PATH to the appropriate
2884         path before running tests.
2885
2886 2010-08-20  Daniel Bates  <dbates@rim.com>
2887
2888         Reviewed by Eric Seidel.
2889
2890         svn-apply doesn't detect empty line with Windows line endings
2891         after property value
2892         https://bugs.webkit.org/show_bug.cgi?id=43981
2893
2894         Part 2 of 2
2895
2896         Add unit tests that were not landed in the first commit.
2897
2898         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
2899           - Added the following test cases:
2900             "SVN: binary file (isBinary true) using Windows line endings"
2901             "SVN: property diff, followed by file change diff using Windows line endings"
2902             "SVN: two consecutive property diffs using Windows line endings"
2903             "SVN: binary file with executable bit change usng Windows line endings"
2904             "SVN: binary file followed by property change on different file using Windows line endings"
2905             "SVN: binary file followed by file change on different file using Windows line endings"
2906             "SVN: file change diff with property change, followed by property change diff using Windows line endings"
2907             "SVN: file change diff with property change, followed by file change diff using Windows line endings"
2908         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
2909           - Added the following test cases:
2910             "add svn:executable, followed by empty line and start of next diff using Windows line endings"
2911             "add svn:executable, followed by empty line and start of next property diff using Windows line endings"
2912             "multi-line '+' change, followed by empty line and start of next diff using Windows line endings"
2913             "multi-line '+' change, followed by empty line and start of next property diff using Windows line endings"
2914             "add svn:executable, followed by empty line and start of binary patch using Windows line endings"
2915             "multi-line '+' change, followed by empty line and start of binary patch using Windows line endings"
2916             "multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings"
2917             "single-line '+' with trailing new line using Windows line endings"
2918             "single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings"
2919             "single-line '-' change with trailing new line, and single-line '+' change using Windows line endings"
2920             "multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
2921         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
2922           - Added the following test cases:
2923             "single-line '-' change followed by empty line with Windows line endings"
2924             "multi-line '+' change and start of binary patch with Windows line endings"
2925
2926 2010-08-20  Daniel Bates  <dbates@rim.com>
2927
2928         Reviewed by Eric Seidel.
2929
2930         svn-apply doesn't detect empty line with Windows line endings
2931         after property value
2932         https://bugs.webkit.org/show_bug.cgi?id=43981
2933
2934         Fixes an issue where an empty line following the property value
2935         in an SVN property change diff would not be detected if it had
2936         Windows line endings (i.e. ended in CRLF). Hence it was consumed
2937         as if it was part of a multi-line property value. 
2938
2939         * Scripts/VCSUtils.pm:
2940           - Modified parseSvnPropertyValue() to detect empty line
2941             with Windows line endings.
2942           - Added toWindowsLineEndings().
2943         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
2944           - Added the following test cases:
2945             "SVN: binary file (isBinary true) using Windows line endings"
2946             "SVN: property diff, followed by file change diff using Windows line endings"
2947             "SVN: two consecutive property diffs using Windows line endings"
2948             "SVN: binary file with executable bit change usng Windows line endings"
2949             "SVN: binary file followed by property change on different file using Windows line endings"
2950             "SVN: binary file followed by file change on different file using Windows line endings"
2951             "SVN: file change diff with property change, followed by property change diff using Windows line endings"
2952             "SVN: file change diff with property change, followed by file change diff using Windows line endings"
2953         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
2954           - Added the following test cases:
2955             "add svn:executable, followed by empty line and start of next diff using Windows line endings"
2956             "add svn:executable, followed by empty line and start of next property diff using Windows line endings"
2957             "multi-line '+' change, followed by empty line and start of next diff using Windows line endings"
2958             "multi-line '+' change, followed by empty line and start of next property diff using Windows line endings"
2959             "add svn:executable, followed by empty line and start of binary patch using Windows line endings"
2960             "multi-line '+' change, followed by empty line and start of binary patch using Windows line endings"
2961             "multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings"
2962             "single-line '+' with trailing new line using Windows line endings"
2963             "single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings"
2964             "single-line '-' change with trailing new line, and single-line '+' change using Windows line endings"
2965             "multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
2966         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
2967           - Added the following test cases:
2968             "single-line '-' change followed by empty line with Windows line endings"
2969             "multi-line '+' change and start of binary patch with Windows line endings"
2970
2971 2010-08-19  David Kilzer  <ddkilzer@apple.com>
2972
2973         BUILD FIX: Fix Mac build after Windows WebKit2 changes for Netscape Plug-ins
2974
2975         * MiniBrowser/mac/BrowserWindowController.m:
2976         (decidePolicyForNavigationAction): Updated method signature.
2977         (decidePolicyForNewWindowAction): Updated method signature.
2978
2979 2010-08-19  Adam Roben  <aroben@apple.com>
2980
2981         Test that NP_Initialize and NP_GetEntryPoints are called in the
2982         correct order
2983
2984         The order differs between Mac and Windows (see r38858).
2985
2986         Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in
2987         NP_Initialize when loading QuickTime when running
2988         plugins/embed-attributes-setting.html in WebKit2 on Windows
2989
2990         Reviewed by Sam Weinig.
2991
2992         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and
2993         a boolean to record whether NP_GetEntryPoints has been called.
2994         (NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been
2995         called yet. This matches Flash and QuickTime's behavior. Crash on Mac
2996         if NP_GetEntryPoints has been called already. This matches
2997         Silverlight's behavior.
2998
2999 2010-08-19  Adam Roben  <aroben@apple.com>
3000
3001         Make build-webkittestrunner build TestNetscapePlugIn on Windows
3002
3003         Fixes <http://webkit.org/b/44268> <rdar://problem/8330388>
3004
3005         Reviewed by Sam Weinig.
3006
3007         * WebKitTestRunner/WebKitTestRunner.sln: Added TestNetscapePlugIn.
3008         Threaded it in between ImageDiff and InjectedBundleGenerated.
3009
3010 2010-08-19  Ojan Vafai  <ojan@chromium.org>
3011
3012         Reviewed by Adam Barth.
3013
3014         install rietveld's upload script from a versioned url
3015         https://bugs.webkit.org/show_bug.cgi?id=44291
3016
3017         autoinstall expects the file at a given URL to never change.
3018         In order to be able to update the file, we need to be able to
3019         change the path.
3020
3021         * Scripts/webkitpy/thirdparty/__init__.py:
3022
3023 2010-08-19  Ojan Vafai  <ojan@chromium.org>
3024
3025         Reviewed by Adam Barth.
3026
3027         add --webkit_patch_id to reitveld uploads
3028         https://bugs.webkit.org/show_bug.cgi?id=44289
3029
3030         This is the first step in having rietveld store which
3031         patches have been uploaded and getting rid of the
3032         in-rietveld flag.
3033
3034         * Scripts/webkitpy/common/net/rietveld.py:
3035         * Scripts/webkitpy/tool/mocktool.py:
3036         * Scripts/webkitpy/tool/steps/postcodereview.py:
3037
3038 2010-08-19  Kenneth Russell  <kbr@google.com>
3039
3040         Reviewed by David Levin.
3041
3042         Adjust my status from committer to reviewer
3043         https://bugs.webkit.org/show_bug.cgi?id=44277
3044
3045         * Scripts/webkitpy/common/config/committers.py:
3046
3047 2010-08-19  Pavel Feldman  <pfeldman@chromium.org>
3048
3049         Reviewed by Yury Semikhatsky.
3050
3051         Chromium DevTools: remove injected script fetcher from test harness.
3052         https://bugs.webkit.org/show_bug.cgi?id=44266
3053
3054         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
3055         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3056
3057 2010-08-19  Pavel Feldman  <pfeldman@chromium.org>
3058
3059         Reviewed by Yury Semikhatsky.
3060
3061         Chromium DevTools: There is no need in resource-based InjectedScript.js source.
3062         Now that we populate front-end after its onload handler, we don't need
3063         to install injected script early. Exposing injected script source on the WebCore
3064         level here.
3065         https://bugs.webkit.org/show_bug.cgi?id=44029
3066
3067         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
3068         (DRTDevToolsAgent::runtimePropertyChanged):
3069         (DRTDevToolsAgent::delayedFrontendLoaded):
3070         (DRTDevToolsAgent::frontendLoaded):
3071         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3072
3073 2010-08-19  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3074
3075         Reviewed by Kenneth Rohde Christiansen.
3076
3077         [Gtk] Enable view mode media feature layout test
3078         https://bugs.webkit.org/show_bug.cgi?id=43278
3079
3080         Add view mode media feature testing infrastructure, and add
3081         placeholder methods for the other platforms'
3082         LayoutTestControllers.
3083
3084         * DumpRenderTree/LayoutTestController.cpp:
3085         (setViewModeMediaFeatureCallback):
3086         (LayoutTestController::staticFunctions):
3087         * DumpRenderTree/LayoutTestController.h:
3088         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3089         (LayoutTestController::setViewModeMediaFeature):
3090         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3091         (LayoutTestController::setViewModeMediaFeature):
3092         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3093         (LayoutTestController::setViewModeMediaFeature):
3094         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3095         (LayoutTestController::setViewModeMediaFeature):
3096
3097 2010-08-18  Mark Rowe  <mrowe@apple.com>
3098
3099         Reviewed by Sam Weinig.
3100
3101         Make it so the WebKit2 test slave runs the WebKit2 tests
3102
3103         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3104
3105 2010-08-18  Sam Weinig  <sam@webkit.org>
3106
3107         Reviewed by Mark Rowe.
3108
3109         Make run-webkit-tests --webkit-test-runner build DumpRenderTree
3110         in addition to WebKitTestRunner to get the DumpRenderTreeSupport
3111         module and the TestNetscapePlugin.
3112
3113         * Scripts/old-run-webkit-tests:
3114
3115 2010-08-18  Adam Roben  <aroben@apple.com>
3116
3117         Fix hang when saving crash logs on Windows
3118
3119         * Scripts/old-run-webkit-tests:
3120         (setUpWindowsCrashLogSaving):
3121         (END):
3122         Pass -s to regtool so it will write the Auto value as a string instead
3123         of as a number. This was causing a "do you want to debug?" dialog to
3124         appear.
3125
3126 2010-08-17  Victor Wang  <victorw@chromium.org>
3127
3128         Unreviewed. Fixed chromium incremental test json upload.
3129         Quote builder name and test results server in url.
3130
3131         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3132
3133 2010-08-17  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3134
3135         Reviewed by Ariya Hidayat.
3136
3137         [Qt] [Symbian] Consistently use Q_OS_SYMBIAN to guard all Symbian platform dependencies
3138         https://bugs.webkit.org/show_bug.cgi?id=44124
3139
3140         Q_WS_S60 is not defined for Symbian^4 devices as Q_WS_S60 used to guard 
3141         Avkon UI framework dependencies. Use Q_OS_SYMBIAN everywhere to mark
3142         Symbian dependencies.
3143
3144         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3145         (WebCore::DumpRenderTree::open):
3146         * QtTestBrowser/launcherwindow.cpp:
3147         (LauncherWindow::init):
3148         (LauncherWindow::toggleFullScreenMode):
3149         (LauncherWindow::showFPS):
3150         (LauncherWindow::updateFPS):
3151         * QtTestBrowser/launcherwindow.h:
3152         (WindowOptions::WindowOptions):
3153         * QtTestBrowser/mainwindow.cpp:
3154         (MainWindow::buildUI):
3155
3156 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
3157
3158         Reviewed by David Levin.
3159
3160         new-run-webkit-tests: remove --show-sources option
3161
3162         --show-sources is pretty much obsolete with --trace everything, so
3163         I'm removing it.
3164
3165         Also rename a couple of methods in the TestTextDiff class to make their
3166         intended visibility (private) more obvious.
3167
3168         https://bugs.webkit.org/show_bug.cgi?id=44143
3169
3170         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3171         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3172         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
3173         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
3174         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3175
3176 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
3177
3178         Reviewed by David Levin.
3179
3180         remove --fuzzy-image-diff in new-run-webkit-tests (it doesn't work)
3181
3182         This code bit-rotted at some point more than a year ago, and nobody seems
3183         to miss it. old-run-webkit-tests has a --tolerance flag that new-run-webkit-tests
3184         should support instead, making this flag unnecessary anyway.
3185
3186         https://bugs.webkit.org/show_bug.cgi?id=44141
3187
3188         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3189         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3190         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Removed.
3191
3192 2010-08-17  Victor Wang  <victorw@chromium.org>
3193
3194         Reviewed by Ojan Vafai.
3195
3196         Update json results generator to have incremental json including
3197         results for tests that pass in current run but failed before.
3198
3199         https://bugs.webkit.org/show_bug.cgi?id=44119
3200
3201         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3202         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3203         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3204
3205 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
3206
3207         Reviewed by Eric Seidel.
3208
3209         fix test-webkitpy, add easy way to find a checkout root
3210
3211         test-webkitpy currently doesn't work right if run from someplace other
3212         than the checkout root, and it spews a bunch of debug logging because
3213         the deduplicate_tests tests contaminates the test environment.
3214
3215         This patch cleans up the deduplicate_tests unit tests, and creates
3216         two new methods in scm.py: find_checkout_root() and default_scm(),
3217         both of which use a single algorithm for guessing what checkout root
3218         to use if you aren't explicitly told one from a path.
3219
3220         https://bugs.webkit.org/show_bug.cgi?id=44001
3221
3222         * Scripts/deduplicate-tests:
3223         * Scripts/webkitpy/common/checkout/scm.py:
3224         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3225         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
3226         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3227         * Scripts/webkitpy/layout_tests/port/test.py:
3228         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3229         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
3230         * Scripts/webkitpy/tool/main.py:
3231
3232 2010-08-17  Victor Wang  <victorw@chromium.org>
3233
3234         Reviewed by Ojan Vafai.
3235
3236         Add support to the test results server for downloading json that
3237         contains test list only.
3238
3239         This is for json results generator to generate incremental json
3240         results so that it includes results not only for tests failed in
3241         current run, but also tests failed before.
3242
3243         Also set the results type to "N" (no data) instead of "P" (pass)
3244         if test results cannot be found in incremental json file.
3245
3246         https://bugs.webkit.org/show_bug.cgi?id=44117
3247
3248         * TestResultServer/handlers/testfilehandler.py:
3249         * TestResultServer/model/jsonresults.py:
3250         * TestResultServer/model/jsonresults_unittest.py:
3251
3252 2010-08-17  Adam Roben  <aroben@apple.com>
3253
3254         Use the right path style
3255
3256         * Scripts/old-run-webkit-tests:
3257
3258 2010-08-17  Adam Roben  <aroben@apple.com>
3259
3260         Fix typo
3261
3262         * Scripts/old-run-webkit-tests:
3263
3264 2010-08-17  Adam Roben  <aroben@apple.com>
3265
3266         Don't hang when running run-webkit-tests as a non-Administrator on
3267         Vista/7
3268
3269         * Scripts/old-run-webkit-tests:
3270         (setUpWindowsCrashLogSaving): Use regtool to set NTSD as the
3271         post-mortem debugger, rather than using NTSD itself. The latter waits
3272         for user input when it fails to set the registry values; the former
3273         does not.
3274
3275 2010-08-17  Adam Roben  <aroben@apple.com>
3276
3277         Teach run-webkit-tests, DumpRenderTree, and WebKitTestRunner how to
3278         save crash logs on Windows
3279
3280         The crash logs are saved to /tmp/layout-test-results and have names
3281         like CrashLog_02bc_2010-08-17_14-36-20-108.txt.
3282
3283         Unfortunately, crashes in the WebKit2 web process are recorded as
3284         time-outs by run-webkit-tests. Fixing this is covered by
3285         <http://webkit.org/b/44121>.
3286
3287         Fixes <http://webkit.org/b/37859> <rdar://problem/7883560>
3288         DumpRenderTree should save a stack trace and/or dump file when it
3289         crashes
3290
3291         Reviewed by Sam Weinig.
3292
3293         * DumpRenderTree/win/DumpRenderTree.cpp:
3294         (exceptionFilter):
3295         (main):
3296         * WebKitTestRunner/win/TestControllerWin.cpp:
3297         (WTR::exceptionFilter):
3298         (WTR::TestController::platformInitialize):
3299         These changes set up an exception filter that prints #CRASHED to
3300         stderr, then lets the exception propagate normally. This allows
3301         run-webkit-tests to detect when we've crashed even when a post-mortem
3302         debugger attaches to the process.
3303
3304         * Scripts/old-run-webkit-tests:
3305         (top level): Declared some variables used by the crash-log-saving
3306         code.
3307         (openDumpTool): Copy _NT_SYMBOL_PATH into the clean environment so
3308         that the post-mortem debugger has access to it.
3309         (toCygwinPath): Added. This is the opposite of toWindowsPath.
3310         (readFromDumpToolWithTimer): If the dump tool prints #CRASHED to
3311         stderr, consider it a crash.
3312         (setUpWindowsCrashLogSaving): Added. Saves the current post-mortem
3313         debugger, then sets ntsd as the post-mortem debugger. ntsd is
3314         configured to save a crash log and then quit automatically.
3315         (END): Added. Restores the previous post-mortem debugger when the
3316         script exits.
3317
3318 2010-08-17  Victor Wang  <victorw@chromium.org>
3319
3320         Reviewed by ojan@chromium.org.
3321
3322         Update test results server:
3323         1. Normalize test results and times after merging (prune tests where
3324            all runs pass or do not have data, truncate all test items to max
3325            number of builds)
3326         2. times should be int not string.
3327         3. when inserting a new test item, should keep old data regardless
3328            whether or not they have same item type with new one.
3329
3330         https://bugs.webkit.org/show_bug.cgi?id=43861
3331
3332         * TestResultServer/model/jsonresults.py:
3333         * TestResultServer/model/jsonresults_unittest.py:
3334
3335 2010-08-16  Sam Weinig  <sam@webkit.org>
3336
3337         Reviewed by Mark Rowe.
3338
3339         Add WebKit2 Mac tester to buildbot.
3340
3341         * BuildSlaveSupport/build.webkit.org-config/config.json:
3342         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3343
3344 2010-08-16  Paul Sawaya  <psawaya@apple.com>
3345
3346         Reviewed by Chris Marrin.
3347
3348         Added shader validation via ANGLE
3349         https://bugs.webkit.org/show_bug.cgi?id=42405
3350
3351         Added ANGLE to webkit build
3352
3353         * Scripts/build-webkit:
3354
3355 2010-08-16  Kevin Ollivier  <kevino@theolliviers.com>
3356
3357         [wx] Build fix, do not build WebCore as a convenience library as this leads to
3358         errors in the Win build w/export symbols and causes problems with DOM bindings
3359         debugging in gdb.
3360
3361         * DumpRenderTree/wscript:
3362         * Scripts/build-webkit:
3363         * wx/browser/wscript:
3364         * wx/build/settings.py:
3365         * wx/build/waf_extensions.py:
3366
3367 2010-08-16  Dan Bernstein  <mitz@apple.com>
3368
3369         Build fix.
3370
3371         * WebKitTestRunner/TestController.cpp:
3372         (WTR::createOtherPage): Initialize the contentsSizeChanged member.
3373         (WTR::TestController::initialize): Ditto.
3374
3375 2010-08-16  Balazs Kelemen  <kb@inf.u-szeged.hu>
3376
3377         Reviewed by Kenneth Rohde Christiansen.
3378
3379         Handle content size change in WebKit2
3380         Re-landing after fix.
3381
3382         https://bugs.webkit.org/show_bug.cgi?id=43198
3383
3384         * MiniBrowser/mac/BrowserWindowController.m:
3385         (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
3386         * MiniBrowser/win/BrowserView.cpp:
3387         (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.
3388
3389 2010-08-16  Sheriff Bot  <webkit.review.bot@gmail.com>
3390
3391         Unreviewed, rolling out r65419.
3392         http://trac.webkit.org/changeset/65419
3393         https://bugs.webkit.org/show_bug.cgi?id=44053
3394
3395         Broke the Windows build (Requested by bbandix on #webkit).
3396
3397         * MiniBrowser/mac/BrowserWindowController.m:
3398         (-[BrowserWindowController awakeFromNib]):
3399         * MiniBrowser/win/BrowserView.cpp:
3400         (BrowserView::create):
3401
3402 2010-08-16  Balazs Kelemen  <kb@inf.u-szeged.hu>
3403
3404         Reviewed by Kenneth Rohde Christiansen.
3405
3406         Handle content size change in WebKit2
3407
3408         https://bugs.webkit.org/show_bug.cgi?id=43198
3409
3410         * MiniBrowser/mac/BrowserWindowController.m:
3411         (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
3412         * MiniBrowser/win/BrowserView.cpp:
3413         (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.
3414
3415 2010-08-16  Ariya Hidayat  <ariya@sencha.com>
3416
3417         Add my new email address to committers.py.
3418
3419         * Scripts/webkitpy/common/config/committers.py:
3420
3421 2010-08-16  Zoltan Horvath  <zoltan@webkit.org>
3422
3423         Add my old e-mail addresses to committers.py.
3424
3425         * Scripts/webkitpy/common/config/committers.py:
3426
3427 2010-08-15  Jon Honeycutt  <jhoneycutt@apple.com>
3428
3429         WebEditorClient::didBeginEditing is never called in WebKit2
3430         https://bugs.webkit.org/show_bug.cgi?id=42939
3431
3432         Reviewed by Sam Weinig.
3433
3434         * WebKitTestRunner/PlatformWebView.h:
3435         Declare focus().
3436
3437         * WebKitTestRunner/TestController.cpp:
3438         (WTR::TestController::resetStateToConsistentValues):
3439         Focus the PlatformWebView.
3440
3441         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3442         (WTR::PlatformWebView::focus):
3443         Stubbed.
3444
3445         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3446         (WTR::PlatformWebView::focus):
3447         Focus the view.
3448
3449 2010-08-15  Jon Honeycutt  <jhoneycutt@apple.com>
3450
3451         run-webkit-tests should not strip editing callbacks when using
3452         WebKitTestRunner on Windows
3453         https://bugs.webkit.org/show_bug.cgi?id=44000
3454
3455         Reviewed by Mark Rowe.
3456
3457         * Scripts/old-run-webkit-tests:
3458         Leave $stripEditingCallbacks undefined until we look for command-line
3459         arguments. If using WebKit2, set it to 0 if not explicity set on the
3460         command line. Later, set it to isCygwin() to match old behavior if it is
3461         not yet defined.
3462
3463 2010-08-15  Kevin Ollivier  <kevino@theolliviers.com>
3464
3465         [wx] Build fix, remove define always set to the correct value by wtf/Platform.h.
3466
3467         * wx/build/settings.py:
3468
3469 2010-08-14  Martin Robinson  <mrobinson@igalia.com>
3470
3471         Reviewed by Kenneth Rohde Christiansen.
3472
3473         [GTK] autogen.sh not executed if build-webkit options change
3474         https://bugs.webkit.org/show_bug.cgi?id=42266
3475
3476         Rerun autogen.sh in situations where the arguments to build-webkit have
3477         changed since the previous build. This will fix some issues on the bots
3478         where the build does not notice changes to default build-webkit arguments.
3479
3480         * Scripts/webkitdirs.pm: Add special logic for detecting changes to build-webkit arguments.
3481
3482 2010-08-14  Eric Seidel  <eric@webkit.org>
3483
3484         Unreviewed.  Another fix to support python 2.3.
3485
3486         Add support for MathML entities
3487         https://bugs.webkit.org/show_bug.cgi?id=43949
3488
3489         * Scripts/webkitpy/thirdparty/simplejson/decoder.py:
3490          - It looks like our simplejson is version 1.7.3 which
3491            should be python 2.3 compatible.  But someone modified
3492            our copy slightly from the original source.
3493            I've removed the relative import in hopes this fixes
3494            the problem.
3495
3496 2010-08-13  Eric Seidel  <eric@webkit.org>
3497
3498         Unreviewed.  Build fix only.
3499
3500         Add support for MathML entities
3501         https://bugs.webkit.org/show_bug.cgi?id=43949
3502
3503         * Scripts/create-html-entity-table:
3504          - Hack sys.path to avoid executing 2.5 dependent python
3505            on systems (like chromium-win and Tiger) which do not have 2.5 python.
3506
3507 2010-08-13  Adam Barth  <abarth@webkit.org>
3508
3509         Reviewed by Eric Seidel.
3510
3511         Rename some concepts in HTML entity search to be more self-documenting
3512         https://bugs.webkit.org/show_bug.cgi?id=44004
3513
3514         Reflect name change in generator script.
3515
3516         * Scripts/create-html-entity-table:
3517
3518 2010-08-12  Adam Barth  <abarth@webkit.org>
3519
3520         Reviewed by Eric Seidel.
3521
3522         Add support for MathML entities
3523         https://bugs.webkit.org/show_bug.cgi?id=43949
3524
3525         A script for generating the C++ state data structure describing all the
3526         entities from a JSON description.
3527
3528         * Scripts/create-html-entity-table: Added.
3529
3530 2010-08-13  Dirk Pranke  <dpranke@chromium.org>
3531
3532         Reviewed by Eric Seidel.
3533
3534         Rewrite new-run-webkit-test's wait_for_threads_to_finish loop to
3535         check for exceptions on all threads, not just the first thread.
3536         
3537         This change also changes the logging behavior for wedged threads
3538         to only dump the stacks of threads that are actually wedged.
3539
3540         Refactor the thread classes in the dump_render_tree_thread module
3541         to make the contract between TestRunner and TestShellThread clearer.
3542
3543         Added a bunch of unit tests.
3544         https://bugs.webkit.org/show_bug.cgi?id=38561
3545
3546         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3547         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3548         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3549
3550 2010-08-13  Kenichi Ishibashi  <bashi@google.com>
3551
3552         Reviewed by Shinichiro Hamaji.
3553
3554         Add test_expectations.txt syntax checker to check-webkit-style.
3555         https://bugs.webkit.org/show_bug.cgi?id=43899
3556
3557         Just utilizing layout_tests/layout_package/test_expectations.py for checking
3558         the syntax of test_expectations.txt.
3559         This change also moves tab checking class from style/checkers/text.py to
3560         style/checkers/common.py for sharing code.
3561
3562         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3563         * Scripts/webkitpy/style/checker.py:
3564         * Scripts/webkitpy/style/checkers/common.py:
3565         * Scripts/webkitpy/style/checkers/common_unittest.py:
3566         * Scripts/webkitpy/style/checkers/test_expectations.py: Added.
3567         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Added.
3568         * Scripts/webkitpy/style/checkers/text.py:
3569         * Scripts/webkitpy/style_references.py:
3570
3571 2010-08-12  Jon Honeycutt  <jhoneycutt@apple.com>
3572
3573         WebKitTestRunner does not correctly resize WebView for W3C SVG tests
3574         https://bugs.webkit.org/show_bug.cgi?id=43945
3575
3576         Reviewed by Sam Weinig.
3577
3578         * WebKitTestRunner/TestInvocation.cpp:
3579         (WTR::sizeWebViewForCurrentTest):
3580         Allow for a Windows-style path.
3581
3582         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3583         (WTR::PlatformWebView::resizeTo):
3584         Call SetWindowPos to resize the view window.
3585
3586 2010-08-12  David Levin  <levin@chromium.org>
3587
3588         Build break fix.
3589
3590         * WebKitTestRunner/TestController.cpp:
3591         (WTR::TestController::resetStateToConsistentValues): Removed usage
3592         of a variable that doesn't exist in the class.
3593
3594 2010-08-12  Jon Honeycutt  <jhoneycutt@apple.com>
3595
3596         WebKitTestRunner needs to run tests without using native controls
3597         https://bugs.webkit.org/show_bug.cgi?id=43772
3598
3599         Reviewed by Sam Weinig.
3600
3601         * WebKitTestRunner/TestController.cpp:
3602         (WTR::TestController::initialize):
3603         Call platformInitializeContext().
3604
3605         * WebKitTestRunner/TestController.h:
3606         Declare platformInitializeContext().
3607
3608         * WebKitTestRunner/mac/TestControllerMac.mm:
3609         (WTR::TestController::platformInitializeContext):
3610         Stubbed.
3611
3612         * WebKitTestRunner/win/TestControllerWin.cpp:
3613         (WTR::TestController::platformInitializeContext):
3614         Call WKContextSetShouldPaintNativeControls() to disable native control
3615         drawing.
3616
3617 2010-08-12  Sam Weinig  <sam@webkit.org>
3618
3619         Reviewed by Alexey Proskuryakov.
3620
3621         WebKitTestRunner should be more aggressive about ensuring consistent state between tests
3622         https://bugs.webkit.org/show_bug.cgi?id=43653
3623
3624         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3625         (WTR::InjectedBundle::InjectedBundle):
3626         (WTR::InjectedBundle::didReceiveMessage):
3627         (WTR::InjectedBundle::beginTesting):
3628         (WTR::InjectedBundle::done):
3629         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3630         (WTR::InjectedBundle::isTestRunning):
3631         (WTR::InjectedBundle::):
3632         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3633         (WTR::InjectedBundlePage::stopLoading):
3634         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
3635         (WTR::InjectedBundlePage::dump):
3636         (WTR::InjectedBundlePage::didFinishLoadForFrame):
3637         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
3638         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
3639         (WTR::InjectedBundlePage::didClearWindowForFrame):
3640         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
3641         (WTR::InjectedBundlePage::willAddMessageToConsole):
3642         (WTR::InjectedBundlePage::willSetStatusbarText):
3643         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
3644         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
3645         (WTR::InjectedBundlePage::shouldBeginEditing):
3646         (WTR::InjectedBundlePage::shouldEndEditing):
3647         (WTR::InjectedBundlePage::shouldInsertNode):
3648         (WTR::InjectedBundlePage::shouldInsertText):
3649         (WTR::InjectedBundlePage::shouldDeleteRange):
3650         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
3651         (WTR::InjectedBundlePage::shouldApplyStyle):
3652         (WTR::InjectedBundlePage::didBeginEditing):
3653         (WTR::InjectedBundlePage::didEndEditing):
3654         (WTR::InjectedBundlePage::didChange):
3655         (WTR::InjectedBundlePage::didChangeSelection):
3656         Don't do any work if we are not currently running a test.
3657
3658         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3659         * WebKitTestRunner/StringFunctions.h:
3660         (WTR::toCF):
3661         Add conversion function for WKURLRef -> CFURLRef
3662
3663         * WebKitTestRunner/TestController.cpp:
3664         (WTR::TestController::TestController):
3665         (WTR::TestController::initialize):
3666         (WTR::TestController::resetStateToConsistentValues):
3667         (WTR::TestController::runTest):
3668         (WTR::TestController::didFinishLoadForFrame):
3669         * WebKitTestRunner/TestController.h:
3670         (WTR::TestController::):
3671         * WebKitTestRunner/TestInvocation.cpp:
3672         (WTR::TestInvocation::invoke):
3673         * WebKitTestRunner/TestInvocation.h:
3674         Move resetting code to TestController.
3675
3676         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3677         * WebKitTestRunner/mac/TestControllerMac.mm:
3678         (WTR::TestController::runUntil):
3679         * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
3680         * WebKitTestRunner/win/TestControllerWin.cpp:
3681         (WTR::TestController::runUntil):
3682         * WebKitTestRunner/win/TestInvocationWin.cpp: Removed.
3683         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3684         Move runUntil to TestController.
3685
3686 2010-08-12  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3687
3688         Unreviewed.
3689
3690         Adding myself to the committers list.
3691
3692         * Scripts/webkitpy/common/config/committers.py:
3693
3694 2010-08-12  Hayato Ito  <hayato@chromium.org>
3695
3696         Reviewed by Tony Chang.
3697
3698         Merge pretty printers for gdb.
3699         https://bugs.webkit.org/show_bug.cgi?id=43850
3700
3701         We need to update webcore.py because basic string classes have moved to WTF from WebCore.
3702         It is good timing to merge webcore.py and wtf.py and name it 'webkit.py'.
3703         webcore.py is left for backward compatibility.
3704
3705         * gdb/webcore.py:
3706         * gdb/webkit.py: Added.
3707         * gdb/wtf.py: Removed.
3708
3709 2010-08-11  Tony Chang  <tony@chromium.org>
3710
3711         Reviewed by David Levin.
3712
3713         [chromium] add google-chrome layout test result directories
3714         https://bugs.webkit.org/show_bug.cgi?id=43889
3715
3716         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3717         * Scripts/webkitpy/layout_tests/port/factory.py:
3718         * Scripts/webkitpy/layout_tests/port/google_chrome.py: Added.
3719         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
3720
3721 2010-08-11  Kent Tamura  <tkent@chromium.org>
3722
3723         Reviewed by Dimitri Glazkov.
3724
3725         [DRT/Chromium] Disable accelerated compositing
3726         https://bugs.webkit.org/show_bug.cgi?id=43894
3727
3728         Disable accelerated compositing because DRT is not ready for
3729         it. This change fixes hundreds of test crashes on Windows and
3730         Linux.
3731
3732         * DumpRenderTree/chromium/TestShell.cpp:
3733         (TestShell::resetWebSettings):
3734
3735 2010-08-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3736
3737         Unreviewed. Adding my Collabora personality to the list.
3738
3739         * Scripts/webkitpy/common/config/committers.py:
3740
3741 2010-08-11  Martin Robinson  <mrobinson@igalia.com>
3742
3743         Adding myself as a reviewer.
3744
3745         * Scripts/webkitpy/common/config/committers.py:
3746
3747 2010-08-11  Daniel Bates  <dbates@rim.com>
3748
3749         Reviewed by Darin Adler.
3750
3751         Perl warnings when running commit-log-editor
3752         https://bugs.webkit.org/show_bug.cgi?id=43856
3753
3754         Fixes Perl warnings introduced by the patch for Bug #40548.
3755
3756         Perl doesn't have symbolic names for True/False. Instead, we
3757         should use boolean values. Moreover, the variable installedEditorApplication
3758         is not be used and should be renamed builtEditorApplication so that it
3759         uses the existing machinery to set the commit log editor application.
3760
3761         * Scripts/commit-log-editor:
3762
3763 2010-08-11  Adam Barth  <abarth@webkit.org>
3764
3765         Reviewed by Eric Seidel.
3766
3767         Trying waiting for httpd lock in the EWS
3768         https://bugs.webkit.org/show_bug.cgi?id=43833
3769
3770         If this works, we can probably run the tests on the mac-ews, which
3771         would be very exciting.  :)
3772
3773         * Scripts/webkitpy/tool/steps/runtests.py:
3774
3775 2010-08-11  Marcus Bulach  <bulach@chromium.org>
3776
3777         Reviewed by Eric Seidel.
3778
3779         Check in a script to list redundant test outputs.
3780         https://bugs.webkit.org/show_bug.cgi?id=37630
3781
3782         If e.g. platform/mac-leopard is missing an expected test output, we
3783         fall back on platform/mac.  This means it's possible to grow redundant
3784         test outputs, where we have the same expected data in both a platform
3785         directory and another platform it falls back on.
3786         (original patch by Evan Marting <evan@chromium.org> https://bugs.webkit.org/attachment.cgi?id=53398)
3787
3788         * Scripts/deduplicate-tests: Added.
3789         * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Added.
3790         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: Added.
3791
3792 2010-08-11  Antonio Gomes  <tonikitoo@webkit.org>
3793
3794         Reviewed by Ariya Hidayat.
3795
3796         [Qt] QtTestBrowser: after switching between QWebView and QGraphicsWebView, rotation actions get broken
3797         https://bugs.webkit.org/show_bug.cgi?id=43853
3798
3799         LauncherWindow::createChrome is connecting menu itens to WebViewGraphicsBased's slots directly.
3800         It behaviors badly when user launches the QtTestBrowser in QWebView mode, since then switching to
3801         QGraphicsWebView mode, createChrome is not called again, and menu items end up not getting connected
3802         to slots at all.
3803
3804         * QtTestBrowser/launcherwindow.cpp:
3805         (LauncherWindow::createChrome):
3806         (LauncherWindow::animatedFlip):
3807         (LauncherWindow::animatedYFlip):
3808         * QtTestBrowser/launcherwindow.h:
3809
3810 2010-08-11  Antonio Gomes  <tonikitoo@webkit.org>
3811
3812         Reviewed by Simon Hausmann.
3813
3814         [Qt] QtTestBrowser: switching between QWebView and QGraphicsWebView modes is broken
3815         https://bugs.webkit.org/show_bug.cgi?id=43851
3816
3817         All window options data (including the bool holding if the view is either QWebView or
3818         QGraphicsWebView based) is stored in m_windowOptions, a class member of LauncherWindow.
3819         When toggle the view from QWebView to QGraphicsWebView based (and vice-versa), we were
3820         not updating LauncherWindow::WindowOptions::m_useGraphicsView bit, and then things were
3821         getting broken.
3822
3823         Patch addresses this issue.
3824
3825         * QtTestBrowser/launcherwindow.cpp:
3826         (LauncherWindow::createChrome):
3827         (LauncherWindow::toggleWebView):
3828         (LauncherWindow::toggleAcceleratedCompositing):
3829
3830 2010-08-10  Antonio Gomes  <tonikitoo@webkit.org>
3831
3832         Reviewed by Ariya Hidayat.
3833
3834         [Qt] QtTestBrowser: lazy instantiate "YRotation" state machine and related objects
3835         https://bugs.webkit.org/show_bug.cgi?id=43831
3836
3837         Only instantiate QStateMachine and friends associated to the YRotation action on demand.
3838
3839         * QtTestBrowser/webview.cpp:
3840         (WebViewGraphicsBased::WebViewGraphicsBased):
3841         (WebViewGraphicsBased::animatedYFlip):
3842
3843 2010-08-11  Darin Adler  <darin@apple.com>
3844
3845         Reviewed by John Sullivan.
3846
3847         Improved editor options for prepare-ChangeLog and commit-log-editor
3848         https://bugs.webkit.org/show_bug.cgi?id=40548
3849
3850         * Scripts/commit-log-editor: Split editor strings on spaces so EDITOR
3851         values like "xed --launch --wait" work properly.
3852
3853         * Scripts/prepare-ChangeLog: Added a new CHANGE_LOG_EDITOR so we can
3854         use a command line tool with the $openChangeLogs feature.
3855
3856 2010-08-11  Yury Semikhatsky  <yurys@chromium.org>
3857
3858         Reviewed by Pavel Feldman.
3859
3860         Web Inspector: remove InjectDispatch.js
3861         https://bugs.webkit.org/show_bug.cgi?id=43835
3862
3863         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
3864         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3865
3866 2010-08-10  Dirk Pranke  <dpranke@chromium.org>
3867
3868         Reviewed by Eric Seidel.
3869
3870         webkit-patch should refuse to run under Win32 Python
3871         https://bugs.webkit.org/show_bug.cgi?id=40962
3872
3873         Given that there are lots of places in webkit-patch's code that
3874         assume unix-style filenames (forward slashes), webkit-patch fails
3875         with weird file-not-found errors when run under a native windows
3876         Python. It would be nice if we just trapped this and errored out
3877         at the beginning, rather than producing unpredictable errors.
3878
3879         * Scripts/webkit-patch:
3880
3881 2010-08-10  Kent Tamura  <tkent@chromium.org>
3882
3883         Unreviewed, build fix.
3884         
3885         Chromium build fix for r65107.
3886
3887         * DumpRenderTree/chromium/LayoutTestController.cpp:
3888         (LayoutTestController::suspendAnimations):
3889         (LayoutTestController::resumeAnimations):
3890
3891 2010-08-10  Sergio Villar Senin  <svillar@igalia.com>
3892
3893         Reviewed by Xan Lopez.
3894
3895         [GTK] http/tests/media/video-cookie.html fails
3896         https://bugs.webkit.org/show_bug.cgi?id=42240
3897
3898         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3899         (LayoutTestController::setAlwaysAcceptCookies): create the
3900         SoupCookieJar if it does not exist. Otherwise the accept policy
3901         won't be set.
3902
3903 2010-08-10  Chris Marrin  <cmarrin@apple.com>
3904
3905         Reviewed by Oliver Hunt.
3906
3907         Add suspendAnimations/resumeAnimation API to DRT
3908         https://bugs.webkit.org/show_bug.cgi?id=43733
3909         
3910         Adds suspendAnimations() and resumeAnimations() to LayoutTestController.
3911         Calls functions with the same names on AnimationController for the 
3912         mainFrame.
3913
3914         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3915         * DumpRenderTree/LayoutTestController.cpp:
3916         (suspendAnimationsCallback):
3917         (resumeAnimationsCallback):
3918         (LayoutTestController::staticFunctions):
3919         * DumpRenderTree/LayoutTestController.h:
3920         * DumpRenderTree/chromium/LayoutTestController.cpp:
3921         (LayoutTestController::LayoutTestController):
3922         (LayoutTestController::suspendAnimations):
3923         (LayoutTestController::resumeAnimations):
3924         * DumpRenderTree/chromium/LayoutTestController.h:
3925         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3926         (LayoutTestController::suspendAnimations):
3927         (LayoutTestController::resumeAnimations):
3928         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3929         (LayoutTestController::suspendAnimations):
3930         (LayoutTestController::resumeAnimations):
3931         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3932         (LayoutTestController::suspendAnimations):
3933         (LayoutTestController::resumeAnimations):
3934         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3935         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3936         (LayoutTestController::suspendAnimations):
3937         (LayoutTestController::resumeAnimations):
3938         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3939         (LayoutTestController::suspendAnimations):
3940         (LayoutTestController::resumeAnimations):
3941
3942 2010-08-10  Dimitri Glazkov  <dglazkov@chromium.org>
3943
3944         Reviewed by Ojan Vafai.
3945
3946         [Chromium/DRT] Enable saving layout test results.
3947         https://bugs.webkit.org/show_bug.cgi?id=43796
3948
3949         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added more
3950             parameters to the new-run-webkit-tests, including the name
3951             of the test results server.
3952
3953 2010-08-10  Jian Li  <jianli@chromium.org>
3954
3955         More chromium build fix.
3956
3957         * DumpRenderTree/chromium/MockSpellCheck.cpp:
3958         (MockSpellCheck::spellCheckWord):
3959         (MockSpellCheck::initializeIfNeeded):
3960         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3961         (NotificationPresenter::grantPermission):
3962         (NotificationPresenter::show):
3963         (NotificationPresenter::checkPermission):
3964
3965 2010-08-10  Jian Li  <jianli@chromium.org>
3966
3967         Chromium build fix.
3968
3969         * DumpRenderTree/chromium/MockSpellCheck.cpp:
3970         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3971
3972 2010-08-10  Victor Wang  <victorw@chromium.org>
3973
3974         Reviewed by Ojan Vafai.
3975
3976         Update test results server merge logic so the aggregated
3977         results and times are updated for tests that are
3978         in aggragated json but not in incremental json.
3979
3980         Also update unittest to test this case.
3981
3982         https://bugs.webkit.org/show_bug.cgi?id=43769
3983
3984         * TestResultServer/model/jsonresults.py:
3985         * TestResultServer/model/jsonresults_unittest.py:
3986
3987 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
3988
3989         Reviewed by Ariya Hidayat.
3990
3991         [Qt] QtTestBrowser: proper set scene rect
3992
3993         When resizesToContents is ON scene's rect is set to the boundary of
3994         the mainFrame. However, navigating to other web page should keep resizing
3995         scene's rect according to the new document loaded. Patch addresses this issue.
3996
3997         Now resizesToContents and scrolling properly work on QtTestBrowser.
3998
3999         * QtTestBrowser/webview.cpp:
4000         (WebViewGraphicsBased::setPage):
4001         (WebViewGraphicsBased::contentsSizeChanged):
4002         (WebViewGraphicsBased::setResizesToContents):
4003         (WebViewGraphicsBased::resizeEvent):
4004         * QtTestBrowser/webview.h:
4005
4006 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
4007
4008         Reviewed by Ariya Hidayat.
4009
4010         [Qt] QtTestBrowser: Clean up LauncherWindow code.
4011
4012         * QtTestBrowser/launcherwindow.cpp:
4013         (LauncherWindow::LauncherWindow): Moves applyPrefs methods call from the constructor to init().
4014         (LauncherWindow::init): Fixed comments.
4015         (LauncherWindow::applyPrefs): Move the method around.
4016         (LauncherWindow::createChrome): Move more code of this method around, for grouping, and fixing up comments.
4017
4018 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
4019
4020         Reviewed by Ariya Hidayat.
4021
4022         [Qt] QtTestBrowser: make reset-zooming to animate when tiled backing store is on.
4023
4024         It gets control+0 the same visual effect as control++ or control-.
4025
4026         * QtTestBrowser/launcherwindow.cpp:
4027         (LauncherWindow::toggleZoomTextOnly):
4028
4029 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
4030
4031         Reviewed by Ariya Hidayat.
4032
4033         [Qt] QtTestBrowser:: make m_zoomLevels a static member.
4034
4035         Not all instances of LauncherWindow need its own m_zoomLevel.
4036
4037         * QtTestBrowser/launcherwindow.cpp:
4038         * QtTestBrowser/launcherwindow.h:
4039
4040 2010-08-09  Sam Weinig  <sam@webkit.org>
4041
4042         Reviewed by Geoffrey Garen.
4043
4044         Add zoom support for injected bundle
4045         https://bugs.webkit.org/show_bug.cgi?id=43759
4046
4047         Use zoom factor SPI to implement zoom related eventSender functions.
4048
4049         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
4050         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
4051         (WTR::EventSendingController::textZoomIn):
4052         (WTR::EventSendingController::textZoomOut):
4053         (WTR::EventSendingController::zoomPageIn):
4054         (WTR::EventSendingController::zoomPageOut):
4055         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
4056         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4057         (WTR::InjectedBundlePage::reset): Reset zoom mode and level for each test.
4058
4059 2010-08-09  Gavin Barraclough  <barraclough@apple.com>
4060
4061         Speculative chromium build fix III.
4062
4063         * DumpRenderTree/chromium/MockSpellCheck.h:
4064         * DumpRenderTree/chromium/NotificationPresenter.h:
4065         * DumpRenderTree/chromium/WebViewHost.h:
4066         (WebViewHost::addClearHeader):
4067         (WebViewHost::clearHeaders):
4068
4069 2010-08-09  Ojan Vafai  <ojan@chromium.org>
4070
4071         Reviewed by Tony Chang.
4072
4073         increase the number of test results that we save
4074         https://bugs.webkit.org/show_bug.cgi?id=43763
4075
4076         Now that we do incremental uploads, we can increase the number of
4077         results that we save for http://test-results.appspot.com/dashboards/flakiness_dashboard.html.
4078
4079         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
4080
4081 2010-08-09  Evan Martin  <evan@chromium.org>
4082
4083         Reviewed by Tony Chang.
4084
4085         [chromium] DRT error print statement incorrectly tries to print a FILE*
4086         https://bugs.webkit.org/show_bug.cgi?id=43747
4087
4088         * DumpRenderTree/chromium/ImageDiff.cpp:
4089         (writeFile): pass the correct pointer.
4090
4091 2010-08-09  Victor Wang  <victorw@chromium.org>
4092
4093         Reviewed by Ojan Vafai.
4094
4095         Upload incremental test results json to server by default.
4096
4097         https://bugs.webkit.org/show_bug.cgi?id=43743
4098
4099         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4100
4101 2010-08-09  Eric Seidel  <eric@webkit.org>
4102
4103         Reviewed by Adam Barth.
4104
4105         EWS bots wait 2 minutes between patches
4106         https://bugs.webkit.org/show_bug.cgi?id=43731
4107
4108         * Scripts/webkitpy/tool/bot/queueengine.py:
4109          - Don't sleep after failures.  This was a hold-over from
4110            an earlier design.
4111         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4112          - EWS bots were not properly reporting true/false from process_work_item.
4113            They were always returning None, thus false, thus always logging
4114            as a failure and sleeping 2 minutes after each patch.
4115
4116 2010-08-09  Sam Weinig  <sam@webkit.org>
4117
4118         Reviewed by Anders Carlsson.
4119
4120         Stub out EventSender for WebKitTestRunner
4121         https://bugs.webkit.org/show_bug.cgi?id=43703
4122
4123         * WebKitTestRunner/DerivedSources.make:
4124         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
4125         Add ability to pass javascript arguments to the wrapped object.
4126
4127         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added.
4128         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: Added.
4129         (WTR::EventSendingController::create):
4130         (WTR::EventSendingController::EventSendingController):
4131         (WTR::EventSendingController::~EventSendingController):
4132         (WTR::EventSendingController::wrapperClass):
4133         (WTR::setExceptionForString):
4134         (WTR::EventSendingController::mouseDown):
4135         (WTR::EventSendingController::mouseUp):
4136         (WTR::EventSendingController::mouseMoveTo):
4137         (WTR::EventSendingController::keyDown):
4138         (WTR::EventSendingController::contextClick):
4139         (WTR::EventSendingController::leapForward):
4140         (WTR::EventSendingController::textZoomIn):
4141         (WTR::EventSendingController::textZoomOut):
4142         (WTR::EventSendingController::zoomPageIn):
4143         (WTR::EventSendingController::zoomPageOut):
4144         (WTR::EventSendingController::makeWindowObject):
4145         * WebKitTestRunner/InjectedBundle/EventSendingController.h: Added.
4146         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4147         (WTR::InjectedBundle::reset):
4148         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
4149         (WTR::InjectedBundle::eventSendingController):
4150         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4151         (WTR::InjectedBundlePage::didClearWindowForFrame):
4152         Add stubbed out EventSenderController.
4153
4154         * WebKitTestRunner/InjectedBundle/GCController.h:
4155         Remove incorrect comment.
4156
4157         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4158         * WebKitTestRunner/win/InjectedBundle.vcproj:
4159         Add new files.
4160
4161 2010-08-08  Kent Tamura  <tkent@chromium.org>
4162
4163         Unreviewed, trivial fix.
4164
4165         Fix "WindowsError: [Error 32] The process cannot access the file
4166         because it is being used by another process" introduced by r64959.
4167
4168         * BuildSlaveSupport/test-result-archive:
4169
4170 2010-08-08  Kent Tamura  <tkent@chromium.org>
4171
4172         Reviewed by Tony Chang.
4173
4174         Chromium buildbot: Avoid "zip" command dependency
4175         https://bugs.webkit.org/show_bug.cgi?id=43470
4176
4177         * BuildSlaveSupport/test-result-archive:
4178          For Chromium port, creates a zip archive with zipfile package of Python
4179          instead of external "zip" command. We'd like to avoid additional
4180          command installation.
4181
4182 2010-08-08  Jon Honeycutt  <jhoneycutt@apple.com>
4183
4184         WebKitTestRunner should add the QuickTime dir to the PATH environment
4185         variable
4186         https://bugs.webkit.org/show_bug.cgi?id=43686
4187
4188         Reviewed by Dan Bernstein.
4189
4190         * WebKitTestRunner/win/TestControllerWin.cpp:
4191         (WTR::addQTDirToPATH):
4192         Copied from DRT.
4193         (WTR::TestController::platformInitialize):
4194         Call addQTDirToPath().
4195         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
4196         Link to shlwapi.lib for SHGetValue.
4197
4198 2010-08-07  Sam Weinig  <sam@webkit.org>
4199
4200         Reviewed by Maciej Stachowiak.
4201
4202         WebKitTestRunner needs layoutTestController.dumpTitleChanges
4203         <rdar://problem/8213861>
4204         https://bugs.webkit.org/show_bug.cgi?id=42683
4205
4206         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
4207         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4208         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
4209         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
4210         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
4211         (WTR::LayoutTestController::LayoutTestController):
4212         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
4213         (WTR::LayoutTestController::dumpTitleChanges):
4214         (WTR::LayoutTestController::shouldDumpTitleChanges):
4215
4216 2010-08-07  Sam Weinig  <sam@webkit.org>
4217
4218         Reviewed by Anders Carlsson.
4219
4220         WebKitTestRunner needs to print onunload handler information
4221         <rdar://problem/8213831>
4222         https://bugs.webkit.org/show_bug.cgi?id=42703
4223
4224         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4225         (WTR::operator<<):
4226         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
4227
4228 2010-08-07  Sam Weinig  <sam@webkit.org>
4229
4230         Reviewed by Anders Carlsson.
4231
4232         Add additional loader client functions need to complete WebKitTestRunner
4233         https://bugs.webkit.org/show_bug.cgi?id=43684
4234
4235         Remove unnecessary and jarring underscores as well.
4236
4237         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
4238         (didClearWindowObjectForFrame