bfcc94e606a3024146ece6dfce1f266dccd72b35
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-10-13  Yi Shen  <yi.4.shen@nokia.com>
2
3         Reviewed by Antonio Gomes.
4
5         [Qt] QtTestBrowser shows two Url input fields
6         https://bugs.webkit.org/show_bug.cgi?id=47613
7
8         * QtTestBrowser/mainwindow.cpp:
9         (MainWindow::MainWindow):
10         (MainWindow::buildUI):
11
12 2010-10-13  Yi Shen  <yi.4.shen@nokia.com>
13
14         Reviewed by Tony Chang.
15
16         [gdb] Add pretty-print supports for UString, Identifier and JSString
17         https://bugs.webkit.org/show_bug.cgi?id=47601
18
19         * gdb/webkit.py:
20
21 2010-10-13  Adam Barth  <abarth@webkit.org>
22
23         Reviewed by Eric Seidel.
24
25         Add list of Ubuntu packages needed by the EWS bots
26         https://bugs.webkit.org/show_bug.cgi?id=47628
27
28         I've been copy/pasting this list between bots, but it's better to have
29         this checked in.
30
31         * EWSTools/ubuntu-ews-packages: Added.
32
33 2010-10-13  Leandro Pereira  <leandro@profusion.mobi>
34
35         Reviewed by Csaba Osztrogonác.
36
37         [EFL] Adds a build slave.
38         https://bugs.webkit.org/show_bug.cgi?id=47290
39
40         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
41         entry for a release build of the EFL port.
42         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
43         flag to build the EFL port.
44
45 2010-10-13  Adam Barth  <abarth@webkit.org>
46
47         Reviewed by Csaba Osztrogonác.
48
49         webkit-patch build shouldn't need --build to actually build!
50         https://bugs.webkit.org/show_bug.cgi?id=47438
51
52         Yeah, requiring --build for the build command is really dumb.  We did
53         this originally because the build step is usually optional in other
54         commands.  We don't have a good way of reversing the default for an
55         option in one command.  This approach is slightly hacky since --build
56         still shows up as an option on the help page, but at least it makes
57         progress.  Passing --build is harmless, so the EWS bots shouldn't
58         explode because of this change.
59
60         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
61         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
62         * Scripts/webkitpy/tool/commands/download.py:
63         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
64         * Scripts/webkitpy/tool/commands/queues_unittest.py:
65
66 2010-10-13  Sheriff Bot  <webkit.review.bot@gmail.com>
67
68         Unreviewed, rolling out r69638.
69         http://trac.webkit.org/changeset/69638
70         https://bugs.webkit.org/show_bug.cgi?id=47595
71
72         "Broke win and chromium-win bots" (Requested by dglazkov on
73         #webkit).
74
75         * Scripts/webkitpy/common/system/path.py:
76         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
77         * Scripts/webkitpy/layout_tests/port/base.py:
78         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
79         * Scripts/webkitpy/layout_tests/port/chromium.py:
80         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
81
82 2010-10-13  John Knottenbelt  <jknotten@chromium.org>
83
84         Reviewed by Steve Block.
85
86         First step towards client-based Geolocation in Chromium. Build
87         fixes for CLIENT_BASED_GEOLOCATION preprocessor feature define.
88         https://bugs.webkit.org/show_bug.cgi?id=47586
89
90         * DumpRenderTree/chromium/WebViewHost.cpp:
91         * DumpRenderTree/chromium/WebViewHost.h:
92
93 2010-10-13  Adam Roben  <aroben@apple.com>
94
95         Test that pressing the spacebar in a text field does not scroll the
96         document
97
98         Test for <http://webkit.org/b/47544> <rdar://problem/8540645>
99         REGRESSION: Pressing spacebar in a text field in WebKit2 does not
100         insert a space, scrolls the page instead
101
102         Reviewed by Sam Weinig.
103
104         * TestWebKitAPI/PlatformUtilities.h: Added isKeyDown.
105
106         * TestWebKitAPI/PlatformWebView.h: Added simulateSpacebarKeyPress.
107
108         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
109         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
110         * TestWebKitAPI/win/copy-resources.cmd:
111         Added new files.
112
113         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: Added.
114         (TestWebKitAPI::JavaScriptCallbackContext::JavaScriptCallbackContext):
115         We use this to track what the result of calling into JavaScript was.
116         (TestWebKitAPI::didFinishLoadForFrame): Records when the page
117         finishes loading.
118         (TestWebKitAPI::didNotHandleKeyEventCallback): Records when a key down
119         event is not handled.
120         (TestWebKitAPI::javaScriptCallback): Records that JavaScript finished
121         executing and whether the result matched our expectation.
122         (TestWebKitAPI::wk): Turns a UTF-8 C string into a WKStringRef.
123         (TestWebKitAPI::runJSTest): Calls into JS, waits for the call to
124         complete, and returns whether we got back the expected result.
125         (TestWebKitAPI::WebKit2_SpacebarScrolling): Tests that pressing
126         spacebar inside a text field does not scroll the document and that
127         pressing it outside the text field does scroll the document.
128
129         * TestWebKitAPI/Tests/WebKit2/spacebar-scrolling.html: Added.
130
131         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
132         (TestWebKitAPI::Util::isKeyDown): Checks the event's type.
133
134         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
135         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Copied
136         code from DRT's EventSendingController.
137
138         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
139         (TestWebKitAPI::Util::isKeyDown): Checks the message's type.
140
141         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
142         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Send the
143         same messages that get sent when you press spacebar in Notepad.
144
145 2010-10-13  Adam Roben  <aroben@apple.com>
146
147         Fix a couple of issues with the TestWebKitAPI build
148
149         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops:
150         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops:
151         Fixed a typo.
152
153         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Use common.vsprops
154         to set our output and intermediate directories so that we don't spew
155         files into the source tree.
156
157 2010-10-13  Balazs Kelemen  <kbalazs@webkit.org>
158
159         Reviewed by Csaba Osztrogonác.
160
161         WTR should accept relative paths
162         https://bugs.webkit.org/show_bug.cgi?id=47486
163
164         * WebKitTestRunner/StringFunctions.h:
165         * WebKitTestRunner/TestInvocation.cpp:
166         (WTR::createWKURL): Moved from StringFunctions.h since it is
167         used only here. Extend relative paths to absolute.
168
169 2010-10-12  Adam Roben  <aroben@apple.com>
170
171         Make TestWebKitAPI work on Windows
172
173         Fixes <http://webkit.org/b/47552> <rdar://problem/8541708>.
174
175         Reviewed by Sam Weinig.
176
177         * Scripts/build-api-tests: Build TestWebKitAPI.sln on Windows.
178
179         * Scripts/run-api-tests: Fix the PATH so that TestWebKitAPI can be
180         run on Windows.
181         (runTest): Added code to run TestWebKitAPI.exe on Windows and to die
182         on unsupported platforms.
183         (populateTests): Added code to run TestWebKitAPI.exe on Windows and to
184         die on other platforms. Extracted some formerly-Mac-specific code to
185         be cross-platform and made it handle any style of line-endings.
186
187         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added.
188         Links against CFLite.
189
190         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added.
191         Contains most properties for the project.
192
193         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops:
194         Added. Links against CoreFoundation.
195
196         * TestWebKitAPI/TestWebKitAPIPrefix.h: Added a Windows-specific
197         section and moved the cross-platform section after the
198         platform-specific parts.
199
200         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Added.
201         (TestWebKitAPI::Util::run): Runs a normal message pump until we're
202         done.
203         (TestWebKitAPI::Util::cf): Turns a UTF-8 C string into a CFString.
204         (TestWebKitAPI::Util::createURLForResource): Uses CFBundle to get the
205         resource path.
206         (TestWebKitAPI::Util::URLForNonExistentResource): Creates a bogus
207         WKURL.
208
209         * TestWebKitAPI/win/PlatformWebViewWin.cpp: Added.
210         (TestWebKitAPI::registerWindowClass):
211         (TestWebKitAPI::PlatformWebView::PlatformWebView):
212         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
213         (TestWebKitAPI::PlatformWebView::page):
214         This was mostly copied from WebKitTestRunner's PlatformWebView.
215
216         * TestWebKitAPI/win/TestWebKitAPI.sln: Added. Builds both
217         TestWebKitAPI and TestWebKitAPIGeneratd. This is used by the
218         build-api-tests script.
219
220         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added. Builds
221         TestWebKitAPI.exe.
222
223         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added. Just calls
224         through to copy-resources.cmd.
225
226         * TestWebKitAPI/win/copy-resources.cmd: Added. Copies resources into
227         or deletes resources from TestWebKitAPI.resources.
228
229         * TestWebKitAPI/win/main.cpp: Added.
230         (main): Calls through to TestsController.
231
232 2010-10-13  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
233
234         Reviewed by Kenneth Rohde Christiansen.
235
236         [EFL] Support viewport configuration and add new arguments for WebKit EFL
237         https://bugs.webkit.org/show_bug.cgi?id=47084
238
239         Opera spec regarding to viewport meta tag was adjusted to WebCore. So, EFL port
240         needs to be modified according to the changes.
241
242         * EWebLauncher/main.c:
243         (on_viewport_changed):
244
245 2010-10-12  Dirk Pranke  <dpranke@chromium.org>
246
247         Reviewed by Eric Seidel.
248
249         This patch enables new-run-webkit-tests (in particular the
250         chromium-win port) to run under Cygwin as well as Win32. Mostly
251         this just required some conversions from cygwin paths to Win32
252         paths when we spawn off Win32 binaries like test_shell.
253
254         https://bugs.webkit.org/show_bug.cgi?id=47220
255
256         * Scripts/webkitpy/common/system/path.py:
257         - Expose the cygpath() function for path conversion
258
259         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
260         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
261         - shift filename->uri conversion in the TestInfo objects to the
262           dump_render_tree thread
263
264         * Scripts/webkitpy/layout_tests/port/base.py:
265         * Scripts/webkitpy/layout_tests/port/chromium.py:
266         - use cygpath()
267
268 2010-10-12  Yuta Kitamura  <yutak@chromium.org>
269
270         Unreviewed. Add Yuta Kitamura (yutak) to the committers list.
271
272         * Scripts/webkitpy/common/config/committers.py:
273
274 2010-10-12  Sam Weinig  <sam@webkit.org>
275
276         Reviewed by Dan Bernstein.
277
278         When a provisional load fails, the provisional URL returned
279         from WKFrameCopyProvisionalURL should be empty
280         <rdar://problem/8540878>
281         https://bugs.webkit.org/show_bug.cgi?id=47546
282
283         Add test.
284
285         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
286         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
287
288 2010-10-12  Anders Carlsson  <andersca@apple.com>
289
290         Reviewed by Sam Weinig.
291
292         Start fleshing out find page overlays
293         https://bugs.webkit.org/show_bug.cgi?id=47559
294
295         * MiniBrowser/mac/BrowserWindowController.m:
296         (-[BrowserWindowController find:]):
297         Pass kWKFindOptionsShowOverlay to WKPageFindString.
298
299 2010-10-12  Robert Hogan  <robert@webkit.org>
300
301         Reviewed by Antonio Gomes.
302
303         [Qt] editing/input/emacs-ctrl-o.html
304
305         ctrl-o is bound to a sequence of commands on Mac, namely:
306         insertParagraphSeparator then moveLeft. In the DRT, we just interpret
307         ctrl-o in EventSenderQt as '\n', i.e. insertParagraphSeparator. As a
308         result we only issue one command, so don't generate the change in caret
309         position that results in the extra editing delegate messages.
310
311         So for the sake of not managing suspicious-looking differences, just
312         make DRT issue the appropriate edit commands to pass the test.
313
314         https://bugs.webkit.org/show_bug.cgi?id=47548
315
316         * DumpRenderTree/qt/EventSenderQt.cpp:
317         (EventSender::keyDown):
318
319 2010-10-12  Anders Carlsson  <andersca@apple.com>
320
321         Reviewed by Sam Weinig.
322
323         Add a simple Find UI to MiniBrowser
324         https://bugs.webkit.org/show_bug.cgi?id=47553
325
326         * MiniBrowser/mac/BrowserWindow.xib:
327         Add Find panel.
328
329         * MiniBrowser/mac/BrowserWindowController.h:
330         * MiniBrowser/mac/BrowserWindowController.m:
331         (-[BrowserWindowController performFindPanelAction:]):
332         Show the find panel.
333
334         (-[BrowserWindowController find:]):
335         Tell the WKPageRef to find the given string.
336
337 2010-10-12  Tony Chang  <tony@chromium.org>
338
339         Unreviewed, fixing DRT compile on Windows after r69586.
340
341         * DumpRenderTree/chromium/WebThemeEngineDRT.h:
342
343 2010-10-12  Tony Chang  <tony@chromium.org>
344
345         Unreviewed, trying to fix NRWT on Windows.
346
347         * Scripts/webkitpy/layout_tests/port/http_lock.py:
348
349 2010-10-12  Balazs Kelemen  <kbalazs@webkit.org>
350
351         Reviewed by Kenneth Rohde Christiansen.
352
353         [Qt][WTR] Checking the path of the injected bundle is bogus
354         https://bugs.webkit.org/show_bug.cgi?id=47541
355
356         * WebKitTestRunner/qt/TestControllerQt.cpp:
357         (WTR::isExistingLibrary): Added (static helper).
358         Extend the path with the appropriate suffix(es) on the
359         platform and check that the file exists.
360         (WTR::TestController::initializeInjectedBundlePath):
361         There were two bugs with the path checking:
362             - the condition should have been inverted
363             - QLibrary::fileName does not give back the filename
364               with the library suffix so we cannot check
365               that existance of the file this way.
366
367 2010-10-12  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
368
369         Reviewed by Tony Chang.
370
371         Implement http locking in NRWT.
372         https://bugs.webkit.org/show_bug.cgi?id=47072
373
374         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
375         * Scripts/webkitpy/layout_tests/port/base.py:
376         * Scripts/webkitpy/layout_tests/port/http_lock.py: Added.
377         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py: Added.
378         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
379
380 2010-10-12  Mark Rowe  <mrowe@apple.com>
381
382         Fix the 32-bit WebKit2 build.
383
384         * MiniBrowser/mac/BrowserWindowController.m:
385         (getWindowFrame): Use NSRect rather than CGRect since that's what -frame returns.
386         (setWindowFrame): Use NSMakeRect rather than CGRectMake since that's what -setFrame:display: expects.
387
388 2010-10-11  Tony Chang  <tony@chromium.org>
389
390         Reviewed by Adam Barth.
391
392         change the order of mrobinson's email addresses so bugs.webkit.org suggests the right one
393         https://bugs.webkit.org/show_bug.cgi?id=47513
394
395         bugs.webkit.org suggests mrobinson@igalia.com as an autocomplete,
396         which doesn't actually work.
397
398         * Scripts/webkitpy/common/config/committers.py:
399
400 2010-10-11  Prasad Tammana  <prasadt@chromium.org>
401
402         Reviewed by Dmitry Titov.
403
404         Added support for showModalDialog on chromium port.
405
406         Implement showModalDialog for Layout tests for chromium port
407         https://bugs.webkit.org/show_bug.cgi?id=46759
408
409         * DumpRenderTree/chromium/WebViewHost.cpp:
410         (WebViewHost::closeWidgetSoon): Quit current message loop if in a modal loop.
411         (WebViewHost::runModal):  Start a nested message loop and remember that.
412         (WebViewHost::WebViewHost):  Initialize m_inModalLoop.
413         * DumpRenderTree/chromium/WebViewHost.h:  Add m_inModalLoop.
414
415 2010-10-11  Martin Robinson  <mrobinson@igalia.com>
416
417         Reviewed by Gustavo Noronha Silva.
418
419         [GTK] Cleanup font selection code for the Freetype backend
420         https://bugs.webkit.org/show_bug.cgi?id=47503
421
422         Update DRT to set values for the cursive and fantasy font families, so
423         that we can generate consistent results for tests that use these families.
424         Add some missing information to fonts.conf.
425
426         * DumpRenderTree/gtk/DumpRenderTree.cpp:
427         (resetDefaultsToConsistentValues): Always set the fantasy and cursive font
428         family names.
429         * DumpRenderTree/gtk/fonts/fonts.conf: Add aliases for cursive and fantasy fonts
430         to our default serif font. Eventually we may want to import or require some "real"
431         fonts, but this should at least ensure consistent rendering during test runs. Also
432         add aliases for some other commonly used fonts in tests (Arial and Lucida Grande).
433         Finally, add a missing oblique specification for DejaVu Serif, which was resulting
434         in some incorrect baselines for the synthetic oblique test.
435
436 2010-10-11  Adam Barth  <abarth@webkit.org>
437
438         Unreviewed.
439
440         Fix sheriffbot not to crash when there are failing tests.  It turns out
441         Python sets don't support the + operator.  We need to use union
442         instead.  There's a more elegant way to do this in Python 2.6, but we
443         need this code to work in 2.5.
444
445         * Scripts/webkitpy/common/net/failuremap.py:
446         * Scripts/webkitpy/common/net/failuremap_unittest.py:
447
448 2010-10-10  Robert Hogan  <robert@webkit.org>
449
450         Unreviewed, fix failing test from r69468.
451
452         [Qt] Put all DRT-created pages in a page group
453
454         Fix on r69468.
455
456         Because we don't delete closed pages immediately in DRT we need
457         to remove them from the page group explicitly instead.
458
459         Fixes failure of fast/events/popup-blocked-from-fake-user-gesture.html
460
461         https://bugs.webkit.org/show_bug.cgi?id=47469
462
463         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
464         (WebCore::DumpRenderTree::windowCloseRequested):
465
466 2010-10-10  Leandro Pereira  <leandro@profusion.mobi>
467
468         Reviewed by Adam Barth.
469
470         commit-queue: Add EFL-EWS status bubble to Bugzilla, now that the
471         EFL-EWS bot is up and running.
472         https://bugs.webkit.org/show_bug.cgi?id=47277
473
474         * QueueStatusServer/handlers/statusbubble.py:
475
476 2010-10-10  Robert Hogan  <robert@webkit.org>
477
478         Reviewed by Antonio Gomes.
479
480         [Qt] Put all DRT-created pages in a page group
481
482         https://bugs.webkit.org/show_bug.cgi?id=47469
483
484         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
485         (WebCore::DumpRenderTree::DumpRenderTree):
486         (WebCore::DumpRenderTree::createWindow):
487
488 2010-10-09  Sam Weinig  <sam@webkit.org>
489
490         Reviewed by Dan Bernstein.
491
492         WKFrameGetFrameLoadState() returns kWKFrameLoadStateCommitted after the load has been stopped
493         <rdar://problem/8173667>
494         https://bugs.webkit.org/show_bug.cgi?id=47461
495
496         * TestWebKitAPI/PlatformUtilities.h:
497         * TestWebKitAPI/Test.h:
498         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
499         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp: Added.
500         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
501         (TestWebKitAPI::TEST):
502         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
503         (TestWebKitAPI::Util::URLForNonExistentResource):
504         Adds a test for the frame load state after a failed provisional load. I wanted to test
505         the frame load state after a committed load failed, but I don't believe that is possible
506         to do without hooking up the http server to serve a long loading page.
507
508 2010-10-09  Sam Weinig  <sam@webkit.org>
509
510         Reviewed by Dan Bernstein.
511
512         Add WebKit2 version of runBeforeUnloadConfirmPanelWithMessage
513         <rdar://problem/8447690>
514         https://bugs.webkit.org/show_bug.cgi?id=47459
515
516         * MiniBrowser/mac/BrowserWindowController.m:
517         (runBeforeUnloadConfirmPanel):
518         (-[BrowserWindowController awakeFromNib]):
519         * WebKitTestRunner/TestController.cpp:
520         (WTR::createOtherPage):
521         (WTR::TestController::initialize):
522
523 2010-10-09  Sam Weinig  <sam@webkit.org>
524
525         Reviewed by Dan Bernstein.
526
527         Need implementation of ChromeClient windowRect related functions.
528         <rdar://problem/8469476>
529         https://bugs.webkit.org/show_bug.cgi?id=47386
530
531         * MiniBrowser/mac/BrowserWindowController.m:
532         (getWindowFrame):
533         (setWindowFrame):
534         (-[BrowserWindowController awakeFromNib]):
535         * WebKitTestRunner/PlatformWebView.h:
536         * WebKitTestRunner/TestController.cpp:
537         (WTR::TestController::initialize):
538         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
539         (WTR::PlatformWebView::windowFrame):
540         (WTR::PlatformWebView::setWindowFrame):
541         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
542         (WTR::PlatformWebView::windowFrame):
543         (WTR::PlatformWebView::setWindowFrame):
544         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
545         (WTR::PlatformWebView::windowFrame):
546         (WTR::PlatformWebView::setWindowFrame):
547
548 2010-10-08  Adam Barth  <abarth@webkit.org>
549
550         Unreviewed (Eric is on vacation in this change is trivial).
551
552         Add a "clean" command to webkit-patch to clean the working directory
553         https://bugs.webkit.org/show_bug.cgi?id=47436
554
555         This command is useful when using SVN because "svn revert" leaves
556         unversioned files behind.
557
558         * Scripts/webkitpy/tool/commands/download.py:
559
560 2010-10-08  Andras Becsi  <abecsi@webkit.org>
561
562         Unreviewed build fix.
563
564         [Qt] Add missing limits.h include since the Qt version currently
565         ran on the bot does need that.
566
567         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
568
569 2010-10-08  Balazs Kelemen  <kbalazs@webkit.org>
570
571         Reviewed by Csaba Osztrogonác.
572
573         [Qt] Turn on building WTR
574         https://bugs.webkit.org/show_bug.cgi?id=47349
575
576         * Scripts/webkitdirs.pm:
577
578 2010-10-08  Balazs Kelemen  <kbalazs@webkit.org>
579
580         Reviewed by Andreas Kling.
581
582         [Qt] TestController needs its platform dependent methods
583         https://bugs.webkit.org/show_bug.cgi?id=47413
584
585         * WebKitTestRunner/qt/TestControllerQt.cpp:
586         (WTR::TestController::initializeInjectedBundlePath):
587         If the WTR_INJECTEDBUNDLE_PATH environmental variable is
588         set then use that otherwise use the path where the bundle
589         lives in a normal trunk build.
590         (WTR::TestController::initializeTestPluginDirectory):
591         Set the bundle's value. It is not used currently.
592         (WTR::TestController::platformInitializeContext):
593         * WebKitTestRunner/qt/WebKitTestRunner.pro:
594
595 2010-10-08  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
596
597         Reviewed by Kenneth Rohde Christiansen.
598
599         WTR: Prevent sending the Done message twice on test timeout.
600         https://bugs.webkit.org/show_bug.cgi?id=47410
601
602         When InjectedBundle::done() calls stopLoading, this may trigger
603         InjectedBundlePage::didFailLoadWithErrorForFrame which calls
604         InjectedBundle::done() itself later in the stack.
605         This would output the timeout failure message twice and confuse
606         the run-webkit-tests script.
607
608         This patch adds a third state, Stopping, which prevents WebCore
609         errors to trigger done() when testing is over.
610
611         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
612         (WTR::InjectedBundle::done):
613         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
614
615 2010-10-08  Andras Becsi  <abecsi@webkit.org>
616
617         Reviewed by Kenneth Rohde Christiansen.
618
619         [Qt] Add an activateFonts() implementation similar to DRT's initializeFonts().
620         Original code by Simon Hausmann.
621         https://bugs.webkit.org/show_bug.cgi?id=47402
622
623         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: Added.
624         (WTR::activateFonts):
625
626 2010-10-08  Andras Becsi  <abecsi@webkit.org>
627
628         Reviewed by Csaba Osztrogonác.
629
630         [Qt] Add support for Qt's WebKitTestRunner to old-run-webkit-tests.
631         https://bugs.webkit.org/show_bug.cgi?id=47401
632
633         * Scripts/build-webkittestrunner:
634         * Scripts/old-run-webkit-tests:
635
636 2010-10-07  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
637
638         Reviewed by Kenneth Rohde Christiansen.
639
640         [Qt] WTR first compile: fix compile issues.
641         https://bugs.webkit.org/show_bug.cgi?id=47343
642
643         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
644         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
645         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
646         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
647         * WebKitTestRunner/TestController.cpp:
648         * WebKitTestRunner/TestInvocation.cpp:
649
650 2010-10-07  Antonio Gomes  <agomes@rim.com>
651
652         Reviewed by Simon Fraser.
653
654         [Mac] [DRT] implement setSpatialNavigationEnabled
655         https://bugs.webkit.org/show_bug.cgi?id=47291
656
657         Implemented LayoutTestController::setSpatialNavigationEnabled for Mac's DRT
658         so it can track regression on the existing implementation and future improvements
659         we are making.
660
661         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
662         (LayoutTestController::setSpatialNavigationEnabled):
663
664 2010-10-07  Dirk Pranke  <dpranke@chromium.org>
665
666         Reviewed by Adam Barth.
667
668         rebaseline-chromium-webkit-tests relied on the filename_to_uri()
669         hook in the Port infrastructure to generate URIs for the files
670         in its summary HTML report; however, that method is supposed to only
671         be used for test files (and should really be renamed), so this would
672         crash.
673
674         This change adds a new "path" module to the system package with a
675         routine called abspath_to_uri() that handles converting paths to
676         file: URIs independently of anything in the layout_tests package,
677         and changes the code to use this. At some point in the near future
678         the layout_tests/port/* code should use this as well.
679
680         This change also deletes a bunch of unused code and fixes some
681         comments in rebaseline_chromium_webkit_tests.py.
682
683         https://bugs.webkit.org/show_bug.cgi?id=47319
684
685         * Scripts/webkitpy/common/system/path.py: Added.
686         * Scripts/webkitpy/common/system/path_unittest.py: Added.
687         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
688         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
689
690 2010-10-07  Martin Robinson  <mrobinson@igalia.com>
691
692         Reviewed by Gustavo Noronha Silva.
693
694         [GTK] The FreeType backend does not respect the FC_EMBOLDEN property
695         https://bugs.webkit.org/show_bug.cgi?id=46216
696
697         Fix my latest commit, as it contained some bad changes from a merge gone wrong.
698
699         * DumpRenderTree/gtk/DumpRenderTree.cpp:
700         (initializeFonts): Also initialize the DevaVu Sans font.
701
702 2010-10-07  Daniel Cheng  <dcheng@chromium.org>
703
704         Reviewed by Tony Chang.
705
706         [chromium] Minor naming cleanup in WebDragData, part 2
707         https://bugs.webkit.org/show_bug.cgi?id=47227
708
709         Update DRT to use the renamed methods.
710
711         * DumpRenderTree/chromium/EventSender.cpp:
712         (EventSender::beginDragWithFiles):
713         * DumpRenderTree/chromium/WebViewHost.cpp:
714         (addDRTFakeFileToDataObject):
715
716 2010-10-07  Anders Carlsson  <andersca@apple.com>
717
718         Reviewed by Sam Weinig.
719
720         Add a WKPageFindClient, hook up WKPageCountStringMatches
721         https://bugs.webkit.org/show_bug.cgi?id=47373
722
723         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
724         Remove hard coded paths.
725
726         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
727         (TestWebKitAPI::TEST):
728         Fix expected result.
729
730         * TestWebKitAPI/Tests/WebKit2/Find.cpp: Added.
731         (TestWebKitAPI::didFinishLoadForFrame):
732         (TestWebKitAPI::didCountStringMatches):
733         (TestWebKitAPI::TEST):
734         * TestWebKitAPI/Tests/WebKit2/find.html: Added.
735         Add test for WKPageCountStringMatches.
736
737 2010-09-21  Martin Robinson  <mrobinson@igalia.com>
738
739         Reviewed by Chris Fleizach.
740
741         [GTK] The FreeType backend does not respect the FC_EMBOLDEN property
742         https://bugs.webkit.org/show_bug.cgi?id=46216
743
744         * DumpRenderTree/gtk/fonts/fonts.conf: Add a setting which enables FC_EMBOLDEN
745         for DejaVu Serif when there is no bold version available. This is necessary to
746         properly test the property in layout tests.
747
748 2010-10-07  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>, Andras Becsi  <abecsi@webkit.org>, Balazs Kelemen  <kbalazs@webkit.org>
749
750         Reviewed by Kenneth Rohde Christiansen.
751
752         [Qt] Add WTR's InjectedBundle build files.
753         https://bugs.webkit.org/show_bug.cgi?id=47333
754
755         * Scripts/webkitdirs.pm:
756         * WebKitTestRunner/DerivedSources.pro: Added.
757         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Added.
758         * WebKitTestRunner/WebKitTestRunner.pro: Added.
759         * WebKitTestRunner/qt/DerivedSources.pro: Removed.
760         Content merged in ../DerivedSources.pro
761
762 2010-10-07  Sheriff Bot  <webkit.review.bot@gmail.com>
763
764         Unreviewed, rolling out r69315.
765         http://trac.webkit.org/changeset/69315
766         https://bugs.webkit.org/show_bug.cgi?id=47363
767
768         Forgot to add the new files (Requested by kbalazs on #webkit).
769
770         * Scripts/webkitdirs.pm:
771         * WebKitTestRunner/qt/DerivedSources.pro: Added.
772
773 2010-10-07  Sam Weinig  <sam@webkit.org>
774
775         Reviewed by Anders Carlsson.
776
777         Change API tester to ask the executable for the list of all
778         tests instead of relying on the directory structure.
779         https://bugs.webkit.org/show_bug.cgi?id=47359
780
781         * Scripts/run-test-webkit-api: Added.
782         * Scripts/webkitdirs.pm:
783         Add additional script to just launch the api tester with the correct settings.
784
785         * Scripts/run-api-tests:
786         Change to use the new --dump-tests options to build the list of tests and change
787         output to reflect a (suite, testcase) tuple for each test. Also adds some color.
788
789         * TestWebKitAPI/Test.h:
790         (TestWebKitAPI::Test::Register::Register):
791         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
792         (TestWebKitAPI::TEST):
793         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
794         (TestWebKitAPI::TEST):
795         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
796         (TestWebKitAPI::TEST):
797         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
798         (TestWebKitAPI::TEST):
799         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
800         (TestWebKitAPI::TEST):
801         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
802         (TestWebKitAPI::TEST):
803         Give each test a suite name in addition to the test name.
804
805         * TestWebKitAPI/TestsController.cpp:
806         (TestWebKitAPI::TestsController::dumpTestNames):
807         (TestWebKitAPI::TestsController::runTestNamed):
808         * TestWebKitAPI/TestsController.h:
809         * TestWebKitAPI/mac/main.mm:
810         (main):
811         Add option to print all registered tests.
812
813 2010-10-07  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>, Andras Becsi  <abecsi@webkit.org>, Balazs Kelemen  <kbalazs@webkit.org>
814
815         Reviewed by Kenneth Rohde Christiansen.
816
817         [Qt] Add WTR's InjectedBundle build files.
818         https://bugs.webkit.org/show_bug.cgi?id=47333
819
820         * Scripts/webkitdirs.pm:
821         * WebKitTestRunner/DerivedSources.pro: Added.
822         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Added.
823         * WebKitTestRunner/WebKitTestRunner.pro: Added.
824         * WebKitTestRunner/qt/DerivedSources.pro: Removed.
825         Content merged in ../DerivedSources.pro
826
827 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
828
829         Unreviewed. Do a renaming that was recommended by the reviewer
830         (Kenneth) but I forgot to do before landing (http://trac.webkit.org/changeset/69253)
831
832         * WebKitTestRunner/qt/TestControllerQt.cpp:
833         (WTR::RunUntilConditionLoop::start):
834         (WTR::RunUntilConditionLoop::RunUntilConditionLoop):
835         (WTR::TestController::runUntil):
836
837 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
838
839         Reviewed by Kenneth Rohde Christiansen.
840
841         [Qt] Watchdog timer implementation for WTR
842         https://bugs.webkit.org/show_bug.cgi?id=47337
843
844         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Factor out
845         the definition of the timer type to a typedef.
846         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp: Added.
847         Timer implementation with QTimer and a helper QObject class.
848         (WTR::WatchdogTimerHelper::instance):
849         (WTR::WatchdogTimerHelper::timerFired):
850         (WTR::WatchdogTimerHelper::WatchdogTimerHelper):
851         (WTR::LayoutTestController::platformInitialize):
852         (WTR::LayoutTestController::invalidateWaitToDumpWatchdogTimer):
853         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
854
855 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
856
857         Unreviewed buildfix for 69297 again
858
859         * WebKitTestRunner/TestController.cpp:
860         (WTR::blankURL):
861
862 2010-10-07  Balazs Kelemen  <Balazs Kelemen>
863
864         Unreviewed trivial build fix for r69297
865
866         * WebKitTestRunner/TestController.cpp:
867         (WTR::blankURL):
868
869 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
870
871         Reviewed by Kenneth Rohde Christiansen.
872
873         WebKitTestRunner should be portable
874         https://bugs.webkit.org/show_bug.cgi?id=45393
875
876         Use only the WebKit API for working with urls.
877         * WebKitTestRunner/StringFunctions.h:
878         (WTR::createWKURL):
879         * WebKitTestRunner/TestController.cpp:
880         (WTR::blankURL):
881         (WTR::TestController::resetStateToConsistentValues):
882         (WTR::TestController::didFinishLoadForFrame):
883
884 2010-10-07  Carlos Garcia Campos  <cgarcia@igalia.com>
885
886         Reviewed by Xan Lopez.
887
888         [GTK] Use gtk_widget_draw() instead of gtk_widget_get_snapshot() in PixelDumpSupportGtk when building with gtk3
889         https://bugs.webkit.org/show_bug.cgi?id=47332
890
891         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
892         (createBitmapContextFromWebView):
893
894 2010-10-06  Chris Guillory  <chris.guillory@google.com>
895
896         Reviewed by Chris Fleizach.
897
898         Remove unused accessibility functions from webkit.
899         https://bugs.webkit.org/attachment.cgi?bugid=46707
900
901         * DumpRenderTree/chromium/WebViewHost.cpp:
902         (WebViewHost::postAccessibilityNotification):
903         * DumpRenderTree/chromium/WebViewHost.h:
904
905 2010-10-06  Lucas Forschler  <lforschler@apple.com>
906
907         Reviewed by Adam Roben.
908
909         Fix the sunspider-compare-results to actually use the passed in value for $root.
910
911         * Scripts/sunspider-compare-results:
912
913 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
914
915         Reviewed by Kenneth Rohde Christiansen.
916
917         [Qt] Runloop implementation for WTR
918         https://bugs.webkit.org/show_bug.cgi?id=47280
919
920         * WebKitTestRunner/qt/TestControllerQt.cpp:
921         Implemented TestController::runUntil by a timerEvent
922         and a QEventLoop. We step into the event loop from runUntil.
923         While we are waiting in the loop a timerEvent is periodically
924         checking the value of the condition. Once the condition has
925         becoming true the timerEvent wakes us up.
926         (WTR::RunUntilLoop::start):
927         (WTR::RunUntilLoop::RunUntilLoop):
928         (WTR::RunUntilLoop::run):
929         (WTR::RunUntilLoop::timerEvent):
930         (WTR::TestController::platformInitialize):
931         (WTR::TestController::runUntil):
932         * WebKitTestRunner/qt/main.cpp:
933         Start the main event loop first and creating the TestController later.
934         (Launcher::Launcher):
935         (Launcher::~Launcher):
936         (Launcher::launch): Creating the TestController.
937         (main): Setting up a timer for calling Launcher::launch from
938         the main event loop.
939
940 2010-10-06  Dirk Pranke  <dpranke@chromium.org>
941
942         Reviewed by Kenneth Russell.
943
944         new-run-webkit-tests: fix typo in chromium-gpu that was trying to
945         enable 'accelerated-composting' instead of 'accelerated-compositing'.
946
947         https://bugs.webkit.org/show_bug.cgi?id=47312
948
949         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
950         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
951
952 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
953
954         Reviewed by Kenneth Rohde Christiansen.
955
956         [Qt] PlatformWebView implementation for WebKitTestRunner
957         https://bugs.webkit.org/show_bug.cgi?id=47276
958
959         The implementation follows the way how
960         we use the API in MiniBrowser.
961         * WebKitTestRunner/PlatformWebView.h:
962         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
963         (WTR::WebView::wkView):
964         (WTR::WebView::~WebView):
965         (WTR::WebView::WebView):
966         (WTR::PlatformWebView::PlatformWebView):
967         (WTR::PlatformWebView::~PlatformWebView):
968         (WTR::PlatformWebView::resizeTo):
969         (WTR::PlatformWebView::page):
970         (WTR::PlatformWebView::focus):
971         * WebKitTestRunner/qt/WebKitTestRunner.pro:
972
973 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
974
975         Reviewed by Kenneth Rohde Christiansen.
976
977         [Qt] Add WebKitTestRunner's build files
978         https://bugs.webkit.org/show_bug.cgi?id=44155
979
980         Parts was taken by Zoltan Horvath's patch.
981
982         * Scripts/generate-forwarding-headers.pl: Moved from WebKit2.
983         * Scripts/webkitdirs.pm: Make the generated files needed by WTR.
984         * WebKitTestRunner/PlatformWebView.h: Addeed typedefs for
985         PlatformWKView and PlatformWindow (void* for now).
986         Buildfix the case when __APPLE__ is not defined.
987         * WebKitTestRunner/qt/DerivedSources.pro: Added.
988         * WebKitTestRunner/qt/PlatformWebViewQt.cpp: Added.
989         Empty stub implementation.
990         (WTR::registerWindowClass):
991         (WTR::PlatformWebView::PlatformWebView):
992         (WTR::PlatformWebView::~PlatformWebView):
993         (WTR::PlatformWebView::resizeTo):
994         (WTR::PlatformWebView::page):
995         (WTR::PlatformWebView::focus):
996         * WebKitTestRunner/qt/TestControllerQt.cpp: Added.
997         Empty stub implementation.
998         (WTR::registerWindowClass):
999         (WTR::TestController::runUntil):
1000         (WTR::TestController::platformInitialize):
1001         (WTR::TestController::initializeInjectedBundlePath):
1002         (WTR::TestController::initializeTestPluginDirectory):
1003         (WTR::TestController::platformInitializeContext):
1004         * WebKitTestRunner/qt/WebKitTestRunner.pro: Added.
1005         * WebKitTestRunner/qt/main.cpp: Added.
1006         (main):
1007
1008 2010-10-06  Tony Chang  <tony@chromium.org>
1009
1010         Unreviewed, rolling out r69202.
1011         http://trac.webkit.org/changeset/69202
1012         https://bugs.webkit.org/show_bug.cgi?id=46937
1013
1014         Broke compile of test_shell
1015
1016         * DumpRenderTree/chromium/EventSender.cpp:
1017         (EventSender::beginDragWithFiles):
1018         * DumpRenderTree/chromium/WebViewHost.cpp:
1019         (addDRTFakeFileToDataObject):
1020
1021 2010-10-06  Daniel Cheng  <dcheng@chromium.org>
1022
1023         Reviewed by Tony Chang.
1024
1025         [chromium] Minor naming cleanup in WebDragData, part 2
1026         https://bugs.webkit.org/show_bug.cgi?id=46937
1027
1028         Update DRT to use the renamed methods.
1029
1030         * DumpRenderTree/chromium/EventSender.cpp:
1031         (EventSender::beginDragWithFiles):
1032         * DumpRenderTree/chromium/WebViewHost.cpp:
1033         (addDRTFakeFileToDataObject):
1034
1035 2010-10-06  David Kilzer  <ddkilzer@apple.com>
1036
1037         <http://webkit.org/b/47270> Move WebArchive serialization code into its own file
1038
1039         Reviewed by Adam Roben.
1040
1041         This is the first step in making webarchive tests work on
1042         Windows.
1043
1044         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added
1045         new files to the project.
1046         * DumpRenderTree/mac/DumpRenderTree.mm: Removed code that moved
1047         to WebArchiveDumpSupport.mm.
1048         * DumpRenderTree/mac/WebArchiveDumpSupport.h: Added.
1049         * DumpRenderTree/mac/WebArchiveDumpSupport.mm: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm.
1050         (serializeWebArchiveToXML):
1051
1052 2010-10-05  Daniel Bates  <dbates@rim.com>
1053
1054         Reviewed by David Kilzer.
1055
1056         Add infrastructure to towards detecting change log diffs that aren't at the top of the ChangeLog
1057         https://bugs.webkit.org/show_bug.cgi?id=46058
1058
1059         Make VCSUtils::fixChangeLogPatch() return a reference to a hash
1060         structure so as to support returning additional information
1061         about a change log diff.
1062
1063         Currently, VCSUtils::fixChangeLogPatch() returns a string that
1064         represents the change log diff. Towards supporting the return
1065         of additional information, such as whether the change log diff
1066         inserts an entry at the top of the ChangeLog file, we need to
1067         make VCSUtils::fixChangeLogPatch() return a reference to hash
1068         structure.
1069
1070         * Scripts/VCSUtils.pm:
1071           - Modified fixChangeLogPatch() to return a reference to a
1072             hash structure.
1073           - Added documentation to fixChangeLogPatch().
1074           - Modified call site in mergeChangeLogs() as necessary.
1075         * Scripts/svn-apply:
1076           - Modified call site in patch() as necessary.
1077         * Scripts/svn-create-patch:
1078           - Modified call site in generateDiff() as necessary.
1079         * Scripts/svn-unapply:
1080           - Modified call site in patch() as necessary.
1081         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
1082           - Modified the unit tests as necessary.
1083
1084 2010-10-05  Tony Chang  <tony@chromium.org>
1085
1086         Reviewed by Darin Adler.
1087
1088         fix the link to the expected image on windows
1089         https://bugs.webkit.org/show_bug.cgi?id=47228
1090
1091         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: On
1092             windows, the file must be opened in binary mode when writing
1093             binary data.
1094
1095 2010-10-05  Adam Barth  <abarth@webkit.org>
1096
1097         Update expected result of unittest to match Tony's change below.
1098
1099         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1100
1101 2010-10-05  Tony Chang  <tony@chromium.org>
1102
1103         Reviewed by Ojan Vafai (over the shoulder).
1104
1105         Paper over errors in image_diff so we don't crash the whole test run.
1106
1107         * Scripts/webkitpy/layout_tests/port/chromium.py:
1108
1109 2010-10-05  Tony Chang  <tony@chromium.org>
1110
1111         Unreviewed, make shutil.rmtree more resiliant to errors
1112         since windows was raising WindowsError: The process cannot access the file because it
1113         is being used by another process.
1114
1115         * Scripts/webkitpy/layout_tests/port/chromium.py:
1116
1117 2010-10-05  Tony Chang  <tony@chromium.org>
1118
1119         Reviewed by Ojan Vafai.
1120
1121         [chromium] fix image diffing in NRWT
1122         https://bugs.webkit.org/show_bug.cgi?id=47128
1123
1124         * Scripts/webkitpy/layout_tests/port/chromium.py: Stop using
1125             NamedTemporaryFile since it doesn't work on Windows.
1126         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1127
1128 2010-10-05  Kenneth Russell  <kbr@google.com>
1129
1130         Reviewed by Tony Chang.
1131
1132         [chromium] Implement layerTreeAsText in DumpRenderTree
1133         https://bugs.webkit.org/show_bug.cgi?id=47216
1134
1135         Plumbed Frame::layerTreeAsText through Chromium's WebKit API to
1136         make it callable from DumpRenderTree.
1137
1138         No new tests; verified with existing compositor layout tests.
1139
1140         * DumpRenderTree/chromium/LayoutTestController.cpp:
1141         (LayoutTestController::LayoutTestController):
1142         (LayoutTestController::layerTreeAsText):
1143         * DumpRenderTree/chromium/LayoutTestController.h:
1144
1145 2010-10-05  Brent Fulgham  <bfulgham@webkit.org>
1146
1147         Unreviewed build correction.
1148
1149         * DumpRenderTree/win/ImageDiff.vcproj: Use WinCairo debug
1150         property sheet so proper libraries are linked.
1151
1152 2010-10-05  Robert Hogan  <robert@webkit.org>
1153
1154         Reviewed by Andreas Kling.
1155
1156         [Qt] Fix url conversion in QWebHistory
1157
1158         Converting from KURL to WFT::String to QUrl does not
1159         permit proper percent encoding later.
1160
1161         https://bugs.webkit.org/show_bug.cgi?id=47048
1162
1163         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1164         (WebCore::dumpHistoryItem):
1165
1166 2010-10-05  Anders Carlsson  <andersca@apple.com>
1167
1168         Reviewed by Sam Weinig.
1169
1170         REGRESSION (r68966?): All dumpAsText test fail on WebKit2
1171         https://bugs.webkit.org/show_bug.cgi?id=47188
1172         <rdar://problem/8514104>
1173
1174         When constructing the std::string, use the real string length instead of the maximum buffer size.
1175
1176         * TestWebKitAPI/PlatformUtilities.h:
1177         (TestWebKitAPI::Util::toSTD):
1178         * WebKitTestRunner/StringFunctions.h:
1179         (WTR::toSTD):
1180
1181 2010-10-04  Sam Weinig  <sam@webkit.org>
1182
1183         Reviewed by Mark Rowe.
1184
1185         Add MIMEType accessor to WKFrame
1186         <rdar://problem/8347683>
1187         https://bugs.webkit.org/show_bug.cgi?id=47138
1188
1189         * TestWebKitAPI/PlatformUtilities.h:
1190         (TestWebKitAPI::Util::toSTD):
1191         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1192         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp: Added.
1193         (TestWebKitAPI::didStartProvisionalLoadForFrame):
1194         (TestWebKitAPI::didCommitLoadForFrame):
1195         (TestWebKitAPI::didFinishLoadForFrame):
1196         (TestWebKitAPI::TEST):
1197         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp: Added.
1198         (TestWebKitAPI::didStartProvisionalLoadForFrame):
1199         (TestWebKitAPI::didCommitLoadForFrame):
1200         (TestWebKitAPI::didFinishLoadForFrame):
1201         (TestWebKitAPI::TEST):
1202         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1203         (TestWebKitAPI::TEST):
1204         * TestWebKitAPI/Tests/WebKit2/basic-1.html: Removed.
1205         * TestWebKitAPI/Tests/WebKit2/icon.png: Added.
1206         * TestWebKitAPI/Tests/WebKit2/simple.html: Added.
1207         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1208         (TestWebKitAPI::Util::createURLForResource):
1209
1210 2010-10-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1211
1212         Reviewed by Ojan Vafai.
1213
1214         [NRWT] Rename current_dir to current_group because it's not a directory
1215         https://bugs.webkit.org/show_bug.cgi?id=47169
1216
1217         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1218         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1219
1220 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
1221
1222         Unreviewed, build fix.
1223
1224         r69065 broke test-webkitpy by trying to create a '/tmp-X' directory,
1225         which can't always be done. This test uses tempfile.mkdtemp(), which
1226         should be safe.
1227
1228         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1229
1230 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
1231
1232         Unreviewed, build fix.
1233
1234         Add missing "from __future__ import with_statement" that was
1235         breaking test-webkitpy on the Leopard bots (broke in r69040).
1236
1237         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1238
1239 2010-10-04  Sheriff Bot  <webkit.review.bot@gmail.com>
1240
1241         Unreviewed, rolling out r69066.
1242         http://trac.webkit.org/changeset/69066
1243         https://bugs.webkit.org/show_bug.cgi?id=47163
1244
1245         Made NRWT reliability worse. (Requested by tkent on #webkit).
1246
1247         * Scripts/webkitpy/layout_tests/port/chromium.py:
1248         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1249
1250 2010-10-04  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1251
1252         Reviewed by Tony Chang.
1253
1254         [NRWT] Reverse the http tests to alphabetical order.
1255         https://bugs.webkit.org/show_bug.cgi?id=47075
1256
1257         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1258
1259 2010-10-04  Robert Hogan  <robert@webkit.org>
1260
1261         Reviewed by Andreas Kling.
1262
1263         [Qt] Fix timeout on http/tests/navigation/post-goback2.html and postredirect-goback2.html
1264
1265         We need to queue back and forward navigations in the DRT from the
1266         LayoutTestController so that maybeDump() knows about them.
1267
1268         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1269         (LayoutTestController::queueBackNavigation):
1270         (LayoutTestController::queueForwardNavigation):
1271
1272 2010-10-04  Tony Chang  <tony@chromium.org>
1273
1274         Reviewed by Kent Tamura.
1275
1276         [chromium] fix image diffing in NRWT
1277         https://bugs.webkit.org/show_bug.cgi?id=47128
1278
1279         * Scripts/webkitpy/layout_tests/port/chromium.py: Flush data to the
1280               temp file and check the image_diff error code more carefully
1281         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1282
1283 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
1284
1285         Reviewed by Adam Barth.
1286
1287         aroben's change in r68792 actually broke new-run-webkit-tests when
1288         running the DRT code path. His change was intended to fix the
1289         way we were converting windows paths to URIs when running under
1290         Cygwin (the paths were getting one too many "/" on the front).
1291         However, the change ended up breaking the chromium_win port, which
1292         had slightly different logic.
1293
1294         This patch removes the port-specific code and adds tests to make
1295         sure we're getting the behavior we expect. The Port object no longer
1296         exposes a get_absolute_path() method that can be used outside of
1297         of converting test filenames, because it's unreliable otherwise
1298         (we don't have the right context to know which conversion is intended).
1299
1300         https://bugs.webkit.org/show_bug.cgi?id=47140
1301
1302         * Scripts/webkitpy/layout_tests/port/base.py:
1303         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1304         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1305         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1306         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1307
1308 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
1309
1310         Unreviewed, build fix.
1311
1312         Handle crash introduced in r69040 if we are not running in a
1313         Chromium checkout.
1314
1315         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1316
1317 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
1318
1319         Reviewed by Tony Chang.
1320
1321         Add a way for us to have test expectations that are specific to the
1322         official builds of Google Chrome (as opposed to Chromium). This change
1323         looks for an additional "test_expectations_chrome.txt" file in
1324         Chromium's repository (webkit/tools/layout_tests), and uses the
1325         concatenation of that file and the regular test_expectations.txt
1326         file for test overrides.
1327
1328         https://bugs.webkit.org/show_bug.cgi?id=46854
1329
1330         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1331         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1332
1333 2010-10-04  Simon Fraser  <simon.fraser@apple.com>
1334
1335         Color tests in the list based on existing pass/fail result.
1336         
1337         Fix the summary data to account for htmlOnly and nonHTML tests.
1338
1339         * CSSTestSuiteHarness/harness/harness.css:
1340         (#test-list > option.pass):
1341         (#test-list > option.fail):
1342         (#test-list > option.skipped):
1343         * CSSTestSuiteHarness/harness/harness.js:
1344         (Test):
1345         (Test.prototype.statusForFormat):
1346         (TestSuite.prototype.fillTestList):
1347         (TestSuite.prototype.updateTestList):
1348         (TestSuite.prototype.recordResult):
1349         (TestSuite.prototype.markTestCompleted):
1350         (TestSuite.prototype.countTestsWithFlag):
1351         (TestSuite.prototype.queryDatabaseForSummary.this.db.transaction):
1352         (TestSuite.prototype.queryDatabaseForSummary):
1353
1354 2010-10-04  Chris Fleizach  <cfleizach@apple.com>
1355
1356         Reviewed by Beth Dakin.
1357
1358         AX: doAXRangeForLine does not work
1359         https://bugs.webkit.org/show_bug.cgi?id=47101
1360
1361         DRT support to handle NSAccessibilityRangeForLineParameterizedAttribute.
1362
1363         * DumpRenderTree/AccessibilityUIElement.cpp:
1364         (rangeForLineCallback):
1365         (AccessibilityUIElement::rangeForLine):
1366         (AccessibilityUIElement::getJSClass):
1367         * DumpRenderTree/AccessibilityUIElement.h:
1368         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1369         (AccessibilityUIElement::rangeForLine):
1370
1371 2010-10-04  Andrey Kosyakov  <caseq@chromium.org>
1372
1373         Unreviewed. Adding myself to the committers list.
1374
1375         * Scripts/webkitpy/common/config/committers.py:
1376
1377 2010-10-04  Sam Weinig  <sam@webkit.org>
1378
1379         Reviewed by Anders Carlsson.
1380
1381         Add ability to set the CacheModel in Webkit2
1382         https://bugs.webkit.org/show_bug.cgi?id=47066
1383
1384         * MiniBrowser/mac/AppDelegate.m:
1385         (-[BrowserAppDelegate init]): Opt minibrowser into
1386         a PrimaryWebBrowser cache model.
1387
1388 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
1389
1390         Make sure to enter all tests when creating the database
1391         for the first time.
1392         
1393         When migrating to a new version of the suite, be sure to
1394         sync up the database and testinfo.data by removing old
1395         tests, and inserting new ones.
1396
1397         * CSSTestSuiteHarness/harness/harness.js:
1398         (TestSuite.prototype.openDatabase.creation):
1399         (TestSuite.prototype.databaseCreated):
1400         (TestSuite.prototype.populateDatabaseFromTestInfoData):
1401         (TestSuite.prototype.insertTest):
1402
1403 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
1404
1405         More work on treating HTML4 and XHTML1 independently; when 
1406         changing the format, rebuild the test list, and update the 
1407         numbers in the chapter popup.
1408
1409         * CSSTestSuiteHarness/harness/harness.js:
1410         (Test):
1411         (Test.prototype.runForFormat):
1412         (Test.prototype.completedForFormat):
1413         (ChapterSection):
1414         (ChapterSection.prototype.countTests):
1415         (Chapter):
1416         (Chapter.prototype.description):
1417         (Chapter.prototype.countTests):
1418         (Chapter.prototype.testCount):
1419         (Chapter.prototype.untestedCount):
1420         (TestSuite.prototype.buildChapters):
1421         (TestSuite.prototype.loadCurrentTest):
1422         (TestSuite.prototype.updateProgressLabel):
1423         (TestSuite.prototype.processFlags):
1424         (TestSuite.prototype.formatChanged):
1425
1426 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
1427
1428         Update test suite version 20101001.
1429         
1430         Handle database migration, and delete tests from the db that are
1431         not present in testinfo.data.
1432         
1433         Load about:blank into the test frame before the test url, to make
1434         missing tests more obvious.
1435         
1436         * CSSTestSuiteHarness/harness/harness.js:
1437         (TestSuite.prototype.loadTest):
1438         (TestSuite.prototype.openDatabase.creation):
1439         (TestSuite.prototype.openDatabase.migration1_0To1_1):
1440         (TestSuite.prototype.openDatabase.if.return):
1441         (TestSuite.prototype.databaseReady):
1442         (TestSuite.prototype.populateDatabaseFromTestInfoData):
1443         (TestSuite.prototype.syncDatabaseWithTestInfoData.this.db.transaction):
1444         (TestSuite.prototype.syncDatabaseWithTestInfoData):
1445
1446 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
1447
1448         Add the ability to jump to a specific test.
1449
1450         * CSSTestSuiteHarness/harness/harness.html:
1451         * CSSTestSuiteHarness/harness/harness.js:
1452         (TestSuite.prototype.goToTestByName):
1453         (TestSuite.prototype.switchToFormat):
1454
1455 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
1456
1457         For a ref test, load the ref in the same format (HTML4 vs XHTML1)
1458         as the test.
1459
1460         * CSSTestSuiteHarness/harness/harness.js:
1461         (TestSuite.prototype.loadRef):
1462
1463 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
1464
1465         Update the UI to reflect the fact that each test needs to be tested
1466         in both HTML4 and XHTML1 format.
1467         
1468         * CSSTestSuiteHarness/harness/harness.js:
1469         (Test):
1470         (Chapter.prototype.description):
1471         (Chapter.prototype.untestedCount):
1472         (TestSuite.prototype.fillChapterPopup):
1473         (TestSuite.prototype.updateChapterPopup):
1474         (TestSuite.prototype.fillTestList):
1475         (TestSuite.prototype.updateTestList):
1476         (TestSuite.prototype.goToNextIncompleteTest):
1477         (TestSuite.prototype.firstIncompleteTestIndex):
1478         (TestSuite.prototype.recordResult):
1479         (TestSuite.prototype.formatChanged):
1480         (TestSuite.prototype.markTestCompleted):
1481         (TestSuite.prototype.resetTestStatus):
1482
1483 2010-10-01  Simon Fraser  <simon.fraser@apple.com>
1484
1485         Add the ability to remove results for re-testing, and
1486         to import results.
1487
1488         * CSSTestSuiteHarness/harness/harness.css:
1489         (.custom button):
1490         (#overlay):
1491         (#overlay.visible):
1492         (.overlay-contents):
1493         (.overlay-contents textarea):
1494         (.overlay-contents .buttons):
1495         (.overlay-contents .note):
1496         (.overlay-contents .buttons button):
1497         * CSSTestSuiteHarness/harness/harness.html:
1498         * CSSTestSuiteHarness/harness/harness.js:
1499         (TestSuite.prototype.importResults):
1500         (TestSuite.prototype.clearResults):
1501         (TestSuite.prototype.markTestCompleted):
1502         (TestSuite.prototype.resetTestStatus):
1503         (TestSuite.prototype.storeTestResult):
1504         (TestSuite.prototype.importTestResults):
1505         (TestSuite.prototype.clearTestResults):
1506
1507 2010-10-01  Sam Weinig  <sam@webkit.org>
1508
1509         Reviewed by Jon Honeycutt.
1510
1511         Deploy the new WKString functions to remove most uses of CF from
1512         the WebKitTestRunner.
1513
1514         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1515         (WTR::InjectedBundle::didReceiveMessage):
1516         (WTR::InjectedBundle::done):
1517         * WebKitTestRunner/StringFunctions.h:
1518         (WTR::toWK):
1519         (WTR::toJS):
1520         (WTR::toSTD):
1521         (WTR::operator<<):
1522         (WTR::copyURLString):
1523         * WebKitTestRunner/TestController.cpp:
1524         (WTR::TestController::resetStateToConsistentValues):
1525         (WTR::TestController::didFinishLoadForFrame):
1526         * WebKitTestRunner/TestInvocation.cpp:
1527         (WTR::TestInvocation::invoke):
1528         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1529
1530 2010-10-01  Mihai Parparita  <mihaip@chromium.org>
1531
1532         Unreviewed TestResultsServer change.
1533
1534         Add files introduced by http://crrev.com/61273 to the list of dashboard 
1535         files to update.
1536
1537         * TestResultServer/handlers/dashboardhandler.py:
1538
1539 2010-10-01  Brian Weinstein  <bweinstein@apple.com>
1540
1541         Build Fix for Windows.
1542
1543         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Don't copy ForwardingHeaders from
1544             WebKitTestRunner/ForwardingHeaders, instead, add $(WebKitOutputDir)/include/WebCore/
1545             ForwardingHeaders to the include path.
1546
1547 2010-10-01  Sam Weinig  <sam@webkit.org>
1548
1549         Reviewed by Anders Carlsson.
1550
1551         Add SPI to convert a WKStringRef to a JSStringRef and vice-versa.
1552
1553         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1554         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
1555         (TestWebKitAPI::TEST):
1556         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp: Added.
1557         (TestWebKitAPI::TEST):
1558
1559 2010-10-01  Sam Weinig  <sam@webkit.org>
1560
1561         Reviewed by Kenneth Rohde Christiansen.
1562
1563         Add additional WKString API
1564         https://bugs.webkit.org/show_bug.cgi?id=46958
1565
1566         Add basic WKStringRef tests.
1567
1568         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1569         * TestWebKitAPI/Tests/WebKit2/WKString.cpp: Added.
1570
1571 2010-10-01  Sam Weinig  <sam@webkit.org>
1572
1573         Reviewed by Dan Bernstein.
1574
1575         Add makefile for TestWebKitAPI and call it from the base makefile.
1576
1577         * Makefile:
1578         * TestWebKitAPI/Makefile: Added.
1579
1580 2010-10-01  Sam Weinig  <sam@webkit.org>
1581
1582         Reviewed by Adam Roben.
1583
1584         Remove unnecessary ForwardingHeaders from test runners.
1585         https://bugs.webkit.org/show_bug.cgi?id=47010
1586
1587         * TestWebKitAPI/Configurations/Base.xcconfig:
1588         * TestWebKitAPI/ForwardingHeaders: Removed.
1589         * WebKitTestRunner/Configurations/Base.xcconfig:
1590         * WebKitTestRunner/ForwardingHeaders: Removed.
1591
1592 2010-09-30  Adam Barth  <abarth@webkit.org>
1593
1594         Reviewed by Eric Seidel.
1595
1596         WebSocket tests are flaky
1597         https://bugs.webkit.org/show_bug.cgi?id=46956
1598
1599         Update these tools to understand how to run the WebSocket tests off the
1600         Apache server.
1601
1602         * Scripts/old-run-webkit-tests:
1603         * Scripts/webkitpy/layout_tests/port/base.py:
1604         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1605         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1606
1607 2010-10-01  Adam Roben  <aroben@apple.com>
1608
1609         Encode Executive command arguments using UTF-8 on Cygwin
1610
1611         Cygwin's Python's os.execv doesn't support unicode command arguments.
1612         Cygwin's execv expects arguments to be encoded using the current code
1613         page. But code pages are limited in what characters they can handle,
1614         and our tests include characters that the English code page can't
1615         handle.  So for now we'll just encode everything in UTF-8 on Cygwin,
1616         which can handle all characters but might confuse some commands, for
1617         expediency's sake. I'm sure we'll run into cases where UTF-8 isn't
1618         good enough, but we can deal with that when the problem arises.
1619
1620         Reviewed by Adam Barth.
1621
1622         Fixes <http://webkit.org/b/46892> <rdar://problem/8496639>
1623         webkitpy.common.system.executive_unittest.ExecutiveTest.test_run_command_with_unicode
1624         fails on Windows
1625
1626         * Scripts/webkitpy/common/system/executive.py:
1627         (Executive._run_command_with_teed_output):
1628         (Executive.run_command):
1629         On Cygwin, encode arguments using UTF-8.
1630
1631 2010-10-01  Sam Weinig  <sam@webkit.org>
1632
1633         Reviewed by Adam Roben.
1634
1635         Add simple API tester for WebKit2
1636         https://bugs.webkit.org/show_bug.cgi?id=46953
1637
1638         This adds a very simple testing infrastructure for testing APIs exposed
1639         through the WebKit project. It consists of two parts: 1) a project that
1640         builds the all the tests 2) a script that searches the tests directory and
1641         calls the tester once for each test.
1642
1643         This adds the infrastructure and two tests:
1644         - Tests/WTF/Vector1.cpp - A proof of concept test of WTF data-structures.
1645         - Tests/WebKit2/BasicTest1.cpp - A proof of concept test of WebKit2 API.
1646
1647         This currently only works on the mac, but is designed to be easily ported 
1648         to any platform.
1649
1650         * Scripts/run-api-tests: Added.
1651         * Scripts/build-api-tests: Added.
1652         Scripts to build/run the tests.
1653
1654         * TestWebKitAPI: Added.
1655         * TestWebKitAPI/Configurations: Added.
1656         * TestWebKitAPI/Configurations/Base.xcconfig: Added.
1657         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Added.
1658         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Added.
1659         * TestWebKitAPI/ForwardingHeaders: Added.
1660         * TestWebKitAPI/ForwardingHeaders/wtf: Added.
1661         * TestWebKitAPI/PlatformUtilities.h: Added.
1662         * TestWebKitAPI/PlatformWebView.h: Added.
1663         (TestWebKitAPI::PlatformWebView::platformView):
1664         * TestWebKitAPI/StringFunctions.h: Added.
1665         * TestWebKitAPI/Test.h: Added.
1666         (TestWebKitAPI::Test::~Test):
1667         (TestWebKitAPI::Test::name):
1668         (TestWebKitAPI::Test::Register::Register):
1669         (TestWebKitAPI::Test::Register::create):
1670         (TestWebKitAPI::Test::Test):
1671         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Added.
1672         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added.
1673         * TestWebKitAPI/TestWebKitAPIPrefix.h: Added.
1674         * TestWebKitAPI/TestsController.cpp: Added.
1675         (TestWebKitAPI::TestsController::shared):
1676         (TestWebKitAPI::TestsController::TestsController):
1677         (TestWebKitAPI::TestsController::runTestNamed):
1678         (TestWebKitAPI::TestsController::testFailed):
1679         (TestWebKitAPI::TestsController::registerCreateTestFunction):
1680         * TestWebKitAPI/TestsController.h: Added.
1681         * TestWebKitAPI/mac: Added.
1682         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm: Added.
1683         (TestWebKitAPI::Util::run):
1684         (TestWebKitAPI::Util::createURLForResource):
1685         * TestWebKitAPI/mac/PlatformWebViewMac.mm: Added.
1686         (TestWebKitAPI::PlatformWebView::PlatformWebView):
1687         (TestWebKitAPI::PlatformWebView::resizeTo):
1688         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
1689         (TestWebKitAPI::PlatformWebView::page):
1690         (TestWebKitAPI::PlatformWebView::focus):
1691         * TestWebKitAPI/mac/main.mm: Added.
1692         Infrastructure.
1693
1694         * TestWebKitAPI/Tests: Added.
1695         * TestWebKitAPI/Tests/WTF: Added.
1696         * TestWebKitAPI/Tests/WTF/Vector1.cpp: Added.
1697         * TestWebKitAPI/Tests/WebKit2: Added.
1698         * TestWebKitAPI/Tests/WebKit2/BasicTest1.cpp: Added.
1699         (TestWebKitAPI::State::State):
1700         * TestWebKitAPI/Tests/WebKit2/basic-1.html: Added.
1701         Proof of concept tests.
1702
1703 2010-10-01  Adam Roben  <aroben@apple.com>
1704
1705         Don't assume AccessibleObjectFromEvent succeeds
1706
1707         Fixes <http://webkit.org/b/44136> <rdar://problem/8321684> Crash in
1708         DumpRenderTree!notificationListenerProc when running
1709         plugins/access-after-page-destroyed.html
1710
1711         Reviewed by Sam Weinig.
1712
1713         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1714         (notificationListenerProc): Check both the return value of
1715         AccessibleObjectFromEvent and the object it returns, as MSDN
1716         recommends.
1717
1718 2010-10-01  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1719
1720         Reviewed by Tony Chang.
1721
1722         [NRWT] Put the http and websocket tests first in the test list.
1723         https://bugs.webkit.org/show_bug.cgi?id=46453
1724
1725         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1726         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1727
1728 2010-10-01  Fady Samuel  <fsamuel@chromium.org>
1729
1730         Unreviewed, adding myself to the committer list.
1731
1732         * Scripts/webkitpy/common/config/committers.py:
1733
1734 2010-10-01  Adam Roben  <aroben@apple.com>
1735
1736         Test NPN_GetValue(NPNVnetscapeWindow)
1737
1738         Test for <http://webkit.org/b/46726> <rdar://problem/8486319>
1739         Right-clicking on windowless Flash plugin in WebKit2 makes a context
1740         menu appear in the bottom-right corner of the screen
1741
1742         Reviewed by Anders Carlsson.
1743
1744         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1745         (PluginTest::NPN_GetValue): Added. Calls through to the browser.
1746
1747         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added NPN_GetValue.
1748
1749         * DumpRenderTree/TestNetscapePlugIn/Tests/win/GetValueNetscapeWindow.cpp: Added.
1750         (GetValueNetscapeWindow::GetValueNetscapeWindow): Initialize members.
1751         (GetValueNetscapeWindow::NPP_SetWindow): Test that
1752         NPN_GetValue(NPNVnetscapeWindow) returns a valid HWND and that it
1753         isn't our HWND.
1754
1755         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1756         Added GetValueNetscapeWindow.
1757
1758 2010-10-01  Andreas Kling  <andreas.kling@nokia.com>
1759
1760         Unreviewed, adding my webkit.org identity to reviewer list.
1761
1762         * Scripts/webkitpy/common/config/committers.py:
1763
1764 2010-09-30  Adam Barth  <abarth@webkit.org>
1765
1766         Reviewed by Eric Seidel.
1767
1768         The WebSocket server should flush its logs
1769         https://bugs.webkit.org/show_bug.cgi?id=46946
1770
1771         The WebSocket server logs are truncated because the driver just
1772         terminates the child.  It should run Python without buffering so we can
1773         see the end of the log.
1774
1775         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1776
1777 2010-09-30  Simon Fraser  <simon.fraser@apple.com>
1778
1779         Add a button to jump to the next untested test.
1780         
1781         * CSSTestSuiteHarness/harness/harness.css:
1782         (.test-type):
1783         (.name > button):
1784         * CSSTestSuiteHarness/harness/harness.html:
1785         * CSSTestSuiteHarness/harness/harness.js:
1786         (Chapter.prototype.description):
1787         (Chapter.prototype.untestedCount):
1788         (TestSuite.prototype.testInfoDataLoaded):
1789         (TestSuite.prototype.fillChapterPopup):
1790         (TestSuite.prototype.updateChapterPopup):
1791         (TestSuite.prototype.buildTestListForChapter):
1792         (TestSuite.prototype.goToNextIncompleteTest):
1793         (TestSuite.prototype.firstIncompleteTestIndex):
1794         (TestSuite.prototype.testCompletionStateChanged):
1795
1796 2010-09-29  Jon Honeycutt  <jhoneycutt@apple.com>
1797
1798         WebKit2 on Windows should use Windows fonts for the various standard
1799         font families
1800         https://bugs.webkit.org/show_bug.cgi?id=43499
1801         <rdar://problem/8272758>
1802
1803         Reviewed by Adam Roben.
1804
1805         * WebKitTestRunner/TestController.cpp:
1806         (WTR::TestController::resetStateToConsistentValues):
1807         Use the Mac fonts for running tests. This matches DRT behavior.
1808
1809 2010-09-30  Adam Barth  <abarth@webkit.org>
1810
1811         Third attempt.  We need a better integration test environment.
1812
1813         * Scripts/webkitpy/common/net/failuremap.py:
1814         * Scripts/webkitpy/common/net/failuremap_unittest.py:
1815
1816 2010-09-30  Robert Hogan  <robert@webkit.org>
1817
1818         Reviewed by Andreas Kling.
1819
1820         [Qt] Support for PlainTextController
1821
1822         Unskip editing/text-iterator/basic-iteration.html
1823
1824         https://bugs.webkit.org/show_bug.cgi?id=38805
1825
1826         * DumpRenderTree/qt/DumpRenderTree.pro:
1827         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1828         (WebCore::DumpRenderTree::DumpRenderTree):
1829         (WebCore::DumpRenderTree::initJSObjects):
1830         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1831         * DumpRenderTree/qt/PlainTextControllerQt.cpp: Added.
1832         (PlainTextController::PlainTextController):
1833         (PlainTextController::plainText):
1834         * DumpRenderTree/qt/PlainTextControllerQt.h: Added.
1835
1836 2010-09-30  Adam Barth  <abarth@webkit.org>
1837
1838         Unreviewed.  Second attempt to fix sheriffbot.
1839
1840         * Scripts/webkitpy/common/net/buildbot.py:
1841
1842 2010-09-30  Adam Barth  <abarth@webkit.org>
1843
1844         Unreviewed.
1845
1846         This patch should stop the sheriffbot from throwing an exception.
1847
1848         * Scripts/webkitpy/common/net/buildbot.py:
1849
1850 2010-09-30  Brian Weinstein  <bweinstein@apple.com>
1851
1852         Reviewed by Adam Roben.
1853
1854         The same bots shouldn't run both Windows Debug Tests and Windows Release Tests.
1855         https://bugs.webkit.org/show_bug.cgi?id=46926
1856
1857         * BuildSlaveSupport/build.webkit.org-config/config.json: Have two bots running Windows 
1858             Release Tests, and two bots running Windows Debug Tests, instead of four running both.
1859
1860 2010-09-30  Adam Barth  <abarth@webkit.org>
1861
1862         Reviewed by Eric Seidel.
1863
1864         webkit-patch find-flaky-tests should print results URLs
1865         https://bugs.webkit.org/show_bug.cgi?id=46917
1866
1867         Printing out the results URL makes find-flaky-tests more actionable
1868         because you can see what happens when a test fails.  The output from
1869         the script is still pretty noisy, but it seems useful.
1870
1871         * Scripts/webkitpy/tool/commands/queries.py:
1872
1873 2010-09-30  Chris Marrin  <cmarrin@apple.com>
1874
1875         Reviewed by Simon Fraser.
1876
1877         Make 2D accelerated canvas rendering build on Mac
1878         https://bugs.webkit.org/show_bug.cgi?id=46007
1879         
1880         Added ACCELERATED_2D_CANVAS to build-webkit
1881
1882         * Scripts/build-webkit:
1883
1884 2010-09-29  Kenneth Russell  <kbr@google.com>
1885
1886         Reviewed by Dimitri Glazkov.
1887
1888         [chromium] Add accelerated compositing support to DumpRenderTree and test_shell
1889         https://bugs.webkit.org/show_bug.cgi?id=46849
1890
1891         Added offscreen code path for WebGraphicsContext3DDefaultImpl which
1892         works with the compositor integration in both DumpRenderTree and
1893         test_shell, since both pass a non-null WebCanvas* to WebViewImpl::paint
1894         and thereby trigger the compositor's readback code path. Added support
1895         for --enable-accelerated-compositing to DumpRenderTree.
1896
1897         Tested in both test_shell and DumpRenderTree on Linux, the latter by
1898         modifying a compositing layout test, dumping the pixels and verifying
1899         that they matched the output when the compositor was active.
1900
1901         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1902         (main):
1903         * DumpRenderTree/chromium/TestShell.cpp:
1904         (TestShell::TestShell):
1905         (TestShell::resetWebSettings):
1906         * DumpRenderTree/chromium/TestShell.h:
1907         (TestShell::setAcceleratedCompositingEnabled):
1908         * DumpRenderTree/chromium/WebPreferences.cpp:
1909         (WebPreferences::reset):
1910         (WebPreferences::applyTo):
1911         * DumpRenderTree/chromium/WebPreferences.h:
1912         * DumpRenderTree/chromium/WebViewHost.cpp:
1913         (WebViewHost::scheduleComposite):
1914         * DumpRenderTree/chromium/WebViewHost.h:
1915
1916 2010-09-30  Adam Roben  <aroben@apple.com>
1917
1918         Ensure that QueueEngine cleans up its log files when its delegate
1919         tells it to stop processing work
1920
1921         Reviewed by Adam Barth.
1922
1923         Fixes <http://webkit.org/b/46891> <rdar://problem/8496638> Many tests
1924         in webkitpy.tool.bot.queueengine_unittest.QueueEngineTest crash on
1925         Windows
1926
1927         * Scripts/webkitpy/tool/bot/queueengine.py:
1928         (QueueEngine.run): Stop ourselves normally (including cleaning up log
1929         files) when the delegate tells us to stop processing work.
1930
1931         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1932         (LoggingDelegate.__init__): Moved code here from
1933         RaisingDelegate.__init__.
1934         (LoggingDelegate.expeced_callbacks): Added the stop_work_queue
1935         callback.
1936         (LoggingDelegate.stop_work_queue): Moved here from RaisingDelegate.
1937         (RaisingDelegate.__init__): Removed code that LoggingDelegate takes
1938         care of for us now.
1939         (QueueEngineTest.test_trivial): Make sure we got the expected stop
1940         message.
1941         (QueueEngineTest.test_not_safe_to_proceed): Changed to explicitly
1942         remove the callbacks that are related to processing a single work
1943         item, rather than removing all callbacks after a certain point, as
1944         there are now more callbacks we expect to receive at the end.
1945
1946 2010-09-30  Adam Roben  <aroben@apple.com>
1947
1948         Fix path -> URL conversion on Cygwin
1949
1950         Reviewed by Adam Barth.
1951
1952         Fixes <http://webkit.org/b/46890> <rdar://problem/8496637> Many tests
1953         in webkitpy.layout_tests.run_webkit_tests_unittest assert on Windows
1954
1955         * Scripts/webkitpy/layout_tests/port/base.py:
1956         (Port.filename_to_uri): Treat Cygwin like other UNIX-y platforms by
1957         assuming paths already have a leading slash.
1958
1959 2010-09-30  Adam Roben  <aroben@apple.com>
1960
1961         Teach WindowGeometryInitializedBeforeSetWindow that NPP_SetWindow can
1962         be called more than once
1963
1964         The NPP_SetWindow call made when the plugin is torn down was confusing
1965         us, and was causing us to spew an error into the next test.
1966
1967         Fixes <http://webkit.org/b/46900> <rdar://problem/8496888> REGRESSION
1968         (r68520): plugins/access-after-page-destroyed.html failing on Windows
1969
1970         Reviewed by Anders Carlsson.
1971
1972         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:
1973         (WindowGeometryInitializedBeforeSetWindow::WindowGeometryInitializedBeforeSetWindow):
1974         Initialize member.
1975         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Bail if
1976         this isn't the first time this is called.
1977
1978 2010-09-30  Eric Seidel  <eric@webkit.org>
1979
1980         Reviewed by Adam Barth.
1981
1982         webkit-patch upload warns that I'm using Xcode when I'm not
1983         https://bugs.webkit.org/show_bug.cgi?id=46869
1984
1985         String.find returns -1 when not found, so switched to "in".
1986
1987         * Scripts/webkitpy/common/system/user.py:
1988         * Scripts/webkitpy/common/system/user_unittest.py:
1989
1990 2010-09-30  Eric Seidel  <eric@webkit.org>
1991
1992         Reviewed by Adam Barth.
1993
1994         webkit-patch failure-reason dies if non-trunk commits are in the blame range
1995         https://bugs.webkit.org/show_bug.cgi?id=46866
1996
1997         I also made failure-reason use RegressionWindow in a cleaner way.
1998
1999         * Scripts/webkitpy/tool/commands/queries.py:
2000
2001 2010-09-29  Adam Barth  <abarth@webkit.org>
2002
2003         Reviewed by Eric Seidel.
2004
2005         webkit-patch find-flaky-tests
2006         https://bugs.webkit.org/show_bug.cgi?id=46876
2007
2008         This command helps us find flaky tests so we can squash them.
2009
2010         * Scripts/webkitpy/tool/commands/queries.py:
2011
2012 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
2013
2014         Fix export to use '?' instead of 'null' for
2015         tests with no results.
2016         
2017         * CSSTestSuiteHarness/harness/harness.js:
2018
2019 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
2020
2021         Add a warning when a test requires special steps.
2022         Add a Print Preview button for 'paged' tests that
2023         brings up the print dialog, allowing the user to 
2024         judge paged media tests.
2025
2026         * CSSTestSuiteHarness/harness/harness.css:
2027         * CSSTestSuiteHarness/harness/harness.html:
2028         * CSSTestSuiteHarness/harness/harness.js:
2029         (TestSuite.prototype.loadTest):
2030         (TestSuite.prototype.processFlags):
2031
2032 2010-09-29  Adam Barth  <abarth@webkit.org>
2033
2034         Reviewed by Eric Seidel.
2035
2036         Remove revisions_casuing_failures
2037         https://bugs.webkit.org/show_bug.cgi?id=46872
2038
2039         This function exists only to be unit tested.
2040
2041         * Scripts/webkitpy/common/net/failuremap.py:
2042         * Scripts/webkitpy/common/net/failuremap_unittest.py:
2043         * Scripts/webkitpy/tool/mocktool.py:
2044
2045 2010-09-29  Adam Barth  <abarth@webkit.org>
2046
2047         Reviewed by Eric Seidel.
2048
2049         SheriffBot should post the list of failing tests to bugs
2050         https://bugs.webkit.org/show_bug.cgi?id=46871
2051
2052         * Scripts/webkitpy/common/net/buildbot.py:
2053         * Scripts/webkitpy/common/net/failuremap.py:
2054         * Scripts/webkitpy/common/net/regressionwindow.py:
2055         * Scripts/webkitpy/tool/bot/sheriff.py:
2056         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
2057         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2058         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2059         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2060         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2061         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2062         * Scripts/webkitpy/tool/mocktool.py:
2063
2064 2010-09-29  Brent Fulgham  <bfulgham@webkit.org>
2065
2066         Reviewed by Martin Robinson, Eric Seidel, and Mark Rowe.
2067
2068         [WinCairo] Adds a build slave.
2069         https://bugs.webkit.org/show_bug.cgi?id=46360
2070
2071         * BuildSlaveSupport/build.webkit.org-config/config.json: Add
2072         entries for a debug build of the WinCairo port.
2073         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add
2074         platform flag to configuration for wincairo (like gtk, chromium, etc.)
2075         * Scripts/build-webkit: Change 'cairo-win32' labeling to 'wincairo'
2076         * Scripts/webkitdirs.pm: Change 'cairo-win32' labeling to 'wincairo'
2077
2078 2010-09-29  Adam Barth  <abarth@webkit.org>
2079
2080         Reviewed by Eric Seidel.
2081
2082         Move more SheriffBot smarts into FailureMap
2083         https://bugs.webkit.org/show_bug.cgi?id=46703
2084
2085         This patch pushes the FailureMap model object further into the
2086         SheriffBot machine.  In addition, it moves a couple operations on this
2087         object from SheriffBot itself to the model.
2088
2089         Eventually, FailureMap will be the canonical context object for
2090         SheriffBot operations.  FailureMap represents a map of the current
2091         failures on the bots that might require remediation.
2092
2093         * Scripts/webkitpy/common/net/failuremap.py:
2094         * Scripts/webkitpy/common/net/regressionwindow.py:
2095         * Scripts/webkitpy/tool/commands/queries.py:
2096         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2097         * Scripts/webkitpy/tool/mocktool.py:
2098
2099 2010-09-29  Tony Chang  <tony@chromium.org>
2100
2101         Reviewed by James Robinson.
2102
2103         [chromium] enable -Werror for DRT and webkit_unit_tests on Linux
2104         https://bugs.webkit.org/show_bug.cgi?id=46829
2105
2106         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
2107         (DRTDevToolsClient::DRTDevToolsClient):
2108         * DumpRenderTree/chromium/TestShell.cpp:
2109         (TestShell::TestShell):
2110         * DumpRenderTree/chromium/WebViewHost.cpp:
2111         (WebViewHost::postAccessibilityNotification):
2112         (WebViewHost::WebViewHost):
2113
2114 2010-09-29  Chris Fleizach  <cfleizach@apple.com>
2115
2116         Reviewed by Darin Adler.
2117
2118         AX: implement CSS3 Speech "speak"
2119         https://bugs.webkit.org/show_bug.cgi?id=46827
2120
2121         * DumpRenderTree/AccessibilityUIElement.cpp:
2122         (speakCallback):
2123         (AccessibilityUIElement::speak):
2124         (AccessibilityUIElement::getJSClass):
2125         * DumpRenderTree/AccessibilityUIElement.h:
2126         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2127         (AccessibilityUIElement::speak):
2128
2129 2010-09-29  Mihai Parparita  <mihaip@chromium.org>
2130
2131         Reviewed by Adam Barth.
2132
2133         Record bot ID when updating queue status
2134         https://bugs.webkit.org/show_bug.cgi?id=46764
2135         
2136         Since we now have multiple bots handling patches from the commit queue,
2137         we need to differentiate status updates from them, so that we can group
2138         the queue status page in a less confusing way.
2139
2140         * QueueStatusServer/handlers/updatestatus.py: Accept bot_id as input
2141         * QueueStatusServer/model/queuestatus.py: Add bot_id property
2142         * QueueStatusServer/templates/updatestatus.html: Add bot_id input
2143         * Scripts/webkitpy/common/net/bugzilla_unittest.py: Extract MockBrowser
2144         * Scripts/webkitpy/common/net/statusserver.py: Add bot_id
2145         * Scripts/webkitpy/common/net/statusserver_unittest.py: Added.
2146         * Scripts/webkitpy/tool/main.py: Add --bot-id
2147         * Scripts/webkitpy/tool/mocktool.py: Add MockBrowser
2148
2149 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
2150
2151         No review.
2152         
2153         References always refert to a file in .xht format, even
2154         for HTML tests, so fix their loading.
2155
2156         * CSSTestSuiteHarness/harness/harness.js:
2157         (TestSuite.prototype.loadRef):
2158
2159 2010-09-28  Johnny Ding  <jnd@chromium.org>
2160
2161         Reviewed by Adam Barth.
2162
2163         https://bugs.webkit.org/show_bug.cgi?id=41292
2164         Add a new parameter to the test plugin to allow specifying a script 
2165         and a mouse/keyboard event. The specified script will be evaluated
2166         in the browser when the specified event is received by the plugin.
2167
2168         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2169         (pluginAllocate):
2170         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
2171         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2172         (NPP_New):
2173         (handleEventCarbon):
2174         (handleEventCocoa):
2175
2176 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
2177
2178         Fix export by adding missing argument.
2179
2180         * CSSTestSuiteHarness/harness/harness.js:
2181         (TestSuite.prototype.showResultsForAllTests):
2182
2183 2010-09-28  Kevin Ollivier  <kevino@theolliviers.com>
2184
2185         [wx] Build fix, add missing import.
2186
2187         * wx/packaging/build-win-installer.py:
2188
2189 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
2190
2191         No review
2192         
2193         Show which tests have been run by dimming them out in the test list.
2194         
2195         Adjust some element sizes.
2196         
2197         * CSSTestSuiteHarness/harness/harness.css:
2198         (#test-list > option.untested):
2199         (#test-list > option.completed):
2200         (#output):
2201         (.output-options):
2202         * CSSTestSuiteHarness/harness/harness.js:
2203         (Test):
2204         (TestSuite.prototype.fillTestList):
2205         (TestSuite.prototype.updateTestList):
2206         (TestSuite.prototype.setSelectedChapter):
2207         (TestSuite.prototype.recordResult):
2208         (TestSuite.prototype.markTestCompleted):
2209         (TestSuite.prototype.testCompletionStateChanged):
2210         (TestSuite.prototype.loadTestStatus):
2211
2212 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
2213
2214         No review.
2215         
2216         Implement export of various queries on the test database, sharing
2217         code with that which displays results inline.
2218
2219         * CSSTestSuiteHarness/harness/harness.js:
2220         ():
2221         (TestSuite.prototype.exportResultsCompletion.var):
2222         (TestSuite.prototype.exportResultsCompletion):
2223         (TestSuite.prototype.showResultsForCompletedTests):
2224         (TestSuite.prototype.exportResultsForCompletedTests):
2225         (TestSuite.prototype.showResultsForAllTests):
2226         (TestSuite.prototype.exportResultsForAllTests):
2227         (TestSuite.prototype.exportResultsForTestsNotRun):
2228         (TestSuite.prototype.exportResultsForTestsWithStatus):
2229         (TestSuite.prototype.exportResultsForTestsWithMismatchedResults):
2230
2231 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
2232
2233         No review.
2234
2235         Work around uncertainty about the order of database
2236         transactions when creating the database, so that we don't
2237         try to query the table before it has been created.
2238
2239         * CSSTestSuiteHarness/harness/harness.js:
2240         (TestSuite):
2241         (TestSuite.prototype.databaseCreated):
2242         (TestSuite.prototype.storeTestResult):
2243         (TestSuite.prototype.populateDatabaseFromTestInfoData):
2244         (TestSuite.prototype.queryDatabaseForTestsWithStatus):
2245         (TestSuite.prototype.queryDatabaseForTestsWithMixedStatus):
2246         (TestSuite.prototype.queryDatabaseForCompletedTests):
2247         (TestSuite.prototype.queryDatabaseForTestsNotRun):
2248
2249 2010-09-28  Tony Chang  <tony@chromium.org>
2250
2251         Reviewed by Eric Seidel.
2252
2253         add python keyring support to webkit-patch
2254         https://bugs.webkit.org/show_bug.cgi?id=41269
2255
2256         * Scripts/webkitpy/common/net/credentials.py: Add the ability to read passwords using
2257             the python keyring module
2258         * Scripts/webkitpy/common/net/credentials_unittest.py:
2259         * Scripts/webkitpy/common/system/user.py: Allow confirm() to default to no and add testing params.
2260         * Scripts/webkitpy/common/system/user_unittest.py:
2261         * Scripts/webkitpy/tool/mocktool.py:
2262
2263 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
2264
2265         Reviewed by Gustavo Noronha Silva.
2266
2267         [Cairo] FreeType fonts should obey FontConfig hinting/anti-aliasing settings
2268         https://bugs.webkit.org/show_bug.cgi?id=46740
2269
2270         * DumpRenderTree/gtk/fonts/fonts.conf: Add specialized variants of common
2271         fonts which can be used to fully test FontConfig rendering settings.
2272
2273 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
2274
2275         Reviewed by Gustavo Noronha Silva.
2276
2277         [gtk] Fedora has a different path for the liberation fonts
2278         https://bugs.webkit.org/show_bug.cgi?id=46709
2279
2280         When searching for DRT fonts, also look in the path where those fonts
2281         are commonly found on Fedora systems.
2282
2283         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2284         (initializeFonts): Include logic for looking for Fedora-style font paths.
2285
2286 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
2287
2288         Reviewed by Andreas Kling.
2289
2290         run-webkit-tests needs an updated list of directories with webgl tests
2291         https://bugs.webkit.org/show_bug.cgi?id=46747
2292
2293         Update the list of directories containing WebGL tests and a unit test
2294         which depends on this list.
2295
2296         * Scripts/old-run-webkit-tests: Update the list of directories.
2297         * Scripts/webkitpy/layout_tests/port/webkit.py: Ditto.
2298         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Update the expected result.
2299
2300 2010-09-28  Adam Barth  <abarth@webkit.org>
2301
2302         Reviewed by Eric Seidel.
2303
2304         Introduce FailureMap to summaries the failures status of all the bots
2305         https://bugs.webkit.org/show_bug.cgi?id=46700
2306
2307         This patch gives the SheriffBot a handle on the list of failing tests.
2308
2309         * Scripts/webkitpy/common/net/buildbot.py:
2310         * Scripts/webkitpy/common/net/failuremap.py: Added.
2311         * Scripts/webkitpy/tool/commands/queries.py:
2312         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2313         * Scripts/webkitpy/tool/mocktool.py:
2314
2315 2010-09-28  Adam Roben  <aroben@apple.com>
2316
2317         Update for the addition of WKPageUIClient::didNotHandleKeyEvent
2318
2319         Fixes <http://webkit.org/b/46660> <rdar://problem/8483465> Need API to
2320         tell a WebKit2 client application that a key event was not handled
2321
2322         Reviewed by Kenneth Rohde Christiansen and Sam Weinig.
2323
2324         * MiniBrowser/mac/BrowserWindowController.m:
2325         (-[BrowserWindowController awakeFromNib]):
2326         * MiniBrowser/win/BrowserView.cpp:
2327         (BrowserView::create):
2328         * WebKitTestRunner/TestController.cpp:
2329         (WTR::createOtherPage):
2330         (WTR::TestController::initialize):
2331
2332 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
2333
2334         Unreviewed.
2335
2336         Update the CSSTestSuiteHarness to not scrape the XHTML chapter files
2337         for the test order, but instead use information from testinfo.data.
2338         
2339         * CSSTestSuiteHarness/harness/harness.html:
2340         * CSSTestSuiteHarness/harness/harness.js:
2341
2342 2010-09-28  Kevin Ollivier  <kevino@theolliviers.com>
2343
2344         [wx] Build fix, don't try to get the svn revision from the git repo when packaging,
2345         it causes the process to hang on the gitorious repo.
2346
2347         * wx/packaging/build-mac-installer.py:
2348         * wx/packaging/build-win-installer.py:
2349
2350 2010-09-28  Adam Roben  <aroben@apple.com>
2351
2352         Test that a plugin's HWND is sized/positioned before NPP_SetWindow is
2353         called
2354
2355         Reviewed by Anders Carlsson.
2356
2357         Test for <http://webkit.org/b/46716> <rdar://problem/8482014>
2358         Full-page Adobe Reader does not paint until window is resized
2359
2360         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2361         (PluginTest::NPP_SetWindow): Added. Just returns NPERR_NO_ERROR at
2362         this level.
2363
2364         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Declared
2365         NPP_SetWindow.
2366
2367         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp: Added.
2368         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Checks that
2369         the plugin's HWND has a non-zero size and that its size/position
2370         matches that specified in the NPWindow.
2371
2372         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2373         (NPP_SetWindow): Call through to the PluginTest.
2374
2375         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2376         Added WindowGeometryInitializedBeforeSetWindow.cpp, and let VS reorder
2377         the files as it saw fit.
2378
2379 2010-09-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
2380
2381         Reviewed by Andreas Kling.
2382
2383         [Qt] Remove support for Qt 4.5
2384         https://bugs.webkit.org/show_bug.cgi?id=46718
2385
2386         Remove the code for versions of Qt prior to 4.6.
2387
2388         * DumpRenderTree/qt/EventSenderQt.cpp:
2389         (EventSender::addTouchPoint):
2390         (EventSender::updateTouchPoint):
2391         (EventSender::setTouchModifier):
2392         (EventSender::touchStart):
2393         (EventSender::touchMove):
2394         (EventSender::touchEnd):
2395         (EventSender::clearTouchPoints):
2396         (EventSender::releaseTouchPoint):
2397         (EventSender::sendTouchEvent):
2398         * DumpRenderTree/qt/EventSenderQt.h:
2399         * DumpRenderTree/qt/TextInputControllerQt.cpp:
2400         (TextInputController::setMarkedText):
2401         * QtTestBrowser/launcherwindow.cpp:
2402         (LauncherWindow::LauncherWindow):
2403         (LauncherWindow::initializeView):
2404         (LauncherWindow::createChrome):
2405         (LauncherWindow::sendTouchEvent):
2406         (LauncherWindow::eventFilter):
2407         (LauncherWindow::applyZoom):
2408         (LauncherWindow::setTouchMocking):
2409         * QtTestBrowser/launcherwindow.h:
2410         * QtTestBrowser/utils.cpp:
2411         (urlFromUserInput):
2412         * QtTestBrowser/webview.cpp:
2413         (WebViewGraphicsBased::animatedFlip):
2414         (WebViewGraphicsBased::animatedYFlip):
2415         * QtTestBrowser/webview.h:
2416         (WebViewGraphicsBased::setYRotation):
2417
2418 2010-09-28  İsmail Dönmez  <ismail@namtrac.org>
2419
2420         Reviewed by Andreas Kling.
2421
2422         Fix DRT compilation on WinCE. Introduce a WCECOMPAT variable
2423         which should point to wcecompat installation. Needs wcecompat
2424         library from http://github.com/mauricek/wcecompat .
2425
2426         * DumpRenderTree/qt/DumpRenderTree.pro:
2427         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2428         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2429
2430 2010-09-28  Daniel Bates  <dbates@rim.com>
2431
2432         Rollout changeset 68493 <http://trac.webkit.org/changeset/68493>
2433         <https://bugs.webkit.org/show_bug.cgi?id=39136>
2434
2435         Rollout changeset 68493 because it broke Sheriffbot's rollout feature.
2436         In particular, this change caused Sheriffbot to raise an exception when
2437         trying to parse the bug id on a bug page. We need to look into this
2438         some more.
2439
2440         * Scripts/webkitpy/common/net/bugzilla.py:
2441         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
2442         * Scripts/webkitpy/tool/bot/sheriff.py:
2443         * Scripts/webkitpy/tool/commands/download.py:
2444         * Scripts/webkitpy/tool/commands/queues.py:
2445         * Scripts/webkitpy/tool/commands/upload.py:
2446         * Scripts/webkitpy/tool/steps/closebug.py:
2447         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
2448         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2449         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
2450
2451 2010-09-28  Adam Barth  <abarth@webkit.org>
2452
2453         Reviewed by Eric Seidel.
2454
2455         Move RegressionWindow further up the dependency chain
2456         https://bugs.webkit.org/show_bug.cgi?id=46698
2457
2458         Baby steps towards pushing this information into bug posts.
2459
2460         * Scripts/webkitpy/common/net/buildbot.py:
2461         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2462         * Scripts/webkitpy/common/net/regressionwindow.py:
2463         * Scripts/webkitpy/tool/commands/queries.py:
2464
2465 2010-09-27  Daniel Bates  <dbates@rim.com>
2466
2467         Reviewed by Adam Barth.
2468
2469         sheriffbot can't roll out security patches
2470         https://bugs.webkit.org/show_bug.cgi?id=39136
2471
2472         Make SheriffBot determine if it's authorized to view a bug
2473         whose change it wants to rollout before it tries to rollout
2474         the change.
2475
2476         Moreover, make both webkit-patch and Sheriffbot provide human-
2477         readable error messages when they are not authorized to view
2478         a bug and when a bug number is invalid.
2479
2480         Currently, Sheriffbot does not parse Bugzilla bugs for
2481         <bug error="...">, which indicates an error when retrieving
2482         a bug. In particular, error="NotPermitted" if a person (or bot)
2483         is not authorized to view a bug. For such error="NotPermitted" bugs,
2484         Sheriffbot raises an exception when parsing the bug report and
2485         this exception does not explicitly indicate Sheriffbot's lack
2486         of authorization. Instead, Sheriffbot should explicitly check
2487         for the presence <bug error="..."> before operating on a bug
2488         and error with a human-readable message if it's not permitted
2489         to view it.
2490
2491         * Scripts/webkitpy/common/net/bugzilla.py: Added BugzillaError class.
2492         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
2493           - Added unit test test_bug_parsing_for_bugzilla_not_permitted_error().
2494           - Added unit test test_bug_parsing_for_bugzilla_not_found_error().
2495           - Added unit test test_bug_parsing_for_bugzilla_invalid_bug_id_error().
2496         * Scripts/webkitpy/tool/bot/sheriff.py: Modified to catch BugzillaError.
2497         * Scripts/webkitpy/tool/commands/download.py: Ditto.
2498         * Scripts/webkitpy/tool/commands/queues.py: Ditto.
2499         * Scripts/webkitpy/tool/commands/upload.py: Ditto.
2500         * Scripts/webkitpy/tool/steps/closebug.py: Ditto.
2501         * Scripts/webkitpy/tool/steps/obsoletepatches.py: Ditto.
2502         * Scripts/webkitpy/tool/steps/preparechangelog.py: Ditto.
2503         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: Ditto.
2504
2505 2010-09-27  Adam Barth  <abarth@webkit.org>
2506
2507         Reviewed by Eric Seidel.
2508
2509         Expose more more failure information from Buildbot to SheriffBot
2510         https://bugs.webkit.org/show_bug.cgi?id=46697
2511
2512         This patch moves the information about what tests failured closer to
2513         SheriffBot.  There are still a couple more patches to go before
2514         SheriffBot can post this information to bugs, but this is a step in
2515         that direction.  Yay for unit tests, which caught some bugs in earlier
2516         versions of this patch.
2517
2518         * Scripts/webkitpy/common/net/buildbot.py:
2519         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2520         * Scripts/webkitpy/common/net/regressionwindow.py: Added.
2521         * Scripts/webkitpy/tool/commands/queries.py:
2522
2523 2010-09-27  Eric Seidel  <eric@webkit.org>
2524
2525         Unreviewed.  Fixing 500 error seen in the status server.
2526
2527         It turns out that a = b = []; b.append(1); then a[0] will be 1!
2528         This should have been obvious to me, I guess, but it was not what I was expecting.
2529
2530         * QueueStatusServer/model/activeworkitems.py:
2531
2532 2010-09-27  Adam Barth  <abarth@webkit.org>
2533
2534         Reviewed by Eric Seidel.
2535
2536         commit-queue should reject patches that fail to land
2537         https://bugs.webkit.org/show_bug.cgi?id=46694
2538
2539         This can happen, for example, if there's no reviewer.  Without this
2540         patch, we'll keep retrying the patch.
2541
2542         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2543         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2544
2545 2010-09-27  Simon Fraser  <simon.fraser@apple.com>
2546
2547         Rubber-stamped by Adele Peterson.
2548
2549         Add a harness for running the CSS 2.1 test suite.
2550         
2551         This harness assumes that you've got a local a copy of the suite
2552         adjacent to the 'harness' directory.
2553         
2554         The harness lets you go through the tests in chapter order,
2555         denoting pass/fail/skipped for each test.
2556         
2557         It uses a client-side database to store the results of testing.
2558
2559         * CSSTestSuiteHarness/harness/harness.css: Added.
2560         * CSSTestSuiteHarness/harness/harness.html: Added.
2561         * CSSTestSuiteHarness/harness/harness.js: Added.
2562
2563 2010-09-27  Eric Seidel  <eric@webkit.org>
2564
2565         Reviewed by Adam Barth.
2566
2567         Patch locks should expire if a patch is marked for retry
2568         https://bugs.webkit.org/show_bug.cgi?id=46682
2569
2570         This was part Adam's original CommitQueueTask design,
2571         but support for it was missing from the server.
2572         I added the support, but triggering lock-release based on this
2573         special "retry" status feels a bit strange so I added a FIXME.
2574
2575         I also changed the text in queuestatus.html to say "Lock Acquired"
2576         since "Last Activity" isn't really true.  We only update the lock
2577         date when the patch is started, not on every status update.
2578
2579         I also noticed an exception in next-patch, which I fixed by re-writing
2580         the unzip logic in activeworkitems.py again.
2581
2582         * QueueStatusServer/handlers/updatestatus.py:
2583         * QueueStatusServer/model/activeworkitems.py:
2584         * QueueStatusServer/templates/queuestatus.html:
2585
2586 2010-09-27  Tony Chang  <tony@chromium.org>
2587
2588         Reviewed by David Levin.
2589
2590         [chromium] fix a warning when compiling DRT on 32-bit linux
2591         https://bugs.webkit.org/show_bug.cgi?id=46641
2592
2593         * DumpRenderTree/chromium/TestEventPrinter.cpp:
2594         (DRTPrinter::handleImage):
2595
2596 2010-09-27  Eric Seidel  <eric@webkit.org>
2597
2598         Reviewed by Adam Barth.
2599
2600         queue-status should report when the patch was last locked to a queue
2601         https://bugs.webkit.org/show_bug.cgi?id=46674
2602
2603         This isn't necessarily the best way to expose this information
2604         but having this accessible via the web interface is very
2605         useful until we come up with a nicer way to display this.
2606
2607         I also cleaned up the code in activeworkitems.py a little
2608         to use list comprehensions and to have the code work with
2609         pairs instead of two lists at once.  Eventually I think those
2610         item/time pairs need to be their own little helper class.
2611
2612         * QueueStatusServer/handlers/queuestatus.py:
2613         * QueueStatusServer/model/activeworkitems.py:
2614         * QueueStatusServer/templates/queuestatus.html:
2615
2616 2010-09-27  Tony Chang  <tony@chromium.org>
2617
2618         Reviewed by David Levin.
2619
2620         [chromium] fix detection of missing fonts on DRT
2621         https://bugs.webkit.org/show_bug.cgi?id=46651
2622
2623         * DumpRenderTree/chromium/TestShellGtk.cpp:
2624         (setupFontconfig):  Only print an error message if lohit isn't found in both locations.
2625
2626 2010-09-27  Tony Chang  <tony@chromium.org>
2627
2628         Reviewed by Dimitri Glazkov.
2629
2630         add webkit unit tests to the chromium testers
2631         https://bugs.webkit.org/show_bug.cgi?id=46669
2632
2633         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2634         * Scripts/run-chromium-webkit-unit-tests: Fix a bug where we weren't using the right configuration.
2635
2636 2010-09-27  Kwang Yul Seo  <skyul@company100.net>
2637
2638         Unreviewed.
2639
2640         Adding myself to the committers list.
2641
2642         * Scripts/webkitpy/common/config/committers.py:
2643
2644 2010-09-27  Mihai Parparita  <mihaip@chromium.org>
2645
2646         Reviewed by Eric Seidel.
2647
2648         webkitpy.common.system.user_unittest.UserTest.test_prompt_with_list spams the console
2649         https://bugs.webkit.org/show_bug.cgi?id=46634
2650         
2651         Use OutputCapture to prevent console spam (and also check for expected
2652         output).
2653
2654         * Scripts/webkitpy/common/system/user_unittest.py:
2655
2656 2010-09-27  Eric Seidel  <eric@webkit.org>
2657
2658         Reviewed by James Robinson.
2659
2660         start-commit-queue should abort any rebases in progress
2661         https://bugs.webkit.org/show_bug.cgi?id=46640
2662
2663         webkit-patch commit-queue would do this itself, but this just
2664         helps ensure that the commit-queue script is properly updated
2665         before we run it (in the case where a previous rebase is in
2666         progress the git svn rebase would not work before we run the
2667         commit-queue).
2668
2669         * EWSTools/start-commit-queue.sh:
2670
2671 2010-09-18  Martin Robinson  <mrobinson@igalia.com>
2672
2673         Reviewed by Gustavo Noronha Silva.
2674
2675         [GTK] Clean up the DRT fonts.conf and switch to Liberation
2676         https://bugs.webkit.org/show_bug.cgi?id=46038
2677
2678         Switch to Liberation fonts for GTK+ layout tests. This will make our
2679         test results metric-compatible with many Windows/Chromium results. It
2680         also simplifies the fonts.conf that we load and prepares the way for
2681         fixing many font bugs.
2682
2683         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2684         (initializeFonts): Initialize a known list of fonts instead of loading
2685         every font in the WEBKIT_TESTFONTS directory.
2686         * DumpRenderTree/gtk/fonts.conf: Removed.
2687         * DumpRenderTree/gtk/fonts/AHEM____.TTF: Copied from WebKitTools/DumpRenderTree/qt/fonts/AHEM____.TTF.
2688         * DumpRenderTree/gtk/fonts/fonts.conf: Added.
2689         * GNUmakefile.am: Modify FONTS_CONF_FILE to be FONTS_CONF_DIR, so that
2690         we can load both fonts.conf and AHEM____.TTF from this location.
2691         * Scripts/old-run-webkit-tests: Remove the check for WEBKIT_TESTFONTS, since
2692         it is no longer used.
2693
2694 2010-09-26  Mihai Parparita  <mihaip@chromium.org>
2695
2696         Reviewed by Ojan Vafai.
2697
2698         new-run-webkit-httpd fails if Perl is not installed
2699         https://bugs.webkit.org/show_bug.cgi?id=46602
2700         
2701         Make Port._read_configuration catch all exceptions, since trying to run
2702         perl (because of _webkit_build_directory) when it's not installed throws
2703         a WindowsError or OSError, not an IOError (this became an issue after 
2704         r68268, since ChromiumPort ends up calling Port.default_configuration in
2705         its constructor, which means that we're ending up on this codepath in
2706         non-NRWT cases too, e.g. for the Chromium NaCl tests, which use
2707         new-run-webkit-httpd).
2708
2709         * Scripts/webkitpy/layout_tests/port/base.py:
2710         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2711
2712 2010-09-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2713
2714         Reviewed by Antonio Gomes.
2715
2716         [EFL] Add setting API to set a local storage database path.
2717         https://bugs.webkit.org/show_bug.cgi?id=45446
2718
2719         Add a setting API to set local storage database path.
2720
2721         * EWebLauncher/main.c:
2722         (on_key_down):
2723         (browserCreate):
2724         (main):
2725
2726 2010-09-26  Sam Weinig  <sam@webkit.org>
2727
2728         Reviewed by Anders Carlsson.
2729
2730         Move shared WebKit2 API (used by both bundle and main API) to WebKit2/Shared/API
2731         https://bugs.webkit.org/show_bug.cgi?id=46587
2732
2733         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2734
2735 2010-09-26  Antonio Gomes  <agomes@rim.com>
2736
2737         Reviewed by Kenneth Rohde Christiansen.
2738
2739         DRT/Mac nodesFromRect support
2740
2741         [Mac][DRT] Implement LayoutTestController::nodesFromRect
2742         https://bugs.webkit.org/show_bug.cgi?id=46580
2743
2744         Implements LayoutTestController::nodesFromRect for Mac DRT, and
2745         adding stubs for GTK+ and Windows.
2746
2747         * DumpRenderTree/LayoutTestController.cpp:
2748         (nodesFromRectCallback):
2749         (LayoutTestController::staticFunctions):
2750         * DumpRenderTree/LayoutTestController.h:
2751         (LayoutTestController::LayoutTestController::nodesFromRect):
2752         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2753         (LayoutTestController::nodesFromRect):
2754
2755 2010-09-25  Nicolas Weber  <thakis@chromium.org>
2756
2757         Reviewed by Adam Barth.
2758
2759         https://bugs.webkit.org/show_bug.cgi?id=46555
2760         Fix typo in prepare-ChangeLog's help output.
2761
2762         * Scripts/prepare-ChangeLog:
2763
2764 2010-09-24  Sam Weinig  <sam@webkit.org>
2765
2766         Reviewed by Darin Adler.
2767
2768         Implement WebKit2 callback equivalent to -[WebUIDelegate mouseDidMoveOverElement:modifierFlags:]
2769         <rdar://problem/8359279>
2770         https://bugs.webkit.org/show_bug.cgi?id=46546
2771
2772         * MiniBrowser/mac/BrowserWindowController.m:
2773         (mouseDidMoveOverElement):
2774         (-[BrowserWindowController awakeFromNib]):
2775         * MiniBrowser/win/BrowserView.cpp:
2776         (mouseDidMoveOverElement):
2777         (BrowserView::create):
2778         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2779         (WTR::InjectedBundlePage::InjectedBundlePage):
2780         * WebKitTestRunner/TestController.cpp:
2781         (WTR::createOtherPage):
2782         (WTR::TestController::initialize):
2783
2784 2010-09-24  Mihai Parparita  <mihaip@chromium.org>
2785
2786         Reviewed by Adam Barth.
2787
2788         Allow rebaselines for webkit-patch rebaseline to be chosen
2789         https://bugs.webkit.org/show_bug.cgi?id=46407
2790         
2791         Instead of always rebaselining all failing tests, allow a subset to be
2792         chosen.
2793
2794         * Scripts/webkitpy/common/system/user.py:
2795         * Scripts/webkitpy/tool/commands/rebaseline.py:
2796
2797 2010-09-24  Ryosuke Niwa  <rniwa@webkit.org>
2798
2799         Reviewed by Tony Chang.
2800
2801         [chromium] Implement TextInputController::firstRectForCharacterRange
2802         https://bugs.webkit.org/show_bug.cgi?id=38100
2803
2804         Implemented TextInputController::firstRectForCharacterRange for chromium platform.
2805         No new tests are added since we need to implement the same feature in chromium side
2806         in order to enable any tests that uses this function.
2807
2808         * DumpRenderTree/chromium/TextInputController.cpp:
2809         (TextInputController::firstRectForCharacterRange): Added.
2810
2811 2010-09-24  Adam Barth  <abarth@webkit.org>
2812
2813         Reviewed by Eric Seidel.
2814
2815         commit-queue reports land failures as "PASS"
2816         https://bugs.webkit.org/show_bug.cgi?id=46530
2817
2818         We were ignoring the return value of land instead of passing it back to
2819         CommitQueue.  Of course, this was the one case I forgot to test!
2820
2821         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2822         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2823
2824 2010-09-24  Kenichi Ishibashi  <bashi@google.com>
2825
2826         Reviewed by Eric Seidel.
2827
2828         new-run-webkit-tests prints out nothing when build-dumprendertree fails
2829         https://bugs.webkit.org/show_bug.cgi?id=37563
2830
2831         Print error message when build-dumprendertree fails.
2832
2833         * Scripts/webkitpy/layout_tests/port/webkit.py:
2834         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2835
2836 2010-09-24  Mihai Parparita  <mihaip@chromium.org>
2837
2838         Reviewed by Tony Chang.
2839
2840         NRWT doesn't respect config set with set-webkit-configuration
2841         https://bugs.webkit.org/show_bug.cgi?id=46278
2842         
2843         Use Port.default_configuration() instead of hardcoding Release in
2844         ChromiumPort configuration initialization, so that we still inherit the
2845         configuration set by set-webkit-configuration.
2846
2847         * Scripts/webkitpy/layout_tests/port/chromium.py:
2848         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2849
2850 2010-09-24  Chang Shu  <chang.shu@nokia.com>
2851
2852         Reviewed by Csaba Osztrogonác.
2853
2854         [Qt] Fix the code to check file existence.
2855         https://bugs.webkit.org/show_bug.cgi?id=46465
2856
2857         * QtTestBrowser/main.cpp:
2858         (main):
2859
2860 2010-09-23  Tony Chang  <tony@chromium.org>
2861
2862         Unreviewed, rolling out r68232.
2863         http://trac.webkit.org/changeset/68232
2864
2865         Broken NRWT on the canary bots.
2866
2867         * Scripts/webkitpy/layout_tests/port/chromium.py:
2868
2869 2010-09-23  Dirk Pranke  <dpranke@chromium.org>
2870
2871         Unreviewed, build fix.
2872
2873         r68008 broke new-run-webkit-tests in that the chromium ports no
2874         longer respect set-webkit-configuration. The correct fix for this
2875         is being pursued in bug 46278 (along with a bunch of unit tests),
2876         but in the meantime I'm reverting the particular lines that broke
2877         things. This was tested by hand.
2878
2879         * Scripts/webkitpy/layout_tests/port/chromium.py:
2880
2881 2010-09-23  Sam Weinig  <sam@webkit.org>
2882
2883         Reviewed by Anders Carlsson.
2884
2885         WebKit2 API: Need way to know when a frame is removed from the hierarchy
2886         <rdar://problem/8414062>
2887         https://bugs.webkit.org/show_bug.cgi?id=46432
2888
2889         * MiniBrowser/mac/BrowserWindowController.m:
2890         (didRemoveFrameFromHierarchy):
2891         (-[BrowserWindowController awakeFromNib]):
2892         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2893         (WTR::InjectedBundlePage::InjectedBundlePage):
2894         * WebKitTestRunner/TestController.cpp:
2895         (WTR::TestController::initialize):
2896
2897 2010-09-23  Tony Chang  <tony@chromium.org>
2898
2899         Reviewed by Dimitri Glazkov.
2900
2901         [chromium] implement layoutTestController.sampleSVGAnimationForElementAtTime
2902         https://bugs.webkit.org/show_bug.cgi?id=46426
2903
2904         * DumpRenderTree/chromium/LayoutTestController.cpp:
2905         (LayoutTestController::LayoutTestController):
2906         (LayoutTestController::sampleSVGAnimationForElementAtTime):
2907         * DumpRenderTree/chromium/LayoutTestController.h:
2908
2909 2010-09-23  Martin Robinson  <mrobinson@igalia.com>
2910
2911         Reviewed by Nate Chapin.
2912
2913         [GTK] r68199 introduced two test failures
2914         https://bugs.webkit.org/show_bug.cgi?id=46424
2915
2916         Fix a regression handling preference overrides that are attached to boolean properties.
2917
2918         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2919         (LayoutTestController::overridePreference): g_strcasecmp returns 0 when strings match
2920         so we must check for that when converting a string to a boolean.
2921
2922 2010-09-23  Dimitri Glazkov  <dglazkov@chromium.org>
2923
2924         Reviewed by David Levin.
2925
2926         Fix a condition check in ServerProcess, which becomes relevant when reading binary data.
2927         https://bugs.webkit.org/show_bug.cgi?id=46406
2928
2929         This breaks when the method is called with specified size of data (image data), and the
2930         buffer hasn't yet reached this size.
2931
2932         * Scripts/webkitpy/layout_tests/port/server_process.py: Changed to check for values of
2933           index larger than 0.
2934
2935 2010-09-23  Martin Robinson  <mrobinson@igalia.com>
2936
2937         Reviewed by Nate Chapin.
2938
2939         [GTK] Some tests from r68174 fail on the GTK+ bots
2940         https://bugs.webkit.org/show_bug.cgi?id=46396
2941
2942         Simplify LayoutTestController::overridePreference to make it easier for
2943         people unfamiliar with the code to keep the list of preferences up to date.
2944         Add the conversion for enable-hyperlink-auditing.
2945
2946         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2947         (LayoutTestController::overridePreference): Use a simple if-else block to determine
2948         out the property name for overrridePreference. Also simplify the logic for setting
2949         string properties. Add the conversion for enable-hyperlink-auditing.
2950
2951 2010-09-23  Tony Chang  <tony@chromium.org>
2952
2953         Reviewed by David Levin.
2954
2955         [chromium] add caretBrowsingEnabled to WebSettings and DRT
2956         https://bugs.webkit.org/show_bug.cgi?id=46388
2957
2958         * DumpRenderTree/chromium/LayoutTestController.cpp:
2959         (LayoutTestController::overridePreference):
2960         * DumpRenderTree/chromium/WebPreferences.cpp:
2961         (WebPreferences::reset):
2962         (WebPreferences::applyTo):
2963         * DumpRenderTree/chromium/WebPreferences.h:
2964
2965 2010-09-23  Nate Chapin  <japhet@chromium.org>
2966
2967         Reviewed by Darin Fisher.
2968
2969         Allow DRT to toggle hyperlink auditing (i.e., <a ping>).
2970         https://bugs.webkit.org/show_bug.cgi?id=30458
2971
2972         * DumpRenderTree/chromium/LayoutTestController.cpp:
2973         (LayoutTestController::overridePreference):
2974         * DumpRenderTree/chromium/WebPreferences.cpp:
2975         (WebPreferences::reset):
2976         (WebPreferences::applyTo):
2977         * DumpRenderTree/chromium/WebPreferences.h:
2978         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2979         (resetDefaultsToConsistentValues):
2980         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2981         (LayoutTestController::overridePreference):
2982
2983 2010-09-21  Stephen White  <senorblanco@chromium.org>
2984
2985         Reviewed by David Levin.
2986
2987         Implement --enable-accelerated-2d-canvas flag in DumpRenderTree.
2988         https://bugs.webkit.org/show_bug.cgi?id=46208
2989
2990         This flag allows the layout tests to be run with or without accelerated
2991         2D canvas rendering.
2992
2993         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2994         (main):
2995         Declare the new flag string, and check for it on startup.
2996         * DumpRenderTree/chromium/TestShell.cpp:
2997         (TestShell::TestShell):
2998         Add a boolean for the new flag, in order to preserve its value over
2999         preferences reset.
3000         (TestShell::resetWebSettings):
3001         Set the new flag to the stored value on reset.
3002         * DumpRenderTree/chromium/TestShell.h:
3003         (TestShell::setAccelerated2dCanvasEnabled):
3004         Add an accessor for the new flag.
3005         * DumpRenderTree/chromium/WebPreferences.cpp:
3006         (WebPreferences::reset):
3007         Initialize the new flag to false.
3008         (WebPreferences::applyTo):
3009         Copy the flag's value to the WebSettings.
3010         * DumpRenderTree/chromium/WebPreferences.h:
3011         Add the new flag.
3012
3013 2010-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3014
3015         Reviewed by Simon Hausmann.
3016
3017         [Qt] Refactor QtWebKitPlatformPlugin interface
3018
3019         Make it easier to keep source-compability for the
3020         QtWebKitPlatformPlugin interface, and run qmake
3021         on the example (but not build) for convenience. 
3022
3023         https://bugs.webkit.org/show_bug.cgi?id=46345
3024
3025         * Scripts/webkitdirs.pm:
3026
3027 2010-09-23  Adam Barth  <abarth@webkit.org>
3028
3029         Reviewed by Eric Seidel.
3030
3031         Tweak some status messages that Eric thought were confusing
3032         https://bugs.webkit.org/show_bug.cgi?id=46342
3033
3034         * Scripts/webkitpy/tool/commands/queues.py:
3035         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3036
3037 2010-09-22  Adam Barth  <abarth@webkit.org>
3038
3039         Reviewed by Eric Seidel.
3040
3041         Fix comm-queue typo
3042         https://bugs.webkit.org/show_bug.cgi?id=46339
3043
3044         We were missing a "self".  The real problem is that we didn't have an
3045         integration test for the failure case.
3046
3047         * Scripts/webkitpy/tool/commands/queues.py:
3048         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3049
3050 2010-09-22  Adam Barth  <abarth@webkit.org>
3051
3052         Reviewed by Eric Seidel.
3053
3054         commit-queue should log more detailed messages to the QueueStatusServer
3055         https://bugs.webkit.org/show_bug.cgi?id=46333
3056
3057         When I created CommitQueueTask, I removed most of the previous logging.
3058         This patch adds back more detailed logging so folks can see their patch
3059         progress through the queue.
3060
3061         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3062         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3063         * Scripts/webkitpy/tool/commands/queues.py:
3064         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3065
3066 2010-09-22  Mihai Parparita  <mihaip@chromium.org>
3067
3068         Reviewed by Darin Fisher.
3069
3070         [Chromium] User style layout tests don't pass on Chromium
3071         https://bugs.webkit.org/show_bug.cgi?id=46069
3072
3073         Fix a typo in LayoutTestController::addUserStyleSheet that was causing a
3074         crash the Chromium DRT. Pass InjectInExistingDocuments to mimic DRT
3075         behavior from other ports.
3076
3077         * DumpRenderTree/chromium/LayoutTestController.cpp:
3078         (LayoutTestController::addUserStyleSheet):
3079
3080 2010-09-22  Brent Fulgham  <bfulgham@webkit.org>
3081
3082         Reviewed by Martin Robinson.
3083
3084         [WinCairo] Part 2: Update WebKitTestRunner and DumpRenderTree Build.
3085         https://bugs.webkit.org/show_bug.cgi?id=46303.
3086
3087         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added.
3088         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Moved
3089         CoreFoundation-specific stuff to new MiniBrowserCoreFoundation
3090         property sheet.
3091         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added.
3092         * MiniBrowser/MiniBrowser.vcproj: Updated configuration to use
3093         appropriate property sheet for the build types.
3094         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Updated the
3095         configuration to use appropriate property sheet for CoreFoundation
3096         and CFLite-style builds.
3097
3098 2010-09-22  Adam Barth  <abarth@webkit.org>
3099
3100         Reviewed by Eric Seidel.
3101
3102         Optimize commit-queue performance for green trees
3103         https://bugs.webkit.org/show_bug.cgi?id=46254
3104
3105         This patch redesigns the controller logic for the commit-queue.  In the
3106         new design, the controller exercises much finer-grained control over
3107         the landing process.  In particular:
3108
3109         - Patches that fail to apply now get rejected almost immediately.
3110         - Patches that fail to build get rejects after two builds (instead of
3111           three builds and one test run).
3112         - Patches that run into a flaky test now get accepted after one build
3113           and two test runs instead of three full build-and-test runs.
3114
3115         The main cost of these optimizations is that we don't find out the tree
3116         has a failing test until the very end of the process, but if the tree
3117         has a busted test, there's not much we can do anyway.  We might as well
3118         burn commit-queue resources spinning optimisticly.
3119
3120         * Scripts/webkitpy/tool/bot/commitqueuetask.py: Added.
3121         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: Added.
3122         * Scripts/webkitpy/tool/commands/queues.py:
3123
3124 2010-09-22  Brent Fulgham  <bfulgham@webkit.org>
3125
3126         Reviewed by Martin Robinson.
3127
3128         [WinCairo] Update WebKitTestRunner and DumpRenderTree Build.
3129         https://bugs.webkit.org/show_bug.cgi?id=46303.
3130
3131         * DumpRenderTree/win/DumpRenderTree.vcproj: Disable local MD5 sources
3132         for Cairo build. Copy wtf MD5 header to ForwardingHeaders for the
3133         WinCairo build.
3134         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added.
3135         * WebKitTestRunner/win/InjectedBundle.vcproj: Update win new *_Cairo
3136         build targets that use the new InjectedBundleCFLite.vsprops file.
3137
3138 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
3139
3140         Unreviewed, build fix.
3141
3142         Fix bustage of rebaseline-chromium-webkit-tests resulting from
3143         r67974. Really need better unit tests for this tool :(
3144
3145         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3146
3147 2010-09-22  Adam Roben  <aroben@apple.com>
3148
3149         Unbreak test-webkitpy
3150
3151         * Scripts/webkitpy/test/main.py:
3152         (Tester.run_tests): Add a line that mysteriously got deleted.
3153
3154 2010-09-22  Adam Roben  <aroben@apple.com>
3155
3156         Make test-webkitpy test WebKit2's scripts
3157
3158         These scripts can't be in WebKitTools due to limitations of Apple's
3159         build process. But that doesn't mean we can't test them!
3160
3161         Fixes <http://webkit.org/b/46297> test-webkitpy should test code in
3162         WebKit2/Scripts
3163
3164         Reviewed by Adam Barth.
3165
3166         * Scripts/test-webkitpy:
3167         (_clean_packages_with_test): Renamed from _clean_webkitpy_with_test.
3168         Now takes an external_package_paths parameter and cleans both webkitpy
3169         and any external packages.
3170         (init): Added an external_package_paths parameter which we pass along
3171         to _clean_packages_with_test.
3172         (top level): Add WebKit2/Scripts/webkit2 as our only external package
3173         and pass it along to init and Tester.run_tests.
3174
3175         * Scripts/webkitpy/test/main.py:
3176         (Tester.run_tests): Added an optional external_package_paths
3177         parameter. We modify sys.path so that the external packages can be
3178         imported, and search for unittest files inside all external packages
3179         in addition to inside webkitpy.
3180
3181 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
3182
3183         Reviewed by Tony Chang.
3184
3185         new-run-webkit-tests: r68063 broke linux python tests
3186
3187         Add a missing "from __future__ import with_statement" to this
3188         new file; the perils of testing only on the Mac and by review :(
3189
3190         https://bugs.webkit.org/show_bug.cgi?id=46293
3191
3192         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3193
3194 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
3195
3196         Reviewed by Tony Chang.
3197
3198         Add a 'chromium-gpu' set of ports that will test the accelerated
3199         GPU paths. This patch adds:
3200
3201         - support for the '--accelerated-compositing' and
3202           'accelerated-2d-canvas' flags to new-run-webkit-tests (and the
3203           'no-' flags)
3204         - adds a new set of Ports that will look under
3205           platform/chromium-gpu-$OS/ for baselines before looking in the
3206           regular chromium search path
3207         - adds a new test_expectations.txt file in platform/chromium-gpu
3208           that skips all but the tests we actually want to run with
3209           acceleration.
3210
3211         This patch will allow us to run both with and without acceleration
3212         and to change the defaults for both the regular and -gpu options
3213         as the code evolves.
3214
3215         We plan to add both --chromium-$OS and --chromium-gpu-$OS runs to
3216         each test bot.
3217
3218         https://bugs.webkit.org/show_bug.cgi?id=46225
3219
3220         * Scripts/webkitpy/layout_tests/port/chromium.py:
3221         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3222         * Scripts/webkitpy/layout_tests/port/factory.py:
3223         * Scripts/webkitpy/layout_tests/port/webkit.py:
3224
3225 2010-09-22  Jamey Hicks  <jamey.hicks@nokia.com>
3226
3227         Reviewed by Kenneth Rohde Christiansen.
3228
3229         [Qt] Web Inspector: Remote Web Inspector support for QtWebKit
3230         https://bugs.webkit.org/show_bug.cgi?id=43988
3231
3232         Runs a web debug server on port specified by QtTestBrowser
3233         argument -remote-inspector-port. Property
3234         _q_webInspectorServerPort of the QWebPage instance will be set
3235         according to the argument. All pages with that property set will
3236         be remotely inspectable.
3237
3238         URL for remote inspection of first QWebPage is
3239             http://localhost:9222/webkit/inspector/inspector.html?page=1
3240         where 1 is the number of the QWebPage instance.
3241
3242         The base URL yields an index page with links to the individual inspectors:
3243             http://localhost:9222/
3244
3245         * QtTestBrowser/launcherwindow.cpp:
3246         (LauncherWindow::init):
3247         * QtTestBrowser/launcherwindow.h:
3248         * QtTestBrowser/main.cpp:
3249         (LauncherApplication::handleUserOptions):
3250
3251 2010-09-22  Adam Roben  <aroben@apple.com>
3252
3253         Fix webkit-patch failure-reason now that build.webkit.org has been
3254         updated
3255
3256         Fixes <http://webkit.org/b/46273> webkit-patch failure-reason crashes
3257         every time
3258
3259         Reviewed by Eric Seidel.
3260
3261         * Scripts/webkitpy/common/net/buildbot.py:
3262         (BuildBot._file_cell_text): Added. Travels down the firstChild chain
3263         looking for an element that contains text, then returns it.
3264         (BuildBot._parse_twisted_file_row): Use _file_cell_text to get the
3265         text out of the cells. This way it doesn't matter whether the cells
3266         have <b> children (as for cells in directory rows) or not (as for
3267         cells in file rows)
3268         (BuildBot._parse_twisted_directory_listing): Look for rows that have
3269         the "directory" or "file" class, rather than rows with any class,
3270         since header rows now have a class attribute.
3271
3272         * Scripts/webkitpy/common/net/buildbot_unittest.py:
3273         (BuildBotTest._example_directory_listing): Updated to more closely
3274         match the markup that build.webkit.org is producing now.
3275
3276 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
3277
3278         Unreviewed, build fix.
3279
3280         new-run-webkit-tests: fix bug introduced in r68008 where if you
3281         specify --chromium and no --platform, and you're running on
3282         windows, you use the 'chromium-win' port by default instead of the
3283         version-specific port. This breaks the buildbots.
3284
3285         It will be good for this refactoring to settle down so I can
3286         rewrite the logic for default ports and the unit tests to be
3287         clearer (and the testing more comprehensive).
3288
3289         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3290
3291 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
3292
3293         Reviewed by Adam Barth.
3294
3295         Modify the Port interface to take only a series of keyword arguments
3296         in the constructor, and modify Port/factory.get() to accomodate that,
3297         and to accept user=XXX as an argument so we can pass
3298         webkitpy.common.system.user.User objects in.
3299
3300         Then, modify new-run-webkit-tests and rebaseline-chromium-webkit-tests
3301         to use the common routine in webkitpy.common.system.user.open_url()
3302         to display HTML files.
3303
3304         There was a routine in the Port interface to do the same thing,
3305         but I see no need for a port-specific hook for this, since it is
3306         something that will always be executed by the host environment
3307         and displaying web pages has nothing to do with running layout tests.
3308
3309         Note that new-run-webkit-tests used to use test_shell to display
3310         the page; this is potentially useful so that you can actually click
3311         from a result to the broken page; however, since DumpRenderTree
3312         doesn't support this functionality, it will be going away eventually.
3313
3314         https://bugs.webkit.org/show_bug.cgi?id=46128
3315
3316         * Scripts/webkitpy/layout_tests/port/base.py:
3317         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3318         * Scripts/webkitpy/layout_tests/port/chromium.py:
3319         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3320         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3321         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3322         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3323         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3324         * Scripts/webkitpy/layout_tests/port/factory.py:
3325         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3326         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3327         * Scripts/webkitpy/layout_tests/port/gtk.py:
3328         * Scripts/webkitpy/layout_tests/port/mac.py:
3329         * Scripts/webkitpy/layout_tests/port/qt.py:
3330         * Scripts/webkitpy/layout_tests/port/test.py:
3331         * Scripts/webkitpy/layout_tests/port/webkit.py:
3332         * Scripts/webkitpy/layout_tests/port/win.py:
3333         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3334         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3335         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3336
3337 2010-09-21  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3338
3339         Reviewed by Kenneth Rohde Christiansen.
3340
3341         [EFL] Get fresh theme when running EWebLauncher
3342         https://bugs.webkit.org/show_bug.cgi?id=46210
3343
3344         If user tried to run EWebLauncher outside of the build tree, it would
3345         not find the theme and fallback to the installed one. However, since
3346         EWebLauncher is not installed, we always want to take the theme from
3347         the just compiled source code. If user had never installed WebKit's
3348         EFL port it could even receive a segv since no theme would be found.
3349
3350         Now EWebLauncher does not fallback to the installed theme and CMake
3351         gives as DATA_DIR the directory of the theme it has just built.
3352
3353         * CMakeListsEfl.txt: Pass the build directory as DATA_DIR to
3354         EWebLauncher.
3355         * EWebLauncher/main.c: Use only the theme from build director. Do not
3356         fallback to others as this could hide real bugs.
3357         (quit):
3358         (browserCreate):
3359         (findThemePath):
3360         (main):
3361
3362 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
3363
3364         Unreviewed, build fix.
3365
3366         Don't pass the --test-shell arg to the Chromium Mac port of DRT;
3367         it just confuses it.
3368
3369         https://bugs.webkit.org/show_bug.cgi?id=46230
3370
3371         * Scripts/webkitpy/layout_tests/port/webkit.py:
3372
3373 2010-09-21  Lucas Forschler  <lforschler@apple.com>
3374
3375         Reviewed by Stephanie Lewis.
3376
3377         Make a new buildbot for Leopard Debug Test
3378
3379         * BuildSlaveSupport/build.webkit.org-config/config.json:
3380
3381 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
3382
3383         Unreviewed, build fix.
3384
3385         Fix breakage of Chromium Mac DRT port caused by r67905.
3386
3387         https://bugs.webkit.org/show_bug.cgi?id=46230
3388
3389         * Scripts/webkitpy/layout_tests/port/webkit.py:
3390
3391 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
3392
3393         Unreviewed, build fix.
3394
3395         Add missing import of 'tempfile'.
3396
3397         * Scripts/webkitpy/layout_tests/port/chromium.py:
3398
3399 2010-09-17  Dirk Pranke  <dpranke@chromium.org>
3400
3401         Reviewed by Ojan Vafai.
3402
3403         new-run-webkit-tests: pull the list of tests from the Port, and
3404            make it possible to run with no actual test files in the filesystem.
3405
3406         This set of changes allows us to delete the special
3407         webkitpy/layout_tests/data directory and test the generic code without
3408         touching the filesystem (except to write results). This speeds up
3409         test-webkitpy substantially.
3410
3411         This also cleans up and removes several code paths in the generic
3412         code and fixes some minor bugs, notably in the test_expectations
3413         parsing, which was previously fragile if the tests weren't present.
3414
3415         We also change the way we diff image results to be able to do so
3416         in memory, without relying on files. This slows down chromium
3417         test_shell, which always writes images to files, but should speed
3418         up DRT and ImageDiff-based implementations slightly.
3419
3420         Note that pulling the list of tests to run from the Port will allow
3421         ports to specify what tests to run as an inclusive list; previously
3422         you could only do this as an exclusive list by using a 
3423         test_expectations file or Skipped files; nothing actually uses this
3424         feature yet and it's unclear if it should be used.
3425
3426         Note that there are no functional changes -- apart from now 
3427         always printing out the location of the checksum file when we are
3428         tracing test runs -- and the total number of lines of non-test code
3429         actually drops by two.
3430
3431         There is some more cleanup that can be done in the Port/Driver 
3432         interface and in some handling of filenames, but I'll save that
3433         for another change.
3434
3435         https://bugs.webkit.org/show_bug.cgi?id=45801
3436
3437         * Scripts/webkitpy/layout_tests/data/*: Removed.
3438             - no longer need special mock layout_tests_directory in the
3439               repository.
3440         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3441             - add code to display missing text files, checksums when tracing
3442             - update to not look at the filesystem directly.
3443         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3444             - add more unit tests
3445         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3446             - remove tests_are_present flag
3447             - update with changes in Port interface - no longer access
3448               the filesystem directly, although we still use os.path for
3449               filename manipulation.
3450         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3451             - add more unit tests
3452         * Scripts/webkitpy/layout_tests/layout_package/test_files.py: Removed.
3453             - renamed to port/test_files.py
3454         * Scripts/webkitpy/layout_tests/port/base.py:
3455             - change diff_image() to expect actual image data, not filenames
3456             - add expected_checksum(), expected_image(), expected_text() to
3457               return the content of the files so that we don't need a filesystem
3458             - add path_exists(), path_isdir() for filesystem-like access.
3459             - add test_dirs() to keep clobber-test-results from needing to
3460               actually look at a real layout tests dir
3461             - add tests() to return the list of tests to run on the port
3462               (calls port/test_files to do the work).
3463             - add update_baseline() to be able to save new baselines
3464             - add uri_to_test_name() from port/dryrun.py so we can easily check
3465               filename_to_uri()
3466         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3467             - add more unit tests
3468         * Scripts/webkitpy/layout_tests/port/chromium.py:
3469             - change diff_image() to accept image content, not filenames.
3470               This will be slower for test_shell/image_diff, but faster
3471               for DRT/ImageDiff.
3472         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3473             - add more unit tests
3474         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3475             - simplify greatly
3476         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3477             - add more unit tests
3478         * Scripts/webkitpy/layout_tests/port/test.py:
3479             - massive rewrite to use in-script list of tests and expectations
3480         * Scripts/webkitpy/layout_tests/port/test_files.py:
3481             - rename from layout_package/test_files.
3482         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
3483             - add unit tests
3484         * Scripts/webkitpy/layout_tests/port/webkit.py:
3485             - update diff_image() to take image contents, not files. Should
3486               make things slightly faster.
3487         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3488             - update with changes to diff_image()
3489         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
3490             - update with changes to diff_image()
3491         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3492             - remove tests_are_present from test_expectations
3493             - pull the list of tests from port.tests() instead
3494               of calling test_files.py directly.
3495         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3496             - update unit tests
3497         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
3498             - update with changes to 
3499         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
3500             - update with change in Port interface
3501         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3502             - update with change in Port interface
3503         * Scripts/webkitpy/style/checkers/test_expectations.py:
3504             - remove the tests_are_present flag
3505
3506 2010-09-21  Anders Carlsson  <andersca@apple.com>
3507
3508         Disable logging.
3509
3510         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
3511
3512 2010-09-21  Tony Chang  <tony@chromium.org>
3513
3514         Reviewed by Kent Tamura.
3515
3516         add a script for running webkit_unit_tests
3517         https://bugs.webkit.org/show_bug.cgi?id=46014
3518
3519         * Scripts/run-chromium-webkit-unit-tests: Added.
3520
3521 2010-09-21  Fridrich Strba  <fridrich.strba@bluewin.ch>
3522
3523         Reviewed by Martin Robinson.
3524
3525         Fix linking problems on Windows.
3526         https://bugs.webkit.org/show_bug.cgi?id=45844
3527
3528         * GNUmakefile.am: link the executables with winmm.dll
3529
3530 2010-09-21  Adam Barth  <abarth@webkit.org>
3531
3532         Reviewed by Eric Seidel.
3533
3534         feeder-queue svn updates more often than needed
3535         https://bugs.webkit.org/show_bug.cgi?id=46171
3536
3537         We don't need to poll SVN every time we feed the feeders.  Rather, we
3538         can count on the wrapper shell script to auto-update the queue.
3539
3540         * Scripts/webkitpy/tool/commands/queues.py:
3541         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3542
3543 2010-09-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3544
3545         Reviewed by Andreas Kling.
3546
3547         [Qt] Add robot loader timeout and extra time options.
3548         https://bugs.webkit.org/show_bug.cgi?id=46172
3549
3550         [-robot-timeout <s>]: Load the next page after s seconds if the current
3551         page didn't finish loading.
3552         [-robot-extra-time <s>]: Wait s seconds after the current page finished
3553         loading before loading the next one. This should allow some time for the
3554         page's JavaScript to execute.
3555
3556         * QtTestBrowser/launcherwindow.cpp:
3557         (LauncherWindow::applyPrefs):
3558         * QtTestBrowser/main.cpp:
3559         (LauncherApplication::robotTimeout):
3560         (LauncherApplication::robotExtraTime):
3561         (LauncherApplication::LauncherApplication):
3562         (LauncherApplication::handleUserOptions):
3563         (main):
3564         * QtTestBrowser/urlloader.cpp:
3565         (UrlLoader::UrlLoader):
3566         (UrlLoader::loadNext):
3567         (UrlLoader::loadUrlList):
3568         * QtTestBrowser/urlloader.h:
3569
3570 2010-09-21  Pavel Podivilov  <podivilov@chromium.org>
3571
3572         Unreviewed.
3573
3574         Adding myself to the committers list.
3575
3576         * Scripts/webkitpy/common/config/committers.py:
3577
3578 2010-09-20  Philippe Normand  <pnormand@igalia.com>
3579
3580         Reviewed by Eric Carlson.
3581
3582         [GTK] enhanced context menu for media elements
3583         https://bugs.webkit.org/show_bug.cgi?id=45021
3584
3585         EventSender::contextClick() now returns an array of js
3586         objects. Each object has a title property and a click() method.
3587
3588         * DumpRenderTree/gtk/EventSender.cpp:
3589         (getMenuItemTitleCallback):
3590         (setMenuItemTitleCallback):
3591         (menuItemClickCallback):
3592         (getMenuItemClass):
3593         (contextClickCallback):
3594
3595 2010-09-20  Hayato Ito  <hayato@chromium.org>
3596
3597         Unreviewed.
3598         Adding myself to the committers list.
3599
3600         * Scripts/webkitpy/common/config/committers.py:
3601
3602 2010-09-20  Adam Barth  <abarth@webkit.org>
3603
3604         Reviewed by Eric Seidel.
3605
3606         The tool member variable should be called _tool
3607         https://bugs.webkit.org/show_bug.cgi?id=46160
3608
3609         Created by find-and-replace.
3610
3611         * Scripts/webkitpy/tool/commands/download.py:
3612         * Scripts/webkitpy/tool/commands/openbugs.py:
3613         * Scripts/webkitpy/tool/commands/queries.py:
3614         * Scripts/webkitpy/tool/commands/queues.py:
3615         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3616         * Scripts/webkitpy/tool/commands/rebaseline.py:
3617         * Scripts/webkitpy/tool/commands/sheriffbot.py:
3618         * Scripts/webkitpy/tool/commands/upload.py:
3619         * Scripts/webkitpy/tool/multicommandtool.py:
3620
3621 2010-09-20  Adam Barth  <abarth@webkit.org>
3622
3623         I ran the tests before landing but ignored the fact that they failed.  :(
3624
3625         * Scripts/webkitpy/tool/commands/queues.py:
3626
3627 2010-09-20  Adam Barth  <abarth@webkit.org>
3628
3629         Reviewed by Eric Seidel.
3630
3631         Add a feeder queue that polls bugs.webkit.org for the commit-cluster
3632         https://bugs.webkit.org/show_bug.cgi?id=46141
3633
3634         The feeder-queue polls bugs.webkit.org every 30 seconds and updates the
3635         list of work items on the status server.  The individual commit-cluster
3636         nodes then grab the patches from the server and process them.
3637
3638         * Scripts/webkitpy/tool/bot/feeders.py: Added.
3639         * Scripts/webkitpy/tool/bot/feeders_unittest.py: Added.
3640         * Scripts/webkitpy/tool/commands/queues.py:
3641         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3642         * Scripts/webkitpy/tool/commands/queuestest.py:
3643
3644 2010-09-20  Leandro Pereira  <leandro@profusion.mobi>
3645
3646         Reviewed by Darin Adler.
3647
3648         build-webkit: Add support for CMake build system
3649         https://bugs.webkit.org/show_bug.cgi?id=44979
3650
3651         * Scripts/build-webkit: Add "--efl" command-line option to build the
3652         EFL port of WebKit.
3653         * Scripts/webkitdirs.pm: Define buildCMakeProject() and
3654         buildEflCMakeProject() subroutines.
3655
3656 2010-09-20  Dirk Pranke  <dpranke@chromium.org>
3657
3658         Reviewed by Ojan Vafai.
3659
3660         new-run-webkit-tests: refactor command line args getting passed to DRT
3661
3662         This change cleans up some argument parsing between functions to get
3663         rid of some overlapping data structures. There should be no functional
3664         changes in this patch; it is pure refactoring in preparation for
3665         landing the Chrome GPU port and adding a generic way to pass
3666         args to DRT/TestShell.
3667
3668         https://bugs.webkit.org/show_bug.cgi?id=46135
3669
3670         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3671           - pass the options argument explicitly to the threads and drivers,
3672             also consolidate the passing of options to the driver.
3673           - pass options directly to process_output() to remove a couple
3674             parameters (minor cleanup).
3675         * Scripts/webkitpy/layout_tests/port/base.py:
3676           - pass the options argument to Port.create_driver().
3677         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3678           - update Port.create_driver() test
3679         * Scripts/webkitpy/layout_tests/port/chromium.py:
3680           - pass the options argument to Port.create_driver(), and clean up
3681             building of the cmd line for DRT.
3682         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3683           - pass the options argument to Port.create_driver()
3684         * Scripts/webkitpy/layout_tests/port/test.py:
3685           - pass the options argument to Port.create_driver()
3686         * Scripts/webkitpy/layout_tests/port/webkit.py:
3687           - pass the options argument to Port.create_driver(), and clean up
3688             building of the cmd line for DRT.
3689         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3690           - consolidate args in _get_dump_render_tree_args and rename to
3691             _get_test_args(); move all of the command-line args to the
3692             Port implementations.
3693
3694 2010-09-20  Andrew Wilson  <atwilson@chromium.org>
3695
3696         Revert change which was accidentally committed along with some expectation changes.
3697
3698         * Scripts/webkitpy/layout_tests/port/base.py:
3699
3700 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
3701
3702         Reviewed by Adam Barth.
3703
3704         Add explicit --force-patch flag to webkitpy tools
3705         https://bugs.webkit.org/show_bug.cgi?id=46103
3706         
3707         It wasn't obvious until I read the applypatch.py source code that
3708         --non-interfactive implies passing --force to patch. Add --force-patch
3709         as an alias to the flag, so that this behavior is more discoverable.
3710
3711         * Scripts/webkitpy/tool/steps/applypatch.py:
3712         * Scripts/webkitpy/tool/steps/options.py:
3713
3714 2010-09-20  Eric Seidel  <eric@webkit.org>
3715
3716         Unreviewed, adding a line which got dropped and is trivially correct (and tested).
3717
3718         commit-queue can't land patches
3719         https://bugs.webkit.org/show_bug.cgi?id=46138
3720
3721         Add a line of code I forgot in my last commit.
3722
3723         * Scripts/webkitpy/common/net/bugzilla.py:
3724         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
3725
3726 2010-09-20  Adam Barth  <abarth@webkit.org>
3727
3728         Reviewed by Eric Seidel.
3729
3730         The commit-cluster bots still race to lock patch_ids
3731         https://bugs.webkit.org/show_bug.cgi?id=46130
3732
3733         It turns out we need to use a transaction object to make the
3734         read/modify/write lock operation atomic.  From reading the AppEngine
3735         documentation, I think this patch should do what we want.  It's hard to
3736         test locally because the test instance isn't distributed in the same
3737         way the production instance is.
3738
3739         * QueueStatusServer/handlers/nextpatch.py:
3740         * QueueStatusServer/model/activeworkitems.py: Added.
3741
3742 2010-09-20  Andy Estes  <aestes@apple.com>
3743
3744         Reviewed by Adam Barth.
3745
3746         REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
3747         https://bugs.webkit.org/show_bug.cgi?id=40961
3748
3749         Implement WebKitUsePreHTML5ParserQuirks preference.
3750
3751         * DumpRenderTree/mac/DumpRenderTree.mm:
3752         (resetDefaultsToConsistentValues): Reset WebKitUsePreHTML5ParserQuirks
3753         to false after a test finishes.
3754
3755 2010-09-20  Adam Roben  <aroben@apple.com>
3756
3757         Windows build fix
3758
3759         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Put
3760         $(WebKitOutputDir)\include before $(WebKitLibrariesDir)\include so
3761         we'll pick up the most recent versions of the headers.
3762
3763 2010-09-20  Eric Seidel  <eric@webkit.org>
3764
3765         Reviewed by Adam Barth.
3766
3767         commit-queue should check commit-queue+ again just before committing
3768         https://bugs.webkit.org/show_bug.cgi?id=32679
3769
3770         Added a _revalidate_patch check, right before landing.
3771
3772         Since _revalidate_patch passes the patch_id from the work item
3773         back to bugzilla, I had to fix all of the previous queue tests to
3774         use valid attachment ids (that's the majority of this change).
3775
3776         In order to validate that the bug was still open, I had to teach
3777         bugzilla.Bug about open/closed states.
3778
3779         * Scripts/webkitpy/common/net/bugzilla.py:
3780         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3781         * Scripts/webkitpy/tool/commands/queues.py:
3782         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3783         * Scripts/webkitpy/tool/commands/queuestest.py:
3784         * Scripts/webkitpy/tool/mocktool.py:
3785
3786 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
3787
3788         Unreviewed.
3789
3790         Adding myself as a comitter.
3791
3792         * Scripts/webkitpy/common/config/committers.py:
3793
3794 2010-09-20  Adam Barth  <abarth@webkit.org>
3795
3796         Reviewed by Eric Seidel.
3797
3798         Two instances of commit-queue try to process the same patch
3799         https://bugs.webkit.org/show_bug.cgi?id=46113
3800
3801         This patch makes next-patch atomic so that the server won't vend the
3802         same patch twice in the same hour.
3803
3804         * QueueStatusServer/handlers/nextpatch.py:
3805
3806 2010-09-20  Adam Roben  <aroben@apple.com>
3807
3808         Make WebKitTestRunner's wait-to-dump watchdog timer work on Windows
3809
3810         We were previously trying to use a CFRunLoopTimer, but since Windows
3811         doesn't use CFRunLoop on most threads this doesn't work. Now we use a
3812         Windows-style timer on Windows.
3813
3814         I also replaced all uses of "watchdog" with "watchdog timer".
3815
3816         Fixes <http://webkit.org/b/46101> WebKitTestRunner's wait-to-dump
3817         watchdog timer doesn't work on Windows
3818
3819         Reviewed by Anders Carlsson.
3820
3821         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3822         (WTR::InjectedBundlePage::dump): Updated for rename.
3823
3824         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Removed
3825         platform-specific functions.
3826         (WTR::LayoutTestController::LayoutTestController): Added call to
3827         platformInitialize.
3828         (WTR::LayoutTestController::waitUntilDone): Changed to call
3829         initializeWaitToDumpWatchdogTimerIfNeeded instead of doing the work
3830         right in this function.
3831         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Updated for
3832         rename.
3833
3834         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added new
3835         members needed to support the watchdog timer abstraction. Replaced
3836         some "watchdog"s with "watchdog timer".
3837
3838         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
3839         Added.
3840         (WTR::LayoutTestController::platformInitialize): Does nothing on this
3841         platform.
3842         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Moved here
3843         from LayoutTestController.cpp and changed to use an early return.
3844         (WTR::waitUntilDoneWatchdogTimerFired): Moved here from
3845         LayoutTestController.cpp.
3846         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
3847         Moved code here from LayoutTestController::waitUntilDone and changed
3848         to use an early return.
3849
3850         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
3851         Added.
3852         (WTR::LayoutTestController::platformInitialize): Initialize our
3853         watchdog timer.
3854         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Added.
3855         Kills and clears the watchdog timer.
3856         (WTR::waitToDumpWatchdogTimerFired): Added. Calls through to the
3857         LayoutTestController member function of the same name.
3858         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
3859         Added. Sets up the timer if it isn't already set.
3860
3861         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added
3862         LayoutTestControllerMac.mm.
3863
3864         * WebKitTestRunner/win/InjectedBundle.vcproj: Added
3865         LayoutTestControllerWin.cpp.
3866
3867 2010-09-20  Martin Robinson  <mrobinson@igalia.com>
3868
3869         Reviewed by Daniel Bates.
3870
3871         [GTK] fast/forms/listbox-selection.html fails
3872         https://bugs.webkit.org/show_bug.cgi?id=45942
3873
3874         Use the gdkModifersFromJSValue helper to parse all appropriate modifier
3875         strings in keyDownCallback.
3876
3877         * DumpRenderTree/gtk/EventSender.cpp:
3878         (keyDownCallback): Use the gdkModifersFromJSValue instead of duplicating the 
3879         modifier parsing logic.
3880
3881 2010-09-19  Sam Weinig  <sam@webkit.org>
3882
3883         Reviewed by Anders Carlsson.
3884
3885         WebKit2 decidePolicyForNavigationAction should include mouse button information
3886         <rdar://problem/8413165>
3887         https://bugs.webkit.org/show_bug.cgi?id=46060
3888
3889         * MiniBrowser/mac/BrowserWindowController.m:
3890         (decidePolicyForNavigationAction):
3891         (decidePolicyForNewWindowAction):
3892
3893 2010-09-19  Daniel Bates  <dbates@rim.com>
3894
3895         Reviewed by Martin Robinson.
3896
3897         Add unit tests for diffs that delete or modify a change log entry
3898         or describe changes that are far apart
3899         https://bugs.webkit.org/show_bug.cgi?id=46046
3900
3901         Add additional unit tests to test change log diffs that contain
3902         deletions or changes that are far apart from each other in the
3903         ChangeLog file.
3904
3905         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
3906           - Added the following unit tests:
3907           "fixChangeLogPatch: [no change] In-place change."
3908           "fixChangeLogPatch: [no change] Remove first entry."
3909           "fixChangeLogPatch: [no change] Remove entry in the middle."
3910           "fixChangeLogPatch: [no change] Far apart changes (i.e. more than one chunk)."
3911
3912 2010-09-19  Sam Weinig  <sam@webkit.org>
3913
3914         Reviewed by Anders Carlsson.
3915
3916         Replace WKBundleRangeRef with WKBundleRangeHandleRef.
3917         https://bugs.webkit.org/show_bug.cgi?id=46054
3918
3919         The new one acts like WKBundleNodeHandleRef and allows for getting a
3920         wrapper in a specific world for the handle.
3921
3922         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3923         (WTR::propertyValue):
3924         (WTR::propertyValueDouble):
3925         (WTR::propertyValueInt):
3926         (WTR::numericWindowPropertyValue):
3927         (WTR::toStr):
3928         (WTR::InjectedBundlePage::shouldBeginEditing):
3929         (WTR::InjectedBundlePage::shouldEndEditing):
3930         (WTR::InjectedBundlePage::shouldInsertNode):
3931         (WTR::InjectedBundlePage::shouldInsertText):
3932         (WTR::InjectedBundlePage::shouldDeleteRange):
3933         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
3934         (WTR::InjectedBundlePage::shouldApplyStyle):
3935         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3936
3937 2010-09-19  Kent Tamura  <tkent@chromium.org>
3938
3939         Unreviewed. Fix WebGL test regressions by r67809.
3940
3941         * DumpRenderTree/chromium/WebPreferences.cpp:
3942         (WebPreferences::applyTo): Call setExperimentalWebGLEnabled().
3943
3944 2010-09-19  Kent Tamura  <tkent@chromium.org>
3945
3946         Reviewed by Adam Barth.
3947
3948         [DRT/Chromium] Fix a WebSettings handling bug
3949         https://bugs.webkit.org/show_bug.cgi?id=45945
3950
3951         Before this change, Chromium DRT reset WebSettings for every new
3952         window. It was wrong.
3953         If new window is not the first one, we have to apply the same
3954         settings as the first window.  So, we introduce WebPreference to
3955         store the current settings, and apply it to new windows. It's same
3956         as test_shell's behavior.
3957
3958         * DumpRenderTree/DumpRenderTree.gypi:
3959         * DumpRenderTree/chromium/LayoutTestController.cpp:
3960           Use WebPreferences instead of WebSettings.
3961         (LayoutTestController::setUserStyleSheetEnabled):
3962         (LayoutTestController::setUserStyleSheetLocation):
3963         (LayoutTestController::setAuthorAndUserStylesEnabled):
3964         (LayoutTestController::setPopupBlockingEnabled):
3965         (LayoutTestController::disableImageLoading):
3966         (LayoutTestController::setJavaScriptCanAccessClipboard):
3967         (LayoutTestController::setXSSAuditorEnabled):
3968         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
3969         (LayoutTestController::setAllowFileAccessFromFileURLs):
3970         (LayoutTestController::overridePreference):
3971         (LayoutTestController::setEditingBehavior):
3972         * DumpRenderTree/chromium/TestShell.cpp:
3973         (TestShell::resetWebSettings): Use WebPreferences.
3974         (TestShell::runFileTest): ditto.
3975         (TestShell::createNewWindow): Apply existing WebPreferences to a new WebView.
3976         * DumpRenderTree/chromium/TestShell.h:
3977         (TestShell::preferences):
3978         (TestShell::applyPreferences):
3979         * DumpRenderTree/chromium/WebPreferences.cpp: Added.
3980         * DumpRenderTree/chromium/WebPreferences.h: Added.
3981
3982 2010-09-18  Prasad Tammana  <prasadt@chromium.org>
3983
3984         Reviewed by David Levin.
3985
3986         update-webkit --chromium spitting out a spurious error
3987         https://bugs.webkit.org/show_bug.cgi?id=45868
3988
3989         * Scripts/update-webkit-chromium: Use commandExists() function to check for existence of gclient.
3990
3991 2010-09-18  Sam Weinig  <sam@webkit.org>
3992
3993         Reviewed by Dan Bernstein.
3994
3995         Improve/unify the PageLoadClient interfaces
3996         https://bugs.webkit.org/show_bug.cgi?id=46043
3997
3998         * MiniBrowser/mac/BrowserWindowController.m:
3999         (didStartProvisionalLoadForFrame):
4000         (didReceiveServerRedirectForProvisionalLoadForFrame):
4001         (didFailProvisionalLoadWithErrorForFrame):
4002         (didCommitLoadForFrame):
4003         (didFinishDocumentLoadForFrame):
4004         (didFinishLoadForFrame):
4005         (didFailLoadWithErrorForFrame):
4006         (didReceiveTitleForFrame):
4007         (didFirstLayoutForFrame):
4008         (didFirstVisuallyNonEmptyLayoutForFrame):
4009         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4010         (WTR::InjectedBundlePage::InjectedBundlePage):
4011         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
4012         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
4013         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
4014         (WTR::InjectedBundlePage::didCommitLoadForFrame):
4015         (WTR::InjectedBundlePage::didFinishLoadForFrame):
4016         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
4017         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
4018         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
4019         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
4020         * WebKitTestRunner/TestController.cpp:
4021         (WTR::TestController::didReceiveMessageFromInjectedBundle):
4022         (WTR::TestController::didFinishLoadForFrame):
4023         * WebKitTestRunner/TestController.h:
4024
4025 2010-09-17  Eric Seidel  <eric@webkit.org>
4026
4027         Unreviewed.  Adding a shell script I use to run the
4028         commit-queue. Now that multiple machines run the cq,
4029         it makes sense to share the script between them.
4030
4031         * EWSTools/start-commit-queue.sh: Added.
4032
4033 2010-09-17  Brian Weinstein  <bweinstein@apple.com>
4034
4035         Reviewed by Jon Honeycutt.
4036
4037         The colors on the new build.webkit.org (after upgrading the master to 0.8.1) are
4038         slightly harder to read, so this reverts the previous background colors for various
4039         states, making it easier to read.
4040
4041         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
4042         (.success):
4043         (.failure):
4044         (.warnings):
4045         (.exception):
4046         (.start,.running,td.building):
4047         (.offline,td.offline):
4048
4049 2010-09-17  Sheriff Bot  <webkit.review.bot@gmail.com>
4050
4051         Unreviewed, rolling out r67692.
4052         http://trac.webkit.org/changeset/67692
4053         https://bugs.webkit.org/show_bug.cgi?id=46011
4054
4055         broke layout test dashboard (Requested by johnny_g on
4056         #webkit).
4057
4058         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
4059         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
4060         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4061
4062 2010-09-17  Martin Robinson  <mrobinson@igalia.com>
4063
4064         Reviewed by Oliver Hunt.
4065
4066         Style bot complains about cairo forward declaration naming
4067         https://bugs.webkit.org/show_bug.cgi?id=45867
4068
4069         Exclude Cairo forward declarations from indentifiers with underscores checks.
4070
4071         * Scripts/webkitpy/style/checkers/cpp.py: Add exclusion for Cairo forward-declarations.
4072         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
4073
4074 2010-09-16  Kinuko Yasuda  <kinuko@chromium.org>
4075
4076         Reviewed by Ojan Vafai.
4077
4078         Include detailed test modifiers (e.g. FLAKY) in results.json for failing non-layout tests
4079         https://bugs.webkit.org/show_bug.cgi?id=45408
4080
4081         This change also tries to remove duplicated upload_results_json methods
4082         in run_webkit_tests.py and json_results_generator.py.
4083
4084         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
4085         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
4086         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4087
4088 2010-09-16  Antonio Gomes  <tonikitoo@webkit.org>
4089
4090         Reviewed by Andreas Kling.
4091
4092         [Qt] When switching views (WebViewGraphicsBased <--> WebViewTraditional), QWebPage signals and QActions have to be re-set.
4093
4094         Recently r67554 changed the way different views use the WebPage class: it was previously being shared between
4095         different views, but now for each view switch, a new WebPage class is constructed and set. Signals and QAction's
4096         were not being set to the new WebPage though. Patch fix that, by re constructing the toolbar, and then re-hooking
4097         all page specific stuff to the UI.
4098
4099         * QtTestBrowser/launcherwindow.cpp:
4100         (LauncherWindow::initializeView):
4101         * QtTestBrowser/mainwindow.cpp:
4102         (MainWindow::MainWindow):
4103         (MainWindow::buildUI):
4104         (MainWindow::setPage):
4105         * QtTestBrowser/mainwindow.h:
4106
4107 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
4108
4109         Reviewed by Andreas Kling.
4110
4111         Make all accesses to m_item (GraphicsWebView) done by WebViewGraphicsBased class happen though graphicsWebView getter method.
4112
4113         This patch is mostly a preparation for another commit, where the ownership of the m_item/GraphicsWebView
4114         object will move to the qgraphicsscene instead of the qgraphicsview.
4115
4116         * QtTestBrowser/webview.cpp:
4117         (WebViewGraphicsBased::setPage):
4118         (WebViewGraphicsBased::setResizesToContents):
4119         (WebViewGraphicsBased::resizeEvent):
4120         (WebViewGraphicsBased::animatedFlip):
4121         * QtTestBrowser/webview.h:
4122         (WebViewGraphicsBased::setItemCacheMode):
4123         (WebViewGraphicsBased::itemCacheMode):
4124
4125 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
4126
4127         Reviewed by Andreas Kling.
4128
4129         Moved setYRotation method body out of the class (WebViewGraphicsBased) definition.
4130
4131         We usually separate methods whose body are larger than a few lines from the class definition.
4132
4133         * QtTestBrowser/webview.h:
4134         (WebViewGraphicsBased::yRotation):
4135         (WebViewGraphicsBased::setYRotation):
4136
4137 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
4138
4139         Reviewed by Andreas Kling.
4140
4141         Make initializeView method of LauncherWindow private.
4142
4143         No one else needs to be able to call it but LauncherWindow.
4144         Also moving the declation of isGraphicsBased method down in the same file, in order
4145         to better group related methods.
4146
4147         * QtTestBrowser/launcherwindow.h:
4148
4149 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
4150
4151         Reviewed by Andreas Kling.
4152
4153         Make the getter 'page' method of MainWindow const.
4154
4155         * QtTestBrowser/mainwindow.cpp:
4156         (MainWindow::page):
4157         * QtTestBrowser/mainwindow.h:
4158
4159 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
4160
4161         Reviewed by Andreas Kling.
4162
4163         Remove useless parameter from MainWindow class' constructor.
4164
4165         The parameter defaults to an empty URL and is not being used by any caller. Apart from that it is also
4166         not referred in the constructor body and does not make much sense.
4167
4168         * QtTestBrowser/mainwindow.cpp:
4169         (MainWindow::MainWindow):
4170         * QtTestBrowser/mainwindow.h:
4171
4172 2010-09-15  Tony Chang  <tony@chromium.org>
4173
4174         Reviewed by Kent Tamura.
4175
4176         [Chromium] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
4177         https://bugs.webkit.org/show_bug.cgi?id=42151
4178
4179         * DumpRenderTree/chromium/LayoutTestController.cpp:
4180         (LayoutTestController::LayoutTestController):
4181         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
4182         (WorkItemLoadHTMLString::run):
4183         (LayoutTestController::queueLoadHTMLString):
4184         (LayoutTestController::reset):
4185         (LayoutTestController::setDeferMainResourceDataLoad):
4186         * DumpRenderTree/chromium/LayoutTestController.h:
4187         (LayoutTestController::deferMainResourceDataLoad):
4188         * DumpRenderTree/chromium/WebViewHost.cpp:
4189         (WebViewHost::didCreateDataSource):
4190
4191 2010-09-16  Adrienne Walker  <enne@google.com>
4192
4193         Reviewed by Kenneth Russell.
4194
4195         Add script to synchronize WebKit and Khronos WebGL tests
4196         https://bugs.webkit.org/show_bug.cgi?id=42336
4197
4198         * Scripts/update-webgl-conformance-tests: Added.
4199         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py: Added.
4200         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py: Added.
4201
4202 2010-09-16  Sam Weinig  <sam@webkit.org>
4203
4204         Reviewed by Anders Carlsson.
4205
4206         Add support for sending synchronous messages from the InjectedBundle to the WKContext
4207         <rdar://problem/8365320>
4208         https://bugs.webkit.org/show_bug.cgi?id=44785
4209
4210         * MiniBrowser/mac/AppDelegate.m:
4211         (didReceiveSynchronousMessageFromInjectedBundle):
4212         (-[BrowserAppDelegate init]):
4213         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
4214         (didCreatePage):
4215         * WebKitTestRunner/TestController.cpp:
4216         (WTR::TestController::initialize):
4217
4218 2010-09-16  Leonid Ebril  <leonid.ebril@nokia.com>
4219
4220         Reviewed by Andreas Kling.
4221
4222         [Qt] QtTestBrowser: Disable creation of a new window for screenshot on Symbian platform.
4223         https://bugs.webkit.org/show_bug.cgi?id=45885
4224
4225         Avoid creation of an additional window for screenshot to prevent overlapping with original window.
4226
4227         * QtTestBrowser/launcherwindow.cpp:
4228         (LauncherWindow::screenshot):
4229
4230 2010-09-16  An