2010-02-08 Maciej Stachowiak <mjs@apple.com>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-02-08  Maciej Stachowiak  <mjs@apple.com>
2
3         Reviewed by Cameron Zwarich.
4
5         Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose.
6         https://bugs.webkit.org/show_bug.cgi?id=34698
7
8         * Scripts/build-webkit:
9
10 2010-02-10  Dirk Pranke  <dpranke@chromium.org>
11
12         Reviewed by Eric Seidel.
13
14         Fix various minor bugs keeping run-chromium-webkit-tests from actually
15         working on the linux and win ports of Chromium.
16
17         https://bugs.webkit.org/show_bug.cgi?id=34739
18
19         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
20         * Scripts/webkitpy/layout_tests/port/__init__.py:
21         * Scripts/webkitpy/layout_tests/port/base.py:
22         * Scripts/webkitpy/layout_tests/port/chromium.py:
23         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
24         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
25         * Scripts/webkitpy/layout_tests/port/http_server.py:
26         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
27
28 2010-02-10  Eric Seidel  <eric@webkit.org>
29
30         Reviewed by David Levin.
31
32         run-chromium-webkit-tests --platform=mac-leopard crashes when using a custom build directory
33         https://bugs.webkit.org/show_bug.cgi?id=34817
34
35         This doesn't fix the root cause of us not
36         correctly failing when support binaries are missing.
37         This only causes the DumpRenderTree binary not to be
38         missing in the custom build directory case.
39         Later patches will make us correctly fail fast when
40         support binaries (like DumpRenderTree or ImageDiff) are missing.
41
42         * Scripts/webkit-build-directory: Added.
43          - Need a way to re-use the perl logic for finding build directories in non-perl scripts.
44         * Scripts/webkitpy/layout_tests/port/base.py: Add a FIXME.
45         * Scripts/webkitpy/layout_tests/port/mac.py:
46          - Call webkit-build-directory to find the build directory instead of assuming "WebKitBuild"
47         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Add FIXMEs.
48
49 2010-02-10  Kevin Watters  <kevinwatters@gmail.com>
50
51         Reviewed by Kevin Ollivier.
52
53         [wx] Add Windows complex text support.
54         
55         https://bugs.webkit.org/show_bug.cgi?id=34759
56
57         * wx/build/settings.py:
58
59 2010-02-10  Kevin Ollivier  <kevino@theolliviers.com>
60
61         [wx] Build fix. Add stub for new LayoutTestController method.
62
63         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
64         (LayoutTestController::numberOfPages):
65
66 2010-02-10  Csaba Osztrogonác  <ossy@webkit.org>
67
68         Unreviewed. Roll out r54626, because it broke GTK and Win build.
69         https://bugs.webkit.org/show_bug.cgi?id=32717
70
71         * DumpRenderTree/LayoutTestController.cpp:
72         (LayoutTestController::staticFunctions):
73         * DumpRenderTree/LayoutTestController.h:
74         * DumpRenderTree/mac/DumpRenderTree.mm:
75         (resetDefaultsToConsistentValues):
76         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
77
78 2010-02-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
79
80         Reviewed by Kenneth Rohde Christiansen.
81
82         Support frameset flattening
83         https://bugs.webkit.org/show_bug.cgi?id=32717
84
85         Add FrameSet Flattening support to Mac DRT.
86
87         * DumpRenderTree/LayoutTestController.cpp:
88         (setFrameSetFlatteningEnabledCallback):
89         (LayoutTestController::staticFunctions):
90         * DumpRenderTree/LayoutTestController.h:
91         * DumpRenderTree/mac/DumpRenderTree.mm:
92         (resetDefaultsToConsistentValues):
93         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
94         (LayoutTestController::setFrameSetFlatteningEnabled):
95
96 2010-02-08  Jon Honeycutt  <jhoneycutt@apple.com>
97
98         <rdar://problem/7436875> Crash in Flash when visiting
99         http://www.cctv.com/default.shtml (WER ID 819298200) [watson 2502260]
100
101         Reviewed by Darin Adler.
102
103         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
104         (executeScript):
105         Moved to an earlier point in the file.
106         (NPP_New):
107         If the plug-in has an onDestroy attribute, store its value.
108         (NPP_Destroy):
109         If the plug-in has code to run on destruction, run it and free it.
110
111 2010-02-10  Diego Gonzalez  <diego.gonzalez@openbossa.org>
112
113         Reviewed by Kenneth Rohde Christiansen.
114
115         Implement pageNumberForElementById() method in Qt DRT LayoutTestController,
116         to make Qt DRT able to get page number.
117
118         LayoutTests:
119             printing/page-break-always.html
120             printing/pageNumerForElementById.html
121             printing/css2.1/page-break-before-000.html
122             printing/css2.1/page-break-after-000.html
123             printing/css2.1/page-break-after-004.html
124             printing/css2.1/page-break-before-001.html
125             printing/css2.1/page-break-after-001.html
126             printing/css2.1/page-break-after-002.html
127             printing/css2.1/page-break-before-002.html
128             printing/css2.1/page-break-inside-000.html
129
130         [Qt] Make possible Qt DRT get a page number for element by ID
131         https://bugs.webkit.org/show_bug.cgi?id=34777
132
133         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
134         (LayoutTestController::pageNumberForElementById):
135         * DumpRenderTree/qt/LayoutTestControllerQt.h:
136
137 2010-02-10  Andras Becsi  <abecsi@webkit.org>
138
139         Reviewed by Adam Barth.
140
141         Make run-iexploder-tests work on Linux.
142         https://bugs.webkit.org/show_bug.cgi?id=34748
143
144         Extract the platform dependant Apache configuration checking code in httpd.pm to a separate function
145         called getHTTPDConfigPathForTestDirectory and use run-launcher instead of run-safari if run on Linux.
146
147         * Scripts/run-iexploder-tests:
148         * Scripts/webkitperl/httpd.pm:
149
150 2010-02-09  Csaba Osztrogonác  <ossy@webkit.org>
151
152         [Qt] Unreviewed. Roll-out r54543, because layout tests crash in debug mode.
153         https://bugs.webkit.org/show_bug.cgi?id=34713
154
155         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
156         (WebCore::WebPage::WebPage):
157         * DumpRenderTree/qt/main.cpp:
158         (main):
159
160 2010-02-09  Alejandro G. Castro  <alex@igalia.com>
161
162         Unreviewed; added myself to committers
163
164         * Scripts/webkitpy/committers.py:
165
166 2010-02-09  Yael Aharon  <yael.aharon@nokia.com>
167
168         Reviewed by Kenneth Rohde Christiansen.
169
170         [Qt] Webkit in Qt does not have window.showModalDialog
171         https://bugs.webkit.org/show_bug.cgi?id=25585
172
173         Set the modality flag when createWindow is called with window type WebWindowDialog.
174
175         * QtLauncher/main.cpp:
176         (WebPage::createWindow):
177
178 2010-02-09  Andras Becsi  <abecsi@webkit.org>
179
180         Unreviewed trivial warning fix.
181
182         * Scripts/build-webkit:
183
184 2010-02-09 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu>
185
186         Reviewed by Tor Arne Vestbø.
187
188         Add possibility of passing parameters to build-webkit by environment variable,
189         because the buildbot slaves can't control the arguments.
190
191         * Scripts/build-webkit:
192
193 2010-02-09  Chang Shu  <Chang.Shu@nokia.com>
194
195         Reviewed by Laszlo Gombos.
196
197         [Qt] Enable appcache feature.
198         https://bugs.webkit.org/show_bug.cgi?id=34713
199
200
201         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
202         (WebCore::WebPage::WebPage):
203         * DumpRenderTree/qt/main.cpp:
204         (main):
205
206 2010-02-09  Shinichiro Hamaji  <hamaji@chromium.org>
207
208         Reviewed by Darin Adler.
209
210         Provide a way to get total number of pages to be printed
211         https://bugs.webkit.org/show_bug.cgi?id=34699
212
213         * DumpRenderTree/LayoutTestController.cpp:
214         (parsePageParameters):
215         (pageNumberForElementByIdCallback):
216         (numberOfPagesCallback):
217         (LayoutTestController::staticFunctions):
218         * DumpRenderTree/LayoutTestController.h:
219         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
220         (LayoutTestController::numberOfPages):
221         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
222         (LayoutTestController::numberOfPages):
223         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
224         (LayoutTestController::numberOfPages):
225
226 2010-02-08  Alexey Proskuryakov  <ap@apple.com>
227
228         Reviewed by Darin Adler.
229
230         https://bugs.webkit.org/show_bug.cgi?id=34727
231         Assertion crashes and freezes when plug-in property access results in an exception
232
233         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
234         (pluginGetProperty): Raise an exception when accessing a particular property.
235         (pluginSetProperty): Ditto.
236         (pluginInvoke): Added methods to get and set host object properties.
237
238 2010-02-08  Kenneth Rohde Christiansen  <kenneth@webkit.org>
239
240         Reviewed by Ariya Hidayat.
241
242         [Qt] Backport No'am Rosenthal's frame rate measurement
243
244         * QtLauncher/main.cpp:
245         (LauncherWindow::LauncherWindow):
246         (LauncherApplication::handleUserOptions):
247         * QtLauncher/webview.cpp:
248         (WebViewGraphicsBased::WebViewGraphicsBased):
249         (WebViewGraphicsBased::enableFrameRateMeasurement):
250         (WebViewGraphicsBased::updateFrameRate):
251         (WebViewGraphicsBased::paintEvent):
252         * QtLauncher/webview.h:
253
254 2010-02-08  Kenneth Rohde Christiansen  <kenneth@webkit.org>
255
256         Reviewed by Tor Arne Vestbø.
257
258         [Qt] Make overridePreference complain when it does not
259         support the preference given.
260
261         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
262         (LayoutTestController::overridePreference):
263
264 2010-02-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
265
266         Reviewed by Kenneth Rohde Christiansen.
267
268         [Qt] Set stdout/stderr to binary mode for DRT on Windows
269
270         This makes sure we don't end up with lots of CRLFs in the
271         DRT output, which breaks tons of results. Matches what
272         the Windows DRT does.
273
274         * DumpRenderTree/qt/main.cpp:
275
276 2010-02-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
277
278         Reviewed by Kenneth Rohde Christiansen.
279
280         Build fix for Qt on Windows.
281
282         Don't use noreturn directly since it's a gcc attribute.
283         Instead use the NO_RETURN macro from AlwaysInline.h
284
285         * QtLauncher/QtLauncher.pro:
286         * QtLauncher/utils.h:
287
288 2010-02-05  Chris Jerdonek  <cjerdonek@webkit.org>
289
290         Reviewed by Shinichiro Hamaji.
291
292         Suppressed check-webkit-style's underscore check in Qt's autotests.
293         Also made the path-specific filter check case-insensitive.
294
295         https://bugs.webkit.org/show_bug.cgi?id=34574
296
297         * Scripts/webkitpy/style/checker.py:
298           - Added a list element to _PATH_RULES_SPECIFIER for
299             directories that should be excluded from the
300             "readability/naming" category (the category that relates to
301             underscores in identifiers, for example).
302
303         * Scripts/webkitpy/style/checker_unittest.py:
304           - Added an "end-to-end" test for "WebKit/qt/tests/".
305
306         * Scripts/webkitpy/style/filter.py:
307           - Altered FilterConfiguration's should_check() method to
308             check for path substring matches case-insensitively.
309
310         * Scripts/webkitpy/style/filter_unittest.py:
311           - Added a test to check case-insensitive path substring matching.
312
313         * Scripts/webkitpy/style/processors/cpp.py:
314           - Removed the hard-coded "WebKit/gtk/webkit/" path reference
315             since this is now taken care of by the _PATH_RULES_SPECIFIER
316             configuration variable.
317
318         * Scripts/webkitpy/style/processors/cpp_unittest.py:
319           - Removed the unit test for the GTK directory since this
320             is now taken care of by the checker._PATH_RULES_SPECIFIER
321             end-to-end tests.
322
323 2010-02-08  Leith Bade  <leith@leithalweapon.geek.nz>
324
325         Reviewed by Darin Adler.
326
327         Fixes: https://bugs.webkit.org/show_bug.cgi?id=34637
328         Corrects the newline inserted into WebKitOutputDir, and WebKitLibrariesDir Windows
329         environemnt variables when there is a space in the user's /home path.
330
331         * Scripts/webkitdirs.pm:
332          - Added missing quotes around $sourceDir in argument list of cygpath in determineWindowsSourceDir().
333
334 2010-02-05  Alexey Proskuryakov  <ap@apple.com>
335
336         Reviewed by Oliver Hunt.
337
338         https://bugs.webkit.org/show_bug.cgi?id=34670
339         TestNetscapePlugin should work with Firefox
340
341         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New): Default to Carbon if
342         browser doesn't tell what it supports.
343
344 2010-02-05  Shinichiro Hamaji  <hamaji@chromium.org>
345
346         Reviewed by Gustavo Noronha Silva.
347
348         [Gtk] Implement layoutTestController.pageNumberForElementById
349         https://bugs.webkit.org/show_bug.cgi?id=34572
350
351         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
352         (LayoutTestController::pageNumberForElementById):
353
354 2010-02-03  Dirk Pranke  <dpranke@chromium.org>
355
356         Reviewed by Eric Seidel.
357
358         Add a simple test implementation and the WebKit Mac implementation
359         for the layout_tests/port package. Also add a simple test driver of
360         that interface.
361
362         https://bugs.webkit.org/show_bug.cgi?id=34511
363
364         * Scripts/webkitpy/layout_tests/driver_test.py: Added.
365         * Scripts/webkitpy/layout_tests/port/__init__.py:
366         * Scripts/webkitpy/layout_tests/port/mac.py: Added.
367         * Scripts/webkitpy/layout_tests/port/test.py: Added.
368
369 2010-02-03  Dirk Pranke  <dpranke@chromium.org>
370
371         Reviewed by Eric Siedel.
372
373         Refactor the port package into an object-oriented style and merge
374         path_utils into it. We add a 'base' and a 'chromium' object to the
375         port package; this will allow us to easily add new ports (like
376         WebKit Mac).
377
378         https://bugs.webkit.org/show_bug.cgi?id=34511
379
380         * Scripts/rebaseline-chromium-webkit-tests:
381         * Scripts/run-chromium-webkit-tests:
382         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
383         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
384         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
385         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
386         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
387         * Scripts/webkitpy/layout_tests/port/__init__.py:
388         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
389         * Scripts/webkitpy/layout_tests/port/base.py: Added.
390         * Scripts/webkitpy/layout_tests/port/chromium.py: Added.
391         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
392         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
393         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
394         * Scripts/webkitpy/layout_tests/port/http_server.py:
395         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
396         * Scripts/webkitpy/layout_tests/port/path_utils.py: Removed.
397         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
398         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
399         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
400         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
401         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
402         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
403         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
404
405 2010-01-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
406
407         Reviewed by Dave Hyatt.
408
409         Implement flattening of framesets
410         https://bugs.webkit.org/show_bug.cgi?id=32717
411
412         Add support for testing frame flattening with the Qt DRT
413
414         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
415         (LayoutTestController::setFrameSetFlatteningEnabled):
416         * DumpRenderTree/qt/LayoutTestControllerQt.h:
417
418 2010-02-03  Chris Jerdonek  <cjerdonek@webkit.org>
419
420         Reviewed by Shinichiro Hamaji.
421
422         Provided a way in check-webkit-style to specify filter rules
423         on a per file or folder basis, via a configuration variable.
424
425         https://bugs.webkit.org/show_bug.cgi?id=33684
426
427         * Scripts/webkitpy/style/checker.py:
428           - Added _PATH_RULES_SPECIFIER configuration variable.
429           - In ProcessorOptions class--
430             - Changed the CategoryFilter attribute to FilterConfiguration.
431             - Added path parameter to is_reportable().
432           - Renamed ArgumentDefaults filter_rules attribute to
433             base_filter_rules.
434           - Updated ArgumentPrinter class.
435           - Added filter rule validation to ArgumentParser (instead of
436             in CategoryFilter constructor).
437
438         * Scripts/webkitpy/style/checker_unittest.py:
439           - Updated unit tests as necessary.
440           - Added unit tests for PATH_RULES_SPECIFIER.
441
442         * Scripts/webkitpy/style/error_handlers.py:
443           - Updated DefaultStyleErrorHandler to use file path when
444             calling is_reportable().
445
446         * Scripts/webkitpy/style/error_handlers_unittest.py:
447           - Updated unit tests as necessary.
448
449         * Scripts/webkitpy/style/filter.py:
450           - Marked CategoryFilter internal with an underscore.
451           - Removed argument validation from CategoryFilter.
452           - Added FilterConfiguration class.
453
454         * Scripts/webkitpy/style/filter_unittest.py:
455           - Updated CategoryFilterTest class.
456           - Added FilterConfigurationTest unit tests.
457
458         * Scripts/webkitpy/style/processors/cpp.py:
459           - Removed _is_test_filename() code.
460           - Removed hard-coded path checks from check_include_line().
461
462         * Scripts/webkitpy/style/processors/cpp_unittest.py:
463           - Removed three unit tests related to exempted files.
464
465 2010-02-05  Kenneth Rohde Christiansen  <kenneth@webkit.org>
466
467         Reviewed by Ariya Hidayat.
468
469         [Qt] Apply the command line options as settings to the
470         graphics system.
471
472         * QtLauncher/main.cpp:
473         (LauncherWindow::LauncherWindow):
474         (requiresGraphicsView):
475         (LauncherApplication::handleUserOptions):
476         * QtLauncher/webview.h:
477         (WebViewGraphicsBased::setItemCacheMode):
478
479 2010-02-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
480
481         Reviewed by Simon Hausmann.
482
483         Notify user that run-webkit-tests has to be run under Cygwin
484
485         The script will bail out if run under Windows shell or Msys.
486
487         * Scripts/run-webkit-tests:
488         * Scripts/webkitdirs.pm:
489
490 2010-02-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
491
492         Reviewed by Simon Hausmann.
493
494         [Qt] Generate convenience headers (QWebView, etc) using qmake
495
496         In Qt this is done using syncqt, but we use a pro-file instead
497         that generates makefile-rules for each of the extra headers.
498
499         These extra headers are installed alongside the normal headers.
500
501         * Scripts/webkitdirs.pm: Run qmake and make on new API-DerivedSources
502
503 2010-02-05  Andras Becsi  <abecsi@webkit.org>
504
505         Unreviewed typo fix.
506
507         Fix wrong whitespace alignment introduced in r54342.
508
509         * Scripts/run-webkit-tests:
510
511 2010-02-04  Mark Rowe  <mrowe@apple.com>
512
513         Reviewed by Timothy Hatcher.
514
515         Build fix.  Remove a symbol corresponding to an inline function from the linker export
516         file to prevent a weak external failure.
517
518         * Scripts/check-for-weak-vtables-and-externals: Renamed from WebKitTools/Scripts/check-for-weak-vtables.
519         Teach the script how to detect weak external symbols so that these errors can be caught immediately
520         in the future.
521
522 2010-02-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
523
524         Rubberstamped by Oliver Hunt.
525
526         [Qt] Make it possible to choose whether the launcher should
527         use the traditional QWidget based QWebView or the newer
528         QGraphics based QGraphicsWebView on a QGraphicsView.
529
530         * QtLauncher/main.cpp:
531         (LauncherWindow::LauncherWindow):
532         (LauncherWindow::eventFilter):
533         (LauncherWindow::loadStarted):
534         (LauncherWindow::print):
535         (LauncherWindow::screenshot):
536         (LauncherWindow::setEditable):
537         (LauncherWindow::setupUI):
538         (main):
539         * QtLauncher/webview.cpp:
540         (WebViewGraphicsBased::WebViewGraphicsBased):
541         (WebViewGraphicsBased::resizeEvent):
542         (GraphicsWebView::mousePressEvent):
543         (GraphicsWebView::contextMenuEvent):
544         * QtLauncher/webview.h:
545         (WebViewTraditional::WebViewTraditional):
546         (GraphicsWebView::GraphicsWebView):
547         (WebViewGraphicsBased::setPage):
548
549 2010-02-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
550
551         Rubberstamped by Oliver Hunt.
552
553         [Qt] QtLauncher cleanup.
554
555         Refactor option handling out in utility functions and make the
556         arguments more Qt compatible.
557
558         * QtLauncher/main.cpp:
559         (requiresGraphicsView):
560         (LauncherApplication::handleUserOptions):
561         * QtLauncher/utils.cpp:
562         (takeOptionValue):
563         (formatKeys):
564         (enumToKeys):
565         (appQuit):
566         * QtLauncher/utils.h:
567
568 2010-02-04  Andras Becsi  <abecsi@inf.u-szeged.hu>
569
570         Reviewed by Tor Arne Vestbø.
571
572         Implement a locking and scheduling mechanism for http testing sessions to be able
573         to run multiple instances of run-webkit-tests parallel on the same machine.
574         If a test session wants to run http tests and this feature is enabled, the pending
575         sessions create lockfiles with sequential lock numbers. These locks are used to schedule
576         the running test sessions in first come first served order. An exclusive lock ensures
577         that the lock numbers are sequential to avoid deadlocks and starvation.
578         Because the buildbot master specifies the flags used by slaves we need an environment
579         variable too to be able to use the feature per-slave.
580         Exporting WEBKIT_WAIT_FOR_HTTPD=1 before testing or using the --wait-for-httpd
581         flag enables this feature, otherwise this patch has no effect on the testing whatsoever.
582
583         https://bugs.webkit.org/show_bug.cgi?id=33153
584
585         * Scripts/run-webkit-tests:
586         * Scripts/webkitperl/httpd.pm:
587
588 2010-01-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
589
590         Reviewed by Simon Hausmann.
591
592         Make run-webkit-tests work under Cygwin for the Qt port
593
594         setPathForRunningWebKitApp() is implemented for the Qt port
595         by using qmake to query for the location of the Qt libraries.
596
597         This requires the original environment (%ENV) to be untouched,
598         so launchWithCurrentEnv() was refactored to launchWithEnv(),
599         and the code in openDumpTool() to not use %ENV but a %CLEAN_ENV
600         instead. This has the added benefit of getting rid of the temp
601         variables used for storing the current env.
602
603         openDumpTool() is also refactored a bit into platform-spesific,
604         port-spesific, and generic environment variables.
605
606         Checks for undef was added a few places to fix Perl concat
607         warnings when run-webkit-tests is aborted.
608
609         https://bugs.webkit.org/show_bug.cgi?id=33895
610
611         * Scripts/run-webkit-tests:
612         * Scripts/webkitdirs.pm:
613
614 2010-02-04  Yuzo Fujishima  <yuzo@google.com>
615
616         Unreviewed.
617
618         Add Yuzo to the committers list.
619
620         * Scripts/webkitpy/committers.py:
621
622 2010-02-03  Dirk Pranke  <dpranke@chromium.org>
623
624         Rubber-stamped by Eric Seidel.
625
626         Change "the Chromium name" to "the name of Google Inc." in the licenses
627
628         https://bugs.webkit.org/show_bug.cgi?id=34511
629
630         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
631         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
632         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
633         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
634         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
635         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
636         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
637         * Scripts/webkitpy/layout_tests/port/__init__.py:
638         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
639         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
640         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
641         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
642         * Scripts/webkitpy/layout_tests/port/http_server.py:
643         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
644         * Scripts/webkitpy/layout_tests/port/path_utils.py:
645         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
646         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
647         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
648         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
649         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
650         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
651         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
652
653 2010-02-03  Dirk Pranke  <dpranke@chromium.org>
654
655         Rubber-stamped by Eric Siedel.
656
657         Rename files as part of refactoring the layout_tests package. All
658         the platform_utils* module, the path_utils.py module, and
659         the http server and web socket server modules are moved into a new
660         port/ package.
661
662         https://bugs.webkit.org/show_bug.cgi?id=34511
663
664         * Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py: Removed.
665         * Scripts/webkitpy/layout_tests/layout_package/http_server.py: Removed.
666         * Scripts/webkitpy/layout_tests/layout_package/http_server_base.py: Removed.
667         * Scripts/webkitpy/layout_tests/layout_package/httpd2.pem: Removed.
668         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
669         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
670         * Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf: Removed.
671         * Scripts/webkitpy/layout_tests/layout_package/path_utils.py: Removed.
672         * Scripts/webkitpy/layout_tests/layout_package/platform_utils.py: Removed.
673         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py: Removed.
674         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py: Removed.
675         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py: Removed.
676         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
677         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
678         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
679         * Scripts/webkitpy/layout_tests/layout_package/websocket_server.py: Removed.
680         * Scripts/webkitpy/layout_tests/port: Added.
681         * Scripts/webkitpy/layout_tests/port/__init__.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils.py.
682         * Scripts/webkitpy/layout_tests/port/apache_http_server.py: Copied from Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py.
683         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py.
684         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py.
685         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py.
686         * Scripts/webkitpy/layout_tests/port/http_server.py: Copied from Scripts/webkitpy/layout_tests/layout_package/http_server.py.
687         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Copied from Scripts/webkitpy/layout_tests/layout_package/http_server_base.py.
688         * Scripts/webkitpy/layout_tests/port/httpd2.pem: Copied from Scripts/webkitpy/layout_tests/layout_package/httpd2.pem.
689         * Scripts/webkitpy/layout_tests/port/lighttpd.conf: Copied from Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf.
690         * Scripts/webkitpy/layout_tests/port/path_utils.py: Copied from Scripts/webkitpy/layout_tests/layout_package/path_utils.py.
691         * Scripts/webkitpy/layout_tests/port/websocket_server.py: Copied from Scripts/webkitpy/layout_tests/layout_package/websocket_server.py.
692         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
693         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
694         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
695         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
696         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
697         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
698
699
700 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
701
702         Rubber-stamped by Eric Seidel.
703
704         Roll back r53559 and r54084 again, because roll out didn't solve flakeyness on the Windows Test bots
705         https://bugs.webkit.org/show_bug.cgi?id=34399
706
707         * Scripts/run-iexploder-tests:
708         * Scripts/run-webkit-httpd:
709         * Scripts/run-webkit-tests:
710         * Scripts/webkitperl/httpd.pm: Added.
711
712 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
713
714         Rubber-stamped by Eric Seidel.
715
716         Roll out r53559 and r54084, because it might caused flakeyness on the Windows Test bots
717
718         * Scripts/run-iexploder-tests:
719         * Scripts/run-webkit-httpd:
720         * Scripts/run-webkit-tests:
721         * Scripts/webkitperl/httpd.pm: Removed.
722
723 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
724
725         Rubber-stamped by Ariya Hidayat.
726
727         Roll back r53889 again, because roll out didn't solve flakeyness on the Windows Test bots
728         https://bugs.webkit.org/show_bug.cgi?id=34399
729
730         * DumpRenderTree/win/EventSender.cpp:
731         (buildModifierFlags):
732         (mouseDownCallback):
733         (mouseUpCallback):
734         (keyDownCallback):
735
736 2010-02-03  Eric Seidel  <eric@webkit.org>
737
738         No review, just fixing copyrights.
739
740         Concerns were expressed about "The Chromium Authors" being
741         a valid legal entity for copyright assignment in the WebKit repository,
742         so this change removes all "The Chromium Authors".
743
744         I looked at the svn logs in src.chromium.org and failed to find any
745         non-google contributions to these files, so they are all now
746         marked as copyright "Google Inc" as all Google contributers assign
747         copyright to "Google Inc" as part of their employment agreement.
748
749         * Scripts/rebaseline-chromium-webkit-tests:
750         * Scripts/run-chromium-webkit-tests:
751         * Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py:
752         * Scripts/webkitpy/layout_tests/layout_package/http_server.py:
753         * Scripts/webkitpy/layout_tests/layout_package/http_server_base.py:
754         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
755         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
756         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
757         * Scripts/webkitpy/layout_tests/layout_package/path_utils.py:
758         * Scripts/webkitpy/layout_tests/layout_package/platform_utils.py:
759         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py:
760         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py:
761         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py:
762         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
763         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
764         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
765         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
766         * Scripts/webkitpy/layout_tests/layout_package/websocket_server.py:
767         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
768         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
769         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
770         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
771         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
772         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
773
774 2010-02-03  Kenneth Rohde Christiansen  <kenneth@webkit.org>
775
776         Reviewed by Ariya Hidayat.
777
778         [Qt] QtLauncher, refactor argument handling in preparation of merge
779         with QGVLauncher
780
781         * QtLauncher/main.cpp:
782         (LauncherApplication::urls):
783         (LauncherApplication::isRobotized):
784         (LauncherApplication::applyDefaultSettings):
785         (LauncherApplication::LauncherApplication):
786         (LauncherApplication::formatKeys):
787         (LauncherApplication::enumToKeys):
788         (fail):
789         (LauncherApplication::handleUserOptions):
790         (main):
791
792 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
793
794         Rubber-stamped by Ariya Hidayat.
795
796         Rolling out r53889, because it might caused flakeyness on the Windows Test bots
797         https://bugs.webkit.org/show_bug.cgi?id=34399
798
799         * DumpRenderTree/win/EventSender.cpp:
800         (mouseDownCallback):
801         (mouseUpCallback):
802         (keyDownCallback):
803
804 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
805
806         Reviewed by Ariya Hidayat.
807
808         [Qt] Fix pixel tests support.
809         https://bugs.webkit.org/show_bug.cgi?id=27813
810
811         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
812         (WebCore::DumpRenderTree::open):
813         (WebCore::DumpRenderTree::processLine):
814          - Hash processing mechanism moved from DumpRenderTree::open to DumpRenderTree::processLine.
815         (WebCore::DumpRenderTree::dump): Fixed and renamed variables.
816
817 2010-02-03  Kevin Watters  <kevinwatters@gmail.com>
818
819         Reviewed by Kevin Ollivier.
820
821         [wx] Enable JIT compilation for wx.
822         
823         https://bugs.webkit.org/show_bug.cgi?id=34536
824
825         * wx/build/settings.py:
826
827 2010-02-02  Kevin Ollivier  <kevino@theolliviers.com>
828
829         [wx] Build fix after introduction of pageNumberForElementById.
830
831         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
832         (LayoutTestController::pageNumberForElementById):
833
834 2010-02-02  Shu Chang  <Chang.Shu@nokia.com>
835
836         Unreviewed.
837
838         Add myself to list of committers.
839
840         * Scripts/webkitpy/committers.py:
841
842 2010-02-02  Chris Jerdonek  <cjerdonek@webkit.org>
843
844         Reviewed by Shinichiro Hamaji.
845
846         Moved filter-related check-webkit-style code into a separate
847         filter module.
848
849         https://bugs.webkit.org/show_bug.cgi?id=34408
850
851         This is preparatory refactoring for Bug 33684, which will allow
852         file and folder-specific filter rules.
853
854         * Scripts/webkitpy/style/checker.py:
855           - Removed CategoryFilter class (moved to filter.py).
856
857         * Scripts/webkitpy/style/checker_unittest.py:
858           - Removed CategoryFilter unit tests (moved to filter_unittest.py).
859
860         * Scripts/webkitpy/style/filter.py: Added.
861           - Added CategoryFilter class (moved from checker.py).
862
863         * Scripts/webkitpy/style/filter_unittest.py: Added.
864           - Added CategoryFilter unit tests (moved from checker_unittest.py).
865
866         * Scripts/webkitpy/style/unittests.py:
867           - Added reference to filter_unittest.py.
868
869 2010-02-01  Chris Jerdonek  <cjerdonek@webkit.org>
870
871         Reviewed by Shinichiro Hamaji.
872
873         Addressed FIXME in check-webkit-style so that the carriage-return
874         check will work for patches.
875
876         https://bugs.webkit.org/show_bug.cgi?id=34260
877
878         Also added support for limiting the number of errors reported
879         per category, per file.
880
881         * Scripts/webkitpy/style/checker.py:
882           - Added new "whitespace/carriage_return" category from common.py.
883           - Added MAX_REPORTS_PER_CATEGORY dictionary.
884           - Added max_reports_per_category attribute to ProcessorOptions class.
885           - Refactored StyleChecker._process_file().
886
887         * Scripts/webkitpy/style/checker_unittest.py:
888           - Updated ProcessorOptionsTest tests.
889           - Added test to check MAX_REPORTS_PER_CATEGORY.
890
891         * Scripts/webkitpy/style/error_handlers.py:
892           - Added support for suppressing the display of errors after
893             reaching a per-category maximum (from max_reports_per_category).
894
895         * Scripts/webkitpy/style/error_handlers_unittest.py:
896           - Added test for suppressing error display.
897
898         * Scripts/webkitpy/style/processors/common.py: Added.
899           - Moved carriage-return check to new file.
900
901         * Scripts/webkitpy/style/processors/common_unittest.py: Added.
902           - Added unit tests for carriage-return check.
903
904         * Scripts/webkitpy/style/unittests.py:
905           - Added reference to common_unittest.py.
906
907 2010-02-01  Shinichiro Hamaji  <hamaji@chromium.org>
908
909         Reviewed by Eric Seidel.
910
911         Provide a way to get page number with layoutTestController
912         https://bugs.webkit.org/show_bug.cgi?id=33840
913
914         * DumpRenderTree/LayoutTestController.cpp:
915         (pageNumberForElementByIdCallback):
916         (LayoutTestController::staticFunctions):
917         * DumpRenderTree/LayoutTestController.h:
918         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
919         (LayoutTestController::pageNumberForElementById):
920         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
921         (LayoutTestController::pageNumberForElementById):
922         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
923         (LayoutTestController::pageNumberForElementById):
924
925 2010-02-01  Shinichiro Hamaji  <hamaji@chromium.org>
926
927         Unreviewed fix for an invalid function call.
928
929         check-webkit-style: Remove filename parameter from all functions where no longer used
930         https://bugs.webkit.org/show_bug.cgi?id=34249
931
932         * Scripts/webkitpy/style/checker.py:
933
934 2010-02-01  Diego Gonzalez  <diego.gonzalez@openbossa.org>
935
936         Reviewed by Kenneth Rohde Christiansen.
937
938         [Qt] DRT Provide global flag ability
939         https://bugs.webkit.org/show_bug.cgi?id=34418
940
941         Add the globalFlag property to the Qt LayoutTestController to allow
942         cross-domain indications.
943
944         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
945         (LayoutTestController::reset):
946         * DumpRenderTree/qt/LayoutTestControllerQt.h:
947         (LayoutTestController::globalFlag):
948         (LayoutTestController::setGlobalFlag):
949
950 2010-02-01  Brady Eidson  <beidson@apple.com>
951
952         Reviewed by Adele Peterson.
953
954         Crash in Safari opening new tabs to "same page"
955         <rdar://problem/7593857> and https://bugs.webkit.org/show_bug.cgi?id=34444
956
957         Add a mode (Mac-only for now) that exercises the WebView SPI _loadBackForwardListFromOtherView:
958
959         * DumpRenderTree/LayoutTestController.cpp:
960         (LayoutTestController::LayoutTestController):
961         (setNewWindowsCopyBackForwardListCallback):
962         (LayoutTestController::staticFunctions):
963
964         * DumpRenderTree/LayoutTestController.h:
965         (LayoutTestController::newWindowsCopyBackForwardList):
966         (LayoutTestController::setNewWindowsCopyBackForwardList):
967
968         * DumpRenderTree/mac/UIDelegate.mm:
969         (-[UIDelegate webView:createWebViewWithRequest:]):
970
971 2010-02-01  Carol Szabo  <carol.szabo@nokia.com>
972
973         Unreviewed.
974
975         Add myself to list of committers.
976
977         * Scripts/webkitpy/committers.py:
978
979 2010-02-01  Nate Chapin  <japhet@chromium.org>
980
981         Rubber-stamped by David Levin.
982
983         Add myself to reviewer list.
984
985         * Scripts/webkitpy/committers.py:
986
987 2010-01-31  Chris Jerdonek  <cjerdonek@webkit.org>
988
989         Reviewed by Shinichiro Hamaji.
990
991         Moved style error handler code to their own classes, and
992         related refactoring. Increased unit test code coverage of
993         style error handling.
994
995         https://bugs.webkit.org/show_bug.cgi?id=34379
996
997         * Scripts/check-webkit-style:
998           - Minor change: added error_count variable.
999
1000         * Scripts/webkitpy/style/checker.py:
1001           - Renamed ProcessorOptions.should_report_error() to is_reportable().
1002           - In the StyleChecker class--
1003             - Removed _default_style_error_handler().
1004             - Added _increment_error_count().
1005             - Refactored to use DefaultStyleErrorHandler and
1006               PatchStyleErrorHandler constructors.
1007
1008         * Scripts/webkitpy/style/checker_unittest.py:
1009           - In the StyleStyleCheckerTest class--
1010             - Removed write_sample_error().
1011             - Removed test_default_style_error_handler().
1012
1013         * Scripts/webkitpy/style/error_handlers.py: Added.
1014           - Added DefaultStyleErrorHandler class.
1015           - Added PatchStyleErrorHandler class.
1016
1017         * Scripts/webkitpy/style/error_handlers_unittest.py: Added.
1018           - Added unit tests for DefaultStyleErrorHandler and
1019             PatchStyleErrorHandler.
1020
1021         * Scripts/webkitpy/style/unittests.py:
1022           - Added error_handlers unit tests.
1023
1024 2010-01-29  Mark Rowe  <mrowe@apple.com>
1025
1026         Rubber-stamped by Stephanie Lewis.
1027
1028         Fix run-leaks with newer versions of the leaks tool.
1029
1030         * Scripts/run-leaks:
1031
1032 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
1033
1034         Reviewed by Eric Siedel.
1035
1036         Top-level test drivers for running the Chromium port of run-webkit-tests
1037         and being able to rebaseline test results from the test bots.  The
1038         files in the Scripts directory are simply wrappers around the files
1039         in webkitpy/layout_tests for convenience.
1040  
1041         https://bugs.webkit.org/show_bug.cgi?id=31498
1042
1043         * Scripts/rebaseline-chromium-webkit-tests: Added.
1044         * Scripts/run-chromium-webkit-tests: Added.
1045         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Added.
1046         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py: Added.
1047
1048 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
1049
1050         Reviewed by Eric Siedel.
1051
1052         Add in the second block of python code for the Chromium port
1053         of run-webkit-tests. These files execute different diffs to classify
1054         the various types of failures from a test.
1055
1056         * Scripts/webkitpy/layout_tests/test_types: Added.
1057         * Scripts/webkitpy/layout_tests/test_types/__init__.py: Added.
1058         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Added.
1059         * Scripts/webkitpy/layout_tests/test_types/image_diff.py: Added.
1060         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: Added.
1061         * Scripts/webkitpy/layout_tests/test_types/text_diff.py: Added.
1062
1063 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
1064
1065         Reviewed by Eric Siedel.
1066
1067         Check in the first part of the Chromium Python port of the 
1068         run-webkit-tests test driver. The files under 
1069         layout_tests/layout_layout constitute most of the implementation;
1070         they can be roughly divided into code that parses the 
1071         "test_expectations.txt" file that describes how we expect tests to
1072         pass or fail, platform-specific hooks for the different Chromium 
1073         ports (in platform_utils*), code for parsing the output of the
1074         tests and generating results files and HTML and JSON for the
1075         dashboards, auxiliary scripts for starting and stopping HTTP and
1076         Web Socket servers, and then one of the actual driver files 
1077         (test_shell_thread). Code for actually parsing test output for 
1078         failures and the top-level driver scripts will follow shortly.
1079
1080         https://bugs.webkit.org/show_bug.cgi?id=31498
1081
1082         * Scripts/webkitpy/layout_tests: Added.
1083         * Scripts/webkitpy/layout_tests/layout_package: Added.
1084         * Scripts/webkitpy/layout_tests/layout_package/__init__.py: Added.
1085         * Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py: Added.
1086         * Scripts/webkitpy/layout_tests/layout_package/http_server.py: Added.
1087         * Scripts/webkitpy/layout_tests/layout_package/http_server_base.py: Added.
1088         * Scripts/webkitpy/layout_tests/layout_package/httpd2.pem: Added.
1089           - scripts to start and stop apache. Note that the apache file
1090             generates a conf file dynamically, and we should switch to 
1091             using the same static conf file that the regular run-webkit-tests
1092             uses, and we can also use the same httpd2.pem file.
1093
1094         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: Added.
1095         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: Added.
1096           - scripts to generate the JSON layout test dashboard and the
1097             flakiness dashboard
1098         * Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf: Added.
1099           - default configuration for LigHTTPd (used on Windows)
1100         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py: Added.
1101           - utility class that implements progress bars on the console to
1102             be displayed while the tests are running
1103         * Scripts/webkitpy/layout_tests/layout_package/path_utils.py: Added.
1104           - various routines for manipulating paths and URIs
1105         * Scripts/webkitpy/layout_tests/layout_package/platform_utils.py: Added.
1106         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py: Added.
1107         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py: Added.
1108         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py: Added.
1109           - platform-specific aspects of the drivers (binary names, paths,
1110             process control, etc.)
1111         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Added.
1112           - code for parsing the 'test_expectations.txt' file to determine
1113             which tests are expected to fail (and how) on which platforms
1114         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: Added.
1115           - code for handling different kinds of failures (generating output
1116             in the results, etc.)
1117         * Scripts/webkitpy/layout_tests/layout_package/test_files.py: Added.
1118           - code to gather the lists of tests
1119         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py: Added.
1120           - code to actually execute tests via TestShell and process
1121             the output
1122         * Scripts/webkitpy/layout_tests/layout_package/websocket_server.py: Added.
1123           - scripts to start and stop the pywebsocket server
1124
1125 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
1126
1127         Reviewed by Eric Seidel.
1128
1129         Check in a copy of the simplejson library; it will be used by
1130         the Chromium port of run-webkit-tests.
1131         
1132         https://bugs.webkit.org/show_bug.cgi?id=31498
1133
1134         * simplejson: Added.
1135         * simplejson/LICENSE.txt: Added.
1136         * simplejson/README.txt: Added.
1137         * simplejson/__init__.py: Added.
1138         * simplejson/_speedups.c: Added.
1139         (ascii_escape_char):
1140         (ascii_escape_unicode):
1141         (ascii_escape_str):
1142         (py_encode_basestring_ascii):
1143         (init_speedups):
1144         * simplejson/decoder.py: Added.
1145         * simplejson/encoder.py: Added.
1146         * simplejson/jsonfilter.py: Added.
1147         * simplejson/scanner.py: Added.
1148
1149 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
1150
1151         No review
1152
1153         Add myself to the committers list
1154
1155         * Scripts/webkitpy/committers.py:
1156
1157 2010-01-29  Jeremy Orlow  <jorlow@chromium.org>
1158
1159         Reviewed by Dimitri Glazkov.
1160
1161         A first step towards the Indexed Database API
1162         https://bugs.webkit.org/show_bug.cgi?id=34342
1163
1164         Add indexed database API.
1165
1166         * Scripts/build-webkit:
1167
1168 2010-01-29  Andras Becsi  <abecsi@webkit.org>
1169
1170         Reviewed by Alexey Proskuryakov.
1171
1172         Correct openHTTPD() to print requests to stdout if run-webkit-httpd is used.
1173         This fixes a regression introduced in r53559.
1174
1175         https://bugs.webkit.org/show_bug.cgi?id=34336
1176
1177         * Scripts/webkitperl/httpd.pm:
1178
1179 2010-01-28  Jon Honeycutt  <jhoneycutt@apple.com>
1180
1181         MSAA: Crash when posting a notification for a detached object
1182
1183         https://bugs.webkit.org/show_bug.cgi?id=34309
1184         <rdar://problem/7409759>
1185
1186         Reviewed by Darin Adler.
1187
1188         * DumpRenderTree/AccessibilityController.h:
1189         Declare new functions. Add new members to store the event hook and the
1190         mapping of accessibility elements to their JS callbacks.
1191
1192         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1193         (AccessibilityController::notificationReceived):
1194         Stubbed.
1195         (AccessibilityController::addNotificationListener):
1196         Stubbed.
1197
1198         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1199         (AccessibilityController::notificationReceived):
1200         Stubbed.
1201         (AccessibilityController::addNotificationListener):
1202         Stubbed.
1203
1204         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1205         (AccessibilityController::AccessibilityController):
1206         Initialize the event hook.
1207         (AccessibilityController::~AccessibilityController):
1208         Remove the event hook. Unprotect all of the JS functions that are stored
1209         in the map.
1210         (logEventProc):
1211         Clean-up a variable.
1212         (stringEvent):
1213         Return a string description of the MSAA event code.
1214         (notificationListenerProc):
1215         Get the accessible object from the event, and query it for IAccessible.
1216         Call the AccessibilityController's notificationReceived().
1217         (comparableObject):
1218         Use QueryService to obtain the IAccessibleComparable for the
1219         IServiceProvider.
1220         (AccessibilityController::notificationReceived):
1221         Iterate the map of objects that have registered for notification
1222         callbacks. Query each for IServiceProvider, then use comparableObject()
1223         to get an IAccessibleComparable. If we find an object matching the
1224         notified object, call its callback, passing the event that was received.
1225         (AccessibilityController::addNotificationListener):
1226         If we have not created the event hook, create it. Protect the JS
1227         callback function object, and add the object and its callback to our
1228         map.
1229
1230         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1231         (AccessibilityUIElement::addNotificationListener):
1232         Call through to the AccessibilityController's addNotificationListener().
1233
1234         * DumpRenderTree/win/DumpRenderTreeWin.h:
1235         Add an extern declaration for the shared FrameLoadDelegate extern, so we
1236         can access it from AccessibilityController.
1237
1238         * DumpRenderTree/win/FrameLoadDelegate.h:
1239         (FrameLoadDelegate::accessibilityController):
1240         Return the AccessibilityController.
1241
1242 2010-01-29  Shinichiro Hamaji  <hamaji@chromium.org>
1243
1244         Reviewed by Darin Adler.
1245
1246         prepare-ChangeLog outputs useless messages for a nonexistent bug ID
1247         https://bugs.webkit.org/show_bug.cgi?id=34313
1248
1249         * Scripts/prepare-ChangeLog:
1250
1251 2010-01-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1252
1253         Rubberstamped by Simon Hausmann.
1254
1255         [Qt] Separate implementation from class definition.
1256
1257         * QtLauncher/main.cpp:
1258         (LauncherWindow::webView):
1259         (LauncherWindow::LauncherWindow):
1260         (LauncherWindow::~LauncherWindow):
1261         (LauncherWindow::keyPressEvent):
1262         (LauncherWindow::grabZoomKeys):
1263         (LauncherWindow::sendTouchEvent):
1264         (LauncherWindow::eventFilter):
1265         (LauncherWindow::loadStarted):
1266         (LauncherWindow::loadFinished):
1267         (LauncherWindow::showLinkHover):
1268         (LauncherWindow::zoomIn):
1269         (LauncherWindow::zoomOut):
1270         (LauncherWindow::resetZoom):
1271         (LauncherWindow::toggleZoomTextOnly):
1272         (LauncherWindow::print):
1273         (LauncherWindow::screenshot):
1274         (LauncherWindow::setEditable):
1275         (LauncherWindow::dumpHtml):
1276         (LauncherWindow::selectElements):
1277         (LauncherWindow::setTouchMocking):
1278         (LauncherWindow::newWindow):
1279         (LauncherWindow::setupUI):
1280
1281 2010-01-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1282
1283         Reviewed by Ariya Hidayat.
1284
1285         [Qt] On Maemo5, a click/touch in the location bar (when unfocused)
1286         should result in all text selected.
1287
1288         * QtLauncher/locationedit.cpp:
1289         (LocationEdit::focusInEvent):
1290         * QtLauncher/locationedit.h:
1291
1292 2010-01-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1293
1294         Reviewed by Ariya Hidayat.
1295
1296         [Qt] Show progress reaching 100% for loads.
1297
1298         * QtLauncher/locationedit.cpp:
1299         (LocationEdit::LocationEdit):
1300         (LocationEdit::setProgress):
1301         (LocationEdit::reset):
1302         (LocationEdit::paintEvent):
1303         * QtLauncher/locationedit.h:
1304
1305 2010-01-29  Andreas Kling  <andreas.kling@nokia.com>
1306
1307         Reviewed by Kenneth Rohde Christiansen.
1308
1309         [Qt] Disable the QtLauncher statusbar on Maemo
1310
1311         https://bugs.webkit.org/show_bug.cgi?id=34330
1312
1313         * QtLauncher/main.cpp:
1314         (LauncherWindow::showLinkHover):
1315         (LauncherWindow::selectElements):
1316
1317 2010-01-29  Andreas Kling  <andreas.kling@nokia.com>
1318
1319         Reviewed by Kenneth Rohde Christiansen.
1320
1321         [Qt] Display page loading progress inside the QtLauncher location bar
1322
1323         https://bugs.webkit.org/show_bug.cgi?id=34210
1324
1325         * QtLauncher/QtLauncher.pro:
1326         * QtLauncher/locationedit.cpp: Added.
1327         (LocationEdit::LocationEdit):
1328         (LocationEdit::setProgress):
1329         (LocationEdit::paintEvent):
1330         * QtLauncher/locationedit.h: Added.
1331         * QtLauncher/mainwindow.cpp:
1332         (MainWindow::buildUI):
1333         * QtLauncher/mainwindow.h:
1334
1335 2010-01-29  Andreas Kling  <andreas.kling@nokia.com>
1336
1337         Reviewed by Kenneth Rohde Christiansen.
1338
1339         [Qt] Add support for Maemo zoom keys in QtLauncher
1340
1341         https://bugs.webkit.org/show_bug.cgi?id=34160
1342
1343         * QtLauncher/main.cpp:
1344         (LauncherWindow::LauncherWindow):
1345         (LauncherWindow::~LauncherWindow):
1346         (LauncherWindow::keyPressEvent):
1347         (LauncherWindow::grabZoomKeys):
1348
1349 2010-01-29  Benjamin Poulain  <benjamin.poulain@nokia.com>
1350
1351         Reviewed by Kenneth Rohde Christiansen.
1352
1353         [Qt] Implement the display() method of the layout test controller
1354         https://bugs.webkit.org/show_bug.cgi?id=34258
1355
1356         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1357         (WebCore::DumpRenderTree::DumpRenderTree):
1358         (WebCore::DumpRenderTree::showPage):
1359         (WebCore::DumpRenderTree::hidePage):
1360         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1361         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1362         (LayoutTestController::reset):
1363         (LayoutTestController::display):
1364         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1365
1366 2010-01-28  Kevin Ollivier  <kevino@theolliviers.com>
1367
1368         [wx] Build fix for MSW, use ThreadingWin.cpp as the Windows pthreads implementation
1369         implements pthread_t in a way that makes it impossible to check its validity,
1370         which is needed by ThreadingPthreads.cpp.
1371
1372         * DumpRenderTree/wscript:
1373         * wx/build/settings.py:
1374
1375 2010-01-28  Andras Becsi  <abecsi@webkit.org>
1376
1377         Adding myself to the committer list. No review needed.
1378
1379         * Scripts/webkitpy/committers.py:
1380
1381 2010-01-28  Hayato Ito  <hayato@chromium.org>
1382
1383         Reviewed by David Levin.
1384
1385         Remove NULL char from input JS file because 'grep' fails if the file contains NULL char.
1386
1387         https://bugs.webkit.org/show_bug.cgi?id=34252
1388
1389         * Scripts/make-script-test-wrappers:
1390
1391 2010-01-28  Kevin Ollivier  <kevino@theolliviers.com>
1392
1393         [wx] Build fix after removal of the zlib image decoder.
1394
1395         * wx/build/settings.py:
1396
1397 2010-01-28  Csaba Osztrogonác  <ossy@webkit.org>
1398
1399         [Qt] Unreviewed, roll out r54000.
1400
1401         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1402         (WebCore::DumpRenderTree::DumpRenderTree):
1403         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1404         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1405         (LayoutTestController::reset):
1406         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1407         (LayoutTestController::display):
1408
1409 2010-01-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
1410
1411         Reviewed by Kenneth Rohde Christiansen.
1412
1413         [Qt] Implement the display() method of the layout test controller
1414         https://bugs.webkit.org/show_bug.cgi?id=34258
1415
1416         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1417         (WebCore::DumpRenderTree::DumpRenderTree):
1418         (WebCore::DumpRenderTree::showPage):
1419         (WebCore::DumpRenderTree::hidePage):
1420         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1421         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1422         (LayoutTestController::reset):
1423         (LayoutTestController::display):
1424         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1425
1426 2010-01-28  Chris Jerdonek  <cjerdonek@webkit.org>
1427
1428         Reviewed by Shinichiro Hamaji.
1429
1430         Eliminated the filename parameter from functions in
1431         check-webkit-style's cpp.py where it is no longer used.
1432
1433         https://bugs.webkit.org/show_bug.cgi?id=34249
1434
1435         * Scripts/webkitpy/style/processors/cpp.py:
1436           - Reduced number of occurrences of "filename" variable from
1437             approximately 200 to 120.
1438
1439         * Scripts/webkitpy/style/processors/cpp_unittest.py:
1440           - Refactored unit tests as necessary to accommodate changes to cpp.py.
1441           - Fixed bug in CppStyleTestBase.perform_include_what_you_use()
1442             where the incorrect file extension was getting passed to
1443             cpp_style.check_language().
1444
1445 2010-01-28  Chris Jerdonek  <cjerdonek@webkit.org>
1446
1447         Reviewed by Shinichiro Hamaji.
1448
1449         In check-webkit-style, eliminated the dependency of
1450         processors/cpp_unittest.py on checker.py.
1451
1452         https://bugs.webkit.org/show_bug.cgi?id=34205
1453
1454         * Scripts/webkitpy/style/checker.py:
1455           - Addressed FIXME by removing STYLE_CATEGORIES data.
1456           - Added style_categories().
1457
1458         * Scripts/webkitpy/style/checker_unittest.py:
1459           - Minor changes.
1460
1461         * Scripts/webkitpy/style/processors/cpp.py:
1462           - Added categories attribute to CppProcessor class (data
1463             was originally checker.STYLE_CATEGORIES).
1464
1465         * Scripts/webkitpy/style/processors/cpp_unittest.py:
1466           - Addressed FIXME by eliminating "import" from checker.py.
1467
1468 2010-01-28  Anton Muhin  <antonm@chromium.org>
1469
1470         Reviewed by Shinichiro Hamaji.
1471
1472         Improve treatment of conditions and rest of the line for if, else, switch and alikes
1473         https://bugs.webkit.org/show_bug.cgi?id=34173
1474
1475         * Scripts/webkitpy/style/cpp_style.py:
1476         * Scripts/webkitpy/style/cpp_style_unittest.py:
1477
1478 2010-01-28  Joe Mason  <jmason@rim.com>
1479
1480         Reviewed by Adam Barth.
1481
1482         Limit login retries to 5
1483         https://bugs.webkit.org/show_bug.cgi?id=34193
1484
1485         * Scripts/webkitpy/bugzilla.py:
1486
1487 2010-01-27  Martin Robinson  <mrobinson@webkit.org>
1488
1489         Adding myself to the committer list. No review necessary.
1490
1491         * Scripts/webkitpy/committers.py:
1492
1493 2010-01-27  George Wright  <gwright@rim.com>
1494
1495         Reviewed by Adam Treat.
1496
1497         https://bugs.webkit.org/show_bug.cgi?id=34216
1498
1499         Add missing include for wtf/Platform.h
1500
1501         * DumpRenderTree/AccessibilityController.h:
1502
1503 2010-01-27  Diego Gonzalez  <diego.gonzalez@openbossa.org>
1504
1505         Reviewed by Kenneth Rohde Christiansen.
1506
1507         [Qt] DRT Provide worker thread ability to track counters
1508         https://bugs.webkit.org/show_bug.cgi?id=34221
1509
1510         Implement workerThreadCount() in LayoutTestController of Qt DRT
1511
1512         Tests:
1513         fast/workers/dedicated-worker-lifecycle.html
1514         fast/workers/shared-worker-frame-lifecycle.html
1515         fast/workers/shared-worker-lifecycle.html
1516         fast/workers/worker-lifecycle.html
1517
1518         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1519         (LayoutTestController::workerThreadCount):
1520         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1521
1522 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1523
1524         Rubberstamped by Simon Hausmann.
1525
1526         [Qt] QtLauncher refactoring:
1527
1528         Make the LauncherWindow depend less on the view, so that more
1529         code can be shared in near future.
1530
1531         * QtLauncher/main.cpp:
1532         (LauncherWindow::sendTouchEvent):
1533         (LauncherWindow::loadFinished):
1534         (LauncherWindow::zoomIn):
1535         (LauncherWindow::zoomOut):
1536         (LauncherWindow::resetZoom):
1537         (LauncherWindow::toggleZoomTextOnly):
1538         (LauncherWindow::dumpHtml):
1539         (LauncherWindow::selectElements):
1540         (LauncherWindow::setupUI):
1541
1542 2010-01-27  Kinuko Yasuda  <kinuko@chromium.org>
1543
1544         Reviewed by Eric Seidel.
1545
1546         Correctly handle the KeyLocation argument that has been introduced
1547         recently to test location-dependent key events in EventSender.keyDown.
1548         http://bugs.webkit.org/show_bug.cgi?id=28247
1549
1550         Test: fast/events/keydown-numpad-keys.html
1551
1552         * DumpRenderTree/gtk/EventSender.cpp:
1553         (keyDownCallback):
1554
1555 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1556
1557         Rubberstamped by Simon Hausmann.
1558
1559         [Qt] QtLauncher refactoring:
1560
1561         Move out code from the MainWindow (renamed to LauncherWindow)
1562         that is not depending on the view, and add it to a new class
1563         called MainWindow.
1564
1565         * QtLauncher/QtLauncher.pro:
1566         * QtLauncher/main.cpp:
1567         (LauncherWindow::LauncherWindow):
1568         (LauncherWindow::eventFilter):
1569         (LauncherWindow::loadStarted):
1570         (LauncherWindow::loadFinished):
1571         (LauncherWindow::newWindow):
1572         (LauncherWindow::setupUI):
1573         (WebPage::createWindow):
1574         (main):
1575         * QtLauncher/mainwindow.cpp: Added.
1576         (MainWindow::MainWindow):
1577         (MainWindow::buildUI):
1578         (MainWindow::page):
1579         (MainWindow::setAddressUrl):
1580         (MainWindow::addCompleterEntry):
1581         (MainWindow::load):
1582         (MainWindow::changeLocation):
1583         (MainWindow::openFile):
1584         * QtLauncher/mainwindow.h: Added.
1585
1586 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1587
1588         Rubberstamped by Simon Hausmann.
1589
1590         [Qt] QtLauncher, coding style fixes.
1591
1592         * QtLauncher/main.cpp:
1593         (MainWindow::MainWindow):
1594         (MainWindow::sendTouchEvent):
1595         (MainWindow::eventFilter):
1596         (MainWindow::loadURL):
1597         (MainWindow::setupUI):
1598         (WebPage::createPlugin):
1599
1600 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1601
1602         Rubberstamped by Simon Hausmann.
1603
1604         [Qt] QtLauncher refactoring, separating the webview and
1605         adding a QGraphicsWebView based version.
1606
1607         * QtLauncher/QtLauncher.pro:
1608         * QtLauncher/main.cpp:
1609         (MainWindow::MainWindow):
1610         * QtLauncher/webpage.h:
1611         * QtLauncher/webview.cpp: Added.
1612         (createContextMenu):
1613         (WebViewGraphicsBased::mousePressEvent):
1614         (WebViewTraditional::mousePressEvent):
1615         (WebViewGraphicsBased::contextMenuEvent):
1616         (WebViewTraditional::contextMenuEvent):
1617         * QtLauncher/webview.h: Added.
1618         (WebViewGraphicsBased::WebViewGraphicsBased):
1619         (WebViewTraditional::WebViewTraditional):
1620
1621 2010-01-27  Alexander Pavlov  <apavlov@chromium.org>
1622
1623         Adding myself as committer. No review necessary.
1624
1625         * Scripts/webkitpy/committers.py:
1626
1627 2010-01-27  Eric Seidel  <eric@webkit.org>
1628
1629         Reviewed by Darin Adler.
1630
1631         webkit-patch needs an open-bugs command
1632         https://bugs.webkit.org/show_bug.cgi?id=30793
1633
1634         * Scripts/test-webkitpy: import OpenBugsTest
1635         * Scripts/webkit-patch: import OpenBugs
1636         * Scripts/webkitpy/commands/download_unittest.py: don't import unittest
1637         * Scripts/webkitpy/commands/early_warning_system_unittest.py: ditto
1638         * Scripts/webkitpy/commands/queries_unittest.py: ditto
1639         * Scripts/webkitpy/commands/queues_unittest.py: ditto
1640         * Scripts/webkitpy/commands/upload_unittest.py: ditto
1641         * Scripts/webkitpy/mock_bugzillatool.py: log when user.open_url is called.
1642
1643 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1644
1645         Rubberstamped by Simon Hausmann
1646
1647         [Qt] QtLauncher refactoring, separating utility methods.
1648
1649         * QtLauncher/QtLauncher.pro:
1650         * QtLauncher/main.cpp:
1651         * QtLauncher/utils.cpp: Added.
1652         (urlFromUserInput):
1653         * QtLauncher/utils.h: Added.
1654
1655 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1656
1657         Rubberstamped by Simon Hausmann
1658
1659         [Qt] Refactor the code in the QtLauncher dealing with HTTP proxy.
1660
1661         * QtLauncher/main.cpp:
1662         (MainWindow::MainWindow):
1663         * QtLauncher/webpage.cpp:
1664         (WebPage::WebPage):
1665         (WebPage::applyProxy):
1666         * QtLauncher/webpage.h:
1667
1668 2010-01-26  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1669
1670         Reviewed by Tor Arne Vestbø.
1671
1672         [Qt] Corrects debug build of DumpRenderTree on Windows.
1673
1674         * DumpRenderTree/qt/DumpRenderTree.pro:
1675
1676 2010-01-26  Daniel Bates  <dbates@webkit.org>
1677
1678         Reviewed by Adam Barth.
1679
1680         https://bugs.webkit.org/show_bug.cgi?id=34070
1681
1682         Moves the try/catch for OSError exceptions in Executive.run_command
1683         to Credentials.read_credentials() so that the unit test
1684         webkitpy.scm_unittest.SCMClassTests.test_error_handlers can
1685         assert that Executive.run_command throws an OSError exception.
1686
1687         * Scripts/webkitpy/credentials.py:
1688         * Scripts/webkitpy/executive.py: Moved try/catch for OSError to
1689         method Credentials.read_credentials().
1690         * Scripts/webkitpy/executive_unittest.py: Removed tests that no longer
1691         apply: test_run_command_with_bad_command_check_return_code and
1692         test_run_command_with_bad_command_check_calls_error_handler. Added new
1693         test to assert that run_command throws OSError exceptions.
1694
1695 2010-01-26  Diego Gonzalez  <diego.gonzalez@openbossa.org>
1696
1697         Reviewed by Kenneth Rohde Christiansen.
1698
1699         [Qt] DRT WebHistory support
1700         https://bugs.webkit.org/show_bug.cgi?id=34167
1701
1702         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1703         (LayoutTestController::reset):
1704         (LayoutTestController::webHistoryItemCount):
1705         (LayoutTestController::keepWebHistory):
1706         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1707
1708 2010-01-26  Kent Tamura  <tkent@chromium.org>
1709
1710         Reviewed by Eric Seidel.
1711
1712         [Win] Add modifiers parameter support to Windows DumpRenderTree
1713         https://bugs.webkit.org/show_bug.cgi?id=34068
1714
1715         Add support for functional name modifiers; "addSelectionKey" and
1716         "rangeSelectionKey", and modifiers parameter to eventSender.mouseDown()
1717         and eventSender.mouseUp().
1718         This change is similar to r53498 for Mac.
1719         
1720         * DumpRenderTree/win/EventSender.cpp:
1721         (buildModifierFlags): New function to set MK_CONTROL or MK_SHIFT to WPARAM.
1722         (mouseDownCallback): Call buidlModifiersFlags().
1723         (mouseUpCallback): ditto.
1724         (keyDownCallback): Add support for "addSelectionkey" and "rangeSelectionKey".
1725
1726 2010-01-26  Chris Jerdonek  <cjerdonek@webkit.org>
1727
1728         Reviewed by Eric Seidel.
1729
1730         The Python autoinstall cache directory now only gets created
1731         in the directory containing autoinstall.py.
1732
1733         https://bugs.webkit.org/show_bug.cgi?id=33365
1734
1735         * Scripts/webkitpy/autoinstall.py:
1736           - Also added a README file to the cache directory saying
1737             where it came from.
1738
1739 2010-01-26  Chris Jerdonek  <cjerdonek@webkit.org>
1740
1741         Reviewed by Eric Seidel.
1742
1743         Moved the check-webkit-style processors into a new
1744         webkitpy/style/processors directory.
1745
1746         https://bugs.webkit.org/show_bug.cgi?id=34060
1747
1748         * Scripts/webkitpy/style/checker.py:
1749         * Scripts/webkitpy/style/checker_unittest.py:
1750         * Scripts/webkitpy/style/cpp_style.py: Removed.
1751         * Scripts/webkitpy/style/cpp_style_unittest.py: Removed.
1752         * Scripts/webkitpy/style/processors: Added.
1753         * Scripts/webkitpy/style/processors/__init__.py: Added.
1754         * Scripts/webkitpy/style/processors/cpp.py: Copied from WebKitTools/Scripts/webkitpy/style/cpp_style.py.
1755         * Scripts/webkitpy/style/processors/cpp_unittest.py: Copied from WebKitTools/Scripts/webkitpy/style/cpp_style_unittest.py.
1756         * Scripts/webkitpy/style/processors/text.py: Copied from WebKitTools/Scripts/webkitpy/style/text_style.py.
1757         * Scripts/webkitpy/style/processors/text_unittest.py: Copied from WebKitTools/Scripts/webkitpy/style/text_style_unittest.py.
1758         * Scripts/webkitpy/style/text_style.py: Removed.
1759         * Scripts/webkitpy/style/text_style_unittest.py: Removed.
1760         * Scripts/webkitpy/style/unittests.py:
1761
1762 2010-01-26  Kevin Ollivier  <kevino@theolliviers.com>
1763
1764         [wx] Build fix, make sure stub function returns a value.
1765
1766         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1767         (LayoutTestController::counterValueForElementById):
1768
1769 2010-01-26  Steve Falkenburg  <sfalken@apple.com>
1770
1771         Reviewed by Oliver Hunt.
1772
1773         Windows build references non-existent include paths
1774         https://bugs.webkit.org/show_bug.cgi?id=34175
1775
1776         * DumpRenderTree/win/DumpRenderTree.vcproj:
1777         * DumpRenderTree/win/ImageDiff.vcproj:
1778         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1779
1780 2010-01-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1781
1782         Reviewed by Ariya Hidayat.
1783
1784         [Qt] Separating out the UrlLoader from the QtLauncher in it's
1785         own implementation and header file.
1786
1787         * QtLauncher/main.cpp:
1788         (main):
1789         * QtLauncher/urlloader.cpp: Added.
1790         (UrlLoader::UrlLoader):
1791         (UrlLoader::loadNext):
1792         (UrlLoader::init):
1793         (UrlLoader::getUrl):
1794         * QtLauncher/urlloader.h: Added.
1795
1796 2010-01-25  Chris Jerdonek  <cjerdonek@webkit.org>
1797
1798         Reviewed by Shinichiro Hamaji.
1799
1800         Refactored check-webkit-style by removing the file path
1801         parameter from the style error handler functions.
1802
1803         https://bugs.webkit.org/show_bug.cgi?id=34031
1804
1805         * Scripts/webkitpy/style/checker.py:
1806           - Added _default_style_error_handler() to StyleChecker class.
1807           - Moved handle_style_error() to inside _default_style_error_handler().
1808
1809         * Scripts/webkitpy/style/checker_unittest.py:
1810           - Removed file path from calls to error handler.
1811
1812         * Scripts/webkitpy/style/cpp_style.py:
1813           - Removed file path from calls to error handler.
1814
1815         * Scripts/webkitpy/style/cpp_style_unittest.py:
1816           - Removed file path from calls to error handler.
1817
1818         * Scripts/webkitpy/style/text_style.py:
1819           - Removed file path from calls to error handler.
1820
1821         * Scripts/webkitpy/style/text_style_unittest.py:
1822           - Removed file path from calls to error handler.
1823
1824 2010-01-25  Jeremy Orlow  <jorlow@chromium.org>
1825
1826         Adding myself as reviewer.  No review necessary.
1827
1828         * Scripts/webkitpy/committers.py:
1829
1830 2010-01-25  Chris Jerdonek  <cjerdonek@webkit.org>
1831
1832         Reviewed by Adam Barth.
1833
1834         Improved prepare-ChangeLog so that it preserves the relative
1835         indentation of a git commit message.
1836
1837         https://bugs.webkit.org/show_bug.cgi?id=34058
1838
1839         * Scripts/prepare-ChangeLog:
1840           - Also adjusted the script so that it does not add white
1841             space characters to empty lines.
1842
1843 2010-01-24  Eric Seidel  <eric@webkit.org>
1844
1845         No review, rolling out r53763.
1846         http://trac.webkit.org/changeset/53763
1847         https://bugs.webkit.org/show_bug.cgi?id=33895
1848
1849         Broke 20+ tests on Windows.
1850
1851         * Scripts/run-webkit-tests:
1852         * Scripts/webkitdirs.pm:
1853
1854 2010-01-24  Adam Barth  <abarth@webkit.org>
1855
1856         Rubber stamped by Eric Seidel.
1857
1858         More pep8 compliance.
1859
1860         * Scripts/webkitpy/mock_bugzillatool.py:
1861
1862 2010-01-24  Adam Barth  <abarth@webkit.org>
1863
1864         Rubber stamped by Eric Seidel.
1865
1866         More pep8 compliance.
1867
1868         * Scripts/webkitpy/executive.py:
1869         * Scripts/webkitpy/grammar.py:
1870
1871 2010-01-24  Adam Barth  <abarth@webkit.org>
1872
1873         Rubber stamped by Eric Seidel.
1874
1875         More pep8 compliance.
1876
1877         * Scripts/webkitpy/comments.py:
1878         * Scripts/webkitpy/committers.py:
1879         * Scripts/webkitpy/credentials.py:
1880
1881 2010-01-24  Adam Barth  <abarth@webkit.org>
1882
1883         Rubber stamped by Eric Seidel.
1884
1885         Make changelogs.py pass pep8.
1886
1887         * Scripts/webkitpy/changelogs.py:
1888
1889 2010-01-23  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1890
1891         [Qt] Unreviewed build fix
1892
1893         * QtLauncher/QtLauncher.pro:
1894         * QtLauncher/webinspector.h:
1895
1896 2010-01-23  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1897
1898         Rubberstamped by Simon Hausmann.
1899
1900         [Qt] Move the WebInspector class to it's own header file.
1901
1902         * QtLauncher/main.cpp:
1903         * QtLauncher/webinspector.h: Added.
1904         (WebInspector::WebInspector):
1905         (WebInspector::showEvent):
1906         (WebInspector::hideEvent):
1907
1908 2010-01-23  Robert Hogan  <robert@roberthogan.net>
1909
1910         Reviewed by Kenneth Rohde Christiansen.
1911
1912         Qt DRT: respect window.close() and window.closed()
1913         
1914         Qt DRT needs to maintain a correct count of open windows
1915         for windowCount(). It also needs to delete windows that
1916         have been closed by window.close().
1917         
1918         This fixes the following tests:
1919         
1920         plugins/destroy-during-npp-new.html
1921         fast/dom/Document/early-document-access.html
1922         fast/dom/Window/window-early-properties.html
1923         fast/events/open-window-from-another-frame.html
1924         fast/events/popup-blocking-click-in-iframe.html
1925         
1926         https://bugs.webkit.org/show_bug.cgi?id=32953
1927
1928         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1929         (WebCore::DumpRenderTree::DumpRenderTree):
1930         (WebCore::DumpRenderTree::createWindow):
1931         (WebCore::DumpRenderTree::windowCloseRequested):
1932         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1933         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1934         (LayoutTestController::maybeDump):
1935
1936 2010-01-23  Dan Bernstein  <mitz@apple.com>
1937
1938         Reviewed by Mark Rowe.
1939
1940         Added a user default for specifying a fallback frameworks path in case
1941         the bundle does not contain frameworks for the current Mac OS X version.
1942
1943         * WebKitLauncher/main.m:
1944         (fallbackMacOSXVersion): Added. Looks up the fallback version in a dictionary
1945         keyed by the FallbackSystemVersions user default and returns it.
1946         (main): If a frameworks directory for the current system version is not found,
1947         try the fallback.
1948
1949 2010-01-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1950
1951         Reviewed by Simon Hausmann.
1952
1953         Make run-webkit-tests work under Cygwin for the Qt port
1954
1955         setPathForRunningWebKitApp() is implemented for the Qt port
1956         by using qmake to query for the location of the Qt libraries.
1957
1958         This requires the original environment (%ENV) to be untouched,
1959         so launchWithCurrentEnv() was refactored to launchWithEnv(),
1960         and the code in openDumpTool() to not use %ENV but a %CLEAN_ENV
1961         instead. This has the added benefit of getting rid of the temp
1962         variables used for storing the current env.
1963
1964         openDumpTool() is also refactored a bit into platform-spesific,
1965         port-spesific, and generic environment variables.
1966
1967         Checks for undef was added a few places to fix Perl concat
1968         warnings when run-webkit-tests is aborted.
1969
1970         https://bugs.webkit.org/show_bug.cgi?id=33895
1971
1972         * Scripts/run-webkit-tests:
1973         * Scripts/webkitdirs.pm:
1974
1975 2010-01-22  Kevin Watters  <kevinwatters@gmail.com>
1976
1977         Reviewed by Kevin Ollivier.
1978
1979         [wx] Remove the Bakefile build system, which is no longer being used.
1980         
1981         https://bugs.webkit.org/show_bug.cgi?id=34022
1982
1983         * DumpRenderTree/wx/DumpRenderTree.bkl: Removed.
1984         * wx/browser/browser.bkl: Removed.
1985         * wx/build-wxwebkit: Removed.
1986
1987 2010-01-22  Gustavo Noronha Silva  <gns@gnome.org>
1988
1989         Reviewed by Simon Fraser.
1990
1991         Reset zoom level to 1.0 when resetting view state. This is causing
1992         many tests to fail after svg/custom/text-zoom.xhtml changes the
1993         zoom level.
1994
1995         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1996         (resetDefaultsToConsistentValues):
1997
1998 2010-01-22  Steve Falkenburg  <sfalken@apple.com>
1999
2000         Reviewed by Darin Adler.
2001
2002         https://bugs.webkit.org/show_bug.cgi?id=34025
2003         Enable client-based Geolocation abstraction for Mac, Windows AppleWebKit targets.
2004
2005         * Scripts/build-webkit:
2006
2007 2010-01-22  Adam Barth  <abarth@webkit.org>
2008
2009         Unreviewed.  Arg.  Someone renamed limit to output_limit on me.
2010
2011         * Scripts/webkitpy/commands/queues.py:
2012
2013 2010-01-22  Adam Barth  <abarth@webkit.org>
2014
2015         Rubber stamped by Eric Seidel.
2016
2017         Make __init__.py and buildbot.py pass pep8 style checker.
2018
2019         * Scripts/webkitpy/__init__.py:
2020         * Scripts/webkitpy/buildbot.py:
2021
2022 2010-01-21  Joe Mason  <jmason@rim.com>
2023
2024         Reviewed by Adam Barth.
2025
2026         webkit-patch should retry on invalid password
2027         https://bugs.webkit.org/show_bug.cgi?id=33955
2028
2029         Ask for bugs.webkit.org authentication in a loop.
2030
2031         * Scripts/webkitpy/bugzilla.py:
2032
2033 2010-01-22  Adam Barth  <abarth@webkit.org>
2034
2035         Unreviewed.  Don't call seek on a NoneType.
2036
2037         * Scripts/webkitpy/statusserver.py:
2038
2039 2010-01-22  Petri Latvala  <petri.latvala@nomovok.com>
2040
2041         Reviewed by David Levin.
2042
2043         check-webkit-style breaks on files with unknown types
2044         https://bugs.webkit.org/show_bug.cgi?id=34001
2045
2046         For files with type FileType.NONE, dispatch_processor returns None.
2047
2048         * Scripts/webkitpy/style/checker.py: Don't call process_file with a processor of value None.
2049
2050 2010-01-22  Adam Barth  <abarth@webkit.org>
2051
2052         Reviewed by Eric Seidel.
2053
2054         Make bugzilla.py and webkitport.py conform to pep8
2055         https://bugs.webkit.org/show_bug.cgi?id=34015
2056
2057         This patch makes webkitport.py and bugzilla.py mostly conform to PEP8
2058         style as enforced by pep8.py.  I wasn't able to get rid of all the
2059         errors because I'm not sure how to wrap some lines properly.  Also,
2060         there are a few deprication errors that I couldn't resolve easily.
2061         However, this is a massive improvement in compliance.
2062
2063         * Scripts/webkitpy/bugzilla.py:
2064         * Scripts/webkitpy/webkitport.py:
2065
2066 2010-01-22  Adam Barth  <abarth@webkit.org>
2067
2068         Reviewed by Darin Adler.
2069
2070         Limit length of EWS results to 5MB
2071         https://bugs.webkit.org/show_bug.cgi?id=34016
2072
2073         Hopefully this will fix the bug where the results link doesn't appear.
2074         Our current theory is that the results blob is too big and the server
2075         is rejecting the request with a 500 error.  That causes us to re-try
2076         the post, but when we re-try the StringIO buffer has its seek pointer
2077         at the end.
2078
2079         * Scripts/webkitpy/commands/queues.py:
2080         * Scripts/webkitpy/statusserver.py:
2081
2082 2010-01-22  Chris Jerdonek  <cjerdonek@webkit.org>
2083
2084         Reviewed by Adam Barth.
2085
2086         Made check-webkit-style able to check patches when script not
2087         run from source root. Also consolidated external references
2088         to a single file.
2089
2090         https://bugs.webkit.org/show_bug.cgi?id=33791
2091
2092         * Scripts/check-webkit-style:
2093           - Changed to import style_references.py.
2094
2095         * Scripts/webkitpy/style/__init__.py:
2096           - Removed __path__ hack that allowed searching Scripts/ directory.
2097
2098         * Scripts/webkitpy/style/checker.py:
2099           - Changed to import style_references.py.
2100
2101         * Scripts/webkitpy/style_references.py: Added.
2102
2103 2010-01-22  Dmitry Titov  <dimich@chromium.org>
2104
2105         Reviewed by Maciej Stachowiak.
2106
2107         Fix the leak of ThreadIdentifiers in threadMap across threads.
2108         https://bugs.webkit.org/show_bug.cgi?id=32689
2109
2110         Add a new test to verify the ThreadIdentifiers are not reused across threads.
2111         The test runs in the beginning of DumpRenderTree and spawns 2 non-WTF treads sequentially,
2112         waiting for the previous thread to terminate before starting the next.
2113         The treads use WTF::currentThread() in their thread function. Without a fix, this
2114         causes both threads to have the same ThreadIdentifier which triggers ASSERT in thread function.
2115         It also starts another thread using WTF. Without the fix, this finds pthread handle from previous
2116         threads in the WTF threadMap and asserts in WTF::establishIdentifierForPthreadHandle().
2117         The test practically does not affect the DRT run time because the threads end immediately.
2118
2119         * DumpRenderTree/mac/DumpRenderTree.mm:
2120         (runThread): Test thread function.
2121         (testThreadIdentifierMap):
2122         (dumpRenderTree):
2123
2124 2010-01-22  Kent Tamura  <tkent@chromium.org>
2125
2126         Reviewed by Maciej Stachowiak.
2127
2128         Fix a bug that mouseDown:withModifiers: is never called.
2129         https://bugs.webkit.org/show_bug.cgi?id=33989
2130
2131         * DumpRenderTree/mac/EventSendingController.mm:
2132         (+[EventSendingController isSelectorExcludedFromWebScript:]):
2133         (+[EventSendingController webScriptNameForSelector:]):
2134
2135 2010-01-22  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2136
2137         Rubberstamped by Antti Koivisto.
2138
2139         [Qt] Separate out the WebPage class into it's own
2140         cpp/header files. Also, removed the assumption that
2141         the view is a QWebView, in preparation of a merger
2142         of the two Qt WebKit launchers.
2143
2144         * QtLauncher/QtLauncher.pro:
2145         * QtLauncher/main.cpp:
2146         (WebView::mousePressEvent):
2147         * QtLauncher/webpage.cpp: Added.
2148         (WebPage::supportsExtension):
2149         (WebPage::extension):
2150         (WebPage::acceptNavigationRequest):
2151         (WebPage::openUrlInDefaultBrowser):
2152         * QtLauncher/webpage.h: Added.
2153         (WebPage::WebPage):
2154
2155 2010-01-21  Chris Jerdonek  <cjerdonek@webkit.org>
2156
2157         Reviewed by Shinichiro Hamaji.
2158
2159         Refactored to move file name and file-reading related code
2160         from cpp_style.py and text_style.py to checker.py.
2161
2162         https://bugs.webkit.org/show_bug.cgi?id=33775
2163
2164         * Scripts/check-webkit-style:
2165           - Updates caused by changes to checker.py.
2166
2167         * Scripts/webkitpy/style/checker.py:
2168           - Added SKIPPED_FILES_WITH_WARNING list.
2169           - Added SKIPPED_FILES_WITHOUT_WARNING list.
2170           - Added FileType class.
2171           - Added ProcessorDispatcher class.
2172           - In StyleChecker class:
2173             - Renamed process_patch() to check_patch().
2174             - Renamed process_file() to check_file().
2175             - Added _process_file().
2176             - Related refactoring.
2177             - Addressed check_patch() FIXME to share code with process_file().
2178
2179         * Scripts/webkitpy/style/checker_unittest.py:
2180           - Added ProcessorDispatcherSkipTest class.
2181           - Added ProcessorDispatcherDispatchTest class.
2182           - Added StyleCheckerCheckFileTest class.
2183
2184         * Scripts/webkitpy/style/cpp_style.py:
2185           - Renamed process_file_data() to _process_lines.
2186           - Removed process_file() (moved logic to checker.py).
2187           - Removed can_handle() (moved logic to checker.py).
2188           - Added CppProcessor class.
2189           - Removed is_exempt() (moved logic to checker.py).
2190           - Added process_file_data() back as a wrapper function.
2191
2192         * Scripts/webkitpy/style/cpp_style_unittest.py:
2193           - Removed test_can_handle().
2194           - Removed test_is_exempt().
2195           - Added CppProcessorTest class.
2196
2197         * Scripts/webkitpy/style/text_style.py:
2198           - Added TextProcessor class.
2199           - Removed process_file().
2200           - Removed can_handle().
2201
2202         * Scripts/webkitpy/style/text_style_unittest.py:
2203           - Removed test_can_handle().
2204           - Added TextProcessorTest class.
2205
2206 2010-01-21  Chris Jerdonek  <cjerdonek@webkit.org>
2207
2208         Reviewed by David Kilzer.
2209
2210         Create a unit-tested subroutine to parse patch files created
2211         by svn-create-patch.
2212
2213         https://bugs.webkit.org/show_bug.cgi?id=33475
2214
2215         * Scripts/VCSUtils.pm:
2216           - Added parseDiff().
2217           - Added parsePatch().
2218
2219         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Added.
2220           - Added unit tests for parseDiff().
2221
2222         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
2223           - Total number of tests now computed dynamically.
2224
2225         * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl: Added.
2226           - Added unit tests for parsePatch().
2227
2228 2010-01-21  Kevin Ollivier  <kevino@theolliviers.com>
2229
2230         [wx] Build fix, add new directory to dir list.
2231
2232         * wx/build/settings.py:
2233
2234 2010-01-21  Adam Barth  <abarth@webkit.org>
2235
2236         Reviewed by Eric Seidel.
2237
2238         Make the EWS transactional
2239         https://bugs.webkit.org/show_bug.cgi?id=33978
2240
2241         Now if the EWS gets interrupted in the middle of processing a patch,
2242         the bots will re-process the patch.
2243
2244         * Scripts/test-webkitpy:
2245         * Scripts/webkitpy/commands/queues.py:
2246         * Scripts/webkitpy/commands/queues_unittest.py:
2247         * Scripts/webkitpy/patchcollection.py:
2248         * Scripts/webkitpy/patchcollection_unittest.py: Added.
2249
2250 2010-01-21  Adam Barth  <abarth@webkit.org>
2251
2252         Unreviewed.  Add missing "ago" for style in the status bubble.
2253
2254         * QueueStatusServer/templates/statusbubble.html:
2255
2256 2010-01-21  Adam Barth  <abarth@webkit.org>
2257
2258         Reviewed by David Levin.
2259
2260         [style-queue] should not complain about identifier names with underscores under WebKit/gtk/webkit/
2261         https://bugs.webkit.org/show_bug.cgi?id=33356
2262
2263         White list unix_hacker_style names in WebKit/gtk/webkit because these
2264         are used in the GTK+ API.
2265
2266         * Scripts/webkitpy/style/cpp_style.py:
2267         * Scripts/webkitpy/style/cpp_style_unittest.py:
2268
2269 2010-01-21  Diego Gonzalez  <diego.gonzalez@openbossa.org>
2270
2271         Reviewed by Kenneth Rohde Christiansen.
2272
2273         [Qt] add setDomainRelaxationForbiddenForURLScheme in Qt DRT
2274         https://bugs.webkit.org/show_bug.cgi?id=33945
2275
2276         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2277         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
2278         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2279
2280 2010-01-21  Simon Hausmann  <simon.hausmann@nokia.com>
2281
2282         No review, rolling out 53615 as it causes two
2283         crashes on the bot.
2284
2285         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2286         (WebCore::DumpRenderTree::DumpRenderTree):
2287         (WebCore::DumpRenderTree::createWindow):
2288         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2289         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2290         (LayoutTestController::maybeDump):
2291
2292 2010-01-21  Robert Hogan  <robert@roberthogan.net>
2293
2294         Reviewed by Simon Hausmann.
2295
2296         Qt DRT: respect window.close() and window.closed()
2297
2298         Qt DRT needs to maintain a correct count of open windows
2299         for windowCount(). It also needs to delete windows that
2300         have been closed by window.close().
2301
2302         This fixes the following tests:
2303
2304         plugins/destroy-during-npp-new.html
2305         fast/dom/Document/early-document-access.html
2306         fast/dom/Window/window-early-properties.html
2307         fast/events/open-window-from-another-frame.html
2308         fast/events/popup-blocking-click-in-iframe.html
2309
2310         https://bugs.webkit.org/show_bug.cgi?id=32953
2311
2312         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2313         (WebCore::DumpRenderTree::DumpRenderTree):
2314         (WebCore::DumpRenderTree::createWindow):
2315         (WebCore::DumpRenderTree::windowCloseRequested):
2316         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2317         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2318         (LayoutTestController::maybeDump):
2319
2320 2010-01-20  Eric Seidel  <eric@webkit.org>
2321
2322         No review, rolling out r53593.
2323         http://trac.webkit.org/changeset/53593
2324         https://bugs.webkit.org/show_bug.cgi?id=33496
2325
2326         Re-rollout this patch, the commit-queue should not have landed
2327         it again, but it did due to land-diff and rollout both not
2328         clearing flags.
2329
2330         * Scripts/webkitpy/commands/early_warning_system.py:
2331         * Scripts/webkitpy/commands/queues.py:
2332         * Scripts/webkitpy/queueengine.py:
2333         * Scripts/webkitpy/scm.py:
2334         * Scripts/webkitpy/scm_unittest.py:
2335
2336 2010-01-20  Eric Seidel  <eric@webkit.org>
2337
2338         Reviewed by Adam Barth.
2339
2340         webkit-commit-queue status page is confusing
2341         https://bugs.webkit.org/show_bug.cgi?id=33496
2342
2343         This should improve the status page by removing more Fail messages.
2344         To do this, I re-factored the CommitQueue and the AbstractReviewQueues
2345         to behave more like one another.  This meant moving where the failure reporting was done.
2346         Previously the AbstractReviewQueue always used the parent process to report the error,
2347         while CommitQueue used the subprocess when possible, and the parent only reported errors
2348         that we didn't know how to handle (bugs in the commit-queue itself).
2349         Now the AbstractReviewQueue follow's the commit-queue's model.  This got rid of a try-block
2350         in both implementations and required teaching handle_script_error in each to post Fail messages
2351         to the status server instead of calling exit(1).
2352
2353         This will also make the style-queue share more bug posting logic with other queues:
2354         https://bugs.webkit.org/show_bug.cgi?id=33871
2355
2356         * Scripts/webkitpy/commands/early_warning_system.py:
2357          - Don't exit(1) as that will cause the calling queue to also report Fail to the status server.
2358            Implementors of handle_script_error are expected to update the status server if needed, but only exit if the error could not be handled.
2359            So we instead pass patch_has_failed_this_queue=True to _update_status_for_script_error in the case that this was a real failure.
2360            _update_status_for_script_error knows how to post the Fail message to the status server.
2361          - Teach _update_status_for_script_error how to post Fail messages to the status server.
2362         * Scripts/webkitpy/commands/queues.py:
2363          - Remove the try block from process_work_item since the caller already has one.
2364          - Only CC watchers on failure to cut down on commit-queue generated mail.
2365          - handle_unexpected_error needs to mark _did_fail now that the try block is gone from process_work_item.
2366          - Abstract _format_script_error_output_for_bug to share code between all queues.
2367          - The new _format_script_error_output_for_bug allows the style-queue to share the posting limit with other queues, as well as support linking to the full output.
2368          - Rename _can_build_and_test to _current_checkout_builds_and_passes_tests to better explain what revision it's testing.
2369          - Move logging out of _can_build_and_test and make the logs explain what revision we're testing.
2370          - handle_script_error now posts Fail instead of the try block in process_work_item handling it.
2371         * Scripts/webkitpy/queueengine.py:
2372          - QueueEngine is no longer used just by the commit-queue, update the logging to say "processing" instead of landing.
2373         * Scripts/webkitpy/scm.py:
2374          - Add new checkout_revision function.
2375         * Scripts/webkitpy/scm_unittest.py:
2376          - Test our new checkout_revision function.
2377
2378 2010-01-20  Fumitoshi Ukai  <ukai@chromium.org>
2379
2380         Reviewed by Alexey Proskuryakov.
2381
2382         WebSocket: Missing Request-URI, when no tralling slash in host
2383         https://bugs.webkit.org/show_bug.cgi?id=33689
2384
2385         Update pywebsocket to 0.4.7.1, which supports alias for resource
2386         name, so that we could test for ws://127.0.0.1:8880
2387
2388         * Scripts/run-webkit-tests:
2389         * Scripts/run-webkit-websocketserver:
2390         * pywebsocket/mod_pywebsocket/dispatch.py:
2391         * pywebsocket/mod_pywebsocket/handshake.py:
2392         * pywebsocket/mod_pywebsocket/standalone.py:
2393         * pywebsocket/setup.py:
2394         * pywebsocket/test/test_dispatch.py:
2395         * pywebsocket/test/test_handshake.py:
2396
2397 2010-01-20  Eric Seidel  <eric@webkit.org>
2398
2399         No review, rolling out r53537.
2400         http://trac.webkit.org/changeset/53537
2401         https://bugs.webkit.org/show_bug.cgi?id=33496
2402
2403         Added a failure condition to the commit-queue and looks to
2404         have broken the EWS bots
2405
2406         * Scripts/webkitpy/commands/early_warning_system.py:
2407         * Scripts/webkitpy/commands/queues.py:
2408         * Scripts/webkitpy/queueengine.py:
2409         * Scripts/webkitpy/scm.py:
2410         * Scripts/webkitpy/scm_unittest.py:
2411
2412 2010-01-20  Jon Honeycutt  <jhoneycutt@apple.com>
2413
2414         MSAA: accSelect() is not implemented
2415
2416         https://bugs.webkit.org/show_bug.cgi?id=33918
2417         <rdar://problem/7436861>
2418
2419         Reviewed by Darin Adler.
2420
2421         * DumpRenderTree/AccessibilityUIElement.cpp:
2422         (takeFocusCallback):
2423         Call the object's takeFocus() function.
2424         (takeSelectionCallback):
2425         Call its takeSelection() function.
2426         (addSelectionCallback):
2427         Call its addSelection() function.
2428         (removeSelectionCallback):
2429         Call its removeSelection() function.
2430         (AccessibilityUIElement::getJSClass):
2431         Add new functions to the JS class definition.
2432
2433         * DumpRenderTree/AccessibilityUIElement.h:
2434         Declare new functions.
2435
2436         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2437         (AccessibilityUIElement::takeFocus):
2438         Stubbed.
2439         (AccessibilityUIElement::takeSelection):
2440         Stubbed.
2441         (AccessibilityUIElement::addSelection):
2442         Stubbed.
2443         (AccessibilityUIElement::removeSelection):
2444         Stubbed.
2445
2446         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2447         (AccessibilityUIElement::takeFocus):
2448         Stubbed.
2449         (AccessibilityUIElement::takeSelection):
2450         Stubbed.
2451         (AccessibilityUIElement::addSelection):
2452         Stubbed.
2453         (AccessibilityUIElement::removeSelection):
2454         Stubbed.
2455
2456         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2457         (AccessibilityUIElement::takeFocus):
2458         Call the object's accSelect() function, passing the appropriate flag.
2459         (AccessibilityUIElement::takeSelection):
2460         Ditto.
2461         (AccessibilityUIElement::addSelection):
2462         Ditto.
2463         (AccessibilityUIElement::removeSelection):
2464         Ditto.
2465
2466 2010-01-20  Andras Becsi  <abecsi@inf.u-szeged.hu>
2467
2468         Reviewed by Alexey Proskuryakov.
2469
2470         Extract Apache handling to httpd.pm module and use the provided functionality
2471         in scripts where Apache is needed.
2472         The module httpd.pm stores the PID of Apache in a variable and cleans up
2473         the PID directory after Apache properly shut down. Catching INT and TERM
2474         signals allows the scripts to close Apache and clean up its PID directory
2475         even if the testing was interrupted.
2476
2477         https://bugs.webkit.org/show_bug.cgi?id=33153
2478
2479         * Scripts/webkitperl/httpd.pm: Added.
2480         * Scripts/run-iexploder-tests:
2481         * Scripts/run-webkit-httpd:
2482         * Scripts/run-webkit-tests:
2483
2484 2010-01-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2485
2486         Reviewed by Simon Hausmann.
2487
2488         [Qt] Make DumpRenderTree build on Windows
2489
2490         * DumpRenderTree/qt/DumpRenderTree.pro:
2491         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2492         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2493         * DumpRenderTree/qt/main.cpp:
2494
2495 2010-01-20  Steve Block  <steveblock@google.com>
2496
2497         Reviewed by Eric Seidel.
2498
2499         Fix commit bot to land patches in order of the bug last modification date.
2500         https://bugs.webkit.org/show_bug.cgi?id=33395
2501
2502         * Scripts/webkitpy/bugzilla.py: Modified. Added 'order=Last+Changed' to bugzilla commit queue URL.
2503
2504 2010-01-20  Adam Barth  <abarth@webkit.org>
2505
2506         Reviewed by Eric Seidel.
2507
2508         Teach check-webkit-style about WebKit/gtk/tests
2509         https://bugs.webkit.org/show_bug.cgi?id=33892
2510
2511         Removes false positives found in
2512         https://bugs.webkit.org/show_bug.cgi?id=30883
2513
2514         * Scripts/webkitpy/style/cpp_style.py:
2515         * Scripts/webkitpy/style/cpp_style_unittest.py:
2516
2517 2010-01-20  Adam Barth  <abarth@webkit.org>
2518
2519         Reviewed by Eric Seidel.
2520
2521         Teach check-webkit-style about QGVLauncher
2522         https://bugs.webkit.org/show_bug.cgi?id=33890
2523
2524         Remove false positives found in
2525         https://bugs.webkit.org/show_bug.cgi?id=33708
2526
2527         * Scripts/webkitpy/style/cpp_style.py:
2528         * Scripts/webkitpy/style/cpp_style_unittest.py:
2529
2530 2010-01-20  Eric Seidel  <eric@webkit.org>
2531
2532         Reviewed by Adam Barth.
2533
2534         webkit-commit-queue status page is confusing
2535         https://bugs.webkit.org/show_bug.cgi?id=33496
2536
2537         This should improve the status page by removing more Fail messages.
2538         To do this, I re-factored the CommitQueue and the AbstractReviewQueues
2539         to behave more like one another.  This meant moving where the failure reporting was done.
2540         Previously the AbstractReviewQueue always used the parent process to report the error,
2541         while CommitQueue used the subprocess when possible, and the parent only reported errors
2542         that we didn't know how to handle (bugs in the commit-queue itself).
2543         Now the AbstractReviewQueue follow's the commit-queue's model.  This got rid of a try-block
2544         in both implementations and required teaching handle_script_error in each to post Fail messages
2545         to the status server instead of calling exit(1).
2546
2547         This will also make the style-queue share more bug posting logic with other queues:
2548         https://bugs.webkit.org/show_bug.cgi?id=33871
2549
2550         * Scripts/webkitpy/commands/early_warning_system.py:
2551          - Don't exit(1) as that will cause the calling queue to also report Fail to the status server.
2552            Implementors of handle_script_error are expected to update the status server if needed, but only exit if the error could not be handled.
2553            So we instead pass patch_has_failed_this_queue=True to _update_status_for_script_error in the case that this was a real failure.
2554            _update_status_for_script_error knows how to post the Fail message to the status server.
2555          - Teach _update_status_for_script_error how to post Fail messages to the status server.
2556         * Scripts/webkitpy/commands/queues.py:
2557          - Remove the try block from process_work_item since the caller already has one.
2558          - Only CC watchers on failure to cut down on commit-queue generated mail.
2559          - handle_unexpected_error needs to mark _did_fail now that the try block is gone from process_work_item.
2560          - Abstract _format_script_error_output_for_bug to share code between all queues.
2561          - The new _format_script_error_output_for_bug allows the style-queue to share the posting limit with other queues, as well as support linking to the full output.
2562          - Rename _can_build_and_test to _current_checkout_builds_and_passes_tests to better explain what revision it's testing.
2563          - Move logging out of _can_build_and_test and make the logs explain what revision we're testing.
2564          - handle_script_error now posts Fail instead of the try block in process_work_item handling it.
2565         * Scripts/webkitpy/queueengine.py:
2566          - QueueEngine is no longer used just by the commit-queue, update the logging to say "processing" instead of landing.
2567         * Scripts/webkitpy/scm.py:
2568          - Add new checkout_revision function.
2569         * Scripts/webkitpy/scm_unittest.py:
2570          - Test our new checkout_revision function.
2571
2572 2010-01-20  Adam Barth  <abarth@webkit.org>
2573
2574         Reviewed by Darin Adler.
2575
2576         Exempt JavaScriptCore/qt/api from style checks
2577         https://bugs.webkit.org/show_bug.cgi?id=33879
2578
2579         Apparently there is a JavaScriptCore API for Qt as well as a WebKit
2580         API.
2581
2582         * Scripts/webkitpy/style/cpp_style.py:
2583         * Scripts/webkitpy/style/cpp_style_unittest.py:
2584
2585 2010-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2586
2587         Reviewed by Simon Hausmann.
2588
2589         [Qt] Don't use QSocketNotifier in the DRT for reading stdin
2590
2591         QSocketNotifier is not available on Windows. Instead we read
2592         stdin synchronously after each test using signals and slots.
2593
2594         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2595         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2596         * DumpRenderTree/qt/main.cpp:
2597
2598 2010-01-19  Adam Barth  <abarth@webkit.org>
2599
2600         Rubber stamped by Eric Seidel.
2601
2602         Move chromium-ews back to building release only to make the EWS faster.
2603
2604         * Scripts/webkitpy/commands/early_warning_system.py:
2605
2606 2010-01-17  Jon Honeycutt  <jhoneycutt@apple.com>
2607
2608         MSAA: The child <option> elements of a non-multiple <select> are not
2609         exposed
2610
2611         https://bugs.webkit.org/show_bug.cgi?id=33773
2612         <rdar://problem/7550556>
2613
2614         Reviewed by Alice Liu.
2615
2616         * DumpRenderTree/AccessibilityUIElement.cpp:
2617         (getIsVisibleCallback):
2618         Call the object's isVisible() function.
2619         (getIsOffScreenCallback):
2620         Ditto, for isOffScreen().
2621         (getIsCollapsedCallback):
2622         Ditto, for isCollapsed().
2623         (getHasPopupCallback):
2624         Ditto, for hasPopup().
2625         (AccessibilityUIElement::getJSClass):
2626         Add isVisible and isOffScreen attributes.
2627
2628         * DumpRenderTree/AccessibilityUIElement.h:
2629         Declare new functions.
2630
2631         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2632         (AccessibilityUIElement::isVisible):
2633         Stubbed.
2634         (AccessibilityUIElement::isOffScreen):
2635         Stubbed.
2636         (AccessibilityUIElement::isCollapsed):
2637         Stubbed.
2638         (AccessibilityUIElement::hasPopup):
2639         Stubbed.
2640
2641         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2642         (AccessibilityUIElement::isVisible):
2643         Stubbed.
2644         (AccessibilityUIElement::isOffScreen):
2645         Stubbed.
2646         (AccessibilityUIElement::isCollapsed):
2647         Stubbed.
2648         (AccessibilityUIElement::hasPopup):
2649         Stubbed.
2650
2651         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2652         (AccessibilityUIElement::showMenu):
2653         Call the object's accDoDefaultAction() to show its popup menu.
2654         (AccessibilityUIElement::isEnabled):
2655         Check that the object does not have the "unavailable" state.
2656         (AccessibilityUIElement::isVisible):
2657         Check that the object does not have the "invisible" state.
2658         (AccessibilityUIElement::isOffScreen):
2659         Check whether the object has the "offscreen" state.
2660         (AccessibilityUIElement::isCollapsed):
2661         Check whether the object has the "collapsed" state.
2662         (AccessibilityUIElement::hasPopup):
2663         Check whether the object has the "has popup" state.
2664
2665 2010-01-19  Victor Wang  <victorw@chromium.org>
2666
2667         Reviewed by Eric Seidel.
2668
2669         Correct committer name.
2670         https://bugs.webkit.org/show_bug.cgi?id=33868
2671
2672         * Scripts/webkitpy/committers.py:
2673
2674 2010-01-19  Kent Tamura  <tkent@chromium.org>
2675
2676         Reviewed by Darin Adler.
2677
2678         [DRT][Mac] Add modifiers parameter to eventSender.mouseDown() and eventSender.mouseUp()
2679         https://bugs.webkit.org/show_bug.cgi?id=33783
2680
2681         Some listbox tests check selection behavior by click events with
2682         "meta" or "shift" keys. Behaviors for such modifier keys are
2683         platform-dependent. The new parameter of mouseDown() and mouseUp()
2684         allows to specify not only concrete modifier keys such as
2685         "shiftKey" "metaKey", but also functional names like
2686         "addSelectionKey" "rangeSelectionKey".
2687
2688         * DumpRenderTree/mac/EventSendingController.mm:
2689         (+[EventSendingController isSelectorExcludedFromWebScript:]):
2690         (+[EventSendingController webScriptNameForSelector:]):
2691         (buildModifierFlags):
2692         (-[EventSendingController mouseDown:withModifiers:]):
2693         (-[EventSendingController mouseDown:]):
2694         (-[EventSendingController mouseUp:withModifiers:]):
2695         (-[EventSendingController mouseUp:]):
2696         (-[EventSendingController keyDown:withModifiers:withLocation:]):
2697
2698 2010-01-19  Adam Barth  <abarth@webkit.org>
2699
2700         Reviewed by Eric Seidel.
2701
2702         Unbreak --request-commit
2703         https://bugs.webkit.org/show_bug.cgi?id=33832
2704
2705         * Scripts/webkitpy/bugzilla.py:
2706
2707 2010-01-19  Eric Seidel  <eric@webkit.org>
2708
2709         Reviewed by Adam Barth.
2710
2711         validate-committer-lists throws exception and committers.py needs a refresh
2712         https://bugs.webkit.org/show_bug.cgi?id=33831
2713
2714         * Scripts/validate-committer-lists: use webkit_logging
2715         * Scripts/webkitpy/committers.py: Add recently minted committers.  Fix Simon Hausmanns email address list to include his webkit-committers@lists address.
2716
2717 2010-01-18  Adam Roben  <aroben@apple.com>
2718
2719         Add LayoutTestController support for calling new WebKit SPI to
2720         disallow setting document.domain
2721
2722         DRT part of fixing <http://webkit.org/b/33806>
2723         <rdar://problem/7552837> Would like API to disallow setting of
2724         document.domain for pages with certain URL schemes
2725
2726         Reviewed by Sam Weinig.
2727
2728         * DumpRenderTree/LayoutTestController.cpp:
2729         (setDomainRelaxationForbiddenForURLSchemeCallback): Added. Calls
2730         through to LayoutTestController.
2731         (LayoutTestController::staticFunctions): Added
2732         setDomainRelaxationForbiddenForURLScheme.
2733
2734         * DumpRenderTree/LayoutTestController.h: Added
2735         setDomainRelaxationForbiddenForURLScheme.
2736
2737         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2738         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
2739         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2740         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
2741         Added. Calls through to WebKit.
2742
2743         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2744         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
2745         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2746         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
2747         Stubbed out.
2748
2749 2010-01-18  Adam Barth  <abarth@webkit.org>
2750
2751         Reviewed by Adam Roben.
2752
2753         Rename patches-to-commit to patches-in-commit-queue
2754         https://bugs.webkit.org/show_bug.cgi?id=33789
2755
2756         The command really lists the patches in the commit-queue not all the
2757         patches that are pending-commit (as the FIXME commands).
2758
2759         * Scripts/webkitpy/commands/queries.py:
2760         * Scripts/webkitpy/commands/queries_unittest.py:
2761
2762 2010-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2763
2764         Reviewed by Simon Hausmann.
2765
2766         [Qt] Force qmake to generate a single makefile for DerivedSources.pro
2767
2768         * Scripts/webkitdirs.pm:
2769
2770 2010-01-18  Adam Roben  <aroben@apple.com>
2771
2772         Clean up use of /useenv when invoking Visual C++
2773
2774         This change reverts things to their pre-r49485 state. That revision
2775         (and, subsequently, r49664 and r51788) started passing /useenv to
2776         Visual C++, even in cases where we don't want to do so (such as when
2777         invoking Visual C++ Express), in the name of making the Chromium build
2778         work. Now that Chromium isn't using buildVisualStudioProject or
2779         pdevenv, we can put things back they way they were.
2780
2781         Fixes <http://webkit.org/b/33797> build-webkit fails with VC++ Express
2782         (due to /useenv flag)
2783
2784         Reviewed by Sam Weinig.
2785
2786         * Scripts/pdevenv: Always pass /useenv. Chromium doesn't use this
2787         script anymore.
2788         * Scripts/webkitdirs.pm:
2789         (buildVisualStudioProject): Never pass /useenv anymore. pdevenv takes
2790         care of this itself, and we don't want to pass /useenv when not using
2791         pdevenv (e.g., when using VC++ Express, because that will cause it to
2792         ignore the Platform SDK).
2793
2794 2010-01-18  Adam Barth  <abarth@webkit.org>
2795
2796         Reviewed by Eric Seidel.
2797
2798         webkit-patch land-safely should obsolete old patches
2799         https://bugs.webkit.org/show_bug.cgi?id=33788
2800
2801         When posting a commit-queue+ patch with land-safely, we should
2802         obsolete the old patches on the bug.  They're really confusing
2803         because the main use case is to address reviewer feedback on a
2804         previous patch.
2805
2806         * Scripts/webkitpy/commands/upload.py:
2807         * Scripts/webkitpy/commands/upload_unittest.py:
2808
2809 2010-01-18  Adam Barth  <abarth@webkit.org>
2810
2811         Reviewed by David Levin.
2812
2813         webkit-patch should authenticate more often
2814         https://bugs.webkit.org/show_bug.cgi?id=33701
2815
2816         This makes it easier to work with security patches.
2817
2818         * Scripts/webkitpy/bugzilla.py:
2819
2820 2010-01-18  Adam Barth  <abarth@webkit.org>
2821
2822         Reviewed by Darin Adler.
2823
2824         style checker needs to know about GObject-specific requirements
2825         inside WebCore/bindings/gobject/
2826         https://bugs.webkit.org/show_bug.cgi?id=33606
2827
2828         Add an exception to the underscore rule for certain
2829         GObject-specific names.
2830
2831         * Scripts/webkitpy/style/cpp_style.py:
2832         * Scripts/webkitpy/style/cpp_style_unittest.py:
2833
2834 2010-01-18  Adam Barth  <abarth@webkit.org>
2835
2836         Reviewed by Shinichiro Hamaji.
2837
2838         [check-webkit-style] does understand ResourceHandleWin.h
2839         https://bugs.webkit.org/show_bug.cgi?id=32975
2840
2841         I'm not 100% convinced this fix is correct, but without more examples,
2842         it's hard to generalize.  We can always generalize the fix in the
2843         future.
2844
2845         * Scripts/webkitpy/style/cpp_style.py:
2846         * Scripts/webkitpy/style/cpp_style_unittest.py:
2847
2848 2010-01-18  Adam Barth  <abarth@webkit.org>
2849
2850         Unreviewed "build" fix.
2851
2852         * Scripts/webkitpy/bugzilla.py:
2853
2854 2010-01-18  Adam Barth  <abarth@webkit.org>
2855
2856         Unreviewed.  Actually make land-safely mark commit-queue+ as
2857         discussed with Eric.
2858
2859         * Scripts/webkitpy/bugzilla.py:
2860         * Scripts/webkitpy/steps/postdiffforcommit.py:
2861
2862 2010-01-17  Adam Barth  <abarth@webkit.org>
2863
2864         Reviewed by Darin Adler.
2865
2866         style-queue complains about one-line macros that include multiple statements
2867         https://bugs.webkit.org/show_bug.cgi?id=33173
2868
2869         Add an exception for multiple statements on a line that starts a macro.
2870
2871         * Scripts/webkitpy/style/cpp_style.py:
2872         * Scripts/webkitpy/style/cpp_style_unittest.py:
2873
2874 2010-01-17  Adam Barth  <abarth@webkit.org>
2875
2876         Reviewed by Darin Adler.
2877
2878         [check-webkit-style] qt unit testing false positives
2879         https://bugs.webkit.org/show_bug.cgi?id=32833
2880
2881         Exempt the Qt API and unit tests from the style checker.
2882
2883         * Scripts/webkitpy/style/cpp_style.py:
2884         * Scripts/webkitpy/style/cpp_style_unittest.py:
2885
2886 2010-01-17  Adam Barth  <abarth@webkit.org>
2887
2888         Reviewed by Darin Adler.
2889
2890         style-check script reports loads of errors on gtk2drawing.c
2891         https://bugs.webkit.org/show_bug.cgi?id=33771
2892
2893         Exempt WebCore/platform/gtk/gtk2drawing.c and
2894         WebCore/platform/gtk/gtk2drawing.h from style checks.
2895
2896         * Scripts/webkitpy/style/cpp_style.py:
2897         * Scripts/webkitpy/style/cpp_style_unittest.py:
2898
2899 2010-01-17  Chris Jerdonek  <cjerdonek@webkit.org>
2900
2901         Reviewed by Shinichiro Hamaji.
2902
2903         Finished eliminating _cpp_style_state global state variable from
2904         check-webkit-style code and eliminating _CppStyleState class.
2905
2906         https://bugs.webkit.org/show_bug.cgi?id=33764
2907
2908         * Scripts/webkitpy/style/checker.py:
2909           - Minor updates caused by changes to cpp_style.py.
2910
2911         * Scripts/webkitpy/style/cpp_style.py:
2912           - Removed _CppStyleState class.
2913           - Removed verbose_level functions.
2914           - Added verbosity as a parameter to _FunctionState constructor.
2915           - Added verbosity as a parameter to process_file().
2916           - Added verbosity as a parameter to process_file_data().
2917
2918         * Scripts/webkitpy/style/cpp_style_unittest.py:
2919           - Added helper functions to set verbosity while running tests.
2920
2921 2010-01-17  Adam Barth  <abarth@webkit.org>
2922
2923         Reviewed by Shinichiro Hamaji.
2924
2925         check-webkit-style underscore check should be disabled for Qt methods starting with qt_
2926         https://bugs.webkit.org/show_bug.cgi?id=33663
2927
2928         * Scripts/webkitpy/style/cpp_style.py:
2929         * Scripts/webkitpy/style/cpp_style_unittest.py:
2930
2931 2010-01-17  Adam Barth  <abarth@webkit.org>
2932
2933         Reviewed by Eric Seidel.
2934
2935         style-queue complains about missing #include of config.h for non-WebCore projects
2936         https://bugs.webkit.org/show_bug.cgi?id=33170
2937
2938         WebKitAPITests are consumers of the WebKit API and therefore do not
2939         need to follow the same include discipline as the rest of WebKit.  This
2940         patch exempts them from the include checks.
2941
2942         * Scripts/webkitpy/style/cpp_style.py:
2943         * Scripts/webkitpy/style/cpp_style_unittest.py:
2944
2945 2010-01-17  Adam Barth  <abarth@webkit.org>
2946
2947         Reviewed by Eric Seidel.
2948
2949         EWS (Early Warning Systems) should build both debug and release
2950         https://bugs.webkit.org/show_bug.cgi?id=33681
2951
2952         Build both debug and release for chromium-ews.
2953
2954         * Scripts/webkitpy/commands/early_warning_system.py:
2955
2956 2010-01-17  Adam Barth  <abarth@webkit.org>
2957
2958         Reviewed by Darin Adler.
2959
2960         style-queue should include instructions for how to file bugs against check-webkit-style
2961         https://bugs.webkit.org/show_bug.cgi?id=32345
2962
2963         Added some text to the error message asking folks to file bugs against
2964         false positives.
2965
2966         * Scripts/webkitpy/commands/queues.py:
2967
2968 2010-01-17  Chris Jerdonek  <cjerdonek@webkit.org>
2969
2970         Reviewed by Adam Barth.
2971
2972         Eliminated the error_count global variable and related
2973         check-webkit-style refactoring.
2974
2975         https://bugs.webkit.org/show_bug.cgi?id=33678
2976
2977         * Scripts/check-webkit-style:
2978           - Updated to use webkit_argument_defaults().
2979           - Renamed styleChecker to style_checker.
2980
2981         * Scripts/webkitpy/style/checker.py:
2982           - Prefixed the three default arguments with WEBKIT_DEFAULT.
2983           - Added webkit_argument_defaults().
2984           - Added default filter_rules parameter to CategoryFilter constructor.
2985           - Added __ne__() to CategoryFilter class.
2986           - Added __eq__() and __ne__() to ProcessorOptions class.
2987           - Added error_count and _write_error attributes to StyleChecker class.
2988           - Made StyleChecker._handle_error() increment the error count.
2989
2990         * Scripts/webkitpy/style/checker_unittest.py:
2991           - Improved CategoryFilterTest.test_eq().
2992           - Added CategoryFilterTest.test_ne().
2993           - Added test_eq() and test_ne() to ProcessorOptionsTest class.
2994           - Updated unit tests to use webkit_argument_defaults().
2995           - Added StyleCheckerTest class.
2996
2997         * Scripts/webkitpy/style/cpp_style.py:
2998           - Removed references to global error_count.
2999
3000         * Scripts/webkitpy/style/cpp_style_unittest.py:
3001           - Removed CppStyleStateTest class.
3002
3003 2010-01-15  Jon Honeycutt  <jhoneycutt@apple.com>
3004
3005         get_accParent should try to retrieve parent AccessibilityObject, before
3006         calling upon window
3007
3008         https://bugs.webkit.org/show_bug.cgi?id=22893
3009
3010         Reviewed by Darin Adler.
3011
3012         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3013         (AccessibilityUIElement::parentElement):
3014         Get the object's parent. Query it for IAccessible, and return it.
3015
3016 2010-01-16  Dan Bernstein  <mitz@apple.com>
3017
3018         Reviewed by Mark Rowe.
3019
3020         <rdar://problem/7529519> DumpRenderTree crashes in makeLargeMallocFailSilently()
3021
3022         * DumpRenderTree/mac/CheckedMalloc.cpp:
3023         (makeLargeMallocFailSilently): Temporarily allow writing to the default
3024         malloc zone structure while modifying it.
3025
3026 2010-01-16  David Kilzer  <ddkilzer@apple.com>
3027
3028         Added back removed properties to iExploder input files
3029
3030         While the update-iexploder-cssproperties script works great to
3031         add new properties, it has the side-effect of removing old
3032         properties that once were parsed.
3033
3034         * iExploder/htdocs/cssproperties.in: Added back removed
3035         properties into their own section.
3036         * iExploder/htdocs/htmlattrs.in: Ditto.
3037
3038 2010-01-16  Holger Hans Peter Freyther  <zecke@selfish.org>
3039
3040         Reviewed by David Kilzer.
3041
3042         Update iExploder/htdocs/*.in by running update-iexploder-cssproperties 
3043         https://bugs.webkit.org/show_bug.cgi?id=33756
3044
3045         * iExploder/htdocs/cssproperties.in: New CSS attributes
3046         * iExploder/htdocs/htmlattrs.in: New HTML attributes
3047         * iExploder/htdocs/htmltags.in: New HTML tags
3048
3049 2010-01-15  Chris Jerdonek  <chris.jerdonek@gmail.com>
3050
3051         Reviewed by David Kilzer.
3052
3053         Altered parseDiffHeader() to skip unrecognized lines and
3054         other minor clean-ups.
3055
3056         https://bugs.webkit.org/show_bug.cgi?id=33476
3057
3058         * Scripts/VCSUtils.pm:
3059           - Changed parseDiffHeader() as follows:
3060             - Skips over unrecognized lines.
3061             - Addressed FIXME to remove substitution for "diff" line.
3062             - Renamed "version" header hash key to "sourceRevision".
3063             - Eliminated "copiedFromVersion" header hash key.
3064             - Included "sourceRevision" also for copied files.
3065             - Checks that copy revision number matches "sourceRevision".
3066             - No longer returns $foundHeaderEnding.
3067             - Dies if header ending not found.
3068             - Diff header dividing line now always added.
3069
3070         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
3071           - Made necessary changes in parseDiffHeader() unit tests.
3072           - Shortened the file paths in some test cases.
3073
3074 2010-01-14  Yuzo Fujishima  <yuzo@google.com>
3075
3076         Reviewed by Alexey Proskuryakov.
3077
3078         Update pywebsocket to 0.4.6
3079         https://bugs.webkit.org/show_bug.cgi?id=32299
3080         The newer pywebsocket can handle more simultaneous connections.
3081
3082         * pywebsocket/mod_pywebsocket/handshake.py:
3083         * pywebsocket/mod_pywebsocket/standalone.py:
3084         * pywebsocket/setup.py:
3085         * pywebsocket/test/test_handshake.py:
3086
3087 2010-01-14  Eric Seidel  <eric@webkit.org>
3088
3089         Reviewed by Adam Barth.
3090
3091         REGRESSION(53133): commit-queue no longer rejects patches with invalid committers, instead it hangs
3092         https://bugs.webkit.org/show_bug.cgi?id=33638
3093
3094         * Scripts/webkitpy/bugzilla.py:
3095          - Add Bug.id() to match Attachment.id()
3096          - Give Bug.reviewed_patches and commit_queued_patches the option to return patches with invalid committers/reviewers.
3097          - Add back a missing variable to _validate_setter_email found by the new unit tests!
3098         * Scripts/webkitpy/commands/queries.py:
3099          - Add FIXMEs about the commands being confusingly named.
3100         * Scripts/webkitpy/commands/queries_unittest.py:
3101          - Update results to reflect the newly restructured mock bug cache.
3102         * Scripts/webkitpy/commands/queues.py:
3103          - Add a new _validate_patches_in_commit_queue method (this is what fixes the regression).
3104          - Add a FIXME about eventually sorting the patches into some order.
3105         * Scripts/webkitpy/commands/queues_unittest.py:
3106          - Update results now that with the newly restructure mock bug cache we're testing cq+'d patches with an invalid committer.
3107         * Scripts/webkitpy/commands/upload_unittest.py:
3108          - Update results to match the newly restructured mock bug cache.
3109         * Scripts/webkitpy/mock_bugzillatool.py:
3110          - Restructure fetch_ methods to not use a manual list of ids, but rather use Bug and Attachment classes to make real queries from all of the Bugs.
3111          - Add a few more attachments and bug dictionaries for use by the tests.
3112
3113 2010-01-13  Diego Gonzalez  <diego.gonzalez@openbossa.org>
3114
3115         Reviewed by Kenneth Christiansen.
3116
3117         [Qt] DRT missing setUserStyleSheetLocation and setUserStyleSheetEnabled in LayoutTestController
3118         https://bugs.webkit.org/show_bug.cgi?id=33617
3119
3120         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3121         (WebCore::WebPage::resetSettings):
3122         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3123         (LayoutTestController::setUserStyleSheetLocation):
3124         (LayoutTestController::setUserStyleSheetEnabled):
3125         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3126
3127 2010-01-14  Adam Roben  <aroben@apple.com>
3128
3129         Add LayoutTestController API to force
3130         -webView:resource:willSendRequest:: to return null
3131
3132         Enables tests for <rdar://problem/7533333> <http://webkit.org/b/33533>
3133         window.onload never fires if page contains an <iframe> with a bad
3134         scheme or whose load is cancelled by returning null from resource load
3135         delegate's willSendRequest
3136
3137         Reviewed by Brady Eidson.
3138
3139         * DumpRenderTree/LayoutTestController.cpp:
3140         (LayoutTestController::LayoutTestController): Initialize new member.
3141         (setWillSendRequestReturnsNullCallback): Call through to
3142         LayoutTestController.
3143         (LayoutTestController::staticFunctions): Added new function.
3144
3145         * DumpRenderTree/LayoutTestController.h: Added
3146         m_willSendRequestReturnsNull.
3147         (LayoutTestController::willSendRequestReturnsNull):
3148         (LayoutTestController::setWillSendRequestReturnsNull):
3149         Added standard accessors.
3150
3151         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3152         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3153         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3154         (ResourceLoadDelegate::willSendRequest):
3155         Return null if LayoutTestController says to.
3156
3157 2010-01-14  Kevin Ollivier  <kevino@theolliviers.com>
3158
3159         [wx] Build fix after removal of XBM support.
3160
3161         * wx/build/settings.py:
3162
3163 2010-01-14  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3164
3165         Reviewed by Simon Hausmann.
3166
3167         Add support for partial building on Symbian.
3168
3169         The build happens in the source directory as out of source builds are
3170         not supported by qmake for Symbian.
3171
3172         Also the actual build isn't started but it is left to the developer
3173         to choose the architecture/configuration.
3174
3175         * Scripts/webkitdirs.pm:
3176
3177 2010-01-14  Simon Hausmann  <simon.hausmann@nokia.com>
3178
3179         Reviewed by Kenneth Rohde Christiansen.
3180
3181         Add support for "detecting" Symbian environments by either
3182         looking for the EPOCROOT environment variable or via --symbian
3183         being passed on the commandline.
3184
3185         * Scripts/webkitdirs.pm:
3186
3187 2010-01-14  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3188
3189         Unreviewed.
3190
3191         [Qt] Use a different Makefile names for sources generation and compilation.
3192         This prevents Makefile overwriting when running build-webkit twice.
3193
3194         * Scripts/webkitdirs.pm:
3195
3196 2010-01-14  Andreas Kling  <andreas.kling@nokia.com>
3197
3198         Reviewed by Kenneth Rohde Christiansen.
3199
3200         [Qt] Add an "alien_QLabel" classId for manual testing of alien widgets.
3201
3202         https://bugs.webkit.org/show_bug.cgi?id=33373
3203
3204         * QtLauncher/main.cpp:
3205         (WebPage::createPlugin):
3206
3207 2010-01-14  Eric Seidel  <eric@webkit.org>
3208
3209         No review, rolling out r53249.
3210         http://trac.webkit.org/changeset/53249
3211         https://bugs.webkit.org/show_bug.cgi?id=33617
3212
3213         This caused http/tests/security/local-user-CSS-from-
3214         remote.html to fail on the Qt Release Build Bot.
3215
3216         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3217         (WebCore::WebPage::resetSettings):
3218         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3219         (LayoutTestController::overridePreference):
3220         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3221
3222 2010-01-14  Chris Jerdonek  <chris.jerdonek@gmail.com>
3223
3224         Reviewed by Shinichiro Hamaji.
3225
3226         Moved error() from cpp_style.py to checker.py.
3227
3228         https://bugs.webkit.org/show_bug.cgi?id=33620
3229
3230         * Scripts/check-webkit-style:
3231           - Addressed FIXME to not set global state.
3232
3233         * Scripts/webkitpy/style/checker.py:
3234           - Added argument validation to ProcessorOptions constructor.
3235           - Added should_report_error() to ProcessorOptions class.
3236           - Removed set_options().
3237           - Added StyleChecker class.
3238
3239         * Scripts/webkitpy/style/checker_unittest.py:
3240           - Added unit test class for ProcessorOptions class.
3241           - Added unit test to check that parse() strips white space.
3242
3243         * Scripts/webkitpy/style/cpp_style.py:
3244           - Removed "filter" and "output_format" methods.
3245           - Removed should_print_error() and error() functions.
3246           - Removed default parameter value from process_file().
3247
3248         * Scripts/webkitpy/style/cpp_style_unittest.py:
3249           - Removed call to cpp_style._should_print_error().
3250           - Removed test_filter() and test_filter_appending().
3251
3252         * Scripts/webkitpy/style/text_style.py:
3253           - Removed default parameter value from process_file().
3254
3255 2010-01-14  Diego Gonzalez  <diego.gonzalez@openbossa.org>
3256
3257         Reviewed by Kenneth Rohde Christiansen.
3258
3259         [Qt] DRT missing setUserStyleSheetLocation and setUserStyleSheetEnabled in LayoutTestController
3260         https://bugs.webkit.org/show_bug.cgi?id=33617
3261
3262         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3263         (WebCore::WebPage::resetSettings):
3264         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3265         (LayoutTestController::setUserStyleSheetLocation):
3266         (LayoutTestController::setUserStyleSheetEnabled):
3267         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3268
3269 2010-01-13  Adam Barth  <abarth@webkit.org>
3270
3271         Reviewed by Eric Seidel.
3272
3273         Fix CloseBugForLandDiff unittest to actually run
3274         https://bugs.webkit.org/show_bug.cgi?id=33640
3275
3276         * Scripts/webkitpy/mock_bugzillatool.py:
3277         * Scripts/webkitpy/steps/closebugforlanddiff_unittest.py:
3278
3279 2010-01-12  Jon Honeycutt  <jhoneycutt@apple.com>
3280
3281         MSAA: selected, selectable, extended selectable, and multiple
3282         selectable states are not reported
3283
3284         https://bugs.webkit.org/show_bug.cgi?id=33574
3285         <rdar://problem/7536826>
3286
3287         Reviewed by Darin Adler.
3288
3289         * DumpRenderTree/AccessibilityUIElement.cpp:
3290         (getIsSelectableCallback):
3291         Return the result of calling isSelectable().
3292         (getIsMultiSelectableCallback):
3293         Return the result of calling isMultiSelectable().
3294         (AccessibilityUIElement::getJSClass):
3295         Add isSelected and isMultiSelectable properties to the JSClass
3296         definition.
3297
3298         * DumpRenderTree/AccessibilityUIElement.h:
3299         Declare isSelectable() and isMultiSelectable().
3300
3301         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3302         (AccessibilityUIElement::isSelectable):
3303         Stubbed.
3304         (AccessibilityUIElement::isMultiSelectable):
3305         Stubbed.
3306
3307         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3308         (AccessibilityUIElement::isSelectable):
3309         Stubbed.
3310         (AccessibilityUIElement::isMultiSelectable):
3311         Stubbed.
3312
3313         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3314         (accessibilityState):
3315         Get the object's state, and return it.
3316         (AccessibilityUIElement::isSelected):
3317         Check the object's selected state.
3318         (AccessibilityUIElement::isSelectable):
3319         Check the object's selectable state.
3320         (AccessibilityUIElement::isMultiSelectable):
3321         Check the object's extended/multiple selectable state.
3322
3323 2010-01-13  Adam Barth  <abarth@webkit.org>
3324
3325         Unreviewed.  Repeat the below for CloseBugForLandDiff.
3326
3327         * Scripts/test-webkitpy:
3328         * Scripts/webkitpy/steps/closebugforlanddiff.py:
3329         * Scripts/webkitpy/steps/closebugforlanddiff_unittest.py: Added.
3330
3331 2010-01-13  Adam Barth  <abarth@webkit.org>
3332
3333         Unreviewed.  Turn the mac-ews status bubbles back on now that this bot
3334         is running again.
3335
3336         * QueueStatusServer/templates/statusbubble.html:
3337
3338 2010-01-13  Adam Barth  <abarth@webkit.org>
3339
3340         Reviewed by Darin Adler.
3341
3342         REGRESSION(53133): webkit-patch land dies if it can't find a bug id.
3343         https://bugs.webkit.org/show_bug.cgi?id=33634
3344
3345         Deal with the case of no bug patch object in the state.
3346
3347         * Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py:
3348         * Scripts/webkitpy/steps/updatechangelogswithreviewer.py:
3349
3350 2010-01-13  Kenneth Russell  <kbr@google.com>
3351
3352         Unreviewed; added myself to the committers list.
3353
3354         * Scripts/webkitpy/committers.py:
3355
3356 2010-01-13  Darin Adler  <darin@apple.com>
3357
3358         Ignore compiled Python in more of webkitpy.
3359
3360         * Scripts/webkitpy/commands: Added property svn:ignore.
3361         * Scripts/webkitpy/steps: Added property svn:ignore.
3362         * Scripts/webkitpy/style: Added property svn:ignore.
3363
3364 2010-01-13  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3365
3366         Reviewed by Simon Hausmann.
3367
3368         [Qt] Fix build problem related to the pushd command
3369
3370         * Scripts/webkitdirs.pm:
3371
3372 2010-01-13  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3373
3374         Reviewed by Simon Hausmann.
3375
3376         [Qt] Split the build process in two different .pro files.
3377         This allows qmake to be run once all source files are available.
3378
3379         * Scripts/webkitdirs.pm: Add calls to make DerivedSources.pro in JSC and WC.
3380
3381 2010-01-13  Shinichiro Hamaji  <hamaji@chromium.org>
3382
3383         Unreviewed tiny typo fix in docstrings.
3384
3385         * Scripts/webkitpy/style/checker_unittest.py:
3386
3387 2010-01-13  Chris Jerdonek  <chris.jerdonek@gmail.com>
3388
3389         Reviewed by Shinichiro Hamaji.
3390
3391         Created a CategoryFilter class to encapsulate the logic of
3392         filter rules.
3393
3394         https://bugs.webkit.org/show_bug.cgi?id=33454
3395
3396         * Scripts/webkitpy/style/checker.py:
3397           - Added CategoryFilter class.
3398
3399         * Scripts/webkitpy/style/checker_unittest.py:
3400           - Added CategoryFilter unit tests.
3401
3402         * Scripts/webkitpy/style/cpp_style.py:
3403           - Updated filter methods to use CategoryFilter.
3404
3405         * Scripts/webkitpy/style/cpp_style_unittest.py:
3406           - Updated references to filters.
3407
3408 2010-01-12  Shinichiro Hamaji  <hamaji@chromium.org>
3409
3410         Unreviewed. Now I can review :)
3411
3412         * Scripts/webkitpy/committers.py:
3413
3414 2010-01-12  Brent Fulgham  <bfulgham@webkit.org>
3415
3416         Reviewed by Darin Adler.
3417
3418         Extend WinLauncher example with better printing features.
3419
3420         * WinLauncher/PrintWebUIDelegate.cpp:
3421         (PrintWebUIDelegate::webViewPrintingMarginRect): Provide slightly
3422          larger margins.
3423         (PrintWebUIDelegate::webViewHeaderHeight): Compute header height based
3424          on text metrics.
3425         (PrintWebUIDelegate::webViewFooterHeight): Compute footer height based
3426          on text metrics.
3427         (PrintWebUIDelegate::drawHeaderInRect): Write useful header, along
3428          with separating line.
3429         (PrintWebUIDelegate::drawFooterInRect):
3430         * WinLauncher/PrintWebUIDelegate.h: Remove stubs.
3431         * WinLauncher/WinLauncher.cpp:
3432         (PrintView): Correct loop used to print individual pages.
3433          Previously it started at 0, which is a wild-card to print all
3434          pages at once.
3435
3436 2010-01-12  Alexey Proskuryakov  <ap@apple.com>
3437
3438         Reviewed by Darin Adler.
3439
3440         https://bugs.webkit.org/show_bug.cgi?id=33540
3441         Make it possible to build in debug mode with assertions disabled
3442
3443         * DumpRenderTree/mac/ObjCController.m: (-[ObjCController accessStoredWebScriptObject]):
3444
3445 2010-01-11  Darin Fisher  <darin@chromium.org>
3446
3447         Reviewed by Dimitri Glazkov.
3448
3449         [Chromium] "build-webkit --chromium" should run "make all" on Linux
3450         https://bugs.webkit.org/show_bug.cgi?id=33500
3451
3452         * Scripts/webkitdirs.pm:
3453
3454 2010-01-12  Eric Seidel  <eric@webkit.org>
3455
3456         Reviewed by Adam Barth.
3457
3458         AssignToCommitter does not need to fetch bugs twice
3459         https://bugs.webkit.org/show_bug.cgi?id=33530
3460
3461         This is a no-brainer patch now that we've added Bug.reviewed_patches
3462
3463         * Scripts/webkitpy/commands/upload.py:
3464
3465 2010-01-12  Eric Seidel  <eric@webkit.org>
3466
3467         Reviewed by Adam Barth.
3468
3469         bugzilla.py should have an Attachment object instead of passing around dictionaries
3470         https://bugs.webkit.org/show_bug.cgi?id=31594
3471
3472         * Scripts/webkitpy/bugzilla.py:
3473          - Add a new Attachment class, with accessor methods for all the necessary properties.
3474          - Update Bug to carry a pointer back to bugzilla (attachments need to access Bugzilla for committer validation and url())
3475          - Move reviewed_patches and commit_queued_patches out of Bugzilla custom methods and onto Bug
3476          - Move committer validation logic into its own class.
3477          - Committer rejection is only used in one place.  Make the new Bug reviewed_patches and commit_queued_patches
3478            handle the common case (of returning "reviewer" or "committer" as None), and let CommitterValidation handle
3479            the case where we want to reject patches in bugzilla.
3480          - Simplify fetch_patches_from_commit_queue now that committer validation is simpler.
3481          - Make all self.bugzilla.fetch_bug access go through BugzillaQueries._fetch_bug.
3482          - Mark set_flag_on_attachment as non-private to denote that CommitterValidation depends on it.
3483          - Move fetch_reviewed_patches_from_bug and fetch_commit_queue_patches_from_bug logic onto the Bug class.
3484         * Scripts/webkitpy/bugzilla_unittest.py:
3485          - Move test_flag_permission_rejection_message into a new CommitterValidationTest class.
3486         * Scripts/webkitpy/commands/download.py:
3487          - Store "bug_id" in state instead of making a fake patch object.
3488          - Update to use Attachment and Bug objects.
3489         * Scripts/webkitpy/commands/download_unittest.py:
3490          - Update expected results now that our testing framework covers more code.
3491         * Scripts/webkitpy/commands/early_warning_system.py: Update to use new Attachment class.
3492         * Scripts/webkitpy/commands/queries.py: Remove unused ReviewedPatches class.
3493         * Scripts/webkitpy/commands/queries_unittest.py: ditto.
3494         * Scripts/webkitpy/commands/queues.py: Update to use new Attachment and CommitterValidator classes.
3495         * Scripts/webkitpy/commands/queuestest.py: ditto.
3496         * Scripts/webkitpy/commands/upload.py: ditto.
3497         * Scripts/webkitpy/mock_bugzillatool.py:
3498          - Now that more logic has moved into Attachment and Bug, we have to actually
3499            provide real reviewer emails as well as real reviewer flags.
3500          - Update mock methods to return Attachment objects.
3501         * Scripts/webkitpy/scm.py: Update to use Attachment class.
3502         * Scripts/webkitpy/scm_unittest.py: Update to use Attachment class.
3503         * Scripts/webkitpy/statusserver.py: ditto.
3504         * Scripts/webkitpy/steps/applypatch.py: ditto.
3505         * Scripts/webkitpy/steps/applypatchwithlocalcommit.py: ditto.
3506         * Scripts/webkitpy/steps/closebug.py: ditto.
3507         * Scripts/webkitpy/steps/closebugforlanddiff.py: Handle either state["bug_id"] or state["patch"].bug_id()
3508         * Scripts/webkitpy/steps/closepatch.py: Update to use Attachment class.
3509         * Scripts/webkitpy/steps/obsoletepatches.py: ditto.
3510         * Scripts/webkitpy/steps/updatechangelogswithreviewer.py: ditto.
3511
3512 2010-01-12  Adam Barth  <abarth@webkit.org>
3513
3514         Unreviewed typo fix.  :(
3515
3516         * Scripts/webkitpy/commands/early_warning_system.py:
3517         * Scripts/webkitpy/commands/queues.py:
3518
3519 2010-01-12  Adam Barth  <abarth@webkit.org>
3520
3521         Unreviewed.  Add "error" to the right part of the message.
3522
3523         * Scripts/webkitpy/commands/queues.py:
3524
3525 2010-01-12  Adam Barth  <abarth@webkit.org>
3526
3527         Reviewed by Eric Seidel.
3528
3529         EWS should show purple when svn-apply fails
3530         https://bugs.webkit.org/show_bug.cgi?id=33527
3531
3532         * Scripts/webkitpy/commands/early_warning_system.py:
3533         * Scripts/webkitpy/commands/queues.py:
3534
3535 2010-01-12  Adam Barth  <abarth@webkit.org>
3536
3537         Reviewed by Eric Seidel.
3538
3539         Remove copy/paste code from subclasses of AbstractReviewQueue
3540         https://bugs.webkit.org/show_bug.cgi?id=33525
3541
3542         * Scripts/webkitpy/commands/early_warning_system.py:
3543         * Scripts/webkitpy/commands/queues.py:
3544
3545 2010-01-12  Adam Barth  <abarth@webkit.org>
3546
3547         Reviewed by Eric Seidel.
3548
3549         Add Gustavo and Xan as gtk-ews watchers
3550         https://bugs.webkit.org/show_bug.cgi?id=33519
3551
3552         * Scripts/webkitpy/commands/early_warning_system.py:
3553
3554 2010-01-12  Adam Barth  <abarth@webkit.org>
3555
3556         Reviewed by Eric Seidel.
3557
3558         webkit-patch shouldn't waste my time for with a component prompt
3559         https://bugs.webkit.org/show_bug.cgi?id=33521
3560
3561         The component field isn't very useful for bugs created with
3562         webkit-patch because they're likely to be resolved quickly.  Instead of
3563         always prompting for a component, we should just default to the "New
3564         Bugs" component.  If the bug stays around for more than five minutes,
3565         we can assign it a proper component.
3566
3567         * Scripts/webkitpy/bugzilla.py:
3568
3569 2010-01-12  Adam Barth  <abarth@webkit.org>
3570
3571         Reviewed by Eric Seidel.
3572
3573         Add experimental "land-safely" command to webkit-patch
3574         https://bugs.webkit.org/show_bug.cgi?id=33518
3575
3576         * Scripts/webkitpy/commands/upload.py:
3577         * Scripts/webkitpy/commands/upload_unittest.py:
3578         * Scripts/webkitpy/steps/__init__.py:
3579         * Scripts/webkitpy/steps/postdiffforcommit.py: Added.
3580
3581 2010-01-11  Kevin Ollivier  <kevino@theolliviers.com>
3582
3583         [wx] Build fix after introduction of JS_NO_EXPORT
3584         
3585         * wx/build/settings.py:
3586
3587 2010-01-11  Eric Seidel  <eric@webkit.org>
3588
3589         No review, rolling out r53079.
3590         http://trac.webkit.org/changeset/53079
3591         https://bugs.webkit.org/show_bug.cgi?id=33197
3592
3593         Adam doens't think this actually works, and believe it caused
3594         a regression https://bugs.webkit.org/show_bug.cgi?id=33488 so
3595         rolling this out.
3596
3597         * Scripts/test-webkitpy:
3598         * Scripts/webkitpy/commands/abstractdiffcommand.py: Removed.
3599         * Scripts/webkitpy/commands/abstractdiffcommand_unittest.py: Removed.