WebKitTools/ChangeLog

   1 2007-12-16  Brent Fulgham  <bfulgham@gmail.com>
   2
   3         Reviewed by Adam Roben.
   4
   5         http://bugs.webkit.org/show_bug.cgi?id=16315
   6         FindSafari needs a path-only option.
   7
   8         * FindSafari/FindSafari.cpp:
   9         (_tmain):
  10
  11 2007-12-16  Alexey Proskuryakov  <ap@webkit.org>
  12
  13         Reviewed by Darin.
  14
  15         http://bugs.webkit.org/show_bug.cgi?id=16462
  16         REGRESSION: access keys broken on Windows
  17
  18         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Send system key events
  19         if Alt is pressed.
  20
  21 2007-12-15  Sam Weinig  <sam@webkit.org>
  22
  23         Reviewed by Mark Rowe.
  24
  25         Fix urlSuitableForTestResult to correctly identify wstring::npos as
  26         the case when wstring.find doesn't find anything.
  27
  28         * DumpRenderTree/win/DumpRenderTree.cpp:
  29         (urlSuitableForTestResult):
  30
  31 2007-12-15  Alp Toker  <alp@atoker.com>
  32
  33         GTK+ DRT build fix for GLib < 2.14.
  34
  35         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  36         (LayoutTestController::setWaitToDump):
  37
  38 2007-12-05  Mark Rowe  <mrowe@apple.com>
  39
  40         Reviewed by Alp Toker.
  41
  42         Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.  This prevents
  43         many layout tests from hanging while waiting on user responses to dialogs.
  44
  45         * DumpRenderTree/gtk/DumpRenderTree.cpp:
  46         (invalidateAnyPreviousWaitToDumpWatchdog):
  47         (webViewScriptAlert):
  48         (webViewScriptPrompt):
  49         (webViewScriptConfirm):
  50         (main):
  51         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
  52         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  53         (waitToDumpWatchdogFired):
  54         (LayoutTestController::setWaitToDump):
  55
  56 2007-12-05  Mark Rowe  <mrowe@apple.com>
  57
  58         Reviewed by Alp Toker.
  59
  60         Flesh out DumpRenderTree for Gtk.  After these changes, the majority of the tests in fast/js pass.
  61
  62         * DumpRenderTree/gtk/DumpRenderTree.cpp:
  63         (dumpFramesAsText): Don't print the frame name when dumping the main frame as text.
  64         (dump):
  65         (runTest):
  66         (webViewLoadStarted): Store the top frame when it starts loading so we can use it to determine when to dump.
  67         (webViewLoadFinished): Dump when the top frame load completes if we're not waiting for a JS callback and the
  68         work queue is empty.
  69         (webViewWindowObjectCleared): Set up window.layoutTestController.
  70         (webViewConsoleMessage): Match the console message format expected by the layout test results.
  71         (main): Hook up the new signals.
  72         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
  73         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Only notify done if the top frame has completed loading to avoid
  74         dumping multiple times.
  75         * Scripts/build-dumprendertree: Ensure build-dumprendertree is a no-op for Gtk too.
  76         * Scripts/run-webkit-tests: Teach run-webkit-tests that Gtk is like Qt in many ways.  Use run-launcher to open test results.
  77
  78 2007-12-14  Anders Carlsson  <andersca@apple.com>
  79
  80         Reviewed by Brady.
  81
  82         Assert that a web frame that's loading a resource always has either a data source or
  83         a provisional data source.
  84
  85         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
  86         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
  87
  88 2007-12-14  Darin Adler  <darin@apple.com>
  89
  90         - fix mistake causing nearly all tests to fail on Windows
  91
  92         * DumpRenderTree/win/UIDelegate.cpp:
  93         (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with
  94         npos, not 0. Also pass URL in to URL function rather than passing the entire message.
  95
  96         * DumpRenderTree/mac/UIDelegate.mm:
  97         (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather
  98         than passing the entire message.
  99
 100 2007-12-14  Darin Adler  <darin@apple.com>
 101
 102         - fix Tiger build
 103
 104         * DumpRenderTree/mac/UIDelegate.mm:
 105         (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any
 106         new-to-Leopard methods.
 107
 108 2007-12-14  Darin Adler  <darin@apple.com>
 109
 110         * DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method
 111         since it now triggers unwanted icon loading. We only had it because we implemented "all"
 112         delegate methods here.
 113
 114 2007-12-14  Anders Carlsson  <andersca@apple.com>
 115
 116         Reviewed by Darin and Geoff.
 117
 118         <rdar://problem/5619295>
 119         REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
 120
 121         Add property getting methods to the plug-in.
 122
 123         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
 124         (pluginInvoke):
 125
 126 2007-12-14  Kevin McCullough  <kmccullough@apple.com>
 127
 128         Reviewed by Darin.
 129
 130         - Layout test fix for mac. When dumped to the console local file paths
 131         now only show the name of the resource not the whole path.  This is to
 132         make the results machine and OS independent.
 133
 134         * DumpRenderTree/mac/UIDelegate.mm:
 135         (-[UIDelegate webView:addMessageToConsole:]):
 136
 137 2007-12-13  Kevin McCullough  <kmccullough@apple.com>
 138
 139         Reviewed by Adam.
 140
 141         - Layout tests fix.  We need a way to remove machine-dependent
 142         information from paths in layout test results. The UIDelegate now does
 143         this.
 144
 145         * DumpRenderTree/DumpRenderTree.h:
 146         * DumpRenderTree/win/DumpRenderTree.cpp:
 147         (urlSuitableForTestResult):
 148         * DumpRenderTree/win/DumpRenderTreeWin.h:
 149         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
 150         * DumpRenderTree/win/UIDelegate.cpp:
 151         (UIDelegate::webViewAddMessageToConsole):
 152
 153 2007-12-13  Alp Toker  <alp@atoker.com>
 154
 155         Build fix for DRT breakage introduced in r28690.
 156
 157         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 158         (LayoutTestController::pathToLocalResource):
 159
 160 2007-12-12  Kevin McCullough  <kmccullough@apple.com>
 161
 162         Reviewed by Alice and Sam.
 163
 164         - <rdar://5621435> Need a way to specify local resources (being loaded
 165         from HTTP tests) on Windows.
 166         - Implemented pathToLocalResource which exposes the functionality of
 167         converting a given unix path to the correct location on Windows.
 168
 169         * DumpRenderTree/LayoutTestController.cpp:
 170         (pathToLocalResourceCallback):
 171         (LayoutTestController::staticFunctions):
 172         * DumpRenderTree/LayoutTestController.h:
 173         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 174         (LayoutTestController::pathToLocalResource):
 175         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 176         (LayoutTestController::pathToLocalResource):
 177
 178 2007-12-12  Anders Carlsson  <andersca@apple.com>
 179
 180         Reviewed by Sam.
 181
 182         <rdar://problem/5132003>
 183         dumpResourceLoadCallbacks is not implemented in DRT on Windows.
 184
 185         * DumpRenderTree/win/DumpRenderTree.cpp:
 186         (main):
 187         Set the resource load delegate.
 188
 189         * DumpRenderTree/win/DumpRenderTree.vcproj:
 190
 191         * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
 192         * DumpRenderTree/win/ResourceLoadDelegate.h: Added.
 193
 194 2007-12-12  Alexey Proskuryakov  <ap@webkit.org>
 195
 196         Reviewed by Adam Roben.
 197
 198         Fix conversion from double to LPARAM in dispatchMessage().
 199
 200         * DumpRenderTree/win/EventSender.cpp:
 201         (dispatchMessageCallback):
 202
 203 2007-12-11  Dan Bernstein  <mitz@apple.com>
 204
 205         Reviewed by Mark Rowe and Sam Weinig too!
 206
 207         - added Helvetica Oblique and Helvetica Bold Oblique to the list of
 208           fonts DumpRenderTree registers.
 209
 210         * DumpRenderTree/win/DumpRenderTree.cpp:
 211         (initialize):
 212
 213 2007-12-11  Brady Eidson  <beidson@apple.com>
 214
 215         Reviewed by Anders
 216
 217         Make DumpRenderTree on mac use its own path for Databases testing
 218
 219         * DumpRenderTree/mac/DumpRenderTree.mm:
 220         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree
 221           for future DRT-only use, then use it to construct the Databases path and set that default
 222
 223 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
 224
 225         Reviewed by Darin.
 226
 227         <rdar://problem/5535636>
 228         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
 229
 230         http://bugs.webkit.org/show_bug.cgi?id=13916
 231         JavaScript detects Tab as a character input on a textfield validation
 232
 233         * DumpRenderTree/mac/EventSendingController.mm:
 234         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
 235         Dispatch a keyup to better match what happens when a key is physically pressed.
 236
 237         * DumpRenderTree/win/EventSender.cpp:
 238         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
 239         returning from keyDown().
 240         (getConstantCallback): Fixed a couple copy/paste mistakes.
 241
 242 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
 243
 244         Reviewed by Oliver.
 245
 246         - <rdar://5599845> Drosera: Does not show loal files in the file list
 247         on the left side.
 248
 249         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
 250         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
 251         so the open source community can build.
 252
 253 2007-12-10  Brady Eidson  <beidson@apple.com>
 254
 255         Rubberstamped by Sam Weinig
 256
 257         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
 258
 259         * DumpRenderTree/mac/UIDelegate.mm:
 260         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
 261         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
 262
 263 2007-12-08  Oliver Hunt  <oliver@apple.com>
 264
 265         Reviewed by Sam W.
 266
 267         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
 268
 269         Fixes <rdar://problem/5620249> Must disable SVG animation
 270         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
 271
 272         In order to allow finer grained control over the set of SVG features
 273         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
 274         distinct flags:
 275         ENABLE_SVG_ANIMATION
 276         ENABLE_SVG_FILTERS
 277         ENABLE_SVG_FONTS
 278         ENABLE_SVG_AS_IMAGE
 279         ENABLE_SVG_USE
 280
 281         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
 282
 283         Script handles all the new build flags, and allows --svg-experimental
 284         to automatically enable all features.
 285
 286         * Scripts/build-webkit:
 287
 288 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
 289
 290         Fix version parsing.
 291
 292         Rubber-stamped by Oliver.
 293
 294         * Drosera/win/Drosera.vcproj/auto-version.sh:
 295
 296 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
 297
 298         Build modifications for Drosera.
 299
 300         Reviewed by Adam.
 301
 302         * Drosera/DroseraWin.make: Added.
 303         * Drosera/win/Drosera.vcproj/Drosera.rc:
 304         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
 305         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
 306         * Drosera/win/Drosera.vcproj/VERSION: Added.
 307         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
 308
 309 2007-12-06  Adam Roben  <aroben@apple.com>
 310
 311         Explicitly turn on the Mac font ascent hack on Windows
 312
 313         This keeps our font metrics matching those from Mac.
 314
 315         Reviewed by Hyatt.
 316
 317         * DumpRenderTree/win/DumpRenderTree.cpp:
 318         (main):
 319
 320 2007-12-06  Anders Carlsson  <andersca@apple.com>
 321
 322         Rename main.c to main.cpp here too.
 323
 324         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
 325
 326 2007-12-06  Sam Weinig  <sam@webkit.org>
 327
 328         Rubber stamped by Geoff.
 329
 330         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
 331
 332 2007-12-06  Darin Adler  <darin@apple.com>
 333
 334         * Scripts/do-webcore-rename: Some more renaming plans.
 335
 336 2007-12-06  Anders Carlsson  <andersca@apple.com>
 337
 338         Restore implementation of testGetIntIdentifier that was accidentally
 339         removed somehow (possibly when I made PluginObject be a cpp file).
 340
 341         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
 342         (pluginInvoke):
 343
 344 2007-12-05  Anders Carlsson  <andersca@apple.com>
 345
 346         Make the entry points extern "C".
 347         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
 348
 349 2007-12-05  Anders Carlsson  <andersca@apple.com>
 350
 351         C++ warning fixes.
 352
 353         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
 354         (NPP_New):
 355         (NPP_Destroy):
 356         (NPP_SetWindow):
 357         (NPP_NewStream):
 358         (NPP_HandleEvent):
 359         (NPP_URLNotify):
 360         (NPP_GetValue):
 361
 362 2007-12-05  Anders Carlsson  <andersca@apple.com>
 363
 364         Add the .cpp files to the TestNetscapePlugIn target.
 365
 366         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 367
 368 2007-12-05  Anders Carlsson  <andersca@apple.com>
 369
 370         Reviewed by Geoff.
 371
 372         Rename the TestNetscapePlugIn .c files to be .cpp.
 373
 374         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 375         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
 376         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
 377         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
 378         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
 379         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
 380         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
 381         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
 382
 383 2007-12-05  Adam Roben  <aroben@apple.com>
 384
 385         Fix case of keypresses from the Windows implementation of eventSender.keyDown
 386
 387         This fixes several regression tests.
 388
 389         Reviewed by Alice.
 390
 391         * DumpRenderTree/win/EventSender.cpp:
 392         (keyDownCallback): Virtual keycodes for ASCII characters are always
 393         uppercase, so we need to check the case of the original character
 394         passed in to eventSender.keyDown.
 395
 396 2007-12-05  Adam Roben  <aroben@apple.com>
 397
 398         Learn from Tim's mistakes
 399
 400         * DumpRenderTree/win/DumpRenderTree.cpp:
 401         (runTest): Reset the authorAndUserStylesEnabled preference for each
 402         test.
 403
 404 2007-12-05  Alp Toker  <alp@atoker.com>
 405
 406         Reviewed by Mark Rowe.
 407
 408         Initialize GTK+ and WebKit so the tests can run.
 409
 410         Reorganize the headers a little.
 411
 412         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 413         (main):
 414
 415 2007-12-04  Anders Carlsson  <andersca@apple.com>
 416
 417         Remove IWebScriptScope include.
 418
 419         * Drosera/win/DebuggerDocumentPlatform.cpp:
 420
 421 2007-12-04  Sam Weinig  <sam@webkit.org>
 422
 423         Rubber stamped by Mark Rowe.
 424
 425         Define CF as platform for mac and revert r28409
 426
 427         * DumpRenderTree/DumpRenderTree.h:
 428         * DumpRenderTree/mac/DumpRenderTreeMac.h:
 429
 430 2007-12-04  Sam Weinig  <sam@webkit.org>
 431
 432         Define CF as platform for windows.
 433
 434         Reviewed by Adam Roben.
 435
 436         * DumpRenderTree/win/DumpRenderTreeWin.h:
 437
 438 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
 439
 440         Reviewed by Adam and Darin.
 441
 442         - Removed a needless BSTR cleanup.
 443
 444         * Drosera/win/DebuggerDocumentPlatform.cpp:
 445         (DebuggerDocument::getPlatformCurrentFunctionStack):
 446
 447 2007-11-27  Adam Roben  <aroben@apple.com>
 448
 449         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
 450
 451         Reviewed by Maciej.
 452
 453         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 454         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
 455
 456 2007-12-04  Alp Toker  <alp@atoker.com>
 457
 458         Prospective Win DRT build fix.
 459
 460         * DumpRenderTree/DumpRenderTree.h:
 461
 462 2007-12-04  Alp Toker  <alp@atoker.com>
 463
 464         Fix a clobbered copyright header.
 465
 466         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 467
 468 2007-12-04  Xan Lopez  <xan@gnome.org>
 469
 470         Reviewed by Alp Toker.
 471
 472         http://bugs.webkit.org/show_bug.cgi?id=15561
 473         GTK port needs DumpRenderTree implementation
 474
 475         Start work on the GTK+ DRT.
 476
 477         This does not work yet, and there are a few lingering style issues
 478         (nothing major) but this patch has been stuck in the bug tracker for
 479         too long already.
 480
 481         * DumpRenderTree/DumpRenderTree.h:
 482         * DumpRenderTree/gtk: Added.
 483         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
 484         (autocorrectURL):
 485         (shouldLogFrameLoadDelegates):
 486         (dumpFrameScrollPosition):
 487         (displayWebView):
 488         (appendString):
 489         (dumpFramesAsText):
 490         (dumpRenderTreeAsText):
 491         (dump):
 492         (runTest):
 493         (main):
 494         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
 495         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
 496         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
 497         (GCController::collect):
 498         (GCController::collectOnAlternateThread):
 499         (GCController::getJSObjectCount):
 500         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
 501         (LayoutTestController::~LayoutTestController):
 502         (LayoutTestController::addDisallowedURL):
 503         (LayoutTestController::clearBackForwardList):
 504         (LayoutTestController::copyDecodedHostName):
 505         (LayoutTestController::copyEncodedHostName):
 506         (LayoutTestController::display):
 507         (LayoutTestController::keepWebHistory):
 508         (LayoutTestController::notifyDone):
 509         (LayoutTestController::queueBackNavigation):
 510         (LayoutTestController::queueForwardNavigation):
 511         (LayoutTestController::queueLoad):
 512         (LayoutTestController::queueReload):
 513         (LayoutTestController::queueScript):
 514         (LayoutTestController::setAcceptsEditing):
 515         (LayoutTestController::setCustomPolicyDelegate):
 516         (LayoutTestController::setMainFrameIsFirstResponder):
 517         (LayoutTestController::setTabKeyCyclesThroughElements):
 518         (LayoutTestController::setUseDashboardCompatibilityMode):
 519         (LayoutTestController::setUserStyleSheetEnabled):
 520         (LayoutTestController::setUserStyleSheetLocation):
 521         (LayoutTestController::setWindowIsKey):
 522         (LayoutTestController::setWaitToDump):
 523         (LayoutTestController::windowCount):
 524         (LayoutTestController::setPrivateBrowsingEnabled):
 525         (LayoutTestController::setAuthorAndUserStylesEnabled):
 526         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
 527         (JSStringCopyUTF8CString):
 528         (LoadItem::invoke):
 529         (ReloadItem::invoke):
 530         (ScriptItem::invoke):
 531         (BackForwardItem::invoke):
 532
 533 2007-12-03  Sam Weinig  <sam@webkit.org>
 534
 535         Move JavaScriptCore thread testing code to pthread specific directory
 536         and remove the dependance on CoreFoundation by using WTF::HashSet.
 537
 538         Reviewed by Geoff and Oliver.
 539
 540         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 541         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
 542         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
 543         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
 544         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
 545         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
 546         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
 547         * DumpRenderTree/pthreads: Added.
 548         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
 549         (javaScriptThreads):
 550         (runJavaScriptThread):
 551         (startJavaScriptThreads):
 552         (stopJavaScriptThreads):
 553
 554 2007-12-03  Andrew Bonventre  <andybons@google.com>
 555
 556         Reviewed by Darin Adler.
 557
 558         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
 559         Symbol lookup menu broken in debugger view
 560
 561         * Drosera/debugger.js: Fixed javascript error where document property
 562         should have been used instead of contentDocument in switchFunction that
 563         was breaking the select symbol dropdown menu.  This is because
 564         window.frames will return a Window object and not a frame object like
 565         the author was originally expecting.
 566
 567 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
 568
 569         Reviewed by Adam.
 570
 571         - <rdar://5618942> Drosera: Console window does not process everything
 572         correctly.
 573         - <rdar://5619005> Drosera: could be sped up by moving the
 574         WebScriptScope stuff into the WebScriptCallFrame.
 575         - Now the console can correctly process objects and does not receive
 576         notifications from JavaScriptCore about the JavaScript in Drosera's
 577         own process.
 578
 579         * Drosera/win/DebuggerDocumentPlatform.cpp:
 580         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
 581         (DebuggerDocument::platformValueForScopeVariableNamed):
 582
 583 2007-12-03  Stephanie  <slewis@apple.com>
 584
 585         Reviewed by Darin.
 586
 587         Check to see if we are building a debug root
 588
 589         * Scripts/check-for-global-initializers:
 590
 591 2007-12-03  Dan Bernstein  <mitz@apple.com>
 592
 593         Reviewed by Darin Adler.
 594
 595         - added a testGetIntIdentifier() method to TestNetscapePlugIn
 596
 597         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
 598         (pluginInvoke):
 599
 600 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
 601
 602         Reviewed by Oliver.
 603
 604         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
 605         in a more fine-grained manner than eventSender.keyDown().
 606
 607         * DumpRenderTree/win/EventSender.cpp:
 608         (getConstantCallback):
 609         (dispatchMessageCallback):
 610
 611 2007-12-02  Darin Adler  <darin@apple.com>
 612
 613         * Scripts/do-webcore-rename: More planned renaming.
 614
 615 2007-12-02  Sam Weinig  <sam@webkit.org>
 616
 617         Rubber stamped by Anders.
 618
 619         Use [NSURL absoluteString] instead of [NSURL description] in order to get
 620         more uniform results cross platform.
 621
 622         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
 623         (-[NSURL _drt_descriptionSuitableForTestResult]):
 624
 625 2007-12-02  Sam Weinig  <sam@webkit.org>
 626
 627         Rubber stamped by Niko.
 628
 629         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
 630
 631         * DumpRenderTree/win/DumpRenderTree.cpp:
 632         * DumpRenderTree/win/DumpRenderTree.vcproj:
 633         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
 634         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
 635         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
 636         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
 637
 638 2007-12-01  Alp Toker  <alp@atoker.com>
 639
 640         Reviewed by Adam Roben.
 641
 642         Make use of the newly introduced webkit.h convenience header.
 643
 644         * GtkLauncher/main.c:
 645
 646 2007-12-01  Adam Treat  <treat@kde.org>
 647
 648         Reviewed by Simon.
 649
 650         * Check to see if the directory exists and exit if not.
 651
 652         * DumpRenderTree/qt/main.cpp:
 653         (main):
 654
 655 2007-12-01  Adam Treat  <treat@kde.org>
 656
 657         Reviewed by Simon.
 658
 659         * Don't hide symbols when in Debug mode
 660         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
 661
 662
 663         * DumpRenderTree/qt/main.cpp:
 664         (messageHandler):
 665
 666 2007-11-30  Alp Toker  <alp@atoker.com>
 667
 668         Reviewed by Adam Roben.
 669
 670         http://bugs.webkit.org/show_bug.cgi?id=15691
 671         [GTK] Public API does not follow GTK+ conventions
 672
 673         Refactor the WebKit/GTK+ public API. Changes:
 674           WebKitPage -> WebKitWebView
 675           WebKitFrame -> WebKitWebFrame
 676
 677         Public API source and header names have been updated to mirror the API
 678         changes.
 679
 680         The API is now kept in WebKit/gtk/WebView to match other ports in the
 681         same class such as Mac and Win.
 682
 683         * GtkLauncher/main.c:
 684         (activate_uri_entry_cb):
 685         (link_hover_cb):
 686         (title_change_cb):
 687         (progress_change_cb):
 688         (go_back_cb):
 689         (go_forward_cb):
 690         (create_browser):
 691         (main):
 692
 693 2007-11-30  Adam Roben  <aroben@apple.com>
 694
 695         Hopefully the final build fix
 696
 697         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
 698         pull in WTF's assertion/logging functions.
 699
 700 2007-11-30  Adam Roben  <aroben@apple.com>
 701
 702         Another build fix
 703
 704         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
 705         WebKit.lib.
 706
 707 2007-11-30  Adam Roben  <aroben@apple.com>
 708
 709         Debug build fix
 710
 711         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
 712         configuration.
 713         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
 714         projects.
 715         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
 716         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
 717         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
 718
 719 2007-11-30  Sam Weinig  <sam@webkit.org>
 720
 721         Reviewed by Adam Roben.
 722
 723         Fix drawSelectionRect to actually draw the selection rect.
 724
 725         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
 726         (drawSelectionRect):
 727
 728 2007-11-30  Darin Adler  <darin@apple.com>
 729
 730         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
 731
 732 2007-11-30  Darin Adler  <darin@apple.com>
 733
 734         * Scripts/do-webcore-rename: Get ready for some future renaming.
 735
 736 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
 737
 738         Reviewed by Adam.
 739
 740         - Removed some unnecessary functions and changed an unused return type.
 741
 742         * Drosera/win/DebuggerClient.cpp:
 743         (registerConsoleClass):
 744         * Drosera/win/DebuggerClient.h:
 745         * Drosera/win/Drosera.cpp:
 746         (registerDroseraClass):
 747
 748 2007-11-28  Alp Toker  <alp@atoker.com>
 749
 750         Reviewed by Timothy Hatcher.
 751
 752         http://bugs.webkit.org/show_bug.cgi?id=16174
 753         [GTK] Use "URI" not "URL" in public API
 754
 755         Replace use of the term "URL" with "URI" in public headers,
 756         documentation and some internal code to match GLib/GTK+ convention.
 757
 758         This is now mentioned in the API guidelines:
 759           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
 760
 761         * GtkLauncher/main.c:
 762         (activate_uri_entry_cb):
 763         (title_change_cb):
 764         (create_toolbar):
 765         (main):
 766
 767 2007-11-29  Anders Carlsson  <andersca@apple.com>
 768
 769         Reviewed by Sam.
 770
 771         <rdar://problem/5230478>
 772         FrameLoadDelegate callbacks are not dumped in DRT.
 773
 774         * DumpRenderTree/win/DumpRenderTree.cpp:
 775         (shouldLogFrameLoadDelegates):
 776         (runTest):
 777         (main):
 778         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
 779         (BSTRtoString):
 780         (descriptionSuitableForTestResult):
 781         (FrameLoadDelegate::QueryInterface):
 782         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
 783         (FrameLoadDelegate::didFailProvisionalLoadWithError):
 784         (FrameLoadDelegate::didCommitLoadForFrame):
 785         (FrameLoadDelegate::didFinishLoadForFrame):
 786         (FrameLoadDelegate::willCloseFrame):
 787         (FrameLoadDelegate::didClearWindowObject):
 788         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
 789         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
 790         * DumpRenderTree/win/FrameLoaderDelegate.h:
 791         (FrameLoadDelegate::windowScriptObjectAvailable):
 792         (FrameLoadDelegate::didFirstLayoutInFrame):
 793
 794 2007-11-29  Sam Weinig  <sam@webkit.org>
 795
 796         Reviewed by Anders.
 797
 798         Add database quota UIDelegates methods to DRT UIDelegate.
 799
 800         * DumpRenderTree/mac/UIDelegate.mm:
 801         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
 802         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
 803
 804 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
 805
 806         Reviewed by Sam.
 807
 808         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
 809         dying and vice versa.
 810         - This fix will allow Drosera and Safari to reconnect if either of them
 811         closes correctly, but does not fix the case where one of them dies
 812         silently.
 813
 814         * Drosera/win/ServerConnection.cpp:
 815         (ServerConnection::attemptToCreateServerConnection): Added a safety
 816         check, because it's possilbe to try to connect to a server that's dying.
 817         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
 818         the server has died.
 819         * Drosera/win/ServerConnection.h: Added the new function and removed
 820         an unnecessary member.
 821
 822 2007-11-29  Anders Carlsson  <andersca@apple.com>
 823
 824         * DumpRenderTree/win/DumpRenderTree.vcproj:
 825         Add shlwapi.lib to all configurations.
 826
 827 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
 828
 829         - Build fix.  Added additional includes for VS Express to the Release
 830         project.
 831
 832         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
 833
 834 2007-11-29  Anders Carlsson  <andersca@apple.com>
 835
 836         Reviewed by Adam.
 837
 838         <rdar://problem/5132005>
 839         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
 840
 841         * DumpRenderTree/win/DumpRenderTree.vcproj:
 842         Add shlwapi.lib
 843
 844         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 845         (LayoutTestController::setUserStyleSheetEnabled):
 846         Implement this.
 847
 848         (appendComponentToPath):
 849         New method which wraps the Win32 API PathAppend.
 850
 851         (followShortcuts):
 852         New method which checks if a file points to a shortcut and
 853         follows the shortcut.
 854
 855         (resolveCygwinPath):
 856         New method that takes a cygwin unix-style path and returns the Win32 path.
 857
 858         (cfStringRefToWString):
 859
 860         (LayoutTestController::setUserStyleSheetLocation):
 861         Implement this.
 862
 863 2007-11-29  Alice Liu  <alice.liu@apple.com>
 864
 865         Reviewed by Adam.
 866
 867         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
 868
 869         * DumpRenderTree/win/EventSender.cpp:
 870         (keyDownCallback):
 871         uppercase letters were being sent as lowercase letters without the shift key down.
 872
 873 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
 874
 875         - Windows build fix. VS express needs some love.
 876
 877         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
 878
 879 2007-11-28  Darin Adler  <darin@apple.com>
 880
 881         Reviewed by Adam Roben.
 882
 883         * DumpRenderTree/mac/EventSendingController.mm:
 884         (-[EventSendingController keyDown:withModifiers:]):
 885         Send capital letters through as lowercase letters with the shift key down
 886         rather than sending them as if they were highly unusual "capital letter keys".
 887
 888         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
 889         where you need to update results and more tests are failing than before.
 890
 891 2007-11-28  Anders Carlsson  <andersca@apple.com>
 892
 893         Reviewed by Darin.
 894
 895         <rdar://problem/5132001>
 896         contextClick is not implemented in DRT on Windows.
 897
 898         * DumpRenderTree/win/EventSender.cpp:
 899         (contextClickCallback):
 900         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
 901         by a WM_RBUTTONUP message.
 902
 903         * DumpRenderTree/win/UIDelegate.cpp:
 904         (UIDelegate::hasCustomMenuImplementation):
 905         (UIDelegate::trackCustomPopupMenu):
 906         * DumpRenderTree/win/UIDelegate.h:
 907         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
 908         menu from being shown (and causing the DRT to hang).
 909
 910 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
 911
 912         Reviewed by Darin.
 913
 914         Fix DumpRenderTree ObjC bug comparing strings.
 915
 916         * DumpRenderTree/mac/ObjCController.m:
 917         (-[ObjCController identityIsEqual::]): Compare strings with string
 918         equality instead of identiy equality.
 919
 920 2007-11-27  Timothy Hatcher  <timothy@apple.com>
 921
 922         Reviewed by Sam.
 923
 924         Reset the authorAndUserStylesEnabled preference
 925         back to YES for each test. Fixes the broken tests.
 926
 927         * DumpRenderTree/mac/DumpRenderTree.mm:
 928         (resetWebViewToConsistentStateBeforeTesting):
 929
 930 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
 931
 932         Reviewed by Adam.
 933
 934         - Drosera now displays the console window, although it cannot currently
 935         process JavaScript.
 936
 937         * Drosera/win/DebuggerClient.cpp: Shows the console window.
 938         (registerConsoleClass): Implemented.
 939         (consoleWndProc): Implemented.
 940         (DebuggerClient::onSize): Implemented.
 941         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
 942         new window.
 943         * Drosera/win/DebuggerClient.h: Added needed method and members for
 944         creating and maintaining a new window.
 945         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
 946         lines of code to more appropriate places.
 947         (Drosera::handleCommand):
 948         (Drosera::initUI):
 949         (Drosera::onSize):
 950         (Drosera::attach):
 951
 952 2007-11-27  Timothy Hatcher  <timothy@apple.com>
 953
 954         Reviewed by Dave Hyatt.
 955
 956         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
 957
 958         Add support for disabling author and user styles for testing.
 959
 960         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 961         * DumpRenderTree/LayoutTestController.cpp:
 962         (setAuthorAndUserStylesEnabledCallback):
 963         (LayoutTestController::staticFunctions):
 964         * DumpRenderTree/LayoutTestController.h:
 965         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 966         (LayoutTestController::setAuthorAndUserStylesEnabled):
 967         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 968         (LayoutTestController::setAuthorAndUserStylesEnabled):
 969
 970 2007-11-26  Dan Bernstein  <mitz@apple.com>
 971
 972         - Tiger build fix.
 973
 974         * DumpRenderTree/mac/Configurations/Base.xcconfig:
 975
 976 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
 977
 978         Reviewed by Maciej.
 979
 980         - Implemented displaying variables for Drosera on Win.
 981
 982         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
 983         that retrieve variables to not hold onto the return value since it's
 984         not returned.  Also changed to use the new signatures of the retrieval
 985         functions.
 986         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
 987         (DebuggerDocument::platformValueForScopeVariableNamed):
 988         * Drosera/win/Drosera.cpp: Removed a needless TODO.
 989         (droseraWndProc):
 990
 991 2007-11-26  Sam Weinig  <sam@webkit.org>
 992
 993         Cleanup names of painting and repainting functions.
 994
 995         Reviewed by Adam Roben.
 996
 997         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
 998         (drawSelectionRect): was drawSelectionRectIntoContext.
 999         (dumpWebViewAsPixelsAndCompareWithExpected):
1000         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1001         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1002         (paintWebView): was drawWebViewIntoContext.
1003         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
1004
1005 2007-11-26  Sam Weinig  <sam@webkit.org>
1006
1007         Reviewed by Dan Bernstein.
1008
1009         - Leopard build fix
1010
1011         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1012
1013 2007-11-26  Sam Weinig  <sam@webkit.org>
1014
1015         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
1016         Use shared PixelDumpSupport for Mac DRT
1017
1018         Reviewed by Adam Roben.
1019
1020         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1021         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
1022         * DumpRenderTree/cg/ImageDiffCG.cpp:
1023         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1024         (drawSelectionRectIntoContext):
1025         (dumpWebViewAsPixelsAndCompareWithExpected):
1026         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1027         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1028         * DumpRenderTree/mac/DumpRenderTree.mm:
1029         (dump):
1030         * DumpRenderTree/mac/ImageDiff.m: Removed.
1031         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
1032         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
1033         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
1034         (setDefaultColorProfileToRGB):
1035         (getBitmapContextFromWebView):
1036         (drawWebViewIntoContext):
1037         (repaintWithVerticalSweep):
1038         (repaintWithHorizontalSweep):
1039         (getSelectionRect):
1040         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
1041
1042 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
1043
1044         Bug 16052: prepare-ChangeLog doesn't report deleted files
1045         <http://bugs.webkit.org/show_bug.cgi?id=16052>
1046
1047         Reviewed by Sam.
1048
1049         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
1050
1051 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
1052
1053         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
1054         <http://bugs.webkit.org/show_bug.cgi?id=15864>
1055
1056         Reviewed by Adam.
1057
1058         Roll functionality of merge-changelog into resolve-ChangeLogs
1059         script.  The script now checks for ChangeLog.rej and
1060         ChangeLog.orig files first.  If it finds them, it uses the
1061         ChangeLog.rej file as a patch (in old contextual diff format) to
1062         apply with --fuzz=3.
1063
1064         * Scripts/merge-changelog: Removed.
1065         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
1066
1067 2007-11-25  Sam Weinig  <sam@webkit.org>
1068
1069         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
1070
1071         Reviewed by Mark Rowe.
1072
1073         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1074         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1075         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1076         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
1077         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
1078
1079 2007-11-25  Sam Weinig  <sam@webkit.org>
1080
1081         Convert DumpRenderTree to ues .xcconfig files.
1082
1083         Reviewed by Mark Rowe.
1084
1085         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1086         * DumpRenderTree/mac/Configurations: Added.
1087         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
1088         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
1089         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
1090
1091 2007-11-25  Sam Weinig  <sam@webkit.org>
1092
1093         Add ForwardingHeaders to wtf for DumpRenderTree.
1094
1095         Reviewed by Mark Rowe.
1096
1097         * DumpRenderTree/DumpRenderTree.h:
1098         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1099         * DumpRenderTree/ForwardingHeaders: Added.
1100         * DumpRenderTree/ForwardingHeaders/wtf: Added.
1101         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
1102         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
1103         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
1104         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
1105         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
1106         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
1107         * DumpRenderTree/LayoutTestController.cpp:
1108         * DumpRenderTree/WorkQueue.cpp:
1109         * DumpRenderTree/mac/DumpRenderTree.mm:
1110         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1111         * DumpRenderTree/mac/JavaScriptThreading.cpp:
1112         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1113         * DumpRenderTree/mac/ObjCController.m:
1114         * DumpRenderTree/mac/UIDelegate.mm:
1115         * DumpRenderTree/mac/WorkQueueItemMac.mm:
1116
1117 2007-11-25  Adam Roben  <aroben@apple.com>
1118
1119         Fix some test failures caused by r28019
1120
1121         Now that stdout is in binary mode, we need to always use printf
1122         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
1123         the output.
1124
1125         Reviewed by Sam.
1126
1127         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
1128         printf.
1129         (UIDelegate::runJavaScriptAlertPanelWithMessage):
1130         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
1131         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
1132         (UIDelegate::webViewAddMessageToConsole):
1133
1134 2007-11-25  Adam Roben  <aroben@apple.com>
1135
1136         Set the font smoothing preference in DRT
1137
1138         This makes the pixel results on Windows closer to the Mac results.
1139
1140         Reviewed by Mitz.
1141
1142         * DumpRenderTree/win/DumpRenderTree.cpp:
1143         (initializePreferences):
1144
1145 2007-11-25  Adam Roben  <aroben@apple.com>
1146
1147         Port ImageDiff to CG and C++
1148
1149         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
1150         <rdar://5071708>
1151
1152         Reviewed by Sam.
1153
1154         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
1155         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
1156         (main):
1157         (createImageFromStdin):
1158         (compareImages):
1159         (getDifferenceBitmap):
1160         (computePercentageDifferent):
1161         * DumpRenderTree/win/ImageDiff.vcproj: Added.
1162
1163 2007-11-25  Adam Roben  <aroben@apple.com>
1164
1165         Fix image diff link generation on Windows
1166
1167         Reviewed by Sam.
1168
1169         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
1170         to toURL.
1171
1172 2007-11-25  Adam Roben  <aroben@apple.com>
1173
1174         Implement pixel dumping in Windows DRT
1175
1176         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
1177         <rdar://5071708>
1178
1179         Reviewed by Sam.
1180
1181         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
1182         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
1183         Content-Length header.
1184         (getMD5HashStringForBitmap):
1185         (dumpWebViewAsPixelsAndCompareWithExpected):
1186         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
1187         * DumpRenderTree/win/DumpRenderTree.cpp:
1188         (dump): Do a pixel dump if requested.
1189         (main): Parse pixel test options.
1190         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
1191         the cg/ subdirectory to the include path.
1192         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
1193         available in a header or import library, so we have to go through this
1194         LoadLibrary/GetProcAddress dance to use them.
1195         (cryptDLL):
1196         (init):
1197         (update):
1198         (final):
1199         (MD5_Init):
1200         (MD5_Update):
1201         (MD5_Final):
1202         * DumpRenderTree/win/MD5.h: Added.
1203         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
1204         moved up to the top level to share it with Mac eventually.
1205         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
1206         (getBitmapContextFromWebView): Forces the WebView to paint using a
1207         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
1208
1209 2007-11-25  Adam Roben  <aroben@apple.com>
1210
1211         Clean up Windows DRT's option parsing a little bit
1212
1213         Reviewed by Sam.
1214
1215         * DumpRenderTree/win/DumpRenderTree.cpp:
1216         (main): Put non-option arguments into a Vector.
1217
1218 2007-11-25  Adam Roben  <aroben@apple.com>
1219
1220         Make Windows DRT stop changing LF into CRLF
1221
1222         Reviewed by Sam.
1223
1224         * DumpRenderTree/win/DumpRenderTree.cpp:
1225         (main): Put stdout in binary mode.
1226         * Scripts/run-webkit-tests: Remove the CRLF hack.
1227
1228 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
1229
1230         Removed empty directory.
1231
1232         * Scripts/resources: Removed.
1233
1234 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
1235
1236         Fix bisect-builds to work with recent WebKit nightly builds.
1237
1238         Reviewed by Dan.
1239
1240         * Scripts/bisect-builds: Check for the
1241         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
1242         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
1243         to WebKit.app/Contents/Resources.
1244
1245 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
1246
1247         Reviewed by Maciej.
1248
1249         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
1250         not closed (affects digg.com)
1251
1252         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
1253         one after finishing with a test to avoid having its delayed onload handler firing when
1254         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
1255         but it helps somewhat.
1256
1257 2007-11-22  Mark Rowe  <mrowe@apple.com>
1258
1259         Reviewed by Alp Toker.
1260
1261         Fix build-webkit to propagate make's exit status if it fails.
1262
1263         * Scripts/webkitdirs.pm:
1264
1265 2007-11-22  Dan Bernstein  <mitz@apple.com>
1266
1267         Reviewed by Mark Rowe.
1268
1269         - fix crash when running pixel tests
1270
1271         * DumpRenderTree/mac/DumpRenderTree.mm:
1272         (dumpRenderTree): Parse the command line options before setting up the
1273         environment so that we know if we need to set up the pixel dump
1274         machinery.
1275
1276 2007-11-21  Eric Seidel  <eric@webkit.org>
1277
1278         Speculative build fix for Tiger.
1279
1280         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
1281
1282 2007-11-21  Eric Seidel  <eric@webkit.org>
1283
1284         Reviewed by Tim Hatcher.
1285
1286         Break out more of DumpRenderTree.mm into individual files
1287
1288         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1289         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
1290         (checkedMalloc):
1291         (checkedRealloc):
1292         (makeLargeMallocFailSilently):
1293         * DumpRenderTree/mac/CheckedMalloc.h: Added.
1294         * DumpRenderTree/mac/DumpRenderTree.mm:
1295         (crashHandler):
1296         (dump):
1297         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1298         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
1299         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
1300         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1301         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1302         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
1303         (javaScriptThreads):
1304         (runJavaScriptThread):
1305         (startJavaScriptThreads):
1306         (stopJavaScriptThreads):
1307         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
1308         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
1309         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
1310         (restoreColorSpace):
1311         (setDefaultColorProfileToRGB):
1312         (initializeColorSpaceAndScreeBufferForPixelTests):
1313         (md5HashStringForBitmap):
1314         (dumpWebViewAsPixelsAndCompareWithExpected):
1315
1316 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
1317
1318         Move install-unix-extras to wx directory as it seems only to be used by that
1319         port now. It now supports universal binaries on Mac and adds libpng and libjpeg.
1320         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
1321         have install-unix-extras install into WebKitLibraries as per
1322         convention.
1323
1324         Reviewed by Mark Rowe.
1325
1326         * Scripts/install-unix-extras: Removed.
1327         * wx/build-wxwebkit:
1328         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
1329
1330 2007-11-21  Eric Seidel  <eric@webkit.org>
1331
1332         Reviewed by Adam.
1333
1334         More refactoring for greater code readability
1335
1336         * DumpRenderTree/mac/DumpRenderTree.mm:
1337         (initializeGlobalsFromCommandLineOptions):
1338         (initializeColorSpaceAndScreeBufferForPixelTests):
1339         (addTestPluginsToPluginSearchPath):
1340         (useLongRunningServerMode):
1341         (runTestingServerLoop):
1342         (prepareConsistentTestingEnvironment):
1343         (dumpRenderTree):
1344         (main):
1345         (dumpFramesAsText):
1346         (dumpBackForwardListForWebView):
1347         (sizeWebViewForCurrentTest):
1348         (methodNameStringForFailedTest):
1349         (dumpBackForwardListForAllWindows):
1350         (dumpWebViewAsPixelsAndCompareWithExpected):
1351         (invalidateAnyPreviousWaitToDumpWatchdog):
1352         (dump):
1353         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1354         * DumpRenderTree/mac/UIDelegate.mm:
1355         (-[UIDelegate webView:createWebViewWithRequest:]):
1356
1357 2007-11-21  Eric Seidel  <eric@webkit.org>
1358
1359         Reviewed by Tim Hatcher.
1360
1361         Abstract more of DRT into static methods
1362
1363         * DumpRenderTree/mac/DumpRenderTree.mm:
1364         (setDefaultsToConsistentValuesForTesting):
1365         (setupSignalHandlers):
1366         (allocateGlobalControllers):
1367         (releaseAndZero):
1368         (releaseGlobalControllers):
1369         (dumpRenderTree):
1370         (shouldLogFrameLoadDelegates):
1371         (createCFURLFromPathOrURL):
1372         (resetWebViewToConsistentStateBeforeTesting):
1373         (runTest):
1374
1375 2007-11-21  Eric Seidel  <eric@webkit.org>
1376
1377         Reviewed by Tim Hatcher.
1378
1379         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
1380
1381         * DumpRenderTree/DumpRenderTree.h:
1382         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1383         * DumpRenderTree/mac/DumpRenderTree.mm:
1384         (dumpRenderTree):
1385         (dump):
1386         (runTest):
1387         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
1388         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
1389         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
1390         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
1391         (-[DumpRenderTreePasteboard declareType:owner:]):
1392         (+[LocalPasteboard alloc]):
1393         (-[LocalPasteboard init]):
1394         (-[LocalPasteboard dealloc]):
1395         (-[LocalPasteboard name]):
1396         (-[LocalPasteboard releaseGlobally]):
1397         (-[LocalPasteboard declareTypes:owner:]):
1398         (-[LocalPasteboard addTypes:owner:]):
1399         (-[LocalPasteboard changeCount]):
1400         (-[LocalPasteboard types]):
1401         (-[LocalPasteboard availableTypeFromArray:]):
1402         (-[LocalPasteboard setData:forType:]):
1403         (-[LocalPasteboard dataForType:]):
1404         (-[LocalPasteboard setPropertyList:forType:]):
1405         (-[LocalPasteboard setString:forType:]):
1406         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
1407         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
1408         (+[DumpRenderTreeWindow allWindows]):
1409         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
1410         (-[DumpRenderTreeWindow dealloc]):
1411         (-[DumpRenderTreeWindow isKeyWindow]):
1412         (-[DumpRenderTreeWindow keyDown:]):
1413
1414 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
1415
1416         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
1417         it indiscriminately copies any headers inside JavaScriptCore,
1418         which includes Tiger ICU headers.
1419
1420         * wx/build-wxwebkit:
1421         Don't run WebCore/move-js-headers.sh any longer.
1422
1423 2007-11-20  Adam Treat  <treat@kde.org>
1424
1425         Reviewed by David Kilzer.
1426
1427         * Prepend git branch name to $baseProductDir
1428
1429         * Scripts/VCSUtils.pm:
1430         * Scripts/webkitdirs.pm:
1431
1432 2007-11-20  Mark Rowe  <mrowe@apple.com>
1433
1434         Reviewed by Simon Hausmann.
1435
1436         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
1437         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
1438         Have it trigger a "make distclean" rather than "make clean" to ensure that the
1439         built product and generated Makefile's are removed.
1440
1441 2007-11-19  Alp Toker  <alp@atoker.com>
1442
1443         Reviewed by Mark Rowe.
1444
1445         http://bugs.webkit.org/show_bug.cgi?id=16040
1446         [GTK] GtkLauncher should be written in C
1447
1448         Port GtkLauncher to plain C.
1449
1450         Use a more conventional GTK+ coding style.
1451
1452         Use a toolbar instead of menus.
1453
1454         Various signature fixes and cleanups.
1455
1456         Add a license header. Assume all previous modifications were copyright
1457         assigned to Apple Inc. by default.
1458
1459         * GtkLauncher/GtkLauncher.pro:
1460         * GtkLauncher/main.c: Added.
1461         (activate_url_entry_cb):
1462         (update_title):
1463         (link_hover_cb):
1464         (title_change_cb):
1465         (progress_change_cb):
1466         (destroy_cb):
1467         (go_back_cb):
1468         (go_forward_cb):
1469         (create_browser):
1470         (create_statusbar):
1471         (create_toolbar):
1472         (create_window):
1473         (main):
1474         * GtkLauncher/main.cpp: Removed.
1475
1476 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
1477
1478         Build script fixes to ensure they do the right thing for the
1479         wx port, and update build-wxwebkit to reflect the way the
1480         build scripts now work.
1481
1482         Reviewed by Adam.
1483
1484         * Scripts/build-testkjs:
1485         * Scripts/build-webkit:
1486         * Scripts/run-javascriptcore-tests:
1487         * Scripts/webkitdirs.pm:
1488         * wx/build-wxwebkit:
1489
1490 2007-11-18  Eric Seidel  <eric@webkit.org>
1491
1492         Reviewed by Anders.
1493
1494         Make run-javascriptcore-tests report failures on exit (to support git bisect)
1495
1496         * Scripts/run-javascriptcore-tests:
1497
1498 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
1499
1500         Reviewed by Adam Roben.
1501
1502         Make run-webkit-tests work with Windows debug build.
1503
1504         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
1505         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
1506         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
1507         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
1508         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
1509
1510 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
1511
1512         Add wxWebKit sample and build script, and integrate it with
1513         build-webkit. Also make build-webkit --clean work for all
1514         ports.
1515
1516         Reviewed by Darin Adler.
1517
1518         * Scripts/build-webkit:
1519         * Scripts/webkitdirs.pm:
1520         * wx: Added.
1521         * wx/browser: Added.
1522         * wx/browser/browser.bkl: Added.
1523         * wx/browser/browser.cpp: Added.
1524         * wx/build-wxwebkit: Added.
1525
1526 2007-11-17  Adam Roben  <aroben@apple.com>
1527
1528         Make it easy to run Safari in the debugger on Windows
1529
1530         I've added a new script, debug-safari, which launches Safari in the
1531         debugger. On OS X it just calls gdb-safari.
1532
1533         Reviewed by Mark Rowe.
1534
1535         * FindSafari/FindSafari.cpp:
1536         (_tmain): Added a /debugger flag, which in combination with
1537         /printSafariLauncher will print a script that launches Safari in the
1538         debugger.
1539         * Scripts/debug-safari: Added.
1540         * Scripts/run-safari: Changed to call runSafari().
1541         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
1542         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
1543         first argument along to FindSafari.
1544         * Scripts/webkitdirs.pm:
1545         (sub runSafari): Added.
1546
1547 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
1548
1549         Reviewed by Adam Roben.
1550
1551         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined.
1552
1553 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
1554
1555         Reviewed by David Kilzer.
1556
1557         The git config command was renamed to repo-config at some point. This
1558         change tries git config and then git repo-config if the first fails.
1559
1560         * Scripts/prepare-ChangeLog:
1561         (gitConfig):
1562
1563 2007-11-16  Dan Bernstein  <mitz@apple.com>
1564
1565         Reviewed by Darin Adler and Sam Weinig.
1566
1567         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
1568
1569         * DumpRenderTree/win/EventSender.cpp:
1570         (keyDownCallback): For characters that cannot be entered on the active
1571         keyboard layout, send a WM_CHAR message with the character along with
1572         a WM_KEYDOWN message with a virtual key code of 255.
1573
1574 2007-11-16  Mark Rowe  <mrowe@apple.com>
1575
1576         Reviewed by Tim Hatcher.
1577
1578         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
1579
1580         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1581         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1582
1583 2007-11-15  Adam Roben  <aroben@apple.com>
1584
1585         Make run-safari actually work on Windows
1586
1587         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
1588         chdir call.
1589
1590 2007-11-14  Adam Roben  <aroben@apple.com>
1591
1592         Updates to Safari launching now that 3.0.4 is released
1593
1594         Reviewed by Sam.
1595
1596         * FindSafari/FindSafari.cpp:
1597         (getWebViewCLSID): Use version-independent ProgID.
1598         * Scripts/run-safari: Use run-webkit-nightly.cmd.
1599
1600 2007-11-14  Anders Carlsson  <andersca@apple.com>
1601
1602         Reviewed by Adam.
1603
1604         <rdar://problem/5309081>
1605         In DRT, "plugin.logDestroy = true" not working on Windows.
1606
1607         * DumpRenderTree/win/TestNetscapePlugin/main.c:
1608         (NPP_Destroy):
1609
1610 2007-11-14  Eric Seidel  <eric@webkit.org>
1611
1612         Reviewed by Sam.
1613
1614         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
1615
1616 2007-11-14  Anders Carlsson  <andersca@apple.com>
1617
1618         Reviewed by Adam.
1619
1620         <rdar://problem/5141186>
1621         window.layoutTestController.setWindowIsKey is not implemented in DRT.
1622
1623         Implement setWindowIsKey.
1624
1625         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1626         (LayoutTestController::setWindowIsKey):
1627
1628 2007-11-13  Sam Weinig  <sam@webkit.org>
1629
1630         Reviewed by Adam Roben.
1631
1632         Fix for <rdar://problem/5382579>
1633         http/tests/security/cross-frame-access-put.html reports large
1634         negative numbers for screenLeft and screenTop (Mac reports "0")
1635
1636         * DumpRenderTree/win/UIDelegate.cpp:
1637         (UIDelegate::UIDelegate): Initialize the RECT.
1638         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
1639         (UIDelegate::webViewFrame): ditto.
1640         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
1641
1642 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
1643
1644         Reviewed by Adam.
1645
1646         - Make Drosera show source, source URLs, and function stack on Windows,
1647         and some minor fixes.
1648
1649         * Drosera/DebuggerDocument.cpp: Force source to always update display.
1650         (DebuggerDocument::updateFileSource):
1651         * Drosera/debugger.js: Force source to always update display.
1652         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
1653         menu controls.
1654         (DebuggerClient::resume):
1655         (DebuggerClient::pause):
1656         (DebuggerClient::stepInto):
1657         (DebuggerClient::stepOver):
1658         (DebuggerClient::stepOut):
1659         (DebuggerClient::showConsole):
1660         (DebuggerClient::closeCurrentFile):
1661         * Drosera/win/DebuggerClient.h: Ditto.
1662         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
1663         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
1664         removed two bugs.  1) caller could be in a bad state when asked to
1665         assign into it. 2) BSTRs were not created correctly.
1666         (DebuggerDocument::getPlatformCurrentFunctionStack):
1667         * Drosera/win/Drosera.cpp: Hook up the menu controls.
1668         (droseraWndProc):
1669         (handleCommand):
1670         (Drosera::resume):
1671         (Drosera::pause):
1672         (Drosera::stepInto):
1673         (Drosera::stepOver):
1674         (Drosera::stepOut):
1675         (Drosera::showConsole):
1676         (Drosera::closeCurrentFile):
1677         * Drosera/win/Drosera.h: Hook up the menu controls.
1678         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
1679         functions, added a null check, and fixed another bug where caller could
1680         be in a bad state when asked to assign into it.
1681         (ServerConnection::didLoadMainResourceForDataSource):
1682         (ServerConnection::getCallerFrame):
1683         * Drosera/win/ServerConnection.h: Safety first.
1684
1685 2007-11-13  Dan Bernstein  <mitz@apple.com>
1686
1687         Reviewed by Darin Adler.
1688
1689         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
1690           DumpRenderTree --pixel-tests renders each test twice
1691
1692         * DumpRenderTree/mac/DumpRenderTree.mm:
1693         (dumpRenderTree): Removed the --paint option because the painting code
1694         is always exercised as a result of
1695         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
1696         calling -displayIfNeeded.
1697         (dump): Changed to always grab the image from the window since the view
1698         is always displayed.
1699         (runTest):
1700         (displayWebView):
1701         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
1702         because it always paints.
1703
1704 2007-11-12  Antti Koivisto  <antti@apple.com>
1705
1706         Reviewed by Adele.
1707
1708         Add support for http media tests
1709
1710         * Scripts/run-webkit-tests:
1711
1712 2007-11-12  Sam Weinig  <sam@webkit.org>
1713
1714         Reviewed by Adam Roben.
1715
1716         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
1717
1718         * DumpRenderTree/win/DumpRenderTree.cpp:
1719         (runTest):
1720         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1721         (LayoutTestController::setPrivateBrowsingEnabled):
1722
1723 2007-11-12  Adam Roben  <aroben@apple.com>
1724
1725         * Scripts/update-webkit-localizable-strings: Changed to only scan the
1726         mac and win subdirectories.
1727
1728 2007-11-11  Adam Roben  <aroben@apple.com>
1729
1730         Fix <rdar://5133816> keepWebHistory is not implemented
1731
1732         Fixes fast/history/clicked-link-is-visited.html.
1733
1734         Reviewed by Darin.
1735
1736         * DumpRenderTree/win/DumpRenderTree.cpp:
1737         (runTest): Clear the optionalSharedHistory.
1738         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1739         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
1740
1741 2007-11-10  Sam Weinig  <sam@webkit.org>
1742
1743         Reviewed by Tim Hatcher.
1744
1745         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript
1746         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions
1747         is turned on)
1748
1749         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
1750
1751         Added test: http/tests/security/cross-frame-access-private-browsing.html
1752
1753         * DumpRenderTree/LayoutTestController.cpp:
1754         (setPrivateBrowsingEnabledCallback):
1755         (LayoutTestController::staticFunctions):
1756         * DumpRenderTree/LayoutTestController.h:
1757         * DumpRenderTree/mac/DumpRenderTree.mm:
1758         (runTest): Default to private browsing disabled.
1759         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1760         (LayoutTestController::setPrivateBrowsingEnabled):
1761         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1762         (LayoutTestController::setPrivateBrowsingEnabled):
1763
1764 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1765
1766         Reviewed by Adam.
1767
1768         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
1769         WebCore's!
1770
1771         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
1772         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
1773         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
1774         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
1775         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
1776         * Drosera/win/Drosera.cpp:
1777         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1778
1779 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1780
1781         Reviewed by Sam.
1782
1783         - Use the new IWebFrame [local] function signature and get the shared
1784         server correctly.
1785
1786         * Drosera/win/DebuggerClient.cpp:
1787         (DebuggerClient::didFinishLoadForFrame):
1788         * Drosera/win/ServerConnection.cpp:
1789         (ServerConnection::attemptToCreateServerConnection):
1790
1791 2007-11-07  Dan Bernstein  <mitz@apple.com>
1792
1793         Reviewed by Darin Adler.
1794
1795         - add an option to run-webkit-tests to ignore pixel test failures where
1796           all pixels differ by no more than a specified threshold
1797
1798         * DumpRenderTree/mac/ImageDiff.m:
1799         (main):
1800         (compareImages):
1801         (computePercentageDifferent):
1802         * Scripts/run-webkit-tests:
1803
1804 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1805
1806         Reviewed by Lars.
1807
1808         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
1809
1810         * DumpRenderTree/qt/DumpRenderTree.cpp:
1811
1812 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1813
1814         Reviewed by Lars.
1815
1816         Reworked the QWebSettings API.
1817         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
1818
1819         * DumpRenderTree/qt/DumpRenderTree.cpp:
1820
1821 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1822
1823         Reviewed by Lars.
1824
1825         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
1826
1827         * DumpRenderTree/qt/jsobjects.cpp:
1828
1829 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1830
1831         Reviewed by Lars Knoll <lars@trolltech.com>.
1832
1833         Add a QWebPage::frameCreated() signal and fix DRT
1834
1835         The removal of createFrame in QWebPage broke the re-implementation
1836         in DumpRenderTree. Instead emit a frameCreated() signal and
1837         connect to it in DumpRenderTree.
1838
1839
1840         * DumpRenderTree/qt/DumpRenderTree.cpp:
1841         (WebCore::WebPage::WebPage):
1842         (WebCore::DumpRenderTree::dump):
1843         (WebCore::DumpRenderTree::connectFrame):
1844         * DumpRenderTree/qt/DumpRenderTree.h:
1845
1846 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1847
1848         Reviewed by Lars Knoll <lars@trolltech.com>.
1849
1850         Moved all the event handlers from QWebFrame into QWebPage.
1851
1852         This cleans up the public API and allows us to remove the
1853         HackWebFrame hack in DumpRenderTree.
1854
1855
1856         * DumpRenderTree/qt/jsobjects.cpp:
1857         (EventSender::mouseDown):
1858         (EventSender::mouseUp):
1859         (EventSender::mouseMoveTo):
1860
1861 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1862
1863         Reviewed by Mark.
1864
1865         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
1866         to prevent the default implementation from popping up messageboxes.
1867
1868         * DumpRenderTree/qt/DumpRenderTree.cpp:
1869         (WebCore::WebPage::javaScriptConfirm):
1870         (WebCore::WebPage::javaScriptPrompt):
1871
1872 2007-11-06  Eric Seidel  <eric@webkit.org>
1873
1874         * Scripts/build-testkjs: build fix... too many $$
1875
1876 2007-11-06  Eric Seidel  <eric@webkit.org>
1877
1878         Reviewed by Mark Rowe.
1879
1880         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
1881
1882 2007-11-05  Adam Roben  <aroben@apple.com>
1883
1884         Add support on Windows for WEBKIT_TESTFONTS
1885
1886         This environment variable lets you specify where the fonts to be used
1887         by DumpRenderTree reside. The Qt port is already using this, so I'm
1888         just following their lead.
1889
1890         Reviewed by Darin.
1891
1892         * DumpRenderTree/win/DumpRenderTree.cpp:
1893         (exePath): Refactored code out of initialize().
1894         (fontsPath): Returns either $WEBKIT_TESTFONTS or
1895         DumpRenderTree.resources.
1896         (initialize): Use the new fontsPath function.
1897         (main): Use the new exePath function.
1898         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
1899         variable to DRT, like Qt does.
1900
1901 2007-11-05  Mark Rowe  <mrowe@apple.com>
1902
1903         Rubber-stamped by Alp Toker.
1904
1905         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
1906
1907         * GtkLauncher/main.cpp:
1908         (goToURLBarText):
1909         (main):
1910
1911 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
1912
1913         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
1914         <http://bugs.webkit.org/show_bug.cgi?id=15830>
1915
1916         Reviewed by Timothy.
1917
1918         Restrict the range of nightly builds used by the bisect-builds script
1919         based on the version of Safari and the version of Mac OS X being used.
1920
1921         Mac OS X 10.4: Safari 2.0: r11976 or newer
1922         Mac OS X 10.4: Safari 3.0: r19992 or newer
1923
1924         Mac OS X 10.5: Safari 2.0: r19594 or newer
1925         Mac OS X 10.5: Safari 3.0: r25124 or newer
1926
1927         * Scripts/bisect-builds:
1928         (findMacOSXVersion): Added.
1929         (makeNightlyList): Added argument to provide version of Mac OS X.
1930         Restrict range of nightly builds based on Safari and Mac OS X versions.
1931
1932 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
1933
1934         Reviewed by Maciej.
1935
1936         - This patch involves several changes, all of them were noticed that
1937         they were needed by the work being done in WebKit to get Drosera and
1938         WebKit working together on Windows.
1939         - The changes are:
1940         1) Added a debugger console for output messages.
1941         2) Drosera now listens for the WebKit server (before, the server would
1942         have to be running before Drosera was started.)
1943         3) Fixed a bug where the WebView started out as 0x0 pixels.
1944         4) Fixed a bug when there is no scope.
1945         5) Added the HTML, JS, and CSS to the project file to make them easy to
1946         find.
1947         6) Made the ServerConnection functions virtual.
1948
1949         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
1950         for the WebKit server.
1951         (DebuggerClient::DebuggerClient):
1952         (DebuggerClient::~DebuggerClient):
1953         (DebuggerClient::didFinishLoadForFrame):
1954         (DebuggerClient::serverConnected):
1955         (DebuggerClient::attemptToCreateServerConnection):
1956         * Drosera/win/DebuggerClient.h: Ditto.
1957         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
1958         scope.
1959         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1960         (DebuggerDocument::platformValueForScopeVariableNamed):
1961         * Drosera/win/Drosera.cpp:
1962         (_tWinMain): Added a console in debug for output messages.
1963         (Drosera::Drosera): Listen for server.
1964         (Drosera::initUI): The server now Initializes COM.
1965         (Drosera::serverConnected): Part of the listening for the server.
1966         (Drosera::attemptToCreateServerConnection): Ditto.
1967         * Drosera/win/Drosera.h: New interface for listening for the server.
1968         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
1969         files to the VS project.
1970         * Drosera/win/ServerConnection.cpp: Part of listening for the server
1971         connection.
1972         (ServerConnection::ServerConnection):
1973         (ServerConnection::attemptToCreateServerConnection):
1974         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
1975         methods.
1976         (ServerConnection::serverConnected):
1977
1978 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
1979
1980         Reviewed by Maciej.
1981
1982         http://bugs.webkit.org/show_bug.cgi?id=15832
1983         fast/dom/gc-10.html crashes when run alone
1984
1985         Check for !done before using objects that can be already deallocated.
1986
1987         * DumpRenderTree/mac/EditingDelegate.mm:
1988         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
1989         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
1990         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
1991         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
1992         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
1993         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
1994         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
1995         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
1996         (-[EditingDelegate webViewDidBeginEditing:]):
1997         (-[EditingDelegate webViewDidChange:]):
1998         (-[EditingDelegate webViewDidEndEditing:]):
1999         (-[EditingDelegate webViewDidChangeTypingStyle:]):
2000         (-[EditingDelegate webViewDidChangeSelection:]):
2001         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2002         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2003         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2004         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2005         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
2006         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
2007         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
2008         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2009         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
2010         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
2011         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2012         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
2013         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
2014         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
2015         (-[FrameLoadDelegate webView:willCloseFrame:]):
2016         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
2017         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
2018         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2019         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2020         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2021         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
2022         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
2023         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
2024         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
2025
2026 2007-11-04  Mark Rowe  <mrowe@apple.com>
2027
2028         Build fix.  Don't use Carbon.h as the prefix header as it triggers
2029         warnings that would otherwise be suppressed due to it being a system header.
2030
2031         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2032
2033 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
2034
2035         Rubber stamped by Adam.
2036
2037         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
2038
2039         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2040
2041 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2042
2043         Sort files(...); sections of Xcode project files.
2044
2045         Rubber-stamped by Darin.
2046
2047         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
2048         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2049         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2050         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2051
2052 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2053
2054         Script to sort "files(...);" sections in Xcode project.pbxproj files.
2055
2056         Reviewed by Darin.
2057
2058         * Scripts/sort-Xcode-project-file: Added.
2059
2060 2007-11-02  Darin Adler  <darin@apple.com>
2061
2062         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
2063
2064 2007-11-02  Darin Adler  <darin@apple.com>
2065
2066         Reviewed by Maciej.
2067
2068         * Scripts/run-sunspider: Pass the "--base" option through.
2069
2070         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
2071         the real script do that. Default configuration to Release to match run-sunspider
2072         so we don't end up building Debug just to compare results.
2073
2074 2007-11-01  Adam Roben  <aroben@apple.com>
2075
2076         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
2077
2078         Reviewed by Sam.
2079
2080         * Scripts/commit-log-editor: Show all the directories beneath the
2081         source root, instead of just the last one.
2082
2083 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
2084
2085         Reviewed by Adam Roben.
2086
2087         Print out an error message when the Windows build fails
2088         and provide guidance on how to find out what went wrong.
2089
2090         * Scripts/build-webkit:
2091         * Scripts/webkitdirs.pm:
2092
2093 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
2094
2095         Rubber-stamped by Adam Roben.
2096
2097         Rolled out r27326 - debug CRT seems to cause no problems after all.
2098
2099         * DumpRenderTree/win/DumpRenderTree.vcproj:
2100
2101 2007-10-31  Adam Roben  <aroben@apple.com>
2102
2103         Switch the Debug configuration to using the non-debug CRT
2104
2105         This matches WebKit.
2106
2107         Reviewed by Steve.
2108
2109         * DumpRenderTree/win/DumpRenderTree.vcproj:
2110
2111 2007-10-31  Antti Koivisto  <antti@apple.com>
2112
2113         Reviewed by bdash.
2114
2115         Disable media tests when doing leak checking on Tiger.
2116         They crash in QuickTime (rdar://problem/5537157).
2117
2118         * Scripts/run-webkit-tests:
2119
2120 2007-10-29  Antti Koivisto  <antti@apple.com>
2121
2122         Reviewed by Maciej.
2123
2124         Build media support by default on OSX only.
2125
2126         * Scripts/build-webkit:
2127
2128 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2129
2130         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
2131         get caught by the pre-commit hooks.
2132
2133 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2134
2135         Reviewed by Adam.
2136
2137         - This is a collection of relatively unrelated changes and cleanups
2138         to Drosera to prepare it for interacting with WebKit.  A lot of these
2139         changes are just correcting mistakes, for example removing included
2140         headers that are no longer needed.
2141
2142         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
2143         this will be needed by the DebuggerClient.
2144         (DebuggerDocument::server):
2145         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
2146         * Drosera/win/DebuggerClient.cpp:
2147         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
2148         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
2149         (DebuggerClient::createWebViewWithRequest): Added comment about its
2150         purpose.
2151         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
2152         declarations.
2153         (DebuggerClient::webViewLoaded): Moved.
2154         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
2155         file, since this was the only place it was used.
2156         (cfStringToBSTR):
2157         * Drosera/win/Drosera.h: Cleaned up the includes.
2158         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
2159         * Drosera/win/HelperFunctions.h: Removed.
2160
2161 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2162
2163         Reviewed by Adam.
2164
2165         - Small cleanup in the ServerConnection class.
2166
2167         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
2168         and added an include.
2169         (ServerConnection::currentFrame):
2170         (ServerConnection::getCallerFrame):
2171         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
2172         made a pointer into a COMPtr, and cleaned up the includes.
2173
2174 2007-10-29  Timothy Hatcher  <timothy@apple.com>
2175
2176         Reviewed by John Sullivan.
2177
2178         - Place the Localizable.strings file in mac or win directories
2179           if that location exists.
2180         - Also look for UI_STRING in .c files.
2181
2182         * Scripts/extract-localizable-strings:
2183
2184 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2185
2186         Reviewed by Adam.
2187
2188         - Set the eol-style to native and made all the line endings the same
2189         so that I avoid messy diffs that show eol changes.
2190
2191         * Drosera/win/ServerConnection.cpp:
2192         (ServerConnection::didParseSource):
2193         (ServerConnection::didEnterCallFrame):
2194         (ServerConnection::willExecuteStatement):
2195         (ServerConnection::willLeaveCallFrame):
2196         (ServerConnection::exceptionWasRaised):
2197
2198 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2199
2200         Reviewed by Adam.
2201
2202         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
2203         functionality that could not have existed previously without the new
2204         interfaces.
2205         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
2206         from a BSTR to a JSValueRef.
2207         (DebuggerDocument::platformEvaluateScript): Implemented.
2208         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
2209         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2210         Implemented.
2211         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
2212         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
2213         * Drosera/win/ServerConnection.cpp: Added a helper function.
2214         (ServerConnection::getCallerFrame):
2215         * Drosera/win/ServerConnection.h: Added a helper function.
2216
2217 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
2218
2219         updated reviewers for my previous changelog.
2220
2221 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
2222         Reviewed by Maciej and Adam and Geoff.
2223
2224         - Minor mac-side improvements including moving a function to a more
2225         appropriate location, fixing a warning, and correctly checking
2226         exceptions.
2227
2228         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
2229         (DebuggerDocument::willExecuteStatement):
2230         (DebuggerDocument::didEnterCallFrame):
2231         (DebuggerDocument::willLeaveCallFrame):
2232         (DebuggerDocument::windowScriptObjectAvailable):
2233         (DebuggerDocument::callFunctionOnObject):
2234         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
2235         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
2236         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
2237         because it doesn't require the ServerConnection at all.
2238         (NSStringCreateWithJSStringRef): Made an argument const.
2239         (JSValueRefCreateWithNSString): Made an argument const.
2240         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
2241         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2242         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
2243         * Drosera/mac/ServerConnection.mm: Ditto.
2244         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
2245
2246 2007-10-29  Sam Weinig  <sam@webkit.org>
2247
2248         Reviewed by Adam Roben.
2249
2250         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
2251
2252         * DumpRenderTree/LayoutTestController.cpp:
2253         (LayoutTestController::LayoutTestController):
2254         (getGlobalFlagCallback):
2255         (setGlobalFlagCallback):
2256         (LayoutTestController::getJSClass):
2257         (LayoutTestController::staticValues):
2258         * DumpRenderTree/LayoutTestController.h:
2259         (LayoutTestController::globalFlag):
2260         (LayoutTestController::setGlobalFlag):
2261
2262 2007-10-29  Darin Adler  <darin@apple.com>
2263
2264         Reviewed by Maciej.
2265
2266         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
2267         resolution instead of its default.
2268
2269 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
2270
2271         Fixed showStatus() to print status for successfully resolved conflicts when using git.
2272
2273         Reviewed by Mark Rowe.
2274
2275         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
2276         was successfully resolved, but this would not show any status because the change had
2277         already been cached in the index using "git add".  The solution is to add an optional
2278         second argument to showStatus() which adds the "--cached" switch to the command.
2279
2280         * Scripts/resolve-ChangeLogs:
2281         (showStatus):
2282
2283 2007-10-28  Eric Seidel  <eric@webkit.org>
2284
2285         Reviewed by Maciej and Geoff, in unison.
2286
2287         * Scripts/run-webkit-tests: remove broken --svg option
2288
2289 2007-10-28  Darin Adler  <darin@apple.com>
2290
2291         Reviewed by Adam.
2292
2293         * Scripts/run-sunspider: Default to "Release" configuration rather than
2294         defaulting to the last configuration used as other scripts do. This can
2295         still be overriden on the command line with "--debug" if there's some
2296         reason to do so. Also fix a typo.
2297
2298         * Scripts/sunspider-compare-results: Fix a typo.
2299
2300 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
2301
2302         Reviewed by Adam.
2303
2304         - Implemented the WebScriptDebugListener functions now that the
2305         WebScriptDebugServer exists
2306
2307         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
2308         functions.
2309         (ServerConnection::currentFrame):
2310         (ServerConnection::didLoadMainResourceForDataSource):
2311         (ServerConnection::didParseSource):
2312         (ServerConnection::failedToParseSource):
2313         (ServerConnection::didEnterCallFrame):
2314         (ServerConnection::willExecuteStatement):
2315         (ServerConnection::willLeaveCallFrame):
2316         (ServerConnection::exceptionWasRaised):
2317         * Drosera/win/ServerConnection.h: Removed unused arguments from the
2318         members arguments list.
2319
2320 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
2321
2322         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
2323         <http://bugs.webkit.org/show_bug.cgi?id=15600>
2324
2325         Reviewed by Darin.
2326
2327         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
2328         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
2329         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
2330         file.  Note that it may also be used as a stand-alone script.
2331
2332         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
2333         * Scripts/resolve-ChangeLogs: Added.
2334         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
2335
2336 2007-10-26  Mark Rowe  <mrowe@apple.com>
2337
2338         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
2339         to the Qt port on the assumption that it was an implementation of the cross-platform
2340         LayoutTestController class.  It is not, so it did not need to be changed.
2341
2342         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
2343
2344 2007-10-25  Mark Rowe  <mrowe@apple.com>
2345
2346         Reviewed by Maciej.
2347
2348         Fix builds with code coverage enabled.
2349
2350         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
2351
2352 2007-10-25  Darin Adler  <darin@apple.com>
2353
2354         Reviewed by Mark Rowe.
2355
2356         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
2357         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
2358
2359 2007-10-25  Stephanie  <slewis@apple.com>
2360
2361         build Fix
2362
2363         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2364
2365 2007-10-25  Stephanie  <slewis@apple.com>
2366
2367         Reviewed by Mark Rowe, Adam Roben.
2368
2369         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
2370
2371         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2372
2373 2007-10-25  Alice Liu  <alice.liu@apple.com>
2374
2375         Reviewed by Adam.
2376
2377         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
2378
2379         Moving destructor into platform-specific files
2380         * DumpRenderTree/LayoutTestController.cpp:
2381         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2382         (LayoutTestController::~LayoutTestController):
2383         * DumpRenderTree/qt/jsobjects.cpp:
2384         (LayoutTestController::~LayoutTestController):
2385
2386         LayoutTestController wasn't being destroyed
2387         * DumpRenderTree/win/DumpRenderTree.cpp:
2388         (runTest):
2389
2390         Added declspec
2391         * DumpRenderTree/win/EditingDelegate.h:
2392
2393         Reset certain values on the webview (or related delegate) that might
2394         have changed while running a test
2395         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2396         (LayoutTestController::~LayoutTestController):
2397
2398 2007-10-25  Adam Roben  <aroben@apple.com>
2399
2400         Make sunspider-compare-results work with relative paths
2401
2402         Reviewed by Sam.
2403
2404         * Scripts/sunspider-compare-results: Convert arguments to absolute
2405         paths before we chdir.
2406
2407 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
2408
2409         Reviewed by Sam.
2410
2411         - Implemented server calls now the WebScriptDebugServer exists.
2412         - Also removed no longer needed call to initialize CG.
2413
2414         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
2415         automatically now.
2416         (_tWinMain):
2417         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
2418         (ServerConnection::ServerConnection):
2419         (ServerConnection::~ServerConnection):
2420         (ServerConnection::pause):
2421         (ServerConnection::resume):
2422         (ServerConnection::stepInto):
2423         (ServerConnection::applicationTerminating):
2424         (ServerConnection::serverConnectionDidDie):
2425         * Drosera/win/ServerConnection.h: Now uses the COM class.
2426
2427 2007-10-24  George Staikos  <staikos@kde.org>
2428
2429         Unbreak Qt build.
2430
2431         * Scripts/build-webkit:
2432
2433 2007-10-24  Adam Roben  <aroben@apple.com>
2434
2435         Remove now-unnecessary call to InitializeCoreGraphics
2436
2437         WebKit takes care of this now.
2438
2439         Reviewed by Ada.
2440
2441         * DumpRenderTree/win/DumpRenderTree.cpp:
2442         (initialize):
2443
2444 2007-10-24  Adam Roben  <aroben@apple.com>
2445
2446         Use WebTextRenderer in DRT
2447
2448         Reviewed by Ada.
2449
2450         * DumpRenderTree/win/DumpRenderTree.cpp:
2451         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
2452
2453 2007-10-24  Sven Herzberg  <sven@imendio.com>
2454
2455         Reviewed by Mark Rowe.
2456
2457         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
2458         Bug 15614: [GTK] qmake based backends don't build on OS X
2459
2460         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
2461         GTK backend on a Mac
2462         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
2463         isDarwin() to make it reusable in other places (like the workaround-
2464         for-prebuilt-qmake in build-webkit)
2465
2466 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2467
2468         Refurbish update-webkit script.
2469
2470         Reviewed by Adam.
2471
2472         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
2473         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
2474         multi-argument version of system() for flexibility and security.  Check for existence
2475         of Internal directory using -d test instead of -x.
2476
2477 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2478
2479         Minor clean-up of prepare-ChangeLog script.
2480
2481         Reviewed by Adam.
2482
2483         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
2484         of a string.  Use multi-argument versions of open() and system() for flexibility and
2485         security.
2486
2487 2007-10-24  Alice Liu  <alice.liu@apple.com>
2488
2489         Reviewed by Oliver.
2490
2491         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
2492
2493         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to
2494         replay the saved events when we're still processing the mousedown that starts the drag
2495         * DumpRenderTree/win/EventSender.cpp:
2496         (doMouseMove):
2497         * DumpRenderTree/win/UIDelegate.cpp:
2498         (UIDelegate::doDragDrop):
2499
2500 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
2501
2502         Reviewed by Sam, Steve and Darin.
2503
2504         - Stubbed out the WebScriptDebugListener functionality in the Server
2505         Connection class to prepare it for receiving those callbacks.
2506         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
2507         and the ServerConnection to not need to be initialized with a server
2508         name, since that is not the way we connect to the WebKit server.
2509
2510         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
2511         no exception.  Now it only loggs when there is an exception
2512         (DebuggerDocument::willExecuteStatement):
2513         (DebuggerDocument::didEnterCallFrame):
2514         (DebuggerDocument::willLeaveCallFrame):
2515         (DebuggerDocument::windowScriptObjectAvailable):
2516         (DebuggerDocument::callFunctionOnObject):
2517         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
2518         to be instantiated with a server's name.
2519         (DebuggerClient::DebuggerClient):
2520         (DebuggerClient::didFinishLoadForFrame):
2521         * Drosera/win/DebuggerClient.h: Removed unsued variable.
2522         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
2523         a server name.
2524         (Drosera::init):
2525         (Drosera::initServer):
2526         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
2527         instantiated with a server's name.
2528         * Drosera/win/ServerConnection.cpp:
2529         (ServerConnection::ServerConnection): No longer needs a server name
2530         (ServerConnection::~ServerConnection): Only release the global context
2531         if there is one.
2532         (ServerConnection::serverConnectionDidDie): Stub for
2533         IWebScriptDebugListener
2534         (ServerConnection::QueryInterface): ditto
2535         (ServerConnection::AddRef): ditto
2536         (ServerConnection::Release): ditto
2537         (ServerConnection::didLoadMainResourceForDataSource): ditto
2538         (ServerConnection::didParseSource): ditto
2539         (ServerConnection::failedToParseSource): ditto
2540         (ServerConnection::didEnterCallFrame): ditto
2541         (ServerConnection::willExecuteStatement): ditto
2542         (ServerConnection::willLeaveCallFrame): ditto
2543         (ServerConnection::exceptionWasRaised): ditto
2544         * Drosera/win/ServerConnection.h: Stubbed out the
2545         IWebScriptDebugListener functions, and this class no longer needs to be
2546         instantiated with a server name.
2547
2548 2007-10-24  Lars Knoll  <lars@trolltech.com>
2549
2550         Reviewed by Simon.
2551
2552         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
2553
2554         * DumpRenderTree/qt/jsobjects.h:
2555
2556 2007-10-24  Lars Knoll  <lars@trolltech.com>
2557
2558         Reviewed by Simon.
2559
2560         add another command.
2561
2562         * DumpRenderTree/qt/jsobjects.cpp:
2563         (TextInputController::doCommand):
2564
2565 2007-10-24  Lars Knoll  <lars@trolltech.com>
2566
2567         Reviewed by Simon.
2568
2569         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
2570
2571         * DumpRenderTree/qt/jsobjects.cpp:
2572         (EventSender::keyDown):
2573         * DumpRenderTree/qt/jsobjects.h:
2574
2575 2007-10-24  Lars Knoll  <lars@trolltech.com>
2576
2577         Reviewed by Simon.
2578
2579         implement eventSender.keyDown().
2580
2581         * DumpRenderTree/qt/jsobjects.cpp:
2582         (EventSender::keyDown):
2583
2584 2007-10-24  Lars Knoll  <lars@trolltech.com>
2585
2586         Reviewed by Simon.
2587
2588         some smaller fixes to the editing support in DRT. Makes another few tests pass.
2589
2590         * DumpRenderTree/qt/DumpRenderTree.cpp:
2591         (WebCore::DumpRenderTree::DumpRenderTree):
2592         (WebCore::DumpRenderTree::initJSObjects):
2593         * DumpRenderTree/qt/jsobjects.cpp:
2594         (TextInputController::doCommand):
2595
2596 2007-10-24  Lars Knoll  <lars@trolltech.com>
2597
2598         Reviewed by Simon.
2599
2600         first bit of implementation for the textinputcontroller.
2601
2602         * DumpRenderTree/qt/DumpRenderTree.cpp:
2603         (WebCore::DumpRenderTree::DumpRenderTree):
2604         * DumpRenderTree/qt/DumpRenderTree.h:
2605         * DumpRenderTree/qt/jsobjects.cpp:
2606         (TextInputController::TextInputController):
2607         (TextInputController::doCommand):
2608         * DumpRenderTree/qt/jsobjects.h:
2609
2610 2007-10-24  Lars Knoll  <lars@trolltech.com>
2611
2612         Reviewed by Simon.
2613
2614         make the man webpage believe it has focus, so the editing tests work correctly.
2615
2616         * DumpRenderTree/qt/DumpRenderTree.cpp:
2617         (WebCore::DumpRenderTree::DumpRenderTree):
2618
2619 2007-10-24  Lars Knoll  <lars@trolltech.com>
2620
2621         Reviewed by Simon.
2622
2623         implement layoutTestController.dumpEditingCallbacks() correctly.
2624
2625         * DumpRenderTree/qt/DumpRenderTree.cpp:
2626         (WebCore::DumpRenderTree::DumpRenderTree):
2627         * DumpRenderTree/qt/jsobjects.cpp:
2628         (LayoutTestController::reset):
2629         (LayoutTestController::dumpEditingCallbacks):
2630
2631 2007-10-24  Lars Knoll  <lars@trolltech.com>
2632
2633         Reviewed by Simon.
2634
2635         Implement support for testing editing.
2636
2637         * DumpRenderTree/qt/DumpRenderTree.cpp:
2638         (WebCore::DumpRenderTree::DumpRenderTree):
2639
2640 2007-10-23  Sam Weinig  <sam@webkit.org>
2641
2642         Check for null BSTR that can be passed to the UIDelegate methods
2643         from javascript null and undefined.  Fixes a failing test case on
2644         Windows (fast/dom/Window/alert-undefined.html)
2645
2646         Reviewed by Eric Seidel.
2647
2648         * DumpRenderTree/win/UIDelegate.cpp:
2649         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2650         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2651         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2652         (UIDelegate::webViewAddMessageToConsole):
2653
2654 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2655
2656         Reviewed by Darin.
2657
2658         Don't print a massive pile of setenvs from tools that automatically build testkjs.
2659
2660         * Scripts/build-testkjs:
2661
2662 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2663
2664         Reviewed by Darin.
2665
2666         - add wrapper that finds the right copy of testkjs
2667
2668         * Scripts/sunspider-compare-results: Added.
2669
2670 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
2671
2672         Reviewed by Sam.
2673
2674         - After talking with Steve I now see that the WebKit server must be
2675         running for DCOM to create the distributed objects, which makes sense
2676         and currently WebKit only allows one instance to be running at a time
2677         which avoids accidentally connecting to the wrong server
2678         - In light of this I have removed the code for the attach box and
2679         NotificationServer and known server names, since they are all extranious
2680         now.
2681
2682         * Drosera/win/Drosera.cpp: Removed notification classes and known server
2683         names.
2684         (_tWinMain): Uses init instead of initUI.
2685         (droseraWndProc): No longer creats an attach dialog box.
2686         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
2687         it's not manditory to call init before doing COM stuff.
2688         (Drosera::init): calls initUI and will call attach when the
2689         functionality exists.
2690         (Drosera::initUI): Has changed very little.
2691         (Drosera::attach): Changed the signature to reflect that we no longer
2692         need the dictionary of known server names.
2693         * Drosera/win/Drosera.h: Removed notification classes and known server
2694         names.  Also renamed and moved some functions.
2695         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
2696         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
2697         headers to the resources folder.
2698         * Drosera/win/resource.h: Removed the Attach box.
2699
2700 2007-10-22  Adam Roben  <aroben@apple.com>
2701
2702         Windows build fix
2703
2704         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
2705
2706 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
2707
2708         - Removed a leak that was fixed.
2709
2710         * Scripts/run-webkit-tests:
2711
2712 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2713
2714         Reviewed by Darin.
2715
2716         - Changed the Client so that the DebuggerDocument now own the
2717         ServerConnection.  This simplifies ownership and cleanup.
2718
2719         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
2720         ServerConnection.
2721         (DebuggerClient::initWithServerName):
2722         (DebuggerClient::didFinishLoadForFrame):
2723         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the
2724         ServerConnection.
2725         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
2726         until after we have a server which we are attached to.
2727         (Drosera::initUI):
2728         (Drosera::attach):
2729         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
2730         out previously.
2731
2732 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2733
2734         Reviewed by Nikolas.
2735
2736         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
2737
2738         * Scripts/run-javascriptcore-tests:
2739
2740 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2741
2742         Reviewed by Nikolas.
2743
2744         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
2745
2746         * Scripts/build-drosera:
2747         * Scripts/build-dumprendertree:
2748         * Scripts/build-testkjs:
2749         * Scripts/build-webkit:
2750         * Scripts/run-javascriptcore-tests:
2751         * Scripts/run-sunspider:
2752         * Scripts/run-webkit-tests:
2753         * Scripts/webkitdirs.pm:
2754
2755 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
2756
2757         Reviewed by Mark Rowe.
2758
2759         Fix for local database support after r26879
2760         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
2761
2762         * Scripts/build-webkit:
2763
2764 2007-10-22  Holger Freyther  <zecke@selfish.org>
2765
2766         Reviewed by Simon Hausmann <hausmann@kde.org>.
2767
2768         - Do not build testkjs as an application bundle. This is
2769         needed for run-javascriptcore-tests on OSX.
2770         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
2771         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
2772         as we do not have -rpath on OSX.
2773
2774         * DumpRenderTree/qt/DumpRenderTree.pro:
2775         * Scripts/run-webkit-tests:
2776
2777 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2778
2779         Reviewed by aroben.
2780
2781         Fix support for Signed-off-by detection in prepare-ChangeLog
2782         --git-commit. The Signed-off-by tag does not appear in the header
2783         but usually at the end.
2784
2785         * Scripts/prepare-ChangeLog:
2786
2787 2007-10-21  Mark Rowe  <mrowe@apple.com>
2788
2789         Reviewed by Eric.
2790
2791         Fix run-javascriptcore-tests for Gtk.
2792
2793         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
2794
2795 2007-10-20  Eric Seidel  <eric@webkit.org>
2796
2797         Reviewed by aroben.
2798
2799         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
2800
2801 2007-10-20  Eric Seidel  <eric@webkit.org>
2802
2803         Reviewed by darin.
2804
2805         Add improved argument handling to run-sunspider, including
2806         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
2807         Also re-factor code into subroutines
2808
2809         * Scripts/build-dumprendertree: removed bogus comments
2810         * Scripts/build-testkjs: Added.
2811         * Scripts/run-javascriptcore-tests: use build-testkjs
2812         * Scripts/run-sunspider: improved argument handling, abstraction
2813         * Scripts/run-webkit-tests: improved abstraction
2814
2815 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
2816
2817         Not reviewed, Windows build fix.
2818
2819         * DumpRenderTree/win/EventSender.cpp:
2820         (keyDownCallback):
2821
2822 2007-10-20  Darin Adler  <darin@apple.com>
2823
2824         Reviewed by Tim Hatcher.
2825
2826         - http://bugs.webkit.org/show_bug.cgi?id=15544
2827           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
2828           not rely on Apple-specific key codes
2829
2830         * DumpRenderTree/mac/EventSendingController.mm:
2831         (-[EventSendingController keyDown:withModifiers:]):
2832         Added named key "rightArrow". Later we could have a whole table of these.
2833         Also tweaked modifiers code a little.
2834
2835         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
2836
2837 2007-10-19  Darin Adler  <darin@apple.com>
2838
2839         Reviewed by Eric.
2840
2841         - http://bugs.webkit.org/show_bug.cgi?id=15566
2842           possible fix for leak seen in DumpRenderTree
2843
2844         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
2845         Delete the item if it's not put on the queue, since the caller has
2846         no way of knowing that. Would be better to have the parameter type
2847         be auto_ptr to express the fact that we take ownership.
2848
2849         - unrelated change
2850
2851         * Drosera/mac/main.m: Add missing include.
2852
2853 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2854
2855         Reviewed by Adam.
2856
2857         - This change should be identical but for some reason was not working
2858         on my machine.
2859
2860         * Scripts/prepare-ChangeLog:
2861
2862 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2863
2864         Reviewed by Oliver and Tim.
2865
2866         - Made use of RetainPtr to avoid retain and release issues and moved the
2867         log function to DebuggerDocumentPlatform, which seems to be a more
2868         logical place for it to live.
2869         - Also moved knownServers from the ServerConnection to
2870         DebuggerApplication to match the Windows code and because it makes sense
2871         that a connection knows its own server but not all of them.
2872
2873         * Drosera/mac/DebuggerClient.h: Moved the log function to
2874           DebuggerDocumentPlatform.
2875         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
2876           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
2877           call for the server name up from the ServerConnection class.
2878         (-[DebuggerClient dealloc]):
2879         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
2880           for the server name up from the ServerConnection.
2881         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
2882         (DebuggerDocument::platformPause):
2883         (DebuggerDocument::platformResume):
2884         (DebuggerDocument::platformStepInto):
2885         (DebuggerDocument::platformEvaluateScript):
2886         (DebuggerDocument::getPlatformCurrentFunctionStack):
2887         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2888         (DebuggerDocument::platformValueForScopeVariableNamed):
2889         (DebuggerDocument::platformLog): Log directly from here. No need to call
2890           DebuggerClient.
2891         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
2892           way I see it, a ServerConnection should only know about its connection
2893           and the group of all possible servers should be kept by the
2894           application.
2895         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
2896           currentServerName, it makes sense that the connection should know that
2897           name.
2898         (-[ServerConnection currentServerName]):
2899
2900 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2901
2902         Reviewed by Adam.
2903
2904         - Integrated changes from mac drosera.  Recently I've encapsulated
2905         out the server connection object from the rest of Drosera because
2906         it is very platform dependent right now and RPC is not implemented on
2907         windows.  This functionality, of communicating with the WebKit server
2908         is the next area I will be focusing on in Windows.
2909
2910         - Other changes and cleanup were made to organize the code and add notes
2911         on which parts still need work.  Also some mac code is added and
2912         commented out, to act as pseudocode for the logic of those parts.
2913
2914         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
2915           pointer.
2916         * Drosera/config.h: Added whitespace.
2917         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
2918           these files got moved into Drosera.h/cpp
2919         * Drosera/win/DebuggerApplication.h: Removed.
2920         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring
2921           happened here to better match the logic flow of the same code on the
2922           mac side and to use the new ServerConnection class.
2923         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
2924         (DebuggerClient::initWithServerName): Initializer that will set up the
2925           class to use a ServerConnection object.  This was necessary so I could
2926           create a DebuggerClient without having to initilaize it at
2927           construction.
2928         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
2929           will be the UIDelegate and FrameLoadDelegate.
2930         (DebuggerClient::AddRef): For IUnknown.
2931         (DebuggerClient::Release): For IUnknown.
2932         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
2933           this still needs to set the global context of the server, but
2934           IWebFrame does not have an accessor for the global context yet.
2935         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
2936           this is a pass through for the same function in the document.
2937         (DebuggerClient::didReceiveTitle): Unimplemented part of
2938           FrameLoadDelegate this would change the title of the window.
2939         (DebuggerClient::createWebViewWithRequest): Part of the
2940           FrameLoadDelegate.  This is about new windows via Window.open() and
2941           how their delegates are set.
2942         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
2943           UIDelegate.  Just a debug function for printing messages.
2944         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
2945           because the Client should be the UIDelegate and FrameLoadDelegate
2946           to match the delegates on mac.
2947         (DebuggerClient::webViewLoaded): Added accessor method.
2948         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
2949           forgotten to add this file before.  This is where the platform
2950           dependent versions of the Documents functions live. Most of these are
2951           unimplemented because some piece of functionality does not exist on
2952           Windows yet.
2953         (DebuggerDocument::platformPause):
2954         (DebuggerDocument::platformResume):
2955         (DebuggerDocument::platformStepInto):
2956         (DebuggerDocument::platformEvaluateScript):
2957         (DebuggerDocument::getPlatformCurrentFunctionStack):
2958         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2959         (DebuggerDocument::platformValueForScopeVariableNamed):
2960         (DebuggerDocument::platformLog):
2961         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
2962           responsibilities becaue they belong in the Client. Also I laid the
2963           groundwork for attaching Drosera to a WebKit process
2964         (attachWndProc): Now if a server is selected the Client becomes it's
2965           delegate.
2966         (Drosera::Drosera): Added the construction of the Client and dictionary
2967           of server names.
2968         (Drosera::initUI): This is no longer the delegates, the Client is.
2969         (Drosera::webViewLoaded): Now asks the Client instead of holding local
2970           state.
2971         (Drosera::applicationDidFinishLaunching): Placeholder for needed
2972           notification registration when it's possible to implement.
2973         (Drosera::serverLoaded): Ditto
2974         (Drosera::serverUnloaded): Ditto
2975         (Drosera::attach): Attach Drosera to the WebKit server.
2976         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
2977         (Drosera::getInst):
2978         (Drosera::setInst):
2979         (Drosera::knownServers):
2980         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
2981           and added the ServerConnection.
2982         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
2983         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
2984           Most of the functions are completely unimlemented because they cannot
2985           connect with the WebKit server, because one does not exist on Windows
2986           yet.
2987         (ServerConnection::initWithServerName):
2988         (ServerConnection::~ServerConnection):
2989         (ServerConnection::setGlobalContext):
2990         (ServerConnection::pause):
2991         (ServerConnection::resume):
2992         (ServerConnection::stepInto):
2993         (ServerConnection::switchToServerNamed):
2994         (ServerConnection::applicationTerminating):
2995         (ServerConnection::serverConnectionDidDie):
2996         (ServerConnection::currentFrame):
2997         * Drosera/win/ServerConnection.h: Added. Ditto.
2998         (ServerConnection::ServerConnection):
2999
3000 2007-10-19  Alice Liu  <alice.liu@apple.com>
3001
3002         Reviewed by Darin.
3003
3004         Fix for these broken layout tests on Windows:
3005
3006         fast/forms/focus-selection-input.html
3007         fast/forms/focus-selection-textarea.html
3008         fast/forms/select-accesskey.html
3009
3010         * DumpRenderTree/win/EventSender.cpp:
3011         (keyDownCallback):
3012         correct the VK code for alt key.
3013
3014 2007-10-19  Eric Seidel  <eric@webkit.org>
3015
3016         Reviewed by Mark Rowe.
3017
3018         Make the GtkLauncher code slightly more readable.
3019
3020         * GtkLauncher/main.cpp:
3021         (setupMainMenu): Added.
3022         (setupMainWindowUI): Added.
3023         (main):
3024
3025 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
3026
3027         Rubber stamped by Adam.
3028
3029         - don't delay-load WebKit in DumpRenderTree.
3030
3031         * DumpRenderTree/win/DumpRenderTree.vcproj:
3032
3033 2007-10-18  Dan Bernstein  <mitz@apple.com>
3034
3035         Reviewed by Adam Roben.
3036
3037         - fix <rdar://problem/5313523>
3038         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
3039
3040         * DumpRenderTree/mac/DumpRenderTree.mm:
3041         (dump): Changed to use _responseMIMEType.
3042
3043 2007-10-17  Adam Roben  <aroben@apple.com>
3044
3045         Make it possible to have Windows-specific tests and results
3046
3047         When searching for tests to run and the Skipped file, we will only
3048         look in platform/win and the cross-platform directory. When looking
3049         for expected results, we will look in platform/win, then
3050         platform/mac-leopard, then platform/mac, then finally the
3051         cross-platform directory.
3052
3053         Reviewed by Sam.
3054
3055         * Scripts/run-webkit-tests:
3056         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
3057         searching in the cross-platform directory.
3058         (sub buildPlatformHierarchy): Removed some unneeded calls to
3059         dirname/basename.
3060
3061 2007-10-17  Adam Roben  <aroben@apple.com>
3062
3063         Add back the call to register WebKit that we had before WebKitInitializer existed
3064
3065         This is needed to ensure that the right WebKit is used when
3066         instantiating COM objects.
3067
3068         Reviewed by Oliver.
3069
3070         * DumpRenderTree/win/debug_internal.vsprops: Define
3071         DEBUG_WEBKIT_HAS_SUFFIX.
3072         * DumpRenderTree/win/DumpRenderTree.cpp:
3073         (initialize):
3074
3075 2007-10-17  Adam Roben  <aroben@apple.com>
3076
3077         Import File::Basename in webkitdirs since we use it
3078
3079         * Scripts/webkitdirs.pm:
3080
3081 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
3082
3083         - Updated the tiger leaks list to make the internal bots green.
3084
3085         * Scripts/run-webkit-tests:
3086
3087 2007-10-17  Adam Roben  <aroben@apple.com>
3088
3089         Build fix for VC++ Express
3090
3091         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
3092         and ole32.lib.
3093
3094 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
3095
3096         Reviewed by Sam.
3097
3098         - Minor mac improvements based on observations I made while implementing the
3099         Windows code.
3100
3101         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
3102         then hand it to the Client who will retain it, it should just be the client who
3103         creates and owns the server.
3104         (-[DebuggerApplication attach:]):
3105         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
3106         * Drosera/mac/DebuggerClient.mm: Creates the server.
3107         (-[DebuggerClient initWithServerName:]):
3108         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
3109         can instead forward declare what it needs.
3110
3111 2007-10-16  Darin Adler  <darin@apple.com>
3112
3113         Reviewed by Geoff Garen.
3114
3115         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
3116         want to turn failing tests into platform-specific test results. Also did a
3117         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
3118         would take the type of results into account only some of the time.
3119
3120 2007-10-16  Adam Roben  <aroben@apple.com>
3121
3122         Add a new nightly launcher script for Windows
3123
3124         This new script is for versions of Safari that don't delay-load
3125         WebKit. I had to make FindSafari be able to print out the nightly
3126         launcher script on stdout because Windows shell scripts can't capture
3127         the output from a command into an environment variable.
3128
3129         Reviewed by Steve.
3130
3131         * FindSafari/FindSafari.cpp:
3132         (_tmain): Added /printSafariLauncher option.
3133         * Scripts/run-webkit-nightly.cmd: Added.
3134
3135 2007-10-16  Adam Roben  <aroben@apple.com>
3136
3137         Replace WebKitInitializer with FindSafari
3138
3139         We now rely on setting the PATH environment variable to tell Windows
3140         where to find WebKit and its dependencies (similar to
3141         DYLD_FRAMEWORK_PATH on Mac).
3142
3143         This change also make DumpRenderTree no longer delay-load WebKit.
3144
3145         Reviewed by Sam.
3146
3147         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
3148         FindSafari.
3149         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
3150         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
3151         WebKitInitializer, don't delay-load WebKit.
3152         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
3153         * Scripts/run-webkit-tests: Ditto.
3154         * Scripts/webkitdirs.pm:
3155         (sub setPathForRunningWebKitApp): Added.
3156         * WebKitInitializer/WebKitInitializer.cpp: Removed.
3157         * WebKitInitializer/WebKitInitializer.h: Removed.
3158         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
3159         * WebKitInitializer/debug.vsprops: Removed.
3160         * WebKitInitializer/debug_internal.vsprops: Removed.
3161         * WebKitInitializer/release.vsprops: Removed.
3162
3163 2007-10-16  Adam Roben  <aroben@apple.com>
3164
3165         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
3166
3167         http://bugs.webkit.org/show_bug.cgi?id=15532
3168
3169         FindSafari simply prints the location of an installed Safari.exe on
3170         stdout.
3171
3172         Reviewed by Darin.
3173
3174         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
3175         (getStringValue):
3176         (getWebViewCLSID):
3177         (getInstalledWebKitDirectory):
3178         (_tmain):
3179         * FindSafari/FindSafari.vcproj: Added.
3180         * Scripts/webkitdirs.pm:
3181         (sub installedSafariPath): Added. Calls FindSafari on Windows.
3182
3183 2007-10-16  Adam Roben  <aroben@apple.com>
3184
3185         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
3186
3187         Reviewed by Kevin McCullough.
3188
3189         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
3190         when referring to WebKit.dll.
3191         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
3192         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
3193         * DumpRenderTree/win/release.vsprops: Ditto.
3194         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
3195         never have a _debug suffix on WebKit.dll.
3196         * WebKitInitializer/WebKitInitializer.cpp:
3197         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
3198         specified.
3199         * WebKitInitializer/debug_internal.vsprops: Added
3200         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
3201
3202 2007-10-16  Darin Adler  <darin@apple.com>
3203
3204         Reviewed by Adele.
3205
3206         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
3207         Remove now-unneeded control/alt key hack; the tests have been updated.
3208
3209 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
3210
3211         - Updated leaks list because our internal bot upgraded it's version of leopard and
3212         one of the leaks was fixed between that revision and the bot's previous version of
3213         leopard.
3214
3215         * Scripts/run-webkit-tests:
3216
3217 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
3218
3219         Reviewed by Tim.
3220
3221         - I encapsulated out the server connecton functionality because it is a specific part
3222         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
3223         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
3224         Windows.  So the majority of this patch is moving preexisting functionality.
3225
3226         - Also I removed the prefix header and changed to use config.h because it is more
3227         standard on how we use config.h in windows and it didn't make much sense to keep
3228         the prefix header and the config.h
3229
3230         * Drosera/DebuggerDocument.cpp:
3231         (DebuggerDocument::DebuggerDocument):
3232         * Drosera/DebuggerDocument.h:
3233         * Drosera/config.h:
3234         * Drosera/mac/DebuggerApplication.mm:
3235         (-[DebuggerApplication attach:]):
3236         * Drosera/mac/DebuggerClient.h:
3237         * Drosera/mac/DebuggerClient.mm:
3238         (-[DebuggerClient initWithServerConnection:]):
3239         (-[DebuggerClient dealloc]):
3240         (-[DebuggerClient windowDidLoad]):
3241         (-[DebuggerClient windowWillClose:]):
3242         (-[DebuggerClient webView:didFinishLoadForFrame:]):
3243         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
3244         * Drosera/mac/DebuggerDocumentPlatform.mm:
3245         (DebuggerDocument::platformPause):
3246         (DebuggerDocument::platformResume):
3247         (DebuggerDocument::platformStepInto):
3248         (DebuggerDocument::platformEvaluateScript):
3249         (DebuggerDocument::getPlatformCurrentFunctionStack):
3250         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3251         (DebuggerDocument::platformValueForScopeVariableNamed):
3252         (DebuggerDocument::platformLog):
3253         * Drosera/mac/Drosera.pch: Removed.
3254         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3255         * Drosera/mac/ServerConnection.h: Added.
3256         * Drosera/mac/ServerConnection.mm: Added.
3257         (-[ServerConnection initWithServerName:]):
3258         (-[ServerConnection dealloc]):
3259         (-[ServerConnection setGlobalContext:]):
3260         (-[ServerConnection pause]):
3261         (-[ServerConnection resume]):
3262         (-[ServerConnection stepInto]):
3263         (-[ServerConnection switchToServerNamed:]):
3264         (-[ServerConnection applicationTerminating:]):
3265         (-[ServerConnection serverConnectionDidDie:]):
3266         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
3267         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
3268         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
3269         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
3270         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
3271         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
3272         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
3273         (-[ServerConnection currentFrame]):
3274         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
3275         (-[ServerConnection knownServers]):
3276
3277 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
3278
3279         Reviewed by Eric.
3280
3281         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
3282           Script to automatically search nightly builds for regressions (bisect-builds)
3283
3284         * Scripts/bisect-builds: Added.
3285
3286 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
3287
3288         Reviewed by Darin.
3289
3290         - New JavaScript benchmark
3291         http://bugs.webkit.org/show_bug.cgi?id=15515
3292
3293         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
3294         current development or release build of JavaScriptCore.
3295
3296 2007-10-15  Mark Rowe  <mrowe@apple.com>
3297
3298         Reviewed by Sam.
3299
3300         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
3301
3302         * Scripts/webkitdirs.pm:
3303         - Change checkArgv to remove the options from @ARGV to prevent
3304         them from interfering with further option processing.
3305         - Fix logic error in determineIsQt that would prevent it from bailing out early.
3306         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
3307         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
3308         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
3309
3310 2007-10-15  Darin Adler  <darin@apple.com>
3311
3312         Reviewed by Sam.
3313
3314         - added logging of window.prompt and window.confirm
3315
3316         * DumpRenderTree/mac/UIDelegate.mm:
3317         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
3318         Implement the recommended delegate rather than the deprecated one.
3319         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
3320         Added.
3321         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
3322         Added.
3323
3324         * DumpRenderTree/win/UIDelegate.h:
3325         * DumpRenderTree/win/UIDelegate.cpp:
3326         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
3327         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
3328         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
3329         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
3330
3331 2007-10-15  Alice Liu  <alice.liu@apple.com>
3332
3333         Reviewed by Sam Weinig.
3334
3335         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
3336
3337         * DumpRenderTree/win/DumpRenderTree.cpp:
3338         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
3339         (main): allocate the global policy delegate for DRT's custom use
3340         * DumpRenderTree/win/DumpRenderTree.vcproj:
3341         Adding files to project
3342         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
3343         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3344         (LayoutTestController::setCustomPolicyDelegate):
3345         set the webview's policy delegate to DRT's custom one if the test requests it.
3346         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
3347         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
3348         (PolicyDelegate::PolicyDelegate):
3349         (PolicyDelegate::QueryInterface):
3350         (PolicyDelegate::AddRef):
3351         (PolicyDelegate::Release):
3352         (PolicyDelegate::decidePolicyForNavigationAction):
3353         * DumpRenderTree/win/PolicyDelegate.h: Added.
3354         (PolicyDelegate::decidePolicyForNewWindowAction):
3355         (PolicyDelegate::decidePolicyForMIMEType):
3356         (PolicyDelegate::unableToImplementPolicyWithError):
3357
3358 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
3359
3360         Reviewed by Mark.
3361
3362         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
3363         when querying for QMAKE_MKSPECS.
3364
3365 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
3366
3367         Reviewed by Adam Roben.
3368
3369         Fix run-webkit-tests is too greedy calculating platform hierarchy
3370         http://bugs.webkit.org/show_bug.cgi?id=15465
3371
3372         Fix run-webkit-tests being too greedy in trying to split the platform name up
3373         causing it to try and find tests in every directory above the first "-" in the
3374         path to the LayoutTests
3375
3376         * Scripts/run-webkit-tests:
3377
3378 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
3379
3380         Reviewed by Darin.
3381
3382         http://bugs.webkit.org/show_bug.cgi?id=15006
3383         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
3384         to reduce code duplication.
3385
3386         * Scripts/build-webkit:
3387         * Scripts/webkitdirs.pm:
3388         buildQMakeProject() renamed to buildQMakeQtProject().
3389         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
3390         unused $colorize has been removed.
3391
3392 === Start merge of feature-branch 2007-10-12 ===
3393
3394 2007-10-08  Eric Seidel  <eric@webkit.org>
3395
3396         Reviewed by Mark Rowe.
3397
3398         * Scripts/build-webkit: add --help, remove unused --color
3399
3400 2007-10-07  Eric Seidel  <eric@webkit.org>
3401
3402         Reviewed by darin.
3403
3404         * Drosera/mac/DebuggerDocumentPlatform.mm:
3405         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
3406
3407 2007-10-03  Rob Buis  <buis@kde.org>
3408
3409         Reviewed by Olliej.
3410
3411         Adapt to changed location of Ahem font.
3412
3413         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3414
3415 2007-10-02  Eric Seidel  <eric@webkit.org>
3416
3417         Reviewed by Adam Roben.
3418
3419         Make pixel tests more useful!
3420         Finally fix the image diff 0.00% mystery problem
3421         Highlight any image differences in the image diff.
3422         Add a link from image diffs back to original test file.
3423
3424         * DumpRenderTree/mac/ImageDiff.m:
3425         (compareImages): highlight any differences
3426         (computePercentageDifferent): round to two decimal places
3427         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
3428
3429 2007-10-02  Eric Seidel  <eric@webkit.org>
3430
3431         Reviewed by Alexey Proskuryakov.
3432
3433         * Scripts/run-webkit-tests: print the % image difference on main results page
3434
3435 2007-10-02  Mark Rowe  <mrowe@apple.com>
3436
3437         Reviewed by Oliver.
3438
3439         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
3440
3441         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
3442         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
3443
3444 2007-10-01  Mark Rowe  <mrowe@apple.com>
3445
3446         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
3447
3448 2007-09-25  Eric Seidel  <eric@webkit.org>
3449
3450         Reviewed by Mark Rowe.
3451
3452         DerivedSources.make was finding "ENABLE_SVG" in the string
3453         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
3454         quite correctly.
3455
3456         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
3457
3458 2007-09-25  Mark Rowe  <mrowe@apple.com>
3459
3460         Rubber-stamped by Eric.
3461
3462         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
3463         This makes it possible to automate nightly builds for the feature-branch.
3464
3465 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
3466
3467         Rubber stamped by Mark.
3468
3469         Enable svg experimental features as default here in feature-branch.
3470
3471         * Scripts/build-webkit:
3472
3473 2007-06-29  Antti Koivisto  <antti@apple.com>
3474
3475         Reviewed by Weinig.
3476
3477         Add VIDEO flag for timed media features
3478
3479         * Scripts/build-webkit
3480
3481 === End merge of feature-branch 2007-10-12 ===
3482
3483 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
3484
3485         Reviewed by Darin.
3486
3487         - Updated rational for the leaks list to be more clear.
3488
3489         * Scripts/run-webkit-tests:
3490
3491 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
3492
3493         Rubber Stamp by Sam.
3494
3495         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
3496         I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
3497
3498         * Scripts/run-webkit-tests:
3499
3500 2007-10-10  Simon Hausmann  <hausmann@kde.org>
3501
3502         Reviewed by Lars.
3503
3504         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
3505         includes are needed for INT_MAX, std::auto_ptr and the like.
3506
3507         * DumpRenderTree/qt/main.cpp:
3508
3509 2007-10-09  Lars Knoll  <lars@trolltech.com>
3510
3511         Reviewed by Simon.
3512
3513         implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
3514
3515         * DumpRenderTree/qt/jsobjects.cpp:
3516         (LayoutTestController::encodeHostName):
3517         (LayoutTestController::decodeHostName):
3518         * DumpRenderTree/qt/jsobjects.h:
3519
3520 2007-10-09  Lars Knoll  <lars@trolltech.com>
3521
3522         Reviewed by Simon.
3523
3524         Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
3525
3526         * DumpRenderTree/qt/DumpRenderTree.cpp:
3527         (WebCore::WebPage::createFrame):
3528         (WebCore::DumpRenderTree::DumpRenderTree):
3529         (WebCore::DumpRenderTree::titleChanged):
3530         * DumpRenderTree/qt/DumpRenderTree.h:
3531         * DumpRenderTree/qt/jsobjects.cpp:
3532         (LayoutTestController::reset):
3533         * DumpRenderTree/qt/jsobjects.h:
3534
3535 2007-10-09  Lars Knoll  <lars@trolltech.com>
3536
3537         Reviewed by Simon.
3538
3539         add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
3540
3541         * DumpRenderTree/qt/DumpRenderTree.h:
3542         * DumpRenderTree/qt/jsobjects.cpp:
3543         (LayoutTestController::clearBackForwardList):
3544         * DumpRenderTree/qt/jsobjects.h:
3545
3546 2007-10-09  Lars Knoll  <lars@trolltech.com>
3547
3548         Reviewed by Simon.
3549
3550         make --git-reviewer work again.
3551
3552         * Scripts/prepare-ChangeLog:
3553
3554 2007-10-07  Holger Hans Peter Freyther  <zecke@selfish.org>
3555
3556         Rubber stamped by Eric.
3557
3558         Connect to the "hovering-over-link" signal emitted by WebKitPage and
3559         show the current link inside the statusbar.
3560         This shows how to make use of this signal and allows to easily test
3561         http://bugs.webkit.org/show_bug.cgi?id=15299.
3562
3563         * GtkLauncher/main.cpp:
3564         (hoveringOverLink):
3565         (main):
3566
3567 2007-10-05  Lars Knoll  <lars@trolltech.com>
3568
3569         add proper error messages to the FrameLoaderClient.
3570         Implement ChromeClientQt::closeWindowSoon and
3571         FrameLoaderClientQt::dispatchCreatePage (which should go away IMO).
3572         Some fixes in DRT to make it work correctly with multiple windows.
3573
3574         Reviewed by Maciej.
3575
3576         * DumpRenderTree/qt/DumpRenderTree.cpp:
3577         (WebCore::DumpRenderTree::DumpRenderTree):
3578         (WebCore::DumpRenderTree::createWindow):
3579         (WebCore::DumpRenderTree::windowCount):
3580         * DumpRenderTree/qt/DumpRenderTree.h:
3581         * DumpRenderTree/qt/jsobjects.cpp:
3582         (LayoutTestController::maybeDump):
3583         (LayoutTestController::windowCount):
3584         * DumpRenderTree/qt/jsobjects.h:
3585
3586 2007-10-05  Lars Knoll  <lars@trolltech.com>
3587
3588         Add a dummy plugin to DRT  to fix fast/dom/Window/Plug-Ins.html.
3589         Add support for layoutTextController.setCanOpenWindows() to DRT
3590         fixing another 2 test cases in fast/dom/Window.
3591
3592         Reviewed by Maciej.
3593
3594         * DumpRenderTree/qt/DumpRenderTree.cpp:
3595         (WebCore::WebPage::WebPage):
3596         (WebCore::WebPage::createWindow):
3597         (WebCore::DumpRenderTree::resetJSObjects):
3598         (WebCore::DumpRenderTree::createWindow):
3599         * DumpRenderTree/qt/DumpRenderTree.h:
3600         * DumpRenderTree/qt/DumpRenderTree.pro:
3601         * DumpRenderTree/qt/jsobjects.cpp:
3602         (LayoutTestController::LayoutTestController):
3603         (LayoutTestController::reset):
3604         * DumpRenderTree/qt/jsobjects.h:
3605         * DumpRenderTree/qt/main.cpp:
3606         * DumpRenderTree/qt/testplugin.cpp: Added.
3607         * DumpRenderTree/qt/testplugin.h: Added.
3608
3609 2007-10-04  Sam Weinig  <sam@webkit.org>
3610
3611         Rubber stamped by Adam.
3612
3613         Remove empty directories.
3614
3615         * DumpRenderTree/DumpRenderTree.qtproj: Removed.
3616         * DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.
3617
3618 2007-10-03  Darin Adler  <darin@apple.com>
3619
3620         Reviewed by Adam.
3621
3622         * Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if
3623         we find the internal libraries in the libraries directory. This
3624         is helpful for Safari team engineers at Apple.
3625
3626 2007-10-03  Adam Roben  <aroben@apple.com>
3627
3628         Update the location of AHEM___.TTF after r25968
3629
3630         Reviewed by Sam.
3631
3632         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3633
3634 2007-10-03  Alp Toker  <alp@atoker.com>
3635
3636         Reviewed by Adam.
3637
3638         http://bugs.webkit.org/show_bug.cgi?id=14726
3639         [gtk] API design. Mapping the WebView delegates to signals.
3640
3641         Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.
3642
3643         * GtkLauncher/main.cpp:
3644         (goToURLBarText):
3645         (titleChanged):
3646         (progressChanged):
3647         (menuMainBackCallback):
3648         (menuMainForwardCallback):
3649         (main):
3650
3651 2007-10-03  Lars Knoll  <lars@trolltech.com>
3652
3653         Reviewed by Rob.
3654
3655         This fixes --strict mode in run-webkit-tests again after
3656         the platform dependent test results have been moved.
3657
3658         * Scripts/run-webkit-tests:
3659
3660 2007-10-03  Lars Knoll  <lars@trolltech.com>
3661
3662         Reviewed by bdash.
3663
3664         remove the hack in run-webkit-tests that forced text only test
3665         to be taken from the platform independent dir. It was only left
3666         there from early days.
3667
3668         Remove platform dependent results for tests that are text only nowadays,
3669         and add one platform dependent result for a text only test that requires it.
3670
3671         * Scripts/run-webkit-tests:
3672
3673 2007-10-03  Lars Knoll  <lars@trolltech.com>
3674
3675         Reviewed by olliej.
3676
3677         Move the Qt version of DRT into the correct place and put the binary into BUILDDIR/bin.
3678
3679         * DumpRenderTree/qt/DumpRenderTree.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp.
3680         (WebCore::WebFrame::WebFrame):
3681         (WebCore::WebPage::WebPage):
3682         (WebCore::WebPage::createFrame):
3683         (WebCore::WebPage::javaScriptAlert):
3684         (WebCore::WebPage::javaScriptConsoleMessage):
3685         (WebCore::DumpRenderTree::DumpRenderTree):
3686         (WebCore::DumpRenderTree::~DumpRenderTree):
3687         (WebCore::DumpRenderTree::open):
3688         (WebCore::DumpRenderTree::readStdin):
3689         (WebCore::DumpRenderTree::resetJSObjects):
3690         (WebCore::DumpRenderTree::initJSObjects):
3691         (WebCore::DumpRenderTree::dumpFramesAsText):
3692         (WebCore::DumpRenderTree::dump):
3693         * DumpRenderTree/qt/DumpRenderTree.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h.
3694         (WebCore::DumpRenderTree::layoutTestController):
3695         (WebCore::DumpRenderTree::eventSender):
3696         * DumpRenderTree/qt/DumpRenderTree.pro: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro.
3697         * DumpRenderTree/qt/fonts.conf: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts.conf.
3698         * DumpRenderTree/qt/fonts/AHEM____.TTF: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts/AHEM____.TTF.
3699         * DumpRenderTree/qt/jsobjects.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp.
3700         (HackWebFrame::mousePressEvent):
3701         (HackWebFrame::mouseReleaseEvent):
3702         (HackWebFrame::mouseMoveEvent):
3703         (HackWebFrame::HackWebFrame):
3704         (HackWebFrame::~HackWebFrame):
3705         (LayoutTestController::LayoutTestController):
3706         (LayoutTestController::reset):
3707         (LayoutTestController::maybeDump):
3708         (LayoutTestController::waitUntilDone):
3709         (LayoutTestController::notifyDone):
3710         (LayoutTestController::dumpEditingCallbacks):
3711         (LayoutTestController::queueReload):
3712         (LayoutTestController::provisionalLoad):
3713         (LayoutTestController::timerEvent):
3714         (EventSender::EventSender):
3715         (EventSender::mouseDown):
3716         (EventSender::mouseUp):
3717         (EventSender::mouseMoveTo):
3718         (EventSender::leapForward):
3719         (EventSender::keyDown):
3720         (EventSender::frameUnderMouse):
3721         * DumpRenderTree/qt/jsobjects.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h.
3722         (LayoutTestController::isLoading):
3723         (LayoutTestController::setLoading):
3724         (LayoutTestController::shouldDumpAsText):
3725         (LayoutTestController::shouldDumpChildrenAsText):
3726         (LayoutTestController::shouldWaitUntilDone):
3727         (LayoutTestController::dumpAsText):
3728         (LayoutTestController::dumpChildFramesAsText):
3729         * DumpRenderTree/qt/main.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/main.cpp.
3730         (messageHandler):
3731         (crashHandler):
3732         (main):
3733         * Scripts/run-webkit-tests:
3734
3735 2007-10-03  Mark Rowe  <mrowe@apple.com>
3736
3737         Reviewed by Alp Toker.
3738
3739         Fix build-webkit when both QTDIR and --gtk are set.  The presence of --gtk
3740         should take precedence over QTDIR when determining which port we are working with.
3741
3742         * Scripts/webkitdirs.pm:
3743
3744 2007-10-02  Adam Roben  <aroben@apple.com>
3745
3746         Add keychain to the list of default packages to install
3747
3748         Rubberstamped by Sam.
3749
3750         * CygwinDownloader/cygwin-downloader.py:
3751         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
3752
3753 2007-10-02  David Kilzer  <ddkilzer@webkit.org>
3754
3755         Reviewed by Adam.
3756
3757         Make "--git-commit trunk..HEAD" work with prepare-ChangeLog.
3758         Also makes WebCore regression test case logic work when using git.
3759
3760         * Scripts/prepare-ChangeLog:
3761         (reviewerAndDescriptionForGitCommit): Added.
3762
3763 2007-10-02  Lars Knoll  <lars@trolltech.com>
3764
3765         Reviewed by bdash.
3766
3767         Add API to retrieve the frame name from QWebFrame.
3768         Implement support for DRT::dumpChildrenAsText.
3769
3770         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3771         (WebCore::DumpRenderTree::dumpFramesAsText):
3772         (WebCore::DumpRenderTree::dump):
3773         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
3774         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3775         (LayoutTestController::LayoutTestController):
3776         (LayoutTestController::reset):
3777         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
3778
3779 2007-10-02  Lars Knoll  <lars@trolltech.com>
3780
3781         Reviewed by bdash.
3782
3783         Fix the handling of the response header for data urls. Make sure we always pass absolute URLs to WebKit from both DRT and QtLauncher.
3784
3785         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3786         (WebCore::DumpRenderTree::readStdin):
3787
3788 2007-10-02  Mark Rowe  <mrowe@apple.com>
3789
3790         Reviewed by Oliver.
3791
3792         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
3793
3794         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
3795         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
3796
3797 2007-10-02  Mark Rowe  <mrowe@apple.com>
3798
3799         Rubber-stamped by Maciej.
3800
3801         Configuration changes from build.webkit.org.  The major change is refactoring to work
3802         with Buildbot 0.7.6, but it does include other smaller changes that have been made in the
3803         last few weeks.
3804
3805         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3806         * BuildSlaveSupport/build.webkit.org-config/webkit/auth.py:
3807         * BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py:
3808         * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
3809         * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
3810         * BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py:
3811         * BuildSlaveSupport/build.webkit.org-config/webkit/status.py:
3812         * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
3813
3814 2007-10-02  Lars Knoll  <lars@trolltech.com>
3815
3816         Reviewed by Maciej.
3817
3818         Add support for eventSender.mouseMove to DRT.
3819         Fixes fast/css/hover-affects-child.html
3820
3821         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3822         (EventSender::mouseMoveTo):
3823
3824 2007-10-01  Mark Rowe  <mrowe@apple.com>
3825
3826         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
3827
3828 2007-10-01  David Kilzer  <ddkilzer@webkit.org>
3829
3830         Reviewed by Hyatt.
3831
3832         Make svn-apply and svn-unapply work with added files in git-diff formatted patches.
3833
3834         * Scripts/svn-apply:
3835         (gitdiff2svndiff): Ignore lines beginning with "new file".
3836         * Scripts/svn-unapply:
3837         (gitdiff2svndiff): Ditto.
3838
3839 2007-09-30  George Staikos  <staikos@kde.org>
3840
3841         Qt build fix (Mac OS X specific)
3842
3843         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro:
3844
3845 2007-09-29  Holger Hans Peter Freyther  <zecke@selfish.org>
3846
3847         Reviewed by Mark.
3848
3849         -Fix http://bugs.webkit.org/show_bug.cgi?id=13226.
3850         Remove Bakefiles from svn.
3851
3852         * GtkLauncher/Bakefiles.bkgen: Removed.
3853         * GtkLauncher/ENV: Removed.
3854         * GtkLauncher/gdklauncher.bkl: Removed.
3855         * GtkLauncher/mk: Removed.
3856         * Scripts/regenerate-makefiles: Removed.
3857
3858 2007-09-25  Kevin McCullough  <kmccullough@apple.com>
3859
3860         Reviewed by John.
3861
3862         - Updating leopard leak list to refelct bugs that have been fixed and no longer leak.
3863
3864         * Scripts/run-webkit-tests:
3865
3866 2007-09-26  Adam Roben  <aroben@apple.com>
3867
3868         Make not finding an installed WebKit non-fatal
3869
3870         What really matters is that we are able to load WebKit and its
3871         dependencies, not whether we think we've found an installed WebKit.
3872
3873         Reviewed by Sam.
3874
3875         * WebKitInitializer/WebKitInitializer.cpp:
3876         (getWebViewCLSID): Use new LOG_WARNING macro.
3877         (getInstalledWebKitDirectory): Ditto.
3878         (initializeWebKit): Don't die if we didn't find an installed WebKit,
3879         and use new macros.
3880         * WebKitInitializer/WebKitInitializer.vcproj: Disabled a warning.
3881
3882 2007-09-26  Adam Roben  <aroben@apple.com>
3883
3884         Committed this file before saving it
3885
3886         * WebKitInitializer/debug_internal.vsprops:
3887
3888 2007-09-26  Adam Roben  <aroben@apple.com>
3889
3890         Load WebKit and its dependencies manually so they come from DllDirectory
3891
3892         I had to change WebKitInitializer to use malloc/free instead of
3893         new/delete to avoid pulling in WebKit (and its dependencies) early
3894         through use of fastMalloc.
3895
3896         Reviewed by Oliver.
3897
3898         * WebKitInitializer/WebKitInitializer.cpp:
3899         (getStringValue): Changed to use malloc/free.
3900         (getInstalledWebKitDirectory): Ditto.
3901         (initializeWebKit): Call SetDllDirectory first, then load all of
3902         WebKit's dependencies manually, finally followed by WebKit itself.
3903         * WebKitInitializer/WebKitInitializer.vcproj: Added a new
3904         configuration to match our other projects.
3905         * WebKitInitializer/debug_internal.vsprops: Added.
3906
3907 2007-09-25  Adam Roben  <aroben@apple.com>
3908
3909         Actually define DEBUG/NDEBUG so that we load WebKit correctly
3910
3911         Rubberstamped by Sam.
3912
3913         * WebKitInitializer/WebKitInitializer.vcproj:
3914
3915 2007-09-25  Adam Roben  <aroben@apple.com>
3916
3917         Make DumpRenderTree delay-load its dependencies
3918
3919         This lets WebKitInitializer re-route the dependencies to be loaded out
3920         of the Safari installation directory.
3921
3922         Also replaced all uses of kCFAllocatorDefault with 0 (which means the
3923         same thing), since we can't import the kCFAllocatorDefault symbol when
3924         delay-loading CoreFoundation.dll.
3925
3926         Rubberstamped by Sam.
3927
3928         * DumpRenderTree/win/DumpRenderTree.cpp:
3929         (runTest):
3930         (javaScriptThreads):
3931         * DumpRenderTree/win/DumpRenderTree.vcproj:
3932         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3933         (LayoutTestController::setWaitToDump):
3934
3935 2007-09-25  Adam Roben  <aroben@apple.com>
3936
3937         Pull ole32.lib into WebKitInitializer
3938
3939         Rubberstamped by Sam.
3940
3941         * WebKitInitializer/WebKitInitializer.vcproj:
3942
3943 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
3944
3945         Reviewed by Adam.
3946
3947         - Fix http://bugs.webkit.org/show_bug.cgi?id=14885
3948           LGPL'ed files contain incorrect FSF address
3949
3950         * Drosera/config.h:
3951
3952 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
3953
3954         Reviewed by Adam.
3955
3956         Make svn-apply and svn-unapply work with git-diff formatted patches.
3957
3958         * Scripts/svn-apply: Apply a filter to the input if we find a git-diff marker before a patch.
3959         (gitdiff2svndiff): Added.
3960         * Scripts/svn-unapply: Ditto.
3961         (gitdiff2svndiff): Added.
3962
3963 2007-09-25  Adam Roben  <aroben@apple.com>
3964
3965         Pull advapi32.lib into WebKitInitializer
3966
3967         This is needed to get the registry functions we use.
3968
3969         Rubberstamped by Sam.
3970
3971         * WebKitInitializer/WebKitInitializer.vcproj:
3972
3973 2007-09-25  Adam Roben  <aroben@apple.com>
3974
3975         Add python and rsync to cygwin-downloader
3976
3977         Our build slaves need this, and it can't hurt for everyone else to
3978         have it, too.
3979
3980         Reviewed by Sam.
3981
3982         * CygwinDownloader/cygwin-downloader.py: Added python and rsync.
3983         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
3984
3985 2007-09-25  Adam Roben  <aroben@apple.com>
3986
3987         Add WebKitInitializer and use it in DumpRenderTree
3988
3989         WebKitInitializer is a static library that has one function,
3990         initializeWebKit(). This registers WebKit and sets up the DLL search
3991         path so that WebKit's dependencies that are installed with Safari can
3992         be found.
3993
3994         Reviewed by Sam.
3995
3996         * DumpRenderTree/DumpRenderTree.sln: Added WebKitInitializer and made
3997         DumpRenderTree depend on it.
3998         * DumpRenderTree/win/DumpRenderTree.cpp:
3999         (initialize): Call initializeWebKit.
4000         * DumpRenderTree/win/DumpRenderTree.vcproj: Link against
4001         WebKitInitializer.lib.
4002         * WebKitInitializer/WebKitInitializer.cpp: Added.
4003         (getStringValue):
4004         (getWebViewCLSID):
4005         (getInstalledWebKitDirectory):
4006         (initializeWebKit):
4007         * WebKitInitializer/WebKitInitializer.h: Added.
4008         * WebKitInitializer/WebKitInitializer.vcproj: Added.
4009         * WebKitInitializer/debug.vsprops: Added.
4010         * WebKitInitializer/release.vsprops: Added.
4011
4012 2007-09-25  Adam Roben  <aroben@apple.com>
4013
4014         Make run-webkit-tests respect set-webkit-configuration
4015
4016         Reviewed by Sam.
4017
4018         * Scripts/run-webkit-tests: Initialize $configuration to whatever
4019         set-webkit-configuration was last set to.
4020
4021 2007-09-25  Mark Rowe  <mrowe@apple.com>
4022
4023         Rubber-stamped by Eric.
4024
4025         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
4026         This makes it possible to automate nightly builds for the feature-branch.
4027
4028 2007-09-25  Adam Roben  <aroben@apple.com>
4029
4030         A couple of fixes/enhancements to update-webkit-*-libs
4031
4032         You can now specify WEBKITSUPPORTLIBRARIESZIPDIR=C:\my\special\place
4033         to tell update-webkit-support-libraries where it should find the
4034         WebKitSupportLibrary.zip file you downloaded.
4035
4036         These scripts also now correctly interpret WEBKITLIBRARIESDIR as a
4037         Windows-style path.
4038
4039         Reviewed by Sam.
4040
4041         * Scripts/update-webkit-auxiliary-libs: Also renamed $supportLibsURL
4042         to $auxiliaryLibsURL and removed an irrelevant comment.
4043         * Scripts/update-webkit-support-libs:
4044
4045 2007-09-25  Adam Treat  <treat@kde.org>
4046
4047         Reviewed by Simon and Lars.
4048
4049         Refactors and cleans up Qt DRT member variable names, member variable
4050         initialization, style fixes and general code cleanup.
4051
4052         Adds queueReload slot to LayoutTestController that some tests require.
4053
4054         Subclasses QWebFrame to make sure that all frames have an associated
4055         LayoutTestController JS window object.
4056
4057         Takes advantage of new QWebFrame provisionalLoad signal to ensure frames
4058         aren't dumped twice.
4059
4060         EOF fixes.
4061
4062         Together, this patch fixes some 20+ layout tests in QtWebKit.
4063
4064         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
4065         (WebCore::WebFrame::WebFrame):
4066         (WebCore::WebPage::WebPage):
4067         (WebCore::WebPage::createFrame):
4068         (WebCore::DumpRenderTree::DumpRenderTree):
4069         (WebCore::DumpRenderTree::open):
4070         (WebCore::DumpRenderTree::readStdin):
4071         (WebCore::DumpRenderTree::initJSObjects):
4072         (WebCore::DumpRenderTree::dump):
4073         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
4074         (WebCore::DumpRenderTree::layoutTestController):
4075         (WebCore::DumpRenderTree::eventSender):
4076         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
4077         (LayoutTestController::LayoutTestController):
4078         (LayoutTestController::reset):
4079         (LayoutTestController::maybeDump):
4080         (LayoutTestController::waitUntilDone):
4081         (LayoutTestController::notifyDone):
4082         (LayoutTestController::queueReload):
4083         (LayoutTestController::provisionalLoad):
4084         (EventSender::EventSender):
4085         (EventSender::mouseDown):
4086         (EventSender::mouseUp):
4087         (EventSender::mouseMoveTo):
4088         (EventSender::frameUnderMouse):
4089         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
4090         (LayoutTestController::isLoading):
4091         (LayoutTestController::setLoading):
4092         (LayoutTestController::dumpAsText):
4093         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
4094         (main):
4095
4096 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
4097
4098
4099         - Reverted an accidentally checked in file.
4100
4101         * Drosera/win/DebuggerDocumentPlatform.cpp: Removed.
4102
4103 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
4104         Reviewed by Sam.
4105
4106         - Updated project files to not use Edit and Continue for Debug Information since it doesn't work and breaks some functionality.
4107
4108         * DumpRenderTree/win/DumpRenderTree.vcproj:
4109         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
4110
4111 2007-09-20  Holger Hans Peter Freyther  <zecke@selfish.org>
4112
4113         Rubber stamped by Adam.
4114
4115         * GdkLauncher: Removed.
4116         * GdkLauncher/Bakefiles.bkgen: Removed.
4117         * GdkLauncher/ENV: Removed.
4118         * GdkLauncher/GdkLauncher.pro: Removed.
4119         * GdkLauncher/gdklauncher.bkl: Removed.
4120         * GdkLauncher/main.cpp: Removed.
4121         * GdkLauncher/mk: Removed.
4122         * GdkLauncher/simple.svg: Removed.
4123         * GdkLauncher/text.html: Removed.
4124         * GtkLauncher: Added.
4125         * GtkLauncher/GdkLauncher.pro: Removed.
4126         * GtkLauncher/GtkLauncher.pro: Added.
4127         * GtkLauncher/main.cpp:
4128         (updateWindowTitle):
4129         (main):
4130         * Scripts/build-webkit:
4131         * Scripts/regenerate-makefiles:
4132         * Scripts/run-javascriptcore-tests:
4133         * Scripts/run-launcher:
4134         * Scripts/run-webkit-tests:
4135         * Scripts/webkitdirs.pm:
4136
4137 2007-09-21  Timothy Hatcher  <timothy@apple.com>
4138
4139         Reviewed by Darin.
4140
4141         <rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded (breaks EA Sports Online)
4142
4143         Assert that the -[WebScriptObject JSObject] return value is only NULL for non-window objects.
4144         This is tested by plugins/root-object-premature-delete-crash.html.
4145
4146         * DumpRenderTree/mac/ObjCController.m:
4147         (-[ObjCController accessStoredWebScriptObject]):
4148
4149 2007-09-21  Kevin McCullough  <kmccullough@apple.com>
4150
4151         Reviewed by Oliver.
4152
4153         - We need to initialize the ref count to 1 at initialization so that objects are not garbage collected. (actual patch written by Oliver)
4154
4155         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
4156         (FrameLoadDelegate::FrameLoadDelegate):
4157
4158 2007-09-20  Julien Chaffraix  <julien.chaffraix@gmail.com>
4159
4160         Reviewed by Adam.
4161
4162         Fix: http://bugs.webkit.org/show_bug.cgi?id=15223
4163         webkitdir.pm::isQt() is not working properly in run-webkit-tests under Linux/Qt
4164
4165         Added determineIsQt() and determineIsGdk() to webkitdirs.pm.
4166         Now isQt() and isGdk() use global variables that are only set once.
4167
4168         An array of all the parameters is now given to build-dumprender which includes
4169         the platform on linux.
4170
4171         * Scripts/build-dumprendertree:
4172         * Scripts/run-webkit-tests:
4173         * Scripts/webkitdirs.pm:
4174
4175 2007-09-19  Adam Roben  <aroben@apple.com>
4176
4177         Rubberstamped by Hyatt.
4178
4179         * Spinneret: Removed.
4180
4181 2007-09-19  Tuukka Hastrup  <Tuukka.Hastrup@iki.fi>
4182
4183         Reviewed by David Kilzer.
4184
4185         * Scripts/webkitdirs.pm: On Gdk and Qt, check that flex, bison, gperf are available.
4186
4187 2007-09-18  Sam Weinig  <sam@webkit.org>
4188
4189         Add JSRetainPtr.h #include to fix some builds.
4190
4191         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4192
4193 2007-09-18  Mike Hommey  <glandium@debian.org>
4194
4195         Reviewed by Adam.
4196
4197         * Scripts/prepare-ChangeLog:
4198         - Properly parse GECOS field.
4199         - Use git configuration for user name and email when appropriate.
4200
4201 2007-09-17  Sam Weinig  <sam@webkit.org>
4202
4203         Build fix.
4204
4205         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4206
4207 2007-09-17  Sam Weinig  <sam@webkit.org>
4208
4209         Reviewed by Adam Roben.
4210
4211         Share more code between mac and windows DRT.
4212             - GCController is now shared.
4213             - Rename WaitUntilDoneDelegate to FrameLoadDelegate for consistency.
4214
4215         * DumpRenderTree/GCController.cpp:
4216         * DumpRenderTree/win/DumpRenderTree.cpp:
4217         * DumpRenderTree/win/DumpRenderTree.vcproj:
4218         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.cpp.
4219         (FrameLoadDelegate::FrameLoadDelegate):
4220         (FrameLoadDelegate::~FrameLoadDelegate):
4221         (FrameLoadDelegate::windowScriptObjectAvailable):
4222         * DumpRenderTree/win/FrameLoaderDelegate.h: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.h.
4223         * DumpRenderTree/win/GCController.cpp: Removed.
4224         * DumpRenderTree/win/GCController.h: Removed.
4225         * DumpRenderTree/win/GCControllerWin.cpp: Copied from DumpRenderTree/win/GCController.cpp.
4226         (GCController::collect):
4227         (GCController::collectOnAlternateThread):
4228         (GCController::getJSObjectCount):
4229         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Removed.
4230         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Removed.
4231
4232 2007-09-17  Sam Weinig  <sam@webkit.org>
4233
4234         Reviewed by Adam Roben.
4235
4236         Begin sharing code between mac and windows DRT.
4237             - both now share LayoutTestController.h/cpp and implement platform dependant
4238               operations in LayoutTestControllerMac/Win.
4239             - DumpRenderTree.h is now shared.
4240             - WorkQueue and WorkQueueItem are also shared.
4241
4242         * DumpRenderTree/DumpRenderTree.h:
4243         * DumpRenderTree/LayoutTestController.cpp:
4244         * DumpRenderTree/win/DumpRenderTree.cpp:
4245         (displayWebView):
4246         (dumpFrameScrollPosition):
4247         (dumpFramesAsText):
4248         (dump):
4249         (runTest):
4250         * DumpRenderTree/win/DumpRenderTree.h: Removed.
4251         * DumpRenderTree/win/DumpRenderTree.vcproj:
4252         * DumpRenderTree/win/DumpRenderTreeWin.h: Copied from DumpRenderTree/win/DumpRenderTree.h.
4253         * DumpRenderTree/win/EditingDelegate.cpp:
4254         (EditingDelegate::shouldBeginEditingInDOMRange):
4255         (EditingDelegate::shouldEndEditingInDOMRange):
4256         (EditingDelegate::shouldInsertNode):
4257         (EditingDelegate::shouldInsertText):
4258         (EditingDelegate::shouldDeleteDOMRange):
4259         (EditingDelegate::shouldChangeSelectedDOMRange):
4260         (EditingDelegate::shouldApplyStyle):
4261         (EditingDelegate::shouldChangeTypingStyle):
4262         (EditingDelegate::doPlatformCommand):
4263         (EditingDelegate::webViewDidBeginEditing):
4264         (EditingDelegate::webViewDidChange):
4265         (EditingDelegate::webViewDidEndEditing):
4266         (EditingDelegate::webViewDidChangeTypingStyle):
4267         (EditingDelegate::webViewDidChangeSelection):
4268         * DumpRenderTree/win/LayoutTestController.cpp: Removed.
4269         * DumpRenderTree/win/LayoutTestController.h: Removed.