2010-09-08 Victor Wang <victorw@chromium.org>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-09-08  Victor Wang  <victorw@chromium.org>
2
3         Reviewed by Ojan Vafai.
4
5         [Chromium] Fix test results server to make sure
6         it does not have corrupted data.
7
8         results.json file size coulbe be >1M and we split
9         the data into multiple data store entries in this
10         case. This patch fixes the issue that the data may
11         be corrupted if data store error happens in the middle
12         of saving multiple entries.
13
14         https://bugs.webkit.org/show_bug.cgi?id=45063
15
16         * TestResultServer/model/datastorefile.py:
17
18 2010-09-08  Peter Varga  <pvarga@inf.u-szeged.hu>
19
20         Reviewed by Kenneth Rohde Christiansen.
21
22         Fix ignoring return value warning in case of gcc 4.4.4
23         https://bugs.webkit.org/show_bug.cgi?id=45384
24
25         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
26         (testPostURLFile):
27         If fwrite have written zero byte then the testPostURLFile function
28         returns with false as tempFile can't be opened.
29         * DumpRenderTree/qt/ImageDiff.cpp:
30         (main):
31         Put fwrite function into an if condition without body to avoid
32         warning. It is safe because this function writes to the stdout.
33
34 2010-09-08  Satish Sampath  <satish@chromium.org>
35
36         Unreviewed, adding myself to committers list.
37
38         * Scripts/webkitpy/common/config/committers.py:
39
40 2010-09-08  Hans Wennborg  <hans@chromium.org>
41
42         Unreviewed.
43
44         Adding myself as a committer in committers.py.
45
46         * Scripts/webkitpy/common/config/committers.py:
47
48 2010-09-08  Zoltan Horvath  <zoltan@webkit.org>
49
50         Reviewed by Simon Hausmann.
51
52         [Qt] Refactor MiniBrowser 
53         https://bugs.webkit.org/show_bug.cgi?id=45173
54
55         Split BrowserWindow into two source files and headers. Remove unnecessary header includes.
56
57         * MiniBrowser/qt/BrowserView.cpp: Added.
58         (createNewPage):
59         (BrowserView::BrowserView):
60         (BrowserView::resizeEvent):
61         (BrowserView::load):
62         (BrowserView::view):
63         * MiniBrowser/qt/BrowserView.h: Added.
64         (BrowserView::~BrowserView):
65         * MiniBrowser/qt/BrowserWindow.cpp:
66         * MiniBrowser/qt/BrowserWindow.h:
67         * MiniBrowser/qt/MiniBrowser.pro:
68
69 2010-09-08  Adam Barth  <abarth@webkit.org>
70
71         Rubber-stamped by Eric Seidel.
72
73         Rename DocLoader to CachedResourceLoader because that's what it does.
74
75         * Scripts/do-webcore-rename:
76
77 2010-09-07  Kinuko Yasuda  <kinuko@chromium.org>
78
79         Reviewed by Ojan Vafai.
80
81         Enable incremental results.json generation for non-layout tests.
82         https://bugs.webkit.org/show_bug.cgi?id=45315
83
84         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: Enable generate_incremental_results=True by default. (This still keeps to generate results.json.)  Also add a code to upload results json files to the app-engine server.  Need a chromium change to actually start the uploading.
85
86         * TestResultServer/model/jsonresults.py: Make sure we save the file with test_type for incremental cases too.
87
88
89 2010-09-07  Dirk Pranke  <dpranke@chromium.org>
90
91         Unreviewed, build fix
92
93         Missed one test in mac_unittest.py in previous change; for some
94         reason the method is listed twice. I will fix both for now, but will
95         figure this out in a later, not-time-sensitive patch.
96
97         https://bugs.webkit.org/show_bug.cgi?id=45357
98
99         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
100
101 2010-09-07  Kent Tamura  <tkent@chromium.org>
102
103         Reviewed by Tony Chang.
104
105         test-webkitpy: Fix load error of
106         webkitpy/layout_tests/port/factory_unittest.py on Win32 Python
107         https://bugs.webkit.org/show_bug.cgi?id=45356 Need a short
108
109         * Scripts/webkitpy/layout_tests/port/server_process.py:
110           Avoid to import fcntl on win32. Win32 Python doesn't have fcntl
111           and we don't use server_process.py on Win32 Python. However
112           unittest.py tries to load everything in a module.
113
114 2010-09-07  Dirk Pranke  <dpranke@chromium.org>
115
116         Reviewed by Kent Tamura.
117
118         Fix regression introduced in previous change to new-run-webkit-tests
119         (bug 45090) to not try to run unittests for the Mac implementation
120         of the Port interface if we aren't running on a Mac.
121
122         Also fix the overrides implementation mock in the chromium unittests
123         to fix the case where there are overrides checked in that cause
124         problems.
125
126         https://bugs.webkit.org/show_bug.cgi?id=45357
127
128         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
129         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
130         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
131
132 2010-09-01  Dirk Pranke  <dpranke@chromium.org>
133
134         Reviewed by Ojan Vafai.
135
136         new-run-webkit-tests: still more unit tests
137
138         Clean up and remove unnecessary code. Biggest notable change is
139         moving the chromium-specific imagediff code from port/base to
140         port/chromium.
141
142         Add more unit tests for run_webkit_tests.py, port/base.py,
143         port/factory.py, port/dryrun.py, and
144         layout_package/dump_render_tree_thread.py
145
146         This covers almost all of the generic and test code paths except for
147         a few error paths involving invalid or port-specific command line
148         arguments, and the code path for uploading results files to the
149         buildbots.
150         
151         https://bugs.webkit.org/show_bug.cgi?id=45090
152
153         * Scripts/webkitpy/layout_tests/data/failures/expected/hang.html: Added.
154         * Scripts/webkitpy/layout_tests/data/http/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
155         * Scripts/webkitpy/layout_tests/data/http/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
156         * Scripts/webkitpy/layout_tests/data/http/tests/ssl/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
157         * Scripts/webkitpy/layout_tests/data/http/tests/ssl/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
158         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
159         * Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
160         * Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
161         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
162         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Added.
163         * Scripts/webkitpy/layout_tests/port/base.py:
164         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
165         * Scripts/webkitpy/layout_tests/port/chromium.py:
166         * Scripts/webkitpy/layout_tests/port/dryrun.py:
167         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
168         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
169         * Scripts/webkitpy/layout_tests/port/port_testcase.py: Added.
170         * Scripts/webkitpy/layout_tests/port/server_process.py:
171         * Scripts/webkitpy/layout_tests/port/test.py:
172         * Scripts/webkitpy/layout_tests/port/webkit.py:
173         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
174         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
175
176 2010-09-07  Joseph Pecoraro  <joepeck@webkit.org>
177
178         Reviewed by Darin Adler.
179
180         Provide a way to trigger a <select multiple> onchange event on changes
181         https://bugs.webkit.org/show_bug.cgi?id=45192
182
183         Adds a selector on ObjCController for testing
184         -[DOMHTMLSelectElement _activateItemAtIndex:allowMultipleSelection:] and
185         its different uses.
186
187         * DumpRenderTree/mac/ObjCController.m:
188         (+[ObjCController isSelectorExcludedFromWebScript:]):
189         (+[ObjCController webScriptNameForSelector:]):
190         (-[ObjCController setSelectElement:selectedIndex:allowingMultiple:]):
191
192 2010-09-07  James Robinson  <jamesr@chromium.org>
193
194         Rubber-stamped by Dimitri Glazkov.
195
196         Move myself from the committer to the reviewer list.
197
198         * Scripts/webkitpy/common/config/committers.py:
199
200 2010-09-07  Tony Chang  <tony@chromium.org>
201
202         Reviewed by Darin Fisher.
203
204         [chromium] Make a public flag for how DRT generates bitmaps on Linux
205         https://bugs.webkit.org/show_bug.cgi?id=45133
206
207         * DumpRenderTree/chromium/TestShell.cpp:
208         (TestShell::dumpImage):
209
210 2010-09-07  Kent Tamura  <tkent@chromium.org>
211
212         Reviewed by Dimitri Glazkov.
213
214         [DRT/Chromium] Implement --check-layout-test-sys-deps
215         https://bugs.webkit.org/show_bug.cgi?id=45283
216
217         * DumpRenderTree/chromium/DumpRenderTree.cpp:
218         (main): Check --check-layout-test-sys-deps and call checkLayoutTestSystemDependencies().
219         * DumpRenderTree/chromium/TestShell.h: Declare checkLayoutTestSystemDependencies().
220         * DumpRenderTree/chromium/TestShellGtk.cpp:
221         (checkLayoutTestSystemDependencies): Add an empty implementation.
222         * DumpRenderTree/chromium/TestShellMac.mm:
223         (checkLayoutTestSystemDependencies): Add an empty implementation.
224         * DumpRenderTree/chromium/TestShellWin.cpp:
225         (checkLayoutTestSystemDependencies): Port similar function of test_shell.
226
227 2010-09-07  Jessie Berlin  <jberlin@apple.com>
228
229         Unreviewed. Mac build fix.
230
231         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
232         (didClearWindowObjectForFrame):
233
234 2010-09-07  Jessie Berlin  <jberlin@apple.com>
235
236         Reviewed by Darin Adler.
237
238         Indicate which one of the ScriptWorlds for a Frame the Window Object has been cleared for
239         https://bugs.webkit.org/show_bug.cgi?id=45217
240         
241         Make WebKitTestRunner work with this change.
242
243         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
244         (WTR::InjectedBundlePage::didClearWindowForFrame):
245         Make sure the ScriptWorld here is the normal world, since that is no longer being done in
246         WebFrameLoaderClient.
247         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
248
249 2010-09-07  Philippe Normand  <pnormand@igalia.com>
250
251         Unreviewed, build fix.
252
253         webkit-patch command to find the ports covering a specific layout test
254         https://bugs.webkit.org/show_bug.cgi?id=42832
255
256         * Scripts/webkitpy/layout_tests/port/chromium.py: Don't assume the
257         tests are present when building the expectations. This is needed
258         for the unittests.
259
260 2010-09-06  Philippe Normand  <pnormand@igalia.com>
261
262         Reviewed by Adam Barth.
263
264         webkit-patch command to find the ports covering a specific layout test
265         https://bugs.webkit.org/show_bug.cgi?id=42832
266
267         To use it: webkit-patch skipped-ports some/layout/test.html
268
269         * Scripts/webkitpy/layout_tests/port/base.py:
270         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
271         * Scripts/webkitpy/layout_tests/port/chromium.py:
272         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
273         * Scripts/webkitpy/layout_tests/port/factory.py:
274         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
275         * Scripts/webkitpy/layout_tests/port/test.py:
276         * Scripts/webkitpy/layout_tests/port/webkit.py:
277         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
278         * Scripts/webkitpy/tool/commands/queries.py:
279         * Scripts/webkitpy/tool/commands/queries_unittest.py:
280         * Scripts/webkitpy/tool/main.py:
281         * Scripts/webkitpy/tool/mocktool.py:
282
283 2010-09-07  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
284
285         Reviewed by Eric Seidel.
286
287         [NRWT] Add temp directory to all running drivers.
288         https://bugs.webkit.org/show_bug.cgi?id=45261
289
290         * Scripts/webkitpy/layout_tests/port/webkit.py:
291
292 2010-09-06  Dimitri Glazkov  <dglazkov@chromium.org>
293
294         Reviewed by Kent Tamura.
295
296         [Chromium/DRT] Empty out user stylesheet after each test run.
297         https://bugs.webkit.org/show_bug.cgi?id=45282
298
299         This should significantly cut down on the number of the mysterious flaky tests
300         whose diffs looked like the page was blown up to a very lage size. This
301         was indeed the dirty work of platform/mac/fast/loader/user-stylesheet-fast-path.html,
302         which set the base body font to 100px.
303
304         Since the user stylesheet was never reset, _all_ pixel tests that ran after it in
305         the same thread failed.
306
307         * DumpRenderTree/chromium/TestShell.cpp:
308         (TestShell::resetWebSettings): Set user stylesheet to an empty URL.
309
310 2010-09-06  Kent Tamura  <tkent@chromium.org>
311
312         Reviewed by Dimitri Glazkov.
313
314         [DRT/Chromium] Do not generate pixel results for text/plain resources
315         https://bugs.webkit.org/show_bug.cgi?id=45253
316
317         * DumpRenderTree/chromium/TestShell.cpp:
318         (TestShell::dump): Clear shouldGeneratePixelResults flag for text/plain.
319
320 2010-09-06  Ojan Vafai  <ojan@chromium.org>
321
322         Reviewed by Kent Tamura.
323
324         print out correct error when a DRT thread dies in NRWT
325         https://bugs.webkit.org/show_bug.cgi?id=45281
326
327         Not sure why, but with the parens, python 2.6.5 on Linux
328         gives an error that raise takes 5 arguments and 0 were given.
329         Didn't test other platforms or python versions, but putting it
330         all on one line fixes it and correctly prints the exception
331         from the DRT thread.
332
333         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
334
335 2010-09-06  Eric Seidel  <eric@webkit.org>
336
337         Unreviewed, just adding some emails from lists.webkit.org.
338
339         Update committers.py to include emails from lists.webkit.org
340         as found by the validate-committer-lists script.
341
342         * Scripts/webkitpy/common/config/committers.py:
343
344 2010-09-06  Martin Robinson  <mrobinson@igalia.com>
345
346         Reviewed by Xan Lopez.
347
348         [GTK] Small code cleanup in DumpRenderTreeGtk.cpp
349         https://bugs.webkit.org/show_bug.cgi?id=45213
350
351         * DumpRenderTree/gtk/DumpRenderTree.cpp:
352         (initializeFonts): Made this function do nothing for non-X11 platforms, so we don't
353         have to surround the invocation with #ifdefs.
354         (useLongRunningServerMode): Added.
355         (runTestingServerLoop): Added.
356         (initializeGlobalsFromCommandLineOptions): Added.
357         (runTest): Removed ifdefs.
358         (main): Use new helper functions.
359
360 2010-09-06  Martin Robinson  <mrobinson@igalia.com>
361
362         Reviewed by Xan Lopez.
363
364         [GTK] EventSender should support modifier keys with mouseDown and mouseUp events
365         https://bugs.webkit.org/show_bug.cgi?id=45235
366
367         Add support for interpreting the modifier key arguments to the mouseDown and mouseUp
368         methods of the EventSender.
369
370         * DumpRenderTree/gtk/EventSender.cpp:
371         (prepareMouseButtonEvent): Allow passing in a modifier bitmask, which will be OR'd
372         with the current modifiers.
373         (contextClickCallback): Always send no modifiers when preparing the mouse event.
374         (gdkModifersFromJSValue): Added, converts a JSValue array into a GDK modifier bitmask.
375         (mouseDownCallback): Send in the requested modifiers to prepareMouseButtonEvent.
376         (mouseUpCallback): Ditto.
377
378 2010-09-05  Peter Kasting  <pkasting@google.com>
379
380         Reviewed by Adam Barth.
381
382         Make Chromium/Mac generate continuous mousewheel events with the same wheelDelta values as Safari/Mac.
383         https://bugs.webkit.org/show_bug.cgi?id=45155
384
385         * DumpRenderTree/chromium/EventSender.cpp: Modify Chromium DRT mousewheel event generation to match new behavior on Mac.
386         (EventSender::handleMouseWheel):
387
388 2010-09-05  Yury Semikhatsky  <yurys@chromium.org>
389
390         Reviewed by Joseph Pecoraro.
391
392         Web Inspector: remove WebDevToolsAgentClient::forceRepaint which is not used
393         https://bugs.webkit.org/show_bug.cgi?id=45179
394
395         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
396         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
397
398 2010-09-05  Andreas Kling  <andreas.kling@nokia.com>
399
400         Rubber-stamped by Daniel Bates.
401
402         Adding myself as reviewer.
403
404         * Scripts/webkitpy/common/config/committers.py:
405
406 2010-09-04  Daniel Bates  <dbates@rim.com>
407
408         Reviewed by Martin Robinson.
409
410         Teach svn-apply/unapply about svn:mergeinfo
411         https://bugs.webkit.org/show_bug.cgi?id=45236
412
413         Recognize the svn:mergeinfo property and ignore it for now.
414
415         Currently, svn-apply/unapply recognize only '+' and '-'
416         property changes within a diff. We should add support
417         to recognize "Merged" and "Reverse-merged" changes as well.
418         Because svn:mergeinfo is metadata that is used only by SVN
419         and tends to be error-prone and/or nuisance (*), we will ignore
420         it for now.
421         (*) See "Parting Thoughts" of <http://www.collab.net/community/subversion/articles/merge-info.html>.
422
423         * Scripts/VCSUtils.pm:
424           - Modified parseSvnProperty() to recognize "Merged" and
425             "Reverse-merged" as the start of a property value.
426         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
427           - Added the following unit tests:
428             "simple: add svn:mergeinfo"
429             "simple: delete svn:mergeinfo"
430             "simple: modified svn:mergeinfo"
431         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
432           - Added the following unit tests:
433             "simple: add svn:mergeinfo"
434             "simple: delete svn:mergeinfo"
435             "simple: modified svn:mergeinfo"
436             "simple: modified svn:mergeinfo using SVN 1.4 syntax"
437             "'Merged' change followed by 'Merged' change"
438             "'Reverse-merged' change followed by 'Reverse-merged' change"
439         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
440           - Added the following unit tests:
441             "'Merged' change"
442             "'Reverse-merged' change"
443             "'Reverse-merged' change followed by 'Merge' change"
444             "'Merged' change followed by 'Merge' change"
445             "'Reverse-merged' change followed by 'Reverse-merged' change"
446             "'Reverse-merged' change followed by 'Reverse-merged' change followed by 'Merged' change"
447
448 2010-09-04  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
449
450         Reviewed by Kenneth Rohde Christiansen.
451
452         [EFL] Move test browser to WebKitTools directory
453         https://bugs.webkit.org/show_bug.cgi?id=45212
454
455         Follow other ports like QT and GTK which moved the test browser to
456         WebKitTools directory.
457
458         * CMakeListsEfl.txt: Added.
459         * EWebLauncher/main.c: Added.
460         (print_history):
461         (zoom_level_set):
462         (on_ecore_evas_resize):
463         (title_set):
464         (viewport_set):
465         (on_title_changed):
466         (on_progress):
467         (on_load_finished):
468         (on_toolbars_visible_set):
469         (on_toolbars_visible_get):
470         (on_statusbar_visible_set):
471         (on_statusbar_visible_get):
472         (on_scrollbars_visible_set):
473         (on_scrollbars_visible_get):
474         (on_menubar_visible_set):
475         (on_menubar_visible_get):
476         (on_tooltip_text_set):
477         (on_inputmethod_changed):
478         (on_viewport_changed):
479         (on_mouse_down):
480         (on_focus_out):
481         (on_focus_in):
482         (on_resized):
483         (on_key_down):
484         (on_browser_del):
485         (on_closeWindow):
486         (quit):
487         (browserCreate):
488         (browserDestroy):
489         (closeWindow):
490         (main_signal_exit):
491         (findThemePath):
492         (main):
493
494 2010-09-03  Simon Fraser  <simon.fraser@apple.com>
495
496         Reviewed by Adam Roben.
497
498         Set project dependencies so that they build serially. This fixes
499         issues when running run-webkit-tests if DRT is not built yet.
500
501         * DumpRenderTree/DumpRenderTree.sln:
502
503 2010-09-03  Dimitri Glazkov  <dglazkov@chromium.org>
504
505         Reviewed by Adam Barth.
506
507         Fix reading configuraiton in NWRT to work on Windows.
508         https://bugs.webkit.org/show_bug.cgi?id=45180
509
510         * Scripts/webkitpy/layout_tests/port/base.py: Added 'perl' argument, because Windows doesn't know what to do
511             with the file otherwise.
512
513 2010-09-03  Chris Rogers  <crogers@google.com>
514
515         Unreviewed
516
517         Add myself to the committers list
518         https://bugs.webkit.org/show_bug.cgi?id=45189
519
520         * Scripts/webkitpy/common/config/committers.py:
521
522 2010-09-03  Andrey Kosyakov  <caseq@chromium.org>
523
524         Reviewed by Yury Semikhatsky.
525
526         http/tests/inspector/console-xhr-logging.html and http/tests/inspector/resource-har-conversion.html are failing on chromium win bot
527         Changed MIME type for .js to application/x-javascript for consistency with apache used on other platforms.
528         https://bugs.webkit.org/show_bug.cgi?id=45137
529
530         * Scripts/webkitpy/layout_tests/port/lighttpd.conf:
531
532 2010-09-03  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
533
534         Reviewed by Eric Seidel.
535
536         Add feature detection support to NRWT.
537         https://bugs.webkit.org/show_bug.cgi?id=41842
538
539         * Scripts/webkitpy/layout_tests/port/base.py:
540         * Scripts/webkitpy/layout_tests/port/qt.py:
541         * Scripts/webkitpy/layout_tests/port/webkit.py:
542         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added.
543
544 2010-09-03  Hironori Bono  <hbono@chromium.org>
545
546         Reviewed by Kent Tamura.
547
548         Adds textInputController.hasSpellingMarker() to avoid using pixel tests for spellchecking tests
549         and implements it for Mac.
550         https://bugs.webkit.org/show_bug.cgi?id=41832
551
552         * DumpRenderTree/mac/TextInputController.m: Added [TextInputController hasSpellingMarker:length:]
553         and bind it so we can call it from JavaScript.
554         (+[TextInputController isSelectorExcludedFromWebScript:]):
555         (+[TextInputController webScriptNameForSelector:]):
556         (-[TextInputController hasSpellingMarker:length:]):
557
558 2010-09-02  Eric Seidel  <eric@webkit.org>
559
560         Reviewed by Adam Barth.
561
562         Add a unit test for commit-queue retries
563         https://bugs.webkit.org/show_bug.cgi?id=45162
564
565         I think commit-queue retries are not correctly avoiding
566         build and test on retries.  So I started testing the code.
567         Unfortunately this test did not find the bug.  But now
568         that we have the test we might as well keep it.
569         I also fixed a broken import in validate-committer-lists.
570
571         * Scripts/validate-committer-lists:
572         * Scripts/webkitpy/tool/commands/queues_unittest.py:
573
574 2010-09-02  Kent Tamura  <tkent@chromium.org>
575
576         Reviewed by Dimitri Glazkov.
577
578         [DRT/Chromium] Remove dependency to base/task.h and base/timer.h
579         https://bugs.webkit.org/show_bug.cgi?id=45091
580
581         Task.{cpp,h} introduces a simpler version of Chromium
582         base/task.h. It doesn't have TupleN and Method.
583
584         * DumpRenderTree/DumpRenderTree.gypi:
585          Add Task.cpp and Task.h
586         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
587         (DRTDevToolsAgent::DRTDevToolsAgent):
588         (DRTDevToolsAgent::reset):
589         (DRTDevToolsAgent::asyncCall):
590         (DRTDevToolsAgent::frontendLoaded):
591         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
592         (DRTDevToolsAgent::taskList): Added to use MethodTask<T>.
593         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
594         (DRTDevToolsClient::DRTDevToolsClient):
595         (DRTDevToolsClient::~DRTDevToolsClient):
596         (DRTDevToolsClient::reset):
597         (DRTDevToolsClient::asyncCall):
598         * DumpRenderTree/chromium/DRTDevToolsClient.h:
599         (DRTDevToolsClient::taskList): Added to use MethodTask<T>.
600         * DumpRenderTree/chromium/EventSender.cpp:
601         (EventSender::EventSender):
602         (EventSender::reset):
603         (EventSender::scheduleAsynchronousClick):
604         * DumpRenderTree/chromium/EventSender.h:
605         (EventSender::taskList): Added to use MethodTask<T>.
606         * DumpRenderTree/chromium/LayoutTestController.cpp:
607         (LayoutTestController::LayoutTestController):
608         (LayoutTestController::WorkQueue::processWorkSoon):
609         (LayoutTestController::waitUntilDone):
610         (LayoutTestController::notifyDone):
611         (LayoutTestController::reset):
612         * DumpRenderTree/chromium/LayoutTestController.h:
613         (LayoutTestController::taskList): Added to use MethodTask<T>.
614         (LayoutTestController::WorkQueue::taskList): Added to use MethodTask<T>.
615         * DumpRenderTree/chromium/NotificationPresenter.cpp:
616         (deferredDisplayDispatch):
617         (NotificationPresenter::show):
618         * DumpRenderTree/chromium/Task.cpp: Added.
619         * DumpRenderTree/chromium/Task.h: Added.
620
621 2010-09-02  Steve Block  <steveblock@google.com>
622
623         Reviewed by Adam Barth.
624
625         Hook up LayoutTestController.setMockDeviceOrientation() on Mac.
626         https://bugs.webkit.org/show_bug.cgi?id=43181
627
628         * DumpRenderTree/mac/DumpRenderTree.mm:
629         (createWebViewAndOffscreenWindow):
630         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
631         (LayoutTestController::setMockDeviceOrientation):
632
633 2010-08-31  Adam Roben  <aroben@apple.com>
634
635         Fix flashiness when resizing the browser window on Windows
636
637         Reviewed by Sam Weinig.
638
639         * MiniBrowser/win/BrowserWindow.cpp:
640         (BrowserWindow::wndProc): Override WM_ERASEBKGND so Windows won't
641         periodically fill the window with white.
642
643 2010-09-02  Peter Kasting  <pkasting@google.com>
644
645         Reviewed by Dimitri Glazkov.
646
647         Implement [continuous]MouseScrollBy() on Chromium, and partly on GTK.
648         https://bugs.webkit.org/show_bug.cgi?id=45073
649
650         * DumpRenderTree/chromium/EventSender.cpp:
651         (EventSender::EventSender):
652         (EventSender::mouseScrollBy):
653         (EventSender::continuousMouseScrollBy):
654         (EventSender::sendCurrentTouchEvent):
655         (EventSender::handleMouseWheel):
656         * DumpRenderTree/chromium/EventSender.h:
657         * DumpRenderTree/gtk/EventSender.cpp:
658         (mouseScrollByCallback):
659         (continuousMouseScrollByCallback):
660
661 2010-09-01  Dirk Pranke  <dpranke@chromium.org>
662
663         Reviewed by Tony Chang.
664
665         Land a patched version of r66542 - change TestRunner to have an
666         separate cleanup method and fix the ordering of cleanup between
667         TestRunner and the printing module, and then wrap everything in a
668         try/finally block to ensure reliable cleanup without needing to
669         rely on stuff happening in the destructor of the TestRunner.
670
671         Also refactor run_webkit_tests.run() to be much smaller and cleaner
672         by creating a bunch of helper methods and moving more stuff into
673         the TestRunner class.
674
675         This fixes the crash at the end of the linux test run of
676         new-run-webkit-tests (and undoes the rollout in 66547).
677
678         https://bugs.webkit.org/show_bug.cgi?id=44902
679
680         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Added.
681         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Added.
682         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Added.
683         * Scripts/webkitpy/layout_tests/data/passes/error.html: Added.
684         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
685         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
686         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
687         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
688         * Scripts/webkitpy/layout_tests/port/base.py:
689         * Scripts/webkitpy/layout_tests/port/test.py:
690         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
691         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
692
693 2010-09-01  Mark Rowe  <mrowe@apple.com>
694
695         Reviewed by Adam Roben.
696
697         Fix TestNetscapePlugIn to compile without access to QuickDraw private headers.
698
699         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
700
701 2010-09-01  Brian Weinstein  <bweinstein@apple.com>
702
703         Reviewed by Adam Roben.
704
705         Have kill-old-processes kill debug and release variants of WebKit2WebWebProcess
706         and WebKitTestRunner.
707
708         * BuildSlaveSupport/win/kill-old-processes:
709
710 2010-09-01  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
711
712         Reviewed by Antonio Gomes.
713
714         [Qt] Remove obsolete include path from DumpRenderTree.pro
715
716         * DumpRenderTree/qt/DumpRenderTree.pro:
717
718 2010-09-01  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
719
720         Reviewed by Laszlo Gombos.
721
722         [Qt] QWebPage::allowGeolocationRequest should be async API
723         https://bugs.webkit.org/show_bug.cgi?id=41364
724
725         Implements new async API for geolocation permission similar to
726         Notification. WebPage maintains list of geolocation permission request
727         QtWebkit and set's when LayoutTestController gets the access from test JS
728
729         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
730         (WebCore::WebPage::WebPage):
731         (WebCore::WebPage::resetSettings):
732         (WebCore::WebPage::requestPermission):
733         (WebCore::WebPage::cancelPermission):
734         (WebCore::WebPage::permissionSet):
735         (WebCore::DumpRenderTree::DumpRenderTree):
736         (WebCore::DumpRenderTree::processLine):
737         (WebCore::DumpRenderTree::geolocationPermissionSet):
738         * DumpRenderTree/qt/DumpRenderTreeQt.h:
739         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
740         (LayoutTestController::reset):
741         (LayoutTestController::setGeolocationPermission):
742         (LayoutTestController::setGeolocationPermissionCommon):
743         * DumpRenderTree/qt/LayoutTestControllerQt.h:
744
745 2010-09-01  Andras Becsi  <abecsi@webkit.org>
746
747         Reviewed by Antti Koivisto.
748
749         [Qt] Auto-generate WebKit2 forwarding headers
750         https://bugs.webkit.org/show_bug.cgi?id=44692
751
752         * MiniBrowser/qt/BrowserWindow.h: use source style includes
753         * MiniBrowser/qt/MiniBrowser.pro: add missing include paths
754         * Scripts/enumerate-included-framework-headers: Removed.
755
756 2010-08-31  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
757
758         Reviewed by Adam Barth.
759
760         Allow Ctrl+C inside Bugzilla::fetch_bug_dictionary
761         https://bugs.webkit.org/show_bug.cgi?id=44789
762
763         * Scripts/webkitpy/common/net/bugzilla.py:
764
765 2010-08-31  Leandro Pereira  <leandro@profusion.mobi>
766
767         Reviewed by Adam Barth.
768
769         ews: Add support for EFL-EWS
770         https://bugs.webkit.org/show_bug.cgi?id=44982
771
772         * QueueStatusServer/model/queues.py: Add "efl-ews" to queues list.
773         * Scripts/webkitpy/common/config/ports.py: Define a EflPort class
774         and add it to the ports dict.
775         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: Define a
776         EflEWS class.
777         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: Add
778         a test case for the EFL EWS.
779
780 2010-08-31  Alexey Proskuryakov  <ap@apple.com>
781
782         Reviewed by Sam Weinig.
783
784         https://bugs.webkit.org/show_bug.cgi?id=42195
785         <rdar://problem/8186761> WebKitTestRunner needs to support layoutTestController.setXSSAuditorEnabled
786
787         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
788         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setXSSAuditorEnabled):
789         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
790         Added setXSSAuditorEnabled, calling through to an WKBundle private method. Calling this method
791         makes WebProcess use a different value for this preference than UIProcess thinks it uses.
792
793         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
794         Reset xssAuditorEnabled. Even though the value doesn't change, this calls through to WebProcess,
795         which forgets its override.
796
797 2010-08-31  Sam Weinig  <sam@webkit.org>
798
799         Reviewed by Gavin Barraclough.
800
801         WebKitTestRunner needs layoutTestController.addUserStyleSheet
802         https://bugs.webkit.org/show_bug.cgi?id=42680
803
804         WebKitTestRunner needs layoutTestController.addUserScript
805         https://bugs.webkit.org/show_bug.cgi?id=42681
806
807         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
808         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
809         (WTR::InjectedBundle::beginTesting):
810         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
811         (WTR::LayoutTestController::addUserScript):
812         (WTR::LayoutTestController::addUserStyleSheet):
813         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
814
815 2010-08-31  Dirk Pranke  <dpranke@chromium.org>
816
817         Unreviewed, rolling out r66542.
818         http://trac.webkit.org/changeset/66542
819         https://bugs.webkit.org/show_bug.cgi?id=44902
820
821         r66542 - the weird logging dependencies in Python stuck again ...
822
823         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Removed.
824         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Removed.
825         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Removed.
826         * Scripts/webkitpy/layout_tests/data/passes/error.html: Removed.
827         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
828         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
829         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
830         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
831         * Scripts/webkitpy/layout_tests/port/base.py:
832         * Scripts/webkitpy/layout_tests/port/test.py:
833         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
834         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
835
836 2010-08-31  Dumitru Daniliuc  <dumi@chromium.org>
837
838         Reviewed by Tony Chang.
839
840         Implementing LayoutTestController::markerTextForListItem() in Chromium's DRT.
841
842         * DumpRenderTree/chromium/LayoutTestController.cpp:
843         (LayoutTestController::LayoutTestController):
844         (LayoutTestController::markerTextForListItem):
845         * DumpRenderTree/chromium/LayoutTestController.h:
846
847 2010-08-31  Dirk Pranke  <dpranke@chromium.org>
848
849         Reviewed by Ojan Vafai.
850
851         new-run-webkit-tests: add more unit tests
852
853         Add more unit tests for new-run-webkit-tests; we now cover all but
854         the most obscure code paths in the generic code. We still need to
855         add coverage for the http server and web socket paths, and add better
856         coverage of the platform-specific logic. Note that the rebaselining
857         tool is still not well tested.
858
859         Also clean up some of the configuration logic for the printing
860         module and the way it interacts with the Python logging module; that
861         is a crufty interface, to be certain.
862         
863         https://bugs.webkit.org/show_bug.cgi?id=44902
864
865         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Added.
866         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Added.
867         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Added.
868         * Scripts/webkitpy/layout_tests/data/passes/error.html: Added.
869         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
870         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
871         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
872         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
873         * Scripts/webkitpy/layout_tests/port/base.py:
874         * Scripts/webkitpy/layout_tests/port/test.py:
875         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
876         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
877
878 2010-08-31  Darin Adler  <darin@apple.com>
879
880         Reviewed by Anders Carlsson.
881
882         * Scripts/check-for-global-initializers: Add a file that ends up having global initializers
883         in a debug build when built with certain compilers.
884
885 2010-08-31  Martin Robinson  <mrobinson@igalia.com>
886
887         Reviewed by Gustavo Noronha Silva.
888
889         [GTK] Isolate all GTK+ typedefs into one file
890         https://bugs.webkit.org/show_bug.cgi?id=44900
891
892         * DumpRenderTree/gtk/EventSender.h: Remove GTK+ typedefs.
893
894 2010-08-31  Eric Seidel  <eric@webkit.org>
895
896         Reviewed by Adam Barth.
897
898         Show more status on queue status pages
899         https://bugs.webkit.org/show_bug.cgi?id=44938
900
901         I upped the number of status lines from 6 to 15 --
902         this has been bugging me for a while...
903
904         I also disabled showing the chromium-win EWS queue
905         since it's been down for almost 5 months now.
906
907         * QueueStatusServer/handlers/dashboard.py:
908         * QueueStatusServer/handlers/queuestatus.py:
909         * QueueStatusServer/model/queues.py:
910
911 2010-08-31  Zoltan Horvath  <zoltan@webkit.org>
912
913         Reviewed by Antonio Gomes.
914
915         [Qt] Read command line arguments and open them as URLs in new windows
916         https://bugs.webkit.org/show_bug.cgi?id=44944
917
918         Extend MiniBrowser to accept command line arguments and open them as URLs in new browser windows.
919
920         * MiniBrowser/qt/main.cpp:
921         (main):
922
923 2010-08-31  Adrian Perez  <aperez@igalia.com>
924
925         Reviewed by Martin Robinson.
926
927         Support scripts to run Buildbot slaves under daemontools (gtk related)
928         https://bugs.webkit.org/show_bug.cgi?id=40053
929
930         * BuildSlaveSupport/gtk: Added.
931         * BuildSlaveSupport/gtk/README: Added.
932         * BuildSlaveSupport/gtk/buildbot: Added.
933         * BuildSlaveSupport/gtk/buildbot/log: Added.
934         * BuildSlaveSupport/gtk/buildbot/log/run: Added.
935         * BuildSlaveSupport/gtk/buildbot/run: Added.
936         * BuildSlaveSupport/gtk/crashmon: Added.
937         * BuildSlaveSupport/gtk/crashmon/crashmon: Added.
938         * BuildSlaveSupport/gtk/crashmon/log: Added.
939         * BuildSlaveSupport/gtk/crashmon/log/run: Added.
940         * BuildSlaveSupport/gtk/crashmon/run: Added.
941         * BuildSlaveSupport/gtk/daemontools-buildbot.conf: Added.
942         * BuildSlaveSupport/gtk/pulseaudio: Added.
943         * BuildSlaveSupport/gtk/pulseaudio/run: Added.
944         * BuildSlaveSupport/gtk/xvfb: Added.
945         * BuildSlaveSupport/gtk/xvfb/log: Added.
946         * BuildSlaveSupport/gtk/xvfb/log/run: Added.
947         * BuildSlaveSupport/gtk/xvfb/run: Added.
948
949 2010-08-27  John Gregg  <johnnyg@google.com>
950
951         Reviewed by David Levin.
952
953         Notifications should support a click event.
954         Adds necessary hooks to chromium's DRT so that clicks on desktop notifications
955         can be simulated during a layout test.  Requires storing a list of active
956         notifications so that they can be referred to later for clicking.
957         https://bugs.webkit.org/show_bug.cgi?id=44800
958
959         * DumpRenderTree/chromium/LayoutTestController.cpp:
960         (LayoutTestController::LayoutTestController):
961         (LayoutTestController::simulateDesktopNotificationClick):
962         * DumpRenderTree/chromium/LayoutTestController.h:
963         * DumpRenderTree/chromium/NotificationPresenter.cpp:
964         (NotificationPresenter::simulateClick):
965         (NotificationPresenter::show):
966         (NotificationPresenter::cancel):
967         (NotificationPresenter::objectDestroyed):
968         * DumpRenderTree/chromium/NotificationPresenter.h:
969
970 2010-08-30  Alice Liu  <alice.liu@apple.com>
971
972         Reviewed by Darin Adler.
973
974         Add missing parts of didFinishDocumentLoadForFrame
975         https://bugs.webkit.org/show_bug.cgi?id=44913
976
977         * MiniBrowser/mac/BrowserWindowController.m:
978         (didFinishDocumentLoadForFrame): Added
979         (-[BrowserWindowController awakeFromNib]): Updated struct
980         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
981         (WTR::InjectedBundlePage::InjectedBundlePage): Rearranged function ptr
982         * WebKitTestRunner/TestController.cpp:
983         (WTR::TestController::initialize): Updated struct
984
985 2010-08-30  Vangelis Kokkevis  <vangelis@chromium.org>
986
987         Unreviewed: Add myself to the list of Committers.
988
989         * Scripts/webkitpy/common/config/committers.py:
990
991 2010-08-30  Kent Tamura  <tkent@chromium.org>
992
993         Reviewed by Adam Barth.
994
995         Fix fast/notifications/notifications-display-close-events.html failure
996         https://bugs.webkit.org/show_bug.cgi?id=44585
997
998         Apply http://crrev.com/48893. We should dispatch display events
999         asynchronously.
1000
1001         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1002         (deferredDisplayDispatch):
1003         (NotificationPresenter::show):
1004
1005 2010-08-30  Robert Hogan  <robert@webkit.org>
1006
1007         Reviewed by Simon Hausmann.
1008
1009         allow ports with windowed plugins to support windowless plugin tests
1010
1011         https://bugs.webkit.org/show_bug.cgi?id=40730
1012
1013         Ports that implement plugins windowed by default need to have a way of
1014         supporting plugin tests that assume the plugin is windowless. Add this
1015         feature to the tests and support it in the webkit test plugin. Also
1016         add mouse and keyboard event logging to the webkit-test plugin on Unix.
1017
1018         Unskip the following tests on Qt:
1019
1020         plugins/mouse-events.html
1021         plugins/keyboard-events.html
1022         plugins/mouse-events-fixedpos.html
1023
1024         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1025         (pluginSetProperty):
1026         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1027         (NPP_New):
1028         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1029         (webkit_test_plugin_handle_event):
1030
1031 2010-08-30  Kevin Ollivier  <kevino@theolliviers.com>
1032
1033         [wx] Build fix after addition of fileapi directory in WebCore.
1034
1035         * wx/build/settings.py:
1036
1037 2010-08-30  Alejandro G. Castro  <alex@igalia.com>
1038
1039         Reviewed by Xan Lopez.
1040
1041         Fixed compilation error, now that we have included the
1042         GtkVersioning.h we have to remove some version dependent code from
1043         EventSender.
1044
1045         * DumpRenderTree/gtk/EventSender.cpp:
1046
1047 2010-08-30  Alejandro G. Castro  <alex@igalia.com>
1048
1049         Reviewed by Martin Robinson.
1050
1051         [Gtk] gdk_display_get_core_pointer and gdk_device_get_core_pointer
1052         are deprecated
1053         https://bugs.webkit.org/show_bug.cgi?id=44787
1054
1055         We have replaced GtkVersioning.cpp with GtkVersioning.c and
1056         created a function (getDefaultGDKPointerDevice) to get the pointer
1057         of the window with the new APIs. We added that function to DRT and
1058         copyandpaste unit test.
1059
1060         * DumpRenderTree/gtk/EventSender.cpp:
1061         (prepareMouseButtonEvent):
1062         (mouseMoveToCallback):
1063         (keyDownCallback):
1064         * GNUmakefile.am:
1065
1066 2010-08-30  Zoltan Horvath  <zoltan@webkit.org>
1067
1068         Reviewed by Kenneth Rohde Christiansen.
1069
1070         [Qt] Add new window menu to MiniBrowser
1071
1072         Implement newWindow function and add a menu item for opening new window in MiniBrowser.
1073
1074         * MiniBrowser/qt/BrowserWindow.cpp:
1075         (BrowserWindow::BrowserWindow):
1076         (BrowserWindow::newWindow):
1077         * MiniBrowser/qt/BrowserWindow.h:
1078         * MiniBrowser/qt/main.cpp:
1079         (main):
1080
1081 2010-08-29  James Robinson  <jamesr@chromium.org>
1082
1083         Reviewed by David Levin.
1084
1085         Make failing the download step fail the build
1086         https://bugs.webkit.org/show_bug.cgi?id=44298
1087
1088         If the download step fails on a test bot, this ensures that
1089         the build goes red instead of only the download step going red
1090         and the overall build staying green.
1091
1092         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1093
1094 2010-08-29  Kent Tamura  <tkent@chromium.org>
1095
1096         Reviewed by Dimitri Glazkov.
1097
1098         [DRT/Chromium] Remove dependency to base/keyboard_codes.h
1099         https://bugs.webkit.org/show_bug.cgi?id=44847
1100
1101         * DumpRenderTree/chromium/EventSender.cpp:
1102          Use webkit_support::VKEY_* instead of base::VKEY_*.
1103
1104 2010-08-29  Darin Adler  <darin@apple.com>
1105
1106         https://bugs.webkit.org/show_bug.cgi?id=40589
1107
1108         * Scripts/prepare-ChangeLog: Only prepend namespaces to non-empty
1109         function names.
1110
1111 2010-08-26  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
1112
1113         Reviewed by Darin Adler.
1114
1115         [iExploder] Add new CSS Properties and HTML Attributes
1116         https://bugs.webkit.org/show_bug.cgi?id=44746
1117
1118         Updated the files with the update-iexploder-cssproperties script
1119         and manually readded the -webkit-binding CSS Property to the list.
1120
1121         * iExploder/htdocs/cssproperties.in:
1122         * iExploder/htdocs/htmlattrs.in:
1123         * iExploder/htdocs/htmltags.in:
1124
1125 2010-08-26  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
1126
1127         Reviewed by Darin Adler.
1128
1129         Fix Coverage build after the addition of ANGLE
1130         https://bugs.webkit.org/show_bug.cgi?id=44744
1131
1132         ANGLE is using libtool to build a static library and the version of
1133         libtool on Leopard refuses to handle the -fprofile-arcs and -ftest-coverage
1134         parameters. The easiest way to handle this is to not build ANGLE with
1135         coverage information.
1136
1137         This is achieved by applying the XCode options for each project
1138         separately and exclude ANGLE.
1139
1140         * Scripts/build-webkit: Remove -framework AppKit due link errors.
1141         * Scripts/webkitdirs.pm: Do not apply the XCode options for ANGLE.
1142
1143 2010-08-28  Kevin Ollivier  <kevino@theolliviers.com>
1144
1145         [wx] Build fix after directory addition.
1146
1147         * wx/build/settings.py:
1148
1149 2010-08-28  Chris Guillory   <chris.guillory@google.com>
1150
1151         Reviewed by Chris Fleizach.
1152
1153         Add AX notification for childrenChanged
1154         https://bugs.webkit.org/show_bug.cgi?id=44472
1155
1156         * DumpRenderTree/chromium/AccessibilityController.cpp:
1157         (AccessibilityController::AccessibilityController):
1158         (AccessibilityController::reset):
1159         (AccessibilityController::getRootElement):
1160         (AccessibilityController::dumpAccessibilityNotifications):
1161         * DumpRenderTree/chromium/AccessibilityController.h:
1162         (AccessibilityController::shouldDumpAccessibilityNotifications):
1163         * DumpRenderTree/chromium/WebViewHost.cpp:
1164         (WebViewHost::didChangeAccessibilityObjectChildren):
1165         * DumpRenderTree/chromium/WebViewHost.h:
1166
1167 2010-08-28  Eric Seidel  <eric@webkit.org>
1168
1169         Reviewed by Adam Barth.
1170
1171         Update commit-queue failure message
1172         https://bugs.webkit.org/show_bug.cgi?id=44798
1173
1174         The commit-queue auto-restarts itself and has for a very long time.
1175         No need for people to email me to request a restart anymore.
1176
1177         * Scripts/webkitpy/common/net/bugzilla.py:
1178         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
1179         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1180
1181 2010-07-27  Jer Noble  <jer.noble@apple.com>
1182
1183         Reviewed by Eric Carlson.
1184
1185         Add JavaScript API to allow a page to go fullscreen.
1186         rdar://problem/6867795
1187         
1188         Added basic full screen support to DumpRenderTree: when a webView requests
1189         that DumpRenderTree go "full screen", just call the provided callback listener object's
1190         will/did Enter/Exit full screen methods.  Also, register a new user default which 
1191         enables full screen support.
1192
1193         * DumpRenderTree/mac/DumpRenderTree.mm:
1194         (resetDefaultsToConsistentValues):
1195         * DumpRenderTree/mac/UIDelegate.mm:
1196         (-[UIDelegate webView:supportsFullscreenForElement:]):
1197         (-[UIDelegate webView:enterFullscreenForElement:listener:]):
1198         (-[UIDelegate webView:exitFullscreenForElement:listener:]):
1199
1200 2010-08-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
1201
1202         Unreviewed. Add myself to the committers list.
1203
1204         * Scripts/webkitpy/common/config/committers.py:
1205
1206 2010-08-27  Kent Tamura  <tkent@chromium.org>
1207
1208         Reviewed by Pavel Feldman.
1209
1210         [DRT/Chromium] Fix inspector test failures
1211         https://bugs.webkit.org/show_bug.cgi?id=44748
1212
1213         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1214         (DRTDevToolsAgent::createClientMessageLoop):
1215           Returns a valid WebKitClientMessageLoop instance
1216         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1217
1218 2010-08-26  Jon Honeycutt  <jhoneycutt@apple.com>
1219
1220         Add Windows WebKit2 Tester to buildbot
1221         <rdar://problem/7887703>
1222
1223         Reviewed by Dan Bernstein.
1224
1225         * BuildSlaveSupport/build.webkit.org-config/config.json:
1226
1227 2010-08-26  Philippe Normand  <pnormand@igalia.com>
1228
1229         Reviewed by Martin Robinson.
1230
1231         [GTK] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
1232         https://bugs.webkit.org/show_bug.cgi?id=42152
1233
1234         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
1235         (LoadHTMLStringItem::invoke): Implementation using
1236         webkit_web_frame_load_string().
1237
1238 2010-08-25  Jon Honeycutt  <jhoneycutt@apple.com>
1239
1240         <rdar://problem/8334338> run-webkit-tests sometimes hangs when using
1241         WebKitTestRunner (44331)
1242
1243         Reviewed by Darin Adler.
1244
1245         * WebKitTestRunner/TestController.cpp:
1246         (WTR::TestController::initialize):
1247         The hang occurs when WebKitTestRunner begins launching the WebKit2
1248         web process then exits before it finishes launching. Work around this by
1249         looking for the --print-supported-features argument and exiting without
1250         creating the web process.
1251
1252 2010-08-26  Dirk Pranke  <dpranke@chromium.org>
1253
1254         Reviewed by Tony Chang.
1255
1256         new-run-webkit-tests: add rebaselining tests for test_expectations
1257         
1258         This patch adds more unit tests for the rebaselining code in the
1259         test_expectations module. It doesn't add any tests for
1260         rebaseline_chromium_webkit_tests itself; that will come some other
1261         time.
1262
1263         https://bugs.webkit.org/show_bug.cgi?id=44648
1264
1265         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1266         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1267
1268 2010-08-26  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1269
1270         Reviewed by Martin Robinson.
1271
1272         [GTK] Add HTTP caching support
1273         https://bugs.webkit.org/show_bug.cgi?id=44261
1274
1275         Ignore new soup API that we decided to merge into the soup backend
1276         while it is being cooked. It follows the libsoup style, and will
1277         be removed from WebKit as soon as it is merged into libsoup.
1278
1279         * Scripts/webkitpy/style/checker.py:
1280
1281 2010-08-26  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1282
1283         Reviewed by Kenneth Rohde Christiansen.
1284
1285         [Qt] DumpRenderTree runs only one test from command mode
1286         https://bugs.webkit.org/show_bug.cgi?id=44012
1287
1288         Enables support to run multiple test files and single
1289         folder containing html files in stand alone mode
1290
1291         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1292         (WebCore::DumpRenderTree::DumpRenderTree):
1293         (WebCore::DumpRenderTree::processArgsLine):
1294         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
1295         (WebCore::DumpRenderTree::processLine):
1296         (WebCore::DumpRenderTree::dump):
1297         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1298         (WebCore::DumpRenderTree::setStandAloneMode):
1299         (WebCore::DumpRenderTree::isStandAloneMode):
1300         * DumpRenderTree/qt/main.cpp:
1301         (main):
1302
1303 2010-08-25  Martin Robinson  <mrobinson@igalia.com>
1304
1305         Updating webkitpy test expectations.
1306
1307         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1308
1309 2010-08-25  Ojan Vafai  <ojan@chromium.org>
1310
1311         Reviewed by Eric Seidel.
1312
1313         fix the always squash git config
1314         https://bugs.webkit.org/show_bug.cgi?id=44651
1315
1316         Fix help text and apparently underscores are not allowed
1317         in git config keys.
1318
1319         * Scripts/webkitpy/common/checkout/scm.py:
1320         * Scripts/webkitpy/tool/steps/commit.py:
1321
1322 2010-08-25  Darin Adler  <darin@apple.com>
1323
1324         Reviewed by John Sullivan.
1325
1326         * Scripts/commit-log-editor: Fix perl warning for people who have no
1327         value for SVN_LOG_EDITOR or CVS_LOG_EDITOR.
1328
1329 2010-08-25  Ojan Vafai  <ojan@chromium.org>
1330
1331         Reviewed by Eric Seidel.
1332
1333         stop blocking commits when the bots are red
1334         https://bugs.webkit.org/show_bug.cgi?id=44644
1335
1336         This check currently is just annoying. It doesn't actually
1337         help keep the tree green. We can always add it back later
1338         if we decide the tree is generally more green.
1339
1340         * Scripts/webkitpy/tool/commands/download_unittest.py:
1341         * Scripts/webkitpy/tool/mocktool.py:
1342         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
1343
1344 2010-08-25  Eric Seidel  <eric@webkit.org>
1345
1346         Reviewed by Simon Fraser.
1347
1348         REGRESSION: media/video-loop.html is timing out on the commit-queue Leopard Bot
1349         https://bugs.webkit.org/show_bug.cgi?id=38912
1350
1351         I know of nothing else to do but skip all media tests for the cq.
1352
1353         * Scripts/webkitpy/tool/steps/runtests.py:
1354
1355 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
1356
1357         Reviewed by Ojan Vafai.
1358
1359         new-run-webkit-tests: add more unit tests for test_expectations
1360         This adds unit tests to cover (almost?) all of the non-rebaselining
1361         functionality.
1362
1363         https://bugs.webkit.org/show_bug.cgi?id=44579
1364
1365         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1366         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1367
1368 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
1369
1370         Reviewed by Ojan Vafai.
1371
1372         new-run-webkit-tests: add more unit tests
1373
1374         This change adds more unit tests for the image_diff, test_failures,
1375         and test_files modules, bringing them to 100% coverage (and adds a
1376         couple tests to run_webkit_tests while we're at it).
1377
1378         This test also turns on the "dryrun" port for testing when run on
1379         the mac, increasing coverage in a few other places.
1380
1381         https://bugs.webkit.org/show_bug.cgi?id=44578
1382
1383         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.checksum: Added.
1384         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.png: Added.
1385         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.txt: Added.
1386         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html.
1387         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.png: Added.
1388         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.txt: Added.
1389         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html.
1390         * Scripts/webkitpy/layout_tests/data/failures/expected/timeout.html: Added.
1391         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
1392         * Scripts/webkitpy/layout_tests/data/resources/README.txt: Added.
1393         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
1394         * Scripts/webkitpy/layout_tests/port/test.py:
1395         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1396
1397 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
1398
1399         Reviewed by Ojan Vafai.
1400
1401         new-run-webkit-tests: add more unit tests for layout_package/printing.py
1402
1403         This change adds more unit tests to get the test coverage to 100%
1404         for the printing module. This code is actually pretty crufty and
1405         has some layering violations that need to be cleaned up but I'll
1406         save that for another CL after we get all the unit tests written and
1407         we fix the multithreading issues. At least now we'll be able to tell
1408         if we break things.
1409
1410         https://bugs.webkit.org/show_bug.cgi?id=44576
1411
1412         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1413         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1414
1415 2010-08-25  Ojan Vafai  <ojan@chromium.org>
1416
1417         Reviewed by Adam Barth.
1418
1419         new-run-webkit-tests should respect set-webkit-configuration
1420         https://bugs.webkit.org/show_bug.cgi?id=44633
1421
1422         Moves the getting of the configuration into the base Port so that
1423         chromium ports use it as well. In the downstream chromium port,
1424         this should still just return Release.
1425
1426         * Scripts/webkitpy/layout_tests/port/base.py:
1427         * Scripts/webkitpy/layout_tests/port/webkit.py:
1428
1429 2010-08-25  Tony Chang  <tony@chromium.org>
1430
1431         Not reviewed, changing svn props for a script.
1432
1433         * Scripts/deduplicate-tests: Added properties svn:executable and svn:eol-style.
1434
1435 2010-08-25  Adam Barth  <abarth@webkit.org>
1436
1437         Reviewed by Eric Seidel.
1438
1439         Remove WebKit2 from core builders
1440         https://bugs.webkit.org/show_bug.cgi?id=44625
1441
1442         This builder was added to the core builders by accident.  It doesn't
1443         appear to be green enough to be a core builder yet.
1444
1445         * Scripts/webkitpy/common/net/buildbot.py:
1446         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1447
1448 2010-08-19  Adam Roben  <aroben@apple.com>
1449
1450         Test that NP_Initialize and NP_GetEntryPoints are called in the
1451         correct order
1452
1453         The order differs between Mac and Windows (see r38858).
1454
1455         Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in
1456         NP_Initialize when loading QuickTime when running
1457         plugins/embed-attributes-setting.html in WebKit2 on Windows
1458
1459         Reviewed by John Sullivan.
1460
1461         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and
1462         a boolean to record whether NP_GetEntryPoints has been called.
1463         (NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been
1464         called yet. This matches Flash and QuickTime's behavior.
1465         (NP_GetEntryPoints): Crash on Mac if NP_Initialize hasn't been called
1466         yet. This matches Silverlight's behavior.
1467
1468 2010-08-25  Martin Robinson  <mrobinson@igalia.com>
1469
1470         Reviewed by Gustavo Noronha Silva.
1471
1472         Cairo and EFL port shouldn't depend on glib.
1473         https://bugs.webkit.org/show_bug.cgi?id=44354
1474
1475         Replace occurrences of GRefPtr and adoptGRef with PlatformRefPtr and
1476         adoptPlatformRef.
1477
1478         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1479         (AccessibilityUIElement::isSelected):
1480
1481 2010-08-25  Ojan Vafai  <ojan@chromium.org>
1482
1483         Fix order of Timothy's email address. The script, and
1484         other tools all assume that the first email is the bugzilla address.
1485
1486         * Scripts/webkitpy/common/config/committers.py:
1487
1488 2010-08-24  Kent Tamura  <tkent@chromium.org>
1489
1490         Reviewed by Pavel Feldman.
1491
1492         [DRT/Chromium] Fix 26 inspector test crashes
1493         https://bugs.webkit.org/show_bug.cgi?id=44580
1494
1495         - DRTDevToolsAgent has a reference to the main WebView. So we
1496           should not clear it in closeDevTools() and should clear it in
1497           ~TestShell().
1498         - DRTDevToolsClient has a reference to a DevTools WebView and no
1499           way to update it. So we should delete DRTDevToolsClient instances
1500           in closeDevTools().
1501
1502         * DumpRenderTree/chromium/TestShell.cpp:
1503         (TestShell::~TestShell):
1504         (TestShell::closeDevTools):
1505
1506 2010-08-24  Eric Seidel  <eric@webkit.org>
1507
1508         Reviewed by Adam Barth.
1509
1510         unicode(Exception(\u"0x1234")) is busted in python 2.5, disable tests which hit this
1511         https://bugs.webkit.org/show_bug.cgi?id=44584
1512
1513         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1514
1515 2010-08-24  Eric Seidel  <eric@webkit.org>
1516
1517         Reviewed by Adam Barth.
1518
1519         commit-queue and EWS bots should report all failures
1520         https://bugs.webkit.org/show_bug.cgi?id=41820
1521
1522         Right now commit-queue/EWS only report failures when the
1523         patch under testing fails.  We should report all failures
1524         to the status server so that we can diagnose when the bots
1525         are wedged w/o needing to log into the machines.
1526
1527         I also reduced the amount of data we upload since we've seen
1528         timeouts during status upload.
1529
1530         * Scripts/webkitpy/common/system/executive.py:
1531         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1532         * Scripts/webkitpy/tool/commands/queues.py:
1533         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1534
1535 2010-08-24  Eric Seidel  <eric@webkit.org>
1536
1537         Reviewed by Adam Barth.
1538
1539         Remove HTML5 parser testing infrastructure now that we don't need it
1540         https://bugs.webkit.org/show_bug.cgi?id=44581
1541
1542         * DumpRenderTree/mac/DumpRenderTree.mm:
1543         (resetDefaultsToConsistentValues):
1544         (initializeGlobalsFromCommandLineOptions):
1545         * Scripts/old-run-webkit-tests:
1546         * Scripts/test-html5-parser: Removed.
1547
1548 2010-08-24  Kent Tamura  <tkent@chromium.org>
1549
1550         Reviewed by Dimitri Glazkov.
1551
1552         [DRT/Chromium] Fix 28 inspector test crashes
1553         https://bugs.webkit.org/show_bug.cgi?id=44574
1554
1555         Reset DevToolsClient and DevToolsAgent before closing a DevTools
1556         WebView in order to avoid accessing to a deleted WebView instance.
1557
1558         * DumpRenderTree/chromium/TestShell.cpp:
1559         (TestShell::closeDevTools):
1560
1561 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
1562
1563         Reviewed by Ojan Vafai.
1564
1565         new-run-webkit-tests: clean up code for test_types, test_failures
1566
1567         Add a bunch of unit tests for webkitpy.layout_tests.test_types and
1568         webkitpy.layout_tests.layout_package.test_failures, and remove
1569         some dead code and otherwise clean up things.
1570
1571         https://bugs.webkit.org/show_bug.cgi?id=44559
1572
1573         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1574         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py: Added.
1575         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1576         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1577         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1578         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: Added.
1579         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1580
1581 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
1582
1583         Reviewed by Eric Seidel.
1584
1585         new-run-webkit-tests: revise unit testing strategy for test failures
1586     
1587         This change revamps the way we store test data for new-run-webkit-tests.
1588         Previously we had a few copies of test files from the main test tree.
1589         Now we have a bunch of completely fake test data and use the test
1590         data to generate different kinds of test failures, getting
1591         much better coverage.
1592
1593         https://bugs.webkit.org/show_bug.cgi?id=44556
1594
1595         * Scripts/webkitpy/layout_tests/data/failures/expected/crash.html: Added.
1596         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.checksum: Added.
1597         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.png: Added.
1598         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.txt: Added.
1599         * Scripts/webkitpy/layout_tests/data/failures/expected/image.html: Added.
1600         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.checksum: Added.
1601         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.png: Added.
1602         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.txt: Added.
1603         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html: Added.
1604         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html: Added.
1605         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_text.html: Added.
1606         * Scripts/webkitpy/layout_tests/data/failures/expected/text-expected.txt: Added.
1607         * Scripts/webkitpy/layout_tests/data/failures/expected/text.html: Added.
1608         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.checksum: Added.
1609         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.png: Added.
1610         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.txt: Added.
1611         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum.html: Added.
1612         * Scripts/webkitpy/layout_tests/data/image/canvas-bg.html: Removed.
1613         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.checksum: Removed.
1614         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.png: Removed.
1615         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.txt: Removed.
1616         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom.html: Removed.
1617         * Scripts/webkitpy/layout_tests/data/misc/crash-expected.txt: Removed.
1618         * Scripts/webkitpy/layout_tests/data/misc/crash.html: Removed.
1619         * Scripts/webkitpy/layout_tests/data/misc/missing-expectation.html: Removed.
1620         * Scripts/webkitpy/layout_tests/data/misc/passing-expected.txt: Removed.
1621         * Scripts/webkitpy/layout_tests/data/misc/passing.html: Removed.
1622         * Scripts/webkitpy/layout_tests/data/passes/image-expected.checksum: Added.
1623         * Scripts/webkitpy/layout_tests/data/passes/image-expected.png: Added.
1624         * Scripts/webkitpy/layout_tests/data/passes/image-expected.txt: Added.
1625         * Scripts/webkitpy/layout_tests/data/passes/image.html: Added.
1626         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.checksum: Added.
1627         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.png: Added.
1628         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.txt: Added.
1629         * Scripts/webkitpy/layout_tests/data/passes/platform_image.html: Added.
1630         * Scripts/webkitpy/layout_tests/data/passes/text-expected.txt: Added.
1631         * Scripts/webkitpy/layout_tests/data/passes/text.html: Added.
1632         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.checksum: Removed.
1633         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.png: Removed.
1634         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.txt: Removed.
1635         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.checksum: Added.
1636         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.png: Added.
1637         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.txt: Added.
1638         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
1639         * Scripts/webkitpy/layout_tests/data/text/article-element-expected.txt: Removed.
1640         * Scripts/webkitpy/layout_tests/data/text/article-element.html: Removed.
1641         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1642         * Scripts/webkitpy/layout_tests/port/test.py:
1643         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1644         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1645
1646 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
1647
1648         Reviewed by Eric Seidel.
1649
1650         speed up new-run-webkit-tests unit tests
1651
1652         Add a --no-record-results flag that turns off generating the JSON
1653         results file on every test run. Generating the file requires us to
1654         fetch the old results down from the bots, which can be slow. This
1655         flag is off by default.
1656     
1657         Reduce the sleep time in wait_for_threads_to_finish from 0.1s to 0.01s.
1658     
1659         These changes together shorten the test cycle from ~4.5s to ~1.5s
1660         - a 3x speedup.
1661
1662         https://bugs.webkit.org/show_bug.cgi?id=44553
1663
1664         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1665         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1666
1667 2010-08-24  Tony Chang  <tony@chromium.org>
1668
1669         Reviewed by Eric Seidel.
1670
1671         [chromium] fix the platform result fallback order on mac/win
1672         https://bugs.webkit.org/show_bug.cgi?id=44483
1673
1674         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1675
1676 2010-08-24  Xan Lopez  <xlopez@igalia.com>
1677
1678         Reviewed by Martin Robinson.
1679
1680         Set a device to the event struct when building with GTK+ 3.x, it's
1681         mandatory.
1682
1683         * DumpRenderTree/gtk/EventSender.cpp:
1684         (keyDownCallback):
1685
1686 2010-08-24  Martin Robinson  <mrobinson@igalia.com>
1687
1688         Reviewed by Xan Lopez.
1689
1690         [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
1691         https://bugs.webkit.org/show_bug.cgi?id=44534
1692
1693         Fix two double-frees introduced in my previous commit.
1694
1695         * DumpRenderTree/gtk/EventSender.cpp:
1696         (contextClickCallback): Copy the event before using it again.
1697         (keyDownCallback): Ditto.
1698
1699 2010-08-24  Martin Robinson  <mrobinson@igalia.com>
1700
1701         Reviewed by Xan Lopez.
1702
1703         [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
1704         https://bugs.webkit.org/show_bug.cgi?id=44534
1705
1706         * DumpRenderTree/gtk/EventSender.cpp:
1707         (prepareMouseButtonEvent): Use gdk_event_new and reference the reference the GdkWindow
1708         when setting it on the event. It is dereferenced by gdk_event_free(...).
1709         (contextClickCallback): Ditto.
1710         (mouseDownCallback): Ditto.
1711         (mouseUpCallback): Ditto.
1712         (mouseMoveToCallback): Ditto.
1713         (mouseWheelToCallback): Ditto.
1714         (sendOrQueueEvent): Take a GdkEvent* instead of a GdkEvent.
1715         (dispatchEvent): Ditto. Also free the event when we are done with it.
1716         (keyDownCallback): Use gdk_event_new and reference the GdkWindow.
1717
1718 2010-08-24  Andras Becsi  <abecsi@webkit.org>
1719
1720         [Qt] WebKit2 build fix.
1721
1722         * Scripts/enumerate-included-framework-headers:
1723         Remove stray global option form sed.
1724
1725 2010-08-24  Kent Tamura  <tkent@chromium.org>
1726
1727         Reviewed by Jeremy Orlow.
1728
1729         [DRT/Chromium] Support for IndexedDB tests
1730         https://bugs.webkit.org/show_bug.cgi?id=44490
1731
1732         * DumpRenderTree/chromium/TestShell.cpp:
1733         (TestShell::TestShell): Enable IndexedDB.
1734
1735 2010-08-23  Martin Robinson  <mrobinson@igalia.com>
1736
1737         Reviewed by Gustavo Noronha Silva.
1738
1739         [GTK] The 64-bit Release bot is showing crashes on tests that use mouse buttons
1740         https://bugs.webkit.org/show_bug.cgi?id=44465
1741
1742         Initialize the axes field of mouse button and motion events to null.
1743         This is the value that should be used for events originating from the
1744         mouse device.
1745
1746         * DumpRenderTree/gtk/EventSender.cpp:
1747         (prepareMouseButtonEvent): Initalize button event axes field to null.
1748         (mouseMoveToCallback): Initialize motion event axes field to null.
1749
1750 2010-08-23  Sheriff Bot  <webkit.review.bot@gmail.com>
1751
1752         Unreviewed, rolling out r65703.
1753         http://trac.webkit.org/changeset/65703
1754         https://bugs.webkit.org/show_bug.cgi?id=44460
1755
1756         "Causing lots of crashes on Snow Leopard when running the
1757         layout tests" (Requested by eseidel2 on #webkit).
1758
1759         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1760         (NP_Initialize):
1761         (NP_GetEntryPoints):
1762
1763 2010-08-23  Jon Honeycutt  <jhoneycutt@apple.com>
1764
1765         Layout tests do not run when using WebKitTestRunner in a Debug build.
1766         https://bugs.webkit.org/show_bug.cgi?id=44409
1767
1768         Reviewed by Dan Bernstein.
1769
1770         * WebKitTestRunner/win/TestControllerWin.cpp:
1771         (WTR::TestController::initializeInjectedBundlePath):
1772         Use InjectedBundle_debug.dll when building Debug.
1773
1774 2010-08-23  Xan Lopez  <xlopez@igalia.com>
1775
1776         Reviewed by Martin Robinson.
1777
1778         [GTK] run-launcher fails if WebKitGTK+ compiled with GTK+-3.0 support
1779         https://bugs.webkit.org/show_bug.cgi?id=42026
1780
1781         If a GTK+ 3.x build is present return that as the library to use,
1782         otherwise fallback to the GTK+ 2.x build.
1783
1784         * Scripts/webkitdirs.pm:
1785
1786 2010-08-23  Balazs Kelemen  <kb@inf.u-szeged.hu>
1787
1788         Reviewed by Ariya Hidayat.
1789
1790         [Qt] Find needed forwarding headers for WebKit2 automatically
1791         https://bugs.webkit.org/show_bug.cgi?id=44336
1792
1793         * MiniBrowser/qt/BrowserWindow.cpp: Use normal (not framework style) includes here.
1794         The new script does not satisfy the needs of this file however using normal includes
1795         is generally better here.
1796         * MiniBrowser/qt/MiniBrowser.pro: Added include paths.
1797         * Scripts/enumerate-included-framework-headers: Enumerates headers included from the 
1798         given frameworks by files in the current directory (and subdirectories).
1799         In the future this needs to be rewritten in perl for being able to use on Windows.
1800
1801 2010-08-22  No'am Rosenthal  <noam.rosenthal@nokia.com>
1802
1803         Reviewed by Ariya Hidayat.
1804
1805         [Qt] Qt test browser: enable a QGLWidget viewport with a command line argument
1806         https://bugs.webkit.org/show_bug.cgi?id=43010
1807
1808         * QtTestBrowser/launcherwindow.cpp:
1809         (LauncherWindow::applyPrefs):
1810         * QtTestBrowser/main.cpp:
1811         (LauncherApplication::handleUserOptions):
1812
1813 2010-08-21  Sam Weinig  <sam@webkit.org>
1814
1815         Reviewed by Dan Bernstein.
1816
1817         Remove specialized retain/release functions in favor of a single one for WKTypeRefs
1818         https://bugs.webkit.org/show_bug.cgi?id=44386
1819
1820         * MiniBrowser/mac/AppDelegate.m:
1821         (didRecieveMessageFromInjectedBundle):
1822         (didNavigateWithNavigationData):
1823         (-[BrowserAppDelegate init]):
1824         (-[BrowserAppDelegate applicationWillTerminate:]):
1825         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
1826         (-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
1827         (-[BrowserStatisticsWindowController dealloc]):
1828         * MiniBrowser/mac/BrowserWindowController.m:
1829         (-[BrowserWindowController initWithPageNamespace:]):
1830         (-[BrowserWindowController fetch:]):
1831         (-[BrowserWindowController windowWillClose:]):
1832         (-[BrowserWindowController applicationTerminating]):
1833         (closePage):
1834         (runJavaScriptAlert):
1835         (runJavaScriptConfirm):
1836         (runJavaScriptPrompt):
1837         (-[BrowserWindowController updateProvisionalURLForFrame:]):
1838         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1839         (didClearWindowObjectForFrame):
1840         * MiniBrowser/win/BrowserView.cpp:
1841         (BrowserView::goToURL):
1842         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1843         (WTR::PlatformWebView::~PlatformWebView):
1844
1845 2010-08-20  Benjamin Poulain  <benjamin.poulain@nokia.com>
1846
1847         Reviewed by Kenneth Rohde Christiansen.
1848
1849         WebKit does not build with Python 2.3
1850         https://bugs.webkit.org/show_bug.cgi?id=44373
1851
1852         Replaced the function sorted() by a call to sort()
1853         on the entry list.
1854         The function sorted() has been added to Python 2.4.
1855         The function method sort() of List works with older
1856         versions of Python.
1857
1858         * Scripts/create-html-entity-table:
1859
1860 2010-08-20  Martin Robinson  <mrobinson@igalia.com>
1861
1862         Reviewed by Pavel Feldman.
1863
1864         Web Inspector: Inspector tests were disabled for GTK.
1865         https://bugs.webkit.org/show_bug.cgi?id=43977
1866
1867         * Scripts/old-run-webkit-tests: Set the WEBKIT_INSPECTOR_PATH to the appropriate
1868         path before running tests.
1869
1870 2010-08-20  Daniel Bates  <dbates@rim.com>
1871
1872         Reviewed by Eric Seidel.
1873
1874         svn-apply doesn't detect empty line with Windows line endings
1875         after property value
1876         https://bugs.webkit.org/show_bug.cgi?id=43981
1877
1878         Part 2 of 2
1879
1880         Add unit tests that were not landed in the first commit.
1881
1882         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
1883           - Added the following test cases:
1884             "SVN: binary file (isBinary true) using Windows line endings"
1885             "SVN: property diff, followed by file change diff using Windows line endings"
1886             "SVN: two consecutive property diffs using Windows line endings"
1887             "SVN: binary file with executable bit change usng Windows line endings"
1888             "SVN: binary file followed by property change on different file using Windows line endings"
1889             "SVN: binary file followed by file change on different file using Windows line endings"
1890             "SVN: file change diff with property change, followed by property change diff using Windows line endings"
1891             "SVN: file change diff with property change, followed by file change diff using Windows line endings"
1892         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
1893           - Added the following test cases:
1894             "add svn:executable, followed by empty line and start of next diff using Windows line endings"
1895             "add svn:executable, followed by empty line and start of next property diff using Windows line endings"
1896             "multi-line '+' change, followed by empty line and start of next diff using Windows line endings"
1897             "multi-line '+' change, followed by empty line and start of next property diff using Windows line endings"
1898             "add svn:executable, followed by empty line and start of binary patch using Windows line endings"
1899             "multi-line '+' change, followed by empty line and start of binary patch using Windows line endings"
1900             "multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings"
1901             "single-line '+' with trailing new line using Windows line endings"
1902             "single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings"
1903             "single-line '-' change with trailing new line, and single-line '+' change using Windows line endings"
1904             "multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
1905         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
1906           - Added the following test cases:
1907             "single-line '-' change followed by empty line with Windows line endings"
1908             "multi-line '+' change and start of binary patch with Windows line endings"
1909
1910 2010-08-20  Daniel Bates  <dbates@rim.com>
1911
1912         Reviewed by Eric Seidel.
1913
1914         svn-apply doesn't detect empty line with Windows line endings
1915         after property value
1916         https://bugs.webkit.org/show_bug.cgi?id=43981
1917
1918         Fixes an issue where an empty line following the property value
1919         in an SVN property change diff would not be detected if it had
1920         Windows line endings (i.e. ended in CRLF). Hence it was consumed
1921         as if it was part of a multi-line property value. 
1922
1923         * Scripts/VCSUtils.pm:
1924           - Modified parseSvnPropertyValue() to detect empty line
1925             with Windows line endings.
1926           - Added toWindowsLineEndings().
1927         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
1928           - Added the following test cases:
1929             "SVN: binary file (isBinary true) using Windows line endings"
1930             "SVN: property diff, followed by file change diff using Windows line endings"
1931             "SVN: two consecutive property diffs using Windows line endings"
1932             "SVN: binary file with executable bit change usng Windows line endings"
1933             "SVN: binary file followed by property change on different file using Windows line endings"
1934             "SVN: binary file followed by file change on different file using Windows line endings"
1935             "SVN: file change diff with property change, followed by property change diff using Windows line endings"
1936             "SVN: file change diff with property change, followed by file change diff using Windows line endings"
1937         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
1938           - Added the following test cases:
1939             "add svn:executable, followed by empty line and start of next diff using Windows line endings"
1940             "add svn:executable, followed by empty line and start of next property diff using Windows line endings"
1941             "multi-line '+' change, followed by empty line and start of next diff using Windows line endings"
1942             "multi-line '+' change, followed by empty line and start of next property diff using Windows line endings"
1943             "add svn:executable, followed by empty line and start of binary patch using Windows line endings"
1944             "multi-line '+' change, followed by empty line and start of binary patch using Windows line endings"
1945             "multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings"
1946             "single-line '+' with trailing new line using Windows line endings"
1947             "single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings"
1948             "single-line '-' change with trailing new line, and single-line '+' change using Windows line endings"
1949             "multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
1950         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
1951           - Added the following test cases:
1952             "single-line '-' change followed by empty line with Windows line endings"
1953             "multi-line '+' change and start of binary patch with Windows line endings"
1954
1955 2010-08-19  David Kilzer  <ddkilzer@apple.com>
1956
1957         BUILD FIX: Fix Mac build after Windows WebKit2 changes for Netscape Plug-ins
1958
1959         * MiniBrowser/mac/BrowserWindowController.m:
1960         (decidePolicyForNavigationAction): Updated method signature.
1961         (decidePolicyForNewWindowAction): Updated method signature.
1962
1963 2010-08-19  Adam Roben  <aroben@apple.com>
1964
1965         Test that NP_Initialize and NP_GetEntryPoints are called in the
1966         correct order
1967
1968         The order differs between Mac and Windows (see r38858).
1969
1970         Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in
1971         NP_Initialize when loading QuickTime when running
1972         plugins/embed-attributes-setting.html in WebKit2 on Windows
1973
1974         Reviewed by Sam Weinig.
1975
1976         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and
1977         a boolean to record whether NP_GetEntryPoints has been called.
1978         (NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been
1979         called yet. This matches Flash and QuickTime's behavior. Crash on Mac
1980         if NP_GetEntryPoints has been called already. This matches
1981         Silverlight's behavior.
1982
1983 2010-08-19  Adam Roben  <aroben@apple.com>
1984
1985         Make build-webkittestrunner build TestNetscapePlugIn on Windows
1986
1987         Fixes <http://webkit.org/b/44268> <rdar://problem/8330388>
1988
1989         Reviewed by Sam Weinig.
1990
1991         * WebKitTestRunner/WebKitTestRunner.sln: Added TestNetscapePlugIn.
1992         Threaded it in between ImageDiff and InjectedBundleGenerated.
1993
1994 2010-08-19  Ojan Vafai  <ojan@chromium.org>
1995
1996         Reviewed by Adam Barth.
1997
1998         install rietveld's upload script from a versioned url
1999         https://bugs.webkit.org/show_bug.cgi?id=44291
2000
2001         autoinstall expects the file at a given URL to never change.
2002         In order to be able to update the file, we need to be able to
2003         change the path.
2004
2005         * Scripts/webkitpy/thirdparty/__init__.py:
2006
2007 2010-08-19  Ojan Vafai  <ojan@chromium.org>
2008
2009         Reviewed by Adam Barth.
2010
2011         add --webkit_patch_id to reitveld uploads
2012         https://bugs.webkit.org/show_bug.cgi?id=44289
2013
2014         This is the first step in having rietveld store which
2015         patches have been uploaded and getting rid of the
2016         in-rietveld flag.
2017
2018         * Scripts/webkitpy/common/net/rietveld.py:
2019         * Scripts/webkitpy/tool/mocktool.py:
2020         * Scripts/webkitpy/tool/steps/postcodereview.py:
2021
2022 2010-08-19  Kenneth Russell  <kbr@google.com>
2023
2024         Reviewed by David Levin.
2025
2026         Adjust my status from committer to reviewer
2027         https://bugs.webkit.org/show_bug.cgi?id=44277
2028
2029         * Scripts/webkitpy/common/config/committers.py:
2030
2031 2010-08-19  Pavel Feldman  <pfeldman@chromium.org>
2032
2033         Reviewed by Yury Semikhatsky.
2034
2035         Chromium DevTools: remove injected script fetcher from test harness.
2036         https://bugs.webkit.org/show_bug.cgi?id=44266
2037
2038         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2039         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2040
2041 2010-08-19  Pavel Feldman  <pfeldman@chromium.org>
2042
2043         Reviewed by Yury Semikhatsky.
2044
2045         Chromium DevTools: There is no need in resource-based InjectedScript.js source.
2046         Now that we populate front-end after its onload handler, we don't need
2047         to install injected script early. Exposing injected script source on the WebCore
2048         level here.
2049         https://bugs.webkit.org/show_bug.cgi?id=44029
2050
2051         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2052         (DRTDevToolsAgent::runtimePropertyChanged):
2053         (DRTDevToolsAgent::delayedFrontendLoaded):
2054         (DRTDevToolsAgent::frontendLoaded):
2055         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2056
2057 2010-08-19  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2058
2059         Reviewed by Kenneth Rohde Christiansen.
2060
2061         [Gtk] Enable view mode media feature layout test
2062         https://bugs.webkit.org/show_bug.cgi?id=43278
2063
2064         Add view mode media feature testing infrastructure, and add
2065         placeholder methods for the other platforms'
2066         LayoutTestControllers.
2067
2068         * DumpRenderTree/LayoutTestController.cpp:
2069         (setViewModeMediaFeatureCallback):
2070         (LayoutTestController::staticFunctions):
2071         * DumpRenderTree/LayoutTestController.h:
2072         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2073         (LayoutTestController::setViewModeMediaFeature):
2074         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2075         (LayoutTestController::setViewModeMediaFeature):
2076         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2077         (LayoutTestController::setViewModeMediaFeature):
2078         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2079         (LayoutTestController::setViewModeMediaFeature):
2080
2081 2010-08-18  Mark Rowe  <mrowe@apple.com>
2082
2083         Reviewed by Sam Weinig.
2084
2085         Make it so the WebKit2 test slave runs the WebKit2 tests
2086
2087         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2088
2089 2010-08-18  Sam Weinig  <sam@webkit.org>
2090
2091         Reviewed by Mark Rowe.
2092
2093         Make run-webkit-tests --webkit-test-runner build DumpRenderTree
2094         in addition to WebKitTestRunner to get the DumpRenderTreeSupport
2095         module and the TestNetscapePlugin.
2096
2097         * Scripts/old-run-webkit-tests:
2098
2099 2010-08-18  Adam Roben  <aroben@apple.com>
2100
2101         Fix hang when saving crash logs on Windows
2102
2103         * Scripts/old-run-webkit-tests:
2104         (setUpWindowsCrashLogSaving):
2105         (END):
2106         Pass -s to regtool so it will write the Auto value as a string instead
2107         of as a number. This was causing a "do you want to debug?" dialog to
2108         appear.
2109
2110 2010-08-17  Victor Wang  <victorw@chromium.org>
2111
2112         Unreviewed. Fixed chromium incremental test json upload.
2113         Quote builder name and test results server in url.
2114
2115         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2116
2117 2010-08-17  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2118
2119         Reviewed by Ariya Hidayat.
2120
2121         [Qt] [Symbian] Consistently use Q_OS_SYMBIAN to guard all Symbian platform dependencies
2122         https://bugs.webkit.org/show_bug.cgi?id=44124
2123
2124         Q_WS_S60 is not defined for Symbian^4 devices as Q_WS_S60 used to guard 
2125         Avkon UI framework dependencies. Use Q_OS_SYMBIAN everywhere to mark
2126         Symbian dependencies.
2127
2128         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2129         (WebCore::DumpRenderTree::open):
2130         * QtTestBrowser/launcherwindow.cpp:
2131         (LauncherWindow::init):
2132         (LauncherWindow::toggleFullScreenMode):
2133         (LauncherWindow::showFPS):
2134         (LauncherWindow::updateFPS):
2135         * QtTestBrowser/launcherwindow.h:
2136         (WindowOptions::WindowOptions):
2137         * QtTestBrowser/mainwindow.cpp:
2138         (MainWindow::buildUI):
2139
2140 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
2141
2142         Reviewed by David Levin.
2143
2144         new-run-webkit-tests: remove --show-sources option
2145
2146         --show-sources is pretty much obsolete with --trace everything, so
2147         I'm removing it.
2148
2149         Also rename a couple of methods in the TestTextDiff class to make their
2150         intended visibility (private) more obvious.
2151
2152         https://bugs.webkit.org/show_bug.cgi?id=44143
2153
2154         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2155         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2156         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2157         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2158         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2159
2160 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
2161
2162         Reviewed by David Levin.
2163
2164         remove --fuzzy-image-diff in new-run-webkit-tests (it doesn't work)
2165
2166         This code bit-rotted at some point more than a year ago, and nobody seems
2167         to miss it. old-run-webkit-tests has a --tolerance flag that new-run-webkit-tests
2168         should support instead, making this flag unnecessary anyway.
2169
2170         https://bugs.webkit.org/show_bug.cgi?id=44141
2171
2172         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2173         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2174         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Removed.
2175
2176 2010-08-17  Victor Wang  <victorw@chromium.org>
2177
2178         Reviewed by Ojan Vafai.
2179
2180         Update json results generator to have incremental json including
2181         results for tests that pass in current run but failed before.
2182
2183         https://bugs.webkit.org/show_bug.cgi?id=44119
2184
2185         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2186         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2187         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2188
2189 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
2190
2191         Reviewed by Eric Seidel.
2192
2193         fix test-webkitpy, add easy way to find a checkout root
2194
2195         test-webkitpy currently doesn't work right if run from someplace other
2196         than the checkout root, and it spews a bunch of debug logging because
2197         the deduplicate_tests tests contaminates the test environment.
2198
2199         This patch cleans up the deduplicate_tests unit tests, and creates
2200         two new methods in scm.py: find_checkout_root() and default_scm(),
2201         both of which use a single algorithm for guessing what checkout root
2202         to use if you aren't explicitly told one from a path.
2203
2204         https://bugs.webkit.org/show_bug.cgi?id=44001
2205
2206         * Scripts/deduplicate-tests:
2207         * Scripts/webkitpy/common/checkout/scm.py:
2208         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2209         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
2210         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2211         * Scripts/webkitpy/layout_tests/port/test.py:
2212         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2213         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2214         * Scripts/webkitpy/tool/main.py:
2215
2216 2010-08-17  Victor Wang  <victorw@chromium.org>
2217
2218         Reviewed by Ojan Vafai.
2219
2220         Add support to the test results server for downloading json that
2221         contains test list only.
2222
2223         This is for json results generator to generate incremental json
2224         results so that it includes results not only for tests failed in
2225         current run, but also tests failed before.
2226
2227         Also set the results type to "N" (no data) instead of "P" (pass)
2228         if test results cannot be found in incremental json file.
2229
2230         https://bugs.webkit.org/show_bug.cgi?id=44117
2231
2232         * TestResultServer/handlers/testfilehandler.py:
2233         * TestResultServer/model/jsonresults.py:
2234         * TestResultServer/model/jsonresults_unittest.py:
2235
2236 2010-08-17  Adam Roben  <aroben@apple.com>
2237
2238         Use the right path style
2239
2240         * Scripts/old-run-webkit-tests:
2241
2242 2010-08-17  Adam Roben  <aroben@apple.com>
2243
2244         Fix typo
2245
2246         * Scripts/old-run-webkit-tests:
2247
2248 2010-08-17  Adam Roben  <aroben@apple.com>
2249
2250         Don't hang when running run-webkit-tests as a non-Administrator on
2251         Vista/7
2252
2253         * Scripts/old-run-webkit-tests:
2254         (setUpWindowsCrashLogSaving): Use regtool to set NTSD as the
2255         post-mortem debugger, rather than using NTSD itself. The latter waits
2256         for user input when it fails to set the registry values; the former
2257         does not.
2258
2259 2010-08-17  Adam Roben  <aroben@apple.com>
2260
2261         Teach run-webkit-tests, DumpRenderTree, and WebKitTestRunner how to
2262         save crash logs on Windows
2263
2264         The crash logs are saved to /tmp/layout-test-results and have names
2265         like CrashLog_02bc_2010-08-17_14-36-20-108.txt.
2266
2267         Unfortunately, crashes in the WebKit2 web process are recorded as
2268         time-outs by run-webkit-tests. Fixing this is covered by
2269         <http://webkit.org/b/44121>.
2270
2271         Fixes <http://webkit.org/b/37859> <rdar://problem/7883560>
2272         DumpRenderTree should save a stack trace and/or dump file when it
2273         crashes
2274
2275         Reviewed by Sam Weinig.
2276
2277         * DumpRenderTree/win/DumpRenderTree.cpp:
2278         (exceptionFilter):
2279         (main):
2280         * WebKitTestRunner/win/TestControllerWin.cpp:
2281         (WTR::exceptionFilter):
2282         (WTR::TestController::platformInitialize):
2283         These changes set up an exception filter that prints #CRASHED to
2284         stderr, then lets the exception propagate normally. This allows
2285         run-webkit-tests to detect when we've crashed even when a post-mortem
2286         debugger attaches to the process.
2287
2288         * Scripts/old-run-webkit-tests:
2289         (top level): Declared some variables used by the crash-log-saving
2290         code.
2291         (openDumpTool): Copy _NT_SYMBOL_PATH into the clean environment so
2292         that the post-mortem debugger has access to it.
2293         (toCygwinPath): Added. This is the opposite of toWindowsPath.
2294         (readFromDumpToolWithTimer): If the dump tool prints #CRASHED to
2295         stderr, consider it a crash.
2296         (setUpWindowsCrashLogSaving): Added. Saves the current post-mortem
2297         debugger, then sets ntsd as the post-mortem debugger. ntsd is
2298         configured to save a crash log and then quit automatically.
2299         (END): Added. Restores the previous post-mortem debugger when the
2300         script exits.
2301
2302 2010-08-17  Victor Wang  <victorw@chromium.org>
2303
2304         Reviewed by ojan@chromium.org.
2305
2306         Update test results server:
2307         1. Normalize test results and times after merging (prune tests where
2308            all runs pass or do not have data, truncate all test items to max
2309            number of builds)
2310         2. times should be int not string.
2311         3. when inserting a new test item, should keep old data regardless
2312            whether or not they have same item type with new one.
2313
2314         https://bugs.webkit.org/show_bug.cgi?id=43861
2315
2316         * TestResultServer/model/jsonresults.py:
2317         * TestResultServer/model/jsonresults_unittest.py:
2318
2319 2010-08-16  Sam Weinig  <sam@webkit.org>
2320
2321         Reviewed by Mark Rowe.
2322
2323         Add WebKit2 Mac tester to buildbot.
2324
2325         * BuildSlaveSupport/build.webkit.org-config/config.json:
2326         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2327
2328 2010-08-16  Paul Sawaya  <psawaya@apple.com>
2329
2330         Reviewed by Chris Marrin.
2331
2332         Added shader validation via ANGLE
2333         https://bugs.webkit.org/show_bug.cgi?id=42405
2334
2335         Added ANGLE to webkit build
2336
2337         * Scripts/build-webkit:
2338
2339 2010-08-16  Kevin Ollivier  <kevino@theolliviers.com>
2340
2341         [wx] Build fix, do not build WebCore as a convenience library as this leads to
2342         errors in the Win build w/export symbols and causes problems with DOM bindings
2343         debugging in gdb.
2344
2345         * DumpRenderTree/wscript:
2346         * Scripts/build-webkit:
2347         * wx/browser/wscript:
2348         * wx/build/settings.py:
2349         * wx/build/waf_extensions.py:
2350
2351 2010-08-16  Dan Bernstein  <mitz@apple.com>
2352
2353         Build fix.
2354
2355         * WebKitTestRunner/TestController.cpp:
2356         (WTR::createOtherPage): Initialize the contentsSizeChanged member.
2357         (WTR::TestController::initialize): Ditto.
2358
2359 2010-08-16  Balazs Kelemen  <kb@inf.u-szeged.hu>
2360
2361         Reviewed by Kenneth Rohde Christiansen.
2362
2363         Handle content size change in WebKit2
2364         Re-landing after fix.
2365
2366         https://bugs.webkit.org/show_bug.cgi?id=43198
2367
2368         * MiniBrowser/mac/BrowserWindowController.m:
2369         (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
2370         * MiniBrowser/win/BrowserView.cpp:
2371         (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.
2372
2373 2010-08-16  Sheriff Bot  <webkit.review.bot@gmail.com>
2374
2375         Unreviewed, rolling out r65419.
2376         http://trac.webkit.org/changeset/65419
2377         https://bugs.webkit.org/show_bug.cgi?id=44053
2378
2379         Broke the Windows build (Requested by bbandix on #webkit).
2380
2381         * MiniBrowser/mac/BrowserWindowController.m:
2382         (-[BrowserWindowController awakeFromNib]):
2383         * MiniBrowser/win/BrowserView.cpp:
2384         (BrowserView::create):
2385
2386 2010-08-16  Balazs Kelemen  <kb@inf.u-szeged.hu>
2387
2388         Reviewed by Kenneth Rohde Christiansen.
2389
2390         Handle content size change in WebKit2
2391
2392         https://bugs.webkit.org/show_bug.cgi?id=43198
2393
2394         * MiniBrowser/mac/BrowserWindowController.m:
2395         (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
2396         * MiniBrowser/win/BrowserView.cpp:
2397         (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.
2398
2399 2010-08-16  Ariya Hidayat  <ariya@sencha.com>
2400
2401         Add my new email address to committers.py.
2402
2403         * Scripts/webkitpy/common/config/committers.py:
2404
2405 2010-08-16  Zoltan Horvath  <zoltan@webkit.org>
2406
2407         Add my old e-mail addresses to committers.py.
2408
2409         * Scripts/webkitpy/common/config/committers.py:
2410
2411 2010-08-15  Jon Honeycutt  <jhoneycutt@apple.com>
2412
2413         WebEditorClient::didBeginEditing is never called in WebKit2
2414         https://bugs.webkit.org/show_bug.cgi?id=42939
2415
2416         Reviewed by Sam Weinig.
2417
2418         * WebKitTestRunner/PlatformWebView.h:
2419         Declare focus().
2420
2421         * WebKitTestRunner/TestController.cpp:
2422         (WTR::TestController::resetStateToConsistentValues):
2423         Focus the PlatformWebView.
2424
2425         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2426         (WTR::PlatformWebView::focus):
2427         Stubbed.
2428
2429         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2430         (WTR::PlatformWebView::focus):
2431         Focus the view.
2432
2433 2010-08-15  Jon Honeycutt  <jhoneycutt@apple.com>
2434
2435         run-webkit-tests should not strip editing callbacks when using
2436         WebKitTestRunner on Windows
2437         https://bugs.webkit.org/show_bug.cgi?id=44000
2438
2439         Reviewed by Mark Rowe.
2440
2441         * Scripts/old-run-webkit-tests:
2442         Leave $stripEditingCallbacks undefined until we look for command-line
2443         arguments. If using WebKit2, set it to 0 if not explicity set on the
2444         command line. Later, set it to isCygwin() to match old behavior if it is
2445         not yet defined.
2446
2447 2010-08-15  Kevin Ollivier  <kevino@theolliviers.com>
2448
2449         [wx] Build fix, remove define always set to the correct value by wtf/Platform.h.
2450
2451         * wx/build/settings.py:
2452
2453 2010-08-14  Martin Robinson  <mrobinson@igalia.com>
2454
2455         Reviewed by Kenneth Rohde Christiansen.
2456
2457         [GTK] autogen.sh not executed if build-webkit options change
2458         https://bugs.webkit.org/show_bug.cgi?id=42266
2459
2460         Rerun autogen.sh in situations where the arguments to build-webkit have
2461         changed since the previous build. This will fix some issues on the bots
2462         where the build does not notice changes to default build-webkit arguments.
2463
2464         * Scripts/webkitdirs.pm: Add special logic for detecting changes to build-webkit arguments.
2465
2466 2010-08-14  Eric Seidel  <eric@webkit.org>
2467
2468         Unreviewed.  Another fix to support python 2.3.
2469
2470         Add support for MathML entities
2471         https://bugs.webkit.org/show_bug.cgi?id=43949
2472
2473         * Scripts/webkitpy/thirdparty/simplejson/decoder.py:
2474          - It looks like our simplejson is version 1.7.3 which
2475            should be python 2.3 compatible.  But someone modified
2476            our copy slightly from the original source.
2477            I've removed the relative import in hopes this fixes
2478            the problem.
2479
2480 2010-08-13  Eric Seidel  <eric@webkit.org>
2481
2482         Unreviewed.  Build fix only.
2483
2484         Add support for MathML entities
2485         https://bugs.webkit.org/show_bug.cgi?id=43949
2486
2487         * Scripts/create-html-entity-table:
2488          - Hack sys.path to avoid executing 2.5 dependent python
2489            on systems (like chromium-win and Tiger) which do not have 2.5 python.
2490
2491 2010-08-13  Adam Barth  <abarth@webkit.org>
2492
2493         Reviewed by Eric Seidel.
2494
2495         Rename some concepts in HTML entity search to be more self-documenting
2496         https://bugs.webkit.org/show_bug.cgi?id=44004
2497
2498         Reflect name change in generator script.
2499
2500         * Scripts/create-html-entity-table:
2501
2502 2010-08-12  Adam Barth  <abarth@webkit.org>
2503
2504         Reviewed by Eric Seidel.
2505
2506         Add support for MathML entities
2507         https://bugs.webkit.org/show_bug.cgi?id=43949
2508
2509         A script for generating the C++ state data structure describing all the
2510         entities from a JSON description.
2511
2512         * Scripts/create-html-entity-table: Added.
2513
2514 2010-08-13  Dirk Pranke  <dpranke@chromium.org>
2515
2516         Reviewed by Eric Seidel.
2517
2518         Rewrite new-run-webkit-test's wait_for_threads_to_finish loop to
2519         check for exceptions on all threads, not just the first thread.
2520         
2521         This change also changes the logging behavior for wedged threads
2522         to only dump the stacks of threads that are actually wedged.
2523
2524         Refactor the thread classes in the dump_render_tree_thread module
2525         to make the contract between TestRunner and TestShellThread clearer.
2526
2527         Added a bunch of unit tests.
2528         https://bugs.webkit.org/show_bug.cgi?id=38561
2529
2530         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2531         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2532         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2533
2534 2010-08-13  Kenichi Ishibashi  <bashi@google.com>
2535
2536         Reviewed by Shinichiro Hamaji.
2537
2538         Add test_expectations.txt syntax checker to check-webkit-style.
2539         https://bugs.webkit.org/show_bug.cgi?id=43899
2540
2541         Just utilizing layout_tests/layout_package/test_expectations.py for checking
2542         the syntax of test_expectations.txt.
2543         This change also moves tab checking class from style/checkers/text.py to
2544         style/checkers/common.py for sharing code.
2545
2546         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2547         * Scripts/webkitpy/style/checker.py:
2548         * Scripts/webkitpy/style/checkers/common.py:
2549         * Scripts/webkitpy/style/checkers/common_unittest.py:
2550         * Scripts/webkitpy/style/checkers/test_expectations.py: Added.
2551         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Added.
2552         * Scripts/webkitpy/style/checkers/text.py:
2553         * Scripts/webkitpy/style_references.py:
2554
2555 2010-08-12  Jon Honeycutt  <jhoneycutt@apple.com>
2556
2557         WebKitTestRunner does not correctly resize WebView for W3C SVG tests
2558         https://bugs.webkit.org/show_bug.cgi?id=43945
2559
2560         Reviewed by Sam Weinig.
2561
2562         * WebKitTestRunner/TestInvocation.cpp:
2563         (WTR::sizeWebViewForCurrentTest):
2564         Allow for a Windows-style path.
2565
2566         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2567         (WTR::PlatformWebView::resizeTo):
2568         Call SetWindowPos to resize the view window.
2569
2570 2010-08-12  David Levin  <levin@chromium.org>
2571
2572         Build break fix.
2573
2574         * WebKitTestRunner/TestController.cpp:
2575         (WTR::TestController::resetStateToConsistentValues): Removed usage
2576         of a variable that doesn't exist in the class.
2577
2578 2010-08-12  Jon Honeycutt  <jhoneycutt@apple.com>
2579
2580         WebKitTestRunner needs to run tests without using native controls
2581         https://bugs.webkit.org/show_bug.cgi?id=43772
2582
2583         Reviewed by Sam Weinig.
2584
2585         * WebKitTestRunner/TestController.cpp:
2586         (WTR::TestController::initialize):
2587         Call platformInitializeContext().
2588
2589         * WebKitTestRunner/TestController.h:
2590         Declare platformInitializeContext().
2591
2592         * WebKitTestRunner/mac/TestControllerMac.mm:
2593         (WTR::TestController::platformInitializeContext):
2594         Stubbed.
2595
2596         * WebKitTestRunner/win/TestControllerWin.cpp:
2597         (WTR::TestController::platformInitializeContext):
2598         Call WKContextSetShouldPaintNativeControls() to disable native control
2599         drawing.
2600
2601 2010-08-12  Sam Weinig  <sam@webkit.org>
2602
2603         Reviewed by Alexey Proskuryakov.
2604
2605         WebKitTestRunner should be more aggressive about ensuring consistent state between tests
2606         https://bugs.webkit.org/show_bug.cgi?id=43653
2607
2608         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2609         (WTR::InjectedBundle::InjectedBundle):
2610         (WTR::InjectedBundle::didReceiveMessage):
2611         (WTR::InjectedBundle::beginTesting):
2612         (WTR::InjectedBundle::done):
2613         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2614         (WTR::InjectedBundle::isTestRunning):
2615         (WTR::InjectedBundle::):
2616         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2617         (WTR::InjectedBundlePage::stopLoading):
2618         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
2619         (WTR::InjectedBundlePage::dump):
2620         (WTR::InjectedBundlePage::didFinishLoadForFrame):
2621         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
2622         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
2623         (WTR::InjectedBundlePage::didClearWindowForFrame):
2624         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
2625         (WTR::InjectedBundlePage::willAddMessageToConsole):
2626         (WTR::InjectedBundlePage::willSetStatusbarText):
2627         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
2628         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
2629         (WTR::InjectedBundlePage::shouldBeginEditing):
2630         (WTR::InjectedBundlePage::shouldEndEditing):
2631         (WTR::InjectedBundlePage::shouldInsertNode):
2632         (WTR::InjectedBundlePage::shouldInsertText):
2633         (WTR::InjectedBundlePage::shouldDeleteRange):
2634         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
2635         (WTR::InjectedBundlePage::shouldApplyStyle):
2636         (WTR::InjectedBundlePage::didBeginEditing):
2637         (WTR::InjectedBundlePage::didEndEditing):
2638         (WTR::InjectedBundlePage::didChange):
2639         (WTR::InjectedBundlePage::didChangeSelection):
2640         Don't do any work if we are not currently running a test.
2641
2642         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2643         * WebKitTestRunner/StringFunctions.h:
2644         (WTR::toCF):
2645         Add conversion function for WKURLRef -> CFURLRef
2646
2647         * WebKitTestRunner/TestController.cpp:
2648         (WTR::TestController::TestController):
2649         (WTR::TestController::initialize):
2650         (WTR::TestController::resetStateToConsistentValues):
2651         (WTR::TestController::runTest):
2652         (WTR::TestController::didFinishLoadForFrame):
2653         * WebKitTestRunner/TestController.h:
2654         (WTR::TestController::):
2655         * WebKitTestRunner/TestInvocation.cpp:
2656         (WTR::TestInvocation::invoke):
2657         * WebKitTestRunner/TestInvocation.h:
2658         Move resetting code to TestController.
2659
2660         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2661         * WebKitTestRunner/mac/TestControllerMac.mm:
2662         (WTR::TestController::runUntil):
2663         * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
2664         * WebKitTestRunner/win/TestControllerWin.cpp:
2665         (WTR::TestController::runUntil):
2666         * WebKitTestRunner/win/TestInvocationWin.cpp: Removed.
2667         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2668         Move runUntil to TestController.
2669
2670 2010-08-12  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2671
2672         Unreviewed.
2673
2674         Adding myself to the committers list.
2675
2676         * Scripts/webkitpy/common/config/committers.py:
2677
2678 2010-08-12  Hayato Ito  <hayato@chromium.org>
2679
2680         Reviewed by Tony Chang.
2681
2682         Merge pretty printers for gdb.
2683         https://bugs.webkit.org/show_bug.cgi?id=43850
2684
2685         We need to update webcore.py because basic string classes have moved to WTF from WebCore.
2686         It is good timing to merge webcore.py and wtf.py and name it 'webkit.py'.
2687         webcore.py is left for backward compatibility.
2688
2689         * gdb/webcore.py:
2690         * gdb/webkit.py: Added.
2691         * gdb/wtf.py: Removed.
2692
2693 2010-08-11  Tony Chang  <tony@chromium.org>
2694
2695         Reviewed by David Levin.
2696
2697         [chromium] add google-chrome layout test result directories
2698         https://bugs.webkit.org/show_bug.cgi?id=43889
2699
2700         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2701         * Scripts/webkitpy/layout_tests/port/factory.py:
2702         * Scripts/webkitpy/layout_tests/port/google_chrome.py: Added.
2703         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2704
2705 2010-08-11  Kent Tamura  <tkent@chromium.org>
2706
2707         Reviewed by Dimitri Glazkov.
2708
2709         [DRT/Chromium] Disable accelerated compositing
2710         https://bugs.webkit.org/show_bug.cgi?id=43894
2711
2712         Disable accelerated compositing because DRT is not ready for
2713         it. This change fixes hundreds of test crashes on Windows and
2714         Linux.
2715
2716         * DumpRenderTree/chromium/TestShell.cpp:
2717         (TestShell::resetWebSettings):
2718
2719 2010-08-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2720
2721         Unreviewed. Adding my Collabora personality to the list.
2722
2723         * Scripts/webkitpy/common/config/committers.py:
2724
2725 2010-08-11  Martin Robinson  <mrobinson@igalia.com>
2726
2727         Adding myself as a reviewer.
2728
2729         * Scripts/webkitpy/common/config/committers.py:
2730
2731 2010-08-11  Daniel Bates  <dbates@rim.com>
2732
2733         Reviewed by Darin Adler.
2734
2735         Perl warnings when running commit-log-editor
2736         https://bugs.webkit.org/show_bug.cgi?id=43856
2737
2738         Fixes Perl warnings introduced by the patch for Bug #40548.
2739
2740         Perl doesn't have symbolic names for True/False. Instead, we
2741         should use boolean values. Moreover, the variable installedEditorApplication
2742         is not be used and should be renamed builtEditorApplication so that it
2743         uses the existing machinery to set the commit log editor application.
2744
2745         * Scripts/commit-log-editor:
2746
2747 2010-08-11  Adam Barth  <abarth@webkit.org>
2748
2749         Reviewed by Eric Seidel.
2750
2751         Trying waiting for httpd lock in the EWS
2752         https://bugs.webkit.org/show_bug.cgi?id=43833
2753
2754         If this works, we can probably run the tests on the mac-ews, which
2755         would be very exciting.  :)
2756
2757         * Scripts/webkitpy/tool/steps/runtests.py:
2758
2759 2010-08-11  Marcus Bulach  <bulach@chromium.org>
2760
2761         Reviewed by Eric Seidel.
2762
2763         Check in a script to list redundant test outputs.
2764         https://bugs.webkit.org/show_bug.cgi?id=37630
2765
2766         If e.g. platform/mac-leopard is missing an expected test output, we
2767         fall back on platform/mac.  This means it's possible to grow redundant
2768         test outputs, where we have the same expected data in both a platform
2769         directory and another platform it falls back on.
2770         (original patch by Evan Marting <evan@chromium.org> https://bugs.webkit.org/attachment.cgi?id=53398)
2771
2772         * Scripts/deduplicate-tests: Added.
2773         * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Added.
2774         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: Added.
2775
2776 2010-08-11  Antonio Gomes  <tonikitoo@webkit.org>
2777
2778         Reviewed by Ariya Hidayat.
2779
2780         [Qt] QtTestBrowser: after switching between QWebView and QGraphicsWebView, rotation actions get broken
2781         https://bugs.webkit.org/show_bug.cgi?id=43853
2782
2783         LauncherWindow::createChrome is connecting menu itens to WebViewGraphicsBased's slots directly.
2784         It behaviors badly when user launches the QtTestBrowser in QWebView mode, since then switching to
2785         QGraphicsWebView mode, createChrome is not called again, and menu items end up not getting connected
2786         to slots at all.
2787
2788         * QtTestBrowser/launcherwindow.cpp:
2789         (LauncherWindow::createChrome):
2790         (LauncherWindow::animatedFlip):
2791         (LauncherWindow::animatedYFlip):
2792         * QtTestBrowser/launcherwindow.h:
2793
2794 2010-08-11  Antonio Gomes  <tonikitoo@webkit.org>
2795
2796         Reviewed by Simon Hausmann.
2797
2798         [Qt] QtTestBrowser: switching between QWebView and QGraphicsWebView modes is broken
2799         https://bugs.webkit.org/show_bug.cgi?id=43851
2800
2801         All window options data (including the bool holding if the view is either QWebView or
2802         QGraphicsWebView based) is stored in m_windowOptions, a class member of LauncherWindow.
2803         When toggle the view from QWebView to QGraphicsWebView based (and vice-versa), we were
2804         not updating LauncherWindow::WindowOptions::m_useGraphicsView bit, and then things were
2805         getting broken.
2806
2807         Patch addresses this issue.
2808
2809         * QtTestBrowser/launcherwindow.cpp:
2810         (LauncherWindow::createChrome):
2811         (LauncherWindow::toggleWebView):
2812         (LauncherWindow::toggleAcceleratedCompositing):
2813
2814 2010-08-10  Antonio Gomes  <tonikitoo@webkit.org>
2815
2816         Reviewed by Ariya Hidayat.
2817
2818         [Qt] QtTestBrowser: lazy instantiate "YRotation" state machine and related objects
2819         https://bugs.webkit.org/show_bug.cgi?id=43831
2820
2821         Only instantiate QStateMachine and friends associated to the YRotation action on demand.
2822
2823         * QtTestBrowser/webview.cpp:
2824         (WebViewGraphicsBased::WebViewGraphicsBased):
2825         (WebViewGraphicsBased::animatedYFlip):
2826
2827 2010-08-11  Darin Adler  <darin@apple.com>
2828
2829         Reviewed by John Sullivan.
2830
2831         Improved editor options for prepare-ChangeLog and commit-log-editor
2832         https://bugs.webkit.org/show_bug.cgi?id=40548
2833
2834         * Scripts/commit-log-editor: Split editor strings on spaces so EDITOR
2835         values like "xed --launch --wait" work properly.
2836
2837         * Scripts/prepare-ChangeLog: Added a new CHANGE_LOG_EDITOR so we can
2838         use a command line tool with the $openChangeLogs feature.
2839
2840 2010-08-11  Yury Semikhatsky  <yurys@chromium.org>
2841
2842         Reviewed by Pavel Feldman.
2843
2844         Web Inspector: remove InjectDispatch.js
2845         https://bugs.webkit.org/show_bug.cgi?id=43835
2846
2847         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2848         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2849
2850 2010-08-10  Dirk Pranke  <dpranke@chromium.org>
2851
2852         Reviewed by Eric Seidel.
2853
2854         webkit-patch should refuse to run under Win32 Python
2855         https://bugs.webkit.org/show_bug.cgi?id=40962
2856
2857         Given that there are lots of places in webkit-patch's code that
2858         assume unix-style filenames (forward slashes), webkit-patch fails
2859         with weird file-not-found errors when run under a native windows
2860         Python. It would be nice if we just trapped this and errored out
2861         at the beginning, rather than producing unpredictable errors.
2862
2863         * Scripts/webkit-patch:
2864
2865 2010-08-10  Kent Tamura  <tkent@chromium.org>
2866
2867         Unreviewed, build fix.
2868         
2869         Chromium build fix for r65107.
2870
2871         * DumpRenderTree/chromium/LayoutTestController.cpp:
2872         (LayoutTestController::suspendAnimations):
2873         (LayoutTestController::resumeAnimations):
2874
2875 2010-08-10  Sergio Villar Senin  <svillar@igalia.com>
2876
2877         Reviewed by Xan Lopez.
2878
2879         [GTK] http/tests/media/video-cookie.html fails
2880         https://bugs.webkit.org/show_bug.cgi?id=42240
2881
2882         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2883         (LayoutTestController::setAlwaysAcceptCookies): create the
2884         SoupCookieJar if it does not exist. Otherwise the accept policy
2885         won't be set.
2886
2887 2010-08-10  Chris Marrin  <cmarrin@apple.com>
2888
2889         Reviewed by Oliver Hunt.
2890
2891         Add suspendAnimations/resumeAnimation API to DRT
2892         https://bugs.webkit.org/show_bug.cgi?id=43733
2893         
2894         Adds suspendAnimations() and resumeAnimations() to LayoutTestController.
2895         Calls functions with the same names on AnimationController for the 
2896         mainFrame.
2897
2898         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2899         * DumpRenderTree/LayoutTestController.cpp:
2900         (suspendAnimationsCallback):
2901         (resumeAnimationsCallback):
2902         (LayoutTestController::staticFunctions):
2903         * DumpRenderTree/LayoutTestController.h:
2904         * DumpRenderTree/chromium/LayoutTestController.cpp:
2905         (LayoutTestController::LayoutTestController):
2906         (LayoutTestController::suspendAnimations):
2907         (LayoutTestController::resumeAnimations):
2908         * DumpRenderTree/chromium/LayoutTestController.h:
2909         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2910         (LayoutTestController::suspendAnimations):
2911         (LayoutTestController::resumeAnimations):
2912         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2913         (LayoutTestController::suspendAnimations):
2914         (LayoutTestController::resumeAnimations):
2915         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2916         (LayoutTestController::suspendAnimations):
2917         (LayoutTestController::resumeAnimations):
2918         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2919         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2920         (LayoutTestController::suspendAnimations):
2921         (LayoutTestController::resumeAnimations):
2922         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2923         (LayoutTestController::suspendAnimations):
2924         (LayoutTestController::resumeAnimations):
2925
2926 2010-08-10  Dimitri Glazkov  <dglazkov@chromium.org>
2927
2928         Reviewed by Ojan Vafai.
2929
2930         [Chromium/DRT] Enable saving layout test results.
2931         https://bugs.webkit.org/show_bug.cgi?id=43796
2932
2933         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added more
2934             parameters to the new-run-webkit-tests, including the name
2935             of the test results server.
2936
2937 2010-08-10  Jian Li  <jianli@chromium.org>
2938
2939         More chromium build fix.
2940
2941         * DumpRenderTree/chromium/MockSpellCheck.cpp:
2942         (MockSpellCheck::spellCheckWord):
2943         (MockSpellCheck::initializeIfNeeded):
2944         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2945         (NotificationPresenter::grantPermission):
2946         (NotificationPresenter::show):
2947         (NotificationPresenter::checkPermission):
2948
2949 2010-08-10  Jian Li  <jianli@chromium.org>
2950
2951         Chromium build fix.
2952
2953         * DumpRenderTree/chromium/MockSpellCheck.cpp:
2954         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2955
2956 2010-08-10  Victor Wang  <victorw@chromium.org>
2957
2958         Reviewed by Ojan Vafai.
2959
2960         Update test results server merge logic so the aggregated
2961         results and times are updated for tests that are
2962         in aggragated json but not in incremental json.
2963
2964         Also update unittest to test this case.
2965
2966         https://bugs.webkit.org/show_bug.cgi?id=43769
2967
2968         * TestResultServer/model/jsonresults.py:
2969         * TestResultServer/model/jsonresults_unittest.py:
2970
2971 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
2972
2973         Reviewed by Ariya Hidayat.
2974
2975         [Qt] QtTestBrowser: proper set scene rect
2976
2977         When resizesToContents is ON scene's rect is set to the boundary of
2978         the mainFrame. However, navigating to other web page should keep resizing
2979         scene's rect according to the new document loaded. Patch addresses this issue.
2980
2981         Now resizesToContents and scrolling properly work on QtTestBrowser.
2982
2983         * QtTestBrowser/webview.cpp:
2984         (WebViewGraphicsBased::setPage):
2985         (WebViewGraphicsBased::contentsSizeChanged):
2986         (WebViewGraphicsBased::setResizesToContents):
2987         (WebViewGraphicsBased::resizeEvent):
2988         * QtTestBrowser/webview.h:
2989
2990 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
2991
2992         Reviewed by Ariya Hidayat.
2993
2994         [Qt] QtTestBrowser: Clean up LauncherWindow code.
2995
2996         * QtTestBrowser/launcherwindow.cpp:
2997         (LauncherWindow::LauncherWindow): Moves applyPrefs methods call from the constructor to init().
2998         (LauncherWindow::init): Fixed comments.
2999         (LauncherWindow::applyPrefs): Move the method around.
3000         (LauncherWindow::createChrome): Move more code of this method around, for grouping, and fixing up comments.
3001
3002 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
3003
3004         Reviewed by Ariya Hidayat.
3005
3006         [Qt] QtTestBrowser: make reset-zooming to animate when tiled backing store is on.
3007
3008         It gets control+0 the same visual effect as control++ or control-.
3009
3010         * QtTestBrowser/launcherwindow.cpp:
3011         (LauncherWindow::toggleZoomTextOnly):
3012
3013 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
3014
3015         Reviewed by Ariya Hidayat.
3016
3017         [Qt] QtTestBrowser:: make m_zoomLevels a static member.
3018
3019         Not all instances of LauncherWindow need its own m_zoomLevel.
3020
3021         * QtTestBrowser/launcherwindow.cpp:
3022         * QtTestBrowser/launcherwindow.h:
3023
3024 2010-08-09  Sam Weinig  <sam@webkit.org>
3025
3026         Reviewed by Geoffrey Garen.
3027
3028         Add zoom support for injected bundle
3029         https://bugs.webkit.org/show_bug.cgi?id=43759
3030
3031         Use zoom factor SPI to implement zoom related eventSender functions.
3032
3033         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3034         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3035         (WTR::EventSendingController::textZoomIn):
3036         (WTR::EventSendingController::textZoomOut):
3037         (WTR::EventSendingController::zoomPageIn):
3038         (WTR::EventSendingController::zoomPageOut):
3039         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3040         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3041         (WTR::InjectedBundlePage::reset): Reset zoom mode and level for each test.
3042
3043 2010-08-09  Gavin Barraclough  <barraclough@apple.com>
3044
3045         Speculative chromium build fix III.
3046
3047         * DumpRenderTree/chromium/MockSpellCheck.h:
3048         * DumpRenderTree/chromium/NotificationPresenter.h:
3049         * DumpRenderTree/chromium/WebViewHost.h:
3050         (WebViewHost::addClearHeader):
3051         (WebViewHost::clearHeaders):
3052
3053 2010-08-09  Ojan Vafai  <ojan@chromium.org>
3054
3055         Reviewed by Tony Chang.
3056
3057         increase the number of test results that we save
3058         https://bugs.webkit.org/show_bug.cgi?id=43763
3059
3060         Now that we do incremental uploads, we can increase the number of
3061         results that we save for http://test-results.appspot.com/dashboards/flakiness_dashboard.html.
3062
3063         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3064
3065 2010-08-09  Evan Martin  <evan@chromium.org>
3066
3067         Reviewed by Tony Chang.
3068
3069         [chromium] DRT error print statement incorrectly tries to print a FILE*
3070         https://bugs.webkit.org/show_bug.cgi?id=43747
3071
3072         * DumpRenderTree/chromium/ImageDiff.cpp:
3073         (writeFile): pass the correct pointer.
3074
3075 2010-08-09  Victor Wang  <victorw@chromium.org>
3076
3077         Reviewed by Ojan Vafai.
3078
3079         Upload incremental test results json to server by default.
3080
3081         https://bugs.webkit.org/show_bug.cgi?id=43743
3082
3083         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3084
3085 2010-08-09  Eric Seidel  <eric@webkit.org>
3086
3087         Reviewed by Adam Barth.
3088
3089         EWS bots wait 2 minutes between patches
3090         https://bugs.webkit.org/show_bug.cgi?id=43731
3091
3092         * Scripts/webkitpy/tool/bot/queueengine.py:
3093          - Don't sleep after failures.  This was a hold-over from
3094            an earlier design.
3095         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3096          - EWS bots were not properly reporting true/false from process_work_item.
3097            They were always returning None, thus false, thus always logging
3098            as a failure and sleeping 2 minutes after each patch.
3099
3100 2010-08-09  Sam Weinig  <sam@webkit.org>
3101
3102         Reviewed by Anders Carlsson.
3103
3104         Stub out EventSender for WebKitTestRunner
3105         https://bugs.webkit.org/show_bug.cgi?id=43703
3106
3107         * WebKitTestRunner/DerivedSources.make:
3108         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3109         Add ability to pass javascript arguments to the wrapped object.
3110
3111         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added.
3112         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: Added.
3113         (WTR::EventSendingController::create):
3114         (WTR::EventSendingController::EventSendingController):
3115         (WTR::EventSendingController::~EventSendingController):
3116         (WTR::EventSendingController::wrapperClass):
3117         (WTR::setExceptionForString):
3118         (WTR::EventSendingController::mouseDown):
3119         (WTR::EventSendingController::mouseUp):
3120         (WTR::EventSendingController::mouseMoveTo):
3121         (WTR::EventSendingController::keyDown):
3122         (WTR::EventSendingController::contextClick):
3123         (WTR::EventSendingController::leapForward):
3124         (WTR::EventSendingController::textZoomIn):
3125         (WTR::EventSendingController::textZoomOut):
3126         (WTR::EventSendingController::zoomPageIn):
3127         (WTR::EventSendingController::zoomPageOut):
3128         (WTR::EventSendingController::makeWindowObject):
3129         * WebKitTestRunner/InjectedBundle/EventSendingController.h: Added.
3130         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3131         (WTR::InjectedBundle::reset):
3132         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3133         (WTR::InjectedBundle::eventSendingController):
3134         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3135         (WTR::InjectedBundlePage::didClearWindowForFrame):
3136         Add stubbed out EventSenderController.
3137
3138         * WebKitTestRunner/InjectedBundle/GCController.h:
3139         Remove incorrect comment.
3140
3141         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3142         * WebKitTestRunner/win/InjectedBundle.vcproj:
3143         Add new files.
3144
3145 2010-08-08  Kent Tamura  <tkent@chromium.org>
3146
3147         Unreviewed, trivial fix.
3148
3149         Fix "WindowsError: [Error 32] The process cannot access the file
3150         because it is being used by another process" introduced by r64959.
3151
3152         * BuildSlaveSupport/test-result-archive:
3153
3154 2010-08-08  Kent Tamura  <tkent@chromium.org>
3155
3156         Reviewed by Tony Chang.
3157
3158         Chromium buildbot: Avoid "zip" command dependency
3159         https://bugs.webkit.org/show_bug.cgi?id=43470
3160
3161         * BuildSlaveSupport/test-result-archive:
3162          For Chromium port, creates a zip archive with zipfile package of Python
3163          instead of external "zip" command. We'd like to avoid additional
3164          command installation.
3165
3166 2010-08-08  Jon Honeycutt  <jhoneycutt@apple.com>
3167
3168         WebKitTestRunner should add the QuickTime dir to the PATH environment
3169         variable
3170         https://bugs.webkit.org/show_bug.cgi?id=43686
3171
3172         Reviewed by Dan Bernstein.
3173
3174         * WebKitTestRunner/win/TestControllerWin.cpp:
3175         (WTR::addQTDirToPATH):
3176         Copied from DRT.
3177         (WTR::TestController::platformInitialize):
3178         Call addQTDirToPath().
3179         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3180         Link to shlwapi.lib for SHGetValue.
3181
3182 2010-08-07  Sam Weinig  <sam@webkit.org>
3183
3184         Reviewed by Maciej Stachowiak.
3185
3186         WebKitTestRunner needs layoutTestController.dumpTitleChanges
3187         <rdar://problem/8213861>
3188         https://bugs.webkit.org/show_bug.cgi?id=42683
3189
3190         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3191         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3192         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
3193         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
3194         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3195         (WTR::LayoutTestController::LayoutTestController):
3196         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3197         (WTR::LayoutTestController::dumpTitleChanges):
3198         (WTR::LayoutTestController::shouldDumpTitleChanges):
3199
3200 2010-08-07  Sam Weinig  <sam@webkit.org>
3201
3202         Reviewed by Anders Carlsson.
3203
3204         WebKitTestRunner needs to print onunload handler information
3205         <rdar://problem/8213831>
3206         https://bugs.webkit.org/show_bug.cgi?id=42703
3207
3208         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3209         (WTR::operator<<):
3210         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
3211
3212 2010-08-07  Sam Weinig  <sam@webkit.org>
3213
3214         Reviewed by Anders Carlsson.
3215
3216         Add additional loader client functions need to complete WebKitTestRunner
3217         https://bugs.webkit.org/show_bug.cgi?id=43684
3218
3219         Remove unnecessary and jarring underscores as well.
3220
3221         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3222         (didClearWindowObjectForFrame):
3223         (didCreatePage):
3224         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3225         (WTR::InjectedBundlePage::InjectedBundlePage):
3226         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
3227         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
3228         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
3229         (WTR::InjectedBundlePage::didCommitLoadForFrame):
3230         (WTR::InjectedBundlePage::didFinishLoadForFrame):
3231         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
3232         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
3233         (WTR::InjectedBundlePage::didClearWindowForFrame):
3234         (WTR::InjectedBundlePage::didCancelClientRedirectForFrame):
3235         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
3236         (WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
3237         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
3238         (WTR::InjectedBundlePage::didHandleOnloadEventsForFrame):
3239         (WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
3240         (WTR::InjectedBundlePage::didRunInsecureContentForFrame):
3241         (WTR::InjectedBundlePage::willAddMessageToConsole):
3242         (WTR::InjectedBundlePage::willSetStatusbarText):
3243         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
3244         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
3245         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
3246         (WTR::InjectedBundlePage::shouldBeginEditing):
3247         (WTR::InjectedBundlePage::shouldEndEditing):
3248         (WTR::InjectedBundlePage::shouldInsertNode):
3249         (WTR::InjectedBundlePage::shouldInsertText):
3250         (WTR::InjectedBundlePage::shouldDeleteRange):
3251         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
3252         (WTR::InjectedBundlePage::shouldApplyStyle):
3253         (WTR::InjectedBundlePage::didBeginEditing):
3254         (WTR::InjectedBundlePage::didEndEditing):
3255         (WTR::InjectedBundlePage::didChange):
3256         (WTR::InjectedBundlePage::didChangeSelection):
3257         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3258
3259 2010-08-07  Dan Bernstein  <mitz@apple.com>
3260
3261         Build fix.
3262
3263         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Made the references
3264         to JSGCController.{cpp,h} relative to the build root.
3265
3266 2010-08-07  Sam Weinig  <sam@webkit.org>
3267
3268         Reviewed by Anders Carlsson.
3269
3270         WebKitTestRunner needs GCController
3271         <rdar://problem/8213834>
3272         https://bugs.webkit.org/show_bug.cgi?id=42701
3273
3274         * WebKitTestRunner/DerivedSources.make:
3275         * WebKitTestRunner/InjectedBundle/Bindings/GCController.idl: Added.
3276         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h:
3277         (WTR::setProperty):
3278         * WebKitTestRunner/InjectedBundle/GCController.cpp: Added.
3279         (WTR::GCController::create):
3280         (WTR::GCController::GCController):
3281         (WTR::GCController::~GCController):
3282         (WTR::GCController::wrapperClass):
3283         (WTR::GCController::collect):
3284         (WTR::GCController::collectOnAlternateThread):
3285         (WTR::GCController::getJSObjectCount):
3286         (WTR::GCController::makeWindowObject):
3287         * WebKitTestRunner/InjectedBundle/GCController.h: Added.
3288         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3289         (WTR::InjectedBundle::reset):
3290         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3291         (WTR::InjectedBundle::bundle):
3292         (WTR::InjectedBundle::gcController):
3293         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3294         (WTR::InjectedBundlePage::didClearWindowForFrame):
3295         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3296         (WTR::LayoutTestController::keepWebHistory):
3297         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3298         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3299         * WebKitTestRunner/win/InjectedBundle.vcproj:
3300
3301 2010-08-05  Jon Honeycutt  <jhoneycutt@apple.com>
3302
3303         WebKitTestRunner needs to be able to set the font smoothing type
3304         https://bugs.webkit.org/show_bug.cgi?id=43406
3305
3306         Reviewed by Adam Roben.
3307
3308         * WebKitTestRunner/TestInvocation.cpp:
3309         (WTR::TestInvocation::resetPreferencesToConsistentValues):
3310         Set the font smoothing level to
3311         kWKFontSmoothingLevelNoSubpixelAntiAliasing to match DRT.
3312
3313 2010-08-06  Jon Honeycutt  <jhoneycutt@apple.com>
3314
3315         Fix a missed variable rename.
3316
3317         Unreviewed.
3318
3319         * Scripts/old-run-webkit-tests:
3320
3321 2010-08-06  Jon Honeycutt  <jhoneycutt@apple.com>
3322
3323         mac-wk2/Skipped should be used on Windows when running regression tests
3324         https://bugs.webkit.org/show_bug.cgi?id=43494
3325
3326         Reviewed by Adam Roben.
3327
3328         * Scripts/old-run-webkit-tests:
3329         If the platform is win-wk2, also read the mac-wk2 skipped list.
3330
3331 2010-08-06  Kent Tamura  <tkent@chromium.org>
3332
3333         Reviewed by Dimitri Glazkov.
3334
3335         [DRT/Chromium] Should revoke scheduled tasks
3336         https://bugs.webkit.org/show_bug.cgi?id=43560
3337
3338         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
3339         (DRTDevToolsAgent::reset): Calls RevokeAll().
3340         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3341         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
3342         (DRTDevToolsClient::reset): Calls RevokeAll().
3343         * DumpRenderTree/chromium/DRTDevToolsClient.h:
3344         * DumpRenderTree/chromium/EventSender.cpp:
3345         (EventSender::reset): Calls RevokeAll().
3346         * DumpRenderTree/chromium/LayoutTestController.cpp:
3347         (LayoutTestController::reset): Calls RevokeAll().
3348         * DumpRenderTree/chromium/TestShell.cpp:
3349         (TestShell::resetTestController): Calls DRTDevToolsAgent::reset() and DRTDevToolsClient::reset().
3350
3351 2010-08-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3352
3353         Reviewed by Antonio Gomes.
3354
3355         [Qt] Fix the DRT build on Mac OS X
3356
3357         * DumpRenderTree/qt/DumpRenderTree.pro:
3358
3359 2010-08-06  Jochen Eisinger  <jochen@chromium.org>
3360
3361         Reviewed by Pavel Feldman.
3362
3363         Rietvield's upload.py moved to a different location.
3364         https://bugs.webkit.org/show_bug.cgi?id=43613
3365
3366         * Scripts/webkitpy/thirdparty/__init__.py:
3367
3368 2010-05-23  Eric Seidel  <eric@webkit.org>
3369
3370         Reviewed by Adam Barth.
3371
3372         QueueStatusServer needs better queue-status pages
3373         https://bugs.webkit.org/show_bug.cgi?id=39562
3374
3375         The primary goal of this patch is to display queue
3376         positions somewhere on the site so that it's easier
3377         for commit-queue users to know when their pach will
3378         be landed.  I also tried to improve the root page
3379         to be more useful than the previous wall of status text.
3380
3381         * QueueStatusServer/handlers/recentstatus.py:
3382         * QueueStatusServer/main.py:
3383         * QueueStatusServer/model/queues.py:
3384         * QueueStatusServer/templates/recentstatus.html:
3385
3386 2010-08-05  Victor Wang  <victorw@chromium.org>
3387
3388         Reviewed by Ojan Vafai.
3389
3390         Add option to generate/upload incremental json results to test result server.
3391         Also refactor the json results generator unittest code to test
3392         incremental and aggregated json results.
3393
3394         https://bugs.webkit.org/show_bug.cgi?id=43519
3395
3396         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3397         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3398         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3399         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3400
3401 2010-08-05  Jian Li  <jianli@chromium.org>
3402
3403         Reviewed by David Levin.
3404
3405         Unify blob related feature defines to ENABLE(BLOB).
3406         https://bugs.webkit.org/show_bug.cgi?id=43081
3407
3408         * Scripts/build-webkit:
3409
3410 2010-08-05  Satish Sampath  <satish@chromium.org>
3411
3412         Reviewed by Jeremy Orlow.
3413
3414         Add speech input controller mock in WebKit and a layout test.
3415         https://bugs.webkit.org/show_bug.cgi?id=43477
3416
3417         Added LayoutTestController::setMockSpeechInputResultCallback method.
3418
3419         * DumpRenderTree/LayoutTestController.cpp:
3420         (setMockSpeechInputResultCallback): Wrapper invoking the member function.
3421         (LayoutTestController::staticFunctions):
3422         * DumpRenderTree/LayoutTestController.h:
3423         * DumpRenderTree/chromium/LayoutTestController.cpp:
3424         (LayoutTestController::LayoutTestController):
3425         (LayoutTestController::setMockSpeechInputResult): Sets the mock result.
3426         (LayoutTestController::speechInputController): Creates the mock controller.
3427         * DumpRenderTree/chromium/LayoutTestController.h:
3428         * DumpRenderTree/chromium/WebViewHost.cpp:
3429         (WebViewHost::speechInputController): Creates the mock controller.
3430         * DumpRenderTree/chromium/WebViewHost.h:
3431         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3432         (LayoutTestController::setMockSpeechInputResult): dummy method.
3433         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3434         (LayoutTestController::setMockSpeechInputResult): dummy method.
3435         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3436         (LayoutTestController::setMockSpeechInputResult): dummy method.
3437         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3438         * DumpRenderTree/win/LayoutTestControllerWin.cpp: dummy method.
3439         (LayoutTestController::setMockSpeechInputResult):
3440         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: dummy method.
3441         (LayoutTestController::setMockSpeechInputResult):
3442
3443 2010-08-04  Adam Roben  <aroben@apple.com>
3444
3445         Fix the path to TestNetscapePlugin's directory on Windows
3446
3447         Fixes <http://webkit.org/b/43513> WebKitTestRunner on Windows fails to
3448         load TestNetscapePlugin
3449
3450         Reviewed by Jon Honeycutt.
3451
3452         * WebKitTestRunner/win/TestControllerWin.cpp:
3453         (WTR::TestController::initializeTestPluginDirectory):
3454         TestNetscapePlugin is in a TestNetscapePlugin[_Debug] directory that's
3455         next to WebKitTestRunner.exe. Previously we were passing the directory
3456         that contains WebKitTestRunner.exe. Also fixed some leaks.
3457
3458 2010-08-05  Kenichi Ishibashi  <bashi@google.com>
3459
3460         Reviewed by Shinichiro Hamaji.
3461
3462         check-webkit-style returns non-zero when patch is entirely minus lines.
3463         https://bugs.webkit.org/show_bug.cgi?id=38169
3464
3465         * Scripts/check-webkit-style:
3466         Check whether a patch contains modified files that are entirely minus lines.
3467         * Scripts/webkitpy/style/filereader.py:
3468         Add a variable that holds number of files that contain only deleted lines.
3469         * Scripts/webkitpy/style/patchreader.py:
3470         Count up modified files that contain only deleted lines.
3471
3472 2010-08-05  Pavel Feldman  <pfeldman@chromium.org>
3473
3474         Reviewed by Yury Semikhatsky.
3475
3476         DevTools: get rid of delayed command dispatching on front-end side.
3477
3478         https://bugs.webkit.org/show_bug.cgi?id=43479
3479
3480         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
3481         (DRTDevToolsAgent::detach):
3482         (DRTDevToolsAgent::frontendLoaded):
3483         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3484         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
3485         (DRTDevToolsClient::~DRTDevToolsClient):
3486         (DRTDevToolsClient::sendFrontendLoaded):
3487         * DumpRenderTree/chromium/DRTDevToolsClient.h:
3488
3489 2010-08-04  Kenichi Ishibashi  <bashi@google.com>
3490
3491         Reviewed by Shinichiro Hamaji.
3492
3493         Fixes check-webkit-style false positive on "new uint32_t."
3494         https://bugs.webkit.org/show_bug.cgi?id=43077
3495
3496         * Scripts/webkitpy/style/checkers/cpp.py:
3497         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3498
3499 2010-08-04  Kent Tamura  <tkent@chromium.org>
3500
3501         Reviewed by Dimitri Glazkov.
3502
3503         [DRT/Chromium] Remove base/linked_ptr.h dependency
3504         https://bugs.webkit.org/show_bug.cgi?id=43472
3505
3506         Replace linked_ptr<TestNavigationEntry> with RefPtr<TestNavigationEntry>.
3507         We need to use RefPtr<> because m_pendingEntry points an object in
3508         m_entries or not in m_entries.
3509
3510         * DumpRenderTree/chromium/TestNavigationController.cpp:
3511         (TestNavigationEntry::create): Added.
3512         (TestNavigationController::activeEntry):
3513         (TestNavigationController::didNavigateToEntry):
3514         (TestNavigationController::discardPendingEntry):
3515         (TestNavigationController::insertEntry):
3516         (TestNavigationController::navigateToPendingEntry):
3517         * DumpRenderTree/chromium/TestNavigationController.h:
3518         * DumpRenderTree/chromium/WebViewHost.cpp:
3519         (WebViewHost::loadURLForFrame):
3520          Use TestNavigationEntry::create().
3521         (WebViewHost::updateURL):
3522          Use RefPtr<>.
3523         (WebViewHost::updateSessionHistory):
3524          Remove unnecessary static_cast<>.
3525
3526 2010-08-04  Kent Tamura  <tkent@chromium.org>
3527
3528         Reviewed by Dimitri Glazkov.
3529
3530         Fix a problem that "archived test results" step doesn't work on Chromium buildbots
3531         https://bugs.webkit.org/show_bug.cgi?id=43333
3532
3533         * BuildSlaveSupport/test-result-archive:
3534           - Make layoutTestResultsDir local and pass it to archiveTestResults()
3535           - Adjust layoutTestResultsDir for Chromium
3536
3537 2010-08-04  Kent Tamura  <tkent@chromium.org>
3538
3539         Reviewed by Dimitri Glazkov.
3540
3541         NRWT: websocket_server startup detection failure
3542         https://bugs.webkit.org/show_bug.cgi?id=43466
3543
3544         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
3545          Increase timeout value: 5 second -> 10 second
3546
3547 2010-08-04  Victor Wang  <victorw@chromium.org>
3548
3549         Reviewed by Ojan Vafai.
3550
3551         -. Add result.json incremental merging functionality to test results app engine.
3552         -. blobstore is not suitable for AE data merging and there is no API to
3553            programatically edit existing blob or write a new one yet, so replace blobstore
3554            with datastore. If file is oversize (>1000*1000 bytes), store file data in
3555            multiple datastore entries.
3556         -. Fix styles.
3557
3558         Test: jsonresults_unittest to test merging logics.
3559
3560         https://bugs.webkit.org/show_bug.cgi?id=38599
3561
3562         * TestResultServer/handlers/dashboardhandler.py:
3563         * TestResultServer/handlers/menu.py:
3564         * TestResultServer/handlers/testfilehandler.py:
3565         * TestResultServer/main.py:
3566         * TestResultServer/model/dashboardfile.py:
3567         * TestResultServer/model/datastorefile.py: Added.
3568         * TestResultServer/model/jsonresults.py: Added.
3569         * TestResultServer/model/jsonresults_unittest.py: Added.
3570         * TestResultServer/model/testfile.py:
3571         * TestResultServer/templates/uploadform.html:
3572
3573 2010-08-04  Antonio Gomes  <tonikitoo@webkit.org>
3574
3575         Reviewed by Kenneth Christiansen.
3576
3577         [Qt] [QtTestBrowser] Remove unneeded QAction class members