The same bots shouldn't run both Windows Debug Tests and Windows Release Tests.
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-09-30  Brian Weinstein  <bweinstein@apple.com>
2
3         Reviewed by Adam Roben.
4
5         The same bots shouldn't run both Windows Debug Tests and Windows Release Tests.
6         https://bugs.webkit.org/show_bug.cgi?id=46926
7
8         * BuildSlaveSupport/build.webkit.org-config/config.json: Have two bots running Windows 
9             Release Tests, and two bots running Windows Debug Tests, instead of four running both.
10
11 2010-09-30  Adam Barth  <abarth@webkit.org>
12
13         Reviewed by Eric Seidel.
14
15         webkit-patch find-flaky-tests should print results URLs
16         https://bugs.webkit.org/show_bug.cgi?id=46917
17
18         Printing out the results URL makes find-flaky-tests more actionable
19         because you can see what happens when a test fails.  The output from
20         the script is still pretty noisy, but it seems useful.
21
22         * Scripts/webkitpy/tool/commands/queries.py:
23
24 2010-09-30  Chris Marrin  <cmarrin@apple.com>
25
26         Reviewed by Simon Fraser.
27
28         Make 2D accelerated canvas rendering build on Mac
29         https://bugs.webkit.org/show_bug.cgi?id=46007
30         
31         Added ACCELERATED_2D_CANVAS to build-webkit
32
33         * Scripts/build-webkit:
34
35 2010-09-29  Kenneth Russell  <kbr@google.com>
36
37         Reviewed by Dimitri Glazkov.
38
39         [chromium] Add accelerated compositing support to DumpRenderTree and test_shell
40         https://bugs.webkit.org/show_bug.cgi?id=46849
41
42         Added offscreen code path for WebGraphicsContext3DDefaultImpl which
43         works with the compositor integration in both DumpRenderTree and
44         test_shell, since both pass a non-null WebCanvas* to WebViewImpl::paint
45         and thereby trigger the compositor's readback code path. Added support
46         for --enable-accelerated-compositing to DumpRenderTree.
47
48         Tested in both test_shell and DumpRenderTree on Linux, the latter by
49         modifying a compositing layout test, dumping the pixels and verifying
50         that they matched the output when the compositor was active.
51
52         * DumpRenderTree/chromium/DumpRenderTree.cpp:
53         (main):
54         * DumpRenderTree/chromium/TestShell.cpp:
55         (TestShell::TestShell):
56         (TestShell::resetWebSettings):
57         * DumpRenderTree/chromium/TestShell.h:
58         (TestShell::setAcceleratedCompositingEnabled):
59         * DumpRenderTree/chromium/WebPreferences.cpp:
60         (WebPreferences::reset):
61         (WebPreferences::applyTo):
62         * DumpRenderTree/chromium/WebPreferences.h:
63         * DumpRenderTree/chromium/WebViewHost.cpp:
64         (WebViewHost::scheduleComposite):
65         * DumpRenderTree/chromium/WebViewHost.h:
66
67 2010-09-30  Adam Roben  <aroben@apple.com>
68
69         Ensure that QueueEngine cleans up its log files when its delegate
70         tells it to stop processing work
71
72         Reviewed by Adam Barth.
73
74         Fixes <http://webkit.org/b/46891> <rdar://problem/8496638> Many tests
75         in webkitpy.tool.bot.queueengine_unittest.QueueEngineTest crash on
76         Windows
77
78         * Scripts/webkitpy/tool/bot/queueengine.py:
79         (QueueEngine.run): Stop ourselves normally (including cleaning up log
80         files) when the delegate tells us to stop processing work.
81
82         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
83         (LoggingDelegate.__init__): Moved code here from
84         RaisingDelegate.__init__.
85         (LoggingDelegate.expeced_callbacks): Added the stop_work_queue
86         callback.
87         (LoggingDelegate.stop_work_queue): Moved here from RaisingDelegate.
88         (RaisingDelegate.__init__): Removed code that LoggingDelegate takes
89         care of for us now.
90         (QueueEngineTest.test_trivial): Make sure we got the expected stop
91         message.
92         (QueueEngineTest.test_not_safe_to_proceed): Changed to explicitly
93         remove the callbacks that are related to processing a single work
94         item, rather than removing all callbacks after a certain point, as
95         there are now more callbacks we expect to receive at the end.
96
97 2010-09-30  Adam Roben  <aroben@apple.com>
98
99         Fix path -> URL conversion on Cygwin
100
101         Reviewed by Adam Barth.
102
103         Fixes <http://webkit.org/b/46890> <rdar://problem/8496637> Many tests
104         in webkitpy.layout_tests.run_webkit_tests_unittest assert on Windows
105
106         * Scripts/webkitpy/layout_tests/port/base.py:
107         (Port.filename_to_uri): Treat Cygwin like other UNIX-y platforms by
108         assuming paths already have a leading slash.
109
110 2010-09-30  Adam Roben  <aroben@apple.com>
111
112         Teach WindowGeometryInitializedBeforeSetWindow that NPP_SetWindow can
113         be called more than once
114
115         The NPP_SetWindow call made when the plugin is torn down was confusing
116         us, and was causing us to spew an error into the next test.
117
118         Fixes <http://webkit.org/b/46900> <rdar://problem/8496888> REGRESSION
119         (r68520): plugins/access-after-page-destroyed.html failing on Windows
120
121         Reviewed by Anders Carlsson.
122
123         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:
124         (WindowGeometryInitializedBeforeSetWindow::WindowGeometryInitializedBeforeSetWindow):
125         Initialize member.
126         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Bail if
127         this isn't the first time this is called.
128
129 2010-09-30  Eric Seidel  <eric@webkit.org>
130
131         Reviewed by Adam Barth.
132
133         webkit-patch upload warns that I'm using Xcode when I'm not
134         https://bugs.webkit.org/show_bug.cgi?id=46869
135
136         String.find returns -1 when not found, so switched to "in".
137
138         * Scripts/webkitpy/common/system/user.py:
139         * Scripts/webkitpy/common/system/user_unittest.py:
140
141 2010-09-30  Eric Seidel  <eric@webkit.org>
142
143         Reviewed by Adam Barth.
144
145         webkit-patch failure-reason dies if non-trunk commits are in the blame range
146         https://bugs.webkit.org/show_bug.cgi?id=46866
147
148         I also made failure-reason use RegressionWindow in a cleaner way.
149
150         * Scripts/webkitpy/tool/commands/queries.py:
151
152 2010-09-29  Adam Barth  <abarth@webkit.org>
153
154         Reviewed by Eric Seidel.
155
156         webkit-patch find-flaky-tests
157         https://bugs.webkit.org/show_bug.cgi?id=46876
158
159         This command helps us find flaky tests so we can squash them.
160
161         * Scripts/webkitpy/tool/commands/queries.py:
162
163 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
164
165         Fix export to use '?' instead of 'null' for
166         tests with no results.
167         
168         * CSSTestSuiteHarness/harness/harness.js:
169
170 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
171
172         Add a warning when a test requires special steps.
173         Add a Print Preview button for 'paged' tests that
174         brings up the print dialog, allowing the user to 
175         judge paged media tests.
176
177         * CSSTestSuiteHarness/harness/harness.css:
178         * CSSTestSuiteHarness/harness/harness.html:
179         * CSSTestSuiteHarness/harness/harness.js:
180         (TestSuite.prototype.loadTest):
181         (TestSuite.prototype.processFlags):
182
183 2010-09-29  Adam Barth  <abarth@webkit.org>
184
185         Reviewed by Eric Seidel.
186
187         Remove revisions_casuing_failures
188         https://bugs.webkit.org/show_bug.cgi?id=46872
189
190         This function exists only to be unit tested.
191
192         * Scripts/webkitpy/common/net/failuremap.py:
193         * Scripts/webkitpy/common/net/failuremap_unittest.py:
194         * Scripts/webkitpy/tool/mocktool.py:
195
196 2010-09-29  Adam Barth  <abarth@webkit.org>
197
198         Reviewed by Eric Seidel.
199
200         SheriffBot should post the list of failing tests to bugs
201         https://bugs.webkit.org/show_bug.cgi?id=46871
202
203         * Scripts/webkitpy/common/net/buildbot.py:
204         * Scripts/webkitpy/common/net/failuremap.py:
205         * Scripts/webkitpy/common/net/regressionwindow.py:
206         * Scripts/webkitpy/tool/bot/sheriff.py:
207         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
208         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
209         * Scripts/webkitpy/tool/commands/queues_unittest.py:
210         * Scripts/webkitpy/tool/commands/sheriffbot.py:
211         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
212         * Scripts/webkitpy/tool/commands/upload_unittest.py:
213         * Scripts/webkitpy/tool/mocktool.py:
214
215 2010-09-29  Brent Fulgham  <bfulgham@webkit.org>
216
217         Reviewed by Martin Robinson, Eric Seidel, and Mark Rowe.
218
219         [WinCairo] Adds a build slave.
220         https://bugs.webkit.org/show_bug.cgi?id=46360
221
222         * BuildSlaveSupport/build.webkit.org-config/config.json: Add
223         entries for a debug build of the WinCairo port.
224         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add
225         platform flag to configuration for wincairo (like gtk, chromium, etc.)
226         * Scripts/build-webkit: Change 'cairo-win32' labeling to 'wincairo'
227         * Scripts/webkitdirs.pm: Change 'cairo-win32' labeling to 'wincairo'
228
229 2010-09-29  Adam Barth  <abarth@webkit.org>
230
231         Reviewed by Eric Seidel.
232
233         Move more SheriffBot smarts into FailureMap
234         https://bugs.webkit.org/show_bug.cgi?id=46703
235
236         This patch pushes the FailureMap model object further into the
237         SheriffBot machine.  In addition, it moves a couple operations on this
238         object from SheriffBot itself to the model.
239
240         Eventually, FailureMap will be the canonical context object for
241         SheriffBot operations.  FailureMap represents a map of the current
242         failures on the bots that might require remediation.
243
244         * Scripts/webkitpy/common/net/failuremap.py:
245         * Scripts/webkitpy/common/net/regressionwindow.py:
246         * Scripts/webkitpy/tool/commands/queries.py:
247         * Scripts/webkitpy/tool/commands/sheriffbot.py:
248         * Scripts/webkitpy/tool/mocktool.py:
249
250 2010-09-29  Tony Chang  <tony@chromium.org>
251
252         Reviewed by James Robinson.
253
254         [chromium] enable -Werror for DRT and webkit_unit_tests on Linux
255         https://bugs.webkit.org/show_bug.cgi?id=46829
256
257         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
258         (DRTDevToolsClient::DRTDevToolsClient):
259         * DumpRenderTree/chromium/TestShell.cpp:
260         (TestShell::TestShell):
261         * DumpRenderTree/chromium/WebViewHost.cpp:
262         (WebViewHost::postAccessibilityNotification):
263         (WebViewHost::WebViewHost):
264
265 2010-09-29  Chris Fleizach  <cfleizach@apple.com>
266
267         Reviewed by Darin Adler.
268
269         AX: implement CSS3 Speech "speak"
270         https://bugs.webkit.org/show_bug.cgi?id=46827
271
272         * DumpRenderTree/AccessibilityUIElement.cpp:
273         (speakCallback):
274         (AccessibilityUIElement::speak):
275         (AccessibilityUIElement::getJSClass):
276         * DumpRenderTree/AccessibilityUIElement.h:
277         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
278         (AccessibilityUIElement::speak):
279
280 2010-09-29  Mihai Parparita  <mihaip@chromium.org>
281
282         Reviewed by Adam Barth.
283
284         Record bot ID when updating queue status
285         https://bugs.webkit.org/show_bug.cgi?id=46764
286         
287         Since we now have multiple bots handling patches from the commit queue,
288         we need to differentiate status updates from them, so that we can group
289         the queue status page in a less confusing way.
290
291         * QueueStatusServer/handlers/updatestatus.py: Accept bot_id as input
292         * QueueStatusServer/model/queuestatus.py: Add bot_id property
293         * QueueStatusServer/templates/updatestatus.html: Add bot_id input
294         * Scripts/webkitpy/common/net/bugzilla_unittest.py: Extract MockBrowser
295         * Scripts/webkitpy/common/net/statusserver.py: Add bot_id
296         * Scripts/webkitpy/common/net/statusserver_unittest.py: Added.
297         * Scripts/webkitpy/tool/main.py: Add --bot-id
298         * Scripts/webkitpy/tool/mocktool.py: Add MockBrowser
299
300 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
301
302         No review.
303         
304         References always refert to a file in .xht format, even
305         for HTML tests, so fix their loading.
306
307         * CSSTestSuiteHarness/harness/harness.js:
308         (TestSuite.prototype.loadRef):
309
310 2010-09-28  Johnny Ding  <jnd@chromium.org>
311
312         Reviewed by Adam Barth.
313
314         https://bugs.webkit.org/show_bug.cgi?id=41292
315         Add a new parameter to the test plugin to allow specifying a script 
316         and a mouse/keyboard event. The specified script will be evaluated
317         in the browser when the specified event is received by the plugin.
318
319         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
320         (pluginAllocate):
321         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
322         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
323         (NPP_New):
324         (handleEventCarbon):
325         (handleEventCocoa):
326
327 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
328
329         Fix export by adding missing argument.
330
331         * CSSTestSuiteHarness/harness/harness.js:
332         (TestSuite.prototype.showResultsForAllTests):
333
334 2010-09-28  Kevin Ollivier  <kevino@theolliviers.com>
335
336         [wx] Build fix, add missing import.
337
338         * wx/packaging/build-win-installer.py:
339
340 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
341
342         No review
343         
344         Show which tests have been run by dimming them out in the test list.
345         
346         Adjust some element sizes.
347         
348         * CSSTestSuiteHarness/harness/harness.css:
349         (#test-list > option.untested):
350         (#test-list > option.completed):
351         (#output):
352         (.output-options):
353         * CSSTestSuiteHarness/harness/harness.js:
354         (Test):
355         (TestSuite.prototype.fillTestList):
356         (TestSuite.prototype.updateTestList):
357         (TestSuite.prototype.setSelectedChapter):
358         (TestSuite.prototype.recordResult):
359         (TestSuite.prototype.markTestCompleted):
360         (TestSuite.prototype.testCompletionStateChanged):
361         (TestSuite.prototype.loadTestStatus):
362
363 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
364
365         No review.
366         
367         Implement export of various queries on the test database, sharing
368         code with that which displays results inline.
369
370         * CSSTestSuiteHarness/harness/harness.js:
371         ():
372         (TestSuite.prototype.exportResultsCompletion.var):
373         (TestSuite.prototype.exportResultsCompletion):
374         (TestSuite.prototype.showResultsForCompletedTests):
375         (TestSuite.prototype.exportResultsForCompletedTests):
376         (TestSuite.prototype.showResultsForAllTests):
377         (TestSuite.prototype.exportResultsForAllTests):
378         (TestSuite.prototype.exportResultsForTestsNotRun):
379         (TestSuite.prototype.exportResultsForTestsWithStatus):
380         (TestSuite.prototype.exportResultsForTestsWithMismatchedResults):
381
382 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
383
384         No review.
385
386         Work around uncertainty about the order of database
387         transactions when creating the database, so that we don't
388         try to query the table before it has been created.
389
390         * CSSTestSuiteHarness/harness/harness.js:
391         (TestSuite):
392         (TestSuite.prototype.databaseCreated):
393         (TestSuite.prototype.storeTestResult):
394         (TestSuite.prototype.populateDatabaseFromTestInfoData):
395         (TestSuite.prototype.queryDatabaseForTestsWithStatus):
396         (TestSuite.prototype.queryDatabaseForTestsWithMixedStatus):
397         (TestSuite.prototype.queryDatabaseForCompletedTests):
398         (TestSuite.prototype.queryDatabaseForTestsNotRun):
399
400 2010-09-28  Tony Chang  <tony@chromium.org>
401
402         Reviewed by Eric Seidel.
403
404         add python keyring support to webkit-patch
405         https://bugs.webkit.org/show_bug.cgi?id=41269
406
407         * Scripts/webkitpy/common/net/credentials.py: Add the ability to read passwords using
408             the python keyring module
409         * Scripts/webkitpy/common/net/credentials_unittest.py:
410         * Scripts/webkitpy/common/system/user.py: Allow confirm() to default to no and add testing params.
411         * Scripts/webkitpy/common/system/user_unittest.py:
412         * Scripts/webkitpy/tool/mocktool.py:
413
414 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
415
416         Reviewed by Gustavo Noronha Silva.
417
418         [Cairo] FreeType fonts should obey FontConfig hinting/anti-aliasing settings
419         https://bugs.webkit.org/show_bug.cgi?id=46740
420
421         * DumpRenderTree/gtk/fonts/fonts.conf: Add specialized variants of common
422         fonts which can be used to fully test FontConfig rendering settings.
423
424 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
425
426         Reviewed by Gustavo Noronha Silva.
427
428         [gtk] Fedora has a different path for the liberation fonts
429         https://bugs.webkit.org/show_bug.cgi?id=46709
430
431         When searching for DRT fonts, also look in the path where those fonts
432         are commonly found on Fedora systems.
433
434         * DumpRenderTree/gtk/DumpRenderTree.cpp:
435         (initializeFonts): Include logic for looking for Fedora-style font paths.
436
437 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
438
439         Reviewed by Andreas Kling.
440
441         run-webkit-tests needs an updated list of directories with webgl tests
442         https://bugs.webkit.org/show_bug.cgi?id=46747
443
444         Update the list of directories containing WebGL tests and a unit test
445         which depends on this list.
446
447         * Scripts/old-run-webkit-tests: Update the list of directories.
448         * Scripts/webkitpy/layout_tests/port/webkit.py: Ditto.
449         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Update the expected result.
450
451 2010-09-28  Adam Barth  <abarth@webkit.org>
452
453         Reviewed by Eric Seidel.
454
455         Introduce FailureMap to summaries the failures status of all the bots
456         https://bugs.webkit.org/show_bug.cgi?id=46700
457
458         This patch gives the SheriffBot a handle on the list of failing tests.
459
460         * Scripts/webkitpy/common/net/buildbot.py:
461         * Scripts/webkitpy/common/net/failuremap.py: Added.
462         * Scripts/webkitpy/tool/commands/queries.py:
463         * Scripts/webkitpy/tool/commands/sheriffbot.py:
464         * Scripts/webkitpy/tool/mocktool.py:
465
466 2010-09-28  Adam Roben  <aroben@apple.com>
467
468         Update for the addition of WKPageUIClient::didNotHandleKeyEvent
469
470         Fixes <http://webkit.org/b/46660> <rdar://problem/8483465> Need API to
471         tell a WebKit2 client application that a key event was not handled
472
473         Reviewed by Kenneth Rohde Christiansen and Sam Weinig.
474
475         * MiniBrowser/mac/BrowserWindowController.m:
476         (-[BrowserWindowController awakeFromNib]):
477         * MiniBrowser/win/BrowserView.cpp:
478         (BrowserView::create):
479         * WebKitTestRunner/TestController.cpp:
480         (WTR::createOtherPage):
481         (WTR::TestController::initialize):
482
483 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
484
485         Unreviewed.
486
487         Update the CSSTestSuiteHarness to not scrape the XHTML chapter files
488         for the test order, but instead use information from testinfo.data.
489         
490         * CSSTestSuiteHarness/harness/harness.html:
491         * CSSTestSuiteHarness/harness/harness.js:
492
493 2010-09-28  Kevin Ollivier  <kevino@theolliviers.com>
494
495         [wx] Build fix, don't try to get the svn revision from the git repo when packaging,
496         it causes the process to hang on the gitorious repo.
497
498         * wx/packaging/build-mac-installer.py:
499         * wx/packaging/build-win-installer.py:
500
501 2010-09-28  Adam Roben  <aroben@apple.com>
502
503         Test that a plugin's HWND is sized/positioned before NPP_SetWindow is
504         called
505
506         Reviewed by Anders Carlsson.
507
508         Test for <http://webkit.org/b/46716> <rdar://problem/8482014>
509         Full-page Adobe Reader does not paint until window is resized
510
511         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
512         (PluginTest::NPP_SetWindow): Added. Just returns NPERR_NO_ERROR at
513         this level.
514
515         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Declared
516         NPP_SetWindow.
517
518         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp: Added.
519         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Checks that
520         the plugin's HWND has a non-zero size and that its size/position
521         matches that specified in the NPWindow.
522
523         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
524         (NPP_SetWindow): Call through to the PluginTest.
525
526         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
527         Added WindowGeometryInitializedBeforeSetWindow.cpp, and let VS reorder
528         the files as it saw fit.
529
530 2010-09-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
531
532         Reviewed by Andreas Kling.
533
534         [Qt] Remove support for Qt 4.5
535         https://bugs.webkit.org/show_bug.cgi?id=46718
536
537         Remove the code for versions of Qt prior to 4.6.
538
539         * DumpRenderTree/qt/EventSenderQt.cpp:
540         (EventSender::addTouchPoint):
541         (EventSender::updateTouchPoint):
542         (EventSender::setTouchModifier):
543         (EventSender::touchStart):
544         (EventSender::touchMove):
545         (EventSender::touchEnd):
546         (EventSender::clearTouchPoints):
547         (EventSender::releaseTouchPoint):
548         (EventSender::sendTouchEvent):
549         * DumpRenderTree/qt/EventSenderQt.h:
550         * DumpRenderTree/qt/TextInputControllerQt.cpp:
551         (TextInputController::setMarkedText):
552         * QtTestBrowser/launcherwindow.cpp:
553         (LauncherWindow::LauncherWindow):
554         (LauncherWindow::initializeView):
555         (LauncherWindow::createChrome):
556         (LauncherWindow::sendTouchEvent):
557         (LauncherWindow::eventFilter):
558         (LauncherWindow::applyZoom):
559         (LauncherWindow::setTouchMocking):
560         * QtTestBrowser/launcherwindow.h:
561         * QtTestBrowser/utils.cpp:
562         (urlFromUserInput):
563         * QtTestBrowser/webview.cpp:
564         (WebViewGraphicsBased::animatedFlip):
565         (WebViewGraphicsBased::animatedYFlip):
566         * QtTestBrowser/webview.h:
567         (WebViewGraphicsBased::setYRotation):
568
569 2010-09-28  İsmail Dönmez  <ismail@namtrac.org>
570
571         Reviewed by Andreas Kling.
572
573         Fix DRT compilation on WinCE. Introduce a WCECOMPAT variable
574         which should point to wcecompat installation. Needs wcecompat
575         library from http://github.com/mauricek/wcecompat .
576
577         * DumpRenderTree/qt/DumpRenderTree.pro:
578         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
579         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
580
581 2010-09-28  Daniel Bates  <dbates@rim.com>
582
583         Rollout changeset 68493 <http://trac.webkit.org/changeset/68493>
584         <https://bugs.webkit.org/show_bug.cgi?id=39136>
585
586         Rollout changeset 68493 because it broke Sheriffbot's rollout feature.
587         In particular, this change caused Sheriffbot to raise an exception when
588         trying to parse the bug id on a bug page. We need to look into this
589         some more.
590
591         * Scripts/webkitpy/common/net/bugzilla.py:
592         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
593         * Scripts/webkitpy/tool/bot/sheriff.py:
594         * Scripts/webkitpy/tool/commands/download.py:
595         * Scripts/webkitpy/tool/commands/queues.py:
596         * Scripts/webkitpy/tool/commands/upload.py:
597         * Scripts/webkitpy/tool/steps/closebug.py:
598         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
599         * Scripts/webkitpy/tool/steps/preparechangelog.py:
600         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
601
602 2010-09-28  Adam Barth  <abarth@webkit.org>
603
604         Reviewed by Eric Seidel.
605
606         Move RegressionWindow further up the dependency chain
607         https://bugs.webkit.org/show_bug.cgi?id=46698
608
609         Baby steps towards pushing this information into bug posts.
610
611         * Scripts/webkitpy/common/net/buildbot.py:
612         * Scripts/webkitpy/common/net/buildbot_unittest.py:
613         * Scripts/webkitpy/common/net/regressionwindow.py:
614         * Scripts/webkitpy/tool/commands/queries.py:
615
616 2010-09-27  Daniel Bates  <dbates@rim.com>
617
618         Reviewed by Adam Barth.
619
620         sheriffbot can't roll out security patches
621         https://bugs.webkit.org/show_bug.cgi?id=39136
622
623         Make SheriffBot determine if it's authorized to view a bug
624         whose change it wants to rollout before it tries to rollout
625         the change.
626
627         Moreover, make both webkit-patch and Sheriffbot provide human-
628         readable error messages when they are not authorized to view
629         a bug and when a bug number is invalid.
630
631         Currently, Sheriffbot does not parse Bugzilla bugs for
632         <bug error="...">, which indicates an error when retrieving
633         a bug. In particular, error="NotPermitted" if a person (or bot)
634         is not authorized to view a bug. For such error="NotPermitted" bugs,
635         Sheriffbot raises an exception when parsing the bug report and
636         this exception does not explicitly indicate Sheriffbot's lack
637         of authorization. Instead, Sheriffbot should explicitly check
638         for the presence <bug error="..."> before operating on a bug
639         and error with a human-readable message if it's not permitted
640         to view it.
641
642         * Scripts/webkitpy/common/net/bugzilla.py: Added BugzillaError class.
643         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
644           - Added unit test test_bug_parsing_for_bugzilla_not_permitted_error().
645           - Added unit test test_bug_parsing_for_bugzilla_not_found_error().
646           - Added unit test test_bug_parsing_for_bugzilla_invalid_bug_id_error().
647         * Scripts/webkitpy/tool/bot/sheriff.py: Modified to catch BugzillaError.
648         * Scripts/webkitpy/tool/commands/download.py: Ditto.
649         * Scripts/webkitpy/tool/commands/queues.py: Ditto.
650         * Scripts/webkitpy/tool/commands/upload.py: Ditto.
651         * Scripts/webkitpy/tool/steps/closebug.py: Ditto.
652         * Scripts/webkitpy/tool/steps/obsoletepatches.py: Ditto.
653         * Scripts/webkitpy/tool/steps/preparechangelog.py: Ditto.
654         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: Ditto.
655
656 2010-09-27  Adam Barth  <abarth@webkit.org>
657
658         Reviewed by Eric Seidel.
659
660         Expose more more failure information from Buildbot to SheriffBot
661         https://bugs.webkit.org/show_bug.cgi?id=46697
662
663         This patch moves the information about what tests failured closer to
664         SheriffBot.  There are still a couple more patches to go before
665         SheriffBot can post this information to bugs, but this is a step in
666         that direction.  Yay for unit tests, which caught some bugs in earlier
667         versions of this patch.
668
669         * Scripts/webkitpy/common/net/buildbot.py:
670         * Scripts/webkitpy/common/net/buildbot_unittest.py:
671         * Scripts/webkitpy/common/net/regressionwindow.py: Added.
672         * Scripts/webkitpy/tool/commands/queries.py:
673
674 2010-09-27  Eric Seidel  <eric@webkit.org>
675
676         Unreviewed.  Fixing 500 error seen in the status server.
677
678         It turns out that a = b = []; b.append(1); then a[0] will be 1!
679         This should have been obvious to me, I guess, but it was not what I was expecting.
680
681         * QueueStatusServer/model/activeworkitems.py:
682
683 2010-09-27  Adam Barth  <abarth@webkit.org>
684
685         Reviewed by Eric Seidel.
686
687         commit-queue should reject patches that fail to land
688         https://bugs.webkit.org/show_bug.cgi?id=46694
689
690         This can happen, for example, if there's no reviewer.  Without this
691         patch, we'll keep retrying the patch.
692
693         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
694         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
695
696 2010-09-27  Simon Fraser  <simon.fraser@apple.com>
697
698         Rubber-stamped by Adele Peterson.
699
700         Add a harness for running the CSS 2.1 test suite.
701         
702         This harness assumes that you've got a local a copy of the suite
703         adjacent to the 'harness' directory.
704         
705         The harness lets you go through the tests in chapter order,
706         denoting pass/fail/skipped for each test.
707         
708         It uses a client-side database to store the results of testing.
709
710         * CSSTestSuiteHarness/harness/harness.css: Added.
711         * CSSTestSuiteHarness/harness/harness.html: Added.
712         * CSSTestSuiteHarness/harness/harness.js: Added.
713
714 2010-09-27  Eric Seidel  <eric@webkit.org>
715
716         Reviewed by Adam Barth.
717
718         Patch locks should expire if a patch is marked for retry
719         https://bugs.webkit.org/show_bug.cgi?id=46682
720
721         This was part Adam's original CommitQueueTask design,
722         but support for it was missing from the server.
723         I added the support, but triggering lock-release based on this
724         special "retry" status feels a bit strange so I added a FIXME.
725
726         I also changed the text in queuestatus.html to say "Lock Acquired"
727         since "Last Activity" isn't really true.  We only update the lock
728         date when the patch is started, not on every status update.
729
730         I also noticed an exception in next-patch, which I fixed by re-writing
731         the unzip logic in activeworkitems.py again.
732
733         * QueueStatusServer/handlers/updatestatus.py:
734         * QueueStatusServer/model/activeworkitems.py:
735         * QueueStatusServer/templates/queuestatus.html:
736
737 2010-09-27  Tony Chang  <tony@chromium.org>
738
739         Reviewed by David Levin.
740
741         [chromium] fix a warning when compiling DRT on 32-bit linux
742         https://bugs.webkit.org/show_bug.cgi?id=46641
743
744         * DumpRenderTree/chromium/TestEventPrinter.cpp:
745         (DRTPrinter::handleImage):
746
747 2010-09-27  Eric Seidel  <eric@webkit.org>
748
749         Reviewed by Adam Barth.
750
751         queue-status should report when the patch was last locked to a queue
752         https://bugs.webkit.org/show_bug.cgi?id=46674
753
754         This isn't necessarily the best way to expose this information
755         but having this accessible via the web interface is very
756         useful until we come up with a nicer way to display this.
757
758         I also cleaned up the code in activeworkitems.py a little
759         to use list comprehensions and to have the code work with
760         pairs instead of two lists at once.  Eventually I think those
761         item/time pairs need to be their own little helper class.
762
763         * QueueStatusServer/handlers/queuestatus.py:
764         * QueueStatusServer/model/activeworkitems.py:
765         * QueueStatusServer/templates/queuestatus.html:
766
767 2010-09-27  Tony Chang  <tony@chromium.org>
768
769         Reviewed by David Levin.
770
771         [chromium] fix detection of missing fonts on DRT
772         https://bugs.webkit.org/show_bug.cgi?id=46651
773
774         * DumpRenderTree/chromium/TestShellGtk.cpp:
775         (setupFontconfig):  Only print an error message if lohit isn't found in both locations.
776
777 2010-09-27  Tony Chang  <tony@chromium.org>
778
779         Reviewed by Dimitri Glazkov.
780
781         add webkit unit tests to the chromium testers
782         https://bugs.webkit.org/show_bug.cgi?id=46669
783
784         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
785         * Scripts/run-chromium-webkit-unit-tests: Fix a bug where we weren't using the right configuration.
786
787 2010-09-27  Kwang Yul Seo  <skyul@company100.net>
788
789         Unreviewed.
790
791         Adding myself to the committers list.
792
793         * Scripts/webkitpy/common/config/committers.py:
794
795 2010-09-27  Mihai Parparita  <mihaip@chromium.org>
796
797         Reviewed by Eric Seidel.
798
799         webkitpy.common.system.user_unittest.UserTest.test_prompt_with_list spams the console
800         https://bugs.webkit.org/show_bug.cgi?id=46634
801         
802         Use OutputCapture to prevent console spam (and also check for expected
803         output).
804
805         * Scripts/webkitpy/common/system/user_unittest.py:
806
807 2010-09-27  Eric Seidel  <eric@webkit.org>
808
809         Reviewed by James Robinson.
810
811         start-commit-queue should abort any rebases in progress
812         https://bugs.webkit.org/show_bug.cgi?id=46640
813
814         webkit-patch commit-queue would do this itself, but this just
815         helps ensure that the commit-queue script is properly updated
816         before we run it (in the case where a previous rebase is in
817         progress the git svn rebase would not work before we run the
818         commit-queue).
819
820         * EWSTools/start-commit-queue.sh:
821
822 2010-09-18  Martin Robinson  <mrobinson@igalia.com>
823
824         Reviewed by Gustavo Noronha Silva.
825
826         [GTK] Clean up the DRT fonts.conf and switch to Liberation
827         https://bugs.webkit.org/show_bug.cgi?id=46038
828
829         Switch to Liberation fonts for GTK+ layout tests. This will make our
830         test results metric-compatible with many Windows/Chromium results. It
831         also simplifies the fonts.conf that we load and prepares the way for
832         fixing many font bugs.
833
834         * DumpRenderTree/gtk/DumpRenderTree.cpp:
835         (initializeFonts): Initialize a known list of fonts instead of loading
836         every font in the WEBKIT_TESTFONTS directory.
837         * DumpRenderTree/gtk/fonts.conf: Removed.
838         * DumpRenderTree/gtk/fonts/AHEM____.TTF: Copied from WebKitTools/DumpRenderTree/qt/fonts/AHEM____.TTF.
839         * DumpRenderTree/gtk/fonts/fonts.conf: Added.
840         * GNUmakefile.am: Modify FONTS_CONF_FILE to be FONTS_CONF_DIR, so that
841         we can load both fonts.conf and AHEM____.TTF from this location.
842         * Scripts/old-run-webkit-tests: Remove the check for WEBKIT_TESTFONTS, since
843         it is no longer used.
844
845 2010-09-26  Mihai Parparita  <mihaip@chromium.org>
846
847         Reviewed by Ojan Vafai.
848
849         new-run-webkit-httpd fails if Perl is not installed
850         https://bugs.webkit.org/show_bug.cgi?id=46602
851         
852         Make Port._read_configuration catch all exceptions, since trying to run
853         perl (because of _webkit_build_directory) when it's not installed throws
854         a WindowsError or OSError, not an IOError (this became an issue after 
855         r68268, since ChromiumPort ends up calling Port.default_configuration in
856         its constructor, which means that we're ending up on this codepath in
857         non-NRWT cases too, e.g. for the Chromium NaCl tests, which use
858         new-run-webkit-httpd).
859
860         * Scripts/webkitpy/layout_tests/port/base.py:
861         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
862
863 2010-09-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
864
865         Reviewed by Antonio Gomes.
866
867         [EFL] Add setting API to set a local storage database path.
868         https://bugs.webkit.org/show_bug.cgi?id=45446
869
870         Add a setting API to set local storage database path.
871
872         * EWebLauncher/main.c:
873         (on_key_down):
874         (browserCreate):
875         (main):
876
877 2010-09-26  Sam Weinig  <sam@webkit.org>
878
879         Reviewed by Anders Carlsson.
880
881         Move shared WebKit2 API (used by both bundle and main API) to WebKit2/Shared/API
882         https://bugs.webkit.org/show_bug.cgi?id=46587
883
884         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
885
886 2010-09-26  Antonio Gomes  <agomes@rim.com>
887
888         Reviewed by Kenneth Rohde Christiansen.
889
890         DRT/Mac nodesFromRect support
891
892         [Mac][DRT] Implement LayoutTestController::nodesFromRect
893         https://bugs.webkit.org/show_bug.cgi?id=46580
894
895         Implements LayoutTestController::nodesFromRect for Mac DRT, and
896         adding stubs for GTK+ and Windows.
897
898         * DumpRenderTree/LayoutTestController.cpp:
899         (nodesFromRectCallback):
900         (LayoutTestController::staticFunctions):
901         * DumpRenderTree/LayoutTestController.h:
902         (LayoutTestController::LayoutTestController::nodesFromRect):
903         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
904         (LayoutTestController::nodesFromRect):
905
906 2010-09-25  Nicolas Weber  <thakis@chromium.org>
907
908         Reviewed by Adam Barth.
909
910         https://bugs.webkit.org/show_bug.cgi?id=46555
911         Fix typo in prepare-ChangeLog's help output.
912
913         * Scripts/prepare-ChangeLog:
914
915 2010-09-24  Sam Weinig  <sam@webkit.org>
916
917         Reviewed by Darin Adler.
918
919         Implement WebKit2 callback equivalent to -[WebUIDelegate mouseDidMoveOverElement:modifierFlags:]
920         <rdar://problem/8359279>
921         https://bugs.webkit.org/show_bug.cgi?id=46546
922
923         * MiniBrowser/mac/BrowserWindowController.m:
924         (mouseDidMoveOverElement):
925         (-[BrowserWindowController awakeFromNib]):
926         * MiniBrowser/win/BrowserView.cpp:
927         (mouseDidMoveOverElement):
928         (BrowserView::create):
929         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
930         (WTR::InjectedBundlePage::InjectedBundlePage):
931         * WebKitTestRunner/TestController.cpp:
932         (WTR::createOtherPage):
933         (WTR::TestController::initialize):
934
935 2010-09-24  Mihai Parparita  <mihaip@chromium.org>
936
937         Reviewed by Adam Barth.
938
939         Allow rebaselines for webkit-patch rebaseline to be chosen
940         https://bugs.webkit.org/show_bug.cgi?id=46407
941         
942         Instead of always rebaselining all failing tests, allow a subset to be
943         chosen.
944
945         * Scripts/webkitpy/common/system/user.py:
946         * Scripts/webkitpy/tool/commands/rebaseline.py:
947
948 2010-09-24  Ryosuke Niwa  <rniwa@webkit.org>
949
950         Reviewed by Tony Chang.
951
952         [chromium] Implement TextInputController::firstRectForCharacterRange
953         https://bugs.webkit.org/show_bug.cgi?id=38100
954
955         Implemented TextInputController::firstRectForCharacterRange for chromium platform.
956         No new tests are added since we need to implement the same feature in chromium side
957         in order to enable any tests that uses this function.
958
959         * DumpRenderTree/chromium/TextInputController.cpp:
960         (TextInputController::firstRectForCharacterRange): Added.
961
962 2010-09-24  Adam Barth  <abarth@webkit.org>
963
964         Reviewed by Eric Seidel.
965
966         commit-queue reports land failures as "PASS"
967         https://bugs.webkit.org/show_bug.cgi?id=46530
968
969         We were ignoring the return value of land instead of passing it back to
970         CommitQueue.  Of course, this was the one case I forgot to test!
971
972         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
973         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
974
975 2010-09-24  Kenichi Ishibashi  <bashi@google.com>
976
977         Reviewed by Eric Seidel.
978
979         new-run-webkit-tests prints out nothing when build-dumprendertree fails
980         https://bugs.webkit.org/show_bug.cgi?id=37563
981
982         Print error message when build-dumprendertree fails.
983
984         * Scripts/webkitpy/layout_tests/port/webkit.py:
985         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
986
987 2010-09-24  Mihai Parparita  <mihaip@chromium.org>
988
989         Reviewed by Tony Chang.
990
991         NRWT doesn't respect config set with set-webkit-configuration
992         https://bugs.webkit.org/show_bug.cgi?id=46278
993         
994         Use Port.default_configuration() instead of hardcoding Release in
995         ChromiumPort configuration initialization, so that we still inherit the
996         configuration set by set-webkit-configuration.
997
998         * Scripts/webkitpy/layout_tests/port/chromium.py:
999         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1000
1001 2010-09-24  Chang Shu  <chang.shu@nokia.com>
1002
1003         Reviewed by Csaba Osztrogonác.
1004
1005         [Qt] Fix the code to check file existence.
1006         https://bugs.webkit.org/show_bug.cgi?id=46465
1007
1008         * QtTestBrowser/main.cpp:
1009         (main):
1010
1011 2010-09-23  Tony Chang  <tony@chromium.org>
1012
1013         Unreviewed, rolling out r68232.
1014         http://trac.webkit.org/changeset/68232
1015
1016         Broken NRWT on the canary bots.
1017
1018         * Scripts/webkitpy/layout_tests/port/chromium.py:
1019
1020 2010-09-23  Dirk Pranke  <dpranke@chromium.org>
1021
1022         Unreviewed, build fix.
1023
1024         r68008 broke new-run-webkit-tests in that the chromium ports no
1025         longer respect set-webkit-configuration. The correct fix for this
1026         is being pursued in bug 46278 (along with a bunch of unit tests),
1027         but in the meantime I'm reverting the particular lines that broke
1028         things. This was tested by hand.
1029
1030         * Scripts/webkitpy/layout_tests/port/chromium.py:
1031
1032 2010-09-23  Sam Weinig  <sam@webkit.org>
1033
1034         Reviewed by Anders Carlsson.
1035
1036         WebKit2 API: Need way to know when a frame is removed from the hierarchy
1037         <rdar://problem/8414062>
1038         https://bugs.webkit.org/show_bug.cgi?id=46432
1039
1040         * MiniBrowser/mac/BrowserWindowController.m:
1041         (didRemoveFrameFromHierarchy):
1042         (-[BrowserWindowController awakeFromNib]):
1043         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1044         (WTR::InjectedBundlePage::InjectedBundlePage):
1045         * WebKitTestRunner/TestController.cpp:
1046         (WTR::TestController::initialize):
1047
1048 2010-09-23  Tony Chang  <tony@chromium.org>
1049
1050         Reviewed by Dimitri Glazkov.
1051
1052         [chromium] implement layoutTestController.sampleSVGAnimationForElementAtTime
1053         https://bugs.webkit.org/show_bug.cgi?id=46426
1054
1055         * DumpRenderTree/chromium/LayoutTestController.cpp:
1056         (LayoutTestController::LayoutTestController):
1057         (LayoutTestController::sampleSVGAnimationForElementAtTime):
1058         * DumpRenderTree/chromium/LayoutTestController.h:
1059
1060 2010-09-23  Martin Robinson  <mrobinson@igalia.com>
1061
1062         Reviewed by Nate Chapin.
1063
1064         [GTK] r68199 introduced two test failures
1065         https://bugs.webkit.org/show_bug.cgi?id=46424
1066
1067         Fix a regression handling preference overrides that are attached to boolean properties.
1068
1069         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1070         (LayoutTestController::overridePreference): g_strcasecmp returns 0 when strings match
1071         so we must check for that when converting a string to a boolean.
1072
1073 2010-09-23  Dimitri Glazkov  <dglazkov@chromium.org>
1074
1075         Reviewed by David Levin.
1076
1077         Fix a condition check in ServerProcess, which becomes relevant when reading binary data.
1078         https://bugs.webkit.org/show_bug.cgi?id=46406
1079
1080         This breaks when the method is called with specified size of data (image data), and the
1081         buffer hasn't yet reached this size.
1082
1083         * Scripts/webkitpy/layout_tests/port/server_process.py: Changed to check for values of
1084           index larger than 0.
1085
1086 2010-09-23  Martin Robinson  <mrobinson@igalia.com>
1087
1088         Reviewed by Nate Chapin.
1089
1090         [GTK] Some tests from r68174 fail on the GTK+ bots
1091         https://bugs.webkit.org/show_bug.cgi?id=46396
1092
1093         Simplify LayoutTestController::overridePreference to make it easier for
1094         people unfamiliar with the code to keep the list of preferences up to date.
1095         Add the conversion for enable-hyperlink-auditing.
1096
1097         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1098         (LayoutTestController::overridePreference): Use a simple if-else block to determine
1099         out the property name for overrridePreference. Also simplify the logic for setting
1100         string properties. Add the conversion for enable-hyperlink-auditing.
1101
1102 2010-09-23  Tony Chang  <tony@chromium.org>
1103
1104         Reviewed by David Levin.
1105
1106         [chromium] add caretBrowsingEnabled to WebSettings and DRT
1107         https://bugs.webkit.org/show_bug.cgi?id=46388
1108
1109         * DumpRenderTree/chromium/LayoutTestController.cpp:
1110         (LayoutTestController::overridePreference):
1111         * DumpRenderTree/chromium/WebPreferences.cpp:
1112         (WebPreferences::reset):
1113         (WebPreferences::applyTo):
1114         * DumpRenderTree/chromium/WebPreferences.h:
1115
1116 2010-09-23  Nate Chapin  <japhet@chromium.org>
1117
1118         Reviewed by Darin Fisher.
1119
1120         Allow DRT to toggle hyperlink auditing (i.e., <a ping>).
1121         https://bugs.webkit.org/show_bug.cgi?id=30458
1122
1123         * DumpRenderTree/chromium/LayoutTestController.cpp:
1124         (LayoutTestController::overridePreference):
1125         * DumpRenderTree/chromium/WebPreferences.cpp:
1126         (WebPreferences::reset):
1127         (WebPreferences::applyTo):
1128         * DumpRenderTree/chromium/WebPreferences.h:
1129         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1130         (resetDefaultsToConsistentValues):
1131         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1132         (LayoutTestController::overridePreference):
1133
1134 2010-09-21  Stephen White  <senorblanco@chromium.org>
1135
1136         Reviewed by David Levin.
1137
1138         Implement --enable-accelerated-2d-canvas flag in DumpRenderTree.
1139         https://bugs.webkit.org/show_bug.cgi?id=46208
1140
1141         This flag allows the layout tests to be run with or without accelerated
1142         2D canvas rendering.
1143
1144         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1145         (main):
1146         Declare the new flag string, and check for it on startup.
1147         * DumpRenderTree/chromium/TestShell.cpp:
1148         (TestShell::TestShell):
1149         Add a boolean for the new flag, in order to preserve its value over
1150         preferences reset.
1151         (TestShell::resetWebSettings):
1152         Set the new flag to the stored value on reset.
1153         * DumpRenderTree/chromium/TestShell.h:
1154         (TestShell::setAccelerated2dCanvasEnabled):
1155         Add an accessor for the new flag.
1156         * DumpRenderTree/chromium/WebPreferences.cpp:
1157         (WebPreferences::reset):
1158         Initialize the new flag to false.
1159         (WebPreferences::applyTo):
1160         Copy the flag's value to the WebSettings.
1161         * DumpRenderTree/chromium/WebPreferences.h:
1162         Add the new flag.
1163
1164 2010-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1165
1166         Reviewed by Simon Hausmann.
1167
1168         [Qt] Refactor QtWebKitPlatformPlugin interface
1169
1170         Make it easier to keep source-compability for the
1171         QtWebKitPlatformPlugin interface, and run qmake
1172         on the example (but not build) for convenience. 
1173
1174         https://bugs.webkit.org/show_bug.cgi?id=46345
1175
1176         * Scripts/webkitdirs.pm:
1177
1178 2010-09-23  Adam Barth  <abarth@webkit.org>
1179
1180         Reviewed by Eric Seidel.
1181
1182         Tweak some status messages that Eric thought were confusing
1183         https://bugs.webkit.org/show_bug.cgi?id=46342
1184
1185         * Scripts/webkitpy/tool/commands/queues.py:
1186         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1187
1188 2010-09-22  Adam Barth  <abarth@webkit.org>
1189
1190         Reviewed by Eric Seidel.
1191
1192         Fix comm-queue typo
1193         https://bugs.webkit.org/show_bug.cgi?id=46339
1194
1195         We were missing a "self".  The real problem is that we didn't have an
1196         integration test for the failure case.
1197
1198         * Scripts/webkitpy/tool/commands/queues.py:
1199         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1200
1201 2010-09-22  Adam Barth  <abarth@webkit.org>
1202
1203         Reviewed by Eric Seidel.
1204
1205         commit-queue should log more detailed messages to the QueueStatusServer
1206         https://bugs.webkit.org/show_bug.cgi?id=46333
1207
1208         When I created CommitQueueTask, I removed most of the previous logging.
1209         This patch adds back more detailed logging so folks can see their patch
1210         progress through the queue.
1211
1212         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1213         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1214         * Scripts/webkitpy/tool/commands/queues.py:
1215         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1216
1217 2010-09-22  Mihai Parparita  <mihaip@chromium.org>
1218
1219         Reviewed by Darin Fisher.
1220
1221         [Chromium] User style layout tests don't pass on Chromium
1222         https://bugs.webkit.org/show_bug.cgi?id=46069
1223
1224         Fix a typo in LayoutTestController::addUserStyleSheet that was causing a
1225         crash the Chromium DRT. Pass InjectInExistingDocuments to mimic DRT
1226         behavior from other ports.
1227
1228         * DumpRenderTree/chromium/LayoutTestController.cpp:
1229         (LayoutTestController::addUserStyleSheet):
1230
1231 2010-09-22  Brent Fulgham  <bfulgham@webkit.org>
1232
1233         Reviewed by Martin Robinson.
1234
1235         [WinCairo] Part 2: Update WebKitTestRunner and DumpRenderTree Build.
1236         https://bugs.webkit.org/show_bug.cgi?id=46303.
1237
1238         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added.
1239         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Moved
1240         CoreFoundation-specific stuff to new MiniBrowserCoreFoundation
1241         property sheet.
1242         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added.
1243         * MiniBrowser/MiniBrowser.vcproj: Updated configuration to use
1244         appropriate property sheet for the build types.
1245         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Updated the
1246         configuration to use appropriate property sheet for CoreFoundation
1247         and CFLite-style builds.
1248
1249 2010-09-22  Adam Barth  <abarth@webkit.org>
1250
1251         Reviewed by Eric Seidel.
1252
1253         Optimize commit-queue performance for green trees
1254         https://bugs.webkit.org/show_bug.cgi?id=46254
1255
1256         This patch redesigns the controller logic for the commit-queue.  In the
1257         new design, the controller exercises much finer-grained control over
1258         the landing process.  In particular:
1259
1260         - Patches that fail to apply now get rejected almost immediately.
1261         - Patches that fail to build get rejects after two builds (instead of
1262           three builds and one test run).
1263         - Patches that run into a flaky test now get accepted after one build
1264           and two test runs instead of three full build-and-test runs.
1265
1266         The main cost of these optimizations is that we don't find out the tree
1267         has a failing test until the very end of the process, but if the tree
1268         has a busted test, there's not much we can do anyway.  We might as well
1269         burn commit-queue resources spinning optimisticly.
1270
1271         * Scripts/webkitpy/tool/bot/commitqueuetask.py: Added.
1272         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: Added.
1273         * Scripts/webkitpy/tool/commands/queues.py:
1274
1275 2010-09-22  Brent Fulgham  <bfulgham@webkit.org>
1276
1277         Reviewed by Martin Robinson.
1278
1279         [WinCairo] Update WebKitTestRunner and DumpRenderTree Build.
1280         https://bugs.webkit.org/show_bug.cgi?id=46303.
1281
1282         * DumpRenderTree/win/DumpRenderTree.vcproj: Disable local MD5 sources
1283         for Cairo build. Copy wtf MD5 header to ForwardingHeaders for the
1284         WinCairo build.
1285         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added.
1286         * WebKitTestRunner/win/InjectedBundle.vcproj: Update win new *_Cairo
1287         build targets that use the new InjectedBundleCFLite.vsprops file.
1288
1289 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
1290
1291         Unreviewed, build fix.
1292
1293         Fix bustage of rebaseline-chromium-webkit-tests resulting from
1294         r67974. Really need better unit tests for this tool :(
1295
1296         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1297
1298 2010-09-22  Adam Roben  <aroben@apple.com>
1299
1300         Unbreak test-webkitpy
1301
1302         * Scripts/webkitpy/test/main.py:
1303         (Tester.run_tests): Add a line that mysteriously got deleted.
1304
1305 2010-09-22  Adam Roben  <aroben@apple.com>
1306
1307         Make test-webkitpy test WebKit2's scripts
1308
1309         These scripts can't be in WebKitTools due to limitations of Apple's
1310         build process. But that doesn't mean we can't test them!
1311
1312         Fixes <http://webkit.org/b/46297> test-webkitpy should test code in
1313         WebKit2/Scripts
1314
1315         Reviewed by Adam Barth.
1316
1317         * Scripts/test-webkitpy:
1318         (_clean_packages_with_test): Renamed from _clean_webkitpy_with_test.
1319         Now takes an external_package_paths parameter and cleans both webkitpy
1320         and any external packages.
1321         (init): Added an external_package_paths parameter which we pass along
1322         to _clean_packages_with_test.
1323         (top level): Add WebKit2/Scripts/webkit2 as our only external package
1324         and pass it along to init and Tester.run_tests.
1325
1326         * Scripts/webkitpy/test/main.py:
1327         (Tester.run_tests): Added an optional external_package_paths
1328         parameter. We modify sys.path so that the external packages can be
1329         imported, and search for unittest files inside all external packages
1330         in addition to inside webkitpy.
1331
1332 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
1333
1334         Reviewed by Tony Chang.
1335
1336         new-run-webkit-tests: r68063 broke linux python tests
1337
1338         Add a missing "from __future__ import with_statement" to this
1339         new file; the perils of testing only on the Mac and by review :(
1340
1341         https://bugs.webkit.org/show_bug.cgi?id=46293
1342
1343         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1344
1345 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
1346
1347         Reviewed by Tony Chang.
1348
1349         Add a 'chromium-gpu' set of ports that will test the accelerated
1350         GPU paths. This patch adds:
1351
1352         - support for the '--accelerated-compositing' and
1353           'accelerated-2d-canvas' flags to new-run-webkit-tests (and the
1354           'no-' flags)
1355         - adds a new set of Ports that will look under
1356           platform/chromium-gpu-$OS/ for baselines before looking in the
1357           regular chromium search path
1358         - adds a new test_expectations.txt file in platform/chromium-gpu
1359           that skips all but the tests we actually want to run with
1360           acceleration.
1361
1362         This patch will allow us to run both with and without acceleration
1363         and to change the defaults for both the regular and -gpu options
1364         as the code evolves.
1365
1366         We plan to add both --chromium-$OS and --chromium-gpu-$OS runs to
1367         each test bot.
1368
1369         https://bugs.webkit.org/show_bug.cgi?id=46225
1370
1371         * Scripts/webkitpy/layout_tests/port/chromium.py:
1372         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1373         * Scripts/webkitpy/layout_tests/port/factory.py:
1374         * Scripts/webkitpy/layout_tests/port/webkit.py:
1375
1376 2010-09-22  Jamey Hicks  <jamey.hicks@nokia.com>
1377
1378         Reviewed by Kenneth Rohde Christiansen.
1379
1380         [Qt] Web Inspector: Remote Web Inspector support for QtWebKit
1381         https://bugs.webkit.org/show_bug.cgi?id=43988
1382
1383         Runs a web debug server on port specified by QtTestBrowser
1384         argument -remote-inspector-port. Property
1385         _q_webInspectorServerPort of the QWebPage instance will be set
1386         according to the argument. All pages with that property set will
1387         be remotely inspectable.
1388
1389         URL for remote inspection of first QWebPage is
1390             http://localhost:9222/webkit/inspector/inspector.html?page=1
1391         where 1 is the number of the QWebPage instance.
1392
1393         The base URL yields an index page with links to the individual inspectors:
1394             http://localhost:9222/
1395
1396         * QtTestBrowser/launcherwindow.cpp:
1397         (LauncherWindow::init):
1398         * QtTestBrowser/launcherwindow.h:
1399         * QtTestBrowser/main.cpp:
1400         (LauncherApplication::handleUserOptions):
1401
1402 2010-09-22  Adam Roben  <aroben@apple.com>
1403
1404         Fix webkit-patch failure-reason now that build.webkit.org has been
1405         updated
1406
1407         Fixes <http://webkit.org/b/46273> webkit-patch failure-reason crashes
1408         every time
1409
1410         Reviewed by Eric Seidel.
1411
1412         * Scripts/webkitpy/common/net/buildbot.py:
1413         (BuildBot._file_cell_text): Added. Travels down the firstChild chain
1414         looking for an element that contains text, then returns it.
1415         (BuildBot._parse_twisted_file_row): Use _file_cell_text to get the
1416         text out of the cells. This way it doesn't matter whether the cells
1417         have <b> children (as for cells in directory rows) or not (as for
1418         cells in file rows)
1419         (BuildBot._parse_twisted_directory_listing): Look for rows that have
1420         the "directory" or "file" class, rather than rows with any class,
1421         since header rows now have a class attribute.
1422
1423         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1424         (BuildBotTest._example_directory_listing): Updated to more closely
1425         match the markup that build.webkit.org is producing now.
1426
1427 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
1428
1429         Unreviewed, build fix.
1430
1431         new-run-webkit-tests: fix bug introduced in r68008 where if you
1432         specify --chromium and no --platform, and you're running on
1433         windows, you use the 'chromium-win' port by default instead of the
1434         version-specific port. This breaks the buildbots.
1435
1436         It will be good for this refactoring to settle down so I can
1437         rewrite the logic for default ports and the unit tests to be
1438         clearer (and the testing more comprehensive).
1439
1440         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1441
1442 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
1443
1444         Reviewed by Adam Barth.
1445
1446         Modify the Port interface to take only a series of keyword arguments
1447         in the constructor, and modify Port/factory.get() to accomodate that,
1448         and to accept user=XXX as an argument so we can pass
1449         webkitpy.common.system.user.User objects in.
1450
1451         Then, modify new-run-webkit-tests and rebaseline-chromium-webkit-tests
1452         to use the common routine in webkitpy.common.system.user.open_url()
1453         to display HTML files.
1454
1455         There was a routine in the Port interface to do the same thing,
1456         but I see no need for a port-specific hook for this, since it is
1457         something that will always be executed by the host environment
1458         and displaying web pages has nothing to do with running layout tests.
1459
1460         Note that new-run-webkit-tests used to use test_shell to display
1461         the page; this is potentially useful so that you can actually click
1462         from a result to the broken page; however, since DumpRenderTree
1463         doesn't support this functionality, it will be going away eventually.
1464
1465         https://bugs.webkit.org/show_bug.cgi?id=46128
1466
1467         * Scripts/webkitpy/layout_tests/port/base.py:
1468         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1469         * Scripts/webkitpy/layout_tests/port/chromium.py:
1470         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1471         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1472         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1473         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1474         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1475         * Scripts/webkitpy/layout_tests/port/factory.py:
1476         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1477         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1478         * Scripts/webkitpy/layout_tests/port/gtk.py:
1479         * Scripts/webkitpy/layout_tests/port/mac.py:
1480         * Scripts/webkitpy/layout_tests/port/qt.py:
1481         * Scripts/webkitpy/layout_tests/port/test.py:
1482         * Scripts/webkitpy/layout_tests/port/webkit.py:
1483         * Scripts/webkitpy/layout_tests/port/win.py:
1484         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1485         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1486         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1487
1488 2010-09-21  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
1489
1490         Reviewed by Kenneth Rohde Christiansen.
1491
1492         [EFL] Get fresh theme when running EWebLauncher
1493         https://bugs.webkit.org/show_bug.cgi?id=46210
1494
1495         If user tried to run EWebLauncher outside of the build tree, it would
1496         not find the theme and fallback to the installed one. However, since
1497         EWebLauncher is not installed, we always want to take the theme from
1498         the just compiled source code. If user had never installed WebKit's
1499         EFL port it could even receive a segv since no theme would be found.
1500
1501         Now EWebLauncher does not fallback to the installed theme and CMake
1502         gives as DATA_DIR the directory of the theme it has just built.
1503
1504         * CMakeListsEfl.txt: Pass the build directory as DATA_DIR to
1505         EWebLauncher.
1506         * EWebLauncher/main.c: Use only the theme from build director. Do not
1507         fallback to others as this could hide real bugs.
1508         (quit):
1509         (browserCreate):
1510         (findThemePath):
1511         (main):
1512
1513 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
1514
1515         Unreviewed, build fix.
1516
1517         Don't pass the --test-shell arg to the Chromium Mac port of DRT;
1518         it just confuses it.
1519
1520         https://bugs.webkit.org/show_bug.cgi?id=46230
1521
1522         * Scripts/webkitpy/layout_tests/port/webkit.py:
1523
1524 2010-09-21  Lucas Forschler  <lforschler@apple.com>
1525
1526         Reviewed by Stephanie Lewis.
1527
1528         Make a new buildbot for Leopard Debug Test
1529
1530         * BuildSlaveSupport/build.webkit.org-config/config.json:
1531
1532 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
1533
1534         Unreviewed, build fix.
1535
1536         Fix breakage of Chromium Mac DRT port caused by r67905.
1537
1538         https://bugs.webkit.org/show_bug.cgi?id=46230
1539
1540         * Scripts/webkitpy/layout_tests/port/webkit.py:
1541
1542 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
1543
1544         Unreviewed, build fix.
1545
1546         Add missing import of 'tempfile'.
1547
1548         * Scripts/webkitpy/layout_tests/port/chromium.py:
1549
1550 2010-09-17  Dirk Pranke  <dpranke@chromium.org>
1551
1552         Reviewed by Ojan Vafai.
1553
1554         new-run-webkit-tests: pull the list of tests from the Port, and
1555            make it possible to run with no actual test files in the filesystem.
1556
1557         This set of changes allows us to delete the special
1558         webkitpy/layout_tests/data directory and test the generic code without
1559         touching the filesystem (except to write results). This speeds up
1560         test-webkitpy substantially.
1561
1562         This also cleans up and removes several code paths in the generic
1563         code and fixes some minor bugs, notably in the test_expectations
1564         parsing, which was previously fragile if the tests weren't present.
1565
1566         We also change the way we diff image results to be able to do so
1567         in memory, without relying on files. This slows down chromium
1568         test_shell, which always writes images to files, but should speed
1569         up DRT and ImageDiff-based implementations slightly.
1570
1571         Note that pulling the list of tests to run from the Port will allow
1572         ports to specify what tests to run as an inclusive list; previously
1573         you could only do this as an exclusive list by using a 
1574         test_expectations file or Skipped files; nothing actually uses this
1575         feature yet and it's unclear if it should be used.
1576
1577         Note that there are no functional changes -- apart from now 
1578         always printing out the location of the checksum file when we are
1579         tracing test runs -- and the total number of lines of non-test code
1580         actually drops by two.
1581
1582         There is some more cleanup that can be done in the Port/Driver 
1583         interface and in some handling of filenames, but I'll save that
1584         for another change.
1585
1586         https://bugs.webkit.org/show_bug.cgi?id=45801
1587
1588         * Scripts/webkitpy/layout_tests/data/*: Removed.
1589             - no longer need special mock layout_tests_directory in the
1590               repository.
1591         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1592             - add code to display missing text files, checksums when tracing
1593             - update to not look at the filesystem directly.
1594         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1595             - add more unit tests
1596         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1597             - remove tests_are_present flag
1598             - update with changes in Port interface - no longer access
1599               the filesystem directly, although we still use os.path for
1600               filename manipulation.
1601         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1602             - add more unit tests
1603         * Scripts/webkitpy/layout_tests/layout_package/test_files.py: Removed.
1604             - renamed to port/test_files.py
1605         * Scripts/webkitpy/layout_tests/port/base.py:
1606             - change diff_image() to expect actual image data, not filenames
1607             - add expected_checksum(), expected_image(), expected_text() to
1608               return the content of the files so that we don't need a filesystem
1609             - add path_exists(), path_isdir() for filesystem-like access.
1610             - add test_dirs() to keep clobber-test-results from needing to
1611               actually look at a real layout tests dir
1612             - add tests() to return the list of tests to run on the port
1613               (calls port/test_files to do the work).
1614             - add update_baseline() to be able to save new baselines
1615             - add uri_to_test_name() from port/dryrun.py so we can easily check
1616               filename_to_uri()
1617         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1618             - add more unit tests
1619         * Scripts/webkitpy/layout_tests/port/chromium.py:
1620             - change diff_image() to accept image content, not filenames.
1621               This will be slower for test_shell/image_diff, but faster
1622               for DRT/ImageDiff.
1623         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1624             - add more unit tests
1625         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1626             - simplify greatly
1627         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1628             - add more unit tests
1629         * Scripts/webkitpy/layout_tests/port/test.py:
1630             - massive rewrite to use in-script list of tests and expectations
1631         * Scripts/webkitpy/layout_tests/port/test_files.py:
1632             - rename from layout_package/test_files.
1633         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1634             - add unit tests
1635         * Scripts/webkitpy/layout_tests/port/webkit.py:
1636             - update diff_image() to take image contents, not files. Should
1637               make things slightly faster.
1638         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1639             - update with changes to diff_image()
1640         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1641             - update with changes to diff_image()
1642         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1643             - remove tests_are_present from test_expectations
1644             - pull the list of tests from port.tests() instead
1645               of calling test_files.py directly.
1646         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1647             - update unit tests
1648         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1649             - update with changes to 
1650         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1651             - update with change in Port interface
1652         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1653             - update with change in Port interface
1654         * Scripts/webkitpy/style/checkers/test_expectations.py:
1655             - remove the tests_are_present flag
1656
1657 2010-09-21  Anders Carlsson  <andersca@apple.com>
1658
1659         Disable logging.
1660
1661         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
1662
1663 2010-09-21  Tony Chang  <tony@chromium.org>
1664
1665         Reviewed by Kent Tamura.
1666
1667         add a script for running webkit_unit_tests
1668         https://bugs.webkit.org/show_bug.cgi?id=46014
1669
1670         * Scripts/run-chromium-webkit-unit-tests: Added.
1671
1672 2010-09-21  Fridrich Strba  <fridrich.strba@bluewin.ch>
1673
1674         Reviewed by Martin Robinson.
1675
1676         Fix linking problems on Windows.
1677         https://bugs.webkit.org/show_bug.cgi?id=45844
1678
1679         * GNUmakefile.am: link the executables with winmm.dll
1680
1681 2010-09-21  Adam Barth  <abarth@webkit.org>
1682
1683         Reviewed by Eric Seidel.
1684
1685         feeder-queue svn updates more often than needed
1686         https://bugs.webkit.org/show_bug.cgi?id=46171
1687
1688         We don't need to poll SVN every time we feed the feeders.  Rather, we
1689         can count on the wrapper shell script to auto-update the queue.
1690
1691         * Scripts/webkitpy/tool/commands/queues.py:
1692         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1693
1694 2010-09-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1695
1696         Reviewed by Andreas Kling.
1697
1698         [Qt] Add robot loader timeout and extra time options.
1699         https://bugs.webkit.org/show_bug.cgi?id=46172
1700
1701         [-robot-timeout <s>]: Load the next page after s seconds if the current
1702         page didn't finish loading.
1703         [-robot-extra-time <s>]: Wait s seconds after the current page finished
1704         loading before loading the next one. This should allow some time for the
1705         page's JavaScript to execute.
1706
1707         * QtTestBrowser/launcherwindow.cpp:
1708         (LauncherWindow::applyPrefs):
1709         * QtTestBrowser/main.cpp:
1710         (LauncherApplication::robotTimeout):
1711         (LauncherApplication::robotExtraTime):
1712         (LauncherApplication::LauncherApplication):
1713         (LauncherApplication::handleUserOptions):
1714         (main):
1715         * QtTestBrowser/urlloader.cpp:
1716         (UrlLoader::UrlLoader):
1717         (UrlLoader::loadNext):
1718         (UrlLoader::loadUrlList):
1719         * QtTestBrowser/urlloader.h:
1720
1721 2010-09-21  Pavel Podivilov  <podivilov@chromium.org>
1722
1723         Unreviewed.
1724
1725         Adding myself to the committers list.
1726
1727         * Scripts/webkitpy/common/config/committers.py:
1728
1729 2010-09-20  Philippe Normand  <pnormand@igalia.com>
1730
1731         Reviewed by Eric Carlson.
1732
1733         [GTK] enhanced context menu for media elements
1734         https://bugs.webkit.org/show_bug.cgi?id=45021
1735
1736         EventSender::contextClick() now returns an array of js
1737         objects. Each object has a title property and a click() method.
1738
1739         * DumpRenderTree/gtk/EventSender.cpp:
1740         (getMenuItemTitleCallback):
1741         (setMenuItemTitleCallback):
1742         (menuItemClickCallback):
1743         (getMenuItemClass):
1744         (contextClickCallback):
1745
1746 2010-09-20  Hayato Ito  <hayato@chromium.org>
1747
1748         Unreviewed.
1749         Adding myself to the committers list.
1750
1751         * Scripts/webkitpy/common/config/committers.py:
1752
1753 2010-09-20  Adam Barth  <abarth@webkit.org>
1754
1755         Reviewed by Eric Seidel.
1756
1757         The tool member variable should be called _tool
1758         https://bugs.webkit.org/show_bug.cgi?id=46160
1759
1760         Created by find-and-replace.
1761
1762         * Scripts/webkitpy/tool/commands/download.py:
1763         * Scripts/webkitpy/tool/commands/openbugs.py:
1764         * Scripts/webkitpy/tool/commands/queries.py:
1765         * Scripts/webkitpy/tool/commands/queues.py:
1766         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1767         * Scripts/webkitpy/tool/commands/rebaseline.py:
1768         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1769         * Scripts/webkitpy/tool/commands/upload.py:
1770         * Scripts/webkitpy/tool/multicommandtool.py:
1771
1772 2010-09-20  Adam Barth  <abarth@webkit.org>
1773
1774         I ran the tests before landing but ignored the fact that they failed.  :(
1775
1776         * Scripts/webkitpy/tool/commands/queues.py:
1777
1778 2010-09-20  Adam Barth  <abarth@webkit.org>
1779
1780         Reviewed by Eric Seidel.
1781
1782         Add a feeder queue that polls bugs.webkit.org for the commit-cluster
1783         https://bugs.webkit.org/show_bug.cgi?id=46141
1784
1785         The feeder-queue polls bugs.webkit.org every 30 seconds and updates the
1786         list of work items on the status server.  The individual commit-cluster
1787         nodes then grab the patches from the server and process them.
1788
1789         * Scripts/webkitpy/tool/bot/feeders.py: Added.
1790         * Scripts/webkitpy/tool/bot/feeders_unittest.py: Added.
1791         * Scripts/webkitpy/tool/commands/queues.py:
1792         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1793         * Scripts/webkitpy/tool/commands/queuestest.py:
1794
1795 2010-09-20  Leandro Pereira  <leandro@profusion.mobi>
1796
1797         Reviewed by Darin Adler.
1798
1799         build-webkit: Add support for CMake build system
1800         https://bugs.webkit.org/show_bug.cgi?id=44979
1801
1802         * Scripts/build-webkit: Add "--efl" command-line option to build the
1803         EFL port of WebKit.
1804         * Scripts/webkitdirs.pm: Define buildCMakeProject() and
1805         buildEflCMakeProject() subroutines.
1806
1807 2010-09-20  Dirk Pranke  <dpranke@chromium.org>
1808
1809         Reviewed by Ojan Vafai.
1810
1811         new-run-webkit-tests: refactor command line args getting passed to DRT
1812
1813         This change cleans up some argument parsing between functions to get
1814         rid of some overlapping data structures. There should be no functional
1815         changes in this patch; it is pure refactoring in preparation for
1816         landing the Chrome GPU port and adding a generic way to pass
1817         args to DRT/TestShell.
1818
1819         https://bugs.webkit.org/show_bug.cgi?id=46135
1820
1821         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1822           - pass the options argument explicitly to the threads and drivers,
1823             also consolidate the passing of options to the driver.
1824           - pass options directly to process_output() to remove a couple
1825             parameters (minor cleanup).
1826         * Scripts/webkitpy/layout_tests/port/base.py:
1827           - pass the options argument to Port.create_driver().
1828         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1829           - update Port.create_driver() test
1830         * Scripts/webkitpy/layout_tests/port/chromium.py:
1831           - pass the options argument to Port.create_driver(), and clean up
1832             building of the cmd line for DRT.
1833         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1834           - pass the options argument to Port.create_driver()
1835         * Scripts/webkitpy/layout_tests/port/test.py:
1836           - pass the options argument to Port.create_driver()
1837         * Scripts/webkitpy/layout_tests/port/webkit.py:
1838           - pass the options argument to Port.create_driver(), and clean up
1839             building of the cmd line for DRT.
1840         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1841           - consolidate args in _get_dump_render_tree_args and rename to
1842             _get_test_args(); move all of the command-line args to the
1843             Port implementations.
1844
1845 2010-09-20  Andrew Wilson  <atwilson@chromium.org>
1846
1847         Revert change which was accidentally committed along with some expectation changes.
1848
1849         * Scripts/webkitpy/layout_tests/port/base.py:
1850
1851 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
1852
1853         Reviewed by Adam Barth.
1854
1855         Add explicit --force-patch flag to webkitpy tools
1856         https://bugs.webkit.org/show_bug.cgi?id=46103
1857         
1858         It wasn't obvious until I read the applypatch.py source code that
1859         --non-interfactive implies passing --force to patch. Add --force-patch
1860         as an alias to the flag, so that this behavior is more discoverable.
1861
1862         * Scripts/webkitpy/tool/steps/applypatch.py:
1863         * Scripts/webkitpy/tool/steps/options.py:
1864
1865 2010-09-20  Eric Seidel  <eric@webkit.org>
1866
1867         Unreviewed, adding a line which got dropped and is trivially correct (and tested).
1868
1869         commit-queue can't land patches
1870         https://bugs.webkit.org/show_bug.cgi?id=46138
1871
1872         Add a line of code I forgot in my last commit.
1873
1874         * Scripts/webkitpy/common/net/bugzilla.py:
1875         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
1876
1877 2010-09-20  Adam Barth  <abarth@webkit.org>
1878
1879         Reviewed by Eric Seidel.
1880
1881         The commit-cluster bots still race to lock patch_ids
1882         https://bugs.webkit.org/show_bug.cgi?id=46130
1883
1884         It turns out we need to use a transaction object to make the
1885         read/modify/write lock operation atomic.  From reading the AppEngine
1886         documentation, I think this patch should do what we want.  It's hard to
1887         test locally because the test instance isn't distributed in the same
1888         way the production instance is.
1889
1890         * QueueStatusServer/handlers/nextpatch.py:
1891         * QueueStatusServer/model/activeworkitems.py: Added.
1892
1893 2010-09-20  Andy Estes  <aestes@apple.com>
1894
1895         Reviewed by Adam Barth.
1896
1897         REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
1898         https://bugs.webkit.org/show_bug.cgi?id=40961
1899
1900         Implement WebKitUsePreHTML5ParserQuirks preference.
1901
1902         * DumpRenderTree/mac/DumpRenderTree.mm:
1903         (resetDefaultsToConsistentValues): Reset WebKitUsePreHTML5ParserQuirks
1904         to false after a test finishes.
1905
1906 2010-09-20  Adam Roben  <aroben@apple.com>
1907
1908         Windows build fix
1909
1910         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Put
1911         $(WebKitOutputDir)\include before $(WebKitLibrariesDir)\include so
1912         we'll pick up the most recent versions of the headers.
1913
1914 2010-09-20  Eric Seidel  <eric@webkit.org>
1915
1916         Reviewed by Adam Barth.
1917
1918         commit-queue should check commit-queue+ again just before committing
1919         https://bugs.webkit.org/show_bug.cgi?id=32679
1920
1921         Added a _revalidate_patch check, right before landing.
1922
1923         Since _revalidate_patch passes the patch_id from the work item
1924         back to bugzilla, I had to fix all of the previous queue tests to
1925         use valid attachment ids (that's the majority of this change).
1926
1927         In order to validate that the bug was still open, I had to teach
1928         bugzilla.Bug about open/closed states.
1929
1930         * Scripts/webkitpy/common/net/bugzilla.py:
1931         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1932         * Scripts/webkitpy/tool/commands/queues.py:
1933         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1934         * Scripts/webkitpy/tool/commands/queuestest.py:
1935         * Scripts/webkitpy/tool/mocktool.py:
1936
1937 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
1938
1939         Unreviewed.
1940
1941         Adding myself as a comitter.
1942
1943         * Scripts/webkitpy/common/config/committers.py:
1944
1945 2010-09-20  Adam Barth  <abarth@webkit.org>
1946
1947         Reviewed by Eric Seidel.
1948
1949         Two instances of commit-queue try to process the same patch
1950         https://bugs.webkit.org/show_bug.cgi?id=46113
1951
1952         This patch makes next-patch atomic so that the server won't vend the
1953         same patch twice in the same hour.
1954
1955         * QueueStatusServer/handlers/nextpatch.py:
1956
1957 2010-09-20  Adam Roben  <aroben@apple.com>
1958
1959         Make WebKitTestRunner's wait-to-dump watchdog timer work on Windows
1960
1961         We were previously trying to use a CFRunLoopTimer, but since Windows
1962         doesn't use CFRunLoop on most threads this doesn't work. Now we use a
1963         Windows-style timer on Windows.
1964
1965         I also replaced all uses of "watchdog" with "watchdog timer".
1966
1967         Fixes <http://webkit.org/b/46101> WebKitTestRunner's wait-to-dump
1968         watchdog timer doesn't work on Windows
1969
1970         Reviewed by Anders Carlsson.
1971
1972         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1973         (WTR::InjectedBundlePage::dump): Updated for rename.
1974
1975         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Removed
1976         platform-specific functions.
1977         (WTR::LayoutTestController::LayoutTestController): Added call to
1978         platformInitialize.
1979         (WTR::LayoutTestController::waitUntilDone): Changed to call
1980         initializeWaitToDumpWatchdogTimerIfNeeded instead of doing the work
1981         right in this function.
1982         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Updated for
1983         rename.
1984
1985         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added new
1986         members needed to support the watchdog timer abstraction. Replaced
1987         some "watchdog"s with "watchdog timer".
1988
1989         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
1990         Added.
1991         (WTR::LayoutTestController::platformInitialize): Does nothing on this
1992         platform.
1993         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Moved here
1994         from LayoutTestController.cpp and changed to use an early return.
1995         (WTR::waitUntilDoneWatchdogTimerFired): Moved here from
1996         LayoutTestController.cpp.
1997         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
1998         Moved code here from LayoutTestController::waitUntilDone and changed
1999         to use an early return.
2000
2001         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
2002         Added.
2003         (WTR::LayoutTestController::platformInitialize): Initialize our
2004         watchdog timer.
2005         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Added.
2006         Kills and clears the watchdog timer.
2007         (WTR::waitToDumpWatchdogTimerFired): Added. Calls through to the
2008         LayoutTestController member function of the same name.
2009         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
2010         Added. Sets up the timer if it isn't already set.
2011
2012         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added
2013         LayoutTestControllerMac.mm.
2014
2015         * WebKitTestRunner/win/InjectedBundle.vcproj: Added
2016         LayoutTestControllerWin.cpp.
2017
2018 2010-09-20  Martin Robinson  <mrobinson@igalia.com>
2019
2020         Reviewed by Daniel Bates.
2021
2022         [GTK] fast/forms/listbox-selection.html fails
2023         https://bugs.webkit.org/show_bug.cgi?id=45942
2024
2025         Use the gdkModifersFromJSValue helper to parse all appropriate modifier
2026         strings in keyDownCallback.
2027
2028         * DumpRenderTree/gtk/EventSender.cpp:
2029         (keyDownCallback): Use the gdkModifersFromJSValue instead of duplicating the 
2030         modifier parsing logic.
2031
2032 2010-09-19  Sam Weinig  <sam@webkit.org>
2033
2034         Reviewed by Anders Carlsson.
2035
2036         WebKit2 decidePolicyForNavigationAction should include mouse button information
2037         <rdar://problem/8413165>
2038         https://bugs.webkit.org/show_bug.cgi?id=46060
2039
2040         * MiniBrowser/mac/BrowserWindowController.m:
2041         (decidePolicyForNavigationAction):
2042         (decidePolicyForNewWindowAction):
2043
2044 2010-09-19  Daniel Bates  <dbates@rim.com>
2045
2046         Reviewed by Martin Robinson.
2047
2048         Add unit tests for diffs that delete or modify a change log entry
2049         or describe changes that are far apart
2050         https://bugs.webkit.org/show_bug.cgi?id=46046
2051
2052         Add additional unit tests to test change log diffs that contain
2053         deletions or changes that are far apart from each other in the
2054         ChangeLog file.
2055
2056         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
2057           - Added the following unit tests:
2058           "fixChangeLogPatch: [no change] In-place change."
2059           "fixChangeLogPatch: [no change] Remove first entry."
2060           "fixChangeLogPatch: [no change] Remove entry in the middle."
2061           "fixChangeLogPatch: [no change] Far apart changes (i.e. more than one chunk)."
2062
2063 2010-09-19  Sam Weinig  <sam@webkit.org>
2064
2065         Reviewed by Anders Carlsson.
2066
2067         Replace WKBundleRangeRef with WKBundleRangeHandleRef.
2068         https://bugs.webkit.org/show_bug.cgi?id=46054
2069
2070         The new one acts like WKBundleNodeHandleRef and allows for getting a
2071         wrapper in a specific world for the handle.
2072
2073         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2074         (WTR::propertyValue):
2075         (WTR::propertyValueDouble):
2076         (WTR::propertyValueInt):
2077         (WTR::numericWindowPropertyValue):
2078         (WTR::toStr):
2079         (WTR::InjectedBundlePage::shouldBeginEditing):
2080         (WTR::InjectedBundlePage::shouldEndEditing):
2081         (WTR::InjectedBundlePage::shouldInsertNode):
2082         (WTR::InjectedBundlePage::shouldInsertText):
2083         (WTR::InjectedBundlePage::shouldDeleteRange):
2084         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
2085         (WTR::InjectedBundlePage::shouldApplyStyle):
2086         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2087
2088 2010-09-19  Kent Tamura  <tkent@chromium.org>
2089
2090         Unreviewed. Fix WebGL test regressions by r67809.
2091
2092         * DumpRenderTree/chromium/WebPreferences.cpp:
2093         (WebPreferences::applyTo): Call setExperimentalWebGLEnabled().
2094
2095 2010-09-19  Kent Tamura  <tkent@chromium.org>
2096
2097         Reviewed by Adam Barth.
2098
2099         [DRT/Chromium] Fix a WebSettings handling bug
2100         https://bugs.webkit.org/show_bug.cgi?id=45945
2101
2102         Before this change, Chromium DRT reset WebSettings for every new
2103         window. It was wrong.
2104         If new window is not the first one, we have to apply the same
2105         settings as the first window.  So, we introduce WebPreference to
2106         store the current settings, and apply it to new windows. It's same
2107         as test_shell's behavior.
2108
2109         * DumpRenderTree/DumpRenderTree.gypi:
2110         * DumpRenderTree/chromium/LayoutTestController.cpp:
2111           Use WebPreferences instead of WebSettings.
2112         (LayoutTestController::setUserStyleSheetEnabled):
2113         (LayoutTestController::setUserStyleSheetLocation):
2114         (LayoutTestController::setAuthorAndUserStylesEnabled):
2115         (LayoutTestController::setPopupBlockingEnabled):
2116         (LayoutTestController::disableImageLoading):
2117         (LayoutTestController::setJavaScriptCanAccessClipboard):
2118         (LayoutTestController::setXSSAuditorEnabled):
2119         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
2120         (LayoutTestController::setAllowFileAccessFromFileURLs):
2121         (LayoutTestController::overridePreference):
2122         (LayoutTestController::setEditingBehavior):
2123         * DumpRenderTree/chromium/TestShell.cpp:
2124         (TestShell::resetWebSettings): Use WebPreferences.
2125         (TestShell::runFileTest): ditto.
2126         (TestShell::createNewWindow): Apply existing WebPreferences to a new WebView.
2127         * DumpRenderTree/chromium/TestShell.h:
2128         (TestShell::preferences):
2129         (TestShell::applyPreferences):
2130         * DumpRenderTree/chromium/WebPreferences.cpp: Added.
2131         * DumpRenderTree/chromium/WebPreferences.h: Added.
2132
2133 2010-09-18  Prasad Tammana  <prasadt@chromium.org>
2134
2135         Reviewed by David Levin.
2136
2137         update-webkit --chromium spitting out a spurious error
2138         https://bugs.webkit.org/show_bug.cgi?id=45868
2139
2140         * Scripts/update-webkit-chromium: Use commandExists() function to check for existence of gclient.
2141
2142 2010-09-18  Sam Weinig  <sam@webkit.org>
2143
2144         Reviewed by Dan Bernstein.
2145
2146         Improve/unify the PageLoadClient interfaces
2147         https://bugs.webkit.org/show_bug.cgi?id=46043
2148
2149         * MiniBrowser/mac/BrowserWindowController.m:
2150         (didStartProvisionalLoadForFrame):
2151         (didReceiveServerRedirectForProvisionalLoadForFrame):
2152         (didFailProvisionalLoadWithErrorForFrame):
2153         (didCommitLoadForFrame):
2154         (didFinishDocumentLoadForFrame):
2155         (didFinishLoadForFrame):
2156         (didFailLoadWithErrorForFrame):
2157         (didReceiveTitleForFrame):
2158         (didFirstLayoutForFrame):
2159         (didFirstVisuallyNonEmptyLayoutForFrame):
2160         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2161         (WTR::InjectedBundlePage::InjectedBundlePage):
2162         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
2163         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
2164         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
2165         (WTR::InjectedBundlePage::didCommitLoadForFrame):
2166         (WTR::InjectedBundlePage::didFinishLoadForFrame):
2167         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
2168         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
2169         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
2170         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2171         * WebKitTestRunner/TestController.cpp:
2172         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2173         (WTR::TestController::didFinishLoadForFrame):
2174         * WebKitTestRunner/TestController.h:
2175
2176 2010-09-17  Eric Seidel  <eric@webkit.org>
2177
2178         Unreviewed.  Adding a shell script I use to run the
2179         commit-queue. Now that multiple machines run the cq,
2180         it makes sense to share the script between them.
2181
2182         * EWSTools/start-commit-queue.sh: Added.
2183
2184 2010-09-17  Brian Weinstein  <bweinstein@apple.com>
2185
2186         Reviewed by Jon Honeycutt.
2187
2188         The colors on the new build.webkit.org (after upgrading the master to 0.8.1) are
2189         slightly harder to read, so this reverts the previous background colors for various
2190         states, making it easier to read.
2191
2192         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
2193         (.success):
2194         (.failure):
2195         (.warnings):
2196         (.exception):
2197         (.start,.running,td.building):
2198         (.offline,td.offline):
2199
2200 2010-09-17  Sheriff Bot  <webkit.review.bot@gmail.com>
2201
2202         Unreviewed, rolling out r67692.
2203         http://trac.webkit.org/changeset/67692
2204         https://bugs.webkit.org/show_bug.cgi?id=46011
2205
2206         broke layout test dashboard (Requested by johnny_g on
2207         #webkit).
2208
2209         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2210         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2211         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2212
2213 2010-09-17  Martin Robinson  <mrobinson@igalia.com>
2214
2215         Reviewed by Oliver Hunt.
2216
2217         Style bot complains about cairo forward declaration naming
2218         https://bugs.webkit.org/show_bug.cgi?id=45867
2219
2220         Exclude Cairo forward declarations from indentifiers with underscores checks.
2221
2222         * Scripts/webkitpy/style/checkers/cpp.py: Add exclusion for Cairo forward-declarations.
2223         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
2224
2225 2010-09-16  Kinuko Yasuda  <kinuko@chromium.org>
2226
2227         Reviewed by Ojan Vafai.
2228
2229         Include detailed test modifiers (e.g. FLAKY) in results.json for failing non-layout tests
2230         https://bugs.webkit.org/show_bug.cgi?id=45408
2231
2232         This change also tries to remove duplicated upload_results_json methods
2233         in run_webkit_tests.py and json_results_generator.py.
2234
2235         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2236         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2237         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2238
2239 2010-09-16  Antonio Gomes  <tonikitoo@webkit.org>
2240
2241         Reviewed by Andreas Kling.
2242
2243         [Qt] When switching views (WebViewGraphicsBased <--> WebViewTraditional), QWebPage signals and QActions have to be re-set.
2244
2245         Recently r67554 changed the way different views use the WebPage class: it was previously being shared between
2246         different views, but now for each view switch, a new WebPage class is constructed and set. Signals and QAction's
2247         were not being set to the new WebPage though. Patch fix that, by re constructing the toolbar, and then re-hooking
2248         all page specific stuff to the UI.
2249
2250         * QtTestBrowser/launcherwindow.cpp:
2251         (LauncherWindow::initializeView):
2252         * QtTestBrowser/mainwindow.cpp:
2253         (MainWindow::MainWindow):
2254         (MainWindow::buildUI):
2255         (MainWindow::setPage):
2256         * QtTestBrowser/mainwindow.h:
2257
2258 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
2259
2260         Reviewed by Andreas Kling.
2261
2262         Make all accesses to m_item (GraphicsWebView) done by WebViewGraphicsBased class happen though graphicsWebView getter method.
2263
2264         This patch is mostly a preparation for another commit, where the ownership of the m_item/GraphicsWebView
2265         object will move to the qgraphicsscene instead of the qgraphicsview.
2266
2267         * QtTestBrowser/webview.cpp:
2268         (WebViewGraphicsBased::setPage):
2269         (WebViewGraphicsBased::setResizesToContents):
2270         (WebViewGraphicsBased::resizeEvent):
2271         (WebViewGraphicsBased::animatedFlip):
2272         * QtTestBrowser/webview.h:
2273         (WebViewGraphicsBased::setItemCacheMode):
2274         (WebViewGraphicsBased::itemCacheMode):
2275
2276 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
2277
2278         Reviewed by Andreas Kling.
2279
2280         Moved setYRotation method body out of the class (WebViewGraphicsBased) definition.
2281
2282         We usually separate methods whose body are larger than a few lines from the class definition.
2283
2284         * QtTestBrowser/webview.h:
2285         (WebViewGraphicsBased::yRotation):
2286         (WebViewGraphicsBased::setYRotation):
2287
2288 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
2289
2290         Reviewed by Andreas Kling.
2291
2292         Make initializeView method of LauncherWindow private.
2293
2294         No one else needs to be able to call it but LauncherWindow.
2295         Also moving the declation of isGraphicsBased method down in the same file, in order
2296         to better group related methods.
2297
2298         * QtTestBrowser/launcherwindow.h:
2299
2300 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
2301
2302         Reviewed by Andreas Kling.
2303
2304         Make the getter 'page' method of MainWindow const.
2305
2306         * QtTestBrowser/mainwindow.cpp:
2307         (MainWindow::page):
2308         * QtTestBrowser/mainwindow.h:
2309
2310 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
2311
2312         Reviewed by Andreas Kling.
2313
2314         Remove useless parameter from MainWindow class' constructor.
2315
2316         The parameter defaults to an empty URL and is not being used by any caller. Apart from that it is also
2317         not referred in the constructor body and does not make much sense.
2318
2319         * QtTestBrowser/mainwindow.cpp:
2320         (MainWindow::MainWindow):
2321         * QtTestBrowser/mainwindow.h:
2322
2323 2010-09-15  Tony Chang  <tony@chromium.org>
2324
2325         Reviewed by Kent Tamura.
2326
2327         [Chromium] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
2328         https://bugs.webkit.org/show_bug.cgi?id=42151
2329
2330         * DumpRenderTree/chromium/LayoutTestController.cpp:
2331         (LayoutTestController::LayoutTestController):
2332         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
2333         (WorkItemLoadHTMLString::run):
2334         (LayoutTestController::queueLoadHTMLString):
2335         (LayoutTestController::reset):
2336         (LayoutTestController::setDeferMainResourceDataLoad):
2337         * DumpRenderTree/chromium/LayoutTestController.h:
2338         (LayoutTestController::deferMainResourceDataLoad):
2339         * DumpRenderTree/chromium/WebViewHost.cpp:
2340         (WebViewHost::didCreateDataSource):
2341
2342 2010-09-16  Adrienne Walker  <enne@google.com>
2343
2344         Reviewed by Kenneth Russell.
2345
2346         Add script to synchronize WebKit and Khronos WebGL tests
2347         https://bugs.webkit.org/show_bug.cgi?id=42336
2348
2349         * Scripts/update-webgl-conformance-tests: Added.
2350         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py: Added.
2351         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py: Added.
2352
2353 2010-09-16  Sam Weinig  <sam@webkit.org>
2354
2355         Reviewed by Anders Carlsson.
2356
2357         Add support for sending synchronous messages from the InjectedBundle to the WKContext
2358         <rdar://problem/8365320>
2359         https://bugs.webkit.org/show_bug.cgi?id=44785
2360
2361         * MiniBrowser/mac/AppDelegate.m:
2362         (didReceiveSynchronousMessageFromInjectedBundle):
2363         (-[BrowserAppDelegate init]):
2364         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2365         (didCreatePage):
2366         * WebKitTestRunner/TestController.cpp:
2367         (WTR::TestController::initialize):
2368
2369 2010-09-16  Leonid Ebril  <leonid.ebril@nokia.com>
2370
2371         Reviewed by Andreas Kling.
2372
2373         [Qt] QtTestBrowser: Disable creation of a new window for screenshot on Symbian platform.
2374         https://bugs.webkit.org/show_bug.cgi?id=45885
2375
2376         Avoid creation of an additional window for screenshot to prevent overlapping with original window.
2377
2378         * QtTestBrowser/launcherwindow.cpp:
2379         (LauncherWindow::screenshot):
2380
2381 2010-09-16  Anders Carlsson  <andersca@apple.com>
2382
2383         Fix clang++ build.
2384
2385         * MiniBrowser/mac/BrowserWindowController.m:
2386         (-[BrowserWindowController zoomIn:]):
2387         (-[BrowserWindowController zoomOut:]):
2388         (-[BrowserWindowController resetZoom:]):
2389         Remove trailing semicolons.
2390
2391 2010-09-16  Sheriff Bot  <webkit.review.bot@gmail.com>
2392
2393         Unreviewed, rolling out r67628.
2394         http://trac.webkit.org/changeset/67628
2395         https://bugs.webkit.org/show_bug.cgi?id=45904
2396
2397         broke the build (Requested by eric_carlson on #webkit).
2398
2399         * DumpRenderTree/gtk/EventSender.cpp:
2400         (contextClickCallback):
2401
2402 2010-09-16  Balazs Kelemen  <kbalazs@webkit.org>
2403
2404         Unreviewed.
2405
2406         Adding myself as a comitter.
2407
2408         * Scripts/webkitpy/common/config/committers.py:
2409
2410 2010-09-15  Philippe Normand  <pnormand@igalia.com>
2411
2412         Reviewed by Eric Carlson.
2413
2414         [GTK] enhanced context menu for media elements
2415         https://bugs.webkit.org/show_bug.cgi?id=45021
2416
2417         EventSender::contextClick() now returns an array of js
2418         objects. Each object has a title property and a click() method.
2419
2420         * DumpRenderTree/gtk/EventSender.cpp:
2421         (getMenuItemTitleCallback):
2422         (setMenuItemTitleCallback):
2423         (menuItemClickCallback):
2424         (getMenuItemClass):
2425         (contextClickCallback):
2426
2427 2010-09-14  Philippe Normand  <pnormand@igalia.com>
2428
2429         Reviewed by Eric Carlson and Martin Robinson.
2430
2431         [GTK] eventSender.contextClick() should return the contents of the context menu
2432         https://bugs.webkit.org/show_bug.cgi?id=39102
2433
2434         Make the eventSender use the new private WebKitGtk+ API to
2435         retrieve the context-menu item titles and store them in an array.
2436
2437         * DumpRenderTree/gtk/EventSender.cpp:
2438         (contextClickCallback):
2439
2440 2010-09-16  Eric Uhrhane  <ericu@chromium.org>
2441
2442         Reviewed by Jian Li.
2443
2444         Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
2445         https://bugs.webkit.org/show_bug.cgi?id=45798
2446
2447         * Scripts/build-webkit:
2448
2449 2010-09-16  Robert Hogan  <robert@webkit.org>
2450
2451         Reviewed by Antonio Gomes.
2452
2453         [Qt] Support globalhistory tests
2454         https://bugs.webkit.org/show_bug.cgi?id=45774
2455
2456         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2457         (WebCore::isGlobalHistoryTest):
2458         (WebCore::DumpRenderTree::open):
2459         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2460         (LayoutTestController::reset):
2461         (LayoutTestController::dumpHistoryCallbacks):
2462         (LayoutTestController::removeAllVisitedLinks):
2463         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2464
2465 2010-09-10  Tony Chang  <tony@chromium.org>
2466
2467         Reviewed by Eric Seidel.
2468
2469         deduplicate-tests should be runnable from any WebKit directory
2470         https://bugs.webkit.org/show_bug.cgi?id=44709
2471
2472         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
2473         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2474
2475 2010-09-15  Tony Chang  <tony@chromium.org>
2476
2477         Reviewed by Kent Tamura.
2478
2479         [chromium] sort testing methods in DRT
2480         https://bugs.webkit.org/show_bug.cgi?id=45850
2481
2482         * DumpRenderTree/chromium/EventSender.cpp:
2483         (EventSender::EventSender):
2484         * DumpRenderTree/chromium/LayoutTestController.cpp:
2485         (LayoutTestController::LayoutTestController):
2486         * DumpRenderTree/chromium/TextInputController.cpp:
2487         (TextInputController::TextInputController):
2488
2489 2010-09-15  Mihai Parparita  <mihaip@chromium.org>
2490
2491         Reviewed by Adam Barth.
2492
2493         CQ status shows items out of order
2494         https://bugs.webkit.org/show_bug.cgi?id=45846
2495         
2496         Only group consecutive status items with the same patch ID into the same
2497         group, so that overall item ordering is preserved.
2498         
2499         Also don't indent status items that only have a single item in their
2500         group.
2501
2502         * QueueStatusServer/handlers/queuestatus.py:
2503         * QueueStatusServer/templates/includes/singlequeuestatus.html: Added.
2504         * QueueStatusServer/templates/queuestatus.html:
2505
2506 2010-09-15  Eric Seidel  <eric@webkit.org>
2507
2508         Reviewed by Adam Barth.
2509
2510         Add queue start/stop messages
2511         https://bugs.webkit.org/show_bug.cgi?id=45853
2512
2513         I ended up needing to clean up a bunch of our unit testing
2514         in order to test this new code path nicely.
2515
2516         There are also a few PEP8 changes needed to pass check-webkit-style.
2517
2518         * Scripts/webkitpy/tool/bot/queueengine.py:
2519         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2520         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2521         * Scripts/webkitpy/tool/commands/queues.py:
2522         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2523         * Scripts/webkitpy/tool/commands/queuestest.py:
2524         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2525
2526 2010-09-15  Simon Fraser  <simon.fraser@apple.com>
2527
2528         https://bugs.webkit.org/show_bug.cgi?id=45849
2529         WKURLCreateWithCFURL crashes with null url
2530         
2531         Fix MiniBrowser crash when the url is not parseable.
2532
2533         * MiniBrowser/mac/BrowserWindowController.m:
2534         (-[BrowserWindowController fetch:]):
2535
2536 2010-09-15  Patrick Gansterer  <paroga@paroga.com>
2537
2538         Unreviewed.
2539
2540         Adding myself to the committers list.
2541
2542         * Scripts/webkitpy/common/config/committers.py:
2543
2544 2010-09-14  Eric Seidel  <eric@webkit.org>
2545
2546         Reviewed by Adam Barth.
2547
2548         Make it possible to run more than one commit-queue instance
2549         https://bugs.webkit.org/show_bug.cgi?id=45786
2550
2551         Mostly we need to make sure the two (or more) instances get
2552         different patches to work on.  To do this, I re-worked
2553         the code responsible for getting the next work item to
2554         round trip through the status server.  The status server only
2555         vends patches from the work items list, only if those patches
2556         have not had status reported for them in the last hour.
2557
2558         This is another step towards making all queues go through the
2559         status server, thus making it possible to run more than one
2560         instance of various EWS bots (as requested in bug 44292).
2561
2562         The webkitpy changes are already covered by existing unit tests.
2563         The QueueStatusSever sadly has no testing infrastructure yet. :(
2564
2565         * QueueStatusServer/handlers/nextpatch.py: Added.
2566         * QueueStatusServer/index.yaml:
2567         * QueueStatusServer/main.py:
2568         * Scripts/webkitpy/tool/commands/queues.py:
2569
2570 2010-09-15  Mihai Parparita  <mihaip@chromium.org>
2571
2572         Reviewed by Tony Chang.
2573
2574         NRWT fails with UnicodeDecodeError on editing/selection/mixed-editability-10.html
2575         https://bugs.webkit.org/show_bug.cgi?id=45791
2576
2577         Force filenames to be raw bytes before running difflib.unified_diff.
2578
2579         * Scripts/webkitpy/layout_tests/port/base.py:
2580         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2581
2582 2010-09-15  Simon Hausmann  <simon.hausmann@nokia.com>
2583
2584         Reviewed by Tor Arne Vestbø.
2585
2586         [Qt] QtTestBrowser crashes when enabling QGraphicsView mode after first loading page without it enabled
2587         https://bugs.webkit.org/show_bug.cgi?id=35247
2588
2589         The main issue when changing the views is that the plugins and any other components that
2590         depend on view specific attributes such as the native window id are not teared down.
2591         Even if we had a tear-down procedure, we'd have to re-initialize the plugin after
2592         switching to the new view (QGraphicsWebView). This is a rather uncommon situation, so
2593         we decided to work around this in QtTestBrowser by making toggling between QWebView
2594         and QGraphicsWebView also re-create the page.
2595
2596         * QtTestBrowser/launcherwindow.cpp:
2597         (LauncherWindow::initializeView):
2598         * QtTestBrowser/mainwindow.h:
2599
2600 2010-09-14  Mihai Parparita  <mihaip@chromium.org>
2601
2602         Reviewed by Adam Barth.
2603
2604         Send webkit accessibility notifications to Chromium
2605         https://bugs.webkit.org/show_bug.cgi?id=45156
2606
2607         Move printf inside shouldDumpAccessibilityNotifications check.
2608
2609         * DumpRenderTree/chromium/WebViewHost.cpp:
2610         (WebViewHost::postAccessibilityNotification):
2611
2612 2010-09-14  Tony Chang  <tony@chromium.org>
2613
2614         Reviewed by Kent Tamura.
2615
2616         [chromium] fix http/tests/security/local-user-CSS-from-remote.html
2617         https://bugs.webkit.org/show_bug.cgi?id=45788
2618
2619         * DumpRenderTree/chromium/LayoutTestController.cpp:
2620         (LayoutTestController::setUserStyleSheetLocation): use a base64 url like in Chrome
2621
2622 2010-09-14  Tony Chang  <tony@chromium.org>
2623
2624         Reviewed by Ojan Vafai.
2625
2626         [chromium] Remove WebKit::areLayoutTestImagesOpaque since it's no longer needed
2627         https://bugs.webkit.org/show_bug.cgi?id=45768
2628
2629         * DumpRenderTree/chromium/TestShell.cpp:
2630         (TestShell::dumpImage): new baselines are checked in and Linux will match Windows going forward.
2631
2632 2010-09-14  Kevin Ollivier  <kevino@theolliviers.com>
2633
2634         [wx] Build fix, add newly added directories to the directory list.
2635
2636         * wx/build/settings.py:
2637
2638 2010-09-14  Sam Weinig  <sam@webkit.org>
2639
2640         Reviewed by Anders Carlsson.
2641
2642         Remove WKBundleNodeRef, replacing uses with WKBundleNodeHandleRef.
2643         https://bugs.webkit.org/show_bug.cgi?id=45785
2644
2645         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2646         (WTR::propertyValue):
2647         (WTR::numericWindowPropertyValue):
2648         (WTR::dumpPath):
2649         (WTR::toStr):
2650         (WTR::operator<<):
2651         (WTR::InjectedBundlePage::InjectedBundlePage):
2652         (WTR::InjectedBundlePage::shouldInsertNode):
2653         (WTR::InjectedBundlePage::shouldBeginEditing):
2654         (WTR::InjectedBundlePage::shouldEndEditing):
2655         (WTR::InjectedBundlePage::shouldInsertText):
2656         (WTR::InjectedBundlePage::shouldDeleteRange):
2657         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
2658         (WTR::InjectedBundlePage::shouldApplyStyle):
2659         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2660
2661 2010-09-14  Adam Barth  <abarth@webkit.org>
2662
2663         Fix two typos in commit-queue.  The first is harmless.  The second
2664         causes the queue to reject patches when the build is broken.  :(
2665
2666         * Scripts/webkitpy/tool/commands/queues.py:
2667         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2668
2669 2010-09-14  Chris Guillory   <chris.guillory@google.com>
2670
2671         Reviewed by Chris Fleizach.
2672
2673         Send all accessibility notifications to Chromium.
2674         https://bugs.webkit.org/show_bug.cgi?id=45156
2675
2676         * DumpRenderTree/chromium/WebViewHost.cpp:
2677         (WebViewHost::postAccessibilityNotification):
2678         * DumpRenderTree/chromium/WebViewHost.h:
2679
2680 2010-09-14  Adam Barth  <abarth@webkit.org>
2681
2682         Reviewed by Eric Seidel.
2683
2684         commit-queue is slow during the day
2685         https://bugs.webkit.org/show_bug.cgi?id=45780
2686
2687         Thanks to the new logging, we've noticed that checkout-is-out-of-date
2688         errors in the first pass of landing don't retry the land.  Instead,
2689         they're treated as failures and cause the commit-queue to do two more
2690         builds before really trying to land the patch.  Worse, in the second
2691         build, we can get bitten by a flaky test.
2692
2693         This patch takes a slightly different approach to the commit-queue's
2694         main control logic.  We now use a separate subprocess for building and
2695         testing and for landing.  This means we should very rarely see the
2696         checkout-is-out-of-date error, and when we do see it, we should retry
2697         more quickly.  If my understanding is correct, this should be a big
2698         speed win for the commit-queue.
2699
2700         * Scripts/webkitpy/tool/commands/download.py:
2701         * Scripts/webkitpy/tool/commands/queues.py:
2702         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2703
2704 2010-09-14  Tony Chang  <tony@chromium.org>
2705
2706         Reviewed by Dimitri Glazkov.
2707
2708         [chromium] implement layoutTestController.setDomainRelaxationForbiddenForURLScheme
2709         https://bugs.webkit.org/show_bug.cgi?id=45762
2710
2711         * DumpRenderTree/chromium/LayoutTestController.cpp:
2712         (LayoutTestController::LayoutTestController):
2713         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
2714         * DumpRenderTree/chromium/LayoutTestController.h:
2715
2716 2010-09-14  Csaba Osztrogonác  <ossy@webkit.org>
2717
2718         Adding myself as a reviewer.
2719
2720         * Scripts/webkitpy/common/config/committers.py:
2721
2722 2010-09-14  Zoltan Horvath  <zoltan@webkit.org>
2723
2724         Reviewed by Kenneth Rohde Christiansen.
2725
2726         [Qt] Build-webkit shows a warning when WebKitBuild directory is not exist
2727         https://bugs.webkit.org/show_bug.cgi?id=45736
2728
2729         Build-webkit has showed a warning when WebKitBuild didn't exist, add
2730         an additional condition to avoid it.
2731
2732         * Scripts/build-webkit:
2733
2734 2010-09-13  Eric Seidel  <eric@webkit.org>
2735
2736         Reviewed by Adam Barth.
2737
2738         commit-queue should log when it's retrying due to checkout out of date error
2739         https://bugs.webkit.org/show_bug.cgi?id=45725
2740
2741         This will allow us to better track how often we see these errors
2742         and how long it takes the queue to recover from them.
2743
2744         In order to pass the tests, I had to correct an error
2745         from a previous change.  The UnitTestPort should not have
2746         ever been using the base port method as that will read
2747         a file from disk.  If the unit tests haven't passed the contents
2748         it should raise an IOError as though the file doesn't exist.
2749
2750         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2751         * Scripts/webkitpy/tool/commands/queues.py:
2752         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2753
2754 2010-09-13  Mihai Parparita  <mihaip@chromium.org>
2755
2756         Reviewed by Adam Barth.
2757
2758         Upload results when cq patch landing fails
2759         https://bugs.webkit.org/show_bug.cgi?id=45683
2760         
2761         Include script errors when CommitQueue._land fails.
2762
2763         * Scripts/webkitpy/tool/commands/queues.py:
2764
2765 2010-09-13  Chris Fleizach  <cfleizach@apple.com>
2766
2767         Reviewed by David Kilzer.
2768
2769         AX: accessibilityIsIgnored is returning nil when return value expects a BOOL
2770         https://bugs.webkit.org/show_bug.cgi?id=45548
2771
2772         * DumpRenderTree/AccessibilityUIElement.cpp:
2773         (isIgnoredCallback):
2774         (AccessibilityUIElement::getJSClass):
2775         * DumpRenderTree/AccessibilityUIElement.h:
2776         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2777         (AccessibilityUIElement::isIgnored):
2778         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2779         (AccessibilityUIElement::isIgnored):
2780         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2781         (AccessibilityUIElement::isIgnored):
2782
2783 2010-09-13  Csaba Osztrogonác  <ossy@webkit.org>
2784
2785         Reviewed by Andreas Kling.
2786
2787         jscPath() is incorrect in Windows' cmd.exe shell
2788         https://bugs.webkit.org/show_bug.cgi?id=45651
2789
2790         * Scripts/webkitdirs.pm: Add ".exe" suffix to $jscName on Windows.
2791
2792 2010-09-13  Chris Fleizach  <cfleizach@apple.com>
2793
2794         Reviewed by Darin Adler.
2795
2796         REGRESSION (r64816-r64889): Crash in WebCore::AccessibilityRenderObject
2797         https://bugs.webkit.org/show_bug.cgi?id=43807
2798
2799         * DumpRenderTree/AccessibilityUIElement.cpp:
2800         (textMarkerForPointCallback):
2801         (AccessibilityUIElement::textMarkerForPoint):
2802         (AccessibilityUIElement::getJSClass):
2803         * DumpRenderTree/AccessibilityUIElement.h:
2804         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2805         (AccessibilityUIElement::textMarkerForPoint):
2806
2807 2010-09-13  Andreas Kling  <andreas.kling@nokia.com>
2808
2809         Reviewed by Kenneth Rohde Christiansen.
2810
2811         [Qt] build-webkit: Add --v8 option to build against V8
2812
2813         Note that V8 is picked up from QtScript, so this currently requires building
2814         against the experimental qt-script-v8 branch.
2815
2816         * Scripts/build-webkit:
2817
2818 2010-09-13  Hans Wennborg  <hans@chromium.org>
2819
2820         Reviewed by Jeremy Orlow.
2821
2822         Add WebDeviceOrientationClientMock::create() and use it from DRT.
2823         https://bugs.webkit.org/show_bug.cgi?id=45650
2824
2825         Do not use the WebDeviceOrientationClientMock constructor directly,
2826         but use the create() member function.
2827
2828         This should fix the linker errors for the multi-DLL Chromium DRT build.
2829
2830         * DumpRenderTree/chromium/LayoutTestController.cpp:
2831         (LayoutTestController::setMockDeviceOrientation):
2832         (LayoutTestController::deviceOrientationClient):
2833
2834 2010-08-27  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
2835
2836         Reviewed by Antti Koivisto.
2837
2838         Add support for testing the viewport meta tag algorithm,
2839         based on the following draft spec:
2840
2841         http://people.opera.com/rune/TR/ED-css-viewport-20100806/
2842
2843         Add common handling of viewport meta tag based on new Opera spec
2844         https://bugs.webkit.org/show_bug.cgi?id=44201
2845
2846         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2847         (LayoutTestController::dumpConfigurationForViewport):
2848         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2849
2850 2010-09-12  Kent Tamura  <tkent@chromium.org>
2851
2852         Reviewed by Tony Chang.
2853
2854         [DRT/Chromium] Remove dependency to base/string16.h and gfx/codec/png_codec.h
2855         https://bugs.webkit.org/show_bug.cgi?id=45517
2856
2857         Use webkit_support_gfx.h for PNG encoding/decoding instead of png_codec.h
2858
2859         * DumpRenderTree/chromium/ImageDiff.cpp:
2860         (Image::craeteFromStdin):
2861         (Image::createFromFilename):
2862         (diffImages):
2863         * DumpRenderTree/chromium/TestShell.cpp:
2864         (TestShell::dumpImage):
2865
2866 2010-09-10  MORITA Hajime  <morrita@google.com>
2867
2868         Reviewed by Tony Chang.
2869
2870         [Chromium] Implement textInputController.hasSpellingMarker() for Chromium
2871         https://bugs.webkit.org/show_bug.cgi?id=45441
2872
2873         Added TextInputController::hasSpellingMarker().
2874         
2875         * DumpRenderTree/chromium/TextInputController.cpp:
2876         (TextInputController::TextInputController):
2877         (TextInputController::hasSpellingMarker):
2878         * DumpRenderTree/chromium/TextInputController.h:
2879
2880 2010-09-12  Dirk Pranke  <dpranke@chromium.org>
2881
2882         Unreviewed, build fix.
2883
2884         My last change accidentally contained a local change to the
2885         rebaselinig script; webkit-patch land picked it up without telling
2886         me and committed it :(
2887
2888         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2889
2890 2010-09-11  Maciej Stachowiak  <mjs@apple.com>
2891
2892         Reviewed by Anders Carlsson.
2893
2894         Attempt to fix Windows MiniBrowser build (untested)
2895         https://bugs.webkit.org/show_bug.cgi?id=45609
2896
2897         * MiniBrowser/win/BrowserView.cpp:
2898         (runJavaScriptConfirm):
2899         (runJavaScriptPrompt):
2900
2901 2010-09-11  Sam Weinig  <sam@webkit.org>
2902
2903         Reviewed by Maciej Stachowiak.
2904
2905         Fix zoom related tests when testing WebKit2.
2906
2907         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2908         (WTR::EventSendingController::zoomPageIn): Zoom in and zoom out are not the same.
2909
2910 2010-09-11  Sam Weinig  <sam@webkit.org>
2911
2912         Reviewed by Dan Bernstein.
2913
2914         Implement WebKit2 callback equivalent to - [WebUIDelegate webView:setStatusText:]
2915         <rdar://problem/8359252>
2916         https://bugs.webkit.org/show_bug.cgi?id=45605
2917
2918         * MiniBrowser/mac/BrowserWindowController.m:
2919         (setStatusText):
2920         (contentsSizeChanged):
2921         (-[BrowserWindowController awakeFromNib]):
2922         * MiniBrowser/win/BrowserView.cpp:
2923         (runJavaScriptConfirm):
2924         (runJavaScriptPrompt):
2925         (setStatusText):
2926         (contentsSizeChanged):
2927         (BrowserView::create):
2928         * WebKitTestRunner/TestController.cpp:
2929         (WTR::createOtherPage):
2930         (WTR::TestController::initialize):
2931
2932 2010-09-11  Sam Weinig  <sam@webkit.org>
2933
2934         Reviewed by Dan Bernstein.
2935
2936         Add callback mechanism for the getting the source of a frame
2937         <rdar://problem/8364681>
2938         https://bugs.webkit.org/show_bug.cgi?id=45604
2939
2940         Add ability to dump the main frame's source to the console.
2941
2942         * MiniBrowser/mac/BrowserWindowController.h:
2943         * MiniBrowser/mac/BrowserWindowController.m:
2944         (-[BrowserWindowController dumpSourceToConsole:]):
2945         * MiniBrowser/mac/MainMenu.xib:
2946
2947 2010-09-11  Eric Seidel  <eric@webkit.org>
2948
2949         Reviewed by Adam Barth.
2950
2951         Remove unneeded Empty Queue messages
2952         https://bugs.webkit.org/show_bug.cgi?id=45602
2953
2954         We already have a /gc job to delete these.
2955         recentstatus.py is already smart enough to use the
2956         most recent of the workitems last update or the most recent status,
2957         so removing these should not change the _last_status_date() return
2958         value more than a few milliseconds.
2959
2960         These messages just spam the recent status log.
2961
2962         * Scripts/webkitpy/tool/commands/queues.py:
2963
2964 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
2965
2966         Reviewed by Adam Barth.
2967
2968         Fix Python exception when generating synthetic patch IDs
2969         https://bugs.webkit.org/show_bug.cgi?id=45592
2970
2971         Can't concatenate strings and numbers directly.
2972
2973         * QueueStatusServer/handlers/queuestatus.py:
2974
2975 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
2976
2977         Reviewed by Adam Barth.
2978
2979         Group statuses in queue status by patch ID
2980         https://bugs.webkit.org/show_bug.cgi?id=45588
2981
2982         Group statuses by patch ID so that the status page is easier
2983         to scan.
2984
2985         * QueueStatusServer/handlers/queuestatus.py:
2986         * QueueStatusServer/stylesheets/dashboard.css:
2987         (.status-group):
2988         (.status-bug):
2989         (.status-group ul):
2990         (.status-group ul li):
2991         (.status-group ul li:hover):
2992         (.status-cell):
2993         (.status-cell:hover):
2994         (.status-cell.pass):
2995         (.status-cell.fail):
2996         (.status-cell.pending):
2997         (.status-cell.error):
2998         * QueueStatusServer/templates/dashboard.html:
2999         * QueueStatusServer/templates/queuestatus.html:
3000
3001 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
3002
3003         Reviewed by Tony Chang.
3004
3005         Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
3006         https://bugs.webkit.org/show_bug.cgi?id=45479
3007
3008         Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after
3009         implementation in ResourceLoadDelegate in the Mac port).
3010
3011         * DumpRenderTree/chromium/LayoutTestController.cpp:
3012         (LayoutTestController::LayoutTestController):
3013         (LayoutTestController::dumpResourceResponseMIMETypes):
3014         (LayoutTestController::reset):
3015         * DumpRenderTree/chromium/LayoutTestController.h:
3016         (LayoutTestController::setShouldDumpResourceResponseMIMETypes):
3017         (LayoutTestController::shouldDumpResourceResponseMIMETypes):
3018         * DumpRenderTree/chromium/TestShell.h:
3019         (TestShell::shouldDumpResourceResponseMIMETypes):
3020         * DumpRenderTree/chromium/WebViewHost.cpp:
3021         (WebViewHost::didReceiveResponse):
3022
3023 2010-09-11  Eric Seidel  <eric@webkit.org>
3024
3025         Reviewed by Adam Barth.
3026
3027         queues.webkit.org should expose /remote_api for data upload/download
3028         https://bugs.webkit.org/show_bug.cgi?id=45559
3029
3030         * QueueStatusServer/app.yaml:
3031          - /remote_api is a standard app-engine service which allows use of
3032            the bulk uploader for data upload/download.  Exposing this
3033            (for admin access only) allows us to use 
3034
3035 2010-09-10  Sam Weinig  <sam@webkit.org>
3036
3037         Reviewed by Dan Bernstein.
3038
3039         Add zoom support to WebKit2 API
3040         <rdar://problem/7660657>
3041         https://bugs.webkit.org/show_bug.cgi?id=45585
3042
3043         - Add zoom options to MiniBrowser that mimic Safari's options using
3044           the new WebKit2 zoom APIs.
3045         - Switch uses of float for the zoom APIs to use double.
3046
3047         * MiniBrowser/mac/BrowserWindowController.h:
3048         * MiniBrowser/mac/BrowserWindowController.m:
3049         (-[BrowserWindowController initWithPageNamespace:]):
3050         (-[BrowserWindowController validateMenuItem:]):
3051         (-[BrowserWindowController validateUserInterfaceItem:]):
3052         (-[BrowserWindowController currentZoomFactor]):
3053         (-[BrowserWindowController setCurrentZoomFactor:]):
3054         (-[BrowserWindowController canZoomIn]):
3055         (-[BrowserWindowController zoomIn:]):
3056         (-[BrowserWindowController canZoomOut]):
3057         (-[BrowserWindowController zoomOut:]):
3058         (-[BrowserWindowController canResetZoom]):
3059         (-[BrowserWindowController resetZoom:]):
3060         (-[BrowserWindowController toggleZoomMode:]):
3061         * MiniBrowser/mac/MainMenu.xib:
3062         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3063         (WTR::EventSendingController::textZoomIn):
3064         (WTR::EventSendingController::textZoomOut):
3065         (WTR::EventSendingController::zoomPageIn):
3066         (WTR::EventSendingController::zoomPageOut):
3067
3068 2010-09-10  Robert Hogan  <robert@webkit.org>
3069
3070         Reviewed by Andreas Kling.
3071
3072         [Qt] Fix crash in DRT in standalone mode
3073
3074         https://bugs.webkit.org/show_bug.cgi?id=45454
3075
3076         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3077         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
3078
3079 2010-09-10  Sam Weinig  <sam@webkit.org>
3080
3081         Reviewed by Darin Adler.
3082
3083         Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom.
3084         Precursor to <rdar://problem/7660657>
3085         https://bugs.webkit.org/show_bug.cgi?id=45522
3086
3087         Update for changes to the Bundle API to allow separate control of page and text zoom
3088         levels.
3089
3090         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3091         (WTR::EventSendingController::textZoomIn):
3092         (WTR::EventSendingController::textZoomOut):
3093         (WTR::EventSendingController::zoomPageIn):
3094         (WTR::EventSendingController::zoomPageOut):
3095         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3096         (WTR::InjectedBundlePage::reset):
3097
3098 2010-09-10  Yael Aharon  <yael.aharon@nokia.com>
3099
3100         Reviewed by Andreas Kling.
3101
3102         [Qt] Support click event for notifications
3103         https://bugs.webkit.org/show_bug.cgi?id=44836
3104
3105         Add support for simulateDesktopNotificationClick by calling
3106         back to DumpRenderTreeSupportQt.cpp.
3107
3108         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3109         (LayoutTestController::simulateDesktopNotificationClick):
3110         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3111
3112 2010-09-10  Mihai Parparita  <mihaip@chromium.org>
3113
3114         Reviewed by Eric Seidel.
3115
3116         Update queue status when patches fail their first land attempt
3117         https://bugs.webkit.org/show_bug.cgi?id=45583
3118
3119         Add a few more _update_status calls to make it more obvious if a patch is 
3120         being retried because tests failed.
3121
3122         * Scripts/webkitpy/tool/commands/queues.py:
3123
3124 2010-09-10  Balazs Kelemen  <kb@inf.u-szeged.hu>
3125
3126         Reviewed by Andreas Kling.
3127
3128         [Qt] MiniBrowser crashes with multiply windows when closing one of them
3129         https://bugs.webkit.org/show_bug.cgi?id=45536
3130
3131         * MiniBrowser/qt/BrowserView.cpp:
3132         (BrowserView::BrowserView): Reference the context instead of adopting it
3133         because it can be shared across different views.
3134
3135 2010-09-10  Tony Chang  <tony@chromium.org>
3136
3137         Unreviewed, rolling out r67241.
3138         http://trac.webkit.org/changeset/67241
3139         https://bugs.webkit.org/show_bug.cgi?id=44709
3140
3141         Accidentally committed.
3142
3143         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
3144         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3145
3146 2010-09-10  Tony Chang  <tony@chromium.org>
3147
3148         Reviewed by Ojan Vafai.
3149
3150         deduplicate-tests should be runnable from any WebKit directory
3151         https://bugs.webkit.org/show_bug.cgi?id=44709
3152
3153         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
3154         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3155
3156 2010-09-10  Tony Chang  <tony@chromium.org>
3157
3158         Unreviewed, rolling out r67216.
3159         http://trac.webkit.org/changeset/67216
3160         https://bugs.webkit.org/show_bug.cgi?id=44709
3161
3162         Broke
3163
3164         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
3165         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3166
3167 2010-09-10  Tony Chang  <tony@chromium.org>
3168
3169         Reviewed by Ojan Vafai.
3170
3171         deduplicate-tests should be runnable from any WebKit directory
3172         https://bugs.webkit.org/show_bug.cgi?id=44709
3173
3174         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
3175         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3176
3177 2010-09-09  Hans Wennborg  <hans@chromium.org>
3178
3179         Reviewed by Jeremy Orlow.
3180
3181         Hook up LayoutTestController.setMockDeviceOrientation() in Chromium DumpRenderTree.
3182         https://bugs.webkit.org/show_bug.cgi?id=45460
3183
3184         This enables DumpRenderTree to run layout tests for DeviceOrientation.
3185
3186         Also declare the LayoutTestController destructor out-of-line.
3187         Otherwise the implicit destructor would cause compiler errors because
3188         of the OwnPtr<WebKit::WebDeviceOrientationClientMock> member.
3189
3190         * DumpRenderTree/chromium/LayoutTestController.cpp:
3191         (LayoutTestController::~LayoutTestController):
3192         (LayoutTestController::setMockDeviceOrientation):
3193         (LayoutTestController::deviceOrientationClient):
3194         * DumpRenderTree/chromium/LayoutTestController.h:
3195         * DumpRenderTree/chromium/WebViewHost.cpp:
3196         (WebViewHost::deviceOrientationClient):
3197         * DumpRenderTree/chromium/WebViewHost.h:
3198
3199 2010-09-09  Sheriff Bot  <webkit.review.bot@gmail.com>
3200
3201         Unreviewed, rolling out r67119.
3202         http://trac.webkit.org/changeset/67119
3203         https://bugs.webkit.org/show_bug.cgi?id=45505
3204
3205         Extra newlines in results (Requested by tony^work on #webkit).
3206
3207         * DumpRenderTree/chromium/LayoutTestController.cpp:
3208         (LayoutTestController::LayoutTestController):
3209         (LayoutTestController::reset):
3210         * DumpRenderTree/chromium/LayoutTestController.h:
3211         * DumpRenderTree/chromium/TestShell.h:
3212         * DumpRenderTree/chromium/WebViewHost.cpp:
3213         (printResponseDescription):
3214         (printNodeDescription):
3215         (printRangeDescription):
3216         (WebViewHost::shouldBeginEditing):
3217         (WebViewHost::shouldEndEditing):
3218         (WebViewHost::shouldInsertNode):
3219         (WebViewHost::shouldChangeSelectedRange):
3220         (WebViewHost::shouldDeleteRange):
3221         (WebViewHost::shouldApplyStyle):
3222         (WebViewHost::didBeginEditing):
3223         (WebViewHost::didChangeSelection):
3224         (WebViewHost::didChangeContents):
3225         (WebViewHost::didEndEditing):
3226         (WebViewHost::decidePolicyForNavigation):
3227         (WebViewHost::didCancelClientRedirect):
3228         (WebViewHost::didStartProvisionalLoad):
3229         (WebViewHost::didReceiveServerRedirectForProvisionalLoad):
3230         (WebViewHost::didFailProvisionalLoad):
3231         (WebViewHost::didCommitProvisionalLoad):
3232         (WebViewHost::didFinishDocumentLoad):
3233         (WebViewHost::didHandleOnloadEvents):
3234         (WebViewHost::didFailLoad):
3235         (WebViewHost::didFinishLoad):
3236         (WebViewHost::didChangeLocationWithinPage):
3237         (WebViewHost::willSendRequest):
3238         (WebViewHost::didReceiveResponse):
3239         (WebViewHost::didFinishResourceLoad):
3240         (WebViewHost::didFailResourceLoad):
3241         (WebViewHost::didDisplayInsecureContent):
3242         (WebViewHost::didRunInsecureContent):
3243         (WebViewHost::printFrameDescription):
3244
3245 2010-09-09  Michael Saboff  <msaboff@apple.com>
3246
3247         Unreviewed, adding myself to committers list.
3248
3249         * Scripts/webkitpy/common/config/committers.py:
3250
3251 2010-09-09  Mihai Parparita  <mihaip@chromium.org>
3252
3253         Reviewed by Tony Chang.
3254
3255         Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
3256         https://bugs.webkit.org/show_bug.cgi?id=45479
3257
3258         Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after
3259         implementation in ResourceLoadDelegate in the Mac port).
3260
3261         * DumpRenderTree/chromium/LayoutTestController.cpp:
3262         (LayoutTestController::LayoutTestController):
3263         (LayoutTestController::dumpResourceResponseMIMETypes):
3264         (LayoutTestController::reset):
3265         * DumpRenderTree/chromium/LayoutTestController.h:
3266         (LayoutTestController::setShouldDumpResourceResponseMIMETypes):
3267         (LayoutTestController::shouldDumpResourceResponseMIMETypes):
3268         * DumpRenderTree/chromium/TestShell.h:
3269         (TestShell::shouldDumpResourceResponseMIMETypes):
3270         * DumpRenderTree/chromium/WebViewHost.cpp:
3271         (WebViewHost::didReceiveResponse):
3272
3273 2010-09-09  Mihai Parparita  <mihaip@chromium.org>
3274
3275         Reviewed by Daniel Bates.
3276
3277         svn-apply tries to delete directories it shouldn't
3278         https://bugs.webkit.org/show_bug.cgi?id=45424
3279
3280         isDirectoryEmptyForRemoval had the wrong check. If an item in the
3281         directory is itself a directory, then the directory is definitely
3282         not empty.
3283
3284         * Scripts/svn-apply:
3285
3286 2010-09-09  Chris Fleizach  <cfleizach@apple.com>
3287
3288         Fixing GTK and windows build failure.
3289
3290         AX: Support AccessibilityTextMarkers in DRT
3291         https://bugs.webkit.org/show_bug.cgi?id=44778
3292
3293         * DumpRenderTree/AccessibilityTextMarker.h:
3294         (AccessibilityTextMarker::platformTextMarker):
3295         (AccessibilityTextMarkerRange::platformTextMarkerRange):
3296         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
3297         (AccessibilityTextMarker::platformTextMarker):
3298         (AccessibilityTextMarkerRange::platformTextMarkerRange):
3299
3300 2010-09-09  Chris Fleizach  <cfleizach@apple.com>
3301
3302         Reviewed by David Kilzer.
3303
3304         AX: Support AccessibilityTextMarkers in DRT
3305         https://bugs.webkit.org/show_bug.cgi?id=44778
3306
3307         Add AccessibilityTextMarker and AccessibilityTextMarkerRange which encapsulate the AXTextMarkers 
3308         that WebCore uses when vending information about its VisiblePositions through AX.
3309
3310         There are a few new methods in AccessibilityUIElement to retrieve and use text markers, and some basic
3311         methods for encapsulating and checking equality.
3312
3313         This will allow future bug fixes in the text marker system to be adequately tested.
3314
3315         * DumpRenderTree/AccessibilityTextMarker.cpp: Added.
3316         (toTextMarker):
3317         (isMarkerEqualCallback):
3318         (markerFinalize):
3319         (AccessibilityTextMarker::makeJSAccessibilityTextMarker):
3320         (AccessibilityTextMarker::getJSClass):
3321         (toTextMarkerRange):
3322         (isMarkerRangeEqualCallback):
3323         (markerRangeFinalize):
3324         (AccessibilityTextMarkerRange::makeJSAccessibilityTextMarkerRange):
3325         (AccessibilityTextMarkerRange::getJSClass):
3326         * DumpRenderTree/AccessibilityTextMarker.h: Added.
3327         (AccessibilityTextMarker::platformTextMarker):
3328         (AccessibilityTextMarkerRange::platformTextMarkerRange):
3329         (AccessibilityTextMarker::AccessibilityTextMarker):
3330         (AccessibilityTextMarker::~AccessibilityTextMarker):
3331         (AccessibilityTextMarker::isEqual):
3332         (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
3333         (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
3334         (AccessibilityTextMarkerRange::isEqual):
3335         * DumpRenderTree/AccessibilityUIElement.cpp:
3336         (textMarkerRangeForElementCallback):
3337         (textMarkerRangeLengthCallback):
3338         (textMarkerRangeForMarkersCallback):
3339         (startTextMarkerForTextMarkerRangeCallback):
3340         (endTextMarkerForTextMarkerRangeCallback):
3341         (accessibilityElementForTextMarkerCallback):
3342         (AccessibilityUIElement::textMarkerRangeForElement):
3343         (AccessibilityUIElement::textMarkerRangeLength):
3344         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
3345         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
3346         (AccessibilityUIElement::accessibilityElementForTextMarker):
3347         (AccessibilityUIElement::getJSClass):
3348         * DumpRenderTree/AccessibilityUIElement.h:
3349         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3350         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm: Added.
3351         (AccessibilityTextMarker::AccessibilityTextMarker):
3352         (AccessibilityTextMarker::~AccessibilityTextMarker):
3353         (AccessibilityTextMarker::isEqual):
3354         (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
3355         (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
3356         (AccessibilityTextMarkerRange::isEqual):
3357         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3358         (AccessibilityUIElement::textMarkerRangeForElement):
3359         (AccessibilityUIElement::textMarkerRangeLength):
3360         (AccessibilityUIElement::textMarkerRangeForMarkers):
3361         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
3362         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
3363         (AccessibilityUIElement::accessibilityElementForTextMarker):
3364         * DumpRenderTree/win/DumpRenderTree.vcproj:
3365
3366 2010-08-25  Tony Chang  <tony@chromium.org>
3367
3368         Reviewed by Ojan Vafai.
3369
3370         don't delete duplicates needed because of intermediate results
3371         https://bugs.webkit.org/show_bug.cgi?id=44653
3372
3373         Also, output the full path so we can pipe the output to rm.
3374
3375         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
3376         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3377
3378 2010-09-09  Balazs Kelemen  <kb@inf.u-szeged.hu>
3379
3380         Reviewed by Andreas Kling.
3381
3382         [Qt] MiniBrowser does not starts properly
3383         https://bugs.webkit.org/show_bug.cgi?id=45459
3384
3385         Do not try set up the first window by calling newWindow on a
3386         newly created BrowserWindow since it creates a new object.
3387         * MiniBrowser/qt/BrowserWindow.cpp:
3388         (BrowserWindow::BrowserWindow):
3389         * MiniBrowser/qt/main.cpp:
3390         (main):
3391
3392 2010-09-09  Martin Robinson  <mrobinson@igalia.com>
3393
3394         Reviewed by Xan Lopez.
3395
3396         [GTK] Get ImageDiff building on Win32
3397         https://bugs.webkit.org/show_bug.cgi?id=45353
3398
3399         * DumpRenderTree/gtk/ImageDiff.cpp:
3400         (main): Switch from using strtok to g_strsplit.
3401
3402 2010-09-09  Zoltan Horvath  <zoltan@webkit.org>
3403
3404         Reviewed by Andreas Kling.
3405
3406         [Qt] Modify load method of MiniBrowser's BrowserView class
3407         https://bugs.webkit.org/show_bug.cgi?id=45442
3408
3409         Modify load method to take a QString as argument, remove unnecessary QT_VERSION_CHECK.
3410
3411         * MiniBrowser/qt/BrowserView.cpp:
3412         (BrowserView::load):
3413         * MiniBrowser/qt/BrowserView.h:
3414         * MiniBrowser/qt/BrowserWindow.cpp:
3415         (BrowserWindow::load):
3416
3417 2010-09-09  Tony Chang  <tony@chromium.org>
3418
3419         Reviewed by Ojan Vafai.
3420
3421         fix show_results in new-run-webkit-tests
3422         https://bugs.webkit.org/show_bug.cgi?id=45413
3423
3424         * Scripts/webkitpy/layout_tests/port/chromium.py:
3425
3426 2010-09-08  Victor Wang  <victorw@chromium.org>
3427
3428         Reviewed by Ojan Vafai.
3429
3430         [Chromium] Fix test results server to make sure
3431         it does not have corrupted data.
3432
3433         results.json file size coulbe be >1M and we split
3434         the data into multiple data store entries in this
3435         case. This patch fixes the issue that the data may
3436         be corrupted if data store error happens in the middle
3437         of saving multiple entries.
3438
3439         https://bugs.webkit.org/show_bug.cgi?id=45063
3440
3441         * TestResultServer/model/datastorefile.py:
3442
3443 2010-09-08  Peter Varga  <pvarga@inf.u-szeged.hu>
3444
3445         Reviewed by Kenneth Rohde Christiansen.
3446
3447         Fix ignoring return value warning in case of gcc 4.4.4
3448         https://bugs.webkit.org/show_bug.cgi?id=45384
3449
3450         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3451         (testPostURLFile):
3452         If fwrite have written zero byte then the testPostURLFile function
3453         returns with false as tempFile can't be opened.
3454         * DumpRenderTree/qt/ImageDiff.cpp:
3455         (main):
3456         Put fwrite function into an if condition without body to avoid
3457         warning. It is safe because this function writes to the stdout.
3458
3459 2010-09-08  Satish Sampath  <satish@chromium.org>
3460
3461         Unreviewed, adding myself to committers list.
3462
3463         * Scripts/webkitpy/common/config/committers.py:
3464
3465 2010-09-08  Hans Wennborg  <hans@chromium.org>
3466
3467         Unreviewed.
3468
3469         Adding myself as a committer in committers.py.
3470
3471         * Scripts/webkitpy/common/config/committers.py:
3472
3473 2010-09-08  Zoltan Horvath  <zoltan@webkit.org>
3474
3475         Reviewed by Simon Hausmann.
3476
3477         [Qt] Refactor MiniBrowser 
3478         https://bugs.webkit.org/show_bug.cgi?id=45173
3479
3480         Split BrowserWindow into two source files and headers. Remove unnecessary header includes.
3481
3482         * MiniBrowser/qt/BrowserView.cpp: Added.
3483         (createNewPage):
3484         (BrowserView::BrowserView):
3485         (BrowserView::resizeEvent):
3486         (BrowserView::load):
3487         (BrowserView::view):
3488         * MiniBrowser/qt/BrowserView.h: Added.
3489         (BrowserView::~BrowserView):
3490         * MiniBrowser/qt/BrowserWindow.cpp:
3491         * MiniBrowser/qt/BrowserWindow.h:
3492         * MiniBrowser/qt/MiniBrowser.pro:
3493
3494 2010-09-08  Adam Barth  <abarth@webkit.org>
3495
3496         Rubber-stamped by Eric Seidel.
3497
3498         Rename DocLoader to CachedResourceLoader because that's what it does.
3499
3500         * Scripts/do-webcore-rename:
3501
3502 2010-09-07  Kinuko Yasuda  <kinuko@chromium.org>
3503
3504         Reviewed by Ojan Vafai.
3505
3506         Enable incremental results.json generation for non-layout tests.
3507         https://bugs.webkit.org/show_bug.cgi?id=45315
3508
3509         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: Enable generate_incremental_results=True by default. (This still keeps to generate results.json.)  Also add a code to upload results json files to the app-engine server.  Need a chromium change to actually start the uploading.
3510
3511         * TestResultServer/model/jsonresults.py: Make sure we save the file with test_type for incremental cases too.
3512
3513
3514 2010-09-07  Dirk Pranke  <dpranke@chromium.org>
3515
3516         Unreviewed, build fix
3517
3518         Missed one test in mac_unittest.py in previous change; for some
3519         reason the method is listed twice. I will fix both for now, but will
3520         figure this out in a later, not-time-sensitive patch.
3521
3522         https://bugs.webkit.org/show_bug.cgi?id=45357
3523
3524         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3525
3526 2010-09-07  Kent Tamura  <tkent@chromium.org>
3527
3528         Reviewed by Tony Chang.
3529
3530         test-webkitpy: Fix load error of
3531         webkitpy/layout_tests/port/factory_unittest.py on Win32 Python
3532         https://bugs.webkit.org/show_bug.cgi?id=45356 Need a short
3533
3534         * Scripts/webkitpy/layout_tests/port/server_process.py:
3535           Avoid to import fcntl on win32. Win32 Python doesn't have fcntl
3536           and we don't use server_process.py on Win32 Python. However
3537           unittest.py tries to load everything in a module.
3538
3539 2010-09-07  Dirk Pranke  <dpranke@chromium.org>
3540
3541         Reviewed by Kent Tamura.
3542
3543         Fix regression introduced in previous change to new-run-webkit-tests
3544         (bug 45090) to not try to run unittests for the Mac implementation
3545         of the Port interface if we aren't running on a Mac.
3546
3547         Also fix the overrides implementation mock in the chromium unittests
3548         to fix the case where there are overrides checked in that cause
3549         problems.
3550
3551         https://bugs.webkit.org/show_bug.cgi?id=45357
3552
3553         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3554         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3555         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3556
3557 2010-09-01  Dirk Pranke  <dpranke@chromium.org>
3558
3559         Reviewed by Ojan Vafai.
3560
3561         new-run-webkit-tests: still more unit tests
3562
3563         Clean up and remove unnecessary code. Biggest notable change is
3564         moving the chromium-specific imagediff code from port/base to
3565         port/chromium.
3566
3567         Add more unit tests for run_webkit_tests.py, port/base.py,
3568         port/factory.py, port/dryrun.py, and
3569         layout_package/dump_render_tree_thread.py
3570
3571         This covers almost all of the generic and test code paths except for
3572         a few error paths involving invalid or port-specific command line
3573         arguments, and the code path for uploading results files to the
3574         buildbots.
3575         
3576         https://bugs.webkit.org/show_bug.cgi?id=45090
3577
3578         * Scripts/webkitpy/layout_tests/data/failures/expected/hang.html: Added.
3579         * Scripts/webkitpy/layout_tests/data/http/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
3580         * Scripts/webkitpy/layout_tests/data/http/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
3581         * Scripts/webkitpy/layout_tests/data/http/tests/ssl/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
3582         * Scripts/webkitpy/layout_tests/data/http/tests/ssl/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
3583         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
3584         * Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
3585         * Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
3586         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3587         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Added.