Reviewed by Darin Adler.
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-07-09  Alexey Proskuryakov  <ap@apple.com>
2
3         Reviewed by Darin Adler.
4
5         https://bugs.webkit.org/show_bug.cgi?id=13075
6         XMLHttpRequest with failed authentication should set status to 401
7
8         https://bugs.webkit.org/show_bug.cgi?id=6871
9         <rdar://problem/3363403> 401 error page is never shown
10
11         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
12         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
13         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
14         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
15         Do respond even if handlesAuthenticationChallenges() is false. Pretend that the user pressed
16         the Cancel button.
17
18 2010-07-12  Andreas Kling  <andreas.kling@nokia.com>
19
20         Reviewed by Tor Arne Vestbø.
21
22         [Qt] Add location bar (Ctrl+L) shortcut in QtTestBrowser
23         https://bugs.webkit.org/show_bug.cgi?id=42082
24
25         * QtTestBrowser/main.cpp:
26         (LauncherWindow::createChrome):
27         * QtTestBrowser/mainwindow.cpp:
28         (MainWindow::openLocation):
29         * QtTestBrowser/mainwindow.h:
30
31 2010-07-12  Adam Roben  <aroben@apple.com>
32
33         Make the Python autoinstaller not use a dead SourceForge server
34
35         Fixes <http://webkit.org/b/42080> webkit-patch is broken due to
36         offline SourceForge server
37
38         Reviewed by Anders Carlsson.
39
40         * Scripts/webkitpy/thirdparty/__init__.py: Use
41         surfnet.dl.sourceforge.net instead of hivelocity.dl.sourceforge.net,
42         which seems to be down.
43
44 2010-07-12  Adam Roben  <aroben@apple.com>
45
46         Make run-webkit-tests print how many tests timed out when exiting
47         early
48
49         The number of timed-out tests is taken into account when deciding
50         whether to exit early. Leaving it out of the output just makes the
51         script look buggy (because it might say something like "Exiting early
52         after 0 crashes.").
53
54         Fixes <http://webkit.org/b/42077> run-webkit-tests prints confusing
55         messages when exiting early due to crashes and time-outs
56
57         Reviewed by Anders Carlsson.
58
59         * Scripts/old-run-webkit-tests:
60         (stopRunningTestsEarlyIfNeeded): When stopping, print the number of
61         timed-out tests, too.
62
63 2010-07-11  Maciej Stachowiak  <mjs@apple.com>
64
65         Reviewed by Dan Bernstein.
66
67         Implement animation-related methods for WebKitTestRunner
68         https://bugs.webkit.org/show_bug.cgi?id=42053
69         
70         Implemented numberOfActiveAnimatiosn and pauseAnimationAtTimeOnElementWithId. Many
71         animation tests were hanging otherwise.
72
73         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
74         (WTR::LayoutTestController::numberOfActiveAnimations):
75         (WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId):
76         (WTR::numberOfActiveAnimationsCallback):
77         (WTR::pauseAnimationAtTimeOnElementWithIdCallback):
78         (WTR::LayoutTestController::staticFunctions):
79         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
80
81 2010-07-11  Daniel Bates  <dbates@rim.com>
82
83         Reviewed by David Kilzer.
84
85         Enable executable support for svn-apply and svn-unapply
86         https://bugs.webkit.org/show_bug.cgi?id=39409
87
88         Connect up the Git and SVN executable bit support in parseDiff() so that
89         executable bit changes are propagated via the returned diff hash to the
90         patch function in svn-apply and svn-unapply.
91
92         * Scripts/VCSUtils.pm:
93           - Modified parseDiff() to call parseSvnDiffProperties when
94             it finds the start of an SVN property change diff.
95           - Removed FIXME comment above parseSvnDiffProperties() since
96             it is now being used by parseDiff().
97           - Export method scmToggleExecutableBit() now that we added the
98             executableBitDelta hash key. (This should have been exported
99             when we added this function in Bug #38423 <https://bugs.webkit.org/show_bug.cgi?id=38423>).
100         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
101           - Updated results for:
102             "rename (with executable bit change)"
103               - Test value of executableBitDelta (now that we have support).
104             "SVN: binary file (isBinary true)"
105               - Remove the property change diff from svnConvertedText. We plan
106                 to remove svnConvertedText in the future. So, we decided
107                 against adding such support to any new code, such as the
108                 property parsing routines. Therefore, we do not keep SVN
109                 converted text for property change diffs.
110           - Added unit tests:
111             "SVN: file change diff with property change diff"
112             "SVN: file change diff, followed by property change diff on different file"
113             "SVN: property diff, followed by file change diff"
114             "SVN: copied file with property change"
115             "SVN: two consecutive property diffs"
116             "SVN: binary file with executable bit change"
117             "SVN: binary file followed by property change on different file"
118             "SVN: binary file followed by file change on different file"
119             "SVN: file change diff with property change, followed by property change diff"
120             "SVN: file change diff with property change, followed by file change diff"
121
122 2010-07-11  Maciej Stachowiak  <mjs@apple.com>
123
124         Reviewed by Dan Bernstein.
125
126         Implement waitUntilDone and notifyDone for WebKitTestRunner
127         https://bugs.webkit.org/show_bug.cgi?id=42049
128
129         With this fix, most of the DOM tests pass.
130         
131         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
132         (WTR::InjectedBundle::didCreatePage): Track the main page. Not
133         a great way to do it in the future case where we may get multiple
134         pages - we really need a way to send it over from the ui process.
135         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
136         (WTR::InjectedBundle::page): A way to get the main page.
137         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
138         (WTR::InjectedBundlePage::InjectedBundlePage): Initialize m_isLoading to false.
139         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): Track that we
140         are loading.
141         (WTR::InjectedBundlePage::dump): Factor into a method so this can be
142         called by the layout test controller. Also, cancel any pending watchdogs.
143         (WTR::InjectedBundlePage::didFinishLoadForFrame): Note that we are done loading.
144         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): Ditto.
145         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
146         (WTR::InjectedBundlePage::isLoading): A way to track if we are loading.
147         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
148         (WTR::LayoutTestController::LayoutTestController): Initialize m_waitToDump
149         to false.
150         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Invalidate 
151         the watchdog.
152         (WTR::waitUntilDoneWatchdogFired): Static helper for the watchdog timer.
153         (WTR::LayoutTestController::setWaitToDump): Set the flag.
154         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Handle the case
155         where waitUntilDone times out.
156         (WTR::LayoutTestController::notifyDone): Dump, if loading is done.
157         (WTR::waitUntilDoneCallback): JS glue for waitUntilDone.
158         (WTR::notifyDoneCallback): JS glue for notifyDone.
159         (WTR::LayoutTestController::staticFunctions): Add waitUntilDone and notifyDone
160         to the layoutController.
161         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
162         (WTR::LayoutTestController::waitToDump): Inline method to get the wait state.
163
164 2010-07-09  Brian Weinstein  <bweinstein@apple.com>
165
166         Rubber-stamped by Dan Bernstein.
167
168         Windows testers running Windows 7 were hanging during test_kill_process. Changing the
169         number of attempts from 3 to 10 fixes the problem on the new bots (and doesn't seem to
170         slow down the tests).
171
172         * Scripts/webkitpy/common/system/executive.py:
173
174 2010-07-09  Luiz Agostini  <luiz.agostini@openbossa.org>
175
176         Reviewed by Kenneth Rohde Christiansen.
177
178         [Qt] Mac build fix
179         https://bugs.webkit.org/show_bug.cgi?id=41967
180
181         Adding file PluginObjectMac.mm and frameworks Cocoa and QuartzCore.
182
183         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
184
185 2010-07-09  Diego Gonzalez  <diegohcg@webkit.org>
186
187         Reviewed by Antonio Gomes.
188
189         [Qt] [WebKit2] Add navigation actions to MiniBrowser toolbar
190         https://bugs.webkit.org/show_bug.cgi?id=41966
191
192         * MiniBrowser/qt/BrowserWindow.cpp:
193         (BrowserWindow::BrowserWindow):
194
195 2010-07-09  Leon Clarke  <leonclarke@google.com>
196
197         Reviewed by Adam Barth.
198
199         add support for link prefetching
200         https://bugs.webkit.org/show_bug.cgi?id=3652
201
202         * Scripts/build-webkit:
203
204 2010-07-09  Ojan Vafai  <ojan@chromium.org>
205
206         Reviewed by Adam Barth.
207
208         r63004 broke some python tests
209         https://bugs.webkit.org/show_bug.cgi?id=42007
210
211         AbstractStep now checks options.no_squash and options.squash, so
212         they needed to have real values. Mock would return an object for those,
213         which would then act as if the values were True.
214
215         * Scripts/webkitpy/tool/commands/commandtest.py:
216         * Scripts/webkitpy/tool/commands/download_unittest.py:
217         * Scripts/webkitpy/tool/commands/stepsequence.py:
218         * Scripts/webkitpy/tool/commands/upload_unittest.py:
219         * Scripts/webkitpy/tool/mocktool.py:
220         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
221         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
222         * Scripts/webkitpy/tool/steps/steps_unittest.py:
223         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
224         * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py:
225
226 2010-07-09  Ojan Vafai  <ojan@chromium.org>
227
228         Reviewed by Adam Barth.
229
230         --squash should go away and become the default
231         https://bugs.webkit.org/show_bug.cgi?id=39624
232
233         If there are local commits and working copy changes, then prompt the user
234         whether to continue. Setting git config webkit-patch.commit_should_always_squash
235         true bypasses the prompt.
236
237         --git-commit=HEAD.. operates on working copy changes only.
238         --git-commit=committish operates on a range of commits as a single commit.
239             e.g. --git-commit=HEAD only operates on the HEAD commit.
240             --git-commit=HEAD~4..HEAD~2 will operate on HEAD~3 and HEAD~2 as a single commit.
241
242         --no-squash and --squash are left in with descriptive error messages if used.
243
244         * Scripts/check-webkit-style:
245         * Scripts/webkitpy/common/checkout/api.py:
246         * Scripts/webkitpy/common/checkout/api_unittest.py:
247         * Scripts/webkitpy/common/checkout/scm.py:
248         * Scripts/webkitpy/common/checkout/scm_unittest.py:
249         * Scripts/webkitpy/common/net/rietveld.py:
250         * Scripts/webkitpy/common/system/user.py:
251         * Scripts/webkitpy/style/optparser.py:
252         * Scripts/webkitpy/style_references.py:
253         * Scripts/webkitpy/tool/commands/download.py:
254         * Scripts/webkitpy/tool/commands/upload.py:
255         * Scripts/webkitpy/tool/mocktool.py:
256         * Scripts/webkitpy/tool/steps/abstractstep.py:
257         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
258         * Scripts/webkitpy/tool/steps/checkstyle.py:
259         * Scripts/webkitpy/tool/steps/checkstyle_unittest.py: Removed.
260         * Scripts/webkitpy/tool/steps/commit.py:
261         * Scripts/webkitpy/tool/steps/options.py:
262         * Scripts/webkitpy/tool/steps/preparechangelog.py:
263         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
264         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
265         * Scripts/webkitpy/tool/steps/validatereviewer.py:
266
267 2010-07-09  Mark Rowe  <mrowe@apple.com>
268
269         Add two new Windows test build slaves.
270
271         * BuildSlaveSupport/build.webkit.org-config/config.json:
272
273 2010-07-09  Albert J. Wong  <ajwong@chromium.org>
274
275         Reviewed by David Levin.
276
277         rebaseline_chromium_webkit_tests missing --use_drt option on linux
278         https://bugs.webkit.org/show_bug.cgi?id=41985
279
280         This adds in the --use_drt option for rebaseline_chromium_webkit_tests
281         so that it works on linux. This is essentially a "compile-fix" for the
282         script.
283
284         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
285
286 2010-07-09  Nico Weber  <thakis@chromium.org>
287
288         Unreviewed. Adding myself as committer.
289
290         * Scripts/webkitpy/common/config/committers.py:
291
292 2010-07-09  David Kilzer  <ddkilzer@apple.com>
293
294         Revert "<http://webkit.org/b/41788> commit-log-editor: wrong ChangeLog read when invoked from subdir with git"
295
296         This reverts commit r62692.
297
298         * Scripts/commit-log-editor:
299
300 2010-07-08  Kinuko Yasuda  <kinuko@chromium.org>
301
302         Reviewed by Ojan Vafai.
303
304         cleanup json_results_generator dependencies so that non-layout-tests can also use it safely
305         https://bugs.webkit.org/show_bug.cgi?id=38693
306
307         Introduced a new base class JSONResultsGeneratorBase that doesn't
308         have any dependency on layout_tests packages.
309         Turned JSONResultsGenerator into a wrapper class of the base class
310         so that the old code can work with it during the cleanup.
311
312         Added json_results_generator_unittest.py.
313
314         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
315         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
316         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py: Added
317
318 2010-07-09  Abhishek Arya  <inferno@chromium.org>
319
320         Unreviewed.
321
322         Marking myself as a committer.
323
324         * Scripts/webkitpy/common/config/committers.py:
325
326 2010-07-09  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
327
328         Reviewed by Antti Koivisto.
329
330         Implement MiniBrowser for Qt.
331         https://bugs.webkit.org/show_bug.cgi?id=40233
332
333         * MiniBrowser/qt/BrowserWindow.cpp: Added.
334         (createNewPage):
335         (BrowserView::BrowserView):
336         (BrowserView::resizeEvent):
337         (BrowserView::load):
338         (BrowserView::view):
339         (BrowserWindow::BrowserWindow):
340         (BrowserWindow::load):
341         (BrowserWindow::changeLocation):
342         (BrowserWindow::~BrowserWindow):
343         * MiniBrowser/qt/BrowserWindow.h: Added.
344         (BrowserView::~BrowserView):
345         * MiniBrowser/qt/MiniBrowser.pro: Added.
346         * MiniBrowser/qt/main.cpp: Added.
347         (main):
348
349 2010-07-09  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
350
351         Reviewed by Simon Hausmann.
352
353         Introduce the Qt autotest launcher.
354
355         Qt autotests should be executed more frequently, ideally by the Qt
356         build bot. This is the first step to provide the tests more accessible.
357
358         [Qt] It should be easier to run all Qt's autotests.
359         https://bugs.webkit.org/show_bug.cgi?id=31625
360
361         * Scripts/run-qtwebkit-tests: Added.
362
363 2010-07-09  Adam Barth  <abarth@webkit.org>
364
365         Reviewed by Eric Seidel.
366
367         commit-queue should merge to TOT when checkout needs update
368         https://bugs.webkit.org/show_bug.cgi?id=41944
369
370         There are a bunch of different designs that are possible here.  This
371         one merges to top of tree by cleaning out the working copy and
372         re-applying the patch.  Once you decide to merge that way, you need to
373         decide who's going to retry.  In this patch, we retry in the child
374         process instead of plumbing the failure reason to the master process.
375
376         This patch is difficult to test end-to-end, but hopefully it will work.
377         :)
378
379         * Scripts/webkitpy/tool/commands/queues.py:
380         * Scripts/webkitpy/tool/commands/stepsequence.py:
381         * Scripts/webkitpy/tool/multicommandtool.py:
382         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
383
384 2010-07-09  Dumitru Daniliuc  <dumi@chromium.org>
385
386         Reviewed by Darin Adler.
387
388         Add a script to check for unnecessary includes in header files.
389         https://bugs.webkit.org/show_bug.cgi?id=41894
390
391         * Scripts/check-header-includes: Added.
392
393 2010-07-09  Adam Barth  <abarth@webkit.org>
394
395         Reviewed by Eric Seidel.
396
397         Add --html5-treebuilder option to run-webkit-tests
398         https://bugs.webkit.org/show_bug.cgi?id=41922
399
400         We're down to one or two regressions in the HTML5lib test suite.  It's
401         getting to be time to look at fixing LayoutTests.
402
403         * Scripts/old-run-webkit-tests:
404
405 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
406
407         Fix Tiger plugin test failures; the #ifdefs were incorrect, resulting
408         in the drawing model never getting set on Tiger.
409
410         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
411         (NPP_New):
412
413 2010-07-08  Aaron Boodman  <aa@chromium.org>
414
415         Reviewed by Timothy Hatcher.
416
417         Add the ability for user scripts and user styles to affect just the top frame.
418
419         https://bugs.webkit.org/show_bug.cgi?id=41529
420
421         * DumpRenderTree/LayoutTestController.h: Added new allFrames param.
422         * DumpRenderTree/LayoutTestController.cpp: Ditto.
423         (addUserScriptCallback):
424         (addUserStyleSheetCallback):
425         * DumpRenderTree/chromium/LayoutTestController.cpp: Ditto.
426         (LayoutTestController::addUserScript):
427         (LayoutTestController::addUserStyleSheet):
428         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Ditto.
429         (LayoutTestController::addUserScript):
430         (LayoutTestController::addUserStyleSheet):
431         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Ditto.
432         (LayoutTestController::addUserScript):
433         (LayoutTestController::addUserStyleSheet):
434         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Ditto.
435         (LayoutTestController::addUserScript):
436         (LayoutTestController::addUserStyleSheet):
437         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Ditto.
438         (LayoutTestController::addUserScript):
439         (LayoutTestController::addUserStyleSheet):
440
441 2010-07-08  Adele Peterson  <adele@apple.com>
442
443         Reviewed by Jon Honeycutt, Adam Roben, and Darin Adler.
444
445         Test infrastructure for https://bugs.webkit.org/show_bug.cgi?id=41721
446         <rdar://problem/8158561> Missing plug-in indicator should have a pressed state
447
448         Log when the missing plugin button is pressed.
449
450         * DumpRenderTree/mac/UIDelegate.mm:
451         (-[UIDelegate webView:didPressMissingPluginButton:]):
452         * DumpRenderTree/win/UIDelegate.cpp:
453         (UIDelegate::QueryInterface):
454         (UIDelegate::createWebViewWithRequest):
455         (UIDelegate::drawBackground):
456         (UIDelegate::decidePolicyForGeolocationRequest):
457         (UIDelegate::didPressMissingPluginButton):
458         * DumpRenderTree/win/UIDelegate.h:
459
460 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
461
462         Fix the Tiger build.
463
464         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
465         (NPP_New):
466
467 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
468
469         Fix windows build.
470
471         #ifdef code for Mac.
472
473         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
474         (NPP_New):
475
476 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
477
478         Reviewed by Anders Carlsson.
479
480         Allow the TestPlugin to use Core Animation rendering for testing
481         https://bugs.webkit.org/show_bug.cgi?id=41872
482         
483         Add the ability for the TestPlugin to use the CoreAnimation rendering model
484         when available, based on the "drawingmodel" attribute of the embed tag:
485             drawingmodel="coreanimation"
486
487         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add PluginObjectMac.mm
488         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Add some macros so we can detect
489         when building on Tiger. Add a void* coreAnimationLayer member.
490         
491         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm: Added.
492         (createCoreAnimationLayer): Obj-C method to create the CALayer.
493         
494         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
495         (NPP_New): Look for the drawingmodel attribute to decide which drawing
496         model to use.
497         (NPP_Destroy): Release the CALayer if we have one.
498         (NPP_GetValue): Return the retained CALayer.
499
500 2010-07-08  Martin Robinson  <mrobinson@igalia.com>
501
502         Reviewed by Xan Lopez.
503
504         [GTK] Support pixel tests
505         https://bugs.webkit.org/show_bug.cgi?id=31518
506
507         Convert this file from CRLF to NL line endings. It will soon
508         be used on more than just the WinCairo platform.
509
510         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
511         (writeFunction):
512         (printPNG):
513         (computeMD5HashStringForBitmapContext):
514         (dumpBitmap):
515
516 2010-07-08  Steve Falkenburg  <sfalken@apple.com>
517
518         Reviewed by Darin Adler.
519
520         Enable Data Execution Prevention for our test harnesses on Windows
521         https://bugs.webkit.org/show_bug.cgi?id=41882
522
523         * DumpRenderTree/win/DumpRenderTree.vcproj:
524         * DumpRenderTree/win/ImageDiff.vcproj:
525         * WebKitAPITest/WebKitAPITest.vcproj:
526         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
527
528 2010-07-07  Robert Hogan  <robert@webkit.org>
529
530         Reviewed by Kenneth Rohde Christiansen.
531
532         [Qt] Add DRT support for pageProperty etc.
533
534         https://bugs.webkit.org/show_bug.cgi?id=41584
535
536         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
537         (LayoutTestController::isPageBoxVisible):
538         (LayoutTestController::pageSizeAndMarginsInPixels):
539         (LayoutTestController::pageProperty):
540         (LayoutTestController::addUserStyleSheet):
541         * DumpRenderTree/qt/LayoutTestControllerQt.h:
542
543 2010-07-08  Martin Robinson  <mrobinson@igalia.com>
544
545         Reviewed by Xan Lopez.
546
547         Remove a warnings from the ImageDiff build by using the proper
548         printf format string for the gsize data type.
549
550         * DumpRenderTree/gtk/ImageDiff.cpp:
551         (printImage): Use the proper printf format string for the gsize data type.
552
553 2010-07-08  Alice Liu  <alice.liu@apple.com>
554
555         Reviewed by Sam Weinig.
556
557         https://bugs.webkit.org/show_bug.cgi?id=41653
558         Add new WebKitTestRunner project for Windows
559
560         * WebKitTestRunner/WebKitTestRunnerPrefix.h: 
561         Similar to how it's done in DumpRenderTree, define max and min early
562         on so that they don't get replaced by a macro requiring 2 arguments.
563
564         * WebKitTestRunner/win: Added.
565         * WebKitTestRunner/win/WebKitTestRunner.sln: Added.
566         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added.
567         * WebKitTestRunner/win/main.cpp: Added.
568         (main): Implemented
569
570         Added these files with stubbed out functions:
571         * WebKitTestRunner/win/PlatformWebViewWin.cpp: Added.
572         (WTR::PlatformWebView::PlatformWebView):
573         (WTR::PlatformWebView::~PlatformWebView):
574         (WTR::PlatformWebView::page):
575         * WebKitTestRunner/win/TestControllerWin.cpp: Added.
576         (WTR::TestController::initializeInjectedBundlePath):
577         * WebKitTestRunner/win/TestInvocationWin.cpp: Added.
578         (WTR::TestInvocation::runUntil):
579
580 2010-07-07  Martin Robinson  <mrobinson@igalia.com>
581
582         Reviewed by Gustavo Noronha Silva.
583
584         [GTK] Implement ImageDiff and add it to the build system
585         https://bugs.webkit.org/show_bug.cgi?id=41779
586
587         Add the initial implementation of the ImageDiff tool for the GTK+
588         port. This is an essential tool for doing pixel tests. The implementation
589         is based on the Mac and Chromium ports.
590
591         * DumpRenderTree/gtk/ImageDiff.cpp: Added.
592         (readPixbufFromStdin): Added.
593         (differenceImageFromDifferenceBuffer): Ditto.
594         (calculateDifference): Ditto.
595         (printImage): Ditto.
596         (printImageDifferences): Ditto.
597         (main): Ditto.
598         * GNUmakefile.am: Add ImageDiff to the WebKitTools build scripts.
599
600 2010-07-08  Jay Civelli  <jcivelli@chromium.org>
601
602         Unreviewed. Adding myself as a committer.
603
604         * Scripts/webkitpy/common/config/committers.py:
605
606 2010-07-08  Adam Roben  <aroben@apple.com>
607
608         Make Windows stop running tests from platform/mac
609
610         r62742 made a change (at my suggestion!) that caused us to start
611         looking for tests in platform/mac, rather than just looking for
612         expected results in platform/mac. This patch just undoes that part of
613         r62742.
614
615         Fixes <http://webkit.org/b/41855> REGRESSION (r62742): Windows runs
616         tests from platform/mac, but shouldn't
617
618         Reviewed by Antti Koivisto and Anders Carlsson.
619
620         * Scripts/old-run-webkit-tests:
621         (top level): Removed "mac-snowleopard" and "mac" from @winPlatforms,
622         so we won't look in those directories for tests to run.
623         (expectedDirectoryForTest): Added back code from pre-r62742 to look in
624         platform/mac-snowleopard and platform/mac for expected results.
625
626 2010-07-08  Antonio Gomes  <tonikitoo@webkit.org>
627
628         Unreviewed. Adding myself as a reviewer.
629
630         * Scripts/webkitpy/common/config/committers.py:
631
632 2010-07-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
633
634         Update my e-mail in committers.py
635
636         * Scripts/webkitpy/common/config/committers.py:
637
638 2010-07-07  Daniel Bates  <dbates@rim.com>
639
640         Reviewed by Dumitru Daniliuc.
641
642         VCSUtils.pm complains about uninitialized value $newLine
643         https://bugs.webkit.org/show_bug.cgi?id=41333
644
645         Fixes an issue where VCSUtils::fixChangeLogPatch() may read off the end of
646         an array when fixing a change log entry that overlaps with an earlier
647         entry. In particular, when a patch contains a change log entry inserted
648         earlier in the change log file, but after an entry with the same author
649         and date.
650
651         * Scripts/VCSUtils.pm:
652             - Added for-loop constraint to fixChangeLogPatch() so that it does not
653               read off the end of the @overlappingLines array.
654         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl: Added unit test.
655
656 2010-07-07  Anders Carlsson  <andersca@apple.com>
657
658         Comment out a part of TestNetscapePlugin that caused tests to fail on Tiger and Leopard.
659
660         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
661         (NPP_New):
662
663 2010-07-07  Kent Tamura  <tkent@chromium.org>
664
665         Reviewed by Adam Barth.
666
667         [DRT/Chromium] Support for indeterminate checkbox
668         https://bugs.webkit.org/show_bug.cgi?id=41747
669
670         Import http://src.chromium.org/viewvc/chrome?view=rev&revision=51499
671
672         * DumpRenderTree/chromium/WebThemeControlDRT.cpp:
673         (WebThemeControlDRT::draw):
674         * DumpRenderTree/chromium/WebThemeControlDRT.h:
675         (WebThemeControlDRT::):
676         * DumpRenderTree/chromium/WebThemeEngineDRT.cpp:
677         (WebThemeEngineDRT::paintButton):
678
679 2010-07-07  Sam Weinig  <sam@webkit.org>
680
681         Reviewed by Mark Rowe.
682
683         Clean up MiniBrowser Xcode project.
684
685         - Use xcconfig files.
686         - Rename plists to canonical Info.plist
687         - Remove localizations.
688
689         * MiniBrowser/Configurations: Added.
690         * MiniBrowser/Configurations/Base.xcconfig: Added.
691         * MiniBrowser/Configurations/DebugRelease.xcconfig: Added.
692         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Added.
693         * MiniBrowser/Configurations/WebBundle.xcconfig: Added.
694         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
695         * MiniBrowser/WebBundle-Info.plist: Removed.
696         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
697         (-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
698         * MiniBrowser/mac/BrowserWindow.xib: Added.
699         * MiniBrowser/mac/BrowserWindowController.m:
700         (-[BrowserWindowController initWithPageNamespace:]):
701         * MiniBrowser/mac/English.lproj: Removed.
702         * MiniBrowser/mac/English.lproj/BrowserWindow.xib: Removed.
703         * MiniBrowser/mac/English.lproj/InfoPlist.strings: Removed.
704         * MiniBrowser/mac/English.lproj/MainMenu.xib: Removed.
705         * MiniBrowser/mac/Info.plist: Copied from MiniBrowser/mac/MiniBrowser-Info.plist.
706         * MiniBrowser/mac/MainMenu.xib: Added.
707         * MiniBrowser/mac/MiniBrowser-Info.plist: Removed.
708         * MiniBrowser/mac/WebBundle/Info.plist: Copied from MiniBrowser/WebBundle-Info.plist.
709
710 2010-07-07  Kent Tamura  <tkent@chromium.org>
711
712         Reviewed by Dimitri Glazkov.
713
714         [DRT/Chromium] Fix two regressions
715         https://bugs.webkit.org/show_bug.cgi?id=41745
716
717         * DumpRenderTree/chromium/WebViewHost.cpp:
718         (WebViewHost::paintInvalidatedRegion):
719          Repaint three times to fix svg/W3C-SVG-1.1/struct-use-01-t.svg
720          and svg/custom/use-on-g-containing-foreignObject-and-image.svg
721          though test_shell does it twice. Probably DRT needs it because
722          DRT delays painting as possible.
723
724 2010-07-07  Anders Carlsson  <andersca@apple.com>
725
726         Try to fix build.
727
728         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
729         (webkit_test_plugin_destroy_stream):
730
731 2010-07-07  Anders Carlsson  <andersca@apple.com>
732
733         Try to fix the GTK+ and Qt test failures by merging the newly added code from TestNetscapePlugin/main.cpp
734
735         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
736         (webkit_test_plugin_new_stream):
737         (webkit_test_plugin_destroy_stream):
738         (webkit_test_plugin_write_ready):
739         (webkit_test_plugin_write):
740
741 2010-07-07  Sam Weinig  <sam@webkit.org>
742
743         Reviewed by Mark Rowe.
744
745         Don't hard code the Mac OS X 10.6 SDK for MiniBrowser. 
746
747         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
748
749 2010-07-07  Anders Carlsson  <andersca@apple.com>
750
751         Use the correct XP_MACOSX define instead of XP_MAC. This was causing test failures on some platforms.
752
753         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
754         (NPP_New):
755         (NPP_HandleEvent):
756
757 2010-07-07  Brian Weinstein  <bweinstein@apple.com>
758
759         Reviewed by Adam Roben.
760
761         Need to have a way to specify different results for Windows XP and 7
762         https://bugs.webkit.org/show_bug.cgi?id=41776
763         
764         Add the ability to have platform/win-xp, platform/win-vista, and platform/win-7
765         subdirectories, so we can have different results for tests on Windows XP, Windows
766         Vista, and Windows 7.
767
768         Windows XP will try the order: win-xp, win-vista, win-7, win, mac-snowleopard, mac.
769         Windows Vista will try the order: win-vista, win-7, win, mac-snowleopard, mac.
770         Windows 7 will try the order: win-7, win, mac-snowleopard, mac.
771
772         This matches the behavior of the mac.
773
774         * Scripts/old-run-webkit-tests: Add multiple platforms for Windows, and if we are on XP
775             or Vista, try looking in other win-* subdirectories before win.
776         * Scripts/webkitdirs.pm: Add some helper functions to determine what version of Windows
777             we are running.
778
779 2010-07-07  Kent Tamura  <tkent@chromium.org>
780
781         Reviewed by Dimitri Glazkov.
782
783         [DRT/Chromium] Remove ASSERT_NOT_REACHED in some functions
784         https://bugs.webkit.org/show_bug.cgi?id=41753
785
786         The original code of the following functions in
787         test_shell_devtools_client.cc have NOTIMPLEMENTED(), not
788         ASSERT_NOT_REACHED(). The program shouldn't stop at these
789         functions.
790
791         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
792         (DRTDevToolsClient::activateWindow):
793         (DRTDevToolsClient::closeWindow):
794         (DRTDevToolsClient::dockWindow):
795         (DRTDevToolsClient::undockWindow):
796
797 2010-07-07  Anders Carlsson  <andersca@apple.com>
798
799         Reviewed by Sam Weinig.
800
801         Test that we call NPP_DestroyStream if a plug-in returns -1 from its NPP_Write function
802         https://bugs.webkit.org/show_bug.cgi?id=41821
803
804         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
805         (pluginGetProperty):
806         (pluginSetProperty):
807         (pluginAllocate):
808         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
809         Add and initialize the returnNegativeOneFromWrite property.
810
811         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
812         (NPP_NewStream):
813         Set the stream type to NP_NORMAL so we'll get write callbacks.
814
815         (NPP_DestroyStream):
816         Treat the onstreamdestroy attribute as a function name and not a string.
817
818         (NPP_WriteReady):
819         Have this return a nonzero value.
820
821         (NPP_Write):
822         If returnNegativeOneFromWrite is true return -1.
823
824 2010-07-07  Kevin Ollivier  <kevino@theolliviers.com>
825
826         [wx] Build fix for machines with both MSVC 2005 and 2008 installed. Ensures the
827         latest version is selected by default, and allows the version to be specified.
828
829         * wx/build/settings.py:
830
831 2010-07-07  Chris Fleizach  <cfleizach@apple.com>
832
833         Reviewed by Darin Adler.
834
835         AX: TextArea should return AXSelectedTextRange of 0,0 if the cursor is not in the text area
836         https://bugs.webkit.org/show_bug.cgi?id=41810
837
838         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
839         (AccessibilityUIElement::selectedTextRange):
840
841 2010-07-07  Martin Robinson  <mrobinson@igalia.com>
842
843         Unreviewed.
844
845         Build fix after r62700.
846
847         * GNUmakefile.am: Update the source list to reflect the new TestNetscapePlugIn
848         source file locations.
849
850 2010-07-07  Ojan Vafai  <ojan@chromium.org>
851
852         Reviewed by David Levin.
853
854         change --exit-after-n-crashes to --exit-after-n-crashes-or-timeouts
855         https://bugs.webkit.org/show_bug.cgi?id=41814
856
857         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
858         * Scripts/old-run-webkit-tests:
859
860 2010-07-07  Ojan Vafai  <ojan@chromium.org>
861
862         Reviewed by David Levin.
863
864         add --exit-after-n-crashes to run-webkit-tests
865         https://bugs.webkit.org/show_bug.cgi?id=41811
866
867         Change the bots at build.webkit.org to use --exit-after-n-crashes
868         instead of --exit-after-n-failures since we want to be able to have
869         more than 20 failures on those bots, but more than 20 crashes means
870         something should be rolled out.
871
872         * Scripts/old-run-webkit-tests:
873         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
874
875 2010-07-07  Brian Weinstein  <bweinstein@apple.com>
876
877         Fix the Windows build by removing win/TestNetscapePlugin/main.cpp from the
878         TestNetscapePlugin project, because this was removed from the tree.
879
880         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
881
882 2010-07-07  Anders Carlsson  <andersca@apple.com>
883
884         Reviewed by Simon Fraser.
885
886         Unify Mac and Windows TestNetscapePlugin main.cpp files
887         https://bugs.webkit.org/show_bug.cgi?id=41798
888         
889         * DumpRenderTree/DumpRenderTree.sln:
890         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
891         (strcasecmp):
892         (NP_Initialize):
893         (NP_GetEntryPoints):
894         (NP_Shutdown):
895         (NPP_New):
896         (NPP_Destroy):
897         (NPP_HandleEvent):
898         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
899         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Removed.
900
901 2010-07-07  Kevin Ollivier  <kevino@theolliviers.com>
902
903         [wx] Build fix. pageProperty needs to return a value.
904
905         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
906         (LayoutTestController::pageProperty):
907
908 2010-07-07  David Kilzer  <ddkilzer@apple.com>
909
910         <http://webkit.org/b/41788> commit-log-editor: wrong ChangeLog read when invoked from subdir with git
911
912         Reviewed by Anders Carlsson.
913
914         For both svn and git, commit-log-editor is invoked from the root
915         of the working directory.  Unlike svn, git returns a list of
916         changed files that are relative to the directory where the
917         command was invoked.  This caused the ChangeLog file in the root
918         directory to be read instead of the ChangeLog in the current
919         directory.
920
921         The fix is to use $ENV{PWD} as the base directory when fixing
922         the path to the ChangeLog files.  With svn, this has no net
923         effect since $ENV{PWD} is the root of the working directory and
924         the ChangeLog paths are already relative to that directory.
925         With git, $ENV{PWD} is the directory that the commit was invoked
926         from, which fixes the ChangeLog paths so that the correct files
927         are read when creating the commit log entry.
928
929         Note that the call to makeFilePathRelative() was supposed to
930         address this issue, but it doesn't because (a) it does nothing
931         with svn working directories by design, and (b) it does nothing
932         with git working directories because it's invoked when the
933         current directory is the root of the working directory, thus
934         giving no relative path.
935
936         * Scripts/commit-log-editor: Removed call to
937         makeFilePathRelative() since since it does nothing.  Moved code
938         to fix up $changeLog path so that it's fixed before trying to
939         open the file, and use $ENV{PWD} as the base path.  Also use
940         canonicalizePath() to clean up paths with "../" in them.
941
942 2010-07-07  Anders Carlsson  <andersca@apple.com>
943
944         Another attempt at fixing the Qt build.
945
946         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
947
948 2010-07-07  Anders Carlsson  <andersca@apple.com>
949
950         Try to fix Qt build.
951
952         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
953
954 2010-07-07  Anders Carlsson  <andersca@apple.com>
955
956         Reviewed by Simon Fraser.
957
958         Rename TestNetscapePlugin.subproj and move platform specific files to subdirectories
959         https://bugs.webkit.org/show_bug.cgi?id=41781
960
961         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
962         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp.
963         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h.
964         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp.
965         * DumpRenderTree/TestNetscapePlugIn/TestObject.h: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.h.
966         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/Info.plist.
967         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp.
968         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.def: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.def.
969         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc.
970         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added.
971         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin_debug.def: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin_debug.def.
972         * DumpRenderTree/TestNetscapePlugIn/win/resource.h: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/resource.h.
973         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed.
974
975 2010-07-07  Andras Becsi  <abecsi@webkit.org>
976
977         Unreviewed trivial fix.
978
979         Remove DUMPRENDERTREE_TEMP environment variable from NRWT
980         which was checked in accidentally in r62635.
981
982         * Scripts/webkitpy/layout_tests/port/webkit.py:
983
984 2010-07-07  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
985
986         Reviewed by Eric Seidel.
987
988         Pass port specific environment to server process.
989         https://bugs.webkit.org/show_bug.cgi?id=41593
990
991         * Scripts/webkitpy/layout_tests/port/qt.py:
992         * Scripts/webkitpy/layout_tests/port/webkit.py:
993
994 2010-07-06  Kent Tamura  <tkent@chromium.org>
995
996         Reviewed by Shinichiro Hamaji.
997
998         Fix a wrong dup detection of rebaseline-chromium-webkit-tests
999         https://bugs.webkit.org/show_bug.cgi?id=41644
1000
1001         rebaseline-chromium-webkit-tests used ImageDiff with 0.1%
1002         tolerance. We don't need tolerance for rebaseline.
1003
1004         * Scripts/webkitpy/layout_tests/port/base.py:
1005           Add optional tolerance parameter to diff_image().
1006         * Scripts/webkitpy/layout_tests/port/test.py:
1007           Add optional tolerance parameter to diff_image().
1008         * Scripts/webkitpy/layout_tests/port/webkit.py:
1009           Add optional tolerance parameter to diff_image(), and pass it to ImageDiff command.
1010         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1011           diff_files() always calls diff_image() with tolerance=0.
1012           diff_files() is used only by rebaseline-chromium-webkit-tests.
1013
1014 2010-07-06  Sam Weinig  <sam@webkit.org>
1015
1016         Fix MiniBrowser build.
1017
1018         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1019
1020 2010-07-06  Sam Weinig  <sam@webkit.org>
1021
1022         Reviewed by Anders Carlsson.
1023
1024         Add support for dumping the contents of messages to the console to WebKitTestRunner
1025
1026         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1027         (WTR::InjectedBundlePage::InjectedBundlePage):
1028         (WTR::InjectedBundlePage::_addMessageToConsole):
1029         (WTR::InjectedBundlePage::addMessageToConsole):
1030         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1031
1032 2010-07-06  Sam Weinig  <sam@webkit.org>
1033
1034         Reviewed by Anders Carlsson.
1035
1036         Patch for https://bugs.webkit.org/show_bug.cgi?id=41708
1037         Add dumpAsText support for WebKitTestRunner
1038
1039         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1040         (WTR::InjectedBundle::InjectedBundle):
1041         (WTR::InjectedBundle::reset): Reset the LayoutTestController for each test.
1042         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1043         (WTR::InjectedBundlePage::didFinishLoadForFrame): Use the new WKBundleFrameCopyInnerText
1044         API to dump the main frames text.
1045
1046 2010-07-06  Darin Adler  <darin@apple.com>
1047
1048         Fix Chromium build.
1049
1050         * DumpRenderTree/chromium/WebViewHost.cpp:
1051         (WebViewHost::didCreateDataSource): Call leakPtr instead of release.
1052         (WebViewHost::didNavigateWithinPage): Ditto.
1053         (WebViewHost::updateURL): Ditto.
1054
1055 2010-07-06  Martin Robinson  <mrobinson@igalia.com>
1056
1057         Reviewed by Xan Lopez.
1058
1059         [GTK] build-webkit should not run autogen.sh unconditionally
1060         https://bugs.webkit.org/show_bug.cgi?id=41704
1061
1062         * Scripts/webkitdirs.pm: Only run autogen.sh during a build if GNUmakefile
1063         doesn't exist. Autotools should re-run autogen.sh when necessary. Also do
1064         some very minor cleanup.
1065
1066 2010-07-06  Darin Adler  <darin@apple.com>
1067
1068         Try to fix Chromium build.
1069
1070         * DumpRenderTree/chromium/WebViewHost.cpp: Added include of PassOwnPtr.h.
1071
1072 2010-07-06  Darin Adler  <darin@apple.com>
1073
1074         Fix build.
1075
1076         * WebKitAPITest/TestsController.cpp:
1077         (WebKitAPITest::TestsController::addTest): Use leakPtr instead of release.
1078
1079 2010-07-06  Roland Steiner  <rolandsteiner@chromium.org>
1080
1081         Reviewed by Kent Tamura.
1082
1083         Bug 40558 - [DRT/Chromium] Upstream TestShellDevTools for Chromium DRT
1084         https://bugs.webkit.org/show_bug.cgi?id=40558
1085
1086         Upstream DevTools for Chromium DRT.
1087         (original Chromium files rev. 51287)
1088
1089         * DumpRenderTree/DumpRenderTree.gypi:
1090         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Added.
1091         (DRTDevToolsAgent::DRTDevToolsAgent):
1092         (DRTDevToolsAgent::setWebView):
1093         (DRTDevToolsAgent::sendMessageToFrontend):
1094         (DRTDevToolsAgent::forceRepaint):
1095         (DRTDevToolsAgent::runtimeFeatureStateChanged):
1096         (DRTDevToolsAgent::injectedScriptSource):
1097         (DRTDevToolsAgent::injectedScriptDispatcherSource):
1098         (DRTDevToolsAgent::debuggerScriptSource):
1099         (DRTDevToolsAgent::asyncCall):
1100         (DRTDevToolsAgent::call):
1101         (DRTDevToolsAgent::webDevToolsAgent):
1102         (DRTDevToolsAgent::attach):
1103         (DRTDevToolsAgent::detach):
1104         (DRTDevToolsAgent::setTimelineProfilingEnabled):
1105         (DRTDevToolsAgent::evaluateInWebInspector):
1106         (DRTDevToolsAgent::dispatchMessageLoop):
1107         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Added.
1108         (DRTDevToolsAgent::~DRTDevToolsAgent):
1109         (DRTDevToolsAgent::hostIdentifier):
1110         * DumpRenderTree/chromium/DRTDevToolsCallArgs.cpp:
1111         * DumpRenderTree/chromium/DRTDevToolsCallArgs.h:
1112         (DRTDevToolsCallArgs::DRTDevToolsCallArgs):
1113         (DRTDevToolsCallArgs::~DRTDevToolsCallArgs):
1114         (DRTDevToolsCallArgs::callsCount):
1115         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Added.
1116         (DRTDevToolsClient::DRTDevToolsClient):
1117         (DRTDevToolsClient::~DRTDevToolsClient):
1118         (DRTDevToolsClient::sendMessageToAgent):
1119         (DRTDevToolsClient::sendDebuggerCommandToAgent):
1120         (DRTDevToolsClient::activateWindow):
1121         (DRTDevToolsClient::closeWindow):
1122         (DRTDevToolsClient::dockWindow):
1123         (DRTDevToolsClient::undockWindow):
1124         (DRTDevToolsClient::asyncCall):
1125         (DRTDevToolsClient::call):
1126         (DRTDevToolsClient::allMessagesProcessed):
1127         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1128         * DumpRenderTree/chromium/EventSender.cpp:
1129         * DumpRenderTree/chromium/LayoutTestController.cpp:
1130         (LayoutTestController::LayoutTestController):
1131         (LayoutTestController::closeWebInspector):
1132         (LayoutTestController::setTimelineProfilingEnabled):
1133         (LayoutTestController::evaluateInWebInspector):
1134         * DumpRenderTree/chromium/LayoutTestController.h:
1135         * DumpRenderTree/chromium/TestShell.cpp:
1136         (TestShell::TestShell):
1137         (TestShell::~TestShell):
1138         (TestShell::createDRTDevToolsClient):
1139         (TestShell::showDevTools):
1140         (TestShell::closeDevTools):
1141         (TestShell::runFileTest):
1142         (TestShell::createNewWindow):
1143         * DumpRenderTree/chromium/TestShell.h:
1144         (TestShell::drtDevToolsAgent):
1145         (TestShell::drtDevToolsClient):
1146         * DumpRenderTree/chromium/config.h:
1147
1148 2010-07-06  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1149
1150         Reviewed by Eric Seidel.
1151
1152         Don't pass image hash to DRT when pixel tests are disabled.
1153         https://bugs.webkit.org/show_bug.cgi?id=41597
1154
1155         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1156
1157 2010-07-05  Csaba Osztrogonác  <ossy@webkit.org>
1158
1159         Reviewed by Eric Seidel.
1160
1161         REGRESSION(r60652): WebKitTools/Scripts/ensure-valid-python should cleanup temporary directory
1162         https://bugs.webkit.org/show_bug.cgi?id=41612
1163
1164         * Scripts/ensure-valid-python: File::Temp::tempdir call fixed.
1165
1166 2010-07-05  Adam Barth  <abarth@webkit.org>
1167
1168         Reviewed by Eric Seidel.
1169
1170         We should be able to specify a bug to block for webkit-patch upload
1171         https://bugs.webkit.org/show_bug.cgi?id=41648
1172
1173         This will be useful for working on the HTML5 parser.
1174
1175         * Scripts/webkitpy/tool/steps/createbug.py:
1176         * Scripts/webkitpy/tool/steps/options.py:
1177
1178 2010-07-05  Martin Robinson  <mrobinson@igalia.com>
1179
1180         Reviewed by Oliver Hunt.
1181
1182         The style checker exempts gtk2drawing.h when it should exempt gtkdrawing.h
1183         https://bugs.webkit.org/show_bug.cgi?id=41017
1184
1185         * Scripts/webkitpy/style/checker.py: Exempt gtkdrawing.h instead of gtk2drawing.h
1186         * Scripts/webkitpy/style/checker_unittest.py: Update the unit test to reflect the change.
1187
1188 2010-07-04  MORITA Hajime  <morrita@google.com>
1189
1190         rebaseline-chromium-webkit-tests: UnicodeDecodeError
1191         https://bugs.webkit.org/show_bug.cgi?id=41589
1192
1193         * run() method can result non-utf-8 bytes, that causes utf-8
1194           decoding fail.  Fixed to disable decoding.
1195         * Fixed Git.find_checkout_root() to make a test pass.
1196
1197         * Scripts/webkitpy/common/checkout/scm.py:
1198         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1199
1200 2010-07-03  Patrick Gansterer  <paroga@paroga.com>
1201
1202         Reviewed by Simon Hausmann.
1203
1204         [Qt] Fix DumpRenderTree userStyleSheet handling.
1205         https://bugs.webkit.org/show_bug.cgi?id=41570
1206
1207         DumpRenderTree did only set the userStyleSheet at
1208         layoutTestController.setUserStyleSheetEnabled().
1209
1210         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1211         (LayoutTestController::reset):
1212         (LayoutTestController::setUserStyleSheetLocation):
1213         (LayoutTestController::setUserStyleSheetEnabled):
1214         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1215
1216 2010-07-03  Robert Hogan  <robert@webkit.org>
1217
1218         Reviewed by Kenneth Rohde Christiansen.
1219
1220         [Qt] support dumpChildFrameScrollPositions
1221
1222         https://bugs.webkit.org/show_bug.cgi?id=41088
1223
1224         Unskip:
1225
1226         http/tests/navigation/anchor-subframeload.html
1227         http/tests/navigation/relativeanchor-frames.html
1228
1229         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1230         (WebCore::DumpRenderTree::dumpFrameScrollPosition):
1231         (WebCore::DumpRenderTree::dump):
1232         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1233         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1234         (LayoutTestController::reset):
1235         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1236         (LayoutTestController::shouldDumpChildFrameScrollPositions):
1237         (LayoutTestController::dumpChildFrameScrollPositions):
1238
1239 2010-07-02  Sam Weinig  <sam@webkit.org>
1240
1241         Reviewed by Anders Carlsson.
1242
1243         Rename new scripts so that they don't make autocompleting run-webkit-tests annoying.
1244
1245         * Scripts/debug-test-runner: Copied from Scripts/debug-webkittestrunner.
1246         * Scripts/debug-webkittestrunner: Removed.
1247         * Scripts/run-test-runner: Copied from Scripts/run-webkittestrunner.
1248         * Scripts/run-webkittestrunner: Removed.
1249
1250 2010-07-02  Brian Weinstein  <bweinstein@apple.com>
1251
1252         Reviewed by Steve Falkenburg.
1253
1254         Some http tests fail on Windows with Cygwin 1.7
1255         https://bugs.webkit.org/show_bug.cgi?id=41537
1256         
1257         With Cygwin 1.7, the registry key at SOFTWARE\\Cygnus Solutions\\Cygwin\\mounts v2\\/
1258         doesn't exist anymore, because the mount points are stored in /etc/fstab. However, we
1259         just need root mount point, which is defined in SOFTWARE\\Cygwin\\setup.
1260
1261         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1262         (resolveCygwinPath): Fall back to SOFTWARE\\Cygwin\\setup if 
1263             SOFTWARE\\Cygnus Solutions\\Cygwin\\mounts v2\\/ doesn't work.
1264
1265 2010-06-23  Martin Robinson  <mrobinson@igalia.com>
1266
1267         Reviewed by Gustavo Noronha Silva.
1268
1269         [GTK] Separate DerivedSources per-project
1270         https://bugs.webkit.org/show_bug.cgi?id=41109
1271
1272         The JavaScriptCore cppflags used to include the top-level DerivedSources directory
1273         allowing the tools to build as a side-effect. Now that the top-level directory
1274         is no longer in the list of JavaScriptCore includes, include it explicitly.
1275
1276         * GNUmakefile.am:
1277
1278 2010-07-01  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1279
1280         Reviewed by Kenneth Rohde Christiansen.
1281
1282         [Qt] Make context menus show up in the right place in QTestBrowser
1283
1284         Context menus were shown at scene-relative coordinates for
1285         QGraphicsWebView while QMenu expects them to be global. The
1286         change to the QWidget case was to get rid of the mapToGlobal.
1287
1288         * QtTestBrowser/webview.cpp:
1289
1290 2010-07-01  Robert Hogan <robert@webkit.org>
1291
1292         Reviewed by Kenneth Rohde Christiansen.
1293
1294         [Qt] dump frames in ascending alphabetical order of title
1295
1296         https://bugs.webkit.org/show_bug.cgi?id=41261
1297
1298         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1299         (WebCore::dumpHistoryItem):
1300
1301 2010-07-01  Martin Robinson  <mrobinson@igalia.com>
1302
1303         Unreviewed. 
1304
1305         Fix the GTK+ build after r62278.
1306
1307         * Scripts/webkitdirs.pm: If the make arguments have already been specified,
1308         let them override the automatic CPU detection for autotools builds.
1309
1310 2010-07-01  Martin Robinson  <mrobinson@igalia.com>
1311
1312         Unreviewed.
1313
1314         Fix the Windows build after r62278.
1315
1316         * Scripts/num-cpus: Use FindBin to add the Scripts directory to the list of library directories.
1317
1318 2010-07-01  Martin Robinson  <mrobinson@igalia.com>
1319
1320         Reviewed by Gustavo Noronha Silva.
1321
1322         [GTK] build-webkit does not detect the number of CPUs
1323         https://bugs.webkit.org/show_bug.cgi?id=41469
1324
1325         Pass the appropriate -j<#> flag to make when building autotools builds.
1326         This causes make to spawn that many number of child processes for doing
1327         parallel builds.
1328
1329         * Scripts/num-cpus: Use the newly abstracted numberOfCPUs to return the number
1330         of CPUs. This makes the script work across more platforms.
1331         * Scripts/webkitdirs.pm: Create a numberOfCPUs/determineNumberOfCPUs to determine the
1332         number of CPUs across several platforms. Use this new function to determine the appropriate
1333         arguments to pass to make for doing parallel builds with autotools build files.
1334
1335 2010-07-01  Simon Hausmann  <simon.hausmann@nokia.com>
1336
1337         Rubber-stamped by Laszlo Gombos.
1338
1339         [Qt][Symbian] Bumped up the maximum heap size to 96MB
1340
1341         * QtTestBrowser/QtTestBrowser.pro: Removed explicit heap size declaration
1342         and use the one from WebKit.pri instead.
1343
1344 2010-07-01  Adam Barth  <abarth@webkit.org>
1345
1346         Reviewed by Eric Seidel.
1347
1348         Promote webkit-patch land-safely to main help
1349         https://bugs.webkit.org/show_bug.cgi?id=41446
1350
1351         I've been using this command a bunch and recommending it to folks.  We
1352         should show it in main help as it's past the experimental phase.
1353
1354         * Scripts/webkitpy/tool/commands/upload.py:
1355
1356 2010-06-28  MORITA Hajime  <morrita@google.com>
1357
1358         Reviewed by Shinichiro Hamaji.
1359
1360         rebaseline-chromium-webkit-tests doesn't do diffs right with a Git checkout of WebKit
1361         https://bugs.webkit.org/show_bug.cgi?id=38775
1362
1363         - Introduced SCM.show_head() and SCM.diff_for_file().
1364         - Replaced direct svn invocations with newly implement SCM methods.
1365
1366         * Scripts/webkitpy/common/checkout/scm.py:
1367         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1368         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1369
1370 2010-06-30  Simon Fraser  <simon.fraser@apple.com>
1371
1372         Reviewed by Sam Weinig.
1373
1374         Allow MiniBrowser to open local files
1375         https://bugs.webkit.org/show_bug.cgi?id=41104
1376
1377         Wire up the openDocument: message with an NSOpenPanel, so we can open
1378         local files.
1379         
1380         Also change the xib so that the window remembers its size.
1381         
1382         * MiniBrowser/mac/AppDelegate.m:
1383         (-[BrowserAppDelegate frontmostBrowserWindowController]):
1384         (-[BrowserAppDelegate openDocument:]):
1385         (-[BrowserAppDelegate openPanelDidEnd:returnCode:contextInfo:]):
1386         * MiniBrowser/mac/English.lproj/BrowserWindow.xib:
1387
1388 2010-06-30  Sam Weinig  <sam@webkit.org>
1389
1390         Rubber-stamped by Anders Carlsson.
1391
1392         Add debug-webkittestrunner and cleanup related scripts.
1393
1394         * Scripts/debug-webkittestrunner: Added.
1395         * Scripts/run-webkittestrunner:
1396         * Scripts/webkitdirs.pm:
1397
1398 2010-06-30  Kevin Ollivier  <kevino@theolliviers.com>
1399
1400         [wx] Build fix after recent changes to LayoutTestController.
1401
1402         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1403         (LayoutTestController::pageSizeAndMarginsInPixels):
1404
1405 2010-06-29  Sam Weinig  <sam@webkit.org>
1406
1407         Reviewed by Anders Carlsson.
1408
1409         Patch for https://bugs.webkit.org/show_bug.cgi?id=41389
1410         Make WebKitTestRunner work with more than one test at a time.
1411
1412         This converts WebKitTestRunner to a similar model as DumpRenderTree,
1413         where there is a single WKView and each test is run it, rather than
1414         the design I was using where each test got its own WKView.
1415
1416         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1417         (WTR::InjectedBundle::didRecieveMessage):
1418         (WTR::InjectedBundle::reset):
1419         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1420         * WebKitTestRunner/TestController.cpp:
1421         (WTR::TestController::initialize):
1422         (WTR::TestController::runTest):
1423         (WTR::TestController::_didRecieveMessageFromInjectedBundle):
1424         (WTR::TestController::didRecieveMessageFromInjectedBundle):
1425         * WebKitTestRunner/TestController.h:
1426         (WTR::TestController::mainWebView):
1427         (WTR::TestController::pageNamespace):
1428         (WTR::TestController::context):
1429         * WebKitTestRunner/TestInvocation.cpp:
1430         (WTR::TestInvocation::TestInvocation):
1431         (WTR::TestInvocation::~TestInvocation):
1432         (WTR::TestInvocation::invoke):
1433         (WTR::TestInvocation::didRecieveMessageFromInjectedBundle):
1434         * WebKitTestRunner/TestInvocation.h:
1435
1436 2010-06-30  Simon Hausmann  <simon.hausmann@nokia.com>
1437
1438         Reviewed by Laszlo Gombos.
1439
1440         [Qt][Symbian] Only 10 websites can be loaded consecutively when using QtWebkit 2.0
1441         https://bugs.webkit.org/show_bug.cgi?id=40446
1442
1443         We quickly run out of memory on Symbian when loading web pages. This is
1444         caused by the default heap size, which is not suited for a web browser.
1445
1446         This change bumps the max heap size to 32MB.
1447
1448         * QtTestBrowser/QtTestBrowser.pro:
1449
1450 2010-06-30  Eric Seidel  <eric@webkit.org>
1451
1452         Reviewed by Adam Barth.
1453
1454         webkit-patch land allow the user to continue even if the builders are red
1455         https://bugs.webkit.org/show_bug.cgi?id=41395
1456
1457         I don't think it's good that we've been teaching people
1458         to always pass --ignore-builders.  At least land is now
1459         useable w/o --ignore-builders.
1460
1461         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
1462
1463 2010-06-29  Robert Hogan  <robert@webkit.org>
1464
1465         Reviewed by Kenneth Rohde Christiansen.
1466
1467         [Qt] support dumpResourceResponseMIMETypes
1468         https://bugs.webkit.org/show_bug.cgi?id=41260
1469
1470         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1471         (LayoutTestController::reset):
1472         (LayoutTestController::dumpResourceResponseMIMETypes):
1473         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1474
1475 2010-06-29  Diego Gonzalez  <diegohcg@webkit.org>
1476
1477         Reviewed by Kenneth Rohde Christiansen.
1478
1479         [Qt] Resize scene when Qt DRT WebPage receives a geometry change request
1480         https://bugs.webkit.org/show_bug.cgi?id=41173
1481
1482         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1483         (WebCore::WebPage::setViewGeometry):
1484         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1485
1486 2010-06-29  Diego Gonzalez  <diegohcg@webkit.org>
1487
1488         Reviewed by Simon Hausmann.
1489
1490         [Qt] Deal with postEvent in case of graphics based DRT
1491         https://bugs.webkit.org/show_bug.cgi?id=41174
1492
1493         QGraphicsScene does not have a postEvent method, so make scene
1494         send the event, in case of graphics based DRT, and delete it after that.
1495
1496         * DumpRenderTree/qt/EventSenderQt.cpp:
1497         (EventSender::scheduleAsynchronousClick):
1498         (EventSender::replaySavedEvents):
1499         (EventSender::postEvent):
1500         * DumpRenderTree/qt/EventSenderQt.h:
1501
1502 2010-06-29  Diego Gonzalez  <diegohcg@webkit.org>
1503
1504         Reviewed by Kenneth Rohde Christiansen.
1505
1506         [Qt] Make switchFocus() method works with QGraphicsWebView in Qt DRT
1507         https://bugs.webkit.org/show_bug.cgi?id=41172
1508
1509         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1510         (WebCore::DumpRenderTree::switchFocus):
1511
1512 2010-06-29  Mario Sanchez Prada  <msanchez@igalia.com>
1513
1514         Reviewed by Xan Lopez.
1515
1516         [Gtk] Make DRT more coherent with other ports to allow reusing more tests
1517         https://bugs.webkit.org/show_bug.cgi?id=40009
1518
1519         Make sure "AXRole: ", "AXTitle: " and "AXDescription: " prefixes
1520         are used when returning those values, for coherency with other ports.
1521
1522         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1523         (AccessibilityUIElement::role):
1524         (AccessibilityUIElement::title):
1525         (AccessibilityUIElement::description):
1526
1527 2010-06-29  Sheriff Bot  <webkit.review.bot@gmail.com>
1528
1529         Unreviewed, rolling out r62106.
1530         http://trac.webkit.org/changeset/62106
1531         https://bugs.webkit.org/show_bug.cgi?id=41346
1532
1533         "Broke editing tests" (Requested by xan_ on #webkit).
1534
1535         * Scripts/old-run-webkit-tests:
1536
1537 2010-06-29  Mario Sanchez Prada  <msanchez@igalia.com>
1538
1539         Reviewed by Xan Lopez.
1540
1541         Ensure DRT loads GAIL (Gtk+ module), for a11y tests
1542         https://bugs.webkit.org/show_bug.cgi?id=38648
1543
1544         Add the GTK_MODULES envvar (set to "gail") to the clean
1545         environment when running DRT for the Gtk+ port
1546
1547         * Scripts/old-run-webkit-tests:
1548
1549 2010-06-28  Adam Barth  <abarth@webkit.org>
1550
1551         Unreviewed.
1552
1553         Switch test-html5-parser back to using runner.html.
1554
1555         * Scripts/test-html5-parser:
1556
1557 2010-06-28  Adam Barth  <abarth@webkit.org>
1558
1559         Reviewed by Eric Seidel.
1560
1561         Restore webkit-runner.html for use with new tree builder
1562         https://bugs.webkit.org/show_bug.cgi?id=41317
1563
1564         For now, we just want to run webkit-runner when we test-html5-parser.
1565
1566         * Scripts/test-html5-parser:
1567
1568 2010-06-23  John Gregg  <johnnyg@google.com>
1569
1570         Reviewed by Kent Tamura.
1571
1572         add ENABLE_DIRECTORY_UPLOAD build support
1573         https://bugs.webkit.org/show_bug.cgi?id=41100
1574
1575         * Scripts/build-webkit:
1576
1577 2010-06-28  Gustavo Noronha Silva  <gns@gnome.org>
1578
1579         Rubber-stamped by Xan Lopez.
1580
1581         Update webkitdirs's knowledge of our library's name.
1582
1583         * Scripts/webkitdirs.pm:
1584
1585 2010-06-28  Sam Weinig  <sam@webkit.org>
1586
1587         Reviewed by Anders Carlsson.
1588
1589         Patch for https://bugs.webkit.org/show_bug.cgi?id=41299
1590         Build up WebKitTestRunner output in the InjectedBundle
1591
1592         Simplify WebKitTestRunner by building up the output in the InjectedBundle
1593         and sending it over postMessage when done, instead of using the async
1594         WKPageRenderTreeExternalRepresentation.
1595
1596         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1597         (WTR::InjectedBundle::done):
1598         (WTR::InjectedBundle::didRecieveMessage):
1599         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1600         (WTR::InjectedBundle::os):
1601         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1602         (WTR::WKStringToUTF8):
1603         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1604         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1605         * WebKitTestRunner/TestInvocation.cpp:
1606         (WTR::WKStringToUTF8):
1607         (WTR::TestInvocation::TestInvocation):
1608         (WTR::TestInvocation::invoke):
1609         (WTR::TestInvocation::initializeMainWebView):
1610         (WTR::TestInvocation::_didRecieveMessageFromInjectedBundle):
1611         (WTR::TestInvocation::didRecieveMessageFromInjectedBundle):
1612         * WebKitTestRunner/TestInvocation.h:
1613
1614 2010-06-28  Robert Hogan  <robert@webkit.org>
1615
1616         Unreviewed, rolling out r62021.
1617         http://trac.webkit.org/changeset/62021
1618         https://bugs.webkit.org/show_bug.cgi?id=41261
1619
1620         Broke http/navigation tests among other
1621
1622         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1623         (WebCore::DumpRenderTree::dumpFramesAsText):
1624
1625 2010-06-28  Sam Weinig  <sam@webkit.org>
1626
1627         Reviewed by Anders Carlsson.
1628
1629         Add run-webkittestrunner to run WebKitTestRunner with the appropriate
1630         environment.
1631
1632         * Scripts/run-webkittestrunner: Added.
1633         * Scripts/webkitdirs.pm:
1634
1635 2010-06-28  Robert Hogan  <robert@webkit.org>
1636
1637         Reviewed by Kenneth Rohde Christiansen.
1638
1639         [Qt] dump frames in ascending alphabetical order of title
1640
1641         https://bugs.webkit.org/show_bug.cgi?id=41261
1642
1643         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1644         (WebCore::DumpRenderTree::dumpFramesAsText):
1645
1646 2010-06-28  Robert Hogan  <robert@webkit.org>
1647
1648         Reviewed by Kenneth Rohde Christiansen.
1649
1650         [Qt] dump bf history of child windows
1651
1652         https://bugs.webkit.org/show_bug.cgi?id=41266
1653
1654         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1655         (WebCore::DumpRenderTree::dumpBackForwardList):
1656         (WebCore::DumpRenderTree::dump):
1657         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1658
1659 2010-06-28  Sam Weinig  <sam@webkit.org>
1660
1661         Reviewed by Anders Carlsson.
1662
1663         Patch for https://bugs.webkit.org/show_bug.cgi?id=41288
1664         WebKit2: Add frame API for InjectedBundle code
1665
1666         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1667         (_didClearWindowForFrame):
1668
1669 2010-06-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1670
1671         Reviewed by Kenneth Rohde Christiansen.
1672
1673         [Qt] QtTestBrowser does not have a "Load" button ; therefore, unable to load pages on touch only symbian devices (portrait mode).
1674         https://bugs.webkit.org/show_bug.cgi?id=38597
1675
1676         Fix behavior so reload button really acts as a load and a reload button.
1677
1678         * QtTestBrowser/mainwindow.cpp:
1679         (MainWindow::changeLocation):
1680
1681 2010-06-28  Xan Lopez  <xlopez@igalia.com>
1682
1683         Reviewed by Gustavo Noronha.
1684
1685         [GTK] Does not compile with -DGSEAL_ENABLE
1686         https://bugs.webkit.org/show_bug.cgi?id=37851
1687
1688         Fix build with GSEAL enabled.
1689
1690         * DumpRenderTree/gtk/EventSender.cpp:
1691         (gtk_widget_get_window):
1692         (prepareMouseButtonEvent):
1693         (mouseMoveToCallback):
1694         (mouseWheelToCallback):
1695         (keyDownCallback):
1696
1697 2010-06-28  Xan Lopez  <xlopez@igalia.com>
1698
1699         Reviewed by Gustavo Noronha.
1700
1701         [GTK] Add support for GTK+3
1702         https://bugs.webkit.org/show_bug.cgi?id=41253
1703
1704         Adapt build system for 3.x support.
1705
1706         * GNUmakefile.am:
1707
1708 2010-06-10  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1709
1710         Reviewed by Simon Hausmann.
1711
1712         [QT][S60] build-webkit scripts picks wrong make spec for windows build
1713         https://bugs.webkit.org/show_bug.cgi?id=41198
1714
1715         Instead of checking for existence of %EPOCROOT% on windows, mandatory use of --symbian flag for symbian builds. 
1716
1717         * Scripts/webkitdirs.pm:
1718         (determineIsSymbian): remove check for %EPOCROOT% as one can build for windows port of QT as well
1719
1720 2010-06-28  Eric Seidel  <eric@webkit.org>
1721
1722         Reviewed by Adam Barth.
1723
1724         Make it possible to test the new HTML5 TreeBuilder
1725         https://bugs.webkit.org/show_bug.cgi?id=41276
1726
1727         Adam was concerned that someone might make their port
1728         depend on this setting (I guess we had some trouble with that
1729         with the HTML5Parser setting), so I littered the code with warnings.
1730
1731         test-html5-parser now tests this code path.
1732
1733         * DumpRenderTree/mac/DumpRenderTree.mm:
1734         (resetDefaultsToConsistentValues):
1735         (initializeGlobalsFromCommandLineOptions):
1736         * Scripts/test-html5-parser:
1737
1738 2010-06-27  MORITA Hajime  <morrita@google.com>
1739
1740         Unreviewed. 
1741         
1742         Some never-called @staticmethods touched self. 
1743         Fixed it to replace these self with a class.
1744
1745         * Scripts/webkitpy/common/checkout/scm.py:
1746
1747 2010-06-27  MORITA Hajime  <morrita@google.com>
1748
1749         Unreviewed.
1750         
1751         Fixed exception raising syntax that is pointed out at
1752         https://bugs.webkit.org/show_bug.cgi?id=41153
1753
1754         * Scripts/webkitpy/common/checkout/scm.py:
1755         * Scripts/webkitpy/common/checkout/scm_unittest.py: 
1756           Removed a bad line that I accidentally checked-in at last revision.
1757
1758 2010-06-24  MORITA Hajime  <morrita@google.com>
1759
1760         Reviewed by Eric Seidel.
1761
1762         rebaseline-chromium-webkit-tests should add or remove files to local git repository
1763         https://bugs.webkit.org/show_bug.cgi?id=41153
1764
1765         - Added SCM.add() and SCM.remove()
1766         - Replaced "svn add" and "svn remove"
1767           rebaseline_chromium_webkit_tests.py: in with SCM method equivalents.
1768         - add "-U" and "-q" options to rebaseline_chromium_webkit_tests.py
1769           for debugging purpose.
1770
1771         * Scripts/webkitpy/common/checkout/scm.py:
1772         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1773         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1774
1775 2010-06-25  Yuzo Fujishima  <yuzo@google.com>
1776
1777         Reviewed by Shinichiro Hamaji.
1778
1779         Improve default value handling for page format properties.
1780         https://bugs.webkit.org/show_bug.cgi?id=41150
1781
1782         * DumpRenderTree/LayoutTestController.cpp:
1783         (parsePageNumber):
1784         (parsePageNumberSizeMarings):
1785         (pageSizeAndMarginsInPixelsCallback):
1786         (LayoutTestController::staticFunctions):
1787         * DumpRenderTree/LayoutTestController.h:
1788         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1789         (LayoutTestController::pageSizeAndMarginsInPixels):
1790         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1791         (LayoutTestController::pageSizeAndMarginsInPixels):
1792         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1793         (LayoutTestController::pageSizeAndMarginsInPixels):
1794
1795 2010-06-21  Robert Hogan  <robert@webkit.org>
1796
1797         Reviewed by Kenneth Rohde Christiansen.
1798
1799         [Qt] DRT Support for setCustomPolicyDelegate
1800
1801         https://bugs.webkit.org/show_bug.cgi?id=39564
1802
1803         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1804         (LayoutTestController::setCustomPolicyDelegate):
1805         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1806
1807 2010-06-26  Robert Hogan  <robert@webkit.org>
1808
1809         Unreviewed, Qt build fix following http://trac.webkit.org/changeset/61879
1810         
1811         Remove qwebscriptworld.h from LayoutTestControllerQt.cpp - it is no longer
1812         exported.
1813
1814         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1815
1816 2010-06-26  Tony Gentilcore  <tonyg@chromium.org>
1817
1818         Reviewed by Dimitri Glazkov.
1819
1820         Add a build-webkit option for enabling Web Timing support.
1821         https://bugs.webkit.org/show_bug.cgi?id=38924
1822
1823         * Scripts/build-webkit:
1824
1825 2010-06-25  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1826
1827         Reviewed by Kenneth Rohde Christiansen.
1828
1829         [Qt] QtTestBrowser does not have a "Load" button ; therefore, unable to load pages on touch only symbian devices (portrait mode).
1830         https://bugs.webkit.org/show_bug.cgi?id=38597
1831
1832         Make the reload button act as a load button as well.
1833
1834         * QtTestBrowser/mainwindow.cpp:
1835         (MainWindow::buildUI):
1836         (MainWindow::changeLocation):
1837
1838 2010-06-25  Prasad Tammana  <prasadt@chromium.org>
1839
1840         Reviewed by Dmitry Titov.
1841
1842         Add empty abortModal() method to all platforms.
1843         https://bugs.webkit.org/show_bug.cgi?id=40864
1844
1845         Add an empty abortModal() stub to LayoutTestController on all platforms to get rid of platform specific #ifs in
1846         platform independent LayoutTestController code.  Without this change, layout tests using LayoutTestController tests
1847         that use abortModal will become mac specific which is not desirable.
1848
1849         * DumpRenderTree/LayoutTestController.cpp:
1850         (abortModalCallback):
1851         (LayoutTestController::staticFunctions):
1852         * DumpRenderTree/LayoutTestController.h:
1853         * DumpRenderTree/chromium/LayoutTestController.cpp:
1854         (LayoutTestController::LayoutTestController):
1855         (LayoutTestController::abortModal):
1856         * DumpRenderTree/chromium/LayoutTestController.h:
1857         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1858         (LayoutTestController::abortModal):
1859         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1860         (LayoutTestController::abortModal):
1861         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1862         (LayoutTestController::abortModal):
1863         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1864         (LayoutTestController::abortModal):
1865
1866 2010-06-25  Sam Weinig  <sam@webkit.org>
1867
1868         Reviewed by Anders Carlsson.
1869
1870         Patch for https://bugs.webkit.org/show_bug.cgi?id=41226
1871         Flesh out injected bundle code for WebKitTestRunner and add basic LayoutTestController.
1872
1873         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Added.
1874         (WTR::InjectedBundle::shared):
1875         (WTR::InjectedBundle::InjectedBundle):
1876         (WTR::InjectedBundle::_didCreatePage):
1877         (WTR::InjectedBundle::_willDestroyPage):
1878         (WTR::InjectedBundle::_didRecieveMessage):
1879         (WTR::InjectedBundle::initialize):
1880         (WTR::InjectedBundle::didCreatePage):
1881         (WTR::InjectedBundle::willDestroyPage):
1882         (WTR::InjectedBundle::didRecieveMessage):
1883         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Added.
1884         (WTR::InjectedBundle::layoutTestController):
1885         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
1886         (WKBundleInitialize):
1887         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Added.
1888         (WTR::InjectedBundlePage::InjectedBundlePage):
1889         (WTR::InjectedBundlePage::~InjectedBundlePage):
1890         (WTR::InjectedBundlePage::_didStartProvisionalLoadForFrame):
1891         (WTR::InjectedBundlePage::_didReceiveServerRedirectForProvisionalLoadForFrame):
1892         (WTR::InjectedBundlePage::_didFailProvisionalLoadWithErrorForFrame):
1893         (WTR::InjectedBundlePage::_didCommitLoadForFrame):
1894         (WTR::InjectedBundlePage::_didFinishLoadForFrame):
1895         (WTR::InjectedBundlePage::_didFailLoadWithErrorForFrame):
1896         (WTR::InjectedBundlePage::_didReceiveTitleForFrame):
1897         (WTR::InjectedBundlePage::_didClearWindowForFrame):
1898         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1899         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
1900         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
1901         (WTR::InjectedBundlePage::didCommitLoadForFrame):
1902         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1903         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1904         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
1905         (WTR::InjectedBundlePage::didClearWindowForFrame):
1906         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added.
1907         (WTR::InjectedBundlePage::page):
1908         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Added.
1909         (WTR::LayoutTestController::create):
1910         (WTR::LayoutTestController::LayoutTestController):
1911         (WTR::LayoutTestController::~LayoutTestController):
1912         (WTR::dumpAsTextCallback):
1913         (WTR::layoutTestControllerObjectFinalize):
1914         (WTR::LayoutTestController::makeWindowObject):
1915         (WTR::LayoutTestController::getJSClass):
1916         (WTR::LayoutTestController::staticFunctions):
1917         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added.
1918         (WTR::LayoutTestController::dumpAsText):
1919         (WTR::LayoutTestController::setDumpAsText):
1920         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1921
1922 2010-06-25  Sam Weinig  <sam@webkit.org>
1923
1924         Reviewed by Anders Carlsson.
1925
1926         Make WebKitTestRunner really work with run-webkit-tests. 
1927
1928         - Add Forwarding headers to allow some cleanup.
1929
1930         * WebKitTestRunner/ForwardingHeaders: Added.
1931         * WebKitTestRunner/ForwardingHeaders/wtf: Added.
1932         * WebKitTestRunner/ForwardingHeaders/wtf/ASCIICType.h: Added.
1933         * WebKitTestRunner/ForwardingHeaders/wtf/Assertions.h: Added.
1934         * WebKitTestRunner/ForwardingHeaders/wtf/Atomics.h: Added.
1935         * WebKitTestRunner/ForwardingHeaders/wtf/FastMalloc.h: Added.
1936         * WebKitTestRunner/ForwardingHeaders/wtf/HashMap.h: Added.
1937         * WebKitTestRunner/ForwardingHeaders/wtf/HashSet.h: Added.
1938         * WebKitTestRunner/ForwardingHeaders/wtf/HashTraits.h: Added.
1939         * WebKitTestRunner/ForwardingHeaders/wtf/Locker.h: Added.
1940         * WebKitTestRunner/ForwardingHeaders/wtf/MainThread.h: Added.
1941         * WebKitTestRunner/ForwardingHeaders/wtf/MathExtras.h: Added.
1942         * WebKitTestRunner/ForwardingHeaders/wtf/Noncopyable.h: Added.
1943         * WebKitTestRunner/ForwardingHeaders/wtf/OwnPtr.h: Added.
1944         * WebKitTestRunner/ForwardingHeaders/wtf/OwnPtrCommon.h: Added.
1945         * WebKitTestRunner/ForwardingHeaders/wtf/PassOwnPtr.h: Added.
1946         * WebKitTestRunner/ForwardingHeaders/wtf/PassRefPtr.h: Added.
1947         * WebKitTestRunner/ForwardingHeaders/wtf/Platform.h: Added.
1948         * WebKitTestRunner/ForwardingHeaders/wtf/RefCounted.h: Added.
1949         * WebKitTestRunner/ForwardingHeaders/wtf/RefPtr.h: Added.
1950         * WebKitTestRunner/ForwardingHeaders/wtf/RetainPtr.h: Added.
1951         * WebKitTestRunner/ForwardingHeaders/wtf/StringExtras.h: Added.
1952         * WebKitTestRunner/ForwardingHeaders/wtf/ThreadSafeShared.h: Added.
1953         * WebKitTestRunner/ForwardingHeaders/wtf/Threading.h: Added.
1954         * WebKitTestRunner/ForwardingHeaders/wtf/ThreadingPrimitives.h: Added.
1955         * WebKitTestRunner/ForwardingHeaders/wtf/Vector.h: Added.
1956         * WebKitTestRunner/TestInvocation.cpp:
1957         (WTR::TestInvocation::dump): Dump the right number of #EOFs.
1958         * WebKitTestRunner/TestInvocation.h:
1959
1960 2010-06-25  Sam Weinig  <sam@webkit.org>
1961
1962         Reviewed by Mark Rowe.
1963
1964         Add support for WebKitTestRunner to old-run-webkit-tests
1965
1966         - Also adds a script to build WebKitTestRunner for old-run-webkit-tests to use.
1967
1968         * Scripts/build-webkittestrunner: Added.
1969         * Scripts/old-run-webkit-tests:
1970
1971 2010-06-25  Adam Barth  <abarth@webkit.org>
1972
1973         Reviewed by David Levin.
1974
1975         Incremental build failed on Chromium ews
1976         https://bugs.webkit.org/show_bug.cgi?id=41011
1977
1978         The division of responsibility between update-webkit --chromium and
1979         build-webkit --chromium is slightly unclear.  In this patch, we make
1980         build-webkit --chromium also update DEPS and re-run GYP in case the
1981         developer has changed either since they updated.
1982
1983         This change is also helpful for the EWS, which wants to update DEPS and
1984         re-run GYP after applying patches, but the EWS doesn't want to run
1985         update-webkit --chromium because it has a dirty working copy.
1986
1987         * Scripts/webkitdirs.pm:
1988
1989 2010-06-25  Robert Hogan  <robert@webkit.org>
1990
1991         Reviewed by Simon Hausmann.
1992
1993         [Qt] Support evaluateScriptInIsolatedWorld()
1994
1995         https://bugs.webkit.org/show_bug.cgi?id=40079
1996
1997         Remove evaluateScriptInIsolatedWorld() from QtWebKit API.
1998         Remove QWebScriptWorld from exported headers.
1999         Confine support to DumpRenderTreeSupportQt so that the tests can pass.
2000
2001         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2002         (LayoutTestController::reset):
2003         (LayoutTestController::evaluateScriptInIsolatedWorld):
2004         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2005
2006 2010-06-25  Anders Carlsson  <andersca@apple.com>
2007
2008         Revert accidental part and add a newline.
2009
2010         * MiniBrowser/mac/AppDelegate.m:
2011         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2012
2013 2010-06-25  Anders Carlsson  <andersca@apple.com>
2014
2015         Rubber-stamped by Dan Bernstein.
2016
2017         Add a LOG macro that expands to a no-op by default.
2018
2019         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2020         * MiniBrowser/mac/AppDelegate.m:
2021         (_didRecieveMessageFromInjectedBundle):
2022         * MiniBrowser/mac/BrowserWindowController.m:
2023         (-[BrowserWindowController windowShouldClose:]):
2024         (_didStartProvisionalLoadForFrame):
2025         (_didReceiveServerRedirectForProvisionalLoadForFrame):
2026         (_didFailProvisionalLoadWithErrorForFrame):
2027         (_didCommitLoadForFrame):
2028         (_didFinishLoadForFrame):
2029         (_didFailLoadWithErrorForFrame):
2030         (_didReceiveTitleForFrame):
2031         (_didFirstLayoutForFrame):
2032         (_didFirstVisuallyNonEmptyLayoutForFrame):
2033         (_didBecomeUnresponsive):
2034         (_didBecomeResponsive):
2035         (_decidePolicyForNavigationAction):
2036         (_decidePolicyForNewWindowAction):
2037         (_createNewPage):
2038         (_showPage):
2039         (_closePage):
2040         (_didNavigateWithNavigationData):
2041         (_didPerformClientRedirect):
2042         (_didPerformServerRedirect):
2043         (_didUpdateHistoryTitle):
2044         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2045         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2046         (_didClearWindowForFrame):
2047         (_didCreatePage):
2048         (_willDestroyPage):
2049         (_didRecieveMessage):
2050
2051 2010-06-24  Adam Barth  <abarth@webkit.org>
2052
2053         Reviewed by Eric Seidel.
2054
2055         commit-queue is taking too long to land patches because of red trees
2056         https://bugs.webkit.org/show_bug.cgi?id=41194
2057
2058         Instead of checking for the tree to be green, we'll just spin hot
2059         trying to land patches.  This is probably too extreme in ignoring the
2060         tree, but I think we should try it for a while to see if we have
2061         trouble.  That will help us find the right balance.
2062
2063         * Scripts/webkitpy/tool/commands/queues.py:
2064         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2065
2066 2010-06-24  Martin Robinson  <mrobinson@igalia.com>
2067
2068         Reviewed by Xan Lopez.
2069
2070         [GTK] Clean up the use of gdk_window_get_root_coords in EventSender
2071         https://bugs.webkit.org/show_bug.cgi?id=40843
2072
2073         Define the version for old GTK+s in a way that is forward-compatible
2074         and clean up the logic a bit.
2075
2076         * DumpRenderTree/gtk/EventSender.cpp:
2077         (gdk_window_get_root_coords): Renamed and cleaned up.
2078         (prepareMouseButtonEvent): Remove #ifdefs.
2079         (mouseMoveToCallback): Remove #ifdefs.
2080
2081 2010-06-24  Dimitri Glazkov  <dglazkov@chromium.org>
2082
2083         Reviewed by Eric Seidel.
2084
2085         Fix NewRunWebKitTests to work on Windows.
2086         https://bugs.webkit.org/show_bug.cgi?id=41180
2087
2088         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added "perl" as first arguments,
2089             because Windows fails to understand what we're asking of it.
2090
2091 2010-06-24  Martin Robinson  <mrobinson@igalia.com>
2092
2093         Reviewed by Xan Lopez.
2094
2095         [GTK] The url passed to the WebView during layout tests is invalid
2096         https://bugs.webkit.org/show_bug.cgi?id=40832
2097
2098         Set the test URL to the full real file URL and do a small cleanup.
2099         Previously a URL like file://relative/path/to/test.html was passed
2100         to the WebView. This malformed file URL would be returned by
2101         webkit_web_view_get_url and webkit_web_frame_get_url.
2102
2103         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2104         (shouldLogFrameLoadDelegates): Change to take a const string& as the argument.
2105         (shouldOpenWebInspector): Change to take a const string& as the argument.
2106         (shouldEnableDeveloperExtras): Change to take a const string& as the argument.
2107         (runTest): Pass the full file:// URL to the view. Remove the superfluous url variable.
2108
2109 2010-06-24  Sam Weinig  <sam@webkit.org>
2110
2111         Reviewed by Anders Carlsson.
2112
2113         Fix WebKitTestRunner Makefile typos.
2114
2115         * WebKitTestRunner/Makefile:
2116
2117 2010-06-24  Adele Peterson  <adele@apple.com>
2118
2119         Reviewed by Eric Carlson.
2120
2121         DumpRenderTree part of testing <rdar://problem/8093680> "Paste and Match Style" should fire paste events
2122         https://bugs.webkit.org/show_bug.cgi?id=41085
2123
2124         * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
2125         Clear the general pasteboard in between tests so Cut,Copy, and setData on ClipboardData won't have lasting effects.
2126
2127 2010-06-23  Sam Weinig  <sam@webkit.org>
2128
2129         Reviewed by Anders Carlsson.
2130
2131         Patch for https://bugs.webkit.org/show_bug.cgi?id=41086
2132         Add new WebKitTestRunner project (ie. DRT for WebKit2).
2133
2134         - Mac only.
2135         - run-webkit-tests has not been modified to call it yet.
2136         - Only dumps the render tree at this time. 
2137
2138         * WebKitTestRunner: Added.
2139         * WebKitTestRunner/Configurations: Added.
2140         * WebKitTestRunner/Configurations/Base.xcconfig: Added.
2141         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Added.
2142         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Added.
2143         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Added.
2144         * WebKitTestRunner/InjectedBundle: Added.
2145         * WebKitTestRunner/InjectedBundle-Info.plist: Added.
2146         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp: Added.
2147         (_didStartProvisionalLoadForFrame):
2148         (_didReceiveServerRedirectForProvisionalLoadForFrame):
2149         (_didFailProvisionalLoadWithErrorForFrame):
2150         (_didCommitLoadForFrame):
2151         (_didFinishLoadForFrame):
2152         (_didFailLoadWithErrorForFrame):
2153         (_didReceiveTitleForFrame):
2154         (_didClearWindow):
2155         (_didCreatePage):
2156         (_willDestroyPage):
2157         (_didRecieveMessage):
2158         (WKBundleInitialize):
2159         * WebKitTestRunner/Makefile: Added.
2160         * WebKitTestRunner/PlatformWebView.h: Added.
2161         (WTR::PlatformWebView::platformView):
2162         * WebKitTestRunner/TestController.cpp: Added.
2163         (WTR::TestController::shared):
2164         (WTR::TestController::TestController):
2165         (WTR::TestController::initialize):
2166         (WTR::TestController::runTest):
2167         (WTR::TestController::runTestingServerLoop):
2168         (WTR::TestController::run):
2169         * WebKitTestRunner/TestController.h: Added.
2170         (WTR::TestController::verbose):
2171         (WTR::TestController::injectedBundlePath):
2172         * WebKitTestRunner/TestInvocation.cpp: Added.
2173         (WTR::createWKURL):
2174         (WTR::TestInvocation::TestInvocation):
2175         (WTR::TestInvocation::~TestInvocation):
2176         (WTR::TestInvocation::invoke):
2177         (WTR::TestInvocation::dump):
2178         (WTR::TestInvocation::initializeMainWebView):
2179         (WTR::TestInvocation::didStartProvisionalLoadForFrame):
2180         (WTR::TestInvocation::didReceiveServerRedirectForProvisionalLoadForFrame):
2181         (WTR::TestInvocation::didFailProvisionalLoadWithErrorForFrame):
2182         (WTR::TestInvocation::didCommitLoadForFrame):
2183         (WTR::TestInvocation::didFinishLoadForFrame):
2184         (WTR::TestInvocation::didFailLoadForFrame):
2185         (WTR::TestInvocation::renderTreeExternalRepresentationFunction):
2186         (WTR::TestInvocation::renderTreeExternalRepresentationDisposeFunction):
2187         * WebKitTestRunner/TestInvocation.h: Added.
2188         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Added.
2189         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added.
2190         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Added.
2191         * WebKitTestRunner/mac: Added.
2192         * WebKitTestRunner/mac/PlatformWebViewMac.mm: Added.
2193         (WTR::PlatformWebView::PlatformWebView):
2194         (WTR::PlatformWebView::~PlatformWebView):
2195         (WTR::PlatformWebView::page):
2196         * WebKitTestRunner/mac/TestInvocationMac.mm: Added.
2197         (WTR::TestInvocation::runUntil):
2198         * WebKitTestRunner/mac/main.mm: Added.
2199         (main):
2200
2201 2010-06-24  Luiz Agostini  <luiz.agostini@openbossa.org>
2202
2203         Unreviewed. Adding myself to the committers list.
2204
2205         * Scripts/webkitpy/common/config/committers.py:
2206
2207 2010-06-23  Kevin Ollivier  <kevino@theolliviers.com>
2208
2209         [wx] Build fix, adding new LayoutTestController methods and enabling SVG_FOREIGN_OBJECT.
2210
2211         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2212         (LayoutTestController::isPageBoxVisible):
2213         (LayoutTestController::pageAreaRectInPixels):
2214         (LayoutTestController::preferredPageSizeInPixels):
2215         * wx/build/settings.py:
2216
2217 2010-06-23  James Robinson  <jamesr@chromium.org>
2218
2219         Unreviewed.  Add my IRC handle to committers.py so the sheriffbot can yell at me.
2220
2221         * Scripts/webkitpy/common/config/committers.py:
2222
2223 2010-06-23  Kent Tamura  <tkent@chromium.org>
2224
2225         Reviewed by Dimitri Glazkov.
2226
2227         Correct Chromium test configuration
2228         https://bugs.webkit.org/show_bug.cgi?id=41057
2229
2230         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2231          - Add "--use-drt" option for NRWT. It is required for Chromium and
2232            ignored for other platforms.
2233          - Skip JSC test on Chromium
2234         * BuildSlaveSupport/test-result-archive:
2235           Add Chromium support.
2236
2237 2010-06-23  Sam Weinig  <sam@webkit.org>
2238
2239         Reviewed by Anders Carlsson.
2240
2241         Fix for https://bugs.webkit.org/show_bug.cgi?id=41073
2242         WebKit2: Flesh out more of the InjectedBundle client API
2243
2244         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2245         (_didStartProvisionalLoadForFrame):
2246         (_didReceiveServerRedirectForProvisionalLoadForFrame):
2247         (_didFailProvisionalLoadWithErrorForFrame):
2248         (_didCommitLoadForFrame):
2249         (_didFinishLoadForFrame):
2250         (_didFailLoadWithErrorForFrame):
2251         (_didReceiveTitleForFrame):
2252         (_didClearWindowForFrame):
2253         (_didCreatePage):
2254         (_willDestroyPage):
2255         (WKBundleInitialize):
2256
2257 2010-06-23  Yuzo Fujishima  <yuzo@google.com>
2258
2259         Reviewed by Shinichiro Hamaji.
2260
2261         Implement page format data programming interface.
2262         Add methods for testing.
2263         https://bugs.webkit.org/show_bug.cgi?id=37538
2264
2265         * DumpRenderTree/LayoutTestController.cpp:
2266         (parsePageNumber):
2267         (isPageBoxVisibleCallback):
2268         (pageAreaRectInPixelsCallback):
2269         (preferredPageSizeInPixelsCallback):
2270         (LayoutTestController::staticFunctions):
2271         * DumpRenderTree/LayoutTestController.h:
2272         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2273         (LayoutTestController::isPageBoxVisible):
2274         (LayoutTestController::pageAreaRectInPixels):
2275         (LayoutTestController::preferredPageSizeInPixels):
2276         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2277         (LayoutTestController::isPageBoxVisible):
2278         (LayoutTestController::pageAreaRectInPixels):
2279         (LayoutTestController::preferredPageSizeInPixels):
2280         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2281         (LayoutTestController::isPageBoxVisible):
2282         (LayoutTestController::pageAreaRectInPixels):
2283         (LayoutTestController::preferredPageSizeInPixels):
2284
2285 2010-06-23  Sam Magnuson  <smagnuson@netflix.com>
2286
2287         Reviewed by Shinichiro Hamaji.
2288
2289         Follow proper convention for if/switch/while as I've discovered
2290         them to be through my review processes.
2291         https://bugs.webkit.org/show_bug.cgi?id=40723
2292
2293         Modified test so that if( foo ) is not allowed as it appears not
2294         to be the accepted convention.
2295
2296         * Scripts/webkitpy/style/checkers/cpp.py:
2297         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2298
2299 2010-06-22  Eric Seidel  <eric@webkit.org>
2300
2301         Reviewed by Adam Barth.
2302
2303         Run clean-header-guards to fix some header guards
2304         https://bugs.webkit.org/show_bug.cgi?id=41044
2305
2306         No functional changes, thus no tests.
2307
2308         This entire change was generated by running
2309         clean-header-guards, and then reverting changes
2310         to files which shouldn't be changed.  Those which
2311         are left all should be updated.
2312
2313         Some of these changes are just fixing 755 permissions
2314         to be 644, since it seems various files have the wrong
2315         execute bit which don't need it.  clean-header-guards
2316         made those (welcome) permission fixes unintentionally.
2317
2318         * DumpRenderTree/chromium/WebThemeControlDRT.h:
2319         * DumpRenderTree/chromium/WebThemeEngineDRT.h:
2320         * QtTestBrowser/fpstimer.h:
2321
2322 2010-06-22  Adam Barth  <abarth@webkit.org>
2323
2324         Reviewed by Eric Seidel.
2325
2326         Rename HTMLDocumentParser to LegacyHTMLDocumentParser
2327         https://bugs.webkit.org/show_bug.cgi?id=41043
2328
2329         Update the hash.
2330
2331         * Scripts/do-webcore-rename:
2332
2333 2010-06-22  Sam Magnuson  <smagnuson@netflix.com>
2334
2335         Reviewed by Shinichiro Hamaji.
2336
2337         Follow proper convention for variable declaration spacing.
2338         https://bugs.webkit.org/show_bug.cgi?id=40724
2339
2340         Modified test so that 'int   a;' is not allowed.
2341
2342         * Scripts/webkitpy/style/checkers/cpp.py:
2343         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2344
2345 2010-06-22  Eric Seidel  <eric@webkit.org>
2346
2347         Unreviewed.  Add Tony Gentilcore now that he's a committer.
2348
2349         * Scripts/webkitpy/common/config/committers.py:
2350
2351 2010-06-22  Eric Seidel  <eric@webkit.org>
2352
2353         Reviewed by Adam Barth.
2354
2355         Remove Gtk 64-Release bot from core since it's broken
2356         https://bugs.webkit.org/show_bug.cgi?id=41022
2357
2358         This bot alone has been responsible for more than 72 hours of
2359         commit-queue blockage in the last week.  The bot is broken -- keeps
2360         losing its display server or similar.  Until the Gtk folks can fix the
2361         bot, we need to remove it from core.  The WebKit community can't keep
2362         it green as is.
2363
2364         * Scripts/webkitpy/common/net/buildbot.py:
2365         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2366
2367 2010-06-21  Dumitru Daniliuc  <dumi@chromium.org>
2368
2369         Reviewed by Eric Seidel.
2370
2371         Fix the Windows build.
2372         https://bugs.webkit.org/show_bug.cgi?id=40972
2373
2374         * DumpRenderTree/win/ImageDiff.vcproj:
2375
2376 2010-06-21  Prasad Tammana  <prasadt@chromium.org>
2377
2378         Reviewed by Darin Adler, Dmitry Titov.
2379
2380         DumpRenderTree should allow tests with modal dialogs
2381         https://bugs.webkit.org/show_bug.cgi?id=35350
2382
2383         * DumpRenderTree/LayoutTestController.cpp:
2384         (abortModalCallback):
2385         (LayoutTestController::staticFunctions):
2386         * DumpRenderTree/LayoutTestController.h:
2387         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2388         (LayoutTestController::abortModal):
2389         Add abortModal method to LayoutTestController and make it available from script.
2390
2391         * DumpRenderTree/mac/UIDelegate.mm: Add support for showModalDialog.
2392         (-[UIDelegate modalWindowWillClose:]): Observer for NSWindowWillCloseNotifications to call
2393         abortModal from when modal window closes.
2394         (-[UIDelegate webViewRunModal:]): Delegate method for showModalDialog to run the modal loop.
2395
2396 2010-06-21  Simon Fraser  <simon.fraser@apple.com>
2397
2398         Reviewed by Anders Carlsson.
2399         
2400         Rename DrawingAreaProxyUpdateChunk to ChunkedUpdateDrawingArea
2401         https://bugs.webkit.org/show_bug.cgi?id=40948
2402         
2403         Have the script look in WebKit2.
2404
2405         * Scripts/do-webcore-rename:
2406
2407 2010-06-21  Robert Hogan  <robert@webkit.org>
2408
2409         Reviewed by Kenneth Rohde Christiansen.
2410
2411         [Qt] Unskip plugins/get-url-that-the-resource-load-delegate-will-disallow.html
2412
2413         It's a Mac-specific test so just add the required LayoutTestController
2414         function as a no-op to avoid failing. Similar approach adopted by other
2415         ports.
2416
2417         https://bugs.webkit.org/show_bug.cgi?id=33344
2418
2419         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2420         (LayoutTestController::addDisallowedURL):
2421
2422 2010-06-21  Sam Weinig  <sam@webkit.org>
2423
2424         Reviewed by Anders Carlsson.
2425
2426         Patch for https://bugs.webkit.org/show_bug.cgi?id=40940
2427         Add message passing support to the WebKit2 API.
2428
2429         - Add some test messages.
2430
2431         * MiniBrowser/mac/AppDelegate.m:
2432         (_didRecieveMessageFromInjectedBundle):
2433         (-[BrowserAppDelegate init]):
2434         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2435         (_didClearWindow):
2436         (_didCreatePage):
2437         (_didRecieveMessage):
2438         (WKBundleInitialize):
2439
2440 2010-06-21  Drew Wilson  <atwilson@chromium.org>
2441
2442         Unreviewed.
2443
2444         Rolling back 61551 and 61555 due to test failures.
2445
2446         * DumpRenderTree/LayoutTestController.cpp:
2447         (LayoutTestController::staticFunctions):
2448         * DumpRenderTree/LayoutTestController.h:
2449         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2450         (LayoutTestController::setEditingBehavior):
2451         * DumpRenderTree/mac/UIDelegate.mm:
2452
2453 2010-06-21  Anders Carlsson  <andersca@apple.com>
2454
2455         Reviewed by Sam Weinig.
2456
2457         Make DumpRenderTree build with clang++
2458
2459         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
2460         (-[LocalPasteboard setPropertyList:forType:]):
2461         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2462         (-[DumpRenderTreeWindow keyDown:]):
2463         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2464         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
2465         (LayoutTestController::isCommandEnabled):
2466
2467 2010-06-21  Satish Sampath  <satish@chromium.org>
2468
2469         Reviewed by Steve Block.
2470
2471         Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
2472         https://bugs.webkit.org/show_bug.cgi?id=40878
2473
2474         * Scripts/build-webkit:
2475
2476 2010-06-21  Kent Tamura  <tkent@chromium.org>
2477
2478         Reviewed by Dimitri Glazkov.
2479
2480         [DRT/Chromium] Initialization for http/tests/loading/
2481         https://bugs.webkit.org/show_bug.cgi?id=40902
2482
2483         * DumpRenderTree/chromium/TestShell.cpp:
2484         (TestShell::runFileTest):
2485
2486 2010-06-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2487
2488         Unreviewed.
2489
2490         Adding myself to the committers list.
2491
2492         * Scripts/webkitpy/common/config/committers.py:
2493
2494 2010-06-20  Kent Tamura  <tkent@chromium.org>
2495
2496         Reviewed by Dimitri Glazkov.
2497
2498         [DRT/Chromium] Add --allow-external-pages option
2499         https://bugs.webkit.org/show_bug.cgi?id=40762
2500
2501         Add --allow-external-pages introduced by Chromium r45403.
2502         http://src.chromium.org/viewvc/chrome?view=rev&revision=45403
2503
2504         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2505         (main):
2506         * DumpRenderTree/chromium/TestShell.cpp:
2507         (TestShell::TestShell):
2508         * DumpRenderTree/chromium/TestShell.h:
2509         (TestShell::allowExternalPages):
2510         (TestShell::setAllowExternalPages):
2511         * DumpRenderTree/chromium/WebViewHost.cpp:
2512         (WebViewHost::willSendRequest):
2513
2514 2010-06-20  Joseph Pecoraro  <joepeck@webkit.org>
2515
2516         Reviewed by Adam Barth.
2517
2518         Sheriffbot: Should allow "r" in SVN_REVISION
2519         https://bugs.webkit.org/show_bug.cgi?id=40889
2520
2521         * Scripts/webkitpy/tool/bot/irc_command.py: remove a leading "r" from SVN_REVISION if it exists
2522         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: test an SVN_REVISION with a leading r.
2523
2524 2010-06-20  Joseph Pecoraro  <joepeck@webkit.org>
2525
2526         Reviewed by Dimitri Glazkov.
2527
2528         Python Tests Fail after r61508
2529         https://bugs.webkit.org/show_bug.cgi?id=40891
2530
2531         Test's regex list needed to be updated to match the new
2532         regex list in the source code. Added new bots to the
2533         example_buildbots list.
2534
2535         Regex list fixed in r61512. Updated bot list.
2536
2537         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2538
2539 2010-06-20  Dimitri Glazkov  <dglazkov@chromium.org>
2540
2541         Unreviewed, build fix.
2542
2543         Tweak test regexp list to match the change in http://trac.webkit.org/changeset/61508.
2544
2545         * Scripts/webkitpy/common/net/buildbot_unittest.py: Tweaked regexp.
2546
2547 2010-06-19  Justin Schuh  <jschuh@chromium.org>
2548
2549         Unreviewed.
2550
2551         Adding myself to the committers list.
2552
2553         * Scripts/webkitpy/common/config/committers.py:
2554
2555 2010-06-19  Sam Weinig  <sam@webkit.org>
2556
2557         Reviewed by Anders Carlsson.
2558
2559         Fix for https://bugs.webkit.org/show_bug.cgi?id=40882
2560         Add ability to have a WebProcess per WebContext.
2561
2562         Move to use new shared contexts API.
2563
2564         * MiniBrowser/mac/AppDelegate.h:
2565         * MiniBrowser/mac/AppDelegate.m:
2566         (-[BrowserAppDelegate init]):
2567         (-[BrowserAppDelegate getCurrentPageNamespace]):
2568         (-[BrowserAppDelegate validateMenuItem:]):
2569         (-[BrowserAppDelegate _setProcessModel:]):
2570         (-[BrowserAppDelegate setSharedProcessProcessModel:]):
2571         (-[BrowserAppDelegate setSharedThreadProcessModel:]):
2572         * MiniBrowser/win/BrowserView.cpp:
2573         (BrowserView::create):
2574
2575 2010-06-02  Robert Hogan  <robert@webkit.org>
2576
2577         Reviewed by Adam Barth.
2578
2579         [Qt] Support evaluateScriptInIsolatedWorld()
2580
2581         https://bugs.webkit.org/show_bug.cgi?id=40079
2582
2583         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2584         (LayoutTestController::evaluateScriptInIsolatedWorld):
2585         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2586
2587 2010-06-18  Dimitri Glazkov  <dglazkov@chromium.org>
2588
2589         Reviewed by Darin Adler.
2590
2591         Add three more non-core Chromium builders to start testing DumpRenderTree.
2592         https://bugs.webkit.org/show_bug.cgi?id=40335
2593
2594         * BuildSlaveSupport/build.webkit.org-config/config.json: Added 3 builders.
2595
2596 2010-06-18  Drew Wilson  <atwilson@chromium.org>
2597
2598         Reviewed by Darin Fisher.
2599
2600         [Chromium] Plumbing for top-level frame names
2601         https://bugs.webkit.org/show_bug.cgi?id=40430
2602
2603         * DumpRenderTree/chromium/WebViewHost.cpp:
2604         (WebViewHost::reset):
2605         Changed obsolete call to clearName() to use setName(WebString()) instead.
2606
2607 2010-06-18  Sam Weinig  <weinig@apple.com>
2608
2609         Rolling http://trac.webkit.org/changeset/61297 back in.
2610
2611         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2612         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Removed.
2613         * MiniBrowser/mac/WebBundle/WebBundleMain.m: Added.
2614         (_didClearWindow):
2615         (_didCreatePage):
2616         (WKBundleInitialize):
2617
2618 2010-06-18  Alexey Proskuryakov  <ap@apple.com>
2619
2620         Reviewed by Darin Adler.
2621
2622         https://bugs.webkit.org/show_bug.cgi?id=40803
2623         TestNetscapePlugin has an incorrect implementation of "property" property
2624
2625         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginGetProperty): Don't
2626         pass a static string back, it's going to be released by NPAPI implementation.
2627
2628 2010-06-18  Leandro Pereira  <leandro@profusion.mobi>
2629
2630         Unreviewed.
2631
2632         Adding myself to the committers list.
2633
2634         * Scripts/webkitpy/common/config/committers.py:
2635
2636 2010-06-17  Tony Chang  <tony@chromium.org>
2637
2638         Reviewed by Kent Tamura.
2639
2640         [chromium] cleanup redundant DEPS value and remove buildbot cleanup code
2641         https://bugs.webkit.org/show_bug.cgi?id=40615
2642
2643         * Scripts/update-webkit-chromium: remove directory removal of third_party in old checkouts
2644
2645 2010-06-17  Ada Chan  <adachan@apple.com>
2646
2647         Rolling out http://trac.webkit.org/changeset/61297 due to build errors.
2648
2649         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2650         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Copied from MiniBrowser/mac/WebBundle/WebBundleMain.c.
2651         * MiniBrowser/mac/WebBundle/WebBundleMain.m: Removed.
2652
2653 2010-06-17  Darin Adler  <darin@apple.com>
2654
2655         One more try at fix for Chromium build.
2656
2657         * DumpRenderTree/chromium/TestShell.cpp:
2658         (TestShell::TestShell): Use set again instead of =.
2659
2660 2010-06-17  Darin Adler  <darin@apple.com>
2661
2662         Fix Chromium build.
2663
2664         I didn't realize that neither Chromium nor Qt share the DumpRenderTree
2665         code with all the other platforms! Wow, that should be fixed at some point.
2666
2667         * DumpRenderTree/chromium/TestShell.cpp:
2668         (TestShell::TestShell): Changed back to using "new".
2669         * DumpRenderTree/chromium/TestShell.h: Changed back to OwnPtr.
2670
2671 2010-06-17  Simon Hausmann  <simon.hausmann@nokia.com>
2672
2673         Unreviewed Qt build fix.
2674
2675         LayoutTestController in the Qt DRT is not using refs :)
2676
2677         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2678         (WebCore::DumpRenderTree::DumpRenderTree):
2679
2680 2010-06-17  Darin Adler  <darin@apple.com>
2681
2682         Reviewed by Sam Weinig.
2683
2684         Use adoptRef and create functions in more code paths
2685         https://bugs.webkit.org/show_bug.cgi?id=40760
2686
2687         * DumpRenderTree/DumpRenderTree.h: Change gLayoutTestController to a RefPtr.
2688
2689         * DumpRenderTree/LayoutTestController.cpp:
2690         (LayoutTestController::create): Added.
2691         * DumpRenderTree/LayoutTestController.h: Declare the create function.
2692
2693         * DumpRenderTree/chromium/TestShell.cpp:
2694         (TestShell::TestShell): Use create instead of new.
2695         * DumpRenderTree/chromium/TestShell.h: Use RefPtr instead of OwnPtr.
2696
2697         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2698         (runTest): Use RefPtr and create instead of OwnPtr and new.
2699
2700         * DumpRenderTree/mac/DumpRenderTree.mm:
2701         (runTest): Use RefPtr and create instead of OwnPtr and new.
2702
2703         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2704         (WebCore::DumpRenderTree::DumpRenderTree): Use create and releaseRef
2705         instead of new.
2706
2707         * DumpRenderTree/win/DumpRenderTree.cpp:
2708         (runTest): Use RefPtr and create instead of OwnPtr and new.
2709
2710         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
2711         (runTest): Use RefPtr and create instead of OwnPtr and new.
2712         (MyApp::OnInit): Removed unneeded code to delete the layout
2713         test controller. This is done during each test.
2714
2715 2010-06-17  Kent Tamura  <tkent@chromium.org>
2716
2717         Reviewed by Shinichiro Hamaji.
2718
2719         [DRT/Chromium] Fix a bug of Windows pixel tests
2720         https://bugs.webkit.org/show_bug.cgi?id=40763
2721
2722         * DumpRenderTree/chromium/TestEventPrinter.cpp:
2723         (TestShellPrinter::handleImage):
2724
2725 2010-06-16  Kent Tamura  <tkent@chromium.org>
2726
2727         Reviewed by Shinichiro Hamaji.
2728
2729         [DRT/Chromium] Fix crash on Mac Release
2730         https://bugs.webkit.org/show_bug.cgi?id=40759
2731
2732         * DumpRenderTree/chromium/WebViewHost.cpp:
2733         (WebViewHost::paintRect): We should not use m_canvas directly because
2734           it is created lazily in canvas().
2735
2736 2010-06-16  Kevin Ollivier  <kevino@theolliviers.com>
2737
2738         [wx] Build fix after new method addition.
2739
2740         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2741         (LayoutTestController::pageProperty):
2742
2743 2010-06-16  Kent Tamura  <tkent@chromium.org>
2744
2745         Reviewed by Dimitri Glazkov.
2746
2747         [DRT/Chromium] Set current working directory for each of tests
2748         https://bugs.webkit.org/show_bug.cgi?id=40668
2749
2750         This change fixes tests with eventSender.beginDragWithFiles().
2751
2752         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2753         (runTest):
2754
2755 2010-06-16  Martin Robinson  <mrobinson@igalia.com>
2756
2757         Reviewed by Gustavo Noronha Silva.
2758
2759         [GTK] r60803 broke media/controls-drag-timebar.html
2760         https://bugs.webkit.org/show_bug.cgi?id=40269
2761
2762         Only queue events while the mouse button is down, if drag mode is enabled. Some
2763         tests may disable drag mode, to prevent the queuing of events in this situation.
2764
2765         * DumpRenderTree/gtk/EventSender.cpp:
2766         (sendOrQueueEvent): Only queue events here if dragMode is true.
2767
2768 2010-06-16  Martin Robinson  <mrobinson@igalia.com>
2769
2770         Reviewed by Gustavo Noronha Silva.
2771
2772         [GTK] Remove the abuse of GDK_CURRENT_TIME in the DRT
2773         https://bugs.webkit.org/show_bug.cgi?id=40600
2774
2775         * DumpRenderTree/gtk/EventSender.cpp:
2776         (prepareMouseButtonEvent): Remove logic adding an offset to GDK_CURRENT_TIME.
2777
2778 2010-06-16  Adam Barth  <abarth@webkit.org>
2779
2780         Reviewed by Dimitri Glazkov.
2781
2782         Add a hidden land-cowboy command to webkit-patch to help land quick
2783         build fixes.
2784
2785         * Scripts/webkitpy/tool/commands/download.py:
2786         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2787
2788 2010-06-16  Adam Roben  <aroben@apple.com>
2789
2790         Convert console messages to UTF-8 before printing them
2791
2792         Speculative fix for <http://webkit.org/b/40731> REGRESSION (r61234):
2793         http/tests/security/xssAuditor/embed-tag-null-char.html and
2794         http/tests/security/xssAuditor/object-embed-tag-null-char.html fail on
2795         Windows. (I can't test the fix because Apache is crashing on my
2796         computer.)
2797
2798         Reviewed by Alexey Proskuryakov.
2799
2800         * DumpRenderTree/win/DumpRenderTree.cpp:
2801         (toUTF8): Extracted the code into an overload that takes a wide string
2802         and a length, then added an overload that takes a wstring.
2803
2804         * DumpRenderTree/win/DumpRenderTreeWin.h: Declare the new toUTF8
2805         overload.
2806
2807         * DumpRenderTree/win/UIDelegate.cpp:
2808         (UIDelegate::webViewAddMessageToConsole): Use toUTF8 to convert to
2809         UTF-8 instead of letting printf convert to the current code page.
2810
2811 2010-06-16  Drew Wilson  <atwilson@chromium.org>
2812
2813         Reviewed by Kent Tamura.
2814
2815         [Chromium] Plumbing for top-level frame names
2816         https://bugs.webkit.org/show_bug.cgi?id=40430
2817
2818         * DumpRenderTree/chromium/WebViewHost.cpp:
2819         (WebViewHost::createView):
2820         Migrate to new createView() API.
2821         * DumpRenderTree/chromium/WebViewHost.h:
2822         Remove obsolete createView() methods, add new createView() API that takes a frameName parameter.
2823
2824 2010-06-16  Diego Gonzalez  <diegohcg@webkit.org>
2825
2826         Reviewed by Kenneth Rohde Christiansen.
2827
2828         [Qt] Scroll wheel event support to graphics based DRT
2829         https://bugs.webkit.org/show_bug.cgi?id=40577
2830
2831         * DumpRenderTree/qt/EventSenderQt.cpp:
2832         (EventSender::continuousMouseScrollBy):
2833         (EventSender::createGraphicsSceneWheelEvent):
2834         * DumpRenderTree/qt/EventSenderQt.h:
2835
2836 2010-06-16  Adam Roben  <aroben@apple.com>
2837
2838         Remove a stray newline from the Windows version of TestNetscapePlugin
2839
2840         Reviewed by Alexey Proskuryakov.
2841
2842         Fixes <http://webkit.org/b/40728>
2843         plugins/geturlnotify-during-document-teardown.html fails on Windows
2844
2845         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
2846         (NPP_Destroy): Removed extra newline that the Mac version doesn't
2847         have.
2848
2849 2010-06-16  Adam Roben  <aroben@apple.com>
2850
2851         Respect LayoutTestController::isPrinting on Windows
2852
2853         This gets some printing tests closer to passing (like
2854         printing/page-rule-in-media-query.html).
2855
2856         Fixes <http://webkit.org/b/40727>.
2857
2858         Reviewed by Dan Bernstein.
2859
2860         * DumpRenderTree/win/DumpRenderTree.cpp:
2861         (dump): Pass LayoutTestController::isPrinting to
2862         IWebFramePrivate::renderTreeAsExternalRepresentation.
2863
2864 2010-06-15  Adam Barth  <abarth@webkit.org>
2865
2866         Reviewed by Eric Seidel.
2867
2868         Enable HTML5 lexer
2869         https://bugs.webkit.org/show_bug.cgi?id=40650
2870
2871         * DumpRenderTree/mac/DumpRenderTree.mm:
2872         (initializeGlobalsFromCommandLineOptions):
2873
2874 2010-06-10  Yuzo Fujishima  <yuzo@google.com>
2875
2876         Reviewed by Shinichiro Hamaji.
2877
2878         Implement render style selection for pages to support CSS3 Paged Media.
2879         https://bugs.webkit.org/show_bug.cgi?id=35961
2880
2881         * DumpRenderTree/LayoutTestController.cpp:
2882         (parsePagePropertyParameters):
2883         (pagePropertyCallback):
2884         (LayoutTestController::staticFunctions):
2885         * DumpRenderTree/LayoutTestController.h:
2886         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2887         (LayoutTestController::pageProperty):
2888         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2889         (LayoutTestController::pageProperty):
2890         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2891         (LayoutTestController::pageProperty):
2892
2893 2010-06-15  Sam Weinig  <sam@webkit.org>
2894
2895         Reviewed by Anders Carlsson.
2896
2897         Fix for https://bugs.webkit.org/show_bug.cgi?id=40630
2898         WebKit2: Add mechanism to inject code into the WebProcess on startup
2899
2900         Add initial InjectedBundle support.
2901
2902         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2903         * MiniBrowser/WebBundle-Info.plist: Added.
2904         Add test InjectedBundle to the project.
2905
2906         * MiniBrowser/mac/AppDelegate.m:
2907         (-[BrowserAppDelegate init]):
2908         Get the path to the WebBundle from the the main bundle and pass it to the new
2909         WKContextCreateWithInjectedBundlePath function.
2910
2911         * MiniBrowser/mac/BrowserWindowController.m:
2912         (_didChangeProgress):
2913         Fix the build.  This has been broken for a while.
2914
2915         * MiniBrowser/mac/WebBundle: Added.
2916         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Added.
2917         (_didCreatePage):
2918         (WKBundleInitialize):
2919         Add really basic InjectedBundle.
2920
2921         * MiniBrowser/win/BrowserView.cpp:
2922         (BrowserView::create):
2923         Switch from WKContextCreateWithProcessModel to WKContextCreate and remove commented out code.
2924
2925 2010-06-15  Dumitru Daniliuc  <dumi@chromium.org>
2926
2927         Reviewed by Darin Adler.
2928
2929         Adding myself to the reviewers list.
2930         https://bugs.webkit.org/show_bug.cgi?id=40693
2931
2932         * Scripts/webkitpy/common/config/committers.py:
2933
2934 2010-06-15  Martin Robinson  <mrobinson@igalia.com>
2935
2936         Reviewed by Xan Lopez.
2937
2938         Switch to using GIO methods instead of realpath in GtkLauncher to determine
2939         the file URI. This should remove warnings about realpath being undefined
2940         when compiling with '-ansi'.
2941
2942         * GtkLauncher/main.c:
2943         (filenameToURL): Use GIO instead of realpath to determine file URI.
2944
2945 2010-06-15  Adam Roben  <aroben@apple.com>
2946
2947         Remove the redundant set-apple-windows-environment-variables script
2948
2949         Apparently update-webkit does this for you these days.
2950
2951         Rubber-stamped by Steve Falkenburg.
2952
2953         * Scripts/set-apple-windows-environment-variables: Removed.
2954
2955 2010-06-14  Adam Roben  <aroben@apple.com>
2956
2957         Add a script to set the WebKitOutputDir and WebKitLibrariesDir
2958         environment variables
2959
2960         Fixes <http://webkit.org/b/40595>.
2961
2962         Reviewed by Steve Falkenburg.
2963
2964         * Scripts/set-apple-windows-environment-variables: Added.
2965         (to_windows_path): Passes the passed-in path through cygpath to
2966         generate a Windows-style path.
2967         (main): Sets the WebKitOutputDir and WebKitLibrariesDir environment
2968         variables to their defaults, if they aren't already set.
2969
2970 2010-06-14  Adam Roben  <aroben@apple.com>
2971
2972         Speed up run-safari/debug-safari on Windows
2973
2974         Fixes <http://webkit.org/b/40586>.
2975
2976         Reviewed by Steve Falkenburg.
2977
2978         * Scripts/webkitdirs.pm:
2979         (runSafari): When debugging, set up the environment to run Safari
2980         using the built WebKit.dll, then use "devenv /debugexe Safari.exe" to
2981         actually launch the debugger. When not debugging, just run WebKit.exe
2982         and it will do the rest for us.
2983
2984 2010-06-15  Diego Gonzalez  <diegohcg@webkit.org>
2985
2986         Reviewed by Kenneth Rohde Christiansen.
2987
2988         [Qt] DRT EventSender support to graphics context events
2989         https://bugs.webkit.org/show_bug.cgi?id=40324
2990
2991         * DumpRenderTree/qt/EventSenderQt.cpp:
2992         (EventSender::contextClick):
2993
2994 2010-06-14  Tony Chang  <tony@chromium.org>
2995
2996         Reviewed by Darin Fisher.
2997
2998         [chromium] checkout chromium third_party directly
2999         https://bugs.webkit.org/show_bug.cgi?id=40556
3000
3001         * Scripts/update-webkit-chromium: some migration code for the bots
3002
3003 2010-06-14  Alexey Proskuryakov  <ap@apple.com>
3004
3005         Chromium build fix.
3006
3007         * DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown): Chromium uses differently
3008         named constants for Windows virtual key codes, replacing VK_DELETE with VKEY_DELETE.
3009
3010 2010-06-14  Alexey Proskuryakov  <ap@apple.com>
3011
3012         Reviewed by Darin Adler.
3013
3014         https://bugs.webkit.org/show_bug.cgi?id=40529
3015         eventSender.keyDown("delete") incorrectly sends a backspace on some platforms
3016
3017         * DumpRenderTree/mac/EventSendingController.mm:
3018         (-[EventSendingController keyDown:withModifiers:withLocation:]): We were sending a broken
3019         event for "delete" - it had virtual key code from forward delete, and text from backspace.
3020         Fixed "delete" to mean forward delete.
3021
3022         * DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown):
3023         * DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback):
3024         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
3025         Mac DRT confusion has propagated to other platforms, fixing those.
3026
3027 2010-06-14  Martin Robinson  <mrobinson@igalia.com>
3028
3029         Reviewed by Xan Lopez.
3030
3031         Small GtkLauncher build fix for some systems.
3032
3033         * GtkLauncher/main.c: Add <limit.h> include.
3034
3035 2010-06-14  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
3036
3037         Reviewed by Laszlo Gombos.
3038
3039         [Qt] navigator.geolocation support for Qt port
3040         https://bugs.webkit.org/show_bug.cgi?id=39724
3041
3042         Implementation for geolocation cases to DumpRenderTreeQt
3043
3044         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3045         (WebCore::WebPage::allowGeolocationRequest):
3046         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3047         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3048         (LayoutTestController::setGeolocationPermission):
3049         (LayoutTestController::setMockGeolocationError):
3050         (LayoutTestController::setMockGeolocationPosition):
3051         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3052         (LayoutTestController::isGeolocationPermissionSet):
3053         (LayoutTestController::geolocationPermission):
3054
3055 2010-06-13  Nathan Lawrence  <nlawrence@apple.com>
3056
3057         Reviewed by Darin Adler.
3058
3059         Outside of Xcode (make or WebKitTools/Scripts), there doesn't seem to
3060         be a way of overwriting the Xcode system path.  Making
3061         $WEBKITOUTPUTDIR take precedence over the system default would make
3062         this possible.
3063
3064         * Scripts/webkitdirs.pm:
3065
3066 2010-06-13  Chris Fleizach  <cfleizach@apple.com>
3067
3068         Reviewed by Darin Adler.
3069
3070         AX: link won't return linked element if URL contains #
3071         https://bugs.webkit.org/show_bug.cgi?id=40192
3072
3073         * DumpRenderTree/AccessibilityUIElement.cpp:
3074         (linkedUIElementAtIndexCallback):
3075         (AccessibilityUIElement::getJSClass):
3076         * DumpRenderTree/AccessibilityUIElement.h:
3077         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3078         (AccessibilityUIElement::linkedUIElementAtIndex):
3079         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3080         (AccessibilityUIElement::linkedUIElementAtIndex):
3081         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3082         (AccessibilityUIElement::linkedUIElementAtIndex):
3083
3084 2010-06-13  Adam Barth  <abarth@webkit.org>
3085
3086         Reviewed by Darin Adler.
3087
3088         webkit-patch should add a bug URL to ChangeLogs if they don't have one yet
3089         https://bugs.webkit.org/show_bug.cgi?id=39550
3090
3091         This can cause an extra request to bugs.webkit.org durig upload, but it
3092         shouldn't be too bad.  Also, this won't work if you remove the
3093         boilerplate created by prepare-ChangeLog.
3094
3095         * Scripts/webkitpy/common/checkout/changelog.py:
3096         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3097         * Scripts/webkitpy/common/net/bugzilla.py:
3098         * Scripts/webkitpy/tool/steps/abstractstep.py:
3099         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3100         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py: Added.
3101
3102 2010-06-08  Robert Hogan  <robert@webkit.org>
3103
3104         Reviewed by Eric Seidel.
3105
3106         [Qt] Add support for callShouldCloseOnWebView() to DRT
3107         https://bugs.webkit.org/show_bug.cgi?id=40330
3108
3109         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3110         (LayoutTestController::callShouldCloseOnWebView):
3111         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3112         (LayoutTestController::setCallCloseOnWebViews):
3113
3114 2010-06-12  Eric Seidel  <eric@webkit.org>
3115
3116         Reviewed by Daniel Bates.
3117
3118         do-webcore-rename should have a --verbose option
3119         https://bugs.webkit.org/show_bug.cgi?id=40497
3120
3121         * Scripts/do-webcore-rename:
3122          - Unified how we handle skipping files/directories
3123            this will allow us to "black list" certain files and
3124            directories when performing renames.
3125          - Made do-webcore-rename log what it's skipping when passed --verbose.
3126
3127 2010-06-12  Darin Adler  <darin@apple.com>
3128
3129         * Scripts/run-bindings-tests: Fixed a typo in a message.
3130
3131 2010-06-12  Kent Tamura  <tkent@chromium.org>
3132
3133         Reviewed by Dimitri Glazkov.
3134
3135         [Chromium] new-run-webkit-tests --use-drt should work with Chromium checkout
3136         https://bugs.webkit.org/show_bug.cgi?id=40402
3137
3138         _build_path() of each Chromium port check existence of build path
3139         of Chromium checkout first, then check existence of build path of
3140         WebKit-only checkout.
3141
3142         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3143         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3144         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3145
3146 2010-06-12  Robert Hogan  <robert@webkit.org>
3147
3148         Reviewed by Kenneth Rohde Christiansen.
3149
3150         [Qt] Back-forward list dumping is incorrect
3151
3152         https://bugs.webkit.org/show_bug.cgi?id=36392
3153
3154         Support dumping child history items in DRT.
3155
3156         Unskip:
3157
3158         fast/loader/frame-src-change-added-to-history.html
3159         fast/loader/frame-src-change-not-added-to-history.html
3160         fast/loader/frame-location-change-not-added-to-history.html
3161
3162         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3163         (WebCore::dumpHistoryItem):
3164
3165 2010-06-10  Ojan Vafai  <ojan@chromium.org>
3166
3167         Reviewed by Eric Seidel.
3168
3169         upload all patches that lack in-rietveld to rietveld
3170         https://bugs.webkit.org/show_bug.cgi?id=40444
3171
3172         If it's a patch, then we'll try to upload it as long as it
3173         doesn't have in-rietveld set. No longer set in-rietveld? since
3174         it's not needed.
3175
3176         * Scripts/webkitpy/common/net/bugzilla.py:
3177
3178 2010-06-10  Ojan Vafai  <ojan@chromium.org>
3179
3180         Reviewed by Darin Fisher.
3181
3182         Fix rietveld upload when message length > 100 characters
3183         https://bugs.webkit.org/show_bug.cgi?id=40457
3184
3185         * Scripts/webkitpy/common/net/rietveld.py:
3186
3187 2010-06-11  Yael Aharon  <yael.aharon@nokia.com>
3188
3189         Reviewed by Laszlo Gombos.
3190
3191         [Qt] There should be a way to enable popups in QtTestBrowser
3192         https://bugs.webkit.org/show_bug.cgi?id=40427
3193
3194         * QtTestBrowser/main.cpp:
3195         (LauncherWindow::toggleJavascriptCanOpenWindows):
3196         (LauncherWindow::createChrome):
3197
3198 2010-06-10  Adam Barth  <abarth@webkit.org>
3199
3200         Reviewed by Daniel Bates.
3201
3202         Make SheriffBot more chatty
3203         https://bugs.webkit.org/show_bug.cgi?id=40463
3204
3205         People seem to like to talk to SheriffBot, so let's make him chat back.
3206
3207         * Scripts/webkitpy/thirdparty/__init__.py:
3208         * Scripts/webkitpy/tool/bot/irc_command.py:
3209         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Added.
3210         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
3211         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3212
3213 2010-06-10  Brian Weinstein  <bweinstein@apple.com>
3214
3215         Reviewed by Darin Adler.
3216
3217         Fix the Windows buildbot when WebKitAuxiliaryLibs.zip cannot be found on our server.
3218         
3219         Robustify update-webkit-auxiliary-libs to be able to handle the case when WebKitAuxiliaryLibs.zip doesn't exist,
3220         and allow the script to fall back to an existing file, only failing if there is no fallback file. Also switch to checking
3221         WEXITSTATUS on $result instead of just comparing $result to 0.
3222
3223         * Scripts/update-webkit-auxiliary-libs:
3224
3225 2010-06-10  Ojan Vafai  <ojan@chromium.org>
3226
3227         Reviewed by Alexey Proskuryakov.
3228
3229         don't use Exception.message as it's deprecated in python 2.6+
3230         https://bugs.webkit.org/show_bug.cgi?id=40449
3231
3232         * Scripts/webkitpy/tool/commands/queues.py:
3233
3234 2010-06-10  Ojan Vafai  <ojan@chromium.org>
3235
3236         Reviewed by Adam Barth.
3237
3238         fix handle_script_error in rietveld upload queue and add testing for handle_script_error
3239         https://bugs.webkit.org/show_bug.cgi?id=40436
3240
3241         * Scripts/webkitpy/common/system/outputcapture.py:
3242         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3243         * Scripts/webkitpy/tool/commands/queues.py:
3244         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3245         * Scripts/webkitpy/tool/commands/queuestest.py:
3246         * Scripts/webkitpy/tool/mocktool.py:
3247
3248 2010-06-10  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
3249
3250         Reviewed by Simon Hausmann.
3251
3252         [Qt] *All* WebGL layout tests fail!
3253         https://bugs.webkit.org/show_bug.cgi?id=40296
3254
3255         Added test for WebKitWebGLEnabled to
3256         LayoutTestController::overridePreference().
3257
3258         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3259         (LayoutTestController::overridePreference):
3260
3261 2010-06-10  Diego Gonzalez  <diegohcg@webkit.org>
3262
3263         Reviewed by Kenneth Rohde Christiansen.
3264
3265         [Qt] DRT EventSender support to graphics mouse events activation
3266         https://bugs.webkit.org/show_bug.cgi?id=40017
3267
3268         * DumpRenderTree/qt/EventSenderQt.cpp:
3269         (EventSender::mouseDown):
3270         (EventSender::mouseUp):
3271         (EventSender::mouseMoveTo):
3272         (EventSender::keyDown):
3273         (EventSender::contextClick):
3274         (EventSender::sendTouchEvent):
3275         (EventSender::sendOrQueueEvent):
3276         (EventSender::eventFilter):
3277         (EventSender::createGraphicsSceneMouseEvent):
3278         (EventSender::sendEvent):
3279         * DumpRenderTree/qt/EventSenderQt.h:
3280         (EventSender::isGraphicsBased):
3281
3282 2010-06-09  Adam Barth  <abarth@webkit.org>
3283
3284         Reviewed by Ojan Vafai.
3285
3286         webkit-patch upload fails for security bugs because there's no rietveld flag
3287         https://bugs.webkit.org/show_bug.cgi?id=40309
3288
3289         There's probably a more elegant way of seeing whether the form control
3290         exists, but this seems to work.
3291
3292         * Scripts/webkitpy/common/net/bugzilla.py:
3293
3294 2010-06-09  Ojan Vafai  <ojan@chromium.org>
3295
3296         Reviewed by Adam Barth.
3297
3298         make rietveld upload faster and avoid posting to bug on errors
3299         https://bugs.webkit.org/show_bug.cgi?id=40389
3300
3301         Only grab the first item of the upload queue instead of trying
3302         to compute the whole list upfront (which is O(n) bugzilla lookups!).
3303
3304         Also, don't post comments to the bug when uploading fails.
3305
3306         * Scripts/webkitpy/common/net/bugzilla.py:
3307         * Scripts/webkitpy/tool/commands/queues.py:
3308         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3309         * Scripts/webkitpy/tool/commands/stepsequence.py:
3310         * Scripts/webkitpy/tool/mocktool.py:
3311
3312 2010-06-09  Ojan Vafai  <ojan@chromium.org>
3313
3314         Reviewed by Adam Barth.
3315
3316         Rietveld upload queue fails when setting in-rietveld flag
3317         https://bugs.webkit.org/show_bug.cgi?id=40371
3318
3319         Make the comment arguments to set_flag_on_attachment optional
3320         and add it to the MockBugzilla.
3321
3322         * Scripts/webkitpy/common/net/bugzilla.py:
3323         * Scripts/webkitpy/tool/bot/queueengine.py:
3324         * Scripts/webkitpy/tool/commands/download_unittest.py:
3325         * Scripts/webkitpy/tool/commands/queues.py:
3326         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3327         * Scripts/webkitpy/tool/mocktool.py:
3328
3329 2010-06-09  Kenneth Russell  <kbr@google.com>
3330
3331         Reviewed by Dimitri Glazkov.
3332
3333         Rename FloatArray to Float32Array
3334         https://bugs.webkit.org/show_bug.cgi?id=40323
3335
3336         Used do-webcore-rename to perform renaming. Manually undid
3337         incorrect changes to WebCore/bridge/jni/jsc/JNIBridgeJSC.cpp,
3338         WebCore/manual-tests/resources/ArrayParameterTestApplet.java and
3339         ArrayParameterTestApplet.class. Updated LayoutTests. Built and ran
3340         all layout tests on Safari; built Chromium and ran selected WebGL
3341         tests.
3342
3343         * Scripts/do-webcore-rename:
3344
3345 2010-06-08  Tony Chang  <tony@chromium.org>
3346
3347         Reviewed by David Levin.
3348
3349         [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out
3350         https://bugs.webkit.org/show_bug.cgi?id=40285
3351
3352         * Scripts/webkitdirs.pm:
3353         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3354
3355 2010-06-03  Roland Steiner  <rolandsteiner@chromium.org>
3356
3357         Reviewed by Tamura Kent.
3358
3359         Bug 40052 - [DRT/Chromium] Upstream test_shell_webthemeengine as WebThemeEngineDRT
3360         https://bugs.webkit.org/show_bug.cgi?id=40052
3361         
3362         Add WebThemeEngineDRT and WebThemeControlDRT ported from Chromium rev. 48907
3363
3364         * DumpRenderTree/DumpRenderTree.gypi:
3365         * DumpRenderTree/chromium/TestShellWin.cpp:
3366         (platformInit):
3367         * DumpRenderTree/chromium/WebThemeControlDRT.cpp: Added.
3368         (WebKit::):
3369         (WebKit::WebThemeControlDRT::WebThemeControlDRT):
3370         (WebKit::WebThemeControlDRT::~WebThemeControlDRT):
3371         (WebKit::WebThemeControlDRT::box):
3372         (WebKit::WebThemeControlDRT::line):
3373         (WebKit::WebThemeControlDRT::triangle):
3374         (WebKit::WebThemeControlDRT::roundRect):
3375         (WebKit::WebThemeControlDRT::oval):
3376         (WebKit::WebThemeControlDRT::circle):
3377         (WebKit::WebThemeControlDRT::nestedBoxes):
3378         (WebKit::WebThemeControlDRT::markState):
3379         (WebKit::WebThemeControlDRT::draw):
3380         (WebKit::WebThemeControlDRT::drawTextField):
3381         (WebKit::WebThemeControlDRT::drawProgressBar):
3382         * DumpRenderTree/chromium/WebThemeControlDRT.h: Added.
3383         (WebKit::WebThemeControlDRT::):
3384         * DumpRenderTree/chromium/WebThemeEngineDRT.cpp: Added.
3385         (WebKit::):
3386         (WebKit::WebThemeEngineDRT::paintButton):
3387         (WebKit::WebThemeEngineDRT::paintMenuList):
3388         (WebKit::WebThemeEngineDRT::paintScrollbarArrow):
3389         (WebKit::WebThemeEngineDRT::paintScrollbarThumb):
3390         (WebKit::WebThemeEngineDRT::paintScrollbarTrack):
3391         (WebKit::WebThemeEngineDRT::paintTextField):
3392         (WebKit::WebThemeEngineDRT::paintTrackbar):
3393         (WebKit::WebThemeEngineDRT::paintProgressBar):
3394         * DumpRenderTree/chromium/WebThemeEngineDRT.h: Added.
3395         (WebKit::WebThemeEngineDRT::WebThemeEngineDRT):
3396
3397 2010-06-08  Sheriff Bot  <webkit.review.bot@gmail.com>
3398
3399         Unreviewed, rolling out r60878.
3400         http://trac.webkit.org/changeset/60878
3401         https://bugs.webkit.org/show_bug.cgi?id=40349
3402
3403         broke linux build (Requested by tony^work on #webkit).
3404
3405         * Scripts/webkitdirs.pm:
3406         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3407
3408 2010-06-08  Tony Chang  <tony@chromium.org>
3409
3410         Reviewed by David Levin.
3411
3412         [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out
3413         https://bugs.webkit.org/show_bug.cgi?id=40285
3414
3415         * Scripts/webkitdirs.pm:
3416         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3417
3418 2010-06-08  Kenneth Russell  <kbr@google.com>
3419
3420         Unreviewed, build fix.
3421
3422         Fix build breakage from 38145
3423         https://bugs.webkit.org/show_bug.cgi?id=40346
3424
3425         The fix for bug 38145 broke the Chromium Win build because
3426         Microsoft's cmath doesn't define log2. Suggested fix by zmo is to
3427         change log2(x) to log(x) / log(2). Built and ran WebGL layout
3428         tests in Safari on Mac OS X. Changed download mirrors for
3429         python-irclib to working ones.
3430
3431         * Scripts/webkitpy/thirdparty/__init__.py:
3432
3433 2010-06-08  Fumitoshi Ukai  <ukai@chromium.org>
3434
3435         Reviewed by Eric Seidel.
3436
3437         old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
3438         https://bugs.webkit.org/show_bug.cgi?id=39058
3439
3440         * Scripts/old-run-webkit-tests:
3441          use sourceDir() to find ensure-valid-python in checkPythonVersion()
3442
3443 2010-06-08  Andras Becsi  <abecsi@webkit.org>
3444
3445         Unreviewed buildfix after r60479.
3446
3447         [GTK] Move the declaration of getRootCoords higher up to fix the build on GTK
3448         versions other than 2.17.3.
3449
3450         * DumpRenderTree/gtk/EventSender.cpp:
3451         (getRootCoords):
3452
3453 2010-06-07  Martin Robinson  <mrobinson@igalia.com>
3454
3455         Reviewed by Oliver Hunt.
3456
3457         [GTK] Mouse movement should not trigger a replay of saved events in the event sender
3458         https://bugs.webkit.org/show_bug.cgi?id=40267
3459
3460         When a mouse button is down, automatically queue mouse motion events and
3461         do not play them back until the mouse button is released. This matches the
3462         behavior of other ports' EventSenders.
3463
3464         * DumpRenderTree/gtk/EventSender.cpp:
3465         (mouseMoveToCallback): Don't automatically replaySavedEvents for mouse motion.
3466         (sendOrQueueEvent): Add a shouldReplaySavedEvents argument defaulting to true.
3467
3468 2010-06-07  Nikolas Zimmermann  <nzimmermann@rim.com>
3469
3470         Reviewed by Sam Weinig.
3471
3472         Add CPP bindings generator
3473         https://bugs.webkit.org/show_bug.cgi?id=38279
3474
3475         Integrate CPP bindings in run-bindings-tests.
3476
3477         * Scripts/run-bindings-tests:
3478
3479 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
3480
3481         Reviewed by Ojan Vafai.
3482
3483         Rename 'svn_merge_base' -> 'remote_merge_base'. This was left out of r60633.
3484         https://bugs.webkit.org/show_bug.cgi?id=40183
3485
3486         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3487
3488 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
3489
3490         Unreviewed.
3491
3492         Add my new email and IRC nick to committers.py.
3493
3494         * Scripts/webkitpy/common/config/committers.py:
3495
3496 2010-06-04  Kinuko Yasuda  <kinuko@chromium.org>
3497
3498         Unreviewed.
3499
3500         Revert changes in json_results_generator.py's _get_svn_revision.
3501
3502         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3503
3504 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
3505
3506         Reviewed by Xan Lopez.
3507
3508         [GTK] GtkLauncher should support relative file paths
3509         https://bugs.webkit.org/show_bug.cgi?id=39944
3510
3511         Allow GtkLauncher to handle relative file paths passed via command-line arguments.
3512
3513         * GtkLauncher/main.c:
3514         (filename_to_url): Added.
3515         (main): Try to resolve arguments as relative file URLs first.
3516
3517 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
3518
3519         Reviewed by Xan Lopez.
3520
3521         [GTK] EventSender should call gtk_main_do_event instead of invoking signal handlers directly
3522         https://bugs.webkit.org/show_bug.cgi?id=40182
3523
3524         Instead of invoking signal handlers directly via g_signal_emit_by_name, call
3525         gtk_main_do_event. This will allow us to call gtk_get_current_event() in WebKit
3526         without breaking DRT.
3527
3528         * DumpRenderTree/gtk/EventSender.cpp:
3529         (dispatchEvent): Use gtk_main_do_event instead of invoking signal handlers directly.
3530         (keyDownCallback): Use dispatchEvent here which now uses gtk_main_do_event.
3531
3532 2010-06-04  Anders Carlsson  <andersca@apple.com>
3533
3534         Reviewed by David Hyatt.
3535
3536         Make the editing/spelling/context-menu-suggestions.html test more robust
3537         https://bugs.webkit.org/show_bug.cgi?id=40178
3538
3539         Change the contextClick method to return an array of strings describing the context menu items.
3540
3541         * DumpRenderTree/mac/EventSendingController.mm:
3542         (+[EventSendingController isSelectorExcludedFromWebScript:]):
3543         (+[EventSendingController webScriptNameForSelector:]):
3544         (-[EventSendingController contextClick]):
3545
3546 2010-06-03  Kinuko Yasuda  <kinuko@chromium.org>
3547
3548         Reviewed by Shinichiro Hamaji.
3549
3550         Clean up chromium-specific code from json_results_generator.py.
3551         https://bugs.webkit.org/show_bug.cgi?id=39665
3552
3553         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3554         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3555         * Scripts/webkitpy/layout_tests/port/base.py:
3556         * Scripts/webkitpy/layout_tests/port/chromium.py:
3557
3558 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
3559
3560         Reviewed by Adam Barth.
3561
3562         Utilize new takeFirst() method where appropriate.
3563         https://bugs.webkit.org/show_bug.cgi?id=40089
3564
3565         * DumpRenderTree/chromium/EventSender.cpp:
3566         (EventSender::replaySavedEvents):
3567         * DumpRenderTree/chromium/LayoutTestController.cpp:
3568         (LayoutTestController::WorkQueue::processWork):
3569         (LayoutTestController::WorkQueue::reset):
3570
3571 2010-06-04  Yael Aharon  <yael.aharon@nokia.com>
3572
3573         Reviewed by Simon Hausmann.
3574
3575         [Qt] QtTestLauncher should allow notifications by default.
3576         https://bugs.webkit.org/show_bug.cgi?id=40078
3577
3578         * QtTestBrowser/main.cpp:
3579         (NotificationsPermissionController::NotificationsPermissionController):
3580         (NotificationsPermissionController::checkPermission):
3581         (NotificationsPermissionController::requestPermission):
3582         (LauncherWindow::LauncherWindow):
3583
3584 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
3585
3586         Reviewed by Adam Barth.
3587
3588         Detect whether the user's environment can open a browser.
3589         https://bugs.webkit.org/show_bug.cgi?id=40136
3590
3591         Some environments like cygwin silently fail webbrowser.open() causing
3592         webkit-patch upload not to display any diff. This detects environments
3593         where webbrowser.open() would fail by testing if webbrowser.get()
3594         raises an exception.
3595
3596         * Scripts/webkitpy/common/system/user.py:
3597         * Scripts/webkitpy/tool/mocktool.py:
3598         * Scripts/webkitpy/tool/steps/confirmdiff.py:
3599
3600 2010-06-03  Tony Gentilcore  <tonyg@chromium.org>
3601
3602         Reviewed by David Levin.
3603
3604         Add dependencies required to link with VS Express 2005.
3605         https://bugs.webkit.org/show_bug.cgi?id=40038
3606
3607         Visual Studio implicitly links against these libs.
3608         VC++ Express does not.
3609
3610         * WebKitAPITest/WebKitAPITestCommon.vsprops:
3611         * WinLauncher/WinLauncher.vcproj:
3612
3613 2010-06-03  Fumitoshi Ukai  <ukai@chromium.org>
3614
3615         Reviewed by David Levin.
3616
3617         bad codecs.open in webkitpy/layout_tests/ports/websocket_server.py
3618         https://bugs.webkit.org/show_bug.cgi?id=40105
3619
3620         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
3621         - kill pywebsocket process when url is not alive and the process is not
3622           terminated, not to leave pywebsocket server running.
3623         - fix codecs.open parameters.
3624
3625 2010-06-03  Fumitoshi Ukai  <ukai@chromium.org>
3626
3627         Reviewed by Alexey Proskuryakov.
3628
3629         old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
3630         https://bugs.webkit.org/show_bug.cgi?id=39058
3631
3632         * Scripts/ensure-valid-python: