2010-04-28 Eric Seidel <eric@webkit.org>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-04-28  Eric Seidel  <eric@webkit.org>
2
3         Reviewed by Shinichiro Hamaji.
4
5         wdiff_text throws ScriptError because wdiff returns non-zero when files differ
6         https://bugs.webkit.org/show_bug.cgi?id=38246
7
8         wdiff returns 0 when files are the same, 1 when they differ.
9         run_command by default raises ScriptError if the return code is non-zero.
10         Fixed this by adding a custom error handler which only raises if the
11         return code is not 1.
12
13         I broke up the huge wdiff_text() method into little pieces
14         for easier unit testing.  There is only one functional change here
15         and that is the addition of the custom error handler.
16
17         * Scripts/webkitpy/layout_tests/port/base.py:
18         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
19
20 2010-04-28  Fumitoshi Ukai  <ukai@chromium.org>
21
22         Unreviewed build fix.
23
24         * DumpRenderTree/chromium/TestShell.cpp:
25         (TestShell::dumpImage): format '%u' expects type 'unsigned int', but argument 2 has type 'size_t'.
26         * DumpRenderTree/chromium/WebViewHost.cpp:
27         (WebViewHost::willSendRequest): too few arguments for format.
28
29 2010-04-27  Shinichiro Hamaji  <hamaji@chromium.org>
30
31         Reviewed by Darin Adler and Eric Seidel.
32
33         Add layoutTestController.setPrinting()
34         https://bugs.webkit.org/show_bug.cgi?id=37203
35
36         * DumpRenderTree/LayoutTestController.cpp:
37         (LayoutTestController::LayoutTestController):
38         (setPrintingCallback):
39         (LayoutTestController::staticFunctions):
40         * DumpRenderTree/LayoutTestController.h:
41         (LayoutTestController::isPrinting):
42         (LayoutTestController::setIsPrinting):
43         * DumpRenderTree/mac/DumpRenderTree.mm:
44         (dump):
45
46 2010-04-27  Michael Nordman  <michaeln@google.com>
47
48         Reviewed by Dmitry Titov.
49
50         [Chromium] Add two things to the webkit API to support appcaches in workers.
51         1) WebURLRequest TargetTypes for worker and shared worker main resources.
52         2) Factory method on class WebCommonWorkerClient to
53            createApplicationCacheHost() for the associated worker.
54
55         https://bugs.webkit.org/show_bug.cgi?id=38147
56
57         * DumpRenderTree/chromium/TestWebWorker.h add a stub impl of the factory method 
58         (TestWebWorker::createApplicationCacheHost):
59
60 2010-04-27  Adam Barth  <abarth@webkit.org>
61
62         Reviewed by Eric Seidel.
63
64         run-bindings-tests doesn't work in an SVN checkout
65         https://bugs.webkit.org/show_bug.cgi?id=38225
66
67         Previously detect_scm_system needed an absolute path for SVN.  Now we
68         accept a relative path.
69
70         * Scripts/webkitpy/common/checkout/scm.py:
71         * Scripts/webkitpy/common/checkout/scm_unittest.py:
72
73 2010-04-27  Sam Weinig  <sam@webkit.org>
74
75         Reviewed by Stephanie Lewis.
76
77         Always build WebKit2 when building on SnowLeopard and later. 
78
79         * Scripts/build-webkit:
80
81 2010-04-27  Sam Weinig  <sam@webkit.org>
82
83         Reviewed by Maciej Stachowiak.
84
85         Fix for https://bugs.webkit.org/show_bug.cgi?id=38238
86         Allow both WebKit and WebKit2 to link to the same WebCore.framework
87
88         * Scripts/build-webkit: Remove the UMBRELLA_LDFLAGS override when building
89         WebCore for WebKit2, it is no longer necessary.
90
91 2010-04-27  James Robinson  <jamesr@chromium.org>
92
93         Reviewed by David Levin.
94
95         Fix a typo in chromium.py that causes NRWT to fail in --verbose
96         mode in a Chromium checkout.
97         https://bugs.webkit.org/show_bug.cgi?id=38234
98
99         * Scripts/webkitpy/layout_tests/port/chromium.py:
100
101 2010-04-27  Darin Fisher  <darin@chromium.org>
102
103         Reviewed by Dimitri Glazkov.
104
105         [Chromium] Remove deprecated form of didChangeLocationWithinPage
106         https://bugs.webkit.org/show_bug.cgi?id=38178
107
108         Switch over to implementing didNavigateWithinPage.
109
110         * DumpRenderTree/chromium/WebViewHost.cpp:
111         (TestWebViewDelegate::didNavigateWithinPage):
112         (WebViewHost::didChangeLocationWithinPage):
113         * DumpRenderTree/chromium/WebViewHost.h:
114
115 2010-04-27  Evan Martin  <evan@chromium.org>
116
117         Unreviewed.
118
119         Adding myself to commmitters list.
120
121         * Scripts/webkitpy/common/config/committers.py:
122
123 2010-04-27  Adam Barth  <abarth@webkit.org>
124
125         Reviewed by Darin Adler.
126
127         run-bindings-tests should use --reset-results instead of --overwrite
128         https://bugs.webkit.org/show_bug.cgi?id=38200
129
130         As requested by Ojan.
131
132         * Scripts/run-bindings-tests:
133
134 2010-04-27  Adam Barth  <abarth@webkit.org>
135
136         Reviewed by Eric Seidel.
137
138         REGRESSION(r58261): webkit-patch edit-changelogs is broken
139         https://bugs.webkit.org/show_bug.cgi?id=38204
140
141         In 58261, we added code to abstract step that interrogates the squash
142         and git_commit options, but it doesn't declare that it uses those
143         options.  That means any command that doesn't happen to declare those
144         options might be broken if it uses the cached_lookup mechanism.
145
146         * Scripts/webkitpy/tool/steps/abstractstep.py:
147         * Scripts/webkitpy/tool/steps/applypatch.py:
148         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
149         * Scripts/webkitpy/tool/steps/build.py:
150         * Scripts/webkitpy/tool/steps/checkstyle.py:
151         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
152         * Scripts/webkitpy/tool/steps/closebug.py:
153         * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
154         * Scripts/webkitpy/tool/steps/commit.py:
155         * Scripts/webkitpy/tool/steps/confirmdiff.py:
156         * Scripts/webkitpy/tool/steps/createbug.py:
157         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
158         * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
159         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
160         * Scripts/webkitpy/tool/steps/postcodereview.py:
161         * Scripts/webkitpy/tool/steps/postdiff.py:
162         * Scripts/webkitpy/tool/steps/preparechangelog.py:
163         * Scripts/webkitpy/tool/steps/runtests.py:
164         * Scripts/webkitpy/tool/steps/update.py:
165         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
166         * Scripts/webkitpy/tool/steps/validatereviewer.py:
167
168 2010-04-27  Eric Seidel  <eric@webkit.org>
169
170         Reviewed by David Levin.
171
172         prepare-ChangeLog --bug fails on some CYGWIN installs due to missing certs
173         https://bugs.webkit.org/show_bug.cgi?id=38212
174
175         * Scripts/prepare-ChangeLog:
176          - Pass --insecure to curl to work around CYGWIN missing certs.
177
178 2010-04-27  Sam Weinig  <sam@webkit.org>
179
180         Rubber-stamped by Beth Dakin.
181
182         It is no longer necessary to set ENABLE_EXPERIMENTAL_SINGLE_VIEW_MODE
183         or WTF_USE_WEB_THREAD. Remove them.
184
185         * Scripts/build-webkit:
186
187 2010-04-27  Chris Jerdonek  <cjerdonek@webkit.org>
188
189         Reviewed by David Levin.
190
191         Changed Chris Jerdonek from committer to reviewer.
192
193         * Scripts/webkitpy/common/config/committers.py:
194
195 2010-04-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
196
197         Reviewed by Kenneth Rohde Christiansen.
198
199         [Qt] QGraphicsWebView: Arrow keys scroll the graphics-view instead of the web-page
200         https://bugs.webkit.org/show_bug.cgi?id=35834
201
202         The scene should always have the size of the web view otherwhise it is
203         possible to scroll the graphics view.
204
205         * QtLauncher/webview.cpp:
206         (WebViewGraphicsBased::resizeEvent):
207
208 2010-04-27  Diego Gonzalez  <diegohcg@webkit.org>
209
210         Unreviewed.
211
212         Adding myself to committers.py
213
214         * Scripts/webkitpy/common/config/committers.py:
215
216 2010-04-27  Eric Seidel  <eric@webkit.org>
217
218         Reviewed by Adam Barth.
219
220         [chromium] new-run-webkit-tests hangs on Chromium Bots (OS X and Linux)
221         https://bugs.webkit.org/show_bug.cgi?id=37987
222
223         After further research, I believe the hang is caused by:
224         http://bugs.python.org/issue2320
225         Basically Popen() is not reentrant.
226         The workaround is to pass close_fds=True to Popen() on Mac/Linux.
227
228         I fixed our main Popen wrapper "Executive.run_command" to use close_fds=True
229         when appropriate.
230
231         I audited all places we call Popen() and either moved them to run_command
232         or left a FIXME that they are not thread safe.  A few places I added the
233         close_fds workaround there and left an explanitory note.
234
235         * Scripts/webkitpy/common/checkout/scm_unittest.py:
236          - Added note that this Popen use is not threadsafe.
237         * Scripts/webkitpy/common/system/executive.py:
238          - Fixed our Executive.run_* to workaround python bug 2320.
239         * Scripts/webkitpy/common/system/user.py:
240          _ Added note that this Popen use is not threadsafe.
241         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: ditto.
242         * Scripts/webkitpy/layout_tests/port/apache_http_server.py: ditto.
243         * Scripts/webkitpy/layout_tests/port/base.py:
244          - Change wdiff back to using run_command now that we believe it
245            to be threadsafe.
246         * Scripts/webkitpy/layout_tests/port/chromium.py:
247          - Fix to use Executive in places.
248          - Pass self._executive down to the Driver for easier unit testing.
249         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
250          - Re-factor to use a _kill_all method.
251          - Made the _kill_all method use run_command to be threadsafe.
252         * Scripts/webkitpy/layout_tests/port/http_server.py:
253          - Add FIXME about using Executive.
254         * Scripts/webkitpy/layout_tests/port/server_process.py:
255          - Use Executive to be threadsafe.
256         * Scripts/webkitpy/layout_tests/port/webkit.py:
257          - Pass self._executive down to the Driver.
258         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
259          - Add note about Popen not being threadsafe.
260         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
261          - Move one caller to run_command add notes about moving others.
262
263 2010-04-27  Adam Barth  <abarth@webkit.org>
264
265         Reviewed by Maciej Stachowiak.
266
267         REGRESSION(r58261): webkit-patch upload does not work in an SVN checkout.
268         https://bugs.webkit.org/show_bug.cgi?id=38186
269
270         Unfortunately, we don't have a good way of testing this change because
271         our test coverage of the scm.py API is poor...
272
273         * Scripts/webkitpy/common/checkout/scm.py:
274         * Scripts/webkitpy/tool/steps/preparechangelog.py:
275
276 2010-04-26  Eric Seidel  <eric@webkit.org>
277
278         Reviewed by Adam Barth.
279
280         Remove unused code from text_diff.py
281         https://bugs.webkit.org/show_bug.cgi?id=38170
282
283         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
284          - Remove is_render_tree_dump which appears unused.
285
286 2010-04-26  Adam Barth  <abarth@webkit.org>
287
288         Reviewed by Eric Seidel.
289
290         webkit-patch pretty-diff is broken
291         https://bugs.webkit.org/show_bug.cgi?id=38172
292
293         We need to register for these options because they're used when we look
294         up the diff.
295
296         * Scripts/webkitpy/tool/steps/confirmdiff.py:
297
298 2010-04-26  Adam Barth  <abarth@webkit.org>
299
300         Reviewed by Eric Seidel.
301
302         Add ObjC and GObject to run-bindings-test
303         https://bugs.webkit.org/show_bug.cgi?id=38168
304
305         * Scripts/run-bindings-tests:
306
307 2010-04-26  Adam Barth  <abarth@webkit.org>
308
309         Reviewed by Eric Seidel.
310
311         Add testing infrastructure for JSC bindings generator
312         https://bugs.webkit.org/show_bug.cgi?id=38167
313
314         Add support for testing more than one bindings.  Also, converted the
315         script to PEP8 style.
316
317         * Scripts/run-bindings-tests:
318
319 2010-04-26  Eric Seidel  <eric@webkit.org>
320
321         Reviewed by Adam Barth.
322
323         Refactor results.html generation out into a new method and test it
324         https://bugs.webkit.org/show_bug.cgi?id=38164
325
326         Hopefully this results in no change in functionality.
327
328         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
329         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
330
331 2010-04-26  Adam Barth  <abarth@webkit.org>
332
333         Unreviewed, rolling out r58265.
334         http://trac.webkit.org/changeset/58265
335         https://bugs.webkit.org/show_bug.cgi?id=38021
336
337         This change prevents me from uploading patches.  It also breaks sheriff-bot.
338
339         * Scripts/webkitpy/tool/steps/options.py:
340
341 2010-04-26  Eric Seidel  <eric@webkit.org>
342
343         Reviewed by Adam Barth.
344
345         [chromium] new-run-webkit-tests hangs on Chromium Bots (OS X and Linux)
346         https://bugs.webkit.org/show_bug.cgi?id=37987
347
348         Rolled out:
349         http://trac.webkit.org/changeset/58062
350         http://trac.webkit.org/changeset/58060
351         http://trac.webkit.org/changeset/58059
352         http://trac.webkit.org/changeset/58055
353         http://trac.webkit.org/changeset/58054
354         and parts of:
355         http://trac.webkit.org/changeset/58050
356
357         I also wrote some new comments and a tiny amount of new
358         code to help make ChromiumDriver.run_test easier to read.
359
360         In order to unit-test my new code, I had to change ChromiumDriver
361         to not automatically start itself when created.  That ended up
362         being a lot of plumbing, but is hopefully easier to understand now.
363
364         There are no tests for the (restored) wdiff code.  wdiff does not
365         exist on all systems, so for now we will assume it worked since
366         it is just old code being reverted.
367
368          * Scripts/webkitpy/layout_tests/driver_test.py:
369           - Use create_driver instead of start_driver, and be sure to call .stop()
370          * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
371           - Use create_driver instead of start_driver
372          * Scripts/webkitpy/layout_tests/port/base.py:
373           - Added a comment to explain that diffs are binary files.
374           - Various patch reverts relating to wdiff
375           - Add Driver._command_wrapper to share code between WebKitDriver and ChromiumDriver.
376           - Made _command_wrapper use shlex.split to get rid of the FIXME.
377          * Scripts/webkitpy/layout_tests/port/base_unittest.py: Added.
378           - test the new _command_wrapper
379          * Scripts/webkitpy/layout_tests/port/chromium.py:
380          - Use _command_wrapper to get rid of a bunch of ugly code.
381          - Make __init__ stop auto-starting.
382          - Rename create_driver to start_driver.
383          - Added _write_command_and_read_line to make it possible to
384            put a FIXME next to read_line() w/o having to put it in two places.
385          - Moved test_shell command building into _test_shell_command and tested it.
386          - Fix comments to say test_shell since ChromiumDriver is test_shell only.
387          * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Added.
388           - Test the new test_shell_command method.
389          * Scripts/webkitpy/layout_tests/port/dryrun.py:
390           - Rename create_driver to start_driver.
391          * Scripts/webkitpy/layout_tests/port/test.py:
392           - Rename create_driver to start_driver.
393          * Scripts/webkitpy/layout_tests/port/webkit.py:
394           - Rename create_driver to start_driver.
395           - Treat output as binary arrays.
396          * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
397           - Treat diff files as binary.
398          * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
399           - Treat diff files as binary.
400
401 2010-04-26  Adam Barth  <abarth@webkit.org>
402
403         Reviewed by Eric Seidel.
404
405         Move bindings test directory into the scripts directory
406         https://bugs.webkit.org/show_bug.cgi?id=38161
407
408         Change script to point to the new location of these data files.
409
410         * Scripts/run-bindings-tests:
411
412 2010-04-26  Adam Barth  <abarth@webkit.org>
413
414         Unreviewed.  Mark run-bindings-tests executable so we can execute it.
415
416         * Scripts/run-bindings-tests:
417
418 2010-04-26  Tony Chang  <tony@chromium.org>
419
420         Reviewed by David Levin.
421
422         [chromium] build-webkit --chromium should build release by default
423         https://bugs.webkit.org/show_bug.cgi?id=38028
424
425         * Scripts/build-dumprendertree: Also should build release by default
426         * Scripts/build-webkit: Make sure to pass command line args through
427         * Scripts/webkitdirs.pm: Build the right configuration
428
429 2010-04-26  Ojan Vafai  <ojan@chromium.org>
430
431         Reviewed by Eric Seidel.
432
433         complete rietveld bugzilla integration
434         https://bugs.webkit.org/show_bug.cgi?id=38021
435
436         Makes --fancy-review the default. All this means is that the patch will
437         be uploaded to rietveld in addition to bugs.webkit.org. 
438
439         * Scripts/webkitpy/tool/steps/options.py:
440
441 2010-04-26  Chris Jerdonek  <cjerdonek@webkit.org>
442
443         Reviewed by Shinichiro Hamaji.
444
445         For check-webkit-style, renamed the style/processors/ directory
446         to style/checkers/.
447
448         https://bugs.webkit.org/show_bug.cgi?id=38122
449
450         * Scripts/webkitpy/style/checker.py:
451           - Updated import statements.
452
453         * Scripts/webkitpy/style/checker_unittest.py:
454           - Updated import statements.
455
456         * Scripts/webkitpy/style/checkers: Copied from WebKitTools/Scripts/webkitpy/style/processors.
457         * Scripts/webkitpy/style/processors: Removed.
458         * Scripts/webkitpy/style/processors/__init__.py: Removed.
459         * Scripts/webkitpy/style/processors/common.py: Removed.
460         * Scripts/webkitpy/style/processors/common_unittest.py: Removed.
461         * Scripts/webkitpy/style/processors/cpp.py: Removed.
462         * Scripts/webkitpy/style/processors/cpp_unittest.py: Removed.
463         * Scripts/webkitpy/style/processors/python.py: Removed.
464         * Scripts/webkitpy/style/processors/python_unittest.py: Removed.
465         * Scripts/webkitpy/style/processors/python_unittest_input.py: Removed.
466         * Scripts/webkitpy/style/processors/text.py: Removed.
467         * Scripts/webkitpy/style/processors/text_unittest.py: Removed.
468
469 2010-04-06  Ojan Vafai  <ojan@chromium.org>
470
471         Reviewed by Adam Barth.
472
473         Include git commits in the diff for webkit-patch upload/land.
474         https://bugs.webkit.org/show_bug.cgi?id=36394
475
476         Adds --squash, --no-squash and --git-commit.
477
478         --git-commit will use a specific local commit for land/upload.
479         If a commit-range is specified, then that range is treated as
480         a single squashed commit.
481
482         --squash will squash all local changes including working copy changes
483         into a single patch.
484
485         --no-squash is the legacy behavior (upload only considers the working copy,
486         land commits the working copy and then each local commit separately to SVN)
487
488         If neither is specified, then an informative error is raised if there is
489         more than one local commit or when there are local commit(s) and working
490         copy changes.
491
492         If the webkit-patch.squash git config parameter is set, then
493         that will be respected instead of raising an error.
494
495         * Scripts/check-webkit-style:
496         * Scripts/webkitpy/common/checkout/api.py:
497         * Scripts/webkitpy/common/checkout/api_unittest.py:
498         * Scripts/webkitpy/common/checkout/scm.py:
499         * Scripts/webkitpy/common/checkout/scm_unittest.py:
500         * Scripts/webkitpy/style/optparser.py:
501         --git-since is removed and --git-commit no longer implies commit_id..
502         Instead, it treats that individual commit, but also supports commit ranges
503         (e.g. commit_id..) as arguments.
504         * Scripts/webkitpy/style/optparser_unittest.py:
505         * Scripts/webkitpy/style_references.py:
506         * Scripts/webkitpy/tool/commands/download.py:
507         * Scripts/webkitpy/tool/commands/upload.py:
508         * Scripts/webkitpy/tool/main.py:
509         * Scripts/webkitpy/tool/mocktool.py:
510         * Scripts/webkitpy/tool/steps/abstractstep.py:
511         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
512         * Scripts/webkitpy/tool/steps/checkstyle.py:
513         * Scripts/webkitpy/tool/steps/commit.py:
514         * Scripts/webkitpy/tool/steps/options.py:
515         * Scripts/webkitpy/tool/steps/postdiff.py:
516         * Scripts/webkitpy/tool/steps/preparechangelog.py:
517         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
518         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
519         * Scripts/webkitpy/tool/steps/validatereviewer.py:
520
521 2010-04-26  Chris Jerdonek  <cjerdonek@webkit.org>
522
523         Reviewed by Shinichiro Hamaji.
524
525         Deleted the StyleChecker-related classes that are no longer
526         being used.
527
528         https://bugs.webkit.org/show_bug.cgi?id=38118
529
530         * Scripts/webkitpy/style/checker.py:
531           - Deleted the DeprecatedStyleChecker class.
532
533         * Scripts/webkitpy/style/checker_unittest.py:
534           - Deleted the StyleCheckerTest, StyleCheckerCheckFileBase,
535             StyleCheckerCheckFileTest, and StyleCheckerCheckPathsTest classes.
536
537 2010-04-26  Chris Jerdonek  <cjerdonek@webkit.org>
538
539         Reviewed by Shinichiro Hamaji.
540
541         Changed the StyleChecker class to use the new TextFileReader class.
542
543         https://bugs.webkit.org/show_bug.cgi?id=37066
544
545         This revision separates the code responsible for reading and iterating
546         over text files from the rest of check-webkit-style.
547
548         * Scripts/check-webkit-style:
549           - Changed the script to use the new StyleProcessor and
550             TextFileReader classes instead of the StyleChecker class.
551
552         * Scripts/webkitpy/style/checker.py:
553           - Added a FIXME to rename many of uses of the word "processor" to
554             "checker".  We did this to clarify the difference between
555             ProcessorBase instances passed to the TextFileReader and
556             classes that process and check lines for style.
557           - Added a FIXME to remove FileType.NONE as a possible return value
558             of ProcessorDispatcher._file_type().  This will better consolidate
559             the logic of which files should be skipped.
560           - Added a FIXME to delete the StyleChecker class.
561           - Added the StyleProcessor class which implements ProcessorBase.
562             This class is responsible for processing lines to check style
563             (but not for reading files).  For each file, this class creates
564             creates both a carriage-return checker and a format-specific
565             style checker (e.g. one of C++, Python, etc).
566           - Updated the PatchChecker class to use a TextFileReader instance
567             instead of a StyleChecker.
568
569         * Scripts/webkitpy/style/checker_unittest.py:
570           - Added the StyleProcessor_EndToEndTest class to do "end-to-end"
571             tests of the StyleProcessor class.
572           - Added the StyleProcessor_CodeCoverageTest to test the
573             StyleProcessor class with more complete code coverage.
574             Unlike the StyleProcessor_EndToEndTest class, this class makes
575             heavy use of mock parameters.
576           - Added FIXME's to delete the unit test classes that are no
577             longer needed.
578           - Updated the PatchCheckerTest class to use a MockTextFileReader
579             instead of a MockStyleChecker.
580
581         * Scripts/webkitpy/style/filereader.py:
582           - Updated the TextFileReader class to use the preferred logic
583             of checking file existence at the beginning of the process_file()
584             method instead of in the except block, per
585             https://bugs.webkit.org/show_bug.cgi?id=37122
586
587         * Scripts/webkitpy/style/filereader_unittest.py:
588           - In the TextFileReaderTest class:
589             - Moved the test_process_file__should_not_process() method.
590             - Added a test_process_file__file_stdin() method to test
591               the file path "-".
592
593 2010-04-20  Robert Hogan  <robert@webkit.org>
594
595         Reviewed by Simon Hausmann.
596
597         [Qt] Add more support for textInputController
598
599         Add support for selectedRange(), setMarkedText(), insertText(),
600         and firstRectForCharacterRange().
601
602         Unskip tests:
603
604         fast/forms/input-maxlength-ime-preedit.html
605         fast/forms/input-maxlength-ime-completed.html
606         fast/text/international/thai-cursor-position.html
607         fast/events/ime-composition-events-001.html
608         editing/selection/5825350-1.html
609         editing/selection/5825350-2.html
610         editing/selection/mixed-editability-10.html
611
612         https://bugs.webkit.org/show_bug.cgi?id=35702
613
614         * DumpRenderTree/qt/TextInputControllerQt.cpp:
615         (TextInputController::setMarkedText):
616         (TextInputController::insertText):
617         (TextInputController::selectedRange):
618         (TextInputController::firstRectForCharacterRange):
619         * DumpRenderTree/qt/TextInputControllerQt.h:
620
621 2010-04-23  Eric Seidel  <eric@webkit.org>
622
623         Reviewed by Adam Barth.
624
625         check-webkit-style complains about non-utf8 data in layout test result
626         https://bugs.webkit.org/show_bug.cgi?id=38027
627
628         The problem was we were assuming patch files/diff output as utf-8.
629         Turns out they're not.  We have to treat them as binary data because
630         a single patch may have multiple text files in it with conflicting encodings!
631
632         * Scripts/webkitpy/common/checkout/api.py:
633          - contents_at_revision returns a byte array, so decode it to unicode
634            before passing it to parse_latest_entry_from_file
635         * Scripts/webkitpy/common/checkout/api_unittest.py:
636          - Update our mock mock_contents_at_revision to match the encoding
637            semantics of the real one.
638         * Scripts/webkitpy/common/checkout/scm.py:
639          - Be careful not to decode output which may contain file contents
640            (like diff, cat or show) as the encoding for that content is unknown.
641         * Scripts/webkitpy/common/checkout/scm_unittest.py:
642          - Update our tests to use both latin1 and utf-8 encoded data.
643         * Scripts/webkitpy/common/net/bugzilla.py:
644          - _fill_attachment_form should not assume unicode data.  Callers
645            may wish to attach other types of files to bugs.
646         * Scripts/webkitpy/common/prettypatch.py:
647          - Diffs are byte arrays, deal with them as such.
648         * Scripts/webkitpy/common/prettypatch_unittest.py:
649          - Test to make sure we handle diffs with multiple conflicting encodings.
650         * Scripts/webkitpy/common/system/executive_unittest.py:
651          - Make sure that our unicode support does not break our
652            byte array input support for run_command.
653
654 2010-04-23  Sam Weinig  <sam@webkit.org>
655
656         Reviewed by David Levin.
657
658         Fix for https://bugs.webkit.org/show_bug.cgi?id=38060
659         Split up Threading.h
660
661         Add necessary forwarding headers.
662
663         * DumpRenderTree/ForwardingHeaders/wtf/Atomics.h: Added.
664         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h: Added.
665         * DumpRenderTree/ForwardingHeaders/wtf/ThreadingPrimitives.h: Added.
666
667 2010-04-23  Xiaomei Ji  <xji@chromium.org>
668
669         No need to review.
670
671         Add xji as committer.
672
673         * Scripts/webkitpy/common/config/committers.py:
674
675 2010-04-23  Kevin Ollivier  <kevino@theolliviers.com>
676
677         [wx] Build fix, add platform stub for new LayoutTestController method.
678
679         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
680         (LayoutTestController::markerTextForListItem):
681
682 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
683
684         Reviewed by Adam Barth.
685
686         new-run-webkit-tests: add a "--retry-failures" flag and a
687         "--no-retry-failures" flag (the former is the default). Also, rename
688         "--print-unexpected-results" and "--retry-unexpected-results" to
689         "--print-last-failures" and "--retry-last-failures" because the
690         retry flag was confusing. The new flag names aren't great, but
691         hopefully they're less confusing.
692
693         https://bugs.webkit.org/show_bug.cgi?id=37838
694
695         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
696
697 2010-04-22  Sam Weinig  <sam@webkit.org>
698
699         Reviewed by Anders Carlsson.
700
701         Fix for https://bugs.webkit.org/show_bug.cgi?id=38022
702         Move isMainThread predicate function to MainThread.h
703
704         Added forwarding header for MainThread.h
705
706         * DumpRenderTree/ForwardingHeaders/wtf/MainThread.h: Added.
707
708 2010-04-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
709
710         Reviewed by Kenneth Rohde Christiansen.
711
712         [Qt] Disable Netscape plugin support for minimal configuration
713         https://bugs.webkit.org/show_bug.cgi?id=38026
714
715         Pass the minimal configuration option to Qt build system 
716         as part of the CONFIG variable.
717
718         * Scripts/build-webkit:
719
720 2010-04-22  Fumitoshi Ukai  <ukai@chromium.org>
721
722         Unreviewed fix.
723
724         * Scripts/webkitpy/layout_tests/port/websocket_server.py: fix NameError: global name 'f' is not defined.
725
726 2010-04-22  James Robinson  <jamesr@chromium.org>
727
728         Reviewed by Adam Barth.
729
730         Revert 58077 and follow-ups.  It's broken.
731         https://bugs.webkit.org/show_bug.cgi?id=37664
732
733         * Scripts/new-run-webkit-httpd:
734         * Scripts/new-run-webkit-websocketserver:
735         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
736         * Scripts/webkitpy/layout_tests/port/http_server.py:
737         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
738
739 2010-04-22  Yaar Schnitman  <yaar@chromium.org>
740
741         Reviewed by Adam Barth.
742
743         Integrate v8 testing utility with webkit tests
744         https://bugs.webkit.org/show_bug.cgi?id=37731
745
746         * Scripts/run-bindings-tests: Added.
747
748 2010-04-22  Eric Seidel  <eric@webkit.org>
749
750         Reviewed by Dimitri Glazkov.
751
752         new-run-webkit-tests --verbose shows ever-increasing #EOF lines
753         https://bugs.webkit.org/show_bug.cgi?id=37794
754
755         * Scripts/webkitpy/layout_tests/port/webkit.py:
756          - Remove the assert() since our ServerProcess code does not always
757            seem to be reading the full stderr output (or we're not waiting for it to).
758
759 2010-04-22  Eric Seidel  <eric@webkit.org>
760
761         Reviewed by Adam Barth.
762
763         Add code to help debug new-run-webkit-test hangs on the Chromium bots
764         https://bugs.webkit.org/show_bug.cgi?id=38011
765
766         I can see no reasonable way to test this change.
767         Stubbing out sys._current_frames() and traceback.extract_stack
768         seems folly.  Dumping real data would have line number
769         (and possibly other call stack) variance between runs.
770
771         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
772          - Add _dump_thread_states and _dump_thread_states_if_necessary
773            to have our main thread dump the states of all threads every
774            60 seconds when running in verbose mode.
775          - Better document what is going on in our main loop.
776
777 2010-04-22  Sam Weinig  <sam@webkit.org>
778
779         Reviewed by Anders Carlsson.
780
781         Fix for https://bugs.webkit.org/show_bug.cgi?id=38002
782         Add rudimentary statistics gathering for WebKit2
783
784         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
785         * MiniBrowser/mac/AppDelegate.h:
786         * MiniBrowser/mac/AppDelegate.m:
787         (-[BrowserAppDelegate init]):
788         (-[BrowserAppDelegate newWindow:]):
789         (-[BrowserAppDelegate getCurrentPageNamespace]):
790         (-[BrowserAppDelegate _setProcessModel:]):
791         (-[BrowserAppDelegate showStatisticsWindow:]):
792         (-[BrowserAppDelegate applicationWillTerminate:]):
793         * MiniBrowser/mac/BrowserStatisticsWindow.xib: Added.
794         * MiniBrowser/mac/BrowserStatisticsWindowController.h: Added.
795         * MiniBrowser/mac/BrowserStatisticsWindowController.m: Added.
796         (-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
797         (-[BrowserStatisticsWindowController dealloc]):
798         (-[BrowserStatisticsWindowController windowDidLoad]):
799         (-[BrowserStatisticsWindowController refreshStatistics:]):
800         * MiniBrowser/mac/BrowserWindowController.h:
801         * MiniBrowser/mac/English.lproj/MainMenu.xib:
802         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
803
804 2010-04-22  Dave Moore  <davemoore@chromium.org>
805
806         Reviewed by Dimitri Glazkov.
807
808         Add test support for icon changes.
809
810         https://bugs.webkit.org/show_bug.cgi?id=33812
811
812         * DumpRenderTree/LayoutTestController.cpp:
813         (LayoutTestController::LayoutTestController):
814         (dumpIconChangesCallback):
815         (LayoutTestController::staticFunctions):
816         * DumpRenderTree/LayoutTestController.h:
817         (LayoutTestController::dumpIconChanges):
818         (LayoutTestController::setDumpIconChanges):
819         * DumpRenderTree/win/FrameLoadDelegate.cpp:
820         (FrameLoadDelegate::didChangeIcons):
821         * DumpRenderTree/win/FrameLoadDelegate.h:
822         * WinLauncher/WinLauncher.h:
823         (WinLauncherWebHost::didChangeIcons):
824
825 2010-04-22  Eric Seidel  <eric@webkit.org>
826
827         Unreviewed.  Script fix.  Will ask dpranke to look tomorrow.
828
829         new-run-webkit-tests --verbose shows ever-increasing #EOF lines
830         https://bugs.webkit.org/show_bug.cgi?id=37794
831
832         The bots are seeing cases where .error is sometimes empty.
833         Lets make the code not crash in that case for now.
834
835         * Scripts/webkitpy/layout_tests/port/webkit.py:
836
837 2010-04-22  Fumitoshi Ukai  <ukai@chromium.org>
838
839         Unreviewed fix.
840
841         * Scripts/webkitpy/layout_tests/port/websocket_server.py: fix NameError: global name 'f' is not defined.
842
843 2010-04-22  Fumitoshi Ukai  <ukai@chromium.org>
844
845         Unreviewed fix.
846
847         * Scripts/new-run-webkit-websocketserver: PyWebSocket no longer takes keyword argument 'register_cygwin'.
848
849 2010-04-22  Eric Seidel  <eric@webkit.org>
850
851         Unreviewed.  Restore the Leopard bots to using
852         old-run-webkit-tests for now.
853
854         * Scripts/run-webkit-tests:
855
856 2010-04-22  Fumitoshi Ukai  <ukai@chromium.org>
857
858         Unreviewed fix.
859
860         * Scripts/webkitpy/layout_tests/port/http_server.py: fix NameError: global name 'env' is not defined.
861
862 2010-04-22  Fumitoshi Ukai  <ukai@chromium.org>
863
864         Unreviewed fix.
865
866         * Scripts/webkitpy/layout_tests/port/websocket_server.py: fix NameError: global name 'env' is not defined.
867
868 2010-04-22  Fumitoshi Ukai  <ukai@chromium.org>
869
870         Reviewed by Adam Barth.
871
872         Chromium: Add --chromium option to new-run-webkit-websocketserver
873         https://bugs.webkit.org/show_bug.cgi?id=37664
874
875         Move cygwin setup logic in chromium_win.py.
876
877         * Scripts/new-run-webkit-httpd: remove register_cygwin parameter to pass http_server.
878         * Scripts/new-run-webkit-websocketserver: add --chromium flag
879         * Scripts/webkitpy/layout_tests/port/chromium_win.py: setup for cygwin
880         * Scripts/webkitpy/layout_tests/port/http_server.py: remove cygwin setup logic
881         * Scripts/webkitpy/layout_tests/port/websocket_server.py: remove cygwin setup logic
882
883 2010-04-22  Eric Seidel  <eric@webkit.org>
884
885         Reviewed by Adam Barth.
886
887         new-run-webkit-tests --verbose shows ever-increasing #EOF lines
888         https://bugs.webkit.org/show_bug.cgi?id=37794
889
890         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
891          - Fix the log message to explain that this is stderr output, not test output.
892         * Scripts/webkitpy/layout_tests/port/webkit.py:
893          - Be sure to reset the server_process.error after reading (seems like the wrong
894            place to do this, but at least this fixes the bug and dpranke and I can talk
895            about better designs later).
896          - Also remove the #EOF from the stderr output before returning it.
897
898 2010-04-22  Eric Seidel  <eric@webkit.org>
899
900         Unreviewed.  Fixing new-run-webkit-tests on the bots.
901
902         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
903          - Fixing _compat_shim_option to take variable keyword args.
904          - Turns out that nargs + callback is ignored unless type is specified.
905            So I added the type so that the option was properly consumed.
906            This was why new-run-webkit-tests couldn't find any tests, it
907            was looking for them under "20" because that was the argument
908            which should have been consumed by --exit-after-n-failures.
909
910 2010-04-22  Tony Chang  <tony@chromium.org>
911
912         Not reviewed, build fix for chromium Windows.
913
914         [chromium] fix ImageDiff compile on windows
915         https://bugs.webkit.org/show_bug.cgi?id=37979
916
917         * DumpRenderTree/chromium/ImageDiff.cpp:
918
919 2010-04-22  Adam Barth  <abarth@webkit.org>
920
921         Unreviewed, rolling out r58069.
922         http://trac.webkit.org/changeset/58069
923         https://bugs.webkit.org/show_bug.cgi?id=27751
924
925         Broke compile on Windows.
926
927         * DumpRenderTree/LayoutTestController.cpp:
928         (LayoutTestController::staticFunctions):
929         * DumpRenderTree/LayoutTestController.h:
930         * DumpRenderTree/chromium/LayoutTestController.cpp:
931         (LayoutTestController::LayoutTestController):
932         (LayoutTestController::overridePreference):
933         * DumpRenderTree/chromium/LayoutTestController.h:
934         * DumpRenderTree/chromium/TestShell.cpp:
935         (TestShell::resetWebSettings):
936         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
937         * DumpRenderTree/mac/DumpRenderTree.mm:
938         (resetDefaultsToConsistentValues):
939         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
940         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
941         (WebCore::WebPage::WebPage):
942         (WebCore::WebPage::resetSettings):
943         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
944         * DumpRenderTree/qt/LayoutTestControllerQt.h:
945         * DumpRenderTree/win/DumpRenderTree.cpp:
946         (resetDefaultsToConsistentValues):
947         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
948         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
949
950 2010-04-22  Eric Seidel  <eric@webkit.org>
951
952         Unreviewed.  Just adding logging.
953
954         Adding logging to help debug why the Leopard Bot
955         can't find any tests to run.
956
957         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
958         * Scripts/webkitpy/layout_tests/port/base.py:
959         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
960          - Make it a fatal error to have no tests to run.
961
962 2010-04-22  Abhishek Arya  <inferno@chromium.org>
963
964         Reviewed by Adam Barth.
965
966         Add support for controlling clipboard access from javascript.
967         Clipboard access from javascript is enabled in test framework.
968         https://bugs.webkit.org/show_bug.cgi?id=27751
969
970         * DumpRenderTree/LayoutTestController.cpp:
971         (setJavaScriptCanAccessClipboardCallback):
972         (LayoutTestController::staticFunctions):
973         * DumpRenderTree/LayoutTestController.h:
974         * DumpRenderTree/chromium/LayoutTestController.cpp:
975         (LayoutTestController::LayoutTestController):
976         (LayoutTestController::setJavaScriptCanAccessClipboard):
977         (LayoutTestController::overridePreference):
978         * DumpRenderTree/chromium/LayoutTestController.h:
979         * DumpRenderTree/chromium/TestShell.cpp:
980         (TestShell::resetWebSettings):
981         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
982         (LayoutTestController::setJavaScriptCanAccessClipboard):
983         * DumpRenderTree/mac/DumpRenderTree.mm:
984         (resetDefaultsToConsistentValues):
985         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
986         (LayoutTestController::setJavaScriptCanAccessClipboard):
987         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
988         (WebCore::WebPage::WebPage):
989         (WebCore::WebPage::resetSettings):
990         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
991         (LayoutTestController::setJavaScriptCanAccessClipboard):
992         * DumpRenderTree/qt/LayoutTestControllerQt.h:
993         * DumpRenderTree/win/DumpRenderTree.cpp:
994         (resetDefaultsToConsistentValues):
995         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
996         (LayoutTestController::setJavaScriptCanAccessClipboard):
997         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
998         (LayoutTestController::setJavaScriptCanAccessClipboard):
999
1000 2010-04-21  Adam Barth  <abarth@webkit.org>
1001
1002         Reviewed by Eric Seidel.
1003
1004         webkit-patch can't fetch attachments on security bugs
1005         https://bugs.webkit.org/show_bug.cgi?id=37975
1006
1007         Instead of calling CURL, we just need to use our Mechanize object,
1008         which understand bugs.webkit.org authentication.
1009
1010         * Scripts/webkitpy/common/checkout/api.py:
1011         * Scripts/webkitpy/common/net/bugzilla.py:
1012
1013 2010-04-21  Eric Seidel  <eric@webkit.org>
1014
1015         Unreviewed.  Temporary commit, will roll-out before morning.
1016
1017         Turning on new-run-webkit-tests for the Leopard build bot
1018         for testing of the harness.
1019         Users should not noctice (except for the results.html difference).
1020
1021         * Scripts/run-webkit-tests:
1022
1023 2010-04-21  Eric Seidel  <eric@webkit.org>
1024
1025         Unreviewed.  Fix typo in my previous fix attempt.
1026
1027         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1028         https://bugs.webkit.org/show_bug.cgi?id=37765
1029
1030         More on-the-bot debugging, sigh.  I wish I had a local build.
1031
1032         * Scripts/webkitpy/layout_tests/port/base.py:
1033
1034 2010-04-21  Eric Seidel  <eric@webkit.org>
1035
1036         Unreviewed.  Fix typo in my previous fix attempt.
1037
1038         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1039         https://bugs.webkit.org/show_bug.cgi?id=37765
1040
1041         * Scripts/webkitpy/layout_tests/port/base.py:
1042          - Add self. to class variable access.
1043
1044 2010-04-21  Eric Seidel  <eric@webkit.org>
1045
1046         Unreviewed.  Another attempt to fix NRWT for chromium.
1047
1048         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1049         https://bugs.webkit.org/show_bug.cgi?id=37765
1050
1051         * Scripts/webkitpy/layout_tests/port/base.py:
1052          - wdiff_text was returning a byte array instead of a
1053            unicode string.  The simple fix was to just decode
1054            the result.  However, seeing so much duplicated code
1055            with Executive made me cry, so I re-wrote the function
1056            to be more like pretty_patch_text and use run_command
1057            (which already knows how to handle unicode).
1058
1059 2010-04-21  Adam Barth  <abarth@webkit.org>
1060
1061         Reviewed by Eric Seidel.
1062
1063         Windows tests buildbots are too slow to be core builders
1064         https://bugs.webkit.org/show_bug.cgi?id=37970
1065
1066         It's 10:45.  The Windows test bots are still hours behind.  They're too
1067         slow to be core builders.  When they get fast, we can add them back.
1068
1069         * Scripts/webkitpy/common/net/buildbot.py:
1070         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1071
1072 2010-04-21  Eric Seidel  <eric@webkit.org>
1073
1074         Unreviewed.  Attempt one more time to fix NRWT for chromium.
1075
1076         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1077         https://bugs.webkit.org/show_bug.cgi?id=37765
1078
1079         I'm debugging in the blind because I don't have a chromium
1080         build on this laptop.
1081
1082         * Scripts/webkitpy/layout_tests/port/chromium.py:
1083          - Apply the previous fix to a second caller.
1084
1085 2010-04-21  Eric Seidel  <eric@webkit.org>
1086
1087         Unreviewed.  Attempt one more time to fix NRWT for chromium.
1088
1089         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1090         https://bugs.webkit.org/show_bug.cgi?id=37765
1091
1092         * Scripts/webkitpy/layout_tests/port/chromium.py:
1093          - Fix handling of test_shell output so that we always
1094            decode it as utf-8.
1095            Unlike DumpRenderTree test_shell does not ever return
1096            pixel data.  It spits out the pixel dumps in a separate
1097            file, thus all output over stdout is utf-8 text.
1098
1099 2010-04-21  Eric Seidel  <eric@webkit.org>
1100
1101         Unreviewed.  Attempt one more time to fix NRWT for chromium.
1102
1103         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1104         https://bugs.webkit.org/show_bug.cgi?id=37765
1105
1106         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1107          - Pass encoding to _save_baseline_data and write_output_files
1108         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1109          - Make _save_baseline_data and write_output_files take an encoding.
1110         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1111         - Pass encoding to _save_baseline_data and write_output_files
1112
1113 2010-04-21  No'am Rosenthal  <noam.rosenthal@nokia.com>
1114
1115         Reviewed by Kenneth Rohde Christiansen.
1116
1117         [Qt] QtLauncher: make FPS measurement accurate
1118         https://bugs.webkit.org/show_bug.cgi?id=37934
1119
1120         Instead of counting paints, which are not interchangeable with frames that
1121         the user sees, we now set an arbitrary timer for FPS measurements. The idea is
1122         that if the main thread is delayed for any reason, that timer would be delayed
1123         as well.
1124
1125         * QtLauncher/QtLauncher.pro:
1126         * QtLauncher/fpstimer.cpp: Added.
1127         (FpsTimer::FpsTimer):
1128         (FpsTimer::numFrames):
1129         (FpsTimer::start):
1130         (FpsTimer::stop):
1131         (FpsTimer::timerEvent):
1132         * QtLauncher/fpstimer.h: Added.
1133         * QtLauncher/webview.cpp:
1134         (WebViewGraphicsBased::setFrameRateMeasurementEnabled):
1135         (WebViewGraphicsBased::updateFrameRate):
1136         (WebViewGraphicsBased::paintEvent):
1137         * QtLauncher/webview.h:
1138
1139 2010-04-21  Eric Seidel  <eric@webkit.org>
1140
1141         Unreviewed, just adding missing ":" in python file.
1142
1143         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1144         https://bugs.webkit.org/show_bug.cgi?id=37765
1145
1146         new-run-webkit-tests --chromium was borked.
1147
1148         * Scripts/webkitpy/layout_tests/port/chromium.py:
1149
1150 2010-04-21  Eric Seidel  <eric@webkit.org>
1151
1152         Reviewed by Adam Barth.
1153
1154         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1155         https://bugs.webkit.org/show_bug.cgi?id=37765
1156
1157         Third time is the charm.  I've fixed all the
1158         new-run-webkit-tests regressions from previous attempts.
1159
1160         I fixed the queue to not ignore Tor as a reviwer in r57531,
1161         but instead it throws an exception every time his name is in a patch.
1162
1163         This fixes our Executive.run_command code to work around a Popen
1164         bug http://bugs.python.org/issue5290 whereby python versions before 2.6
1165         do not correctly handle unicode objects as input or output to
1166         Popen.communicate.
1167
1168         Following the advice of:
1169         http://farmdev.com/talks/unicode/
1170         I have changed all of webkitpy to use unicode() objects as strings
1171         instead of str objects (which in Python 3 are renamed "bytes").
1172
1173         String literals were left as "foo" instead of converting to u"foo"
1174         as u"foo" is only required if the string has a non-ascii code point.
1175         Python is smart about comparing str() and unicode() values and will
1176         log an error to the console if the comparison is ever invalid.
1177
1178         Executive.run* now correctly accept and return unicode() objects.
1179         I attempted to fix all the places that we call .write() to make sure we
1180         encode any unicode() objects into utf-8.
1181
1182         I removed several uses of StringIO.  StringIO should generally always be
1183         passed a unicode() value.
1184
1185         Likewise I replaced most calls to open() with codecs.open().
1186         codecs.open() matches Python 3 open semantics in requiring an encoding
1187         parameter.  Files opened with codecs.open() with a unicode-compatible
1188         encoding will vend unicode() objects from their read() calls, like how
1189         StringIO created with a unicode() object will do.
1190
1191         I also deployed "with" statements wider (now that the project has
1192         settled on Python 2.5) to close a bunch of file descriptor leaks.
1193
1194         * Scripts/webkitpy/common/checkout/api_unittest.py:
1195          - Read/write utf-8 files instead of ascii.
1196          - Update the tests to use test for proper unicode() handling.
1197         * Scripts/webkitpy/common/checkout/changelog.py:
1198          - Document that parse_latest_entry_from_file expects
1199            file-like objects which return unicode strings.
1200         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1201          - Use unicode() strings instead of str() byte arrays.
1202          - Deploy "with" to close file descriptor leaks.
1203         * Scripts/webkitpy/common/checkout/commitinfo.py:
1204          - Remove unneeded import.
1205         * Scripts/webkitpy/common/checkout/scm.py:
1206          - Remove use of str().
1207         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1208          - Read/write utf-8 files and use unicode() strings in testing.
1209         * Scripts/webkitpy/common/config/committers.py:
1210          - Use \u instead of \x to make slightly clearer what we're doing.
1211         * Scripts/webkitpy/common/net/bugzilla.py:
1212          - Add a new _string_contents() method and explain why
1213             we have to call unicode() on the result of soup.string
1214             and why it's safe to do so w/o needing to pass a codec name.
1215           - Remove the (unused) support for passing a file object to add_patch_to_bug().
1216         * Scripts/webkitpy/common/net/buildbot.py:
1217          - Use unicode() instead of str() when needing to coax a
1218             NavigableString object into a unicode() object.
1219         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1220          - Add a test which contains a unicode builder name.
1221         * Scripts/webkitpy/common/net/statusserver.py:
1222          - Remove use of str()
1223         * Scripts/webkitpy/common/prettypatch.py:
1224          - Write out the patch file as utf-8.
1225         * Scripts/webkitpy/common/system/autoinstall.py:
1226          - Write out files with a explicit encodings.
1227          - Deploy "with" to close file descriptor leaks.
1228         * Scripts/webkitpy/common/system/deprecated_logging.py:
1229          - Write out log files as utf-8.
1230         * Scripts/webkitpy/common/system/executive.py:
1231          - Make run* properly take and return unicode() objects.
1232          - Cleaned up input handling in run_command a little by adding
1233            a _compute_input() method which can return early instead of having
1234            such a long/cluttered if-block.
1235         * Scripts/webkitpy/common/system/executive_unittest.py:
1236          - Added a unit test to make sure we don't break Tor again!
1237         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1238          - Write out the test list as utf-8.
1239         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1240          - Write out json files as utf-8.
1241         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1242          - Deploy "with" to close file descriptor leaks.
1243         * Scripts/webkitpy/layout_tests/port/chromium.py: Add Executive.py FIXME.
1244         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: ditto.
1245         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: ditto.
1246         * Scripts/webkitpy/layout_tests/port/gtk.py: ditto.
1247         * Scripts/webkitpy/layout_tests/port/mac.py: ditto.
1248         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1249          - Make the skipped file parsing test unicode.
1250         * Scripts/webkitpy/layout_tests/port/qt.py: Add Executive.py FIXME.
1251         * Scripts/webkitpy/layout_tests/port/server_process.py: ditto.
1252         * Scripts/webkitpy/layout_tests/port/webkit.py:
1253          - Deploy "with" to close file descriptor leaks.
1254         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1255          - Make explicit the encodings of log files and pid files.
1256         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1257          - Make encodings explicit and deploy "with".
1258         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: ditto.
1259         * Scripts/webkitpy/layout_tests/test_types/image_diff.py: ditto.
1260         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: ditto.
1261         * Scripts/webkitpy/layout_tests/test_types/text_diff.py: ditto.
1262         * Scripts/webkitpy/style/filereader_unittest.py: ditto.
1263         * Scripts/webkitpy/thirdparty/__init__.py: ditto.
1264         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1265          - Removed extra import.
1266         * Scripts/webkitpy/tool/commands/queues.py:
1267          - No need to map args to strings now that run_command does.
1268          - Update test results to match args changes.
1269          - Document our global argument hacks.
1270         * Scripts/webkitpy/tool/commands/upload.py:
1271          - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
1272         * Scripts/webkitpy/tool/mocktool.py:
1273          - Rename add_patch_to_bug argument to match bugzilla.py
1274         * Scripts/webkitpy/tool/steps/abstractstep.py:
1275          - Executive.run_* now require lists instead of strings.
1276            The lack of this change was what broke webkit-patch
1277            for svn users the first time this was landed.
1278         * Scripts/webkitpy/tool/steps/postdiff.py:
1279          - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
1280         * Scripts/webkitpy/tool/steps/postdiffforcommit.py: ditto
1281         * Scripts/webkitpy/tool/steps/postdiffforrevert.py: ditto
1282         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1283          - Fixed spurious logging seen when running test-webkitpy
1284
1285 2010-04-21  Chris Fleizach  <cfleizach@apple.com>
1286
1287         Reviewed by Alexey Proskuryakov.
1288
1289         aria-liveregion-notifications.html fails on leopard release bot
1290         https://bugs.webkit.org/show_bug.cgi?id=37112
1291
1292         Change the way that notifications are listened for by forcing clients
1293         to call a remove listener as well to match the add listener. DRT will
1294         assert if those are not done in the correct order. 
1295
1296         * DumpRenderTree/AccessibilityUIElement.cpp:
1297         (removeNotificationListenerCallback):
1298         (AccessibilityUIElement::getJSClass):
1299         * DumpRenderTree/AccessibilityUIElement.h:
1300         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1301         (AccessibilityUIElement::removeNotificationListener):
1302         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1303         (-[AccessibilityNotificationHandler initWithPlatformElement:]):
1304         (-[AccessibilityNotificationHandler dealloc]):
1305         (-[AccessibilityNotificationHandler _notificationReceived:]):
1306         (-[AccessibilityNotificationHandler setCallback:]):
1307         (AccessibilityUIElement::AccessibilityUIElement):
1308         (AccessibilityUIElement::~AccessibilityUIElement):
1309         (AccessibilityUIElement::addNotificationListener):
1310         (AccessibilityUIElement::removeNotificationListener):
1311         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1312         (AccessibilityUIElement::removeNotificationListener):
1313
1314 2010-04-21  Anders Carlsson  <andersca@apple.com>
1315
1316         Reviewed by Sam Weinig.
1317
1318         Add debug menu items to show/hide the Web View.
1319         https://bugs.webkit.org/show_bug.cgi?id=37958
1320
1321         * MiniBrowser/mac/BrowserWindowController.h:
1322         * MiniBrowser/mac/BrowserWindowController.m:
1323         (-[BrowserWindowController showHideWebView:]):
1324         (-[BrowserWindowController removeReinsertWebView:]):
1325         (-[BrowserWindowController validateMenuItem:]):
1326         * MiniBrowser/mac/English.lproj/MainMenu.xib:
1327
1328 2010-04-21  Eric Seidel  <eric@webkit.org>
1329
1330         Unreviewed.  Rolling out unicode() changes as they broke NRWT for chromium.
1331         Rolling out:
1332         http://trac.webkit.org/changeset/58014
1333         http://trac.webkit.org/changeset/58016
1334         http://trac.webkit.org/changeset/58020
1335
1336         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbo
1337         https://bugs.webkit.org/show_bug.cgi?id=37765
1338
1339         * Scripts/webkitpy/common/checkout/api_unittest.py:
1340         * Scripts/webkitpy/common/checkout/changelog.py:
1341         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1342         * Scripts/webkitpy/common/checkout/commitinfo.py:
1343         * Scripts/webkitpy/common/checkout/scm.py:
1344         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1345         * Scripts/webkitpy/common/config/committers.py:
1346         * Scripts/webkitpy/common/net/bugzilla.py:
1347         * Scripts/webkitpy/common/net/buildbot.py:
1348         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1349         * Scripts/webkitpy/common/net/statusserver.py:
1350         * Scripts/webkitpy/common/prettypatch.py:
1351         * Scripts/webkitpy/common/system/autoinstall.py:
1352         * Scripts/webkitpy/common/system/deprecated_logging.py:
1353         * Scripts/webkitpy/common/system/executive.py:
1354         * Scripts/webkitpy/common/system/executive_unittest.py:
1355         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1356         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1357         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1358         * Scripts/webkitpy/layout_tests/port/chromium.py:
1359         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1360         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1361         * Scripts/webkitpy/layout_tests/port/gtk.py:
1362         * Scripts/webkitpy/layout_tests/port/mac.py:
1363         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1364         * Scripts/webkitpy/layout_tests/port/qt.py:
1365         * Scripts/webkitpy/layout_tests/port/server_process.py:
1366         * Scripts/webkitpy/layout_tests/port/webkit.py:
1367         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1368         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1369         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1370         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1371         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1372         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1373         * Scripts/webkitpy/style/filereader_unittest.py:
1374         * Scripts/webkitpy/thirdparty/__init__.py:
1375         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1376         * Scripts/webkitpy/tool/commands/queues.py:
1377         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1378         * Scripts/webkitpy/tool/commands/upload.py:
1379         * Scripts/webkitpy/tool/mocktool.py:
1380         * Scripts/webkitpy/tool/steps/abstractstep.py:
1381         * Scripts/webkitpy/tool/steps/postdiff.py:
1382         * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
1383         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
1384         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1385
1386 2010-04-21  Eric Seidel  <eric@webkit.org>
1387
1388         Unreviewed, fixing NRWT for real this time.
1389
1390         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1391         https://bugs.webkit.org/show_bug.cgi?id=37765
1392
1393         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1394          - Add a hack to fix new-run-webkit-tests
1395            my understanding of codecs.open(encoding=None)
1396            must have been wrong.
1397
1398 2010-04-21  Eric Seidel  <eric@webkit.org>
1399
1400         Unreviewed, just fixing exception seen on builders.
1401
1402         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1403         https://bugs.webkit.org/show_bug.cgi?id=37765
1404
1405         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1406          - Pass and encoding to _write_into_file_at_path
1407
1408 2010-04-21  Eric Seidel  <eric@webkit.org>
1409
1410         Reviewed by Adam Barth.
1411
1412         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1413         https://bugs.webkit.org/show_bug.cgi?id=37765
1414
1415         I fixed the queue to not ignore Tor as a reviwer in r57531,
1416         but instead it throws an exception every time his name is in a patch.
1417
1418         This fixes our Executive.run_command code to work around a Popen
1419         bug http://bugs.python.org/issue5290 whereby python versions before 2.6
1420         do not correctly handle unicode objects as input or output to
1421         Popen.communicate.
1422
1423         Following the advice of:
1424         http://farmdev.com/talks/unicode/
1425         I have changed all of webkitpy to use unicode() objects as strings
1426         instead of str objects (which in Python 3 are renamed "bytes").
1427
1428         String literals were left as "foo" instead of converting to u"foo"
1429         as u"foo" is only required if the string has a non-ascii code point.
1430         Python is smart about comparing str() and unicode() values and will
1431         log an error to the console if the comparison is ever invalid.
1432
1433         Executive.run* now correctly accept and return unicode() objects.
1434         I attempted to fix all the places that we call .write() to make sure we
1435         encode any unicode() objects into utf-8.
1436
1437         I removed several uses of StringIO.  StringIO should generally always be
1438         passed a unicode() value.
1439
1440         Likewise I replaced most calls to open() with codecs.open().
1441         codecs.open() matches Python 3 open semantics in requiring an encoding
1442         parameter.  Files opened with codecs.open() with a unicode-compatible
1443         encoding will vend unicode() objects from their read() calls, like how
1444         StringIO created with a unicode() object will do.
1445
1446         I also deployed "with" statements wider (now that the project has
1447         settled on Python 2.5) to close a bunch of file descriptor leaks.
1448
1449         * Scripts/webkitpy/common/checkout/api_unittest.py:
1450          - Read/write utf-8 files instead of ascii.
1451          - Update the tests to use test for proper unicode() handling.
1452         * Scripts/webkitpy/common/checkout/changelog.py:
1453          - Document that parse_latest_entry_from_file expects
1454            file-like objects which return unicode strings.
1455         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1456          - Use unicode() strings instead of str() byte arrays.
1457          - Deploy "with" to close file descriptor leaks.
1458         * Scripts/webkitpy/common/checkout/commitinfo.py:
1459          - Remove unneeded import.
1460         * Scripts/webkitpy/common/checkout/scm.py:
1461          - Remove use of str().
1462         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1463          - Read/write utf-8 files and use unicode() strings in testing.
1464         * Scripts/webkitpy/common/config/committers.py:
1465          - Use \u instead of \x to make slightly clearer what we're doing.
1466         * Scripts/webkitpy/common/net/bugzilla.py:
1467          - Add a new _string_contents() method and explain why
1468             we have to call unicode() on the result of soup.string
1469             and why it's safe to do so w/o needing to pass a codec name.
1470           - Remove the (unused) support for passing a file object to add_patch_to_bug().
1471         * Scripts/webkitpy/common/net/buildbot.py:
1472          - Use unicode() instead of str() when needing to coax a
1473             NavigableString object into a unicode() object.
1474         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1475          - Add a test which contains a unicode builder name.
1476         * Scripts/webkitpy/common/net/statusserver.py:
1477          - Remove use of str()
1478         * Scripts/webkitpy/common/prettypatch.py:
1479          - Write out the patch file as utf-8.
1480         * Scripts/webkitpy/common/system/autoinstall.py:
1481          - Write out files with a explicit encodings.
1482          - Deploy "with" to close file descriptor leaks.
1483         * Scripts/webkitpy/common/system/deprecated_logging.py:
1484          - Write out log files as utf-8.
1485         * Scripts/webkitpy/common/system/executive.py:
1486          - Make run* properly take and return unicode() objects.
1487          - Cleaned up input handling in run_command a little by adding
1488            a _compute_input() method which can return early instead of having
1489            such a long/cluttered if-block.
1490         * Scripts/webkitpy/common/system/executive_unittest.py:
1491          - Added a unit test to make sure we don't break Tor again!
1492         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1493          - Write out the test list as utf-8.
1494         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1495          - Write out json files as utf-8.
1496         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1497          - Deploy "with" to close file descriptor leaks.
1498         * Scripts/webkitpy/layout_tests/port/chromium.py: Add Executive.py FIXME.
1499         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: ditto.
1500         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: ditto.
1501         * Scripts/webkitpy/layout_tests/port/gtk.py: ditto.
1502         * Scripts/webkitpy/layout_tests/port/mac.py: ditto.
1503         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1504          - Make the skipped file parsing test unicode.
1505         * Scripts/webkitpy/layout_tests/port/qt.py: Add Executive.py FIXME.
1506         * Scripts/webkitpy/layout_tests/port/server_process.py: ditto.
1507         * Scripts/webkitpy/layout_tests/port/webkit.py:
1508          - Deploy "with" to close file descriptor leaks.
1509         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1510          - Make explicit the encodings of log files and pid files.
1511         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1512          - Make encodings explicit and deploy "with".
1513         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: ditto.
1514         * Scripts/webkitpy/layout_tests/test_types/image_diff.py: ditto.
1515         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: ditto.
1516         * Scripts/webkitpy/layout_tests/test_types/text_diff.py: ditto.
1517         * Scripts/webkitpy/style/filereader_unittest.py: ditto.
1518         * Scripts/webkitpy/thirdparty/__init__.py: ditto.
1519         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1520          - Removed extra import.
1521         * Scripts/webkitpy/tool/commands/queues.py:
1522          - No need to map args to strings now that run_command does.
1523          - Update test results to match args changes.
1524          - Document our global argument hacks.
1525         * Scripts/webkitpy/tool/commands/upload.py:
1526          - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
1527         * Scripts/webkitpy/tool/mocktool.py:
1528          - Rename add_patch_to_bug argument to match bugzilla.py
1529         * Scripts/webkitpy/tool/steps/abstractstep.py:
1530          - Executive.run_* now require lists instead of strings.
1531            The lack of this change was what broke webkit-patch
1532            for svn users the first time this was landed.
1533         * Scripts/webkitpy/tool/steps/postdiff.py:
1534          - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
1535         * Scripts/webkitpy/tool/steps/postdiffforcommit.py: ditto
1536         * Scripts/webkitpy/tool/steps/postdiffforrevert.py: ditto
1537         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1538          - Fixed spurious logging seen when running test-webkitpy
1539
1540 2010-04-21  Kinuko Yasuda  <kinuko@chromium.org>
1541
1542         Unreviewed.
1543
1544         Add myself in committers.py.
1545
1546         * Scripts/webkitpy/common/config/committers.py:
1547
1548 2010-04-21  Dirk Pranke  <dpranke@chromium.org>
1549
1550         Reviewed by Dimitri Glazkov.
1551
1552         new-run-webkit-tests: fix a bug in the Chromium port where we would
1553         try to talk to a crashed test_shell and raise exceptions that weren't
1554         being caught.
1555
1556         https://bugs.webkit.org/show_bug.cgi?id=37941
1557
1558         * Scripts/webkitpy/layout_tests/port/chromium.py:
1559
1560 2010-04-21  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1561
1562         Unreviewed.
1563
1564         [Qt] [Symbian] Build fix.
1565
1566         Work around a Qt quirk. Some versions of Symbian port Qt
1567         QFontDatabase::removeAllApplicationFonts symbol is not available.
1568
1569         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1570         (WebCore::DumpRenderTree::open):
1571
1572 2010-04-21  Alexey Proskuryakov  <ap@apple.com>
1573
1574         Unreviewed.
1575
1576         https://bugs.webkit.org/show_bug.cgi?id=37933
1577         <rdar://problem/7719540> XMLHttpRequest.withCredentials should be better enforced.
1578
1579         Adding stub implementation of authenticateSession(). Depending on platform loader behavior,
1580         a real implementation may or may not be necessary for the one test that currently uses it
1581         to pass.
1582
1583         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1584         (LayoutTestController::authenticateSession):
1585         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1586
1587 2010-04-21  Alexey Proskuryakov  <ap@apple.com>
1588
1589         Reviewed by Brady Eidson.
1590
1591         https://bugs.webkit.org/show_bug.cgi?id=37933
1592         <rdar://problem/7719540> XMLHttpRequest.withCredentials should be better enforced.
1593
1594         Adding authenticateSession() method that adds credentials to per-process credential storage
1595         (for platforms that even have such). No Windows implementation, because writing another
1596         loader for DRT is painful.
1597
1598         * DumpRenderTree/LayoutTestController.cpp:
1599         (authenticateSessionCallback):
1600         (LayoutTestController::staticFunctions):
1601         * DumpRenderTree/LayoutTestController.h:
1602         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1603         (-[SynchronousLoader dealloc]):
1604         (-[SynchronousLoader connectionShouldUseCredentialStorage:]):
1605         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
1606         (-[SynchronousLoader connection:didFailWithError:]):
1607         (-[SynchronousLoader connectionDidFinishLoading:]):
1608         (+[SynchronousLoader makeRequest:withUsername:password:]):
1609         (LayoutTestController::authenticateSession):
1610
1611         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1612         (LayoutTestController::authenticateSession):
1613         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1614         (LayoutTestController::authenticateSession):
1615         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1616         (LayoutTestController::authenticateSession):
1617         Stub implementations.
1618
1619 2010-04-21  Kent Tamura  <tkent@chromium.org>
1620
1621         Reviewed by Dimitri Glazkov.
1622
1623         [DRT/Chromium] Make DRT compilable in Chromium tree
1624         https://bugs.webkit.org/show_bug.cgi?id=37923
1625
1626         We need to use different GYPs in a case of WebKit-only checkout
1627         and a case of whole Chromium checkout because the relative paths
1628         from webkit/ to WebKit/chromium/features.gypi are different in
1629         these cases and we can't use 'conditions' for 'includes' in GYPs.
1630
1631         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1632
1633 2010-04-21  Jakub Wieczorek  <jwieczorek@webkit.org>
1634
1635         Reviewed by Darin Adler.
1636
1637         List item markers are not always updated after changes in the DOM.
1638         https://bugs.webkit.org/show_bug.cgi?id=37060
1639
1640         * DumpRenderTree/LayoutTestController.cpp:
1641         (markerTextForListItemCallback): A function that returns the marker text for a given list item.
1642         (LayoutTestController::staticFunctions):
1643         * DumpRenderTree/LayoutTestController.h:
1644         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1645         (LayoutTestController::markerTextForListItem): Implement it in the GTK port.
1646         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1647         (LayoutTestController::markerTextForListItem): Add a stub.
1648         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1649         (LayoutTestController::LayoutTestController):
1650         (LayoutTestController::markerTextForListItem): Implement it in the Qt port.
1651         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1652         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1653         (LayoutTestController::markerTextForListItem): Add a stub.
1654
1655 2010-04-21  Adam Roben  <aroben@apple.com>
1656
1657         Exclude leaks in CGGradientCreateWithColorComponents from
1658         run-webkit-tests leaks output
1659
1660         The leak in CG is covered by <rdar://problem/7888492>.
1661
1662         Fixes <http://webkit.org/b/37927>.
1663
1664         Reviewed by Eric Carlson.
1665
1666         * Scripts/old-run-webkit-tests:
1667         (sub countAndPrintLeaks): Exclude leaks in
1668         CGGradientCreateWithColorComponents on certain OSs.
1669
1670 2010-04-21  Kent Tamura  <tkent@chromium.org>
1671
1672         Reviewed by Shinichiro Hamaji.
1673
1674         [DRT/Chromium] Import MockSpellCheck from Chromium
1675         https://bugs.webkit.org/show_bug.cgi?id=37910
1676
1677         Import webkit/tools/test_shell/mock_spellcheck.{cc,h} rev.37241 of Chromium.
1678
1679         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1680           Add ICU explicitly because WTFString.h includes ICU headers.
1681           Add MockSpellCheck.{cpp,h}.
1682         * DumpRenderTree/chromium/MockSpellCheck.cpp: Added.
1683         * DumpRenderTree/chromium/MockSpellCheck.h: Added.
1684         * DumpRenderTree/chromium/WebViewHost.cpp:
1685         (WebViewHost::spellCheck):
1686         * DumpRenderTree/chromium/WebViewHost.h:
1687         * DumpRenderTree/chromium/config.h: Define JS_EXPORTDATA, which is used
1688           by wtf/text/AtomicString.h included by wtf/text/WTFString.h.
1689
1690 2010-04-21  Adam Barth  <abarth@webkit.org>
1691
1692         Reviewed by Eric Seidel.
1693
1694         Add webkit-patch pretty-diff
1695         https://bugs.webkit.org/show_bug.cgi?id=37892
1696
1697         This is slightly lame because it asks you whether the diff is correct,
1698         but it's a starting point.
1699
1700         * Scripts/webkitpy/tool/commands/__init__.py:
1701         * Scripts/webkitpy/tool/commands/prettydiff.py: Added.
1702         * Scripts/webkitpy/tool/main.py:
1703
1704 2010-04-21  Adam Barth  <abarth@webkit.org>
1705
1706         Reviewed by Darin Adler.
1707
1708         Remove mention of non-existant --no-build option
1709         https://bugs.webkit.org/show_bug.cgi?id=37893
1710
1711         The option doesn't exist!
1712
1713         * Scripts/webkitpy/tool/commands/stepsequence.py:
1714
1715 2010-04-21  Balazs Kelemen  <kb@inf.u-szeged.hu>
1716
1717         Reviewed by Kenneth Rohde Christiansen.
1718
1719         [Qt] Interrupting JavaScript is cumbersome when you use QtLaucher for testing or profiling.
1720         https://bugs.webkit.org/show_bug.cgi?id=37198
1721
1722         * QtLauncher/main.cpp:
1723         (LauncherWindow::toggleInterruptingJavaScriptEnabled):
1724         (LauncherWindow::newWindow):
1725         (LauncherWindow::cloneWindow):
1726         (LauncherWindow::createChrome):
1727         (main):
1728         * QtLauncher/webpage.cpp:
1729         (WebPage::WebPage):
1730         (WebPage::shouldInterruptJavaScript):
1731         * QtLauncher/webpage.h:
1732         (WebPage::setInterruptingJavaScriptEnabled):
1733
1734 2010-04-21  Eric Seidel  <eric@webkit.org>
1735
1736         Unreviewed, rolling out r57963.
1737         http://trac.webkit.org/changeset/57963
1738         https://bugs.webkit.org/show_bug.cgi?id=37759
1739
1740         Three tests started crashing on the Qt bot.
1741
1742         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1743         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1744
1745 2010-04-21  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1746
1747         Reviewed by Eric Seidel.
1748
1749         Make new-run-webkit-tests work for the Qt port
1750         https://bugs.webkit.org/show_bug.cgi?id=37588
1751
1752         * Scripts/webkitpy/layout_tests/port/qt.py:
1753
1754 2010-04-21  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1755
1756         Reviewed by Eric Seidel.
1757
1758         new-run-webkit-tests: try to detect alternate apache path
1759         https://bugs.webkit.org/show_bug.cgi?id=37587
1760
1761         _check_port_build() also needs to return true in the
1762         base implementation to not fail the check_build step.
1763
1764         * Scripts/webkitpy/layout_tests/port/webkit.py:
1765
1766 2010-04-21  Yi Shen  <yi.4.shen@nokia.com>
1767
1768         Reviewed by Simon Hausmann.
1769
1770         [Qt] Add LayoutTestController interface: computedStyleIncludingVisitedInfo
1771         https://bugs.webkit.org/show_bug.cgi?id=37759
1772
1773         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1774         (LayoutTestController::computedStyleIncludingVisitedInfo):
1775         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1776
1777 2010-04-21  Eric Seidel  <eric@webkit.org>
1778
1779         Unreviewed, test fix only.
1780
1781         new-run-webkit-tests: implement a --log trace message to be able to display detailed output of an individual test run
1782         https://bugs.webkit.org/show_bug.cgi?id=37726
1783
1784         This change seems to have broken a test.
1785         Attempting to handle the case where we don't have any
1786         timing information.  Dirk may have to correct this change.
1787
1788         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1789
1790 2010-04-19  Eric Seidel  <eric@webkit.org>
1791
1792         Reviewed by Adam Barth.
1793
1794         new-run-webkit-tests has much higher startup latency than run-webkit-tests
1795         https://bugs.webkit.org/show_bug.cgi?id=37643
1796
1797         I got rid of the -expected.checksum reads during startup.
1798         This makes startup noticably better on my laptop.
1799
1800         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1801          - Use image_hash() instead of .image_hash now that expected.checksum
1802            file reads are done lazily.
1803         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1804          - Add debug logging for this sleep call.
1805            In my testing I never saw this sleep() hit.
1806         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1807          - Sleep a shorter interval to make websocket server
1808            startup more responsive.  On my machine startup was
1809            taking around 1 second.
1810          - Remove the unconditional .5s delay on startup.
1811         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1812          - Make image_hash file reads done lazily in a new image_hash() function.
1813          - Add a "Starting testing ..." meter update after DRT threads have
1814            been started, but before we get updates from the first one.
1815          - Rename variable "t" to a full english name to match WebKit style.
1816
1817 2010-04-20  Daniel Bates  <dbates@rim.com>
1818
1819         Reviewed by Eric Seidel.
1820
1821         https://bugs.webkit.org/show_bug.cgi?id=37748
1822
1823         Make Sheriffbot more inspirational.
1824
1825         * Scripts/webkitpy/common/net/bugzilla.py:
1826         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
1827         * Scripts/webkitpy/tool/bot/irc_command.py:
1828         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1829         * Scripts/webkitpy/tool/mocktool.py:
1830
1831 2010-04-20  Kent Tamura  <tkent@chromium.org>
1832
1833         Reviewed by Dimitri Glazkov.
1834
1835         [DRT/Chromium] Import Chromium image_diff as ImageDiff
1836         https://bugs.webkit.org/show_bug.cgi?id=37790
1837
1838         ImageDiff.cpp is based on tools/imagediff/image_diff.cc r41911 of Chromium.
1839
1840         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1841         * DumpRenderTree/chromium/ImageDiff.cpp: Added.
1842         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1843
1844 2010-04-20  Dirk Pranke <dpranke@chromium.org>
1845
1846         This patch to new-run-webkit-tests adds a --log 'trace' option
1847         that prints out detailed info about a given test as it executes
1848         (where the baselines are, what the expectation is, what we got,
1849         how long it took).
1850
1851         https://bugs.webkit.org/show_bug.cgi?id=37726
1852
1853         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1854           - use the newly exposed TestResult class and implement
1855             --log trace
1856         * Scripts/webkitpy/layout_tests/layout_package/dump_render_thread.py:
1857           - rename TestStats to TestResult and make it more public, resulting
1858             in cleaner code
1859         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1860           - add expectation_to_string() as a separate callable function
1861
1862 2010-04-20  Eric Seidel  <eric@webkit.org>
1863
1864         Unreviewed, rolling out r57907.
1865         http://trac.webkit.org/changeset/57907
1866         https://bugs.webkit.org/show_bug.cgi?id=37765
1867
1868         Appears to have broken MacEWS and possibly webkit-patch upload
1869         for svn users.  Needs further investigation.
1870
1871         * Scripts/webkitpy/common/checkout/api.py:
1872         * Scripts/webkitpy/common/checkout/api_unittest.py:
1873         * Scripts/webkitpy/common/checkout/changelog.py:
1874         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1875         * Scripts/webkitpy/common/checkout/commitinfo.py:
1876         * Scripts/webkitpy/common/checkout/scm.py:
1877         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1878         * Scripts/webkitpy/common/config/committers.py:
1879         * Scripts/webkitpy/common/net/bugzilla.py:
1880         * Scripts/webkitpy/common/net/buildbot.py:
1881         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1882         * Scripts/webkitpy/common/net/statusserver.py:
1883         * Scripts/webkitpy/common/prettypatch.py:
1884         * Scripts/webkitpy/common/system/autoinstall.py:
1885         * Scripts/webkitpy/common/system/deprecated_logging.py:
1886         * Scripts/webkitpy/common/system/executive.py:
1887         * Scripts/webkitpy/common/system/executive_unittest.py:
1888         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1889         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1890         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
1891         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1892         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1893         * Scripts/webkitpy/tool/commands/queues.py:
1894         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1895         * Scripts/webkitpy/tool/commands/upload.py:
1896         * Scripts/webkitpy/tool/mocktool.py:
1897         * Scripts/webkitpy/tool/steps/abstractstep.py:
1898         * Scripts/webkitpy/tool/steps/postdiff.py:
1899         * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
1900         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
1901         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1902
1903 2010-04-20  Nate Chapin  <japhet@chromium.org>
1904
1905         Unreviewed.
1906
1907         Update my irc handle in committers.py (natechapin -> japhet).
1908
1909         * Scripts/webkitpy/common/config/committers.py:
1910
1911 2010-04-20  Eric Seidel  <eric@webkit.org>
1912
1913         Reviewed by Adam Barth.
1914
1915         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1916         https://bugs.webkit.org/show_bug.cgi?id=37765
1917
1918         I fixed the queue to not ignore Tor as a reviwer in r57531,
1919         but instead it throws an exception every time his name is in a patch.
1920
1921         This fixes our Executive.run_command code to work around a Popen
1922         bug http://bugs.python.org/issue5290 whereby python versions before 2.6
1923         do not correctly handle unicode objects as input or output to
1924         Popen.communicate.
1925
1926         Following the advice of:
1927         http://farmdev.com/talks/unicode/
1928         I'm attempting to take the python unicode plunge and use unicode()
1929         objects as strings instead of str() objects everywhere in webkitpy.
1930
1931         We do not have to use u"" instead of "" because u"a" == "a" as expected
1932         in Python.  Python will generate a warning to the console in cases where
1933         a unicode() == str() operation cannot be performed.
1934
1935         I also cleaned up the input handling in run_command a little by adding
1936         a new _compute_input() method which can return early instead of having
1937         such a long/cluttered if-block.
1938
1939         Executive.run* now correctly accept and return unicode() objects.
1940         I attempted to fix all the places that we call .write() to make sure we
1941         encode any unicode() objects into utf-8.
1942
1943         All places which use StringIO need to be sure to pass StringIO a
1944         pre-encoded byte-array (str object) instead of unicode so that
1945         clients which read from the StringIO don't have encoding exceptions.
1946         To make this easier, I removed the patch_file_object support from
1947         add_patch_to_bug, and changed the 4 places which previously used
1948         StringIO to create a fake patch file.
1949
1950         I attempted to document any places where we are not correctly converting
1951         to/from bytes (str() objects) to strings (unicode() objects).
1952
1953         * Scripts/webkitpy/common/checkout/api_unittest.py:
1954          - Read/write utf-8 files instead of ascii.
1955          - Update the tests to use test for proper unicode() handling.
1956         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1957          - Use unicode() strings instead of str() byte arrays.
1958         * Scripts/webkitpy/common/checkout/scm.py:
1959          - Remove use of str().
1960         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1961          - Read/write utf-8 files and use unicode() strings in testing.
1962         * Scripts/webkitpy/common/config/committers.py:
1963          - Use \u instead of \x to make slightly clearer what we're doing.
1964         * Scripts/webkitpy/common/net/bugzilla.py:
1965          - Add a new _string_contents() method and explain why
1966            we have to call unicode() on the result of soup.string
1967            and why it's safe to do so w/o needing to pass a codec name.
1968          - Remove the (unused) support for passing a file object to add_patch_to_bug().
1969         * Scripts/webkitpy/common/net/buildbot.py:
1970          - Use unicode() instead of str() when needing to coax a
1971            NavigableString object into a unicode() object.
1972         * Scripts/webkitpy/common/net/statusserver.py:
1973          - Remove use of str()
1974         * Scripts/webkitpy/common/prettypatch.py:
1975          - Write out the patch file as utf-8.
1976         * Scripts/webkitpy/common/system/autoinstall.py:
1977          - Add a FIXME about encoding.
1978         * Scripts/webkitpy/common/system/deprecated_logging.py:
1979          - Document that tee() works on bytes, not strings.
1980         * Scripts/webkitpy/common/system/executive.py:
1981          - Make run* properly take and return unicode() objects.
1982         * Scripts/webkitpy/common/system/executive_unittest.py:
1983          - Added a unit test to make sure we don't break Tor again!
1984         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1985          - Write out the test list as utf-8.
1986         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1987          - Write out json files as utf-8.
1988         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
1989          - Add FIXME about encoding handling.
1990         * Scripts/webkitpy/tool/commands/upload.py:
1991          - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
1992         * Scripts/webkitpy/tool/mocktool.py:
1993          - Rename add_patch_to_bug argument to match bugzilla.py
1994         * Scripts/webkitpy/tool/steps/postdiff.py:
1995          - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
1996         * Scripts/webkitpy/tool/steps/postdiffforcommit.py: ditto.
1997         * Scripts/webkitpy/tool/steps/postdiffforrevert.py: ditto.
1998         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1999          - Fixed spurious logging seen when running test-webkitpy
2000
2001 2010-04-20  Chris Jerdonek  <cjerdonek@webkit.org>
2002
2003         Reviewed by Shinichiro Hamaji.
2004
2005         For check-webkit-style, implemented __eq__() and __ne__() (the
2006         built-in equality and inequality methods) for the
2007         DefaultStyleErrorHandler class.
2008
2009         https://bugs.webkit.org/show_bug.cgi?id=37850
2010
2011         This will facilitate unit-testing for a subsequent patch,
2012         namely for https://bugs.webkit.org/show_bug.cgi?id=37850
2013
2014         * Scripts/webkitpy/style/error_handlers.py:
2015           - Added __eq__() and __ne__() to the DefaultStyleErrorHandler
2016             class.
2017
2018         * Scripts/webkitpy/style/error_handlers_unittest.py:
2019           - Added unit tests for __eq__() and __ne__().
2020           - Also included a minor clean-up refactoring of combining the
2021             StyleErrorHandlerTestBase class (which has not needed to
2022             be separate due to previous changes) into the
2023             DefaultStyleErrorHandlerTest class.
2024
2025 2010-04-20  Jakub Wieczorek  <jwieczorek@webkit.org>
2026
2027         Unreviewed.
2028
2029         Add my IRC nick to the committers.py list.
2030
2031         * Scripts/webkitpy/common/config/committers.py:
2032
2033 2010-04-20  Kim Grönholm  <kim.gronholm@nomovok.com>
2034
2035         Reviewed by Simon Hausmann.
2036
2037         [Qt] Multitouch mocking in QtLauncher doesn't work with QGraphicsView
2038         https://bugs.webkit.org/show_bug.cgi?id=37816
2039         
2040         Fix multi-touch mocking in QtLauncher when using QGraphicsView.
2041         Test: https://bug-32434-attachments.webkit.org/attachment.cgi?id=44955
2042
2043         * QtLauncher/main.cpp:
2044         (LauncherWindow::eventFilter):
2045         (LauncherWindow::initializeView):
2046
2047 2010-04-20  MORITA Hajime <morrita@google.com>
2048
2049         Unreviewed, add myself to the committers list.
2050
2051         * Scripts/webkitpy/common/config/committers.py:
2052
2053 2010-04-20  Kent Tamura  <tkent@chromium.org>
2054
2055         Reviewed by Shinichiro Hamaji.
2056
2057         [DRT/Chromium] Fix some unexpected results of editing
2058         https://bugs.webkit.org/show_bug.cgi?id=37843
2059
2060         This change fixes about 70 unexpected results.
2061         The original test_webview_delegate.cc doesn't have this bug.
2062         The bug was introduced when I ported it to WebKit tree.
2063
2064         * DumpRenderTree/chromium/WebViewHost.cpp:
2065         (printRangeDescription): Replace the latter startContainer() with endContainer().
2066
2067 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2068
2069         Unreviewed, build fix.
2070
2071         Turn off some unit tests for now - the new-run-webkit-tests dryrun
2072         tests for chromium won't work if you don't have a chromium checkout.
2073
2074         https://bugs.webkit.org/show_bug.cgi?id=37841
2075
2076         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2077
2078 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2079
2080         Unreviewed, build fix.
2081
2082         (Re-)add dryrun.py; this was renamed from passing.py in the previous
2083         CL but apparently somehow didn't get checked in.
2084
2085         https://bugs.webkit.org/show_bug.cgi?id=37841
2086
2087         * Scripts/webkitpy/layout_tests/port/dryrun.py: Added.
2088
2089 2010-04-19  Shinichiro Hamaji  <hamaji@chromium.org>
2090
2091         Reviewed by David Levin.
2092
2093         check-webkit-style: exits when encountering a deleted file
2094         https://bugs.webkit.org/show_bug.cgi?id=37122
2095
2096         This reverts the quick fix done by r57119 and makes check_patch
2097         not call check_file for deleted files.
2098
2099         Also this change fixes the behavior for "-", which should mean
2100         stdin.  Before this change, the style checker just ignored "-"
2101         with a warning message.
2102
2103         * Scripts/webkitpy/style/checker.py:
2104         * Scripts/webkitpy/style/checker_unittest.py:
2105
2106 2010-04-19  Daniel Bates  <dbates@rim.com>
2107
2108         No review, rolling out 57868.
2109         http://trac.webkit.org/changeset/57868
2110         https://bugs.webkit.org/show_bug.cgi?id=37748
2111
2112         Sheriffbot wasn't very inspirational after this patch.
2113         Instead, he was silent when you said hi :-(. Rolling
2114         out this patch so that I can debug/test this some more.
2115
2116         * Scripts/webkitpy/common/net/bugzilla.py:
2117         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
2118         * Scripts/webkitpy/tool/bot/irc_command.py:
2119         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2120         * Scripts/webkitpy/tool/mocktool.py:
2121
2122 2010-04-19  Daniel Bates  <dbates@rim.com>
2123
2124         Reviewed by Adam Barth.
2125
2126         https://bugs.webkit.org/show_bug.cgi?id=37748
2127
2128         Make Sheriffbot more inspirational.
2129
2130         * Scripts/webkitpy/common/net/bugzilla.py:
2131         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
2132         * Scripts/webkitpy/tool/bot/irc_command.py:
2133         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2134         * Scripts/webkitpy/tool/mocktool.py:
2135
2136 2010-04-19  Kevin Ollivier  <kevino@theolliviers.com>
2137
2138         [wx] Build fix, add missing header.
2139
2140         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2141
2142 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2143  
2144          Reviewed by Adam Barth.
2145  
2146          new-run-webkit-tests - repurpose the "Passing" port as "Dryrun" port
2147          that can be used to test platforms other than the one you are running
2148          on. This can be useful for checking baselines and testing code
2149          coverage.
2150  
2151          Note that running the code on the "wrong" port requires each
2152          port-specific implementation to actually not require any
2153          platform-specific python code (e.g., the chromium-win port must
2154          test for the existence of windows functions before calling them).
2155  
2156          https://bugs.webkit.org/show_bug.cgi?id=37782
2157  
2158          * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2159          * Scripts/webkitpy/layout_tests/port/dryrun.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/port/passing.py.
2160          * Scripts/webkitpy/layout_tests/port/factory.py:
2161          * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2162
2163 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2164
2165         Reviewed by Eric Seidel.
2166
2167         new-run-webkit-tests: add --build (default) and --no-build
2168         options to make that step optional. This flag modifies what happens
2169         in port.check_build().
2170
2171         https://bugs.webkit.org/show_bug.cgi?id=37786
2172
2173         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2174         * Scripts/webkitpy/layout_tests/port/chromium.py:
2175         * Scripts/webkitpy/layout_tests/port/webkit.py:
2176
2177 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2178
2179         Unreviewed, build fix.
2180
2181         new-run-webkit-tests - fix a typo in r57480 that caused us to stop
2182         logging the actual list of unexpected results.
2183
2184         https://bugs.webkit.org/show_bug.cgi?id=37831
2185
2186         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2187
2188 2010-04-19  Dirk Pranke <dpranke@chromium.org>
2189
2190         Reviewed by Adam Barth.
2191
2192         From a patch by Tor Arne Vestbo  <tor.arne.vestbo@nokia.com>
2193
2194         new-run-webkit-tests: make the retry step more explicit
2195         https://bugs.webkit.org/show_bug.cgi?id=37606
2196
2197         It might be confusing to see the test and percent counters
2198         reset without any notice of what's going on, so we make the
2199         message that a retry-run is started explicit.
2200
2201         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2202
2203 2010-04-19  Sam Weinig  <weinig@apple.com>
2204
2205         Reviewed by Anders Carlsson.
2206
2207         Add support for opening a new window (File->New Window) to
2208         Windows MiniBrowser. Accelerator doesn't work.
2209
2210         * MiniBrowser/win/BrowserView.cpp:
2211         (createNewPage): Use BrowserView::create.
2212         * MiniBrowser/win/BrowserWindow.cpp:
2213         (BrowserWindow::onCommand): Respond to ID_FILE_NEW_WINDOW
2214         by creating a new window.
2215         * MiniBrowser/win/BrowserWindow.h:
2216         (BrowserWindow::create): Added. Don't allow creating
2217         BrowserWindows on the stack by making constructor
2218         private and exposing the create function.
2219         * MiniBrowser/win/MiniBrowser.cpp:
2220         (MiniBrowser::createNewWindow): Move new window creation
2221         logic here.
2222         * MiniBrowser/win/MiniBrowser.h:
2223         * MiniBrowser/win/MiniBrowser.rc: 
2224         * MiniBrowser/win/main.cpp:
2225         (_tWinMain): Use the new MiniBrowser::createNewWindow().
2226
2227 2010-04-19  Chris Fleizach  <cfleizach@apple.com>
2228
2229         Reviewed by Beth Dakin.
2230
2231         AX: aria-haspopup needs to be exposed
2232         https://bugs.webkit.org/show_bug.cgi?id=37808
2233
2234         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2235         (AccessibilityUIElement::hasPopup):
2236
2237 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2238
2239         Reviewed by Eric Seidel.
2240
2241         Submit a better workaround for r57806 than the one in r57831 - log
2242         an error and exit if you try to run new-run-webkit-tests with --use-drt
2243         on Windows.
2244
2245         https://bugs.webkit.org/show_bug.cgi?id=37822
2246
2247         * Scripts/webkitpy/layout_tests/port/chromium.py:
2248
2249 2010-04-19  Jesus Sanchez-Palencia  <jesus@webkit.org>
2250
2251         Unreviewed.
2252
2253         Just adding myself as a committer.
2254
2255         * Scripts/webkitpy/common/config/committers.py:
2256
2257 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2258
2259         Reviewed by Eric Seidel.
2260
2261         Add slightly better logging to the websocket python wrapper script,
2262         including a --verbose flag for debug output.
2263
2264         https://bugs.webkit.org/show_bug.cgi?id=37233
2265
2266         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2267         * Scripts/new-run-webkit-websocketserver:
2268
2269 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2270
2271         Reviewed by Eric Seidel.
2272
2273         new-run-webkit-tests: add a way (--print-unexpected-results) to
2274         (re-)print out the tests that produced unexpected results in the
2275         last run. Also add a way (--retry-unexpected-results) to
2276         automatically re-test them.
2277
2278         https://bugs.webkit.org/show_bug.cgi?id=37783
2279
2280         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2281
2282 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2283
2284         Reviewed by Eric Seidel.
2285
2286         Restructure the logging in new-run-webkit-tests so that many of log
2287         messages that were logged to the MeteredStream also get logged in
2288         --verbose mode.
2289
2290         https://bugs.webkit.org/show_bug.cgi?id=37780
2291
2292         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
2293         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2294
2295 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2296
2297         Reviewed by Eric Seidel.
2298
2299         new-run-webkit-tests: add 'summary' and 'unexpected-results' options
2300         to the --log flag. Also add a 'progress' flag to enable the regular
2301         progress bar (as opposed to 'detailed-progress', which enables the
2302         dots). Also add a 'nothing' flag to allow you to be explicit that
2303         you don't want any logging on the command line.
2304
2305         The default is
2306         '--log detailed-progress,summary,unexpected,unexpected-results'
2307
2308         (The default logging is unchanged by this patch, this just makes things
2309         properly configurable).
2310
2311         Note that 'nothing' doesn't work properly yet; I need a couple other
2312         patches to land to avoid rewriting things several different ways.
2313
2314         https://bugs.webkit.org/show_bug.cgi?id=37785
2315
2316         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2317
2318 2010-04-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2319
2320         Reviewed by Simon Hausmann.
2321
2322         Make the URL change on committed load.
2323
2324         * QtLauncher/mainwindow.cpp:
2325         (MainWindow::buildUI):
2326         (MainWindow::setAddressUrl):
2327         * QtLauncher/mainwindow.h:
2328
2329 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2330
2331         Reviewed by Eric Seidel.
2332
2333         Fix a typo in the rebaselining tool that causes us to use "debug"
2334         instead of "Debug" in a directory path, which fails on platforms with
2335         case-sensitive filesystems.
2336
2337         https://bugs.webkit.org/show_bug.cgi?id=37819
2338
2339         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2340
2341 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2342
2343         Unreviewed, build fix.
2344
2345         Fix breakage of chromium-win canary bots caused by r57806. That patch
2346         introduced the option of using Chrome's new port of DumpRenderTree,
2347         but unfortunately that port relies on the webkit.py class
2348         implementation which uses non-blocking I/O that isn't available on
2349         Windows. This patch turns off that option and doesn't import the
2350         class if we're running on Windows.
2351
2352         https://bugs.webkit.org/show_bug.cgi?id=37817
2353
2354         * Scripts/webkitpy/layout_tests/port/chromium.py:
2355
2356 2010-04-19  James Robinson  <jamesr@chromium.org>
2357
2358         Reviewed by abarth.
2359
2360         Fix a typo
2361
2362         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2363
2364 2010-04-19  Adam Roben  <aroben@apple.com>
2365
2366         Fix run-webkit-tests when there are spaces in the path
2367
2368         Fixes <http://webkit.org/b/37809>
2369
2370         Reviewed by Adam Barth.
2371
2372         * Scripts/run-webkit-tests: Use an "indirect object" to specify the
2373         path to the harness to exec(). According to perldoc, this usage will
2374         prohibit perl from parsing the arguments to exec() via the shell,
2375         which would incorrectly split paths with spaces in them, etc.
2376
2377 2010-04-19  Dimitri Glazkov  <dglazkov@chromium.org>
2378
2379         Reviewed by Adam Roben.
2380
2381         WinLauncher.h should use LF line-endings and use native line-endings style.
2382         https://bugs.webkit.org/show_bug.cgi?id=37807
2383
2384         * WinLauncher/WinLauncher.h: Added property svn:eol-style, converted to LF line-endings.
2385
2386 2010-04-19  Kent Tamura  <tkent@chromium.org>
2387
2388         Reviewed by Shinichiro Hamaji.
2389
2390         [DRT/Chromium] Fix a test initialization problem
2391         https://bugs.webkit.org/show_bug.cgi?id=37791
2392
2393         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2394         (runTest): Call resetTestController() before runFileTest(). Some
2395           controllers initialize their fields in reset() and not in their
2396           constructors.
2397
2398 2010-04-19  Kent Tamura  <tkent@chromium.org>
2399
2400         Reviewed by Eric Seidel.
2401
2402         [Chromium] new-run-webkit-tests should use WebKitDriver for --use-drt
2403         https://bugs.webkit.org/show_bug.cgi?id=37793
2404
2405         We need to use WebKitDriver instead of ChromiumDriver for Chromium
2406         DRT because its interface is different from test_shell.
2407
2408         Chromium DRT has no UI.  So we can't use it to show test results.
2409
2410         * Scripts/webkitpy/layout_tests/port/chromium.py:
2411
2412 2010-04-18  Eric Seidel  <eric@webkit.org>
2413
2414         Reviewed by Adam Roben.
2415
2416         Make failure-reason more forgiving
2417         https://bugs.webkit.org/show_bug.cgi?id=37525
2418
2419         Removed search_limit, which wasn't very useful anyway.
2420         Added a log about the long load time loading from the builders.
2421         Prompt the user for what revision to start walking from (makes it easy to restart upon failure).
2422
2423         * Scripts/webkitpy/common/net/buildbot.py:
2424         * Scripts/webkitpy/tool/commands/queries.py:
2425
2426 2010-04-18  Chris Jerdonek  <cjerdonek@webkit.org>
2427
2428         Reviewed by Shinichiro Hamaji.
2429
2430         Created a class for check-webkit-style that encapsulates iterating
2431         over text files and reading them.
2432
2433         https://bugs.webkit.org/show_bug.cgi?id=37754
2434
2435         This revision is an intermediate step towards separating our
2436         style-checking code from the logic of iterating over files and
2437         reading them.
2438
2439         * Scripts/webkitpy/common/system/logtesting.py:
2440           - Added a logMessages() method to the LoggingTestCase class.
2441             This method provides unit tests with access to the raw list
2442             of log messages in case the tester needs to do something more
2443             than simply assert the list of existing messages.
2444
2445         * Scripts/webkitpy/style/checker.py:
2446           - Added a ProcessorBase class that processors of lists of lines
2447             should eventually inherit from.
2448           - Also added a FIXME to use the ProcessorBase class and the
2449             TextFileReader class added below.
2450
2451         * Scripts/webkitpy/style/filereader.py: Added.
2452           - Created a TextFileReader class that encapsulates reading
2453             and iterating over text files.
2454
2455         * Scripts/webkitpy/style/filereader_unittest.py: Added.
2456           - Added a TextFileReaderTest class to unit-test the
2457             new TextFileReader class.
2458
2459 2010-04-15  Tony Chang  <tony@chromium.org>
2460
2461         Reviewed by Adam Barth.
2462
2463         [chromium] new-run-webkit-tests should be able to use chromium DRT
2464         https://bugs.webkit.org/show_bug.cgi?id=37645
2465
2466         Make sure that the lack of a chromium checkout doesn't cause the script to
2467         fail.
2468
2469         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2470         * Scripts/webkitpy/layout_tests/port/chromium.py:
2471         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Fix up a few paths
2472             to be relative to an upstream output dir.
2473         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --use-drt flag.
2474
2475 2010-04-18  Eric Seidel  <eric@webkit.org>
2476
2477         Unreviewed, fixing the Qt bot.
2478
2479         Add a layer of indirection when calling run-webkit-tests to allow testing new-run-webkit-tests on various platforms
2480         https://bugs.webkit.org/show_bug.cgi?id=37632
2481
2482         * Scripts/run-webkit-tests:
2483          - Exit non-zero of launching the harness fails.
2484
2485 2010-04-18  Eric Seidel  <eric@webkit.org>
2486
2487         Unreviewed, fixing the Qt bot.
2488
2489         Add a layer of indirection when calling run-webkit-tests to allow testing new-run-webkit-tests on various platforms
2490         https://bugs.webkit.org/show_bug.cgi?id=37632
2491
2492         * Scripts/run-webkit-tests:
2493          - Fix the wrapper to work for users who do not
2494            have WebKitTools/Scripts in their path.
2495
2496 2010-04-14  Eric Seidel  <eric@webkit.org>
2497
2498         Reviewed by Adam Barth.
2499
2500         Add a layer of indirection when calling run-webkit-tests to
2501         allow testing new-run-webkit-tests on various platforms.
2502         https://bugs.webkit.org/show_bug.cgi?id=37632
2503
2504         This will let us test and fix bugs in new-run-webkit-tests
2505         without needing to restart the buildbot master between tests.
2506
2507         Currently this change leaves run-webkit-tests as-is, but once
2508         its landed we will easily be able to turn on/off
2509         new-run-webkit-tests for various ports/configurations.
2510
2511         I will send a note out to webkit-dev about how we will
2512         be using this launcher script to test on the bots.
2513
2514         * Scripts/old-run-webkit-tests: Copied from WebKitTools/Scripts/run-webkit-tests.
2515         * Scripts/run-webkit-tests:
2516          - A new script which decides whether to run new- or old-
2517            run-webkit-tests based on the platform.
2518         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2519          - Add some dummy argument handling for arguments which
2520            old-run-webkit-tests supports but new-run-webkit-tests
2521            does not yet.
2522
2523 2010-04-18  Eric Seidel  <eric@webkit.org>
2524
2525         Reviewed by Adam Barth.
2526
2527         Add Gtk bots to the list of "core builders" (builders which stop the commit-queue when they turn red)
2528         https://bugs.webkit.org/show_bug.cgi?id=33295
2529
2530         The Gtk builders have been green every time I've looked
2531         at them in the last 5 days or so.  It would appear webkit
2532         is now keeping them green and we should update the core
2533         builder list to match reality.
2534
2535         * Scripts/webkitpy/common/net/buildbot.py:
2536         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2537
2538 2010-04-18  Robert Hogan  <robert@webkit.org>
2539
2540         Reviewed by Simon Hausmann.
2541
2542         [Qt] Add support for LayoutTestController commands:
2543                    setSmartInsertDeleteEnabled
2544                    setSelectTrailingWhitespaceEnabled
2545                    execCommand
2546                    isCommandEnabled
2547
2548         https://bugs.webkit.org/show_bug.cgi?id=35844
2549
2550         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2551         (WebCore::WebPage::resetSettings):
2552         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2553         (LayoutTestController::setSmartInsertDeleteEnabled):
2554         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
2555         (LayoutTestController::execCommand):
2556         (LayoutTestController::isCommandEnabled):
2557         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2558
2559 2010-04-17  Adam Barth  <abarth@webkit.org>
2560
2561         Reviewed by Eric Seidel.
2562
2563         Remove steps_references and commands_references
2564         https://bugs.webkit.org/show_bug.cgi?id=37758
2565
2566         We tried using the mumble_references convention to manage our
2567         dependencies, but it doesn't seem to be providing much value for the
2568         steps and commands module because these modules are small pieces of the
2569         larger tool module.  In this patch, I've removed the references file
2570         for these modules.
2571  
2572         I've left the style_references file for the style module because that
2573         module seems better isolated from the rest of webkitpy and the
2574         style_references file appears to be providing some value.
2575
2576         * Scripts/webkitpy/tool/commands/commandtest.py:
2577         * Scripts/webkitpy/tool/commands/download_unittest.py:
2578         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2579         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2580         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2581         * Scripts/webkitpy/tool/commands/queuestest.py:
2582         * Scripts/webkitpy/tool/commands/upload.py:
2583         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2584         * Scripts/webkitpy/tool/commands_references.py: Removed.
2585         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
2586         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2587         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
2588         * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py:
2589         * Scripts/webkitpy/tool/steps_references.py: Removed.
2590
2591 2010-04-17  Eric Seidel  <eric@webkit.org>
2592
2593         Reviewed by Adam Barth.
2594
2595         WebKit needs a Chromium Mac EWS Builder
2596         https://bugs.webkit.org/show_bug.cgi?id=37742
2597
2598         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2599
2600 2010-04-17  Adam Barth  <abarth@webkit.org>
2601
2602         Fix expected results for unit test broken by
2603         http://trac.webkit.org/changeset/57772
2604
2605         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2606
2607 2010-04-17  Sam Weinig  <weinig@apple.com>
2608
2609         Reviewed by Adam Roben.
2610
2611         Teach windows MiniBrowser how to work with window.open()
2612         and targeted links.
2613
2614         * MiniBrowser/win/BrowserView.cpp:
2615         (createNewPage): Create a new BrowserWindow and return its page.
2616         (showPage): Show the page.
2617         (closePage): Empty implementation.
2618         (runJavaScriptAlert): Empty implementation.
2619         (BrowserView::create): Register a UIClient.
2620         * MiniBrowser/win/BrowserView.h:
2621         (BrowserView::webView): Added.
2622         Change create to take a BrowserWindow instead of an HWND.
2623
2624         * MiniBrowser/win/BrowserWindow.cpp:
2625         (BrowserWindow::wndProc): Respond to WM_NCDESTROY.
2626         (BrowserWindow::goToURL): Added. Forwards to BrowserView.
2627         (BrowserWindow::onCreate): Don't always go to the default
2628         url. Let the caller do this.
2629         (BrowserWindow::onNCDestroy): Delete the window.
2630         * MiniBrowser/win/BrowserWindow.h:
2631         (BrowserWindow::view): Added.
2632         (BrowserWindow::window): Added.
2633
2634         * MiniBrowser/win/main.cpp:
2635         (_tWinMain):
2636         Go to the default URL for the initial page. Allocate the initial
2637         window on the heap for correctness.
2638
2639 2010-04-16  Adam Roben  <aroben@apple.com>
2640
2641         Add the Windows Debug (Test) builder to the list of core builders
2642
2643         It's been green for a few days now, and all the known Windows
2644         flakiness is Release-only.
2645
2646         Rubber-stamped by Mark Rowe.
2647
2648         * Scripts/webkitpy/common/net/buildbot.py:
2649         (BuildBot.core_builder_name_regexps): Added a regular expression to
2650         match the "Windows Debug (Test)" builder.
2651
2652 2010-04-16  Sam Weinig  <sam@webkit.org>
2653
2654         Reviewed by Anders Carlsson.
2655
2656         Fix window.open() and targeted links.
2657
2658         * MiniBrowser/mac/BrowserWindowController.m:
2659         (_createNewPage): Use the correct initializer to and load the window.
2660
2661 2010-04-16  Adam Roben  <aroben@apple.com>
2662
2663         Fix links to layout test results from build status pages
2664
2665         Reviewed by Mark Rowe.
2666
2667         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2668         (ExtractTestResults.finished): Prepend "/" on the URL of the test
2669         results page so that it is treated as an absolute URL.
2670
2671 2010-04-16  Tony Chang  <tony@chromium.org>
2672
2673         Reviewed by Dimitri Glazkov.
2674
2675         [chromium] build DRT on Linux
2676         https://bugs.webkit.org/show_bug.cgi?id=37690
2677
2678         * Scripts/build-dumprendertree: Add support for win and linux
2679
2680 2010-04-16  Sam Weinig  <weinig@apple.com>
2681
2682         Reviewed by Adam Roben.
2683
2684         Use the threaded process model for MiniBrowser if holding down
2685         the shift key on startup.
2686
2687         * MiniBrowser/win/BrowserView.cpp:
2688         (BrowserView::create): 
2689
2690 2010-04-15  Tony Chang  <tony@chromium.org>
2691
2692         Reviewed by Dimitri Glazkov.
2693
2694         [chromium] Add TestShellGtk.cpp so we can link on Linux
2695         https://bugs.webkit.org/show_bug.cgi?id=37561
2696
2697         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Add new file and
2698             add platform file exceptions.
2699         * DumpRenderTree/chromium/TestShellGtk.cpp: Added.
2700         (AlarmHandler):
2701         (TestShell::waitTestFinished):
2702
2703 2010-04-15  Tony Chang  <tony@chromium.org>
2704
2705         Reviewed by Dimitri Glazkov.
2706
2707         build DRT on chromium mac
2708         https://bugs.webkit.org/show_bug.cgi?id=37639
2709
2710         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2711         * Scripts/build-dumprendertree: enable build-dumprendertree --chromium
2712
2713 2010-04-15  Kent Tamura  <tkent@chromium.org>
2714
2715         Reviewed by Dimitri Glazkov.
2716
2717         [DRT/Chromium] Add LayoutTestHelper for Mac
2718         https://bugs.webkit.org/show_bug.cgi?id=37668
2719
2720         LayouTestHelper.mm is based on webkit/tools/test_shell/mac/layout_test_helper.mm
2721         of Chromium.
2722
2723         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2724         * DumpRenderTree/chromium/LayoutTestHelper.mm: Added.
2725
2726 2010-04-15  Alexey Proskuryakov  <ap@apple.com>
2727
2728         Reviewed by Geoff Garen.
2729
2730         https://bugs.webkit.org/show_bug.cgi?id=37494
2731         <rdar://problem/7857060> REGRESSION (r57340): fast/events/mouse-drag-from-frame-to-other-frame.html
2732         fails on Windows
2733
2734         * DumpRenderTree/win/EventSender.cpp: (makeEventSender):
2735         * DumpRenderTree/win/EventSender.h:
2736         Tell EventSender if it's being created for a top frame.
2737         
2738         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2739         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld): We only want to reset
2740         EventSender machinery when a new test is loaded, not when an iframe (or just its global
2741         object) is created.
2742
2743 2010-04-15  Adam Roben  <aroben@apple.com>
2744
2745         Fix Windows WebKit2 build.
2746
2747         * MiniBrowser/win/MiniBrowser.cpp:
2748
2749 2010-04-15  Ojan Vafai  <ojan@chromium.org>
2750
2751         Reviewed by Adam Barth.
2752
2753         Include codereview issue number in patch description
2754         https://bugs.webkit.org/show_bug.cgi?id=37677
2755
2756         This lets us know which rietveld issue this patch is tied to.
2757
2758         Also, make it so that --fancy-review overrides --no-review.
2759
2760         * Scripts/webkitpy/tool/steps/postcodereview.py:
2761         * Scripts/webkitpy/tool/steps/postdiff.py:
2762
2763 2010-04-15  Adam Roben  <aroben@apple.com>
2764
2765         Make --exit-after-n-failures work when all tests are timing out or crashing
2766
2767         Fixes <http://webkit.org/b/37679>.
2768
2769         Reviewed by Jon Honeycutt.
2770
2771         * Scripts/run-webkit-tests:
2772         (top level): When a test crashes or times out, break out of the main loop if
2773         stopRunningTestsEarlyIfNeeded returns true. Moved some code from the bottom of the main loop
2774         from here...
2775         (stopRunningTestsEarlyIfNeeded): ...to here.
2776
2777 2010-04-15  Sam Weinig  <sam@webkit.org>
2778
2779         Reviewed by Anders Carlsson.
2780
2781         Add WebHistoryClient support.
2782         https://bugs.webkit.org/show_bug.cgi?id=37671
2783
2784         Add HistoryClient logging.
2785
2786         * MiniBrowser/mac/BrowserWindowController.m:
2787         (_didNavigateWithNavigationData):
2788         (_didPerformClientRedirect):
2789         (_didPerformServerRedirect):
2790         (_didUpdateHistoryTitle):
2791         (-[BrowserWindowController awakeFromNib]):
2792
2793 2010-04-15  Anders Carlsson  <andersca@apple.com>
2794
2795         Reviewed by Sam Weinig.
2796
2797         Start the mini browser in threaded mode if shift is pressed during startup.
2798         https://bugs.webkit.org/show_bug.cgi?id=37670
2799
2800         * MiniBrowser/mac/AppDelegate.m:
2801         (-[BrowserAppDelegate init]):
2802
2803 2010-04-15  Chris Fleizach  <cfleizach@apple.com>
2804
2805         Reviewed by Beth Dakin.
2806
2807         AXHelp is being appended from ancestors incorrectly
2808         https://bugs.webkit.org/show_bug.cgi?id=37659
2809
2810         * DumpRenderTree/AccessibilityUIElement.cpp:
2811         (getHelpTextCallback):
2812         (AccessibilityUIElement::getJSClass):
2813         * DumpRenderTree/AccessibilityUIElement.h:
2814         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2815         (AccessibilityUIElement::helpText):
2816         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2817         (AccessibilityUIElement::helpText):
2818         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2819         (AccessibilityUIElement::helpText):
2820
2821 2010-04-15  Dirk Pranke  <dpranke@chromium.org>
2822
2823         Reviewed by Adam Barth.
2824
2825         Re-format run-webkit-tests to fit in 80-columns for PEP-8 compliance.
2826         (broken by r57463 and r57381, at least). I've also filed bug 37477
2827         to fix check-webkit-style to catch these things.
2828
2829         https://bugs.webkit.org/show_bug.cgi?id=38586
2830
2831         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2832
2833 2010-04-15  Dirk Pranke  <dpranke@chromium.org>
2834
2835         Reviewed by Dimitri Glazkov.
2836
2837         Add a way to override the user-visible name for the test binary since
2838         some ports don't call it DumpRenderTree (e.g., Chromium Win uses
2839         test_shell, Chromium Mac uses TestShell) by adding a driver_name()
2840         method to the Port interface.
2841
2842         https://bugs.webkit.org/show_bug.cgi?id=37631
2843
2844         * Scripts/webkitpy/layout_tests/port/base.py:
2845         * Scripts/webkitpy/layout_tests/port/chromium.py:
2846         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2847         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2848
2849 2010-04-14  Anders Carlsson  <andersca@apple.com>
2850
2851         Reviewed by Adam Roben.
2852
2853         Add "Force Repaint" to debug menu.
2854         https://bugs.webkit.org/show_bug.cgi?id=37627
2855
2856         * MiniBrowser/mac/BrowserWindowController.h:
2857         * MiniBrowser/mac/BrowserWindowController.m:
2858         (-[BrowserWindowController forceRepaint:]):
2859         * MiniBrowser/mac/English.lproj/MainMenu.xib:
2860
2861 2010-04-15  Sam Weinig  <sam@webkit.org>
2862
2863         Reviewed by Adam Roben.
2864
2865         Add debug-minibrowser script.
2866
2867         * Scripts/debug-minibrowser: Copied from Scripts/run-minibrowser.
2868         * Scripts/webkitdirs.pm:
2869
2870 2010-04-15  Roland Steiner  <rolandsteiner@chromium.org>
2871  
2872         Reviewed by Dimitri Glazkov.
2873
2874         Bug 37636 - [DRT/Chromium] Implement DRT/Chromium for Windows
2875         https://bugs.webkit.org/show_bug.cgi?id=37636
2876  
2877         Second patch: add Windows-specific implementation parts
2878         of TestShell.
2879
2880         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2881         * DumpRenderTree/chromium/TestShell.h:
2882         (TestShell::finishedEvent):
2883         * DumpRenderTree/chromium/TestShellWin.cpp:
2884         (watchDogThread):
2885         (TestShell::waitTestFinished):
2886
2887 2010-04-15  Roland Steiner  <rolandsteiner@chromium.org>
2888
2889         Reviewed by Dimitri Glazkov.
2890
2891         Bug 37636 - [DRT/Chromium] Implement DRT/Chromium for Windows
2892         https://bugs.webkit.org/show_bug.cgi?id=37636
2893
2894         First patch: fix compiler errors.
2895
2896         * DumpRenderTree/chromium/EventSender.cpp:
2897         (EventSender::reset):
2898         (EventSender::dispatchMessage):
2899         * DumpRenderTree/chromium/LayoutTestController.cpp:
2900         (LayoutTestController::pathToLocalResource):
2901         * DumpRenderTree/chromium/TestWebWorker.h:
2902         * DumpRenderTree/chromium/TextInputController.cpp:
2903         * DumpRenderTree/chromium/WebViewHost.h:
2904         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2905
2906 2010-04-14  Luiz Agostini  <luiz.agostini@openbossa.org>
2907
2908         Reviewed by Simon Hausmann.
2909
2910         [Qt] Moving setViewMode from DumpRenderTreeSupportQt to qwebpage.cpp
2911         https://bugs.webkit.org/show_bug.cgi?id=37622
2912
2913         Method qt_wrt_setViewMode was removed from qwebpage.cpp by mistake in r57433
2914         (bug 35844). Moving it back.
2915
2916         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2917         (LayoutTestController::setViewModeMediaFeature):
2918
2919 2010-04-15  Dirk Pranke  <dpranke@chromium.org>
2920
2921         Reviewed by Adam Barth.
2922
2923         Add some very minimal unit tests for new-run-webkit-tests. This should
2924         be enough to catch egregious brokenness like syntax errors and import
2925         declaration issues.
2926
2927         https://bugs.webkit.org/show_bug.cgi?id=37432
2928
2929         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2930         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: Added.
2931
2932 2010-04-14  Brian Weinstein  <bweinstein@apple.com>
2933
2934         Reviewed by Adam Roben.
2935
2936         Add a way for the buildbot to kill any old processes that are running. This
2937         is useful because the Windows bots can get in states where a process remains
2938         running (httpd.exe, DumpRenderTree.exe), which causes the bots to get in a red
2939         state, and the processes must be killed manually.
2940
2941         * BuildSlaveSupport/build.webkit.org-config/master.cfg: If we are on Windows, kill
2942             the old processes that might be running.
2943         * BuildSlaveSupport/win/kill-old-processes: Added.
2944
2945 2010-04-14  Sam Weinig  <sam@webkit.org>
2946
2947         Reviewed by Anders Carlsson.
2948
2949         Tear down WebKit more completely on window closing and application
2950         termination. We still don't block application termination for pending
2951         close, but this is a step in the right direction.
2952
2953         * MiniBrowser/mac/AppDelegate.m:
2954         (-[BrowserAppDelegate applicationWillTerminate:]):
2955         * MiniBrowser/mac/BrowserWindowController.h:
2956         * MiniBrowser/mac/BrowserWindowController.m:
2957         (-[BrowserWindowController dealloc]):
2958         (-[BrowserWindowController windowWillClose:]):
2959         (-[BrowserWindowController applicationTerminating]):
2960
2961 2010-04-14  Adam Barth  <abarth@webkit.org>
2962
2963         Reviewed by Eric Seidel.
2964
2965         Use pretty patch for confirming webkit-patch diffs
2966         https://bugs.webkit.org/show_bug.cgi?id=37489
2967
2968         * Scripts/webkitpy/common/prettypatch.py: Added.
2969         * Scripts/webkitpy/tool/commands/download_unittest.py:
2970         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2971         * Scripts/webkitpy/tool/mocktool.py:
2972         * Scripts/webkitpy/tool/steps/confirmdiff.py:
2973
2974 2010-04-14  Eric Seidel  <eric@webkit.org>
2975
2976         Reviewed by Adam Barth.
2977
2978         Teach webkit-patch how to handle revisions missing ChangeLogs
2979         https://bugs.webkit.org/show_bug.cgi?id=37519
2980
2981         Make commit_info_for_revision return None when revision
2982         is missing a ChangeLog.  Previously we would throw an array index
2983         exception.
2984         Teach callers how to handle None.
2985
2986         * Scripts/webkitpy/common/checkout/api.py:
2987         * Scripts/webkitpy/common/checkout/api_unittest.py:
2988         * Scripts/webkitpy/tool/commands/download.py:
2989         * Scripts/webkitpy/tool/commands/queries.py:
2990         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2991
2992 2010-04-13  Eric Seidel  <eric@webkit.org>
2993
2994         Reviewed by Adam Roben.
2995
2996         Add Qt Bot to the list of "core builders" (builders which block the commit-queue when red)
2997         https://bugs.webkit.org/show_bug.cgi?id=33297
2998
2999         This is an experiment.  The bots have been green for
3000         a while.  We'll see if adding them under sheriff-bot protection
3001         will keep them green.
3002
3003         * Scripts/webkitpy/common/net/buildbot.py:
3004         * Scripts/webkitpy/common/net/buildbot_unittest.py:
3005
3006 2010-04-13  Eric Seidel  <eric@webkit.org>
3007
3008         Unreviewed, just fixing a constant in the Rietveld unit test.
3009
3010         * Scripts/webkitpy/common/net/rietveld_unittest.py
3011
3012 2010-04-13  Eric Seidel  <eric@webkit.org>
3013
3014         Unreviewed, just adding missing Mock to fix python tests.
3015
3016         * Scripts/webkitpy/tool/mocktool.py:
3017
3018 2010-04-13  Ojan Vafai  <ojan@chromium.org>
3019
3020         Reviewed by David Levin.
3021
3022         Add experimental prototype Rietveld integration to webkit-patch upload
3023         https://bugs.webkit.org/show_bug.cgi?id=37418
3024
3025         This patch adds bare-bones integration with Rietveld for code reviews.
3026         The behavior is hidden behind the --fancy-review command line flag.
3027         Currently, there's no support for uploading more than one patch per
3028         issue (which is a nice feature of Rietveld).  The plan is to play with
3029         this for a bit and see if it's useful.
3030
3031         Modified from Adam's original patch to autoinstall the rietveld upload script.
3032
3033         * Scripts/webkitpy/common/config/__init__.py:
3034         * Scripts/webkitpy/common/net/rietveld.py: Added.
3035         * Scripts/webkitpy/common/net/rietveld_unitttest.py: Added.
3036         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3037         * Scripts/webkitpy/tool/commands/upload.py:
3038         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3039         * Scripts/webkitpy/tool/main.py:
3040         * Scripts/webkitpy/tool/mocktool.py:
3041         * Scripts/webkitpy/tool/steps/__init__.py:
3042         * Scripts/webkitpy/tool/steps/options.py:
3043         * Scripts/webkitpy/tool/steps/postcodereview.py: Added.
3044         * Scripts/webkitpy/tool/steps/postdiff.py:
3045
3046 2010-04-13  Sam Weinig  <sam@webkit.org>
3047
3048         Rubber-stamped by Mark Rowe.
3049
3050         Add Makefile to MiniBrowser.
3051
3052         * MiniBrowser/Makefile: Added.
3053
3054 2010-04-13  Eric Seidel  <eric@webkit.org>
3055
3056         Unreviewed, just adding a sanity check.
3057
3058         Add check to make sure commit-queue can never commit too short a message
3059         https://bugs.webkit.org/show_bug.cgi?id=37528
3060
3061         The commit-queue made bogus messages here:
3062         http://trac.webkit.org/changeset/57532
3063         http://trac.webkit.org/changeset/57534
3064
3065         This was a regression caused by adding unicode parsing for
3066         our ChangeLog files.  Popen does not seem to play nice with
3067         unicode strings.
3068
3069         I'm also adding an "assert" to make sure short ChangeLogs never happen again.
3070
3071         * Scripts/webkitpy/common/system/executive.py:
3072          - Cast input to strings before passing to POpen
3073         * Scripts/webkitpy/tool/steps/commit.py:
3074          - Validate that commit messages are not to short.
3075
3076 2010-04-13  Adam Roben  <aroben@apple.com>
3077
3078         Robustify new-run-webkit-tests against paths with spaces in them
3079
3080         Reviewed by Eric Seidel.
3081
3082         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
3083         (LayoutTestApacheHttpd.__init__): Quote all paths that we pass to
3084         Apache to ensure that paths with spaces in them are interpreted
3085         correctly.
3086
3087 2010-04-13  Csaba Osztrogonác  <ossy@webkit.org>
3088
3089         Unreviewed buildfix after r57537.
3090
3091         * DumpRenderTree/qt/LayoutTestControllerQt.h: Declaration of removeOriginAccessWhitelistEntry() added.
3092
3093 2010-04-13  Sam Weinig  <sam@webkit.org>
3094
3095         Reviewed by Maciej Stachowiak.
3096
3097         Make building new webkit API and MiniBrowser a little easier.
3098
3099         * Scripts/build-webkit: Make building with --webkit2 build the 
3100         MiniBrowser as well and tell you how to use it.
3101         * Scripts/run-minibrowser: Copied from Scripts/run-safari.
3102         * Scripts/webkitdirs.pm: Add runMiniBrowser function.
3103
3104 2010-04-12  Timothy Hatcher  <timothy@apple.com>
3105
3106         SecurityOrigin needs a way to remove individual OriginAccessEntries
3107         https://bugs.webkit.org/show_bug.cgi?id=37449
3108
3109         Reviewed by Dave Hyatt.
3110
3111         * DumpRenderTree/LayoutTestController.cpp:
3112         (removeOriginAccessWhitelistEntryCallback): Added. Call LayoutTestController::removeOriginAccessWhitelistEntry.
3113         (LayoutTestController::staticFunctions): Added removeOriginAccessWhitelistEntry.
3114         * DumpRenderTree/LayoutTestController.h:
3115         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3116         (LayoutTestController::removeOriginAccessWhitelistEntry): Added. FIXME to implement.
3117         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3118         (LayoutTestController::removeOriginAccessWhitelistEntry): Added.
3119         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3120         (LayoutTestController::removeOriginAccessWhitelistEntry): Added. FIXME to implement.
3121         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3122         (LayoutTestController::removeOriginAccessWhitelistEntry): Added.
3123         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3124         (LayoutTestController::whiteListAccessFromOrigin): FIXME to implement.
3125         (LayoutTestController::removeOriginAccessWhitelistEntry): Added. FIXME to implement.
3126
3127 2010-04-13  Timothy Hatcher  <timothy@apple.com>
3128
3129         Rename SecurityOrigin::whiteListAccessFromOrigin to addOriginAccessWhitelistEntry.
3130         And LayoutTestController.whiteListAccessFromOrigin to addOriginAccessWhitelistEntry.
3131         And SecurityOrigin::resetOriginAccessWhiteLists to resetOriginAccessWhitelists.
3132
3133         SecurityOrigin needs a way to remove individual OriginAccessEntries
3134         https://bugs.webkit.org/show_bug.cgi?id=37449
3135
3136         Reviewed by Dave Hyatt.
3137
3138         * DumpRenderTree/LayoutTestController.cpp:
3139         (addOriginAccessWhitelistEntryCallback):
3140         (LayoutTestController::staticFunctions):
3141         * DumpRenderTree/LayoutTestController.h:
3142         * DumpRenderTree/chromium/LayoutTestController.cpp:
3143         (LayoutTestController::LayoutTestController):
3144         (LayoutTestController::addOriginAccessWhitelistEntry):
3145         * DumpRenderTree/chromium/LayoutTestController.h:
3146         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3147         (LayoutTestController::addOriginAccessWhitelistEntry):
3148         * DumpRenderTree/mac/DumpRenderTree.mm:
3149         (resetWebViewToConsistentStateBeforeTesting):
3150         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3151         (LayoutTestController::addOriginAccessWhitelistEntry):
3152         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3153         (LayoutTestController::addOriginAccessWhitelistEntry):
3154         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3155         * DumpRenderTree/win/DumpRenderTree.cpp:
3156         (resetWebViewToConsistentStateBeforeTesting):
3157         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3158         (LayoutTestController::addOriginAccessWhitelistEntry):
3159         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3160         (LayoutTestController::addOriginAccessWhitelistEntry):
3161
3162 2010-04-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3163
3164         Reviewed by Eric Seidel.
3165
3166         Remove duplicate function for new-run-webkit-tests
3167         https://bugs.webkit.org/show_bug.cgi?id=37517
3168
3169         The version() function was already implemented.
3170
3171         * Scripts/webkitpy/layout_tests/port/webkit.py:
3172
3173 2010-04-13  Eric Seidel  <eric@webkit.org>
3174
3175         Reviewed by David Levin.
3176
3177         the commit-queue hates Tor Arne Vestbø
3178         https://bugs.webkit.org/show_bug.cgi?id=37511
3179
3180         We were failing to read reviewers out of ChangeLogs
3181         when the reviewer has unicode characters in his/her name.
3182         I fixed this by explicitly decoding from utf8 every time we
3183         read in a ChangeLog file (they are always UTF8).
3184
3185         * Scripts/webkitpy/common/checkout/changelog.py:
3186         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3187
3188 2010-04-13  Adam Roben  <aroben@apple.com>
3189
3190         Fix run-webkit-tests on Windows with spaces in the path
3191
3192         Fixes <http://webkit.org/b/37509>.
3193
3194         Reviewed by Steve Falkenburg.
3195
3196         * Scripts/run-webkit-tests:
3197         (convertPathUsingCygpath): Remove spaces from the path before passing
3198         them to cygpath, then add them back in after conversion, as some
3199         versions of cygpath seem to convert spaces into newlines.
3200
3201 2010-04-13  Adam Barth  <abarth@webkit.org>
3202
3203         Unreviewed, but approved by Dumitru Daniliuc.  (This patch is intended
3204         to fix the downstream Chromium build bots.  Hopefully it will work!)
3205
3206         Add a driver script for the new websocket server
3207         https://bugs.webkit.org/show_bug.cgi?id=37495
3208
3209         websocket_server.py can't be run directly because its a module and not
3210         a standalone script.  This used to work by accident because it didn't
3211         depend on any other modules.
3212
3213         * Scripts/new-run-webkit-websocketserver: Added.
3214         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
3215
3216 2010-04-12  Eric Seidel  <eric@webkit.org>
3217
3218         Reviewed by Adam Barth.
3219
3220         Make new-run-webkit-test PrettyPatch failure reporting more awesome
3221         https://bugs.webkit.org/show_bug.cgi?id=37487
3222
3223         I also fixed an Executive/executive typo.
3224
3225         * Scripts/webkitpy/layout_tests/port/base.py:
3226
3227 2010-04-12  Eric Seidel  <eric@webkit.org>
3228
3229         Reviewed by Adam Barth.
3230
3231         new-run-webkit-tests should only build java support files on Mac
3232         https://bugs.webkit.org/show_bug.cgi?id=37482
3233
3234         Only the mac needs java support files, so I pushed _build_java
3235         down into the Mac port using a new hook "_check_port_build".
3236         In the process I noticed a bunch of code which could be shared
3237         between all ports and thus got rid of _tests_for_disabled_features
3238         and version() copy/paste between all webkit ports.
3239         I also made check_build only bother to check for ImageDiff if we're
3240         using pixel tests.
3241
3242         * Scripts/webkitpy/layout_tests/port/gtk.py:
3243         * Scripts/webkitpy/layout_tests/port/mac.py:
3244         * Scripts/webkitpy/layout_tests/port/qt.py:
3245         * Scripts/webkitpy/layout_tests/port/webkit.py:
3246         * Scripts/webkitpy/layout_tests/port/win.py:
3247
3248 2010-04-12  Dumitru Daniliuc  <dumi@chromium.org>
3249
3250         Unreviewed, trying to make scripts work on machines without
3251         Ruby...
3252
3253         * Scripts/webkitpy/layout_tests/port/base.py:
3254
3255 2010-04-12  Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
3256
3257         Reviewed by Eric Seidel.
3258
3259         Add stub files for running new-run-webkit-tests for the Qt port
3260
3261         * Scripts/webkitpy/layout_tests/port/factory.py:
3262         * Scripts/webkitpy/layout_tests/port/qt.py: Added.
3263
3264 2010-04-12  Dirk Pranke  <dpranke@chromium.org>
3265
3266         Reviewed by Eric Seidel.
3267
3268         Modify run_webkit_tests.py to not call sys.exit() at the end of test
3269         run; doing so makes it more difficult to embed the routine for,
3270         among other things, unit tests. We push the exit calling up into
3271         new-run-webkit-tests.
3272
3273         https://bugs.webkit.org/show_bug.cgi?id=37464
3274
3275         * Scripts/new-run-webkit-tests:
3276         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3277
3278 2010-04-12  Eric Seidel  <eric@webkit.org>
3279
3280         Unreviewed.
3281
3282         Add stub Gtk implementation for new-run-webkit-tests.
3283
3284         * Scripts/webkitpy/layout_tests/port/factory.py:
3285         * Scripts/webkitpy/layout_tests/port/gtk.py: Added.
3286
3287 2010-04-12  Eric Seidel  <eric@webkit.org>
3288
3289         Reviewed by Adam Barth.
3290
3291         new-run-webkit-tests fails with exception on systems missing ruby
3292         https://bugs.webkit.org/show_bug.cgi?id=37441
3293
3294         * Scripts/webkitpy/layout_tests/port/base.py:
3295          - Catch failures similar to how wdiff code path does.
3296          - After one failure, stop trying.
3297
3298 2010-04-12  Tony Chang  <tony@chromium.org>
3299
3300         Reviewed by Eric Seidel.
3301
3302         Fix how we import simplejson based on how it's used in this file.
3303         This fixes exceptions raised when trying to write the simplejson output.
3304
3305         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3306
3307 2010-04-11  Chris Jerdonek  <cjerdonek@webkit.org>
3308
3309         Reviewed by Shinichiro Hamaji.
3310
3311         Refactored check-webkit-style so that the StyleChecker class
3312         has no dependencies on patch-related concepts.
3313
3314         https://bugs.webkit.org/show_bug.cgi?id=37065
3315
3316         This patch is an intermediate step towards making the StyleChecker
3317         class a generalized file processor that can do arbitary operations
3318         on the files corresponding to a list of paths.  This patch
3319         also simplifies the unit-testing of patch-checking code.
3320
3321         * Scripts/check-webkit-style:
3322           - Updated to use the new PatchChecker class.
3323
3324         * Scripts/webkitpy/style/checker.py:
3325           - Refactored the StyleChecker.check_patch() method into the
3326             check() method of a new PatchChecker class.
3327
3328         * Scripts/webkitpy/style/checker_unittest.py:
3329           - Refactored the unit tests as necessary, changing the
3330             StyleCheckerCheckPatchTest class to a PatchCheckerTest class.
3331
3332 2010-04-11  Adam Barth  <abarth@webkit.org>
3333
3334         Unreviewed.
3335
3336         Fix new-run-webkit-tests regressions cased by Eric's option parsing patch
3337         https://bugs.webkit.org/show_bug.cgi?id=37430
3338
3339         We need some basic unit testing of this script, or we're going to keep
3340         breaking it like this.  Added missing namespace qualifiers and
3341         propagated renaming of an option.
3342
3343         * Scripts/webkitpy/common/config/ports.py:
3344         * Scripts/webkitpy/layout_tests/driver_test.py:
3345         * Scripts/webkitpy/layout_tests/port/base.py:
3346         * Scripts/webkitpy/layout_tests/port/mac.py:
3347         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3348
3349 2010-04-11  Eric Seidel  <eric@webkit.org>
3350
3351         Reviewed by Adam Barth.
3352
3353         Break new-run-webkit-tests options into groups for easier re-use and possible relocation
3354         https://bugs.webkit.org/show_bug.cgi?id=37408
3355
3356         new-run-webkit-tests currently has one huge function for
3357         dealing with all options-parsing. 
3358         This patch is a first attempt at trying to split that large
3359         function down into smaller (hopefully more readable?) chunks
3360         dealing with the different areas of options.
3361         For example, it would make sense to move configuration
3362         options off into some module which deals with the vagries of
3363         WebKit's configuration system.  It would also make sense to move
3364         Chromium options off onto the Chromium port object (where they are used).
3365         It may make sense to move results.json options over to the results.json code.
3366         This change is a first iteration, and we will certainly need more
3367         refinement to this code over time.  Hopefully I didn't make things
3368         harder to read here.
3369
3370         * Scripts/webkitpy/layout_tests/driver_test.py:
3371         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3372
3373 2010-04-11  Adam Barth  <abarth@webkit.org>
3374
3375         Reviewed by Eric Seidel.
3376
3377         create-rollout copy needs to be updated to reflect removal of --no-build
3378         https://bugs.webkit.org/show_bug.cgi?id=37425
3379
3380         Removed --no-build and --no-test from the instructions because these
3381         don't exist anymore.
3382
3383         * Scripts/webkitpy/tool/commands/download_unittest.py:
3384             - Updated the expected results to reflect the new copy.
3385         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
3386
3387 2010-04-11  Sheriff Bot  <webkit.review.bot@gmail.com>
3388
3389         Unreviewed, rolling out r57460.
3390         http://trac.webkit.org/changeset/57460
3391         https://bugs.webkit.org/show_bug.cgi?id=37424
3392
3393         broke chromium builders (Requested by tony^work on #webkit).
3394
3395         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3396
3397 2010-04-11  Tony Chang  <tony@chromium.org>
3398
3399         Reviewed by Darin Fisher.
3400
3401         [chromium] update chromium DEPS for upstream compile
3402         https://bugs.webkit.org/show_bug.cgi?id=36578
3403
3404         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Small fix to avoid a circular dependency between
3405           WebKit.gyp and webkit.gyp.
3406
3407 2010-04-11  Joseph Pecoraro  <joepeck@webkit.org>
3408
3409         Reviewed by Eric Seidel.
3410
3411         svn-apply errors out when removing directories in git
3412         https://bugs.webkit.org/show_bug.cgi?id=34871
3413
3414         * Scripts/svn-apply:
3415         (isDirectoryEmptyForRemoval): early break if the directory doesn't exist
3416         (scmRemove): have git ignore unmatched files
3417
3418 2010-04-11  Daniel Bates  <dbates@rim.com>
3419
3420         No review, rolling out 57440.
3421         http://trac.webkit.org/changeset/57440
3422         https://bugs.webkit.org/show_bug.cgi?id=27204
3423
3424         Did not handle Git patches that included both file and property
3425         changes to the same file. Rolling this change out while I look
3426         into this.
3427
3428         * Scripts/VCSUtils.pm:
3429         * Scripts/svn-apply:
3430         * Scripts/svn-unapply:
3431         * Scripts/webkitperl/VCSUtils_unittest/appendSVNExecutableBitChangeToPatch.pl: Removed.
3432         * Scripts/webkitperl/VCSUtils_unittest/parseGitFileMode.pl: Removed.
3433         * Scripts/webkitperl/VCSUtils_unittest/parseStartOfPatchOrPropertyChangeAndEndOfPropertyChange.pl: Removed.
3434
3435 2010-04-11  Adam Barth  <abarth@webkit.org>
3436
3437         Reviewed by Eric Seidel.
3438
3439         Fix typo in log path for AbstractQueue
3440         https://bugs.webkit.org/show_bug.cgi?id=37414
3441
3442         * Scripts/webkitpy/tool/commands/queues.py:
3443         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3444
3445 2010-04-11  Adam Barth  <abarth@webkit.org>
3446
3447         Unreviewed.  Add missing import statement.
3448
3449         * Scripts/webkitpy/common/system/executive.py:
3450
3451 2010-04-11  Robert Hogan  <robert@webkit.org>
3452
3453         Reviewed by Simon Hausmann.
3454
3455         [Qt] Add setWillSendRequestReturnsNull and setWillSendRequestClearHeader
3456
3457         https://bugs.webkit.org/show_bug.cgi?id=37410
3458
3459         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3460         (LayoutTestController::reset):
3461         (LayoutTestController::setWillSendRequestReturnsNull):
3462         (LayoutTestController::setWillSendRequestClearHeader):
3463         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3464
3465 2010-04-11  Csaba Osztrogonác  <ossy@webkit.org>
3466
3467         [Qt] Unreviewed buildfix for --debug build after r57433.
3468
3469         Refactor Qt DRT support in QtWebKit
3470         https://bugs.webkit.org/show_bug.cgi?id=35844
3471
3472         * QtLauncher/main.cpp: qt_drt_garbageCollector_collect(); renamed to DumpRenderTreeSupportQt::garbageCollectorCollect();
3473         (launcherMain):
3474
3475 2010-04-11  Joseph Pecoraro  <joepeck@webkit.org>
3476
3477         Reviewed by Mark Rowe.
3478
3479         Make commit-log-editor Rubber-stamp aware. And other minor cleanups.
3480         https://bugs.webkit.org/show_bug.cgi?id=37407
3481
3482         * Scripts/commit-log-editor:
3483
3484 2010-04-11  Eric Seidel  <eric@webkit.org>
3485
3486         Reviewed by Adam Barth.
3487
3488         Add PrettyPatch links to new-run-webkit-tests output
3489         https://bugs.webkit.org/show_bug.cgi?id=37406
3490
3491         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3492          - We're leaking a file handle here, add a FIXME.
3493         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3494          - Add pretty diff links.
3495         * Scripts/webkitpy/layout_tests/port/base.py:
3496          - Add support for generating pretty diffs using PrettyPatch.
3497         * Scripts/webkitpy/layout_tests/port/webkit.py:
3498          - We're leaking another file handle here, another FIXME.
3499         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
3500          - Update write_output_files signature.
3501         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
3502          - Remove unused arguments from write_output_files.
3503          - Add support for dumping pretty diffs to write_output_files.
3504          - Fix a bunch of file descriptor leaks in this file.
3505         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3506          - Update write_output_files signature.
3507
3508 2010-04-10  Adam Barth  <abarth@webkit.org>
3509
3510         Reviewed by Eric Seidel.
3511
3512         kill_process is copy/pasted in five places
3513         https://bugs.webkit.org/show_bug.cgi?id=37405
3514
3515         We shouldn't replicate the kill_process logic in every port.  Instead,
3516         we should move the process interaction to Executive.
3517
3518         Dirk mentioned that he wanted this abstraction to make it easier to
3519         mock things out for testing.  It turns out this function is only used
3520         in one place where it can't be used as a mock point for testing because
3521         the corresponding create process actually creates a real process.  In
3522         the long term, we should indirect both these calls through a non-static
3523         Executive as a mock point.  However, we should wait on that until we
3524         actually want to write the test.
3525
3526         * Scripts/webkitpy/layout_tests/port/base.py:
3527         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3528         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3529         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3530         * Scripts/webkitpy/layout_tests/port/mac.py:
3531         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
3532         * Scripts/webkitpy/layout_tests/port/win.py:
3533
3534 2010-04-10  Adam Barth  <abarth@webkit.org>
3535
3536         Reviewed by Eric Seidel.
3537
3538         new-run-webkit-tests shouldn't alter its path to import packages
3539         https://bugs.webkit.org/show_bug.cgi?id=37404
3540