WebKitTools/ChangeLog

   1 2010-01-28  Andras Becsi  <abecsi@webkit.org>
   2
   3         Adding myself to the committer list. No review needed.
   4
   5         * Scripts/webkitpy/committers.py:
   6
   7 2010-01-28  Hayato Ito  <hayato@chromium.org>
   8
   9         Reviewed by David Levin.
  10
  11         Remove NULL char from input JS file because 'grep' fails if the file contains NULL char.
  12
  13         https://bugs.webkit.org/show_bug.cgi?id=34252
  14
  15         * Scripts/make-script-test-wrappers:
  16
  17 2010-01-28  Kevin Ollivier  <kevino@theolliviers.com>
  18
  19         [wx] Build fix after removal of the zlib image decoder.
  20
  21         * wx/build/settings.py:
  22
  23 2010-01-28  Csaba Osztrogonác  <ossy@webkit.org>
  24
  25         [Qt] Unreviewed, roll out r54000.
  26
  27         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  28         (WebCore::DumpRenderTree::DumpRenderTree):
  29         * DumpRenderTree/qt/DumpRenderTreeQt.h:
  30         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  31         (LayoutTestController::reset):
  32         * DumpRenderTree/qt/LayoutTestControllerQt.h:
  33         (LayoutTestController::display):
  34
  35 2010-01-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
  36
  37         Reviewed by Kenneth Rohde Christiansen.
  38
  39         [Qt] Implement the display() method of the layout test controller
  40         https://bugs.webkit.org/show_bug.cgi?id=34258
  41
  42         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  43         (WebCore::DumpRenderTree::DumpRenderTree):
  44         (WebCore::DumpRenderTree::showPage):
  45         (WebCore::DumpRenderTree::hidePage):
  46         * DumpRenderTree/qt/DumpRenderTreeQt.h:
  47         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  48         (LayoutTestController::reset):
  49         (LayoutTestController::display):
  50         * DumpRenderTree/qt/LayoutTestControllerQt.h:
  51
  52 2010-01-28  Chris Jerdonek  <cjerdonek@webkit.org>
  53
  54         Reviewed by Shinichiro Hamaji.
  55
  56         Eliminated the filename parameter from functions in
  57         check-webkit-style's cpp.py where it is no longer used.
  58
  59         https://bugs.webkit.org/show_bug.cgi?id=34249
  60
  61         * Scripts/webkitpy/style/processors/cpp.py:
  62           - Reduced number of occurrences of "filename" variable from
  63             approximately 200 to 120.
  64
  65         * Scripts/webkitpy/style/processors/cpp_unittest.py:
  66           - Refactored unit tests as necessary to accommodate changes to cpp.py.
  67           - Fixed bug in CppStyleTestBase.perform_include_what_you_use()
  68             where the incorrect file extension was getting passed to
  69             cpp_style.check_language().
  70
  71 2010-01-28  Chris Jerdonek  <cjerdonek@webkit.org>
  72
  73         Reviewed by Shinichiro Hamaji.
  74
  75         In check-webkit-style, eliminated the dependency of
  76         processors/cpp_unittest.py on checker.py.
  77
  78         https://bugs.webkit.org/show_bug.cgi?id=34205
  79
  80         * Scripts/webkitpy/style/checker.py:
  81           - Addressed FIXME by removing STYLE_CATEGORIES data.
  82           - Added style_categories().
  83
  84         * Scripts/webkitpy/style/checker_unittest.py:
  85           - Minor changes.
  86
  87         * Scripts/webkitpy/style/processors/cpp.py:
  88           - Added categories attribute to CppProcessor class (data
  89             was originally checker.STYLE_CATEGORIES).
  90
  91         * Scripts/webkitpy/style/processors/cpp_unittest.py:
  92           - Addressed FIXME by eliminating "import" from checker.py.
  93
  94 2010-01-28  Anton Muhin  <antonm@chromium.org>
  95
  96         Reviewed by Shinichiro Hamaji.
  97
  98         Improve treatment of conditions and rest of the line for if, else, switch and alikes
  99         https://bugs.webkit.org/show_bug.cgi?id=34173
 100
 101         * Scripts/webkitpy/style/cpp_style.py:
 102         * Scripts/webkitpy/style/cpp_style_unittest.py:
 103
 104 2010-01-28  Joe Mason  <jmason@rim.com>
 105
 106         Reviewed by Adam Barth.
 107
 108         Limit login retries to 5
 109         https://bugs.webkit.org/show_bug.cgi?id=34193
 110
 111         * Scripts/webkitpy/bugzilla.py:
 112
 113 2010-01-27  Martin Robinson  <mrobinson@webkit.org>
 114
 115         Adding myself to the committer list. No review necessary.
 116
 117         * Scripts/webkitpy/committers.py:
 118
 119 2010-01-27  George Wright  <gwright@rim.com>
 120
 121         Reviewed by Adam Treat.
 122
 123         https://bugs.webkit.org/show_bug.cgi?id=34216
 124
 125         Add missing include for wtf/Platform.h
 126
 127         * DumpRenderTree/AccessibilityController.h:
 128
 129 2010-01-27  Diego Gonzalez  <diego.gonzalez@openbossa.org>
 130
 131         Reviewed by Kenneth Rohde Christiansen.
 132
 133         [Qt] DRT Provide worker thread ability to track counters
 134         https://bugs.webkit.org/show_bug.cgi?id=34221
 135
 136         Implement workerThreadCount() in LayoutTestController of Qt DRT
 137
 138         Tests:
 139         fast/workers/dedicated-worker-lifecycle.html
 140         fast/workers/shared-worker-frame-lifecycle.html
 141         fast/workers/shared-worker-lifecycle.html
 142         fast/workers/worker-lifecycle.html
 143
 144         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 145         (LayoutTestController::workerThreadCount):
 146         * DumpRenderTree/qt/LayoutTestControllerQt.h:
 147
 148 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 149
 150         Rubberstamped by Simon Hausmann.
 151
 152         [Qt] QtLauncher refactoring:
 153
 154         Make the LauncherWindow depend less on the view, so that more
 155         code can be shared in near future.
 156
 157         * QtLauncher/main.cpp:
 158         (LauncherWindow::sendTouchEvent):
 159         (LauncherWindow::loadFinished):
 160         (LauncherWindow::zoomIn):
 161         (LauncherWindow::zoomOut):
 162         (LauncherWindow::resetZoom):
 163         (LauncherWindow::toggleZoomTextOnly):
 164         (LauncherWindow::dumpHtml):
 165         (LauncherWindow::selectElements):
 166         (LauncherWindow::setupUI):
 167
 168 2010-01-27  Kinuko Yasuda  <kinuko@chromium.org>
 169
 170         Reviewed by Eric Seidel.
 171
 172         Correctly handle the KeyLocation argument that has been introduced
 173         recently to test location-dependent key events in EventSender.keyDown.
 174         http://bugs.webkit.org/show_bug.cgi?id=28247
 175
 176         Test: fast/events/keydown-numpad-keys.html
 177
 178         * DumpRenderTree/gtk/EventSender.cpp:
 179         (keyDownCallback):
 180
 181 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 182
 183         Rubberstamped by Simon Hausmann.
 184
 185         [Qt] QtLauncher refactoring:
 186
 187         Move out code from the MainWindow (renamed to LauncherWindow)
 188         that is not depending on the view, and add it to a new class
 189         called MainWindow.
 190
 191         * QtLauncher/QtLauncher.pro:
 192         * QtLauncher/main.cpp:
 193         (LauncherWindow::LauncherWindow):
 194         (LauncherWindow::eventFilter):
 195         (LauncherWindow::loadStarted):
 196         (LauncherWindow::loadFinished):
 197         (LauncherWindow::newWindow):
 198         (LauncherWindow::setupUI):
 199         (WebPage::createWindow):
 200         (main):
 201         * QtLauncher/mainwindow.cpp: Added.
 202         (MainWindow::MainWindow):
 203         (MainWindow::buildUI):
 204         (MainWindow::page):
 205         (MainWindow::setAddressUrl):
 206         (MainWindow::addCompleterEntry):
 207         (MainWindow::load):
 208         (MainWindow::changeLocation):
 209         (MainWindow::openFile):
 210         * QtLauncher/mainwindow.h: Added.
 211
 212 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 213
 214         Rubberstamped by Simon Hausmann.
 215
 216         [Qt] QtLauncher, coding style fixes.
 217
 218         * QtLauncher/main.cpp:
 219         (MainWindow::MainWindow):
 220         (MainWindow::sendTouchEvent):
 221         (MainWindow::eventFilter):
 222         (MainWindow::loadURL):
 223         (MainWindow::setupUI):
 224         (WebPage::createPlugin):
 225
 226 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 227
 228         Rubberstamped by Simon Hausmann.
 229
 230         [Qt] QtLauncher refactoring, separating the webview and
 231         adding a QGraphicsWebView based version.
 232
 233         * QtLauncher/QtLauncher.pro:
 234         * QtLauncher/main.cpp:
 235         (MainWindow::MainWindow):
 236         * QtLauncher/webpage.h:
 237         * QtLauncher/webview.cpp: Added.
 238         (createContextMenu):
 239         (WebViewGraphicsBased::mousePressEvent):
 240         (WebViewTraditional::mousePressEvent):
 241         (WebViewGraphicsBased::contextMenuEvent):
 242         (WebViewTraditional::contextMenuEvent):
 243         * QtLauncher/webview.h: Added.
 244         (WebViewGraphicsBased::WebViewGraphicsBased):
 245         (WebViewTraditional::WebViewTraditional):
 246
 247 2010-01-27  Alexander Pavlov  <apavlov@chromium.org>
 248
 249         Adding myself as committer. No review necessary.
 250
 251         * Scripts/webkitpy/committers.py:
 252
 253 2010-01-27  Eric Seidel  <eric@webkit.org>
 254
 255         Reviewed by Darin Adler.
 256
 257         webkit-patch needs an open-bugs command
 258         https://bugs.webkit.org/show_bug.cgi?id=30793
 259
 260         * Scripts/test-webkitpy: import OpenBugsTest
 261         * Scripts/webkit-patch: import OpenBugs
 262         * Scripts/webkitpy/commands/download_unittest.py: don't import unittest
 263         * Scripts/webkitpy/commands/early_warning_system_unittest.py: ditto
 264         * Scripts/webkitpy/commands/queries_unittest.py: ditto
 265         * Scripts/webkitpy/commands/queues_unittest.py: ditto
 266         * Scripts/webkitpy/commands/upload_unittest.py: ditto
 267         * Scripts/webkitpy/mock_bugzillatool.py: log when user.open_url is called.
 268
 269 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 270
 271         Rubberstamped by Simon Hausmann
 272
 273         [Qt] QtLauncher refactoring, separating utility methods.
 274
 275         * QtLauncher/QtLauncher.pro:
 276         * QtLauncher/main.cpp:
 277         * QtLauncher/utils.cpp: Added.
 278         (urlFromUserInput):
 279         * QtLauncher/utils.h: Added.
 280
 281 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 282
 283         Rubberstamped by Simon Hausmann
 284
 285         [Qt] Refactor the code in the QtLauncher dealing with HTTP proxy.
 286
 287         * QtLauncher/main.cpp:
 288         (MainWindow::MainWindow):
 289         * QtLauncher/webpage.cpp:
 290         (WebPage::WebPage):
 291         (WebPage::applyProxy):
 292         * QtLauncher/webpage.h:
 293
 294 2010-01-26  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
 295
 296         Reviewed by Tor Arne Vestbø.
 297
 298         [Qt] Corrects debug build of DumpRenderTree on Windows.
 299
 300         * DumpRenderTree/qt/DumpRenderTree.pro:
 301
 302 2010-01-26  Daniel Bates  <dbates@webkit.org>
 303
 304         Reviewed by Adam Barth.
 305
 306         https://bugs.webkit.org/show_bug.cgi?id=34070
 307
 308         Moves the try/catch for OSError exceptions in Executive.run_command
 309         to Credentials.read_credentials() so that the unit test
 310         webkitpy.scm_unittest.SCMClassTests.test_error_handlers can
 311         assert that Executive.run_command throws an OSError exception.
 312
 313         * Scripts/webkitpy/credentials.py:
 314         * Scripts/webkitpy/executive.py: Moved try/catch for OSError to
 315         method Credentials.read_credentials().
 316         * Scripts/webkitpy/executive_unittest.py: Removed tests that no longer
 317         apply: test_run_command_with_bad_command_check_return_code and
 318         test_run_command_with_bad_command_check_calls_error_handler. Added new
 319         test to assert that run_command throws OSError exceptions.
 320
 321 2010-01-26  Diego Gonzalez  <diego.gonzalez@openbossa.org>
 322
 323         Reviewed by Kenneth Rohde Christiansen.
 324
 325         [Qt] DRT WebHistory support
 326         https://bugs.webkit.org/show_bug.cgi?id=34167
 327
 328         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 329         (LayoutTestController::reset):
 330         (LayoutTestController::webHistoryItemCount):
 331         (LayoutTestController::keepWebHistory):
 332         * DumpRenderTree/qt/LayoutTestControllerQt.h:
 333
 334 2010-01-26  Kent Tamura  <tkent@chromium.org>
 335
 336         Reviewed by Eric Seidel.
 337
 338         [Win] Add modifiers parameter support to Windows DumpRenderTree
 339         https://bugs.webkit.org/show_bug.cgi?id=34068
 340
 341         Add support for functional name modifiers; "addSelectionKey" and
 342         "rangeSelectionKey", and modifiers parameter to eventSender.mouseDown()
 343         and eventSender.mouseUp().
 344         This change is similar to r53498 for Mac.
 345
 346         * DumpRenderTree/win/EventSender.cpp:
 347         (buildModifierFlags): New function to set MK_CONTROL or MK_SHIFT to WPARAM.
 348         (mouseDownCallback): Call buidlModifiersFlags().
 349         (mouseUpCallback): ditto.
 350         (keyDownCallback): Add support for "addSelectionkey" and "rangeSelectionKey".
 351
 352 2010-01-26  Chris Jerdonek  <cjerdonek@webkit.org>
 353
 354         Reviewed by Eric Seidel.
 355
 356         The Python autoinstall cache directory now only gets created
 357         in the directory containing autoinstall.py.
 358
 359         https://bugs.webkit.org/show_bug.cgi?id=33365
 360
 361         * Scripts/webkitpy/autoinstall.py:
 362           - Also added a README file to the cache directory saying
 363             where it came from.
 364
 365 2010-01-26  Chris Jerdonek  <cjerdonek@webkit.org>
 366
 367         Reviewed by Eric Seidel.
 368
 369         Moved the check-webkit-style processors into a new
 370         webkitpy/style/processors directory.
 371
 372         https://bugs.webkit.org/show_bug.cgi?id=34060
 373
 374         * Scripts/webkitpy/style/checker.py:
 375         * Scripts/webkitpy/style/checker_unittest.py:
 376         * Scripts/webkitpy/style/cpp_style.py: Removed.
 377         * Scripts/webkitpy/style/cpp_style_unittest.py: Removed.
 378         * Scripts/webkitpy/style/processors: Added.
 379         * Scripts/webkitpy/style/processors/__init__.py: Added.
 380         * Scripts/webkitpy/style/processors/cpp.py: Copied from WebKitTools/Scripts/webkitpy/style/cpp_style.py.
 381         * Scripts/webkitpy/style/processors/cpp_unittest.py: Copied from WebKitTools/Scripts/webkitpy/style/cpp_style_unittest.py.
 382         * Scripts/webkitpy/style/processors/text.py: Copied from WebKitTools/Scripts/webkitpy/style/text_style.py.
 383         * Scripts/webkitpy/style/processors/text_unittest.py: Copied from WebKitTools/Scripts/webkitpy/style/text_style_unittest.py.
 384         * Scripts/webkitpy/style/text_style.py: Removed.
 385         * Scripts/webkitpy/style/text_style_unittest.py: Removed.
 386         * Scripts/webkitpy/style/unittests.py:
 387
 388 2010-01-26  Kevin Ollivier  <kevino@theolliviers.com>
 389
 390         [wx] Build fix, make sure stub function returns a value.
 391
 392         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
 393         (LayoutTestController::counterValueForElementById):
 394
 395 2010-01-26  Steve Falkenburg  <sfalken@apple.com>
 396
 397         Reviewed by Oliver Hunt.
 398
 399         Windows build references non-existent include paths
 400         https://bugs.webkit.org/show_bug.cgi?id=34175
 401
 402         * DumpRenderTree/win/DumpRenderTree.vcproj:
 403         * DumpRenderTree/win/ImageDiff.vcproj:
 404         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
 405
 406 2010-01-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 407
 408         Reviewed by Ariya Hidayat.
 409
 410         [Qt] Separating out the UrlLoader from the QtLauncher in it's
 411         own implementation and header file.
 412
 413         * QtLauncher/main.cpp:
 414         (main):
 415         * QtLauncher/urlloader.cpp: Added.
 416         (UrlLoader::UrlLoader):
 417         (UrlLoader::loadNext):
 418         (UrlLoader::init):
 419         (UrlLoader::getUrl):
 420         * QtLauncher/urlloader.h: Added.
 421
 422 2010-01-25  Chris Jerdonek  <cjerdonek@webkit.org>
 423
 424         Reviewed by Shinichiro Hamaji.
 425
 426         Refactored check-webkit-style by removing the file path
 427         parameter from the style error handler functions.
 428
 429         https://bugs.webkit.org/show_bug.cgi?id=34031
 430
 431         * Scripts/webkitpy/style/checker.py:
 432           - Added _default_style_error_handler() to StyleChecker class.
 433           - Moved handle_style_error() to inside _default_style_error_handler().
 434
 435         * Scripts/webkitpy/style/checker_unittest.py:
 436           - Removed file path from calls to error handler.
 437
 438         * Scripts/webkitpy/style/cpp_style.py:
 439           - Removed file path from calls to error handler.
 440
 441         * Scripts/webkitpy/style/cpp_style_unittest.py:
 442           - Removed file path from calls to error handler.
 443
 444         * Scripts/webkitpy/style/text_style.py:
 445           - Removed file path from calls to error handler.
 446
 447         * Scripts/webkitpy/style/text_style_unittest.py:
 448           - Removed file path from calls to error handler.
 449
 450 2010-01-25  Jeremy Orlow  <jorlow@chromium.org>
 451
 452         Adding myself as reviewer.  No review necessary.
 453
 454         * Scripts/webkitpy/committers.py:
 455
 456 2010-01-25  Chris Jerdonek  <cjerdonek@webkit.org>
 457
 458         Reviewed by Adam Barth.
 459
 460         Improved prepare-ChangeLog so that it preserves the relative
 461         indentation of a git commit message.
 462
 463         https://bugs.webkit.org/show_bug.cgi?id=34058
 464
 465         * Scripts/prepare-ChangeLog:
 466           - Also adjusted the script so that it does not add white
 467             space characters to empty lines.
 468
 469 2010-01-24  Eric Seidel  <eric@webkit.org>
 470
 471         No review, rolling out r53763.
 472         http://trac.webkit.org/changeset/53763
 473         https://bugs.webkit.org/show_bug.cgi?id=33895
 474
 475         Broke 20+ tests on Windows.
 476
 477         * Scripts/run-webkit-tests:
 478         * Scripts/webkitdirs.pm:
 479
 480 2010-01-24  Adam Barth  <abarth@webkit.org>
 481
 482         Rubber stamped by Eric Seidel.
 483
 484         More pep8 compliance.
 485
 486         * Scripts/webkitpy/mock_bugzillatool.py:
 487
 488 2010-01-24  Adam Barth  <abarth@webkit.org>
 489
 490         Rubber stamped by Eric Seidel.
 491
 492         More pep8 compliance.
 493
 494         * Scripts/webkitpy/executive.py:
 495         * Scripts/webkitpy/grammar.py:
 496
 497 2010-01-24  Adam Barth  <abarth@webkit.org>
 498
 499         Rubber stamped by Eric Seidel.
 500
 501         More pep8 compliance.
 502
 503         * Scripts/webkitpy/comments.py:
 504         * Scripts/webkitpy/committers.py:
 505         * Scripts/webkitpy/credentials.py:
 506
 507 2010-01-24  Adam Barth  <abarth@webkit.org>
 508
 509         Rubber stamped by Eric Seidel.
 510
 511         Make changelogs.py pass pep8.
 512
 513         * Scripts/webkitpy/changelogs.py:
 514
 515 2010-01-23  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 516
 517         [Qt] Unreviewed build fix
 518
 519         * QtLauncher/QtLauncher.pro:
 520         * QtLauncher/webinspector.h:
 521
 522 2010-01-23  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 523
 524         Rubberstamped by Simon Hausmann.
 525
 526         [Qt] Move the WebInspector class to it's own header file.
 527
 528         * QtLauncher/main.cpp:
 529         * QtLauncher/webinspector.h: Added.
 530         (WebInspector::WebInspector):
 531         (WebInspector::showEvent):
 532         (WebInspector::hideEvent):
 533
 534 2010-01-23  Robert Hogan  <robert@roberthogan.net>
 535
 536         Reviewed by Kenneth Rohde Christiansen.
 537
 538         Qt DRT: respect window.close() and window.closed()
 539
 540         Qt DRT needs to maintain a correct count of open windows
 541         for windowCount(). It also needs to delete windows that
 542         have been closed by window.close().
 543
 544         This fixes the following tests:
 545
 546         plugins/destroy-during-npp-new.html
 547         fast/dom/Document/early-document-access.html
 548         fast/dom/Window/window-early-properties.html
 549         fast/events/open-window-from-another-frame.html
 550         fast/events/popup-blocking-click-in-iframe.html
 551
 552         https://bugs.webkit.org/show_bug.cgi?id=32953
 553
 554         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
 555         (WebCore::DumpRenderTree::DumpRenderTree):
 556         (WebCore::DumpRenderTree::createWindow):
 557         (WebCore::DumpRenderTree::windowCloseRequested):
 558         * DumpRenderTree/qt/DumpRenderTreeQt.h:
 559         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 560         (LayoutTestController::maybeDump):
 561
 562 2010-01-23  Dan Bernstein  <mitz@apple.com>
 563
 564         Reviewed by Mark Rowe.
 565
 566         Added a user default for specifying a fallback frameworks path in case
 567         the bundle does not contain frameworks for the current Mac OS X version.
 568
 569         * WebKitLauncher/main.m:
 570         (fallbackMacOSXVersion): Added. Looks up the fallback version in a dictionary
 571         keyed by the FallbackSystemVersions user default and returns it.
 572         (main): If a frameworks directory for the current system version is not found,
 573         try the fallback.
 574
 575 2010-01-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
 576
 577         Reviewed by Simon Hausmann.
 578
 579         Make run-webkit-tests work under Cygwin for the Qt port
 580
 581         setPathForRunningWebKitApp() is implemented for the Qt port
 582         by using qmake to query for the location of the Qt libraries.
 583
 584         This requires the original environment (%ENV) to be untouched,
 585         so launchWithCurrentEnv() was refactored to launchWithEnv(),
 586         and the code in openDumpTool() to not use %ENV but a %CLEAN_ENV
 587         instead. This has the added benefit of getting rid of the temp
 588         variables used for storing the current env.
 589
 590         openDumpTool() is also refactored a bit into platform-spesific,
 591         port-spesific, and generic environment variables.
 592
 593         Checks for undef was added a few places to fix Perl concat
 594         warnings when run-webkit-tests is aborted.
 595
 596         https://bugs.webkit.org/show_bug.cgi?id=33895
 597
 598         * Scripts/run-webkit-tests:
 599         * Scripts/webkitdirs.pm:
 600
 601 2010-01-22  Kevin Watters  <kevinwatters@gmail.com>
 602
 603         Reviewed by Kevin Ollivier.
 604
 605         [wx] Remove the Bakefile build system, which is no longer being used.
 606
 607         https://bugs.webkit.org/show_bug.cgi?id=34022
 608
 609         * DumpRenderTree/wx/DumpRenderTree.bkl: Removed.
 610         * wx/browser/browser.bkl: Removed.
 611         * wx/build-wxwebkit: Removed.
 612
 613 2010-01-22  Gustavo Noronha Silva  <gns@gnome.org>
 614
 615         Reviewed by Simon Fraser.
 616
 617         Reset zoom level to 1.0 when resetting view state. This is causing
 618         many tests to fail after svg/custom/text-zoom.xhtml changes the
 619         zoom level.
 620
 621         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 622         (resetDefaultsToConsistentValues):
 623
 624 2010-01-22  Steve Falkenburg  <sfalken@apple.com>
 625
 626         Reviewed by Darin Adler.
 627
 628         https://bugs.webkit.org/show_bug.cgi?id=34025
 629         Enable client-based Geolocation abstraction for Mac, Windows AppleWebKit targets.
 630
 631         * Scripts/build-webkit:
 632
 633 2010-01-22  Adam Barth  <abarth@webkit.org>
 634
 635         Unreviewed.  Arg.  Someone renamed limit to output_limit on me.
 636
 637         * Scripts/webkitpy/commands/queues.py:
 638
 639 2010-01-22  Adam Barth  <abarth@webkit.org>
 640
 641         Rubber stamped by Eric Seidel.
 642
 643         Make __init__.py and buildbot.py pass pep8 style checker.
 644
 645         * Scripts/webkitpy/__init__.py:
 646         * Scripts/webkitpy/buildbot.py:
 647
 648 2010-01-21  Joe Mason  <jmason@rim.com>
 649
 650         Reviewed by Adam Barth.
 651
 652         webkit-patch should retry on invalid password
 653         https://bugs.webkit.org/show_bug.cgi?id=33955
 654
 655         Ask for bugs.webkit.org authentication in a loop.
 656
 657         * Scripts/webkitpy/bugzilla.py:
 658
 659 2010-01-22  Adam Barth  <abarth@webkit.org>
 660
 661         Unreviewed.  Don't call seek on a NoneType.
 662
 663         * Scripts/webkitpy/statusserver.py:
 664
 665 2010-01-22  Petri Latvala  <petri.latvala@nomovok.com>
 666
 667         Reviewed by David Levin.
 668
 669         check-webkit-style breaks on files with unknown types
 670         https://bugs.webkit.org/show_bug.cgi?id=34001
 671
 672         For files with type FileType.NONE, dispatch_processor returns None.
 673
 674         * Scripts/webkitpy/style/checker.py: Don't call process_file with a processor of value None.
 675
 676 2010-01-22  Adam Barth  <abarth@webkit.org>
 677
 678         Reviewed by Eric Seidel.
 679
 680         Make bugzilla.py and webkitport.py conform to pep8
 681         https://bugs.webkit.org/show_bug.cgi?id=34015
 682
 683         This patch makes webkitport.py and bugzilla.py mostly conform to PEP8
 684         style as enforced by pep8.py.  I wasn't able to get rid of all the
 685         errors because I'm not sure how to wrap some lines properly.  Also,
 686         there are a few deprication errors that I couldn't resolve easily.
 687         However, this is a massive improvement in compliance.
 688
 689         * Scripts/webkitpy/bugzilla.py:
 690         * Scripts/webkitpy/webkitport.py:
 691
 692 2010-01-22  Adam Barth  <abarth@webkit.org>
 693
 694         Reviewed by Darin Adler.
 695
 696         Limit length of EWS results to 5MB
 697         https://bugs.webkit.org/show_bug.cgi?id=34016
 698
 699         Hopefully this will fix the bug where the results link doesn't appear.
 700         Our current theory is that the results blob is too big and the server
 701         is rejecting the request with a 500 error.  That causes us to re-try
 702         the post, but when we re-try the StringIO buffer has its seek pointer
 703         at the end.
 704
 705         * Scripts/webkitpy/commands/queues.py:
 706         * Scripts/webkitpy/statusserver.py:
 707
 708 2010-01-22  Chris Jerdonek  <cjerdonek@webkit.org>
 709
 710         Reviewed by Adam Barth.
 711
 712         Made check-webkit-style able to check patches when script not
 713         run from source root. Also consolidated external references
 714         to a single file.
 715
 716         https://bugs.webkit.org/show_bug.cgi?id=33791
 717
 718         * Scripts/check-webkit-style:
 719           - Changed to import style_references.py.
 720
 721         * Scripts/webkitpy/style/__init__.py:
 722           - Removed __path__ hack that allowed searching Scripts/ directory.
 723
 724         * Scripts/webkitpy/style/checker.py:
 725           - Changed to import style_references.py.
 726
 727         * Scripts/webkitpy/style_references.py: Added.
 728
 729 2010-01-22  Dmitry Titov  <dimich@chromium.org>
 730
 731         Reviewed by Maciej Stachowiak.
 732
 733         Fix the leak of ThreadIdentifiers in threadMap across threads.
 734         https://bugs.webkit.org/show_bug.cgi?id=32689
 735
 736         Add a new test to verify the ThreadIdentifiers are not reused across threads.
 737         The test runs in the beginning of DumpRenderTree and spawns 2 non-WTF treads sequentially,
 738         waiting for the previous thread to terminate before starting the next.
 739         The treads use WTF::currentThread() in their thread function. Without a fix, this
 740         causes both threads to have the same ThreadIdentifier which triggers ASSERT in thread function.
 741         It also starts another thread using WTF. Without the fix, this finds pthread handle from previous
 742         threads in the WTF threadMap and asserts in WTF::establishIdentifierForPthreadHandle().
 743         The test practically does not affect the DRT run time because the threads end immediately.
 744
 745         * DumpRenderTree/mac/DumpRenderTree.mm:
 746         (runThread): Test thread function.
 747         (testThreadIdentifierMap):
 748         (dumpRenderTree):
 749
 750 2010-01-22  Kent Tamura  <tkent@chromium.org>
 751
 752         Reviewed by Maciej Stachowiak.
 753
 754         Fix a bug that mouseDown:withModifiers: is never called.
 755         https://bugs.webkit.org/show_bug.cgi?id=33989
 756
 757         * DumpRenderTree/mac/EventSendingController.mm:
 758         (+[EventSendingController isSelectorExcludedFromWebScript:]):
 759         (+[EventSendingController webScriptNameForSelector:]):
 760
 761 2010-01-22  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 762
 763         Rubberstamped by Antti Koivisto.
 764
 765         [Qt] Separate out the WebPage class into it's own
 766         cpp/header files. Also, removed the assumption that
 767         the view is a QWebView, in preparation of a merger
 768         of the two Qt WebKit launchers.
 769
 770         * QtLauncher/QtLauncher.pro:
 771         * QtLauncher/main.cpp:
 772         (WebView::mousePressEvent):
 773         * QtLauncher/webpage.cpp: Added.
 774         (WebPage::supportsExtension):
 775         (WebPage::extension):
 776         (WebPage::acceptNavigationRequest):
 777         (WebPage::openUrlInDefaultBrowser):
 778         * QtLauncher/webpage.h: Added.
 779         (WebPage::WebPage):
 780
 781 2010-01-21  Chris Jerdonek  <cjerdonek@webkit.org>
 782
 783         Reviewed by Shinichiro Hamaji.
 784
 785         Refactored to move file name and file-reading related code
 786         from cpp_style.py and text_style.py to checker.py.
 787
 788         https://bugs.webkit.org/show_bug.cgi?id=33775
 789
 790         * Scripts/check-webkit-style:
 791           - Updates caused by changes to checker.py.
 792
 793         * Scripts/webkitpy/style/checker.py:
 794           - Added SKIPPED_FILES_WITH_WARNING list.
 795           - Added SKIPPED_FILES_WITHOUT_WARNING list.
 796           - Added FileType class.
 797           - Added ProcessorDispatcher class.
 798           - In StyleChecker class:
 799             - Renamed process_patch() to check_patch().
 800             - Renamed process_file() to check_file().
 801             - Added _process_file().
 802             - Related refactoring.
 803             - Addressed check_patch() FIXME to share code with process_file().
 804
 805         * Scripts/webkitpy/style/checker_unittest.py:
 806           - Added ProcessorDispatcherSkipTest class.
 807           - Added ProcessorDispatcherDispatchTest class.
 808           - Added StyleCheckerCheckFileTest class.
 809
 810         * Scripts/webkitpy/style/cpp_style.py:
 811           - Renamed process_file_data() to _process_lines.
 812           - Removed process_file() (moved logic to checker.py).
 813           - Removed can_handle() (moved logic to checker.py).
 814           - Added CppProcessor class.
 815           - Removed is_exempt() (moved logic to checker.py).
 816           - Added process_file_data() back as a wrapper function.
 817
 818         * Scripts/webkitpy/style/cpp_style_unittest.py:
 819           - Removed test_can_handle().
 820           - Removed test_is_exempt().
 821           - Added CppProcessorTest class.
 822
 823         * Scripts/webkitpy/style/text_style.py:
 824           - Added TextProcessor class.
 825           - Removed process_file().
 826           - Removed can_handle().
 827
 828         * Scripts/webkitpy/style/text_style_unittest.py:
 829           - Removed test_can_handle().
 830           - Added TextProcessorTest class.
 831
 832 2010-01-21  Chris Jerdonek  <cjerdonek@webkit.org>
 833
 834         Reviewed by David Kilzer.
 835
 836         Create a unit-tested subroutine to parse patch files created
 837         by svn-create-patch.
 838
 839         https://bugs.webkit.org/show_bug.cgi?id=33475
 840
 841         * Scripts/VCSUtils.pm:
 842           - Added parseDiff().
 843           - Added parsePatch().
 844
 845         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Added.
 846           - Added unit tests for parseDiff().
 847
 848         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
 849           - Total number of tests now computed dynamically.
 850
 851         * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl: Added.
 852           - Added unit tests for parsePatch().
 853
 854 2010-01-21  Kevin Ollivier  <kevino@theolliviers.com>
 855
 856         [wx] Build fix, add new directory to dir list.
 857
 858         * wx/build/settings.py:
 859
 860 2010-01-21  Adam Barth  <abarth@webkit.org>
 861
 862         Reviewed by Eric Seidel.
 863
 864         Make the EWS transactional
 865         https://bugs.webkit.org/show_bug.cgi?id=33978
 866
 867         Now if the EWS gets interrupted in the middle of processing a patch,
 868         the bots will re-process the patch.
 869
 870         * Scripts/test-webkitpy:
 871         * Scripts/webkitpy/commands/queues.py:
 872         * Scripts/webkitpy/commands/queues_unittest.py:
 873         * Scripts/webkitpy/patchcollection.py:
 874         * Scripts/webkitpy/patchcollection_unittest.py: Added.
 875
 876 2010-01-21  Adam Barth  <abarth@webkit.org>
 877
 878         Unreviewed.  Add missing "ago" for style in the status bubble.
 879
 880         * QueueStatusServer/templates/statusbubble.html:
 881
 882 2010-01-21  Adam Barth  <abarth@webkit.org>
 883
 884         Reviewed by David Levin.
 885
 886         [style-queue] should not complain about identifier names with underscores under WebKit/gtk/webkit/
 887         https://bugs.webkit.org/show_bug.cgi?id=33356
 888
 889         White list unix_hacker_style names in WebKit/gtk/webkit because these
 890         are used in the GTK+ API.
 891
 892         * Scripts/webkitpy/style/cpp_style.py:
 893         * Scripts/webkitpy/style/cpp_style_unittest.py:
 894
 895 2010-01-21  Diego Gonzalez  <diego.gonzalez@openbossa.org>
 896
 897         Reviewed by Kenneth Rohde Christiansen.
 898
 899         [Qt] add setDomainRelaxationForbiddenForURLScheme in Qt DRT
 900         https://bugs.webkit.org/show_bug.cgi?id=33945
 901
 902         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 903         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
 904         * DumpRenderTree/qt/LayoutTestControllerQt.h:
 905
 906 2010-01-21  Simon Hausmann  <simon.hausmann@nokia.com>
 907
 908         No review, rolling out 53615 as it causes two
 909         crashes on the bot.
 910
 911         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
 912         (WebCore::DumpRenderTree::DumpRenderTree):
 913         (WebCore::DumpRenderTree::createWindow):
 914         * DumpRenderTree/qt/DumpRenderTreeQt.h:
 915         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 916         (LayoutTestController::maybeDump):
 917
 918 2010-01-21  Robert Hogan  <robert@roberthogan.net>
 919
 920         Reviewed by Simon Hausmann.
 921
 922         Qt DRT: respect window.close() and window.closed()
 923
 924         Qt DRT needs to maintain a correct count of open windows
 925         for windowCount(). It also needs to delete windows that
 926         have been closed by window.close().
 927
 928         This fixes the following tests:
 929
 930         plugins/destroy-during-npp-new.html
 931         fast/dom/Document/early-document-access.html
 932         fast/dom/Window/window-early-properties.html
 933         fast/events/open-window-from-another-frame.html
 934         fast/events/popup-blocking-click-in-iframe.html
 935
 936         https://bugs.webkit.org/show_bug.cgi?id=32953
 937
 938         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
 939         (WebCore::DumpRenderTree::DumpRenderTree):
 940         (WebCore::DumpRenderTree::createWindow):
 941         (WebCore::DumpRenderTree::windowCloseRequested):
 942         * DumpRenderTree/qt/DumpRenderTreeQt.h:
 943         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 944         (LayoutTestController::maybeDump):
 945
 946 2010-01-20  Eric Seidel  <eric@webkit.org>
 947
 948         No review, rolling out r53593.
 949         http://trac.webkit.org/changeset/53593
 950         https://bugs.webkit.org/show_bug.cgi?id=33496
 951
 952         Re-rollout this patch, the commit-queue should not have landed
 953         it again, but it did due to land-diff and rollout both not
 954         clearing flags.
 955
 956         * Scripts/webkitpy/commands/early_warning_system.py:
 957         * Scripts/webkitpy/commands/queues.py:
 958         * Scripts/webkitpy/queueengine.py:
 959         * Scripts/webkitpy/scm.py:
 960         * Scripts/webkitpy/scm_unittest.py:
 961
 962 2010-01-20  Eric Seidel  <eric@webkit.org>
 963
 964         Reviewed by Adam Barth.
 965
 966         webkit-commit-queue status page is confusing
 967         https://bugs.webkit.org/show_bug.cgi?id=33496
 968
 969         This should improve the status page by removing more Fail messages.
 970         To do this, I re-factored the CommitQueue and the AbstractReviewQueues
 971         to behave more like one another.  This meant moving where the failure reporting was done.
 972         Previously the AbstractReviewQueue always used the parent process to report the error,
 973         while CommitQueue used the subprocess when possible, and the parent only reported errors
 974         that we didn't know how to handle (bugs in the commit-queue itself).
 975         Now the AbstractReviewQueue follow's the commit-queue's model.  This got rid of a try-block
 976         in both implementations and required teaching handle_script_error in each to post Fail messages
 977         to the status server instead of calling exit(1).
 978
 979         This will also make the style-queue share more bug posting logic with other queues:
 980         https://bugs.webkit.org/show_bug.cgi?id=33871
 981
 982         * Scripts/webkitpy/commands/early_warning_system.py:
 983          - Don't exit(1) as that will cause the calling queue to also report Fail to the status server.
 984            Implementors of handle_script_error are expected to update the status server if needed, but only exit if the error could not be handled.
 985            So we instead pass patch_has_failed_this_queue=True to _update_status_for_script_error in the case that this was a real failure.
 986            _update_status_for_script_error knows how to post the Fail message to the status server.
 987          - Teach _update_status_for_script_error how to post Fail messages to the status server.
 988         * Scripts/webkitpy/commands/queues.py:
 989          - Remove the try block from process_work_item since the caller already has one.
 990          - Only CC watchers on failure to cut down on commit-queue generated mail.
 991          - handle_unexpected_error needs to mark _did_fail now that the try block is gone from process_work_item.
 992          - Abstract _format_script_error_output_for_bug to share code between all queues.
 993          - The new _format_script_error_output_for_bug allows the style-queue to share the posting limit with other queues, as well as support linking to the full output.
 994          - Rename _can_build_and_test to _current_checkout_builds_and_passes_tests to better explain what revision it's testing.
 995          - Move logging out of _can_build_and_test and make the logs explain what revision we're testing.
 996          - handle_script_error now posts Fail instead of the try block in process_work_item handling it.
 997         * Scripts/webkitpy/queueengine.py:
 998          - QueueEngine is no longer used just by the commit-queue, update the logging to say "processing" instead of landing.
 999         * Scripts/webkitpy/scm.py:
1000          - Add new checkout_revision function.
1001         * Scripts/webkitpy/scm_unittest.py:
1002          - Test our new checkout_revision function.
1003
1004 2010-01-20  Fumitoshi Ukai  <ukai@chromium.org>
1005
1006         Reviewed by Alexey Proskuryakov.
1007
1008         WebSocket: Missing Request-URI, when no tralling slash in host
1009         https://bugs.webkit.org/show_bug.cgi?id=33689
1010
1011         Update pywebsocket to 0.4.7.1, which supports alias for resource
1012         name, so that we could test for ws://127.0.0.1:8880
1013
1014         * Scripts/run-webkit-tests:
1015         * Scripts/run-webkit-websocketserver:
1016         * pywebsocket/mod_pywebsocket/dispatch.py:
1017         * pywebsocket/mod_pywebsocket/handshake.py:
1018         * pywebsocket/mod_pywebsocket/standalone.py:
1019         * pywebsocket/setup.py:
1020         * pywebsocket/test/test_dispatch.py:
1021         * pywebsocket/test/test_handshake.py:
1022
1023 2010-01-20  Eric Seidel  <eric@webkit.org>
1024
1025         No review, rolling out r53537.
1026         http://trac.webkit.org/changeset/53537
1027         https://bugs.webkit.org/show_bug.cgi?id=33496
1028
1029         Added a failure condition to the commit-queue and looks to
1030         have broken the EWS bots
1031
1032         * Scripts/webkitpy/commands/early_warning_system.py:
1033         * Scripts/webkitpy/commands/queues.py:
1034         * Scripts/webkitpy/queueengine.py:
1035         * Scripts/webkitpy/scm.py:
1036         * Scripts/webkitpy/scm_unittest.py:
1037
1038 2010-01-20  Jon Honeycutt  <jhoneycutt@apple.com>
1039
1040         MSAA: accSelect() is not implemented
1041
1042         https://bugs.webkit.org/show_bug.cgi?id=33918
1043         <rdar://problem/7436861>
1044
1045         Reviewed by Darin Adler.
1046
1047         * DumpRenderTree/AccessibilityUIElement.cpp:
1048         (takeFocusCallback):
1049         Call the object's takeFocus() function.
1050         (takeSelectionCallback):
1051         Call its takeSelection() function.
1052         (addSelectionCallback):
1053         Call its addSelection() function.
1054         (removeSelectionCallback):
1055         Call its removeSelection() function.
1056         (AccessibilityUIElement::getJSClass):
1057         Add new functions to the JS class definition.
1058
1059         * DumpRenderTree/AccessibilityUIElement.h:
1060         Declare new functions.
1061
1062         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1063         (AccessibilityUIElement::takeFocus):
1064         Stubbed.
1065         (AccessibilityUIElement::takeSelection):
1066         Stubbed.
1067         (AccessibilityUIElement::addSelection):
1068         Stubbed.
1069         (AccessibilityUIElement::removeSelection):
1070         Stubbed.
1071
1072         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1073         (AccessibilityUIElement::takeFocus):
1074         Stubbed.
1075         (AccessibilityUIElement::takeSelection):
1076         Stubbed.
1077         (AccessibilityUIElement::addSelection):
1078         Stubbed.
1079         (AccessibilityUIElement::removeSelection):
1080         Stubbed.
1081
1082         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1083         (AccessibilityUIElement::takeFocus):
1084         Call the object's accSelect() function, passing the appropriate flag.
1085         (AccessibilityUIElement::takeSelection):
1086         Ditto.
1087         (AccessibilityUIElement::addSelection):
1088         Ditto.
1089         (AccessibilityUIElement::removeSelection):
1090         Ditto.
1091
1092 2010-01-20  Andras Becsi  <abecsi@inf.u-szeged.hu>
1093
1094         Reviewed by Alexey Proskuryakov.
1095
1096         Extract Apache handling to httpd.pm module and use the provided functionality
1097         in scripts where Apache is needed.
1098         The module httpd.pm stores the PID of Apache in a variable and cleans up
1099         the PID directory after Apache properly shut down. Catching INT and TERM
1100         signals allows the scripts to close Apache and clean up its PID directory
1101         even if the testing was interrupted.
1102
1103         https://bugs.webkit.org/show_bug.cgi?id=33153
1104
1105         * Scripts/webkitperl/httpd.pm: Added.
1106         * Scripts/run-iexploder-tests:
1107         * Scripts/run-webkit-httpd:
1108         * Scripts/run-webkit-tests:
1109
1110 2010-01-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1111
1112         Reviewed by Simon Hausmann.
1113
1114         [Qt] Make DumpRenderTree build on Windows
1115
1116         * DumpRenderTree/qt/DumpRenderTree.pro:
1117         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1118         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1119         * DumpRenderTree/qt/main.cpp:
1120
1121 2010-01-20  Steve Block  <steveblock@google.com>
1122
1123         Reviewed by Eric Seidel.
1124
1125         Fix commit bot to land patches in order of the bug last modification date.
1126         https://bugs.webkit.org/show_bug.cgi?id=33395
1127
1128         * Scripts/webkitpy/bugzilla.py: Modified. Added 'order=Last+Changed' to bugzilla commit queue URL.
1129
1130 2010-01-20  Adam Barth  <abarth@webkit.org>
1131
1132         Reviewed by Eric Seidel.
1133
1134         Teach check-webkit-style about WebKit/gtk/tests
1135         https://bugs.webkit.org/show_bug.cgi?id=33892
1136
1137         Removes false positives found in
1138         https://bugs.webkit.org/show_bug.cgi?id=30883
1139
1140         * Scripts/webkitpy/style/cpp_style.py:
1141         * Scripts/webkitpy/style/cpp_style_unittest.py:
1142
1143 2010-01-20  Adam Barth  <abarth@webkit.org>
1144
1145         Reviewed by Eric Seidel.
1146
1147         Teach check-webkit-style about QGVLauncher
1148         https://bugs.webkit.org/show_bug.cgi?id=33890
1149
1150         Remove false positives found in
1151         https://bugs.webkit.org/show_bug.cgi?id=33708
1152
1153         * Scripts/webkitpy/style/cpp_style.py:
1154         * Scripts/webkitpy/style/cpp_style_unittest.py:
1155
1156 2010-01-20  Eric Seidel  <eric@webkit.org>
1157
1158         Reviewed by Adam Barth.
1159
1160         webkit-commit-queue status page is confusing
1161         https://bugs.webkit.org/show_bug.cgi?id=33496
1162
1163         This should improve the status page by removing more Fail messages.
1164         To do this, I re-factored the CommitQueue and the AbstractReviewQueues
1165         to behave more like one another.  This meant moving where the failure reporting was done.
1166         Previously the AbstractReviewQueue always used the parent process to report the error,
1167         while CommitQueue used the subprocess when possible, and the parent only reported errors
1168         that we didn't know how to handle (bugs in the commit-queue itself).
1169         Now the AbstractReviewQueue follow's the commit-queue's model.  This got rid of a try-block
1170         in both implementations and required teaching handle_script_error in each to post Fail messages
1171         to the status server instead of calling exit(1).
1172
1173         This will also make the style-queue share more bug posting logic with other queues:
1174         https://bugs.webkit.org/show_bug.cgi?id=33871
1175
1176         * Scripts/webkitpy/commands/early_warning_system.py:
1177          - Don't exit(1) as that will cause the calling queue to also report Fail to the status server.
1178            Implementors of handle_script_error are expected to update the status server if needed, but only exit if the error could not be handled.
1179            So we instead pass patch_has_failed_this_queue=True to _update_status_for_script_error in the case that this was a real failure.
1180            _update_status_for_script_error knows how to post the Fail message to the status server.
1181          - Teach _update_status_for_script_error how to post Fail messages to the status server.
1182         * Scripts/webkitpy/commands/queues.py:
1183          - Remove the try block from process_work_item since the caller already has one.
1184          - Only CC watchers on failure to cut down on commit-queue generated mail.
1185          - handle_unexpected_error needs to mark _did_fail now that the try block is gone from process_work_item.
1186          - Abstract _format_script_error_output_for_bug to share code between all queues.
1187          - The new _format_script_error_output_for_bug allows the style-queue to share the posting limit with other queues, as well as support linking to the full output.
1188          - Rename _can_build_and_test to _current_checkout_builds_and_passes_tests to better explain what revision it's testing.
1189          - Move logging out of _can_build_and_test and make the logs explain what revision we're testing.
1190          - handle_script_error now posts Fail instead of the try block in process_work_item handling it.
1191         * Scripts/webkitpy/queueengine.py:
1192          - QueueEngine is no longer used just by the commit-queue, update the logging to say "processing" instead of landing.
1193         * Scripts/webkitpy/scm.py:
1194          - Add new checkout_revision function.
1195         * Scripts/webkitpy/scm_unittest.py:
1196          - Test our new checkout_revision function.
1197
1198 2010-01-20  Adam Barth  <abarth@webkit.org>
1199
1200         Reviewed by Darin Adler.
1201
1202         Exempt JavaScriptCore/qt/api from style checks
1203         https://bugs.webkit.org/show_bug.cgi?id=33879
1204
1205         Apparently there is a JavaScriptCore API for Qt as well as a WebKit
1206         API.
1207
1208         * Scripts/webkitpy/style/cpp_style.py:
1209         * Scripts/webkitpy/style/cpp_style_unittest.py:
1210
1211 2010-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1212
1213         Reviewed by Simon Hausmann.
1214
1215         [Qt] Don't use QSocketNotifier in the DRT for reading stdin
1216
1217         QSocketNotifier is not available on Windows. Instead we read
1218         stdin synchronously after each test using signals and slots.
1219
1220         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1221         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1222         * DumpRenderTree/qt/main.cpp:
1223
1224 2010-01-19  Adam Barth  <abarth@webkit.org>
1225
1226         Rubber stamped by Eric Seidel.
1227
1228         Move chromium-ews back to building release only to make the EWS faster.
1229
1230         * Scripts/webkitpy/commands/early_warning_system.py:
1231
1232 2010-01-17  Jon Honeycutt  <jhoneycutt@apple.com>
1233
1234         MSAA: The child <option> elements of a non-multiple <select> are not
1235         exposed
1236
1237         https://bugs.webkit.org/show_bug.cgi?id=33773
1238         <rdar://problem/7550556>
1239
1240         Reviewed by Alice Liu.
1241
1242         * DumpRenderTree/AccessibilityUIElement.cpp:
1243         (getIsVisibleCallback):
1244         Call the object's isVisible() function.
1245         (getIsOffScreenCallback):
1246         Ditto, for isOffScreen().
1247         (getIsCollapsedCallback):
1248         Ditto, for isCollapsed().
1249         (getHasPopupCallback):
1250         Ditto, for hasPopup().
1251         (AccessibilityUIElement::getJSClass):
1252         Add isVisible and isOffScreen attributes.
1253
1254         * DumpRenderTree/AccessibilityUIElement.h:
1255         Declare new functions.
1256
1257         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1258         (AccessibilityUIElement::isVisible):
1259         Stubbed.
1260         (AccessibilityUIElement::isOffScreen):
1261         Stubbed.
1262         (AccessibilityUIElement::isCollapsed):
1263         Stubbed.
1264         (AccessibilityUIElement::hasPopup):
1265         Stubbed.
1266
1267         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1268         (AccessibilityUIElement::isVisible):
1269         Stubbed.
1270         (AccessibilityUIElement::isOffScreen):
1271         Stubbed.
1272         (AccessibilityUIElement::isCollapsed):
1273         Stubbed.
1274         (AccessibilityUIElement::hasPopup):
1275         Stubbed.
1276
1277         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1278         (AccessibilityUIElement::showMenu):
1279         Call the object's accDoDefaultAction() to show its popup menu.
1280         (AccessibilityUIElement::isEnabled):
1281         Check that the object does not have the "unavailable" state.
1282         (AccessibilityUIElement::isVisible):
1283         Check that the object does not have the "invisible" state.
1284         (AccessibilityUIElement::isOffScreen):
1285         Check whether the object has the "offscreen" state.
1286         (AccessibilityUIElement::isCollapsed):
1287         Check whether the object has the "collapsed" state.
1288         (AccessibilityUIElement::hasPopup):
1289         Check whether the object has the "has popup" state.
1290
1291 2010-01-19  Victor Wang  <victorw@chromium.org>
1292
1293         Reviewed by Eric Seidel.
1294
1295         Correct committer name.
1296         https://bugs.webkit.org/show_bug.cgi?id=33868
1297
1298         * Scripts/webkitpy/committers.py:
1299
1300 2010-01-19  Kent Tamura  <tkent@chromium.org>
1301
1302         Reviewed by Darin Adler.
1303
1304         [DRT][Mac] Add modifiers parameter to eventSender.mouseDown() and eventSender.mouseUp()
1305         https://bugs.webkit.org/show_bug.cgi?id=33783
1306
1307         Some listbox tests check selection behavior by click events with
1308         "meta" or "shift" keys. Behaviors for such modifier keys are
1309         platform-dependent. The new parameter of mouseDown() and mouseUp()
1310         allows to specify not only concrete modifier keys such as
1311         "shiftKey" "metaKey", but also functional names like
1312         "addSelectionKey" "rangeSelectionKey".
1313
1314         * DumpRenderTree/mac/EventSendingController.mm:
1315         (+[EventSendingController isSelectorExcludedFromWebScript:]):
1316         (+[EventSendingController webScriptNameForSelector:]):
1317         (buildModifierFlags):
1318         (-[EventSendingController mouseDown:withModifiers:]):
1319         (-[EventSendingController mouseDown:]):
1320         (-[EventSendingController mouseUp:withModifiers:]):
1321         (-[EventSendingController mouseUp:]):
1322         (-[EventSendingController keyDown:withModifiers:withLocation:]):
1323
1324 2010-01-19  Adam Barth  <abarth@webkit.org>
1325
1326         Reviewed by Eric Seidel.
1327
1328         Unbreak --request-commit
1329         https://bugs.webkit.org/show_bug.cgi?id=33832
1330
1331         * Scripts/webkitpy/bugzilla.py:
1332
1333 2010-01-19  Eric Seidel  <eric@webkit.org>
1334
1335         Reviewed by Adam Barth.
1336
1337         validate-committer-lists throws exception and committers.py needs a refresh
1338         https://bugs.webkit.org/show_bug.cgi?id=33831
1339
1340         * Scripts/validate-committer-lists: use webkit_logging
1341         * Scripts/webkitpy/committers.py: Add recently minted committers.  Fix Simon Hausmanns email address list to include his webkit-committers@lists address.
1342
1343 2010-01-18  Adam Roben  <aroben@apple.com>
1344
1345         Add LayoutTestController support for calling new WebKit SPI to
1346         disallow setting document.domain
1347
1348         DRT part of fixing <http://webkit.org/b/33806>
1349         <rdar://problem/7552837> Would like API to disallow setting of
1350         document.domain for pages with certain URL schemes
1351
1352         Reviewed by Sam Weinig.
1353
1354         * DumpRenderTree/LayoutTestController.cpp:
1355         (setDomainRelaxationForbiddenForURLSchemeCallback): Added. Calls
1356         through to LayoutTestController.
1357         (LayoutTestController::staticFunctions): Added
1358         setDomainRelaxationForbiddenForURLScheme.
1359
1360         * DumpRenderTree/LayoutTestController.h: Added
1361         setDomainRelaxationForbiddenForURLScheme.
1362
1363         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1364         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
1365         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1366         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
1367         Added. Calls through to WebKit.
1368
1369         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1370         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
1371         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1372         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
1373         Stubbed out.
1374
1375 2010-01-18  Adam Barth  <abarth@webkit.org>
1376
1377         Reviewed by Adam Roben.
1378
1379         Rename patches-to-commit to patches-in-commit-queue
1380         https://bugs.webkit.org/show_bug.cgi?id=33789
1381
1382         The command really lists the patches in the commit-queue not all the
1383         patches that are pending-commit (as the FIXME commands).
1384
1385         * Scripts/webkitpy/commands/queries.py:
1386         * Scripts/webkitpy/commands/queries_unittest.py:
1387
1388 2010-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1389
1390         Reviewed by Simon Hausmann.
1391
1392         [Qt] Force qmake to generate a single makefile for DerivedSources.pro
1393
1394         * Scripts/webkitdirs.pm:
1395
1396 2010-01-18  Adam Roben  <aroben@apple.com>
1397
1398         Clean up use of /useenv when invoking Visual C++
1399
1400         This change reverts things to their pre-r49485 state. That revision
1401         (and, subsequently, r49664 and r51788) started passing /useenv to
1402         Visual C++, even in cases where we don't want to do so (such as when
1403         invoking Visual C++ Express), in the name of making the Chromium build
1404         work. Now that Chromium isn't using buildVisualStudioProject or
1405         pdevenv, we can put things back they way they were.
1406
1407         Fixes <http://webkit.org/b/33797> build-webkit fails with VC++ Express
1408         (due to /useenv flag)
1409
1410         Reviewed by Sam Weinig.
1411
1412         * Scripts/pdevenv: Always pass /useenv. Chromium doesn't use this
1413         script anymore.
1414         * Scripts/webkitdirs.pm:
1415         (buildVisualStudioProject): Never pass /useenv anymore. pdevenv takes
1416         care of this itself, and we don't want to pass /useenv when not using
1417         pdevenv (e.g., when using VC++ Express, because that will cause it to
1418         ignore the Platform SDK).
1419
1420 2010-01-18  Adam Barth  <abarth@webkit.org>
1421
1422         Reviewed by Eric Seidel.
1423
1424         webkit-patch land-safely should obsolete old patches
1425         https://bugs.webkit.org/show_bug.cgi?id=33788
1426
1427         When posting a commit-queue+ patch with land-safely, we should
1428         obsolete the old patches on the bug.  They're really confusing
1429         because the main use case is to address reviewer feedback on a
1430         previous patch.
1431
1432         * Scripts/webkitpy/commands/upload.py:
1433         * Scripts/webkitpy/commands/upload_unittest.py:
1434
1435 2010-01-18  Adam Barth  <abarth@webkit.org>
1436
1437         Reviewed by David Levin.
1438
1439         webkit-patch should authenticate more often
1440         https://bugs.webkit.org/show_bug.cgi?id=33701
1441
1442         This makes it easier to work with security patches.
1443
1444         * Scripts/webkitpy/bugzilla.py:
1445
1446 2010-01-18  Adam Barth  <abarth@webkit.org>
1447
1448         Reviewed by Darin Adler.
1449
1450         style checker needs to know about GObject-specific requirements
1451         inside WebCore/bindings/gobject/
1452         https://bugs.webkit.org/show_bug.cgi?id=33606
1453
1454         Add an exception to the underscore rule for certain
1455         GObject-specific names.
1456
1457         * Scripts/webkitpy/style/cpp_style.py:
1458         * Scripts/webkitpy/style/cpp_style_unittest.py:
1459
1460 2010-01-18  Adam Barth  <abarth@webkit.org>
1461
1462         Reviewed by Shinichiro Hamaji.
1463
1464         [check-webkit-style] does understand ResourceHandleWin.h
1465         https://bugs.webkit.org/show_bug.cgi?id=32975
1466
1467         I'm not 100% convinced this fix is correct, but without more examples,
1468         it's hard to generalize.  We can always generalize the fix in the
1469         future.
1470
1471         * Scripts/webkitpy/style/cpp_style.py:
1472         * Scripts/webkitpy/style/cpp_style_unittest.py:
1473
1474 2010-01-18  Adam Barth  <abarth@webkit.org>
1475
1476         Unreviewed "build" fix.
1477
1478         * Scripts/webkitpy/bugzilla.py:
1479
1480 2010-01-18  Adam Barth  <abarth@webkit.org>
1481
1482         Unreviewed.  Actually make land-safely mark commit-queue+ as
1483         discussed with Eric.
1484
1485         * Scripts/webkitpy/bugzilla.py:
1486         * Scripts/webkitpy/steps/postdiffforcommit.py:
1487
1488 2010-01-17  Adam Barth  <abarth@webkit.org>
1489
1490         Reviewed by Darin Adler.
1491
1492         style-queue complains about one-line macros that include multiple statements
1493         https://bugs.webkit.org/show_bug.cgi?id=33173
1494
1495         Add an exception for multiple statements on a line that starts a macro.
1496
1497         * Scripts/webkitpy/style/cpp_style.py:
1498         * Scripts/webkitpy/style/cpp_style_unittest.py:
1499
1500 2010-01-17  Adam Barth  <abarth@webkit.org>
1501
1502         Reviewed by Darin Adler.
1503
1504         [check-webkit-style] qt unit testing false positives
1505         https://bugs.webkit.org/show_bug.cgi?id=32833
1506
1507         Exempt the Qt API and unit tests from the style checker.
1508
1509         * Scripts/webkitpy/style/cpp_style.py:
1510         * Scripts/webkitpy/style/cpp_style_unittest.py:
1511
1512 2010-01-17  Adam Barth  <abarth@webkit.org>
1513
1514         Reviewed by Darin Adler.
1515
1516         style-check script reports loads of errors on gtk2drawing.c
1517         https://bugs.webkit.org/show_bug.cgi?id=33771
1518
1519         Exempt WebCore/platform/gtk/gtk2drawing.c and
1520         WebCore/platform/gtk/gtk2drawing.h from style checks.
1521
1522         * Scripts/webkitpy/style/cpp_style.py:
1523         * Scripts/webkitpy/style/cpp_style_unittest.py:
1524
1525 2010-01-17  Chris Jerdonek  <cjerdonek@webkit.org>
1526
1527         Reviewed by Shinichiro Hamaji.
1528
1529         Finished eliminating _cpp_style_state global state variable from
1530         check-webkit-style code and eliminating _CppStyleState class.
1531
1532         https://bugs.webkit.org/show_bug.cgi?id=33764
1533
1534         * Scripts/webkitpy/style/checker.py:
1535           - Minor updates caused by changes to cpp_style.py.
1536
1537         * Scripts/webkitpy/style/cpp_style.py:
1538           - Removed _CppStyleState class.
1539           - Removed verbose_level functions.
1540           - Added verbosity as a parameter to _FunctionState constructor.
1541           - Added verbosity as a parameter to process_file().
1542           - Added verbosity as a parameter to process_file_data().
1543
1544         * Scripts/webkitpy/style/cpp_style_unittest.py:
1545           - Added helper functions to set verbosity while running tests.
1546
1547 2010-01-17  Adam Barth  <abarth@webkit.org>
1548
1549         Reviewed by Shinichiro Hamaji.
1550
1551         check-webkit-style underscore check should be disabled for Qt methods starting with qt_
1552         https://bugs.webkit.org/show_bug.cgi?id=33663
1553
1554         * Scripts/webkitpy/style/cpp_style.py:
1555         * Scripts/webkitpy/style/cpp_style_unittest.py:
1556
1557 2010-01-17  Adam Barth  <abarth@webkit.org>
1558
1559         Reviewed by Eric Seidel.
1560
1561         style-queue complains about missing #include of config.h for non-WebCore projects
1562         https://bugs.webkit.org/show_bug.cgi?id=33170
1563
1564         WebKitAPITests are consumers of the WebKit API and therefore do not
1565         need to follow the same include discipline as the rest of WebKit.  This
1566         patch exempts them from the include checks.
1567
1568         * Scripts/webkitpy/style/cpp_style.py:
1569         * Scripts/webkitpy/style/cpp_style_unittest.py:
1570
1571 2010-01-17  Adam Barth  <abarth@webkit.org>
1572
1573         Reviewed by Eric Seidel.
1574
1575         EWS (Early Warning Systems) should build both debug and release
1576         https://bugs.webkit.org/show_bug.cgi?id=33681
1577
1578         Build both debug and release for chromium-ews.
1579
1580         * Scripts/webkitpy/commands/early_warning_system.py:
1581
1582 2010-01-17  Adam Barth  <abarth@webkit.org>
1583
1584         Reviewed by Darin Adler.
1585
1586         style-queue should include instructions for how to file bugs against check-webkit-style
1587         https://bugs.webkit.org/show_bug.cgi?id=32345
1588
1589         Added some text to the error message asking folks to file bugs against
1590         false positives.
1591
1592         * Scripts/webkitpy/commands/queues.py:
1593
1594 2010-01-17  Chris Jerdonek  <cjerdonek@webkit.org>
1595
1596         Reviewed by Adam Barth.
1597
1598         Eliminated the error_count global variable and related
1599         check-webkit-style refactoring.
1600
1601         https://bugs.webkit.org/show_bug.cgi?id=33678
1602
1603         * Scripts/check-webkit-style:
1604           - Updated to use webkit_argument_defaults().
1605           - Renamed styleChecker to style_checker.
1606
1607         * Scripts/webkitpy/style/checker.py:
1608           - Prefixed the three default arguments with WEBKIT_DEFAULT.
1609           - Added webkit_argument_defaults().
1610           - Added default filter_rules parameter to CategoryFilter constructor.
1611           - Added __ne__() to CategoryFilter class.
1612           - Added __eq__() and __ne__() to ProcessorOptions class.
1613           - Added error_count and _write_error attributes to StyleChecker class.
1614           - Made StyleChecker._handle_error() increment the error count.
1615
1616         * Scripts/webkitpy/style/checker_unittest.py:
1617           - Improved CategoryFilterTest.test_eq().
1618           - Added CategoryFilterTest.test_ne().
1619           - Added test_eq() and test_ne() to ProcessorOptionsTest class.
1620           - Updated unit tests to use webkit_argument_defaults().
1621           - Added StyleCheckerTest class.
1622
1623         * Scripts/webkitpy/style/cpp_style.py:
1624           - Removed references to global error_count.
1625
1626         * Scripts/webkitpy/style/cpp_style_unittest.py:
1627           - Removed CppStyleStateTest class.
1628
1629 2010-01-15  Jon Honeycutt  <jhoneycutt@apple.com>
1630
1631         get_accParent should try to retrieve parent AccessibilityObject, before
1632         calling upon window
1633
1634         https://bugs.webkit.org/show_bug.cgi?id=22893
1635
1636         Reviewed by Darin Adler.
1637
1638         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1639         (AccessibilityUIElement::parentElement):
1640         Get the object's parent. Query it for IAccessible, and return it.
1641
1642 2010-01-16  Dan Bernstein  <mitz@apple.com>
1643
1644         Reviewed by Mark Rowe.
1645
1646         <rdar://problem/7529519> DumpRenderTree crashes in makeLargeMallocFailSilently()
1647
1648         * DumpRenderTree/mac/CheckedMalloc.cpp:
1649         (makeLargeMallocFailSilently): Temporarily allow writing to the default
1650         malloc zone structure while modifying it.
1651
1652 2010-01-16  David Kilzer  <ddkilzer@apple.com>
1653
1654         Added back removed properties to iExploder input files
1655
1656         While the update-iexploder-cssproperties script works great to
1657         add new properties, it has the side-effect of removing old
1658         properties that once were parsed.
1659
1660         * iExploder/htdocs/cssproperties.in: Added back removed
1661         properties into their own section.
1662         * iExploder/htdocs/htmlattrs.in: Ditto.
1663
1664 2010-01-16  Holger Hans Peter Freyther  <zecke@selfish.org>
1665
1666         Reviewed by David Kilzer.
1667
1668         Update iExploder/htdocs/*.in by running update-iexploder-cssproperties
1669         https://bugs.webkit.org/show_bug.cgi?id=33756
1670
1671         * iExploder/htdocs/cssproperties.in: New CSS attributes
1672         * iExploder/htdocs/htmlattrs.in: New HTML attributes
1673         * iExploder/htdocs/htmltags.in: New HTML tags
1674
1675 2010-01-15  Chris Jerdonek  <chris.jerdonek@gmail.com>
1676
1677         Reviewed by David Kilzer.
1678
1679         Altered parseDiffHeader() to skip unrecognized lines and
1680         other minor clean-ups.
1681
1682         https://bugs.webkit.org/show_bug.cgi?id=33476
1683
1684         * Scripts/VCSUtils.pm:
1685           - Changed parseDiffHeader() as follows:
1686             - Skips over unrecognized lines.
1687             - Addressed FIXME to remove substitution for "diff" line.
1688             - Renamed "version" header hash key to "sourceRevision".
1689             - Eliminated "copiedFromVersion" header hash key.
1690             - Included "sourceRevision" also for copied files.
1691             - Checks that copy revision number matches "sourceRevision".
1692             - No longer returns $foundHeaderEnding.
1693             - Dies if header ending not found.
1694             - Diff header dividing line now always added.
1695
1696         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
1697           - Made necessary changes in parseDiffHeader() unit tests.
1698           - Shortened the file paths in some test cases.
1699
1700 2010-01-14  Yuzo Fujishima  <yuzo@google.com>
1701
1702         Reviewed by Alexey Proskuryakov.
1703
1704         Update pywebsocket to 0.4.6
1705         https://bugs.webkit.org/show_bug.cgi?id=32299
1706         The newer pywebsocket can handle more simultaneous connections.
1707
1708         * pywebsocket/mod_pywebsocket/handshake.py:
1709         * pywebsocket/mod_pywebsocket/standalone.py:
1710         * pywebsocket/setup.py:
1711         * pywebsocket/test/test_handshake.py:
1712
1713 2010-01-14  Eric Seidel  <eric@webkit.org>
1714
1715         Reviewed by Adam Barth.
1716
1717         REGRESSION(53133): commit-queue no longer rejects patches with invalid committers, instead it hangs
1718         https://bugs.webkit.org/show_bug.cgi?id=33638
1719
1720         * Scripts/webkitpy/bugzilla.py:
1721          - Add Bug.id() to match Attachment.id()
1722          - Give Bug.reviewed_patches and commit_queued_patches the option to return patches with invalid committers/reviewers.
1723          - Add back a missing variable to _validate_setter_email found by the new unit tests!
1724         * Scripts/webkitpy/commands/queries.py:
1725          - Add FIXMEs about the commands being confusingly named.
1726         * Scripts/webkitpy/commands/queries_unittest.py:
1727          - Update results to reflect the newly restructured mock bug cache.
1728         * Scripts/webkitpy/commands/queues.py:
1729          - Add a new _validate_patches_in_commit_queue method (this is what fixes the regression).
1730          - Add a FIXME about eventually sorting the patches into some order.
1731         * Scripts/webkitpy/commands/queues_unittest.py:
1732          - Update results now that with the newly restructure mock bug cache we're testing cq+'d patches with an invalid committer.
1733         * Scripts/webkitpy/commands/upload_unittest.py:
1734          - Update results to match the newly restructured mock bug cache.
1735         * Scripts/webkitpy/mock_bugzillatool.py:
1736          - Restructure fetch_ methods to not use a manual list of ids, but rather use Bug and Attachment classes to make real queries from all of the Bugs.
1737          - Add a few more attachments and bug dictionaries for use by the tests.
1738
1739 2010-01-13  Diego Gonzalez  <diego.gonzalez@openbossa.org>
1740
1741         Reviewed by Kenneth Christiansen.
1742
1743         [Qt] DRT missing setUserStyleSheetLocation and setUserStyleSheetEnabled in LayoutTestController
1744         https://bugs.webkit.org/show_bug.cgi?id=33617
1745
1746         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1747         (WebCore::WebPage::resetSettings):
1748         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1749         (LayoutTestController::setUserStyleSheetLocation):
1750         (LayoutTestController::setUserStyleSheetEnabled):
1751         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1752
1753 2010-01-14  Adam Roben  <aroben@apple.com>
1754
1755         Add LayoutTestController API to force
1756         -webView:resource:willSendRequest:: to return null
1757
1758         Enables tests for <rdar://problem/7533333> <http://webkit.org/b/33533>
1759         window.onload never fires if page contains an <iframe> with a bad
1760         scheme or whose load is cancelled by returning null from resource load
1761         delegate's willSendRequest
1762
1763         Reviewed by Brady Eidson.
1764
1765         * DumpRenderTree/LayoutTestController.cpp:
1766         (LayoutTestController::LayoutTestController): Initialize new member.
1767         (setWillSendRequestReturnsNullCallback): Call through to
1768         LayoutTestController.
1769         (LayoutTestController::staticFunctions): Added new function.
1770
1771         * DumpRenderTree/LayoutTestController.h: Added
1772         m_willSendRequestReturnsNull.
1773         (LayoutTestController::willSendRequestReturnsNull):
1774         (LayoutTestController::setWillSendRequestReturnsNull):
1775         Added standard accessors.
1776
1777         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1778         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1779         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1780         (ResourceLoadDelegate::willSendRequest):
1781         Return null if LayoutTestController says to.
1782
1783 2010-01-14  Kevin Ollivier  <kevino@theolliviers.com>
1784
1785         [wx] Build fix after removal of XBM support.
1786
1787         * wx/build/settings.py:
1788
1789 2010-01-14  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1790
1791         Reviewed by Simon Hausmann.
1792
1793         Add support for partial building on Symbian.
1794
1795         The build happens in the source directory as out of source builds are
1796         not supported by qmake for Symbian.
1797
1798         Also the actual build isn't started but it is left to the developer
1799         to choose the architecture/configuration.
1800
1801         * Scripts/webkitdirs.pm:
1802
1803 2010-01-14  Simon Hausmann  <simon.hausmann@nokia.com>
1804
1805         Reviewed by Kenneth Rohde Christiansen.
1806
1807         Add support for "detecting" Symbian environments by either
1808         looking for the EPOCROOT environment variable or via --symbian
1809         being passed on the commandline.
1810
1811         * Scripts/webkitdirs.pm:
1812
1813 2010-01-14  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1814
1815         Unreviewed.
1816
1817         [Qt] Use a different Makefile names for sources generation and compilation.
1818         This prevents Makefile overwriting when running build-webkit twice.
1819
1820         * Scripts/webkitdirs.pm:
1821
1822 2010-01-14  Andreas Kling  <andreas.kling@nokia.com>
1823
1824         Reviewed by Kenneth Rohde Christiansen.
1825
1826         [Qt] Add an "alien_QLabel" classId for manual testing of alien widgets.
1827
1828         https://bugs.webkit.org/show_bug.cgi?id=33373
1829
1830         * QtLauncher/main.cpp:
1831         (WebPage::createPlugin):
1832
1833 2010-01-14  Eric Seidel  <eric@webkit.org>
1834
1835         No review, rolling out r53249.
1836         http://trac.webkit.org/changeset/53249
1837         https://bugs.webkit.org/show_bug.cgi?id=33617
1838
1839         This caused http/tests/security/local-user-CSS-from-
1840         remote.html to fail on the Qt Release Build Bot.
1841
1842         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1843         (WebCore::WebPage::resetSettings):
1844         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1845         (LayoutTestController::overridePreference):
1846         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1847
1848 2010-01-14  Chris Jerdonek  <chris.jerdonek@gmail.com>
1849
1850         Reviewed by Shinichiro Hamaji.
1851
1852         Moved error() from cpp_style.py to checker.py.
1853
1854         https://bugs.webkit.org/show_bug.cgi?id=33620
1855
1856         * Scripts/check-webkit-style:
1857           - Addressed FIXME to not set global state.
1858
1859         * Scripts/webkitpy/style/checker.py:
1860           - Added argument validation to ProcessorOptions constructor.
1861           - Added should_report_error() to ProcessorOptions class.
1862           - Removed set_options().
1863           - Added StyleChecker class.
1864
1865         * Scripts/webkitpy/style/checker_unittest.py:
1866           - Added unit test class for ProcessorOptions class.
1867           - Added unit test to check that parse() strips white space.
1868
1869         * Scripts/webkitpy/style/cpp_style.py:
1870           - Removed "filter" and "output_format" methods.
1871           - Removed should_print_error() and error() functions.
1872           - Removed default parameter value from process_file().
1873
1874         * Scripts/webkitpy/style/cpp_style_unittest.py:
1875           - Removed call to cpp_style._should_print_error().
1876           - Removed test_filter() and test_filter_appending().
1877
1878         * Scripts/webkitpy/style/text_style.py:
1879           - Removed default parameter value from process_file().
1880
1881 2010-01-14  Diego Gonzalez  <diego.gonzalez@openbossa.org>
1882
1883         Reviewed by Kenneth Rohde Christiansen.
1884
1885         [Qt] DRT missing setUserStyleSheetLocation and setUserStyleSheetEnabled in LayoutTestController
1886         https://bugs.webkit.org/show_bug.cgi?id=33617
1887
1888         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1889         (WebCore::WebPage::resetSettings):
1890         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1891         (LayoutTestController::setUserStyleSheetLocation):
1892         (LayoutTestController::setUserStyleSheetEnabled):
1893         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1894
1895 2010-01-13  Adam Barth  <abarth@webkit.org>
1896
1897         Reviewed by Eric Seidel.
1898
1899         Fix CloseBugForLandDiff unittest to actually run
1900         https://bugs.webkit.org/show_bug.cgi?id=33640
1901
1902         * Scripts/webkitpy/mock_bugzillatool.py:
1903         * Scripts/webkitpy/steps/closebugforlanddiff_unittest.py:
1904
1905 2010-01-12  Jon Honeycutt  <jhoneycutt@apple.com>
1906
1907         MSAA: selected, selectable, extended selectable, and multiple
1908         selectable states are not reported
1909
1910         https://bugs.webkit.org/show_bug.cgi?id=33574
1911         <rdar://problem/7536826>
1912
1913         Reviewed by Darin Adler.
1914
1915         * DumpRenderTree/AccessibilityUIElement.cpp:
1916         (getIsSelectableCallback):
1917         Return the result of calling isSelectable().
1918         (getIsMultiSelectableCallback):
1919         Return the result of calling isMultiSelectable().
1920         (AccessibilityUIElement::getJSClass):
1921         Add isSelected and isMultiSelectable properties to the JSClass
1922         definition.
1923
1924         * DumpRenderTree/AccessibilityUIElement.h:
1925         Declare isSelectable() and isMultiSelectable().
1926
1927         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1928         (AccessibilityUIElement::isSelectable):
1929         Stubbed.
1930         (AccessibilityUIElement::isMultiSelectable):
1931         Stubbed.
1932
1933         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1934         (AccessibilityUIElement::isSelectable):
1935         Stubbed.
1936         (AccessibilityUIElement::isMultiSelectable):
1937         Stubbed.
1938
1939         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1940         (accessibilityState):
1941         Get the object's state, and return it.
1942         (AccessibilityUIElement::isSelected):
1943         Check the object's selected state.
1944         (AccessibilityUIElement::isSelectable):
1945         Check the object's selectable state.
1946         (AccessibilityUIElement::isMultiSelectable):
1947         Check the object's extended/multiple selectable state.
1948
1949 2010-01-13  Adam Barth  <abarth@webkit.org>
1950
1951         Unreviewed.  Repeat the below for CloseBugForLandDiff.
1952
1953         * Scripts/test-webkitpy:
1954         * Scripts/webkitpy/steps/closebugforlanddiff.py:
1955         * Scripts/webkitpy/steps/closebugforlanddiff_unittest.py: Added.
1956
1957 2010-01-13  Adam Barth  <abarth@webkit.org>
1958
1959         Unreviewed.  Turn the mac-ews status bubbles back on now that this bot
1960         is running again.
1961
1962         * QueueStatusServer/templates/statusbubble.html:
1963
1964 2010-01-13  Adam Barth  <abarth@webkit.org>
1965
1966         Reviewed by Darin Adler.
1967
1968         REGRESSION(53133): webkit-patch land dies if it can't find a bug id.
1969         https://bugs.webkit.org/show_bug.cgi?id=33634
1970
1971         Deal with the case of no bug patch object in the state.
1972
1973         * Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py:
1974         * Scripts/webkitpy/steps/updatechangelogswithreviewer.py:
1975
1976 2010-01-13  Kenneth Russell  <kbr@google.com>
1977
1978         Unreviewed; added myself to the committers list.
1979
1980         * Scripts/webkitpy/committers.py:
1981
1982 2010-01-13  Darin Adler  <darin@apple.com>
1983
1984         Ignore compiled Python in more of webkitpy.
1985
1986         * Scripts/webkitpy/commands: Added property svn:ignore.
1987         * Scripts/webkitpy/steps: Added property svn:ignore.
1988         * Scripts/webkitpy/style: Added property svn:ignore.
1989
1990 2010-01-13  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1991
1992         Reviewed by Simon Hausmann.
1993
1994         [Qt] Fix build problem related to the pushd command
1995
1996         * Scripts/webkitdirs.pm:
1997
1998 2010-01-13  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1999
2000         Reviewed by Simon Hausmann.
2001
2002         [Qt] Split the build process in two different .pro files.
2003         This allows qmake to be run once all source files are available.
2004
2005         * Scripts/webkitdirs.pm: Add calls to make DerivedSources.pro in JSC and WC.
2006
2007 2010-01-13  Shinichiro Hamaji  <hamaji@chromium.org>
2008
2009         Unreviewed tiny typo fix in docstrings.
2010
2011         * Scripts/webkitpy/style/checker_unittest.py:
2012
2013 2010-01-13  Chris Jerdonek  <chris.jerdonek@gmail.com>
2014
2015         Reviewed by Shinichiro Hamaji.
2016
2017         Created a CategoryFilter class to encapsulate the logic of
2018         filter rules.
2019
2020         https://bugs.webkit.org/show_bug.cgi?id=33454
2021
2022         * Scripts/webkitpy/style/checker.py:
2023           - Added CategoryFilter class.
2024
2025         * Scripts/webkitpy/style/checker_unittest.py:
2026           - Added CategoryFilter unit tests.
2027
2028         * Scripts/webkitpy/style/cpp_style.py:
2029           - Updated filter methods to use CategoryFilter.
2030
2031         * Scripts/webkitpy/style/cpp_style_unittest.py:
2032           - Updated references to filters.
2033
2034 2010-01-12  Shinichiro Hamaji  <hamaji@chromium.org>
2035
2036         Unreviewed. Now I can review :)
2037
2038         * Scripts/webkitpy/committers.py:
2039
2040 2010-01-12  Brent Fulgham  <bfulgham@webkit.org>
2041
2042         Reviewed by Darin Adler.
2043
2044         Extend WinLauncher example with better printing features.
2045
2046         * WinLauncher/PrintWebUIDelegate.cpp:
2047         (PrintWebUIDelegate::webViewPrintingMarginRect): Provide slightly
2048          larger margins.
2049         (PrintWebUIDelegate::webViewHeaderHeight): Compute header height based
2050          on text metrics.
2051         (PrintWebUIDelegate::webViewFooterHeight): Compute footer height based
2052          on text metrics.
2053         (PrintWebUIDelegate::drawHeaderInRect): Write useful header, along
2054          with separating line.
2055         (PrintWebUIDelegate::drawFooterInRect):
2056         * WinLauncher/PrintWebUIDelegate.h: Remove stubs.
2057         * WinLauncher/WinLauncher.cpp:
2058         (PrintView): Correct loop used to print individual pages.
2059          Previously it started at 0, which is a wild-card to print all
2060          pages at once.
2061
2062 2010-01-12  Alexey Proskuryakov  <ap@apple.com>
2063
2064         Reviewed by Darin Adler.
2065
2066         https://bugs.webkit.org/show_bug.cgi?id=33540
2067         Make it possible to build in debug mode with assertions disabled
2068
2069         * DumpRenderTree/mac/ObjCController.m: (-[ObjCController accessStoredWebScriptObject]):
2070
2071 2010-01-11  Darin Fisher  <darin@chromium.org>
2072
2073         Reviewed by Dimitri Glazkov.
2074
2075         [Chromium] "build-webkit --chromium" should run "make all" on Linux
2076         https://bugs.webkit.org/show_bug.cgi?id=33500
2077
2078         * Scripts/webkitdirs.pm:
2079
2080 2010-01-12  Eric Seidel  <eric@webkit.org>
2081
2082         Reviewed by Adam Barth.
2083
2084         AssignToCommitter does not need to fetch bugs twice
2085         https://bugs.webkit.org/show_bug.cgi?id=33530
2086
2087         This is a no-brainer patch now that we've added Bug.reviewed_patches
2088
2089         * Scripts/webkitpy/commands/upload.py:
2090
2091 2010-01-12  Eric Seidel  <eric@webkit.org>
2092
2093         Reviewed by Adam Barth.
2094
2095         bugzilla.py should have an Attachment object instead of passing around dictionaries
2096         https://bugs.webkit.org/show_bug.cgi?id=31594
2097
2098         * Scripts/webkitpy/bugzilla.py:
2099          - Add a new Attachment class, with accessor methods for all the necessary properties.
2100          - Update Bug to carry a pointer back to bugzilla (attachments need to access Bugzilla for committer validation and url())
2101          - Move reviewed_patches and commit_queued_patches out of Bugzilla custom methods and onto Bug
2102          - Move committer validation logic into its own class.
2103          - Committer rejection is only used in one place.  Make the new Bug reviewed_patches and commit_queued_patches
2104            handle the common case (of returning "reviewer" or "committer" as None), and let CommitterValidation handle
2105            the case where we want to reject patches in bugzilla.
2106          - Simplify fetch_patches_from_commit_queue now that committer validation is simpler.
2107          - Make all self.bugzilla.fetch_bug access go through BugzillaQueries._fetch_bug.
2108          - Mark set_flag_on_attachment as non-private to denote that CommitterValidation depends on it.
2109          - Move fetch_reviewed_patches_from_bug and fetch_commit_queue_patches_from_bug logic onto the Bug class.
2110         * Scripts/webkitpy/bugzilla_unittest.py:
2111          - Move test_flag_permission_rejection_message into a new CommitterValidationTest class.
2112         * Scripts/webkitpy/commands/download.py:
2113          - Store "bug_id" in state instead of making a fake patch object.
2114          - Update to use Attachment and Bug objects.
2115         * Scripts/webkitpy/commands/download_unittest.py:
2116          - Update expected results now that our testing framework covers more code.
2117         * Scripts/webkitpy/commands/early_warning_system.py: Update to use new Attachment class.
2118         * Scripts/webkitpy/commands/queries.py: Remove unused ReviewedPatches class.
2119         * Scripts/webkitpy/commands/queries_unittest.py: ditto.
2120         * Scripts/webkitpy/commands/queues.py: Update to use new Attachment and CommitterValidator classes.
2121         * Scripts/webkitpy/commands/queuestest.py: ditto.
2122         * Scripts/webkitpy/commands/upload.py: ditto.
2123         * Scripts/webkitpy/mock_bugzillatool.py:
2124          - Now that more logic has moved into Attachment and Bug, we have to actually
2125            provide real reviewer emails as well as real reviewer flags.
2126          - Update mock methods to return Attachment objects.
2127         * Scripts/webkitpy/scm.py: Update to use Attachment class.
2128         * Scripts/webkitpy/scm_unittest.py: Update to use Attachment class.
2129         * Scripts/webkitpy/statusserver.py: ditto.
2130         * Scripts/webkitpy/steps/applypatch.py: ditto.
2131         * Scripts/webkitpy/steps/applypatchwithlocalcommit.py: ditto.
2132         * Scripts/webkitpy/steps/closebug.py: ditto.
2133         * Scripts/webkitpy/steps/closebugforlanddiff.py: Handle either state["bug_id"] or state["patch"].bug_id()
2134         * Scripts/webkitpy/steps/closepatch.py: Update to use Attachment class.
2135         * Scripts/webkitpy/steps/obsoletepatches.py: ditto.
2136         * Scripts/webkitpy/steps/updatechangelogswithreviewer.py: ditto.
2137
2138 2010-01-12  Adam Barth  <abarth@webkit.org>
2139
2140         Unreviewed typo fix.  :(
2141
2142         * Scripts/webkitpy/commands/early_warning_system.py:
2143         * Scripts/webkitpy/commands/queues.py:
2144
2145 2010-01-12  Adam Barth  <abarth@webkit.org>
2146
2147         Unreviewed.  Add "error" to the right part of the message.
2148
2149         * Scripts/webkitpy/commands/queues.py:
2150
2151 2010-01-12  Adam Barth  <abarth@webkit.org>
2152
2153         Reviewed by Eric Seidel.
2154
2155         EWS should show purple when svn-apply fails
2156         https://bugs.webkit.org/show_bug.cgi?id=33527
2157
2158         * Scripts/webkitpy/commands/early_warning_system.py:
2159         * Scripts/webkitpy/commands/queues.py:
2160
2161 2010-01-12  Adam Barth  <abarth@webkit.org>
2162
2163         Reviewed by Eric Seidel.
2164
2165         Remove copy/paste code from subclasses of AbstractReviewQueue
2166         https://bugs.webkit.org/show_bug.cgi?id=33525
2167
2168         * Scripts/webkitpy/commands/early_warning_system.py:
2169         * Scripts/webkitpy/commands/queues.py:
2170
2171 2010-01-12  Adam Barth  <abarth@webkit.org>
2172
2173         Reviewed by Eric Seidel.
2174
2175         Add Gustavo and Xan as gtk-ews watchers
2176         https://bugs.webkit.org/show_bug.cgi?id=33519
2177
2178         * Scripts/webkitpy/commands/early_warning_system.py:
2179
2180 2010-01-12  Adam Barth  <abarth@webkit.org>
2181
2182         Reviewed by Eric Seidel.
2183
2184         webkit-patch shouldn't waste my time for with a component prompt
2185         https://bugs.webkit.org/show_bug.cgi?id=33521
2186
2187         The component field isn't very useful for bugs created with
2188         webkit-patch because they're likely to be resolved quickly.  Instead of
2189         always prompting for a component, we should just default to the "New
2190         Bugs" component.  If the bug stays around for more than five minutes,
2191         we can assign it a proper component.
2192
2193         * Scripts/webkitpy/bugzilla.py:
2194
2195 2010-01-12  Adam Barth  <abarth@webkit.org>
2196
2197         Reviewed by Eric Seidel.
2198
2199         Add experimental "land-safely" command to webkit-patch
2200         https://bugs.webkit.org/show_bug.cgi?id=33518
2201
2202         * Scripts/webkitpy/commands/upload.py:
2203         * Scripts/webkitpy/commands/upload_unittest.py:
2204         * Scripts/webkitpy/steps/__init__.py:
2205         * Scripts/webkitpy/steps/postdiffforcommit.py: Added.
2206
2207 2010-01-11  Kevin Ollivier  <kevino@theolliviers.com>
2208
2209         [wx] Build fix after introduction of JS_NO_EXPORT
2210
2211         * wx/build/settings.py:
2212
2213 2010-01-11  Eric Seidel  <eric@webkit.org>
2214
2215         No review, rolling out r53079.
2216         http://trac.webkit.org/changeset/53079
2217         https://bugs.webkit.org/show_bug.cgi?id=33197
2218
2219         Adam doens't think this actually works, and believe it caused
2220         a regression https://bugs.webkit.org/show_bug.cgi?id=33488 so
2221         rolling this out.
2222
2223         * Scripts/test-webkitpy:
2224         * Scripts/webkitpy/commands/abstractdiffcommand.py: Removed.
2225         * Scripts/webkitpy/commands/abstractdiffcommand_unittest.py: Removed.
2226         * Scripts/webkitpy/commands/download.py:
2227         * Scripts/webkitpy/commands/upload.py:
2228         * Scripts/webkitpy/mock_bugzillatool.py:
2229
2230 2010-01-10  Adam Barth  <abarth@webkit.org>
2231
2232         Reviewed by David Kilzer.
2233
2234         bugzilla-tool submit-patch mistakenly picks up bug URLs in non-ChangeLog files
2235         https://bugs.webkit.org/show_bug.cgi?id=33197
2236
2237         We should just search for bug numbers in the ChangeLogs instead of in
2238         the whole diff.
2239
2240         * Scripts/test-webkitpy:
2241         * Scripts/webkitpy/commands/abstractdiffcommand.py: Added.
2242         * Scripts/webkitpy/commands/abstractdiffcommand_unittest.py: Added.
2243         * Scripts/webkitpy/commands/download.py:
2244         * Scripts/webkitpy/commands/upload.py:
2245         * Scripts/webkitpy/mock_bugzillatool.py:
2246
2247 2010-01-11  Chris Jerdonek  <chris.jerdonek@gmail.com>
2248
2249         Reviewed by David Kilzer.
2250
2251         Created a unit-tested function to parse the header block of
2252         a Git or SVN diff -- for future refactoring of svn-apply and
2253         svn-unapply.
2254
2255         https://bugs.webkit.org/show_bug.cgi?id=33447
2256
2257         * Scripts/VCSUtils.pm:
2258           - Added parseDiffHeader().
2259           - Removed irrelevant comment from gitdiff2svndiff().
2260
2261         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl: Added.
2262           - Added 48 unit tests for parseDiffHeader().
2263
2264 2010-01-10  Adam Barth  <abarth@webkit.org>
2265
2266         Rubber stamped by David Kilzer.
2267
2268         bugzilla-tool submit-patch mistakenly picks up bug URLs in non-ChangeLog files
2269         https://bugs.webkit.org/show_bug.cgi?id=33197
2270
2271         Fix a typo: Commmand -> Command.
2272
2273         * Scripts/webkitpy/commands/abstractsequencedcommand.py:
2274         * Scripts/webkitpy/commands/download.py:
2275         * Scripts/webkitpy/commands/queries.py:
2276         * Scripts/webkitpy/commands/upload.py:
2277         * Scripts/webkitpy/multicommandtool.py:
2278
2279 2010-01-10  Adam Barth  <abarth@webkit.org>
2280
2281         Reviewed by Darin Adler.
2282
2283         Let webkit-patch work with options in $EDITOR
2284         https://bugs.webkit.org/show_bug.cgi?id=33414
2285
2286         The $EDITOR evironment variable might have command line options like
2287         bbedit -w.  This patch lets us run those $EDITORs.
2288
2289         * Scripts/webkitpy/user.py:
2290
2291 2010-01-10  Robert Hogan  <robert@roberthogan.net>
2292
2293         Reviewed by Adam Barth.
2294
2295         [Qt] Add enableXSSAuditor support to QWebSettings and DRT.
2296
2297         https://bugs.webkit.org/show_bug.cgi?id=33419
2298
2299         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2300         (WebCore::WebPage::WebPage):
2301         (WebCore::WebPage::resetSettings):
2302         (WebCore::DumpRenderTree::createWindow):
2303         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2304         (LayoutTestController::setXSSAuditorEnabled):
2305         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2306
2307 2010-01-10  Adam Barth  <abarth@webkit.org>
2308
2309         Unreviewed cosmetic change.  Remove the status bubble for mac-ews
2310         because we don't have hardware for it at the moment.
2311
2312         * QueueStatusServer/templates/statusbubble.html:
2313
2314 2010-01-09  Daniel Bates  <dbates@webkit.org>
2315
2316         No review, rolling out r53044.
2317         http://trac.webkit.org/changeset/53044
2318         https://bugs.webkit.org/show_bug.cgi?id=33419
2319
2320         We need to look into this some more because the Qt
2321         bot is failing the XSSAuditor tests. See bug #33419
2322         for more details.
2323
2324         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2325         (WebCore::WebPage::WebPage):
2326         (WebCore::WebPage::resetSettings):
2327         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2328         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2329
2330 2010-01-09  Daniel Bates  <dbates@webkit.org>
2331
2332         Reviewed by Adam Barth.
2333
2334         https://bugs.webkit.org/show_bug.cgi?id=33419
2335
2336         Adds support for the XSSAuditor to the Qt DRT.
2337
2338         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2339         (WebCore::WebPage::WebPage):
2340         (WebCore::WebPage::resetSettings):
2341         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2342         (LayoutTestController::setXSSAuditorEnabled):
2343         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2344
2345 2010-01-09  Adam Barth  <abarth@webkit.org>
2346
2347         Reviewed by Eric Seidel.
2348
2349         Retry writes to QueueStatusServer when we get 500 errors
2350         https://bugs.webkit.org/show_bug.cgi?id=33412
2351
2352         This prevents the queues from failing to mark a patch as "pass" or
2353         "fail" when AppEngine throws 500 errors.
2354
2355         * Scripts/test-webkitpy:
2356         * Scripts/webkitpy/networktransaction.py: Added.
2357         * Scripts/webkitpy/networktransaction_unittest.py: Added.
2358         * Scripts/webkitpy/statusserver.py:
2359         * Scripts/webkitpy/steps/closebugformarkbugfixed.py: Added.
2360         * Scripts/webkitpy/steps/closebugregardlessofpatches.py: Added.
2361         * Scripts/webkitpy/steps/findbugidfromsvnrevision.py: Added.
2362
2363 2010-01-09  David Kilzer  <ddkilzer@apple.com>
2364
2365         <http://webkit.org/b/33430> Fix rounded borders in queue status on older Firefox and Safari browsers
2366
2367         Reviewed by Eric Seidel.
2368
2369         * QueueStatusServer/templates/statusbubble.html: Added
2370         -moz-border-radius and -webkit-border-radius to provide rounded
2371         borders in older Firefox and Safari browsers.
2372
2373 2010-01-09  Chris Jerdonek  <chris.jerdonek@gmail.com>
2374
2375         Reviewed by David Kilzer.
2376
2377         Modified VCSUtils::gitdiff2svndiff() to accept strings that
2378         end in vertical white space.
2379
2380         https://bugs.webkit.org/show_bug.cgi?id=33415
2381
2382         * Scripts/VCSUtils.pm:
2383         * Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl:
2384
2385 2010-01-08  Eric Seidel  <eric@webkit.org>
2386
2387         Reviewed by Adam Barth.
2388
2389         run-javascriptcore-tests needs a --quiet flag
2390         https://bugs.webkit.org/show_bug.cgi?id=33399
2391
2392         Until run-javascriptcore-tests has a --quiet flag, lets just stiffle the output in webkit-patch.
2393
2394         * Scripts/webkitpy/steps/runtests.py:
2395
2396 2010-01-08  Andras Becsi  <abecsi@inf.u-szeged.hu>
2397
2398         Reviewed by Alexey Proskuryakov.
2399
2400         Only run http and websocket tests as last if no argument is given to be able to explicitly control the test order.
2401
2402         To be able to run multiple instances of run-webkit-tests besides each other on the same machine we need to minimize
2403         the time when Apache and WebSocketServer is locked by tests.
2404         Because closeHTTPD() and closeWebSocketServer() is only called at the end of the testing,
2405         we need to run http and websocket tests after all other tests.
2406         If one however explicitly specifies the tests to run in the argument list of run-webkit-tests
2407         we need to preserve the given order.
2408
2409         * Scripts/run-webkit-tests:
2410
2411 2010-01-08  Adam Barth  <abarth@webkit.org>
2412
2413         Reviewed by Eric Seidel.
2414
2415         Don't post style-queue pass messages to bugs
2416         https://bugs.webkit.org/show_bug.cgi?id=33404
2417
2418         These messages aren't needed any more now that we have the status
2419         bubble reporting pass events passively.
2420
2421         * Scripts/webkitpy/commands/queues.py:
2422
2423 2010-01-08  Adam Barth  <abarth@webkit.org>
2424
2425         Reviewed by Eric Seidel.
2426
2427         Optimize the number of CPUs used for building Qt and Gtk
2428         https://bugs.webkit.org/show_bug.cgi?id=33394
2429
2430         Instead of hardcoding the number 8, we should read the number of CPUs
2431         from the environment.
2432
2433         * Scripts/webkitpy/executive.py:
2434         * Scripts/webkitpy/webkitport.py:
2435         * Scripts/webkitpy/webkitport_unittest.py:
2436
2437 2010-01-08  Chris Fleizach  <cfleizach@apple.com>
2438
2439         Reviewed by Eric Seidel.
2440
2441         REGRESSION(52819?): AXLoadComplete and AXLayoutComplete causes 4 tests fail on Snow Leopard Debug bot
2442         https://bugs.webkit.org/show_bug.cgi?id=33300
2443
2444         * DumpRenderTree/AccessibilityUIElement.h:
2445         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2446         (AccessibilityUIElement::AccessibilityUIElement):
2447         (AccessibilityUIElement::~AccessibilityUIElement):
2448         (_accessibilityNotificationCallback):
2449         (AccessibilityUIElement::addNotificationListener):
2450
2451 2010-01-08  Eric Seidel  <eric@webkit.org>
2452
2453         Reviewed by Simon Hausmann.
2454
2455         commit-queue should run run-javascriptcore-tests
2456         https://bugs.webkit.org/show_bug.cgi?id=33376
2457
2458         I also made it run the python and perl unit tests.
2459
2460         * Scripts/webkitpy/steps/runtests.py:
2461         * Scripts/webkitpy/webkitport.py:
2462
2463 2010-01-07  Andras Becsi  <abecsi@inf.u-szeged.hu>
2464
2465         Reviewed by Darin Adler.
2466
2467         Run the http and websocket tests after all other tests.
2468         https://bugs.webkit.org/show_bug.cgi?id=33153
2469
2470         * Scripts/run-webkit-tests:
2471
2472 2010-01-07  Adam Barth  <abarth@webkit.org>
2473
2474         Reviewed by Eric Seidel.
2475
2476         Fix some test-webkitpy expectations
2477         https://bugs.webkit.org/show_bug.cgi?id=33345
2478
2479         I forgot to change these when I added the CheckStyle step.
2480
2481         * Scripts/webkitpy/commands/upload_unittest.py:
2482
2483 2010-01-07  Adam Barth  <abarth@webkit.org>
2484
2485         Reviewed by Eric Seidel.
2486
2487         webkit-patch edit-changelogs (or upload) will open blank files if run outside the root
2488         https://bugs.webkit.org/show_bug.cgi?id=33341
2489
2490         Fix this by moving to the root directory before editing ChangeLogs.
2491         There is a related bug with CheckStyle.
2492
2493         * Scripts/webkitpy/steps/checkstyle.py:
2494         * Scripts/webkitpy/steps/editchangelog.py:
2495
2496 2010-01-07  Eric Seidel  <eric@webkit.org>
2497
2498         Reviewed by Nikolas Zimmermann.
2499
2500         media/unsupported-tracks.html is failing on Snow Leopard Release bot
2501         https://bugs.webkit.org/show_bug.cgi?id=32339
2502
2503         This is a speculative fix.  I do not have a Snow Leopard machine to test on
2504         and I've not seen mention of someone being able to reproduce this locally.
2505
2506         Prevent watchdog timer from firing after a test completes but before
2507         the next one starts, causing the error to appear in the next test.
2508
2509         * DumpRenderTree/mac/DumpRenderTree.mm:
2510         (dump): Stop the watchdog before printing #EOF for the test content.
2511         We only need to care about the JavaScript of the test running too long
2512         or some hang in WebCore.  Any other failures will be covered by the calling
2513         script's own watchdog timer.
2514
2515 2010-01-07  Eric Seidel  <eric@webkit.org>
2516
2517         Reviewed by Adam Barth.
2518
2519         commit-queue is stuck spinning due to exception
2520         https://bugs.webkit.org/show_bug.cgi?id=33358
2521
2522         * Scripts/webkitpy/commands/queues.py:
2523          - Don't try to stringify the exception.
2524
2525 2010-01-07  Mark Rowe  <mrowe@apple.com>
2526
2527         Reviewed by Jon Honeycutt.
2528
2529         Don't leak a JSStringRef within _accessibilityNotificationCallback.
2530
2531         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2532         (_accessibilityNotificationCallback): Have a JSRetainPtr adopt the JSStringRef so that it will be cleaned up
2533         when it goes out of scope.
2534
2535 2010-01-07  Simon Fraser  <simon.fraser@apple.com>
2536
2537         Reviewed by Darin Adler.
2538
2539         Add proposed rename of HTMLPlugInImageElement to HTMLEmbeddedObjectElement.
2540
2541         * Scripts/do-webcore-rename:
2542
2543 2010-01-07  Kim Grönholm  <kim.gronholm@nomovok.com>
2544
2545         Reviewed by Antti Koivisto.
2546
2547         Wrong state and TouchLists in TouchEvents
2548         https://bugs.webkit.org/show_bug.cgi?id=32878
2549
2550         * DumpRenderTree/qt/EventSenderQt.cpp:
2551         (EventSender::touchStart):
2552         (EventSender::touchEnd):
2553         (EventSender::clearTouchPoints):
2554         * DumpRenderTree/qt/EventSenderQt.h:
2555
2556 2010-01-07  Chris Jerdonek  <chris.jerdonek@gmail.com>
2557
2558         Reviewed by Adam Barth.
2559
2560         Created a module that runs the style package unit tests.
2561
2562         https://bugs.webkit.org/show_bug.cgi?id=32973
2563
2564         * Scripts/test-webkitpy:
2565         * Scripts/webkitpy/style/unittests.py: Added.
2566
2567 2010-01-07  Adam Barth  <abarth@webkit.org>
2568
2569         Reviewed by Maciej Stachowiak.
2570
2571         Don't print a redundant message when confirming a diff
2572         https://bugs.webkit.org/show_bug.cgi?id=33315
2573
2574         Instead of saying "ERROR: User declined" we should just exit because
2575         the use knows they just declined!
2576
2577         * Scripts/webkitpy/steps/confirmdiff.py:
2578
2579 2010-01-07  Adam Barth  <abarth@webkit.org>
2580
2581         Reviewed by Maciej Stachowiak.
2582
2583         Check style before uploading a patch
2584         https://bugs.webkit.org/show_bug.cgi?id=33314
2585
2586         * Scripts/webkitpy/commands/upload.py:
2587         * Scripts/webkitpy/steps/checkstyle.py:
2588         * Scripts/webkitpy/steps/options.py:
2589
2590 2010-01-07  Adam Barth  <abarth@webkit.org>
2591
2592         Reviewed by Maciej Stachowiak.
2593
2594         Add prepare and post to webkit-patch main help
2595         https://bugs.webkit.org/show_bug.cgi?id=33313
2596
2597         * Scripts/webkitpy/commands/upload.py:
2598
2599 2010-01-07  Eric Seidel  <eric@webkit.org>
2600
2601         Reviewed by Adam Barth.
2602
2603         Add Chromium bots to the list of "core builders" (builders which stop the commit-queue when they turn red)
2604         https://bugs.webkit.org/show_bug.cgi?id=33290
2605
2606         Add the Chromium builders to our list of core builders and test that our regexps work.
2607         I also updated our regexp testing to make sure we cover all known builders at build.webkit.org.
2608
2609         * Scripts/webkitpy/buildbot.py:
2610         * Scripts/webkitpy/buildbot_unittest.py:
2611
2612 2010-01-07  Adam Barth  <abarth@webkit.org>
2613
2614         Reviewed by Eric Seidel.
2615
2616         bugzilla-tool needs a new name
2617         https://bugs.webkit.org/show_bug.cgi?id=28459
2618
2619         Rename bugzilla-tool to webkit-patch.  Also, rename some commands to
2620         make more sense with the new name.
2621
2622         * Scripts/bugzilla-tool: Removed.
2623         * Scripts/webkit-patch: Added.
2624         * Scripts/webkit-tools-completion.sh:
2625         * Scripts/webkitpy/bugzilla_unittest.py:
2626         * Scripts/webkitpy/commands/download.py:
2627         * Scripts/webkitpy/commands/download_unittest.py:
2628         * Scripts/webkitpy/commands/early_warning_system.py:
2629         * Scripts/webkitpy/commands/queries.py:
2630         * Scripts/webkitpy/commands/queues.py:
2631         * Scripts/webkitpy/commands/queues_unittest.py:
2632         * Scripts/webkitpy/commands/upload.py:
2633         * Scripts/webkitpy/commands/upload_unittest.py:
2634         * Scripts/webkitpy/queueengine.py:
2635         * Scripts/webkitpy/steps/completerollout.py:
2636
2637 2010-01-07  Chris Jerdonek  <chris.jerdonek@gmail.com>
2638
2639         Reviewed by Eric Seidel.
2640
2641         Moved style-related modules to webkitpy.style sub-package.
2642
2643         https://bugs.webkit.org/show_bug.cgi?id=32971
2644
2645         * Scripts/check-webkit-style:
2646           - Updated import statement.
2647
2648         * Scripts/test-webkitpy:
2649           - Updated import statements.
2650
2651         * Scripts/webkitpy/cpp_style.py: Removed.
2652           - Moved to webkitpy/style.
2653
2654         * Scripts/webkitpy/cpp_style_unittest.py: Removed.
2655           - Moved to webkitpy/style.
2656
2657         * Scripts/webkitpy/style.py: Removed.
2658           - Moved to webkitpy/style/checker.py.
2659
2660         * Scripts/webkitpy/style/__init__.py: Added.
2661           - Added containing webkitpy directory to package search path.
2662
2663         * Scripts/webkitpy/style/checker.py: Copied from Scripts/webkitpy/style.py.
2664         * Scripts/webkitpy/style/checker_unittest.py: Copied from Scripts/webkitpy/style_unittest.py.
2665           - Updated import statement.
2666
2667         * Scripts/webkitpy/style/cpp_style.py: Copied from Scripts/webkitpy/cpp_style.py.
2668         * Scripts/webkitpy/style/cpp_style_unittest.py: Copied from Scripts/webkitpy/cpp_style_unittest.py.
2669           - Update import statement.
2670
2671         * Scripts/webkitpy/style/text_style.py: Copied from Scripts/webkitpy/text_style.py.
2672         * Scripts/webkitpy/style/text_style_unittest.py: Copied from Scripts/webkitpy/text_style_unittest.py.
2673         * Scripts/webkitpy/style_unittest.py: Removed.
2674           - Moved to webkitpy/style/checker_unittest.py.
2675
2676         * Scripts/webkitpy/text_style.py: Removed.
2677           - Moved to webkitpy/style.
2678
2679         * Scripts/webkitpy/text_style_unittest.py: Removed.
2680           - Moved to webkitpy/style.
2681
2682 2010-01-06  Kinuko Yasuda  <kinuko@chromium.org>
2683
2684         Reviewed by Eric Seidel.
2685
2686         [Qt] Support the 3rd argument of EventSender.keyDown that
2687         has been recently added to report keyLocation
2688         (see also: https://bugs.webkit.org/show_bug.cgi?id=28247).
2689         https://bugs.webkit.org/show_bug.cgi?id=33250
2690
2691         Test: fast/events/keydown-numpad-keys.html
2692
2693         * DumpRenderTree/qt/EventSenderQt.cpp:
2694         (EventSender::keyDown):
2695         * DumpRenderTree/qt/EventSenderQt.h:
2696
2697 2010-01-06  Eric Seidel  <eric@webkit.org>
2698
2699         Reviewed by Adam Barth.
2700
2701         Add long_help for all common commands.
2702         https://bugs.webkit.org/show_bug.cgi?id=33261
2703
2704         For now these long_helps are pretty basic.
2705         These were all written to just explain the steps
2706         that each command runs.  This style long_help could
2707         be made easier by using:
2708         https://bugs.webkit.org/show_bug.cgi?id=33257
2709
2710         * Scripts/webkitpy/commands/download.py:
2711         * Scripts/webkitpy/commands/queries.py:
2712
2713 2010-01-06  Diego Gonzalez  <diego.gonzalez@openbossa.org>
2714
2715         Reviewed by Kenneth Christiansen.
2716
2717         [Qt] Add page zooming support to Qt DumpRenderTree
2718         https://bugs.webkit.org/show_bug.cgi?id=32898
2719
2720         Patch by Kim Grönholm  <kim.gronholm@nomovok.com>,
2721                  Diego Gonzalez <diego.gonzalez@openbossa.org> and
2722                  Afonso Costa <afonso.costa@openbossa.org>
2723
2724         * DumpRenderTree/qt/EventSenderQt.cpp:
2725         (EventSender::zoomPageIn):
2726         (EventSender::zoomPageOut):
2727         * DumpRenderTree/qt/EventSenderQt.h:
2728
2729 2010-01-06  Eric Seidel  <eric@webkit.org>
2730
2731         No review, just adding Mike Belshe's new bugzilla email at his request.
2732
2733         * Scripts/webkitpy/committers.py:
2734
2735 2010-01-06  Eric Seidel  <eric@webkit.org>
2736
2737         Unreviewed.  Rolling out r52869 and r52853 due to bot
2738         and local run-webkit-test failures
2739
2740         REGRESSION(52854?) fast/workers/shared-worker-constructor.html failed on Leopard Build Bot
2741         https://bugs.webkit.org/show_bug.cgi?id=33256
2742
2743         The original bug was https://bugs.webkit.org/show_bug.cgi?id=33153
2744
2745         * Scripts/run-webkit-tests:
2746
2747 2010-01-06  Eric Seidel  <eric@webkit.org>
2748
2749         Unreviewed "build" fix.  Just adding missing include.
2750
2751         bugzilla-tool rollout --complete-rollout should make a nicer bug comment
2752         https://bugs.webkit.org/show_bug.cgi?id=29212
2753
2754         * Scripts/webkitpy/steps/completerollout.py:
2755
2756 2010-01-06  Eric Seidel  <eric@webkit.org>
2757
2758         Reviewed by Adam Barth.
2759
2760         bugzilla-tool rollout --complete-rollout should make a nicer bug comment
2761         https://bugs.webkit.org/show_bug.cgi?id=29212
2762
2763         * Scripts/webkitpy/bugzilla.py:
2764          - Make reopen_bug robust against the bug already being open.
2765         * Scripts/webkitpy/commands/download.py:
2766          - Remove dead code from Rollout.
2767         * Scripts/webkitpy/steps/completerollout.py:
2768          - Improve the rollout comment.
2769
2770 2010-01-06  Andras Becsi  <abecsi@inf.u-szeged.hu>
2771
2772         Reviewed by Darin Adler.
2773
2774         Set isHttpdOpen to 0 if pidfile does not exist for some reason.
2775         Speculative fix for https://bugs.webkit.org/show_bug.cgi?id=33256.
2776
2777         * Scripts/run-webkit-tests:
2778
2779 2010-01-06  Andras Becsi  <abecsi@inf.u-szeged.hu>
2780
2781         Reviewed by Darin Adler.
2782
2783         Change hardcoded /tmp in run-webkit-tests to File::Spec->tmpdir(),
2784         and remove the httpd's pidfile directory if httpd terminated.
2785
2786         * Scripts/run-webkit-tests:
2787
2788 2010-01-05  Chris Jerdonek  <chris.jerdonek@gmail.com>
2789
2790         Reviewed by David Levin.
2791
2792         Refactored check-webkit-style's argument parser to not rely
2793         on global state, and improved its error handling and unit
2794         test coverage.
2795
2796         https://bugs.webkit.org/show_bug.cgi?id=32966
2797
2798         * Scripts/check-webkit-style:
2799           - Adjusted to use new argument parser.
2800
2801         * Scripts/webkitpy/cpp_style.py:
2802           - Changed _CppStyleState to accept an array of filter rules
2803             instead of a comma-delimited string.
2804           - Eliminated cpp_style._DEFAULT_FILTER_RULES.
2805           - Eliminated cpp_style._USAGE.
2806
2807         * Scripts/webkitpy/cpp_style_unittest.py:
2808           - Updated test_filter() and test_default_filter().
2809
2810         * Scripts/webkitpy/style.py:
2811           - Converted style._USAGE to create_usage().
2812           - Corrected usage instructions by removing 0 as a valid
2813             --verbose flag value.
2814           - Removed use_webkit_styles().
2815           - Added ProcessorOptions class.
2816           - Added ArgumentDefaults class.
2817           - Added ArgumentPrinter class.
2818           - Removed parse_arguments and added ArgumentParser class.
2819           - Moved exit_with_usage() and exit_with_categories() into
2820             ArgumentParser.
2821           - Refactored parse_arguments() as ArgumentParser.parse().
2822           - Improved parser error handling.
2823
2824         * Scripts/webkitpy/style_unittest.py:
2825           - Added DefaultArgumentsTest class.
2826           - Addressed FIXME to check style.WEBKIT_FILTER_RULES
2827             against style.STYLE_CATEGORIES.
2828           - Added ArgumentPrinterTest class.
2829           - Added ArgumentParserTest class and rewrote parser unit tests.
2830
2831 2010-01-05  Adam Roben  <aroben@apple.com>
2832
2833         Test that it's safe to call IWebView::close when
2834         IWebView::initWithFrame hasn't been called
2835
2836         Part of <http://webkit.org/b/32827> Crash when calling
2837         IWebView::close, then releasing the WebView, without calling
2838         DestroyWindow
2839
2840         Reviewed by Steve Falkenburg.
2841
2842         * WebKitAPITest/tests/WebViewDestruction.cpp:
2843         (WebKitAPITest::CloseWithoutInitWithFrame): Calls IWebView::close
2844         without ever calling IWebView::initWithFrame and tests that we don't
2845         crash or leak.
2846
2847 2010-01-05  Adam Roben  <aroben@apple.com>
2848
2849         Add more WebViewDestruction tests
2850
2851         Fixes <http://webkit.org/b/33216>.
2852
2853         Reviewed by Eric Seidel.
2854
2855         * WebKitAPITest/tests/WebViewDestruction.cpp:
2856         (WebKitAPITest::NoInitWithFrame):
2857         (WebKitAPITest::CloseThenDestroyViewWindow):
2858         (WebKitAPITest::DestroyViewWindowThenClose):
2859         (WebKitAPITest::DestroyHostWindow):
2860         (WebKitAPITest::DestroyHostWindowThenClose):
2861         (WebKitAPITest::CloseThenDestroyHostWindow):
2862         Added these tests that exercise tearing down a WebView in various
2863         ways, all of which we eventually want to have work. Some of them
2864         currently crash or leak.
2865
2866 2010-01-05  Robert Hogan  <robert@roberthogan.net>
2867
2868         Reviewed by Eric Seidel.
2869
2870         [Qt] fix DRT link failures on --no-svg builds when only making changes to DRT
2871
2872         If you're working from a --minimal or --no-svg build and make changes to the
2873         DRT, then recompile, the build will fail.
2874
2875         This is because the current behavior at build time is to assume that the
2876         previous Qt build supported SVG and consequently delete libQtWebKit.so.
2877         Unfortunately, just deleting libQtWebKit.so will not cause the library to
2878         re-link. Instead the build will see libQtWebKit.so.4 and co., pass over the
2879         linking phase, and attempt to link the DRT with libQtWebKit.so absent. This
2880         results in a link failure on the DRT.
2881
2882         Since re-linking libQtWebKit can take up to ten minutes and should be avoided
2883         in cases where not actually required, remove the assumption that
2884         the previous Qt build supported SVG, and amend the symbol detection to look for
2885         a symbol name that is not present in SVG builds. Currently webkitdirs.pm looks
2886         for 'SVGElement' but even non-SVG builds contain the symbol 'isSVGElement'.
2887
2888         https://bugs.webkit.org/show_bug.cgi?id=32992
2889
2890         * Scripts/webkitdirs.pm:
2891
2892 2010-01-05  Chris Jerdonek  <chris.jerdonek@gmail.com>
2893
2894         Reviewed by David Kilzer.
2895
2896         Switched to generating list of Perl unit test files dynamically,
2897         instead of explicitly.
2898
2899         https://bugs.webkit.org/show_bug.cgi?id=33200
2900
2901         * Scripts/test-webkitperl:
2902
2903 2010-01-05  Yael Aharon  <yael.aharon@nokia.com>
2904
2905         Reviewed by Kenneth Rohde Christiansen.
2906
2907         [Qt] Reimplement EventSender::leapForward
2908         https://bugs.webkit.org/show_bug.cgi?id=33114
2909
2910         Follow Windows implementation of leapForward. When leapForward is called,
2911         messages are queued and posted after the timeout. A new event loop is created to
2912         handle those messages and the additional messages that are created as a result.
2913
2914         * DumpRenderTree/qt/DumpRenderTree.pro:
2915         * DumpRenderTree/qt/EventSenderQt.cpp:
2916         (EventSender::EventSender):
2917         (EventSender::mouseDown):
2918         (EventSender::mouseUp):
2919         (EventSender::mouseMoveTo):
2920         (EventSender::leapForward):
2921         (EventSender::sendOrQueueEvent):
2922         (EventSender::replaySavedEvents):
2923         (EventSender::eventFilter):
2924         * DumpRenderTree/qt/EventSenderQt.h:
2925
2926 2010-01-05  Adam Barth  <abarth@webkit.org>
2927
2928         Reviewed by Darin Adler.
2929
2930         Fix obscure queue crash in queueengine
2931         https://bugs.webkit.org/show_bug.cgi?id=33196
2932
2933         Sometimes we get an exception that can't be stringified.  For example:
2934
2935         AttributeError: 'ParseError' object has no attribute 'msg'
2936
2937         In these cases, the whole queue dies because we're in the global
2938         exception handler.  Instead of dieing here, we should just print a less
2939         informative message to the console.  We're already printing the whole
2940         backtrace anyway, so there's not much point to stringifying the
2941         exception anyway.
2942
2943         * Scripts/webkitpy/queueengine.py:
2944
2945 2010-01-05  Dominic Mazzoni  <dmazzoni@google.com>
2946
2947         Reviewed by Darin Adler.
2948
2949         https://bugs.webkit.org/show_bug.cgi?id=32571
2950
2951         For an object with an aria role of "checkbox" or "radiobutton",
2952         use the "aria-checked" attribute to determine if it's checked.
2953         These changes add an isChecked() method to AccessibilityUIElement
2954         so that we can check for this property from a layout test.
2955
2956         * DumpRenderTree/AccessibilityUIElement.cpp:
2957         (getIsCheckedCallback):
2958         (AccessibilityUIElement::getJSClass):
2959         * DumpRenderTree/AccessibilityUIElement.h:
2960         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2961         (AccessibilityUIElement::isChecked):
2962         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2963         (AccessibilityUIElement::isChecked):
2964         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2965         (AccessibilityUIElement::isChecked):
2966
2967 2010-01-05  David Levin  <levin@chromium.org>
2968
2969         Reviewed by Darin Adler.
2970
2971         Having a comment for the #endif for a header guard is not required WebKit style.
2972         https://bugs.webkit.org/show_bug.cgi?id=33214
2973
2974         * Scripts/webkitpy/cpp_style.py: removed the check and made the loop exit
2975           early when it has all the needed information to continue.
2976         * Scripts/webkitpy/cpp_style_unittest.py: removed the corresponding tests.
2977
2978 2010-01-05  Adam Roben  <aroben@apple.com>
2979
2980         Share more code in the WebViewDestruction tests
2981
2982         Part of <http://webkit.org/b/33212> Small fixes/improvements to
2983         WebKitAPITest
2984
2985         Reviewed by Sam Weinig.
2986
2987         * WebKitAPITest/tests/WebViewDestruction.cpp:
2988         (WebKitAPITest::createAndInitializeWebView): Renamed from
2989         createWebView. Now initializes the HostWindow and returns the
2990         WebView's HWND via an out-parameter.
2991         (WebKitAPITest::finishWebViewDestructionTest): Added. Code came from
2992         the CloseWithoutDestroyWindow test.
2993         (WebKitAPITest::CloseWithoutDestroyViewWindow): Renamed from
2994         CloseWithoutDestroyWindow and changed to use the new functions.
2995         (WebKitAPITest::MainFrameAfterClose): Changed to use the new
2996         functions.
2997         (WebKitAPITest::NoCloseOrDestroyViewWindow): Renamed from
2998         NoCloseOrDestroyWindow and changed to use the new functions.
2999
3000 2010-01-05  Adam Roben  <aroben@apple.com>
3001
3002         Don't show HostWindows by default
3003
3004         This was making WebKitAPITest very flashy as windows appeared and
3005         disappeared.
3006
3007         Part of <http://webkit.org/b/33212> Small fixes/improvements to
3008         WebKitAPITest
3009
3010         Reviewed by Sam Weinig.
3011
3012         * WebKitAPITest/HostWindow.cpp:
3013         (WebKitAPITest::HostWindow::initialize): Removed the WS_VISIBLE style
3014         from the window.
3015
3016 2010-01-05  Adam Roben  <aroben@apple.com>
3017
3018         Don't hang in WebKitAPITest if no messages have been posted
3019
3020         Part of <http://webkit.org/b/33212> Small fixes/improvements to
3021         WebKitAPITest
3022
3023         Reviewed by Sam Weinig.
3024
3025         * WebKitAPITest/tests/WebViewDestruction.cpp:
3026         (WebKitAPITest::runMessagePump): Use PeekMessage instead of GetMessage
3027         to avoid hanging if no messages have been posted.
3028
3029 2010-01-05  Adam Roben  <aroben@apple.com>
3030
3031         Fix WebKitCreateInstance helper
3032
3033         Part of <http://webkit.org/b/33212> Small fixes/improvements to
3034         WebKitAPITest
3035
3036         Reviewed by Sam Weinig.
3037
3038         * WebKitAPITest/tests/WebViewDestruction.cpp:
3039         (WebKitAPITest::WebKitCreateInstance): Pass the pointer straight
3040         through, instead of taking its address.
3041
3042 2010-01-04  Maciej Stachowiak  <mjs@apple.com>
3043
3044         Reviewed by Darin Fisher.
3045
3046         Reorganize, document and rename OS() platform macros.
3047         https://bugs.webkit.org/show_bug.cgi?id=33198
3048
3049         Adapt to name changes.
3050
3051         * DumpRenderTree/DumpRenderTree.h:
3052         * DumpRenderTree/config.h:
3053
3054 2010-01-05  Chris Jerdonek  <chris.jerdonek@gmail.com>
3055
3056         Reviewed by Eric Seidel.
3057
3058         Minor improvements to test-webkit-scripts, as suggested
3059         by an earlier review.
3060
3061         https://bugs.webkit.org/show_bug.cgi?id=33125
3062
3063         * Scripts/test-webkit-scripts:
3064           - Used OptionParser class instead of getopt.getopt().
3065           - Created main() method for __main__ block.
3066           - Enclosed functions in a class.
3067
3068 2010-01-05  Chris Fleizach  <cfleizach@apple.com>
3069
3070         No review. Fix DRT breakage on Tiger/Leopard.
3071
3072         Add ARIA "Live Region" support
3073         https://bugs.webkit.org/show_bug.cgi?id=33117
3074
3075         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3076
3077 2010-01-04  Chris Fleizach  <cfleizach@apple.com>
3078
3079         Reviewed by Darin Adler.
3080
3081         Add ARIA "Live Region" support
3082         https://bugs.webkit.org/show_bug.cgi?id=33117
3083
3084         * DumpRenderTree/AccessibilityUIElement.cpp:
3085         (indexOfChildCallback):
3086         (boolAttributeValueCallback):
3087         (stringAttributeValueCallback):
3088         (addNotificationListenerCallback):
3089         (AccessibilityUIElement::getJSClass):
3090         * DumpRenderTree/AccessibilityUIElement.h:
3091         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3092         (AccessibilityUIElement::indexOfChild):
3093         (AccessibilityUIElement::stringAttributeValue):
3094         (AccessibilityUIElement::boolAttributeValue):
3095         (AccessibilityUIElement::addNotificationListener):
3096         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3097         (AccessibilityUIElement::indexOfChild):
3098         (AccessibilityUIElement::stringAttributeValue):
3099         (AccessibilityUIElement::boolAttributeValue):
3100         (_accessibilityNotificationCallback):
3101         (AccessibilityUIElement::addNotificationListener):
3102         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3103         (AccessibilityUIElement::indexOfChild):
3104         (AccessibilityUIElement::stringAttributeValue):
3105         (AccessibilityUIElement::boolAttributeValue):
3106         (AccessibilityUIElement::addNotificationListener):
3107
3108 2010-01-04  Eric Seidel  <eric@webkit.org>
3109
3110         Reviewed by Adam Barth.
3111
3112         bugzilla-tool rollout should require a reason
3113         https://bugs.webkit.org/show_bug.cgi?id=30810
3114
3115         * Scripts/webkitpy/changelogs.py: Add support for a reason, add auto-wrapping logic.
3116         * Scripts/webkitpy/changelogs_unittest.py: Test reason support.
3117         * Scripts/webkitpy/commands/download.py: rollout now requires a reason, remove unused BUGID argument
3118         * Scripts/webkitpy/commands/download_unittest.py: pass required reason
3119         * Scripts/webkitpy/steps/preparechangelogforrevert.py: pass reason to update_for_revert
3120
3121 2010-01-04  Jon Honeycutt  <jhoneycutt@apple.com>
3122
3123         MSAA: <select> elements should broadcast value change events
3124
3125         https://bugs.webkit.org/show_bug.cgi?id=33088
3126
3127         <rdar://problem/7332364>
3128
3129         Reviewed by Darin Adler.
3130
3131         * DumpRenderTree/AccessibilityController.cpp:
3132         (logValueChangeEventsCallback):
3133         Start logging value change events.
3134         (AccessibilityController::getJSClass):
3135         Add a "logValueChangeEvents" to the AccessibilityController's JS class
3136         definition.
3137         (AccessibilityController::resetToConsistentState):
3138         Disable logging of value change events.
3139
3140         * DumpRenderTree/AccessibilityController.h:
3141         Declare setLogValueChangeEvents(), and add a member variable for the
3142         value change event hook.
3143
3144         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3145         (AccessibilityController::setLogValueChangeEvents):
3146         Stubbed.
3147
3148         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3149         (AccessibilityController::setLogValueChangeEvents):
3150         Stubbed.
3151
3152         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3153         (AccessibilityController::AccessibilityController):
3154         Initialize new member var.
3155         (AccessibilityController::~AccessibilityController):
3156         Disable logging of value change events.
3157         (logEventProc):
3158         When we receive an EVENT_OBJECT_VALUECHANGE, log the name of the object
3159         and its value.
3160         (AccessibilityController::setLogValueChangeEvents):
3161         If disabling logging, unhook the event, and clear the event hook
3162         member var. Otherwise, query for the root element to enable
3163         accessibility, and hook EVENT_OBJECT_VALUECHANGE.
3164
3165 2010-01-04  Adam Barth  <abarth@webkit.org>
3166
3167         Reviewed by Eric Seidel.
3168
3169         long_help for submit-patch
3170         https://bugs.webkit.org/show_bug.cgi?id=33184
3171
3172         * Scripts/webkitpy/commands/upload.py:
3173
3174 2010-01-04  Adam Barth  <abarth@webkit.org>
3175
3176         Reviewed by Eric Seidel.
3177
3178         commit-queue can wrongly reject patches if the buildbots are behind
3179         https://bugs.webkit.org/show_bug.cgi?id=30098
3180
3181         Check to make sure we can currently build and test before trying to
3182         land a patch.
3183
3184         * Scripts/webkitpy/commands/queues.py:
3185
3186 2010-01-04  Adam Roben  <aroben@apple.com>
3187
3188         Add a test harness for the Windows WebKit API, and a few tests
3189
3190         We currently only have tests for a handful of bugs regarding WebView
3191         destruction, but more tests can easily be added later. Eventually
3192         we'll run these tests as part of run-webkit-tests.
3193
3194         Fixes <http://webkit.org/b/33167>.
3195
3196         Reviewed by Sam Weinig.
3197
3198         * WebKitAPITest/HostWindow.cpp: Added.
3199         (WebKitAPITest::HostWindow::HostWindow): Initialize m_window.
3200         (WebKitAPITest::HostWindow::~HostWindow): Destroy our window if
3201         needed.
3202         (WebKitAPITest::HostWindow::initialize): Create our window.
3203         (WebKitAPITest::HostWindow::clientRect): Return our window's client
3204         rect.
3205         (WebKitAPITest::HostWindow::registerWindowClass): Does what it says.
3206         (WebKitAPITest::HostWindow::wndProc): Just call through to
3207         DefWindowProcW.
3208
3209         * WebKitAPITest/HostWindow.h: Added.
3210         (WebKitAPITest::HostWindow::window): Simple getter.
3211
3212         * WebKitAPITest/Test.h: Added. This file defines some macros useful
3213         for writing tests.
3214
3215         * WebKitAPITest/TestsController.cpp: Added.
3216         (WebKitAPITest::TestsController::TestsController): Initialize our
3217         members.
3218         (WebKitAPITest::TestsController::shared): Return the shared instance.
3219         (WebKitAPITest::TestsController::runAllTests): Run a message pump
3220         until a WM_QUIT message is received, then return whether all tests
3221         succeeded.
3222         (WebKitAPITest::TestsController::addTest): Add the test to m_tests and
3223         start running tests soon.
3224         (WebKitAPITest::TestsController::testFailed): Record the failure and
3225         print a message about it to stdout.
3226         (WebKitAPITest::TestsController::runNextTest): If we don't have any
3227         tests to run, post a WM_QUIT message to stop the message pump.
3228         Otherwise, run the test and print whether it passed, then schedule the
3229         next test.
3230         (WebKitAPITest::TestsController::runNextTestSoon): Set a 0-delay timer
3231         to run the next test.
3232         (WebKitAPITest::TestsController::registerWindowClass): Does what it
3233         says.
3234         (WebKitAPITest::TestsController::wndProc): If the runNextTestTimer
3235         fired, call runNextTest(). Pass everything else through to
3236         DefWindowProcW.
3237
3238         * WebKitAPITest/TestsController.h: Added.
3239
3240         * WebKitAPITest/WebKitAPITest.vcproj: Added.
3241
3242         * WebKitAPITest/WebKitAPITestCommon.vsprops: Added.
3243
3244         * WebKitAPITest/main.cpp: Added.
3245         (main): (Mostly) just calls TestsController::runAllTests.
3246
3247         * WebKitAPITest/tests/WebViewDestruction.cpp: Added.
3248         (WebKitAPITest::WebKitCreateInstance): Helper function template to
3249         call through to the real WebKitCreateInstance.
3250         (WebKitAPITest::webViewCount): Helper function to call through to
3251         IWebKitStatistics::webViewCount.
3252         (WebKitAPITest::createWebView): Helper function to create a WebView
3253         and put it inside a HostWindow.
3254         (WebKitAPITest::runMessagePump): Helper function to run a message pump
3255         for a specified number of milliseconds, or until a WM_QUIT message is
3256         received.
3257         (WebKitAPITest::CloseWithoutDestroyWindow): Test for
3258         <http://webkit.org/b/32827>.
3259         (WebKitAPITest::MainFrameAfterClose): Test for
3260         <http://webkit.org/b/32868>.
3261         (WebKitAPITest::NoCloseOrDestroyWindow): Test for
3262         <http://webkit.org/b/33162>.
3263
3264 2010-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3265
3266         Reviewed by David Kilzer.
3267
3268         Add support for Git's "diff.mnemonicprefix" config option to WebKitTools
3269
3270         https://bugs.webkit.org/show_bug.cgi?id=32820
3271
3272         * Scripts/VCSUtils.pm:
3273         * Scripts/svn-apply:
3274         * Scripts/svn-unapply:
3275         * Scripts/test-webkitperl: Run gitdiff2svndiff test
3276         * Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl: Added.
3277         * Scripts/webkitpy/diff_parser.py:
3278         * Scripts/webkitpy/diff_parser_unittest.py:
3279
3280 2010-01-04  Chris Jerdonek  <chris.jerdonek@gmail.com>
3281
3282         Reviewed by David Kilzer.
3283
3284         Divided the Perl unit tests into separate files and put
3285         them in a separate directory, and renamed test-webkit-perl
3286         to test-webkitperl.
3287
3288         https://bugs.webkit.org/show_bug.cgi?id=33124
3289
3290         * Scripts/VCSUtils.pm:
3291           - Renamed generateRunPatchCommand() to generatePatchCommand().
3292
3293         * Scripts/VCSUtils_unittest.pl: Removed.
3294           - Divided into three files in Scripts/webkitperl/VCSUtils_unittest.
3295
3296         * Scripts/test-webkit-perl: Removed.
3297           - Renamed to test-webkitperl.
3298
3299         * Scripts/test-webkit-scripts:
3300           - Updated paths to test-webkitpy and test-webkitperl.
3301
3302         * Scripts/test-webkitperl: Copied from Scripts/test-webkit-perl.
3303           - Added paths to new test files.
3304
3305         * Scripts/webkitperl: Added.
3306         * Scripts/webkitperl/VCSUtils_unittest: Added.
3307         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl: Added.
3308         * Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl: Added.
3309         * Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl: Copied from Scripts/VCSUtils_unittest.pl.
3310
3311 2010-01-04  Eric Seidel  <eric@webkit.org>
3312
3313         Reviewed by Adam Barth.
3314
3315         Make bugzilla-tool rollout include a bug link in the ChangeLog entry
3316         https://bugs.webkit.org/show_bug.cgi?id=33146
3317
3318         One more step towards better rollouts.
3319
3320         * Scripts/webkitpy/changelogs.py:
3321         * Scripts/webkitpy/changelogs_unittest.py:
3322         * Scripts/webkitpy/steps/preparechangelogforrevert.py:
3323
3324 2010-01-04  Adam Barth  <abarth@webkit.org>
3325
3326         Reviewed by Eric Seidel.
3327
3328         Sort the step options
3329         https://bugs.webkit.org/show_bug.cgi?id=33144
3330
3331         * Scripts/webkitpy/steps/options.py:
3332
3333 2010-01-04  Eric Seidel  <eric@webkit.org>
3334
3335         Reviewed by Adam Barth.
3336
3337         Need support for longer text in per-command help
3338         https://bugs.webkit.org/show_bug.cgi?id=33143
3339
3340         Add some minimal additional help to land-diff and
3341         pave the way for adding better help to all commands.
3342
3343         * Scripts/webkitpy/commands/download.py: Add small amount of additional help to land-diff
3344         * Scripts/webkitpy/multicommandtool.py: support long_help
3345         * Scripts/webkitpy/multicommandtool_unittest.py: test long_help
3346
3347 2010-01-04  Adam Barth  <abarth@webkit.org>
3348
3349         Reviewed by Eric Seidel.
3350
3351         Add unit test for MarkBugFixed
3352         https://bugs.webkit.org/show_bug.cgi?id=33142
3353
3354         MarkBugFixed is way behind in command technology, but it still needs a
3355         unit test, as the FIXME commands.
3356
3357         Also, remove mark-bug-fixed and create-bug from main help since we have
3358         more modern commands to replace them.
3359
3360         * Scripts/webkitpy/commands/upload.py:
3361         * Scripts/webkitpy/commands/upload_unittest.py:
3362         * Scripts/webkitpy/mock_bugzillatool.py:
3363
3364 2010-01-04  Adam Barth  <abarth@webkit.org>
3365
3366         Reviewed by Eric Seidel.
3367
3368         Add missing unit test for CommitMessageForCurrentDiff
3369         https://bugs.webkit.org/show_bug.cgi?id=33141
3370
3371         * Scripts/webkitpy/commands/upload.py:
3372         * Scripts/webkitpy/commands/upload_unittest.py:
3373
3374 2010-01-04  Adam Barth  <abarth@webkit.org>
3375
3376         Reviewed by Eric Seidel.
3377
3378         Remove raw_input from queues in favor of user.prompt
3379         https://bugs.webkit.org/show_bug.cgi?id=33140
3380
3381         This lets up properly mock out the user interaction instead of hacking
3382         around it with the options.
3383
3384         * Scripts/webkitpy/commands/queues.py:
3385         * Scripts/webkitpy/commands/queuestest.py:
3386
3387 2010-01-04  Eric Seidel  <eric@webkit.org>
3388
3389         Reviewed by Adam Barth.
3390
3391         bugzilla-tool should not require users to install mechanize
3392         https://bugs.webkit.org/show_bug.cgi?id=32635
3393
3394         * Scripts/webkitpy/__init__.py: Add missing declaration for ClientForm (which mechanize requires).
3395
3396 2010-01-04  Eric Seidel  <eric@webkit.org>
3397
3398         Reviewed by Adam Barth.
3399
3400         bugzilla-tool should not require users to install mechanize
3401         https://bugs.webkit.org/show_bug.cgi?id=32635
3402
3403         Use the nifty "autoinstall" module from Daniel Krech:
3404         http://pypi.python.org/pypi/autoinstall/0.2
3405         http://code.google.com/p/pyautoinstall/
3406         It's available under a WebKit-compatible BSD license.
3407
3408         * Scripts/webkitpy/__init__.py:
3409          - bind "mechanize" to an autoinstall importer which will
3410            auto-download mechanize if necessary.
3411         * Scripts/webkitpy/autoinstall.py: Added.
3412         * Scripts/webkitpy/bugzilla.py: use "mechanize" instead of webkit_mechanize
3413         * Scripts/webkitpy/statusbot.py: ditto.
3414         * Scripts/webkitpy/webkit_mechanize.py: Removed.
3415
3416 2010-01-04  Adam Barth  <abarth@webkit.org>
3417
3418         Reviewed by Eric Seidel.
3419
3420         [bzt] Move AbstractSequencedCommand to a more general location
3421         https://bugs.webkit.org/show_bug.cgi?id=33137
3422
3423         I do what the FIXME tell me to do.
3424
3425         * Scripts/webkitpy/commands/abstractsequencedcommand.py: Added.
3426         * Scripts/webkitpy/commands/download.py:
3427         * Scripts/webkitpy/commands/upload.py:
3428
3429 2010-01-04  Adam Barth  <abarth@webkit.org>
3430
3431         Reviewed by Eric Seidel.
3432
3433         Rename StatusBot to StatusServer
3434         https://bugs.webkit.org/show_bug.cgi?id=33139
3435
3436         It's not a bot.  It's a server.
3437
3438         * Scripts/bugzilla-tool:
3439         * Scripts/webkitpy/bugzilla.py:
3440         * Scripts/webkitpy/commands/early_warning_system.py:
3441         * Scripts/webkitpy/commands/queues.py:
3442         * Scripts/webkitpy/mock_bugzillatool.py:
3443         * Scripts/webkitpy/queueengine.py:
3444         * Scripts/webkitpy/statusbot.py: Removed.
3445
3446 2010-01-04  Adam Barth  <abarth@webkit.org>
3447
3448         Reviewed by Eric Seidel.
3449
3450         [bzt] submit-pach should have a -o/--open option to open the bug after submit
3451         https://bugs.webkit.org/show_bug.cgi?id=33136
3452
3453         Python makes this very easy.
3454
3455         * Scripts/webkitpy/mock_bugzillatool.py:
3456         * Scripts/webkitpy/steps/options.py:
3457         * Scripts/webkitpy/steps/postdiff.py:
3458         * Scripts/webkitpy/user.py:
3459
3460 2010-01-04  Adam Barth  <abarth@webkit.org>
3461
3462         Reviewed by Eric Seidel.
3463
3464         [bzt] Move steps to a submodule
3465         https://bugs.webkit.org/show_bug.cgi?id=33135
3466
3467         For great victory.  This will probably introduce some regressions
3468         because our test coverage isn't perfect, but I've tried to be careful.
3469
3470         * Scripts/test-webkitpy:
3471         * Scripts/webkitpy/buildsteps.py: Removed.
3472         * Scripts/webkitpy/buildsteps_unittest.py: Removed.
3473         * Scripts/webkitpy/commands/download.py:
3474         * Scripts/webkitpy/commands/upload.py:
3475         * Scripts/webkitpy/steps/__init__.py: Added.
3476         * Scripts/webkitpy/steps/abstractstep.py: Added.
3477         * Scripts/webkitpy/steps/applypatch.py: Added.
3478         * Scripts/webkitpy/steps/applypatchwithlocalcommit.py: Added.
3479         * Scripts/webkitpy/steps/build.py: Added.
3480         * Scripts/webkitpy/steps/checkstyle.py: Added.
3481         * Scripts/webkitpy/steps/cleanworkingdirectory.py: Added.
3482         * Scripts/webkitpy/steps/cleanworkingdirectorywithlocalcommits.py: Added.
3483         * Scripts/webkitpy/steps/closebug.py: Added.
3484         * Scripts/webkitpy/steps/closebugforlanddiff.py: Added.
3485         * Scripts/webkitpy/steps/closepatch.py: Added.
3486         * Scripts/webkitpy/steps/commit.py: Added.
3487         * Scripts/webkitpy/steps/completerollout.py: Added.
3488         * Scripts/webkitpy/steps/confirmdiff.py: Added.
3489         * Scripts/webkitpy/steps/createbug.py: Added.
3490         * Scripts/webkitpy/steps/editchangelog.py: Added.
3491         * Scripts/webkitpy/steps/ensurebuildersaregreen.py: Added.
3492         * Scripts/webkitpy/steps/ensurelocalcommitifneeded.py: Added.
3493         * Scripts/webkitpy/steps/metastep.py: Added.
3494         * Scripts/webkitpy/steps/obsoletepatches.py: Added.
3495         * Scripts/webkitpy/steps/options.py: Added.
3496         * Scripts/webkitpy/steps/postdiff.py: Added.
3497         * Scripts/webkitpy/steps/preparechangelog.py: Added.
3498         * Scripts/webkitpy/steps/preparechangelogforrevert.py: Added.
3499         * Scripts/webkitpy/steps/promptforbugortitle.py: Added.
3500         * Scripts/webkitpy/steps/revertrevision.py: Added.
3501         * Scripts/webkitpy/steps/runtests.py: Added.
3502         * Scripts/webkitpy/steps/steps_unittest.py: Added.
3503         * Scripts/webkitpy/steps/update.py: Added.
3504         * Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py: Added.
3505         * Scripts/webkitpy/steps/updatechangelogswithreviewer.py: Added.
3506         * Scripts/webkitpy/stepsequence.py:
3507
3508 2010-01-04  Daniel Bates  <dbates@webkit.org>
3509
3510         Reviewed by Eric Seidel.
3511
3512         https://bugs.webkit.org/show_bug.cgi?id=33097
3513
3514         Cleans up the File menu to better conform to the File menu in Safari
3515         both in terms of options and keyboard shortcuts. Adds a "Quit" menu
3516         options to close all open windows. Also, renames the Tools menu to
3517         Develop.
3518
3519         * QtLauncher/main.cpp:
3520         (MainWindow::setupUI):
3521
3522 2010-01-04  Daniel Bates  <dbates@webkit.org>
3523
3524         https://bugs.webkit.org/show_bug.cgi?id=33039
3525
3526         Unreviewed fix.
3527
3528         * Scripts/webkitpy/credentials.py:
3529         * Scripts/webkitpy/credentials_unittest.py:
3530
3531 2010-01-04  Daniel Bates  <dbates@webkit.org>
3532
3533         Reviewed by Eric Seidel.
3534
3535         https://bugs.webkit.org/show_bug.cgi?id=33039
3536
3537         [bzt] Second attempt to fix an issue where bugzilla-tool dies
3538         when the keychain lookup fails to find an entry for bugs.webkit.org.
3539
3540         * Scripts/webkitpy/credentials.py:
3541         * Scripts/webkitpy/credentials_unittest.py:
3542
3543 2010-01-04  Eric Seidel  <eric@webkit.org>
3544
3545         Reviewed by Adam Barth.
3546
3547         Make Rollout an AbstractSequencedCommmand
3548         https://bugs.webkit.org/show_bug.cgi?id=33133
3549
3550         As suggested by Adam in:
3551         https://bugs.webkit.org/show_bug.cgi?id=33131#c2
3552
3553         * Scripts/webkitpy/commands/download.py:
3554
3555 2010-01-04  Eric Seidel  <eric@webkit.org>
3556
3557         Reviewed by Adam Barth.
3558
3559         Make all commands AbstractDeclarativeCommmands instead of direct Command subclasses
3560         https://bugs.webkit.org/show_bug.cgi?id=33131
3561
3562         Evenetually we'll probably roll AbstractDeclarativeCommmand directly into Command
3563         but for now we just deploy it everywhere and don't try to fix up the few valid uses
3564         of Command.
3565
3566         * Scripts/webkitpy/commands/download.py:
3567         * Scripts/webkitpy/commands/queries.py:
3568         * Scripts/webkitpy/commands/upload.py:
3569         * Scripts/webkitpy/multicommandtool.py:
3570
3571 2010-01-03  Adam Barth  <abarth@webkit.org>
3572
3573         Unreviewed "build" fix.  Need to import ScriptError.
3574
3575         * Scripts/webkitpy/buildsteps.py:
3576
3577 2010-01-03  Adam Barth  <abarth@webkit.org>
3578
3579         Reviewed by Eric Seidel.
3580
3581         [bzt] Make it easier to run submit-patch when previous run cancelled
3582         https://bugs.webkit.org/show_bug.cgi?id=33070
3583
3584         This patch renames create-review to submit-patch (as requested by
3585         Maciej).
3586
3587         This patch makes it easier to run submit-patch after the user has
3588         already cancelled a previous run of submit-patch by detecting when we
3589         already have ChangeLogs and reading the bug number from them (and not
3590         attempting to recreate them).  Aside from performance and the extra
3591         edit step, this command should not subsume post-dif.
3592
3593         Also, added a --email command line argument so that the output of
3594         prepare-ChangeLog makes sense when it can't find the user's email
3595         address.
3596
3597         * Scripts/webkitpy/bugzilla.py:
3598         * Scripts/webkitpy/buildsteps.py:
3599         * Scripts/webkitpy/commands/upload.py:
3600         * Scripts/webkitpy/commands/upload_unittest.py:
3601         * Scripts/webkitpy/mock_bugzillatool.py:
3602         * Scripts/webkitpy/user.py:
3603
3604 2010-01-03  Eric Seidel  <eric@webkit.org>
3605
3606         Reviewed by Adam Barth.
3607
3608         Rename Scripts/modules to Scripts/webkitpy
3609         https://bugs.webkit.org/show_bug.cgi?id=33128
3610
3611         Just search-replace and svn mv commands.
3612
3613         * Scripts/bugzilla-tool:
3614         * Scripts/check-webkit-style:
3615         * Scripts/modules: Removed.
3616         * Scripts/modules/BeautifulSoup.py: Removed.
3617         * Scripts/modules/__init__.py: Removed.
3618         * Scripts/modules/bugzilla.py: Removed.
3619         * Scripts/modules/bugzilla_unittest.py: Removed.
3620         * Scripts/modules/buildbot.py: Removed.