b28db9e563b3b20eb7329666c65b0b3aea37390b
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-10-13  Eric Seidel  <eric@webkit.org>
2
3         Reviewed by Adam Barth.
4
5         beat diff_parser with the ugly stick
6         https://bugs.webkit.org/show_bug.cgi?id=47626
7
8         * Scripts/webkitpy/common/checkout/diff_parser.py:
9         * Scripts/webkitpy/style/patchreader.py:
10         * Scripts/webkitpy/style/patchreader_unittest.py:
11
12 2010-10-13  Eric Seidel  <eric@webkit.org>
13
14         Reviewed by Adam Barth.
15
16         Break LayoutTestResults out into its own file
17         https://bugs.webkit.org/show_bug.cgi?id=47637
18
19         * Scripts/webkitpy/common/net/buildbot.py:
20         * Scripts/webkitpy/common/net/buildbot_unittest.py:
21         * Scripts/webkitpy/common/net/layouttestresults.py: Added.
22         * Scripts/webkitpy/common/net/layouttestresults_unittest.py: Added.
23
24 2010-10-13  Adam Barth  <abarth@webkit.org>
25
26         Unreviewed.
27
28         Chromium port can't run JavaScriptCore tests
29         https://bugs.webkit.org/show_bug.cgi?id=47654
30
31         This lets webkit-patch build-and-test work on Chromium.
32
33         * Scripts/webkitpy/common/config/ports.py:
34         * Scripts/webkitpy/tool/steps/runtests.py:
35
36 2010-10-13  Adam Barth  <abarth@webkit.org>
37
38         Reviewed by Eric Seidel.
39
40         Make --port a global option and pass the port information to the commit-queue subprocess
41         https://bugs.webkit.org/show_bug.cgi?id=47650
42
43         This patch paves the way to run the commit-queue on a non-Mac port.
44
45         * Scripts/webkitpy/tool/commands/queues.py:
46         * Scripts/webkitpy/tool/commands/queues_unittest.py:
47         * Scripts/webkitpy/tool/commands/queuestest.py:
48         * Scripts/webkitpy/tool/main.py:
49         * Scripts/webkitpy/tool/steps/options.py:
50         * Scripts/webkitpy/tool/steps/preparechangelog.py:
51         * Scripts/webkitpy/tool/steps/runtests.py:
52         * Scripts/webkitpy/tool/steps/update.py:
53
54 2010-10-13  Adam Barth  <abarth@webkit.org>
55
56         Reviewed by Eric Seidel.
57
58         Introduce the ChromiumXVFBPort for running commit-queue on EC2
59         https://bugs.webkit.org/show_bug.cgi?id=47653
60
61         I'm not entirely sure this is the best way to do this, but we need to
62         run the tests under XVFB on EC2 because the EC2 instances don't have a
63         real monitor hooked up.  This patch adds a ChromiumXVFBPort that runs
64         that way.  The idea is that XVFB is like a platform for the Chromium
65         port, but we don't have a real notion of platform separate from port.
66
67         * Scripts/webkitpy/common/config/ports.py:
68
69 2010-10-13  Sergio Villar Senin  <svillar@igalia.com>
70
71         Reviewed by Martin Robinson.
72
73         [GTK] Add HTTP caching support
74         https://bugs.webkit.org/show_bug.cgi?id=44261
75
76         Add include paths for the new soup HTTP cache code.
77
78         * GNUmakefile.am: Add paths for the new soup HTTP cache code.
79
80 2010-10-13  Yi Shen  <yi.4.shen@nokia.com>
81
82         Reviewed by Antonio Gomes.
83
84         [Qt] QtTestBrowser shows two Url input fields
85         https://bugs.webkit.org/show_bug.cgi?id=47613
86
87         * QtTestBrowser/mainwindow.cpp:
88         (MainWindow::MainWindow):
89         (MainWindow::buildUI):
90
91 2010-10-13  Yi Shen  <yi.4.shen@nokia.com>
92
93         Reviewed by Tony Chang.
94
95         [gdb] Add pretty-print supports for UString, Identifier and JSString
96         https://bugs.webkit.org/show_bug.cgi?id=47601
97
98         * gdb/webkit.py:
99
100 2010-10-13  Adam Barth  <abarth@webkit.org>
101
102         Reviewed by Eric Seidel.
103
104         Add list of Ubuntu packages needed by the EWS bots
105         https://bugs.webkit.org/show_bug.cgi?id=47628
106
107         I've been copy/pasting this list between bots, but it's better to have
108         this checked in.
109
110         * EWSTools/ubuntu-ews-packages: Added.
111
112 2010-10-13  Leandro Pereira  <leandro@profusion.mobi>
113
114         Reviewed by Csaba Osztrogonác.
115
116         [EFL] Adds a build slave.
117         https://bugs.webkit.org/show_bug.cgi?id=47290
118
119         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
120         entry for a release build of the EFL port.
121         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
122         flag to build the EFL port.
123
124 2010-10-13  Adam Barth  <abarth@webkit.org>
125
126         Reviewed by Csaba Osztrogonác.
127
128         webkit-patch build shouldn't need --build to actually build!
129         https://bugs.webkit.org/show_bug.cgi?id=47438
130
131         Yeah, requiring --build for the build command is really dumb.  We did
132         this originally because the build step is usually optional in other
133         commands.  We don't have a good way of reversing the default for an
134         option in one command.  This approach is slightly hacky since --build
135         still shows up as an option on the help page, but at least it makes
136         progress.  Passing --build is harmless, so the EWS bots shouldn't
137         explode because of this change.
138
139         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
140         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
141         * Scripts/webkitpy/tool/commands/download.py:
142         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
143         * Scripts/webkitpy/tool/commands/queues_unittest.py:
144
145 2010-10-13  Sheriff Bot  <webkit.review.bot@gmail.com>
146
147         Unreviewed, rolling out r69638.
148         http://trac.webkit.org/changeset/69638
149         https://bugs.webkit.org/show_bug.cgi?id=47595
150
151         "Broke win and chromium-win bots" (Requested by dglazkov on
152         #webkit).
153
154         * Scripts/webkitpy/common/system/path.py:
155         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
156         * Scripts/webkitpy/layout_tests/port/base.py:
157         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
158         * Scripts/webkitpy/layout_tests/port/chromium.py:
159         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
160
161 2010-10-13  John Knottenbelt  <jknotten@chromium.org>
162
163         Reviewed by Steve Block.
164
165         First step towards client-based Geolocation in Chromium. Build
166         fixes for CLIENT_BASED_GEOLOCATION preprocessor feature define.
167         https://bugs.webkit.org/show_bug.cgi?id=47586
168
169         * DumpRenderTree/chromium/WebViewHost.cpp:
170         * DumpRenderTree/chromium/WebViewHost.h:
171
172 2010-10-13  Adam Roben  <aroben@apple.com>
173
174         Test that pressing the spacebar in a text field does not scroll the
175         document
176
177         Test for <http://webkit.org/b/47544> <rdar://problem/8540645>
178         REGRESSION: Pressing spacebar in a text field in WebKit2 does not
179         insert a space, scrolls the page instead
180
181         Reviewed by Sam Weinig.
182
183         * TestWebKitAPI/PlatformUtilities.h: Added isKeyDown.
184
185         * TestWebKitAPI/PlatformWebView.h: Added simulateSpacebarKeyPress.
186
187         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
188         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
189         * TestWebKitAPI/win/copy-resources.cmd:
190         Added new files.
191
192         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: Added.
193         (TestWebKitAPI::JavaScriptCallbackContext::JavaScriptCallbackContext):
194         We use this to track what the result of calling into JavaScript was.
195         (TestWebKitAPI::didFinishLoadForFrame): Records when the page
196         finishes loading.
197         (TestWebKitAPI::didNotHandleKeyEventCallback): Records when a key down
198         event is not handled.
199         (TestWebKitAPI::javaScriptCallback): Records that JavaScript finished
200         executing and whether the result matched our expectation.
201         (TestWebKitAPI::wk): Turns a UTF-8 C string into a WKStringRef.
202         (TestWebKitAPI::runJSTest): Calls into JS, waits for the call to
203         complete, and returns whether we got back the expected result.
204         (TestWebKitAPI::WebKit2_SpacebarScrolling): Tests that pressing
205         spacebar inside a text field does not scroll the document and that
206         pressing it outside the text field does scroll the document.
207
208         * TestWebKitAPI/Tests/WebKit2/spacebar-scrolling.html: Added.
209
210         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
211         (TestWebKitAPI::Util::isKeyDown): Checks the event's type.
212
213         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
214         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Copied
215         code from DRT's EventSendingController.
216
217         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
218         (TestWebKitAPI::Util::isKeyDown): Checks the message's type.
219
220         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
221         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Send the
222         same messages that get sent when you press spacebar in Notepad.
223
224 2010-10-13  Adam Roben  <aroben@apple.com>
225
226         Fix a couple of issues with the TestWebKitAPI build
227
228         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops:
229         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops:
230         Fixed a typo.
231
232         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Use common.vsprops
233         to set our output and intermediate directories so that we don't spew
234         files into the source tree.
235
236 2010-10-13  Balazs Kelemen  <kbalazs@webkit.org>
237
238         Reviewed by Csaba Osztrogonác.
239
240         WTR should accept relative paths
241         https://bugs.webkit.org/show_bug.cgi?id=47486
242
243         * WebKitTestRunner/StringFunctions.h:
244         * WebKitTestRunner/TestInvocation.cpp:
245         (WTR::createWKURL): Moved from StringFunctions.h since it is
246         used only here. Extend relative paths to absolute.
247
248 2010-10-12  Adam Roben  <aroben@apple.com>
249
250         Make TestWebKitAPI work on Windows
251
252         Fixes <http://webkit.org/b/47552> <rdar://problem/8541708>.
253
254         Reviewed by Sam Weinig.
255
256         * Scripts/build-api-tests: Build TestWebKitAPI.sln on Windows.
257
258         * Scripts/run-api-tests: Fix the PATH so that TestWebKitAPI can be
259         run on Windows.
260         (runTest): Added code to run TestWebKitAPI.exe on Windows and to die
261         on unsupported platforms.
262         (populateTests): Added code to run TestWebKitAPI.exe on Windows and to
263         die on other platforms. Extracted some formerly-Mac-specific code to
264         be cross-platform and made it handle any style of line-endings.
265
266         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added.
267         Links against CFLite.
268
269         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added.
270         Contains most properties for the project.
271
272         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops:
273         Added. Links against CoreFoundation.
274
275         * TestWebKitAPI/TestWebKitAPIPrefix.h: Added a Windows-specific
276         section and moved the cross-platform section after the
277         platform-specific parts.
278
279         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Added.
280         (TestWebKitAPI::Util::run): Runs a normal message pump until we're
281         done.
282         (TestWebKitAPI::Util::cf): Turns a UTF-8 C string into a CFString.
283         (TestWebKitAPI::Util::createURLForResource): Uses CFBundle to get the
284         resource path.
285         (TestWebKitAPI::Util::URLForNonExistentResource): Creates a bogus
286         WKURL.
287
288         * TestWebKitAPI/win/PlatformWebViewWin.cpp: Added.
289         (TestWebKitAPI::registerWindowClass):
290         (TestWebKitAPI::PlatformWebView::PlatformWebView):
291         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
292         (TestWebKitAPI::PlatformWebView::page):
293         This was mostly copied from WebKitTestRunner's PlatformWebView.
294
295         * TestWebKitAPI/win/TestWebKitAPI.sln: Added. Builds both
296         TestWebKitAPI and TestWebKitAPIGeneratd. This is used by the
297         build-api-tests script.
298
299         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added. Builds
300         TestWebKitAPI.exe.
301
302         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added. Just calls
303         through to copy-resources.cmd.
304
305         * TestWebKitAPI/win/copy-resources.cmd: Added. Copies resources into
306         or deletes resources from TestWebKitAPI.resources.
307
308         * TestWebKitAPI/win/main.cpp: Added.
309         (main): Calls through to TestsController.
310
311 2010-10-13  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
312
313         Reviewed by Kenneth Rohde Christiansen.
314
315         [EFL] Support viewport configuration and add new arguments for WebKit EFL
316         https://bugs.webkit.org/show_bug.cgi?id=47084
317
318         Opera spec regarding to viewport meta tag was adjusted to WebCore. So, EFL port
319         needs to be modified according to the changes.
320
321         * EWebLauncher/main.c:
322         (on_viewport_changed):
323
324 2010-10-12  Dirk Pranke  <dpranke@chromium.org>
325
326         Reviewed by Eric Seidel.
327
328         This patch enables new-run-webkit-tests (in particular the
329         chromium-win port) to run under Cygwin as well as Win32. Mostly
330         this just required some conversions from cygwin paths to Win32
331         paths when we spawn off Win32 binaries like test_shell.
332
333         https://bugs.webkit.org/show_bug.cgi?id=47220
334
335         * Scripts/webkitpy/common/system/path.py:
336         - Expose the cygpath() function for path conversion
337
338         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
339         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
340         - shift filename->uri conversion in the TestInfo objects to the
341           dump_render_tree thread
342
343         * Scripts/webkitpy/layout_tests/port/base.py:
344         * Scripts/webkitpy/layout_tests/port/chromium.py:
345         - use cygpath()
346
347 2010-10-12  Yuta Kitamura  <yutak@chromium.org>
348
349         Unreviewed. Add Yuta Kitamura (yutak) to the committers list.
350
351         * Scripts/webkitpy/common/config/committers.py:
352
353 2010-10-12  Sam Weinig  <sam@webkit.org>
354
355         Reviewed by Dan Bernstein.
356
357         When a provisional load fails, the provisional URL returned
358         from WKFrameCopyProvisionalURL should be empty
359         <rdar://problem/8540878>
360         https://bugs.webkit.org/show_bug.cgi?id=47546
361
362         Add test.
363
364         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
365         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
366
367 2010-10-12  Anders Carlsson  <andersca@apple.com>
368
369         Reviewed by Sam Weinig.
370
371         Start fleshing out find page overlays
372         https://bugs.webkit.org/show_bug.cgi?id=47559
373
374         * MiniBrowser/mac/BrowserWindowController.m:
375         (-[BrowserWindowController find:]):
376         Pass kWKFindOptionsShowOverlay to WKPageFindString.
377
378 2010-10-12  Robert Hogan  <robert@webkit.org>
379
380         Reviewed by Antonio Gomes.
381
382         [Qt] editing/input/emacs-ctrl-o.html
383
384         ctrl-o is bound to a sequence of commands on Mac, namely:
385         insertParagraphSeparator then moveLeft. In the DRT, we just interpret
386         ctrl-o in EventSenderQt as '\n', i.e. insertParagraphSeparator. As a
387         result we only issue one command, so don't generate the change in caret
388         position that results in the extra editing delegate messages.
389
390         So for the sake of not managing suspicious-looking differences, just
391         make DRT issue the appropriate edit commands to pass the test.
392
393         https://bugs.webkit.org/show_bug.cgi?id=47548
394
395         * DumpRenderTree/qt/EventSenderQt.cpp:
396         (EventSender::keyDown):
397
398 2010-10-12  Anders Carlsson  <andersca@apple.com>
399
400         Reviewed by Sam Weinig.
401
402         Add a simple Find UI to MiniBrowser
403         https://bugs.webkit.org/show_bug.cgi?id=47553
404
405         * MiniBrowser/mac/BrowserWindow.xib:
406         Add Find panel.
407
408         * MiniBrowser/mac/BrowserWindowController.h:
409         * MiniBrowser/mac/BrowserWindowController.m:
410         (-[BrowserWindowController performFindPanelAction:]):
411         Show the find panel.
412
413         (-[BrowserWindowController find:]):
414         Tell the WKPageRef to find the given string.
415
416 2010-10-12  Tony Chang  <tony@chromium.org>
417
418         Unreviewed, fixing DRT compile on Windows after r69586.
419
420         * DumpRenderTree/chromium/WebThemeEngineDRT.h:
421
422 2010-10-12  Tony Chang  <tony@chromium.org>
423
424         Unreviewed, trying to fix NRWT on Windows.
425
426         * Scripts/webkitpy/layout_tests/port/http_lock.py:
427
428 2010-10-12  Balazs Kelemen  <kbalazs@webkit.org>
429
430         Reviewed by Kenneth Rohde Christiansen.
431
432         [Qt][WTR] Checking the path of the injected bundle is bogus
433         https://bugs.webkit.org/show_bug.cgi?id=47541
434
435         * WebKitTestRunner/qt/TestControllerQt.cpp:
436         (WTR::isExistingLibrary): Added (static helper).
437         Extend the path with the appropriate suffix(es) on the
438         platform and check that the file exists.
439         (WTR::TestController::initializeInjectedBundlePath):
440         There were two bugs with the path checking:
441             - the condition should have been inverted
442             - QLibrary::fileName does not give back the filename
443               with the library suffix so we cannot check
444               that existance of the file this way.
445
446 2010-10-12  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
447
448         Reviewed by Tony Chang.
449
450         Implement http locking in NRWT.
451         https://bugs.webkit.org/show_bug.cgi?id=47072
452
453         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
454         * Scripts/webkitpy/layout_tests/port/base.py:
455         * Scripts/webkitpy/layout_tests/port/http_lock.py: Added.
456         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py: Added.
457         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
458
459 2010-10-12  Mark Rowe  <mrowe@apple.com>
460
461         Fix the 32-bit WebKit2 build.
462
463         * MiniBrowser/mac/BrowserWindowController.m:
464         (getWindowFrame): Use NSRect rather than CGRect since that's what -frame returns.
465         (setWindowFrame): Use NSMakeRect rather than CGRectMake since that's what -setFrame:display: expects.
466
467 2010-10-11  Tony Chang  <tony@chromium.org>
468
469         Reviewed by Adam Barth.
470
471         change the order of mrobinson's email addresses so bugs.webkit.org suggests the right one
472         https://bugs.webkit.org/show_bug.cgi?id=47513
473
474         bugs.webkit.org suggests mrobinson@igalia.com as an autocomplete,
475         which doesn't actually work.
476
477         * Scripts/webkitpy/common/config/committers.py:
478
479 2010-10-11  Prasad Tammana  <prasadt@chromium.org>
480
481         Reviewed by Dmitry Titov.
482
483         Added support for showModalDialog on chromium port.
484
485         Implement showModalDialog for Layout tests for chromium port
486         https://bugs.webkit.org/show_bug.cgi?id=46759
487
488         * DumpRenderTree/chromium/WebViewHost.cpp:
489         (WebViewHost::closeWidgetSoon): Quit current message loop if in a modal loop.
490         (WebViewHost::runModal):  Start a nested message loop and remember that.
491         (WebViewHost::WebViewHost):  Initialize m_inModalLoop.
492         * DumpRenderTree/chromium/WebViewHost.h:  Add m_inModalLoop.
493
494 2010-10-11  Martin Robinson  <mrobinson@igalia.com>
495
496         Reviewed by Gustavo Noronha Silva.
497
498         [GTK] Cleanup font selection code for the Freetype backend
499         https://bugs.webkit.org/show_bug.cgi?id=47503
500
501         Update DRT to set values for the cursive and fantasy font families, so
502         that we can generate consistent results for tests that use these families.
503         Add some missing information to fonts.conf.
504
505         * DumpRenderTree/gtk/DumpRenderTree.cpp:
506         (resetDefaultsToConsistentValues): Always set the fantasy and cursive font
507         family names.
508         * DumpRenderTree/gtk/fonts/fonts.conf: Add aliases for cursive and fantasy fonts
509         to our default serif font. Eventually we may want to import or require some "real"
510         fonts, but this should at least ensure consistent rendering during test runs. Also
511         add aliases for some other commonly used fonts in tests (Arial and Lucida Grande).
512         Finally, add a missing oblique specification for DejaVu Serif, which was resulting
513         in some incorrect baselines for the synthetic oblique test.
514
515 2010-10-11  Adam Barth  <abarth@webkit.org>
516
517         Unreviewed.
518
519         Fix sheriffbot not to crash when there are failing tests.  It turns out
520         Python sets don't support the + operator.  We need to use union
521         instead.  There's a more elegant way to do this in Python 2.6, but we
522         need this code to work in 2.5.
523
524         * Scripts/webkitpy/common/net/failuremap.py:
525         * Scripts/webkitpy/common/net/failuremap_unittest.py:
526
527 2010-10-10  Robert Hogan  <robert@webkit.org>
528
529         Unreviewed, fix failing test from r69468.
530
531         [Qt] Put all DRT-created pages in a page group
532
533         Fix on r69468.
534
535         Because we don't delete closed pages immediately in DRT we need
536         to remove them from the page group explicitly instead.
537
538         Fixes failure of fast/events/popup-blocked-from-fake-user-gesture.html
539
540         https://bugs.webkit.org/show_bug.cgi?id=47469
541
542         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
543         (WebCore::DumpRenderTree::windowCloseRequested):
544
545 2010-10-10  Leandro Pereira  <leandro@profusion.mobi>
546
547         Reviewed by Adam Barth.
548
549         commit-queue: Add EFL-EWS status bubble to Bugzilla, now that the
550         EFL-EWS bot is up and running.
551         https://bugs.webkit.org/show_bug.cgi?id=47277
552
553         * QueueStatusServer/handlers/statusbubble.py:
554
555 2010-10-10  Robert Hogan  <robert@webkit.org>
556
557         Reviewed by Antonio Gomes.
558
559         [Qt] Put all DRT-created pages in a page group
560
561         https://bugs.webkit.org/show_bug.cgi?id=47469
562
563         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
564         (WebCore::DumpRenderTree::DumpRenderTree):
565         (WebCore::DumpRenderTree::createWindow):
566
567 2010-10-09  Sam Weinig  <sam@webkit.org>
568
569         Reviewed by Dan Bernstein.
570
571         WKFrameGetFrameLoadState() returns kWKFrameLoadStateCommitted after the load has been stopped
572         <rdar://problem/8173667>
573         https://bugs.webkit.org/show_bug.cgi?id=47461
574
575         * TestWebKitAPI/PlatformUtilities.h:
576         * TestWebKitAPI/Test.h:
577         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
578         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp: Added.
579         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
580         (TestWebKitAPI::TEST):
581         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
582         (TestWebKitAPI::Util::URLForNonExistentResource):
583         Adds a test for the frame load state after a failed provisional load. I wanted to test
584         the frame load state after a committed load failed, but I don't believe that is possible
585         to do without hooking up the http server to serve a long loading page.
586
587 2010-10-09  Sam Weinig  <sam@webkit.org>
588
589         Reviewed by Dan Bernstein.
590
591         Add WebKit2 version of runBeforeUnloadConfirmPanelWithMessage
592         <rdar://problem/8447690>
593         https://bugs.webkit.org/show_bug.cgi?id=47459
594
595         * MiniBrowser/mac/BrowserWindowController.m:
596         (runBeforeUnloadConfirmPanel):
597         (-[BrowserWindowController awakeFromNib]):
598         * WebKitTestRunner/TestController.cpp:
599         (WTR::createOtherPage):
600         (WTR::TestController::initialize):
601
602 2010-10-09  Sam Weinig  <sam@webkit.org>
603
604         Reviewed by Dan Bernstein.
605
606         Need implementation of ChromeClient windowRect related functions.
607         <rdar://problem/8469476>
608         https://bugs.webkit.org/show_bug.cgi?id=47386
609
610         * MiniBrowser/mac/BrowserWindowController.m:
611         (getWindowFrame):
612         (setWindowFrame):
613         (-[BrowserWindowController awakeFromNib]):
614         * WebKitTestRunner/PlatformWebView.h:
615         * WebKitTestRunner/TestController.cpp:
616         (WTR::TestController::initialize):
617         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
618         (WTR::PlatformWebView::windowFrame):
619         (WTR::PlatformWebView::setWindowFrame):
620         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
621         (WTR::PlatformWebView::windowFrame):
622         (WTR::PlatformWebView::setWindowFrame):
623         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
624         (WTR::PlatformWebView::windowFrame):
625         (WTR::PlatformWebView::setWindowFrame):
626
627 2010-10-08  Adam Barth  <abarth@webkit.org>
628
629         Unreviewed (Eric is on vacation in this change is trivial).
630
631         Add a "clean" command to webkit-patch to clean the working directory
632         https://bugs.webkit.org/show_bug.cgi?id=47436
633
634         This command is useful when using SVN because "svn revert" leaves
635         unversioned files behind.
636
637         * Scripts/webkitpy/tool/commands/download.py:
638
639 2010-10-08  Andras Becsi  <abecsi@webkit.org>
640
641         Unreviewed build fix.
642
643         [Qt] Add missing limits.h include since the Qt version currently
644         ran on the bot does need that.
645
646         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
647
648 2010-10-08  Balazs Kelemen  <kbalazs@webkit.org>
649
650         Reviewed by Csaba Osztrogonác.
651
652         [Qt] Turn on building WTR
653         https://bugs.webkit.org/show_bug.cgi?id=47349
654
655         * Scripts/webkitdirs.pm:
656
657 2010-10-08  Balazs Kelemen  <kbalazs@webkit.org>
658
659         Reviewed by Andreas Kling.
660
661         [Qt] TestController needs its platform dependent methods
662         https://bugs.webkit.org/show_bug.cgi?id=47413
663
664         * WebKitTestRunner/qt/TestControllerQt.cpp:
665         (WTR::TestController::initializeInjectedBundlePath):
666         If the WTR_INJECTEDBUNDLE_PATH environmental variable is
667         set then use that otherwise use the path where the bundle
668         lives in a normal trunk build.
669         (WTR::TestController::initializeTestPluginDirectory):
670         Set the bundle's value. It is not used currently.
671         (WTR::TestController::platformInitializeContext):
672         * WebKitTestRunner/qt/WebKitTestRunner.pro:
673
674 2010-10-08  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
675
676         Reviewed by Kenneth Rohde Christiansen.
677
678         WTR: Prevent sending the Done message twice on test timeout.
679         https://bugs.webkit.org/show_bug.cgi?id=47410
680
681         When InjectedBundle::done() calls stopLoading, this may trigger
682         InjectedBundlePage::didFailLoadWithErrorForFrame which calls
683         InjectedBundle::done() itself later in the stack.
684         This would output the timeout failure message twice and confuse
685         the run-webkit-tests script.
686
687         This patch adds a third state, Stopping, which prevents WebCore
688         errors to trigger done() when testing is over.
689
690         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
691         (WTR::InjectedBundle::done):
692         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
693
694 2010-10-08  Andras Becsi  <abecsi@webkit.org>
695
696         Reviewed by Kenneth Rohde Christiansen.
697
698         [Qt] Add an activateFonts() implementation similar to DRT's initializeFonts().
699         Original code by Simon Hausmann.
700         https://bugs.webkit.org/show_bug.cgi?id=47402
701
702         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: Added.
703         (WTR::activateFonts):
704
705 2010-10-08  Andras Becsi  <abecsi@webkit.org>
706
707         Reviewed by Csaba Osztrogonác.
708
709         [Qt] Add support for Qt's WebKitTestRunner to old-run-webkit-tests.
710         https://bugs.webkit.org/show_bug.cgi?id=47401
711
712         * Scripts/build-webkittestrunner:
713         * Scripts/old-run-webkit-tests:
714
715 2010-10-07  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
716
717         Reviewed by Kenneth Rohde Christiansen.
718
719         [Qt] WTR first compile: fix compile issues.
720         https://bugs.webkit.org/show_bug.cgi?id=47343
721
722         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
723         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
724         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
725         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
726         * WebKitTestRunner/TestController.cpp:
727         * WebKitTestRunner/TestInvocation.cpp:
728
729 2010-10-07  Antonio Gomes  <agomes@rim.com>
730
731         Reviewed by Simon Fraser.
732
733         [Mac] [DRT] implement setSpatialNavigationEnabled
734         https://bugs.webkit.org/show_bug.cgi?id=47291
735
736         Implemented LayoutTestController::setSpatialNavigationEnabled for Mac's DRT
737         so it can track regression on the existing implementation and future improvements
738         we are making.
739
740         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
741         (LayoutTestController::setSpatialNavigationEnabled):
742
743 2010-10-07  Dirk Pranke  <dpranke@chromium.org>
744
745         Reviewed by Adam Barth.
746
747         rebaseline-chromium-webkit-tests relied on the filename_to_uri()
748         hook in the Port infrastructure to generate URIs for the files
749         in its summary HTML report; however, that method is supposed to only
750         be used for test files (and should really be renamed), so this would
751         crash.
752
753         This change adds a new "path" module to the system package with a
754         routine called abspath_to_uri() that handles converting paths to
755         file: URIs independently of anything in the layout_tests package,
756         and changes the code to use this. At some point in the near future
757         the layout_tests/port/* code should use this as well.
758
759         This change also deletes a bunch of unused code and fixes some
760         comments in rebaseline_chromium_webkit_tests.py.
761
762         https://bugs.webkit.org/show_bug.cgi?id=47319
763
764         * Scripts/webkitpy/common/system/path.py: Added.
765         * Scripts/webkitpy/common/system/path_unittest.py: Added.
766         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
767         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
768
769 2010-10-07  Martin Robinson  <mrobinson@igalia.com>
770
771         Reviewed by Gustavo Noronha Silva.
772
773         [GTK] The FreeType backend does not respect the FC_EMBOLDEN property
774         https://bugs.webkit.org/show_bug.cgi?id=46216
775
776         Fix my latest commit, as it contained some bad changes from a merge gone wrong.
777
778         * DumpRenderTree/gtk/DumpRenderTree.cpp:
779         (initializeFonts): Also initialize the DevaVu Sans font.
780
781 2010-10-07  Daniel Cheng  <dcheng@chromium.org>
782
783         Reviewed by Tony Chang.
784
785         [chromium] Minor naming cleanup in WebDragData, part 2
786         https://bugs.webkit.org/show_bug.cgi?id=47227
787
788         Update DRT to use the renamed methods.
789
790         * DumpRenderTree/chromium/EventSender.cpp:
791         (EventSender::beginDragWithFiles):
792         * DumpRenderTree/chromium/WebViewHost.cpp:
793         (addDRTFakeFileToDataObject):
794
795 2010-10-07  Anders Carlsson  <andersca@apple.com>
796
797         Reviewed by Sam Weinig.
798
799         Add a WKPageFindClient, hook up WKPageCountStringMatches
800         https://bugs.webkit.org/show_bug.cgi?id=47373
801
802         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
803         Remove hard coded paths.
804
805         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
806         (TestWebKitAPI::TEST):
807         Fix expected result.
808
809         * TestWebKitAPI/Tests/WebKit2/Find.cpp: Added.
810         (TestWebKitAPI::didFinishLoadForFrame):
811         (TestWebKitAPI::didCountStringMatches):
812         (TestWebKitAPI::TEST):
813         * TestWebKitAPI/Tests/WebKit2/find.html: Added.
814         Add test for WKPageCountStringMatches.
815
816 2010-09-21  Martin Robinson  <mrobinson@igalia.com>
817
818         Reviewed by Chris Fleizach.
819
820         [GTK] The FreeType backend does not respect the FC_EMBOLDEN property
821         https://bugs.webkit.org/show_bug.cgi?id=46216
822
823         * DumpRenderTree/gtk/fonts/fonts.conf: Add a setting which enables FC_EMBOLDEN
824         for DejaVu Serif when there is no bold version available. This is necessary to
825         properly test the property in layout tests.
826
827 2010-10-07  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>, Andras Becsi  <abecsi@webkit.org>, Balazs Kelemen  <kbalazs@webkit.org>
828
829         Reviewed by Kenneth Rohde Christiansen.
830
831         [Qt] Add WTR's InjectedBundle build files.
832         https://bugs.webkit.org/show_bug.cgi?id=47333
833
834         * Scripts/webkitdirs.pm:
835         * WebKitTestRunner/DerivedSources.pro: Added.
836         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Added.
837         * WebKitTestRunner/WebKitTestRunner.pro: Added.
838         * WebKitTestRunner/qt/DerivedSources.pro: Removed.
839         Content merged in ../DerivedSources.pro
840
841 2010-10-07  Sheriff Bot  <webkit.review.bot@gmail.com>
842
843         Unreviewed, rolling out r69315.
844         http://trac.webkit.org/changeset/69315
845         https://bugs.webkit.org/show_bug.cgi?id=47363
846
847         Forgot to add the new files (Requested by kbalazs on #webkit).
848
849         * Scripts/webkitdirs.pm:
850         * WebKitTestRunner/qt/DerivedSources.pro: Added.
851
852 2010-10-07  Sam Weinig  <sam@webkit.org>
853
854         Reviewed by Anders Carlsson.
855
856         Change API tester to ask the executable for the list of all
857         tests instead of relying on the directory structure.
858         https://bugs.webkit.org/show_bug.cgi?id=47359
859
860         * Scripts/run-test-webkit-api: Added.
861         * Scripts/webkitdirs.pm:
862         Add additional script to just launch the api tester with the correct settings.
863
864         * Scripts/run-api-tests:
865         Change to use the new --dump-tests options to build the list of tests and change
866         output to reflect a (suite, testcase) tuple for each test. Also adds some color.
867
868         * TestWebKitAPI/Test.h:
869         (TestWebKitAPI::Test::Register::Register):
870         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
871         (TestWebKitAPI::TEST):
872         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
873         (TestWebKitAPI::TEST):
874         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
875         (TestWebKitAPI::TEST):
876         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
877         (TestWebKitAPI::TEST):
878         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
879         (TestWebKitAPI::TEST):
880         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
881         (TestWebKitAPI::TEST):
882         Give each test a suite name in addition to the test name.
883
884         * TestWebKitAPI/TestsController.cpp:
885         (TestWebKitAPI::TestsController::dumpTestNames):
886         (TestWebKitAPI::TestsController::runTestNamed):
887         * TestWebKitAPI/TestsController.h:
888         * TestWebKitAPI/mac/main.mm:
889         (main):
890         Add option to print all registered tests.
891
892 2010-10-07  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>, Andras Becsi  <abecsi@webkit.org>, Balazs Kelemen  <kbalazs@webkit.org>
893
894         Reviewed by Kenneth Rohde Christiansen.
895
896         [Qt] Add WTR's InjectedBundle build files.
897         https://bugs.webkit.org/show_bug.cgi?id=47333
898
899         * Scripts/webkitdirs.pm:
900         * WebKitTestRunner/DerivedSources.pro: Added.
901         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Added.
902         * WebKitTestRunner/WebKitTestRunner.pro: Added.
903         * WebKitTestRunner/qt/DerivedSources.pro: Removed.
904         Content merged in ../DerivedSources.pro
905
906 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
907
908         Unreviewed. Do a renaming that was recommended by the reviewer
909         (Kenneth) but I forgot to do before landing (http://trac.webkit.org/changeset/69253)
910
911         * WebKitTestRunner/qt/TestControllerQt.cpp:
912         (WTR::RunUntilConditionLoop::start):
913         (WTR::RunUntilConditionLoop::RunUntilConditionLoop):
914         (WTR::TestController::runUntil):
915
916 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
917
918         Reviewed by Kenneth Rohde Christiansen.
919
920         [Qt] Watchdog timer implementation for WTR
921         https://bugs.webkit.org/show_bug.cgi?id=47337
922
923         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Factor out
924         the definition of the timer type to a typedef.
925         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp: Added.
926         Timer implementation with QTimer and a helper QObject class.
927         (WTR::WatchdogTimerHelper::instance):
928         (WTR::WatchdogTimerHelper::timerFired):
929         (WTR::WatchdogTimerHelper::WatchdogTimerHelper):
930         (WTR::LayoutTestController::platformInitialize):
931         (WTR::LayoutTestController::invalidateWaitToDumpWatchdogTimer):
932         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
933
934 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
935
936         Unreviewed buildfix for 69297 again
937
938         * WebKitTestRunner/TestController.cpp:
939         (WTR::blankURL):
940
941 2010-10-07  Balazs Kelemen  <Balazs Kelemen>
942
943         Unreviewed trivial build fix for r69297
944
945         * WebKitTestRunner/TestController.cpp:
946         (WTR::blankURL):
947
948 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
949
950         Reviewed by Kenneth Rohde Christiansen.
951
952         WebKitTestRunner should be portable
953         https://bugs.webkit.org/show_bug.cgi?id=45393
954
955         Use only the WebKit API for working with urls.
956         * WebKitTestRunner/StringFunctions.h:
957         (WTR::createWKURL):
958         * WebKitTestRunner/TestController.cpp:
959         (WTR::blankURL):
960         (WTR::TestController::resetStateToConsistentValues):
961         (WTR::TestController::didFinishLoadForFrame):
962
963 2010-10-07  Carlos Garcia Campos  <cgarcia@igalia.com>
964
965         Reviewed by Xan Lopez.
966
967         [GTK] Use gtk_widget_draw() instead of gtk_widget_get_snapshot() in PixelDumpSupportGtk when building with gtk3
968         https://bugs.webkit.org/show_bug.cgi?id=47332
969
970         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
971         (createBitmapContextFromWebView):
972
973 2010-10-06  Chris Guillory  <chris.guillory@google.com>
974
975         Reviewed by Chris Fleizach.
976
977         Remove unused accessibility functions from webkit.
978         https://bugs.webkit.org/attachment.cgi?bugid=46707
979
980         * DumpRenderTree/chromium/WebViewHost.cpp:
981         (WebViewHost::postAccessibilityNotification):
982         * DumpRenderTree/chromium/WebViewHost.h:
983
984 2010-10-06  Lucas Forschler  <lforschler@apple.com>
985
986         Reviewed by Adam Roben.
987
988         Fix the sunspider-compare-results to actually use the passed in value for $root.
989
990         * Scripts/sunspider-compare-results:
991
992 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
993
994         Reviewed by Kenneth Rohde Christiansen.
995
996         [Qt] Runloop implementation for WTR
997         https://bugs.webkit.org/show_bug.cgi?id=47280
998
999         * WebKitTestRunner/qt/TestControllerQt.cpp:
1000         Implemented TestController::runUntil by a timerEvent
1001         and a QEventLoop. We step into the event loop from runUntil.
1002         While we are waiting in the loop a timerEvent is periodically
1003         checking the value of the condition. Once the condition has
1004         becoming true the timerEvent wakes us up.
1005         (WTR::RunUntilLoop::start):
1006         (WTR::RunUntilLoop::RunUntilLoop):
1007         (WTR::RunUntilLoop::run):
1008         (WTR::RunUntilLoop::timerEvent):
1009         (WTR::TestController::platformInitialize):
1010         (WTR::TestController::runUntil):
1011         * WebKitTestRunner/qt/main.cpp:
1012         Start the main event loop first and creating the TestController later.
1013         (Launcher::Launcher):
1014         (Launcher::~Launcher):
1015         (Launcher::launch): Creating the TestController.
1016         (main): Setting up a timer for calling Launcher::launch from
1017         the main event loop.
1018
1019 2010-10-06  Dirk Pranke  <dpranke@chromium.org>
1020
1021         Reviewed by Kenneth Russell.
1022
1023         new-run-webkit-tests: fix typo in chromium-gpu that was trying to
1024         enable 'accelerated-composting' instead of 'accelerated-compositing'.
1025
1026         https://bugs.webkit.org/show_bug.cgi?id=47312
1027
1028         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1029         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1030
1031 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
1032
1033         Reviewed by Kenneth Rohde Christiansen.
1034
1035         [Qt] PlatformWebView implementation for WebKitTestRunner
1036         https://bugs.webkit.org/show_bug.cgi?id=47276
1037
1038         The implementation follows the way how
1039         we use the API in MiniBrowser.
1040         * WebKitTestRunner/PlatformWebView.h:
1041         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1042         (WTR::WebView::wkView):
1043         (WTR::WebView::~WebView):
1044         (WTR::WebView::WebView):
1045         (WTR::PlatformWebView::PlatformWebView):
1046         (WTR::PlatformWebView::~PlatformWebView):
1047         (WTR::PlatformWebView::resizeTo):
1048         (WTR::PlatformWebView::page):
1049         (WTR::PlatformWebView::focus):
1050         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1051
1052 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
1053
1054         Reviewed by Kenneth Rohde Christiansen.
1055
1056         [Qt] Add WebKitTestRunner's build files
1057         https://bugs.webkit.org/show_bug.cgi?id=44155
1058
1059         Parts was taken by Zoltan Horvath's patch.
1060
1061         * Scripts/generate-forwarding-headers.pl: Moved from WebKit2.
1062         * Scripts/webkitdirs.pm: Make the generated files needed by WTR.
1063         * WebKitTestRunner/PlatformWebView.h: Addeed typedefs for
1064         PlatformWKView and PlatformWindow (void* for now).
1065         Buildfix the case when __APPLE__ is not defined.
1066         * WebKitTestRunner/qt/DerivedSources.pro: Added.
1067         * WebKitTestRunner/qt/PlatformWebViewQt.cpp: Added.
1068         Empty stub implementation.
1069         (WTR::registerWindowClass):
1070         (WTR::PlatformWebView::PlatformWebView):
1071         (WTR::PlatformWebView::~PlatformWebView):
1072         (WTR::PlatformWebView::resizeTo):
1073         (WTR::PlatformWebView::page):
1074         (WTR::PlatformWebView::focus):
1075         * WebKitTestRunner/qt/TestControllerQt.cpp: Added.
1076         Empty stub implementation.
1077         (WTR::registerWindowClass):
1078         (WTR::TestController::runUntil):
1079         (WTR::TestController::platformInitialize):
1080         (WTR::TestController::initializeInjectedBundlePath):
1081         (WTR::TestController::initializeTestPluginDirectory):
1082         (WTR::TestController::platformInitializeContext):
1083         * WebKitTestRunner/qt/WebKitTestRunner.pro: Added.
1084         * WebKitTestRunner/qt/main.cpp: Added.
1085         (main):
1086
1087 2010-10-06  Tony Chang  <tony@chromium.org>
1088
1089         Unreviewed, rolling out r69202.
1090         http://trac.webkit.org/changeset/69202
1091         https://bugs.webkit.org/show_bug.cgi?id=46937
1092
1093         Broke compile of test_shell
1094
1095         * DumpRenderTree/chromium/EventSender.cpp:
1096         (EventSender::beginDragWithFiles):
1097         * DumpRenderTree/chromium/WebViewHost.cpp:
1098         (addDRTFakeFileToDataObject):
1099
1100 2010-10-06  Daniel Cheng  <dcheng@chromium.org>
1101
1102         Reviewed by Tony Chang.
1103
1104         [chromium] Minor naming cleanup in WebDragData, part 2
1105         https://bugs.webkit.org/show_bug.cgi?id=46937
1106
1107         Update DRT to use the renamed methods.
1108
1109         * DumpRenderTree/chromium/EventSender.cpp:
1110         (EventSender::beginDragWithFiles):
1111         * DumpRenderTree/chromium/WebViewHost.cpp:
1112         (addDRTFakeFileToDataObject):
1113
1114 2010-10-06  David Kilzer  <ddkilzer@apple.com>
1115
1116         <http://webkit.org/b/47270> Move WebArchive serialization code into its own file
1117
1118         Reviewed by Adam Roben.
1119
1120         This is the first step in making webarchive tests work on
1121         Windows.
1122
1123         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added
1124         new files to the project.
1125         * DumpRenderTree/mac/DumpRenderTree.mm: Removed code that moved
1126         to WebArchiveDumpSupport.mm.
1127         * DumpRenderTree/mac/WebArchiveDumpSupport.h: Added.
1128         * DumpRenderTree/mac/WebArchiveDumpSupport.mm: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm.
1129         (serializeWebArchiveToXML):
1130
1131 2010-10-05  Daniel Bates  <dbates@rim.com>
1132
1133         Reviewed by David Kilzer.
1134
1135         Add infrastructure to towards detecting change log diffs that aren't at the top of the ChangeLog
1136         https://bugs.webkit.org/show_bug.cgi?id=46058
1137
1138         Make VCSUtils::fixChangeLogPatch() return a reference to a hash
1139         structure so as to support returning additional information
1140         about a change log diff.
1141
1142         Currently, VCSUtils::fixChangeLogPatch() returns a string that
1143         represents the change log diff. Towards supporting the return
1144         of additional information, such as whether the change log diff
1145         inserts an entry at the top of the ChangeLog file, we need to
1146         make VCSUtils::fixChangeLogPatch() return a reference to hash
1147         structure.
1148
1149         * Scripts/VCSUtils.pm:
1150           - Modified fixChangeLogPatch() to return a reference to a
1151             hash structure.
1152           - Added documentation to fixChangeLogPatch().
1153           - Modified call site in mergeChangeLogs() as necessary.
1154         * Scripts/svn-apply:
1155           - Modified call site in patch() as necessary.
1156         * Scripts/svn-create-patch:
1157           - Modified call site in generateDiff() as necessary.
1158         * Scripts/svn-unapply:
1159           - Modified call site in patch() as necessary.
1160         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
1161           - Modified the unit tests as necessary.
1162
1163 2010-10-05  Tony Chang  <tony@chromium.org>
1164
1165         Reviewed by Darin Adler.
1166
1167         fix the link to the expected image on windows
1168         https://bugs.webkit.org/show_bug.cgi?id=47228
1169
1170         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: On
1171             windows, the file must be opened in binary mode when writing
1172             binary data.
1173
1174 2010-10-05  Adam Barth  <abarth@webkit.org>
1175
1176         Update expected result of unittest to match Tony's change below.
1177
1178         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1179
1180 2010-10-05  Tony Chang  <tony@chromium.org>
1181
1182         Reviewed by Ojan Vafai (over the shoulder).
1183
1184         Paper over errors in image_diff so we don't crash the whole test run.
1185
1186         * Scripts/webkitpy/layout_tests/port/chromium.py:
1187
1188 2010-10-05  Tony Chang  <tony@chromium.org>
1189
1190         Unreviewed, make shutil.rmtree more resiliant to errors
1191         since windows was raising WindowsError: The process cannot access the file because it
1192         is being used by another process.
1193
1194         * Scripts/webkitpy/layout_tests/port/chromium.py:
1195
1196 2010-10-05  Tony Chang  <tony@chromium.org>
1197
1198         Reviewed by Ojan Vafai.
1199
1200         [chromium] fix image diffing in NRWT
1201         https://bugs.webkit.org/show_bug.cgi?id=47128
1202
1203         * Scripts/webkitpy/layout_tests/port/chromium.py: Stop using
1204             NamedTemporaryFile since it doesn't work on Windows.
1205         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1206
1207 2010-10-05  Kenneth Russell  <kbr@google.com>
1208
1209         Reviewed by Tony Chang.
1210
1211         [chromium] Implement layerTreeAsText in DumpRenderTree
1212         https://bugs.webkit.org/show_bug.cgi?id=47216
1213
1214         Plumbed Frame::layerTreeAsText through Chromium's WebKit API to
1215         make it callable from DumpRenderTree.
1216
1217         No new tests; verified with existing compositor layout tests.
1218
1219         * DumpRenderTree/chromium/LayoutTestController.cpp:
1220         (LayoutTestController::LayoutTestController):
1221         (LayoutTestController::layerTreeAsText):
1222         * DumpRenderTree/chromium/LayoutTestController.h:
1223
1224 2010-10-05  Brent Fulgham  <bfulgham@webkit.org>
1225
1226         Unreviewed build correction.
1227
1228         * DumpRenderTree/win/ImageDiff.vcproj: Use WinCairo debug
1229         property sheet so proper libraries are linked.
1230
1231 2010-10-05  Robert Hogan  <robert@webkit.org>
1232
1233         Reviewed by Andreas Kling.
1234
1235         [Qt] Fix url conversion in QWebHistory
1236
1237         Converting from KURL to WFT::String to QUrl does not
1238         permit proper percent encoding later.
1239
1240         https://bugs.webkit.org/show_bug.cgi?id=47048
1241
1242         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1243         (WebCore::dumpHistoryItem):
1244
1245 2010-10-05  Anders Carlsson  <andersca@apple.com>
1246
1247         Reviewed by Sam Weinig.
1248
1249         REGRESSION (r68966?): All dumpAsText test fail on WebKit2
1250         https://bugs.webkit.org/show_bug.cgi?id=47188
1251         <rdar://problem/8514104>
1252
1253         When constructing the std::string, use the real string length instead of the maximum buffer size.
1254
1255         * TestWebKitAPI/PlatformUtilities.h:
1256         (TestWebKitAPI::Util::toSTD):
1257         * WebKitTestRunner/StringFunctions.h:
1258         (WTR::toSTD):
1259
1260 2010-10-04  Sam Weinig  <sam@webkit.org>
1261
1262         Reviewed by Mark Rowe.
1263
1264         Add MIMEType accessor to WKFrame
1265         <rdar://problem/8347683>
1266         https://bugs.webkit.org/show_bug.cgi?id=47138
1267
1268         * TestWebKitAPI/PlatformUtilities.h:
1269         (TestWebKitAPI::Util::toSTD):
1270         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1271         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp: Added.
1272         (TestWebKitAPI::didStartProvisionalLoadForFrame):
1273         (TestWebKitAPI::didCommitLoadForFrame):
1274         (TestWebKitAPI::didFinishLoadForFrame):
1275         (TestWebKitAPI::TEST):
1276         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp: Added.
1277         (TestWebKitAPI::didStartProvisionalLoadForFrame):
1278         (TestWebKitAPI::didCommitLoadForFrame):
1279         (TestWebKitAPI::didFinishLoadForFrame):
1280         (TestWebKitAPI::TEST):
1281         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1282         (TestWebKitAPI::TEST):
1283         * TestWebKitAPI/Tests/WebKit2/basic-1.html: Removed.
1284         * TestWebKitAPI/Tests/WebKit2/icon.png: Added.
1285         * TestWebKitAPI/Tests/WebKit2/simple.html: Added.
1286         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1287         (TestWebKitAPI::Util::createURLForResource):
1288
1289 2010-10-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1290
1291         Reviewed by Ojan Vafai.
1292
1293         [NRWT] Rename current_dir to current_group because it's not a directory
1294         https://bugs.webkit.org/show_bug.cgi?id=47169
1295
1296         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1297         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1298
1299 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
1300
1301         Unreviewed, build fix.
1302
1303         r69065 broke test-webkitpy by trying to create a '/tmp-X' directory,
1304         which can't always be done. This test uses tempfile.mkdtemp(), which
1305         should be safe.
1306
1307         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1308
1309 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
1310
1311         Unreviewed, build fix.
1312
1313         Add missing "from __future__ import with_statement" that was
1314         breaking test-webkitpy on the Leopard bots (broke in r69040).
1315
1316         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1317
1318 2010-10-04  Sheriff Bot  <webkit.review.bot@gmail.com>
1319
1320         Unreviewed, rolling out r69066.
1321         http://trac.webkit.org/changeset/69066
1322         https://bugs.webkit.org/show_bug.cgi?id=47163
1323
1324         Made NRWT reliability worse. (Requested by tkent on #webkit).
1325
1326         * Scripts/webkitpy/layout_tests/port/chromium.py:
1327         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1328
1329 2010-10-04  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1330
1331         Reviewed by Tony Chang.
1332
1333         [NRWT] Reverse the http tests to alphabetical order.
1334         https://bugs.webkit.org/show_bug.cgi?id=47075
1335
1336         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1337
1338 2010-10-04  Robert Hogan  <robert@webkit.org>
1339
1340         Reviewed by Andreas Kling.
1341
1342         [Qt] Fix timeout on http/tests/navigation/post-goback2.html and postredirect-goback2.html
1343
1344         We need to queue back and forward navigations in the DRT from the
1345         LayoutTestController so that maybeDump() knows about them.
1346
1347         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1348         (LayoutTestController::queueBackNavigation):
1349         (LayoutTestController::queueForwardNavigation):
1350
1351 2010-10-04  Tony Chang  <tony@chromium.org>
1352
1353         Reviewed by Kent Tamura.
1354
1355         [chromium] fix image diffing in NRWT
1356         https://bugs.webkit.org/show_bug.cgi?id=47128
1357
1358         * Scripts/webkitpy/layout_tests/port/chromium.py: Flush data to the
1359               temp file and check the image_diff error code more carefully
1360         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1361
1362 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
1363
1364         Reviewed by Adam Barth.
1365
1366         aroben's change in r68792 actually broke new-run-webkit-tests when
1367         running the DRT code path. His change was intended to fix the
1368         way we were converting windows paths to URIs when running under
1369         Cygwin (the paths were getting one too many "/" on the front).
1370         However, the change ended up breaking the chromium_win port, which
1371         had slightly different logic.
1372
1373         This patch removes the port-specific code and adds tests to make
1374         sure we're getting the behavior we expect. The Port object no longer
1375         exposes a get_absolute_path() method that can be used outside of
1376         of converting test filenames, because it's unreliable otherwise
1377         (we don't have the right context to know which conversion is intended).
1378
1379         https://bugs.webkit.org/show_bug.cgi?id=47140
1380
1381         * Scripts/webkitpy/layout_tests/port/base.py:
1382         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1383         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1384         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1385         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1386
1387 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
1388
1389         Unreviewed, build fix.
1390
1391         Handle crash introduced in r69040 if we are not running in a
1392         Chromium checkout.
1393
1394         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1395
1396 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
1397
1398         Reviewed by Tony Chang.
1399
1400         Add a way for us to have test expectations that are specific to the
1401         official builds of Google Chrome (as opposed to Chromium). This change
1402         looks for an additional "test_expectations_chrome.txt" file in
1403         Chromium's repository (webkit/tools/layout_tests), and uses the
1404         concatenation of that file and the regular test_expectations.txt
1405         file for test overrides.
1406
1407         https://bugs.webkit.org/show_bug.cgi?id=46854
1408
1409         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1410         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1411
1412 2010-10-04  Simon Fraser  <simon.fraser@apple.com>
1413
1414         Color tests in the list based on existing pass/fail result.
1415         
1416         Fix the summary data to account for htmlOnly and nonHTML tests.
1417
1418         * CSSTestSuiteHarness/harness/harness.css:
1419         (#test-list > option.pass):
1420         (#test-list > option.fail):
1421         (#test-list > option.skipped):
1422         * CSSTestSuiteHarness/harness/harness.js:
1423         (Test):
1424         (Test.prototype.statusForFormat):
1425         (TestSuite.prototype.fillTestList):
1426         (TestSuite.prototype.updateTestList):
1427         (TestSuite.prototype.recordResult):
1428         (TestSuite.prototype.markTestCompleted):
1429         (TestSuite.prototype.countTestsWithFlag):
1430         (TestSuite.prototype.queryDatabaseForSummary.this.db.transaction):
1431         (TestSuite.prototype.queryDatabaseForSummary):
1432
1433 2010-10-04  Chris Fleizach  <cfleizach@apple.com>
1434
1435         Reviewed by Beth Dakin.
1436
1437         AX: doAXRangeForLine does not work
1438         https://bugs.webkit.org/show_bug.cgi?id=47101
1439
1440         DRT support to handle NSAccessibilityRangeForLineParameterizedAttribute.
1441
1442         * DumpRenderTree/AccessibilityUIElement.cpp:
1443         (rangeForLineCallback):
1444         (AccessibilityUIElement::rangeForLine):
1445         (AccessibilityUIElement::getJSClass):
1446         * DumpRenderTree/AccessibilityUIElement.h:
1447         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1448         (AccessibilityUIElement::rangeForLine):
1449
1450 2010-10-04  Andrey Kosyakov  <caseq@chromium.org>
1451
1452         Unreviewed. Adding myself to the committers list.
1453
1454         * Scripts/webkitpy/common/config/committers.py:
1455
1456 2010-10-04  Sam Weinig  <sam@webkit.org>
1457
1458         Reviewed by Anders Carlsson.
1459
1460         Add ability to set the CacheModel in Webkit2
1461         https://bugs.webkit.org/show_bug.cgi?id=47066
1462
1463         * MiniBrowser/mac/AppDelegate.m:
1464         (-[BrowserAppDelegate init]): Opt minibrowser into
1465         a PrimaryWebBrowser cache model.
1466
1467 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
1468
1469         Make sure to enter all tests when creating the database
1470         for the first time.
1471         
1472         When migrating to a new version of the suite, be sure to
1473         sync up the database and testinfo.data by removing old
1474         tests, and inserting new ones.
1475
1476         * CSSTestSuiteHarness/harness/harness.js:
1477         (TestSuite.prototype.openDatabase.creation):
1478         (TestSuite.prototype.databaseCreated):
1479         (TestSuite.prototype.populateDatabaseFromTestInfoData):
1480         (TestSuite.prototype.insertTest):
1481
1482 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
1483
1484         More work on treating HTML4 and XHTML1 independently; when 
1485         changing the format, rebuild the test list, and update the 
1486         numbers in the chapter popup.
1487
1488         * CSSTestSuiteHarness/harness/harness.js:
1489         (Test):
1490         (Test.prototype.runForFormat):
1491         (Test.prototype.completedForFormat):
1492         (ChapterSection):
1493         (ChapterSection.prototype.countTests):
1494         (Chapter):
1495         (Chapter.prototype.description):
1496         (Chapter.prototype.countTests):
1497         (Chapter.prototype.testCount):
1498         (Chapter.prototype.untestedCount):
1499         (TestSuite.prototype.buildChapters):
1500         (TestSuite.prototype.loadCurrentTest):
1501         (TestSuite.prototype.updateProgressLabel):
1502         (TestSuite.prototype.processFlags):
1503         (TestSuite.prototype.formatChanged):
1504
1505 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
1506
1507         Update test suite version 20101001.
1508         
1509         Handle database migration, and delete tests from the db that are
1510         not present in testinfo.data.
1511         
1512         Load about:blank into the test frame before the test url, to make
1513         missing tests more obvious.
1514         
1515         * CSSTestSuiteHarness/harness/harness.js:
1516         (TestSuite.prototype.loadTest):
1517         (TestSuite.prototype.openDatabase.creation):
1518         (TestSuite.prototype.openDatabase.migration1_0To1_1):
1519         (TestSuite.prototype.openDatabase.if.return):
1520         (TestSuite.prototype.databaseReady):
1521         (TestSuite.prototype.populateDatabaseFromTestInfoData):
1522         (TestSuite.prototype.syncDatabaseWithTestInfoData.this.db.transaction):
1523         (TestSuite.prototype.syncDatabaseWithTestInfoData):
1524
1525 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
1526
1527         Add the ability to jump to a specific test.
1528
1529         * CSSTestSuiteHarness/harness/harness.html:
1530         * CSSTestSuiteHarness/harness/harness.js:
1531         (TestSuite.prototype.goToTestByName):
1532         (TestSuite.prototype.switchToFormat):
1533
1534 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
1535
1536         For a ref test, load the ref in the same format (HTML4 vs XHTML1)
1537         as the test.
1538
1539         * CSSTestSuiteHarness/harness/harness.js:
1540         (TestSuite.prototype.loadRef):
1541
1542 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
1543
1544         Update the UI to reflect the fact that each test needs to be tested
1545         in both HTML4 and XHTML1 format.
1546         
1547         * CSSTestSuiteHarness/harness/harness.js:
1548         (Test):
1549         (Chapter.prototype.description):
1550         (Chapter.prototype.untestedCount):
1551         (TestSuite.prototype.fillChapterPopup):
1552         (TestSuite.prototype.updateChapterPopup):
1553         (TestSuite.prototype.fillTestList):
1554         (TestSuite.prototype.updateTestList):
1555         (TestSuite.prototype.goToNextIncompleteTest):
1556         (TestSuite.prototype.firstIncompleteTestIndex):
1557         (TestSuite.prototype.recordResult):
1558         (TestSuite.prototype.formatChanged):
1559         (TestSuite.prototype.markTestCompleted):
1560         (TestSuite.prototype.resetTestStatus):
1561
1562 2010-10-01  Simon Fraser  <simon.fraser@apple.com>
1563
1564         Add the ability to remove results for re-testing, and
1565         to import results.
1566
1567         * CSSTestSuiteHarness/harness/harness.css:
1568         (.custom button):
1569         (#overlay):
1570         (#overlay.visible):
1571         (.overlay-contents):
1572         (.overlay-contents textarea):
1573         (.overlay-contents .buttons):
1574         (.overlay-contents .note):
1575         (.overlay-contents .buttons button):
1576         * CSSTestSuiteHarness/harness/harness.html:
1577         * CSSTestSuiteHarness/harness/harness.js:
1578         (TestSuite.prototype.importResults):
1579         (TestSuite.prototype.clearResults):
1580         (TestSuite.prototype.markTestCompleted):
1581         (TestSuite.prototype.resetTestStatus):
1582         (TestSuite.prototype.storeTestResult):
1583         (TestSuite.prototype.importTestResults):
1584         (TestSuite.prototype.clearTestResults):
1585
1586 2010-10-01  Sam Weinig  <sam@webkit.org>
1587
1588         Reviewed by Jon Honeycutt.
1589
1590         Deploy the new WKString functions to remove most uses of CF from
1591         the WebKitTestRunner.
1592
1593         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1594         (WTR::InjectedBundle::didReceiveMessage):
1595         (WTR::InjectedBundle::done):
1596         * WebKitTestRunner/StringFunctions.h:
1597         (WTR::toWK):
1598         (WTR::toJS):
1599         (WTR::toSTD):
1600         (WTR::operator<<):
1601         (WTR::copyURLString):
1602         * WebKitTestRunner/TestController.cpp:
1603         (WTR::TestController::resetStateToConsistentValues):
1604         (WTR::TestController::didFinishLoadForFrame):
1605         * WebKitTestRunner/TestInvocation.cpp:
1606         (WTR::TestInvocation::invoke):
1607         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1608
1609 2010-10-01  Mihai Parparita  <mihaip@chromium.org>
1610
1611         Unreviewed TestResultsServer change.
1612
1613         Add files introduced by http://crrev.com/61273 to the list of dashboard 
1614         files to update.
1615
1616         * TestResultServer/handlers/dashboardhandler.py:
1617
1618 2010-10-01  Brian Weinstein  <bweinstein@apple.com>
1619
1620         Build Fix for Windows.
1621
1622         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Don't copy ForwardingHeaders from
1623             WebKitTestRunner/ForwardingHeaders, instead, add $(WebKitOutputDir)/include/WebCore/
1624             ForwardingHeaders to the include path.
1625
1626 2010-10-01  Sam Weinig  <sam@webkit.org>
1627
1628         Reviewed by Anders Carlsson.
1629
1630         Add SPI to convert a WKStringRef to a JSStringRef and vice-versa.
1631
1632         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1633         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
1634         (TestWebKitAPI::TEST):
1635         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp: Added.
1636         (TestWebKitAPI::TEST):
1637
1638 2010-10-01  Sam Weinig  <sam@webkit.org>
1639
1640         Reviewed by Kenneth Rohde Christiansen.
1641
1642         Add additional WKString API
1643         https://bugs.webkit.org/show_bug.cgi?id=46958
1644
1645         Add basic WKStringRef tests.
1646
1647         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1648         * TestWebKitAPI/Tests/WebKit2/WKString.cpp: Added.
1649
1650 2010-10-01  Sam Weinig  <sam@webkit.org>
1651
1652         Reviewed by Dan Bernstein.
1653
1654         Add makefile for TestWebKitAPI and call it from the base makefile.
1655
1656         * Makefile:
1657         * TestWebKitAPI/Makefile: Added.
1658
1659 2010-10-01  Sam Weinig  <sam@webkit.org>
1660
1661         Reviewed by Adam Roben.
1662
1663         Remove unnecessary ForwardingHeaders from test runners.
1664         https://bugs.webkit.org/show_bug.cgi?id=47010
1665
1666         * TestWebKitAPI/Configurations/Base.xcconfig:
1667         * TestWebKitAPI/ForwardingHeaders: Removed.
1668         * WebKitTestRunner/Configurations/Base.xcconfig:
1669         * WebKitTestRunner/ForwardingHeaders: Removed.
1670
1671 2010-09-30  Adam Barth  <abarth@webkit.org>
1672
1673         Reviewed by Eric Seidel.
1674
1675         WebSocket tests are flaky
1676         https://bugs.webkit.org/show_bug.cgi?id=46956
1677
1678         Update these tools to understand how to run the WebSocket tests off the
1679         Apache server.
1680
1681         * Scripts/old-run-webkit-tests:
1682         * Scripts/webkitpy/layout_tests/port/base.py:
1683         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1684         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1685
1686 2010-10-01  Adam Roben  <aroben@apple.com>
1687
1688         Encode Executive command arguments using UTF-8 on Cygwin
1689
1690         Cygwin's Python's os.execv doesn't support unicode command arguments.
1691         Cygwin's execv expects arguments to be encoded using the current code
1692         page. But code pages are limited in what characters they can handle,
1693         and our tests include characters that the English code page can't
1694         handle.  So for now we'll just encode everything in UTF-8 on Cygwin,
1695         which can handle all characters but might confuse some commands, for
1696         expediency's sake. I'm sure we'll run into cases where UTF-8 isn't
1697         good enough, but we can deal with that when the problem arises.
1698
1699         Reviewed by Adam Barth.
1700
1701         Fixes <http://webkit.org/b/46892> <rdar://problem/8496639>
1702         webkitpy.common.system.executive_unittest.ExecutiveTest.test_run_command_with_unicode
1703         fails on Windows
1704
1705         * Scripts/webkitpy/common/system/executive.py:
1706         (Executive._run_command_with_teed_output):
1707         (Executive.run_command):
1708         On Cygwin, encode arguments using UTF-8.
1709
1710 2010-10-01  Sam Weinig  <sam@webkit.org>
1711
1712         Reviewed by Adam Roben.
1713
1714         Add simple API tester for WebKit2
1715         https://bugs.webkit.org/show_bug.cgi?id=46953
1716
1717         This adds a very simple testing infrastructure for testing APIs exposed
1718         through the WebKit project. It consists of two parts: 1) a project that
1719         builds the all the tests 2) a script that searches the tests directory and
1720         calls the tester once for each test.
1721
1722         This adds the infrastructure and two tests:
1723         - Tests/WTF/Vector1.cpp - A proof of concept test of WTF data-structures.
1724         - Tests/WebKit2/BasicTest1.cpp - A proof of concept test of WebKit2 API.
1725
1726         This currently only works on the mac, but is designed to be easily ported 
1727         to any platform.
1728
1729         * Scripts/run-api-tests: Added.
1730         * Scripts/build-api-tests: Added.
1731         Scripts to build/run the tests.
1732
1733         * TestWebKitAPI: Added.
1734         * TestWebKitAPI/Configurations: Added.
1735         * TestWebKitAPI/Configurations/Base.xcconfig: Added.
1736         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Added.
1737         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Added.
1738         * TestWebKitAPI/ForwardingHeaders: Added.
1739         * TestWebKitAPI/ForwardingHeaders/wtf: Added.
1740         * TestWebKitAPI/PlatformUtilities.h: Added.
1741         * TestWebKitAPI/PlatformWebView.h: Added.
1742         (TestWebKitAPI::PlatformWebView::platformView):
1743         * TestWebKitAPI/StringFunctions.h: Added.
1744         * TestWebKitAPI/Test.h: Added.
1745         (TestWebKitAPI::Test::~Test):
1746         (TestWebKitAPI::Test::name):
1747         (TestWebKitAPI::Test::Register::Register):
1748         (TestWebKitAPI::Test::Register::create):
1749         (TestWebKitAPI::Test::Test):
1750         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Added.
1751         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added.
1752         * TestWebKitAPI/TestWebKitAPIPrefix.h: Added.
1753         * TestWebKitAPI/TestsController.cpp: Added.
1754         (TestWebKitAPI::TestsController::shared):
1755         (TestWebKitAPI::TestsController::TestsController):
1756         (TestWebKitAPI::TestsController::runTestNamed):
1757         (TestWebKitAPI::TestsController::testFailed):
1758         (TestWebKitAPI::TestsController::registerCreateTestFunction):
1759         * TestWebKitAPI/TestsController.h: Added.
1760         * TestWebKitAPI/mac: Added.
1761         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm: Added.
1762         (TestWebKitAPI::Util::run):
1763         (TestWebKitAPI::Util::createURLForResource):
1764         * TestWebKitAPI/mac/PlatformWebViewMac.mm: Added.
1765         (TestWebKitAPI::PlatformWebView::PlatformWebView):
1766         (TestWebKitAPI::PlatformWebView::resizeTo):
1767         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
1768         (TestWebKitAPI::PlatformWebView::page):
1769         (TestWebKitAPI::PlatformWebView::focus):
1770         * TestWebKitAPI/mac/main.mm: Added.
1771         Infrastructure.
1772
1773         * TestWebKitAPI/Tests: Added.
1774         * TestWebKitAPI/Tests/WTF: Added.
1775         * TestWebKitAPI/Tests/WTF/Vector1.cpp: Added.
1776         * TestWebKitAPI/Tests/WebKit2: Added.
1777         * TestWebKitAPI/Tests/WebKit2/BasicTest1.cpp: Added.
1778         (TestWebKitAPI::State::State):
1779         * TestWebKitAPI/Tests/WebKit2/basic-1.html: Added.
1780         Proof of concept tests.
1781
1782 2010-10-01  Adam Roben  <aroben@apple.com>
1783
1784         Don't assume AccessibleObjectFromEvent succeeds
1785
1786         Fixes <http://webkit.org/b/44136> <rdar://problem/8321684> Crash in
1787         DumpRenderTree!notificationListenerProc when running
1788         plugins/access-after-page-destroyed.html
1789
1790         Reviewed by Sam Weinig.
1791
1792         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1793         (notificationListenerProc): Check both the return value of
1794         AccessibleObjectFromEvent and the object it returns, as MSDN
1795         recommends.
1796
1797 2010-10-01  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1798
1799         Reviewed by Tony Chang.
1800
1801         [NRWT] Put the http and websocket tests first in the test list.
1802         https://bugs.webkit.org/show_bug.cgi?id=46453
1803
1804         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1805         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1806
1807 2010-10-01  Fady Samuel  <fsamuel@chromium.org>
1808
1809         Unreviewed, adding myself to the committer list.
1810
1811         * Scripts/webkitpy/common/config/committers.py:
1812
1813 2010-10-01  Adam Roben  <aroben@apple.com>
1814
1815         Test NPN_GetValue(NPNVnetscapeWindow)
1816
1817         Test for <http://webkit.org/b/46726> <rdar://problem/8486319>
1818         Right-clicking on windowless Flash plugin in WebKit2 makes a context
1819         menu appear in the bottom-right corner of the screen
1820
1821         Reviewed by Anders Carlsson.
1822
1823         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1824         (PluginTest::NPN_GetValue): Added. Calls through to the browser.
1825
1826         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added NPN_GetValue.
1827
1828         * DumpRenderTree/TestNetscapePlugIn/Tests/win/GetValueNetscapeWindow.cpp: Added.
1829         (GetValueNetscapeWindow::GetValueNetscapeWindow): Initialize members.
1830         (GetValueNetscapeWindow::NPP_SetWindow): Test that
1831         NPN_GetValue(NPNVnetscapeWindow) returns a valid HWND and that it
1832         isn't our HWND.
1833
1834         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1835         Added GetValueNetscapeWindow.
1836
1837 2010-10-01  Andreas Kling  <andreas.kling@nokia.com>
1838
1839         Unreviewed, adding my webkit.org identity to reviewer list.
1840
1841         * Scripts/webkitpy/common/config/committers.py:
1842
1843 2010-09-30  Adam Barth  <abarth@webkit.org>
1844
1845         Reviewed by Eric Seidel.
1846
1847         The WebSocket server should flush its logs
1848         https://bugs.webkit.org/show_bug.cgi?id=46946
1849
1850         The WebSocket server logs are truncated because the driver just
1851         terminates the child.  It should run Python without buffering so we can
1852         see the end of the log.
1853
1854         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1855
1856 2010-09-30  Simon Fraser  <simon.fraser@apple.com>
1857
1858         Add a button to jump to the next untested test.
1859         
1860         * CSSTestSuiteHarness/harness/harness.css:
1861         (.test-type):
1862         (.name > button):
1863         * CSSTestSuiteHarness/harness/harness.html:
1864         * CSSTestSuiteHarness/harness/harness.js:
1865         (Chapter.prototype.description):
1866         (Chapter.prototype.untestedCount):
1867         (TestSuite.prototype.testInfoDataLoaded):
1868         (TestSuite.prototype.fillChapterPopup):
1869         (TestSuite.prototype.updateChapterPopup):
1870         (TestSuite.prototype.buildTestListForChapter):
1871         (TestSuite.prototype.goToNextIncompleteTest):
1872         (TestSuite.prototype.firstIncompleteTestIndex):
1873         (TestSuite.prototype.testCompletionStateChanged):
1874
1875 2010-09-29  Jon Honeycutt  <jhoneycutt@apple.com>
1876
1877         WebKit2 on Windows should use Windows fonts for the various standard
1878         font families
1879         https://bugs.webkit.org/show_bug.cgi?id=43499
1880         <rdar://problem/8272758>
1881
1882         Reviewed by Adam Roben.
1883
1884         * WebKitTestRunner/TestController.cpp:
1885         (WTR::TestController::resetStateToConsistentValues):
1886         Use the Mac fonts for running tests. This matches DRT behavior.
1887
1888 2010-09-30  Adam Barth  <abarth@webkit.org>
1889
1890         Third attempt.  We need a better integration test environment.
1891
1892         * Scripts/webkitpy/common/net/failuremap.py:
1893         * Scripts/webkitpy/common/net/failuremap_unittest.py:
1894
1895 2010-09-30  Robert Hogan  <robert@webkit.org>
1896
1897         Reviewed by Andreas Kling.
1898
1899         [Qt] Support for PlainTextController
1900
1901         Unskip editing/text-iterator/basic-iteration.html
1902
1903         https://bugs.webkit.org/show_bug.cgi?id=38805
1904
1905         * DumpRenderTree/qt/DumpRenderTree.pro:
1906         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1907         (WebCore::DumpRenderTree::DumpRenderTree):
1908         (WebCore::DumpRenderTree::initJSObjects):
1909         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1910         * DumpRenderTree/qt/PlainTextControllerQt.cpp: Added.
1911         (PlainTextController::PlainTextController):
1912         (PlainTextController::plainText):
1913         * DumpRenderTree/qt/PlainTextControllerQt.h: Added.
1914
1915 2010-09-30  Adam Barth  <abarth@webkit.org>
1916
1917         Unreviewed.  Second attempt to fix sheriffbot.
1918
1919         * Scripts/webkitpy/common/net/buildbot.py:
1920
1921 2010-09-30  Adam Barth  <abarth@webkit.org>
1922
1923         Unreviewed.
1924
1925         This patch should stop the sheriffbot from throwing an exception.
1926
1927         * Scripts/webkitpy/common/net/buildbot.py:
1928
1929 2010-09-30  Brian Weinstein  <bweinstein@apple.com>
1930
1931         Reviewed by Adam Roben.
1932
1933         The same bots shouldn't run both Windows Debug Tests and Windows Release Tests.
1934         https://bugs.webkit.org/show_bug.cgi?id=46926
1935
1936         * BuildSlaveSupport/build.webkit.org-config/config.json: Have two bots running Windows 
1937             Release Tests, and two bots running Windows Debug Tests, instead of four running both.
1938
1939 2010-09-30  Adam Barth  <abarth@webkit.org>
1940
1941         Reviewed by Eric Seidel.
1942
1943         webkit-patch find-flaky-tests should print results URLs
1944         https://bugs.webkit.org/show_bug.cgi?id=46917
1945
1946         Printing out the results URL makes find-flaky-tests more actionable
1947         because you can see what happens when a test fails.  The output from
1948         the script is still pretty noisy, but it seems useful.
1949
1950         * Scripts/webkitpy/tool/commands/queries.py:
1951
1952 2010-09-30  Chris Marrin  <cmarrin@apple.com>
1953
1954         Reviewed by Simon Fraser.
1955
1956         Make 2D accelerated canvas rendering build on Mac
1957         https://bugs.webkit.org/show_bug.cgi?id=46007
1958         
1959         Added ACCELERATED_2D_CANVAS to build-webkit
1960
1961         * Scripts/build-webkit:
1962
1963 2010-09-29  Kenneth Russell  <kbr@google.com>
1964
1965         Reviewed by Dimitri Glazkov.
1966
1967         [chromium] Add accelerated compositing support to DumpRenderTree and test_shell
1968         https://bugs.webkit.org/show_bug.cgi?id=46849
1969
1970         Added offscreen code path for WebGraphicsContext3DDefaultImpl which
1971         works with the compositor integration in both DumpRenderTree and
1972         test_shell, since both pass a non-null WebCanvas* to WebViewImpl::paint
1973         and thereby trigger the compositor's readback code path. Added support
1974         for --enable-accelerated-compositing to DumpRenderTree.
1975
1976         Tested in both test_shell and DumpRenderTree on Linux, the latter by
1977         modifying a compositing layout test, dumping the pixels and verifying
1978         that they matched the output when the compositor was active.
1979
1980         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1981         (main):
1982         * DumpRenderTree/chromium/TestShell.cpp:
1983         (TestShell::TestShell):
1984         (TestShell::resetWebSettings):
1985         * DumpRenderTree/chromium/TestShell.h:
1986         (TestShell::setAcceleratedCompositingEnabled):
1987         * DumpRenderTree/chromium/WebPreferences.cpp:
1988         (WebPreferences::reset):
1989         (WebPreferences::applyTo):
1990         * DumpRenderTree/chromium/WebPreferences.h:
1991         * DumpRenderTree/chromium/WebViewHost.cpp:
1992         (WebViewHost::scheduleComposite):
1993         * DumpRenderTree/chromium/WebViewHost.h:
1994
1995 2010-09-30  Adam Roben  <aroben@apple.com>
1996
1997         Ensure that QueueEngine cleans up its log files when its delegate
1998         tells it to stop processing work
1999
2000         Reviewed by Adam Barth.
2001
2002         Fixes <http://webkit.org/b/46891> <rdar://problem/8496638> Many tests
2003         in webkitpy.tool.bot.queueengine_unittest.QueueEngineTest crash on
2004         Windows
2005
2006         * Scripts/webkitpy/tool/bot/queueengine.py:
2007         (QueueEngine.run): Stop ourselves normally (including cleaning up log
2008         files) when the delegate tells us to stop processing work.
2009
2010         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2011         (LoggingDelegate.__init__): Moved code here from
2012         RaisingDelegate.__init__.
2013         (LoggingDelegate.expeced_callbacks): Added the stop_work_queue
2014         callback.
2015         (LoggingDelegate.stop_work_queue): Moved here from RaisingDelegate.
2016         (RaisingDelegate.__init__): Removed code that LoggingDelegate takes
2017         care of for us now.
2018         (QueueEngineTest.test_trivial): Make sure we got the expected stop
2019         message.
2020         (QueueEngineTest.test_not_safe_to_proceed): Changed to explicitly
2021         remove the callbacks that are related to processing a single work
2022         item, rather than removing all callbacks after a certain point, as
2023         there are now more callbacks we expect to receive at the end.
2024
2025 2010-09-30  Adam Roben  <aroben@apple.com>
2026
2027         Fix path -> URL conversion on Cygwin
2028
2029         Reviewed by Adam Barth.
2030
2031         Fixes <http://webkit.org/b/46890> <rdar://problem/8496637> Many tests
2032         in webkitpy.layout_tests.run_webkit_tests_unittest assert on Windows
2033
2034         * Scripts/webkitpy/layout_tests/port/base.py:
2035         (Port.filename_to_uri): Treat Cygwin like other UNIX-y platforms by
2036         assuming paths already have a leading slash.
2037
2038 2010-09-30  Adam Roben  <aroben@apple.com>
2039
2040         Teach WindowGeometryInitializedBeforeSetWindow that NPP_SetWindow can
2041         be called more than once
2042
2043         The NPP_SetWindow call made when the plugin is torn down was confusing
2044         us, and was causing us to spew an error into the next test.
2045
2046         Fixes <http://webkit.org/b/46900> <rdar://problem/8496888> REGRESSION
2047         (r68520): plugins/access-after-page-destroyed.html failing on Windows
2048
2049         Reviewed by Anders Carlsson.
2050
2051         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:
2052         (WindowGeometryInitializedBeforeSetWindow::WindowGeometryInitializedBeforeSetWindow):
2053         Initialize member.
2054         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Bail if
2055         this isn't the first time this is called.
2056
2057 2010-09-30  Eric Seidel  <eric@webkit.org>
2058
2059         Reviewed by Adam Barth.
2060
2061         webkit-patch upload warns that I'm using Xcode when I'm not
2062         https://bugs.webkit.org/show_bug.cgi?id=46869
2063
2064         String.find returns -1 when not found, so switched to "in".
2065
2066         * Scripts/webkitpy/common/system/user.py:
2067         * Scripts/webkitpy/common/system/user_unittest.py:
2068
2069 2010-09-30  Eric Seidel  <eric@webkit.org>
2070
2071         Reviewed by Adam Barth.
2072
2073         webkit-patch failure-reason dies if non-trunk commits are in the blame range
2074         https://bugs.webkit.org/show_bug.cgi?id=46866
2075
2076         I also made failure-reason use RegressionWindow in a cleaner way.
2077
2078         * Scripts/webkitpy/tool/commands/queries.py:
2079
2080 2010-09-29  Adam Barth  <abarth@webkit.org>
2081
2082         Reviewed by Eric Seidel.
2083
2084         webkit-patch find-flaky-tests
2085         https://bugs.webkit.org/show_bug.cgi?id=46876
2086
2087         This command helps us find flaky tests so we can squash them.
2088
2089         * Scripts/webkitpy/tool/commands/queries.py:
2090
2091 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
2092
2093         Fix export to use '?' instead of 'null' for
2094         tests with no results.
2095         
2096         * CSSTestSuiteHarness/harness/harness.js:
2097
2098 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
2099
2100         Add a warning when a test requires special steps.
2101         Add a Print Preview button for 'paged' tests that
2102         brings up the print dialog, allowing the user to 
2103         judge paged media tests.
2104
2105         * CSSTestSuiteHarness/harness/harness.css:
2106         * CSSTestSuiteHarness/harness/harness.html:
2107         * CSSTestSuiteHarness/harness/harness.js:
2108         (TestSuite.prototype.loadTest):
2109         (TestSuite.prototype.processFlags):
2110
2111 2010-09-29  Adam Barth  <abarth@webkit.org>
2112
2113         Reviewed by Eric Seidel.
2114
2115         Remove revisions_casuing_failures
2116         https://bugs.webkit.org/show_bug.cgi?id=46872
2117
2118         This function exists only to be unit tested.
2119
2120         * Scripts/webkitpy/common/net/failuremap.py:
2121         * Scripts/webkitpy/common/net/failuremap_unittest.py:
2122         * Scripts/webkitpy/tool/mocktool.py:
2123
2124 2010-09-29  Adam Barth  <abarth@webkit.org>
2125
2126         Reviewed by Eric Seidel.
2127
2128         SheriffBot should post the list of failing tests to bugs
2129         https://bugs.webkit.org/show_bug.cgi?id=46871
2130
2131         * Scripts/webkitpy/common/net/buildbot.py:
2132         * Scripts/webkitpy/common/net/failuremap.py:
2133         * Scripts/webkitpy/common/net/regressionwindow.py:
2134         * Scripts/webkitpy/tool/bot/sheriff.py:
2135         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
2136         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2137         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2138         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2139         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2140         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2141         * Scripts/webkitpy/tool/mocktool.py:
2142
2143 2010-09-29  Brent Fulgham  <bfulgham@webkit.org>
2144
2145         Reviewed by Martin Robinson, Eric Seidel, and Mark Rowe.
2146
2147         [WinCairo] Adds a build slave.
2148         https://bugs.webkit.org/show_bug.cgi?id=46360
2149
2150         * BuildSlaveSupport/build.webkit.org-config/config.json: Add
2151         entries for a debug build of the WinCairo port.
2152         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add
2153         platform flag to configuration for wincairo (like gtk, chromium, etc.)
2154         * Scripts/build-webkit: Change 'cairo-win32' labeling to 'wincairo'
2155         * Scripts/webkitdirs.pm: Change 'cairo-win32' labeling to 'wincairo'
2156
2157 2010-09-29  Adam Barth  <abarth@webkit.org>
2158
2159         Reviewed by Eric Seidel.
2160
2161         Move more SheriffBot smarts into FailureMap
2162         https://bugs.webkit.org/show_bug.cgi?id=46703
2163
2164         This patch pushes the FailureMap model object further into the
2165         SheriffBot machine.  In addition, it moves a couple operations on this
2166         object from SheriffBot itself to the model.
2167
2168         Eventually, FailureMap will be the canonical context object for
2169         SheriffBot operations.  FailureMap represents a map of the current
2170         failures on the bots that might require remediation.
2171
2172         * Scripts/webkitpy/common/net/failuremap.py:
2173         * Scripts/webkitpy/common/net/regressionwindow.py:
2174         * Scripts/webkitpy/tool/commands/queries.py:
2175         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2176         * Scripts/webkitpy/tool/mocktool.py:
2177
2178 2010-09-29  Tony Chang  <tony@chromium.org>
2179
2180         Reviewed by James Robinson.
2181
2182         [chromium] enable -Werror for DRT and webkit_unit_tests on Linux
2183         https://bugs.webkit.org/show_bug.cgi?id=46829
2184
2185         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
2186         (DRTDevToolsClient::DRTDevToolsClient):
2187         * DumpRenderTree/chromium/TestShell.cpp:
2188         (TestShell::TestShell):
2189         * DumpRenderTree/chromium/WebViewHost.cpp:
2190         (WebViewHost::postAccessibilityNotification):
2191         (WebViewHost::WebViewHost):
2192
2193 2010-09-29  Chris Fleizach  <cfleizach@apple.com>
2194
2195         Reviewed by Darin Adler.
2196
2197         AX: implement CSS3 Speech "speak"
2198         https://bugs.webkit.org/show_bug.cgi?id=46827
2199
2200         * DumpRenderTree/AccessibilityUIElement.cpp:
2201         (speakCallback):
2202         (AccessibilityUIElement::speak):
2203         (AccessibilityUIElement::getJSClass):
2204         * DumpRenderTree/AccessibilityUIElement.h:
2205         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2206         (AccessibilityUIElement::speak):
2207
2208 2010-09-29  Mihai Parparita  <mihaip@chromium.org>
2209
2210         Reviewed by Adam Barth.
2211
2212         Record bot ID when updating queue status
2213         https://bugs.webkit.org/show_bug.cgi?id=46764
2214         
2215         Since we now have multiple bots handling patches from the commit queue,
2216         we need to differentiate status updates from them, so that we can group
2217         the queue status page in a less confusing way.
2218
2219         * QueueStatusServer/handlers/updatestatus.py: Accept bot_id as input
2220         * QueueStatusServer/model/queuestatus.py: Add bot_id property
2221         * QueueStatusServer/templates/updatestatus.html: Add bot_id input
2222         * Scripts/webkitpy/common/net/bugzilla_unittest.py: Extract MockBrowser
2223         * Scripts/webkitpy/common/net/statusserver.py: Add bot_id
2224         * Scripts/webkitpy/common/net/statusserver_unittest.py: Added.
2225         * Scripts/webkitpy/tool/main.py: Add --bot-id
2226         * Scripts/webkitpy/tool/mocktool.py: Add MockBrowser
2227
2228 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
2229
2230         No review.
2231         
2232         References always refert to a file in .xht format, even
2233         for HTML tests, so fix their loading.
2234
2235         * CSSTestSuiteHarness/harness/harness.js:
2236         (TestSuite.prototype.loadRef):
2237
2238 2010-09-28  Johnny Ding  <jnd@chromium.org>
2239
2240         Reviewed by Adam Barth.
2241
2242         https://bugs.webkit.org/show_bug.cgi?id=41292
2243         Add a new parameter to the test plugin to allow specifying a script 
2244         and a mouse/keyboard event. The specified script will be evaluated
2245         in the browser when the specified event is received by the plugin.
2246
2247         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2248         (pluginAllocate):
2249         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
2250         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2251         (NPP_New):
2252         (handleEventCarbon):
2253         (handleEventCocoa):
2254
2255 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
2256
2257         Fix export by adding missing argument.
2258
2259         * CSSTestSuiteHarness/harness/harness.js:
2260         (TestSuite.prototype.showResultsForAllTests):
2261
2262 2010-09-28  Kevin Ollivier  <kevino@theolliviers.com>
2263
2264         [wx] Build fix, add missing import.
2265
2266         * wx/packaging/build-win-installer.py:
2267
2268 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
2269
2270         No review
2271         
2272         Show which tests have been run by dimming them out in the test list.
2273         
2274         Adjust some element sizes.
2275         
2276         * CSSTestSuiteHarness/harness/harness.css:
2277         (#test-list > option.untested):
2278         (#test-list > option.completed):
2279         (#output):
2280         (.output-options):
2281         * CSSTestSuiteHarness/harness/harness.js:
2282         (Test):
2283         (TestSuite.prototype.fillTestList):
2284         (TestSuite.prototype.updateTestList):
2285         (TestSuite.prototype.setSelectedChapter):
2286         (TestSuite.prototype.recordResult):
2287         (TestSuite.prototype.markTestCompleted):
2288         (TestSuite.prototype.testCompletionStateChanged):
2289         (TestSuite.prototype.loadTestStatus):
2290
2291 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
2292
2293         No review.
2294         
2295         Implement export of various queries on the test database, sharing
2296         code with that which displays results inline.
2297
2298         * CSSTestSuiteHarness/harness/harness.js:
2299         ():
2300         (TestSuite.prototype.exportResultsCompletion.var):
2301         (TestSuite.prototype.exportResultsCompletion):
2302         (TestSuite.prototype.showResultsForCompletedTests):
2303         (TestSuite.prototype.exportResultsForCompletedTests):
2304         (TestSuite.prototype.showResultsForAllTests):
2305         (TestSuite.prototype.exportResultsForAllTests):
2306         (TestSuite.prototype.exportResultsForTestsNotRun):
2307         (TestSuite.prototype.exportResultsForTestsWithStatus):
2308         (TestSuite.prototype.exportResultsForTestsWithMismatchedResults):
2309
2310 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
2311
2312         No review.
2313
2314         Work around uncertainty about the order of database
2315         transactions when creating the database, so that we don't
2316         try to query the table before it has been created.
2317
2318         * CSSTestSuiteHarness/harness/harness.js:
2319         (TestSuite):
2320         (TestSuite.prototype.databaseCreated):
2321         (TestSuite.prototype.storeTestResult):
2322         (TestSuite.prototype.populateDatabaseFromTestInfoData):
2323         (TestSuite.prototype.queryDatabaseForTestsWithStatus):
2324         (TestSuite.prototype.queryDatabaseForTestsWithMixedStatus):
2325         (TestSuite.prototype.queryDatabaseForCompletedTests):
2326         (TestSuite.prototype.queryDatabaseForTestsNotRun):
2327
2328 2010-09-28  Tony Chang  <tony@chromium.org>
2329
2330         Reviewed by Eric Seidel.
2331
2332         add python keyring support to webkit-patch
2333         https://bugs.webkit.org/show_bug.cgi?id=41269
2334
2335         * Scripts/webkitpy/common/net/credentials.py: Add the ability to read passwords using
2336             the python keyring module
2337         * Scripts/webkitpy/common/net/credentials_unittest.py:
2338         * Scripts/webkitpy/common/system/user.py: Allow confirm() to default to no and add testing params.
2339         * Scripts/webkitpy/common/system/user_unittest.py:
2340         * Scripts/webkitpy/tool/mocktool.py:
2341
2342 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
2343
2344         Reviewed by Gustavo Noronha Silva.
2345
2346         [Cairo] FreeType fonts should obey FontConfig hinting/anti-aliasing settings
2347         https://bugs.webkit.org/show_bug.cgi?id=46740
2348
2349         * DumpRenderTree/gtk/fonts/fonts.conf: Add specialized variants of common
2350         fonts which can be used to fully test FontConfig rendering settings.
2351
2352 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
2353
2354         Reviewed by Gustavo Noronha Silva.
2355
2356         [gtk] Fedora has a different path for the liberation fonts
2357         https://bugs.webkit.org/show_bug.cgi?id=46709
2358
2359         When searching for DRT fonts, also look in the path where those fonts
2360         are commonly found on Fedora systems.
2361
2362         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2363         (initializeFonts): Include logic for looking for Fedora-style font paths.
2364
2365 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
2366
2367         Reviewed by Andreas Kling.
2368
2369         run-webkit-tests needs an updated list of directories with webgl tests
2370         https://bugs.webkit.org/show_bug.cgi?id=46747
2371
2372         Update the list of directories containing WebGL tests and a unit test
2373         which depends on this list.
2374
2375         * Scripts/old-run-webkit-tests: Update the list of directories.
2376         * Scripts/webkitpy/layout_tests/port/webkit.py: Ditto.
2377         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Update the expected result.
2378
2379 2010-09-28  Adam Barth  <abarth@webkit.org>
2380
2381         Reviewed by Eric Seidel.
2382
2383         Introduce FailureMap to summaries the failures status of all the bots
2384         https://bugs.webkit.org/show_bug.cgi?id=46700
2385
2386         This patch gives the SheriffBot a handle on the list of failing tests.
2387
2388         * Scripts/webkitpy/common/net/buildbot.py:
2389         * Scripts/webkitpy/common/net/failuremap.py: Added.
2390         * Scripts/webkitpy/tool/commands/queries.py:
2391         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2392         * Scripts/webkitpy/tool/mocktool.py:
2393
2394 2010-09-28  Adam Roben  <aroben@apple.com>
2395
2396         Update for the addition of WKPageUIClient::didNotHandleKeyEvent
2397
2398         Fixes <http://webkit.org/b/46660> <rdar://problem/8483465> Need API to
2399         tell a WebKit2 client application that a key event was not handled
2400
2401         Reviewed by Kenneth Rohde Christiansen and Sam Weinig.
2402
2403         * MiniBrowser/mac/BrowserWindowController.m:
2404         (-[BrowserWindowController awakeFromNib]):
2405         * MiniBrowser/win/BrowserView.cpp:
2406         (BrowserView::create):
2407         * WebKitTestRunner/TestController.cpp:
2408         (WTR::createOtherPage):
2409         (WTR::TestController::initialize):
2410
2411 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
2412
2413         Unreviewed.
2414
2415         Update the CSSTestSuiteHarness to not scrape the XHTML chapter files
2416         for the test order, but instead use information from testinfo.data.
2417         
2418         * CSSTestSuiteHarness/harness/harness.html:
2419         * CSSTestSuiteHarness/harness/harness.js:
2420
2421 2010-09-28  Kevin Ollivier  <kevino@theolliviers.com>
2422
2423         [wx] Build fix, don't try to get the svn revision from the git repo when packaging,
2424         it causes the process to hang on the gitorious repo.
2425
2426         * wx/packaging/build-mac-installer.py:
2427         * wx/packaging/build-win-installer.py:
2428
2429 2010-09-28  Adam Roben  <aroben@apple.com>
2430
2431         Test that a plugin's HWND is sized/positioned before NPP_SetWindow is
2432         called
2433
2434         Reviewed by Anders Carlsson.
2435
2436         Test for <http://webkit.org/b/46716> <rdar://problem/8482014>
2437         Full-page Adobe Reader does not paint until window is resized
2438
2439         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2440         (PluginTest::NPP_SetWindow): Added. Just returns NPERR_NO_ERROR at
2441         this level.
2442
2443         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Declared
2444         NPP_SetWindow.
2445
2446         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp: Added.
2447         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Checks that
2448         the plugin's HWND has a non-zero size and that its size/position
2449         matches that specified in the NPWindow.
2450
2451         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2452         (NPP_SetWindow): Call through to the PluginTest.
2453
2454         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2455         Added WindowGeometryInitializedBeforeSetWindow.cpp, and let VS reorder
2456         the files as it saw fit.
2457
2458 2010-09-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
2459
2460         Reviewed by Andreas Kling.
2461
2462         [Qt] Remove support for Qt 4.5
2463         https://bugs.webkit.org/show_bug.cgi?id=46718
2464
2465         Remove the code for versions of Qt prior to 4.6.
2466
2467         * DumpRenderTree/qt/EventSenderQt.cpp:
2468         (EventSender::addTouchPoint):
2469         (EventSender::updateTouchPoint):
2470         (EventSender::setTouchModifier):
2471         (EventSender::touchStart):
2472         (EventSender::touchMove):
2473         (EventSender::touchEnd):
2474         (EventSender::clearTouchPoints):
2475         (EventSender::releaseTouchPoint):
2476         (EventSender::sendTouchEvent):
2477         * DumpRenderTree/qt/EventSenderQt.h:
2478         * DumpRenderTree/qt/TextInputControllerQt.cpp:
2479         (TextInputController::setMarkedText):
2480         * QtTestBrowser/launcherwindow.cpp:
2481         (LauncherWindow::LauncherWindow):
2482         (LauncherWindow::initializeView):
2483         (LauncherWindow::createChrome):
2484         (LauncherWindow::sendTouchEvent):
2485         (LauncherWindow::eventFilter):
2486         (LauncherWindow::applyZoom):
2487         (LauncherWindow::setTouchMocking):
2488         * QtTestBrowser/launcherwindow.h:
2489         * QtTestBrowser/utils.cpp:
2490         (urlFromUserInput):
2491         * QtTestBrowser/webview.cpp:
2492         (WebViewGraphicsBased::animatedFlip):
2493         (WebViewGraphicsBased::animatedYFlip):
2494         * QtTestBrowser/webview.h:
2495         (WebViewGraphicsBased::setYRotation):
2496
2497 2010-09-28  İsmail Dönmez  <ismail@namtrac.org>
2498
2499         Reviewed by Andreas Kling.
2500
2501         Fix DRT compilation on WinCE. Introduce a WCECOMPAT variable
2502         which should point to wcecompat installation. Needs wcecompat
2503         library from http://github.com/mauricek/wcecompat .
2504
2505         * DumpRenderTree/qt/DumpRenderTree.pro:
2506         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2507         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2508
2509 2010-09-28  Daniel Bates  <dbates@rim.com>
2510
2511         Rollout changeset 68493 <http://trac.webkit.org/changeset/68493>
2512         <https://bugs.webkit.org/show_bug.cgi?id=39136>
2513
2514         Rollout changeset 68493 because it broke Sheriffbot's rollout feature.
2515         In particular, this change caused Sheriffbot to raise an exception when
2516         trying to parse the bug id on a bug page. We need to look into this
2517         some more.
2518
2519         * Scripts/webkitpy/common/net/bugzilla.py:
2520         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
2521         * Scripts/webkitpy/tool/bot/sheriff.py:
2522         * Scripts/webkitpy/tool/commands/download.py:
2523         * Scripts/webkitpy/tool/commands/queues.py:
2524         * Scripts/webkitpy/tool/commands/upload.py:
2525         * Scripts/webkitpy/tool/steps/closebug.py:
2526         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
2527         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2528         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
2529
2530 2010-09-28  Adam Barth  <abarth@webkit.org>
2531
2532         Reviewed by Eric Seidel.
2533
2534         Move RegressionWindow further up the dependency chain
2535         https://bugs.webkit.org/show_bug.cgi?id=46698
2536
2537         Baby steps towards pushing this information into bug posts.
2538
2539         * Scripts/webkitpy/common/net/buildbot.py:
2540         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2541         * Scripts/webkitpy/common/net/regressionwindow.py:
2542         * Scripts/webkitpy/tool/commands/queries.py:
2543
2544 2010-09-27  Daniel Bates  <dbates@rim.com>
2545
2546         Reviewed by Adam Barth.
2547
2548         sheriffbot can't roll out security patches
2549         https://bugs.webkit.org/show_bug.cgi?id=39136
2550
2551         Make SheriffBot determine if it's authorized to view a bug
2552         whose change it wants to rollout before it tries to rollout
2553         the change.
2554
2555         Moreover, make both webkit-patch and Sheriffbot provide human-
2556         readable error messages when they are not authorized to view
2557         a bug and when a bug number is invalid.
2558
2559         Currently, Sheriffbot does not parse Bugzilla bugs for
2560         <bug error="...">, which indicates an error when retrieving
2561         a bug. In particular, error="NotPermitted" if a person (or bot)
2562         is not authorized to view a bug. For such error="NotPermitted" bugs,
2563         Sheriffbot raises an exception when parsing the bug report and
2564         this exception does not explicitly indicate Sheriffbot's lack
2565         of authorization. Instead, Sheriffbot should explicitly check
2566         for the presence <bug error="..."> before operating on a bug
2567         and error with a human-readable message if it's not permitted
2568         to view it.
2569
2570         * Scripts/webkitpy/common/net/bugzilla.py: Added BugzillaError class.
2571         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
2572           - Added unit test test_bug_parsing_for_bugzilla_not_permitted_error().
2573           - Added unit test test_bug_parsing_for_bugzilla_not_found_error().
2574           - Added unit test test_bug_parsing_for_bugzilla_invalid_bug_id_error().
2575         * Scripts/webkitpy/tool/bot/sheriff.py: Modified to catch BugzillaError.
2576         * Scripts/webkitpy/tool/commands/download.py: Ditto.
2577         * Scripts/webkitpy/tool/commands/queues.py: Ditto.
2578         * Scripts/webkitpy/tool/commands/upload.py: Ditto.
2579         * Scripts/webkitpy/tool/steps/closebug.py: Ditto.
2580         * Scripts/webkitpy/tool/steps/obsoletepatches.py: Ditto.
2581         * Scripts/webkitpy/tool/steps/preparechangelog.py: Ditto.
2582         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: Ditto.
2583
2584 2010-09-27  Adam Barth  <abarth@webkit.org>
2585
2586         Reviewed by Eric Seidel.
2587
2588         Expose more more failure information from Buildbot to SheriffBot
2589         https://bugs.webkit.org/show_bug.cgi?id=46697
2590
2591         This patch moves the information about what tests failured closer to
2592         SheriffBot.  There are still a couple more patches to go before
2593         SheriffBot can post this information to bugs, but this is a step in
2594         that direction.  Yay for unit tests, which caught some bugs in earlier
2595         versions of this patch.
2596
2597         * Scripts/webkitpy/common/net/buildbot.py:
2598         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2599         * Scripts/webkitpy/common/net/regressionwindow.py: Added.
2600         * Scripts/webkitpy/tool/commands/queries.py:
2601
2602 2010-09-27  Eric Seidel  <eric@webkit.org>
2603
2604         Unreviewed.  Fixing 500 error seen in the status server.
2605
2606         It turns out that a = b = []; b.append(1); then a[0] will be 1!
2607         This should have been obvious to me, I guess, but it was not what I was expecting.
2608
2609         * QueueStatusServer/model/activeworkitems.py:
2610
2611 2010-09-27  Adam Barth  <abarth@webkit.org>
2612
2613         Reviewed by Eric Seidel.
2614
2615         commit-queue should reject patches that fail to land
2616         https://bugs.webkit.org/show_bug.cgi?id=46694
2617
2618         This can happen, for example, if there's no reviewer.  Without this
2619         patch, we'll keep retrying the patch.
2620
2621         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2622         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2623
2624 2010-09-27  Simon Fraser  <simon.fraser@apple.com>
2625
2626         Rubber-stamped by Adele Peterson.
2627
2628         Add a harness for running the CSS 2.1 test suite.
2629         
2630         This harness assumes that you've got a local a copy of the suite
2631         adjacent to the 'harness' directory.
2632         
2633         The harness lets you go through the tests in chapter order,
2634         denoting pass/fail/skipped for each test.
2635         
2636         It uses a client-side database to store the results of testing.
2637
2638         * CSSTestSuiteHarness/harness/harness.css: Added.
2639         * CSSTestSuiteHarness/harness/harness.html: Added.
2640         * CSSTestSuiteHarness/harness/harness.js: Added.
2641
2642 2010-09-27  Eric Seidel  <eric@webkit.org>
2643
2644         Reviewed by Adam Barth.
2645
2646         Patch locks should expire if a patch is marked for retry
2647         https://bugs.webkit.org/show_bug.cgi?id=46682
2648
2649         This was part Adam's original CommitQueueTask design,
2650         but support for it was missing from the server.
2651         I added the support, but triggering lock-release based on this
2652         special "retry" status feels a bit strange so I added a FIXME.
2653
2654         I also changed the text in queuestatus.html to say "Lock Acquired"
2655         since "Last Activity" isn't really true.  We only update the lock
2656         date when the patch is started, not on every status update.
2657
2658         I also noticed an exception in next-patch, which I fixed by re-writing
2659         the unzip logic in activeworkitems.py again.
2660
2661         * QueueStatusServer/handlers/updatestatus.py:
2662         * QueueStatusServer/model/activeworkitems.py:
2663         * QueueStatusServer/templates/queuestatus.html:
2664
2665 2010-09-27  Tony Chang  <tony@chromium.org>
2666
2667         Reviewed by David Levin.
2668
2669         [chromium] fix a warning when compiling DRT on 32-bit linux
2670         https://bugs.webkit.org/show_bug.cgi?id=46641
2671
2672         * DumpRenderTree/chromium/TestEventPrinter.cpp:
2673         (DRTPrinter::handleImage):
2674
2675 2010-09-27  Eric Seidel  <eric@webkit.org>
2676
2677         Reviewed by Adam Barth.
2678
2679         queue-status should report when the patch was last locked to a queue
2680         https://bugs.webkit.org/show_bug.cgi?id=46674
2681
2682         This isn't necessarily the best way to expose this information
2683         but having this accessible via the web interface is very
2684         useful until we come up with a nicer way to display this.
2685
2686         I also cleaned up the code in activeworkitems.py a little
2687         to use list comprehensions and to have the code work with
2688         pairs instead of two lists at once.  Eventually I think those
2689         item/time pairs need to be their own little helper class.
2690
2691         * QueueStatusServer/handlers/queuestatus.py:
2692         * QueueStatusServer/model/activeworkitems.py:
2693         * QueueStatusServer/templates/queuestatus.html:
2694
2695 2010-09-27  Tony Chang  <tony@chromium.org>
2696
2697         Reviewed by David Levin.
2698
2699         [chromium] fix detection of missing fonts on DRT
2700         https://bugs.webkit.org/show_bug.cgi?id=46651
2701
2702         * DumpRenderTree/chromium/TestShellGtk.cpp:
2703         (setupFontconfig):  Only print an error message if lohit isn't found in both locations.
2704
2705 2010-09-27  Tony Chang  <tony@chromium.org>
2706
2707         Reviewed by Dimitri Glazkov.
2708
2709         add webkit unit tests to the chromium testers
2710         https://bugs.webkit.org/show_bug.cgi?id=46669
2711
2712         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2713         * Scripts/run-chromium-webkit-unit-tests: Fix a bug where we weren't using the right configuration.
2714
2715 2010-09-27  Kwang Yul Seo  <skyul@company100.net>
2716
2717         Unreviewed.
2718
2719         Adding myself to the committers list.
2720
2721         * Scripts/webkitpy/common/config/committers.py:
2722
2723 2010-09-27  Mihai Parparita  <mihaip@chromium.org>
2724
2725         Reviewed by Eric Seidel.
2726
2727         webkitpy.common.system.user_unittest.UserTest.test_prompt_with_list spams the console
2728         https://bugs.webkit.org/show_bug.cgi?id=46634
2729         
2730         Use OutputCapture to prevent console spam (and also check for expected
2731         output).
2732
2733         * Scripts/webkitpy/common/system/user_unittest.py:
2734
2735 2010-09-27  Eric Seidel  <eric@webkit.org>
2736
2737         Reviewed by James Robinson.
2738
2739         start-commit-queue should abort any rebases in progress
2740         https://bugs.webkit.org/show_bug.cgi?id=46640
2741
2742         webkit-patch commit-queue would do this itself, but this just
2743         helps ensure that the commit-queue script is properly updated
2744         before we run it (in the case where a previous rebase is in
2745         progress the git svn rebase would not work before we run the
2746         commit-queue).
2747
2748         * EWSTools/start-commit-queue.sh:
2749
2750 2010-09-18  Martin Robinson  <mrobinson@igalia.com>
2751
2752         Reviewed by Gustavo Noronha Silva.
2753
2754         [GTK] Clean up the DRT fonts.conf and switch to Liberation
2755         https://bugs.webkit.org/show_bug.cgi?id=46038
2756
2757         Switch to Liberation fonts for GTK+ layout tests. This will make our
2758         test results metric-compatible with many Windows/Chromium results. It
2759         also simplifies the fonts.conf that we load and prepares the way for
2760         fixing many font bugs.
2761
2762         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2763         (initializeFonts): Initialize a known list of fonts instead of loading
2764         every font in the WEBKIT_TESTFONTS directory.
2765         * DumpRenderTree/gtk/fonts.conf: Removed.
2766         * DumpRenderTree/gtk/fonts/AHEM____.TTF: Copied from WebKitTools/DumpRenderTree/qt/fonts/AHEM____.TTF.
2767         * DumpRenderTree/gtk/fonts/fonts.conf: Added.
2768         * GNUmakefile.am: Modify FONTS_CONF_FILE to be FONTS_CONF_DIR, so that
2769         we can load both fonts.conf and AHEM____.TTF from this location.
2770         * Scripts/old-run-webkit-tests: Remove the check for WEBKIT_TESTFONTS, since
2771         it is no longer used.
2772
2773 2010-09-26  Mihai Parparita  <mihaip@chromium.org>
2774
2775         Reviewed by Ojan Vafai.
2776
2777         new-run-webkit-httpd fails if Perl is not installed
2778         https://bugs.webkit.org/show_bug.cgi?id=46602
2779         
2780         Make Port._read_configuration catch all exceptions, since trying to run
2781         perl (because of _webkit_build_directory) when it's not installed throws
2782         a WindowsError or OSError, not an IOError (this became an issue after 
2783         r68268, since ChromiumPort ends up calling Port.default_configuration in
2784         its constructor, which means that we're ending up on this codepath in
2785         non-NRWT cases too, e.g. for the Chromium NaCl tests, which use
2786         new-run-webkit-httpd).
2787
2788         * Scripts/webkitpy/layout_tests/port/base.py:
2789         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2790
2791 2010-09-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2792
2793         Reviewed by Antonio Gomes.
2794
2795         [EFL] Add setting API to set a local storage database path.
2796         https://bugs.webkit.org/show_bug.cgi?id=45446
2797
2798         Add a setting API to set local storage database path.
2799
2800         * EWebLauncher/main.c:
2801         (on_key_down):
2802         (browserCreate):
2803         (main):
2804
2805 2010-09-26  Sam Weinig  <sam@webkit.org>
2806
2807         Reviewed by Anders Carlsson.
2808
2809         Move shared WebKit2 API (used by both bundle and main API) to WebKit2/Shared/API
2810         https://bugs.webkit.org/show_bug.cgi?id=46587
2811
2812         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2813
2814 2010-09-26  Antonio Gomes  <agomes@rim.com>
2815
2816         Reviewed by Kenneth Rohde Christiansen.
2817
2818         DRT/Mac nodesFromRect support
2819
2820         [Mac][DRT] Implement LayoutTestController::nodesFromRect
2821         https://bugs.webkit.org/show_bug.cgi?id=46580
2822
2823         Implements LayoutTestController::nodesFromRect for Mac DRT, and
2824         adding stubs for GTK+ and Windows.
2825
2826         * DumpRenderTree/LayoutTestController.cpp:
2827         (nodesFromRectCallback):
2828         (LayoutTestController::staticFunctions):
2829         * DumpRenderTree/LayoutTestController.h:
2830         (LayoutTestController::LayoutTestController::nodesFromRect):
2831         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2832         (LayoutTestController::nodesFromRect):
2833
2834 2010-09-25  Nicolas Weber  <thakis@chromium.org>
2835
2836         Reviewed by Adam Barth.
2837
2838         https://bugs.webkit.org/show_bug.cgi?id=46555
2839         Fix typo in prepare-ChangeLog's help output.
2840
2841         * Scripts/prepare-ChangeLog:
2842
2843 2010-09-24  Sam Weinig  <sam@webkit.org>
2844
2845         Reviewed by Darin Adler.
2846
2847         Implement WebKit2 callback equivalent to -[WebUIDelegate mouseDidMoveOverElement:modifierFlags:]
2848         <rdar://problem/8359279>
2849         https://bugs.webkit.org/show_bug.cgi?id=46546
2850
2851         * MiniBrowser/mac/BrowserWindowController.m:
2852         (mouseDidMoveOverElement):
2853         (-[BrowserWindowController awakeFromNib]):
2854         * MiniBrowser/win/BrowserView.cpp:
2855         (mouseDidMoveOverElement):
2856         (BrowserView::create):
2857         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2858         (WTR::InjectedBundlePage::InjectedBundlePage):
2859         * WebKitTestRunner/TestController.cpp:
2860         (WTR::createOtherPage):
2861         (WTR::TestController::initialize):
2862
2863 2010-09-24  Mihai Parparita  <mihaip@chromium.org>
2864
2865         Reviewed by Adam Barth.
2866
2867         Allow rebaselines for webkit-patch rebaseline to be chosen
2868         https://bugs.webkit.org/show_bug.cgi?id=46407
2869         
2870         Instead of always rebaselining all failing tests, allow a subset to be
2871         chosen.
2872
2873         * Scripts/webkitpy/common/system/user.py:
2874         * Scripts/webkitpy/tool/commands/rebaseline.py:
2875
2876 2010-09-24  Ryosuke Niwa  <rniwa@webkit.org>
2877
2878         Reviewed by Tony Chang.
2879
2880         [chromium] Implement TextInputController::firstRectForCharacterRange
2881         https://bugs.webkit.org/show_bug.cgi?id=38100
2882
2883         Implemented TextInputController::firstRectForCharacterRange for chromium platform.
2884         No new tests are added since we need to implement the same feature in chromium side
2885         in order to enable any tests that uses this function.
2886
2887         * DumpRenderTree/chromium/TextInputController.cpp:
2888         (TextInputController::firstRectForCharacterRange): Added.
2889
2890 2010-09-24  Adam Barth  <abarth@webkit.org>
2891
2892         Reviewed by Eric Seidel.
2893
2894         commit-queue reports land failures as "PASS"
2895         https://bugs.webkit.org/show_bug.cgi?id=46530
2896
2897         We were ignoring the return value of land instead of passing it back to
2898         CommitQueue.  Of course, this was the one case I forgot to test!
2899
2900         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2901         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2902
2903 2010-09-24  Kenichi Ishibashi  <bashi@google.com>
2904
2905         Reviewed by Eric Seidel.
2906
2907         new-run-webkit-tests prints out nothing when build-dumprendertree fails
2908         https://bugs.webkit.org/show_bug.cgi?id=37563
2909
2910         Print error message when build-dumprendertree fails.
2911
2912         * Scripts/webkitpy/layout_tests/port/webkit.py:
2913         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2914
2915 2010-09-24  Mihai Parparita  <mihaip@chromium.org>
2916
2917         Reviewed by Tony Chang.
2918
2919         NRWT doesn't respect config set with set-webkit-configuration
2920         https://bugs.webkit.org/show_bug.cgi?id=46278
2921         
2922         Use Port.default_configuration() instead of hardcoding Release in
2923         ChromiumPort configuration initialization, so that we still inherit the
2924         configuration set by set-webkit-configuration.
2925
2926         * Scripts/webkitpy/layout_tests/port/chromium.py:
2927         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2928
2929 2010-09-24  Chang Shu  <chang.shu@nokia.com>
2930
2931         Reviewed by Csaba Osztrogonác.
2932
2933         [Qt] Fix the code to check file existence.
2934         https://bugs.webkit.org/show_bug.cgi?id=46465
2935
2936         * QtTestBrowser/main.cpp:
2937         (main):
2938
2939 2010-09-23  Tony Chang  <tony@chromium.org>
2940
2941         Unreviewed, rolling out r68232.
2942         http://trac.webkit.org/changeset/68232
2943
2944         Broken NRWT on the canary bots.
2945
2946         * Scripts/webkitpy/layout_tests/port/chromium.py:
2947
2948 2010-09-23  Dirk Pranke  <dpranke@chromium.org>
2949
2950         Unreviewed, build fix.
2951
2952         r68008 broke new-run-webkit-tests in that the chromium ports no
2953         longer respect set-webkit-configuration. The correct fix for this
2954         is being pursued in bug 46278 (along with a bunch of unit tests),
2955         but in the meantime I'm reverting the particular lines that broke
2956         things. This was tested by hand.
2957
2958         * Scripts/webkitpy/layout_tests/port/chromium.py:
2959
2960 2010-09-23  Sam Weinig  <sam@webkit.org>
2961
2962         Reviewed by Anders Carlsson.
2963
2964         WebKit2 API: Need way to know when a frame is removed from the hierarchy
2965         <rdar://problem/8414062>
2966         https://bugs.webkit.org/show_bug.cgi?id=46432
2967
2968         * MiniBrowser/mac/BrowserWindowController.m:
2969         (didRemoveFrameFromHierarchy):
2970         (-[BrowserWindowController awakeFromNib]):
2971         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2972         (WTR::InjectedBundlePage::InjectedBundlePage):
2973         * WebKitTestRunner/TestController.cpp:
2974         (WTR::TestController::initialize):
2975
2976 2010-09-23  Tony Chang  <tony@chromium.org>
2977
2978         Reviewed by Dimitri Glazkov.
2979
2980         [chromium] implement layoutTestController.sampleSVGAnimationForElementAtTime
2981         https://bugs.webkit.org/show_bug.cgi?id=46426
2982
2983         * DumpRenderTree/chromium/LayoutTestController.cpp:
2984         (LayoutTestController::LayoutTestController):
2985         (LayoutTestController::sampleSVGAnimationForElementAtTime):
2986         * DumpRenderTree/chromium/LayoutTestController.h:
2987
2988 2010-09-23  Martin Robinson  <mrobinson@igalia.com>
2989
2990         Reviewed by Nate Chapin.
2991
2992         [GTK] r68199 introduced two test failures
2993         https://bugs.webkit.org/show_bug.cgi?id=46424
2994
2995         Fix a regression handling preference overrides that are attached to boolean properties.
2996
2997         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2998         (LayoutTestController::overridePreference): g_strcasecmp returns 0 when strings match
2999         so we must check for that when converting a string to a boolean.
3000
3001 2010-09-23  Dimitri Glazkov  <dglazkov@chromium.org>
3002
3003         Reviewed by David Levin.
3004
3005         Fix a condition check in ServerProcess, which becomes relevant when reading binary data.
3006         https://bugs.webkit.org/show_bug.cgi?id=46406
3007
3008         This breaks when the method is called with specified size of data (image data), and the
3009         buffer hasn't yet reached this size.
3010
3011         * Scripts/webkitpy/layout_tests/port/server_process.py: Changed to check for values of
3012           index larger than 0.
3013
3014 2010-09-23  Martin Robinson  <mrobinson@igalia.com>
3015
3016         Reviewed by Nate Chapin.
3017
3018         [GTK] Some tests from r68174 fail on the GTK+ bots
3019         https://bugs.webkit.org/show_bug.cgi?id=46396
3020
3021         Simplify LayoutTestController::overridePreference to make it easier for
3022         people unfamiliar with the code to keep the list of preferences up to date.
3023         Add the conversion for enable-hyperlink-auditing.
3024
3025         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3026         (LayoutTestController::overridePreference): Use a simple if-else block to determine
3027         out the property name for overrridePreference. Also simplify the logic for setting
3028         string properties. Add the conversion for enable-hyperlink-auditing.
3029
3030 2010-09-23  Tony Chang  <tony@chromium.org>
3031
3032         Reviewed by David Levin.
3033
3034         [chromium] add caretBrowsingEnabled to WebSettings and DRT
3035         https://bugs.webkit.org/show_bug.cgi?id=46388
3036
3037         * DumpRenderTree/chromium/LayoutTestController.cpp:
3038         (LayoutTestController::overridePreference):
3039         * DumpRenderTree/chromium/WebPreferences.cpp:
3040         (WebPreferences::reset):
3041         (WebPreferences::applyTo):
3042         * DumpRenderTree/chromium/WebPreferences.h:
3043
3044 2010-09-23  Nate Chapin  <japhet@chromium.org>
3045
3046         Reviewed by Darin Fisher.
3047
3048         Allow DRT to toggle hyperlink auditing (i.e., <a ping>).
3049         https://bugs.webkit.org/show_bug.cgi?id=30458
3050
3051         * DumpRenderTree/chromium/LayoutTestController.cpp:
3052         (LayoutTestController::overridePreference):
3053         * DumpRenderTree/chromium/WebPreferences.cpp:
3054         (WebPreferences::reset):
3055         (WebPreferences::applyTo):
3056         * DumpRenderTree/chromium/WebPreferences.h:
3057         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3058         (resetDefaultsToConsistentValues):
3059         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3060         (LayoutTestController::overridePreference):
3061
3062 2010-09-21  Stephen White  <senorblanco@chromium.org>
3063
3064         Reviewed by David Levin.
3065
3066         Implement --enable-accelerated-2d-canvas flag in DumpRenderTree.
3067         https://bugs.webkit.org/show_bug.cgi?id=46208
3068
3069         This flag allows the layout tests to be run with or without accelerated
3070         2D canvas rendering.
3071
3072         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3073         (main):
3074         Declare the new flag string, and check for it on startup.
3075         * DumpRenderTree/chromium/TestShell.cpp:
3076         (TestShell::TestShell):
3077         Add a boolean for the new flag, in order to preserve its value over
3078         preferences reset.
3079         (TestShell::resetWebSettings):
3080         Set the new flag to the stored value on reset.
3081         * DumpRenderTree/chromium/TestShell.h:
3082         (TestShell::setAccelerated2dCanvasEnabled):
3083         Add an accessor for the new flag.
3084         * DumpRenderTree/chromium/WebPreferences.cpp:
3085         (WebPreferences::reset):
3086         Initialize the new flag to false.
3087         (WebPreferences::applyTo):
3088         Copy the flag's value to the WebSettings.
3089         * DumpRenderTree/chromium/WebPreferences.h:
3090         Add the new flag.
3091
3092 2010-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3093
3094         Reviewed by Simon Hausmann.
3095
3096         [Qt] Refactor QtWebKitPlatformPlugin interface
3097
3098         Make it easier to keep source-compability for the
3099         QtWebKitPlatformPlugin interface, and run qmake
3100         on the example (but not build) for convenience. 
3101
3102         https://bugs.webkit.org/show_bug.cgi?id=46345
3103
3104         * Scripts/webkitdirs.pm:
3105
3106 2010-09-23  Adam Barth  <abarth@webkit.org>
3107
3108         Reviewed by Eric Seidel.
3109
3110         Tweak some status messages that Eric thought were confusing
3111         https://bugs.webkit.org/show_bug.cgi?id=46342
3112
3113         * Scripts/webkitpy/tool/commands/queues.py:
3114         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3115
3116 2010-09-22  Adam Barth  <abarth@webkit.org>
3117
3118         Reviewed by Eric Seidel.
3119
3120         Fix comm-queue typo
3121         https://bugs.webkit.org/show_bug.cgi?id=46339
3122
3123         We were missing a "self".  The real problem is that we didn't have an
3124         integration test for the failure case.
3125
3126         * Scripts/webkitpy/tool/commands/queues.py:
3127         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3128
3129 2010-09-22  Adam Barth  <abarth@webkit.org>
3130
3131         Reviewed by Eric Seidel.
3132
3133         commit-queue should log more detailed messages to the QueueStatusServer
3134         https://bugs.webkit.org/show_bug.cgi?id=46333
3135
3136         When I created CommitQueueTask, I removed most of the previous logging.
3137         This patch adds back more detailed logging so folks can see their patch
3138         progress through the queue.
3139
3140         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3141         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3142         * Scripts/webkitpy/tool/commands/queues.py:
3143         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3144
3145 2010-09-22  Mihai Parparita  <mihaip@chromium.org>
3146
3147         Reviewed by Darin Fisher.
3148
3149         [Chromium] User style layout tests don't pass on Chromium
3150         https://bugs.webkit.org/show_bug.cgi?id=46069
3151
3152         Fix a typo in LayoutTestController::addUserStyleSheet that was causing a
3153         crash the Chromium DRT. Pass InjectInExistingDocuments to mimic DRT
3154         behavior from other ports.
3155
3156         * DumpRenderTree/chromium/LayoutTestController.cpp:
3157         (LayoutTestController::addUserStyleSheet):
3158
3159 2010-09-22  Brent Fulgham  <bfulgham@webkit.org>
3160
3161         Reviewed by Martin Robinson.
3162
3163         [WinCairo] Part 2: Update WebKitTestRunner and DumpRenderTree Build.
3164         https://bugs.webkit.org/show_bug.cgi?id=46303.
3165
3166         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added.
3167         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Moved
3168         CoreFoundation-specific stuff to new MiniBrowserCoreFoundation
3169         property sheet.
3170         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added.
3171         * MiniBrowser/MiniBrowser.vcproj: Updated configuration to use
3172         appropriate property sheet for the build types.
3173         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Updated the
3174         configuration to use appropriate property sheet for CoreFoundation
3175         and CFLite-style builds.
3176
3177 2010-09-22  Adam Barth  <abarth@webkit.org>
3178
3179         Reviewed by Eric Seidel.
3180
3181         Optimize commit-queue performance for green trees
3182         https://bugs.webkit.org/show_bug.cgi?id=46254
3183
3184         This patch redesigns the controller logic for the commit-queue.  In the
3185         new design, the controller exercises much finer-grained control over
3186         the landing process.  In particular:
3187
3188         - Patches that fail to apply now get rejected almost immediately.
3189         - Patches that fail to build get rejects after two builds (instead of
3190           three builds and one test run).
3191         - Patches that run into a flaky test now get accepted after one build
3192           and two test runs instead of three full build-and-test runs.
3193
3194         The main cost of these optimizations is that we don't find out the tree
3195         has a failing test until the very end of the process, but if the tree
3196         has a busted test, there's not much we can do anyway.  We might as well
3197         burn commit-queue resources spinning optimisticly.
3198
3199         * Scripts/webkitpy/tool/bot/commitqueuetask.py: Added.
3200         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: Added.
3201         * Scripts/webkitpy/tool/commands/queues.py:
3202
3203 2010-09-22  Brent Fulgham  <bfulgham@webkit.org>
3204
3205         Reviewed by Martin Robinson.
3206
3207         [WinCairo] Update WebKitTestRunner and DumpRenderTree Build.
3208         https://bugs.webkit.org/show_bug.cgi?id=46303.
3209
3210         * DumpRenderTree/win/DumpRenderTree.vcproj: Disable local MD5 sources
3211         for Cairo build. Copy wtf MD5 header to ForwardingHeaders for the
3212         WinCairo build.
3213         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added.
3214         * WebKitTestRunner/win/InjectedBundle.vcproj: Update win new *_Cairo
3215         build targets that use the new InjectedBundleCFLite.vsprops file.
3216
3217 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
3218
3219         Unreviewed, build fix.
3220
3221         Fix bustage of rebaseline-chromium-webkit-tests resulting from
3222         r67974. Really need better unit tests for this tool :(
3223
3224         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3225
3226 2010-09-22  Adam Roben  <aroben@apple.com>
3227
3228         Unbreak test-webkitpy
3229
3230         * Scripts/webkitpy/test/main.py:
3231         (Tester.run_tests): Add a line that mysteriously got deleted.
3232
3233 2010-09-22  Adam Roben  <aroben@apple.com>
3234
3235         Make test-webkitpy test WebKit2's scripts
3236
3237         These scripts can't be in WebKitTools due to limitations of Apple's
3238         build process. But that doesn't mean we can't test them!
3239
3240         Fixes <http://webkit.org/b/46297> test-webkitpy should test code in
3241         WebKit2/Scripts
3242
3243         Reviewed by Adam Barth.
3244
3245         * Scripts/test-webkitpy:
3246         (_clean_packages_with_test): Renamed from _clean_webkitpy_with_test.
3247         Now takes an external_package_paths parameter and cleans both webkitpy
3248         and any external packages.
3249         (init): Added an external_package_paths parameter which we pass along
3250         to _clean_packages_with_test.
3251         (top level): Add WebKit2/Scripts/webkit2 as our only external package
3252         and pass it along to init and Tester.run_tests.
3253
3254         * Scripts/webkitpy/test/main.py:
3255         (Tester.run_tests): Added an optional external_package_paths
3256         parameter. We modify sys.path so that the external packages can be
3257         imported, and search for unittest files inside all external packages
3258         in addition to inside webkitpy.
3259
3260 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
3261
3262         Reviewed by Tony Chang.
3263
3264         new-run-webkit-tests: r68063 broke linux python tests
3265
3266         Add a missing "from __future__ import with_statement" to this
3267         new file; the perils of testing only on the Mac and by review :(
3268
3269         https://bugs.webkit.org/show_bug.cgi?id=46293
3270
3271         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3272
3273 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
3274
3275         Reviewed by Tony Chang.
3276
3277         Add a 'chromium-gpu' set of ports that will test the accelerated
3278         GPU paths. This patch adds:
3279
3280         - support for the '--accelerated-compositing' and
3281           'accelerated-2d-canvas' flags to new-run-webkit-tests (and the
3282           'no-' flags)
3283         - adds a new set of Ports that will look under
3284           platform/chromium-gpu-$OS/ for baselines before looking in the
3285           regular chromium search path
3286         - adds a new test_expectations.txt file in platform/chromium-gpu
3287           that skips all but the tests we actually want to run with
3288           acceleration.
3289
3290         This patch will allow us to run both with and without acceleration
3291         and to change the defaults for both the regular and -gpu options
3292         as the code evolves.
3293
3294         We plan to add both --chromium-$OS and --chromium-gpu-$OS runs to
3295         each test bot.
3296
3297         https://bugs.webkit.org/show_bug.cgi?id=46225
3298
3299         * Scripts/webkitpy/layout_tests/port/chromium.py:
3300         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3301         * Scripts/webkitpy/layout_tests/port/factory.py:
3302         * Scripts/webkitpy/layout_tests/port/webkit.py:
3303
3304 2010-09-22  Jamey Hicks  <jamey.hicks@nokia.com>
3305
3306         Reviewed by Kenneth Rohde Christiansen.
3307
3308         [Qt] Web Inspector: Remote Web Inspector support for QtWebKit
3309         https://bugs.webkit.org/show_bug.cgi?id=43988
3310
3311         Runs a web debug server on port specified by QtTestBrowser
3312         argument -remote-inspector-port. Property
3313         _q_webInspectorServerPort of the QWebPage instance will be set
3314         according to the argument. All pages with that property set will
3315         be remotely inspectable.
3316
3317         URL for remote inspection of first QWebPage is
3318             http://localhost:9222/webkit/inspector/inspector.html?page=1
3319         where 1 is the number of the QWebPage instance.
3320
3321         The base URL yields an index page with links to the individual inspectors:
3322             http://localhost:9222/
3323
3324         * QtTestBrowser/launcherwindow.cpp:
3325         (LauncherWindow::init):
3326         * QtTestBrowser/launcherwindow.h:
3327         * QtTestBrowser/main.cpp:
3328         (LauncherApplication::handleUserOptions):
3329
3330 2010-09-22  Adam Roben  <aroben@apple.com>
3331
3332         Fix webkit-patch failure-reason now that build.webkit.org has been
3333         updated
3334
3335         Fixes <http://webkit.org/b/46273> webkit-patch failure-reason crashes
3336         every time
3337
3338         Reviewed by Eric Seidel.
3339
3340         * Scripts/webkitpy/common/net/buildbot.py:
3341         (BuildBot._file_cell_text): Added. Travels down the firstChild chain
3342         looking for an element that contains text, then returns it.
3343         (BuildBot._parse_twisted_file_row): Use _file_cell_text to get the
3344         text out of the cells. This way it doesn't matter whether the cells
3345         have <b> children (as for cells in directory rows) or not (as for
3346         cells in file rows)
3347         (BuildBot._parse_twisted_directory_listing): Look for rows that have
3348         the "directory" or "file" class, rather than rows with any class,
3349         since header rows now have a class attribute.
3350
3351         * Scripts/webkitpy/common/net/buildbot_unittest.py:
3352         (BuildBotTest._example_directory_listing): Updated to more closely
3353         match the markup that build.webkit.org is producing now.
3354
3355 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
3356
3357         Unreviewed, build fix.
3358
3359         new-run-webkit-tests: fix bug introduced in r68008 where if you
3360         specify --chromium and no --platform, and you're running on
3361         windows, you use the 'chromium-win' port by default instead of the
3362         version-specific port. This breaks the buildbots.
3363
3364         It will be good for this refactoring to settle down so I can
3365         rewrite the logic for default ports and the unit tests to be
3366         clearer (and the testing more comprehensive).
3367
3368         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3369
3370 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
3371
3372         Reviewed by Adam Barth.
3373
3374         Modify the Port interface to take only a series of keyword arguments
3375         in the constructor, and modify Port/factory.get() to accomodate that,
3376         and to accept user=XXX as an argument so we can pass
3377         webkitpy.common.system.user.User objects in.
3378
3379         Then, modify new-run-webkit-tests and rebaseline-chromium-webkit-tests
3380         to use the common routine in webkitpy.common.system.user.open_url()
3381         to display HTML files.
3382
3383         There was a routine in the Port interface to do the same thing,
3384         but I see no need for a port-specific hook for this, since it is
3385         something that will always be executed by the host environment
3386         and displaying web pages has nothing to do with running layout tests.
3387
3388         Note that new-run-webkit-tests used to use test_shell to display
3389         the page; this is potentially useful so that you can actually click
3390         from a result to the broken page; however, since DumpRenderTree
3391         doesn't support this functionality, it will be going away eventually.
3392
3393         https://bugs.webkit.org/show_bug.cgi?id=46128
3394
3395         * Scripts/webkitpy/layout_tests/port/base.py:
3396         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3397         * Scripts/webkitpy/layout_tests/port/chromium.py:
3398         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3399         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3400         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3401         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3402         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3403         * Scripts/webkitpy/layout_tests/port/factory.py:
3404         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3405         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3406         * Scripts/webkitpy/layout_tests/port/gtk.py:
3407         * Scripts/webkitpy/layout_tests/port/mac.py:
3408         * Scripts/webkitpy/layout_tests/port/qt.py:
3409         * Scripts/webkitpy/layout_tests/port/test.py:
3410         * Scripts/webkitpy/layout_tests/port/webkit.py:
3411         * Scripts/webkitpy/layout_tests/port/win.py:
3412         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3413         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3414         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3415
3416 2010-09-21  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3417
3418         Reviewed by Kenneth Rohde Christiansen.
3419
3420         [EFL] Get fresh theme when running EWebLauncher
3421         https://bugs.webkit.org/show_bug.cgi?id=46210
3422
3423         If user tried to run EWebLauncher outside of the build tree, it would
3424         not find the theme and fallback to the installed one. However, since
3425         EWebLauncher is not installed, we always want to take the theme from
3426         the just compiled source code. If user had never installed WebKit's
3427         EFL port it could even receive a segv since no theme would be found.
3428
3429         Now EWebLauncher does not fallback to the installed theme and CMake
3430         gives as DATA_DIR the directory of the theme it has just built.
3431
3432         * CMakeListsEfl.txt: Pass the build directory as DATA_DIR to
3433         EWebLauncher.
3434         * EWebLauncher/main.c: Use only the theme from build director. Do not
3435         fallback to others as this could hide real bugs.
3436         (quit):
3437         (browserCreate):
3438         (findThemePath):
3439         (main):
3440
3441 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
3442
3443         Unreviewed, build fix.
3444
3445         Don't pass the --test-shell arg to the Chromium Mac port of DRT;
3446         it just confuses it.
3447
3448         https://bugs.webkit.org/show_bug.cgi?id=46230
3449
3450         * Scripts/webkitpy/layout_tests/port/webkit.py:
3451
3452 2010-09-21  Lucas Forschler  <lforschler@apple.com>
3453
3454         Reviewed by Stephanie Lewis.
3455
3456         Make a new buildbot for Leopard Debug Test
3457
3458         * BuildSlaveSupport/build.webkit.org-config/config.json:
3459
3460 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
3461
3462         Unreviewed, build fix.
3463
3464         Fix breakage of Chromium Mac DRT port caused by r67905.
3465
3466         https://bugs.webkit.org/show_bug.cgi?id=46230
3467
3468         * Scripts/webkitpy/layout_tests/port/webkit.py:
3469
3470 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
3471
3472         Unreviewed, build fix.
3473
3474         Add missing import of 'tempfile'.
3475
3476         * Scripts/webkitpy/layout_tests/port/chromium.py:
3477
3478 2010-09-17  Dirk Pranke  <dpranke@chromium.org>
3479
3480         Reviewed by Ojan Vafai.
3481
3482         new-run-webkit-tests: pull the list of tests from the Port, and
3483            make it possible to run with no actual test files in the filesystem.
3484
3485         This set of changes allows us to delete the special
3486         webkitpy/layout_tests/data directory and test the generic code without
3487         touching the filesystem (except to write results). This speeds up
3488         test-webkitpy substantially.
3489
3490         This also cleans up and removes several code paths in the generic
3491         code and fixes some minor bugs, notably in the test_expectations
3492         parsing, which was previously fragile if the tests weren't present.
3493
3494         We also change the way we diff image results to be able to do so
3495         in memory, without relying on files. This slows down chromium
3496         test_shell, which always writes images to files, but should speed
3497         up DRT and ImageDiff-based implementations slightly.
3498
3499         Note that pulling the list of tests to run from the Port will allow
3500         ports to specify what tests to run as an inclusive list; previously
3501         you could only do this as an exclusive list by using a 
3502         test_expectations file or Skipped files; nothing actually uses this
3503         feature yet and it's unclear if it should be used.
3504
3505         Note that there are no functional changes -- apart from now 
3506         always printing out the location of the checksum file when we are
3507         tracing test runs -- and the total number of lines of non-test code
3508         actually drops by two.
3509
3510         There is some more cleanup that can be done in the Port/Driver 
3511         interface and in some handling of filenames, but I'll save that
3512         for another change.
3513
3514         https://bugs.webkit.org/show_bug.cgi?id=45801
3515
3516         * Scripts/webkitpy/layout_tests/data/*: Removed.
3517             - no longer need special mock layout_tests_directory in the
3518               repository.
3519         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3520             - add code to display missing text files, checksums when tracing
3521             - update to not look at the filesystem directly.
3522         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3523             - add more unit tests
3524         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3525             - remove tests_are_present flag
3526             - update with changes in Port interface - no longer access
3527               the filesystem directly, although we still use os.path for
3528               filename manipulation.
3529         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3530             - add more unit tests
3531         * Scripts/webkitpy/layout_tests/layout_package/test_files.py: Removed.
3532             - renamed to port/test_files.py
3533         * Scripts/webkitpy/layout_tests/port/base.py:
3534             - change diff_image() to expect actual image data, not filenames
3535             - add expected_checksum(), expected_image(), expected_text() to
3536               return the content of the files so that we don't need a filesystem
3537             - add path_exists(), path_isdir() for filesystem-like access.
3538             - add test_dirs() to keep clobber-test-results from needing to
3539               actually look at a real layout tests dir
3540             - add tests() to return the list of tests to run on the port
3541               (calls port/test_files to do the work).
3542             - add update_baseline() to be able to save new baselines
3543             - add uri_to_test_name() from port/dryrun.py so we can easily check
3544               filename_to_uri()
3545         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3546             - add more unit tests
3547         * Scripts/webkitpy/layout_tests/port/chromium.py:
3548             - change diff_image() to accept image content, not filenames.
3549               This will be slower for test_shell/image_diff, but faster
3550               for DRT/ImageDiff.
3551         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3552             - add more unit tests
3553         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3554             - simplify greatly
3555         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3556             - add more unit tests
3557         * Scripts/webkitpy/layout_tests/port/test.py:
3558             - massive rewrite to use in-script list of tests and expectations
3559         * Scripts/webkitpy/layout_tests/port/test_files.py:
3560             - rename from layout_package/test_files.
3561         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
3562             - add unit tests
3563         * Scripts/webkitpy/layout_tests/port/webkit.py:
3564             - update diff_image() to take image contents, not files. Should
3565               make things slightly faster.
3566         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3567             - update with changes to diff_image()
3568         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
3569             - update with changes to diff_image()
3570         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3571             - remove tests_are_present from test_expectations
3572             - pull the list of tests from port.tests() instead
3573               of calling test_files.py directly.
3574         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3575             - update unit tests
3576         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
3577             - update with changes to 
3578         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
3579             - update with change in Port interface
3580         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3581             - update with change in Port interface
3582         * Scripts/webkitpy/style/checkers/test_expectations.py:
3583             - remove the tests_are_present flag
3584
3585 2010-09-21  Anders Carlsson  <andersca@apple.com>
3586
3587         Disable logging.
3588
3589         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
3590
3591 2010-09-21  Tony Chang  <tony@chromium.org>
3592
3593         Reviewed by Kent Tamura.
3594
3595         add a script for running webkit_unit_tests
3596         https://bugs.webkit.org/show_bug.cgi?id=46014
3597
3598         * Scripts/run-chromium-webkit-unit-tests: Added.
3599
3600 2010-09-21  Fridrich Strba  <fridrich.strba@bluewin.ch>
3601
3602         Reviewed by Martin Robinson.
3603
3604         Fix linking problems on Windows.
3605         https://bugs.webkit.org/show_bug.cgi?id=45844
3606
3607         * GNUmakefile.am: link the executables with winmm.dll
3608
3609 2010-09-21  Adam Barth  <abarth@webkit.org>
3610
3611         Reviewed by Eric Seidel.
3612
3613         feeder-queue svn updates more often than needed
3614         https://bugs.webkit.org/show_bug.cgi?id=46171
3615
3616         We don't need to poll SVN every time we feed the feeders.  Rather, we
3617         can count on the wrapper shell script to auto-update the queue.
3618
3619         * Scripts/webkitpy/tool/commands/queues.py:
3620         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3621
3622 2010-09-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3623
3624         Reviewed by Andreas Kling.
3625
3626         [Qt] Add robot loader timeout and extra time options.
3627         https://bugs.webkit.org/show_bug.cgi?id=46172
3628
3629         [-robot-timeout <s>]: Load the next page after s seconds if the current
3630         page didn't finish loading.
3631         [-robot-extra-time <s>]: Wait s seconds after the current page finished
3632         loading before loading the next one. This should allow some time for the
3633         page's JavaScript to execute.
3634
3635         * QtTestBrowser/launcherwindow.cpp:
3636         (LauncherWindow::applyPrefs):
3637         * QtTestBrowser/main.cpp:
3638         (LauncherApplication::robotTimeout):
3639         (LauncherApplication::robotExtraTime):
3640         (LauncherApplication::LauncherApplication):
3641         (LauncherApplication::handleUserOptions):
3642         (main):
3643         * QtTestBrowser/urlloader.cpp:
3644         (UrlLoader::UrlLoader):
3645         (UrlLoader::loadNext):
3646         (UrlLoader::loadUrlList):
3647         * QtTestBrowser/urlloader.h:
3648
3649 2010-09-21  Pavel Podivilov  <podivilov@chromium.org>
3650
3651         Unreviewed.
3652
3653         Adding myself to the committers list.
3654
3655         * Scripts/webkitpy/common/config/committers.py:
3656
3657 2010-09-20  Philippe Normand  <pnormand@igalia.com>
3658
3659         Reviewed by Eric Carlson.
3660
3661         [GTK] enhanced context menu for media elements
3662         https://bugs.webkit.org/show_bug.cgi?id=45021
3663
3664         EventSender::contextClick() now returns an array of js
3665         objects. Each object has a title property and a click() method.
3666
3667         * DumpRenderTree/gtk/EventSender.cpp:
3668         (getMenuItemTitleCallback):
3669         (setMenuItemTitleCallback):
3670         (menuItemClickCallback):
3671         (getMenuItemClass):
3672         (contextClickCallback):
3673
3674 2010-09-20  Hayato Ito  <hayato@chromium.org>
3675
3676         Unreviewed.
3677         Adding myself to the committers list.
3678
3679         * Scripts/webkitpy/common/config/committers.py:
3680
3681 2010-09-20  Adam Barth  <abarth@webkit.org>
3682
3683         Reviewed by Eric Seidel.
3684
3685         The tool member variable should be called _tool
3686         https://bugs.webkit.org/show_bug.cgi?id=46160
3687
3688         Created by find-and-replace.
3689
3690         * Scripts/webkitpy/tool/commands/download.py:
3691         * Scripts/webkitpy/tool/commands/openbugs.py:
3692         * Scripts/webkitpy/tool/commands/queries.py:
3693         * Scripts/webkitpy/tool/commands/queues.py:
3694         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3695         * Scripts/webkitpy/tool/commands/rebaseline.py:
3696         * Scripts/webkitpy/tool/commands/sheriffbot.py:
3697         * Scripts/webkitpy/tool/commands/upload.py:
3698         * Scripts/webkitpy/tool/multicommandtool.py:
3699
3700 2010-09-20  Adam Barth  <abarth@webkit.org>
3701
3702         I ran the tests before landing but ignored the fact that they failed.  :(
3703
3704         * Scripts/webkitpy/tool/commands/queues.py:
3705
3706 2010-09-20  Adam Barth  <abarth@webkit.org>
3707
3708         Reviewed by Eric Seidel.
3709
3710         Add a feeder queue that polls bugs.webkit.org for the commit-cluster
3711         https://bugs.webkit.org/show_bug.cgi?id=46141
3712
3713         The feeder-queue polls bugs.webkit.org every 30 seconds and updates the
3714         list of work items on the status server.  The individual commit-cluster
3715         nodes then grab the patches from the server and process them.
3716
3717         * Scripts/webkitpy/tool/bot/feeders.py: Added.
3718         * Scripts/webkitpy/tool/bot/feeders_unittest.py: Added.
3719         * Scripts/webkitpy/tool/commands/queues.py:
3720         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3721         * Scripts/webkitpy/tool/commands/queuestest.py:
3722
3723 2010-09-20  Leandro Pereira  <leandro@profusion.mobi>
3724
3725         Reviewed by Darin Adler.
3726
3727         build-webkit: Add support for CMake build system
3728         https://bugs.webkit.org/show_bug.cgi?id=44979
3729
3730         * Scripts/build-webkit: Add "--efl" command-line option to build the
3731         EFL port of WebKit.
3732         * Scripts/webkitdirs.pm: Define buildCMakeProject() and
3733         buildEflCMakeProject() subroutines.
3734
3735 2010-09-20  Dirk Pranke  <dpranke@chromium.org>
3736
3737         Reviewed by Ojan Vafai.
3738
3739         new-run-webkit-tests: refactor command line args getting passed to DRT
3740
3741         This change cleans up some argument parsing between functions to get
3742         rid of some overlapping data structures. There should be no functional
3743         changes in this patch; it is pure refactoring in preparation for
3744         landing the Chrome GPU port and adding a generic way to pass
3745         args to DRT/TestShell.
3746
3747         https://bugs.webkit.org/show_bug.cgi?id=46135
3748
3749         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3750           - pass the options argument explicitly to the threads and drivers,
3751             also consolidate the passing of options to the driver.
3752           - pass options directly to process_output() to remove a couple
3753             parameters (minor cleanup).
3754         * Scripts/webkitpy/layout_tests/port/base.py:
3755           - pass the options argument to Port.create_driver().
3756         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3757           - update Port.create_driver() test
3758         * Scripts/webkitpy/layout_tests/port/chromium.py:
3759           - pass the options argument to Port.create_driver(), and clean up
3760             building of the cmd line for DRT.
3761         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3762           - pass the options argument to Port.create_driver()
3763         * Scripts/webkitpy/layout_tests/port/test.py:
3764           - pass the options argument to Port.create_driver()
3765         * Scripts/webkitpy/layout_tests/port/webkit.py:
3766           - pass the options argument to Port.create_driver(), and clean up
3767             building of the cmd line for DRT.
3768         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3769           - consolidate args in _get_dump_render_tree_args and rename to
3770             _get_test_args(); move all of the command-line args to the
3771             Port implementations.
3772
3773 2010-09-20  Andrew Wilson  <atwilson@chromium.org>
3774
3775         Revert change which was accidentally committed along with some expectation changes.
3776
3777         * Scripts/webkitpy/layout_tests/port/base.py:
3778
3779 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
3780
3781         Reviewed by Adam Barth.
3782
3783         Add explicit --force-patch flag to webkitpy tools
3784         https://bugs.webkit.org/show_bug.cgi?id=46103
3785         
3786         It wasn't obvious until I read the applypatch.py source code that
3787         --non-interfactive implies passing --force to patch. Add --force-patch
3788         as an alias to the flag, so that this behavior is more discoverable.
3789
3790         * Scripts/webkitpy/tool/steps/applypatch.py:
3791         * Scripts/webkitpy/tool/steps/options.py:
3792
3793 2010-09-20  Eric Seidel  <eric@webkit.org>
3794
3795         Unreviewed, adding a line which got dropped and is trivially correct (and tested).
3796
3797         commit-queue can't land patches
3798         https://bugs.webkit.org/show_bug.cgi?id=46138
3799
3800         Add a line of code I forgot in my last commit.
3801
3802         * Scripts/webkitpy/common/net/bugzilla.py:
3803         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
3804
3805 2010-09-20  Adam Barth  <abarth@webkit.org>
3806
3807         Reviewed by Eric Seidel.
3808
3809         The commit-cluster bots still race to lock patch_ids
3810         https://bugs.webkit.org/show_bug.cgi?id=46130
3811
3812         It turns out we need to use a transaction object to make the
3813         read/modify/write lock operation atomic.  From reading the AppEngine
3814         documentation, I think this patch should do what we want.  It's hard to
3815         test locally because the test instance isn't distributed in the same
3816         way the production instance is.
3817
3818         * QueueStatusServer/handlers/nextpatch.py:
3819         * QueueStatusServer/model/activeworkitems.py: Added.
3820
3821 2010-09-20  Andy Estes  <aestes@apple.com>
3822
3823         Reviewed by Adam Barth.
3824
3825         REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
3826         https://bugs.webkit.org/show_bug.cgi?id=40961
3827
3828         Implement WebKitUsePreHTML5ParserQuirks preference.
3829
3830         * DumpRenderTree/mac/DumpRenderTree.mm:
3831         (resetDefaultsToConsistentValues): Reset WebKitUsePreHTML5ParserQuirks
3832         to false after a test finishes.
3833
3834 2010-09-20  Adam Roben  <aroben@apple.com>
3835
3836         Windows build fix
3837
3838         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Put
3839         $(WebKitOutputDir)\include before $(WebKitLibrariesDir)\include so
3840         we'll pick up the most recent versions of the headers.
3841
3842 2010-09-20  Eric Seidel  <eric@webkit.org>
3843
3844         Reviewed by Adam Barth.
3845
3846         commit-queue should check commit-queue+ again just before committing
3847         https://bugs.webkit.org/show_bug.cgi?id=32679
3848
3849         Added a _revalidate_patch check, right before landing.
3850
3851         Since _revalidate_patch passes the patch_id from the work item
3852         back to bugzilla, I had to fix all of the previous queue tests to
3853         use valid attachment ids (that's the majority of this change).
3854
3855         In order to validate that the bug was still open, I had to teach
3856         bugzilla.Bug about open/closed states.
3857
3858         * Scripts/webkitpy/common/net/bugzilla.py:
3859         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3860         * Scripts/webkitpy/tool/commands/queues.py:
3861         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3862         * Scripts/webkitpy/tool/commands/queuestest.py:
3863         * Scripts/webkitpy/tool/mocktool.py:
3864
3865 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
3866
3867         Unreviewed.
3868
3869         Adding myself as a comitter.
3870
3871         * Scripts/webkitpy/common/config/committers.py:
3872
3873 2010-09-20  Adam Barth  <abarth@webkit.org>
3874
3875         Reviewed by Eric Seidel.
3876
3877         Two instances of commit-queue try to process the same patch
3878         https://bugs.webkit.org/show_bug.cgi?id=46113
3879
3880         This patch makes next-patch atomic so that the server won't vend the
3881         same patch twice in the same hour.
3882
3883         * QueueStatusServer/handlers/nextpatch.py:
3884
3885 2010-09-20  Adam Roben  <aroben@apple.com>
3886
3887         Make WebKitTestRunner's wait-to-dump watchdog timer work on Windows
3888
3889         We were previously trying to use a CFRunLoopTimer, but since Windows
3890         doesn't use CFRunLoop on most threads this doesn't work. Now we use a
3891         Windows-style timer on Windows.
3892
3893         I also replaced all uses of "watchdog" with "watchdog timer".
3894
3895         Fixes <http://webkit.org/b/46101> WebKitTestRunner's wait-to-dump
3896         watchdog timer doesn't work on Windows
3897
3898         Reviewed by Anders Carlsson.
3899
3900         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3901         (WTR::InjectedBundlePage::dump): Updated for rename.
3902
3903         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Removed
3904         platform-specific functions.
3905         (WTR::LayoutTestController::LayoutTestController): Added call to
3906         platformInitialize.
3907         (WTR::LayoutTestController::waitUntilDone): Changed to call
3908         initializeWaitToDumpWatchdogTimerIfNeeded instead of doing the work
3909         right in this function.
3910         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Updated for
3911         rename.
3912
3913         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added new
3914         members needed to support the watchdog timer abstraction. Replaced
3915         some "watchdog"s with "watchdog timer".
3916
3917         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
3918         Added.
3919         (WTR::LayoutTestController::platformInitialize): Does nothing on this
3920         platform.
3921         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Moved here
3922         from LayoutTestController.cpp and changed to use an early return.
3923         (WTR::waitUntilDoneWatchdogTimerFired): Moved here from
3924         LayoutTestController.cpp.
3925         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
3926         Moved code here from LayoutTestController::waitUntilDone and changed
3927         to use an early return.
3928
3929         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
3930         Added.
3931         (WTR::LayoutTestController::platformInitialize): Initialize our
3932         watchdog timer.
3933         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Added.
3934         Kills and clears the watchdog timer.
3935         (WTR::waitToDumpWatchdogTimerFired): Added. Calls through to the
3936         LayoutTestController member function of the same name.
3937         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
3938         Added. Sets up the timer if it isn't already set.
3939
3940         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added
3941         LayoutTestControllerMac.mm.
3942
3943         * WebKitTestRunner/win/InjectedBundle.vcproj: Added
3944         LayoutTestControllerWin.cpp.
3945
3946 2010-09-20  Martin Robinson  <mrobinson@igalia.com>
3947
3948         Reviewed by Daniel Bates.
3949
3950         [GTK] fast/forms/listbox-selection.html fails
3951         https://bugs.webkit.org/show_bug.cgi?id=45942
3952
3953         Use the gdkModifersFromJSValue helper to parse all appropriate modifier
3954         strings in keyDownCallback.
3955
3956         * DumpRenderTree/gtk/EventSender.cpp:
3957         (keyDownCallback): Use the gdkModifersFromJSValue instead of duplicating the 
3958         modifier parsing logic.
3959
3960 2010-09-19  Sam Weinig  <sam@webkit.org>
3961
3962         Reviewed by Anders Carlsson.
3963
3964         WebKit2 decidePolicyForNavigationAction should include mouse button information
3965         <rdar://problem/8413165>
3966         https://bugs.webkit.org/show_bug.cgi?id=46060
3967
3968         * MiniBrowser/mac/BrowserWindowController.m:
3969         (decidePolicyForNavigationAction):
3970         (decidePolicyForNewWindowAction):
3971
3972 2010-09-19  Daniel Bates  <dbates@rim.com>
3973
3974         Reviewed by Martin Robinson.
3975
3976         Add unit tests for diffs that delete or modify a change log entry
3977         or describe changes that are far apart
3978         https://bugs.webkit.org/show_bug.cgi?id=46046
3979
3980         Add additional unit tests to test change log diffs that contain
3981         deletions or changes that are far apart from each other in the
3982         ChangeLog file.
3983
3984         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
3985           - Added the following unit tests:
3986           "fixChangeLogPatch: [no change] In-place change."
3987           "fixChangeLogPatch: [no change] Remove first entry."
3988           "fixChangeLogPatch: [no change] Remove entry in the middle."
3989           "fixChangeLogPatch: [no change] Far apart changes (i.e. more than one chunk)."
3990
3991 2010-09-19  Sam Weinig  <sam@webkit.org>
3992
3993         Reviewed by Anders Carlsson.
3994
3995         Replace WKBundleRangeRef with WKBundleRangeHandleRef.
3996         https://bugs.webkit.org/show_bug.cgi?id=46054
3997
3998         The new one acts like WKBundleNodeHandleRef and allows for getting a
3999         wrapper in a specific world for the handle.
4000
4001         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4002         (WTR::propertyValue):
4003         (WTR::propertyValueDouble):
4004         (WTR::propertyValueInt):
4005         (WTR::numericWindowPropertyValue):
4006         (WTR::toStr):
4007         (WTR::InjectedBundlePage::shouldBeginEditing):
4008         (WTR::InjectedBundlePage::shouldEndEditing):
4009         (WTR::InjectedBundlePage::shouldInsertNode):
4010         (WTR::InjectedBundlePage::shouldInsertText):
4011         (WTR::InjectedBundlePage::shouldDeleteRange):
4012         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
4013         (WTR::InjectedBundlePage::shouldApplyStyle):
4014         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
4015
4016 2010-09-19  Kent Tamura  <tkent@chromium.org>
4017
4018         Unreviewed. Fix WebGL test regressions by r67809.
4019
4020         * DumpRenderTree/chromium/WebPreferences.cpp:
4021         (WebPreferences::applyTo): Call setExperimentalWebGLEnabled().
4022
4023 2010-09-19  Kent Tamura  <tkent@chromium.org>
4024
4025         Reviewed by Adam Barth.
4026
4027         [DRT/Chromium] Fix a WebSettings handling bug
4028         https://bugs.webkit.org/show_bug.cgi?id=45945
4029
4030         Before this change, Chromium DRT reset WebSettings for every new
4031         window. It was wrong.
4032         If new window is not the first one, we have to apply the same
4033         settings as the first window.  So, we introduce WebPreference to
4034         store the current settings, and apply it to new windows. It's same
4035         as test_shell's behavior.
4036
4037         * DumpRenderTree/DumpRenderTree.gypi:
4038         * DumpRenderTree/chromium/LayoutTestController.cpp:
4039           Use WebPreferences instead of WebSettings.
4040         (LayoutTestController::setUserStyleSheetEnabled):
4041         (LayoutTestController::setUserStyleSheetLocation):
4042         (LayoutTestController::setAuthorAndUserStylesEnabled):
4043         (LayoutTestController::setPopupBlockingEnabled):
4044         (LayoutTestController::disableImageLoading):
4045         (LayoutTestController::setJavaScriptCanAccessClipboard):
4046         (LayoutTestController::setXSSAuditorEnabled):
4047         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
4048         (LayoutTestController::setAllowFileAccessFromFileURLs):
4049         (LayoutTestController::overridePreference):
4050         (LayoutTestController::setEditingBehavior):
4051         * DumpRenderTree/chromium/TestShell.cpp:
4052         (TestShell::resetWebSettings): Use WebPreferences.
4053         (TestShell::runFileTest): ditto.
4054         (TestShell::createNewWindow): Apply existing WebPreferences to a new WebView.
4055         * DumpRenderTree/chromium/TestShell.h:
4056         (TestShell::preferences):
4057         (TestShell::applyPreferences):
4058         * DumpRenderTree/chromium/WebPreferences.cpp: Added.
4059         * DumpRenderTree/chromium/WebPreferences.h: Added.
4060
4061 2010-09-18  Prasad Tammana  <prasadt@chromium.org>
4062
4063         Reviewed by David Levin.
4064
4065         update-webkit --chromium spitting out a spurious error
4066         https://bugs.webkit.org/show_bug.cgi?id=45868
4067
4068         * Scripts/update-webkit-chromium: Use commandExists() function to check for existence of gclient.
4069
4070 2010-09-18  Sam Weinig  <sam@webkit.org>
4071
4072         Reviewed by Dan Bernstein.
4073
4074         Improve/unify the PageLoadClient interfaces
4075         https://bugs.webkit.org/show_bug.cgi?id=46043
4076
4077         * MiniBrowser/mac/BrowserWindowController.m:
4078         (didStartProvisionalLoadForFrame):
4079         (didReceiveServerRedirectForProvisionalLoadForFrame):
4080         (didFailProvisionalLoadWithErrorForFrame):
4081         (didCommitLoadForFrame):
4082         (didFinishDocumentLoadForFrame):
4083         (didFinishLoadForFrame):
4084         (didFailLoadWithErrorForFrame):
4085         (didReceiveTitleForFrame):
4086         (didFirstLayoutForFrame):
4087         (didFirstVisuallyNonEmptyLayoutForFrame):
4088         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4089         (WTR::InjectedBundlePage::InjectedBundlePage):
4090         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
4091         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
4092         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
4093         (WTR::InjectedBundlePage::didCommitLoadForFrame):
4094         (WTR::InjectedBundlePage::didFinishLoadForFrame):
4095         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
4096         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
4097         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
4098         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
4099         * WebKitTestRunner/TestController.cpp:
4100         (WTR::TestController::didReceiveMessageFromInjectedBundle):
4101         (WTR::TestController::didFinishLoadForFrame):
4102         * WebKitTestRunner/TestController.h:
4103
4104 2010-09-17  Eric Seidel  <eric@webkit.org>
4105
4106         Unreviewed.  Adding a shell script I use to run the
4107         commit-queue. Now that multiple machines run the cq,
4108         it makes sense to share the script between them.
4109
4110         * EWSTools/start-commit-queue.sh: Added.
4111
4112 2010-09-17  Brian Weinstein  <bweinstein@apple.com>
4113
4114         Reviewed by Jon Honeycutt.
4115
4116         The colors on the new build.webkit.org (after upgrading the master to 0.8.1) are
4117         slightly harder to read, so this reverts the previous background colors for various
4118         states, making it easier to read.
4119
4120         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
4121         (.success):
4122         (.failure):
4123         (.warnings):
4124         (.exception):
4125         (.start,.running,td.building):
4126         (.offline,td.offline):
4127
4128 2010-09-17  Sheriff Bot  <webkit.review.bot@gmail.com>
4129
4130         Unreviewed, rolling out r67692.
4131         http://trac.webkit.org/changeset/67692
4132         https://bugs.webkit.org/show_bug.cgi?id=46011
4133
4134         broke layout test dashboard (Requested by johnny_g on
4135         #webkit).
4136
4137         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
4138         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
4139         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4140
4141 2010-09-17  Martin Robinson  <mrobinson@igalia.com>
4142
4143         Reviewed by Oliver Hunt.
4144
4145         Style bot complains about cairo forward declaration naming
4146         https://bugs.webkit.org/show_bug.cgi?id=45867
4147
4148         Exclude Cairo forward declarations from indentifiers with underscores checks.
4149
4150         * Scripts/webkitpy/style/checkers/cpp.py: Add exclusion for Cairo forward-declarations.
4151         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
4152
4153 2010-09-16  Kinuko Yasuda  <kinuko@chromium.org>
4154
4155         Reviewed by Ojan Vafai.
4156
4157         Include detailed test modifiers (e.g. FLAKY) in results.json for failing non-layout tests
4158         https://bugs.webkit.org/show_bug.cgi?id=45408
4159
4160         This change also tries to remove duplicated upload_results_json methods
4161         in run_webkit_tests.py and json_results_generator.py.
4162
4163         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
4164         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
4165         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4166
4167 2010-09-16  Antonio Gomes  <tonikitoo@webkit.org>
4168
4169         Reviewed by Andreas Kling.
4170
4171         [Qt] When switching views (WebViewGraphicsBased <--> WebViewTraditional), QWebPage signals and QActions have to be re-set.
4172
4173         Recently r67554 changed the way different views use the WebPage class: it was previously being shared between
4174         different views, but now for each view switch, a new WebPage class is constructed and set. Signals and QAction's
4175         were not being set to the new WebPage though. Patch fix that, by re constructing the toolbar, and then re-hooking
4176         all page specific stuff to the UI.
4177
4178         * QtTestBrowser/launcherwindow.cpp:
4179         (LauncherWindow::initializeView):
4180         * QtTestBrowser/mainwindow.cpp:
4181         (MainWindow::MainWindow):
4182         (MainWindow::buildUI):
4183         (MainWindow::setPage):
4184         * QtTestBrowser/mainwindow.h:
4185
4186 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
4187
4188         Reviewed by Andreas Kling.
4189
4190         Make all accesses to m_item (GraphicsWebView) done by WebViewGraphicsBased class happen though graphicsWebView getter method.
4191
4192         This patch is mostly a preparation for another commit, where the ownership of the m_item/GraphicsWebView
4193         object will move to the qgraphicsscene instead of the qgraphicsview.
4194
4195         * QtTestBrowser/webview.cpp:
4196         (WebViewGraphicsBased::setPage):
4197         (WebViewGraphicsBased::setResizesToContents):
4198         (WebViewGraphicsBased::resizeEvent):
4199         (WebViewGraphicsBased::animatedFlip):
4200         * QtTestBrowser/webview.h:
4201         (WebViewGraphicsBased::setItemCacheMode):
4202         (WebViewGraphicsBased::itemCacheMode):
4203
4204 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
4205
4206         Reviewed by Andreas Kling.
4207
4208         Moved setYRotation method body out of the class (WebViewGraphicsBased) definition.
4209
4210         We usually separate methods whose body are larger than a few lines from the class definition.
4211
4212         * QtTestBrowser/webview.h:
4213         (WebViewGraphicsBased::yRotation):
4214         (WebViewGraphicsBased::setYRotation):
4215
4216 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
4217
4218         Reviewed by Andreas Kling.
4219
4220         Make initializeView method of LauncherWindow private.
4221
4222         No one else needs to be able to call it but LauncherWindow.
4223         Also moving the declation of isGraphicsBased method down in the same file, in order
4224         to better group related methods.
4225
4226         * QtTestBrowser/launcherwindow.h:
4227
4228 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
4229
423