Fix a crash on exit in WinLauncher
[WebKit-https.git] / WebKitTools / ChangeLog
1 2008-12-03  Adam Roben  <aroben@apple.com>
2
3         Fix a crash on exit in WinLauncher
4
5         Reviewed by Sam Weinig.
6
7         * WinLauncher/WinLauncher.cpp:
8         (_tWinMain): Call shutDownWebKit before exiting.
9
10 2008-12-03  Adam Roben  <aroben@apple.com>
11
12         Add a Debug_Internal configuration to WinLauncher
13
14         This matches our other projects.
15
16         Reviewed by Sam Weinig.
17
18         * WinLauncher/WinLauncher.vcproj: Added a Debug_Internal
19         configuration, which is identical to Debug except that it also
20         references debug_internal.vsprops. Also removed some settings that we
21         should be picking up from the .vsprops files.
22
23 2008-12-02  Eric Seidel  <eric@webkit.org>
24
25         Reviewed by David Kilzer.
26
27         Hack build-webkit --chromium to use Win32 python instead
28         of using the default cygwin python.  Scons + CYGWIN tries
29         to build with GCC by default, we force MSVC in our file
30         but that just results in errors from Scons.  Until we can fix
31         this latest round of errors, at least make build-webkit --chromium
32         actually "work" under CYGWIN instead of forcing users to use
33         a cmd shell directly.
34         
35         This is working around a Scons bug:
36         http://scons.tigris.org/issues/show_bug.cgi?id=2266
37
38         * Scripts/webkitdirs.pm:
39
40 2008-12-01  David Kilzer  <ddkilzer@apple.com>
41
42         Bug 22466: REGRESSION (35867): Many resources missing when saving webarchive of webkit.org
43
44         <https://bugs.webkit.org/show_bug.cgi?id=22466>
45         <rdar://problem/6403593>
46
47         Reviewed by Brady Eidson.
48
49         * DumpRenderTree/mac/DumpRenderTree.mm:
50         (normalizeHTTPResponseHeaderFields): Added.  Normalizes Date, Etag,
51         Keep-Alive, Last-Modified and Server header fields to prevent false
52         positive test failures.
53         (convertWebResourceResponseToDictionary): Call
54         normalizeHTTPResponseHeaderFields() to noramlize HTTP response
55         header fields.
56
57 2008-12-01  David D. Kilzer  <ddkilzer@webkit.org>
58
59         Bug 22559: Report builds left to test in bisect-builds (like git-bisect)
60
61         <https://bugs.webkit.org/show_bug.cgi?id=22559>
62
63         Reviewed by Adam Roben.
64
65         * Scripts/bisect-builds: Updated status message to report the
66         maximum number of builds left to test after the current one.
67         (max): Added.
68
69 2008-11-27  Alp Toker  <alp@nuanti.com>
70
71         Build GtkLauncher and minidom with the '-ansi' compiler flag to detect
72         API header breakage at build time.
73
74         * GNUmakefile.am:
75
76 2008-11-26  Eric Seidel  <eric@webkit.org>
77
78         Reviewed by Nikolas Zimmermann and Mark Rowe.
79         
80         Add support for build-webkit --chromium
81         https://bugs.webkit.org/show_bug.cgi?id=22515
82         More cleanups changing isCygwin calls to isAppleWinWebKit and deploying isAppleWebKit where necessary.
83
84         * Scripts/build-dumprendertree:
85         * Scripts/build-jsc:
86         * Scripts/build-webkit:
87         * Scripts/gdb-safari:
88         * Scripts/run-webkit-tests:
89         * Scripts/webkitdirs.pm:
90
91 2008-11-26  Eric Seidel  <eric@webkit.org>
92
93         Reviewed by Nikolas Zimmermann.
94
95         Add support for build-webkit --chromium (tested on mac)
96         https://bugs.webkit.org/show_bug.cgi?id=22515
97         Also simplified some code using checkArgv
98
99         * Scripts/build-webkit:
100         * Scripts/webkitdirs.pm:
101
102 2008-11-26  Eric Seidel  <eric@webkit.org>
103
104         Reviewed by Nikolas Zimmermann.
105
106         More pre-work for adding a build-webkit --chromium which works on Mac and Windows
107         https://bugs.webkit.org/show_bug.cgi?id=22515
108         Change a few calls to isCygwin to isAppleWinWebKit and a few calls to isAppleMacWebKit to isDarwin
109         in preparation for having a chromium cygwin and chromium mac build
110
111         * Scripts/build-webkit:
112         * Scripts/webkitdirs.pm:
113
114 2008-11-26  Eric Seidel  <eric@webkit.org>
115
116         Reviewed by Nikolas Zimmermann.
117
118         Pre-work for getting build-webkit --chromium to work
119         https://bugs.webkit.org/show_bug.cgi?id=22515
120         Rename isOSX to isAppleMacWebKit to match what the code does, and add isChromium()
121
122         * Scripts/build-dumprendertree:
123         * Scripts/build-jsc:
124         * Scripts/build-webkit:
125         * Scripts/gdb-safari:
126         * Scripts/run-javascriptcore-tests:
127         * Scripts/run-webkit-tests:
128         * Scripts/webkitdirs.pm:
129
130 2008-11-26  David Kilzer  <ddkilzer@apple.com>
131
132         Bug 22488: Make DRT smarter about charset encoding when post-processing webarchive content
133
134         <https://bugs.webkit.org/show_bug.cgi?id=22488>
135
136         Reviewed by Brady Eidson.
137
138         * DumpRenderTree/mac/DumpRenderTree.mm:
139         (convertWebResourceDataToString): If an IANA charset encoding string
140         is provided, convert it to a CFStringEncoding value and then to an
141         NSStringEncoding value, else fall back to NSUTF8StringEncoding.  We
142         also nil-check dataAsString, so the worst-case scenario is that the
143         data won't be decoded to a string (versus crashing DumpRenderTree).
144
145 2008-11-26  Jan Michael Alonzo  <jmalonzo@webkit.org>
146
147         Reviewed by Holger Freyther.
148
149         [Gtk] add/remove tests from Skipped and fix netscape plugin test
150         https://bugs.webkit.org/show_bug.cgi?id=22484
151
152         Remove print'ing to stderr
153
154         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
155         (NP_Initialize):
156         (NP_Shutdown):
157
158 2008-11-25  Steve Falkenburg  <sfalken@apple.com>
159
160         Windows build fix.
161
162         * DumpRenderTree/cg/PixelDumpSupportCG.h:
163
164 2008-11-25  Steve Falkenburg  <sfalken@apple.com>
165
166         Windows build fix.
167
168         * DumpRenderTree/cg/ImageDiffCG.cpp:
169
170 2008-11-24  Darin Fisher  <darin@chromium.org>
171
172         Fix bustage.
173
174         https://bugs.webkit.org/show_bug.cgi?id=15643
175
176         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
177         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
178
179 2008-11-24  Glenn Wilson  <gwilson@chromium.org>
180
181         Reviewed by Alexey Proskuryakov.
182
183         http://bugs.webkit.org/show_bug.cgi?id=15643
184
185         Added support for changing the "trailing whitespace" work-around
186         in LayoutTestController (so layout tests can verify this functionality)
187
188         * DumpRenderTree/LayoutTestController.cpp:
189         (setSelectTrailingWhitespaceEnabledCallback):
190         (LayoutTestController::staticFunctions):
191         * DumpRenderTree/LayoutTestController.h:
192         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
193         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
194         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
195         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
196
197 2008-11-24  Simon Fraser  <simon.fraser@apple.com>
198
199         Reviewed by Darin Adler
200
201         https://bugs.webkit.org/show_bug.cgi?id=22433
202         
203         Add script that attempts to detect virtual methods
204         whose signatures differ only by constness (which can
205         indicate a programming error).
206         
207         * Scripts/detect-mismatched-virtual-const: Added.
208
209 2008-11-24  Zan Dobersek  <zandobersek@gmail.com>
210
211         Reviewed by Holger Freyther.
212
213         https://bugs.webkit.org/show_bug.cgi?id=22039
214
215         [Gtk+] Implement TestNetscapePlugin for Gtk+ port and add it to the
216         build.
217
218         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
219         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
220         * DumpRenderTree/gtk/DumpRenderTree.cpp:
221         (setDefaultsToConsistentStateValuesForTesting):
222         * DumpRenderTree/gtk/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h: Added.
223         * DumpRenderTree/gtk/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h: Added.
224         * DumpRenderTree/gtk/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h: Added.
225         * GNUmakefile.am:
226
227 2008-11-24  Holger Hans Peter Freyther  <zecke@selfish.org>
228
229         Reviewed by Mark Rowe.
230
231         [Gtk+] Add configure option to enable Web Workers and enable it by default
232
233         Add --enable-workers to the buildsystem (used by build-webkit) add
234         the to be build files to the GNUmakefile.am and change build-webkit
235         to enable Web Workers by default.
236
237         * Scripts/build-webkit:
238
239 2008-11-24  Mark Rowe  <mrowe@apple.com>
240
241         Reviewed by Alexey Proskuryakov.
242
243         Let gdb-safari accept the --debug and --release options once more.
244
245         * Scripts/gdb-safari:
246
247 2008-11-23  Zan Dobersek  <zandobersek@gmail.com>
248
249         Reviewed by Holger Freyther. Landed by Jan Alonzo.
250
251         Get SVG tests tested on GTK port.
252
253         * Scripts/webkitdirs.pm:
254
255 2008-11-19  Greg Bolsinga  <bolsinga@apple.com>
256
257         Reviewed by Darin Adler.
258
259         https://bugs.webkit.org/show_bug.cgi?id=21810
260         Remove use of static C++ objects that are destroyed at exit time (destructors)
261
262         All static C++ objects that create atexit calls are gone. Update script
263         to indicate how to fix the problem should a new one appear.
264         
265         * Scripts/check-for-exit-time-destructors:
266
267 2008-11-18  Alexey Proskuryakov  <ap@webkit.org>
268
269         Reviewed by Darin Adler.
270
271         https://bugs.webkit.org/show_bug.cgi?id=22337
272         Enable workers by default
273
274         * Scripts/build-webkit: Changed the default to enabled.
275
276 2008-11-18  Alexey Proskuryakov  <ap@webkit.org>
277
278         Rubber-stamped by Darin Adler.
279
280         https://bugs.webkit.org/show_bug.cgi?id=22306
281         Disable channel messaging support
282
283         * Scripts/build-webkit: Add an option to enable channel messaging.
284
285 2008-11-17  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
286
287         Reviewed by George Staikos.
288
289         Add --(no-)wml build flags.
290
291         * Scripts/build-webkit:
292         * Scripts/run-webkit-tests:
293         * Scripts/webkitdirs.pm:
294
295 2008-11-17  Geoffrey Garen  <ggaren@apple.com>
296
297         Not reviewed.
298         
299         Try to fix gtk build.
300
301         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
302         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
303         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
304
305 2008-11-17  Pierre-Olivier Latour  <pol@apple.com>
306
307         Reviewed by Maciej.
308
309         Pixel tests should use a default tolerance of 0.1% on Leopard and 1.0%
310         on Tiger.
311
312         https://bugs.webkit.org/show_bug.cgi?id=22271
313
314         * Scripts/run-webkit-tests:
315
316 2008-11-17  Pierre-Olivier Latour  <pol@apple.com>
317
318         Reviewed by Sam Weinig.
319
320         Added new JavaScript API on LayoutController to pause a running
321         CSS transition or animation at a given time.
322
323         https://bugs.webkit.org/show_bug.cgi?id=21261
324
325         * DumpRenderTree/LayoutTestController.cpp:
326         (pauseAnimationAtTimeOnElementWithIdCallback):
327         (pauseTransitionAtTimeOnElementWithIdCallback):
328         (LayoutTestController::staticFunctions):
329         * DumpRenderTree/LayoutTestController.h:
330         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
331         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
332         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
333         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
334         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
335         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
336
337 2008-11-17  Gabor Loki  <loki@inf.u-szeged.hu>
338
339         Reviewed by Darin Adler.
340
341         <https://bugs.webkit.org/show_bug.cgi?id=22309>
342         Pass the remaining options to build system on Qt-port
343
344         * Scripts/build-webkit:
345         * Scripts/webkitdirs.pm:
346
347 2008-11-16  Greg Bolsinga  <bolsinga@apple.com>
348
349         Reviewed by Darin Adler.
350
351         https://bugs.webkit.org/show_bug.cgi?id=21810
352         Remove use of static C++ objects that are destroyed at exit time (destructors)
353
354         Remove .o files from the exclude list that have had their exit-time destructors removed.
355         Handle case when there is no current symbol.
356         
357         * Scripts/check-for-exit-time-destructors:
358
359 2008-11-16  Sam Weinig  <sam@webkit.org>
360
361         * Scripts/do-webcore-rename: Remove now fixed renames.
362
363 2008-11-16  Darin Adler  <darin@apple.com>
364
365         * Scripts/do-webcore-rename: Plan some future renames.
366
367 2008-11-15  Darin Adler  <darin@apple.com>
368
369         Rubber stamped by Geoff Garen.
370
371         - do the long-planned StructureID -> Structure rename
372
373         * Scripts/check-for-global-initializers: Update name of StructureID.o.
374         * Scripts/do-webcore-rename: Renaming script that I used.
375
376 2008-11-15  Greg Bolsinga  <bolsinga@apple.com>
377
378         Reviewed by Darin Adler.
379
380         https://bugs.webkit.org/show_bug.cgi?id=21810
381         Remove use of static C++ objects that are destroyed at exit time (destructors)
382
383         Create DEFINE_STATIC_LOCAL macro. Change static local objects to leak to avoid 
384         exit-time destructor. Update code that was changed to fix this issue that ran 
385         into a gcc bug (<rdar://problem/6354696> Codegen issue with C++ static reference 
386         in gcc build 5465). Also typdefs for template types needed to be added in some 
387         cases so the type could make it through the macro successfully.
388
389         Basically code of the form:
390         static T m;
391         becomes:
392         DEFINE_STATIC_LOCAL(T, m, ());
393
394         Also any code of the form:
395         static T& m = *new T;
396         also becomes:
397         DEFINE_STATIC_LOCAL(T, m, ());
398
399         Remove .o files from the exclude list that have had their exit-time destructors removed.
400         
401         * Scripts/check-for-exit-time-destructors:
402
403 2008-11-14  Kevin Ollivier  <kevino@theolliviers.com>
404
405         wx mac buildbot fix. Also, make sure we don't keep hitting this problem.
406
407         * wx/install-unix-extras:
408
409 2008-11-14  Alp Toker  <alp@nuanti.com>
410
411         GTK DRT build fix for gcc 4.4 snapshot. Add missing stdio include.
412
413         Fixes Debian bug #505723
414         http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=505723
415
416         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
417
418 2008-11-14  Krishna <krishnamurty.podipireddy@nokia.com>
419
420         Reviewed by Simon Hausmann.
421
422         Fix hanging DRT with Qt.
423
424         https://bugs.webkit.org/show_bug.cgi?id=22209
425
426         * DumpRenderTree/qt/DumpRenderTree.cpp:
427         (WebCore::DumpRenderTree::dump):
428         Send empty pixel test data 'block', which is now
429         expected by run-layout-tests.
430
431 2008-11-12  Dmitry Titov  <dimich@chromium.org>
432
433         Reviewed by Alexey Proskuryakov.
434
435         https://bugs.webkit.org/show_bug.cgi?id=22216
436
437         * Scripts/build-webkit:
438         Addes ENABLE_WORKERS to build-webkit so it's possible to build with workers enabled.
439
440 2008-11-06  David Kilzer  <ddkilzer@apple.com>
441
442         BUILD FIX: Backed out r38189 (and r38203) for Xcode 3.0.
443
444         Apparently older versions of gcc have issues with this patch.
445         Backing out a second time until the issues are resolved.
446
447 2008-11-06  David Kilzer  <ddkilzer@apple.com>
448
449         BUILD WAS NOT BROKEN: Rolling r38189 back in.
450
451         Please perform a clean build if you see crashes.
452
453 2008-11-06  David Kilzer  <ddkilzer@apple.com>
454
455         BUILD FIX: Backed out r38189 since it apparently broke the world.
456
457 2008-11-06  Chris Fleizach  <cfleizach@apple.com>
458
459         Reviewed by Beth Dakin.
460
461         Add ability to query an attribute's settable status and the
462         ability to retrieve a single attribute from an AXObject
463
464         * DumpRenderTree/AccessibilityUIElement.cpp:
465         (isAttributeSettableCallback):
466         (attributeValueCallback):
467         (AccessibilityUIElement::getJSClass):
468         * DumpRenderTree/AccessibilityUIElement.h:
469         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
470         (+[NSString stringWithJSStringRef:]):
471         (AccessibilityUIElement::attributeValue):
472         (AccessibilityUIElement::isAttributeSettable):
473         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
474         (AccessibilityUIElement::attributeValue):
475         (AccessibilityUIElement::isAttributeSettable):
476
477 2008-11-06  Greg Bolsinga  <bolsinga@apple.com>
478
479         Reviewed by Darin Adler.
480         
481         Bug 21810: Remove use of static C++ objects that are destroyed at exit time (destructors)
482         https://bugs.webkit.org/show_bug.cgi?id=21810
483         
484         Remove .o files from the exclude list that have had their exit-time destructors removed.
485
486         * Scripts/check-for-exit-time-destructors:
487
488 2008-11-05  Alp Toker  <alp@nuanti.com>
489
490         GTK build script tweak.
491
492         Make the path relative since it will appear in all -I compiler flags.
493         Long argument lists cause bizarre slowdowns in libtool and result
494         in huge build logs.
495
496         * Scripts/webkitdirs.pm:
497
498 2008-11-05  Anders Carlsson  <andersca@apple.com>
499
500         Fix 64-bit build.
501
502         * DumpRenderTree/mac/DumpRenderTree.mm:
503         (setDefaultsToConsistentValuesForTesting):
504
505 2008-11-04  Simon Fraser  <simon.fraser@apple.com>
506
507         Add AccessibilityObject.o to the exclude list for the
508         check for global destructors.
509         
510         * Scripts/check-for-exit-time-destructors:
511
512 2008-11-04  Darin Adler  <darin@apple.com>
513
514         * Scripts/check-for-exit-time-destructors: Fix failures seen on the
515         bot, but for some reason not on my computer.
516
517 2008-11-03  Darin Adler  <darin@apple.com>
518
519         Reviewed by Tim Hatcher.
520
521         - https://bugs.webkit.org/show_bug.cgi?id=22061
522           create script to check for exit-time destructors
523
524         * Scripts/check-for-exit-time-destructors: Added.
525         Started as a copy of check-for-global-initializers.
526
527         * Scripts/check-for-global-initializers: Added code to make
528         this script rerun any time it's modified, and also to properly
529         run again after the first time it reports an error.
530
531 2008-11-03  Pierre-Olivier Latour  <pol@apple.com>
532
533         Reviewed by Dan Bernstein.
534
535         Fixed the override of the "AppleScrollBarVariant" system setting to also work with HIToolbox.
536
537         https://bugs.webkit.org/show_bug.cgi?id=22054
538
539         * DumpRenderTree/mac/DumpRenderTree.mm:
540         (setDefaultsToConsistentValuesForTesting):
541
542 2008-10-31  Cameron Zwarich  <zwarich@apple.com>
543
544         Not reviewed.
545
546         * Scripts/do-webcore-rename:
547
548         Add some renames to contemplate for the future.
549
550 2008-10-31  Darin Adler  <darin@apple.com>
551
552         Requested by Mark Rowe.
553
554         * Scripts/check-for-global-initializers: s/Web Kit/WebKit/.
555
556 2008-10-31  David Kilzer  <ddkilzer@apple.com>
557
558         Bug 21997: prepare-ChangeLog should filter out ChangeLog files
559
560         <https://bugs.webkit.org/show_bug.cgi?id=21997>
561
562         Reviewed by Darin Adler.
563
564         * Scripts/prepare-ChangeLog:
565         (generateFileList): Don't add ChangeLog files to %{$functionLists}.
566         This prevents them from showing up in the new ChangeLog entry.  They
567         were already excluded from @{$changedFiles}.
568
569 2008-10-30  Mark Rowe  <mrowe@apple.com>
570
571         Reviewed by Jon Homeycutt.
572
573         Explicitly default to building for only the native architecture in debug and release builds.
574
575         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
576
577 2008-10-30  Pierre-Olivier Latour  <pol@apple.com>
578
579         Reviewed by Dan Bernstein.
580
581         Fixed 64 bit build failure.
582
583         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
584         (setupMainDisplayColorProfile):
585         (createBitmapContextFromWebView):
586
587 2008-10-28  Alp Toker  <alp@nuanti.com>
588
589         Fix GTK DRT following build breakage in r37928.
590
591         * DumpRenderTree/gtk/DumpRenderTree.cpp:
592         (dump):
593         (runTest):
594         (main):
595
596 2008-10-28  Alp Toker  <alp@nuanti.com>
597
598         Reviewed by Mark Rowe.
599
600         Fix recently introduced double-free crashes in GTK DRT.
601
602         LayoutTestController was made ref-counted in r36606 and Mac/Win DRT
603         were updated to call ->deref() but GTK DRT was still deleting
604         gLayoutTestController manually. This patch updates GTK to match the
605         other ports and resolves the memory allocation issues.
606
607         * DumpRenderTree/gtk/DumpRenderTree.cpp:
608         (runTest):
609
610 2008-10-28  Alp Toker  <alp@nuanti.com>
611
612         Reviewed by Mark Rowe.
613
614         Fix GTK DRT hang when running the tests.
615
616         Update output from the DRT tool to print an additional '#EOF' to match
617         breaking changes that were made in r37434.
618
619         * DumpRenderTree/gtk/DumpRenderTree.cpp:
620         (dump):
621
622 2008-10-28  Adele Peterson  <adele@apple.com>
623
624         Reviewed by Sam Weinig. 
625
626         Specify which Localizable.strings to update since we don't always want to update the file in the same
627         directory where we're searching for the strings to localize.
628         
629         * Scripts/extract-localizable-strings:
630         * Scripts/update-webkit-localizable-strings:
631
632 2008-10-28  Timothy Hatcher  <timothy@apple.com>
633
634         Add support for enabling the profiler, so the profiling tests can continue
635         work now that the profiler is not always enabled.
636
637         https://bugs.webkit.org/show_bug.cgi?id=21927
638
639         <rdar://problem/6211578> Make the JavaScript profiler opt-in, so it does
640         not slow down JavaScript all the time
641
642         Reviewed by Darin Adler and Kevin McCullough.
643
644         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Make the editor use spaces.
645         * DumpRenderTree/LayoutTestController.cpp:
646         (setJavaScriptProfilingEnabledCallback): Added. Calls LayoutTestController::setJavaScriptProfilingEnabled.
647         (LayoutTestController::staticFunctions): Added setJavaScriptProfilingEnabled to the script class.
648         * DumpRenderTree/LayoutTestController.h:
649         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
650         (LayoutTestController::setJavaScriptProfilingEnabled): Stubbed out with a FIXME.
651         * DumpRenderTree/mac/DumpRenderTree.mm:
652         (resetWebViewToConsistentStateBeforeTesting): Disables the developer extras and disables the profiler.
653         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
654         (LayoutTestController::setJavaScriptProfilingEnabled): Toggles the developer extras and profiler.
655         * DumpRenderTree/win/DumpRenderTree.cpp:
656         (resetWebViewToConsistentStateBeforeTesting): Disables the developer extras and disables the profiler.
657         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
658         (LayoutTestController::setJavaScriptProfilingEnabled): Toggles the developer extras and profiler.
659
660 2008-10-28  Pierre-Olivier Latour  <pol@apple.com>
661
662         Reviewed by Dan Bernstein
663
664         Primary changes in DumpRenderTree:
665         - Ensure font smoothing is disabled (this is also called LCD anti-aliasing and
666         is different from regular font CG anti-aliasing) as font-smoothing settings
667         depends on the display and can also be changed by the user
668         - Use a new cleared buffer for each test instead of the reusing same one to
669         avoid potential result corruption across tests
670         - Can now receive the expected pixel hash as a suffix to the test path or
671         url as "path'hash"
672         - Make sure hash is computed in a endian-independent way
673         - Improve the code that sets/restores the screen color profile
674         - Make the code more cross-platformy with std::string goodness
675         - Added an "on-screen" mode where the snapshot will take into account surfaces
676         on the window (like OpenGL content): this uses the new CG APIs on 10.5 or
677         reading from the display framebuffer on 10.4. This mode is not active by
678         default for performance reason, but must be explicitly activated from the test
679         file using the new "testOnscreen()" JS API.
680
681         Primary changes in ImageDiff:
682         - Provide a new comparison algorithm that is more tolerant to "acceptable"
683         failures (i.e. very small differences in font rendering, which --threshold is
684         not really good at handling)
685         - Generate normalized intensity-only diff images
686
687         Primary changes in run-webkit-tests:
688         - Take advantage of hashes for pixel tests which makes them much faster by
689         minimizing image comparisons
690         - Removed repaint options as these should be set from within test files using
691         JS API
692         - Replaced "threshold" option in  by "tolerance" expressed in percents
693         - Added more logging when in "verbose" mode
694
695         https://bugs.webkit.org/show_bug.cgi?id=21322
696         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
697         * DumpRenderTree/ForwardingHeaders/wtf/PassRefPtr.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/PassRefPtr.h.
698         * DumpRenderTree/ForwardingHeaders/wtf/RefPtr.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/RefPtr.h.
699         * DumpRenderTree/LayoutTestController.cpp:
700         (LayoutTestController::LayoutTestController):
701         (testOnscreenCallback):
702         (LayoutTestController::staticFunctions):
703         * DumpRenderTree/LayoutTestController.h:
704         (LayoutTestController::testOnscreen):
705         (LayoutTestController::setTestOnscreen):
706         (LayoutTestController::testPathOrURL):
707         (LayoutTestController::expectedPixelHash):
708         * DumpRenderTree/PixelDumpSupport.h:
709         * DumpRenderTree/cg/ImageDiffCG.cpp:
710         (strtof):
711         (releaseMallocBuffer):
712         (createDifferenceImage):
713         (imageHasAlpha):
714         (main):
715         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
716         (computeMD5HashStringForBitmapContext):
717         (dumpWebViewAsPixelsAndCompareWithExpected):
718         * DumpRenderTree/cg/PixelDumpSupportCG.h:
719         (BitmapContext::createByAdoptingBitmapAndContext):
720         (BitmapContext::~BitmapContext):
721         (BitmapContext::cgContext):
722         (BitmapContext::BitmapContext):
723         * DumpRenderTree/mac/DumpRenderTree.mm:
724         (shouldIgnoreWebCoreNodeLeaks):
725         (setDefaultsToConsistentValuesForTesting):
726         (crashHandler):
727         (initializeGlobalsFromCommandLineOptions):
728         (prepareConsistentTestingEnvironment):
729         (dumpRenderTree):
730         (sizeWebViewForCurrentTest):
731         (dump):
732         (runTest):
733         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
734         (restoreMainDisplayColorProfile):
735         (setupMainDisplayColorProfile):
736         (createBitmapContextFromWebView):
737         * DumpRenderTree/win/DumpRenderTree.cpp:
738         (dump):
739         (runTest):
740         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
741         (getBitmapContextFromWebView):
742         * Scripts/run-webkit-tests:
743
744 2008-10-27  Kevin Ollivier  <kevino@theolliviers.com>
745
746         wx build fix on Linux/GTK. Enable support for #include <JavaScriptCore/XYZ.h> style includes.
747
748         * wx/build-wxwebkit:
749
750 2008-10-24  Anders Carlsson  <andersca@apple.com>
751
752         Try fixing the 64-bit build.
753         
754         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
755         (testGetProperty):
756
757 2008-10-24  Anders Carlsson  <andersca@apple.com>
758
759         Reviewed by Sam Weinig.
760         
761         <rdar://problem/5440917> Support NPN_Construct
762         
763         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
764         (testCallback):
765         Fix a memory leak.
766         
767         (testConstruct):
768         New test method that treats it first argument as a constructor and invokes it with the rest of the arguments.
769         
770         (pluginInvoke):
771         Handle testConstruct.
772         
773         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
774         (testGetProperty):
775         Add objectPointer property.
776         
777         (testEnumerate):
778         Only enumerate the two first properties.
779         
780         (testConstruct):
781         Add a simple construct implementation that just returns the test object.
782
783 2008-10-24  David Kilzer  <ddkilzer@apple.com>
784
785         Bug 21850: svn-apply and svn-unapply should preserve patch line endings
786
787         <https://bugs.webkit.org/show_bug.cgi?id=21850>
788
789         Reviewed by Adam Roben.
790
791         * Scripts/svn-apply: Save end-of-line characters when stripping them
792         off each line of a patch so that they may be restored after
793         processing the line.
794         * Scripts/svn-unapply: Ditto.
795
796 2008-10-23  David Kilzer  <ddkilzer@apple.com>
797
798         Bug 21832: Fix scripts using 'new File::Temp' for Perl 5.10
799
800         <https://bugs.webkit.org/show_bug.cgi?id=21832>
801
802         Reviewed by Sam Weinig.
803
804         * Scripts/bisect-builds: Use imported tempfile() from File::Temp
805         instead of 'new File::Temp' to make the script work with Perl 5.10.
806         * Scripts/sort-Xcode-project-file: Ditto.
807
808 2008-10-22  Brady Eidson  <beidson@apple.com>
809
810         Reviewed by Adam Roben
811         
812         <rdar://6261773> - autocomplete="off" doesn't work on Windows
813
814         Implement LayoutTestController::elementDoesAutoCompleteForElementWithId() on Windows
815         
816         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
817
818 2008-10-22  Darin Adler  <darin@apple.com>
819
820         * Scripts/do-webcore-rename: More renaming plans.
821
822 2008-10-21  Steve Falkenburg  <sfalken@apple.com>
823
824         Exclude strings marked with UNLOCALIZED_STRING or UNLOCALIZED_LPCTSTR.
825
826         * Scripts/extract-localizable-strings:
827
828 2008-10-17  Maciej Stachowiak  <mjs@apple.com>
829
830         Reviewed by Mark Rowe.
831         
832         - default to 1000 tests per dump tool instance again, now that CTI no longer causes
833         excess different stack logs.
834         
835         (Also fix a small bug in my last change.)
836
837         * Scripts/run-webkit-tests:
838
839 2008-10-17  Stephanie Lewis  <slewis@apple.com>
840
841         Reviewed by Mark Rowe.
842
843         Fix layout tests that use prologues and epilogues.
844
845         * Scripts/run-webkit-tests:
846
847 2008-10-17  Maciej Stachowiak  <mjs@apple.com>
848
849         Reviewed by Mark Rowe.
850         
851         - make sure MallocStackLogging is only on for tools we want to
852         leak check, not other random stuff as well.
853
854         * Scripts/run-webkit-tests:
855
856 2008-10-17  Maciej Stachowiak  <mjs@apple.com>
857
858         Reviewed by Stephanie Lewis.
859         
860         - make run-webkit-tests --leaks default to 100 tests per run instead of 1000
861         
862         This should reduce or eliminate crashes on the buildbot due to
863         running out of memory while stack logging.
864
865         * Scripts/run-webkit-tests:
866
867 2008-10-16  Jan Michael Alonzo  <jmalonzo@webkit.org>
868
869         Gtk build fix. Not reviewed.
870
871         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
872         (LayoutTestController::setSmartInsertDeleteEnabled):
873
874 2008-10-15  Glenn Wilson  <gwilson@google.com>
875
876         Added new method to allow tests to disable smart editing in the course of a test.
877         This is a possible solution to bug .20655
878
879         Reviewed by Tim Hatcher.
880
881         * DumpRenderTree/LayoutTestController.cpp:
882         (setSmartInsertDeleteEnabledCallback): new method
883         (LayoutTestController::staticFunctions): added new method to static list of callbacks
884         * DumpRenderTree/LayoutTestController.h: added signature of new method
885         * DumpRenderTree/mac/DumpRenderTree.mm:
886         (resetWebViewToConsistentStateBeforeTesting): added state resetting
887         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
888         (LayoutTestController::setSmartInsertDeleteEnabled): added new method
889         * DumpRenderTree/win/DumpRenderTree.cpp:
890         (resetWebViewToConsistentStateBeforeTesting): added state resetting
891         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
892         (LayoutTestController::setSmartInsertDeleteEnabled): added new method
893
894 2008-10-14  Ada Chan  <adachan@apple.com>
895
896         Fix windows build.
897
898         Reviewed by Sam Weinig.
899
900         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
901         * DumpRenderTree/config.h:
902         * DumpRenderTree/win/DumpRenderTreeWin.h:
903         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
904         * DumpRenderTree/win/UIDelegate.cpp:
905
906 2008-10-13  Timothy Hatcher  <timothy@apple.com>
907
908         Make prepare-ChangeLog populate the changed functions for JavaScript files.
909
910         https://bugs.webkit.org/show_bug.cgi?id=21567
911
912         Reviewed by David Kilzer.
913
914         * Scripts/prepare-ChangeLog:
915         (get_function_line_ranges): Call get_function_line_ranges_for_javascript for
916         files that end with ".js".
917         (get_function_line_ranges_for_javascript): Find functions, anonymous functions
918         and getters/setters.
919
920 2008-10-14  Alp Toker  <alp@nuanti.com>
921
922         Reviewed by Sam Weinig.
923
924         https://bugs.webkit.org/show_bug.cgi?id=16299
925         Add a config.h file to DRT
926
927         Add a config.h to DumpRenderTree and reduce use of DumpRenderTree.h as
928         an ad-hoc config header.
929
930         * DumpRenderTree/AccessibilityController.cpp:
931         * DumpRenderTree/AccessibilityUIElement.cpp:
932         * DumpRenderTree/AccessibilityUIElement.h:
933         * DumpRenderTree/DumpRenderTree.h:
934         * DumpRenderTree/GCController.cpp:
935         * DumpRenderTree/LayoutTestController.cpp:
936         * DumpRenderTree/WorkQueue.cpp:
937         * DumpRenderTree/config.h: Added.
938         * DumpRenderTree/gtk/DumpRenderTree.cpp:
939         * DumpRenderTree/gtk/GCControllerGtk.cpp:
940         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
941         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
942         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
943         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
944         * DumpRenderTree/win/DumpRenderTree.cpp:
945         * DumpRenderTree/win/DumpRenderTreeWin.h:
946         * DumpRenderTree/win/EditingDelegate.cpp:
947         * DumpRenderTree/win/EventSender.cpp:
948         * DumpRenderTree/win/FrameLoadDelegate.cpp:
949         * DumpRenderTree/win/GCControllerWin.cpp:
950         * DumpRenderTree/win/MD5.cpp:
951         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
952         * DumpRenderTree/win/PolicyDelegate.cpp:
953         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
954         * DumpRenderTree/win/WorkQueueItemWin.cpp:
955         * GNUmakefile.am:
956
957 2008-10-13  Chris Fleizach  <cfleizach@apple.com>
958
959         Reviewed by Beth Dakin.
960
961         Added a method to get the links in a webpage
962
963         * DumpRenderTree/AccessibilityUIElement.cpp:
964         (attributesOfDocumentLinksCallback):
965         (AccessibilityUIElement::getJSClass):
966         * DumpRenderTree/AccessibilityUIElement.h:
967         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
968         (AccessibilityUIElement::getDocumentLinks):
969         (AccessibilityUIElement::attributesOfDocumentLinks):
970         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
971         (AccessibilityUIElement::getDocumentLinks):
972         (AccessibilityUIElement::attributesOfDocumentLinks):
973
974 2008-10-13  David Kilzer  <ddkilzer@apple.com>
975
976         Bug 21457: resolve-ChangeLogs should be able to operate on a git revision range
977
978         <https://bugs.webkit.org/show_bug.cgi?id=21457>
979
980         Reviewed by Adam.
981
982         * Scripts/resolve-ChangeLogs: Added optional parameter to
983         -f|--fix-merged switch to run the script on a revision range.
984         Updated command-line validation checks.
985         (findChangeLog): Fixed long-standing bug that should have used
986         $_[0] instead of $_.
987         (fixMergedChangeLog): Renamed to fixOneMergedChangeLog($).  Updated
988         to work when called from git filter-branch.  It always restores a
989         copy of the previous revision before reapplying the patch.
990         (fixMergedChangeLogs): Added.  Calls itself through git filter-branch
991         to re-merge ChangeLog files across a revision range.  Removes
992         .git/refs/original directory on success.
993         (parseFixMerged): Added.  Custom method to parse the -f|--fix-merged
994         switch.
995         (removeChangeLogArguments): Added.  Removes items from @ARGV when
996         they are ChangeLog paths, and return a list of paths.  This makes it
997         easier to validate the command-line.
998         (resolveChangeLog): Added.  Extracted from main code block.  Runs
999         the traditional single-file merge algorithm.
1000         (usageAndExit): Added.  Extracted from main code block.  Prints
1001         usage statement and exits with error status.
1002
1003 2008-10-12  Darin Adler  <darin@apple.com>
1004
1005         * Scripts/make-js-test-wrappers: Update exceptions list so the script
1006         won't overwrite files and mangle tests.
1007
1008 2008-10-11  Dan Bernstein  <mitz@apple.com>
1009
1010         Reviewed by Sam Weinig and Anders Carlsson.
1011
1012         - update Mac DumpRenderTree to use the new WebView SPI for forcing the
1013           complex text code path
1014         - add --complex-text support to Windows DumpRenderTree
1015
1016         * DumpRenderTree/mac/DumpRenderTree.mm:
1017         (dumpRenderTree):
1018         * DumpRenderTree/win/DumpRenderTree.cpp:
1019         (createWebViewAndOffscreenWindow):
1020         (main):
1021         * Scripts/run-webkit-tests:
1022
1023 2008-10-09  Eric Seidel  <eric@webkit.org>
1024
1025         Reviewed by Oliver Hunt.
1026
1027         https://bugs.webkit.org/show_bug.cgi?id=21498
1028
1029         * Scripts/make-js-test-wrappers: ignore resources/shadow-offset.js
1030
1031 2008-10-09  Cameron Zwarich  <zwarich@apple.com>
1032
1033         Not reviewed.
1034
1035         Add StructureID.o to the exclusion list in the global initializers
1036         script to fix the Debug build.
1037
1038         * Scripts/check-for-global-initializers:
1039
1040 2008-10-08  Mark Rowe  <mrowe@apple.com>
1041
1042         Fix the Windows build after r37434.
1043
1044         * DumpRenderTree/win/DumpRenderTree.cpp:
1045         (dump): Update code to approximate valid C++ syntax.
1046
1047 2008-10-08  Timothy Hatcher  <timothy@apple.com>
1048
1049         Add SVGElementInstance to the list of exceptions that have
1050         global initializers in debug builds.
1051
1052         Rubber-stamped by Mark Rowe.
1053
1054         * Scripts/check-for-global-initializers: Add SVGElementInstance.o.
1055
1056 2008-10-08  Simon Fraser  <simon.fraser@apple.com>
1057
1058         Reviewed by Dan Bernstein
1059
1060         Avoid disconnect between DRT and run-webkit-tests
1061         about whether to expect PNG dumps by having DRT always
1062         print two blocks terminated by #EOF, the second of which
1063         may be empty.
1064         
1065         https://bugs.webkit.org/show_bug.cgi?id=21483
1066         
1067         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1068         (printPNG):
1069         (dumpWebViewAsPixelsAndCompareWithExpected):
1070         * DumpRenderTree/mac/DumpRenderTree.mm:
1071         (dump):
1072         * DumpRenderTree/win/DumpRenderTree.cpp:
1073         (dump):
1074         * Scripts/run-webkit-tests:
1075
1076 2008-10-07  Adam Roben  <aroben@apple.com>
1077
1078         Make sure short functions get included in ChangeLog output for git
1079         repositories
1080
1081         Reviewed by Dave Kilzer.
1082
1083         * Scripts/prepare-ChangeLog:
1084         (sub diffCommand): Pass -U0 to git diff so that each contiguous change
1085         will get its own chunk without any surrounding context.
1086         (sub extractLineRange): Use the line numbers from the chunk header
1087         without modifying them now that they're accurate.
1088
1089 2008-10-04  Mark Rowe  <mrowe@apple.com>
1090
1091         Reviewed by Tim Hatcher.
1092
1093         Update check-for-weak-vtables to check only the final linked image for weak vtables.
1094         This gives more useful results than checking each object file independently.
1095
1096         * Scripts/check-for-weak-vtables:
1097
1098 2008-10-03  Pierre-Olivier Latour <pol@apple.com>
1099
1100         Reviewed by Darin Adler
1101
1102         Render images to RGBA8 bitmaps independently of platform endianness.
1103
1104         Create image difference bitmap in reference image colorspace instead of device colorspace
1105         (which depends on the main display profile), so that no color matching happens.
1106
1107         https://bugs.webkit.org/show_bug.cgi?id=21336
1108
1109         * DumpRenderTree/cg/ImageDiffCG.cpp:
1110         (createDifferenceBitmap):
1111         (computePercentageDifferent):
1112         (compareImages):
1113
1114 2008-10-02  Simon Fraser  <simon.fraser@apple.com>
1115
1116         Reviewed by Darin Adler
1117
1118         Fix hang when running with --pixel --reset, which occurs
1119         because DRT spews PNG data when the script does not expect it.
1120         
1121         https://bugs.webkit.org/show_bug.cgi?id=21323
1122         
1123         * Scripts/run-webkit-tests:
1124
1125 2008-09-30  Mark Rowe  <mrowe@apple.com>
1126
1127         Reviewed by Dan Bernstein.
1128
1129         Add a leak counter for CachedResources since we've had two recent leaks involving them.
1130
1131         * Scripts/check-for-global-initializers:
1132
1133 2008-09-30  Mark Rowe  <mrowe@apple.com>
1134
1135         Rubber-stamped by Dan Bernstein.
1136
1137         Fix many leaks seen on fast/backgrounds/svg-as-background-1.html.
1138
1139         JavaScript wrappers were keeping DOM objects alive, which was leading to the SVG background image
1140         being kept alive in the memory cache past our last attempt to empty the cache prior to quitting.
1141         We need to empty the memory cache after forcing a JavaScript garbage collection to ensure that
1142         any live JavaScript wrappers are collected and their corresponding DOM objects have a chance to be
1143         torn down before we exit.
1144
1145         * DumpRenderTree/mac/DumpRenderTree.mm:
1146         (dumpRenderTree):
1147         (main):
1148
1149 2008-09-30  Simon Fraser  <simon.fraser@apple.com>
1150
1151         Reviewed by Dan Bernstein
1152
1153         Don't run pixel comparison for text-only tests.
1154         https://bugs.webkit.org/show_bug.cgi?id=21124
1155         
1156         * DumpRenderTree/mac/DumpRenderTree.mm:
1157         (dump):
1158         * Scripts/run-webkit-tests:
1159
1160 2008-09-29  Thiago Macieira  <thiago.macieira@nokia.com>
1161
1162         Reviewed by Simon.
1163
1164         Changed copyright from Trolltech ASA to Nokia.
1165         
1166         Nokia acquired Trolltech ASA, assets were transferred on September 26th 2008.
1167         
1168
1169         * DumpRenderTree/qt/DumpRenderTree.cpp:
1170         * DumpRenderTree/qt/jsobjects.cpp:
1171         * DumpRenderTree/qt/jsobjects.h:
1172         * DumpRenderTree/qt/main.cpp:
1173         * DumpRenderTree/qt/testplugin.cpp:
1174         * DumpRenderTree/qt/testplugin.h:
1175
1176 2008-09-28  David Kilzer  <ddkilzer@apple.com>
1177
1178         Bug 21185: resolve-ChangeLogs should be able to fix poorly merged ChangeLog entries after a git svn rebase
1179
1180         <https://bugs.webkit.org/show_bug.cgi?id=21185>
1181
1182         Reviewed by Adam.
1183
1184         * Scripts/resolve-ChangeLogs: Added new -f|--fix-merge switch that
1185         will attempt to reapply the last commit to a ChangeLog file such
1186         that the ChangeLog entry appears at the top of the file.
1187         (findChangeLog): Added prototype and moved method below the exit
1188         statement.
1189         (fixMergedChangeLog): Added.  Method to fix incorrectly merged
1190         ChangeLog entries.
1191
1192 2008-09-27  Anders Carlsson  <andersca@apple.com>
1193
1194         Reviewed by Sam Weinig.
1195         
1196         https://bugs.webkit.org/show_bug.cgi?id=21178
1197         <rdar://problem/6248651>
1198         
1199         Return the result value from getURL.
1200         
1201         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1202         (getURL):
1203
1204 2008-09-26  Matt Lilek  <webkit@mattlilek.com>
1205
1206         Reviewed by Tim Hatcher.
1207
1208         Update FEATURE_DEFINES after ENABLE_CROSS_DOCUMENT_MESSAGING was removed.
1209
1210         * Scripts/build-webkit:
1211
1212 2008-09-26  Alice Liu  <alice.liu@apple.com>
1213
1214         Remove usage of atlstr.h and CString for VCExpress compatibility
1215
1216         Reviewed by Stephanie Lewis.
1217
1218         * record-memory-win/main.cpp:
1219         (ProcessArgs):
1220         (UseImage):
1221         (QueryContinuously):
1222         (OneQuery):
1223         (OneQueryMP):
1224
1225 2008-09-26  Kevin Ollivier  <kevino@theolliviers.com>
1226
1227         wx build fix. Update the version of libpng.
1228
1229         * wx/install-unix-extras:
1230
1231 2008-09-24  Sam Weinig  <sam@webkit.org>
1232
1233         Reviewed by Darin Adler.
1234
1235         Fix for https://bugs.webkit.org/show_bug.cgi?id=21080
1236         <rdar://problem/6243534>
1237         Crash below Function.apply when using a runtime array as the argument list
1238
1239         Add method to ObjCController to return a runtime array.
1240
1241         * DumpRenderTree/mac/ObjCController.m:
1242         (+[ObjCController isSelectorExcludedFromWebScript:]):
1243         (+[ObjCController webScriptNameForSelector:]):
1244         (-[ObjCController testArray]):
1245
1246 2008-09-24  Beth Dakin  <bdakin@apple.com>
1247
1248         Reviewed by Sam Weinig.
1249
1250         Speculative build fix. 
1251
1252         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1253         (AccessibilityUIElement::supportsPressAction):
1254
1255 2008-09-23  Beth Dakin  <bdakin@apple.com>
1256
1257         Reviewed by Sam Weinig.
1258
1259         This patch extends DumpRenderTree's AccessibilityController to ask 
1260         if the focused element supports the press action.
1261
1262         * DumpRenderTree/AccessibilityUIElement.cpp:
1263         (getSupportsPressActionCallback):
1264         (AccessibilityUIElement::getJSClass):
1265         * DumpRenderTree/AccessibilityUIElement.h:
1266         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1267         (AccessibilityUIElement::supportsPressAction):
1268
1269 2008-09-22  Alice Liu  <alice.liu@apple.com>
1270
1271         Adding a stand-alone Windows console application to record a process's memory usage
1272
1273         Reviewed by Steve Falkenburg.
1274
1275         * record-memory-win: Added.
1276         * record-memory-win/main.cpp: Added.
1277         * record-memory-win/record-memory-win.vcproj: Added.
1278
1279 2008-09-22  Chris Fleizach  <cfleizach@apple.com>
1280
1281         Reviewed by Darin Adler.
1282
1283         Support ability to get/set selected text ranges for text controls through AX.
1284
1285         * DumpRenderTree/AccessibilityUIElement.cpp:
1286         (setSelectedTextRangeCallback):
1287         (getSelectedTextRangeCallback):
1288         (AccessibilityUIElement::getJSClass):
1289         * DumpRenderTree/AccessibilityUIElement.h:
1290         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1291         (AccessibilityUIElement::attributesOfRowHeaders):
1292         (AccessibilityUIElement::attributesOfVisibleCells):
1293         (AccessibilityUIElement::rowIndexRange):
1294         (AccessibilityUIElement::columnIndexRange):
1295         (AccessibilityUIElement::cellForColumnAndRow):
1296         (AccessibilityUIElement::selectedTextRange):
1297         (AccessibilityUIElement::setSelectedTextRange):
1298         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1299         (AccessibilityUIElement::selectedTextRange):
1300         (AccessibilityUIElement::setSelectedTextRange):
1301
1302 2008-09-20  Darin Adler  <darin@apple.com>
1303
1304         * DumpRenderTree/mac/DumpRenderTree.mm:
1305         (convertMIMEType): Turn on Stephanie's workaround for Tiger too.
1306
1307 2008-09-19  Alp Toker  <alp@nuanti.com>
1308
1309         Build fix for the 'gold' linker and recent binutils. New behaviour
1310         requires that we link to used libraries explicitly.
1311
1312         * GNUmakefile.am:
1313
1314 2008-09-19  Stephanie Lewis  <slewis@apple.com>
1315
1316         Reviewed by Oliver Hunt.
1317
1318         Implement a workaround for an incorrect mime-type on machines with 
1319         Dashcode 2.0.1.  Dashcode is overriding the UTI type for .js files.
1320         See radar <rdar://problem/6234318>.     
1321
1322         * DumpRenderTree/mac/DumpRenderTree.mm:
1323         (convertMIMEType):
1324
1325 2008-09-19  Chris Fleizach  <cfleizach@apple.com>
1326
1327         Fixed Windows bustage
1328
1329         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1330         (AccessibilityUIElement::titleUIElement):
1331
1332 2008-09-18  Chris Fleizach  <cfleizach@apple.com>
1333
1334         Reviewed by Darin Adler.
1335
1336         Expose titleUIElement call for DumpRenderTree
1337
1338         * ChangeLog:
1339         * DumpRenderTree/AccessibilityUIElement.cpp:
1340         (titleUIElementCallback):
1341         (AccessibilityUIElement::getJSClass):
1342         * DumpRenderTree/AccessibilityUIElement.h:
1343         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1344         (AccessibilityUIElement::titleUIElement):
1345
1346 2008-09-18  Darin Adler  <darin@apple.com>
1347
1348         * Scripts/do-webcore-rename: More renaming plans.
1349
1350 2008-09-18  Mark Rowe  <mrowe@apple.com>
1351
1352         Reviewed by Dan Bernstein.
1353
1354         Clear the main frame's name between tests to get more consistent test results
1355         when running the WebKit tests with --nthly.
1356
1357         * DumpRenderTree/mac/DumpRenderTree.mm:
1358         (resetWebViewToConsistentStateBeforeTesting):
1359         * DumpRenderTree/win/DumpRenderTree.cpp:
1360         (resetWebViewToConsistentStateBeforeTesting):
1361
1362 2008-09-18  Stephanie Lewis  <slewis@apple.com>
1363
1364         Really fix tiger jsc tests.
1365
1366         * Scripts/run-javascriptcore-tests:
1367
1368 2008-09-18  Stephanie Lewis  <slewis@apple.com>
1369
1370         Reviewed by Maciej Stachowiak.
1371
1372         Fix jsc tests on Tiger.  Make jsc tests smarter about when to use the arch flag.
1373
1374         * Scripts/run-javascriptcore-tests:
1375         * Scripts/webkitdirs.pm:
1376
1377 2008-09-18  Mark Rowe  <mrowe@apple.com>
1378
1379         Rubber-stamped by Sam Weinig.
1380
1381         Print warning to stdout rather than stderr when a test attempts to access a remote resource.
1382         This should make it more obvious when a test does this, as stderr output tends to be obscured
1383         by noise in the test results.
1384
1385         Also fixes some coding style issues in ResourceLoadDelegate.mm.
1386
1387         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1388         (-[NSError _drt_descriptionSuitableForTestResult]):
1389         (-[NSURL _drt_descriptionSuitableForTestResult]):
1390         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1391         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1392         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
1393         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
1394         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
1395         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
1396
1397 2008-09-18  Stephanie Lewis  <slewis@apple.com>
1398
1399         Reviewed by Mark Rowe and Maciej Stachowiak..
1400
1401         add a --64-bit option and specify which architecture to run on Mac.
1402
1403         * Scripts/run-javascriptcore-tests:
1404
1405 2008-09-17  Mark Rowe  <mrowe@apple.com>
1406
1407         Reviewed by Sam Weinig.
1408
1409         Fix a crash seen running DumpRenderTree on fast/dom/null-document-window-open-crash.html under guard malloc.
1410
1411         The JS wrapper for LayoutTestController could outlive the wrapped instance, and would crash when
1412         attempting to access the wrapped instance within layoutTestControllerObjectFinalize. We fix this by making
1413         LayoutTestController ref-counted to ensure that it is not outlived by the JS wrapper.
1414
1415         * DumpRenderTree/ForwardingHeaders/wtf/RefCounted.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/RefCounted.h.
1416         * DumpRenderTree/LayoutTestController.cpp:
1417         (LayoutTestController::LayoutTestController):
1418         (notifyDoneCallback): Remove code that is no longer needed now that we must always have a wrapped instance.
1419         (layoutTestControllerObjectFinalize): Deref the wrapped object.
1420         (LayoutTestController::makeWindowObject): Ref the wrapped object.
1421         * DumpRenderTree/LayoutTestController.h: Make LayoutTestController RefCounted.
1422         * DumpRenderTree/mac/DumpRenderTree.mm:
1423         (runTest): Deref the LayoutTestController object rather than explicitly deleting it.
1424         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Remove code that is no longer needed.
1425         * DumpRenderTree/win/DumpRenderTree.cpp:
1426         (runTest): Deref the LayoutTestController object rather than explicitly deleting it.
1427
1428 2008-09-16  Sam Weinig  <sam@webkit.org>
1429
1430         Reviewed by Mark Rowe.
1431
1432         Add flag to disable running sample on tests that timeout.
1433
1434         * Scripts/run-webkit-tests:
1435
1436 2008-09-16  Adam Roben  <aroben@apple.com>
1437
1438         Windows build fix after r36511
1439
1440         Update for rename of layoutTestController to gLayoutTestController.
1441
1442         * DumpRenderTree/LayoutTestController.cpp:
1443         * DumpRenderTree/win/EditingDelegate.cpp:
1444         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1445         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1446         * DumpRenderTree/win/UIDelegate.cpp:
1447
1448 2008-09-16  Adam Roben  <aroben@apple.com>
1449
1450         Add a script to print out the dependency tree of a Visual Studio
1451         solution file
1452
1453         * Scripts/print-msvc-project-dependencies: Added.
1454
1455 2008-09-16  Mark Rowe  <mrowe@apple.com>
1456
1457         Fix the build.
1458
1459         * DumpRenderTree/LayoutTestController.cpp:
1460         (notifyDoneCallback): Call fprintf in a safer manner.
1461
1462 2008-09-16  Simon Fraser  <simon.fraser@apple.com>
1463
1464         Reviewed by Eric Seidel
1465         
1466         Protect against tests that call layoutTestController.notifyDone() 
1467         more than once, which would lead to memory corruption, by nulling
1468         out the LayoutTestController on the JSObjectRef on destruction. Also
1469         add a finalize callback on the class so that if the LTC outlives
1470         the JSObjectRef, the JSObjectRef backpointer on the LTC can be
1471         nulled out.
1472         
1473         https://bugs.webkit.org/show_bug.cgi?id=20875
1474
1475         * DumpRenderTree/LayoutTestController.cpp:
1476         (LayoutTestController::LayoutTestController):
1477         (notifyDoneCallback):
1478         (layoutTestControllerObjectFinalize):
1479         (LayoutTestController::makeWindowObject):
1480         (LayoutTestController::getJSClass):
1481         * DumpRenderTree/LayoutTestController.h:
1482         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1483         (LayoutTestController::~LayoutTestController):
1484
1485 2008-09-16  Simon Fraser  <simon.fraser@apple.com>
1486
1487         Reviewed by Eric Seidel
1488
1489         Step 1 patch: rename global variable for clarity.
1490         https://bugs.webkit.org/show_bug.cgi?id=20875
1491
1492         * DumpRenderTree/DumpRenderTree.h:
1493         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1494         (dumpWebViewAsPixelsAndCompareWithExpected):
1495         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1496         (dumpFramesAsText):
1497         (dump):
1498         (runTest):
1499         (processWork):
1500         (webViewLoadFinished):
1501         (webViewWindowObjectCleared):
1502         * DumpRenderTree/mac/DumpRenderTree.mm:
1503         (allocateGlobalControllers):
1504         (dumpFrameScrollPosition):
1505         (dumpFramesAsText):
1506         (methodNameStringForFailedTest):
1507         (dump):
1508         (runTest):
1509         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1510         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1511         * DumpRenderTree/mac/EditingDelegate.mm:
1512         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
1513         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
1514         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
1515         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
1516         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
1517         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
1518         (-[EditingDelegate webViewDidBeginEditing:]):
1519         (-[EditingDelegate webViewDidChange:]):
1520         (-[EditingDelegate webViewDidEndEditing:]):
1521         (-[EditingDelegate webViewDidChangeTypingStyle:]):
1522         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1523         (-[FrameLoadDelegate processWork:]):
1524         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
1525         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1526         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
1527         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
1528         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
1529         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
1530         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1531         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1532         * DumpRenderTree/mac/UIDelegate.mm:
1533         (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]):
1534         (-[UIDelegate webViewFocus:]):
1535         (-[UIDelegate webViewUnfocus:]):
1536         (-[UIDelegate webView:createWebViewWithRequest:]):
1537         (-[UIDelegate webViewClose:]):
1538         * DumpRenderTree/win/DumpRenderTree.cpp:
1539         (dumpFrameScrollPosition):
1540         (dumpFramesAsText):
1541         (dump):
1542         (runTest):
1543
1544 2008-09-15  Alice Liu  <alice.liu@apple.com>
1545
1546         A change needed to make PPC bots pass accessibility/table-cell-spans.html layout test
1547
1548         Reviewed by Stephanie Lewis.
1549
1550         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1551         Calling -[NSValue rangeValue] on nil object was returning bogus results on PPC, 
1552         but not Intel.  Add a check for nil before calling. 
1553         (AccessibilityUIElement::rowIndexRange):
1554         (AccessibilityUIElement::columnIndexRange):
1555
1556 2008-09-14  Mark Rowe  <mrowe@apple.com>
1557
1558         Build fix.
1559
1560         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1561         (waitUntilDoneWatchdogFired):
1562         * DumpRenderTree/mac/ObjCPlugin.m:
1563
1564 2008-09-08  Dan Bernstein  <mitz@apple.com>
1565
1566         Reviewed by Mark Rowe.
1567
1568         - add an option to run-webkit-tests to always use the complex text code path
1569
1570         * DumpRenderTree/mac/DumpRenderTree.mm:
1571         (initializeGlobalsFromCommandLineOptions):
1572         (dumpRenderTree):
1573         * Scripts/run-webkit-tests:
1574
1575 2008-09-08  Steve Falkenburg  <sfalken@apple.com>
1576
1577         Another Windows nightly build fix.
1578
1579         Reviewed by Sam Weinig.
1580
1581         * FindSafari/FindSafari.cpp:
1582         (_tmain): Delete existing WebKitNightly directory in temp.
1583         * FindSafari/Safari.exe.manifest: Add PROGIDs for each COM class. Remove non-production classes.
1584
1585 2008-09-07  Stephanie Lewis  <slewis@apple.com>
1586
1587         Reviewed by Mark Rowe.
1588
1589         Fix DRT build 
1590
1591         * DumpRenderTree/DumpRenderTreePrefix.h:
1592         * DumpRenderTree/win/DumpRenderTree.vcproj:
1593
1594 2008-09-06  Steve Falkenburg  <sfalken@apple.com>
1595
1596         Fix Windows nightlies.
1597         
1598         Copy WebKit.dll alongside application so registry-free COM can find it.
1599         Update embedded manifest to force use registry-free COM.
1600
1601         Reviewed by Dave Hyatt.
1602
1603         * FindSafari/FindSafari.cpp:
1604         (copyManifest):
1605         (replaceManifest):
1606         (_tmain):
1607         * FindSafari/FindSafari.rc: Added.
1608         * FindSafari/FindSafari.vcproj:
1609         * FindSafari/Safari.exe.manifest: Added.
1610         * FindSafari/resource.h: Added.
1611
1612 === End merge of squirrelfish-extreme ===
1613
1614 2008-08-31  Mark Rowe  <mrowe@apple.com>
1615
1616         Reviewed by Maciej Stachowiak.
1617
1618         Add a --profile flag to run-sunspider.
1619
1620         * Scripts/webkitdirs.pm: Detect --profile or --profiling passed as a command-line argument
1621         to build scripts as indicating that we should use the "Profiling" configuration.  At present
1622         this is only supported by JavaScriptCore, so using this argument to build any other project
1623         will likely result in unexpected behaviour.
1624
1625 2008-08-27  Mark Rowe  <mrowe@apple.com>
1626
1627         Reviewed by Oliver Hunt.
1628
1629         Fix run-webkit-tests to handle DRT exiting early.
1630
1631         * Scripts/run-webkit-tests: Initialize $expectedResultPaths{$base} before it will be used.
1632
1633 === Start merge of squirrelfish-extreme ===
1634
1635 2008-09-04  Mark Rowe  <mrowe@apple.com>
1636
1637         Reviewed by Eric Seidel.
1638
1639         Fix https://bugs.webkit.org/show_bug.cgi?id=20639.
1640         Bug 20639: ENABLE_DASHBOARD_SUPPORT does not need to be a FEATURE_DEFINE
1641
1642         * Scripts/build-webkit: Remove ENABLE_DASHBOARD_SUPPORT-related code.
1643
1644 2008-09-04  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
1645
1646         Reviewed by Oliver Hunt.
1647
1648         Bug 20616: Incorporate V8 benchmarks in testing
1649         <https://bugs.webkit.org/show_bug.cgi?id=20616>
1650
1651         Add support for the --v8 option to run-sunspider.
1652
1653         * Scripts/run-sunspider:
1654
1655 2008-09-04  Kevin Ollivier  <kevino@theolliviers.com>
1656
1657         wx buildbot fix. More robust handling of clean when makefiles are not built or 
1658         are not completely made.
1659
1660         * wx/build-wxwebkit:
1661
1662 2008-09-03  Mark Rowe  <mrowe@apple.com>
1663
1664         More Mac build fixes.
1665
1666         Set ENABLE_DASHBOARD_SUPPORT when building for Mac via build-webkit.
1667         Also set ENABLE_CROSS_DOCUMENT_MESSAGING in order to match the
1668         default configuration specified in the .xcconfig files.
1669
1670         * Scripts/build-webkit:
1671
1672 2008-09-03  Mark Rowe  <mrowe@apple.com>
1673
1674         Mac build fix.  Ensure that dashboard support is enabled.
1675
1676         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1677
1678 2008-08-25  Steve Falkenburg  <sfalken@apple.com>
1679
1680         Build fix. Copy correct version of ICU.
1681
1682         * DumpRenderTree/win/DumpRenderTree.vcproj:
1683
1684 2008-08-25  Holger Hans Peter Freyther  <zecke@selfish.org>
1685
1686         Reviewed by Simon.
1687
1688         [run-webkit-tests] Use QtLauncher to show the results of the tests
1689         konqueror might not be installed, xdg-open might not be installed but the
1690         QtLauncher should be present.
1691
1692         * Scripts/run-webkit-tests:
1693
1694 2008-08-24  Jon Honeycutt  <jhoneycutt@apple.com>
1695
1696         Initial support for accessibility layout tests on Windows.
1697         https://bugs.webkit.org/show_bug.cgi?id=20497
1698
1699         Reviewed by Sam Weinig.
1700
1701         * DumpRenderTree/AccessibilityController.h: Fix typos.
1702         * DumpRenderTree/AccessibilityUIElement.cpp: Change #import to #include.
1703         * DumpRenderTree/AccessibilityUIElement.h: Define _WINSOCKAPI_ to
1704         prevent oleacc.h, which includes windows.h, from including winsock.h.
1705         Fixed typos.
1706         * DumpRenderTree/win/AccessibilityControllerWin.cpp: Added.
1707         (AccessibilityController::AccessibilityController):
1708         (AccessibilityController::~AccessibilityController):
1709         (AccessibilityController::focusedElement): Get the root element, and
1710         request its focused object.
1711         (AccessibilityController::rootElement): Query Windows for the 
1712         accessible client object for the WebView's window.
1713         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Added.
1714         (AccessibilityUIElement::AccessibilityUIElement):
1715         (AccessibilityUIElement::~AccessibilityUIElement):
1716         (AccessibilityUIElement::getLinkedUIElements): Not implemented.
1717         (AccessibilityUIElement::getChildren): Get the child count, and append
1718         each child.
1719         (AccessibilityUIElement::getChildAtIndex): Get the child at the given
1720         index offset by 1. In MSAA, child 0 is the object itself.
1721         (AccessibilityUIElement::allAttributes): Not implemented.
1722         (AccessibilityUIElement::attributesOfLinkedUIElements): Same.
1723         (AccessibilityUIElement::attributesOfChildren): Same.
1724         (AccessibilityUIElement::parameterizedAttributeNames): Same.
1725         (self): Return a VARIANT representing the "self" object. This is used
1726         when calling methods that require a child variant.
1727         (AccessibilityUIElement::role): Get the MSAA role, a long value, and
1728         convert it into a string with GetRoleText().
1729         (AccessibilityUIElement::title): Get the element's title, and convert
1730         it to a JS String.
1731         (AccessibilityUIElement::description): Same, for description.
1732         (AccessibilityUIElement::width):
1733         (AccessibilityUIElement::height):
1734         (AccessibilityUIElement::intValue): Get the object's value as a string,
1735         and convert the string to a double.
1736         (AccessibilityUIElement::minValue): Not implemented.
1737         (AccessibilityUIElement::maxValue): Same.
1738         (AccessibilityUIElement::insertionPointLineNumber): Same.
1739         (AccessibilityUIElement::attributesOfColumnHeaders): Same.
1740         (AccessibilityUIElement::attributesOfRowHeaders): Same.
1741         (AccessibilityUIElement::attributesOfColumns): Same.
1742         (AccessibilityUIElement::attributesOfRows): Same.
1743         (AccessibilityUIElement::attributesOfVisibleCells): Same.
1744         (AccessibilityUIElement::attributesOfHeader): Same.
1745         (AccessibilityUIElement::indexInTable): Same.
1746         (AccessibilityUIElement::rowIndexRange): Same.
1747         (AccessibilityUIElement::columnIndexRange): Same.
1748         (AccessibilityUIElement::lineForIndex): Same.
1749         (AccessibilityUIElement::boundsForRange): Same.
1750         (AccessibilityUIElement::cellForColumnAndRow): Same.
1751         * DumpRenderTree/win/DumpRenderTree.vcproj: Add accessibility files to
1752         project.  Link to oleacc.lib, the MSAA library.
1753         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1754         (FrameLoadDelegate::FrameLoadDelegate): Initialize the accessibility
1755         controller.
1756         (FrameLoadDelegate::didClearWindowObject): Create a new window object
1757         for the accessibility controller.
1758         * DumpRenderTree/win/FrameLoadDelegate.h:
1759
1760 2008-08-21  Simon Fraser  <simon.fraser@apple.com>
1761
1762         Reviewed by Mark Rowe
1763         
1764         Make build-launcher-app work when run from a git repository.
1765         https://bugs.webkit.org/show_bug.cgi?id=20478
1766
1767         * BuildSlaveSupport/build-launcher-app:
1768
1769 2008-08-20  Maxime Britto  <britto@apple.com>
1770
1771         Reviewed by Ada Chan.
1772
1773          rdar://5259746
1774         Mouse events are sent to page while resizing window (affects Gmail)
1775
1776         * DumpRenderTree/win/UIDelegate.h:
1777         (UIDelegate::webViewSendResizeMessage): Add the new interface method, not implemented.
1778
1779 2008-08-19  Chris Fleizach  <cfleizach@apple.com>
1780
1781         Reviewed by Beth Dakin.
1782
1783         Add snowleopard platform in layout tests
1784
1785         Added support for accessing the attributes of
1786         accessibility tables through the accessibility controller
1787         in DumpRenderTree
1788
1789         * DumpRenderTree/AccessibilityUIElement.cpp:
1790         (attributesOfColumnHeadersCallback):
1791         (attributesOfRowHeadersCallback):
1792         (attributesOfColumnsCallback):
1793         (attributesOfRowsCallback):
1794         (attributesOfVisibleCellsCallback):
1795         (attributesOfHeaderCallback):
1796         (indexInTableCallback):
1797         (rowIndexRangeCallback):
1798         (columnIndexRangeCallback):
1799         (childAtIndexCallback):
1800         (cellForColumnAndRowCallback):
1801         (AccessibilityUIElement::getJSClass):
1802         * DumpRenderTree/AccessibilityUIElement.h:
1803         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1804         (convertNSArrayToVector):
1805         (descriptionOfElements):
1806         (AccessibilityUIElement::getLinkedUIElements):
1807         (AccessibilityUIElement::getChildren):
1808         (AccessibilityUIElement::attributesOfLinkedUIElements):
1809         (AccessibilityUIElement::attributesOfChildren):
1810         (AccessibilityUIElement::attributesOfColumnHeaders):
1811         (AccessibilityUIElement::attributesOfRowHeaders):
1812         (AccessibilityUIElement::attributesOfColumns):
1813         (AccessibilityUIElement::attributesOfRows):
1814         (AccessibilityUIElement::attributesOfVisibleCells):
1815         (AccessibilityUIElement::attributesOfHeader):
1816         (AccessibilityUIElement::indexInTable):
1817         (AccessibilityUIElement::rowIndexRange):
1818         (AccessibilityUIElement::columnIndexRange):
1819         (AccessibilityUIElement::cellForColumnAndRow):
1820         * Scripts/run-webkit-tests:
1821
1822 2008-08-19  Alexey Proskuryakov  <ap@webkit.org>
1823
1824         Reviewed by Darin Adler.
1825
1826         Fix run-webkit-tests misreporting crashed tests as timed out ones because DumpRenderTree
1827         is waiting for crash reporter to let it exit.
1828
1829         The fix does not work on Tiger, because the state of the process is indistinguishable from
1830         other waiting processes, at least not with this technique.
1831
1832         * Scripts/run-webkit-tests:
1833
1834 2008-08-18  Alp Toker  <alp@nuanti.com>
1835
1836         Reviewed by Holger Freyther.
1837
1838         https://bugs.webkit.org/show_bug.cgi?id=20350
1839         [GTK] Get DumpRenderTree working
1840
1841         Fixes and enhancements to DumpRenderTree. With these changes, the test
1842         suite can now complete a run producing text and render tree dumps.
1843
1844         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1845         (dumpFramesAsText):
1846         (dump):
1847         (runTest):
1848         (webViewLoadFinished):
1849         (webViewWindowObjectCleared):
1850         (webViewConsoleMessage):
1851         (webViewScriptAlert):
1852         (webViewScriptPrompt):
1853         (webViewScriptConfirm):
1854         (webViewTitleChanged):
1855         (main):
1856         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
1857         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1858         (LayoutTestController::clearBackForwardList):
1859         (LayoutTestController::pathToLocalResource):
1860         (LayoutTestController::setAcceptsEditing):
1861         (LayoutTestController::setUserStyleSheetEnabled):
1862         (LayoutTestController::setUserStyleSheetLocation):
1863         (waitToDumpWatchdogFired):
1864         (LayoutTestController::windowCount):
1865         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
1866         (JSStringCopyUTF8CString):
1867         (ScriptItem::invoke):
1868
1869 2008-08-17  Geoffrey Garen  <ggaren@apple.com>
1870
1871         Reviewed by Cameron Zwarich.
1872         
1873         Updated project files to XCode 3.1.
1874
1875         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
1876         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1877
1878 2008-08-15  Mark Rowe  <mrowe@apple.com>
1879
1880         Rubber-stamped by Geoff Garen.
1881
1882         <rdar://problem/6139914> Please include a _debug version of JavaScriptCore framework
1883
1884         * Scripts/check-for-global-initializers: Ignore initializers when building the debug variant.
1885
1886 2008-08-13  Simon Hausmann  <hausmann@webkit.org>
1887
1888         Rubber-stamped by Holger.
1889
1890         Revert r31585 and disable http tests for the Qt build again unless
1891         explicitly enabled.
1892
1893         Running the http tests unfortunately currently still triggers
1894         failures in non-http tests due to side-effects. Disable them by default for
1895         now, for more reliable results.
1896
1897         * Scripts/run-webkit-tests:
1898
1899 2008-08-10  Jan Michael Alonzo  <jmalonzo@webkit.org>
1900
1901         Reviewed (and updated) by Alp Toker.
1902
1903         https://bugs.webkit.org/show_bug.cgi?id=16620
1904         [GTK] Autotools make dist and make check support
1905
1906         Get make dist working.
1907
1908         Note that not all possible configurations have been tested yet.
1909
1910         * GNUmakefile.am:
1911
1912 2008-08-10  Alp Toker  <alp@nuanti.com>
1913
1914         Remove leftover qmake/GTK+ build files.
1915
1916         * DumpRenderTree/gtk/DumpRenderTree.pro: Removed.
1917         * GtkLauncher/GtkLauncher.pro: Removed.
1918
1919 2008-08-06  Chris Fleizach  <cfleizach@apple.com>
1920
1921         Reviewed by Beth Dakin
1922
1923         AX functions shouldn't return position information because it changes
1924         based on the platform
1925
1926         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1927         (AccessibilityUIElement::boundsForRange):
1928
1929 2008-08-06  Eric Seidel  <eric@webkit.org>
1930
1931         Reviewed by darin.
1932         
1933         Fix leaks seen on build-bot by fixing memory management of AccessibilityUIElement.
1934         <https://bugs.webkit.org/show_bug.cgi?id=20297>
1935         <rdar://problem/6093153>
1936         
1937         I've made AccessibilityUIElement a stack object for now.  It could be
1938         made RefCounted, but I figured that might be overkill for the moment.
1939         Essentially it's just a RefPtr itself. :)
1940         
1941         I also fixed a few typos, such as AccessibilityUIElement() instead of ~AccessibilityUIElement()
1942         which was causing additional leaks. :)
1943         
1944         I added toAXElement to remove a bunch of copy/paste code.
1945
1946         * DumpRenderTree/AccessibilityController.h:
1947         * DumpRenderTree/AccessibilityUIElement.cpp:
1948         (toAXElement):
1949         (allAttributesCallback):
1950         (attributesOfLinkedUIElementsCallback):
1951         (attributesOfChildrenCallback):
1952         (lineForIndexCallback):
1953         (boundsForRangeCallback):
1954         (childAtIndexCallback):
1955         (getRoleCallback):
1956         (getTitleCallback):
1957         (getDescriptionCallback):
1958         (getWidthCallback):
1959         (getHeightCallback):
1960         (getIntValueCallback):
1961         (getMinValueCallback):
1962         (getMaxValueCallback):
1963         (getInsertionPointLineNumberCallback):
1964         (finalize):
1965         * DumpRenderTree/AccessibilityUIElement.h:
1966         (AccessibilityUIElement::platformUIElement):
1967         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1968         (AccessibilityController::focusedElement):
1969         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1970         (AccessibilityUIElement::AccessibilityUIElement):
1971         (AccessibilityUIElement::getLinkedUIElements):
1972         (AccessibilityUIElement::getChildren):
1973         (AccessibilityUIElement::getChildAtIndex):
1974         (AccessibilityUIElement::attributesOfLinkedUIElements):
1975         (AccessibilityUIElement::attributesOfChildren):
1976
1977 2008-08-06  Eric Seidel  <eric@webkit.org>
1978
1979         Reviewed by Cameron Zwarich.
1980
1981         Speculative fix for an error I keep seeing in my Cygwin build
1982
1983         * Scripts/webkitdirs.pm: make determineConfigurationProductDir() always call determineConfiguration() even on cygwin
1984
1985 2008-08-02  Kevin Ollivier  <kevino@theolliviers.com>
1986
1987         Forgot to commit licensing correction in last commit.
1988
1989         * wx/packaging/wxWebKitInstaller.iss.in:
1990
1991 2008-08-02  Kevin Ollivier  <kevino@theolliviers.com>
1992
1993         Reviewed by Eric Seidel.
1994         
1995         Scripts for building a wxWebKit installer for wxPython on Win, eventually will
1996         be used for nightlies.
1997         
1998         https://bugs.webkit.org/show_bug.cgi?id=20036
1999
2000         * wx/packaging: Added.
2001         * wx/packaging/build-win-installer.py: Added.
2002         * wx/packaging/wxWebKitInstaller.iss.in: Added.
2003
2004 2008-07-31  Adam Roben  <aroben@apple.com>
2005
2006         Follow-up to r35500
2007
2008         * WinLauncher/WinLauncher.vcproj: Set the manifest properties for the
2009         Release configuration, too.
2010
2011 2008-07-31  Stefan Landvogt <stefan.landvogt@gmail.com>
2012
2013         Fix Bug 20245: WinLauncher does not start in WebKit-debug right out of
2014         the box
2015
2016         <https://bugs.webkit.org/show_bug.cgi?id=20245>
2017
2018         Reviewed by Adam Roben.
2019
2020         * WinLauncher/WinLauncher.vcproj: adding the following properties to
2021         WinLauncher > Properties > Manifest Tool > Isolated COM
2022         Type Library File: $(WebKitOutputDir)\lib\WebKit.tlb
2023         Component File Name: WebKit$(WebKitDLLConfigSuffix)
2024         Doing the change on "All Configurations"
2025
2026 2008-07-31  Adam Roben  <aroben@apple.com>
2027
2028         Windows build bot fix
2029
2030         * DumpRenderTree/win/ImageDiff.vcproj: Don't fail if files that only
2031         exist for people at Apple can't be found. Also updated the ICU version
2032         to 3.8.
2033
2034 2008-07-31  David Kilzer  <ddkilzer@apple.com>
2035
2036         Fix layout test results for webarchive/test-xml-stylesheet.xml
2037
2038         Reviewed by Darin Adler.
2039
2040         * DumpRenderTree/mac/DumpRenderTree.mm:
2041         (convertMIMEType): Work around the "text/xml" local file type
2042         regression in Leopard using the BUILDING_ON_LEOPARD macro.  Also
2043         stop mangling "application/x-javascript" into "text/javascript".
2044         (convertWebResourceDataToString): When checking whether to dump a
2045         resource as text, also check to see if the MIME type is in the
2046         -[WebHTMLRepresentation supportedNonImageMIMETypes] array.
2047         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added BUILDING_ON_LEOPARD
2048         macro.
2049
2050 2008-07-31  Chris Fleizach  <cfleizach@apple.com>
2051
2052         Reviewed by Alice Liu
2053
2054         Add AX support to get the bounds for a range of text
2055         Add AX support to get the child of an element
2056         Add AX support to get all the parameterized attribute names of an element
2057
2058         * DumpRenderTree/AccessibilityUIElement.cpp:
2059         (parameterizedAttributeNamesCallback):
2060         (boundsForRangeCallback):
2061         (childAtIndexCallback):
2062         (AccessibilityUIElement::getJSClass):
2063         * DumpRenderTree/AccessibilityUIElement.h:
2064         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2065         (AccessibilityUIElement::getChildAtIndex):
2066         (AccessibilityUIElement::parameterizedAttributeNames):
2067         (AccessibilityUIElement::boundsForRange):
2068
2069 2008-07-31  Erik Bunce  <elbunce@thehive.com>
2070
2071         Reviewed by Simon.
2072
2073         Make run-launcher set DYLD_LIBRARY_PATH to make things work on Mac OS X.
2074
2075         * Scripts/run-launcher:
2076
2077 2008-07-30  Jessica Kahn  <jess@apple.com>
2078
2079         Reviewed by Adam Roben.
2080
2081         Slightly stricter checking for previous change, suggested by Adam.
2082         
2083         * Scripts/extract-localizable-strings:
2084
2085 2008-07-30  Jessica Kahn  <jess@apple.com>
2086
2087         Reviewed by Darin Adler.
2088
2089         Added support for UI_STRING and UI_STRING_KEY macros with flexible prefixes.
2090         
2091         * Scripts/extract-localizable-strings:
2092
2093 2008-07-30  Anders Carlsson  <andersca@apple.com>
2094
2095         Reviewed by Adam.
2096
2097         Copy icu38* files instead of icu36* files.
2098         
2099         * DumpRenderTree/win/DumpRenderTree.vcproj:
2100
2101 2008-07-25  Jan Michael Alonzo  <jmalonzo@webkit.org>
2102
2103         DRT/Gtk build fix for r35362
2104
2105         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2106         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
2107
2108 2008-07-25  Brady Eidson  <beidson@apple.com>
2109
2110         Reviewed by Sam
2111
2112         Add the ability to dump whether-or-not an element should have autocomplete enabled, 
2113         from the perspective of the WebKit API
2114
2115         * DumpRenderTree/LayoutTestController.cpp:
2116         (elementDoesAutoCompleteForElementWithIdCallback):
2117         (LayoutTestController::staticFunctions):
2118
2119         * DumpRenderTree/LayoutTestController.h:
2120         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2121         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
2122         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2123         (LayoutTestController::elementDoesAutoCompleteForElementWithId): Stub for now until I can get on Windows
2124
2125 2008-07-25  Chris Fleizach  <cfleizach@apple.com>
2126
2127         Reviewed by Beth Dakin
2128
2129         Add support for AXLineForIndex and AXInsertionPointIndex through the 
2130         accessibility controller
2131
2132         * DumpRenderTree/AccessibilityUIElement.cpp:
2133         (lineForIndexCallback):
2134         (getInsertionPointLineNumberCallback):
2135         (AccessibilityUIElement::getJSClass):
2136         * DumpRenderTree/AccessibilityUIElement.h:
2137         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2138         (AccessibilityUIElement::insertionPointLineNumber):
2139         (AccessibilityUIElement::lineForIndex):
2140
2141 2008-07-25  Adam Roben  <aroben@apple.com>
2142
2143         Try to fix the Windows build bot
2144
2145         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't try to copy files
2146         that don't exist for people outside of Apple.
2147
2148 2008-07-18  Landry Breuil  <landry@openbsd.org>
2149
2150         Bug 19975: [OpenBSD] Patches to enable build of WebKit
2151
2152         <https://bugs.webkit.org/show_bug.cgi?id=19975>
2153
2154         Reviewed by David Kilzer.
2155
2156         * DumpRenderTree/DumpRenderTree.h: OpenBSD doesn't support wide characters.
2157
2158 2008-07-16  Jon Honeycutt  <jhoneycutt@apple.com>
2159
2160         CygwinDownloader fails to install necessary packages
2161         https://bugs.webkit.org/show_bug.cgi?id=20075
2162
2163         Reviewed by Mark Rowe.
2164
2165         * CygwinDownloader/cygwin-downloader.zip: Rebuilt after two broken
2166         mirrors removed in r34116. Set MIME type to application/octet-stream.
2167
2168 2008-07-16  Jon Honeycutt  <jhoneycutt@apple.com>
2169
2170         CygwinDownloader's make-zip.sh script fails
2171         https://bugs.webkit.org/show_bug.cgi?id=20074
2172
2173         Reviewed by Mark Rowe.
2174
2175         * CygwinDownloader/cygwin-downloader.py:
2176
2177 2008-07-15  Sam Weinig  <sam@webkit.org>
2178
2179         Reviewed by Anders Carlsson.
2180
2181         Refactor accessibility testing code.
2182
2183         We now have:
2184         - AccessibilityController
2185           Controller which has access to the WebView and can provide the focused element, root element
2186           and in the future, elementAtPoint.
2187
2188         - AccessibilityUIElement
2189           Object which provides access to the data provided by the Accessibility APIs.
2190
2191         * DumpRenderTree/AccessibilityController.cpp:
2192         (getFocusedElementCallback):
2193         (getRootElementCallback):
2194         (AccessibilityController::getJSClass):
2195         * DumpRenderTree/AccessibilityController.h:
2196         * DumpRenderTree/AccessibilityUIElement.cpp: Added.
2197         (allAttributesCallback):
2198         (attributesOfLinkedUIElementsCallback):
2199         (attributesOfChildrenCallback):
2200         (getRoleCallback):
2201         (getTitleCallback):
2202         (getDescriptionCallback):
2203         (getWidthCallback):
2204         (getHeightCallback):
2205         (getIntValueCallback):
2206         (getMinValueCallback):
2207         (getMaxValueCallback):
2208         (finalize):
2209         (AccessibilityUIElement::makeJSAccessibilityUIElement):
2210         (AccessibilityUIElement::getJSClass):
2211         * DumpRenderTree/AccessibilityUIElement.h: Added.
2212         (AccessibilityUIElement::platformUIElement):
2213         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2214         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2215         (AccessibilityController::AccessibilityController):
2216         (AccessibilityController::~AccessibilityController):
2217         (AccessibilityController::focusedElement):
2218         (AccessibilityController::rootElement):
2219         * DumpRenderTree/mac/AccessibilityUIElementMac.mm: Added.
2220         (AccessibilityUIElement::AccessibilityUIElement):
2221         (descriptionOfValue):
2222         (attributesOfElement):
2223         (nsStringToJSStringRef):
2224         (concatenateAttributeAndValue):
2225         (AccessibilityUIElement::getLinkedUIElements):
2226         (AccessibilityUIElement::getChildren):
2227         (AccessibilityUIElement::attributesOfLinkedUIElements):
2228         (AccessibilityUIElement::attributesOfChildren):
2229         (AccessibilityUIElement::allAttributes):
2230         (AccessibilityUIElement::role):
2231         (AccessibilityUIElement::title):
2232         (AccessibilityUIElement::description):
2233         (AccessibilityUIElement::width):
2234         (AccessibilityUIElement::height):
2235         (AccessibilityUIElement::intValue):
2236         (AccessibilityUIElement::minValue):
2237         (AccessibilityUIElement::maxValue):
2238
2239 2008-07-14  Chris Fleizach  <cfleizach@apple.com>
2240
2241         Reviewed by Beth Dakin
2242
2243         Add support to get attributes of the AXChildren of an objecty
2244
2245         * DumpRenderTree/AccessibilityController.cpp:
2246         (attributesOfChildrenForFocusedElementCallback):
2247         (AccessibilityController::staticFunctions):
2248         * DumpRenderTree/AccessibilityController.h:
2249         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2250         (descriptionOfValue):
2251         (AccessibilityController::attributesOfChildrenForFocusedElement):
2252
2253 2008-07-14  Steve Falkenburg  <sfalken@apple.com>
2254
2255         Build fix.
2256
2257         * DumpRenderTree/win/DumpRenderTree.vcproj:
2258
2259 2008-07-14  Adam Roben  <aroben@apple.com>
2260
2261         Attempted Windows build fix
2262
2263         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Add
2264         CoreFoundation/OSXCompatibilityHeaders[/GNUCompatibility] to the
2265         include path.
2266
2267 2008-07-14  Alexey Proskuryakov  <ap@webkit.org>
2268
2269         Reviewed by Geoff Garen.
2270
2271         Eliminate per-thread JavaScript global data instance support and make arbitrary
2272         global data/global object combinations possible.
2273
2274         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
2275         (runJavaScriptThread): Don't pass a released context reference to JSGarbageCollect.
2276         In this scenario, it was causing crashes after each 10-20 tests, because there was a large
2277         chance for a different thread to cause GC after the context was released.
2278
2279 2008-07-11  Stephanie Lewis  <slewis@apple.com>
2280
2281         Reviewed by Darin Adler.
2282
2283         Make sure we read WebCore Leak messages.  Force full document teardown for DumpRenderTree.
2284
2285         Up timeout limit, some slower machines were timing out before crashtracer finished writing out to disk and quitting DRT.
2286
2287         * DumpRenderTree/mac/DumpRenderTree.mm:
2288         (setDefaultsToConsistentValuesForTesting):
2289         (resetWebViewToConsistentStateBeforeTesting):
2290         * Scripts/run-webkit-tests:
2291
2292 2008-07-10  Steve Falkenburg  <sfalken@apple.com>
2293
2294         Build fix.
2295
2296         * DumpRenderTree/win/DumpRenderTree.vcproj:
2297
2298 2008-07-09  Eric Seidel  <eric@webkit.org>
2299
2300         Reviewed by Mark Rowe.
2301         
2302         Print <div> backgrounds when printing from DRT.
2303
2304         * DumpRenderTree/mac/DumpRenderTree.mm:
2305         (setDefaultsToConsistentValuesForTesting):
2306
2307 2008-07-09  Eric Seidel  <eric@webkit.org>
2308
2309         Reviewed by Mark Rowe.
2310
2311         Fix copying of expected results to correct location
2312
2313         * Scripts/run-webkit-tests:
2314
2315 2008-07-09  Eric Seidel  <eric@webkit.org>
2316
2317         Reviewed by aroben.
2318
2319         * DumpRenderTree/LayoutTestController.cpp:
2320         (LayoutTestController::LayoutTestController):
2321         (dumpAsPDFCallback):
2322         (LayoutTestController::staticFunctions):
2323         * DumpRenderTree/LayoutTestController.h:
2324         (LayoutTestController::dumpAsPDF):
2325         (LayoutTestController::setDumpAsPDF):
2326         * DumpRenderTree/mac/DumpRenderTree.mm:
2327         (dumpFrameAsPDF):
2328         (dump):
2329
2330 2008-07-09  Eric Seidel  <eric@webkit.org>
2331
2332         Reviewed by weinig.
2333
2334         Add Content-Type support to DumpRenderTree and run-webkit-tests
2335         and move expected.txt files to expected.webarchive
2336         
2337         https://bugs.webkit.org/show_bug.cgi?id=15565
2338
2339         * DumpRenderTree/cg/ImageDiffCG.cpp:
2340         (compareImages):
2341         (main):
2342         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2343         (printPNG):
2344         * DumpRenderTree/mac/DumpRenderTree.mm:
2345         (dump):
2346         * Scripts/run-webkit-tests:
2347
2348 2008-07-08  Jon Honeycutt  <jhoneycutt@apple.com>
2349
2350         Reviewed by Anders.
2351
2352         Port r34988 to Mac: allow tests to define JavaScript to execute when
2353         NPP_DestroyStream or NPP_URLNotify is called.
2354
2355         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2356         (NPP_New): Remove initialization that happens in pluginAllocate. Look
2357         for new arguments onStreamDestroy and onURLNotify.
2358         (NPP_Destroy): Free onStreamDestroy and onURLNotify.
2359         (executeScript): Code moved from onStreamLoad.
2360         (NPP_NewStream): Call executeScript.
2361         (NPP_DestroyStream): Same.
2362         (NPP_URLNotify): Same.
2363
2364 2008-07-07  Beth Dakin  <bdakin@apple.com>
2365
2366         Reviewed by Anders.
2367
2368         This patch extends DRT accessibility tests to add the ability to 
2369         query the intValue, minValue, and maxValue of the focused element.
2370
2371         * DumpRenderTree/AccessibilityController.cpp:
2372         (intValueOfFocusedElementCallback):
2373         (minValueOfFocusedElementCallback):
2374         (maxValueOfFocusedElementCallback):
2375         (AccessibilityController::staticFunctions):
2376         * DumpRenderTree/AccessibilityController.h:
2377         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2378         (AccessibilityController::intValueOfFocusedElement):
2379         (AccessibilityController::minValueOfFocusedElement):
2380         (AccessibilityController::maxValueOfFocusedElement):
2381
2382 2008-07-07  Steve Falkenburg  <sfalken@apple.com>
2383
2384         Fix build.
2385
2386         * DumpRenderTree/win/ImageDiff.vcproj:
2387
2388 2008-07-02  Jon Honeycutt  <jhoneycutt@apple.com>
2389
2390         Allow tests to define JavaScript to execute when NPP_DestroyStream or
2391         NPP_URLNotify is called.
2392
2393         Reviewed by Anders.
2394
2395         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add a new
2396         property, "returnErrorFromNewStream." This is to support the test for
2397         <rdar://5983747> Safari crashes trying to load the SilverLight plugin,
2398         caused by WebKit calling NPP_DestroyStream after a plug-in returns an
2399         error from NPP_NewStream.
2400         (pluginGetProperty): 
2401         (pluginSetProperty):
2402         (pluginAllocate):
2403         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Added new
2404         members, onStreamDestroy and onURLNotify.
2405         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
2406         (NPP_New): Remove initialization of onStreamLoad; this was moved to
2407         pluginAllocate. Look for new arguments onStreamDestroy and
2408         onURLNotify, and store their values.
2409         (NPP_Destroy): Free new members.
2410         (executeScript): Code moved from onStreamLoad
2411         (NPP_NewStream): If returnErrorFromNewStream has been set to true,
2412         return a generic error code. If onStreamLoad is set, execute it as
2413         JavaScript.
2414         (NPP_DestroyStream): If onStreamDestroy is set, execute it as JS.
2415         (NPP_URLNotify): Same, for onURLNotify.
2416
2417 2008-07-02  Brady Eidson  <beidson@apple.com>
2418
2419         Reviewed by Mitz Pettel and John Sullivan
2420
2421         Add the ability to tell DRT to call stopLoading on a WebFrame inside of a didStartProvisionalLoadForFrame
2422         load delegate.
2423
2424         Required to add a layout test for the fix for <rdar://problem/5549871>
2425
2426         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2427         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): If stopProvisionalFrameLoads is set, call
2428           [WebFrame stopLoading] to test for the crash reflected in 5549871
2429
2430         All of the following are infrastructure to add the layoutTestController.setStopProvisionalFrameLoads() call:
2431         * DumpRenderTree/LayoutTestController.cpp:
2432         (LayoutTestController::LayoutTestController):
2433         (setStopProvisionalFrameLoadsCallback):
2434         (LayoutTestController::staticFunctions):
2435         * DumpRenderTree/LayoutTestController.h:
2436         (LayoutTestController::stopProvisionalFrameLoads):
2437         (LayoutTestController::setStopProvisionalFrameLoads):
2438
2439 2008-07-01  Chris Fleizach  <cfleizach@apple.com>
2440
2441         Reviewed by Beth Dakin
2442
2443         Support ability to get width and height of an element through accessibility
2444
2445         * DumpRenderTree/AccessibilityController.cpp:
2446         (widthOfFocusedElementCallback):
2447         (heightOfFocusedElementCallback):
2448         (AccessibilityController::staticFunctions):
2449         * DumpRenderTree/AccessibilityController.h:
2450         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2451         (AccessibilityController::widthOfFocusedElement):
2452         (AccessibilityController::heightOfFocusedElement):
2453
2454 2008-06-30  Chris Fleizach  <cfleizach@apple.com>
2455
2456         Reviewed by Beth Dakin
2457
2458         Support the ability to get the linked ui elements of an object
2459
2460         * DumpRenderTree/AccessibilityController.cpp:
2461         (attributesOfLinkedUIElementsForFocusedElementCallback):
2462         (AccessibilityController::staticFunctions):
2463         * DumpRenderTree/AccessibilityController.h:
2464         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2465         (AccessibilityController::attributesOfLinkedUIElementsForFocusedElement):
2466         (AccessibilityController::allAttributesOfFocusedElement):
2467         (attributesOfElement):
2468         (nsStringToJSStringRef):
2469
2470 2008-06-29  Sam Weinig  <sam@webkit.org>
2471
2472         Fix Tiger build.
2473
2474         * DumpRenderTree/mac/EventSendingController.mm:
2475         (eventTypeForMouseButtonAndAction):
2476
2477 2008-06-27  Eric Seidel  <eric@webkit.org>
2478
2479         Reviewed by darin.
2480
2481         Add multi-button mouseevent support to DRT
2482         https://bugs.webkit.org/show_bug.cgi?id=15173
2483         
2484         It's now possible to specify the mouse button with:
2485         eventSender.mouseDown(1); eventSender.mouseUp(1); etc.
2486
2487         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2488         * DumpRenderTree/mac/EventSendingController.h:
2489         * DumpRenderTree/mac/EventSendingController.mm:
2490         (+[EventSendingController isSelectorExcludedFromWebScript:]):
2491         (+[EventSendingController webScriptNameForSelector:]):
2492         (eventTypeForMouseButtonAndAction):
2493         (-[EventSendingController updateClickCountForButton:]):
2494         (-[EventSendingController mouseDown:]):
2495         (-[EventSendingController mouseUp:]):
2496         (-[EventSendingController mouseMoveToX:Y:]):
2497         (-[EventSendingController contextClick]):
2498
2499 2008-06-28  Nikolas Zimmermann  <zimmermann@kde.org>
2500
2501         Reviewed by Oliver.
2502
2503         Copy <test>-expected.png from the right location to /tmp/layout-test-results.
2504         Use $expectedPixelDir instead of $expectedDir. Allows using SVG pixel tests again.
2505
2506         * Scripts/run-webkit-tests:
2507
2508 2008-06-27  Jan Michael Alonzo  <jmalonzo@webkit.org>
2509
2510         Reviewed by Christian Dywan.
2511
2512         [Gtk] Initialize webview settings before running DRT tests
2513         http://bugs.webkit.org/show_bug.cgi?id=19778
2514
2515         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2516         (setDefaultsToConsistentStateValuesForTesting):
2517         (main):
2518
2519 2008-06-26  Darin Adler  <darin@apple.com>
2520
2521         * Scripts/check-for-weak-vtables: Fixed comment.
2522
2523 2008-06-26  Darin Adler  <darin@apple.com>
2524
2525         * Scripts/check-for-weak-vtables: Added.
2526
2527 2008-06-26  Beth Dakin  <bdakin@apple.com>
2528
2529         Reviewed by Sam.
2530
2531         Do not include AXPosition in the dump of all of the accessibility 
2532         attributes since it is screen-specific.
2533
2534         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2535         (AccessibilityController::allAttributesOfFocusedElement):
2536
2537 2008-06-26  Beth Dakin  <bdakin@apple.com>
2538
2539         Reviewed by Anders.
2540
2541         This is a speculative fix for the failing layout test on the build 
2542         bot. It seems that the problem that the Build Bot is having is 
2543         Tiger-specific. On Tiger, [NSValue description] was not very smart. 
2544         So I replaced our call to description with a hand-rolled equivalent 
2545         that will match on both platforms. 
2546
2547         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2548         (descriptionOfValue):
2549
2550 2008-06-25  Beth Dakin  <bdakin@apple.com>
2551
2552         Reviewed by Sam Weinig.
2553
2554         This patch adds support to the AccessibilityController to query the 
2555         following attributes specifically, without a full attribute dump: 
2556         AXRole, AXTitle, and AXDescription.
2557
2558         * DumpRenderTree/AccessibilityController.cpp:
2559         (allAttributesForFocusedElementCallback):
2560         (roleOfFocusedElementCallback):
2561         (titleOfFocusedElementCallback):
2562         (descriptionOfFocusedElementCallback):
2563         (AccessibilityController::staticFunctions):
2564         * DumpRenderTree/AccessibilityController.h:
2565         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2566         (AccessibilityController::allAttributesForFocusedElement):
2567         (concatenateAttributeAndValue):
2568         (AccessibilityController::roleOfFocusedElement):
2569         (AccessibilityController::titleOfFocusedElement):
2570         (AccessibilityController::descriptionOfFocusedElement):
2571
2572 2008-06-24  Dan Bernstein  <mitz@apple.com>
2573
2574         Reviewed by Stephanie Lewis.
2575
2576         - move the linker flags from the debug configuration in the project
2577           to the shared configuration
2578
2579         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2580         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2581
2582 2008-06-24  Dan Bernstein  <mitz@apple.com>
2583
2584         - try to fix the Tiger build
2585
2586         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2587
2588 2008-06-24  Sam Weinig and Beth Dakin  <bdakin@apple.com and sam@webkit.org>
2589
2590         Reviewed by Darin Adler.
2591
2592         Fix for <rdar://problem/5884881> Make DumpRenderTree support 
2593         accessibility tests
2594
2595         This patch adds some basic support for accessibility layout tests 
2596         on the Mac.
2597
2598         * DumpRenderTree/AccessibilityController.cpp: Added.
2599         (AccessibilityController::AccessibilityController):
2600         (AccessibilityController::~AccessibilityController):
2601         (dumpCurrentAttributesCallback):
2602         (AccessibilityController::makeWindowObject):
2603         (AccessibilityController::getJSClass):
2604         (AccessibilityController::staticFunctions):
2605         * DumpRenderTree/AccessibilityController.h: Added.
2606         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2607         * DumpRenderTree/mac/AccessibilityControllerMac.mm: Added.
2608         (descriptionOfValue):
2609         (AccessibilityController::dumpCurrentAttributes):
2610         * DumpRenderTree/mac/DumpRenderTree.mm:
2611         * DumpRenderTree/mac/FrameLoadDelegate.h:
2612         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2613         (-[FrameLoadDelegate init]):
2614         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2615
2616 2008-06-24  John Sullivan  <sullivan@apple.com>
2617
2618         Reviewed by Dan Bernstein
2619
2620         * Scripts/extract-localizable-strings:
2621         add UI_STRING_LOCALIZE_LATER, LPCTSTR_UI_STRING_LOCALIZE_LATER, and LOG_WARNING to the 
2622         list of debugging macros, to avoid noise when keeping the list of localized string 
2623         exceptions up to date
2624
2625 2008-06-24  Dan Bernstein  <mitz@apple.com>
2626
2627         Rubber-stamped by Darin Adler.
2628
2629         - add a font family for testing font-weight
2630
2631         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linker
2632         flags to create data sections for the WeightWatcher fonts.
2633         * DumpRenderTree/fonts: Added.
2634         * DumpRenderTree/fonts/WebKitWeightWatcher100.ttf: Added.
2635         * DumpRenderTree/fonts/WebKitWeightWatcher200.ttf: Added.
2636         * DumpRenderTree/fonts/WebKitWeightWatcher300.ttf: Added.
2637         * DumpRenderTree/fonts/WebKitWeightWatcher400.ttf: Added.
2638         * DumpRenderTree/fonts/WebKitWeightWatcher500.ttf: Added.
2639         * DumpRenderTree/fonts/WebKitWeightWatcher600.ttf: Added.
2640         * DumpRenderTree/fonts/WebKitWeightWatcher700.ttf: Added.
2641         * DumpRenderTree/fonts/WebKitWeightWatcher800.ttf: Added.
2642         * DumpRenderTree/fonts/WebKitWeightWatcher900.ttf: Added.
2643         * DumpRenderTree/mac/DumpRenderTree.mm:
2644         (activateFonts): Renamed activateAhemFont to this and made it activate
2645         the WeightWatcher fonts in addition to Ahem.
2646         (prepareConsistentTestingEnvironment): Adjusted for the name change.
2647         * DumpRenderTree/win/DumpRenderTree.cpp:
2648         (initialize): Added the WeightWatcher fonts.
2649
2650 2008-06-20  Brent Fulgham  <bfulgham@gmail.com>
2651
2652         Reviewed by Darin Adler.
2653
2654         Extend the build-webkit (and set-webkit-configuration) script to
2655         support Cairo-based webkit builds.  (see http://bugs.webkit.org/show_bug.cgi?17952)
2656
2657         * Scripts/build-webkit:  Add --cairo-win32 to the help message
2658         * Scripts/webkitdirs.pm:  Extend the 'determinePassedConfiguration
2659           subroutine to recognize the --cairo-win32 flag.  When present,
2660           the build configuration is changed from Debug/Release to
2661           Debug_Cairo/Release_Cairo.  This flag is only active when the
2662           isCygwin() test is true.
2663
2664 2008-06-17  Dan Bernstein  <mitz@apple.com>
2665
2666         Reviewed by Justin Garcia.
2667
2668         - prefer Leopard results when running on Snow Leopard.
2669
2670         * Scripts/run-webkit-tests: Added a mapping of Snow Leopard to
2671           mac-leopard.
2672         * Scripts/webkitdirs.pm: Added isSnowLeopard().
2673
2674 2008-06-15  Darin Adler  <darin@apple.com>
2675
2676         * Scripts/do-webcore-rename: Updated for the latest round of renaming.
2677
2678 2008-06-15  Darin Adler  <darin@apple.com>
2679
2680         * Scripts/do-webcore-rename: Updated for the latest round of renaming.
2681
2682 2008-06-15  Darin Adler  <darin@apple.com>
2683
2684         * Scripts/do-webcore-rename: Updated for the latest round of renaming.
2685
2686 2008-06-15  Darin Adler  <darin@apple.com>
2687
2688         * Scripts/do-webcore-rename: Updated for the latest round of renaming.
2689
2690 2008-06-15  Darin Adler  <darin@apple.com>
2691
2692         * Scripts/do-file-rename: Updated.
2693         * Scripts/do-webcore-rename: Updated for the latest round of renaming.
2694
2695 2008-06-15  Darin Adler  <darin@apple.com>
2696
2697         * Scripts/do-file-rename: Updated for the latest round of renaming.
2698         * Scripts/do-webcore-rename: Tweaked and reorganized a bit.
2699
2700 2008-06-15  Darin Adler  <darin@apple.com>
2701
2702         * Scripts/create-exports: Added.
2703         * Scripts/do-file-rename: Added some planned renames.
2704         * Scripts/do-webcore-rename: Updated for the latest round of renaming.
2705
2706 2008-06-15  Darin Adler  <darin@apple.com>
2707
2708         * Scripts/do-webcore-rename: Updated for the latest round of renaming.
2709
2710 2008-06-15  Maciej Stachowiak  <mjs@apple.com>
2711
2712         Reviewed by Oliver.
2713         
2714         - rename testkjs to jsc
2715
2716         * Scripts/build-jsc: Copied from Scripts/build-testkjs.
2717         * Scripts/build-testkjs: Removed.
2718         * Scripts/run-javascriptcore-tests:
2719         * Scripts/run-jsc: Copied from Scripts/run-testkjs.
2720         * Scripts/run-sunspider:
2721         * Scripts/run-testkjs: Removed.
2722         * Scripts/sunspider-compare-results:
2723
2724 2008-06-14  Darin Adler  <darin@apple.com>
2725
2726         * Scripts/do-webcore-rename: Moved planned renames into a separate hash
2727         from the actual renames. Removed many renames that are either done or
2728         no longer planned.
2729
2730 2008-06-14  Darin Adler  <darin@apple.com>
2731
2732         * Scripts/do-webcore-rename: Fixed obvious typo.
2733
2734 2008-06-13  Darin Adler  <darin@apple.com>
2735
2736         * Scripts/make-js-test-wrappers: Added three more exceptions.
2737
2738 2008-06-10  Joerg Bornemann  <joerg.bornemann@trolltech.com>
2739
2740         Reviewed by Simon.
2741
2742         For the qmake based build make it possible to build against makespecs where
2743         QMAKE_CC is defined in a configuration file included from qmake.conf.
2744
2745         * Scripts/webkitdirs.pm: Added support for include() statements in
2746         qmake.conf.
2747
2748 2008-06-09  Alp Toker  <alp@nuanti.com>
2749
2750         gcc3/autotools build fix. Add explicit -O2 -fno-strict-aliasing to
2751         each of the tools since these are no longer set globally.
2752
2753         * GNUmakefile.am:
2754
2755 2008-06-08  Darin Adler  <darin@apple.com>
2756
2757         * Scripts/make-js-test-wrappers: Added another exception.
2758
2759 2008-06-07  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
2760
2761         Reviewed by Timothy.
2762
2763         Remove the --squirrelfish option from SunSpider, as it is no longer needed.
2764
2765         * Scripts/run-sunspider:
2766
2767 2008-06-05  Alp Toker  <alp@nuanti.com>
2768
2769         Build fix for r34387.
2770
2771         * GNUmakefile.am:
2772
2773 2008-06-04  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
2774
2775         Reviewed by Oliver.
2776
2777         Add an exception for Opcode.o to the global initializers check so that
2778         we can dump instruction statistics in the JavaScript virtual machine.
2779
2780         * Scripts/check-for-global-initializers:
2781
2782 2008-05-30  Steve Falkenburg  <sfalken@apple.com>
2783
2784         Generate an isolated COM manifest for registry free COM.
2785         
2786         * DumpRenderTree/win/DumpRenderTree.vcproj:
2787
2788 2008-06-02  Anders Carlsson  <andersca@apple.com>
2789
2790         Reviewed by David Hyatt and Mitz.
2791
2792         <rdar://problem/5704119> 
2793         repro crash in WebCore::RenderPart::setWidget (plugin-related?)
2794         
2795         Call -[WebView display] in the "plug-in" failed delegate method, simulating
2796         the sheet that Safari puts up.
2797         
2798         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2799         (-[ResourceLoadDelegate webView:plugInFailedWithError:dataSource:]):
2800
2801 2008-05-30  Timothy Hatcher  <timothy@apple.com>
2802
2803         Made the starting line number of scripts be 1-based throughout the engine.
2804         This cleans up script line numbers so they are all consistent now.
2805
2806         Reviewed by Oliver Hunt.
2807
2808         * DumpRenderTree/mac/ObjCController.m:
2809         (runJavaScriptThread): Pass a line number of 1 instead of 0 to JSEvaluateScript.
2810         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
2811         (runJavaScriptThread): Ditto.
2812         * DumpRenderTree/win/DumpRenderTree.cpp:
2813         (runJavaScriptThread): Ditto.
2814
2815 2008-05-29  Geoffrey Garen  <ggaren@apple.com>
2816
2817         Reviewed by Adam Roben.
2818
2819         Fixed VCSUtils.pm to work with git repositories inside symlinks.
2820
2821         * Scripts/VCSUtils.pm: Compute a relative path from the git repository
2822         root, instead of the root of the filesystem, to work around a bug in
2823         abs2rel when traversing symlinked home directories.
2824
2825 2008-05-29  Kevin Ollivier  <kevino@theolliviers.com>
2826
2827         Reviewed by Darin Adler.
2828         
2829         Restore original behavior of isOSX() referring to the Mac port, not the OS itself.
2830         
2831         https://bugs.webkit.org/show_bug.cgi?id=19311
2832
2833         * Scripts/webkitdirs.pm:
2834
2835 2008-05-29  Alexey Proskuryakov  <ap@webkit.org>
2836
2837         Reviewed by Adam Roben.
2838
2839         Fix run-iexploder-tests and run-mangleme-tests to work with updated shared scripts and
2840         configuration files.
2841
2842         * Scripts/run-iexploder-tests:
2843         * Scripts/run-mangleme-tests:
2844         Renamed runSafari to not conflict with the one in webkitdirs.
2845         Added SSLCertificateFile option for httpd, as now needed.
2846
2847 2008-05-27  Kevin Ollivier  <kevino@theolliviers.com>
2848
2849         wx build fix. Update the sample app after wxWebFrame->wxWebBrowserShell rename.
2850
2851         * wx/browser/browser.cpp:
2852         (MyApp::OnInit):
2853
2854 2008-05-24  Andreia Gaita  <shana@isninja.com>
2855
2856         Reviewed by Alp Toker.
2857
2858         cygwin-downloader.py fixes.
2859
2860         Remove two non-working mirrors. Add a check for missing dependency
2861         packages to avoid bailing out on an inconsistent Cygwin package list.
2862
2863         * CygwinDownloader/cygwin-downloader.py:
2864
2865 2008-05-24  Jan Michael Alonzo  <jmalonzo@webkit.org>
2866
2867         Reviewed by Darin Adler.
2868
2869         Remove useQmake usage. QMake build doesn't support Gtk port
2870         anymore.
2871
2872         Also fix 2 occurences of "Web Kit". Should be WebKit.
2873
2874         * Scripts/build-webkit:
2875         * Scripts/run-javascriptcore-tests:
2876         * Scripts/run-launcher:
2877         * Scripts/run-webkit-tests:
2878         * Scripts/webkitdirs.pm:
2879
2880 2008-05-22  Stephanie Lewis  <slewis@apple.com>
2881
2882         Reviewed by Dan.
2883
2884         implement the beforeUnload UI delegate so that DRT will dispatch beforeunload events.
2885
2886         * DumpRenderTree/mac/UIDelegate.mm:
2887         (-[UIDelegate webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:]):
2888         * DumpRenderTree/win/UIDelegate.cpp:
2889         (SearchableWebViewHost::runBeforeUnloadConfirmPanelWithMessage):
2890
2891 2008-05-21  Adele Peterson  <adele@apple.com>
2892
2893         Reviewed by Adam.
2894
2895         DumpRenderTree support for <rdar://problem/5787733> fast/dom/HTMLDocument/hasFocus.html fails on Windows
2896
2897         * DumpRenderTree/win/UIDelegate.cpp:
2898         (UIDelegate::webViewFocus): Added.
2899         (UIDelegate::webViewUnfocus): Added.
2900         * DumpRenderTree/win/UIDelegate.h:
2901
2902 2008-05-21  Mark Rowe  <mrowe@apple.com>
2903
2904         Rubber-stamped by Stephanie Lewis.
2905
2906         Set the pass_through flag on Getopt so that extra arguments can be passed through to Safari,
2907         rather than trigger an unknown argument message.  This allows run-webkit-tests to display results
2908         once more.
2909
2910         * Scripts/run-safari:
2911
2912 2008-05-21  Stephanie Lewis  <slewis@apple.com>
2913
2914         Reviewed by Maciej, Mark.
2915   
2916         arch doesn't take arguments on tiger.  expand DRT timeout for guardMalloc.
2917
2918         * Scripts/run-webkit-tests:
2919         * Scripts/webkitdirs.pm:
2920
2921 2008-05-20  Mark Rowe  <mrowe@apple.com>
2922
2923         Reviewed by Stephanie Lewis.
2924
2925         Improve the behavior of run-webkit-tests with 64-bit WebKit by automatically inferring whether to run 64-bit.
2926
2927         If --64-bit is not passed to run-webkit-tests, attempt to guess whether we should run 64-bit.
2928         This decision is made based on the 64-bitness of the built WebKit framework if it exists, and
2929         can be manually overridden by passing --64-bit or --no-64-bit.  This removes the need to always
2930         pass an argument to run-webkit-tests after having built with "make x86_64".
2931
2932         * Scripts/gdb-safari:
2933         * Scripts/run-safari:
2934         * Scripts/run-webkit-tests:
2935         * Scripts/webkitdirs.pm: Split the setting of the 64-bit flag, the determination of the
2936         preferred architecture, and exporting of the environment variables for 'arch' out into
2937         separate subroutines.
2938
2939 2008-05-20  Mark Rowe  <mrowe@apple.com>
2940
2941         Fix "make x86_64" by adding x86_64 target to WebKitTools Makefile.
2942
2943         * Makefile:
2944
2945 === End merge of squirrelfish ===
2946
2947 2008-04-14  Maciej Stachowiak  <mjs@apple.com>
2948
2949         Reviewed by Oliver.
2950         
2951         - added support for --ubench mode
2952
2953         * Scripts/run-sunspider:
2954
2955 2008-03-26  Geoffrey Garen  <ggaren@apple.com>
2956
2957         Reviewed by Oliver Hunt.
2958
2959         --squirrelfish mode: pared down tests for squirrelfish to chew on.
2960
2961         * Scripts/run-sunspider:
2962
2963 === Start merge of squirrelfish ===
2964
2965 2008-05-21  Darin Adler  <darin@apple.com>
2966
2967         * Scripts/make-js-test-wrappers: Added another exception.
2968
2969 2008-05-19  Stephanie Lewis  <slewis@apple.com>
2970
2971         Reviewed by Adam.
2972
2973         Explicitly set run mode to 32bit unless overridden to avoid
2974         confusion when running tests
2975
2976         * Scripts/build-dumprendertree:
2977         * Scripts/gdb-safari:
2978         * Scripts/run-webkit-tests:
2979         * Scripts/webkitdirs.pm:
2980
2981 2008-05-16  Stephanie Lewis  <slewis@apple.com>
2982
2983         Reviewed by Steve.
2984
2985         Print out pending unload event count. Also print out main frame name to match Mac.         
2986
2987         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2988         (descriptionSuitableForTestResult):
2989         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
2990
2991 2008-05-16  Timothy Hatcher  <timothy@apple.com>
2992
2993         Remove the Drosera project, code and resources since it has been
2994         replaced with the Web Inspector's debugger. Removes references to
2995         Drosera in various scripts and makefiles.
2996
2997         Rubber-stamped by Mark Rowe.
2998
2999         * BuildSlaveSupport/build-launcher-app:
3000         * Drosera/DebuggerDocument.cpp: Removed.
3001         * Drosera/DebuggerDocument.h: Removed.
3002         * Drosera/Drosera.icns: Removed.
3003         * Drosera/DroseraWin.make: Removed.
3004         * Drosera/English.lproj/Debugger.nib/classes.nib: Removed.
3005         * Drosera/English.lproj/Debugger.nib/info.nib: Removed.
3006         * Drosera/English.lproj/Debugger.nib/keyedobjects.nib: Removed.
3007         * Drosera/English.lproj/MainMenu.nib/classes.nib: Removed.
3008         * Drosera/English.lproj/MainMenu.nib/info.nib: Removed.
3009         * Drosera/English.lproj/MainMenu.nib/keyedobjects.nib: Removed.
3010         * Drosera/ForwardingHeaders/wtf/Assertions.h: Removed.
3011         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Removed.
3012         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Removed.
3013         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Removed.
3014         * Drosera/ForwardingHeaders/wtf/Platform.h: Removed.
3015         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Removed.
3016         * Drosera/Images/Drosera.ico: Removed.
3017         * Drosera/Images/SourceArrow.png: Removed.
3018         * Drosera/Images/SourceArrowBlank.png: Removed.
3019         * Drosera/Images/SourceArrowOpen.png: Removed.
3020         * Drosera/Images/background_stripe.png: Removed.
3021         * Drosera/Images/breakPoint.tif: Removed.
3022         * Drosera/Images/breakPointDisabled.tif: Removed.
3023         * Drosera/Images/breakpointeditor.png: Removed.
3024         * Drosera/Images/close.tif: Removed.
3025         * Drosera/Images/close_active.tif: Removed.
3026         * Drosera/Images/close_hover.tif: Removed.
3027         * Drosera/Images/console.png: Removed.
3028         * Drosera/Images/continue.tif: Removed.
3029         * Drosera/Images/fileIcon.jpg: Removed.
3030         * Drosera/Images/finishFunction.tif: Removed.
3031         * Drosera/Images/glossyFooterFill.tif: Removed.
3032         * Drosera/Images/glossyHeader.png: Removed.
3033         * Drosera/Images/glossyHeaderPressed.png: Removed.
3034         * Drosera/Images/gradientBackground.png: Removed.
3035         * Drosera/Images/gutter.png: Removed.
3036         * Drosera/Images/navLeftDisabled.png: Removed.
3037         * Drosera/Images/navLeftNormal.png: Removed.
3038         * Drosera/Images/navLeftPressed.png: Removed.
3039         * Drosera/Images/navRightDisabled.png: Removed.
3040         * Drosera/Images/navRightNormal.png: Removed.
3041         * Drosera/Images/navRightPressed.png: Removed.
3042         * Drosera/Images/pause.tif: Removed.
3043         * Drosera/Images/popUpArrows.png: Removed.
3044         * Drosera/Images/programCounter.tif: Removed.
3045         * Drosera/Images/programCounterBreakPoint.tif: Removed.
3046         * Drosera/Images/programCounterBreakPointDisabled.tif: Removed.
3047         * Drosera/Images/run.tif: Removed.
3048         * Drosera/Images/siteCollapsed.tif: Removed.
3049         * Drosera/Images/siteExpanded.tif: Removed.
3050         * Drosera/Images/siteIcon.tif: Removed.
3051         * Drosera/Images/small.ico: Removed.
3052         * Drosera/Images/splitterBar.tif: Removed.
3053         * Drosera/Images/splitterDimple.tif: Removed.
3054         * Drosera/Images/step.tif: Removed.
3055         * Drosera/Images/stepOut.tif: Removed.
3056         * Drosera/Images/stepOver.tif: Removed.
3057         * Drosera/Images/stop.tif: Removed.
3058         * Drosera/Images/toolbarBackground.png: Removed.
3059         * Drosera/Images/verticalSplitterBar.tiff: Removed.
3060         * Drosera/Images/verticalSplitterDimple.tiff: Removed.
3061         * Drosera/Makefile: Removed.
3062         * Drosera/breakpointEditor.html: Removed.
3063         * Drosera/config.h: Removed.
3064         * Drosera/console.css: Removed.
3065         * Drosera/console.html: Removed.
3066         * Drosera/console.js: Removed.
3067         * Drosera/debugger.css: Removed.
3068         * Drosera/debugger.html: Removed.
3069         * Drosera/debugger.js: Removed.
3070         * Drosera/mac/DebuggerApplication.h: Removed.
3071         * Drosera/mac/DebuggerApplication.mm: Removed.
3072         * Drosera/mac/DebuggerClient.h: Removed.
3073         * Drosera/mac/DebuggerClient.mm: Removed.
3074         * Drosera/mac/DebuggerDocumentPlatform.mm: Removed.
3075         * Drosera/mac/Drosera.xcodeproj/project.pbxproj: Removed.
3076         * Drosera/mac/Info.plist: Removed.
3077         * Drosera/mac/LauncherInfo.plist: Removed.
3078         * Drosera/mac/Makefile: Removed.
3079         * Drosera/mac/ServerConnection.h: Removed.
3080         * Drosera/mac/ServerConnection.mm: Removed.
3081         * Drosera/mac/launcher.m: Removed.
3082         * Drosera/mac/main.m: Removed.
3083         * Drosera/viewer.css: Removed.
3084         * Drosera/viewer.html: Removed.
3085         * Drosera/win/BaseDelegate.h: Removed.
3086         * Drosera/win/DebuggerClient.cpp: Removed.
3087         * Drosera/win/DebuggerClient.h: Removed.
3088         * Drosera/win/DebuggerDocumentPlatform.cpp: Removed.
3089         * Drosera/win/Drosera.cpp: Removed.
3090         * Drosera/win/Drosera.h: Removed.
3091         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed.
3092         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed.
3093         * Drosera/win/DroseraPrefix.cpp: Removed.
3094         * Drosera/win/DroseraPrefix.h: Removed.
3095         * Drosera/win/Info.plist: Removed.
3096         * Drosera/win/ServerConnection.cpp: Removed.
3097         * Drosera/win/ServerConnection.h: Removed.
3098         * Drosera/win/resource.h: Removed.
3099         * Makefile:
3100         * Scripts/build-drosera: Removed.
3101         * Scripts/gdb-drosera: Removed.
3102         * Scripts/run-drosera: Removed.
3103         * Scripts/run-drosera-nightly.cmd: Removed.
3104         * Scripts/run-drosera.cmd: Removed.
3105         * Scripts/webkitdirs.pm:
3106
3107 2008-05-15  Stephanie Lewis  <slewis@apple.com>
3108
3109         Reviewed by Anders.
3110
3111         Dump the unload count for a frame after parsing is finished.
3112
3113         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3114         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
3115
3116 2008-05-15  Alexey Proskuryakov  <ap@webkit.org>
3117
3118         Reviewed by Dan Bernstein.
3119
3120         https://bugs.webkit.org/show_bug.cgi?id=10707
3121         DumpRenderTree should not be able to access non-local resources
3122
3123         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3124         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3125         Block them, and complain.
3126
3127 2008-05-15  Kevin Ollivier  <kevino@theolliviers.com>
3128
3129         wx build fix. Update the version of libpng to download and instsall.
3130
3131         * wx/install-unix-extras:
3132
3133 2008-05-14  Julien Chaffraix  <jchaffraix@webkit.org>
3134
3135         Reviewed by Eric.
3136
3137         - isDarwin() and isCygwin() returned an empty string if the platform equality check fails.
3138           We now force the return value to be numeric.
3139
3140         - Removed platform checks as it was a work around the previous issue.
3141
3142         - Replaced isDarwin() by isOSX() as they have now the same behaviour.
3143
3144         * Scripts/build-webkit:
3145         * Scripts/webkitdirs.pm:
3146
3147 2008-05-12  Adam Roben  <aroben@apple.com>
3148
3149         Support for testing NPN_PostURL
3150
3151         Reviewed by Anders Carlsson.
3152
3153         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3154         (toCString): Added this helper function.
3155         (testPostURLFile): Added. Writes the passed-in content to the
3156         passed-in file and calls NPN_PostURL with the passed-in URL and
3157         target.
3158         (pluginInvoke): Added a case for testPostURLFile.
3159         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3160         (followShortcuts): Changed to allow paths that don't yet exist.
3161
3162 2008-05-12  Mark Rowe  <mrowe@apple.com>
3163
3164         Reviewed by Sam Weinig.
3165
3166         Minor cleanup of the DRT Xcode project.
3167
3168         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:  Use GCC_OPTIMIZATION_LEVEL rather than
3169         OPTIMIZATION_CFLAGS.  Don't include Info.plist in the "Copy Bundle Resources" build phase as it does
3170         not need to be there.
3171
3172 2008-05-12  Anders Carlsson  <andersca@apple.com>
3173
3174         Reviewed by Adam.
3175
3176         Add support for testing application caches.
3177         
3178         * DumpRenderTree/mac/DumpRenderTree.mm:
3179         (dumpRenderTree):
3180         Empty the cache.
3181         
3182         (resetWebViewToConsistentStateBeforeTesting):
3183         Turn on support for the application cache.
3184
3185 2008-05-09  Mark Rowe  <mrowe@apple.com>
3186
3187         Reviewed by Anders Carlsson.
3188
3189         Update TestNetscapePlugIn to build 64-bit using the Cocoa event model.
3190
3191         It currently does not attempt to print events which means that plugins/mouse-events.html
3192         will fail when run 64-bit.  All other tests that use this plugin pass.
3193
3194         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3195         (testGetIntIdentifier):
3196         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3197         (NPP_New):
3198         (NPP_HandleEvent):
3199
3200 2008-05-09  Brady Eidson  <beidson@apple.com>
3201
3202         Reviewed by Adam Roben
3203
3204         Explicitly call shutDownWebKit() before quitting.
3205
3206         * Drosera/win/Drosera.cpp:
3207         (_tWinMain):
3208
3209         * DumpRenderTree/win/DumpRenderTree.cpp:
3210         (main):
3211
3212 2008-05-09  Mark Rowe  <mrowe@apple.com>
3213
3214         Fix the Tiger build of Drosera.
3215
3216         * Drosera/config.h: Define BUILDING_ON_TIGER when building on Tiger.
3217
3218 2008-05-09  Sam Weinig  <sam@webkit.org>
3219
3220         Rubber-stamped by Mark Rowe.
3221
3222         Remove the ENABLE_CROSS_DOCUMENT_MESSAGING #ifdefs.
3223
3224         * Scripts/build-webkit:
3225
3226 2008-05-08  Mark Rowe  <mrowe@apple.com>
3227
3228         Another attempt at a Tiger build fix.
3229
3230         Use DumpRenderTreeMac.h rather than DumpRenderTree.h as DumpRenderTreePasteboard is not an Obj-C++ file.
3231
3232         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
3233
3234 2008-05-08  Mark Rowe  <mrowe@apple.com>
3235
3236         Tiger build fix.  Include DumpRenderTree.h so that BUILDING_ON_TIGER will be defined.
3237
3238         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
3239
3240 2008-05-08  Mark Rowe  <mrowe@apple.com>
3241
3242         Reviewed by Oliver Hunt and Dan Bernstein.
3243
3244         Update DumpRenderTree to build 64-bit.
3245
3246         The three major changes here are:
3247         1) Use NSInteger in the appropriate places.
3248         2) Use ColorSync API that is available in 64-bit to switch display profiles.
3249         3) Use method-swizzling to achieve similar results to class posing when using the Obj-C 2.0 runtime.
3250
3251         The build of DumpRenderTree will still fail in 64-bit for now as the TestNetscapePlugIn target also
3252         needs updated to successfully build.
3253
3254         * DumpRenderTree/mac/Configurations/Base.xcconfig: Don't prevent Xcode from building 64-bit.
3255         * DumpRenderTree/mac/DumpRenderTree.mm:
3256         (swizzleAllMethods):
3257         (poseAsClass):
3258         (prepareConsistentTestingEnvironment):
3259         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3260         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
3261         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
3262         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3263         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3264         (restoreColorSpace):
3265         (failedGettingCurrentProfile):
3266         (setDefaultColorProfileToRGB):
3267
3268 2008-05-08  Mark Rowe  <mrowe@apple.com>
3269
3270         Reviewed by Darin Adler.
3271
3272         Clean up Drosera so that it will build 64-bit.
3273
3274         * Drosera/mac/DebuggerApplication.mm:
3275         (-[DebuggerApplication numberOfRowsInTableView:]): Use NSInteger rather than int.
3276         (-[DebuggerApplication tableView:objectValueForTableColumn:row:]): Ditto.
3277         * Drosera/mac/Drosera.xcodeproj/project.pbxproj: Use the default value for VALID_ARCHS.
3278
3279 2008-05-07  David Kilzer  <ddkilzer@apple.com>
3280
3281         Use File::Find and Getopt::Long in make-js-test-wrappers
3282
3283         Reviewed by Darin Adler.
3284
3285         * Scripts/make-js-test-wrappers:
3286         - Updated Apple copyright statement.
3287         - Added command-line switch parsing and -h|--help switch.
3288         - Allowed user to pass list of files/directories on which to do
3289           a restricted search for TEMPLATE.html files.  The default
3290           behavior is still to search the entire LayoutTests directory.
3291         - Removed duplicate 'use strict' statement.
3292         - Replaced use of `find` statements with File::Find::find().
3293         - Remove unneeded chomp() calls now that we use File::Find.
3294         (directoryFilter): Added.  Filters .svn directories when used
3295         with File::Find::find().
3296         (findTemplateFiles): Added.  Returns a list of TEMPLATE.html
3297         files found.
3298
3299 2008-05-05  Steve Falkenburg  <sfalken@apple.com>
3300
3301         Copy dependencies of ImageDiff, DumpRenderTree in post-build step.
3302
3303         * DumpRenderTree/win/DumpRenderTree.vcproj:
3304         * DumpRenderTree/win/ImageDiff.vcproj:
3305
3306 2008-05-05  Adele Peterson  <adele@apple.com>
3307
3308         Reviewed by Adam.
3309
3310         Look for the right ImageDiff executable for debug builds.
3311
3312         * Scripts/run-webkit-tests:
3313
3314 2008-05-05  Darin Adler  <darin@apple.com>
3315
3316         * Scripts/run-webkit-tests: Ignore a Java leak showing up in the WebKit
3317         leak tests.
3318
3319 2008-05-05  Ariya Hidayat  <ariya.hidayat@trolltech.com>
3320
3321         Reviewed by Simon.
3322
3323         In the Qt's DumpRenderTree, adjust the web view properly (because W3C SVG 
3324         tests expect to be 480x360)
3325
3326         * DumpRenderTree/qt/DumpRenderTree.cpp:
3327         (WebCore::DumpRenderTree::open):
3328
3329 2008-05-02  Dan Bernstein  <mitz@apple.com>
3330
3331         Reviewed by Adam Roben.
3332
3333         - add an option to svn-apply to set the reviewer name in change logs
3334
3335         * Scripts/svn-apply: Added a [-r|--reviewer name] option.
3336
3337 2008-05-01  David Kilzer  <ddkilzer@apple.com>
3338
3339         Clean up configuration usage in run-webkit-tests
3340
3341         Reviewed by Adam.
3342
3343         * Scripts/run-webkit-tests: Parse configuration switches using
3344         passedConfiguration() from webkitdirs.pm like every other script.
3345         Note that we must still call setConfiguration() afterwards in
3346         case the --configuration switch was used.  Use $configurationOption
3347         when running build-dumprendertree instead of recreating the switch.
3348
3349 2008-04-29  Adam Roben  <aroben@apple.com>
3350
3351         Restore the beloved COMPtr::operator&
3352
3353 2008-04-29  Adam Roben  <aroben@apple.com>
3354
3355         Windows build fixes
3356
3357         Replace COMPtr::operator& with COMPtr::adoptionPointer.
3358
3359 2008-04-25  Alexey Proskuryakov  <ap@webkit.org>
3360
3361         Reviewed by Darin Adler.
3362
3363         Fix run-webkit-tests --threading
3364         and provisionally fix <https://bugs.webkit.org/show_bug.cgi?id=18661>
3365         Proxy server issue in Sunday's Nightly
3366
3367         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
3368         (runJavaScriptThread):
3369         (startJavaScriptThreads):
3370         (stopJavaScriptThreads):
3371         Spawned threads were immediately detached, unlike the original ones, so joining them
3372         made no sense. Now, all threads are created detached, and stopJavaScriptThreads() just
3373         waits for them all to exit.
3374
3375 2008-04-28  Holger Hans Peter Freyther  <zecke@selfish.org>
3376
3377         Reviewed by Simon.
3378
3379         Reset dumping resource load callbacks to false for the next test
3380         
3381
3382         * DumpRenderTree/qt/jsobjects.cpp:
3383         (LayoutTestController::reset):
3384
3385 2008-04-28  Tor Arne Vestbø  <tavestbo@trolltech.com>
3386
3387         Reviewed by Simon.
3388
3389         Adapt to the latest API changes in WebKit/qt/Api.
3390
3391         * DumpRenderTree/qt/DumpRenderTree.cpp:
3392         (WebCore::DumpRenderTree::DumpRenderTree):
3393         * DumpRenderTree/qt/jsobjects.cpp:
3394
3395 2008-04-26  Robin Dunn  <robin@alldunn.com>
3396
3397         Reviewed by Kevin Ollivier.
3398         
3399         Delete the DerivedSources after make clean has been done so that the DerivedSources
3400         don't get re-created. Also, use the proper extension for the Win wxPython extension.
3401         
3402         https://bugs.webkit.org/show_bug.cgi?id=18756
3403
3404         * wx/build-wxwebkit:
3405
3406 2008-04-26  Adam Barth <hk9565@gmail.com>
3407
3408         Reviewed by Adam Roben and Sam Weinig.
3409
3410         Updates LayoutTestController to use host instead of domain.
3411
3412         Collin Jackson <collinj-webkit@collinjackson.com> also contributed to this patch.
3413
3414         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3415         (LayoutTestController::setDatabaseQuota):
3416         * DumpRenderTree/mac/UIDelegate.mm:
3417         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]):
3418
3419 2008-04-26  Kevin Ollivier  <kevino@theolliviers.com>
3420
3421         wx build fix. Need the latest libpng. (Somehow my initial test passed without it.)
3422
3423         * wx/install-unix-extras:
3424
3425 2008-04-26  Robin Dunn  <robin@alldunn.com>
3426
3427         Reviewed by Kevin Ollivier.
3428         
3429         Allow the user to set the path to SWIG using an environment variable.
3430         
3431         https://bugs.webkit.org/show_bug.cgi?id=18660
3432
3433         * wx/build-wxwebkit:
3434
3435 2008-04-26  Kevin Ollivier  <kevino@theolliviers.com>
3436
3437         wx build fix. Download the latest libpng version for building the
3438         dependencies.
3439
3440         * wx/install-unix-extras:
3441
3442 2008-04-25  Holger Hans Peter Freyther  <zecke@selfish.org>
3443
3444         Reviewed by Simon.
3445
3446         Implement dumping of resource load callbacks to pass http/tests/xmlhttprequest/abort-should-cancel-load.html
3447         
3448         Similar to Editing and Frameloading we do the dumping within WebCore
3449         
3450
3451         * DumpRenderTree/qt/jsobjects.cpp:
3452         (LayoutTestController::dumpResourceLoadCallbacks):
3453         * DumpRenderTree/qt/jsobjects.h:
3454
3455 2008-04-24  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
3456
3457         Reviewed by Maciej Stachowiak.
3458
3459         http://bugs.webkit.org/show_bug.cgi?id=18485
3460         Typo and documentation fix for build-webkit
3461
3462         * Scripts/build-webkit:
3463
3464 2008-04-24  Anders Carlsson  <andersca@apple.com>
3465
3466         Reviewed by Sam.
3467
3468         Don't call fprintf from the signal handler.
3469         
3470         * DumpRenderTree/mac/DumpRenderTree.mm:
3471         (crashHandler):
3472
3473 2008-04-23  Adam Roben  <aroben@apple.com>
3474
3475         Make crashes be reported as crashes, not hangs
3476
3477         Reviewed by David Kilzer.
3478
3479         * Scripts/run-webkit-tests:
3480         (top level): Use the new status field of the output from
3481         readFromDumpToolWithTimer to determine if the test crashed or hung.
3482         (sub readFromDumpToolWithTimer):
3483           - If we fail to read a line and $! is not EAGAIN, then we've crashed
3484             and should not try to read any more.
3485           - Changed the timedout field to a more general status field.
3486
3487 2008-04-22  David Kilzer  <ddkilzer@apple.com>
3488
3489         Bug 18683: update-webkit returns 0 even if it fails
3490
3491         <https://bugs.webkit.org/show_bug.cgi?id=18683>
3492
3493         Reviewed by Mitz Pettel.
3494
3495         * Scripts/update-webkit:
3496         (runSvnUpdate): Die if close() fails.
3497
3498 2008-04-21  Adam Roben  <aroben@apple.com>
3499
3500         Flush stdout/stderr after printing every #EOF separator
3501
3502         This fixes a hang when running the pixel tests on Windows
3503
3504         Reviewed by Mitz Pettel.
3505
3506         * DumpRenderTree/win/DumpRenderTree.cpp:
3507         (dump):
3508         (main): We don't have to flush stdout/stderr in the arguments loop
3509         anymore, as runTest flushes for us.
3510
3511 2008-04-21  Adam Roben  <aroben@apple.com>
3512
3513         Fix pixel tests
3514
3515         * Scripts/run-webkit-tests:
3516         (sub readFromDumpToolWithTimer): Use readline instead of read to
3517         ensure that we don't read past the #EOF marker.
3518
3519 2008-04-21  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
3520
3521         Reviewed by Simon.
3522
3523         Build fix for Qt 4.3
3524
3525         * When building WebCore/internal make sure the QT_[BEGIN,END]_NAMESPACE is
3526         always defined. Do this by adding defines to the compiler line
3527
3528         * DumpRenderTree/qt/DumpRenderTree.pro:
3529
3530 2008-04-19  Mike Hommey  <glandium@debian.org>
3531
3532         Reviewed by Alp Toker.
3533
3534         Don't build GtkLauncher and DumpRenderTree with rpath.
3535
3536         * GNUmakefile.am:
3537
3538 2008-04-18  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
3539
3540         Reviewed by Alp Toker.
3541
3542         http://bugs.webkit.org/show_bug.cgi?id=16620
3543         [GTK] Autotools make dist and make check support
3544
3545         Cleanups.
3546
3547         * GNUmakefile.am:
3548
3549 2008-04-18  Adam Roben  <aroben@apple.com>
3550
3551         Drop the hang timer to 30 seconds
3552
3553         This matches what DRT/mac was using.
3554
3555         Reviewed by Mitz Pettel.
3556
3557         * Scripts/run-webkit-tests:
3558
3559 2008-04-18  Adam Roben  <aroben@apple.com>
3560
3561         Get rid of DRT's Watchdog
3562
3563         run-webkit-tests now detects hangs and samples DRT as needed.
3564
3565         Reviewed by Mitz Pettel.
3566
3567         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Removed
3568         Watchdog* files from the project.
3569         * DumpRenderTree/Watchdog.cpp: Removed.
3570         * DumpRenderTree/Watchdog.h: Removed.
3571         * DumpRenderTree/mac/DumpRenderTree.mm: Removed uses of Watchdog
3572         (dumpRenderTree):
3573         (runTest):
3574         * DumpRenderTree/mac/WatchdogMac.h: Removed.
3575         * DumpRenderTree/mac/WatchdogMac.mm: Removed.
3576         * Scripts/run-webkit-tests:
3577         (sub testCrashedOrTimedOut): Call sampleDumpTool() if we timed out.
3578         (sub sampleDumpTool): Added. Writes a sample report to
3579         ~/Library/Logs/DumpRenderTree/HangReport.txt.
3580
3581 2008-04-18  Simon Hausmann  <hausmann@webkit.org>
3582
3583         Reviewed by Holger.
3584
3585         Adapt to the API changes in WebKit/qt
3586
3587         * DumpRenderTree/qt/DumpRenderTree.cpp:
3588         (WebCore::WebPage::WebPage):
3589         (WebCore::DumpRenderTree::DumpRenderTree):
3590         (WebCore::DumpRenderTree::initJSObjects):
3591         (WebCore::DumpRenderTree::dumpFramesAsText):
3592         (WebCore::DumpRenderTree::dump):
3593
3594 2008-04-17  Adam Roben  <aroben@apple.com>
3595
3596         Fix many tests on Windows
3597
3598         * Scripts/run-webkit-tests:
3599         (readFromDumpToolWithTimer):
3600          - Use read instead of sysread to ensure that we don't interfere with
3601            other uses of buffered IO in this script.
3602         (setFileHandleNonBlocking): Actually set the filehandle to blocking
3603         when specified.
3604
3605 2008-04-17  Adam Roben  <aroben@apple.com>
3606
3607         Fix ~10 tests
3608
3609         * Scripts/run-webkit-tests: Only remove the newline after #EOF, not
3610         whatever newline happens to be at the end of what we've read.
3611
3612 2008-04-17  Adam Roben  <aroben@apple.com>
3613
3614         Remove DRT/win's hang timer
3615
3616         run-webkit-tests takes care of this for us now
3617
3618         Reviewed by Anders Carlsson.
3619
3620         * DumpRenderTree/win/DumpRenderTree.cpp:
3621
3622 2008-04-17  Adam Roben  <aroben@apple.com>
3623
3624         Don't wait for the hang timer twice in the case of a hang
3625
3626         Previously we'd wait for a hang while reading both stdout and stderr
3627         from DRT. Now we'll only wait for one or the other.
3628
3629         Reviewed by Anders Carlsson.
3630
3631         * Scripts/run-webkit-tests:
3632         (top level): Don't wait for stderr to time out if stdout already timed
3633         out.
3634         (readFromDumpToolWithTimer): If $dontWaitForTimeOut is true, quit
3635         after the first read that returns no data.
3636
3637 2008-04-17  Adam Roben  <aroben@apple.com>
3638
3639         Don't throw away the output from timed out tests
3640
3641         Reviewed by Anders Carlsson.
3642
3643         * Scripts/run-webkit-tests:
3644         (top level): Updated for changes to readFromDumpToolWithTimer.
3645         (readFromDumpToolWithTimer): Return a hash that contains both the
3646         output and whether or not the test timed out.
3647
3648 2008-04-17  Adam Roben  <aroben@apple.com>
3649
3650         Make the hang timer 60 seconds
3651