ad9db607cafd43123ae2c7aa88d4799f8e58b2cf
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-09-08  Peter Varga  <pvarga@inf.u-szeged.hu>
2
3         Reviewed by Kenneth Rohde Christiansen.
4
5         Fix ignoring return value warning in case of gcc 4.4.4
6         https://bugs.webkit.org/show_bug.cgi?id=45384
7
8         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
9         (testPostURLFile):
10         If fwrite have written zero byte then the testPostURLFile function
11         returns with false as tempFile can't be opened.
12         * DumpRenderTree/qt/ImageDiff.cpp:
13         (main):
14         Put fwrite function into an if condition without body to avoid
15         warning. It is safe because this function writes to the stdout.
16
17 2010-09-08  Satish Sampath  <satish@chromium.org>
18
19         Unreviewed, adding myself to committers list.
20
21         * Scripts/webkitpy/common/config/committers.py:
22
23 2010-09-08  Hans Wennborg  <hans@chromium.org>
24
25         Unreviewed.
26
27         Adding myself as a committer in committers.py.
28
29         * Scripts/webkitpy/common/config/committers.py:
30
31 2010-09-08  Zoltan Horvath  <zoltan@webkit.org>
32
33         Reviewed by Simon Hausmann.
34
35         [Qt] Refactor MiniBrowser 
36         https://bugs.webkit.org/show_bug.cgi?id=45173
37
38         Split BrowserWindow into two source files and headers. Remove unnecessary header includes.
39
40         * MiniBrowser/qt/BrowserView.cpp: Added.
41         (createNewPage):
42         (BrowserView::BrowserView):
43         (BrowserView::resizeEvent):
44         (BrowserView::load):
45         (BrowserView::view):
46         * MiniBrowser/qt/BrowserView.h: Added.
47         (BrowserView::~BrowserView):
48         * MiniBrowser/qt/BrowserWindow.cpp:
49         * MiniBrowser/qt/BrowserWindow.h:
50         * MiniBrowser/qt/MiniBrowser.pro:
51
52 2010-09-08  Adam Barth  <abarth@webkit.org>
53
54         Rubber-stamped by Eric Seidel.
55
56         Rename DocLoader to CachedResourceLoader because that's what it does.
57
58         * Scripts/do-webcore-rename:
59
60 2010-09-07  Kinuko Yasuda  <kinuko@chromium.org>
61
62         Reviewed by Ojan Vafai.
63
64         Enable incremental results.json generation for non-layout tests.
65         https://bugs.webkit.org/show_bug.cgi?id=45315
66
67         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: Enable generate_incremental_results=True by default. (This still keeps to generate results.json.)  Also add a code to upload results json files to the app-engine server.  Need a chromium change to actually start the uploading.
68
69         * TestResultServer/model/jsonresults.py: Make sure we save the file with test_type for incremental cases too.
70
71
72 2010-09-07  Dirk Pranke  <dpranke@chromium.org>
73
74         Unreviewed, build fix
75
76         Missed one test in mac_unittest.py in previous change; for some
77         reason the method is listed twice. I will fix both for now, but will
78         figure this out in a later, not-time-sensitive patch.
79
80         https://bugs.webkit.org/show_bug.cgi?id=45357
81
82         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
83
84 2010-09-07  Kent Tamura  <tkent@chromium.org>
85
86         Reviewed by Tony Chang.
87
88         test-webkitpy: Fix load error of
89         webkitpy/layout_tests/port/factory_unittest.py on Win32 Python
90         https://bugs.webkit.org/show_bug.cgi?id=45356 Need a short
91
92         * Scripts/webkitpy/layout_tests/port/server_process.py:
93           Avoid to import fcntl on win32. Win32 Python doesn't have fcntl
94           and we don't use server_process.py on Win32 Python. However
95           unittest.py tries to load everything in a module.
96
97 2010-09-07  Dirk Pranke  <dpranke@chromium.org>
98
99         Reviewed by Kent Tamura.
100
101         Fix regression introduced in previous change to new-run-webkit-tests
102         (bug 45090) to not try to run unittests for the Mac implementation
103         of the Port interface if we aren't running on a Mac.
104
105         Also fix the overrides implementation mock in the chromium unittests
106         to fix the case where there are overrides checked in that cause
107         problems.
108
109         https://bugs.webkit.org/show_bug.cgi?id=45357
110
111         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
112         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
113         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
114
115 2010-09-01  Dirk Pranke  <dpranke@chromium.org>
116
117         Reviewed by Ojan Vafai.
118
119         new-run-webkit-tests: still more unit tests
120
121         Clean up and remove unnecessary code. Biggest notable change is
122         moving the chromium-specific imagediff code from port/base to
123         port/chromium.
124
125         Add more unit tests for run_webkit_tests.py, port/base.py,
126         port/factory.py, port/dryrun.py, and
127         layout_package/dump_render_tree_thread.py
128
129         This covers almost all of the generic and test code paths except for
130         a few error paths involving invalid or port-specific command line
131         arguments, and the code path for uploading results files to the
132         buildbots.
133         
134         https://bugs.webkit.org/show_bug.cgi?id=45090
135
136         * Scripts/webkitpy/layout_tests/data/failures/expected/hang.html: Added.
137         * Scripts/webkitpy/layout_tests/data/http/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
138         * Scripts/webkitpy/layout_tests/data/http/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
139         * Scripts/webkitpy/layout_tests/data/http/tests/ssl/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
140         * Scripts/webkitpy/layout_tests/data/http/tests/ssl/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
141         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
142         * Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
143         * Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
144         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
145         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Added.
146         * Scripts/webkitpy/layout_tests/port/base.py:
147         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
148         * Scripts/webkitpy/layout_tests/port/chromium.py:
149         * Scripts/webkitpy/layout_tests/port/dryrun.py:
150         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
151         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
152         * Scripts/webkitpy/layout_tests/port/port_testcase.py: Added.
153         * Scripts/webkitpy/layout_tests/port/server_process.py:
154         * Scripts/webkitpy/layout_tests/port/test.py:
155         * Scripts/webkitpy/layout_tests/port/webkit.py:
156         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
157         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
158
159 2010-09-07  Joseph Pecoraro  <joepeck@webkit.org>
160
161         Reviewed by Darin Adler.
162
163         Provide a way to trigger a <select multiple> onchange event on changes
164         https://bugs.webkit.org/show_bug.cgi?id=45192
165
166         Adds a selector on ObjCController for testing
167         -[DOMHTMLSelectElement _activateItemAtIndex:allowMultipleSelection:] and
168         its different uses.
169
170         * DumpRenderTree/mac/ObjCController.m:
171         (+[ObjCController isSelectorExcludedFromWebScript:]):
172         (+[ObjCController webScriptNameForSelector:]):
173         (-[ObjCController setSelectElement:selectedIndex:allowingMultiple:]):
174
175 2010-09-07  James Robinson  <jamesr@chromium.org>
176
177         Rubber-stamped by Dimitri Glazkov.
178
179         Move myself from the committer to the reviewer list.
180
181         * Scripts/webkitpy/common/config/committers.py:
182
183 2010-09-07  Tony Chang  <tony@chromium.org>
184
185         Reviewed by Darin Fisher.
186
187         [chromium] Make a public flag for how DRT generates bitmaps on Linux
188         https://bugs.webkit.org/show_bug.cgi?id=45133
189
190         * DumpRenderTree/chromium/TestShell.cpp:
191         (TestShell::dumpImage):
192
193 2010-09-07  Kent Tamura  <tkent@chromium.org>
194
195         Reviewed by Dimitri Glazkov.
196
197         [DRT/Chromium] Implement --check-layout-test-sys-deps
198         https://bugs.webkit.org/show_bug.cgi?id=45283
199
200         * DumpRenderTree/chromium/DumpRenderTree.cpp:
201         (main): Check --check-layout-test-sys-deps and call checkLayoutTestSystemDependencies().
202         * DumpRenderTree/chromium/TestShell.h: Declare checkLayoutTestSystemDependencies().
203         * DumpRenderTree/chromium/TestShellGtk.cpp:
204         (checkLayoutTestSystemDependencies): Add an empty implementation.
205         * DumpRenderTree/chromium/TestShellMac.mm:
206         (checkLayoutTestSystemDependencies): Add an empty implementation.
207         * DumpRenderTree/chromium/TestShellWin.cpp:
208         (checkLayoutTestSystemDependencies): Port similar function of test_shell.
209
210 2010-09-07  Jessie Berlin  <jberlin@apple.com>
211
212         Unreviewed. Mac build fix.
213
214         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
215         (didClearWindowObjectForFrame):
216
217 2010-09-07  Jessie Berlin  <jberlin@apple.com>
218
219         Reviewed by Darin Adler.
220
221         Indicate which one of the ScriptWorlds for a Frame the Window Object has been cleared for
222         https://bugs.webkit.org/show_bug.cgi?id=45217
223         
224         Make WebKitTestRunner work with this change.
225
226         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
227         (WTR::InjectedBundlePage::didClearWindowForFrame):
228         Make sure the ScriptWorld here is the normal world, since that is no longer being done in
229         WebFrameLoaderClient.
230         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
231
232 2010-09-07  Philippe Normand  <pnormand@igalia.com>
233
234         Unreviewed, build fix.
235
236         webkit-patch command to find the ports covering a specific layout test
237         https://bugs.webkit.org/show_bug.cgi?id=42832
238
239         * Scripts/webkitpy/layout_tests/port/chromium.py: Don't assume the
240         tests are present when building the expectations. This is needed
241         for the unittests.
242
243 2010-09-06  Philippe Normand  <pnormand@igalia.com>
244
245         Reviewed by Adam Barth.
246
247         webkit-patch command to find the ports covering a specific layout test
248         https://bugs.webkit.org/show_bug.cgi?id=42832
249
250         To use it: webkit-patch skipped-ports some/layout/test.html
251
252         * Scripts/webkitpy/layout_tests/port/base.py:
253         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
254         * Scripts/webkitpy/layout_tests/port/chromium.py:
255         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
256         * Scripts/webkitpy/layout_tests/port/factory.py:
257         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
258         * Scripts/webkitpy/layout_tests/port/test.py:
259         * Scripts/webkitpy/layout_tests/port/webkit.py:
260         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
261         * Scripts/webkitpy/tool/commands/queries.py:
262         * Scripts/webkitpy/tool/commands/queries_unittest.py:
263         * Scripts/webkitpy/tool/main.py:
264         * Scripts/webkitpy/tool/mocktool.py:
265
266 2010-09-07  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
267
268         Reviewed by Eric Seidel.
269
270         [NRWT] Add temp directory to all running drivers.
271         https://bugs.webkit.org/show_bug.cgi?id=45261
272
273         * Scripts/webkitpy/layout_tests/port/webkit.py:
274
275 2010-09-06  Dimitri Glazkov  <dglazkov@chromium.org>
276
277         Reviewed by Kent Tamura.
278
279         [Chromium/DRT] Empty out user stylesheet after each test run.
280         https://bugs.webkit.org/show_bug.cgi?id=45282
281
282         This should significantly cut down on the number of the mysterious flaky tests
283         whose diffs looked like the page was blown up to a very lage size. This
284         was indeed the dirty work of platform/mac/fast/loader/user-stylesheet-fast-path.html,
285         which set the base body font to 100px.
286
287         Since the user stylesheet was never reset, _all_ pixel tests that ran after it in
288         the same thread failed.
289
290         * DumpRenderTree/chromium/TestShell.cpp:
291         (TestShell::resetWebSettings): Set user stylesheet to an empty URL.
292
293 2010-09-06  Kent Tamura  <tkent@chromium.org>
294
295         Reviewed by Dimitri Glazkov.
296
297         [DRT/Chromium] Do not generate pixel results for text/plain resources
298         https://bugs.webkit.org/show_bug.cgi?id=45253
299
300         * DumpRenderTree/chromium/TestShell.cpp:
301         (TestShell::dump): Clear shouldGeneratePixelResults flag for text/plain.
302
303 2010-09-06  Ojan Vafai  <ojan@chromium.org>
304
305         Reviewed by Kent Tamura.
306
307         print out correct error when a DRT thread dies in NRWT
308         https://bugs.webkit.org/show_bug.cgi?id=45281
309
310         Not sure why, but with the parens, python 2.6.5 on Linux
311         gives an error that raise takes 5 arguments and 0 were given.
312         Didn't test other platforms or python versions, but putting it
313         all on one line fixes it and correctly prints the exception
314         from the DRT thread.
315
316         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
317
318 2010-09-06  Eric Seidel  <eric@webkit.org>
319
320         Unreviewed, just adding some emails from lists.webkit.org.
321
322         Update committers.py to include emails from lists.webkit.org
323         as found by the validate-committer-lists script.
324
325         * Scripts/webkitpy/common/config/committers.py:
326
327 2010-09-06  Martin Robinson  <mrobinson@igalia.com>
328
329         Reviewed by Xan Lopez.
330
331         [GTK] Small code cleanup in DumpRenderTreeGtk.cpp
332         https://bugs.webkit.org/show_bug.cgi?id=45213
333
334         * DumpRenderTree/gtk/DumpRenderTree.cpp:
335         (initializeFonts): Made this function do nothing for non-X11 platforms, so we don't
336         have to surround the invocation with #ifdefs.
337         (useLongRunningServerMode): Added.
338         (runTestingServerLoop): Added.
339         (initializeGlobalsFromCommandLineOptions): Added.
340         (runTest): Removed ifdefs.
341         (main): Use new helper functions.
342
343 2010-09-06  Martin Robinson  <mrobinson@igalia.com>
344
345         Reviewed by Xan Lopez.
346
347         [GTK] EventSender should support modifier keys with mouseDown and mouseUp events
348         https://bugs.webkit.org/show_bug.cgi?id=45235
349
350         Add support for interpreting the modifier key arguments to the mouseDown and mouseUp
351         methods of the EventSender.
352
353         * DumpRenderTree/gtk/EventSender.cpp:
354         (prepareMouseButtonEvent): Allow passing in a modifier bitmask, which will be OR'd
355         with the current modifiers.
356         (contextClickCallback): Always send no modifiers when preparing the mouse event.
357         (gdkModifersFromJSValue): Added, converts a JSValue array into a GDK modifier bitmask.
358         (mouseDownCallback): Send in the requested modifiers to prepareMouseButtonEvent.
359         (mouseUpCallback): Ditto.
360
361 2010-09-05  Peter Kasting  <pkasting@google.com>
362
363         Reviewed by Adam Barth.
364
365         Make Chromium/Mac generate continuous mousewheel events with the same wheelDelta values as Safari/Mac.
366         https://bugs.webkit.org/show_bug.cgi?id=45155
367
368         * DumpRenderTree/chromium/EventSender.cpp: Modify Chromium DRT mousewheel event generation to match new behavior on Mac.
369         (EventSender::handleMouseWheel):
370
371 2010-09-05  Yury Semikhatsky  <yurys@chromium.org>
372
373         Reviewed by Joseph Pecoraro.
374
375         Web Inspector: remove WebDevToolsAgentClient::forceRepaint which is not used
376         https://bugs.webkit.org/show_bug.cgi?id=45179
377
378         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
379         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
380
381 2010-09-05  Andreas Kling  <andreas.kling@nokia.com>
382
383         Rubber-stamped by Daniel Bates.
384
385         Adding myself as reviewer.
386
387         * Scripts/webkitpy/common/config/committers.py:
388
389 2010-09-04  Daniel Bates  <dbates@rim.com>
390
391         Reviewed by Martin Robinson.
392
393         Teach svn-apply/unapply about svn:mergeinfo
394         https://bugs.webkit.org/show_bug.cgi?id=45236
395
396         Recognize the svn:mergeinfo property and ignore it for now.
397
398         Currently, svn-apply/unapply recognize only '+' and '-'
399         property changes within a diff. We should add support
400         to recognize "Merged" and "Reverse-merged" changes as well.
401         Because svn:mergeinfo is metadata that is used only by SVN
402         and tends to be error-prone and/or nuisance (*), we will ignore
403         it for now.
404         (*) See "Parting Thoughts" of <http://www.collab.net/community/subversion/articles/merge-info.html>.
405
406         * Scripts/VCSUtils.pm:
407           - Modified parseSvnProperty() to recognize "Merged" and
408             "Reverse-merged" as the start of a property value.
409         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
410           - Added the following unit tests:
411             "simple: add svn:mergeinfo"
412             "simple: delete svn:mergeinfo"
413             "simple: modified svn:mergeinfo"
414         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
415           - Added the following unit tests:
416             "simple: add svn:mergeinfo"
417             "simple: delete svn:mergeinfo"
418             "simple: modified svn:mergeinfo"
419             "simple: modified svn:mergeinfo using SVN 1.4 syntax"
420             "'Merged' change followed by 'Merged' change"
421             "'Reverse-merged' change followed by 'Reverse-merged' change"
422         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
423           - Added the following unit tests:
424             "'Merged' change"
425             "'Reverse-merged' change"
426             "'Reverse-merged' change followed by 'Merge' change"
427             "'Merged' change followed by 'Merge' change"
428             "'Reverse-merged' change followed by 'Reverse-merged' change"
429             "'Reverse-merged' change followed by 'Reverse-merged' change followed by 'Merged' change"
430
431 2010-09-04  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
432
433         Reviewed by Kenneth Rohde Christiansen.
434
435         [EFL] Move test browser to WebKitTools directory
436         https://bugs.webkit.org/show_bug.cgi?id=45212
437
438         Follow other ports like QT and GTK which moved the test browser to
439         WebKitTools directory.
440
441         * CMakeListsEfl.txt: Added.
442         * EWebLauncher/main.c: Added.
443         (print_history):
444         (zoom_level_set):
445         (on_ecore_evas_resize):
446         (title_set):
447         (viewport_set):
448         (on_title_changed):
449         (on_progress):
450         (on_load_finished):
451         (on_toolbars_visible_set):
452         (on_toolbars_visible_get):
453         (on_statusbar_visible_set):
454         (on_statusbar_visible_get):
455         (on_scrollbars_visible_set):
456         (on_scrollbars_visible_get):
457         (on_menubar_visible_set):
458         (on_menubar_visible_get):
459         (on_tooltip_text_set):
460         (on_inputmethod_changed):
461         (on_viewport_changed):
462         (on_mouse_down):
463         (on_focus_out):
464         (on_focus_in):
465         (on_resized):
466         (on_key_down):
467         (on_browser_del):
468         (on_closeWindow):
469         (quit):
470         (browserCreate):
471         (browserDestroy):
472         (closeWindow):
473         (main_signal_exit):
474         (findThemePath):
475         (main):
476
477 2010-09-03  Simon Fraser  <simon.fraser@apple.com>
478
479         Reviewed by Adam Roben.
480
481         Set project dependencies so that they build serially. This fixes
482         issues when running run-webkit-tests if DRT is not built yet.
483
484         * DumpRenderTree/DumpRenderTree.sln:
485
486 2010-09-03  Dimitri Glazkov  <dglazkov@chromium.org>
487
488         Reviewed by Adam Barth.
489
490         Fix reading configuraiton in NWRT to work on Windows.
491         https://bugs.webkit.org/show_bug.cgi?id=45180
492
493         * Scripts/webkitpy/layout_tests/port/base.py: Added 'perl' argument, because Windows doesn't know what to do
494             with the file otherwise.
495
496 2010-09-03  Chris Rogers  <crogers@google.com>
497
498         Unreviewed
499
500         Add myself to the committers list
501         https://bugs.webkit.org/show_bug.cgi?id=45189
502
503         * Scripts/webkitpy/common/config/committers.py:
504
505 2010-09-03  Andrey Kosyakov  <caseq@chromium.org>
506
507         Reviewed by Yury Semikhatsky.
508
509         http/tests/inspector/console-xhr-logging.html and http/tests/inspector/resource-har-conversion.html are failing on chromium win bot
510         Changed MIME type for .js to application/x-javascript for consistency with apache used on other platforms.
511         https://bugs.webkit.org/show_bug.cgi?id=45137
512
513         * Scripts/webkitpy/layout_tests/port/lighttpd.conf:
514
515 2010-09-03  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
516
517         Reviewed by Eric Seidel.
518
519         Add feature detection support to NRWT.
520         https://bugs.webkit.org/show_bug.cgi?id=41842
521
522         * Scripts/webkitpy/layout_tests/port/base.py:
523         * Scripts/webkitpy/layout_tests/port/qt.py:
524         * Scripts/webkitpy/layout_tests/port/webkit.py:
525         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added.
526
527 2010-09-03  Hironori Bono  <hbono@chromium.org>
528
529         Reviewed by Kent Tamura.
530
531         Adds textInputController.hasSpellingMarker() to avoid using pixel tests for spellchecking tests
532         and implements it for Mac.
533         https://bugs.webkit.org/show_bug.cgi?id=41832
534
535         * DumpRenderTree/mac/TextInputController.m: Added [TextInputController hasSpellingMarker:length:]
536         and bind it so we can call it from JavaScript.
537         (+[TextInputController isSelectorExcludedFromWebScript:]):
538         (+[TextInputController webScriptNameForSelector:]):
539         (-[TextInputController hasSpellingMarker:length:]):
540
541 2010-09-02  Eric Seidel  <eric@webkit.org>
542
543         Reviewed by Adam Barth.
544
545         Add a unit test for commit-queue retries
546         https://bugs.webkit.org/show_bug.cgi?id=45162
547
548         I think commit-queue retries are not correctly avoiding
549         build and test on retries.  So I started testing the code.
550         Unfortunately this test did not find the bug.  But now
551         that we have the test we might as well keep it.
552         I also fixed a broken import in validate-committer-lists.
553
554         * Scripts/validate-committer-lists:
555         * Scripts/webkitpy/tool/commands/queues_unittest.py:
556
557 2010-09-02  Kent Tamura  <tkent@chromium.org>
558
559         Reviewed by Dimitri Glazkov.
560
561         [DRT/Chromium] Remove dependency to base/task.h and base/timer.h
562         https://bugs.webkit.org/show_bug.cgi?id=45091
563
564         Task.{cpp,h} introduces a simpler version of Chromium
565         base/task.h. It doesn't have TupleN and Method.
566
567         * DumpRenderTree/DumpRenderTree.gypi:
568          Add Task.cpp and Task.h
569         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
570         (DRTDevToolsAgent::DRTDevToolsAgent):
571         (DRTDevToolsAgent::reset):
572         (DRTDevToolsAgent::asyncCall):
573         (DRTDevToolsAgent::frontendLoaded):
574         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
575         (DRTDevToolsAgent::taskList): Added to use MethodTask<T>.
576         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
577         (DRTDevToolsClient::DRTDevToolsClient):
578         (DRTDevToolsClient::~DRTDevToolsClient):
579         (DRTDevToolsClient::reset):
580         (DRTDevToolsClient::asyncCall):
581         * DumpRenderTree/chromium/DRTDevToolsClient.h:
582         (DRTDevToolsClient::taskList): Added to use MethodTask<T>.
583         * DumpRenderTree/chromium/EventSender.cpp:
584         (EventSender::EventSender):
585         (EventSender::reset):
586         (EventSender::scheduleAsynchronousClick):
587         * DumpRenderTree/chromium/EventSender.h:
588         (EventSender::taskList): Added to use MethodTask<T>.
589         * DumpRenderTree/chromium/LayoutTestController.cpp:
590         (LayoutTestController::LayoutTestController):
591         (LayoutTestController::WorkQueue::processWorkSoon):
592         (LayoutTestController::waitUntilDone):
593         (LayoutTestController::notifyDone):
594         (LayoutTestController::reset):
595         * DumpRenderTree/chromium/LayoutTestController.h:
596         (LayoutTestController::taskList): Added to use MethodTask<T>.
597         (LayoutTestController::WorkQueue::taskList): Added to use MethodTask<T>.
598         * DumpRenderTree/chromium/NotificationPresenter.cpp:
599         (deferredDisplayDispatch):
600         (NotificationPresenter::show):
601         * DumpRenderTree/chromium/Task.cpp: Added.
602         * DumpRenderTree/chromium/Task.h: Added.
603
604 2010-09-02  Steve Block  <steveblock@google.com>
605
606         Reviewed by Adam Barth.
607
608         Hook up LayoutTestController.setMockDeviceOrientation() on Mac.
609         https://bugs.webkit.org/show_bug.cgi?id=43181
610
611         * DumpRenderTree/mac/DumpRenderTree.mm:
612         (createWebViewAndOffscreenWindow):
613         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
614         (LayoutTestController::setMockDeviceOrientation):
615
616 2010-08-31  Adam Roben  <aroben@apple.com>
617
618         Fix flashiness when resizing the browser window on Windows
619
620         Reviewed by Sam Weinig.
621
622         * MiniBrowser/win/BrowserWindow.cpp:
623         (BrowserWindow::wndProc): Override WM_ERASEBKGND so Windows won't
624         periodically fill the window with white.
625
626 2010-09-02  Peter Kasting  <pkasting@google.com>
627
628         Reviewed by Dimitri Glazkov.
629
630         Implement [continuous]MouseScrollBy() on Chromium, and partly on GTK.
631         https://bugs.webkit.org/show_bug.cgi?id=45073
632
633         * DumpRenderTree/chromium/EventSender.cpp:
634         (EventSender::EventSender):
635         (EventSender::mouseScrollBy):
636         (EventSender::continuousMouseScrollBy):
637         (EventSender::sendCurrentTouchEvent):
638         (EventSender::handleMouseWheel):
639         * DumpRenderTree/chromium/EventSender.h:
640         * DumpRenderTree/gtk/EventSender.cpp:
641         (mouseScrollByCallback):
642         (continuousMouseScrollByCallback):
643
644 2010-09-01  Dirk Pranke  <dpranke@chromium.org>
645
646         Reviewed by Tony Chang.
647
648         Land a patched version of r66542 - change TestRunner to have an
649         separate cleanup method and fix the ordering of cleanup between
650         TestRunner and the printing module, and then wrap everything in a
651         try/finally block to ensure reliable cleanup without needing to
652         rely on stuff happening in the destructor of the TestRunner.
653
654         Also refactor run_webkit_tests.run() to be much smaller and cleaner
655         by creating a bunch of helper methods and moving more stuff into
656         the TestRunner class.
657
658         This fixes the crash at the end of the linux test run of
659         new-run-webkit-tests (and undoes the rollout in 66547).
660
661         https://bugs.webkit.org/show_bug.cgi?id=44902
662
663         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Added.
664         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Added.
665         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Added.
666         * Scripts/webkitpy/layout_tests/data/passes/error.html: Added.
667         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
668         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
669         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
670         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
671         * Scripts/webkitpy/layout_tests/port/base.py:
672         * Scripts/webkitpy/layout_tests/port/test.py:
673         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
674         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
675
676 2010-09-01  Mark Rowe  <mrowe@apple.com>
677
678         Reviewed by Adam Roben.
679
680         Fix TestNetscapePlugIn to compile without access to QuickDraw private headers.
681
682         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
683
684 2010-09-01  Brian Weinstein  <bweinstein@apple.com>
685
686         Reviewed by Adam Roben.
687
688         Have kill-old-processes kill debug and release variants of WebKit2WebWebProcess
689         and WebKitTestRunner.
690
691         * BuildSlaveSupport/win/kill-old-processes:
692
693 2010-09-01  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
694
695         Reviewed by Antonio Gomes.
696
697         [Qt] Remove obsolete include path from DumpRenderTree.pro
698
699         * DumpRenderTree/qt/DumpRenderTree.pro:
700
701 2010-09-01  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
702
703         Reviewed by Laszlo Gombos.
704
705         [Qt] QWebPage::allowGeolocationRequest should be async API
706         https://bugs.webkit.org/show_bug.cgi?id=41364
707
708         Implements new async API for geolocation permission similar to
709         Notification. WebPage maintains list of geolocation permission request
710         QtWebkit and set's when LayoutTestController gets the access from test JS
711
712         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
713         (WebCore::WebPage::WebPage):
714         (WebCore::WebPage::resetSettings):
715         (WebCore::WebPage::requestPermission):
716         (WebCore::WebPage::cancelPermission):
717         (WebCore::WebPage::permissionSet):
718         (WebCore::DumpRenderTree::DumpRenderTree):
719         (WebCore::DumpRenderTree::processLine):
720         (WebCore::DumpRenderTree::geolocationPermissionSet):
721         * DumpRenderTree/qt/DumpRenderTreeQt.h:
722         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
723         (LayoutTestController::reset):
724         (LayoutTestController::setGeolocationPermission):
725         (LayoutTestController::setGeolocationPermissionCommon):
726         * DumpRenderTree/qt/LayoutTestControllerQt.h:
727
728 2010-09-01  Andras Becsi  <abecsi@webkit.org>
729
730         Reviewed by Antti Koivisto.
731
732         [Qt] Auto-generate WebKit2 forwarding headers
733         https://bugs.webkit.org/show_bug.cgi?id=44692
734
735         * MiniBrowser/qt/BrowserWindow.h: use source style includes
736         * MiniBrowser/qt/MiniBrowser.pro: add missing include paths
737         * Scripts/enumerate-included-framework-headers: Removed.
738
739 2010-08-31  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
740
741         Reviewed by Adam Barth.
742
743         Allow Ctrl+C inside Bugzilla::fetch_bug_dictionary
744         https://bugs.webkit.org/show_bug.cgi?id=44789
745
746         * Scripts/webkitpy/common/net/bugzilla.py:
747
748 2010-08-31  Leandro Pereira  <leandro@profusion.mobi>
749
750         Reviewed by Adam Barth.
751
752         ews: Add support for EFL-EWS
753         https://bugs.webkit.org/show_bug.cgi?id=44982
754
755         * QueueStatusServer/model/queues.py: Add "efl-ews" to queues list.
756         * Scripts/webkitpy/common/config/ports.py: Define a EflPort class
757         and add it to the ports dict.
758         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: Define a
759         EflEWS class.
760         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: Add
761         a test case for the EFL EWS.
762
763 2010-08-31  Alexey Proskuryakov  <ap@apple.com>
764
765         Reviewed by Sam Weinig.
766
767         https://bugs.webkit.org/show_bug.cgi?id=42195
768         <rdar://problem/8186761> WebKitTestRunner needs to support layoutTestController.setXSSAuditorEnabled
769
770         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
771         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setXSSAuditorEnabled):
772         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
773         Added setXSSAuditorEnabled, calling through to an WKBundle private method. Calling this method
774         makes WebProcess use a different value for this preference than UIProcess thinks it uses.
775
776         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
777         Reset xssAuditorEnabled. Even though the value doesn't change, this calls through to WebProcess,
778         which forgets its override.
779
780 2010-08-31  Sam Weinig  <sam@webkit.org>
781
782         Reviewed by Gavin Barraclough.
783
784         WebKitTestRunner needs layoutTestController.addUserStyleSheet
785         https://bugs.webkit.org/show_bug.cgi?id=42680
786
787         WebKitTestRunner needs layoutTestController.addUserScript
788         https://bugs.webkit.org/show_bug.cgi?id=42681
789
790         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
791         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
792         (WTR::InjectedBundle::beginTesting):
793         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
794         (WTR::LayoutTestController::addUserScript):
795         (WTR::LayoutTestController::addUserStyleSheet):
796         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
797
798 2010-08-31  Dirk Pranke  <dpranke@chromium.org>
799
800         Unreviewed, rolling out r66542.
801         http://trac.webkit.org/changeset/66542
802         https://bugs.webkit.org/show_bug.cgi?id=44902
803
804         r66542 - the weird logging dependencies in Python stuck again ...
805
806         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Removed.
807         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Removed.
808         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Removed.
809         * Scripts/webkitpy/layout_tests/data/passes/error.html: Removed.
810         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
811         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
812         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
813         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
814         * Scripts/webkitpy/layout_tests/port/base.py:
815         * Scripts/webkitpy/layout_tests/port/test.py:
816         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
817         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
818
819 2010-08-31  Dumitru Daniliuc  <dumi@chromium.org>
820
821         Reviewed by Tony Chang.
822
823         Implementing LayoutTestController::markerTextForListItem() in Chromium's DRT.
824
825         * DumpRenderTree/chromium/LayoutTestController.cpp:
826         (LayoutTestController::LayoutTestController):
827         (LayoutTestController::markerTextForListItem):
828         * DumpRenderTree/chromium/LayoutTestController.h:
829
830 2010-08-31  Dirk Pranke  <dpranke@chromium.org>
831
832         Reviewed by Ojan Vafai.
833
834         new-run-webkit-tests: add more unit tests
835
836         Add more unit tests for new-run-webkit-tests; we now cover all but
837         the most obscure code paths in the generic code. We still need to
838         add coverage for the http server and web socket paths, and add better
839         coverage of the platform-specific logic. Note that the rebaselining
840         tool is still not well tested.
841
842         Also clean up some of the configuration logic for the printing
843         module and the way it interacts with the Python logging module; that
844         is a crufty interface, to be certain.
845         
846         https://bugs.webkit.org/show_bug.cgi?id=44902
847
848         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Added.
849         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Added.
850         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Added.
851         * Scripts/webkitpy/layout_tests/data/passes/error.html: Added.
852         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
853         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
854         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
855         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
856         * Scripts/webkitpy/layout_tests/port/base.py:
857         * Scripts/webkitpy/layout_tests/port/test.py:
858         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
859         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
860
861 2010-08-31  Darin Adler  <darin@apple.com>
862
863         Reviewed by Anders Carlsson.
864
865         * Scripts/check-for-global-initializers: Add a file that ends up having global initializers
866         in a debug build when built with certain compilers.
867
868 2010-08-31  Martin Robinson  <mrobinson@igalia.com>
869
870         Reviewed by Gustavo Noronha Silva.
871
872         [GTK] Isolate all GTK+ typedefs into one file
873         https://bugs.webkit.org/show_bug.cgi?id=44900
874
875         * DumpRenderTree/gtk/EventSender.h: Remove GTK+ typedefs.
876
877 2010-08-31  Eric Seidel  <eric@webkit.org>
878
879         Reviewed by Adam Barth.
880
881         Show more status on queue status pages
882         https://bugs.webkit.org/show_bug.cgi?id=44938
883
884         I upped the number of status lines from 6 to 15 --
885         this has been bugging me for a while...
886
887         I also disabled showing the chromium-win EWS queue
888         since it's been down for almost 5 months now.
889
890         * QueueStatusServer/handlers/dashboard.py:
891         * QueueStatusServer/handlers/queuestatus.py:
892         * QueueStatusServer/model/queues.py:
893
894 2010-08-31  Zoltan Horvath  <zoltan@webkit.org>
895
896         Reviewed by Antonio Gomes.
897
898         [Qt] Read command line arguments and open them as URLs in new windows
899         https://bugs.webkit.org/show_bug.cgi?id=44944
900
901         Extend MiniBrowser to accept command line arguments and open them as URLs in new browser windows.
902
903         * MiniBrowser/qt/main.cpp:
904         (main):
905
906 2010-08-31  Adrian Perez  <aperez@igalia.com>
907
908         Reviewed by Martin Robinson.
909
910         Support scripts to run Buildbot slaves under daemontools (gtk related)
911         https://bugs.webkit.org/show_bug.cgi?id=40053
912
913         * BuildSlaveSupport/gtk: Added.
914         * BuildSlaveSupport/gtk/README: Added.
915         * BuildSlaveSupport/gtk/buildbot: Added.
916         * BuildSlaveSupport/gtk/buildbot/log: Added.
917         * BuildSlaveSupport/gtk/buildbot/log/run: Added.
918         * BuildSlaveSupport/gtk/buildbot/run: Added.
919         * BuildSlaveSupport/gtk/crashmon: Added.
920         * BuildSlaveSupport/gtk/crashmon/crashmon: Added.
921         * BuildSlaveSupport/gtk/crashmon/log: Added.
922         * BuildSlaveSupport/gtk/crashmon/log/run: Added.
923         * BuildSlaveSupport/gtk/crashmon/run: Added.
924         * BuildSlaveSupport/gtk/daemontools-buildbot.conf: Added.
925         * BuildSlaveSupport/gtk/pulseaudio: Added.
926         * BuildSlaveSupport/gtk/pulseaudio/run: Added.
927         * BuildSlaveSupport/gtk/xvfb: Added.
928         * BuildSlaveSupport/gtk/xvfb/log: Added.
929         * BuildSlaveSupport/gtk/xvfb/log/run: Added.
930         * BuildSlaveSupport/gtk/xvfb/run: Added.
931
932 2010-08-27  John Gregg  <johnnyg@google.com>
933
934         Reviewed by David Levin.
935
936         Notifications should support a click event.
937         Adds necessary hooks to chromium's DRT so that clicks on desktop notifications
938         can be simulated during a layout test.  Requires storing a list of active
939         notifications so that they can be referred to later for clicking.
940         https://bugs.webkit.org/show_bug.cgi?id=44800
941
942         * DumpRenderTree/chromium/LayoutTestController.cpp:
943         (LayoutTestController::LayoutTestController):
944         (LayoutTestController::simulateDesktopNotificationClick):
945         * DumpRenderTree/chromium/LayoutTestController.h:
946         * DumpRenderTree/chromium/NotificationPresenter.cpp:
947         (NotificationPresenter::simulateClick):
948         (NotificationPresenter::show):
949         (NotificationPresenter::cancel):
950         (NotificationPresenter::objectDestroyed):
951         * DumpRenderTree/chromium/NotificationPresenter.h:
952
953 2010-08-30  Alice Liu  <alice.liu@apple.com>
954
955         Reviewed by Darin Adler.
956
957         Add missing parts of didFinishDocumentLoadForFrame
958         https://bugs.webkit.org/show_bug.cgi?id=44913
959
960         * MiniBrowser/mac/BrowserWindowController.m:
961         (didFinishDocumentLoadForFrame): Added
962         (-[BrowserWindowController awakeFromNib]): Updated struct
963         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
964         (WTR::InjectedBundlePage::InjectedBundlePage): Rearranged function ptr
965         * WebKitTestRunner/TestController.cpp:
966         (WTR::TestController::initialize): Updated struct
967
968 2010-08-30  Vangelis Kokkevis  <vangelis@chromium.org>
969
970         Unreviewed: Add myself to the list of Committers.
971
972         * Scripts/webkitpy/common/config/committers.py:
973
974 2010-08-30  Kent Tamura  <tkent@chromium.org>
975
976         Reviewed by Adam Barth.
977
978         Fix fast/notifications/notifications-display-close-events.html failure
979         https://bugs.webkit.org/show_bug.cgi?id=44585
980
981         Apply http://crrev.com/48893. We should dispatch display events
982         asynchronously.
983
984         * DumpRenderTree/chromium/NotificationPresenter.cpp:
985         (deferredDisplayDispatch):
986         (NotificationPresenter::show):
987
988 2010-08-30  Robert Hogan  <robert@webkit.org>
989
990         Reviewed by Simon Hausmann.
991
992         allow ports with windowed plugins to support windowless plugin tests
993
994         https://bugs.webkit.org/show_bug.cgi?id=40730
995
996         Ports that implement plugins windowed by default need to have a way of
997         supporting plugin tests that assume the plugin is windowless. Add this
998         feature to the tests and support it in the webkit test plugin. Also
999         add mouse and keyboard event logging to the webkit-test plugin on Unix.
1000
1001         Unskip the following tests on Qt:
1002
1003         plugins/mouse-events.html
1004         plugins/keyboard-events.html
1005         plugins/mouse-events-fixedpos.html
1006
1007         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1008         (pluginSetProperty):
1009         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1010         (NPP_New):
1011         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1012         (webkit_test_plugin_handle_event):
1013
1014 2010-08-30  Kevin Ollivier  <kevino@theolliviers.com>
1015
1016         [wx] Build fix after addition of fileapi directory in WebCore.
1017
1018         * wx/build/settings.py:
1019
1020 2010-08-30  Alejandro G. Castro  <alex@igalia.com>
1021
1022         Reviewed by Xan Lopez.
1023
1024         Fixed compilation error, now that we have included the
1025         GtkVersioning.h we have to remove some version dependent code from
1026         EventSender.
1027
1028         * DumpRenderTree/gtk/EventSender.cpp:
1029
1030 2010-08-30  Alejandro G. Castro  <alex@igalia.com>
1031
1032         Reviewed by Martin Robinson.
1033
1034         [Gtk] gdk_display_get_core_pointer and gdk_device_get_core_pointer
1035         are deprecated
1036         https://bugs.webkit.org/show_bug.cgi?id=44787
1037
1038         We have replaced GtkVersioning.cpp with GtkVersioning.c and
1039         created a function (getDefaultGDKPointerDevice) to get the pointer
1040         of the window with the new APIs. We added that function to DRT and
1041         copyandpaste unit test.
1042
1043         * DumpRenderTree/gtk/EventSender.cpp:
1044         (prepareMouseButtonEvent):
1045         (mouseMoveToCallback):
1046         (keyDownCallback):
1047         * GNUmakefile.am:
1048
1049 2010-08-30  Zoltan Horvath  <zoltan@webkit.org>
1050
1051         Reviewed by Kenneth Rohde Christiansen.
1052
1053         [Qt] Add new window menu to MiniBrowser
1054
1055         Implement newWindow function and add a menu item for opening new window in MiniBrowser.
1056
1057         * MiniBrowser/qt/BrowserWindow.cpp:
1058         (BrowserWindow::BrowserWindow):
1059         (BrowserWindow::newWindow):
1060         * MiniBrowser/qt/BrowserWindow.h:
1061         * MiniBrowser/qt/main.cpp:
1062         (main):
1063
1064 2010-08-29  James Robinson  <jamesr@chromium.org>
1065
1066         Reviewed by David Levin.
1067
1068         Make failing the download step fail the build
1069         https://bugs.webkit.org/show_bug.cgi?id=44298
1070
1071         If the download step fails on a test bot, this ensures that
1072         the build goes red instead of only the download step going red
1073         and the overall build staying green.
1074
1075         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1076
1077 2010-08-29  Kent Tamura  <tkent@chromium.org>
1078
1079         Reviewed by Dimitri Glazkov.
1080
1081         [DRT/Chromium] Remove dependency to base/keyboard_codes.h
1082         https://bugs.webkit.org/show_bug.cgi?id=44847
1083
1084         * DumpRenderTree/chromium/EventSender.cpp:
1085          Use webkit_support::VKEY_* instead of base::VKEY_*.
1086
1087 2010-08-29  Darin Adler  <darin@apple.com>
1088
1089         https://bugs.webkit.org/show_bug.cgi?id=40589
1090
1091         * Scripts/prepare-ChangeLog: Only prepend namespaces to non-empty
1092         function names.
1093
1094 2010-08-26  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
1095
1096         Reviewed by Darin Adler.
1097
1098         [iExploder] Add new CSS Properties and HTML Attributes
1099         https://bugs.webkit.org/show_bug.cgi?id=44746
1100
1101         Updated the files with the update-iexploder-cssproperties script
1102         and manually readded the -webkit-binding CSS Property to the list.
1103
1104         * iExploder/htdocs/cssproperties.in:
1105         * iExploder/htdocs/htmlattrs.in:
1106         * iExploder/htdocs/htmltags.in:
1107
1108 2010-08-26  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
1109
1110         Reviewed by Darin Adler.
1111
1112         Fix Coverage build after the addition of ANGLE
1113         https://bugs.webkit.org/show_bug.cgi?id=44744
1114
1115         ANGLE is using libtool to build a static library and the version of
1116         libtool on Leopard refuses to handle the -fprofile-arcs and -ftest-coverage
1117         parameters. The easiest way to handle this is to not build ANGLE with
1118         coverage information.
1119
1120         This is achieved by applying the XCode options for each project
1121         separately and exclude ANGLE.
1122
1123         * Scripts/build-webkit: Remove -framework AppKit due link errors.
1124         * Scripts/webkitdirs.pm: Do not apply the XCode options for ANGLE.
1125
1126 2010-08-28  Kevin Ollivier  <kevino@theolliviers.com>
1127
1128         [wx] Build fix after directory addition.
1129
1130         * wx/build/settings.py:
1131
1132 2010-08-28  Chris Guillory   <chris.guillory@google.com>
1133
1134         Reviewed by Chris Fleizach.
1135
1136         Add AX notification for childrenChanged
1137         https://bugs.webkit.org/show_bug.cgi?id=44472
1138
1139         * DumpRenderTree/chromium/AccessibilityController.cpp:
1140         (AccessibilityController::AccessibilityController):
1141         (AccessibilityController::reset):
1142         (AccessibilityController::getRootElement):
1143         (AccessibilityController::dumpAccessibilityNotifications):
1144         * DumpRenderTree/chromium/AccessibilityController.h:
1145         (AccessibilityController::shouldDumpAccessibilityNotifications):
1146         * DumpRenderTree/chromium/WebViewHost.cpp:
1147         (WebViewHost::didChangeAccessibilityObjectChildren):
1148         * DumpRenderTree/chromium/WebViewHost.h:
1149
1150 2010-08-28  Eric Seidel  <eric@webkit.org>
1151
1152         Reviewed by Adam Barth.
1153
1154         Update commit-queue failure message
1155         https://bugs.webkit.org/show_bug.cgi?id=44798
1156
1157         The commit-queue auto-restarts itself and has for a very long time.
1158         No need for people to email me to request a restart anymore.
1159
1160         * Scripts/webkitpy/common/net/bugzilla.py:
1161         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
1162         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1163
1164 2010-07-27  Jer Noble  <jer.noble@apple.com>
1165
1166         Reviewed by Eric Carlson.
1167
1168         Add JavaScript API to allow a page to go fullscreen.
1169         rdar://problem/6867795
1170         
1171         Added basic full screen support to DumpRenderTree: when a webView requests
1172         that DumpRenderTree go "full screen", just call the provided callback listener object's
1173         will/did Enter/Exit full screen methods.  Also, register a new user default which 
1174         enables full screen support.
1175
1176         * DumpRenderTree/mac/DumpRenderTree.mm:
1177         (resetDefaultsToConsistentValues):
1178         * DumpRenderTree/mac/UIDelegate.mm:
1179         (-[UIDelegate webView:supportsFullscreenForElement:]):
1180         (-[UIDelegate webView:enterFullscreenForElement:listener:]):
1181         (-[UIDelegate webView:exitFullscreenForElement:listener:]):
1182
1183 2010-08-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
1184
1185         Unreviewed. Add myself to the committers list.
1186
1187         * Scripts/webkitpy/common/config/committers.py:
1188
1189 2010-08-27  Kent Tamura  <tkent@chromium.org>
1190
1191         Reviewed by Pavel Feldman.
1192
1193         [DRT/Chromium] Fix inspector test failures
1194         https://bugs.webkit.org/show_bug.cgi?id=44748
1195
1196         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1197         (DRTDevToolsAgent::createClientMessageLoop):
1198           Returns a valid WebKitClientMessageLoop instance
1199         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1200
1201 2010-08-26  Jon Honeycutt  <jhoneycutt@apple.com>
1202
1203         Add Windows WebKit2 Tester to buildbot
1204         <rdar://problem/7887703>
1205
1206         Reviewed by Dan Bernstein.
1207
1208         * BuildSlaveSupport/build.webkit.org-config/config.json:
1209
1210 2010-08-26  Philippe Normand  <pnormand@igalia.com>
1211
1212         Reviewed by Martin Robinson.
1213
1214         [GTK] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
1215         https://bugs.webkit.org/show_bug.cgi?id=42152
1216
1217         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
1218         (LoadHTMLStringItem::invoke): Implementation using
1219         webkit_web_frame_load_string().
1220
1221 2010-08-25  Jon Honeycutt  <jhoneycutt@apple.com>
1222
1223         <rdar://problem/8334338> run-webkit-tests sometimes hangs when using
1224         WebKitTestRunner (44331)
1225
1226         Reviewed by Darin Adler.
1227
1228         * WebKitTestRunner/TestController.cpp:
1229         (WTR::TestController::initialize):
1230         The hang occurs when WebKitTestRunner begins launching the WebKit2
1231         web process then exits before it finishes launching. Work around this by
1232         looking for the --print-supported-features argument and exiting without
1233         creating the web process.
1234
1235 2010-08-26  Dirk Pranke  <dpranke@chromium.org>
1236
1237         Reviewed by Tony Chang.
1238
1239         new-run-webkit-tests: add rebaselining tests for test_expectations
1240         
1241         This patch adds more unit tests for the rebaselining code in the
1242         test_expectations module. It doesn't add any tests for
1243         rebaseline_chromium_webkit_tests itself; that will come some other
1244         time.
1245
1246         https://bugs.webkit.org/show_bug.cgi?id=44648
1247
1248         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1249         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1250
1251 2010-08-26  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1252
1253         Reviewed by Martin Robinson.
1254
1255         [GTK] Add HTTP caching support
1256         https://bugs.webkit.org/show_bug.cgi?id=44261
1257
1258         Ignore new soup API that we decided to merge into the soup backend
1259         while it is being cooked. It follows the libsoup style, and will
1260         be removed from WebKit as soon as it is merged into libsoup.
1261
1262         * Scripts/webkitpy/style/checker.py:
1263
1264 2010-08-26  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1265
1266         Reviewed by Kenneth Rohde Christiansen.
1267
1268         [Qt] DumpRenderTree runs only one test from command mode
1269         https://bugs.webkit.org/show_bug.cgi?id=44012
1270
1271         Enables support to run multiple test files and single
1272         folder containing html files in stand alone mode
1273
1274         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1275         (WebCore::DumpRenderTree::DumpRenderTree):
1276         (WebCore::DumpRenderTree::processArgsLine):
1277         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
1278         (WebCore::DumpRenderTree::processLine):
1279         (WebCore::DumpRenderTree::dump):
1280         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1281         (WebCore::DumpRenderTree::setStandAloneMode):
1282         (WebCore::DumpRenderTree::isStandAloneMode):
1283         * DumpRenderTree/qt/main.cpp:
1284         (main):
1285
1286 2010-08-25  Martin Robinson  <mrobinson@igalia.com>
1287
1288         Updating webkitpy test expectations.
1289
1290         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1291
1292 2010-08-25  Ojan Vafai  <ojan@chromium.org>
1293
1294         Reviewed by Eric Seidel.
1295
1296         fix the always squash git config
1297         https://bugs.webkit.org/show_bug.cgi?id=44651
1298
1299         Fix help text and apparently underscores are not allowed
1300         in git config keys.
1301
1302         * Scripts/webkitpy/common/checkout/scm.py:
1303         * Scripts/webkitpy/tool/steps/commit.py:
1304
1305 2010-08-25  Darin Adler  <darin@apple.com>
1306
1307         Reviewed by John Sullivan.
1308
1309         * Scripts/commit-log-editor: Fix perl warning for people who have no
1310         value for SVN_LOG_EDITOR or CVS_LOG_EDITOR.
1311
1312 2010-08-25  Ojan Vafai  <ojan@chromium.org>
1313
1314         Reviewed by Eric Seidel.
1315
1316         stop blocking commits when the bots are red
1317         https://bugs.webkit.org/show_bug.cgi?id=44644
1318
1319         This check currently is just annoying. It doesn't actually
1320         help keep the tree green. We can always add it back later
1321         if we decide the tree is generally more green.
1322
1323         * Scripts/webkitpy/tool/commands/download_unittest.py:
1324         * Scripts/webkitpy/tool/mocktool.py:
1325         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
1326
1327 2010-08-25  Eric Seidel  <eric@webkit.org>
1328
1329         Reviewed by Simon Fraser.
1330
1331         REGRESSION: media/video-loop.html is timing out on the commit-queue Leopard Bot
1332         https://bugs.webkit.org/show_bug.cgi?id=38912
1333
1334         I know of nothing else to do but skip all media tests for the cq.
1335
1336         * Scripts/webkitpy/tool/steps/runtests.py:
1337
1338 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
1339
1340         Reviewed by Ojan Vafai.
1341
1342         new-run-webkit-tests: add more unit tests for test_expectations
1343         This adds unit tests to cover (almost?) all of the non-rebaselining
1344         functionality.
1345
1346         https://bugs.webkit.org/show_bug.cgi?id=44579
1347
1348         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1349         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1350
1351 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
1352
1353         Reviewed by Ojan Vafai.
1354
1355         new-run-webkit-tests: add more unit tests
1356
1357         This change adds more unit tests for the image_diff, test_failures,
1358         and test_files modules, bringing them to 100% coverage (and adds a
1359         couple tests to run_webkit_tests while we're at it).
1360
1361         This test also turns on the "dryrun" port for testing when run on
1362         the mac, increasing coverage in a few other places.
1363
1364         https://bugs.webkit.org/show_bug.cgi?id=44578
1365
1366         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.checksum: Added.
1367         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.png: Added.
1368         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.txt: Added.
1369         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html.
1370         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.png: Added.
1371         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.txt: Added.
1372         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html.
1373         * Scripts/webkitpy/layout_tests/data/failures/expected/timeout.html: Added.
1374         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
1375         * Scripts/webkitpy/layout_tests/data/resources/README.txt: Added.
1376         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
1377         * Scripts/webkitpy/layout_tests/port/test.py:
1378         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1379
1380 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
1381
1382         Reviewed by Ojan Vafai.
1383
1384         new-run-webkit-tests: add more unit tests for layout_package/printing.py
1385
1386         This change adds more unit tests to get the test coverage to 100%
1387         for the printing module. This code is actually pretty crufty and
1388         has some layering violations that need to be cleaned up but I'll
1389         save that for another CL after we get all the unit tests written and
1390         we fix the multithreading issues. At least now we'll be able to tell
1391         if we break things.
1392
1393         https://bugs.webkit.org/show_bug.cgi?id=44576
1394
1395         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1396         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1397
1398 2010-08-25  Ojan Vafai  <ojan@chromium.org>
1399
1400         Reviewed by Adam Barth.
1401
1402         new-run-webkit-tests should respect set-webkit-configuration
1403         https://bugs.webkit.org/show_bug.cgi?id=44633
1404
1405         Moves the getting of the configuration into the base Port so that
1406         chromium ports use it as well. In the downstream chromium port,
1407         this should still just return Release.
1408
1409         * Scripts/webkitpy/layout_tests/port/base.py:
1410         * Scripts/webkitpy/layout_tests/port/webkit.py:
1411
1412 2010-08-25  Tony Chang  <tony@chromium.org>
1413
1414         Not reviewed, changing svn props for a script.
1415
1416         * Scripts/deduplicate-tests: Added properties svn:executable and svn:eol-style.
1417
1418 2010-08-25  Adam Barth  <abarth@webkit.org>
1419
1420         Reviewed by Eric Seidel.
1421
1422         Remove WebKit2 from core builders
1423         https://bugs.webkit.org/show_bug.cgi?id=44625
1424
1425         This builder was added to the core builders by accident.  It doesn't
1426         appear to be green enough to be a core builder yet.
1427
1428         * Scripts/webkitpy/common/net/buildbot.py:
1429         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1430
1431 2010-08-19  Adam Roben  <aroben@apple.com>
1432
1433         Test that NP_Initialize and NP_GetEntryPoints are called in the
1434         correct order
1435
1436         The order differs between Mac and Windows (see r38858).
1437
1438         Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in
1439         NP_Initialize when loading QuickTime when running
1440         plugins/embed-attributes-setting.html in WebKit2 on Windows
1441
1442         Reviewed by John Sullivan.
1443
1444         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and
1445         a boolean to record whether NP_GetEntryPoints has been called.
1446         (NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been
1447         called yet. This matches Flash and QuickTime's behavior.
1448         (NP_GetEntryPoints): Crash on Mac if NP_Initialize hasn't been called
1449         yet. This matches Silverlight's behavior.
1450
1451 2010-08-25  Martin Robinson  <mrobinson@igalia.com>
1452
1453         Reviewed by Gustavo Noronha Silva.
1454
1455         Cairo and EFL port shouldn't depend on glib.
1456         https://bugs.webkit.org/show_bug.cgi?id=44354
1457
1458         Replace occurrences of GRefPtr and adoptGRef with PlatformRefPtr and
1459         adoptPlatformRef.
1460
1461         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1462         (AccessibilityUIElement::isSelected):
1463
1464 2010-08-25  Ojan Vafai  <ojan@chromium.org>
1465
1466         Fix order of Timothy's email address. The script, and
1467         other tools all assume that the first email is the bugzilla address.
1468
1469         * Scripts/webkitpy/common/config/committers.py:
1470
1471 2010-08-24  Kent Tamura  <tkent@chromium.org>
1472
1473         Reviewed by Pavel Feldman.
1474
1475         [DRT/Chromium] Fix 26 inspector test crashes
1476         https://bugs.webkit.org/show_bug.cgi?id=44580
1477
1478         - DRTDevToolsAgent has a reference to the main WebView. So we
1479           should not clear it in closeDevTools() and should clear it in
1480           ~TestShell().
1481         - DRTDevToolsClient has a reference to a DevTools WebView and no
1482           way to update it. So we should delete DRTDevToolsClient instances
1483           in closeDevTools().
1484
1485         * DumpRenderTree/chromium/TestShell.cpp:
1486         (TestShell::~TestShell):
1487         (TestShell::closeDevTools):
1488
1489 2010-08-24  Eric Seidel  <eric@webkit.org>
1490
1491         Reviewed by Adam Barth.
1492
1493         unicode(Exception(\u"0x1234")) is busted in python 2.5, disable tests which hit this
1494         https://bugs.webkit.org/show_bug.cgi?id=44584
1495
1496         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1497
1498 2010-08-24  Eric Seidel  <eric@webkit.org>
1499
1500         Reviewed by Adam Barth.
1501
1502         commit-queue and EWS bots should report all failures
1503         https://bugs.webkit.org/show_bug.cgi?id=41820
1504
1505         Right now commit-queue/EWS only report failures when the
1506         patch under testing fails.  We should report all failures
1507         to the status server so that we can diagnose when the bots
1508         are wedged w/o needing to log into the machines.
1509
1510         I also reduced the amount of data we upload since we've seen
1511         timeouts during status upload.
1512
1513         * Scripts/webkitpy/common/system/executive.py:
1514         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1515         * Scripts/webkitpy/tool/commands/queues.py:
1516         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1517
1518 2010-08-24  Eric Seidel  <eric@webkit.org>
1519
1520         Reviewed by Adam Barth.
1521
1522         Remove HTML5 parser testing infrastructure now that we don't need it
1523         https://bugs.webkit.org/show_bug.cgi?id=44581
1524
1525         * DumpRenderTree/mac/DumpRenderTree.mm:
1526         (resetDefaultsToConsistentValues):
1527         (initializeGlobalsFromCommandLineOptions):
1528         * Scripts/old-run-webkit-tests:
1529         * Scripts/test-html5-parser: Removed.
1530
1531 2010-08-24  Kent Tamura  <tkent@chromium.org>
1532
1533         Reviewed by Dimitri Glazkov.
1534
1535         [DRT/Chromium] Fix 28 inspector test crashes
1536         https://bugs.webkit.org/show_bug.cgi?id=44574
1537
1538         Reset DevToolsClient and DevToolsAgent before closing a DevTools
1539         WebView in order to avoid accessing to a deleted WebView instance.
1540
1541         * DumpRenderTree/chromium/TestShell.cpp:
1542         (TestShell::closeDevTools):
1543
1544 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
1545
1546         Reviewed by Ojan Vafai.
1547
1548         new-run-webkit-tests: clean up code for test_types, test_failures
1549
1550         Add a bunch of unit tests for webkitpy.layout_tests.test_types and
1551         webkitpy.layout_tests.layout_package.test_failures, and remove
1552         some dead code and otherwise clean up things.
1553
1554         https://bugs.webkit.org/show_bug.cgi?id=44559
1555
1556         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1557         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py: Added.
1558         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1559         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1560         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1561         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: Added.
1562         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1563
1564 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
1565
1566         Reviewed by Eric Seidel.
1567
1568         new-run-webkit-tests: revise unit testing strategy for test failures
1569     
1570         This change revamps the way we store test data for new-run-webkit-tests.
1571         Previously we had a few copies of test files from the main test tree.
1572         Now we have a bunch of completely fake test data and use the test
1573         data to generate different kinds of test failures, getting
1574         much better coverage.
1575
1576         https://bugs.webkit.org/show_bug.cgi?id=44556
1577
1578         * Scripts/webkitpy/layout_tests/data/failures/expected/crash.html: Added.
1579         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.checksum: Added.
1580         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.png: Added.
1581         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.txt: Added.
1582         * Scripts/webkitpy/layout_tests/data/failures/expected/image.html: Added.
1583         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.checksum: Added.
1584         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.png: Added.
1585         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.txt: Added.
1586         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html: Added.
1587         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html: Added.
1588         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_text.html: Added.
1589         * Scripts/webkitpy/layout_tests/data/failures/expected/text-expected.txt: Added.
1590         * Scripts/webkitpy/layout_tests/data/failures/expected/text.html: Added.
1591         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.checksum: Added.
1592         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.png: Added.
1593         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.txt: Added.
1594         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum.html: Added.
1595         * Scripts/webkitpy/layout_tests/data/image/canvas-bg.html: Removed.
1596         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.checksum: Removed.
1597         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.png: Removed.
1598         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.txt: Removed.
1599         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom.html: Removed.
1600         * Scripts/webkitpy/layout_tests/data/misc/crash-expected.txt: Removed.
1601         * Scripts/webkitpy/layout_tests/data/misc/crash.html: Removed.
1602         * Scripts/webkitpy/layout_tests/data/misc/missing-expectation.html: Removed.
1603         * Scripts/webkitpy/layout_tests/data/misc/passing-expected.txt: Removed.
1604         * Scripts/webkitpy/layout_tests/data/misc/passing.html: Removed.
1605         * Scripts/webkitpy/layout_tests/data/passes/image-expected.checksum: Added.
1606         * Scripts/webkitpy/layout_tests/data/passes/image-expected.png: Added.
1607         * Scripts/webkitpy/layout_tests/data/passes/image-expected.txt: Added.
1608         * Scripts/webkitpy/layout_tests/data/passes/image.html: Added.
1609         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.checksum: Added.
1610         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.png: Added.
1611         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.txt: Added.
1612         * Scripts/webkitpy/layout_tests/data/passes/platform_image.html: Added.
1613         * Scripts/webkitpy/layout_tests/data/passes/text-expected.txt: Added.
1614         * Scripts/webkitpy/layout_tests/data/passes/text.html: Added.
1615         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.checksum: Removed.
1616         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.png: Removed.
1617         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.txt: Removed.
1618         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.checksum: Added.
1619         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.png: Added.
1620         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.txt: Added.
1621         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
1622         * Scripts/webkitpy/layout_tests/data/text/article-element-expected.txt: Removed.
1623         * Scripts/webkitpy/layout_tests/data/text/article-element.html: Removed.
1624         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1625         * Scripts/webkitpy/layout_tests/port/test.py:
1626         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1627         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1628
1629 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
1630
1631         Reviewed by Eric Seidel.
1632
1633         speed up new-run-webkit-tests unit tests
1634
1635         Add a --no-record-results flag that turns off generating the JSON
1636         results file on every test run. Generating the file requires us to
1637         fetch the old results down from the bots, which can be slow. This
1638         flag is off by default.
1639     
1640         Reduce the sleep time in wait_for_threads_to_finish from 0.1s to 0.01s.
1641     
1642         These changes together shorten the test cycle from ~4.5s to ~1.5s
1643         - a 3x speedup.
1644
1645         https://bugs.webkit.org/show_bug.cgi?id=44553
1646
1647         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1648         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1649
1650 2010-08-24  Tony Chang  <tony@chromium.org>
1651
1652         Reviewed by Eric Seidel.
1653
1654         [chromium] fix the platform result fallback order on mac/win
1655         https://bugs.webkit.org/show_bug.cgi?id=44483
1656
1657         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1658
1659 2010-08-24  Xan Lopez  <xlopez@igalia.com>
1660
1661         Reviewed by Martin Robinson.
1662
1663         Set a device to the event struct when building with GTK+ 3.x, it's
1664         mandatory.
1665
1666         * DumpRenderTree/gtk/EventSender.cpp:
1667         (keyDownCallback):
1668
1669 2010-08-24  Martin Robinson  <mrobinson@igalia.com>
1670
1671         Reviewed by Xan Lopez.
1672
1673         [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
1674         https://bugs.webkit.org/show_bug.cgi?id=44534
1675
1676         Fix two double-frees introduced in my previous commit.
1677
1678         * DumpRenderTree/gtk/EventSender.cpp:
1679         (contextClickCallback): Copy the event before using it again.
1680         (keyDownCallback): Ditto.
1681
1682 2010-08-24  Martin Robinson  <mrobinson@igalia.com>
1683
1684         Reviewed by Xan Lopez.
1685
1686         [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
1687         https://bugs.webkit.org/show_bug.cgi?id=44534
1688
1689         * DumpRenderTree/gtk/EventSender.cpp:
1690         (prepareMouseButtonEvent): Use gdk_event_new and reference the reference the GdkWindow
1691         when setting it on the event. It is dereferenced by gdk_event_free(...).
1692         (contextClickCallback): Ditto.
1693         (mouseDownCallback): Ditto.
1694         (mouseUpCallback): Ditto.
1695         (mouseMoveToCallback): Ditto.
1696         (mouseWheelToCallback): Ditto.
1697         (sendOrQueueEvent): Take a GdkEvent* instead of a GdkEvent.
1698         (dispatchEvent): Ditto. Also free the event when we are done with it.
1699         (keyDownCallback): Use gdk_event_new and reference the GdkWindow.
1700
1701 2010-08-24  Andras Becsi  <abecsi@webkit.org>
1702
1703         [Qt] WebKit2 build fix.
1704
1705         * Scripts/enumerate-included-framework-headers:
1706         Remove stray global option form sed.
1707
1708 2010-08-24  Kent Tamura  <tkent@chromium.org>
1709
1710         Reviewed by Jeremy Orlow.
1711
1712         [DRT/Chromium] Support for IndexedDB tests
1713         https://bugs.webkit.org/show_bug.cgi?id=44490
1714
1715         * DumpRenderTree/chromium/TestShell.cpp:
1716         (TestShell::TestShell): Enable IndexedDB.
1717
1718 2010-08-23  Martin Robinson  <mrobinson@igalia.com>
1719
1720         Reviewed by Gustavo Noronha Silva.
1721
1722         [GTK] The 64-bit Release bot is showing crashes on tests that use mouse buttons
1723         https://bugs.webkit.org/show_bug.cgi?id=44465
1724
1725         Initialize the axes field of mouse button and motion events to null.
1726         This is the value that should be used for events originating from the
1727         mouse device.
1728
1729         * DumpRenderTree/gtk/EventSender.cpp:
1730         (prepareMouseButtonEvent): Initalize button event axes field to null.
1731         (mouseMoveToCallback): Initialize motion event axes field to null.
1732
1733 2010-08-23  Sheriff Bot  <webkit.review.bot@gmail.com>
1734
1735         Unreviewed, rolling out r65703.
1736         http://trac.webkit.org/changeset/65703
1737         https://bugs.webkit.org/show_bug.cgi?id=44460
1738
1739         "Causing lots of crashes on Snow Leopard when running the
1740         layout tests" (Requested by eseidel2 on #webkit).
1741
1742         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1743         (NP_Initialize):
1744         (NP_GetEntryPoints):
1745
1746 2010-08-23  Jon Honeycutt  <jhoneycutt@apple.com>
1747
1748         Layout tests do not run when using WebKitTestRunner in a Debug build.
1749         https://bugs.webkit.org/show_bug.cgi?id=44409
1750
1751         Reviewed by Dan Bernstein.
1752
1753         * WebKitTestRunner/win/TestControllerWin.cpp:
1754         (WTR::TestController::initializeInjectedBundlePath):
1755         Use InjectedBundle_debug.dll when building Debug.
1756
1757 2010-08-23  Xan Lopez  <xlopez@igalia.com>
1758
1759         Reviewed by Martin Robinson.
1760
1761         [GTK] run-launcher fails if WebKitGTK+ compiled with GTK+-3.0 support
1762         https://bugs.webkit.org/show_bug.cgi?id=42026
1763
1764         If a GTK+ 3.x build is present return that as the library to use,
1765         otherwise fallback to the GTK+ 2.x build.
1766
1767         * Scripts/webkitdirs.pm:
1768
1769 2010-08-23  Balazs Kelemen  <kb@inf.u-szeged.hu>
1770
1771         Reviewed by Ariya Hidayat.
1772
1773         [Qt] Find needed forwarding headers for WebKit2 automatically
1774         https://bugs.webkit.org/show_bug.cgi?id=44336
1775
1776         * MiniBrowser/qt/BrowserWindow.cpp: Use normal (not framework style) includes here.
1777         The new script does not satisfy the needs of this file however using normal includes
1778         is generally better here.
1779         * MiniBrowser/qt/MiniBrowser.pro: Added include paths.
1780         * Scripts/enumerate-included-framework-headers: Enumerates headers included from the 
1781         given frameworks by files in the current directory (and subdirectories).
1782         In the future this needs to be rewritten in perl for being able to use on Windows.
1783
1784 2010-08-22  No'am Rosenthal  <noam.rosenthal@nokia.com>
1785
1786         Reviewed by Ariya Hidayat.
1787
1788         [Qt] Qt test browser: enable a QGLWidget viewport with a command line argument
1789         https://bugs.webkit.org/show_bug.cgi?id=43010
1790
1791         * QtTestBrowser/launcherwindow.cpp:
1792         (LauncherWindow::applyPrefs):
1793         * QtTestBrowser/main.cpp:
1794         (LauncherApplication::handleUserOptions):
1795
1796 2010-08-21  Sam Weinig  <sam@webkit.org>
1797
1798         Reviewed by Dan Bernstein.
1799
1800         Remove specialized retain/release functions in favor of a single one for WKTypeRefs
1801         https://bugs.webkit.org/show_bug.cgi?id=44386
1802
1803         * MiniBrowser/mac/AppDelegate.m:
1804         (didRecieveMessageFromInjectedBundle):
1805         (didNavigateWithNavigationData):
1806         (-[BrowserAppDelegate init]):
1807         (-[BrowserAppDelegate applicationWillTerminate:]):
1808         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
1809         (-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
1810         (-[BrowserStatisticsWindowController dealloc]):
1811         * MiniBrowser/mac/BrowserWindowController.m:
1812         (-[BrowserWindowController initWithPageNamespace:]):
1813         (-[BrowserWindowController fetch:]):
1814         (-[BrowserWindowController windowWillClose:]):
1815         (-[BrowserWindowController applicationTerminating]):
1816         (closePage):
1817         (runJavaScriptAlert):
1818         (runJavaScriptConfirm):
1819         (runJavaScriptPrompt):
1820         (-[BrowserWindowController updateProvisionalURLForFrame:]):
1821         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1822         (didClearWindowObjectForFrame):
1823         * MiniBrowser/win/BrowserView.cpp:
1824         (BrowserView::goToURL):
1825         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1826         (WTR::PlatformWebView::~PlatformWebView):
1827
1828 2010-08-20  Benjamin Poulain  <benjamin.poulain@nokia.com>
1829
1830         Reviewed by Kenneth Rohde Christiansen.
1831
1832         WebKit does not build with Python 2.3
1833         https://bugs.webkit.org/show_bug.cgi?id=44373
1834
1835         Replaced the function sorted() by a call to sort()
1836         on the entry list.
1837         The function sorted() has been added to Python 2.4.
1838         The function method sort() of List works with older
1839         versions of Python.
1840
1841         * Scripts/create-html-entity-table:
1842
1843 2010-08-20  Martin Robinson  <mrobinson@igalia.com>
1844
1845         Reviewed by Pavel Feldman.
1846
1847         Web Inspector: Inspector tests were disabled for GTK.
1848         https://bugs.webkit.org/show_bug.cgi?id=43977
1849
1850         * Scripts/old-run-webkit-tests: Set the WEBKIT_INSPECTOR_PATH to the appropriate
1851         path before running tests.
1852
1853 2010-08-20  Daniel Bates  <dbates@rim.com>
1854
1855         Reviewed by Eric Seidel.
1856
1857         svn-apply doesn't detect empty line with Windows line endings
1858         after property value
1859         https://bugs.webkit.org/show_bug.cgi?id=43981
1860
1861         Part 2 of 2
1862
1863         Add unit tests that were not landed in the first commit.
1864
1865         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
1866           - Added the following test cases:
1867             "SVN: binary file (isBinary true) using Windows line endings"
1868             "SVN: property diff, followed by file change diff using Windows line endings"
1869             "SVN: two consecutive property diffs using Windows line endings"
1870             "SVN: binary file with executable bit change usng Windows line endings"
1871             "SVN: binary file followed by property change on different file using Windows line endings"
1872             "SVN: binary file followed by file change on different file using Windows line endings"
1873             "SVN: file change diff with property change, followed by property change diff using Windows line endings"
1874             "SVN: file change diff with property change, followed by file change diff using Windows line endings"
1875         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
1876           - Added the following test cases:
1877             "add svn:executable, followed by empty line and start of next diff using Windows line endings"
1878             "add svn:executable, followed by empty line and start of next property diff using Windows line endings"
1879             "multi-line '+' change, followed by empty line and start of next diff using Windows line endings"
1880             "multi-line '+' change, followed by empty line and start of next property diff using Windows line endings"
1881             "add svn:executable, followed by empty line and start of binary patch using Windows line endings"
1882             "multi-line '+' change, followed by empty line and start of binary patch using Windows line endings"
1883             "multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings"
1884             "single-line '+' with trailing new line using Windows line endings"
1885             "single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings"
1886             "single-line '-' change with trailing new line, and single-line '+' change using Windows line endings"
1887             "multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
1888         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
1889           - Added the following test cases:
1890             "single-line '-' change followed by empty line with Windows line endings"
1891             "multi-line '+' change and start of binary patch with Windows line endings"
1892
1893 2010-08-20  Daniel Bates  <dbates@rim.com>
1894
1895         Reviewed by Eric Seidel.
1896
1897         svn-apply doesn't detect empty line with Windows line endings
1898         after property value
1899         https://bugs.webkit.org/show_bug.cgi?id=43981
1900
1901         Fixes an issue where an empty line following the property value
1902         in an SVN property change diff would not be detected if it had
1903         Windows line endings (i.e. ended in CRLF). Hence it was consumed
1904         as if it was part of a multi-line property value. 
1905
1906         * Scripts/VCSUtils.pm:
1907           - Modified parseSvnPropertyValue() to detect empty line
1908             with Windows line endings.
1909           - Added toWindowsLineEndings().
1910         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
1911           - Added the following test cases:
1912             "SVN: binary file (isBinary true) using Windows line endings"
1913             "SVN: property diff, followed by file change diff using Windows line endings"
1914             "SVN: two consecutive property diffs using Windows line endings"
1915             "SVN: binary file with executable bit change usng Windows line endings"
1916             "SVN: binary file followed by property change on different file using Windows line endings"
1917             "SVN: binary file followed by file change on different file using Windows line endings"
1918             "SVN: file change diff with property change, followed by property change diff using Windows line endings"
1919             "SVN: file change diff with property change, followed by file change diff using Windows line endings"
1920         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
1921           - Added the following test cases:
1922             "add svn:executable, followed by empty line and start of next diff using Windows line endings"
1923             "add svn:executable, followed by empty line and start of next property diff using Windows line endings"
1924             "multi-line '+' change, followed by empty line and start of next diff using Windows line endings"
1925             "multi-line '+' change, followed by empty line and start of next property diff using Windows line endings"
1926             "add svn:executable, followed by empty line and start of binary patch using Windows line endings"
1927             "multi-line '+' change, followed by empty line and start of binary patch using Windows line endings"
1928             "multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings"
1929             "single-line '+' with trailing new line using Windows line endings"
1930             "single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings"
1931             "single-line '-' change with trailing new line, and single-line '+' change using Windows line endings"
1932             "multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
1933         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
1934           - Added the following test cases:
1935             "single-line '-' change followed by empty line with Windows line endings"
1936             "multi-line '+' change and start of binary patch with Windows line endings"
1937
1938 2010-08-19  David Kilzer  <ddkilzer@apple.com>
1939
1940         BUILD FIX: Fix Mac build after Windows WebKit2 changes for Netscape Plug-ins
1941
1942         * MiniBrowser/mac/BrowserWindowController.m:
1943         (decidePolicyForNavigationAction): Updated method signature.
1944         (decidePolicyForNewWindowAction): Updated method signature.
1945
1946 2010-08-19  Adam Roben  <aroben@apple.com>
1947
1948         Test that NP_Initialize and NP_GetEntryPoints are called in the
1949         correct order
1950
1951         The order differs between Mac and Windows (see r38858).
1952
1953         Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in
1954         NP_Initialize when loading QuickTime when running
1955         plugins/embed-attributes-setting.html in WebKit2 on Windows
1956
1957         Reviewed by Sam Weinig.
1958
1959         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and
1960         a boolean to record whether NP_GetEntryPoints has been called.
1961         (NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been
1962         called yet. This matches Flash and QuickTime's behavior. Crash on Mac
1963         if NP_GetEntryPoints has been called already. This matches
1964         Silverlight's behavior.
1965
1966 2010-08-19  Adam Roben  <aroben@apple.com>
1967
1968         Make build-webkittestrunner build TestNetscapePlugIn on Windows
1969
1970         Fixes <http://webkit.org/b/44268> <rdar://problem/8330388>
1971
1972         Reviewed by Sam Weinig.
1973
1974         * WebKitTestRunner/WebKitTestRunner.sln: Added TestNetscapePlugIn.
1975         Threaded it in between ImageDiff and InjectedBundleGenerated.
1976
1977 2010-08-19  Ojan Vafai  <ojan@chromium.org>
1978
1979         Reviewed by Adam Barth.
1980
1981         install rietveld's upload script from a versioned url
1982         https://bugs.webkit.org/show_bug.cgi?id=44291
1983
1984         autoinstall expects the file at a given URL to never change.
1985         In order to be able to update the file, we need to be able to
1986         change the path.
1987
1988         * Scripts/webkitpy/thirdparty/__init__.py:
1989
1990 2010-08-19  Ojan Vafai  <ojan@chromium.org>
1991
1992         Reviewed by Adam Barth.
1993
1994         add --webkit_patch_id to reitveld uploads
1995         https://bugs.webkit.org/show_bug.cgi?id=44289
1996
1997         This is the first step in having rietveld store which
1998         patches have been uploaded and getting rid of the
1999         in-rietveld flag.
2000
2001         * Scripts/webkitpy/common/net/rietveld.py:
2002         * Scripts/webkitpy/tool/mocktool.py:
2003         * Scripts/webkitpy/tool/steps/postcodereview.py:
2004
2005 2010-08-19  Kenneth Russell  <kbr@google.com>
2006
2007         Reviewed by David Levin.
2008
2009         Adjust my status from committer to reviewer
2010         https://bugs.webkit.org/show_bug.cgi?id=44277
2011
2012         * Scripts/webkitpy/common/config/committers.py:
2013
2014 2010-08-19  Pavel Feldman  <pfeldman@chromium.org>
2015
2016         Reviewed by Yury Semikhatsky.
2017
2018         Chromium DevTools: remove injected script fetcher from test harness.
2019         https://bugs.webkit.org/show_bug.cgi?id=44266
2020
2021         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2022         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2023
2024 2010-08-19  Pavel Feldman  <pfeldman@chromium.org>
2025
2026         Reviewed by Yury Semikhatsky.
2027
2028         Chromium DevTools: There is no need in resource-based InjectedScript.js source.
2029         Now that we populate front-end after its onload handler, we don't need
2030         to install injected script early. Exposing injected script source on the WebCore
2031         level here.
2032         https://bugs.webkit.org/show_bug.cgi?id=44029
2033
2034         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2035         (DRTDevToolsAgent::runtimePropertyChanged):
2036         (DRTDevToolsAgent::delayedFrontendLoaded):
2037         (DRTDevToolsAgent::frontendLoaded):
2038         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2039
2040 2010-08-19  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2041
2042         Reviewed by Kenneth Rohde Christiansen.
2043
2044         [Gtk] Enable view mode media feature layout test
2045         https://bugs.webkit.org/show_bug.cgi?id=43278
2046
2047         Add view mode media feature testing infrastructure, and add
2048         placeholder methods for the other platforms'
2049         LayoutTestControllers.
2050
2051         * DumpRenderTree/LayoutTestController.cpp:
2052         (setViewModeMediaFeatureCallback):
2053         (LayoutTestController::staticFunctions):
2054         * DumpRenderTree/LayoutTestController.h:
2055         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2056         (LayoutTestController::setViewModeMediaFeature):
2057         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2058         (LayoutTestController::setViewModeMediaFeature):
2059         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2060         (LayoutTestController::setViewModeMediaFeature):
2061         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2062         (LayoutTestController::setViewModeMediaFeature):
2063
2064 2010-08-18  Mark Rowe  <mrowe@apple.com>
2065
2066         Reviewed by Sam Weinig.
2067
2068         Make it so the WebKit2 test slave runs the WebKit2 tests
2069
2070         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2071
2072 2010-08-18  Sam Weinig  <sam@webkit.org>
2073
2074         Reviewed by Mark Rowe.
2075
2076         Make run-webkit-tests --webkit-test-runner build DumpRenderTree
2077         in addition to WebKitTestRunner to get the DumpRenderTreeSupport
2078         module and the TestNetscapePlugin.
2079
2080         * Scripts/old-run-webkit-tests:
2081
2082 2010-08-18  Adam Roben  <aroben@apple.com>
2083
2084         Fix hang when saving crash logs on Windows
2085
2086         * Scripts/old-run-webkit-tests:
2087         (setUpWindowsCrashLogSaving):
2088         (END):
2089         Pass -s to regtool so it will write the Auto value as a string instead
2090         of as a number. This was causing a "do you want to debug?" dialog to
2091         appear.
2092
2093 2010-08-17  Victor Wang  <victorw@chromium.org>
2094
2095         Unreviewed. Fixed chromium incremental test json upload.
2096         Quote builder name and test results server in url.
2097
2098         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2099
2100 2010-08-17  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2101
2102         Reviewed by Ariya Hidayat.
2103
2104         [Qt] [Symbian] Consistently use Q_OS_SYMBIAN to guard all Symbian platform dependencies
2105         https://bugs.webkit.org/show_bug.cgi?id=44124
2106
2107         Q_WS_S60 is not defined for Symbian^4 devices as Q_WS_S60 used to guard 
2108         Avkon UI framework dependencies. Use Q_OS_SYMBIAN everywhere to mark
2109         Symbian dependencies.
2110
2111         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2112         (WebCore::DumpRenderTree::open):
2113         * QtTestBrowser/launcherwindow.cpp:
2114         (LauncherWindow::init):
2115         (LauncherWindow::toggleFullScreenMode):
2116         (LauncherWindow::showFPS):
2117         (LauncherWindow::updateFPS):
2118         * QtTestBrowser/launcherwindow.h:
2119         (WindowOptions::WindowOptions):
2120         * QtTestBrowser/mainwindow.cpp:
2121         (MainWindow::buildUI):
2122
2123 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
2124
2125         Reviewed by David Levin.
2126
2127         new-run-webkit-tests: remove --show-sources option
2128
2129         --show-sources is pretty much obsolete with --trace everything, so
2130         I'm removing it.
2131
2132         Also rename a couple of methods in the TestTextDiff class to make their
2133         intended visibility (private) more obvious.
2134
2135         https://bugs.webkit.org/show_bug.cgi?id=44143
2136
2137         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2138         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2139         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2140         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2141         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2142
2143 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
2144
2145         Reviewed by David Levin.
2146
2147         remove --fuzzy-image-diff in new-run-webkit-tests (it doesn't work)
2148
2149         This code bit-rotted at some point more than a year ago, and nobody seems
2150         to miss it. old-run-webkit-tests has a --tolerance flag that new-run-webkit-tests
2151         should support instead, making this flag unnecessary anyway.
2152
2153         https://bugs.webkit.org/show_bug.cgi?id=44141
2154
2155         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2156         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2157         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Removed.
2158
2159 2010-08-17  Victor Wang  <victorw@chromium.org>
2160
2161         Reviewed by Ojan Vafai.
2162
2163         Update json results generator to have incremental json including
2164         results for tests that pass in current run but failed before.
2165
2166         https://bugs.webkit.org/show_bug.cgi?id=44119
2167
2168         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2169         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2170         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2171
2172 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
2173
2174         Reviewed by Eric Seidel.
2175
2176         fix test-webkitpy, add easy way to find a checkout root
2177
2178         test-webkitpy currently doesn't work right if run from someplace other
2179         than the checkout root, and it spews a bunch of debug logging because
2180         the deduplicate_tests tests contaminates the test environment.
2181
2182         This patch cleans up the deduplicate_tests unit tests, and creates
2183         two new methods in scm.py: find_checkout_root() and default_scm(),
2184         both of which use a single algorithm for guessing what checkout root
2185         to use if you aren't explicitly told one from a path.
2186
2187         https://bugs.webkit.org/show_bug.cgi?id=44001
2188
2189         * Scripts/deduplicate-tests:
2190         * Scripts/webkitpy/common/checkout/scm.py:
2191         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2192         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
2193         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2194         * Scripts/webkitpy/layout_tests/port/test.py:
2195         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2196         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2197         * Scripts/webkitpy/tool/main.py:
2198
2199 2010-08-17  Victor Wang  <victorw@chromium.org>
2200
2201         Reviewed by Ojan Vafai.
2202
2203         Add support to the test results server for downloading json that
2204         contains test list only.
2205
2206         This is for json results generator to generate incremental json
2207         results so that it includes results not only for tests failed in
2208         current run, but also tests failed before.
2209
2210         Also set the results type to "N" (no data) instead of "P" (pass)
2211         if test results cannot be found in incremental json file.
2212
2213         https://bugs.webkit.org/show_bug.cgi?id=44117
2214
2215         * TestResultServer/handlers/testfilehandler.py:
2216         * TestResultServer/model/jsonresults.py:
2217         * TestResultServer/model/jsonresults_unittest.py:
2218
2219 2010-08-17  Adam Roben  <aroben@apple.com>
2220
2221         Use the right path style
2222
2223         * Scripts/old-run-webkit-tests:
2224
2225 2010-08-17  Adam Roben  <aroben@apple.com>
2226
2227         Fix typo
2228
2229         * Scripts/old-run-webkit-tests:
2230
2231 2010-08-17  Adam Roben  <aroben@apple.com>
2232
2233         Don't hang when running run-webkit-tests as a non-Administrator on
2234         Vista/7
2235
2236         * Scripts/old-run-webkit-tests:
2237         (setUpWindowsCrashLogSaving): Use regtool to set NTSD as the
2238         post-mortem debugger, rather than using NTSD itself. The latter waits
2239         for user input when it fails to set the registry values; the former
2240         does not.
2241
2242 2010-08-17  Adam Roben  <aroben@apple.com>
2243
2244         Teach run-webkit-tests, DumpRenderTree, and WebKitTestRunner how to
2245         save crash logs on Windows
2246
2247         The crash logs are saved to /tmp/layout-test-results and have names
2248         like CrashLog_02bc_2010-08-17_14-36-20-108.txt.
2249
2250         Unfortunately, crashes in the WebKit2 web process are recorded as
2251         time-outs by run-webkit-tests. Fixing this is covered by
2252         <http://webkit.org/b/44121>.
2253
2254         Fixes <http://webkit.org/b/37859> <rdar://problem/7883560>
2255         DumpRenderTree should save a stack trace and/or dump file when it
2256         crashes
2257
2258         Reviewed by Sam Weinig.
2259
2260         * DumpRenderTree/win/DumpRenderTree.cpp:
2261         (exceptionFilter):
2262         (main):
2263         * WebKitTestRunner/win/TestControllerWin.cpp:
2264         (WTR::exceptionFilter):
2265         (WTR::TestController::platformInitialize):
2266         These changes set up an exception filter that prints #CRASHED to
2267         stderr, then lets the exception propagate normally. This allows
2268         run-webkit-tests to detect when we've crashed even when a post-mortem
2269         debugger attaches to the process.
2270
2271         * Scripts/old-run-webkit-tests:
2272         (top level): Declared some variables used by the crash-log-saving
2273         code.
2274         (openDumpTool): Copy _NT_SYMBOL_PATH into the clean environment so
2275         that the post-mortem debugger has access to it.
2276         (toCygwinPath): Added. This is the opposite of toWindowsPath.
2277         (readFromDumpToolWithTimer): If the dump tool prints #CRASHED to
2278         stderr, consider it a crash.
2279         (setUpWindowsCrashLogSaving): Added. Saves the current post-mortem
2280         debugger, then sets ntsd as the post-mortem debugger. ntsd is
2281         configured to save a crash log and then quit automatically.
2282         (END): Added. Restores the previous post-mortem debugger when the
2283         script exits.
2284
2285 2010-08-17  Victor Wang  <victorw@chromium.org>
2286
2287         Reviewed by ojan@chromium.org.
2288
2289         Update test results server:
2290         1. Normalize test results and times after merging (prune tests where
2291            all runs pass or do not have data, truncate all test items to max
2292            number of builds)
2293         2. times should be int not string.
2294         3. when inserting a new test item, should keep old data regardless
2295            whether or not they have same item type with new one.
2296
2297         https://bugs.webkit.org/show_bug.cgi?id=43861
2298
2299         * TestResultServer/model/jsonresults.py:
2300         * TestResultServer/model/jsonresults_unittest.py:
2301
2302 2010-08-16  Sam Weinig  <sam@webkit.org>
2303
2304         Reviewed by Mark Rowe.
2305
2306         Add WebKit2 Mac tester to buildbot.
2307
2308         * BuildSlaveSupport/build.webkit.org-config/config.json:
2309         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2310
2311 2010-08-16  Paul Sawaya  <psawaya@apple.com>
2312
2313         Reviewed by Chris Marrin.
2314
2315         Added shader validation via ANGLE
2316         https://bugs.webkit.org/show_bug.cgi?id=42405
2317
2318         Added ANGLE to webkit build
2319
2320         * Scripts/build-webkit:
2321
2322 2010-08-16  Kevin Ollivier  <kevino@theolliviers.com>
2323
2324         [wx] Build fix, do not build WebCore as a convenience library as this leads to
2325         errors in the Win build w/export symbols and causes problems with DOM bindings
2326         debugging in gdb.
2327
2328         * DumpRenderTree/wscript:
2329         * Scripts/build-webkit:
2330         * wx/browser/wscript:
2331         * wx/build/settings.py:
2332         * wx/build/waf_extensions.py:
2333
2334 2010-08-16  Dan Bernstein  <mitz@apple.com>
2335
2336         Build fix.
2337
2338         * WebKitTestRunner/TestController.cpp:
2339         (WTR::createOtherPage): Initialize the contentsSizeChanged member.
2340         (WTR::TestController::initialize): Ditto.
2341
2342 2010-08-16  Balazs Kelemen  <kb@inf.u-szeged.hu>
2343
2344         Reviewed by Kenneth Rohde Christiansen.
2345
2346         Handle content size change in WebKit2
2347         Re-landing after fix.
2348
2349         https://bugs.webkit.org/show_bug.cgi?id=43198
2350
2351         * MiniBrowser/mac/BrowserWindowController.m:
2352         (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
2353         * MiniBrowser/win/BrowserView.cpp:
2354         (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.
2355
2356 2010-08-16  Sheriff Bot  <webkit.review.bot@gmail.com>
2357
2358         Unreviewed, rolling out r65419.
2359         http://trac.webkit.org/changeset/65419
2360         https://bugs.webkit.org/show_bug.cgi?id=44053
2361
2362         Broke the Windows build (Requested by bbandix on #webkit).
2363
2364         * MiniBrowser/mac/BrowserWindowController.m:
2365         (-[BrowserWindowController awakeFromNib]):
2366         * MiniBrowser/win/BrowserView.cpp:
2367         (BrowserView::create):
2368
2369 2010-08-16  Balazs Kelemen  <kb@inf.u-szeged.hu>
2370
2371         Reviewed by Kenneth Rohde Christiansen.
2372
2373         Handle content size change in WebKit2
2374
2375         https://bugs.webkit.org/show_bug.cgi?id=43198
2376
2377         * MiniBrowser/mac/BrowserWindowController.m:
2378         (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
2379         * MiniBrowser/win/BrowserView.cpp:
2380         (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.
2381
2382 2010-08-16  Ariya Hidayat  <ariya@sencha.com>
2383
2384         Add my new email address to committers.py.
2385
2386         * Scripts/webkitpy/common/config/committers.py:
2387
2388 2010-08-16  Zoltan Horvath  <zoltan@webkit.org>
2389
2390         Add my old e-mail addresses to committers.py.
2391
2392         * Scripts/webkitpy/common/config/committers.py:
2393
2394 2010-08-15  Jon Honeycutt  <jhoneycutt@apple.com>
2395
2396         WebEditorClient::didBeginEditing is never called in WebKit2
2397         https://bugs.webkit.org/show_bug.cgi?id=42939
2398
2399         Reviewed by Sam Weinig.
2400
2401         * WebKitTestRunner/PlatformWebView.h:
2402         Declare focus().
2403
2404         * WebKitTestRunner/TestController.cpp:
2405         (WTR::TestController::resetStateToConsistentValues):
2406         Focus the PlatformWebView.
2407
2408         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2409         (WTR::PlatformWebView::focus):
2410         Stubbed.
2411
2412         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2413         (WTR::PlatformWebView::focus):
2414         Focus the view.
2415
2416 2010-08-15  Jon Honeycutt  <jhoneycutt@apple.com>
2417
2418         run-webkit-tests should not strip editing callbacks when using
2419         WebKitTestRunner on Windows
2420         https://bugs.webkit.org/show_bug.cgi?id=44000
2421
2422         Reviewed by Mark Rowe.
2423
2424         * Scripts/old-run-webkit-tests:
2425         Leave $stripEditingCallbacks undefined until we look for command-line
2426         arguments. If using WebKit2, set it to 0 if not explicity set on the
2427         command line. Later, set it to isCygwin() to match old behavior if it is
2428         not yet defined.
2429
2430 2010-08-15  Kevin Ollivier  <kevino@theolliviers.com>
2431
2432         [wx] Build fix, remove define always set to the correct value by wtf/Platform.h.
2433
2434         * wx/build/settings.py:
2435
2436 2010-08-14  Martin Robinson  <mrobinson@igalia.com>
2437
2438         Reviewed by Kenneth Rohde Christiansen.
2439
2440         [GTK] autogen.sh not executed if build-webkit options change
2441         https://bugs.webkit.org/show_bug.cgi?id=42266
2442
2443         Rerun autogen.sh in situations where the arguments to build-webkit have
2444         changed since the previous build. This will fix some issues on the bots
2445         where the build does not notice changes to default build-webkit arguments.
2446
2447         * Scripts/webkitdirs.pm: Add special logic for detecting changes to build-webkit arguments.
2448
2449 2010-08-14  Eric Seidel  <eric@webkit.org>
2450
2451         Unreviewed.  Another fix to support python 2.3.
2452
2453         Add support for MathML entities
2454         https://bugs.webkit.org/show_bug.cgi?id=43949
2455
2456         * Scripts/webkitpy/thirdparty/simplejson/decoder.py:
2457          - It looks like our simplejson is version 1.7.3 which
2458            should be python 2.3 compatible.  But someone modified
2459            our copy slightly from the original source.
2460            I've removed the relative import in hopes this fixes
2461            the problem.
2462
2463 2010-08-13  Eric Seidel  <eric@webkit.org>
2464
2465         Unreviewed.  Build fix only.
2466
2467         Add support for MathML entities
2468         https://bugs.webkit.org/show_bug.cgi?id=43949
2469
2470         * Scripts/create-html-entity-table:
2471          - Hack sys.path to avoid executing 2.5 dependent python
2472            on systems (like chromium-win and Tiger) which do not have 2.5 python.
2473
2474 2010-08-13  Adam Barth  <abarth@webkit.org>
2475
2476         Reviewed by Eric Seidel.
2477
2478         Rename some concepts in HTML entity search to be more self-documenting
2479         https://bugs.webkit.org/show_bug.cgi?id=44004
2480
2481         Reflect name change in generator script.
2482
2483         * Scripts/create-html-entity-table:
2484
2485 2010-08-12  Adam Barth  <abarth@webkit.org>
2486
2487         Reviewed by Eric Seidel.
2488
2489         Add support for MathML entities
2490         https://bugs.webkit.org/show_bug.cgi?id=43949
2491
2492         A script for generating the C++ state data structure describing all the
2493         entities from a JSON description.
2494
2495         * Scripts/create-html-entity-table: Added.
2496
2497 2010-08-13  Dirk Pranke  <dpranke@chromium.org>
2498
2499         Reviewed by Eric Seidel.
2500
2501         Rewrite new-run-webkit-test's wait_for_threads_to_finish loop to
2502         check for exceptions on all threads, not just the first thread.
2503         
2504         This change also changes the logging behavior for wedged threads
2505         to only dump the stacks of threads that are actually wedged.
2506
2507         Refactor the thread classes in the dump_render_tree_thread module
2508         to make the contract between TestRunner and TestShellThread clearer.
2509
2510         Added a bunch of unit tests.
2511         https://bugs.webkit.org/show_bug.cgi?id=38561
2512
2513         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2514         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2515         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2516
2517 2010-08-13  Kenichi Ishibashi  <bashi@google.com>
2518
2519         Reviewed by Shinichiro Hamaji.
2520
2521         Add test_expectations.txt syntax checker to check-webkit-style.
2522         https://bugs.webkit.org/show_bug.cgi?id=43899
2523
2524         Just utilizing layout_tests/layout_package/test_expectations.py for checking
2525         the syntax of test_expectations.txt.
2526         This change also moves tab checking class from style/checkers/text.py to
2527         style/checkers/common.py for sharing code.
2528
2529         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2530         * Scripts/webkitpy/style/checker.py:
2531         * Scripts/webkitpy/style/checkers/common.py:
2532         * Scripts/webkitpy/style/checkers/common_unittest.py:
2533         * Scripts/webkitpy/style/checkers/test_expectations.py: Added.
2534         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Added.
2535         * Scripts/webkitpy/style/checkers/text.py:
2536         * Scripts/webkitpy/style_references.py:
2537
2538 2010-08-12  Jon Honeycutt  <jhoneycutt@apple.com>
2539
2540         WebKitTestRunner does not correctly resize WebView for W3C SVG tests
2541         https://bugs.webkit.org/show_bug.cgi?id=43945
2542
2543         Reviewed by Sam Weinig.
2544
2545         * WebKitTestRunner/TestInvocation.cpp:
2546         (WTR::sizeWebViewForCurrentTest):
2547         Allow for a Windows-style path.
2548
2549         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2550         (WTR::PlatformWebView::resizeTo):
2551         Call SetWindowPos to resize the view window.
2552
2553 2010-08-12  David Levin  <levin@chromium.org>
2554
2555         Build break fix.
2556
2557         * WebKitTestRunner/TestController.cpp:
2558         (WTR::TestController::resetStateToConsistentValues): Removed usage
2559         of a variable that doesn't exist in the class.
2560
2561 2010-08-12  Jon Honeycutt  <jhoneycutt@apple.com>
2562
2563         WebKitTestRunner needs to run tests without using native controls
2564         https://bugs.webkit.org/show_bug.cgi?id=43772
2565
2566         Reviewed by Sam Weinig.
2567
2568         * WebKitTestRunner/TestController.cpp:
2569         (WTR::TestController::initialize):
2570         Call platformInitializeContext().
2571
2572         * WebKitTestRunner/TestController.h:
2573         Declare platformInitializeContext().
2574
2575         * WebKitTestRunner/mac/TestControllerMac.mm:
2576         (WTR::TestController::platformInitializeContext):
2577         Stubbed.
2578
2579         * WebKitTestRunner/win/TestControllerWin.cpp:
2580         (WTR::TestController::platformInitializeContext):
2581         Call WKContextSetShouldPaintNativeControls() to disable native control
2582         drawing.
2583
2584 2010-08-12  Sam Weinig  <sam@webkit.org>
2585
2586         Reviewed by Alexey Proskuryakov.
2587
2588         WebKitTestRunner should be more aggressive about ensuring consistent state between tests
2589         https://bugs.webkit.org/show_bug.cgi?id=43653
2590
2591         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2592         (WTR::InjectedBundle::InjectedBundle):
2593         (WTR::InjectedBundle::didReceiveMessage):
2594         (WTR::InjectedBundle::beginTesting):
2595         (WTR::InjectedBundle::done):
2596         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2597         (WTR::InjectedBundle::isTestRunning):
2598         (WTR::InjectedBundle::):
2599         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2600         (WTR::InjectedBundlePage::stopLoading):
2601         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
2602         (WTR::InjectedBundlePage::dump):
2603         (WTR::InjectedBundlePage::didFinishLoadForFrame):
2604         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
2605         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
2606         (WTR::InjectedBundlePage::didClearWindowForFrame):
2607         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
2608         (WTR::InjectedBundlePage::willAddMessageToConsole):
2609         (WTR::InjectedBundlePage::willSetStatusbarText):
2610         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
2611         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
2612         (WTR::InjectedBundlePage::shouldBeginEditing):
2613         (WTR::InjectedBundlePage::shouldEndEditing):
2614         (WTR::InjectedBundlePage::shouldInsertNode):
2615         (WTR::InjectedBundlePage::shouldInsertText):
2616         (WTR::InjectedBundlePage::shouldDeleteRange):
2617         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
2618         (WTR::InjectedBundlePage::shouldApplyStyle):
2619         (WTR::InjectedBundlePage::didBeginEditing):
2620         (WTR::InjectedBundlePage::didEndEditing):
2621         (WTR::InjectedBundlePage::didChange):
2622         (WTR::InjectedBundlePage::didChangeSelection):
2623         Don't do any work if we are not currently running a test.
2624
2625         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2626         * WebKitTestRunner/StringFunctions.h:
2627         (WTR::toCF):
2628         Add conversion function for WKURLRef -> CFURLRef
2629
2630         * WebKitTestRunner/TestController.cpp:
2631         (WTR::TestController::TestController):
2632         (WTR::TestController::initialize):
2633         (WTR::TestController::resetStateToConsistentValues):
2634         (WTR::TestController::runTest):
2635         (WTR::TestController::didFinishLoadForFrame):
2636         * WebKitTestRunner/TestController.h:
2637         (WTR::TestController::):
2638         * WebKitTestRunner/TestInvocation.cpp:
2639         (WTR::TestInvocation::invoke):
2640         * WebKitTestRunner/TestInvocation.h:
2641         Move resetting code to TestController.
2642
2643         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2644         * WebKitTestRunner/mac/TestControllerMac.mm:
2645         (WTR::TestController::runUntil):
2646         * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
2647         * WebKitTestRunner/win/TestControllerWin.cpp:
2648         (WTR::TestController::runUntil):
2649         * WebKitTestRunner/win/TestInvocationWin.cpp: Removed.
2650         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2651         Move runUntil to TestController.
2652
2653 2010-08-12  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2654
2655         Unreviewed.
2656
2657         Adding myself to the committers list.
2658
2659         * Scripts/webkitpy/common/config/committers.py:
2660
2661 2010-08-12  Hayato Ito  <hayato@chromium.org>
2662
2663         Reviewed by Tony Chang.
2664
2665         Merge pretty printers for gdb.
2666         https://bugs.webkit.org/show_bug.cgi?id=43850
2667
2668         We need to update webcore.py because basic string classes have moved to WTF from WebCore.
2669         It is good timing to merge webcore.py and wtf.py and name it 'webkit.py'.
2670         webcore.py is left for backward compatibility.
2671
2672         * gdb/webcore.py:
2673         * gdb/webkit.py: Added.
2674         * gdb/wtf.py: Removed.
2675
2676 2010-08-11  Tony Chang  <tony@chromium.org>
2677
2678         Reviewed by David Levin.
2679
2680         [chromium] add google-chrome layout test result directories
2681         https://bugs.webkit.org/show_bug.cgi?id=43889
2682
2683         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2684         * Scripts/webkitpy/layout_tests/port/factory.py:
2685         * Scripts/webkitpy/layout_tests/port/google_chrome.py: Added.
2686         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2687
2688 2010-08-11  Kent Tamura  <tkent@chromium.org>
2689
2690         Reviewed by Dimitri Glazkov.
2691
2692         [DRT/Chromium] Disable accelerated compositing
2693         https://bugs.webkit.org/show_bug.cgi?id=43894
2694
2695         Disable accelerated compositing because DRT is not ready for
2696         it. This change fixes hundreds of test crashes on Windows and
2697         Linux.
2698
2699         * DumpRenderTree/chromium/TestShell.cpp:
2700         (TestShell::resetWebSettings):
2701
2702 2010-08-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2703
2704         Unreviewed. Adding my Collabora personality to the list.
2705
2706         * Scripts/webkitpy/common/config/committers.py:
2707
2708 2010-08-11  Martin Robinson  <mrobinson@igalia.com>
2709
2710         Adding myself as a reviewer.
2711
2712         * Scripts/webkitpy/common/config/committers.py:
2713
2714 2010-08-11  Daniel Bates  <dbates@rim.com>
2715
2716         Reviewed by Darin Adler.
2717
2718         Perl warnings when running commit-log-editor
2719         https://bugs.webkit.org/show_bug.cgi?id=43856
2720
2721         Fixes Perl warnings introduced by the patch for Bug #40548.
2722
2723         Perl doesn't have symbolic names for True/False. Instead, we
2724         should use boolean values. Moreover, the variable installedEditorApplication
2725         is not be used and should be renamed builtEditorApplication so that it
2726         uses the existing machinery to set the commit log editor application.
2727
2728         * Scripts/commit-log-editor:
2729
2730 2010-08-11  Adam Barth  <abarth@webkit.org>
2731
2732         Reviewed by Eric Seidel.
2733
2734         Trying waiting for httpd lock in the EWS
2735         https://bugs.webkit.org/show_bug.cgi?id=43833
2736
2737         If this works, we can probably run the tests on the mac-ews, which
2738         would be very exciting.  :)
2739
2740         * Scripts/webkitpy/tool/steps/runtests.py:
2741
2742 2010-08-11  Marcus Bulach  <bulach@chromium.org>
2743
2744         Reviewed by Eric Seidel.
2745
2746         Check in a script to list redundant test outputs.
2747         https://bugs.webkit.org/show_bug.cgi?id=37630
2748
2749         If e.g. platform/mac-leopard is missing an expected test output, we
2750         fall back on platform/mac.  This means it's possible to grow redundant
2751         test outputs, where we have the same expected data in both a platform
2752         directory and another platform it falls back on.
2753         (original patch by Evan Marting <evan@chromium.org> https://bugs.webkit.org/attachment.cgi?id=53398)
2754
2755         * Scripts/deduplicate-tests: Added.
2756         * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Added.
2757         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: Added.
2758
2759 2010-08-11  Antonio Gomes  <tonikitoo@webkit.org>
2760
2761         Reviewed by Ariya Hidayat.
2762
2763         [Qt] QtTestBrowser: after switching between QWebView and QGraphicsWebView, rotation actions get broken
2764         https://bugs.webkit.org/show_bug.cgi?id=43853
2765
2766         LauncherWindow::createChrome is connecting menu itens to WebViewGraphicsBased's slots directly.
2767         It behaviors badly when user launches the QtTestBrowser in QWebView mode, since then switching to
2768         QGraphicsWebView mode, createChrome is not called again, and menu items end up not getting connected
2769         to slots at all.
2770
2771         * QtTestBrowser/launcherwindow.cpp:
2772         (LauncherWindow::createChrome):
2773         (LauncherWindow::animatedFlip):
2774         (LauncherWindow::animatedYFlip):
2775         * QtTestBrowser/launcherwindow.h:
2776
2777 2010-08-11  Antonio Gomes  <tonikitoo@webkit.org>
2778
2779         Reviewed by Simon Hausmann.
2780
2781         [Qt] QtTestBrowser: switching between QWebView and QGraphicsWebView modes is broken
2782         https://bugs.webkit.org/show_bug.cgi?id=43851
2783
2784         All window options data (including the bool holding if the view is either QWebView or
2785         QGraphicsWebView based) is stored in m_windowOptions, a class member of LauncherWindow.
2786         When toggle the view from QWebView to QGraphicsWebView based (and vice-versa), we were
2787         not updating LauncherWindow::WindowOptions::m_useGraphicsView bit, and then things were
2788         getting broken.
2789
2790         Patch addresses this issue.
2791
2792         * QtTestBrowser/launcherwindow.cpp:
2793         (LauncherWindow::createChrome):
2794         (LauncherWindow::toggleWebView):
2795         (LauncherWindow::toggleAcceleratedCompositing):
2796
2797 2010-08-10  Antonio Gomes  <tonikitoo@webkit.org>
2798
2799         Reviewed by Ariya Hidayat.
2800
2801         [Qt] QtTestBrowser: lazy instantiate "YRotation" state machine and related objects
2802         https://bugs.webkit.org/show_bug.cgi?id=43831
2803
2804         Only instantiate QStateMachine and friends associated to the YRotation action on demand.
2805
2806         * QtTestBrowser/webview.cpp:
2807         (WebViewGraphicsBased::WebViewGraphicsBased):
2808         (WebViewGraphicsBased::animatedYFlip):
2809
2810 2010-08-11  Darin Adler  <darin@apple.com>
2811
2812         Reviewed by John Sullivan.
2813
2814         Improved editor options for prepare-ChangeLog and commit-log-editor
2815         https://bugs.webkit.org/show_bug.cgi?id=40548
2816
2817         * Scripts/commit-log-editor: Split editor strings on spaces so EDITOR
2818         values like "xed --launch --wait" work properly.
2819
2820         * Scripts/prepare-ChangeLog: Added a new CHANGE_LOG_EDITOR so we can
2821         use a command line tool with the $openChangeLogs feature.
2822
2823 2010-08-11  Yury Semikhatsky  <yurys@chromium.org>
2824
2825         Reviewed by Pavel Feldman.
2826
2827         Web Inspector: remove InjectDispatch.js
2828         https://bugs.webkit.org/show_bug.cgi?id=43835
2829
2830         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2831         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2832
2833 2010-08-10  Dirk Pranke  <dpranke@chromium.org>
2834
2835         Reviewed by Eric Seidel.
2836
2837         webkit-patch should refuse to run under Win32 Python
2838         https://bugs.webkit.org/show_bug.cgi?id=40962
2839
2840         Given that there are lots of places in webkit-patch's code that
2841         assume unix-style filenames (forward slashes), webkit-patch fails
2842         with weird file-not-found errors when run under a native windows
2843         Python. It would be nice if we just trapped this and errored out
2844         at the beginning, rather than producing unpredictable errors.
2845
2846         * Scripts/webkit-patch:
2847
2848 2010-08-10  Kent Tamura  <tkent@chromium.org>
2849
2850         Unreviewed, build fix.
2851         
2852         Chromium build fix for r65107.
2853
2854         * DumpRenderTree/chromium/LayoutTestController.cpp:
2855         (LayoutTestController::suspendAnimations):
2856         (LayoutTestController::resumeAnimations):
2857
2858 2010-08-10  Sergio Villar Senin  <svillar@igalia.com>
2859
2860         Reviewed by Xan Lopez.
2861
2862         [GTK] http/tests/media/video-cookie.html fails
2863         https://bugs.webkit.org/show_bug.cgi?id=42240
2864
2865         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2866         (LayoutTestController::setAlwaysAcceptCookies): create the
2867         SoupCookieJar if it does not exist. Otherwise the accept policy
2868         won't be set.
2869
2870 2010-08-10  Chris Marrin  <cmarrin@apple.com>
2871
2872         Reviewed by Oliver Hunt.
2873
2874         Add suspendAnimations/resumeAnimation API to DRT
2875         https://bugs.webkit.org/show_bug.cgi?id=43733
2876         
2877         Adds suspendAnimations() and resumeAnimations() to LayoutTestController.
2878         Calls functions with the same names on AnimationController for the 
2879         mainFrame.
2880
2881         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2882         * DumpRenderTree/LayoutTestController.cpp:
2883         (suspendAnimationsCallback):
2884         (resumeAnimationsCallback):
2885         (LayoutTestController::staticFunctions):
2886         * DumpRenderTree/LayoutTestController.h:
2887         * DumpRenderTree/chromium/LayoutTestController.cpp:
2888         (LayoutTestController::LayoutTestController):
2889         (LayoutTestController::suspendAnimations):
2890         (LayoutTestController::resumeAnimations):
2891         * DumpRenderTree/chromium/LayoutTestController.h:
2892         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2893         (LayoutTestController::suspendAnimations):
2894         (LayoutTestController::resumeAnimations):
2895         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2896         (LayoutTestController::suspendAnimations):
2897         (LayoutTestController::resumeAnimations):
2898         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2899         (LayoutTestController::suspendAnimations):
2900         (LayoutTestController::resumeAnimations):
2901         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2902         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2903         (LayoutTestController::suspendAnimations):
2904         (LayoutTestController::resumeAnimations):
2905         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2906         (LayoutTestController::suspendAnimations):
2907         (LayoutTestController::resumeAnimations):
2908
2909 2010-08-10  Dimitri Glazkov  <dglazkov@chromium.org>
2910
2911         Reviewed by Ojan Vafai.
2912
2913         [Chromium/DRT] Enable saving layout test results.
2914         https://bugs.webkit.org/show_bug.cgi?id=43796
2915
2916         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added more
2917             parameters to the new-run-webkit-tests, including the name
2918             of the test results server.
2919
2920 2010-08-10  Jian Li  <jianli@chromium.org>
2921
2922         More chromium build fix.
2923
2924         * DumpRenderTree/chromium/MockSpellCheck.cpp:
2925         (MockSpellCheck::spellCheckWord):
2926         (MockSpellCheck::initializeIfNeeded):
2927         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2928         (NotificationPresenter::grantPermission):
2929         (NotificationPresenter::show):
2930         (NotificationPresenter::checkPermission):
2931
2932 2010-08-10  Jian Li  <jianli@chromium.org>
2933
2934         Chromium build fix.
2935
2936         * DumpRenderTree/chromium/MockSpellCheck.cpp:
2937         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2938
2939 2010-08-10  Victor Wang  <victorw@chromium.org>
2940
2941         Reviewed by Ojan Vafai.
2942
2943         Update test results server merge logic so the aggregated
2944         results and times are updated for tests that are
2945         in aggragated json but not in incremental json.
2946
2947         Also update unittest to test this case.
2948
2949         https://bugs.webkit.org/show_bug.cgi?id=43769
2950
2951         * TestResultServer/model/jsonresults.py:
2952         * TestResultServer/model/jsonresults_unittest.py:
2953
2954 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
2955
2956         Reviewed by Ariya Hidayat.
2957
2958         [Qt] QtTestBrowser: proper set scene rect
2959
2960         When resizesToContents is ON scene's rect is set to the boundary of
2961         the mainFrame. However, navigating to other web page should keep resizing
2962         scene's rect according to the new document loaded. Patch addresses this issue.
2963
2964         Now resizesToContents and scrolling properly work on QtTestBrowser.
2965
2966         * QtTestBrowser/webview.cpp:
2967         (WebViewGraphicsBased::setPage):
2968         (WebViewGraphicsBased::contentsSizeChanged):
2969         (WebViewGraphicsBased::setResizesToContents):
2970         (WebViewGraphicsBased::resizeEvent):
2971         * QtTestBrowser/webview.h:
2972
2973 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
2974
2975         Reviewed by Ariya Hidayat.
2976
2977         [Qt] QtTestBrowser: Clean up LauncherWindow code.
2978
2979         * QtTestBrowser/launcherwindow.cpp:
2980         (LauncherWindow::LauncherWindow): Moves applyPrefs methods call from the constructor to init().
2981         (LauncherWindow::init): Fixed comments.
2982         (LauncherWindow::applyPrefs): Move the method around.
2983         (LauncherWindow::createChrome): Move more code of this method around, for grouping, and fixing up comments.
2984
2985 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
2986
2987         Reviewed by Ariya Hidayat.
2988
2989         [Qt] QtTestBrowser: make reset-zooming to animate when tiled backing store is on.
2990
2991         It gets control+0 the same visual effect as control++ or control-.
2992
2993         * QtTestBrowser/launcherwindow.cpp:
2994         (LauncherWindow::toggleZoomTextOnly):
2995
2996 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
2997
2998         Reviewed by Ariya Hidayat.
2999
3000         [Qt] QtTestBrowser:: make m_zoomLevels a static member.
3001
3002         Not all instances of LauncherWindow need its own m_zoomLevel.
3003
3004         * QtTestBrowser/launcherwindow.cpp:
3005         * QtTestBrowser/launcherwindow.h:
3006
3007 2010-08-09  Sam Weinig  <sam@webkit.org>
3008
3009         Reviewed by Geoffrey Garen.
3010
3011         Add zoom support for injected bundle
3012         https://bugs.webkit.org/show_bug.cgi?id=43759
3013
3014         Use zoom factor SPI to implement zoom related eventSender functions.
3015
3016         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3017         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3018         (WTR::EventSendingController::textZoomIn):
3019         (WTR::EventSendingController::textZoomOut):
3020         (WTR::EventSendingController::zoomPageIn):
3021         (WTR::EventSendingController::zoomPageOut):
3022         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3023         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3024         (WTR::InjectedBundlePage::reset): Reset zoom mode and level for each test.
3025
3026 2010-08-09  Gavin Barraclough  <barraclough@apple.com>
3027
3028         Speculative chromium build fix III.
3029
3030         * DumpRenderTree/chromium/MockSpellCheck.h:
3031         * DumpRenderTree/chromium/NotificationPresenter.h:
3032         * DumpRenderTree/chromium/WebViewHost.h:
3033         (WebViewHost::addClearHeader):
3034         (WebViewHost::clearHeaders):
3035
3036 2010-08-09  Ojan Vafai  <ojan@chromium.org>
3037
3038         Reviewed by Tony Chang.
3039
3040         increase the number of test results that we save
3041         https://bugs.webkit.org/show_bug.cgi?id=43763
3042
3043         Now that we do incremental uploads, we can increase the number of
3044         results that we save for http://test-results.appspot.com/dashboards/flakiness_dashboard.html.
3045
3046         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3047
3048 2010-08-09  Evan Martin  <evan@chromium.org>
3049
3050         Reviewed by Tony Chang.
3051
3052         [chromium] DRT error print statement incorrectly tries to print a FILE*
3053         https://bugs.webkit.org/show_bug.cgi?id=43747
3054
3055         * DumpRenderTree/chromium/ImageDiff.cpp:
3056         (writeFile): pass the correct pointer.
3057
3058 2010-08-09  Victor Wang  <victorw@chromium.org>
3059
3060         Reviewed by Ojan Vafai.
3061
3062         Upload incremental test results json to server by default.
3063
3064         https://bugs.webkit.org/show_bug.cgi?id=43743
3065
3066         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3067
3068 2010-08-09  Eric Seidel  <eric@webkit.org>
3069
3070         Reviewed by Adam Barth.
3071
3072         EWS bots wait 2 minutes between patches
3073         https://bugs.webkit.org/show_bug.cgi?id=43731
3074
3075         * Scripts/webkitpy/tool/bot/queueengine.py:
3076          - Don't sleep after failures.  This was a hold-over from
3077            an earlier design.
3078         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3079          - EWS bots were not properly reporting true/false from process_work_item.
3080            They were always returning None, thus false, thus always logging
3081            as a failure and sleeping 2 minutes after each patch.
3082
3083 2010-08-09  Sam Weinig  <sam@webkit.org>
3084
3085         Reviewed by Anders Carlsson.
3086
3087         Stub out EventSender for WebKitTestRunner
3088         https://bugs.webkit.org/show_bug.cgi?id=43703
3089
3090         * WebKitTestRunner/DerivedSources.make:
3091         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3092         Add ability to pass javascript arguments to the wrapped object.
3093
3094         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added.
3095         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: Added.
3096         (WTR::EventSendingController::create):
3097         (WTR::EventSendingController::EventSendingController):
3098         (WTR::EventSendingController::~EventSendingController):
3099         (WTR::EventSendingController::wrapperClass):
3100         (WTR::setExceptionForString):
3101         (WTR::EventSendingController::mouseDown):
3102         (WTR::EventSendingController::mouseUp):
3103         (WTR::EventSendingController::mouseMoveTo):
3104         (WTR::EventSendingController::keyDown):
3105         (WTR::EventSendingController::contextClick):
3106         (WTR::EventSendingController::leapForward):
3107         (WTR::EventSendingController::textZoomIn):
3108         (WTR::EventSendingController::textZoomOut):
3109         (WTR::EventSendingController::zoomPageIn):
3110         (WTR::EventSendingController::zoomPageOut):
3111         (WTR::EventSendingController::makeWindowObject):
3112         * WebKitTestRunner/InjectedBundle/EventSendingController.h: Added.
3113         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3114         (WTR::InjectedBundle::reset):
3115         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3116         (WTR::InjectedBundle::eventSendingController):
3117         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3118         (WTR::InjectedBundlePage::didClearWindowForFrame):
3119         Add stubbed out EventSenderController.
3120
3121         * WebKitTestRunner/InjectedBundle/GCController.h:
3122         Remove incorrect comment.
3123
3124         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3125         * WebKitTestRunner/win/InjectedBundle.vcproj:
3126         Add new files.
3127
3128 2010-08-08  Kent Tamura  <tkent@chromium.org>
3129
3130         Unreviewed, trivial fix.
3131
3132         Fix "WindowsError: [Error 32] The process cannot access the file
3133         because it is being used by another process" introduced by r64959.
3134
3135         * BuildSlaveSupport/test-result-archive:
3136
3137 2010-08-08  Kent Tamura  <tkent@chromium.org>
3138
3139         Reviewed by Tony Chang.
3140
3141         Chromium buildbot: Avoid "zip" command dependency
3142         https://bugs.webkit.org/show_bug.cgi?id=43470
3143
3144         * BuildSlaveSupport/test-result-archive:
3145          For Chromium port, creates a zip archive with zipfile package of Python
3146          instead of external "zip" command. We'd like to avoid additional
3147          command installation.
3148
3149 2010-08-08  Jon Honeycutt  <jhoneycutt@apple.com>
3150
3151         WebKitTestRunner should add the QuickTime dir to the PATH environment
3152         variable
3153         https://bugs.webkit.org/show_bug.cgi?id=43686
3154
3155         Reviewed by Dan Bernstein.
3156
3157         * WebKitTestRunner/win/TestControllerWin.cpp:
3158         (WTR::addQTDirToPATH):
3159         Copied from DRT.
3160         (WTR::TestController::platformInitialize):
3161         Call addQTDirToPath().
3162         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3163         Link to shlwapi.lib for SHGetValue.
3164
3165 2010-08-07  Sam Weinig  <sam@webkit.org>
3166
3167         Reviewed by Maciej Stachowiak.
3168
3169         WebKitTestRunner needs layoutTestController.dumpTitleChanges
3170         <rdar://problem/8213861>
3171         https://bugs.webkit.org/show_bug.cgi?id=42683
3172
3173         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3174         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3175         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
3176         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
3177         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3178         (WTR::LayoutTestController::LayoutTestController):
3179         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3180         (WTR::LayoutTestController::dumpTitleChanges):
3181         (WTR::LayoutTestController::shouldDumpTitleChanges):
3182
3183 2010-08-07  Sam Weinig  <sam@webkit.org>
3184
3185         Reviewed by Anders Carlsson.
3186
3187         WebKitTestRunner needs to print onunload handler information
3188         <rdar://problem/8213831>
3189         https://bugs.webkit.org/show_bug.cgi?id=42703
3190
3191         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3192         (WTR::operator<<):
3193         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
3194
3195 2010-08-07  Sam Weinig  <sam@webkit.org>
3196
3197         Reviewed by Anders Carlsson.
3198
3199         Add additional loader client functions need to complete WebKitTestRunner
3200         https://bugs.webkit.org/show_bug.cgi?id=43684
3201
3202         Remove unnecessary and jarring underscores as well.
3203
3204         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3205         (didClearWindowObjectForFrame):
3206         (didCreatePage):
3207         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3208         (WTR::InjectedBundlePage::InjectedBundlePage):
3209         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
3210         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
3211         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
3212         (WTR::InjectedBundlePage::didCommitLoadForFrame):
3213         (WTR::InjectedBundlePage::didFinishLoadForFrame):
3214         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
3215         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
3216         (WTR::InjectedBundlePage::didClearWindowForFrame):
3217         (WTR::InjectedBundlePage::didCancelClientRedirectForFrame):
3218         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
3219         (WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
3220         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
3221         (WTR::InjectedBundlePage::didHandleOnloadEventsForFrame):
3222         (WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
3223         (WTR::InjectedBundlePage::didRunInsecureContentForFrame):
3224         (WTR::InjectedBundlePage::willAddMessageToConsole):
3225         (WTR::InjectedBundlePage::willSetStatusbarText):
3226         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
3227         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
3228         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
3229         (WTR::InjectedBundlePage::shouldBeginEditing):
3230         (WTR::InjectedBundlePage::shouldEndEditing):
3231         (WTR::InjectedBundlePage::shouldInsertNode):
3232         (WTR::InjectedBundlePage::shouldInsertText):
3233         (WTR::InjectedBundlePage::shouldDeleteRange):
3234         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
3235         (WTR::InjectedBundlePage::shouldApplyStyle):
3236         (WTR::InjectedBundlePage::didBeginEditing):
3237         (WTR::InjectedBundlePage::didEndEditing):
3238         (WTR::InjectedBundlePage::didChange):
3239         (WTR::InjectedBundlePage::didChangeSelection):
3240         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3241
3242 2010-08-07  Dan Bernstein  <mitz@apple.com>
3243
3244         Build fix.
3245
3246         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Made the references
3247         to JSGCController.{cpp,h} relative to the build root.
3248
3249 2010-08-07  Sam Weinig  <sam@webkit.org>
3250
3251         Reviewed by Anders Carlsson.
3252
3253         WebKitTestRunner needs GCController
3254         <rdar://problem/8213834>
3255         https://bugs.webkit.org/show_bug.cgi?id=42701
3256
3257         * WebKitTestRunner/DerivedSources.make:
3258         * WebKitTestRunner/InjectedBundle/Bindings/GCController.idl: Added.
3259         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h:
3260         (WTR::setProperty):
3261         * WebKitTestRunner/InjectedBundle/GCController.cpp: Added.
3262         (WTR::GCController::create):
3263         (WTR::GCController::GCController):
3264         (WTR::GCController::~GCController):
3265         (WTR::GCController::wrapperClass):
3266         (WTR::GCController::collect):
3267         (WTR::GCController::collectOnAlternateThread):
3268         (WTR::GCController::getJSObjectCount):
3269         (WTR::GCController::makeWindowObject):
3270         * WebKitTestRunner/InjectedBundle/GCController.h: Added.
3271         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3272         (WTR::InjectedBundle::reset):
3273         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3274         (WTR::InjectedBundle::bundle):
3275         (WTR::InjectedBundle::gcController):
3276         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3277         (WTR::InjectedBundlePage::didClearWindowForFrame):
3278         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3279         (WTR::LayoutTestController::keepWebHistory):
3280         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3281         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3282         * WebKitTestRunner/win/InjectedBundle.vcproj:
3283
3284 2010-08-05  Jon Honeycutt  <jhoneycutt@apple.com>
3285
3286         WebKitTestRunner needs to be able to set the font smoothing type
3287         https://bugs.webkit.org/show_bug.cgi?id=43406
3288
3289         Reviewed by Adam Roben.
3290
3291         * WebKitTestRunner/TestInvocation.cpp:
3292         (WTR::TestInvocation::resetPreferencesToConsistentValues):
3293         Set the font smoothing level to
3294         kWKFontSmoothingLevelNoSubpixelAntiAliasing to match DRT.
3295
3296 2010-08-06  Jon Honeycutt  <jhoneycutt@apple.com>
3297
3298         Fix a missed variable rename.
3299
3300         Unreviewed.
3301
3302         * Scripts/old-run-webkit-tests:
3303
3304 2010-08-06  Jon Honeycutt  <jhoneycutt@apple.com>
3305
3306         mac-wk2/Skipped should be used on Windows when running regression tests
3307         https://bugs.webkit.org/show_bug.cgi?id=43494
3308
3309         Reviewed by Adam Roben.
3310
3311         * Scripts/old-run-webkit-tests:
3312         If the platform is win-wk2, also read the mac-wk2 skipped list.
3313
3314 2010-08-06  Kent Tamura  <tkent@chromium.org>
3315
3316         Reviewed by Dimitri Glazkov.
3317
3318         [DRT/Chromium] Should revoke scheduled tasks
3319         https://bugs.webkit.org/show_bug.cgi?id=43560
3320
3321         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
3322         (DRTDevToolsAgent::reset): Calls RevokeAll().
3323         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3324         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
3325         (DRTDevToolsClient::reset): Calls RevokeAll().
3326         * DumpRenderTree/chromium/DRTDevToolsClient.h:
3327         * DumpRenderTree/chromium/EventSender.cpp:
3328         (EventSender::reset): Calls RevokeAll().
3329         * DumpRenderTree/chromium/LayoutTestController.cpp:
3330         (LayoutTestController::reset): Calls RevokeAll().
3331         * DumpRenderTree/chromium/TestShell.cpp:
3332         (TestShell::resetTestController): Calls DRTDevToolsAgent::reset() and DRTDevToolsClient::reset().
3333
3334 2010-08-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3335
3336         Reviewed by Antonio Gomes.
3337
3338         [Qt] Fix the DRT build on Mac OS X
3339
3340         * DumpRenderTree/qt/DumpRenderTree.pro:
3341
3342 2010-08-06  Jochen Eisinger  <jochen@chromium.org>
3343
3344         Reviewed by Pavel Feldman.
3345
3346         Rietvield's upload.py moved to a different location.
3347         https://bugs.webkit.org/show_bug.cgi?id=43613
3348
3349         * Scripts/webkitpy/thirdparty/__init__.py:
3350
3351 2010-05-23  Eric Seidel  <eric@webkit.org>
3352
3353         Reviewed by Adam Barth.
3354
3355         QueueStatusServer needs better queue-status pages
3356         https://bugs.webkit.org/show_bug.cgi?id=39562
3357
3358         The primary goal of this patch is to display queue
3359         positions somewhere on the site so that it's easier
3360         for commit-queue users to know when their pach will
3361         be landed.  I also tried to improve the root page
3362         to be more useful than the previous wall of status text.
3363
3364         * QueueStatusServer/handlers/recentstatus.py:
3365         * QueueStatusServer/main.py:
3366         * QueueStatusServer/model/queues.py:
3367         * QueueStatusServer/templates/recentstatus.html:
3368
3369 2010-08-05  Victor Wang  <victorw@chromium.org>
3370
3371         Reviewed by Ojan Vafai.
3372
3373         Add option to generate/upload incremental json results to test result server.
3374         Also refactor the json results generator unittest code to test
3375         incremental and aggregated json results.
3376
3377         https://bugs.webkit.org/show_bug.cgi?id=43519
3378
3379         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3380         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3381         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3382         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3383
3384 2010-08-05  Jian Li  <jianli@chromium.org>
3385
3386         Reviewed by David Levin.
3387
3388         Unify blob related feature defines to ENABLE(BLOB).
3389         https://bugs.webkit.org/show_bug.cgi?id=43081
3390
3391         * Scripts/build-webkit:
3392
3393 2010-08-05  Satish Sampath  <satish@chromium.org>
3394
3395         Reviewed by Jeremy Orlow.
3396
3397         Add speech input controller mock in WebKit and a layout test.
3398         https://bugs.webkit.org/show_bug.cgi?id=43477
3399
3400         Added LayoutTestController::setMockSpeechInputResultCallback method.
3401
3402         * DumpRenderTree/LayoutTestController.cpp:
3403         (setMockSpeechInputResultCallback): Wrapper invoking the member function.
3404         (LayoutTestController::staticFunctions):
3405         * DumpRenderTree/LayoutTestController.h:
3406         * DumpRenderTree/chromium/LayoutTestController.cpp:
3407         (LayoutTestController::LayoutTestController):
3408         (LayoutTestController::setMockSpeechInputResult): Sets the mock result.
3409         (LayoutTestController::speechInputController): Creates the mock controller.
3410         * DumpRenderTree/chromium/LayoutTestController.h:
3411         * DumpRenderTree/chromium/WebViewHost.cpp:
3412         (WebViewHost::speechInputController): Creates the mock controller.
3413         * DumpRenderTree/chromium/WebViewHost.h:
3414         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3415         (LayoutTestController::setMockSpeechInputResult): dummy method.
3416         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3417         (LayoutTestController::setMockSpeechInputResult): dummy method.
3418         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3419         (LayoutTestController::setMockSpeechInputResult): dummy method.
3420         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3421         * DumpRenderTree/win/LayoutTestControllerWin.cpp: dummy method.
3422         (LayoutTestController::setMockSpeechInputResult):
3423         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: dummy method.
3424         (LayoutTestController::setMockSpeechInputResult):
3425
3426 2010-08-04  Adam Roben  <aroben@apple.com>
3427
3428         Fix the path to TestNetscapePlugin's directory on Windows
3429
3430         Fixes <http://webkit.org/b/43513> WebKitTestRunner on Windows fails to
3431         load TestNetscapePlugin
3432
3433         Reviewed by Jon Honeycutt.
3434
3435         * WebKitTestRunner/win/TestControllerWin.cpp:
3436         (WTR::TestController::initializeTestPluginDirectory):
3437         TestNetscapePlugin is in a TestNetscapePlugin[_Debug] directory that's
3438         next to WebKitTestRunner.exe. Previously we were passing the directory
3439         that contains WebKitTestRunner.exe. Also fixed some leaks.
3440
3441 2010-08-05  Kenichi Ishibashi  <bashi@google.com>
3442
3443         Reviewed by Shinichiro Hamaji.
3444
3445         check-webkit-style returns non-zero when patch is entirely minus lines.
3446         https://bugs.webkit.org/show_bug.cgi?id=38169
3447
3448         * Scripts/check-webkit-style:
3449         Check whether a patch contains modified files that are entirely minus lines.
3450         * Scripts/webkitpy/style/filereader.py:
3451         Add a variable that holds number of files that contain only deleted lines.
3452         * Scripts/webkitpy/style/patchreader.py:
3453         Count up modified files that contain only deleted lines.
3454
3455 2010-08-05  Pavel Feldman  <pfeldman@chromium.org>
3456
3457         Reviewed by Yury Semikhatsky.
3458
3459         DevTools: get rid of delayed command dispatching on front-end side.
3460
3461         https://bugs.webkit.org/show_bug.cgi?id=43479
3462
3463         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
3464         (DRTDevToolsAgent::detach):
3465         (DRTDevToolsAgent::frontendLoaded):
3466         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3467         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
3468         (DRTDevToolsClient::~DRTDevToolsClient):
3469         (DRTDevToolsClient::sendFrontendLoaded):
3470         * DumpRenderTree/chromium/DRTDevToolsClient.h:
3471
3472 2010-08-04  Kenichi Ishibashi  <bashi@google.com>
3473
3474         Reviewed by Shinichiro Hamaji.
3475
3476         Fixes check-webkit-style false positive on "new uint32_t."
3477         https://bugs.webkit.org/show_bug.cgi?id=43077
3478
3479         * Scripts/webkitpy/style/checkers/cpp.py:
3480         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3481
3482 2010-08-04  Kent Tamura  <tkent@chromium.org>
3483
3484         Reviewed by Dimitri Glazkov.
3485
3486         [DRT/Chromium] Remove base/linked_ptr.h dependency
3487         https://bugs.webkit.org/show_bug.cgi?id=43472
3488
3489         Replace linked_ptr<TestNavigationEntry> with RefPtr<TestNavigationEntry>.
3490         We need to use RefPtr<> because m_pendingEntry points an object in
3491         m_entries or not in m_entries.
3492
3493         * DumpRenderTree/chromium/TestNavigationController.cpp:
3494         (TestNavigationEntry::create): Added.
3495         (TestNavigationController::activeEntry):
3496         (TestNavigationController::didNavigateToEntry):
3497         (TestNavigationController::discardPendingEntry):
3498         (TestNavigationController::insertEntry):
3499         (TestNavigationController::navigateToPendingEntry):
3500         * DumpRenderTree/chromium/TestNavigationController.h:
3501         * DumpRenderTree/chromium/WebViewHost.cpp:
3502         (WebViewHost::loadURLForFrame):
3503          Use TestNavigationEntry::create().
3504         (WebViewHost::updateURL):
3505          Use RefPtr<>.
3506         (WebViewHost::updateSessionHistory):
3507          Remove unnecessary static_cast<>.
3508
3509 2010-08-04  Kent Tamura  <tkent@chromium.org>
3510
3511         Reviewed by Dimitri Glazkov.
3512
3513         Fix a problem that "archived test results" step doesn't work on Chromium buildbots
3514         https://bugs.webkit.org/show_bug.cgi?id=43333
3515
3516         * BuildSlaveSupport/test-result-archive:
3517           - Make layoutTestResultsDir local and pass it to archiveTestResults()
3518           - Adjust layoutTestResultsDir for Chromium
3519
3520 2010-08-04  Kent Tamura  <tkent@chromium.org>
3521
3522         Reviewed by Dimitri Glazkov.
3523
3524         NRWT: websocket_server startup detection failure
3525         https://bugs.webkit.org/show_bug.cgi?id=43466
3526
3527         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
3528          Increase timeout value: 5 second -> 10 second
3529
3530 2010-08-04  Victor Wang  <victorw@chromium.org>
3531
3532         Reviewed by Ojan Vafai.
3533
3534         -. Add result.json incremental merging functionality to test results app engine.
3535         -. blobstore is not suitable for AE data merging and there is no API to
3536            programatically edit existing blob or write a new one yet, so replace blobstore
3537            with datastore. If file is oversize (>1000*1000 bytes), store file data in
3538            multiple datastore entries.
3539         -. Fix styles.
3540
3541         Test: jsonresults_unittest to test merging logics.
3542
3543         https://bugs.webkit.org/show_bug.cgi?id=38599
3544
3545         * TestResultServer/handlers/dashboardhandler.py:
3546         * TestResultServer/handlers/menu.py:
3547         * TestResultServer/handlers/testfilehandler.py:
3548         * TestResultServer/main.py:
3549         * TestResultServer/model/dashboardfile.py:
3550         * TestResultServer/model/datastorefile.py: Added.
3551         * TestResultServer/model/jsonresults.py: Added.
3552         * TestResultServer/model/jsonresults_unittest.py: Added.
3553         * TestResultServer/model/testfile.py:
3554         * TestResultServer/templates/uploadform.html:
3555
3556 2010-08-04  Antonio Gomes  <tonikitoo@webkit.org>
3557
3558         Reviewed by Kenneth Christiansen.
3559
3560         [Qt] [QtTestBrowser] Remove unneeded QAction class members
3561         https://bugs.webkit.org/show_bug.cgi?id=43518
3562
3563         LauncherWindow class has two totally unneeded class members: m_flopAnimated and
3564         m_flipYAnimated. Also, in initializeView method there are some dead code block
3565         trying to connect them at the wrong time, when they have not been instanciated.
3566
3567         This patch:
3568
3569         - removes the two cited class members in favor of local variables in createChrome method;
3570         - removes the dead code block.
3571
3572         * QtTestBrowser/launcherwindow.cpp:
3573         (LauncherWindow::LauncherWindow):
3574         (LauncherWindow::initializeView):
3575         (LauncherWindow::createChrome):
3576         * QtTestBrowser/launcherwindow.h:
3577
3578 2010-08-04  Antonio Gomes  <tonikitoo@webkit.org>
3579
3580         Reviewed by Simon Hausmann and Kenneth Christiansen.