WebKitTools/ChangeLog

   1 2010-10-07  Sheriff Bot  <webkit.review.bot@gmail.com>
   2
   3         Unreviewed, rolling out r69315.
   4         http://trac.webkit.org/changeset/69315
   5         https://bugs.webkit.org/show_bug.cgi?id=47363
   6
   7         Forgot to add the new files (Requested by kbalazs on #webkit).
   8
   9         * Scripts/webkitdirs.pm:
  10         * WebKitTestRunner/qt/DerivedSources.pro: Added.
  11
  12 2010-10-07  Sam Weinig  <sam@webkit.org>
  13
  14         Reviewed by Anders Carlsson.
  15
  16         Change API tester to ask the executable for the list of all
  17         tests instead of relying on the directory structure.
  18         https://bugs.webkit.org/show_bug.cgi?id=47359
  19
  20         * Scripts/run-test-webkit-api: Added.
  21         * Scripts/webkitdirs.pm:
  22         Add additional script to just launch the api tester with the correct settings.
  23
  24         * Scripts/run-api-tests:
  25         Change to use the new --dump-tests options to build the list of tests and change
  26         output to reflect a (suite, testcase) tuple for each test. Also adds some color.
  27
  28         * TestWebKitAPI/Test.h:
  29         (TestWebKitAPI::Test::Register::Register):
  30         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
  31         (TestWebKitAPI::TEST):
  32         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
  33         (TestWebKitAPI::TEST):
  34         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
  35         (TestWebKitAPI::TEST):
  36         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
  37         (TestWebKitAPI::TEST):
  38         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
  39         (TestWebKitAPI::TEST):
  40         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
  41         (TestWebKitAPI::TEST):
  42         Give each test a suite name in addition to the test name.
  43
  44         * TestWebKitAPI/TestsController.cpp:
  45         (TestWebKitAPI::TestsController::dumpTestNames):
  46         (TestWebKitAPI::TestsController::runTestNamed):
  47         * TestWebKitAPI/TestsController.h:
  48         * TestWebKitAPI/mac/main.mm:
  49         (main):
  50         Add option to print all registered tests.
  51
  52 2010-10-07  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>, Andras Becsi  <abecsi@webkit.org>, Balazs Kelemen  <kbalazs@webkit.org>
  53
  54         Reviewed by Kenneth Rohde Christiansen.
  55
  56         [Qt] Add WTR's InjectedBundle build files.
  57         https://bugs.webkit.org/show_bug.cgi?id=47333
  58
  59         * Scripts/webkitdirs.pm:
  60         * WebKitTestRunner/DerivedSources.pro: Added.
  61         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Added.
  62         * WebKitTestRunner/WebKitTestRunner.pro: Added.
  63         * WebKitTestRunner/qt/DerivedSources.pro: Removed.
  64         Content merged in ../DerivedSources.pro
  65
  66 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
  67
  68         Unreviewed. Do a renaming that was recommended by the reviewer
  69         (Kenneth) but I forgot to do before landing (http://trac.webkit.org/changeset/69253)
  70
  71         * WebKitTestRunner/qt/TestControllerQt.cpp:
  72         (WTR::RunUntilConditionLoop::start):
  73         (WTR::RunUntilConditionLoop::RunUntilConditionLoop):
  74         (WTR::TestController::runUntil):
  75
  76 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
  77
  78         Reviewed by Kenneth Rohde Christiansen.
  79
  80         [Qt] Watchdog timer implementation for WTR
  81         https://bugs.webkit.org/show_bug.cgi?id=47337
  82
  83         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Factor out
  84         the definition of the timer type to a typedef.
  85         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp: Added.
  86         Timer implementation with QTimer and a helper QObject class.
  87         (WTR::WatchdogTimerHelper::instance):
  88         (WTR::WatchdogTimerHelper::timerFired):
  89         (WTR::WatchdogTimerHelper::WatchdogTimerHelper):
  90         (WTR::LayoutTestController::platformInitialize):
  91         (WTR::LayoutTestController::invalidateWaitToDumpWatchdogTimer):
  92         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
  93
  94 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
  95
  96         Unreviewed buildfix for 69297 again
  97
  98         * WebKitTestRunner/TestController.cpp:
  99         (WTR::blankURL):
 100
 101 2010-10-07  Balazs Kelemen  <Balazs Kelemen>
 102
 103         Unreviewed trivial build fix for r69297
 104
 105         * WebKitTestRunner/TestController.cpp:
 106         (WTR::blankURL):
 107
 108 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
 109
 110         Reviewed by Kenneth Rohde Christiansen.
 111
 112         WebKitTestRunner should be portable
 113         https://bugs.webkit.org/show_bug.cgi?id=45393
 114
 115         Use only the WebKit API for working with urls.
 116         * WebKitTestRunner/StringFunctions.h:
 117         (WTR::createWKURL):
 118         * WebKitTestRunner/TestController.cpp:
 119         (WTR::blankURL):
 120         (WTR::TestController::resetStateToConsistentValues):
 121         (WTR::TestController::didFinishLoadForFrame):
 122
 123 2010-10-07  Carlos Garcia Campos  <cgarcia@igalia.com>
 124
 125         Reviewed by Xan Lopez.
 126
 127         [GTK] Use gtk_widget_draw() instead of gtk_widget_get_snapshot() in PixelDumpSupportGtk when building with gtk3
 128         https://bugs.webkit.org/show_bug.cgi?id=47332
 129
 130         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
 131         (createBitmapContextFromWebView):
 132
 133 2010-10-06  Chris Guillory  <chris.guillory@google.com>
 134
 135         Reviewed by Chris Fleizach.
 136
 137         Remove unused accessibility functions from webkit.
 138         https://bugs.webkit.org/attachment.cgi?bugid=46707
 139
 140         * DumpRenderTree/chromium/WebViewHost.cpp:
 141         (WebViewHost::postAccessibilityNotification):
 142         * DumpRenderTree/chromium/WebViewHost.h:
 143
 144 2010-10-06  Lucas Forschler  <lforschler@apple.com>
 145
 146         Reviewed by Adam Roben.
 147
 148         Fix the sunspider-compare-results to actually use the passed in value for $root.
 149
 150         * Scripts/sunspider-compare-results:
 151
 152 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
 153
 154         Reviewed by Kenneth Rohde Christiansen.
 155
 156         [Qt] Runloop implementation for WTR
 157         https://bugs.webkit.org/show_bug.cgi?id=47280
 158
 159         * WebKitTestRunner/qt/TestControllerQt.cpp:
 160         Implemented TestController::runUntil by a timerEvent
 161         and a QEventLoop. We step into the event loop from runUntil.
 162         While we are waiting in the loop a timerEvent is periodically
 163         checking the value of the condition. Once the condition has
 164         becoming true the timerEvent wakes us up.
 165         (WTR::RunUntilLoop::start):
 166         (WTR::RunUntilLoop::RunUntilLoop):
 167         (WTR::RunUntilLoop::run):
 168         (WTR::RunUntilLoop::timerEvent):
 169         (WTR::TestController::platformInitialize):
 170         (WTR::TestController::runUntil):
 171         * WebKitTestRunner/qt/main.cpp:
 172         Start the main event loop first and creating the TestController later.
 173         (Launcher::Launcher):
 174         (Launcher::~Launcher):
 175         (Launcher::launch): Creating the TestController.
 176         (main): Setting up a timer for calling Launcher::launch from
 177         the main event loop.
 178
 179 2010-10-06  Dirk Pranke  <dpranke@chromium.org>
 180
 181         Reviewed by Kenneth Russell.
 182
 183         new-run-webkit-tests: fix typo in chromium-gpu that was trying to
 184         enable 'accelerated-composting' instead of 'accelerated-compositing'.
 185
 186         https://bugs.webkit.org/show_bug.cgi?id=47312
 187
 188         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
 189         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
 190
 191 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
 192
 193         Reviewed by Kenneth Rohde Christiansen.
 194
 195         [Qt] PlatformWebView implementation for WebKitTestRunner
 196         https://bugs.webkit.org/show_bug.cgi?id=47276
 197
 198         The implementation follows the way how
 199         we use the API in MiniBrowser.
 200         * WebKitTestRunner/PlatformWebView.h:
 201         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
 202         (WTR::WebView::wkView):
 203         (WTR::WebView::~WebView):
 204         (WTR::WebView::WebView):
 205         (WTR::PlatformWebView::PlatformWebView):
 206         (WTR::PlatformWebView::~PlatformWebView):
 207         (WTR::PlatformWebView::resizeTo):
 208         (WTR::PlatformWebView::page):
 209         (WTR::PlatformWebView::focus):
 210         * WebKitTestRunner/qt/WebKitTestRunner.pro:
 211
 212 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
 213
 214         Reviewed by Kenneth Rohde Christiansen.
 215
 216         [Qt] Add WebKitTestRunner's build files
 217         https://bugs.webkit.org/show_bug.cgi?id=44155
 218
 219         Parts was taken by Zoltan Horvath's patch.
 220
 221         * Scripts/generate-forwarding-headers.pl: Moved from WebKit2.
 222         * Scripts/webkitdirs.pm: Make the generated files needed by WTR.
 223         * WebKitTestRunner/PlatformWebView.h: Addeed typedefs for
 224         PlatformWKView and PlatformWindow (void* for now).
 225         Buildfix the case when __APPLE__ is not defined.
 226         * WebKitTestRunner/qt/DerivedSources.pro: Added.
 227         * WebKitTestRunner/qt/PlatformWebViewQt.cpp: Added.
 228         Empty stub implementation.
 229         (WTR::registerWindowClass):
 230         (WTR::PlatformWebView::PlatformWebView):
 231         (WTR::PlatformWebView::~PlatformWebView):
 232         (WTR::PlatformWebView::resizeTo):
 233         (WTR::PlatformWebView::page):
 234         (WTR::PlatformWebView::focus):
 235         * WebKitTestRunner/qt/TestControllerQt.cpp: Added.
 236         Empty stub implementation.
 237         (WTR::registerWindowClass):
 238         (WTR::TestController::runUntil):
 239         (WTR::TestController::platformInitialize):
 240         (WTR::TestController::initializeInjectedBundlePath):
 241         (WTR::TestController::initializeTestPluginDirectory):
 242         (WTR::TestController::platformInitializeContext):
 243         * WebKitTestRunner/qt/WebKitTestRunner.pro: Added.
 244         * WebKitTestRunner/qt/main.cpp: Added.
 245         (main):
 246
 247 2010-10-06  Tony Chang  <tony@chromium.org>
 248
 249         Unreviewed, rolling out r69202.
 250         http://trac.webkit.org/changeset/69202
 251         https://bugs.webkit.org/show_bug.cgi?id=46937
 252
 253         Broke compile of test_shell
 254
 255         * DumpRenderTree/chromium/EventSender.cpp:
 256         (EventSender::beginDragWithFiles):
 257         * DumpRenderTree/chromium/WebViewHost.cpp:
 258         (addDRTFakeFileToDataObject):
 259
 260 2010-10-06  Daniel Cheng  <dcheng@chromium.org>
 261
 262         Reviewed by Tony Chang.
 263
 264         [chromium] Minor naming cleanup in WebDragData, part 2
 265         https://bugs.webkit.org/show_bug.cgi?id=46937
 266
 267         Update DRT to use the renamed methods.
 268
 269         * DumpRenderTree/chromium/EventSender.cpp:
 270         (EventSender::beginDragWithFiles):
 271         * DumpRenderTree/chromium/WebViewHost.cpp:
 272         (addDRTFakeFileToDataObject):
 273
 274 2010-10-06  David Kilzer  <ddkilzer@apple.com>
 275
 276         <http://webkit.org/b/47270> Move WebArchive serialization code into its own file
 277
 278         Reviewed by Adam Roben.
 279
 280         This is the first step in making webarchive tests work on
 281         Windows.
 282
 283         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added
 284         new files to the project.
 285         * DumpRenderTree/mac/DumpRenderTree.mm: Removed code that moved
 286         to WebArchiveDumpSupport.mm.
 287         * DumpRenderTree/mac/WebArchiveDumpSupport.h: Added.
 288         * DumpRenderTree/mac/WebArchiveDumpSupport.mm: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm.
 289         (serializeWebArchiveToXML):
 290
 291 2010-10-05  Daniel Bates  <dbates@rim.com>
 292
 293         Reviewed by David Kilzer.
 294
 295         Add infrastructure to towards detecting change log diffs that aren't at the top of the ChangeLog
 296         https://bugs.webkit.org/show_bug.cgi?id=46058
 297
 298         Make VCSUtils::fixChangeLogPatch() return a reference to a hash
 299         structure so as to support returning additional information
 300         about a change log diff.
 301
 302         Currently, VCSUtils::fixChangeLogPatch() returns a string that
 303         represents the change log diff. Towards supporting the return
 304         of additional information, such as whether the change log diff
 305         inserts an entry at the top of the ChangeLog file, we need to
 306         make VCSUtils::fixChangeLogPatch() return a reference to hash
 307         structure.
 308
 309         * Scripts/VCSUtils.pm:
 310           - Modified fixChangeLogPatch() to return a reference to a
 311             hash structure.
 312           - Added documentation to fixChangeLogPatch().
 313           - Modified call site in mergeChangeLogs() as necessary.
 314         * Scripts/svn-apply:
 315           - Modified call site in patch() as necessary.
 316         * Scripts/svn-create-patch:
 317           - Modified call site in generateDiff() as necessary.
 318         * Scripts/svn-unapply:
 319           - Modified call site in patch() as necessary.
 320         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
 321           - Modified the unit tests as necessary.
 322
 323 2010-10-05  Tony Chang  <tony@chromium.org>
 324
 325         Reviewed by Darin Adler.
 326
 327         fix the link to the expected image on windows
 328         https://bugs.webkit.org/show_bug.cgi?id=47228
 329
 330         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: On
 331             windows, the file must be opened in binary mode when writing
 332             binary data.
 333
 334 2010-10-05  Adam Barth  <abarth@webkit.org>
 335
 336         Update expected result of unittest to match Tony's change below.
 337
 338         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
 339
 340 2010-10-05  Tony Chang  <tony@chromium.org>
 341
 342         Reviewed by Ojan Vafai (over the shoulder).
 343
 344         Paper over errors in image_diff so we don't crash the whole test run.
 345
 346         * Scripts/webkitpy/layout_tests/port/chromium.py:
 347
 348 2010-10-05  Tony Chang  <tony@chromium.org>
 349
 350         Unreviewed, make shutil.rmtree more resiliant to errors
 351         since windows was raising WindowsError: The process cannot access the file because it
 352         is being used by another process.
 353
 354         * Scripts/webkitpy/layout_tests/port/chromium.py:
 355
 356 2010-10-05  Tony Chang  <tony@chromium.org>
 357
 358         Reviewed by Ojan Vafai.
 359
 360         [chromium] fix image diffing in NRWT
 361         https://bugs.webkit.org/show_bug.cgi?id=47128
 362
 363         * Scripts/webkitpy/layout_tests/port/chromium.py: Stop using
 364             NamedTemporaryFile since it doesn't work on Windows.
 365         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
 366
 367 2010-10-05  Kenneth Russell  <kbr@google.com>
 368
 369         Reviewed by Tony Chang.
 370
 371         [chromium] Implement layerTreeAsText in DumpRenderTree
 372         https://bugs.webkit.org/show_bug.cgi?id=47216
 373
 374         Plumbed Frame::layerTreeAsText through Chromium's WebKit API to
 375         make it callable from DumpRenderTree.
 376
 377         No new tests; verified with existing compositor layout tests.
 378
 379         * DumpRenderTree/chromium/LayoutTestController.cpp:
 380         (LayoutTestController::LayoutTestController):
 381         (LayoutTestController::layerTreeAsText):
 382         * DumpRenderTree/chromium/LayoutTestController.h:
 383
 384 2010-10-05  Brent Fulgham  <bfulgham@webkit.org>
 385
 386         Unreviewed build correction.
 387
 388         * DumpRenderTree/win/ImageDiff.vcproj: Use WinCairo debug
 389         property sheet so proper libraries are linked.
 390
 391 2010-10-05  Robert Hogan  <robert@webkit.org>
 392
 393         Reviewed by Andreas Kling.
 394
 395         [Qt] Fix url conversion in QWebHistory
 396
 397         Converting from KURL to WFT::String to QUrl does not
 398         permit proper percent encoding later.
 399
 400         https://bugs.webkit.org/show_bug.cgi?id=47048
 401
 402         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
 403         (WebCore::dumpHistoryItem):
 404
 405 2010-10-05  Anders Carlsson  <andersca@apple.com>
 406
 407         Reviewed by Sam Weinig.
 408
 409         REGRESSION (r68966?): All dumpAsText test fail on WebKit2
 410         https://bugs.webkit.org/show_bug.cgi?id=47188
 411         <rdar://problem/8514104>
 412
 413         When constructing the std::string, use the real string length instead of the maximum buffer size.
 414
 415         * TestWebKitAPI/PlatformUtilities.h:
 416         (TestWebKitAPI::Util::toSTD):
 417         * WebKitTestRunner/StringFunctions.h:
 418         (WTR::toSTD):
 419
 420 2010-10-04  Sam Weinig  <sam@webkit.org>
 421
 422         Reviewed by Mark Rowe.
 423
 424         Add MIMEType accessor to WKFrame
 425         <rdar://problem/8347683>
 426         https://bugs.webkit.org/show_bug.cgi?id=47138
 427
 428         * TestWebKitAPI/PlatformUtilities.h:
 429         (TestWebKitAPI::Util::toSTD):
 430         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 431         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp: Added.
 432         (TestWebKitAPI::didStartProvisionalLoadForFrame):
 433         (TestWebKitAPI::didCommitLoadForFrame):
 434         (TestWebKitAPI::didFinishLoadForFrame):
 435         (TestWebKitAPI::TEST):
 436         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp: Added.
 437         (TestWebKitAPI::didStartProvisionalLoadForFrame):
 438         (TestWebKitAPI::didCommitLoadForFrame):
 439         (TestWebKitAPI::didFinishLoadForFrame):
 440         (TestWebKitAPI::TEST):
 441         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
 442         (TestWebKitAPI::TEST):
 443         * TestWebKitAPI/Tests/WebKit2/basic-1.html: Removed.
 444         * TestWebKitAPI/Tests/WebKit2/icon.png: Added.
 445         * TestWebKitAPI/Tests/WebKit2/simple.html: Added.
 446         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
 447         (TestWebKitAPI::Util::createURLForResource):
 448
 449 2010-10-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
 450
 451         Reviewed by Ojan Vafai.
 452
 453         [NRWT] Rename current_dir to current_group because it's not a directory
 454         https://bugs.webkit.org/show_bug.cgi?id=47169
 455
 456         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
 457         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 458
 459 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
 460
 461         Unreviewed, build fix.
 462
 463         r69065 broke test-webkitpy by trying to create a '/tmp-X' directory,
 464         which can't always be done. This test uses tempfile.mkdtemp(), which
 465         should be safe.
 466
 467         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
 468
 469 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
 470
 471         Unreviewed, build fix.
 472
 473         Add missing "from __future__ import with_statement" that was
 474         breaking test-webkitpy on the Leopard bots (broke in r69040).
 475
 476         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
 477
 478 2010-10-04  Sheriff Bot  <webkit.review.bot@gmail.com>
 479
 480         Unreviewed, rolling out r69066.
 481         http://trac.webkit.org/changeset/69066
 482         https://bugs.webkit.org/show_bug.cgi?id=47163
 483
 484         Made NRWT reliability worse. (Requested by tkent on #webkit).
 485
 486         * Scripts/webkitpy/layout_tests/port/chromium.py:
 487         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
 488
 489 2010-10-04  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
 490
 491         Reviewed by Tony Chang.
 492
 493         [NRWT] Reverse the http tests to alphabetical order.
 494         https://bugs.webkit.org/show_bug.cgi?id=47075
 495
 496         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 497
 498 2010-10-04  Robert Hogan  <robert@webkit.org>
 499
 500         Reviewed by Andreas Kling.
 501
 502         [Qt] Fix timeout on http/tests/navigation/post-goback2.html and postredirect-goback2.html
 503
 504         We need to queue back and forward navigations in the DRT from the
 505         LayoutTestController so that maybeDump() knows about them.
 506
 507         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 508         (LayoutTestController::queueBackNavigation):
 509         (LayoutTestController::queueForwardNavigation):
 510
 511 2010-10-04  Tony Chang  <tony@chromium.org>
 512
 513         Reviewed by Kent Tamura.
 514
 515         [chromium] fix image diffing in NRWT
 516         https://bugs.webkit.org/show_bug.cgi?id=47128
 517
 518         * Scripts/webkitpy/layout_tests/port/chromium.py: Flush data to the
 519               temp file and check the image_diff error code more carefully
 520         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
 521
 522 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
 523
 524         Reviewed by Adam Barth.
 525
 526         aroben's change in r68792 actually broke new-run-webkit-tests when
 527         running the DRT code path. His change was intended to fix the
 528         way we were converting windows paths to URIs when running under
 529         Cygwin (the paths were getting one too many "/" on the front).
 530         However, the change ended up breaking the chromium_win port, which
 531         had slightly different logic.
 532
 533         This patch removes the port-specific code and adds tests to make
 534         sure we're getting the behavior we expect. The Port object no longer
 535         exposes a get_absolute_path() method that can be used outside of
 536         of converting test filenames, because it's unreliable otherwise
 537         (we don't have the right context to know which conversion is intended).
 538
 539         https://bugs.webkit.org/show_bug.cgi?id=47140
 540
 541         * Scripts/webkitpy/layout_tests/port/base.py:
 542         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
 543         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
 544         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 545         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
 546
 547 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
 548
 549         Unreviewed, build fix.
 550
 551         Handle crash introduced in r69040 if we are not running in a
 552         Chromium checkout.
 553
 554         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
 555
 556 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
 557
 558         Reviewed by Tony Chang.
 559
 560         Add a way for us to have test expectations that are specific to the
 561         official builds of Google Chrome (as opposed to Chromium). This change
 562         looks for an additional "test_expectations_chrome.txt" file in
 563         Chromium's repository (webkit/tools/layout_tests), and uses the
 564         concatenation of that file and the regular test_expectations.txt
 565         file for test overrides.
 566
 567         https://bugs.webkit.org/show_bug.cgi?id=46854
 568
 569         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
 570         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
 571
 572 2010-10-04  Simon Fraser  <simon.fraser@apple.com>
 573
 574         Color tests in the list based on existing pass/fail result.
 575
 576         Fix the summary data to account for htmlOnly and nonHTML tests.
 577
 578         * CSSTestSuiteHarness/harness/harness.css:
 579         (#test-list > option.pass):
 580         (#test-list > option.fail):
 581         (#test-list > option.skipped):
 582         * CSSTestSuiteHarness/harness/harness.js:
 583         (Test):
 584         (Test.prototype.statusForFormat):
 585         (TestSuite.prototype.fillTestList):
 586         (TestSuite.prototype.updateTestList):
 587         (TestSuite.prototype.recordResult):
 588         (TestSuite.prototype.markTestCompleted):
 589         (TestSuite.prototype.countTestsWithFlag):
 590         (TestSuite.prototype.queryDatabaseForSummary.this.db.transaction):
 591         (TestSuite.prototype.queryDatabaseForSummary):
 592
 593 2010-10-04  Chris Fleizach  <cfleizach@apple.com>
 594
 595         Reviewed by Beth Dakin.
 596
 597         AX: doAXRangeForLine does not work
 598         https://bugs.webkit.org/show_bug.cgi?id=47101
 599
 600         DRT support to handle NSAccessibilityRangeForLineParameterizedAttribute.
 601
 602         * DumpRenderTree/AccessibilityUIElement.cpp:
 603         (rangeForLineCallback):
 604         (AccessibilityUIElement::rangeForLine):
 605         (AccessibilityUIElement::getJSClass):
 606         * DumpRenderTree/AccessibilityUIElement.h:
 607         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
 608         (AccessibilityUIElement::rangeForLine):
 609
 610 2010-10-04  Andrey Kosyakov  <caseq@chromium.org>
 611
 612         Unreviewed. Adding myself to the committers list.
 613
 614         * Scripts/webkitpy/common/config/committers.py:
 615
 616 2010-10-04  Sam Weinig  <sam@webkit.org>
 617
 618         Reviewed by Anders Carlsson.
 619
 620         Add ability to set the CacheModel in Webkit2
 621         https://bugs.webkit.org/show_bug.cgi?id=47066
 622
 623         * MiniBrowser/mac/AppDelegate.m:
 624         (-[BrowserAppDelegate init]): Opt minibrowser into
 625         a PrimaryWebBrowser cache model.
 626
 627 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
 628
 629         Make sure to enter all tests when creating the database
 630         for the first time.
 631
 632         When migrating to a new version of the suite, be sure to
 633         sync up the database and testinfo.data by removing old
 634         tests, and inserting new ones.
 635
 636         * CSSTestSuiteHarness/harness/harness.js:
 637         (TestSuite.prototype.openDatabase.creation):
 638         (TestSuite.prototype.databaseCreated):
 639         (TestSuite.prototype.populateDatabaseFromTestInfoData):
 640         (TestSuite.prototype.insertTest):
 641
 642 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
 643
 644         More work on treating HTML4 and XHTML1 independently; when
 645         changing the format, rebuild the test list, and update the
 646         numbers in the chapter popup.
 647
 648         * CSSTestSuiteHarness/harness/harness.js:
 649         (Test):
 650         (Test.prototype.runForFormat):
 651         (Test.prototype.completedForFormat):
 652         (ChapterSection):
 653         (ChapterSection.prototype.countTests):
 654         (Chapter):
 655         (Chapter.prototype.description):
 656         (Chapter.prototype.countTests):
 657         (Chapter.prototype.testCount):
 658         (Chapter.prototype.untestedCount):
 659         (TestSuite.prototype.buildChapters):
 660         (TestSuite.prototype.loadCurrentTest):
 661         (TestSuite.prototype.updateProgressLabel):
 662         (TestSuite.prototype.processFlags):
 663         (TestSuite.prototype.formatChanged):
 664
 665 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
 666
 667         Update test suite version 20101001.
 668
 669         Handle database migration, and delete tests from the db that are
 670         not present in testinfo.data.
 671
 672         Load about:blank into the test frame before the test url, to make
 673         missing tests more obvious.
 674
 675         * CSSTestSuiteHarness/harness/harness.js:
 676         (TestSuite.prototype.loadTest):
 677         (TestSuite.prototype.openDatabase.creation):
 678         (TestSuite.prototype.openDatabase.migration1_0To1_1):
 679         (TestSuite.prototype.openDatabase.if.return):
 680         (TestSuite.prototype.databaseReady):
 681         (TestSuite.prototype.populateDatabaseFromTestInfoData):
 682         (TestSuite.prototype.syncDatabaseWithTestInfoData.this.db.transaction):
 683         (TestSuite.prototype.syncDatabaseWithTestInfoData):
 684
 685 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
 686
 687         Add the ability to jump to a specific test.
 688
 689         * CSSTestSuiteHarness/harness/harness.html:
 690         * CSSTestSuiteHarness/harness/harness.js:
 691         (TestSuite.prototype.goToTestByName):
 692         (TestSuite.prototype.switchToFormat):
 693
 694 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
 695
 696         For a ref test, load the ref in the same format (HTML4 vs XHTML1)
 697         as the test.
 698
 699         * CSSTestSuiteHarness/harness/harness.js:
 700         (TestSuite.prototype.loadRef):
 701
 702 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
 703
 704         Update the UI to reflect the fact that each test needs to be tested
 705         in both HTML4 and XHTML1 format.
 706
 707         * CSSTestSuiteHarness/harness/harness.js:
 708         (Test):
 709         (Chapter.prototype.description):
 710         (Chapter.prototype.untestedCount):
 711         (TestSuite.prototype.fillChapterPopup):
 712         (TestSuite.prototype.updateChapterPopup):
 713         (TestSuite.prototype.fillTestList):
 714         (TestSuite.prototype.updateTestList):
 715         (TestSuite.prototype.goToNextIncompleteTest):
 716         (TestSuite.prototype.firstIncompleteTestIndex):
 717         (TestSuite.prototype.recordResult):
 718         (TestSuite.prototype.formatChanged):
 719         (TestSuite.prototype.markTestCompleted):
 720         (TestSuite.prototype.resetTestStatus):
 721
 722 2010-10-01  Simon Fraser  <simon.fraser@apple.com>
 723
 724         Add the ability to remove results for re-testing, and
 725         to import results.
 726
 727         * CSSTestSuiteHarness/harness/harness.css:
 728         (.custom button):
 729         (#overlay):
 730         (#overlay.visible):
 731         (.overlay-contents):
 732         (.overlay-contents textarea):
 733         (.overlay-contents .buttons):
 734         (.overlay-contents .note):
 735         (.overlay-contents .buttons button):
 736         * CSSTestSuiteHarness/harness/harness.html:
 737         * CSSTestSuiteHarness/harness/harness.js:
 738         (TestSuite.prototype.importResults):
 739         (TestSuite.prototype.clearResults):
 740         (TestSuite.prototype.markTestCompleted):
 741         (TestSuite.prototype.resetTestStatus):
 742         (TestSuite.prototype.storeTestResult):
 743         (TestSuite.prototype.importTestResults):
 744         (TestSuite.prototype.clearTestResults):
 745
 746 2010-10-01  Sam Weinig  <sam@webkit.org>
 747
 748         Reviewed by Jon Honeycutt.
 749
 750         Deploy the new WKString functions to remove most uses of CF from
 751         the WebKitTestRunner.
 752
 753         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
 754         (WTR::InjectedBundle::didReceiveMessage):
 755         (WTR::InjectedBundle::done):
 756         * WebKitTestRunner/StringFunctions.h:
 757         (WTR::toWK):
 758         (WTR::toJS):
 759         (WTR::toSTD):
 760         (WTR::operator<<):
 761         (WTR::copyURLString):
 762         * WebKitTestRunner/TestController.cpp:
 763         (WTR::TestController::resetStateToConsistentValues):
 764         (WTR::TestController::didFinishLoadForFrame):
 765         * WebKitTestRunner/TestInvocation.cpp:
 766         (WTR::TestInvocation::invoke):
 767         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
 768
 769 2010-10-01  Mihai Parparita  <mihaip@chromium.org>
 770
 771         Unreviewed TestResultsServer change.
 772
 773         Add files introduced by http://crrev.com/61273 to the list of dashboard
 774         files to update.
 775
 776         * TestResultServer/handlers/dashboardhandler.py:
 777
 778 2010-10-01  Brian Weinstein  <bweinstein@apple.com>
 779
 780         Build Fix for Windows.
 781
 782         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Don't copy ForwardingHeaders from
 783             WebKitTestRunner/ForwardingHeaders, instead, add $(WebKitOutputDir)/include/WebCore/
 784             ForwardingHeaders to the include path.
 785
 786 2010-10-01  Sam Weinig  <sam@webkit.org>
 787
 788         Reviewed by Anders Carlsson.
 789
 790         Add SPI to convert a WKStringRef to a JSStringRef and vice-versa.
 791
 792         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 793         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
 794         (TestWebKitAPI::TEST):
 795         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp: Added.
 796         (TestWebKitAPI::TEST):
 797
 798 2010-10-01  Sam Weinig  <sam@webkit.org>
 799
 800         Reviewed by Kenneth Rohde Christiansen.
 801
 802         Add additional WKString API
 803         https://bugs.webkit.org/show_bug.cgi?id=46958
 804
 805         Add basic WKStringRef tests.
 806
 807         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 808         * TestWebKitAPI/Tests/WebKit2/WKString.cpp: Added.
 809
 810 2010-10-01  Sam Weinig  <sam@webkit.org>
 811
 812         Reviewed by Dan Bernstein.
 813
 814         Add makefile for TestWebKitAPI and call it from the base makefile.
 815
 816         * Makefile:
 817         * TestWebKitAPI/Makefile: Added.
 818
 819 2010-10-01  Sam Weinig  <sam@webkit.org>
 820
 821         Reviewed by Adam Roben.
 822
 823         Remove unnecessary ForwardingHeaders from test runners.
 824         https://bugs.webkit.org/show_bug.cgi?id=47010
 825
 826         * TestWebKitAPI/Configurations/Base.xcconfig:
 827         * TestWebKitAPI/ForwardingHeaders: Removed.
 828         * WebKitTestRunner/Configurations/Base.xcconfig:
 829         * WebKitTestRunner/ForwardingHeaders: Removed.
 830
 831 2010-09-30  Adam Barth  <abarth@webkit.org>
 832
 833         Reviewed by Eric Seidel.
 834
 835         WebSocket tests are flaky
 836         https://bugs.webkit.org/show_bug.cgi?id=46956
 837
 838         Update these tools to understand how to run the WebSocket tests off the
 839         Apache server.
 840
 841         * Scripts/old-run-webkit-tests:
 842         * Scripts/webkitpy/layout_tests/port/base.py:
 843         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
 844         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
 845
 846 2010-10-01  Adam Roben  <aroben@apple.com>
 847
 848         Encode Executive command arguments using UTF-8 on Cygwin
 849
 850         Cygwin's Python's os.execv doesn't support unicode command arguments.
 851         Cygwin's execv expects arguments to be encoded using the current code
 852         page. But code pages are limited in what characters they can handle,
 853         and our tests include characters that the English code page can't
 854         handle.  So for now we'll just encode everything in UTF-8 on Cygwin,
 855         which can handle all characters but might confuse some commands, for
 856         expediency's sake. I'm sure we'll run into cases where UTF-8 isn't
 857         good enough, but we can deal with that when the problem arises.
 858
 859         Reviewed by Adam Barth.
 860
 861         Fixes <http://webkit.org/b/46892> <rdar://problem/8496639>
 862         webkitpy.common.system.executive_unittest.ExecutiveTest.test_run_command_with_unicode
 863         fails on Windows
 864
 865         * Scripts/webkitpy/common/system/executive.py:
 866         (Executive._run_command_with_teed_output):
 867         (Executive.run_command):
 868         On Cygwin, encode arguments using UTF-8.
 869
 870 2010-10-01  Sam Weinig  <sam@webkit.org>
 871
 872         Reviewed by Adam Roben.
 873
 874         Add simple API tester for WebKit2
 875         https://bugs.webkit.org/show_bug.cgi?id=46953
 876
 877         This adds a very simple testing infrastructure for testing APIs exposed
 878         through the WebKit project. It consists of two parts: 1) a project that
 879         builds the all the tests 2) a script that searches the tests directory and
 880         calls the tester once for each test.
 881
 882         This adds the infrastructure and two tests:
 883         - Tests/WTF/Vector1.cpp - A proof of concept test of WTF data-structures.
 884         - Tests/WebKit2/BasicTest1.cpp - A proof of concept test of WebKit2 API.
 885
 886         This currently only works on the mac, but is designed to be easily ported
 887         to any platform.
 888
 889         * Scripts/run-api-tests: Added.
 890         * Scripts/build-api-tests: Added.
 891         Scripts to build/run the tests.
 892
 893         * TestWebKitAPI: Added.
 894         * TestWebKitAPI/Configurations: Added.
 895         * TestWebKitAPI/Configurations/Base.xcconfig: Added.
 896         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Added.
 897         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Added.
 898         * TestWebKitAPI/ForwardingHeaders: Added.
 899         * TestWebKitAPI/ForwardingHeaders/wtf: Added.
 900         * TestWebKitAPI/PlatformUtilities.h: Added.
 901         * TestWebKitAPI/PlatformWebView.h: Added.
 902         (TestWebKitAPI::PlatformWebView::platformView):
 903         * TestWebKitAPI/StringFunctions.h: Added.
 904         * TestWebKitAPI/Test.h: Added.
 905         (TestWebKitAPI::Test::~Test):
 906         (TestWebKitAPI::Test::name):
 907         (TestWebKitAPI::Test::Register::Register):
 908         (TestWebKitAPI::Test::Register::create):
 909         (TestWebKitAPI::Test::Test):
 910         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Added.
 911         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added.
 912         * TestWebKitAPI/TestWebKitAPIPrefix.h: Added.
 913         * TestWebKitAPI/TestsController.cpp: Added.
 914         (TestWebKitAPI::TestsController::shared):
 915         (TestWebKitAPI::TestsController::TestsController):
 916         (TestWebKitAPI::TestsController::runTestNamed):
 917         (TestWebKitAPI::TestsController::testFailed):
 918         (TestWebKitAPI::TestsController::registerCreateTestFunction):
 919         * TestWebKitAPI/TestsController.h: Added.
 920         * TestWebKitAPI/mac: Added.
 921         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm: Added.
 922         (TestWebKitAPI::Util::run):
 923         (TestWebKitAPI::Util::createURLForResource):
 924         * TestWebKitAPI/mac/PlatformWebViewMac.mm: Added.
 925         (TestWebKitAPI::PlatformWebView::PlatformWebView):
 926         (TestWebKitAPI::PlatformWebView::resizeTo):
 927         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
 928         (TestWebKitAPI::PlatformWebView::page):
 929         (TestWebKitAPI::PlatformWebView::focus):
 930         * TestWebKitAPI/mac/main.mm: Added.
 931         Infrastructure.
 932
 933         * TestWebKitAPI/Tests: Added.
 934         * TestWebKitAPI/Tests/WTF: Added.
 935         * TestWebKitAPI/Tests/WTF/Vector1.cpp: Added.
 936         * TestWebKitAPI/Tests/WebKit2: Added.
 937         * TestWebKitAPI/Tests/WebKit2/BasicTest1.cpp: Added.
 938         (TestWebKitAPI::State::State):
 939         * TestWebKitAPI/Tests/WebKit2/basic-1.html: Added.
 940         Proof of concept tests.
 941
 942 2010-10-01  Adam Roben  <aroben@apple.com>
 943
 944         Don't assume AccessibleObjectFromEvent succeeds
 945
 946         Fixes <http://webkit.org/b/44136> <rdar://problem/8321684> Crash in
 947         DumpRenderTree!notificationListenerProc when running
 948         plugins/access-after-page-destroyed.html
 949
 950         Reviewed by Sam Weinig.
 951
 952         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
 953         (notificationListenerProc): Check both the return value of
 954         AccessibleObjectFromEvent and the object it returns, as MSDN
 955         recommends.
 956
 957 2010-10-01  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
 958
 959         Reviewed by Tony Chang.
 960
 961         [NRWT] Put the http and websocket tests first in the test list.
 962         https://bugs.webkit.org/show_bug.cgi?id=46453
 963
 964         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 965         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
 966
 967 2010-10-01  Fady Samuel  <fsamuel@chromium.org>
 968
 969         Unreviewed, adding myself to the committer list.
 970
 971         * Scripts/webkitpy/common/config/committers.py:
 972
 973 2010-10-01  Adam Roben  <aroben@apple.com>
 974
 975         Test NPN_GetValue(NPNVnetscapeWindow)
 976
 977         Test for <http://webkit.org/b/46726> <rdar://problem/8486319>
 978         Right-clicking on windowless Flash plugin in WebKit2 makes a context
 979         menu appear in the bottom-right corner of the screen
 980
 981         Reviewed by Anders Carlsson.
 982
 983         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
 984         (PluginTest::NPN_GetValue): Added. Calls through to the browser.
 985
 986         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added NPN_GetValue.
 987
 988         * DumpRenderTree/TestNetscapePlugIn/Tests/win/GetValueNetscapeWindow.cpp: Added.
 989         (GetValueNetscapeWindow::GetValueNetscapeWindow): Initialize members.
 990         (GetValueNetscapeWindow::NPP_SetWindow): Test that
 991         NPN_GetValue(NPNVnetscapeWindow) returns a valid HWND and that it
 992         isn't our HWND.
 993
 994         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
 995         Added GetValueNetscapeWindow.
 996
 997 2010-10-01  Andreas Kling  <andreas.kling@nokia.com>
 998
 999         Unreviewed, adding my webkit.org identity to reviewer list.
1000
1001         * Scripts/webkitpy/common/config/committers.py:
1002
1003 2010-09-30  Adam Barth  <abarth@webkit.org>
1004
1005         Reviewed by Eric Seidel.
1006
1007         The WebSocket server should flush its logs
1008         https://bugs.webkit.org/show_bug.cgi?id=46946
1009
1010         The WebSocket server logs are truncated because the driver just
1011         terminates the child.  It should run Python without buffering so we can
1012         see the end of the log.
1013
1014         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1015
1016 2010-09-30  Simon Fraser  <simon.fraser@apple.com>
1017
1018         Add a button to jump to the next untested test.
1019
1020         * CSSTestSuiteHarness/harness/harness.css:
1021         (.test-type):
1022         (.name > button):
1023         * CSSTestSuiteHarness/harness/harness.html:
1024         * CSSTestSuiteHarness/harness/harness.js:
1025         (Chapter.prototype.description):
1026         (Chapter.prototype.untestedCount):
1027         (TestSuite.prototype.testInfoDataLoaded):
1028         (TestSuite.prototype.fillChapterPopup):
1029         (TestSuite.prototype.updateChapterPopup):
1030         (TestSuite.prototype.buildTestListForChapter):
1031         (TestSuite.prototype.goToNextIncompleteTest):
1032         (TestSuite.prototype.firstIncompleteTestIndex):
1033         (TestSuite.prototype.testCompletionStateChanged):
1034
1035 2010-09-29  Jon Honeycutt  <jhoneycutt@apple.com>
1036
1037         WebKit2 on Windows should use Windows fonts for the various standard
1038         font families
1039         https://bugs.webkit.org/show_bug.cgi?id=43499
1040         <rdar://problem/8272758>
1041
1042         Reviewed by Adam Roben.
1043
1044         * WebKitTestRunner/TestController.cpp:
1045         (WTR::TestController::resetStateToConsistentValues):
1046         Use the Mac fonts for running tests. This matches DRT behavior.
1047
1048 2010-09-30  Adam Barth  <abarth@webkit.org>
1049
1050         Third attempt.  We need a better integration test environment.
1051
1052         * Scripts/webkitpy/common/net/failuremap.py:
1053         * Scripts/webkitpy/common/net/failuremap_unittest.py:
1054
1055 2010-09-30  Robert Hogan  <robert@webkit.org>
1056
1057         Reviewed by Andreas Kling.
1058
1059         [Qt] Support for PlainTextController
1060
1061         Unskip editing/text-iterator/basic-iteration.html
1062
1063         https://bugs.webkit.org/show_bug.cgi?id=38805
1064
1065         * DumpRenderTree/qt/DumpRenderTree.pro:
1066         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1067         (WebCore::DumpRenderTree::DumpRenderTree):
1068         (WebCore::DumpRenderTree::initJSObjects):
1069         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1070         * DumpRenderTree/qt/PlainTextControllerQt.cpp: Added.
1071         (PlainTextController::PlainTextController):
1072         (PlainTextController::plainText):
1073         * DumpRenderTree/qt/PlainTextControllerQt.h: Added.
1074
1075 2010-09-30  Adam Barth  <abarth@webkit.org>
1076
1077         Unreviewed.  Second attempt to fix sheriffbot.
1078
1079         * Scripts/webkitpy/common/net/buildbot.py:
1080
1081 2010-09-30  Adam Barth  <abarth@webkit.org>
1082
1083         Unreviewed.
1084
1085         This patch should stop the sheriffbot from throwing an exception.
1086
1087         * Scripts/webkitpy/common/net/buildbot.py:
1088
1089 2010-09-30  Brian Weinstein  <bweinstein@apple.com>
1090
1091         Reviewed by Adam Roben.
1092
1093         The same bots shouldn't run both Windows Debug Tests and Windows Release Tests.
1094         https://bugs.webkit.org/show_bug.cgi?id=46926
1095
1096         * BuildSlaveSupport/build.webkit.org-config/config.json: Have two bots running Windows
1097             Release Tests, and two bots running Windows Debug Tests, instead of four running both.
1098
1099 2010-09-30  Adam Barth  <abarth@webkit.org>
1100
1101         Reviewed by Eric Seidel.
1102
1103         webkit-patch find-flaky-tests should print results URLs
1104         https://bugs.webkit.org/show_bug.cgi?id=46917
1105
1106         Printing out the results URL makes find-flaky-tests more actionable
1107         because you can see what happens when a test fails.  The output from
1108         the script is still pretty noisy, but it seems useful.
1109
1110         * Scripts/webkitpy/tool/commands/queries.py:
1111
1112 2010-09-30  Chris Marrin  <cmarrin@apple.com>
1113
1114         Reviewed by Simon Fraser.
1115
1116         Make 2D accelerated canvas rendering build on Mac
1117         https://bugs.webkit.org/show_bug.cgi?id=46007
1118
1119         Added ACCELERATED_2D_CANVAS to build-webkit
1120
1121         * Scripts/build-webkit:
1122
1123 2010-09-29  Kenneth Russell  <kbr@google.com>
1124
1125         Reviewed by Dimitri Glazkov.
1126
1127         [chromium] Add accelerated compositing support to DumpRenderTree and test_shell
1128         https://bugs.webkit.org/show_bug.cgi?id=46849
1129
1130         Added offscreen code path for WebGraphicsContext3DDefaultImpl which
1131         works with the compositor integration in both DumpRenderTree and
1132         test_shell, since both pass a non-null WebCanvas* to WebViewImpl::paint
1133         and thereby trigger the compositor's readback code path. Added support
1134         for --enable-accelerated-compositing to DumpRenderTree.
1135
1136         Tested in both test_shell and DumpRenderTree on Linux, the latter by
1137         modifying a compositing layout test, dumping the pixels and verifying
1138         that they matched the output when the compositor was active.
1139
1140         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1141         (main):
1142         * DumpRenderTree/chromium/TestShell.cpp:
1143         (TestShell::TestShell):
1144         (TestShell::resetWebSettings):
1145         * DumpRenderTree/chromium/TestShell.h:
1146         (TestShell::setAcceleratedCompositingEnabled):
1147         * DumpRenderTree/chromium/WebPreferences.cpp:
1148         (WebPreferences::reset):
1149         (WebPreferences::applyTo):
1150         * DumpRenderTree/chromium/WebPreferences.h:
1151         * DumpRenderTree/chromium/WebViewHost.cpp:
1152         (WebViewHost::scheduleComposite):
1153         * DumpRenderTree/chromium/WebViewHost.h:
1154
1155 2010-09-30  Adam Roben  <aroben@apple.com>
1156
1157         Ensure that QueueEngine cleans up its log files when its delegate
1158         tells it to stop processing work
1159
1160         Reviewed by Adam Barth.
1161
1162         Fixes <http://webkit.org/b/46891> <rdar://problem/8496638> Many tests
1163         in webkitpy.tool.bot.queueengine_unittest.QueueEngineTest crash on
1164         Windows
1165
1166         * Scripts/webkitpy/tool/bot/queueengine.py:
1167         (QueueEngine.run): Stop ourselves normally (including cleaning up log
1168         files) when the delegate tells us to stop processing work.
1169
1170         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1171         (LoggingDelegate.__init__): Moved code here from
1172         RaisingDelegate.__init__.
1173         (LoggingDelegate.expeced_callbacks): Added the stop_work_queue
1174         callback.
1175         (LoggingDelegate.stop_work_queue): Moved here from RaisingDelegate.
1176         (RaisingDelegate.__init__): Removed code that LoggingDelegate takes
1177         care of for us now.
1178         (QueueEngineTest.test_trivial): Make sure we got the expected stop
1179         message.
1180         (QueueEngineTest.test_not_safe_to_proceed): Changed to explicitly
1181         remove the callbacks that are related to processing a single work
1182         item, rather than removing all callbacks after a certain point, as
1183         there are now more callbacks we expect to receive at the end.
1184
1185 2010-09-30  Adam Roben  <aroben@apple.com>
1186
1187         Fix path -> URL conversion on Cygwin
1188
1189         Reviewed by Adam Barth.
1190
1191         Fixes <http://webkit.org/b/46890> <rdar://problem/8496637> Many tests
1192         in webkitpy.layout_tests.run_webkit_tests_unittest assert on Windows
1193
1194         * Scripts/webkitpy/layout_tests/port/base.py:
1195         (Port.filename_to_uri): Treat Cygwin like other UNIX-y platforms by
1196         assuming paths already have a leading slash.
1197
1198 2010-09-30  Adam Roben  <aroben@apple.com>
1199
1200         Teach WindowGeometryInitializedBeforeSetWindow that NPP_SetWindow can
1201         be called more than once
1202
1203         The NPP_SetWindow call made when the plugin is torn down was confusing
1204         us, and was causing us to spew an error into the next test.
1205
1206         Fixes <http://webkit.org/b/46900> <rdar://problem/8496888> REGRESSION
1207         (r68520): plugins/access-after-page-destroyed.html failing on Windows
1208
1209         Reviewed by Anders Carlsson.
1210
1211         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:
1212         (WindowGeometryInitializedBeforeSetWindow::WindowGeometryInitializedBeforeSetWindow):
1213         Initialize member.
1214         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Bail if
1215         this isn't the first time this is called.
1216
1217 2010-09-30  Eric Seidel  <eric@webkit.org>
1218
1219         Reviewed by Adam Barth.
1220
1221         webkit-patch upload warns that I'm using Xcode when I'm not
1222         https://bugs.webkit.org/show_bug.cgi?id=46869
1223
1224         String.find returns -1 when not found, so switched to "in".
1225
1226         * Scripts/webkitpy/common/system/user.py:
1227         * Scripts/webkitpy/common/system/user_unittest.py:
1228
1229 2010-09-30  Eric Seidel  <eric@webkit.org>
1230
1231         Reviewed by Adam Barth.
1232
1233         webkit-patch failure-reason dies if non-trunk commits are in the blame range
1234         https://bugs.webkit.org/show_bug.cgi?id=46866
1235
1236         I also made failure-reason use RegressionWindow in a cleaner way.
1237
1238         * Scripts/webkitpy/tool/commands/queries.py:
1239
1240 2010-09-29  Adam Barth  <abarth@webkit.org>
1241
1242         Reviewed by Eric Seidel.
1243
1244         webkit-patch find-flaky-tests
1245         https://bugs.webkit.org/show_bug.cgi?id=46876
1246
1247         This command helps us find flaky tests so we can squash them.
1248
1249         * Scripts/webkitpy/tool/commands/queries.py:
1250
1251 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
1252
1253         Fix export to use '?' instead of 'null' for
1254         tests with no results.
1255
1256         * CSSTestSuiteHarness/harness/harness.js:
1257
1258 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
1259
1260         Add a warning when a test requires special steps.
1261         Add a Print Preview button for 'paged' tests that
1262         brings up the print dialog, allowing the user to
1263         judge paged media tests.
1264
1265         * CSSTestSuiteHarness/harness/harness.css:
1266         * CSSTestSuiteHarness/harness/harness.html:
1267         * CSSTestSuiteHarness/harness/harness.js:
1268         (TestSuite.prototype.loadTest):
1269         (TestSuite.prototype.processFlags):
1270
1271 2010-09-29  Adam Barth  <abarth@webkit.org>
1272
1273         Reviewed by Eric Seidel.
1274
1275         Remove revisions_casuing_failures
1276         https://bugs.webkit.org/show_bug.cgi?id=46872
1277
1278         This function exists only to be unit tested.
1279
1280         * Scripts/webkitpy/common/net/failuremap.py:
1281         * Scripts/webkitpy/common/net/failuremap_unittest.py:
1282         * Scripts/webkitpy/tool/mocktool.py:
1283
1284 2010-09-29  Adam Barth  <abarth@webkit.org>
1285
1286         Reviewed by Eric Seidel.
1287
1288         SheriffBot should post the list of failing tests to bugs
1289         https://bugs.webkit.org/show_bug.cgi?id=46871
1290
1291         * Scripts/webkitpy/common/net/buildbot.py:
1292         * Scripts/webkitpy/common/net/failuremap.py:
1293         * Scripts/webkitpy/common/net/regressionwindow.py:
1294         * Scripts/webkitpy/tool/bot/sheriff.py:
1295         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
1296         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1297         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1298         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1299         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1300         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1301         * Scripts/webkitpy/tool/mocktool.py:
1302
1303 2010-09-29  Brent Fulgham  <bfulgham@webkit.org>
1304
1305         Reviewed by Martin Robinson, Eric Seidel, and Mark Rowe.
1306
1307         [WinCairo] Adds a build slave.
1308         https://bugs.webkit.org/show_bug.cgi?id=46360
1309
1310         * BuildSlaveSupport/build.webkit.org-config/config.json: Add
1311         entries for a debug build of the WinCairo port.
1312         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add
1313         platform flag to configuration for wincairo (like gtk, chromium, etc.)
1314         * Scripts/build-webkit: Change 'cairo-win32' labeling to 'wincairo'
1315         * Scripts/webkitdirs.pm: Change 'cairo-win32' labeling to 'wincairo'
1316
1317 2010-09-29  Adam Barth  <abarth@webkit.org>
1318
1319         Reviewed by Eric Seidel.
1320
1321         Move more SheriffBot smarts into FailureMap
1322         https://bugs.webkit.org/show_bug.cgi?id=46703
1323
1324         This patch pushes the FailureMap model object further into the
1325         SheriffBot machine.  In addition, it moves a couple operations on this
1326         object from SheriffBot itself to the model.
1327
1328         Eventually, FailureMap will be the canonical context object for
1329         SheriffBot operations.  FailureMap represents a map of the current
1330         failures on the bots that might require remediation.
1331
1332         * Scripts/webkitpy/common/net/failuremap.py:
1333         * Scripts/webkitpy/common/net/regressionwindow.py:
1334         * Scripts/webkitpy/tool/commands/queries.py:
1335         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1336         * Scripts/webkitpy/tool/mocktool.py:
1337
1338 2010-09-29  Tony Chang  <tony@chromium.org>
1339
1340         Reviewed by James Robinson.
1341
1342         [chromium] enable -Werror for DRT and webkit_unit_tests on Linux
1343         https://bugs.webkit.org/show_bug.cgi?id=46829
1344
1345         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1346         (DRTDevToolsClient::DRTDevToolsClient):
1347         * DumpRenderTree/chromium/TestShell.cpp:
1348         (TestShell::TestShell):
1349         * DumpRenderTree/chromium/WebViewHost.cpp:
1350         (WebViewHost::postAccessibilityNotification):
1351         (WebViewHost::WebViewHost):
1352
1353 2010-09-29  Chris Fleizach  <cfleizach@apple.com>
1354
1355         Reviewed by Darin Adler.
1356
1357         AX: implement CSS3 Speech "speak"
1358         https://bugs.webkit.org/show_bug.cgi?id=46827
1359
1360         * DumpRenderTree/AccessibilityUIElement.cpp:
1361         (speakCallback):
1362         (AccessibilityUIElement::speak):
1363         (AccessibilityUIElement::getJSClass):
1364         * DumpRenderTree/AccessibilityUIElement.h:
1365         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1366         (AccessibilityUIElement::speak):
1367
1368 2010-09-29  Mihai Parparita  <mihaip@chromium.org>
1369
1370         Reviewed by Adam Barth.
1371
1372         Record bot ID when updating queue status
1373         https://bugs.webkit.org/show_bug.cgi?id=46764
1374
1375         Since we now have multiple bots handling patches from the commit queue,
1376         we need to differentiate status updates from them, so that we can group
1377         the queue status page in a less confusing way.
1378
1379         * QueueStatusServer/handlers/updatestatus.py: Accept bot_id as input
1380         * QueueStatusServer/model/queuestatus.py: Add bot_id property
1381         * QueueStatusServer/templates/updatestatus.html: Add bot_id input
1382         * Scripts/webkitpy/common/net/bugzilla_unittest.py: Extract MockBrowser
1383         * Scripts/webkitpy/common/net/statusserver.py: Add bot_id
1384         * Scripts/webkitpy/common/net/statusserver_unittest.py: Added.
1385         * Scripts/webkitpy/tool/main.py: Add --bot-id
1386         * Scripts/webkitpy/tool/mocktool.py: Add MockBrowser
1387
1388 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
1389
1390         No review.
1391
1392         References always refert to a file in .xht format, even
1393         for HTML tests, so fix their loading.
1394
1395         * CSSTestSuiteHarness/harness/harness.js:
1396         (TestSuite.prototype.loadRef):
1397
1398 2010-09-28  Johnny Ding  <jnd@chromium.org>
1399
1400         Reviewed by Adam Barth.
1401
1402         https://bugs.webkit.org/show_bug.cgi?id=41292
1403         Add a new parameter to the test plugin to allow specifying a script
1404         and a mouse/keyboard event. The specified script will be evaluated
1405         in the browser when the specified event is received by the plugin.
1406
1407         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1408         (pluginAllocate):
1409         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
1410         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1411         (NPP_New):
1412         (handleEventCarbon):
1413         (handleEventCocoa):
1414
1415 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1416
1417         Fix export by adding missing argument.
1418
1419         * CSSTestSuiteHarness/harness/harness.js:
1420         (TestSuite.prototype.showResultsForAllTests):
1421
1422 2010-09-28  Kevin Ollivier  <kevino@theolliviers.com>
1423
1424         [wx] Build fix, add missing import.
1425
1426         * wx/packaging/build-win-installer.py:
1427
1428 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1429
1430         No review
1431
1432         Show which tests have been run by dimming them out in the test list.
1433
1434         Adjust some element sizes.
1435
1436         * CSSTestSuiteHarness/harness/harness.css:
1437         (#test-list > option.untested):
1438         (#test-list > option.completed):
1439         (#output):
1440         (.output-options):
1441         * CSSTestSuiteHarness/harness/harness.js:
1442         (Test):
1443         (TestSuite.prototype.fillTestList):
1444         (TestSuite.prototype.updateTestList):
1445         (TestSuite.prototype.setSelectedChapter):
1446         (TestSuite.prototype.recordResult):
1447         (TestSuite.prototype.markTestCompleted):
1448         (TestSuite.prototype.testCompletionStateChanged):
1449         (TestSuite.prototype.loadTestStatus):
1450
1451 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1452
1453         No review.
1454
1455         Implement export of various queries on the test database, sharing
1456         code with that which displays results inline.
1457
1458         * CSSTestSuiteHarness/harness/harness.js:
1459         ():
1460         (TestSuite.prototype.exportResultsCompletion.var):
1461         (TestSuite.prototype.exportResultsCompletion):
1462         (TestSuite.prototype.showResultsForCompletedTests):
1463         (TestSuite.prototype.exportResultsForCompletedTests):
1464         (TestSuite.prototype.showResultsForAllTests):
1465         (TestSuite.prototype.exportResultsForAllTests):
1466         (TestSuite.prototype.exportResultsForTestsNotRun):
1467         (TestSuite.prototype.exportResultsForTestsWithStatus):
1468         (TestSuite.prototype.exportResultsForTestsWithMismatchedResults):
1469
1470 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1471
1472         No review.
1473
1474         Work around uncertainty about the order of database
1475         transactions when creating the database, so that we don't
1476         try to query the table before it has been created.
1477
1478         * CSSTestSuiteHarness/harness/harness.js:
1479         (TestSuite):
1480         (TestSuite.prototype.databaseCreated):
1481         (TestSuite.prototype.storeTestResult):
1482         (TestSuite.prototype.populateDatabaseFromTestInfoData):
1483         (TestSuite.prototype.queryDatabaseForTestsWithStatus):
1484         (TestSuite.prototype.queryDatabaseForTestsWithMixedStatus):
1485         (TestSuite.prototype.queryDatabaseForCompletedTests):
1486         (TestSuite.prototype.queryDatabaseForTestsNotRun):
1487
1488 2010-09-28  Tony Chang  <tony@chromium.org>
1489
1490         Reviewed by Eric Seidel.
1491
1492         add python keyring support to webkit-patch
1493         https://bugs.webkit.org/show_bug.cgi?id=41269
1494
1495         * Scripts/webkitpy/common/net/credentials.py: Add the ability to read passwords using
1496             the python keyring module
1497         * Scripts/webkitpy/common/net/credentials_unittest.py:
1498         * Scripts/webkitpy/common/system/user.py: Allow confirm() to default to no and add testing params.
1499         * Scripts/webkitpy/common/system/user_unittest.py:
1500         * Scripts/webkitpy/tool/mocktool.py:
1501
1502 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
1503
1504         Reviewed by Gustavo Noronha Silva.
1505
1506         [Cairo] FreeType fonts should obey FontConfig hinting/anti-aliasing settings
1507         https://bugs.webkit.org/show_bug.cgi?id=46740
1508
1509         * DumpRenderTree/gtk/fonts/fonts.conf: Add specialized variants of common
1510         fonts which can be used to fully test FontConfig rendering settings.
1511
1512 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
1513
1514         Reviewed by Gustavo Noronha Silva.
1515
1516         [gtk] Fedora has a different path for the liberation fonts
1517         https://bugs.webkit.org/show_bug.cgi?id=46709
1518
1519         When searching for DRT fonts, also look in the path where those fonts
1520         are commonly found on Fedora systems.
1521
1522         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1523         (initializeFonts): Include logic for looking for Fedora-style font paths.
1524
1525 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
1526
1527         Reviewed by Andreas Kling.
1528
1529         run-webkit-tests needs an updated list of directories with webgl tests
1530         https://bugs.webkit.org/show_bug.cgi?id=46747
1531
1532         Update the list of directories containing WebGL tests and a unit test
1533         which depends on this list.
1534
1535         * Scripts/old-run-webkit-tests: Update the list of directories.
1536         * Scripts/webkitpy/layout_tests/port/webkit.py: Ditto.
1537         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Update the expected result.
1538
1539 2010-09-28  Adam Barth  <abarth@webkit.org>
1540
1541         Reviewed by Eric Seidel.
1542
1543         Introduce FailureMap to summaries the failures status of all the bots
1544         https://bugs.webkit.org/show_bug.cgi?id=46700
1545
1546         This patch gives the SheriffBot a handle on the list of failing tests.
1547
1548         * Scripts/webkitpy/common/net/buildbot.py:
1549         * Scripts/webkitpy/common/net/failuremap.py: Added.
1550         * Scripts/webkitpy/tool/commands/queries.py:
1551         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1552         * Scripts/webkitpy/tool/mocktool.py:
1553
1554 2010-09-28  Adam Roben  <aroben@apple.com>
1555
1556         Update for the addition of WKPageUIClient::didNotHandleKeyEvent
1557
1558         Fixes <http://webkit.org/b/46660> <rdar://problem/8483465> Need API to
1559         tell a WebKit2 client application that a key event was not handled
1560
1561         Reviewed by Kenneth Rohde Christiansen and Sam Weinig.
1562
1563         * MiniBrowser/mac/BrowserWindowController.m:
1564         (-[BrowserWindowController awakeFromNib]):
1565         * MiniBrowser/win/BrowserView.cpp:
1566         (BrowserView::create):
1567         * WebKitTestRunner/TestController.cpp:
1568         (WTR::createOtherPage):
1569         (WTR::TestController::initialize):
1570
1571 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1572
1573         Unreviewed.
1574
1575         Update the CSSTestSuiteHarness to not scrape the XHTML chapter files
1576         for the test order, but instead use information from testinfo.data.
1577
1578         * CSSTestSuiteHarness/harness/harness.html:
1579         * CSSTestSuiteHarness/harness/harness.js:
1580
1581 2010-09-28  Kevin Ollivier  <kevino@theolliviers.com>
1582
1583         [wx] Build fix, don't try to get the svn revision from the git repo when packaging,
1584         it causes the process to hang on the gitorious repo.
1585
1586         * wx/packaging/build-mac-installer.py:
1587         * wx/packaging/build-win-installer.py:
1588
1589 2010-09-28  Adam Roben  <aroben@apple.com>
1590
1591         Test that a plugin's HWND is sized/positioned before NPP_SetWindow is
1592         called
1593
1594         Reviewed by Anders Carlsson.
1595
1596         Test for <http://webkit.org/b/46716> <rdar://problem/8482014>
1597         Full-page Adobe Reader does not paint until window is resized
1598
1599         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1600         (PluginTest::NPP_SetWindow): Added. Just returns NPERR_NO_ERROR at
1601         this level.
1602
1603         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Declared
1604         NPP_SetWindow.
1605
1606         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp: Added.
1607         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Checks that
1608         the plugin's HWND has a non-zero size and that its size/position
1609         matches that specified in the NPWindow.
1610
1611         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1612         (NPP_SetWindow): Call through to the PluginTest.
1613
1614         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1615         Added WindowGeometryInitializedBeforeSetWindow.cpp, and let VS reorder
1616         the files as it saw fit.
1617
1618 2010-09-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
1619
1620         Reviewed by Andreas Kling.
1621
1622         [Qt] Remove support for Qt 4.5
1623         https://bugs.webkit.org/show_bug.cgi?id=46718
1624
1625         Remove the code for versions of Qt prior to 4.6.
1626
1627         * DumpRenderTree/qt/EventSenderQt.cpp:
1628         (EventSender::addTouchPoint):
1629         (EventSender::updateTouchPoint):
1630         (EventSender::setTouchModifier):
1631         (EventSender::touchStart):
1632         (EventSender::touchMove):
1633         (EventSender::touchEnd):
1634         (EventSender::clearTouchPoints):
1635         (EventSender::releaseTouchPoint):
1636         (EventSender::sendTouchEvent):
1637         * DumpRenderTree/qt/EventSenderQt.h:
1638         * DumpRenderTree/qt/TextInputControllerQt.cpp:
1639         (TextInputController::setMarkedText):
1640         * QtTestBrowser/launcherwindow.cpp:
1641         (LauncherWindow::LauncherWindow):
1642         (LauncherWindow::initializeView):
1643         (LauncherWindow::createChrome):
1644         (LauncherWindow::sendTouchEvent):
1645         (LauncherWindow::eventFilter):
1646         (LauncherWindow::applyZoom):
1647         (LauncherWindow::setTouchMocking):
1648         * QtTestBrowser/launcherwindow.h:
1649         * QtTestBrowser/utils.cpp:
1650         (urlFromUserInput):
1651         * QtTestBrowser/webview.cpp:
1652         (WebViewGraphicsBased::animatedFlip):
1653         (WebViewGraphicsBased::animatedYFlip):
1654         * QtTestBrowser/webview.h:
1655         (WebViewGraphicsBased::setYRotation):
1656
1657 2010-09-28  İsmail Dönmez  <ismail@namtrac.org>
1658
1659         Reviewed by Andreas Kling.
1660
1661         Fix DRT compilation on WinCE. Introduce a WCECOMPAT variable
1662         which should point to wcecompat installation. Needs wcecompat
1663         library from http://github.com/mauricek/wcecompat .
1664
1665         * DumpRenderTree/qt/DumpRenderTree.pro:
1666         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1667         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1668
1669 2010-09-28  Daniel Bates  <dbates@rim.com>
1670
1671         Rollout changeset 68493 <http://trac.webkit.org/changeset/68493>
1672         <https://bugs.webkit.org/show_bug.cgi?id=39136>
1673
1674         Rollout changeset 68493 because it broke Sheriffbot's rollout feature.
1675         In particular, this change caused Sheriffbot to raise an exception when
1676         trying to parse the bug id on a bug page. We need to look into this
1677         some more.
1678
1679         * Scripts/webkitpy/common/net/bugzilla.py:
1680         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
1681         * Scripts/webkitpy/tool/bot/sheriff.py:
1682         * Scripts/webkitpy/tool/commands/download.py:
1683         * Scripts/webkitpy/tool/commands/queues.py:
1684         * Scripts/webkitpy/tool/commands/upload.py:
1685         * Scripts/webkitpy/tool/steps/closebug.py:
1686         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
1687         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1688         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
1689
1690 2010-09-28  Adam Barth  <abarth@webkit.org>
1691
1692         Reviewed by Eric Seidel.
1693
1694         Move RegressionWindow further up the dependency chain
1695         https://bugs.webkit.org/show_bug.cgi?id=46698
1696
1697         Baby steps towards pushing this information into bug posts.
1698
1699         * Scripts/webkitpy/common/net/buildbot.py:
1700         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1701         * Scripts/webkitpy/common/net/regressionwindow.py:
1702         * Scripts/webkitpy/tool/commands/queries.py:
1703
1704 2010-09-27  Daniel Bates  <dbates@rim.com>
1705
1706         Reviewed by Adam Barth.
1707
1708         sheriffbot can't roll out security patches
1709         https://bugs.webkit.org/show_bug.cgi?id=39136
1710
1711         Make SheriffBot determine if it's authorized to view a bug
1712         whose change it wants to rollout before it tries to rollout
1713         the change.
1714
1715         Moreover, make both webkit-patch and Sheriffbot provide human-
1716         readable error messages when they are not authorized to view
1717         a bug and when a bug number is invalid.
1718
1719         Currently, Sheriffbot does not parse Bugzilla bugs for
1720         <bug error="...">, which indicates an error when retrieving
1721         a bug. In particular, error="NotPermitted" if a person (or bot)
1722         is not authorized to view a bug. For such error="NotPermitted" bugs,
1723         Sheriffbot raises an exception when parsing the bug report and
1724         this exception does not explicitly indicate Sheriffbot's lack
1725         of authorization. Instead, Sheriffbot should explicitly check
1726         for the presence <bug error="..."> before operating on a bug
1727         and error with a human-readable message if it's not permitted
1728         to view it.
1729
1730         * Scripts/webkitpy/common/net/bugzilla.py: Added BugzillaError class.
1731         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
1732           - Added unit test test_bug_parsing_for_bugzilla_not_permitted_error().
1733           - Added unit test test_bug_parsing_for_bugzilla_not_found_error().
1734           - Added unit test test_bug_parsing_for_bugzilla_invalid_bug_id_error().
1735         * Scripts/webkitpy/tool/bot/sheriff.py: Modified to catch BugzillaError.
1736         * Scripts/webkitpy/tool/commands/download.py: Ditto.
1737         * Scripts/webkitpy/tool/commands/queues.py: Ditto.
1738         * Scripts/webkitpy/tool/commands/upload.py: Ditto.
1739         * Scripts/webkitpy/tool/steps/closebug.py: Ditto.
1740         * Scripts/webkitpy/tool/steps/obsoletepatches.py: Ditto.
1741         * Scripts/webkitpy/tool/steps/preparechangelog.py: Ditto.
1742         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: Ditto.
1743
1744 2010-09-27  Adam Barth  <abarth@webkit.org>
1745
1746         Reviewed by Eric Seidel.
1747
1748         Expose more more failure information from Buildbot to SheriffBot
1749         https://bugs.webkit.org/show_bug.cgi?id=46697
1750
1751         This patch moves the information about what tests failured closer to
1752         SheriffBot.  There are still a couple more patches to go before
1753         SheriffBot can post this information to bugs, but this is a step in
1754         that direction.  Yay for unit tests, which caught some bugs in earlier
1755         versions of this patch.
1756
1757         * Scripts/webkitpy/common/net/buildbot.py:
1758         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1759         * Scripts/webkitpy/common/net/regressionwindow.py: Added.
1760         * Scripts/webkitpy/tool/commands/queries.py:
1761
1762 2010-09-27  Eric Seidel  <eric@webkit.org>
1763
1764         Unreviewed.  Fixing 500 error seen in the status server.
1765
1766         It turns out that a = b = []; b.append(1); then a[0] will be 1!
1767         This should have been obvious to me, I guess, but it was not what I was expecting.
1768
1769         * QueueStatusServer/model/activeworkitems.py:
1770
1771 2010-09-27  Adam Barth  <abarth@webkit.org>
1772
1773         Reviewed by Eric Seidel.
1774
1775         commit-queue should reject patches that fail to land
1776         https://bugs.webkit.org/show_bug.cgi?id=46694
1777
1778         This can happen, for example, if there's no reviewer.  Without this
1779         patch, we'll keep retrying the patch.
1780
1781         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1782         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1783
1784 2010-09-27  Simon Fraser  <simon.fraser@apple.com>
1785
1786         Rubber-stamped by Adele Peterson.
1787
1788         Add a harness for running the CSS 2.1 test suite.
1789
1790         This harness assumes that you've got a local a copy of the suite
1791         adjacent to the 'harness' directory.
1792
1793         The harness lets you go through the tests in chapter order,
1794         denoting pass/fail/skipped for each test.
1795
1796         It uses a client-side database to store the results of testing.
1797
1798         * CSSTestSuiteHarness/harness/harness.css: Added.
1799         * CSSTestSuiteHarness/harness/harness.html: Added.
1800         * CSSTestSuiteHarness/harness/harness.js: Added.
1801
1802 2010-09-27  Eric Seidel  <eric@webkit.org>
1803
1804         Reviewed by Adam Barth.
1805
1806         Patch locks should expire if a patch is marked for retry
1807         https://bugs.webkit.org/show_bug.cgi?id=46682
1808
1809         This was part Adam's original CommitQueueTask design,
1810         but support for it was missing from the server.
1811         I added the support, but triggering lock-release based on this
1812         special "retry" status feels a bit strange so I added a FIXME.
1813
1814         I also changed the text in queuestatus.html to say "Lock Acquired"
1815         since "Last Activity" isn't really true.  We only update the lock
1816         date when the patch is started, not on every status update.
1817
1818         I also noticed an exception in next-patch, which I fixed by re-writing
1819         the unzip logic in activeworkitems.py again.
1820
1821         * QueueStatusServer/handlers/updatestatus.py:
1822         * QueueStatusServer/model/activeworkitems.py:
1823         * QueueStatusServer/templates/queuestatus.html:
1824
1825 2010-09-27  Tony Chang  <tony@chromium.org>
1826
1827         Reviewed by David Levin.
1828
1829         [chromium] fix a warning when compiling DRT on 32-bit linux
1830         https://bugs.webkit.org/show_bug.cgi?id=46641
1831
1832         * DumpRenderTree/chromium/TestEventPrinter.cpp:
1833         (DRTPrinter::handleImage):
1834
1835 2010-09-27  Eric Seidel  <eric@webkit.org>
1836
1837         Reviewed by Adam Barth.
1838
1839         queue-status should report when the patch was last locked to a queue
1840         https://bugs.webkit.org/show_bug.cgi?id=46674
1841
1842         This isn't necessarily the best way to expose this information
1843         but having this accessible via the web interface is very
1844         useful until we come up with a nicer way to display this.
1845
1846         I also cleaned up the code in activeworkitems.py a little
1847         to use list comprehensions and to have the code work with
1848         pairs instead of two lists at once.  Eventually I think those
1849         item/time pairs need to be their own little helper class.
1850
1851         * QueueStatusServer/handlers/queuestatus.py:
1852         * QueueStatusServer/model/activeworkitems.py:
1853         * QueueStatusServer/templates/queuestatus.html:
1854
1855 2010-09-27  Tony Chang  <tony@chromium.org>
1856
1857         Reviewed by David Levin.
1858
1859         [chromium] fix detection of missing fonts on DRT
1860         https://bugs.webkit.org/show_bug.cgi?id=46651
1861
1862         * DumpRenderTree/chromium/TestShellGtk.cpp:
1863         (setupFontconfig):  Only print an error message if lohit isn't found in both locations.
1864
1865 2010-09-27  Tony Chang  <tony@chromium.org>
1866
1867         Reviewed by Dimitri Glazkov.
1868
1869         add webkit unit tests to the chromium testers
1870         https://bugs.webkit.org/show_bug.cgi?id=46669
1871
1872         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1873         * Scripts/run-chromium-webkit-unit-tests: Fix a bug where we weren't using the right configuration.
1874
1875 2010-09-27  Kwang Yul Seo  <skyul@company100.net>
1876
1877         Unreviewed.
1878
1879         Adding myself to the committers list.
1880
1881         * Scripts/webkitpy/common/config/committers.py:
1882
1883 2010-09-27  Mihai Parparita  <mihaip@chromium.org>
1884
1885         Reviewed by Eric Seidel.
1886
1887         webkitpy.common.system.user_unittest.UserTest.test_prompt_with_list spams the console
1888         https://bugs.webkit.org/show_bug.cgi?id=46634
1889
1890         Use OutputCapture to prevent console spam (and also check for expected
1891         output).
1892
1893         * Scripts/webkitpy/common/system/user_unittest.py:
1894
1895 2010-09-27  Eric Seidel  <eric@webkit.org>
1896
1897         Reviewed by James Robinson.
1898
1899         start-commit-queue should abort any rebases in progress
1900         https://bugs.webkit.org/show_bug.cgi?id=46640
1901
1902         webkit-patch commit-queue would do this itself, but this just
1903         helps ensure that the commit-queue script is properly updated
1904         before we run it (in the case where a previous rebase is in
1905         progress the git svn rebase would not work before we run the
1906         commit-queue).
1907
1908         * EWSTools/start-commit-queue.sh:
1909
1910 2010-09-18  Martin Robinson  <mrobinson@igalia.com>
1911
1912         Reviewed by Gustavo Noronha Silva.
1913
1914         [GTK] Clean up the DRT fonts.conf and switch to Liberation
1915         https://bugs.webkit.org/show_bug.cgi?id=46038
1916
1917         Switch to Liberation fonts for GTK+ layout tests. This will make our
1918         test results metric-compatible with many Windows/Chromium results. It
1919         also simplifies the fonts.conf that we load and prepares the way for
1920         fixing many font bugs.
1921
1922         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1923         (initializeFonts): Initialize a known list of fonts instead of loading
1924         every font in the WEBKIT_TESTFONTS directory.
1925         * DumpRenderTree/gtk/fonts.conf: Removed.
1926         * DumpRenderTree/gtk/fonts/AHEM____.TTF: Copied from WebKitTools/DumpRenderTree/qt/fonts/AHEM____.TTF.
1927         * DumpRenderTree/gtk/fonts/fonts.conf: Added.
1928         * GNUmakefile.am: Modify FONTS_CONF_FILE to be FONTS_CONF_DIR, so that
1929         we can load both fonts.conf and AHEM____.TTF from this location.
1930         * Scripts/old-run-webkit-tests: Remove the check for WEBKIT_TESTFONTS, since
1931         it is no longer used.
1932
1933 2010-09-26  Mihai Parparita  <mihaip@chromium.org>
1934
1935         Reviewed by Ojan Vafai.
1936
1937         new-run-webkit-httpd fails if Perl is not installed
1938         https://bugs.webkit.org/show_bug.cgi?id=46602
1939
1940         Make Port._read_configuration catch all exceptions, since trying to run
1941         perl (because of _webkit_build_directory) when it's not installed throws
1942         a WindowsError or OSError, not an IOError (this became an issue after
1943         r68268, since ChromiumPort ends up calling Port.default_configuration in
1944         its constructor, which means that we're ending up on this codepath in
1945         non-NRWT cases too, e.g. for the Chromium NaCl tests, which use
1946         new-run-webkit-httpd).
1947
1948         * Scripts/webkitpy/layout_tests/port/base.py:
1949         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1950
1951 2010-09-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1952
1953         Reviewed by Antonio Gomes.
1954
1955         [EFL] Add setting API to set a local storage database path.
1956         https://bugs.webkit.org/show_bug.cgi?id=45446
1957
1958         Add a setting API to set local storage database path.
1959
1960         * EWebLauncher/main.c:
1961         (on_key_down):
1962         (browserCreate):
1963         (main):
1964
1965 2010-09-26  Sam Weinig  <sam@webkit.org>
1966
1967         Reviewed by Anders Carlsson.
1968
1969         Move shared WebKit2 API (used by both bundle and main API) to WebKit2/Shared/API
1970         https://bugs.webkit.org/show_bug.cgi?id=46587
1971
1972         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1973
1974 2010-09-26  Antonio Gomes  <agomes@rim.com>
1975
1976         Reviewed by Kenneth Rohde Christiansen.
1977
1978         DRT/Mac nodesFromRect support
1979
1980         [Mac][DRT] Implement LayoutTestController::nodesFromRect
1981         https://bugs.webkit.org/show_bug.cgi?id=46580
1982
1983         Implements LayoutTestController::nodesFromRect for Mac DRT, and
1984         adding stubs for GTK+ and Windows.
1985
1986         * DumpRenderTree/LayoutTestController.cpp:
1987         (nodesFromRectCallback):
1988         (LayoutTestController::staticFunctions):
1989         * DumpRenderTree/LayoutTestController.h:
1990         (LayoutTestController::LayoutTestController::nodesFromRect):
1991         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1992         (LayoutTestController::nodesFromRect):
1993
1994 2010-09-25  Nicolas Weber  <thakis@chromium.org>
1995
1996         Reviewed by Adam Barth.
1997
1998         https://bugs.webkit.org/show_bug.cgi?id=46555
1999         Fix typo in prepare-ChangeLog's help output.
2000
2001         * Scripts/prepare-ChangeLog:
2002
2003 2010-09-24  Sam Weinig  <sam@webkit.org>
2004
2005         Reviewed by Darin Adler.
2006
2007         Implement WebKit2 callback equivalent to -[WebUIDelegate mouseDidMoveOverElement:modifierFlags:]
2008         <rdar://problem/8359279>
2009         https://bugs.webkit.org/show_bug.cgi?id=46546
2010
2011         * MiniBrowser/mac/BrowserWindowController.m:
2012         (mouseDidMoveOverElement):
2013         (-[BrowserWindowController awakeFromNib]):
2014         * MiniBrowser/win/BrowserView.cpp:
2015         (mouseDidMoveOverElement):
2016         (BrowserView::create):
2017         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2018         (WTR::InjectedBundlePage::InjectedBundlePage):
2019         * WebKitTestRunner/TestController.cpp:
2020         (WTR::createOtherPage):
2021         (WTR::TestController::initialize):
2022
2023 2010-09-24  Mihai Parparita  <mihaip@chromium.org>
2024
2025         Reviewed by Adam Barth.
2026
2027         Allow rebaselines for webkit-patch rebaseline to be chosen
2028         https://bugs.webkit.org/show_bug.cgi?id=46407
2029
2030         Instead of always rebaselining all failing tests, allow a subset to be
2031         chosen.
2032
2033         * Scripts/webkitpy/common/system/user.py:
2034         * Scripts/webkitpy/tool/commands/rebaseline.py:
2035
2036 2010-09-24  Ryosuke Niwa  <rniwa@webkit.org>
2037
2038         Reviewed by Tony Chang.
2039
2040         [chromium] Implement TextInputController::firstRectForCharacterRange
2041         https://bugs.webkit.org/show_bug.cgi?id=38100
2042
2043         Implemented TextInputController::firstRectForCharacterRange for chromium platform.
2044         No new tests are added since we need to implement the same feature in chromium side
2045         in order to enable any tests that uses this function.
2046
2047         * DumpRenderTree/chromium/TextInputController.cpp:
2048         (TextInputController::firstRectForCharacterRange): Added.
2049
2050 2010-09-24  Adam Barth  <abarth@webkit.org>
2051
2052         Reviewed by Eric Seidel.
2053
2054         commit-queue reports land failures as "PASS"
2055         https://bugs.webkit.org/show_bug.cgi?id=46530
2056
2057         We were ignoring the return value of land instead of passing it back to
2058         CommitQueue.  Of course, this was the one case I forgot to test!
2059
2060         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2061         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2062
2063 2010-09-24  Kenichi Ishibashi  <bashi@google.com>
2064
2065         Reviewed by Eric Seidel.
2066
2067         new-run-webkit-tests prints out nothing when build-dumprendertree fails
2068         https://bugs.webkit.org/show_bug.cgi?id=37563
2069
2070         Print error message when build-dumprendertree fails.
2071
2072         * Scripts/webkitpy/layout_tests/port/webkit.py:
2073         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2074
2075 2010-09-24  Mihai Parparita  <mihaip@chromium.org>
2076
2077         Reviewed by Tony Chang.
2078
2079         NRWT doesn't respect config set with set-webkit-configuration
2080         https://bugs.webkit.org/show_bug.cgi?id=46278
2081
2082         Use Port.default_configuration() instead of hardcoding Release in
2083         ChromiumPort configuration initialization, so that we still inherit the
2084         configuration set by set-webkit-configuration.
2085
2086         * Scripts/webkitpy/layout_tests/port/chromium.py:
2087         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2088
2089 2010-09-24  Chang Shu  <chang.shu@nokia.com>
2090
2091         Reviewed by Csaba Osztrogonác.
2092
2093         [Qt] Fix the code to check file existence.
2094         https://bugs.webkit.org/show_bug.cgi?id=46465
2095
2096         * QtTestBrowser/main.cpp:
2097         (main):
2098
2099 2010-09-23  Tony Chang  <tony@chromium.org>
2100
2101         Unreviewed, rolling out r68232.
2102         http://trac.webkit.org/changeset/68232
2103
2104         Broken NRWT on the canary bots.
2105
2106         * Scripts/webkitpy/layout_tests/port/chromium.py:
2107
2108 2010-09-23  Dirk Pranke  <dpranke@chromium.org>
2109
2110         Unreviewed, build fix.
2111
2112         r68008 broke new-run-webkit-tests in that the chromium ports no
2113         longer respect set-webkit-configuration. The correct fix for this
2114         is being pursued in bug 46278 (along with a bunch of unit tests),
2115         but in the meantime I'm reverting the particular lines that broke
2116         things. This was tested by hand.
2117
2118         * Scripts/webkitpy/layout_tests/port/chromium.py:
2119
2120 2010-09-23  Sam Weinig  <sam@webkit.org>
2121
2122         Reviewed by Anders Carlsson.
2123
2124         WebKit2 API: Need way to know when a frame is removed from the hierarchy
2125         <rdar://problem/8414062>
2126         https://bugs.webkit.org/show_bug.cgi?id=46432
2127
2128         * MiniBrowser/mac/BrowserWindowController.m:
2129         (didRemoveFrameFromHierarchy):
2130         (-[BrowserWindowController awakeFromNib]):
2131         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2132         (WTR::InjectedBundlePage::InjectedBundlePage):
2133         * WebKitTestRunner/TestController.cpp:
2134         (WTR::TestController::initialize):
2135
2136 2010-09-23  Tony Chang  <tony@chromium.org>
2137
2138         Reviewed by Dimitri Glazkov.
2139
2140         [chromium] implement layoutTestController.sampleSVGAnimationForElementAtTime
2141         https://bugs.webkit.org/show_bug.cgi?id=46426
2142
2143         * DumpRenderTree/chromium/LayoutTestController.cpp:
2144         (LayoutTestController::LayoutTestController):
2145         (LayoutTestController::sampleSVGAnimationForElementAtTime):
2146         * DumpRenderTree/chromium/LayoutTestController.h:
2147
2148 2010-09-23  Martin Robinson  <mrobinson@igalia.com>
2149
2150         Reviewed by Nate Chapin.
2151
2152         [GTK] r68199 introduced two test failures
2153         https://bugs.webkit.org/show_bug.cgi?id=46424
2154
2155         Fix a regression handling preference overrides that are attached to boolean properties.
2156
2157         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2158         (LayoutTestController::overridePreference): g_strcasecmp returns 0 when strings match
2159         so we must check for that when converting a string to a boolean.
2160
2161 2010-09-23  Dimitri Glazkov  <dglazkov@chromium.org>
2162
2163         Reviewed by David Levin.
2164
2165         Fix a condition check in ServerProcess, which becomes relevant when reading binary data.
2166         https://bugs.webkit.org/show_bug.cgi?id=46406
2167
2168         This breaks when the method is called with specified size of data (image data), and the
2169         buffer hasn't yet reached this size.
2170
2171         * Scripts/webkitpy/layout_tests/port/server_process.py: Changed to check for values of
2172           index larger than 0.
2173
2174 2010-09-23  Martin Robinson  <mrobinson@igalia.com>
2175
2176         Reviewed by Nate Chapin.
2177
2178         [GTK] Some tests from r68174 fail on the GTK+ bots
2179         https://bugs.webkit.org/show_bug.cgi?id=46396
2180
2181         Simplify LayoutTestController::overridePreference to make it easier for
2182         people unfamiliar with the code to keep the list of preferences up to date.
2183         Add the conversion for enable-hyperlink-auditing.
2184
2185         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2186         (LayoutTestController::overridePreference): Use a simple if-else block to determine
2187         out the property name for overrridePreference. Also simplify the logic for setting
2188         string properties. Add the conversion for enable-hyperlink-auditing.
2189
2190 2010-09-23  Tony Chang  <tony@chromium.org>
2191
2192         Reviewed by David Levin.
2193
2194         [chromium] add caretBrowsingEnabled to WebSettings and DRT
2195         https://bugs.webkit.org/show_bug.cgi?id=46388
2196
2197         * DumpRenderTree/chromium/LayoutTestController.cpp:
2198         (LayoutTestController::overridePreference):
2199         * DumpRenderTree/chromium/WebPreferences.cpp:
2200         (WebPreferences::reset):
2201         (WebPreferences::applyTo):
2202         * DumpRenderTree/chromium/WebPreferences.h:
2203
2204 2010-09-23  Nate Chapin  <japhet@chromium.org>
2205
2206         Reviewed by Darin Fisher.
2207
2208         Allow DRT to toggle hyperlink auditing (i.e., <a ping>).
2209         https://bugs.webkit.org/show_bug.cgi?id=30458
2210
2211         * DumpRenderTree/chromium/LayoutTestController.cpp:
2212         (LayoutTestController::overridePreference):
2213         * DumpRenderTree/chromium/WebPreferences.cpp:
2214         (WebPreferences::reset):
2215         (WebPreferences::applyTo):
2216         * DumpRenderTree/chromium/WebPreferences.h:
2217         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2218         (resetDefaultsToConsistentValues):
2219         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2220         (LayoutTestController::overridePreference):
2221
2222 2010-09-21  Stephen White  <senorblanco@chromium.org>
2223
2224         Reviewed by David Levin.
2225
2226         Implement --enable-accelerated-2d-canvas flag in DumpRenderTree.
2227         https://bugs.webkit.org/show_bug.cgi?id=46208
2228
2229         This flag allows the layout tests to be run with or without accelerated
2230         2D canvas rendering.
2231
2232         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2233         (main):
2234         Declare the new flag string, and check for it on startup.
2235         * DumpRenderTree/chromium/TestShell.cpp:
2236         (TestShell::TestShell):
2237         Add a boolean for the new flag, in order to preserve its value over
2238         preferences reset.
2239         (TestShell::resetWebSettings):
2240         Set the new flag to the stored value on reset.
2241         * DumpRenderTree/chromium/TestShell.h:
2242         (TestShell::setAccelerated2dCanvasEnabled):
2243         Add an accessor for the new flag.
2244         * DumpRenderTree/chromium/WebPreferences.cpp:
2245         (WebPreferences::reset):
2246         Initialize the new flag to false.
2247         (WebPreferences::applyTo):
2248         Copy the flag's value to the WebSettings.
2249         * DumpRenderTree/chromium/WebPreferences.h:
2250         Add the new flag.
2251
2252 2010-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2253
2254         Reviewed by Simon Hausmann.
2255
2256         [Qt] Refactor QtWebKitPlatformPlugin interface
2257
2258         Make it easier to keep source-compability for the
2259         QtWebKitPlatformPlugin interface, and run qmake
2260         on the example (but not build) for convenience.
2261
2262         https://bugs.webkit.org/show_bug.cgi?id=46345
2263
2264         * Scripts/webkitdirs.pm:
2265
2266 2010-09-23  Adam Barth  <abarth@webkit.org>
2267
2268         Reviewed by Eric Seidel.
2269
2270         Tweak some status messages that Eric thought were confusing
2271         https://bugs.webkit.org/show_bug.cgi?id=46342
2272
2273         * Scripts/webkitpy/tool/commands/queues.py:
2274         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2275
2276 2010-09-22  Adam Barth  <abarth@webkit.org>
2277
2278         Reviewed by Eric Seidel.
2279
2280         Fix comm-queue typo
2281         https://bugs.webkit.org/show_bug.cgi?id=46339
2282
2283         We were missing a "self".  The real problem is that we didn't have an
2284         integration test for the failure case.
2285
2286         * Scripts/webkitpy/tool/commands/queues.py:
2287         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2288
2289 2010-09-22  Adam Barth  <abarth@webkit.org>
2290
2291         Reviewed by Eric Seidel.
2292
2293         commit-queue should log more detailed messages to the QueueStatusServer
2294         https://bugs.webkit.org/show_bug.cgi?id=46333
2295
2296         When I created CommitQueueTask, I removed most of the previous logging.
2297         This patch adds back more detailed logging so folks can see their patch
2298         progress through the queue.
2299
2300         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2301         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2302         * Scripts/webkitpy/tool/commands/queues.py:
2303         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2304
2305 2010-09-22  Mihai Parparita  <mihaip@chromium.org>
2306
2307         Reviewed by Darin Fisher.
2308
2309         [Chromium] User style layout tests don't pass on Chromium
2310         https://bugs.webkit.org/show_bug.cgi?id=46069
2311
2312         Fix a typo in LayoutTestController::addUserStyleSheet that was causing a
2313         crash the Chromium DRT. Pass InjectInExistingDocuments to mimic DRT
2314         behavior from other ports.
2315
2316         * DumpRenderTree/chromium/LayoutTestController.cpp:
2317         (LayoutTestController::addUserStyleSheet):
2318
2319 2010-09-22  Brent Fulgham  <bfulgham@webkit.org>
2320
2321         Reviewed by Martin Robinson.
2322
2323         [WinCairo] Part 2: Update WebKitTestRunner and DumpRenderTree Build.
2324         https://bugs.webkit.org/show_bug.cgi?id=46303.
2325
2326         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added.
2327         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Moved
2328         CoreFoundation-specific stuff to new MiniBrowserCoreFoundation
2329         property sheet.
2330         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added.
2331         * MiniBrowser/MiniBrowser.vcproj: Updated configuration to use
2332         appropriate property sheet for the build types.
2333         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Updated the
2334         configuration to use appropriate property sheet for CoreFoundation
2335         and CFLite-style builds.
2336
2337 2010-09-22  Adam Barth  <abarth@webkit.org>
2338
2339         Reviewed by Eric Seidel.
2340
2341         Optimize commit-queue performance for green trees
2342         https://bugs.webkit.org/show_bug.cgi?id=46254
2343
2344         This patch redesigns the controller logic for the commit-queue.  In the
2345         new design, the controller exercises much finer-grained control over
2346         the landing process.  In particular:
2347
2348         - Patches that fail to apply now get rejected almost immediately.
2349         - Patches that fail to build get rejects after two builds (instead of
2350           three builds and one test run).
2351         - Patches that run into a flaky test now get accepted after one build
2352           and two test runs instead of three full build-and-test runs.
2353
2354         The main cost of these optimizations is that we don't find out the tree
2355         has a failing test until the very end of the process, but if the tree
2356         has a busted test, there's not much we can do anyway.  We might as well
2357         burn commit-queue resources spinning optimisticly.
2358
2359         * Scripts/webkitpy/tool/bot/commitqueuetask.py: Added.
2360         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: Added.
2361         * Scripts/webkitpy/tool/commands/queues.py:
2362
2363 2010-09-22  Brent Fulgham  <bfulgham@webkit.org>
2364
2365         Reviewed by Martin Robinson.
2366
2367         [WinCairo] Update WebKitTestRunner and DumpRenderTree Build.
2368         https://bugs.webkit.org/show_bug.cgi?id=46303.
2369
2370         * DumpRenderTree/win/DumpRenderTree.vcproj: Disable local MD5 sources
2371         for Cairo build. Copy wtf MD5 header to ForwardingHeaders for the
2372         WinCairo build.
2373         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added.
2374         * WebKitTestRunner/win/InjectedBundle.vcproj: Update win new *_Cairo
2375         build targets that use the new InjectedBundleCFLite.vsprops file.
2376
2377 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
2378
2379         Unreviewed, build fix.
2380
2381         Fix bustage of rebaseline-chromium-webkit-tests resulting from
2382         r67974. Really need better unit tests for this tool :(
2383
2384         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2385
2386 2010-09-22  Adam Roben  <aroben@apple.com>
2387
2388         Unbreak test-webkitpy
2389
2390         * Scripts/webkitpy/test/main.py:
2391         (Tester.run_tests): Add a line that mysteriously got deleted.
2392
2393 2010-09-22  Adam Roben  <aroben@apple.com>
2394
2395         Make test-webkitpy test WebKit2's scripts
2396
2397         These scripts can't be in WebKitTools due to limitations of Apple's
2398         build process. But that doesn't mean we can't test them!
2399
2400         Fixes <http://webkit.org/b/46297> test-webkitpy should test code in
2401         WebKit2/Scripts
2402
2403         Reviewed by Adam Barth.
2404
2405         * Scripts/test-webkitpy:
2406         (_clean_packages_with_test): Renamed from _clean_webkitpy_with_test.
2407         Now takes an external_package_paths parameter and cleans both webkitpy
2408         and any external packages.
2409         (init): Added an external_package_paths parameter which we pass along
2410         to _clean_packages_with_test.
2411         (top level): Add WebKit2/Scripts/webkit2 as our only external package
2412         and pass it along to init and Tester.run_tests.
2413
2414         * Scripts/webkitpy/test/main.py:
2415         (Tester.run_tests): Added an optional external_package_paths
2416         parameter. We modify sys.path so that the external packages can be
2417         imported, and search for unittest files inside all external packages
2418         in addition to inside webkitpy.
2419
2420 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
2421
2422         Reviewed by Tony Chang.
2423
2424         new-run-webkit-tests: r68063 broke linux python tests
2425
2426         Add a missing "from __future__ import with_statement" to this
2427         new file; the perils of testing only on the Mac and by review :(
2428
2429         https://bugs.webkit.org/show_bug.cgi?id=46293
2430
2431         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2432
2433 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
2434
2435         Reviewed by Tony Chang.
2436
2437         Add a 'chromium-gpu' set of ports that will test the accelerated
2438         GPU paths. This patch adds:
2439
2440         - support for the '--accelerated-compositing' and
2441           'accelerated-2d-canvas' flags to new-run-webkit-tests (and the
2442           'no-' flags)
2443         - adds a new set of Ports that will look under
2444           platform/chromium-gpu-$OS/ for baselines before looking in the
2445           regular chromium search path
2446         - adds a new test_expectations.txt file in platform/chromium-gpu
2447           that skips all but the tests we actually want to run with
2448           acceleration.
2449
2450         This patch will allow us to run both with and without acceleration
2451         and to change the defaults for both the regular and -gpu options
2452         as the code evolves.
2453
2454         We plan to add both --chromium-$OS and --chromium-gpu-$OS runs to
2455         each test bot.
2456
2457         https://bugs.webkit.org/show_bug.cgi?id=46225
2458
2459         * Scripts/webkitpy/layout_tests/port/chromium.py:
2460         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2461         * Scripts/webkitpy/layout_tests/port/factory.py:
2462         * Scripts/webkitpy/layout_tests/port/webkit.py:
2463
2464 2010-09-22  Jamey Hicks  <jamey.hicks@nokia.com>
2465
2466         Reviewed by Kenneth Rohde Christiansen.
2467
2468         [Qt] Web Inspector: Remote Web Inspector support for QtWebKit
2469         https://bugs.webkit.org/show_bug.cgi?id=43988
2470
2471         Runs a web debug server on port specified by QtTestBrowser
2472         argument -remote-inspector-port. Property
2473         _q_webInspectorServerPort of the QWebPage instance will be set
2474         according to the argument. All pages with that property set will
2475         be remotely inspectable.
2476
2477         URL for remote inspection of first QWebPage is
2478             http://localhost:9222/webkit/inspector/inspector.html?page=1
2479         where 1 is the number of the QWebPage instance.
2480
2481         The base URL yields an index page with links to the individual inspectors:
2482             http://localhost:9222/
2483
2484         * QtTestBrowser/launcherwindow.cpp:
2485         (LauncherWindow::init):
2486         * QtTestBrowser/launcherwindow.h:
2487         * QtTestBrowser/main.cpp:
2488         (LauncherApplication::handleUserOptions):
2489
2490 2010-09-22  Adam Roben  <aroben@apple.com>
2491
2492         Fix webkit-patch failure-reason now that build.webkit.org has been
2493         updated
2494
2495         Fixes <http://webkit.org/b/46273> webkit-patch failure-reason crashes
2496         every time
2497
2498         Reviewed by Eric Seidel.
2499
2500         * Scripts/webkitpy/common/net/buildbot.py:
2501         (BuildBot._file_cell_text): Added. Travels down the firstChild chain
2502         looking for an element that contains text, then returns it.
2503         (BuildBot._parse_twisted_file_row): Use _file_cell_text to get the
2504         text out of the cells. This way it doesn't matter whether the cells
2505         have <b> children (as for cells in directory rows) or not (as for
2506         cells in file rows)
2507         (BuildBot._parse_twisted_directory_listing): Look for rows that have
2508         the "directory" or "file" class, rather than rows with any class,
2509         since header rows now have a class attribute.
2510
2511         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2512         (BuildBotTest._example_directory_listing): Updated to more closely
2513         match the markup that build.webkit.org is producing now.
2514
2515 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2516
2517         Unreviewed, build fix.
2518
2519         new-run-webkit-tests: fix bug introduced in r68008 where if you
2520         specify --chromium and no --platform, and you're running on
2521         windows, you use the 'chromium-win' port by default instead of the
2522         version-specific port. This breaks the buildbots.
2523
2524         It will be good for this refactoring to settle down so I can
2525         rewrite the logic for default ports and the unit tests to be
2526         clearer (and the testing more comprehensive).
2527
2528         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2529
2530 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2531
2532         Reviewed by Adam Barth.
2533
2534         Modify the Port interface to take only a series of keyword arguments
2535         in the constructor, and modify Port/factory.get() to accomodate that,
2536         and to accept user=XXX as an argument so we can pass
2537         webkitpy.common.system.user.User objects in.
2538
2539         Then, modify new-run-webkit-tests and rebaseline-chromium-webkit-tests
2540         to use the common routine in webkitpy.common.system.user.open_url()
2541         to display HTML files.
2542
2543         There was a routine in the Port interface to do the same thing,
2544         but I see no need for a port-specific hook for this, since it is
2545         something that will always be executed by the host environment
2546         and displaying web pages has nothing to do with running layout tests.
2547
2548         Note that new-run-webkit-tests used to use test_shell to display
2549         the page; this is potentially useful so that you can actually click
2550         from a result to the broken page; however, since DumpRenderTree
2551         doesn't support this functionality, it will be going away eventually.
2552
2553         https://bugs.webkit.org/show_bug.cgi?id=46128
2554
2555         * Scripts/webkitpy/layout_tests/port/base.py:
2556         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2557         * Scripts/webkitpy/layout_tests/port/chromium.py:
2558         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2559         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2560         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2561         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2562         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2563         * Scripts/webkitpy/layout_tests/port/factory.py:
2564         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2565         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2566         * Scripts/webkitpy/layout_tests/port/gtk.py:
2567         * Scripts/webkitpy/layout_tests/port/mac.py:
2568         * Scripts/webkitpy/layout_tests/port/qt.py:
2569         * Scripts/webkitpy/layout_tests/port/test.py:
2570         * Scripts/webkitpy/layout_tests/port/webkit.py:
2571         * Scripts/webkitpy/layout_tests/port/win.py:
2572         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2573         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2574         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2575
2576 2010-09-21  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2577
2578         Reviewed by Kenneth Rohde Christiansen.
2579
2580         [EFL] Get fresh theme when running EWebLauncher
2581         https://bugs.webkit.org/show_bug.cgi?id=46210
2582
2583         If user tried to run EWebLauncher outside of the build tree, it would
2584         not find the theme and fallback to the installed one. However, since
2585         EWebLauncher is not installed, we always want to take the theme from
2586         the just compiled source code. If user had never installed WebKit's
2587         EFL port it could even receive a segv since no theme would be found.
2588
2589         Now EWebLauncher does not fallback to the installed theme and CMake
2590         gives as DATA_DIR the directory of the theme it has just built.
2591
2592         * CMakeListsEfl.txt: Pass the build directory as DATA_DIR to
2593         EWebLauncher.
2594         * EWebLauncher/main.c: Use only the theme from build director. Do not
2595         fallback to others as this could hide real bugs.
2596         (quit):
2597         (browserCreate):
2598         (findThemePath):
2599         (main):
2600
2601 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2602
2603         Unreviewed, build fix.
2604
2605         Don't pass the --test-shell arg to the Chromium Mac port of DRT;
2606         it just confuses it.
2607
2608         https://bugs.webkit.org/show_bug.cgi?id=46230
2609
2610         * Scripts/webkitpy/layout_tests/port/webkit.py:
2611
2612 2010-09-21  Lucas Forschler  <lforschler@apple.com>
2613
2614         Reviewed by Stephanie Lewis.
2615
2616         Make a new buildbot for Leopard Debug Test
2617
2618         * BuildSlaveSupport/build.webkit.org-config/config.json:
2619
2620 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2621
2622         Unreviewed, build fix.
2623
2624         Fix breakage of Chromium Mac DRT port caused by r67905.
2625
2626         https://bugs.webkit.org/show_bug.cgi?id=46230
2627
2628         * Scripts/webkitpy/layout_tests/port/webkit.py:
2629
2630 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2631
2632         Unreviewed, build fix.
2633
2634         Add missing import of 'tempfile'.
2635
2636         * Scripts/webkitpy/layout_tests/port/chromium.py:
2637
2638 2010-09-17  Dirk Pranke  <dpranke@chromium.org>
2639
2640         Reviewed by Ojan Vafai.
2641
2642         new-run-webkit-tests: pull the list of tests from the Port, and
2643            make it possible to run with no actual test files in the filesystem.
2644
2645         This set of changes allows us to delete the special
2646         webkitpy/layout_tests/data directory and test the generic code without
2647         touching the filesystem (except to write results). This speeds up
2648         test-webkitpy substantially.
2649
2650         This also cleans up and removes several code paths in the generic
2651         code and fixes some minor bugs, notably in the test_expectations
2652         parsing, which was previously fragile if the tests weren't present.
2653
2654         We also change the way we diff image results to be able to do so
2655         in memory, without relying on files. This slows down chromium
2656         test_shell, which always writes images to files, but should speed
2657         up DRT and ImageDiff-based implementations slightly.
2658
2659         Note that pulling the list of tests to run from the Port will allow
2660         ports to specify what tests to run as an inclusive list; previously
2661         you could only do this as an exclusive list by using a
2662         test_expectations file or Skipped files; nothing actually uses this
2663         feature yet and it's unclear if it should be used.
2664
2665         Note that there are no functional changes -- apart from now
2666         always printing out the location of the checksum file when we are
2667         tracing test runs -- and the total number of lines of non-test code
2668         actually drops by two.
2669
2670         There is some more cleanup that can be done in the Port/Driver
2671         interface and in some handling of filenames, but I'll save that
2672         for another change.
2673
2674         https://bugs.webkit.org/show_bug.cgi?id=45801
2675
2676         * Scripts/webkitpy/layout_tests/data/*: Removed.
2677             - no longer need special mock layout_tests_directory in the
2678               repository.
2679         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2680             - add code to display missing text files, checksums when tracing
2681             - update to not look at the filesystem directly.
2682         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2683             - add more unit tests
2684         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2685             - remove tests_are_present flag
2686             - update with changes in Port interface - no longer access
2687               the filesystem directly, although we still use os.path for
2688               filename manipulation.
2689         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2690             - add more unit tests
2691         * Scripts/webkitpy/layout_tests/layout_package/test_files.py: Removed.
2692             - renamed to port/test_files.py
2693         * Scripts/webkitpy/layout_tests/port/base.py:
2694             - change diff_image() to expect actual image data, not filenames
2695             - add expected_checksum(), expected_image(), expected_text() to
2696               return the content of the files so that we don't need a filesystem
2697             - add path_exists(), path_isdir() for filesystem-like access.
2698             - add test_dirs() to keep clobber-test-results from needing to
2699               actually look at a real layout tests dir
2700             - add tests() to return the list of tests to run on the port
2701               (calls port/test_files to do the work).
2702             - add update_baseline() to be able to save new baselines
2703             - add uri_to_test_name() from port/dryrun.py so we can easily check
2704               filename_to_uri()
2705         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2706             - add more unit tests
2707         * Scripts/webkitpy/layout_tests/port/chromium.py:
2708             - change diff_image() to accept image content, not filenames.
2709               This will be slower for test_shell/image_diff, but faster
2710               for DRT/ImageDiff.
2711         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2712             - add more unit tests
2713         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2714             - simplify greatly
2715         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2716             - add more unit tests
2717         * Scripts/webkitpy/layout_tests/port/test.py:
2718             - massive rewrite to use in-script list of tests and expectations
2719         * Scripts/webkitpy/layout_tests/port/test_files.py:
2720             - rename from layout_package/test_files.
2721         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2722             - add unit tests
2723         * Scripts/webkitpy/layout_tests/port/webkit.py:
2724             - update diff_image() to take image contents, not files. Should
2725               make things slightly faster.
2726         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2727             - update with changes to diff_image()
2728         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2729             - update with changes to diff_image()
2730         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2731             - remove tests_are_present from test_expectations
2732             - pull the list of tests from port.tests() instead
2733               of calling test_files.py directly.
2734         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2735             - update unit tests
2736         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2737             - update with changes to
2738         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2739             - update with change in Port interface
2740         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2741             - update with change in Port interface
2742         * Scripts/webkitpy/style/checkers/test_expectations.py:
2743             - remove the tests_are_present flag
2744
2745 2010-09-21  Anders Carlsson  <andersca@apple.com>
2746
2747         Disable logging.
2748
2749         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2750
2751 2010-09-21  Tony Chang  <tony@chromium.org>
2752
2753         Reviewed by Kent Tamura.
2754
2755         add a script for running webkit_unit_tests
2756         https://bugs.webkit.org/show_bug.cgi?id=46014
2757
2758         * Scripts/run-chromium-webkit-unit-tests: Added.
2759
2760 2010-09-21  Fridrich Strba  <fridrich.strba@bluewin.ch>
2761
2762         Reviewed by Martin Robinson.
2763
2764         Fix linking problems on Windows.
2765         https://bugs.webkit.org/show_bug.cgi?id=45844
2766
2767         * GNUmakefile.am: link the executables with winmm.dll
2768
2769 2010-09-21  Adam Barth  <abarth@webkit.org>
2770
2771         Reviewed by Eric Seidel.
2772
2773         feeder-queue svn updates more often than needed
2774         https://bugs.webkit.org/show_bug.cgi?id=46171
2775
2776         We don't need to poll SVN every time we feed the feeders.  Rather, we
2777         can count on the wrapper shell script to auto-update the queue.
2778
2779         * Scripts/webkitpy/tool/commands/queues.py:
2780         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2781
2782 2010-09-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2783
2784         Reviewed by Andreas Kling.
2785
2786         [Qt] Add robot loader timeout and extra time options.
2787         https://bugs.webkit.org/show_bug.cgi?id=46172
2788
2789         [-robot-timeout <s>]: Load the next page after s seconds if the current
2790         page didn't finish loading.
2791         [-robot-extra-time <s>]: Wait s seconds after the current page finished
2792         loading before loading the next one. This should allow some time for the
2793         page's JavaScript to execute.
2794
2795         * QtTestBrowser/launcherwindow.cpp:
2796         (LauncherWindow::applyPrefs):
2797         * QtTestBrowser/main.cpp:
2798         (LauncherApplication::robotTimeout):
2799         (LauncherApplication::robotExtraTime):
2800         (LauncherApplication::LauncherApplication):
2801         (LauncherApplication::handleUserOptions):
2802         (main):
2803         * QtTestBrowser/urlloader.cpp:
2804         (UrlLoader::UrlLoader):
2805         (UrlLoader::loadNext):
2806         (UrlLoader::loadUrlList):
2807         * QtTestBrowser/urlloader.h:
2808
2809 2010-09-21  Pavel Podivilov  <podivilov@chromium.org>
2810
2811         Unreviewed.
2812
2813         Adding myself to the committers list.
2814
2815         * Scripts/webkitpy/common/config/committers.py:
2816
2817 2010-09-20  Philippe Normand  <pnormand@igalia.com>
2818
2819         Reviewed by Eric Carlson.
2820
2821         [GTK] enhanced context menu for media elements
2822         https://bugs.webkit.org/show_bug.cgi?id=45021
2823
2824         EventSender::contextClick() now returns an array of js
2825         objects. Each object has a title property and a click() method.
2826
2827         * DumpRenderTree/gtk/EventSender.cpp:
2828         (getMenuItemTitleCallback):
2829         (setMenuItemTitleCallback):
2830         (menuItemClickCallback):
2831         (getMenuItemClass):
2832         (contextClickCallback):
2833
2834 2010-09-20  Hayato Ito  <hayato@chromium.org>
2835
2836         Unreviewed.
2837         Adding myself to the committers list.
2838
2839         * Scripts/webkitpy/common/config/committers.py:
2840
2841 2010-09-20  Adam Barth  <abarth@webkit.org>
2842
2843         Reviewed by Eric Seidel.
2844
2845         The tool member variable should be called _tool
2846         https://bugs.webkit.org/show_bug.cgi?id=46160
2847
2848         Created by find-and-replace.
2849
2850         * Scripts/webkitpy/tool/commands/download.py:
2851         * Scripts/webkitpy/tool/commands/openbugs.py:
2852         * Scripts/webkitpy/tool/commands/queries.py:
2853         * Scripts/webkitpy/tool/commands/queues.py:
2854         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2855         * Scripts/webkitpy/tool/commands/rebaseline.py:
2856         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2857         * Scripts/webkitpy/tool/commands/upload.py:
2858         * Scripts/webkitpy/tool/multicommandtool.py:
2859
2860 2010-09-20  Adam Barth  <abarth@webkit.org>
2861
2862         I ran the tests before landing but ignored the fact that they failed.  :(
2863
2864         * Scripts/webkitpy/tool/commands/queues.py:
2865
2866 2010-09-20  Adam Barth  <abarth@webkit.org>
2867
2868         Reviewed by Eric Seidel.
2869
2870         Add a feeder queue that polls bugs.webkit.org for the commit-cluster
2871         https://bugs.webkit.org/show_bug.cgi?id=46141
2872
2873         The feeder-queue polls bugs.webkit.org every 30 seconds and updates the
2874         list of work items on the status server.  The individual commit-cluster
2875         nodes then grab the patches from the server and process them.
2876
2877         * Scripts/webkitpy/tool/bot/feeders.py: Added.
2878         * Scripts/webkitpy/tool/bot/feeders_unittest.py: Added.
2879         * Scripts/webkitpy/tool/commands/queues.py:
2880         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2881         * Scripts/webkitpy/tool/commands/queuestest.py:
2882
2883 2010-09-20  Leandro Pereira  <leandro@profusion.mobi>
2884
2885         Reviewed by Darin Adler.
2886
2887         build-webkit: Add support for CMake build system
2888         https://bugs.webkit.org/show_bug.cgi?id=44979
2889
2890         * Scripts/build-webkit: Add "--efl" command-line option to build the
2891         EFL port of WebKit.
2892         * Scripts/webkitdirs.pm: Define buildCMakeProject() and
2893         buildEflCMakeProject() subroutines.
2894
2895 2010-09-20  Dirk Pranke  <dpranke@chromium.org>
2896
2897         Reviewed by Ojan Vafai.
2898
2899         new-run-webkit-tests: refactor command line args getting passed to DRT
2900
2901         This change cleans up some argument parsing between functions to get
2902         rid of some overlapping data structures. There should be no functional
2903         changes in this patch; it is pure refactoring in preparation for
2904         landing the Chrome GPU port and adding a generic way to pass
2905         args to DRT/TestShell.
2906
2907         https://bugs.webkit.org/show_bug.cgi?id=46135
2908
2909         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2910           - pass the options argument explicitly to the threads and drivers,
2911             also consolidate the passing of options to the driver.
2912           - pass options directly to process_output() to remove a couple
2913             parameters (minor cleanup).
2914         * Scripts/webkitpy/layout_tests/port/base.py:
2915           - pass the options argument to Port.create_driver().
2916         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2917           - update Port.create_driver() test
2918         * Scripts/webkitpy/layout_tests/port/chromium.py:
2919           - pass the options argument to Port.create_driver(), and clean up
2920             building of the cmd line for DRT.
2921         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2922           - pass the options argument to Port.create_driver()
2923         * Scripts/webkitpy/layout_tests/port/test.py:
2924           - pass the options argument to Port.create_driver()
2925         * Scripts/webkitpy/layout_tests/port/webkit.py:
2926           - pass the options argument to Port.create_driver(), and clean up
2927             building of the cmd line for DRT.
2928         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2929           - consolidate args in _get_dump_render_tree_args and rename to
2930             _get_test_args(); move all of the command-line args to the
2931             Port implementations.
2932
2933 2010-09-20  Andrew Wilson  <atwilson@chromium.org>
2934
2935         Revert change which was accidentally committed along with some expectation changes.
2936
2937         * Scripts/webkitpy/layout_tests/port/base.py:
2938
2939 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
2940
2941         Reviewed by Adam Barth.
2942
2943         Add explicit --force-patch flag to webkitpy tools
2944         https://bugs.webkit.org/show_bug.cgi?id=46103
2945
2946         It wasn't obvious until I read the applypatch.py source code that
2947         --non-interfactive implies passing --force to patch. Add --force-patch
2948         as an alias to the flag, so that this behavior is more discoverable.
2949
2950         * Scripts/webkitpy/tool/steps/applypatch.py:
2951         * Scripts/webkitpy/tool/steps/options.py:
2952
2953 2010-09-20  Eric Seidel  <eric@webkit.org>
2954
2955         Unreviewed, adding a line which got dropped and is trivially correct (and tested).
2956
2957         commit-queue can't land patches
2958         https://bugs.webkit.org/show_bug.cgi?id=46138
2959
2960         Add a line of code I forgot in my last commit.
2961
2962         * Scripts/webkitpy/common/net/bugzilla.py:
2963         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
2964
2965 2010-09-20  Adam Barth  <abarth@webkit.org>
2966
2967         Reviewed by Eric Seidel.
2968
2969         The commit-cluster bots still race to lock patch_ids
2970         https://bugs.webkit.org/show_bug.cgi?id=46130
2971
2972         It turns out we need to use a transaction object to make the
2973         read/modify/write lock operation atomic.  From reading the AppEngine
2974         documentation, I think this patch should do what we want.  It's hard to
2975         test locally because the test instance isn't distributed in the same
2976         way the production instance is.
2977
2978         * QueueStatusServer/handlers/nextpatch.py:
2979         * QueueStatusServer/model/activeworkitems.py: Added.
2980
2981 2010-09-20  Andy Estes  <aestes@apple.com>
2982
2983         Reviewed by Adam Barth.
2984
2985         REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
2986         https://bugs.webkit.org/show_bug.cgi?id=40961
2987
2988         Implement WebKitUsePreHTML5ParserQuirks preference.
2989
2990         * DumpRenderTree/mac/DumpRenderTree.mm:
2991         (resetDefaultsToConsistentValues): Reset WebKitUsePreHTML5ParserQuirks
2992         to false after a test finishes.
2993
2994 2010-09-20  Adam Roben  <aroben@apple.com>
2995
2996         Windows build fix
2997
2998         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Put
2999         $(WebKitOutputDir)\include before $(WebKitLibrariesDir)\include so
3000         we'll pick up the most recent versions of the headers.
3001
3002 2010-09-20  Eric Seidel  <eric@webkit.org>
3003
3004         Reviewed by Adam Barth.
3005
3006         commit-queue should check commit-queue+ again just before committing
3007         https://bugs.webkit.org/show_bug.cgi?id=32679
3008
3009         Added a _revalidate_patch check, right before landing.
3010
3011         Since _revalidate_patch passes the patch_id from the work item
3012         back to bugzilla, I had to fix all of the previous queue tests to
3013         use valid attachment ids (that's the majority of this change).
3014
3015         In order to validate that the bug was still open, I had to teach
3016         bugzilla.Bug about open/closed states.
3017
3018         * Scripts/webkitpy/common/net/bugzilla.py:
3019         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3020         * Scripts/webkitpy/tool/commands/queues.py:
3021         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3022         * Scripts/webkitpy/tool/commands/queuestest.py:
3023         * Scripts/webkitpy/tool/mocktool.py:
3024
3025 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
3026
3027         Unreviewed.
3028
3029         Adding myself as a comitter.
3030
3031         * Scripts/webkitpy/common/config/committers.py:
3032
3033 2010-09-20  Adam Barth  <abarth@webkit.org>
3034
3035         Reviewed by Eric Seidel.
3036
3037         Two instances of commit-queue try to process the same patch
3038         https://bugs.webkit.org/show_bug.cgi?id=46113
3039
3040         This patch makes next-patch atomic so that the server won't vend the
3041         same patch twice in the same hour.
3042
3043         * QueueStatusServer/handlers/nextpatch.py:
3044
3045 2010-09-20  Adam Roben  <aroben@apple.com>
3046
3047         Make WebKitTestRunner's wait-to-dump watchdog timer work on Windows
3048
3049         We were previously trying to use a CFRunLoopTimer, but since Windows
3050         doesn't use CFRunLoop on most threads this doesn't work. Now we use a
3051         Windows-style timer on Windows.
3052
3053         I also replaced all uses of "watchdog" with "watchdog timer".
3054
3055         Fixes <http://webkit.org/b/46101> WebKitTestRunner's wait-to-dump
3056         watchdog timer doesn't work on Windows
3057
3058         Reviewed by Anders Carlsson.
3059
3060         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3061         (WTR::InjectedBundlePage::dump): Updated for rename.
3062
3063         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Removed
3064         platform-specific functions.
3065         (WTR::LayoutTestController::LayoutTestController): Added call to
3066         platformInitialize.
3067         (WTR::LayoutTestController::waitUntilDone): Changed to call
3068         initializeWaitToDumpWatchdogTimerIfNeeded instead of doing the work
3069         right in this function.
3070         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Updated for
3071         rename.
3072
3073         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added new
3074         members needed to support the watchdog timer abstraction. Replaced
3075         some "watchdog"s with "watchdog timer".
3076
3077         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
3078         Added.
3079         (WTR::LayoutTestController::platformInitialize): Does nothing on this
3080         platform.
3081         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Moved here
3082         from LayoutTestController.cpp and changed to use an early return.
3083         (WTR::waitUntilDoneWatchdogTimerFired): Moved here from
3084         LayoutTestController.cpp.
3085         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
3086         Moved code here from LayoutTestController::waitUntilDone and changed
3087         to use an early return.
3088
3089         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
3090         Added.
3091         (WTR::LayoutTestController::platformInitialize): Initialize our
3092         watchdog timer.
3093         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Added.
3094         Kills and clears the watchdog timer.
3095         (WTR::waitToDumpWatchdogTimerFired): Added. Calls through to the
3096         LayoutTestController member function of the same name.
3097         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
3098         Added. Sets up the timer if it isn't already set.
3099
3100         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added
3101         LayoutTestControllerMac.mm.
3102
3103         * WebKitTestRunner/win/InjectedBundle.vcproj: Added
3104         LayoutTestControllerWin.cpp.
3105
3106 2010-09-20  Martin Robinson  <mrobinson@igalia.com>
3107
3108         Reviewed by Daniel Bates.
3109
3110         [GTK] fast/forms/listbox-selection.html fails
3111         https://bugs.webkit.org/show_bug.cgi?id=45942
3112
3113         Use the gdkModifersFromJSValue helper to parse all appropriate modifier
3114         strings in keyDownCallback.
3115
3116         * DumpRenderTree/gtk/EventSender.cpp:
3117         (keyDownCallback): Use the gdkModifersFromJSValue instead of duplicating the
3118         modifier parsing logic.
3119
3120 2010-09-19  Sam Weinig  <sam@webkit.org>
3121
3122         Reviewed by Anders Carlsson.
3123
3124         WebKit2 decidePolicyForNavigationAction should include mouse button information
3125         <rdar://problem/8413165>
3126         https://bugs.webkit.org/show_bug.cgi?id=46060
3127
3128         * MiniBrowser/mac/BrowserWindowController.m:
3129         (decidePolicyForNavigationAction):
3130         (decidePolicyForNewWindowAction):
3131
3132 2010-09-19  Daniel Bates  <dbates@rim.com>
3133
3134         Reviewed by Martin Robinson.
3135
3136         Add unit tests for diffs that delete or modify a change log entry
3137         or describe changes that are far apart
3138         https://bugs.webkit.org/show_bug.cgi?id=46046
3139
3140         Add additional unit tests to test change log diffs that contain
3141         deletions or changes that are far apart from each other in the
3142         ChangeLog file.
3143
3144         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
3145           - Added the following unit tests:
3146           "fixChangeLogPatch: [no change] In-place change."
3147           "fixChangeLogPatch: [no change] Remove first entry."
3148           "fixChangeLogPatch: [no change] Remove entry in the middle."
3149           "fixChangeLogPatch: [no change] Far apart changes (i.e. more than one chunk)."
3150
3151 2010-09-19  Sam Weinig  <sam@webkit.org>
3152
3153         Reviewed by Anders Carlsson.
3154
3155         Replace WKBundleRangeRef with WKBundleRangeHandleRef.
3156         https://bugs.webkit.org/show_bug.cgi?id=46054
3157
3158         The new one acts like WKBundleNodeHandleRef and allows for getting a
3159         wrapper in a specific world for the handle.
3160
3161         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3162         (WTR::propertyValue):
3163         (WTR::propertyValueDouble):
3164         (WTR::propertyValueInt):
3165         (WTR::numericWindowPropertyValue):
3166         (WTR::toStr):
3167         (WTR::InjectedBundlePage::shouldBeginEditing):
3168         (WTR::InjectedBundlePage::shouldEndEditing):
3169         (WTR::InjectedBundlePage::shouldInsertNode):
3170         (WTR::InjectedBundlePage::shouldInsertText):
3171         (WTR::InjectedBundlePage::shouldDeleteRange):
3172         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
3173         (WTR::InjectedBundlePage::shouldApplyStyle):
3174         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3175
3176 2010-09-19  Kent Tamura  <tkent@chromium.org>
3177
3178         Unreviewed. Fix WebGL test regressions by r67809.
3179
3180         * DumpRenderTree/chromium/WebPreferences.cpp:
3181         (WebPreferences::applyTo): Call setExperimentalWebGLEnabled().
3182
3183 2010-09-19  Kent Tamura  <tkent@chromium.org>
3184
3185         Reviewed by Adam Barth.
3186
3187         [DRT/Chromium] Fix a WebSettings handling bug
3188         https://bugs.webkit.org/show_bug.cgi?id=45945
3189
3190         Before this change, Chromium DRT reset WebSettings for every new
3191         window. It was wrong.
3192         If new window is not the first one, we have to apply the same
3193         settings as the first window.  So, we introduce WebPreference to
3194         store the current settings, and apply it to new windows. It's same
3195         as test_shell's behavior.
3196
3197         * DumpRenderTree/DumpRenderTree.gypi:
3198         * DumpRenderTree/chromium/LayoutTestController.cpp:
3199           Use WebPreferences instead of WebSettings.
3200         (LayoutTestController::setUserStyleSheetEnabled):
3201         (LayoutTestController::setUserStyleSheetLocation):
3202         (LayoutTestController::setAuthorAndUserStylesEnabled):
3203         (LayoutTestController::setPopupBlockingEnabled):
3204         (LayoutTestController::disableImageLoading):
3205         (LayoutTestController::setJavaScriptCanAccessClipboard):
3206         (LayoutTestController::setXSSAuditorEnabled):
3207         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
3208         (LayoutTestController::setAllowFileAccessFromFileURLs):
3209         (LayoutTestController::overridePreference):
3210         (LayoutTestController::setEditingBehavior):
3211         * DumpRenderTree/chromium/TestShell.cpp:
3212         (TestShell::resetWebSettings): Use WebPreferences.
3213         (TestShell::runFileTest): ditto.
3214         (TestShell::createNewWindow): Apply existing WebPreferences to a new WebView.
3215         * DumpRenderTree/chromium/TestShell.h:
3216         (TestShell::preferences):
3217         (TestShell::applyPreferences):
3218         * DumpRenderTree/chromium/WebPreferences.cpp: Added.
3219         * DumpRenderTree/chromium/WebPreferences.h: Added.
3220
3221 2010-09-18  Prasad Tammana  <prasadt@chromium.org>
3222
3223         Reviewed by David Levin.
3224
3225         update-webkit --chromium spitting out a spurious error
3226         https://bugs.webkit.org/show_bug.cgi?id=45868
3227
3228         * Scripts/update-webkit-chromium: Use commandExists() function to check for existence of gclient.
3229
3230 2010-09-18  Sam Weinig  <sam@webkit.org>
3231
3232         Reviewed by Dan Bernstein.
3233
3234         Improve/unify the PageLoadClient interfaces
3235         https://bugs.webkit.org/show_bug.cgi?id=46043
3236
3237         * MiniBrowser/mac/BrowserWindowController.m:
3238         (didStartProvisionalLoadForFrame):
3239         (didReceiveServerRedirectForProvisionalLoadForFrame):
3240         (didFailProvisionalLoadWithErrorForFrame):
3241         (didCommitLoadForFrame):
3242         (didFinishDocumentLoadForFrame):
3243         (didFinishLoadForFrame):
3244         (didFailLoadWithErrorForFrame):
3245         (didReceiveTitleForFrame):
3246         (didFirstLayoutForFrame):
3247         (didFirstVisuallyNonEmptyLayoutForFrame):
3248         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3249         (WTR::InjectedBundlePage::InjectedBundlePage):
3250         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
3251         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
3252         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
3253         (WTR::InjectedBundlePage::didCommitLoadForFrame):
3254         (WTR::InjectedBundlePage::didFinishLoadForFrame):
3255         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
3256         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
3257         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
3258         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3259         * WebKitTestRunner/TestController.cpp:
3260         (WTR::TestController::didReceiveMessageFromInjectedBundle):
3261         (WTR::TestController::didFinishLoadForFrame):
3262         * WebKitTestRunner/TestController.h:
3263
3264 2010-09-17  Eric Seidel  <eric@webkit.org>
3265
3266         Unreviewed.  Adding a shell script I use to run the
3267         commit-queue. Now that multiple machines run the cq,
3268         it makes sense to share the script between them.
3269
3270         * EWSTools/start-commit-queue.sh: Added.
3271
3272 2010-09-17  Brian Weinstein  <bweinstein@apple.com>
3273
3274         Reviewed by Jon Honeycutt.
3275
3276         The colors on the new build.webkit.org (after upgrading the master to 0.8.1) are
3277         slightly harder to read, so this reverts the previous background colors for various
3278         states, making it easier to read.
3279
3280         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
3281         (.success):
3282         (.failure):
3283         (.warnings):
3284         (.exception):
3285         (.start,.running,td.building):
3286         (.offline,td.offline):
3287
3288 2010-09-17  Sheriff Bot  <webkit.review.bot@gmail.com>
3289
3290         Unreviewed, rolling out r67692.
3291         http://trac.webkit.org/changeset/67692
3292         https://bugs.webkit.org/show_bug.cgi?id=46011
3293
3294         broke layout test dashboard (Requested by johnny_g on
3295         #webkit).
3296
3297         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3298         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3299         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3300
3301 2010-09-17  Martin Robinson  <mrobinson@igalia.com>
3302
3303         Reviewed by Oliver Hunt.
3304
3305         Style bot complains about cairo forward declaration naming
3306         https://bugs.webkit.org/show_bug.cgi?id=45867
3307
3308         Exclude Cairo forward declarations from indentifiers with underscores checks.
3309
3310         * Scripts/webkitpy/style/checkers/cpp.py: Add exclusion for Cairo forward-declarations.
3311         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
3312
3313 2010-09-16  Kinuko Yasuda  <kinuko@chromium.org>
3314
3315         Reviewed by Ojan Vafai.
3316
3317         Include detailed test modifiers (e.g. FLAKY) in results.json for failing non-layout tests
3318         https://bugs.webkit.org/show_bug.cgi?id=45408
3319
3320         This change also tries to remove duplicated upload_results_json methods
3321         in run_webkit_tests.py and json_results_generator.py.
3322
3323         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3324         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3325         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3326
3327 2010-09-16  Antonio Gomes  <tonikitoo@webkit.org>
3328
3329         Reviewed by Andreas Kling.
3330
3331         [Qt] When switching views (WebViewGraphicsBased <--> WebViewTraditional), QWebPage signals and QActions have to be re-set.
3332
3333         Recently r67554 changed the way different views use the WebPage class: it was previously being shared between
3334         different views, but now for each view switch, a new WebPage class is constructed and set. Signals and QAction's
3335         were not being set to the new WebPage though. Patch fix that, by re constructing the toolbar, and then re-hooking
3336         all page specific stuff to the UI.
3337
3338         * QtTestBrowser/launcherwindow.cpp:
3339         (LauncherWindow::initializeView):
3340         * QtTestBrowser/mainwindow.cpp:
3341         (MainWindow::MainWindow):
3342         (MainWindow::buildUI):
3343         (MainWindow::setPage):
3344         * QtTestBrowser/mainwindow.h:
3345
3346 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3347
3348         Reviewed by Andreas Kling.
3349
3350         Make all accesses to m_item (GraphicsWebView) done by WebViewGraphicsBased class happen though graphicsWebView getter method.
3351
3352         This patch is mostly a preparation for another commit, where the ownership of the m_item/GraphicsWebView
3353         object will move to the qgraphicsscene instead of the qgraphicsview.
3354
3355         * QtTestBrowser/webview.cpp:
3356         (WebViewGraphicsBased::setPage):
3357         (WebViewGraphicsBased::setResizesToContents):
3358         (WebViewGraphicsBased::resizeEvent):
3359         (WebViewGraphicsBased::animatedFlip):
3360         * QtTestBrowser/webview.h:
3361         (WebViewGraphicsBased::setItemCacheMode):
3362         (WebViewGraphicsBased::itemCacheMode):
3363
3364 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3365
3366         Reviewed by Andreas Kling.
3367
3368         Moved setYRotation method body out of the class (WebViewGraphicsBased) definition.
3369
3370         We usually separate methods whose body are larger than a few lines from the class definition.
3371
3372         * QtTestBrowser/webview.h:
3373         (WebViewGraphicsBased::yRotation):
3374         (WebViewGraphicsBased::setYRotation):
3375
3376 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3377
3378         Reviewed by Andreas Kling.
3379
3380         Make initializeView method of LauncherWindow private.
3381
3382         No one else needs to be able to call it but LauncherWindow.
3383         Also moving the declation of isGraphicsBased method down in the same file, in order
3384         to better group related methods.
3385
3386         * QtTestBrowser/launcherwindow.h:
3387
3388 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3389
3390         Reviewed by Andreas Kling.
3391
3392         Make the getter 'page' method of MainWindow const.
3393
3394         * QtTestBrowser/mainwindow.cpp:
3395         (MainWindow::page):
3396         * QtTestBrowser/mainwindow.h:
3397
3398 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3399
3400         Reviewed by Andreas Kling.
3401
3402         Remove useless parameter from MainWindow class' constructor.
3403
3404         The parameter defaults to an empty URL and is not being used by any caller. Apart from that it is also
3405         not referred in the constructor body and does not make much sense.
3406
3407         * QtTestBrowser/mainwindow.cpp:
3408         (MainWindow::MainWindow):
3409         * QtTestBrowser/mainwindow.h:
3410
3411 2010-09-15  Tony Chang  <tony@chromium.org>
3412
3413         Reviewed by Kent Tamura.
3414
3415         [Chromium] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
3416         https://bugs.webkit.org/show_bug.cgi?id=42151
3417
3418         * DumpRenderTree/chromium/LayoutTestController.cpp:
3419         (LayoutTestController::LayoutTestController):
3420         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
3421         (WorkItemLoadHTMLString::run):
3422         (LayoutTestController::queueLoadHTMLString):
3423         (LayoutTestController::reset):
3424         (LayoutTestController::setDeferMainResourceDataLoad):
3425         * DumpRenderTree/chromium/LayoutTestController.h:
3426         (LayoutTestController::deferMainResourceDataLoad):
3427         * DumpRenderTree/chromium/WebViewHost.cpp:
3428         (WebViewHost::didCreateDataSource):
3429
3430 2010-09-16  Adrienne Walker  <enne@google.com>
3431
3432         Reviewed by Kenneth Russell.
3433
3434         Add script to synchronize WebKit and Khronos WebGL tests
3435         https://bugs.webkit.org/show_bug.cgi?id=42336
3436
3437         * Scripts/update-webgl-conformance-tests: Added.
3438         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py: Added.
3439         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py: Added.
3440
3441 2010-09-16  Sam Weinig  <sam@webkit.org>
3442
3443         Reviewed by Anders Carlsson.
3444
3445         Add support for sending synchronous messages from the InjectedBundle to the WKContext
3446         <rdar://problem/8365320>
3447         https://bugs.webkit.org/show_bug.cgi?id=44785
3448
3449         * MiniBrowser/mac/AppDelegate.m:
3450         (didReceiveSynchronousMessageFromInjectedBundle):
3451         (-[BrowserAppDelegate init]):
3452         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3453         (didCreatePage):
3454         * WebKitTestRunner/TestController.cpp:
3455         (WTR::TestController::initialize):
3456
3457 2010-09-16  Leonid Ebril  <leonid.ebril@nokia.com>
3458
3459         Reviewed by Andreas Kling.
3460
3461         [Qt] QtTestBrowser: Disable creation of a new window for screenshot on Symbian platform.
3462         https://bugs.webkit.org/show_bug.cgi?id=45885
3463
3464         Avoid creation of an additional window for screenshot to prevent overlapping with original window.
3465
3466         * QtTestBrowser/launcherwindow.cpp:
3467         (LauncherWindow::screenshot):
3468
3469 2010-09-16  Anders Carlsson  <andersca@apple.com>
3470
3471         Fix clang++ build.
3472
3473         * MiniBrowser/mac/BrowserWindowController.m:
3474         (-[BrowserWindowController zoomIn:]):
3475         (-[BrowserWindowController zoomOut:]):
3476         (-[BrowserWindowController resetZoom:]):
3477         Remove trailing semicolons.
3478
3479 2010-09-16  Sheriff Bot  <webkit.review.bot@gmail.com>
3480
3481         Unreviewed, rolling out r67628.
3482         http://trac.webkit.org/changeset/67628
3483         https://bugs.webkit.org/show_bug.cgi?id=45904
3484
3485         broke the build (Requested by eric_carlson on #webkit).
3486
3487         * DumpRenderTree/gtk/EventSender.cpp:
3488         (contextClickCallback):
3489
3490 2010-09-16  Balazs Kelemen  <kbalazs@webkit.org>
3491
3492         Unreviewed.
3493
3494         Adding myself as a comitter.
3495
3496         * Scripts/webkitpy/common/config/committers.py:
3497
3498 2010-09-15  Philippe Normand  <pnormand@igalia.com>
3499
3500         Reviewed by Eric Carlson.
3501
3502         [GTK] enhanced context menu for media elements
3503         https://bugs.webkit.org/show_bug.cgi?id=45021
3504
3505         EventSender::contextClick() now returns an array of js
3506         objects. Each object has a title property and a click() method.
3507
3508         * DumpRenderTree/gtk/EventSender.cpp:
3509         (getMenuItemTitleCallback):
3510         (setMenuItemTitleCallback):
3511         (menuItemClickCallback):
3512         (getMenuItemClass):
3513         (contextClickCallback):
3514
3515 2010-09-14  Philippe Normand  <pnormand@igalia.com>
3516
3517         Reviewed by Eric Carlson and Martin Robinson.
3518
3519         [GTK] eventSender.contextClick() should return the contents of the context menu
3520         https://bugs.webkit.org/show_bug.cgi?id=39102
3521
3522         Make the eventSender use the new private WebKitGtk+ API to
3523         retrieve the context-menu item titles and store them in an array.
3524
3525         * DumpRenderTree/gtk/EventSender.cpp:
3526         (contextClickCallback):
3527
3528 2010-09-16  Eric Uhrhane  <ericu@chromium.org>
3529
3530         Reviewed by Jian Li.
3531
3532         Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
3533         https://bugs.webkit.org/show_bug.cgi?id=45798
3534
3535         * Scripts/build-webkit:
3536
3537 2010-09-16  Robert Hogan  <robert@webkit.org>
3538
3539         Reviewed by Antonio Gomes.
3540
3541         [Qt] Support globalhistory tests
3542         https://bugs.webkit.org/show_bug.cgi?id=45774
3543
3544         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3545         (WebCore::isGlobalHistoryTest):
3546         (WebCore::DumpRenderTree::open):
3547         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3548         (LayoutTestController::reset):
3549         (LayoutTestController::dumpHistoryCallbacks):
3550         (LayoutTestController::removeAllVisitedLinks):
3551         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3552
3553 2010-09-10  Tony Chang  <tony@chromium.org>
3554
3555         Reviewed by Eric Seidel.
3556
3557         deduplicate-tests should be runnable from any WebKit directory
3558         https://bugs.webkit.org/show_bug.cgi?id=44709
3559
3560         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
3561         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3562
3563 2010-09-15  Tony Chang  <tony@chromium.org>
3564
3565         Reviewed by Kent Tamura.
3566
3567         [chromium] sort testing methods in DRT
3568         https://bugs.webkit.org/show_bug.cgi?id=45850
3569
3570         * DumpRenderTree/chromium/EventSender.cpp:
3571         (EventSender::EventSender):
3572         * DumpRenderTree/chromium/LayoutTestController.cpp:
3573         (LayoutTestController::LayoutTestController):
3574         * DumpRenderTree/chromium/TextInputController.cpp:
3575         (TextInputController::TextInputController):
3576
3577 2010-09-15  Mihai Parparita  <mihaip@chromium.org>
3578
3579         Reviewed by Adam Barth.
3580
3581         CQ status shows items out of order
3582         https://bugs.webkit.org/show_bug.cgi?id=45846
3583
3584         Only group consecutive status items with the same patch ID into the same
3585         group, so that overall item ordering is preserved.
3586
3587         Also don't indent status items that only have a single item in their
3588         group.
3589
3590         * QueueStatusServer/handlers/queuestatus.py:
3591         * QueueStatusServer/templates/includes/singlequeuestatus.html: Added.
3592         * QueueStatusServer/templates/queuestatus.html:
3593
3594 2010-09-15  Eric Seidel  <eric@webkit.org>
3595
3596         Reviewed by Adam Barth.
3597
3598         Add queue start/stop messages
3599         https://bugs.webkit.org/show_bug.cgi?id=45853
3600
3601         I ended up needing to clean up a bunch of our unit testing
3602         in order to test this new code path nicely.
3603
3604         There are also a few PEP8 changes needed to pass check-webkit-style.
3605
3606         * Scripts/webkitpy/tool/bot/queueengine.py:
3607         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
3608         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3609         * Scripts/webkitpy/tool/commands/queues.py:
3610         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3611         * Scripts/webkitpy/tool/commands/queuestest.py:
3612         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
3613
3614 2010-09-15  Simon Fraser  <simon.fraser@apple.com>
3615
3616         https://bugs.webkit.org/show_bug.cgi?id=45849
3617         WKURLCreateWithCFURL crashes with null url
3618
3619         Fix MiniBrowser crash when the url is not parseable.
3620
3621         * MiniBrowser/mac/BrowserWindowController.m:
3622         (-[BrowserWindowController fetch:]):
3623
3624 2010-09-15  Patrick Gansterer  <paroga@paroga.com>
3625
3626         Unreviewed.
3627
3628         Adding myself to the committers list.
3629
3630         * Scripts/webkitpy/common/config/committers.py:
3631
3632 2010-09-14  Eric Seidel  <eric@webkit.org>
3633
3634         Reviewed by Adam Barth.
3635
3636         Make it possible to run more than one commit-queue instance
3637         https://bugs.webkit.org/show_bug.cgi?id=45786
3638
3639         Mostly we need to make sure the two (or more) instances get
3640         different patches to work on.  To do this, I re-worked
3641         the code responsible for getting the next work item to
3642         round trip through the status server.  The status server only
3643         vends patches from the work items list, only if those patches
3644         have not had status reported for them in the last hour.
3645
3646         This is another step towards making all queues go through the
3647         status server, thus making it possible to run more than one
3648         instance of various EWS bots (as requested in bug 44292).
3649
3650         The webkitpy changes are already covered by existing unit tests.
3651         The QueueStatusSever sadly has no testing infrastructure yet. :(
3652
3653         * QueueStatusServer/handlers/nextpatch.py: Added.
3654         * QueueStatusServer/index.yaml:
3655         * QueueStatusServer/main.py:
3656         * Scripts/webkitpy/tool/commands/queues.py:
3657
3658 2010-09-15  Mihai Parparita  <mihaip@chromium.org>
3659
3660         Reviewed by Tony Chang.
3661
3662         NRWT fails with UnicodeDecodeError on editing/selection/mixed-editability-10.html
3663         https://bugs.webkit.org/show_bug.cgi?id=45791
3664
3665         Force filenames to be raw bytes before running difflib.unified_diff.
3666
3667         * Scripts/webkitpy/layout_tests/port/base.py:
3668         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3669
3670 2010-09-15  Simon Hausmann  <simon.hausmann@nokia.com>
3671
3672         Reviewed by Tor Arne Vestbø.
3673
3674         [Qt] QtTestBrowser crashes when enabling QGraphicsView mode after first loading page without it enabled
3675         https://bugs.webkit.org/show_bug.cgi?id=35247
3676
3677         The main issue when changing the views is that the plugins and any other components that
3678         depend on view specific attributes such as the native window id are not teared down.
3679         Even if we had a tear-down procedure, we'd have to re-initialize the plugin after
3680         switching to the new view (QGraphicsWebView). This is a rather uncommon situation, so
3681         we decided to work around this in QtTestBrowser by making toggling between QWebView
3682         and QGraphicsWebView also re-create the page.
3683
3684         * QtTestBrowser/launcherwindow.cpp:
3685         (LauncherWindow::initializeView):
3686         * QtTestBrowser/mainwindow.h:
3687
3688 2010-09-14  Mihai Parparita  <mihaip@chromium.org>
3689
3690         Reviewed by Adam Barth.
3691
3692         Send webkit accessibility notifications to Chromium
3693         https://bugs.webkit.org/show_bug.cgi?id=45156
3694
3695         Move printf inside shouldDumpAccessibilityNotifications check.
3696
3697         * DumpRenderTree/chromium/WebViewHost.cpp:
3698         (WebViewHost::postAccessibilityNotification):
3699
3700 2010-09-14  Tony Chang  <tony@chromium.org>
3701
3702         Reviewed by Kent Tamura.
3703
3704         [chromium] fix http/tests/security/local-user-CSS-from-remote.html
3705         https://bugs.webkit.org/show_bug.cgi?id=45788
3706
3707         * DumpRenderTree/chromium/LayoutTestController.cpp:
3708         (LayoutTestController::setUserStyleSheetLocation): use a base64 url like in Chrome
3709
3710 2010-09-14  Tony Chang  <tony@chromium.org>
3711
3712         Reviewed by Ojan Vafai.
3713
3714         [chromium] Remove WebKit::areLayoutTestImagesOpaque since it's no longer needed
3715         https://bugs.webkit.org/show_bug.cgi?id=45768
3716
3717         * DumpRenderTree/chromium/TestShell.cpp:
3718         (TestShell::dumpImage): new baselines are checked in and Linux will match Windows going forward.
3719
3720 2010-09-14  Kevin Ollivier  <kevino@theolliviers.com>
3721
3722         [wx] Build fix, add newly added directories to the directory list.
3723
3724         * wx/build/settings.py:
3725
3726 2010-09-14  Sam Weinig  <sam@webkit.org>
3727
3728         Reviewed by Anders Carlsson.
3729
3730         Remove WKBundleNodeRef, replacing uses with WKBundleNodeHandleRef.
3731         https://bugs.webkit.org/show_bug.cgi?id=45785
3732
3733         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3734         (WTR::propertyValue):
3735         (WTR::numericWindowPropertyValue):
3736         (WTR::dumpPath):
3737         (WTR::toStr):
3738         (WTR::operator<<):
3739         (WTR::InjectedBundlePage::InjectedBundlePage):
3740         (WTR::InjectedBundlePage::shouldInsertNode):
3741         (WTR::InjectedBundlePage::shouldBeginEditing):
3742         (WTR::InjectedBundlePage::shouldEndEditing):
3743         (WTR::InjectedBundlePage::shouldInsertText):
3744         (WTR::InjectedBundlePage::shouldDeleteRange):
3745         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
3746         (WTR::InjectedBundlePage::shouldApplyStyle):
3747         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3748
3749 2010-09-14  Adam Barth  <abarth@webkit.org>
3750
3751         Fix two typos in commit-queue.  The first is harmless.  The second
3752         causes the queue to reject patches when the build is broken.  :(
3753
3754         * Scripts/webkitpy/tool/commands/queues.py:
3755         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3756
3757 2010-09-14  Chris Guillory   <chris.guillory@google.com>
3758
3759         Reviewed by Chris Fleizach.
3760
3761         Send all accessibility notifications to Chromium.
3762         https://bugs.webkit.org/show_bug.cgi?id=45156
3763
3764         * DumpRenderTree/chromium/WebViewHost.cpp:
3765         (WebViewHost::postAccessibilityNotification):
3766         * DumpRenderTree/chromium/WebViewHost.h:
3767
3768 2010-09-14  Adam Barth  <abarth@webkit.org>
3769
3770         Reviewed by Eric Seidel.
3771
3772         commit-queue is slow during the day
3773         https://bugs.webkit.org/show_bug.cgi?id=45780
3774
3775         Thanks to the new logging, we've noticed that checkout-is-out-of-date
3776         errors in the first pass of landing don't retry the land.  Instead,
3777         they're treated as failures and cause the commit-queue to do two more
3778         builds before really trying to land the patch.  Worse, in the second
3779         build, we can get bitten by a flaky test.
3780
3781         This patch takes a slightly different approach to the commit-queue's
3782         main control logic.  We now use a separate subprocess for building and
3783         testing and for landing.  This means we should very rarely see the
3784         checkout-is-out-of-date error, and when we do see it, we should retry
3785         more quickly.  If my understanding is correct, this should be a big
3786         speed win for the commit-queue.
3787
3788         * Scripts/webkitpy/tool/commands/download.py:
3789         * Scripts/webkitpy/tool/commands/queues.py:
3790         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3791
3792 2010-09-14  Tony Chang  <tony@chromium.org>
3793
3794         Reviewed by Dimitri Glazkov.
3795
3796         [chromium] implement layoutTestController.setDomainRelaxationForbiddenForURLScheme
3797         https://bugs.webkit.org/show_bug.cgi?id=45762
3798
3799         * DumpRenderTree/chromium/LayoutTestController.cpp:
3800         (LayoutTestController::LayoutTestController):
3801         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
3802         * DumpRenderTree/chromium/LayoutTestController.h:
3803
3804 2010-09-14  Csaba Osztrogonác  <ossy@webkit.org>
3805
3806         Adding myself as a reviewer.
3807
3808         * Scripts/webkitpy/common/config/committers.py:
3809
3810 2010-09-14  Zoltan Horvath  <zoltan@webkit.org>
3811
3812         Reviewed by Kenneth Rohde Christiansen.
3813
3814         [Qt] Build-webkit shows a warning when WebKitBuild directory is not exist
3815         https://bugs.webkit.org/show_bug.cgi?id=45736
3816
3817         Build-webkit has showed a warning when WebKitBuild didn't exist, add
3818         an additional condition to avoid it.
3819
3820         * Scripts/build-webkit:
3821
3822 2010-09-13  Eric Seidel  <eric@webkit.org>
3823
3824         Reviewed by Adam Barth.
3825
3826         commit-queue should log when it's retrying due to checkout out of date error
3827         https://bugs.webkit.org/show_bug.cgi?id=45725
3828
3829         This will allow us to better track how often we see these errors
3830         and how long it takes the queue to recover from them.
3831
3832         In order to pass the tests, I had to correct an error
3833         from a previous change.  The UnitTestPort should not have
3834         ever been using the base port method as that will read
3835         a file from disk.  If the unit tests haven't passed the contents
3836         it should raise an IOError as though the file doesn't exist.
3837
3838         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3839         * Scripts/webkitpy/tool/commands/queues.py:
3840         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3841
3842 2010-09-13  Mihai Parparita  <mihaip@chromium.org>
3843
3844         Reviewed by Adam Barth.
3845
3846         Upload results when cq patch landing fails
3847         https://bugs.webkit.org/show_bug.cgi?id=45683
3848
3849         Include script errors when CommitQueue._land fails.
3850
3851         * Scripts/webkitpy/tool/commands/queues.py:
3852
3853 2010-09-13  Chris Fleizach  <cfleizach@apple.com>
3854
3855         Reviewed by David Kilzer.
3856
3857         AX: accessibilityIsIgnored is returning nil when return value expects a BOOL
3858         https://bugs.webkit.org/show_bug.cgi?id=45548
3859
3860         * DumpRenderTree/AccessibilityUIElement.cpp:
3861         (isIgnoredCallback):
3862         (AccessibilityUIElement::getJSClass):
3863         * DumpRenderTree/AccessibilityUIElement.h:
3864         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3865         (AccessibilityUIElement::isIgnored):
3866         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3867         (AccessibilityUIElement::isIgnored):
3868         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3869         (AccessibilityUIElement::isIgnored):
3870
3871 2010-09-13  Csaba Osztrogonác  <ossy@webkit.org>
3872
3873         Reviewed by Andreas Kling.
3874
3875         jscPath() is incorrect in Windows' cmd.exe shell
3876         https://bugs.webkit.org/show_bug.cgi?id=45651
3877
3878         * Scripts/webkitdirs.pm: Add ".exe" suffix to $jscName on Windows.
3879
3880 2010-09-13  Chris Fleizach  <cfleizach@apple.com>
3881
3882         Reviewed by Darin Adler.
3883
3884         REGRESSION (r64816-r64889): Crash in WebCore::AccessibilityRenderObject
3885         https://bugs.webkit.org/show_bug.cgi?id=43807
3886
3887         * DumpRenderTree/AccessibilityUIElement.cpp:
3888         (textMarkerForPointCallback):
3889         (AccessibilityUIElement::textMarkerForPoint):
3890         (AccessibilityUIElement::getJSClass):
3891         * DumpRenderTree/AccessibilityUIElement.h:
3892         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3893         (AccessibilityUIElement::textMarkerForPoint):
3894
3895 2010-09-13  Andreas Kling  <andreas.kling@nokia.com>
3896
3897         Reviewed by Kenneth Rohde Christiansen.
3898
3899         [Qt] build-webkit: Add --v8 option to build against V8
3900
3901         Note that V8 is picked up from QtScript, so this currently requires building
3902         against the experimental qt-script-v8 branch.
3903
3904         * Scripts/build-webkit:
3905
3906 2010-09-13  Hans Wennborg  <hans@chromium.org>
3907
3908         Reviewed by Jeremy Orlow.
3909
3910         Add WebDeviceOrientationClientMock::create() and use it from DRT.
3911         https://bugs.webkit.org/show_bug.cgi?id=45650
3912
3913         Do not use the WebDeviceOrientationClientMock constructor directly,
3914         but use the create() member function.
3915
3916         This should fix the linker errors for the multi-DLL Chromium DRT build.
3917
3918         * DumpRenderTree/chromium/LayoutTestController.cpp:
3919         (LayoutTestController::setMockDeviceOrientation):
3920         (LayoutTestController::deviceOrientationClient):
3921
3922 2010-08-27  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
3923
3924         Reviewed by Antti Koivisto.
3925
3926         Add support for testing the viewport meta tag algorithm,
3927         based on the following draft spec:
3928
3929         http://people.opera.com/rune/TR/ED-css-viewport-20100806/
3930
3931         Add common handling of viewport meta tag based on new Opera spec
3932         https://bugs.webkit.org/show_bug.cgi?id=44201
3933
3934         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3935         (LayoutTestController::dumpConfigurationForViewport):
3936         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3937
3938 2010-09-12  Kent Tamura  <tkent@chromium.org>
3939
3940         Reviewed by Tony Chang.
3941
3942         [DRT/Chromium] Remove dependency to base/string16.h and gfx/codec/png_codec.h
3943         https://bugs.webkit.org/show_bug.cgi?id=45517
3944
3945         Use webkit_support_gfx.h for PNG encoding/decoding instead of png_codec.h
3946
3947         * DumpRenderTree/chromium/ImageDiff.cpp:
3948         (Image::craeteFromStdin):
3949         (Image::createFromFilename):
3950         (diffImages):
3951         * DumpRenderTree/chromium/TestShell.cpp:
3952         (TestShell::dumpImage):
3953
3954 2010-09-10  MORITA Hajime  <morrita@google.com>
3955
3956         Reviewed by Tony Chang.
3957
3958         [Chromium] Implement textInputController.hasSpellingMarker() for Chromium
3959         https://bugs.webkit.org/show_bug.cgi?id=45441
3960
3961         Added TextInputController::hasSpellingMarker().
3962
3963         * DumpRenderTree/chromium/TextInputController.cpp:
3964         (TextInputController::TextInputController):
3965         (TextInputController::hasSpellingMarker):
3966         * DumpRenderTree/chromium/TextInputController.h:
3967
3968 2010-09-12  Dirk Pranke  <dpranke@chromium.org>
3969
3970         Unreviewed, build fix.
3971
3972         My last change accidentally contained a local change to the
3973         rebaselinig script; webkit-patch land picked it up without telling
3974         me and committed it :(
3975
3976         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3977
3978 2010-09-11  Maciej Stachowiak  <mjs@apple.com>
3979
3980         Reviewed by Anders Carlsson.
3981
3982         Attempt to fix Windows MiniBrowser build (untested)
3983         https://bugs.webkit.org/show_bug.cgi?id=45609
3984
3985         * MiniBrowser/win/BrowserView.cpp:
3986         (runJavaScriptConfirm):
3987         (runJavaScriptPrompt):
3988
3989 2010-09-11  Sam Weinig  <sam@webkit.org>
3990
3991         Reviewed by Maciej Stachowiak.
3992
3993         Fix zoom related tests when testing WebKit2.
3994
3995         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3996         (WTR::EventSendingController::zoomPageIn): Zoom in and zoom out are not the same.
3997
3998 2010-09-11  Sam Weinig  <sam@webkit.org>
3999
4000         Reviewed by Dan Bernstein.
4001
4002         Implement WebKit2 callback equivalent to - [WebUIDelegate webView:setStatusText:]
4003         <rdar://problem/8359252>
4004         https://bugs.webkit.org/show_bug.cgi?id=45605
4005
4006         * MiniBrowser/mac/BrowserWindowController.m:
4007         (setStatusText):
4008         (contentsSizeChanged):
4009         (-[BrowserWindowController awakeFromNib]):
4010         * MiniBrowser/win/BrowserView.cpp:
4011         (runJavaScriptConfirm):
4012         (runJavaScriptPrompt):
4013         (setStatusText):
4014         (contentsSizeChanged):
4015         (BrowserView::create):
4016         * WebKitTestRunner/TestController.cpp:
4017         (WTR::createOtherPage):
4018         (WTR::TestController::initialize):
4019
4020 2010-09-11  Sam Weinig  <sam@webkit.org>
4021
4022         Reviewed by Dan Bernstein.
4023
4024         Add callback mechanism for the getting the source of a frame
4025         <rdar://problem/8364681>
4026         https://bugs.webkit.org/show_bug.cgi?id=45604
4027
4028         Add ability to dump the main frame's source to the console.
4029
4030         * MiniBrowser/mac/BrowserWindowController.h:
4031         * MiniBrowser/mac/BrowserWindowController.m:
4032         (-[BrowserWindowController dumpSourceToConsole:]):
4033         * MiniBrowser/mac/MainMenu.xib:
4034
4035 2010-09-11  Eric Seidel  <eric@webkit.org>
4036
4037         Reviewed by Adam Barth.
4038
4039         Remove unneeded Empty Queue messages
4040         https://bugs.webkit.org/show_bug.cgi?id=45602
4041
4042         We already have a /gc job to delete these.
4043         recentstatus.py is already smart enough to use the
4044         most recent of the workitems last update or the most recent status,
4045         so removing these should not change the _last_status_date() return
4046         value more than a few milliseconds.
4047
4048         These messages just spam the recent status log.
4049
4050         * Scripts/webkitpy/tool/commands/queues.py:
4051
4052 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
4053
4054         Reviewed by Adam Barth.
4055
4056         Fix Python exception when generating synthetic patch IDs
4057         https://bugs.webkit.org/show_bug.cgi?id=45592
4058
4059         Can't concatenate strings and numbers directly.
4060
4061         * QueueStatusServer/handlers/queuestatus.py:
4062
4063 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
4064
4065         Reviewed by Adam Barth.
4066
4067         Group statuses in queue status by patch ID
4068         https://bugs.webkit.org/show_bug.cgi?id=45588
4069
4070         Group statuses by patch ID so that the status page is easier
4071         to scan.
4072
4073         * QueueStatusServer/handlers/queuestatus.py:
4074         * QueueStatusServer/stylesheets/dashboard.css:
4075         (.status-group):
4076         (.status-bug):
4077         (.status-group ul):
4078         (.status-group ul li):
4079         (.status-group ul li:hover):
4080         (.status-cell):
4081         (.status-cell:hover):
4082         (.status-cell.pass):
4083         (.status-cell.fail):
4084         (.status-cell.pending):
4085         (.status-cell.error):
4086         * QueueStatusServer/templates/dashboard.html:
4087         * QueueStatusServer/templates/queuestatus.html:
4088
4089 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
4090
4091         Reviewed by Tony Chang.
4092
4093         Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
4094         https://bugs.webkit.org/show_bug.cgi?id=45479
4095
4096         Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after
4097         implementation in ResourceLoadDelegate in the Mac port).
4098
4099         * DumpRenderTree/chromium/LayoutTestController.cpp:
4100         (LayoutTestController::LayoutTestController):
4101         (LayoutTestController::dumpResourceResponseMIMETypes):
4102         (LayoutTestController::reset):
4103         * DumpRenderTree/chromium/LayoutTestController.h:
4104         (LayoutTestController::setShouldDumpResourceResponseMIMETypes):
4105         (LayoutTestController::shouldDumpResourceResponseMIMETypes):
4106         * DumpRenderTree/chromium/TestShell.h:
4107         (TestShell::shouldDumpResourceResponseMIMETypes):
4108         * DumpRenderTree/chromium/WebViewHost.cpp:
4109         (WebViewHost::didReceiveResponse):
4110
4111 2010-09-11  Eric Seidel  <eric@webkit.org>
4112
4113         Reviewed by Adam Barth.
4114
4115         queues.webkit.org should expose /remote_api for data upload/download
4116         https://bugs.webkit.org/show_bug.cgi?id=45559
4117
4118         * QueueStatusServer/app.yaml:
4119          - /remote_api is a standard app-engine service which allows use of
4120            the bulk uploader for data upload/download.  Exposing this
4121            (for admin access only) allows us to use
4122
4123 2010-09-10  Sam Weinig  <sam@webkit.org>
4124
4125         Reviewed by Dan Bernstein.
4126
4127         Add zoom support to WebKit2 API
4128         <rdar://problem/7660657>
4129         https://bugs.webkit.org/show_bug.cgi?id=45585
4130
4131         - Add zoom options to MiniBrowser that mimic Safari's options using
4132           the new WebKit2 zoom APIs.
4133         - Switch uses of float for the zoom APIs to use double.
4134
4135         * MiniBrowser/mac/BrowserWindowController.h:
4136         * MiniBrowser/mac/BrowserWindowController.m:
4137         (-[BrowserWindowController initWithPageNamespace:]):
4138         (-[BrowserWindowController validateMenuItem:]):
4139         (-[BrowserWindowController validateUserInterfaceItem:]):
4140         (-[BrowserWindowController currentZoomFactor]):
4141         (-[BrowserWindowController setCurrentZoomFactor:]):
4142         (-[BrowserWindowController canZoomIn]):
4143         (-[BrowserWindowController zoomIn:]):
4144         (-[BrowserWindowController canZoomOut]):
4145         (-[BrowserWindowController zoomOut:]):
4146         (-[BrowserWindowController canResetZoom]):
4147         (-[BrowserWindowController resetZoom:]):
4148         (-[BrowserWindowController toggleZoomMode:]):
4149         * MiniBrowser/mac/MainMenu.xib:
4150         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
4151         (WTR::EventSendingController::textZoomIn):
4152         (WTR::EventSendingController::textZoomOut):
4153         (WTR::EventSendingController::zoomPageIn):
4154         (WTR::EventSendingController::zoomPageOut):
4155
4156 2010-09-10  Robert Hogan  <robert@webkit.org>
4157
4158         Reviewed by Andreas Kling.
4159
4160         [Qt] Fix crash in DRT in standalone mode
4161
4162         https://bugs.webkit.org/show_bug.cgi?id=45454
4163
4164         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4165         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
4166
4167 2010-09-10  Sam Weinig  <sam@webkit.org>
4168
4169         Reviewed by Darin Adler.
4170
4171         Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom.
4172         Precursor to <rdar://problem/7660657>
4173         https://bugs.webkit.org/show_bug.cgi?id=45522
4174
4175         Update for changes to the Bundle API to allow separate control of page and text zoom
4176         levels.
4177
4178         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
4179         (WTR::EventSendingController::textZoomIn):
4180         (WTR::EventSendingController::textZoomOut):
4181         (WTR::EventSendingController::zoomPageIn):
4182         (WTR::EventSendingController::zoomPageOut):
4183         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4184         (WTR::InjectedBundlePage::reset):
4185
4186 2010-09-10  Yael Aharon  <yael.aharon@nokia.com>
4187
4188         Reviewed by Andreas Kling.
4189
4190         [Qt] Support click event for notifications
4191         https://bugs.webkit.org/show_bug.cgi?id=44836
4192
4193         Add support for simulateDesktopNotificationClick by calling
4194         back to DumpRenderTreeSupportQt.cpp.
4195
4196         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4197         (LayoutTestController::simulateDesktopNotificationClick):
4198         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4199
4200 2010-09-10  Mihai Parparita  <mihaip@chromium.org>
4201
4202         Reviewed by Eric Seidel.
4203
4204         Update queue status when patches fail their first land attempt
4205         https://bugs.webkit.org/show_bug.cgi?id=45583
4206
4207         Add a few more _update_status calls to make it more obvious if a patch is
4208         being retried because tests failed.
4209
4210         * Scripts/webkitpy/tool/commands/queues.py:
4211
4212 2010-09-10  Balazs Kelemen  <kb@inf.u-szeged.hu>
4213
4214         Reviewed by Andreas Kling.
4215
4216         [Qt] MiniBrowser crashes with multiply windows when closing one of them
4217         https://bugs.webkit.org/show_bug.cgi?id=45536
4218
4219         * MiniBrowser/qt/BrowserView.cpp:
4220         (BrowserView::BrowserView): Reference the context instead of adopting it
4221         because it can be shared across different views.
4222
4223 2010-09-10  Tony Chang  <tony@chromium.org>
4224
4225         Unreviewed, rolling out r67241.
4226         http://trac.webkit.org/changeset/67241
4227         https://bugs.webkit.org/show_bug.cgi?id=44709
4228
4229         Accidentally committed.
4230
4231         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
4232         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
4233
4234 2010-09-10  Tony Chang  <tony@chromium.org>
4235
4236         Reviewed by Ojan Vafai.
4237
4238         deduplicate-tests should be runnable from any WebKit directory
4239         https://bugs.webkit.org/show_bug.cgi?id=44709
4240
4241         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
4242         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
4243
4244 2010-09-10  Tony Chang  <tony@chromium.org>