a8f6b1b0d21e6edc0bfc6be0be7012f12b443c88
[WebKit-https.git] / WebKitTools / ChangeLog
1 2008-05-05  Adele Peterson  <adele@apple.com>
2
3         Reviewed by Adam.
4
5         Look for the right ImageDiff executable for debug builds.
6
7         * Scripts/run-webkit-tests:
8
9 2008-05-05  Darin Adler  <darin@apple.com>
10
11         * Scripts/run-webkit-tests: Ignore a Java leak showing up in the WebKit
12         leak tests.
13
14 2008-05-05  Ariya Hidayat  <ariya.hidayat@trolltech.com>
15
16         Reviewed by Simon.
17
18         In the Qt's DumpRenderTree, adjust the web view properly (because W3C SVG 
19         tests expect to be 480x360)
20
21         * DumpRenderTree/qt/DumpRenderTree.cpp:
22         (WebCore::DumpRenderTree::open):
23
24 2008-05-02  Dan Bernstein  <mitz@apple.com>
25
26         Reviewed by Adam Roben.
27
28         - add an option to svn-apply to set the reviewer name in change logs
29
30         * Scripts/svn-apply: Added a [-r|--reviewer name] option.
31
32 2008-05-01  David Kilzer  <ddkilzer@apple.com>
33
34         Clean up configuration usage in run-webkit-tests
35
36         Reviewed by Adam.
37
38         * Scripts/run-webkit-tests: Parse configuration switches using
39         passedConfiguration() from webkitdirs.pm like every other script.
40         Note that we must still call setConfiguration() afterwards in
41         case the --configuration switch was used.  Use $configurationOption
42         when running build-dumprendertree instead of recreating the switch.
43
44 2008-04-29  Adam Roben  <aroben@apple.com>
45
46         Restore the beloved COMPtr::operator&
47
48 2008-04-29  Adam Roben  <aroben@apple.com>
49
50         Windows build fixes
51
52         Replace COMPtr::operator& with COMPtr::adoptionPointer.
53
54 2008-04-25  Alexey Proskuryakov  <ap@webkit.org>
55
56         Reviewed by Darin.
57
58         Fix run-webkit-tests --threading
59         and provisionally fix <https://bugs.webkit.org/show_bug.cgi?id=18661>
60         Proxy server issue in Sunday's Nightly
61
62         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
63         (runJavaScriptThread):
64         (startJavaScriptThreads):
65         (stopJavaScriptThreads):
66         Spawned threads were immediately detached, unlike the original ones, so joining them
67         made no sense. Now, all threads are created detached, and stopJavaScriptThreads() just
68         waits for them all to exit.
69
70 2008-04-28  Holger Hans Peter Freyther  <zecke@selfish.org>
71
72         Reviewed by Simon.
73
74         Reset dumping resource load callbacks to false for the next test
75         
76
77         * DumpRenderTree/qt/jsobjects.cpp:
78         (LayoutTestController::reset):
79
80 2008-04-28  Tor Arne Vestbø  <tavestbo@trolltech.com>
81
82         Reviewed by Simon.
83
84         Adapt to the latest API changes in WebKit/qt/Api.
85
86         * DumpRenderTree/qt/DumpRenderTree.cpp:
87         (WebCore::DumpRenderTree::DumpRenderTree):
88         * DumpRenderTree/qt/jsobjects.cpp:
89
90 2008-04-26  Robin Dunn  <robin@alldunn.com>
91
92         Reviewed by Kevin Ollivier.
93         
94         Delete the DerivedSources after make clean has been done so that the DerivedSources
95         don't get re-created. Also, use the proper extension for the Win wxPython extension.
96         
97         https://bugs.webkit.org/show_bug.cgi?id=18756
98
99         * wx/build-wxwebkit:
100
101 2008-04-26  Adam Barth <hk9565@gmail.com>
102
103         Reviewed by Adam Roben and Sam Weinig.
104
105         Updates LayoutTestController to use host instead of domain.
106
107         Collin Jackson <collinj-webkit@collinjackson.com> also contributed to this patch.
108
109         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
110         (LayoutTestController::setDatabaseQuota):
111         * DumpRenderTree/mac/UIDelegate.mm:
112         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]):
113
114 2008-04-26  Kevin Ollivier  <kevino@theolliviers.com>
115
116         wx build fix. Need the latest libpng. (Somehow my initial test passed without it.)
117
118         * wx/install-unix-extras:
119
120 2008-04-26  Robin Dunn  <robin@alldunn.com>
121
122         Reviewed by Kevin Ollivier.
123         
124         Allow the user to set the path to SWIG using an environment variable.
125         
126         https://bugs.webkit.org/show_bug.cgi?id=18660
127
128         * wx/build-wxwebkit:
129
130 2008-04-26  Kevin Ollivier  <kevino@theolliviers.com>
131
132         wx build fix. Download the latest libpng version for building the
133         dependencies.
134
135         * wx/install-unix-extras:
136
137 2008-04-25  Holger Hans Peter Freyther  <zecke@selfish.org>
138
139         Reviewed by Simon.
140
141         Implement dumping of resource load callbacks to pass http/tests/xmlhttprequest/abort-should-cancel-load.html
142         
143         Similar to Editing and Frameloading we do the dumping within WebCore
144         
145
146         * DumpRenderTree/qt/jsobjects.cpp:
147         (LayoutTestController::dumpResourceLoadCallbacks):
148         * DumpRenderTree/qt/jsobjects.h:
149
150 2008-04-24  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
151
152         Reviewed by Maciej Stachowiak.
153
154         http://bugs.webkit.org/show_bug.cgi?id=18485
155         Typo and documentation fix for build-webkit
156
157         * Scripts/build-webkit:
158
159 2008-04-24  Anders Carlsson  <andersca@apple.com>
160
161         Reviewed by Sam.
162
163         Don't call fprintf from the signal handler.
164         
165         * DumpRenderTree/mac/DumpRenderTree.mm:
166         (crashHandler):
167
168 2008-04-23  Adam Roben  <aroben@apple.com>
169
170         Make crashes be reported as crashes, not hangs
171
172         Reviewed by David Kilzer.
173
174         * Scripts/run-webkit-tests:
175         (top level): Use the new status field of the output from
176         readFromDumpToolWithTimer to determine if the test crashed or hung.
177         (sub readFromDumpToolWithTimer):
178           - If we fail to read a line and $! is not EAGAIN, then we've crashed
179             and should not try to read any more.
180           - Changed the timedout field to a more general status field.
181
182 2008-04-22  David Kilzer  <ddkilzer@apple.com>
183
184         Bug 18683: update-webkit returns 0 even if it fails
185
186         <https://bugs.webkit.org/show_bug.cgi?id=18683>
187
188         Reviewed by Mitz Pettel.
189
190         * Scripts/update-webkit:
191         (runSvnUpdate): Die if close() fails.
192
193 2008-04-21  Adam Roben  <aroben@apple.com>
194
195         Flush stdout/stderr after printing every #EOF separator
196
197         This fixes a hang when running the pixel tests on Windows
198
199         Reviewed by Mitz Pettel.
200
201         * DumpRenderTree/win/DumpRenderTree.cpp:
202         (dump):
203         (main): We don't have to flush stdout/stderr in the arguments loop
204         anymore, as runTest flushes for us.
205
206 2008-04-21  Adam Roben  <aroben@apple.com>
207
208         Fix pixel tests
209
210         * Scripts/run-webkit-tests:
211         (sub readFromDumpToolWithTimer): Use readline instead of read to
212         ensure that we don't read past the #EOF marker.
213
214 2008-04-21  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
215
216         Reviewed by Simon.
217
218         Build fix for Qt 4.3
219
220         * When building WebCore/internal make sure the QT_[BEGIN,END]_NAMESPACE is
221         always defined. Do this by adding defines to the compiler line
222
223         * DumpRenderTree/qt/DumpRenderTree.pro:
224
225 2008-04-19  Mike Hommey  <glandium@debian.org>
226
227         Reviewed by Alp Toker.
228
229         Don't build GtkLauncher and DumpRenderTree with rpath.
230
231         * GNUmakefile.am:
232
233 2008-04-18  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
234
235         Reviewed by Alp Toker.
236
237         http://bugs.webkit.org/show_bug.cgi?id=16620
238         [GTK] Autotools make dist and make check support
239
240         Cleanups.
241
242         * GNUmakefile.am:
243
244 2008-04-18  Adam Roben  <aroben@apple.com>
245
246         Drop the hang timer to 30 seconds
247
248         This matches what DRT/mac was using.
249
250         Reviewed by Mitz Pettel.
251
252         * Scripts/run-webkit-tests:
253
254 2008-04-18  Adam Roben  <aroben@apple.com>
255
256         Get rid of DRT's Watchdog
257
258         run-webkit-tests now detects hangs and samples DRT as needed.
259
260         Reviewed by Mitz Pettel.
261
262         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Removed
263         Watchdog* files from the project.
264         * DumpRenderTree/Watchdog.cpp: Removed.
265         * DumpRenderTree/Watchdog.h: Removed.
266         * DumpRenderTree/mac/DumpRenderTree.mm: Removed uses of Watchdog
267         (dumpRenderTree):
268         (runTest):
269         * DumpRenderTree/mac/WatchdogMac.h: Removed.
270         * DumpRenderTree/mac/WatchdogMac.mm: Removed.
271         * Scripts/run-webkit-tests:
272         (sub testCrashedOrTimedOut): Call sampleDumpTool() if we timed out.
273         (sub sampleDumpTool): Added. Writes a sample report to
274         ~/Library/Logs/DumpRenderTree/HangReport.txt.
275
276 2008-04-18  Simon Hausmann  <hausmann@webkit.org>
277
278         Reviewed by Holger.
279
280         Adapt to the API changes in WebKit/qt
281
282         * DumpRenderTree/qt/DumpRenderTree.cpp:
283         (WebCore::WebPage::WebPage):
284         (WebCore::DumpRenderTree::DumpRenderTree):
285         (WebCore::DumpRenderTree::initJSObjects):
286         (WebCore::DumpRenderTree::dumpFramesAsText):
287         (WebCore::DumpRenderTree::dump):
288
289 2008-04-17  Adam Roben  <aroben@apple.com>
290
291         Fix many tests on Windows
292
293         * Scripts/run-webkit-tests:
294         (readFromDumpToolWithTimer):
295          - Use read instead of sysread to ensure that we don't interfere with
296            other uses of buffered IO in this script.
297         (setFileHandleNonBlocking): Actually set the filehandle to blocking
298         when specified.
299
300 2008-04-17  Adam Roben  <aroben@apple.com>
301
302         Fix ~10 tests
303
304         * Scripts/run-webkit-tests: Only remove the newline after #EOF, not
305         whatever newline happens to be at the end of what we've read.
306
307 2008-04-17  Adam Roben  <aroben@apple.com>
308
309         Remove DRT/win's hang timer
310
311         run-webkit-tests takes care of this for us now
312
313         Reviewed by Anders Carlsson.
314
315         * DumpRenderTree/win/DumpRenderTree.cpp:
316
317 2008-04-17  Adam Roben  <aroben@apple.com>
318
319         Don't wait for the hang timer twice in the case of a hang
320
321         Previously we'd wait for a hang while reading both stdout and stderr
322         from DRT. Now we'll only wait for one or the other.
323
324         Reviewed by Anders Carlsson.
325
326         * Scripts/run-webkit-tests:
327         (top level): Don't wait for stderr to time out if stdout already timed
328         out.
329         (readFromDumpToolWithTimer): If $dontWaitForTimeOut is true, quit
330         after the first read that returns no data.
331
332 2008-04-17  Adam Roben  <aroben@apple.com>
333
334         Don't throw away the output from timed out tests
335
336         Reviewed by Anders Carlsson.
337
338         * Scripts/run-webkit-tests:
339         (top level): Updated for changes to readFromDumpToolWithTimer.
340         (readFromDumpToolWithTimer): Return a hash that contains both the
341         output and whether or not the test timed out.
342
343 2008-04-17  Adam Roben  <aroben@apple.com>
344
345         Make the hang timer 60 seconds
346
347         * Scripts/run-webkit-tests:
348
349 2008-04-17  Adam Roben  <aroben@apple.com>
350
351         Get rid of carriage returns in DRT/win's stderr
352
353         Reviewed by Eric Seidel.
354
355         * DumpRenderTree/win/DumpRenderTree.cpp:
356         (main): Mark stderr as binary like we already do for stdout.
357
358 2008-04-17  Adam Roben  <aroben@apple.com>
359
360         Fix Bug 17678: run-webkit-tests should have a watchdog timer (and
361         timeout long tests)
362
363         <https://bugs.webkit.org/show_bug.cgi?id=17678>
364
365         We now abort tests that take longer than 60 seconds to produce output.
366         This matches the watchdog timer in DRT/mac and DRT/win (which we can
367         now remove).
368
369         Reviewed by Eric Seidel.
370
371         * Scripts/run-webkit-tests:
372         (top level): Read DRT's output using the new readFromDumpToolWithTimer
373         subroutine. If readFromDumpToolWithTimer returns undefined it means
374         the test timed out, so we register the test as a hang and move on.
375         (sub testCrashedOrTimedOut): Renamed from testCrashed. Now handles
376         both crashed and timed out tests. If the test timed out, we kill DRT
377         before returning.
378         (sub linksForTimedOutTest): Added. We don't have any output to link to for
379         tests that timed out.
380         (sub recordActualResultsAndDiff): Don't call length on undefined.
381         (sub readFromDumpToolWithTimer): Added. Performs non-blocking reads
382         from a filehandle until an #EOF is reached or
383         $maximumSecondsWithoutOutput have elapsed.
384         (sub setFileHandleNonBlocking): Marks a filehandle as blocking or
385         non-blocking.
386
387 2008-04-17  Adam Roben  <aroben@apple.com>
388
389         Refactor test results page generation
390
391         Reviewed by Eric Seidel.
392
393         * Scripts/run-webkit-tests:
394         (sub htmlForResultsSection): Added. Takes a set of tests, a
395         description, and a subroutine to generate the links for each test, and
396         creates a HTML string containing a table of the tests and their
397         links.
398         (sub linksForExpectedAndActualResults): Added. Replaces the
399         htmlForExpectedAndActualResults subroutine.
400         (sub linksForMismatchTest): Added.
401         (sub linksForCrashOrErrorTest): Added.
402         (sub linksForNewTest): Added.
403
404 2008-04-17  Adam Roben  <aroben@apple.com>
405
406         Print the extension for all tests in the test results page
407
408         Reviewed by Eric Seidel.
409
410         * Scripts/run-webkit-tests:
411
412 2008-04-17  Adam Roben  <aroben@apple.com>
413
414         Move code that counts finished tests into a subroutine
415
416         Reviewed by Eric Seidel.
417
418         * Scripts/run-webkit-tests:
419         (sub countFinishedTest): Added.
420
421 2008-04-17  Adam Roben  <aroben@apple.com>
422
423         Move code that handles a crash into a subroutine
424
425         Reviewed by Eric Seidel.
426
427         * Scripts/run-webkit-tests:
428         (sub testCrashed): Added.
429
430 2008-04-17  Eric Seidel  <eric@webkit.org>
431
432         Reviewed by hyatt.
433         
434         Rename RenderView to RenderViewport in the next rename patch.
435
436         * Scripts/do-webcore-rename:
437
438 2008-04-17  Mario Bensi  <mbensi@pleyo.com>
439
440         Reviewed by Alp Toker.
441
442         http://bugs.webkit.org/show_bug.cgi?id=18543
443         DumpRenderTree gtk freeze
444
445         fix DumpRenderTree gtk freeze 
446
447         * DumpRenderTree/gtk/DumpRenderTree.cpp:
448         (dump):
449
450 2008-04-15  Anders Carlsson  <andersca@apple.com>
451
452         Add missing ;
453         
454         * Scripts/build-webkit:
455         
456 2008-04-15  Anders Carlsson  <andersca@apple.com>
457
458         Reviewed by Adam.
459
460         Add ENABLE_OFFLINE_WEB_APPLICATIONS to FEATURE_DEFINES.
461
462         * Scripts/build-webkit:
463
464 2008-04-15  Andre Poenitz  <andre.poenitz@trolltech.com>
465
466         Reviewed by Simon.
467
468         Fix compilation with Qt namespaces
469
470         Qt can be configured to have all of its classes inside a specified namespaces.
471         This is for example used in plugin/component environments like Eclipse.
472
473         This change makes it possible to let the Qt port compile against a namespaced
474         Qt by the use of macros Qt provides to properly forward declare Qt classes in
475         the namespace.
476
477         * DumpRenderTree/qt/DumpRenderTree.h:
478
479 2008-04-08  Kevin Ollivier  <kevino@theolliviers.com>
480
481         Reviewed by Darin Adler.
482
483         Add a script that propagates any file changes made to the Bakefiles
484         over to GTK and Qt build systems. Still needs to be wired into
485         those ports though.
486
487         * Scripts/update-sources-list.py: Added.
488
489 2008-04-08  Mark Rowe  <mrowe@apple.com>
490
491         Clean up after Brady.
492
493         * DumpRenderTree/mac/DumpRenderTree.mm: Add an include so that NSInteger can be found.
494
495 2008-04-08  Brady Eidson  <beidson@apple.com>
496
497         Reviewed by Mitzpettel
498
499         Fixed http://bugs.webkit.org/show_bug.cgi?id=18302
500         -WebArchive subresources dump in random order, intermittent failures
501
502         * DumpRenderTree/mac/DumpRenderTree.mm:
503         (compareResourceURLs): Sorting function based on the resource URLs
504         (serializeWebArchiveToXML): Sort the subresource array
505
506 2008-04-07  Brady Eidson  <beidson@apple.com>
507
508         OMG, BUILD - please!
509
510         * Scripts/build-webkit:
511
512 2008-04-03  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
513
514         Reviewed by Simon.
515
516         * Enable running http tests for Qt again. Failing tests can be put into the skipped list.
517         * Running these tests on windows and other platforms might need some work.
518
519         * Scripts/run-webkit-tests:
520
521 2008-04-03  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
522
523         Reviewed by Simon.
524
525         * For the http tests we need the output of the FrameLoaderClient. The QtWebKit API
526         is not exporting enough to create the output in DRT itself. Settle with the approach
527         Lars has taken for the Editing support and add branches to our FrameLoaderClient code.
528         * run-webkit-tests http/tests(/loading) can now be executed.
529         * For tests in loading/ directories we are going to throw away the dirty
530         QWebPage to start with something clean.
531         
532
533         * DumpRenderTree/qt/DumpRenderTree.cpp:
534
535 2008-04-03  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
536
537         Reviewed by Simon.
538
539         * Treat http and https as special URLs as well. Change the main.cpp and
540         DumpRenderTree.cpp to handle http and https URIs as input.
541         * I'm not doing the clean up and merging of these two checks now.
542         
543
544         * DumpRenderTree/qt/DumpRenderTree.cpp:
545         (WebCore::DumpRenderTree::readStdin):
546         * DumpRenderTree/qt/main.cpp:
547         (main):
548
549 2008-04-03  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
550
551         Reviewed by Simon.
552
553         * Remove dumpFrameLoadCallbacks from simple-subframe.html because it is
554         located in a directory with the name "loading". And this will autoamtically
555         enable dumping.
556         * Remove this method from the LayoutTestController as it is unused now and this
557         avoids adding it to the DRT of the Qt port.
558         
559
560         * DumpRenderTree/LayoutTestController.cpp:
561         (setPrivateBrowsingEnabledCallback):
562
563 2008-04-01  Christian Dywan  <christian@imendio.com>
564
565         Build fix for GCC 4.3.
566
567         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: include string.h
568
569 2008-04-01  Simon Hausmann  <hausmann@webkit.org>
570
571         Reviewed by Holger.
572
573         Fix Qt DRT run by also printing EOF on stderr, as expected by
574         run-webkit-tests.
575
576         * DumpRenderTree/qt/DumpRenderTree.cpp:
577         (WebCore::DumpRenderTree::dump):
578
579 2008-03-31  Julien Chaffraix  <julien.chaffraix@gmail.com>
580
581         Reviewed by Darin.
582
583         Bug 17665: determineSourceDir() dies if $sourceDir has a trailing backslash
584
585         Remove trailing '/' in $sourceDir in determineSourceDir().
586
587         Fix suggested by Dmitriy Kazachkov.
588
589         * Scripts/webkitdirs.pm:
590
591 2008-03-29  Adam Roben  <aroben@apple.com>
592
593         Update for rename of an IWebViewPrivate method
594
595         Reviewed by Mitz Pettel.
596
597         * DumpRenderTree/win/DumpRenderTree.cpp:
598         (createWebViewAndOffscreenWindow):
599
600 2008-03-26  Antti Koivisto  <antti@apple.com>
601
602         Reviewed by Anders.
603         
604         Enable SVG animation support by default.
605
606         * Scripts/build-webkit:
607
608 2008-03-25  Adam Roben  <aroben@apple.com>
609
610         Windows build fix
611
612         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
613         Add $(WebKitLibrariesDir)\include to the include path so we can find
614         stdint.h there.
615
616 2008-03-24  Eric Seidel  <eric@webkit.org>
617
618         Reviewed by Mark.
619
620         Clean up SVG features message to be less confusing.
621
622         * Scripts/build-webkit:
623
624 2008-03-24  Sam Weinig  <sam@webkit.org>
625
626         Reviewed by Dave Hyatt.
627
628         Add EventSender.zoomPageIn/zoomPageOut support to DRT.
629
630         * DumpRenderTree/mac/DumpRenderTree.mm:
631         (resetWebViewToConsistentStateBeforeTesting):
632         * DumpRenderTree/mac/EventSendingController.mm:
633         (+[EventSendingController isSelectorExcludedFromWebScript:]):
634         (-[EventSendingController zoomPageIn]):
635         (-[EventSendingController zoomPageOut]):
636         * DumpRenderTree/win/DumpRenderTree.cpp:
637         (resetWebViewToConsistentStateBeforeTesting):
638         * DumpRenderTree/win/EventSender.cpp:
639         (textZoomInCallback):
640         (textZoomOutCallback):
641         (zoomPageInCallback):
642         (zoomPageOutCallback):
643
644 2008-03-24  Dan Bernstein  <mitz@apple.com>
645
646         Reviewed by Mark Rowe.
647
648         - update bisect-builds for Safari 3.1
649
650         * Scripts/bisect-builds: Added Safari 3.1 and the corresponding minimal
651         revision, r29711.
652
653 2008-03-21  Rodney Dawes  <dobey@wayofthemonkey.com>
654
655         Reviewed by Holger.
656
657         http://bugs.webkit.org/show_bug.cgi?id=17981
658
659         Add webcore and javascriptcore cppflags to programs' _CPPFLAGS.
660
661         * GNUmakefile.am:
662
663 2008-03-21  Adam Roben  <aroben@apple.com>
664
665         Remove a non-working mirror from cygwin-downloader and add the ruby package
666
667         * CygwinDownloader/cygwin-downloader.py:
668         * CygwinDownloader/cygwin-downloader.zip: Updated.
669
670 2008-03-20  Mark Rowe  <mrowe@apple.com>
671
672         Reviewed by Sam Weinig.
673
674         Ensure that the defines generated for FEATURE_DEFINES are sorted so that they will match the default settings of each project.
675         This will prevent the world from being rebuilt if you happen to switch between building in Xcode and with build-webkit on the
676         command-line.
677
678         * Scripts/build-webkit:
679
680 2008-03-17  Eric Seidel  <eric@webkit.org>
681
682         Reviewed by Dan Bernstein.
683
684         Fix bogus argCount check breaking plugin test.
685
686         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
687
688 2008-03-17  Eric Seidel  <eric@webkit.org>
689
690         Reviewed by darin.
691
692         Cleanup PluginObject.cpp and add support for testing
693         converting from int -> identifier -> string
694         and from string -> identifier -> int
695         as well as round-tripping ints and stings through identifiers
696
697         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
698         (pluginGetProperty):
699         (pluginSetProperty):
700         (testDOMAccess):
701         (stringVariantToIdentifier):
702         (int32VariantToIdentifier):
703         (doubleVariantToIdentifier):
704         (variantToIdentifier):
705         (testIdentifierToString):
706         (testIdentifierToInt):
707         (testCallback):
708         (getURL):
709         (removeDefaultMethod):
710         (getURLNotify):
711         (testInvokeDefault):
712         (destroyStream):
713         (testEnumerate):
714         (testGetIntIdentifier):
715         (testGetProperty):
716         (testEvaluate):
717         (testGetPropertyReturnValue):
718         (pluginInvoke):
719         (pluginInvokeDefault):
720         (pluginInvalidate):
721         (pluginAllocate):
722         (pluginDeallocate):
723         (handleCallback):
724
725 2008-03-16  Kevin Ollivier  <kevino@theolliviers.com>
726
727         Rubber stamped by Darin.
728
729         Add set-webkit-configuration support for wx port, and centralize
730         build dir location setting.
731
732         http://bugs.webkit.org/show_bug.cgi?id=17790
733
734         * wx/browser/browser.bkl:
735         * wx/build-wxwebkit:
736
737 2008-03-15  Darin Adler  <darin@apple.com>
738
739         * Scripts/commit-log-editor: Include the name line of the change log entry.
740         A long time ago I designed this script to not include the name because I
741         thought it was redundant (same as the name of the person checking in), but
742         nowadays it's more common for someone to check something in done by someone
743         else.
744
745         * Scripts/do-webcore-rename: Added some more planned renames and removed
746         some that were already done "by hand".
747
748 2008-03-13  Brent Fulgham  <bfulgham@gmail.com>
749
750         Reviewed by Darin.
751
752         Correct paths to vsprops files so they use the environment
753         variable, rather than hard-coded path.
754         http://bugs.webkit.org/show_bug.cgi?id=17797.
755
756         * WinLauncher/WinLauncher.vcproj:  Correct paths to vsprops.
757
758 2008-03-12  Steve Falkenburg  <sfalken@apple.com>
759
760         VSExpress build fix
761
762         * WinLauncher/WinLauncher.vcproj:
763
764 2008-03-12  Holger Hans Peter Freyther  <zecke@selfish.org>
765
766         Reviewed by Alp Toker.
767
768         Run testkjs in the correct productsDir in the GTK+ port.
769
770         * Scripts/run-javascriptcore-tests:
771
772 2008-03-11  Brent Fulgham  <bfulgham@gmail.com>
773
774         Reviewed by Adam Roben.
775
776         Enabled WinLauncher as part of normal Windows build.
777         http://bugs.webkit.org/show_bug.cgi?id=17715.
778
779         * WinLauncher/WinLauncher.vcproj: Update to use vsprops so that
780           it can find the proper libraries to link against.
781
782 2008-03-10  Julien Chaffraix  <julien.chaffraix@gmail.com>
783
784         Reviewed and landed by Darin.
785
786         http://bugs.webkit.org/show_bug.cgi?id=17581
787         Bug 17581: Use of uninitialized value in string ne at WebKitTools/Scripts/run-webkit-tests line 1576.
788
789         Remove the previous warning which occurs when the --random option is used.
790
791         * Scripts/run-webkit-tests: verify that $component[0] is defined before checking for
792         its inequality
793
794 2008-03-07  Simon Hausmann  <hausmann@webkit.org>
795
796         Reviewed by Darin.
797
798         Done with Lars.
799
800         Ported the netscape test plugin to QWebPluginFactory.
801
802         * DumpRenderTree/qt/DumpRenderTree.cpp:
803         (WebCore::WebPage::WebPage):
804         * DumpRenderTree/qt/main.cpp:
805         * DumpRenderTree/qt/testplugin.cpp:
806         (TestPlugin::plugins):
807         (TestPlugin::create):
808         * DumpRenderTree/qt/testplugin.h:
809
810 2008-03-09  Steve Falkenburg  <sfalken@apple.com>
811
812         Stop Windows build if an error occurs in a prior project.
813
814         Rubber stamped by Darin.
815
816         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
817         * DumpRenderTree/win/DumpRenderTree.vcproj:
818         * DumpRenderTree/win/ImageDiff.vcproj:
819         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
820
821 2008-03-08  Julien Chaffraix  <julien.chaffraix@gmail.com>
822
823         Reviewed by Mark Rowe.
824
825         DRT build fix for Tiger.
826
827         * DumpRenderTree/mac/DumpRenderTreeMac.h: Define BUILDING_ON_TIGER.
828
829 2008-03-07  Mark Rowe  <mrowe@apple.com>
830
831         Reviewed by Oliver Hunt.
832
833         Fix WebKit build with GCC 4.2.
834
835         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Use correct argument type in method signature.
836
837 2008-03-07  Stephanie Lewis <slewis@apple.com>
838
839         Reviewed by Oliver.
840
841         Add Windows part of <rdar://problem/5693690> 
842
843         * DumpRenderTree/win/DumpRenderTree.cpp:
844         (dump):
845         (main):
846
847 2008-03-07  Alp Toker  <alp@atoker.com>
848
849         Back out the r30818, r30819 build fix attempts now the GTK+ build
850         server has been upgraded.
851
852         * Scripts/webkitdirs.pm:
853
854 2008-03-07  Stephanie Lewis <slewis@apple.com>
855
856         Reviewed by Geoff.
857
858         <rdar://problem/5693690> run-webkit-tests swallows STDERR output, including WebCore LEAK messages
859
860         * DumpRenderTree/mac/DumpRenderTree.mm:
861         (dump): push EOF to stderr after every test
862         * Scripts/run-webkit-tests: collect stderr output and print it
863
864 2008-03-07  Steve Falkenburg  <sfalken@apple.com>
865
866         Get pdevenv working with Visual Studio Express.
867         
868         Reviewed by Adam.
869
870         * Scripts/pdevenv:
871
872 2008-03-06  Adele Peterson  <adele@apple.com>
873
874         Reviewed by Darin.
875
876         Updated for testing <rdar://problem/5785895> Implement hasFocus() for HTMLDocument (HTML5)
877
878         * DumpRenderTree/mac/UIDelegate.mm:
879         (-[UIDelegate webViewFocus:]): Remove duplicate code that was also in LayoutTestController::setWindowIsKey
880         (-[UIDelegate webViewUnfocus:]): Added.  In Safari, the default is to focus another window if there is one.
881          To easily test cases where the window is unfocused, I made this just call setWindowIsKey(false).
882
883 2008-03-06  Matt Lilek  <webkit@mattlilek.com>
884
885         Reviewed by Adam Roben.
886
887         Bug 17691: REGRESSION: FindSafari doesn't work
888         http://bugs.webkit.org/show_bug.cgi?id=17691
889
890         Swap my change from r30394 to use the Release libraries instead of Debug
891         since some machines don't have the Debug version.
892
893         * FindSafari/FindSafari.vcproj:
894
895 2008-03-06  Kevin McCullough  <kmccullough@apple.com>
896
897         Reviewed by Sam and Tim.
898
899         <rdar://5631450> Drosera: breakpoint indicators disappear after the
900         script is finished running.
901         - If there is a pre-existing breakpoint on a line when the file is
902         updated we need to redraw it.
903
904         * Drosera/debugger.js:
905
906 2008-03-06  Brady Eidson  <beidson@apple.com>
907
908         Tiger build fix...?
909
910         * DumpRenderTree/mac/WatchdogMac.mm:
911
912 2008-03-06  Brady Eidson  <beidson@apple.com>
913
914         Reviewed by Darin
915
916         Added a cross-platform Watchdog thread to DRT.
917
918         The current watchdog in both DRTWin and DRTMac is Timer based.  Therefore, deadlocks and long running
919         main thread hangs still affect DRT.
920
921         By placing the watchdog on a thread and having DRT "check in" after each test, long-running hangs
922         and true deadlocks can be caught.
923
924         There is one hook for platform specific code.  As I did my development and testing on Mac, and Mac has
925         `sample` available, the Mac implementation of this hook samples the process before it is killed.
926
927         I arbitrarily chose 30 seconds as the timeout for now - this can be tweaked easily if we find a need.
928
929         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
930         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added LINKER_DISPLAYS_MANGLED_NAMES
931
932         * DumpRenderTree/ForwardingHeaders/wtf/Locker.h: Added.
933         * DumpRenderTree/ForwardingHeaders/wtf/Threading.h: Added.
934
935         * DumpRenderTree/Watchdog.cpp: Added.
936         (Watchdog::Watchdog):
937         (Watchdog::~Watchdog):
938         (Watchdog::start):
939         (Watchdog::stop):
940         (Watchdog::checkIn):
941         (Watchdog::setWatchdogInterval):
942         (Watchdog::handleHang):
943         (Watchdog::watchdogThreadStart):
944         (Watchdog::watchdogThread):
945         * DumpRenderTree/Watchdog.h: Added.
946
947         * DumpRenderTree/mac/WatchdogMac.h: Added.
948         * DumpRenderTree/mac/WatchdogMac.mm: Added.
949         (WatchdogMac::handleHang): Sample the process and write it out to a file
950
951         * DumpRenderTree/mac/DumpRenderTree.mm:
952         (dumpRenderTree): Setup and start the watchdog before running any tests
953         (runTest): Checkin with the watchdog after each test
954
955 2008-03-05  Alp Toker  <alp@atoker.com>
956
957         Attempt to get the autotools build working again on the bot with
958         build-webkit.
959
960         Force the use of /bin/bash since we seem to have bash-isms in the
961         configure script right now.
962
963         * Scripts/webkitdirs.pm:
964
965 2008-03-05  Alp Toker  <alp@atoker.com>
966
967         Re-attempt to switch to the autotools build system for GTK+.
968
969         Change scripts to continue when distclean fails.
970
971         * Scripts/webkitdirs.pm:
972
973 2008-03-05  Alp Toker  <alp@atoker.com>
974
975         Force qmake for the GTK+ build until we get the build bot to succeed
976         with autotools (currently dies at make distclean)
977
978         * Scripts/webkitdirs.pm:
979
980 2008-03-04  Alp Toker  <alp@atoker.com>
981
982         Reviewed by Mark Rowe.
983
984         Switch the default GTK+ build system from qmake to autotools.
985
986         qmake can still be used by defining WEBKIT_BUILD_SYSTEM=qmake
987
988         * Scripts/build-webkit:
989         * Scripts/run-launcher:
990         * Scripts/run-webkit-tests:
991         * Scripts/webkitdirs.pm:
992
993 2008-03-04  Sam Weinig  <sam@webkit.org>
994
995         Reviewed by Darin Adler.
996
997         * Scripts/do-webcore-rename: Update renaming plan.
998
999 2008-03-02  Brent Fulgham  <bfulgham@gmail.com>
1000
1001         Reviewed by Alp Toker.
1002
1003         Remove some needless LIBS.
1004
1005         * GNUmakefile.am:
1006
1007 2008-03-02  Alp Toker  <alp@atoker.com>
1008
1009         Reviewed by Mark Rowe.
1010
1011         Split the WebKit GTK+ build out of the WebCore build and change the
1012         shared object name to match the package name.
1013
1014         * GNUmakefile.am:
1015
1016 2008-03-01  Mark Rowe  <mrowe@apple.com>
1017
1018         Reviewed by Tim Hatcher.
1019
1020         Update Xcode configuration to support building debug and release from the mysterious future.
1021
1022         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1023
1024 2008-02-29  David Kilzer  <ddkilzer@apple.com>
1025
1026         Pass the correct configuration switch (--Debug|--Release) to build-testkjs.
1027
1028         Reviewed by Dan.
1029
1030         Originally broken in r26838.
1031
1032         * Scripts/run-javascriptcore-tests: Push configuration switch onto @xcodeArgs
1033         not local, unused @args variable.
1034
1035 2008-02-29  David Kilzer  <ddkilzer@apple.com>
1036
1037         Bug 15754: webarchive layout tests fail when WebKit directory path contains symlinks
1038
1039         <http://bugs.webkit.org/show_bug.cgi?id=15754>
1040
1041         Reviewed by Geoff and Darin.
1042
1043         We were using -[NSFileManager currentDirectoryPath] to get the current working directory,
1044         then removing that path from all file:/// URLs in the WebArchive output so these tests
1045         would pass no matter where they were run.
1046
1047         The problem was that -[NSFileManager currentDirectoryPath] resolves symlinks in the
1048         current working directory, but the WebArchive does not.  This left the current working
1049         directory in all file:/// URLs in the test output, and thus all tests failed, for any
1050         developer that used symlinks to get to their WebKit source directory.
1051
1052         The fix is to look backwards for "/LayoutTests/" in the URL we're passed, and simply
1053         remove the current working directory path (no matter what it is) after "file://" but
1054         before "/LayoutTests/".  
1055
1056         * DumpRenderTree/mac/DumpRenderTree.mm:
1057         (normalizeWebResourceURL): Removed unused oldURLBase argument.  We now replace the
1058         current working directory as described above.
1059         (convertWebResourceResponseToDictionary): Remove unused oldURLBase argument.  Update
1060         calls to normalizeWebResourceURL().
1061         (serializeWebArchiveToXML): Removed now unused cwdURL variable.  Update calls to
1062         normalizeWebResourceURL() and convertWebResourceResponseToDictionary().
1063
1064 2008-02-26  Robin Dunn <robin@alldunn.com>
1065
1066         Reviewed by Kevin Ollivier.
1067
1068         Improvements to the wx build script.
1069
1070         http://bugs.webkit.org/show_bug.cgi?id=17492
1071
1072         * wx/build-wxwebkit:
1073         - Update the Windows dll copying logic to copy dlls inside WebKitLibraries/win
1074         - Allow the build script to properly find wxPython includes under different setups
1075         - Make sure WX_PREFIX is set to WXWIN (wxWindows dir environment var.) if not defined
1076
1077 2008-02-26  Timothy Hatcher  <timothy@apple.com>
1078
1079         Reviewed by Darin Adler.
1080
1081         * Scripts/build-webkit: Add --universal and --64-bit flags to make building
1082         64-bit architectures easy. Combine the two flags to build 4-way universal.
1083         * Makefile: Add "64" and "64u" make rules. Fix the universal rule to return
1084         non-zero when the build failes.
1085
1086 2008-02-26  Jessica Kahn  <jess@apple.com>
1087
1088         Reviewed by Darin.
1089
1090         * Scripts/gdb-safari: Set WEBKIT_UNSET_DYLD_FRAMEWORK_PATH in gdb's environment,
1091         so that Safari inherits it when launched. Preexisting code in WebKit checks this
1092         environment variable, and if set, unsets DYLD_FRAMEWORK_PATH, so that applications
1093         launched by Safari continue to use the standard system WebKit.
1094
1095 2008-02-25  Adam Roben  <aroben@apple.com>
1096
1097         Fix run-webkit-tests after r30394
1098
1099         * Scripts/webkitdirs.pm: Never append _debug to FindSafari's
1100         executable name.
1101
1102 2008-02-24  Darin Adler  <darin@apple.com>
1103
1104         * Scripts/do-webcore-rename: Make some updates based on a trial run of
1105         the renaming script.
1106
1107 2008-02-24  Darin Adler  <darin@apple.com>
1108
1109         * Scripts/do-webcore-rename: More renaming plans.
1110
1111 2008-02-23  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
1112
1113         Rubber stamped by Darin.
1114
1115         Add separator '\' after libJavaScriptCore_la_LIBADD and cleanup
1116         whitespaces introduced in the previous commit.
1117
1118         * GNUmakefile.am:
1119
1120 2008-02-23  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
1121
1122         Rubber-stamped by Darin.
1123
1124         * GNUmakefile.am: Add both GLOBALDEPS and WEBKITDEPS instead of DEPENDENCIES.
1125
1126 2008-02-23  David Kilzer  <ddkilzer@apple.com>
1127
1128         Please clarify licensing for some files
1129         <http://bugs.webkit.org/show_bug.cgi?id=14970>
1130
1131         Reviewed by Darin.
1132
1133         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Added
1134         copyright statement.  Replaced license with newer Apple BSD-style license.
1135         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Ditto.
1136         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Ditto.
1137         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.h: Ditto.
1138         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Ditto.
1139         * DumpRenderTree/win/TestNetscapePlugin/main.c: Ditto.
1140         * mangleme/LICENSE: Added (LGPL).
1141
1142 2008-02-22  Anders Carlsson  <andersca@apple.com>
1143
1144         Reviewed by Adam.
1145
1146         <rdar://problem/5748781> 
1147         https://bugs.webkit.org/show_bug.cgi?id=17413
1148         REGRESSION: Latest Nightly doesn't load Java plugin w/Safari 3.1b
1149         
1150         Copy the Java plug-in over to the new location.
1151         
1152         * FindSafari/FindSafari.cpp:
1153         (_tmain):
1154
1155 2008-02-22  Anders Carlsson  <andersca@apple.com>
1156
1157         Reviewed by Adam.
1158
1159         <rdar://problem/5747325> REGRESSION: HTTP layout tests hang
1160         
1161         * DumpRenderTree/win/DumpRenderTree.cpp:
1162         (runTest):
1163         Init the URL request with the correct timeout.
1164
1165 2008-02-21  Mike Auty  <mike.auty@gmail.com>
1166
1167         Reviewed by Alp Toker.
1168
1169         http://bugs.webkit.org/show_bug.cgi?id=17445
1170         [GTK] WebKit doesn't compile with LDFLAGS="-Wl,--as-needed"
1171
1172         GTK+/autotools build system improvements
1173
1174         The GNUmakefile.am files make use of the LDFLAGS variable to include library
1175         additions such as -ljpeg etc.  Unfortunately, if these inclusions aren't made
1176         in LIBADD/LDADD variables, then they are mis-ordered during the linking.
1177
1178         The as-needed flag discards libraries whose functions have not been needed by
1179         earlier libraries, which therefore makes the ordering important.
1180
1181         This moves all -l library inclusion statements from LDFLAGS variables to
1182         LIBADD/LDADD variables.
1183
1184         * GNUmakefile.am:
1185
1186 2008-02-20  Brent Fulgham  <bfulgham@gmail.com>
1187
1188         Reviewed by Alp.
1189
1190         - http://bugs.webkit.org/show_bug.cgi?id=17428
1191           Reenable a Windows-based launcher
1192
1193         This patch reenables the venerable Spinneret application,
1194         changing its name to match the other lanch applications.
1195
1196         * WinLauncher: Added.
1197         * WinLauncher/WinLauncher.cpp: Added.
1198         (WinLauncherWebHost::updateAddressBar):
1199         (WinLauncherWebHost::QueryInterface):
1200         (WinLauncherWebHost::AddRef):
1201         (WinLauncherWebHost::Release):
1202         (resizeSubViews):
1203         (_tWinMain):
1204         (MyRegisterClass):
1205         (InitInstance):
1206         (WndProc):
1207         (MyEditProc):
1208         (About):
1209         (loadURL):
1210         * WinLauncher/WinLauncher.h: Added.
1211         (WinLauncherWebHost::WinLauncherWebHost):
1212         (WinLauncherWebHost::didStartProvisionalLoadForFrame):
1213         (WinLauncherWebHost::didReceiveServerRedirectForProvisionalLoadForFrame):
1214         (WinLauncherWebHost::didFailProvisionalLoadWithError):
1215         (WinLauncherWebHost::didCommitLoadForFrame):
1216         (WinLauncherWebHost::didReceiveTitle):
1217         (WinLauncherWebHost::didReceiveIcon):
1218         (WinLauncherWebHost::didFinishLoadForFrame):
1219         (WinLauncherWebHost::didFailLoadWithError):
1220         (WinLauncherWebHost::didChangeLocationWithinPageForFrame):
1221         (WinLauncherWebHost::willPerformClientRedirectToURL):
1222         (WinLauncherWebHost::didCancelClientRedirectForFrame):
1223         (WinLauncherWebHost::willCloseFrame):
1224         (WinLauncherWebHost::windowScriptObjectAvailable):
1225         * WinLauncher/WinLauncher.ico: Added.
1226         * WinLauncher/WinLauncher.rc: Added.
1227         * WinLauncher/WinLauncher.vcproj: Added.
1228         * WinLauncher/resource.h: Added.
1229         * WinLauncher/small.ico: Added.
1230         * WinLauncher/stdafx.cpp: Added.
1231         * WinLauncher/stdafx.h: Added.
1232
1233 2008-02-19  Brady Eidson  <beidson@apple.com>
1234
1235         Reviewed by Geoff
1236
1237         Fixed a bug in DRT --threaded mode
1238
1239         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
1240         (startJavaScriptThreads): Don't detach the newly created thread.  The later call to stopJavaScriptThreads() tries
1241           to pthread_join() each thread that had been created, but you can't join a detached thread!
1242
1243 2008-02-18  Brady Eidson  <beidson@apple.com>
1244
1245         Changes by Geoff Garen, Reviewed by Darin
1246
1247         Fix for <rdar://5747529> - ObjC Exception can cause JSLock to never be released
1248
1249         DRT changes for test: platform/mac/plugins/webScriptObject-exception-deadlock.html
1250
1251         [WebScriptObject valueForKey:] might throw an exception, and previously might have "leaked" the global JSLock
1252         This test calls valueForKey, then runs some arbitrary Javascript on a 2ndary thread.  If the lock has leaked,
1253         this series of method calls will deadlock.  If things are good, it will complete successfully.
1254
1255         * DumpRenderTree/mac/ObjCController.m:
1256         (runJavaScriptThread):
1257         (+[ObjCController isSelectorExcludedFromWebScript:]):
1258         (+[ObjCController webScriptNameForSelector:]):
1259         (-[ObjCController testValueForKey]):
1260
1261 2008-02-18  Matt Lilek  <webkit@mattlilek.com>
1262
1263         Reviewed by Adam.
1264
1265         Remove FindSafari's Release configuration.
1266
1267         * FindSafari/FindSafari.vcproj:
1268
1269 2008-02-15  Adam Roben  <aroben@apple.com>
1270
1271         Fix a typo that broke the Mac build
1272
1273         Reviewed by Mark.
1274
1275         * Scripts/build-webkit:
1276
1277 2008-02-14  Adam Roben  <aroben@apple.com>
1278
1279         Turn on cross-document messaging support by default
1280
1281         Reviewed by Darin.
1282
1283         * Scripts/build-webkit:
1284
1285 2008-02-14  Adam Roben  <aroben@apple.com>
1286
1287         Conditionalize cross-document messaging support
1288
1289         The cross-document messaging parts of HTML 5 are in flux and we want
1290         ports to be able to turn off the support as needed.
1291
1292         Note that the support is turned off by default right now. A subsequent
1293         commit will turn it on by default.
1294
1295         Reviewed by Darin.
1296
1297         * Scripts/build-webkit:
1298
1299 2008-02-14  Darin Adler  <darin@apple.com>
1300
1301        - fix Windows build
1302
1303         * DumpRenderTree/win/UIDelegate.cpp:
1304         (UIDelegate::setStatusText): Update parameter types to match declaration.
1305
1306 2008-02-14  Oliver Hunt  <oliver@apple.com>
1307
1308         Reviewed by Geoff G and Weinig.
1309
1310         Add ability for DRT to report tests setting the status text.
1311
1312         * DumpRenderTree/LayoutTestController.cpp:
1313         (LayoutTestController::LayoutTestController):
1314         (dumpStatusCallbacksCallback):
1315         (LayoutTestController::staticFunctions):
1316         * DumpRenderTree/LayoutTestController.h:
1317         * DumpRenderTree/mac/UIDelegate.mm:
1318         (-[UIDelegate webView:setStatusText:]):
1319         * DumpRenderTree/win/UIDelegate.cpp:
1320         * DumpRenderTree/win/UIDelegate.h:
1321
1322 2008-02-13  Adam Roben  <aroben@apple.com>
1323
1324         Windows build fix
1325
1326         * DumpRenderTree/ForwardingHeaders/wtf/MathExtras.h: Added.
1327
1328 2008-02-13  Adam Roben  <aroben@apple.com>
1329
1330         Windows/GTK+ build fix
1331
1332         * DumpRenderTree/LayoutTestController.cpp: #include MathExtras.h to
1333         get isnan.
1334
1335 2008-02-13  Brady Eidson  <beidson@apple.com>
1336
1337         Reviewed by Darin Adler
1338
1339         Add some much needed Database support to DRT
1340
1341         * DumpRenderTree/LayoutTestController.cpp:
1342         (LayoutTestController::LayoutTestController):
1343         (dumpDatabaseCallbacksCallback): Flag to control if the UIDelegate methods related to
1344           databases are called
1345         (clearAllDatabasesCallback): Allow a test to delete all databases
1346         (setDatabaseQuotaCallback): Allow a test to set the quota new origins will get
1347         (LayoutTestController::staticFunctions):
1348
1349         * DumpRenderTree/LayoutTestController.h:
1350         (LayoutTestController::dumpDatabaseCallbacks):
1351         (LayoutTestController::setDumpDatabaseCallbacks):
1352
1353         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1354         (LayoutTestController::clearAllDatabases):
1355         (LayoutTestController::setDatabaseQuota):
1356
1357         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1358         (LayoutTestController::clearAllDatabases): Stubbed out
1359         (LayoutTestController::setDatabaseQuota): Ditto
1360         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1361         (LayoutTestController::clearAllDatabases): Stubbed out with error message
1362         (LayoutTestController::setDatabaseQuota): Ditto
1363
1364         * DumpRenderTree/mac/UIDelegate.mm:
1365         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): Print a
1366           message with details about the event then return a 5mb quota like before
1367
1368
1369 2008-02-12  Steve Falkenburg  <sfalken@apple.com>
1370
1371         Changes to support merged MIDL output.
1372
1373         All COM interfaces are now generated to WebKit.h.
1374
1375         Reviewed by Sam, Ada.
1376
1377         * Drosera/win/BaseDelegate.h:
1378         * Drosera/win/DebuggerClient.cpp:
1379         * Drosera/win/DebuggerDocumentPlatform.cpp:
1380         * Drosera/win/Drosera.cpp:
1381         * Drosera/win/ServerConnection.cpp:
1382         * Drosera/win/ServerConnection.h:
1383         * DumpRenderTree/win/DumpRenderTree.cpp:
1384         * DumpRenderTree/win/EditingDelegate.h:
1385         * DumpRenderTree/win/EventSender.cpp:
1386         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1387         * DumpRenderTree/win/FrameLoadDelegate.h:
1388         * DumpRenderTree/win/GCControllerWin.cpp:
1389         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1390         * DumpRenderTree/win/PolicyDelegate.h:
1391         * DumpRenderTree/win/ResourceLoadDelegate.h:
1392         * DumpRenderTree/win/UIDelegate.cpp:
1393         * DumpRenderTree/win/UIDelegate.h:
1394         * DumpRenderTree/win/WorkQueueItemWin.cpp:
1395
1396 2008-02-10  Dan Bernstein  <mitz@apple.com>
1397
1398         Reviewed by Oliver Hunt.
1399
1400         - fix a memory leak
1401
1402         * DumpRenderTree/cg/ImageDiffCG.cpp:
1403         (getDifferenceBitmap): Use a static CFMutableData instead of allocating
1404         and leaking the buffer each time.
1405
1406 2008-02-07  Adam Roben  <aroben@apple.com>
1407
1408         Fix error in bisect-builds when responding "broken" for the first
1409         build
1410
1411         Reviewed by Dave Kilzer.
1412
1413         * Scripts/bisect-builds: Only try to test the build if the nightly
1414         info for the current index has not been deleted.
1415
1416 2008-02-07  Geoffrey Garen  <ggaren@apple.com>
1417
1418         Reviewed by Alexey Proskuryakov.
1419
1420         Fixed two minor typos in the --root option, to get it working.
1421
1422         * Scripts/run-sunspider:
1423             1. Actually assign the function argument to our local variable.
1424             2. Actually set the $root variable, so we don't try to build later.
1425
1426 2008-02-05  Oliver Hunt  <oliver@apple.com>
1427
1428         RS=Eric.
1429
1430         Re-enable foreignObject by default as it is needed for a number of non-fO
1431         related SVG tests and none of the old known crashes occur anymore.
1432
1433         * Scripts/build-webkit:
1434
1435 2008-02-05  Steve Falkenburg  <sfalken@apple.com>
1436
1437         Build fix.  Don't override intermediate directory.
1438
1439         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1440
1441 2008-02-05  Holger Hans Peter Freyther  <zecke@selfish.org>
1442
1443         Build fix for Windows. willCloseFrame is a pure virtual and we are
1444         forced to have an implementation.
1445         
1446         This partially reverts r30014.
1447
1448         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1449         (FrameLoadDelegate::willCloseFrame):
1450         * DumpRenderTree/win/FrameLoadDelegate.h:
1451
1452 2008-02-05  Nikolas Zimmermann  <zimmermann@kde.org>
1453
1454         Reviewed by Holger.
1455
1456         Don't build wrapper for SVGTestCase.js (special file for svg/dynamic-updates)
1457
1458         * Scripts/make-js-test-wrappers:
1459
1460 2008-02-05  Holger Freyther  <zecke@selfish.org>
1461
1462         Reviewed by Darin.
1463
1464         In http://bugs.webkit.org/show_bug.cgi?id=16853 it was identified that the
1465         the output of the willCloseFrame and didClearWindowObject FrameLoadDelegate
1466         depends on the order the tests are executed.
1467         
1468         Propose to remove willCloseFrame and didlCearWindowObject output from the
1469         FrameLoadDelegate and update the test results. The output of didClearWindowObject
1470         is not interesting for any of the current tests and we have other ways to find
1471         out if a frame was closed or not.
1472
1473         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1474         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1475         (FrameLoadDelegate::didClearWindowObject):
1476         * DumpRenderTree/win/FrameLoadDelegate.h:
1477
1478 2008-02-04  Mark Rowe  <mrowe@apple.com>
1479
1480         Reviewed by Oliver Hunt.
1481
1482         Workaround for http://bugs.webkit.org/show_bug.cgi?id=16842
1483         Bug 16842: Hang in DRT in leaks mode due to signal handler doing unsafe things
1484
1485         Don't install the signal handler unless we are running the pixel tests.
1486         It is currently only used to restore the color profile, but by catching
1487         signals we can trigger a deadlock in DRT while running leak tests.
1488         The deadlock is tracked by http://bugs.webkit.org/show_bug.cgi?id=16842,
1489         and a more complete fix will need to be developed to address this for
1490         pixel tests as well.
1491
1492         * DumpRenderTree/mac/DumpRenderTree.mm:
1493         (dumpRenderTree):
1494
1495 2008-02-04  Mark Rowe  <mrowe@apple.com>
1496
1497        Gtk qmake build fix.
1498
1499         * Scripts/webkitdirs.pm:  Fix perl's complaint about an odd number of elements in anonymous hash.
1500
1501 2008-02-04  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
1502
1503         Reviewed by Alp Toker and Mark Rowe.
1504
1505         http://bugs.webkit.org/show_bug.cgi?id=16618
1506         [GTK] build-webkit and run-webkit-tests autootools support
1507
1508         * Scripts/build-webkit: added --database and --icon-database options
1509         * Scripts/run-launcher:
1510         * Scripts/run-webkit-tests:
1511         * Scripts/webkitdirs.pm:
1512
1513 2008-02-04  Oliver Hunt  <oliver@apple.com>
1514
1515         Reviewed by Steve F.
1516
1517         Partial fix for <rdar://5621244> Drag & Drop doesn't work correctly in DRT
1518
1519         Implement required DRT functionality to allow majority of Drag and Drop testcases to work.
1520         Issues include:
1521           * Uses Sleep() to implement leapForward reliably.
1522           * 3 DND tests still fail for reasons that i have not yet determined
1523           * Has to explicitly ignore an extraneous WM_MOUSELEAVE that i am at a loss to explain 
1524
1525         * DumpRenderTree/win/EventSender.cpp:
1526         (leapForwardCallback):
1527         (mouseDownCallback):
1528         (doMouseUp):
1529         (mouseUpCallback):
1530         (doMouseMove):
1531         (mouseMoveToCallback):
1532           Minor updates to these functions to handle the different message queue structure.
1533
1534         (replaySavedEvents):
1535           More complicated now.  Where possible we just use the old while-loop model of execution,
1536           but when leapForward has been used we have to jump through some hoops and set up an 
1537           inner event loop so that we can ensure messages get the correct time stamp.
1538
1539         * DumpRenderTree/win/UIDelegate.cpp:
1540         (UIDelegate::doDragDrop):
1541           Call replaySavedEvents directly to force synchronous handling of drag and drop.
1542
1543 2008-02-04  Rodney Dawes  <dobey@wayofthemonkey.com>
1544
1545         Reviewed by Alp Toker and Mark Rowe.
1546
1547         Fix http://bugs.webkit.org/show_bug.cgi?id=17175.
1548         Bug 17175: Use of C++ compiler flags in CFLAGS
1549
1550         * GNUmakefile.am: Use global_cxxflags as well as global_cflags in CXXFLAGS.
1551
1552 2008-02-04  Darin Adler  <darin@apple.com>
1553
1554         Reviewed by Geoff.
1555
1556         * Scripts/make-js-test-wrappers: Look at the whole LayoutTests tree, not just the fast
1557         and svg subdirectories. Added some more exceptions for the benefit of the fast/dom
1558         subdirectory.
1559
1560 2008-02-04  Adam Roben  <aroben@apple.com>
1561
1562         Windows Apple-only build fix
1563
1564         * DumpRenderTree/win/DumpRenderTree.vcproj: Added a new include
1565         directory.
1566
1567 2008-02-04  Alp Toker  <alp@atoker.com>
1568
1569         Rubber-stamped by Mark Rowe.
1570
1571         Remove all trailing whitespace in the GTK+ port and related
1572         components.
1573
1574         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
1575         * DumpRenderTree/gtk/GCControllerGtk.cpp:
1576         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1577         * GNUmakefile.am:
1578
1579 2008-02-01  Eric Seidel  <eric@webkit.org>
1580
1581         Reviewed by Oliver.
1582
1583         Also search LayoutTests/svg for js-based tests.
1584
1585         * Scripts/make-js-test-wrappers:
1586
1587 2008-01-31  Alp Toker  <alp@atoker.com>
1588
1589         Rubber-stamped by Adam Roben.
1590
1591         http://bugs.webkit.org/show_bug.cgi?id=17006
1592         [GTK] Header path should be webkit/webkit.h
1593
1594         Move the GTK+ API sources as needed and update the build systems.
1595
1596         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1597         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
1598         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
1599         * GNUmakefile.am:
1600         * GtkLauncher/main.c:
1601
1602 2008-01-30  Stephanie  <slewis@apple.com>
1603
1604         Reviewed by Geoff.
1605
1606         Add an option to run-webkit-tests to merge leaks results and print the number of unique leaks found under a certain call depth.  This should make it easier for the buildbots to track new leaks.
1607
1608         * Scripts/run-webkit-tests:
1609
1610 2008-01-30  Alexey Proskuryakov  <ap@webkit.org>
1611
1612         Reviewed by Adam Roben.
1613
1614         One more debug (external) fix.
1615
1616         * DumpRenderTree/win/DumpRenderTree.cpp: TestNetscapePlugin is built with a _debug suffix in both DebugInternal
1617         and Debug configurations. 
1618
1619 2008-01-29  Geoffrey Garen  <ggaren@apple.com>
1620
1621         Reviewed by Sam Weinig. Sam Weinig.
1622         
1623         Fixed <rdar://problem/5692566> fast/encoding/mailto-always-utf-8.html
1624         fails when run after fast/dom/Window/window-property-shadowing.html (16902)
1625
1626         Modified our policy delegates not to output window.name. Since a
1627         previous test may have explicitly set window.name, we can't rely on its
1628         implicit value in test results.
1629
1630         * DumpRenderTree/mac/PolicyDelegate.mm:
1631         (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
1632
1633         * DumpRenderTree/win/PolicyDelegate.cpp:
1634         (PolicyDelegate::decidePolicyForNavigationAction):
1635
1636 2008-01-29  Mark Rowe  <mrowe@apple.com>
1637
1638         Reviewed by Tim Hatcher.
1639
1640         <rdar://problem/5600926> WebCore on Tiger must link to its own copy of SQLite 3.4 or newer (so HTML database behavior will be correct).
1641
1642         * Scripts/build-webkit: Copy SQLite static library and headers into the build directory.
1643
1644 2008-01-29  David Kilzer  <ddkilzer@apple.com>
1645
1646         Refactor ChangeLog path code
1647
1648         Reviewed by Adam.
1649
1650         * Scripts/prepare-ChangeLog: Simplify code in one foreach() loop, and extract
1651         duplicate code in another foreach() loop.
1652
1653 2008-01-29  Alexey Proskuryakov  <ap@webkit.org>
1654
1655         Reviewed by Darin.
1656
1657         <rdar://problem/5710692> All storage tests fail/crash
1658
1659         * DumpRenderTree/mac/UIDelegate.mm:
1660         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): Set an
1661         arbitrary quota of 5 megabytes.
1662
1663         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
1664         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
1665         Removed unused (I think) code.
1666         
1667         * DumpRenderTree/win/UIDelegate.cpp:
1668         (UIDelegate::QueryInterface): IWebUIDelegatePrivate3 is now supported.
1669         (UIDelegate::webViewPainted): A stub implementation.
1670         (UIDelegate::exceededDatabaseQuota): Set an arbitrary quota of 5 megabytes.
1671         * DumpRenderTree/win/UIDelegate.h:
1672
1673 2008-01-27  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
1674
1675         GTK+ DRT build fix for breakage introduced in r29822.
1676
1677         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1678         (LayoutTestController::setPersistentUserStyleSheetLocation):
1679         (LayoutTestController::clearPersistentUserStyleSheet):
1680
1681 2008-01-27  Dan Bernstein  <mitz@apple.com>
1682
1683         Reviewed by Darin Adler.
1684
1685         - add support for directory prologues and epilogues to run-webkit-tests
1686         - allow setting a persistent user style sheet in DumpRenderTree
1687         - activate the WebKit Layout Tests font in Windows DumpRenderTree
1688
1689         * DumpRenderTree/LayoutTestController.cpp:
1690         (clearPersistentUserStyleSheetCallback): Added.
1691         (setPersistentUserStyleSheetLocationCallback): Added.
1692         (LayoutTestController::staticFunctions): Added.
1693         clearPersistentUserStyleSheet and setPersistentUserStyleSheet.
1694         * DumpRenderTree/LayoutTestController.h:
1695         * DumpRenderTree/mac/DumpRenderTree.mm:
1696         (setPersistentUserStyleSheetLocation): Added.
1697         (resetWebViewToConsistentStateBeforeTesting): Added the user style sheet
1698         to the set of things this function resets. Now it either disables the
1699         user style sheet or sets it to the persistent user style sheet and
1700         enables it.
1701         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1702         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1703         (LayoutTestController::setPersistentUserStyleSheetLocation): Added.
1704         (LayoutTestController::clearPersistentUserStyleSheet): Added.
1705         * DumpRenderTree/win/DumpRenderTree.cpp:
1706         (setPersistentUserStyleSheetLocation): Added.
1707         (initialize): Added the WebKit Layout Tests font to the set of fonts to
1708         install.
1709         (resetWebViewToConsistentStateBeforeTesting): See DumpRenderTree.mm.
1710         * DumpRenderTree/win/DumpRenderTreeWin.h:
1711         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1712         (LayoutTestController::setPersistentUserStyleSheetLocation): Added.
1713         (LayoutTestController::clearPersistentUserStyleSheet): Added.
1714         * Scripts/run-webkit-tests: Changed to look for, and if found process in
1715         DumpRenderTree, files named run-webkit-tests-prologue.html and
1716         run-webkit-tests-epilogue.html in the resources subdirectory of any
1717         test directory and platform test results directory. The prologues are
1718         processed before the first test from the directory (and its
1719         subdirectories) is run, and the epilogues are processed after the last
1720         test from the directory is run. Platform-specific prologues and
1721         epilogues are processed in order of specificity.
1722
1723 2008-01-25  Alexey Proskuryakov  <ap@webkit.org>
1724
1725         Reviewed by Mark Rowe.
1726
1727         <rdar://problem/5699933> http/tests/security/cross-frame-access-get.html is still failing
1728
1729         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Clear HTTP cache to ensure consistent test environment
1730         (matching Mac DRT).
1731         * DumpRenderTree/win/DumpRenderTree.vcproj: Link to CFNetwork.
1732
1733 2008-01-24  Sam Weinig  <sam@webkit.org>
1734
1735         Reviewed by Ada Chan.
1736
1737         Fix for <rdar://5131975> DumpRenderTree doesn't support undo/redo
1738
1739         - Adds simplified UndoManager to windows DRT to allow testing the
1740           undo/redo code paths in WebCore and WebKit.  This is a temporary
1741           solution to an issue that should eventually be solved by having a
1742           shared UndoManager in WebKit.
1743
1744         * DumpRenderTree/win/DumpRenderTree.cpp:
1745         (runTest):
1746         * DumpRenderTree/win/UIDelegate.cpp:
1747         (DRTUndoObject::DRTUndoObject):
1748         (DRTUndoObject::invoke):
1749         (DRTUndoStack::~DRTUndoStack):
1750         (DRTUndoStack::isEmpty):
1751         (DRTUndoStack::clear):
1752         (DRTUndoStack::push):
1753         (DRTUndoStack::pop):
1754         (DRTUndoManager::canRedo):
1755         (DRTUndoManager::canUndo):
1756         (DRTUndoManager::DRTUndoManager):
1757         (DRTUndoManager::removeAllActions):
1758         (DRTUndoManager::registerUndoWithTarget):
1759         (DRTUndoManager::redo):
1760         (DRTUndoManager::undo):
1761         (UIDelegate::UIDelegate):
1762         (UIDelegate::resetUndoManager):
1763         (UIDelegate::registerUndoWithTarget):
1764         (UIDelegate::removeAllActionsWithTarget):
1765         (UIDelegate::setActionTitle):
1766         (UIDelegate::undo):
1767         (UIDelegate::redo):
1768         (UIDelegate::canUndo):
1769         (UIDelegate::canRedo):
1770         * DumpRenderTree/win/UIDelegate.h:
1771
1772 2008-01-23  Adam Roben  <aroben@apple.com>
1773
1774         Allow directories containing ChangeLogs to be passed to
1775         resolve-ChangeLogs
1776
1777         Reviewed by David Kilzer.
1778
1779         * Scripts/resolve-ChangeLogs:
1780         (sub findChangeLog): Return a ChangeLog contained within the specified
1781         directory if one exists.
1782
1783 2008-01-23  Steve Falkenburg  <sfalken@apple.com>
1784
1785         <rdar://problem/5698732> Copyright strings should include 2008
1786
1787         Reviewed by Sam.
1788
1789         * Drosera/win/Drosera.vcproj/Drosera.rc:
1790         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc:
1791
1792 2008-01-23  Alp Toker  <alp@atoker.com>
1793
1794         Rubber-stamped by Mark Rowe.
1795
1796         Remove whitespace after -I in automake include lists.
1797
1798         * GNUmakefile.am:
1799
1800 2008-01-23  Michael Goddard <michael.goddard@trolltech.com>
1801
1802         Reviewed by Lars Knoll <lars@trolltech.com>.
1803
1804         Reworked the JavaScriptCore Qt bindings:
1805         
1806         * Update JS DRT controller for Qt JS binding changes.
1807         There were two functions that needed some changes
1808         so that the layout tests would work, so this makes
1809         a few tests pass again.
1810         
1811         * Bump the timeout for layout tests up to 11s.
1812         At least some tests have an internal timeout of
1813         10 seconds, so make the waitUntilDone approach
1814         wait at least 11s.  fast/dom/open-and-close-by-DOM.html
1815         is one of these - now the failure message is more
1816         accurate.
1817         
1818
1819         * DumpRenderTree/qt/jsobjects.cpp:
1820         (LayoutTestController::waitUntilDone):
1821         * DumpRenderTree/qt/jsobjects.h:
1822
1823 2008-01-22  Anders Carlsson  <andersca@apple.com>
1824
1825         Reviewed by Darin and Adam.
1826
1827         <rdar://problem/5688975>
1828         div element on microsoft site has wrong left offset.
1829         
1830         Add new method for testing the return vale of NPN_GetProperty.
1831         
1832         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1833         (pluginInvoke):
1834
1835 2008-01-22  Alexey Proskuryakov  <ap@webkit.org>
1836
1837         Reviewed by Adam Roben.
1838
1839         <rdar://problem/5670257> editing/selection/4895428-3.html makes editing/selection/5131716-2.html fail
1840
1841         * DumpRenderTree/win/EventSender.cpp: (makeEventSender): Reset static variables for a new test.
1842
1843 2008-01-21  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
1844
1845         Reviewed by Alp Toker.
1846
1847         http://bugs.webkit.org/show_bug.cgi?id=16955
1848         Get errors when cross-compile webkit-gtk
1849
1850         * GNUmakefile.am: Removed ICU_CFLAGS 
1851
1852 2008-01-21  Darin Adler  <darin@apple.com>
1853
1854         Reviewed by Mitz and Adam.
1855
1856         * Scripts/svn-create-patch: Sort ChangeLog files first. Also slightly improved the
1857         sorting speed by doing all sort criteria in a single pass instead of three sorts.
1858
1859 2008-01-21  Simon Hausmann  <hausmann@webkit.org>
1860
1861         Reviewed by Holger.
1862
1863         Fix focus chain handling and cycling through focusable objects (links) using tab/backtab.
1864         
1865         * Fix GraphicsContext::drawFocusRing to also draw single focus rects.
1866         * Implemented QWebPage::focusNextPrevChild by sending fake tab/shift-tab events
1867         and make the return value depend on whether we successfully determined a focusable
1868         node or not.
1869         * Changed QWebView::focusNextPrevChild() to call the base QWidget implementation correctly
1870         if we could not handle the focus chain ourselves.
1871         * Changed the focus policy of QWebView to correctly use WheelFocus instead of ClickFocus.
1872         * Made ChromeClientQt::canTakeFocus() and takeFocus() dummy method since they are only
1873         used to control the situation of stepping out of the focus chain inside the page.
1874         * Made inclusion of links in the focus chain configurable through QWebSettings::LinksIncludedInFocusChain.
1875         The layout tests expect this to be disabled but for the user it seems sensible to have it
1876         on by default, hence the default in qwebsettings.cpp
1877         
1878
1879         * DumpRenderTree/qt/DumpRenderTree.cpp:
1880         (WebCore::WebPage::WebPage):
1881
1882 2008-01-19  Mark Rowe  <mrowe@apple.com>
1883
1884         Reviewed by Alp Toker.
1885
1886         Allow the --http flag to run-webkit-tests to override
1887         the default behaviour of disabling HTTP tests for Qt,
1888         Gtk and Wx.
1889
1890         * Scripts/run-webkit-tests:
1891
1892 2008-01-19  David Kilzer  <ddkilzer@apple.com>
1893
1894         <rdar://problem/5695344> check-for-global-initializers script never checks any object files
1895
1896         Reviewed by Darin.
1897
1898         We now touch a check-for-global-initializers.timestamp file in
1899         the TARGET_TEMP_DIR directory to determine when new object files
1900         have been compiled and thus need to be checked.  If the timestamp
1901         file doesn't exist, all object files will be checked.
1902
1903         Previously the modification time of the "executable" (the
1904         framework binary, e.g., WebKit.framework/WebKit) was used, but
1905         since this was the last file modified at the end of the compile
1906         phase, no object files would ever get checked!
1907
1908         Also added JSCustomSQLTransactionCallback.o to the list of files
1909         since it has static initializers in Debug builds of WebCore.
1910
1911         * Scripts/check-for-global-initializers:
1912
1913 2008-01-18  Adam Roben  <aroben@apple.com>
1914
1915         Build fix
1916
1917         * Scripts/build-webkit:
1918
1919 2008-01-18  Beth Dakin  <bdakin@apple.com>
1920
1921         Reviewed by Oliver.
1922
1923         Update build-webkit to account for foreign-object being disabled by 
1924         default.
1925
1926         * Scripts/build-webkit:
1927
1928 2008-01-18  Adam Roben  <aroben@apple.com>
1929
1930         Updated for method renames
1931
1932         Reviewed by Adele.
1933
1934         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1935         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
1936         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1937         (LayoutTestController::setMainFrameIsFirstResponder):
1938         (LayoutTestController::setWindowIsKey):
1939         * DumpRenderTree/mac/UIDelegate.mm:
1940         (-[UIDelegate webViewFocus:]):
1941         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1942         (FrameLoadDelegate::didCommitLoadForFrame):
1943
1944 2008-01-18  Alexey Proskuryakov  <ap@webkit.org>
1945
1946         Reviewed by Adam Roben.
1947
1948         Fix plugin-related tests in Debug_Internal configuration, which are failing because of CRT version mismatch
1949         between DRT and TestNetscapePlugin.
1950
1951         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Added a Debug_Internal configuration.
1952         * DumpRenderTree/DumpRenderTree.sln: Use this configuration.
1953
1954 2008-01-18  Simon Hausmann  <hausmann@webkit.org>
1955
1956         Reviewed by Holger.
1957
1958         Fix fast/dom/Window/window-resize.html
1959         
1960         In DRT connect the page's geometryChangeRequest signal to a slot that
1961         sets the geometry of the view widget.
1962         
1963
1964         * DumpRenderTree/qt/DumpRenderTree.cpp:
1965         (WebCore::WebPage::setViewGeometry):
1966         (WebCore::WebPage::WebPage):
1967
1968 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
1969
1970         Build fix.
1971
1972         * Drosera/DroseraWin.make:
1973
1974 2008-01-17  Darin Adler  <darin@apple.com>
1975
1976         * Scripts/run-webkit-tests: Fixed a bug number.
1977
1978 2008-01-17  Alexey Proskuryakov  <ap@webkit.org>
1979
1980         Reviewed by Adam Roben.
1981
1982         http://bugs.webkit.org/show_bug.cgi?id=16908
1983         run-webkit-tests complains about missing FindSafari.exe
1984
1985         * Scripts/webkitdirs.pm: Append _debug as appropriate.
1986
1987 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
1988
1989         Re-add DEBUG_WEBKIT_HAS_SUFFIX.
1990         
1991         Rubber-stamped by Jon Honeycutt.
1992
1993         * DumpRenderTree/win/DumpRenderTree.vcproj:
1994
1995 2008-01-16  Alp Toker  <alp@atoker.com>
1996
1997         Reviewed by Mark Rowe.
1998
1999         http://bugs.webkit.org/show_bug.cgi?id=16218
2000         [GTK] API: Should this entry point be called go_back rather than go_backward?
2001
2002         Track back/forward API changes in the tools.
2003
2004         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
2005         (BackForwardItem::invoke):
2006         * GtkLauncher/main.c:
2007         (go_back_cb):
2008
2009 2008-01-16  Adam Roben  <aroben@apple.com>
2010
2011         Windows build fix after r29488
2012
2013         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2014         Build into a subdirectory of $WebKitOutputDir\bin to match where DRT
2015         expects to find the plugin.
2016
2017 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
2018
2019         Reviewed by Sam Weinig.
2020         
2021         Fixed the waitUntilDone watchdog timer -- the old code never added the
2022         timer to the run loop, so it didn't do anything.
2023
2024         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2025         (LayoutTestController::setWaitToDump):
2026         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2027         (LayoutTestController::setWaitToDump):
2028
2029 2008-01-14  Steve Falkenburg  <sfalken@apple.com>
2030
2031         Use shared vsprops for most vcproj properties.
2032         
2033         Reviewed by Darin.
2034
2035         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2036         * DumpRenderTree/win/DumpRenderTree.vcproj:
2037         * DumpRenderTree/win/ImageDiff.vcproj:
2038         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2039         * FindSafari/FindSafari.vcproj:
2040
2041 2008-01-14  Stephanie  <slewis@apple.com>
2042
2043        Reviewed by NOBODY.
2044   
2045        revert accidental character.
2046
2047        * Scripts/run-webkit-tests:
2048
2049 2008-01-14  Stephanie  <slewis@apple.com>
2050
2051         RS=Oliver
2052
2053         add Quicktime PPC only leaks to Leopard exclude list. See <rdar://problem/5667132>
2054
2055         * Scripts/run-webkit-tests:
2056
2057 2008-01-14  Darin Adler  <darin@apple.com>
2058
2059         * Scripts/do-webcore-rename: Queue up another rename.
2060
2061 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
2062
2063         Reviewed by Darin.
2064
2065         * Allow to run the tests in reverse order to spot test cases where the result depends on the order
2066         the tests were ran.
2067         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
2068
2069         * Scripts/run-webkit-tests:
2070
2071 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
2072
2073         Reviewed by Darin.
2074
2075         * Randomize tests array to spot test cases where the results depends on the order
2076         the tests are ran.
2077         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
2078
2079         * Scripts/run-webkit-tests:
2080
2081 2008-01-14  Darin Adler  <darin@apple.com>
2082
2083         * Scripts/run-webkit-tests: More ignore list tweaking.
2084
2085 2008-01-14  Darin Adler  <darin@apple.com>
2086
2087         * Scripts/run-webkit-tests: Add another leak to the ignore list.
2088
2089 2008-01-14  Dan Bernstein  <mitz@apple.com>
2090
2091         Reviewed by Adam Roben.
2092
2093         - try to fix failure in fast/dom/Window/window-onFocus.html seen on the
2094           build bots
2095
2096         * DumpRenderTree/win/DumpRenderTree.cpp:
2097         (resetWebViewToConsistentStateBeforeTesting): Focus the web view.
2098
2099 2008-01-13  Steve Falkenburg  <sfalken@apple.com>
2100
2101         Share common files across projects.
2102         
2103         Unify vsprops files
2104         Debug:          common.vsprops, debug.vsprops
2105         Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
2106         Release:        common.vsprops, release.vsprops
2107         
2108         Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
2109         debug_internal.vsprops will be mostly empty except for file path prefix modifiers.
2110
2111         Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.
2112
2113         Reviewed by Adam Roben.
2114
2115         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2116         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Removed.
2117         * Drosera/win/Drosera.vcproj/VERSION: Removed.
2118         * Drosera/win/Drosera.vcproj/auto-version.sh: Removed.
2119         * Drosera/win/Drosera.vcproj/debug.vsprops: Removed.
2120         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Removed.
2121         * Drosera/win/Drosera.vcproj/release.vsprops: Removed.
2122         * DumpRenderTree/win/DumpRenderTree.vcproj:
2123         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2124         * DumpRenderTree/win/debug.vsprops: Removed.
2125         * DumpRenderTree/win/debug_internal.vsprops: Removed.
2126         * DumpRenderTree/win/release.vsprops: Removed.
2127
2128 2008-01-13  Brent Fulgham  <bfulgham@gmail.com>
2129
2130         Reviewed by Maciej.
2131
2132         - http://bugs.webkit.org/show_bug.cgi?id=16314
2133           Script to launch Drosera
2134
2135         * Scripts/gdb-drosera: Added.
2136         * Scripts/run-drosera: Added.
2137         * Scripts/run-drosera-nightly.cmd: Added.
2138         * Scripts/webkitdirs.pm: Added runDrosera function.
2139
2140 2008-01-13  Dan Bernstein  <mitz@apple.com>
2141
2142         - fix breakage due to last-minute change
2143
2144         * DumpRenderTree/win/DumpRenderTree.cpp:
2145         (runTest): Declare the loop variable.
2146
2147 2008-01-13  Dan Bernstein  <mitz@apple.com>
2148
2149         Reviewed by Adam Roben.
2150
2151         - fix <rdar://problem/5132009> Windows DRT does not support multiple windows
2152
2153         * DumpRenderTree/win/DumpRenderTree.cpp:
2154         (DumpRenderTreeWndProc):
2155         (initialize):
2156         (dumpBackForwardList):
2157         (dumpBackForwardListForAllWindows):
2158         (dump):
2159         (resetWebViewToConsistentStateBeforeTesting): Factored out of
2160         runTest().
2161         (runTest):
2162         (allWindows): Added. Returns a vector of all open windows.
2163         (windowToWebViewMap): Added. Returns a map from open windows to their
2164         WebViews.
2165         (createWebViewAndOffscreenWindow): Factored out of main() to be
2166         reusable for creating extra windows.
2167         (main):
2168         * DumpRenderTree/win/DumpRenderTreeWin.h:
2169         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2170         (LayoutTestController::windowCount): Implemented.
2171         * DumpRenderTree/win/UIDelegate.cpp:
2172         (UIDelegate::createWebViewWithRequest): Implemented.
2173         (UIDelegate::webViewClose): Implemented.
2174         * DumpRenderTree/win/UIDelegate.h:
2175
2176 2008-01-12  Alp Toker  <alp@atoker.com>
2177
2178         Reviewed by Mark Rowe.
2179
2180         Hide non-public symbols in GTK+/autotools release builds.
2181
2182         * GNUmakefile.am:
2183
2184 2008-01-12  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
2185
2186         Reviewed by Ap.
2187
2188         * Make launching of the WebKit httpd work on GNU/Debian/Linux
2189         
2190         The configuration of Apache2 and installation does not depend on
2191         the kernel but on the distribution policy. Make launching of httpd
2192         work for Debian derived distributions.
2193
2194         * Scripts/run-webkit-httpd:
2195         * Scripts/run-webkit-tests:
2196         * Scripts/webkitdirs.pm:
2197
2198 2008-01-12  Mark Rowe  <mrowe@apple.com>
2199
2200         Reviewed by Maciej Stachowiak.
2201
2202         Fix crash in http/tests/security/local-JavaScript-from-remote.html under guard malloc.
2203
2204         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Retain string before returning it to
2205         match the callers expectations that it can take ownership of the string.
2206
2207 2008-01-11  Alexey Proskuryakov  <ap@webkit.org>
2208
2209         Reviewed by Adam Roben.
2210
2211         <rdar://problem/5667275> fast/dynamic/layer-hit-test-crash.html is failing
2212
2213         * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ignore WM_MOUSELEAVE events,
2214         as these are only posted because the test window is not a normal visible one, and
2215         they confuse drag&drop machinery.
2216
2217 2008-01-11  Adam Roben  <aroben@apple.com>
2218
2219         Fix a crash when pathToLocalResource fails and a leak
2220
2221         Reviewed by Darin.
2222
2223         * DumpRenderTree/LayoutTestController.cpp:
2224         (pathToLocalResourceCallback): Dont leak the JSStringRef, and make
2225         sure not to pass null to JSValueMakeString.
2226         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2227         (LayoutTestController::pathToLocalResource): Print an error message if
2228         the conversion fails so it's clear what happened.
2229
2230 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
2231
2232         Reviewed by John Sullivan.
2233
2234         * DumpRenderTree/mac/GCControllerMac.mm:
2235         (GCController::collectOnAlternateThread): Updated for name change.
2236
2237 2008-01-10  Kevin Ollivier  <kevino@theolliviers.com>
2238
2239         wx build fix. Don't build dftables any longer since it's now a Perl
2240         script.
2241
2242         * wx/build-wxwebkit:
2243
2244 2008-01-10  Sam Weinig  <sam@webkit.org>
2245
2246         Reviewed by Anders Carlsson.
2247
2248         Make DRT track open windows instead of allocated windows so that
2249         we can avoid ASSERTION due to late deallocs out of our control.
2250
2251         * DumpRenderTree/mac/DumpRenderTree.mm:
2252         (dumpBackForwardListForAllWindows):
2253         (runTest):
2254         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2255         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2256         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2257         (+[DumpRenderTreeWindow openWindows]):
2258         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
2259         (-[DumpRenderTreeWindow close]):
2260         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2261         (LayoutTestController::windowCount):
2262
2263 2008-01-10  Ada Chan  <adachan@apple.com>
2264
2265         Meta key is not the same as Alt key on windows.
2266
2267         Reviewed by Darin.
2268
2269         * DumpRenderTree/win/EventSender.cpp:
2270         (keyDownCallback):
2271
2272 2008-01-09  Kevin McCullough  <kmccullough@apple.com>
2273
2274         Reviewed by Darin, Sam and Adam.
2275
2276         -<rdar://problem/5654486> REGRESSION (Safari 3.0.4-TOT): clicking on
2277         link in gmail message displays JavaScript alert falsely complaining
2278         about pop-up blocking.
2279         - Added the ability to enable the pop-up blocker via the
2280         LayoutTestController.
2281
2282         * DumpRenderTree/LayoutTestController.cpp:
2283         (setPopupBlockingEnabledCallback):
2284         (LayoutTestController::staticFunctions):
2285         * DumpRenderTree/LayoutTestController.h:
2286         * DumpRenderTree/mac/DumpRenderTree.mm:
2287         (setDefaultsToConsistentValuesForTesting):
2288         (resetWebViewToConsistentStateBeforeTesting):
2289         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2290         (LayoutTestController::setPopupBlockingEnabled):
2291
2292 2008-01-10  Lars Knoll  <lars@trolltech.com>
2293
2294         Reviewed by Simon.
2295
2296         rename QWebPageHistory to QWebHistory.
2297         
2298
2299         * DumpRenderTree/qt/jsobjects.cpp:
2300
2301 2008-01-09  Maciej Stachowiak  <mjs@apple.com>
2302
2303         Reviewed by Darin.
2304         
2305         - add some more renames, adjust some
2306
2307         * Scripts/do-webcore-rename:
2308
2309 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
2310
2311         Reviewed by Oliver.
2312
2313         Enable SVG Fonts support by default.
2314
2315         * Scripts/build-webkit:
2316
2317 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
2318
2319         Reviewed by Adam.
2320
2321         Fixes: http://bugs.webkit.org/show_bug.cgi?id=16244
2322         DRT doesn't handle platform specific pixel test results correctly.
2323
2324         <test>-expected.txt files and <test>-expected.png files may now live
2325         in different directories (ie. a cross-platform <test>-expected.txt file
2326         and a platform-specific <test>-expected.png file).
2327
2328         * Scripts/run-webkit-tests:
2329
2330 2008-01-04  Kevin McCullough  <kmccullough@apple.com>
2331
2332         Reviewed by Darin.
2333
2334         - <rdar://problem/5666914> fast/regex/test{1,4}.html are failing
2335         DRT did not correctly handle printing the '\0' char.  Now it does.
2336
2337         * DumpRenderTree/win/DumpRenderTree.cpp:
2338         (dumpFramesAsText):
2339         (dump):
2340
2341 2008-01-07  Simon Hausmann  <hausmann@webkit.org>
2342
2343         Reviewed by Lars.
2344
2345         Ported of the network backend of the Qt platform to Qt 4.4's new networking API.
2346         
2347
2348         * DumpRenderTree/qt/main.cpp:
2349         * DumpRenderTree/qt/testplugin.cpp:
2350         * DumpRenderTree/qt/testplugin.h:
2351
2352 2008-01-05  Mark Rowe  <mrowe@apple.com>
2353
2354         Reviewed by Alp Toker.
2355
2356         Fix hang in fast/frames/frame-display-none-focus.html during Gtk layout tests.
2357
2358         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2359         (processWork): Process pending work.
2360         (webViewLoadFinished): Schedule processing of pending work.
2361         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Use webkit_web_frame_reload.
2362
2363 2008-01-05  Darin Adler  <darin@apple.com>
2364
2365         * Scripts/do-webcore-rename: Some more renaming plans.
2366
2367 2008-01-04  Alice Liu  <alice.liu@apple.com>
2368
2369         Reviewed by Alexey and Darin.
2370
2371         Adding "home" and "end" to DRT's keydown since
2372         DOM key events can't handle keyIdentifiers at this point. 
2373
2374         * DumpRenderTree/mac/EventSendingController.mm:
2375         (-[EventSendingController keyDown:withModifiers:]):
2376         * DumpRenderTree/win/EventSender.cpp:
2377         (keyDownCallback):
2378
2379 2008-01-04  Lars Knoll  <lars@trolltech.com>
2380
2381         Reviewed by Simon.
2382
2383         fix DRT after the changes to QWebPage.
2384         
2385         The great thing is that we actually don't have
2386         any regressions from the QWebPage change :)
2387         
2388
2389         * DumpRenderTree/qt/DumpRenderTree.cpp:
2390         (WebCore::DumpRenderTree::DumpRenderTree):
2391
2392 2008-01-04  Lars Knoll  <lars@trolltech.com>
2393
2394         Reviewed by Simon.
2395
2396         make QWebPage a QObject and get things to compile.
2397         
2398         Nothing works currently though.
2399         
2400
2401         * DumpRenderTree/qt/DumpRenderTree.cpp:
2402         (WebCore::DumpRenderTree::DumpRenderTree):
2403
2404 2008-01-04  Lars Knoll  <lars@trolltech.com>
2405
2406         Reviewed by Simon.
2407
2408         take a QString as identifier in QWebFrame::addToJSWindowObject.
2409
2410         * DumpRenderTree/qt/DumpRenderTree.cpp:
2411         (WebCore::DumpRenderTree::initJSObjects):
2412
2413 2008-01-04  Alp Toker  <alp@atoker.com>
2414
2415         GTK+ DRT build fix for breakage introduced in r29149.
2416
2417         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2418         (LayoutTestController::execCommand):
2419
2420 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
2421
2422         Reviewed by Darin.
2423
2424         <rdar://problem/5463489> A number of layout tests should be using execCommand instead of textInputController
2425
2426         Added layoutTestController.execCommand to access editor commands that are not available
2427         via document.execCommand.
2428
2429         * DumpRenderTree/LayoutTestController.cpp:
2430         (execCommandCallback):
2431         (LayoutTestController::staticFunctions):
2432         * DumpRenderTree/LayoutTestController.h:
2433         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2434         (LayoutTestController::execCommand):
2435         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2436         (LayoutTestController::queueLoad):
2437         (LayoutTestController::execCommand):
2438
2439 2008-01-03  Alice Liu  <alice.liu@apple.com>
2440
2441         Reviewed by Darin, Mitz.
2442
2443         fixed <rdar://5130762> mousedowns in different locations increase the clickcount incorrectly
2444
2445         the clickcount should not increase if the last click was at a different location.  it's a new click.
2446
2447         * DumpRenderTree/mac/DumpRenderTree.mm:
2448         (runTest):
2449         * DumpRenderTree/mac/EventSendingController.h:
2450         * DumpRenderTree/mac/EventSendingController.mm:
2451         (-[EventSendingController mouseDown]):
2452         (-[EventSendingController mouseUp]):
2453
2454 2008-01-03  Darin Adler  <darin@apple.com>
2455
2456         Reviewed by Adam.
2457
2458         * Scripts/update-webkit: Make this work a little better for the people at Apple
2459         who have a directory named Internal.
2460
2461 2008-01-03  Adam Roben  <aroben@apple.com>
2462
2463         Use HTTP::Date instead of Date::Parse because it's installed by Cygwin by default
2464
2465         Rubberstamped by Mark.
2466
2467         * Scripts/update-webkit-auxiliary-libs:
2468
2469 2008-01-03  Adam Roben  <aroben@apple.com>
2470
2471         Fix Bug 15663: update-webkit re-downloads WebKitAuxiliaryLibrary unnecessarily
2472
2473         http://bugs.webkit.org/show_bug.cgi?id=15663
2474
2475         Added a fuzz factor into the Last-Modified comparison for downloading
2476         WebKitAuxiliaryLibrary.zip.
2477
2478         The zip file is served from a set of mirrors who give Last-Modified
2479         times that are off by 1-3 seconds from each other. This was causing
2480         the build bots to redownload WebKitAuxiliaryLibrary for every build,
2481         which would then cause all of WebCore to rebuild each time.
2482
2483         Reviewed by Mark.
2484
2485         * Scripts/update-webkit-auxiliary-libs: Check if the new zip file is
2486         at least 30 seconds newer than the old one -- otherwise we assume that
2487         the difference in time is due to the mirrors being slightly offset
2488         from each other.
2489         (sub lastModifiedToUnixTime): Added.
2490
2491 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
2492
2493         Windows build fix.
2494
2495         * DumpRenderTree/ForwardingHeaders/wtf/HashTraits.h: Added (needed by COMPtr.h).
2496
2497 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
2498
2499         Reviewed by Lars.
2500
2501         Moved QWebPage::open to QWebFrame::load and added setHtml.
2502         
2503
2504         * DumpRenderTree/qt/DumpRenderTree.cpp:
2505         (WebCore::DumpRenderTree::open):
2506
2507 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
2508
2509         Reviewed by Lars.
2510
2511         Added the first revision of QWebView and started moving functionality from QWebPave over to QWebView and QWebFrame.
2512         
2513
2514         * DumpRenderTree/qt/DumpRenderTree.cpp:
2515         (WebCore::DumpRenderTree::DumpRenderTree):
2516
2517 2008-01-02  Sam Weinig  <sam@webkit.org>
2518
2519         * Scripts/do-webcore-rename: Yet more renaming ideas.
2520
2521 2008-01-02  Darin Adler  <darin@apple.com>
2522
2523         * Scripts/do-webcore-rename: More renaming ideas. (Maciej, please merge yours with mine.)
2524
2525 2008-01-02  Alice Liu  <alice.liu@apple.com>
2526
2527         Reviewed by Sam Weinig.
2528
2529         fixing assertion hit with editing/selection/move-begin-end.html
2530
2531         * DumpRenderTree/ForwardingHeaders/wtf/ASCIICType.h: Added.
2532         * DumpRenderTree/win/DumpRenderTree.vcproj:
2533         * DumpRenderTree/win/EventSender.cpp:
2534         (keyDownCallback):
2535         using isupper will cause an assertion for inputs outside of ascii range. use isASCIIUpper instead.
2536
2537 2008-01-02  Darin Adler  <darin@apple.com>
2538
2539         * Scripts/do-webcore-rename: Some more name change plans.
2540
2541 2008-01-02  Alice Liu  <alice.liu@apple.com>
2542
2543         Reviewed by Maciej.
2544
2545         Added handling for page up and page down in EventSender
2546
2547         * DumpRenderTree/mac/EventSendingController.mm:
2548         (-[EventSendingController keyDown:withModifiers:]):
2549         * DumpRenderTree/win/EventSender.cpp:
2550         (keyDownCallback):
2551
2552 2008-01-02  Alexey Proskuryakov  <ap@webkit.org>
2553
2554         Reviewed by Darin.
2555
2556         Fix fast/events/arrow-keys-on-body.html for real.
2557
2558         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Pass proper keyData for WM_KEYUP, too.
2559
2560 2008-01-02  Luca Bruno  <lethalman88@gmail.com>
2561
2562         Reviewed by Darin.
2563
2564         http://bugs.webkit.org/show_bug.cgi?id=16674
2565         [GTK] run-launcher sets wrong LD_LIBRARY_PATH
2566
2567         * Scripts/run-launcher:
2568
2569 2007-12-31  Darin Adler  <darin@apple.com>
2570
2571         Suggested by Antti.
2572
2573         * Scripts/webkitdirs.pm: Turned off the QuickTime requirement for Windows until
2574         we get it installed on the build bots.
2575
2576 2007-12-30  Eric Seidel  <eric@webkit.org>
2577
2578         Reviewed by Sam.
2579
2580         * Scripts/do-webcore-rename: Add a few more planned renames s/(\w+)Imp/\1/
2581
2582 2007-12-29  Darin Adler  <darin@apple.com>
2583
2584         Reviewed by Oliver.
2585
2586         - fix http://bugs.webkit.org/show_bug.cgi?id=16663
2587           leak bot shows createCStringFromNPVariant result leaking
2588
2589         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2590         (pluginInvoke): Added a missing free.
2591
2592 2007-12-26  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
2593
2594         Reviewed by Alp Toker.
2595
2596         http://bugs.webkit.org/show_bug.cgi?id=16390
2597         Use autotools or GNU make as the build system for the GTK port
2598
2599         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: include glib.h
2600         * GNUmakefile.am: Added.
2601
2602 2007-12-24  Alexey Proskuryakov  <ap@webkit.org>
2603
2604         Reviewed by Oliver.
2605
2606         Fix fast/events/arrow-keys-on-body.html, failing on Windows.
2607
2608         * DumpRenderTree/win/EventSender.cpp:
2609         (keyDownCallback): Add KF_EXTENDED flag to arrow keys. Also add a count
2610         of 1, even though WebKit currently ignores it.
2611
2612 2007-12-23  Kevin Ollivier  <kevino@theolliviers.com>
2613
2614         wx buildbot fix. Update libpng dl script to the latest version.
2615
2616         * wx/install-unix-extras:
2617
2618 2007-12-22  Antti Koivisto  <antti@apple.com>
2619
2620         Fix a typo.
2621
2622         * Scripts/webkitdirs.pm:
2623
2624 2007-12-21  Sam Weinig  <sam@webkit.org>
2625
2626         Reviewed by Mark Rowe.
2627
2628         - Disable the back/forward cache using the new WebPreferences API
2629           instead of through the BackForwardList.  This makes us match what
2630           we do on Windows.
2631
2632         * DumpRenderTree/mac/DumpRenderTree.mm:
2633         (createWebViewAndOffscreenWindow):
2634         (setDefaultsToConsistentValuesForTesting):
2635
2636 2007-12-21  Dan Bernstein  <mitz@apple.com>
2637
2638         Reviewed by Mark Rowe.
2639
2640         - disable the back/forward cache in Windows DumpRenderTree. It is
2641           already disabled in Mac DumpRenderTree.
2642
2643         * DumpRenderTree/win/DumpRenderTree.cpp:
2644         (initializePreferences):
2645
2646 2007-12-13  Antti Koivisto  <antti@apple.com>
2647
2648         Reviewed by Darin and Steve.
2649         
2650         - check for QuickTime SDK on Windows.
2651         - build media support on Windows by default
2652
2653         * Scripts/build-webkit:
2654         * Scripts/webkitdirs.pm:
2655
2656 2007-12-21  Kevin Ollivier  <kevino@theolliviers.com>
2657
2658         Build script fix for buildbot.
2659
2660         * wx/build-wxwebkit:
2661
2662 2007-12-20  Eric Seidel  <eric@webkit.org>
2663
2664         Reviewed by mjs.
2665
2666         * Scripts/run-sunspider: change --runs default to 10 for better accuracy
2667
2668 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
2669
2670         Reviewed by Steve.
2671
2672         - <rdar://5656485> Drosera: Win: Nightly does not reliably connect to
2673         WebKit.
2674
2675         - Drosera and Safari need to use the same ProgIDs in order for
2676         CoCreateInstance to work properly.  The most robust way to do this is
2677         for WebKit to dynamically publish those ProgIDs.
2678
2679         * Drosera/win/DebuggerClient.cpp: Use the published ProgIDs
2680         (DebuggerClient::createWebViewWithRequest):
2681         * Drosera/win/Drosera.cpp: Use the published ProgIDs and rename some
2682         statics.
2683         (Drosera::initUI):
2684         (Drosera::attach):
2685         (Drosera::attemptToCreateServerConnection):
2686         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Fix a runtime failure.
2687         * Drosera/win/ServerConnection.cpp: Reformat the connection function and
2688         make use of the published ProgIDs.
2689         (ServerConnection::attemptToCreateServerConnection):
2690
2691 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
2692
2693         - <rdar://problem/5658317> REGRESSION: 20+ leaks seen on buildbots.
2694         - Build bot and leak fix.
2695
2696         * DumpRenderTree/LayoutTestController.cpp:
2697         (pathToLocalResourceCallback):
2698
2699 2007-12-19  David Kilzer  <ddkilzer@apple.com>
2700
2701         Make svn-apply/svn-unapply work with patches from git-format-patch.
2702
2703         Reviewed by Darin.
2704
2705         * Scripts/svn-apply:
2706         (patch): If 'Index:' can't be found in the text passed in, print it
2707         out with a warning and return early.
2708         * Scripts/svn-unapply:
2709         (patch): Ditto.
2710
2711 2007-12-18  Kevin Ollivier  <kevino@theolliviers.com>
2712
2713         Reviewed by Alp Toker.
2714
2715         Build related fixes.
2716
2717         * wx/build-wxwebkit:
2718         - Check to make sure the user is running a supported wx port
2719         - More robust checks for Cygwin
2720         - Only run install-unix-extras on Mac, it's not the right solution
2721           for Linux distros.
2722         - Remove outdated Linux instructions after successful build
2723         - Clean Bakefile-generated files during a clean operation
2724
2725 2007-12-18  Darin Adler  <darin@apple.com>
2726
2727         * Scripts/make-js-test-wrappers: Don't generate a wrapper for select-options-remove.js.
2728
2729 2007-12-18  Steve Falkenburg  <sfalken@apple.com>
2730
2731         Add script to run Drosera as part of the nightly.
2732         
2733         Reviewed by Kevin M.
2734
2735         * Scripts/run-drosera.cmd: Added.
2736
2737 2007-12-18  Darin Adler  <darin@apple.com>
2738
2739         * Scripts/do-webcore-rename: Remove a stray K.
2740
2741 2007-12-18  Darin Adler  <darin@apple.com>
2742
2743         * Scripts/do-webcore-rename: Plan more renaming.
2744
2745 2007-12-14  Juan A. Suarez Romero  <jasuarez@igalia.com>
2746
2747         Reviewed by Alp Toker.
2748
2749         http://bugs.webkit.org/show_bug.cgi?id=16042
2750         [GTK] Eliminate webkit_init()
2751
2752         Moving webkit initialization to WebView class init.
2753
2754         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2755         (main):
2756         * GtkLauncher/main.c:
2757         (main):
2758
2759 2007-12-17  Luca Bruno  <lethalman88@gmail.com>
2760
2761         Reviewed by Alp Toker.
2762
2763         http://bugs.webkit.org/show_bug.cgi?id=13542
2764         gdklauncher doesnt change URL in adress GTKEntry.
2765
2766         * GtkLauncher/main.c:
2767         (load_commit_cb): added
2768         (title_change_cb):
2769         (create_browser):
2770
2771 2007-12-16  Dimitri Glazkov  <dimitri@glazkov.com>
2772
2773         Reviewed by Adam Roben.
2774
2775         Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.
2776
2777         * FindSafari/FindSafari.cpp:
2778         (_tmain):
2779
2780 2007-12-16  Brent Fulgham  <bfulgham@gmail.com>
2781
2782         Reviewed by Adam Roben.
2783
2784         http://bugs.webkit.org/show_bug.cgi?id=16315
2785         FindSafari needs a path-only option.
2786
2787         * FindSafari/FindSafari.cpp:
2788         (_tmain):
2789
2790 2007-12-16  Alexey Proskuryakov  <ap@webkit.org>
2791
2792         Reviewed by Darin.
2793
2794         http://bugs.webkit.org/show_bug.cgi?id=16462
2795         REGRESSION: access keys broken on Windows
2796
2797         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Send system key events
2798         if Alt is pressed.
2799
2800 2007-12-15  Sam Weinig  <sam@webkit.org>
2801
2802         Reviewed by Mark Rowe.
2803
2804         Fix urlSuitableForTestResult to correctly identify wstring::npos as
2805         the case when wstring.find doesn't find anything.
2806
2807         * DumpRenderTree/win/DumpRenderTree.cpp:
2808         (urlSuitableForTestResult):
2809
2810 2007-12-15  Alp Toker  <alp@atoker.com>
2811
2812         GTK+ DRT build fix for GLib < 2.14.
2813
2814         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2815         (LayoutTestController::setWaitToDump):
2816
2817 2007-12-05  Mark Rowe  <mrowe@apple.com>
2818
2819         Reviewed by Alp Toker.
2820
2821         Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.  This prevents
2822         many layout tests from hanging while waiting on user responses to dialogs.
2823
2824         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2825         (invalidateAnyPreviousWaitToDumpWatchdog):
2826         (webViewScriptAlert):
2827         (webViewScriptPrompt):
2828         (webViewScriptConfirm):
2829         (main):
2830         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
2831         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2832         (waitToDumpWatchdogFired):
2833         (LayoutTestController::setWaitToDump):
2834
2835 2007-12-05  Mark Rowe  <mrowe@apple.com>
2836
2837         Reviewed by Alp Toker.
2838
2839         Flesh out DumpRenderTree for Gtk.  After these changes, the majority of the tests in fast/js pass.
2840
2841         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2842         (dumpFramesAsText): Don't print the frame name when dumping the main frame as text.
2843         (dump):
2844         (runTest):
2845         (webViewLoadStarted): Store the top frame when it starts loading so we can use it to determine when to dump.
2846         (webViewLoadFinished): Dump when the top frame load completes if we're not waiting for a JS callback and the
2847         work queue is empty.
2848         (webViewWindowObjectCleared): Set up window.layoutTestController.
2849         (webViewConsoleMessage): Match the console message format expected by the layout test results.
2850         (main): Hook up the new signals.
2851         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
2852         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Only notify done if the top frame has completed loading to avoid
2853         dumping multiple times.
2854         * Scripts/build-dumprendertree: Ensure build-dumprendertree is a no-op for Gtk too.
2855         * Scripts/run-webkit-tests: Teach run-webkit-tests that Gtk is like Qt in many ways.  Use run-launcher to open test results.
2856
2857 2007-12-14  Anders Carlsson  <andersca@apple.com>
2858
2859         Reviewed by Brady.
2860
2861         Assert that a web frame that's loading a resource always has either a data source or 
2862         a provisional data source.
2863         
2864         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2865         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2866
2867 2007-12-14  Darin Adler  <darin@apple.com>
2868
2869         - fix mistake causing nearly all tests to fail on Windows
2870
2871         * DumpRenderTree/win/UIDelegate.cpp:
2872         (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with
2873         npos, not 0. Also pass URL in to URL function rather than passing the entire message.
2874
2875         * DumpRenderTree/mac/UIDelegate.mm:
2876         (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather
2877         than passing the entire message.
2878
2879 2007-12-14  Darin Adler  <darin@apple.com>
2880
2881         - fix Tiger build
2882
2883         * DumpRenderTree/mac/UIDelegate.mm:
2884         (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any
2885         new-to-Leopard methods.
2886
2887 2007-12-14  Darin Adler  <darin@apple.com>
2888
2889         * DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method
2890         since it now triggers unwanted icon loading. We only had it because we implemented "all"
2891         delegate methods here.
2892
2893 2007-12-14  Anders Carlsson  <andersca@apple.com>
2894
2895         Reviewed by Darin and Geoff.
2896
2897         <rdar://problem/5619295> 
2898         REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
2899         
2900         Add property getting methods to the plug-in.
2901         
2902         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2903         (pluginInvoke):
2904
2905 2007-12-14  Kevin McCullough  <kmccullough@apple.com>
2906
2907         Reviewed by Darin.
2908
2909         - Layout test fix for mac. When dumped to the console local file paths
2910         now only show the name of the resource not the whole path.  This is to
2911         make the results machine and OS independent.
2912
2913         * DumpRenderTree/mac/UIDelegate.mm:
2914         (-[UIDelegate webView:addMessageToConsole:]):
2915
2916 2007-12-13  Kevin McCullough  <kmccullough@apple.com>
2917
2918         Reviewed by Adam.
2919
2920         - Layout tests fix.  We need a way to remove machine-dependent
2921         information from paths in layout test results. The UIDelegate now does
2922         this.
2923
2924         * DumpRenderTree/DumpRenderTree.h:
2925         * DumpRenderTree/win/DumpRenderTree.cpp:
2926         (urlSuitableForTestResult):
2927         * DumpRenderTree/win/DumpRenderTreeWin.h:
2928         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2929         * DumpRenderTree/win/UIDelegate.cpp:
2930         (UIDelegate::webViewAddMessageToConsole):
2931
2932 2007-12-13  Alp Toker  <alp@atoker.com>
2933
2934         Build fix for DRT breakage introduced in r28690.
2935
2936         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2937         (LayoutTestController::pathToLocalResource):
2938
2939 2007-12-12  Kevin McCullough  <kmccullough@apple.com>
2940
2941         Reviewed by Alice and Sam.
2942
2943         - <rdar://5621435> Need a way to specify local resources (being loaded
2944         from HTTP tests) on Windows.
2945         - Implemented pathToLocalResource which exposes the functionality of
2946         converting a given unix path to the correct location on Windows.
2947
2948         * DumpRenderTree/LayoutTestController.cpp:
2949         (pathToLocalResourceCallback):
2950         (LayoutTestController::staticFunctions):
2951         * DumpRenderTree/LayoutTestController.h:
2952         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2953         (LayoutTestController::pathToLocalResource):
2954         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2955         (LayoutTestController::pathToLocalResource):
2956
2957 2007-12-12  Anders Carlsson  <andersca@apple.com>
2958
2959         Reviewed by Sam.
2960
2961         <rdar://problem/5132003>
2962         dumpResourceLoadCallbacks is not implemented in DRT on Windows.
2963
2964         * DumpRenderTree/win/DumpRenderTree.cpp:
2965         (main):
2966         Set the resource load delegate.
2967         
2968         * DumpRenderTree/win/DumpRenderTree.vcproj:
2969         
2970         * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
2971         * DumpRenderTree/win/ResourceLoadDelegate.h: Added.
2972
2973 2007-12-12  Alexey Proskuryakov  <ap@webkit.org>
2974
2975         Reviewed by Adam Roben.
2976
2977         Fix conversion from double to LPARAM in dispatchMessage().
2978
2979         * DumpRenderTree/win/EventSender.cpp:
2980         (dispatchMessageCallback):
2981
2982 2007-12-11  Dan Bernstein  <mitz@apple.com>
2983
2984         Reviewed by Mark Rowe and Sam Weinig too!
2985
2986         - added Helvetica Oblique and Helvetica Bold Oblique to the list of
2987           fonts DumpRenderTree registers.
2988
2989         * DumpRenderTree/win/DumpRenderTree.cpp:
2990         (initialize):
2991
2992 2007-12-11  Brady Eidson  <beidson@apple.com>
2993
2994         Reviewed by Anders
2995
2996         Make DumpRenderTree on mac use its own path for Databases testing
2997
2998         * DumpRenderTree/mac/DumpRenderTree.mm:
2999         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree 
3000           for future DRT-only use, then use it to construct the Databases path and set that default
3001
3002 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
3003
3004         Reviewed by Darin.
3005
3006         <rdar://problem/5535636>
3007         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
3008
3009         http://bugs.webkit.org/show_bug.cgi?id=13916
3010         JavaScript detects Tab as a character input on a textfield validation
3011
3012         * DumpRenderTree/mac/EventSendingController.mm:
3013         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
3014         Dispatch a keyup to better match what happens when a key is physically pressed.
3015
3016         * DumpRenderTree/win/EventSender.cpp:
3017         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
3018         returning from keyDown().
3019         (getConstantCallback): Fixed a couple copy/paste mistakes.
3020
3021 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
3022
3023         Reviewed by Oliver.
3024
3025         - <rdar://5599845> Drosera: Does not show loal files in the file list
3026         on the left side.
3027
3028         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
3029         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
3030         so the open source community can build.
3031
3032 2007-12-10  Brady Eidson  <beidson@apple.com>
3033
3034         Rubberstamped by Sam Weinig
3035
3036         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
3037
3038         * DumpRenderTree/mac/UIDelegate.mm:
3039         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
3040         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
3041
3042 2007-12-08  Oliver Hunt  <oliver@apple.com>
3043
3044         Reviewed by Sam W.
3045
3046         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
3047         
3048         Fixes <rdar://problem/5620249> Must disable SVG animation
3049         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
3050         
3051         In order to allow finer grained control over the set of SVG features
3052         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
3053         distinct flags:
3054         ENABLE_SVG_ANIMATION
3055         ENABLE_SVG_FILTERS
3056         ENABLE_SVG_FONTS
3057         ENABLE_SVG_AS_IMAGE
3058         ENABLE_SVG_USE
3059         
3060         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
3061         
3062         Script handles all the new build flags, and allows --svg-experimental
3063         to automatically enable all features.
3064
3065         * Scripts/build-webkit:
3066
3067 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
3068
3069         Fix version parsing.
3070
3071         Rubber-stamped by Oliver.
3072
3073         * Drosera/win/Drosera.vcproj/auto-version.sh:
3074
3075 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
3076
3077         Build modifications for Drosera.
3078
3079         Reviewed by Adam.
3080
3081         * Drosera/DroseraWin.make: Added.
3082         * Drosera/win/Drosera.vcproj/Drosera.rc:
3083         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
3084         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
3085         * Drosera/win/Drosera.vcproj/VERSION: Added.
3086         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
3087
3088 2007-12-06  Adam Roben  <aroben@apple.com>
3089
3090         Explicitly turn on the Mac font ascent hack on Windows
3091
3092         This keeps our font metrics matching those from Mac.
3093
3094         Reviewed by Hyatt.
3095
3096         * DumpRenderTree/win/DumpRenderTree.cpp:
3097         (main):
3098
3099 2007-12-06  Anders Carlsson  <andersca@apple.com>
3100
3101         Rename main.c to main.cpp here too.
3102         
3103         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
3104
3105 2007-12-06  Sam Weinig  <sam@webkit.org>
3106
3107         Rubber stamped by Geoff.
3108
3109         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
3110
3111 2007-12-06  Darin Adler  <darin@apple.com>
3112
3113         * Scripts/do-webcore-rename: Some more renaming plans.
3114
3115 2007-12-06  Anders Carlsson  <andersca@apple.com>
3116
3117         Restore implementation of testGetIntIdentifier that was accidentally
3118         removed somehow (possibly when I made PluginObject be a cpp file).
3119         
3120         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3121         (pluginInvoke):
3122
3123 2007-12-05  Anders Carlsson  <andersca@apple.com>
3124
3125         Make the entry points extern "C".
3126         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3127         
3128 2007-12-05  Anders Carlsson  <andersca@apple.com>
3129
3130         C++ warning fixes.
3131         
3132         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3133         (NPP_New):
3134         (NPP_Destroy):
3135         (NPP_SetWindow):
3136         (NPP_NewStream):
3137         (NPP_HandleEvent):
3138         (NPP_URLNotify):
3139         (NPP_GetValue):
3140
3141 2007-12-05  Anders Carlsson  <andersca@apple.com>
3142
3143         Add the .cpp files to the TestNetscapePlugIn target.
3144
3145         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3146
3147 2007-12-05  Anders Carlsson  <andersca@apple.com>
3148
3149         Reviewed by Geoff.
3150         
3151         Rename the TestNetscapePlugIn .c files to be .cpp.
3152
3153         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3154         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
3155         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
3156         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
3157         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
3158         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
3159         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
3160         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3161
3162 2007-12-05  Adam Roben  <aroben@apple.com>
3163
3164         Fix case of keypresses from the Windows implementation of eventSender.keyDown
3165
3166         This fixes several regression tests.
3167
3168         Reviewed by Alice.
3169
3170         * DumpRenderTree/win/EventSender.cpp:
3171         (keyDownCallback): Virtual keycodes for ASCII characters are always
3172         uppercase, so we need to check the case of the original character
3173         passed in to eventSender.keyDown.
3174
3175 2007-12-05  Adam Roben  <aroben@apple.com>
3176
3177         Learn from Tim's mistakes
3178
3179         * DumpRenderTree/win/DumpRenderTree.cpp:
3180         (runTest): Reset the authorAndUserStylesEnabled preference for each
3181         test.
3182
3183 2007-12-05  Alp Toker  <alp@atoker.com>
3184
3185         Reviewed by Mark Rowe.
3186
3187         Initialize GTK+ and WebKit so the tests can run.
3188
3189         Reorganize the headers a little.
3190
3191         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3192         (main):
3193
3194 2007-12-04  Anders Carlsson  <andersca@apple.com>
3195
3196         Remove IWebScriptScope include.
3197         
3198         * Drosera/win/DebuggerDocumentPlatform.cpp:
3199
3200 2007-12-04  Sam Weinig  <sam@webkit.org>
3201
3202         Rubber stamped by Mark Rowe.
3203
3204         Define CF as platform for mac and revert r28409
3205
3206         * DumpRenderTree/DumpRenderTree.h:
3207         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3208
3209 2007-12-04  Sam Weinig  <sam@webkit.org>
3210
3211         Define CF as platform for windows.
3212
3213         Reviewed by Adam Roben.
3214
3215         * DumpRenderTree/win/DumpRenderTreeWin.h:
3216
3217 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
3218
3219         Reviewed by Adam and Darin.
3220
3221         - Removed a needless BSTR cleanup.
3222
3223         * Drosera/win/DebuggerDocumentPlatform.cpp:
3224         (DebuggerDocument::getPlatformCurrentFunctionStack):
3225
3226 2007-11-27  Adam Roben  <aroben@apple.com>
3227
3228         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
3229
3230         Reviewed by Maciej.
3231
3232         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3233         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
3234
3235 2007-12-04  Alp Toker  <alp@atoker.com>
3236
3237         Prospective Win DRT build fix.
3238
3239         * DumpRenderTree/DumpRenderTree.h:
3240
3241 2007-12-04  Alp Toker  <alp@atoker.com>
3242
3243         Fix a clobbered copyright header.
3244
3245         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3246
3247 2007-12-04  Xan Lopez  <xan@gnome.org>
3248
3249         Reviewed by Alp Toker.
3250
3251         http://bugs.webkit.org/show_bug.cgi?id=15561
3252         GTK port needs DumpRenderTree implementation
3253
3254         Start work on the GTK+ DRT.
3255
3256         This does not work yet, and there are a few lingering style issues
3257         (nothing major) but this patch has been stuck in the bug tracker for
3258         too long already.
3259
3260         * DumpRenderTree/DumpRenderTree.h:
3261         * DumpRenderTree/gtk: Added.
3262         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
3263         (autocorrectURL):
3264         (shouldLogFrameLoadDelegates):
3265         (dumpFrameScrollPosition):
3266         (displayWebView):
3267         (appendString):
3268         (dumpFramesAsText):
3269         (dumpRenderTreeAsText):
3270         (dump):
3271         (runTest):
3272         (main):
3273         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
3274         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
3275         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
3276         (GCController::collect):
3277         (GCController::collectOnAlternateThread):
3278         (GCController::getJSObjectCount):
3279         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
3280         (LayoutTestController::~LayoutTestController):
3281         (LayoutTestController::addDisallowedURL):
3282         (LayoutTestController::clearBackForwardList):
3283         (LayoutTestController::copyDecodedHostName):
3284         (LayoutTestController::copyEncodedHostName):
3285         (LayoutTestController::display):
3286         (LayoutTestController::keepWebHistory):
3287         (LayoutTestController::notifyDone):
3288         (LayoutTestController::queueBackNavigation):
3289         (LayoutTestController::queueForwardNavigation):
3290         (LayoutTestController::queueLoad):
3291         (LayoutTestController::queueReload):
3292         (LayoutTestController::queueScript):
3293         (LayoutTestController::setAcceptsEditing):
3294         (LayoutTestController::setCustomPolicyDelegate):
3295         (LayoutTestController::setMainFrameIsFirstResponder):
3296         (LayoutTestController::setTabKeyCyclesThroughElements):
3297         (LayoutTestController::setUseDashboardCompatibilityMode):
3298         (LayoutTestController::setUserStyleSheetEnabled):
3299         (LayoutTestController::setUserStyleSheetLocation):
3300         (LayoutTestController::setWindowIsKey):
3301         (LayoutTestController::setWaitToDump):
3302         (LayoutTestController::windowCount):
3303         (LayoutTestController::setPrivateBrowsingEnabled):
3304         (LayoutTestController::setAuthorAndUserStylesEnabled):
3305         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
3306         (JSStringCopyUTF8CString):
3307         (LoadItem::invoke):
3308         (ReloadItem::invoke):
3309         (ScriptItem::invoke):
3310         (BackForwardItem::invoke):
3311
3312 2007-12-03  Sam Weinig  <sam@webkit.org>
3313
3314         Move JavaScriptCore thread testing code to pthread specific directory
3315         and remove the dependance on CoreFoundation by using WTF::HashSet.
3316
3317         Reviewed by Geoff and Oliver.
3318
3319         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3320         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
3321         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
3322         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
3323         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
3324         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
3325         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
3326         * DumpRenderTree/pthreads: Added.
3327         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
3328         (javaScriptThreads):
3329         (runJavaScriptThread):
3330         (startJavaScriptThreads):
3331         (stopJavaScriptThreads):
3332
3333 2007-12-03  Andrew Bonventre  <andybons@google.com>
3334
3335         Reviewed by Darin Adler.
3336
3337         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
3338         Symbol lookup menu broken in debugger view
3339
3340         * Drosera/debugger.js: Fixed javascript error where document property
3341         should have been used instead of contentDocument in switchFunction that
3342         was breaking the select symbol dropdown menu.  This is because
3343         window.frames will return a Window object and not a frame object like
3344         the author was originally expecting.
3345
3346 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
3347
3348         Reviewed by Adam.
3349
3350         - <rdar://5618942> Drosera: Console window does not process everything
3351         correctly.
3352         - <rdar://5619005> Drosera: could be sped up by moving the 
3353         WebScriptScope stuff into the WebScriptCallFrame.
3354         - Now the console can correctly process objects and does not receive
3355         notifications from JavaScriptCore about the JavaScript in Drosera's
3356         own process.
3357
3358         * Drosera/win/DebuggerDocumentPlatform.cpp:
3359         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3360         (DebuggerDocument::platformValueForScopeVariableNamed):
3361
3362 2007-12-03  Stephanie  <slewis@apple.com>
3363
3364         Reviewed by Darin.
3365
3366         Check to see if we are building a debug root
3367
3368         * Scripts/check-for-global-initializers: 
3369
3370 2007-12-03  Dan Bernstein  <mitz@apple.com>
3371
3372         Reviewed by Darin Adler.
3373
3374         - added a testGetIntIdentifier() method to TestNetscapePlugIn
3375
3376         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
3377         (pluginInvoke):
3378
3379 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
3380
3381         Reviewed by Oliver.
3382
3383         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
3384         in a more fine-grained manner than eventSender.keyDown().
3385
3386         * DumpRenderTree/win/EventSender.cpp:
3387         (getConstantCallback):
3388         (dispatchMessageCallback):
3389
3390 2007-12-02  Darin Adler  <darin@apple.com>
3391
3392         * Scripts/do-webcore-rename: More planned renaming.
3393
3394 2007-12-02  Sam Weinig  <sam@webkit.org>
3395
3396         Rubber stamped by Anders.
3397
3398         Use [NSURL absoluteString] instead of [NSURL description] in order to get
3399         more uniform results cross platform.
3400
3401         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3402         (-[NSURL _drt_descriptionSuitableForTestResult]):
3403
3404 2007-12-02  Sam Weinig  <sam@webkit.org>
3405
3406         Rubber stamped by Niko.
3407
3408         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
3409
3410         * DumpRenderTree/win/DumpRenderTree.cpp:
3411         * DumpRenderTree/win/DumpRenderTree.vcproj:
3412         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
3413         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
3414         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
3415         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
3416
3417 2007-12-01  Alp Toker  <alp@atoker.com>
3418
3419         Reviewed by Adam Roben.
3420
3421         Make use of the newly introduced webkit.h convenience header.
3422
3423         * GtkLauncher/main.c:
3424
3425 2007-12-01  Adam Treat  <treat@kde.org>
3426
3427         Reviewed by Simon.
3428
3429         * Check to see if the directory exists and exit if not.
3430
3431         * DumpRenderTree/qt/main.cpp:
3432         (main):
3433
3434 2007-12-01  Adam Treat  <treat@kde.org>
3435
3436         Reviewed by Simon.
3437
3438         * Don't hide symbols when in Debug mode
3439         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
3440
3441
3442         * DumpRenderTree/qt/main.cpp:
3443         (messageHandler):
3444
3445 2007-11-30  Alp Toker  <alp@atoker.com>
3446
3447         Reviewed by Adam Roben.
3448
3449         http://bugs.webkit.org/show_bug.cgi?id=15691
3450         [GTK] Public API does not follow GTK+ conventions
3451
3452         Refactor the WebKit/GTK+ public API. Changes:
3453           WebKitPage -> WebKitWebView
3454           WebKitFrame -> WebKitWebFrame
3455
3456         Public API source and header names have been updated to mirror the API
3457         changes.
3458
3459         The API is now kept in WebKit/gtk/WebView to match other ports in the
3460         same class such as Mac and Win.
3461
3462         * GtkLauncher/main.c:
3463         (activate_uri_entry_cb):
3464         (link_hover_cb):
3465         (title_change_cb):
3466         (progress_change_cb):
3467         (go_back_cb):
3468         (go_forward_cb):
3469         (create_browser):
3470         (main):
3471
3472 2007-11-30  Adam Roben  <aroben@apple.com>
3473
3474         Hopefully the final build fix
3475
3476         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
3477         pull in WTF's assertion/logging functions.
3478
3479 2007-11-30  Adam Roben  <aroben@apple.com>
3480
3481         Another build fix
3482
3483         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
3484         WebKit.lib.
3485
3486 2007-11-30  Adam Roben  <aroben@apple.com>
3487
3488         Debug build fix
3489
3490         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
3491         configuration.
3492         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
3493         projects.
3494         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
3495         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
3496         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
3497
3498 2007-11-30  Sam Weinig  <sam@webkit.org>
3499
3500         Reviewed by Adam Roben.
3501
3502         Fix drawSelectionRect to actually draw the selection rect.
3503
3504         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3505         (drawSelectionRect):
3506
3507 2007-11-30  Darin Adler  <darin@apple.com>
3508
3509         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
3510
3511 2007-11-30  Darin Adler  <darin@apple.com>
3512
3513         * Scripts/do-webcore-rename: Get ready for some future renaming.
3514
3515 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
3516
3517         Reviewed by Adam.
3518
3519         - Removed some unnecessary functions and changed an unused return type. 
3520
3521         * Drosera/win/DebuggerClient.cpp:
3522         (registerConsoleClass):
3523         * Drosera/win/DebuggerClient.h:
3524         * Drosera/win/Drosera.cpp:
3525         (registerDroseraClass):
3526
3527 2007-11-28  Alp Toker  <alp@atoker.com>
3528
3529         Reviewed by Timothy Hatcher.
3530
3531         http://bugs.webkit.org/show_bug.cgi?id=16174
3532         [GTK] Use "URI" not "URL" in public API
3533
3534         Replace use of the term "URL" with "URI" in public headers,
3535         documentation and some internal code to match GLib/GTK+ convention.
3536
3537         This is now mentioned in the API guidelines:
3538           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
3539
3540         * GtkLauncher/main.c:
3541         (activate_uri_entry_cb):
3542         (title_change_cb):
3543         (create_toolbar):
3544         (main):
3545
3546 2007-11-29  Anders Carlsson  <andersca@apple.com>
3547
3548         Reviewed by Sam.
3549
3550         <rdar://problem/5230478>
3551         FrameLoadDelegate callbacks are not dumped in DRT.
3552         
3553         * DumpRenderTree/win/DumpRenderTree.cpp:
3554         (shouldLogFrameLoadDelegates):
3555         (runTest):
3556         (main):
3557         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
3558         (BSTRtoString):
3559         (descriptionSuitableForTestResult):
3560         (FrameLoadDelegate::QueryInterface):
3561         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
3562         (FrameLoadDelegate::didFailProvisionalLoadWithError):
3563         (FrameLoadDelegate::didCommitLoadForFrame):
3564         (FrameLoadDelegate::didFinishLoadForFrame):
3565         (FrameLoadDelegate::willCloseFrame):
3566         (FrameLoadDelegate::didClearWindowObject):
3567         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
3568         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
3569         * DumpRenderTree/win/FrameLoaderDelegate.h:
3570         (FrameLoadDelegate::windowScriptObjectAvailable):
3571         (FrameLoadDelegate::didFirstLayoutInFrame):
3572
3573 2007-11-29  Sam Weinig  <sam@webkit.org>
3574
3575         Reviewed by Anders.
3576
3577         Add database quota UIDelegates methods to DRT UIDelegate.
3578
3579         * DumpRenderTree/mac/UIDelegate.mm:
3580         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
3581         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
3582
3583 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
3584
3585         Reviewed by Sam.
3586
3587         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
3588         dying and vice versa.
3589         - This fix will allow Drosera and Safari to reconnect if either of them
3590         closes correctly, but does not fix the case where one of them dies
3591         silently.
3592
3593         * Drosera/win/ServerConnection.cpp:
3594         (ServerConnection::attemptToCreateServerConnection): Added a safety
3595         check, because it's possilbe to try to connect to a server that's dying.
3596         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
3597         the server has died.
3598         * Drosera/win/ServerConnection.h: Added the new function and removed
3599         an unnecessary member.
3600
3601 2007-11-29  Anders Carlsson  <andersca@apple.com>
3602
3603         * DumpRenderTree/win/DumpRenderTree.vcproj:
3604         Add shlwapi.lib to all configurations.
3605
3606 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
3607
3608         - Build fix.  Added additional includes for VS Express to the Release
3609         project.
3610
3611         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
3612
3613 2007-11-29  Anders Carlsson  <andersca@apple.com>
3614
3615         Reviewed by Adam.
3616
3617         <rdar://problem/5132005>
3618         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
3619         
3620         * DumpRenderTree/win/DumpRenderTree.vcproj:
3621         Add shlwapi.lib
3622         
3623         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3624         (LayoutTestController::setUserStyleSheetEnabled):
3625         Implement this.
3626         
3627         (appendComponentToPath):
3628         New method which wraps the Win32 API PathAppend.
3629         
3630         (followShortcuts):
3631         New method which checks if a file points to a shortcut and
3632         follows the shortcut.
3633         
3634         (resolveCygwinPath):
3635         New method that takes a cygwin unix-style path and returns the Win32 path.
3636         
3637         (cfStringRefToWString):
3638         
3639         (LayoutTestController::setUserStyleSheetLocation):
3640         Implement this.
3641
3642 2007-11-29  Alice Liu  <alice.liu@apple.com>
3643
3644         Reviewed by Adam.
3645
3646         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
3647
3648         * DumpRenderTree/win/EventSender.cpp:
3649         (keyDownCallback):
3650         uppercase letters were being sent as lowercase letters without the shift key down.
3651
3652 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
3653
3654         - Windows build fix. VS express needs some love.
3655
3656         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
3657
3658 2007-11-28  Darin Adler  <darin@apple.com>
3659
3660         Reviewed by Adam Roben.
3661
3662         * DumpRenderTree/mac/EventSendingController.mm:
3663         (-[EventSendingController keyDown:withModifiers:]):
3664         Send capital letters through as lowercase letters with the shift key down
3665         rather than sending them as if they were highly unusual "capital letter keys".
3666
3667         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
3668         where you need to update results and more tests are failing than before.
3669
3670 2007-11-28  Anders Carlsson  <andersca@apple.com>
3671
3672         Reviewed by Darin.
3673
3674         <rdar://problem/5132001>
3675         contextClick is not implemented in DRT on Windows.
3676         
3677         * DumpRenderTree/win/EventSender.cpp:
3678         (contextClickCallback):
3679         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
3680         by a WM_RBUTTONUP message.
3681         
3682         * DumpRenderTree/win/UIDelegate.cpp:
3683         (UIDelegate::hasCustomMenuImplementation):
3684         (UIDelegate::trackCustomPopupMenu):
3685         * DumpRenderTree/win/UIDelegate.h:
3686         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
3687         menu from being shown (and causing the DRT to hang).
3688
3689 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
3690
3691         Reviewed by Darin.
3692
3693         Fix DumpRenderTree ObjC bug comparing strings.
3694
3695         * DumpRenderTree/mac/ObjCController.m:
3696         (-[ObjCController identityIsEqual::]): Compare strings with string
3697         equality instead of identiy equality.
3698
3699 2007-11-27  Timothy Hatcher  <timothy@apple.com>
3700
3701         Reviewed by Sam.
3702
3703         Reset the authorAndUserStylesEnabled preference
3704         back to YES for each test. Fixes the broken tests.
3705
3706         * DumpRenderTree/mac/DumpRenderTree.mm:
3707         (resetWebViewToConsistentStateBeforeTesting):
3708
3709 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
3710
3711         Reviewed by Adam.
3712
3713         - Drosera now displays the console window, although it cannot currently
3714         process JavaScript.
3715
3716         * Drosera/win/DebuggerClient.cpp: Shows the console window.
3717         (registerConsoleClass): Implemented.
3718         (consoleWndProc): Implemented.
3719         (DebuggerClient::onSize): Implemented.
3720         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
3721         new window.
3722         * Drosera/win/DebuggerClient.h: Added needed method and members for 
3723         creating and maintaining a new window.
3724         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
3725         lines of code to more appropriate places.
3726         (Drosera::handleCommand):
3727         (Drosera::initUI):
3728         (Drosera::onSize):
3729         (Drosera::attach):
3730
3731 2007-11-27  Timothy Hatcher  <timothy@apple.com>
3732
3733         Reviewed by Dave Hyatt.
3734
3735         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
3736         
3737         Add support for disabling author and user styles for testing.
3738
3739         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3740         * DumpRenderTree/LayoutTestController.cpp:
3741         (setAuthorAndUserStylesEnabledCallback):
3742         (LayoutTestController::staticFunctions):
3743         * DumpRenderTree/LayoutTestController.h:
3744         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3745         (LayoutTestController::setAuthorAndUserStylesEnabled):
3746         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3747         (LayoutTestController::setAuthorAndUserStylesEnabled):
3748
3749 2007-11-26  Dan Bernstein  <mitz@apple.com>
3750
3751         - Tiger build fix.
3752
3753         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3754
3755 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
3756
3757         Reviewed by Maciej.
3758
3759         - Implemented displaying variables for Drosera on Win.
3760
3761         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
3762         that retrieve variables to not hold onto the return value since it's
3763         not returned.  Also changed to use the new signatures of the retrieval
3764         functions.
3765         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3766         (DebuggerDocument::platformValueForScopeVariableNamed):
3767         * Drosera/win/Drosera.cpp: Removed a needless TODO.
3768         (droseraWndProc):
3769
3770 2007-11-26  Sam Weinig  <sam@webkit.org>
3771
3772         Cleanup names of painting and repainting functions.
3773
3774         Reviewed by Adam Roben.
3775
3776         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3777         (drawSelectionRect): was drawSelectionRectIntoContext.
3778         (dumpWebViewAsPixelsAndCompareWithExpected):
3779         * DumpRenderTree/cg/PixelDumpSupportCG.h:
3780         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3781         (paintWebView): was drawWebViewIntoContext.
3782         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
3783
3784 2007-11-26  Sam Weinig  <sam@webkit.org>
3785
3786         Reviewed by Dan Bernstein.
3787
3788         - Leopard build fix
3789
3790         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3791
3792 2007-11-26  Sam Weinig  <sam@webkit.org>
3793
3794         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
3795         Use shared PixelDumpSupport for Mac DRT
3796
3797         Reviewed by Adam Roben.
3798
3799         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3800         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
3801         * DumpRenderTree/cg/ImageDiffCG.cpp:
3802         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3803         (drawSelectionRectIntoContext):
3804         (dumpWebViewAsPixelsAndCompareWithExpected):
3805         * DumpRenderTree/cg/PixelDumpSupportCG.h:
3806         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3807         * DumpRenderTree/mac/DumpRenderTree.mm:
3808         (dump):
3809         * DumpRenderTree/mac/ImageDiff.m: Removed.
3810         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
3811         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
3812         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
3813         (setDefaultColorProfileToRGB):
3814         (getBitmapContextFromWebView):
3815         (drawWebViewIntoContext):
3816         (repaintWithVerticalSweep):
3817         (repaintWithHorizontalSweep):
3818         (getSelectionRect):
3819         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
3820
3821 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
3822
3823         Bug 16052: prepare-ChangeLog doesn't report deleted files
3824         <http://bugs.webkit.org/show_bug.cgi?id=16052>
3825
3826         Reviewed by Sam.
3827
3828         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
3829
3830 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
3831
3832         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
3833         <http://bugs.webkit.org/show_bug.cgi?id=15864>
3834
3835         Reviewed by Adam.
3836
3837         Roll functionality of merge-changelog into resolve-ChangeLogs
3838         script.  The script now checks for ChangeLog.rej and
3839         ChangeLog.orig files first.  If it finds them, it uses the
3840         ChangeLog.rej file as a patch (in old contextual diff format) to
3841         apply with --fuzz=3.
3842
3843         * Scripts/merge-changelog: Removed.
3844         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
3845
3846 2007-11-25  Sam Weinig  <sam@webkit.org>
3847
3848         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
3849
3850         Reviewed by Mark Rowe.
3851
3852         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3853         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3854         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
3855         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
3856         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
3857
3858 2007-11-25  Sam Weinig  <sam@webkit.org>
3859
3860         Convert DumpRenderTree to ues .xcconfig files.
3861
3862         Reviewed by Mark Rowe.
3863
3864         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3865         * DumpRenderTree/mac/Configurations: Added.
3866         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
3867         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
3868         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
3869
3870 2007-11-25  Sam Weinig  <sam@webkit.org>
3871
3872         Add ForwardingHeaders to wtf for DumpRenderTree.
3873
3874         Reviewed by Mark Rowe.
3875
3876         * DumpRenderTree/DumpRenderTree.h:
3877         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3878         * DumpRenderTree/ForwardingHeaders: Added.
3879         * DumpRenderTree/ForwardingHeaders/wtf: Added.
3880         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
3881         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
3882         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
3883         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
3884         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
3885         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
3886         * DumpRenderTree/LayoutTestController.cpp:
3887         * DumpRenderTree/WorkQueue.cpp:
3888         * DumpRenderTree/mac/DumpRenderTree.mm:
3889         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3890         * DumpRenderTree/mac/JavaScriptThreading.cpp:
3891         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3892         * DumpRenderTree/mac/ObjCController.m:
3893         * DumpRenderTree/mac/UIDelegate.mm:
3894         * DumpRenderTree/mac/WorkQueueItemMac.mm:
3895
3896 2007-11-25  Adam Roben  <aroben@apple.com>
3897
3898         Fix some test failures caused by r28019
3899
3900         Now that stdout is in binary mode, we need to always use printf
3901         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
3902         the output.
3903
3904         Reviewed by Sam.
3905
3906         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
3907         printf.
3908         (UIDelegate::runJavaScriptAlertPanelWithMessage):
3909         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
3910         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
3911         (UIDelegate::webViewAddMessageToConsole):
3912
3913 2007-11-25  Adam Roben  <aroben@apple.com>
3914
3915         Set the font smoothing preference in DRT
3916
3917         This makes the pixel results on Windows closer to the Mac results.
3918
3919         Reviewed by Mitz.
3920
3921         * DumpRenderTree/win/DumpRenderTree.cpp:
3922         (initializePreferences):
3923
3924 2007-11-25  Adam Roben  <aroben@apple.com>
3925
3926         Port ImageDiff to CG and C++
3927
3928         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
3929         <rdar://5071708>
3930
3931         Reviewed by Sam.
3932
3933         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
3934         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
3935         (main):
3936         (createImageFromStdin):
3937         (compareImages):
3938         (getDifferenceBitmap):
3939         (computePercentageDifferent):
3940         * DumpRenderTree/win/ImageDiff.vcproj: Added.
3941
3942 2007-11-25  Adam Roben  <aroben@apple.com>
3943
3944         Fix image diff link generation on Windows
3945
3946         Reviewed by Sam.
3947
3948         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
3949         to toURL.
3950
3951 2007-11-25  Adam Roben  <aroben@apple.com>
3952
3953         Implement pixel dumping in Windows DRT
3954
3955         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
3956         <rdar://5071708>
3957
3958         Reviewed by Sam.
3959
3960         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
3961         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
3962         Content-Length header.
3963         (getMD5HashStringForBitmap):
3964         (dumpWebViewAsPixelsAndCompareWithExpected):
3965         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
3966         * DumpRenderTree/win/DumpRenderTree.cpp:
3967         (dump): Do a pixel dump if requested.
3968         (main): Parse pixel test options.
3969         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
3970         the cg/ subdirectory to the include path.
3971         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
3972         available in a header or import library, so we have to go through this
3973         LoadLibrary/GetProcAddress dance to use them.
3974         (cryptDLL):
3975         (init):
3976         (update):
3977         (final):
3978         (MD5_Init):
3979         (MD5_Update):
3980         (MD5_Final):
3981         * DumpRenderTree/win/MD5.h: Added.
3982         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
3983         moved up to the top level to share it with Mac eventually.
3984         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
3985         (getBitmapContextFromWebView): Forces the WebView to paint using a
3986         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
3987
3988 2007-11-25  Adam Roben  <aroben@apple.com>
3989
3990         Clean up Windows DRT's option parsing a little bit
3991
3992         Reviewed by Sam.
3993
3994         * DumpRenderTree/win/DumpRenderTree.cpp:
3995         (main): Put non-option arguments into a Vector.
3996
3997 2007-11-25  Adam Roben  <aroben@apple.com>
3998
3999         Make Windows DRT stop changing LF into CRLF
4000
4001         Reviewed by Sam.
4002
4003         * DumpRenderTree/win/DumpRenderTree.cpp:
4004         (main): Put stdout in binary mode.
4005         * Scripts/run-webkit-tests: Remove the CRLF hack.
4006
4007 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
4008
4009         Removed empty directory.
4010
4011         * Scripts/resources: Removed.
4012
4013 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
4014
4015         Fix bisect-builds to work with recent WebKit nightly builds.
4016
4017         Reviewed by Dan.
4018
4019         * Scripts/bisect-builds: Check for the 
4020         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
4021         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
4022         to WebKit.app/Contents/Resources.
4023
4024 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
4025
4026         Reviewed by Maciej.
4027
4028         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
4029         not closed (affects digg.com)
4030
4031         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
4032         one after finishing with a test to avoid having its delayed onload handler firing when
4033         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
4034         but it helps somewhat.
4035
4036 2007-11-22  Mark Rowe  <mrowe@apple.com>
4037
4038         Reviewed by Alp Toker.
4039
4040         Fix build-webkit to propagate make's exit status if it fails.
4041
4042         * Scripts/webkitdirs.pm:
4043
4044 2007-11-22  Dan Bernstein  <mitz@apple.com>
4045
4046         Reviewed by Mark Rowe.
4047
4048         - fix crash when running pixel tests
4049
4050         * DumpRenderTree/mac/DumpRenderTree.mm:
4051         (dumpRenderTree): Parse the command line options before setting up the
4052         environment so that we know if we need to set up the pixel dump
4053         machinery.
4054
4055 2007-11-21  Eric Seidel  <eric@webkit.org>
4056
4057         Speculative build fix for Tiger.
4058
4059         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
4060
4061 2007-11-21  Eric Seidel  <eric@webkit.org>
4062
4063         Reviewed by Tim Hatcher.
4064
4065         Break out more of DumpRenderTree.mm into individual files
4066
4067         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4068         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
4069         (checkedMalloc):
4070         (checkedRealloc):
4071         (makeLargeMallocFailSilently):
4072         * DumpRenderTree/mac/CheckedMalloc.h: Added.
4073         * DumpRenderTree/mac/DumpRenderTree.mm:
4074         (crashHandler):
4075         (dump):
4076         * DumpRenderTree/mac/DumpRenderTreeMac.h:
4077         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
4078         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
4079         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
4080         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
4081         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
4082         (javaScriptThreads):
4083         (runJavaScriptThread):
4084         (startJavaScriptThreads):
4085         (stopJavaScriptThreads):
4086         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
4087         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
4088         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
4089         (restoreColorSpace):
4090         (setDefaultColorProfileToRGB):
4091         (initializeColorSpaceAndScreeBufferForPixelTests):
4092         (md5HashStringForBitmap):
4093         (dumpWebViewAsPixelsAndCompareWithExpected):
4094
4095 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
4096
4097         Move install-unix-extras to wx directory as it seems only to be used by that 
4098         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
4099         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
4100         have install-unix-extras install into WebKitLibraries as per
4101         convention.
4102         
4103         Reviewed by Mark Rowe.
4104
4105         * Scripts/install-unix-extras: Removed.
4106         * wx/build-wxwebkit:
4107         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
4108
4109 2007-11-21  Eric Seidel  <eric@webkit.org>
4110
4111         Reviewed by Adam.
4112
4113         More refactoring for greater code readability
4114
4115         * DumpRenderTree/mac/DumpRenderTree.mm:
4116         (initializeGlobalsFromCommandLineOptions):
4117         (initializeColorSpaceAndScreeBufferForPixelTests):
4118         (addTestPluginsToPluginSearchPath):
4119         (useLongRunningServerMode):
4120         (runTestingServerLoop):
4121         (prepareConsistentTestingEnvironment):
4122         (dumpRenderTree):
4123         (main):
4124         (dumpFramesAsText):
4125         (dumpBackForwardListForWebView):
4126         (sizeWebViewForCurrentTest):
4127         (methodNameStringForFailedTest):
4128         (dumpBackForwardListForAllWindows):
4129         (dumpWebViewAsPixelsAndCompareWithExpected):
4130         (invalidateAnyPreviousWaitToDumpWatchdog):
4131         (dump):
4132         * DumpRenderTree/mac/DumpRenderTreeMac.h:
4133         * DumpRenderTree/mac/UIDelegate.mm:
4134         (-[UIDelegate webView:createWebViewWithRequest:]):
4135
4136 2007-11-21  Eric Seidel  <eric@webkit.org>
4137
4138         Reviewed by Tim Hatcher.
4139
4140         Abstract more of DRT into static methods
4141
4142         * DumpRenderTree/mac/DumpRenderTree.mm:
4143         (setDefaultsToConsistentValuesForTesting):
4144         (setupSignalHandlers):
4145         (allocateGlobalControllers):
4146         (releaseAndZero):
4147         (releaseGlobalControllers):
4148         (dumpRenderTree):
4149         (shouldLogFrameLoadDelegates):
4150         (createCFURLFromPathOrURL):
4151         (resetWebViewToConsistentStateBeforeTesting):
4152         (runTest):
4153
4154 2007-11-21  Eric Seidel  <eric@webkit.org>
4155
4156         Reviewed by Tim Hatcher.
4157
4158         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
4159
4160         * DumpRenderTree/DumpRenderTree.h:
4161         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4162         * DumpRenderTree/mac/DumpRenderTree.mm:
4163         (dumpRenderTree):
4164         (dump):
4165         (runTest):
4166         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
4167         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
4168         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
4169         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
4170         (-[DumpRenderTreePasteboard declareType:owner:]):
4171         (+[LocalPasteboard alloc]):
4172         (-[LocalPasteboard init]):
4173         (-[LocalPasteboard dealloc]):
4174         (-[LocalPasteboard name]):
4175         (-[LocalPasteboard releaseGlobally]):
4176         (-[LocalPasteboard declareTypes:owner:]):
4177         (-[LocalPasteboard addTypes:owner:]):
4178         (-[LocalPasteboard changeCount]):
4179         (-[LocalPasteboard types]):
4180         (-[LocalPasteboard availableTypeFromArray:]):
4181         (-[LocalPasteboard setData:forType:]):
4182         (-[LocalPasteboard dataForType:]):
4183         (-[LocalPasteboard setPropertyList:forType:]):
4184         (-[LocalPasteboard setString:forType:]):
4185         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
4186         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
4187         (+[DumpRenderTreeWindow allWindows]):
4188         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
4189         (-[DumpRenderTreeWindow dealloc]):
4190         (-[DumpRenderTreeWindow isKeyWindow]):
4191         (-[DumpRenderTreeWindow keyDown:]):
4192
4193 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
4194
4195         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
4196         it indiscriminately copies any headers inside JavaScriptCore,
4197         which includes Tiger ICU headers. 
4198
4199         * wx/build-wxwebkit:
4200         Don't run WebCore/move-js-headers.sh any longer.
4201
4202 2007-11-20  Adam Treat  <treat@kde.org>
4203
4204         Reviewed by David Kilzer.
4205
4206         * Prepend git branch name to $baseProductDir
4207
4208         * Scripts/VCSUtils.pm:
4209         * Scripts/webkitdirs.pm:
4210
4211 2007-11-20  Mark Rowe  <mrowe@apple.com>
4212
4213         Reviewed by Simon Hausmann.
4214
4215         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
4216         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
4217         Have it trigger a "make distclean" rather than "make clean" to ensure that the
4218         built product and generated Makefile's are removed.
4219
4220 2007-11-19  Alp Toker  <alp@atoker.com>
4221
4222         Reviewed by Mark Rowe.
4223
4224         http://bugs.webkit.org/show_bug.cgi?id=16040
4225         [GTK] GtkLauncher should be written in C
4226
4227         Port GtkLauncher to plain C.
4228
4229         Use a more conventional GTK+ coding style.
4230
4231         Use a toolbar instead of menus.
4232
4233         Various signature fixes and cleanups.
4234
4235         Add a license header. Assume all previous modifications were copyright
4236         assigned to Apple Inc. by default.
4237
4238         * GtkLauncher/GtkLauncher.pro:
4239         * GtkLauncher/main.c: Added.
4240         (activate_url_entry_cb):
4241         (update_title):
4242         (link_hover_cb):
4243         (title_change_cb):
4244         (progress_change_cb):
4245         (destroy_cb):
4246         (go_back_cb):
4247         (go_forward_cb):
4248         (create_browser):
4249         (create_statusbar):
4250         (create_toolbar):
4251         (create_window):
4252         (main):
4253         * GtkLauncher/main.cpp: Removed.
4254
4255 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
4256
4257         Build script fixes to ensure they do the right thing for the 
4258         wx port, and update build-wxwebkit to reflect the way the
4259         build scripts now work.
4260
4261         Reviewed by Adam.
4262
4263         * Scripts/build-testkjs:
4264         * Scripts/build-webkit:
4265         * Scripts/run-javascriptcore-tests:
4266         * Scripts/webkitdirs.pm:
4267         * wx/build-wxwebkit:
4268
4269 2007-11-18  Eric Seidel  <eric@webkit.org>
4270
4271         Reviewed by Anders.
4272
4273         Make run-javascriptcore-tests report failures on exit (to support git bisect)
4274
4275         * Scripts/run-javascriptcore-tests:
4276
4277 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
4278
4279         Reviewed by Adam Roben.
4280
4281         Make run-webkit-tests work with Windows debug build.
4282
4283         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
4284         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
4285         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
4286         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
4287         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
4288
4289 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
4290
4291         Add wxWebKit sample and build script, and integrate it with 
4292         build-webkit. Also make build-webkit --clean work for all
4293         ports.
4294
4295         Reviewed by Darin Adler.
4296
4297         * Scripts/build-webkit:
4298         * Scripts/webkitdirs.pm:
4299         * wx: Added.
4300         * wx/browser: Added.
4301         * wx/browser/browser.bkl: Added.
4302         * wx/browser/browser.cpp: Added.
4303         * wx/build-wxwebkit: Added.
4304
4305 2007-11-17  Adam Roben  <aroben@apple.com>
4306
4307         Make it easy to run Safari in the debugger on Windows
4308
4309         I've added a new script, debug-safari, which launches Safari in the
4310         debugger. On OS X it just calls gdb-safari.
4311
4312         Reviewed by Mark Rowe.
4313
4314         * FindSafari/FindSafari.cpp:
4315         (_tmain): Added a /debugger flag, which in combination with
4316         /printSafariLauncher will print a script that launches Safari in the
4317         debugger.
4318         * Scripts/debug-safari: Added.
4319         * Scripts/run-safari: Changed to call runSafari().
4320         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
4321         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
4322         first argument along to FindSafari.
4323         * Scripts/webkitdirs.pm:
4324         (sub runSafari): Added.
4325
4326 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
4327
4328         Reviewed by Adam Roben.
4329
4330         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
4331
4332 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
4333
4334         Reviewed by David Kilzer.
4335
4336         The git config command was renamed to repo-config at some point. This
4337         change tries git config and then git repo-config if the first fails.
4338
4339         * Scripts/prepare-ChangeLog:
4340         (gitConfig):
4341
4342 2007-11-16  Dan Bernstein  <mitz@apple.com>
4343
4344         Reviewed by Darin Adler and Sam Weinig.
4345
4346         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
4347
4348         * DumpRenderTree/win/EventSender.cpp:
4349         (keyDownCallback): For characters that cannot be entered on the active
4350         keyboard layout, send a WM_CHAR message with the character along with
4351         a WM_KEYDOWN message with a virtual key code of 255.
4352
4353 2007-11-16  Mark Rowe  <mrowe@apple.com>
4354
4355         Reviewed by Tim Hatcher.
4356
4357         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
4358
4359         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
4360         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4361
4362 2007-11-15  Adam Roben  <aroben@apple.com>
4363
4364         Make run-safari actually work on Windows