Unreviewed build fix for r69297
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-10-07  Balazs Kelemen  <Balazs Kelemen>
2
3         Unreviewed trivial build fix for r69297
4
5         * WebKitTestRunner/TestController.cpp:
6         (WTR::blankURL):
7
8 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
9
10         Reviewed by Kenneth Rohde Christiansen.
11
12         WebKitTestRunner should be portable
13         https://bugs.webkit.org/show_bug.cgi?id=45393
14
15         Use only the WebKit API for working with urls.
16         * WebKitTestRunner/StringFunctions.h:
17         (WTR::createWKURL):
18         * WebKitTestRunner/TestController.cpp:
19         (WTR::blankURL):
20         (WTR::TestController::resetStateToConsistentValues):
21         (WTR::TestController::didFinishLoadForFrame):
22
23 2010-10-07  Carlos Garcia Campos  <cgarcia@igalia.com>
24
25         Reviewed by Xan Lopez.
26
27         [GTK] Use gtk_widget_draw() instead of gtk_widget_get_snapshot() in PixelDumpSupportGtk when building with gtk3
28         https://bugs.webkit.org/show_bug.cgi?id=47332
29
30         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
31         (createBitmapContextFromWebView):
32
33 2010-10-06  Chris Guillory  <chris.guillory@google.com>
34
35         Reviewed by Chris Fleizach.
36
37         Remove unused accessibility functions from webkit.
38         https://bugs.webkit.org/attachment.cgi?bugid=46707
39
40         * DumpRenderTree/chromium/WebViewHost.cpp:
41         (WebViewHost::postAccessibilityNotification):
42         * DumpRenderTree/chromium/WebViewHost.h:
43
44 2010-10-06  Lucas Forschler  <lforschler@apple.com>
45
46         Reviewed by Adam Roben.
47
48         Fix the sunspider-compare-results to actually use the passed in value for $root.
49
50         * Scripts/sunspider-compare-results:
51
52 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
53
54         Reviewed by Kenneth Rohde Christiansen.
55
56         [Qt] Runloop implementation for WTR
57         https://bugs.webkit.org/show_bug.cgi?id=47280
58
59         * WebKitTestRunner/qt/TestControllerQt.cpp:
60         Implemented TestController::runUntil by a timerEvent
61         and a QEventLoop. We step into the event loop from runUntil.
62         While we are waiting in the loop a timerEvent is periodically
63         checking the value of the condition. Once the condition has
64         becoming true the timerEvent wakes us up.
65         (WTR::RunUntilLoop::start):
66         (WTR::RunUntilLoop::RunUntilLoop):
67         (WTR::RunUntilLoop::run):
68         (WTR::RunUntilLoop::timerEvent):
69         (WTR::TestController::platformInitialize):
70         (WTR::TestController::runUntil):
71         * WebKitTestRunner/qt/main.cpp:
72         Start the main event loop first and creating the TestController later.
73         (Launcher::Launcher):
74         (Launcher::~Launcher):
75         (Launcher::launch): Creating the TestController.
76         (main): Setting up a timer for calling Launcher::launch from
77         the main event loop.
78
79 2010-10-06  Dirk Pranke  <dpranke@chromium.org>
80
81         Reviewed by Kenneth Russell.
82
83         new-run-webkit-tests: fix typo in chromium-gpu that was trying to
84         enable 'accelerated-composting' instead of 'accelerated-compositing'.
85
86         https://bugs.webkit.org/show_bug.cgi?id=47312
87
88         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
89         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
90
91 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
92
93         Reviewed by Kenneth Rohde Christiansen.
94
95         [Qt] PlatformWebView implementation for WebKitTestRunner
96         https://bugs.webkit.org/show_bug.cgi?id=47276
97
98         The implementation follows the way how
99         we use the API in MiniBrowser.
100         * WebKitTestRunner/PlatformWebView.h:
101         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
102         (WTR::WebView::wkView):
103         (WTR::WebView::~WebView):
104         (WTR::WebView::WebView):
105         (WTR::PlatformWebView::PlatformWebView):
106         (WTR::PlatformWebView::~PlatformWebView):
107         (WTR::PlatformWebView::resizeTo):
108         (WTR::PlatformWebView::page):
109         (WTR::PlatformWebView::focus):
110         * WebKitTestRunner/qt/WebKitTestRunner.pro:
111
112 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
113
114         Reviewed by Kenneth Rohde Christiansen.
115
116         [Qt] Add WebKitTestRunner's build files
117         https://bugs.webkit.org/show_bug.cgi?id=44155
118
119         Parts was taken by Zoltan Horvath's patch.
120
121         * Scripts/generate-forwarding-headers.pl: Moved from WebKit2.
122         * Scripts/webkitdirs.pm: Make the generated files needed by WTR.
123         * WebKitTestRunner/PlatformWebView.h: Addeed typedefs for
124         PlatformWKView and PlatformWindow (void* for now).
125         Buildfix the case when __APPLE__ is not defined.
126         * WebKitTestRunner/qt/DerivedSources.pro: Added.
127         * WebKitTestRunner/qt/PlatformWebViewQt.cpp: Added.
128         Empty stub implementation.
129         (WTR::registerWindowClass):
130         (WTR::PlatformWebView::PlatformWebView):
131         (WTR::PlatformWebView::~PlatformWebView):
132         (WTR::PlatformWebView::resizeTo):
133         (WTR::PlatformWebView::page):
134         (WTR::PlatformWebView::focus):
135         * WebKitTestRunner/qt/TestControllerQt.cpp: Added.
136         Empty stub implementation.
137         (WTR::registerWindowClass):
138         (WTR::TestController::runUntil):
139         (WTR::TestController::platformInitialize):
140         (WTR::TestController::initializeInjectedBundlePath):
141         (WTR::TestController::initializeTestPluginDirectory):
142         (WTR::TestController::platformInitializeContext):
143         * WebKitTestRunner/qt/WebKitTestRunner.pro: Added.
144         * WebKitTestRunner/qt/main.cpp: Added.
145         (main):
146
147 2010-10-06  Tony Chang  <tony@chromium.org>
148
149         Unreviewed, rolling out r69202.
150         http://trac.webkit.org/changeset/69202
151         https://bugs.webkit.org/show_bug.cgi?id=46937
152
153         Broke compile of test_shell
154
155         * DumpRenderTree/chromium/EventSender.cpp:
156         (EventSender::beginDragWithFiles):
157         * DumpRenderTree/chromium/WebViewHost.cpp:
158         (addDRTFakeFileToDataObject):
159
160 2010-10-06  Daniel Cheng  <dcheng@chromium.org>
161
162         Reviewed by Tony Chang.
163
164         [chromium] Minor naming cleanup in WebDragData, part 2
165         https://bugs.webkit.org/show_bug.cgi?id=46937
166
167         Update DRT to use the renamed methods.
168
169         * DumpRenderTree/chromium/EventSender.cpp:
170         (EventSender::beginDragWithFiles):
171         * DumpRenderTree/chromium/WebViewHost.cpp:
172         (addDRTFakeFileToDataObject):
173
174 2010-10-06  David Kilzer  <ddkilzer@apple.com>
175
176         <http://webkit.org/b/47270> Move WebArchive serialization code into its own file
177
178         Reviewed by Adam Roben.
179
180         This is the first step in making webarchive tests work on
181         Windows.
182
183         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added
184         new files to the project.
185         * DumpRenderTree/mac/DumpRenderTree.mm: Removed code that moved
186         to WebArchiveDumpSupport.mm.
187         * DumpRenderTree/mac/WebArchiveDumpSupport.h: Added.
188         * DumpRenderTree/mac/WebArchiveDumpSupport.mm: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm.
189         (serializeWebArchiveToXML):
190
191 2010-10-05  Daniel Bates  <dbates@rim.com>
192
193         Reviewed by David Kilzer.
194
195         Add infrastructure to towards detecting change log diffs that aren't at the top of the ChangeLog
196         https://bugs.webkit.org/show_bug.cgi?id=46058
197
198         Make VCSUtils::fixChangeLogPatch() return a reference to a hash
199         structure so as to support returning additional information
200         about a change log diff.
201
202         Currently, VCSUtils::fixChangeLogPatch() returns a string that
203         represents the change log diff. Towards supporting the return
204         of additional information, such as whether the change log diff
205         inserts an entry at the top of the ChangeLog file, we need to
206         make VCSUtils::fixChangeLogPatch() return a reference to hash
207         structure.
208
209         * Scripts/VCSUtils.pm:
210           - Modified fixChangeLogPatch() to return a reference to a
211             hash structure.
212           - Added documentation to fixChangeLogPatch().
213           - Modified call site in mergeChangeLogs() as necessary.
214         * Scripts/svn-apply:
215           - Modified call site in patch() as necessary.
216         * Scripts/svn-create-patch:
217           - Modified call site in generateDiff() as necessary.
218         * Scripts/svn-unapply:
219           - Modified call site in patch() as necessary.
220         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
221           - Modified the unit tests as necessary.
222
223 2010-10-05  Tony Chang  <tony@chromium.org>
224
225         Reviewed by Darin Adler.
226
227         fix the link to the expected image on windows
228         https://bugs.webkit.org/show_bug.cgi?id=47228
229
230         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: On
231             windows, the file must be opened in binary mode when writing
232             binary data.
233
234 2010-10-05  Adam Barth  <abarth@webkit.org>
235
236         Update expected result of unittest to match Tony's change below.
237
238         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
239
240 2010-10-05  Tony Chang  <tony@chromium.org>
241
242         Reviewed by Ojan Vafai (over the shoulder).
243
244         Paper over errors in image_diff so we don't crash the whole test run.
245
246         * Scripts/webkitpy/layout_tests/port/chromium.py:
247
248 2010-10-05  Tony Chang  <tony@chromium.org>
249
250         Unreviewed, make shutil.rmtree more resiliant to errors
251         since windows was raising WindowsError: The process cannot access the file because it
252         is being used by another process.
253
254         * Scripts/webkitpy/layout_tests/port/chromium.py:
255
256 2010-10-05  Tony Chang  <tony@chromium.org>
257
258         Reviewed by Ojan Vafai.
259
260         [chromium] fix image diffing in NRWT
261         https://bugs.webkit.org/show_bug.cgi?id=47128
262
263         * Scripts/webkitpy/layout_tests/port/chromium.py: Stop using
264             NamedTemporaryFile since it doesn't work on Windows.
265         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
266
267 2010-10-05  Kenneth Russell  <kbr@google.com>
268
269         Reviewed by Tony Chang.
270
271         [chromium] Implement layerTreeAsText in DumpRenderTree
272         https://bugs.webkit.org/show_bug.cgi?id=47216
273
274         Plumbed Frame::layerTreeAsText through Chromium's WebKit API to
275         make it callable from DumpRenderTree.
276
277         No new tests; verified with existing compositor layout tests.
278
279         * DumpRenderTree/chromium/LayoutTestController.cpp:
280         (LayoutTestController::LayoutTestController):
281         (LayoutTestController::layerTreeAsText):
282         * DumpRenderTree/chromium/LayoutTestController.h:
283
284 2010-10-05  Brent Fulgham  <bfulgham@webkit.org>
285
286         Unreviewed build correction.
287
288         * DumpRenderTree/win/ImageDiff.vcproj: Use WinCairo debug
289         property sheet so proper libraries are linked.
290
291 2010-10-05  Robert Hogan  <robert@webkit.org>
292
293         Reviewed by Andreas Kling.
294
295         [Qt] Fix url conversion in QWebHistory
296
297         Converting from KURL to WFT::String to QUrl does not
298         permit proper percent encoding later.
299
300         https://bugs.webkit.org/show_bug.cgi?id=47048
301
302         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
303         (WebCore::dumpHistoryItem):
304
305 2010-10-05  Anders Carlsson  <andersca@apple.com>
306
307         Reviewed by Sam Weinig.
308
309         REGRESSION (r68966?): All dumpAsText test fail on WebKit2
310         https://bugs.webkit.org/show_bug.cgi?id=47188
311         <rdar://problem/8514104>
312
313         When constructing the std::string, use the real string length instead of the maximum buffer size.
314
315         * TestWebKitAPI/PlatformUtilities.h:
316         (TestWebKitAPI::Util::toSTD):
317         * WebKitTestRunner/StringFunctions.h:
318         (WTR::toSTD):
319
320 2010-10-04  Sam Weinig  <sam@webkit.org>
321
322         Reviewed by Mark Rowe.
323
324         Add MIMEType accessor to WKFrame
325         <rdar://problem/8347683>
326         https://bugs.webkit.org/show_bug.cgi?id=47138
327
328         * TestWebKitAPI/PlatformUtilities.h:
329         (TestWebKitAPI::Util::toSTD):
330         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
331         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp: Added.
332         (TestWebKitAPI::didStartProvisionalLoadForFrame):
333         (TestWebKitAPI::didCommitLoadForFrame):
334         (TestWebKitAPI::didFinishLoadForFrame):
335         (TestWebKitAPI::TEST):
336         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp: Added.
337         (TestWebKitAPI::didStartProvisionalLoadForFrame):
338         (TestWebKitAPI::didCommitLoadForFrame):
339         (TestWebKitAPI::didFinishLoadForFrame):
340         (TestWebKitAPI::TEST):
341         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
342         (TestWebKitAPI::TEST):
343         * TestWebKitAPI/Tests/WebKit2/basic-1.html: Removed.
344         * TestWebKitAPI/Tests/WebKit2/icon.png: Added.
345         * TestWebKitAPI/Tests/WebKit2/simple.html: Added.
346         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
347         (TestWebKitAPI::Util::createURLForResource):
348
349 2010-10-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
350
351         Reviewed by Ojan Vafai.
352
353         [NRWT] Rename current_dir to current_group because it's not a directory
354         https://bugs.webkit.org/show_bug.cgi?id=47169
355
356         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
357         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
358
359 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
360
361         Unreviewed, build fix.
362
363         r69065 broke test-webkitpy by trying to create a '/tmp-X' directory,
364         which can't always be done. This test uses tempfile.mkdtemp(), which
365         should be safe.
366
367         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
368
369 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
370
371         Unreviewed, build fix.
372
373         Add missing "from __future__ import with_statement" that was
374         breaking test-webkitpy on the Leopard bots (broke in r69040).
375
376         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
377
378 2010-10-04  Sheriff Bot  <webkit.review.bot@gmail.com>
379
380         Unreviewed, rolling out r69066.
381         http://trac.webkit.org/changeset/69066
382         https://bugs.webkit.org/show_bug.cgi?id=47163
383
384         Made NRWT reliability worse. (Requested by tkent on #webkit).
385
386         * Scripts/webkitpy/layout_tests/port/chromium.py:
387         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
388
389 2010-10-04  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
390
391         Reviewed by Tony Chang.
392
393         [NRWT] Reverse the http tests to alphabetical order.
394         https://bugs.webkit.org/show_bug.cgi?id=47075
395
396         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
397
398 2010-10-04  Robert Hogan  <robert@webkit.org>
399
400         Reviewed by Andreas Kling.
401
402         [Qt] Fix timeout on http/tests/navigation/post-goback2.html and postredirect-goback2.html
403
404         We need to queue back and forward navigations in the DRT from the
405         LayoutTestController so that maybeDump() knows about them.
406
407         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
408         (LayoutTestController::queueBackNavigation):
409         (LayoutTestController::queueForwardNavigation):
410
411 2010-10-04  Tony Chang  <tony@chromium.org>
412
413         Reviewed by Kent Tamura.
414
415         [chromium] fix image diffing in NRWT
416         https://bugs.webkit.org/show_bug.cgi?id=47128
417
418         * Scripts/webkitpy/layout_tests/port/chromium.py: Flush data to the
419               temp file and check the image_diff error code more carefully
420         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
421
422 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
423
424         Reviewed by Adam Barth.
425
426         aroben's change in r68792 actually broke new-run-webkit-tests when
427         running the DRT code path. His change was intended to fix the
428         way we were converting windows paths to URIs when running under
429         Cygwin (the paths were getting one too many "/" on the front).
430         However, the change ended up breaking the chromium_win port, which
431         had slightly different logic.
432
433         This patch removes the port-specific code and adds tests to make
434         sure we're getting the behavior we expect. The Port object no longer
435         exposes a get_absolute_path() method that can be used outside of
436         of converting test filenames, because it's unreliable otherwise
437         (we don't have the right context to know which conversion is intended).
438
439         https://bugs.webkit.org/show_bug.cgi?id=47140
440
441         * Scripts/webkitpy/layout_tests/port/base.py:
442         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
443         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
444         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
445         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
446
447 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
448
449         Unreviewed, build fix.
450
451         Handle crash introduced in r69040 if we are not running in a
452         Chromium checkout.
453
454         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
455
456 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
457
458         Reviewed by Tony Chang.
459
460         Add a way for us to have test expectations that are specific to the
461         official builds of Google Chrome (as opposed to Chromium). This change
462         looks for an additional "test_expectations_chrome.txt" file in
463         Chromium's repository (webkit/tools/layout_tests), and uses the
464         concatenation of that file and the regular test_expectations.txt
465         file for test overrides.
466
467         https://bugs.webkit.org/show_bug.cgi?id=46854
468
469         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
470         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
471
472 2010-10-04  Simon Fraser  <simon.fraser@apple.com>
473
474         Color tests in the list based on existing pass/fail result.
475         
476         Fix the summary data to account for htmlOnly and nonHTML tests.
477
478         * CSSTestSuiteHarness/harness/harness.css:
479         (#test-list > option.pass):
480         (#test-list > option.fail):
481         (#test-list > option.skipped):
482         * CSSTestSuiteHarness/harness/harness.js:
483         (Test):
484         (Test.prototype.statusForFormat):
485         (TestSuite.prototype.fillTestList):
486         (TestSuite.prototype.updateTestList):
487         (TestSuite.prototype.recordResult):
488         (TestSuite.prototype.markTestCompleted):
489         (TestSuite.prototype.countTestsWithFlag):
490         (TestSuite.prototype.queryDatabaseForSummary.this.db.transaction):
491         (TestSuite.prototype.queryDatabaseForSummary):
492
493 2010-10-04  Chris Fleizach  <cfleizach@apple.com>
494
495         Reviewed by Beth Dakin.
496
497         AX: doAXRangeForLine does not work
498         https://bugs.webkit.org/show_bug.cgi?id=47101
499
500         DRT support to handle NSAccessibilityRangeForLineParameterizedAttribute.
501
502         * DumpRenderTree/AccessibilityUIElement.cpp:
503         (rangeForLineCallback):
504         (AccessibilityUIElement::rangeForLine):
505         (AccessibilityUIElement::getJSClass):
506         * DumpRenderTree/AccessibilityUIElement.h:
507         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
508         (AccessibilityUIElement::rangeForLine):
509
510 2010-10-04  Andrey Kosyakov  <caseq@chromium.org>
511
512         Unreviewed. Adding myself to the committers list.
513
514         * Scripts/webkitpy/common/config/committers.py:
515
516 2010-10-04  Sam Weinig  <sam@webkit.org>
517
518         Reviewed by Anders Carlsson.
519
520         Add ability to set the CacheModel in Webkit2
521         https://bugs.webkit.org/show_bug.cgi?id=47066
522
523         * MiniBrowser/mac/AppDelegate.m:
524         (-[BrowserAppDelegate init]): Opt minibrowser into
525         a PrimaryWebBrowser cache model.
526
527 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
528
529         Make sure to enter all tests when creating the database
530         for the first time.
531         
532         When migrating to a new version of the suite, be sure to
533         sync up the database and testinfo.data by removing old
534         tests, and inserting new ones.
535
536         * CSSTestSuiteHarness/harness/harness.js:
537         (TestSuite.prototype.openDatabase.creation):
538         (TestSuite.prototype.databaseCreated):
539         (TestSuite.prototype.populateDatabaseFromTestInfoData):
540         (TestSuite.prototype.insertTest):
541
542 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
543
544         More work on treating HTML4 and XHTML1 independently; when 
545         changing the format, rebuild the test list, and update the 
546         numbers in the chapter popup.
547
548         * CSSTestSuiteHarness/harness/harness.js:
549         (Test):
550         (Test.prototype.runForFormat):
551         (Test.prototype.completedForFormat):
552         (ChapterSection):
553         (ChapterSection.prototype.countTests):
554         (Chapter):
555         (Chapter.prototype.description):
556         (Chapter.prototype.countTests):
557         (Chapter.prototype.testCount):
558         (Chapter.prototype.untestedCount):
559         (TestSuite.prototype.buildChapters):
560         (TestSuite.prototype.loadCurrentTest):
561         (TestSuite.prototype.updateProgressLabel):
562         (TestSuite.prototype.processFlags):
563         (TestSuite.prototype.formatChanged):
564
565 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
566
567         Update test suite version 20101001.
568         
569         Handle database migration, and delete tests from the db that are
570         not present in testinfo.data.
571         
572         Load about:blank into the test frame before the test url, to make
573         missing tests more obvious.
574         
575         * CSSTestSuiteHarness/harness/harness.js:
576         (TestSuite.prototype.loadTest):
577         (TestSuite.prototype.openDatabase.creation):
578         (TestSuite.prototype.openDatabase.migration1_0To1_1):
579         (TestSuite.prototype.openDatabase.if.return):
580         (TestSuite.prototype.databaseReady):
581         (TestSuite.prototype.populateDatabaseFromTestInfoData):
582         (TestSuite.prototype.syncDatabaseWithTestInfoData.this.db.transaction):
583         (TestSuite.prototype.syncDatabaseWithTestInfoData):
584
585 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
586
587         Add the ability to jump to a specific test.
588
589         * CSSTestSuiteHarness/harness/harness.html:
590         * CSSTestSuiteHarness/harness/harness.js:
591         (TestSuite.prototype.goToTestByName):
592         (TestSuite.prototype.switchToFormat):
593
594 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
595
596         For a ref test, load the ref in the same format (HTML4 vs XHTML1)
597         as the test.
598
599         * CSSTestSuiteHarness/harness/harness.js:
600         (TestSuite.prototype.loadRef):
601
602 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
603
604         Update the UI to reflect the fact that each test needs to be tested
605         in both HTML4 and XHTML1 format.
606         
607         * CSSTestSuiteHarness/harness/harness.js:
608         (Test):
609         (Chapter.prototype.description):
610         (Chapter.prototype.untestedCount):
611         (TestSuite.prototype.fillChapterPopup):
612         (TestSuite.prototype.updateChapterPopup):
613         (TestSuite.prototype.fillTestList):
614         (TestSuite.prototype.updateTestList):
615         (TestSuite.prototype.goToNextIncompleteTest):
616         (TestSuite.prototype.firstIncompleteTestIndex):
617         (TestSuite.prototype.recordResult):
618         (TestSuite.prototype.formatChanged):
619         (TestSuite.prototype.markTestCompleted):
620         (TestSuite.prototype.resetTestStatus):
621
622 2010-10-01  Simon Fraser  <simon.fraser@apple.com>
623
624         Add the ability to remove results for re-testing, and
625         to import results.
626
627         * CSSTestSuiteHarness/harness/harness.css:
628         (.custom button):
629         (#overlay):
630         (#overlay.visible):
631         (.overlay-contents):
632         (.overlay-contents textarea):
633         (.overlay-contents .buttons):
634         (.overlay-contents .note):
635         (.overlay-contents .buttons button):
636         * CSSTestSuiteHarness/harness/harness.html:
637         * CSSTestSuiteHarness/harness/harness.js:
638         (TestSuite.prototype.importResults):
639         (TestSuite.prototype.clearResults):
640         (TestSuite.prototype.markTestCompleted):
641         (TestSuite.prototype.resetTestStatus):
642         (TestSuite.prototype.storeTestResult):
643         (TestSuite.prototype.importTestResults):
644         (TestSuite.prototype.clearTestResults):
645
646 2010-10-01  Sam Weinig  <sam@webkit.org>
647
648         Reviewed by Jon Honeycutt.
649
650         Deploy the new WKString functions to remove most uses of CF from
651         the WebKitTestRunner.
652
653         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
654         (WTR::InjectedBundle::didReceiveMessage):
655         (WTR::InjectedBundle::done):
656         * WebKitTestRunner/StringFunctions.h:
657         (WTR::toWK):
658         (WTR::toJS):
659         (WTR::toSTD):
660         (WTR::operator<<):
661         (WTR::copyURLString):
662         * WebKitTestRunner/TestController.cpp:
663         (WTR::TestController::resetStateToConsistentValues):
664         (WTR::TestController::didFinishLoadForFrame):
665         * WebKitTestRunner/TestInvocation.cpp:
666         (WTR::TestInvocation::invoke):
667         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
668
669 2010-10-01  Mihai Parparita  <mihaip@chromium.org>
670
671         Unreviewed TestResultsServer change.
672
673         Add files introduced by http://crrev.com/61273 to the list of dashboard 
674         files to update.
675
676         * TestResultServer/handlers/dashboardhandler.py:
677
678 2010-10-01  Brian Weinstein  <bweinstein@apple.com>
679
680         Build Fix for Windows.
681
682         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Don't copy ForwardingHeaders from
683             WebKitTestRunner/ForwardingHeaders, instead, add $(WebKitOutputDir)/include/WebCore/
684             ForwardingHeaders to the include path.
685
686 2010-10-01  Sam Weinig  <sam@webkit.org>
687
688         Reviewed by Anders Carlsson.
689
690         Add SPI to convert a WKStringRef to a JSStringRef and vice-versa.
691
692         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
693         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
694         (TestWebKitAPI::TEST):
695         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp: Added.
696         (TestWebKitAPI::TEST):
697
698 2010-10-01  Sam Weinig  <sam@webkit.org>
699
700         Reviewed by Kenneth Rohde Christiansen.
701
702         Add additional WKString API
703         https://bugs.webkit.org/show_bug.cgi?id=46958
704
705         Add basic WKStringRef tests.
706
707         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
708         * TestWebKitAPI/Tests/WebKit2/WKString.cpp: Added.
709
710 2010-10-01  Sam Weinig  <sam@webkit.org>
711
712         Reviewed by Dan Bernstein.
713
714         Add makefile for TestWebKitAPI and call it from the base makefile.
715
716         * Makefile:
717         * TestWebKitAPI/Makefile: Added.
718
719 2010-10-01  Sam Weinig  <sam@webkit.org>
720
721         Reviewed by Adam Roben.
722
723         Remove unnecessary ForwardingHeaders from test runners.
724         https://bugs.webkit.org/show_bug.cgi?id=47010
725
726         * TestWebKitAPI/Configurations/Base.xcconfig:
727         * TestWebKitAPI/ForwardingHeaders: Removed.
728         * WebKitTestRunner/Configurations/Base.xcconfig:
729         * WebKitTestRunner/ForwardingHeaders: Removed.
730
731 2010-09-30  Adam Barth  <abarth@webkit.org>
732
733         Reviewed by Eric Seidel.
734
735         WebSocket tests are flaky
736         https://bugs.webkit.org/show_bug.cgi?id=46956
737
738         Update these tools to understand how to run the WebSocket tests off the
739         Apache server.
740
741         * Scripts/old-run-webkit-tests:
742         * Scripts/webkitpy/layout_tests/port/base.py:
743         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
744         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
745
746 2010-10-01  Adam Roben  <aroben@apple.com>
747
748         Encode Executive command arguments using UTF-8 on Cygwin
749
750         Cygwin's Python's os.execv doesn't support unicode command arguments.
751         Cygwin's execv expects arguments to be encoded using the current code
752         page. But code pages are limited in what characters they can handle,
753         and our tests include characters that the English code page can't
754         handle.  So for now we'll just encode everything in UTF-8 on Cygwin,
755         which can handle all characters but might confuse some commands, for
756         expediency's sake. I'm sure we'll run into cases where UTF-8 isn't
757         good enough, but we can deal with that when the problem arises.
758
759         Reviewed by Adam Barth.
760
761         Fixes <http://webkit.org/b/46892> <rdar://problem/8496639>
762         webkitpy.common.system.executive_unittest.ExecutiveTest.test_run_command_with_unicode
763         fails on Windows
764
765         * Scripts/webkitpy/common/system/executive.py:
766         (Executive._run_command_with_teed_output):
767         (Executive.run_command):
768         On Cygwin, encode arguments using UTF-8.
769
770 2010-10-01  Sam Weinig  <sam@webkit.org>
771
772         Reviewed by Adam Roben.
773
774         Add simple API tester for WebKit2
775         https://bugs.webkit.org/show_bug.cgi?id=46953
776
777         This adds a very simple testing infrastructure for testing APIs exposed
778         through the WebKit project. It consists of two parts: 1) a project that
779         builds the all the tests 2) a script that searches the tests directory and
780         calls the tester once for each test.
781
782         This adds the infrastructure and two tests:
783         - Tests/WTF/Vector1.cpp - A proof of concept test of WTF data-structures.
784         - Tests/WebKit2/BasicTest1.cpp - A proof of concept test of WebKit2 API.
785
786         This currently only works on the mac, but is designed to be easily ported 
787         to any platform.
788
789         * Scripts/run-api-tests: Added.
790         * Scripts/build-api-tests: Added.
791         Scripts to build/run the tests.
792
793         * TestWebKitAPI: Added.
794         * TestWebKitAPI/Configurations: Added.
795         * TestWebKitAPI/Configurations/Base.xcconfig: Added.
796         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Added.
797         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Added.
798         * TestWebKitAPI/ForwardingHeaders: Added.
799         * TestWebKitAPI/ForwardingHeaders/wtf: Added.
800         * TestWebKitAPI/PlatformUtilities.h: Added.
801         * TestWebKitAPI/PlatformWebView.h: Added.
802         (TestWebKitAPI::PlatformWebView::platformView):
803         * TestWebKitAPI/StringFunctions.h: Added.
804         * TestWebKitAPI/Test.h: Added.
805         (TestWebKitAPI::Test::~Test):
806         (TestWebKitAPI::Test::name):
807         (TestWebKitAPI::Test::Register::Register):
808         (TestWebKitAPI::Test::Register::create):
809         (TestWebKitAPI::Test::Test):
810         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Added.
811         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added.
812         * TestWebKitAPI/TestWebKitAPIPrefix.h: Added.
813         * TestWebKitAPI/TestsController.cpp: Added.
814         (TestWebKitAPI::TestsController::shared):
815         (TestWebKitAPI::TestsController::TestsController):
816         (TestWebKitAPI::TestsController::runTestNamed):
817         (TestWebKitAPI::TestsController::testFailed):
818         (TestWebKitAPI::TestsController::registerCreateTestFunction):
819         * TestWebKitAPI/TestsController.h: Added.
820         * TestWebKitAPI/mac: Added.
821         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm: Added.
822         (TestWebKitAPI::Util::run):
823         (TestWebKitAPI::Util::createURLForResource):
824         * TestWebKitAPI/mac/PlatformWebViewMac.mm: Added.
825         (TestWebKitAPI::PlatformWebView::PlatformWebView):
826         (TestWebKitAPI::PlatformWebView::resizeTo):
827         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
828         (TestWebKitAPI::PlatformWebView::page):
829         (TestWebKitAPI::PlatformWebView::focus):
830         * TestWebKitAPI/mac/main.mm: Added.
831         Infrastructure.
832
833         * TestWebKitAPI/Tests: Added.
834         * TestWebKitAPI/Tests/WTF: Added.
835         * TestWebKitAPI/Tests/WTF/Vector1.cpp: Added.
836         * TestWebKitAPI/Tests/WebKit2: Added.
837         * TestWebKitAPI/Tests/WebKit2/BasicTest1.cpp: Added.
838         (TestWebKitAPI::State::State):
839         * TestWebKitAPI/Tests/WebKit2/basic-1.html: Added.
840         Proof of concept tests.
841
842 2010-10-01  Adam Roben  <aroben@apple.com>
843
844         Don't assume AccessibleObjectFromEvent succeeds
845
846         Fixes <http://webkit.org/b/44136> <rdar://problem/8321684> Crash in
847         DumpRenderTree!notificationListenerProc when running
848         plugins/access-after-page-destroyed.html
849
850         Reviewed by Sam Weinig.
851
852         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
853         (notificationListenerProc): Check both the return value of
854         AccessibleObjectFromEvent and the object it returns, as MSDN
855         recommends.
856
857 2010-10-01  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
858
859         Reviewed by Tony Chang.
860
861         [NRWT] Put the http and websocket tests first in the test list.
862         https://bugs.webkit.org/show_bug.cgi?id=46453
863
864         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
865         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
866
867 2010-10-01  Fady Samuel  <fsamuel@chromium.org>
868
869         Unreviewed, adding myself to the committer list.
870
871         * Scripts/webkitpy/common/config/committers.py:
872
873 2010-10-01  Adam Roben  <aroben@apple.com>
874
875         Test NPN_GetValue(NPNVnetscapeWindow)
876
877         Test for <http://webkit.org/b/46726> <rdar://problem/8486319>
878         Right-clicking on windowless Flash plugin in WebKit2 makes a context
879         menu appear in the bottom-right corner of the screen
880
881         Reviewed by Anders Carlsson.
882
883         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
884         (PluginTest::NPN_GetValue): Added. Calls through to the browser.
885
886         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added NPN_GetValue.
887
888         * DumpRenderTree/TestNetscapePlugIn/Tests/win/GetValueNetscapeWindow.cpp: Added.
889         (GetValueNetscapeWindow::GetValueNetscapeWindow): Initialize members.
890         (GetValueNetscapeWindow::NPP_SetWindow): Test that
891         NPN_GetValue(NPNVnetscapeWindow) returns a valid HWND and that it
892         isn't our HWND.
893
894         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
895         Added GetValueNetscapeWindow.
896
897 2010-10-01  Andreas Kling  <andreas.kling@nokia.com>
898
899         Unreviewed, adding my webkit.org identity to reviewer list.
900
901         * Scripts/webkitpy/common/config/committers.py:
902
903 2010-09-30  Adam Barth  <abarth@webkit.org>
904
905         Reviewed by Eric Seidel.
906
907         The WebSocket server should flush its logs
908         https://bugs.webkit.org/show_bug.cgi?id=46946
909
910         The WebSocket server logs are truncated because the driver just
911         terminates the child.  It should run Python without buffering so we can
912         see the end of the log.
913
914         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
915
916 2010-09-30  Simon Fraser  <simon.fraser@apple.com>
917
918         Add a button to jump to the next untested test.
919         
920         * CSSTestSuiteHarness/harness/harness.css:
921         (.test-type):
922         (.name > button):
923         * CSSTestSuiteHarness/harness/harness.html:
924         * CSSTestSuiteHarness/harness/harness.js:
925         (Chapter.prototype.description):
926         (Chapter.prototype.untestedCount):
927         (TestSuite.prototype.testInfoDataLoaded):
928         (TestSuite.prototype.fillChapterPopup):
929         (TestSuite.prototype.updateChapterPopup):
930         (TestSuite.prototype.buildTestListForChapter):
931         (TestSuite.prototype.goToNextIncompleteTest):
932         (TestSuite.prototype.firstIncompleteTestIndex):
933         (TestSuite.prototype.testCompletionStateChanged):
934
935 2010-09-29  Jon Honeycutt  <jhoneycutt@apple.com>
936
937         WebKit2 on Windows should use Windows fonts for the various standard
938         font families
939         https://bugs.webkit.org/show_bug.cgi?id=43499
940         <rdar://problem/8272758>
941
942         Reviewed by Adam Roben.
943
944         * WebKitTestRunner/TestController.cpp:
945         (WTR::TestController::resetStateToConsistentValues):
946         Use the Mac fonts for running tests. This matches DRT behavior.
947
948 2010-09-30  Adam Barth  <abarth@webkit.org>
949
950         Third attempt.  We need a better integration test environment.
951
952         * Scripts/webkitpy/common/net/failuremap.py:
953         * Scripts/webkitpy/common/net/failuremap_unittest.py:
954
955 2010-09-30  Robert Hogan  <robert@webkit.org>
956
957         Reviewed by Andreas Kling.
958
959         [Qt] Support for PlainTextController
960
961         Unskip editing/text-iterator/basic-iteration.html
962
963         https://bugs.webkit.org/show_bug.cgi?id=38805
964
965         * DumpRenderTree/qt/DumpRenderTree.pro:
966         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
967         (WebCore::DumpRenderTree::DumpRenderTree):
968         (WebCore::DumpRenderTree::initJSObjects):
969         * DumpRenderTree/qt/DumpRenderTreeQt.h:
970         * DumpRenderTree/qt/PlainTextControllerQt.cpp: Added.
971         (PlainTextController::PlainTextController):
972         (PlainTextController::plainText):
973         * DumpRenderTree/qt/PlainTextControllerQt.h: Added.
974
975 2010-09-30  Adam Barth  <abarth@webkit.org>
976
977         Unreviewed.  Second attempt to fix sheriffbot.
978
979         * Scripts/webkitpy/common/net/buildbot.py:
980
981 2010-09-30  Adam Barth  <abarth@webkit.org>
982
983         Unreviewed.
984
985         This patch should stop the sheriffbot from throwing an exception.
986
987         * Scripts/webkitpy/common/net/buildbot.py:
988
989 2010-09-30  Brian Weinstein  <bweinstein@apple.com>
990
991         Reviewed by Adam Roben.
992
993         The same bots shouldn't run both Windows Debug Tests and Windows Release Tests.
994         https://bugs.webkit.org/show_bug.cgi?id=46926
995
996         * BuildSlaveSupport/build.webkit.org-config/config.json: Have two bots running Windows 
997             Release Tests, and two bots running Windows Debug Tests, instead of four running both.
998
999 2010-09-30  Adam Barth  <abarth@webkit.org>
1000
1001         Reviewed by Eric Seidel.
1002
1003         webkit-patch find-flaky-tests should print results URLs
1004         https://bugs.webkit.org/show_bug.cgi?id=46917
1005
1006         Printing out the results URL makes find-flaky-tests more actionable
1007         because you can see what happens when a test fails.  The output from
1008         the script is still pretty noisy, but it seems useful.
1009
1010         * Scripts/webkitpy/tool/commands/queries.py:
1011
1012 2010-09-30  Chris Marrin  <cmarrin@apple.com>
1013
1014         Reviewed by Simon Fraser.
1015
1016         Make 2D accelerated canvas rendering build on Mac
1017         https://bugs.webkit.org/show_bug.cgi?id=46007
1018         
1019         Added ACCELERATED_2D_CANVAS to build-webkit
1020
1021         * Scripts/build-webkit:
1022
1023 2010-09-29  Kenneth Russell  <kbr@google.com>
1024
1025         Reviewed by Dimitri Glazkov.
1026
1027         [chromium] Add accelerated compositing support to DumpRenderTree and test_shell
1028         https://bugs.webkit.org/show_bug.cgi?id=46849
1029
1030         Added offscreen code path for WebGraphicsContext3DDefaultImpl which
1031         works with the compositor integration in both DumpRenderTree and
1032         test_shell, since both pass a non-null WebCanvas* to WebViewImpl::paint
1033         and thereby trigger the compositor's readback code path. Added support
1034         for --enable-accelerated-compositing to DumpRenderTree.
1035
1036         Tested in both test_shell and DumpRenderTree on Linux, the latter by
1037         modifying a compositing layout test, dumping the pixels and verifying
1038         that they matched the output when the compositor was active.
1039
1040         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1041         (main):
1042         * DumpRenderTree/chromium/TestShell.cpp:
1043         (TestShell::TestShell):
1044         (TestShell::resetWebSettings):
1045         * DumpRenderTree/chromium/TestShell.h:
1046         (TestShell::setAcceleratedCompositingEnabled):
1047         * DumpRenderTree/chromium/WebPreferences.cpp:
1048         (WebPreferences::reset):
1049         (WebPreferences::applyTo):
1050         * DumpRenderTree/chromium/WebPreferences.h:
1051         * DumpRenderTree/chromium/WebViewHost.cpp:
1052         (WebViewHost::scheduleComposite):
1053         * DumpRenderTree/chromium/WebViewHost.h:
1054
1055 2010-09-30  Adam Roben  <aroben@apple.com>
1056
1057         Ensure that QueueEngine cleans up its log files when its delegate
1058         tells it to stop processing work
1059
1060         Reviewed by Adam Barth.
1061
1062         Fixes <http://webkit.org/b/46891> <rdar://problem/8496638> Many tests
1063         in webkitpy.tool.bot.queueengine_unittest.QueueEngineTest crash on
1064         Windows
1065
1066         * Scripts/webkitpy/tool/bot/queueengine.py:
1067         (QueueEngine.run): Stop ourselves normally (including cleaning up log
1068         files) when the delegate tells us to stop processing work.
1069
1070         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1071         (LoggingDelegate.__init__): Moved code here from
1072         RaisingDelegate.__init__.
1073         (LoggingDelegate.expeced_callbacks): Added the stop_work_queue
1074         callback.
1075         (LoggingDelegate.stop_work_queue): Moved here from RaisingDelegate.
1076         (RaisingDelegate.__init__): Removed code that LoggingDelegate takes
1077         care of for us now.
1078         (QueueEngineTest.test_trivial): Make sure we got the expected stop
1079         message.
1080         (QueueEngineTest.test_not_safe_to_proceed): Changed to explicitly
1081         remove the callbacks that are related to processing a single work
1082         item, rather than removing all callbacks after a certain point, as
1083         there are now more callbacks we expect to receive at the end.
1084
1085 2010-09-30  Adam Roben  <aroben@apple.com>
1086
1087         Fix path -> URL conversion on Cygwin
1088
1089         Reviewed by Adam Barth.
1090
1091         Fixes <http://webkit.org/b/46890> <rdar://problem/8496637> Many tests
1092         in webkitpy.layout_tests.run_webkit_tests_unittest assert on Windows
1093
1094         * Scripts/webkitpy/layout_tests/port/base.py:
1095         (Port.filename_to_uri): Treat Cygwin like other UNIX-y platforms by
1096         assuming paths already have a leading slash.
1097
1098 2010-09-30  Adam Roben  <aroben@apple.com>
1099
1100         Teach WindowGeometryInitializedBeforeSetWindow that NPP_SetWindow can
1101         be called more than once
1102
1103         The NPP_SetWindow call made when the plugin is torn down was confusing
1104         us, and was causing us to spew an error into the next test.
1105
1106         Fixes <http://webkit.org/b/46900> <rdar://problem/8496888> REGRESSION
1107         (r68520): plugins/access-after-page-destroyed.html failing on Windows
1108
1109         Reviewed by Anders Carlsson.
1110
1111         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:
1112         (WindowGeometryInitializedBeforeSetWindow::WindowGeometryInitializedBeforeSetWindow):
1113         Initialize member.
1114         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Bail if
1115         this isn't the first time this is called.
1116
1117 2010-09-30  Eric Seidel  <eric@webkit.org>
1118
1119         Reviewed by Adam Barth.
1120
1121         webkit-patch upload warns that I'm using Xcode when I'm not
1122         https://bugs.webkit.org/show_bug.cgi?id=46869
1123
1124         String.find returns -1 when not found, so switched to "in".
1125
1126         * Scripts/webkitpy/common/system/user.py:
1127         * Scripts/webkitpy/common/system/user_unittest.py:
1128
1129 2010-09-30  Eric Seidel  <eric@webkit.org>
1130
1131         Reviewed by Adam Barth.
1132
1133         webkit-patch failure-reason dies if non-trunk commits are in the blame range
1134         https://bugs.webkit.org/show_bug.cgi?id=46866
1135
1136         I also made failure-reason use RegressionWindow in a cleaner way.
1137
1138         * Scripts/webkitpy/tool/commands/queries.py:
1139
1140 2010-09-29  Adam Barth  <abarth@webkit.org>
1141
1142         Reviewed by Eric Seidel.
1143
1144         webkit-patch find-flaky-tests
1145         https://bugs.webkit.org/show_bug.cgi?id=46876
1146
1147         This command helps us find flaky tests so we can squash them.
1148
1149         * Scripts/webkitpy/tool/commands/queries.py:
1150
1151 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
1152
1153         Fix export to use '?' instead of 'null' for
1154         tests with no results.
1155         
1156         * CSSTestSuiteHarness/harness/harness.js:
1157
1158 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
1159
1160         Add a warning when a test requires special steps.
1161         Add a Print Preview button for 'paged' tests that
1162         brings up the print dialog, allowing the user to 
1163         judge paged media tests.
1164
1165         * CSSTestSuiteHarness/harness/harness.css:
1166         * CSSTestSuiteHarness/harness/harness.html:
1167         * CSSTestSuiteHarness/harness/harness.js:
1168         (TestSuite.prototype.loadTest):
1169         (TestSuite.prototype.processFlags):
1170
1171 2010-09-29  Adam Barth  <abarth@webkit.org>
1172
1173         Reviewed by Eric Seidel.
1174
1175         Remove revisions_casuing_failures
1176         https://bugs.webkit.org/show_bug.cgi?id=46872
1177
1178         This function exists only to be unit tested.
1179
1180         * Scripts/webkitpy/common/net/failuremap.py:
1181         * Scripts/webkitpy/common/net/failuremap_unittest.py:
1182         * Scripts/webkitpy/tool/mocktool.py:
1183
1184 2010-09-29  Adam Barth  <abarth@webkit.org>
1185
1186         Reviewed by Eric Seidel.
1187
1188         SheriffBot should post the list of failing tests to bugs
1189         https://bugs.webkit.org/show_bug.cgi?id=46871
1190
1191         * Scripts/webkitpy/common/net/buildbot.py:
1192         * Scripts/webkitpy/common/net/failuremap.py:
1193         * Scripts/webkitpy/common/net/regressionwindow.py:
1194         * Scripts/webkitpy/tool/bot/sheriff.py:
1195         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
1196         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1197         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1198         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1199         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1200         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1201         * Scripts/webkitpy/tool/mocktool.py:
1202
1203 2010-09-29  Brent Fulgham  <bfulgham@webkit.org>
1204
1205         Reviewed by Martin Robinson, Eric Seidel, and Mark Rowe.
1206
1207         [WinCairo] Adds a build slave.
1208         https://bugs.webkit.org/show_bug.cgi?id=46360
1209
1210         * BuildSlaveSupport/build.webkit.org-config/config.json: Add
1211         entries for a debug build of the WinCairo port.
1212         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add
1213         platform flag to configuration for wincairo (like gtk, chromium, etc.)
1214         * Scripts/build-webkit: Change 'cairo-win32' labeling to 'wincairo'
1215         * Scripts/webkitdirs.pm: Change 'cairo-win32' labeling to 'wincairo'
1216
1217 2010-09-29  Adam Barth  <abarth@webkit.org>
1218
1219         Reviewed by Eric Seidel.
1220
1221         Move more SheriffBot smarts into FailureMap
1222         https://bugs.webkit.org/show_bug.cgi?id=46703
1223
1224         This patch pushes the FailureMap model object further into the
1225         SheriffBot machine.  In addition, it moves a couple operations on this
1226         object from SheriffBot itself to the model.
1227
1228         Eventually, FailureMap will be the canonical context object for
1229         SheriffBot operations.  FailureMap represents a map of the current
1230         failures on the bots that might require remediation.
1231
1232         * Scripts/webkitpy/common/net/failuremap.py:
1233         * Scripts/webkitpy/common/net/regressionwindow.py:
1234         * Scripts/webkitpy/tool/commands/queries.py:
1235         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1236         * Scripts/webkitpy/tool/mocktool.py:
1237
1238 2010-09-29  Tony Chang  <tony@chromium.org>
1239
1240         Reviewed by James Robinson.
1241
1242         [chromium] enable -Werror for DRT and webkit_unit_tests on Linux
1243         https://bugs.webkit.org/show_bug.cgi?id=46829
1244
1245         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1246         (DRTDevToolsClient::DRTDevToolsClient):
1247         * DumpRenderTree/chromium/TestShell.cpp:
1248         (TestShell::TestShell):
1249         * DumpRenderTree/chromium/WebViewHost.cpp:
1250         (WebViewHost::postAccessibilityNotification):
1251         (WebViewHost::WebViewHost):
1252
1253 2010-09-29  Chris Fleizach  <cfleizach@apple.com>
1254
1255         Reviewed by Darin Adler.
1256
1257         AX: implement CSS3 Speech "speak"
1258         https://bugs.webkit.org/show_bug.cgi?id=46827
1259
1260         * DumpRenderTree/AccessibilityUIElement.cpp:
1261         (speakCallback):
1262         (AccessibilityUIElement::speak):
1263         (AccessibilityUIElement::getJSClass):
1264         * DumpRenderTree/AccessibilityUIElement.h:
1265         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1266         (AccessibilityUIElement::speak):
1267
1268 2010-09-29  Mihai Parparita  <mihaip@chromium.org>
1269
1270         Reviewed by Adam Barth.
1271
1272         Record bot ID when updating queue status
1273         https://bugs.webkit.org/show_bug.cgi?id=46764
1274         
1275         Since we now have multiple bots handling patches from the commit queue,
1276         we need to differentiate status updates from them, so that we can group
1277         the queue status page in a less confusing way.
1278
1279         * QueueStatusServer/handlers/updatestatus.py: Accept bot_id as input
1280         * QueueStatusServer/model/queuestatus.py: Add bot_id property
1281         * QueueStatusServer/templates/updatestatus.html: Add bot_id input
1282         * Scripts/webkitpy/common/net/bugzilla_unittest.py: Extract MockBrowser
1283         * Scripts/webkitpy/common/net/statusserver.py: Add bot_id
1284         * Scripts/webkitpy/common/net/statusserver_unittest.py: Added.
1285         * Scripts/webkitpy/tool/main.py: Add --bot-id
1286         * Scripts/webkitpy/tool/mocktool.py: Add MockBrowser
1287
1288 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
1289
1290         No review.
1291         
1292         References always refert to a file in .xht format, even
1293         for HTML tests, so fix their loading.
1294
1295         * CSSTestSuiteHarness/harness/harness.js:
1296         (TestSuite.prototype.loadRef):
1297
1298 2010-09-28  Johnny Ding  <jnd@chromium.org>
1299
1300         Reviewed by Adam Barth.
1301
1302         https://bugs.webkit.org/show_bug.cgi?id=41292
1303         Add a new parameter to the test plugin to allow specifying a script 
1304         and a mouse/keyboard event. The specified script will be evaluated
1305         in the browser when the specified event is received by the plugin.
1306
1307         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1308         (pluginAllocate):
1309         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
1310         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1311         (NPP_New):
1312         (handleEventCarbon):
1313         (handleEventCocoa):
1314
1315 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1316
1317         Fix export by adding missing argument.
1318
1319         * CSSTestSuiteHarness/harness/harness.js:
1320         (TestSuite.prototype.showResultsForAllTests):
1321
1322 2010-09-28  Kevin Ollivier  <kevino@theolliviers.com>
1323
1324         [wx] Build fix, add missing import.
1325
1326         * wx/packaging/build-win-installer.py:
1327
1328 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1329
1330         No review
1331         
1332         Show which tests have been run by dimming them out in the test list.
1333         
1334         Adjust some element sizes.
1335         
1336         * CSSTestSuiteHarness/harness/harness.css:
1337         (#test-list > option.untested):
1338         (#test-list > option.completed):
1339         (#output):
1340         (.output-options):
1341         * CSSTestSuiteHarness/harness/harness.js:
1342         (Test):
1343         (TestSuite.prototype.fillTestList):
1344         (TestSuite.prototype.updateTestList):
1345         (TestSuite.prototype.setSelectedChapter):
1346         (TestSuite.prototype.recordResult):
1347         (TestSuite.prototype.markTestCompleted):
1348         (TestSuite.prototype.testCompletionStateChanged):
1349         (TestSuite.prototype.loadTestStatus):
1350
1351 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1352
1353         No review.
1354         
1355         Implement export of various queries on the test database, sharing
1356         code with that which displays results inline.
1357
1358         * CSSTestSuiteHarness/harness/harness.js:
1359         ():
1360         (TestSuite.prototype.exportResultsCompletion.var):
1361         (TestSuite.prototype.exportResultsCompletion):
1362         (TestSuite.prototype.showResultsForCompletedTests):
1363         (TestSuite.prototype.exportResultsForCompletedTests):
1364         (TestSuite.prototype.showResultsForAllTests):
1365         (TestSuite.prototype.exportResultsForAllTests):
1366         (TestSuite.prototype.exportResultsForTestsNotRun):
1367         (TestSuite.prototype.exportResultsForTestsWithStatus):
1368         (TestSuite.prototype.exportResultsForTestsWithMismatchedResults):
1369
1370 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1371
1372         No review.
1373
1374         Work around uncertainty about the order of database
1375         transactions when creating the database, so that we don't
1376         try to query the table before it has been created.
1377
1378         * CSSTestSuiteHarness/harness/harness.js:
1379         (TestSuite):
1380         (TestSuite.prototype.databaseCreated):
1381         (TestSuite.prototype.storeTestResult):
1382         (TestSuite.prototype.populateDatabaseFromTestInfoData):
1383         (TestSuite.prototype.queryDatabaseForTestsWithStatus):
1384         (TestSuite.prototype.queryDatabaseForTestsWithMixedStatus):
1385         (TestSuite.prototype.queryDatabaseForCompletedTests):
1386         (TestSuite.prototype.queryDatabaseForTestsNotRun):
1387
1388 2010-09-28  Tony Chang  <tony@chromium.org>
1389
1390         Reviewed by Eric Seidel.
1391
1392         add python keyring support to webkit-patch
1393         https://bugs.webkit.org/show_bug.cgi?id=41269
1394
1395         * Scripts/webkitpy/common/net/credentials.py: Add the ability to read passwords using
1396             the python keyring module
1397         * Scripts/webkitpy/common/net/credentials_unittest.py:
1398         * Scripts/webkitpy/common/system/user.py: Allow confirm() to default to no and add testing params.
1399         * Scripts/webkitpy/common/system/user_unittest.py:
1400         * Scripts/webkitpy/tool/mocktool.py:
1401
1402 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
1403
1404         Reviewed by Gustavo Noronha Silva.
1405
1406         [Cairo] FreeType fonts should obey FontConfig hinting/anti-aliasing settings
1407         https://bugs.webkit.org/show_bug.cgi?id=46740
1408
1409         * DumpRenderTree/gtk/fonts/fonts.conf: Add specialized variants of common
1410         fonts which can be used to fully test FontConfig rendering settings.
1411
1412 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
1413
1414         Reviewed by Gustavo Noronha Silva.
1415
1416         [gtk] Fedora has a different path for the liberation fonts
1417         https://bugs.webkit.org/show_bug.cgi?id=46709
1418
1419         When searching for DRT fonts, also look in the path where those fonts
1420         are commonly found on Fedora systems.
1421
1422         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1423         (initializeFonts): Include logic for looking for Fedora-style font paths.
1424
1425 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
1426
1427         Reviewed by Andreas Kling.
1428
1429         run-webkit-tests needs an updated list of directories with webgl tests
1430         https://bugs.webkit.org/show_bug.cgi?id=46747
1431
1432         Update the list of directories containing WebGL tests and a unit test
1433         which depends on this list.
1434
1435         * Scripts/old-run-webkit-tests: Update the list of directories.
1436         * Scripts/webkitpy/layout_tests/port/webkit.py: Ditto.
1437         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Update the expected result.
1438
1439 2010-09-28  Adam Barth  <abarth@webkit.org>
1440
1441         Reviewed by Eric Seidel.
1442
1443         Introduce FailureMap to summaries the failures status of all the bots
1444         https://bugs.webkit.org/show_bug.cgi?id=46700
1445
1446         This patch gives the SheriffBot a handle on the list of failing tests.
1447
1448         * Scripts/webkitpy/common/net/buildbot.py:
1449         * Scripts/webkitpy/common/net/failuremap.py: Added.
1450         * Scripts/webkitpy/tool/commands/queries.py:
1451         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1452         * Scripts/webkitpy/tool/mocktool.py:
1453
1454 2010-09-28  Adam Roben  <aroben@apple.com>
1455
1456         Update for the addition of WKPageUIClient::didNotHandleKeyEvent
1457
1458         Fixes <http://webkit.org/b/46660> <rdar://problem/8483465> Need API to
1459         tell a WebKit2 client application that a key event was not handled
1460
1461         Reviewed by Kenneth Rohde Christiansen and Sam Weinig.
1462
1463         * MiniBrowser/mac/BrowserWindowController.m:
1464         (-[BrowserWindowController awakeFromNib]):
1465         * MiniBrowser/win/BrowserView.cpp:
1466         (BrowserView::create):
1467         * WebKitTestRunner/TestController.cpp:
1468         (WTR::createOtherPage):
1469         (WTR::TestController::initialize):
1470
1471 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1472
1473         Unreviewed.
1474
1475         Update the CSSTestSuiteHarness to not scrape the XHTML chapter files
1476         for the test order, but instead use information from testinfo.data.
1477         
1478         * CSSTestSuiteHarness/harness/harness.html:
1479         * CSSTestSuiteHarness/harness/harness.js:
1480
1481 2010-09-28  Kevin Ollivier  <kevino@theolliviers.com>
1482
1483         [wx] Build fix, don't try to get the svn revision from the git repo when packaging,
1484         it causes the process to hang on the gitorious repo.
1485
1486         * wx/packaging/build-mac-installer.py:
1487         * wx/packaging/build-win-installer.py:
1488
1489 2010-09-28  Adam Roben  <aroben@apple.com>
1490
1491         Test that a plugin's HWND is sized/positioned before NPP_SetWindow is
1492         called
1493
1494         Reviewed by Anders Carlsson.
1495
1496         Test for <http://webkit.org/b/46716> <rdar://problem/8482014>
1497         Full-page Adobe Reader does not paint until window is resized
1498
1499         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1500         (PluginTest::NPP_SetWindow): Added. Just returns NPERR_NO_ERROR at
1501         this level.
1502
1503         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Declared
1504         NPP_SetWindow.
1505
1506         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp: Added.
1507         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Checks that
1508         the plugin's HWND has a non-zero size and that its size/position
1509         matches that specified in the NPWindow.
1510
1511         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1512         (NPP_SetWindow): Call through to the PluginTest.
1513
1514         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1515         Added WindowGeometryInitializedBeforeSetWindow.cpp, and let VS reorder
1516         the files as it saw fit.
1517
1518 2010-09-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
1519
1520         Reviewed by Andreas Kling.
1521
1522         [Qt] Remove support for Qt 4.5
1523         https://bugs.webkit.org/show_bug.cgi?id=46718
1524
1525         Remove the code for versions of Qt prior to 4.6.
1526
1527         * DumpRenderTree/qt/EventSenderQt.cpp:
1528         (EventSender::addTouchPoint):
1529         (EventSender::updateTouchPoint):
1530         (EventSender::setTouchModifier):
1531         (EventSender::touchStart):
1532         (EventSender::touchMove):
1533         (EventSender::touchEnd):
1534         (EventSender::clearTouchPoints):
1535         (EventSender::releaseTouchPoint):
1536         (EventSender::sendTouchEvent):
1537         * DumpRenderTree/qt/EventSenderQt.h:
1538         * DumpRenderTree/qt/TextInputControllerQt.cpp:
1539         (TextInputController::setMarkedText):
1540         * QtTestBrowser/launcherwindow.cpp:
1541         (LauncherWindow::LauncherWindow):
1542         (LauncherWindow::initializeView):
1543         (LauncherWindow::createChrome):
1544         (LauncherWindow::sendTouchEvent):
1545         (LauncherWindow::eventFilter):
1546         (LauncherWindow::applyZoom):
1547         (LauncherWindow::setTouchMocking):
1548         * QtTestBrowser/launcherwindow.h:
1549         * QtTestBrowser/utils.cpp:
1550         (urlFromUserInput):
1551         * QtTestBrowser/webview.cpp:
1552         (WebViewGraphicsBased::animatedFlip):
1553         (WebViewGraphicsBased::animatedYFlip):
1554         * QtTestBrowser/webview.h:
1555         (WebViewGraphicsBased::setYRotation):
1556
1557 2010-09-28  İsmail Dönmez  <ismail@namtrac.org>
1558
1559         Reviewed by Andreas Kling.
1560
1561         Fix DRT compilation on WinCE. Introduce a WCECOMPAT variable
1562         which should point to wcecompat installation. Needs wcecompat
1563         library from http://github.com/mauricek/wcecompat .
1564
1565         * DumpRenderTree/qt/DumpRenderTree.pro:
1566         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1567         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1568
1569 2010-09-28  Daniel Bates  <dbates@rim.com>
1570
1571         Rollout changeset 68493 <http://trac.webkit.org/changeset/68493>
1572         <https://bugs.webkit.org/show_bug.cgi?id=39136>
1573
1574         Rollout changeset 68493 because it broke Sheriffbot's rollout feature.
1575         In particular, this change caused Sheriffbot to raise an exception when
1576         trying to parse the bug id on a bug page. We need to look into this
1577         some more.
1578
1579         * Scripts/webkitpy/common/net/bugzilla.py:
1580         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
1581         * Scripts/webkitpy/tool/bot/sheriff.py:
1582         * Scripts/webkitpy/tool/commands/download.py:
1583         * Scripts/webkitpy/tool/commands/queues.py:
1584         * Scripts/webkitpy/tool/commands/upload.py:
1585         * Scripts/webkitpy/tool/steps/closebug.py:
1586         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
1587         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1588         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
1589
1590 2010-09-28  Adam Barth  <abarth@webkit.org>
1591
1592         Reviewed by Eric Seidel.
1593
1594         Move RegressionWindow further up the dependency chain
1595         https://bugs.webkit.org/show_bug.cgi?id=46698
1596
1597         Baby steps towards pushing this information into bug posts.
1598
1599         * Scripts/webkitpy/common/net/buildbot.py:
1600         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1601         * Scripts/webkitpy/common/net/regressionwindow.py:
1602         * Scripts/webkitpy/tool/commands/queries.py:
1603
1604 2010-09-27  Daniel Bates  <dbates@rim.com>
1605
1606         Reviewed by Adam Barth.
1607
1608         sheriffbot can't roll out security patches
1609         https://bugs.webkit.org/show_bug.cgi?id=39136
1610
1611         Make SheriffBot determine if it's authorized to view a bug
1612         whose change it wants to rollout before it tries to rollout
1613         the change.
1614
1615         Moreover, make both webkit-patch and Sheriffbot provide human-
1616         readable error messages when they are not authorized to view
1617         a bug and when a bug number is invalid.
1618
1619         Currently, Sheriffbot does not parse Bugzilla bugs for
1620         <bug error="...">, which indicates an error when retrieving
1621         a bug. In particular, error="NotPermitted" if a person (or bot)
1622         is not authorized to view a bug. For such error="NotPermitted" bugs,
1623         Sheriffbot raises an exception when parsing the bug report and
1624         this exception does not explicitly indicate Sheriffbot's lack
1625         of authorization. Instead, Sheriffbot should explicitly check
1626         for the presence <bug error="..."> before operating on a bug
1627         and error with a human-readable message if it's not permitted
1628         to view it.
1629
1630         * Scripts/webkitpy/common/net/bugzilla.py: Added BugzillaError class.
1631         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
1632           - Added unit test test_bug_parsing_for_bugzilla_not_permitted_error().
1633           - Added unit test test_bug_parsing_for_bugzilla_not_found_error().
1634           - Added unit test test_bug_parsing_for_bugzilla_invalid_bug_id_error().
1635         * Scripts/webkitpy/tool/bot/sheriff.py: Modified to catch BugzillaError.
1636         * Scripts/webkitpy/tool/commands/download.py: Ditto.
1637         * Scripts/webkitpy/tool/commands/queues.py: Ditto.
1638         * Scripts/webkitpy/tool/commands/upload.py: Ditto.
1639         * Scripts/webkitpy/tool/steps/closebug.py: Ditto.
1640         * Scripts/webkitpy/tool/steps/obsoletepatches.py: Ditto.
1641         * Scripts/webkitpy/tool/steps/preparechangelog.py: Ditto.
1642         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: Ditto.
1643
1644 2010-09-27  Adam Barth  <abarth@webkit.org>
1645
1646         Reviewed by Eric Seidel.
1647
1648         Expose more more failure information from Buildbot to SheriffBot
1649         https://bugs.webkit.org/show_bug.cgi?id=46697
1650
1651         This patch moves the information about what tests failured closer to
1652         SheriffBot.  There are still a couple more patches to go before
1653         SheriffBot can post this information to bugs, but this is a step in
1654         that direction.  Yay for unit tests, which caught some bugs in earlier
1655         versions of this patch.
1656
1657         * Scripts/webkitpy/common/net/buildbot.py:
1658         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1659         * Scripts/webkitpy/common/net/regressionwindow.py: Added.
1660         * Scripts/webkitpy/tool/commands/queries.py:
1661
1662 2010-09-27  Eric Seidel  <eric@webkit.org>
1663
1664         Unreviewed.  Fixing 500 error seen in the status server.
1665
1666         It turns out that a = b = []; b.append(1); then a[0] will be 1!
1667         This should have been obvious to me, I guess, but it was not what I was expecting.
1668
1669         * QueueStatusServer/model/activeworkitems.py:
1670
1671 2010-09-27  Adam Barth  <abarth@webkit.org>
1672
1673         Reviewed by Eric Seidel.
1674
1675         commit-queue should reject patches that fail to land
1676         https://bugs.webkit.org/show_bug.cgi?id=46694
1677
1678         This can happen, for example, if there's no reviewer.  Without this
1679         patch, we'll keep retrying the patch.
1680
1681         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1682         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1683
1684 2010-09-27  Simon Fraser  <simon.fraser@apple.com>
1685
1686         Rubber-stamped by Adele Peterson.
1687
1688         Add a harness for running the CSS 2.1 test suite.
1689         
1690         This harness assumes that you've got a local a copy of the suite
1691         adjacent to the 'harness' directory.
1692         
1693         The harness lets you go through the tests in chapter order,
1694         denoting pass/fail/skipped for each test.
1695         
1696         It uses a client-side database to store the results of testing.
1697
1698         * CSSTestSuiteHarness/harness/harness.css: Added.
1699         * CSSTestSuiteHarness/harness/harness.html: Added.
1700         * CSSTestSuiteHarness/harness/harness.js: Added.
1701
1702 2010-09-27  Eric Seidel  <eric@webkit.org>
1703
1704         Reviewed by Adam Barth.
1705
1706         Patch locks should expire if a patch is marked for retry
1707         https://bugs.webkit.org/show_bug.cgi?id=46682
1708
1709         This was part Adam's original CommitQueueTask design,
1710         but support for it was missing from the server.
1711         I added the support, but triggering lock-release based on this
1712         special "retry" status feels a bit strange so I added a FIXME.
1713
1714         I also changed the text in queuestatus.html to say "Lock Acquired"
1715         since "Last Activity" isn't really true.  We only update the lock
1716         date when the patch is started, not on every status update.
1717
1718         I also noticed an exception in next-patch, which I fixed by re-writing
1719         the unzip logic in activeworkitems.py again.
1720
1721         * QueueStatusServer/handlers/updatestatus.py:
1722         * QueueStatusServer/model/activeworkitems.py:
1723         * QueueStatusServer/templates/queuestatus.html:
1724
1725 2010-09-27  Tony Chang  <tony@chromium.org>
1726
1727         Reviewed by David Levin.
1728
1729         [chromium] fix a warning when compiling DRT on 32-bit linux
1730         https://bugs.webkit.org/show_bug.cgi?id=46641
1731
1732         * DumpRenderTree/chromium/TestEventPrinter.cpp:
1733         (DRTPrinter::handleImage):
1734
1735 2010-09-27  Eric Seidel  <eric@webkit.org>
1736
1737         Reviewed by Adam Barth.
1738
1739         queue-status should report when the patch was last locked to a queue
1740         https://bugs.webkit.org/show_bug.cgi?id=46674
1741
1742         This isn't necessarily the best way to expose this information
1743         but having this accessible via the web interface is very
1744         useful until we come up with a nicer way to display this.
1745
1746         I also cleaned up the code in activeworkitems.py a little
1747         to use list comprehensions and to have the code work with
1748         pairs instead of two lists at once.  Eventually I think those
1749         item/time pairs need to be their own little helper class.
1750
1751         * QueueStatusServer/handlers/queuestatus.py:
1752         * QueueStatusServer/model/activeworkitems.py:
1753         * QueueStatusServer/templates/queuestatus.html:
1754
1755 2010-09-27  Tony Chang  <tony@chromium.org>
1756
1757         Reviewed by David Levin.
1758
1759         [chromium] fix detection of missing fonts on DRT
1760         https://bugs.webkit.org/show_bug.cgi?id=46651
1761
1762         * DumpRenderTree/chromium/TestShellGtk.cpp:
1763         (setupFontconfig):  Only print an error message if lohit isn't found in both locations.
1764
1765 2010-09-27  Tony Chang  <tony@chromium.org>
1766
1767         Reviewed by Dimitri Glazkov.
1768
1769         add webkit unit tests to the chromium testers
1770         https://bugs.webkit.org/show_bug.cgi?id=46669
1771
1772         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1773         * Scripts/run-chromium-webkit-unit-tests: Fix a bug where we weren't using the right configuration.
1774
1775 2010-09-27  Kwang Yul Seo  <skyul@company100.net>
1776
1777         Unreviewed.
1778
1779         Adding myself to the committers list.
1780
1781         * Scripts/webkitpy/common/config/committers.py:
1782
1783 2010-09-27  Mihai Parparita  <mihaip@chromium.org>
1784
1785         Reviewed by Eric Seidel.
1786
1787         webkitpy.common.system.user_unittest.UserTest.test_prompt_with_list spams the console
1788         https://bugs.webkit.org/show_bug.cgi?id=46634
1789         
1790         Use OutputCapture to prevent console spam (and also check for expected
1791         output).
1792
1793         * Scripts/webkitpy/common/system/user_unittest.py:
1794
1795 2010-09-27  Eric Seidel  <eric@webkit.org>
1796
1797         Reviewed by James Robinson.
1798
1799         start-commit-queue should abort any rebases in progress
1800         https://bugs.webkit.org/show_bug.cgi?id=46640
1801
1802         webkit-patch commit-queue would do this itself, but this just
1803         helps ensure that the commit-queue script is properly updated
1804         before we run it (in the case where a previous rebase is in
1805         progress the git svn rebase would not work before we run the
1806         commit-queue).
1807
1808         * EWSTools/start-commit-queue.sh:
1809
1810 2010-09-18  Martin Robinson  <mrobinson@igalia.com>
1811
1812         Reviewed by Gustavo Noronha Silva.
1813
1814         [GTK] Clean up the DRT fonts.conf and switch to Liberation
1815         https://bugs.webkit.org/show_bug.cgi?id=46038
1816
1817         Switch to Liberation fonts for GTK+ layout tests. This will make our
1818         test results metric-compatible with many Windows/Chromium results. It
1819         also simplifies the fonts.conf that we load and prepares the way for
1820         fixing many font bugs.
1821
1822         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1823         (initializeFonts): Initialize a known list of fonts instead of loading
1824         every font in the WEBKIT_TESTFONTS directory.
1825         * DumpRenderTree/gtk/fonts.conf: Removed.
1826         * DumpRenderTree/gtk/fonts/AHEM____.TTF: Copied from WebKitTools/DumpRenderTree/qt/fonts/AHEM____.TTF.
1827         * DumpRenderTree/gtk/fonts/fonts.conf: Added.
1828         * GNUmakefile.am: Modify FONTS_CONF_FILE to be FONTS_CONF_DIR, so that
1829         we can load both fonts.conf and AHEM____.TTF from this location.
1830         * Scripts/old-run-webkit-tests: Remove the check for WEBKIT_TESTFONTS, since
1831         it is no longer used.
1832
1833 2010-09-26  Mihai Parparita  <mihaip@chromium.org>
1834
1835         Reviewed by Ojan Vafai.
1836
1837         new-run-webkit-httpd fails if Perl is not installed
1838         https://bugs.webkit.org/show_bug.cgi?id=46602
1839         
1840         Make Port._read_configuration catch all exceptions, since trying to run
1841         perl (because of _webkit_build_directory) when it's not installed throws
1842         a WindowsError or OSError, not an IOError (this became an issue after 
1843         r68268, since ChromiumPort ends up calling Port.default_configuration in
1844         its constructor, which means that we're ending up on this codepath in
1845         non-NRWT cases too, e.g. for the Chromium NaCl tests, which use
1846         new-run-webkit-httpd).
1847
1848         * Scripts/webkitpy/layout_tests/port/base.py:
1849         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1850
1851 2010-09-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1852
1853         Reviewed by Antonio Gomes.
1854
1855         [EFL] Add setting API to set a local storage database path.
1856         https://bugs.webkit.org/show_bug.cgi?id=45446
1857
1858         Add a setting API to set local storage database path.
1859
1860         * EWebLauncher/main.c:
1861         (on_key_down):
1862         (browserCreate):
1863         (main):
1864
1865 2010-09-26  Sam Weinig  <sam@webkit.org>
1866
1867         Reviewed by Anders Carlsson.
1868
1869         Move shared WebKit2 API (used by both bundle and main API) to WebKit2/Shared/API
1870         https://bugs.webkit.org/show_bug.cgi?id=46587
1871
1872         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1873
1874 2010-09-26  Antonio Gomes  <agomes@rim.com>
1875
1876         Reviewed by Kenneth Rohde Christiansen.
1877
1878         DRT/Mac nodesFromRect support
1879
1880         [Mac][DRT] Implement LayoutTestController::nodesFromRect
1881         https://bugs.webkit.org/show_bug.cgi?id=46580
1882
1883         Implements LayoutTestController::nodesFromRect for Mac DRT, and
1884         adding stubs for GTK+ and Windows.
1885
1886         * DumpRenderTree/LayoutTestController.cpp:
1887         (nodesFromRectCallback):
1888         (LayoutTestController::staticFunctions):
1889         * DumpRenderTree/LayoutTestController.h:
1890         (LayoutTestController::LayoutTestController::nodesFromRect):
1891         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1892         (LayoutTestController::nodesFromRect):
1893
1894 2010-09-25  Nicolas Weber  <thakis@chromium.org>
1895
1896         Reviewed by Adam Barth.
1897
1898         https://bugs.webkit.org/show_bug.cgi?id=46555
1899         Fix typo in prepare-ChangeLog's help output.
1900
1901         * Scripts/prepare-ChangeLog:
1902
1903 2010-09-24  Sam Weinig  <sam@webkit.org>
1904
1905         Reviewed by Darin Adler.
1906
1907         Implement WebKit2 callback equivalent to -[WebUIDelegate mouseDidMoveOverElement:modifierFlags:]
1908         <rdar://problem/8359279>
1909         https://bugs.webkit.org/show_bug.cgi?id=46546
1910
1911         * MiniBrowser/mac/BrowserWindowController.m:
1912         (mouseDidMoveOverElement):
1913         (-[BrowserWindowController awakeFromNib]):
1914         * MiniBrowser/win/BrowserView.cpp:
1915         (mouseDidMoveOverElement):
1916         (BrowserView::create):
1917         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1918         (WTR::InjectedBundlePage::InjectedBundlePage):
1919         * WebKitTestRunner/TestController.cpp:
1920         (WTR::createOtherPage):
1921         (WTR::TestController::initialize):
1922
1923 2010-09-24  Mihai Parparita  <mihaip@chromium.org>
1924
1925         Reviewed by Adam Barth.
1926
1927         Allow rebaselines for webkit-patch rebaseline to be chosen
1928         https://bugs.webkit.org/show_bug.cgi?id=46407
1929         
1930         Instead of always rebaselining all failing tests, allow a subset to be
1931         chosen.
1932
1933         * Scripts/webkitpy/common/system/user.py:
1934         * Scripts/webkitpy/tool/commands/rebaseline.py:
1935
1936 2010-09-24  Ryosuke Niwa  <rniwa@webkit.org>
1937
1938         Reviewed by Tony Chang.
1939
1940         [chromium] Implement TextInputController::firstRectForCharacterRange
1941         https://bugs.webkit.org/show_bug.cgi?id=38100
1942
1943         Implemented TextInputController::firstRectForCharacterRange for chromium platform.
1944         No new tests are added since we need to implement the same feature in chromium side
1945         in order to enable any tests that uses this function.
1946
1947         * DumpRenderTree/chromium/TextInputController.cpp:
1948         (TextInputController::firstRectForCharacterRange): Added.
1949
1950 2010-09-24  Adam Barth  <abarth@webkit.org>
1951
1952         Reviewed by Eric Seidel.
1953
1954         commit-queue reports land failures as "PASS"
1955         https://bugs.webkit.org/show_bug.cgi?id=46530
1956
1957         We were ignoring the return value of land instead of passing it back to
1958         CommitQueue.  Of course, this was the one case I forgot to test!
1959
1960         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1961         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1962
1963 2010-09-24  Kenichi Ishibashi  <bashi@google.com>
1964
1965         Reviewed by Eric Seidel.
1966
1967         new-run-webkit-tests prints out nothing when build-dumprendertree fails
1968         https://bugs.webkit.org/show_bug.cgi?id=37563
1969
1970         Print error message when build-dumprendertree fails.
1971
1972         * Scripts/webkitpy/layout_tests/port/webkit.py:
1973         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1974
1975 2010-09-24  Mihai Parparita  <mihaip@chromium.org>
1976
1977         Reviewed by Tony Chang.
1978
1979         NRWT doesn't respect config set with set-webkit-configuration
1980         https://bugs.webkit.org/show_bug.cgi?id=46278
1981         
1982         Use Port.default_configuration() instead of hardcoding Release in
1983         ChromiumPort configuration initialization, so that we still inherit the
1984         configuration set by set-webkit-configuration.
1985
1986         * Scripts/webkitpy/layout_tests/port/chromium.py:
1987         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1988
1989 2010-09-24  Chang Shu  <chang.shu@nokia.com>
1990
1991         Reviewed by Csaba Osztrogonác.
1992
1993         [Qt] Fix the code to check file existence.
1994         https://bugs.webkit.org/show_bug.cgi?id=46465
1995
1996         * QtTestBrowser/main.cpp:
1997         (main):
1998
1999 2010-09-23  Tony Chang  <tony@chromium.org>
2000
2001         Unreviewed, rolling out r68232.
2002         http://trac.webkit.org/changeset/68232
2003
2004         Broken NRWT on the canary bots.
2005
2006         * Scripts/webkitpy/layout_tests/port/chromium.py:
2007
2008 2010-09-23  Dirk Pranke  <dpranke@chromium.org>
2009
2010         Unreviewed, build fix.
2011
2012         r68008 broke new-run-webkit-tests in that the chromium ports no
2013         longer respect set-webkit-configuration. The correct fix for this
2014         is being pursued in bug 46278 (along with a bunch of unit tests),
2015         but in the meantime I'm reverting the particular lines that broke
2016         things. This was tested by hand.
2017
2018         * Scripts/webkitpy/layout_tests/port/chromium.py:
2019
2020 2010-09-23  Sam Weinig  <sam@webkit.org>
2021
2022         Reviewed by Anders Carlsson.
2023
2024         WebKit2 API: Need way to know when a frame is removed from the hierarchy
2025         <rdar://problem/8414062>
2026         https://bugs.webkit.org/show_bug.cgi?id=46432
2027
2028         * MiniBrowser/mac/BrowserWindowController.m:
2029         (didRemoveFrameFromHierarchy):
2030         (-[BrowserWindowController awakeFromNib]):
2031         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2032         (WTR::InjectedBundlePage::InjectedBundlePage):
2033         * WebKitTestRunner/TestController.cpp:
2034         (WTR::TestController::initialize):
2035
2036 2010-09-23  Tony Chang  <tony@chromium.org>
2037
2038         Reviewed by Dimitri Glazkov.
2039
2040         [chromium] implement layoutTestController.sampleSVGAnimationForElementAtTime
2041         https://bugs.webkit.org/show_bug.cgi?id=46426
2042
2043         * DumpRenderTree/chromium/LayoutTestController.cpp:
2044         (LayoutTestController::LayoutTestController):
2045         (LayoutTestController::sampleSVGAnimationForElementAtTime):
2046         * DumpRenderTree/chromium/LayoutTestController.h:
2047
2048 2010-09-23  Martin Robinson  <mrobinson@igalia.com>
2049
2050         Reviewed by Nate Chapin.
2051
2052         [GTK] r68199 introduced two test failures
2053         https://bugs.webkit.org/show_bug.cgi?id=46424
2054
2055         Fix a regression handling preference overrides that are attached to boolean properties.
2056
2057         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2058         (LayoutTestController::overridePreference): g_strcasecmp returns 0 when strings match
2059         so we must check for that when converting a string to a boolean.
2060
2061 2010-09-23  Dimitri Glazkov  <dglazkov@chromium.org>
2062
2063         Reviewed by David Levin.
2064
2065         Fix a condition check in ServerProcess, which becomes relevant when reading binary data.
2066         https://bugs.webkit.org/show_bug.cgi?id=46406
2067
2068         This breaks when the method is called with specified size of data (image data), and the
2069         buffer hasn't yet reached this size.
2070
2071         * Scripts/webkitpy/layout_tests/port/server_process.py: Changed to check for values of
2072           index larger than 0.
2073
2074 2010-09-23  Martin Robinson  <mrobinson@igalia.com>
2075
2076         Reviewed by Nate Chapin.
2077
2078         [GTK] Some tests from r68174 fail on the GTK+ bots
2079         https://bugs.webkit.org/show_bug.cgi?id=46396
2080
2081         Simplify LayoutTestController::overridePreference to make it easier for
2082         people unfamiliar with the code to keep the list of preferences up to date.
2083         Add the conversion for enable-hyperlink-auditing.
2084
2085         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2086         (LayoutTestController::overridePreference): Use a simple if-else block to determine
2087         out the property name for overrridePreference. Also simplify the logic for setting
2088         string properties. Add the conversion for enable-hyperlink-auditing.
2089
2090 2010-09-23  Tony Chang  <tony@chromium.org>
2091
2092         Reviewed by David Levin.
2093
2094         [chromium] add caretBrowsingEnabled to WebSettings and DRT
2095         https://bugs.webkit.org/show_bug.cgi?id=46388
2096
2097         * DumpRenderTree/chromium/LayoutTestController.cpp:
2098         (LayoutTestController::overridePreference):
2099         * DumpRenderTree/chromium/WebPreferences.cpp:
2100         (WebPreferences::reset):
2101         (WebPreferences::applyTo):
2102         * DumpRenderTree/chromium/WebPreferences.h:
2103
2104 2010-09-23  Nate Chapin  <japhet@chromium.org>
2105
2106         Reviewed by Darin Fisher.
2107
2108         Allow DRT to toggle hyperlink auditing (i.e., <a ping>).
2109         https://bugs.webkit.org/show_bug.cgi?id=30458
2110
2111         * DumpRenderTree/chromium/LayoutTestController.cpp:
2112         (LayoutTestController::overridePreference):
2113         * DumpRenderTree/chromium/WebPreferences.cpp:
2114         (WebPreferences::reset):
2115         (WebPreferences::applyTo):
2116         * DumpRenderTree/chromium/WebPreferences.h:
2117         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2118         (resetDefaultsToConsistentValues):
2119         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2120         (LayoutTestController::overridePreference):
2121
2122 2010-09-21  Stephen White  <senorblanco@chromium.org>
2123
2124         Reviewed by David Levin.
2125
2126         Implement --enable-accelerated-2d-canvas flag in DumpRenderTree.
2127         https://bugs.webkit.org/show_bug.cgi?id=46208
2128
2129         This flag allows the layout tests to be run with or without accelerated
2130         2D canvas rendering.
2131
2132         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2133         (main):
2134         Declare the new flag string, and check for it on startup.
2135         * DumpRenderTree/chromium/TestShell.cpp:
2136         (TestShell::TestShell):
2137         Add a boolean for the new flag, in order to preserve its value over
2138         preferences reset.
2139         (TestShell::resetWebSettings):
2140         Set the new flag to the stored value on reset.
2141         * DumpRenderTree/chromium/TestShell.h:
2142         (TestShell::setAccelerated2dCanvasEnabled):
2143         Add an accessor for the new flag.
2144         * DumpRenderTree/chromium/WebPreferences.cpp:
2145         (WebPreferences::reset):
2146         Initialize the new flag to false.
2147         (WebPreferences::applyTo):
2148         Copy the flag's value to the WebSettings.
2149         * DumpRenderTree/chromium/WebPreferences.h:
2150         Add the new flag.
2151
2152 2010-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2153
2154         Reviewed by Simon Hausmann.
2155
2156         [Qt] Refactor QtWebKitPlatformPlugin interface
2157
2158         Make it easier to keep source-compability for the
2159         QtWebKitPlatformPlugin interface, and run qmake
2160         on the example (but not build) for convenience. 
2161
2162         https://bugs.webkit.org/show_bug.cgi?id=46345
2163
2164         * Scripts/webkitdirs.pm:
2165
2166 2010-09-23  Adam Barth  <abarth@webkit.org>
2167
2168         Reviewed by Eric Seidel.
2169
2170         Tweak some status messages that Eric thought were confusing
2171         https://bugs.webkit.org/show_bug.cgi?id=46342
2172
2173         * Scripts/webkitpy/tool/commands/queues.py:
2174         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2175
2176 2010-09-22  Adam Barth  <abarth@webkit.org>
2177
2178         Reviewed by Eric Seidel.
2179
2180         Fix comm-queue typo
2181         https://bugs.webkit.org/show_bug.cgi?id=46339
2182
2183         We were missing a "self".  The real problem is that we didn't have an
2184         integration test for the failure case.
2185
2186         * Scripts/webkitpy/tool/commands/queues.py:
2187         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2188
2189 2010-09-22  Adam Barth  <abarth@webkit.org>
2190
2191         Reviewed by Eric Seidel.
2192
2193         commit-queue should log more detailed messages to the QueueStatusServer
2194         https://bugs.webkit.org/show_bug.cgi?id=46333
2195
2196         When I created CommitQueueTask, I removed most of the previous logging.
2197         This patch adds back more detailed logging so folks can see their patch
2198         progress through the queue.
2199
2200         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2201         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2202         * Scripts/webkitpy/tool/commands/queues.py:
2203         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2204
2205 2010-09-22  Mihai Parparita  <mihaip@chromium.org>
2206
2207         Reviewed by Darin Fisher.
2208
2209         [Chromium] User style layout tests don't pass on Chromium
2210         https://bugs.webkit.org/show_bug.cgi?id=46069
2211
2212         Fix a typo in LayoutTestController::addUserStyleSheet that was causing a
2213         crash the Chromium DRT. Pass InjectInExistingDocuments to mimic DRT
2214         behavior from other ports.
2215
2216         * DumpRenderTree/chromium/LayoutTestController.cpp:
2217         (LayoutTestController::addUserStyleSheet):
2218
2219 2010-09-22  Brent Fulgham  <bfulgham@webkit.org>
2220
2221         Reviewed by Martin Robinson.
2222
2223         [WinCairo] Part 2: Update WebKitTestRunner and DumpRenderTree Build.
2224         https://bugs.webkit.org/show_bug.cgi?id=46303.
2225
2226         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added.
2227         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Moved
2228         CoreFoundation-specific stuff to new MiniBrowserCoreFoundation
2229         property sheet.
2230         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added.
2231         * MiniBrowser/MiniBrowser.vcproj: Updated configuration to use
2232         appropriate property sheet for the build types.
2233         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Updated the
2234         configuration to use appropriate property sheet for CoreFoundation
2235         and CFLite-style builds.
2236
2237 2010-09-22  Adam Barth  <abarth@webkit.org>
2238
2239         Reviewed by Eric Seidel.
2240
2241         Optimize commit-queue performance for green trees
2242         https://bugs.webkit.org/show_bug.cgi?id=46254
2243
2244         This patch redesigns the controller logic for the commit-queue.  In the
2245         new design, the controller exercises much finer-grained control over
2246         the landing process.  In particular:
2247
2248         - Patches that fail to apply now get rejected almost immediately.
2249         - Patches that fail to build get rejects after two builds (instead of
2250           three builds and one test run).
2251         - Patches that run into a flaky test now get accepted after one build
2252           and two test runs instead of three full build-and-test runs.
2253
2254         The main cost of these optimizations is that we don't find out the tree
2255         has a failing test until the very end of the process, but if the tree
2256         has a busted test, there's not much we can do anyway.  We might as well
2257         burn commit-queue resources spinning optimisticly.
2258
2259         * Scripts/webkitpy/tool/bot/commitqueuetask.py: Added.
2260         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: Added.
2261         * Scripts/webkitpy/tool/commands/queues.py:
2262
2263 2010-09-22  Brent Fulgham  <bfulgham@webkit.org>
2264
2265         Reviewed by Martin Robinson.
2266
2267         [WinCairo] Update WebKitTestRunner and DumpRenderTree Build.
2268         https://bugs.webkit.org/show_bug.cgi?id=46303.
2269
2270         * DumpRenderTree/win/DumpRenderTree.vcproj: Disable local MD5 sources
2271         for Cairo build. Copy wtf MD5 header to ForwardingHeaders for the
2272         WinCairo build.
2273         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added.
2274         * WebKitTestRunner/win/InjectedBundle.vcproj: Update win new *_Cairo
2275         build targets that use the new InjectedBundleCFLite.vsprops file.
2276
2277 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
2278
2279         Unreviewed, build fix.
2280
2281         Fix bustage of rebaseline-chromium-webkit-tests resulting from
2282         r67974. Really need better unit tests for this tool :(
2283
2284         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2285
2286 2010-09-22  Adam Roben  <aroben@apple.com>
2287
2288         Unbreak test-webkitpy
2289
2290         * Scripts/webkitpy/test/main.py:
2291         (Tester.run_tests): Add a line that mysteriously got deleted.
2292
2293 2010-09-22  Adam Roben  <aroben@apple.com>
2294
2295         Make test-webkitpy test WebKit2's scripts
2296
2297         These scripts can't be in WebKitTools due to limitations of Apple's
2298         build process. But that doesn't mean we can't test them!
2299
2300         Fixes <http://webkit.org/b/46297> test-webkitpy should test code in
2301         WebKit2/Scripts
2302
2303         Reviewed by Adam Barth.
2304
2305         * Scripts/test-webkitpy:
2306         (_clean_packages_with_test): Renamed from _clean_webkitpy_with_test.
2307         Now takes an external_package_paths parameter and cleans both webkitpy
2308         and any external packages.
2309         (init): Added an external_package_paths parameter which we pass along
2310         to _clean_packages_with_test.
2311         (top level): Add WebKit2/Scripts/webkit2 as our only external package
2312         and pass it along to init and Tester.run_tests.
2313
2314         * Scripts/webkitpy/test/main.py:
2315         (Tester.run_tests): Added an optional external_package_paths
2316         parameter. We modify sys.path so that the external packages can be
2317         imported, and search for unittest files inside all external packages
2318         in addition to inside webkitpy.
2319
2320 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
2321
2322         Reviewed by Tony Chang.
2323
2324         new-run-webkit-tests: r68063 broke linux python tests
2325
2326         Add a missing "from __future__ import with_statement" to this
2327         new file; the perils of testing only on the Mac and by review :(
2328
2329         https://bugs.webkit.org/show_bug.cgi?id=46293
2330
2331         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2332
2333 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
2334
2335         Reviewed by Tony Chang.
2336
2337         Add a 'chromium-gpu' set of ports that will test the accelerated
2338         GPU paths. This patch adds:
2339
2340         - support for the '--accelerated-compositing' and
2341           'accelerated-2d-canvas' flags to new-run-webkit-tests (and the
2342           'no-' flags)
2343         - adds a new set of Ports that will look under
2344           platform/chromium-gpu-$OS/ for baselines before looking in the
2345           regular chromium search path
2346         - adds a new test_expectations.txt file in platform/chromium-gpu
2347           that skips all but the tests we actually want to run with
2348           acceleration.
2349
2350         This patch will allow us to run both with and without acceleration
2351         and to change the defaults for both the regular and -gpu options
2352         as the code evolves.
2353
2354         We plan to add both --chromium-$OS and --chromium-gpu-$OS runs to
2355         each test bot.
2356
2357         https://bugs.webkit.org/show_bug.cgi?id=46225
2358
2359         * Scripts/webkitpy/layout_tests/port/chromium.py:
2360         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2361         * Scripts/webkitpy/layout_tests/port/factory.py:
2362         * Scripts/webkitpy/layout_tests/port/webkit.py:
2363
2364 2010-09-22  Jamey Hicks  <jamey.hicks@nokia.com>
2365
2366         Reviewed by Kenneth Rohde Christiansen.
2367
2368         [Qt] Web Inspector: Remote Web Inspector support for QtWebKit
2369         https://bugs.webkit.org/show_bug.cgi?id=43988
2370
2371         Runs a web debug server on port specified by QtTestBrowser
2372         argument -remote-inspector-port. Property
2373         _q_webInspectorServerPort of the QWebPage instance will be set
2374         according to the argument. All pages with that property set will
2375         be remotely inspectable.
2376
2377         URL for remote inspection of first QWebPage is
2378             http://localhost:9222/webkit/inspector/inspector.html?page=1
2379         where 1 is the number of the QWebPage instance.
2380
2381         The base URL yields an index page with links to the individual inspectors:
2382             http://localhost:9222/
2383
2384         * QtTestBrowser/launcherwindow.cpp:
2385         (LauncherWindow::init):
2386         * QtTestBrowser/launcherwindow.h:
2387         * QtTestBrowser/main.cpp:
2388         (LauncherApplication::handleUserOptions):
2389
2390 2010-09-22  Adam Roben  <aroben@apple.com>
2391
2392         Fix webkit-patch failure-reason now that build.webkit.org has been
2393         updated
2394
2395         Fixes <http://webkit.org/b/46273> webkit-patch failure-reason crashes
2396         every time
2397
2398         Reviewed by Eric Seidel.
2399
2400         * Scripts/webkitpy/common/net/buildbot.py:
2401         (BuildBot._file_cell_text): Added. Travels down the firstChild chain
2402         looking for an element that contains text, then returns it.
2403         (BuildBot._parse_twisted_file_row): Use _file_cell_text to get the
2404         text out of the cells. This way it doesn't matter whether the cells
2405         have <b> children (as for cells in directory rows) or not (as for
2406         cells in file rows)
2407         (BuildBot._parse_twisted_directory_listing): Look for rows that have
2408         the "directory" or "file" class, rather than rows with any class,
2409         since header rows now have a class attribute.
2410
2411         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2412         (BuildBotTest._example_directory_listing): Updated to more closely
2413         match the markup that build.webkit.org is producing now.
2414
2415 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2416
2417         Unreviewed, build fix.
2418
2419         new-run-webkit-tests: fix bug introduced in r68008 where if you
2420         specify --chromium and no --platform, and you're running on
2421         windows, you use the 'chromium-win' port by default instead of the
2422         version-specific port. This breaks the buildbots.
2423
2424         It will be good for this refactoring to settle down so I can
2425         rewrite the logic for default ports and the unit tests to be
2426         clearer (and the testing more comprehensive).
2427
2428         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2429
2430 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2431
2432         Reviewed by Adam Barth.
2433
2434         Modify the Port interface to take only a series of keyword arguments
2435         in the constructor, and modify Port/factory.get() to accomodate that,
2436         and to accept user=XXX as an argument so we can pass
2437         webkitpy.common.system.user.User objects in.
2438
2439         Then, modify new-run-webkit-tests and rebaseline-chromium-webkit-tests
2440         to use the common routine in webkitpy.common.system.user.open_url()
2441         to display HTML files.
2442
2443         There was a routine in the Port interface to do the same thing,
2444         but I see no need for a port-specific hook for this, since it is
2445         something that will always be executed by the host environment
2446         and displaying web pages has nothing to do with running layout tests.
2447
2448         Note that new-run-webkit-tests used to use test_shell to display
2449         the page; this is potentially useful so that you can actually click
2450         from a result to the broken page; however, since DumpRenderTree
2451         doesn't support this functionality, it will be going away eventually.
2452
2453         https://bugs.webkit.org/show_bug.cgi?id=46128
2454
2455         * Scripts/webkitpy/layout_tests/port/base.py:
2456         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2457         * Scripts/webkitpy/layout_tests/port/chromium.py:
2458         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2459         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2460         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2461         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2462         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2463         * Scripts/webkitpy/layout_tests/port/factory.py:
2464         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2465         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2466         * Scripts/webkitpy/layout_tests/port/gtk.py:
2467         * Scripts/webkitpy/layout_tests/port/mac.py:
2468         * Scripts/webkitpy/layout_tests/port/qt.py:
2469         * Scripts/webkitpy/layout_tests/port/test.py:
2470         * Scripts/webkitpy/layout_tests/port/webkit.py:
2471         * Scripts/webkitpy/layout_tests/port/win.py:
2472         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2473         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2474         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2475
2476 2010-09-21  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2477
2478         Reviewed by Kenneth Rohde Christiansen.
2479
2480         [EFL] Get fresh theme when running EWebLauncher
2481         https://bugs.webkit.org/show_bug.cgi?id=46210
2482
2483         If user tried to run EWebLauncher outside of the build tree, it would
2484         not find the theme and fallback to the installed one. However, since
2485         EWebLauncher is not installed, we always want to take the theme from
2486         the just compiled source code. If user had never installed WebKit's
2487         EFL port it could even receive a segv since no theme would be found.
2488
2489         Now EWebLauncher does not fallback to the installed theme and CMake
2490         gives as DATA_DIR the directory of the theme it has just built.
2491
2492         * CMakeListsEfl.txt: Pass the build directory as DATA_DIR to
2493         EWebLauncher.
2494         * EWebLauncher/main.c: Use only the theme from build director. Do not
2495         fallback to others as this could hide real bugs.
2496         (quit):
2497         (browserCreate):
2498         (findThemePath):
2499         (main):
2500
2501 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2502
2503         Unreviewed, build fix.
2504
2505         Don't pass the --test-shell arg to the Chromium Mac port of DRT;
2506         it just confuses it.
2507
2508         https://bugs.webkit.org/show_bug.cgi?id=46230
2509
2510         * Scripts/webkitpy/layout_tests/port/webkit.py:
2511
2512 2010-09-21  Lucas Forschler  <lforschler@apple.com>
2513
2514         Reviewed by Stephanie Lewis.
2515
2516         Make a new buildbot for Leopard Debug Test
2517
2518         * BuildSlaveSupport/build.webkit.org-config/config.json:
2519
2520 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2521
2522         Unreviewed, build fix.
2523
2524         Fix breakage of Chromium Mac DRT port caused by r67905.
2525
2526         https://bugs.webkit.org/show_bug.cgi?id=46230
2527
2528         * Scripts/webkitpy/layout_tests/port/webkit.py:
2529
2530 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2531
2532         Unreviewed, build fix.
2533
2534         Add missing import of 'tempfile'.
2535
2536         * Scripts/webkitpy/layout_tests/port/chromium.py:
2537
2538 2010-09-17  Dirk Pranke  <dpranke@chromium.org>
2539
2540         Reviewed by Ojan Vafai.
2541
2542         new-run-webkit-tests: pull the list of tests from the Port, and
2543            make it possible to run with no actual test files in the filesystem.
2544
2545         This set of changes allows us to delete the special
2546         webkitpy/layout_tests/data directory and test the generic code without
2547         touching the filesystem (except to write results). This speeds up
2548         test-webkitpy substantially.
2549
2550         This also cleans up and removes several code paths in the generic
2551         code and fixes some minor bugs, notably in the test_expectations
2552         parsing, which was previously fragile if the tests weren't present.
2553
2554         We also change the way we diff image results to be able to do so
2555         in memory, without relying on files. This slows down chromium
2556         test_shell, which always writes images to files, but should speed
2557         up DRT and ImageDiff-based implementations slightly.
2558
2559         Note that pulling the list of tests to run from the Port will allow
2560         ports to specify what tests to run as an inclusive list; previously
2561         you could only do this as an exclusive list by using a 
2562         test_expectations file or Skipped files; nothing actually uses this
2563         feature yet and it's unclear if it should be used.
2564
2565         Note that there are no functional changes -- apart from now 
2566         always printing out the location of the checksum file when we are
2567         tracing test runs -- and the total number of lines of non-test code
2568         actually drops by two.
2569
2570         There is some more cleanup that can be done in the Port/Driver 
2571         interface and in some handling of filenames, but I'll save that
2572         for another change.
2573
2574         https://bugs.webkit.org/show_bug.cgi?id=45801
2575
2576         * Scripts/webkitpy/layout_tests/data/*: Removed.
2577             - no longer need special mock layout_tests_directory in the
2578               repository.
2579         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2580             - add code to display missing text files, checksums when tracing
2581             - update to not look at the filesystem directly.
2582         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2583             - add more unit tests
2584         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2585             - remove tests_are_present flag
2586             - update with changes in Port interface - no longer access
2587               the filesystem directly, although we still use os.path for
2588               filename manipulation.
2589         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2590             - add more unit tests
2591         * Scripts/webkitpy/layout_tests/layout_package/test_files.py: Removed.
2592             - renamed to port/test_files.py
2593         * Scripts/webkitpy/layout_tests/port/base.py:
2594             - change diff_image() to expect actual image data, not filenames
2595             - add expected_checksum(), expected_image(), expected_text() to
2596               return the content of the files so that we don't need a filesystem
2597             - add path_exists(), path_isdir() for filesystem-like access.
2598             - add test_dirs() to keep clobber-test-results from needing to
2599               actually look at a real layout tests dir
2600             - add tests() to return the list of tests to run on the port
2601               (calls port/test_files to do the work).
2602             - add update_baseline() to be able to save new baselines
2603             - add uri_to_test_name() from port/dryrun.py so we can easily check
2604               filename_to_uri()
2605         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2606             - add more unit tests
2607         * Scripts/webkitpy/layout_tests/port/chromium.py:
2608             - change diff_image() to accept image content, not filenames.
2609               This will be slower for test_shell/image_diff, but faster
2610               for DRT/ImageDiff.
2611         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2612             - add more unit tests
2613         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2614             - simplify greatly
2615         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2616             - add more unit tests
2617         * Scripts/webkitpy/layout_tests/port/test.py:
2618             - massive rewrite to use in-script list of tests and expectations
2619         * Scripts/webkitpy/layout_tests/port/test_files.py:
2620             - rename from layout_package/test_files.
2621         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2622             - add unit tests
2623         * Scripts/webkitpy/layout_tests/port/webkit.py:
2624             - update diff_image() to take image contents, not files. Should
2625               make things slightly faster.
2626         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2627             - update with changes to diff_image()
2628         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2629             - update with changes to diff_image()
2630         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2631             - remove tests_are_present from test_expectations
2632             - pull the list of tests from port.tests() instead
2633               of calling test_files.py directly.
2634         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2635             - update unit tests
2636         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2637             - update with changes to 
2638         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2639             - update with change in Port interface
2640         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2641             - update with change in Port interface
2642         * Scripts/webkitpy/style/checkers/test_expectations.py:
2643             - remove the tests_are_present flag
2644
2645 2010-09-21  Anders Carlsson  <andersca@apple.com>
2646
2647         Disable logging.
2648
2649         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2650
2651 2010-09-21  Tony Chang  <tony@chromium.org>
2652
2653         Reviewed by Kent Tamura.
2654
2655         add a script for running webkit_unit_tests
2656         https://bugs.webkit.org/show_bug.cgi?id=46014
2657
2658         * Scripts/run-chromium-webkit-unit-tests: Added.
2659
2660 2010-09-21  Fridrich Strba  <fridrich.strba@bluewin.ch>
2661
2662         Reviewed by Martin Robinson.
2663
2664         Fix linking problems on Windows.
2665         https://bugs.webkit.org/show_bug.cgi?id=45844
2666
2667         * GNUmakefile.am: link the executables with winmm.dll
2668
2669 2010-09-21  Adam Barth  <abarth@webkit.org>
2670
2671         Reviewed by Eric Seidel.
2672
2673         feeder-queue svn updates more often than needed
2674         https://bugs.webkit.org/show_bug.cgi?id=46171
2675
2676         We don't need to poll SVN every time we feed the feeders.  Rather, we
2677         can count on the wrapper shell script to auto-update the queue.
2678
2679         * Scripts/webkitpy/tool/commands/queues.py:
2680         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2681
2682 2010-09-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2683
2684         Reviewed by Andreas Kling.
2685
2686         [Qt] Add robot loader timeout and extra time options.
2687         https://bugs.webkit.org/show_bug.cgi?id=46172
2688
2689         [-robot-timeout <s>]: Load the next page after s seconds if the current
2690         page didn't finish loading.
2691         [-robot-extra-time <s>]: Wait s seconds after the current page finished
2692         loading before loading the next one. This should allow some time for the
2693         page's JavaScript to execute.
2694
2695         * QtTestBrowser/launcherwindow.cpp:
2696         (LauncherWindow::applyPrefs):
2697         * QtTestBrowser/main.cpp:
2698         (LauncherApplication::robotTimeout):
2699         (LauncherApplication::robotExtraTime):
2700         (LauncherApplication::LauncherApplication):
2701         (LauncherApplication::handleUserOptions):
2702         (main):
2703         * QtTestBrowser/urlloader.cpp:
2704         (UrlLoader::UrlLoader):
2705         (UrlLoader::loadNext):
2706         (UrlLoader::loadUrlList):
2707         * QtTestBrowser/urlloader.h:
2708
2709 2010-09-21  Pavel Podivilov  <podivilov@chromium.org>
2710
2711         Unreviewed.
2712
2713         Adding myself to the committers list.
2714
2715         * Scripts/webkitpy/common/config/committers.py:
2716
2717 2010-09-20  Philippe Normand  <pnormand@igalia.com>
2718
2719         Reviewed by Eric Carlson.
2720
2721         [GTK] enhanced context menu for media elements
2722         https://bugs.webkit.org/show_bug.cgi?id=45021
2723
2724         EventSender::contextClick() now returns an array of js
2725         objects. Each object has a title property and a click() method.
2726
2727         * DumpRenderTree/gtk/EventSender.cpp:
2728         (getMenuItemTitleCallback):
2729         (setMenuItemTitleCallback):
2730         (menuItemClickCallback):
2731         (getMenuItemClass):
2732         (contextClickCallback):
2733
2734 2010-09-20  Hayato Ito  <hayato@chromium.org>
2735
2736         Unreviewed.
2737         Adding myself to the committers list.
2738
2739         * Scripts/webkitpy/common/config/committers.py:
2740
2741 2010-09-20  Adam Barth  <abarth@webkit.org>
2742
2743         Reviewed by Eric Seidel.
2744
2745         The tool member variable should be called _tool
2746         https://bugs.webkit.org/show_bug.cgi?id=46160
2747
2748         Created by find-and-replace.
2749
2750         * Scripts/webkitpy/tool/commands/download.py:
2751         * Scripts/webkitpy/tool/commands/openbugs.py:
2752         * Scripts/webkitpy/tool/commands/queries.py:
2753         * Scripts/webkitpy/tool/commands/queues.py:
2754         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2755         * Scripts/webkitpy/tool/commands/rebaseline.py:
2756         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2757         * Scripts/webkitpy/tool/commands/upload.py:
2758         * Scripts/webkitpy/tool/multicommandtool.py:
2759
2760 2010-09-20  Adam Barth  <abarth@webkit.org>
2761
2762         I ran the tests before landing but ignored the fact that they failed.  :(
2763
2764         * Scripts/webkitpy/tool/commands/queues.py:
2765
2766 2010-09-20  Adam Barth  <abarth@webkit.org>
2767
2768         Reviewed by Eric Seidel.
2769
2770         Add a feeder queue that polls bugs.webkit.org for the commit-cluster
2771         https://bugs.webkit.org/show_bug.cgi?id=46141
2772
2773         The feeder-queue polls bugs.webkit.org every 30 seconds and updates the
2774         list of work items on the status server.  The individual commit-cluster
2775         nodes then grab the patches from the server and process them.
2776
2777         * Scripts/webkitpy/tool/bot/feeders.py: Added.
2778         * Scripts/webkitpy/tool/bot/feeders_unittest.py: Added.
2779         * Scripts/webkitpy/tool/commands/queues.py:
2780         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2781         * Scripts/webkitpy/tool/commands/queuestest.py:
2782
2783 2010-09-20  Leandro Pereira  <leandro@profusion.mobi>
2784
2785         Reviewed by Darin Adler.
2786
2787         build-webkit: Add support for CMake build system
2788         https://bugs.webkit.org/show_bug.cgi?id=44979
2789
2790         * Scripts/build-webkit: Add "--efl" command-line option to build the
2791         EFL port of WebKit.
2792         * Scripts/webkitdirs.pm: Define buildCMakeProject() and
2793         buildEflCMakeProject() subroutines.
2794
2795 2010-09-20  Dirk Pranke  <dpranke@chromium.org>
2796
2797         Reviewed by Ojan Vafai.
2798
2799         new-run-webkit-tests: refactor command line args getting passed to DRT
2800
2801         This change cleans up some argument parsing between functions to get
2802         rid of some overlapping data structures. There should be no functional
2803         changes in this patch; it is pure refactoring in preparation for
2804         landing the Chrome GPU port and adding a generic way to pass
2805         args to DRT/TestShell.
2806
2807         https://bugs.webkit.org/show_bug.cgi?id=46135
2808
2809         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2810           - pass the options argument explicitly to the threads and drivers,
2811             also consolidate the passing of options to the driver.
2812           - pass options directly to process_output() to remove a couple
2813             parameters (minor cleanup).
2814         * Scripts/webkitpy/layout_tests/port/base.py:
2815           - pass the options argument to Port.create_driver().
2816         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2817           - update Port.create_driver() test
2818         * Scripts/webkitpy/layout_tests/port/chromium.py:
2819           - pass the options argument to Port.create_driver(), and clean up
2820             building of the cmd line for DRT.
2821         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2822           - pass the options argument to Port.create_driver()
2823         * Scripts/webkitpy/layout_tests/port/test.py:
2824           - pass the options argument to Port.create_driver()
2825         * Scripts/webkitpy/layout_tests/port/webkit.py:
2826           - pass the options argument to Port.create_driver(), and clean up
2827             building of the cmd line for DRT.
2828         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2829           - consolidate args in _get_dump_render_tree_args and rename to
2830             _get_test_args(); move all of the command-line args to the
2831             Port implementations.
2832
2833 2010-09-20  Andrew Wilson  <atwilson@chromium.org>
2834
2835         Revert change which was accidentally committed along with some expectation changes.
2836
2837         * Scripts/webkitpy/layout_tests/port/base.py:
2838
2839 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
2840
2841         Reviewed by Adam Barth.
2842
2843         Add explicit --force-patch flag to webkitpy tools
2844         https://bugs.webkit.org/show_bug.cgi?id=46103
2845         
2846         It wasn't obvious until I read the applypatch.py source code that
2847         --non-interfactive implies passing --force to patch. Add --force-patch
2848         as an alias to the flag, so that this behavior is more discoverable.
2849
2850         * Scripts/webkitpy/tool/steps/applypatch.py:
2851         * Scripts/webkitpy/tool/steps/options.py:
2852
2853 2010-09-20  Eric Seidel  <eric@webkit.org>
2854
2855         Unreviewed, adding a line which got dropped and is trivially correct (and tested).
2856
2857         commit-queue can't land patches
2858         https://bugs.webkit.org/show_bug.cgi?id=46138
2859
2860         Add a line of code I forgot in my last commit.
2861
2862         * Scripts/webkitpy/common/net/bugzilla.py:
2863         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
2864
2865 2010-09-20  Adam Barth  <abarth@webkit.org>
2866
2867         Reviewed by Eric Seidel.
2868
2869         The commit-cluster bots still race to lock patch_ids
2870         https://bugs.webkit.org/show_bug.cgi?id=46130
2871
2872         It turns out we need to use a transaction object to make the
2873         read/modify/write lock operation atomic.  From reading the AppEngine
2874         documentation, I think this patch should do what we want.  It's hard to
2875         test locally because the test instance isn't distributed in the same
2876         way the production instance is.
2877
2878         * QueueStatusServer/handlers/nextpatch.py:
2879         * QueueStatusServer/model/activeworkitems.py: Added.
2880
2881 2010-09-20  Andy Estes  <aestes@apple.com>
2882
2883         Reviewed by Adam Barth.
2884
2885         REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
2886         https://bugs.webkit.org/show_bug.cgi?id=40961
2887
2888         Implement WebKitUsePreHTML5ParserQuirks preference.
2889
2890         * DumpRenderTree/mac/DumpRenderTree.mm:
2891         (resetDefaultsToConsistentValues): Reset WebKitUsePreHTML5ParserQuirks
2892         to false after a test finishes.
2893
2894 2010-09-20  Adam Roben  <aroben@apple.com>
2895
2896         Windows build fix
2897
2898         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Put
2899         $(WebKitOutputDir)\include before $(WebKitLibrariesDir)\include so
2900         we'll pick up the most recent versions of the headers.
2901
2902 2010-09-20  Eric Seidel  <eric@webkit.org>
2903
2904         Reviewed by Adam Barth.
2905
2906         commit-queue should check commit-queue+ again just before committing
2907         https://bugs.webkit.org/show_bug.cgi?id=32679
2908
2909         Added a _revalidate_patch check, right before landing.
2910
2911         Since _revalidate_patch passes the patch_id from the work item
2912         back to bugzilla, I had to fix all of the previous queue tests to
2913         use valid attachment ids (that's the majority of this change).
2914
2915         In order to validate that the bug was still open, I had to teach
2916         bugzilla.Bug about open/closed states.
2917
2918         * Scripts/webkitpy/common/net/bugzilla.py:
2919         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2920         * Scripts/webkitpy/tool/commands/queues.py:
2921         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2922         * Scripts/webkitpy/tool/commands/queuestest.py:
2923         * Scripts/webkitpy/tool/mocktool.py:
2924
2925 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
2926
2927         Unreviewed.
2928
2929         Adding myself as a comitter.
2930
2931         * Scripts/webkitpy/common/config/committers.py:
2932
2933 2010-09-20  Adam Barth  <abarth@webkit.org>
2934
2935         Reviewed by Eric Seidel.
2936
2937         Two instances of commit-queue try to process the same patch
2938         https://bugs.webkit.org/show_bug.cgi?id=46113
2939
2940         This patch makes next-patch atomic so that the server won't vend the
2941         same patch twice in the same hour.
2942
2943         * QueueStatusServer/handlers/nextpatch.py:
2944
2945 2010-09-20  Adam Roben  <aroben@apple.com>
2946
2947         Make WebKitTestRunner's wait-to-dump watchdog timer work on Windows
2948
2949         We were previously trying to use a CFRunLoopTimer, but since Windows
2950         doesn't use CFRunLoop on most threads this doesn't work. Now we use a
2951         Windows-style timer on Windows.
2952
2953         I also replaced all uses of "watchdog" with "watchdog timer".
2954
2955         Fixes <http://webkit.org/b/46101> WebKitTestRunner's wait-to-dump
2956         watchdog timer doesn't work on Windows
2957
2958         Reviewed by Anders Carlsson.
2959
2960         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2961         (WTR::InjectedBundlePage::dump): Updated for rename.
2962
2963         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Removed
2964         platform-specific functions.
2965         (WTR::LayoutTestController::LayoutTestController): Added call to
2966         platformInitialize.
2967         (WTR::LayoutTestController::waitUntilDone): Changed to call
2968         initializeWaitToDumpWatchdogTimerIfNeeded instead of doing the work
2969         right in this function.
2970         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Updated for
2971         rename.
2972
2973         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added new
2974         members needed to support the watchdog timer abstraction. Replaced
2975         some "watchdog"s with "watchdog timer".
2976
2977         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
2978         Added.
2979         (WTR::LayoutTestController::platformInitialize): Does nothing on this
2980         platform.
2981         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Moved here
2982         from LayoutTestController.cpp and changed to use an early return.
2983         (WTR::waitUntilDoneWatchdogTimerFired): Moved here from
2984         LayoutTestController.cpp.
2985         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
2986         Moved code here from LayoutTestController::waitUntilDone and changed
2987         to use an early return.
2988
2989         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
2990         Added.
2991         (WTR::LayoutTestController::platformInitialize): Initialize our
2992         watchdog timer.
2993         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Added.
2994         Kills and clears the watchdog timer.
2995         (WTR::waitToDumpWatchdogTimerFired): Added. Calls through to the
2996         LayoutTestController member function of the same name.
2997         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
2998         Added. Sets up the timer if it isn't already set.
2999
3000         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added
3001         LayoutTestControllerMac.mm.
3002
3003         * WebKitTestRunner/win/InjectedBundle.vcproj: Added
3004         LayoutTestControllerWin.cpp.
3005
3006 2010-09-20  Martin Robinson  <mrobinson@igalia.com>
3007
3008         Reviewed by Daniel Bates.
3009
3010         [GTK] fast/forms/listbox-selection.html fails
3011         https://bugs.webkit.org/show_bug.cgi?id=45942
3012
3013         Use the gdkModifersFromJSValue helper to parse all appropriate modifier
3014         strings in keyDownCallback.
3015
3016         * DumpRenderTree/gtk/EventSender.cpp:
3017         (keyDownCallback): Use the gdkModifersFromJSValue instead of duplicating the 
3018         modifier parsing logic.
3019
3020 2010-09-19  Sam Weinig  <sam@webkit.org>
3021
3022         Reviewed by Anders Carlsson.
3023
3024         WebKit2 decidePolicyForNavigationAction should include mouse button information
3025         <rdar://problem/8413165>
3026         https://bugs.webkit.org/show_bug.cgi?id=46060
3027
3028         * MiniBrowser/mac/BrowserWindowController.m:
3029         (decidePolicyForNavigationAction):
3030         (decidePolicyForNewWindowAction):
3031
3032 2010-09-19  Daniel Bates  <dbates@rim.com>
3033
3034         Reviewed by Martin Robinson.
3035
3036         Add unit tests for diffs that delete or modify a change log entry
3037         or describe changes that are far apart
3038         https://bugs.webkit.org/show_bug.cgi?id=46046
3039
3040         Add additional unit tests to test change log diffs that contain
3041         deletions or changes that are far apart from each other in the
3042         ChangeLog file.
3043
3044         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
3045           - Added the following unit tests:
3046           "fixChangeLogPatch: [no change] In-place change."
3047           "fixChangeLogPatch: [no change] Remove first entry."
3048           "fixChangeLogPatch: [no change] Remove entry in the middle."
3049           "fixChangeLogPatch: [no change] Far apart changes (i.e. more than one chunk)."
3050
3051 2010-09-19  Sam Weinig  <sam@webkit.org>
3052
3053         Reviewed by Anders Carlsson.
3054
3055         Replace WKBundleRangeRef with WKBundleRangeHandleRef.
3056         https://bugs.webkit.org/show_bug.cgi?id=46054
3057
3058         The new one acts like WKBundleNodeHandleRef and allows for getting a
3059         wrapper in a specific world for the handle.
3060
3061         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3062         (WTR::propertyValue):
3063         (WTR::propertyValueDouble):
3064         (WTR::propertyValueInt):
3065         (WTR::numericWindowPropertyValue):
3066         (WTR::toStr):
3067         (WTR::InjectedBundlePage::shouldBeginEditing):
3068         (WTR::InjectedBundlePage::shouldEndEditing):
3069         (WTR::InjectedBundlePage::shouldInsertNode):
3070         (WTR::InjectedBundlePage::shouldInsertText):
3071         (WTR::InjectedBundlePage::shouldDeleteRange):
3072         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
3073         (WTR::InjectedBundlePage::shouldApplyStyle):
3074         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3075
3076 2010-09-19  Kent Tamura  <tkent@chromium.org>
3077
3078         Unreviewed. Fix WebGL test regressions by r67809.
3079
3080         * DumpRenderTree/chromium/WebPreferences.cpp:
3081         (WebPreferences::applyTo): Call setExperimentalWebGLEnabled().
3082
3083 2010-09-19  Kent Tamura  <tkent@chromium.org>
3084
3085         Reviewed by Adam Barth.
3086
3087         [DRT/Chromium] Fix a WebSettings handling bug
3088         https://bugs.webkit.org/show_bug.cgi?id=45945
3089
3090         Before this change, Chromium DRT reset WebSettings for every new
3091         window. It was wrong.
3092         If new window is not the first one, we have to apply the same
3093         settings as the first window.  So, we introduce WebPreference to
3094         store the current settings, and apply it to new windows. It's same
3095         as test_shell's behavior.
3096
3097         * DumpRenderTree/DumpRenderTree.gypi:
3098         * DumpRenderTree/chromium/LayoutTestController.cpp:
3099           Use WebPreferences instead of WebSettings.
3100         (LayoutTestController::setUserStyleSheetEnabled):
3101         (LayoutTestController::setUserStyleSheetLocation):
3102         (LayoutTestController::setAuthorAndUserStylesEnabled):
3103         (LayoutTestController::setPopupBlockingEnabled):
3104         (LayoutTestController::disableImageLoading):
3105         (LayoutTestController::setJavaScriptCanAccessClipboard):
3106         (LayoutTestController::setXSSAuditorEnabled):
3107         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
3108         (LayoutTestController::setAllowFileAccessFromFileURLs):
3109         (LayoutTestController::overridePreference):
3110         (LayoutTestController::setEditingBehavior):
3111         * DumpRenderTree/chromium/TestShell.cpp:
3112         (TestShell::resetWebSettings): Use WebPreferences.
3113         (TestShell::runFileTest): ditto.
3114         (TestShell::createNewWindow): Apply existing WebPreferences to a new WebView.
3115         * DumpRenderTree/chromium/TestShell.h:
3116         (TestShell::preferences):
3117         (TestShell::applyPreferences):
3118         * DumpRenderTree/chromium/WebPreferences.cpp: Added.
3119         * DumpRenderTree/chromium/WebPreferences.h: Added.
3120
3121 2010-09-18  Prasad Tammana  <prasadt@chromium.org>
3122
3123         Reviewed by David Levin.
3124
3125         update-webkit --chromium spitting out a spurious error
3126         https://bugs.webkit.org/show_bug.cgi?id=45868
3127
3128         * Scripts/update-webkit-chromium: Use commandExists() function to check for existence of gclient.
3129
3130 2010-09-18  Sam Weinig  <sam@webkit.org>
3131
3132         Reviewed by Dan Bernstein.
3133
3134         Improve/unify the PageLoadClient interfaces
3135         https://bugs.webkit.org/show_bug.cgi?id=46043
3136
3137         * MiniBrowser/mac/BrowserWindowController.m:
3138         (didStartProvisionalLoadForFrame):
3139         (didReceiveServerRedirectForProvisionalLoadForFrame):
3140         (didFailProvisionalLoadWithErrorForFrame):
3141         (didCommitLoadForFrame):
3142         (didFinishDocumentLoadForFrame):
3143         (didFinishLoadForFrame):
3144         (didFailLoadWithErrorForFrame):
3145         (didReceiveTitleForFrame):
3146         (didFirstLayoutForFrame):
3147         (didFirstVisuallyNonEmptyLayoutForFrame):
3148         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3149         (WTR::InjectedBundlePage::InjectedBundlePage):
3150         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
3151         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
3152         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
3153         (WTR::InjectedBundlePage::didCommitLoadForFrame):
3154         (WTR::InjectedBundlePage::didFinishLoadForFrame):
3155         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
3156         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
3157         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
3158         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3159         * WebKitTestRunner/TestController.cpp:
3160         (WTR::TestController::didReceiveMessageFromInjectedBundle):
3161         (WTR::TestController::didFinishLoadForFrame):
3162         * WebKitTestRunner/TestController.h:
3163
3164 2010-09-17  Eric Seidel  <eric@webkit.org>
3165
3166         Unreviewed.  Adding a shell script I use to run the
3167         commit-queue. Now that multiple machines run the cq,
3168         it makes sense to share the script between them.
3169
3170         * EWSTools/start-commit-queue.sh: Added.
3171
3172 2010-09-17  Brian Weinstein  <bweinstein@apple.com>
3173
3174         Reviewed by Jon Honeycutt.
3175
3176         The colors on the new build.webkit.org (after upgrading the master to 0.8.1) are
3177         slightly harder to read, so this reverts the previous background colors for various
3178         states, making it easier to read.
3179
3180         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
3181         (.success):
3182         (.failure):
3183         (.warnings):
3184         (.exception):
3185         (.start,.running,td.building):
3186         (.offline,td.offline):
3187
3188 2010-09-17  Sheriff Bot  <webkit.review.bot@gmail.com>
3189
3190         Unreviewed, rolling out r67692.
3191         http://trac.webkit.org/changeset/67692
3192         https://bugs.webkit.org/show_bug.cgi?id=46011
3193
3194         broke layout test dashboard (Requested by johnny_g on
3195         #webkit).
3196
3197         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3198         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3199         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3200
3201 2010-09-17  Martin Robinson  <mrobinson@igalia.com>
3202
3203         Reviewed by Oliver Hunt.
3204
3205         Style bot complains about cairo forward declaration naming
3206         https://bugs.webkit.org/show_bug.cgi?id=45867
3207
3208         Exclude Cairo forward declarations from indentifiers with underscores checks.
3209
3210         * Scripts/webkitpy/style/checkers/cpp.py: Add exclusion for Cairo forward-declarations.
3211         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
3212
3213 2010-09-16  Kinuko Yasuda  <kinuko@chromium.org>
3214
3215         Reviewed by Ojan Vafai.
3216
3217         Include detailed test modifiers (e.g. FLAKY) in results.json for failing non-layout tests
3218         https://bugs.webkit.org/show_bug.cgi?id=45408
3219
3220         This change also tries to remove duplicated upload_results_json methods
3221         in run_webkit_tests.py and json_results_generator.py.
3222
3223         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3224         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3225         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3226
3227 2010-09-16  Antonio Gomes  <tonikitoo@webkit.org>
3228
3229         Reviewed by Andreas Kling.
3230
3231         [Qt] When switching views (WebViewGraphicsBased <--> WebViewTraditional), QWebPage signals and QActions have to be re-set.
3232
3233         Recently r67554 changed the way different views use the WebPage class: it was previously being shared between
3234         different views, but now for each view switch, a new WebPage class is constructed and set. Signals and QAction's
3235         were not being set to the new WebPage though. Patch fix that, by re constructing the toolbar, and then re-hooking
3236         all page specific stuff to the UI.
3237
3238         * QtTestBrowser/launcherwindow.cpp:
3239         (LauncherWindow::initializeView):
3240         * QtTestBrowser/mainwindow.cpp:
3241         (MainWindow::MainWindow):
3242         (MainWindow::buildUI):
3243         (MainWindow::setPage):
3244         * QtTestBrowser/mainwindow.h:
3245
3246 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3247
3248         Reviewed by Andreas Kling.
3249
3250         Make all accesses to m_item (GraphicsWebView) done by WebViewGraphicsBased class happen though graphicsWebView getter method.
3251
3252         This patch is mostly a preparation for another commit, where the ownership of the m_item/GraphicsWebView
3253         object will move to the qgraphicsscene instead of the qgraphicsview.
3254
3255         * QtTestBrowser/webview.cpp:
3256         (WebViewGraphicsBased::setPage):
3257         (WebViewGraphicsBased::setResizesToContents):
3258         (WebViewGraphicsBased::resizeEvent):
3259         (WebViewGraphicsBased::animatedFlip):
3260         * QtTestBrowser/webview.h:
3261         (WebViewGraphicsBased::setItemCacheMode):
3262         (WebViewGraphicsBased::itemCacheMode):
3263
3264 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3265
3266         Reviewed by Andreas Kling.
3267
3268         Moved setYRotation method body out of the class (WebViewGraphicsBased) definition.
3269
3270         We usually separate methods whose body are larger than a few lines from the class definition.
3271
3272         * QtTestBrowser/webview.h:
3273         (WebViewGraphicsBased::yRotation):
3274         (WebViewGraphicsBased::setYRotation):
3275
3276 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3277
3278         Reviewed by Andreas Kling.
3279
3280         Make initializeView method of LauncherWindow private.
3281
3282         No one else needs to be able to call it but LauncherWindow.
3283         Also moving the declation of isGraphicsBased method down in the same file, in order
3284         to better group related methods.
3285
3286         * QtTestBrowser/launcherwindow.h:
3287
3288 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3289
3290         Reviewed by Andreas Kling.
3291
3292         Make the getter 'page' method of MainWindow const.
3293
3294         * QtTestBrowser/mainwindow.cpp:
3295         (MainWindow::page):
3296         * QtTestBrowser/mainwindow.h:
3297
3298 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3299
3300         Reviewed by Andreas Kling.
3301
3302         Remove useless parameter from MainWindow class' constructor.
3303
3304         The parameter defaults to an empty URL and is not being used by any caller. Apart from that it is also
3305         not referred in the constructor body and does not make much sense.
3306
3307         * QtTestBrowser/mainwindow.cpp:
3308         (MainWindow::MainWindow):
3309         * QtTestBrowser/mainwindow.h:
3310
3311 2010-09-15  Tony Chang  <tony@chromium.org>
3312
3313         Reviewed by Kent Tamura.
3314
3315         [Chromium] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
3316         https://bugs.webkit.org/show_bug.cgi?id=42151
3317
3318         * DumpRenderTree/chromium/LayoutTestController.cpp:
3319         (LayoutTestController::LayoutTestController):
3320         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
3321         (WorkItemLoadHTMLString::run):
3322         (LayoutTestController::queueLoadHTMLString):
3323         (LayoutTestController::reset):
3324         (LayoutTestController::setDeferMainResourceDataLoad):
3325         * DumpRenderTree/chromium/LayoutTestController.h:
3326         (LayoutTestController::deferMainResourceDataLoad):
3327         * DumpRenderTree/chromium/WebViewHost.cpp:
3328         (WebViewHost::didCreateDataSource):
3329
3330 2010-09-16  Adrienne Walker  <enne@google.com>
3331
3332         Reviewed by Kenneth Russell.
3333
3334         Add script to synchronize WebKit and Khronos WebGL tests
3335         https://bugs.webkit.org/show_bug.cgi?id=42336
3336
3337         * Scripts/update-webgl-conformance-tests: Added.
3338         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py: Added.
3339         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py: Added.
3340
3341 2010-09-16  Sam Weinig  <sam@webkit.org>
3342
3343         Reviewed by Anders Carlsson.
3344
3345         Add support for sending synchronous messages from the InjectedBundle to the WKContext
3346         <rdar://problem/8365320>
3347         https://bugs.webkit.org/show_bug.cgi?id=44785
3348
3349         * MiniBrowser/mac/AppDelegate.m:
3350         (didReceiveSynchronousMessageFromInjectedBundle):
3351         (-[BrowserAppDelegate init]):
3352         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3353         (didCreatePage):
3354         * WebKitTestRunner/TestController.cpp:
3355         (WTR::TestController::initialize):
3356
3357 2010-09-16  Leonid Ebril  <leonid.ebril@nokia.com>
3358
3359         Reviewed by Andreas Kling.
3360
3361         [Qt] QtTestBrowser: Disable creation of a new window for screenshot on Symbian platform.
3362         https://bugs.webkit.org/show_bug.cgi?id=45885
3363
3364         Avoid creation of an additional window for screenshot to prevent overlapping with original window.
3365
3366         * QtTestBrowser/launcherwindow.cpp:
3367         (LauncherWindow::screenshot):
3368
3369 2010-09-16  Anders Carlsson  <andersca@apple.com>
3370
3371         Fix clang++ build.
3372
3373         * MiniBrowser/mac/BrowserWindowController.m:
3374         (-[BrowserWindowController zoomIn:]):
3375         (-[BrowserWindowController zoomOut:]):
3376         (-[BrowserWindowController resetZoom:]):
3377         Remove trailing semicolons.
3378
3379 2010-09-16  Sheriff Bot  <webkit.review.bot@gmail.com>
3380
3381         Unreviewed, rolling out r67628.
3382         http://trac.webkit.org/changeset/67628
3383         https://bugs.webkit.org/show_bug.cgi?id=45904
3384
3385         broke the build (Requested by eric_carlson on #webkit).
3386
3387         * DumpRenderTree/gtk/EventSender.cpp:
3388         (contextClickCallback):
3389
3390 2010-09-16  Balazs Kelemen  <kbalazs@webkit.org>
3391
3392         Unreviewed.
3393
3394         Adding myself as a comitter.
3395
3396         * Scripts/webkitpy/common/config/committers.py:
3397
3398 2010-09-15  Philippe Normand  <pnormand@igalia.com>
3399
3400         Reviewed by Eric Carlson.
3401
3402         [GTK] enhanced context menu for media elements
3403         https://bugs.webkit.org/show_bug.cgi?id=45021
3404
3405         EventSender::contextClick() now returns an array of js
3406         objects. Each object has a title property and a click() method.
3407
3408         * DumpRenderTree/gtk/EventSender.cpp:
3409         (getMenuItemTitleCallback):
3410         (setMenuItemTitleCallback):
3411         (menuItemClickCallback):
3412         (getMenuItemClass):
3413         (contextClickCallback):
3414
3415 2010-09-14  Philippe Normand  <pnormand@igalia.com>
3416
3417         Reviewed by Eric Carlson and Martin Robinson.
3418
3419         [GTK] eventSender.contextClick() should return the contents of the context menu
3420         https://bugs.webkit.org/show_bug.cgi?id=39102
3421
3422         Make the eventSender use the new private WebKitGtk+ API to
3423         retrieve the context-menu item titles and store them in an array.
3424
3425         * DumpRenderTree/gtk/EventSender.cpp:
3426         (contextClickCallback):
3427
3428 2010-09-16  Eric Uhrhane  <ericu@chromium.org>
3429
3430         Reviewed by Jian Li.
3431
3432         Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
3433         https://bugs.webkit.org/show_bug.cgi?id=45798
3434
3435         * Scripts/build-webkit:
3436
3437 2010-09-16  Robert Hogan  <robert@webkit.org>
3438
3439         Reviewed by Antonio Gomes.
3440
3441         [Qt] Support globalhistory tests
3442         https://bugs.webkit.org/show_bug.cgi?id=45774
3443
3444         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3445         (WebCore::isGlobalHistoryTest):
3446         (WebCore::DumpRenderTree::open):
3447         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3448         (LayoutTestController::reset):
3449         (LayoutTestController::dumpHistoryCallbacks):
3450         (LayoutTestController::removeAllVisitedLinks):
3451         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3452
3453 2010-09-10  Tony Chang  <tony@chromium.org>
3454
3455         Reviewed by Eric Seidel.
3456
3457         deduplicate-tests should be runnable from any WebKit directory
3458         https://bugs.webkit.org/show_bug.cgi?id=44709
3459
3460         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
3461         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3462
3463 2010-09-15  Tony Chang  <tony@chromium.org>
3464
3465         Reviewed by Kent Tamura.
3466
3467         [chromium] sort testing methods in DRT
3468         https://bugs.webkit.org/show_bug.cgi?id=45850
3469
3470         * DumpRenderTree/chromium/EventSender.cpp:
3471         (EventSender::EventSender):
3472         * DumpRenderTree/chromium/LayoutTestController.cpp:
3473         (LayoutTestController::LayoutTestController):
3474         * DumpRenderTree/chromium/TextInputController.cpp:
3475         (TextInputController::TextInputController):
3476
3477 2010-09-15  Mihai Parparita  <mihaip@chromium.org>
3478
3479         Reviewed by Adam Barth.
3480
3481         CQ status shows items out of order
3482         https://bugs.webkit.org/show_bug.cgi?id=45846
3483         
3484         Only group consecutive status items with the same patch ID into the same
3485         group, so that overall item ordering is preserved.
3486         
3487         Also don't indent status items that only have a single item in their
3488         group.
3489
3490         * QueueStatusServer/handlers/queuestatus.py:
3491         * QueueStatusServer/templates/includes/singlequeuestatus.html: Added.
3492         * QueueStatusServer/templates/queuestatus.html:
3493
3494 2010-09-15  Eric Seidel  <eric@webkit.org>
3495
3496         Reviewed by Adam Barth.
3497
3498         Add queue start/stop messages
3499         https://bugs.webkit.org/show_bug.cgi?id=45853
3500
3501         I ended up needing to clean up a bunch of our unit testing
3502         in order to test this new code path nicely.
3503
3504         There are also a few PEP8 changes needed to pass check-webkit-style.
3505
3506         * Scripts/webkitpy/tool/bot/queueengine.py:
3507         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
3508         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3509         * Scripts/webkitpy/tool/commands/queues.py:
3510         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3511         * Scripts/webkitpy/tool/commands/queuestest.py:
3512         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
3513
3514 2010-09-15  Simon Fraser  <simon.fraser@apple.com>
3515
3516         https://bugs.webkit.org/show_bug.cgi?id=45849
3517         WKURLCreateWithCFURL crashes with null url
3518         
3519         Fix MiniBrowser crash when the url is not parseable.
3520
3521         * MiniBrowser/mac/BrowserWindowController.m:
3522         (-[BrowserWindowController fetch:]):
3523
3524 2010-09-15  Patrick Gansterer  <paroga@paroga.com>
3525
3526         Unreviewed.
3527
3528         Adding myself to the committers list.
3529
3530         * Scripts/webkitpy/common/config/committers.py:
3531
3532 2010-09-14  Eric Seidel  <eric@webkit.org>
3533
3534         Reviewed by Adam Barth.
3535
3536         Make it possible to run more than one commit-queue instance
3537         https://bugs.webkit.org/show_bug.cgi?id=45786
3538
3539         Mostly we need to make sure the two (or more) instances get
3540         different patches to work on.  To do this, I re-worked
3541         the code responsible for getting the next work item to
3542         round trip through the status server.  The status server only
3543         vends patches from the work items list, only if those patches
3544         have not had status reported for them in the last hour.
3545
3546         This is another step towards making all queues go through the
3547         status server, thus making it possible to run more than one
3548         instance of various EWS bots (as requested in bug 44292).
3549
3550         The webkitpy changes are already covered by existing unit tests.
3551         The QueueStatusSever sadly has no testing infrastructure yet. :(
3552
3553         * QueueStatusServer/handlers/nextpatch.py: Added.
3554         * QueueStatusServer/index.yaml:
3555         * QueueStatusServer/main.py:
3556         * Scripts/webkitpy/tool/commands/queues.py:
3557
3558 2010-09-15  Mihai Parparita  <mihaip@chromium.org>
3559
3560         Reviewed by Tony Chang.
3561
3562         NRWT fails with UnicodeDecodeError on editing/selection/mixed-editability-10.html
3563         https://bugs.webkit.org/show_bug.cgi?id=45791
3564
3565         Force filenames to be raw bytes before running difflib.unified_diff.
3566
3567         * Scripts/webkitpy/layout_tests/port/base.py:
3568         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3569
3570 2010-09-15  Simon Hausmann  <simon.hausmann@nokia.com>
3571
3572         Reviewed by Tor Arne Vestbø.
3573
3574         [Qt] QtTestBrowser crashes when enabling QGraphicsView mode after first loading page without it enabled
3575         https://bugs.webkit.org/show_bug.cgi?id=35247
3576
3577         The main issue when changing the views is that the plugins and any other components that
3578         depend on view specific attributes such as the native window id are not teared down.
3579         Even if we had a tear-down procedure, we'd have to re-initialize the plugin after
3580         switching to the new view (QGraphicsWebView). This is a rather uncommon situation, so
3581         we decided to work around this in QtTestBrowser by making toggling between QWebView
3582         and QGraphicsWebView also re-create the page.
3583
3584         * QtTestBrowser/launcherwindow.cpp:
3585         (LauncherWindow::initializeView):
3586         * QtTestBrowser/mainwindow.h:
3587
3588 201