2010-06-28 Xan Lopez <xlopez@igalia.com>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-06-28  Xan Lopez  <xlopez@igalia.com>
2
3         Reviewed by Gustavo Noronha.
4
5         [GTK] Add support for GTK+3
6         https://bugs.webkit.org/show_bug.cgi?id=41253
7
8         Adapt build system for 3.x support.
9
10         * GNUmakefile.am:
11
12 2010-06-10  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
13
14         Reviewed by Simon Hausmann.
15
16         [QT][S60] build-webkit scripts picks wrong make spec for windows build
17         https://bugs.webkit.org/show_bug.cgi?id=41198
18
19         Instead of checking for existence of %EPOCROOT% on windows, mandatory use of --symbian flag for symbian builds. 
20
21         * Scripts/webkitdirs.pm:
22         (determineIsSymbian): remove check for %EPOCROOT% as one can build for windows port of QT as well
23
24 2010-06-28  Eric Seidel  <eric@webkit.org>
25
26         Reviewed by Adam Barth.
27
28         Make it possible to test the new HTML5 TreeBuilder
29         https://bugs.webkit.org/show_bug.cgi?id=41276
30
31         Adam was concerned that someone might make their port
32         depend on this setting (I guess we had some trouble with that
33         with the HTML5Parser setting), so I littered the code with warnings.
34
35         test-html5-parser now tests this code path.
36
37         * DumpRenderTree/mac/DumpRenderTree.mm:
38         (resetDefaultsToConsistentValues):
39         (initializeGlobalsFromCommandLineOptions):
40         * Scripts/test-html5-parser:
41
42 2010-06-27  MORITA Hajime  <morrita@google.com>
43
44         Unreviewed. 
45         
46         Some never-called @staticmethods touched self. 
47         Fixed it to replace these self with a class.
48
49         * Scripts/webkitpy/common/checkout/scm.py:
50
51 2010-06-27  MORITA Hajime  <morrita@google.com>
52
53         Unreviewed.
54         
55         Fixed exception raising syntax that is pointed out at
56         https://bugs.webkit.org/show_bug.cgi?id=41153
57
58         * Scripts/webkitpy/common/checkout/scm.py:
59         * Scripts/webkitpy/common/checkout/scm_unittest.py: 
60           Removed a bad line that I accidentally checked-in at last revision.
61
62 2010-06-24  MORITA Hajime  <morrita@google.com>
63
64         Reviewed by Eric Seidel.
65
66         rebaseline-chromium-webkit-tests should add or remove files to local git repository
67         https://bugs.webkit.org/show_bug.cgi?id=41153
68
69         - Added SCM.add() and SCM.remove()
70         - Replaced "svn add" and "svn remove"
71           rebaseline_chromium_webkit_tests.py: in with SCM method equivalents.
72         - add "-U" and "-q" options to rebaseline_chromium_webkit_tests.py
73           for debugging purpose.
74
75         * Scripts/webkitpy/common/checkout/scm.py:
76         * Scripts/webkitpy/common/checkout/scm_unittest.py:
77         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
78
79 2010-06-25  Yuzo Fujishima  <yuzo@google.com>
80
81         Reviewed by Shinichiro Hamaji.
82
83         Improve default value handling for page format properties.
84         https://bugs.webkit.org/show_bug.cgi?id=41150
85
86         * DumpRenderTree/LayoutTestController.cpp:
87         (parsePageNumber):
88         (parsePageNumberSizeMarings):
89         (pageSizeAndMarginsInPixelsCallback):
90         (LayoutTestController::staticFunctions):
91         * DumpRenderTree/LayoutTestController.h:
92         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
93         (LayoutTestController::pageSizeAndMarginsInPixels):
94         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
95         (LayoutTestController::pageSizeAndMarginsInPixels):
96         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
97         (LayoutTestController::pageSizeAndMarginsInPixels):
98
99 2010-06-21  Robert Hogan  <robert@webkit.org>
100
101         Reviewed by Kenneth Rohde Christiansen.
102
103         [Qt] DRT Support for setCustomPolicyDelegate
104
105         https://bugs.webkit.org/show_bug.cgi?id=39564
106
107         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
108         (LayoutTestController::setCustomPolicyDelegate):
109         * DumpRenderTree/qt/LayoutTestControllerQt.h:
110
111 2010-06-26  Robert Hogan  <robert@webkit.org>
112
113         Unreviewed, Qt build fix following http://trac.webkit.org/changeset/61879
114         
115         Remove qwebscriptworld.h from LayoutTestControllerQt.cpp - it is no longer
116         exported.
117
118         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
119
120 2010-06-26  Tony Gentilcore  <tonyg@chromium.org>
121
122         Reviewed by Dimitri Glazkov.
123
124         Add a build-webkit option for enabling Web Timing support.
125         https://bugs.webkit.org/show_bug.cgi?id=38924
126
127         * Scripts/build-webkit:
128
129 2010-06-25  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
130
131         Reviewed by Kenneth Rohde Christiansen.
132
133         [Qt] QtTestBrowser does not have a "Load" button ; therefore, unable to load pages on touch only symbian devices (portrait mode).
134         https://bugs.webkit.org/show_bug.cgi?id=38597
135
136         Make the reload button act as a load button as well.
137
138         * QtTestBrowser/mainwindow.cpp:
139         (MainWindow::buildUI):
140         (MainWindow::changeLocation):
141
142 2010-06-25  Prasad Tammana  <prasadt@chromium.org>
143
144         Reviewed by Dmitry Titov.
145
146         Add empty abortModal() method to all platforms.
147         https://bugs.webkit.org/show_bug.cgi?id=40864
148
149         Add an empty abortModal() stub to LayoutTestController on all platforms to get rid of platform specific #ifs in
150         platform independent LayoutTestController code.  Without this change, layout tests using LayoutTestController tests
151         that use abortModal will become mac specific which is not desirable.
152
153         * DumpRenderTree/LayoutTestController.cpp:
154         (abortModalCallback):
155         (LayoutTestController::staticFunctions):
156         * DumpRenderTree/LayoutTestController.h:
157         * DumpRenderTree/chromium/LayoutTestController.cpp:
158         (LayoutTestController::LayoutTestController):
159         (LayoutTestController::abortModal):
160         * DumpRenderTree/chromium/LayoutTestController.h:
161         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
162         (LayoutTestController::abortModal):
163         * DumpRenderTree/qt/LayoutTestControllerQt.h:
164         (LayoutTestController::abortModal):
165         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
166         (LayoutTestController::abortModal):
167         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
168         (LayoutTestController::abortModal):
169
170 2010-06-25  Sam Weinig  <sam@webkit.org>
171
172         Reviewed by Anders Carlsson.
173
174         Patch for https://bugs.webkit.org/show_bug.cgi?id=41226
175         Flesh out injected bundle code for WebKitTestRunner and add basic LayoutTestController.
176
177         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Added.
178         (WTR::InjectedBundle::shared):
179         (WTR::InjectedBundle::InjectedBundle):
180         (WTR::InjectedBundle::_didCreatePage):
181         (WTR::InjectedBundle::_willDestroyPage):
182         (WTR::InjectedBundle::_didRecieveMessage):
183         (WTR::InjectedBundle::initialize):
184         (WTR::InjectedBundle::didCreatePage):
185         (WTR::InjectedBundle::willDestroyPage):
186         (WTR::InjectedBundle::didRecieveMessage):
187         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Added.
188         (WTR::InjectedBundle::layoutTestController):
189         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
190         (WKBundleInitialize):
191         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Added.
192         (WTR::InjectedBundlePage::InjectedBundlePage):
193         (WTR::InjectedBundlePage::~InjectedBundlePage):
194         (WTR::InjectedBundlePage::_didStartProvisionalLoadForFrame):
195         (WTR::InjectedBundlePage::_didReceiveServerRedirectForProvisionalLoadForFrame):
196         (WTR::InjectedBundlePage::_didFailProvisionalLoadWithErrorForFrame):
197         (WTR::InjectedBundlePage::_didCommitLoadForFrame):
198         (WTR::InjectedBundlePage::_didFinishLoadForFrame):
199         (WTR::InjectedBundlePage::_didFailLoadWithErrorForFrame):
200         (WTR::InjectedBundlePage::_didReceiveTitleForFrame):
201         (WTR::InjectedBundlePage::_didClearWindowForFrame):
202         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
203         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
204         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
205         (WTR::InjectedBundlePage::didCommitLoadForFrame):
206         (WTR::InjectedBundlePage::didFinishLoadForFrame):
207         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
208         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
209         (WTR::InjectedBundlePage::didClearWindowForFrame):
210         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added.
211         (WTR::InjectedBundlePage::page):
212         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Added.
213         (WTR::LayoutTestController::create):
214         (WTR::LayoutTestController::LayoutTestController):
215         (WTR::LayoutTestController::~LayoutTestController):
216         (WTR::dumpAsTextCallback):
217         (WTR::layoutTestControllerObjectFinalize):
218         (WTR::LayoutTestController::makeWindowObject):
219         (WTR::LayoutTestController::getJSClass):
220         (WTR::LayoutTestController::staticFunctions):
221         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added.
222         (WTR::LayoutTestController::dumpAsText):
223         (WTR::LayoutTestController::setDumpAsText):
224         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
225
226 2010-06-25  Sam Weinig  <sam@webkit.org>
227
228         Reviewed by Anders Carlsson.
229
230         Make WebKitTestRunner really work with run-webkit-tests. 
231
232         - Add Forwarding headers to allow some cleanup.
233
234         * WebKitTestRunner/ForwardingHeaders: Added.
235         * WebKitTestRunner/ForwardingHeaders/wtf: Added.
236         * WebKitTestRunner/ForwardingHeaders/wtf/ASCIICType.h: Added.
237         * WebKitTestRunner/ForwardingHeaders/wtf/Assertions.h: Added.
238         * WebKitTestRunner/ForwardingHeaders/wtf/Atomics.h: Added.
239         * WebKitTestRunner/ForwardingHeaders/wtf/FastMalloc.h: Added.
240         * WebKitTestRunner/ForwardingHeaders/wtf/HashMap.h: Added.
241         * WebKitTestRunner/ForwardingHeaders/wtf/HashSet.h: Added.
242         * WebKitTestRunner/ForwardingHeaders/wtf/HashTraits.h: Added.
243         * WebKitTestRunner/ForwardingHeaders/wtf/Locker.h: Added.
244         * WebKitTestRunner/ForwardingHeaders/wtf/MainThread.h: Added.
245         * WebKitTestRunner/ForwardingHeaders/wtf/MathExtras.h: Added.
246         * WebKitTestRunner/ForwardingHeaders/wtf/Noncopyable.h: Added.
247         * WebKitTestRunner/ForwardingHeaders/wtf/OwnPtr.h: Added.
248         * WebKitTestRunner/ForwardingHeaders/wtf/OwnPtrCommon.h: Added.
249         * WebKitTestRunner/ForwardingHeaders/wtf/PassOwnPtr.h: Added.
250         * WebKitTestRunner/ForwardingHeaders/wtf/PassRefPtr.h: Added.
251         * WebKitTestRunner/ForwardingHeaders/wtf/Platform.h: Added.
252         * WebKitTestRunner/ForwardingHeaders/wtf/RefCounted.h: Added.
253         * WebKitTestRunner/ForwardingHeaders/wtf/RefPtr.h: Added.
254         * WebKitTestRunner/ForwardingHeaders/wtf/RetainPtr.h: Added.
255         * WebKitTestRunner/ForwardingHeaders/wtf/StringExtras.h: Added.
256         * WebKitTestRunner/ForwardingHeaders/wtf/ThreadSafeShared.h: Added.
257         * WebKitTestRunner/ForwardingHeaders/wtf/Threading.h: Added.
258         * WebKitTestRunner/ForwardingHeaders/wtf/ThreadingPrimitives.h: Added.
259         * WebKitTestRunner/ForwardingHeaders/wtf/Vector.h: Added.
260         * WebKitTestRunner/TestInvocation.cpp:
261         (WTR::TestInvocation::dump): Dump the right number of #EOFs.
262         * WebKitTestRunner/TestInvocation.h:
263
264 2010-06-25  Sam Weinig  <sam@webkit.org>
265
266         Reviewed by Mark Rowe.
267
268         Add support for WebKitTestRunner to old-run-webkit-tests
269
270         - Also adds a script to build WebKitTestRunner for old-run-webkit-tests to use.
271
272         * Scripts/build-webkittestrunner: Added.
273         * Scripts/old-run-webkit-tests:
274
275 2010-06-25  Adam Barth  <abarth@webkit.org>
276
277         Reviewed by David Levin.
278
279         Incremental build failed on Chromium ews
280         https://bugs.webkit.org/show_bug.cgi?id=41011
281
282         The division of responsibility between update-webkit --chromium and
283         build-webkit --chromium is slightly unclear.  In this patch, we make
284         build-webkit --chromium also update DEPS and re-run GYP in case the
285         developer has changed either since they updated.
286
287         This change is also helpful for the EWS, which wants to update DEPS and
288         re-run GYP after applying patches, but the EWS doesn't want to run
289         update-webkit --chromium because it has a dirty working copy.
290
291         * Scripts/webkitdirs.pm:
292
293 2010-06-25  Robert Hogan  <robert@webkit.org>
294
295         Reviewed by Simon Hausmann.
296
297         [Qt] Support evaluateScriptInIsolatedWorld()
298
299         https://bugs.webkit.org/show_bug.cgi?id=40079
300
301         Remove evaluateScriptInIsolatedWorld() from QtWebKit API.
302         Remove QWebScriptWorld from exported headers.
303         Confine support to DumpRenderTreeSupportQt so that the tests can pass.
304
305         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
306         (LayoutTestController::reset):
307         (LayoutTestController::evaluateScriptInIsolatedWorld):
308         * DumpRenderTree/qt/LayoutTestControllerQt.h:
309
310 2010-06-25  Anders Carlsson  <andersca@apple.com>
311
312         Revert accidental part and add a newline.
313
314         * MiniBrowser/mac/AppDelegate.m:
315         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
316
317 2010-06-25  Anders Carlsson  <andersca@apple.com>
318
319         Rubber-stamped by Dan Bernstein.
320
321         Add a LOG macro that expands to a no-op by default.
322
323         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
324         * MiniBrowser/mac/AppDelegate.m:
325         (_didRecieveMessageFromInjectedBundle):
326         * MiniBrowser/mac/BrowserWindowController.m:
327         (-[BrowserWindowController windowShouldClose:]):
328         (_didStartProvisionalLoadForFrame):
329         (_didReceiveServerRedirectForProvisionalLoadForFrame):
330         (_didFailProvisionalLoadWithErrorForFrame):
331         (_didCommitLoadForFrame):
332         (_didFinishLoadForFrame):
333         (_didFailLoadWithErrorForFrame):
334         (_didReceiveTitleForFrame):
335         (_didFirstLayoutForFrame):
336         (_didFirstVisuallyNonEmptyLayoutForFrame):
337         (_didBecomeUnresponsive):
338         (_didBecomeResponsive):
339         (_decidePolicyForNavigationAction):
340         (_decidePolicyForNewWindowAction):
341         (_createNewPage):
342         (_showPage):
343         (_closePage):
344         (_didNavigateWithNavigationData):
345         (_didPerformClientRedirect):
346         (_didPerformServerRedirect):
347         (_didUpdateHistoryTitle):
348         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
349         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
350         (_didClearWindowForFrame):
351         (_didCreatePage):
352         (_willDestroyPage):
353         (_didRecieveMessage):
354
355 2010-06-24  Adam Barth  <abarth@webkit.org>
356
357         Reviewed by Eric Seidel.
358
359         commit-queue is taking too long to land patches because of red trees
360         https://bugs.webkit.org/show_bug.cgi?id=41194
361
362         Instead of checking for the tree to be green, we'll just spin hot
363         trying to land patches.  This is probably too extreme in ignoring the
364         tree, but I think we should try it for a while to see if we have
365         trouble.  That will help us find the right balance.
366
367         * Scripts/webkitpy/tool/commands/queues.py:
368         * Scripts/webkitpy/tool/commands/queues_unittest.py:
369
370 2010-06-24  Martin Robinson  <mrobinson@igalia.com>
371
372         Reviewed by Xan Lopez.
373
374         [GTK] Clean up the use of gdk_window_get_root_coords in EventSender
375         https://bugs.webkit.org/show_bug.cgi?id=40843
376
377         Define the version for old GTK+s in a way that is forward-compatible
378         and clean up the logic a bit.
379
380         * DumpRenderTree/gtk/EventSender.cpp:
381         (gdk_window_get_root_coords): Renamed and cleaned up.
382         (prepareMouseButtonEvent): Remove #ifdefs.
383         (mouseMoveToCallback): Remove #ifdefs.
384
385 2010-06-24  Dimitri Glazkov  <dglazkov@chromium.org>
386
387         Reviewed by Eric Seidel.
388
389         Fix NewRunWebKitTests to work on Windows.
390         https://bugs.webkit.org/show_bug.cgi?id=41180
391
392         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added "perl" as first arguments,
393             because Windows fails to understand what we're asking of it.
394
395 2010-06-24  Martin Robinson  <mrobinson@igalia.com>
396
397         Reviewed by Xan Lopez.
398
399         [GTK] The url passed to the WebView during layout tests is invalid
400         https://bugs.webkit.org/show_bug.cgi?id=40832
401
402         Set the test URL to the full real file URL and do a small cleanup.
403         Previously a URL like file://relative/path/to/test.html was passed
404         to the WebView. This malformed file URL would be returned by
405         webkit_web_view_get_url and webkit_web_frame_get_url.
406
407         * DumpRenderTree/gtk/DumpRenderTree.cpp:
408         (shouldLogFrameLoadDelegates): Change to take a const string& as the argument.
409         (shouldOpenWebInspector): Change to take a const string& as the argument.
410         (shouldEnableDeveloperExtras): Change to take a const string& as the argument.
411         (runTest): Pass the full file:// URL to the view. Remove the superfluous url variable.
412
413 2010-06-24  Sam Weinig  <sam@webkit.org>
414
415         Reviewed by Anders Carlsson.
416
417         Fix WebKitTestRunner Makefile typos.
418
419         * WebKitTestRunner/Makefile:
420
421 2010-06-24  Adele Peterson  <adele@apple.com>
422
423         Reviewed by Eric Carlson.
424
425         DumpRenderTree part of testing <rdar://problem/8093680> "Paste and Match Style" should fire paste events
426         https://bugs.webkit.org/show_bug.cgi?id=41085
427
428         * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
429         Clear the general pasteboard in between tests so Cut,Copy, and setData on ClipboardData won't have lasting effects.
430
431 2010-06-23  Sam Weinig  <sam@webkit.org>
432
433         Reviewed by Anders Carlsson.
434
435         Patch for https://bugs.webkit.org/show_bug.cgi?id=41086
436         Add new WebKitTestRunner project (ie. DRT for WebKit2).
437
438         - Mac only.
439         - run-webkit-tests has not been modified to call it yet.
440         - Only dumps the render tree at this time. 
441
442         * WebKitTestRunner: Added.
443         * WebKitTestRunner/Configurations: Added.
444         * WebKitTestRunner/Configurations/Base.xcconfig: Added.
445         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Added.
446         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Added.
447         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Added.
448         * WebKitTestRunner/InjectedBundle: Added.
449         * WebKitTestRunner/InjectedBundle-Info.plist: Added.
450         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp: Added.
451         (_didStartProvisionalLoadForFrame):
452         (_didReceiveServerRedirectForProvisionalLoadForFrame):
453         (_didFailProvisionalLoadWithErrorForFrame):
454         (_didCommitLoadForFrame):
455         (_didFinishLoadForFrame):
456         (_didFailLoadWithErrorForFrame):
457         (_didReceiveTitleForFrame):
458         (_didClearWindow):
459         (_didCreatePage):
460         (_willDestroyPage):
461         (_didRecieveMessage):
462         (WKBundleInitialize):
463         * WebKitTestRunner/Makefile: Added.
464         * WebKitTestRunner/PlatformWebView.h: Added.
465         (WTR::PlatformWebView::platformView):
466         * WebKitTestRunner/TestController.cpp: Added.
467         (WTR::TestController::shared):
468         (WTR::TestController::TestController):
469         (WTR::TestController::initialize):
470         (WTR::TestController::runTest):
471         (WTR::TestController::runTestingServerLoop):
472         (WTR::TestController::run):
473         * WebKitTestRunner/TestController.h: Added.
474         (WTR::TestController::verbose):
475         (WTR::TestController::injectedBundlePath):
476         * WebKitTestRunner/TestInvocation.cpp: Added.
477         (WTR::createWKURL):
478         (WTR::TestInvocation::TestInvocation):
479         (WTR::TestInvocation::~TestInvocation):
480         (WTR::TestInvocation::invoke):
481         (WTR::TestInvocation::dump):
482         (WTR::TestInvocation::initializeMainWebView):
483         (WTR::TestInvocation::didStartProvisionalLoadForFrame):
484         (WTR::TestInvocation::didReceiveServerRedirectForProvisionalLoadForFrame):
485         (WTR::TestInvocation::didFailProvisionalLoadWithErrorForFrame):
486         (WTR::TestInvocation::didCommitLoadForFrame):
487         (WTR::TestInvocation::didFinishLoadForFrame):
488         (WTR::TestInvocation::didFailLoadForFrame):
489         (WTR::TestInvocation::renderTreeExternalRepresentationFunction):
490         (WTR::TestInvocation::renderTreeExternalRepresentationDisposeFunction):
491         * WebKitTestRunner/TestInvocation.h: Added.
492         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Added.
493         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added.
494         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Added.
495         * WebKitTestRunner/mac: Added.
496         * WebKitTestRunner/mac/PlatformWebViewMac.mm: Added.
497         (WTR::PlatformWebView::PlatformWebView):
498         (WTR::PlatformWebView::~PlatformWebView):
499         (WTR::PlatformWebView::page):
500         * WebKitTestRunner/mac/TestInvocationMac.mm: Added.
501         (WTR::TestInvocation::runUntil):
502         * WebKitTestRunner/mac/main.mm: Added.
503         (main):
504
505 2010-06-24  Luiz Agostini  <luiz.agostini@openbossa.org>
506
507         Unreviewed. Adding myself to the committers list.
508
509         * Scripts/webkitpy/common/config/committers.py:
510
511 2010-06-23  Kevin Ollivier  <kevino@theolliviers.com>
512
513         [wx] Build fix, adding new LayoutTestController methods and enabling SVG_FOREIGN_OBJECT.
514
515         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
516         (LayoutTestController::isPageBoxVisible):
517         (LayoutTestController::pageAreaRectInPixels):
518         (LayoutTestController::preferredPageSizeInPixels):
519         * wx/build/settings.py:
520
521 2010-06-23  James Robinson  <jamesr@chromium.org>
522
523         Unreviewed.  Add my IRC handle to committers.py so the sheriffbot can yell at me.
524
525         * Scripts/webkitpy/common/config/committers.py:
526
527 2010-06-23  Kent Tamura  <tkent@chromium.org>
528
529         Reviewed by Dimitri Glazkov.
530
531         Correct Chromium test configuration
532         https://bugs.webkit.org/show_bug.cgi?id=41057
533
534         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
535          - Add "--use-drt" option for NRWT. It is required for Chromium and
536            ignored for other platforms.
537          - Skip JSC test on Chromium
538         * BuildSlaveSupport/test-result-archive:
539           Add Chromium support.
540
541 2010-06-23  Sam Weinig  <sam@webkit.org>
542
543         Reviewed by Anders Carlsson.
544
545         Fix for https://bugs.webkit.org/show_bug.cgi?id=41073
546         WebKit2: Flesh out more of the InjectedBundle client API
547
548         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
549         (_didStartProvisionalLoadForFrame):
550         (_didReceiveServerRedirectForProvisionalLoadForFrame):
551         (_didFailProvisionalLoadWithErrorForFrame):
552         (_didCommitLoadForFrame):
553         (_didFinishLoadForFrame):
554         (_didFailLoadWithErrorForFrame):
555         (_didReceiveTitleForFrame):
556         (_didClearWindowForFrame):
557         (_didCreatePage):
558         (_willDestroyPage):
559         (WKBundleInitialize):
560
561 2010-06-23  Yuzo Fujishima  <yuzo@google.com>
562
563         Reviewed by Shinichiro Hamaji.
564
565         Implement page format data programming interface.
566         Add methods for testing.
567         https://bugs.webkit.org/show_bug.cgi?id=37538
568
569         * DumpRenderTree/LayoutTestController.cpp:
570         (parsePageNumber):
571         (isPageBoxVisibleCallback):
572         (pageAreaRectInPixelsCallback):
573         (preferredPageSizeInPixelsCallback):
574         (LayoutTestController::staticFunctions):
575         * DumpRenderTree/LayoutTestController.h:
576         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
577         (LayoutTestController::isPageBoxVisible):
578         (LayoutTestController::pageAreaRectInPixels):
579         (LayoutTestController::preferredPageSizeInPixels):
580         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
581         (LayoutTestController::isPageBoxVisible):
582         (LayoutTestController::pageAreaRectInPixels):
583         (LayoutTestController::preferredPageSizeInPixels):
584         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
585         (LayoutTestController::isPageBoxVisible):
586         (LayoutTestController::pageAreaRectInPixels):
587         (LayoutTestController::preferredPageSizeInPixels):
588
589 2010-06-23  Sam Magnuson  <smagnuson@netflix.com>
590
591         Reviewed by Shinichiro Hamaji.
592
593         Follow proper convention for if/switch/while as I've discovered
594         them to be through my review processes.
595         https://bugs.webkit.org/show_bug.cgi?id=40723
596
597         Modified test so that if( foo ) is not allowed as it appears not
598         to be the accepted convention.
599
600         * Scripts/webkitpy/style/checkers/cpp.py:
601         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
602
603 2010-06-22  Eric Seidel  <eric@webkit.org>
604
605         Reviewed by Adam Barth.
606
607         Run clean-header-guards to fix some header guards
608         https://bugs.webkit.org/show_bug.cgi?id=41044
609
610         No functional changes, thus no tests.
611
612         This entire change was generated by running
613         clean-header-guards, and then reverting changes
614         to files which shouldn't be changed.  Those which
615         are left all should be updated.
616
617         Some of these changes are just fixing 755 permissions
618         to be 644, since it seems various files have the wrong
619         execute bit which don't need it.  clean-header-guards
620         made those (welcome) permission fixes unintentionally.
621
622         * DumpRenderTree/chromium/WebThemeControlDRT.h:
623         * DumpRenderTree/chromium/WebThemeEngineDRT.h:
624         * QtTestBrowser/fpstimer.h:
625
626 2010-06-22  Adam Barth  <abarth@webkit.org>
627
628         Reviewed by Eric Seidel.
629
630         Rename HTMLDocumentParser to LegacyHTMLDocumentParser
631         https://bugs.webkit.org/show_bug.cgi?id=41043
632
633         Update the hash.
634
635         * Scripts/do-webcore-rename:
636
637 2010-06-22  Sam Magnuson  <smagnuson@netflix.com>
638
639         Reviewed by Shinichiro Hamaji.
640
641         Follow proper convention for variable declaration spacing.
642         https://bugs.webkit.org/show_bug.cgi?id=40724
643
644         Modified test so that 'int   a;' is not allowed.
645
646         * Scripts/webkitpy/style/checkers/cpp.py:
647         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
648
649 2010-06-22  Eric Seidel  <eric@webkit.org>
650
651         Unreviewed.  Add Tony Gentilcore now that he's a committer.
652
653         * Scripts/webkitpy/common/config/committers.py:
654
655 2010-06-22  Eric Seidel  <eric@webkit.org>
656
657         Reviewed by Adam Barth.
658
659         Remove Gtk 64-Release bot from core since it's broken
660         https://bugs.webkit.org/show_bug.cgi?id=41022
661
662         This bot alone has been responsible for more than 72 hours of
663         commit-queue blockage in the last week.  The bot is broken -- keeps
664         losing its display server or similar.  Until the Gtk folks can fix the
665         bot, we need to remove it from core.  The WebKit community can't keep
666         it green as is.
667
668         * Scripts/webkitpy/common/net/buildbot.py:
669         * Scripts/webkitpy/common/net/buildbot_unittest.py:
670
671 2010-06-21  Dumitru Daniliuc  <dumi@chromium.org>
672
673         Reviewed by Eric Seidel.
674
675         Fix the Windows build.
676         https://bugs.webkit.org/show_bug.cgi?id=40972
677
678         * DumpRenderTree/win/ImageDiff.vcproj:
679
680 2010-06-21  Prasad Tammana  <prasadt@chromium.org>
681
682         Reviewed by Darin Adler, Dmitry Titov.
683
684         DumpRenderTree should allow tests with modal dialogs
685         https://bugs.webkit.org/show_bug.cgi?id=35350
686
687         * DumpRenderTree/LayoutTestController.cpp:
688         (abortModalCallback):
689         (LayoutTestController::staticFunctions):
690         * DumpRenderTree/LayoutTestController.h:
691         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
692         (LayoutTestController::abortModal):
693         Add abortModal method to LayoutTestController and make it available from script.
694
695         * DumpRenderTree/mac/UIDelegate.mm: Add support for showModalDialog.
696         (-[UIDelegate modalWindowWillClose:]): Observer for NSWindowWillCloseNotifications to call
697         abortModal from when modal window closes.
698         (-[UIDelegate webViewRunModal:]): Delegate method for showModalDialog to run the modal loop.
699
700 2010-06-21  Simon Fraser  <simon.fraser@apple.com>
701
702         Reviewed by Anders Carlsson.
703         
704         Rename DrawingAreaProxyUpdateChunk to ChunkedUpdateDrawingArea
705         https://bugs.webkit.org/show_bug.cgi?id=40948
706         
707         Have the script look in WebKit2.
708
709         * Scripts/do-webcore-rename:
710
711 2010-06-21  Robert Hogan  <robert@webkit.org>
712
713         Reviewed by Kenneth Rohde Christiansen.
714
715         [Qt] Unskip plugins/get-url-that-the-resource-load-delegate-will-disallow.html
716
717         It's a Mac-specific test so just add the required LayoutTestController
718         function as a no-op to avoid failing. Similar approach adopted by other
719         ports.
720
721         https://bugs.webkit.org/show_bug.cgi?id=33344
722
723         * DumpRenderTree/qt/LayoutTestControllerQt.h:
724         (LayoutTestController::addDisallowedURL):
725
726 2010-06-21  Sam Weinig  <sam@webkit.org>
727
728         Reviewed by Anders Carlsson.
729
730         Patch for https://bugs.webkit.org/show_bug.cgi?id=40940
731         Add message passing support to the WebKit2 API.
732
733         - Add some test messages.
734
735         * MiniBrowser/mac/AppDelegate.m:
736         (_didRecieveMessageFromInjectedBundle):
737         (-[BrowserAppDelegate init]):
738         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
739         (_didClearWindow):
740         (_didCreatePage):
741         (_didRecieveMessage):
742         (WKBundleInitialize):
743
744 2010-06-21  Drew Wilson  <atwilson@chromium.org>
745
746         Unreviewed.
747
748         Rolling back 61551 and 61555 due to test failures.
749
750         * DumpRenderTree/LayoutTestController.cpp:
751         (LayoutTestController::staticFunctions):
752         * DumpRenderTree/LayoutTestController.h:
753         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
754         (LayoutTestController::setEditingBehavior):
755         * DumpRenderTree/mac/UIDelegate.mm:
756
757 2010-06-21  Anders Carlsson  <andersca@apple.com>
758
759         Reviewed by Sam Weinig.
760
761         Make DumpRenderTree build with clang++
762
763         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
764         (-[LocalPasteboard setPropertyList:forType:]):
765         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
766         (-[DumpRenderTreeWindow keyDown:]):
767         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
768         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
769         (LayoutTestController::isCommandEnabled):
770
771 2010-06-21  Satish Sampath  <satish@chromium.org>
772
773         Reviewed by Steve Block.
774
775         Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
776         https://bugs.webkit.org/show_bug.cgi?id=40878
777
778         * Scripts/build-webkit:
779
780 2010-06-21  Kent Tamura  <tkent@chromium.org>
781
782         Reviewed by Dimitri Glazkov.
783
784         [DRT/Chromium] Initialization for http/tests/loading/
785         https://bugs.webkit.org/show_bug.cgi?id=40902
786
787         * DumpRenderTree/chromium/TestShell.cpp:
788         (TestShell::runFileTest):
789
790 2010-06-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
791
792         Unreviewed.
793
794         Adding myself to the committers list.
795
796         * Scripts/webkitpy/common/config/committers.py:
797
798 2010-06-20  Kent Tamura  <tkent@chromium.org>
799
800         Reviewed by Dimitri Glazkov.
801
802         [DRT/Chromium] Add --allow-external-pages option
803         https://bugs.webkit.org/show_bug.cgi?id=40762
804
805         Add --allow-external-pages introduced by Chromium r45403.
806         http://src.chromium.org/viewvc/chrome?view=rev&revision=45403
807
808         * DumpRenderTree/chromium/DumpRenderTree.cpp:
809         (main):
810         * DumpRenderTree/chromium/TestShell.cpp:
811         (TestShell::TestShell):
812         * DumpRenderTree/chromium/TestShell.h:
813         (TestShell::allowExternalPages):
814         (TestShell::setAllowExternalPages):
815         * DumpRenderTree/chromium/WebViewHost.cpp:
816         (WebViewHost::willSendRequest):
817
818 2010-06-20  Joseph Pecoraro  <joepeck@webkit.org>
819
820         Reviewed by Adam Barth.
821
822         Sheriffbot: Should allow "r" in SVN_REVISION
823         https://bugs.webkit.org/show_bug.cgi?id=40889
824
825         * Scripts/webkitpy/tool/bot/irc_command.py: remove a leading "r" from SVN_REVISION if it exists
826         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: test an SVN_REVISION with a leading r.
827
828 2010-06-20  Joseph Pecoraro  <joepeck@webkit.org>
829
830         Reviewed by Dimitri Glazkov.
831
832         Python Tests Fail after r61508
833         https://bugs.webkit.org/show_bug.cgi?id=40891
834
835         Test's regex list needed to be updated to match the new
836         regex list in the source code. Added new bots to the
837         example_buildbots list.
838
839         Regex list fixed in r61512. Updated bot list.
840
841         * Scripts/webkitpy/common/net/buildbot_unittest.py:
842
843 2010-06-20  Dimitri Glazkov  <dglazkov@chromium.org>
844
845         Unreviewed, build fix.
846
847         Tweak test regexp list to match the change in http://trac.webkit.org/changeset/61508.
848
849         * Scripts/webkitpy/common/net/buildbot_unittest.py: Tweaked regexp.
850
851 2010-06-19  Justin Schuh  <jschuh@chromium.org>
852
853         Unreviewed.
854
855         Adding myself to the committers list.
856
857         * Scripts/webkitpy/common/config/committers.py:
858
859 2010-06-19  Sam Weinig  <sam@webkit.org>
860
861         Reviewed by Anders Carlsson.
862
863         Fix for https://bugs.webkit.org/show_bug.cgi?id=40882
864         Add ability to have a WebProcess per WebContext.
865
866         Move to use new shared contexts API.
867
868         * MiniBrowser/mac/AppDelegate.h:
869         * MiniBrowser/mac/AppDelegate.m:
870         (-[BrowserAppDelegate init]):
871         (-[BrowserAppDelegate getCurrentPageNamespace]):
872         (-[BrowserAppDelegate validateMenuItem:]):
873         (-[BrowserAppDelegate _setProcessModel:]):
874         (-[BrowserAppDelegate setSharedProcessProcessModel:]):
875         (-[BrowserAppDelegate setSharedThreadProcessModel:]):
876         * MiniBrowser/win/BrowserView.cpp:
877         (BrowserView::create):
878
879 2010-06-02  Robert Hogan  <robert@webkit.org>
880
881         Reviewed by Adam Barth.
882
883         [Qt] Support evaluateScriptInIsolatedWorld()
884
885         https://bugs.webkit.org/show_bug.cgi?id=40079
886
887         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
888         (LayoutTestController::evaluateScriptInIsolatedWorld):
889         * DumpRenderTree/qt/LayoutTestControllerQt.h:
890
891 2010-06-18  Dimitri Glazkov  <dglazkov@chromium.org>
892
893         Reviewed by Darin Adler.
894
895         Add three more non-core Chromium builders to start testing DumpRenderTree.
896         https://bugs.webkit.org/show_bug.cgi?id=40335
897
898         * BuildSlaveSupport/build.webkit.org-config/config.json: Added 3 builders.
899
900 2010-06-18  Drew Wilson  <atwilson@chromium.org>
901
902         Reviewed by Darin Fisher.
903
904         [Chromium] Plumbing for top-level frame names
905         https://bugs.webkit.org/show_bug.cgi?id=40430
906
907         * DumpRenderTree/chromium/WebViewHost.cpp:
908         (WebViewHost::reset):
909         Changed obsolete call to clearName() to use setName(WebString()) instead.
910
911 2010-06-18  Sam Weinig  <weinig@apple.com>
912
913         Rolling http://trac.webkit.org/changeset/61297 back in.
914
915         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
916         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Removed.
917         * MiniBrowser/mac/WebBundle/WebBundleMain.m: Added.
918         (_didClearWindow):
919         (_didCreatePage):
920         (WKBundleInitialize):
921
922 2010-06-18  Alexey Proskuryakov  <ap@apple.com>
923
924         Reviewed by Darin Adler.
925
926         https://bugs.webkit.org/show_bug.cgi?id=40803
927         TestNetscapePlugin has an incorrect implementation of "property" property
928
929         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginGetProperty): Don't
930         pass a static string back, it's going to be released by NPAPI implementation.
931
932 2010-06-18  Leandro Pereira  <leandro@profusion.mobi>
933
934         Unreviewed.
935
936         Adding myself to the committers list.
937
938         * Scripts/webkitpy/common/config/committers.py:
939
940 2010-06-17  Tony Chang  <tony@chromium.org>
941
942         Reviewed by Kent Tamura.
943
944         [chromium] cleanup redundant DEPS value and remove buildbot cleanup code
945         https://bugs.webkit.org/show_bug.cgi?id=40615
946
947         * Scripts/update-webkit-chromium: remove directory removal of third_party in old checkouts
948
949 2010-06-17  Ada Chan  <adachan@apple.com>
950
951         Rolling out http://trac.webkit.org/changeset/61297 due to build errors.
952
953         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
954         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Copied from MiniBrowser/mac/WebBundle/WebBundleMain.c.
955         * MiniBrowser/mac/WebBundle/WebBundleMain.m: Removed.
956
957 2010-06-17  Darin Adler  <darin@apple.com>
958
959         One more try at fix for Chromium build.
960
961         * DumpRenderTree/chromium/TestShell.cpp:
962         (TestShell::TestShell): Use set again instead of =.
963
964 2010-06-17  Darin Adler  <darin@apple.com>
965
966         Fix Chromium build.
967
968         I didn't realize that neither Chromium nor Qt share the DumpRenderTree
969         code with all the other platforms! Wow, that should be fixed at some point.
970
971         * DumpRenderTree/chromium/TestShell.cpp:
972         (TestShell::TestShell): Changed back to using "new".
973         * DumpRenderTree/chromium/TestShell.h: Changed back to OwnPtr.
974
975 2010-06-17  Simon Hausmann  <simon.hausmann@nokia.com>
976
977         Unreviewed Qt build fix.
978
979         LayoutTestController in the Qt DRT is not using refs :)
980
981         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
982         (WebCore::DumpRenderTree::DumpRenderTree):
983
984 2010-06-17  Darin Adler  <darin@apple.com>
985
986         Reviewed by Sam Weinig.
987
988         Use adoptRef and create functions in more code paths
989         https://bugs.webkit.org/show_bug.cgi?id=40760
990
991         * DumpRenderTree/DumpRenderTree.h: Change gLayoutTestController to a RefPtr.
992
993         * DumpRenderTree/LayoutTestController.cpp:
994         (LayoutTestController::create): Added.
995         * DumpRenderTree/LayoutTestController.h: Declare the create function.
996
997         * DumpRenderTree/chromium/TestShell.cpp:
998         (TestShell::TestShell): Use create instead of new.
999         * DumpRenderTree/chromium/TestShell.h: Use RefPtr instead of OwnPtr.
1000
1001         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1002         (runTest): Use RefPtr and create instead of OwnPtr and new.
1003
1004         * DumpRenderTree/mac/DumpRenderTree.mm:
1005         (runTest): Use RefPtr and create instead of OwnPtr and new.
1006
1007         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1008         (WebCore::DumpRenderTree::DumpRenderTree): Use create and releaseRef
1009         instead of new.
1010
1011         * DumpRenderTree/win/DumpRenderTree.cpp:
1012         (runTest): Use RefPtr and create instead of OwnPtr and new.
1013
1014         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
1015         (runTest): Use RefPtr and create instead of OwnPtr and new.
1016         (MyApp::OnInit): Removed unneeded code to delete the layout
1017         test controller. This is done during each test.
1018
1019 2010-06-17  Kent Tamura  <tkent@chromium.org>
1020
1021         Reviewed by Shinichiro Hamaji.
1022
1023         [DRT/Chromium] Fix a bug of Windows pixel tests
1024         https://bugs.webkit.org/show_bug.cgi?id=40763
1025
1026         * DumpRenderTree/chromium/TestEventPrinter.cpp:
1027         (TestShellPrinter::handleImage):
1028
1029 2010-06-16  Kent Tamura  <tkent@chromium.org>
1030
1031         Reviewed by Shinichiro Hamaji.
1032
1033         [DRT/Chromium] Fix crash on Mac Release
1034         https://bugs.webkit.org/show_bug.cgi?id=40759
1035
1036         * DumpRenderTree/chromium/WebViewHost.cpp:
1037         (WebViewHost::paintRect): We should not use m_canvas directly because
1038           it is created lazily in canvas().
1039
1040 2010-06-16  Kevin Ollivier  <kevino@theolliviers.com>
1041
1042         [wx] Build fix after new method addition.
1043
1044         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1045         (LayoutTestController::pageProperty):
1046
1047 2010-06-16  Kent Tamura  <tkent@chromium.org>
1048
1049         Reviewed by Dimitri Glazkov.
1050
1051         [DRT/Chromium] Set current working directory for each of tests
1052         https://bugs.webkit.org/show_bug.cgi?id=40668
1053
1054         This change fixes tests with eventSender.beginDragWithFiles().
1055
1056         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1057         (runTest):
1058
1059 2010-06-16  Martin Robinson  <mrobinson@igalia.com>
1060
1061         Reviewed by Gustavo Noronha Silva.
1062
1063         [GTK] r60803 broke media/controls-drag-timebar.html
1064         https://bugs.webkit.org/show_bug.cgi?id=40269
1065
1066         Only queue events while the mouse button is down, if drag mode is enabled. Some
1067         tests may disable drag mode, to prevent the queuing of events in this situation.
1068
1069         * DumpRenderTree/gtk/EventSender.cpp:
1070         (sendOrQueueEvent): Only queue events here if dragMode is true.
1071
1072 2010-06-16  Martin Robinson  <mrobinson@igalia.com>
1073
1074         Reviewed by Gustavo Noronha Silva.
1075
1076         [GTK] Remove the abuse of GDK_CURRENT_TIME in the DRT
1077         https://bugs.webkit.org/show_bug.cgi?id=40600
1078
1079         * DumpRenderTree/gtk/EventSender.cpp:
1080         (prepareMouseButtonEvent): Remove logic adding an offset to GDK_CURRENT_TIME.
1081
1082 2010-06-16  Adam Barth  <abarth@webkit.org>
1083
1084         Reviewed by Dimitri Glazkov.
1085
1086         Add a hidden land-cowboy command to webkit-patch to help land quick
1087         build fixes.
1088
1089         * Scripts/webkitpy/tool/commands/download.py:
1090         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1091
1092 2010-06-16  Adam Roben  <aroben@apple.com>
1093
1094         Convert console messages to UTF-8 before printing them
1095
1096         Speculative fix for <http://webkit.org/b/40731> REGRESSION (r61234):
1097         http/tests/security/xssAuditor/embed-tag-null-char.html and
1098         http/tests/security/xssAuditor/object-embed-tag-null-char.html fail on
1099         Windows. (I can't test the fix because Apache is crashing on my
1100         computer.)
1101
1102         Reviewed by Alexey Proskuryakov.
1103
1104         * DumpRenderTree/win/DumpRenderTree.cpp:
1105         (toUTF8): Extracted the code into an overload that takes a wide string
1106         and a length, then added an overload that takes a wstring.
1107
1108         * DumpRenderTree/win/DumpRenderTreeWin.h: Declare the new toUTF8
1109         overload.
1110
1111         * DumpRenderTree/win/UIDelegate.cpp:
1112         (UIDelegate::webViewAddMessageToConsole): Use toUTF8 to convert to
1113         UTF-8 instead of letting printf convert to the current code page.
1114
1115 2010-06-16  Drew Wilson  <atwilson@chromium.org>
1116
1117         Reviewed by Kent Tamura.
1118
1119         [Chromium] Plumbing for top-level frame names
1120         https://bugs.webkit.org/show_bug.cgi?id=40430
1121
1122         * DumpRenderTree/chromium/WebViewHost.cpp:
1123         (WebViewHost::createView):
1124         Migrate to new createView() API.
1125         * DumpRenderTree/chromium/WebViewHost.h:
1126         Remove obsolete createView() methods, add new createView() API that takes a frameName parameter.
1127
1128 2010-06-16  Diego Gonzalez  <diegohcg@webkit.org>
1129
1130         Reviewed by Kenneth Rohde Christiansen.
1131
1132         [Qt] Scroll wheel event support to graphics based DRT
1133         https://bugs.webkit.org/show_bug.cgi?id=40577
1134
1135         * DumpRenderTree/qt/EventSenderQt.cpp:
1136         (EventSender::continuousMouseScrollBy):
1137         (EventSender::createGraphicsSceneWheelEvent):
1138         * DumpRenderTree/qt/EventSenderQt.h:
1139
1140 2010-06-16  Adam Roben  <aroben@apple.com>
1141
1142         Remove a stray newline from the Windows version of TestNetscapePlugin
1143
1144         Reviewed by Alexey Proskuryakov.
1145
1146         Fixes <http://webkit.org/b/40728>
1147         plugins/geturlnotify-during-document-teardown.html fails on Windows
1148
1149         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
1150         (NPP_Destroy): Removed extra newline that the Mac version doesn't
1151         have.
1152
1153 2010-06-16  Adam Roben  <aroben@apple.com>
1154
1155         Respect LayoutTestController::isPrinting on Windows
1156
1157         This gets some printing tests closer to passing (like
1158         printing/page-rule-in-media-query.html).
1159
1160         Fixes <http://webkit.org/b/40727>.
1161
1162         Reviewed by Dan Bernstein.
1163
1164         * DumpRenderTree/win/DumpRenderTree.cpp:
1165         (dump): Pass LayoutTestController::isPrinting to
1166         IWebFramePrivate::renderTreeAsExternalRepresentation.
1167
1168 2010-06-15  Adam Barth  <abarth@webkit.org>
1169
1170         Reviewed by Eric Seidel.
1171
1172         Enable HTML5 lexer
1173         https://bugs.webkit.org/show_bug.cgi?id=40650
1174
1175         * DumpRenderTree/mac/DumpRenderTree.mm:
1176         (initializeGlobalsFromCommandLineOptions):
1177
1178 2010-06-10  Yuzo Fujishima  <yuzo@google.com>
1179
1180         Reviewed by Shinichiro Hamaji.
1181
1182         Implement render style selection for pages to support CSS3 Paged Media.
1183         https://bugs.webkit.org/show_bug.cgi?id=35961
1184
1185         * DumpRenderTree/LayoutTestController.cpp:
1186         (parsePagePropertyParameters):
1187         (pagePropertyCallback):
1188         (LayoutTestController::staticFunctions):
1189         * DumpRenderTree/LayoutTestController.h:
1190         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1191         (LayoutTestController::pageProperty):
1192         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1193         (LayoutTestController::pageProperty):
1194         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1195         (LayoutTestController::pageProperty):
1196
1197 2010-06-15  Sam Weinig  <sam@webkit.org>
1198
1199         Reviewed by Anders Carlsson.
1200
1201         Fix for https://bugs.webkit.org/show_bug.cgi?id=40630
1202         WebKit2: Add mechanism to inject code into the WebProcess on startup
1203
1204         Add initial InjectedBundle support.
1205
1206         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1207         * MiniBrowser/WebBundle-Info.plist: Added.
1208         Add test InjectedBundle to the project.
1209
1210         * MiniBrowser/mac/AppDelegate.m:
1211         (-[BrowserAppDelegate init]):
1212         Get the path to the WebBundle from the the main bundle and pass it to the new
1213         WKContextCreateWithInjectedBundlePath function.
1214
1215         * MiniBrowser/mac/BrowserWindowController.m:
1216         (_didChangeProgress):
1217         Fix the build.  This has been broken for a while.
1218
1219         * MiniBrowser/mac/WebBundle: Added.
1220         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Added.
1221         (_didCreatePage):
1222         (WKBundleInitialize):
1223         Add really basic InjectedBundle.
1224
1225         * MiniBrowser/win/BrowserView.cpp:
1226         (BrowserView::create):
1227         Switch from WKContextCreateWithProcessModel to WKContextCreate and remove commented out code.
1228
1229 2010-06-15  Dumitru Daniliuc  <dumi@chromium.org>
1230
1231         Reviewed by Darin Adler.
1232
1233         Adding myself to the reviewers list.
1234         https://bugs.webkit.org/show_bug.cgi?id=40693
1235
1236         * Scripts/webkitpy/common/config/committers.py:
1237
1238 2010-06-15  Martin Robinson  <mrobinson@igalia.com>
1239
1240         Reviewed by Xan Lopez.
1241
1242         Switch to using GIO methods instead of realpath in GtkLauncher to determine
1243         the file URI. This should remove warnings about realpath being undefined
1244         when compiling with '-ansi'.
1245
1246         * GtkLauncher/main.c:
1247         (filenameToURL): Use GIO instead of realpath to determine file URI.
1248
1249 2010-06-15  Adam Roben  <aroben@apple.com>
1250
1251         Remove the redundant set-apple-windows-environment-variables script
1252
1253         Apparently update-webkit does this for you these days.
1254
1255         Rubber-stamped by Steve Falkenburg.
1256
1257         * Scripts/set-apple-windows-environment-variables: Removed.
1258
1259 2010-06-14  Adam Roben  <aroben@apple.com>
1260
1261         Add a script to set the WebKitOutputDir and WebKitLibrariesDir
1262         environment variables
1263
1264         Fixes <http://webkit.org/b/40595>.
1265
1266         Reviewed by Steve Falkenburg.
1267
1268         * Scripts/set-apple-windows-environment-variables: Added.
1269         (to_windows_path): Passes the passed-in path through cygpath to
1270         generate a Windows-style path.
1271         (main): Sets the WebKitOutputDir and WebKitLibrariesDir environment
1272         variables to their defaults, if they aren't already set.
1273
1274 2010-06-14  Adam Roben  <aroben@apple.com>
1275
1276         Speed up run-safari/debug-safari on Windows
1277
1278         Fixes <http://webkit.org/b/40586>.
1279
1280         Reviewed by Steve Falkenburg.
1281
1282         * Scripts/webkitdirs.pm:
1283         (runSafari): When debugging, set up the environment to run Safari
1284         using the built WebKit.dll, then use "devenv /debugexe Safari.exe" to
1285         actually launch the debugger. When not debugging, just run WebKit.exe
1286         and it will do the rest for us.
1287
1288 2010-06-15  Diego Gonzalez  <diegohcg@webkit.org>
1289
1290         Reviewed by Kenneth Rohde Christiansen.
1291
1292         [Qt] DRT EventSender support to graphics context events
1293         https://bugs.webkit.org/show_bug.cgi?id=40324
1294
1295         * DumpRenderTree/qt/EventSenderQt.cpp:
1296         (EventSender::contextClick):
1297
1298 2010-06-14  Tony Chang  <tony@chromium.org>
1299
1300         Reviewed by Darin Fisher.
1301
1302         [chromium] checkout chromium third_party directly
1303         https://bugs.webkit.org/show_bug.cgi?id=40556
1304
1305         * Scripts/update-webkit-chromium: some migration code for the bots
1306
1307 2010-06-14  Alexey Proskuryakov  <ap@apple.com>
1308
1309         Chromium build fix.
1310
1311         * DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown): Chromium uses differently
1312         named constants for Windows virtual key codes, replacing VK_DELETE with VKEY_DELETE.
1313
1314 2010-06-14  Alexey Proskuryakov  <ap@apple.com>
1315
1316         Reviewed by Darin Adler.
1317
1318         https://bugs.webkit.org/show_bug.cgi?id=40529
1319         eventSender.keyDown("delete") incorrectly sends a backspace on some platforms
1320
1321         * DumpRenderTree/mac/EventSendingController.mm:
1322         (-[EventSendingController keyDown:withModifiers:withLocation:]): We were sending a broken
1323         event for "delete" - it had virtual key code from forward delete, and text from backspace.
1324         Fixed "delete" to mean forward delete.
1325
1326         * DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown):
1327         * DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback):
1328         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
1329         Mac DRT confusion has propagated to other platforms, fixing those.
1330
1331 2010-06-14  Martin Robinson  <mrobinson@igalia.com>
1332
1333         Reviewed by Xan Lopez.
1334
1335         Small GtkLauncher build fix for some systems.
1336
1337         * GtkLauncher/main.c: Add <limit.h> include.
1338
1339 2010-06-14  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1340
1341         Reviewed by Laszlo Gombos.
1342
1343         [Qt] navigator.geolocation support for Qt port
1344         https://bugs.webkit.org/show_bug.cgi?id=39724
1345
1346         Implementation for geolocation cases to DumpRenderTreeQt
1347
1348         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1349         (WebCore::WebPage::allowGeolocationRequest):
1350         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1351         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1352         (LayoutTestController::setGeolocationPermission):
1353         (LayoutTestController::setMockGeolocationError):
1354         (LayoutTestController::setMockGeolocationPosition):
1355         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1356         (LayoutTestController::isGeolocationPermissionSet):
1357         (LayoutTestController::geolocationPermission):
1358
1359 2010-06-13  Nathan Lawrence  <nlawrence@apple.com>
1360
1361         Reviewed by Darin Adler.
1362
1363         Outside of Xcode (make or WebKitTools/Scripts), there doesn't seem to
1364         be a way of overwriting the Xcode system path.  Making
1365         $WEBKITOUTPUTDIR take precedence over the system default would make
1366         this possible.
1367
1368         * Scripts/webkitdirs.pm:
1369
1370 2010-06-13  Chris Fleizach  <cfleizach@apple.com>
1371
1372         Reviewed by Darin Adler.
1373
1374         AX: link won't return linked element if URL contains #
1375         https://bugs.webkit.org/show_bug.cgi?id=40192
1376
1377         * DumpRenderTree/AccessibilityUIElement.cpp:
1378         (linkedUIElementAtIndexCallback):
1379         (AccessibilityUIElement::getJSClass):
1380         * DumpRenderTree/AccessibilityUIElement.h:
1381         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1382         (AccessibilityUIElement::linkedUIElementAtIndex):
1383         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1384         (AccessibilityUIElement::linkedUIElementAtIndex):
1385         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1386         (AccessibilityUIElement::linkedUIElementAtIndex):
1387
1388 2010-06-13  Adam Barth  <abarth@webkit.org>
1389
1390         Reviewed by Darin Adler.
1391
1392         webkit-patch should add a bug URL to ChangeLogs if they don't have one yet
1393         https://bugs.webkit.org/show_bug.cgi?id=39550
1394
1395         This can cause an extra request to bugs.webkit.org durig upload, but it
1396         shouldn't be too bad.  Also, this won't work if you remove the
1397         boilerplate created by prepare-ChangeLog.
1398
1399         * Scripts/webkitpy/common/checkout/changelog.py:
1400         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1401         * Scripts/webkitpy/common/net/bugzilla.py:
1402         * Scripts/webkitpy/tool/steps/abstractstep.py:
1403         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1404         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py: Added.
1405
1406 2010-06-08  Robert Hogan  <robert@webkit.org>
1407
1408         Reviewed by Eric Seidel.
1409
1410         [Qt] Add support for callShouldCloseOnWebView() to DRT
1411         https://bugs.webkit.org/show_bug.cgi?id=40330
1412
1413         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1414         (LayoutTestController::callShouldCloseOnWebView):
1415         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1416         (LayoutTestController::setCallCloseOnWebViews):
1417
1418 2010-06-12  Eric Seidel  <eric@webkit.org>
1419
1420         Reviewed by Daniel Bates.
1421
1422         do-webcore-rename should have a --verbose option
1423         https://bugs.webkit.org/show_bug.cgi?id=40497
1424
1425         * Scripts/do-webcore-rename:
1426          - Unified how we handle skipping files/directories
1427            this will allow us to "black list" certain files and
1428            directories when performing renames.
1429          - Made do-webcore-rename log what it's skipping when passed --verbose.
1430
1431 2010-06-12  Darin Adler  <darin@apple.com>
1432
1433         * Scripts/run-bindings-tests: Fixed a typo in a message.
1434
1435 2010-06-12  Kent Tamura  <tkent@chromium.org>
1436
1437         Reviewed by Dimitri Glazkov.
1438
1439         [Chromium] new-run-webkit-tests --use-drt should work with Chromium checkout
1440         https://bugs.webkit.org/show_bug.cgi?id=40402
1441
1442         _build_path() of each Chromium port check existence of build path
1443         of Chromium checkout first, then check existence of build path of
1444         WebKit-only checkout.
1445
1446         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1447         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1448         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1449
1450 2010-06-12  Robert Hogan  <robert@webkit.org>
1451
1452         Reviewed by Kenneth Rohde Christiansen.
1453
1454         [Qt] Back-forward list dumping is incorrect
1455
1456         https://bugs.webkit.org/show_bug.cgi?id=36392
1457
1458         Support dumping child history items in DRT.
1459
1460         Unskip:
1461
1462         fast/loader/frame-src-change-added-to-history.html
1463         fast/loader/frame-src-change-not-added-to-history.html
1464         fast/loader/frame-location-change-not-added-to-history.html
1465
1466         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1467         (WebCore::dumpHistoryItem):
1468
1469 2010-06-10  Ojan Vafai  <ojan@chromium.org>
1470
1471         Reviewed by Eric Seidel.
1472
1473         upload all patches that lack in-rietveld to rietveld
1474         https://bugs.webkit.org/show_bug.cgi?id=40444
1475
1476         If it's a patch, then we'll try to upload it as long as it
1477         doesn't have in-rietveld set. No longer set in-rietveld? since
1478         it's not needed.
1479
1480         * Scripts/webkitpy/common/net/bugzilla.py:
1481
1482 2010-06-10  Ojan Vafai  <ojan@chromium.org>
1483
1484         Reviewed by Darin Fisher.
1485
1486         Fix rietveld upload when message length > 100 characters
1487         https://bugs.webkit.org/show_bug.cgi?id=40457
1488
1489         * Scripts/webkitpy/common/net/rietveld.py:
1490
1491 2010-06-11  Yael Aharon  <yael.aharon@nokia.com>
1492
1493         Reviewed by Laszlo Gombos.
1494
1495         [Qt] There should be a way to enable popups in QtTestBrowser
1496         https://bugs.webkit.org/show_bug.cgi?id=40427
1497
1498         * QtTestBrowser/main.cpp:
1499         (LauncherWindow::toggleJavascriptCanOpenWindows):
1500         (LauncherWindow::createChrome):
1501
1502 2010-06-10  Adam Barth  <abarth@webkit.org>
1503
1504         Reviewed by Daniel Bates.
1505
1506         Make SheriffBot more chatty
1507         https://bugs.webkit.org/show_bug.cgi?id=40463
1508
1509         People seem to like to talk to SheriffBot, so let's make him chat back.
1510
1511         * Scripts/webkitpy/thirdparty/__init__.py:
1512         * Scripts/webkitpy/tool/bot/irc_command.py:
1513         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Added.
1514         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
1515         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1516
1517 2010-06-10  Brian Weinstein  <bweinstein@apple.com>
1518
1519         Reviewed by Darin Adler.
1520
1521         Fix the Windows buildbot when WebKitAuxiliaryLibs.zip cannot be found on our server.
1522         
1523         Robustify update-webkit-auxiliary-libs to be able to handle the case when WebKitAuxiliaryLibs.zip doesn't exist,
1524         and allow the script to fall back to an existing file, only failing if there is no fallback file. Also switch to checking
1525         WEXITSTATUS on $result instead of just comparing $result to 0.
1526
1527         * Scripts/update-webkit-auxiliary-libs:
1528
1529 2010-06-10  Ojan Vafai  <ojan@chromium.org>
1530
1531         Reviewed by Alexey Proskuryakov.
1532
1533         don't use Exception.message as it's deprecated in python 2.6+
1534         https://bugs.webkit.org/show_bug.cgi?id=40449
1535
1536         * Scripts/webkitpy/tool/commands/queues.py:
1537
1538 2010-06-10  Ojan Vafai  <ojan@chromium.org>
1539
1540         Reviewed by Adam Barth.
1541
1542         fix handle_script_error in rietveld upload queue and add testing for handle_script_error
1543         https://bugs.webkit.org/show_bug.cgi?id=40436
1544
1545         * Scripts/webkitpy/common/system/outputcapture.py:
1546         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1547         * Scripts/webkitpy/tool/commands/queues.py:
1548         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1549         * Scripts/webkitpy/tool/commands/queuestest.py:
1550         * Scripts/webkitpy/tool/mocktool.py:
1551
1552 2010-06-10  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
1553
1554         Reviewed by Simon Hausmann.
1555
1556         [Qt] *All* WebGL layout tests fail!
1557         https://bugs.webkit.org/show_bug.cgi?id=40296
1558
1559         Added test for WebKitWebGLEnabled to
1560         LayoutTestController::overridePreference().
1561
1562         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1563         (LayoutTestController::overridePreference):
1564
1565 2010-06-10  Diego Gonzalez  <diegohcg@webkit.org>
1566
1567         Reviewed by Kenneth Rohde Christiansen.
1568
1569         [Qt] DRT EventSender support to graphics mouse events activation
1570         https://bugs.webkit.org/show_bug.cgi?id=40017
1571
1572         * DumpRenderTree/qt/EventSenderQt.cpp:
1573         (EventSender::mouseDown):
1574         (EventSender::mouseUp):
1575         (EventSender::mouseMoveTo):
1576         (EventSender::keyDown):
1577         (EventSender::contextClick):
1578         (EventSender::sendTouchEvent):
1579         (EventSender::sendOrQueueEvent):
1580         (EventSender::eventFilter):
1581         (EventSender::createGraphicsSceneMouseEvent):
1582         (EventSender::sendEvent):
1583         * DumpRenderTree/qt/EventSenderQt.h:
1584         (EventSender::isGraphicsBased):
1585
1586 2010-06-09  Adam Barth  <abarth@webkit.org>
1587
1588         Reviewed by Ojan Vafai.
1589
1590         webkit-patch upload fails for security bugs because there's no rietveld flag
1591         https://bugs.webkit.org/show_bug.cgi?id=40309
1592
1593         There's probably a more elegant way of seeing whether the form control
1594         exists, but this seems to work.
1595
1596         * Scripts/webkitpy/common/net/bugzilla.py:
1597
1598 2010-06-09  Ojan Vafai  <ojan@chromium.org>
1599
1600         Reviewed by Adam Barth.
1601
1602         make rietveld upload faster and avoid posting to bug on errors
1603         https://bugs.webkit.org/show_bug.cgi?id=40389
1604
1605         Only grab the first item of the upload queue instead of trying
1606         to compute the whole list upfront (which is O(n) bugzilla lookups!).
1607
1608         Also, don't post comments to the bug when uploading fails.
1609
1610         * Scripts/webkitpy/common/net/bugzilla.py:
1611         * Scripts/webkitpy/tool/commands/queues.py:
1612         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1613         * Scripts/webkitpy/tool/commands/stepsequence.py:
1614         * Scripts/webkitpy/tool/mocktool.py:
1615
1616 2010-06-09  Ojan Vafai  <ojan@chromium.org>
1617
1618         Reviewed by Adam Barth.
1619
1620         Rietveld upload queue fails when setting in-rietveld flag
1621         https://bugs.webkit.org/show_bug.cgi?id=40371
1622
1623         Make the comment arguments to set_flag_on_attachment optional
1624         and add it to the MockBugzilla.
1625
1626         * Scripts/webkitpy/common/net/bugzilla.py:
1627         * Scripts/webkitpy/tool/bot/queueengine.py:
1628         * Scripts/webkitpy/tool/commands/download_unittest.py:
1629         * Scripts/webkitpy/tool/commands/queues.py:
1630         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1631         * Scripts/webkitpy/tool/mocktool.py:
1632
1633 2010-06-09  Kenneth Russell  <kbr@google.com>
1634
1635         Reviewed by Dimitri Glazkov.
1636
1637         Rename FloatArray to Float32Array
1638         https://bugs.webkit.org/show_bug.cgi?id=40323
1639
1640         Used do-webcore-rename to perform renaming. Manually undid
1641         incorrect changes to WebCore/bridge/jni/jsc/JNIBridgeJSC.cpp,
1642         WebCore/manual-tests/resources/ArrayParameterTestApplet.java and
1643         ArrayParameterTestApplet.class. Updated LayoutTests. Built and ran
1644         all layout tests on Safari; built Chromium and ran selected WebGL
1645         tests.
1646
1647         * Scripts/do-webcore-rename:
1648
1649 2010-06-08  Tony Chang  <tony@chromium.org>
1650
1651         Reviewed by David Levin.
1652
1653         [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out
1654         https://bugs.webkit.org/show_bug.cgi?id=40285
1655
1656         * Scripts/webkitdirs.pm:
1657         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1658
1659 2010-06-03  Roland Steiner  <rolandsteiner@chromium.org>
1660
1661         Reviewed by Tamura Kent.
1662
1663         Bug 40052 - [DRT/Chromium] Upstream test_shell_webthemeengine as WebThemeEngineDRT
1664         https://bugs.webkit.org/show_bug.cgi?id=40052
1665         
1666         Add WebThemeEngineDRT and WebThemeControlDRT ported from Chromium rev. 48907
1667
1668         * DumpRenderTree/DumpRenderTree.gypi:
1669         * DumpRenderTree/chromium/TestShellWin.cpp:
1670         (platformInit):
1671         * DumpRenderTree/chromium/WebThemeControlDRT.cpp: Added.
1672         (WebKit::):
1673         (WebKit::WebThemeControlDRT::WebThemeControlDRT):
1674         (WebKit::WebThemeControlDRT::~WebThemeControlDRT):
1675         (WebKit::WebThemeControlDRT::box):
1676         (WebKit::WebThemeControlDRT::line):
1677         (WebKit::WebThemeControlDRT::triangle):
1678         (WebKit::WebThemeControlDRT::roundRect):
1679         (WebKit::WebThemeControlDRT::oval):
1680         (WebKit::WebThemeControlDRT::circle):
1681         (WebKit::WebThemeControlDRT::nestedBoxes):
1682         (WebKit::WebThemeControlDRT::markState):
1683         (WebKit::WebThemeControlDRT::draw):
1684         (WebKit::WebThemeControlDRT::drawTextField):
1685         (WebKit::WebThemeControlDRT::drawProgressBar):
1686         * DumpRenderTree/chromium/WebThemeControlDRT.h: Added.
1687         (WebKit::WebThemeControlDRT::):
1688         * DumpRenderTree/chromium/WebThemeEngineDRT.cpp: Added.
1689         (WebKit::):
1690         (WebKit::WebThemeEngineDRT::paintButton):
1691         (WebKit::WebThemeEngineDRT::paintMenuList):
1692         (WebKit::WebThemeEngineDRT::paintScrollbarArrow):
1693         (WebKit::WebThemeEngineDRT::paintScrollbarThumb):
1694         (WebKit::WebThemeEngineDRT::paintScrollbarTrack):
1695         (WebKit::WebThemeEngineDRT::paintTextField):
1696         (WebKit::WebThemeEngineDRT::paintTrackbar):
1697         (WebKit::WebThemeEngineDRT::paintProgressBar):
1698         * DumpRenderTree/chromium/WebThemeEngineDRT.h: Added.
1699         (WebKit::WebThemeEngineDRT::WebThemeEngineDRT):
1700
1701 2010-06-08  Sheriff Bot  <webkit.review.bot@gmail.com>
1702
1703         Unreviewed, rolling out r60878.
1704         http://trac.webkit.org/changeset/60878
1705         https://bugs.webkit.org/show_bug.cgi?id=40349
1706
1707         broke linux build (Requested by tony^work on #webkit).
1708
1709         * Scripts/webkitdirs.pm:
1710         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1711
1712 2010-06-08  Tony Chang  <tony@chromium.org>
1713
1714         Reviewed by David Levin.
1715
1716         [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out
1717         https://bugs.webkit.org/show_bug.cgi?id=40285
1718
1719         * Scripts/webkitdirs.pm:
1720         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1721
1722 2010-06-08  Kenneth Russell  <kbr@google.com>
1723
1724         Unreviewed, build fix.
1725
1726         Fix build breakage from 38145
1727         https://bugs.webkit.org/show_bug.cgi?id=40346
1728
1729         The fix for bug 38145 broke the Chromium Win build because
1730         Microsoft's cmath doesn't define log2. Suggested fix by zmo is to
1731         change log2(x) to log(x) / log(2). Built and ran WebGL layout
1732         tests in Safari on Mac OS X. Changed download mirrors for
1733         python-irclib to working ones.
1734
1735         * Scripts/webkitpy/thirdparty/__init__.py:
1736
1737 2010-06-08  Fumitoshi Ukai  <ukai@chromium.org>
1738
1739         Reviewed by Eric Seidel.
1740
1741         old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
1742         https://bugs.webkit.org/show_bug.cgi?id=39058
1743
1744         * Scripts/old-run-webkit-tests:
1745          use sourceDir() to find ensure-valid-python in checkPythonVersion()
1746
1747 2010-06-08  Andras Becsi  <abecsi@webkit.org>
1748
1749         Unreviewed buildfix after r60479.
1750
1751         [GTK] Move the declaration of getRootCoords higher up to fix the build on GTK
1752         versions other than 2.17.3.
1753
1754         * DumpRenderTree/gtk/EventSender.cpp:
1755         (getRootCoords):
1756
1757 2010-06-07  Martin Robinson  <mrobinson@igalia.com>
1758
1759         Reviewed by Oliver Hunt.
1760
1761         [GTK] Mouse movement should not trigger a replay of saved events in the event sender
1762         https://bugs.webkit.org/show_bug.cgi?id=40267
1763
1764         When a mouse button is down, automatically queue mouse motion events and
1765         do not play them back until the mouse button is released. This matches the
1766         behavior of other ports' EventSenders.
1767
1768         * DumpRenderTree/gtk/EventSender.cpp:
1769         (mouseMoveToCallback): Don't automatically replaySavedEvents for mouse motion.
1770         (sendOrQueueEvent): Add a shouldReplaySavedEvents argument defaulting to true.
1771
1772 2010-06-07  Nikolas Zimmermann  <nzimmermann@rim.com>
1773
1774         Reviewed by Sam Weinig.
1775
1776         Add CPP bindings generator
1777         https://bugs.webkit.org/show_bug.cgi?id=38279
1778
1779         Integrate CPP bindings in run-bindings-tests.
1780
1781         * Scripts/run-bindings-tests:
1782
1783 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
1784
1785         Reviewed by Ojan Vafai.
1786
1787         Rename 'svn_merge_base' -> 'remote_merge_base'. This was left out of r60633.
1788         https://bugs.webkit.org/show_bug.cgi?id=40183
1789
1790         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1791
1792 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
1793
1794         Unreviewed.
1795
1796         Add my new email and IRC nick to committers.py.
1797
1798         * Scripts/webkitpy/common/config/committers.py:
1799
1800 2010-06-04  Kinuko Yasuda  <kinuko@chromium.org>
1801
1802         Unreviewed.
1803
1804         Revert changes in json_results_generator.py's _get_svn_revision.
1805
1806         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1807
1808 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
1809
1810         Reviewed by Xan Lopez.
1811
1812         [GTK] GtkLauncher should support relative file paths
1813         https://bugs.webkit.org/show_bug.cgi?id=39944
1814
1815         Allow GtkLauncher to handle relative file paths passed via command-line arguments.
1816
1817         * GtkLauncher/main.c:
1818         (filename_to_url): Added.
1819         (main): Try to resolve arguments as relative file URLs first.
1820
1821 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
1822
1823         Reviewed by Xan Lopez.
1824
1825         [GTK] EventSender should call gtk_main_do_event instead of invoking signal handlers directly
1826         https://bugs.webkit.org/show_bug.cgi?id=40182
1827
1828         Instead of invoking signal handlers directly via g_signal_emit_by_name, call
1829         gtk_main_do_event. This will allow us to call gtk_get_current_event() in WebKit
1830         without breaking DRT.
1831
1832         * DumpRenderTree/gtk/EventSender.cpp:
1833         (dispatchEvent): Use gtk_main_do_event instead of invoking signal handlers directly.
1834         (keyDownCallback): Use dispatchEvent here which now uses gtk_main_do_event.
1835
1836 2010-06-04  Anders Carlsson  <andersca@apple.com>
1837
1838         Reviewed by David Hyatt.
1839
1840         Make the editing/spelling/context-menu-suggestions.html test more robust
1841         https://bugs.webkit.org/show_bug.cgi?id=40178
1842
1843         Change the contextClick method to return an array of strings describing the context menu items.
1844
1845         * DumpRenderTree/mac/EventSendingController.mm:
1846         (+[EventSendingController isSelectorExcludedFromWebScript:]):
1847         (+[EventSendingController webScriptNameForSelector:]):
1848         (-[EventSendingController contextClick]):
1849
1850 2010-06-03  Kinuko Yasuda  <kinuko@chromium.org>
1851
1852         Reviewed by Shinichiro Hamaji.
1853
1854         Clean up chromium-specific code from json_results_generator.py.
1855         https://bugs.webkit.org/show_bug.cgi?id=39665
1856
1857         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1858         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1859         * Scripts/webkitpy/layout_tests/port/base.py:
1860         * Scripts/webkitpy/layout_tests/port/chromium.py:
1861
1862 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
1863
1864         Reviewed by Adam Barth.
1865
1866         Utilize new takeFirst() method where appropriate.
1867         https://bugs.webkit.org/show_bug.cgi?id=40089
1868
1869         * DumpRenderTree/chromium/EventSender.cpp:
1870         (EventSender::replaySavedEvents):
1871         * DumpRenderTree/chromium/LayoutTestController.cpp:
1872         (LayoutTestController::WorkQueue::processWork):
1873         (LayoutTestController::WorkQueue::reset):
1874
1875 2010-06-04  Yael Aharon  <yael.aharon@nokia.com>
1876
1877         Reviewed by Simon Hausmann.
1878
1879         [Qt] QtTestLauncher should allow notifications by default.
1880         https://bugs.webkit.org/show_bug.cgi?id=40078
1881
1882         * QtTestBrowser/main.cpp:
1883         (NotificationsPermissionController::NotificationsPermissionController):
1884         (NotificationsPermissionController::checkPermission):
1885         (NotificationsPermissionController::requestPermission):
1886         (LauncherWindow::LauncherWindow):
1887
1888 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
1889
1890         Reviewed by Adam Barth.
1891
1892         Detect whether the user's environment can open a browser.
1893         https://bugs.webkit.org/show_bug.cgi?id=40136
1894
1895         Some environments like cygwin silently fail webbrowser.open() causing
1896         webkit-patch upload not to display any diff. This detects environments
1897         where webbrowser.open() would fail by testing if webbrowser.get()
1898         raises an exception.
1899
1900         * Scripts/webkitpy/common/system/user.py:
1901         * Scripts/webkitpy/tool/mocktool.py:
1902         * Scripts/webkitpy/tool/steps/confirmdiff.py:
1903
1904 2010-06-03  Tony Gentilcore  <tonyg@chromium.org>
1905
1906         Reviewed by David Levin.
1907
1908         Add dependencies required to link with VS Express 2005.
1909         https://bugs.webkit.org/show_bug.cgi?id=40038
1910
1911         Visual Studio implicitly links against these libs.
1912         VC++ Express does not.
1913
1914         * WebKitAPITest/WebKitAPITestCommon.vsprops:
1915         * WinLauncher/WinLauncher.vcproj:
1916
1917 2010-06-03  Fumitoshi Ukai  <ukai@chromium.org>
1918
1919         Reviewed by David Levin.
1920
1921         bad codecs.open in webkitpy/layout_tests/ports/websocket_server.py
1922         https://bugs.webkit.org/show_bug.cgi?id=40105
1923
1924         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1925         - kill pywebsocket process when url is not alive and the process is not
1926           terminated, not to leave pywebsocket server running.
1927         - fix codecs.open parameters.
1928
1929 2010-06-03  Fumitoshi Ukai  <ukai@chromium.org>
1930
1931         Reviewed by Alexey Proskuryakov.
1932
1933         old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
1934         https://bugs.webkit.org/show_bug.cgi?id=39058
1935
1936         * Scripts/ensure-valid-python:
1937           - Perl 5.8 doesn't have File::Temp->newdir().  Use File::Temp->tempdir() instead.
1938           - Add --check-only and --help option.
1939           - --check-only option only checks python version and don't try to install Python 2.5.
1940           - Set executable bit.
1941         * Scripts/old-run-webkit-tests:
1942           - Check if it can run the websocket tests by calling ensure-valid-python --check-only.
1943
1944 2010-05-14  Ojan Vafai  <ojan@chromium.org>
1945
1946         Reviewed by Adam Barth.
1947
1948         add a RietveldUploadQueue to upload in-rietveld? patches to rietveld
1949         https://bugs.webkit.org/show_bug.cgi?id=38918
1950
1951         Patches with in-rietveld? get uploaded to rietveld and get marked
1952         in-rietveld+. If the upload fails, they are marked in-rietveld-
1953         and an error is logged to the bug, like the commit-queue.
1954
1955         Also, get rid of --fancy-review and the ability to upload to rietveld
1956         using webkit-patch upload/post.
1957
1958         * Scripts/webkitpy/common/net/bugzilla.py:
1959         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
1960         * Scripts/webkitpy/tool/commands/download.py:
1961         * Scripts/webkitpy/tool/commands/download_unittest.py:
1962         * Scripts/webkitpy/tool/commands/queues.py:
1963         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1964         * Scripts/webkitpy/tool/commands/upload.py:
1965         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1966         * Scripts/webkitpy/tool/mocktool.py:
1967         * Scripts/webkitpy/tool/steps/options.py:
1968         * Scripts/webkitpy/tool/steps/postcodereview.py:
1969
1970 2010-05-24  Ojan Vafai  <ojan@chromium.org>
1971
1972         Reviewed by Chris Jerdonek.
1973
1974         many webkit-patch commands fail in a non-svn tracking git checkout
1975         https://bugs.webkit.org/show_bug.cgi?id=38156
1976
1977         If the svn-tracking-branch (trunk) doesn't exist, fallback to the git remote-tracking-branch (master).
1978         If neither exists, then error out. This makes webkit-patch work
1979         for anyone that follows the intructions at http://trac.webkit.org/wiki/UsingGitWithWebKit
1980         to checkout webkit. The fallback to master is for people who don't
1981         do the steps on that page for tracking svn.
1982
1983         * Scripts/webkitpy/common/checkout/scm.py:
1984         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1985
1986 2010-06-03  Mike Fenton  <mifenton@rim.com>
1987
1988         Unreviewed.
1989
1990         Reverse e-mail for myself in committers.py to correspond with bugzilla account.
1991
1992         * Scripts/webkitpy/common/config/committers.py:
1993
1994 2010-06-03  Pavel Feldman  <pfeldman@chromium.org>
1995
1996         Reviewed by Yury Semikhatsky.
1997
1998         Web Inspector: a number of fixes that make InspectorController
1999         happy with null redirects.
2000
2001         https://bugs.webkit.org/show_bug.cgi?id=40109
2002
2003         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2004         (runTest):
2005         * DumpRenderTree/mac/DumpRenderTree.mm:
2006         (runTest):
2007         * DumpRenderTree/win/DumpRenderTree.cpp:
2008         (runTest):
2009
2010 2010-06-02  Tasuku Suzuki  <tasuku.suzuki@nokia.com>
2011
2012         Reviewed by Shinichiro Hamaji.
2013
2014         [Qt] Fix compilation with QT_NO_PROPERTIES
2015         https://bugs.webkit.org/show_bug.cgi?id=38324
2016
2017         * QtTestBrowser/main.cpp:
2018         (LauncherWindow::init):
2019
2020 2010-06-02  Diego Gonzalez  <diegohcg@webkit.org>
2021
2022         Reviewed by Kenneth Rohde Christiansen.
2023
2024         [Qt] Make possible run DRT with QGraphicsWebView
2025         https://bugs.webkit.org/show_bug.cgi?id=40016
2026
2027         Make possible to use a environment variable for switching backend.
2028         Usage: QT_DRT_WEBVIEW_MODE=graphics WebKitTools/Scripts/run-webkit-tests --qt
2029
2030         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2031         (WebCore::WebViewGraphicsBased::WebViewGraphicsBased):
2032         (WebCore::DumpRenderTree::DumpRenderTree):
2033         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2034         (WebCore::DumpRenderTree::setGraphicsBased):
2035         (WebCore::DumpRenderTree::isGraphicsBased):
2036         (WebCore::WebViewGraphicsBased::graphicsView):
2037         (WebCore::WebViewGraphicsBased::setPage):
2038         * Scripts/old-run-webkit-tests:
2039
2040 2010-06-02  Csaba Osztrogon√°c  <ossy@webkit.org>
2041
2042         Reviewed by Eric Seidel.
2043
2044         Slave lost shouldn't be recognized as build failed.
2045         https://bugs.webkit.org/show_bug.cgi?id=39282
2046
2047         * Scripts/webkitpy/common/net/buildbot.py: Treat slave lost as green.
2048         * Scripts/webkitpy/common/net/buildbot_unittest.py: Add unit test for slave lost.
2049
2050 2010-06-01  Yael Aharon  <yael.aharon@nokia.com>
2051
2052         Reviewed by Kenneth Rohde Christiansen.
2053
2054         [Qt] Fix the lifecycle of notification objects
2055         https://bugs.webkit.org/show_bug.cgi?id=40003
2056
2057         Remove the dependency of notifications on QWebPage.
2058
2059         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2060         (WebCore::requestPermissionCallback):
2061         (WebCore::WebPage::WebPage):
2062         (WebCore::DumpRenderTree::requestPermission):
2063         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2064
2065 2010-06-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2066
2067         Unreviewed, rolling out r60559.
2068         http://trac.webkit.org/changeset/60559
2069         https://bugs.webkit.org/show_bug.cgi?id=40055
2070
2071         It broke python unit test (Requested by Ossy on #webkit).
2072
2073         * Scripts/webkitpy/common/net/buildbot.py:
2074
2075 2010-06-02  Csaba Osztrogon√°c  <ossy@webkit.org>
2076
2077         Reviewed by Eric Seidel.
2078
2079         Slave lost shouldn't be recognized as build failed.
2080         https://bugs.webkit.org/show_bug.cgi?id=39282
2081
2082         * Scripts/webkitpy/common/net/buildbot.py:
2083
2084 2010-06-02  Tony Gentilcore  <tonyg@chromium.org>
2085
2086         Reviewed by Eric Seidel.
2087
2088         Fix crash caused when assigned_to is disabled
2089         https://bugs.webkit.org/show_bug.cgi?id=40039
2090
2091         * Scripts/webkitpy/common/net/bugzilla.py:
2092
2093 2010-06-02  Sterling Swigart  <sswigart@google.com>
2094
2095         Reviewed by David Levin.
2096
2097         Image Resizer Patch 0: Added compilation argument to conditionally compile pending patches.
2098         https://bugs.webkit.org/show_bug.cgi?id=39906
2099
2100         * Scripts/build-webkit:
2101
2102 2010-06-01  Raine Makelainen  <raine.makelainen@nokia.com>
2103
2104         Reviewed by Simon Hausmann.
2105
2106         Fixed tests to use QWebSettings::JavascriptCanAccessClipboard instead of QWebSettings::JavaScriptCanAccessClipboard.
2107
2108         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2109         (WebCore::WebPage::WebPage):
2110         (WebCore::WebPage::resetSettings):
2111         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2112         (LayoutTestController::setJavaScriptCanAccessClipboard):
2113
2114 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
2115
2116         Reviewed by Mark Rowe.
2117
2118         A nicer Tiger build fix.
2119
2120         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2121         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2122         Enable GCC_OBJC_CALL_CXX_CDTORS via .xcconfig.
2123
2124 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
2125
2126         A real Tiger build fix.
2127
2128         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Enable GCC_OBJC_CALL_CXX_CDTORS
2129         for all configurations, not just debug.
2130
2131 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
2132
2133         Tiger build fix.
2134
2135         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Enable GCC_OBJC_CALL_CXX_CDTORS.
2136
2137 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
2138
2139         Reviewed by Xan Lopez.
2140
2141         [GTK] Get more mouse tests passing
2142         https://bugs.webkit.org/show_bug.cgi?id=39040
2143
2144         Reproduce the logic from the Windows EventSender for mapping
2145         button numbers to GDK button numbers. Move this logic to the
2146         prepareMouseButtonEvent helper.
2147
2148         * DumpRenderTree/gtk/EventSender.cpp:
2149         (prepareMouseButtonEvent): Reproduce Windows logic.
2150         (contextClickCallback): Move mapping logic to prepareMouseButtonEvent.
2151         (mouseDownCallback): Ditto.
2152         (mouseUpCallback): Ditto.
2153
2154 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
2155
2156         Reviewed by Sam Weinig.
2157
2158         https://bugs.webkit.org/show_bug.cgi?id=39434
2159         REGRESSION (r59811): Geolocation callbacks cannot be created
2160
2161         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added MockGeolocationProvider.
2162
2163         * DumpRenderTree/mac/DumpRenderTree.mm:
2164         (createWebViewAndOffscreenWindow): Tell the view to use MockGeolocationProvider. 
2165         (resetWebViewToConsistentStateBeforeTesting): Make sure that mock notifications don't leak
2166         into subsequent tests.
2167
2168         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2169         (LayoutTestController::setMockGeolocationPosition): Changed to use MockGeolocationProvider.
2170         (LayoutTestController::setMockGeolocationError): Ditto.
2171
2172         * DumpRenderTree/mac/MockGeolocationProvider.h: Added.
2173         * DumpRenderTree/mac/MockGeolocationProvider.mm: Added.
2174         (+[MockGeolocationProvider shared]):
2175         (-[MockGeolocationProvider dealloc]):
2176         (-[MockGeolocationProvider setPosition:]):
2177         (-[MockGeolocationProvider setError:]):
2178         (-[MockGeolocationProvider registerWebView:]):
2179         (-[MockGeolocationProvider unregisterWebView:]):
2180         (-[MockGeolocationProvider lastPosition]):
2181         (-[MockGeolocationProvider stopTimer]):
2182         (-[MockGeolocationProvider timerFired]):
2183
2184         * DumpRenderTree/mac/UIDelegate.mm:
2185         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
2186         This delegate method must send a response. I'm not sure what the two-stage check is supposed
2187         to achieve, it seems unnecessary.
2188
2189 2010-05-12  Martin Robinson  <mrobinson@igalia.com>
2190
2191         Reviewed by Xan Lopez.
2192
2193         [GTK] Double clicks cause three button press events
2194         https://bugs.webkit.org/show_bug.cgi?id=38853
2195
2196         WebKit now filters the extra GDK_BUTTON_PRESS before GDK_2BUTTON_PRESS
2197         and GDK_3BUTTON_PRESS via gdk_event_peek(). Since EventSender bypasses
2198         the GDK event queue entirely, we simply do not send the extra event.
2199
2200         * DumpRenderTree/gtk/EventSender.cpp:
2201         (mouseDownCallback): Do not send extra event. Send GDK_3BUTTON_PRESS appropriately.
2202         (dispatchEvent): Properly handle GDK_3BUTTON_PRESS.
2203
2204 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
2205
2206         Not reviewed. Build fix.
2207
2208         Fix GTK+ build caused by a bad merge.
2209
2210         * DumpRenderTree/gtk/EventSender.cpp: 
2211         (prepareMouseButtonEvent): Use the GdkEvent union as a pointer here.
2212
2213 2010-06-01  Martin Robinson  <mrobinson@webkit.org>
2214
2215         Reviewed by Xan Lopez.
2216
2217         [GTK] Double clicks cause three button press events
2218         https://bugs.webkit.org/show_bug.cgi?id=38853
2219
2220         Small EventSender cleanups. Consolidate some common code. Style fixes.
2221
2222         * DumpRenderTree/gtk/EventSender.cpp:
2223         (prepareMouseButtonEvent): Added.
2224         (contextClickCallback): Use prepareMouseButtonEvent.
2225         (mouseDownCallback): Use prepareMouseButtonEvent.
2226         (mouseUpCallback): Use prepareMouseButtonEvent.
2227         (mouseMoveToCallback): Small style fix.
2228
2229 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
2230
2231         Reviewed by Xan Lopez.
2232
2233         [GTK] Double clicks cause three button press events
2234         https://bugs.webkit.org/show_bug.cgi?id=38853
2235
2236         Add rudimentary leapForward support to the GTK+ DRT. leapForward allows a test
2237         to pause for a specified amount of time. It is used in the processing of drag-
2238         -and-drop data as well as to separate distinct mouse double-clicks in some tests.
2239         This patch enables tests that rely on the latter behavior to pass.
2240
2241         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2242         (webViewWindowObjectCleared): Only initialize the EventSender when loading the top frame.
2243         * DumpRenderTree/gtk/EventSender.cpp:
2244         (leapForwardCallback): Add support for adjusting the time offset on leapForward().
2245         (contextClickCallback): Use sendOrQueueEvent.
2246         (updateClickCount): Take the time offset into account when counting clicks.
2247         (mouseDownCallback): Use sendOrQueueEvent.
2248         (getStateFlags): Change down/currentEventButton into buttonCurrentlyDown/lastClickButton.
2249         (mouseUpCallback): Use sendOrQueueEvent.
2250         (mouseMoveToCallback): Ditto.
2251         (mouseWheelToCallback): Ditto.
2252         (sendOrQueueEvent): Added.
2253         (dispatchEvent): Added.
2254         (replaySavedEvents): Pause when an event has a delay and defer to dispatchEvent.
2255         (makeEventSender): Only initialize the EventSender when loading the top frame.
2256         * DumpRenderTree/gtk/EventSender.h: Ditto.
2257
2258 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
2259
2260         Reviewed by Xan Lopez.
2261
2262         [GTK] css1/color_and_background/background_attachment.html fails on the 32-bit debug bot
2263         https://bugs.webkit.org/show_bug.cgi?id=39101
2264
2265         Work around timing issues for render tree dumps by pumping the
2266         main loop before doing the dump. Resize events are asynchronous
2267         in GTK+, so sometimes resize requests are still pending when DRT
2268         dumps the tree.
2269
2270         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2271         (dump): Pump the main loop before dumping the render tree.
2272
2273 2010-05-31  Kent Tamura  <tkent@chromium.org>
2274
2275         Reviewed by Dimitri Glazkov.
2276
2277         [DRT/Chromium] Fix crash of a test after another test with multiple windows
2278         https://bugs.webkit.org/show_bug.cgi?id=39942
2279
2280         If a test opens multiple windows, focuses on non-main window, and
2281         the focused window is closed, TestShell::m_focusedWidget points a
2282         deleted object.
2283
2284         * DumpRenderTree/chromium/TestShell.cpp:
2285         (TestShell::closeWindow): Clear m_focusedWidget.
2286
2287 2010-05-30  Kent Tamura  <tkent@chromium.org>
2288
2289         Reviewed by Dimitri Glazkov.
2290
2291         new-run-webkit-tests: Support DRT on Chromium-win
2292         https://bugs.webkit.org/show_bug.cgi?id=39810
2293
2294         Add --test-shell flag to DRT/Chromium, and it changes DRT so that
2295         it behaves like test_shell about command analysis, printing
2296         format, pixel dumping, and timeout handling.
2297
2298         chromium.py and chromium_win.py supports the --test-shell flag and
2299         DRT/Chromium-win binary names.
2300         
2301         * DumpRenderTree/DumpRenderTree.gypi: Add new files.
2302         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2303         (runTest): Support for test_shell-style command.
2304         (main): Introduce --test-shell.
2305         * DumpRenderTree/chromium/TestEventPrinter.cpp: Added.
2306         * DumpRenderTree/chromium/TestEventPrinter.h: Added.
2307           TestEventPrinter class manages stdio output and image output.
2308           TestEventPrinter.cpp has two implementations; DRTPrinter and
2309           TestShellPrinter.
2310         * DumpRenderTree/chromium/TestShell.cpp:
2311           Some changes for TestEventPrinter.
2312         (TestShell::TestShell):
2313         (TestShell::runFileTest):
2314         (TestShell::testTimedOut):
2315         (TestShell::dump):
2316         (TestShell::dumpImage):
2317         * DumpRenderTree/chromium/TestShell.h:
2318         (TestShell::printer):
2319         (TestShell::layoutTestTimeout):
2320         (TestShell::layoutTestTimeoutForWatchDog):
2321         (TestShell::setLayoutTestTimeout):
2322         * DumpRenderTree/chromium/TestShellWin.cpp:
2323         (watchDogThread): Use TestShell::layoutTestTimeoutForWatchDog().
2324         * Scripts/webkitpy/layout_tests/port/chromium.py:
2325         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2326
2327 2010-05-30  Robert Hogan  <robert@webkit.org>
2328
2329         Reviewed by Kenneth Rohde Christiansen.
2330
2331         [Qt] Enhance Qt DRT implementation to support platform scroll wheel events.
2332
2333         https://bugs.webkit.org/show_bug.cgi?id=36004
2334
2335         * DumpRenderTree/qt/EventSenderQt.cpp:
2336         (EventSender::EventSender): QApplication::setWheelScrollLines(2) in order to match
2337                                     Scrollbar::pixelsPerLineStep() for DRT testing.
2338         (EventSender::mouseScrollBy): Added
2339         (EventSender::continuousMouseScrollBy): Added
2340         * DumpRenderTree/qt/EventSenderQt.h:
2341
2342 2010-05-28  Adam Barth  <abarth@webkit.org>
2343
2344         Reviewed by David Levin.
2345
2346         webkit-patch should support CHANGE_LOG_EDIT_APPLICATION
2347         https://bugs.webkit.org/show_bug.cgi?id=39546
2348
2349         One sublty is that we want to wait for the user to finish editing the
2350         ChangeLog before moving on to the next step.  That means we want to pass
2351         -W to open.  However, if the user is using Xcode to edit the ChangeLog,
2352         we don't want them to have to exit the Xcode application.  For this reason,
2353         we create a new instance of the application with -n.
2354         
2355         Overall, xed seems like a better solution, so we recommend that too.
2356
2357         * Scripts/webkitpy/common/system/user.py:
2358         * Scripts/webkitpy/tool/mocktool.py:
2359         * Scripts/webkitpy/tool/steps/editchangelog.py:
2360
2361 2010-05-21  Dirk Pranke  <dpranke@chromium.org>
2362
2363         Reviewed by Ojan Vafai.
2364
2365         new-run-webkit-tests: fix handling of Ctrl-C to exit even if some
2366         threads are wedged. Also, the script will print the results of the
2367         tests completed when the interrupt occurs.
2368
2369         https://bugs.webkit.org/show_bug.cgi?id=33238
2370
2371         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2372         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2373         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2374         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2375
2376 2010-05-28  Darin Adler  <darin@apple.com>
2377
2378         Ignore more Python messiness.
2379
2380         * Scripts/webkitpy/layout_tests/data/platform/test: Added property svn:ignore.
2381         * Scripts/webkitpy/layout_tests/layout_package: Added property svn:ignore.
2382         * Scripts/webkitpy/layout_tests/test_types: Added property svn:ignore.
2383         * Scripts/webkitpy/test: Added property svn:ignore.
2384         * Scripts/webkitpy/thirdparty/simplejson: Added property svn:ignore.
2385
2386 2010-05-28  Chris Fleizach  <cfleizach@apple.com>
2387
2388         Reviewed by Beth Dakin.
2389
2390         Adding myself as a reviewer.
2391
2392         * Scripts/webkitpy/common/config/committers.py:
2393
2394 2010-05-28  Chris Fleizach  <cfleizach@apple.com>
2395
2396         Build fix. No review.
2397
2398         AX: need to catch NSAccessibilityExceptions in DRT
2399         https://bugs.webkit.org/show_bug.cgi?id=39881
2400
2401         It looks like Tiger doesn't like seeing a NSMakeRange inside a @try.
2402
2403         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2404         (AccessibilityUIElement::rowIndexRange):
2405         (AccessibilityUIElement::columnIndexRange):
2406         (AccessibilityUIElement::selectedTextRange):
2407
2408 2010-05-28  Chris Fleizach  <cfleizach@apple.com>
2409
2410         Reviewed by Darin Adler.
2411
2412         AX: need to catch NSAccessibilityExceptions in DRT
2413         https://bugs.webkit.org/show_bug.cgi?id=39881
2414
2415         Normally, accessibility exceptions are caught in the AX Runtime on the Mac, but 
2416         because DRT is its own AX client, no one is there to catch these otherwise innocuous exceptions.
2417   
2418         So DRT should wrap exception handlers around its AX related calls.
2419
2420         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2421         (attributesOfElement):
2422         (AccessibilityUIElement::getLinkedUIElements):
2423         (AccessibilityUIElement::getDocumentLinks):
2424         (AccessibilityUIElement::getChildren):
2425         (AccessibilityUIElement::getChildrenWithRange):
2426         (AccessibilityUIElement::ariaOwnsElementAtIndex):
2427         (AccessibilityUIElement::ariaFlowToElementAtIndex):
2428         (AccessibilityUIElement::disclosedRowAtIndex):
2429         (AccessibilityUIElement::selectedRowAtIndex):
2430         (AccessibilityUIElement::titleUIElement):
2431         (AccessibilityUIElement::parentElement):
2432         (AccessibilityUIElement::disclosedByRow):
2433         (AccessibilityUIElement::stringAttributeValue):
2434         (AccessibilityUIElement::boolAttributeValue):
2435         (AccessibilityUIElement::isAttributeSettable):
2436         (AccessibilityUIElement::isAttributeSupported):
2437         (AccessibilityUIElement::role):
2438         (AccessibilityUIElement::subrole):
2439         (AccessibilityUIElement::roleDescription):
2440         (AccessibilityUIElement::title):
2441         (AccessibilityUIElement::description):
2442         (AccessibilityUIElement::orientation):
2443         (AccessibilityUIElement::stringValue):
2444         (AccessibilityUIElement::language):
2445         (AccessibilityUIElement::helpText):
2446         (AccessibilityUIElement::x):
2447         (AccessibilityUIElement::y):
2448         (AccessibilityUIElement::width):
2449         (AccessibilityUIElement::height):
2450         (AccessibilityUIElement::clickPointX):
2451         (AccessibilityUIElement::clickPointY):
2452         (AccessibilityUIElement::intValue):
2453         (AccessibilityUIElement::minValue):
2454         (AccessibilityUIElement::maxValue):
2455         (AccessibilityUIElement::valueDescription):
2456         (AccessibilityUIElement::insertionPointLineNumber):
2457         (AccessibilityUIElement::isActionSupported):
2458         (AccessibilityUIElement::isEnabled):
2459         (AccessibilityUIElement::isRequired):
2460         (AccessibilityUIElement::isSelected):
2461         (AccessibilityUIElement::isExpanded):
2462         (AccessibilityUIElement::hierarchicalLevel):
2463         (AccessibilityUIElement::ariaIsGrabbed):
2464         (AccessibilityUIElement::ariaDropEffects):
2465         (AccessibilityUIElement::lineForIndex):
2466         (AccessibilityUIElement::boundsForRange):
2467         (AccessibilityUIElement::stringForRange):
2468         (AccessibilityUIElement::attributesOfColumnHeaders):
2469         (AccessibilityUIElement::attributesOfRowHeaders):
2470         (AccessibilityUIElement::attributesOfColumns):
2471         (AccessibilityUIElement::attributesOfRows):
2472         (AccessibilityUIElement::attributesOfVisibleCells):
2473         (AccessibilityUIElement::attributesOfHeader):
2474         (AccessibilityUIElement::rowCount):
2475         (AccessibilityUIElement::columnCount):
2476         (AccessibilityUIElement::indexInTable):
2477         (AccessibilityUIElement::rowIndexRange):
2478         (AccessibilityUIElement::columnIndexRange):
2479         (AccessibilityUIElement::cellForColumnAndRow):
2480         (AccessibilityUIElement::selectedTextRange):
2481         (AccessibilityUIElement::setSelectedTextRange):
2482         (AccessibilityUIElement::increment):
2483         (AccessibilityUIElement::decrement):
2484         (AccessibilityUIElement::showMenu):
2485         (AccessibilityUIElement::press):
2486         (AccessibilityUIElement::url):
2487         (AccessibilityUIElement::hasPopup):
2488
2489 2010-05-28  Yael Aharon  <yael.aharon@nokia.com>
2490
2491         Reviewed by Laszlo Gombos.
2492
2493         [Qt] Pass all web notification layout tests
2494         https://bugs.webkit.org/show_bug.cgi?id=39146
2495
2496         Mimic Chromium's test_shell security model in Qt's DRT.
2497         It makes a list of origins which were granted permission to display
2498         notifications, and only those origins can display notifications.
2499
2500         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2501         (WebCore::checkPermissionCallback):
2502         (WebCore::requestPermissionCallback):
2503         (WebCore::WebPage::WebPage):
2504         (WebCore::DumpRenderTree::checkPermission):
2505         (WebCore::DumpRenderTree::requestPermission):
2506         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2507         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2508         (LayoutTestController::reset):
2509         (LayoutTestController::grantDesktopNotificationPermission):
2510         (LayoutTestController::checkDesktopNotificationPermission):
2511         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2512
2513 2010-05-27  Philippe Normand  <pnormand@igalia.com>
2514
2515         Reviewed by Shinichiro Hamaji.
2516
2517         check-webkit-style complains about use of NULL in GTK function calls that require sentinels
2518         https://bugs.webkit.org/show_bug.cgi?id=39372
2519
2520         Don't warn about NULL in g_*() calls. Zero can't be used instead
2521         for calls like g_build_filename and g_object_get/set.
2522
2523         * Scripts/webkitpy/style/checkers/cpp.py:
2524         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2525
2526 2010-05-27  Luiz Agostini  <luiz.agostini@openbossa.org>
2527
2528         Reviewed by Kenneth Rohde Christiansen.
2529
2530         [Qt] Platform plugin example
2531         https://bugs.webkit.org/show_bug.cgi?id=39489
2532
2533         Exempting directory WebKit/qt/examples/ from style guide.
2534
2535         * Scripts/webkitpy/style/checker.py:
2536
2537 2010-05-26  Philippe Normand  <pnormand@igalia.com>
2538
2539         Reviewed by David Levin.
2540
2541         [style] Allow usage of NULL in gst_*_many()
2542         https://bugs.webkit.org/show_bug.cgi?id=39740
2543
2544         Don't warn if NULL is used by gst_*_many() functions. Zero can't
2545         be used for the reason explained in Bug 32858.
2546
2547         * Scripts/webkitpy/style/checkers/cpp.py:
2548         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2549
2550 2010-05-27  Adam Barth  <abarth@webkit.org>
2551
2552         Reviewed by Eric Seidel.
2553
2554         Update script to run the normal version of the parser tests.
2555
2556         * Scripts/test-html5-parser:
2557
2558 2010-05-27  Adam Barth  <abarth@webkit.org>
2559
2560         Reviewed by Eric Seidel.
2561
2562         Add HTML5 parser support to run-webkit-tests
2563         https://bugs.webkit.org/show_bug.cgi?id=39815
2564
2565         * Scripts/old-run-webkit-tests:
2566
2567 2010-05-26  Adam Barth  <abarth@webkit.org>
2568
2569         Reviewed by Eric Seidel.
2570
2571         Make HTML5 lexer not ASSERT when resuming partial parses
2572         https://bugs.webkit.org/show_bug.cgi?id=39755
2573
2574         Add webkit-resumer.html to the HTML5 parser test suite.
2575
2576         * Scripts/test-html5-parser:
2577
2578 2010-05-24  Tony Chang  <tony@chromium.org>
2579
2580         Reviewed by Kent Tamura.
2581
2582         [chromium] setup fonts on chromium linux DRT
2583         https://bugs.webkit.org/show_bug.cgi?id=39644
2584
2585         * DumpRenderTree/chromium/TestShellGtk.cpp:
2586         (setupFontconfig):
2587         (platformInit):
2588         * DumpRenderTree/chromium/WebViewHost.cpp:
2589         (WebViewHost::paintRect):  Fix a bug where in release builds, we didn't initialize m_canvas.
2590         * DumpRenderTree/chromium/fonts.conf: Added.
2591
2592 2010-05-24  Dirk Pranke  <dpranke@chromium.org>
2593
2594         Reviewed by Dimitri Glazkov.
2595
2596         Re-commit r58765 - it had been rolled out to see if it was causing
2597         a perf regression (in r59787 and r59789), but that does not seem to
2598         have been the case.
2599
2600         https://bugs.webkit.org/show_bug.cgi?id=39605
2601
2602         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2603         (NotificationPresenter::show):
2604
2605 2010-05-25  Ojan Vafai  <ojan@chromium.org>
2606
2607         Reviewed by Chris Jerdonek.
2608
2609         remove suppression of rietveld logging
2610         https://bugs.webkit.org/show_bug.cgi?id=39693
2611
2612         Now that we only upload to rietveld explicitly, e.g. on the bot
2613         or via webkit-patch post-attachment-to-rietveld, we should print
2614         all the rietveld logging. It was suppressed before to avoid making
2615         webkit-patch upload too noisy.
2616
2617         * Scripts/webkitpy/common/net/rietveld.py:
2618
2619 2010-05-25  Antonio Gomes  <tonikitoo@webkit.org>
2620
2621         Reviewed by Ojan Vafai.
2622
2623         [Qt] Expose the editing behavior setting in DRT to test all editing code paths
2624         https://bugs.webkit.org/show_bug.cgi?id=39680
2625
2626         Implement LayoutTestController::setEditingBehavior in Qt's DRT.
2627
2628         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2629         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2630         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2631         (LayoutTestController::setEditingBehavior):
2632
2633 2010-05-25  Kevin Ollivier  <kevino@theolliviers.com>
2634
2635         [wx] Build fix after API change and addition of WebCore/platform/text/transcoder dir. 
2636
2637         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2638         (LayoutTestController::setEditingBehavior):
2639         * wx/build/settings.py:
2640
2641 2010-05-24  Antonio Gomes  <tonikitoo@webkit.org>
2642
2643         Reviewed by Eric Seidel and Kent Tamura (for the Chromium part).
2644
2645         editingBehavior settings needs to be set back to a reasonable default between tests
2646         https://bugs.webkit.org/show_bug.cgi?id=39433
2647
2648         Similarly to r59861, hard code the default setting during reset for Gtk and Chromium,
2649         so that the serialized version of the setting stays in sync with expectations.
2650
2651         * DumpRenderTree/chromium/TestShell.cpp:
2652         (TestShell::resetWebSettings):
2653         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2654         (resetDefaultsToConsistentValues):
2655
2656 2010-05-24  Eric Seidel  <eric@webkit.org>
2657
2658         Reviewed by Adam Barth.
2659
2660         webkit-patch land calls scm.changed_files 4 times!
2661         https://bugs.webkit.org/show_bug.cgi?id=39584
2662
2663         * Scripts/webkitpy/tool/commands/download_unittest.py:
2664          - Assert that we don't call modified_changelogs too often.
2665         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
2666          - Use cached changelogs list instead of calling modified_changelogs directly.
2667         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2668          - ditto.
2669
2670 2010-05-24  Kent Tamura  <tkent@chromium.org>
2671
2672         Reviewed by Dimitri Glazkov.
2673
2674         [DRT/Chromium] Import layout_test_helper for Windows
2675         https://bugs.webkit.org/show_bug.cgi?id=39581
2676
2677         Import Chromium win/layout_test_helper.cc as LayoutTestHelperWin.cpp.
2678         http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/win/layout_test_helper.cc
2679
2680         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Added.
2681
2682 2010-05-24  Kent Tamura  <tkent@chromium.org>
2683
2684         Reviewed by Dimitri Glazkov.
2685
2686         [DRT/Chromium] Reset frame name
2687         https://bugs.webkit.org/show_bug.cgi?id=39586
2688
2689         This change fixes about 70 unexpected results.
2690
2691         * DumpRenderTree/chromium/WebViewHost.cpp:
2692         (WebViewHost::reset):
2693
2694 2010-05-24  Marcus Bulach  <bulach@chromium.org>
2695
2696         Reviewed by Kent Tamura.
2697
2698         [chromium] Adds WebGeolocationServiceMockImpl to remove public dependency on wtf/HashMap.h
2699         https://bugs.webkit.org/show_bug.cgi?id=39587
2700
2701         * DumpRenderTree/chromium/WebViewHost.cpp:
2702         (WebViewHost::geolocationService):
2703
2704 2010-05-24  Robert Hogan  <robert@webkit.org>
2705
2706         Reviewed by Laszlo Gombos.
2707
2708         [Qt] DRT Support for removeOriginAccessWhitelistEntry
2709
2710         Unskips http/tests/xmlhttprequest/origin-whitelisting-removal.html
2711
2712         [Qt] DRT Support for removeOriginAccessWhitelistEntry
2713         https://bugs.webkit.org/show_bug.cgi?id=39565
2714
2715         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2716         (LayoutTestController::removeOriginAccessWhitelistEntry):
2717
2718 2010-05-24  Marcus Bulach  <bulach@google.com>
2719
2720         Reviewed by Ojan Vafai.
2721
2722         _svn_branch_has_extra_commits needs to check for ^HEAD instead of ^head.
2723         https://bugs.webkit.org/show_bug.cgi?id=39603
2724
2725         * Scripts/webkitpy/common/checkout/scm.py:
2726
2727 == Rolled over to ChangeLog-2010-05-24 ==