WebKitTools/ChangeLog

   1 2007-06-23  Adam Roben  <aroben@apple.com>
   2
   3         Land num-cpus for the Windows build.
   4
   5         Reviewed by Mark Rowe.
   6
   7         * Scripts/num-cpus: Added.
   8
   9 2007-06-22  Simon Hausmann  <hausmann@kde.org>
  10
  11         Reviewed by Adam Roben.
  12
  13         Added support for populating ChangeLog entries from given git commits
  14         using --git-commit=<commitish> and --git-reviewer=<name>.
  15
  16         * Scripts/prepare-ChangeLog:
  17
  18 2007-06-22  Timothy Hatcher  <timothy@apple.com>
  19
  20         Reviewed by Anders.
  21
  22         <rdar://problem/5228168> Leopard regression test failures: fast/applescript
  23
  24         There were some changes in Leopard that made our test output inconsistent with Tiger.
  25
  26         NSAppleEventDescriptor no longer returns a stringValue for typeType descriptors
  27         on Leopard, so output our own readable string for typeType descriptors.
  28
  29         NSArray's description also changed on Leopard to output more whitespace, so
  30         make our own string representation for typeAEList descriptors. This requires
  31         a special case typeUnicodeText too, so the output is a quoted string.
  32
  33         * DumpRenderTree/AppleScriptController.m:
  34         (convertAEDescToObject):
  35
  36 2007-06-21  Anders Carlsson  <andersca@apple.com>
  37
  38         Reviewed by Geoff.
  39
  40         Don't dump didFirstLayout callbacks, they happen intermittently.
  41
  42         * DumpRenderTree/FrameLoadDelegate.m:
  43
  44 2007-06-21  Lars Knoll  <lars@trolltech.com>
  45
  46         Reviewed by Simon.
  47
  48         look for the Qt library in the installed location
  49
  50         * Scripts/webkitdirs.pm:
  51
  52 2007-06-20  Geoffrey Garen  <ggaren@apple.com>
  53
  54         Reviewed by Adele Peterson, Oliver Hunt, Anders Carlsson.
  55
  56         Added tests for stringByEvaluatingJavaScriptFromString.
  57
  58         * DumpRenderTree/DumpRenderTree.m:
  59         (testStringByEvaluatingJavaScriptFromString):
  60         (dumpRenderTree):
  61
  62 2007-06-19  Andrew Wellington  <proton@wiretapped.net>
  63
  64         Reviewed by Mark Rowe.
  65
  66         Support applications with spaces or special characters in their names
  67
  68         * Scripts/run-webkit-app:
  69
  70 2007-06-18  Anders Carlsson  <andersca@apple.com>
  71
  72         Reviewed by John Sullivan.
  73
  74         Assert that the frame has a dataSource.
  75
  76         * DumpRenderTree/FrameLoadDelegate.m:
  77         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
  78
  79 2007-06-18  Adam Treat <adam@staikos.net>
  80
  81         Reviewed by George.
  82
  83         Reflect the library name change.
  84
  85         * Scripts/webkitdirs.pm:
  86
  87 2007-06-18  Jake Helfert  <jake@jakeonthenet.com>
  88
  89         Reviewed by Adam.
  90
  91         - fix http://bugs.webkit.org/show_bug.cgi?id=14154
  92           Spinneret doesn't build against the new Win32 port.
  93
  94         * Spinneret/Spinneret/Spinneret.cpp:
  95         (_tWinMain):
  96             -Changed IWebViewExt to IWebViewPrivate
  97             -Changed Co[Un]initialize to Ole[Un]initialize because WebKit now calls
  98              the WIN32 function RegisterDragDrop which requires the Ole* calls.
  99         * Spinneret/Spinneret/Spinneret.h:
 100         (SpinneretWebHost::didReceiveIcon): Updated method signature.
 101         (SpinneretWebHost::willPerformClientRedirectToURL): Updated method signature.
 102         (SpinneretWebHost::windowScriptObjectAvailable): Updated method signature.
 103
 104 2007-06-14  Sam Weinig  <sam@webkit.org>
 105
 106         Reviewed by Brady.
 107
 108         Update set of files to download for cygwin to include
 109         diffutils and regenerate the zip file.  This should fix
 110         an issue on vista where svn-create-patch doesn't work.
 111
 112         * CygwinDownloader/cygwin-downloader.py:
 113         * CygwinDownloader/cygwin-downloader.zip:
 114
 115 2007-06-14  Mark Rowe  <mrowe@apple.com>
 116
 117         Update script to match new nightly.webkit.org infrastructure.
 118
 119         * BuildSlaveSupport/build-launcher-dmg:  Upload to the live web server, not the caching proxy.  Let the server know it's a Mac build.
 120
 121 2007-06-12  Adam Roben  <aroben@apple.com>
 122
 123         Land CygwinDownloader.
 124
 125         Rubberstamped by Hyatt.
 126
 127         * CygwinDownloader/cygwin-downloader.py: Added.
 128         * CygwinDownloader/cygwin-downloader.zip: Added.
 129         * CygwinDownloader/make-zip.sh: Added.
 130         * CygwinDownloader/setup.py: Added.
 131
 132 2007-06-06  Vladimir Olexa  <vladimir.olexa@gmail.com>
 133
 134         Reviewed by Mark Rowe.
 135
 136         Fixes Bug 13996: http://bugs.webkit.org/show_bug.cgi?id=13996
 137         [Drosera] Items in the file list don't get un-highlighted when
 138         files are selected from the file drop-down
 139
 140         * Drosera/debugger.js: currentFile was getting modified before file in the file
 141         browser got un-highlighted. Changed the order in which the functions execute.
 142
 143 2007-06-06  Mark Rowe  <mrowe@apple.com>
 144
 145         Reviewed by Maciej.
 146
 147         http://bugs.webkit.org/show_bug.cgi?id=13988
 148         Bug 13988: Colon in file path crashes WebKit Nightly
 149
 150         The WebKit launcher makes use of two `dyld' variables to coerce Safari into running with
 151         the bundled WebKit framework.  Both of these variables are interpreted as containing a
 152         colon-delimited list of paths.  There is no escaping mechanism defined, so if we detect
 153         a path with a colon in it we need to bail out to prevent `dyld' from throwing an error
 154         when we execute Safari.
 155
 156         * WebKitLauncher/main.m:
 157         (main):
 158
 159 2007-06-05  Mark Rowe  <mrowe@apple.com>
 160
 161         Reviewed by Anders.
 162
 163         * WebKitLauncher/Info.plist: Update CFBundleGetInfoString, and add CFBundleShortVersionString.
 164
 165 2007-05-30  Alp Toker  <alp.toker@collabora.co.uk>
 166
 167         Reviewed by Brady.
 168
 169         Enable logging in the Gdk port.
 170         http://bugs.webkit.org/show_bug.cgi?id=13936
 171
 172         * GdkLauncher/main.cpp:
 173         (main):
 174
 175 2007-05-29  Holger Freyther  <zecke@selfish.org>
 176
 177         Reviewed by Anders.
 178
 179         Create a GtkLayout and pass it to the FrameView/ScrollView. Embed the GtkLayout into a GtkScrolledWindow
 180         to provide ScrollBars for the FrameView.
 181
 182         * GdkLauncher/main.cpp:
 183         (registerRenderingAreaEvents):
 184         (layout_realize_callback): Only after realization we can access the GtkLayout::bin_window
 185         (frameResizeCallback): Inform the ScrollView about its new viewport size, and ask the FrameView to adjust
 186         (main):
 187
 188 2007-05-29  David Kilzer  <ddkilzer@webkit.org>
 189
 190         Reviewed by Darin.
 191
 192         - fix http://bugs.webkit.org/show_bug.cgi?id=13901
 193           run-pageloadtest does not obey testName on command-line
 194
 195         * Scripts/run-pageloadtest: Grab $testName from the command-line if it is present,
 196         otherwise default to "svg".  Added dummy check to make sure $testName.pltsuite
 197         exists.
 198
 199 2007-05-29  David Kilzer  <ddkilzer@webkit.org>
 200
 201         Reviewed by Darin.
 202
 203         - fix http://bugs.webkit.org/show_bug.cgi?id=13900
 204           svnStatus($) subroutine in svn-[un]apply does not work properly with directories
 205
 206         This patch also fixes an instance of the "broken pipe" warning that happened when
 207         a directory contained modified files that were not part of an applied or unapplied
 208         patch.
 209
 210         * Scripts/svn-apply:
 211         (svnStatus($)): If we're trying to get status on a directory (instead of a file),
 212         make sure we actually get the directory's status (if it has one), not the first
 213         file's status reported within the directory.  Fix "broken pipe" warnings by
 214         reading all of the output from the SVN filehandle before closing it.
 215         * Scripts/svn-unapply:
 216         (svnStatus($)): Ditto.
 217
 218 2007-05-28  David Kilzer  <ddkilzer@webkit.org>
 219
 220         Reviewed by Darin.
 221
 222         - fix http://bugs.webkit.org/show_bug.cgi?id=10342
 223           prepare-ChangeLog only shows removed files but not added files when files are moved
 224         - fix prepare-ChangeLog part of http://bugs.webkit.org/show_bug.cgi?id=13408
 225           prepare-ChangeLog and svn-create-patch don't show replaced files
 226
 227         Switched method used to find list of changed files from "diff" to "status".  This
 228         makes added and replaced files with history appear in the changed file list for svn.
 229         Added check for "+" in output from the svn status command to detect file history, and
 230         handle it in the generateFileList(\@\@\%) and in statusDescription($$) subroutines.
 231
 232         * Scripts/prepare-ChangeLog:
 233         (diffCommand(@)): Switched argument from hash ref to array to match statusCommand(@).
 234         (statusCommand(@)): Switched argument from array ref to array.  Necessary to use
 235         the output of "keys $paths" without creating a temporary array variable.
 236         (findOriginalFileFromSvn($)): Added.  Based on findSourceFileAndRevision($)
 237         subroutine in svn-create-patch.
 238         (generateFileList(\@\@\%)): Added.  Extracted from main body of script.  Runs status
 239         command using command-line arguments instead of list of changed files from the diff
 240         command.  Changed svn regex to only accept file statuses that we know how to handle.
 241         Identify original file when an added/replaced status with history is present.
 242         (statusDescription($$)): Handled added/replaced statuses with history.  Added
 243         fall-through return statement.
 244
 245 2007-05-28  Holger Freyther  <zecke@selfish.org>
 246
 247         Reviewed by Mark Rowe.
 248
 249         Add scripts and data to generate a coverage data for WebKit.
 250
 251         * CodeCoverage/README: Added.
 252         * CodeCoverage/amber.png: Added.
 253         * CodeCoverage/cov.py: Added.
 254         * CodeCoverage/emerald.png: Added.
 255         * CodeCoverage/gcov.css: Added.
 256         * CodeCoverage/glass.png: Added.
 257         * CodeCoverage/regenerate-coverage-display: Added.
 258         * CodeCoverage/ruby.png: Added.
 259         * CodeCoverage/run-generate-coverage-data: Added.
 260         * CodeCoverage/snow.png: Added.
 261         * Scripts/build-webkit: Add --coverage by Niko
 262         * Scripts/check-for-global-initializers: Skip the check on coverage builds
 263         * Scripts/generate-coverage-data: Added.
 264         * Scripts/run-javascriptcore-tests: Add --coverage by Niko
 265
 266 2007-05-29  Mark Rowe  <mrowe@apple.com>
 267
 268         Build fix after r21745.
 269
 270         * Scripts/check-for-global-initializers: Skip CachedPage.o as it now has a global initializer in debug builds.
 271
 272 2007-05-25  Anders Carlsson  <andersca@apple.com>
 273
 274         Fix build.
 275
 276         * DumpRenderTree/DumpRenderTree.m:
 277         * DumpRenderTree/FrameLoadDelegate.m:
 278
 279 2007-05-25  Simon Hausmann  <hausmann@kde.org>
 280
 281         Reviewed by Zack.
 282
 283         For the keyDown binding use QStringList instead of QList<QString>. The former is a default
 284         registered metatype. Also print out critical messages in dumprendertree's qt message handler.
 285
 286         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
 287         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
 288         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
 289
 290 2007-05-20  David Kilzer  <ddkilzer@webkit.org>
 291
 292         Reviewed by Adam Roben.
 293
 294         - fix http://bugs.webkit.org/show_bug.cgi?id=13565
 295           Change svn-create-patch to put LayoutTests in the end
 296
 297         In addition to reordering test files under the LayoutTests directory so that they
 298         appear after source code files, this patch fixes an issue with prepare-ChangeLog
 299         if the first argument passed to it is a file name instead of a directory name.
 300
 301         * Scripts/prepare-ChangeLog:
 302         (isGIT()): If first value in @dirs array is a file, use dirname() to get the directory.
 303         (isSVN()): Ditto.
 304         * Scripts/svn-create-patch:
 305         (generateFileList($\%\%\%)): Differentiate test files in the LayoutTests directory from
 306         source code files.
 307
 308 2007-05-18  Mark Rowe  <mrowe@apple.com>
 309
 310         Reviewed by Oliver.
 311
 312         Force LC_ALL to C when parsing locale-specific strings in 'svn' output.
 313
 314         * Scripts/svn-create-patch:
 315         * Scripts/webkitdirs.pm:
 316
 317 2007-05-18  Holger Freyther  <zecke@selfish.org>
 318
 319         Reviewed by Maciej.
 320
 321         * GdkLauncher/main.cpp: Call setGtkWidget
 322         (main):
 323
 324 2007-05-18  Holger Hans Peter Freyther  <zecke@selfish.org>
 325
 326         Reviewed by Mark Rowe.
 327
 328         * GdkLauncher/main.cpp:
 329         (main): Call Frame::init to catch up with Maciej's changes.
 330         * Scripts/run-javascriptcore-tests: Remove --gdk from the command line
 331         passed to the helper scripts.
 332
 333 2007-05-16  Brady Eidson  <beidson@apple.com>
 334
 335         Build fix for some dev configurations
 336
 337         * DumpRenderTree/DumpRenderTree.m:
 338
 339 2007-05-16  Maciej Stachowiak  <mjs@apple.com>
 340
 341         Reviewed by Justin.
 342
 343         - created a new mechanism to log FrameLoadDelegate callbacks in directories named "loading"
 344
 345         The reason for doing things in this slightly odd way is to make sure we don't miss the load delegates
 346         that happen before the load commits.
 347
 348         Basically I moved WaitUntilDoneDelegate into a separate file (FrameLoadDelegate.m) and added
 349         optional logging for every FrameLoadDelegate callback, including SPI callbacks.
 350
 351         * DumpRenderTree/DumpRenderTree.h:
 352         * DumpRenderTree/DumpRenderTree.m:
 353         (createWebView):
 354         (dumpRenderTree):
 355         (dump):
 356         (+[LayoutTestController isSelectorExcludedFromWebScript:]):
 357         (-[LayoutTestController clearBackForwardList]):
 358         (-[LayoutTestController setUseDashboardCompatibilityMode:]):
 359         (-[LayoutTestController dumpFrameLoadCallbacks]):
 360         (-[LayoutTestController setWindowIsKey:]):
 361         (-[LayoutTestController setMainFrameIsFirstResponder:]):
 362         (-[LayoutTestController _doLoad:target:]):
 363         (-[LayoutTestController _doBackOrForwardNavigation:]):
 364         (-[LayoutTestController queueReload]):
 365         (-[LayoutTestController queueScript:]):
 366         (-[LayoutTestController queueLoad:target:]):
 367         (-[LayoutTestController setAcceptsEditing:]):
 368         (-[LayoutTestController setTabKeyCyclesThroughElements:]):
 369         (shouldLogFrameLoadDelegates):
 370         (runTest):
 371         (displayWebView):
 372         (+[DumpRenderTreeEvent mouseLocation]):
 373         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 374         * DumpRenderTree/DumpRenderTreeDraggingInfo.m:
 375         (-[DumpRenderTreeDraggingInfo draggingDestinationWindow]):
 376         * DumpRenderTree/EventSendingController.m:
 377         (-[EventSendingController mouseDown]):
 378         (-[EventSendingController mouseUp]):
 379         (-[EventSendingController mouseMoveToX:Y:]):
 380         (-[EventSendingController contextClick]):
 381         * DumpRenderTree/FrameLoadDelegate.h: Added.
 382         * DumpRenderTree/FrameLoadDelegate.m: Added.
 383         (-[WebFrame _drt_descriptionSuitableForTestResult]):
 384         (-[FrameLoadDelegate processWork:]):
 385         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
 386         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
 387         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
 388         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
 389         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
 390         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
 391         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
 392         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
 393         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
 394         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
 395         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
 396         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
 397         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
 398         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
 399         (-[FrameLoadDelegate webView:willCloseFrame:]):
 400         (-[FrameLoadDelegate webView:didFirstLayoutInFrame:]):
 401         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
 402         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
 403         * DumpRenderTree/ResourceLoadDelegate.m:
 404         (-[NSURL _drt_descriptionSuitableForTestResult]):
 405         * DumpRenderTree/UIDelegate.m:
 406         (-[UIDelegate webViewFocus:]):
 407
 408 2007-05-16  Kevin McCullough  <kmccullough@apple.com>
 409
 410         Reviewed by Darin and Geoff.
 411
 412         - rdar://problem/4981886
 413         - Now windows opened by the DOM can be closed by JS.
 414
 415         * DumpRenderTree/DumpRenderTree.m:
 416         (+[LayoutTestController isSelectorExcludedFromWebScript:]):
 417         (-[LayoutTestController windowCount]):
 418
 419 2007-05-15  Adam Roben  <aroben@apple.com>
 420
 421         Reviewed by David Kilzer.
 422
 423         http://bugs.webkit.org/show_bug.cgi?id=13732
 424         prepare-ChangeLog should work with git
 425
 426         * Scripts/prepare-ChangeLog: Added support for Git.
 427
 428 2007-05-15  Lars Knoll <lars@trolltech.com>
 429
 430         Reviewed by Zack
 431
 432         Add the EventSender object to DRT. Currently it implements
 433         mouseDown, mouseUp and mouseMoveTo.
 434
 435         Make run-webkit-tests --strict work somewhat better for form elements.
 436
 437         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
 438         (WebCore::DumpRenderTree::DumpRenderTree):
 439         (WebCore::DumpRenderTree::initJSObjects):
 440         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
 441         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
 442         (HackWebFrame::mousePressEvent):
 443         (HackWebFrame::mouseReleaseEvent):
 444         (EventSender::EventSender):
 445         (EventSender::mouseDown):
 446         (EventSender::mouseUp):
 447         (EventSender::mouseMoveTo):
 448         (EventSender::leapForward):
 449         (EventSender::keyDown):
 450         (EventSender::frameUnderMouse):
 451         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
 452         * Scripts/run-webkit-tests:
 453
 454 2007-05-12  Oliver Hunt  <oliver@apple.com>
 455
 456         Reviewed by Hyatt.
 457
 458         Add new api to DRT to allow us to test a file being dragged
 459         onto <input type="file">
 460
 461         * DumpRenderTree/DumpRenderTree.h:
 462         * DumpRenderTree/DumpRenderTree.m:
 463         (+[LayoutTestController isSelectorExcludedFromWebScript:]):
 464         (-[LayoutTestController addFileToPasteboardOnDrag]):
 465         (runTest):
 466         * DumpRenderTree/UIDelegate.m:
 467         (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]):
 468
 469 2007-05-11  Holger Hans Peter Freyther  <zecke@selfish.org>
 470
 471         Reviewed by Maciej.
 472
 473         Bug 13656: [gdk] Resize the drawing area of the GdkLauncher
 474         http://bugs.webkit.org/show_bug.cgi?id=13656
 475
 476         * GdkLauncher/main.cpp: Handle resizing the drawing area
 477         (frameResizeCallback):
 478         (main):
 479
 480 2007-05-11  Geoffrey Garen  <ggaren@apple.com>
 481
 482         Reviewed by Darin Adler.
 483
 484         Updated test now that +[WebScriptObject scriptObjectForJSObject:frame:]
 485         is gone.
 486
 487         * DumpRenderTree/DumpRenderTree.m:
 488         (-[WaitUntilDoneDelegate webView:didClearWindowObject:forFrame:]):
 489         (+[LayoutTestController isSelectorExcludedFromWebScript:]):
 490         (+[LayoutTestController webScriptNameForSelector:]):
 491         (-[LayoutTestController testWrapperRoundTripping:]):
 492
 493 2007-05-08  Maciej Stachowiak  <mjs@apple.com>
 494
 495         Reviewed by Oliver.
 496
 497         - don't clear events whenever an EventSendingController goes away, only do it at predictable times,
 498         since destroying a subframe can make one go away
 499
 500         (Discovered while fixing:
 501
 502         <rdar://problem/5063277> blank screen after login to Citibank Online (accessing document before frame starts loading cancels load)
 503         <rdar://problem/5159541> REGRESSION (r20972): Wall Street Journal pages replaced by advertisements (13465)
 504
 505         * DumpRenderTree/DumpRenderTree.m:
 506         (runTest): explicitly clear saved events after every page load
 507         * DumpRenderTree/EventSendingController.h:
 508         * DumpRenderTree/EventSendingController.m:
 509         (-[EventSendingController dealloc]): don't clear saved events here...
 510         (+[EventSendingController clearSavedEvents]): do it here
 511         * Scripts/check-for-global-initializers:
 512
 513 2007-05-10  Mark Rowe  <mrowe@apple.com>
 514
 515         Build fix for DumpRenderTree. Enable Objective-C exceptions in Release configuration.
 516
 517         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 518
 519 2007-05-09  Geoffrey Garen  <ggaren@apple.com>
 520
 521         Reviewed by Maciej Stachowiak.
 522
 523         Added support for testing ObjC/JS type bridging.
 524
 525         Added ASSERT that -JSObject returns nil when the underlying JSObject
 526         is no longer GC protected.
 527
 528         * DumpRenderTree/DumpRenderTree.m:
 529         (returnThisCallback):
 530         (returnThisClass):
 531         (-[WaitUntilDoneDelegate webView:didClearWindowObject:forFrame:]):
 532         (+[LayoutTestController isSelectorExcludedFromWebScript:]):
 533         (+[LayoutTestController webScriptNameForSelector:]):
 534         (-[LayoutTestController accessStoredWebScriptObject]):
 535         (-[LayoutTestController testWrapperRoundTripping]):
 536         (-[LayoutTestController objCClassNameOf:]):
 537         (-[LayoutTestController objCObjectOfClass:]):
 538         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 539
 540 2007-05-10  Lars Knoll <lars@trolltech.com>
 541
 542         Reviewed by Simon
 543
 544         Move setting of the DPI value a few lines up. Should fix
 545         the last two remaining failures in the layout tests.
 546
 547         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
 548         (main):
 549
 550 2007-05-09  Holger Freyther <zecke@selfish.org>
 551
 552         Reviewed by Mark Rowe.
 553
 554         * GdkLauncher/main.cpp: Always include config.h.
 555
 556 2007-05-08  Geoffrey Garen  <ggaren@apple.com>
 557
 558         Reviewed by Darin Adler.
 559
 560         Added support for testing ObjC object identity.
 561
 562         Added ASSERT to verify that you can round-trip the object passed to you
 563         in -didClearWindowObject:forFrame:.
 564
 565         * DumpRenderTree/DumpRenderTree.m:
 566         (-[WaitUntilDoneDelegate webView:didClearWindowObject:forFrame:]):
 567         (+[LayoutTestController isSelectorExcludedFromWebScript:]):
 568         (+[LayoutTestController webScriptNameForSelector:]):
 569         (-[LayoutTestController accessStoredWebScriptObject]):
 570         (-[LayoutTestController objCIdentityIsEqual::]):
 571
 572 2007-05-07  Geoffrey Garen  <ggaren@apple.com>
 573
 574         Reviewed by Maciej Stachowiak.
 575
 576         Added tests for new APIs: -[WebFrame windowObject], -[WebFrame globalContext],
 577         and - (void)webView:(WebView *)webView didClearWindowObject:(WebScriptObject *)windowObject
 578         forFrame:(WebFrame *)frame, in the form of ASSERTs.
 579
 580         * DumpRenderTree/DumpRenderTree.m:
 581         (runJavaScriptThread): Fixed quote mismatch that prepare-changelog likes
 582         to complain about.
 583
 584         (-[WaitUntilDoneDelegate webView:windowScriptObjectAvailable:]):
 585         (-[WaitUntilDoneDelegate webView:didClearWindowObject:forFrame:]):
 586         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 587
 588 2007-05-08  Lars Knoll <lars@trolltech.com>
 589
 590         Reviewed by Zack.
 591
 592         Dump JavaScript console messages as well. Also requires a slight
 593         change in run-webkit-tests, so we still correctly differentiate
 594         between text only and rendertree tests.
 595
 596         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
 597         (WebCore::WebPage::WebPage):
 598         (WebCore::WebPage::javaScriptConsoleMessage):
 599         (WebCore::DumpRenderTree::DumpRenderTree):
 600         (WebCore::DumpRenderTree::dump):
 601         * Scripts/run-webkit-tests:
 602
 603 2007-05-08  Lars Knoll <lars@trolltech.com>
 604
 605         Reviewed by Zack
 606
 607         Specify what the serif, sans-serif and monospace aliases
 608         should map to and explicitly select the Gui style of
 609         DRT to be plastique.
 610
 611         Fixes most of the test failures still seen on the build bot.
 612
 613         * DumpRenderTree/DumpRenderTree.qtproj/fonts.conf:
 614         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
 615         (main):
 616
 617 2007-05-07  Lars Knoll <lars@trolltech.com>
 618
 619         Reviewed by Zack
 620
 621         Fix the default font to 9pt Sans Serif.
 622
 623         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
 624         (main):
 625
 626 2007-05-04  Lars Knoll <lars@trolltech.com>
 627
 628         Reviewed by Zack
 629
 630         Revert on line of the last commit. We still want to keep the RPATH
 631         support in the pro file.
 632
 633         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro:
 634
 635 2007-05-04  Lars Knoll <lars@trolltech.com>
 636
 637         Reviewed by Zack
 638
 639         Remove the old bitmap fonts I tried using to get reliable results from
 640         DumpRenderTree on X11. Instead we now use the URW Type1 fonts from
 641         ghostscript. I've added a mirror to simply check them out at
 642         svn://labs.trolltech.com/svn/webkit/testfonts.
 643
 644         Fixed DumpRenderTree to make sure these fonts are the only ones we use
 645         on X11 and added a fonts.conf file to get a well defined fontconfig
 646         configuration.
 647
 648         Made sure run-webkit-tests forwards the WEBKIT_TESTFONTS environment variable
 649         I use to find the fonts to DumpRenderTree.
 650
 651         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro:
 652         * DumpRenderTree/DumpRenderTree.qtproj/fontoverload.cpp: Removed.
 653         * DumpRenderTree/DumpRenderTree.qtproj/fonts/COPYING: Removed.
 654         * DumpRenderTree/DumpRenderTree.qtproj/fonts/CourierBold.ttf: Removed.
 655         * DumpRenderTree/DumpRenderTree.qtproj/fonts/CourierBoldOblique.ttf: Removed.
 656         * DumpRenderTree/DumpRenderTree.qtproj/fonts/CourierMedium.ttf: Removed.
 657         * DumpRenderTree/DumpRenderTree.qtproj/fonts/CourierMediumOblique.ttf: Removed.
 658         * DumpRenderTree/DumpRenderTree.qtproj/fonts/HelveticaBold.ttf: Removed.
 659         * DumpRenderTree/DumpRenderTree.qtproj/fonts/HelveticaBoldOblique.ttf: Removed.
 660         * DumpRenderTree/DumpRenderTree.qtproj/fonts/HelveticaMedium.ttf: Removed.
 661         * DumpRenderTree/DumpRenderTree.qtproj/fonts/HelveticaMediumOblique.ttf: Removed.
 662         * DumpRenderTree/DumpRenderTree.qtproj/fonts/SymbolMedium.ttf: Removed.
 663         * DumpRenderTree/DumpRenderTree.qtproj/fonts/TimesBold.ttf: Removed.
 664         * DumpRenderTree/DumpRenderTree.qtproj/fonts/TimesBoldItalic.ttf: Removed.
 665         * DumpRenderTree/DumpRenderTree.qtproj/fonts/TimesMedium.ttf: Removed.
 666         * DumpRenderTree/DumpRenderTree.qtproj/fonts/TimesMediumItalic.ttf: Removed.
 667         * DumpRenderTree/DumpRenderTree.qtproj/fonts.conf: Added.
 668         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
 669         (main):
 670         * Scripts/run-webkit-tests:
 671
 672 2007-05-03  Holger Freyther <freyther@kde.org>
 673
 674         Reviewed by Zack, landed by Simon.
 675         This is bugzilla bug 13499.
 676
 677         * GdkLauncher/GdkLauncher.pro: Build the GdkLauncher using qmake
 678         * GdkLauncher/main.cpp: We don't have a config.h with the qmake build
 679         * Scripts/build-webkit: Add --gdk for the Gdk port
 680         * Scripts/webkitdirs.pm: Add helper methods for the Gdk port
 681
 682 2007-05-03  Geoffrey Garen  <ggaren@apple.com>
 683
 684         Build fix: Add AllInOneFile.o to the ignore list, since it includes files
 685         in the ignore list.
 686
 687         * Scripts/check-for-global-initializers:
 688
 689 2007-05-02  Holger Freyther <freyther@kde.org>
 690
 691         Reviewed by Mark Rowe.
 692
 693         * Scripts/build-webkit: Remove the CMake call.
 694         * Scripts/webkitdirs.pm: Remove isQtWithQMake as QMake is now the only
 695         buildsystem for the Qt port.
 696
 697 2007-04-27  Kevin McCullough  <kmccullough@apple.com>
 698
 699         - Removed debugging statements and took out the removal of the deletion
 700           of the symlink.  This is because multiple instances of run-webkit-tests
 701           can be running at the same time.
 702         * Scripts/run-webkit-tests:
 703
 704 2007-04-27  Adam Roben <aroben@apple.com>
 705
 706         Reviewed by Maciej.
 707
 708         Cleaned up prepare-ChangeLog
 709
 710         * Scripts/prepare-ChangeLog: No code changes, but style now matches
 711         the prevalent style of our perl scripts.
 712
 713 2007-04-27  Nazar Kulyk  <schamane@myeburg.net>
 714
 715         Reviewed by Mark Rowe.
 716
 717         Basic auto-correction of user-entered URLs.
 718
 719         * GdkLauncher/main.cpp:
 720         (autocorrectURL):
 721         (goToURLBarText):
 722         (main):
 723
 724 2007-04-28  Mark Rowe  <mrowe@apple.com>
 725
 726         Rubber-stamped by Anders.
 727
 728         Rename some methods and variables to match the style guidelines.
 729
 730         * GdkLauncher/main.cpp:
 731         (stringIsEmpty):
 732         (stringIsEqual):
 733         (goToURLBarText):
 734         (goButtonClickedCallback):
 735         (urlBarEnterCallback):
 736         (frameResizeCallback):
 737         (frameDestroyCallback):
 738         (menuMainBackCallback):
 739         (menuMainForwardCallback):
 740         (menuMainQuitCallback):
 741         (main):
 742
 743 2007-04-27  Holger Freyther <freyther@kde.org>
 744
 745         Reviewed by Maciej.
 746
 747         Remove unmaintained CMake build system.
 748
 749         * DumpRenderTree/DumpRenderTree.qtproj/CMakeLists.txt: Removed.
 750         * Scripts/build-webkit: Remove references to CMake.
 751         * Scripts/webkitdirs.pm: Remove references to CMake.
 752
 753 2007-04-26  Alp Toker  <alp@atoker.com>
 754
 755         Reviewed by Mark Rowe.
 756
 757         * GdkLauncher/main.cpp:
 758         (main): Avoid use of deprecated API.
 759
 760 2007-04-26  Kevin McCullough  <kmccullough@apple.com>
 761
 762         - Changed debugging statements for more information.
 763
 764         * Scripts/run-webkit-tests:
 765
 766 2007-04-26  Kevin McCullough  <kmccullough@apple.com>
 767
 768         - Adding debugging statements to see why these tests fail.  These will be removed.
 769
 770         * Scripts/run-webkit-tests:
 771
 772 2007-04-25  Anders Carlsson  <andersca@apple.com>
 773
 774         Reviewed by Mitz.
 775
 776         Add a setUseDashboardCompatibilityMode method to LayoutTestController which is used to toggle
 777         the dashboard compatibility mode.
 778
 779         * DumpRenderTree/DumpRenderTree.m:
 780         (+[LayoutTestController isSelectorExcludedFromWebScript:]):
 781         (+[LayoutTestController webScriptNameForSelector:]):
 782         (-[LayoutTestController setUseDashboardCompatibilityMode:]):
 783         (runTest):
 784         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 785
 786 2007-04-24  Timothy Hatcher  <timothy@apple.com>
 787
 788         Setting the valid architectures to 32-bit only, so these projects
 789         will ignore requests to build them 64-bit. Once they can be built 64-bit,
 790         the valid architectures can be updated.
 791
 792         * Drosera/Drosera.xcodeproj/project.pbxproj:
 793         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 794
 795 2007-04-23  Adam Roben  <aroben@apple.com>
 796
 797         Reviewed by Mark Rowe and David Kilzer.
 798
 799         * Scripts/build-webkit: Print the path to the run-safari script when
 800         finished building so that users can copy-and-paste the command to
 801         execute it.
 802
 803 2007-04-23  Darin Adler  <darin@apple.com>
 804
 805         Reviewed by Hyatt.
 806
 807         - rename box-sizing to -webkit-box-sizing
 808
 809         * Drosera/console.css: Here.
 810         * Drosera/debugger.css: And here.
 811         * Drosera/viewer.css: And here.
 812
 813 2007-04-21  Mitz Pettel  <mitz@webkit.org>
 814
 815         Reviewed by Darin.
 816
 817         - http://bugs.webkit.org/show_bug.cgi?id=13350
 818           Build Ahem into DumpRenderTree
 819
 820         * DumpRenderTree/DumpRenderTree.m:
 821         (activateAhemFont): Added. Activates the copy of Ahem included in the
 822         DumpRenderTree binary.
 823         (dumpRenderTree): Replaced the check that Ahem is available with a call
 824         to activateAhemFont().
 825         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 826           Added linker options to include Ahem in the data section of the
 827           DumpRenderTree binary.
 828
 829 2007-04-20  Adam Roben  <aroben@apple.com>
 830
 831         Reviewed by Darin.
 832
 833         http://bugs.webkit.org/show_bug.cgi?id=13421
 834         Bug 13421: prepare-ChangeLog should use svn-create-patch when spewing diffs
 835
 836         * Scripts/prepare-ChangeLog: Use svn-create-patch instead of svn diff.
 837
 838 2007-04-18  Brady Eidson  <beidson@apple.com>
 839
 840         Reviewed by Tim
 841
 842         <rdar://problem/5008925>
 843         Expose the NSURLConnection delegate willCacheResponse API to WebResourceLoadDelegate
 844
 845         * DumpRenderTree/ResourceLoadDelegate.m:
 846         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
 847           Add the willCacheResponse delegate call
 848
 849 2007-04-18  Adam Roben  <aroben@apple.com>
 850
 851         Reviewed by David Kilzer.
 852
 853         * Scripts/webkitdirs.pm:
 854         (sub setConfiguration): Added an optional argument to set the
 855         configuration instead of parsing it from ARGV.
 856
 857 2007-04-17  Adam Roben  <aroben@apple.com>
 858
 859         * Scripts/find-included-framework-headers: Search Obj-C and Obj-C++
 860         files as well.
 861
 862 2007-04-17  Adam Roben  <aroben@apple.com>
 863
 864         Added a simple shell script to find all the headers from a specified
 865         framework or frameworks that are included by files beneath the working
 866         directory.
 867
 868         * Scripts/find-included-framework-headers: Added.
 869
 870 2007-04-16  Timothy Hatcher  <timothy@apple.com>
 871
 872         * Drosera/debugger.css: hide the borders for iframes
 873
 874 2007-04-13  Adam Roben  <aroben@apple.com>
 875
 876         Rubberstamped by Anders.
 877
 878         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: #include
 879         stdio.h so that snprintf is defined.
 880
 881 2007-04-13  Brady Eidson  <beidson@apple.com>
 882
 883         Reviewed by Anders
 884
 885         Add the ability to dump the back/forward history of all windows open at the end of a test
 886
 887         * DumpRenderTree/DumpRenderTree.m:
 888         (dumpBackForwardListForWebView): Dump B/F list for the given WebView
 889         (dump): Call dumpBackForwardListForWebView for each WebView open after the test
 890
 891 2007-04-13  Anders Carlsson  <andersca@apple.com>
 892
 893         Reviewed by Brady.
 894
 895         By default, close any windows that have been opened during a test. This can be overridden by
 896         calling setCloseRemainingWindowsWhenComplete(false).
 897
 898         Change the windows set to an array so we can gurantee the enumeration order.
 899
 900         * DumpRenderTree/DumpRenderTree.m:
 901         (+[LayoutTestController isSelectorExcludedFromWebScript:]):
 902         (+[LayoutTestController webScriptNameForSelector:]):
 903         (-[LayoutTestController setCloseRemainingWindowsWhenComplete:]):
 904         (runTest):
 905         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
 906         (-[DumpRenderTreeWindow dealloc]):
 907
 908 2007-04-13  Geoffrey Garen  <ggaren@apple.com>
 909
 910         Build fix.
 911
 912         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
 913         (handleCallback): Explicitly cast the void* returned by malloc.
 914
 915 2007-04-12  Deneb Meketa  <dmeketa@adobe.com>
 916
 917         Reviewed by Darin Adler.
 918
 919         http://bugs.webkit.org/show_bug.cgi?id=13029
 920         rdar://problem/4994849
 921         Bug 13029: Permit NPAPI plug-ins to see HTTP response headers.
 922         Changes in WebKitTools are only for the NPAPI test plugin.
 923
 924         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: main test logic.
 925         (pluginInvoke): support null window argument for NPStream creation.
 926         (pluginAllocate): initialization.
 927         (pluginDeallocate): cleanup.
 928         (handleCallback): add second JS callback arg: header dump.
 929         (notifyStream): added; hook from NPP_NewStream to record headers.
 930         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: declarations.
 931         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: call new header hook.
 932         (NPP_NewStream): call new header hook.
 933
 934 2007-04-09  Geoffrey Garen  <ggaren@apple.com>
 935
 936         Reviewed by Maciej Stachowiak.
 937
 938         Fixed fast/forms/textarea-paste-newline.html.
 939
 940         This failure was pretty funny. run-webkit-tests kills and respawns
 941         DumpRenderTree once every 1000 runs. Adding a few tests caused
 942         textarea-paste-newline.html to run right at the beginning of DumpRenderTree's
 943         lifetime, before any render tree dumps had occurred. However, WebCore
 944         used a render tree dump as the hook that set a global flag to allow
 945         pasting through the DOM API, so running before any render tree dumps had
 946         occurred caused this test to fail.
 947
 948         * DumpRenderTree/DumpRenderTree.m:
 949         (dumpRenderTree): Explicitly tell WebKit to allow pasting through the DOM
 950         API, instead of hoping it will read the tea leaves.
 951
 952 2007-04-07  Mark Rowe  <mrowe@apple.com>
 953
 954         Not reviewed.  Update to match some configuration changes that have been active on build.webkit.org.
 955
 956         * BuildSlaveSupport/build.webkit.org-config/webkit/status.py:
 957
 958 2007-04-05  Anders Carlsson  <andersca@apple.com>
 959
 960         Reviewed by Adam.
 961
 962         Add support for opening new windows in DumpRenderTree.
 963
 964         (+[LayoutTestController isSelectorExcludedFromWebScript:]):
 965         (+[LayoutTestController webScriptNameForSelector:]):
 966         (-[LayoutTestController setCallCloseOnWebViews:]):
 967         (-[LayoutTestController setCanOpenWindows]):
 968         Add two new methods callable from JavaScript. setCanOpenWindows controls whether a test
 969         can open new windows, and setCallCloseOnWebViews controls whether -[WebView close] should be called on
 970         web views that are about to be closed.
 971
 972         (runTest):
 973         Make sure that only the main window is around when a test has finished running.
 974
 975         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
 976         (-[DumpRenderTreeWindow dealloc]):
 977         Manage the set of windows.
 978
 979         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
 980         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
 981         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c:
 982         (NPP_Destroy):
 983         Add a "logDestroy" property which controls whether plugins should print when they are destroyed or not.
 984
 985         * DumpRenderTree/UIDelegate.m:
 986         (-[UIDelegate webView:createWebViewWithRequest:]):
 987         Create new windows.
 988
 989         (-[UIDelegate webViewClose:]):
 990         Close windows.
 991
 992 2007-04-05  Anders Carlsson  <andersca@apple.com>
 993
 994         Reviewed by Maciej.
 995
 996         Move WebView and NSWindow creation to a separate function in preparation of supporting opening new
 997         windows in DRT.
 998
 999         * DumpRenderTree/DumpRenderTree.m:
1000         (createWebView):
1001         (dumpRenderTree):
1002
1003 2007-04-03  Anders Carlsson  <andersca@apple.com>
1004
1005         Reviewed by Darin.
1006
1007         Add the notion of a "disallowed URL", which the resource loader won't allow to be loaded.
1008
1009         * DumpRenderTree/DumpRenderTree.h:
1010         * DumpRenderTree/DumpRenderTree.m:
1011         (dumpRenderTree):
1012         (+[LayoutTestController isSelectorExcludedFromWebScript:]):
1013         (+[LayoutTestController webScriptNameForSelector:]):
1014         (-[LayoutTestController addDisallowedURL:]):
1015         (runTest):
1016         * DumpRenderTree/ResourceLoadDelegate.m:
1017         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1018
1019 2007-04-03  Mark Rowe  <mrowe@apple.com>
1020
1021         Reviewed by Antti.
1022
1023         * BuildSlaveSupport/build-launcher-dmg: Use bzip2 compression in nightly build disk images rather than gzip.
1024
1025 2007-04-02  Anders Carlsson  <andersca@apple.com>
1026
1027         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
1028         Don't use #import in a header included by C files.
1029
1030 2007-03-31  Mark Rowe  <mrowe@apple.com>
1031
1032         Reviewed by Mitz.
1033
1034         Fix http://bugs.webkit.org/show_bug.cgi?id=13239
1035         Bug 13239: REGRESSION (r20343): Drosera hits exception trying to call "count" cross-process
1036
1037         Use -[WebScriptObject valueForKey:@"length"] to retrieve the length of a JavaScript array
1038         rather than -[WebScriptObject count].
1039
1040         * Drosera/DebuggerDocument.m:
1041         (-[DebuggerDocument webScriptAttributeKeysForScriptObject:]):
1042
1043 2007-03-30  Anders Carlsson  <andersca@apple.com>
1044
1045         Reviewed by Geoff.
1046
1047         Add an "onstreamload" attribute to the plugin which is called when a stream starts loading.
1048
1049         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
1050         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c:
1051         (NPP_New):
1052         Look for the onstreamload attribute.
1053
1054         (NPP_Destroy):
1055         Free the onstreamload attribute.
1056
1057         (NPP_NewStream):
1058         Call the onstreamload handler.
1059
1060 2007-03-30  Geoffrey Garen  <ggaren@apple.com>
1061
1062         Removing an assertion I just added because it's crashing the Leopard
1063         buildbot. The related layout test will still report a failure, so we
1064         don't really need this assertion.
1065
1066         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
1067         (pluginInvoke):
1068
1069 2007-03-30  Anders Carlsson  <andersca@apple.com>
1070
1071         Reviewed by Geoff.
1072
1073         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c:
1074         (testAllocate):
1075         (testEnumerate):
1076         Add casts.
1077
1078         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.h:
1079         Don't use #import, use #include.
1080
1081 2007-03-30  Anders Carlsson  <andersca@apple.com>
1082
1083         Reviewed by Alexey.
1084
1085         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
1086         (pluginInvoke):
1087         Free the identifier string.
1088
1089 2007-03-30  Anders Carlsson  <andersca@apple.com>
1090
1091         Reviewed by Geoff.
1092
1093         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1094         Add TestObject.c and TestObject.h
1095
1096         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
1097         (pluginGetProperty):
1098         Implement the testObject property.
1099
1100         (pluginInvoke):
1101         Implement testEnumerate which takes an object and an array and enumerates
1102         the properties of the object and adds them to the array.
1103
1104         (pluginAllocate):
1105         Allocate the test object.
1106
1107         (pluginDeallocate):
1108         Free the test object.
1109
1110         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Added.
1111         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.h: Added.
1112         Add a test object with two enumerable properties.
1113
1114 2007-03-29  Geoffrey Garen  <ggaren@apple.com>
1115
1116         Reviewed by Beth Dakin.
1117
1118         Layout test for <rdar://problem/5091330> REGRESSION: Repro crash in
1119         -[WebBaseNetscapePluginView(WebNPPCallbacks) destroyStream:reason:]
1120         navigating away from page with DivX movie plug-in (13203)
1121
1122         Added hasStream property and destroyStream function, used by layout test.
1123
1124         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
1125         (pluginGetProperty):
1126         (pluginInvoke):
1127         (pluginAllocate):
1128         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
1129         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c:
1130         (NPP_NewStream):
1131
1132 2007-03-27  Anders Carlsson  <acarlsson@apple.com>
1133
1134         Reviewed by Geoff.
1135
1136         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
1137         (pluginInvoke):
1138         Add new function which takes a function and calls it using NPN_InvokeDefault.
1139
1140 2007-03-27  Adele Peterson  <adele@apple.com>
1141
1142         Adding comment.
1143
1144         * DumpRenderTree/DumpRenderTree.m:
1145         (-[WaitUntilDoneDelegate webView:didFinishLoadForFrame:]):
1146
1147 2007-03-27  Adele Peterson  <adele@apple.com>
1148
1149         Fix svg tests by calling displayIfNeeded.
1150
1151         * DumpRenderTree/DumpRenderTree.m:
1152         (-[WaitUntilDoneDelegate webView:didFinishLoadForFrame:]):
1153
1154 2007-03-26  Mark Rowe  <mrowe@apple.com>
1155
1156         Reviewed by Sam Weinig.
1157
1158         Upload crash logs from DumpRenderTree as part of the test results to ease debugging
1159         of hard-to-reproduce crashes.
1160
1161         * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
1162
1163 2007-03-23  Adam Treat  <adam@staikos.net>
1164
1165         Reviewed and committed by George.
1166
1167         Patch by Adam Treat.  Removes hardcoded path to .pro file.
1168
1169 2007-03-22  Adam Roben  <aroben@apple.com>
1170
1171         Reviewed by Geoff.
1172
1173         Removed eventSender.mouseClick because it was only useful for AppKit
1174         controls, which we don't use anymore.
1175
1176         * DumpRenderTree/EventSendingController.m:
1177         (+[EventSendingController isSelectorExcludedFromWebScript:]): Removed
1178         mouseClick.
1179
1180 2007-03-22  Adam Roben  <aroben@apple.com>
1181
1182         Reviewed by Ada.
1183
1184         Make eventSender.mouseClick actually send a mouse up event.
1185
1186         * DumpRenderTree/EventSendingController.m:
1187         (-[EventSendingController mouseClick]):
1188
1189 2007-03-19  David Hyatt  <hyatt@apple.com>
1190
1191         Update the minimum font size pref to match the actual default setting in Safari.  It should have been 1
1192         all this time and not 9.
1193
1194         Reviewed by aroben
1195
1196         * DumpRenderTree/DumpRenderTree.m:
1197         (dumpRenderTree):
1198
1199 2007-03-18  Dan Waylonis  <waylonis@mac.com>
1200
1201         Reviewed by Tim Hatcher.
1202
1203         DumpRenderTree changes for http://bugs.webkit.org/show_bug.cgi?id=13005
1204         Bug 13005: WebScriptObject +throwException needs NULL check.
1205
1206         Add tests to ensure that a plugin can safely throw an exception in dealloc.
1207
1208         * DumpRenderTree/ObjCPlugin.h:
1209         * DumpRenderTree/ObjCPlugin.m:
1210         (+[ObjCPlugin webScriptNameForKey:]):
1211         (+[ObjCPlugin isKeyExcludedFromWebScript:]):
1212         (-[ObjCPlugin dealloc]):
1213
1214 2007-03-13  Mark Rowe  <mrowe@apple.com>
1215
1216         Reviewed by Maciej.
1217
1218         Have the nightly launcher prefer Safari found in /Applications or ~/Applications
1219         if present, otherwise fall back on using LaunchServices to locate it elsewhere
1220         on the system.  The motivation for this is to make the behaviour of the nightly
1221         builds more predictable on machines with multiple copies of Safari present.
1222
1223         * WebKitLauncher/main.m:
1224         (locateSafariBundle):
1225         (main):
1226
1227 2007-03-12  Darin Adler  <darin@apple.com>
1228
1229         Reviewed by Tim Hatcher.
1230
1231         - add a DumpRenderTree feature where you can get the Objective-C
1232           class name of a JavaScript object
1233
1234         * DumpRenderTree/DumpRenderTree.m:
1235         (+[LayoutTestController isSelectorExcludedFromWebScript:]): Add the
1236         objCClassNameOf: selector.
1237         (+[LayoutTestController webScriptNameForSelector:]): Add the
1238         objCClassNameOf: selector, with the name "objCClassName".
1239         (-[LayoutTestController objCClassNameOf:]): Added.
1240
1241 2007-03-11  Geoffrey Garen  <ggaren@apple.com>
1242
1243         Reviewed by Oliver Hunt.
1244
1245         Beefed up --threaded mode in light of <rdar://problem/4681051> Installer
1246         crashes in KJS::Collector::markOtherThreadConservatively(KJS::Collector::Thread*)
1247         trying to install iLife 06 using Rosetta on an Intel Machine
1248
1249         --threaded mode now runs a bunch of different JavaScript threads, randomly
1250         killing and respawning them. This was sufficient for reproducing the
1251         bug on my MacBook Pro.
1252
1253         * DumpRenderTree/DumpRenderTree.m:
1254         (javaScriptThreads):
1255         (runJavaScriptThread):
1256         (startJavaScriptThreads):
1257         (stopJavaScriptThreads):
1258         (dumpRenderTree):
1259
1260 2007-03-11  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
1261
1262         Reviewed by Brady Eidson.
1263
1264         Add forward/backward/quit menus for easier testing.
1265
1266         * GdkLauncher/main.cpp:
1267         (menuMainBackCb):
1268         (menuMainForwardCb):
1269         (menuMainQuitCb):
1270         (main):
1271
1272 2007-03-09  Andrew Wellington  <proton@wiretapped.net>
1273
1274         Reviewed by Darin.
1275
1276         - fix http://bugs.webkit.org/show_bug.cgi?id=13007
1277           svn-create-patch doesn't handle UTF files with BOMs as text
1278
1279         Force diff to treat files that svn-create-patch thinks are text as text.
1280
1281         * Scripts/svn-create-patch: Added -a switch to diff command.
1282
1283 2007-03-09  Mark Rowe  <mrowe@apple.com>
1284
1285         Unreviewed.  Use the new SVN URL on the buildbot.
1286
1287         * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
1288
1289 2007-03-08  Mark Rowe  <mrowe@apple.com>
1290
1291         Reviewed by Antti.
1292
1293         Fix compiler warnings when building Drosera as 64-bit.
1294
1295         * Drosera/DebuggerDocument.m:
1296         (-[DebuggerDocument breakpointEditorHTML]): Move away from deprecated NSString method.
1297         (-[DebuggerDocument scriptConfirmSheetDidEnd:returnCode:contextInfo:]): Update type.
1298         (-[DebuggerDocument webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]): Update type to accommodate constant.
1299
1300 2007-03-07  Mark Rowe  <mrowe@apple.com>
1301
1302         Reviewed by Maciej.
1303
1304         Update check-for-global-initializers to ignore new debug initializers in bidi.o and kjs_events.o.
1305
1306         * Scripts/check-for-global-initializers:
1307
1308 2007-03-07  Anders Carlsson  <acarlsson@apple.com>
1309
1310         Reviewed by Adam.
1311
1312         Add some assertions.
1313
1314         * DumpRenderTree/DumpRenderTree.m:
1315         (-[WaitUntilDoneDelegate webView:didStartProvisionalLoadForFrame:]):
1316         (-[WaitUntilDoneDelegate webView:didCommitLoadForFrame:]):
1317         (-[WaitUntilDoneDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1318         (-[WaitUntilDoneDelegate webView:didFailLoadWithError:forFrame:]):
1319
1320 2007-03-07  David Kilzer  <ddkilzer@webkit.org>
1321
1322         Reviewed by Darin.
1323
1324         - WebKitTools part of fix for http://bugs.webkit.org/show_bug.cgi?id=12463
1325           WebArchiver - attempt to insert nil exception when archive empty iframe
1326
1327         The dumpDOMAsWebArchive() test method uses the DOMDocument as a basis for creating
1328         a webarchive while the dumpSourceAsWebArchive() test method uses the original
1329         dataSource (page source) to create a webarchive.  Most tests currently use
1330         dumpDOMAsWebArchive() since this is what Safari does when saving a web page as a
1331         webarchive.
1332
1333         * DumpRenderTree/DumpRenderTree.m: Renamed dumpAsWebArchive to dumpDOMAsWebArchive.
1334         Added dumpSourceAsWebArchive.
1335         (dump):
1336         (+[LayoutTestController isSelectorExcludedFromWebScript:]):
1337         (-[LayoutTestController dumpDOMAsWebArchive]):
1338         (-[LayoutTestController dumpSourceAsWebArchive]):
1339         (runTest):
1340
1341 2007-03-05  Kevin McCullough  <kmccullough@apple.com>
1342
1343         Reviewed by Mark and Dave H.
1344
1345         - rdar://problem/4922454
1346         - This fixes a security issue by making remote referrers not able to access local
1347         resources, unless they register their schemes to be treated as local. The result is
1348         that those schemes can access local resources and cannot be accessed by remote
1349         referrers.
1350         Because this behavior is new a link-on-or-after check is made to determine if the
1351         app should use the older, less safe, behavior.
1352
1353         * DumpRenderTree/DumpRenderTree.m: Add ability to set user style sheet to DRT.
1354         (+[LayoutTestController isSelectorExcludedFromWebScript:]):
1355         (+[LayoutTestController webScriptNameForSelector:]):
1356         (-[LayoutTestController setUserStyleSheetLocation:]):
1357         (-[LayoutTestController setUserStyleSheetEnabled:]):
1358
1359 2007-03-05  Anders Carlsson  <acarlsson@apple.com>
1360
1361         Reviewed by Adam, Darin.
1362
1363         <rdar://problem/5025212>
1364         In Mail, a crash occurs at WebCore::Frame::tree() when clicking on embedded flash object
1365
1366         Add a "getURLNotify" method to the plugin object. This lets you pass a URL, a target and a callback function
1367         to be run when the URL has finished (or failed) loading.
1368
1369         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
1370         (pluginInvoke):
1371         (handleCallback):
1372         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
1373         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c:
1374         (NPP_URLNotify):
1375
1376 2007-03-04  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
1377
1378         Reviewed by Nikolas Zimmermann.
1379
1380         Load a url given on a command line in a way that also
1381         works for local (file://) urls.
1382
1383         * GdkLauncher/main.cpp:
1384         (main):
1385
1386 2007-03-02  Geoffrey Garen  <ggaren@apple.com>
1387
1388         Tweaked parse-malloc-history to work with new malloc_history output format.
1389
1390         * Scripts/parse-malloc-history:
1391
1392 2007-02-28  Vladimir Olexa  <vladimir.olexa@gmail.com>
1393
1394         Reviewed by Tim H.
1395
1396         Fixes: http://bugs.webkit.org/show_bug.cgi?id=12887
1397         Bug#12887: [Drosera] Add ability to close loaded files
1398
1399         * Drosera/DebuggerDocument.h:
1400         * Drosera/DebuggerDocument.m:
1401         (-[DebuggerDocument closeCurrentFile:]): Adds delegation to call a JS script to close files
1402         * Drosera/Drosera.xcodeproj/project.pbxproj:
1403         * Drosera/English.lproj/MainMenu.nib/classes.nib:
1404         * Drosera/English.lproj/MainMenu.nib/info.nib:
1405         * Drosera/English.lproj/MainMenu.nib/keyedobjects.nib: Adds Close Current File menu item
1406         * Drosera/debugger.html: Changed "no files loaded" to "<No files loaded>" to match Xcode style
1407         * Drosera/debugger.js: Adds implementation of closeFile() to unload currently loaded file
1408
1409 2007-02-28  Nikolas Zimmermann  <zimmermann@kde.org>
1410
1411         Reviewed by Maciej.
1412
1413         Add new flags to build-webkit to be able to switch on/off xpath, xslt, etc. easily.
1414
1415         * Scripts/build-webkit:
1416
1417 2007-02-27  Geoffrey Garen  <ggaren@apple.com>
1418
1419         Small tweak to run-webkit-tests.
1420
1421         * Scripts/run-webkit-tests: Allow people with lots of RAM to run more than
1422         1000 MallocStackLogging tests at a time.
1423
1424 2007-02-26  Maciej Stachowiak  <mjs@apple.com>
1425
1426         Reviewed by Lars.
1427
1428         - set ENABLE_XSLT even when compiling without SVG support, since that is no
1429         longer hardcoded into config.h.
1430
1431         * Scripts/build-webkit:
1432
1433 2007-02-26  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
1434
1435         Reviewed by Adam Roben.
1436
1437         Rename *_SUPPORT defines to ENABLE_*.
1438
1439         * GdkLauncher/gdklauncher.bkl:
1440
1441 2007-02-24  Geoffrey Garen  <ggaren@apple.com>
1442
1443         Reviewed by Darin Adler.
1444
1445         * Scripts/run-webkit-tests: Stop ignoring BidiRun leaks, now that they're
1446         fixed.
1447
1448 2007-02-24  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
1449
1450         Reviewed by Adam Roben.
1451
1452         Improve gdklauncher: add text field for entering url.
1453
1454         * GdkLauncher/gdklauncher.bkl:
1455         * GdkLauncher/main.cpp:
1456         (strEmpty):
1457         (strEq):
1458         (handleGdkEvent):
1459         (goToUrlBarText):
1460         (goButtonClickedCb):
1461         (urlBarEnterCb):
1462         (registerRenderingAreaEvents):
1463         (frameResizeCb):
1464         (frameDestroyCb):
1465         (main):
1466
1467 2007-02-22  Vladimir Olexa  <vladimir.olexa@gmail.com>
1468
1469         Reviewed by Tim H.
1470
1471         Fixes: http://bugs.webkit.org/show_bug.cgi?id=12852
1472         Bug#12852: Drosera should select function name, not "function" keyword when selecting from function list pop-up
1473         * Drosera/debugger.js: Fixed some logic errors resulting in generating double IDs and names.
1474
1475 2007-02-22  Adele Peterson  <adele@apple.com>
1476
1477         Reviewed by Darin.
1478
1479         Added option in layoutTestController to setTabKeyCyclesThroughElements, so we
1480         can test <rdar://problem/5014970> 9A374: Tabs don't work in the message body
1481
1482         * DumpRenderTree/DumpRenderTree.m:
1483         (+[LayoutTestController isSelectorExcludedFromWebScript:]):
1484         (+[LayoutTestController webScriptNameForSelector:]):
1485         (-[LayoutTestController setTabKeyCyclesThroughElements:]):
1486
1487 2007-02-22  Geoffrey Garen  <ggaren@apple.com>
1488
1489         Used svn merge -r19786:19785 to roll out previous hack to work around
1490         SVG painting issue in DRT.
1491
1492         Implemented new work-around, which makes --paint paint *after* dumping
1493         the render tree instead of before, so that painting doesn't influence
1494         the SVG render tree.
1495
1496         This should fix the ~400 new pixel failures introduced in r19786.
1497
1498         * DumpRenderTree/DumpRenderTree.m:
1499         (dump):
1500         * Scripts/run-webkit-tests:
1501
1502 2007-02-22  Geoffrey Garen  <ggaren@apple.com>
1503
1504         Resetting --leaks mode default to run 1000 tests at a time because setting it
1505         to 750 didn't stop the stack logging related crashes, and running more tests
1506         at a time is faster. The crashes seem to be a real bug in stack logging,
1507         not an out of memory condition.
1508
1509         * Scripts/run-webkit-tests:
1510
1511 2007-02-21  Geoffrey Garen  <ggaren@apple.com>
1512
1513         Reviewed by Adam Roben.
1514
1515         Added hack to force painting when running an SVG test. This is a work-around
1516         for http://bugs.webkit.org/show_bug.cgi?id=12849 SVG renderers update at
1517         paint time instead of style resolution time.
1518
1519         We need this so that --leaks mode, which always paints, doesn't appear to
1520         fail SVG tests. We also need this if we ever want to test style application
1521         in SVG, since many SVGs don't apply style to their renderers until they paint.
1522
1523         * Scripts/run-webkit-tests:
1524
1525 2007-02-21  Geoffrey Garen  <ggaren@apple.com>
1526
1527         Reduced --leaks mode to running only 750 tests at a time, in the hopes
1528         of fixing intermittent crasher that may be caused by out of memory
1529         conditions.
1530
1531         * Scripts/run-webkit-tests:
1532
1533 2007-02-21  Geoffrey Garen  <ggaren@apple.com>
1534
1535         Reviewed by Darin Adler.
1536
1537         Made DRT paint when running run-webkit-tests in --leaks mode, to check
1538         for painting leaks.
1539
1540         * DumpRenderTree/DumpRenderTree.m: Removed some "NO" initializations, since
1541         that's the default for statics.
1542         (dumpRenderTree): Added --paint command line option, which specifies that
1543         DRT should paint at the end of every test.
1544         (displayWebView): New function, called by dump() and -[LayoutTestController display].
1545         * Scripts/run-webkit-tests: Use the --paint command line option when checking
1546         for leaks.
1547
1548         * Scripts/run-webkit-tests: Added a new, painting leak to the ignore list.
1549         Removed stale comment about THRD leaks -- we now ignore them reliably.
1550
1551 2007-02-21  Geoffrey Garen  <ggaren@apple.com>
1552
1553         Tools tweak. No review necessary.
1554
1555         * Scripts/parse-malloc-history: Enabled multiple merge-regexp command line
1556         arguments. Changed command line argument variables from special implicit
1557         no-op values to specific empty values that we test explicitly.
1558
1559 2007-02-21  Vladimir Olexa  <vladimir.olexa@gmail.com>
1560
1561         Reviewed by Tim H.
1562
1563         Bug 12834: Drosera should remember scroll position of open files like Xcode
1564         http://bugs.webkit.org/show_bug.cgi?id=12834
1565
1566         * Drosera/debugger.js: Implemented scrolling memory
1567
1568 2007-02-20  Geoffrey Garen  <ggaren@apple.com>
1569
1570         Tools tweak. No review necessary.
1571
1572         Made parse-malloc-history executable. (Oops!)
1573
1574         Made parse-malloc-history parse 'leaks' output in addition to 'malloc_history"
1575         output.
1576
1577         Added the ability to merge callstacks by regexp, not just depth, so you
1578         can ask questions like, "How many of these allocations were due to that one
1579         call to ...?"
1580
1581         * Scripts/parse-malloc-history:
1582
1583 2007-02-20  Geoffrey Garen  <ggaren@apple.com>
1584
1585         * Scripts/parse-malloc-history: Added copyright info.
1586
1587 2007-02-20  Geoffrey Garen  <ggaren@apple.com>
1588
1589         Reviewed by Darin Adler.
1590
1591         New script to parse the output from malloc_history, so we can determine
1592         what's using memory in WebKit.
1593
1594         * Scripts/parse-malloc-history: Added.
1595
1596 2007-02-20  Graham Dennis  <graham.dennis@gmail.com>
1597
1598         Reviewed by Darin Adler.
1599
1600         Fix for http://bugs.webkit.org/show_bug.cgi?id=12802
1601         WebKit.framework is built with SVG_SUPPORT for No-SVG build
1602
1603         * Scripts/build-webkit: Pass the "FEATURE_DEFINES=" option when building WebKit as well.
1604
1605 2007-02-19  Geoffrey Garen  <ggaren@apple.com>
1606
1607         Build fix.
1608
1609         * Scripts/check-for-global-initializers: Ignore the global counter I added
1610         for SubresourceLoaders.
1611
1612 2007-02-19  Darin Adler  <darin@apple.com>
1613
1614         Reviewed by Tim Hatcher.
1615
1616         * Scripts/check-for-global-initializers: Delete the linked executable if the check fails.
1617         Without this, you only see the global initializer error once, which makes it very easy
1618         to miss them.
1619
1620 2007-02-16  Mark Rowe  <mrowe@apple.com>
1621
1622         Not reviewed.
1623
1624         <rdar://problem/4982312> leaks bot should run in normal mode, rather than quiet mode
1625
1626         * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py: Switch back to default verbosity for output of leaks tests.
1627
1628 2007-02-15  Geoffrey Garen  <ggaren@apple.com>
1629
1630         Reviewed by Beth Dakin.
1631
1632         * DumpRenderTree/DumpRenderTree.m: Don't ignore NSAttributedString WebCore::Node
1633         leaks anymore, either, since r19486 fixed them, too.
1634         (shouldIgnoreWebCoreNodeLeaks):
1635
1636 2007-02-15  Darin Adler  <darin@apple.com>
1637
1638         * Scripts/run-webkit-tests: Don't ignore NSAttributedString leaks any more. Those were
1639         fixed by change 19486.
1640
1641 2007-02-15  Geoffrey Garen  <ggaren@apple.com>
1642
1643         Reviewed by Beth Dakin.
1644
1645         Ignore another leak, seen recently on the buildbot.
1646
1647         * Scripts/run-webkit-tests:
1648
1649 2007-02-14  Geoffrey Garen  <ggaren@apple.com>
1650
1651         Reviewed by Beth Dakin.
1652
1653         Ignore another leak, seen recently on the buildbot.
1654
1655         * Scripts/run-webkit-tests:
1656
1657 2007-02-13  Darin Adler  <darin@apple.com>
1658
1659         * Scripts/run-webkit-tests: Fix a bug where --reset-results output would all go in one
1660         giant line.
1661
1662 2007-02-11  Maciej Stachowiak  <mjs@apple.com>
1663
1664         Reviewed by Mitz.
1665
1666         - add contextClick() operation to eventSender to be able to test this
1667
1668         * DumpRenderTree/EventSendingController.m:
1669         (+[EventSendingController isSelectorExcludedFromWebScript:]):
1670         (-[EventSendingController contextClick]):
1671
1672 2007-02-11  Darin Adler  <darin@apple.com>
1673
1674         * Scripts/check-for-global-initializers: Fix case where executable doesn't exist at all
1675         so it doesn't give a perl exception (happens in clean builds, for example).
1676
1677 2007-02-10  David Kilzer  <ddkilzer@webkit.org>
1678
1679         Reviewed by Adam.
1680
1681         * Scripts/svn-create-patch:
1682         (findSourceFileAndRevision($)): Use File::Spec->abs2rel() instead of substr() to generate
1683         a relative path to the copied file.
1684
1685 2007-02-10  Timothy Hatcher  <timothy@apple.com>
1686
1687         Reviewed by Sam Weinig.
1688
1689         * Drosera/Drosera.icns: updated the icon with 512px and 256px variants
1690
1691 2007-02-10  David Kilzer  <ddkilzer@webkit.org>
1692
1693         Reviewed by Timothy.
1694
1695         * Scripts/svn-apply:
1696         (handleBinaryChange($$)): Binary patches don't need a trailing newline after the base64
1697         encoded text.
1698
1699 2007-02-10  Brady Eidson <beidson@apple.com>
1700
1701         Reviewed by Maciej
1702
1703         <rdar://problem/4965133> WebKit sends file:// url referrers
1704
1705         * Scripts/run-webkit-tests: Enhanced the http tests so that we can run layout tests
1706           on local files, but have an httpd for remote resources
1707
1708 2007-02-08  Geoffrey Garen  <ggaren@apple.com>
1709
1710         Reviewed by Beth Dakin.
1711
1712         Ignore another false leak report.
1713
1714         * Scripts/run-webkit-tests:
1715
1716 2007-02-08  Geoffrey Garen  <ggaren@apple.com>
1717
1718         Reviewed by Kevin McCullough.
1719
1720         * Scripts/run-webkit-tests: Don't try to create /tmp/LayoutTests if it
1721         already exists, to avoid confusing error message.
1722
1723         Also, remove /tmp/LayoutTests after running so unsupecting fools don't
1724         try to rm -rf it, only later to discover that they have completely hosed
1725         their machines.
1726
1727 2007-02-08  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
1728
1729         Reviewed by Adam Roben.
1730
1731         Linux/gdk build fixes.
1732
1733         * GdkLauncher/main.cpp: Add -exit-after-loading and
1734         -dump-render-tree as debugging aid.
1735         (strEq):
1736         (main):
1737
1738 2007-02-08  Geoffrey Garen  <ggaren@apple.com>
1739
1740         Minor fixup based on Maciej's review last night.
1741
1742         * Scripts/run-webkit-tests: Use normal "increment at end of loop" behavior,
1743         and do a little math to make it work.
1744
1745 2007-02-08  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
1746
1747         Reviewed by Adam Roben.
1748
1749         Linux/gdk build fixes.
1750
1751         * GdkLauncher/gdklauncher.bkl:
1752
1753 2007-02-08  Kevin McCullough  <KMcCullough@apple.com>
1754
1755         - Fix layout test failures.
1756
1757         * Scripts/run-webkit-tests:
1758
1759 2007-02-08  Darin Adler  <darin@apple.com>
1760
1761         Reviewed by Anders.
1762
1763         * Scripts/check-for-global-initializers: For speed, only check files that
1764         have been modified since the last time we linked. For tidiness, capture
1765         stderr from nm, and prevent "nm: no name list" messages from going out.
1766
1767 2007-02-08  Geoffrey Garen  <ggaren@apple.com>
1768
1769         Reviewed by Maciej Stachowiak, Adam Roben.
1770
1771         Added 'nthly' support to run-webkit-tests. It's like 'singly', for an
1772         arbitrary number n.
1773
1774         Plus some renames:
1775             - DumpRenderTree => "dumpTool" (to match abstraction elsewhere)
1776             - checkLeaks => "shouldCheckLeaks" (to match style guidelines)
1777             - tool => dumpTool (to match abstraction elsewhere)
1778             - httpdOpen => isHttpdOpen (to match style guidelines)
1779
1780         Plus a few logic fixups:
1781             - Don't check isDumpToolOpen when we know we've called openDumpTool().
1782             - Use a single code path to decide when to shut down dumpTool and
1783               when to check for leaks, since the operations are coincidental.
1784             - Use a single code path for running the leaks tool, since the only
1785               thing that varies between configurations is the output file name.
1786             - Increment $count after each test finishes, instead of at the end
1787               of the loop, to help with comparing to the length of the array
1788               and %-ing by n.
1789             - Use a more robust test inside the loop to determine if we need to
1790               close dumpTool, instead of copying the closing code outside the loop.
1791
1792         Layout tests pass.
1793
1794         * Scripts/run-webkit-tests:
1795
1796 2007-02-06  Geoffrey Garen  <ggaren@apple.com>
1797
1798         Reviewed by Beth Dakin, evil twin to Bethany P. Dakin.
1799
1800         Ignore known leaks in CFRunLoop. Exclude THRD leaks by type so that we can
1801         catch all reports of them, not just those inside pthread_create.
1802
1803         Also, use "\\" instead of "\" because we need the actual \ to get into the
1804         regexp string if it's going to do any escaping. (Oops!)
1805
1806         * Scripts/run-webkit-tests:
1807
1808 2007-02-06  Geoffrey Garen  <ggaren@apple.com>
1809
1810         Reviewed by Bethany P. Dakin.
1811
1812         The 's' is optional when the leaks tool reports 'leaks'.
1813
1814         * Scripts/run-leaks:
1815
1816 2007-02-06  Geoffrey Garen  <ggaren@apple.com>
1817
1818         Reviewed by Bethany P. Dakin.
1819
1820         Hooked up run-webkit-tests to the run-leaks script. No change in behavior yet.
1821
1822         * Scripts/run-webkit-tests: Changed symbol names to valid regular expressions.
1823
1824 2007-02-06  David Smith  <catfish.man@gmail.com>
1825
1826         Reviewed by Darin.
1827
1828         Patch for http://bugs.webkit.org/show_bug.cgi?id=12566
1829         [Drosera] Console history fixups
1830
1831         * Drosera/console.js: assorted cleanups and fixes
1832
1833 2007-02-05  Geoffrey Garen  <ggaren@apple.com>
1834
1835         Reviewed by Darin Adler.
1836
1837         New script that allows you to ignore leaks by regular expression.
1838
1839         * Scripts/run-leaks: Added.
1840
1841 2007-02-03  Sam Weinig  <sam@webkit.org>
1842
1843         Reviewed by Mark.
1844
1845         Patch for http://bugs.webkit.org/show_bug.cgi?id=12555
1846         Drosera doesn't handle CR ( carriage returns ) well
1847
1848         - Normalize all the line endings.
1849
1850         * Drosera/debugger.js:
1851
1852 2007-02-02  Geoffrey Garen  <ggaren@apple.com>
1853
1854         Reviewed by Darin Adler.
1855
1856         Added some more known leaks to the leaks ignore list.
1857
1858         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Why does XCode
1859         hate itself so much?
1860         * Scripts/run-webkit-tests:
1861
1862 2007-02-02  Geoffrey Garen  <ggaren@apple.com>
1863
1864         Even better build fix than the last.
1865
1866         * ChangeLog:
1867         * DumpRenderTree/DumpRenderTree.m:
1868         (shouldIgnoreWebCoreNodeLeaks):
1869
1870 2007-02-02  Geoffrey Garen  <ggaren@apple.com>
1871
1872         Fixed build. Added work-around for GCC bug.
1873
1874         * DumpRenderTree/DumpRenderTree.m:
1875         (shouldIgnoreWebCoreNodeLeaks):
1876
1877 2007-02-01  Geoffrey Garen  <ggaren@apple.com>
1878
1879         Reviewed by Maciej Stachowiak.
1880
1881         Added support for selectively ignoring WebCore::Node leaks during layout
1882         tests, so that we can ignore known leaks in other components.
1883
1884         * DumpRenderTree/DumpRenderTree.m:
1885         (shouldIgnoreWebCoreNodeLeaks): Implements a black list of tests whose
1886         WebCore::Node leaks we have to ignore. Does this CFString gobbledy-gook
1887         confuse anyone else?
1888         (runTest):
1889
1890 2007-02-01  Anders Carlsson  <acarlsson@apple.com>
1891
1892         Reviewed by Darin.
1893
1894         * DumpRenderTree/UIDelegate.m:
1895         (-[UIDelegate webView:addMessageToConsole:]):
1896         Dump console messages.
1897
1898 2007-01-31  Anders Carlsson  <acarlsson@apple.com>
1899
1900         * DumpRenderTree/ResourceLoadDelegate.m:
1901         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1902         Use an NSString here so we can guarantee that -description always returns the same value.
1903
1904 2007-01-31  Geoffrey Garen  <ggaren@apple.com>
1905
1906         Reviewed by Darin Adler.
1907
1908         Added Selection::toRange to the leaks -exclude list, since it comes up
1909         as a false positive (Radar 4967949).
1910
1911         Also added RangeCounter to the global initializer exclude list. I added
1912         a RangeCounter since leaks won't detect all Range leaks anymore.
1913
1914         * Scripts/check-for-global-initializers:
1915         * Scripts/run-webkit-tests:
1916
1917 2007-01-31  Anders Carlsson  <acarlsson@apple.com>
1918
1919         * DumpRenderTree/ResourceLoadDelegate.m:
1920         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1921         Don't try to create an identifier if resource loads shouldn't be dumped.
1922
1923 2007-01-31  Anders Carlsson  <acarlsson@apple.com>
1924
1925         Reviewed by Geoff.
1926
1927         Add dumping of resource loads. This isn't completely tweaked yet since the test results would
1928         rely on resources being delivered in the same order which might not always be true. However, it works good
1929         enough for the simple webarchive tests I want to do right now.
1930
1931         * DumpRenderTree/DumpRenderTree.h:
1932         * DumpRenderTree/DumpRenderTree.m:
1933         (dumpRenderTree):
1934         (+[LayoutTestController isSelectorExcludedFromWebScript:]):
1935         (-[LayoutTestController dumpResourceLoadCallbacks]):
1936         (runTest):
1937
1938         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1939         * DumpRenderTree/ResourceLoadDelegate.h: Added.
1940         * DumpRenderTree/ResourceLoadDelegate.m: Added.
1941         Add new resource load delegate.
1942
1943 2007-01-31  Geoffrey Garen  <ggaren@apple.com>
1944
1945         Backing out the CFRunLoopRunSpecific exclude command because it was overly
1946         broad. We'll either need to work around this leak in DRT, or do some
1947         custom grep-based leak ignoring.
1948
1949         * Scripts/run-webkit-tests:
1950
1951 2007-01-30  Geoffrey Garen  <ggaren@apple.com>
1952
1953         Reviewed by Beth Dakin.
1954
1955         Filed some more Radars in other components, added some more leaks to the
1956         exclusion list.
1957
1958         * Scripts/run-webkit-tests: Ignore leaks in CFNotificationCenterAddObserver,
1959         CFRunLoopRunSpecific, and NSSpellChecker.
1960
1961 2007-01-30  David Kilzer  <ddkilzer@webkit.org>
1962
1963         Reviewed by Darin.
1964
1965         http://bugs.webkit.org/show_bug.cgi?id=11882
1966         Need a way to regression test .webarchive output files
1967
1968         Implement layoutTestController.dumpAsWebArchive() to test WebArchive format.
1969         Alters WebResourceResponse and WebResourceURL properties within WebArchive format
1970         to normalize URLs to remove path where WebKit was checked out.  Also converts
1971         WebDataResource properties from data to string if the corresponding
1972         WebResourceMIMEType property starts with "text/" or equals
1973         "application/x-javascript".
1974
1975         * DumpRenderTree/DumpRenderTree.m:
1976         (convertWebResourceDataToString): Added.
1977         (normalizeWebResourceURL): Added.
1978         (normalizeWebResourceResponse): Added.
1979         (serializeWebArchiveToXML): Added.
1980         (dump):
1981         (+[LayoutTestController isSelectorExcludedFromWebScript:]):
1982         (-[LayoutTestController dumpAsWebArchive]): Added.
1983         (runTest):
1984
1985 2007-01-30  David Kilzer  <ddkilzer@webkit.org>
1986
1987         Reviewed by Mark Rowe.
1988
1989         http://bugs.webkit.org/show_bug.cgi?id=12470
1990         svn-create-patch creates duplicate patches for files within an added/modified directory
1991
1992         * Scripts/svn-create-patch:
1993         (sub generateFileList($\%\%)): Ignore directories when generating the file list.
1994
1995 2007-01-29  Geoffrey Garen  <ggaren@apple.com>
1996
1997         Reviewed by Maciej Stachowiak.
1998
1999         Fixed <rdar://problem/4485644> REGRESSION: JavaScriptCore has init routines
2000
2001         No more mollycoddling for you, FastMalloc.o!
2002
2003         * Scripts/check-for-global-initializers:
2004
2005 2007-01-29  Graham Dennis  <graham.dennis@gmail.com>
2006
2007         Reviewed by Maciej.
2008
2009         Enables layout test for: http://bugs.webkit.org/show_bug.cgi?id=10725
2010         Image data in from RTFD clipboard data thrown away
2011
2012         - This method is needed because NSArrays are bridged to JS Arrays,
2013           which in turn are bridged back to WebScriptObjects when passed from
2014           JS to ObjC. Hence it is not possbile to pass an NSArray from JS.
2015
2016         * DumpRenderTree/DumpRenderTree.m:
2017         (-[DumpRenderTreePasteboard declareType:owner:]): Added a convenience method for JS.
2018
2019 2007-01-25  Geoffrey Garen  <ggaren@apple.com>
2020
2021         Reviewed by Maciej Stachowiak.
2022
2023         Added support for test for <rdar://problem/4608404> WebScriptObject's
2024         _rootObject lack of ownership policy causes crashes (e.g., in Dashcode)
2025
2026         * DumpRenderTree/DumpRenderTree.m:
2027         (+[LayoutTestController isSelectorExcludedFromWebScript:]):
2028         (+[LayoutTestController webScriptNameForSelector:]):
2029         (-[LayoutTestController storeWebScriptObject:]):
2030         (-[LayoutTestController accessStoredWebScriptObject]):
2031         (-[LayoutTestController dealloc]):
2032
2033 2007-01-26  Lars Knoll <lars@trolltech.com>
2034
2035         Reviewed by Zack
2036
2037         Small hack to ensure that our top level frame actually has the
2038         correct size. Unfortunately this means I'll have to regenerate
2039         all test cases :/
2040
2041         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2042         (WebCore::DumpRenderTree::DumpRenderTree):
2043
2044 2007-01-25  Lars Knoll <lars@trolltech.com>
2045
2046         Reviewed by Darin and Zack
2047
2048         Move the test results for Qt into a directory of it's own
2049         (WebKit/LayoutTestResults/qt). Leave the Mac results where
2050         they are for now and share the text only results between
2051         Mac and Qt.
2052
2053         Add support for a LayoutTestResults/platform/Skipped file
2054         to run-webkit-tests to be able to ignore certain tests
2055
2056         Remove the old tests-skipped.txt from Qts DumpRenderTree
2057         implementation.
2058
2059         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2060         (WebCore::DumpRenderTree::DumpRenderTree):
2061         (WebCore::DumpRenderTree::open):
2062         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
2063         * DumpRenderTree/DumpRenderTree.qtproj/tests-skipped.txt: Removed.
2064         * Scripts/run-webkit-tests:
2065
2066 2007-01-24  Darin Adler  <darin@apple.com>
2067
2068         Reviewed by Oliver.
2069
2070         - fix crash seen in layout tests
2071
2072         * DumpRenderTree/EventSendingController.m: (-[EventSendingController dealloc]):
2073         Add back the line of code that sets savedMouseEvents to nil. I thought it was
2074         a field of the EventSendingController, but it's actually a global.
2075
2076 2007-01-24  Darin Adler  <darin@apple.com>
2077
2078         Reviewed by Maciej.
2079
2080         - changed dragMode to be a property instead of a function
2081
2082         * DumpRenderTree/EventSendingController.h: Renamed inDragMode to dragMode.
2083         * DumpRenderTree/EventSendingController.m:
2084         (+[EventSendingController isSelectorExcludedFromWebScript:]): Removed setDragMode.
2085         (+[EventSendingController isKeyExcludedFromWebScript:]): Added dragMode.
2086         (-[EventSendingController init]): Updated for name change.
2087         (-[EventSendingController leapForward:]): Ditto.
2088         (-[EventSendingController mouseUp]): Ditto.
2089         (-[EventSendingController mouseMoveToX:Y:]): Ditto.
2090
2091 2007-01-24  Darin Adler  <darin@apple.com>
2092
2093         Reviewed by Maciej.
2094
2095         - made the deferral of mouse events until drag completes conditional
2096           it's needed for drag testing, and harmful for selection testing
2097
2098         * DumpRenderTree/EventSendingController.h: Added inDragMode boolean.
2099         * DumpRenderTree/EventSendingController.m:
2100         (+[EventSendingController isSelectorExcludedFromWebScript:]): Added setDragMode:.
2101         (+[EventSendingController webScriptNameForSelector:]): Added name for setDragMode,
2102         and remove unneeded clearKillRing name.
2103         (-[EventSendingController init]): Initialize inDragMode to true.
2104         (-[EventSendingController dealloc]): Removed overzealous assertions -- we should
2105         not be asserting things that are dependent on the test content!
2106         (-[EventSendingController leapForward:]): Only queue events in drag mode.
2107         (-[EventSendingController setDragMode:]): Added.
2108         (-[EventSendingController mouseDown]): Removed overzealous assertion.
2109         (-[EventSendingController mouseUp]): Removed overzealous assertions.
2110         Only queue events in drag mode.
2111         (-[EventSendingController mouseMoveToX:Y:]): Only queue events in drag mode.
2112
2113 2007-01-24  Lars Knoll <lars@trolltech.com>
2114
2115         Reviewed by Zack
2116
2117         Add a signal handler, always dump immediately if we get an
2118         error during a page load and raise the timeout to 5 seconds
2119         (as we get a lot less such failures now)
2120
2121         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2122         (WebCore::DumpRenderTree::DumpRenderTree):
2123         (WebCore::DumpRenderTree::maybeDump):
2124         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
2125         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
2126         (LayoutTestController::waitUntilDone):
2127         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
2128         (crashHandler):
2129         (main):
2130         * DumpRenderTree/DumpRenderTree.qtproj/tests-skipped.txt:
2131
2132 2007-01-22  Darin Adler  <darin@apple.com>
2133
2134         Reviewed by Mitz.
2135
2136         - a couple tiny tweaks to make --reset-results work better
2137
2138         * Scripts/run-webkit-tests: Always generate results when --reset-results is specified.
2139         Don't make a separate "new" entry while generating results when --reset-results
2140         is specified since new results are the norm in that case.
2141
2142 2007-01-21  Sanjay Madhav  <sanjay12@gmail.com>
2143
2144         Reviewed by Darin.
2145
2146         Test support for: <rdar://problem/4928583> Memory usage grows when reloading google.com/ig
2147
2148         This adds a getJSObjectCount test-accessible function to allow test scripts to track JSObject usage.
2149
2150         * DumpRenderTree/GCController.h:
2151         * DumpRenderTree/GCController.mm:
2152         (+[GCController isSelectorExcludedFromWebScript:]):
2153         (-[GCController getJSObjectCount]):
2154
2155 2007-01-20  Mark Rowe  <mrowe@apple.com>
2156
2157         Reviewed by Maciej.
2158
2159         * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py: Track the output of run-javascriptcore-tests,
2160         catch single regressions, and don't generate tests results for new tests.
2161
2162 2007-01-20  Adam Roben  <aroben@apple.com>
2163
2164         Rubberstamped by Maciej.
2165
2166         * Scripts/run-webkit-tests: Change the default behavior back to
2167         generating results for new tests (this can be disabled with
2168         --no-new-test-results)
2169
2170 2007-01-19  Lars Knoll <lars@trolltech.com>
2171
2172         Reviewed by Adam Roben.
2173
2174         run-webkit-tests does now not generate new results by default anymore.
2175         You'll have to pass the --new-tests flag to it to force it to do so.
2176
2177         This is required to make it possible to have tests running on multiple
2178         platforms peacefully together.
2179
2180         * Scripts/run-webkit-tests:
2181
2182 2007-01-18  Darin Adler  <darin@apple.com>
2183
2184         Reviewed by John Sullivan.
2185
2186         * Scripts/run-webkit-tests: Fix handling of configuration so it
2187         does the right thing when no explicit configuration is passed in.
2188         The old code assumed that the result of setConfiguration() was the
2189         configuration, but it's undefined when no configuration is
2190         explicitly passed in. The correct function to use is
2191         configuration(), and I also streamlined the code.
2192
2193 2007-01-17  Lars Knoll <lars@trolltech.com>
2194
2195         Fix my last commit to actually work in all cases.
2196
2197         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2198         (WebCore::DumpRenderTree::readStdin):
2199
2200 2007-01-17  Lars Knoll <lars@trolltech.com>
2201
2202         Reviewed by Maciej
2203
2204         Make sure DumpRenderTree exits when run-webkit-tests
2205         is done.
2206
2207         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2208         (WebCore::DumpRenderTree::readStdin):
2209
2210 2007-01-17  Lars Knoll <lars@trolltech.com>
2211
2212         Reviewed by Zack
2213
2214         Small fixes in DumpRenderTree, so we don't by
2215         accident dump twice for the same test.
2216
2217         Exclude one more test as it currently causes DumpRenderTree to
2218         hang forever.
2219
2220         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2221         (WebCore::DumpRenderTree::readStdin):
2222         (WebCore::DumpRenderTree::dump):
2223         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
2224         (LayoutTestController::notifyDone):
2225         * DumpRenderTree/DumpRenderTree.qtproj/tests-skipped.txt:
2226
2227 2007-01-17  Lars Knoll <lars@trolltech.com>
2228
2229         Reviewed by Zack
2230
2231         Add a message handler to DumpRenderTree that will
2232         suppress all debug output coming from qDebug() statements.
2233         Like this we can get rid of all the noise coming
2234         from the notImplemented() macro when running the
2235         layout tests. You can get it back by adding -v to
2236         DumpRenderTree's command line.
2237
2238         Changed run-webkit-tests slightly, so we by default
2239         don't fail anymore when our output differs from what
2240         is generated on the Mac. Added a --strict option, so
2241         that we can still see this cases and fix them one by one.
2242
2243         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
2244         (messageHandler):
2245         (main):
2246         * Scripts/run-webkit-tests:
2247
2248 2007-01-16  Lars Knoll <lars@trolltech.com>
2249
2250         Reviewed by Zack
2251
2252         Use the new public API for the Qt build, and don't rely on
2253         WebKit internals anymore.
2254
2255         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2256         (WebCore::DumpRenderTree::DumpRenderTree):
2257         (WebCore::DumpRenderTree::~DumpRenderTree):
2258         (WebCore::DumpRenderTree::open):
2259         (WebCore::DumpRenderTree::readStdin):
2260         (WebCore::DumpRenderTree::initJSObjects):
2261         (WebCore::DumpRenderTree::dump):
2262         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
2263         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro:
2264         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTreeClient.cpp: Removed.
2265         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTreeClient.h: Removed.
2266         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
2267         (LayoutTestController::notifyDone):
2268         (LayoutTestController::timerEvent):
2269         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
2270         (main):
2271         * DumpRenderTree/DumpRenderTree.qtproj/tests-skipped.txt:
2272
2273 2007-01-15  Justin Garcia  <justin.garcia@apple.com>
2274
2275         Reviewed by mjs
2276
2277         <rdar://problem/4810960>
2278         Gmail Editor: window.focus() called on keyDown (9640)
2279
2280         * DumpRenderTree/EventSendingController.m: Send the keyDown event
2281         to the firstResponder, not the event's locationInWindow.  A
2282         key press's locationInWindow is meaningless and just a dummy
2283         coordinate.
2284
2285 2007-01-15  Eric Seidel  <eric@webkit.org>
2286
2287         Reviewed by bdash.
2288
2289         Add a script to keep our header guards squeaky clean.
2290
2291         * Scripts/clean-header-guards: Added.
2292
2293 2007-01-15  Lars Knoll <lars@trolltech.com>
2294
2295         Reviewed by Zack
2296
2297         Fix a few smaller issues in here, and update
2298         our list of skipped tests.
2299
2300         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2301         (WebCore::DumpRenderTree::DumpRenderTree):
2302         (WebCore::DumpRenderTree::readStdin):
2303         (WebCore::DumpRenderTree::dump):
2304         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
2305         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
2306         (LayoutTestController::LayoutTestController):
2307         (LayoutTestController::reset):
2308         (LayoutTestController::waitUntilDone):
2309         (LayoutTestController::notifyDone):
2310         (LayoutTestController::dumpEditingCallbacks):
2311         (LayoutTestController::timerEvent):
2312         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
2313         * DumpRenderTree/DumpRenderTree.qtproj/tests-skipped.txt:
2314
2315 2007-01-14  Mark Rowe  <mrowe@apple.com>
2316
2317         Reviewed by Adam.
2318
2319         <rdar://problem/4908909> Need to create Leopard nightly build
2320
2321         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj: Always use the 10.4 Universal SDK.  The disk images don't mount pre-10.4 so we aren't losing anything here.
2322         * WebKitLauncher/WebKitNightlyEnabler.m:
2323         (poseAsWebKitApp): Simplify CoreFoundation-related hackery by using _CFGetProcessPath instead of walking the mach-o symbol tables.  The smaller timeframe where the
2324         CFProcessPath environment variable is set allows this to work correctly on Leopard where the old code failed.
2325         (enableWebKitNightlyBehaviour):
2326         * WebKitLauncher/main.m:
2327         (main): Pass executable path as WebKitAppPath rather than CFProcessPath to prevent it being picked up too early by CoreFoundation.
2328         * Drosera/launcher.m:
2329         (main): Ditto
2330
2331 2007-01-12  Lars Knoll <lars@trolltech.com>
2332
2333         Reviewed by Zack
2334
2335         Get DumpRenderTree to work again for the Qt build.
2336
2337         Make run-webkit-tests a little less verbose when testing
2338         Qt, and add an option to run DumpRenderTree inside valgrind
2339         (useful for debugging)
2340
2341         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2342         (WebCore::DumpRenderTree::DumpRenderTree):
2343         (WebCore::DumpRenderTree::~DumpRenderTree):
2344         (WebCore::DumpRenderTree::open):
2345         (WebCore::DumpRenderTree::dump):
2346         (WebCore::DumpRenderTree::maybeDump):
2347         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
2348         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTreeClient.cpp:
2349         (WebCore::DumpRenderTreeClient::dispatchDidHandleOnloadEvents):
2350         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTreeClient.h:
2351         * DumpRenderTree/DumpRenderTree.qtproj/tests-skipped.txt:
2352         * Scripts/run-webkit-tests:
2353
2354 2007-01-12  Zack Rusin  <zack@kde.org>
2355
2356         Add WEBKIT_FULLBUILD env variable to get the
2357         build do a make clean before make to cleanout the
2358         stale depenendencies (for buildbot mainly).
2359
2360         * Scripts/webkitdirs.pm:
2361
2362 2007-01-11  Mitz Pettel  <mitz@webkit.org>
2363
2364         Reviewed by Hyatt.
2365
2366         - http://bugs.webkit.org/show_bug.cgi?id=10249
2367           Temporarily disable tests that are causing kernel panics
2368
2369         Changed the ImageDiff tool not to use CoreImage filters.
2370
2371         * DumpRenderTree/ImageDiff.m:
2372         (main):
2373         (createImageFromStdin):
2374         (compareImages):
2375         (getDifferenceBitmap):
2376
2377 2007-01-11  Lars Knoll <lars@trolltech.com>
2378
2379         Fix compilation
2380
2381         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro:
2382
2383 2007-01-11  Lars Knoll <lars@trolltech.com>
2384
2385         Reviewed by Darin.
2386
2387         Adjust to loader changes.
2388
2389         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2390         (WebCore::DumpRenderTree::DumpRenderTree):
2391
2392 2007-01-06  George Staikos  <staikos@kde.org>
2393
2394         This doesn't build on all unix platforms!
2395
2396         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro:
2397
2398 2007-01-05  Zack Rusin  <zack@kde.org>
2399
2400         Reviewed by Simon.
2401
2402         Fix the undefined warnings and try to detect
2403         the DISPLAY properly.
2404
2405         * Scripts/run-webkit-tests:
2406
2407 2007-01-05  David Kilzer  <ddkilzer@webkit.org>
2408
2409         Reviewed by Mark Rowe.
2410
2411         Speed up svn-create-patch for copied and moved files.
2412
2413         * Scripts/svn-create-patch:
2414         (manufacturePatchForAdditionWithHistory($$)): Use 'svn cat' instead of 'svn cat -rNNNNN'
2415         so svn pulls original from local disk.
2416
2417 2007-01-04  Lars Knoll <lars@trolltech.com>
2418
2419         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro:
2420               Link with RPATH to (hopefully) get the automatic tests working.
2421
2422 2007-01-03  Mark Rowe  <bdash@webkit.org>
2423
2424         Reviewed by Anders.
2425
2426         * Scripts/run-webkit-tests: Launch Safari using the same WebKit build configuration as the layout tests used.
2427
2428 2007-01-02  Zack Rusin  <zack@kde.org>
2429
2430         Make it work after javascriptcore/bindings changes.
2431
2432         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2433         (WebCore::DumpRenderTree::initJSObjects):
2434         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro:
2435
2436 2007-01-01  David Kilzer  <ddkilzer@webkit.org>
2437
2438         Reviewed by Darin.
2439
2440         http://bugs.webkit.org/show_bug.cgi?id=12023
2441         svn-create-patch and friends should handle moved/copied files
2442
2443         * Scripts/svn-apply: Identify copied files and handle those before all other patches.
2444         * Scripts/svn-create-patch: Generate patches with subtle changes for copied files.
2445         (findMimeType($)): Added.
2446         (findModificationTime($)): Added.
2447         (findSourceFileAndRevision($)): Added.
2448         (generateDiff($$$)): Changed to use svn stat instead of svn diff.
2449         (isBinaryMimeType($)): Added.
2450         (manufacturePatchForAdditionWithHistory($$)): Added.
2451         * Scripts/svn-unapply: Identify copied files and handle those after unapplying all other patches.
2452
2453 2006-12-29  Eric Seidel  <eric@webkit.org>
2454
2455         Reviewed by olliej.
2456
2457         Stop DumpRenderTree from reporting false Frame/Node leaks due to new SVGImage
2458
2459         * DumpRenderTree/DumpRenderTree.m:
2460         (dumpRenderTree): clear WebCore cache before exiting
2461
2462 2006-12-29  David Kilzer  <ddkilzer@webkit.org>
2463
2464         Reviewed by NOBODY (build fix).
2465
2466         Reverted last commit until WebResourceData issue is fixed.
2467
2468         http://bugs.webkit.org/show_bug.cgi?id=11882
2469         Need a way to regression test .webarchive output files
2470
2471         * DumpRenderTree/DumpRenderTree.m:
2472         (serializeWebArchiveToXML): Removed.
2473         (dump):
2474         (+[LayoutTestController isSelectorExcludedFromWebScript:]):
2475         (-[LayoutTestController dumpAsWebArchive]): Removed.
2476         (runTest):
2477
2478 2006-12-28  David Kilzer  <ddkilzer@webkit.org>
2479
2480         Reviewed by Darin.
2481
2482         http://bugs.webkit.org/show_bug.cgi?id=11882
2483         Need a way to regression test .webarchive output files
2484
2485         Implement layoutTestController.dumpAsWebArchive() to test WebArchive format.
2486         Saves WebArchive plist in xml format, then alters file:// URLs to remove path
2487         where WebKit was checked out.
2488
2489         * DumpRenderTree/DumpRenderTree.m:
2490         (serializeWebArchiveToXML): Added.
2491         (dump):
2492         (+[LayoutTestController isSelectorExcludedFromWebScript:]):
2493         (-[LayoutTestController dumpAsWebArchive]): Added.
2494         (runTest):
2495
2496 2006-12-28  George Staikos  <staikos@kde.org>
2497
2498         Reviewed by Olliej.
2499
2500         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro: don't build on non-X11
2501
2502 2006-12-27  Geoffrey Garen  <ggaren@apple.com>
2503
2504         Reviewed by Eric Seidel. Prose edited by Mitz Pettel.
2505
2506         Some cleanup I did while debugging the regression in plugins/netscape-dom-access.html.
2507
2508         No behavior change. Layout tests pass.
2509
2510         * DumpRenderTree/DumpRenderTree.h: Exported the done BOOL in place of the
2511         doneLoading() accessor function. This matches the rest of DRT's exports and
2512         makes it easier to search for clients who check (!done).
2513
2514         * DumpRenderTree/DumpRenderTree.m: Moved fflush() call to runTest() so
2515         it would cover both code paths for calling runTest().
2516
2517         (dumpRenderTree): "doneLoading()" => "done"
2518         (dump): ditto
2519         * DumpRenderTree/EditingDelegate.m: ditto
2520         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]): ditto
2521         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]): ditto
2522         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]): ditto
2523         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]): ditto
2524         (-[EditingDelegate webView:shouldDeleteDOMRange:]): ditto
2525         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]): ditto
2526         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]): ditto
2527         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]): ditto
2528         (-[EditingDelegate webViewDidBeginEditing:]): ditto
2529         (-[EditingDelegate webViewDidChange:]): ditto
2530         (-[EditingDelegate webViewDidEndEditing:]): ditto
2531         (-[EditingDelegate webViewDidChangeTypingStyle:]): ditto
2532         (-[EditingDelegate webViewDidChangeSelection:]): ditto
2533         * DumpRenderTree/UIDelegate.m: ditto
2534         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:]): ditto
2535
2536 2006-12-26  Eric Seidel  <eric@webkit.org>
2537
2538         Reviewed by bradee-oh.
2539
2540         Add very simple run-pageloadtest script for running SVG page load test.
2541
2542         * Scripts/run-pageloadtest: Added.
2543
2544 2006-12-26  Geoffrey Garen  <ggaren@apple.com>
2545
2546         Reviewed by Eric Seidel.
2547
2548         Some cleanup in preparation for fixing <rdar://problem/4740328> Safari
2549         crash on quit in _NPN_ReleaseObject from KJS::Bindings::CInstance::~CInstance
2550
2551         (dumpRenderTree): Renamed "installedPlugins" to "sharedDatabase."
2552
2553 2006-12-23  Geoffrey Garen  <ggaren@apple.com>
2554
2555         Reviewed by Maciej Stachowiak.
2556
2557         Added --threaded support to run-webkit-tests and DumpRenderTree.
2558
2559         In "threaded" mode, DRT runs a concurrent JavaScript thread with each test,
2560         stressing the thread safety of JavaScriptCore and the JavaScriptCore/WebCore
2561         interface. This is useful for tracking down bugs you might see on a system
2562         configured to use a PAC file.
2563
2564         Ironically, I can proudly state that very few layout tests pass.
2565
2566         * DumpRenderTree/DumpRenderTree.m: Added javaScriptThread and helper functions
2567         for starting and stopping it.
2568         (runJavaScriptThread): helper function
2569         (startJavaScriptThread): helper function
2570         (stopJavaScriptThread): helper function
2571
2572         (dumpRenderTree): Added --threaded command line argument.
2573         * Scripts/run-webkit-tests: ditto
2574
2575 2006-12-22  Mark Rowe  <bdash@webkit.org>
2576
2577         Reviewed by Brady.
2578
2579         Fix for <rdar://problem/4265976>
2580         prepare-ChangeLog sometimes lists the wrong Objective-C class name for a changed method
2581
2582         * Scripts/prepare-ChangeLog: Treat @end as the end of both the interface and the method declaration.
2583
2584 2006-12-21  Mark Rowe  <bdash@webkit.org>
2585
2586         Reviewed by Tim Hatcher.
2587
2588         http://bugs.webkit.org/show_bug.cgi?id=11922
2589         Bug 11922: REGRESSION(r17128): Drosera no longer shows local variables in stack frame
2590
2591         * Drosera/DebuggerDocument.m:
2592         (-[WebScriptObject webScriptAttributeKeysForScriptObject:]): Use an anonymous function with function.call to
2593         ensure that the properties are being retrieved from the correct scope object.
2594
2595 2006-12-21  Lars Knoll <lars@trolltech.com>
2596
2597         Reviewed by Zack
2598
2599         Add support for the layoutTestController JavaScript object
2600         to be able to get textOnly dumps.
2601         Added a Qt specific hack to always get the same fonts (the ones
2602         added in this submit) and the same dpi when running the layout tests.
2603         Modified the run-webkit-tests script to also do a comparison to the
2604         Mac generated outputs (by stripping out positioning information).
2605
2606         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2607         (WebCore::DumpRenderTree::DumpRenderTree):
2608         (WebCore::DumpRenderTree::open):
2609         (WebCore::DumpRenderTree::resetJSObjects):
2610         (WebCore::DumpRenderTree::initJSObjects):
2611         (WebCore::DumpRenderTree::dump):
2612         (WebCore::DumpRenderTree::checkLoaded):
2613         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
2614         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro:
2615         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTreeClient.cpp:
2616         (WebCore::DumpRenderTreeClient::DumpRenderTreeClient):
2617         (WebCore::DumpRenderTreeClient::partClearedInBegin):
2618         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTreeClient.h:
2619         * DumpRenderTree/DumpRenderTree.qtproj/fontoverload.cpp: Added.
2620         (QX11Info::appDpiY):
2621         (QX11Info::appDpiX):
2622         (qt_x11ft_convert_pattern):
2623         (LayoutTestController::LayoutTestController):
2624         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h: Added.
2625         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp: Added.
2626         (LayoutTestController::shouldDumpAsText):
2627         (LayoutTestController::shouldWaitUntilDone):
2628         (LayoutTestController::reset):
2629         (LayoutTestController::dumpAsText):
2630         (LayoutTestController::waitUntilDone):
2631         (LayoutTestController::notifyDone):
2632         * DumpRenderTree/DumpRenderTree.qtproj/fonts/AHEM____.TTF: Added.
2633         * DumpRenderTree/DumpRenderTree.qtproj/fonts/COPYING: Added.
2634         * DumpRenderTree/DumpRenderTree.qtproj/fonts/CourierBold.ttf: Added.
2635         * DumpRenderTree/DumpRenderTree.qtproj/fonts/CourierBoldOblique.ttf: Added.
2636         * DumpRenderTree/DumpRenderTree.qtproj/fonts/CourierMedium.ttf: Added.
2637         * DumpRenderTree/DumpRenderTree.qtproj/fonts/CourierMediumOblique.ttf: Added.
2638         * DumpRenderTree/DumpRenderTree.qtproj/fonts/HelveticaBold.ttf: Added.
2639         * DumpRenderTree/DumpRenderTree.qtproj/fonts/HelveticaBoldOblique.ttf: Added.
2640         * DumpRenderTree/DumpRenderTree.qtproj/fonts/HelveticaMedium.ttf: Added.
2641         * DumpRenderTree/DumpRenderTree.qtproj/fonts/HelveticaMediumOblique.ttf: Added.
2642         * DumpRenderTree/DumpRenderTree.qtproj/fonts/SymbolMedium.ttf: Added.
2643         * DumpRenderTree/DumpRenderTree.qtproj/fonts/TimesBold.ttf: Added.
2644         * DumpRenderTree/DumpRenderTree.qtproj/fonts/TimesBoldItalic.ttf: Added.
2645         * DumpRenderTree/DumpRenderTree.qtproj/fonts/TimesMedium.ttf: Added.
2646         * DumpRenderTree/DumpRenderTree.qtproj/fonts/TimesMediumItalic.ttf: Added.
2647         * Scripts/run-webkit-tests:
2648
2649 2006-12-21  Mark Rowe  <bdash@webkit.org>
2650
2651         Reviewed by Geoff.
2652
2653         http://bugs.webkit.org/show_bug.cgi?id=11888
2654         Bug 11888: REGRESSION (r18320): Web Inspector panes broken
2655
2656         * Drosera/debugger.js: Use removeProperty to reset a style property to its initial value.
2657
2658 2006-12-18  Geoffrey Garen  <ggaren@apple.com>
2659
2660         Reviewed by Beth Dakin.
2661
2662         Updated EventSender to be able to send mouse up events outside the WebView.
2663         This is a minor tweak to a hackish implementation. The real solution
2664         should be to use NSApplication's event sending model instead of rolling
2665         our own, but I don't have time for that right now.
2666
2667         * DumpRenderTree/EventSendingController.m:
2668         (-[EventSendingController mouseUp]):
2669
2670 2006-12-15  Marvin Decker  <marv.decker@gmail.com>
2671
2672         Reviewed by Darin and Alexey.
2673
2674         Fix the Windows build, move various Client implementations out of
2675         WebCore and into WebKit.
2676
2677         * Spinneret/Spinneret.sln:
2678
2679 2006-12-14  Timothy Hatcher  <timothy@apple.com>
2680
2681         Reviewed by Brady.
2682
2683         * Makefile.shared: use $PIPESTATUS[0] and a sub-shell to exit with xcodebuild's exit status
2684
2685 2006-12-13  Zack Rusin  <zack@kde.org>
2686
2687         Reviewed by rwlbuis
2688
2689         Use the qmake build by default with Qt - it's the one that works
2690         currently.
2691
2692         * Scripts/build-webkit:
2693         * Scripts/webkitdirs.pm:
2694
2695 2006-12-10  Lars Knoll <lars@trolltech.com>
2696
2697         Reviewed by Zack
2698
2699         Some more fixes to the dumprendertree application.
2700         Fix the run-webkit-tests script for Qt.
2701
2702         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2703         (WebCore::DumpRenderTree::open):
2704         (WebCore::DumpRenderTree::readStdin):
2705         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
2706         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro: Added.
2707         * Scripts/run-webkit-tests:
2708         * Scripts/webkitdirs.pm:
2709
2710 2006-12-10  Rob Buis  <buis@kde.org>
2711
2712         Reviewed by Darin.
2713
2714         * DumpRenderTree/DumpRenderTree.m:
2715         (dump):
2716
2717 2006-12-10  Lars Knoll <lars@trolltech.com>
2718
2719         Reviewed by Zack
2720
2721         Get the DumpRenderTree app to compile again
2722
2723         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2724         (WebCore::DumpRenderTree::DumpRenderTree):
2725         (WebCore::DumpRenderTree::open):
2726         (WebCore::DumpRenderTree::readStdin):
2727         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro: Added.
2728         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTreeClient.cpp:
2729         (WebCore::DumpRenderTreeClient::DumpRenderTreeClient):
2730         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTreeClient.h:
2731         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
2732         (main):
2733
2734 2006-12-09  George Staikos  <staikos@kde.org>
2735
2736         Reviewed by Zack.
2737
2738         Repair QMake build on OS X.
2739
2740         * Scripts/build-webkit:
2741
2742 2006-12-09  Zack Rusin  <zack@kde.org>
2743
2744         Fixing small mistakes in the build scripts for
2745         the qmake builds.
2746
2747         * Scripts/build-webkit:
2748         * Scripts/webkitdirs.pm:
2749
2750 2006-12-09  Simon Hausmann  <hausmann@kde.org>
2751
2752         Reviewed by hyatt.
2753
2754         Add support for a QMake build using build-webkit --qmake
2755
2756         * Scripts/build-webkit:
2757         * Scripts/webkitdirs.pm:
2758
2759 2006-12-09  George Staikos  <staikos@kde.org>
2760
2761         Reviewed by Zack.
2762
2763         Remove reference to Unity.
2764
2765         * Scripts/webkitdirs.pm:
2766
2767 2006-12-08  Zack Rusin  <zack@kde.org>
2768
2769         Reviewed by Maciej.
2770
2771         Fix the compile after recent API changes.
2772
2773         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2774         (WebCore::DumpRenderTree::DumpRenderTree):
2775         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
2776         (main):
2777
2778 2006-12-08  George Staikos  <staikos@kde.org>
2779
2780         Reviewed by Maciej.
2781
2782         Build Qt webkit on non-linux, and prefer it if $QTDIR is set
2783
2784         * Scripts/build-webkit:
2785         * Scripts/webkitdirs.pm:
2786
2787 2006-12-06  Steve Falkenburg  <sfalken@apple.com>
2788
2789         Support C strings for localization
2790
2791         * Scripts/extract-localizable-strings:
2792
2793 2006-12-04  Steve Falkenburg  <sfalken@apple.com>
2794
2795         Reviewed by Darin.
2796
2797         Make extract-localizable-strings compatible with cpp file extensions.
2798
2799         * Scripts/extract-localizable-strings:
2800
2801 2006-11-21  Darin Adler  <darin@apple.com>
2802
2803         Reviewed by Maciej.
2804
2805         - a couple changes to reduce the chance of false positives on the leakbot
2806
2807         * DumpRenderTree/DumpRenderTree.m:
2808         (dumpRenderTree): Move the main function into a separate function so we can run
2809         a final garbage collect afterward without any stray values on the stack. Replaced
2810         the old way of closing down a WebView (setting the delegates to nil) with the new
2811         way (calling the close method), which does a more complete job of shutting
2812         everything down without waiting for the WebView object to be deallocated.
2813         (main): Put auto-release pool here and added an explicit call to garbage collect.
2814         With a separate function, we greatly reduce the chance that a stray address on the
2815         stack will keep an object alive.
2816
2817         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Let Xcode do its thing,
2818         because I don't have what it takes to fight the power.
2819
2820 2006-11-17  Zack Rusin  <zack@kde.org>
2821
2822         Reviewed by Mitz. Landed by Niko.
2823
2824         Fixing compilation.
2825
2826         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2827         (WebCore::DumpRenderTree::DumpRenderTree): Adding
2828         ContextMenuClient to the constructor
2829
2830 2006-11-12  Mark Rowe  <bdash@webkit.org>
2831
2832         Reviewed by Mitz.
2833
2834         Clean up of GdkLauncher bakefile.
2835
2836         * GdkLauncher/gdklauncher.bkl:
2837
2838 2006-11-11  Nikolas Zimmermann  <zimmermann@kde.org>
2839
2840         Reviewed and landed by Anders.
2841
2842         Make DRT work again on Qt/Linux.
2843
2844         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2845         (WebCore::DumpRenderTree::DumpRenderTree):
2846
2847 2006-11-10  Zack Rusin  <zack@kde.org>
2848
2849         Reviewed and landed by Anders.
2850
2851         Adjusting to the recent loader changes, making it compile
2852         and work.
2853
2854         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2855         (WebCore::DumpRenderTree::DumpRenderTree):
2856         (WebCore::DumpRenderTree::checkLoaded):
2857         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
2858
2859 2006-11-10  Zack Rusin  <zack@kde.org>
2860
2861         Reviewed by Anders.
2862
2863         Making the Qt code work after refactorings in WebCore.
2864
2865         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2866         (WebCore::DumpRenderTree::DumpRenderTree):
2867         (WebCore::DumpRenderTree::checkLoaded):
2868         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
2869
2870 2006-11-08  Darin Adler  <darin@apple.com>
2871
2872         Reviewed by Anders.
2873
2874         - same change as below, only tested this time
2875
2876         * DumpRenderTree/DumpRenderTree.m: (main): Explicitly turn "tab to links"
2877         mode off. I think we need to do this because WebPreferences saves things
2878         for us automatically. It would be good to turn that off for DumpRenderTree,
2879         but for now lets handle this like the other preferences (set it explicitly
2880         each time).
2881
2882 2006-11-08  Darin Adler  <darin@apple.com>
2883
2884         Reviewed by Anders.
2885
2886         * DumpRenderTree/DumpRenderTree.m: (main): Get rid of code to turn on
2887         "tab to links" mode. No current tests depend on this, and there's a new
2888         test I want to land that depends on the default setting.
2889
2890 2006-11-06  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
2891
2892         Reviewed by Maciej.
2893
2894         Linux\gdk build fixes.
2895
2896         * GdkLauncher/main.cpp:
2897         (LauncherFrameGdk::LauncherFrameGdk):
2898         (main):
2899
2900 2006-11-06  Alexey Proskuryakov  <ap@nypop.com>
2901
2902         Build fix, approved in principle by Tim H.
2903
2904         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2905         Disable deprecated warnings for main.c (TestNetscapePlugin),
2906         as it now uses QuickDraw to convert mouse event coordinates.
2907
2908 2006-11-05  Timothy Hatcher  <timothy@apple.com>
2909
2910         Reviewed by Maciej.
2911
2912         Bug 11525: [Drosera] function menu doesn't understand object.method = function() {} syntax
2913         http://bugs.webkit.org/show_bug.cgi?id=11525
2914
2915         * Drosera/debugger.js: imporved the function name code
2916
2917 2006-11-06  Alexey Proskuryakov  <ap@webkit.org>
2918
2919         Reviewed by Maciej.
2920
2921         Make sure that alerts and delegate output made after notifyDone() are ignored, rather than
2922         being attributed to the next test.
2923
2924         * DumpRenderTree/EditingDelegate.m:
2925         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
2926         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
2927         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
2928         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
2929         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
2930         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2931         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
2932         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
2933         (-[EditingDelegate webViewDidBeginEditing:]):
2934         (-[EditingDelegate webViewDidChange:]):
2935         (-[EditingDelegate webViewDidEndEditing:]):
2936         (-[EditingDelegate webViewDidChangeTypingStyle:]):
2937         (-[EditingDelegate webViewDidChangeSelection:]):
2938         * DumpRenderTree/UIDelegate.m:
2939         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:]):
2940
2941 2006-11-06  Mark Rowe  <bdash@webkit.org>
2942
2943         Reviewed by Alexey.
2944
2945         Fix "Undefined subroutine &main::WEXITSTATUS" when build-dumprendertree fails.
2946
2947         * Scripts/run-webkit-tests: import the POSIX module.
2948
2949 2006-11-06  Alexey Proskuryakov  <ap@webkit.org>
2950
2951         Reviewed by Maciej.
2952
2953         Test for http://bugs.webkit.org/show_bug.cgi?id=11517
2954         REGRESSION: Flash clicks/interactivity not working properly
2955
2956         Teach TestNetscapePlugin to log events passed to it. To enable, set eventLoggingEnabled to true:
2957
2958         <embed name="plg" type="application/x-webkit-test-netscape" width=100 height=100></embed>
2959         <script>
2960             plg.eventLoggingEnabled = true;
2961             // use eventSender to simulate events...
2962         </script>
2963
2964         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
2965         (pluginGetProperty):
2966         (pluginSetProperty):
2967         (pluginAllocate):
2968         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
2969         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c:
2970         (NPP_HandleEvent):
2971
2972 2006-11-04  David Smith  <catfish.man@gmail.com>
2973
2974         Reviewed by Tim H.
2975
2976         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11521
2977         Bug 11521: [Drosera] Breakpoint editor UI behaves incorrectly when multiple editors are open
2978
2979         * Drosera/debugger.js: Use .// instead of // so that it doesn't root the search at the document.
2980
2981 2006-11-04  David Smith  <catfish.man@gmail.com>
2982
2983         Reviewed by Tim H.
2984
2985         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11513
2986         Bug 11513: [Drosera] Function popup fails to appear when clicking supposedly valid areas.
2987
2988         * Drosera/debugger.css: Stick a min-width on the menu to keep it from becoming smaller than the control.
2989
2990 2006-11-04  David Smith  <catfish.man@gmail.com>
2991
2992         Reviewed by Tim H.
2993
2994         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11512
2995         Bug 11512: [Drosera] Scrolling via keyboard breaks after clicking in function popup.
2996
2997         * Drosera/debugger.js: blur() the function popup when we're done with it.
2998
2999 2006-11-04  Mark Rowe  <bdash@webkit.org>
3000
3001         Reviewed by Darin.
3002
3003         Fix use of uninitialized value in pattern match.
3004
3005         * Scripts/webkitdirs.pm:
3006
3007 2006-11-04  Darin Adler  <darin@apple.com>
3008
3009         Reviewed by Tim Hatcher.
3010
3011         * Scripts/webkitdirs.pm: Don't try to use the Xcode build setting if it's project-relative.
3012
3013 2006-11-03  David Smith  <catfish.man@gmail.com>
3014
3015         Reviewed by Tim H.
3016
3017         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11510
3018         Bug 11510: [Drosera] Doubleclicking the attach table should attach to the clicked item.
3019
3020         * Drosera/DebuggerApplication.m:
3021         (-[DebuggerApplication showAttachPanel:]): Set the doubleAction for the table view
3022
3023 2006-11-03  Vladimir Olexa  <vladimir.olexa@gmail.com>
3024
3025         Reviewed by Tim H.
3026
3027         Fixes: http://bugs.webkit.org/show_bug.cgi?id=9596
3028         Bug 9596: [Drosera] add a function popup to the source pane
3029
3030         * Drosera/debugger.css: Added styles for function popup
3031         * Drosera/debugger.html: Added function popup button and select
3032         * Drosera/debugger.js: Added function popup functionality
3033
3034 2006-11-03  Michael Emmel  <mike.emmel@gmail.com>
3035
3036         Reviewed by Maciej.
3037
3038         http://bugs.webkit.org/show_bug.cgi?id=9671
3039
3040         * Scripts/wkstyle:
3041         Adds astyle sed script formats according to most of the style guidelines.
3042
3043 2006-11-03  Alexey Proskuryakov  <ap@nypop.com>
3044
3045         Reviewed by Adele.
3046
3047         http://bugs.webkit.org/show_bug.cgi?id=7323
3048         REGRESSION (10.4.4): ondrag* events don't fire on page in a frame
3049
3050         When dragging, do not send EventSendingController's events immediately. Dragging
3051         is supposed to be modal, so we need to perform it from within the delegate, without
3052         returning to JS to make the next mouse movement.
3053
3054         When the mouse is down, mouse events are now recorded, and executed when mouseUp is sent.
3055
3056         * DumpRenderTree/EventSendingController.h:
3057         * DumpRenderTree/EventSendingController.m:
3058         (-[EventSendingController dealloc]):
3059         (-[EventSendingController leapForward:]):
3060         (-[EventSendingController mouseDown]):
3061         (-[EventSendingController mouseUp]):
3062         (-[EventSendingController mouseMoveToX:Y:]):
3063         (+[EventSendingController saveEvent:]):
3064         (+[EventSendingController replaySavedEvents]):
3065         * DumpRenderTree/UIDelegate.m:
3066         (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]):
3067
3068 2006-11-02  Geoffrey Garen  <ggaren@apple.com>
3069
3070         Reviewed by Justin Garcia.
3071
3072         Made dumping of editing callbacks opt-in, so that editing spew doesn't
3073         cloud non-editing tests.
3074
3075         * DumpRenderTree/DumpRenderTree.m:
3076         (+[LayoutTestController isSelectorExcludedFromWebScript:]):
3077         (-[LayoutTestController shouldDumpEditingCallbacks]):
3078         (runTest):
3079         * DumpRenderTree/EditingDelegate.m:
3080         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
3081         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
3082         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
3083         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
3084         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
3085         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
3086         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
3087         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
3088         (-[EditingDelegate webViewDidBeginEditing:]):
3089         (-[EditingDelegate webViewDidChange:]):
3090         (-[EditingDelegate webViewDidEndEditing:]):
3091         (-[EditingDelegate webViewDidChangeTypingStyle:]):
3092         (-[EditingDelegate webViewDidChangeSelection:]):
3093
3094 2006-11-02  Alexey Proskuryakov  <ap@nypop.com>
3095
3096         Reviewed by Maciej, landed by Anders.
3097
3098         - http://bugs.webkit.org/show_bug.cgi?id=7802
3099           devenv.com not available in VC++ Express installations
3100
3101         * Scripts/webkitdirs.pm: Make Windows build work with Visual C++ Express.
3102         * Scripts/install-win-extras: Make setx.exe actually run.
3103
3104 2006-11-01  Stephanie Lewis  <slewis@apple.com>
3105
3106         Reviewed by Kevin.
3107
3108         Fixed bug where additional arguments got fed to xcode and jsdriver.pl
3109         Since testkjs is being built before the tests are run, we don't need
3110         to build it with webkit.
3111
3112         Fixes bugs
3113         http://bugs.webkit.org/show_bug.cgi?id=11462
3114         http://bugs.webkit.org/show_bug.cgi?id=6168
3115
3116         * Scripts/build-webkit:
3117         * Scripts/run-javascriptcore-tests:
3118
3119 2006-11-01  Brady Eidson  <beidson@apple.com>
3120
3121         Reviewed by Tim Hatcher
3122
3123         Added accessor to get the source directory for use in client scripts
3124
3125         * Scripts/webkitdirs.pm:
3126
3127 2006-11-01  Mark Rowe  <bdash@webkit.org>
3128
3129         Reviewed by Mitz.
3130
3131         Update references to webkit.opendarwin.org to webkit.org in Spinneret and WebKit.app.
3132
3133         * Spinneret/Spinneret/Spinneret.cpp:
3134         (_tWinMain):
3135         * WebKitLauncher/WebKitNightlyEnabler.m:
3136         (cleanUpAfterOurselves):
3137
3138 2006-10-31  Mark Rowe  <bdash@webkit.org>
3139
3140         Reviewed by Stephanie.
3141
3142         Limit build slaves to a single build to prevent concurrent builds on a single slave from significantly increasing build time.
3143
3144         * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py: Adjust slave distribution, and make use of a SlaveLock.
3145         * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py: Remove unused Qt build factory.
3146
3147 2006-10-31  Darin Adler  <darin@apple.com>
3148
3149         * DumpRenderTree/DumpRenderTree.m: Instead of allocating a single local
3150         pasteboard, allocate any number of local pasteboards.
3151         (main): Allocate the dictionary of pasteboards.
3152         (+[DumpRenderTreePasteboard _pasteboardWithName:]): Allocate a pasteboard,
3153         given a name.
3154         (+[LocalPasteboard alloc]): Added, so we don't have to call NSAllocateObject
3155         explicitly elsewhere.
3156         (-[LocalPasteboard addTypes:owner:]): Added a check that the owner responds
3157         to the selector rather than calling unconditionally.
3158
3159 2006-10-30  Darin Adler  <darin@apple.com>
3160
3161         - fixed build
3162
3163         * DumpRenderTree/DumpRenderTree.m: (-[LocalPasteboard setString:forType:]):
3164         Don't use CFPasteboard.
3165
3166 2006-10-30  Vladimir Olexa  <vladimir.olexa@gmail.com>
3167
3168         Reviewed by Tim H.
3169
3170         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11353
3171
3172         * Drosera/debugger.js: ParsedURL() object now recognizes local files
3173
3174 2006-10-30  Darin Adler  <darin@apple.com>
3175
3176         Reviewed by Tim Hatcher.
3177
3178         * DumpRenderTree/DumpRenderTree.m: Changed to allocate a local pasteboard.
3179         This should make our buildbot tests no longer need a pasteboard server.
3180
3181 2006-10-30  Geoffrey Garen  <ggaren@apple.com>
3182
3183         Reviewed by Beth.
3184
3185         Reorganized project file into Delegates and Controllers groups, and split
3186         UIDelegate stuff into a UIDelegate class.
3187
3188         A little birdy told me that I might end up adding some UIDelegate methods
3189         to DRT soon.
3190
3191         * DumpRenderTree/DumpRenderTree.m:
3192         (main):
3193         (runTest):
3194         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3195
3196 2006-10-31  Nikolas Zimmermann  <zimmermann@kde.org>
3197
3198         Reviewed by Oliver.
3199
3200         Add new platform/graphics include directory.
3201
3202         * DumpRenderTree/DumpRenderTree.qtproj/CMakeLists.txt:
3203
3204 2006-10-30  Timothy Hatcher  <timothy@apple.com>
3205
3206         Reviewed by Stephanie.
3207
3208         Add a special case for the Internal makefiles, so it can find the OepnSource.
3209
3210         * Scripts/webkitdirs.pm:
3211
3212 2006-10-30  Stephanie Lewis  <slewis@apple.com>
3213
3214         Reviewed by Darin.
3215
3216         Change Makefiles to return non-zero when module make fails.
3217         Fix bug where if xcode options are not set, modules can build in the
3218         wrong directory.
3219
3220         * Makefile:
3221         * Scripts/webkitdirs.pm:
3222
3223 2006-10-30  Matt Lilek  <pewtermoose@gmail.com>
3224
3225         Reviewed by Tim H.
3226
3227         Fix for http://bugs.webkit.org/show_bug.cgi?id=10468
3228         [Drosera] The Console toolbar button should bring the console window to the front.
3229
3230         The console now gets focus when its activated but already open.  Command + L also
3231         now activates/focuses the console.
3232
3233         * Drosera/English.lproj/MainMenu.nib/classes.nib:
3234         * Drosera/English.lproj/MainMenu.nib/info.nib:
3235         * Drosera/English.lproj/MainMenu.nib/keyedobjects.nib:
3236         * Drosera/debugger.js:
3237
3238 2006-10-29  Darin Adler  <darin@apple.com>
3239
3240         * Scripts/do-file-rename: Renames done, ready for the next round.
3241         * Scripts/do-webcore-rename: Ditto.
3242
3243 2006-10-29  Darin Adler  <darin@apple.com>
3244
3245         * Scripts/do-file-rename: And again.
3246
3247 2006-10-29  Darin Adler  <darin@apple.com>
3248
3249         * Scripts/do-webcore-rename: Tweaked plans for renaming again.
3250
3251 2006-10-29  Darin Adler  <darin@apple.com>
3252
3253         Reviewed by Mitz.
3254
3255         * DumpRenderTree/DumpRenderTree.m: (-[DumpRenderTreeWindow keyDown:]):
3256         Added. Does nothing, which prevents a beep.
3257
3258         * Scripts/do-webcore-rename: Tweaked plans for renaming a bit.
3259
3260 2006-10-27  Brady Eidson  <beidson@apple.com>
3261
3262         Rubber stamped by Tim Hatcher
3263
3264         Added "make universal" to build universal binaries
3265
3266         * Makefile:
3267         * Makefile.shared:
3268
3269 2006-10-26  Sam Weinig  <sam.weinig@gmail.com>
3270
3271         Reviewed by Geoff.
3272
3273         Fix for http://bugs.webkit.org/show_bug.cgi?id=11419
3274         REGRESSION (r17299): Assertion failure in -[WebHTMLView(WebPrivate) _topHTMLView]
3275         ([view isKindOfClass:[WebHTMLView class]]) when running the layout tests
3276
3277         * DumpRenderTree/EventSendingController.m:
3278         (-[EventSendingController mouseMoveToX:Y:]):
3279
3280 2006-10-26  Nikolas Zimmermann  <zimmermann@kde.org>
3281
3282         Reviewed by Darin.
3283
3284         Fix Qt/Linux build.
3285
3286         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3287         (WebCore::DumpRenderTree::open):
3288
3289 2006-10-24  Stephanie Lewis  <slewis@apple.com>
3290
3291         Reviewed by Maciej.
3292
3293         - Changed run-javascriptcore tests to build testkjs before running.
3294
3295         * Scripts/run-javascriptcore-tests:
3296
3297 2006-10-24  Nikolas Zimmermann  <zimmermann@kde.org>
3298
3299         Reviewed by Maciej.
3300
3301         Fix Qt/Linux build.
3302
3303         - Remove BrowserExtensionQt, move it's methods to Page/FrameQt.
3304         - Fix CMakeLists.txt to include platform/network.
3305
3306         * DumpRenderTree/DumpRenderTree.qtproj/CMakeLists.txt:
3307
3308 2006-10-24  David Smith  <catfish.man@gmail.com>
3309
3310         Reviewed by Tim H.
3311
3312         Bug 11382: [Drosera] Dragging breakpoints onto each other can mess up inline editor
3313         http://bugs.webkit.org/show_bug.cgi?id=11382
3314
3315         * Drosera/debugger.js: Breakpoint dragging now ensures that editors aren't orphaned.
3316
3317 2006-10-21  Darin Adler  <darin@apple.com>
3318
3319         * Scripts/commit-log-editor: Use baseProductDir() to find the base product directory.
3320         This was still using "symroots" so it almost never worked!
3321
3322 2006-10-21  Darin Adler  <darin@apple.com>
3323
3324         * Makefile: Build DumpRenderTree too.
3325         * Scripts/do-webcore-rename: Removed bogus comment.
3326
3327 2006-10-20  David Smith  <catfish.man@gmail.com>
3328
3329         Reviewed by Tim H.
3330
3331         Bug 11367: Inline Breakpoint Editor Improvements: Act III
3332         http://bugs.webkit.org/show_bug.cgi?id=11367
3333
3334         Major breakpoint editor changes:
3335         * Breakpoints can now either pause or log to console
3336         * Code cleanup through use of XPath and converting breakpoints to objects
3337         * Breakpoints now track how many times they've been reached
3338         * UI tweaks
3339         * The breakpoint editor now saves changes as they're entered
3340         * Because changes are auto-saved now, the save button has been converted to a close button (images from PSMTabBarControl, BSD licensed)
3341         * If an expression with no return is entered as a condition, it will be wrapped transparently with a return statement.
3342
3343         * Drosera/DebuggerDocument.m:
3344         (-[WebScriptObject breakpointEditorHTML]): A way of loading this from an external file, as it was getting too complex to include inline.
3345         * Drosera/Drosera.xcodeproj/project.pbxproj:
3346         * Drosera/Images/close.tif: Added.
3347         * Drosera/Images/close_active.tif: Added.
3348         * Drosera/Images/close_hover.tif: Added.
3349         * Drosera/breakpointEditor.html: Added.
3350         * Drosera/console.js: Added a way to append messages from outside the console window.
3351         * Drosera/debugger.js:
3352         * Drosera/viewer.css:
3353         * Drosera/viewer.html:
3354
3355 2006-10-18  David Smith  <catfish.man@gmail.com>
3356
3357         Reviewed by Tim H.
3358
3359         Improve the doubleclick behavior of breakpoints, and make breakpoints with no custom condition set appear blank instead of return [-1, 1] depending on enabled state.
3360
3361         * Drosera/DebuggerDocument.m:
3362         (-[WebScriptObject getDoubleClickMillis]): Add an ObjC wrapper for GetDblTime() so that JS can call it
3363         * Drosera/Drosera.xcodeproj/project.pbxproj: link Carbon for GetDblTime()
3364         * Drosera/debugger.js:
3365
3366 2006-10-18  Timothy Hatcher  <timothy@apple.com>
3367
3368         Reviewed by Anders.
3369
3370         Bug 10851: Crash with Drosera
3371         http://bugs.webkit.org/show_bug.cgi?id=10851
3372
3373         This crash results in an assert in debug builds.
3374
3375         assert(implementsCall());
3376
3377         The __drosera_introspection propery was not callable. Now we just assign
3378         this.__drosera_introspection in the evaluateWebScript call.
3379         This change also removes one DO message.
3380
3381         * Drosera/DebuggerDocument.m:
3382         (-[WebScriptObject webScriptAttributeKeysForScriptObject:]):
3383
3384 2006-10-18  Mark Rowe  <bdash@webkit.org>
3385
3386         Reviewed by Tim H.
3387
3388         http://bugs.webkit.org/show_bug.cgi?id=11304
3389         Bug 11304: Drosera fails to link as universal binary on PowerPC machine
3390
3391         * Drosera/Drosera.xcodeproj/project.pbxproj: Use -weak_framework to link against JavaScriptCore and WebCore directly
3392         when they are not part of the WebKit umbrella framework.
3393
3394 2006-10-18  Adam Roben  <aroben@apple.com>
3395
3396         fixo el buildo II: Release's Pride.
3397
3398         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3399
3400 2006-10-18  Geoffrey Garen  <ggaren@apple.com>
3401
3402         fixo el buildo.
3403
3404         Work around #import of <PDFKit/PDFView.h>.
3405
3406         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3407
3408 2006-10-18  David Smith  <catfish.man@gmail.com>
3409
3410         Reviewed by Tim H.
3411
3412         Add Xcode 3 style inline breakpoint editor. Credit to xenon for the CSS wizardry to get the appearance working properly.
3413
3414         * Drosera/Drosera.xcodeproj/project.pbxproj:
3415         * Drosera/Images/breakpointeditor.png: Added.
3416         * Drosera/breakpointEditor.css: Removed.
3417         * Drosera/breakpointEditor.html: Removed.
3418         * Drosera/breakpointEditor.js: Removed.
3419         * Drosera/debugger.js:
3420         * Drosera/viewer.css:
3421
3422 2006-10-18  David Harrison  <harrison@apple.com>
3423
3424         Reviewed by Tim H.
3425
3426         Bug 11341: REGRESSION (r16760): editing/selection/editable-links is failing
3427         http://bugs.webkit.org/show_bug.cgi?id=11341
3428
3429         Link editing behavior became a preference. DumpRenderTree needs to specify the
3430         non-default behavior it wants (WebKitEditableLinkOnlyLiveWithShiftKey).
3431
3432         * DumpRenderTree/DumpRenderTree.m:
3433         (main):
3434
3435 2006-10-15  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
3436
3437         Reviewed by Anders.
3438
3439         Make compiler not complain about unused gk. SpinneretWebHost was not setting
3440         initial refcount upon creation, so it is completely bogus.
3441
3442         * GdkLauncher/main.cpp:
3443         (main):
3444         * Spinneret/Spinneret/Spinneret.h:
3445         (SpinneretWebHost::SpinneretWebHost):
3446
3447 2006-10-15  Nikolas Zimmermann  <zimmermann@kde.org>
3448
3449         Reviewed by Oliver.
3450
3451         Add another hanging test, to the "to be skipped" list.
3452
3453         * DumpRenderTree/DumpRenderTree.qtproj/tests-skipped.txt:
3454
3455 2006-10-14  Nikolas Zimmermann  <zimmermann@kde.org>
3456
3457         Reviewed by Anders.
3458
3459         Some fixes to get the Qt BuildSlave to run the LayoutTests.
3460
3461         * Scripts/build-dumprendertree: No need to call cmake again.
3462         * Scripts/run-webkit-tests: Expose LD_LIBRARY_PATH.
3463
3464 2006-10-13  Nikolas Zimmermann  <zimmermann@kde.org>
3465
3466         Reviewed by Eric.
3467
3468         Force --no-http on Qt/Linux.
3469
3470         * Scripts/run-webkit-tests:
3471
3472 2006-10-13  Kevin McCullough  <KMcCullough@apple.com>
3473
3474         Reviewed by Adam.
3475
3476         Gets JavaScripCore tests running on windows.
3477
3478         * Scripts/run-javascriptcore-tests:
3479         * Scripts/webkitdirs.pm:
3480
3481 2006-10-12  Nikolas Zimmermann  <zimmermann@kde.org>
3482
3483         Reviewed by Maciej.
3484
3485         Exclude some tests which crash or hang from Qt/Linux DRT.
3486         These are known to fail, and will be fixed at some point :-)
3487
3488         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3489         (WebCore::DumpRenderTree::DumpRenderTree):
3490         (WebCore::DumpRenderTree::open):
3491         (WebCore::DumpRenderTree::readStdin):
3492         (WebCore::DumpRenderTree::readSkipFile):
3493         (WebCore::DumpRenderTree::checkLoaded):
3494         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
3495         * DumpRenderTree/DumpRenderTree.qtproj/tests-skipped.txt: Added.
3496
3497 2006-10-12  Nikolas Zimmermann  <zimmermann@kde.org>
3498
3499         Reviewed by Maciej.
3500
3501         Specialization of alert() for DumpRenderTree - just log the output, don't show any message box.
3502
3503         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTreeClient.cpp:
3504         (WebCore::DumpRenderTreeClient::runJavaScriptAlert):
3505         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTreeClient.h:
3506
3507 2006-10-12  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
3508
3509         Reviewed by Maciej.
3510
3511         Also regenerate GdkLauncher makefiles, since not doing that might
3512         lead to mismatch between WebCore and GdkLauncher compiler settings.
3513
3514         * Scripts/regenerate-makefiles:
3515
3516 2006-10-10  David Smith  <catfish.man@gmail.com>
3517
3518         Reviewed by Tim H.
3519
3520         Bug 11246: Minor Drosera code cleanup
3521         http://bugs.webkit.org/show_bug.cgi?id=11246
3522
3523         * Drosera/debugger.js: Change [has, add, remove]StyleClass to be a function on Element rather than taking an Element as an argument.
3524
3525 2006-10-10  Vladimir Olexa  <vladimir.olexa@gmail.com>
3526
3527         Reviewed by Tim H.
3528
3529         Bug 9778: http://bugs.webkit.org/show_bug.cgi?id=9778
3530
3531         * Drosera/Drosera.xcodeproj/project.pbxproj: Added files
3532         * Drosera/English.lproj/Debugger.nib/info.nib: Resized the main window and WebView
3533         * Drosera/English.lproj/Debugger.nib/keyedobjects.nib: Resized the main window and WebView
3534         * Drosera/Images/SourceArrowOpen.png: Added.
3535         * Drosera/Images/fileIcon.jpg: Added.
3536         * Drosera/Images/siteCollapsed.tif: Added.
3537         * Drosera/Images/siteExpanded.tif: Added.
3538         * Drosera/Images/siteIcon.tif: Added.
3539         * Drosera/debugger.css: Added File Browser styles
3540         * Drosera/debugger.html: Added File Browser UI
3541         * Drosera/debugger.js: Added File Browser functionality
3542
3543 2006-10-10  Darin Adler  <darin@apple.com>
3544
3545         * Scripts/do-file-rename: Added.
3546
3547 2006-10-09  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
3548
3549         Reviewed by Geoff.
3550
3551         Add -exit-after-loading option to make gdklauncher quit after fully loading and rendering
3552         a page. This allows automatic testing via e.g. valgrind.
3553
3554         * GdkLauncher/gdklauncher.bkl:
3555         * GdkLauncher/main.cpp:
3556         (LauncherFrameGdk::LauncherFrameGdk):
3557         (LauncherFrameGdk::setExitAfterLoading):
3558         (LauncherFrameGdk::handledOnloadEvents):
3559         (handle_event):
3560         (main):
3561
3562 2006-10-06  David Smith  <catfish.man@gmail.com>
3563
3564         Reviewed by Timothy.
3565
3566         Bug 9665: [Drosera] Conditional breakpoints. http://bugs.webkit.org/show_bug.cgi?id=9665
3567
3568         * Drosera/Drosera.xcodeproj/project.pbxproj: Added new files
3569         * Drosera/breakpointEditor.css: Added.
3570         * Drosera/breakpointEditor.html: Added.
3571         * Drosera/breakpointEditor.js: Added.
3572         * Drosera/debugger.js: Added conditional breakpoint support, and the ability to open the breakpoint editor window on option-clicking a breakpoint.
3573
3574 2006-10-06  Nikolas Zimmermann  <zimmermann@kde.org>
3575
3576         Reviewed by Tim H.
3577
3578         Fix Qt/Linux build by adapting the s/ScrollBar/Scrollbar/ changes.
3579
3580         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3581         (WebCore::DumpRenderTree::DumpRenderTree):
3582
3583 2006-10-05  Oliver Hunt  <ohunt@apple.com>
3584
3585         Reviewed by Anders.
3586
3587         * Scripts/run-webkit-tests:
3588         Fix pixel tests.
3589
3590 2006-10-04  Anders Carlsson  <acarlsson@apple.com>
3591
3592         Reviewed by Darin.
3593
3594         * Scripts/run-webkit-tests:
3595         Add an environment variable, WebKitExpectedTestResultsDirectory, which controls where expected test
3596         results should be.
3597
3598 2006-10-05  Nikolas Zimmermann  <zimmermann@kde.org>
3599
3600         Reviewed and landed by ap.
3601
3602         Cmake: make it possible to install the libraries after having built using 'build-webkit'.
3603         Just set the "WebKitInstallationPrefix" environment variable to your desired prefix.
3604
3605         * Scripts/webkitdirs.pm:
3606
3607 2006-10-04  Mark Rowe  <bdash@webkit.org>
3608
3609         Reviewed by Stephanie.
3610
3611         Switch the Qt buildbot to the standard set of build steps.
3612         Have JavaScriptCoreTest check the output of run-javascriptcore-tests to
3613         see if any regressions were spotted, and fail the test if so.
3614
3615         * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
3616         * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
3617         * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
3618
3619 2006-10-04  Timothy Hatcher  <timothy@apple.com>
3620
3621         Reviewed by Mitz Pettel!
3622
3623         Bug 10708: [Drosera] Make the console input plaintext-only
3624         http://bugs.webkit.org/show_bug.cgi?id=10708
3625
3626         Change the console input -webkit-user-modify property to
3627         read-write-plaintext-only.
3628
3629         * Drosera/console.css:
3630
3631 2006-10-04  David Smith  <catfish.man@gmail.com>
3632
3633         Reviewed by Tim H.
3634
3635         Bug 10473: [Drosera] Overlapping text in JavaScript Console
3636         http://bugs.webkit.org/show_bug.cgi?id=10473
3637
3638         Using min-height instead of height to avoid overlapping text.
3639
3640         * Drosera/console.css:
3641
3642 2006-10-04  David Smith  <catfish.man@gmail.com>
3643
3644         Reviewed by Tim H.
3645
3646         Added a bash-style command history.
3647
3648         * Drosera/console.js:
3649
3650 2006-10-03  Anders Carlsson  <acarlsson@apple.com>
3651
3652         Reviewed by Adam and Brady.
3653
3654         * DumpRenderTree/DumpRenderTree.m:
3655         (main):
3656         Update URL to Ahem.ttf
3657
3658 2006-10-03  Darin Adler  <darin@apple.com>
3659
3660         * Scripts/commit-log-editor: Added missing "close" call. Oops!
3661
3662 2006-10-03  Nikolas Zimmermann  <zimmermann@kde.org>
3663
3664         Reviewed by eseidel.  Landed by eseidel.
3665
3666         Offer a way for BuildBot to not colorize the cmake output, when building
3667         with the 'build-webkit' script. Add "--color" / "--no-color" option pair.
3668
3669         Default is colorize output, though only Qt platform handles this for now.
3670
3671         * Scripts/build-dumprendertree:
3672         * Scripts/build-webkit:
3673         * Scripts/webkitdirs.pm:
3674
3675 2006-10-03  Nikolas Zimmermann  <zimmermann@kde.org>
3676
3677         Reviewed by eseidel.  Landed by eseidel.
3678
3679         Make all important scripts work with Qt/Linux.
3680
3681         You can safely use this now:
3682         set-configuration-release --debug && build-webkit && run-javascriptcore-tests && run-webkit-tests
3683
3684         * Scripts/build-dumprendertree:
3685         * Scripts/run-javascriptcore-tests:
3686         * Scripts/run-webkit-tests:
3687         * Scripts/webkitdirs.pm:
3688
3689 2006-10-03  Nikolas Zimmermann  <zimmermann@kde.org>
3690
3691         Reviewed by Eric.
3692
3693         build-webkit tweak: Use WebKitBuild/$config as output dir (Release/Debug).
3694
3695         * Scripts/webkitdirs.pm:
3696
3697 2006-10-02  Nikolas Zimmermann  <zimmermann@kde.org>
3698
3699         Reviewed/landed by Adam.
3700
3701         Proper build-webkit support for Qt/Linux.
3702
3703         Compilation process is similar to OSX now, aka.
3704         the build directory is RootCheckoutDir/WebKitBuild now.
3705
3706         * Scripts/build-webkit: Recognize Qt.
3707         * Scripts/webkitdirs.pm: Add buildCMakeProject() logic.
3708
3709 2006-10-01  Mark Rowe  <opendarwin.org@bdash.net.nz>
3710
3711         Reviewed by Maciej.
3712
3713         Add QT build slave to Buildbot.
3714
3715         * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py: Add QT build slave, fix existing errors.
3716         * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py: Add QT build factory.
3717         * BuildSlaveSupport/build.webkit.org-config/webkit/status.py: Disable forcing of builds via web interface to prevent spamming.  Use the IRC bot in #webkit-build instead.
3718         * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py: Add CMake build step.
3719
3720 2006-09-28  David Harrison  <harrison@apple.com>
3721
3722         Suggested by Darin.
3723
3724         Moved an extern declaration from inside a method to the top of the file.
3725
3726         * DumpRenderTree/EventSendingController.m:
3727         (-[EventSendingController clearKillRing]):
3728
3729 2006-09-28  David Harrison  <harrison@apple.com>
3730
3731         Reviewed by Justin.
3732
3733         Add clearKillRing so we can test emacs support with empty kill ring.
3734
3735         * DumpRenderTree/EventSendingController.m:
3736         (+[EventSendingController isSelectorExcludedFromWebScript:]):
3737         (+[EventSendingController webScriptNameForSelector:]):
3738         (-[EventSendingController clearKillRing]):
3739
3740 2006-09-27  MorganL  <morganl.webkit@yahoo.com>
3741
3742         Reviewed by Maciej, landed by Brady
3743
3744         Fix URL bar updating.
3745
3746         * Spinneret/Spinneret/Spinneret.h:
3747         (SpinneretWebHost::didStartProvisionalLoadForFrame):
3748         (SpinneretWebHost::didCommitLoadForFrame):
3749         (SpinneretWebHost::didFinishLoadForFrame):
3750
3751 2006-09-23  Sam Weinig  <sam.weinig@gmail.com>
3752
3753         Reviewed by Eric.
3754
3755         Build Fix.
3756
3757         * DumpRenderTree/EventSendingController.m:
3758         (-[EventSendingController enableDOMUIEventLogging:]):
3759
3760 2006-09-22  Justin Garcia  <justin.garcia@apple.com>
3761
3762         Reviewed by darin
3763
3764         * Scripts/do-webcore-rename:
3765
3766 2006-09-21  Timothy Hatcher  <timothy@apple.com>
3767
3768         Reviewed by Adam.
3769
3770         Bug 10923: Frame scroll layout test failures on the buildbot
3771         http://bugs.webkit.org/show_bug.cgi?id=10923
3772
3773         Added a new method that will toggle on the recursive dump of
3774         child frame scroll positions.
3775
3776         * DumpRenderTree/DumpRenderTree.m:
3777         (dumpFrameScrollPosition):
3778         (+[LayoutTestController isSelectorExcludedFromWebScript:]):
3779         (-[LayoutTestController dumpChildFrameScrollPositions]):
3780
3781 2006-09-19  Krzysztof Kowalczyk <kkowalczyk@gmail.com>
3782
3783         Reviewed by eseidel.  Landed by eseidel.
3784
3785         Detect that close button was pressed and exit cleanly.
3786
3787         * GdkLauncher/main.cpp:
3788         (handle_event):
3789         (main):
3790
3791 2006-09-17  Adam Roben  <aroben@apple.com>
3792
3793         Reviewed by hyatt, sfalken.
3794
3795         Get DumpRenderTree compiling and limping along on Windows.
3796
3797         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3798         (loadResourceIntoArray): Added this function that WebCore::ImageWin needs from WebKit
3799         (main): Add NULL argument to Page constructor.
3800         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Remove incorrect "wininet.dll" argument to CC, fix JavaScriptCore.lib path, add *_SECURE_NO_DEPRECATE #defines
3801         * Scripts/webkitdirs.pm: Fix JavaScriptCore.lib path
3802
3803 2006-09-15  Mark Rowe  <opendarwin.org@bdash.net.nz>
3804
3805         Reviewed by Brady.
3806
3807         http://bugs.webkit.org/show_bug.cgi?id=10635
3808         Bug 10635: Buildbot configuration in SVN is out of sync with build.webkit.org
3809
3810         * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py: Reorder build slaves within build factories in an attempt to spread the load evenly.
3811         * BuildSlaveSupport/build.webkit.org-config/webkit/status.py: Return to sending status emails to <svnuser>@opensource.apple.com addresses.
3812         * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py: Update configuration to match changes in Buildbot.  Always do clean SVG builds.
3813
3814 2006-09-09  Sam Weinig  <sam.weinig@gmail.com>
3815
3816         Reviewed by Eric.
3817
3818         Patch for http://bugs.webkit.org/show_bug.cgi?id=10791
3819         Even More Objective-C DOM auto-generation cleanup
3820
3821         - Change to use new, more Objectice-C'ish version of
3822           DOMKeyboardEvent's initKeyboardEvent.  Fixes an error with
3823           regression test for fast/events/dblclick-addEventListener.html.
3824
3825         * DumpRenderTree/EventSendingController.m:
3826         (-[EventSendingController fireKeyboardEventsToElement:]):
3827
3828 2006-09-04  Nikolas Zimmermann  <zimmermann@kde.org>
3829
3830         Reviewed by Tim H.
3831
3832         Fixes last part of: http://bugs.webkit.org/show_bug.cgi?id=10644
3833         Move QtLauncher down to WebKitQt.
3834
3835         * QtLauncher/CMakeLists.txt: Removed.
3836         * QtLauncher/main.cpp: Removed.
3837
3838 2006-09-04  Nikolas Zimmermann  <zimmermann@kde.org>
3839
3840         Reviewed by Darin.
3841
3842         Fixes parts of: http://bugs.webkit.org/show_bug.cgi?id=10644
3843         Adjust DumpRenderTree to the FrameQtClient changes.
3844
3845         * DumpRenderTree/DumpRenderTree.qtproj/CMakeLists.txt:
3846         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3847         (WebCore::DumpRenderTree::DumpRenderTree):
3848         (WebCore::DumpRenderTree::~DumpRenderTree):
3849         (WebCore::DumpRenderTree::frame):
3850         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
3851         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTreeClient.cpp: Added.
3852         (WebCore::DumpRenderTreeClient::DumpRenderTreeClient):
3853         (WebCore::DumpRenderTreeClient::~DumpRenderTreeClient):
3854         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTreeClient.h: Added.
3855
3856 2006-09-03  Darin Adler  <darin@apple.com>
3857
3858         * Scripts/do-webcore-rename: More renaming plans.
3859
3860 2006-09-03  Alexey Proskuryakov  <ap@nypop.com>
3861
3862         Reviewed by Tim H.
3863
3864         http://bugs.webkit.org/show_bug.cgi?id=10693
3865         Convert JavaScript arrays to AppleScript lists
3866
3867         * DumpRenderTree/AppleScriptController.m:
3868         (convertAEDescToObject):
3869         (-[AppleScriptController doJavaScript:]): Support printing AEDescLists.
3870
3871 2006-08-31  Darin Adler  <darin@apple.com>
3872
3873         * Scripts/do-webcore-rename: Prepare for another round of renaming.
3874
3875 2006-08-29  Dan Waylonis  <waylonis@google.com>
3876
3877         Reviewed by ggaren.
3878
3879         - Verification of exceptions thrown in a plugin.  Test for bug 10114.
3880         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3881         * DumpRenderTree/ObjCPlugin.m:
3882         (+[ObjCPlugin isSelectorExcludedFromWebScript:]):
3883         (+[ObjCPlugin webScriptNameForSelector:]):
3884         (-[ObjCPlugin throwIfArgumentIsNotHello:]):
3885
3886 2006-08-30  Nikolas Zimmermann  <zimmermann@kde.org>
3887
3888         Reviewed by Tim H.
3889
3890         Commit KDE related tweaks, to be able to
3891         differentiate between a Qt-only or a KDE build.
3892
3893         * DumpRenderTree/DumpRenderTree.qtproj/CMakeLists.txt: Add ksvg2/ includes.
3894         * QtLauncher/CMakeLists.txt: Add ksvg2/ includes.
3895
3896 2006-08-29  Darin Adler  <darin@apple.com>
3897
3898         Reviewed by Tim Hatcher.
3899
3900         * Scripts/gdb-safari: Set DYLD_FRAMEWORK_PATH inside gdb instead of setting it in gdb's environment
3901         to work around what seems to be a bug in some versions of gdb.
3902
3903 2006-08-16  Tim Omernick  <timo@apple.com>
3904
3905         Reviewed by John Sullivan.
3906
3907         Part of <rdar://problem/4481553> NetscapeMoviePlugIn example code scripting doesn't work in Firefox (4319)
3908         <http://bugs.webkit.org/show_bug.cgi?id=4319>: NetscapeMoviePlugIn example code scripting doesn't work
3909         in Firefox
3910
3911         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c:
3912         (NPP_GetValue):
3913         WebKit's NPP_GetValue() reference counting behavior has been changed to match Firefox.  NPObject return values
3914         are expected to be retained by the plug-in, and released by the caller.
3915
3916 2006-08-28  Nikolas Zimmermann  <zimmermann@kde.org>
3917
3918         Reviewed by Tim Hatcher.
3919
3920         Fixes one chunk of: http://bugs.webkit.org/show_bug.cgi?id=10604
3921
3922         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3923         (WebCore::DumpRenderTree::checkLoaded): Faster polling for isLoaded() in
3924         Qt's DumpRenderTree.
3925
3926       * Scripts/run-webkit-tests:
3927         Use -expected-qt.txt etc.. output in run-webkit-test if isQt().
3928
3929 2006-08-28  Darin Adler  <darin@apple.com>
3930
3931         Reviewed by Tim Hatcher.
3932
3933         * Scripts/build-drosera: Fix behavior when there are multiple options.
3934
3935 2006-08-27  Timothy Hatcher  <timothy@apple.com>
3936
3937         Reviewed by Anders.
3938
3939         Drosera will be built when you type make.
3940
3941         * Drosera/Makefile: Added.
3942         * Makefile: Added.
3943         * Makefile.shared: Added.
3944
3945 2006-08-27  Anders Carlsson  <acarlsson@apple.com>
3946
3947         Forgot to add these.
3948
3949         * DumpRenderTree/DumpRenderTree.qtproj/CMakeLists.txt: Added.
3950         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp: Added.
3951         (WebCore::DumpRenderTree::DumpRenderTree):
3952         (WebCore::DumpRenderTree::~DumpRenderTree):
3953         (WebCore::DumpRenderTree::open):
3954         (WebCore::DumpRenderTree::readStdin):
3955         (WebCore::DumpRenderTree::checkLoaded):
3956         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h: Added.
3957         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp: Added.
3958         (main):
3959
3960 2006-08-27  Nikolas Zimmermann  <zimmermann@kde.org>
3961
3962         Reviewed by Eric, landed by Anders.
3963
3964         Add DumpRenderTree support for Qt/Linux.
3965
3966         * DumpRenderTree/DumpRenderTree.qtproj/CMakeLists.txt: Added.
3967         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp: Added.
3968         (WebCore::DumpRenderTree::DumpRenderTree):
3969         (WebCore::DumpRenderTree::~DumpRenderTree):
3970         (WebCore::DumpRenderTree::open):
3971         (WebCore::DumpRenderTree::readStdin):
3972         (WebCore::DumpRenderTree::checkLoaded):
3973         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h: Added.
3974         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp: Added.
3975         (main):
3976         * Scripts/build-dumprendertree:
3977         * Scripts/run-webkit-tests:
3978         * Scripts/webkitdirs.pm:
3979
3980 2006-08-24  Nikolas Zimmermann  <zimmermann@kde.org>
3981
3982         Reviewed by Eric. Landed by rwlbuis.
3983
3984         Add QtLauncher (was testunity before), which provides a
3985         standalone "browser" to test the Qt platform stuff.
3986
3987         * QtLauncher/CMakeLists.txt: Added.
3988         * QtLauncher/main.cpp: Added.
3989         (main):
3990
3991 2006-08-22  Trey Matteson  <trey@usa.net>
3992
3993         Reviewed by ggaren.
3994
3995         Added support for a new set of browser navigation tests.  The main feature
3996         is the ability for a test to queue up a set of future actions that will
3997         happen after that first page is loaded.  This is used to simulate a sequence
3998         of user actions such as filling out forms, loading additional pages or
3999         going back.  In addition we can now dump out the state of the back/forward
4000         list, and the scroll position is dumped if not at 0,0.
4001
4002         * DumpRenderTree/DumpRenderTree.m:
4003         (main):  Init new state
4004         (compareHistoryItems):  New utility to support sorting.
4005         (dumpHistoryItem):  Write out a WebHistoryItem and kids.
4006         (dumpFrameScrollPosition):  Write out the scroll position.
4007         (dump):  Optionally write b/f list or scroll position.
4008         (-[WaitUntilDoneDelegate processWork:]):  Perform queued work.
4009         (-[WaitUntilDoneDelegate webView:locationChangeDone:forDataSource:]):
4010         Kick off any queued actions.  Fixed for the case of loads started in
4011         a subframe instead of the root frame.
4012         (-[WaitUntilDoneDelegate webView:didStartProvisionalLoadForFrame:]):
4013         Grab the topmost frame that is being loaded.  Do this as early as possible,
4014         instead of in didCommitLoadForFrame.
4015         (-[WaitUntilDoneDelegate webView:didCommitLoadForFrame:]):
4016         Noting a load has started now happens in previous method.
4017         (+[LayoutTestController isSelectorExcludedFromWebScript:]):  Boilerplate
4018         (+[LayoutTestController webScriptNameForSelector:]):  Boilerplate
4019         (-[LayoutTestController notifyDone]):  readyToDump var is subsumed by
4020         topFrameLoading
4021         (-[LayoutTestController dumpBackForwardList]):  New impl, just set a bit.
4022         (-[LayoutTestController _addWorkForTarget:selector:arg1:arg2:]):
4023         Add new work to the queue.
4024         (-[LayoutTestController _doLoad:target:]):  Do a queued load.
4025         (-[LayoutTestController _doBackOrForwardNav:]):  Do a queued back/forward.
4026         (-[LayoutTestController scheduleBackNav:]):  Ways for scripts to queue actions
4027         (-[LayoutTestController scheduleForwardNav:]):
4028         (-[LayoutTestController scheduleReload]):
4029         (-[LayoutTestController scheduleScript:]):
4030         (-[LayoutTestController scheduleLoad:target:]):
4031         (runTest):  Clear new state for each test.  Renamed from "dumpRenderTree"
4032         since it's not one of the functions that does any dumping.
4033
4034 2006-08-15  Jonas Witt <jonas.witt@gmail.com>
4035
4036         Reviewed by Darin.
4037
4038         - added a function to create a few DOMKeyboardEvents and dispatch
4039           them to a specified HTML element
4040           http://bugs.webkit.org/show_bug.cgi?id=9736
4041
4042         * DumpRenderTree/EventSendingController.m:
4043         (+[EventSendingController isSelectorExcludedFromWebScript:]):
4044         (+[EventSendingController webScriptNameForSelector:]):
4045         (-[EventSendingController fireKeyboardEventsToElement:]):
4046
4047 2006-08-15  Duncan Wilcox  <duncan@mclink.it>
4048
4049         Reviewed and tweaked by Darin.
4050
4051         - added DumpRenderTree support so editing delegate can be made to refuse edits
4052           to enable tests for http://bugs.webkit.org/show_bug.cgi?id=10129
4053
4054         * DumpRenderTree/DumpRenderTree.m:
4055         (+[LayoutTestController isSelectorExcludedFromWebScript:]): Add setAcceptsEditing:
4056         to the list of methods.
4057         (+[LayoutTestController webScriptNameForSelector:]): Use the name setAcceptsEditing,
4058         without the colon, for the JavaScript name.
4059         (-[LayoutTestController setAcceptsEditing:]): Added. Calls through to the editing
4060         delegate.
4061         (dumpRenderTree): Set the acceptsEditing flag to YES before each test.
4062
4063         * DumpRenderTree/EditingDelegate.h: Added an "acceptsEditing" flag and getter and
4064         setter methods to the class.
4065         * DumpRenderTree/EditingDelegate.m:
4066         (-[EditingDelegate init]): Initialize acceptsEditing to YES.
4067         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]): Instead of always returning YES,
4068         return the value of acceptsEditing.
4069         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]): Ditto.
4070         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]): Ditto.
4071         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]): Ditto.
4072         (-[EditingDelegate webView:shouldDeleteDOMRange:]): Ditto.
4073         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
4074         Ditto.
4075         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]): Ditto.
4076         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]): Ditto.
4077         (-[EditingDelegate setAcceptsEditing:]): Added.
4078
4079 2006-08-03  Mark Rowe  <opendarwin.org@bdash.net.nz>
4080
4081         Reviewed by Darin.
4082
4083         Bug 10224: [Drosera] Drosera icon should be set on DroseraLauncher so it appears in nightly builds
4084         http://bugs.webkit.org/show_bug.cgi?id=10224
4085
4086         * Drosera/Drosera.xcodeproj/project.pbxproj:
4087         * Drosera/LauncherInfo.plist:
4088
4089 2006-08-03  Mitz Pettel  <opendarwin.org@mitzpettel.com>
4090
4091         - fix ASSERTION FAILURE: draggingDocumentView == nil in -[WebViewPrivate dealloc]
4092           when a test performs an unsuccessful drag and drop operation.
4093
4094         * DumpRenderTree/EventSendingController.m:
4095         (-[EventSendingController mouseUp]): Added a call to -draggingExited: if the
4096         drag operation for the mouse release is NSDragOperationNone.
4097
4098 2006-08-02  Timothy Hatcher  <timothy@apple.com>
4099
4100         Reviewed by Darin.
4101
4102         Bug 9632: [Drosera] syntax highlighting is slow (reproducible 40 second hang)
4103         http://bugs.webkit.org/show_bug.cgi?id=9632
4104
4105         Do not change the file source when normalizing the line endings.
4106         We use this file source to compare against new versions of the source
4107         as it comes in, so we can skip re-syntax highlighting if they are the same.
4108         The problem is apparent on yahoo.com since they have mixed line endings and
4109         once we normalize them the source will always be different. This was
4110         compounded by the fact that yahoo has around 40 inline scripts. Each
4111         inline script causes us to check if the main document has more loaded,
4112         that is when we compare the source strings. Since they are always different
4113         we would syntax highlight yahoo.com 40 times! We do check source length before
4114         doing a more expensive string comparison, but the lengths were the same.
4115
4116         * Drosera/debugger.js:
4117
4118 2006-08-02  Niels Leenheer  <niels.leenheer@gmail.com>
4119
4120         Reviewed by Timothy.
4121
4122         Bug 9931: [Drosera] Needs a cool icon
4123         http://bugs.webkit.org/show_bug.cgi?id=9931
4124
4125         * Drosera/Drosera.icns: Added.
4126         * Drosera/Drosera.xcodeproj/project.pbxproj:
4127         * Drosera/Info.plist:
4128
4129 2006-08-01  Darin Adler  <darin@apple.com>
4130
4131         - fix a bug in my recent change where the mouse position at the end of
4132           the last test would affect the results of the next test
4133
4134         * DumpRenderTree/DumpRenderTree.m: (dumpRenderTree): Set lastMousePosition to 0.
4135
4136 2006-07-31  Mark Rowe  <opendarwin.org@bdash.net.nz>
4137
4138         Reviewed by Maciej.
4139
4140         http://bugs.webkit.org/show_bug.cgi?id=10182
4141         Bug 10182: [Drosera] Evaluating expressions in Console is slow when current frame has many variables
4142
4143         * Drosera/console.js: String.indexOf returns -1 when the string is not found.
4144         Correct the logic to not reload local variable list unless an '=' character is in the expression.
4145
4146 2006-07-31  Darin Adler  <darin@apple.com>
4147
4148         Reviewed by Maciej.
4149
4150         - fix http://bugs.webkit.org/show_bug.cgi?id=10171
4151           REGRESSION: failing layout test: fast/events/objc-event-api.html
4152
4153         * DumpRenderTree/DumpRenderTree.m:
4154         (main): Add pose so we can implement +[NSEvent mouseLocation]. Put the window at a predictable
4155         location in flipped coordinates, since those are the coordinates that we use.
4156         (+[DumpRenderTreeEvent mouseLocation]): Implement this, since it's used for mouse event handling
4157         inside WebHTMLView.
4158
4159         * DumpRenderTree/EventSendingController.m:
4160         (+[EventSendingController initialize]): Removed unused webkitDomEventProperties array.
4161         (-[EventSendingController init]): Removed, since the whole thing was a no-op.
4162         (-[EventSendingController mouseMoveToX:Y:]): Convert the x,y pair to window coordinates. The old code
4163         probably worked OK, but this is needed to be correct.
4164         (-[EventSendingController handleEvent:]): Put clientX/Y before screenX/Y and removed the flipping
4165         code from screenY. We didn't really need to flip screenY -- what was actually happening was that the
4166         position that DumpRenderTree chose was in non-flipped coordinates, and with that fixed we can just
4167         dump the screenY as-is.
4168
4169 2006-07-31  Mark Rowe  <opendarwin.org@bdash.net.nz>
4170
4171         Reviewed by Darin.
4172
4173         http://bugs.webkit.org/show_bug.cgi?id=10178
4174         Bug 10178: [Drosera] Selecting a frame in the stack list should take you to that location in the source
4175
4176         * Drosera/debugger.js:  Keep a stack that contains the source file and line number references for outer
4177         frames.  Use this stack to determine which file and line to highlight when a stack frame is selected.
4178
4179 2006-07-31  Mark Rowe  <opendarwin.org@bdash.net.nz>
4180
4181         Reviewed by Darin.
4182
4183         http://bugs.webkit.org/show_bug.cgi?id=10175
4184         Bug 10175: [Drosera] Anonymous functions show up as "(global scope)" in stack list
4185
4186         * Drosera/DebuggerDocument.m:
4187         (-[WebScriptObject currentFunctionStack]): If the frame has a caller it isn't the global scope.
4188
4189 2006-07-31  Mark Rowe  <opendarwin.org@bdash.net.nz>
4190
4191         Reviewed by Darin.
4192
4193         http://bugs.webkit.org/show_bug.cgi?id=10167
4194         Bug 10167: REGRESSION(r15688): ASSERTION FAILED: _private->mouseDownEvent != nil in layout tests
4195
4196         * DumpRenderTree/EventSendingController.m: Don't set the mouse down flag
4197         in keyDown handler.
4198
4199 2006-07-30  Mark Rowe  <opendarwin.org@bdash.net.nz>
4200
4201         Reviewed by Maciej.
4202
4203         Bug 9686: [Drosera] Need the ability to break into Drosera on Javascript exceptions
4204         http://bugs.webkit.org/show_bug.cgi?id=9686
4205
4206         * Drosera/DebuggerDocument.m:
4207         (-[WebScriptObject switchToServerNamed:]): Remove as listener before resuming to
4208         ensure that the server does not try and notify us of events related to the resumption.
4209         (-[WebScriptObject webView:exceptionWasRaised:sourceId:line:forWebFrame:]): Delegate
4210         call through to JavaScript.
4211         * Drosera/debugger.js: Pause debugger when exception is raised.
4212
4213 2006-07-29  Mike Emmel  <mike.emmel@gmail.com>
4214
4215         Reviewed by Darin.
4216
4217         - fixes for Linux build
4218
4219         * GdkLauncher/mk: Added call to bakefile_gen before calling make.
4220         * GdkLauncher/gdklauncher.bkl: Tweak comment.
4221
4222 2006-07-24  Dan Waylonis  <waylonis@google.com>
4223
4224         Reviewed and tweaked a bit by Darin.
4225
4226         * DumpRenderTree/ObjCPlugin.m:
4227         (+[ObjCPlugin isSelectorExcludedFromWebScript:]): Added "echo:".
4228         (+[ObjCPlugin webScriptNameForSelector:]): Use the name "echo" for
4229         "echo:" so it's nice to call from JavaScript.
4230         (-[ObjCPlugin echo:]): Just returns the same object -- can be used
4231         to test a round trip through Objective-C types.
4232
4233 2006-07-24  Alexey Proskuryakov  <ap@nypop.com>
4234
4235         Reviewed by Darin.
4236
4237         Fix http://bugs.webkit.org/show_bug.cgi?id=10060
4238         Improve iExploder results parsing
4239
4240         * Scripts/run-iexploder-tests: Fix Apach logs parsing to produce a correct results
4241         in random mode, too.
4242
4243 2006-07-18  David Kilzer  <ddkilzer@kilzer.net>
4244
4245         Reviewed by Timothy.
4246
4247         - fix http://bugs.webkit.org/show_bug.cgi?id=9964
4248           Add switch to prepare-ChangeLog to skip svn update of ChangeLog files
4249
4250         * Scripts/prepare-ChangeLog: Added --[no-]update switch.
4251
4252 2006-07-16  David Kilzer  <ddkilzer@kilzer.net>
4253
4254         Reviewed by Darin.
4255
4256         * BuildSlaveSupport/build.webkit.org-config/buildbot.css:
4257         Removed "No newline at end of file" that snuck in as part of the "apply patch" process.
4258         * GdkLauncher/mk:
4259         Removed "Property changes" that snuck in as part of the "apply patch" process.
4260
4261 2006-07-16  David Kilzer  <ddkilzer@kilzer.net>
4262
4263         Reviewed by Darin.
4264
4265         - fix http://bugs.webkit.org/show_bug.cgi?id=9875
4266           Teach svn-apply and svn-unapply to use patch(1) for additions and deletions
4267
4268         * Scripts/svn-apply:
4269         (addDirectoriesIfNeeded): Don't try to add a directory that's already in svn.
4270         (checksum): Added.
4271         (patch): Use patch(1) for non-binary additions and deletions.
4272         * Scripts/svn-unapply:
4273         (checksum): Added.