a4a91f834fb3af1056a71dedc90a41bffd6c9365
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-04-28  Chris Jerdonek  <cjerdonek@webkit.org>
2
3         Reviewed by Daniel Bates.
4
5         Removed the dividing line (i.e. "====...") logic from the code
6         called by svn-apply and svn-unapply.
7
8         https://bugs.webkit.org/show_bug.cgi?id=38093
9
10         The dividing line logic is unnecessary.  Removing it simplifies the
11         code and makes some subsequent changes easier.
12
13         * Scripts/VCSUtils.pm:
14           - Removed the logic in gitdiff2svndiff() to convert the git
15             "index" line to an SVN dividing line.
16           - Adjusted the logic similarly in parseDiffHeader().
17
18         * Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl:
19           - Updated the unit tests as necessary.
20
21         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
22           - Updated the unit tests as necessary.
23           - Corrected an error in the unit tests whereby all elements
24             of an array were referencing the same element rather than
25             distinct elements -- causing unit test failures to be masked.
26
27         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
28           - Updated the unit tests as necessary.
29           - Made the same unit test correction as above for parseDiff.pl.
30
31 2010-04-28  Evan Stade  <estade@chromium.org>
32
33         Unreviewed.
34
35         * Scripts/webkitpy/common/config/committers.py: adding myself as a committer
36
37 2010-04-28  Sam Weinig  <sam@webkit.org>
38
39         Reviewed by Mark Rowe.
40
41         Add MiniBrowser to the lists of modules to build and only build it on
42         SnowLeopard and later.
43
44         * Makefile:
45         * MiniBrowser/Makefile:
46
47 2010-04-28  Sam Weinig  <sam@webkit.org>
48
49         Reviewed by Mark Rowe.
50
51         Make running MiniBrowser.app without explicitly setting DYLD_FRAMEWORK_PATH.
52
53         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
54         * MiniBrowser/mac/make-launchable.sh: Added.
55
56 2010-04-28  Eric Seidel  <eric@webkit.org>
57
58         Reviewed by David Levin.
59
60         Audit all uses of subprocess in webkitpy
61         https://bugs.webkit.org/show_bug.cgi?id=38284
62
63         After further discussions with Jeffrey Yasskin
64         about http://bugs.python.org/issue2320
65         and related issues of using subprocess from
66         multiple threads, I have learned that subprocess
67         is known to be non-threadsafe through recent
68         Python 2.7 builds.
69
70         I'm attempting to lessen our exposure to these
71         subprocess bugs by auditing each use of subprocess
72         in webkitpy.  I did not find any unsafe calls
73         in my audit, but I did remove numerous unneeded
74         import subprocess lines.
75
76         * Scripts/webkitpy/common/checkout/api.py:
77         * Scripts/webkitpy/common/net/bugzilla.py:
78         * Scripts/webkitpy/common/system/deprecated_logging_unittest.py:
79         * Scripts/webkitpy/common/system/user.py:
80         * Scripts/webkitpy/layout_tests/port/base.py:
81         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
82         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
83         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: Added.
84         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
85         * Scripts/webkitpy/layout_tests/port/gtk.py:
86         * Scripts/webkitpy/layout_tests/port/mac.py:
87         * Scripts/webkitpy/layout_tests/port/qt.py:
88         * Scripts/webkitpy/layout_tests/port/webkit.py:
89         * Scripts/webkitpy/layout_tests/port/win.py:
90
91 2010-04-28  Darin Adler  <darin@apple.com>
92
93         Ignore a directory the Python tools creates.
94
95         * Scripts/webkitpy/style: Modified property svn:ignore.
96
97 2010-04-28  Darin Adler  <darin@apple.com>
98
99         * Scripts/extract-localizable-strings: Fix minor mistake in
100         argument checking.
101
102 2010-04-28  Luiz Agostini  <luiz.agostini@openbossa.org>
103
104         Reviewed by Kenneth Rohde Christiansen.
105
106         [Qt] QWebPage viewMode property
107         https://bugs.webkit.org/show_bug.cgi?id=38119
108
109         Replacing method qt_wrt_setViewMode by wrt_viewMode property.
110
111         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
112         (LayoutTestController::setViewModeMediaFeature):
113
114 2010-04-28  Chris Jerdonek  <cjerdonek@webkit.org>
115
116         Reviewed by Shinichiro Hamaji.
117
118         Adjusted check-webkit-style so that files with file type NONE
119         are automatically skipped without warning.
120
121         https://bugs.webkit.org/show_bug.cgi?id=38197
122
123         This change simplifies configuring which files to skip.  It also
124         addresses an issue whereby check-webkit-style was unintentionally
125         checking .vcproj files for carriage returns.
126
127         * Scripts/webkitpy/style/checker.py:
128           - Moved the C++, Python, and text file extensions to new
129             module-level configuration variables.
130           - Removed .pyc from the _SKIPPED_FILES_WITHOUT_WARNING configuration
131             variable.
132           - Changed the numeric values of the FileType enum so that
133             FileType.NONE evaluates to False.
134           - For ProcessorDispatcher.should_skip_without_warning():
135             - Changed the method to return True for FileType.NONE files.
136             - Made ChangeLog files an exception to getting skipped.
137           - Changed the StyleProcessor.process() method to raise an
138             exception if given a file path that should not be processed.
139
140         * Scripts/webkitpy/style/checker_unittest.py:
141           - Updated the unit tests and added more test cases as necessary.
142
143 2010-04-28  Eric Seidel  <eric@webkit.org>
144
145         Reviewed by Jeremy Orlow.
146
147         webkitpy: ScriptError('Failed to run "[u\'taskkill.exe\', u\'/f\', u\'/im\', u\'httpd.exe\']" exit_code: 128',)
148         https://bugs.webkit.org/show_bug.cgi?id=38248
149
150         The previous code did not check the return code of taskkill.
151         When I moved that callsite from using subprocess.call to
152         Executive.run_command having a non-zero return code became an error.
153
154         In this change I've centralized our killall handling in executive,
155         and added tests for it to make sure it works.
156
157         Currently kill_process and kill_all swallow exceptions in the cases
158         where the process(es) to be killed do(es) not exist.
159
160         * Scripts/webkitpy/common/system/executive.py:
161         * Scripts/webkitpy/common/system/executive_unittest.py:
162         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
163         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
164         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
165         * Scripts/webkitpy/layout_tests/port/gtk.py:
166         * Scripts/webkitpy/layout_tests/port/mac.py:
167         * Scripts/webkitpy/layout_tests/port/qt.py:
168         * Scripts/webkitpy/layout_tests/port/win.py:
169
170 2010-04-28  Eric Seidel  <eric@webkit.org>
171
172         Reviewed by Shinichiro Hamaji.
173
174         wdiff_text throws ScriptError because wdiff returns non-zero when files differ
175         https://bugs.webkit.org/show_bug.cgi?id=38246
176
177         wdiff returns 0 when files are the same, 1 when they differ.
178         run_command by default raises ScriptError if the return code is non-zero.
179         Fixed this by adding a custom error handler which only raises if the
180         return code is not 1.
181
182         I broke up the huge wdiff_text() method into little pieces
183         for easier unit testing.  There is only one functional change here
184         and that is the addition of the custom error handler.
185
186         * Scripts/webkitpy/layout_tests/port/base.py:
187         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
188
189 2010-04-28  Fumitoshi Ukai  <ukai@chromium.org>
190
191         Unreviewed build fix.
192
193         * DumpRenderTree/chromium/TestShell.cpp:
194         (TestShell::dumpImage): format '%u' expects type 'unsigned int', but argument 2 has type 'size_t'.
195         * DumpRenderTree/chromium/WebViewHost.cpp:
196         (WebViewHost::willSendRequest): too few arguments for format.
197
198 2010-04-27  Shinichiro Hamaji  <hamaji@chromium.org>
199
200         Reviewed by Darin Adler and Eric Seidel.
201
202         Add layoutTestController.setPrinting()
203         https://bugs.webkit.org/show_bug.cgi?id=37203
204
205         * DumpRenderTree/LayoutTestController.cpp:
206         (LayoutTestController::LayoutTestController):
207         (setPrintingCallback):
208         (LayoutTestController::staticFunctions):
209         * DumpRenderTree/LayoutTestController.h:
210         (LayoutTestController::isPrinting):
211         (LayoutTestController::setIsPrinting):
212         * DumpRenderTree/mac/DumpRenderTree.mm:
213         (dump):
214
215 2010-04-27  Michael Nordman  <michaeln@google.com>
216
217         Reviewed by Dmitry Titov.
218
219         [Chromium] Add two things to the webkit API to support appcaches in workers.
220         1) WebURLRequest TargetTypes for worker and shared worker main resources.
221         2) Factory method on class WebCommonWorkerClient to
222            createApplicationCacheHost() for the associated worker.
223
224         https://bugs.webkit.org/show_bug.cgi?id=38147
225
226         * DumpRenderTree/chromium/TestWebWorker.h add a stub impl of the factory method 
227         (TestWebWorker::createApplicationCacheHost):
228
229 2010-04-27  Adam Barth  <abarth@webkit.org>
230
231         Reviewed by Eric Seidel.
232
233         run-bindings-tests doesn't work in an SVN checkout
234         https://bugs.webkit.org/show_bug.cgi?id=38225
235
236         Previously detect_scm_system needed an absolute path for SVN.  Now we
237         accept a relative path.
238
239         * Scripts/webkitpy/common/checkout/scm.py:
240         * Scripts/webkitpy/common/checkout/scm_unittest.py:
241
242 2010-04-27  Sam Weinig  <sam@webkit.org>
243
244         Reviewed by Stephanie Lewis.
245
246         Always build WebKit2 when building on SnowLeopard and later. 
247
248         * Scripts/build-webkit:
249
250 2010-04-27  Sam Weinig  <sam@webkit.org>
251
252         Reviewed by Maciej Stachowiak.
253
254         Fix for https://bugs.webkit.org/show_bug.cgi?id=38238
255         Allow both WebKit and WebKit2 to link to the same WebCore.framework
256
257         * Scripts/build-webkit: Remove the UMBRELLA_LDFLAGS override when building
258         WebCore for WebKit2, it is no longer necessary.
259
260 2010-04-27  James Robinson  <jamesr@chromium.org>
261
262         Reviewed by David Levin.
263
264         Fix a typo in chromium.py that causes NRWT to fail in --verbose
265         mode in a Chromium checkout.
266         https://bugs.webkit.org/show_bug.cgi?id=38234
267
268         * Scripts/webkitpy/layout_tests/port/chromium.py:
269
270 2010-04-27  Darin Fisher  <darin@chromium.org>
271
272         Reviewed by Dimitri Glazkov.
273
274         [Chromium] Remove deprecated form of didChangeLocationWithinPage
275         https://bugs.webkit.org/show_bug.cgi?id=38178
276
277         Switch over to implementing didNavigateWithinPage.
278
279         * DumpRenderTree/chromium/WebViewHost.cpp:
280         (TestWebViewDelegate::didNavigateWithinPage):
281         (WebViewHost::didChangeLocationWithinPage):
282         * DumpRenderTree/chromium/WebViewHost.h:
283
284 2010-04-27  Evan Martin  <evan@chromium.org>
285
286         Unreviewed.
287
288         Adding myself to commmitters list.
289
290         * Scripts/webkitpy/common/config/committers.py:
291
292 2010-04-27  Adam Barth  <abarth@webkit.org>
293
294         Reviewed by Darin Adler.
295
296         run-bindings-tests should use --reset-results instead of --overwrite
297         https://bugs.webkit.org/show_bug.cgi?id=38200
298
299         As requested by Ojan.
300
301         * Scripts/run-bindings-tests:
302
303 2010-04-27  Adam Barth  <abarth@webkit.org>
304
305         Reviewed by Eric Seidel.
306
307         REGRESSION(r58261): webkit-patch edit-changelogs is broken
308         https://bugs.webkit.org/show_bug.cgi?id=38204
309
310         In 58261, we added code to abstract step that interrogates the squash
311         and git_commit options, but it doesn't declare that it uses those
312         options.  That means any command that doesn't happen to declare those
313         options might be broken if it uses the cached_lookup mechanism.
314
315         * Scripts/webkitpy/tool/steps/abstractstep.py:
316         * Scripts/webkitpy/tool/steps/applypatch.py:
317         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
318         * Scripts/webkitpy/tool/steps/build.py:
319         * Scripts/webkitpy/tool/steps/checkstyle.py:
320         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
321         * Scripts/webkitpy/tool/steps/closebug.py:
322         * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
323         * Scripts/webkitpy/tool/steps/commit.py:
324         * Scripts/webkitpy/tool/steps/confirmdiff.py:
325         * Scripts/webkitpy/tool/steps/createbug.py:
326         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
327         * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
328         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
329         * Scripts/webkitpy/tool/steps/postcodereview.py:
330         * Scripts/webkitpy/tool/steps/postdiff.py:
331         * Scripts/webkitpy/tool/steps/preparechangelog.py:
332         * Scripts/webkitpy/tool/steps/runtests.py:
333         * Scripts/webkitpy/tool/steps/update.py:
334         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
335         * Scripts/webkitpy/tool/steps/validatereviewer.py:
336
337 2010-04-27  Eric Seidel  <eric@webkit.org>
338
339         Reviewed by David Levin.
340
341         prepare-ChangeLog --bug fails on some CYGWIN installs due to missing certs
342         https://bugs.webkit.org/show_bug.cgi?id=38212
343
344         * Scripts/prepare-ChangeLog:
345          - Pass --insecure to curl to work around CYGWIN missing certs.
346
347 2010-04-27  Sam Weinig  <sam@webkit.org>
348
349         Rubber-stamped by Beth Dakin.
350
351         It is no longer necessary to set ENABLE_EXPERIMENTAL_SINGLE_VIEW_MODE
352         or WTF_USE_WEB_THREAD. Remove them.
353
354         * Scripts/build-webkit:
355
356 2010-04-27  Chris Jerdonek  <cjerdonek@webkit.org>
357
358         Reviewed by David Levin.
359
360         Changed Chris Jerdonek from committer to reviewer.
361
362         * Scripts/webkitpy/common/config/committers.py:
363
364 2010-04-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
365
366         Reviewed by Kenneth Rohde Christiansen.
367
368         [Qt] QGraphicsWebView: Arrow keys scroll the graphics-view instead of the web-page
369         https://bugs.webkit.org/show_bug.cgi?id=35834
370
371         The scene should always have the size of the web view otherwhise it is
372         possible to scroll the graphics view.
373
374         * QtLauncher/webview.cpp:
375         (WebViewGraphicsBased::resizeEvent):
376
377 2010-04-27  Diego Gonzalez  <diegohcg@webkit.org>
378
379         Unreviewed.
380
381         Adding myself to committers.py
382
383         * Scripts/webkitpy/common/config/committers.py:
384
385 2010-04-27  Eric Seidel  <eric@webkit.org>
386
387         Reviewed by Adam Barth.
388
389         [chromium] new-run-webkit-tests hangs on Chromium Bots (OS X and Linux)
390         https://bugs.webkit.org/show_bug.cgi?id=37987
391
392         After further research, I believe the hang is caused by:
393         http://bugs.python.org/issue2320
394         Basically Popen() is not reentrant.
395         The workaround is to pass close_fds=True to Popen() on Mac/Linux.
396
397         I fixed our main Popen wrapper "Executive.run_command" to use close_fds=True
398         when appropriate.
399
400         I audited all places we call Popen() and either moved them to run_command
401         or left a FIXME that they are not thread safe.  A few places I added the
402         close_fds workaround there and left an explanitory note.
403
404         * Scripts/webkitpy/common/checkout/scm_unittest.py:
405          - Added note that this Popen use is not threadsafe.
406         * Scripts/webkitpy/common/system/executive.py:
407          - Fixed our Executive.run_* to workaround python bug 2320.
408         * Scripts/webkitpy/common/system/user.py:
409          _ Added note that this Popen use is not threadsafe.
410         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: ditto.
411         * Scripts/webkitpy/layout_tests/port/apache_http_server.py: ditto.
412         * Scripts/webkitpy/layout_tests/port/base.py:
413          - Change wdiff back to using run_command now that we believe it
414            to be threadsafe.
415         * Scripts/webkitpy/layout_tests/port/chromium.py:
416          - Fix to use Executive in places.
417          - Pass self._executive down to the Driver for easier unit testing.
418         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
419          - Re-factor to use a _kill_all method.
420          - Made the _kill_all method use run_command to be threadsafe.
421         * Scripts/webkitpy/layout_tests/port/http_server.py:
422          - Add FIXME about using Executive.
423         * Scripts/webkitpy/layout_tests/port/server_process.py:
424          - Use Executive to be threadsafe.
425         * Scripts/webkitpy/layout_tests/port/webkit.py:
426          - Pass self._executive down to the Driver.
427         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
428          - Add note about Popen not being threadsafe.
429         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
430          - Move one caller to run_command add notes about moving others.
431
432 2010-04-27  Adam Barth  <abarth@webkit.org>
433
434         Reviewed by Maciej Stachowiak.
435
436         REGRESSION(r58261): webkit-patch upload does not work in an SVN checkout.
437         https://bugs.webkit.org/show_bug.cgi?id=38186
438
439         Unfortunately, we don't have a good way of testing this change because
440         our test coverage of the scm.py API is poor...
441
442         * Scripts/webkitpy/common/checkout/scm.py:
443         * Scripts/webkitpy/tool/steps/preparechangelog.py:
444
445 2010-04-26  Eric Seidel  <eric@webkit.org>
446
447         Reviewed by Adam Barth.
448
449         Remove unused code from text_diff.py
450         https://bugs.webkit.org/show_bug.cgi?id=38170
451
452         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
453          - Remove is_render_tree_dump which appears unused.
454
455 2010-04-26  Adam Barth  <abarth@webkit.org>
456
457         Reviewed by Eric Seidel.
458
459         webkit-patch pretty-diff is broken
460         https://bugs.webkit.org/show_bug.cgi?id=38172
461
462         We need to register for these options because they're used when we look
463         up the diff.
464
465         * Scripts/webkitpy/tool/steps/confirmdiff.py:
466
467 2010-04-26  Adam Barth  <abarth@webkit.org>
468
469         Reviewed by Eric Seidel.
470
471         Add ObjC and GObject to run-bindings-test
472         https://bugs.webkit.org/show_bug.cgi?id=38168
473
474         * Scripts/run-bindings-tests:
475
476 2010-04-26  Adam Barth  <abarth@webkit.org>
477
478         Reviewed by Eric Seidel.
479
480         Add testing infrastructure for JSC bindings generator
481         https://bugs.webkit.org/show_bug.cgi?id=38167
482
483         Add support for testing more than one bindings.  Also, converted the
484         script to PEP8 style.
485
486         * Scripts/run-bindings-tests:
487
488 2010-04-26  Eric Seidel  <eric@webkit.org>
489
490         Reviewed by Adam Barth.
491
492         Refactor results.html generation out into a new method and test it
493         https://bugs.webkit.org/show_bug.cgi?id=38164
494
495         Hopefully this results in no change in functionality.
496
497         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
498         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
499
500 2010-04-26  Adam Barth  <abarth@webkit.org>
501
502         Unreviewed, rolling out r58265.
503         http://trac.webkit.org/changeset/58265
504         https://bugs.webkit.org/show_bug.cgi?id=38021
505
506         This change prevents me from uploading patches.  It also breaks sheriff-bot.
507
508         * Scripts/webkitpy/tool/steps/options.py:
509
510 2010-04-26  Eric Seidel  <eric@webkit.org>
511
512         Reviewed by Adam Barth.
513
514         [chromium] new-run-webkit-tests hangs on Chromium Bots (OS X and Linux)
515         https://bugs.webkit.org/show_bug.cgi?id=37987
516
517         Rolled out:
518         http://trac.webkit.org/changeset/58062
519         http://trac.webkit.org/changeset/58060
520         http://trac.webkit.org/changeset/58059
521         http://trac.webkit.org/changeset/58055
522         http://trac.webkit.org/changeset/58054
523         and parts of:
524         http://trac.webkit.org/changeset/58050
525
526         I also wrote some new comments and a tiny amount of new
527         code to help make ChromiumDriver.run_test easier to read.
528
529         In order to unit-test my new code, I had to change ChromiumDriver
530         to not automatically start itself when created.  That ended up
531         being a lot of plumbing, but is hopefully easier to understand now.
532
533         There are no tests for the (restored) wdiff code.  wdiff does not
534         exist on all systems, so for now we will assume it worked since
535         it is just old code being reverted.
536
537          * Scripts/webkitpy/layout_tests/driver_test.py:
538           - Use create_driver instead of start_driver, and be sure to call .stop()
539          * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
540           - Use create_driver instead of start_driver
541          * Scripts/webkitpy/layout_tests/port/base.py:
542           - Added a comment to explain that diffs are binary files.
543           - Various patch reverts relating to wdiff
544           - Add Driver._command_wrapper to share code between WebKitDriver and ChromiumDriver.
545           - Made _command_wrapper use shlex.split to get rid of the FIXME.
546          * Scripts/webkitpy/layout_tests/port/base_unittest.py: Added.
547           - test the new _command_wrapper
548          * Scripts/webkitpy/layout_tests/port/chromium.py:
549          - Use _command_wrapper to get rid of a bunch of ugly code.
550          - Make __init__ stop auto-starting.
551          - Rename create_driver to start_driver.
552          - Added _write_command_and_read_line to make it possible to
553            put a FIXME next to read_line() w/o having to put it in two places.
554          - Moved test_shell command building into _test_shell_command and tested it.
555          - Fix comments to say test_shell since ChromiumDriver is test_shell only.
556          * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Added.
557           - Test the new test_shell_command method.
558          * Scripts/webkitpy/layout_tests/port/dryrun.py:
559           - Rename create_driver to start_driver.
560          * Scripts/webkitpy/layout_tests/port/test.py:
561           - Rename create_driver to start_driver.
562          * Scripts/webkitpy/layout_tests/port/webkit.py:
563           - Rename create_driver to start_driver.
564           - Treat output as binary arrays.
565          * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
566           - Treat diff files as binary.
567          * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
568           - Treat diff files as binary.
569
570 2010-04-26  Adam Barth  <abarth@webkit.org>
571
572         Reviewed by Eric Seidel.
573
574         Move bindings test directory into the scripts directory
575         https://bugs.webkit.org/show_bug.cgi?id=38161
576
577         Change script to point to the new location of these data files.
578
579         * Scripts/run-bindings-tests:
580
581 2010-04-26  Adam Barth  <abarth@webkit.org>
582
583         Unreviewed.  Mark run-bindings-tests executable so we can execute it.
584
585         * Scripts/run-bindings-tests:
586
587 2010-04-26  Tony Chang  <tony@chromium.org>
588
589         Reviewed by David Levin.
590
591         [chromium] build-webkit --chromium should build release by default
592         https://bugs.webkit.org/show_bug.cgi?id=38028
593
594         * Scripts/build-dumprendertree: Also should build release by default
595         * Scripts/build-webkit: Make sure to pass command line args through
596         * Scripts/webkitdirs.pm: Build the right configuration
597
598 2010-04-26  Ojan Vafai  <ojan@chromium.org>
599
600         Reviewed by Eric Seidel.
601
602         complete rietveld bugzilla integration
603         https://bugs.webkit.org/show_bug.cgi?id=38021
604
605         Makes --fancy-review the default. All this means is that the patch will
606         be uploaded to rietveld in addition to bugs.webkit.org. 
607
608         * Scripts/webkitpy/tool/steps/options.py:
609
610 2010-04-26  Chris Jerdonek  <cjerdonek@webkit.org>
611
612         Reviewed by Shinichiro Hamaji.
613
614         For check-webkit-style, renamed the style/processors/ directory
615         to style/checkers/.
616
617         https://bugs.webkit.org/show_bug.cgi?id=38122
618
619         * Scripts/webkitpy/style/checker.py:
620           - Updated import statements.
621
622         * Scripts/webkitpy/style/checker_unittest.py:
623           - Updated import statements.
624
625         * Scripts/webkitpy/style/checkers: Copied from WebKitTools/Scripts/webkitpy/style/processors.
626         * Scripts/webkitpy/style/processors: Removed.
627         * Scripts/webkitpy/style/processors/__init__.py: Removed.
628         * Scripts/webkitpy/style/processors/common.py: Removed.
629         * Scripts/webkitpy/style/processors/common_unittest.py: Removed.
630         * Scripts/webkitpy/style/processors/cpp.py: Removed.
631         * Scripts/webkitpy/style/processors/cpp_unittest.py: Removed.
632         * Scripts/webkitpy/style/processors/python.py: Removed.
633         * Scripts/webkitpy/style/processors/python_unittest.py: Removed.
634         * Scripts/webkitpy/style/processors/python_unittest_input.py: Removed.
635         * Scripts/webkitpy/style/processors/text.py: Removed.
636         * Scripts/webkitpy/style/processors/text_unittest.py: Removed.
637
638 2010-04-06  Ojan Vafai  <ojan@chromium.org>
639
640         Reviewed by Adam Barth.
641
642         Include git commits in the diff for webkit-patch upload/land.
643         https://bugs.webkit.org/show_bug.cgi?id=36394
644
645         Adds --squash, --no-squash and --git-commit.
646
647         --git-commit will use a specific local commit for land/upload.
648         If a commit-range is specified, then that range is treated as
649         a single squashed commit.
650
651         --squash will squash all local changes including working copy changes
652         into a single patch.
653
654         --no-squash is the legacy behavior (upload only considers the working copy,
655         land commits the working copy and then each local commit separately to SVN)
656
657         If neither is specified, then an informative error is raised if there is
658         more than one local commit or when there are local commit(s) and working
659         copy changes.
660
661         If the webkit-patch.squash git config parameter is set, then
662         that will be respected instead of raising an error.
663
664         * Scripts/check-webkit-style:
665         * Scripts/webkitpy/common/checkout/api.py:
666         * Scripts/webkitpy/common/checkout/api_unittest.py:
667         * Scripts/webkitpy/common/checkout/scm.py:
668         * Scripts/webkitpy/common/checkout/scm_unittest.py:
669         * Scripts/webkitpy/style/optparser.py:
670         --git-since is removed and --git-commit no longer implies commit_id..
671         Instead, it treats that individual commit, but also supports commit ranges
672         (e.g. commit_id..) as arguments.
673         * Scripts/webkitpy/style/optparser_unittest.py:
674         * Scripts/webkitpy/style_references.py:
675         * Scripts/webkitpy/tool/commands/download.py:
676         * Scripts/webkitpy/tool/commands/upload.py:
677         * Scripts/webkitpy/tool/main.py:
678         * Scripts/webkitpy/tool/mocktool.py:
679         * Scripts/webkitpy/tool/steps/abstractstep.py:
680         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
681         * Scripts/webkitpy/tool/steps/checkstyle.py:
682         * Scripts/webkitpy/tool/steps/commit.py:
683         * Scripts/webkitpy/tool/steps/options.py:
684         * Scripts/webkitpy/tool/steps/postdiff.py:
685         * Scripts/webkitpy/tool/steps/preparechangelog.py:
686         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
687         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
688         * Scripts/webkitpy/tool/steps/validatereviewer.py:
689
690 2010-04-26  Chris Jerdonek  <cjerdonek@webkit.org>
691
692         Reviewed by Shinichiro Hamaji.
693
694         Deleted the StyleChecker-related classes that are no longer
695         being used.
696
697         https://bugs.webkit.org/show_bug.cgi?id=38118
698
699         * Scripts/webkitpy/style/checker.py:
700           - Deleted the DeprecatedStyleChecker class.
701
702         * Scripts/webkitpy/style/checker_unittest.py:
703           - Deleted the StyleCheckerTest, StyleCheckerCheckFileBase,
704             StyleCheckerCheckFileTest, and StyleCheckerCheckPathsTest classes.
705
706 2010-04-26  Chris Jerdonek  <cjerdonek@webkit.org>
707
708         Reviewed by Shinichiro Hamaji.
709
710         Changed the StyleChecker class to use the new TextFileReader class.
711
712         https://bugs.webkit.org/show_bug.cgi?id=37066
713
714         This revision separates the code responsible for reading and iterating
715         over text files from the rest of check-webkit-style.
716
717         * Scripts/check-webkit-style:
718           - Changed the script to use the new StyleProcessor and
719             TextFileReader classes instead of the StyleChecker class.
720
721         * Scripts/webkitpy/style/checker.py:
722           - Added a FIXME to rename many of uses of the word "processor" to
723             "checker".  We did this to clarify the difference between
724             ProcessorBase instances passed to the TextFileReader and
725             classes that process and check lines for style.
726           - Added a FIXME to remove FileType.NONE as a possible return value
727             of ProcessorDispatcher._file_type().  This will better consolidate
728             the logic of which files should be skipped.
729           - Added a FIXME to delete the StyleChecker class.
730           - Added the StyleProcessor class which implements ProcessorBase.
731             This class is responsible for processing lines to check style
732             (but not for reading files).  For each file, this class creates
733             creates both a carriage-return checker and a format-specific
734             style checker (e.g. one of C++, Python, etc).
735           - Updated the PatchChecker class to use a TextFileReader instance
736             instead of a StyleChecker.
737
738         * Scripts/webkitpy/style/checker_unittest.py:
739           - Added the StyleProcessor_EndToEndTest class to do "end-to-end"
740             tests of the StyleProcessor class.
741           - Added the StyleProcessor_CodeCoverageTest to test the
742             StyleProcessor class with more complete code coverage.
743             Unlike the StyleProcessor_EndToEndTest class, this class makes
744             heavy use of mock parameters.
745           - Added FIXME's to delete the unit test classes that are no
746             longer needed.
747           - Updated the PatchCheckerTest class to use a MockTextFileReader
748             instead of a MockStyleChecker.
749
750         * Scripts/webkitpy/style/filereader.py:
751           - Updated the TextFileReader class to use the preferred logic
752             of checking file existence at the beginning of the process_file()
753             method instead of in the except block, per
754             https://bugs.webkit.org/show_bug.cgi?id=37122
755
756         * Scripts/webkitpy/style/filereader_unittest.py:
757           - In the TextFileReaderTest class:
758             - Moved the test_process_file__should_not_process() method.
759             - Added a test_process_file__file_stdin() method to test
760               the file path "-".
761
762 2010-04-20  Robert Hogan  <robert@webkit.org>
763
764         Reviewed by Simon Hausmann.
765
766         [Qt] Add more support for textInputController
767
768         Add support for selectedRange(), setMarkedText(), insertText(),
769         and firstRectForCharacterRange().
770
771         Unskip tests:
772
773         fast/forms/input-maxlength-ime-preedit.html
774         fast/forms/input-maxlength-ime-completed.html
775         fast/text/international/thai-cursor-position.html
776         fast/events/ime-composition-events-001.html
777         editing/selection/5825350-1.html
778         editing/selection/5825350-2.html
779         editing/selection/mixed-editability-10.html
780
781         https://bugs.webkit.org/show_bug.cgi?id=35702
782
783         * DumpRenderTree/qt/TextInputControllerQt.cpp:
784         (TextInputController::setMarkedText):
785         (TextInputController::insertText):
786         (TextInputController::selectedRange):
787         (TextInputController::firstRectForCharacterRange):
788         * DumpRenderTree/qt/TextInputControllerQt.h:
789
790 2010-04-23  Eric Seidel  <eric@webkit.org>
791
792         Reviewed by Adam Barth.
793
794         check-webkit-style complains about non-utf8 data in layout test result
795         https://bugs.webkit.org/show_bug.cgi?id=38027
796
797         The problem was we were assuming patch files/diff output as utf-8.
798         Turns out they're not.  We have to treat them as binary data because
799         a single patch may have multiple text files in it with conflicting encodings!
800
801         * Scripts/webkitpy/common/checkout/api.py:
802          - contents_at_revision returns a byte array, so decode it to unicode
803            before passing it to parse_latest_entry_from_file
804         * Scripts/webkitpy/common/checkout/api_unittest.py:
805          - Update our mock mock_contents_at_revision to match the encoding
806            semantics of the real one.
807         * Scripts/webkitpy/common/checkout/scm.py:
808          - Be careful not to decode output which may contain file contents
809            (like diff, cat or show) as the encoding for that content is unknown.
810         * Scripts/webkitpy/common/checkout/scm_unittest.py:
811          - Update our tests to use both latin1 and utf-8 encoded data.
812         * Scripts/webkitpy/common/net/bugzilla.py:
813          - _fill_attachment_form should not assume unicode data.  Callers
814            may wish to attach other types of files to bugs.
815         * Scripts/webkitpy/common/prettypatch.py:
816          - Diffs are byte arrays, deal with them as such.
817         * Scripts/webkitpy/common/prettypatch_unittest.py:
818          - Test to make sure we handle diffs with multiple conflicting encodings.
819         * Scripts/webkitpy/common/system/executive_unittest.py:
820          - Make sure that our unicode support does not break our
821            byte array input support for run_command.
822
823 2010-04-23  Sam Weinig  <sam@webkit.org>
824
825         Reviewed by David Levin.
826
827         Fix for https://bugs.webkit.org/show_bug.cgi?id=38060
828         Split up Threading.h
829
830         Add necessary forwarding headers.
831
832         * DumpRenderTree/ForwardingHeaders/wtf/Atomics.h: Added.
833         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h: Added.
834         * DumpRenderTree/ForwardingHeaders/wtf/ThreadingPrimitives.h: Added.
835
836 2010-04-23  Xiaomei Ji  <xji@chromium.org>
837
838         No need to review.
839
840         Add xji as committer.
841
842         * Scripts/webkitpy/common/config/committers.py:
843
844 2010-04-23  Kevin Ollivier  <kevino@theolliviers.com>
845
846         [wx] Build fix, add platform stub for new LayoutTestController method.
847
848         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
849         (LayoutTestController::markerTextForListItem):
850
851 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
852
853         Reviewed by Adam Barth.
854
855         new-run-webkit-tests: add a "--retry-failures" flag and a
856         "--no-retry-failures" flag (the former is the default). Also, rename
857         "--print-unexpected-results" and "--retry-unexpected-results" to
858         "--print-last-failures" and "--retry-last-failures" because the
859         retry flag was confusing. The new flag names aren't great, but
860         hopefully they're less confusing.
861
862         https://bugs.webkit.org/show_bug.cgi?id=37838
863
864         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
865
866 2010-04-22  Sam Weinig  <sam@webkit.org>
867
868         Reviewed by Anders Carlsson.
869
870         Fix for https://bugs.webkit.org/show_bug.cgi?id=38022
871         Move isMainThread predicate function to MainThread.h
872
873         Added forwarding header for MainThread.h
874
875         * DumpRenderTree/ForwardingHeaders/wtf/MainThread.h: Added.
876
877 2010-04-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
878
879         Reviewed by Kenneth Rohde Christiansen.
880
881         [Qt] Disable Netscape plugin support for minimal configuration
882         https://bugs.webkit.org/show_bug.cgi?id=38026
883
884         Pass the minimal configuration option to Qt build system 
885         as part of the CONFIG variable.
886
887         * Scripts/build-webkit:
888
889 2010-04-22  Fumitoshi Ukai  <ukai@chromium.org>
890
891         Unreviewed fix.
892
893         * Scripts/webkitpy/layout_tests/port/websocket_server.py: fix NameError: global name 'f' is not defined.
894
895 2010-04-22  James Robinson  <jamesr@chromium.org>
896
897         Reviewed by Adam Barth.
898
899         Revert 58077 and follow-ups.  It's broken.
900         https://bugs.webkit.org/show_bug.cgi?id=37664
901
902         * Scripts/new-run-webkit-httpd:
903         * Scripts/new-run-webkit-websocketserver:
904         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
905         * Scripts/webkitpy/layout_tests/port/http_server.py:
906         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
907
908 2010-04-22  Yaar Schnitman  <yaar@chromium.org>
909
910         Reviewed by Adam Barth.
911
912         Integrate v8 testing utility with webkit tests
913         https://bugs.webkit.org/show_bug.cgi?id=37731
914
915         * Scripts/run-bindings-tests: Added.
916
917 2010-04-22  Eric Seidel  <eric@webkit.org>
918
919         Reviewed by Dimitri Glazkov.
920
921         new-run-webkit-tests --verbose shows ever-increasing #EOF lines
922         https://bugs.webkit.org/show_bug.cgi?id=37794
923
924         * Scripts/webkitpy/layout_tests/port/webkit.py:
925          - Remove the assert() since our ServerProcess code does not always
926            seem to be reading the full stderr output (or we're not waiting for it to).
927
928 2010-04-22  Eric Seidel  <eric@webkit.org>
929
930         Reviewed by Adam Barth.
931
932         Add code to help debug new-run-webkit-test hangs on the Chromium bots
933         https://bugs.webkit.org/show_bug.cgi?id=38011
934
935         I can see no reasonable way to test this change.
936         Stubbing out sys._current_frames() and traceback.extract_stack
937         seems folly.  Dumping real data would have line number
938         (and possibly other call stack) variance between runs.
939
940         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
941          - Add _dump_thread_states and _dump_thread_states_if_necessary
942            to have our main thread dump the states of all threads every
943            60 seconds when running in verbose mode.
944          - Better document what is going on in our main loop.
945
946 2010-04-22  Sam Weinig  <sam@webkit.org>
947
948         Reviewed by Anders Carlsson.
949
950         Fix for https://bugs.webkit.org/show_bug.cgi?id=38002
951         Add rudimentary statistics gathering for WebKit2
952
953         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
954         * MiniBrowser/mac/AppDelegate.h:
955         * MiniBrowser/mac/AppDelegate.m:
956         (-[BrowserAppDelegate init]):
957         (-[BrowserAppDelegate newWindow:]):
958         (-[BrowserAppDelegate getCurrentPageNamespace]):
959         (-[BrowserAppDelegate _setProcessModel:]):
960         (-[BrowserAppDelegate showStatisticsWindow:]):
961         (-[BrowserAppDelegate applicationWillTerminate:]):
962         * MiniBrowser/mac/BrowserStatisticsWindow.xib: Added.
963         * MiniBrowser/mac/BrowserStatisticsWindowController.h: Added.
964         * MiniBrowser/mac/BrowserStatisticsWindowController.m: Added.
965         (-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
966         (-[BrowserStatisticsWindowController dealloc]):
967         (-[BrowserStatisticsWindowController windowDidLoad]):
968         (-[BrowserStatisticsWindowController refreshStatistics:]):
969         * MiniBrowser/mac/BrowserWindowController.h:
970         * MiniBrowser/mac/English.lproj/MainMenu.xib:
971         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
972
973 2010-04-22  Dave Moore  <davemoore@chromium.org>
974
975         Reviewed by Dimitri Glazkov.
976
977         Add test support for icon changes.
978
979         https://bugs.webkit.org/show_bug.cgi?id=33812
980
981         * DumpRenderTree/LayoutTestController.cpp:
982         (LayoutTestController::LayoutTestController):
983         (dumpIconChangesCallback):
984         (LayoutTestController::staticFunctions):
985         * DumpRenderTree/LayoutTestController.h:
986         (LayoutTestController::dumpIconChanges):
987         (LayoutTestController::setDumpIconChanges):
988         * DumpRenderTree/win/FrameLoadDelegate.cpp:
989         (FrameLoadDelegate::didChangeIcons):
990         * DumpRenderTree/win/FrameLoadDelegate.h:
991         * WinLauncher/WinLauncher.h:
992         (WinLauncherWebHost::didChangeIcons):
993
994 2010-04-22  Eric Seidel  <eric@webkit.org>
995
996         Unreviewed.  Script fix.  Will ask dpranke to look tomorrow.
997
998         new-run-webkit-tests --verbose shows ever-increasing #EOF lines
999         https://bugs.webkit.org/show_bug.cgi?id=37794
1000
1001         The bots are seeing cases where .error is sometimes empty.
1002         Lets make the code not crash in that case for now.
1003
1004         * Scripts/webkitpy/layout_tests/port/webkit.py:
1005
1006 2010-04-22  Fumitoshi Ukai  <ukai@chromium.org>
1007
1008         Unreviewed fix.
1009
1010         * Scripts/webkitpy/layout_tests/port/websocket_server.py: fix NameError: global name 'f' is not defined.
1011
1012 2010-04-22  Fumitoshi Ukai  <ukai@chromium.org>
1013
1014         Unreviewed fix.
1015
1016         * Scripts/new-run-webkit-websocketserver: PyWebSocket no longer takes keyword argument 'register_cygwin'.
1017
1018 2010-04-22  Eric Seidel  <eric@webkit.org>
1019
1020         Unreviewed.  Restore the Leopard bots to using
1021         old-run-webkit-tests for now.
1022
1023         * Scripts/run-webkit-tests:
1024
1025 2010-04-22  Fumitoshi Ukai  <ukai@chromium.org>
1026
1027         Unreviewed fix.
1028
1029         * Scripts/webkitpy/layout_tests/port/http_server.py: fix NameError: global name 'env' is not defined.
1030
1031 2010-04-22  Fumitoshi Ukai  <ukai@chromium.org>
1032
1033         Unreviewed fix.
1034
1035         * Scripts/webkitpy/layout_tests/port/websocket_server.py: fix NameError: global name 'env' is not defined.
1036
1037 2010-04-22  Fumitoshi Ukai  <ukai@chromium.org>
1038
1039         Reviewed by Adam Barth.
1040
1041         Chromium: Add --chromium option to new-run-webkit-websocketserver
1042         https://bugs.webkit.org/show_bug.cgi?id=37664
1043
1044         Move cygwin setup logic in chromium_win.py.
1045
1046         * Scripts/new-run-webkit-httpd: remove register_cygwin parameter to pass http_server.
1047         * Scripts/new-run-webkit-websocketserver: add --chromium flag
1048         * Scripts/webkitpy/layout_tests/port/chromium_win.py: setup for cygwin
1049         * Scripts/webkitpy/layout_tests/port/http_server.py: remove cygwin setup logic
1050         * Scripts/webkitpy/layout_tests/port/websocket_server.py: remove cygwin setup logic
1051
1052 2010-04-22  Eric Seidel  <eric@webkit.org>
1053
1054         Reviewed by Adam Barth.
1055
1056         new-run-webkit-tests --verbose shows ever-increasing #EOF lines
1057         https://bugs.webkit.org/show_bug.cgi?id=37794
1058
1059         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1060          - Fix the log message to explain that this is stderr output, not test output.
1061         * Scripts/webkitpy/layout_tests/port/webkit.py:
1062          - Be sure to reset the server_process.error after reading (seems like the wrong
1063            place to do this, but at least this fixes the bug and dpranke and I can talk
1064            about better designs later).
1065          - Also remove the #EOF from the stderr output before returning it.
1066
1067 2010-04-22  Eric Seidel  <eric@webkit.org>
1068
1069         Unreviewed.  Fixing new-run-webkit-tests on the bots.
1070
1071         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1072          - Fixing _compat_shim_option to take variable keyword args.
1073          - Turns out that nargs + callback is ignored unless type is specified.
1074            So I added the type so that the option was properly consumed.
1075            This was why new-run-webkit-tests couldn't find any tests, it
1076            was looking for them under "20" because that was the argument
1077            which should have been consumed by --exit-after-n-failures.
1078
1079 2010-04-22  Tony Chang  <tony@chromium.org>
1080
1081         Not reviewed, build fix for chromium Windows.
1082
1083         [chromium] fix ImageDiff compile on windows
1084         https://bugs.webkit.org/show_bug.cgi?id=37979
1085
1086         * DumpRenderTree/chromium/ImageDiff.cpp:
1087
1088 2010-04-22  Adam Barth  <abarth@webkit.org>
1089
1090         Unreviewed, rolling out r58069.
1091         http://trac.webkit.org/changeset/58069
1092         https://bugs.webkit.org/show_bug.cgi?id=27751
1093
1094         Broke compile on Windows.
1095
1096         * DumpRenderTree/LayoutTestController.cpp:
1097         (LayoutTestController::staticFunctions):
1098         * DumpRenderTree/LayoutTestController.h:
1099         * DumpRenderTree/chromium/LayoutTestController.cpp:
1100         (LayoutTestController::LayoutTestController):
1101         (LayoutTestController::overridePreference):
1102         * DumpRenderTree/chromium/LayoutTestController.h:
1103         * DumpRenderTree/chromium/TestShell.cpp:
1104         (TestShell::resetWebSettings):
1105         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1106         * DumpRenderTree/mac/DumpRenderTree.mm:
1107         (resetDefaultsToConsistentValues):
1108         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1109         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1110         (WebCore::WebPage::WebPage):
1111         (WebCore::WebPage::resetSettings):
1112         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1113         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1114         * DumpRenderTree/win/DumpRenderTree.cpp:
1115         (resetDefaultsToConsistentValues):
1116         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1117         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1118
1119 2010-04-22  Eric Seidel  <eric@webkit.org>
1120
1121         Unreviewed.  Just adding logging.
1122
1123         Adding logging to help debug why the Leopard Bot
1124         can't find any tests to run.
1125
1126         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
1127         * Scripts/webkitpy/layout_tests/port/base.py:
1128         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1129          - Make it a fatal error to have no tests to run.
1130
1131 2010-04-22  Abhishek Arya  <inferno@chromium.org>
1132
1133         Reviewed by Adam Barth.
1134
1135         Add support for controlling clipboard access from javascript.
1136         Clipboard access from javascript is enabled in test framework.
1137         https://bugs.webkit.org/show_bug.cgi?id=27751
1138
1139         * DumpRenderTree/LayoutTestController.cpp:
1140         (setJavaScriptCanAccessClipboardCallback):
1141         (LayoutTestController::staticFunctions):
1142         * DumpRenderTree/LayoutTestController.h:
1143         * DumpRenderTree/chromium/LayoutTestController.cpp:
1144         (LayoutTestController::LayoutTestController):
1145         (LayoutTestController::setJavaScriptCanAccessClipboard):
1146         (LayoutTestController::overridePreference):
1147         * DumpRenderTree/chromium/LayoutTestController.h:
1148         * DumpRenderTree/chromium/TestShell.cpp:
1149         (TestShell::resetWebSettings):
1150         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1151         (LayoutTestController::setJavaScriptCanAccessClipboard):
1152         * DumpRenderTree/mac/DumpRenderTree.mm:
1153         (resetDefaultsToConsistentValues):
1154         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1155         (LayoutTestController::setJavaScriptCanAccessClipboard):
1156         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1157         (WebCore::WebPage::WebPage):
1158         (WebCore::WebPage::resetSettings):
1159         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1160         (LayoutTestController::setJavaScriptCanAccessClipboard):
1161         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1162         * DumpRenderTree/win/DumpRenderTree.cpp:
1163         (resetDefaultsToConsistentValues):
1164         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1165         (LayoutTestController::setJavaScriptCanAccessClipboard):
1166         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1167         (LayoutTestController::setJavaScriptCanAccessClipboard):
1168
1169 2010-04-21  Adam Barth  <abarth@webkit.org>
1170
1171         Reviewed by Eric Seidel.
1172
1173         webkit-patch can't fetch attachments on security bugs
1174         https://bugs.webkit.org/show_bug.cgi?id=37975
1175
1176         Instead of calling CURL, we just need to use our Mechanize object,
1177         which understand bugs.webkit.org authentication.
1178
1179         * Scripts/webkitpy/common/checkout/api.py:
1180         * Scripts/webkitpy/common/net/bugzilla.py:
1181
1182 2010-04-21  Eric Seidel  <eric@webkit.org>
1183
1184         Unreviewed.  Temporary commit, will roll-out before morning.
1185
1186         Turning on new-run-webkit-tests for the Leopard build bot
1187         for testing of the harness.
1188         Users should not noctice (except for the results.html difference).
1189
1190         * Scripts/run-webkit-tests:
1191
1192 2010-04-21  Eric Seidel  <eric@webkit.org>
1193
1194         Unreviewed.  Fix typo in my previous fix attempt.
1195
1196         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1197         https://bugs.webkit.org/show_bug.cgi?id=37765
1198
1199         More on-the-bot debugging, sigh.  I wish I had a local build.
1200
1201         * Scripts/webkitpy/layout_tests/port/base.py:
1202
1203 2010-04-21  Eric Seidel  <eric@webkit.org>
1204
1205         Unreviewed.  Fix typo in my previous fix attempt.
1206
1207         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1208         https://bugs.webkit.org/show_bug.cgi?id=37765
1209
1210         * Scripts/webkitpy/layout_tests/port/base.py:
1211          - Add self. to class variable access.
1212
1213 2010-04-21  Eric Seidel  <eric@webkit.org>
1214
1215         Unreviewed.  Another attempt to fix NRWT for chromium.
1216
1217         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1218         https://bugs.webkit.org/show_bug.cgi?id=37765
1219
1220         * Scripts/webkitpy/layout_tests/port/base.py:
1221          - wdiff_text was returning a byte array instead of a
1222            unicode string.  The simple fix was to just decode
1223            the result.  However, seeing so much duplicated code
1224            with Executive made me cry, so I re-wrote the function
1225            to be more like pretty_patch_text and use run_command
1226            (which already knows how to handle unicode).
1227
1228 2010-04-21  Adam Barth  <abarth@webkit.org>
1229
1230         Reviewed by Eric Seidel.
1231
1232         Windows tests buildbots are too slow to be core builders
1233         https://bugs.webkit.org/show_bug.cgi?id=37970
1234
1235         It's 10:45.  The Windows test bots are still hours behind.  They're too
1236         slow to be core builders.  When they get fast, we can add them back.
1237
1238         * Scripts/webkitpy/common/net/buildbot.py:
1239         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1240
1241 2010-04-21  Eric Seidel  <eric@webkit.org>
1242
1243         Unreviewed.  Attempt one more time to fix NRWT for chromium.
1244
1245         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1246         https://bugs.webkit.org/show_bug.cgi?id=37765
1247
1248         I'm debugging in the blind because I don't have a chromium
1249         build on this laptop.
1250
1251         * Scripts/webkitpy/layout_tests/port/chromium.py:
1252          - Apply the previous fix to a second caller.
1253
1254 2010-04-21  Eric Seidel  <eric@webkit.org>
1255
1256         Unreviewed.  Attempt one more time to fix NRWT for chromium.
1257
1258         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1259         https://bugs.webkit.org/show_bug.cgi?id=37765
1260
1261         * Scripts/webkitpy/layout_tests/port/chromium.py:
1262          - Fix handling of test_shell output so that we always
1263            decode it as utf-8.
1264            Unlike DumpRenderTree test_shell does not ever return
1265            pixel data.  It spits out the pixel dumps in a separate
1266            file, thus all output over stdout is utf-8 text.
1267
1268 2010-04-21  Eric Seidel  <eric@webkit.org>
1269
1270         Unreviewed.  Attempt one more time to fix NRWT for chromium.
1271
1272         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1273         https://bugs.webkit.org/show_bug.cgi?id=37765
1274
1275         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1276          - Pass encoding to _save_baseline_data and write_output_files
1277         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1278          - Make _save_baseline_data and write_output_files take an encoding.
1279         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1280         - Pass encoding to _save_baseline_data and write_output_files
1281
1282 2010-04-21  No'am Rosenthal  <noam.rosenthal@nokia.com>
1283
1284         Reviewed by Kenneth Rohde Christiansen.
1285
1286         [Qt] QtLauncher: make FPS measurement accurate
1287         https://bugs.webkit.org/show_bug.cgi?id=37934
1288
1289         Instead of counting paints, which are not interchangeable with frames that
1290         the user sees, we now set an arbitrary timer for FPS measurements. The idea is
1291         that if the main thread is delayed for any reason, that timer would be delayed
1292         as well.
1293
1294         * QtLauncher/QtLauncher.pro:
1295         * QtLauncher/fpstimer.cpp: Added.
1296         (FpsTimer::FpsTimer):
1297         (FpsTimer::numFrames):
1298         (FpsTimer::start):
1299         (FpsTimer::stop):
1300         (FpsTimer::timerEvent):
1301         * QtLauncher/fpstimer.h: Added.
1302         * QtLauncher/webview.cpp:
1303         (WebViewGraphicsBased::setFrameRateMeasurementEnabled):
1304         (WebViewGraphicsBased::updateFrameRate):
1305         (WebViewGraphicsBased::paintEvent):
1306         * QtLauncher/webview.h:
1307
1308 2010-04-21  Eric Seidel  <eric@webkit.org>
1309
1310         Unreviewed, just adding missing ":" in python file.
1311
1312         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1313         https://bugs.webkit.org/show_bug.cgi?id=37765
1314
1315         new-run-webkit-tests --chromium was borked.
1316
1317         * Scripts/webkitpy/layout_tests/port/chromium.py:
1318
1319 2010-04-21  Eric Seidel  <eric@webkit.org>
1320
1321         Reviewed by Adam Barth.
1322
1323         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1324         https://bugs.webkit.org/show_bug.cgi?id=37765
1325
1326         Third time is the charm.  I've fixed all the
1327         new-run-webkit-tests regressions from previous attempts.
1328
1329         I fixed the queue to not ignore Tor as a reviwer in r57531,
1330         but instead it throws an exception every time his name is in a patch.
1331
1332         This fixes our Executive.run_command code to work around a Popen
1333         bug http://bugs.python.org/issue5290 whereby python versions before 2.6
1334         do not correctly handle unicode objects as input or output to
1335         Popen.communicate.
1336
1337         Following the advice of:
1338         http://farmdev.com/talks/unicode/
1339         I have changed all of webkitpy to use unicode() objects as strings
1340         instead of str objects (which in Python 3 are renamed "bytes").
1341
1342         String literals were left as "foo" instead of converting to u"foo"
1343         as u"foo" is only required if the string has a non-ascii code point.
1344         Python is smart about comparing str() and unicode() values and will
1345         log an error to the console if the comparison is ever invalid.
1346
1347         Executive.run* now correctly accept and return unicode() objects.
1348         I attempted to fix all the places that we call .write() to make sure we
1349         encode any unicode() objects into utf-8.
1350
1351         I removed several uses of StringIO.  StringIO should generally always be
1352         passed a unicode() value.
1353
1354         Likewise I replaced most calls to open() with codecs.open().
1355         codecs.open() matches Python 3 open semantics in requiring an encoding
1356         parameter.  Files opened with codecs.open() with a unicode-compatible
1357         encoding will vend unicode() objects from their read() calls, like how
1358         StringIO created with a unicode() object will do.
1359
1360         I also deployed "with" statements wider (now that the project has
1361         settled on Python 2.5) to close a bunch of file descriptor leaks.
1362
1363         * Scripts/webkitpy/common/checkout/api_unittest.py:
1364          - Read/write utf-8 files instead of ascii.
1365          - Update the tests to use test for proper unicode() handling.
1366         * Scripts/webkitpy/common/checkout/changelog.py:
1367          - Document that parse_latest_entry_from_file expects
1368            file-like objects which return unicode strings.
1369         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1370          - Use unicode() strings instead of str() byte arrays.
1371          - Deploy "with" to close file descriptor leaks.
1372         * Scripts/webkitpy/common/checkout/commitinfo.py:
1373          - Remove unneeded import.
1374         * Scripts/webkitpy/common/checkout/scm.py:
1375          - Remove use of str().
1376         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1377          - Read/write utf-8 files and use unicode() strings in testing.
1378         * Scripts/webkitpy/common/config/committers.py:
1379          - Use \u instead of \x to make slightly clearer what we're doing.
1380         * Scripts/webkitpy/common/net/bugzilla.py:
1381          - Add a new _string_contents() method and explain why
1382             we have to call unicode() on the result of soup.string
1383             and why it's safe to do so w/o needing to pass a codec name.
1384           - Remove the (unused) support for passing a file object to add_patch_to_bug().
1385         * Scripts/webkitpy/common/net/buildbot.py:
1386          - Use unicode() instead of str() when needing to coax a
1387             NavigableString object into a unicode() object.
1388         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1389          - Add a test which contains a unicode builder name.
1390         * Scripts/webkitpy/common/net/statusserver.py:
1391          - Remove use of str()
1392         * Scripts/webkitpy/common/prettypatch.py:
1393          - Write out the patch file as utf-8.
1394         * Scripts/webkitpy/common/system/autoinstall.py:
1395          - Write out files with a explicit encodings.
1396          - Deploy "with" to close file descriptor leaks.
1397         * Scripts/webkitpy/common/system/deprecated_logging.py:
1398          - Write out log files as utf-8.
1399         * Scripts/webkitpy/common/system/executive.py:
1400          - Make run* properly take and return unicode() objects.
1401          - Cleaned up input handling in run_command a little by adding
1402            a _compute_input() method which can return early instead of having
1403            such a long/cluttered if-block.
1404         * Scripts/webkitpy/common/system/executive_unittest.py:
1405          - Added a unit test to make sure we don't break Tor again!
1406         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1407          - Write out the test list as utf-8.
1408         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1409          - Write out json files as utf-8.
1410         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1411          - Deploy "with" to close file descriptor leaks.
1412         * Scripts/webkitpy/layout_tests/port/chromium.py: Add Executive.py FIXME.
1413         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: ditto.
1414         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: ditto.
1415         * Scripts/webkitpy/layout_tests/port/gtk.py: ditto.
1416         * Scripts/webkitpy/layout_tests/port/mac.py: ditto.
1417         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1418          - Make the skipped file parsing test unicode.
1419         * Scripts/webkitpy/layout_tests/port/qt.py: Add Executive.py FIXME.
1420         * Scripts/webkitpy/layout_tests/port/server_process.py: ditto.
1421         * Scripts/webkitpy/layout_tests/port/webkit.py:
1422          - Deploy "with" to close file descriptor leaks.
1423         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1424          - Make explicit the encodings of log files and pid files.
1425         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1426          - Make encodings explicit and deploy "with".
1427         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: ditto.
1428         * Scripts/webkitpy/layout_tests/test_types/image_diff.py: ditto.
1429         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: ditto.
1430         * Scripts/webkitpy/layout_tests/test_types/text_diff.py: ditto.
1431         * Scripts/webkitpy/style/filereader_unittest.py: ditto.
1432         * Scripts/webkitpy/thirdparty/__init__.py: ditto.
1433         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1434          - Removed extra import.
1435         * Scripts/webkitpy/tool/commands/queues.py:
1436          - No need to map args to strings now that run_command does.
1437          - Update test results to match args changes.
1438          - Document our global argument hacks.
1439         * Scripts/webkitpy/tool/commands/upload.py:
1440          - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
1441         * Scripts/webkitpy/tool/mocktool.py:
1442          - Rename add_patch_to_bug argument to match bugzilla.py
1443         * Scripts/webkitpy/tool/steps/abstractstep.py:
1444          - Executive.run_* now require lists instead of strings.
1445            The lack of this change was what broke webkit-patch
1446            for svn users the first time this was landed.
1447         * Scripts/webkitpy/tool/steps/postdiff.py:
1448          - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
1449         * Scripts/webkitpy/tool/steps/postdiffforcommit.py: ditto
1450         * Scripts/webkitpy/tool/steps/postdiffforrevert.py: ditto
1451         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1452          - Fixed spurious logging seen when running test-webkitpy
1453
1454 2010-04-21  Chris Fleizach  <cfleizach@apple.com>
1455
1456         Reviewed by Alexey Proskuryakov.
1457
1458         aria-liveregion-notifications.html fails on leopard release bot
1459         https://bugs.webkit.org/show_bug.cgi?id=37112
1460
1461         Change the way that notifications are listened for by forcing clients
1462         to call a remove listener as well to match the add listener. DRT will
1463         assert if those are not done in the correct order. 
1464
1465         * DumpRenderTree/AccessibilityUIElement.cpp:
1466         (removeNotificationListenerCallback):
1467         (AccessibilityUIElement::getJSClass):
1468         * DumpRenderTree/AccessibilityUIElement.h:
1469         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1470         (AccessibilityUIElement::removeNotificationListener):
1471         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1472         (-[AccessibilityNotificationHandler initWithPlatformElement:]):
1473         (-[AccessibilityNotificationHandler dealloc]):
1474         (-[AccessibilityNotificationHandler _notificationReceived:]):
1475         (-[AccessibilityNotificationHandler setCallback:]):
1476         (AccessibilityUIElement::AccessibilityUIElement):
1477         (AccessibilityUIElement::~AccessibilityUIElement):
1478         (AccessibilityUIElement::addNotificationListener):
1479         (AccessibilityUIElement::removeNotificationListener):
1480         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1481         (AccessibilityUIElement::removeNotificationListener):
1482
1483 2010-04-21  Anders Carlsson  <andersca@apple.com>
1484
1485         Reviewed by Sam Weinig.
1486
1487         Add debug menu items to show/hide the Web View.
1488         https://bugs.webkit.org/show_bug.cgi?id=37958
1489
1490         * MiniBrowser/mac/BrowserWindowController.h:
1491         * MiniBrowser/mac/BrowserWindowController.m:
1492         (-[BrowserWindowController showHideWebView:]):
1493         (-[BrowserWindowController removeReinsertWebView:]):
1494         (-[BrowserWindowController validateMenuItem:]):
1495         * MiniBrowser/mac/English.lproj/MainMenu.xib:
1496
1497 2010-04-21  Eric Seidel  <eric@webkit.org>
1498
1499         Unreviewed.  Rolling out unicode() changes as they broke NRWT for chromium.
1500         Rolling out:
1501         http://trac.webkit.org/changeset/58014
1502         http://trac.webkit.org/changeset/58016
1503         http://trac.webkit.org/changeset/58020
1504
1505         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbo
1506         https://bugs.webkit.org/show_bug.cgi?id=37765
1507
1508         * Scripts/webkitpy/common/checkout/api_unittest.py:
1509         * Scripts/webkitpy/common/checkout/changelog.py:
1510         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1511         * Scripts/webkitpy/common/checkout/commitinfo.py:
1512         * Scripts/webkitpy/common/checkout/scm.py:
1513         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1514         * Scripts/webkitpy/common/config/committers.py:
1515         * Scripts/webkitpy/common/net/bugzilla.py:
1516         * Scripts/webkitpy/common/net/buildbot.py:
1517         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1518         * Scripts/webkitpy/common/net/statusserver.py:
1519         * Scripts/webkitpy/common/prettypatch.py:
1520         * Scripts/webkitpy/common/system/autoinstall.py:
1521         * Scripts/webkitpy/common/system/deprecated_logging.py:
1522         * Scripts/webkitpy/common/system/executive.py:
1523         * Scripts/webkitpy/common/system/executive_unittest.py:
1524         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1525         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1526         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1527         * Scripts/webkitpy/layout_tests/port/chromium.py:
1528         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1529         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1530         * Scripts/webkitpy/layout_tests/port/gtk.py:
1531         * Scripts/webkitpy/layout_tests/port/mac.py:
1532         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1533         * Scripts/webkitpy/layout_tests/port/qt.py:
1534         * Scripts/webkitpy/layout_tests/port/server_process.py:
1535         * Scripts/webkitpy/layout_tests/port/webkit.py:
1536         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1537         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1538         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1539         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1540         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1541         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1542         * Scripts/webkitpy/style/filereader_unittest.py:
1543         * Scripts/webkitpy/thirdparty/__init__.py:
1544         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1545         * Scripts/webkitpy/tool/commands/queues.py:
1546         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1547         * Scripts/webkitpy/tool/commands/upload.py:
1548         * Scripts/webkitpy/tool/mocktool.py:
1549         * Scripts/webkitpy/tool/steps/abstractstep.py:
1550         * Scripts/webkitpy/tool/steps/postdiff.py:
1551         * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
1552         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
1553         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1554
1555 2010-04-21  Eric Seidel  <eric@webkit.org>
1556
1557         Unreviewed, fixing NRWT for real this time.
1558
1559         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1560         https://bugs.webkit.org/show_bug.cgi?id=37765
1561
1562         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1563          - Add a hack to fix new-run-webkit-tests
1564            my understanding of codecs.open(encoding=None)
1565            must have been wrong.
1566
1567 2010-04-21  Eric Seidel  <eric@webkit.org>
1568
1569         Unreviewed, just fixing exception seen on builders.
1570
1571         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1572         https://bugs.webkit.org/show_bug.cgi?id=37765
1573
1574         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1575          - Pass and encoding to _write_into_file_at_path
1576
1577 2010-04-21  Eric Seidel  <eric@webkit.org>
1578
1579         Reviewed by Adam Barth.
1580
1581         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1582         https://bugs.webkit.org/show_bug.cgi?id=37765
1583
1584         I fixed the queue to not ignore Tor as a reviwer in r57531,
1585         but instead it throws an exception every time his name is in a patch.
1586
1587         This fixes our Executive.run_command code to work around a Popen
1588         bug http://bugs.python.org/issue5290 whereby python versions before 2.6
1589         do not correctly handle unicode objects as input or output to
1590         Popen.communicate.
1591
1592         Following the advice of:
1593         http://farmdev.com/talks/unicode/
1594         I have changed all of webkitpy to use unicode() objects as strings
1595         instead of str objects (which in Python 3 are renamed "bytes").
1596
1597         String literals were left as "foo" instead of converting to u"foo"
1598         as u"foo" is only required if the string has a non-ascii code point.
1599         Python is smart about comparing str() and unicode() values and will
1600         log an error to the console if the comparison is ever invalid.
1601
1602         Executive.run* now correctly accept and return unicode() objects.
1603         I attempted to fix all the places that we call .write() to make sure we
1604         encode any unicode() objects into utf-8.
1605
1606         I removed several uses of StringIO.  StringIO should generally always be
1607         passed a unicode() value.
1608
1609         Likewise I replaced most calls to open() with codecs.open().
1610         codecs.open() matches Python 3 open semantics in requiring an encoding
1611         parameter.  Files opened with codecs.open() with a unicode-compatible
1612         encoding will vend unicode() objects from their read() calls, like how
1613         StringIO created with a unicode() object will do.
1614
1615         I also deployed "with" statements wider (now that the project has
1616         settled on Python 2.5) to close a bunch of file descriptor leaks.
1617
1618         * Scripts/webkitpy/common/checkout/api_unittest.py:
1619          - Read/write utf-8 files instead of ascii.
1620          - Update the tests to use test for proper unicode() handling.
1621         * Scripts/webkitpy/common/checkout/changelog.py:
1622          - Document that parse_latest_entry_from_file expects
1623            file-like objects which return unicode strings.
1624         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1625          - Use unicode() strings instead of str() byte arrays.
1626          - Deploy "with" to close file descriptor leaks.
1627         * Scripts/webkitpy/common/checkout/commitinfo.py:
1628          - Remove unneeded import.
1629         * Scripts/webkitpy/common/checkout/scm.py:
1630          - Remove use of str().
1631         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1632          - Read/write utf-8 files and use unicode() strings in testing.
1633         * Scripts/webkitpy/common/config/committers.py:
1634          - Use \u instead of \x to make slightly clearer what we're doing.
1635         * Scripts/webkitpy/common/net/bugzilla.py:
1636          - Add a new _string_contents() method and explain why
1637             we have to call unicode() on the result of soup.string
1638             and why it's safe to do so w/o needing to pass a codec name.
1639           - Remove the (unused) support for passing a file object to add_patch_to_bug().
1640         * Scripts/webkitpy/common/net/buildbot.py:
1641          - Use unicode() instead of str() when needing to coax a
1642             NavigableString object into a unicode() object.
1643         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1644          - Add a test which contains a unicode builder name.
1645         * Scripts/webkitpy/common/net/statusserver.py:
1646          - Remove use of str()
1647         * Scripts/webkitpy/common/prettypatch.py:
1648          - Write out the patch file as utf-8.
1649         * Scripts/webkitpy/common/system/autoinstall.py:
1650          - Write out files with a explicit encodings.
1651          - Deploy "with" to close file descriptor leaks.
1652         * Scripts/webkitpy/common/system/deprecated_logging.py:
1653          - Write out log files as utf-8.
1654         * Scripts/webkitpy/common/system/executive.py:
1655          - Make run* properly take and return unicode() objects.
1656          - Cleaned up input handling in run_command a little by adding
1657            a _compute_input() method which can return early instead of having
1658            such a long/cluttered if-block.
1659         * Scripts/webkitpy/common/system/executive_unittest.py:
1660          - Added a unit test to make sure we don't break Tor again!
1661         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1662          - Write out the test list as utf-8.
1663         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1664          - Write out json files as utf-8.
1665         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1666          - Deploy "with" to close file descriptor leaks.
1667         * Scripts/webkitpy/layout_tests/port/chromium.py: Add Executive.py FIXME.
1668         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: ditto.
1669         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: ditto.
1670         * Scripts/webkitpy/layout_tests/port/gtk.py: ditto.
1671         * Scripts/webkitpy/layout_tests/port/mac.py: ditto.
1672         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1673          - Make the skipped file parsing test unicode.
1674         * Scripts/webkitpy/layout_tests/port/qt.py: Add Executive.py FIXME.
1675         * Scripts/webkitpy/layout_tests/port/server_process.py: ditto.
1676         * Scripts/webkitpy/layout_tests/port/webkit.py:
1677          - Deploy "with" to close file descriptor leaks.
1678         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1679          - Make explicit the encodings of log files and pid files.
1680         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1681          - Make encodings explicit and deploy "with".
1682         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: ditto.
1683         * Scripts/webkitpy/layout_tests/test_types/image_diff.py: ditto.
1684         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: ditto.
1685         * Scripts/webkitpy/layout_tests/test_types/text_diff.py: ditto.
1686         * Scripts/webkitpy/style/filereader_unittest.py: ditto.
1687         * Scripts/webkitpy/thirdparty/__init__.py: ditto.
1688         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1689          - Removed extra import.
1690         * Scripts/webkitpy/tool/commands/queues.py:
1691          - No need to map args to strings now that run_command does.
1692          - Update test results to match args changes.
1693          - Document our global argument hacks.
1694         * Scripts/webkitpy/tool/commands/upload.py:
1695          - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
1696         * Scripts/webkitpy/tool/mocktool.py:
1697          - Rename add_patch_to_bug argument to match bugzilla.py
1698         * Scripts/webkitpy/tool/steps/abstractstep.py:
1699          - Executive.run_* now require lists instead of strings.
1700            The lack of this change was what broke webkit-patch
1701            for svn users the first time this was landed.
1702         * Scripts/webkitpy/tool/steps/postdiff.py:
1703          - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
1704         * Scripts/webkitpy/tool/steps/postdiffforcommit.py: ditto
1705         * Scripts/webkitpy/tool/steps/postdiffforrevert.py: ditto
1706         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1707          - Fixed spurious logging seen when running test-webkitpy
1708
1709 2010-04-21  Kinuko Yasuda  <kinuko@chromium.org>
1710
1711         Unreviewed.
1712
1713         Add myself in committers.py.
1714
1715         * Scripts/webkitpy/common/config/committers.py:
1716
1717 2010-04-21  Dirk Pranke  <dpranke@chromium.org>
1718
1719         Reviewed by Dimitri Glazkov.
1720
1721         new-run-webkit-tests: fix a bug in the Chromium port where we would
1722         try to talk to a crashed test_shell and raise exceptions that weren't
1723         being caught.
1724
1725         https://bugs.webkit.org/show_bug.cgi?id=37941
1726
1727         * Scripts/webkitpy/layout_tests/port/chromium.py:
1728
1729 2010-04-21  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1730
1731         Unreviewed.
1732
1733         [Qt] [Symbian] Build fix.
1734
1735         Work around a Qt quirk. Some versions of Symbian port Qt
1736         QFontDatabase::removeAllApplicationFonts symbol is not available.
1737
1738         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1739         (WebCore::DumpRenderTree::open):
1740
1741 2010-04-21  Alexey Proskuryakov  <ap@apple.com>
1742
1743         Unreviewed.
1744
1745         https://bugs.webkit.org/show_bug.cgi?id=37933
1746         <rdar://problem/7719540> XMLHttpRequest.withCredentials should be better enforced.
1747
1748         Adding stub implementation of authenticateSession(). Depending on platform loader behavior,
1749         a real implementation may or may not be necessary for the one test that currently uses it
1750         to pass.
1751
1752         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1753         (LayoutTestController::authenticateSession):
1754         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1755
1756 2010-04-21  Alexey Proskuryakov  <ap@apple.com>
1757
1758         Reviewed by Brady Eidson.
1759
1760         https://bugs.webkit.org/show_bug.cgi?id=37933
1761         <rdar://problem/7719540> XMLHttpRequest.withCredentials should be better enforced.
1762
1763         Adding authenticateSession() method that adds credentials to per-process credential storage
1764         (for platforms that even have such). No Windows implementation, because writing another
1765         loader for DRT is painful.
1766
1767         * DumpRenderTree/LayoutTestController.cpp:
1768         (authenticateSessionCallback):
1769         (LayoutTestController::staticFunctions):
1770         * DumpRenderTree/LayoutTestController.h:
1771         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1772         (-[SynchronousLoader dealloc]):
1773         (-[SynchronousLoader connectionShouldUseCredentialStorage:]):
1774         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
1775         (-[SynchronousLoader connection:didFailWithError:]):
1776         (-[SynchronousLoader connectionDidFinishLoading:]):
1777         (+[SynchronousLoader makeRequest:withUsername:password:]):
1778         (LayoutTestController::authenticateSession):
1779
1780         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1781         (LayoutTestController::authenticateSession):
1782         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1783         (LayoutTestController::authenticateSession):
1784         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1785         (LayoutTestController::authenticateSession):
1786         Stub implementations.
1787
1788 2010-04-21  Kent Tamura  <tkent@chromium.org>
1789
1790         Reviewed by Dimitri Glazkov.
1791
1792         [DRT/Chromium] Make DRT compilable in Chromium tree
1793         https://bugs.webkit.org/show_bug.cgi?id=37923
1794
1795         We need to use different GYPs in a case of WebKit-only checkout
1796         and a case of whole Chromium checkout because the relative paths
1797         from webkit/ to WebKit/chromium/features.gypi are different in
1798         these cases and we can't use 'conditions' for 'includes' in GYPs.
1799
1800         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1801
1802 2010-04-21  Jakub Wieczorek  <jwieczorek@webkit.org>
1803
1804         Reviewed by Darin Adler.
1805
1806         List item markers are not always updated after changes in the DOM.
1807         https://bugs.webkit.org/show_bug.cgi?id=37060
1808
1809         * DumpRenderTree/LayoutTestController.cpp:
1810         (markerTextForListItemCallback): A function that returns the marker text for a given list item.
1811         (LayoutTestController::staticFunctions):
1812         * DumpRenderTree/LayoutTestController.h:
1813         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1814         (LayoutTestController::markerTextForListItem): Implement it in the GTK port.
1815         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1816         (LayoutTestController::markerTextForListItem): Add a stub.
1817         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1818         (LayoutTestController::LayoutTestController):
1819         (LayoutTestController::markerTextForListItem): Implement it in the Qt port.
1820         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1821         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1822         (LayoutTestController::markerTextForListItem): Add a stub.
1823
1824 2010-04-21  Adam Roben  <aroben@apple.com>
1825
1826         Exclude leaks in CGGradientCreateWithColorComponents from
1827         run-webkit-tests leaks output
1828
1829         The leak in CG is covered by <rdar://problem/7888492>.
1830
1831         Fixes <http://webkit.org/b/37927>.
1832
1833         Reviewed by Eric Carlson.
1834
1835         * Scripts/old-run-webkit-tests:
1836         (sub countAndPrintLeaks): Exclude leaks in
1837         CGGradientCreateWithColorComponents on certain OSs.
1838
1839 2010-04-21  Kent Tamura  <tkent@chromium.org>
1840
1841         Reviewed by Shinichiro Hamaji.
1842
1843         [DRT/Chromium] Import MockSpellCheck from Chromium
1844         https://bugs.webkit.org/show_bug.cgi?id=37910
1845
1846         Import webkit/tools/test_shell/mock_spellcheck.{cc,h} rev.37241 of Chromium.
1847
1848         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1849           Add ICU explicitly because WTFString.h includes ICU headers.
1850           Add MockSpellCheck.{cpp,h}.
1851         * DumpRenderTree/chromium/MockSpellCheck.cpp: Added.
1852         * DumpRenderTree/chromium/MockSpellCheck.h: Added.
1853         * DumpRenderTree/chromium/WebViewHost.cpp:
1854         (WebViewHost::spellCheck):
1855         * DumpRenderTree/chromium/WebViewHost.h:
1856         * DumpRenderTree/chromium/config.h: Define JS_EXPORTDATA, which is used
1857           by wtf/text/AtomicString.h included by wtf/text/WTFString.h.
1858
1859 2010-04-21  Adam Barth  <abarth@webkit.org>
1860
1861         Reviewed by Eric Seidel.
1862
1863         Add webkit-patch pretty-diff
1864         https://bugs.webkit.org/show_bug.cgi?id=37892
1865
1866         This is slightly lame because it asks you whether the diff is correct,
1867         but it's a starting point.
1868
1869         * Scripts/webkitpy/tool/commands/__init__.py:
1870         * Scripts/webkitpy/tool/commands/prettydiff.py: Added.
1871         * Scripts/webkitpy/tool/main.py:
1872
1873 2010-04-21  Adam Barth  <abarth@webkit.org>
1874
1875         Reviewed by Darin Adler.
1876
1877         Remove mention of non-existant --no-build option
1878         https://bugs.webkit.org/show_bug.cgi?id=37893
1879
1880         The option doesn't exist!
1881
1882         * Scripts/webkitpy/tool/commands/stepsequence.py:
1883
1884 2010-04-21  Balazs Kelemen  <kb@inf.u-szeged.hu>
1885
1886         Reviewed by Kenneth Rohde Christiansen.
1887
1888         [Qt] Interrupting JavaScript is cumbersome when you use QtLaucher for testing or profiling.
1889         https://bugs.webkit.org/show_bug.cgi?id=37198
1890
1891         * QtLauncher/main.cpp:
1892         (LauncherWindow::toggleInterruptingJavaScriptEnabled):
1893         (LauncherWindow::newWindow):
1894         (LauncherWindow::cloneWindow):
1895         (LauncherWindow::createChrome):
1896         (main):
1897         * QtLauncher/webpage.cpp:
1898         (WebPage::WebPage):
1899         (WebPage::shouldInterruptJavaScript):
1900         * QtLauncher/webpage.h:
1901         (WebPage::setInterruptingJavaScriptEnabled):
1902
1903 2010-04-21  Eric Seidel  <eric@webkit.org>
1904
1905         Unreviewed, rolling out r57963.
1906         http://trac.webkit.org/changeset/57963
1907         https://bugs.webkit.org/show_bug.cgi?id=37759
1908
1909         Three tests started crashing on the Qt bot.
1910
1911         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1912         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1913
1914 2010-04-21  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1915
1916         Reviewed by Eric Seidel.
1917
1918         Make new-run-webkit-tests work for the Qt port
1919         https://bugs.webkit.org/show_bug.cgi?id=37588
1920
1921         * Scripts/webkitpy/layout_tests/port/qt.py:
1922
1923 2010-04-21  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1924
1925         Reviewed by Eric Seidel.
1926
1927         new-run-webkit-tests: try to detect alternate apache path
1928         https://bugs.webkit.org/show_bug.cgi?id=37587
1929
1930         _check_port_build() also needs to return true in the
1931         base implementation to not fail the check_build step.
1932
1933         * Scripts/webkitpy/layout_tests/port/webkit.py:
1934
1935 2010-04-21  Yi Shen  <yi.4.shen@nokia.com>
1936
1937         Reviewed by Simon Hausmann.
1938
1939         [Qt] Add LayoutTestController interface: computedStyleIncludingVisitedInfo
1940         https://bugs.webkit.org/show_bug.cgi?id=37759
1941
1942         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1943         (LayoutTestController::computedStyleIncludingVisitedInfo):
1944         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1945
1946 2010-04-21  Eric Seidel  <eric@webkit.org>
1947
1948         Unreviewed, test fix only.
1949
1950         new-run-webkit-tests: implement a --log trace message to be able to display detailed output of an individual test run
1951         https://bugs.webkit.org/show_bug.cgi?id=37726
1952
1953         This change seems to have broken a test.
1954         Attempting to handle the case where we don't have any
1955         timing information.  Dirk may have to correct this change.
1956
1957         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1958
1959 2010-04-19  Eric Seidel  <eric@webkit.org>
1960
1961         Reviewed by Adam Barth.
1962
1963         new-run-webkit-tests has much higher startup latency than run-webkit-tests
1964         https://bugs.webkit.org/show_bug.cgi?id=37643
1965
1966         I got rid of the -expected.checksum reads during startup.
1967         This makes startup noticably better on my laptop.
1968
1969         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1970          - Use image_hash() instead of .image_hash now that expected.checksum
1971            file reads are done lazily.
1972         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1973          - Add debug logging for this sleep call.
1974            In my testing I never saw this sleep() hit.
1975         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1976          - Sleep a shorter interval to make websocket server
1977            startup more responsive.  On my machine startup was
1978            taking around 1 second.
1979          - Remove the unconditional .5s delay on startup.
1980         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1981          - Make image_hash file reads done lazily in a new image_hash() function.
1982          - Add a "Starting testing ..." meter update after DRT threads have
1983            been started, but before we get updates from the first one.
1984          - Rename variable "t" to a full english name to match WebKit style.
1985
1986 2010-04-20  Daniel Bates  <dbates@rim.com>
1987
1988         Reviewed by Eric Seidel.
1989
1990         https://bugs.webkit.org/show_bug.cgi?id=37748
1991
1992         Make Sheriffbot more inspirational.
1993
1994         * Scripts/webkitpy/common/net/bugzilla.py:
1995         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
1996         * Scripts/webkitpy/tool/bot/irc_command.py:
1997         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1998         * Scripts/webkitpy/tool/mocktool.py:
1999
2000 2010-04-20  Kent Tamura  <tkent@chromium.org>
2001
2002         Reviewed by Dimitri Glazkov.
2003
2004         [DRT/Chromium] Import Chromium image_diff as ImageDiff
2005         https://bugs.webkit.org/show_bug.cgi?id=37790
2006
2007         ImageDiff.cpp is based on tools/imagediff/image_diff.cc r41911 of Chromium.
2008
2009         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2010         * DumpRenderTree/chromium/ImageDiff.cpp: Added.
2011         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2012
2013 2010-04-20  Dirk Pranke <dpranke@chromium.org>
2014
2015         This patch to new-run-webkit-tests adds a --log 'trace' option
2016         that prints out detailed info about a given test as it executes
2017         (where the baselines are, what the expectation is, what we got,
2018         how long it took).
2019
2020         https://bugs.webkit.org/show_bug.cgi?id=37726
2021
2022         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2023           - use the newly exposed TestResult class and implement
2024             --log trace
2025         * Scripts/webkitpy/layout_tests/layout_package/dump_render_thread.py:
2026           - rename TestStats to TestResult and make it more public, resulting
2027             in cleaner code
2028         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2029           - add expectation_to_string() as a separate callable function
2030
2031 2010-04-20  Eric Seidel  <eric@webkit.org>
2032
2033         Unreviewed, rolling out r57907.
2034         http://trac.webkit.org/changeset/57907
2035         https://bugs.webkit.org/show_bug.cgi?id=37765
2036
2037         Appears to have broken MacEWS and possibly webkit-patch upload
2038         for svn users.  Needs further investigation.
2039
2040         * Scripts/webkitpy/common/checkout/api.py:
2041         * Scripts/webkitpy/common/checkout/api_unittest.py:
2042         * Scripts/webkitpy/common/checkout/changelog.py:
2043         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2044         * Scripts/webkitpy/common/checkout/commitinfo.py:
2045         * Scripts/webkitpy/common/checkout/scm.py:
2046         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2047         * Scripts/webkitpy/common/config/committers.py:
2048         * Scripts/webkitpy/common/net/bugzilla.py:
2049         * Scripts/webkitpy/common/net/buildbot.py:
2050         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2051         * Scripts/webkitpy/common/net/statusserver.py:
2052         * Scripts/webkitpy/common/prettypatch.py:
2053         * Scripts/webkitpy/common/system/autoinstall.py:
2054         * Scripts/webkitpy/common/system/deprecated_logging.py:
2055         * Scripts/webkitpy/common/system/executive.py:
2056         * Scripts/webkitpy/common/system/executive_unittest.py:
2057         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2058         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2059         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
2060         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2061         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2062         * Scripts/webkitpy/tool/commands/queues.py:
2063         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2064         * Scripts/webkitpy/tool/commands/upload.py:
2065         * Scripts/webkitpy/tool/mocktool.py:
2066         * Scripts/webkitpy/tool/steps/abstractstep.py:
2067         * Scripts/webkitpy/tool/steps/postdiff.py:
2068         * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
2069         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
2070         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2071
2072 2010-04-20  Nate Chapin  <japhet@chromium.org>
2073
2074         Unreviewed.
2075
2076         Update my irc handle in committers.py (natechapin -> japhet).
2077
2078         * Scripts/webkitpy/common/config/committers.py:
2079
2080 2010-04-20  Eric Seidel  <eric@webkit.org>
2081
2082         Reviewed by Adam Barth.
2083
2084         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
2085         https://bugs.webkit.org/show_bug.cgi?id=37765
2086
2087         I fixed the queue to not ignore Tor as a reviwer in r57531,
2088         but instead it throws an exception every time his name is in a patch.
2089
2090         This fixes our Executive.run_command code to work around a Popen
2091         bug http://bugs.python.org/issue5290 whereby python versions before 2.6
2092         do not correctly handle unicode objects as input or output to
2093         Popen.communicate.
2094
2095         Following the advice of:
2096         http://farmdev.com/talks/unicode/
2097         I'm attempting to take the python unicode plunge and use unicode()
2098         objects as strings instead of str() objects everywhere in webkitpy.
2099
2100         We do not have to use u"" instead of "" because u"a" == "a" as expected
2101         in Python.  Python will generate a warning to the console in cases where
2102         a unicode() == str() operation cannot be performed.
2103
2104         I also cleaned up the input handling in run_command a little by adding
2105         a new _compute_input() method which can return early instead of having
2106         such a long/cluttered if-block.
2107
2108         Executive.run* now correctly accept and return unicode() objects.
2109         I attempted to fix all the places that we call .write() to make sure we
2110         encode any unicode() objects into utf-8.
2111
2112         All places which use StringIO need to be sure to pass StringIO a
2113         pre-encoded byte-array (str object) instead of unicode so that
2114         clients which read from the StringIO don't have encoding exceptions.
2115         To make this easier, I removed the patch_file_object support from
2116         add_patch_to_bug, and changed the 4 places which previously used
2117         StringIO to create a fake patch file.
2118
2119         I attempted to document any places where we are not correctly converting
2120         to/from bytes (str() objects) to strings (unicode() objects).
2121
2122         * Scripts/webkitpy/common/checkout/api_unittest.py:
2123          - Read/write utf-8 files instead of ascii.
2124          - Update the tests to use test for proper unicode() handling.
2125         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2126          - Use unicode() strings instead of str() byte arrays.
2127         * Scripts/webkitpy/common/checkout/scm.py:
2128          - Remove use of str().
2129         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2130          - Read/write utf-8 files and use unicode() strings in testing.
2131         * Scripts/webkitpy/common/config/committers.py:
2132          - Use \u instead of \x to make slightly clearer what we're doing.
2133         * Scripts/webkitpy/common/net/bugzilla.py:
2134          - Add a new _string_contents() method and explain why
2135            we have to call unicode() on the result of soup.string
2136            and why it's safe to do so w/o needing to pass a codec name.
2137          - Remove the (unused) support for passing a file object to add_patch_to_bug().
2138         * Scripts/webkitpy/common/net/buildbot.py:
2139          - Use unicode() instead of str() when needing to coax a
2140            NavigableString object into a unicode() object.
2141         * Scripts/webkitpy/common/net/statusserver.py:
2142          - Remove use of str()
2143         * Scripts/webkitpy/common/prettypatch.py:
2144          - Write out the patch file as utf-8.
2145         * Scripts/webkitpy/common/system/autoinstall.py:
2146          - Add a FIXME about encoding.
2147         * Scripts/webkitpy/common/system/deprecated_logging.py:
2148          - Document that tee() works on bytes, not strings.
2149         * Scripts/webkitpy/common/system/executive.py:
2150          - Make run* properly take and return unicode() objects.
2151         * Scripts/webkitpy/common/system/executive_unittest.py:
2152          - Added a unit test to make sure we don't break Tor again!
2153         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2154          - Write out the test list as utf-8.
2155         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2156          - Write out json files as utf-8.
2157         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
2158          - Add FIXME about encoding handling.
2159         * Scripts/webkitpy/tool/commands/upload.py:
2160          - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
2161         * Scripts/webkitpy/tool/mocktool.py:
2162          - Rename add_patch_to_bug argument to match bugzilla.py
2163         * Scripts/webkitpy/tool/steps/postdiff.py:
2164          - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
2165         * Scripts/webkitpy/tool/steps/postdiffforcommit.py: ditto.
2166         * Scripts/webkitpy/tool/steps/postdiffforrevert.py: ditto.
2167         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2168          - Fixed spurious logging seen when running test-webkitpy
2169
2170 2010-04-20  Chris Jerdonek  <cjerdonek@webkit.org>
2171
2172         Reviewed by Shinichiro Hamaji.
2173
2174         For check-webkit-style, implemented __eq__() and __ne__() (the
2175         built-in equality and inequality methods) for the
2176         DefaultStyleErrorHandler class.
2177
2178         https://bugs.webkit.org/show_bug.cgi?id=37850
2179
2180         This will facilitate unit-testing for a subsequent patch,
2181         namely for https://bugs.webkit.org/show_bug.cgi?id=37850
2182
2183         * Scripts/webkitpy/style/error_handlers.py:
2184           - Added __eq__() and __ne__() to the DefaultStyleErrorHandler
2185             class.
2186
2187         * Scripts/webkitpy/style/error_handlers_unittest.py:
2188           - Added unit tests for __eq__() and __ne__().
2189           - Also included a minor clean-up refactoring of combining the
2190             StyleErrorHandlerTestBase class (which has not needed to
2191             be separate due to previous changes) into the
2192             DefaultStyleErrorHandlerTest class.
2193
2194 2010-04-20  Jakub Wieczorek  <jwieczorek@webkit.org>
2195
2196         Unreviewed.
2197
2198         Add my IRC nick to the committers.py list.
2199
2200         * Scripts/webkitpy/common/config/committers.py:
2201
2202 2010-04-20  Kim Grönholm  <kim.gronholm@nomovok.com>
2203
2204         Reviewed by Simon Hausmann.
2205
2206         [Qt] Multitouch mocking in QtLauncher doesn't work with QGraphicsView
2207         https://bugs.webkit.org/show_bug.cgi?id=37816
2208         
2209         Fix multi-touch mocking in QtLauncher when using QGraphicsView.
2210         Test: https://bug-32434-attachments.webkit.org/attachment.cgi?id=44955
2211
2212         * QtLauncher/main.cpp:
2213         (LauncherWindow::eventFilter):
2214         (LauncherWindow::initializeView):
2215
2216 2010-04-20  MORITA Hajime <morrita@google.com>
2217
2218         Unreviewed, add myself to the committers list.
2219
2220         * Scripts/webkitpy/common/config/committers.py:
2221
2222 2010-04-20  Kent Tamura  <tkent@chromium.org>
2223
2224         Reviewed by Shinichiro Hamaji.
2225
2226         [DRT/Chromium] Fix some unexpected results of editing
2227         https://bugs.webkit.org/show_bug.cgi?id=37843
2228
2229         This change fixes about 70 unexpected results.
2230         The original test_webview_delegate.cc doesn't have this bug.
2231         The bug was introduced when I ported it to WebKit tree.
2232
2233         * DumpRenderTree/chromium/WebViewHost.cpp:
2234         (printRangeDescription): Replace the latter startContainer() with endContainer().
2235
2236 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2237
2238         Unreviewed, build fix.
2239
2240         Turn off some unit tests for now - the new-run-webkit-tests dryrun
2241         tests for chromium won't work if you don't have a chromium checkout.
2242
2243         https://bugs.webkit.org/show_bug.cgi?id=37841
2244
2245         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2246
2247 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2248
2249         Unreviewed, build fix.
2250
2251         (Re-)add dryrun.py; this was renamed from passing.py in the previous
2252         CL but apparently somehow didn't get checked in.
2253
2254         https://bugs.webkit.org/show_bug.cgi?id=37841
2255
2256         * Scripts/webkitpy/layout_tests/port/dryrun.py: Added.
2257
2258 2010-04-19  Shinichiro Hamaji  <hamaji@chromium.org>
2259
2260         Reviewed by David Levin.
2261
2262         check-webkit-style: exits when encountering a deleted file
2263         https://bugs.webkit.org/show_bug.cgi?id=37122
2264
2265         This reverts the quick fix done by r57119 and makes check_patch
2266         not call check_file for deleted files.
2267
2268         Also this change fixes the behavior for "-", which should mean
2269         stdin.  Before this change, the style checker just ignored "-"
2270         with a warning message.
2271
2272         * Scripts/webkitpy/style/checker.py:
2273         * Scripts/webkitpy/style/checker_unittest.py:
2274
2275 2010-04-19  Daniel Bates  <dbates@rim.com>
2276
2277         No review, rolling out 57868.
2278         http://trac.webkit.org/changeset/57868
2279         https://bugs.webkit.org/show_bug.cgi?id=37748
2280
2281         Sheriffbot wasn't very inspirational after this patch.
2282         Instead, he was silent when you said hi :-(. Rolling
2283         out this patch so that I can debug/test this some more.
2284
2285         * Scripts/webkitpy/common/net/bugzilla.py:
2286         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
2287         * Scripts/webkitpy/tool/bot/irc_command.py:
2288         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2289         * Scripts/webkitpy/tool/mocktool.py:
2290
2291 2010-04-19  Daniel Bates  <dbates@rim.com>
2292
2293         Reviewed by Adam Barth.
2294
2295         https://bugs.webkit.org/show_bug.cgi?id=37748
2296
2297         Make Sheriffbot more inspirational.
2298
2299         * Scripts/webkitpy/common/net/bugzilla.py:
2300         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
2301         * Scripts/webkitpy/tool/bot/irc_command.py:
2302         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2303         * Scripts/webkitpy/tool/mocktool.py:
2304
2305 2010-04-19  Kevin Ollivier  <kevino@theolliviers.com>
2306
2307         [wx] Build fix, add missing header.
2308
2309         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2310
2311 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2312  
2313          Reviewed by Adam Barth.
2314  
2315          new-run-webkit-tests - repurpose the "Passing" port as "Dryrun" port
2316          that can be used to test platforms other than the one you are running
2317          on. This can be useful for checking baselines and testing code
2318          coverage.
2319  
2320          Note that running the code on the "wrong" port requires each
2321          port-specific implementation to actually not require any
2322          platform-specific python code (e.g., the chromium-win port must
2323          test for the existence of windows functions before calling them).
2324  
2325          https://bugs.webkit.org/show_bug.cgi?id=37782
2326  
2327          * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2328          * Scripts/webkitpy/layout_tests/port/dryrun.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/port/passing.py.
2329          * Scripts/webkitpy/layout_tests/port/factory.py:
2330          * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2331
2332 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2333
2334         Reviewed by Eric Seidel.
2335
2336         new-run-webkit-tests: add --build (default) and --no-build
2337         options to make that step optional. This flag modifies what happens
2338         in port.check_build().
2339
2340         https://bugs.webkit.org/show_bug.cgi?id=37786
2341
2342         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2343         * Scripts/webkitpy/layout_tests/port/chromium.py:
2344         * Scripts/webkitpy/layout_tests/port/webkit.py:
2345
2346 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2347
2348         Unreviewed, build fix.
2349
2350         new-run-webkit-tests - fix a typo in r57480 that caused us to stop
2351         logging the actual list of unexpected results.
2352
2353         https://bugs.webkit.org/show_bug.cgi?id=37831
2354
2355         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2356
2357 2010-04-19  Dirk Pranke <dpranke@chromium.org>
2358
2359         Reviewed by Adam Barth.
2360
2361         From a patch by Tor Arne Vestbo  <tor.arne.vestbo@nokia.com>
2362
2363         new-run-webkit-tests: make the retry step more explicit
2364         https://bugs.webkit.org/show_bug.cgi?id=37606
2365
2366         It might be confusing to see the test and percent counters
2367         reset without any notice of what's going on, so we make the
2368         message that a retry-run is started explicit.
2369
2370         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2371
2372 2010-04-19  Sam Weinig  <weinig@apple.com>
2373
2374         Reviewed by Anders Carlsson.
2375
2376         Add support for opening a new window (File->New Window) to
2377         Windows MiniBrowser. Accelerator doesn't work.
2378
2379         * MiniBrowser/win/BrowserView.cpp:
2380         (createNewPage): Use BrowserView::create.
2381         * MiniBrowser/win/BrowserWindow.cpp:
2382         (BrowserWindow::onCommand): Respond to ID_FILE_NEW_WINDOW
2383         by creating a new window.
2384         * MiniBrowser/win/BrowserWindow.h:
2385         (BrowserWindow::create): Added. Don't allow creating
2386         BrowserWindows on the stack by making constructor
2387         private and exposing the create function.
2388         * MiniBrowser/win/MiniBrowser.cpp:
2389         (MiniBrowser::createNewWindow): Move new window creation
2390         logic here.
2391         * MiniBrowser/win/MiniBrowser.h:
2392         * MiniBrowser/win/MiniBrowser.rc: 
2393         * MiniBrowser/win/main.cpp:
2394         (_tWinMain): Use the new MiniBrowser::createNewWindow().
2395
2396 2010-04-19  Chris Fleizach  <cfleizach@apple.com>
2397
2398         Reviewed by Beth Dakin.
2399
2400         AX: aria-haspopup needs to be exposed
2401         https://bugs.webkit.org/show_bug.cgi?id=37808
2402
2403         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2404         (AccessibilityUIElement::hasPopup):
2405
2406 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2407
2408         Reviewed by Eric Seidel.
2409
2410         Submit a better workaround for r57806 than the one in r57831 - log
2411         an error and exit if you try to run new-run-webkit-tests with --use-drt
2412         on Windows.
2413
2414         https://bugs.webkit.org/show_bug.cgi?id=37822
2415
2416         * Scripts/webkitpy/layout_tests/port/chromium.py:
2417
2418 2010-04-19  Jesus Sanchez-Palencia  <jesus@webkit.org>
2419
2420         Unreviewed.
2421
2422         Just adding myself as a committer.
2423
2424         * Scripts/webkitpy/common/config/committers.py:
2425
2426 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2427
2428         Reviewed by Eric Seidel.
2429
2430         Add slightly better logging to the websocket python wrapper script,
2431         including a --verbose flag for debug output.
2432
2433         https://bugs.webkit.org/show_bug.cgi?id=37233
2434
2435         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2436         * Scripts/new-run-webkit-websocketserver:
2437
2438 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2439
2440         Reviewed by Eric Seidel.
2441
2442         new-run-webkit-tests: add a way (--print-unexpected-results) to
2443         (re-)print out the tests that produced unexpected results in the
2444         last run. Also add a way (--retry-unexpected-results) to
2445         automatically re-test them.
2446
2447         https://bugs.webkit.org/show_bug.cgi?id=37783
2448
2449         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2450
2451 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2452
2453         Reviewed by Eric Seidel.
2454
2455         Restructure the logging in new-run-webkit-tests so that many of log
2456         messages that were logged to the MeteredStream also get logged in
2457         --verbose mode.
2458
2459         https://bugs.webkit.org/show_bug.cgi?id=37780
2460
2461         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
2462         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2463
2464 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2465
2466         Reviewed by Eric Seidel.
2467
2468         new-run-webkit-tests: add 'summary' and 'unexpected-results' options
2469         to the --log flag. Also add a 'progress' flag to enable the regular
2470         progress bar (as opposed to 'detailed-progress', which enables the
2471         dots). Also add a 'nothing' flag to allow you to be explicit that
2472         you don't want any logging on the command line.
2473
2474         The default is
2475         '--log detailed-progress,summary,unexpected,unexpected-results'
2476
2477         (The default logging is unchanged by this patch, this just makes things
2478         properly configurable).
2479
2480         Note that 'nothing' doesn't work properly yet; I need a couple other
2481         patches to land to avoid rewriting things several different ways.
2482
2483         https://bugs.webkit.org/show_bug.cgi?id=37785
2484
2485         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2486
2487 2010-04-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2488
2489         Reviewed by Simon Hausmann.
2490
2491         Make the URL change on committed load.
2492
2493         * QtLauncher/mainwindow.cpp:
2494         (MainWindow::buildUI):
2495         (MainWindow::setAddressUrl):
2496         * QtLauncher/mainwindow.h:
2497
2498 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2499
2500         Reviewed by Eric Seidel.
2501
2502         Fix a typo in the rebaselining tool that causes us to use "debug"
2503         instead of "Debug" in a directory path, which fails on platforms with
2504         case-sensitive filesystems.
2505
2506         https://bugs.webkit.org/show_bug.cgi?id=37819
2507
2508         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2509
2510 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2511
2512         Unreviewed, build fix.
2513
2514         Fix breakage of chromium-win canary bots caused by r57806. That patch
2515         introduced the option of using Chrome's new port of DumpRenderTree,
2516         but unfortunately that port relies on the webkit.py class
2517         implementation which uses non-blocking I/O that isn't available on
2518         Windows. This patch turns off that option and doesn't import the
2519         class if we're running on Windows.
2520
2521         https://bugs.webkit.org/show_bug.cgi?id=37817
2522
2523         * Scripts/webkitpy/layout_tests/port/chromium.py:
2524
2525 2010-04-19  James Robinson  <jamesr@chromium.org>
2526
2527         Reviewed by abarth.
2528
2529         Fix a typo
2530
2531         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2532
2533 2010-04-19  Adam Roben  <aroben@apple.com>
2534
2535         Fix run-webkit-tests when there are spaces in the path
2536
2537         Fixes <http://webkit.org/b/37809>
2538
2539         Reviewed by Adam Barth.
2540
2541         * Scripts/run-webkit-tests: Use an "indirect object" to specify the
2542         path to the harness to exec(). According to perldoc, this usage will
2543         prohibit perl from parsing the arguments to exec() via the shell,
2544         which would incorrectly split paths with spaces in them, etc.
2545
2546 2010-04-19  Dimitri Glazkov  <dglazkov@chromium.org>
2547
2548         Reviewed by Adam Roben.
2549
2550         WinLauncher.h should use LF line-endings and use native line-endings style.
2551         https://bugs.webkit.org/show_bug.cgi?id=37807
2552
2553         * WinLauncher/WinLauncher.h: Added property svn:eol-style, converted to LF line-endings.
2554
2555 2010-04-19  Kent Tamura  <tkent@chromium.org>
2556
2557         Reviewed by Shinichiro Hamaji.
2558
2559         [DRT/Chromium] Fix a test initialization problem
2560         https://bugs.webkit.org/show_bug.cgi?id=37791
2561
2562         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2563         (runTest): Call resetTestController() before runFileTest(). Some
2564           controllers initialize their fields in reset() and not in their
2565           constructors.
2566
2567 2010-04-19  Kent Tamura  <tkent@chromium.org>
2568
2569         Reviewed by Eric Seidel.
2570
2571         [Chromium] new-run-webkit-tests should use WebKitDriver for --use-drt
2572         https://bugs.webkit.org/show_bug.cgi?id=37793
2573
2574         We need to use WebKitDriver instead of ChromiumDriver for Chromium
2575         DRT because its interface is different from test_shell.
2576
2577         Chromium DRT has no UI.  So we can't use it to show test results.
2578
2579         * Scripts/webkitpy/layout_tests/port/chromium.py:
2580
2581 2010-04-18  Eric Seidel  <eric@webkit.org>
2582
2583         Reviewed by Adam Roben.
2584
2585         Make failure-reason more forgiving
2586         https://bugs.webkit.org/show_bug.cgi?id=37525
2587
2588         Removed search_limit, which wasn't very useful anyway.
2589         Added a log about the long load time loading from the builders.
2590         Prompt the user for what revision to start walking from (makes it easy to restart upon failure).
2591
2592         * Scripts/webkitpy/common/net/buildbot.py:
2593         * Scripts/webkitpy/tool/commands/queries.py:
2594
2595 2010-04-18  Chris Jerdonek  <cjerdonek@webkit.org>
2596
2597         Reviewed by Shinichiro Hamaji.
2598
2599         Created a class for check-webkit-style that encapsulates iterating
2600         over text files and reading them.
2601
2602         https://bugs.webkit.org/show_bug.cgi?id=37754
2603
2604         This revision is an intermediate step towards separating our
2605         style-checking code from the logic of iterating over files and
2606         reading them.
2607
2608         * Scripts/webkitpy/common/system/logtesting.py:
2609           - Added a logMessages() method to the LoggingTestCase class.
2610             This method provides unit tests with access to the raw list
2611             of log messages in case the tester needs to do something more
2612             than simply assert the list of existing messages.
2613
2614         * Scripts/webkitpy/style/checker.py:
2615           - Added a ProcessorBase class that processors of lists of lines
2616             should eventually inherit from.
2617           - Also added a FIXME to use the ProcessorBase class and the
2618             TextFileReader class added below.
2619
2620         * Scripts/webkitpy/style/filereader.py: Added.
2621           - Created a TextFileReader class that encapsulates reading
2622             and iterating over text files.
2623
2624         * Scripts/webkitpy/style/filereader_unittest.py: Added.
2625           - Added a TextFileReaderTest class to unit-test the
2626             new TextFileReader class.
2627
2628 2010-04-15  Tony Chang  <tony@chromium.org>
2629
2630         Reviewed by Adam Barth.
2631
2632         [chromium] new-run-webkit-tests should be able to use chromium DRT
2633         https://bugs.webkit.org/show_bug.cgi?id=37645
2634
2635         Make sure that the lack of a chromium checkout doesn't cause the script to
2636         fail.
2637
2638         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2639         * Scripts/webkitpy/layout_tests/port/chromium.py:
2640         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Fix up a few paths
2641             to be relative to an upstream output dir.
2642         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --use-drt flag.
2643
2644 2010-04-18  Eric Seidel  <eric@webkit.org>
2645
2646         Unreviewed, fixing the Qt bot.
2647
2648         Add a layer of indirection when calling run-webkit-tests to allow testing new-run-webkit-tests on various platforms
2649         https://bugs.webkit.org/show_bug.cgi?id=37632
2650
2651         * Scripts/run-webkit-tests:
2652          - Exit non-zero of launching the harness fails.
2653
2654 2010-04-18  Eric Seidel  <eric@webkit.org>
2655
2656         Unreviewed, fixing the Qt bot.
2657
2658         Add a layer of indirection when calling run-webkit-tests to allow testing new-run-webkit-tests on various platforms
2659         https://bugs.webkit.org/show_bug.cgi?id=37632
2660
2661         * Scripts/run-webkit-tests:
2662          - Fix the wrapper to work for users who do not
2663            have WebKitTools/Scripts in their path.
2664
2665 2010-04-14  Eric Seidel  <eric@webkit.org>
2666
2667         Reviewed by Adam Barth.
2668
2669         Add a layer of indirection when calling run-webkit-tests to
2670         allow testing new-run-webkit-tests on various platforms.
2671         https://bugs.webkit.org/show_bug.cgi?id=37632
2672
2673         This will let us test and fix bugs in new-run-webkit-tests
2674         without needing to restart the buildbot master between tests.
2675
2676         Currently this change leaves run-webkit-tests as-is, but once
2677         its landed we will easily be able to turn on/off
2678         new-run-webkit-tests for various ports/configurations.
2679
2680         I will send a note out to webkit-dev about how we will
2681         be using this launcher script to test on the bots.
2682
2683         * Scripts/old-run-webkit-tests: Copied from WebKitTools/Scripts/run-webkit-tests.
2684         * Scripts/run-webkit-tests:
2685          - A new script which decides whether to run new- or old-
2686            run-webkit-tests based on the platform.
2687         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2688          - Add some dummy argument handling for arguments which
2689            old-run-webkit-tests supports but new-run-webkit-tests
2690            does not yet.
2691
2692 2010-04-18  Eric Seidel  <eric@webkit.org>
2693
2694         Reviewed by Adam Barth.
2695
2696         Add Gtk bots to the list of "core builders" (builders which stop the commit-queue when they turn red)
2697         https://bugs.webkit.org/show_bug.cgi?id=33295
2698
2699         The Gtk builders have been green every time I've looked
2700         at them in the last 5 days or so.  It would appear webkit
2701         is now keeping them green and we should update the core
2702         builder list to match reality.
2703
2704         * Scripts/webkitpy/common/net/buildbot.py:
2705         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2706
2707 2010-04-18  Robert Hogan  <robert@webkit.org>
2708
2709         Reviewed by Simon Hausmann.
2710
2711         [Qt] Add support for LayoutTestController commands:
2712                    setSmartInsertDeleteEnabled
2713                    setSelectTrailingWhitespaceEnabled
2714                    execCommand
2715                    isCommandEnabled
2716
2717         https://bugs.webkit.org/show_bug.cgi?id=35844
2718
2719         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2720         (WebCore::WebPage::resetSettings):
2721         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2722         (LayoutTestController::setSmartInsertDeleteEnabled):
2723         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
2724         (LayoutTestController::execCommand):
2725         (LayoutTestController::isCommandEnabled):
2726         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2727
2728 2010-04-17  Adam Barth  <abarth@webkit.org>
2729
2730         Reviewed by Eric Seidel.
2731
2732         Remove steps_references and commands_references
2733         https://bugs.webkit.org/show_bug.cgi?id=37758
2734
2735         We tried using the mumble_references convention to manage our
2736         dependencies, but it doesn't seem to be providing much value for the
2737         steps and commands module because these modules are small pieces of the
2738         larger tool module.  In this patch, I've removed the references file
2739         for these modules.
2740  
2741         I've left the style_references file for the style module because that
2742         module seems better isolated from the rest of webkitpy and the
2743         style_references file appears to be providing some value.
2744
2745         * Scripts/webkitpy/tool/commands/commandtest.py:
2746         * Scripts/webkitpy/tool/commands/download_unittest.py:
2747         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2748         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2749         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2750         * Scripts/webkitpy/tool/commands/queuestest.py:
2751         * Scripts/webkitpy/tool/commands/upload.py:
2752         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2753         * Scripts/webkitpy/tool/commands_references.py: Removed.
2754         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
2755         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2756         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
2757         * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py:
2758         * Scripts/webkitpy/tool/steps_references.py: Removed.
2759
2760 2010-04-17  Eric Seidel  <eric@webkit.org>
2761
2762         Reviewed by Adam Barth.
2763
2764         WebKit needs a Chromium Mac EWS Builder
2765         https://bugs.webkit.org/show_bug.cgi?id=37742
2766
2767         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2768
2769 2010-04-17  Adam Barth  <abarth@webkit.org>
2770
2771         Fix expected results for unit test broken by
2772         http://trac.webkit.org/changeset/57772
2773
2774         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2775
2776 2010-04-17  Sam Weinig  <weinig@apple.com>
2777
2778         Reviewed by Adam Roben.
2779
2780         Teach windows MiniBrowser how to work with window.open()
2781         and targeted links.
2782
2783         * MiniBrowser/win/BrowserView.cpp:
2784         (createNewPage): Create a new BrowserWindow and return its page.
2785         (showPage): Show the page.
2786         (closePage): Empty implementation.
2787         (runJavaScriptAlert): Empty implementation.
2788         (BrowserView::create): Register a UIClient.
2789         * MiniBrowser/win/BrowserView.h:
2790         (BrowserView::webView): Added.
2791         Change create to take a BrowserWindow instead of an HWND.
2792
2793         * MiniBrowser/win/BrowserWindow.cpp:
2794         (BrowserWindow::wndProc): Respond to WM_NCDESTROY.
2795         (BrowserWindow::goToURL): Added. Forwards to BrowserView.
2796         (BrowserWindow::onCreate): Don't always go to the default
2797         url. Let the caller do this.
2798         (BrowserWindow::onNCDestroy): Delete the window.
2799         * MiniBrowser/win/BrowserWindow.h:
2800         (BrowserWindow::view): Added.
2801         (BrowserWindow::window): Added.
2802
2803         * MiniBrowser/win/main.cpp:
2804         (_tWinMain):
2805         Go to the default URL for the initial page. Allocate the initial
2806         window on the heap for correctness.
2807
2808 2010-04-16  Adam Roben  <aroben@apple.com>
2809
2810         Add the Windows Debug (Test) builder to the list of core builders
2811
2812         It's been green for a few days now, and all the known Windows
2813         flakiness is Release-only.
2814
2815         Rubber-stamped by Mark Rowe.
2816
2817         * Scripts/webkitpy/common/net/buildbot.py:
2818         (BuildBot.core_builder_name_regexps): Added a regular expression to
2819         match the "Windows Debug (Test)" builder.
2820
2821 2010-04-16  Sam Weinig  <sam@webkit.org>
2822
2823         Reviewed by Anders Carlsson.
2824
2825         Fix window.open() and targeted links.
2826
2827         * MiniBrowser/mac/BrowserWindowController.m:
2828         (_createNewPage): Use the correct initializer to and load the window.
2829
2830 2010-04-16  Adam Roben  <aroben@apple.com>
2831
2832         Fix links to layout test results from build status pages
2833
2834         Reviewed by Mark Rowe.
2835
2836         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2837         (ExtractTestResults.finished): Prepend "/" on the URL of the test
2838         results page so that it is treated as an absolute URL.
2839
2840 2010-04-16  Tony Chang  <tony@chromium.org>
2841
2842         Reviewed by Dimitri Glazkov.
2843
2844         [chromium] build DRT on Linux
2845         https://bugs.webkit.org/show_bug.cgi?id=37690
2846
2847         * Scripts/build-dumprendertree: Add support for win and linux
2848
2849 2010-04-16  Sam Weinig  <weinig@apple.com>
2850
2851         Reviewed by Adam Roben.
2852
2853         Use the threaded process model for MiniBrowser if holding down
2854         the shift key on startup.
2855
2856         * MiniBrowser/win/BrowserView.cpp:
2857         (BrowserView::create): 
2858
2859 2010-04-15  Tony Chang  <tony@chromium.org>
2860
2861         Reviewed by Dimitri Glazkov.
2862
2863         [chromium] Add TestShellGtk.cpp so we can link on Linux
2864         https://bugs.webkit.org/show_bug.cgi?id=37561
2865
2866         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Add new file and
2867             add platform file exceptions.
2868         * DumpRenderTree/chromium/TestShellGtk.cpp: Added.
2869         (AlarmHandler):
2870         (TestShell::waitTestFinished):
2871
2872 2010-04-15  Tony Chang  <tony@chromium.org>
2873
2874         Reviewed by Dimitri Glazkov.
2875
2876         build DRT on chromium mac
2877         https://bugs.webkit.org/show_bug.cgi?id=37639
2878
2879         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2880         * Scripts/build-dumprendertree: enable build-dumprendertree --chromium
2881
2882 2010-04-15  Kent Tamura  <tkent@chromium.org>
2883
2884         Reviewed by Dimitri Glazkov.
2885
2886         [DRT/Chromium] Add LayoutTestHelper for Mac
2887         https://bugs.webkit.org/show_bug.cgi?id=37668
2888
2889         LayouTestHelper.mm is based on webkit/tools/test_shell/mac/layout_test_helper.mm
2890         of Chromium.
2891
2892         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2893         * DumpRenderTree/chromium/LayoutTestHelper.mm: Added.
2894
2895 2010-04-15  Alexey Proskuryakov  <ap@apple.com>
2896
2897         Reviewed by Geoff Garen.
2898
2899         https://bugs.webkit.org/show_bug.cgi?id=37494
2900         <rdar://problem/7857060> REGRESSION (r57340): fast/events/mouse-drag-from-frame-to-other-frame.html
2901         fails on Windows
2902
2903         * DumpRenderTree/win/EventSender.cpp: (makeEventSender):
2904         * DumpRenderTree/win/EventSender.h:
2905         Tell EventSender if it's being created for a top frame.
2906         
2907         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2908         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld): We only want to reset
2909         EventSender machinery when a new test is loaded, not when an iframe (or just its global
2910         object) is created.
2911
2912 2010-04-15  Adam Roben  <aroben@apple.com>
2913
2914         Fix Windows WebKit2 build.
2915
2916         * MiniBrowser/win/MiniBrowser.cpp:
2917
2918 2010-04-15  Ojan Vafai  <ojan@chromium.org>
2919
2920         Reviewed by Adam Barth.
2921
2922         Include codereview issue number in patch description
2923         https://bugs.webkit.org/show_bug.cgi?id=37677
2924
2925         This lets us know which rietveld issue this patch is tied to.
2926
2927         Also, make it so that --fancy-review overrides --no-review.
2928
2929         * Scripts/webkitpy/tool/steps/postcodereview.py:
2930         * Scripts/webkitpy/tool/steps/postdiff.py:
2931
2932 2010-04-15  Adam Roben  <aroben@apple.com>
2933
2934         Make --exit-after-n-failures work when all tests are timing out or crashing
2935
2936         Fixes <http://webkit.org/b/37679>.
2937
2938         Reviewed by Jon Honeycutt.
2939
2940         * Scripts/run-webkit-tests:
2941         (top level): When a test crashes or times out, break out of the main loop if
2942         stopRunningTestsEarlyIfNeeded returns true. Moved some code from the bottom of the main loop
2943         from here...
2944         (stopRunningTestsEarlyIfNeeded): ...to here.
2945
2946 2010-04-15  Sam Weinig  <sam@webkit.org>
2947
2948         Reviewed by Anders Carlsson.
2949
2950         Add WebHistoryClient support.
2951         https://bugs.webkit.org/show_bug.cgi?id=37671
2952
2953         Add HistoryClient logging.
2954
2955         * MiniBrowser/mac/BrowserWindowController.m:
2956         (_didNavigateWithNavigationData):
2957         (_didPerformClientRedirect):
2958         (_didPerformServerRedirect):
2959         (_didUpdateHistoryTitle):
2960         (-[BrowserWindowController awakeFromNib]):
2961
2962 2010-04-15  Anders Carlsson  <andersca@apple.com>
2963
2964         Reviewed by Sam Weinig.
2965
2966         Start the mini browser in threaded mode if shift is pressed during startup.
2967         https://bugs.webkit.org/show_bug.cgi?id=37670
2968
2969         * MiniBrowser/mac/AppDelegate.m:
2970         (-[BrowserAppDelegate init]):
2971
2972 2010-04-15  Chris Fleizach  <cfleizach@apple.com>
2973
2974         Reviewed by Beth Dakin.
2975
2976         AXHelp is being appended from ancestors incorrectly
2977         https://bugs.webkit.org/show_bug.cgi?id=37659
2978
2979         * DumpRenderTree/AccessibilityUIElement.cpp:
2980         (getHelpTextCallback):
2981         (AccessibilityUIElement::getJSClass):
2982         * DumpRenderTree/AccessibilityUIElement.h:
2983         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2984         (AccessibilityUIElement::helpText):
2985         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2986         (AccessibilityUIElement::helpText):
2987         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2988         (AccessibilityUIElement::helpText):
2989
2990 2010-04-15  Dirk Pranke  <dpranke@chromium.org>
2991
2992         Reviewed by Adam Barth.
2993
2994         Re-format run-webkit-tests to fit in 80-columns for PEP-8 compliance.
2995         (broken by r57463 and r57381, at least). I've also filed bug 37477
2996         to fix check-webkit-style to catch these things.
2997
2998         https://bugs.webkit.org/show_bug.cgi?id=38586
2999
3000         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3001
3002 2010-04-15  Dirk Pranke  <dpranke@chromium.org>
3003
3004         Reviewed by Dimitri Glazkov.
3005
3006         Add a way to override the user-visible name for the test binary since
3007         some ports don't call it DumpRenderTree (e.g., Chromium Win uses
3008         test_shell, Chromium Mac uses TestShell) by adding a driver_name()
3009         method to the Port interface.
3010
3011         https://bugs.webkit.org/show_bug.cgi?id=37631
3012
3013         * Scripts/webkitpy/layout_tests/port/base.py:
3014         * Scripts/webkitpy/layout_tests/port/chromium.py:
3015         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3016         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3017
3018 2010-04-14  Anders Carlsson  <andersca@apple.com>
3019
3020         Reviewed by Adam Roben.
3021
3022         Add "Force Repaint" to debug menu.
3023         https://bugs.webkit.org/show_bug.cgi?id=37627
3024
3025         * MiniBrowser/mac/BrowserWindowController.h:
3026         * MiniBrowser/mac/BrowserWindowController.m:
3027         (-[BrowserWindowController forceRepaint:]):
3028         * MiniBrowser/mac/English.lproj/MainMenu.xib:
3029
3030 2010-04-15  Sam Weinig  <sam@webkit.org>
3031
3032         Reviewed by Adam Roben.
3033
3034         Add debug-minibrowser script.
3035
3036         * Scripts/debug-minibrowser: Copied from Scripts/run-minibrowser.
3037         * Scripts/webkitdirs.pm:
3038
3039 2010-04-15  Roland Steiner  <rolandsteiner@chromium.org>
3040  
3041         Reviewed by Dimitri Glazkov.
3042
3043         Bug 37636 - [DRT/Chromium] Implement DRT/Chromium for Windows
3044         https://bugs.webkit.org/show_bug.cgi?id=37636
3045  
3046         Second patch: add Windows-specific implementation parts
3047         of TestShell.
3048
3049         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3050         * DumpRenderTree/chromium/TestShell.h:
3051         (TestShell::finishedEvent):
3052         * DumpRenderTree/chromium/TestShellWin.cpp:
3053         (watchDogThread):
3054         (TestShell::waitTestFinished):
3055
3056 2010-04-15  Roland Steiner  <rolandsteiner@chromium.org>
3057
3058         Reviewed by Dimitri Glazkov.
3059
3060         Bug 37636 - [DRT/Chromium] Implement DRT/Chromium for Windows
3061         https://bugs.webkit.org/show_bug.cgi?id=37636
3062
3063         First patch: fix compiler errors.
3064
3065         * DumpRenderTree/chromium/EventSender.cpp:
3066         (EventSender::reset):
3067         (EventSender::dispatchMessage):
3068         * DumpRenderTree/chromium/LayoutTestController.cpp:
3069         (LayoutTestController::pathToLocalResource):
3070         * DumpRenderTree/chromium/TestWebWorker.h:
3071         * DumpRenderTree/chromium/TextInputController.cpp:
3072         * DumpRenderTree/chromium/WebViewHost.h:
3073         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3074
3075 2010-04-14  Luiz Agostini  <luiz.agostini@openbossa.org>
3076
3077         Reviewed by Simon Hausmann.
3078
3079         [Qt] Moving setViewMode from DumpRenderTreeSupportQt to qwebpage.cpp
3080         https://bugs.webkit.org/show_bug.cgi?id=37622
3081
3082         Method qt_wrt_setViewMode was removed from qwebpage.cpp by mistake in r57433
3083         (bug 35844). Moving it back.
3084
3085         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3086         (LayoutTestController::setViewModeMediaFeature):
3087
3088 2010-04-15  Dirk Pranke  <dpranke@chromium.org>
3089
3090         Reviewed by Adam Barth.
3091
3092         Add some very minimal unit tests for new-run-webkit-tests. This should
3093         be enough to catch egregious brokenness like syntax errors and import
3094         declaration issues.
3095
3096         https://bugs.webkit.org/show_bug.cgi?id=37432
3097
3098         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3099         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: Added.
3100
3101 2010-04-14  Brian Weinstein  <bweinstein@apple.com>
3102
3103         Reviewed by Adam Roben.
3104
3105         Add a way for the buildbot to kill any old processes that are running. This
3106         is useful because the Windows bots can get in states where a process remains
3107         running (httpd.exe, DumpRenderTree.exe), which causes the bots to get in a red
3108         state, and the processes must be killed manually.
3109
3110         * BuildSlaveSupport/build.webkit.org-config/master.cfg: If we are on Windows, kill
3111             the old processes that might be running.
3112         * BuildSlaveSupport/win/kill-old-processes: Added.
3113
3114 2010-04-14  Sam Weinig  <sam@webkit.org>
3115
3116         Reviewed by Anders Carlsson.
3117
3118         Tear down WebKit more completely on window closing and application
3119         termination. We still don't block application termination for pending
3120         close, but this is a step in the right direction.
3121
3122         * MiniBrowser/mac/AppDelegate.m:
3123         (-[BrowserAppDelegate applicationWillTerminate:]):
3124         * MiniBrowser/mac/BrowserWindowController.h:
3125         * MiniBrowser/mac/BrowserWindowController.m:
3126         (-[BrowserWindowController dealloc]):
3127         (-[BrowserWindowController windowWillClose:]):
3128         (-[BrowserWindowController applicationTerminating]):
3129
3130 2010-04-14  Adam Barth  <abarth@webkit.org>
3131
3132         Reviewed by Eric Seidel.
3133
3134         Use pretty patch for confirming webkit-patch diffs
3135         https://bugs.webkit.org/show_bug.cgi?id=37489
3136
3137         * Scripts/webkitpy/common/prettypatch.py: Added.
3138         * Scripts/webkitpy/tool/commands/download_unittest.py:
3139         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3140         * Scripts/webkitpy/tool/mocktool.py:
3141         * Scripts/webkitpy/tool/steps/confirmdiff.py:
3142
3143 2010-04-14  Eric Seidel  <eric@webkit.org>
3144
3145         Reviewed by Adam Barth.
3146
3147         Teach webkit-patch how to handle revisions missing ChangeLogs
3148         https://bugs.webkit.org/show_bug.cgi?id=37519
3149
3150         Make commit_info_for_revision return None when revision
3151         is missing a ChangeLog.  Previously we would throw an array index
3152         exception.
3153         Teach callers how to handle None.
3154
3155         * Scripts/webkitpy/common/checkout/api.py:
3156         * Scripts/webkitpy/common/checkout/api_unittest.py:
3157         * Scripts/webkitpy/tool/commands/download.py:
3158         * Scripts/webkitpy/tool/commands/queries.py:
3159         * Scripts/webkitpy/tool/commands/sheriffbot.py:
3160
3161 2010-04-13  Eric Seidel  <eric@webkit.org>
3162
3163         Reviewed by Adam Roben.
3164
3165         Add Qt Bot to the list of "core builders" (builders which block the commit-queue when red)
3166         https://bugs.webkit.org/show_bug.cgi?id=33297
3167
3168         This is an experiment.  The bots have been green for
3169         a while.  We'll see if adding them under sheriff-bot protection
3170         will keep them green.
3171
3172         * Scripts/webkitpy/common/net/buildbot.py:
3173         * Scripts/webkitpy/common/net/buildbot_unittest.py:
3174
3175 2010-04-13  Eric Seidel  <eric@webkit.org>
3176
3177         Unreviewed, just fixing a constant in the Rietveld unit test.
3178
3179         * Scripts/webkitpy/common/net/rietveld_unittest.py
3180
3181 2010-04-13  Eric Seidel  <eric@webkit.org>
3182
3183         Unreviewed, just adding missing Mock to fix python tests.
3184
3185         * Scripts/webkitpy/tool/mocktool.py:
3186
3187 2010-04-13  Ojan Vafai  <ojan@chromium.org>
3188
3189         Reviewed by David Levin.
3190
3191         Add experimental prototype Rietveld integration to webkit-patch upload
3192         https://bugs.webkit.org/show_bug.cgi?id=37418
3193
3194         This patch adds bare-bones integration with Rietveld for code reviews.
3195         The behavior is hidden behind the --fancy-review command line flag.
3196         Currently, there's no support for uploading more than one patch per
3197         issue (which is a nice feature of Rietveld).  The plan is to play with
3198         this for a bit and see if it's useful.
3199
3200         Modified from Adam's original patch to autoinstall the rietveld upload script.
3201
3202         * Scripts/webkitpy/common/config/__init__.py:
3203         * Scripts/webkitpy/common/net/rietveld.py: Added.
3204         * Scripts/webkitpy/common/net/rietveld_unitttest.py: Added.
3205         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3206         * Scripts/webkitpy/tool/commands/upload.py:
3207         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3208         * Scripts/webkitpy/tool/main.py:
3209         * Scripts/webkitpy/tool/mocktool.py:
3210         * Scripts/webkitpy/tool/steps/__init__.py:
3211         * Scripts/webkitpy/tool/steps/options.py:
3212         * Scripts/webkitpy/tool/steps/postcodereview.py: Added.
3213         * Scripts/webkitpy/tool/steps/postdiff.py:
3214
3215 2010-04-13  Sam Weinig  <sam@webkit.org>
3216
3217         Rubber-stamped by Mark Rowe.
3218
3219         Add Makefile to MiniBrowser.
3220
3221         * MiniBrowser/Makefile: Added.
3222
3223 2010-04-13  Eric Seidel  <eric@webkit.org>
3224
3225         Unreviewed, just adding a sanity check.
3226
3227         Add check to make sure commit-queue can never commit too short a message
3228         https://bugs.webkit.org/show_bug.cgi?id=37528
3229
3230         The commit-queue made bogus messages here:
3231         http://trac.webkit.org/changeset/57532
3232         http://trac.webkit.org/changeset/57534
3233
3234         This was a regression caused by adding unicode parsing for
3235         our ChangeLog files.  Popen does not seem to play nice with
3236         unicode strings.
3237
3238         I'm also adding an "assert" to make sure short ChangeLogs never happen again.
3239
3240         * Scripts/webkitpy/common/system/executive.py:
3241          - Cast input to strings before passing to POpen
3242         * Scripts/webkitpy/tool/steps/commit.py:
3243          - Validate that commit messages are not to short.
3244
3245 2010-04-13  Adam Roben  <aroben@apple.com>
3246
3247         Robustify new-run-webkit-tests against paths with spaces in them
3248
3249         Reviewed by Eric Seidel.
3250
3251         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
3252         (LayoutTestApacheHttpd.__init__): Quote all paths that we pass to
3253         Apache to ensure that paths with spaces in them are interpreted
3254         correctly.
3255
3256 2010-04-13  Csaba Osztrogonác  <ossy@webkit.org>
3257
3258         Unreviewed buildfix after r57537.
3259
3260         * DumpRenderTree/qt/LayoutTestControllerQt.h: Declaration of removeOriginAccessWhitelistEntry() added.
3261
3262 2010-04-13  Sam Weinig  <sam@webkit.org>
3263
3264         Reviewed by Maciej Stachowiak.
3265
3266         Make building new webkit API and MiniBrowser a little easier.
3267
3268         * Scripts/build-webkit: Make building with --webkit2 build the 
3269         MiniBrowser as well and tell you how to use it.
3270         * Scripts/run-minibrowser: Copied from Scripts/run-safari.
3271         * Scripts/webkitdirs.pm: Add runMiniBrowser function.
3272
3273 2010-04-12  Timothy Hatcher  <timothy@apple.com>
3274
3275         SecurityOrigin needs a way to remove individual OriginAccessEntries
3276         https://bugs.webkit.org/show_bug.cgi?id=37449
3277
3278         Reviewed by Dave Hyatt.
3279
3280         * DumpRenderTree/LayoutTestController.cpp:
3281         (removeOriginAccessWhitelistEntryCallback): Added. Call LayoutTestController::removeOriginAccessWhitelistEntry.
3282         (LayoutTestController::staticFunctions): Added removeOriginAccessWhitelistEntry.
3283         * DumpRenderTree/LayoutTestController.h:
3284         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3285         (LayoutTestController::removeOriginAccessWhitelistEntry): Added. FIXME to implement.
3286         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3287         (LayoutTestController::removeOriginAccessWhitelistEntry): Added.
3288         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3289         (LayoutTestController::removeOriginAccessWhitelistEntry): Added. FIXME to implement.
3290         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3291         (LayoutTestController::removeOriginAccessWhitelistEntry): Added.
3292         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3293         (LayoutTestController::whiteListAccessFromOrigin): FIXME to implement.
3294         (LayoutTestController::removeOriginAccessWhitelistEntry): Added. FIXME to implement.
3295
3296 2010-04-13  Timothy Hatcher  <timothy@apple.com>
3297
3298         Rename SecurityOrigin::whiteListAccessFromOrigin to addOriginAccessWhitelistEntry.
3299         And LayoutTestController.whiteListAccessFromOrigin to addOriginAccessWhitelistEntry.
3300         And SecurityOrigin::resetOriginAccessWhiteLists to resetOriginAccessWhitelists.
3301
3302         SecurityOrigin needs a way to remove individual OriginAccessEntries
3303         https://bugs.webkit.org/show_bug.cgi?id=37449
3304
3305         Reviewed by Dave Hyatt.
3306
3307         * DumpRenderTree/LayoutTestController.cpp:
3308         (addOriginAccessWhitelistEntryCallback):
3309         (LayoutTestController::staticFunctions):
3310         * DumpRenderTree/LayoutTestController.h:
3311         * DumpRenderTree/chromium/LayoutTestController.cpp:
3312         (LayoutTestController::LayoutTestController):
3313         (LayoutTestController::addOriginAccessWhitelistEntry):
3314         * DumpRenderTree/chromium/LayoutTestController.h:
3315         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3316         (LayoutTestController::addOriginAccessWhitelistEntry):
3317         * DumpRenderTree/mac/DumpRenderTree.mm:
3318         (resetWebViewToConsistentStateBeforeTesting):
3319         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3320         (LayoutTestController::addOriginAccessWhitelistEntry):
3321         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3322         (LayoutTestController::addOriginAccessWhitelistEntry):
3323         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3324         * DumpRenderTree/win/DumpRenderTree.cpp:
3325         (resetWebViewToConsistentStateBeforeTesting):
3326         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3327         (LayoutTestController::addOriginAccessWhitelistEntry):
3328         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3329         (LayoutTestController::addOriginAccessWhitelistEntry):
3330
3331 2010-04-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3332
3333         Reviewed by Eric Seidel.
3334
3335         Remove duplicate function for new-run-webkit-tests
3336         https://bugs.webkit.org/show_bug.cgi?id=37517
3337
3338         The version() function was already implemented.
3339
3340         * Scripts/webkitpy/layout_tests/port/webkit.py:
3341
3342 2010-04-13  Eric Seidel  <eric@webkit.org>
3343
3344         Reviewed by David Levin.
3345
3346         the commit-queue hates Tor Arne Vestbø
3347         https://bugs.webkit.org/show_bug.cgi?id=37511
3348
3349         We were failing to read reviewers out of ChangeLogs
3350         when the reviewer has unicode characters in his/her name.
3351         I fixed this by explicitly decoding from utf8 every time we
3352         read in a ChangeLog file (they are always UTF8).
3353
3354         * Scripts/webkitpy/common/checkout/changelog.py:
3355         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3356
3357 2010-04-13  Adam Roben  <aroben@apple.com>
3358
3359         Fix run-webkit-tests on Windows with spaces in the path
3360
3361         Fixes <http://webkit.org/b/37509>.
3362
3363         Reviewed by Steve Falkenburg.
3364
3365         * Scripts/run-webkit-tests:
3366         (convertPathUsingCygpath): Remove spaces from the path before passing
3367         them to cygpath, then add them back in after conversion, as some
3368         versions of cygpath seem to convert spaces into newlines.
3369
3370 2010-04-13  Adam Barth  <abarth@webkit.org>
3371
3372         Unreviewed, but approved by Dumitru Daniliuc.  (This patch is intended
3373         to fix the downstream Chromium build bots.  Hopefully it will work!)
3374
3375         Add a driver script for the new websocket server
3376         https://bugs.webkit.org/show_bug.cgi?id=37495
3377
3378         websocket_server.py can't be run directly because its a module and not
3379         a standalone script.  This used to work by accident because it didn't
3380         depend on any other modules.
3381
3382         * Scripts/new-run-webkit-websocketserver: Added.
3383         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
3384
3385 2010-04-12  Eric Seidel  <eric@webkit.org>
3386
3387         Reviewed by Adam Barth.
3388
3389         Make new-run-webkit-test PrettyPatch failure reporting more awesome
3390         https://bugs.webkit.org/show_bug.cgi?id=37487
3391
3392         I also fixed an Executive/executive typo.
3393
3394         * Scripts/webkitpy/layout_tests/port/base.py:
3395
3396 2010-04-12  Eric Seidel  <eric@webkit.org>
3397
3398         Reviewed by Adam Barth.
3399
3400         new-run-webkit-tests should only build java support files on Mac
3401         https://bugs.webkit.org/show_bug.cgi?id=37482
3402
3403         Only the mac needs java support files, so I pushed _build_java
3404         down into the Mac port using a new hook "_check_port_build".
3405         In the process I noticed a bunch of code which could be shared
3406         between all ports and thus got rid of _tests_for_disabled_features
3407         and version() copy/paste between all webkit ports.
3408         I also made check_build only bother to check for ImageDiff if we're
3409         using pixel tests.
3410
3411         * Scripts/webkitpy/layout_tests/port/gtk.py:
3412         * Scripts/webkitpy/layout_tests/port/mac.py:
3413         * Scripts/webkitpy/layout_tests/port/qt.py:
3414         * Scripts/webkitpy/layout_tests/port/webkit.py:
3415         * Scripts/webkitpy/layout_tests/port/win.py:
3416
3417 2010-04-12  Dumitru Daniliuc  <dumi@chromium.org>
3418
3419         Unreviewed, trying to make scripts work on machines without
3420         Ruby...
3421
3422         * Scripts/webkitpy/layout_tests/port/base.py:
3423
3424 2010-04-12  Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
3425
3426         Reviewed by Eric Seidel.
3427
3428         Add stub files for running new-run-webkit-tests for the Qt port
3429
3430         * Scripts/webkitpy/layout_tests/port/factory.py:
3431         * Scripts/webkitpy/layout_tests/port/qt.py: Added.
3432
3433 2010-04-12  Dirk Pranke  <dpranke@chromium.org>
3434
3435         Reviewed by Eric Seidel.
3436
3437         Modify run_webkit_tests.py to not call sys.exit() at the end of test
3438         run; doing so makes it more difficult to embed the routine for,
3439         among other things, unit tests. We push the exit calling up into
3440         new-run-webkit-tests.
3441
3442         https://bugs.webkit.org/show_bug.cgi?id=37464
3443
3444         * Scripts/new-run-webkit-tests:
3445         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3446
3447 2010-04-12  Eric Seidel  <eric@webkit.org>
3448
3449         Unreviewed.
3450
3451         Add stub Gtk implementation for new-run-webkit-tests.
3452
3453         * Scripts/webkitpy/layout_tests/port/factory.py:
3454         * Scripts/webkitpy/layout_tests/port/gtk.py: Added.
3455
3456 2010-04-12  Eric Seidel  <eric@webkit.org>
3457
3458         Reviewed by Adam Barth.
3459
3460         new-run-webkit-tests fails with exception on systems missing ruby
3461         https://bugs.webkit.org/show_bug.cgi?id=37441
3462
3463         * Scripts/webkitpy/layout_tests/port/base.py:
3464          - Catch failures similar to how wdiff code path does.
3465          - After one failure, stop trying.
3466
3467 2010-04-12  Tony Chang  <tony@chromium.org>
3468
3469         Reviewed by Eric Seidel.
3470
3471         Fix how we import simplejson based on how it's used in this file.
3472         This fixes exceptions raised when trying to write the simplejson output.
3473
3474         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3475
3476 2010-04-11  Chris Jerdonek  <cjerdonek@webkit.org>
3477
3478         Reviewed by Shinichiro Hamaji.
3479
3480         Refactored check-webkit-style so that the StyleChecker class
3481         has no dependencies on patch-related concepts.
3482
3483         https://bugs.webkit.org/show_bug.cgi?id=37065
3484
3485         This patch is an intermediate step towards making the StyleChecker
3486         class a generalized file processor that can do arbitary operations
3487         on the files corresponding to a list of paths.  This patch
3488         also simplifies the unit-testing of patch-checking code.
3489
3490         * Scripts/check-webkit-style:
3491           - Updated to use the new PatchChecker class.
3492
3493         * Scripts/webkitpy/style/checker.py:
3494           - Refactored the StyleChecker.check_patch() method into the
3495             check() method of a new PatchChecker class.
3496
3497         * Scripts/webkitpy/style/checker_unittest.py:
3498           - Refactored the unit tests as necessary, changing the
3499             StyleCheckerCheckPatchTest class to a PatchCheckerTest class.
3500
3501 2010-04-11  Adam Barth  <abarth@webkit.org>
3502
3503         Unreviewed.
3504
3505         Fix new-run-webkit-tests regressions cased by Eric's option parsing patch
3506         https://bugs.webkit.org/show_bug.cgi?id=37430
3507
3508         We need some basic unit testing of this script, or we're going to keep
3509         breaking it like this.  Added missing namespace qualifiers and
3510         propagated renaming of an option.
3511
3512         * Scripts/webkitpy/common/config/ports.py:
3513         * Scripts/webkitpy/layout_tests/driver_test.py:
3514         * Scripts/webkitpy/layout_tests/port/base.py:
3515         * Scripts/webkitpy/layout_tests/port/mac.py:
3516         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3517
3518 2010-04-11  Eric Seidel  <eric@webkit.org>
3519
3520         Reviewed by Adam Barth.
3521
3522         Break new-run-webkit-tests options into groups for easier re-use and possible relocation
3523         https://bugs.webkit.org/show_bug.cgi?id=37408
3524
3525         new-run-webkit-tests currently has one huge function for
3526         dealing with all options-parsing. 
3527         This patch is a first attempt at trying to split that large
3528         function down into smaller (hopefully more readable?) chunks
3529         dealing with the different areas of options.
3530         For example, it would make sense to move configuration
3531         options off into some module which deals with the vagries of
3532         WebKit's configuration system.  It would also make sense to move
3533         Chromium options off onto the Chromium port object (where they are used).
3534         It may make sense to move results.json options over to the results.json code.
3535         This change is a first iteration, and we will certainly need more
3536         refinement to this code over time.  Hopefully I didn't make things
3537         harder to read here.
3538
3539         * Scripts/webkitpy/layout_tests/driver_test.py:
3540