a3aa4c9cf00d97b8739a995aeeedbdc0e02769a5
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-12-09  Koan-Sin Tan  <koansin.tan@gmail.com>
2
3         Reviewed by Tor Arne Vestbø
4
5         [Qt] run-launcher doesn't start the browser on Mac OS X 10.6
6         https://bugs.webkit.org/show_bug.cgi?id=50742
7
8         check not only QtWebKit.framework/QtWebKit but also libQtWebKit.dylib
9
10         * Scripts/webkitdirs.pm:
11
12 2010-12-09  Joone Hur  <joone@kldp.org>
13
14          Reviewed by Martin Robinson.
15
16          [GTK] Support for viewport meta tag
17          https://bugs.webkit.org/show_bug.cgi?id=45443
18
19          Add support for testing the viewport properties for WebKitGtk.
20
21          * DumpRenderTree/LayoutTestController.cpp:
22          (dumpConfigurationForViewportCallback): Added this JS callback to set the size of the visible viewport.
23          (LayoutTestController::staticFunctions):
24          * DumpRenderTree/LayoutTestController.h:
25          * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
26          (LayoutTestController::dumpConfigurationForViewport): Added this function to test the viewport properties.
27          * DumpRenderTree/mac/LayoutTestControllerMac.mm:
28          (LayoutTestController::dumpConfigurationForViewport): Ditto.
29          * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
30          (LayoutTestController::dumpConfigurationForViewport): Ditto.
31          * DumpRenderTree/win/LayoutTestControllerWin.cpp:
32          (LayoutTestController::dumpConfigurationForViewport): Ditto.
33          * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
34          (LayoutTestController::dumpConfigurationForViewport): Ditto.
35
36 2010-12-08  William Siegrist <wsiegrist@apple.com>
37
38         Reviewed by Eric Seidel.
39
40         Migrate buildbot.py from xmlrpc to json.
41         https://bugs.webkit.org/show_bug.cgi?id=50647
42
43         * Scripts/webkitpy/common/net/buildbot.py:
44
45 2010-12-08  Tony Chang  <tony@chromium.org>
46
47         Reviewed by Eric Seidel.
48
49         make starting the websocket server more reliable on windows
50         https://bugs.webkit.org/show_bug.cgi?id=50712
51
52         * Scripts/webkitpy/common/system/filesystem.py:
53         (remove): Substitute method for os.remove to retry on error on Windows
54         * Scripts/webkitpy/common/system/filesystem_unittest.py:
55         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Use FileSystem.remove
56
57 2010-12-08  Jessie Berlin  <jberlin@apple.com>
58
59         Reviewed by Adam Roben.
60
61         WebKit2: Implement WebChromeClient::exceededDatabaseQuota
62         https://bugs.webkit.org/show_bug.cgi?id=50656
63
64         * MiniBrowser/mac/BrowserWindowController.m:
65         (-[BrowserWindowController awakeFromNib]):
66         Indicate that exceededDatabaseQuota is not implemented.
67         * MiniBrowser/win/BrowserView.cpp:
68         (BrowserView::create):
69         Ditto.
70         * WebKitTestRunner/TestController.cpp:
71         (WTR::createOtherPage):
72         Ditto.
73         (WTR::TestController::initialize):
74         Ditto.
75
76 2010-12-08  Antonio Gomes  <agomes@rim.com>
77
78         Reviewed by Martin Robinson.
79
80         [Gtk] Populate DumpRenderTreeSupportGtk (part III)
81         https://bugs.webkit.org/show_bug.cgi?id=48429
82
83         Moved the following methods from webkitprivate.h to DumpRenderTreeSupportGtk.cpp|h:
84         * webkit_gc_collect_javascript_objects;
85         * webkit_gc_collect_javascript_objects_on_alternate_thread;
86         * webkit_gc_count_javascript_objects;
87         * webkit_web_frame_layout.
88
89         These were all only used by GTK+ DRT.
90
91         * DumpRenderTree/gtk/EventSender.cpp:
92         (dispatchEvent):
93         * DumpRenderTree/gtk/GCControllerGtk.cpp:
94         (GCController::collect):
95         (GCController::collectOnAlternateThread):
96         (GCController::getJSObjectCount):
97
98 2010-12-07  Tony Chang  <tony@chromium.org>
99
100         Reviewed by Ojan Vafai.
101
102         [chromium] force NRWT to use DRT
103         https://bugs.webkit.org/show_bug.cgi?id=50359
104
105         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
106
107 2010-12-06  Sam Weinig  <sam@webkit.org>
108
109         Reviewed by Anders Carlsson.
110
111         Generalize didChangeLocationWithinPageForFrame for all same document navigations
112         https://bugs.webkit.org/show_bug.cgi?id=50584
113
114         * MiniBrowser/mac/BrowserWindowController.m:
115         (didSameDocumentNavigationForFrame):
116         (-[BrowserWindowController awakeFromNib]):
117         (-[BrowserWindowController didSameDocumentNavigationForFrame:]):
118         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
119         (TestWebKitAPI::didSameDocumentNavigationForFrame):
120         (TestWebKitAPI::TEST):
121         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
122         (WTR::InjectedBundlePage::InjectedBundlePage):
123         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame):
124         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
125         * WebKitTestRunner/TestController.cpp:
126         (WTR::TestController::initialize):
127
128 2010-12-06  Kinuko Yasuda  <kinuko@chromium.org>
129
130         Reviewed by Ojan Vafai.
131
132         Make TestResultsServer return 404 for non-existing results files.
133         https://bugs.webkit.org/show_bug.cgi?id=50581
134
135         * TestResultServer/handlers/testfilehandler.py:
136
137 2010-12-06  Tony Chang  <tony@chromium.org>
138
139         Reviewed by Ojan Vafai.
140
141         [chromium] fix an assert hit in DRT
142         https://bugs.webkit.org/show_bug.cgi?id=50575
143
144         This class uses WTF's RefPtr, but expects chrome's base::RefPtr
145         semantics.
146
147         Otherwise, we hit ASSERTION FAILED: !m_adoptionIsRequired
148         (third_party/WebKit/JavaScriptCore/wtf/RefCounted.h:37 void
149         WTF::RefCountedBase::ref()).
150
151         * DumpRenderTree/chromium/TestWebWorker.h:
152         (TestWebWorker::TestWebWorker):
153
154 2010-12-02  Ojan Vafai  <ojan@chromium.org>
155
156         Reviewed by Eric Seidel.
157
158         make webkit-patch command work when the git branch is not synced to the remote svn branch
159         https://bugs.webkit.org/show_bug.cgi?id=50424
160
161         * Scripts/webkitpy/common/checkout/scm.py:
162         * Scripts/webkitpy/common/checkout/scm_unittest.py:
163
164 2010-12-06  Patrick Gansterer  <paroga@webkit.org>
165
166         Reviewed by Andreas Kling.
167
168         [WINCE] Add build system
169         https://bugs.webkit.org/show_bug.cgi?id=50522
170
171         * CMakeListsWinCE.txt: Added.
172
173 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
174
175         Reviewed by Tony Chang.
176
177         Allow the Chromium port to have Leopard-specific baselines
178         https://bugs.webkit.org/show_bug.cgi?id=50506
179
180         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
181
182 2010-12-03  Tony Chang  <tony@chromium.org>
183
184         Reviewed by Kent Tamura.
185
186         [chromium] fix 2 bugs with inspector tests in DRT
187         https://bugs.webkit.org/show_bug.cgi?id=50492
188
189         Tasks can outlive the tasklist (even when canceled) so this was
190         causing a crash when ~WebTask() ran.  Avoid this by unregistering
191         when a task is canceled.
192
193         Also fix an assert when closing devtool windows by copying some
194         logic from test_shell.
195
196         * DumpRenderTree/chromium/Task.cpp:
197         (WebTask::~WebTask):
198         (TaskList::revokeAll):
199         * DumpRenderTree/chromium/Task.h: Canceling a task now removes it from
200             the tasklist (since the task can outlive the tasklist).
201         * DumpRenderTree/chromium/TestShell.h:
202         (TestShell::devToolsWebView):
203         * DumpRenderTree/chromium/WebViewHost.cpp:
204         (WebViewHost::~WebViewHost): Don't load about:blank when closing
205             a window if the window has devtools loaded.  This avoids an
206             ASSERT and matches test_shell.
207
208 2010-12-06  Alejandro G. Castro  <alex@igalia.com>
209
210         Reviewed by Martin Robinson.
211
212         [GTK] Fix GtkLauncher.c style, use webkit style
213         https://bugs.webkit.org/show_bug.cgi?id=50542
214
215         * GtkLauncher/main.c:
216         (activateUriEntryCb):
217         (updateTitle):
218         (linkHoverCb):
219         (notifyTitleCb):
220         (notifyLoadStatusCb):
221         (notifyProgressCb):
222         (destroyCb):
223         (goBackCb):
224         (goForwardCb):
225         (create_webViewCb):
226         (webViewReadyCb):
227         (closeWebViewCb):
228         (createBrowser):
229         (createStatusbar):
230         (createToolbar):
231         (createWindow):
232         (main):
233
234 2010-12-04  Antonio Gomes  <agomes@rim.com>
235
236         Reviewed by Martin Robinson.
237
238         [Gtk] Populate DumpRenderTreeSupportGtk (Part II)
239         https://bugs.webkit.org/show_bug.cgi?id=48429
240
241         Moved more private method declared with WEBKIT_API to
242         DumpRenderTreeSupportGtk, since they were only being used by DRT.
243
244         * DumpRenderTree/gtk/DumpRenderTree.cpp:
245         (resetDefaultsToConsistentValues):
246         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
247         (LayoutTestController::addOriginAccessWhitelistEntry):
248         (LayoutTestController::execCommand):
249         (LayoutTestController::isCommandEnabled):
250
251 2010-12-04  Antonio Gomes  <agomes@rim.com>
252
253         Reviewed by Andreas Kling.
254
255         Removed extern webkit_web_view_set_group_name from gtk/DumpRenderTree.cpp
256
257         Method was removed by http://trac.webkit.org/changeset/71604
258
259         * DumpRenderTree/gtk/DumpRenderTree.cpp:
260
261 2010-12-05  Alejandro G. Castro  <alex@igalia.com>
262
263         Reviewed by Xan Lopez.
264
265         [GTK] Fix compilation warnings reported by clang
266         https://bugs.webkit.org/show_bug.cgi?id=50252
267
268         * GtkLauncher/main.c:
269         (create_window): The create_statusbar function does not have
270         parameters.
271
272 2010-12-05  Robert Hogan  <robert@webkit.org>
273
274         Reviewed by Andreas Kling.
275
276         [Qt] Zero-sized font does not yet work
277
278         Fix fast/text/font-size-zero.html
279
280         Copy other ports by setting minimumFontSize to 0 for DRT runs.
281
282         https://bugs.webkit.org/show_bug.cgi?id=49759
283
284         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
285         (WebCore::WebPage::WebPage):
286
287 2010-12-04  Sam Weinig  <sam@webkit.org>
288
289         Reviewed by Jon Honeycutt.
290
291         WebKit2: Need client functions to notify app when the url changes due to a fragment navigation
292         https://bugs.webkit.org/show_bug.cgi?id=50511
293
294         Update tools for new didChangeLocationWithinPageForFrame client function (and changed bundle
295         signature) and added a test for the functionality (PageLoadDidChangeLocationWithinPageForFrame.cpp)
296
297         * MiniBrowser/mac/BrowserWindowController.m:
298         (didChangeLocationWithinPageForFrame):
299         (-[BrowserWindowController awakeFromNib]):
300         (-[BrowserWindowController didChangeLocationWithinPageForFrame:]):
301         * TestWebKitAPI/PlatformUtilities.cpp:
302         (TestWebKitAPI::Util::toWK):
303         * TestWebKitAPI/PlatformUtilities.h:
304         (TestWebKitAPI::Util::adoptWK):
305         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
306         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp: Added.
307         (TestWebKitAPI::nullJavaScriptCallback):
308         (TestWebKitAPI::didFinishLoadForFrame):
309         (TestWebKitAPI::didChangeLocationWithinPageForFrame):
310         (TestWebKitAPI::TEST):
311         * TestWebKitAPI/Tests/WebKit2/file-with-anchor.html: Added.
312         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
313         * TestWebKitAPI/win/copy-resources.cmd:
314         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
315         (WTR::InjectedBundlePage::InjectedBundlePage):
316         (WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
317         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
318         * WebKitTestRunner/TestController.cpp:
319         (WTR::TestController::initialize):
320
321 2010-11-08  Antonio Gomes  <agomes@rim.com>
322
323         Reviewed by Martin Robinson.
324
325         [Gtk] Populate DumpRenderTreeSupportGtk
326         https://bugs.webkit.org/show_bug.cgi?id=48429
327
328         Made the previous calls to webkit_web_frame* functions defined as private
329         APIs in webkitprivate.h go through DRTSupportGtk.
330
331         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
332         (AccessibilityController::focusedElement):
333         * DumpRenderTree/gtk/DumpRenderTree.cpp:
334         (dumpFramesAsText):
335         (resetDefaultsToConsistentValues):
336         (dump):
337         (webViewDocumentLoadFinished):
338         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
339         (LayoutTestController::counterValueForElementById):
340         (LayoutTestController::pageNumberForElementById):
341         (LayoutTestController::numberOfPages):
342         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
343         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
344         (LayoutTestController::sampleSVGAnimationForElementAtTime):
345         (LayoutTestController::numberOfActiveAnimations):
346         (LayoutTestController::suspendAnimations):
347         (LayoutTestController::resumeAnimations):
348         (LayoutTestController::markerTextForListItem):
349
350 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
351
352         Reviewed by Tony Chang.
353
354         Rebaseline server: use pretty text diff output
355         https://bugs.webkit.org/show_bug.cgi?id=50484
356         
357         Serve *-pretty-diff.html for text diff output.
358
359         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
360         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
361         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
362         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
363
364 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
365
366         Unreviewed, rolling out r73302.
367         http://trac.webkit.org/changeset/73302
368         https://bugs.webkit.org/show_bug.cgi?id=50499
369
370         Causes crashes in debug LayoutTests (Requested by xan_ on
371         #webkit).
372
373         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
374         (AccessibilityUIElement::AccessibilityUIElement):
375         (AccessibilityUIElement::parentElementCallback):
376         * DumpRenderTree/chromium/AccessibilityUIElement.h:
377         * DumpRenderTree/chromium/CppBoundClass.cpp:
378         * DumpRenderTree/chromium/CppBoundClass.h:
379
380 2010-12-03  Sam Weinig  <sam@webkit.org>
381
382         Reviewed by Maciej Stachowiak.
383
384         Enable <a ping> for Mac/Windows/WebKit2 builds
385         <rdar://problem/8504473>
386         https://bugs.webkit.org/show_bug.cgi?id=50488
387
388         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
389         (TestWebKitAPI::TEST): Test that the default value of
390         WKPreferencesGetHyperlinkAuditingEnabled is true.
391
392 2010-12-03  Chris Guillory  <chris.guillory@google.com>
393
394         Reviewed by Chris Fleizach.
395
396         Include the FrameView widget of a RenderWidget in the accessibility tree.
397         https://bugs.webkit.org/show_bug.cgi?id=49106
398
399         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
400         (AccessibilityUIElement::AccessibilityUIElement):
401         (AccessibilityUIElement::parentElementCallback):
402         (AccessibilityUIElement::isEqualCallback):
403         * DumpRenderTree/chromium/AccessibilityUIElement.h:
404         * DumpRenderTree/chromium/CppBoundClass.cpp:
405         (CppBoundClass::getFromCppVariant):
406         * DumpRenderTree/chromium/CppBoundClass.h:
407
408 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
409
410         Reviewed by Tony Chang.
411
412         Rebaseline server: organize tests by state, add dry run mode
413         https://bugs.webkit.org/show_bug.cgi?id=50473
414         
415         Group tests in the menu by state, so that it's easier to see after
416         processing the queue which failed.
417         
418         Add support for the --dry-run flag so that it's easier to test changes
419         such as this (stubs out filesystem and SCM operations).
420
421         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
422         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
423         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
424
425 2010-12-03  Brady Eidson  <beidson@apple.com>
426
427         Reviewed by Anders Carlsson.
428
429         Groundwork for <rdar://problem/7660733> and https://bugs.webkit.org/show_bug.cgi?id=50191
430         WebKit2 Authentication Support
431
432         Keep these builds working:
433         * MiniBrowser/mac/BrowserWindowController.m:
434         (-[BrowserWindowController awakeFromNib]):
435
436         * WebKitTestRunner/TestController.cpp:
437         (WTR::TestController::initialize):
438
439 2010-12-02  Mihai Parparita  <mihaip@chromium.org>
440
441         Reviewed by Tony Chang.
442
443         Rebaseline server: move existing baselines
444         https://bugs.webkit.org/show_bug.cgi?id=50421
445         
446         Implement moving of existing baselines: move all files that are about
447         to be overwriten by update baselines.
448         
449         Also fix a typo in the UI JS.
450
451         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
452         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
453         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
454
455 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
456
457         Unreviewed, rolling out r73211.
458         http://trac.webkit.org/changeset/73211
459         https://bugs.webkit.org/show_bug.cgi?id=50450
460
461         Broke Chromium's "Webkit Win (dbg)(2)" bot. (Requested by
462         yutak on #webkit).
463
464         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
465
466 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
467
468         Unreviewed, rolling out r73222.
469         http://trac.webkit.org/changeset/73222
470         https://bugs.webkit.org/show_bug.cgi?id=50449
471
472         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
473         (Requested by yutak on #webkit).
474
475         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
476         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
477         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
478         * Scripts/webkitpy/layout_tests/port/base.py:
479         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
480         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
481
482 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
483
484         Unreviewed, rolling out r73228.
485         http://trac.webkit.org/changeset/73228
486         https://bugs.webkit.org/show_bug.cgi?id=50448
487
488         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
489         (Requested by yutak on #webkit).
490
491         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
492         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
493         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
494         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
495         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
496
497 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
498
499         Unreviewed, rolling out r73231.
500         http://trac.webkit.org/changeset/73231
501         https://bugs.webkit.org/show_bug.cgi?id=50443
502
503         r73211 seemed to broke Chromium's "Webkit Win (dbg)(2)" bot.
504         (Requested by yutak on #webkit).
505
506         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
507         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
508         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
509         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
510
511 2010-12-03  David Levin  <levin@chromium.org>
512
513         Reviewed by Shinichiro Hamaji.
514
515         check-webkit-style: false positive reported for #if macro
516         https://bugs.webkit.org/show_bug.cgi?id=48242
517
518         * Scripts/webkitpy/style/checkers/cpp.py: Adjusted check to avoid
519           all preprocessor commands.
520         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test.
521
522 2010-12-02  Eric Seidel  <eric@webkit.org>
523
524         Reviewed by Adam Barth.
525
526         Update the EWSTools scripts to use modern-style git repos
527         https://bugs.webkit.org/show_bug.cgi?id=50402
528
529         * EWSTools/create-webkit-git:
530         * EWSTools/start-commit-queue.sh:
531         * EWSTools/start-queue.sh:
532
533 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
534
535         Fix Chromium Linux plugin tests by not logging
536         unconditionally from the event handling code.
537
538         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
539         (handleEventX11):
540
541 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
542
543         Reviewed by Tony Chang.
544
545         nrwt multiprocessing - move logic back into run_webkit_tests
546
547         This change moves a bunch of logic that I had put into
548         message_broker back into run_webkit_tests, in a slightly
549         different format. WorkerMessageBroker needed to become less aware of
550         the logic the TestRunner class uses, and more generic.
551         Eventually the MessageBroker will only do generic messaging and
552         thread/process-pooling, and (almost) all of the
553         run-webkit-tests-specific logic will be moved to
554         run_webkit_tests.py and dump_render_tree_thread.py.
555         
556         The biggest changes are that the Broker can now start a single
557         worker, but the responsibility for starting all of them is pushed
558         back to the TestRunner (Manager), and the logic for checking if
559         the threads are done or wedged is moved back to TestRunner. We
560         also remove WorkerMessageBroker.cleanup (not needed) and
561         cancel_workers (they have to be cancelled individually).
562         
563         The  message_broker is now encapsulated inside
564         TestRunner._run_tests(); it only needs to exist while actually
565         running the tests.
566
567         Also, delete a bunch of tests in message_broker_unittest that no
568         longer make much sense.
569
570         This patch depends on bug 50372.
571
572         https://bugs.webkit.org/show_bug.cgi?id=50374
573
574         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
575         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
576         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
577         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
578         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
579
580 2010-12-02  Hayato Ito  <hayato@chromium.org>
581
582         Reviewed by Eric Seidel.
583
584         Refactor test_types's compare_output() method so that it takes a
585         TestInput object.
586
587         compare_output() will need additional information included in a TestInput
588         object to support reftests. This change is a pre-requirement of that.
589
590         https://bugs.webkit.org/show_bug.cgi?id=50362
591
592         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
593         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
594         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
595         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
596         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
597
598 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
599
600         Reviewed by Anders Carlsson.
601
602         Add the ability to run script on 'new' and 'paint' in the test plugin
603         https://bugs.webkit.org/show_bug.cgi?id=50425
604         
605         Add "onnew" and "onpaintevent" attributes to the test plugin,
606         so that tests can run JS at these times.
607
608         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
609         (pluginAllocate):
610         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
611         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
612         (NPP_New):
613         (NPP_Destroy):
614         (handleEventCarbon):
615         (handleEventCocoa):
616         (NPP_HandleEvent):
617
618 2010-12-02  Sam Weinig  <sam@webkit.org>
619
620         Fix Qt build.
621
622         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
623         (WTR::PlatformWebView::PlatformWebView):
624
625 2010-12-02  Sam Weinig  <sam@webkit.org>
626
627         Reviewed by Anders Carlsson.
628
629         WebKit2 Preferences should be held off the PageGroup, not the Context
630         https://bugs.webkit.org/show_bug.cgi?id=50414
631
632         Update for API changes.
633
634         * WebKitTestRunner/PlatformWebView.h:
635         * WebKitTestRunner/TestController.cpp:
636         (WTR::createOtherPage):
637         (WTR::TestController::initialize):
638         (WTR::TestController::resetStateToConsistentValues):
639         * WebKitTestRunner/TestController.h:
640         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
641         (WTR::PlatformWebView::PlatformWebView):
642         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
643         (WTR::PlatformWebView::PlatformWebView):
644
645 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
646
647         Reviewed by Tony Chang.
648
649         new-run-webkit-tests: minor cleanup for multiprocessing work
650
651         This change:
652         * moves worker naming into TestShellThread, eliminating a
653           parameter to the constructor and putting the responsibility in
654           the correct place.
655         * eliminates the _WorkerState() class in message_broker, because
656           it turns out that state really needs to be in run_webkit_tests
657         * renames the Broker classes to be module-private.
658         * fixes a bunch of minor commenting and whitespace issues to
659           make subsequent patches a bit clearer.
660         * Adds a Port hook for default_worker_model() so that we can
661           accomodate the potential for different worker models on
662           different ports.
663         * merge in the fix from 50420 for the brokenness introduced in
664           bug 50367.
665
666         This patch depends on bug 50367.
667
668         https://bugs.webkit.org/show_bug.cgi?id=50372
669
670         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
671         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
672         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
673         * Scripts/webkitpy/layout_tests/port/base.py:
674         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
675         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
676
677 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
678
679         Reviewed by Tony Chang.
680
681         This change is a bunch of cleanup / refactoring of the file
682         below. It moves a bunch of free functions to methods on the
683         TestShellThread class, and restructures other methods to be
684         closer to the structure we'll need for the multiprocessing
685         rewrite.
686
687         It also makes the logic of --run-singly a *lot* easier to follow
688         by nestling all of the separate-thread logic into a single
689         routine.
690
691         There should be no semantic changes in this patch, just cleanup.
692
693         https://bugs.webkit.org/show_bug.cgi?id=50367
694
695         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
696
697 2010-12-02  Tony Chang  <tony@chromium.org>
698
699         Unreviewed, rolling out r73164.
700         http://trac.webkit.org/changeset/73164
701         https://bugs.webkit.org/show_bug.cgi?id=50359
702
703         broke debugger tests on win
704
705         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
706
707 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
708
709         Reviewed by Tony Chang.
710
711         Rebaseline server: add updating of baselines
712         https://bugs.webkit.org/show_bug.cgi?id=50305
713         
714         Implements updating of baselines, where we copy -actual.* files over
715         the current -expected.* files. To do this, we need a
716         _get_actual_result_files method to get test results files and a
717         _rebaseline_test method to actually do the file copy and SCM operation.
718         _rebaseline_test logs output into a buffer, this is useful for both
719         showing result in the UI and for unit tests.
720         
721         To make passing around of the various test environment properties
722         (results directory, filesystem, SCM, etc) easier, add a TestConfig
723         class for them.
724         
725         Moving of existing baselines is not implemented yet, this patch is big
726         enough as it is.
727
728         * Scripts/webkitpy/common/system/filesystem.py:
729         * Scripts/webkitpy/common/system/filesystem_mock.py:
730         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
731         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
732         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
733         * Scripts/webkitpy/tool/mocktool.py:
734
735 2010-12-02  Brent Fulgham  <bfulgham@webkit.org>
736
737         Unreviewed build fix after vcproj updates.
738
739         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Make sure
740         that WIN_CAIRO is defined for this build.
741         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Update file
742         to reflect new 'Debug_Cairo_CFLite' and 'Release_Cairo_CFLite'
743         (these were previously 'Debug_Cairo' and 'Release_Cairo'
744
745 2010-12-02  Sam Weinig  <sam@webkit.org>
746
747         Reviewed by Anders Carlsson.
748
749         WebKit2 needs API to turn on popup blocking
750         https://bugs.webkit.org/show_bug.cgi?id=50407
751
752         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
753         (TestWebKitAPI::TEST):
754         * WebKitTestRunner/TestController.cpp:
755         (WTR::TestController::resetStateToConsistentValues):
756
757 2010-12-01  Tony Chang  <tony@chromium.org>
758
759         Reviewed by Ojan Vafai.
760
761         [chromium] force NRWT to use DRT
762         https://bugs.webkit.org/show_bug.cgi?id=50359
763
764         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
765
766 2010-12-02  Martin Robinson  <mrobinson@igalia.com>
767
768         Reviewed by Xan Lopez.
769
770         [GTK] DumpRenderTree has two copies of JavaScriptCore
771         https://bugs.webkit.org/show_bug.cgi?id=49877
772
773         * GNUmakefile.am: Remove the second copy of JavaScriptCore from the
774         LDADD list for DumpRenderTree.
775
776 2010-12-02  Sergio Villar Senin  <svillar@igalia.com>
777
778         Unreviewed: Added myself to list of Committers.
779
780         * Scripts/webkitpy/common/config/committers.py:
781
782 2010-12-01  Mihai Parparita  <mihaip@chromium.org>
783
784         Reviewed by Adam Barth.
785
786         build-webkit --chromium always updates DEPS and re-generates project files
787         https://bugs.webkit.org/show_bug.cgi?id=50340
788         
789         Make build-webkit --chromium invoke update-webkit-chromium only when
790         --update-chromium is passed in, so that we don't add 20 seconds to all
791         builds.
792         
793         Making all invocations update was added with r61883, with the goal of
794         making EWS bots always update. The bots will switch to using this flag
795         (as will all other webkit-patch build steps) so nothing should change
796         for them.
797
798         * Scripts/webkitdirs.pm:
799         * Scripts/webkitpy/common/config/ports.py:
800         * Scripts/webkitpy/common/config/ports_unittest.py:
801
802 2010-12-01  Dirk Pranke  <dpranke@chromium.org>
803
804         Reviewed by Tony Chang.
805
806         new-run-webkit-tests: add a --dry-run / -n flag
807         https://bugs.webkit.org/show_bug.cgi?id=50045
808
809         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
810         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
811
812 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
813
814         Reviewed by Adam Roben.
815
816         WinCairo build should not use link-time code generation (LTCG)
817         https://bugs.webkit.org/show_bug.cgi?id=50353
818
819         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
820         * DumpRenderTree/win/DumpRenderTree.vcproj:
821         * DumpRenderTree/win/ImageDiff.vcproj:
822         * FindSafari/FindSafari.vcproj:
823         * MiniBrowser/MiniBrowser.vcproj:
824         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
825         * WebKitAPITest/WebKitAPITest.vcproj:
826         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
827         * WebKitTestRunner/win/InjectedBundle.vcproj:
828         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
829         * WinLauncher/WinLauncher.vcproj:
830         * record-memory-win/record-memory-win.vcproj:
831
832 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
833
834         Touch GetUserAgentWithNullNPPFromNPPNew.cpp in an effort to force
835         a rebuild of TestNetscapePlugin.la on GTK+. It seems that simply
836         adding the file to the sources list was not enough to force the rebuild.
837
838         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
839         Remove an empty line at the end of this file to force a rebuild.
840
841 2010-12-01  Sam Weinig  <sam@webkit.org>
842
843         Fix windows build.
844
845         * MiniBrowser/win/BrowserView.cpp:
846         (BrowserView::create):
847
848 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
849
850         Add missing file to the TestNetscapePlugin sources list after r73057.
851
852         * GNUmakefile.am: Add missing file.
853
854 2010-12-01  Sam Weinig  <sam@webkit.org>
855
856         Reviewed by Anders Carlsson.
857
858         Add PageGrouping to WebKit2 API
859         https://bugs.webkit.org/show_bug.cgi?id=50332
860
861         - Update testing harnesses to deal with new PageGroup API.
862
863         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
864         (WKBundleInitialize):
865         * TestWebKitAPI/InjectedBundleController.cpp:
866         (TestWebKitAPI::InjectedBundleController::initialize):
867         (TestWebKitAPI::InjectedBundleController::didInitializePageGroup):
868         (TestWebKitAPI::InjectedBundleController::initializeTestNamed):
869         * TestWebKitAPI/InjectedBundleController.h:
870         * TestWebKitAPI/InjectedBundleTest.h:
871         (TestWebKitAPI::InjectedBundleTest::initialize):
872         (TestWebKitAPI::InjectedBundleTest::didInitializePageGroup):
873         * TestWebKitAPI/PlatformUtilities.cpp:
874         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
875         * TestWebKitAPI/PlatformUtilities.h:
876         * TestWebKitAPI/PlatformWebView.h:
877         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
878         (TestWebKitAPI::TEST):
879         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
880         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
881         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
882         (TestWebKitAPI::PlatformWebView::PlatformWebView):
883         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
884         (TestWebKitAPI::PlatformWebView::PlatformWebView):
885         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
886         (WTR::InjectedBundle::didInitializePageGroup):
887         (WTR::InjectedBundle::initialize):
888         (WTR::InjectedBundle::beginTesting):
889         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
890         (WTR::InjectedBundle::pageGroup):
891         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
892         (WTR::LayoutTestController::addUserScript):
893         (WTR::LayoutTestController::addUserStyleSheet):
894         (WTR::LayoutTestController::setXSSAuditorEnabled):
895         * WebKitTestRunner/TestController.cpp:
896         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
897         (WTR::PlatformWebView::PlatformWebView):
898
899 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
900
901         Reviewed by Adam Roben.
902
903         vcproj changes can't be applied cleanly by the Windows EWS bot
904         https://bugs.webkit.org/show_bug.cgi?id=50328
905
906         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
907         * CLWrapper/CLWrapper.vcproj: Modified property svn:eol-style.
908         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
909         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added property svn:eol-style.
910         * DumpRenderTree/win/DumpRenderTree.vcproj: Modified property svn:eol-style.
911         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added property svn:eol-style.
912         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added property svn:eol-style.
913         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added property svn:eol-style.
914         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added property svn:eol-style.
915         * DumpRenderTree/win/ImageDiff.vcproj: Modified property svn:eol-style.
916         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added property svn:eol-style.
917         * FindSafari/FindSafari.vcproj: Modified property svn:eol-style.
918         * FindSafari/FindSafariCommon.vsprops: Added property svn:eol-style.
919         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
920         * MIDLWrapper/MIDLWrapper.vcproj: Modified property svn:eol-style.
921         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added property svn:eol-style.
922         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added property svn:eol-style.
923         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added property svn:eol-style.
924         * MiniBrowser/MiniBrowser.vcproj: Added property svn:eol-style.
925         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added property svn:eol-style.
926         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added property svn:eol-style.
927         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops: Added property svn:eol-style.
928         * TestWebKitAPI/win/TestWebKitAPI.sln: Added property svn:eol-style.
929         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added property svn:eol-style.
930         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added property svn:eol-style.
931         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added property svn:eol-style.
932         * WebKitAPITest/WebKitAPITest.vcproj: Added property svn:eol-style.
933         * WebKitAPITest/WebKitAPITestCommon.vsprops: Added property svn:eol-style.
934         * WebKitLauncherWin/WebKitLauncherWin.vcproj: Modified property svn:eol-style.
935         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added property svn:eol-style.
936         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added property svn:eol-style.
937         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added property svn:eol-style.
938         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops: Added property svn:eol-style.
939         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added property svn:eol-style.
940         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added property svn:eol-style.
941         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added property svn:eol-style.
942         * WebKitTestRunner/WebKitTestRunner.sln: Added property svn:eol-style.
943         * WebKitTestRunner/win/InjectedBundle.vcproj: Added property svn:eol-style.
944         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added property svn:eol-style.
945         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added property svn:eol-style.
946         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added property svn:eol-style.
947         * WinLauncher/WinLauncher.vcproj: Modified property svn:eol-style.
948         * WinLauncher/WinLauncherCommon.vsprops: Added property svn:eol-style.
949         * record-memory-win/record-memory-win-common.vsprops: Added property svn:eol-style.
950         * record-memory-win/record-memory-win.vcproj: Modified property svn:eol-style.
951
952 2010-12-01  Anders Carlsson  <andersca@apple.com>
953
954         Reviewed by Darin Adler.
955
956         Return a correct user agent if NPN_UserAgent is called with a null NPP from NPP_New.
957         https://bugs.webkit.org/show_bug.cgi?id=50336
958
959         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
960         Add new test.
961
962         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
963         (PluginTest::NPP_New):
964         Add default implementation/
965
966         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
967         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp: Added.
968         (GetUserAgentWithNullNPPFromNPPNew::GetUserAgentWithNullNPPFromNPPNew):
969         (GetUserAgentWithNullNPPFromNPPNew::NPP_New):
970         Get the user agent.
971
972         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
973         (NPP_New):
974         Call PluginTest::NPP_New.
975
976         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
977         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
978         Add new files.
979
980         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
981         (webkit_test_plugin_new_instance):
982         Call PluginTest::NPP_New.
983
984 2010-12-01  Kevin Ollivier  <kevino@theolliviers.com>
985
986         [wx] Build fixes after recent trunk changes.
987
988         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
989         (LayoutTestController::findString):
990         * wx/build/settings.py:
991
992 2010-12-01  Dan Bernstein  <mitz@apple.com>
993
994         Reviewed by Darin Adler.
995
996         WebKitTestRunner needs layoutTestController.findString
997         https://bugs.webkit.org/show_bug.cgi?id=50238
998
999         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added findString().
1000         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1001         (WTR::LayoutTestController::findString): Updated signature for autogenerated bindings.
1002         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
1003
1004 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
1005
1006         Try using svn:eol-style native on a vcproj file.
1007
1008         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Modified property svn:eol-style.
1009
1010 2010-12-01  Patrick Gansterer  <paroga@webkit.org>
1011
1012         Reviewed by Adam Roben.
1013
1014         [WINCE] Add WinCELauncher
1015         https://bugs.webkit.org/show_bug.cgi?id=50217
1016
1017         * WinCELauncher/main.cpp: Added.
1018
1019 2010-11-30  Benjamin Poulain  <benjamin.poulain@nokia.com>
1020
1021         Reviewed by Kenneth Rohde Christiansen.
1022
1023         [Qt] Implement layoutTestController.findString
1024         https://bugs.webkit.org/show_bug.cgi?id=50236
1025
1026         Add the missing function to the LayoutTestController.
1027
1028         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1029         (LayoutTestController::findString):
1030         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1031
1032 2010-11-30  Tony Chang  <tony@chromium.org>
1033
1034         Reviewed by Adam Barth.
1035
1036         [chromium] fix get-int-identifier-special-values.html using TestNetscapePlugIn
1037         https://bugs.webkit.org/show_bug.cgi?id=49036
1038
1039         * DumpRenderTree/chromium/LayoutTestController.cpp: Use IsNumber instead of IsInt32
1040             for CppVariants.
1041         (LayoutTestController::cppVariantToBool):
1042         (LayoutTestController::cppVariantToInt32):
1043         (LayoutTestController::setDatabaseQuota):
1044         (LayoutTestController::evaluateInWebInspector):
1045         (LayoutTestController::setMockGeolocationError):
1046
1047 2010-11-30  Eric Seidel  <eric@webkit.org>
1048
1049         Reviewed by Tony Chang.
1050
1051         update-webkit should call git fetch before git svn rebase
1052         https://bugs.webkit.org/show_bug.cgi?id=50273
1053
1054         After discussion on webkit-dev, we've decided to move the "default"
1055         git setup to pulling updates from git.webkit.org in preference
1056         to rebuilding the local svn index using git svn fetch every time.
1057
1058         This change should have no effect on people using the "old" git setup
1059         and should dramatically increase the speed of updates for those using
1060         the "new" git setup along with update-webkit.  I'm about to move the
1061         EWS and other queues over to this setup once this lands.
1062
1063         * Scripts/update-webkit:
1064
1065 2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>
1066
1067         Reviewed by Xan Lopez.
1068
1069         GTK: AX: implement press in DRT
1070         https://bugs.webkit.org/show_bug.cgi?id=36146
1071
1072         Implement AccessibilityUIElement::press() for GTK.
1073
1074         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1075         (AccessibilityUIElement::press): Implemented.
1076
1077 2010-11-29  Mihai Parparita  <mihaip@chromium.org>
1078
1079         Reviewed by Tony Chang.
1080
1081         config.webkit_base_dir returns a path with a trailing slash
1082         https://bugs.webkit.org/show_bug.cgi?id=50197
1083         
1084         config.webkit_base_dir() should return a path without a trailing slash,
1085         like all the other methods that return paths.
1086         
1087         Undoes MockFileSytem changes by r72640, since they're no longer
1088         necessary for GetBaselinesTest to pass.
1089
1090         * Scripts/webkitpy/common/system/filesystem_mock.py:
1091         * Scripts/webkitpy/layout_tests/port/base.py:
1092         * Scripts/webkitpy/layout_tests/port/config.py:
1093         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1094
1095 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
1096
1097         Reviewed by Tony Chang.
1098
1099         Rebaseline server: baseline display tweaks
1100         https://bugs.webkit.org/show_bug.cgi?id=50207
1101         
1102         Determine which baselines were used when running the tests and highlight
1103         them in the UI. Sort platform names alphabetically.
1104         
1105         Also makes the server URL be launched in the user's browser
1106         automatically.
1107
1108         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1109         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1110         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
1111         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1112         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
1113
1114 2010-11-30  Dan Bernstein  <mitz@apple.com>
1115
1116         Reviewed by Anders Carlsson.
1117
1118         <rdar://problem/8710645> WebKitTestRunner needs layoutTestController.findString
1119         https://bugs.webkit.org/show_bug.cgi?id=50238
1120
1121         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1122         (WTR::LayoutTestController::findString): Added.
1123         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1124
1125 2010-11-30  Steve Falkenburg  <sfalken@apple.com>
1126
1127         Reviewed by Adam Roben.
1128
1129         All projects on Windows should use cmd files for build events
1130         https://bugs.webkit.org/show_bug.cgi?id=50213
1131
1132         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
1133         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Added.
1134         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Added.
1135         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
1136         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Added.
1137         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Added.
1138         * DumpRenderTree/win/ImageDiffCommon.vsprops:
1139         * DumpRenderTree/win/ImageDiffPostBuild.cmd: Added.
1140         * DumpRenderTree/win/ImageDiffPreBuild.cmd: Added.
1141         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops:
1142         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
1143         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops:
1144         * MiniBrowser/MiniBrowserPostBuild.cmd: Added.
1145         * MiniBrowser/MiniBrowserPreBuild.cmd: Added.
1146         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
1147         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Added.
1148         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Added.
1149         * WebKitAPITest/WebKitAPITestCommon.vsprops:
1150         * WebKitAPITest/WebKitAPITestPostBuild.cmd: Added.
1151         * WebKitAPITest/WebKitAPITestPreBuild.cmd: Added.
1152         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
1153         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
1154         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd: Added.
1155         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd: Added.
1156         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd: Added.
1157         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd: Added.
1158         * WinLauncher/WinLauncherCommon.vsprops:
1159         * WinLauncher/WinLauncherPostBuild.cmd: Added.
1160         * WinLauncher/WinLauncherPreBuild.cmd: Added.
1161
1162 2010-11-29  Dan Bernstein  <mitz@apple.com>
1163
1164         GTK DumpRenderTree build fix after r72887.
1165
1166         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1167         (LayoutTestController::findString):
1168
1169 2010-11-29  Dan Bernstein  <mitz@apple.com>
1170
1171         Windows DumpRenderTree build fix after r72887.
1172
1173         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1174         (LayoutTestController::findString): Added empty implementation.
1175
1176 2010-11-29  Dan Bernstein  <mitz@apple.com>
1177
1178         Reviewed by Darin Adler.
1179
1180         DumpRenderTree changes for testing the text search API.
1181         https://bugs.webkit.org/show_bug.cgi?id=50038
1182
1183         * DumpRenderTree/LayoutTestController.cpp:
1184         (findStringCallback):
1185         (LayoutTestController::staticFunctions):
1186         * DumpRenderTree/LayoutTestController.h:
1187         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1188         (LayoutTestController::findString):
1189         * MiniBrowser/mac/BrowserWindowController.m:
1190         (-[BrowserWindowController find:]):
1191
1192 2010-11-29  Johnny Ding  <jnd@chromium.org>
1193
1194         Unreviewed: Add myself to the list of Committers.
1195
1196         * Scripts/webkitpy/common/config/committers.py:
1197
1198 2010-11-29  Mark Rowe  <mrowe@apple.com>
1199
1200         Reviewed by Adele Peterson.
1201
1202         <rdar://problem/8694997> DumpRenderTree fails to build.
1203
1204         * DumpRenderTree/mac/PerlSupport/Makefile: Skip generating wrappers.
1205
1206 2010-11-29  Mark Rowe  <mrowe@apple.com>
1207
1208         Reviewed by Adele Peterson.
1209
1210         <rdar://problem/8694997> DumpRenderTree fails to build.
1211
1212         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm.
1213         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapTiger.c.
1214         * DumpRenderTree/mac/PerlSupport/Makefile:
1215
1216 2010-11-29  Mario Sanchez Prada  <msanchez@igalia.com>
1217
1218         Reviewed by Martin Robinson.
1219
1220         [GTK] Null-check needed in DRT's AccessibilityUIElement::allAtributes()
1221         https://bugs.webkit.org/show_bug.cgi?id=50154
1222
1223         Added missing checks to allAttributes().
1224
1225         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1226         (AccessibilityUIElement::allAttributes): Added missing checks.
1227
1228 2010-11-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1229
1230         Reviewed by Kenneth Rohde Christiansen.
1231
1232         [Qt] Allow pre-generation for package builds for WebKit2
1233         https://bugs.webkit.org/show_bug.cgi?id=50139
1234
1235         Use a build variable for the generated directory path and set the
1236         value based on CONFIG just like for WebKit1.
1237
1238         For non-package builds use a relative base path for the
1239         genrated directory just like for WebKit1.
1240
1241         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1242         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1243
1244 2010-11-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1245
1246         Reviewed by Kenneth Rohde Christiansen.
1247
1248         [Qt] Move some build logic from Qt to platform independent code
1249         https://bugs.webkit.org/show_bug.cgi?id=50134
1250
1251         Create target directories inside generate-forwarding-headers.pl.
1252
1253         * Scripts/generate-forwarding-headers.pl:
1254
1255 2010-11-24  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
1256
1257         Reviewed by Martin Robinson.
1258
1259         [GTK] Windowless plugins gets broken key input
1260         https://bugs.webkit.org/show_bug.cgi?id=49927
1261
1262         Convert the XEvent::keycode to ASCII before printing it. Not
1263         doing this was causing false positive in 
1264         plugins/keyboard-events.html.
1265
1266         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1267         (keycode_to_char):
1268         (webkit_test_plugin_handle_event):
1269
1270 2010-11-24  Jan Erik Hanssen  <jhanssen@sencha.com>
1271
1272         Reviewed by Antonio Gomes.
1273
1274         [Qt] Html autofocus not working with QGraphicsWebView
1275         https://bugs.webkit.org/show_bug.cgi?id=43169
1276
1277         Tell the scene to set the webview item as the currently
1278         focused item. This makes the input field with autofocus get
1279         focus as it should.
1280
1281         * QtTestBrowser/webview.cpp:
1282         (WebViewGraphicsBased::WebViewGraphicsBased):
1283
1284 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
1285
1286         Reviewed by Tony Chang.
1287
1288         nrwt - clean up create_driver interface and print out the
1289         command line used for DumpRenderTree/TestShell.
1290
1291         This patch adds a driver_cmd_line() call to the Port class in
1292         order to retrive the command line to print it out (as part of
1293         --print config).
1294
1295         In addition, this patch cleans up the Port.create_driver()
1296         signature and the Driver constructor interface to take a worker
1297         number and no longer require the image_path argument (Chromium's
1298         drivers now synthesize the image_path from the worker number
1299         internally).
1300
1301         https://bugs.webkit.org/show_bug.cgi?id=49934
1302
1303         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1304         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1305         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1306         * Scripts/webkitpy/layout_tests/port/base.py:
1307         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1308         * Scripts/webkitpy/layout_tests/port/chromium.py:
1309         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1310         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1311         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1312         * Scripts/webkitpy/layout_tests/port/test.py:
1313         * Scripts/webkitpy/layout_tests/port/webkit.py:
1314         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1315         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1316
1317 2010-11-24  Ojan Vafai  <ojan@chromium.org>
1318
1319         Reviewed by Tony Chang.
1320
1321         [chromium] improve memory usage for test results server and store fewer runs
1322         https://bugs.webkit.org/show_bug.cgi?id=50035
1323
1324         Store fewer runs and don't pass full files around when we only need bools.
1325         Greatly improves error rates on test-results.appspot.com.
1326
1327         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1328         * TestResultServer/handlers/testfilehandler.py:
1329         * TestResultServer/model/dashboardfile.py:
1330         * TestResultServer/model/jsonresults.py:
1331
1332 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
1333
1334         Reviewed by Tony Chang.
1335
1336         This patch implements the first part of the manager side of the
1337         Broker objects - it handles creating threads, waiting for them
1338         to complete, and running a single-threaded loop as well.
1339
1340         https://bugs.webkit.org/show_bug.cgi?id=49779
1341
1342         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1343         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
1344         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1345         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1346
1347 2010-11-24  Mihai Parparita  <mihaip@chromium.org>
1348
1349         Reviewed by David Levin.
1350
1351         DRT should not generate pixel output for text/plain tests
1352         https://bugs.webkit.org/show_bug.cgi?id=50002
1353         
1354         Modify Mac, Windows and GTK DRT implementations to disable pixel output
1355         when encountering a text/plain response (the Chromium one already does
1356         this, and none of the other ports special-case text/plain output in
1357         the first place).
1358
1359         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1360         (dump):
1361         * DumpRenderTree/mac/DumpRenderTree.mm:
1362         (dump):
1363         * DumpRenderTree/win/DumpRenderTree.cpp:
1364         (dump):
1365
1366 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
1367
1368         Unreviewed.
1369
1370         Add my other email address to committers.py.
1371
1372         * Scripts/webkitpy/common/config/committers.py:
1373
1374 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
1375
1376         Reviewed by Csaba Osztrogonác.
1377
1378         Make build-webkit --minimal build with ENABLE_INSPECTOR=0
1379         https://bugs.webkit.org/show_bug.cgi?id=49975
1380
1381         * Scripts/build-webkit: Add ENABLE_INSPECTOR define to features,
1382         to enable the script to define it 0 in case of a minimal build.
1383
1384 2010-11-24  Martin Robinson  <mrobinson@igalia.com>
1385
1386         Reviewed by Xan Lopez.
1387
1388         [GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient
1389         https://bugs.webkit.org/show_bug.cgi?id=49143
1390
1391         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1392         (createWebView): Call the new connectEditingCallbacks function.
1393         * DumpRenderTree/gtk/EditingCallbacks.cpp: Added.
1394         (dumpNodePath):
1395         (dumpRange):
1396         (insertActionString):
1397         (selectionAffinityString):
1398         (shouldBeginEditing):
1399         (shouldEndEditing):
1400         (shouldInsertNode):
1401         (shouldInsertText):
1402         (shouldDeleteRange):
1403         (shouldShowDeleteInterfaceForElement):
1404         (shouldChangeSelectedRange):
1405         (shouldApplyStyle):
1406         (editingBegan):
1407         (userChangedContents):
1408         (editingEnded):
1409         (selectionChanged):
1410         (connectEditingCallbacks):
1411         * DumpRenderTree/gtk/EditingCallbacks.h: Added.
1412         * GNUmakefile.am: Added EditingCallbacks.{h,cpp} to the source list.
1413
1414 2010-11-24  Yi Shen  <yi.4.shen@nokia.com>
1415
1416         Reviewed by Andreas Kling.
1417
1418         [Qt] Make QtTestBrowser remember the selected user agent
1419         https://bugs.webkit.org/show_bug.cgi?id=50021
1420
1421         Set user agent for a new page by using the old page's
1422
1423         * QtTestBrowser/mainwindow.cpp:
1424         (MainWindow::setPage):
1425
1426 2010-11-24 Patrick Gansterer <paroga@webkit.org>
1427
1428         Reviewed by Csaba Osztrogonác.
1429
1430         Remove Bakefile build system files
1431         https://bugs.webkit.org/show_bug.cgi?id=49983
1432
1433         r53757 only removed the content, but not the files.
1434         This patch removes that empty files.
1435
1436         * DumpRenderTree/wx/DumpRenderTree.bkl: Removed.
1437         * wx/browser/browser.bkl: Removed.
1438         * wx/build-wxwebkit: Removed.
1439
1440 2010-11-23  Dirk Pranke  <dpranke@chromium.org>
1441
1442         Reviewed by Tony Chang.
1443
1444         This patch cleans up the logic used to shard tests into groups a
1445         bit and adds the --worker-model flag to NRWT. The flag is only
1446         used at the moment to control whether to run single-threaded or
1447         not, but eventually will also allow toggling between threads and
1448         processes.
1449
1450         Also add a minor cleanup with _test_is_slow(), which just
1451         eliminates some repetition and gives slightly better encapsulation.
1452
1453         https://bugs.webkit.org/show_bug.cgi?id=49773
1454
1455         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1456         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1457
1458 2010-11-23  Mihai Parparita  <mihaip@chromium.org>
1459
1460         Reviewed by Tony Chang.
1461
1462         Rebaseline server: list current baselines and platforms
1463         https://bugs.webkit.org/show_bug.cgi?id=49991
1464         
1465         List existing baselines (with Trac links) for tests.
1466         
1467         Add dropdowns for choosing with platform baselines to target (and what
1468         to do with existing ones).
1469
1470         Also fix MockFileSystem.join to behave more like os.path.join (unit
1471         test was ending up with two consecutive slashes in a layout test
1472         path).        
1473
1474         * Scripts/webkitpy/common/system/filesystem_mock.py:
1475         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1476         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1477         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1478         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
1479         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
1480         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1481         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py: Added.
1482
1483 2010-11-23  Ojan Vafai  <ojan@chromium.org>
1484
1485         Reviewed by Tony Chang.
1486
1487         remove timeout argument to urlopen
1488         https://bugs.webkit.org/show_bug.cgi?id=49995
1489
1490         Apparently the version of python we have on the bots doesn't accept a timeout argument.
1491
1492         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
1493
1494 2010-11-23  Sheriff Bot  <webkit.review.bot@gmail.com>
1495
1496         Unreviewed, rolling out r72628.
1497         http://trac.webkit.org/changeset/72628
1498         https://bugs.webkit.org/show_bug.cgi?id=49994
1499
1500         This patch is causing layout-test failtures on GTK Linux
1501         64-bit Debug (Requested by ctguil on #webkit).
1502
1503         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
1504         (AccessibilityUIElement::AccessibilityUIElement):
1505         (AccessibilityUIElement::parentElementCallback):
1506         * DumpRenderTree/chromium/AccessibilityUIElement.h:
1507         * DumpRenderTree/chromium/CppBoundClass.cpp:
1508         * DumpRenderTree/chromium/CppBoundClass.h:
1509
1510 2010-11-22  Ojan Vafai  <ojan@chromium.org>
1511
1512         Reviewed by Tony Chang.
1513
1514         speculative fix for upload errors: stop using mechanize to upload to test-results.appspot.com
1515         https://bugs.webkit.org/show_bug.cgi?id=49944
1516
1517         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
1518
1519 2010-11-23  Chris Guillory  <chris.guillory@google.com>
1520
1521         Reviewed by Dimitri Glazkov.
1522
1523         Include the FrameView widget of a RenderWidget in the accessibility tree.
1524         https://bugs.webkit.org/show_bug.cgi?id=49106
1525
1526         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
1527         (AccessibilityUIElement::AccessibilityUIElement):
1528         (AccessibilityUIElement::parentElementCallback):
1529         (AccessibilityUIElement::isEqualCallback):
1530         * DumpRenderTree/chromium/AccessibilityUIElement.h:
1531         * DumpRenderTree/chromium/CppBoundClass.cpp:
1532         (CppBoundClass::getFromCppVariant):
1533         * DumpRenderTree/chromium/CppBoundClass.h:
1534
1535 2010-11-23  Alex Grilo  <abgrilo@profusion.mobi>
1536
1537         Reviewed by Kenneth Rohde Christiansen.
1538
1539         [EFL] Add tiled backing store to EWebLauncher
1540         https://bugs.webkit.org/show_bug.cgi?id=45777
1541
1542         Allow EWebLauncher to choose between single and tiled backing store
1543
1544         * EWebLauncher/main.c:
1545         (on_key_down):
1546         (browserCreate):
1547         (main):
1548
1549 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
1550
1551         Reviewed by Tor Arne Vestbø.
1552
1553         [Qt] Review the setUserPermission & friends API
1554         https://bugs.webkit.org/show_bug.cgi?id=46810
1555
1556         Renamed requestPermissionFromUser to featurePermissionRequested
1557         and cancelRequestsForPermission to featurePermissionRequestCanceled.
1558
1559         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1560         (WebCore::WebPage::WebPage):
1561         * QtTestBrowser/webpage.cpp:
1562         (WebPage::WebPage):
1563         (WebPage::featurePermissionRequestCanceled):
1564         * QtTestBrowser/webpage.h:
1565
1566 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
1567
1568         Reviewed by Tor Arne Vestbø.
1569
1570         [Qt] Review the setUserPermission & friends API
1571         https://bugs.webkit.org/show_bug.cgi?id=46810
1572
1573         Rename setUserPermission to setFeaturePermission
1574
1575         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1576         (WebCore::WebPage::requestPermission):
1577         (WebCore::WebPage::permissionSet):
1578         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1579         (LayoutTestController::grantDesktopNotificationPermission):
1580         * QtTestBrowser/webpage.cpp:
1581         (WebPage::requestPermission):
1582
1583 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
1584
1585         Reviewed by Tor Arne Vestbø.
1586
1587         [Qt] Review the setUserPermission & friends API
1588         https://bugs.webkit.org/show_bug.cgi?id=46810
1589
1590         Rename PermissionDomain to Feature, NotificationsPermissionDomain to Notifications
1591         and GeolocationPermissionDomain to Geolocation.
1592
1593         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1594         (WebCore::WebPage::WebPage):
1595         (WebCore::WebPage::requestPermission):
1596         (WebCore::WebPage::cancelPermission):
1597         (WebCore::WebPage::permissionSet):
1598         (WebCore::DumpRenderTree::geolocationPermissionSet):
1599         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1600         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1601         (LayoutTestController::grantDesktopNotificationPermission):
1602         * QtTestBrowser/webpage.cpp:
1603         (WebPage::WebPage):
1604         (WebPage::requestPermission):
1605         (WebPage::cancelRequestsForPermission):
1606         * QtTestBrowser/webpage.h:
1607
1608 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
1609
1610         Reviewed by Tor Arne Vestbø.
1611
1612         [Qt] Review the setUserPermission & friends API
1613         https://bugs.webkit.org/show_bug.cgi?id=46810
1614
1615         Add a ByUser suffix to PermissionGranted/Denied. In the future
1616         we can add PermissionGrantedByDefault.
1617
1618
1619         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1620         (WebCore::WebPage::requestPermission):
1621         (WebCore::WebPage::permissionSet):
1622         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1623         (LayoutTestController::grantDesktopNotificationPermission):
1624         * QtTestBrowser/webpage.cpp:
1625         (WebPage::requestPermission):
1626
1627 2010-11-18  Satish Sampath  <satish@chromium.org>
1628
1629         Reviewed by Jeremy Orlow.
1630
1631         For speech input event, send an event object containing all the recognition results and metadata.
1632         https://bugs.webkit.org/show_bug.cgi?id=49736
1633
1634         Updated DRT by renaming the mock result method on all platforms to the new signature.
1635
1636         * DumpRenderTree/LayoutTestController.cpp:
1637         (addMockSpeechInputResultCallback):
1638         (LayoutTestController::staticFunctions):
1639         * DumpRenderTree/LayoutTestController.h:
1640         * DumpRenderTree/chromium/LayoutTestController.cpp:
1641         (LayoutTestController::LayoutTestController):
1642         (LayoutTestController::addMockSpeechInputResult):
1643         * DumpRenderTree/chromium/LayoutTestController.h:
1644         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1645         (LayoutTestController::addMockSpeechInputResult):
1646         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1647         (LayoutTestController::addMockSpeechInputResult):
1648         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1649         (LayoutTestController::addMockSpeechInputResult):
1650         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1651         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1652         (LayoutTestController::addMockSpeechInputResult):
1653         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1654         (LayoutTestController::addMockSpeechInputResult):
1655
1656 2010-11-22  Dirk Pranke  <dpranke@chromium.org>
1657
1658         Reviewed by Tony Chang.
1659
1660         Fix some spacing issues with log messages with
1661         new-run-webkit-tests --verbose.
1662
1663         https://bugs.webkit.org/show_bug.cgi?id=49936
1664
1665         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1666
1667 2010-11-22  Ojan Vafai  <ojan@chromium.org>
1668
1669         Reviewed by Adam Barth.
1670
1671         update scm to work with different remote branches
1672         https://bugs.webkit.org/show_bug.cgi?id=49949
1673
1674         This works if there are multiple svn tracking branches
1675         and/or if the tracking branch is refs/remots/origin/master
1676         instead of refs/remotes/trunk which is the direction we're trying
1677         to head since that makes fetches faster.
1678
1679         * Scripts/webkitpy/common/checkout/scm.py:
1680         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1681
1682 2010-11-22  Hayato Ito  <hayato@chromium.org>
1683
1684         Reviewed by Shinichiro Hamaji.
1685
1686         Ignore reference files which will be used by reftests when collecting
1687         test cases.
1688         https://bugs.webkit.org/show_bug.cgi?id=49835
1689
1690         * Scripts/webkitpy/layout_tests/port/test_files.py:
1691         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1692
1693 2010-11-22  Adam Roben  <aroben@apple.com>
1694
1695         Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files
1696
1697         Apple's Windows build allows placing header files and import libraries for WebKit's
1698         dependencies (CoreGraphics, CFNetwork, SQLite, etc.) outside the source tree via the
1699         $WebKitLibrariesDir environment variable. This is both required for production builds and
1700         convenient for Apple-internal developer builds. Apple's production builds also require that
1701         WebKit's shared .vsprops files be accessed relative to $WebKitLibrariesDir. In production
1702         builds, the files are copied into that directory tree by the
1703         WebKitLibraries/win/tools/WinTools.make file. In Apple-internal developer builds, the
1704         copying is done by
1705         JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make.
1706
1707         This .vsprops copying is problematic in one very important case: when a developer updates
1708         their source tree and then tries to build. Visual Studio only reads .vsprops files when a
1709         project is first loaded. So, when Visual Studio is first opened after the .vsprops files are
1710         updated, it reads in the old files that were already residing in $WebKitLibrariesDir. When a
1711         build is started, JavaScriptCoreGenerated.make copies the new .vsprops files into
1712         $WebKitLibrariesDir, but Visual Studio will not pick up the changes.  The rest of the build
1713         will proceed with out-of-date .vsprops files, which will likely result in a build failure.
1714
1715         To fix this, we now use normal relative paths to access the .vsprops files in the source
1716         tree rather than in $WebKitLibrariesDir, but prefix those paths with a new environment
1717         variable, $WebKitVSPropsRedirectionDir. In developer builds, this environment variable is
1718         unset, so the normal relative paths are used to read the .vsprops files out of the source
1719         tree directly. In production builds, this environment variable is set to a fake directory
1720         that will cause the .vsprops files in $WebKitLibrariesDir to be found when the relative path
1721         is resolved.
1722         
1723         For example, JavaScriptCore.vcproj uses this path for FeatureDefines.vsprops:
1724
1725         $(WebKitVSPropsRedirectionDir)..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
1726
1727         In developer builds, where $WebKitVSPropsRedirectionDir is unset, this will point to the
1728         files in WebKitLibraries\win\tools\vsprops in the source tree. In production builds,
1729         JavaScriptCore.make sets $WebKitVSPropsRedirectionDir to
1730         "$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\", so the full path for
1731         FeatureDefines.vsprops becomes:
1732
1733         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
1734
1735         which resolves to:
1736
1737         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
1738
1739         (We rely on the fact that Windows doesn't care whether the directories "1", "2", and "3"
1740         actually exist since they are matched by an equal number of ".." path components.)
1741
1742         Note that Visual Studio still won't pick up changes made to .vsprops files while Visual
1743         Studio is open, but that problem hasn't seemed to cause developers many headaches so far.
1744
1745         Fixes <http://webkit.org/b/49181> Windows build fails mysteriously when .vsprops files are
1746         updated
1747
1748         Reviewed by Dave Hyatt.
1749
1750         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1751         * DumpRenderTree/win/DumpRenderTree.vcproj:
1752         * DumpRenderTree/win/ImageDiff.vcproj:
1753         * FindSafari/FindSafari.vcproj:
1754         * MiniBrowser/MiniBrowser.vcproj:
1755         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1756         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
1757         * WebKitAPITest/WebKitAPITest.vcproj:
1758         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1759         * WebKitTestRunner/win/InjectedBundle.vcproj:
1760         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1761         * WinLauncher/WinLauncher.vcproj:
1762         * record-memory-win/record-memory-win.vcproj:
1763         Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
1764         files.
1765
1766 2010-11-22  Adam Roben  <aroben@apple.com>
1767
1768         Make it possible to run tests on Windows without Visual Studio or VC++
1769         Express installed
1770
1771         webkitdir.pm::setupCygwinEnv dies when Visual Studio and VC++ Express
1772         are not installed. But this function doesn't need to be called when we
1773         already have a build available and are just trying to run the tests.
1774
1775         Fixes <http://webkit.org/b/49932> New Windows 7 bot can't run tests
1776         because Visual Studio/VC++ Express aren't installed
1777
1778         Reviewed by Dave Hyatt.
1779
1780         * Scripts/webkitdirs.pm:
1781         (determineConfigurationForVisualStudio): Don't call setupCygwinEnv, as
1782         it is not needed by this function. Also added a FIXME.
1783
1784         (usingVisualStudioExpress): Call setupCygwinEnv directly rather than
1785         relying on determineConfigurationForVisualStudio doing it.
1786
1787 2010-11-19  Hayato Ito  <hayato@chromium.org>
1788
1789         Reviewed by Shinichiro Hamaji.
1790
1791         Simplify Driver.run_test() so that it takes only one parameter, TestInput.
1792
1793         https://bugs.webkit.org/show_bug.cgi?id=49812
1794
1795         * Scripts/webkitpy/layout_tests/driver_test.py:
1796         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1797         * Scripts/webkitpy/layout_tests/port/base.py:
1798         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1799         * Scripts/webkitpy/layout_tests/port/chromium.py:
1800         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1801         * Scripts/webkitpy/layout_tests/port/test.py:
1802         * Scripts/webkitpy/layout_tests/port/webkit.py:
1803         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1804         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1805
1806 2010-11-22  Hayato Ito  <hayato@chromium.org>
1807
1808         Reviewed by Tony Chang.
1809
1810         [NRWT] Retry a few times in reading a png image to avoid a race condition.
1811
1812         https://bugs.webkit.org/show_bug.cgi?id=49924
1813
1814         * Scripts/webkitpy/layout_tests/port/chromium.py:
1815
1816 2010-11-22  João Paulo Rechi Vita  <jprvita@profusion.mobi>
1817
1818         Reviewed by Kenneth Rohde Christiansen.
1819
1820         Fix EWebLauncher zoom discretization
1821         https://bugs.webkit.org/show_bug.cgi?id=49810
1822
1823         * EWebLauncher/main.c:
1824         (nearest_zoom_level_get):
1825         (zoom_level_set):
1826         (on_load_finished):
1827         (on_key_down):
1828
1829 2010-11-21  Sam Weinig  <sam@webkit.org>
1830
1831         Rubber-stamped by Dan Bernstein.
1832
1833         Fix ~300 WebKit2 tests by enabling developer extras preference.
1834
1835         * WebKitTestRunner/TestController.cpp:
1836         (WTR::TestController::resetStateToConsistentValues):
1837
1838 2010-11-21  Sam Weinig  <sam@webkit.org>
1839
1840         Reviewed by Dan Bernstein.
1841
1842         Textareas should be resizable by default
1843         https://bugs.webkit.org/show_bug.cgi?id=49892
1844
1845         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1846         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp: Added.
1847         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1848         Add preferences test.
1849
1850 2010-11-19  Mihai Parparita  <mihaip@chromium.org>
1851
1852         Reviewed by Tony Chang.
1853
1854         Rebaseline server: checksum-only differences and prefetching
1855         https://bugs.webkit.org/show_bug.cgi?id=49841
1856         
1857         Add support for image test results where the only difference is in the
1858         checksum.
1859         
1860         Add prefetching of the image results from the next test.
1861         
1862         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1863         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1864         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1865
1866 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
1867
1868         Reviewed by Tony Chang.
1869
1870         nrwt multiprocessing - add 'worker number' concept, move stuff to worker thread
1871
1872         Add the 'worker number' and 'worker name' concepts to the 
1873         TestShellThread objects, and move test_types and test_args from
1874         the TestRunner to the TestShellThread.
1875
1876         https://bugs.webkit.org/show_bug.cgi?id=49768
1877
1878         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1879         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1880
1881 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
1882
1883         Reviewed by Ojan Vafai.
1884
1885         Do some minor cleanup and bug fixing.
1886
1887         https://bugs.webkit.org/show_bug.cgi?id=49777
1888
1889         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1890         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1891
1892 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
1893
1894         Reviewed by Ojan Vafai.
1895
1896         nrwt - config.build_directory() is busted
1897
1898         Fixes a typo that was causing us to usually return the top level
1899         directory WebKitBuild instead of WebKitBuild/{Debug,Release}. The
1900         bug was hidden by test stubs that were too simplistic :(.
1901
1902         https://bugs.webkit.org/show_bug.cgi?id=49815
1903
1904         * Scripts/webkitpy/common/system/executive_mock.py:
1905         * Scripts/webkitpy/layout_tests/port/config.py:
1906         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1907
1908 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
1909
1910         Reviewed by Adam Roben.
1911
1912         Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
1913         https://bugs.webkit.org/show_bug.cgi?id=49819
1914
1915         * DumpRenderTree/DumpRenderTree.sln:
1916         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1917         * DumpRenderTree/win/DumpRenderTree.vcproj:
1918         * DumpRenderTree/win/ImageDiff.vcproj:
1919         * FindSafari/FindSafari.vcproj:
1920         * MiniBrowser/MiniBrowser.vcproj:
1921         * TestWebKitAPI/win/TestWebKitAPI.sln:
1922         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1923         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
1924         * WebKitAPITest/WebKitAPITest.vcproj:
1925         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1926         * WebKitTestRunner/win/InjectedBundle.vcproj:
1927         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
1928         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1929         * WinLauncher/WinLauncher.vcproj:
1930         * record-memory-win/record-memory-win.vcproj:
1931
1932 2010-11-19  Adam Roben  <aroben@apple.com>
1933
1934         Add some more Windows slaves
1935
1936         This is probably more than we will be using in the immediate future,
1937         but having some extra slave names makes experimenting with different
1938         configurations easier.
1939
1940         Reviewed by Jon Honeycutt.
1941
1942         * BuildSlaveSupport/build.webkit.org-config/config.json: Added 5 more
1943         Windows slaves and distributed them among the three different Test
1944         builders.
1945
1946 2010-11-19  Kinuko Yasuda  <kinuko@chromium.org>
1947
1948         Reviewed by Ojan Vafai.
1949
1950         [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
1951         https://bugs.webkit.org/show_bug.cgi?id=49702
1952
1953         Re-landing r72357 with a test fix.
1954
1955         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1956         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1957         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1958
1959 2010-11-19  Avi Drissman  <avi@google.com>
1960
1961         Reviewed by Antonio Gomes.
1962
1963         Complete support for Unix editing mode
1964         https://bugs.webkit.org/show_bug.cgi?id=49757
1965
1966         * DumpRenderTree/LayoutTestController.cpp:
1967         (setEditingBehaviorCallback):
1968         * DumpRenderTree/chromium/LayoutTestController.cpp:
1969         (LayoutTestController::setEditingBehavior):
1970
1971 2010-11-19  Adam Roben  <aroben@apple.com>
1972
1973         Fix run-javascriptcore-tests when there's a space in the path to
1974         testapi
1975
1976         Reviewed by Sam Weinig.
1977
1978         * Scripts/run-javascriptcore-tests: Use an indirect object when calling
1979         system() to force it to interpret spaces in the path correctly.
1980
1981 2010-11-19  Adam Roben  <aroben@apple.com>
1982
1983         Update scripts for .exe name changes after r72327
1984
1985         As of r72327, the "_debug" suffix is only used in Debug_All builds.
1986
1987         Reviewed by Sam Weinig.
1988
1989         * Scripts/run-javascriptcore-tests:
1990         (testapiPath):
1991
1992         * Scripts/sunspider-compare-results:
1993         (pathToBuiltJSC):
1994
1995         * Scripts/webkitdirs.pm:
1996         (jscPath):
1997         (safariPath):
1998
1999 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
2000
2001         Reviewed by Darin Adler.
2002
2003         Normalize Cairo/CFLite project/solution configuration names
2004         https://bugs.webkit.org/show_bug.cgi?id=49818
2005
2006         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2007         * DumpRenderTree/win/DumpRenderTree.vcproj:
2008         * DumpRenderTree/win/ImageDiff.vcproj:
2009         * MiniBrowser/MiniBrowser.vcproj:
2010         * TestWebKitAPI/win/TestWebKitAPI.sln:
2011         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2012         * WebKitAPITest/WebKitAPITest.vcproj:
2013         * WebKitTestRunner/win/InjectedBundle.vcproj:
2014         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2015         * WinLauncher/WinLauncher.vcproj:
2016         * Scripts/webkitdirs.pm: Updated cairo build configs.
2017
2018 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
2019
2020         Reviewed by Adam Roben.
2021
2022         Windows vcproj configuration names should be normalized across projects
2023         https://bugs.webkit.org/show_bug.cgi?id=49776
2024
2025         * DumpRenderTree/DumpRenderTree.sln:
2026         * FindSafari/FindSafari.vcproj:
2027         * TestWebKitAPI/win/TestWebKitAPI.sln:
2028         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
2029         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added.
2030         * WebKitAPITest/WebKitAPITest.vcproj:
2031         * WebKitAPITest/WebKitAPITestCommon.vsprops:
2032         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
2033         * WebKitTestRunner/WebKitTestRunner.sln:
2034         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
2035         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added.
2036         * record-memory-win/record-memory-win.vcproj:
2037
2038 2010-11-18  Gavin Barraclough  <barraclough@apple.com>
2039
2040         Build fix - as per DRT-mac, always enabled developer extras,
2041         in win/qt/gtk DRT.
2042
2043         This is necessary to enable rich exception messages to be generated
2044         following https://bugs.webkit.org/show_bug.cgi?id=49708.
2045
2046         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2047         (shouldEnableDeveloperExtras):
2048         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2049         (WebCore::shouldEnableDeveloperExtras):
2050         * DumpRenderTree/win/DumpRenderTree.cpp:
2051         (shouldEnableDeveloperExtras):
2052
2053 2010-11-18  Sheriff Bot  <webkit.review.bot@gmail.com>
2054
2055         Unreviewed, rolling out r72357.
2056         http://trac.webkit.org/changeset/72357
2057         https://bugs.webkit.org/show_bug.cgi?id=49784
2058
2059         It broke test-webkitpy tests since the patch didn't have the
2060         corresponding test update (Requested by kinuko on #webkit).
2061
2062         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2063         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2064
2065 2010-11-18  Mihai Parparita  <mihaip@chromium.org>
2066
2067         Reviewed by Tony Chang.
2068
2069         Rebaseline server: add rebaseline queue
2070         https://bugs.webkit.org/show_bug.cgi?id=49763
2071         
2072         Add a UI queue (a multi-item <select>) where tests to be baselined
2073         can be enqueued (also supports basic removal). A queue is used instead
2074         of immediately doing rebaselines since SCM operations can take a while.
2075         It's better to go through lots of tests quickly to mark them as
2076         needing rebaselining and then batch the SCM operations.
2077         
2078         Also adds a simple log where results can be displayed.
2079
2080         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
2081         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2082         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2083         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js: Added.
2084         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
2085         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2086
2087 2010-11-18  Gavin Barraclough  <barraclough@apple.com>
2088
2089         Reviewed by Oliver Hunt.
2090
2091         Bug 49708 - Stop recompiling functions to regenerate exception info.
2092
2093         Instead only hold info as necessary – keep divot info is the inspector
2094         is enabled, line number info is debugging or profiling, and handler
2095         info for functions with try/catch.
2096
2097         * DumpRenderTree/mac/DumpRenderTree.mm:
2098         (shouldEnableDeveloperExtras):
2099             - always enable the developer tools from DRT, to ensure we
2100               produce rich error messages on JavaScript exceptions.
2101
2102 2010-11-18  Kinuko Yasuda  <kinuko@chromium.org>
2103
2104         Reviewed by Ojan Vafai.
2105
2106         [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
2107         https://bugs.webkit.org/show_bug.cgi?id=49702
2108
2109         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2110         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2111
2112 2010-11-18  Dirk Pranke  <dpranke@chromium.org>
2113
2114         Reviewed by Tony Chang.
2115
2116         new-run-webkit-tests: create first part of 'message_broker' class for multiprocessing fixes
2117
2118         Create the first version of the 'message_broker' package. This
2119         class will encapsulate all of the threading/multiprocessing and
2120         message-sending details for the communication between the
2121         'manager' object and the 'worker' objects. For the moment, it
2122         just holds some routines and tests for logging thread stacks.
2123
2124         There should be no functional changes in this patch, just moving stuff
2125         around.
2126
2127         https://bugs.webkit.org/show_bug.cgi?id=49707
2128
2129         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2130         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Removed.
2131         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Added.
2132         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: Added.
2133         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2134         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2135
2136 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
2137
2138         Reviewed by Adam Roben.
2139
2140         Remove leftover Windows Debug_Internal configurations
2141         https://bugs.webkit.org/show_bug.cgi?id=49758
2142
2143         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2144         * DumpRenderTree/win/DumpRenderTree.vcproj:
2145         * DumpRenderTree/win/ImageDiff.vcproj:
2146         * MiniBrowser/MiniBrowser.vcproj:
2147         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2148         * WebKitAPITest/WebKitAPITest.vcproj:
2149         * WebKitTestRunner/win/InjectedBundle.vcproj:
2150         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2151         * WinLauncher/WinLauncher.vcproj:
2152
2153 2010-11-18  Adam Roben  <aroben@apple.com>
2154
2155         Add three new Windows XP build slaves
2156
2157         Reviewed by Steve Falkenburg.
2158
2159         * BuildSlaveSupport/build.webkit.org-config/config.json: Added three
2160         new slaves, and added them to the Windows XP Debug (Tests) builder.
2161
2162 2010-11-18  Daniel Bates  <dbates@rim.com>
2163
2164         Reviewed by Adam Roben.
2165
2166         update-webkit-support-libs should fall back to existing
2167         WebKitSupportLibrary version if there is no internet connectivity
2168         https://bugs.webkit.org/show_bug.cgi?id=49503
2169
2170         Fall back to existing support libraries (if present) when there is
2171         no internet connection.
2172
2173         Currently, update-webkit-support-libs dies with an "out-of-date"
2174         error when there is no internet connection because it cannot
2175         retrieve versioning information from developer.apple.com. Because
2176         update-webkit-support-libs fails, build-webkit fails. Instead,
2177         if there is no internet connection and the support libraries are
2178         present then we should warn the user and exit() with success so
2179         that build-webkit can work without an internet connection.
2180
2181         * Scripts/update-webkit-support-libs:
2182
2183 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
2184
2185         Reviewed by Adam Roben.
2186
2187         Debug_Internal Windows configuration is unnecessary, should be removed
2188         https://bugs.webkit.org/show_bug.cgi?id=49753
2189
2190         * DumpRenderTree/win/DumpRenderTree.cpp:
2191         * MiniBrowser/win/stdafx.h:
2192         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2193         * WebKitTestRunner/win/TestControllerWin.cpp:
2194
2195 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
2196
2197         Reviewed by Adam Roben.
2198
2199         Clean up vcproj errors
2200         https://bugs.webkit.org/show_bug.cgi?id=49741
2201
2202         * MiniBrowser/MiniBrowser.vcproj:
2203         * WebKitAPITest/WebKitAPITest.vcproj:
2204         * WebKitTestRunner/win/InjectedBundle.vcproj:
2205         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2206
2207 2010-11-18  Hayato Ito  <hayato@chromium.org>
2208
2209         Reviewed by Shinichiro Hamaji.
2210
2211         [NRWT] Fix a break of '--new-baseline' feature in pixel_test
2212         which is caused by r72249.
2213
2214         https://bugs.webkit.org/show_bug.cgi?id=49751
2215
2216         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2217
2218 2010-11-18  Adam Roben  <aroben@apple.com>
2219
2220         Implement layoutTestController.waitForPolicyDelegate on Windows
2221
2222         Fixes <http://webkit.org/b/25038> <rdar://problem/6790213>.
2223
2224         Reviewed by Simon Fraser.
2225
2226         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2227         (LayoutTestController::waitForPolicyDelegate): Implemented by porting
2228         code from LayoutTestControllerMac.mm.
2229
2230 2010-11-18  Hayato Ito  <hayato@chromium.org>
2231
2232         Reviewed by Shinichiro Hamaji.
2233
2234         [NRWT] Fix a break of '--new-baseline' feature which is caused by r72249.
2235
2236         https://bugs.webkit.org/show_bug.cgi?id=49740
2237
2238         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2239
2240 2010-11-18  Tony Chang  <tony@chromium.org>
2241
2242         Reviewed by Adam Barth.
2243
2244         run platform/chromium/plugins/refcount-leaks.html on all platforms
2245         https://bugs.webkit.org/show_bug.cgi?id=49485
2246
2247         Add PluginObject.testObjectCount which returns the number of allocated
2248         TestObjects. Add PluginObject.testCreateTestObject which allocates
2249         and returns a TestObject.
2250
2251         Add TestObject.refCount which returns the number of refs on the
2252         TestObject.
2253
2254         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2255         (pluginGetProperty):
2256         (pluginInvoke):
2257         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
2258         (getTestObjectCount):
2259         (testAllocate):
2260         (testDeallocate):
2261         (testGetProperty):
2262         (testScriptObjectInvoke): Release a ref to a plugin object that was
2263             previously leaked.
2264         * DumpRenderTree/TestNetscapePlugIn/TestObject.h:
2265
2266 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
2267
2268         Reviewed by Adam Roben.
2269
2270         WebKitTools projects (WebKitTestRunner, record-memory-win) should use vsprops for common build settings
2271         https://bugs.webkit.org/show_bug.cgi?id=49711
2272
2273         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added.
2274         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added.
2275         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added.
2276         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2277         * record-memory-win/record-memory-win-common.vsprops: Added.
2278         * record-memory-win/record-memory-win.vcproj:
2279
2280 2010-11-18  Andras Becsi  <abecsi@inf.u-szeged.hu>
2281
2282         Reviewed by Csaba Osztrogonác.
2283
2284         [Qt][WK2] Only add user agent strings to the list which aren't listed yet.
2285
2286         * MiniBrowser/qt/BrowserWindow.cpp:
2287         (BrowserWindow::updateUserAgentList):
2288
2289 2010-11-17  Adam Roben  <aroben@apple.com>
2290
2291         Don't trigger Windows builds when chromium-win test results change
2292
2293         Reviewed by Mark Rowe.
2294
2295         * Scripts/webkitpy/common/config/build.py:
2296         (_should_file_trigger_build): Changed the regular expression used to
2297         search for directory names to only consider full directory names,
2298         rather than matching directory names where the string we care about is
2299         a suffix of the name.
2300
2301         * Scripts/webkitpy/common/config/build_unittest.py:
2302         (ShouldBuildTest): Added a test.
2303
2304 2010-11-17  Hayato Ito  <hayato@chromium.org>
2305
2306         Reviewed by Shinichiro Hamaji.
2307
2308         Remove a uri member from TestInput class.
2309
2310         https://bugs.webkit.org/show_bug.cgi?id=49691
2311
2312         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2313         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2314
2315 2010-11-17  Adam Roben  <aroben@apple.com>
2316
2317         Move FindSafari's settings into a vsprops file
2318
2319         Fixes <http://webkit.org/b/49699> FindSafari should use a vsprops file
2320
2321         Reviewed by Steve Falkenburg.
2322
2323         * FindSafari/FindSafari.vcproj:
2324         * FindSafari/FindSafariCommon.vsprops: Added.
2325
2326 2010-11-17  Adam Roben  <aroben@apple.com>
2327
2328         Use a minimum font size of 0 in DRT on Windows
2329
2330         This is the Windows equivalent of r72164.
2331
2332         Rubber-stamped by Dave Hyatt.
2333
2334         * DumpRenderTree/win/DumpRenderTree.cpp:
2335         (resetDefaultsToConsistentValues):
2336
2337 2010-11-17  Dirk Pranke  <dpranke@chromium.org>
2338
2339         Reviewed by Andreas Kling.
2340
2341         webkit-patch pretty-diff shouldn't need to be run from a checkout root in git
2342         https://bugs.webkit.org/show_bug.cgi?id=49639
2343
2344         * Scripts/webkitpy/common/checkout/scm.py:
2345
2346 2010-11-17  Mihai Parparita  <mihaip@chromium.org>
2347
2348         Reviewed by Tony Chang.
2349
2350         Rebaseline server: add loupe for image diffs
2351         https://bugs.webkit.org/show_bug.cgi?id=49692
2352         
2353         Add a loupe (magnifiying glass) for inspecting image diffs. Shows an
2354         enlarged area of the expected, actual and diff images side by side.
2355
2356         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
2357         * Scripts/webkitpy/tool/commands/data/rebaselineserver/loupe.js: Added.
2358         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2359         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2360
2361 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
2362
2363         Reviewed by Adam Roben.
2364
2365         WebKitLauncherWin should use vsprops for shared build settings
2366         https://bugs.webkit.org/show_bug.cgi?id=49696
2367
2368         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
2369         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added.
2370
2371 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
2372
2373         Reviewed by Adam Roben.
2374
2375         WinLauncher should use vsprops for shared build settings
2376         https://bugs.webkit.org/show_bug.cgi?id=49695
2377
2378         * WinLauncher/WinLauncher.cpp:
2379         (_tWinMain):
2380         (PrintView):
2381         (WndProc):
2382         (MyEditProc):
2383         * WinLauncher/WinLauncher.vcproj:
2384         * WinLauncher/WinLauncherCommon.vsprops: Added.
2385
2386 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
2387
2388         Delete unused file unintentionally added in last change.
2389
2390         * DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Removed.
2391
2392 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
2393
2394         Reviewed by Adam Roben.
2395
2396         DumpRenderTree on Windows should use a vsprops file for shared project settings
2397         https://bugs.webkit.org/show_bug.cgi?id=49690
2398
2399         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2400         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added.
2401         * DumpRenderTree/win/DumpRenderTree.vcproj:
2402         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added.
2403         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added.
2404         * DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Added.
2405         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added.
2406         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added.
2407         * DumpRenderTree/win/ImageDiff.vcproj:
2408         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added.
2409
2410 2010-11-17  Hayato Ito  <hayato@chromium.org>
2411
2412         Refactor TestTypeBase.compare_output().
2413
2414         Introduce a TestOutput class and update compare_output() of each test
2415         types so that they can take both actual and expected TestOutput objects.
2416
2417         https://bugs.webkit.org/show_bug.cgi?id=49431
2418
2419         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2420         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Added.
2421         * Scripts/webkitpy/layout_tests/port/base.py:
2422         * Scripts/webkitpy/layout_tests/port/chromium.py:
2423         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2424         * Scripts/webkitpy/layout_tests/port/test.py:
2425         * Scripts/webkitpy/layout_tests/port/webkit.py:
2426         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2427         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2428         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2429         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2430
2431 2010-11-17  Adam Roben  <aroben@apple.com>
2432
2433         Make each Windows Test builder use the same OS for all its slaves
2434
2435         Currently each WebKit1 Windows Test builder has one Windows XP slave
2436         and one Windows 7 slave. Having different OSes in a single builder
2437         meant that the builders would alternate between red and green when
2438         there were OS-specific failures.
2439
2440         Fixes <http://webkit.org/b/49688> Windows Test builders alternate
2441         between red and green because of multiple OS versions
2442
2443         Reviewed by Mark Rowe.
2444
2445         * BuildSlaveSupport/build.webkit.org-config/config.json: Renamed
2446         "Windows Release (Tests)" to "Windows 7 Release (Tests)", "Windows
2447         Debug (Tests)" to "Windows XP Debug (Tests)", and "Windows Release
2448         (WebKit2 Tests)" to "Windows 7 Release (WebKit2 Tests)". Updated the
2449         builders for the two WebKit1 builders so that they would all use the
2450         appropriate OS.
2451
2452 2010-11-17  James Robinson  <jamesr@chromium.org>
2453
2454         Reviewed by Dan Bernstein.
2455
2456         [chromium] Set minimum font size to 0 for DRT
2457         https://bugs.webkit.org/show_bug.cgi?id=49677
2458
2459         Followup for http://trac.webkit.org/changeset/72141.
2460
2461         Test: http/tests/misc/acid3.html
2462
2463         * DumpRenderTree/chromium/WebPreferences.cpp:
2464         (WebPreferences::reset):
2465
2466 2010-11-17  Andras Becsi  <abecsi@webkit.org>
2467
2468         Unreviewed build fix.
2469
2470         [Qt] Add missing file I forgot in r72220.
2471
2472         * MiniBrowser/MiniBrowser.qrc: Added.
2473
2474 2010-11-17  Andras Becsi  <abecsi@webkit.org>
2475
2476         Reviewed by Andreas Kling.
2477
2478         [Qt][WK2] Make it possible to set custom user agent strings in MiniBrowser.
2479         https://bugs.webkit.org/show_bug.cgi?id=49627
2480
2481         Add a user agent dialog and a resource file for useragentlist.txt to MiniBrowser.
2482
2483         * MiniBrowser/MiniBrowser.qrc: Added.
2484         Add it here to prevent qmake from detecting it
2485         since it needs to be copied to the build directory.
2486         * MiniBrowser/qt/BrowserWindow.cpp:
2487         (BrowserWindow::BrowserWindow):
2488         (BrowserWindow::updateUserAgentList):
2489         (BrowserWindow::showUserAgentDialog):
2490         * MiniBrowser/qt/BrowserWindow.h:
2491         * MiniBrowser/qt/MiniBrowser.pro:
2492
2493 2010-11-17  Adam Roben  <aroben@apple.com>
2494
2495         Make changes to the Mac WebKit2 Skipped file trigger Windows builds
2496
2497         We use that file on Windows!
2498
2499         Fixes <http://webkit.org/b/49643> Changes to
2500         LayoutTests/platform/mac-wk2 should trigger a Windows build, but don't
2501
2502         Reviewed by Steve Falkenburg.
2503
2504         * Scripts/webkitpy/common/config/build.py:
2505         (_should_file_trigger_build): Added the mac-wk2 directory and make it
2506         trigger builds on SnowLeopard and Windows.
2507
2508         * Scripts/webkitpy/common/config/build_unittest.py:
2509         (ShouldBuildTest.test_should_build): Added a test.
2510
2511 2010-11-17  Satish Sampath  <satish@chromium.org>
2512
2513         Reviewed by Jeremy Orlow.
2514
2515         Clear the speech input mock explicitly before each test.
2516         https://bugs.webkit.org/show_bug.cgi?id=49660
2517
2518         * DumpRenderTree/chromium/LayoutTestController.cpp:
2519         (LayoutTestController::setMockSpeechInputResult):
2520         * DumpRenderTree/chromium/LayoutTestController.h:
2521         * DumpRenderTree/chromium/WebViewHost.cpp:
2522         (WebViewHost::speechInputController):
2523         (WebViewHost::reset): Invoke speech input mock's clearResults method.
2524         * DumpRenderTree/chromium/WebViewHost.h:
2525         (WebViewHost::speechInputControllerMock): Moved mock from LayoutTestController.
2526
2527 2010-11-17  Alexander Pavlov  <apavlov@chromium.org>
2528
2529         Unreviewed, specify IRC nickname in committers.py.
2530
2531         * Scripts/webkitpy/common/config/committers.py:
2532
2533 2010-11-17  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2534
2535         Reviewed by Tony Chang.
2536
2537         [NRWT] Make http locking similar to perl implementation
2538         https://bugs.webkit.org/show_bug.cgi?id=49187
2539
2540         * Scripts/webkitpy/common/system/file_lock.py: Added.
2541         * Scripts/webkitpy/common/system/file_lock_unittest.py: Added.
2542         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2543
2544 2010-11-17  MORITA Hajime  <morrita@google.com>
2545
2546         Reviewed by Kent Tamura.
2547
2548         [Chromium][DRT] EventSender.contextClick() should aware spellchecking
2549         https://bugs.webkit.org/show_bug.cgi?id=49366
2550
2551         - EvenSender: Checked WebContextMenuData.misspelledWord and added extra context menu entries
2552           according to the spellchecker suggestion
2553         - MockSpellCheck: add fillSuggestionList to provide fake suggestions.
2554
2555         test_expectations.txt will be changed after this change is ported to test_shell.
2556         
2557         * DumpRenderTree/chromium/EventSender.cpp:
2558         (makeMenuItemStringsFor):
2559         (EventSender::contextClick):
2560         * DumpRenderTree/chromium/MockSpellCheck.cpp:
2561         (MockSpellCheck::fillSuggestionList):
2562         (MockSpellCheck::initializeIfNeeded):
2563         * DumpRenderTree/chromium/MockSpellCheck.h:
2564         * DumpRenderTree/chromium/WebViewHost.cpp:
2565         (WebViewHost::mockSpellCheck):
2566         * DumpRenderTree/chromium/WebViewHost.h:
2567
2568 2010-11-16  Dave Hyatt  <hyatt@apple.com>
2569
2570         Reviewed by Sam Weinig.
2571
2572         Make sure the pref for minimum font size is just explicitly set to 0 every time,
2573         since the bots have 1 stuck in their plist otherwise.
2574
2575         * DumpRenderTree/mac/DumpRenderTree.mm:
2576         (resetDefaultsToConsistentValues):
2577
2578 2010-11-16  Mihai Parparita  <mihaip@chromium.org>
2579
2580         Reviewed by Tony Chang.
2581
2582         Rebaseline server: compute diffs client-side
2583         https://bugs.webkit.org/show_bug.cgi?id=49640
2584         
2585         The image diff output from the DRT is pretty bad on some ports (at
2586         least the Mac one), so it's better to compute diffs on the client by
2587         using <canvas>.
2588
2589         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
2590         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2591         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2592
2593 2010-11-16  Mihai Parparita  <mihaip@chromium.org>
2594
2595         Reviewed by Tony Chang.
2596
2597         Rebaseline server: display test results
2598         https://bugs.webkit.org/show_bug.cgi?id=49626
2599         
2600         Adds basic result display to the rebaseline server. On the Python side
2601         this involves:
2602         - Parsing the unexpected_results.json into a dictionary.
2603         - Serving it as JSON under /results.json.
2604         (the JSON -> dict -> JSON transform isn't strictly necessary right now,
2605         but I'll need to have access to the parsed results on the Python side
2606         for follow-up changes).
2607         
2608         On the web UI side this adds:
2609         - Markup for display image and text results (expected, actual, diff),
2610           and JS for populating it.
2611         - Markup for breaking down test results by failure type and directory,
2612           and JS for populating it.
2613
2614         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
2615         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2616         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2617         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js: Added.
2618         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2619
2620 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
2621
2622         Reviewed by Ojan Vafai.
2623
2624         See Chromium issue http://codereview.chromium.org/5133001/ - we
2625         are modifying the build bots to pass in the builder name with
2626         the "GPU" string appended instead of appending it in the code.
2627
2628         https://bugs.webkit.org/show_bug.cgi?id=49636
2629
2630         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2631
2632 2010-11-16  Steve Falkenburg  <sfalken@apple.com>
2633
2634         Reviewed by Adam Roben.
2635
2636         Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
2637         https://bugs.webkit.org/show_bug.cgi?id=49632
2638
2639         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2640         * DumpRenderTree/win/DumpRenderTree.vcproj:
2641         * DumpRenderTree/win/ImageDiff.vcproj:
2642         * MiniBrowser/MiniBrowser.vcproj:
2643         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2644         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
2645         * WebKitTestRunner/win/InjectedBundle.vcproj:
2646         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2647         * WinLauncher/WinLauncher.vcproj:
2648         * record-memory-win/record-memory-win.vcproj:
2649
2650 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
2651
2652         Reviewed by Ojan Vafai.
2653
2654         new-run-webkit-tests: rename TestInfo to TestInput, move image hash to work thread
2655
2656         Rename the TestInfo class to TestInput to be clearer about its
2657         function, and move the checksum-reading code into dump_render_tree_thread
2658         to avoid cross-thread access.
2659
2660         https://bugs.webkit.org/show_bug.cgi?id=49573
2661
2662         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2663         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2664         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2665
2666 2010-11-16  Dave Hyatt  <hyatt@apple.com>
2667
2668         Fix bustage. Remove the minimum font size pref setting in DumpRenderTree.
2669
2670         * DumpRenderTree/mac/DumpRenderTree.mm:
2671         (resetDefaultsToConsistentValues):
2672
2673 2010-11-16  Stephanie Lewis  <slewis@apple.com>
2674
2675         Reviewed by Geoff Garen.
2676
2677         <rdar://problem/8624267> Leak creating offscreen webview running fast/dom tests
2678
2679         Use shared DeviceOrientationProviderMock. The old allocation method created a new WebDeviceOrientationProviderMock 
2680         for every WebView, and the WebKit API doesn't support that ownership model.
2681
2682         I also fixed a leak in setMockDeviceOrientation by adding a missing release.
2683
2684         * DumpRenderTree/mac/DumpRenderTree.mm:
2685         (createWebViewAndOffscreenWindow):
2686         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2687         (LayoutTestController::setMockDeviceOrientation):
2688
2689 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
2690
2691         Reviewed by Ojan Vafai.
2692
2693         new-run-webkit-tests: log the process id in --verbose mode
2694
2695         As part of the switch to multi-process mode, we should log the
2696         process id when running w/ --verbose.
2697
2698         https://bugs.webkit.org/show_bug.cgi?id=49571
2699
2700         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2701
2702 2010-11-16  Adam Roben  <aroben@apple.com>
2703
2704         Only trigger Windows builds when files that we actually use on Windows
2705         are changed
2706
2707         A new Scheduler subclass, PlatformSpecificScheduler, has been added.
2708         It uses the new webkitpy.common.config.build module to determine
2709         whether a particular change should trigger a build on a particular
2710         platform. The Windows builders have been switched to use a
2711         PlatformSpecificScheduler.
2712
2713         The logic to determine whether or not a particular change should
2714         trigger a build on a given platform has only been implemented/tested
2715         for Windows. I tried to make it easy to add more platforms in the
2716         future, but I don't have enough familiarity with all platforms to be
2717         able to implement it for them.
2718
2719         Fixes <http://webkit.org/b/49407> Windows builders kick off builds for
2720         lots irrelevant changes (e.g., rebaselining Chromium test results)
2721
2722         Reviewed by Eric Seidel.
2723
2724         * BuildSlaveSupport/build.webkit.org-config/config.json: Use a
2725         PlatformSpecificScheduler for the Windows builders.
2726
2727         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2728         (PlatformSpecificScheduler.__init__): Added. Stores our platform, sets
2729         up a ChangeFilter that filters to our branch and will call through to
2730         our filter method, and calls up to our base class.
2731         (PlatformSpecificScheduler.filter): Calls through to
2732         build.should_build to find out whether we should trigger a build for
2733         this change.
2734
2735         * Scripts/webkitpy/common/net/build.py: Added.
2736         (_should_file_trigger_build): Uses a set of directories and regexp
2737         patterns to determine whether the given file should trigger a build on
2738         the given platform. As mentioned earlier, this has only been
2739         implemented for Windows, though I did try to make some guesses about
2740         other platforms.
2741         (should_build): Returns true if any of the files should trigger a
2742         build on the given platform.
2743
2744         * Scripts/webkitpy/common/net/build_unittest.py: Added.
2745         (ShouldBuildTest.test_should_build): Does some basic testing to make
2746         sure we're triggering builds for the right files. It only tests
2747         Windows for now, though I tried to make some guesses about other
2748         platforms.
2749
2750 2010-11-16  Simon Hausmann  <simon.hausmann@nokia.com>
2751
2752         Reviewed by Andreas Kling.
2753
2754         [Qt] Remove synchronous QWebPage::checkPermissions signal
2755         https://bugs.webkit.org/show_bug.cgi?id=46810
2756
2757         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2758         (WebCore::WebPage::WebPage):
2759         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2760         (LayoutTestController::grantDesktopNotificationPermission): When granting
2761         permission, grant it directly on the QWebPage/Frame, that will remember it.
2762         * QtTestBrowser/webpage.cpp:
2763         (WebPage::WebPage):
2764         * QtTestBrowser/webpage.h:
2765
2766
2767 2010-11-16  Andras Becsi  <abecsi@inf.u-szeged.hu>
2768
2769         Reviewed by Csaba Osztrogonác.
2770
2771         [Qt] Add isPrinting and setPrinting methods to DRT's LayoutTestController.
2772
2773         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2774         (LayoutTestController::reset):
2775         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2776         (LayoutTestController::isPrinting):
2777         (LayoutTestController::setPrinting):
2778
2779 2010-11-16  Balazs Kelemen  <kbalazs@webkit.org>
2780
2781         Reviewed by Andreas Kling.
2782
2783         [Qt][WK2] Add a way to turn on tiled backing store in MiniBrowser
2784         https://bugs.webkit.org/show_bug.cgi?id=49587
2785
2786         * MiniBrowser/qt/BrowserView.cpp:
2787         (BrowserView::BrowserView): Added BackingStoreType
2788         argument to ctor. Propagating it to the QGraphicsWKView.
2789         * MiniBrowser/qt/BrowserView.h:
2790         * MiniBrowser/qt/BrowserWindow.cpp:
2791         (BrowserWindow::BrowserWindow):
2792         (BrowserWindow::newWindow): Create the new BrowserWindow
2793         with the same BackingStoreType that this instance has.
2794         * MiniBrowser/qt/BrowserWindow.h: Added BackingStoreType member.
2795         * MiniBrowser/qt/main.cpp:
2796         (main): Use tiled backing store if got -tiled command line argument.
2797         Avoid redundant copy of command line args.
2798
2799 2010-11-16  John Knottenbelt  <jknotten@chromium.org>
2800
2801         Reviewed by Jeremy Orlow.
2802
2803         Move DeviceOrientationClientMock from LayoutTestController to WebViewHost.
2804         https://bugs.webkit.org/show_bug.cgi?id=48506
2805
2806         This ensures that there is one mock per page WebView / WebViewHost. This is a
2807         design constraint of the DeviceOrientationClientMock because the m_controller
2808         field can only store a pointer to a single instance of the corresponding
2809         DeviceOrientationController.
2810
2811         Test: fast/dom/DeviceOrientation/no-page-cache.html
2812
2813         * DumpRenderTree/chromium/LayoutTestController.cpp:
2814         (LayoutTestController::setMockDeviceOrientation):
2815         (LayoutTestController::deviceOrientationClientMock):
2816         * DumpRenderTree/chromium/LayoutTestController.h:
2817         * DumpRenderTree/chromium/WebViewHost.cpp:
2818         (WebViewHost::deviceOrientationClientMock):
2819         (WebViewHost::deviceOrientationClient):
2820         (WebViewHost::reset):
2821         * DumpRenderTree/chromium/WebViewHost.h:
2822
2823 2010-11-15  Andras Becsi  <abecsi@webkit.org>
2824
2825         Reviewed by Andreas Kling.
2826
2827         [Qt][WK2] Avoid polling in WebKitTestRunner.
2828         https://bugs.webkit.org/show_bug.cgi?id=49542
2829
2830         Make the WK2 testing session about 10-15% faster and decrease random flakiness
2831         resulting from timing skew by removing the millisecond polling from TestControllerQt.
2832
2833         * WebKitTestRunner/TestController.cpp:
2834         (WTR::TestController::didFinishLoadForFrame):
2835         * WebKitTestRunner/TestController.h:
2836         * WebKitTestRunner/TestInvocation.cpp:
2837         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2838         * WebKitTestRunner/mac/TestControllerMac.mm:
2839         (WTR::TestController::notifyDone): Add method stub.
2840         * WebKitTestRunner/qt/TestControllerQt.cpp:
2841         (WTR::TestControllerRunLoop::instance):
2842         (WTR::TestControllerRunLoop::start):
2843         (WTR::TestControllerRunLoop::stop):
2844         (WTR::TestControllerRunLoop::TestControllerRunLoop):
2845         (WTR::TestControllerRunLoop::timerEvent):
2846         (WTR::TestController::notifyDone):
2847         (WTR::TestController::platformRunUntil):
2848         * WebKitTestRunner/win/TestControllerWin.cpp:
2849         (WTR::TestController::notifyDone): Add method stub.
2850
2851 2010-11-15  Darin Adler  <darin@apple.com>
2852
2853         * Scripts/webkitpy/common/net/bugzilla: Added property svn:ignore.
2854
2855 2010-11-15  Benjamin Poulain  <benjamin.poulain@nokia.com>
2856
2857         Reviewed by Andreas Kling.
2858
2859         [Qt] [WK2] Add Ctrl+L shortcut to Qt Minibrowser
2860         https://bugs.webkit.org/show_bug.cgi?id=49544
2861
2862         Add the shortcut to BrowserWindow.
2863
2864         * MiniBrowser/qt/BrowserWindow.cpp:
2865         (BrowserWindow::BrowserWindow):
2866         (BrowserWindow::openLocation):
2867         * MiniBrowser/qt/BrowserWindow.h:
2868
2869 2010-11-14  David Levin  <levin@chromium.org>
2870
2871         Reviewed by Daniel Bates.
2872
2873         check-webkit-style should detect PassRefPtr usage in functions.
2874         https://bugs.webkit.org/show_bug.cgi?id=49513
2875
2876         * Scripts/webkitpy/style/checkers/cpp.py:
2877         (check_for_function_lengths): Revert a comment change that I
2878          accidentally made in r71986.
2879         (check_pass_ptr_usage): Added the code to do the check.
2880         (process_line): Added the call to check_pass_ptr_usage.
2881         (CppChecker): Added the new error category.
2882         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2883         (CppStyleTestBase::perform_pass_ptr_check): Runs the new check for
2884          testing purposes.
2885         (PassPtrTest::*): The class/functions to unit test the new
2886          functionality.
2887
2888 2010-11-14  David Levin  <levin@chromium.org>
2889
2890         Reviewed by Shinichiro Hamaji.
2891
2892         check-webkit-style function detection and the line count style checks should be separate.
2893         https://bugs.webkit.org/show_bug.cgi?id=49512
2894
2895         * Scripts/webkitpy/style/checkers/cpp.py: Do the separation.
2896         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Adjust the test to
2897           call the detection function and fix line counts in two places now that
2898           the code really only counts the lines in the body of the function.
2899
2900 2010-11-14  Andreas Kling  <kling@webkit.org>
2901
2902         Reviewed by Antonio Gomes.
2903
2904         http/tests/plugins tests print "Unhandled variable" to stderr under Qt
2905         https://bugs.webkit.org/show_bug.cgi?id=33438
2906
2907         Stifle "Unhandled variable" warning to match what the other
2908         TestNetscapePlugin does (NPP_GetValue in TestNetscapePlugIn/main.cpp
2909         simply returns NPERR_GENERIC_ERROR for unhandled variables.)
2910
2911         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2912         (webkit_test_plugin_get_value):
2913
2914 2010-11-13  David Levin  <levin@chromium.org>
2915
2916         Reviewed by Eric Seidel.
2917
2918         check-webkit-style function detection crashes on functions in templates.
2919         https://bugs.webkit.org/show_bug.cgi?id=49504
2920
2921         For example "template <bool shouldClose(const Element*)>".
2922
2923         * Scripts/webkitpy/style/checkers/cpp.py: If not function is detected, bail out.
2924         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Modified the complex
2925           function detection test to expose this issue.
2926
2927 2010-11-12  David Levin  <levin@chromium.org>
2928
2929         Reviewed by Shinichiro Hamaji.
2930
2931         check-webkit-style function detection doesn't detect indented functions declaractions.
2932         https://bugs.webkit.org/show_bug.cgi?id=49446
2933
2934         Indented function declarations occur inside class definitions, so
2935         they are a pretty common (and worth detecting).
2936
2937         * Scripts/webkitpy/style/checkers/cpp.py:
2938           Changed regex to allow indentation.
2939           Changed the function start detection to only happen when not in a
2940           function.
2941           Changed function end detection to work based on matching braces
2942           instead of finding a close brace at the beginning of the line.
2943           Fixed close_expression to do what it says when it doesn't find
2944           the close.
2945         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Indented function test.
2946
2947 2010-11-12  Daniel Bates  <dbates@rim.com>
2948
2949         Rubber-stamped by Nikolas Zimmermann.
2950
2951         Make do-file-rename rename files in the directory WebKit2.
2952
2953         This also makes the list of searched directories in do-file-rename
2954         consistent with the list of searched directories in the script do-webcore-rename.
2955
2956         * Scripts/do-file-rename:
2957
2958 2010-11-12  Dirk Pranke  <dpranke@chromium.org>
2959
2960         Reviewed by James Robinson.
2961
2962         Attempt yet again to land the fix for bug 49360 (respecting
2963         set-webkit-configuration). We need to handle the cases where
2964         trying to run webkit-build-directory to find out where the
2965         default configuration might be fails (that shows up on some
2966         Chromium bots that apparently don't have perl installed).
2967
2968         https://bugs.webkit.org/show_bug.cgi?id=49360
2969
2970         * Scripts/webkitpy/layout_tests/port/config.py:
2971         * Scripts/webkitpy/layout_tests/port/config_standalone.py: Added.
2972         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2973
2974 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
2975
2976         Reviewed by Adam Barth.
2977
2978         webkit-patch land logs commit message twice
2979         https://bugs.webkit.org/show_bug.cgi?id=49482
2980         
2981         Don't log the comment that's used by bugzilla.close_bug_as_fixed, since
2982         that's just the commit message, which we now output following the
2983         actual commit.
2984
2985         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2986
2987 2010-11-12  Tony Chang  <tony@chromium.org>
2988
2989         Reviewed by Adam Barth.
2990
2991         run platform/chromium/plugins/script-object-invoke.html on all platforms
2992         https://bugs.webkit.org/show_bug.cgi?id=49280
2993
2994         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2995         (testScriptObjectInvoke):
2996         (pluginInvoke):
2997
2998 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
2999
3000         Reviewed by Adam Barth.
3001
3002         webkit-patch land-cowboy (and other commands) should display the committed SVN revision after landing a patch
3003         https://bugs.webkit.org/show_bug.cgi?id=49471
3004
3005         Right now there's no indication of a successful commit.
3006         
3007         * Scripts/webkitpy/tool/commands/download_unittest.py:
3008         * Scripts/webkitpy/tool/steps/commit.py:
3009
3010 2010-11-12  Kinuko Yasuda  <kinuko@chromium.org>
3011
3012         Reviewed by Ojan Vafai.
3013
3014         Include detailed test modifiers in results.json and enable incremental uploading for non-layout tests
3015         https://bugs.webkit.org/show_bug.cgi?id=49354
3016
3017         Also moved/integrated the upload method from run_webkit_tests.py to json_results_generator.py.
3018
3019         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3020         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3021         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3022         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3023
3024 2010-11-12  Tony Chang  <tony@chromium.org>
3025
3026         Reviewed by Kent Tamura.
3027
3028         [chromium] Load a blank page when closing DRT WebViewHosts
3029         https://bugs.webkit.org/show_bug.cgi?id=49417
3030
3031         In test_shell, when we close a window, we first load about:blank
3032         and run GC to fire the destruction logic of the page.  In test_shell,
3033         this happens in ~TestShell.  In DRT, we manage virtual windows as
3034         WebViewHosts, so we need to replicate this logic in ~WebViewHost.
3035
3036         Managing focus is a bit trickier, since normally you would get window
3037         events to reset the focus to the right window.  We do it manually
3038         instead.
3039
3040         This fixes 2 plugin tests on DRT.
3041
3042         * DumpRenderTree/chromium/TestShell.cpp:
3043         (TestShell::~TestShell): Move window close logic to ~WebViewHost.
3044         (TestShell::closeWindow): Move widget close() to WVH destructor and
3045             manage focus manually.
3046         (TestShell::closeRemainingWindows): Comment typo.
3047         * DumpRenderTree/chromium/WebViewHost.cpp:
3048         (WebViewHost::closeWidget):
3049         (invokeCloseWidget):
3050         (WebViewHost::closeWidgetSoon): Close the window asynchronously (matches
3051             test_shell).
3052         (WebViewHost::~WebViewHost):
3053         * DumpRenderTree/chromium/WebViewHost.h:
3054
3055 2010-11-12  David Levin  <levin@chromium.org>
3056
3057         Reviewed by Adam Barth.
3058
3059         cpp.py needs some tidying.
3060         https://bugs.webkit.org/show_bug.cgi?id=49443
3061
3062         * Scripts/webkitpy/style/checkers/cpp.py:
3063           Fix parameter ordering for iteratively_replace_matches_with_char
3064           to mirror other similar functions (and improved comments, etc.)
3065           Also, use a python-ism (for/else) to get rid of a variable that
3066           was there to determine if something had been found in the loop.
3067
3068 2010-11-12  Robert Kroeger  <rjkroege@chromium.org>
3069
3070         Reviewed by James Robinson.
3071
3072         [Chromium/DRT] Make EventSendingController send complete touch events.
3073         https://bugs.webkit.org/show_bug.cgi?id=49285
3074
3075         * DumpRenderTree/chromium/EventSender.cpp:
3076         (EventSender::addTouchPoint):
3077         (EventSender::updateTouchPoint):
3078         (EventSender::sendCurrentTouchEvent):
3079
3080 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
3081
3082         Unreviewed rollout of r71858.
3083
3084         Rollout out r71858 since it breaks new-run-webkit-httpd as used by the
3085         NaCl tests.
3086
3087         * Scripts/webkitpy/layout_tests/port/config.py:
3088         * Scripts/webkitpy/layout_tests/port/config_standalone.py: Removed.
3089         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3090
3091 2010-11-12  Benjamin Poulain  <benjamin.poulain@nokia.com>
3092
3093         Reviewed by Kenneth Rohde Christiansen.
3094
3095         [Qt] TestController::runUntil doesn't honor the timeout parameter
3096         https://bugs.webkit.org/show_bug.cgi?id=48941
3097
3098         Implement the missing timeout of WebKitTestRunner for Qt.
3099
3100         A QElapsedTimer has been added to RunUntilConditionLoop in order
3101         to measure how long the loop has been running. When the timer
3102         is bigger or equal than the timeout, the loop ends even if the
3103         condition is not met.
3104
3105         * WebKitTestRunner/qt/TestControllerQt.cpp:
3106         (WTR::RunUntilConditionLoop::start):
3107         (WTR::RunUntilConditionLoop::run):
3108         (WTR::RunUntilConditionLoop::timerEvent):
3109         (WTR::TestController::platformRunUntil):
3110
3111 2010-11-11  David Levin  <levin@chromium.org>
3112
3113         Reviewed by Shinichiro Hamaji.
3114
3115         check-webkit-style function detection doesn't handle templates with spaces.
3116         https://bugs.webkit.org/show_bug.cgi?id=49427
3117
3118         * Scripts/webkitpy/style/checkers/cpp.py: Stripped out templates when
3119           finding the function name.
3120         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Made the test have a
3121           template with a space.
3122
3123 2010-11-11  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
3124
3125         Reviewed by Shinichiro Hamaji.
3126
3127         Enable check-webkit-style on Qt files
3128         https://bugs.webkit.org/show_bug.cgi?id=48322
3129
3130         Adding exception for _q_... private slots and
3131         ..._data() methods in tests
3132
3133         * Scripts/webkitpy/style/checker.py: enable Qt dirs, add exceptions
3134         * Scripts/webkitpy/style/checker_unittest.py: improve unittests
3135
3136 2010-11-11  David Levin  <levin@chromium.org>
3137
3138         Reviewed by Shinichiro Hamaji.
3139
3140         check-webkit-style function detection doesn't work for templates and destructors.
3141         https://bugs.webkit.org/show_bug.cgi?id=49425
3142
3143         * Scripts/webkitpy/style/checkers/cpp.py: Changed regex for templates and destructors.
3144         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Made the test hit this issue.
3145
3146 2010-11-11  Joone Hur  <joone@kldp.org>
3147
3148         Reviewed by Antonio Gomes.
3149
3150         [GTK][DRT] Implement LayoutTestController::nodesFromRect
3151         https://bugs.webkit.org/show_bug.cgi?id=46598
3152
3153         Support nodesFromRect in DRT
3154
3155         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3156         (LayoutTestController::nodesFromRect):
3157
3158 2010-11-11  MORITA Hajime  <morrita@google.com>
3159
3160         Reviewed by Kent Tamura.
3161
3162         editing/selection/context-menu-on-text.html fails on chromium
3163         https://bugs.webkit.org/show_bug.cgi?id=45898
3164
3165         Enhance Chromium's EventSender::contextClick() to return
3166         array of menu strings. The implementation incomplete because
3167         Although actual context menu is implemented by the browser,
3168         it reflects editability of underlying context thus makes
3169         context-menu-on-text.html passed.
3170         
3171         * DumpRenderTree/chromium/EventSender.cpp:
3172         (makeMenuItemStringsFor): Added.
3173         (EventSender::contextClick): Now returns array of menu strings.
3174         * DumpRenderTree/chromium/WebViewHost.cpp:
3175         (WebViewHost::showContextMenu): Now storing given WebContextMenuData object.
3176         (WebViewHost::clearContextMenuData): Added.
3177         (WebViewHost::lastContextMenuData): Added.
3178         * DumpRenderTree/chromium/WebViewHost.h:
3179
3180 2010-11-11  Dirk Pranke  <dpranke@chromium.org>
3181
3182         Unreviewed, build fix.
3183
3184         fix build breakage caused by fix for bug 49380 (r71858).
3185
3186         config_standalone needs to ensure that the packages it needs are
3187         in sys.path.
3188
3189         https://bugs.webkit.org/show_bug.cgi?id=49419
3190
3191         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
3192
3193 2010-11-11  Dirk Pranke  <dpranke@chromium.org>
3194
3195         Reviewed by Adam Roben.
3196
3197         Fix NRWT to respect set-webkit-configuration again :(
3198
3199         This change fixes a typo in config.py that was causing the wrong
3200         value to be read initially and us never actually looking into
3201         the filesystem to get the default configuration.
3202         
3203         * Scripts/webkitpy/layout_tests/port/config.py:
3204         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
3205         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3206
3207 2010-11-11  Eric Seidel  <eric@webkit.org>
3208
3209         Reviewed by Adam Barth.
3210
3211         Split out Bug, Attachment and CommitterValidator from bugzilla.py
3212         https://bugs.webkit.org/show_bug.cgi?id=49403
3213
3214         CommitterValidator really had nothing to do with bugzilla.py.
3215         I've put it next to committers.py for now since its rather tied to that file.
3216
3217         * Scripts/webkitpy/common/config/committervalidator.py: Added.
3218         * Scripts/webkitpy/common/config/committervalidator_unittest.py: Added.
3219         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
3220         * Scripts/webkitpy/common/net/bugzilla/attachment.py: Added.
3221         * Scripts/webkitpy/common/net/bugzilla/bug.py: Added.
3222         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py: Added.
3223         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3224         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3225         * Scripts/webkitpy/tool/bot/feeders.py:
3226         * Scripts/webkitpy/tool/commands/queues.py:
3227
3228 2010-11-11  Dirk Pranke  <dpranke@chromium.org>
3229
3230         Reviewed by Eric Seidel.
3231
3232         fix missing 'pid' argument for http lockfile checking on win32
3233         https://bugs.webkit.org/show_bug.cgi?id=49363
3234
3235         * Scripts/webkitpy/common/system/executive.py:
3236
3237 2010-11-11  Eric Seidel  <eric@webkit.org>
3238
3239         Rubber-stamped by Adam Barth.
3240
3241         Move bugzilla.py into its own module in preparation for splitting one-file-per-class
3242         https://bugs.webkit.org/show_bug.cgi?id=49402
3243
3244         * Scripts/webkitpy/common/net/bugzilla/__init__.py: Added.
3245         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/bugzilla.py.
3246         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/bugzilla_unittest.py.
3247
3248 2010-11-10  Chris Guillory  <chris.guillory@google.com>
3249
3250         Reviewed by Chris Fleizach.
3251
3252         Use IAccessibleComparable to compare accessibility objects.
3253         https://bugs.webkit.org/show_bug.cgi?id=49118
3254
3255         * DumpRenderTree/AccessibilityUIElement.cpp:
3256         (AccessibilityUIElement::isEqual):
3257         * DumpRenderTree/AccessibilityUIElement.h:
3258         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3259         (comparableObject):
3260         (AccessibilityUIElement::isEqual):
3261
3262 2010-11-10  Csaba Osztrogonác  <ossy@webkit.org>
3263
3264         Reviewed by David Hyatt.
3265
3266         HTML5 Ruby support should be mandatory feature
3267         https://bugs.webkit.org/show_bug.cgi?id=49272
3268
3269         Remove Ruby as optional feature.
3270
3271         * Scripts/build-webkit:
3272
3273 2010-11-10  Adam Roben  <aroben@apple.com>
3274
3275         Print VC++ Express build logs in the same order that the projects are
3276         built
3277
3278         Fixes <http://webkit.org/b/49326> print-vse-failure-logs prints logs
3279         in an unhelpful order
3280
3281         Reviewed by Eric Seidel.
3282
3283         * Scripts/print-vse-failure-logs:
3284         (PrintVisualStudioExpressLogs._build_order): Added. Uses
3285         print-msvc-project-dependencies to figure out the order in which
3286         projects are built.
3287         (PrintVisualStudioExpressLogs._sort_buildlogs): Added. Sorts the logs
3288         based on their build order and project name.
3289         (PrintVisualStudioExpressLogs._obj_directory): Moved code to find the
3290         scripts directory from here...
3291         (PrintVisualStudioExpressLogs._scripts_directory): ...to here.
3292         (PrintVisualStudioExpressLogs.main): Sort the logs before printing
3293         them.
3294
3295 2010-11-10  Adam Roben  <aroben@apple.com>
3296
3297         Only print the interesting text from VC++ Express build logs
3298
3299         Fixes <http://webkit.org/b/49325> It's hard to find the interesting
3300         output from print-vse-failure-logs
3301
3302         Reviewed by Eric Seidel.
3303
3304         * Scripts/print-vse-failure-logs: Removed unnecessary os.path import,
3305         added newly-required imports. Removed a comment that was essentially a
3306         FIXME, and is now fixed.
3307         (PrintVisualStudioExpressLogs._relevant_text): Added. Uses
3308         BeautifulSoup to extract the relevant text from the build log.
3309         (PrintVisualStudioExpressLogs.main): Only print the relevant text.
3310
3311 2010-11-09  Mihai Parparita  <mihaip@chromium.org>
3312
3313         Reviewed by Tony Chang.
3314
3315         [Chromium] http/tests/security/XFrameOptions fail with Chromium DRT
3316         https://bugs.webkit.org/show_bug.cgi?id=49286
3317         
3318         The tests in http/tests/security/XFrameOptions started to fail after
3319         r71297, since it changed the WebViewHost::assignIdentifierToRequest
3320         logic to always assign identifiers to requests, even if we're not going
3321         to be dumping resource load callbacks at that point. These tests
3322         only call LayoutTestController.dumpResourceLoadCallbacks after the
3323         request is started, thus their expectations have "<unknown>" as the
3324         identifier. Change WebViewHost to the previous behavior, which also
3325         match the other ports'.
3326
3327         * DumpRenderTree/chromium/WebViewHost.cpp:
3328         (WebViewHost::assignIdentifierToRequest):
3329         (WebViewHost::removeIdentifierForRequest):
3330
3331 2010-11-08  Tony Chang  <tony@chromium.org>
3332
3333         Reviewed by Adam Barth.
3334
3335         run platform/chromium/plugins/return-npobject.html on all platforms
3336         https://bugs.webkit.org/show_bug.cgi?id=49103
3337
3338         This tests that we can get an NPObject returned through a method on
3339         an NPAPI Object.
3340
3341         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3342         (testCallbackReturn):
3343         (pluginInvoke):
3344
3345 2010-11-09  Sheriff Bot  <webkit.review.bot@gmail.com>
3346
3347         Unreviewed, rolling out r71672.
3348         http://trac.webkit.org/changeset/71672
3349         https://bugs.webkit.org/show_bug.cgi?id=49276
3350
3351         It doesn't work on Chromium Windows bot (Requested by Ossy on
3352         #webkit).
3353
3354         * Scripts/webkitpy/common/system/file_lock.py: Removed.
3355         * Scripts/webkitpy/common/system/file_lock_unittest.py: Removed.
3356         * Scripts/webkitpy/layout_tests/port/http_lock.py:
3357
3358 2010-11-09  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3359
3360         Reviewed by Tony Chang.
3361
3362         [NRWT] Make http locking similar to perl implementation
3363         https://bugs.webkit.org/show_bug.cgi?id=49187
3364
3365         * Scripts/webkitpy/common/system/file_lock.py: Added.
3366         * Scripts/webkitpy/common/system/file_lock_unittest.py: Added.
3367         * Scripts/webkitpy/layout_tests/port/http_lock.py:
3368
3369 2010-11-09  James Kozianski  <koz@chromium.org>
3370
3371         Reviewed by Eric Seidel.
3372
3373         Clean up imports for webkit-patch.
3374         https://bugs.webkit.org/show_bug.cgi?id=49083
3375
3376         Move some imports from commands into main.py where they are used.
3377         Move command imports into the __init__ of the commands module.
3378
3379         * Scripts/webkitpy/tool/commands/__init__.py:
3380         * Scripts/webkitpy/tool/commands/download.py:
3381         * Scripts/webkitpy/tool/commands/queues.py:
3382         * Scripts/webkitpy/tool/main.py:
3383
3384 2010-11-09  Yi Shen  <yi.4.shen@nokia.com>
3385
3386         Reviewed by Andreas Kling.
3387
3388         [Qt][QtTestBrowser] Don't erase incorrect url in the Url Bar
3389         https://bugs.webkit.org/show_bug.cgi?id=49047
3390
3391         * QtTestBrowser/mainwindow.cpp:
3392         (MainWindow::setAddressUrl):
3393
3394 2010-11-09  Andras Becsi  <abecsi@webkit.org>
3395
3396         Reviewed by Csaba Osztrogonác.
3397
3398         Improve old-run-webkit-tests --verbose to show DumpTool opening/closing
3399         https://bugs.webkit.org/show_bug.cgi?id=49252
3400
3401         * Scripts/old-run-webkit-tests:
3402
3403 2010-11-09  Csaba Osztrogonác  <ossy@webkit.org>
3404
3405         Reviewed by Tor Arne Vestbø.
3406
3407         Output of old-run-webkit-tests is buggy in verbose mode
3408         https://bugs.webkit.org/show_bug.cgi?id=49249
3409
3410         * Scripts/old-run-webkit-tests: Redundant outputs removed.
3411
3412 2010-11-08  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
3413
3414         Reviewed by Martin Robinson.
3415
3416         [GTK] Link with target name set does not work
3417         https://bugs.webkit.org/show_bug.cgi?id=48865
3418
3419         When a new page is created with a name (target=myFrame), the new
3420         mainFrame could not be found because they where not stored in the
3421         same PageGroup. As PageGroup are not exposed externally so the
3422         simpliest solution is to use a global page group name. This also fixes
3423         issue with visited link coloration across pages. After this change the
3424         private function webkit_web_view_set_group_name() was no longer used
3425         so it was removed completly.
3426
3427         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3428         (createWebView):
3429
3430 2010-11-08  John Knottenbelt  <jknotten@chromium.org>
3431
3432         Reviewed by Kent Tamura.
3433
3434         WebViewHost::reset() uses placement new.
3435         https://bugs.webkit.org/show_bug.cgi?id=49069
3436
3437         WebViewHost is using placement destruction / new to simulate a fresh
3438         WebViewHost object at the same address. This is because the WebView remains
3439         open across tests and maintains a pointer to the WebViewHost.
3440         This change resets member variables explictly instead of the placement new dance.
3441
3442         * DumpRenderTree/chromium/WebViewHost.cpp:
3443         (WebViewHost::WebViewHost):
3444         (WebViewHost::reset):
3445
3446 2010-11-08  Dirk Pranke <dpranke@chromium.org>
3447
3448         Reviewed by Eric Seidel.
3449
3450         Fix the webkit_base_dir logic in webkitpy/layout_tests/port/config.py. 
3451         It turns out that NRWT can't use the code in scm.find_checkout_root()
3452         because the Chromium bots don't do full checkouts of the WebKit
3453         tree; they only check out subdirectories like WebKitTools/Scripts.
3454         Until we can figure out a better approach for this, I've
3455         restored the base_dir-detecting code from NRWT, which works in
3456         any directory tree, scm or no.
3457
3458         This also restores the files modified in r71475 and r71474.
3459
3460         https://bugs.webkit.org/show_bug.cgi?id=49151
3461
3462         * WebKitTools/Scripts/webkitpy/layout_tests/port/config.py
3463         * WebKitTools/Scripts/webkitpy/layout_tests/port/config_unittest.py
3464
3465 2010-11-08  Eric Seidel  <eric@webkit.org>
3466
3467         Reviewed by Adam Barth.
3468
3469         webkit-patch failure-reason explodes if a build is missing
3470         https://bugs.webkit.org/show_bug.cgi?id=49195
3471
3472         This is likely a recent regression.  Adding a unit test for this case.
3473
3474         * Scripts/webkitpy/common/net/buildbot.py:
3475         * Scripts/webkitpy/common/net/buildbot_unittest.py:
3476
3477 2010-11-08  Dan Bernstein  <mitz@apple.com>
3478
3479         Reviewed by Darin Adler.
3480
3481         Ignore the system scrollbar setting.
3482
3483         * DumpRenderTree/mac/DumpRenderTree.mm:
3484         (resetDefaultsToConsistentValues): Set the scrollbar default.
3485
3486 2010-11-05  Adam Roben  <aroben@apple.com>
3487
3488         Make webkitpy.common.system.executive_unittest pass when running under
3489         Win32 Python
3490
3491         Fixes <http://webkit.org/b/49033>.
3492
3493         Reviewed by Dave Levin and Eric Seidel.
3494
3495         * Scripts/webkitpy/common/system/executive.py:
3496         (Executive._run_command_with_teed_output): Pass the arguments through
3497         encode_argument_if_needed rather than using Cygwin-specific code here.
3498         (Executive.run_and_throw_if_fail): Use child_process_encoding to decode
3499         the output.
3500         (Executive.run_command): Use encode_argument_if_needed to encode the
3501         arguments and child_process_encoding to decode the output.
3502         (Executive._child_process_encoding): Returns the encoding that should be
3503         used when communicating with child processes. On Windows we use mbcs,
3504         which maps to the current code page. On all other platforms we use
3505         UTF-8.
3506         (Executive._should_encode_child_process_arguments): Returns True if
3507         arguments to child processes need to be encoded. This is currently
3508         only needed on Cygwin and Win32 Python 2.x.
3509         (Executive._encode_argument_if_needed): Encode the argument using
3510         child_process_encoding if we need to encode arguments to child
3511         processes on this platform.
3512
3513         * Scripts/webkitpy/common/system/executive_unittest.py:
3514         (never_ending_command): Added. Returns arguments to run a command that
3515         will not quit until we kill it. On Windows we use wmic, on other
3516         platforms we use yes.
3517         (ExecutiveTest.test_run_command_with_unicode): Changed to expect the
3518         mbcs encoding to be used and for output from the child processes to
3519         have been roundtripped through encode/decode on Win32 Python. When
3520         UTF-8 is the encoding the roundtripping is undetectable, but with mbcs
3521         it's possible that some characters will not be able to be converted
3522         and will be replaced by question marks; the round-tripping allows us
3523         to expect this result.
3524
3525         (ExecutiveTest.test_kill_process):
3526         (ExecutiveTest.test_kill_all):
3527         Use never_ending_command instead of invoking "yes" directly. Expect an
3528         exit code of 1 when using Win32 Python, as that's what seems to happen.
3529
3530 2010-11-08  Adam Roben  <aroben@apple.com>
3531
3532         Roll out r71532
3533
3534         It broke the build for Cygwin 1.7 installs. Cygwin 1.7's default
3535         .bashrc unsets %TEMP%, which broke copy-tools.cmd.
3536
3537         * Scripts/webkitdirs.pm:
3538
3539 2010-11-08  Tony Chang  <tony@chromium.org>
3540
3541         Reviewed by Adam Barth.
3542
3543         run platform/chromium/plugins/nested-plugin-objects.html on all platforms
3544         https://bugs.webkit.org/show_bug.cgi?id=49094
3545
3546         This tests that objects created by plugins are proplery cleaned up.
3547
3548         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3549         (testPassTestObject):
3550         (pluginInvoke):
3551         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
3552         (testAllocate):
3553         (testDeallocate):
3554         (testGetProperty):
3555         (testConstruct):
3556
3557 2010-11-08  Adam Roben  <aroben@apple.com>
3558
3559         Mark Windows builds triggered from Perl as being non-interactive
3560
3561         This affects whether some of our scripts will show alerts vs. printing
3562         to the build log.
3563
3564         Fixes <http://webkit.org/b/49181> Windows build fail mysteriously when
3565         .vsprops files are updated
3566
3567         Reviewed by Steve Falkenburg.
3568
3569         * Scripts/webkitdirs.pm:
3570         (buildVisualStudioProject): Set WEBKIT_NONINTERACTIVE_BUILD to 1.
3571
3572 2010-11-08  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3573
3574         Reviewed by Ojan Vafai.
3575
3576         Make http locking default in NRWT.
3577         https://bugs.webkit.org/show_bug.cgi?id=48053
3578
3579         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3580         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3581
3582 2010-11-08  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3583
3584         Reviewed by Csaba Osztrogonác.
3585
3586         [NRWT] If the http lock fails we shouldn't do any locking
3587         https://bugs.webkit.org/show_bug.cgi?id=49164
3588
3589         If something goes wrong with the locking, the test should keep going.
3590
3591         * Scripts/webkitpy/layout_tests/port/http_lock.py:
3592
3593 2010-11-08  Adam Roben  <aroben@apple.com>
3594
3595         Switch back to using kCGImageAlphaPremultipliedFirst when generating
3596         pixel dumps on Windows
3597
3598         I changed this behavior in r71418 thinking that it was required for
3599         getting plugins to show up in pixel dumps. But it doesn't seem to be
3600         necessary, and was making it impossible to compare new Windows pixel
3601         dumps with existing Windows or Mac pixel dumps (because ImageDiff won't
3602         compare an image with alpha to an image without alpha).
3603
3604         Fixes <http://webkit.org/b/49172> REGRESION (r71418): Can't compare
3605         new Windows pixel results to existing Windows or Mac results
3606
3607         Reviewed by Antti Koivisto.
3608
3609         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3610         (createBitmapContextFromWebView): Replaced kCGImageAlphaNoneSkipFirst
3611         with kCGImageAlphaPremultipliedFirst.
3612
3613 2010-11-08  Csaba Osztrogonac  <ossy@webkit.org>
3614
3615         Unreviewed, rolling out r71466.
3616         http://trac.webkit.org/changeset/71466
3617         https://bugs.webkit.org/show_bug.cgi?id=48865
3618
3619         It broke layout tests on GTK bots.
3620
3621         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3622         (createWebView):
3623
3624 2010-11-08  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3625
3626         Reviewed by Csaba Osztrogonác.
3627
3628         Enable running of Qt API tests on BuildBot
3629         https://bugs.webkit.org/show_bug.cgi?id=49004
3630
3631         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3632
3633 2010-11-08  Eric Seidel  <eric@webkit.org>
3634
3635         Reviewed by Adam Barth.
3636
3637         Add clean-review-queue command to remove closed bugs from the webkit.org/pending-review
3638         https://bugs.webkit.org/show_bug.cgi?id=49160
3639
3640         Bugzilla doesn't automatically remove r? when a bug gets closed.
3641         This script takes care of that for webkit.org.
3642
3643         * Scripts/webkitpy/common/net/bugzilla.py:
3644         * Scripts/webkitpy/tool/commands/upload.py:
3645
3646 2010-11-07  Fumitoshi Ukai  <ukai@chromium.org>
3647
3648         Unreviewed, rolling out r71474.
3649         http://trac.webkit.org/changeset/71474
3650         https://bugs.webkit.org/show_bug.cgi?id=48280
3651
3652         breaks chromium webkit tests
3653         https://bugs.webkit.org/show_bug.cgi?id=49151
3654
3655         * Scripts/webkitpy/layout_tests/port/base.py:
3656         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3657         * Scripts/webkitpy/layout_tests/port/config.py:
3658         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3659         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3660         * Scripts/webkitpy/layout_tests/port/webkit.py:
3661         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3662         * Scripts/webkitpy/tool/mocktool.py:
3663
3664 2010-11-07  Fumitoshi Ukai  <ukai@chromium.org>
3665
3666         Unreviewed, rolling out r71475.
3667         http://trac.webkit.org/changeset/71475
3668  
3669         breaks chromium webkit tests
3670         https://bugs.webkit.org/show_bug.cgi?id=49151
3671
3672         * Scripts/webkitpy/common/newstringio.py: Removed.
3673         * Scripts/webkitpy/common/newstringio_unittest.py: Removed.
3674         * Scripts/webkitpy/common/system/executive_mock.py: Removed.
3675         * Scripts/webkitpy/common/system/filesystem_mock.py: Removed.
3676         * Scripts/webkitpy/layout_tests/port/config_mock.py: Removed.
3677
3678 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
3679
3680         Unreviewed, build fix.
3681
3682         Add files inexplicably not committed in r71474 as part of the
3683         fix for bug 48280.
3684
3685         * Scripts/webkitpy/common/newstringio.py: Added.
3686         * Scripts/webkitpy/common/newstringio_unittest.py: Added.
3687         * Scripts/webkitpy/common/system/executive_mock.py: Added.
3688         * Scripts/webkitpy/common/system/filesystem_mock.py: Added.
3689         * Scripts/webkitpy/layout_tests/port/config_mock.py: Added.
3690
3691 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
3692
3693         Reviewed by Eric Siedel.
3694
3695         new-run-webkit-tests: update port/base and port/webkit to use the
3696         new FileSystem and Config abstractions, pulling more logic out of
3697         the base Port classes into separate, mockable objects.
3698
3699         Also create a MockFileSystem object, a MockConfig object, move
3700         MockExecutive into common/system to be next to executive, and
3701         update the config object to use a FileSystem.
3702
3703         https://bugs.webkit.org/show_bug.cgi?id=48280
3704
3705         * Scripts/webkitpy/common/newstringio.py: Added.
3706         * Scripts/webkitpy/common/newstringio_unittest.py: Added.
3707         * Scripts/webkitpy/common/system/executive_mock.py: Added.
3708         * Scripts/webkitpy/common/system/filesystem_mock.py: Added.
3709         * Scripts/webkitpy/layout_tests/port/base.py:
3710         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3711         * Scripts/webkitpy/layout_tests/port/config.py:
3712         * Scripts/webkitpy/layout_tests/port/config_mock.py:
3713         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3714         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3715         * Scripts/webkitpy/layout_tests/port/webkit.py:
3716         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3717         * Scripts/webkitpy/tool/mocktool.py:
3718
3719 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
3720
3721         Unreviewed, build breakage.
3722
3723         Apparently I uploaded the wrong version of the file to fix 49122
3724         and neither Eric or I noticed - it was missing a dirname() call.
3725         Fixing ...
3726
3727         https://bugs.webkit.org/show_bug.cgi?id=49122
3728
3729         * Scripts/webkitpy/common/checkout/scm.py:
3730
3731 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
3732
3733         Reviewed by Eric Seidel.
3734
3735         webkitpy/tool/* unittests change cwd and don't clean up properly
3736
3737         https://bugs.webkit.org/show_bug.cgi?id=49122
3738
3739         * Scripts/webkitpy/common/checkout/scm.py:
3740
3741 2010-11-05  Chris Marrin  <cmarrin@apple.com>
3742
3743         Reviewed by Simon Fraser.
3744
3745         suspendAnimations/resumeAnimations not present in WebKit2
3746         https://bugs.webkit.org/show_bug.cgi?id=49109
3747
3748         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3749         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3750         (WTR::LayoutTestController::suspendAnimations):
3751         (WTR::LayoutTestController::resumeAnimations):
3752         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3753
3754 2010-11-05  Tony Chang  <tony@chromium.org>
3755
3756         Reviewed by David Levin.
3757
3758         cleanup style in TestNetscapePlugIn/PluginObject.cpp
3759         https://bugs.webkit.org/show_bug.cgi?id=49044
3760
3761         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3762         (getPluginClass):
3763         (pluginGetProperty):
3764         (pluginSetProperty):
3765         (variantToIdentifier):
3766         (testCallback):
3767         (getURL):
3768         (getURLNotify):
3769         (testInvokeDefault):
3770         (testGetProperty):
3771         (testDocumentOpen):
3772         (testWindowOpen):
3773         (pluginInvoke):
3774         (handleCallback):
3775         (notifyStream):
3776         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
3777
3778 2010-11-05  Eric Seidel  <eric@webkit.org>
3779
3780         Reviewed by David Levin.
3781
3782         Add QueueStatusServer/__init__.py so others can run the QueueStatusServer tests
3783         https://bugs.webkit.org/show_bug.cgi?id=49032
3784
3785         I wrote this file as part of bug 47847, but I forgot to commit it.
3786         No one else noticed it missing because test-webkitpy knows how
3787         to recover in the case where it can't import QueueStatusServer
3788         (which generally occurs due to not having installed the AppEngine SDK).
3789
3790         * QueueStatusServer/__init__.py: Added.
3791         * QueueStatusServer/model/workitems_unittest.py:
3792          - Remove a test which fails.  This was probably landed (by me)
3793            from my other machine, which since this __init__.py was missing
3794            I never noticed the failure and landed this invalid test.
3795            Sadly we can't really test remove_work_item as it depends
3796            on .key() working.  .key() will throw unless the object
3797            has already been saved it seems.
3798            This may be a mis-design in our remove_work_item implementation,
3799            but for now, just removing the test.
3800
3801 2010-11-04  Adam Roben  <aroben@apple.com>
3802
3803         Teach check-webkit-style about TestNetscapePlugIn
3804
3805         Fixes <http://webkit.org/b/49030> check-webkit-style is ignorant of
3806         TestNetscapePlugIn's coding conventions
3807
3808         Reviewed by John Sullivan.
3809
3810         * Scripts/webkitpy/style/checker.py: Lump TestNetscapePlugIn in with
3811         WebKitAPITest and TestWebKitAPI in having different include order and
3812         naming conventions than WebCore. Added some comments about why the
3813         exceptions exist.
3814
3815 2010-11-04  Adam Roben  <aroben@apple.com>
3816
3817         Add a test that shows that windowed plugins are able to paint
3818
3819         Somehow we never had a test for this before.
3820
3821         Fixes <http://webkit.org/b/49029> Should add a test that shows
3822         windowed plugins can paint
3823
3824         Reviewed by Jon Honeycutt.
3825
3826         * DumpRenderTree/TestNetscapePlugIn/Tests/win/DrawsGradient.cpp: Added.
3827         (DrawsGradient::DrawsGradient):
3828         (DrawsGradient::wndProc): We handle the WM_PAINT and WM_PRINTCLIENT messages.
3829
3830         (DrawsGradient::onPaint):
3831         (DrawsGradient::onPrintClient):
3832         These both just call through to paint.
3833
3834         (DrawsGradient::paint): Fills our client area with some gradients.
3835
3836         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Link
3837         against Msimg32.lib for ::GradientFill and added DrawsGradient.
3838
3839         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3840         (createBitmapContextFromWebView): Use WM_PRINT instead of
3841         WM_PRINTCLIENT so that ::DefWindowProc will send
3842         WM_PRINT/WM_PRINTCLIENT messages to the WebView's child windows.
3843         Replaced kCGImageAlphaPremultipledFirst with kCGImageAlphaNoneSkipFirst
3844         because GDI doesn't support alpha and kCGImageBitmapOrder32Little with
3845         kCGImageBitmapOrder32Host because, who knows, maybe someday Windows
3846         will run on a big-endian platform.
3847
3848 2010-11-04  Adam Roben  <aroben@apple.com>
3849
3850         Extract much of NPNInvalidateRectInvalidatesWindow's code into a
3851         WindowedPluginTest base class
3852
3853         The base class takes care of subclassing the plugin's window so that a
3854         custom WNDPROC is called. This will make it easier to write tests that
3855         need to handle window messages.
3856
3857         Fixes <http://webkit.org/b/49028> It's hard to write a PluginTest with
3858         a custom WNDPROC
3859
3860         Reviewed by Jon Honeycutt.
3861
3862         * DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp:
3863         (NPNInvalidateRectInvalidatesWindow::NPNInvalidateRectInvalidatesWindow):
3864         (NPNInvalidateRectInvalidatesWindow::NPP_SetWindow):
3865         (NPNInvalidateRectInvalidatesWindow::wndProc):
3866         (NPNInvalidateRectInvalidatesWindow::testInvalidateRect):
3867         Moved code from here to WindowedPluginTest. Changed to use window()
3868         instead of m_window.
3869
3870         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3871         Added WindowedPluginTest and added TestNetscapePlugIn/win to the
3872         include path. Also reordered the include path to make a little more
3873         sense and simplified the entry that added TestNetscapePlugIn itself to
3874         the include path.
3875
3876         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp: Added.
3877         (WindowedPluginTest::WindowedPluginTest):
3878         (WindowedPluginTest::NPP_SetWindow):
3879         (WindowedPluginTest::staticWndProc):
3880         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.h: Added.
3881         (WindowedPluginTest::window):
3882         Code came from NPNInvalidateRectInvalidatesWindow.
3883
3884 2010-11-04  Adam Roben  <aroben@apple.com>
3885
3886         Add a plugin test to show that windowed plugins are clipped correctly
3887
3888         Fixes <http://webkit.org/b/49024> <rdar://problem/8487847> Windowed
3889         plugins aren't clipped in WebKit2 on Windows
3890
3891         Reviewed by Jon Honeycutt.
3892
3893         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp: Added.
3894         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Initialize members.
3895         (WindowRegionIsSetToClipRect::NPP_SetWindow): Check that our window
3896         region matches the clip rect we know we should have based on
3897         window-region-is-set-to-clip-rect.html, and check that our window class
3898         doesn't have the CS_PARENTDC style.
3899
3900         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3901         Added WindowRegionIsSetToClipRect.
3902
3903 2010-11-05  Alejandro G. Castro  <alex@igalia.com>
3904
3905         Reviewed by Martin Robinson.
3906
3907         [GTK] Avoid font hinting in the DRT
3908         https://bugs.webkit.org/show_bug.cgi?id=48548
3909
3910         Change the settings to avoid font hinting, it was causing
3911         different results depending on the distribution.
3912
3913         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3914         (initializeGtkFontSettings):
3915         * DumpRenderTree/gtk/fonts/fonts.conf:
3916
3917 2010-11-05  Eric Seidel  <eric@webkit.org>
3918
3919         Reviewed by Adam Barth.
3920
3921         build-webkit spams system.log by repeatedly checking for PBXProductDirectory in com.apple.Xcode
3922         https://bugs.webkit.org/show_bug.cgi?id=49051
3923
3924         This is a speculative fix.  The unit tests cover these methods, however
3925         I don't know if this will fully stop the system.log spam.
3926
3927         * Scripts/webkitpy/layout_tests/port/base.py:
3928         * Scripts/webkitpy/layout_tests/port/webkit.py:
3929
3930 2010-11-05  Eric Seidel  <eric@webkit.org>
3931
3932         Reviewed by Adam Barth.
3933
3934         Add basic support for showing bot id on /queue-status/ pages
3935         https://bugs.webkit.org/show_bug.cgi?id=49037
3936
3937         This support is really simple.  Eventually we'll want to
3938         show the bot id in the lock table too, but we don't have
3939         that information stored in the server yet.
3940
3941         * QueueStatusServer/handlers/queuestatus.py:
3942         * QueueStatusServer/handlers/queuestatus_unittest.py: Added.
3943         * QueueStatusServer/templates/includes/singlequeuestatus.html:
3944
3945 2010-11-04  Dirk Pranke  <dpranke@chromium.org>
3946
3947         Reviewed by Adam Barth.
3948
3949         Create a filesystem wrapper that we can use to enforce
3950         particular conventions and use for mocking and dependency
3951         injection down the line.
3952
3953         https://bugs.webkit.org/show_bug.cgi?id=48144
3954
3955         * Scripts/webkitpy/common/system/filesystem.py: Added.
3956         * Scripts/webkitpy/common/system/filesystem_unittest.py: Added.
3957
3958 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
3959
3960         Reviewed by Tony Chang.
3961
3962         run_webkit_tests_unittest fails under Python 2.5
3963         https://bugs.webkit.org/show_bug.cgi?id=49043
3964         
3965         Switch from itertools.chain.from_iterable (which was added in 2.6)
3966         to using itertools.chain directly.
3967
3968         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3969
3970 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
3971
3972         Unreviewed fix to webkit-patch rebaseline-server so that it runs under
3973         Python 2.5 (it needs an import to use the with statement).
3974
3975         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3976
3977 2010-11-04  Dirk Pranke  <dpranke@chromium.org>
3978
3979         Reviewed by Adam Barth.
3980
3981         new-run-webkit-tests: split out webkit-specific configuration stuff into a new module
3982
3983         The current NRWT code has webkit-specific configuration code (like
3984         _script_path, default configuration, etc.) mixed in with
3985         layout-test-specific stuff in port/base. The configuration code
3986         should be split out into a separate module for easier mocking,
3987         testing, and isolation.
3988
3989         https://bugs.webkit.org/show_bug.cgi?id=48264
3990
3991         * Scripts/webkitpy/layout_tests/port/config.py: Added.
3992         * Scripts/webkitpy/layout_tests/port/config_unittest.py: Added.
3993
3994 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
3995
3996         Reviewed by Tony Chang.
3997
3998         Rebaseline server: initial framework
3999         https://bugs.webkit.org/show_bug.cgi?id=48892
4000         
4001         Adds the basic framework for the rebaseline server (details at 
4002         http://webkit.org/b/47761). Includes the rebaseline-server webkit-patch
4003         command, which starts an HTTP server that can serve static files or
4004         invoke handler methods on a class.
4005
4006         * Scripts/webkitpy/tool/commands/__init__.py:
4007         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html: Added.
4008         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css: Added.
4009         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js: Added.
4010         * Scripts/webkitpy/tool/commands/rebaselineserver.py: Added.
4011
4012 2010-11-04  Dirk Pranke  <dpranke@chromium.org>
4013
4014         Reviewed by James Robinson.
4015
4016         new-run-webkit-tests wasn't using DRT by default for
4017         --platform chromium-gpu
4018
4019         The default value was set to False instead of None, which meant
4020         that the platform specific logic wasn't firing to change the
4021         value to True (b/c we were afraid we'd be overriding the user
4022         preference).
4023
4024         https://bugs.webkit.org/show_bug.cgi?id=49038
4025
4026         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4027
4028 2010-11-04  Tony Chang  <tony@chromium.org>
4029
4030         Reviewed by Adam Barth.
4031
4032         make platform/chromium/plugins/multiple-plugins.html pass on all platforms
4033         https://bugs.webkit.org/show_bug.cgi?id=49026
4034
4035         Have the testObject.bar property return the string "bar".  This lets
4036         us run and pass platform/chromium/plugins/multiple-plugins.html on all
4037         platforms.
4038
4039         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
4040         (testGetProperty):
4041
4042 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
4043
4044         Reviewed by Tony Chang.
4045
4046         NRWT doesn't have good test coverage for --run-chunk, --batch-size, --run-part, etc.
4047         https://bugs.webkit.org/show_bug.cgi?id=48878
4048         
4049         Add get_tests_run so that it's easy to see which tests get run (and with
4050         what batching) for a given flag combination. Flesh out the various
4051         test cases that have FIXMEs.
4052         
4053         Also fixes an off-by-one error (batch sizes were one larger than 
4054         expected) and makes --run-part also have wraparound behavior, like
4055         --run-chunk.
4056
4057         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
4058         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4059         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
4060
4061 2010-11-04  Erik Arvidsson  <arv@chromium.org>
4062
4063         Reviewed by Dimitri Glazkov.
4064
4065         Support box-sizing without the vendor prefix
4066         https://bugs.webkit.org/show_bug.cgi?id=36713
4067
4068         Based on patch by Peter Beverloo <peter@lvp-media.com>
4069
4070         * iExploder/htdocs/cssproperties.in: Change -webkit-box-sizing to box-sizing.
4071
4072 2010-11-04  Csaba Osztrogonác  <ossy@webkit.org>
4073
4074         Unreviewed rollout r71340, because it broke Chromium Windows bot.
4075
4076         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
4077         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4078
4079 2010-11-04  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
4080
4081         Reviewed by Ojan Vafai.
4082
4083         Make http locking default in NRWT.
4084         https://bugs.webkit.org/show_bug.cgi?id=48053
4085
4086         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
4087         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4088
4089 2010-11-04  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
4090
4091         Reviewed by Eric Seidel.
4092
4093         [NRWT] Clear invalid http locks on Windows platform as well
4094         https://bugs.webkit.org/show_bug.cgi?id=48515
4095
4096         * Scripts/webkitpy/common/system/executive.py:
4097         * Scripts/webkitpy/common/system/executive_unittest.py:
4098         * Scripts/webkitpy/layout_tests/port/http_lock.py:
4099
4100 2010-11-02  Adam Roben  <aroben@apple.com>
4101
4102         Reduce our dependence on coreutils when running Python tests
4103
4104         This patch introduces versions of the standard echo and cat utilities
4105         implemented in Python. They are probably missing features of their
4106         coreutils equivalents, but they can do what's necessary for our Python
4107         tests. This is useful on Windows, where these utilities typically
4108         aren't available.
4109
4110         Fixes <http://webkit.org/b/48883> executive_unittest relies on echo
4111         and cat utilities from coreutils, which are not present on Windows
4112
4113         Reviewed by Eric Seidel.
4114
4115         * Scripts/webkitpy/common/system/executive_unittest.py: Changed to use
4116         our Python-based echo and cat.
4117
4118         * Scripts/webkitpy/common/system/fileutils.py: Added.
4119         (make_stdout_binary): On Windows, puts sys.stdout into binary mode so
4120         that \n won't be translated into \r\n. I couldn't think of a good way
4121         to test this directly without touching the filesystem, but it is tested
4122         indirectly by echo_unittest.
4123
4124         * Scripts/webkitpy/test/cat.py: Added.
4125         (command_arguments): Returns a list for invoking cat with the given arguments.
4126         (main): Acts like a simplified version of the coreutils cat utility.
4127
4128         * Scripts/webkitpy/test/cat_unittest.py: Added.
4129         (CatTest.assert_cat): Runs cat with the given input and ensures the
4130         output matches the input.
4131         (CatTest.test_basic): Performs a simple test of cat.
4132         (CatTest.test_no_newline): Tests what happens when the input string
4133         doesn't have a trailing newline.
4134         (CatTest.test_unicode): Tests passing a unicode string to cat.
4135         (CatTest.test_as_command): Tests running cat as a separate command.
4136
4137         * Scripts/webkitpy/test/echo.py: Added.
4138         (command_arguments): Returns a list for invoking echo with the given arguments.
4139         (main): Acts like a simplified version of the coreutils echo utility.
4140
4141         * Scripts/webkitpy/test/echo_unittest.py: Added.
4142         (EchoTest.test_basic): Performs a simple test of echo.
4143         (EchoTest.test_no_newline): Tests passing -n to echo to suppress the
4144         trailing newline.
4145         (EchoTest.test_unicode): Tests passing unicode and non-unicode strings
4146         to echo.
4147         (EchoTest.test_argument_order): Tests what happens when -n is not the
4148         first argument.
4149         (EchoTest.test_empty_arguments): Tests what happens when you pass [] to
4150         echo.main.
4151         (EchoTest.test_no_arguments): Tests what happens when you call
4152         echo.main with no arguments.
4153         (EchoTest.test_as_command): Tests running echo as a separate command.
4154
4155 2010-11-04  Renata Hodovan  <reni@inf.u-szeged.hu>
4156
4157         Unreviewed: Add myself to the list of Committers.
4158
4159         * Scripts/webkitpy/common/config/committers.py:
4160
4161 2010-11-04  Andreas Kling  <kling@webkit.org>
4162
4163         Reviewed by Kenneth Rohde Christiansen.
4164
4165         [Qt] Hook into QWebPage::scrollRequested for resizes-to-contents mode
4166
4167         In RTC mode the QGraphicsWebView item is the size of the contents,
4168         scrolling works a bit differently  (we need to react to scrollRequested.)
4169
4170         Normally QGraphicsView will replay the last mouse event when scrolling,
4171         so to prevent WebKit from getting confused by this we temporarily make
4172         the QGraphicsView non-interactive.
4173
4174         * QtTestBrowser/webview.cpp:
4175         (WebViewGraphicsBased::setPage):
4176         (WebViewGraphicsBased::scrollRequested):
4177         * QtTestBrowser/webview.h:
4178
4179 2010-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4180
4181         Reviewed by Andreas Kling.
4182
4183         Use OS(MAC_OS_X) rather than PLATFORM(MAC) in TestControllerQt
4184
4185         PLATFORM(MAC) is not defined for the Qt port, as it refers to
4186         the Mac-port, not the Mac OS X operating system.
4187
4188         * WebKitTestRunner/qt/TestControllerQt.cpp:
4189         (WTR::isExistingLibrary):
4190
4191 2010-11-04  Leonid Ebril  <leonid.ebril@nokia.com>
4192
4193         Reviewed by Andreas Kling.
4194
4195         [Qt] Adding iphone user agent string the user agent list for QtTestBrowser
4196         https://bugs.webkit.org/show_bug.cgi?id=48869
4197
4198         * QtTestBrowser/useragentlist.txt:
4199
4200 2010-11-03  Adam Roben  <aroben@apple.com>
4201
4202         Always use uppercase drive names in strings returned by abspath_to_uri
4203
4204         Some versions of cygpath use lowercase drive letters while others use
4205         uppercase, which makes it hard to test the output of code that uses
4206         cygpath.
4207
4208         Fixes <http://webkit.org/b/48914> webkitpy.common.system.path_unittest
4209         fails with Cygwin 1.5
4210
4211         Reviewed by Eric Seidel.
4212
4213         * Scripts/webkitpy/common/system/path.py:
4214         (cygpath): Updated the docstring to indicate that only absolute paths
4215         should be passed for now (though relative paths will work fine).
4216         (_Cygpath.convert): Upper-case the first letter of the converted Windows path.
4217
4218 2010-11-03  George Guo  <George.Guo@Nokia.com>
4219
4220         Reviewed by Andreas Kling.
4221
4222         [Qt] QtTestBrowser : set mmp rule pageddata in Symbian
4223         https://bugs.webkit.org/show_bug.cgi?id=48767
4224     
4225         Paging is needd on Symbian devices to support benchmarks tests like
4226         dromaeo.com and Celtic Kane that need a lot of memory to run  
4227
4228         * QtTestBrowser/QtTestBrowser.pro:
4229
4230 2010-11-03  Jenn Braithwaite  <jennb@chromium.org>
4231
4232         Reviewed by Dmitry Titov.
4233
4234         Chromium: Update resource tracking when moving a frame between documents
4235         https://bugs.webkit.org/show_bug.cgi?id=48363
4236
42