a00cd0ea50c3d3f0c90bb5c31e0ae920707ad84c
[WebKit-https.git] / WebKitTools / ChangeLog
1 2008-02-04  Darin Adler  <darin@apple.com>
2
3         Reviewed by Geoff.
4
5         * Scripts/make-js-test-wrappers: Look at the whole LayoutTests tree, not just the fast
6         and svg subdirectories. Added some more exceptions for the benefit of the fast/dom
7         subdirectory.
8
9 2008-02-04  Adam Roben  <aroben@apple.com>
10
11         Windows Apple-only build fix
12
13         * DumpRenderTree/win/DumpRenderTree.vcproj: Added a new include
14         directory.
15
16 2008-02-04  Alp Toker  <alp@atoker.com>
17
18         Rubber-stamped by Mark Rowe.
19
20         Remove all trailing whitespace in the GTK+ port and related
21         components.
22
23         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
24         * DumpRenderTree/gtk/GCControllerGtk.cpp:
25         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
26         * GNUmakefile.am:
27
28 2008-02-01  Eric Seidel  <eric@webkit.org>
29
30         Reviewed by Oliver.
31
32         Also search LayoutTests/svg for js-based tests.
33
34         * Scripts/make-js-test-wrappers:
35
36 2008-01-31  Alp Toker  <alp@atoker.com>
37
38         Rubber-stamped by Adam Roben.
39
40         http://bugs.webkit.org/show_bug.cgi?id=17006
41         [GTK] Header path should be webkit/webkit.h
42
43         Move the GTK+ API sources as needed and update the build systems.
44
45         * DumpRenderTree/gtk/DumpRenderTree.cpp:
46         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
47         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
48         * GNUmakefile.am:
49         * GtkLauncher/main.c:
50
51 2008-01-30  Stephanie  <slewis@apple.com>
52
53         Reviewed by Geoff.
54
55         Add an option to run-webkit-tests to merge leaks results and print the number of unique leaks found under a certain call depth.  This should make it easier for the buildbots to track new leaks.
56
57         * Scripts/run-webkit-tests:
58
59 2008-01-30  Alexey Proskuryakov  <ap@webkit.org>
60
61         Reviewed by Adam Roben.
62
63         One more debug (external) fix.
64
65         * DumpRenderTree/win/DumpRenderTree.cpp: TestNetscapePlugin is built with a _debug suffix in both DebugInternal
66         and Debug configurations. 
67
68 2008-01-29  Geoffrey Garen  <ggaren@apple.com>
69
70         Reviewed by Sam Weinig. Sam Weinig.
71         
72         Fixed <rdar://problem/5692566> fast/encoding/mailto-always-utf-8.html
73         fails when run after fast/dom/Window/window-property-shadowing.html (16902)
74
75         Modified our policy delegates not to output window.name. Since a
76         previous test may have explicitly set window.name, we can't rely on its
77         implicit value in test results.
78
79         * DumpRenderTree/mac/PolicyDelegate.mm:
80         (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
81
82         * DumpRenderTree/win/PolicyDelegate.cpp:
83         (PolicyDelegate::decidePolicyForNavigationAction):
84
85 2008-01-29  Mark Rowe  <mrowe@apple.com>
86
87         Reviewed by Tim Hatcher.
88
89         <rdar://problem/5600926> WebCore on Tiger must link to its own copy of SQLite 3.4 or newer (so HTML database behavior will be correct).
90
91         * Scripts/build-webkit: Copy SQLite static library and headers into the build directory.
92
93 2008-01-29  David Kilzer  <ddkilzer@apple.com>
94
95         Refactor ChangeLog path code
96
97         Reviewed by Adam.
98
99         * Scripts/prepare-ChangeLog: Simplify code in one foreach() loop, and extract
100         duplicate code in another foreach() loop.
101
102 2008-01-29  Alexey Proskuryakov  <ap@webkit.org>
103
104         Reviewed by Darin.
105
106         <rdar://problem/5710692> All storage tests fail/crash
107
108         * DumpRenderTree/mac/UIDelegate.mm:
109         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): Set an
110         arbitrary quota of 5 megabytes.
111
112         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
113         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
114         Removed unused (I think) code.
115         
116         * DumpRenderTree/win/UIDelegate.cpp:
117         (UIDelegate::QueryInterface): IWebUIDelegatePrivate3 is now supported.
118         (UIDelegate::webViewPainted): A stub implementation.
119         (UIDelegate::exceededDatabaseQuota): Set an arbitrary quota of 5 megabytes.
120         * DumpRenderTree/win/UIDelegate.h:
121
122 2008-01-27  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
123
124         GTK+ DRT build fix for breakage introduced in r29822.
125
126         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
127         (LayoutTestController::setPersistentUserStyleSheetLocation):
128         (LayoutTestController::clearPersistentUserStyleSheet):
129
130 2008-01-27  Dan Bernstein  <mitz@apple.com>
131
132         Reviewed by Darin Adler.
133
134         - add support for directory prologues and epilogues to run-webkit-tests
135         - allow setting a persistent user style sheet in DumpRenderTree
136         - activate the WebKit Layout Tests font in Windows DumpRenderTree
137
138         * DumpRenderTree/LayoutTestController.cpp:
139         (clearPersistentUserStyleSheetCallback): Added.
140         (setPersistentUserStyleSheetLocationCallback): Added.
141         (LayoutTestController::staticFunctions): Added.
142         clearPersistentUserStyleSheet and setPersistentUserStyleSheet.
143         * DumpRenderTree/LayoutTestController.h:
144         * DumpRenderTree/mac/DumpRenderTree.mm:
145         (setPersistentUserStyleSheetLocation): Added.
146         (resetWebViewToConsistentStateBeforeTesting): Added the user style sheet
147         to the set of things this function resets. Now it either disables the
148         user style sheet or sets it to the persistent user style sheet and
149         enables it.
150         * DumpRenderTree/mac/DumpRenderTreeMac.h:
151         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
152         (LayoutTestController::setPersistentUserStyleSheetLocation): Added.
153         (LayoutTestController::clearPersistentUserStyleSheet): Added.
154         * DumpRenderTree/win/DumpRenderTree.cpp:
155         (setPersistentUserStyleSheetLocation): Added.
156         (initialize): Added the WebKit Layout Tests font to the set of fonts to
157         install.
158         (resetWebViewToConsistentStateBeforeTesting): See DumpRenderTree.mm.
159         * DumpRenderTree/win/DumpRenderTreeWin.h:
160         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
161         (LayoutTestController::setPersistentUserStyleSheetLocation): Added.
162         (LayoutTestController::clearPersistentUserStyleSheet): Added.
163         * Scripts/run-webkit-tests: Changed to look for, and if found process in
164         DumpRenderTree, files named run-webkit-tests-prologue.html and
165         run-webkit-tests-epilogue.html in the resources subdirectory of any
166         test directory and platform test results directory. The prologues are
167         processed before the first test from the directory (and its
168         subdirectories) is run, and the epilogues are processed after the last
169         test from the directory is run. Platform-specific prologues and
170         epilogues are processed in order of specificity.
171
172 2008-01-25  Alexey Proskuryakov  <ap@webkit.org>
173
174         Reviewed by Mark Rowe.
175
176         <rdar://problem/5699933> http/tests/security/cross-frame-access-get.html is still failing
177
178         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Clear HTTP cache to ensure consistent test environment
179         (matching Mac DRT).
180         * DumpRenderTree/win/DumpRenderTree.vcproj: Link to CFNetwork.
181
182 2008-01-24  Sam Weinig  <sam@webkit.org>
183
184         Reviewed by Ada Chan.
185
186         Fix for <rdar://5131975> DumpRenderTree doesn't support undo/redo
187
188         - Adds simplified UndoManager to windows DRT to allow testing the
189           undo/redo code paths in WebCore and WebKit.  This is a temporary
190           solution to an issue that should eventually be solved by having a
191           shared UndoManager in WebKit.
192
193         * DumpRenderTree/win/DumpRenderTree.cpp:
194         (runTest):
195         * DumpRenderTree/win/UIDelegate.cpp:
196         (DRTUndoObject::DRTUndoObject):
197         (DRTUndoObject::invoke):
198         (DRTUndoStack::~DRTUndoStack):
199         (DRTUndoStack::isEmpty):
200         (DRTUndoStack::clear):
201         (DRTUndoStack::push):
202         (DRTUndoStack::pop):
203         (DRTUndoManager::canRedo):
204         (DRTUndoManager::canUndo):
205         (DRTUndoManager::DRTUndoManager):
206         (DRTUndoManager::removeAllActions):
207         (DRTUndoManager::registerUndoWithTarget):
208         (DRTUndoManager::redo):
209         (DRTUndoManager::undo):
210         (UIDelegate::UIDelegate):
211         (UIDelegate::resetUndoManager):
212         (UIDelegate::registerUndoWithTarget):
213         (UIDelegate::removeAllActionsWithTarget):
214         (UIDelegate::setActionTitle):
215         (UIDelegate::undo):
216         (UIDelegate::redo):
217         (UIDelegate::canUndo):
218         (UIDelegate::canRedo):
219         * DumpRenderTree/win/UIDelegate.h:
220
221 2008-01-23  Adam Roben  <aroben@apple.com>
222
223         Allow directories containing ChangeLogs to be passed to
224         resolve-ChangeLogs
225
226         Reviewed by David Kilzer.
227
228         * Scripts/resolve-ChangeLogs:
229         (sub findChangeLog): Return a ChangeLog contained within the specified
230         directory if one exists.
231
232 2008-01-23  Steve Falkenburg  <sfalken@apple.com>
233
234         <rdar://problem/5698732> Copyright strings should include 2008
235
236         Reviewed by Sam.
237
238         * Drosera/win/Drosera.vcproj/Drosera.rc:
239         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc:
240
241 2008-01-23  Alp Toker  <alp@atoker.com>
242
243         Rubber-stamped by Mark Rowe.
244
245         Remove whitespace after -I in automake include lists.
246
247         * GNUmakefile.am:
248
249 2008-01-23  Michael Goddard <michael.goddard@trolltech.com>
250
251         Reviewed by Lars Knoll <lars@trolltech.com>.
252
253         Reworked the JavaScriptCore Qt bindings:
254         
255         * Update JS DRT controller for Qt JS binding changes.
256         There were two functions that needed some changes
257         so that the layout tests would work, so this makes
258         a few tests pass again.
259         
260         * Bump the timeout for layout tests up to 11s.
261         At least some tests have an internal timeout of
262         10 seconds, so make the waitUntilDone approach
263         wait at least 11s.  fast/dom/open-and-close-by-DOM.html
264         is one of these - now the failure message is more
265         accurate.
266         
267
268         * DumpRenderTree/qt/jsobjects.cpp:
269         (LayoutTestController::waitUntilDone):
270         * DumpRenderTree/qt/jsobjects.h:
271
272 2008-01-22  Anders Carlsson  <andersca@apple.com>
273
274         Reviewed by Darin and Adam.
275
276         <rdar://problem/5688975>
277         div element on microsoft site has wrong left offset.
278         
279         Add new method for testing the return vale of NPN_GetProperty.
280         
281         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
282         (pluginInvoke):
283
284 2008-01-22  Alexey Proskuryakov  <ap@webkit.org>
285
286         Reviewed by Adam Roben.
287
288         <rdar://problem/5670257> editing/selection/4895428-3.html makes editing/selection/5131716-2.html fail
289
290         * DumpRenderTree/win/EventSender.cpp: (makeEventSender): Reset static variables for a new test.
291
292 2008-01-21  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
293
294         Reviewed by Alp Toker.
295
296         http://bugs.webkit.org/show_bug.cgi?id=16955
297         Get errors when cross-compile webkit-gtk
298
299         * GNUmakefile.am: Removed ICU_CFLAGS 
300
301 2008-01-21  Darin Adler  <darin@apple.com>
302
303         Reviewed by Mitz and Adam.
304
305         * Scripts/svn-create-patch: Sort ChangeLog files first. Also slightly improved the
306         sorting speed by doing all sort criteria in a single pass instead of three sorts.
307
308 2008-01-21  Simon Hausmann  <hausmann@webkit.org>
309
310         Reviewed by Holger.
311
312         Fix focus chain handling and cycling through focusable objects (links) using tab/backtab.
313         
314         * Fix GraphicsContext::drawFocusRing to also draw single focus rects.
315         * Implemented QWebPage::focusNextPrevChild by sending fake tab/shift-tab events
316         and make the return value depend on whether we successfully determined a focusable
317         node or not.
318         * Changed QWebView::focusNextPrevChild() to call the base QWidget implementation correctly
319         if we could not handle the focus chain ourselves.
320         * Changed the focus policy of QWebView to correctly use WheelFocus instead of ClickFocus.
321         * Made ChromeClientQt::canTakeFocus() and takeFocus() dummy method since they are only
322         used to control the situation of stepping out of the focus chain inside the page.
323         * Made inclusion of links in the focus chain configurable through QWebSettings::LinksIncludedInFocusChain.
324         The layout tests expect this to be disabled but for the user it seems sensible to have it
325         on by default, hence the default in qwebsettings.cpp
326         
327
328         * DumpRenderTree/qt/DumpRenderTree.cpp:
329         (WebCore::WebPage::WebPage):
330
331 2008-01-19  Mark Rowe  <mrowe@apple.com>
332
333         Reviewed by Alp Toker.
334
335         Allow the --http flag to run-webkit-tests to override
336         the default behaviour of disabling HTTP tests for Qt,
337         Gtk and Wx.
338
339         * Scripts/run-webkit-tests:
340
341 2008-01-19  David Kilzer  <ddkilzer@apple.com>
342
343         <rdar://problem/5695344> check-for-global-initializers script never checks any object files
344
345         Reviewed by Darin.
346
347         We now touch a check-for-global-initializers.timestamp file in
348         the TARGET_TEMP_DIR directory to determine when new object files
349         have been compiled and thus need to be checked.  If the timestamp
350         file doesn't exist, all object files will be checked.
351
352         Previously the modification time of the "executable" (the
353         framework binary, e.g., WebKit.framework/WebKit) was used, but
354         since this was the last file modified at the end of the compile
355         phase, no object files would ever get checked!
356
357         Also added JSCustomSQLTransactionCallback.o to the list of files
358         since it has static initializers in Debug builds of WebCore.
359
360         * Scripts/check-for-global-initializers:
361
362 2008-01-18  Adam Roben  <aroben@apple.com>
363
364         Build fix
365
366         * Scripts/build-webkit:
367
368 2008-01-18  Beth Dakin  <bdakin@apple.com>
369
370         Reviewed by Oliver.
371
372         Update build-webkit to account for foreign-object being disabled by 
373         default.
374
375         * Scripts/build-webkit:
376
377 2008-01-18  Adam Roben  <aroben@apple.com>
378
379         Updated for method renames
380
381         Reviewed by Adele.
382
383         * DumpRenderTree/mac/FrameLoadDelegate.mm:
384         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
385         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
386         (LayoutTestController::setMainFrameIsFirstResponder):
387         (LayoutTestController::setWindowIsKey):
388         * DumpRenderTree/mac/UIDelegate.mm:
389         (-[UIDelegate webViewFocus:]):
390         * DumpRenderTree/win/FrameLoadDelegate.cpp:
391         (FrameLoadDelegate::didCommitLoadForFrame):
392
393 2008-01-18  Alexey Proskuryakov  <ap@webkit.org>
394
395         Reviewed by Adam Roben.
396
397         Fix plugin-related tests in Debug_Internal configuration, which are failing because of CRT version mismatch
398         between DRT and TestNetscapePlugin.
399
400         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Added a Debug_Internal configuration.
401         * DumpRenderTree/DumpRenderTree.sln: Use this configuration.
402
403 2008-01-18  Simon Hausmann  <hausmann@webkit.org>
404
405         Reviewed by Holger.
406
407         Fix fast/dom/Window/window-resize.html
408         
409         In DRT connect the page's geometryChangeRequest signal to a slot that
410         sets the geometry of the view widget.
411         
412
413         * DumpRenderTree/qt/DumpRenderTree.cpp:
414         (WebCore::WebPage::setViewGeometry):
415         (WebCore::WebPage::WebPage):
416
417 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
418
419         Build fix.
420
421         * Drosera/DroseraWin.make:
422
423 2008-01-17  Darin Adler  <darin@apple.com>
424
425         * Scripts/run-webkit-tests: Fixed a bug number.
426
427 2008-01-17  Alexey Proskuryakov  <ap@webkit.org>
428
429         Reviewed by Adam Roben.
430
431         http://bugs.webkit.org/show_bug.cgi?id=16908
432         run-webkit-tests complains about missing FindSafari.exe
433
434         * Scripts/webkitdirs.pm: Append _debug as appropriate.
435
436 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
437
438         Re-add DEBUG_WEBKIT_HAS_SUFFIX.
439         
440         Rubber-stamped by Jon Honeycutt.
441
442         * DumpRenderTree/win/DumpRenderTree.vcproj:
443
444 2008-01-16  Alp Toker  <alp@atoker.com>
445
446         Reviewed by Mark Rowe.
447
448         http://bugs.webkit.org/show_bug.cgi?id=16218
449         [GTK] API: Should this entry point be called go_back rather than go_backward?
450
451         Track back/forward API changes in the tools.
452
453         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
454         (BackForwardItem::invoke):
455         * GtkLauncher/main.c:
456         (go_back_cb):
457
458 2008-01-16  Adam Roben  <aroben@apple.com>
459
460         Windows build fix after r29488
461
462         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
463         Build into a subdirectory of $WebKitOutputDir\bin to match where DRT
464         expects to find the plugin.
465
466 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
467
468         Reviewed by Sam Weinig.
469         
470         Fixed the waitUntilDone watchdog timer -- the old code never added the
471         timer to the run loop, so it didn't do anything.
472
473         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
474         (LayoutTestController::setWaitToDump):
475         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
476         (LayoutTestController::setWaitToDump):
477
478 2008-01-14  Steve Falkenburg  <sfalken@apple.com>
479
480         Use shared vsprops for most vcproj properties.
481         
482         Reviewed by Darin.
483
484         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
485         * DumpRenderTree/win/DumpRenderTree.vcproj:
486         * DumpRenderTree/win/ImageDiff.vcproj:
487         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
488         * FindSafari/FindSafari.vcproj:
489
490 2008-01-14  Stephanie  <slewis@apple.com>
491
492        Reviewed by NOBODY.
493   
494        revert accidental character.
495
496        * Scripts/run-webkit-tests:
497
498 2008-01-14  Stephanie  <slewis@apple.com>
499
500         RS=Oliver
501
502         add Quicktime PPC only leaks to Leopard exclude list. See <rdar://problem/5667132>
503
504         * Scripts/run-webkit-tests:
505
506 2008-01-14  Darin Adler  <darin@apple.com>
507
508         * Scripts/do-webcore-rename: Queue up another rename.
509
510 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
511
512         Reviewed by Darin.
513
514         * Allow to run the tests in reverse order to spot test cases where the result depends on the order
515         the tests were ran.
516         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
517
518         * Scripts/run-webkit-tests:
519
520 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
521
522         Reviewed by Darin.
523
524         * Randomize tests array to spot test cases where the results depends on the order
525         the tests are ran.
526         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
527
528         * Scripts/run-webkit-tests:
529
530 2008-01-14  Darin Adler  <darin@apple.com>
531
532         * Scripts/run-webkit-tests: More ignore list tweaking.
533
534 2008-01-14  Darin Adler  <darin@apple.com>
535
536         * Scripts/run-webkit-tests: Add another leak to the ignore list.
537
538 2008-01-14  Dan Bernstein  <mitz@apple.com>
539
540         Reviewed by Adam Roben.
541
542         - try to fix failure in fast/dom/Window/window-onFocus.html seen on the
543           build bots
544
545         * DumpRenderTree/win/DumpRenderTree.cpp:
546         (resetWebViewToConsistentStateBeforeTesting): Focus the web view.
547
548 2008-01-13  Steve Falkenburg  <sfalken@apple.com>
549
550         Share common files across projects.
551         
552         Unify vsprops files
553         Debug:          common.vsprops, debug.vsprops
554         Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
555         Release:        common.vsprops, release.vsprops
556         
557         Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
558         debug_internal.vsprops will be mostly empty except for file path prefix modifiers.
559
560         Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.
561
562         Reviewed by Adam Roben.
563
564         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
565         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Removed.
566         * Drosera/win/Drosera.vcproj/VERSION: Removed.
567         * Drosera/win/Drosera.vcproj/auto-version.sh: Removed.
568         * Drosera/win/Drosera.vcproj/debug.vsprops: Removed.
569         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Removed.
570         * Drosera/win/Drosera.vcproj/release.vsprops: Removed.
571         * DumpRenderTree/win/DumpRenderTree.vcproj:
572         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
573         * DumpRenderTree/win/debug.vsprops: Removed.
574         * DumpRenderTree/win/debug_internal.vsprops: Removed.
575         * DumpRenderTree/win/release.vsprops: Removed.
576
577 2008-01-13  Brent Fulgham  <bfulgham@gmail.com>
578
579         Reviewed by Maciej.
580
581         - http://bugs.webkit.org/show_bug.cgi?id=16314
582           Script to launch Drosera
583
584         * Scripts/gdb-drosera: Added.
585         * Scripts/run-drosera: Added.
586         * Scripts/run-drosera-nightly.cmd: Added.
587         * Scripts/webkitdirs.pm: Added runDrosera function.
588
589 2008-01-13  Dan Bernstein  <mitz@apple.com>
590
591         - fix breakage due to last-minute change
592
593         * DumpRenderTree/win/DumpRenderTree.cpp:
594         (runTest): Declare the loop variable.
595
596 2008-01-13  Dan Bernstein  <mitz@apple.com>
597
598         Reviewed by Adam Roben.
599
600         - fix <rdar://problem/5132009> Windows DRT does not support multiple windows
601
602         * DumpRenderTree/win/DumpRenderTree.cpp:
603         (DumpRenderTreeWndProc):
604         (initialize):
605         (dumpBackForwardList):
606         (dumpBackForwardListForAllWindows):
607         (dump):
608         (resetWebViewToConsistentStateBeforeTesting): Factored out of
609         runTest().
610         (runTest):
611         (allWindows): Added. Returns a vector of all open windows.
612         (windowToWebViewMap): Added. Returns a map from open windows to their
613         WebViews.
614         (createWebViewAndOffscreenWindow): Factored out of main() to be
615         reusable for creating extra windows.
616         (main):
617         * DumpRenderTree/win/DumpRenderTreeWin.h:
618         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
619         (LayoutTestController::windowCount): Implemented.
620         * DumpRenderTree/win/UIDelegate.cpp:
621         (UIDelegate::createWebViewWithRequest): Implemented.
622         (UIDelegate::webViewClose): Implemented.
623         * DumpRenderTree/win/UIDelegate.h:
624
625 2008-01-12  Alp Toker  <alp@atoker.com>
626
627         Reviewed by Mark Rowe.
628
629         Hide non-public symbols in GTK+/autotools release builds.
630
631         * GNUmakefile.am:
632
633 2008-01-12  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
634
635         Reviewed by Ap.
636
637         * Make launching of the WebKit httpd work on GNU/Debian/Linux
638         
639         The configuration of Apache2 and installation does not depend on
640         the kernel but on the distribution policy. Make launching of httpd
641         work for Debian derived distributions.
642
643         * Scripts/run-webkit-httpd:
644         * Scripts/run-webkit-tests:
645         * Scripts/webkitdirs.pm:
646
647 2008-01-12  Mark Rowe  <mrowe@apple.com>
648
649         Reviewed by Maciej Stachowiak.
650
651         Fix crash in http/tests/security/local-JavaScript-from-remote.html under guard malloc.
652
653         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Retain string before returning it to
654         match the callers expectations that it can take ownership of the string.
655
656 2008-01-11  Alexey Proskuryakov  <ap@webkit.org>
657
658         Reviewed by Adam Roben.
659
660         <rdar://problem/5667275> fast/dynamic/layer-hit-test-crash.html is failing
661
662         * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ignore WM_MOUSELEAVE events,
663         as these are only posted because the test window is not a normal visible one, and
664         they confuse drag&drop machinery.
665
666 2008-01-11  Adam Roben  <aroben@apple.com>
667
668         Fix a crash when pathToLocalResource fails and a leak
669
670         Reviewed by Darin.
671
672         * DumpRenderTree/LayoutTestController.cpp:
673         (pathToLocalResourceCallback): Dont leak the JSStringRef, and make
674         sure not to pass null to JSValueMakeString.
675         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
676         (LayoutTestController::pathToLocalResource): Print an error message if
677         the conversion fails so it's clear what happened.
678
679 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
680
681         Reviewed by John Sullivan.
682
683         * DumpRenderTree/mac/GCControllerMac.mm:
684         (GCController::collectOnAlternateThread): Updated for name change.
685
686 2008-01-10  Kevin Ollivier  <kevino@theolliviers.com>
687
688         wx build fix. Don't build dftables any longer since it's now a Perl
689         script.
690
691         * wx/build-wxwebkit:
692
693 2008-01-10  Sam Weinig  <sam@webkit.org>
694
695         Reviewed by Anders Carlsson.
696
697         Make DRT track open windows instead of allocated windows so that
698         we can avoid ASSERTION due to late deallocs out of our control.
699
700         * DumpRenderTree/mac/DumpRenderTree.mm:
701         (dumpBackForwardListForAllWindows):
702         (runTest):
703         * DumpRenderTree/mac/DumpRenderTreeMac.h:
704         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
705         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
706         (+[DumpRenderTreeWindow openWindows]):
707         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
708         (-[DumpRenderTreeWindow close]):
709         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
710         (LayoutTestController::windowCount):
711
712 2008-01-10  Ada Chan  <adachan@apple.com>
713
714         Meta key is not the same as Alt key on windows.
715
716         Reviewed by Darin.
717
718         * DumpRenderTree/win/EventSender.cpp:
719         (keyDownCallback):
720
721 2008-01-09  Kevin McCullough  <kmccullough@apple.com>
722
723         Reviewed by Darin, Sam and Adam.
724
725         -<rdar://problem/5654486> REGRESSION (Safari 3.0.4-TOT): clicking on
726         link in gmail message displays JavaScript alert falsely complaining
727         about pop-up blocking.
728         - Added the ability to enable the pop-up blocker via the
729         LayoutTestController.
730
731         * DumpRenderTree/LayoutTestController.cpp:
732         (setPopupBlockingEnabledCallback):
733         (LayoutTestController::staticFunctions):
734         * DumpRenderTree/LayoutTestController.h:
735         * DumpRenderTree/mac/DumpRenderTree.mm:
736         (setDefaultsToConsistentValuesForTesting):
737         (resetWebViewToConsistentStateBeforeTesting):
738         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
739         (LayoutTestController::setPopupBlockingEnabled):
740
741 2008-01-10  Lars Knoll  <lars@trolltech.com>
742
743         Reviewed by Simon.
744
745         rename QWebPageHistory to QWebHistory.
746         
747
748         * DumpRenderTree/qt/jsobjects.cpp:
749
750 2008-01-09  Maciej Stachowiak  <mjs@apple.com>
751
752         Reviewed by Darin.
753         
754         - add some more renames, adjust some
755
756         * Scripts/do-webcore-rename:
757
758 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
759
760         Reviewed by Oliver.
761
762         Enable SVG Fonts support by default.
763
764         * Scripts/build-webkit:
765
766 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
767
768         Reviewed by Adam.
769
770         Fixes: http://bugs.webkit.org/show_bug.cgi?id=16244
771         DRT doesn't handle platform specific pixel test results correctly.
772
773         <test>-expected.txt files and <test>-expected.png files may now live
774         in different directories (ie. a cross-platform <test>-expected.txt file
775         and a platform-specific <test>-expected.png file).
776
777         * Scripts/run-webkit-tests:
778
779 2008-01-04  Kevin McCullough  <kmccullough@apple.com>
780
781         Reviewed by Darin.
782
783         - <rdar://problem/5666914> fast/regex/test{1,4}.html are failing
784         DRT did not correctly handle printing the '\0' char.  Now it does.
785
786         * DumpRenderTree/win/DumpRenderTree.cpp:
787         (dumpFramesAsText):
788         (dump):
789
790 2008-01-07  Simon Hausmann  <hausmann@webkit.org>
791
792         Reviewed by Lars.
793
794         Ported of the network backend of the Qt platform to Qt 4.4's new networking API.
795         
796
797         * DumpRenderTree/qt/main.cpp:
798         * DumpRenderTree/qt/testplugin.cpp:
799         * DumpRenderTree/qt/testplugin.h:
800
801 2008-01-05  Mark Rowe  <mrowe@apple.com>
802
803         Reviewed by Alp Toker.
804
805         Fix hang in fast/frames/frame-display-none-focus.html during Gtk layout tests.
806
807         * DumpRenderTree/gtk/DumpRenderTree.cpp:
808         (processWork): Process pending work.
809         (webViewLoadFinished): Schedule processing of pending work.
810         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Use webkit_web_frame_reload.
811
812 2008-01-05  Darin Adler  <darin@apple.com>
813
814         * Scripts/do-webcore-rename: Some more renaming plans.
815
816 2008-01-04  Alice Liu  <alice.liu@apple.com>
817
818         Reviewed by Alexey and Darin.
819
820         Adding "home" and "end" to DRT's keydown since
821         DOM key events can't handle keyIdentifiers at this point. 
822
823         * DumpRenderTree/mac/EventSendingController.mm:
824         (-[EventSendingController keyDown:withModifiers:]):
825         * DumpRenderTree/win/EventSender.cpp:
826         (keyDownCallback):
827
828 2008-01-04  Lars Knoll  <lars@trolltech.com>
829
830         Reviewed by Simon.
831
832         fix DRT after the changes to QWebPage.
833         
834         The great thing is that we actually don't have
835         any regressions from the QWebPage change :)
836         
837
838         * DumpRenderTree/qt/DumpRenderTree.cpp:
839         (WebCore::DumpRenderTree::DumpRenderTree):
840
841 2008-01-04  Lars Knoll  <lars@trolltech.com>
842
843         Reviewed by Simon.
844
845         make QWebPage a QObject and get things to compile.
846         
847         Nothing works currently though.
848         
849
850         * DumpRenderTree/qt/DumpRenderTree.cpp:
851         (WebCore::DumpRenderTree::DumpRenderTree):
852
853 2008-01-04  Lars Knoll  <lars@trolltech.com>
854
855         Reviewed by Simon.
856
857         take a QString as identifier in QWebFrame::addToJSWindowObject.
858
859         * DumpRenderTree/qt/DumpRenderTree.cpp:
860         (WebCore::DumpRenderTree::initJSObjects):
861
862 2008-01-04  Alp Toker  <alp@atoker.com>
863
864         GTK+ DRT build fix for breakage introduced in r29149.
865
866         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
867         (LayoutTestController::execCommand):
868
869 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
870
871         Reviewed by Darin.
872
873         <rdar://problem/5463489> A number of layout tests should be using execCommand instead of textInputController
874
875         Added layoutTestController.execCommand to access editor commands that are not available
876         via document.execCommand.
877
878         * DumpRenderTree/LayoutTestController.cpp:
879         (execCommandCallback):
880         (LayoutTestController::staticFunctions):
881         * DumpRenderTree/LayoutTestController.h:
882         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
883         (LayoutTestController::execCommand):
884         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
885         (LayoutTestController::queueLoad):
886         (LayoutTestController::execCommand):
887
888 2008-01-03  Alice Liu  <alice.liu@apple.com>
889
890         Reviewed by Darin, Mitz.
891
892         fixed <rdar://5130762> mousedowns in different locations increase the clickcount incorrectly
893
894         the clickcount should not increase if the last click was at a different location.  it's a new click.
895
896         * DumpRenderTree/mac/DumpRenderTree.mm:
897         (runTest):
898         * DumpRenderTree/mac/EventSendingController.h:
899         * DumpRenderTree/mac/EventSendingController.mm:
900         (-[EventSendingController mouseDown]):
901         (-[EventSendingController mouseUp]):
902
903 2008-01-03  Darin Adler  <darin@apple.com>
904
905         Reviewed by Adam.
906
907         * Scripts/update-webkit: Make this work a little better for the people at Apple
908         who have a directory named Internal.
909
910 2008-01-03  Adam Roben  <aroben@apple.com>
911
912         Use HTTP::Date instead of Date::Parse because it's installed by Cygwin by default
913
914         Rubberstamped by Mark.
915
916         * Scripts/update-webkit-auxiliary-libs:
917
918 2008-01-03  Adam Roben  <aroben@apple.com>
919
920         Fix Bug 15663: update-webkit re-downloads WebKitAuxiliaryLibrary unnecessarily
921
922         http://bugs.webkit.org/show_bug.cgi?id=15663
923
924         Added a fuzz factor into the Last-Modified comparison for downloading
925         WebKitAuxiliaryLibrary.zip.
926
927         The zip file is served from a set of mirrors who give Last-Modified
928         times that are off by 1-3 seconds from each other. This was causing
929         the build bots to redownload WebKitAuxiliaryLibrary for every build,
930         which would then cause all of WebCore to rebuild each time.
931
932         Reviewed by Mark.
933
934         * Scripts/update-webkit-auxiliary-libs: Check if the new zip file is
935         at least 30 seconds newer than the old one -- otherwise we assume that
936         the difference in time is due to the mirrors being slightly offset
937         from each other.
938         (sub lastModifiedToUnixTime): Added.
939
940 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
941
942         Windows build fix.
943
944         * DumpRenderTree/ForwardingHeaders/wtf/HashTraits.h: Added (needed by COMPtr.h).
945
946 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
947
948         Reviewed by Lars.
949
950         Moved QWebPage::open to QWebFrame::load and added setHtml.
951         
952
953         * DumpRenderTree/qt/DumpRenderTree.cpp:
954         (WebCore::DumpRenderTree::open):
955
956 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
957
958         Reviewed by Lars.
959
960         Added the first revision of QWebView and started moving functionality from QWebPave over to QWebView and QWebFrame.
961         
962
963         * DumpRenderTree/qt/DumpRenderTree.cpp:
964         (WebCore::DumpRenderTree::DumpRenderTree):
965
966 2008-01-02  Sam Weinig  <sam@webkit.org>
967
968         * Scripts/do-webcore-rename: Yet more renaming ideas.
969
970 2008-01-02  Darin Adler  <darin@apple.com>
971
972         * Scripts/do-webcore-rename: More renaming ideas. (Maciej, please merge yours with mine.)
973
974 2008-01-02  Alice Liu  <alice.liu@apple.com>
975
976         Reviewed by Sam Weinig.
977
978         fixing assertion hit with editing/selection/move-begin-end.html
979
980         * DumpRenderTree/ForwardingHeaders/wtf/ASCIICType.h: Added.
981         * DumpRenderTree/win/DumpRenderTree.vcproj:
982         * DumpRenderTree/win/EventSender.cpp:
983         (keyDownCallback):
984         using isupper will cause an assertion for inputs outside of ascii range. use isASCIIUpper instead.
985
986 2008-01-02  Darin Adler  <darin@apple.com>
987
988         * Scripts/do-webcore-rename: Some more name change plans.
989
990 2008-01-02  Alice Liu  <alice.liu@apple.com>
991
992         Reviewed by Maciej.
993
994         Added handling for page up and page down in EventSender
995
996         * DumpRenderTree/mac/EventSendingController.mm:
997         (-[EventSendingController keyDown:withModifiers:]):
998         * DumpRenderTree/win/EventSender.cpp:
999         (keyDownCallback):
1000
1001 2008-01-02  Alexey Proskuryakov  <ap@webkit.org>
1002
1003         Reviewed by Darin.
1004
1005         Fix fast/events/arrow-keys-on-body.html for real.
1006
1007         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Pass proper keyData for WM_KEYUP, too.
1008
1009 2008-01-02  Luca Bruno  <lethalman88@gmail.com>
1010
1011         Reviewed by Darin.
1012
1013         http://bugs.webkit.org/show_bug.cgi?id=16674
1014         [GTK] run-launcher sets wrong LD_LIBRARY_PATH
1015
1016         * Scripts/run-launcher:
1017
1018 2007-12-31  Darin Adler  <darin@apple.com>
1019
1020         Suggested by Antti.
1021
1022         * Scripts/webkitdirs.pm: Turned off the QuickTime requirement for Windows until
1023         we get it installed on the build bots.
1024
1025 2007-12-30  Eric Seidel  <eric@webkit.org>
1026
1027         Reviewed by Sam.
1028
1029         * Scripts/do-webcore-rename: Add a few more planned renames s/(\w+)Imp/\1/
1030
1031 2007-12-29  Darin Adler  <darin@apple.com>
1032
1033         Reviewed by Oliver.
1034
1035         - fix http://bugs.webkit.org/show_bug.cgi?id=16663
1036           leak bot shows createCStringFromNPVariant result leaking
1037
1038         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1039         (pluginInvoke): Added a missing free.
1040
1041 2007-12-26  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
1042
1043         Reviewed by Alp Toker.
1044
1045         http://bugs.webkit.org/show_bug.cgi?id=16390
1046         Use autotools or GNU make as the build system for the GTK port
1047
1048         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: include glib.h
1049         * GNUmakefile.am: Added.
1050
1051 2007-12-24  Alexey Proskuryakov  <ap@webkit.org>
1052
1053         Reviewed by Oliver.
1054
1055         Fix fast/events/arrow-keys-on-body.html, failing on Windows.
1056
1057         * DumpRenderTree/win/EventSender.cpp:
1058         (keyDownCallback): Add KF_EXTENDED flag to arrow keys. Also add a count
1059         of 1, even though WebKit currently ignores it.
1060
1061 2007-12-23  Kevin Ollivier  <kevino@theolliviers.com>
1062
1063         wx buildbot fix. Update libpng dl script to the latest version.
1064
1065         * wx/install-unix-extras:
1066
1067 2007-12-22  Antti Koivisto  <antti@apple.com>
1068
1069         Fix a typo.
1070
1071         * Scripts/webkitdirs.pm:
1072
1073 2007-12-21  Sam Weinig  <sam@webkit.org>
1074
1075         Reviewed by Mark Rowe.
1076
1077         - Disable the back/forward cache using the new WebPreferences API
1078           instead of through the BackForwardList.  This makes us match what
1079           we do on Windows.
1080
1081         * DumpRenderTree/mac/DumpRenderTree.mm:
1082         (createWebViewAndOffscreenWindow):
1083         (setDefaultsToConsistentValuesForTesting):
1084
1085 2007-12-21  Dan Bernstein  <mitz@apple.com>
1086
1087         Reviewed by Mark Rowe.
1088
1089         - disable the back/forward cache in Windows DumpRenderTree. It is
1090           already disabled in Mac DumpRenderTree.
1091
1092         * DumpRenderTree/win/DumpRenderTree.cpp:
1093         (initializePreferences):
1094
1095 2007-12-13  Antti Koivisto  <antti@apple.com>
1096
1097         Reviewed by Darin and Steve.
1098         
1099         - check for QuickTime SDK on Windows.
1100         - build media support on Windows by default
1101
1102         * Scripts/build-webkit:
1103         * Scripts/webkitdirs.pm:
1104
1105 2007-12-21  Kevin Ollivier  <kevino@theolliviers.com>
1106
1107         Build script fix for buildbot.
1108
1109         * wx/build-wxwebkit:
1110
1111 2007-12-20  Eric Seidel  <eric@webkit.org>
1112
1113         Reviewed by mjs.
1114
1115         * Scripts/run-sunspider: change --runs default to 10 for better accuracy
1116
1117 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
1118
1119         Reviewed by Steve.
1120
1121         - <rdar://5656485> Drosera: Win: Nightly does not reliably connect to
1122         WebKit.
1123
1124         - Drosera and Safari need to use the same ProgIDs in order for
1125         CoCreateInstance to work properly.  The most robust way to do this is
1126         for WebKit to dynamically publish those ProgIDs.
1127
1128         * Drosera/win/DebuggerClient.cpp: Use the published ProgIDs
1129         (DebuggerClient::createWebViewWithRequest):
1130         * Drosera/win/Drosera.cpp: Use the published ProgIDs and rename some
1131         statics.
1132         (Drosera::initUI):
1133         (Drosera::attach):
1134         (Drosera::attemptToCreateServerConnection):
1135         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Fix a runtime failure.
1136         * Drosera/win/ServerConnection.cpp: Reformat the connection function and
1137         make use of the published ProgIDs.
1138         (ServerConnection::attemptToCreateServerConnection):
1139
1140 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
1141
1142         - <rdar://problem/5658317> REGRESSION: 20+ leaks seen on buildbots.
1143         - Build bot and leak fix.
1144
1145         * DumpRenderTree/LayoutTestController.cpp:
1146         (pathToLocalResourceCallback):
1147
1148 2007-12-19  David Kilzer  <ddkilzer@apple.com>
1149
1150         Make svn-apply/svn-unapply work with patches from git-format-patch.
1151
1152         Reviewed by Darin.
1153
1154         * Scripts/svn-apply:
1155         (patch): If 'Index:' can't be found in the text passed in, print it
1156         out with a warning and return early.
1157         * Scripts/svn-unapply:
1158         (patch): Ditto.
1159
1160 2007-12-18  Kevin Ollivier  <kevino@theolliviers.com>
1161
1162         Reviewed by Alp Toker.
1163
1164         Build related fixes.
1165
1166         * wx/build-wxwebkit:
1167         - Check to make sure the user is running a supported wx port
1168         - More robust checks for Cygwin
1169         - Only run install-unix-extras on Mac, it's not the right solution
1170           for Linux distros.
1171         - Remove outdated Linux instructions after successful build
1172         - Clean Bakefile-generated files during a clean operation
1173
1174 2007-12-18  Darin Adler  <darin@apple.com>
1175
1176         * Scripts/make-js-test-wrappers: Don't generate a wrapper for select-options-remove.js.
1177
1178 2007-12-18  Steve Falkenburg  <sfalken@apple.com>
1179
1180         Add script to run Drosera as part of the nightly.
1181         
1182         Reviewed by Kevin M.
1183
1184         * Scripts/run-drosera.cmd: Added.
1185
1186 2007-12-18  Darin Adler  <darin@apple.com>
1187
1188         * Scripts/do-webcore-rename: Remove a stray K.
1189
1190 2007-12-18  Darin Adler  <darin@apple.com>
1191
1192         * Scripts/do-webcore-rename: Plan more renaming.
1193
1194 2007-12-14  Juan A. Suarez Romero  <jasuarez@igalia.com>
1195
1196         Reviewed by Alp Toker.
1197
1198         http://bugs.webkit.org/show_bug.cgi?id=16042
1199         [GTK] Eliminate webkit_init()
1200
1201         Moving webkit initialization to WebView class init.
1202
1203         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1204         (main):
1205         * GtkLauncher/main.c:
1206         (main):
1207
1208 2007-12-17  Luca Bruno  <lethalman88@gmail.com>
1209
1210         Reviewed by Alp Toker.
1211
1212         http://bugs.webkit.org/show_bug.cgi?id=13542
1213         gdklauncher doesnt change URL in adress GTKEntry.
1214
1215         * GtkLauncher/main.c:
1216         (load_commit_cb): added
1217         (title_change_cb):
1218         (create_browser):
1219
1220 2007-12-16  Dimitri Glazkov  <dimitri@glazkov.com>
1221
1222         Reviewed by Adam Roben.
1223
1224         Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.
1225
1226         * FindSafari/FindSafari.cpp:
1227         (_tmain):
1228
1229 2007-12-16  Brent Fulgham  <bfulgham@gmail.com>
1230
1231         Reviewed by Adam Roben.
1232
1233         http://bugs.webkit.org/show_bug.cgi?id=16315
1234         FindSafari needs a path-only option.
1235
1236         * FindSafari/FindSafari.cpp:
1237         (_tmain):
1238
1239 2007-12-16  Alexey Proskuryakov  <ap@webkit.org>
1240
1241         Reviewed by Darin.
1242
1243         http://bugs.webkit.org/show_bug.cgi?id=16462
1244         REGRESSION: access keys broken on Windows
1245
1246         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Send system key events
1247         if Alt is pressed.
1248
1249 2007-12-15  Sam Weinig  <sam@webkit.org>
1250
1251         Reviewed by Mark Rowe.
1252
1253         Fix urlSuitableForTestResult to correctly identify wstring::npos as
1254         the case when wstring.find doesn't find anything.
1255
1256         * DumpRenderTree/win/DumpRenderTree.cpp:
1257         (urlSuitableForTestResult):
1258
1259 2007-12-15  Alp Toker  <alp@atoker.com>
1260
1261         GTK+ DRT build fix for GLib < 2.14.
1262
1263         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1264         (LayoutTestController::setWaitToDump):
1265
1266 2007-12-05  Mark Rowe  <mrowe@apple.com>
1267
1268         Reviewed by Alp Toker.
1269
1270         Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.  This prevents
1271         many layout tests from hanging while waiting on user responses to dialogs.
1272
1273         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1274         (invalidateAnyPreviousWaitToDumpWatchdog):
1275         (webViewScriptAlert):
1276         (webViewScriptPrompt):
1277         (webViewScriptConfirm):
1278         (main):
1279         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
1280         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1281         (waitToDumpWatchdogFired):
1282         (LayoutTestController::setWaitToDump):
1283
1284 2007-12-05  Mark Rowe  <mrowe@apple.com>
1285
1286         Reviewed by Alp Toker.
1287
1288         Flesh out DumpRenderTree for Gtk.  After these changes, the majority of the tests in fast/js pass.
1289
1290         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1291         (dumpFramesAsText): Don't print the frame name when dumping the main frame as text.
1292         (dump):
1293         (runTest):
1294         (webViewLoadStarted): Store the top frame when it starts loading so we can use it to determine when to dump.
1295         (webViewLoadFinished): Dump when the top frame load completes if we're not waiting for a JS callback and the
1296         work queue is empty.
1297         (webViewWindowObjectCleared): Set up window.layoutTestController.
1298         (webViewConsoleMessage): Match the console message format expected by the layout test results.
1299         (main): Hook up the new signals.
1300         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
1301         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Only notify done if the top frame has completed loading to avoid
1302         dumping multiple times.
1303         * Scripts/build-dumprendertree: Ensure build-dumprendertree is a no-op for Gtk too.
1304         * Scripts/run-webkit-tests: Teach run-webkit-tests that Gtk is like Qt in many ways.  Use run-launcher to open test results.
1305
1306 2007-12-14  Anders Carlsson  <andersca@apple.com>
1307
1308         Reviewed by Brady.
1309
1310         Assert that a web frame that's loading a resource always has either a data source or 
1311         a provisional data source.
1312         
1313         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1314         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1315
1316 2007-12-14  Darin Adler  <darin@apple.com>
1317
1318         - fix mistake causing nearly all tests to fail on Windows
1319
1320         * DumpRenderTree/win/UIDelegate.cpp:
1321         (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with
1322         npos, not 0. Also pass URL in to URL function rather than passing the entire message.
1323
1324         * DumpRenderTree/mac/UIDelegate.mm:
1325         (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather
1326         than passing the entire message.
1327
1328 2007-12-14  Darin Adler  <darin@apple.com>
1329
1330         - fix Tiger build
1331
1332         * DumpRenderTree/mac/UIDelegate.mm:
1333         (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any
1334         new-to-Leopard methods.
1335
1336 2007-12-14  Darin Adler  <darin@apple.com>
1337
1338         * DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method
1339         since it now triggers unwanted icon loading. We only had it because we implemented "all"
1340         delegate methods here.
1341
1342 2007-12-14  Anders Carlsson  <andersca@apple.com>
1343
1344         Reviewed by Darin and Geoff.
1345
1346         <rdar://problem/5619295> 
1347         REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
1348         
1349         Add property getting methods to the plug-in.
1350         
1351         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1352         (pluginInvoke):
1353
1354 2007-12-14  Kevin McCullough  <kmccullough@apple.com>
1355
1356         Reviewed by Darin.
1357
1358         - Layout test fix for mac. When dumped to the console local file paths
1359         now only show the name of the resource not the whole path.  This is to
1360         make the results machine and OS independent.
1361
1362         * DumpRenderTree/mac/UIDelegate.mm:
1363         (-[UIDelegate webView:addMessageToConsole:]):
1364
1365 2007-12-13  Kevin McCullough  <kmccullough@apple.com>
1366
1367         Reviewed by Adam.
1368
1369         - Layout tests fix.  We need a way to remove machine-dependent
1370         information from paths in layout test results. The UIDelegate now does
1371         this.
1372
1373         * DumpRenderTree/DumpRenderTree.h:
1374         * DumpRenderTree/win/DumpRenderTree.cpp:
1375         (urlSuitableForTestResult):
1376         * DumpRenderTree/win/DumpRenderTreeWin.h:
1377         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1378         * DumpRenderTree/win/UIDelegate.cpp:
1379         (UIDelegate::webViewAddMessageToConsole):
1380
1381 2007-12-13  Alp Toker  <alp@atoker.com>
1382
1383         Build fix for DRT breakage introduced in r28690.
1384
1385         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1386         (LayoutTestController::pathToLocalResource):
1387
1388 2007-12-12  Kevin McCullough  <kmccullough@apple.com>
1389
1390         Reviewed by Alice and Sam.
1391
1392         - <rdar://5621435> Need a way to specify local resources (being loaded
1393         from HTTP tests) on Windows.
1394         - Implemented pathToLocalResource which exposes the functionality of
1395         converting a given unix path to the correct location on Windows.
1396
1397         * DumpRenderTree/LayoutTestController.cpp:
1398         (pathToLocalResourceCallback):
1399         (LayoutTestController::staticFunctions):
1400         * DumpRenderTree/LayoutTestController.h:
1401         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1402         (LayoutTestController::pathToLocalResource):
1403         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1404         (LayoutTestController::pathToLocalResource):
1405
1406 2007-12-12  Anders Carlsson  <andersca@apple.com>
1407
1408         Reviewed by Sam.
1409
1410         <rdar://problem/5132003>
1411         dumpResourceLoadCallbacks is not implemented in DRT on Windows.
1412
1413         * DumpRenderTree/win/DumpRenderTree.cpp:
1414         (main):
1415         Set the resource load delegate.
1416         
1417         * DumpRenderTree/win/DumpRenderTree.vcproj:
1418         
1419         * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
1420         * DumpRenderTree/win/ResourceLoadDelegate.h: Added.
1421
1422 2007-12-12  Alexey Proskuryakov  <ap@webkit.org>
1423
1424         Reviewed by Adam Roben.
1425
1426         Fix conversion from double to LPARAM in dispatchMessage().
1427
1428         * DumpRenderTree/win/EventSender.cpp:
1429         (dispatchMessageCallback):
1430
1431 2007-12-11  Dan Bernstein  <mitz@apple.com>
1432
1433         Reviewed by Mark Rowe and Sam Weinig too!
1434
1435         - added Helvetica Oblique and Helvetica Bold Oblique to the list of
1436           fonts DumpRenderTree registers.
1437
1438         * DumpRenderTree/win/DumpRenderTree.cpp:
1439         (initialize):
1440
1441 2007-12-11  Brady Eidson  <beidson@apple.com>
1442
1443         Reviewed by Anders
1444
1445         Make DumpRenderTree on mac use its own path for Databases testing
1446
1447         * DumpRenderTree/mac/DumpRenderTree.mm:
1448         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree 
1449           for future DRT-only use, then use it to construct the Databases path and set that default
1450
1451 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
1452
1453         Reviewed by Darin.
1454
1455         <rdar://problem/5535636>
1456         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
1457
1458         http://bugs.webkit.org/show_bug.cgi?id=13916
1459         JavaScript detects Tab as a character input on a textfield validation
1460
1461         * DumpRenderTree/mac/EventSendingController.mm:
1462         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
1463         Dispatch a keyup to better match what happens when a key is physically pressed.
1464
1465         * DumpRenderTree/win/EventSender.cpp:
1466         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
1467         returning from keyDown().
1468         (getConstantCallback): Fixed a couple copy/paste mistakes.
1469
1470 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
1471
1472         Reviewed by Oliver.
1473
1474         - <rdar://5599845> Drosera: Does not show loal files in the file list
1475         on the left side.
1476
1477         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
1478         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
1479         so the open source community can build.
1480
1481 2007-12-10  Brady Eidson  <beidson@apple.com>
1482
1483         Rubberstamped by Sam Weinig
1484
1485         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
1486
1487         * DumpRenderTree/mac/UIDelegate.mm:
1488         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
1489         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
1490
1491 2007-12-08  Oliver Hunt  <oliver@apple.com>
1492
1493         Reviewed by Sam W.
1494
1495         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
1496         
1497         Fixes <rdar://problem/5620249> Must disable SVG animation
1498         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
1499         
1500         In order to allow finer grained control over the set of SVG features
1501         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
1502         distinct flags:
1503         ENABLE_SVG_ANIMATION
1504         ENABLE_SVG_FILTERS
1505         ENABLE_SVG_FONTS
1506         ENABLE_SVG_AS_IMAGE
1507         ENABLE_SVG_USE
1508         
1509         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
1510         
1511         Script handles all the new build flags, and allows --svg-experimental
1512         to automatically enable all features.
1513
1514         * Scripts/build-webkit:
1515
1516 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
1517
1518         Fix version parsing.
1519
1520         Rubber-stamped by Oliver.
1521
1522         * Drosera/win/Drosera.vcproj/auto-version.sh:
1523
1524 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
1525
1526         Build modifications for Drosera.
1527
1528         Reviewed by Adam.
1529
1530         * Drosera/DroseraWin.make: Added.
1531         * Drosera/win/Drosera.vcproj/Drosera.rc:
1532         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1533         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
1534         * Drosera/win/Drosera.vcproj/VERSION: Added.
1535         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
1536
1537 2007-12-06  Adam Roben  <aroben@apple.com>
1538
1539         Explicitly turn on the Mac font ascent hack on Windows
1540
1541         This keeps our font metrics matching those from Mac.
1542
1543         Reviewed by Hyatt.
1544
1545         * DumpRenderTree/win/DumpRenderTree.cpp:
1546         (main):
1547
1548 2007-12-06  Anders Carlsson  <andersca@apple.com>
1549
1550         Rename main.c to main.cpp here too.
1551         
1552         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
1553
1554 2007-12-06  Sam Weinig  <sam@webkit.org>
1555
1556         Rubber stamped by Geoff.
1557
1558         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
1559
1560 2007-12-06  Darin Adler  <darin@apple.com>
1561
1562         * Scripts/do-webcore-rename: Some more renaming plans.
1563
1564 2007-12-06  Anders Carlsson  <andersca@apple.com>
1565
1566         Restore implementation of testGetIntIdentifier that was accidentally
1567         removed somehow (possibly when I made PluginObject be a cpp file).
1568         
1569         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1570         (pluginInvoke):
1571
1572 2007-12-05  Anders Carlsson  <andersca@apple.com>
1573
1574         Make the entry points extern "C".
1575         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1576         
1577 2007-12-05  Anders Carlsson  <andersca@apple.com>
1578
1579         C++ warning fixes.
1580         
1581         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1582         (NPP_New):
1583         (NPP_Destroy):
1584         (NPP_SetWindow):
1585         (NPP_NewStream):
1586         (NPP_HandleEvent):
1587         (NPP_URLNotify):
1588         (NPP_GetValue):
1589
1590 2007-12-05  Anders Carlsson  <andersca@apple.com>
1591
1592         Add the .cpp files to the TestNetscapePlugIn target.
1593
1594         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1595
1596 2007-12-05  Anders Carlsson  <andersca@apple.com>
1597
1598         Reviewed by Geoff.
1599         
1600         Rename the TestNetscapePlugIn .c files to be .cpp.
1601
1602         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1603         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
1604         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
1605         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
1606         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
1607         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
1608         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
1609         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1610
1611 2007-12-05  Adam Roben  <aroben@apple.com>
1612
1613         Fix case of keypresses from the Windows implementation of eventSender.keyDown
1614
1615         This fixes several regression tests.
1616
1617         Reviewed by Alice.
1618
1619         * DumpRenderTree/win/EventSender.cpp:
1620         (keyDownCallback): Virtual keycodes for ASCII characters are always
1621         uppercase, so we need to check the case of the original character
1622         passed in to eventSender.keyDown.
1623
1624 2007-12-05  Adam Roben  <aroben@apple.com>
1625
1626         Learn from Tim's mistakes
1627
1628         * DumpRenderTree/win/DumpRenderTree.cpp:
1629         (runTest): Reset the authorAndUserStylesEnabled preference for each
1630         test.
1631
1632 2007-12-05  Alp Toker  <alp@atoker.com>
1633
1634         Reviewed by Mark Rowe.
1635
1636         Initialize GTK+ and WebKit so the tests can run.
1637
1638         Reorganize the headers a little.
1639
1640         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1641         (main):
1642
1643 2007-12-04  Anders Carlsson  <andersca@apple.com>
1644
1645         Remove IWebScriptScope include.
1646         
1647         * Drosera/win/DebuggerDocumentPlatform.cpp:
1648
1649 2007-12-04  Sam Weinig  <sam@webkit.org>
1650
1651         Rubber stamped by Mark Rowe.
1652
1653         Define CF as platform for mac and revert r28409
1654
1655         * DumpRenderTree/DumpRenderTree.h:
1656         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1657
1658 2007-12-04  Sam Weinig  <sam@webkit.org>
1659
1660         Define CF as platform for windows.
1661
1662         Reviewed by Adam Roben.
1663
1664         * DumpRenderTree/win/DumpRenderTreeWin.h:
1665
1666 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
1667
1668         Reviewed by Adam and Darin.
1669
1670         - Removed a needless BSTR cleanup.
1671
1672         * Drosera/win/DebuggerDocumentPlatform.cpp:
1673         (DebuggerDocument::getPlatformCurrentFunctionStack):
1674
1675 2007-11-27  Adam Roben  <aroben@apple.com>
1676
1677         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
1678
1679         Reviewed by Maciej.
1680
1681         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1682         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
1683
1684 2007-12-04  Alp Toker  <alp@atoker.com>
1685
1686         Prospective Win DRT build fix.
1687
1688         * DumpRenderTree/DumpRenderTree.h:
1689
1690 2007-12-04  Alp Toker  <alp@atoker.com>
1691
1692         Fix a clobbered copyright header.
1693
1694         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1695
1696 2007-12-04  Xan Lopez  <xan@gnome.org>
1697
1698         Reviewed by Alp Toker.
1699
1700         http://bugs.webkit.org/show_bug.cgi?id=15561
1701         GTK port needs DumpRenderTree implementation
1702
1703         Start work on the GTK+ DRT.
1704
1705         This does not work yet, and there are a few lingering style issues
1706         (nothing major) but this patch has been stuck in the bug tracker for
1707         too long already.
1708
1709         * DumpRenderTree/DumpRenderTree.h:
1710         * DumpRenderTree/gtk: Added.
1711         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
1712         (autocorrectURL):
1713         (shouldLogFrameLoadDelegates):
1714         (dumpFrameScrollPosition):
1715         (displayWebView):
1716         (appendString):
1717         (dumpFramesAsText):
1718         (dumpRenderTreeAsText):
1719         (dump):
1720         (runTest):
1721         (main):
1722         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
1723         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
1724         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
1725         (GCController::collect):
1726         (GCController::collectOnAlternateThread):
1727         (GCController::getJSObjectCount):
1728         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
1729         (LayoutTestController::~LayoutTestController):
1730         (LayoutTestController::addDisallowedURL):
1731         (LayoutTestController::clearBackForwardList):
1732         (LayoutTestController::copyDecodedHostName):
1733         (LayoutTestController::copyEncodedHostName):
1734         (LayoutTestController::display):
1735         (LayoutTestController::keepWebHistory):
1736         (LayoutTestController::notifyDone):
1737         (LayoutTestController::queueBackNavigation):
1738         (LayoutTestController::queueForwardNavigation):
1739         (LayoutTestController::queueLoad):
1740         (LayoutTestController::queueReload):
1741         (LayoutTestController::queueScript):
1742         (LayoutTestController::setAcceptsEditing):
1743         (LayoutTestController::setCustomPolicyDelegate):
1744         (LayoutTestController::setMainFrameIsFirstResponder):
1745         (LayoutTestController::setTabKeyCyclesThroughElements):
1746         (LayoutTestController::setUseDashboardCompatibilityMode):
1747         (LayoutTestController::setUserStyleSheetEnabled):
1748         (LayoutTestController::setUserStyleSheetLocation):
1749         (LayoutTestController::setWindowIsKey):
1750         (LayoutTestController::setWaitToDump):
1751         (LayoutTestController::windowCount):
1752         (LayoutTestController::setPrivateBrowsingEnabled):
1753         (LayoutTestController::setAuthorAndUserStylesEnabled):
1754         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
1755         (JSStringCopyUTF8CString):
1756         (LoadItem::invoke):
1757         (ReloadItem::invoke):
1758         (ScriptItem::invoke):
1759         (BackForwardItem::invoke):
1760
1761 2007-12-03  Sam Weinig  <sam@webkit.org>
1762
1763         Move JavaScriptCore thread testing code to pthread specific directory
1764         and remove the dependance on CoreFoundation by using WTF::HashSet.
1765
1766         Reviewed by Geoff and Oliver.
1767
1768         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1769         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
1770         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
1771         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
1772         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
1773         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
1774         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
1775         * DumpRenderTree/pthreads: Added.
1776         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
1777         (javaScriptThreads):
1778         (runJavaScriptThread):
1779         (startJavaScriptThreads):
1780         (stopJavaScriptThreads):
1781
1782 2007-12-03  Andrew Bonventre  <andybons@google.com>
1783
1784         Reviewed by Darin Adler.
1785
1786         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
1787         Symbol lookup menu broken in debugger view
1788
1789         * Drosera/debugger.js: Fixed javascript error where document property
1790         should have been used instead of contentDocument in switchFunction that
1791         was breaking the select symbol dropdown menu.  This is because
1792         window.frames will return a Window object and not a frame object like
1793         the author was originally expecting.
1794
1795 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
1796
1797         Reviewed by Adam.
1798
1799         - <rdar://5618942> Drosera: Console window does not process everything
1800         correctly.
1801         - <rdar://5619005> Drosera: could be sped up by moving the 
1802         WebScriptScope stuff into the WebScriptCallFrame.
1803         - Now the console can correctly process objects and does not receive
1804         notifications from JavaScriptCore about the JavaScript in Drosera's
1805         own process.
1806
1807         * Drosera/win/DebuggerDocumentPlatform.cpp:
1808         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1809         (DebuggerDocument::platformValueForScopeVariableNamed):
1810
1811 2007-12-03  Stephanie  <slewis@apple.com>
1812
1813         Reviewed by Darin.
1814
1815         Check to see if we are building a debug root
1816
1817         * Scripts/check-for-global-initializers: 
1818
1819 2007-12-03  Dan Bernstein  <mitz@apple.com>
1820
1821         Reviewed by Darin Adler.
1822
1823         - added a testGetIntIdentifier() method to TestNetscapePlugIn
1824
1825         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
1826         (pluginInvoke):
1827
1828 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
1829
1830         Reviewed by Oliver.
1831
1832         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
1833         in a more fine-grained manner than eventSender.keyDown().
1834
1835         * DumpRenderTree/win/EventSender.cpp:
1836         (getConstantCallback):
1837         (dispatchMessageCallback):
1838
1839 2007-12-02  Darin Adler  <darin@apple.com>
1840
1841         * Scripts/do-webcore-rename: More planned renaming.
1842
1843 2007-12-02  Sam Weinig  <sam@webkit.org>
1844
1845         Rubber stamped by Anders.
1846
1847         Use [NSURL absoluteString] instead of [NSURL description] in order to get
1848         more uniform results cross platform.
1849
1850         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1851         (-[NSURL _drt_descriptionSuitableForTestResult]):
1852
1853 2007-12-02  Sam Weinig  <sam@webkit.org>
1854
1855         Rubber stamped by Niko.
1856
1857         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
1858
1859         * DumpRenderTree/win/DumpRenderTree.cpp:
1860         * DumpRenderTree/win/DumpRenderTree.vcproj:
1861         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
1862         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
1863         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
1864         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
1865
1866 2007-12-01  Alp Toker  <alp@atoker.com>
1867
1868         Reviewed by Adam Roben.
1869
1870         Make use of the newly introduced webkit.h convenience header.
1871
1872         * GtkLauncher/main.c:
1873
1874 2007-12-01  Adam Treat  <treat@kde.org>
1875
1876         Reviewed by Simon.
1877
1878         * Check to see if the directory exists and exit if not.
1879
1880         * DumpRenderTree/qt/main.cpp:
1881         (main):
1882
1883 2007-12-01  Adam Treat  <treat@kde.org>
1884
1885         Reviewed by Simon.
1886
1887         * Don't hide symbols when in Debug mode
1888         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
1889
1890
1891         * DumpRenderTree/qt/main.cpp:
1892         (messageHandler):
1893
1894 2007-11-30  Alp Toker  <alp@atoker.com>
1895
1896         Reviewed by Adam Roben.
1897
1898         http://bugs.webkit.org/show_bug.cgi?id=15691
1899         [GTK] Public API does not follow GTK+ conventions
1900
1901         Refactor the WebKit/GTK+ public API. Changes:
1902           WebKitPage -> WebKitWebView
1903           WebKitFrame -> WebKitWebFrame
1904
1905         Public API source and header names have been updated to mirror the API
1906         changes.
1907
1908         The API is now kept in WebKit/gtk/WebView to match other ports in the
1909         same class such as Mac and Win.
1910
1911         * GtkLauncher/main.c:
1912         (activate_uri_entry_cb):
1913         (link_hover_cb):
1914         (title_change_cb):
1915         (progress_change_cb):
1916         (go_back_cb):
1917         (go_forward_cb):
1918         (create_browser):
1919         (main):
1920
1921 2007-11-30  Adam Roben  <aroben@apple.com>
1922
1923         Hopefully the final build fix
1924
1925         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
1926         pull in WTF's assertion/logging functions.
1927
1928 2007-11-30  Adam Roben  <aroben@apple.com>
1929
1930         Another build fix
1931
1932         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
1933         WebKit.lib.
1934
1935 2007-11-30  Adam Roben  <aroben@apple.com>
1936
1937         Debug build fix
1938
1939         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
1940         configuration.
1941         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
1942         projects.
1943         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
1944         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
1945         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
1946
1947 2007-11-30  Sam Weinig  <sam@webkit.org>
1948
1949         Reviewed by Adam Roben.
1950
1951         Fix drawSelectionRect to actually draw the selection rect.
1952
1953         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1954         (drawSelectionRect):
1955
1956 2007-11-30  Darin Adler  <darin@apple.com>
1957
1958         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
1959
1960 2007-11-30  Darin Adler  <darin@apple.com>
1961
1962         * Scripts/do-webcore-rename: Get ready for some future renaming.
1963
1964 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1965
1966         Reviewed by Adam.
1967
1968         - Removed some unnecessary functions and changed an unused return type. 
1969
1970         * Drosera/win/DebuggerClient.cpp:
1971         (registerConsoleClass):
1972         * Drosera/win/DebuggerClient.h:
1973         * Drosera/win/Drosera.cpp:
1974         (registerDroseraClass):
1975
1976 2007-11-28  Alp Toker  <alp@atoker.com>
1977
1978         Reviewed by Timothy Hatcher.
1979
1980         http://bugs.webkit.org/show_bug.cgi?id=16174
1981         [GTK] Use "URI" not "URL" in public API
1982
1983         Replace use of the term "URL" with "URI" in public headers,
1984         documentation and some internal code to match GLib/GTK+ convention.
1985
1986         This is now mentioned in the API guidelines:
1987           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
1988
1989         * GtkLauncher/main.c:
1990         (activate_uri_entry_cb):
1991         (title_change_cb):
1992         (create_toolbar):
1993         (main):
1994
1995 2007-11-29  Anders Carlsson  <andersca@apple.com>
1996
1997         Reviewed by Sam.
1998
1999         <rdar://problem/5230478>
2000         FrameLoadDelegate callbacks are not dumped in DRT.
2001         
2002         * DumpRenderTree/win/DumpRenderTree.cpp:
2003         (shouldLogFrameLoadDelegates):
2004         (runTest):
2005         (main):
2006         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
2007         (BSTRtoString):
2008         (descriptionSuitableForTestResult):
2009         (FrameLoadDelegate::QueryInterface):
2010         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
2011         (FrameLoadDelegate::didFailProvisionalLoadWithError):
2012         (FrameLoadDelegate::didCommitLoadForFrame):
2013         (FrameLoadDelegate::didFinishLoadForFrame):
2014         (FrameLoadDelegate::willCloseFrame):
2015         (FrameLoadDelegate::didClearWindowObject):
2016         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
2017         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
2018         * DumpRenderTree/win/FrameLoaderDelegate.h:
2019         (FrameLoadDelegate::windowScriptObjectAvailable):
2020         (FrameLoadDelegate::didFirstLayoutInFrame):
2021
2022 2007-11-29  Sam Weinig  <sam@webkit.org>
2023
2024         Reviewed by Anders.
2025
2026         Add database quota UIDelegates methods to DRT UIDelegate.
2027
2028         * DumpRenderTree/mac/UIDelegate.mm:
2029         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
2030         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
2031
2032 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
2033
2034         Reviewed by Sam.
2035
2036         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
2037         dying and vice versa.
2038         - This fix will allow Drosera and Safari to reconnect if either of them
2039         closes correctly, but does not fix the case where one of them dies
2040         silently.
2041
2042         * Drosera/win/ServerConnection.cpp:
2043         (ServerConnection::attemptToCreateServerConnection): Added a safety
2044         check, because it's possilbe to try to connect to a server that's dying.
2045         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
2046         the server has died.
2047         * Drosera/win/ServerConnection.h: Added the new function and removed
2048         an unnecessary member.
2049
2050 2007-11-29  Anders Carlsson  <andersca@apple.com>
2051
2052         * DumpRenderTree/win/DumpRenderTree.vcproj:
2053         Add shlwapi.lib to all configurations.
2054
2055 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
2056
2057         - Build fix.  Added additional includes for VS Express to the Release
2058         project.
2059
2060         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2061
2062 2007-11-29  Anders Carlsson  <andersca@apple.com>
2063
2064         Reviewed by Adam.
2065
2066         <rdar://problem/5132005>
2067         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
2068         
2069         * DumpRenderTree/win/DumpRenderTree.vcproj:
2070         Add shlwapi.lib
2071         
2072         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2073         (LayoutTestController::setUserStyleSheetEnabled):
2074         Implement this.
2075         
2076         (appendComponentToPath):
2077         New method which wraps the Win32 API PathAppend.
2078         
2079         (followShortcuts):
2080         New method which checks if a file points to a shortcut and
2081         follows the shortcut.
2082         
2083         (resolveCygwinPath):
2084         New method that takes a cygwin unix-style path and returns the Win32 path.
2085         
2086         (cfStringRefToWString):
2087         
2088         (LayoutTestController::setUserStyleSheetLocation):
2089         Implement this.
2090
2091 2007-11-29  Alice Liu  <alice.liu@apple.com>
2092
2093         Reviewed by Adam.
2094
2095         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
2096
2097         * DumpRenderTree/win/EventSender.cpp:
2098         (keyDownCallback):
2099         uppercase letters were being sent as lowercase letters without the shift key down.
2100
2101 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
2102
2103         - Windows build fix. VS express needs some love.
2104
2105         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2106
2107 2007-11-28  Darin Adler  <darin@apple.com>
2108
2109         Reviewed by Adam Roben.
2110
2111         * DumpRenderTree/mac/EventSendingController.mm:
2112         (-[EventSendingController keyDown:withModifiers:]):
2113         Send capital letters through as lowercase letters with the shift key down
2114         rather than sending them as if they were highly unusual "capital letter keys".
2115
2116         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
2117         where you need to update results and more tests are failing than before.
2118
2119 2007-11-28  Anders Carlsson  <andersca@apple.com>
2120
2121         Reviewed by Darin.
2122
2123         <rdar://problem/5132001>
2124         contextClick is not implemented in DRT on Windows.
2125         
2126         * DumpRenderTree/win/EventSender.cpp:
2127         (contextClickCallback):
2128         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
2129         by a WM_RBUTTONUP message.
2130         
2131         * DumpRenderTree/win/UIDelegate.cpp:
2132         (UIDelegate::hasCustomMenuImplementation):
2133         (UIDelegate::trackCustomPopupMenu):
2134         * DumpRenderTree/win/UIDelegate.h:
2135         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
2136         menu from being shown (and causing the DRT to hang).
2137
2138 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
2139
2140         Reviewed by Darin.
2141
2142         Fix DumpRenderTree ObjC bug comparing strings.
2143
2144         * DumpRenderTree/mac/ObjCController.m:
2145         (-[ObjCController identityIsEqual::]): Compare strings with string
2146         equality instead of identiy equality.
2147
2148 2007-11-27  Timothy Hatcher  <timothy@apple.com>
2149
2150         Reviewed by Sam.
2151
2152         Reset the authorAndUserStylesEnabled preference
2153         back to YES for each test. Fixes the broken tests.
2154
2155         * DumpRenderTree/mac/DumpRenderTree.mm:
2156         (resetWebViewToConsistentStateBeforeTesting):
2157
2158 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
2159
2160         Reviewed by Adam.
2161
2162         - Drosera now displays the console window, although it cannot currently
2163         process JavaScript.
2164
2165         * Drosera/win/DebuggerClient.cpp: Shows the console window.
2166         (registerConsoleClass): Implemented.
2167         (consoleWndProc): Implemented.
2168         (DebuggerClient::onSize): Implemented.
2169         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
2170         new window.
2171         * Drosera/win/DebuggerClient.h: Added needed method and members for 
2172         creating and maintaining a new window.
2173         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
2174         lines of code to more appropriate places.
2175         (Drosera::handleCommand):
2176         (Drosera::initUI):
2177         (Drosera::onSize):
2178         (Drosera::attach):
2179
2180 2007-11-27  Timothy Hatcher  <timothy@apple.com>
2181
2182         Reviewed by Dave Hyatt.
2183
2184         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
2185         
2186         Add support for disabling author and user styles for testing.
2187
2188         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2189         * DumpRenderTree/LayoutTestController.cpp:
2190         (setAuthorAndUserStylesEnabledCallback):
2191         (LayoutTestController::staticFunctions):
2192         * DumpRenderTree/LayoutTestController.h:
2193         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2194         (LayoutTestController::setAuthorAndUserStylesEnabled):
2195         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2196         (LayoutTestController::setAuthorAndUserStylesEnabled):
2197
2198 2007-11-26  Dan Bernstein  <mitz@apple.com>
2199
2200         - Tiger build fix.
2201
2202         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2203
2204 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
2205
2206         Reviewed by Maciej.
2207
2208         - Implemented displaying variables for Drosera on Win.
2209
2210         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
2211         that retrieve variables to not hold onto the return value since it's
2212         not returned.  Also changed to use the new signatures of the retrieval
2213         functions.
2214         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2215         (DebuggerDocument::platformValueForScopeVariableNamed):
2216         * Drosera/win/Drosera.cpp: Removed a needless TODO.
2217         (droseraWndProc):
2218
2219 2007-11-26  Sam Weinig  <sam@webkit.org>
2220
2221         Cleanup names of painting and repainting functions.
2222
2223         Reviewed by Adam Roben.
2224
2225         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2226         (drawSelectionRect): was drawSelectionRectIntoContext.
2227         (dumpWebViewAsPixelsAndCompareWithExpected):
2228         * DumpRenderTree/cg/PixelDumpSupportCG.h:
2229         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2230         (paintWebView): was drawWebViewIntoContext.
2231         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
2232
2233 2007-11-26  Sam Weinig  <sam@webkit.org>
2234
2235         Reviewed by Dan Bernstein.
2236
2237         - Leopard build fix
2238
2239         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2240
2241 2007-11-26  Sam Weinig  <sam@webkit.org>
2242
2243         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
2244         Use shared PixelDumpSupport for Mac DRT
2245
2246         Reviewed by Adam Roben.
2247
2248         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2249         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
2250         * DumpRenderTree/cg/ImageDiffCG.cpp:
2251         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2252         (drawSelectionRectIntoContext):
2253         (dumpWebViewAsPixelsAndCompareWithExpected):
2254         * DumpRenderTree/cg/PixelDumpSupportCG.h:
2255         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2256         * DumpRenderTree/mac/DumpRenderTree.mm:
2257         (dump):
2258         * DumpRenderTree/mac/ImageDiff.m: Removed.
2259         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
2260         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
2261         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
2262         (setDefaultColorProfileToRGB):
2263         (getBitmapContextFromWebView):
2264         (drawWebViewIntoContext):
2265         (repaintWithVerticalSweep):
2266         (repaintWithHorizontalSweep):
2267         (getSelectionRect):
2268         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
2269
2270 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
2271
2272         Bug 16052: prepare-ChangeLog doesn't report deleted files
2273         <http://bugs.webkit.org/show_bug.cgi?id=16052>
2274
2275         Reviewed by Sam.
2276
2277         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
2278
2279 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
2280
2281         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
2282         <http://bugs.webkit.org/show_bug.cgi?id=15864>
2283
2284         Reviewed by Adam.
2285
2286         Roll functionality of merge-changelog into resolve-ChangeLogs
2287         script.  The script now checks for ChangeLog.rej and
2288         ChangeLog.orig files first.  If it finds them, it uses the
2289         ChangeLog.rej file as a patch (in old contextual diff format) to
2290         apply with --fuzz=3.
2291
2292         * Scripts/merge-changelog: Removed.
2293         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
2294
2295 2007-11-25  Sam Weinig  <sam@webkit.org>
2296
2297         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
2298
2299         Reviewed by Mark Rowe.
2300
2301         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2302         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2303         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2304         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
2305         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
2306
2307 2007-11-25  Sam Weinig  <sam@webkit.org>
2308
2309         Convert DumpRenderTree to ues .xcconfig files.
2310
2311         Reviewed by Mark Rowe.
2312
2313         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2314         * DumpRenderTree/mac/Configurations: Added.
2315         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
2316         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
2317         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
2318
2319 2007-11-25  Sam Weinig  <sam@webkit.org>
2320
2321         Add ForwardingHeaders to wtf for DumpRenderTree.
2322
2323         Reviewed by Mark Rowe.
2324
2325         * DumpRenderTree/DumpRenderTree.h:
2326         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2327         * DumpRenderTree/ForwardingHeaders: Added.
2328         * DumpRenderTree/ForwardingHeaders/wtf: Added.
2329         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
2330         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
2331         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
2332         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
2333         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
2334         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
2335         * DumpRenderTree/LayoutTestController.cpp:
2336         * DumpRenderTree/WorkQueue.cpp:
2337         * DumpRenderTree/mac/DumpRenderTree.mm:
2338         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2339         * DumpRenderTree/mac/JavaScriptThreading.cpp:
2340         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2341         * DumpRenderTree/mac/ObjCController.m:
2342         * DumpRenderTree/mac/UIDelegate.mm:
2343         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2344
2345 2007-11-25  Adam Roben  <aroben@apple.com>
2346
2347         Fix some test failures caused by r28019
2348
2349         Now that stdout is in binary mode, we need to always use printf
2350         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
2351         the output.
2352
2353         Reviewed by Sam.
2354
2355         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
2356         printf.
2357         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2358         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2359         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2360         (UIDelegate::webViewAddMessageToConsole):
2361
2362 2007-11-25  Adam Roben  <aroben@apple.com>
2363
2364         Set the font smoothing preference in DRT
2365
2366         This makes the pixel results on Windows closer to the Mac results.
2367
2368         Reviewed by Mitz.
2369
2370         * DumpRenderTree/win/DumpRenderTree.cpp:
2371         (initializePreferences):
2372
2373 2007-11-25  Adam Roben  <aroben@apple.com>
2374
2375         Port ImageDiff to CG and C++
2376
2377         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
2378         <rdar://5071708>
2379
2380         Reviewed by Sam.
2381
2382         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
2383         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
2384         (main):
2385         (createImageFromStdin):
2386         (compareImages):
2387         (getDifferenceBitmap):
2388         (computePercentageDifferent):
2389         * DumpRenderTree/win/ImageDiff.vcproj: Added.
2390
2391 2007-11-25  Adam Roben  <aroben@apple.com>
2392
2393         Fix image diff link generation on Windows
2394
2395         Reviewed by Sam.
2396
2397         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
2398         to toURL.
2399
2400 2007-11-25  Adam Roben  <aroben@apple.com>
2401
2402         Implement pixel dumping in Windows DRT
2403
2404         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
2405         <rdar://5071708>
2406
2407         Reviewed by Sam.
2408
2409         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
2410         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
2411         Content-Length header.
2412         (getMD5HashStringForBitmap):
2413         (dumpWebViewAsPixelsAndCompareWithExpected):
2414         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
2415         * DumpRenderTree/win/DumpRenderTree.cpp:
2416         (dump): Do a pixel dump if requested.
2417         (main): Parse pixel test options.
2418         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
2419         the cg/ subdirectory to the include path.
2420         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
2421         available in a header or import library, so we have to go through this
2422         LoadLibrary/GetProcAddress dance to use them.
2423         (cryptDLL):
2424         (init):
2425         (update):
2426         (final):
2427         (MD5_Init):
2428         (MD5_Update):
2429         (MD5_Final):
2430         * DumpRenderTree/win/MD5.h: Added.
2431         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
2432         moved up to the top level to share it with Mac eventually.
2433         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
2434         (getBitmapContextFromWebView): Forces the WebView to paint using a
2435         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
2436
2437 2007-11-25  Adam Roben  <aroben@apple.com>
2438
2439         Clean up Windows DRT's option parsing a little bit
2440
2441         Reviewed by Sam.
2442
2443         * DumpRenderTree/win/DumpRenderTree.cpp:
2444         (main): Put non-option arguments into a Vector.
2445
2446 2007-11-25  Adam Roben  <aroben@apple.com>
2447
2448         Make Windows DRT stop changing LF into CRLF
2449
2450         Reviewed by Sam.
2451
2452         * DumpRenderTree/win/DumpRenderTree.cpp:
2453         (main): Put stdout in binary mode.
2454         * Scripts/run-webkit-tests: Remove the CRLF hack.
2455
2456 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
2457
2458         Removed empty directory.
2459
2460         * Scripts/resources: Removed.
2461
2462 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
2463
2464         Fix bisect-builds to work with recent WebKit nightly builds.
2465
2466         Reviewed by Dan.
2467
2468         * Scripts/bisect-builds: Check for the 
2469         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
2470         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
2471         to WebKit.app/Contents/Resources.
2472
2473 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
2474
2475         Reviewed by Maciej.
2476
2477         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
2478         not closed (affects digg.com)
2479
2480         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
2481         one after finishing with a test to avoid having its delayed onload handler firing when
2482         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
2483         but it helps somewhat.
2484
2485 2007-11-22  Mark Rowe  <mrowe@apple.com>
2486
2487         Reviewed by Alp Toker.
2488
2489         Fix build-webkit to propagate make's exit status if it fails.
2490
2491         * Scripts/webkitdirs.pm:
2492
2493 2007-11-22  Dan Bernstein  <mitz@apple.com>
2494
2495         Reviewed by Mark Rowe.
2496
2497         - fix crash when running pixel tests
2498
2499         * DumpRenderTree/mac/DumpRenderTree.mm:
2500         (dumpRenderTree): Parse the command line options before setting up the
2501         environment so that we know if we need to set up the pixel dump
2502         machinery.
2503
2504 2007-11-21  Eric Seidel  <eric@webkit.org>
2505
2506         Speculative build fix for Tiger.
2507
2508         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
2509
2510 2007-11-21  Eric Seidel  <eric@webkit.org>
2511
2512         Reviewed by Tim Hatcher.
2513
2514         Break out more of DumpRenderTree.mm into individual files
2515
2516         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2517         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
2518         (checkedMalloc):
2519         (checkedRealloc):
2520         (makeLargeMallocFailSilently):
2521         * DumpRenderTree/mac/CheckedMalloc.h: Added.
2522         * DumpRenderTree/mac/DumpRenderTree.mm:
2523         (crashHandler):
2524         (dump):
2525         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2526         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
2527         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
2528         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2529         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2530         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
2531         (javaScriptThreads):
2532         (runJavaScriptThread):
2533         (startJavaScriptThreads):
2534         (stopJavaScriptThreads):
2535         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
2536         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
2537         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
2538         (restoreColorSpace):
2539         (setDefaultColorProfileToRGB):
2540         (initializeColorSpaceAndScreeBufferForPixelTests):
2541         (md5HashStringForBitmap):
2542         (dumpWebViewAsPixelsAndCompareWithExpected):
2543
2544 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
2545
2546         Move install-unix-extras to wx directory as it seems only to be used by that 
2547         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
2548         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
2549         have install-unix-extras install into WebKitLibraries as per
2550         convention.
2551         
2552         Reviewed by Mark Rowe.
2553
2554         * Scripts/install-unix-extras: Removed.
2555         * wx/build-wxwebkit:
2556         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
2557
2558 2007-11-21  Eric Seidel  <eric@webkit.org>
2559
2560         Reviewed by Adam.
2561
2562         More refactoring for greater code readability
2563
2564         * DumpRenderTree/mac/DumpRenderTree.mm:
2565         (initializeGlobalsFromCommandLineOptions):
2566         (initializeColorSpaceAndScreeBufferForPixelTests):
2567         (addTestPluginsToPluginSearchPath):
2568         (useLongRunningServerMode):
2569         (runTestingServerLoop):
2570         (prepareConsistentTestingEnvironment):
2571         (dumpRenderTree):
2572         (main):
2573         (dumpFramesAsText):
2574         (dumpBackForwardListForWebView):
2575         (sizeWebViewForCurrentTest):
2576         (methodNameStringForFailedTest):
2577         (dumpBackForwardListForAllWindows):
2578         (dumpWebViewAsPixelsAndCompareWithExpected):
2579         (invalidateAnyPreviousWaitToDumpWatchdog):
2580         (dump):
2581         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2582         * DumpRenderTree/mac/UIDelegate.mm:
2583         (-[UIDelegate webView:createWebViewWithRequest:]):
2584
2585 2007-11-21  Eric Seidel  <eric@webkit.org>
2586
2587         Reviewed by Tim Hatcher.
2588
2589         Abstract more of DRT into static methods
2590
2591         * DumpRenderTree/mac/DumpRenderTree.mm:
2592         (setDefaultsToConsistentValuesForTesting):
2593         (setupSignalHandlers):
2594         (allocateGlobalControllers):
2595         (releaseAndZero):
2596         (releaseGlobalControllers):
2597         (dumpRenderTree):
2598         (shouldLogFrameLoadDelegates):
2599         (createCFURLFromPathOrURL):
2600         (resetWebViewToConsistentStateBeforeTesting):
2601         (runTest):
2602
2603 2007-11-21  Eric Seidel  <eric@webkit.org>
2604
2605         Reviewed by Tim Hatcher.
2606
2607         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
2608
2609         * DumpRenderTree/DumpRenderTree.h:
2610         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2611         * DumpRenderTree/mac/DumpRenderTree.mm:
2612         (dumpRenderTree):
2613         (dump):
2614         (runTest):
2615         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
2616         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
2617         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
2618         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
2619         (-[DumpRenderTreePasteboard declareType:owner:]):
2620         (+[LocalPasteboard alloc]):
2621         (-[LocalPasteboard init]):
2622         (-[LocalPasteboard dealloc]):
2623         (-[LocalPasteboard name]):
2624         (-[LocalPasteboard releaseGlobally]):
2625         (-[LocalPasteboard declareTypes:owner:]):
2626         (-[LocalPasteboard addTypes:owner:]):
2627         (-[LocalPasteboard changeCount]):
2628         (-[LocalPasteboard types]):
2629         (-[LocalPasteboard availableTypeFromArray:]):
2630         (-[LocalPasteboard setData:forType:]):
2631         (-[LocalPasteboard dataForType:]):
2632         (-[LocalPasteboard setPropertyList:forType:]):
2633         (-[LocalPasteboard setString:forType:]):
2634         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
2635         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
2636         (+[DumpRenderTreeWindow allWindows]):
2637         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
2638         (-[DumpRenderTreeWindow dealloc]):
2639         (-[DumpRenderTreeWindow isKeyWindow]):
2640         (-[DumpRenderTreeWindow keyDown:]):
2641
2642 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
2643
2644         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
2645         it indiscriminately copies any headers inside JavaScriptCore,
2646         which includes Tiger ICU headers. 
2647
2648         * wx/build-wxwebkit:
2649         Don't run WebCore/move-js-headers.sh any longer.
2650
2651 2007-11-20  Adam Treat  <treat@kde.org>
2652
2653         Reviewed by David Kilzer.
2654
2655         * Prepend git branch name to $baseProductDir
2656
2657         * Scripts/VCSUtils.pm:
2658         * Scripts/webkitdirs.pm:
2659
2660 2007-11-20  Mark Rowe  <mrowe@apple.com>
2661
2662         Reviewed by Simon Hausmann.
2663
2664         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
2665         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
2666         Have it trigger a "make distclean" rather than "make clean" to ensure that the
2667         built product and generated Makefile's are removed.
2668
2669 2007-11-19  Alp Toker  <alp@atoker.com>
2670
2671         Reviewed by Mark Rowe.
2672
2673         http://bugs.webkit.org/show_bug.cgi?id=16040
2674         [GTK] GtkLauncher should be written in C
2675
2676         Port GtkLauncher to plain C.
2677
2678         Use a more conventional GTK+ coding style.
2679
2680         Use a toolbar instead of menus.
2681
2682         Various signature fixes and cleanups.
2683
2684         Add a license header. Assume all previous modifications were copyright
2685         assigned to Apple Inc. by default.
2686
2687         * GtkLauncher/GtkLauncher.pro:
2688         * GtkLauncher/main.c: Added.
2689         (activate_url_entry_cb):
2690         (update_title):
2691         (link_hover_cb):
2692         (title_change_cb):
2693         (progress_change_cb):
2694         (destroy_cb):
2695         (go_back_cb):
2696         (go_forward_cb):
2697         (create_browser):
2698         (create_statusbar):
2699         (create_toolbar):
2700         (create_window):
2701         (main):
2702         * GtkLauncher/main.cpp: Removed.
2703
2704 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
2705
2706         Build script fixes to ensure they do the right thing for the 
2707         wx port, and update build-wxwebkit to reflect the way the
2708         build scripts now work.
2709
2710         Reviewed by Adam.
2711
2712         * Scripts/build-testkjs:
2713         * Scripts/build-webkit:
2714         * Scripts/run-javascriptcore-tests:
2715         * Scripts/webkitdirs.pm:
2716         * wx/build-wxwebkit:
2717
2718 2007-11-18  Eric Seidel  <eric@webkit.org>
2719
2720         Reviewed by Anders.
2721
2722         Make run-javascriptcore-tests report failures on exit (to support git bisect)
2723
2724         * Scripts/run-javascriptcore-tests:
2725
2726 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
2727
2728         Reviewed by Adam Roben.
2729
2730         Make run-webkit-tests work with Windows debug build.
2731
2732         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
2733         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
2734         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
2735         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
2736         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
2737
2738 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
2739
2740         Add wxWebKit sample and build script, and integrate it with 
2741         build-webkit. Also make build-webkit --clean work for all
2742         ports.
2743
2744         Reviewed by Darin Adler.
2745
2746         * Scripts/build-webkit:
2747         * Scripts/webkitdirs.pm:
2748         * wx: Added.
2749         * wx/browser: Added.
2750         * wx/browser/browser.bkl: Added.
2751         * wx/browser/browser.cpp: Added.
2752         * wx/build-wxwebkit: Added.
2753
2754 2007-11-17  Adam Roben  <aroben@apple.com>
2755
2756         Make it easy to run Safari in the debugger on Windows
2757
2758         I've added a new script, debug-safari, which launches Safari in the
2759         debugger. On OS X it just calls gdb-safari.
2760
2761         Reviewed by Mark Rowe.
2762
2763         * FindSafari/FindSafari.cpp:
2764         (_tmain): Added a /debugger flag, which in combination with
2765         /printSafariLauncher will print a script that launches Safari in the
2766         debugger.
2767         * Scripts/debug-safari: Added.
2768         * Scripts/run-safari: Changed to call runSafari().
2769         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
2770         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
2771         first argument along to FindSafari.
2772         * Scripts/webkitdirs.pm:
2773         (sub runSafari): Added.
2774
2775 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
2776
2777         Reviewed by Adam Roben.
2778
2779         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
2780
2781 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
2782
2783         Reviewed by David Kilzer.
2784
2785         The git config command was renamed to repo-config at some point. This
2786         change tries git config and then git repo-config if the first fails.
2787
2788         * Scripts/prepare-ChangeLog:
2789         (gitConfig):
2790
2791 2007-11-16  Dan Bernstein  <mitz@apple.com>
2792
2793         Reviewed by Darin Adler and Sam Weinig.
2794
2795         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
2796
2797         * DumpRenderTree/win/EventSender.cpp:
2798         (keyDownCallback): For characters that cannot be entered on the active
2799         keyboard layout, send a WM_CHAR message with the character along with
2800         a WM_KEYDOWN message with a virtual key code of 255.
2801
2802 2007-11-16  Mark Rowe  <mrowe@apple.com>
2803
2804         Reviewed by Tim Hatcher.
2805
2806         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
2807
2808         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2809         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2810
2811 2007-11-15  Adam Roben  <aroben@apple.com>
2812
2813         Make run-safari actually work on Windows
2814
2815         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
2816         chdir call.
2817
2818 2007-11-14  Adam Roben  <aroben@apple.com>
2819
2820         Updates to Safari launching now that 3.0.4 is released
2821
2822         Reviewed by Sam.
2823
2824         * FindSafari/FindSafari.cpp:
2825         (getWebViewCLSID): Use version-independent ProgID.
2826         * Scripts/run-safari: Use run-webkit-nightly.cmd.
2827
2828 2007-11-14  Anders Carlsson  <andersca@apple.com>
2829
2830         Reviewed by Adam.
2831
2832         <rdar://problem/5309081>
2833         In DRT, "plugin.logDestroy = true" not working on Windows.
2834         
2835         * DumpRenderTree/win/TestNetscapePlugin/main.c:
2836         (NPP_Destroy):
2837
2838 2007-11-14  Eric Seidel  <eric@webkit.org>
2839
2840         Reviewed by Sam.
2841
2842         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
2843
2844 2007-11-14  Anders Carlsson  <andersca@apple.com>
2845
2846         Reviewed by Adam.
2847
2848         <rdar://problem/5141186>
2849         window.layoutTestController.setWindowIsKey is not implemented in DRT.
2850         
2851         Implement setWindowIsKey.
2852         
2853         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2854         (LayoutTestController::setWindowIsKey):
2855
2856 2007-11-13  Sam Weinig  <sam@webkit.org>
2857
2858         Reviewed by Adam Roben.
2859
2860         Fix for <rdar://problem/5382579>
2861         http/tests/security/cross-frame-access-put.html reports large 
2862         negative numbers for screenLeft and screenTop (Mac reports "0")
2863
2864         * DumpRenderTree/win/UIDelegate.cpp:
2865         (UIDelegate::UIDelegate): Initialize the RECT.
2866         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
2867         (UIDelegate::webViewFrame): ditto.
2868         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
2869
2870 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
2871
2872         Reviewed by Adam.
2873
2874         - Make Drosera show source, source URLs, and function stack on Windows,
2875         and some minor fixes.
2876
2877         * Drosera/DebuggerDocument.cpp: Force source to always update display.
2878         (DebuggerDocument::updateFileSource):
2879         * Drosera/debugger.js: Force source to always update display.
2880         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
2881         menu controls.
2882         (DebuggerClient::resume):
2883         (DebuggerClient::pause):
2884         (DebuggerClient::stepInto):
2885         (DebuggerClient::stepOver):
2886         (DebuggerClient::stepOut):
2887         (DebuggerClient::showConsole):
2888         (DebuggerClient::closeCurrentFile):
2889         * Drosera/win/DebuggerClient.h: Ditto.
2890         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
2891         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
2892         removed two bugs.  1) caller could be in a bad state when asked to
2893         assign into it. 2) BSTRs were not created correctly.
2894         (DebuggerDocument::getPlatformCurrentFunctionStack):
2895         * Drosera/win/Drosera.cpp: Hook up the menu controls.
2896         (droseraWndProc):
2897         (handleCommand):
2898         (Drosera::resume):
2899         (Drosera::pause):
2900         (Drosera::stepInto):
2901         (Drosera::stepOver):
2902         (Drosera::stepOut):
2903         (Drosera::showConsole):
2904         (Drosera::closeCurrentFile):
2905         * Drosera/win/Drosera.h: Hook up the menu controls.
2906         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
2907         functions, added a null check, and fixed another bug where caller could
2908         be in a bad state when asked to assign into it.
2909         (ServerConnection::didLoadMainResourceForDataSource):
2910         (ServerConnection::getCallerFrame):
2911         * Drosera/win/ServerConnection.h: Safety first.
2912
2913 2007-11-13  Dan Bernstein  <mitz@apple.com>
2914
2915         Reviewed by Darin Adler.
2916
2917         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
2918           DumpRenderTree --pixel-tests renders each test twice
2919
2920         * DumpRenderTree/mac/DumpRenderTree.mm:
2921         (dumpRenderTree): Removed the --paint option because the painting code
2922         is always exercised as a result of
2923         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
2924         calling -displayIfNeeded.
2925         (dump): Changed to always grab the image from the window since the view
2926         is always displayed.
2927         (runTest):
2928         (displayWebView):
2929         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
2930         because it always paints.
2931
2932 2007-11-12  Antti Koivisto  <antti@apple.com>
2933
2934         Reviewed by Adele.
2935         
2936         Add support for http media tests
2937
2938         * Scripts/run-webkit-tests:
2939
2940 2007-11-12  Sam Weinig  <sam@webkit.org>
2941
2942         Reviewed by Adam Roben.
2943
2944         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
2945
2946         * DumpRenderTree/win/DumpRenderTree.cpp:
2947         (runTest):
2948         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2949         (LayoutTestController::setPrivateBrowsingEnabled):
2950
2951 2007-11-12  Adam Roben  <aroben@apple.com>
2952
2953         * Scripts/update-webkit-localizable-strings: Changed to only scan the
2954         mac and win subdirectories.
2955
2956 2007-11-11  Adam Roben  <aroben@apple.com>
2957
2958         Fix <rdar://5133816> keepWebHistory is not implemented
2959
2960         Fixes fast/history/clicked-link-is-visited.html.
2961
2962         Reviewed by Darin.
2963
2964         * DumpRenderTree/win/DumpRenderTree.cpp:
2965         (runTest): Clear the optionalSharedHistory.
2966         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2967         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
2968
2969 2007-11-10  Sam Weinig  <sam@webkit.org>
2970
2971         Reviewed by Tim Hatcher.
2972
2973         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
2974         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
2975         is turned on)
2976
2977         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
2978
2979         Added test: http/tests/security/cross-frame-access-private-browsing.html
2980
2981         * DumpRenderTree/LayoutTestController.cpp:
2982         (setPrivateBrowsingEnabledCallback):
2983         (LayoutTestController::staticFunctions):
2984         * DumpRenderTree/LayoutTestController.h:
2985         * DumpRenderTree/mac/DumpRenderTree.mm:
2986         (runTest): Default to private browsing disabled.
2987         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2988         (LayoutTestController::setPrivateBrowsingEnabled):
2989         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2990         (LayoutTestController::setPrivateBrowsingEnabled):
2991
2992 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
2993
2994         Reviewed by Adam.
2995
2996         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
2997         WebCore's!
2998
2999         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
3000         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
3001         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
3002         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
3003         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
3004         * Drosera/win/Drosera.cpp:
3005         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
3006
3007 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
3008
3009         Reviewed by Sam.
3010
3011         - Use the new IWebFrame [local] function signature and get the shared
3012         server correctly.
3013
3014         * Drosera/win/DebuggerClient.cpp:
3015         (DebuggerClient::didFinishLoadForFrame):
3016         * Drosera/win/ServerConnection.cpp:
3017         (ServerConnection::attemptToCreateServerConnection):
3018
3019 2007-11-07  Dan Bernstein  <mitz@apple.com>
3020
3021         Reviewed by Darin Adler.
3022
3023         - add an option to run-webkit-tests to ignore pixel test failures where
3024           all pixels differ by no more than a specified threshold
3025
3026         * DumpRenderTree/mac/ImageDiff.m:
3027         (main):
3028         (compareImages):
3029         (computePercentageDifferent):
3030         * Scripts/run-webkit-tests:
3031
3032 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3033
3034         Reviewed by Lars.
3035
3036         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
3037
3038         * DumpRenderTree/qt/DumpRenderTree.cpp:
3039
3040 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3041
3042         Reviewed by Lars.
3043
3044         Reworked the QWebSettings API.
3045         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
3046
3047         * DumpRenderTree/qt/DumpRenderTree.cpp:
3048
3049 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3050
3051         Reviewed by Lars.
3052
3053         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
3054
3055         * DumpRenderTree/qt/jsobjects.cpp:
3056
3057 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3058
3059         Reviewed by Lars Knoll <lars@trolltech.com>.
3060
3061         Add a QWebPage::frameCreated() signal and fix DRT
3062         
3063         The removal of createFrame in QWebPage broke the re-implementation
3064         in DumpRenderTree. Instead emit a frameCreated() signal and
3065         connect to it in DumpRenderTree.
3066         
3067
3068         * DumpRenderTree/qt/DumpRenderTree.cpp:
3069         (WebCore::WebPage::WebPage):
3070         (WebCore::DumpRenderTree::dump):
3071         (WebCore::DumpRenderTree::connectFrame):
3072         * DumpRenderTree/qt/DumpRenderTree.h:
3073
3074 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3075
3076         Reviewed by Lars Knoll <lars@trolltech.com>.
3077
3078         Moved all the event handlers from QWebFrame into QWebPage.
3079         
3080         This cleans up the public API and allows us to remove the
3081         HackWebFrame hack in DumpRenderTree.
3082         
3083
3084         * DumpRenderTree/qt/jsobjects.cpp:
3085         (EventSender::mouseDown):
3086         (EventSender::mouseUp):
3087         (EventSender::mouseMoveTo):
3088
3089 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3090
3091         Reviewed by Mark.
3092
3093         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
3094         to prevent the default implementation from popping up messageboxes.
3095
3096         * DumpRenderTree/qt/DumpRenderTree.cpp:
3097         (WebCore::WebPage::javaScriptConfirm):
3098         (WebCore::WebPage::javaScriptPrompt):
3099
3100 2007-11-06  Eric Seidel  <eric@webkit.org>
3101
3102         * Scripts/build-testkjs: build fix... too many $$
3103
3104 2007-11-06  Eric Seidel  <eric@webkit.org>
3105
3106         Reviewed by Mark Rowe.
3107
3108         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
3109
3110 2007-11-05  Adam Roben  <aroben@apple.com>
3111
3112         Add support on Windows for WEBKIT_TESTFONTS
3113
3114         This environment variable lets you specify where the fonts to be used
3115         by DumpRenderTree reside. The Qt port is already using this, so I'm
3116         just following their lead.
3117
3118         Reviewed by Darin.
3119
3120         * DumpRenderTree/win/DumpRenderTree.cpp:
3121         (exePath): Refactored code out of initialize().
3122         (fontsPath): Returns either $WEBKIT_TESTFONTS or
3123         DumpRenderTree.resources.
3124         (initialize): Use the new fontsPath function.
3125         (main): Use the new exePath function.
3126         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
3127         variable to DRT, like Qt does.
3128
3129 2007-11-05  Mark Rowe  <mrowe@apple.com>
3130
3131         Rubber-stamped by Alp Toker.
3132
3133         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
3134
3135         * GtkLauncher/main.cpp:
3136         (goToURLBarText):
3137         (main):
3138
3139 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
3140
3141         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
3142         <http://bugs.webkit.org/show_bug.cgi?id=15830>
3143
3144         Reviewed by Timothy.
3145
3146         Restrict the range of nightly builds used by the bisect-builds script
3147         based on the version of Safari and the version of Mac OS X being used.
3148
3149         Mac OS X 10.4: Safari 2.0: r11976 or newer
3150         Mac OS X 10.4: Safari 3.0: r19992 or newer
3151
3152         Mac OS X 10.5: Safari 2.0: r19594 or newer
3153         Mac OS X 10.5: Safari 3.0: r25124 or newer
3154
3155         * Scripts/bisect-builds:
3156         (findMacOSXVersion): Added.
3157         (makeNightlyList): Added argument to provide version of Mac OS X.
3158         Restrict range of nightly builds based on Safari and Mac OS X versions.
3159
3160 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
3161
3162         Reviewed by Maciej.
3163
3164         - This patch involves several changes, all of them were noticed that
3165         they were needed by the work being done in WebKit to get Drosera and
3166         WebKit working together on Windows.
3167         - The changes are:
3168         1) Added a debugger console for output messages.
3169         2) Drosera now listens for the WebKit server (before, the server would
3170         have to be running before Drosera was started.)
3171         3) Fixed a bug where the WebView started out as 0x0 pixels.
3172         4) Fixed a bug when there is no scope.
3173         5) Added the HTML, JS, and CSS to the project file to make them easy to
3174         find.
3175         6) Made the ServerConnection functions virtual.
3176
3177         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
3178         for the WebKit server.
3179         (DebuggerClient::DebuggerClient):
3180         (DebuggerClient::~DebuggerClient):
3181         (DebuggerClient::didFinishLoadForFrame):
3182         (DebuggerClient::serverConnected):
3183         (DebuggerClient::attemptToCreateServerConnection):
3184         * Drosera/win/DebuggerClient.h: Ditto.
3185         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
3186         scope.
3187         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3188         (DebuggerDocument::platformValueForScopeVariableNamed):
3189         * Drosera/win/Drosera.cpp:
3190         (_tWinMain): Added a console in debug for output messages.
3191         (Drosera::Drosera): Listen for server.
3192         (Drosera::initUI): The server now Initializes COM.
3193         (Drosera::serverConnected): Part of the listening for the server.
3194         (Drosera::attemptToCreateServerConnection): Ditto.
3195         * Drosera/win/Drosera.h: New interface for listening for the server.
3196         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
3197         files to the VS project.
3198         * Drosera/win/ServerConnection.cpp: Part of listening for the server
3199         connection.
3200         (ServerConnection::ServerConnection):
3201         (ServerConnection::attemptToCreateServerConnection):
3202         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
3203         methods.
3204         (ServerConnection::serverConnected):
3205
3206 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
3207
3208         Reviewed by Maciej.
3209
3210         http://bugs.webkit.org/show_bug.cgi?id=15832
3211         fast/dom/gc-10.html crashes when run alone
3212
3213         Check for !done before using objects that can be already deallocated.
3214
3215         * DumpRenderTree/mac/EditingDelegate.mm:
3216         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
3217         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
3218         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
3219         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
3220         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
3221         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
3222         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
3223         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
3224         (-[EditingDelegate webViewDidBeginEditing:]):
3225         (-[EditingDelegate webViewDidChange:]):
3226         (-[EditingDelegate webViewDidEndEditing:]):
3227         (-[EditingDelegate webViewDidChangeTypingStyle:]):
3228         (-[EditingDelegate webViewDidChangeSelection:]):
3229         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3230         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
3231         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
3232         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3233         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
3234         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
3235         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
3236         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3237         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
3238         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
3239         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
3240         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
3241         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
3242         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
3243         (-[FrameLoadDelegate webView:willCloseFrame:]):
3244         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
3245         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
3246         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3247         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
3248         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3249         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
3250         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
3251         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
3252         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
3253
3254 2007-11-04  Mark Rowe  <mrowe@apple.com>
3255
3256         Build fix.  Don't use Carbon.h as the prefix header as it triggers
3257         warnings that would otherwise be suppressed due to it being a system header.
3258
3259         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3260
3261 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
3262
3263         Rubber stamped by Adam.
3264         
3265         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
3266
3267         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3268
3269 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
3270
3271         Sort files(...); sections of Xcode project files.
3272
3273         Rubber-stamped by Darin.
3274
3275         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
3276         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3277         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3278         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
3279
3280 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
3281
3282         Script to sort "files(...);" sections in Xcode project.pbxproj files.
3283
3284         Reviewed by Darin.
3285
3286         * Scripts/sort-Xcode-project-file: Added.
3287
3288 2007-11-02  Darin Adler  <darin@apple.com>
3289
3290         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
3291
3292 2007-11-02  Darin Adler  <darin@apple.com>
3293
3294         Reviewed by Maciej.
3295
3296         * Scripts/run-sunspider: Pass the "--base" option through.
3297
3298         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
3299         the real script do that. Default configuration to Release to match run-sunspider
3300         so we don't end up building Debug just to compare results.
3301
3302 2007-11-01  Adam Roben  <aroben@apple.com>
3303
3304         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
3305
3306         Reviewed by Sam.
3307
3308         * Scripts/commit-log-editor: Show all the directories beneath the
3309         source root, instead of just the last one.
3310
3311 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
3312
3313         Reviewed by Adam Roben.
3314
3315         Print out an error message when the Windows build fails
3316         and provide guidance on how to find out what went wrong.
3317
3318         * Scripts/build-webkit:
3319         * Scripts/webkitdirs.pm:
3320
3321 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
3322
3323         Rubber-stamped by Adam Roben.
3324
3325         Rolled out r27326 - debug CRT seems to cause no problems after all.
3326
3327         * DumpRenderTree/win/DumpRenderTree.vcproj:
3328
3329 2007-10-31  Adam Roben  <aroben@apple.com>
3330
3331         Switch the Debug configuration to using the non-debug CRT
3332
3333         This matches WebKit.
3334
3335         Reviewed by Steve.
3336
3337         * DumpRenderTree/win/DumpRenderTree.vcproj:
3338
3339 2007-10-31  Antti Koivisto  <antti@apple.com>
3340
3341         Reviewed by bdash.
3342         
3343         Disable media tests when doing leak checking on Tiger.
3344         They crash in QuickTime (rdar://problem/5537157).
3345
3346         * Scripts/run-webkit-tests:
3347
3348 2007-10-29  Antti Koivisto  <antti@apple.com>
3349
3350         Reviewed by Maciej.
3351         
3352         Build media support by default on OSX only.
3353
3354         * Scripts/build-webkit:
3355
3356 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3357
3358         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
3359         get caught by the pre-commit hooks.
3360
3361 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3362
3363         Reviewed by Adam.
3364
3365         - This is a collection of relatively unrelated changes and cleanups
3366         to Drosera to prepare it for interacting with WebKit.  A lot of these
3367         changes are just correcting mistakes, for example removing included
3368         headers that are no longer needed.
3369
3370         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
3371         this will be needed by the DebuggerClient.
3372         (DebuggerDocument::server):
3373         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
3374         * Drosera/win/DebuggerClient.cpp: 
3375         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
3376         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
3377         (DebuggerClient::createWebViewWithRequest): Added comment about its
3378         purpose. 
3379         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
3380         declarations.
3381         (DebuggerClient::webViewLoaded): Moved.
3382         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
3383         file, since this was the only place it was used.
3384         (cfStringToBSTR):
3385         * Drosera/win/Drosera.h: Cleaned up the includes.
3386         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
3387         * Drosera/win/HelperFunctions.h: Removed.
3388
3389 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3390
3391         Reviewed by Adam.
3392
3393         - Small cleanup in the ServerConnection class.
3394
3395         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
3396         and added an include.
3397         (ServerConnection::currentFrame):
3398         (ServerConnection::getCallerFrame):
3399         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
3400         made a pointer into a COMPtr, and cleaned up the includes.
3401
3402 2007-10-29  Timothy Hatcher  <timothy@apple.com>
3403
3404         Reviewed by John Sullivan.
3405         
3406         - Place the Localizable.strings file in mac or win directories
3407           if that location exists.
3408         - Also look for UI_STRING in .c files.
3409
3410         * Scripts/extract-localizable-strings:
3411
3412 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3413
3414         Reviewed by Adam.
3415
3416         - Set the eol-style to native and made all the line endings the same
3417         so that I avoid messy diffs that show eol changes.
3418
3419         * Drosera/win/ServerConnection.cpp:
3420         (ServerConnection::didParseSource):
3421         (ServerConnection::didEnterCallFrame):
3422         (ServerConnection::willExecuteStatement):
3423         (ServerConnection::willLeaveCallFrame):
3424         (ServerConnection::exceptionWasRaised):
3425
3426 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3427
3428         Reviewed by Adam.
3429
3430         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
3431         functionality that could not have existed previously without the new
3432         interfaces.
3433         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
3434         from a BSTR to a JSValueRef.
3435         (DebuggerDocument::platformEvaluateScript): Implemented.
3436         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
3437         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3438         Implemented.
3439         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
3440         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
3441         * Drosera/win/ServerConnection.cpp: Added a helper function.
3442         (ServerConnection::getCallerFrame):
3443         * Drosera/win/ServerConnection.h: Added a helper function.
3444
3445 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
3446
3447         updated reviewers for my previous changelog.
3448
3449 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
3450         Reviewed by Maciej and Adam and Geoff.
3451
3452         - Minor mac-side improvements including moving a function to a more
3453         appropriate location, fixing a warning, and correctly checking
3454         exceptions.
3455
3456         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
3457         (DebuggerDocument::willExecuteStatement):
3458         (DebuggerDocument::didEnterCallFrame):
3459         (DebuggerDocument::willLeaveCallFrame):
3460         (DebuggerDocument::windowScriptObjectAvailable):
3461         (DebuggerDocument::callFunctionOnObject):
3462         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
3463         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
3464         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
3465         because it doesn't require the ServerConnection at all.
3466         (NSStringCreateWithJSStringRef): Made an argument const.
3467         (JSValueRefCreateWithNSString): Made an argument const.
3468         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
3469         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3470         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
3471         * Drosera/mac/ServerConnection.mm: Ditto.
3472         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
3473
3474 2007-10-29  Sam Weinig  <sam@webkit.org>
3475
3476         Reviewed by Adam Roben.
3477
3478         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
3479
3480         * DumpRenderTree/LayoutTestController.cpp:
3481         (LayoutTestController::LayoutTestController):
3482         (getGlobalFlagCallback):
3483         (setGlobalFlagCallback):
3484         (LayoutTestController::getJSClass):
3485         (LayoutTestController::staticValues):
3486         * DumpRenderTree/LayoutTestController.h:
3487         (LayoutTestController::globalFlag):
3488         (LayoutTestController::setGlobalFlag):
3489
3490 2007-10-29  Darin Adler  <darin@apple.com>
3491
3492         Reviewed by Maciej.
3493
3494         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
3495         resolution instead of its default.
3496
3497 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
3498
3499         Fixed showStatus() to print status for successfully resolved conflicts when using git.
3500
3501         Reviewed by Mark Rowe.
3502
3503         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
3504         was successfully resolved, but this would not show any status because the change had
3505         already been cached in the index using "git add".  The solution is to add an optional
3506         second argument to showStatus() which adds the "--cached" switch to the command.
3507
3508         * Scripts/resolve-ChangeLogs:
3509         (showStatus):
3510
3511 2007-10-28  Eric Seidel  <eric@webkit.org>
3512
3513         Reviewed by Maciej and Geoff, in unison.
3514
3515         * Scripts/run-webkit-tests: remove broken --svg option
3516
3517 2007-10-28  Darin Adler  <darin@apple.com>
3518
3519         Reviewed by Adam.
3520
3521         * Scripts/run-sunspider: Default to "Release" configuration rather than
3522         defaulting to the last configuration used as other scripts do. This can
3523         still be overriden on the command line with "--debug" if there's some
3524         reason to do so. Also fix a typo.
3525
3526         * Scripts/sunspider-compare-results: Fix a typo.
3527
3528 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
3529
3530         Reviewed by Adam.
3531
3532         - Implemented the WebScriptDebugListener functions now that the
3533         WebScriptDebugServer exists
3534
3535         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
3536         functions.
3537         (ServerConnection::currentFrame):
3538         (ServerConnection::didLoadMainResourceForDataSource):
3539         (ServerConnection::didParseSource):
3540         (ServerConnection::failedToParseSource):
3541         (ServerConnection::didEnterCallFrame):
3542         (ServerConnection::willExecuteStatement):
3543         (ServerConnection::willLeaveCallFrame):
3544         (ServerConnection::exceptionWasRaised):
3545         * Drosera/win/ServerConnection.h: Removed unused arguments from the
3546         members arguments list.
3547
3548 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
3549
3550         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
3551         <http://bugs.webkit.org/show_bug.cgi?id=15600>
3552
3553         Reviewed by Darin.
3554
3555         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
3556         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
3557         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
3558         file.  Note that it may also be used as a stand-alone script.
3559
3560         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
3561         * Scripts/resolve-ChangeLogs: Added.
3562         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
3563
3564 2007-10-26  Mark Rowe  <mrowe@apple.com>
3565
3566         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
3567         to the Qt port on the assumption that it was an implementation of the cross-platform
3568         LayoutTestController class.  It is not, so it did not need to be changed.
3569
3570         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
3571
3572 2007-10-25  Mark Rowe  <mrowe@apple.com>
3573
3574         Reviewed by Maciej.
3575
3576         Fix builds with code coverage enabled.
3577
3578         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
3579
3580 2007-10-25  Darin Adler  <darin@apple.com>
3581
3582         Reviewed by Mark Rowe.
3583
3584         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
3585         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
3586
3587 2007-10-25  Stephanie  <slewis@apple.com>
3588
3589         build Fix
3590
3591         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3592
3593 2007-10-25  Stephanie  <slewis@apple.com>
3594
3595         Reviewed by Mark Rowe, Adam Roben.
3596
3597         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
3598
3599         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
3600
3601 2007-10-25  Alice Liu  <alice.liu@apple.com>
3602
3603         Reviewed by Adam.
3604
3605         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
3606
3607         Moving destructor into platform-specific files
3608         * DumpRenderTree/LayoutTestController.cpp:
3609         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3610         (LayoutTestController::~LayoutTestController):
3611         * DumpRenderTree/qt/jsobjects.cpp:
3612         (LayoutTestController::~LayoutTestController):
3613
3614         LayoutTestController wasn't being destroyed
3615         * DumpRenderTree/win/DumpRenderTree.cpp:
3616         (runTest):
3617
3618         Added declspec
3619         * DumpRenderTree/win/EditingDelegate.h:
3620
3621         Reset certain values on the webview (or related delegate) that might 
3622         have changed while running a test
3623         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3624         (LayoutTestController::~LayoutTestController):
3625
3626 2007-10-25  Adam Roben  <aroben@apple.com>
3627
3628         Make sunspider-compare-results work with relative paths
3629
3630         Reviewed by Sam.
3631
3632         * Scripts/sunspider-compare-results: Convert arguments to absolute
3633         paths before we chdir.
3634
3635 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
3636
3637         Reviewed by Sam.
3638
3639         - Implemented server calls now the WebScriptDebugServer exists.
3640         - Also removed no longer needed call to initialize CG.
3641
3642         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
3643         automatically now.
3644         (_tWinMain):
3645         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
3646         (ServerConnection::ServerConnection):
3647         (ServerConnection::~ServerConnection):
3648         (ServerConnection::pause):
3649         (ServerConnection::resume):
3650         (ServerConnection::stepInto):
3651         (ServerConnection::applicationTerminating):
3652         (ServerConnection::serverConnectionDidDie):
3653         * Drosera/win/ServerConnection.h: Now uses the COM class.
3654
3655 2007-10-24  George Staikos  <staikos@kde.org>
3656
3657         Unbreak Qt build.
3658
3659         * Scripts/build-webkit:
3660
3661 2007-10-24  Adam Roben  <aroben@apple.com>
3662
3663         Remove now-unnecessary call to InitializeCoreGraphics
3664
3665         WebKit takes care of this now.
3666
3667         Reviewed by Ada.
3668
3669         * DumpRenderTree/win/DumpRenderTree.cpp:
3670         (initialize):
3671
3672 2007-10-24  Adam Roben  <aroben@apple.com>
3673
3674         Use WebTextRenderer in DRT
3675
3676         Reviewed by Ada.
3677
3678         * DumpRenderTree/win/DumpRenderTree.cpp:
3679         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
3680
3681 2007-10-24  Sven Herzberg  <sven@imendio.com>
3682
3683         Reviewed by Mark Rowe.
3684
3685         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
3686         Bug 15614: [GTK] qmake based backends don't build on OS X
3687
3688         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
3689         GTK backend on a Mac
3690         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
3691         isDarwin() to make it reusable in other places (like the workaround-
3692         for-prebuilt-qmake in build-webkit)
3693
3694 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
3695
3696         Refurbish update-webkit script.
3697
3698         Reviewed by Adam.
3699
3700         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
3701         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
3702         multi-argument version of system() for flexibility and security.  Check for existence
3703         of Internal directory using -d test instead of -x.
3704
3705 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
3706
3707         Minor clean-up of prepare-ChangeLog script.
3708
3709         Reviewed by Adam.
3710
3711         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
3712         of a string.  Use multi-argument versions of open() and system() for flexibility and
3713         security.
3714
3715 2007-10-24  Alice Liu  <alice.liu@apple.com>
3716
3717         Reviewed by Oliver.
3718
3719         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
3720
3721         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
3722         replay the saved events when we're still processing the mousedown that starts the drag
3723         * DumpRenderTree/win/EventSender.cpp:
3724         (doMouseMove):
3725         * DumpRenderTree/win/UIDelegate.cpp:
3726         (UIDelegate::doDragDrop):
3727
3728 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
3729
3730         Reviewed by Sam, Steve and Darin.
3731
3732         - Stubbed out the WebScriptDebugListener functionality in the Server
3733         Connection class to prepare it for receiving those callbacks.
3734         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
3735         and the ServerConnection to not need to be initialized with a server
3736         name, since that is not the way we connect to the WebKit server. 
3737
3738         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
3739         no exception.  Now it only loggs when there is an exception
3740         (DebuggerDocument::willExecuteStatement):
3741         (DebuggerDocument::didEnterCallFrame):
3742         (DebuggerDocument::willLeaveCallFrame):
3743         (DebuggerDocument::windowScriptObjectAvailable):
3744         (DebuggerDocument::callFunctionOnObject):
3745         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
3746         to be instantiated with a server's name.
3747         (DebuggerClient::DebuggerClient):
3748         (DebuggerClient::didFinishLoadForFrame):
3749         * Drosera/win/DebuggerClient.h: Removed unsued variable.
3750         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
3751         a server name.
3752         (Drosera::init):
3753         (Drosera::initServer):
3754         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
3755         instantiated with a server's name.
3756         * Drosera/win/ServerConnection.cpp: 
3757         (ServerConnection::ServerConnection): No longer needs a server name
3758         (ServerConnection::~ServerConnection): Only release the global context
3759         if there is one.
3760         (ServerConnection::serverConnectionDidDie): Stub for
3761         IWebScriptDebugListener
3762         (ServerConnection::QueryInterface): ditto
3763         (ServerConnection::AddRef): ditto
3764         (ServerConnection::Release): ditto
3765         (ServerConnection::didLoadMainResourceForDataSource): ditto
3766         (ServerConnection::didParseSource): ditto
3767         (ServerConnection::failedToParseSource): ditto
3768         (ServerConnection::didEnterCallFrame): ditto
3769         (ServerConnection::willExecuteStatement): ditto
3770         (ServerConnection::willLeaveCallFrame): ditto
3771         (ServerConnection::exceptionWasRaised): ditto
3772         * Drosera/win/ServerConnection.h: Stubbed out the
3773         IWebScriptDebugListener functions, and this class no longer needs to be
3774         instantiated with a server name.
3775
3776 2007-10-24  Lars Knoll  <lars@trolltech.com>
3777
3778         Reviewed by Simon.
3779
3780         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
3781
3782         * DumpRenderTree/qt/jsobjects.h:
3783
3784 2007-10-24  Lars Knoll  <lars@trolltech.com>
3785
3786         Reviewed by Simon.
3787
3788         add another command.
3789
3790         * DumpRenderTree/qt/jsobjects.cpp:
3791         (TextInputController::doCommand):
3792
3793 2007-10-24  Lars Knoll  <lars@trolltech.com>
3794
3795         Reviewed by Simon.
3796
3797         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
3798
3799         * DumpRenderTree/qt/jsobjects.cpp:
3800         (EventSender::keyDown):
3801         * DumpRenderTree/qt/jsobjects.h:
3802
3803 2007-10-24  Lars Knoll  <lars@trolltech.com>
3804
3805         Reviewed by Simon.
3806
3807         implement eventSender.keyDown().
3808
3809         * DumpRenderTree/qt/jsobjects.cpp:
3810         (EventSender::keyDown):
3811
3812 2007-10-24  Lars Knoll  <lars@trolltech.com>
3813
3814         Reviewed by Simon.
3815
3816         some smaller fixes to the editing support in DRT. Makes another few tests pass.
3817
3818         * DumpRenderTree/qt/DumpRenderTree.cpp:
3819         (WebCore::DumpRenderTree::DumpRenderTree):
3820         (WebCore::DumpRenderTree::initJSObjects):
3821         * DumpRenderTree/qt/jsobjects.cpp:
3822         (TextInputController::doCommand):
3823
3824 2007-10-24  Lars Knoll  <lars@trolltech.com>
3825
3826         Reviewed by Simon.
3827
3828         first bit of implementation for the textinputcontroller.
3829
3830         * DumpRenderTree/qt/DumpRenderTree.cpp:
3831         (WebCore::DumpRenderTree::DumpRenderTree):
3832         * DumpRenderTree/qt/DumpRenderTree.h:
3833         * DumpRenderTree/qt/jsobjects.cpp:
3834         (TextInputController::TextInputController):
3835         (TextInputController::doCommand):
3836         * DumpRenderTree/qt/jsobjects.h:
3837
3838 2007-10-24  Lars Knoll  <lars@trolltech.com>
3839
3840         Reviewed by Simon.
3841
3842         make the man webpage believe it has focus, so the editing tests work correctly.
3843
3844         * DumpRenderTree/qt/DumpRenderTree.cpp:
3845         (WebCore::DumpRenderTree::DumpRenderTree):
3846
3847 2007-10-24  Lars Knoll  <lars@trolltech.com>
3848
3849         Reviewed by Simon.
3850
3851         implement layoutTestController.dumpEditingCallbacks() correctly.
3852
3853         * DumpRenderTree/qt/DumpRenderTree.cpp:
3854         (WebCore::DumpRenderTree::DumpRenderTree):
3855         * DumpRenderTree/qt/jsobjects.cpp:
3856         (LayoutTestController::reset):
3857         (LayoutTestController::dumpEditingCallbacks):
3858
3859 2007-10-24  Lars Knoll  <lars@trolltech.com>
3860
3861         Reviewed by Simon.
3862
3863         Implement support for testing editing.
3864
3865         * DumpRenderTree/qt/DumpRenderTree.cpp:
3866         (WebCore::DumpRenderTree::DumpRenderTree):
3867
3868 2007-10-23  Sam Weinig  <sam@webkit.org>
3869
3870         Check for null BSTR that can be passed to the UIDelegate methods
3871         from javascript null and undefined.  Fixes a failing test case on
3872         Windows (fast/dom/Window/alert-undefined.html)
3873
3874         Reviewed by Eric Seidel.
3875
3876         * DumpRenderTree/win/UIDelegate.cpp:
3877         (UIDelegate::runJavaScriptAlertPanelWithMessage):
3878         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
3879         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
3880         (UIDelegate::webViewAddMessageToConsole):
3881
3882 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
3883
3884         Reviewed by Darin.
3885         
3886         Don't print a massive pile of setenvs from tools that automatically build testkjs.
3887
3888         * Scripts/build-testkjs:
3889
3890 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
3891
3892         Reviewed by Darin.
3893
3894         - add wrapper that finds the right copy of testkjs
3895         
3896         * Scripts/sunspider-compare-results: Added.
3897
3898 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
3899
3900         Reviewed by Sam.
3901
3902         - After talking with Steve I now see that the WebKit server must be
3903         running for DCOM to create the distributed objects, which makes sense
3904         and currently WebKit only allows one instance to be running at a time
3905         which avoids accidentally connecting to the wrong server
3906         - In light of this I have removed the code for the attach box and
3907         NotificationServer and known server names, since they are all extranious
3908         now.
3909
3910         * Drosera/win/Drosera.cpp: Removed notification classes and known server
3911         names.
3912         (_tWinMain): Uses init instead of initUI.
3913         (droseraWndProc): No longer creats an attach dialog box.
3914         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
3915         it's not manditory to call init before doing COM stuff.
3916         (Drosera::init): calls initUI and will call attach when the
3917         functionality exists. 
3918         (Drosera::initUI): Has changed very little.
3919         (Drosera::attach): Changed the signature to reflect that we no longer
3920         need the dictionary of known server names.
3921         * Drosera/win/Drosera.h: Removed notification classes and known server
3922         names.  Also renamed and moved some functions.
3923         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
3924         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
3925         headers to the resources folder. 
3926         * Drosera/win/resource.h: Removed the Attach box.
3927
3928 2007-10-22  Adam Roben  <aroben@apple.com>
3929
3930         Windows build fix
3931
3932         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
3933
3934 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
3935
3936         - Removed a leak that was fixed.
3937
3938         * Scripts/run-webkit-tests:
3939
3940 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3941
3942         Reviewed by Darin.
3943
3944         - Changed the Client so that the DebuggerDocument now own the
3945         ServerConnection.  This simplifies ownership and cleanup. 
3946
3947         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
3948         ServerConnection.
3949         (DebuggerClient::initWithServerName):
3950         (DebuggerClient::didFinishLoadForFrame):
3951         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
3952         ServerConnection.
3953         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
3954         until after we have a server which we are attached to.
3955         (Drosera::initUI):
3956         (Drosera::attach):
3957         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
3958         out previously.
3959
3960 2007-10-22  Simon Hausmann  <hausmann@kde.org>
3961
3962         Reviewed by Nikolas.
3963
3964         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
3965
3966         * Scripts/run-javascriptcore-tests:
3967
3968 2007-10-22  Simon Hausmann  <hausmann@kde.org>
3969
3970         Reviewed by Nikolas.
3971
3972         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
3973
3974         * Scripts/build-drosera:
3975         * Scripts/build-dumprendertree:
3976         * Scripts/build-testkjs:
3977         * Scripts/build-webkit:
3978         * Scripts/run-javascriptcore-tests:
3979         * Scripts/run-sunspider:
3980         * Scripts/run-webkit-tests:
3981         * Scripts/webkitdirs.pm:
3982
3983 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
3984
3985         Reviewed by Mark Rowe.
3986         
3987         Fix for local database support after r26879
3988         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
3989
3990         * Scripts/build-webkit:
3991
3992 2007-10-22  Holger Freyther  <zecke@selfish.org>
3993
3994         Reviewed by Simon Hausmann <hausmann@kde.org>.
3995
3996         - Do not build testkjs as an application bundle. This is
3997         needed for run-javascriptcore-tests on OSX.
3998         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
3999         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
4000         as we do not have -rpath on OSX.
4001
4002         * DumpRenderTree/qt/DumpRenderTree.pro:
4003         * Scripts/run-webkit-tests:
4004
4005 2007-10-22  Simon Hausmann  <hausmann@kde.org>
4006
4007         Reviewed by aroben.
4008
4009         Fix support for Signed-off-by detection in prepare-ChangeLog
4010         --git-commit. The Signed-off-by tag does not appear in the header
4011         but usually at the end.
4012
4013         * Scripts/prepare-ChangeLog:
4014
4015 2007-10-21  Mark Rowe  <mrowe@apple.com>
4016
4017         Reviewed by Eric.
4018
4019         Fix run-javascriptcore-tests for Gtk.
4020
4021         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
4022
4023 2007-10-20  Eric Seidel  <eric@webkit.org>
4024
4025         Reviewed by aroben.
4026
4027         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
4028
4029 2007-10-20  Eric Seidel  <eric@webkit.org>
4030
4031         Reviewed by darin.
4032         
4033         Add improved argument handling to run-sunspider, including
4034         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
4035         Also re-factor code into subroutines
4036
4037         * Scripts/build-dumprendertree: removed bogus comments
4038         * Scripts/build-testkjs: Added.
4039         * Scripts/run-javascriptcore-tests: use build-testkjs
4040         * Scripts/run-sunspider: improved argument handling, abstraction
4041         * Scripts/run-webkit-tests: improved abstraction
4042
4043 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
4044
4045         Not reviewed, Windows build fix.
4046
4047         * DumpRenderTree/win/EventSender.cpp:
4048         (keyDownCallback):
4049
4050 2007-10-20  Darin Adler  <darin@apple.com>
4051
4052         Reviewed by Tim Hatcher.
4053
4054         - http://bugs.webkit.org/show_bug.cgi?id=15544
4055           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
4056           not rely on Apple-specific key codes
4057
4058         * DumpRenderTree/mac/EventSendingController.mm:
4059         (-[EventSendingController keyDown:withModifiers:]):
4060         Added named key "rightArrow". Later we could have a whole table of these.
4061         Also tweaked modifiers code a little.
4062
4063         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
4064
4065 2007-10-19  Darin Adler  <darin@apple.com>
4066
4067         Reviewed by Eric.
4068
4069         - http://bugs.webkit.org/show_bug.cgi?id=15566
4070           possible fix for leak seen in DumpRenderTree
4071
4072         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
4073         Delete the item if it's not put on the queue, since the caller has
4074         no way of knowing that. Would be better to have the parameter type
4075         be auto_ptr to express the fact that we take ownership.
4076
4077         - unrelated change
4078
4079         * Drosera/mac/main.m: Add missing include.
4080
4081 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
4082
4083         Reviewed by Adam.
4084
4085         - This change should be identical but for some reason was not working
4086         on my machine.
4087
4088         * Scripts/prepare-ChangeLog:
4089
4090 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
4091
4092         Reviewed by Oliver and Tim.
4093
4094         - Made use of RetainPtr to avoid retain and release issues and moved the
4095         log function to DebuggerDocumentPlatform, which seems to be a more
4096         logical place for it to live.
4097         - Also moved knownServers from the ServerConnection to
4098         DebuggerApplication to match the Windows code and because it makes sense
4099         that a connection knows its own server but not all of them.
4100
4101         * Drosera/mac/DebuggerClient.h: Moved the log function to
4102           DebuggerDocumentPlatform.
4103         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
4104           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
4105           call for the server name up from the ServerConnection class.
4106         (-[DebuggerClient dealloc]):
4107         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
4108           for the server name up from the ServerConnection.
4109         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
4110         (DebuggerDocument::platformPause):
4111         (DebuggerDocument::platformResume):
4112         (DebuggerDocument::platformStepInto):
4113         (DebuggerDocument::platformEvaluateScript):
4114         (DebuggerDocument::getPlatformCurrentFunctionStack):
4115         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
4116         (DebuggerDocument::platformValueForScopeVariableNamed):
4117         (DebuggerDocument::platformLog): Log directly from here. No need to call
4118           DebuggerClient.
4119         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
4120           way I see it, a ServerConnection should only know about its connection
4121           and the group of all possible servers should be kept by the
4122           application.
4123         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
4124           currentServerName, it makes sense that the connection should know that
4125           name.
4126         (-[ServerConnection currentServerName]):
4127
4128 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
4129
4130         Reviewed by Adam.
4131
4132         - Integrated changes from mac drosera.  Recently I've encapsulated
4133         out the server connection object from the rest of Drosera because
4134         it is very platform dependent right now and RPC is not implemented on
4135         windows.  This functionality, of communicating with the WebKit server
4136         is the next area I will be focusing on in Windows.
4137
4138         - Other changes and cleanup were made to organize the code and add notes
4139         on which parts still need work.  Also some mac code is added and
4140         commented out, to act as pseudocode for the logic of those parts.
4141
4142         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
4143           pointer.
4144         * Drosera/config.h: Added whitespace.
4145         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
4146           these files got moved into Drosera.h/cpp
4147         * Drosera/win/DebuggerApplication.h: Removed.
4148         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
4149           happened here to better match the logic flow of the same code on the 
4150           mac side and to use the new ServerConnection class.
4151         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
4152         (DebuggerClient::initWithServerName): Initializer that will set up the
4153           class to use a ServerConnection object.  This was necessary so I could
4154           create a DebuggerClient without having to initilaize it at
4155           construction.
4156         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
4157           will be the UIDelegate and FrameLoadDelegate.
4158         (DebuggerClient::AddRef): For IUnknown.
4159         (DebuggerClient::Release): For IUnknown.
4160         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
4161           this still needs to set the global context of the server, but
4162           IWebFrame does not have an accessor for the global context yet. 
4163         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
4164           this is a pass through for the same function in the document.
4165         (DebuggerClient::didReceiveTitle): Unimplemented part of
4166           FrameLoadDelegate this would change the title of the window.
4167         (DebuggerClient::createWebViewWithRequest): Part of the
4168           FrameLoadDelegate.  This is about new windows via Window.open() and
4169           how their delegates are set.
4170         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
4171           UIDelegate.  Just a debug function for printing messages.
4172         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
4173           because the Client should be the UIDelegate and FrameLoadDelegate
4174           to match the delegates on mac.
4175         (DebuggerClient::webViewLoaded): Added accessor method.
4176         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
4177           forgotten to add this file before.  This is where the platform
4178           dependent versions of the Documents functions live. Most of these are
4179           unimplemented because some piece of functionality does not exist on
4180           Windows yet.
4181         (DebuggerDocument::platformPause):
4182         (DebuggerDocument::platformResume):
4183         (DebuggerDocument::platformStepInto):
4184         (DebuggerDocument::platformEvaluateScript):
4185         (DebuggerDocument::getPlatformCurrentFunctionStack):
4186         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
4187         (DebuggerDocument::platformValueForScopeVariableNamed):
4188         (DebuggerDocument::platformLog):
4189         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
4190           responsibilities becaue they belong in the Client. Also I laid the
4191           groundwork for attaching Drosera to a WebKit process
4192         (attachWndProc): Now if a server is selected the Client becomes it's
4193           delegate.
4194         (Drosera::Drosera): Added the construction of the Client and dictionary
4195           of server names. 
4196         (Drosera::initUI): This is no longer the delegates, the Client is.
4197         (Drosera::webViewLoaded): Now asks the Client instead of holding local
4198           state. 
4199         (Drosera::applicationDidFinishLaunching): Placeholder for needed
4200           notification registration when it's possible to implement.
4201         (Drosera::serverLoaded): Ditto
4202         (Drosera::serverUnloaded): Ditto
4203         (Drosera::attach): Attach Drosera to the WebKit server.
4204         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
4205         (Drosera::getInst): 
4206         (Drosera::setInst):
4207         (Drosera::knownServers):
4208         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
4209           and added the ServerConnection.
4210         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
4211         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
4212           Most of the functions are completely unimlemented because they cannot
4213           connect with the WebKit server, because one does not exist on Windows
4214           yet.
4215         (ServerConnection::initWithServerName): 
4216         (ServerConnection::~ServerConnection):
4217         (ServerConnection::setGlobalContext):
4218         (ServerConnection::pause):
4219         (ServerConnection::resume):
4220         (ServerConnection::stepInto):
4221         (ServerConnection::switchToServerNamed):
4222         (ServerConnection::applicationTerminating):
4223         (ServerConnection::serverConnectionDidDie):
4224         (ServerConnection::currentFrame):
4225         * Drosera/win/ServerConnection.h: Added. Ditto.
4226         (ServerConnection::ServerConnection):
4227
4228 2007-10-19  Alice Liu  <alice.liu@apple.com>
4229
4230         Reviewed by Darin.
4231
4232         Fix for these broken layout tests on Windows:
4233         
4234         fast/forms/focus-selection-input.html
4235         fast/forms/focus-selection-textarea.html
4236         fast/forms/select-accesskey.html
4237         
4238         * DumpRenderTree/win/EventSender.cpp:
4239         (keyDownCallback):
4240         correct the VK code for alt key.
4241         
4242 2007-10-19  Eric Seidel  <eric@webkit.org>
4243
4244         Reviewed by Mark Rowe.
4245         
4246         Make the GtkLauncher code slightly more readable.
4247
4248         * GtkLauncher/main.cpp:
4249         (setupMainMenu): Added.
4250         (setupMainWindowUI): Added.
4251         (main):
4252
4253 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
4254
4255         Rubber stamped by Adam.
4256         
4257         - don't delay-load WebKit in DumpRenderTree.
4258
4259         * DumpRenderTree/win/DumpRenderTree.vcproj:
4260
4261 2007-10-18  Dan Bernstein  <mitz@apple.com>
4262
4263         Reviewed by Adam Roben.
4264
4265         - fix <rdar://problem/5313523>
4266         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
4267
4268         * DumpRenderTree/mac/DumpRenderTree.mm:
4269         (dump): Changed to use _responseMIMEType.
4270
4271 2007-10-17  Adam Roben  <aroben@apple.com>
4272
4273         Make it possible to have Windows-specific tests and results
4274
4275         When searching for tests to run and the Skipped file, we will only
4276         look in platform/win and the cross-platform directory. When looking
4277         for expected results, we will look in platform/win, then
4278         platform/mac-leopard, then platform/mac, then finally the
4279         cross-platform directory.
4280
4281         Reviewed by Sam.
4282
4283         * Scripts/run-webkit-tests:
4284         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
4285         searching in the cross-platform directory.
4286         (sub buildPlatformHierarchy): Removed some unneeded calls to
4287         dirname/basename.
4288
4289 2007-10-17  Adam Roben  <aroben@apple.com>
4290
4291         Add back the call to register WebKit that we had before WebKitInitializer existed
4292
4293         This is needed to ensure that the right WebKit is used when
4294         instantiating COM objects.
4295
4296         Reviewed by Oliver.
4297
4298         * DumpRenderTree/win/debug_internal.vsprops: Define
4299         DEBUG_WEBKIT_HAS_SUFFIX.
4300         * DumpRenderTree/win/DumpRenderTree.cpp:
4301  &n