2010-10-06 Balazs Kelemen <kbalazs@webkit.org>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
2
3         Reviewed by Kenneth Rohde Christiansen.
4
5         [Qt] Add WebKitTestRunner's build files
6         https://bugs.webkit.org/show_bug.cgi?id=44155
7
8         Parts was taken by Zoltan Horvath's patch.
9
10         * Scripts/generate-forwarding-headers.pl: Moved from WebKit2.
11         * Scripts/webkitdirs.pm: Make the generated files needed by WTR.
12         * WebKitTestRunner/PlatformWebView.h: Addeed typedefs for
13         PlatformWKView and PlatformWindow (void* for now).
14         Buildfix the case when __APPLE__ is not defined.
15         * WebKitTestRunner/qt/DerivedSources.pro: Added.
16         * WebKitTestRunner/qt/PlatformWebViewQt.cpp: Added.
17         Empty stub implementation.
18         (WTR::registerWindowClass):
19         (WTR::PlatformWebView::PlatformWebView):
20         (WTR::PlatformWebView::~PlatformWebView):
21         (WTR::PlatformWebView::resizeTo):
22         (WTR::PlatformWebView::page):
23         (WTR::PlatformWebView::focus):
24         * WebKitTestRunner/qt/TestControllerQt.cpp: Added.
25         Empty stub implementation.
26         (WTR::registerWindowClass):
27         (WTR::TestController::runUntil):
28         (WTR::TestController::platformInitialize):
29         (WTR::TestController::initializeInjectedBundlePath):
30         (WTR::TestController::initializeTestPluginDirectory):
31         (WTR::TestController::platformInitializeContext):
32         * WebKitTestRunner/qt/WebKitTestRunner.pro: Added.
33         * WebKitTestRunner/qt/main.cpp: Added.
34         (main):
35
36 2010-10-06  Tony Chang  <tony@chromium.org>
37
38         Unreviewed, rolling out r69202.
39         http://trac.webkit.org/changeset/69202
40         https://bugs.webkit.org/show_bug.cgi?id=46937
41
42         Broke compile of test_shell
43
44         * DumpRenderTree/chromium/EventSender.cpp:
45         (EventSender::beginDragWithFiles):
46         * DumpRenderTree/chromium/WebViewHost.cpp:
47         (addDRTFakeFileToDataObject):
48
49 2010-10-06  Daniel Cheng  <dcheng@chromium.org>
50
51         Reviewed by Tony Chang.
52
53         [chromium] Minor naming cleanup in WebDragData, part 2
54         https://bugs.webkit.org/show_bug.cgi?id=46937
55
56         Update DRT to use the renamed methods.
57
58         * DumpRenderTree/chromium/EventSender.cpp:
59         (EventSender::beginDragWithFiles):
60         * DumpRenderTree/chromium/WebViewHost.cpp:
61         (addDRTFakeFileToDataObject):
62
63 2010-10-06  David Kilzer  <ddkilzer@apple.com>
64
65         <http://webkit.org/b/47270> Move WebArchive serialization code into its own file
66
67         Reviewed by Adam Roben.
68
69         This is the first step in making webarchive tests work on
70         Windows.
71
72         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added
73         new files to the project.
74         * DumpRenderTree/mac/DumpRenderTree.mm: Removed code that moved
75         to WebArchiveDumpSupport.mm.
76         * DumpRenderTree/mac/WebArchiveDumpSupport.h: Added.
77         * DumpRenderTree/mac/WebArchiveDumpSupport.mm: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm.
78         (serializeWebArchiveToXML):
79
80 2010-10-05  Daniel Bates  <dbates@rim.com>
81
82         Reviewed by David Kilzer.
83
84         Add infrastructure to towards detecting change log diffs that aren't at the top of the ChangeLog
85         https://bugs.webkit.org/show_bug.cgi?id=46058
86
87         Make VCSUtils::fixChangeLogPatch() return a reference to a hash
88         structure so as to support returning additional information
89         about a change log diff.
90
91         Currently, VCSUtils::fixChangeLogPatch() returns a string that
92         represents the change log diff. Towards supporting the return
93         of additional information, such as whether the change log diff
94         inserts an entry at the top of the ChangeLog file, we need to
95         make VCSUtils::fixChangeLogPatch() return a reference to hash
96         structure.
97
98         * Scripts/VCSUtils.pm:
99           - Modified fixChangeLogPatch() to return a reference to a
100             hash structure.
101           - Added documentation to fixChangeLogPatch().
102           - Modified call site in mergeChangeLogs() as necessary.
103         * Scripts/svn-apply:
104           - Modified call site in patch() as necessary.
105         * Scripts/svn-create-patch:
106           - Modified call site in generateDiff() as necessary.
107         * Scripts/svn-unapply:
108           - Modified call site in patch() as necessary.
109         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
110           - Modified the unit tests as necessary.
111
112 2010-10-05  Tony Chang  <tony@chromium.org>
113
114         Reviewed by Darin Adler.
115
116         fix the link to the expected image on windows
117         https://bugs.webkit.org/show_bug.cgi?id=47228
118
119         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: On
120             windows, the file must be opened in binary mode when writing
121             binary data.
122
123 2010-10-05  Adam Barth  <abarth@webkit.org>
124
125         Update expected result of unittest to match Tony's change below.
126
127         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
128
129 2010-10-05  Tony Chang  <tony@chromium.org>
130
131         Reviewed by Ojan Vafai (over the shoulder).
132
133         Paper over errors in image_diff so we don't crash the whole test run.
134
135         * Scripts/webkitpy/layout_tests/port/chromium.py:
136
137 2010-10-05  Tony Chang  <tony@chromium.org>
138
139         Unreviewed, make shutil.rmtree more resiliant to errors
140         since windows was raising WindowsError: The process cannot access the file because it
141         is being used by another process.
142
143         * Scripts/webkitpy/layout_tests/port/chromium.py:
144
145 2010-10-05  Tony Chang  <tony@chromium.org>
146
147         Reviewed by Ojan Vafai.
148
149         [chromium] fix image diffing in NRWT
150         https://bugs.webkit.org/show_bug.cgi?id=47128
151
152         * Scripts/webkitpy/layout_tests/port/chromium.py: Stop using
153             NamedTemporaryFile since it doesn't work on Windows.
154         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
155
156 2010-10-05  Kenneth Russell  <kbr@google.com>
157
158         Reviewed by Tony Chang.
159
160         [chromium] Implement layerTreeAsText in DumpRenderTree
161         https://bugs.webkit.org/show_bug.cgi?id=47216
162
163         Plumbed Frame::layerTreeAsText through Chromium's WebKit API to
164         make it callable from DumpRenderTree.
165
166         No new tests; verified with existing compositor layout tests.
167
168         * DumpRenderTree/chromium/LayoutTestController.cpp:
169         (LayoutTestController::LayoutTestController):
170         (LayoutTestController::layerTreeAsText):
171         * DumpRenderTree/chromium/LayoutTestController.h:
172
173 2010-10-05  Brent Fulgham  <bfulgham@webkit.org>
174
175         Unreviewed build correction.
176
177         * DumpRenderTree/win/ImageDiff.vcproj: Use WinCairo debug
178         property sheet so proper libraries are linked.
179
180 2010-10-05  Robert Hogan  <robert@webkit.org>
181
182         Reviewed by Andreas Kling.
183
184         [Qt] Fix url conversion in QWebHistory
185
186         Converting from KURL to WFT::String to QUrl does not
187         permit proper percent encoding later.
188
189         https://bugs.webkit.org/show_bug.cgi?id=47048
190
191         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
192         (WebCore::dumpHistoryItem):
193
194 2010-10-05  Anders Carlsson  <andersca@apple.com>
195
196         Reviewed by Sam Weinig.
197
198         REGRESSION (r68966?): All dumpAsText test fail on WebKit2
199         https://bugs.webkit.org/show_bug.cgi?id=47188
200         <rdar://problem/8514104>
201
202         When constructing the std::string, use the real string length instead of the maximum buffer size.
203
204         * TestWebKitAPI/PlatformUtilities.h:
205         (TestWebKitAPI::Util::toSTD):
206         * WebKitTestRunner/StringFunctions.h:
207         (WTR::toSTD):
208
209 2010-10-04  Sam Weinig  <sam@webkit.org>
210
211         Reviewed by Mark Rowe.
212
213         Add MIMEType accessor to WKFrame
214         <rdar://problem/8347683>
215         https://bugs.webkit.org/show_bug.cgi?id=47138
216
217         * TestWebKitAPI/PlatformUtilities.h:
218         (TestWebKitAPI::Util::toSTD):
219         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
220         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp: Added.
221         (TestWebKitAPI::didStartProvisionalLoadForFrame):
222         (TestWebKitAPI::didCommitLoadForFrame):
223         (TestWebKitAPI::didFinishLoadForFrame):
224         (TestWebKitAPI::TEST):
225         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp: Added.
226         (TestWebKitAPI::didStartProvisionalLoadForFrame):
227         (TestWebKitAPI::didCommitLoadForFrame):
228         (TestWebKitAPI::didFinishLoadForFrame):
229         (TestWebKitAPI::TEST):
230         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
231         (TestWebKitAPI::TEST):
232         * TestWebKitAPI/Tests/WebKit2/basic-1.html: Removed.
233         * TestWebKitAPI/Tests/WebKit2/icon.png: Added.
234         * TestWebKitAPI/Tests/WebKit2/simple.html: Added.
235         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
236         (TestWebKitAPI::Util::createURLForResource):
237
238 2010-10-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
239
240         Reviewed by Ojan Vafai.
241
242         [NRWT] Rename current_dir to current_group because it's not a directory
243         https://bugs.webkit.org/show_bug.cgi?id=47169
244
245         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
246         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
247
248 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
249
250         Unreviewed, build fix.
251
252         r69065 broke test-webkitpy by trying to create a '/tmp-X' directory,
253         which can't always be done. This test uses tempfile.mkdtemp(), which
254         should be safe.
255
256         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
257
258 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
259
260         Unreviewed, build fix.
261
262         Add missing "from __future__ import with_statement" that was
263         breaking test-webkitpy on the Leopard bots (broke in r69040).
264
265         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
266
267 2010-10-04  Sheriff Bot  <webkit.review.bot@gmail.com>
268
269         Unreviewed, rolling out r69066.
270         http://trac.webkit.org/changeset/69066
271         https://bugs.webkit.org/show_bug.cgi?id=47163
272
273         Made NRWT reliability worse. (Requested by tkent on #webkit).
274
275         * Scripts/webkitpy/layout_tests/port/chromium.py:
276         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
277
278 2010-10-04  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
279
280         Reviewed by Tony Chang.
281
282         [NRWT] Reverse the http tests to alphabetical order.
283         https://bugs.webkit.org/show_bug.cgi?id=47075
284
285         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
286
287 2010-10-04  Robert Hogan  <robert@webkit.org>
288
289         Reviewed by Andreas Kling.
290
291         [Qt] Fix timeout on http/tests/navigation/post-goback2.html and postredirect-goback2.html
292
293         We need to queue back and forward navigations in the DRT from the
294         LayoutTestController so that maybeDump() knows about them.
295
296         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
297         (LayoutTestController::queueBackNavigation):
298         (LayoutTestController::queueForwardNavigation):
299
300 2010-10-04  Tony Chang  <tony@chromium.org>
301
302         Reviewed by Kent Tamura.
303
304         [chromium] fix image diffing in NRWT
305         https://bugs.webkit.org/show_bug.cgi?id=47128
306
307         * Scripts/webkitpy/layout_tests/port/chromium.py: Flush data to the
308               temp file and check the image_diff error code more carefully
309         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
310
311 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
312
313         Reviewed by Adam Barth.
314
315         aroben's change in r68792 actually broke new-run-webkit-tests when
316         running the DRT code path. His change was intended to fix the
317         way we were converting windows paths to URIs when running under
318         Cygwin (the paths were getting one too many "/" on the front).
319         However, the change ended up breaking the chromium_win port, which
320         had slightly different logic.
321
322         This patch removes the port-specific code and adds tests to make
323         sure we're getting the behavior we expect. The Port object no longer
324         exposes a get_absolute_path() method that can be used outside of
325         of converting test filenames, because it's unreliable otherwise
326         (we don't have the right context to know which conversion is intended).
327
328         https://bugs.webkit.org/show_bug.cgi?id=47140
329
330         * Scripts/webkitpy/layout_tests/port/base.py:
331         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
332         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
333         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
334         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
335
336 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
337
338         Unreviewed, build fix.
339
340         Handle crash introduced in r69040 if we are not running in a
341         Chromium checkout.
342
343         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
344
345 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
346
347         Reviewed by Tony Chang.
348
349         Add a way for us to have test expectations that are specific to the
350         official builds of Google Chrome (as opposed to Chromium). This change
351         looks for an additional "test_expectations_chrome.txt" file in
352         Chromium's repository (webkit/tools/layout_tests), and uses the
353         concatenation of that file and the regular test_expectations.txt
354         file for test overrides.
355
356         https://bugs.webkit.org/show_bug.cgi?id=46854
357
358         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
359         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
360
361 2010-10-04  Simon Fraser  <simon.fraser@apple.com>
362
363         Color tests in the list based on existing pass/fail result.
364         
365         Fix the summary data to account for htmlOnly and nonHTML tests.
366
367         * CSSTestSuiteHarness/harness/harness.css:
368         (#test-list > option.pass):
369         (#test-list > option.fail):
370         (#test-list > option.skipped):
371         * CSSTestSuiteHarness/harness/harness.js:
372         (Test):
373         (Test.prototype.statusForFormat):
374         (TestSuite.prototype.fillTestList):
375         (TestSuite.prototype.updateTestList):
376         (TestSuite.prototype.recordResult):
377         (TestSuite.prototype.markTestCompleted):
378         (TestSuite.prototype.countTestsWithFlag):
379         (TestSuite.prototype.queryDatabaseForSummary.this.db.transaction):
380         (TestSuite.prototype.queryDatabaseForSummary):
381
382 2010-10-04  Chris Fleizach  <cfleizach@apple.com>
383
384         Reviewed by Beth Dakin.
385
386         AX: doAXRangeForLine does not work
387         https://bugs.webkit.org/show_bug.cgi?id=47101
388
389         DRT support to handle NSAccessibilityRangeForLineParameterizedAttribute.
390
391         * DumpRenderTree/AccessibilityUIElement.cpp:
392         (rangeForLineCallback):
393         (AccessibilityUIElement::rangeForLine):
394         (AccessibilityUIElement::getJSClass):
395         * DumpRenderTree/AccessibilityUIElement.h:
396         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
397         (AccessibilityUIElement::rangeForLine):
398
399 2010-10-04  Andrey Kosyakov  <caseq@chromium.org>
400
401         Unreviewed. Adding myself to the committers list.
402
403         * Scripts/webkitpy/common/config/committers.py:
404
405 2010-10-04  Sam Weinig  <sam@webkit.org>
406
407         Reviewed by Anders Carlsson.
408
409         Add ability to set the CacheModel in Webkit2
410         https://bugs.webkit.org/show_bug.cgi?id=47066
411
412         * MiniBrowser/mac/AppDelegate.m:
413         (-[BrowserAppDelegate init]): Opt minibrowser into
414         a PrimaryWebBrowser cache model.
415
416 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
417
418         Make sure to enter all tests when creating the database
419         for the first time.
420         
421         When migrating to a new version of the suite, be sure to
422         sync up the database and testinfo.data by removing old
423         tests, and inserting new ones.
424
425         * CSSTestSuiteHarness/harness/harness.js:
426         (TestSuite.prototype.openDatabase.creation):
427         (TestSuite.prototype.databaseCreated):
428         (TestSuite.prototype.populateDatabaseFromTestInfoData):
429         (TestSuite.prototype.insertTest):
430
431 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
432
433         More work on treating HTML4 and XHTML1 independently; when 
434         changing the format, rebuild the test list, and update the 
435         numbers in the chapter popup.
436
437         * CSSTestSuiteHarness/harness/harness.js:
438         (Test):
439         (Test.prototype.runForFormat):
440         (Test.prototype.completedForFormat):
441         (ChapterSection):
442         (ChapterSection.prototype.countTests):
443         (Chapter):
444         (Chapter.prototype.description):
445         (Chapter.prototype.countTests):
446         (Chapter.prototype.testCount):
447         (Chapter.prototype.untestedCount):
448         (TestSuite.prototype.buildChapters):
449         (TestSuite.prototype.loadCurrentTest):
450         (TestSuite.prototype.updateProgressLabel):
451         (TestSuite.prototype.processFlags):
452         (TestSuite.prototype.formatChanged):
453
454 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
455
456         Update test suite version 20101001.
457         
458         Handle database migration, and delete tests from the db that are
459         not present in testinfo.data.
460         
461         Load about:blank into the test frame before the test url, to make
462         missing tests more obvious.
463         
464         * CSSTestSuiteHarness/harness/harness.js:
465         (TestSuite.prototype.loadTest):
466         (TestSuite.prototype.openDatabase.creation):
467         (TestSuite.prototype.openDatabase.migration1_0To1_1):
468         (TestSuite.prototype.openDatabase.if.return):
469         (TestSuite.prototype.databaseReady):
470         (TestSuite.prototype.populateDatabaseFromTestInfoData):
471         (TestSuite.prototype.syncDatabaseWithTestInfoData.this.db.transaction):
472         (TestSuite.prototype.syncDatabaseWithTestInfoData):
473
474 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
475
476         Add the ability to jump to a specific test.
477
478         * CSSTestSuiteHarness/harness/harness.html:
479         * CSSTestSuiteHarness/harness/harness.js:
480         (TestSuite.prototype.goToTestByName):
481         (TestSuite.prototype.switchToFormat):
482
483 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
484
485         For a ref test, load the ref in the same format (HTML4 vs XHTML1)
486         as the test.
487
488         * CSSTestSuiteHarness/harness/harness.js:
489         (TestSuite.prototype.loadRef):
490
491 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
492
493         Update the UI to reflect the fact that each test needs to be tested
494         in both HTML4 and XHTML1 format.
495         
496         * CSSTestSuiteHarness/harness/harness.js:
497         (Test):
498         (Chapter.prototype.description):
499         (Chapter.prototype.untestedCount):
500         (TestSuite.prototype.fillChapterPopup):
501         (TestSuite.prototype.updateChapterPopup):
502         (TestSuite.prototype.fillTestList):
503         (TestSuite.prototype.updateTestList):
504         (TestSuite.prototype.goToNextIncompleteTest):
505         (TestSuite.prototype.firstIncompleteTestIndex):
506         (TestSuite.prototype.recordResult):
507         (TestSuite.prototype.formatChanged):
508         (TestSuite.prototype.markTestCompleted):
509         (TestSuite.prototype.resetTestStatus):
510
511 2010-10-01  Simon Fraser  <simon.fraser@apple.com>
512
513         Add the ability to remove results for re-testing, and
514         to import results.
515
516         * CSSTestSuiteHarness/harness/harness.css:
517         (.custom button):
518         (#overlay):
519         (#overlay.visible):
520         (.overlay-contents):
521         (.overlay-contents textarea):
522         (.overlay-contents .buttons):
523         (.overlay-contents .note):
524         (.overlay-contents .buttons button):
525         * CSSTestSuiteHarness/harness/harness.html:
526         * CSSTestSuiteHarness/harness/harness.js:
527         (TestSuite.prototype.importResults):
528         (TestSuite.prototype.clearResults):
529         (TestSuite.prototype.markTestCompleted):
530         (TestSuite.prototype.resetTestStatus):
531         (TestSuite.prototype.storeTestResult):
532         (TestSuite.prototype.importTestResults):
533         (TestSuite.prototype.clearTestResults):
534
535 2010-10-01  Sam Weinig  <sam@webkit.org>
536
537         Reviewed by Jon Honeycutt.
538
539         Deploy the new WKString functions to remove most uses of CF from
540         the WebKitTestRunner.
541
542         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
543         (WTR::InjectedBundle::didReceiveMessage):
544         (WTR::InjectedBundle::done):
545         * WebKitTestRunner/StringFunctions.h:
546         (WTR::toWK):
547         (WTR::toJS):
548         (WTR::toSTD):
549         (WTR::operator<<):
550         (WTR::copyURLString):
551         * WebKitTestRunner/TestController.cpp:
552         (WTR::TestController::resetStateToConsistentValues):
553         (WTR::TestController::didFinishLoadForFrame):
554         * WebKitTestRunner/TestInvocation.cpp:
555         (WTR::TestInvocation::invoke):
556         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
557
558 2010-10-01  Mihai Parparita  <mihaip@chromium.org>
559
560         Unreviewed TestResultsServer change.
561
562         Add files introduced by http://crrev.com/61273 to the list of dashboard 
563         files to update.
564
565         * TestResultServer/handlers/dashboardhandler.py:
566
567 2010-10-01  Brian Weinstein  <bweinstein@apple.com>
568
569         Build Fix for Windows.
570
571         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Don't copy ForwardingHeaders from
572             WebKitTestRunner/ForwardingHeaders, instead, add $(WebKitOutputDir)/include/WebCore/
573             ForwardingHeaders to the include path.
574
575 2010-10-01  Sam Weinig  <sam@webkit.org>
576
577         Reviewed by Anders Carlsson.
578
579         Add SPI to convert a WKStringRef to a JSStringRef and vice-versa.
580
581         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
582         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
583         (TestWebKitAPI::TEST):
584         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp: Added.
585         (TestWebKitAPI::TEST):
586
587 2010-10-01  Sam Weinig  <sam@webkit.org>
588
589         Reviewed by Kenneth Rohde Christiansen.
590
591         Add additional WKString API
592         https://bugs.webkit.org/show_bug.cgi?id=46958
593
594         Add basic WKStringRef tests.
595
596         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
597         * TestWebKitAPI/Tests/WebKit2/WKString.cpp: Added.
598
599 2010-10-01  Sam Weinig  <sam@webkit.org>
600
601         Reviewed by Dan Bernstein.
602
603         Add makefile for TestWebKitAPI and call it from the base makefile.
604
605         * Makefile:
606         * TestWebKitAPI/Makefile: Added.
607
608 2010-10-01  Sam Weinig  <sam@webkit.org>
609
610         Reviewed by Adam Roben.
611
612         Remove unnecessary ForwardingHeaders from test runners.
613         https://bugs.webkit.org/show_bug.cgi?id=47010
614
615         * TestWebKitAPI/Configurations/Base.xcconfig:
616         * TestWebKitAPI/ForwardingHeaders: Removed.
617         * WebKitTestRunner/Configurations/Base.xcconfig:
618         * WebKitTestRunner/ForwardingHeaders: Removed.
619
620 2010-09-30  Adam Barth  <abarth@webkit.org>
621
622         Reviewed by Eric Seidel.
623
624         WebSocket tests are flaky
625         https://bugs.webkit.org/show_bug.cgi?id=46956
626
627         Update these tools to understand how to run the WebSocket tests off the
628         Apache server.
629
630         * Scripts/old-run-webkit-tests:
631         * Scripts/webkitpy/layout_tests/port/base.py:
632         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
633         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
634
635 2010-10-01  Adam Roben  <aroben@apple.com>
636
637         Encode Executive command arguments using UTF-8 on Cygwin
638
639         Cygwin's Python's os.execv doesn't support unicode command arguments.
640         Cygwin's execv expects arguments to be encoded using the current code
641         page. But code pages are limited in what characters they can handle,
642         and our tests include characters that the English code page can't
643         handle.  So for now we'll just encode everything in UTF-8 on Cygwin,
644         which can handle all characters but might confuse some commands, for
645         expediency's sake. I'm sure we'll run into cases where UTF-8 isn't
646         good enough, but we can deal with that when the problem arises.
647
648         Reviewed by Adam Barth.
649
650         Fixes <http://webkit.org/b/46892> <rdar://problem/8496639>
651         webkitpy.common.system.executive_unittest.ExecutiveTest.test_run_command_with_unicode
652         fails on Windows
653
654         * Scripts/webkitpy/common/system/executive.py:
655         (Executive._run_command_with_teed_output):
656         (Executive.run_command):
657         On Cygwin, encode arguments using UTF-8.
658
659 2010-10-01  Sam Weinig  <sam@webkit.org>
660
661         Reviewed by Adam Roben.
662
663         Add simple API tester for WebKit2
664         https://bugs.webkit.org/show_bug.cgi?id=46953
665
666         This adds a very simple testing infrastructure for testing APIs exposed
667         through the WebKit project. It consists of two parts: 1) a project that
668         builds the all the tests 2) a script that searches the tests directory and
669         calls the tester once for each test.
670
671         This adds the infrastructure and two tests:
672         - Tests/WTF/Vector1.cpp - A proof of concept test of WTF data-structures.
673         - Tests/WebKit2/BasicTest1.cpp - A proof of concept test of WebKit2 API.
674
675         This currently only works on the mac, but is designed to be easily ported 
676         to any platform.
677
678         * Scripts/run-api-tests: Added.
679         * Scripts/build-api-tests: Added.
680         Scripts to build/run the tests.
681
682         * TestWebKitAPI: Added.
683         * TestWebKitAPI/Configurations: Added.
684         * TestWebKitAPI/Configurations/Base.xcconfig: Added.
685         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Added.
686         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Added.
687         * TestWebKitAPI/ForwardingHeaders: Added.
688         * TestWebKitAPI/ForwardingHeaders/wtf: Added.
689         * TestWebKitAPI/PlatformUtilities.h: Added.
690         * TestWebKitAPI/PlatformWebView.h: Added.
691         (TestWebKitAPI::PlatformWebView::platformView):
692         * TestWebKitAPI/StringFunctions.h: Added.
693         * TestWebKitAPI/Test.h: Added.
694         (TestWebKitAPI::Test::~Test):
695         (TestWebKitAPI::Test::name):
696         (TestWebKitAPI::Test::Register::Register):
697         (TestWebKitAPI::Test::Register::create):
698         (TestWebKitAPI::Test::Test):
699         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Added.
700         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added.
701         * TestWebKitAPI/TestWebKitAPIPrefix.h: Added.
702         * TestWebKitAPI/TestsController.cpp: Added.
703         (TestWebKitAPI::TestsController::shared):
704         (TestWebKitAPI::TestsController::TestsController):
705         (TestWebKitAPI::TestsController::runTestNamed):
706         (TestWebKitAPI::TestsController::testFailed):
707         (TestWebKitAPI::TestsController::registerCreateTestFunction):
708         * TestWebKitAPI/TestsController.h: Added.
709         * TestWebKitAPI/mac: Added.
710         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm: Added.
711         (TestWebKitAPI::Util::run):
712         (TestWebKitAPI::Util::createURLForResource):
713         * TestWebKitAPI/mac/PlatformWebViewMac.mm: Added.
714         (TestWebKitAPI::PlatformWebView::PlatformWebView):
715         (TestWebKitAPI::PlatformWebView::resizeTo):
716         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
717         (TestWebKitAPI::PlatformWebView::page):
718         (TestWebKitAPI::PlatformWebView::focus):
719         * TestWebKitAPI/mac/main.mm: Added.
720         Infrastructure.
721
722         * TestWebKitAPI/Tests: Added.
723         * TestWebKitAPI/Tests/WTF: Added.
724         * TestWebKitAPI/Tests/WTF/Vector1.cpp: Added.
725         * TestWebKitAPI/Tests/WebKit2: Added.
726         * TestWebKitAPI/Tests/WebKit2/BasicTest1.cpp: Added.
727         (TestWebKitAPI::State::State):
728         * TestWebKitAPI/Tests/WebKit2/basic-1.html: Added.
729         Proof of concept tests.
730
731 2010-10-01  Adam Roben  <aroben@apple.com>
732
733         Don't assume AccessibleObjectFromEvent succeeds
734
735         Fixes <http://webkit.org/b/44136> <rdar://problem/8321684> Crash in
736         DumpRenderTree!notificationListenerProc when running
737         plugins/access-after-page-destroyed.html
738
739         Reviewed by Sam Weinig.
740
741         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
742         (notificationListenerProc): Check both the return value of
743         AccessibleObjectFromEvent and the object it returns, as MSDN
744         recommends.
745
746 2010-10-01  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
747
748         Reviewed by Tony Chang.
749
750         [NRWT] Put the http and websocket tests first in the test list.
751         https://bugs.webkit.org/show_bug.cgi?id=46453
752
753         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
754         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
755
756 2010-10-01  Fady Samuel  <fsamuel@chromium.org>
757
758         Unreviewed, adding myself to the committer list.
759
760         * Scripts/webkitpy/common/config/committers.py:
761
762 2010-10-01  Adam Roben  <aroben@apple.com>
763
764         Test NPN_GetValue(NPNVnetscapeWindow)
765
766         Test for <http://webkit.org/b/46726> <rdar://problem/8486319>
767         Right-clicking on windowless Flash plugin in WebKit2 makes a context
768         menu appear in the bottom-right corner of the screen
769
770         Reviewed by Anders Carlsson.
771
772         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
773         (PluginTest::NPN_GetValue): Added. Calls through to the browser.
774
775         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added NPN_GetValue.
776
777         * DumpRenderTree/TestNetscapePlugIn/Tests/win/GetValueNetscapeWindow.cpp: Added.
778         (GetValueNetscapeWindow::GetValueNetscapeWindow): Initialize members.
779         (GetValueNetscapeWindow::NPP_SetWindow): Test that
780         NPN_GetValue(NPNVnetscapeWindow) returns a valid HWND and that it
781         isn't our HWND.
782
783         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
784         Added GetValueNetscapeWindow.
785
786 2010-10-01  Andreas Kling  <andreas.kling@nokia.com>
787
788         Unreviewed, adding my webkit.org identity to reviewer list.
789
790         * Scripts/webkitpy/common/config/committers.py:
791
792 2010-09-30  Adam Barth  <abarth@webkit.org>
793
794         Reviewed by Eric Seidel.
795
796         The WebSocket server should flush its logs
797         https://bugs.webkit.org/show_bug.cgi?id=46946
798
799         The WebSocket server logs are truncated because the driver just
800         terminates the child.  It should run Python without buffering so we can
801         see the end of the log.
802
803         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
804
805 2010-09-30  Simon Fraser  <simon.fraser@apple.com>
806
807         Add a button to jump to the next untested test.
808         
809         * CSSTestSuiteHarness/harness/harness.css:
810         (.test-type):
811         (.name > button):
812         * CSSTestSuiteHarness/harness/harness.html:
813         * CSSTestSuiteHarness/harness/harness.js:
814         (Chapter.prototype.description):
815         (Chapter.prototype.untestedCount):
816         (TestSuite.prototype.testInfoDataLoaded):
817         (TestSuite.prototype.fillChapterPopup):
818         (TestSuite.prototype.updateChapterPopup):
819         (TestSuite.prototype.buildTestListForChapter):
820         (TestSuite.prototype.goToNextIncompleteTest):
821         (TestSuite.prototype.firstIncompleteTestIndex):
822         (TestSuite.prototype.testCompletionStateChanged):
823
824 2010-09-29  Jon Honeycutt  <jhoneycutt@apple.com>
825
826         WebKit2 on Windows should use Windows fonts for the various standard
827         font families
828         https://bugs.webkit.org/show_bug.cgi?id=43499
829         <rdar://problem/8272758>
830
831         Reviewed by Adam Roben.
832
833         * WebKitTestRunner/TestController.cpp:
834         (WTR::TestController::resetStateToConsistentValues):
835         Use the Mac fonts for running tests. This matches DRT behavior.
836
837 2010-09-30  Adam Barth  <abarth@webkit.org>
838
839         Third attempt.  We need a better integration test environment.
840
841         * Scripts/webkitpy/common/net/failuremap.py:
842         * Scripts/webkitpy/common/net/failuremap_unittest.py:
843
844 2010-09-30  Robert Hogan  <robert@webkit.org>
845
846         Reviewed by Andreas Kling.
847
848         [Qt] Support for PlainTextController
849
850         Unskip editing/text-iterator/basic-iteration.html
851
852         https://bugs.webkit.org/show_bug.cgi?id=38805
853
854         * DumpRenderTree/qt/DumpRenderTree.pro:
855         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
856         (WebCore::DumpRenderTree::DumpRenderTree):
857         (WebCore::DumpRenderTree::initJSObjects):
858         * DumpRenderTree/qt/DumpRenderTreeQt.h:
859         * DumpRenderTree/qt/PlainTextControllerQt.cpp: Added.
860         (PlainTextController::PlainTextController):
861         (PlainTextController::plainText):
862         * DumpRenderTree/qt/PlainTextControllerQt.h: Added.
863
864 2010-09-30  Adam Barth  <abarth@webkit.org>
865
866         Unreviewed.  Second attempt to fix sheriffbot.
867
868         * Scripts/webkitpy/common/net/buildbot.py:
869
870 2010-09-30  Adam Barth  <abarth@webkit.org>
871
872         Unreviewed.
873
874         This patch should stop the sheriffbot from throwing an exception.
875
876         * Scripts/webkitpy/common/net/buildbot.py:
877
878 2010-09-30  Brian Weinstein  <bweinstein@apple.com>
879
880         Reviewed by Adam Roben.
881
882         The same bots shouldn't run both Windows Debug Tests and Windows Release Tests.
883         https://bugs.webkit.org/show_bug.cgi?id=46926
884
885         * BuildSlaveSupport/build.webkit.org-config/config.json: Have two bots running Windows 
886             Release Tests, and two bots running Windows Debug Tests, instead of four running both.
887
888 2010-09-30  Adam Barth  <abarth@webkit.org>
889
890         Reviewed by Eric Seidel.
891
892         webkit-patch find-flaky-tests should print results URLs
893         https://bugs.webkit.org/show_bug.cgi?id=46917
894
895         Printing out the results URL makes find-flaky-tests more actionable
896         because you can see what happens when a test fails.  The output from
897         the script is still pretty noisy, but it seems useful.
898
899         * Scripts/webkitpy/tool/commands/queries.py:
900
901 2010-09-30  Chris Marrin  <cmarrin@apple.com>
902
903         Reviewed by Simon Fraser.
904
905         Make 2D accelerated canvas rendering build on Mac
906         https://bugs.webkit.org/show_bug.cgi?id=46007
907         
908         Added ACCELERATED_2D_CANVAS to build-webkit
909
910         * Scripts/build-webkit:
911
912 2010-09-29  Kenneth Russell  <kbr@google.com>
913
914         Reviewed by Dimitri Glazkov.
915
916         [chromium] Add accelerated compositing support to DumpRenderTree and test_shell
917         https://bugs.webkit.org/show_bug.cgi?id=46849
918
919         Added offscreen code path for WebGraphicsContext3DDefaultImpl which
920         works with the compositor integration in both DumpRenderTree and
921         test_shell, since both pass a non-null WebCanvas* to WebViewImpl::paint
922         and thereby trigger the compositor's readback code path. Added support
923         for --enable-accelerated-compositing to DumpRenderTree.
924
925         Tested in both test_shell and DumpRenderTree on Linux, the latter by
926         modifying a compositing layout test, dumping the pixels and verifying
927         that they matched the output when the compositor was active.
928
929         * DumpRenderTree/chromium/DumpRenderTree.cpp:
930         (main):
931         * DumpRenderTree/chromium/TestShell.cpp:
932         (TestShell::TestShell):
933         (TestShell::resetWebSettings):
934         * DumpRenderTree/chromium/TestShell.h:
935         (TestShell::setAcceleratedCompositingEnabled):
936         * DumpRenderTree/chromium/WebPreferences.cpp:
937         (WebPreferences::reset):
938         (WebPreferences::applyTo):
939         * DumpRenderTree/chromium/WebPreferences.h:
940         * DumpRenderTree/chromium/WebViewHost.cpp:
941         (WebViewHost::scheduleComposite):
942         * DumpRenderTree/chromium/WebViewHost.h:
943
944 2010-09-30  Adam Roben  <aroben@apple.com>
945
946         Ensure that QueueEngine cleans up its log files when its delegate
947         tells it to stop processing work
948
949         Reviewed by Adam Barth.
950
951         Fixes <http://webkit.org/b/46891> <rdar://problem/8496638> Many tests
952         in webkitpy.tool.bot.queueengine_unittest.QueueEngineTest crash on
953         Windows
954
955         * Scripts/webkitpy/tool/bot/queueengine.py:
956         (QueueEngine.run): Stop ourselves normally (including cleaning up log
957         files) when the delegate tells us to stop processing work.
958
959         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
960         (LoggingDelegate.__init__): Moved code here from
961         RaisingDelegate.__init__.
962         (LoggingDelegate.expeced_callbacks): Added the stop_work_queue
963         callback.
964         (LoggingDelegate.stop_work_queue): Moved here from RaisingDelegate.
965         (RaisingDelegate.__init__): Removed code that LoggingDelegate takes
966         care of for us now.
967         (QueueEngineTest.test_trivial): Make sure we got the expected stop
968         message.
969         (QueueEngineTest.test_not_safe_to_proceed): Changed to explicitly
970         remove the callbacks that are related to processing a single work
971         item, rather than removing all callbacks after a certain point, as
972         there are now more callbacks we expect to receive at the end.
973
974 2010-09-30  Adam Roben  <aroben@apple.com>
975
976         Fix path -> URL conversion on Cygwin
977
978         Reviewed by Adam Barth.
979
980         Fixes <http://webkit.org/b/46890> <rdar://problem/8496637> Many tests
981         in webkitpy.layout_tests.run_webkit_tests_unittest assert on Windows
982
983         * Scripts/webkitpy/layout_tests/port/base.py:
984         (Port.filename_to_uri): Treat Cygwin like other UNIX-y platforms by
985         assuming paths already have a leading slash.
986
987 2010-09-30  Adam Roben  <aroben@apple.com>
988
989         Teach WindowGeometryInitializedBeforeSetWindow that NPP_SetWindow can
990         be called more than once
991
992         The NPP_SetWindow call made when the plugin is torn down was confusing
993         us, and was causing us to spew an error into the next test.
994
995         Fixes <http://webkit.org/b/46900> <rdar://problem/8496888> REGRESSION
996         (r68520): plugins/access-after-page-destroyed.html failing on Windows
997
998         Reviewed by Anders Carlsson.
999
1000         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:
1001         (WindowGeometryInitializedBeforeSetWindow::WindowGeometryInitializedBeforeSetWindow):
1002         Initialize member.
1003         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Bail if
1004         this isn't the first time this is called.
1005
1006 2010-09-30  Eric Seidel  <eric@webkit.org>
1007
1008         Reviewed by Adam Barth.
1009
1010         webkit-patch upload warns that I'm using Xcode when I'm not
1011         https://bugs.webkit.org/show_bug.cgi?id=46869
1012
1013         String.find returns -1 when not found, so switched to "in".
1014
1015         * Scripts/webkitpy/common/system/user.py:
1016         * Scripts/webkitpy/common/system/user_unittest.py:
1017
1018 2010-09-30  Eric Seidel  <eric@webkit.org>
1019
1020         Reviewed by Adam Barth.
1021
1022         webkit-patch failure-reason dies if non-trunk commits are in the blame range
1023         https://bugs.webkit.org/show_bug.cgi?id=46866
1024
1025         I also made failure-reason use RegressionWindow in a cleaner way.
1026
1027         * Scripts/webkitpy/tool/commands/queries.py:
1028
1029 2010-09-29  Adam Barth  <abarth@webkit.org>
1030
1031         Reviewed by Eric Seidel.
1032
1033         webkit-patch find-flaky-tests
1034         https://bugs.webkit.org/show_bug.cgi?id=46876
1035
1036         This command helps us find flaky tests so we can squash them.
1037
1038         * Scripts/webkitpy/tool/commands/queries.py:
1039
1040 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
1041
1042         Fix export to use '?' instead of 'null' for
1043         tests with no results.
1044         
1045         * CSSTestSuiteHarness/harness/harness.js:
1046
1047 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
1048
1049         Add a warning when a test requires special steps.
1050         Add a Print Preview button for 'paged' tests that
1051         brings up the print dialog, allowing the user to 
1052         judge paged media tests.
1053
1054         * CSSTestSuiteHarness/harness/harness.css:
1055         * CSSTestSuiteHarness/harness/harness.html:
1056         * CSSTestSuiteHarness/harness/harness.js:
1057         (TestSuite.prototype.loadTest):
1058         (TestSuite.prototype.processFlags):
1059
1060 2010-09-29  Adam Barth  <abarth@webkit.org>
1061
1062         Reviewed by Eric Seidel.
1063
1064         Remove revisions_casuing_failures
1065         https://bugs.webkit.org/show_bug.cgi?id=46872
1066
1067         This function exists only to be unit tested.
1068
1069         * Scripts/webkitpy/common/net/failuremap.py:
1070         * Scripts/webkitpy/common/net/failuremap_unittest.py:
1071         * Scripts/webkitpy/tool/mocktool.py:
1072
1073 2010-09-29  Adam Barth  <abarth@webkit.org>
1074
1075         Reviewed by Eric Seidel.
1076
1077         SheriffBot should post the list of failing tests to bugs
1078         https://bugs.webkit.org/show_bug.cgi?id=46871
1079
1080         * Scripts/webkitpy/common/net/buildbot.py:
1081         * Scripts/webkitpy/common/net/failuremap.py:
1082         * Scripts/webkitpy/common/net/regressionwindow.py:
1083         * Scripts/webkitpy/tool/bot/sheriff.py:
1084         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
1085         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1086         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1087         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1088         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1089         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1090         * Scripts/webkitpy/tool/mocktool.py:
1091
1092 2010-09-29  Brent Fulgham  <bfulgham@webkit.org>
1093
1094         Reviewed by Martin Robinson, Eric Seidel, and Mark Rowe.
1095
1096         [WinCairo] Adds a build slave.
1097         https://bugs.webkit.org/show_bug.cgi?id=46360
1098
1099         * BuildSlaveSupport/build.webkit.org-config/config.json: Add
1100         entries for a debug build of the WinCairo port.
1101         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add
1102         platform flag to configuration for wincairo (like gtk, chromium, etc.)
1103         * Scripts/build-webkit: Change 'cairo-win32' labeling to 'wincairo'
1104         * Scripts/webkitdirs.pm: Change 'cairo-win32' labeling to 'wincairo'
1105
1106 2010-09-29  Adam Barth  <abarth@webkit.org>
1107
1108         Reviewed by Eric Seidel.
1109
1110         Move more SheriffBot smarts into FailureMap
1111         https://bugs.webkit.org/show_bug.cgi?id=46703
1112
1113         This patch pushes the FailureMap model object further into the
1114         SheriffBot machine.  In addition, it moves a couple operations on this
1115         object from SheriffBot itself to the model.
1116
1117         Eventually, FailureMap will be the canonical context object for
1118         SheriffBot operations.  FailureMap represents a map of the current
1119         failures on the bots that might require remediation.
1120
1121         * Scripts/webkitpy/common/net/failuremap.py:
1122         * Scripts/webkitpy/common/net/regressionwindow.py:
1123         * Scripts/webkitpy/tool/commands/queries.py:
1124         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1125         * Scripts/webkitpy/tool/mocktool.py:
1126
1127 2010-09-29  Tony Chang  <tony@chromium.org>
1128
1129         Reviewed by James Robinson.
1130
1131         [chromium] enable -Werror for DRT and webkit_unit_tests on Linux
1132         https://bugs.webkit.org/show_bug.cgi?id=46829
1133
1134         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1135         (DRTDevToolsClient::DRTDevToolsClient):
1136         * DumpRenderTree/chromium/TestShell.cpp:
1137         (TestShell::TestShell):
1138         * DumpRenderTree/chromium/WebViewHost.cpp:
1139         (WebViewHost::postAccessibilityNotification):
1140         (WebViewHost::WebViewHost):
1141
1142 2010-09-29  Chris Fleizach  <cfleizach@apple.com>
1143
1144         Reviewed by Darin Adler.
1145
1146         AX: implement CSS3 Speech "speak"
1147         https://bugs.webkit.org/show_bug.cgi?id=46827
1148
1149         * DumpRenderTree/AccessibilityUIElement.cpp:
1150         (speakCallback):
1151         (AccessibilityUIElement::speak):
1152         (AccessibilityUIElement::getJSClass):
1153         * DumpRenderTree/AccessibilityUIElement.h:
1154         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1155         (AccessibilityUIElement::speak):
1156
1157 2010-09-29  Mihai Parparita  <mihaip@chromium.org>
1158
1159         Reviewed by Adam Barth.
1160
1161         Record bot ID when updating queue status
1162         https://bugs.webkit.org/show_bug.cgi?id=46764
1163         
1164         Since we now have multiple bots handling patches from the commit queue,
1165         we need to differentiate status updates from them, so that we can group
1166         the queue status page in a less confusing way.
1167
1168         * QueueStatusServer/handlers/updatestatus.py: Accept bot_id as input
1169         * QueueStatusServer/model/queuestatus.py: Add bot_id property
1170         * QueueStatusServer/templates/updatestatus.html: Add bot_id input
1171         * Scripts/webkitpy/common/net/bugzilla_unittest.py: Extract MockBrowser
1172         * Scripts/webkitpy/common/net/statusserver.py: Add bot_id
1173         * Scripts/webkitpy/common/net/statusserver_unittest.py: Added.
1174         * Scripts/webkitpy/tool/main.py: Add --bot-id
1175         * Scripts/webkitpy/tool/mocktool.py: Add MockBrowser
1176
1177 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
1178
1179         No review.
1180         
1181         References always refert to a file in .xht format, even
1182         for HTML tests, so fix their loading.
1183
1184         * CSSTestSuiteHarness/harness/harness.js:
1185         (TestSuite.prototype.loadRef):
1186
1187 2010-09-28  Johnny Ding  <jnd@chromium.org>
1188
1189         Reviewed by Adam Barth.
1190
1191         https://bugs.webkit.org/show_bug.cgi?id=41292
1192         Add a new parameter to the test plugin to allow specifying a script 
1193         and a mouse/keyboard event. The specified script will be evaluated
1194         in the browser when the specified event is received by the plugin.
1195
1196         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1197         (pluginAllocate):
1198         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
1199         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1200         (NPP_New):
1201         (handleEventCarbon):
1202         (handleEventCocoa):
1203
1204 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1205
1206         Fix export by adding missing argument.
1207
1208         * CSSTestSuiteHarness/harness/harness.js:
1209         (TestSuite.prototype.showResultsForAllTests):
1210
1211 2010-09-28  Kevin Ollivier  <kevino@theolliviers.com>
1212
1213         [wx] Build fix, add missing import.
1214
1215         * wx/packaging/build-win-installer.py:
1216
1217 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1218
1219         No review
1220         
1221         Show which tests have been run by dimming them out in the test list.
1222         
1223         Adjust some element sizes.
1224         
1225         * CSSTestSuiteHarness/harness/harness.css:
1226         (#test-list > option.untested):
1227         (#test-list > option.completed):
1228         (#output):
1229         (.output-options):
1230         * CSSTestSuiteHarness/harness/harness.js:
1231         (Test):
1232         (TestSuite.prototype.fillTestList):
1233         (TestSuite.prototype.updateTestList):
1234         (TestSuite.prototype.setSelectedChapter):
1235         (TestSuite.prototype.recordResult):
1236         (TestSuite.prototype.markTestCompleted):
1237         (TestSuite.prototype.testCompletionStateChanged):
1238         (TestSuite.prototype.loadTestStatus):
1239
1240 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1241
1242         No review.
1243         
1244         Implement export of various queries on the test database, sharing
1245         code with that which displays results inline.
1246
1247         * CSSTestSuiteHarness/harness/harness.js:
1248         ():
1249         (TestSuite.prototype.exportResultsCompletion.var):
1250         (TestSuite.prototype.exportResultsCompletion):
1251         (TestSuite.prototype.showResultsForCompletedTests):
1252         (TestSuite.prototype.exportResultsForCompletedTests):
1253         (TestSuite.prototype.showResultsForAllTests):
1254         (TestSuite.prototype.exportResultsForAllTests):
1255         (TestSuite.prototype.exportResultsForTestsNotRun):
1256         (TestSuite.prototype.exportResultsForTestsWithStatus):
1257         (TestSuite.prototype.exportResultsForTestsWithMismatchedResults):
1258
1259 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1260
1261         No review.
1262
1263         Work around uncertainty about the order of database
1264         transactions when creating the database, so that we don't
1265         try to query the table before it has been created.
1266
1267         * CSSTestSuiteHarness/harness/harness.js:
1268         (TestSuite):
1269         (TestSuite.prototype.databaseCreated):
1270         (TestSuite.prototype.storeTestResult):
1271         (TestSuite.prototype.populateDatabaseFromTestInfoData):
1272         (TestSuite.prototype.queryDatabaseForTestsWithStatus):
1273         (TestSuite.prototype.queryDatabaseForTestsWithMixedStatus):
1274         (TestSuite.prototype.queryDatabaseForCompletedTests):
1275         (TestSuite.prototype.queryDatabaseForTestsNotRun):
1276
1277 2010-09-28  Tony Chang  <tony@chromium.org>
1278
1279         Reviewed by Eric Seidel.
1280
1281         add python keyring support to webkit-patch
1282         https://bugs.webkit.org/show_bug.cgi?id=41269
1283
1284         * Scripts/webkitpy/common/net/credentials.py: Add the ability to read passwords using
1285             the python keyring module
1286         * Scripts/webkitpy/common/net/credentials_unittest.py:
1287         * Scripts/webkitpy/common/system/user.py: Allow confirm() to default to no and add testing params.
1288         * Scripts/webkitpy/common/system/user_unittest.py:
1289         * Scripts/webkitpy/tool/mocktool.py:
1290
1291 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
1292
1293         Reviewed by Gustavo Noronha Silva.
1294
1295         [Cairo] FreeType fonts should obey FontConfig hinting/anti-aliasing settings
1296         https://bugs.webkit.org/show_bug.cgi?id=46740
1297
1298         * DumpRenderTree/gtk/fonts/fonts.conf: Add specialized variants of common
1299         fonts which can be used to fully test FontConfig rendering settings.
1300
1301 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
1302
1303         Reviewed by Gustavo Noronha Silva.
1304
1305         [gtk] Fedora has a different path for the liberation fonts
1306         https://bugs.webkit.org/show_bug.cgi?id=46709
1307
1308         When searching for DRT fonts, also look in the path where those fonts
1309         are commonly found on Fedora systems.
1310
1311         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1312         (initializeFonts): Include logic for looking for Fedora-style font paths.
1313
1314 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
1315
1316         Reviewed by Andreas Kling.
1317
1318         run-webkit-tests needs an updated list of directories with webgl tests
1319         https://bugs.webkit.org/show_bug.cgi?id=46747
1320
1321         Update the list of directories containing WebGL tests and a unit test
1322         which depends on this list.
1323
1324         * Scripts/old-run-webkit-tests: Update the list of directories.
1325         * Scripts/webkitpy/layout_tests/port/webkit.py: Ditto.
1326         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Update the expected result.
1327
1328 2010-09-28  Adam Barth  <abarth@webkit.org>
1329
1330         Reviewed by Eric Seidel.
1331
1332         Introduce FailureMap to summaries the failures status of all the bots
1333         https://bugs.webkit.org/show_bug.cgi?id=46700
1334
1335         This patch gives the SheriffBot a handle on the list of failing tests.
1336
1337         * Scripts/webkitpy/common/net/buildbot.py:
1338         * Scripts/webkitpy/common/net/failuremap.py: Added.
1339         * Scripts/webkitpy/tool/commands/queries.py:
1340         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1341         * Scripts/webkitpy/tool/mocktool.py:
1342
1343 2010-09-28  Adam Roben  <aroben@apple.com>
1344
1345         Update for the addition of WKPageUIClient::didNotHandleKeyEvent
1346
1347         Fixes <http://webkit.org/b/46660> <rdar://problem/8483465> Need API to
1348         tell a WebKit2 client application that a key event was not handled
1349
1350         Reviewed by Kenneth Rohde Christiansen and Sam Weinig.
1351
1352         * MiniBrowser/mac/BrowserWindowController.m:
1353         (-[BrowserWindowController awakeFromNib]):
1354         * MiniBrowser/win/BrowserView.cpp:
1355         (BrowserView::create):
1356         * WebKitTestRunner/TestController.cpp:
1357         (WTR::createOtherPage):
1358         (WTR::TestController::initialize):
1359
1360 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1361
1362         Unreviewed.
1363
1364         Update the CSSTestSuiteHarness to not scrape the XHTML chapter files
1365         for the test order, but instead use information from testinfo.data.
1366         
1367         * CSSTestSuiteHarness/harness/harness.html:
1368         * CSSTestSuiteHarness/harness/harness.js:
1369
1370 2010-09-28  Kevin Ollivier  <kevino@theolliviers.com>
1371
1372         [wx] Build fix, don't try to get the svn revision from the git repo when packaging,
1373         it causes the process to hang on the gitorious repo.
1374
1375         * wx/packaging/build-mac-installer.py:
1376         * wx/packaging/build-win-installer.py:
1377
1378 2010-09-28  Adam Roben  <aroben@apple.com>
1379
1380         Test that a plugin's HWND is sized/positioned before NPP_SetWindow is
1381         called
1382
1383         Reviewed by Anders Carlsson.
1384
1385         Test for <http://webkit.org/b/46716> <rdar://problem/8482014>
1386         Full-page Adobe Reader does not paint until window is resized
1387
1388         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1389         (PluginTest::NPP_SetWindow): Added. Just returns NPERR_NO_ERROR at
1390         this level.
1391
1392         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Declared
1393         NPP_SetWindow.
1394
1395         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp: Added.
1396         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Checks that
1397         the plugin's HWND has a non-zero size and that its size/position
1398         matches that specified in the NPWindow.
1399
1400         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1401         (NPP_SetWindow): Call through to the PluginTest.
1402
1403         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1404         Added WindowGeometryInitializedBeforeSetWindow.cpp, and let VS reorder
1405         the files as it saw fit.
1406
1407 2010-09-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
1408
1409         Reviewed by Andreas Kling.
1410
1411         [Qt] Remove support for Qt 4.5
1412         https://bugs.webkit.org/show_bug.cgi?id=46718
1413
1414         Remove the code for versions of Qt prior to 4.6.
1415
1416         * DumpRenderTree/qt/EventSenderQt.cpp:
1417         (EventSender::addTouchPoint):
1418         (EventSender::updateTouchPoint):
1419         (EventSender::setTouchModifier):
1420         (EventSender::touchStart):
1421         (EventSender::touchMove):
1422         (EventSender::touchEnd):
1423         (EventSender::clearTouchPoints):
1424         (EventSender::releaseTouchPoint):
1425         (EventSender::sendTouchEvent):
1426         * DumpRenderTree/qt/EventSenderQt.h:
1427         * DumpRenderTree/qt/TextInputControllerQt.cpp:
1428         (TextInputController::setMarkedText):
1429         * QtTestBrowser/launcherwindow.cpp:
1430         (LauncherWindow::LauncherWindow):
1431         (LauncherWindow::initializeView):
1432         (LauncherWindow::createChrome):
1433         (LauncherWindow::sendTouchEvent):
1434         (LauncherWindow::eventFilter):
1435         (LauncherWindow::applyZoom):
1436         (LauncherWindow::setTouchMocking):
1437         * QtTestBrowser/launcherwindow.h:
1438         * QtTestBrowser/utils.cpp:
1439         (urlFromUserInput):
1440         * QtTestBrowser/webview.cpp:
1441         (WebViewGraphicsBased::animatedFlip):
1442         (WebViewGraphicsBased::animatedYFlip):
1443         * QtTestBrowser/webview.h:
1444         (WebViewGraphicsBased::setYRotation):
1445
1446 2010-09-28  İsmail Dönmez  <ismail@namtrac.org>
1447
1448         Reviewed by Andreas Kling.
1449
1450         Fix DRT compilation on WinCE. Introduce a WCECOMPAT variable
1451         which should point to wcecompat installation. Needs wcecompat
1452         library from http://github.com/mauricek/wcecompat .
1453
1454         * DumpRenderTree/qt/DumpRenderTree.pro:
1455         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1456         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1457
1458 2010-09-28  Daniel Bates  <dbates@rim.com>
1459
1460         Rollout changeset 68493 <http://trac.webkit.org/changeset/68493>
1461         <https://bugs.webkit.org/show_bug.cgi?id=39136>
1462
1463         Rollout changeset 68493 because it broke Sheriffbot's rollout feature.
1464         In particular, this change caused Sheriffbot to raise an exception when
1465         trying to parse the bug id on a bug page. We need to look into this
1466         some more.
1467
1468         * Scripts/webkitpy/common/net/bugzilla.py:
1469         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
1470         * Scripts/webkitpy/tool/bot/sheriff.py:
1471         * Scripts/webkitpy/tool/commands/download.py:
1472         * Scripts/webkitpy/tool/commands/queues.py:
1473         * Scripts/webkitpy/tool/commands/upload.py:
1474         * Scripts/webkitpy/tool/steps/closebug.py:
1475         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
1476         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1477         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
1478
1479 2010-09-28  Adam Barth  <abarth@webkit.org>
1480
1481         Reviewed by Eric Seidel.
1482
1483         Move RegressionWindow further up the dependency chain
1484         https://bugs.webkit.org/show_bug.cgi?id=46698
1485
1486         Baby steps towards pushing this information into bug posts.
1487
1488         * Scripts/webkitpy/common/net/buildbot.py:
1489         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1490         * Scripts/webkitpy/common/net/regressionwindow.py:
1491         * Scripts/webkitpy/tool/commands/queries.py:
1492
1493 2010-09-27  Daniel Bates  <dbates@rim.com>
1494
1495         Reviewed by Adam Barth.
1496
1497         sheriffbot can't roll out security patches
1498         https://bugs.webkit.org/show_bug.cgi?id=39136
1499
1500         Make SheriffBot determine if it's authorized to view a bug
1501         whose change it wants to rollout before it tries to rollout
1502         the change.
1503
1504         Moreover, make both webkit-patch and Sheriffbot provide human-
1505         readable error messages when they are not authorized to view
1506         a bug and when a bug number is invalid.
1507
1508         Currently, Sheriffbot does not parse Bugzilla bugs for
1509         <bug error="...">, which indicates an error when retrieving
1510         a bug. In particular, error="NotPermitted" if a person (or bot)
1511         is not authorized to view a bug. For such error="NotPermitted" bugs,
1512         Sheriffbot raises an exception when parsing the bug report and
1513         this exception does not explicitly indicate Sheriffbot's lack
1514         of authorization. Instead, Sheriffbot should explicitly check
1515         for the presence <bug error="..."> before operating on a bug
1516         and error with a human-readable message if it's not permitted
1517         to view it.
1518
1519         * Scripts/webkitpy/common/net/bugzilla.py: Added BugzillaError class.
1520         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
1521           - Added unit test test_bug_parsing_for_bugzilla_not_permitted_error().
1522           - Added unit test test_bug_parsing_for_bugzilla_not_found_error().
1523           - Added unit test test_bug_parsing_for_bugzilla_invalid_bug_id_error().
1524         * Scripts/webkitpy/tool/bot/sheriff.py: Modified to catch BugzillaError.
1525         * Scripts/webkitpy/tool/commands/download.py: Ditto.
1526         * Scripts/webkitpy/tool/commands/queues.py: Ditto.
1527         * Scripts/webkitpy/tool/commands/upload.py: Ditto.
1528         * Scripts/webkitpy/tool/steps/closebug.py: Ditto.
1529         * Scripts/webkitpy/tool/steps/obsoletepatches.py: Ditto.
1530         * Scripts/webkitpy/tool/steps/preparechangelog.py: Ditto.
1531         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: Ditto.
1532
1533 2010-09-27  Adam Barth  <abarth@webkit.org>
1534
1535         Reviewed by Eric Seidel.
1536
1537         Expose more more failure information from Buildbot to SheriffBot
1538         https://bugs.webkit.org/show_bug.cgi?id=46697
1539
1540         This patch moves the information about what tests failured closer to
1541         SheriffBot.  There are still a couple more patches to go before
1542         SheriffBot can post this information to bugs, but this is a step in
1543         that direction.  Yay for unit tests, which caught some bugs in earlier
1544         versions of this patch.
1545
1546         * Scripts/webkitpy/common/net/buildbot.py:
1547         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1548         * Scripts/webkitpy/common/net/regressionwindow.py: Added.
1549         * Scripts/webkitpy/tool/commands/queries.py:
1550
1551 2010-09-27  Eric Seidel  <eric@webkit.org>
1552
1553         Unreviewed.  Fixing 500 error seen in the status server.
1554
1555         It turns out that a = b = []; b.append(1); then a[0] will be 1!
1556         This should have been obvious to me, I guess, but it was not what I was expecting.
1557
1558         * QueueStatusServer/model/activeworkitems.py:
1559
1560 2010-09-27  Adam Barth  <abarth@webkit.org>
1561
1562         Reviewed by Eric Seidel.
1563
1564         commit-queue should reject patches that fail to land
1565         https://bugs.webkit.org/show_bug.cgi?id=46694
1566
1567         This can happen, for example, if there's no reviewer.  Without this
1568         patch, we'll keep retrying the patch.
1569
1570         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1571         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1572
1573 2010-09-27  Simon Fraser  <simon.fraser@apple.com>
1574
1575         Rubber-stamped by Adele Peterson.
1576
1577         Add a harness for running the CSS 2.1 test suite.
1578         
1579         This harness assumes that you've got a local a copy of the suite
1580         adjacent to the 'harness' directory.
1581         
1582         The harness lets you go through the tests in chapter order,
1583         denoting pass/fail/skipped for each test.
1584         
1585         It uses a client-side database to store the results of testing.
1586
1587         * CSSTestSuiteHarness/harness/harness.css: Added.
1588         * CSSTestSuiteHarness/harness/harness.html: Added.
1589         * CSSTestSuiteHarness/harness/harness.js: Added.
1590
1591 2010-09-27  Eric Seidel  <eric@webkit.org>
1592
1593         Reviewed by Adam Barth.
1594
1595         Patch locks should expire if a patch is marked for retry
1596         https://bugs.webkit.org/show_bug.cgi?id=46682
1597
1598         This was part Adam's original CommitQueueTask design,
1599         but support for it was missing from the server.
1600         I added the support, but triggering lock-release based on this
1601         special "retry" status feels a bit strange so I added a FIXME.
1602
1603         I also changed the text in queuestatus.html to say "Lock Acquired"
1604         since "Last Activity" isn't really true.  We only update the lock
1605         date when the patch is started, not on every status update.
1606
1607         I also noticed an exception in next-patch, which I fixed by re-writing
1608         the unzip logic in activeworkitems.py again.
1609
1610         * QueueStatusServer/handlers/updatestatus.py:
1611         * QueueStatusServer/model/activeworkitems.py:
1612         * QueueStatusServer/templates/queuestatus.html:
1613
1614 2010-09-27  Tony Chang  <tony@chromium.org>
1615
1616         Reviewed by David Levin.
1617
1618         [chromium] fix a warning when compiling DRT on 32-bit linux
1619         https://bugs.webkit.org/show_bug.cgi?id=46641
1620
1621         * DumpRenderTree/chromium/TestEventPrinter.cpp:
1622         (DRTPrinter::handleImage):
1623
1624 2010-09-27  Eric Seidel  <eric@webkit.org>
1625
1626         Reviewed by Adam Barth.
1627
1628         queue-status should report when the patch was last locked to a queue
1629         https://bugs.webkit.org/show_bug.cgi?id=46674
1630
1631         This isn't necessarily the best way to expose this information
1632         but having this accessible via the web interface is very
1633         useful until we come up with a nicer way to display this.
1634
1635         I also cleaned up the code in activeworkitems.py a little
1636         to use list comprehensions and to have the code work with
1637         pairs instead of two lists at once.  Eventually I think those
1638         item/time pairs need to be their own little helper class.
1639
1640         * QueueStatusServer/handlers/queuestatus.py:
1641         * QueueStatusServer/model/activeworkitems.py:
1642         * QueueStatusServer/templates/queuestatus.html:
1643
1644 2010-09-27  Tony Chang  <tony@chromium.org>
1645
1646         Reviewed by David Levin.
1647
1648         [chromium] fix detection of missing fonts on DRT
1649         https://bugs.webkit.org/show_bug.cgi?id=46651
1650
1651         * DumpRenderTree/chromium/TestShellGtk.cpp:
1652         (setupFontconfig):  Only print an error message if lohit isn't found in both locations.
1653
1654 2010-09-27  Tony Chang  <tony@chromium.org>
1655
1656         Reviewed by Dimitri Glazkov.
1657
1658         add webkit unit tests to the chromium testers
1659         https://bugs.webkit.org/show_bug.cgi?id=46669
1660
1661         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1662         * Scripts/run-chromium-webkit-unit-tests: Fix a bug where we weren't using the right configuration.
1663
1664 2010-09-27  Kwang Yul Seo  <skyul@company100.net>
1665
1666         Unreviewed.
1667
1668         Adding myself to the committers list.
1669
1670         * Scripts/webkitpy/common/config/committers.py:
1671
1672 2010-09-27  Mihai Parparita  <mihaip@chromium.org>
1673
1674         Reviewed by Eric Seidel.
1675
1676         webkitpy.common.system.user_unittest.UserTest.test_prompt_with_list spams the console
1677         https://bugs.webkit.org/show_bug.cgi?id=46634
1678         
1679         Use OutputCapture to prevent console spam (and also check for expected
1680         output).
1681
1682         * Scripts/webkitpy/common/system/user_unittest.py:
1683
1684 2010-09-27  Eric Seidel  <eric@webkit.org>
1685
1686         Reviewed by James Robinson.
1687
1688         start-commit-queue should abort any rebases in progress
1689         https://bugs.webkit.org/show_bug.cgi?id=46640
1690
1691         webkit-patch commit-queue would do this itself, but this just
1692         helps ensure that the commit-queue script is properly updated
1693         before we run it (in the case where a previous rebase is in
1694         progress the git svn rebase would not work before we run the
1695         commit-queue).
1696
1697         * EWSTools/start-commit-queue.sh:
1698
1699 2010-09-18  Martin Robinson  <mrobinson@igalia.com>
1700
1701         Reviewed by Gustavo Noronha Silva.
1702
1703         [GTK] Clean up the DRT fonts.conf and switch to Liberation
1704         https://bugs.webkit.org/show_bug.cgi?id=46038
1705
1706         Switch to Liberation fonts for GTK+ layout tests. This will make our
1707         test results metric-compatible with many Windows/Chromium results. It
1708         also simplifies the fonts.conf that we load and prepares the way for
1709         fixing many font bugs.
1710
1711         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1712         (initializeFonts): Initialize a known list of fonts instead of loading
1713         every font in the WEBKIT_TESTFONTS directory.
1714         * DumpRenderTree/gtk/fonts.conf: Removed.
1715         * DumpRenderTree/gtk/fonts/AHEM____.TTF: Copied from WebKitTools/DumpRenderTree/qt/fonts/AHEM____.TTF.
1716         * DumpRenderTree/gtk/fonts/fonts.conf: Added.
1717         * GNUmakefile.am: Modify FONTS_CONF_FILE to be FONTS_CONF_DIR, so that
1718         we can load both fonts.conf and AHEM____.TTF from this location.
1719         * Scripts/old-run-webkit-tests: Remove the check for WEBKIT_TESTFONTS, since
1720         it is no longer used.
1721
1722 2010-09-26  Mihai Parparita  <mihaip@chromium.org>
1723
1724         Reviewed by Ojan Vafai.
1725
1726         new-run-webkit-httpd fails if Perl is not installed
1727         https://bugs.webkit.org/show_bug.cgi?id=46602
1728         
1729         Make Port._read_configuration catch all exceptions, since trying to run
1730         perl (because of _webkit_build_directory) when it's not installed throws
1731         a WindowsError or OSError, not an IOError (this became an issue after 
1732         r68268, since ChromiumPort ends up calling Port.default_configuration in
1733         its constructor, which means that we're ending up on this codepath in
1734         non-NRWT cases too, e.g. for the Chromium NaCl tests, which use
1735         new-run-webkit-httpd).
1736
1737         * Scripts/webkitpy/layout_tests/port/base.py:
1738         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1739
1740 2010-09-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1741
1742         Reviewed by Antonio Gomes.
1743
1744         [EFL] Add setting API to set a local storage database path.
1745         https://bugs.webkit.org/show_bug.cgi?id=45446
1746
1747         Add a setting API to set local storage database path.
1748
1749         * EWebLauncher/main.c:
1750         (on_key_down):
1751         (browserCreate):
1752         (main):
1753
1754 2010-09-26  Sam Weinig  <sam@webkit.org>
1755
1756         Reviewed by Anders Carlsson.
1757
1758         Move shared WebKit2 API (used by both bundle and main API) to WebKit2/Shared/API
1759         https://bugs.webkit.org/show_bug.cgi?id=46587
1760
1761         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1762
1763 2010-09-26  Antonio Gomes  <agomes@rim.com>
1764
1765         Reviewed by Kenneth Rohde Christiansen.
1766
1767         DRT/Mac nodesFromRect support
1768
1769         [Mac][DRT] Implement LayoutTestController::nodesFromRect
1770         https://bugs.webkit.org/show_bug.cgi?id=46580
1771
1772         Implements LayoutTestController::nodesFromRect for Mac DRT, and
1773         adding stubs for GTK+ and Windows.
1774
1775         * DumpRenderTree/LayoutTestController.cpp:
1776         (nodesFromRectCallback):
1777         (LayoutTestController::staticFunctions):
1778         * DumpRenderTree/LayoutTestController.h:
1779         (LayoutTestController::LayoutTestController::nodesFromRect):
1780         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1781         (LayoutTestController::nodesFromRect):
1782
1783 2010-09-25  Nicolas Weber  <thakis@chromium.org>
1784
1785         Reviewed by Adam Barth.
1786
1787         https://bugs.webkit.org/show_bug.cgi?id=46555
1788         Fix typo in prepare-ChangeLog's help output.
1789
1790         * Scripts/prepare-ChangeLog:
1791
1792 2010-09-24  Sam Weinig  <sam@webkit.org>
1793
1794         Reviewed by Darin Adler.
1795
1796         Implement WebKit2 callback equivalent to -[WebUIDelegate mouseDidMoveOverElement:modifierFlags:]
1797         <rdar://problem/8359279>
1798         https://bugs.webkit.org/show_bug.cgi?id=46546
1799
1800         * MiniBrowser/mac/BrowserWindowController.m:
1801         (mouseDidMoveOverElement):
1802         (-[BrowserWindowController awakeFromNib]):
1803         * MiniBrowser/win/BrowserView.cpp:
1804         (mouseDidMoveOverElement):
1805         (BrowserView::create):
1806         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1807         (WTR::InjectedBundlePage::InjectedBundlePage):
1808         * WebKitTestRunner/TestController.cpp:
1809         (WTR::createOtherPage):
1810         (WTR::TestController::initialize):
1811
1812 2010-09-24  Mihai Parparita  <mihaip@chromium.org>
1813
1814         Reviewed by Adam Barth.
1815
1816         Allow rebaselines for webkit-patch rebaseline to be chosen
1817         https://bugs.webkit.org/show_bug.cgi?id=46407
1818         
1819         Instead of always rebaselining all failing tests, allow a subset to be
1820         chosen.
1821
1822         * Scripts/webkitpy/common/system/user.py:
1823         * Scripts/webkitpy/tool/commands/rebaseline.py:
1824
1825 2010-09-24  Ryosuke Niwa  <rniwa@webkit.org>
1826
1827         Reviewed by Tony Chang.
1828
1829         [chromium] Implement TextInputController::firstRectForCharacterRange
1830         https://bugs.webkit.org/show_bug.cgi?id=38100
1831
1832         Implemented TextInputController::firstRectForCharacterRange for chromium platform.
1833         No new tests are added since we need to implement the same feature in chromium side
1834         in order to enable any tests that uses this function.
1835
1836         * DumpRenderTree/chromium/TextInputController.cpp:
1837         (TextInputController::firstRectForCharacterRange): Added.
1838
1839 2010-09-24  Adam Barth  <abarth@webkit.org>
1840
1841         Reviewed by Eric Seidel.
1842
1843         commit-queue reports land failures as "PASS"
1844         https://bugs.webkit.org/show_bug.cgi?id=46530
1845
1846         We were ignoring the return value of land instead of passing it back to
1847         CommitQueue.  Of course, this was the one case I forgot to test!
1848
1849         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1850         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1851
1852 2010-09-24  Kenichi Ishibashi  <bashi@google.com>
1853
1854         Reviewed by Eric Seidel.
1855
1856         new-run-webkit-tests prints out nothing when build-dumprendertree fails
1857         https://bugs.webkit.org/show_bug.cgi?id=37563
1858
1859         Print error message when build-dumprendertree fails.
1860
1861         * Scripts/webkitpy/layout_tests/port/webkit.py:
1862         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1863
1864 2010-09-24  Mihai Parparita  <mihaip@chromium.org>
1865
1866         Reviewed by Tony Chang.
1867
1868         NRWT doesn't respect config set with set-webkit-configuration
1869         https://bugs.webkit.org/show_bug.cgi?id=46278
1870         
1871         Use Port.default_configuration() instead of hardcoding Release in
1872         ChromiumPort configuration initialization, so that we still inherit the
1873         configuration set by set-webkit-configuration.
1874
1875         * Scripts/webkitpy/layout_tests/port/chromium.py:
1876         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1877
1878 2010-09-24  Chang Shu  <chang.shu@nokia.com>
1879
1880         Reviewed by Csaba Osztrogonác.
1881
1882         [Qt] Fix the code to check file existence.
1883         https://bugs.webkit.org/show_bug.cgi?id=46465
1884
1885         * QtTestBrowser/main.cpp:
1886         (main):
1887
1888 2010-09-23  Tony Chang  <tony@chromium.org>
1889
1890         Unreviewed, rolling out r68232.
1891         http://trac.webkit.org/changeset/68232
1892
1893         Broken NRWT on the canary bots.
1894
1895         * Scripts/webkitpy/layout_tests/port/chromium.py:
1896
1897 2010-09-23  Dirk Pranke  <dpranke@chromium.org>
1898
1899         Unreviewed, build fix.
1900
1901         r68008 broke new-run-webkit-tests in that the chromium ports no
1902         longer respect set-webkit-configuration. The correct fix for this
1903         is being pursued in bug 46278 (along with a bunch of unit tests),
1904         but in the meantime I'm reverting the particular lines that broke
1905         things. This was tested by hand.
1906
1907         * Scripts/webkitpy/layout_tests/port/chromium.py:
1908
1909 2010-09-23  Sam Weinig  <sam@webkit.org>
1910
1911         Reviewed by Anders Carlsson.
1912
1913         WebKit2 API: Need way to know when a frame is removed from the hierarchy
1914         <rdar://problem/8414062>
1915         https://bugs.webkit.org/show_bug.cgi?id=46432
1916
1917         * MiniBrowser/mac/BrowserWindowController.m:
1918         (didRemoveFrameFromHierarchy):
1919         (-[BrowserWindowController awakeFromNib]):
1920         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1921         (WTR::InjectedBundlePage::InjectedBundlePage):
1922         * WebKitTestRunner/TestController.cpp:
1923         (WTR::TestController::initialize):
1924
1925 2010-09-23  Tony Chang  <tony@chromium.org>
1926
1927         Reviewed by Dimitri Glazkov.
1928
1929         [chromium] implement layoutTestController.sampleSVGAnimationForElementAtTime
1930         https://bugs.webkit.org/show_bug.cgi?id=46426
1931
1932         * DumpRenderTree/chromium/LayoutTestController.cpp:
1933         (LayoutTestController::LayoutTestController):
1934         (LayoutTestController::sampleSVGAnimationForElementAtTime):
1935         * DumpRenderTree/chromium/LayoutTestController.h:
1936
1937 2010-09-23  Martin Robinson  <mrobinson@igalia.com>
1938
1939         Reviewed by Nate Chapin.
1940
1941         [GTK] r68199 introduced two test failures
1942         https://bugs.webkit.org/show_bug.cgi?id=46424
1943
1944         Fix a regression handling preference overrides that are attached to boolean properties.
1945
1946         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1947         (LayoutTestController::overridePreference): g_strcasecmp returns 0 when strings match
1948         so we must check for that when converting a string to a boolean.
1949
1950 2010-09-23  Dimitri Glazkov  <dglazkov@chromium.org>
1951
1952         Reviewed by David Levin.
1953
1954         Fix a condition check in ServerProcess, which becomes relevant when reading binary data.
1955         https://bugs.webkit.org/show_bug.cgi?id=46406
1956
1957         This breaks when the method is called with specified size of data (image data), and the
1958         buffer hasn't yet reached this size.
1959
1960         * Scripts/webkitpy/layout_tests/port/server_process.py: Changed to check for values of
1961           index larger than 0.
1962
1963 2010-09-23  Martin Robinson  <mrobinson@igalia.com>
1964
1965         Reviewed by Nate Chapin.
1966
1967         [GTK] Some tests from r68174 fail on the GTK+ bots
1968         https://bugs.webkit.org/show_bug.cgi?id=46396
1969
1970         Simplify LayoutTestController::overridePreference to make it easier for
1971         people unfamiliar with the code to keep the list of preferences up to date.
1972         Add the conversion for enable-hyperlink-auditing.
1973
1974         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1975         (LayoutTestController::overridePreference): Use a simple if-else block to determine
1976         out the property name for overrridePreference. Also simplify the logic for setting
1977         string properties. Add the conversion for enable-hyperlink-auditing.
1978
1979 2010-09-23  Tony Chang  <tony@chromium.org>
1980
1981         Reviewed by David Levin.
1982
1983         [chromium] add caretBrowsingEnabled to WebSettings and DRT
1984         https://bugs.webkit.org/show_bug.cgi?id=46388
1985
1986         * DumpRenderTree/chromium/LayoutTestController.cpp:
1987         (LayoutTestController::overridePreference):
1988         * DumpRenderTree/chromium/WebPreferences.cpp:
1989         (WebPreferences::reset):
1990         (WebPreferences::applyTo):
1991         * DumpRenderTree/chromium/WebPreferences.h:
1992
1993 2010-09-23  Nate Chapin  <japhet@chromium.org>
1994
1995         Reviewed by Darin Fisher.
1996
1997         Allow DRT to toggle hyperlink auditing (i.e., <a ping>).
1998         https://bugs.webkit.org/show_bug.cgi?id=30458
1999
2000         * DumpRenderTree/chromium/LayoutTestController.cpp:
2001         (LayoutTestController::overridePreference):
2002         * DumpRenderTree/chromium/WebPreferences.cpp:
2003         (WebPreferences::reset):
2004         (WebPreferences::applyTo):
2005         * DumpRenderTree/chromium/WebPreferences.h:
2006         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2007         (resetDefaultsToConsistentValues):
2008         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2009         (LayoutTestController::overridePreference):
2010
2011 2010-09-21  Stephen White  <senorblanco@chromium.org>
2012
2013         Reviewed by David Levin.
2014
2015         Implement --enable-accelerated-2d-canvas flag in DumpRenderTree.
2016         https://bugs.webkit.org/show_bug.cgi?id=46208
2017
2018         This flag allows the layout tests to be run with or without accelerated
2019         2D canvas rendering.
2020
2021         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2022         (main):
2023         Declare the new flag string, and check for it on startup.
2024         * DumpRenderTree/chromium/TestShell.cpp:
2025         (TestShell::TestShell):
2026         Add a boolean for the new flag, in order to preserve its value over
2027         preferences reset.
2028         (TestShell::resetWebSettings):
2029         Set the new flag to the stored value on reset.
2030         * DumpRenderTree/chromium/TestShell.h:
2031         (TestShell::setAccelerated2dCanvasEnabled):
2032         Add an accessor for the new flag.
2033         * DumpRenderTree/chromium/WebPreferences.cpp:
2034         (WebPreferences::reset):
2035         Initialize the new flag to false.
2036         (WebPreferences::applyTo):
2037         Copy the flag's value to the WebSettings.
2038         * DumpRenderTree/chromium/WebPreferences.h:
2039         Add the new flag.
2040
2041 2010-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2042
2043         Reviewed by Simon Hausmann.
2044
2045         [Qt] Refactor QtWebKitPlatformPlugin interface
2046
2047         Make it easier to keep source-compability for the
2048         QtWebKitPlatformPlugin interface, and run qmake
2049         on the example (but not build) for convenience. 
2050
2051         https://bugs.webkit.org/show_bug.cgi?id=46345
2052
2053         * Scripts/webkitdirs.pm:
2054
2055 2010-09-23  Adam Barth  <abarth@webkit.org>
2056
2057         Reviewed by Eric Seidel.
2058
2059         Tweak some status messages that Eric thought were confusing
2060         https://bugs.webkit.org/show_bug.cgi?id=46342
2061
2062         * Scripts/webkitpy/tool/commands/queues.py:
2063         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2064
2065 2010-09-22  Adam Barth  <abarth@webkit.org>
2066
2067         Reviewed by Eric Seidel.
2068
2069         Fix comm-queue typo
2070         https://bugs.webkit.org/show_bug.cgi?id=46339
2071
2072         We were missing a "self".  The real problem is that we didn't have an
2073         integration test for the failure case.
2074
2075         * Scripts/webkitpy/tool/commands/queues.py:
2076         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2077
2078 2010-09-22  Adam Barth  <abarth@webkit.org>
2079
2080         Reviewed by Eric Seidel.
2081
2082         commit-queue should log more detailed messages to the QueueStatusServer
2083         https://bugs.webkit.org/show_bug.cgi?id=46333
2084
2085         When I created CommitQueueTask, I removed most of the previous logging.
2086         This patch adds back more detailed logging so folks can see their patch
2087         progress through the queue.
2088
2089         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2090         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2091         * Scripts/webkitpy/tool/commands/queues.py:
2092         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2093
2094 2010-09-22  Mihai Parparita  <mihaip@chromium.org>
2095
2096         Reviewed by Darin Fisher.
2097
2098         [Chromium] User style layout tests don't pass on Chromium
2099         https://bugs.webkit.org/show_bug.cgi?id=46069
2100
2101         Fix a typo in LayoutTestController::addUserStyleSheet that was causing a
2102         crash the Chromium DRT. Pass InjectInExistingDocuments to mimic DRT
2103         behavior from other ports.
2104
2105         * DumpRenderTree/chromium/LayoutTestController.cpp:
2106         (LayoutTestController::addUserStyleSheet):
2107
2108 2010-09-22  Brent Fulgham  <bfulgham@webkit.org>
2109
2110         Reviewed by Martin Robinson.
2111
2112         [WinCairo] Part 2: Update WebKitTestRunner and DumpRenderTree Build.
2113         https://bugs.webkit.org/show_bug.cgi?id=46303.
2114
2115         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added.
2116         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Moved
2117         CoreFoundation-specific stuff to new MiniBrowserCoreFoundation
2118         property sheet.
2119         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added.
2120         * MiniBrowser/MiniBrowser.vcproj: Updated configuration to use
2121         appropriate property sheet for the build types.
2122         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Updated the
2123         configuration to use appropriate property sheet for CoreFoundation
2124         and CFLite-style builds.
2125
2126 2010-09-22  Adam Barth  <abarth@webkit.org>
2127
2128         Reviewed by Eric Seidel.
2129
2130         Optimize commit-queue performance for green trees
2131         https://bugs.webkit.org/show_bug.cgi?id=46254
2132
2133         This patch redesigns the controller logic for the commit-queue.  In the
2134         new design, the controller exercises much finer-grained control over
2135         the landing process.  In particular:
2136
2137         - Patches that fail to apply now get rejected almost immediately.
2138         - Patches that fail to build get rejects after two builds (instead of
2139           three builds and one test run).
2140         - Patches that run into a flaky test now get accepted after one build
2141           and two test runs instead of three full build-and-test runs.
2142
2143         The main cost of these optimizations is that we don't find out the tree
2144         has a failing test until the very end of the process, but if the tree
2145         has a busted test, there's not much we can do anyway.  We might as well
2146         burn commit-queue resources spinning optimisticly.
2147
2148         * Scripts/webkitpy/tool/bot/commitqueuetask.py: Added.
2149         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: Added.
2150         * Scripts/webkitpy/tool/commands/queues.py:
2151
2152 2010-09-22  Brent Fulgham  <bfulgham@webkit.org>
2153
2154         Reviewed by Martin Robinson.
2155
2156         [WinCairo] Update WebKitTestRunner and DumpRenderTree Build.
2157         https://bugs.webkit.org/show_bug.cgi?id=46303.
2158
2159         * DumpRenderTree/win/DumpRenderTree.vcproj: Disable local MD5 sources
2160         for Cairo build. Copy wtf MD5 header to ForwardingHeaders for the
2161         WinCairo build.
2162         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added.
2163         * WebKitTestRunner/win/InjectedBundle.vcproj: Update win new *_Cairo
2164         build targets that use the new InjectedBundleCFLite.vsprops file.
2165
2166 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
2167
2168         Unreviewed, build fix.
2169
2170         Fix bustage of rebaseline-chromium-webkit-tests resulting from
2171         r67974. Really need better unit tests for this tool :(
2172
2173         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2174
2175 2010-09-22  Adam Roben  <aroben@apple.com>
2176
2177         Unbreak test-webkitpy
2178
2179         * Scripts/webkitpy/test/main.py:
2180         (Tester.run_tests): Add a line that mysteriously got deleted.
2181
2182 2010-09-22  Adam Roben  <aroben@apple.com>
2183
2184         Make test-webkitpy test WebKit2's scripts
2185
2186         These scripts can't be in WebKitTools due to limitations of Apple's
2187         build process. But that doesn't mean we can't test them!
2188
2189         Fixes <http://webkit.org/b/46297> test-webkitpy should test code in
2190         WebKit2/Scripts
2191
2192         Reviewed by Adam Barth.
2193
2194         * Scripts/test-webkitpy:
2195         (_clean_packages_with_test): Renamed from _clean_webkitpy_with_test.
2196         Now takes an external_package_paths parameter and cleans both webkitpy
2197         and any external packages.
2198         (init): Added an external_package_paths parameter which we pass along
2199         to _clean_packages_with_test.
2200         (top level): Add WebKit2/Scripts/webkit2 as our only external package
2201         and pass it along to init and Tester.run_tests.
2202
2203         * Scripts/webkitpy/test/main.py:
2204         (Tester.run_tests): Added an optional external_package_paths
2205         parameter. We modify sys.path so that the external packages can be
2206         imported, and search for unittest files inside all external packages
2207         in addition to inside webkitpy.
2208
2209 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
2210
2211         Reviewed by Tony Chang.
2212
2213         new-run-webkit-tests: r68063 broke linux python tests
2214
2215         Add a missing "from __future__ import with_statement" to this
2216         new file; the perils of testing only on the Mac and by review :(
2217
2218         https://bugs.webkit.org/show_bug.cgi?id=46293
2219
2220         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2221
2222 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
2223
2224         Reviewed by Tony Chang.
2225
2226         Add a 'chromium-gpu' set of ports that will test the accelerated
2227         GPU paths. This patch adds:
2228
2229         - support for the '--accelerated-compositing' and
2230           'accelerated-2d-canvas' flags to new-run-webkit-tests (and the
2231           'no-' flags)
2232         - adds a new set of Ports that will look under
2233           platform/chromium-gpu-$OS/ for baselines before looking in the
2234           regular chromium search path
2235         - adds a new test_expectations.txt file in platform/chromium-gpu
2236           that skips all but the tests we actually want to run with
2237           acceleration.
2238
2239         This patch will allow us to run both with and without acceleration
2240         and to change the defaults for both the regular and -gpu options
2241         as the code evolves.
2242
2243         We plan to add both --chromium-$OS and --chromium-gpu-$OS runs to
2244         each test bot.
2245
2246         https://bugs.webkit.org/show_bug.cgi?id=46225
2247
2248         * Scripts/webkitpy/layout_tests/port/chromium.py:
2249         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2250         * Scripts/webkitpy/layout_tests/port/factory.py:
2251         * Scripts/webkitpy/layout_tests/port/webkit.py:
2252
2253 2010-09-22  Jamey Hicks  <jamey.hicks@nokia.com>
2254
2255         Reviewed by Kenneth Rohde Christiansen.
2256
2257         [Qt] Web Inspector: Remote Web Inspector support for QtWebKit
2258         https://bugs.webkit.org/show_bug.cgi?id=43988
2259
2260         Runs a web debug server on port specified by QtTestBrowser
2261         argument -remote-inspector-port. Property
2262         _q_webInspectorServerPort of the QWebPage instance will be set
2263         according to the argument. All pages with that property set will
2264         be remotely inspectable.
2265
2266         URL for remote inspection of first QWebPage is
2267             http://localhost:9222/webkit/inspector/inspector.html?page=1
2268         where 1 is the number of the QWebPage instance.
2269
2270         The base URL yields an index page with links to the individual inspectors:
2271             http://localhost:9222/
2272
2273         * QtTestBrowser/launcherwindow.cpp:
2274         (LauncherWindow::init):
2275         * QtTestBrowser/launcherwindow.h:
2276         * QtTestBrowser/main.cpp:
2277         (LauncherApplication::handleUserOptions):
2278
2279 2010-09-22  Adam Roben  <aroben@apple.com>
2280
2281         Fix webkit-patch failure-reason now that build.webkit.org has been
2282         updated
2283
2284         Fixes <http://webkit.org/b/46273> webkit-patch failure-reason crashes
2285         every time
2286
2287         Reviewed by Eric Seidel.
2288
2289         * Scripts/webkitpy/common/net/buildbot.py:
2290         (BuildBot._file_cell_text): Added. Travels down the firstChild chain
2291         looking for an element that contains text, then returns it.
2292         (BuildBot._parse_twisted_file_row): Use _file_cell_text to get the
2293         text out of the cells. This way it doesn't matter whether the cells
2294         have <b> children (as for cells in directory rows) or not (as for
2295         cells in file rows)
2296         (BuildBot._parse_twisted_directory_listing): Look for rows that have
2297         the "directory" or "file" class, rather than rows with any class,
2298         since header rows now have a class attribute.
2299
2300         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2301         (BuildBotTest._example_directory_listing): Updated to more closely
2302         match the markup that build.webkit.org is producing now.
2303
2304 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2305
2306         Unreviewed, build fix.
2307
2308         new-run-webkit-tests: fix bug introduced in r68008 where if you
2309         specify --chromium and no --platform, and you're running on
2310         windows, you use the 'chromium-win' port by default instead of the
2311         version-specific port. This breaks the buildbots.
2312
2313         It will be good for this refactoring to settle down so I can
2314         rewrite the logic for default ports and the unit tests to be
2315         clearer (and the testing more comprehensive).
2316
2317         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2318
2319 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2320
2321         Reviewed by Adam Barth.
2322
2323         Modify the Port interface to take only a series of keyword arguments
2324         in the constructor, and modify Port/factory.get() to accomodate that,
2325         and to accept user=XXX as an argument so we can pass
2326         webkitpy.common.system.user.User objects in.
2327
2328         Then, modify new-run-webkit-tests and rebaseline-chromium-webkit-tests
2329         to use the common routine in webkitpy.common.system.user.open_url()
2330         to display HTML files.
2331
2332         There was a routine in the Port interface to do the same thing,
2333         but I see no need for a port-specific hook for this, since it is
2334         something that will always be executed by the host environment
2335         and displaying web pages has nothing to do with running layout tests.
2336
2337         Note that new-run-webkit-tests used to use test_shell to display
2338         the page; this is potentially useful so that you can actually click
2339         from a result to the broken page; however, since DumpRenderTree
2340         doesn't support this functionality, it will be going away eventually.
2341
2342         https://bugs.webkit.org/show_bug.cgi?id=46128
2343
2344         * Scripts/webkitpy/layout_tests/port/base.py:
2345         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2346         * Scripts/webkitpy/layout_tests/port/chromium.py:
2347         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2348         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2349         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2350         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2351         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2352         * Scripts/webkitpy/layout_tests/port/factory.py:
2353         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2354         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2355         * Scripts/webkitpy/layout_tests/port/gtk.py:
2356         * Scripts/webkitpy/layout_tests/port/mac.py:
2357         * Scripts/webkitpy/layout_tests/port/qt.py:
2358         * Scripts/webkitpy/layout_tests/port/test.py:
2359         * Scripts/webkitpy/layout_tests/port/webkit.py:
2360         * Scripts/webkitpy/layout_tests/port/win.py:
2361         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2362         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2363         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2364
2365 2010-09-21  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2366
2367         Reviewed by Kenneth Rohde Christiansen.
2368
2369         [EFL] Get fresh theme when running EWebLauncher
2370         https://bugs.webkit.org/show_bug.cgi?id=46210
2371
2372         If user tried to run EWebLauncher outside of the build tree, it would
2373         not find the theme and fallback to the installed one. However, since
2374         EWebLauncher is not installed, we always want to take the theme from
2375         the just compiled source code. If user had never installed WebKit's
2376         EFL port it could even receive a segv since no theme would be found.
2377
2378         Now EWebLauncher does not fallback to the installed theme and CMake
2379         gives as DATA_DIR the directory of the theme it has just built.
2380
2381         * CMakeListsEfl.txt: Pass the build directory as DATA_DIR to
2382         EWebLauncher.
2383         * EWebLauncher/main.c: Use only the theme from build director. Do not
2384         fallback to others as this could hide real bugs.
2385         (quit):
2386         (browserCreate):
2387         (findThemePath):
2388         (main):
2389
2390 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2391
2392         Unreviewed, build fix.
2393
2394         Don't pass the --test-shell arg to the Chromium Mac port of DRT;
2395         it just confuses it.
2396
2397         https://bugs.webkit.org/show_bug.cgi?id=46230
2398
2399         * Scripts/webkitpy/layout_tests/port/webkit.py:
2400
2401 2010-09-21  Lucas Forschler  <lforschler@apple.com>
2402
2403         Reviewed by Stephanie Lewis.
2404
2405         Make a new buildbot for Leopard Debug Test
2406
2407         * BuildSlaveSupport/build.webkit.org-config/config.json:
2408
2409 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2410
2411         Unreviewed, build fix.
2412
2413         Fix breakage of Chromium Mac DRT port caused by r67905.
2414
2415         https://bugs.webkit.org/show_bug.cgi?id=46230
2416
2417         * Scripts/webkitpy/layout_tests/port/webkit.py:
2418
2419 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2420
2421         Unreviewed, build fix.
2422
2423         Add missing import of 'tempfile'.
2424
2425         * Scripts/webkitpy/layout_tests/port/chromium.py:
2426
2427 2010-09-17  Dirk Pranke  <dpranke@chromium.org>
2428
2429         Reviewed by Ojan Vafai.
2430
2431         new-run-webkit-tests: pull the list of tests from the Port, and
2432            make it possible to run with no actual test files in the filesystem.
2433
2434         This set of changes allows us to delete the special
2435         webkitpy/layout_tests/data directory and test the generic code without
2436         touching the filesystem (except to write results). This speeds up
2437         test-webkitpy substantially.
2438
2439         This also cleans up and removes several code paths in the generic
2440         code and fixes some minor bugs, notably in the test_expectations
2441         parsing, which was previously fragile if the tests weren't present.
2442
2443         We also change the way we diff image results to be able to do so
2444         in memory, without relying on files. This slows down chromium
2445         test_shell, which always writes images to files, but should speed
2446         up DRT and ImageDiff-based implementations slightly.
2447
2448         Note that pulling the list of tests to run from the Port will allow
2449         ports to specify what tests to run as an inclusive list; previously
2450         you could only do this as an exclusive list by using a 
2451         test_expectations file or Skipped files; nothing actually uses this
2452         feature yet and it's unclear if it should be used.
2453
2454         Note that there are no functional changes -- apart from now 
2455         always printing out the location of the checksum file when we are
2456         tracing test runs -- and the total number of lines of non-test code
2457         actually drops by two.
2458
2459         There is some more cleanup that can be done in the Port/Driver 
2460         interface and in some handling of filenames, but I'll save that
2461         for another change.
2462
2463         https://bugs.webkit.org/show_bug.cgi?id=45801
2464
2465         * Scripts/webkitpy/layout_tests/data/*: Removed.
2466             - no longer need special mock layout_tests_directory in the
2467               repository.
2468         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2469             - add code to display missing text files, checksums when tracing
2470             - update to not look at the filesystem directly.
2471         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2472             - add more unit tests
2473         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2474             - remove tests_are_present flag
2475             - update with changes in Port interface - no longer access
2476               the filesystem directly, although we still use os.path for
2477               filename manipulation.
2478         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2479             - add more unit tests
2480         * Scripts/webkitpy/layout_tests/layout_package/test_files.py: Removed.
2481             - renamed to port/test_files.py
2482         * Scripts/webkitpy/layout_tests/port/base.py:
2483             - change diff_image() to expect actual image data, not filenames
2484             - add expected_checksum(), expected_image(), expected_text() to
2485               return the content of the files so that we don't need a filesystem
2486             - add path_exists(), path_isdir() for filesystem-like access.
2487             - add test_dirs() to keep clobber-test-results from needing to
2488               actually look at a real layout tests dir
2489             - add tests() to return the list of tests to run on the port
2490               (calls port/test_files to do the work).
2491             - add update_baseline() to be able to save new baselines
2492             - add uri_to_test_name() from port/dryrun.py so we can easily check
2493               filename_to_uri()
2494         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2495             - add more unit tests
2496         * Scripts/webkitpy/layout_tests/port/chromium.py:
2497             - change diff_image() to accept image content, not filenames.
2498               This will be slower for test_shell/image_diff, but faster
2499               for DRT/ImageDiff.
2500         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2501             - add more unit tests
2502         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2503             - simplify greatly
2504         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2505             - add more unit tests
2506         * Scripts/webkitpy/layout_tests/port/test.py:
2507             - massive rewrite to use in-script list of tests and expectations
2508         * Scripts/webkitpy/layout_tests/port/test_files.py:
2509             - rename from layout_package/test_files.
2510         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2511             - add unit tests
2512         * Scripts/webkitpy/layout_tests/port/webkit.py:
2513             - update diff_image() to take image contents, not files. Should
2514               make things slightly faster.
2515         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2516             - update with changes to diff_image()
2517         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2518             - update with changes to diff_image()
2519         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2520             - remove tests_are_present from test_expectations
2521             - pull the list of tests from port.tests() instead
2522               of calling test_files.py directly.
2523         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2524             - update unit tests
2525         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2526             - update with changes to 
2527         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2528             - update with change in Port interface
2529         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2530             - update with change in Port interface
2531         * Scripts/webkitpy/style/checkers/test_expectations.py:
2532             - remove the tests_are_present flag
2533
2534 2010-09-21  Anders Carlsson  <andersca@apple.com>
2535
2536         Disable logging.
2537
2538         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2539
2540 2010-09-21  Tony Chang  <tony@chromium.org>
2541
2542         Reviewed by Kent Tamura.
2543
2544         add a script for running webkit_unit_tests
2545         https://bugs.webkit.org/show_bug.cgi?id=46014
2546
2547         * Scripts/run-chromium-webkit-unit-tests: Added.
2548
2549 2010-09-21  Fridrich Strba  <fridrich.strba@bluewin.ch>
2550
2551         Reviewed by Martin Robinson.
2552
2553         Fix linking problems on Windows.
2554         https://bugs.webkit.org/show_bug.cgi?id=45844
2555
2556         * GNUmakefile.am: link the executables with winmm.dll
2557
2558 2010-09-21  Adam Barth  <abarth@webkit.org>
2559
2560         Reviewed by Eric Seidel.
2561
2562         feeder-queue svn updates more often than needed
2563         https://bugs.webkit.org/show_bug.cgi?id=46171
2564
2565         We don't need to poll SVN every time we feed the feeders.  Rather, we
2566         can count on the wrapper shell script to auto-update the queue.
2567
2568         * Scripts/webkitpy/tool/commands/queues.py:
2569         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2570
2571 2010-09-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2572
2573         Reviewed by Andreas Kling.
2574
2575         [Qt] Add robot loader timeout and extra time options.
2576         https://bugs.webkit.org/show_bug.cgi?id=46172
2577
2578         [-robot-timeout <s>]: Load the next page after s seconds if the current
2579         page didn't finish loading.
2580         [-robot-extra-time <s>]: Wait s seconds after the current page finished
2581         loading before loading the next one. This should allow some time for the
2582         page's JavaScript to execute.
2583
2584         * QtTestBrowser/launcherwindow.cpp:
2585         (LauncherWindow::applyPrefs):
2586         * QtTestBrowser/main.cpp:
2587         (LauncherApplication::robotTimeout):
2588         (LauncherApplication::robotExtraTime):
2589         (LauncherApplication::LauncherApplication):
2590         (LauncherApplication::handleUserOptions):
2591         (main):
2592         * QtTestBrowser/urlloader.cpp:
2593         (UrlLoader::UrlLoader):
2594         (UrlLoader::loadNext):
2595         (UrlLoader::loadUrlList):
2596         * QtTestBrowser/urlloader.h:
2597
2598 2010-09-21  Pavel Podivilov  <podivilov@chromium.org>
2599
2600         Unreviewed.
2601
2602         Adding myself to the committers list.
2603
2604         * Scripts/webkitpy/common/config/committers.py:
2605
2606 2010-09-20  Philippe Normand  <pnormand@igalia.com>
2607
2608         Reviewed by Eric Carlson.
2609
2610         [GTK] enhanced context menu for media elements
2611         https://bugs.webkit.org/show_bug.cgi?id=45021
2612
2613         EventSender::contextClick() now returns an array of js
2614         objects. Each object has a title property and a click() method.
2615
2616         * DumpRenderTree/gtk/EventSender.cpp:
2617         (getMenuItemTitleCallback):
2618         (setMenuItemTitleCallback):
2619         (menuItemClickCallback):
2620         (getMenuItemClass):
2621         (contextClickCallback):
2622
2623 2010-09-20  Hayato Ito  <hayato@chromium.org>
2624
2625         Unreviewed.
2626         Adding myself to the committers list.
2627
2628         * Scripts/webkitpy/common/config/committers.py:
2629
2630 2010-09-20  Adam Barth  <abarth@webkit.org>
2631
2632         Reviewed by Eric Seidel.
2633
2634         The tool member variable should be called _tool
2635         https://bugs.webkit.org/show_bug.cgi?id=46160
2636
2637         Created by find-and-replace.
2638
2639         * Scripts/webkitpy/tool/commands/download.py:
2640         * Scripts/webkitpy/tool/commands/openbugs.py:
2641         * Scripts/webkitpy/tool/commands/queries.py:
2642         * Scripts/webkitpy/tool/commands/queues.py:
2643         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2644         * Scripts/webkitpy/tool/commands/rebaseline.py:
2645         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2646         * Scripts/webkitpy/tool/commands/upload.py:
2647         * Scripts/webkitpy/tool/multicommandtool.py:
2648
2649 2010-09-20  Adam Barth  <abarth@webkit.org>
2650
2651         I ran the tests before landing but ignored the fact that they failed.  :(
2652
2653         * Scripts/webkitpy/tool/commands/queues.py:
2654
2655 2010-09-20  Adam Barth  <abarth@webkit.org>
2656
2657         Reviewed by Eric Seidel.
2658
2659         Add a feeder queue that polls bugs.webkit.org for the commit-cluster
2660         https://bugs.webkit.org/show_bug.cgi?id=46141
2661
2662         The feeder-queue polls bugs.webkit.org every 30 seconds and updates the
2663         list of work items on the status server.  The individual commit-cluster
2664         nodes then grab the patches from the server and process them.
2665
2666         * Scripts/webkitpy/tool/bot/feeders.py: Added.
2667         * Scripts/webkitpy/tool/bot/feeders_unittest.py: Added.
2668         * Scripts/webkitpy/tool/commands/queues.py:
2669         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2670         * Scripts/webkitpy/tool/commands/queuestest.py:
2671
2672 2010-09-20  Leandro Pereira  <leandro@profusion.mobi>
2673
2674         Reviewed by Darin Adler.
2675
2676         build-webkit: Add support for CMake build system
2677         https://bugs.webkit.org/show_bug.cgi?id=44979
2678
2679         * Scripts/build-webkit: Add "--efl" command-line option to build the
2680         EFL port of WebKit.
2681         * Scripts/webkitdirs.pm: Define buildCMakeProject() and
2682         buildEflCMakeProject() subroutines.
2683
2684 2010-09-20  Dirk Pranke  <dpranke@chromium.org>
2685
2686         Reviewed by Ojan Vafai.
2687
2688         new-run-webkit-tests: refactor command line args getting passed to DRT
2689
2690         This change cleans up some argument parsing between functions to get
2691         rid of some overlapping data structures. There should be no functional
2692         changes in this patch; it is pure refactoring in preparation for
2693         landing the Chrome GPU port and adding a generic way to pass
2694         args to DRT/TestShell.
2695
2696         https://bugs.webkit.org/show_bug.cgi?id=46135
2697
2698         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2699           - pass the options argument explicitly to the threads and drivers,
2700             also consolidate the passing of options to the driver.
2701           - pass options directly to process_output() to remove a couple
2702             parameters (minor cleanup).
2703         * Scripts/webkitpy/layout_tests/port/base.py:
2704           - pass the options argument to Port.create_driver().
2705         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2706           - update Port.create_driver() test
2707         * Scripts/webkitpy/layout_tests/port/chromium.py:
2708           - pass the options argument to Port.create_driver(), and clean up
2709             building of the cmd line for DRT.
2710         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2711           - pass the options argument to Port.create_driver()
2712         * Scripts/webkitpy/layout_tests/port/test.py:
2713           - pass the options argument to Port.create_driver()
2714         * Scripts/webkitpy/layout_tests/port/webkit.py:
2715           - pass the options argument to Port.create_driver(), and clean up
2716             building of the cmd line for DRT.
2717         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2718           - consolidate args in _get_dump_render_tree_args and rename to
2719             _get_test_args(); move all of the command-line args to the
2720             Port implementations.
2721
2722 2010-09-20  Andrew Wilson  <atwilson@chromium.org>
2723
2724         Revert change which was accidentally committed along with some expectation changes.
2725
2726         * Scripts/webkitpy/layout_tests/port/base.py:
2727
2728 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
2729
2730         Reviewed by Adam Barth.
2731
2732         Add explicit --force-patch flag to webkitpy tools
2733         https://bugs.webkit.org/show_bug.cgi?id=46103
2734         
2735         It wasn't obvious until I read the applypatch.py source code that
2736         --non-interfactive implies passing --force to patch. Add --force-patch
2737         as an alias to the flag, so that this behavior is more discoverable.
2738
2739         * Scripts/webkitpy/tool/steps/applypatch.py:
2740         * Scripts/webkitpy/tool/steps/options.py:
2741
2742 2010-09-20  Eric Seidel  <eric@webkit.org>
2743
2744         Unreviewed, adding a line which got dropped and is trivially correct (and tested).
2745
2746         commit-queue can't land patches
2747         https://bugs.webkit.org/show_bug.cgi?id=46138
2748
2749         Add a line of code I forgot in my last commit.
2750
2751         * Scripts/webkitpy/common/net/bugzilla.py:
2752         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
2753
2754 2010-09-20  Adam Barth  <abarth@webkit.org>
2755
2756         Reviewed by Eric Seidel.
2757
2758         The commit-cluster bots still race to lock patch_ids
2759         https://bugs.webkit.org/show_bug.cgi?id=46130
2760
2761         It turns out we need to use a transaction object to make the
2762         read/modify/write lock operation atomic.  From reading the AppEngine
2763         documentation, I think this patch should do what we want.  It's hard to
2764         test locally because the test instance isn't distributed in the same
2765         way the production instance is.
2766
2767         * QueueStatusServer/handlers/nextpatch.py:
2768         * QueueStatusServer/model/activeworkitems.py: Added.
2769
2770 2010-09-20  Andy Estes  <aestes@apple.com>
2771
2772         Reviewed by Adam Barth.
2773
2774         REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
2775         https://bugs.webkit.org/show_bug.cgi?id=40961
2776
2777         Implement WebKitUsePreHTML5ParserQuirks preference.
2778
2779         * DumpRenderTree/mac/DumpRenderTree.mm:
2780         (resetDefaultsToConsistentValues): Reset WebKitUsePreHTML5ParserQuirks
2781         to false after a test finishes.
2782
2783 2010-09-20  Adam Roben  <aroben@apple.com>
2784
2785         Windows build fix
2786
2787         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Put
2788         $(WebKitOutputDir)\include before $(WebKitLibrariesDir)\include so
2789         we'll pick up the most recent versions of the headers.
2790
2791 2010-09-20  Eric Seidel  <eric@webkit.org>
2792
2793         Reviewed by Adam Barth.
2794
2795         commit-queue should check commit-queue+ again just before committing
2796         https://bugs.webkit.org/show_bug.cgi?id=32679
2797
2798         Added a _revalidate_patch check, right before landing.
2799
2800         Since _revalidate_patch passes the patch_id from the work item
2801         back to bugzilla, I had to fix all of the previous queue tests to
2802         use valid attachment ids (that's the majority of this change).
2803
2804         In order to validate that the bug was still open, I had to teach
2805         bugzilla.Bug about open/closed states.
2806
2807         * Scripts/webkitpy/common/net/bugzilla.py:
2808         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2809         * Scripts/webkitpy/tool/commands/queues.py:
2810         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2811         * Scripts/webkitpy/tool/commands/queuestest.py:
2812         * Scripts/webkitpy/tool/mocktool.py:
2813
2814 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
2815
2816         Unreviewed.
2817
2818         Adding myself as a comitter.
2819
2820         * Scripts/webkitpy/common/config/committers.py:
2821
2822 2010-09-20  Adam Barth  <abarth@webkit.org>
2823
2824         Reviewed by Eric Seidel.
2825
2826         Two instances of commit-queue try to process the same patch
2827         https://bugs.webkit.org/show_bug.cgi?id=46113
2828
2829         This patch makes next-patch atomic so that the server won't vend the
2830         same patch twice in the same hour.
2831
2832         * QueueStatusServer/handlers/nextpatch.py:
2833
2834 2010-09-20  Adam Roben  <aroben@apple.com>
2835
2836         Make WebKitTestRunner's wait-to-dump watchdog timer work on Windows
2837
2838         We were previously trying to use a CFRunLoopTimer, but since Windows
2839         doesn't use CFRunLoop on most threads this doesn't work. Now we use a
2840         Windows-style timer on Windows.
2841
2842         I also replaced all uses of "watchdog" with "watchdog timer".
2843
2844         Fixes <http://webkit.org/b/46101> WebKitTestRunner's wait-to-dump
2845         watchdog timer doesn't work on Windows
2846
2847         Reviewed by Anders Carlsson.
2848
2849         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2850         (WTR::InjectedBundlePage::dump): Updated for rename.
2851
2852         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Removed
2853         platform-specific functions.
2854         (WTR::LayoutTestController::LayoutTestController): Added call to
2855         platformInitialize.
2856         (WTR::LayoutTestController::waitUntilDone): Changed to call
2857         initializeWaitToDumpWatchdogTimerIfNeeded instead of doing the work
2858         right in this function.
2859         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Updated for
2860         rename.
2861
2862         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added new
2863         members needed to support the watchdog timer abstraction. Replaced
2864         some "watchdog"s with "watchdog timer".
2865
2866         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
2867         Added.
2868         (WTR::LayoutTestController::platformInitialize): Does nothing on this
2869         platform.
2870         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Moved here
2871         from LayoutTestController.cpp and changed to use an early return.
2872         (WTR::waitUntilDoneWatchdogTimerFired): Moved here from
2873         LayoutTestController.cpp.
2874         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
2875         Moved code here from LayoutTestController::waitUntilDone and changed
2876         to use an early return.
2877
2878         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
2879         Added.
2880         (WTR::LayoutTestController::platformInitialize): Initialize our
2881         watchdog timer.
2882         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Added.
2883         Kills and clears the watchdog timer.
2884         (WTR::waitToDumpWatchdogTimerFired): Added. Calls through to the
2885         LayoutTestController member function of the same name.
2886         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
2887         Added. Sets up the timer if it isn't already set.
2888
2889         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added
2890         LayoutTestControllerMac.mm.
2891
2892         * WebKitTestRunner/win/InjectedBundle.vcproj: Added
2893         LayoutTestControllerWin.cpp.
2894
2895 2010-09-20  Martin Robinson  <mrobinson@igalia.com>
2896
2897         Reviewed by Daniel Bates.
2898
2899         [GTK] fast/forms/listbox-selection.html fails
2900         https://bugs.webkit.org/show_bug.cgi?id=45942
2901
2902         Use the gdkModifersFromJSValue helper to parse all appropriate modifier
2903         strings in keyDownCallback.
2904
2905         * DumpRenderTree/gtk/EventSender.cpp:
2906         (keyDownCallback): Use the gdkModifersFromJSValue instead of duplicating the 
2907         modifier parsing logic.
2908
2909 2010-09-19  Sam Weinig  <sam@webkit.org>
2910
2911         Reviewed by Anders Carlsson.
2912
2913         WebKit2 decidePolicyForNavigationAction should include mouse button information
2914         <rdar://problem/8413165>
2915         https://bugs.webkit.org/show_bug.cgi?id=46060
2916
2917         * MiniBrowser/mac/BrowserWindowController.m:
2918         (decidePolicyForNavigationAction):
2919         (decidePolicyForNewWindowAction):
2920
2921 2010-09-19  Daniel Bates  <dbates@rim.com>
2922
2923         Reviewed by Martin Robinson.
2924
2925         Add unit tests for diffs that delete or modify a change log entry
2926         or describe changes that are far apart
2927         https://bugs.webkit.org/show_bug.cgi?id=46046
2928
2929         Add additional unit tests to test change log diffs that contain
2930         deletions or changes that are far apart from each other in the
2931         ChangeLog file.
2932
2933         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
2934           - Added the following unit tests:
2935           "fixChangeLogPatch: [no change] In-place change."
2936           "fixChangeLogPatch: [no change] Remove first entry."
2937           "fixChangeLogPatch: [no change] Remove entry in the middle."
2938           "fixChangeLogPatch: [no change] Far apart changes (i.e. more than one chunk)."
2939
2940 2010-09-19  Sam Weinig  <sam@webkit.org>
2941
2942         Reviewed by Anders Carlsson.
2943
2944         Replace WKBundleRangeRef with WKBundleRangeHandleRef.
2945         https://bugs.webkit.org/show_bug.cgi?id=46054
2946
2947         The new one acts like WKBundleNodeHandleRef and allows for getting a
2948         wrapper in a specific world for the handle.
2949
2950         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2951         (WTR::propertyValue):
2952         (WTR::propertyValueDouble):
2953         (WTR::propertyValueInt):
2954         (WTR::numericWindowPropertyValue):
2955         (WTR::toStr):
2956         (WTR::InjectedBundlePage::shouldBeginEditing):
2957         (WTR::InjectedBundlePage::shouldEndEditing):
2958         (WTR::InjectedBundlePage::shouldInsertNode):
2959         (WTR::InjectedBundlePage::shouldInsertText):
2960         (WTR::InjectedBundlePage::shouldDeleteRange):
2961         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
2962         (WTR::InjectedBundlePage::shouldApplyStyle):
2963         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2964
2965 2010-09-19  Kent Tamura  <tkent@chromium.org>
2966
2967         Unreviewed. Fix WebGL test regressions by r67809.
2968
2969         * DumpRenderTree/chromium/WebPreferences.cpp:
2970         (WebPreferences::applyTo): Call setExperimentalWebGLEnabled().
2971
2972 2010-09-19  Kent Tamura  <tkent@chromium.org>
2973
2974         Reviewed by Adam Barth.
2975
2976         [DRT/Chromium] Fix a WebSettings handling bug
2977         https://bugs.webkit.org/show_bug.cgi?id=45945
2978
2979         Before this change, Chromium DRT reset WebSettings for every new
2980         window. It was wrong.
2981         If new window is not the first one, we have to apply the same
2982         settings as the first window.  So, we introduce WebPreference to
2983         store the current settings, and apply it to new windows. It's same
2984         as test_shell's behavior.
2985
2986         * DumpRenderTree/DumpRenderTree.gypi:
2987         * DumpRenderTree/chromium/LayoutTestController.cpp:
2988           Use WebPreferences instead of WebSettings.
2989         (LayoutTestController::setUserStyleSheetEnabled):
2990         (LayoutTestController::setUserStyleSheetLocation):
2991         (LayoutTestController::setAuthorAndUserStylesEnabled):
2992         (LayoutTestController::setPopupBlockingEnabled):
2993         (LayoutTestController::disableImageLoading):
2994         (LayoutTestController::setJavaScriptCanAccessClipboard):
2995         (LayoutTestController::setXSSAuditorEnabled):
2996         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
2997         (LayoutTestController::setAllowFileAccessFromFileURLs):
2998         (LayoutTestController::overridePreference):
2999         (LayoutTestController::setEditingBehavior):
3000         * DumpRenderTree/chromium/TestShell.cpp:
3001         (TestShell::resetWebSettings): Use WebPreferences.
3002         (TestShell::runFileTest): ditto.
3003         (TestShell::createNewWindow): Apply existing WebPreferences to a new WebView.
3004         * DumpRenderTree/chromium/TestShell.h:
3005         (TestShell::preferences):
3006         (TestShell::applyPreferences):
3007         * DumpRenderTree/chromium/WebPreferences.cpp: Added.
3008         * DumpRenderTree/chromium/WebPreferences.h: Added.
3009
3010 2010-09-18  Prasad Tammana  <prasadt@chromium.org>
3011
3012         Reviewed by David Levin.
3013
3014         update-webkit --chromium spitting out a spurious error
3015         https://bugs.webkit.org/show_bug.cgi?id=45868
3016
3017         * Scripts/update-webkit-chromium: Use commandExists() function to check for existence of gclient.
3018
3019 2010-09-18  Sam Weinig  <sam@webkit.org>
3020
3021         Reviewed by Dan Bernstein.
3022
3023         Improve/unify the PageLoadClient interfaces
3024         https://bugs.webkit.org/show_bug.cgi?id=46043
3025
3026         * MiniBrowser/mac/BrowserWindowController.m:
3027         (didStartProvisionalLoadForFrame):
3028         (didReceiveServerRedirectForProvisionalLoadForFrame):
3029         (didFailProvisionalLoadWithErrorForFrame):
3030         (didCommitLoadForFrame):
3031         (didFinishDocumentLoadForFrame):
3032         (didFinishLoadForFrame):
3033         (didFailLoadWithErrorForFrame):
3034         (didReceiveTitleForFrame):
3035         (didFirstLayoutForFrame):
3036         (didFirstVisuallyNonEmptyLayoutForFrame):
3037         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3038         (WTR::InjectedBundlePage::InjectedBundlePage):
3039         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
3040         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
3041         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
3042         (WTR::InjectedBundlePage::didCommitLoadForFrame):
3043         (WTR::InjectedBundlePage::didFinishLoadForFrame):
3044         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
3045         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
3046         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
3047         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3048         * WebKitTestRunner/TestController.cpp:
3049         (WTR::TestController::didReceiveMessageFromInjectedBundle):
3050         (WTR::TestController::didFinishLoadForFrame):
3051         * WebKitTestRunner/TestController.h:
3052
3053 2010-09-17  Eric Seidel  <eric@webkit.org>
3054
3055         Unreviewed.  Adding a shell script I use to run the
3056         commit-queue. Now that multiple machines run the cq,
3057         it makes sense to share the script between them.
3058
3059         * EWSTools/start-commit-queue.sh: Added.
3060
3061 2010-09-17  Brian Weinstein  <bweinstein@apple.com>
3062
3063         Reviewed by Jon Honeycutt.
3064
3065         The colors on the new build.webkit.org (after upgrading the master to 0.8.1) are
3066         slightly harder to read, so this reverts the previous background colors for various
3067         states, making it easier to read.
3068
3069         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
3070         (.success):
3071         (.failure):
3072         (.warnings):
3073         (.exception):
3074         (.start,.running,td.building):
3075         (.offline,td.offline):
3076
3077 2010-09-17  Sheriff Bot  <webkit.review.bot@gmail.com>
3078
3079         Unreviewed, rolling out r67692.
3080         http://trac.webkit.org/changeset/67692
3081         https://bugs.webkit.org/show_bug.cgi?id=46011
3082
3083         broke layout test dashboard (Requested by johnny_g on
3084         #webkit).
3085
3086         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3087         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3088         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3089
3090 2010-09-17  Martin Robinson  <mrobinson@igalia.com>
3091
3092         Reviewed by Oliver Hunt.
3093
3094         Style bot complains about cairo forward declaration naming
3095         https://bugs.webkit.org/show_bug.cgi?id=45867
3096
3097         Exclude Cairo forward declarations from indentifiers with underscores checks.
3098
3099         * Scripts/webkitpy/style/checkers/cpp.py: Add exclusion for Cairo forward-declarations.
3100         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
3101
3102 2010-09-16  Kinuko Yasuda  <kinuko@chromium.org>
3103
3104         Reviewed by Ojan Vafai.
3105
3106         Include detailed test modifiers (e.g. FLAKY) in results.json for failing non-layout tests
3107         https://bugs.webkit.org/show_bug.cgi?id=45408
3108
3109         This change also tries to remove duplicated upload_results_json methods
3110         in run_webkit_tests.py and json_results_generator.py.
3111
3112         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3113         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3114         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3115
3116 2010-09-16  Antonio Gomes  <tonikitoo@webkit.org>
3117
3118         Reviewed by Andreas Kling.
3119
3120         [Qt] When switching views (WebViewGraphicsBased <--> WebViewTraditional), QWebPage signals and QActions have to be re-set.
3121
3122         Recently r67554 changed the way different views use the WebPage class: it was previously being shared between
3123         different views, but now for each view switch, a new WebPage class is constructed and set. Signals and QAction's
3124         were not being set to the new WebPage though. Patch fix that, by re constructing the toolbar, and then re-hooking
3125         all page specific stuff to the UI.
3126
3127         * QtTestBrowser/launcherwindow.cpp:
3128         (LauncherWindow::initializeView):
3129         * QtTestBrowser/mainwindow.cpp:
3130         (MainWindow::MainWindow):
3131         (MainWindow::buildUI):
3132         (MainWindow::setPage):
3133         * QtTestBrowser/mainwindow.h:
3134
3135 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3136
3137         Reviewed by Andreas Kling.
3138
3139         Make all accesses to m_item (GraphicsWebView) done by WebViewGraphicsBased class happen though graphicsWebView getter method.
3140
3141         This patch is mostly a preparation for another commit, where the ownership of the m_item/GraphicsWebView
3142         object will move to the qgraphicsscene instead of the qgraphicsview.
3143
3144         * QtTestBrowser/webview.cpp:
3145         (WebViewGraphicsBased::setPage):
3146         (WebViewGraphicsBased::setResizesToContents):
3147         (WebViewGraphicsBased::resizeEvent):
3148         (WebViewGraphicsBased::animatedFlip):
3149         * QtTestBrowser/webview.h:
3150         (WebViewGraphicsBased::setItemCacheMode):
3151         (WebViewGraphicsBased::itemCacheMode):
3152
3153 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3154
3155         Reviewed by Andreas Kling.
3156
3157         Moved setYRotation method body out of the class (WebViewGraphicsBased) definition.
3158
3159         We usually separate methods whose body are larger than a few lines from the class definition.
3160
3161         * QtTestBrowser/webview.h:
3162         (WebViewGraphicsBased::yRotation):
3163         (WebViewGraphicsBased::setYRotation):
3164
3165 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3166
3167         Reviewed by Andreas Kling.
3168
3169         Make initializeView method of LauncherWindow private.
3170
3171         No one else needs to be able to call it but LauncherWindow.
3172         Also moving the declation of isGraphicsBased method down in the same file, in order
3173         to better group related methods.
3174
3175         * QtTestBrowser/launcherwindow.h:
3176
3177 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3178
3179         Reviewed by Andreas Kling.
3180
3181         Make the getter 'page' method of MainWindow const.
3182
3183         * QtTestBrowser/mainwindow.cpp:
3184         (MainWindow::page):
3185         * QtTestBrowser/mainwindow.h:
3186
3187 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3188
3189         Reviewed by Andreas Kling.
3190
3191         Remove useless parameter from MainWindow class' constructor.
3192
3193         The parameter defaults to an empty URL and is not being used by any caller. Apart from that it is also
3194         not referred in the constructor body and does not make much sense.
3195
3196         * QtTestBrowser/mainwindow.cpp:
3197         (MainWindow::MainWindow):
3198         * QtTestBrowser/mainwindow.h:
3199
3200 2010-09-15  Tony Chang  <tony@chromium.org>
3201
3202         Reviewed by Kent Tamura.
3203
3204         [Chromium] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
3205         https://bugs.webkit.org/show_bug.cgi?id=42151
3206
3207         * DumpRenderTree/chromium/LayoutTestController.cpp:
3208         (LayoutTestController::LayoutTestController):
3209         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
3210         (WorkItemLoadHTMLString::run):
3211         (LayoutTestController::queueLoadHTMLString):
3212         (LayoutTestController::reset):
3213         (LayoutTestController::setDeferMainResourceDataLoad):
3214         * DumpRenderTree/chromium/LayoutTestController.h:
3215         (LayoutTestController::deferMainResourceDataLoad):
3216         * DumpRenderTree/chromium/WebViewHost.cpp:
3217         (WebViewHost::didCreateDataSource):
3218
3219 2010-09-16  Adrienne Walker  <enne@google.com>
3220
3221         Reviewed by Kenneth Russell.
3222
3223         Add script to synchronize WebKit and Khronos WebGL tests
3224         https://bugs.webkit.org/show_bug.cgi?id=42336
3225
3226         * Scripts/update-webgl-conformance-tests: Added.
3227         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py: Added.
3228         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py: Added.
3229
3230 2010-09-16  Sam Weinig  <sam@webkit.org>
3231
3232         Reviewed by Anders Carlsson.
3233
3234         Add support for sending synchronous messages from the InjectedBundle to the WKContext
3235         <rdar://problem/8365320>
3236         https://bugs.webkit.org/show_bug.cgi?id=44785
3237
3238         * MiniBrowser/mac/AppDelegate.m:
3239         (didReceiveSynchronousMessageFromInjectedBundle):
3240         (-[BrowserAppDelegate init]):
3241         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3242         (didCreatePage):
3243         * WebKitTestRunner/TestController.cpp:
3244         (WTR::TestController::initialize):
3245
3246 2010-09-16  Leonid Ebril  <leonid.ebril@nokia.com>
3247
3248         Reviewed by Andreas Kling.
3249
3250         [Qt] QtTestBrowser: Disable creation of a new window for screenshot on Symbian platform.
3251         https://bugs.webkit.org/show_bug.cgi?id=45885
3252
3253         Avoid creation of an additional window for screenshot to prevent overlapping with original window.
3254
3255         * QtTestBrowser/launcherwindow.cpp:
3256         (LauncherWindow::screenshot):
3257
3258 2010-09-16  Anders Carlsson  <andersca@apple.com>
3259
3260         Fix clang++ build.
3261
3262         * MiniBrowser/mac/BrowserWindowController.m:
3263         (-[BrowserWindowController zoomIn:]):
3264         (-[BrowserWindowController zoomOut:]):
3265         (-[BrowserWindowController resetZoom:]):
3266         Remove trailing semicolons.
3267
3268 2010-09-16  Sheriff Bot  <webkit.review.bot@gmail.com>
3269
3270         Unreviewed, rolling out r67628.
3271         http://trac.webkit.org/changeset/67628
3272         https://bugs.webkit.org/show_bug.cgi?id=45904
3273
3274         broke the build (Requested by eric_carlson on #webkit).
3275
3276         * DumpRenderTree/gtk/EventSender.cpp:
3277         (contextClickCallback):
3278
3279 2010-09-16  Balazs Kelemen  <kbalazs@webkit.org>
3280
3281         Unreviewed.
3282
3283         Adding myself as a comitter.
3284
3285         * Scripts/webkitpy/common/config/committers.py:
3286
3287 2010-09-15  Philippe Normand  <pnormand@igalia.com>
3288
3289         Reviewed by Eric Carlson.
3290
3291         [GTK] enhanced context menu for media elements
3292         https://bugs.webkit.org/show_bug.cgi?id=45021
3293
3294         EventSender::contextClick() now returns an array of js
3295         objects. Each object has a title property and a click() method.
3296
3297         * DumpRenderTree/gtk/EventSender.cpp:
3298         (getMenuItemTitleCallback):
3299         (setMenuItemTitleCallback):
3300         (menuItemClickCallback):
3301         (getMenuItemClass):
3302         (contextClickCallback):
3303
3304 2010-09-14  Philippe Normand  <pnormand@igalia.com>
3305
3306         Reviewed by Eric Carlson and Martin Robinson.
3307
3308         [GTK] eventSender.contextClick() should return the contents of the context menu
3309         https://bugs.webkit.org/show_bug.cgi?id=39102
3310
3311         Make the eventSender use the new private WebKitGtk+ API to
3312         retrieve the context-menu item titles and store them in an array.
3313
3314         * DumpRenderTree/gtk/EventSender.cpp:
3315         (contextClickCallback):
3316
3317 2010-09-16  Eric Uhrhane  <ericu@chromium.org>
3318
3319         Reviewed by Jian Li.
3320
3321         Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
3322         https://bugs.webkit.org/show_bug.cgi?id=45798
3323
3324         * Scripts/build-webkit:
3325
3326 2010-09-16  Robert Hogan  <robert@webkit.org>
3327
3328         Reviewed by Antonio Gomes.
3329
3330         [Qt] Support globalhistory tests
3331         https://bugs.webkit.org/show_bug.cgi?id=45774
3332
3333         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3334         (WebCore::isGlobalHistoryTest):
3335         (WebCore::DumpRenderTree::open):
3336         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3337         (LayoutTestController::reset):
3338         (LayoutTestController::dumpHistoryCallbacks):
3339         (LayoutTestController::removeAllVisitedLinks):
3340         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3341
3342 2010-09-10  Tony Chang  <tony@chromium.org>
3343
3344         Reviewed by Eric Seidel.
3345
3346         deduplicate-tests should be runnable from any WebKit directory
3347         https://bugs.webkit.org/show_bug.cgi?id=44709
3348
3349         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
3350         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3351
3352 2010-09-15  Tony Chang  <tony@chromium.org>
3353
3354         Reviewed by Kent Tamura.
3355
3356         [chromium] sort testing methods in DRT
3357         https://bugs.webkit.org/show_bug.cgi?id=45850
3358
3359         * DumpRenderTree/chromium/EventSender.cpp:
3360         (EventSender::EventSender):
3361         * DumpRenderTree/chromium/LayoutTestController.cpp:
3362         (LayoutTestController::LayoutTestController):
3363         * DumpRenderTree/chromium/TextInputController.cpp:
3364         (TextInputController::TextInputController):
3365
3366 2010-09-15  Mihai Parparita  <mihaip@chromium.org>
3367
3368         Reviewed by Adam Barth.
3369
3370         CQ status shows items out of order
3371         https://bugs.webkit.org/show_bug.cgi?id=45846
3372         
3373         Only group consecutive status items with the same patch ID into the same
3374         group, so that overall item ordering is preserved.
3375         
3376         Also don't indent status items that only have a single item in their
3377         group.
3378
3379         * QueueStatusServer/handlers/queuestatus.py:
3380         * QueueStatusServer/templates/includes/singlequeuestatus.html: Added.
3381         * QueueStatusServer/templates/queuestatus.html:
3382
3383 2010-09-15  Eric Seidel  <eric@webkit.org>
3384
3385         Reviewed by Adam Barth.
3386
3387         Add queue start/stop messages
3388         https://bugs.webkit.org/show_bug.cgi?id=45853
3389
3390         I ended up needing to clean up a bunch of our unit testing
3391         in order to test this new code path nicely.
3392
3393         There are also a few PEP8 changes needed to pass check-webkit-style.
3394
3395         * Scripts/webkitpy/tool/bot/queueengine.py:
3396         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
3397         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3398         * Scripts/webkitpy/tool/commands/queues.py:
3399         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3400         * Scripts/webkitpy/tool/commands/queuestest.py:
3401         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
3402
3403 2010-09-15  Simon Fraser  <simon.fraser@apple.com>
3404
3405         https://bugs.webkit.org/show_bug.cgi?id=45849
3406         WKURLCreateWithCFURL crashes with null url
3407         
3408         Fix MiniBrowser crash when the url is not parseable.
3409
3410         * MiniBrowser/mac/BrowserWindowController.m:
3411         (-[BrowserWindowController fetch:]):
3412
3413 2010-09-15  Patrick Gansterer  <paroga@paroga.com>
3414
3415         Unreviewed.
3416
3417         Adding myself to the committers list.
3418
3419         * Scripts/webkitpy/common/config/committers.py:
3420
3421 2010-09-14  Eric Seidel  <eric@webkit.org>
3422
3423         Reviewed by Adam Barth.
3424
3425         Make it possible to run more than one commit-queue instance
3426         https://bugs.webkit.org/show_bug.cgi?id=45786
3427
3428         Mostly we need to make sure the two (or more) instances get
3429         different patches to work on.  To do this, I re-worked
3430         the code responsible for getting the next work item to
3431         round trip through the status server.  The status server only
3432         vends patches from the work items list, only if those patches
3433         have not had status reported for them in the last hour.
3434
3435         This is another step towards making all queues go through the
3436         status server, thus making it possible to run more than one
3437         instance of various EWS bots (as requested in bug 44292).
3438
3439         The webkitpy changes are already covered by existing unit tests.
3440         The QueueStatusSever sadly has no testing infrastructure yet. :(
3441
3442         * QueueStatusServer/handlers/nextpatch.py: Added.
3443         * QueueStatusServer/index.yaml:
3444         * QueueStatusServer/main.py:
3445         * Scripts/webkitpy/tool/commands/queues.py:
3446
3447 2010-09-15  Mihai Parparita  <mihaip@chromium.org>
3448
3449         Reviewed by Tony Chang.
3450
3451         NRWT fails with UnicodeDecodeError on editing/selection/mixed-editability-10.html
3452         https://bugs.webkit.org/show_bug.cgi?id=45791
3453
3454         Force filenames to be raw bytes before running difflib.unified_diff.
3455
3456         * Scripts/webkitpy/layout_tests/port/base.py:
3457         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3458
3459 2010-09-15  Simon Hausmann  <simon.hausmann@nokia.com>
3460
3461         Reviewed by Tor Arne Vestbø.
3462
3463         [Qt] QtTestBrowser crashes when enabling QGraphicsView mode after first loading page without it enabled
3464         https://bugs.webkit.org/show_bug.cgi?id=35247
3465
3466         The main issue when changing the views is that the plugins and any other components that
3467         depend on view specific attributes such as the native window id are not teared down.
3468         Even if we had a tear-down procedure, we'd have to re-initialize the plugin after
3469         switching to the new view (QGraphicsWebView). This is a rather uncommon situation, so
3470         we decided to work around this in QtTestBrowser by making toggling between QWebView
3471         and QGraphicsWebView also re-create the page.
3472
3473         * QtTestBrowser/launcherwindow.cpp:
3474         (LauncherWindow::initializeView):
3475         * QtTestBrowser/mainwindow.h:
3476
3477 2010-09-14  Mihai Parparita  <mihaip@chromium.org>
3478
3479         Reviewed by Adam Barth.
3480
3481         Send webkit accessibility notifications to Chromium
3482         https://bugs.webkit.org/show_bug.cgi?id=45156
3483
3484         Move printf inside shouldDumpAccessibilityNotifications check.
3485
3486         * DumpRenderTree/chromium/WebViewHost.cpp:
3487         (WebViewHost::postAccessibilityNotification):
3488
3489 2010-09-14  Tony Chang  <tony@chromium.org>
3490
3491         Reviewed by Kent Tamura.
3492
3493         [chromium] fix http/tests/security/local-user-CSS-from-remote.html
3494         https://bugs.webkit.org/show_bug.cgi?id=45788
3495
3496         * DumpRenderTree/chromium/LayoutTestController.cpp:
3497         (LayoutTestController::setUserStyleSheetLocation): use a base64 url like in Chrome
3498
3499 2010-09-14  Tony Chang  <tony@chromium.org>
3500
3501         Reviewed by Ojan Vafai.
3502
3503         [chromium] Remove WebKit::areLayoutTestImagesOpaque since it's no longer needed
3504         https://bugs.webkit.org/show_bug.cgi?id=45768
3505
3506         * DumpRenderTree/chromium/TestShell.cpp:
3507         (TestShell::dumpImage): new baselines are checked in and Linux will match Windows going forward.
3508
3509 2010-09-14  Kevin Ollivier  <kevino@theolliviers.com>
3510
3511         [wx] Build fix, add newly added directories to the directory list.
3512
3513         * wx/build/settings.py:
3514
3515 2010-09-14  Sam Weinig  <sam@webkit.org>
3516
3517         Reviewed by Anders Carlsson.
3518
3519         Remove WKBundleNodeRef, replacing uses with WKBundleNodeHandleRef.
3520         https://bugs.webkit.org/show_bug.cgi?id=45785
3521
3522         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3523         (WTR::propertyValue):
3524         (WTR::numericWindowPropertyValue):
3525         (WTR::dumpPath):
3526         (WTR::toStr):
3527         (WTR::operator<<):
3528         (WTR::InjectedBundlePage::InjectedBundlePage):
3529         (WTR::InjectedBundlePage::shouldInsertNode):
3530         (WTR::InjectedBundlePage::shouldBeginEditing):
3531         (WTR::InjectedBundlePage::shouldEndEditing):
3532         (WTR::InjectedBundlePage::shouldInsertText):
3533         (WTR::InjectedBundlePage::shouldDeleteRange):
3534         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
3535         (WTR::InjectedBundlePage::shouldApplyStyle):
3536         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3537
3538 2010-09-14  Adam Barth  <abarth@webkit.org>
3539
3540         Fix two typos in commit-queue.  The first is harmless.  The second
3541         causes the queue to reject patches when the build is broken.  :(
3542
3543         * Scripts/webkitpy/tool/commands/queues.py:
3544         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3545
3546 2010-09-14  Chris Guillory   <chris.guillory@google.com>
3547
3548         Reviewed by Chris Fleizach.
3549
3550         Send all accessibility notifications to Chromium.
3551         https://bugs.webkit.org/show_bug.cgi?id=45156
3552
3553         * DumpRenderTree/chromium/WebViewHost.cpp:
3554         (WebViewHost::postAccessibilityNotification):
3555         * DumpRenderTree/chromium/WebViewHost.h:
3556
3557 2010-09-14  Adam Barth  <abarth@webkit.org>
3558
3559         Reviewed by Eric Seidel.
3560
3561         commit-queue is slow during the day
3562         https://bugs.webkit.org/show_bug.cgi?id=45780
3563
3564         Thanks to the new logging, we've noticed that checkout-is-out-of-date
3565         errors in the first pass of landing don't retry the land.  Instead,
3566         they're treated as failures and cause the commit-queue to do two more
3567         builds before really trying to land the patch.  Worse, in the second
3568         build, we can get bitten by a flaky test.
3569
3570         This patch takes a slightly different approach to the commit-queue's
3571         main control logic.  We now use a separate subprocess for building and
3572         testing and for landing.  This means we should very rarely see the
3573         checkout-is-out-of-date error, and when we do see it, we should retry
3574         more quickly.  If my understanding is correct, this should be a big
3575         speed win for the commit-queue.
3576
3577         * Scripts/webkitpy/tool/commands/download.py:
3578         * Scripts/webkitpy/tool/commands/queues.py:
3579         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3580
3581 2010-09-14  Tony Chang  <tony@chromium.org>
3582
3583         Reviewed by Dimitri Glazkov.
3584
3585         [chromium] implement layoutTestController.setDomainRelaxationForbiddenForURLScheme
3586         https://bugs.webkit.org/show_bug.cgi?id=45762