Fix http://bugs.webkit.org/show_bug.cgi?id=17175 (Bug 17175: Use of C++ compiler...
[WebKit-https.git] / WebKitTools / ChangeLog
1 2008-02-04  Rodney Dawes  <dobey@wayofthemonkey.com>
2
3         Reviewed by Alp Toker and Mark Rowe.
4
5         Fix http://bugs.webkit.org/show_bug.cgi?id=17175.
6         Bug 17175: Use of C++ compiler flags in CFLAGS
7
8         * GNUmakefile.am: Use global_cxxflags as well as global_cflags in CXXFLAGS.
9
10 2008-02-04  Darin Adler  <darin@apple.com>
11
12         Reviewed by Geoff.
13
14         * Scripts/make-js-test-wrappers: Look at the whole LayoutTests tree, not just the fast
15         and svg subdirectories. Added some more exceptions for the benefit of the fast/dom
16         subdirectory.
17
18 2008-02-04  Adam Roben  <aroben@apple.com>
19
20         Windows Apple-only build fix
21
22         * DumpRenderTree/win/DumpRenderTree.vcproj: Added a new include
23         directory.
24
25 2008-02-04  Alp Toker  <alp@atoker.com>
26
27         Rubber-stamped by Mark Rowe.
28
29         Remove all trailing whitespace in the GTK+ port and related
30         components.
31
32         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
33         * DumpRenderTree/gtk/GCControllerGtk.cpp:
34         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
35         * GNUmakefile.am:
36
37 2008-02-01  Eric Seidel  <eric@webkit.org>
38
39         Reviewed by Oliver.
40
41         Also search LayoutTests/svg for js-based tests.
42
43         * Scripts/make-js-test-wrappers:
44
45 2008-01-31  Alp Toker  <alp@atoker.com>
46
47         Rubber-stamped by Adam Roben.
48
49         http://bugs.webkit.org/show_bug.cgi?id=17006
50         [GTK] Header path should be webkit/webkit.h
51
52         Move the GTK+ API sources as needed and update the build systems.
53
54         * DumpRenderTree/gtk/DumpRenderTree.cpp:
55         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
56         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
57         * GNUmakefile.am:
58         * GtkLauncher/main.c:
59
60 2008-01-30  Stephanie  <slewis@apple.com>
61
62         Reviewed by Geoff.
63
64         Add an option to run-webkit-tests to merge leaks results and print the number of unique leaks found under a certain call depth.  This should make it easier for the buildbots to track new leaks.
65
66         * Scripts/run-webkit-tests:
67
68 2008-01-30  Alexey Proskuryakov  <ap@webkit.org>
69
70         Reviewed by Adam Roben.
71
72         One more debug (external) fix.
73
74         * DumpRenderTree/win/DumpRenderTree.cpp: TestNetscapePlugin is built with a _debug suffix in both DebugInternal
75         and Debug configurations. 
76
77 2008-01-29  Geoffrey Garen  <ggaren@apple.com>
78
79         Reviewed by Sam Weinig. Sam Weinig.
80         
81         Fixed <rdar://problem/5692566> fast/encoding/mailto-always-utf-8.html
82         fails when run after fast/dom/Window/window-property-shadowing.html (16902)
83
84         Modified our policy delegates not to output window.name. Since a
85         previous test may have explicitly set window.name, we can't rely on its
86         implicit value in test results.
87
88         * DumpRenderTree/mac/PolicyDelegate.mm:
89         (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
90
91         * DumpRenderTree/win/PolicyDelegate.cpp:
92         (PolicyDelegate::decidePolicyForNavigationAction):
93
94 2008-01-29  Mark Rowe  <mrowe@apple.com>
95
96         Reviewed by Tim Hatcher.
97
98         <rdar://problem/5600926> WebCore on Tiger must link to its own copy of SQLite 3.4 or newer (so HTML database behavior will be correct).
99
100         * Scripts/build-webkit: Copy SQLite static library and headers into the build directory.
101
102 2008-01-29  David Kilzer  <ddkilzer@apple.com>
103
104         Refactor ChangeLog path code
105
106         Reviewed by Adam.
107
108         * Scripts/prepare-ChangeLog: Simplify code in one foreach() loop, and extract
109         duplicate code in another foreach() loop.
110
111 2008-01-29  Alexey Proskuryakov  <ap@webkit.org>
112
113         Reviewed by Darin.
114
115         <rdar://problem/5710692> All storage tests fail/crash
116
117         * DumpRenderTree/mac/UIDelegate.mm:
118         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): Set an
119         arbitrary quota of 5 megabytes.
120
121         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
122         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
123         Removed unused (I think) code.
124         
125         * DumpRenderTree/win/UIDelegate.cpp:
126         (UIDelegate::QueryInterface): IWebUIDelegatePrivate3 is now supported.
127         (UIDelegate::webViewPainted): A stub implementation.
128         (UIDelegate::exceededDatabaseQuota): Set an arbitrary quota of 5 megabytes.
129         * DumpRenderTree/win/UIDelegate.h:
130
131 2008-01-27  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
132
133         GTK+ DRT build fix for breakage introduced in r29822.
134
135         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
136         (LayoutTestController::setPersistentUserStyleSheetLocation):
137         (LayoutTestController::clearPersistentUserStyleSheet):
138
139 2008-01-27  Dan Bernstein  <mitz@apple.com>
140
141         Reviewed by Darin Adler.
142
143         - add support for directory prologues and epilogues to run-webkit-tests
144         - allow setting a persistent user style sheet in DumpRenderTree
145         - activate the WebKit Layout Tests font in Windows DumpRenderTree
146
147         * DumpRenderTree/LayoutTestController.cpp:
148         (clearPersistentUserStyleSheetCallback): Added.
149         (setPersistentUserStyleSheetLocationCallback): Added.
150         (LayoutTestController::staticFunctions): Added.
151         clearPersistentUserStyleSheet and setPersistentUserStyleSheet.
152         * DumpRenderTree/LayoutTestController.h:
153         * DumpRenderTree/mac/DumpRenderTree.mm:
154         (setPersistentUserStyleSheetLocation): Added.
155         (resetWebViewToConsistentStateBeforeTesting): Added the user style sheet
156         to the set of things this function resets. Now it either disables the
157         user style sheet or sets it to the persistent user style sheet and
158         enables it.
159         * DumpRenderTree/mac/DumpRenderTreeMac.h:
160         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
161         (LayoutTestController::setPersistentUserStyleSheetLocation): Added.
162         (LayoutTestController::clearPersistentUserStyleSheet): Added.
163         * DumpRenderTree/win/DumpRenderTree.cpp:
164         (setPersistentUserStyleSheetLocation): Added.
165         (initialize): Added the WebKit Layout Tests font to the set of fonts to
166         install.
167         (resetWebViewToConsistentStateBeforeTesting): See DumpRenderTree.mm.
168         * DumpRenderTree/win/DumpRenderTreeWin.h:
169         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
170         (LayoutTestController::setPersistentUserStyleSheetLocation): Added.
171         (LayoutTestController::clearPersistentUserStyleSheet): Added.
172         * Scripts/run-webkit-tests: Changed to look for, and if found process in
173         DumpRenderTree, files named run-webkit-tests-prologue.html and
174         run-webkit-tests-epilogue.html in the resources subdirectory of any
175         test directory and platform test results directory. The prologues are
176         processed before the first test from the directory (and its
177         subdirectories) is run, and the epilogues are processed after the last
178         test from the directory is run. Platform-specific prologues and
179         epilogues are processed in order of specificity.
180
181 2008-01-25  Alexey Proskuryakov  <ap@webkit.org>
182
183         Reviewed by Mark Rowe.
184
185         <rdar://problem/5699933> http/tests/security/cross-frame-access-get.html is still failing
186
187         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Clear HTTP cache to ensure consistent test environment
188         (matching Mac DRT).
189         * DumpRenderTree/win/DumpRenderTree.vcproj: Link to CFNetwork.
190
191 2008-01-24  Sam Weinig  <sam@webkit.org>
192
193         Reviewed by Ada Chan.
194
195         Fix for <rdar://5131975> DumpRenderTree doesn't support undo/redo
196
197         - Adds simplified UndoManager to windows DRT to allow testing the
198           undo/redo code paths in WebCore and WebKit.  This is a temporary
199           solution to an issue that should eventually be solved by having a
200           shared UndoManager in WebKit.
201
202         * DumpRenderTree/win/DumpRenderTree.cpp:
203         (runTest):
204         * DumpRenderTree/win/UIDelegate.cpp:
205         (DRTUndoObject::DRTUndoObject):
206         (DRTUndoObject::invoke):
207         (DRTUndoStack::~DRTUndoStack):
208         (DRTUndoStack::isEmpty):
209         (DRTUndoStack::clear):
210         (DRTUndoStack::push):
211         (DRTUndoStack::pop):
212         (DRTUndoManager::canRedo):
213         (DRTUndoManager::canUndo):
214         (DRTUndoManager::DRTUndoManager):
215         (DRTUndoManager::removeAllActions):
216         (DRTUndoManager::registerUndoWithTarget):
217         (DRTUndoManager::redo):
218         (DRTUndoManager::undo):
219         (UIDelegate::UIDelegate):
220         (UIDelegate::resetUndoManager):
221         (UIDelegate::registerUndoWithTarget):
222         (UIDelegate::removeAllActionsWithTarget):
223         (UIDelegate::setActionTitle):
224         (UIDelegate::undo):
225         (UIDelegate::redo):
226         (UIDelegate::canUndo):
227         (UIDelegate::canRedo):
228         * DumpRenderTree/win/UIDelegate.h:
229
230 2008-01-23  Adam Roben  <aroben@apple.com>
231
232         Allow directories containing ChangeLogs to be passed to
233         resolve-ChangeLogs
234
235         Reviewed by David Kilzer.
236
237         * Scripts/resolve-ChangeLogs:
238         (sub findChangeLog): Return a ChangeLog contained within the specified
239         directory if one exists.
240
241 2008-01-23  Steve Falkenburg  <sfalken@apple.com>
242
243         <rdar://problem/5698732> Copyright strings should include 2008
244
245         Reviewed by Sam.
246
247         * Drosera/win/Drosera.vcproj/Drosera.rc:
248         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc:
249
250 2008-01-23  Alp Toker  <alp@atoker.com>
251
252         Rubber-stamped by Mark Rowe.
253
254         Remove whitespace after -I in automake include lists.
255
256         * GNUmakefile.am:
257
258 2008-01-23  Michael Goddard <michael.goddard@trolltech.com>
259
260         Reviewed by Lars Knoll <lars@trolltech.com>.
261
262         Reworked the JavaScriptCore Qt bindings:
263         
264         * Update JS DRT controller for Qt JS binding changes.
265         There were two functions that needed some changes
266         so that the layout tests would work, so this makes
267         a few tests pass again.
268         
269         * Bump the timeout for layout tests up to 11s.
270         At least some tests have an internal timeout of
271         10 seconds, so make the waitUntilDone approach
272         wait at least 11s.  fast/dom/open-and-close-by-DOM.html
273         is one of these - now the failure message is more
274         accurate.
275         
276
277         * DumpRenderTree/qt/jsobjects.cpp:
278         (LayoutTestController::waitUntilDone):
279         * DumpRenderTree/qt/jsobjects.h:
280
281 2008-01-22  Anders Carlsson  <andersca@apple.com>
282
283         Reviewed by Darin and Adam.
284
285         <rdar://problem/5688975>
286         div element on microsoft site has wrong left offset.
287         
288         Add new method for testing the return vale of NPN_GetProperty.
289         
290         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
291         (pluginInvoke):
292
293 2008-01-22  Alexey Proskuryakov  <ap@webkit.org>
294
295         Reviewed by Adam Roben.
296
297         <rdar://problem/5670257> editing/selection/4895428-3.html makes editing/selection/5131716-2.html fail
298
299         * DumpRenderTree/win/EventSender.cpp: (makeEventSender): Reset static variables for a new test.
300
301 2008-01-21  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
302
303         Reviewed by Alp Toker.
304
305         http://bugs.webkit.org/show_bug.cgi?id=16955
306         Get errors when cross-compile webkit-gtk
307
308         * GNUmakefile.am: Removed ICU_CFLAGS 
309
310 2008-01-21  Darin Adler  <darin@apple.com>
311
312         Reviewed by Mitz and Adam.
313
314         * Scripts/svn-create-patch: Sort ChangeLog files first. Also slightly improved the
315         sorting speed by doing all sort criteria in a single pass instead of three sorts.
316
317 2008-01-21  Simon Hausmann  <hausmann@webkit.org>
318
319         Reviewed by Holger.
320
321         Fix focus chain handling and cycling through focusable objects (links) using tab/backtab.
322         
323         * Fix GraphicsContext::drawFocusRing to also draw single focus rects.
324         * Implemented QWebPage::focusNextPrevChild by sending fake tab/shift-tab events
325         and make the return value depend on whether we successfully determined a focusable
326         node or not.
327         * Changed QWebView::focusNextPrevChild() to call the base QWidget implementation correctly
328         if we could not handle the focus chain ourselves.
329         * Changed the focus policy of QWebView to correctly use WheelFocus instead of ClickFocus.
330         * Made ChromeClientQt::canTakeFocus() and takeFocus() dummy method since they are only
331         used to control the situation of stepping out of the focus chain inside the page.
332         * Made inclusion of links in the focus chain configurable through QWebSettings::LinksIncludedInFocusChain.
333         The layout tests expect this to be disabled but for the user it seems sensible to have it
334         on by default, hence the default in qwebsettings.cpp
335         
336
337         * DumpRenderTree/qt/DumpRenderTree.cpp:
338         (WebCore::WebPage::WebPage):
339
340 2008-01-19  Mark Rowe  <mrowe@apple.com>
341
342         Reviewed by Alp Toker.
343
344         Allow the --http flag to run-webkit-tests to override
345         the default behaviour of disabling HTTP tests for Qt,
346         Gtk and Wx.
347
348         * Scripts/run-webkit-tests:
349
350 2008-01-19  David Kilzer  <ddkilzer@apple.com>
351
352         <rdar://problem/5695344> check-for-global-initializers script never checks any object files
353
354         Reviewed by Darin.
355
356         We now touch a check-for-global-initializers.timestamp file in
357         the TARGET_TEMP_DIR directory to determine when new object files
358         have been compiled and thus need to be checked.  If the timestamp
359         file doesn't exist, all object files will be checked.
360
361         Previously the modification time of the "executable" (the
362         framework binary, e.g., WebKit.framework/WebKit) was used, but
363         since this was the last file modified at the end of the compile
364         phase, no object files would ever get checked!
365
366         Also added JSCustomSQLTransactionCallback.o to the list of files
367         since it has static initializers in Debug builds of WebCore.
368
369         * Scripts/check-for-global-initializers:
370
371 2008-01-18  Adam Roben  <aroben@apple.com>
372
373         Build fix
374
375         * Scripts/build-webkit:
376
377 2008-01-18  Beth Dakin  <bdakin@apple.com>
378
379         Reviewed by Oliver.
380
381         Update build-webkit to account for foreign-object being disabled by 
382         default.
383
384         * Scripts/build-webkit:
385
386 2008-01-18  Adam Roben  <aroben@apple.com>
387
388         Updated for method renames
389
390         Reviewed by Adele.
391
392         * DumpRenderTree/mac/FrameLoadDelegate.mm:
393         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
394         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
395         (LayoutTestController::setMainFrameIsFirstResponder):
396         (LayoutTestController::setWindowIsKey):
397         * DumpRenderTree/mac/UIDelegate.mm:
398         (-[UIDelegate webViewFocus:]):
399         * DumpRenderTree/win/FrameLoadDelegate.cpp:
400         (FrameLoadDelegate::didCommitLoadForFrame):
401
402 2008-01-18  Alexey Proskuryakov  <ap@webkit.org>
403
404         Reviewed by Adam Roben.
405
406         Fix plugin-related tests in Debug_Internal configuration, which are failing because of CRT version mismatch
407         between DRT and TestNetscapePlugin.
408
409         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Added a Debug_Internal configuration.
410         * DumpRenderTree/DumpRenderTree.sln: Use this configuration.
411
412 2008-01-18  Simon Hausmann  <hausmann@webkit.org>
413
414         Reviewed by Holger.
415
416         Fix fast/dom/Window/window-resize.html
417         
418         In DRT connect the page's geometryChangeRequest signal to a slot that
419         sets the geometry of the view widget.
420         
421
422         * DumpRenderTree/qt/DumpRenderTree.cpp:
423         (WebCore::WebPage::setViewGeometry):
424         (WebCore::WebPage::WebPage):
425
426 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
427
428         Build fix.
429
430         * Drosera/DroseraWin.make:
431
432 2008-01-17  Darin Adler  <darin@apple.com>
433
434         * Scripts/run-webkit-tests: Fixed a bug number.
435
436 2008-01-17  Alexey Proskuryakov  <ap@webkit.org>
437
438         Reviewed by Adam Roben.
439
440         http://bugs.webkit.org/show_bug.cgi?id=16908
441         run-webkit-tests complains about missing FindSafari.exe
442
443         * Scripts/webkitdirs.pm: Append _debug as appropriate.
444
445 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
446
447         Re-add DEBUG_WEBKIT_HAS_SUFFIX.
448         
449         Rubber-stamped by Jon Honeycutt.
450
451         * DumpRenderTree/win/DumpRenderTree.vcproj:
452
453 2008-01-16  Alp Toker  <alp@atoker.com>
454
455         Reviewed by Mark Rowe.
456
457         http://bugs.webkit.org/show_bug.cgi?id=16218
458         [GTK] API: Should this entry point be called go_back rather than go_backward?
459
460         Track back/forward API changes in the tools.
461
462         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
463         (BackForwardItem::invoke):
464         * GtkLauncher/main.c:
465         (go_back_cb):
466
467 2008-01-16  Adam Roben  <aroben@apple.com>
468
469         Windows build fix after r29488
470
471         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
472         Build into a subdirectory of $WebKitOutputDir\bin to match where DRT
473         expects to find the plugin.
474
475 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
476
477         Reviewed by Sam Weinig.
478         
479         Fixed the waitUntilDone watchdog timer -- the old code never added the
480         timer to the run loop, so it didn't do anything.
481
482         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
483         (LayoutTestController::setWaitToDump):
484         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
485         (LayoutTestController::setWaitToDump):
486
487 2008-01-14  Steve Falkenburg  <sfalken@apple.com>
488
489         Use shared vsprops for most vcproj properties.
490         
491         Reviewed by Darin.
492
493         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
494         * DumpRenderTree/win/DumpRenderTree.vcproj:
495         * DumpRenderTree/win/ImageDiff.vcproj:
496         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
497         * FindSafari/FindSafari.vcproj:
498
499 2008-01-14  Stephanie  <slewis@apple.com>
500
501        Reviewed by NOBODY.
502   
503        revert accidental character.
504
505        * Scripts/run-webkit-tests:
506
507 2008-01-14  Stephanie  <slewis@apple.com>
508
509         RS=Oliver
510
511         add Quicktime PPC only leaks to Leopard exclude list. See <rdar://problem/5667132>
512
513         * Scripts/run-webkit-tests:
514
515 2008-01-14  Darin Adler  <darin@apple.com>
516
517         * Scripts/do-webcore-rename: Queue up another rename.
518
519 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
520
521         Reviewed by Darin.
522
523         * Allow to run the tests in reverse order to spot test cases where the result depends on the order
524         the tests were ran.
525         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
526
527         * Scripts/run-webkit-tests:
528
529 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
530
531         Reviewed by Darin.
532
533         * Randomize tests array to spot test cases where the results depends on the order
534         the tests are ran.
535         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
536
537         * Scripts/run-webkit-tests:
538
539 2008-01-14  Darin Adler  <darin@apple.com>
540
541         * Scripts/run-webkit-tests: More ignore list tweaking.
542
543 2008-01-14  Darin Adler  <darin@apple.com>
544
545         * Scripts/run-webkit-tests: Add another leak to the ignore list.
546
547 2008-01-14  Dan Bernstein  <mitz@apple.com>
548
549         Reviewed by Adam Roben.
550
551         - try to fix failure in fast/dom/Window/window-onFocus.html seen on the
552           build bots
553
554         * DumpRenderTree/win/DumpRenderTree.cpp:
555         (resetWebViewToConsistentStateBeforeTesting): Focus the web view.
556
557 2008-01-13  Steve Falkenburg  <sfalken@apple.com>
558
559         Share common files across projects.
560         
561         Unify vsprops files
562         Debug:          common.vsprops, debug.vsprops
563         Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
564         Release:        common.vsprops, release.vsprops
565         
566         Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
567         debug_internal.vsprops will be mostly empty except for file path prefix modifiers.
568
569         Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.
570
571         Reviewed by Adam Roben.
572
573         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
574         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Removed.
575         * Drosera/win/Drosera.vcproj/VERSION: Removed.
576         * Drosera/win/Drosera.vcproj/auto-version.sh: Removed.
577         * Drosera/win/Drosera.vcproj/debug.vsprops: Removed.
578         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Removed.
579         * Drosera/win/Drosera.vcproj/release.vsprops: Removed.
580         * DumpRenderTree/win/DumpRenderTree.vcproj:
581         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
582         * DumpRenderTree/win/debug.vsprops: Removed.
583         * DumpRenderTree/win/debug_internal.vsprops: Removed.
584         * DumpRenderTree/win/release.vsprops: Removed.
585
586 2008-01-13  Brent Fulgham  <bfulgham@gmail.com>
587
588         Reviewed by Maciej.
589
590         - http://bugs.webkit.org/show_bug.cgi?id=16314
591           Script to launch Drosera
592
593         * Scripts/gdb-drosera: Added.
594         * Scripts/run-drosera: Added.
595         * Scripts/run-drosera-nightly.cmd: Added.
596         * Scripts/webkitdirs.pm: Added runDrosera function.
597
598 2008-01-13  Dan Bernstein  <mitz@apple.com>
599
600         - fix breakage due to last-minute change
601
602         * DumpRenderTree/win/DumpRenderTree.cpp:
603         (runTest): Declare the loop variable.
604
605 2008-01-13  Dan Bernstein  <mitz@apple.com>
606
607         Reviewed by Adam Roben.
608
609         - fix <rdar://problem/5132009> Windows DRT does not support multiple windows
610
611         * DumpRenderTree/win/DumpRenderTree.cpp:
612         (DumpRenderTreeWndProc):
613         (initialize):
614         (dumpBackForwardList):
615         (dumpBackForwardListForAllWindows):
616         (dump):
617         (resetWebViewToConsistentStateBeforeTesting): Factored out of
618         runTest().
619         (runTest):
620         (allWindows): Added. Returns a vector of all open windows.
621         (windowToWebViewMap): Added. Returns a map from open windows to their
622         WebViews.
623         (createWebViewAndOffscreenWindow): Factored out of main() to be
624         reusable for creating extra windows.
625         (main):
626         * DumpRenderTree/win/DumpRenderTreeWin.h:
627         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
628         (LayoutTestController::windowCount): Implemented.
629         * DumpRenderTree/win/UIDelegate.cpp:
630         (UIDelegate::createWebViewWithRequest): Implemented.
631         (UIDelegate::webViewClose): Implemented.
632         * DumpRenderTree/win/UIDelegate.h:
633
634 2008-01-12  Alp Toker  <alp@atoker.com>
635
636         Reviewed by Mark Rowe.
637
638         Hide non-public symbols in GTK+/autotools release builds.
639
640         * GNUmakefile.am:
641
642 2008-01-12  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
643
644         Reviewed by Ap.
645
646         * Make launching of the WebKit httpd work on GNU/Debian/Linux
647         
648         The configuration of Apache2 and installation does not depend on
649         the kernel but on the distribution policy. Make launching of httpd
650         work for Debian derived distributions.
651
652         * Scripts/run-webkit-httpd:
653         * Scripts/run-webkit-tests:
654         * Scripts/webkitdirs.pm:
655
656 2008-01-12  Mark Rowe  <mrowe@apple.com>
657
658         Reviewed by Maciej Stachowiak.
659
660         Fix crash in http/tests/security/local-JavaScript-from-remote.html under guard malloc.
661
662         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Retain string before returning it to
663         match the callers expectations that it can take ownership of the string.
664
665 2008-01-11  Alexey Proskuryakov  <ap@webkit.org>
666
667         Reviewed by Adam Roben.
668
669         <rdar://problem/5667275> fast/dynamic/layer-hit-test-crash.html is failing
670
671         * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ignore WM_MOUSELEAVE events,
672         as these are only posted because the test window is not a normal visible one, and
673         they confuse drag&drop machinery.
674
675 2008-01-11  Adam Roben  <aroben@apple.com>
676
677         Fix a crash when pathToLocalResource fails and a leak
678
679         Reviewed by Darin.
680
681         * DumpRenderTree/LayoutTestController.cpp:
682         (pathToLocalResourceCallback): Dont leak the JSStringRef, and make
683         sure not to pass null to JSValueMakeString.
684         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
685         (LayoutTestController::pathToLocalResource): Print an error message if
686         the conversion fails so it's clear what happened.
687
688 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
689
690         Reviewed by John Sullivan.
691
692         * DumpRenderTree/mac/GCControllerMac.mm:
693         (GCController::collectOnAlternateThread): Updated for name change.
694
695 2008-01-10  Kevin Ollivier  <kevino@theolliviers.com>
696
697         wx build fix. Don't build dftables any longer since it's now a Perl
698         script.
699
700         * wx/build-wxwebkit:
701
702 2008-01-10  Sam Weinig  <sam@webkit.org>
703
704         Reviewed by Anders Carlsson.
705
706         Make DRT track open windows instead of allocated windows so that
707         we can avoid ASSERTION due to late deallocs out of our control.
708
709         * DumpRenderTree/mac/DumpRenderTree.mm:
710         (dumpBackForwardListForAllWindows):
711         (runTest):
712         * DumpRenderTree/mac/DumpRenderTreeMac.h:
713         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
714         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
715         (+[DumpRenderTreeWindow openWindows]):
716         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
717         (-[DumpRenderTreeWindow close]):
718         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
719         (LayoutTestController::windowCount):
720
721 2008-01-10  Ada Chan  <adachan@apple.com>
722
723         Meta key is not the same as Alt key on windows.
724
725         Reviewed by Darin.
726
727         * DumpRenderTree/win/EventSender.cpp:
728         (keyDownCallback):
729
730 2008-01-09  Kevin McCullough  <kmccullough@apple.com>
731
732         Reviewed by Darin, Sam and Adam.
733
734         -<rdar://problem/5654486> REGRESSION (Safari 3.0.4-TOT): clicking on
735         link in gmail message displays JavaScript alert falsely complaining
736         about pop-up blocking.
737         - Added the ability to enable the pop-up blocker via the
738         LayoutTestController.
739
740         * DumpRenderTree/LayoutTestController.cpp:
741         (setPopupBlockingEnabledCallback):
742         (LayoutTestController::staticFunctions):
743         * DumpRenderTree/LayoutTestController.h:
744         * DumpRenderTree/mac/DumpRenderTree.mm:
745         (setDefaultsToConsistentValuesForTesting):
746         (resetWebViewToConsistentStateBeforeTesting):
747         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
748         (LayoutTestController::setPopupBlockingEnabled):
749
750 2008-01-10  Lars Knoll  <lars@trolltech.com>
751
752         Reviewed by Simon.
753
754         rename QWebPageHistory to QWebHistory.
755         
756
757         * DumpRenderTree/qt/jsobjects.cpp:
758
759 2008-01-09  Maciej Stachowiak  <mjs@apple.com>
760
761         Reviewed by Darin.
762         
763         - add some more renames, adjust some
764
765         * Scripts/do-webcore-rename:
766
767 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
768
769         Reviewed by Oliver.
770
771         Enable SVG Fonts support by default.
772
773         * Scripts/build-webkit:
774
775 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
776
777         Reviewed by Adam.
778
779         Fixes: http://bugs.webkit.org/show_bug.cgi?id=16244
780         DRT doesn't handle platform specific pixel test results correctly.
781
782         <test>-expected.txt files and <test>-expected.png files may now live
783         in different directories (ie. a cross-platform <test>-expected.txt file
784         and a platform-specific <test>-expected.png file).
785
786         * Scripts/run-webkit-tests:
787
788 2008-01-04  Kevin McCullough  <kmccullough@apple.com>
789
790         Reviewed by Darin.
791
792         - <rdar://problem/5666914> fast/regex/test{1,4}.html are failing
793         DRT did not correctly handle printing the '\0' char.  Now it does.
794
795         * DumpRenderTree/win/DumpRenderTree.cpp:
796         (dumpFramesAsText):
797         (dump):
798
799 2008-01-07  Simon Hausmann  <hausmann@webkit.org>
800
801         Reviewed by Lars.
802
803         Ported of the network backend of the Qt platform to Qt 4.4's new networking API.
804         
805
806         * DumpRenderTree/qt/main.cpp:
807         * DumpRenderTree/qt/testplugin.cpp:
808         * DumpRenderTree/qt/testplugin.h:
809
810 2008-01-05  Mark Rowe  <mrowe@apple.com>
811
812         Reviewed by Alp Toker.
813
814         Fix hang in fast/frames/frame-display-none-focus.html during Gtk layout tests.
815
816         * DumpRenderTree/gtk/DumpRenderTree.cpp:
817         (processWork): Process pending work.
818         (webViewLoadFinished): Schedule processing of pending work.
819         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Use webkit_web_frame_reload.
820
821 2008-01-05  Darin Adler  <darin@apple.com>
822
823         * Scripts/do-webcore-rename: Some more renaming plans.
824
825 2008-01-04  Alice Liu  <alice.liu@apple.com>
826
827         Reviewed by Alexey and Darin.
828
829         Adding "home" and "end" to DRT's keydown since
830         DOM key events can't handle keyIdentifiers at this point. 
831
832         * DumpRenderTree/mac/EventSendingController.mm:
833         (-[EventSendingController keyDown:withModifiers:]):
834         * DumpRenderTree/win/EventSender.cpp:
835         (keyDownCallback):
836
837 2008-01-04  Lars Knoll  <lars@trolltech.com>
838
839         Reviewed by Simon.
840
841         fix DRT after the changes to QWebPage.
842         
843         The great thing is that we actually don't have
844         any regressions from the QWebPage change :)
845         
846
847         * DumpRenderTree/qt/DumpRenderTree.cpp:
848         (WebCore::DumpRenderTree::DumpRenderTree):
849
850 2008-01-04  Lars Knoll  <lars@trolltech.com>
851
852         Reviewed by Simon.
853
854         make QWebPage a QObject and get things to compile.
855         
856         Nothing works currently though.
857         
858
859         * DumpRenderTree/qt/DumpRenderTree.cpp:
860         (WebCore::DumpRenderTree::DumpRenderTree):
861
862 2008-01-04  Lars Knoll  <lars@trolltech.com>
863
864         Reviewed by Simon.
865
866         take a QString as identifier in QWebFrame::addToJSWindowObject.
867
868         * DumpRenderTree/qt/DumpRenderTree.cpp:
869         (WebCore::DumpRenderTree::initJSObjects):
870
871 2008-01-04  Alp Toker  <alp@atoker.com>
872
873         GTK+ DRT build fix for breakage introduced in r29149.
874
875         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
876         (LayoutTestController::execCommand):
877
878 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
879
880         Reviewed by Darin.
881
882         <rdar://problem/5463489> A number of layout tests should be using execCommand instead of textInputController
883
884         Added layoutTestController.execCommand to access editor commands that are not available
885         via document.execCommand.
886
887         * DumpRenderTree/LayoutTestController.cpp:
888         (execCommandCallback):
889         (LayoutTestController::staticFunctions):
890         * DumpRenderTree/LayoutTestController.h:
891         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
892         (LayoutTestController::execCommand):
893         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
894         (LayoutTestController::queueLoad):
895         (LayoutTestController::execCommand):
896
897 2008-01-03  Alice Liu  <alice.liu@apple.com>
898
899         Reviewed by Darin, Mitz.
900
901         fixed <rdar://5130762> mousedowns in different locations increase the clickcount incorrectly
902
903         the clickcount should not increase if the last click was at a different location.  it's a new click.
904
905         * DumpRenderTree/mac/DumpRenderTree.mm:
906         (runTest):
907         * DumpRenderTree/mac/EventSendingController.h:
908         * DumpRenderTree/mac/EventSendingController.mm:
909         (-[EventSendingController mouseDown]):
910         (-[EventSendingController mouseUp]):
911
912 2008-01-03  Darin Adler  <darin@apple.com>
913
914         Reviewed by Adam.
915
916         * Scripts/update-webkit: Make this work a little better for the people at Apple
917         who have a directory named Internal.
918
919 2008-01-03  Adam Roben  <aroben@apple.com>
920
921         Use HTTP::Date instead of Date::Parse because it's installed by Cygwin by default
922
923         Rubberstamped by Mark.
924
925         * Scripts/update-webkit-auxiliary-libs:
926
927 2008-01-03  Adam Roben  <aroben@apple.com>
928
929         Fix Bug 15663: update-webkit re-downloads WebKitAuxiliaryLibrary unnecessarily
930
931         http://bugs.webkit.org/show_bug.cgi?id=15663
932
933         Added a fuzz factor into the Last-Modified comparison for downloading
934         WebKitAuxiliaryLibrary.zip.
935
936         The zip file is served from a set of mirrors who give Last-Modified
937         times that are off by 1-3 seconds from each other. This was causing
938         the build bots to redownload WebKitAuxiliaryLibrary for every build,
939         which would then cause all of WebCore to rebuild each time.
940
941         Reviewed by Mark.
942
943         * Scripts/update-webkit-auxiliary-libs: Check if the new zip file is
944         at least 30 seconds newer than the old one -- otherwise we assume that
945         the difference in time is due to the mirrors being slightly offset
946         from each other.
947         (sub lastModifiedToUnixTime): Added.
948
949 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
950
951         Windows build fix.
952
953         * DumpRenderTree/ForwardingHeaders/wtf/HashTraits.h: Added (needed by COMPtr.h).
954
955 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
956
957         Reviewed by Lars.
958
959         Moved QWebPage::open to QWebFrame::load and added setHtml.
960         
961
962         * DumpRenderTree/qt/DumpRenderTree.cpp:
963         (WebCore::DumpRenderTree::open):
964
965 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
966
967         Reviewed by Lars.
968
969         Added the first revision of QWebView and started moving functionality from QWebPave over to QWebView and QWebFrame.
970         
971
972         * DumpRenderTree/qt/DumpRenderTree.cpp:
973         (WebCore::DumpRenderTree::DumpRenderTree):
974
975 2008-01-02  Sam Weinig  <sam@webkit.org>
976
977         * Scripts/do-webcore-rename: Yet more renaming ideas.
978
979 2008-01-02  Darin Adler  <darin@apple.com>
980
981         * Scripts/do-webcore-rename: More renaming ideas. (Maciej, please merge yours with mine.)
982
983 2008-01-02  Alice Liu  <alice.liu@apple.com>
984
985         Reviewed by Sam Weinig.
986
987         fixing assertion hit with editing/selection/move-begin-end.html
988
989         * DumpRenderTree/ForwardingHeaders/wtf/ASCIICType.h: Added.
990         * DumpRenderTree/win/DumpRenderTree.vcproj:
991         * DumpRenderTree/win/EventSender.cpp:
992         (keyDownCallback):
993         using isupper will cause an assertion for inputs outside of ascii range. use isASCIIUpper instead.
994
995 2008-01-02  Darin Adler  <darin@apple.com>
996
997         * Scripts/do-webcore-rename: Some more name change plans.
998
999 2008-01-02  Alice Liu  <alice.liu@apple.com>
1000
1001         Reviewed by Maciej.
1002
1003         Added handling for page up and page down in EventSender
1004
1005         * DumpRenderTree/mac/EventSendingController.mm:
1006         (-[EventSendingController keyDown:withModifiers:]):
1007         * DumpRenderTree/win/EventSender.cpp:
1008         (keyDownCallback):
1009
1010 2008-01-02  Alexey Proskuryakov  <ap@webkit.org>
1011
1012         Reviewed by Darin.
1013
1014         Fix fast/events/arrow-keys-on-body.html for real.
1015
1016         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Pass proper keyData for WM_KEYUP, too.
1017
1018 2008-01-02  Luca Bruno  <lethalman88@gmail.com>
1019
1020         Reviewed by Darin.
1021
1022         http://bugs.webkit.org/show_bug.cgi?id=16674
1023         [GTK] run-launcher sets wrong LD_LIBRARY_PATH
1024
1025         * Scripts/run-launcher:
1026
1027 2007-12-31  Darin Adler  <darin@apple.com>
1028
1029         Suggested by Antti.
1030
1031         * Scripts/webkitdirs.pm: Turned off the QuickTime requirement for Windows until
1032         we get it installed on the build bots.
1033
1034 2007-12-30  Eric Seidel  <eric@webkit.org>
1035
1036         Reviewed by Sam.
1037
1038         * Scripts/do-webcore-rename: Add a few more planned renames s/(\w+)Imp/\1/
1039
1040 2007-12-29  Darin Adler  <darin@apple.com>
1041
1042         Reviewed by Oliver.
1043
1044         - fix http://bugs.webkit.org/show_bug.cgi?id=16663
1045           leak bot shows createCStringFromNPVariant result leaking
1046
1047         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1048         (pluginInvoke): Added a missing free.
1049
1050 2007-12-26  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
1051
1052         Reviewed by Alp Toker.
1053
1054         http://bugs.webkit.org/show_bug.cgi?id=16390
1055         Use autotools or GNU make as the build system for the GTK port
1056
1057         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: include glib.h
1058         * GNUmakefile.am: Added.
1059
1060 2007-12-24  Alexey Proskuryakov  <ap@webkit.org>
1061
1062         Reviewed by Oliver.
1063
1064         Fix fast/events/arrow-keys-on-body.html, failing on Windows.
1065
1066         * DumpRenderTree/win/EventSender.cpp:
1067         (keyDownCallback): Add KF_EXTENDED flag to arrow keys. Also add a count
1068         of 1, even though WebKit currently ignores it.
1069
1070 2007-12-23  Kevin Ollivier  <kevino@theolliviers.com>
1071
1072         wx buildbot fix. Update libpng dl script to the latest version.
1073
1074         * wx/install-unix-extras:
1075
1076 2007-12-22  Antti Koivisto  <antti@apple.com>
1077
1078         Fix a typo.
1079
1080         * Scripts/webkitdirs.pm:
1081
1082 2007-12-21  Sam Weinig  <sam@webkit.org>
1083
1084         Reviewed by Mark Rowe.
1085
1086         - Disable the back/forward cache using the new WebPreferences API
1087           instead of through the BackForwardList.  This makes us match what
1088           we do on Windows.
1089
1090         * DumpRenderTree/mac/DumpRenderTree.mm:
1091         (createWebViewAndOffscreenWindow):
1092         (setDefaultsToConsistentValuesForTesting):
1093
1094 2007-12-21  Dan Bernstein  <mitz@apple.com>
1095
1096         Reviewed by Mark Rowe.
1097
1098         - disable the back/forward cache in Windows DumpRenderTree. It is
1099           already disabled in Mac DumpRenderTree.
1100
1101         * DumpRenderTree/win/DumpRenderTree.cpp:
1102         (initializePreferences):
1103
1104 2007-12-13  Antti Koivisto  <antti@apple.com>
1105
1106         Reviewed by Darin and Steve.
1107         
1108         - check for QuickTime SDK on Windows.
1109         - build media support on Windows by default
1110
1111         * Scripts/build-webkit:
1112         * Scripts/webkitdirs.pm:
1113
1114 2007-12-21  Kevin Ollivier  <kevino@theolliviers.com>
1115
1116         Build script fix for buildbot.
1117
1118         * wx/build-wxwebkit:
1119
1120 2007-12-20  Eric Seidel  <eric@webkit.org>
1121
1122         Reviewed by mjs.
1123
1124         * Scripts/run-sunspider: change --runs default to 10 for better accuracy
1125
1126 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
1127
1128         Reviewed by Steve.
1129
1130         - <rdar://5656485> Drosera: Win: Nightly does not reliably connect to
1131         WebKit.
1132
1133         - Drosera and Safari need to use the same ProgIDs in order for
1134         CoCreateInstance to work properly.  The most robust way to do this is
1135         for WebKit to dynamically publish those ProgIDs.
1136
1137         * Drosera/win/DebuggerClient.cpp: Use the published ProgIDs
1138         (DebuggerClient::createWebViewWithRequest):
1139         * Drosera/win/Drosera.cpp: Use the published ProgIDs and rename some
1140         statics.
1141         (Drosera::initUI):
1142         (Drosera::attach):
1143         (Drosera::attemptToCreateServerConnection):
1144         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Fix a runtime failure.
1145         * Drosera/win/ServerConnection.cpp: Reformat the connection function and
1146         make use of the published ProgIDs.
1147         (ServerConnection::attemptToCreateServerConnection):
1148
1149 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
1150
1151         - <rdar://problem/5658317> REGRESSION: 20+ leaks seen on buildbots.
1152         - Build bot and leak fix.
1153
1154         * DumpRenderTree/LayoutTestController.cpp:
1155         (pathToLocalResourceCallback):
1156
1157 2007-12-19  David Kilzer  <ddkilzer@apple.com>
1158
1159         Make svn-apply/svn-unapply work with patches from git-format-patch.
1160
1161         Reviewed by Darin.
1162
1163         * Scripts/svn-apply:
1164         (patch): If 'Index:' can't be found in the text passed in, print it
1165         out with a warning and return early.
1166         * Scripts/svn-unapply:
1167         (patch): Ditto.
1168
1169 2007-12-18  Kevin Ollivier  <kevino@theolliviers.com>
1170
1171         Reviewed by Alp Toker.
1172
1173         Build related fixes.
1174
1175         * wx/build-wxwebkit:
1176         - Check to make sure the user is running a supported wx port
1177         - More robust checks for Cygwin
1178         - Only run install-unix-extras on Mac, it's not the right solution
1179           for Linux distros.
1180         - Remove outdated Linux instructions after successful build
1181         - Clean Bakefile-generated files during a clean operation
1182
1183 2007-12-18  Darin Adler  <darin@apple.com>
1184
1185         * Scripts/make-js-test-wrappers: Don't generate a wrapper for select-options-remove.js.
1186
1187 2007-12-18  Steve Falkenburg  <sfalken@apple.com>
1188
1189         Add script to run Drosera as part of the nightly.
1190         
1191         Reviewed by Kevin M.
1192
1193         * Scripts/run-drosera.cmd: Added.
1194
1195 2007-12-18  Darin Adler  <darin@apple.com>
1196
1197         * Scripts/do-webcore-rename: Remove a stray K.
1198
1199 2007-12-18  Darin Adler  <darin@apple.com>
1200
1201         * Scripts/do-webcore-rename: Plan more renaming.
1202
1203 2007-12-14  Juan A. Suarez Romero  <jasuarez@igalia.com>
1204
1205         Reviewed by Alp Toker.
1206
1207         http://bugs.webkit.org/show_bug.cgi?id=16042
1208         [GTK] Eliminate webkit_init()
1209
1210         Moving webkit initialization to WebView class init.
1211
1212         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1213         (main):
1214         * GtkLauncher/main.c:
1215         (main):
1216
1217 2007-12-17  Luca Bruno  <lethalman88@gmail.com>
1218
1219         Reviewed by Alp Toker.
1220
1221         http://bugs.webkit.org/show_bug.cgi?id=13542
1222         gdklauncher doesnt change URL in adress GTKEntry.
1223
1224         * GtkLauncher/main.c:
1225         (load_commit_cb): added
1226         (title_change_cb):
1227         (create_browser):
1228
1229 2007-12-16  Dimitri Glazkov  <dimitri@glazkov.com>
1230
1231         Reviewed by Adam Roben.
1232
1233         Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.
1234
1235         * FindSafari/FindSafari.cpp:
1236         (_tmain):
1237
1238 2007-12-16  Brent Fulgham  <bfulgham@gmail.com>
1239
1240         Reviewed by Adam Roben.
1241
1242         http://bugs.webkit.org/show_bug.cgi?id=16315
1243         FindSafari needs a path-only option.
1244
1245         * FindSafari/FindSafari.cpp:
1246         (_tmain):
1247
1248 2007-12-16  Alexey Proskuryakov  <ap@webkit.org>
1249
1250         Reviewed by Darin.
1251
1252         http://bugs.webkit.org/show_bug.cgi?id=16462
1253         REGRESSION: access keys broken on Windows
1254
1255         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Send system key events
1256         if Alt is pressed.
1257
1258 2007-12-15  Sam Weinig  <sam@webkit.org>
1259
1260         Reviewed by Mark Rowe.
1261
1262         Fix urlSuitableForTestResult to correctly identify wstring::npos as
1263         the case when wstring.find doesn't find anything.
1264
1265         * DumpRenderTree/win/DumpRenderTree.cpp:
1266         (urlSuitableForTestResult):
1267
1268 2007-12-15  Alp Toker  <alp@atoker.com>
1269
1270         GTK+ DRT build fix for GLib < 2.14.
1271
1272         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1273         (LayoutTestController::setWaitToDump):
1274
1275 2007-12-05  Mark Rowe  <mrowe@apple.com>
1276
1277         Reviewed by Alp Toker.
1278
1279         Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.  This prevents
1280         many layout tests from hanging while waiting on user responses to dialogs.
1281
1282         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1283         (invalidateAnyPreviousWaitToDumpWatchdog):
1284         (webViewScriptAlert):
1285         (webViewScriptPrompt):
1286         (webViewScriptConfirm):
1287         (main):
1288         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
1289         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1290         (waitToDumpWatchdogFired):
1291         (LayoutTestController::setWaitToDump):
1292
1293 2007-12-05  Mark Rowe  <mrowe@apple.com>
1294
1295         Reviewed by Alp Toker.
1296
1297         Flesh out DumpRenderTree for Gtk.  After these changes, the majority of the tests in fast/js pass.
1298
1299         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1300         (dumpFramesAsText): Don't print the frame name when dumping the main frame as text.
1301         (dump):
1302         (runTest):
1303         (webViewLoadStarted): Store the top frame when it starts loading so we can use it to determine when to dump.
1304         (webViewLoadFinished): Dump when the top frame load completes if we're not waiting for a JS callback and the
1305         work queue is empty.
1306         (webViewWindowObjectCleared): Set up window.layoutTestController.
1307         (webViewConsoleMessage): Match the console message format expected by the layout test results.
1308         (main): Hook up the new signals.
1309         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
1310         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Only notify done if the top frame has completed loading to avoid
1311         dumping multiple times.
1312         * Scripts/build-dumprendertree: Ensure build-dumprendertree is a no-op for Gtk too.
1313         * Scripts/run-webkit-tests: Teach run-webkit-tests that Gtk is like Qt in many ways.  Use run-launcher to open test results.
1314
1315 2007-12-14  Anders Carlsson  <andersca@apple.com>
1316
1317         Reviewed by Brady.
1318
1319         Assert that a web frame that's loading a resource always has either a data source or 
1320         a provisional data source.
1321         
1322         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1323         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1324
1325 2007-12-14  Darin Adler  <darin@apple.com>
1326
1327         - fix mistake causing nearly all tests to fail on Windows
1328
1329         * DumpRenderTree/win/UIDelegate.cpp:
1330         (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with
1331         npos, not 0. Also pass URL in to URL function rather than passing the entire message.
1332
1333         * DumpRenderTree/mac/UIDelegate.mm:
1334         (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather
1335         than passing the entire message.
1336
1337 2007-12-14  Darin Adler  <darin@apple.com>
1338
1339         - fix Tiger build
1340
1341         * DumpRenderTree/mac/UIDelegate.mm:
1342         (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any
1343         new-to-Leopard methods.
1344
1345 2007-12-14  Darin Adler  <darin@apple.com>
1346
1347         * DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method
1348         since it now triggers unwanted icon loading. We only had it because we implemented "all"
1349         delegate methods here.
1350
1351 2007-12-14  Anders Carlsson  <andersca@apple.com>
1352
1353         Reviewed by Darin and Geoff.
1354
1355         <rdar://problem/5619295> 
1356         REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
1357         
1358         Add property getting methods to the plug-in.
1359         
1360         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1361         (pluginInvoke):
1362
1363 2007-12-14  Kevin McCullough  <kmccullough@apple.com>
1364
1365         Reviewed by Darin.
1366
1367         - Layout test fix for mac. When dumped to the console local file paths
1368         now only show the name of the resource not the whole path.  This is to
1369         make the results machine and OS independent.
1370
1371         * DumpRenderTree/mac/UIDelegate.mm:
1372         (-[UIDelegate webView:addMessageToConsole:]):
1373
1374 2007-12-13  Kevin McCullough  <kmccullough@apple.com>
1375
1376         Reviewed by Adam.
1377
1378         - Layout tests fix.  We need a way to remove machine-dependent
1379         information from paths in layout test results. The UIDelegate now does
1380         this.
1381
1382         * DumpRenderTree/DumpRenderTree.h:
1383         * DumpRenderTree/win/DumpRenderTree.cpp:
1384         (urlSuitableForTestResult):
1385         * DumpRenderTree/win/DumpRenderTreeWin.h:
1386         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1387         * DumpRenderTree/win/UIDelegate.cpp:
1388         (UIDelegate::webViewAddMessageToConsole):
1389
1390 2007-12-13  Alp Toker  <alp@atoker.com>
1391
1392         Build fix for DRT breakage introduced in r28690.
1393
1394         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1395         (LayoutTestController::pathToLocalResource):
1396
1397 2007-12-12  Kevin McCullough  <kmccullough@apple.com>
1398
1399         Reviewed by Alice and Sam.
1400
1401         - <rdar://5621435> Need a way to specify local resources (being loaded
1402         from HTTP tests) on Windows.
1403         - Implemented pathToLocalResource which exposes the functionality of
1404         converting a given unix path to the correct location on Windows.
1405
1406         * DumpRenderTree/LayoutTestController.cpp:
1407         (pathToLocalResourceCallback):
1408         (LayoutTestController::staticFunctions):
1409         * DumpRenderTree/LayoutTestController.h:
1410         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1411         (LayoutTestController::pathToLocalResource):
1412         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1413         (LayoutTestController::pathToLocalResource):
1414
1415 2007-12-12  Anders Carlsson  <andersca@apple.com>
1416
1417         Reviewed by Sam.
1418
1419         <rdar://problem/5132003>
1420         dumpResourceLoadCallbacks is not implemented in DRT on Windows.
1421
1422         * DumpRenderTree/win/DumpRenderTree.cpp:
1423         (main):
1424         Set the resource load delegate.
1425         
1426         * DumpRenderTree/win/DumpRenderTree.vcproj:
1427         
1428         * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
1429         * DumpRenderTree/win/ResourceLoadDelegate.h: Added.
1430
1431 2007-12-12  Alexey Proskuryakov  <ap@webkit.org>
1432
1433         Reviewed by Adam Roben.
1434
1435         Fix conversion from double to LPARAM in dispatchMessage().
1436
1437         * DumpRenderTree/win/EventSender.cpp:
1438         (dispatchMessageCallback):
1439
1440 2007-12-11  Dan Bernstein  <mitz@apple.com>
1441
1442         Reviewed by Mark Rowe and Sam Weinig too!
1443
1444         - added Helvetica Oblique and Helvetica Bold Oblique to the list of
1445           fonts DumpRenderTree registers.
1446
1447         * DumpRenderTree/win/DumpRenderTree.cpp:
1448         (initialize):
1449
1450 2007-12-11  Brady Eidson  <beidson@apple.com>
1451
1452         Reviewed by Anders
1453
1454         Make DumpRenderTree on mac use its own path for Databases testing
1455
1456         * DumpRenderTree/mac/DumpRenderTree.mm:
1457         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree 
1458           for future DRT-only use, then use it to construct the Databases path and set that default
1459
1460 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
1461
1462         Reviewed by Darin.
1463
1464         <rdar://problem/5535636>
1465         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
1466
1467         http://bugs.webkit.org/show_bug.cgi?id=13916
1468         JavaScript detects Tab as a character input on a textfield validation
1469
1470         * DumpRenderTree/mac/EventSendingController.mm:
1471         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
1472         Dispatch a keyup to better match what happens when a key is physically pressed.
1473
1474         * DumpRenderTree/win/EventSender.cpp:
1475         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
1476         returning from keyDown().
1477         (getConstantCallback): Fixed a couple copy/paste mistakes.
1478
1479 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
1480
1481         Reviewed by Oliver.
1482
1483         - <rdar://5599845> Drosera: Does not show loal files in the file list
1484         on the left side.
1485
1486         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
1487         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
1488         so the open source community can build.
1489
1490 2007-12-10  Brady Eidson  <beidson@apple.com>
1491
1492         Rubberstamped by Sam Weinig
1493
1494         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
1495
1496         * DumpRenderTree/mac/UIDelegate.mm:
1497         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
1498         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
1499
1500 2007-12-08  Oliver Hunt  <oliver@apple.com>
1501
1502         Reviewed by Sam W.
1503
1504         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
1505         
1506         Fixes <rdar://problem/5620249> Must disable SVG animation
1507         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
1508         
1509         In order to allow finer grained control over the set of SVG features
1510         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
1511         distinct flags:
1512         ENABLE_SVG_ANIMATION
1513         ENABLE_SVG_FILTERS
1514         ENABLE_SVG_FONTS
1515         ENABLE_SVG_AS_IMAGE
1516         ENABLE_SVG_USE
1517         
1518         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
1519         
1520         Script handles all the new build flags, and allows --svg-experimental
1521         to automatically enable all features.
1522
1523         * Scripts/build-webkit:
1524
1525 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
1526
1527         Fix version parsing.
1528
1529         Rubber-stamped by Oliver.
1530
1531         * Drosera/win/Drosera.vcproj/auto-version.sh:
1532
1533 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
1534
1535         Build modifications for Drosera.
1536
1537         Reviewed by Adam.
1538
1539         * Drosera/DroseraWin.make: Added.
1540         * Drosera/win/Drosera.vcproj/Drosera.rc:
1541         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1542         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
1543         * Drosera/win/Drosera.vcproj/VERSION: Added.
1544         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
1545
1546 2007-12-06  Adam Roben  <aroben@apple.com>
1547
1548         Explicitly turn on the Mac font ascent hack on Windows
1549
1550         This keeps our font metrics matching those from Mac.
1551
1552         Reviewed by Hyatt.
1553
1554         * DumpRenderTree/win/DumpRenderTree.cpp:
1555         (main):
1556
1557 2007-12-06  Anders Carlsson  <andersca@apple.com>
1558
1559         Rename main.c to main.cpp here too.
1560         
1561         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
1562
1563 2007-12-06  Sam Weinig  <sam@webkit.org>
1564
1565         Rubber stamped by Geoff.
1566
1567         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
1568
1569 2007-12-06  Darin Adler  <darin@apple.com>
1570
1571         * Scripts/do-webcore-rename: Some more renaming plans.
1572
1573 2007-12-06  Anders Carlsson  <andersca@apple.com>
1574
1575         Restore implementation of testGetIntIdentifier that was accidentally
1576         removed somehow (possibly when I made PluginObject be a cpp file).
1577         
1578         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1579         (pluginInvoke):
1580
1581 2007-12-05  Anders Carlsson  <andersca@apple.com>
1582
1583         Make the entry points extern "C".
1584         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1585         
1586 2007-12-05  Anders Carlsson  <andersca@apple.com>
1587
1588         C++ warning fixes.
1589         
1590         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1591         (NPP_New):
1592         (NPP_Destroy):
1593         (NPP_SetWindow):
1594         (NPP_NewStream):
1595         (NPP_HandleEvent):
1596         (NPP_URLNotify):
1597         (NPP_GetValue):
1598
1599 2007-12-05  Anders Carlsson  <andersca@apple.com>
1600
1601         Add the .cpp files to the TestNetscapePlugIn target.
1602
1603         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1604
1605 2007-12-05  Anders Carlsson  <andersca@apple.com>
1606
1607         Reviewed by Geoff.
1608         
1609         Rename the TestNetscapePlugIn .c files to be .cpp.
1610
1611         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1612         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
1613         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
1614         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
1615         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
1616         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
1617         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
1618         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1619
1620 2007-12-05  Adam Roben  <aroben@apple.com>
1621
1622         Fix case of keypresses from the Windows implementation of eventSender.keyDown
1623
1624         This fixes several regression tests.
1625
1626         Reviewed by Alice.
1627
1628         * DumpRenderTree/win/EventSender.cpp:
1629         (keyDownCallback): Virtual keycodes for ASCII characters are always
1630         uppercase, so we need to check the case of the original character
1631         passed in to eventSender.keyDown.
1632
1633 2007-12-05  Adam Roben  <aroben@apple.com>
1634
1635         Learn from Tim's mistakes
1636
1637         * DumpRenderTree/win/DumpRenderTree.cpp:
1638         (runTest): Reset the authorAndUserStylesEnabled preference for each
1639         test.
1640
1641 2007-12-05  Alp Toker  <alp@atoker.com>
1642
1643         Reviewed by Mark Rowe.
1644
1645         Initialize GTK+ and WebKit so the tests can run.
1646
1647         Reorganize the headers a little.
1648
1649         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1650         (main):
1651
1652 2007-12-04  Anders Carlsson  <andersca@apple.com>
1653
1654         Remove IWebScriptScope include.
1655         
1656         * Drosera/win/DebuggerDocumentPlatform.cpp:
1657
1658 2007-12-04  Sam Weinig  <sam@webkit.org>
1659
1660         Rubber stamped by Mark Rowe.
1661
1662         Define CF as platform for mac and revert r28409
1663
1664         * DumpRenderTree/DumpRenderTree.h:
1665         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1666
1667 2007-12-04  Sam Weinig  <sam@webkit.org>
1668
1669         Define CF as platform for windows.
1670
1671         Reviewed by Adam Roben.
1672
1673         * DumpRenderTree/win/DumpRenderTreeWin.h:
1674
1675 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
1676
1677         Reviewed by Adam and Darin.
1678
1679         - Removed a needless BSTR cleanup.
1680
1681         * Drosera/win/DebuggerDocumentPlatform.cpp:
1682         (DebuggerDocument::getPlatformCurrentFunctionStack):
1683
1684 2007-11-27  Adam Roben  <aroben@apple.com>
1685
1686         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
1687
1688         Reviewed by Maciej.
1689
1690         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1691         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
1692
1693 2007-12-04  Alp Toker  <alp@atoker.com>
1694
1695         Prospective Win DRT build fix.
1696
1697         * DumpRenderTree/DumpRenderTree.h:
1698
1699 2007-12-04  Alp Toker  <alp@atoker.com>
1700
1701         Fix a clobbered copyright header.
1702
1703         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1704
1705 2007-12-04  Xan Lopez  <xan@gnome.org>
1706
1707         Reviewed by Alp Toker.
1708
1709         http://bugs.webkit.org/show_bug.cgi?id=15561
1710         GTK port needs DumpRenderTree implementation
1711
1712         Start work on the GTK+ DRT.
1713
1714         This does not work yet, and there are a few lingering style issues
1715         (nothing major) but this patch has been stuck in the bug tracker for
1716         too long already.
1717
1718         * DumpRenderTree/DumpRenderTree.h:
1719         * DumpRenderTree/gtk: Added.
1720         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
1721         (autocorrectURL):
1722         (shouldLogFrameLoadDelegates):
1723         (dumpFrameScrollPosition):
1724         (displayWebView):
1725         (appendString):
1726         (dumpFramesAsText):
1727         (dumpRenderTreeAsText):
1728         (dump):
1729         (runTest):
1730         (main):
1731         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
1732         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
1733         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
1734         (GCController::collect):
1735         (GCController::collectOnAlternateThread):
1736         (GCController::getJSObjectCount):
1737         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
1738         (LayoutTestController::~LayoutTestController):
1739         (LayoutTestController::addDisallowedURL):
1740         (LayoutTestController::clearBackForwardList):
1741         (LayoutTestController::copyDecodedHostName):
1742         (LayoutTestController::copyEncodedHostName):
1743         (LayoutTestController::display):
1744         (LayoutTestController::keepWebHistory):
1745         (LayoutTestController::notifyDone):
1746         (LayoutTestController::queueBackNavigation):
1747         (LayoutTestController::queueForwardNavigation):
1748         (LayoutTestController::queueLoad):
1749         (LayoutTestController::queueReload):
1750         (LayoutTestController::queueScript):
1751         (LayoutTestController::setAcceptsEditing):
1752         (LayoutTestController::setCustomPolicyDelegate):
1753         (LayoutTestController::setMainFrameIsFirstResponder):
1754         (LayoutTestController::setTabKeyCyclesThroughElements):
1755         (LayoutTestController::setUseDashboardCompatibilityMode):
1756         (LayoutTestController::setUserStyleSheetEnabled):
1757         (LayoutTestController::setUserStyleSheetLocation):
1758         (LayoutTestController::setWindowIsKey):
1759         (LayoutTestController::setWaitToDump):
1760         (LayoutTestController::windowCount):
1761         (LayoutTestController::setPrivateBrowsingEnabled):
1762         (LayoutTestController::setAuthorAndUserStylesEnabled):
1763         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
1764         (JSStringCopyUTF8CString):
1765         (LoadItem::invoke):
1766         (ReloadItem::invoke):
1767         (ScriptItem::invoke):
1768         (BackForwardItem::invoke):
1769
1770 2007-12-03  Sam Weinig  <sam@webkit.org>
1771
1772         Move JavaScriptCore thread testing code to pthread specific directory
1773         and remove the dependance on CoreFoundation by using WTF::HashSet.
1774
1775         Reviewed by Geoff and Oliver.
1776
1777         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1778         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
1779         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
1780         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
1781         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
1782         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
1783         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
1784         * DumpRenderTree/pthreads: Added.
1785         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
1786         (javaScriptThreads):
1787         (runJavaScriptThread):
1788         (startJavaScriptThreads):
1789         (stopJavaScriptThreads):
1790
1791 2007-12-03  Andrew Bonventre  <andybons@google.com>
1792
1793         Reviewed by Darin Adler.
1794
1795         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
1796         Symbol lookup menu broken in debugger view
1797
1798         * Drosera/debugger.js: Fixed javascript error where document property
1799         should have been used instead of contentDocument in switchFunction that
1800         was breaking the select symbol dropdown menu.  This is because
1801         window.frames will return a Window object and not a frame object like
1802         the author was originally expecting.
1803
1804 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
1805
1806         Reviewed by Adam.
1807
1808         - <rdar://5618942> Drosera: Console window does not process everything
1809         correctly.
1810         - <rdar://5619005> Drosera: could be sped up by moving the 
1811         WebScriptScope stuff into the WebScriptCallFrame.
1812         - Now the console can correctly process objects and does not receive
1813         notifications from JavaScriptCore about the JavaScript in Drosera's
1814         own process.
1815
1816         * Drosera/win/DebuggerDocumentPlatform.cpp:
1817         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1818         (DebuggerDocument::platformValueForScopeVariableNamed):
1819
1820 2007-12-03  Stephanie  <slewis@apple.com>
1821
1822         Reviewed by Darin.
1823
1824         Check to see if we are building a debug root
1825
1826         * Scripts/check-for-global-initializers: 
1827
1828 2007-12-03  Dan Bernstein  <mitz@apple.com>
1829
1830         Reviewed by Darin Adler.
1831
1832         - added a testGetIntIdentifier() method to TestNetscapePlugIn
1833
1834         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
1835         (pluginInvoke):
1836
1837 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
1838
1839         Reviewed by Oliver.
1840
1841         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
1842         in a more fine-grained manner than eventSender.keyDown().
1843
1844         * DumpRenderTree/win/EventSender.cpp:
1845         (getConstantCallback):
1846         (dispatchMessageCallback):
1847
1848 2007-12-02  Darin Adler  <darin@apple.com>
1849
1850         * Scripts/do-webcore-rename: More planned renaming.
1851
1852 2007-12-02  Sam Weinig  <sam@webkit.org>
1853
1854         Rubber stamped by Anders.
1855
1856         Use [NSURL absoluteString] instead of [NSURL description] in order to get
1857         more uniform results cross platform.
1858
1859         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1860         (-[NSURL _drt_descriptionSuitableForTestResult]):
1861
1862 2007-12-02  Sam Weinig  <sam@webkit.org>
1863
1864         Rubber stamped by Niko.
1865
1866         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
1867
1868         * DumpRenderTree/win/DumpRenderTree.cpp:
1869         * DumpRenderTree/win/DumpRenderTree.vcproj:
1870         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
1871         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
1872         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
1873         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
1874
1875 2007-12-01  Alp Toker  <alp@atoker.com>
1876
1877         Reviewed by Adam Roben.
1878
1879         Make use of the newly introduced webkit.h convenience header.
1880
1881         * GtkLauncher/main.c:
1882
1883 2007-12-01  Adam Treat  <treat@kde.org>
1884
1885         Reviewed by Simon.
1886
1887         * Check to see if the directory exists and exit if not.
1888
1889         * DumpRenderTree/qt/main.cpp:
1890         (main):
1891
1892 2007-12-01  Adam Treat  <treat@kde.org>
1893
1894         Reviewed by Simon.
1895
1896         * Don't hide symbols when in Debug mode
1897         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
1898
1899
1900         * DumpRenderTree/qt/main.cpp:
1901         (messageHandler):
1902
1903 2007-11-30  Alp Toker  <alp@atoker.com>
1904
1905         Reviewed by Adam Roben.
1906
1907         http://bugs.webkit.org/show_bug.cgi?id=15691
1908         [GTK] Public API does not follow GTK+ conventions
1909
1910         Refactor the WebKit/GTK+ public API. Changes:
1911           WebKitPage -> WebKitWebView
1912           WebKitFrame -> WebKitWebFrame
1913
1914         Public API source and header names have been updated to mirror the API
1915         changes.
1916
1917         The API is now kept in WebKit/gtk/WebView to match other ports in the
1918         same class such as Mac and Win.
1919
1920         * GtkLauncher/main.c:
1921         (activate_uri_entry_cb):
1922         (link_hover_cb):
1923         (title_change_cb):
1924         (progress_change_cb):
1925         (go_back_cb):
1926         (go_forward_cb):
1927         (create_browser):
1928         (main):
1929
1930 2007-11-30  Adam Roben  <aroben@apple.com>
1931
1932         Hopefully the final build fix
1933
1934         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
1935         pull in WTF's assertion/logging functions.
1936
1937 2007-11-30  Adam Roben  <aroben@apple.com>
1938
1939         Another build fix
1940
1941         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
1942         WebKit.lib.
1943
1944 2007-11-30  Adam Roben  <aroben@apple.com>
1945
1946         Debug build fix
1947
1948         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
1949         configuration.
1950         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
1951         projects.
1952         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
1953         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
1954         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
1955
1956 2007-11-30  Sam Weinig  <sam@webkit.org>
1957
1958         Reviewed by Adam Roben.
1959
1960         Fix drawSelectionRect to actually draw the selection rect.
1961
1962         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1963         (drawSelectionRect):
1964
1965 2007-11-30  Darin Adler  <darin@apple.com>
1966
1967         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
1968
1969 2007-11-30  Darin Adler  <darin@apple.com>
1970
1971         * Scripts/do-webcore-rename: Get ready for some future renaming.
1972
1973 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1974
1975         Reviewed by Adam.
1976
1977         - Removed some unnecessary functions and changed an unused return type. 
1978
1979         * Drosera/win/DebuggerClient.cpp:
1980         (registerConsoleClass):
1981         * Drosera/win/DebuggerClient.h:
1982         * Drosera/win/Drosera.cpp:
1983         (registerDroseraClass):
1984
1985 2007-11-28  Alp Toker  <alp@atoker.com>
1986
1987         Reviewed by Timothy Hatcher.
1988
1989         http://bugs.webkit.org/show_bug.cgi?id=16174
1990         [GTK] Use "URI" not "URL" in public API
1991
1992         Replace use of the term "URL" with "URI" in public headers,
1993         documentation and some internal code to match GLib/GTK+ convention.
1994
1995         This is now mentioned in the API guidelines:
1996           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
1997
1998         * GtkLauncher/main.c:
1999         (activate_uri_entry_cb):
2000         (title_change_cb):
2001         (create_toolbar):
2002         (main):
2003
2004 2007-11-29  Anders Carlsson  <andersca@apple.com>
2005
2006         Reviewed by Sam.
2007
2008         <rdar://problem/5230478>
2009         FrameLoadDelegate callbacks are not dumped in DRT.
2010         
2011         * DumpRenderTree/win/DumpRenderTree.cpp:
2012         (shouldLogFrameLoadDelegates):
2013         (runTest):
2014         (main):
2015         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
2016         (BSTRtoString):
2017         (descriptionSuitableForTestResult):
2018         (FrameLoadDelegate::QueryInterface):
2019         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
2020         (FrameLoadDelegate::didFailProvisionalLoadWithError):
2021         (FrameLoadDelegate::didCommitLoadForFrame):
2022         (FrameLoadDelegate::didFinishLoadForFrame):
2023         (FrameLoadDelegate::willCloseFrame):
2024         (FrameLoadDelegate::didClearWindowObject):
2025         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
2026         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
2027         * DumpRenderTree/win/FrameLoaderDelegate.h:
2028         (FrameLoadDelegate::windowScriptObjectAvailable):
2029         (FrameLoadDelegate::didFirstLayoutInFrame):
2030
2031 2007-11-29  Sam Weinig  <sam@webkit.org>
2032
2033         Reviewed by Anders.
2034
2035         Add database quota UIDelegates methods to DRT UIDelegate.
2036
2037         * DumpRenderTree/mac/UIDelegate.mm:
2038         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
2039         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
2040
2041 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
2042
2043         Reviewed by Sam.
2044
2045         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
2046         dying and vice versa.
2047         - This fix will allow Drosera and Safari to reconnect if either of them
2048         closes correctly, but does not fix the case where one of them dies
2049         silently.
2050
2051         * Drosera/win/ServerConnection.cpp:
2052         (ServerConnection::attemptToCreateServerConnection): Added a safety
2053         check, because it's possilbe to try to connect to a server that's dying.
2054         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
2055         the server has died.
2056         * Drosera/win/ServerConnection.h: Added the new function and removed
2057         an unnecessary member.
2058
2059 2007-11-29  Anders Carlsson  <andersca@apple.com>
2060
2061         * DumpRenderTree/win/DumpRenderTree.vcproj:
2062         Add shlwapi.lib to all configurations.
2063
2064 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
2065
2066         - Build fix.  Added additional includes for VS Express to the Release
2067         project.
2068
2069         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2070
2071 2007-11-29  Anders Carlsson  <andersca@apple.com>
2072
2073         Reviewed by Adam.
2074
2075         <rdar://problem/5132005>
2076         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
2077         
2078         * DumpRenderTree/win/DumpRenderTree.vcproj:
2079         Add shlwapi.lib
2080         
2081         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2082         (LayoutTestController::setUserStyleSheetEnabled):
2083         Implement this.
2084         
2085         (appendComponentToPath):
2086         New method which wraps the Win32 API PathAppend.
2087         
2088         (followShortcuts):
2089         New method which checks if a file points to a shortcut and
2090         follows the shortcut.
2091         
2092         (resolveCygwinPath):
2093         New method that takes a cygwin unix-style path and returns the Win32 path.
2094         
2095         (cfStringRefToWString):
2096         
2097         (LayoutTestController::setUserStyleSheetLocation):
2098         Implement this.
2099
2100 2007-11-29  Alice Liu  <alice.liu@apple.com>
2101
2102         Reviewed by Adam.
2103
2104         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
2105
2106         * DumpRenderTree/win/EventSender.cpp:
2107         (keyDownCallback):
2108         uppercase letters were being sent as lowercase letters without the shift key down.
2109
2110 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
2111
2112         - Windows build fix. VS express needs some love.
2113
2114         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2115
2116 2007-11-28  Darin Adler  <darin@apple.com>
2117
2118         Reviewed by Adam Roben.
2119
2120         * DumpRenderTree/mac/EventSendingController.mm:
2121         (-[EventSendingController keyDown:withModifiers:]):
2122         Send capital letters through as lowercase letters with the shift key down
2123         rather than sending them as if they were highly unusual "capital letter keys".
2124
2125         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
2126         where you need to update results and more tests are failing than before.
2127
2128 2007-11-28  Anders Carlsson  <andersca@apple.com>
2129
2130         Reviewed by Darin.
2131
2132         <rdar://problem/5132001>
2133         contextClick is not implemented in DRT on Windows.
2134         
2135         * DumpRenderTree/win/EventSender.cpp:
2136         (contextClickCallback):
2137         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
2138         by a WM_RBUTTONUP message.
2139         
2140         * DumpRenderTree/win/UIDelegate.cpp:
2141         (UIDelegate::hasCustomMenuImplementation):
2142         (UIDelegate::trackCustomPopupMenu):
2143         * DumpRenderTree/win/UIDelegate.h:
2144         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
2145         menu from being shown (and causing the DRT to hang).
2146
2147 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
2148
2149         Reviewed by Darin.
2150
2151         Fix DumpRenderTree ObjC bug comparing strings.
2152
2153         * DumpRenderTree/mac/ObjCController.m:
2154         (-[ObjCController identityIsEqual::]): Compare strings with string
2155         equality instead of identiy equality.
2156
2157 2007-11-27  Timothy Hatcher  <timothy@apple.com>
2158
2159         Reviewed by Sam.
2160
2161         Reset the authorAndUserStylesEnabled preference
2162         back to YES for each test. Fixes the broken tests.
2163
2164         * DumpRenderTree/mac/DumpRenderTree.mm:
2165         (resetWebViewToConsistentStateBeforeTesting):
2166
2167 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
2168
2169         Reviewed by Adam.
2170
2171         - Drosera now displays the console window, although it cannot currently
2172         process JavaScript.
2173
2174         * Drosera/win/DebuggerClient.cpp: Shows the console window.
2175         (registerConsoleClass): Implemented.
2176         (consoleWndProc): Implemented.
2177         (DebuggerClient::onSize): Implemented.
2178         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
2179         new window.
2180         * Drosera/win/DebuggerClient.h: Added needed method and members for 
2181         creating and maintaining a new window.
2182         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
2183         lines of code to more appropriate places.
2184         (Drosera::handleCommand):
2185         (Drosera::initUI):
2186         (Drosera::onSize):
2187         (Drosera::attach):
2188
2189 2007-11-27  Timothy Hatcher  <timothy@apple.com>
2190
2191         Reviewed by Dave Hyatt.
2192
2193         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
2194         
2195         Add support for disabling author and user styles for testing.
2196
2197         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2198         * DumpRenderTree/LayoutTestController.cpp:
2199         (setAuthorAndUserStylesEnabledCallback):
2200         (LayoutTestController::staticFunctions):
2201         * DumpRenderTree/LayoutTestController.h:
2202         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2203         (LayoutTestController::setAuthorAndUserStylesEnabled):
2204         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2205         (LayoutTestController::setAuthorAndUserStylesEnabled):
2206
2207 2007-11-26  Dan Bernstein  <mitz@apple.com>
2208
2209         - Tiger build fix.
2210
2211         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2212
2213 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
2214
2215         Reviewed by Maciej.
2216
2217         - Implemented displaying variables for Drosera on Win.
2218
2219         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
2220         that retrieve variables to not hold onto the return value since it's
2221         not returned.  Also changed to use the new signatures of the retrieval
2222         functions.
2223         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2224         (DebuggerDocument::platformValueForScopeVariableNamed):
2225         * Drosera/win/Drosera.cpp: Removed a needless TODO.
2226         (droseraWndProc):
2227
2228 2007-11-26  Sam Weinig  <sam@webkit.org>
2229
2230         Cleanup names of painting and repainting functions.
2231
2232         Reviewed by Adam Roben.
2233
2234         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2235         (drawSelectionRect): was drawSelectionRectIntoContext.
2236         (dumpWebViewAsPixelsAndCompareWithExpected):
2237         * DumpRenderTree/cg/PixelDumpSupportCG.h:
2238         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2239         (paintWebView): was drawWebViewIntoContext.
2240         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
2241
2242 2007-11-26  Sam Weinig  <sam@webkit.org>
2243
2244         Reviewed by Dan Bernstein.
2245
2246         - Leopard build fix
2247
2248         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2249
2250 2007-11-26  Sam Weinig  <sam@webkit.org>
2251
2252         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
2253         Use shared PixelDumpSupport for Mac DRT
2254
2255         Reviewed by Adam Roben.
2256
2257         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2258         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
2259         * DumpRenderTree/cg/ImageDiffCG.cpp:
2260         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2261         (drawSelectionRectIntoContext):
2262         (dumpWebViewAsPixelsAndCompareWithExpected):
2263         * DumpRenderTree/cg/PixelDumpSupportCG.h:
2264         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2265         * DumpRenderTree/mac/DumpRenderTree.mm:
2266         (dump):
2267         * DumpRenderTree/mac/ImageDiff.m: Removed.
2268         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
2269         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
2270         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
2271         (setDefaultColorProfileToRGB):
2272         (getBitmapContextFromWebView):
2273         (drawWebViewIntoContext):
2274         (repaintWithVerticalSweep):
2275         (repaintWithHorizontalSweep):
2276         (getSelectionRect):
2277         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
2278
2279 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
2280
2281         Bug 16052: prepare-ChangeLog doesn't report deleted files
2282         <http://bugs.webkit.org/show_bug.cgi?id=16052>
2283
2284         Reviewed by Sam.
2285
2286         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
2287
2288 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
2289
2290         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
2291         <http://bugs.webkit.org/show_bug.cgi?id=15864>
2292
2293         Reviewed by Adam.
2294
2295         Roll functionality of merge-changelog into resolve-ChangeLogs
2296         script.  The script now checks for ChangeLog.rej and
2297         ChangeLog.orig files first.  If it finds them, it uses the
2298         ChangeLog.rej file as a patch (in old contextual diff format) to
2299         apply with --fuzz=3.
2300
2301         * Scripts/merge-changelog: Removed.
2302         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
2303
2304 2007-11-25  Sam Weinig  <sam@webkit.org>
2305
2306         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
2307
2308         Reviewed by Mark Rowe.
2309
2310         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2311         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2312         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2313         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
2314         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
2315
2316 2007-11-25  Sam Weinig  <sam@webkit.org>
2317
2318         Convert DumpRenderTree to ues .xcconfig files.
2319
2320         Reviewed by Mark Rowe.
2321
2322         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2323         * DumpRenderTree/mac/Configurations: Added.
2324         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
2325         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
2326         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
2327
2328 2007-11-25  Sam Weinig  <sam@webkit.org>
2329
2330         Add ForwardingHeaders to wtf for DumpRenderTree.
2331
2332         Reviewed by Mark Rowe.
2333
2334         * DumpRenderTree/DumpRenderTree.h:
2335         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2336         * DumpRenderTree/ForwardingHeaders: Added.
2337         * DumpRenderTree/ForwardingHeaders/wtf: Added.
2338         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
2339         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
2340         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
2341         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
2342         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
2343         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
2344         * DumpRenderTree/LayoutTestController.cpp:
2345         * DumpRenderTree/WorkQueue.cpp:
2346         * DumpRenderTree/mac/DumpRenderTree.mm:
2347         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2348         * DumpRenderTree/mac/JavaScriptThreading.cpp:
2349         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2350         * DumpRenderTree/mac/ObjCController.m:
2351         * DumpRenderTree/mac/UIDelegate.mm:
2352         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2353
2354 2007-11-25  Adam Roben  <aroben@apple.com>
2355
2356         Fix some test failures caused by r28019
2357
2358         Now that stdout is in binary mode, we need to always use printf
2359         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
2360         the output.
2361
2362         Reviewed by Sam.
2363
2364         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
2365         printf.
2366         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2367         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2368         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2369         (UIDelegate::webViewAddMessageToConsole):
2370
2371 2007-11-25  Adam Roben  <aroben@apple.com>
2372
2373         Set the font smoothing preference in DRT
2374
2375         This makes the pixel results on Windows closer to the Mac results.
2376
2377         Reviewed by Mitz.
2378
2379         * DumpRenderTree/win/DumpRenderTree.cpp:
2380         (initializePreferences):
2381
2382 2007-11-25  Adam Roben  <aroben@apple.com>
2383
2384         Port ImageDiff to CG and C++
2385
2386         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
2387         <rdar://5071708>
2388
2389         Reviewed by Sam.
2390
2391         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
2392         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
2393         (main):
2394         (createImageFromStdin):
2395         (compareImages):
2396         (getDifferenceBitmap):
2397         (computePercentageDifferent):
2398         * DumpRenderTree/win/ImageDiff.vcproj: Added.
2399
2400 2007-11-25  Adam Roben  <aroben@apple.com>
2401
2402         Fix image diff link generation on Windows
2403
2404         Reviewed by Sam.
2405
2406         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
2407         to toURL.
2408
2409 2007-11-25  Adam Roben  <aroben@apple.com>
2410
2411         Implement pixel dumping in Windows DRT
2412
2413         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
2414         <rdar://5071708>
2415
2416         Reviewed by Sam.
2417
2418         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
2419         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
2420         Content-Length header.
2421         (getMD5HashStringForBitmap):
2422         (dumpWebViewAsPixelsAndCompareWithExpected):
2423         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
2424         * DumpRenderTree/win/DumpRenderTree.cpp:
2425         (dump): Do a pixel dump if requested.
2426         (main): Parse pixel test options.
2427         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
2428         the cg/ subdirectory to the include path.
2429         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
2430         available in a header or import library, so we have to go through this
2431         LoadLibrary/GetProcAddress dance to use them.
2432         (cryptDLL):
2433         (init):
2434         (update):
2435         (final):
2436         (MD5_Init):
2437         (MD5_Update):
2438         (MD5_Final):
2439         * DumpRenderTree/win/MD5.h: Added.
2440         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
2441         moved up to the top level to share it with Mac eventually.
2442         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
2443         (getBitmapContextFromWebView): Forces the WebView to paint using a
2444         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
2445
2446 2007-11-25  Adam Roben  <aroben@apple.com>
2447
2448         Clean up Windows DRT's option parsing a little bit
2449
2450         Reviewed by Sam.
2451
2452         * DumpRenderTree/win/DumpRenderTree.cpp:
2453         (main): Put non-option arguments into a Vector.
2454
2455 2007-11-25  Adam Roben  <aroben@apple.com>
2456
2457         Make Windows DRT stop changing LF into CRLF
2458
2459         Reviewed by Sam.
2460
2461         * DumpRenderTree/win/DumpRenderTree.cpp:
2462         (main): Put stdout in binary mode.
2463         * Scripts/run-webkit-tests: Remove the CRLF hack.
2464
2465 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
2466
2467         Removed empty directory.
2468
2469         * Scripts/resources: Removed.
2470
2471 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
2472
2473         Fix bisect-builds to work with recent WebKit nightly builds.
2474
2475         Reviewed by Dan.
2476
2477         * Scripts/bisect-builds: Check for the 
2478         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
2479         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
2480         to WebKit.app/Contents/Resources.
2481
2482 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
2483
2484         Reviewed by Maciej.
2485
2486         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
2487         not closed (affects digg.com)
2488
2489         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
2490         one after finishing with a test to avoid having its delayed onload handler firing when
2491         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
2492         but it helps somewhat.
2493
2494 2007-11-22  Mark Rowe  <mrowe@apple.com>
2495
2496         Reviewed by Alp Toker.
2497
2498         Fix build-webkit to propagate make's exit status if it fails.
2499
2500         * Scripts/webkitdirs.pm:
2501
2502 2007-11-22  Dan Bernstein  <mitz@apple.com>
2503
2504         Reviewed by Mark Rowe.
2505
2506         - fix crash when running pixel tests
2507
2508         * DumpRenderTree/mac/DumpRenderTree.mm:
2509         (dumpRenderTree): Parse the command line options before setting up the
2510         environment so that we know if we need to set up the pixel dump
2511         machinery.
2512
2513 2007-11-21  Eric Seidel  <eric@webkit.org>
2514
2515         Speculative build fix for Tiger.
2516
2517         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
2518
2519 2007-11-21  Eric Seidel  <eric@webkit.org>
2520
2521         Reviewed by Tim Hatcher.
2522
2523         Break out more of DumpRenderTree.mm into individual files
2524
2525         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2526         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
2527         (checkedMalloc):
2528         (checkedRealloc):
2529         (makeLargeMallocFailSilently):
2530         * DumpRenderTree/mac/CheckedMalloc.h: Added.
2531         * DumpRenderTree/mac/DumpRenderTree.mm:
2532         (crashHandler):
2533         (dump):
2534         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2535         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
2536         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
2537         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2538         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2539         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
2540         (javaScriptThreads):
2541         (runJavaScriptThread):
2542         (startJavaScriptThreads):
2543         (stopJavaScriptThreads):
2544         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
2545         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
2546         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
2547         (restoreColorSpace):
2548         (setDefaultColorProfileToRGB):
2549         (initializeColorSpaceAndScreeBufferForPixelTests):
2550         (md5HashStringForBitmap):
2551         (dumpWebViewAsPixelsAndCompareWithExpected):
2552
2553 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
2554
2555         Move install-unix-extras to wx directory as it seems only to be used by that 
2556         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
2557         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
2558         have install-unix-extras install into WebKitLibraries as per
2559         convention.
2560         
2561         Reviewed by Mark Rowe.
2562
2563         * Scripts/install-unix-extras: Removed.
2564         * wx/build-wxwebkit:
2565         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
2566
2567 2007-11-21  Eric Seidel  <eric@webkit.org>
2568
2569         Reviewed by Adam.
2570
2571         More refactoring for greater code readability
2572
2573         * DumpRenderTree/mac/DumpRenderTree.mm:
2574         (initializeGlobalsFromCommandLineOptions):
2575         (initializeColorSpaceAndScreeBufferForPixelTests):
2576         (addTestPluginsToPluginSearchPath):
2577         (useLongRunningServerMode):
2578         (runTestingServerLoop):
2579         (prepareConsistentTestingEnvironment):
2580         (dumpRenderTree):
2581         (main):
2582         (dumpFramesAsText):
2583         (dumpBackForwardListForWebView):
2584         (sizeWebViewForCurrentTest):
2585         (methodNameStringForFailedTest):
2586         (dumpBackForwardListForAllWindows):
2587         (dumpWebViewAsPixelsAndCompareWithExpected):
2588         (invalidateAnyPreviousWaitToDumpWatchdog):
2589         (dump):
2590         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2591         * DumpRenderTree/mac/UIDelegate.mm:
2592         (-[UIDelegate webView:createWebViewWithRequest:]):
2593
2594 2007-11-21  Eric Seidel  <eric@webkit.org>
2595
2596         Reviewed by Tim Hatcher.
2597
2598         Abstract more of DRT into static methods
2599
2600         * DumpRenderTree/mac/DumpRenderTree.mm:
2601         (setDefaultsToConsistentValuesForTesting):
2602         (setupSignalHandlers):
2603         (allocateGlobalControllers):
2604         (releaseAndZero):
2605         (releaseGlobalControllers):
2606         (dumpRenderTree):
2607         (shouldLogFrameLoadDelegates):
2608         (createCFURLFromPathOrURL):
2609         (resetWebViewToConsistentStateBeforeTesting):
2610         (runTest):
2611
2612 2007-11-21  Eric Seidel  <eric@webkit.org>
2613
2614         Reviewed by Tim Hatcher.
2615
2616         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
2617
2618         * DumpRenderTree/DumpRenderTree.h:
2619         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2620         * DumpRenderTree/mac/DumpRenderTree.mm:
2621         (dumpRenderTree):
2622         (dump):
2623         (runTest):
2624         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
2625         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
2626         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
2627         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
2628         (-[DumpRenderTreePasteboard declareType:owner:]):
2629         (+[LocalPasteboard alloc]):
2630         (-[LocalPasteboard init]):
2631         (-[LocalPasteboard dealloc]):
2632         (-[LocalPasteboard name]):
2633         (-[LocalPasteboard releaseGlobally]):
2634         (-[LocalPasteboard declareTypes:owner:]):
2635         (-[LocalPasteboard addTypes:owner:]):
2636         (-[LocalPasteboard changeCount]):
2637         (-[LocalPasteboard types]):
2638         (-[LocalPasteboard availableTypeFromArray:]):
2639         (-[LocalPasteboard setData:forType:]):
2640         (-[LocalPasteboard dataForType:]):
2641         (-[LocalPasteboard setPropertyList:forType:]):
2642         (-[LocalPasteboard setString:forType:]):
2643         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
2644         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
2645         (+[DumpRenderTreeWindow allWindows]):
2646         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
2647         (-[DumpRenderTreeWindow dealloc]):
2648         (-[DumpRenderTreeWindow isKeyWindow]):
2649         (-[DumpRenderTreeWindow keyDown:]):
2650
2651 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
2652
2653         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
2654         it indiscriminately copies any headers inside JavaScriptCore,
2655         which includes Tiger ICU headers. 
2656
2657         * wx/build-wxwebkit:
2658         Don't run WebCore/move-js-headers.sh any longer.
2659
2660 2007-11-20  Adam Treat  <treat@kde.org>
2661
2662         Reviewed by David Kilzer.
2663
2664         * Prepend git branch name to $baseProductDir
2665
2666         * Scripts/VCSUtils.pm:
2667         * Scripts/webkitdirs.pm:
2668
2669 2007-11-20  Mark Rowe  <mrowe@apple.com>
2670
2671         Reviewed by Simon Hausmann.
2672
2673         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
2674         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
2675         Have it trigger a "make distclean" rather than "make clean" to ensure that the
2676         built product and generated Makefile's are removed.
2677
2678 2007-11-19  Alp Toker  <alp@atoker.com>
2679
2680         Reviewed by Mark Rowe.
2681
2682         http://bugs.webkit.org/show_bug.cgi?id=16040
2683         [GTK] GtkLauncher should be written in C
2684
2685         Port GtkLauncher to plain C.
2686
2687         Use a more conventional GTK+ coding style.
2688
2689         Use a toolbar instead of menus.
2690
2691         Various signature fixes and cleanups.
2692
2693         Add a license header. Assume all previous modifications were copyright
2694         assigned to Apple Inc. by default.
2695
2696         * GtkLauncher/GtkLauncher.pro:
2697         * GtkLauncher/main.c: Added.
2698         (activate_url_entry_cb):
2699         (update_title):
2700         (link_hover_cb):
2701         (title_change_cb):
2702         (progress_change_cb):
2703         (destroy_cb):
2704         (go_back_cb):
2705         (go_forward_cb):
2706         (create_browser):
2707         (create_statusbar):
2708         (create_toolbar):
2709         (create_window):
2710         (main):
2711         * GtkLauncher/main.cpp: Removed.
2712
2713 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
2714
2715         Build script fixes to ensure they do the right thing for the 
2716         wx port, and update build-wxwebkit to reflect the way the
2717         build scripts now work.
2718
2719         Reviewed by Adam.
2720
2721         * Scripts/build-testkjs:
2722         * Scripts/build-webkit:
2723         * Scripts/run-javascriptcore-tests:
2724         * Scripts/webkitdirs.pm:
2725         * wx/build-wxwebkit:
2726
2727 2007-11-18  Eric Seidel  <eric@webkit.org>
2728
2729         Reviewed by Anders.
2730
2731         Make run-javascriptcore-tests report failures on exit (to support git bisect)
2732
2733         * Scripts/run-javascriptcore-tests:
2734
2735 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
2736
2737         Reviewed by Adam Roben.
2738
2739         Make run-webkit-tests work with Windows debug build.
2740
2741         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
2742         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
2743         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
2744         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
2745         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
2746
2747 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
2748
2749         Add wxWebKit sample and build script, and integrate it with 
2750         build-webkit. Also make build-webkit --clean work for all
2751         ports.
2752
2753         Reviewed by Darin Adler.
2754
2755         * Scripts/build-webkit:
2756         * Scripts/webkitdirs.pm:
2757         * wx: Added.
2758         * wx/browser: Added.
2759         * wx/browser/browser.bkl: Added.
2760         * wx/browser/browser.cpp: Added.
2761         * wx/build-wxwebkit: Added.
2762
2763 2007-11-17  Adam Roben  <aroben@apple.com>
2764
2765         Make it easy to run Safari in the debugger on Windows
2766
2767         I've added a new script, debug-safari, which launches Safari in the
2768         debugger. On OS X it just calls gdb-safari.
2769
2770         Reviewed by Mark Rowe.
2771
2772         * FindSafari/FindSafari.cpp:
2773         (_tmain): Added a /debugger flag, which in combination with
2774         /printSafariLauncher will print a script that launches Safari in the
2775         debugger.
2776         * Scripts/debug-safari: Added.
2777         * Scripts/run-safari: Changed to call runSafari().
2778         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
2779         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
2780         first argument along to FindSafari.
2781         * Scripts/webkitdirs.pm:
2782         (sub runSafari): Added.
2783
2784 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
2785
2786         Reviewed by Adam Roben.
2787
2788         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
2789
2790 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
2791
2792         Reviewed by David Kilzer.
2793
2794         The git config command was renamed to repo-config at some point. This
2795         change tries git config and then git repo-config if the first fails.
2796
2797         * Scripts/prepare-ChangeLog:
2798         (gitConfig):
2799
2800 2007-11-16  Dan Bernstein  <mitz@apple.com>
2801
2802         Reviewed by Darin Adler and Sam Weinig.
2803
2804         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
2805
2806         * DumpRenderTree/win/EventSender.cpp:
2807         (keyDownCallback): For characters that cannot be entered on the active
2808         keyboard layout, send a WM_CHAR message with the character along with
2809         a WM_KEYDOWN message with a virtual key code of 255.
2810
2811 2007-11-16  Mark Rowe  <mrowe@apple.com>
2812
2813         Reviewed by Tim Hatcher.
2814
2815         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
2816
2817         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2818         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2819
2820 2007-11-15  Adam Roben  <aroben@apple.com>
2821
2822         Make run-safari actually work on Windows
2823
2824         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
2825         chdir call.
2826
2827 2007-11-14  Adam Roben  <aroben@apple.com>
2828
2829         Updates to Safari launching now that 3.0.4 is released
2830
2831         Reviewed by Sam.
2832
2833         * FindSafari/FindSafari.cpp:
2834         (getWebViewCLSID): Use version-independent ProgID.
2835         * Scripts/run-safari: Use run-webkit-nightly.cmd.
2836
2837 2007-11-14  Anders Carlsson  <andersca@apple.com>
2838
2839         Reviewed by Adam.
2840
2841         <rdar://problem/5309081>
2842         In DRT, "plugin.logDestroy = true" not working on Windows.
2843         
2844         * DumpRenderTree/win/TestNetscapePlugin/main.c:
2845         (NPP_Destroy):
2846
2847 2007-11-14  Eric Seidel  <eric@webkit.org>
2848
2849         Reviewed by Sam.
2850
2851         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
2852
2853 2007-11-14  Anders Carlsson  <andersca@apple.com>
2854
2855         Reviewed by Adam.
2856
2857         <rdar://problem/5141186>
2858         window.layoutTestController.setWindowIsKey is not implemented in DRT.
2859         
2860         Implement setWindowIsKey.
2861         
2862         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2863         (LayoutTestController::setWindowIsKey):
2864
2865 2007-11-13  Sam Weinig  <sam@webkit.org>
2866
2867         Reviewed by Adam Roben.
2868
2869         Fix for <rdar://problem/5382579>
2870         http/tests/security/cross-frame-access-put.html reports large 
2871         negative numbers for screenLeft and screenTop (Mac reports "0")
2872
2873         * DumpRenderTree/win/UIDelegate.cpp:
2874         (UIDelegate::UIDelegate): Initialize the RECT.
2875         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
2876         (UIDelegate::webViewFrame): ditto.
2877         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
2878
2879 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
2880
2881         Reviewed by Adam.
2882
2883         - Make Drosera show source, source URLs, and function stack on Windows,
2884         and some minor fixes.
2885
2886         * Drosera/DebuggerDocument.cpp: Force source to always update display.
2887         (DebuggerDocument::updateFileSource):
2888         * Drosera/debugger.js: Force source to always update display.
2889         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
2890         menu controls.
2891         (DebuggerClient::resume):
2892         (DebuggerClient::pause):
2893         (DebuggerClient::stepInto):
2894         (DebuggerClient::stepOver):
2895         (DebuggerClient::stepOut):
2896         (DebuggerClient::showConsole):
2897         (DebuggerClient::closeCurrentFile):
2898         * Drosera/win/DebuggerClient.h: Ditto.
2899         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
2900         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
2901         removed two bugs.  1) caller could be in a bad state when asked to
2902         assign into it. 2) BSTRs were not created correctly.
2903         (DebuggerDocument::getPlatformCurrentFunctionStack):
2904         * Drosera/win/Drosera.cpp: Hook up the menu controls.
2905         (droseraWndProc):
2906         (handleCommand):
2907         (Drosera::resume):
2908         (Drosera::pause):
2909         (Drosera::stepInto):
2910         (Drosera::stepOver):
2911         (Drosera::stepOut):
2912         (Drosera::showConsole):
2913         (Drosera::closeCurrentFile):
2914         * Drosera/win/Drosera.h: Hook up the menu controls.
2915         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
2916         functions, added a null check, and fixed another bug where caller could
2917         be in a bad state when asked to assign into it.
2918         (ServerConnection::didLoadMainResourceForDataSource):
2919         (ServerConnection::getCallerFrame):
2920         * Drosera/win/ServerConnection.h: Safety first.
2921
2922 2007-11-13  Dan Bernstein  <mitz@apple.com>
2923
2924         Reviewed by Darin Adler.
2925
2926         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
2927           DumpRenderTree --pixel-tests renders each test twice
2928
2929         * DumpRenderTree/mac/DumpRenderTree.mm:
2930         (dumpRenderTree): Removed the --paint option because the painting code
2931         is always exercised as a result of
2932         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
2933         calling -displayIfNeeded.
2934         (dump): Changed to always grab the image from the window since the view
2935         is always displayed.
2936         (runTest):
2937         (displayWebView):
2938         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
2939         because it always paints.
2940
2941 2007-11-12  Antti Koivisto  <antti@apple.com>
2942
2943         Reviewed by Adele.
2944         
2945         Add support for http media tests
2946
2947         * Scripts/run-webkit-tests:
2948
2949 2007-11-12  Sam Weinig  <sam@webkit.org>
2950
2951         Reviewed by Adam Roben.
2952
2953         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
2954
2955         * DumpRenderTree/win/DumpRenderTree.cpp:
2956         (runTest):
2957         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2958         (LayoutTestController::setPrivateBrowsingEnabled):
2959
2960 2007-11-12  Adam Roben  <aroben@apple.com>
2961
2962         * Scripts/update-webkit-localizable-strings: Changed to only scan the
2963         mac and win subdirectories.
2964
2965 2007-11-11  Adam Roben  <aroben@apple.com>
2966
2967         Fix <rdar://5133816> keepWebHistory is not implemented
2968
2969         Fixes fast/history/clicked-link-is-visited.html.
2970
2971         Reviewed by Darin.
2972
2973         * DumpRenderTree/win/DumpRenderTree.cpp:
2974         (runTest): Clear the optionalSharedHistory.
2975         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2976         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
2977
2978 2007-11-10  Sam Weinig  <sam@webkit.org>
2979
2980         Reviewed by Tim Hatcher.
2981
2982         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
2983         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
2984         is turned on)
2985
2986         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
2987
2988         Added test: http/tests/security/cross-frame-access-private-browsing.html
2989
2990         * DumpRenderTree/LayoutTestController.cpp:
2991         (setPrivateBrowsingEnabledCallback):
2992         (LayoutTestController::staticFunctions):
2993         * DumpRenderTree/LayoutTestController.h:
2994         * DumpRenderTree/mac/DumpRenderTree.mm:
2995         (runTest): Default to private browsing disabled.
2996         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2997         (LayoutTestController::setPrivateBrowsingEnabled):
2998         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2999         (LayoutTestController::setPrivateBrowsingEnabled):
3000
3001 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
3002
3003         Reviewed by Adam.
3004
3005         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
3006         WebCore's!
3007
3008         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
3009         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
3010         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
3011         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
3012         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
3013         * Drosera/win/Drosera.cpp:
3014         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
3015
3016 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
3017
3018         Reviewed by Sam.
3019
3020         - Use the new IWebFrame [local] function signature and get the shared
3021         server correctly.
3022
3023         * Drosera/win/DebuggerClient.cpp:
3024         (DebuggerClient::didFinishLoadForFrame):
3025         * Drosera/win/ServerConnection.cpp:
3026         (ServerConnection::attemptToCreateServerConnection):
3027
3028 2007-11-07  Dan Bernstein  <mitz@apple.com>
3029
3030         Reviewed by Darin Adler.
3031
3032         - add an option to run-webkit-tests to ignore pixel test failures where
3033           all pixels differ by no more than a specified threshold
3034
3035         * DumpRenderTree/mac/ImageDiff.m:
3036         (main):
3037         (compareImages):
3038         (computePercentageDifferent):
3039         * Scripts/run-webkit-tests:
3040
3041 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3042
3043         Reviewed by Lars.
3044
3045         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
3046
3047         * DumpRenderTree/qt/DumpRenderTree.cpp:
3048
3049 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3050
3051         Reviewed by Lars.
3052
3053         Reworked the QWebSettings API.
3054         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
3055
3056         * DumpRenderTree/qt/DumpRenderTree.cpp:
3057
3058 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3059
3060         Reviewed by Lars.
3061
3062         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
3063
3064         * DumpRenderTree/qt/jsobjects.cpp:
3065
3066 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3067
3068         Reviewed by Lars Knoll <lars@trolltech.com>.
3069
3070         Add a QWebPage::frameCreated() signal and fix DRT
3071         
3072         The removal of createFrame in QWebPage broke the re-implementation
3073         in DumpRenderTree. Instead emit a frameCreated() signal and
3074         connect to it in DumpRenderTree.
3075         
3076
3077         * DumpRenderTree/qt/DumpRenderTree.cpp:
3078         (WebCore::WebPage::WebPage):
3079         (WebCore::DumpRenderTree::dump):
3080         (WebCore::DumpRenderTree::connectFrame):
3081         * DumpRenderTree/qt/DumpRenderTree.h:
3082
3083 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3084
3085         Reviewed by Lars Knoll <lars@trolltech.com>.
3086
3087         Moved all the event handlers from QWebFrame into QWebPage.
3088         
3089         This cleans up the public API and allows us to remove the
3090         HackWebFrame hack in DumpRenderTree.
3091         
3092
3093         * DumpRenderTree/qt/jsobjects.cpp:
3094         (EventSender::mouseDown):
3095         (EventSender::mouseUp):
3096         (EventSender::mouseMoveTo):
3097
3098 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3099
3100         Reviewed by Mark.
3101
3102         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
3103         to prevent the default implementation from popping up messageboxes.
3104
3105         * DumpRenderTree/qt/DumpRenderTree.cpp:
3106         (WebCore::WebPage::javaScriptConfirm):
3107         (WebCore::WebPage::javaScriptPrompt):
3108
3109 2007-11-06  Eric Seidel  <eric@webkit.org>
3110
3111         * Scripts/build-testkjs: build fix... too many $$
3112
3113 2007-11-06  Eric Seidel  <eric@webkit.org>
3114
3115         Reviewed by Mark Rowe.
3116
3117         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
3118
3119 2007-11-05  Adam Roben  <aroben@apple.com>
3120
3121         Add support on Windows for WEBKIT_TESTFONTS
3122
3123         This environment variable lets you specify where the fonts to be used
3124         by DumpRenderTree reside. The Qt port is already using this, so I'm
3125         just following their lead.
3126
3127         Reviewed by Darin.
3128
3129         * DumpRenderTree/win/DumpRenderTree.cpp:
3130         (exePath): Refactored code out of initialize().
3131         (fontsPath): Returns either $WEBKIT_TESTFONTS or
3132         DumpRenderTree.resources.
3133         (initialize): Use the new fontsPath function.
3134         (main): Use the new exePath function.
3135         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
3136         variable to DRT, like Qt does.
3137
3138 2007-11-05  Mark Rowe  <mrowe@apple.com>
3139
3140         Rubber-stamped by Alp Toker.
3141
3142         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
3143
3144         * GtkLauncher/main.cpp:
3145         (goToURLBarText):
3146         (main):
3147
3148 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
3149
3150         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
3151         <http://bugs.webkit.org/show_bug.cgi?id=15830>
3152
3153         Reviewed by Timothy.
3154
3155         Restrict the range of nightly builds used by the bisect-builds script
3156         based on the version of Safari and the version of Mac OS X being used.
3157
3158         Mac OS X 10.4: Safari 2.0: r11976 or newer
3159         Mac OS X 10.4: Safari 3.0: r19992 or newer
3160
3161         Mac OS X 10.5: Safari 2.0: r19594 or newer
3162         Mac OS X 10.5: Safari 3.0: r25124 or newer
3163
3164         * Scripts/bisect-builds:
3165         (findMacOSXVersion): Added.
3166         (makeNightlyList): Added argument to provide version of Mac OS X.
3167         Restrict range of nightly builds based on Safari and Mac OS X versions.
3168
3169 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
3170
3171         Reviewed by Maciej.
3172
3173         - This patch involves several changes, all of them were noticed that
3174         they were needed by the work being done in WebKit to get Drosera and
3175         WebKit working together on Windows.
3176         - The changes are:
3177         1) Added a debugger console for output messages.
3178         2) Drosera now listens for the WebKit server (before, the server would
3179         have to be running before Drosera was started.)
3180         3) Fixed a bug where the WebView started out as 0x0 pixels.
3181         4) Fixed a bug when there is no scope.
3182         5) Added the HTML, JS, and CSS to the project file to make them easy to
3183         find.
3184         6) Made the ServerConnection functions virtual.
3185
3186         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
3187         for the WebKit server.
3188         (DebuggerClient::DebuggerClient):
3189         (DebuggerClient::~DebuggerClient):
3190         (DebuggerClient::didFinishLoadForFrame):
3191         (DebuggerClient::serverConnected):
3192         (DebuggerClient::attemptToCreateServerConnection):
3193         * Drosera/win/DebuggerClient.h: Ditto.
3194         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
3195         scope.
3196         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3197         (DebuggerDocument::platformValueForScopeVariableNamed):
3198         * Drosera/win/Drosera.cpp:
3199         (_tWinMain): Added a console in debug for output messages.
3200         (Drosera::Drosera): Listen for server.
3201         (Drosera::initUI): The server now Initializes COM.
3202         (Drosera::serverConnected): Part of the listening for the server.
3203         (Drosera::attemptToCreateServerConnection): Ditto.
3204         * Drosera/win/Drosera.h: New interface for listening for the server.
3205         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
3206         files to the VS project.
3207         * Drosera/win/ServerConnection.cpp: Part of listening for the server
3208         connection.
3209         (ServerConnection::ServerConnection):
3210         (ServerConnection::attemptToCreateServerConnection):
3211         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
3212         methods.
3213         (ServerConnection::serverConnected):
3214
3215 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
3216
3217         Reviewed by Maciej.
3218
3219         http://bugs.webkit.org/show_bug.cgi?id=15832
3220         fast/dom/gc-10.html crashes when run alone
3221
3222         Check for !done before using objects that can be already deallocated.
3223
3224         * DumpRenderTree/mac/EditingDelegate.mm:
3225         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
3226         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
3227         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
3228         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
3229         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
3230         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
3231         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
3232         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
3233         (-[EditingDelegate webViewDidBeginEditing:]):
3234         (-[EditingDelegate webViewDidChange:]):
3235         (-[EditingDelegate webViewDidEndEditing:]):
3236         (-[EditingDelegate webViewDidChangeTypingStyle:]):
3237         (-[EditingDelegate webViewDidChangeSelection:]):
3238         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3239         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
3240         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
3241         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3242         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
3243         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
3244         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
3245         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3246         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
3247         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
3248         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
3249         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
3250         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
3251         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
3252         (-[FrameLoadDelegate webView:willCloseFrame:]):
3253         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
3254         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
3255         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3256         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
3257         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3258         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
3259         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
3260         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
3261         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
3262
3263 2007-11-04  Mark Rowe  <mrowe@apple.com>
3264
3265         Build fix.  Don't use Carbon.h as the prefix header as it triggers
3266         warnings that would otherwise be suppressed due to it being a system header.
3267
3268         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3269
3270 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
3271
3272         Rubber stamped by Adam.
3273         
3274         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
3275
3276         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3277
3278 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
3279
3280         Sort files(...); sections of Xcode project files.
3281
3282         Rubber-stamped by Darin.
3283
3284         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
3285         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3286         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3287         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
3288
3289 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
3290
3291         Script to sort "files(...);" sections in Xcode project.pbxproj files.
3292
3293         Reviewed by Darin.
3294
3295         * Scripts/sort-Xcode-project-file: Added.
3296
3297 2007-11-02  Darin Adler  <darin@apple.com>
3298
3299         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
3300
3301 2007-11-02  Darin Adler  <darin@apple.com>
3302
3303         Reviewed by Maciej.
3304
3305         * Scripts/run-sunspider: Pass the "--base" option through.
3306
3307         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
3308         the real script do that. Default configuration to Release to match run-sunspider
3309         so we don't end up building Debug just to compare results.
3310
3311 2007-11-01  Adam Roben  <aroben@apple.com>
3312
3313         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
3314
3315         Reviewed by Sam.
3316
3317         * Scripts/commit-log-editor: Show all the directories beneath the
3318         source root, instead of just the last one.
3319
3320 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
3321
3322         Reviewed by Adam Roben.
3323
3324         Print out an error message when the Windows build fails
3325         and provide guidance on how to find out what went wrong.
3326
3327         * Scripts/build-webkit:
3328         * Scripts/webkitdirs.pm:
3329
3330 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
3331
3332         Rubber-stamped by Adam Roben.
3333
3334         Rolled out r27326 - debug CRT seems to cause no problems after all.
3335
3336         * DumpRenderTree/win/DumpRenderTree.vcproj:
3337
3338 2007-10-31  Adam Roben  <aroben@apple.com>
3339
3340         Switch the Debug configuration to using the non-debug CRT
3341
3342         This matches WebKit.
3343
3344         Reviewed by Steve.
3345
3346         * DumpRenderTree/win/DumpRenderTree.vcproj:
3347
3348 2007-10-31  Antti Koivisto  <antti@apple.com>
3349
3350         Reviewed by bdash.
3351         
3352         Disable media tests when doing leak checking on Tiger.
3353         They crash in QuickTime (rdar://problem/5537157).
3354
3355         * Scripts/run-webkit-tests:
3356
3357 2007-10-29  Antti Koivisto  <antti@apple.com>
3358
3359         Reviewed by Maciej.
3360         
3361         Build media support by default on OSX only.
3362
3363         * Scripts/build-webkit:
3364
3365 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3366
3367         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
3368         get caught by the pre-commit hooks.
3369
3370 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3371
3372         Reviewed by Adam.
3373
3374         - This is a collection of relatively unrelated changes and cleanups
3375         to Drosera to prepare it for interacting with WebKit.  A lot of these
3376         changes are just correcting mistakes, for example removing included
3377         headers that are no longer needed.
3378
3379         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
3380         this will be needed by the DebuggerClient.
3381         (DebuggerDocument::server):
3382         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
3383         * Drosera/win/DebuggerClient.cpp: 
3384         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
3385         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
3386         (DebuggerClient::createWebViewWithRequest): Added comment about its
3387         purpose. 
3388         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
3389         declarations.
3390         (DebuggerClient::webViewLoaded): Moved.
3391         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
3392         file, since this was the only place it was used.
3393         (cfStringToBSTR):
3394         * Drosera/win/Drosera.h: Cleaned up the includes.
3395         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
3396         * Drosera/win/HelperFunctions.h: Removed.
3397
3398 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3399
3400         Reviewed by Adam.
3401
3402         - Small cleanup in the ServerConnection class.
3403
3404         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
3405         and added an include.
3406         (ServerConnection::currentFrame):
3407         (ServerConnection::getCallerFrame):
3408         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
3409         made a pointer into a COMPtr, and cleaned up the includes.
3410
3411 2007-10-29  Timothy Hatcher  <timothy@apple.com>
3412
3413         Reviewed by John Sullivan.
3414         
3415         - Place the Localizable.strings file in mac or win directories
3416           if that location exists.
3417         - Also look for UI_STRING in .c files.
3418
3419         * Scripts/extract-localizable-strings:
3420
3421 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3422
3423         Reviewed by Adam.
3424
3425         - Set the eol-style to native and made all the line endings the same
3426         so that I avoid messy diffs that show eol changes.
3427
3428         * Drosera/win/ServerConnection.cpp:
3429         (ServerConnection::didParseSource):
3430         (ServerConnection::didEnterCallFrame):
3431         (ServerConnection::willExecuteStatement):
3432         (ServerConnection::willLeaveCallFrame):
3433         (ServerConnection::exceptionWasRaised):
3434
3435 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3436
3437         Reviewed by Adam.
3438
3439         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
3440         functionality that could not have existed previously without the new
3441         interfaces.
3442         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
3443         from a BSTR to a JSValueRef.
3444         (DebuggerDocument::platformEvaluateScript): Implemented.
3445         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
3446         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3447         Implemented.
3448         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
3449         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
3450         * Drosera/win/ServerConnection.cpp: Added a helper function.
3451         (ServerConnection::getCallerFrame):
3452         * Drosera/win/ServerConnection.h: Added a helper function.
3453
3454 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
3455
3456         updated reviewers for my previous changelog.
3457
3458 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
3459         Reviewed by Maciej and Adam and Geoff.
3460
3461         - Minor mac-side improvements including moving a function to a more
3462         appropriate location, fixing a warning, and correctly checking
3463         exceptions.
3464
3465         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
3466         (DebuggerDocument::willExecuteStatement):
3467         (DebuggerDocument::didEnterCallFrame):
3468         (DebuggerDocument::willLeaveCallFrame):
3469         (DebuggerDocument::windowScriptObjectAvailable):
3470         (DebuggerDocument::callFunctionOnObject):
3471         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
3472         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
3473         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
3474         because it doesn't require the ServerConnection at all.
3475         (NSStringCreateWithJSStringRef): Made an argument const.
3476         (JSValueRefCreateWithNSString): Made an argument const.
3477         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
3478         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3479         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
3480         * Drosera/mac/ServerConnection.mm: Ditto.
3481         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
3482
3483 2007-10-29  Sam Weinig  <sam@webkit.org>
3484
3485         Reviewed by Adam Roben.
3486
3487         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
3488
3489         * DumpRenderTree/LayoutTestController.cpp:
3490         (LayoutTestController::LayoutTestController):
3491         (getGlobalFlagCallback):
3492         (setGlobalFlagCallback):
3493         (LayoutTestController::getJSClass):
3494         (LayoutTestController::staticValues):
3495         * DumpRenderTree/LayoutTestController.h:
3496         (LayoutTestController::globalFlag):
3497         (LayoutTestController::setGlobalFlag):
3498
3499 2007-10-29  Darin Adler  <darin@apple.com>
3500
3501         Reviewed by Maciej.
3502
3503         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
3504         resolution instead of its default.
3505
3506 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
3507
3508         Fixed showStatus() to print status for successfully resolved conflicts when using git.
3509
3510         Reviewed by Mark Rowe.
3511
3512         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
3513         was successfully resolved, but this would not show any status because the change had
3514         already been cached in the index using "git add".  The solution is to add an optional
3515         second argument to showStatus() which adds the "--cached" switch to the command.
3516
3517         * Scripts/resolve-ChangeLogs:
3518         (showStatus):
3519
3520 2007-10-28  Eric Seidel  <eric@webkit.org>
3521
3522         Reviewed by Maciej and Geoff, in unison.
3523
3524         * Scripts/run-webkit-tests: remove broken --svg option
3525
3526 2007-10-28  Darin Adler  <darin@apple.com>
3527
3528         Reviewed by Adam.
3529
3530         * Scripts/run-sunspider: Default to "Release" configuration rather than
3531         defaulting to the last configuration used as other scripts do. This can
3532         still be overriden on the command line with "--debug" if there's some
3533         reason to do so. Also fix a typo.
3534
3535         * Scripts/sunspider-compare-results: Fix a typo.
3536
3537 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
3538
3539         Reviewed by Adam.
3540
3541         - Implemented the WebScriptDebugListener functions now that the
3542         WebScriptDebugServer exists
3543
3544         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
3545         functions.
3546         (ServerConnection::currentFrame):
3547         (ServerConnection::didLoadMainResourceForDataSource):
3548         (ServerConnection::didParseSource):
3549         (ServerConnection::failedToParseSource):
3550         (ServerConnection::didEnterCallFrame):
3551         (ServerConnection::willExecuteStatement):
3552         (ServerConnection::willLeaveCallFrame):
3553         (ServerConnection::exceptionWasRaised):
3554         * Drosera/win/ServerConnection.h: Removed unused arguments from the
3555         members arguments list.
3556
3557 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
3558
3559         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
3560         <http://bugs.webkit.org/show_bug.cgi?id=15600>
3561
3562         Reviewed by Darin.
3563
3564         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
3565         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
3566         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
3567         file.  Note that it may also be used as a stand-alone script.
3568
3569         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
3570         * Scripts/resolve-ChangeLogs: Added.
3571         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
3572
3573 2007-10-26  Mark Rowe  <mrowe@apple.com>
3574
3575         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
3576         to the Qt port on the assumption that it was an implementation of the cross-platform
3577         LayoutTestController class.  It is not, so it did not need to be changed.
3578
3579         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
3580
3581 2007-10-25  Mark Rowe  <mrowe@apple.com>
3582
3583         Reviewed by Maciej.
3584
3585         Fix builds with code coverage enabled.
3586
3587         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
3588
3589 2007-10-25  Darin Adler  <darin@apple.com>
3590
3591         Reviewed by Mark Rowe.
3592
3593         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
3594         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
3595
3596 2007-10-25  Stephanie  <slewis@apple.com>
3597
3598         build Fix
3599
3600         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3601
3602 2007-10-25  Stephanie  <slewis@apple.com>
3603
3604         Reviewed by Mark Rowe, Adam Roben.
3605
3606         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
3607
3608         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
3609
3610 2007-10-25  Alice Liu  <alice.liu@apple.com>
3611
3612         Reviewed by Adam.
3613
3614         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
3615
3616         Moving destructor into platform-specific files
3617         * DumpRenderTree/LayoutTestController.cpp:
3618         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3619         (LayoutTestController::~LayoutTestController):
3620         * DumpRenderTree/qt/jsobjects.cpp:
3621         (LayoutTestController::~LayoutTestController):
3622
3623         LayoutTestController wasn't being destroyed
3624         * DumpRenderTree/win/DumpRenderTree.cpp:
3625         (runTest):
3626
3627         Added declspec
3628         * DumpRenderTree/win/EditingDelegate.h:
3629
3630         Reset certain values on the webview (or related delegate) that might 
3631         have changed while running a test
3632         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3633         (LayoutTestController::~LayoutTestController):
3634
3635 2007-10-25  Adam Roben  <aroben@apple.com>
3636
3637         Make sunspider-compare-results work with relative paths
3638
3639         Reviewed by Sam.
3640
3641         * Scripts/sunspider-compare-results: Convert arguments to absolute
3642         paths before we chdir.
3643
3644 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
3645
3646         Reviewed by Sam.
3647
3648         - Implemented server calls now the WebScriptDebugServer exists.
3649         - Also removed no longer needed call to initialize CG.
3650
3651         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
3652         automatically now.
3653         (_tWinMain):
3654         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
3655         (ServerConnection::ServerConnection):
3656         (ServerConnection::~ServerConnection):
3657         (ServerConnection::pause):
3658         (ServerConnection::resume):