Unreviewed build fix for WebInspector with Qt build.
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-11-03  Eric Seidel  <eric@webkit.org>
2
3         No review, just changing wording of log message.
4
5         Change log string to say "failed" instead of "rejected"
6         when a commit fails due to an out of date checkout.
7         This makes grepping the commit-queue log for rejected patches easier.
8
9         * Scripts/bugzilla-tool:
10
11 2009-11-03  Eric Seidel  <eric@webkit.org>
12
13         No review, adding commonly known committers missing from the file.
14
15         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
16
17 2009-11-03  Eric Seidel  <eric@webkit.org>
18
19         No review, just sort-order cleanup.
20
21         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
22
23 2009-11-03  Stephen White  <senorblanco@chromium.org>
24
25         (Unreviewed).
26
27         Add myself to committers.py.
28
29         * Scripts/modules/committers.py:
30
31 2009-11-03  Robin Dunn  <robin@alldunn.com>
32
33         Reviewed by Kevin Ollviier.
34
35         Add packaging scripts for Debian-based Linux distros.
36         
37         https://bugs.webkit.org/show_bug.cgi?id=31075
38
39         * wx/packaging/build-debian-installer.py: Added.
40         * wx/packaging/debian: Added.
41
42 2009-11-03  Dan Bernstein  <mitz@apple.com>
43
44         Reviewed by Anders Carlsson and Beth Dakin.
45
46         https://bugs.webkit.org/show_bug.cgi?id=31070
47
48         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
49         destroyed, it executes the value of the 'ondestroy' parameter as a
50         script.
51
52         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
53         (pluginAllocate): Initialize onDestroy.
54         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
55         onDestroy.
56         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
57         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
58         specified.
59         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
60
61 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
62
63         Reviewed by Xan Lopez.
64
65         https://bugs.webkit.org/show_bug.cgi?id=31035
66         [GTK] some accessibility tests hitting assertion in debug builds
67
68         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
69
70         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
71         (AccessibilityController::rootElement):
72
73 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
74
75         Reviewed by Beth Dakin.
76
77         Support ARIA "tab" roles
78         https://bugs.webkit.org/show_bug.cgi?id=30842
79
80         * DumpRenderTree/AccessibilityUIElement.cpp:
81         * DumpRenderTree/AccessibilityUIElement.h:
82         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
83         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
84         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
85
86 2009-11-01  Eric Seidel  <eric@webkit.org>
87
88         Reviewed by David Levin.
89
90         buildbots should use --exit-after-N-failures
91         https://bugs.webkit.org/show_bug.cgi?id=30809
92
93         Make the bots exit after 20 failures to prevent never-ending
94         test runs where every test spends a minute crashing.
95
96         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
97
98 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
99
100         Reviewed by Eric Seidel.
101
102         Turn on warnings for QtWebKit for gcc
103         https://bugs.webkit.org/show_bug.cgi?id=30958
104
105         * DumpRenderTree/qt/main.cpp: 
106         (crashHandler): Mark function NO_RETURN
107
108 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
109
110         Adding myself to the committers list.
111
112         * Scripts/modules/committers.py:
113
114 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
115
116         Fix an issue that Adam noticed in DRT.
117
118         Reviewed by Darin Adler.
119
120         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
121         (AccessibilityUIElement::role):
122         Get the length of the role text, and create a buffer dynamically.
123
124 2009-10-30  Eric Seidel  <eric@webkit.org>
125
126         No review, rolling out r50105.
127         http://trac.webkit.org/changeset/50105
128
129         This commit was causing:
130         https://bugs.webkit.org/show_bug.cgi?id=30869
131         We'll re-implement the feature a different way.
132
133         * Scripts/bugzilla-tool:
134
135 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
136
137         Test for MSAA: Accessibility of headings is not correct
138
139         https://bugs.webkit.org/show_bug.cgi?id=30937
140
141         Reviewed by Adam Roben.
142
143         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
144         (AccessibilityUIElement::role):
145         Allow the role returned to be a BSTR.
146         (AccessibilityUIElement::description):
147         Fix a copy/paste error.
148
149 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
150
151         Test for MSAA: Accessibility of links is wrong
152
153         https://bugs.webkit.org/show_bug.cgi?id=30928
154
155         Reviewed by Darin Adler.
156
157         * DumpRenderTree/AccessibilityUIElement.cpp:
158         (getAccessibilityValueCallback):
159         Return the accessibility value.
160         (AccessibilityUIElement::getJSClass):
161         Added "accessibilityValue" value.
162
163         * DumpRenderTree/AccessibilityUIElement.h:
164
165         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
166         (AccessibilityUIElement::accessibilityValue):
167         Stubbed.
168
169         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
170         (AccessibilityUIElement::accessibilityValue):
171         Stubbed.
172
173         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
174         (AccessibilityUIElement::accessibilityValue):
175         Get the object's value, and return it as a JS string.
176
177 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
178
179         Fix typo in command name used by wx build system.
180
181         * wx/build/build_utils.py:
182
183 2009-10-30  Adam Barth  <abarth@webkit.org>
184
185         Reviewed by Darin Adler.
186
187         Patch v1 is a dumb default name for patches
188         https://bugs.webkit.org/show_bug.cgi?id=30952
189
190         Let's use "Patch" instead.
191
192         * Scripts/bugzilla-tool:
193
194 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
195
196         Unreviewed trivial buildfix.
197
198         [Qt] Buildfix for r50333.
199
200         * DumpRenderTree/qt/DumpRenderTree.pro:
201
202 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
203
204         Reviewed by Holger Freyther.
205
206         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
207         https://bugs.webkit.org/show_bug.cgi?id=30953
208
209         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
210         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
211         makes qt DRT to share this implementation (as gtk and mac ports do).
212
213         * DumpRenderTree/qt/DumpRenderTree.pro:
214         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
215         * DumpRenderTree/qt/WorkQueue.h: Removed.
216
217 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
218
219         Unreviewed potential buildbot fix.
220
221         Second try: Reset page history before running each test.
222
223         Apparently the QWebHistory::clear() keeps the current page
224         in history which is not what we want, so we not additionally
225         sets the history capacity to 0 (forces removing everything)
226         and then sets it back to its original value.
227
228         * DumpRenderTree/qt/DumpRenderTree.cpp:
229         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
230
231 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
232
233         Unreviewed potential buildbot fix.
234
235         Reset page history before running each test.
236
237         * DumpRenderTree/qt/DumpRenderTree.cpp:
238         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
239
240 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
241
242         Reviewed by Eric Seidel.
243
244         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
245
246         Bug 28420 -  Implement HTML5 <ruby> rendering
247         (https://bugs.webkit.org/show_bug.cgi?id=28420)
248
249         No new tests (no functional change).
250
251         * Scripts/build-webkit:
252
253 2009-10-29  Dan Bernstein  <mitz@apple.com>
254
255         Reviewed by Mark Rowe.
256
257         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
258         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
259         define it.
260
261         * Scripts/VCSUtils.pm:
262         * Scripts/svn-apply:
263         * Scripts/svn-unapply:
264
265 2009-10-29  Xan Lopez  <xlopez@igalia.com>
266
267         Reviewed by Gustavo Noronha.
268
269         Use the GTK+ main loop instead of rolling our own mini-version of
270         it.
271
272         * DumpRenderTree/gtk/DumpRenderTree.cpp:
273         (dump):
274         (runTest):
275         (webViewLoadFinished):
276
277 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
278
279         Reviewed by Oliver Hunt.
280
281         Implement the Qt version of DRT dumpBackForwardList().
282
283         * DumpRenderTree/qt/DumpRenderTree.cpp:
284         (WebCore::dumpHistoryItem):
285         (WebCore::DumpRenderTree::dumpBackForwardList):
286
287 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
288
289         Reviewed by Adam Roben.
290
291         Implement DRT functionality for Qt introduced in
292         r28690 and r28705.
293
294         - Implemented pathToLocalResource which exposes the functionality of
295         converting a given unix path to the correct location on Windows.
296         - Implemented a way to remove machine-dependent information from paths
297         in layout test results.
298
299         * DumpRenderTree/qt/DumpRenderTree.cpp:
300         (WebCore::urlSuitableForTestResult):
301         (WebCore::WebPage::javaScriptConsoleMessage):
302         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
303         (LayoutTestController::pathToLocalResource):
304         * DumpRenderTree/qt/LayoutTestControllerQt.h:
305
306 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
307
308         Adding myself to the committers list.
309
310         * Scripts/modules/committers.py:
311
312 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
313
314         Adding myself to the committers list.
315
316         * Scripts/modules/committers.py:
317
318 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
319
320         Reviewed by Jan Alonzo.
321
322         [GTK] API to start inspector for a WebView
323         https://bugs.webkit.org/show_bug.cgi?id=22551
324
325         Use the new inspector API to implement the LayoutTestController
326         interfaces used to test the inspector.
327
328         * DumpRenderTree/gtk/DumpRenderTree.cpp:
329         (webInspectorInspectWebView):
330         (createWebView):
331         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
332         (LayoutTestController::showWebInspector):
333         (LayoutTestController::closeWebInspector):
334         (LayoutTestController::evaluateInWebInspector):
335
336 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
337
338         Reviewed by Eric Seidel.
339
340         [Qt] WebFrame::counterValueForElementById must not be exposed
341         https://bugs.webkit.org/show_bug.cgi?id=30882
342
343         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
344         (LayoutTestController::counterValueForElementById):
345
346 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
347
348         Rubberstamped by Oliver Hunt.
349
350         Fix the warning:
351
352         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
353         declared with attribute warn_unused_result".
354
355         by actually checking the result. In the case it is null, an
356         error has occoured, so treat it as the other fatal errors.
357
358         * DumpRenderTree/qt/DumpRenderTree.cpp:
359         (WebCore::DumpRenderTree::initializeFonts):
360
361 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
362
363         Reviewed by Darin Adler.
364
365         Provide a way to get counter values with layoutTestContoller
366         https://bugs.webkit.org/show_bug.cgi?id=30555
367
368         Define layoutTestContoller.counterValueForElementById.
369
370         * DumpRenderTree/LayoutTestController.cpp:
371         (counterValueForElementByIdCallback):
372         (LayoutTestController::staticFunctions):
373         * DumpRenderTree/LayoutTestController.h:
374         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
375         (LayoutTestController::counterValueForElementById):
376
377 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
378
379         Rubberstamped by Oliver Hunt.
380
381         Change two methods to be internal for DRT use only.
382
383         Part of [Qt] Review all new API in Qt 4.6
384         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
385
386         * DumpRenderTree/qt/DumpRenderTree.cpp:
387         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
388         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
389         (LayoutTestController::whiteListAccessFromOrigin):
390
391 2009-10-27  Eric Seidel  <eric@webkit.org>
392
393         Reviewed by Adam Barth.
394
395         REGRESSION: svn-apply exits(1) when applying a patch with a file add
396         https://bugs.webkit.org/show_bug.cgi?id=30826
397
398         * Scripts/svn-apply:
399          - Add () around all system() calls.
400          - Use the correct system() == 0 or die instead of system() or die
401          - Add descriptive messages to all die statements.
402
403 2009-10-27  Steve Block  <steveblock@google.com>
404
405         Reviewed by NOBODY.
406
407         Adds steveblock@google.com to list of committers.
408
409         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
410
411 2009-10-27  Eric Seidel  <eric@webkit.org>
412
413         Reviewed by Adam Barth.
414
415         svn-apply can exit(0) even on patch failure
416         https://bugs.webkit.org/show_bug.cgi?id=29622
417
418         * Scripts/svn-apply:
419          - Add a bunch of "or die" statements, hopefully catching all
420            possible cases where failure could still exit(0).
421
422 2009-10-27  Eric Seidel  <eric@webkit.org>
423
424         Reviewed by Adam Barth.
425
426         svn-* scripts should share code through VCSUtils.pm
427         https://bugs.webkit.org/show_bug.cgi?id=30791
428
429         Just moving code into a shared location.
430
431         * Scripts/VCSUtils.pm:
432         * Scripts/prepare-ChangeLog:
433         * Scripts/resolve-ChangeLogs:
434         * Scripts/svn-apply:
435         * Scripts/svn-create-patch:
436         * Scripts/svn-unapply:
437         * Scripts/update-webkit:
438
439 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
440
441         Suppress a huge number of MSVC warnings when building wxWebKit.
442
443         * wx/build/settings.py:
444
445 2009-10-26  Eric Seidel  <eric@webkit.org>
446
447         No review, just adding Mike Belshe to the committers list.
448
449         * Scripts/modules/committers.py:
450
451 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
452
453         Reviewed by Darin Adler.
454
455         Make .rc files compile on Windows without depending on MFC headers
456         https://bugs.webkit.org/show_bug.cgi?id=30750
457
458         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
459         windows.h instead of afxres.h because it exists even when MFC is not 
460         installed, and is all that's needed here.
461
462         * FindSafari/FindSafari.rc: Ditto
463
464 2009-10-24  Eric Seidel  <eric@webkit.org>
465
466         Reviewed by Adam Barth.
467
468         bugzilla-tool post-diff should know how to mark commit-queue=?
469         https://bugs.webkit.org/show_bug.cgi?id=29202
470
471         * Scripts/bugzilla-tool:
472          - Add --commit-queue option to post-diff, post-commits and create-bug.
473         * Scripts/modules/bugzilla.py:
474          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
475          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
476
477 2009-10-23  Eric Seidel  <eric@webkit.org>
478
479         Reviewed by Adam Barth.
480
481         bugzilla-tool commit-queue does not notice modifications to committers.py
482         https://bugs.webkit.org/show_bug.cgi?id=30084
483
484         * Scripts/bugzilla-tool:
485          - Make commit-queue re-exec itself instead of using while(1).
486          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
487          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
488
489 2009-10-22  Eric Seidel  <eric@webkit.org>
490
491         Reviewed by Adam Barth.
492
493         commit-queue will get stuck on patches if land-patches terminates unexpectedly
494         https://bugs.webkit.org/show_bug.cgi?id=30634
495
496         * Scripts/bugzilla-tool:
497          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
498          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
499
500 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
501
502         Reviewed by Eric Seidel.
503
504         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
505
506         https://bugs.webkit.org/show_bug.cgi?id=30763
507
508         * pywebsocket/mod_pywebsocket/__init__.py:
509         * pywebsocket/mod_pywebsocket/dispatch.py:
510         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
511         * pywebsocket/mod_pywebsocket/standalone.py:
512         * pywebsocket/setup.py:
513         * pywebsocket/test/test_dispatch.py:
514
515 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
516
517         Reviewed by David Levin.
518
519         REGRESSION: 2 failures in run-webkit-unittests
520         https://bugs.webkit.org/show_bug.cgi?id=30645
521
522         * Scripts/modules/cpp_style_unittest.py:
523         Fixed a few test scenarios which apparently lost some spaces from 
524         text literals.
525
526 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
527
528         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
529
530         * Scripts/webkitdirs.pm:
531
532 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
533
534         Reviewed by Darin Adler.
535
536         Unification of using null device in perl scripts.
537         https://bugs.webkit.org/show_bug.cgi?id=30572
538
539         * Scripts/VCSUtils.pm:
540         * Scripts/bisect-builds:
541         * Scripts/resolve-ChangeLogs:
542         * Scripts/run-iexploder-tests:
543         * Scripts/run-jsc:
544         * Scripts/run-mangleme-tests:
545         * Scripts/run-webkit-tests:
546         * Scripts/webkitdirs.pm:
547         Using File::Spec->devnull() instead of hard coded /dev/null.
548
549 2009-10-26  Eric Seidel  <eric@webkit.org>
550
551         Reviewed by Holger Freyther.
552
553         Reviewers are missing from committers.py
554         https://bugs.webkit.org/show_bug.cgi?id=30733
555
556         * Scripts/modules/committers.py:
557
558 2009-10-23  Eric Seidel  <eric@webkit.org>
559
560         No review, only adding Alice to the list of reviewers.
561
562         * Scripts/modules/committers.py:
563
564 2009-10-23  Eric Seidel  <eric@webkit.org>
565
566         Reviewed by Eric Carlson.
567
568         fast/media/mq-transform-02.html failed on Leopard Commit Bot
569         https://bugs.webkit.org/show_bug.cgi?id=30700
570
571         * DumpRenderTree/mac/DumpRenderTree.mm:
572         (resetDefaultsToConsistentValues): Update QuickTime version check.
573
574 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
575
576         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get 
577         character measurement APIs that are private on Tiger.
578
579         * wx/build/settings.py:
580
581 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
582
583         Reviewed by NOBODY (build fix).
584         Build fix following bug #30696.
585
586         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
587         (LayoutTestController::evaluateScriptInIsolatedWorld):
588
589 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
590
591         Reviewed by Sam Weinig & Geoff Garen.
592
593         https://bugs.webkit.org/show_bug.cgi?id=30696
594         Enable isolated-worlds tests on mac.
595
596         Add private interface for DRT to invoke execution in a given world.
597
598         * DumpRenderTree/LayoutTestController.cpp:
599         (evaluateScriptInIsolatedWorldCallback):
600         (LayoutTestController::staticFunctions):
601         * DumpRenderTree/LayoutTestController.h:
602         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
603         (LayoutTestController::evaluateScriptInIsolatedWorld):
604         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
605         (LayoutTestController::evaluateScriptInIsolatedWorld):
606
607 2009-10-21  Eric Seidel  <eric@webkit.org>
608
609         Reviewed by Adam Barth.
610
611         bugzilla-tool's "patch failed to download an apply" error should give more information
612         https://bugs.webkit.org/show_bug.cgi?id=30632
613
614         * Scripts/modules/scm.py:
615          - Use the common run_command method instead of custom POpen code.
616          - Make run_command know how to take pipes as input.
617         * Scripts/modules/scm_unittest.py:
618          - Add new tests to cover change.
619          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
620
621 2009-10-21  Kent Tamura  <tkent@chromium.org>
622
623         Unreviewed.  Adding myself to the committers list.
624
625         * Scripts/modules/committers.py:
626
627 2009-10-21  Robin Dunn  <robin@alldunn.com>
628
629         Reviewed by Kevin Ollivier.
630
631         Update the Windows installer builder to work with Vista / Win 7 and with git.
632         
633         https://bugs.webkit.org/show_bug.cgi?id=30649
634
635         * wx/build/build_utils.py:
636         * wx/packaging/build-mac-installer.py:
637         * wx/packaging/build-win-installer.py:
638         * wx/packaging/wxWebKitInstaller.iss.in:
639
640 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
641
642         Reviewed by Gustavo Noronha.
643
644         [GTK] Added conditional code to avoid using
645         gdk_window_get_root_coords if we do not have a gtk+ release newer
646         than 2.17.3.
647         https://bugs.webkit.org/show_bug.cgi?id=30636
648
649         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
650
651 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
652
653         Reviewed by Eric Seidel.
654
655         [Qt] Added dummy implementation for keepWebHistory()
656         https://bugs.webkit.org/show_bug.cgi?id=30592
657
658         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
659         (LayoutTestController::keepWebHistory):
660         * DumpRenderTree/qt/LayoutTestControllerQt.h:
661
662 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
663
664         Reviewed by Xan Lopez.
665
666         [GTK] Fixed the double click condition, it is not double click if
667         we move in just in one direction.
668         https://bugs.webkit.org/show_bug.cgi?id=30636
669
670         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
671
672 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
673
674         Reviewed by Xan Lopez.
675
676         [GTK] Initialize the events completly before emitting them.
677         https://bugs.webkit.org/show_bug.cgi?id=30633
678
679         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
680
681 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
682
683         wx build fix. Fix for when linking using --as-needed with gcc.
684
685         * wx/browser/wscript:
686
687 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
688
689         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
690         to support all the features used by CURL backend.
691         
692         * wx/build/settings.py:
693         * wx/install-unix-extras:
694
695 2009-10-20  Anton Muhin  <antonm@chromium.org>
696
697         Reviewed by Adam Barth.
698
699         Add {ager,antonm,yurys}@chromium.org into committers.py
700         https://bugs.webkit.org/show_bug.cgi?id=30560
701
702         * Scripts/modules/committers.py:
703
704 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
705
706         Reviewed by Tor Arne Vestbø.
707
708         Make the Netscape Test plugin available to the Qt launcher.
709
710         * Scripts/run-launcher:
711
712 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
713
714         Reviewed by David Levin.
715
716         Removed WebSocket runtime settings.
717         https://bugs.webkit.org/show_bug.cgi?id=29896
718
719         WebSocket runtime configuration is supported by chromium/v8 only.
720
721         * DumpRenderTree/mac/DumpRenderTree.mm:
722         (resetDefaultsToConsistentValues):
723         * DumpRenderTree/win/DumpRenderTree.cpp:
724         (resetDefaultsToConsistentValues):
725
726 2009-10-19  Nate Chapin  <japhet@chromium.org>
727
728         Reviewed by Adam Barth.
729
730         Add testFail() to test plugin so we can test our handling of a
731         plugin invoke call returning false.
732
733         https://bugs.webkit.org/show_bug.cgi?id=30239
734
735         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
736         (pluginInvoke):
737         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
738
739 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
740
741         Reviewed by Gustavo Noronha.
742
743         Enable DOM pasting when running layout tests.
744
745         * DumpRenderTree/gtk/DumpRenderTree.cpp:
746         (resetDefaultsToConsistentValues):
747
748 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
749
750         Reviewed by Simon Hausmann.
751
752         Use the setPreferredContentsSize method instead
753         of setFixedContentsSize, as the method has been renamed.
754
755         * DumpRenderTree/qt/DumpRenderTree.cpp:
756         (WebCore::DumpRenderTree::open):
757         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
758         (LayoutTestController::setFixedContentsSize):
759
760 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
761
762         Reviewed by Dan Bernstein.
763
764         https://bugs.webkit.org/show_bug.cgi?id=30456
765         Fixes for new Debug_All Windows build configuration.
766
767         * DumpRenderTree/win/DumpRenderTree.cpp:
768         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
769         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
770
771 2009-10-16  Eric Seidel  <eric@webkit.org>
772
773         Reviewed by Adam Barth.
774
775         commit-queue status bot should list which buildbot is blocking the queue
776         https://bugs.webkit.org/show_bug.cgi?id=30452
777
778         Add new methods and testing.
779
780         * Scripts/bugzilla-tool:
781         * Scripts/modules/buildbot.py:
782         * Scripts/modules/buildbot_unittest.py:
783
784 2009-10-16  Eric Seidel  <eric@webkit.org>
785
786         Reviewed by Adam Barth.
787
788         run-webkit-tests fails when CWD is not inside a WebKit checkout
789         https://bugs.webkit.org/show_bug.cgi?id=30451
790
791         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
792         * Scripts/modules/scm_unittest.py:
793           - Remove use of original_path (we don't need to restore the CWD).
794           - Don't use '.' to find the webkit checkout, use __file__ instead.
795
796 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
797
798         Reviewed by Adam Roben.
799
800         Add a Debug_All configuration to build entire stack as debug.
801         Change Debug_Internal to:
802         - stop using _debug suffix for all WebKit/Safari binaries
803         - not use _debug as a DLL naming suffix
804         - use non-debug C runtime lib.
805
806         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
807         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
808         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
809         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
810         Add missing debug.vsprops inherited property sheet.
811         Add Debug_All configuration.
812         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
813         * WinLauncher/WinLauncher.vcproj:
814         Removed extraneous definitions inherited from vsprops.
815         Add Debug_All configuration.
816
817 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
818
819         Reviewed by David Levin.
820
821         check-webkit-style is wrong about indent checking in namespaces
822         in header files and a few other things
823         https://bugs.webkit.org/show_bug.cgi?id=30362
824
825         The few other things include:
826         + check-webkit-style does not require spaces around the equal sign
827           inside 'if' statements and around binary operators that take 
828           numeric literals.
829         + check-webkit-style reports false errors for the / operator
830           when part of a filename in the #include directive.
831
832         * Scripts/modules/cpp_style.py:
833         Improved indentation checking and space checking around
834         binary operators. While the checks are still not perfect,
835         they are clearly better than before.
836         * Scripts/modules/cpp_style_unittest.py:
837         Added test cases for the newly supported checks and modified old
838         test cases to match the new guidelines
839
840 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
841
842         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
843
844         * wx/build/settings.py:
845
846 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
847
848         Reviewed by David Levin.
849
850         Add mod_pywebsocket to test Web Sockets.
851         http://code.google.com/p/pywebsocket/
852         https://bugs.webkit.org/show_bug.cgi?id=27490
853
854         * pywebsocket/COPYING: Added.
855         * pywebsocket/MANIFEST.in: Added.
856         * pywebsocket/README: Added.
857         * pywebsocket/example/echo_client.py: Added.
858         * pywebsocket/example/echo_wsh.py: Added.
859         * pywebsocket/mod_pywebsocket/__init__.py: Added.
860         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
861         * pywebsocket/mod_pywebsocket/handshake.py: Added.
862         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
863         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
864         * pywebsocket/mod_pywebsocket/standalone.py: Added.
865         * pywebsocket/mod_pywebsocket/util.py: Added.
866         * pywebsocket/setup.py: Added.
867         * pywebsocket/test/config.py: Added.
868         * pywebsocket/test/mock.py: Added.
869         * pywebsocket/test/run_all.py: Added.
870         * pywebsocket/test/test_dispatch.py: Added.
871         * pywebsocket/test/test_handshake.py: Added.
872         * pywebsocket/test/test_mock.py: Added.
873         * pywebsocket/test/test_msgutil.py: Added.
874         * pywebsocket/test/test_util.py: Added.
875         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
876         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
877         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
878         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
879         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
880         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
881         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
882         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
883
884 2009-10-15  James Robinson  <jamesr@google.com>
885
886         Reviewed by David Levin.
887
888         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
889
890         https://bugs.webkit.org/show_bug.cgi?id=30426
891
892         * Scripts/modules/cpp_style.py:
893         * Scripts/modules/cpp_style_unittest.py:
894
895 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
896
897         Reviewed by Adam Roben.
898
899         Fixes <http://webkit.org/b/30411>.
900         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
901         
902         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
903         building Chromium.
904
905         * Scripts/pdevenv:
906
907 2009-10-15  Robin Dunn  <robin@alldunn.com>
908
909         Reviewed by Kevin Ollivier.
910
911         Add Mac package building scripts for wx.
912         
913         https://bugs.webkit.org/show_bug.cgi?id=30405
914
915         * wx/build/build_utils.py:
916         * wx/build/settings.py:
917         * wx/packaging/build-mac-installer.py: Added.
918
919 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
920
921         Reviewed by Gustavo Noronha.
922
923         Enable Web Sockets support when running layout tests.
924
925         * DumpRenderTree/gtk/DumpRenderTree.cpp:
926         (resetDefaultsToConsistentValues):
927
928 2009-10-15  Xan Lopez  <xlopez@igalia.com>
929
930         Reviewed by Gustavo Noronha.
931
932         Need to initialize event.button.button, since in most cases a
933         button number is not passed as an argument.
934
935         * DumpRenderTree/gtk/EventSender.cpp:
936         (mouseDownCallback):
937         (mouseUpCallback):
938
939 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
940
941         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
942         the OS if none was explicitly set.
943
944         * wx/build/settings.py:
945
946 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
947
948         Reviewed by Timothy Hatcher.
949
950         Web Inspector: enable developers extras within inspector layout tests.
951
952         https://bugs.webkit.org/show_bug.cgi?id=30014
953
954         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
955         (LayoutTestController::showWebInspector):
956         (LayoutTestController::closeWebInspector):
957         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
958         (LayoutTestController::showWebInspector):
959         (LayoutTestController::closeWebInspector):
960
961 2009-10-14  José Millán Soto  <jmillan@igalia.com>
962
963         Reviewed by Jan Alonzo.
964
965         GtkLauncher is using a deprecated signal
966         https://bugs.webkit.org/show_bug.cgi?id=30364
967
968         Modified GtkLauncher to use notify::title signal instead of
969         deprecated title-changed signal
970
971         * GtkLauncher/main.c:
972         (notify_title_cb):
973         (create_browser):
974
975 2009-10-14  Brady Eidson  <beidson@apple.com>
976
977         Reviewed by Sam Weinig.
978
979         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
980         1 - Disables WebHistory
981         2 - Doesn't make sense in that context anyway.
982
983         * DumpRenderTree/win/DumpRenderTree.cpp:
984         (createWebViewAndOffscreenWindow):
985
986 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
987
988         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
989         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
990
991         * wx/build/settings.py:
992         * wx/install-unix-extras:
993
994 2009-10-14  Brady Eidson  <beidson@apple.com>
995
996         Reviewed by Sam Weinig.
997
998         WebKit Win API should provide a delegate interface for global history.
999         https://bugs.webkit.org/show_bug.cgi?id=29905
1000
1001         * DumpRenderTree/LayoutTestController.cpp:
1002         (LayoutTestController::LayoutTestController):
1003         * DumpRenderTree/LayoutTestController.h:
1004         (LayoutTestController::dumpHistoryDelegateCallbacks):
1005         (LayoutTestController::setDumpHistoryDelegateCallbacks):
1006                 
1007         * DumpRenderTree/win/DumpRenderTree.cpp:
1008         (shouldLogHistoryDelegates):
1009         (runTest):
1010         (createWebViewAndOffscreenWindow):
1011         (main):
1012         * DumpRenderTree/win/DumpRenderTree.vcproj:
1013         
1014         Add the IWebHistoryDelegate to DRT Windows:
1015         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
1016         (wstringFromBSTR):
1017         (HistoryDelegate::HistoryDelegate):
1018         (HistoryDelegate::~HistoryDelegate):
1019         (HistoryDelegate::QueryInterface):
1020         (HistoryDelegate::AddRef):
1021         (HistoryDelegate::Release):
1022         (HistoryDelegate::didNavigateWithNavigationData):
1023         (HistoryDelegate::didPerformClientRedirectFromURL):
1024         (HistoryDelegate::didPerformServerRedirectFromURL):
1025         (HistoryDelegate::updateHistoryTitle):
1026         (HistoryDelegate::populateVisitedLinksForWebView):
1027         * DumpRenderTree/win/HistoryDelegate.h: Added.
1028
1029         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1030         (LayoutTestController::removeAllVisitedLinks):
1031
1032 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
1033
1034         Reviewed by Simon Hausmann.
1035
1036         [Qt] Implement support for setPOSIXLocale on Qt.
1037         https://bugs.webkit.org/show_bug.cgi?id=30268 
1038  
1039         * DumpRenderTree/qt/DumpRenderTree.cpp:
1040         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1041         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1042         (LayoutTestController::setPOSIXLocale):
1043         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1044
1045 2009-10-13  Stephanie Lewis  <slewis@apple.com>
1046
1047         Unreviewed, adding myself to reviewers list.
1048
1049         * Scripts/modules/committers.py:
1050
1051 2009-10-13  Stephanie Lewis  <slewis@apple.com>
1052
1053         Reviewed by Mark Rowe.
1054
1055         Fix null assignment so root tests work again.
1056
1057         * Scripts/webkitdirs.pm:
1058
1059 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1060
1061         Reviewed by Simon Hausmann.
1062
1063         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
1064         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
1065         This is done in preparation of implementing missing features in DRT.
1066         No functionality changes made yet.
1067
1068         * DumpRenderTree/qt/DumpRenderTree.cpp:
1069         * DumpRenderTree/qt/DumpRenderTree.pro:
1070         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
1071         (EventSender::EventSender):
1072         (EventSender::mouseDown):
1073         (EventSender::mouseUp):
1074         (EventSender::mouseMoveTo):
1075         (EventSender::leapForward):
1076         (EventSender::keyDown):
1077         (EventSender::contextClick):
1078         (EventSender::scheduleAsynchronousClick):
1079         (EventSender::frameUnderMouse):
1080         * DumpRenderTree/qt/EventSenderQt.h: Added.
1081         (EventSender::clearKillRing):
1082         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
1083         (LayoutTestController::LayoutTestController):
1084         (LayoutTestController::reset):
1085         (LayoutTestController::processWork):
1086         (LayoutTestController::maybeDump):
1087         (LayoutTestController::waitUntilDone):
1088         (LayoutTestController::notifyDone):
1089         (LayoutTestController::windowCount):
1090         (LayoutTestController::clearBackForwardList):
1091         (LayoutTestController::dumpEditingCallbacks):
1092         (LayoutTestController::dumpResourceLoadCallbacks):
1093         (LayoutTestController::queueBackNavigation):
1094         (LayoutTestController::queueForwardNavigation):
1095         (LayoutTestController::queueLoad):
1096         (LayoutTestController::queueReload):
1097         (LayoutTestController::queueScript):
1098         (LayoutTestController::provisionalLoad):
1099         (LayoutTestController::timerEvent):
1100         (LayoutTestController::encodeHostName):
1101         (LayoutTestController::decodeHostName):
1102         (LayoutTestController::setJavaScriptProfilingEnabled):
1103         (LayoutTestController::setFixedContentsSize):
1104         (LayoutTestController::setPrivateBrowsingEnabled):
1105         (LayoutTestController::setPopupBlockingEnabled):
1106         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
1107         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
1108         (LayoutTestController::numberOfActiveAnimations):
1109         (LayoutTestController::disableImageLoading):
1110         (LayoutTestController::dispatchPendingLoadRequests):
1111         (LayoutTestController::setDatabaseQuota):
1112         (LayoutTestController::clearAllDatabases):
1113         (LayoutTestController::whiteListAccessFromOrigin):
1114         (LayoutTestController::waitForPolicyDelegate):
1115         (LayoutTestController::overridePreference):
1116         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
1117         (LayoutTestController::isLoading):
1118         (LayoutTestController::setLoading):
1119         (LayoutTestController::shouldDumpAsText):
1120         (LayoutTestController::shouldDumpBackForwardList):
1121         (LayoutTestController::shouldDumpChildrenAsText):
1122         (LayoutTestController::shouldDumpDatabaseCallbacks):
1123         (LayoutTestController::shouldDumpStatusCallbacks):
1124         (LayoutTestController::shouldWaitUntilDone):
1125         (LayoutTestController::canOpenWindows):
1126         (LayoutTestController::shouldDumpTitleChanges):
1127         (LayoutTestController::waitForPolicy):
1128         (LayoutTestController::dumpAsText):
1129         (LayoutTestController::dumpChildFramesAsText):
1130         (LayoutTestController::dumpDatabaseCallbacks):
1131         (LayoutTestController::dumpStatusCallbacks):
1132         (LayoutTestController::setCanOpenWindows):
1133         (LayoutTestController::dumpBackForwardList):
1134         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
1135         (LayoutTestController::display):
1136         (LayoutTestController::dumpTitleChanges):
1137         (LayoutTestController::dumpSelectionRect):
1138         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
1139         (TextInputController::TextInputController):
1140         (TextInputController::doCommand):
1141         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
1142         * DumpRenderTree/qt/WorkQueue.cpp:
1143         * DumpRenderTree/qt/WorkQueue.h:
1144         * DumpRenderTree/qt/WorkQueueItem.h:
1145         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
1146         (findFrameNamed):
1147         (LoadItem::invoke):
1148         (ReloadItem::invoke):
1149         (ScriptItem::invoke):
1150         (BackForwardItem::invoke):
1151         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
1152         * DumpRenderTree/qt/jsobjects.h:
1153
1154 2009-10-13  Dmitry Titov  <dimich@chromium.org>
1155
1156         Not reviewed, adding myself to the list of reviewers.
1157
1158         * Scripts/modules/committers.py:
1159
1160 2009-10-13  Anders Carlsson  <andersca@apple.com>
1161
1162         Reviewed by Sam Weinig.
1163
1164         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
1165
1166         Make the private browsing mode testable by the test plug-in.
1167         
1168         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1169         (pluginGetProperty):
1170         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
1171         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1172         (NPP_New):
1173         (NPP_SetValue):
1174
1175 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
1176
1177         No review, just adding self to the list of reviewers.
1178
1179         * Scripts/modules/committers.py:
1180
1181 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
1182
1183         Reviewed by Adam Roben.
1184
1185         Web Inspector: Use proper web view in inspector layout
1186         tests for windows.
1187
1188         https://bugs.webkit.org/show_bug.cgi?id=30298
1189
1190         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1191         (LayoutTestController::showWebInspector):
1192         (LayoutTestController::closeWebInspector):
1193         (LayoutTestController::evaluateInWebInspector):
1194
1195 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
1196
1197         Reviewed by Sam Weinig.
1198
1199         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
1200         https://bugs.webkit.org/show_bug.cgi?id=29841
1201
1202         * DumpRenderTree/mac/DumpRenderTree.mm:
1203         (resetDefaultsToConsistentValues):
1204         * DumpRenderTree/win/DumpRenderTree.cpp:
1205         (resetDefaultsToConsistentValues):
1206
1207 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
1208
1209         Reviewed by Dimitri Glazkov.
1210
1211         Chromium Port - Windows
1212         https://bugs.webkit.org/show_bug.cgi?id=29969
1213
1214         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
1215         * Scripts/webkitdirs.pm:
1216
1217 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
1218
1219         Reviewed by Darin Adler.
1220
1221         jsc scripts cleanup and Qt/GTK fix
1222         https://bugs.webkit.org/show_bug.cgi?id=30288
1223
1224         Duplicated jscPath() moved to webkitdirs.pm.
1225         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
1226         Configuration added (release/debug) to path for Qt-port on Windows.
1227
1228         * Scripts/run-javascriptcore-tests:
1229         * Scripts/run-jsc:
1230         * Scripts/run-sunspider:
1231         * Scripts/sunspider-compare-results:
1232         * Scripts/webkitdirs.pm:
1233
1234 2009-10-11  Adam Barth  <abarth@webkit.org>
1235
1236         Unreviewed.  Add Collin to committers.py.
1237
1238         * Scripts/modules/committers.py:
1239
1240 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
1241
1242         wx build fix, add bindings to source/include dirs now that there are sources there.
1243
1244         * wx/build/settings.py:
1245
1246 2009-10-09  Mark Rowe  <mrowe@apple.com>
1247
1248         Reviewed by Brady Eidson.
1249
1250         Enable plug-in halting in DumpRenderTree.
1251
1252         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
1253         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
1254
1255         * DumpRenderTree/mac/DumpRenderTree.mm:
1256         (resetDefaultsToConsistentValues):
1257         * DumpRenderTree/mac/UIDelegate.mm:
1258         (-[UIDelegate webView:shouldHaltPlugin:]):
1259
1260 2009-10-08  Brady Eidson  <beidson@apple.com>
1261
1262         Reviewed by Dan Bernstein.
1263
1264         Ask the History Delegate to populate the visited links hash.
1265         <rdar://problem/7285293> and https://webkit.org/b/29904
1266
1267         Add the ability for LayoutTestController to clear all visited links.
1268         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
1269
1270         * DumpRenderTree/LayoutTestController.cpp:
1271         (LayoutTestController::LayoutTestController):
1272         (removeAllVisitedLinksCallback):
1273         (LayoutTestController::staticFunctions):
1274         * DumpRenderTree/LayoutTestController.h:
1275         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1276         (LayoutTestController::removeAllVisitedLinks):
1277
1278         * DumpRenderTree/mac/HistoryDelegate.mm:
1279         (-[HistoryDelegate populateVisitedLinksForWebView:]):
1280
1281         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1282         (LayoutTestController::removeAllVisitedLinks):
1283         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1284         (LayoutTestController::removeAllVisitedLinks):
1285         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1286         (LayoutTestController::removeAllVisitedLinks):
1287
1288
1289 2009-10-08  Daniel Bates  <dbates@webkit.org>
1290
1291         Reviewed by Adam Roben.
1292
1293         https://bugs.webkit.org/show_bug.cgi?id=30175
1294         
1295         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
1296         the OLE drag-and-drop return value like the function it emulates. Currently, 
1297         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine 
1298         whether the drag-and-drop operation was successful or was cancelled.
1299         
1300         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop 
1301         return value according to whether the drop operation was successful or not.
1302
1303         * DumpRenderTree/win/EventSender.cpp:
1304         (doMouseUp): Added parameter oleDragAndDropReturnValue.
1305         (replaySavedEvents): Ditto.
1306         * DumpRenderTree/win/EventSender.h:
1307         * DumpRenderTree/win/UIDelegate.cpp:
1308         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
1309
1310 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
1311
1312         Reviewed by Xan Lopez.
1313
1314         [GTK] Added support for a parameter setting the button that was
1315         pressed in the mouseDown function.
1316         https://bugs.webkit.org/show_bug.cgi?id=30220
1317
1318         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
1319
1320 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
1321
1322         Reviewed by Xan Lopez.
1323
1324         [GTK] Added a line to the bottom of the expected result to match
1325         the output of the test.
1326         https://bugs.webkit.org/show_bug.cgi?id=30220
1327
1328         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
1329         expected.txt:
1330
1331 2009-10-08  Adam Roben  <aroben@apple.com>
1332
1333         Use QueryInterface to get IWebInspectorPrivate
1334
1335         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
1336         accessed in a more standard way
1337
1338         Reviewed by John Sullivan and Tim Hatcher.
1339
1340         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1341         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
1342         by calling IWebViewPrivate::inspector, then use QueryInterface to get
1343         to the IWebInspectorPrivate interface.
1344
1345 2009-10-07  Adam Roben  <aroben@apple.com>
1346
1347         Implement DRT support for origin whitelisting
1348
1349         Fixes <http://webkit.org/b/30185>.
1350
1351         Reviewed by Eric Seidel.
1352
1353         * DumpRenderTree/win/DumpRenderTree.cpp:
1354         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
1355         whitelist, to match Mac DRT.
1356         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1357         (LayoutTestController::whiteListAccessFromOrigin): Call through to
1358         IWebViewPrivate::whiteListAccessFromOrigin.
1359
1360 2009-10-07  Brady Eidson  <beidson@apple.com>
1361
1362         Reviewed by Darin Adler.
1363
1364         Send title changes to the global history delegate.
1365         <rdar://problem/7285293> and https://webkit.org/b/29904
1366
1367         * DumpRenderTree/mac/HistoryDelegate.mm:
1368         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
1369
1370 2009-10-07  Adam Barth  <abarth@webkit.org>
1371
1372         Unreviewed.  Remove some folks from committers.py who were listed on
1373         the WebKit Team wiki page but who weren't actually listed as commit+.
1374         At some point, we should coorelate this list with the committers
1375         mailing list.
1376
1377         * Scripts/modules/committers.py:
1378
1379 2009-10-07  Adam Barth  <abarth@webkit.org>
1380
1381         Unreviewed.  Import a bunch of committers from the WebKit Team page on
1382         the wiki into committers.py.
1383
1384         * Scripts/modules/committers.py:
1385
1386 2009-10-07  Adam Barth  <abarth@webkit.org>
1387
1388         Unreviewed.  Added Aaron Boodman to committers.py.
1389
1390         * Scripts/modules/committers.py:
1391
1392 2009-10-07  Evan Martin  <evan@chromium.org>
1393
1394         Reviewed by Darin Adler.
1395
1396         Add API to LayoutTestController for re/setting the system locale.
1397         https://bugs.webkit.org/show_bug.cgi?id=18994
1398
1399         * DumpRenderTree/LayoutTestController.cpp:
1400         (setLocaleCallback):
1401         (LayoutTestController::staticFunctions):
1402         (LayoutTestController::setLocale):
1403         * DumpRenderTree/LayoutTestController.h:
1404
1405 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
1406
1407         Reviewed by Jan Alonzo.
1408
1409         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
1410         https://bugs.webkit.org/show_bug.cgi?id=29689
1411
1412         Build fix by adding -lfontconfig for DumpRenderTree.
1413
1414         * GNUmakefile.am:
1415
1416 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
1417
1418         Reviewed by Simon Hausmann.
1419
1420         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
1421
1422         * Scripts/run-webkit-tests:
1423
1424 2009-10-07  Xan Lopez  <xlopez@igalia.com>
1425
1426         Reviewed by Gustavo Noronha.
1427
1428         "delete" in EventSender is the backspace key, not the delete one.
1429
1430         * DumpRenderTree/gtk/EventSender.cpp:
1431         (keyDownCallback):
1432
1433 2009-10-07  Xan Lopez  <xlopez@igalia.com>
1434
1435         Reviewed by Gustavo Noronha.
1436
1437         getChildrenWithRange expects as last parameter the end index, not
1438         the length of the range. Correct this and clarify the variable
1439         names to reflect how the code works.
1440
1441         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1442         (AccessibilityUIElement::getChildrenWithRange):
1443         (AccessibilityUIElement::getChildAtIndex):
1444
1445 2009-10-06  Mark Rowe  <mrowe@apple.com>
1446
1447         Reviewed by Simon Fraser.
1448
1449         <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
1450
1451         * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
1452         the fact we have already changed the working directory to the top of the open source tree.
1453
1454 2009-10-06  Julie Parent  <jparent@chromium.org>
1455
1456         Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
1457         rather than my committer email.
1458
1459         * Scripts/modules/committers.py:
1460
1461 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
1462
1463         Reviewed by Eric Seidel.
1464
1465         [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
1466
1467         r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
1468         it after each layout test as it should do, making the DRT dump additional output
1469         for all of the subsequent layout tests.
1470
1471         * DumpRenderTree/qt/jsobjects.cpp:
1472         (LayoutTestController::reset):
1473
1474 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
1475
1476         Reviewed by Simon Hausmann.
1477
1478         [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
1479         fast/dom/assign-to-window-status.html test, which is passing as a result.
1480
1481         https://bugs.webkit.org/show_bug.cgi?id=30127
1482
1483         * DumpRenderTree/qt/DumpRenderTree.cpp:
1484         (WebCore::DumpRenderTree::DumpRenderTree):
1485         (WebCore::DumpRenderTree::statusBarMessage):
1486         * DumpRenderTree/qt/DumpRenderTree.h:
1487         * DumpRenderTree/qt/jsobjects.h:
1488         (LayoutTestController::shouldDumpStatusCallbacks):
1489         (LayoutTestController::dumpStatusCallbacks):
1490
1491 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
1492
1493         Reviewed by Simon Hausmann.
1494
1495         [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
1496         ignores the argument indicating which mouse button to trigger.
1497         https://bugs.webkit.org/show_bug.cgi?id=30048
1498
1499         This affects the fast/events/mouse-click-events.html layout test.
1500
1501         * DumpRenderTree/qt/jsobjects.cpp:
1502         (EventSender::mouseDown):
1503         (EventSender::mouseUp):
1504         * DumpRenderTree/qt/jsobjects.h:
1505
1506 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
1507
1508         Reviewed by Simon Hausmann.
1509
1510         [Qt] Fix the EventSender::keyDown() implementation
1511         https://bugs.webkit.org/show_bug.cgi?id=30043
1512
1513         It should post both a key press event and a key release event,
1514         just like other ports do.
1515
1516         * DumpRenderTree/qt/jsobjects.cpp:
1517         (EventSender::keyDown):
1518
1519 2009-10-05  Kevin Ollivier  <kevino@theolliviers.com>
1520
1521         wx build fix. Add jpeg to the list of libs to link against.
1522
1523         * wx/build/settings.py:
1524
1525 2009-10-05  Jakub Wieczorek  <faw217@gmail.com>
1526
1527         Reviewed by Simon Hausmann.
1528
1529         [Qt] EventSender::keyDown() cannot send function-key events.
1530         https://bugs.webkit.org/show_bug.cgi?id=30044
1531
1532         This affects the fast/events/keydown-function-keys.html layout test.
1533
1534         * DumpRenderTree/qt/jsobjects.cpp:
1535         (EventSender::keyDown):
1536
1537 2009-10-05  Vadim Zeitlin  <vadim@wxwidgets.org>
1538
1539         Added --wx-compiler-prefix waf option to allow building wxWebKit with
1540         wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".
1541
1542         * wx/build/settings.py:
1543         * wx/build/wxpresets.py:
1544
1545 2009-10-05  Pavel Feldman  <pfeldman@chromium.org>
1546
1547         Reviewed by Timothy Hatcher.
1548
1549         Web Inspector: add testing harness for Web Inspector.
1550
1551         https://bugs.webkit.org/show_bug.cgi?id=30010
1552
1553         * DumpRenderTree/LayoutTestController.cpp:
1554         (showWebInspectorCallback):
1555         (closeWebInspectorCallback):
1556         (evaluateInWebInspectorCallback):
1557         (LayoutTestController::staticFunctions):
1558         * DumpRenderTree/LayoutTestController.h:
1559         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1560         (LayoutTestController::showWebInspector):
1561         (LayoutTestController::closeWebInspector):
1562         (LayoutTestController::evaluateInWebInspector):
1563         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1564         (LayoutTestController::showWebInspector):
1565         (LayoutTestController::closeWebInspector):
1566         (LayoutTestController::evaluateInWebInspector):
1567         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1568         (LayoutTestController::showWebInspector):
1569         (LayoutTestController::closeWebInspector):
1570         (LayoutTestController::evaluateInWebInspector):
1571         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1572         (LayoutTestController::showWebInspector):
1573         (LayoutTestController::closeWebInspector):
1574         (LayoutTestController::evaluateInWebInspector):
1575
1576 2009-10-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1577
1578         Reviewed by Ariyha Hidayat.
1579
1580         Pass arguments to system() as a string instead of array
1581
1582         When passed as an array entries with a space fail to translate
1583         to two arguments to the child process, so instead of manually
1584         splitting all the entries in @buildArgs we pass the whole thing
1585         as a string instead.
1586
1587         * Scripts/webkitdirs.pm:
1588
1589 2009-10-04  Carol Szabo  <carol.szabo@nokia.com>
1590
1591         Reviewed by David Levin.
1592
1593         check-webkit-style misses whitespace errors for operators:
1594         <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||.
1595         https://bugs.webkit.org/show_bug.cgi?id=30021
1596
1597         * Scripts/modules/cpp_style.py:
1598         Added the operators mentioned above to the same list as == and !=.
1599
1600 2009-10-02  Julie Parent  <jparent@chromium.org>
1601
1602         Unreviewed.
1603
1604         Adding myself and Ojan Vafai as committers, because we are committers.
1605
1606         * Scripts/modules/committers.py:
1607
1608 2009-10-02  Brian Weinstein  <bweinstein@apple.com>
1609
1610         Reviewed by Adam Roben.
1611
1612         svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
1613         this will help the patch merging process when TryBots are used.
1614
1615         * Scripts/svn-create-patch:
1616
1617 2009-10-02  Jakub Wieczorek  <faw217@gmail.com>
1618
1619         Reviewed by Simon Hausmann.
1620
1621         [Qt] Implement layoutTestController.overridePreference().
1622         https://bugs.webkit.org/show_bug.cgi?id=29970
1623
1624         * DumpRenderTree/qt/DumpRenderTree.cpp:
1625         (WebCore::WebPage::WebPage):
1626         (WebCore::WebPage::resetSettings):
1627         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1628         * DumpRenderTree/qt/jsobjects.cpp:
1629         (LayoutTestController::reset):
1630         (LayoutTestController::setPrivateBrowsingEnabled):
1631         (LayoutTestController::setPopupBlockingEnabled):
1632         (LayoutTestController::overridePreference):
1633         * DumpRenderTree/qt/jsobjects.h:
1634
1635 2009-10-01  Chris Marrin  <cmarrin@apple.com>
1636
1637         Reviewed by Oliver Hunt.
1638
1639         Turn on ENABLE_3D_CANVAS in TOT
1640         https://bugs.webkit.org/show_bug.cgi?id=29906
1641
1642         * Scripts/build-webkit:
1643
1644 2009-10-01  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1645
1646         Rubberstamped by Simon Hausmann.
1647
1648         Enable HTTP tests for Qt
1649
1650         * Scripts/run-webkit-tests:
1651
1652 2009-10-01  Yaar Schnitman  <yaar@chromium.org>
1653
1654         Reviewed by Dimitri Glazkov.
1655
1656         build-webkit --chromium now also works on cygwin.
1657
1658         https://bugs.webkit.org/show_bug.cgi?id=29973
1659
1660         * Scripts/webkitdirs.pm:
1661
1662 2009-10-01  Zoltan Horvath  <zoltan@webkit.org>
1663
1664         Reviewed by Simon Hausmann.
1665
1666         [Qt] Don't use TCmalloc in DumpRenderTree
1667         https://bugs.webkit.org/show_bug.cgi?id=27029
1668
1669         Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT.
1670
1671         * DumpRenderTree/qt/DumpRenderTree.pro:
1672
1673 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
1674
1675         Reviewed by Simon Hausmann.
1676
1677         [Qt] Implement eventSender.scheduleAsynchronousClick().
1678
1679         https://bugs.webkit.org/show_bug.cgi?id=29931
1680
1681         * DumpRenderTree/qt/jsobjects.cpp:
1682         (EventSender::scheduleAsynchronousClick):
1683         * DumpRenderTree/qt/jsobjects.h:
1684
1685 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
1686
1687         Reviewed by Simon Hausmann.
1688
1689         [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
1690         fast/events/open-window-from-another-frame.html from the Skipped list.
1691
1692         https://bugs.webkit.org/show_bug.cgi?id=29930
1693
1694         * DumpRenderTree/qt/jsobjects.cpp:
1695         (LayoutTestController::setPopupBlockingEnabled):
1696         * DumpRenderTree/qt/jsobjects.h:
1697
1698 2009-09-30  Cameron McCormack  <cam@mcc.id.au>
1699
1700         Unreviewed.
1701
1702         Added myself to the list of committers.
1703
1704         * Scripts/modules/committers.py:
1705
1706 2009-09-30  Eric Seidel  <eric@webkit.org>
1707
1708         No review, just adding Geoff to the list of reviewers.
1709
1710         * Scripts/modules/committers.py:
1711
1712 2009-09-30  Dan Bernstein  <mitz@apple.com>
1713
1714         Reviewed by Sam Weinig.
1715
1716         Added the WebKit Layout Tests fonts that are referenced in
1717         LayoutTests/platform/win/css2.1/resources/Mac-compatible-font-fallback.css
1718
1719         * DumpRenderTree/fonts/WebKit Layout Tests 2.ttf: Added.
1720         * DumpRenderTree/fonts/WebKit Layout Tests.ttf: Added.
1721
1722 2009-09-30  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
1723
1724         Reviewed by David Kilzer.
1725
1726         Make sunspider scripts work on Windows platform.
1727         https://bugs.webkit.org/show_bug.cgi?id=29656
1728
1729         * Scripts/run-sunspider: Perl scripts invoked with same Perl interpreter.
1730         * Scripts/sunspider-compare-results: Perl scripts invoked with same Perl interpreter.
1731         * Scripts/webkitdirs.pm: currentPerlPath() added.
1732
1733 2009-09-29  Brady Eidson  <beidson@apple.com>
1734
1735         Rubberstamped by Dan Bernstein.
1736
1737         Fix license and some sorting in new files.
1738
1739         * DumpRenderTree/mac/HistoryDelegate.h:
1740         * DumpRenderTree/mac/HistoryDelegate.mm:
1741
1742 2009-09-29  Yaar Schnitman  <yaar@chromium.org>
1743
1744         Reviewed by David Kilzer.
1745
1746         Fixed how error codes are handled.
1747         https://bugs.webkit.org/show_bug.cgi?id=29898
1748
1749         * Scripts/update-webkit:
1750         * Scripts/update-webkit-chromium:
1751
1752 2009-09-29  Brady Eidson  <beidson@apple.com>
1753
1754         Reviewed by John Sullivan.
1755
1756         Updated way-out-of-date sorting throughout the dump methods/flags.
1757
1758         * DumpRenderTree/LayoutTestController.cpp:
1759         (LayoutTestController::LayoutTestController):
1760         (dumpAsPDFCallback):
1761         (dumpAsTextCallback):
1762         (dumpFrameLoadCallbacksCallback):
1763         (dumpResourceLoadCallbacksCallback):
1764         (LayoutTestController::staticFunctions):
1765
1766         * DumpRenderTree/LayoutTestController.h:
1767         (LayoutTestController::dumpAsText):
1768         (LayoutTestController::setDumpAsText):
1769         (LayoutTestController::dumpFrameLoadCallbacks):
1770         (LayoutTestController::setDumpFrameLoadCallbacks):
1771         (LayoutTestController::dumpSelectionRect):
1772         (LayoutTestController::setDumpSelectionRect):
1773         (LayoutTestController::dumpSourceAsWebArchive):
1774         (LayoutTestController::setDumpSourceAsWebArchive):
1775         (LayoutTestController::dumpStatusCallbacks):
1776         (LayoutTestController::setDumpStatusCallbacks):
1777         (LayoutTestController::dumpTitleChanges):
1778         (LayoutTestController::setDumpTitleChanges):
1779         (LayoutTestController::dumpWillCacheResponse):
1780         (LayoutTestController::setDumpWillCacheResponse):
1781
1782 2009-09-29  Brady Eidson  <beidson@apple.com>
1783
1784         Reviewed by John Sullivan.
1785
1786         WebKit Mac API should provide a delegate interface for global history.
1787         <rdar://problem/7042773> and https://webkit.org/b/29904
1788
1789         Adding the dumping of global history delegate callbacks.
1790
1791         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1792
1793         Automatically dump history delegate callbacks for tests with "globalhistory/" in their URL:
1794         * DumpRenderTree/mac/DumpRenderTree.mm:
1795         (createWebViewAndOffscreenWindow):
1796         (allocateGlobalControllers):
1797         (shouldLogFrameLoadDelegates):
1798         (shouldLogHistoryDelegates):
1799         (runTest):
1800
1801         Dump history delegate callbacks:
1802         * DumpRenderTree/mac/HistoryDelegate.h: Added.
1803         * DumpRenderTree/mac/HistoryDelegate.mm: Added.
1804         (-[HistoryDelegate webView:didNavigateWithNavigationData:inFrame:]):
1805         (-[HistoryDelegate webView:didPerformClientRedirectFromURL:toURL:inFrame:]):
1806         (-[HistoryDelegate webView:didPerformServerRedirectFromURL:toURL:inFrame:]):
1807
1808 2009-09-29  Daniel Bates  <dbates@webkit.org>
1809
1810         Reviewed by Adam Roben.
1811
1812         https://bugs.webkit.org/show_bug.cgi?id=28902
1813         
1814         Fixes an issue where the drop effect returned by Window Dump Render Tree 
1815         was always DROPEFFECT_NONE (since it was hard coded to do so).
1816         
1817         This patch corrects this issue by determining the actual drop effect 
1818         performed by the corresponding drag-and-drop operation so that we can 
1819         return it.
1820
1821         * DumpRenderTree/win/DraggingInfo.h: Added field m_dropEffect to store performed drop effect.
1822         (DraggingInfo::DraggingInfo):
1823         (DraggingInfo::performedDropEffect): Added method.
1824         (DraggingInfo::setPerformedDropEffect): Added method.
1825         * DumpRenderTree/win/EventSender.cpp:
1826         (doMouseUp): Calls method DraggingInfo::setPerformedDropEffect with performed drop effect.
1827         Moved delete draggingInfo to UIDelegate::doDragDrop.
1828         * DumpRenderTree/win/UIDelegate.cpp:
1829         (UIDelegate::doDragDrop): Sets performedDropEffect to DraggingInfo::performedDropEffect().
1830
1831 2009-09-29  Dan Bernstein  <mitz@apple.com>
1832
1833         Reviewed by Adam Roben.
1834
1835         Remove copying of unnecessary or nonexistent files from the ImageDiff
1836         post-build event.
1837
1838         * DumpRenderTree/win/ImageDiff.vcproj:
1839
1840 2009-09-29  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
1841
1842         Reviewed by David Kilzer.
1843
1844         [Qt] Make build-webkit script work on Windows
1845         https://bugs.webkit.org/show_bug.cgi?id=29802
1846
1847         * Scripts/run-webkit-tests:
1848         * Scripts/webkitdirs.pm:
1849          - Removed unnecessary -p switch for mkdir on Windows.
1850          - Use canonical path, which uses slashes or backslashes depends on platform.
1851          - isWindows() only test for Windows and not for Cyqwin.
1852
1853 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1854
1855         Reviewed by Simon Hausmann.
1856
1857         Fix time measurement in build-webkit after refactoring done in r48853.
1858
1859         * Scripts/build-webkit:
1860
1861 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1862
1863         Reviewed by Tor Arne Vestbø.
1864
1865         [Qt] Default font size reconciliation to 16px/13px to match other platform's de-facto standard.
1866         This fixes https://bugs.webkit.org/show_bug.cgi?id=19674.
1867
1868         * DumpRenderTree/qt/DumpRenderTree.cpp:
1869         (WebCore::WebPage::WebPage):
1870
1871 2009-09-29  Jakub Wieczorek  <faw217@gmail.com>
1872
1873         Reviewed by Simon Hausmann.
1874
1875         [Qt] Implement eventSender.contextClick().
1876         https://bugs.webkit.org/show_bug.cgi?id=29821
1877
1878         * DumpRenderTree/qt/jsobjects.cpp:
1879         (EventSender::contextClick):
1880         * DumpRenderTree/qt/jsobjects.h:
1881
1882 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
1883
1884         Reviewed by Eric Seidel.
1885
1886         Add experimentalWebSocketsEnabled in WebPreferences.
1887         https://bugs.webkit.org/show_bug.cgi?id=28941
1888
1889         * DumpRenderTree/mac/DumpRenderTree.mm:
1890         (resetDefaultsToConsistentValues):
1891         * DumpRenderTree/win/DumpRenderTree.cpp:
1892         (resetDefaultsToConsistentValues):
1893
1894 2009-09-28  Yaar Schnitman  <yaar@chromium.org>
1895
1896         Reviewed by David Kilzer.
1897
1898         Integrated chromium port building into webkit tools update-webkit and
1899         build-webkit.
1900
1901         https://bugs.webkit.org/show_bug.cgi?id=29749
1902
1903         * Scripts/build-webkit: When --chromium is specified, will build
1904           the chromium port (currently only Mac is supported).
1905         * Scripts/update-webkit: When --chromium is specified, delegates to
1906           update-webkit-chromium.
1907         * Scripts/webkitdirs.pm: Added chromium specific defs.
1908         * Scripts/update-webkit-chromium: Uses gclient and gyp to fetch
1909           chromium port's dependencies and update its project files.
1910
1911 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
1912
1913         Unreviewed.
1914
1915         Add myself to list of committers.
1916
1917         * Scripts/modules/committers.py:
1918
1919 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
1920
1921         Reviewed by Darin Adler.
1922
1923         run-webkit-tests: Do not strip the metrics when there is no expected result for a test.
1924         https://bugs.webkit.org/show_bug.cgi?id=29771
1925
1926         * Scripts/run-webkit-tests:
1927
1928 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
1929
1930         Reviewed by Simon Hausmann.
1931
1932         [Qt] Implement layoutTestController.waitForPolicyDelegate.
1933         https://bugs.webkit.org/show_bug.cgi?id=25037
1934
1935         * DumpRenderTree/qt/DumpRenderTree.cpp:
1936         (WebCore::WebPage::acceptNavigationRequest):
1937         * DumpRenderTree/qt/DumpRenderTree.pro:
1938         * DumpRenderTree/qt/jsobjects.cpp:
1939         (LayoutTestController::reset):
1940         (LayoutTestController::notifyDone):
1941         (LayoutTestController::waitForPolicyDelegate):
1942         * DumpRenderTree/qt/jsobjects.h:
1943         (LayoutTestController::waitForPolicy):
1944
1945 2009-09-26  David Kilzer  <ddkilzer@apple.com>
1946
1947         <http://webkit.org/b/29764> mark-bug-fixed: add -o|--open switch
1948
1949         Reviewed by Eric Seidel.
1950
1951         The -o|--open switch uses the open(1) command on Mac OS X to
1952         open the bug URL in the default web browser.  If there are
1953         similar mechanisms on other platforms, they may be added later.
1954
1955         * Scripts/mark-bug-fixed:
1956         (MarkBugFixed.__init__): Added -o|--open switch to list of parse
1957         options.
1958         (MarkBugFixed._determine_bug_id_and_svn_revision): Moved logging
1959         code into main() and extracted prompting code into
1960         _prompt_user_for_correctness().
1961         (MarkBugFixed._open_bug_in_web_browser): Added.
1962         (MarkBugFixed._prompt_user_for_correctness): Added.
1963         (MarkBugFixed.main): Added logging code from
1964         _determine_bug_id_and_svn_revision().  Added code to call
1965         _open_bug_in_web_browser() if the switch is set.  Added code to
1966         call _prompt_user_for_correctness() when needed.
1967         * Scripts/modules/bugzilla.py:
1968         (Bugzilla.short_bug_url_for_bug_id): Added.
1969
1970 2009-09-26  David Kilzer  <ddkilzer@apple.com>
1971
1972         svn-unapply and svn-apply don't work when used outside multiple svn working directories
1973
1974         <http://webkit.org/b/29744>
1975         <rdar://problem/7252905>
1976
1977         Reviewed by Eric Seidel.
1978
1979         Some users have a workflow where svn-create-patch, svn-apply and
1980         svn-unapply are used outside of multiple svn working
1981         directories.  Instead of aborting the scripts in these cases,
1982         print a warning and assume that Subversion is being used.
1983
1984         * Scripts/VCSUtils.pm:
1985         (determineVCSRoot): Call warn() instead of die() if both isGit()
1986         and isSVN() initially return false.  Set $VCSUtils::isSVN to 1
1987         to enforce the assumption about Subversion, then return
1988         determineSVNRoot().
1989         * Scripts/svn-apply: Switch to using isGit() and isSVN() from
1990         VCSUtils.pm.  They both already cache their values and checking
1991         here is redundant since determineVCSRoot() is called later.
1992
1993 2009-09-26  Zan Dobersek  <zandobersek@gmail.com>
1994
1995         Reviewed by Gustavo Noronha.
1996
1997         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
1998         https://bugs.webkit.org/show_bug.cgi?id=29689
1999
2000         Load test fonts through FontConfig before each test.
2001         This ensures a more proper rendering of the tests.
2002
2003         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2004         (initializeFonts):
2005         (runTest):
2006         (main):
2007         * DumpRenderTree/gtk/fonts.conf: Copied from WebKitTools/DumpRenderTree/qt/fonts.conf.
2008         * GNUmakefile.am:
2009
2010 2009-09-25  David Kilzer  <ddkilzer@apple.com>
2011
2012         <http://webkit.org/b/29718> mark-bug-fixed: add -u|--update-only switch
2013
2014         Reviewed by Eric Seidel.
2015
2016         * Scripts/mark-bug-fixed:
2017         (MarkBugFixed.__init__): Added -u|--update-only switch to list
2018         of parse options.
2019         (MarkBugFixed.main): When -u|--update-only is specified, add a
2020         comment to the bug without marking it Resolved/Fixed.
2021
2022 2009-09-25  Darin Adler  <darin@apple.com>
2023
2024         Reviewed by Geoffrey Garen.
2025
2026         * Scripts/prepare-ChangeLog: Leave files from the script-tests directory
2027         out, just as we do for the resources directory.
2028
2029 2009-09-25  Adam Barth  <abarth@webkit.org>
2030
2031         Unreviewed.  Added Tony to committers.py because he's a
2032         committer now.
2033
2034         * Scripts/modules/committers.py:
2035
2036 2009-09-25  Eric Seidel  <eric@webkit.org>
2037
2038         Reviewed by Simon Fraser.
2039
2040         REGRESSION: media/video-pause-empty-events.html is occasionally timing out on bots
2041         https://bugs.webkit.org/show_bug.cgi?id=28624
2042
2043         Disable hardware compositing on Leopard for versions of QuickTime 7.6.4 and older.
2044
2045         * DumpRenderTree/mac/DumpRenderTree.mm:
2046         (resetDefaultsToConsistentValues):
2047
2048 2009-09-25  Eric Seidel  <eric@webkit.org>
2049
2050         Reviewed by Adam Barth.
2051
2052         commit-queue should auto-retry patches which fail to commit due to out of date files
2053         https://bugs.webkit.org/show_bug.cgi?id=28316
2054
2055         * Scripts/bugzilla-tool:
2056          - Handle new CheckoutNeedsUpdate exception.
2057         * Scripts/modules/logging_unittest.py:
2058          - Call the ScriptError constructor correctly (this test had regressed).
2059         * Scripts/modules/scm.py:
2060          - Added the ability to define custom error handlers for run_command
2061            and added a commit_error_handler which throws CheckoutNeedsUpdate
2062            instead of ScriptError.
2063          - Re-ordered ScriptError constructor arguments to make ScriptError("message text") usage possible.
2064         * Scripts/modules/scm_unittest.py:
2065          - Added tests of new error handlers.
2066
2067 2009-09-25  Eric Seidel  <eric@webkit.org>
2068
2069         Reviewed by Adam Barth.
2070
2071         commit-queue should give better feedback when failing a patch
2072         https://bugs.webkit.org/show_bug.cgi?id=29316
2073
2074         * Scripts/bugzilla-tool:
2075          - Update ScriptError uses to the new constructor format.
2076          - Move CommitQueue._run_command to WebKitLandingScripts.run_command_with_teed_output
2077            so that we can print to both stdout as well as an output buffer for error reporting.
2078          - Update run_and_throw_if_fail to use teed output so that it can report the "output" as part of ScriptError.
2079          - Use e.message_with_output() when failing a patch (this is the real fix here).
2080            I also removed use of "This patch will require manual commit." as that's not always true.
2081          - Add missing word "bug" from log message.
2082         * Scripts/modules/scm.py:
2083          - Make ScriptError save a bunch more data so that error messages can be nicer.
2084          - Update ScriptError callers.
2085
2086 2009-09-24  John Gregg  <johnnyg@google.com>
2087
2088         Reviewed by Eric Seidel.
2089
2090         Enable switch for notifications (experimental) in Page Settings
2091         https://bugs.webkit.org/show_bug.cgi?id=28930
2092
2093         Now that desktop notifications are controlled by run-time switch,
2094         set that switch to true for DumpRenderTree.
2095
2096         * DumpRenderTree/mac/DumpRenderTree.mm:
2097         (resetDefaultsToConsistentValues):
2098         * DumpRenderTree/win/DumpRenderTree.cpp:
2099         (resetDefaultsToConsistentValues):
2100         * DumpRenderTree/win/UIDelegate.cpp:
2101         (UIDelegate::QueryInterface):
2102
2103 2009-09-24  Kevin Ollivier  <kevino@theolliviers.com>
2104
2105         wx build fix. SnowLeopard fixes for Mac dependencies.
2106
2107         * wx/build/build_utils.py:
2108         * wx/build/settings.py:
2109         * wx/install-unix-extras:
2110
2111 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2112
2113         Reviewed by Oliver Hunt.
2114
2115         Add support for DRT to send mouse wheel events.
2116
2117         https://bugs.webkit.org/show_bug.cgi?id=29348
2118         [Gtk] Scrollwheel on horizontal scrollbars should slide horizontally
2119
2120         * DumpRenderTree/gtk/EventSender.cpp:
2121         (mouseWheelToCallback):
2122
2123 2009-09-17  Eric Seidel  <eric@webkit.org>
2124
2125         Reviewed by David Levin.
2126
2127         commit-queue needs web-based status reporting
2128         https://bugs.webkit.org/show_bug.cgi?id=29307
2129
2130         Add a first-pass web-based status for the commit-queue.
2131         The bot is currently reachable at:
2132         http://webkit-commit-queue.appspot.com/
2133
2134         * CommitQueueStatus/app.yaml: Added.
2135          - Application description file required by App Engine.
2136         * CommitQueueStatus/filters/__init__.py: Added.
2137          - Required by python to treat 'filters' as a module.
2138         * CommitQueueStatus/filters/webkit_extras.py: Added.
2139          - Support for turning 'bug 123' and 'patch 123' into links.
2140            This lets us use plain text strings in our logs yet display nice HTML (help prevent XSS attacks on the page).
2141         * CommitQueueStatus/index.html: Added.
2142         * CommitQueueStatus/index.yaml: Added.
2143          - Some auto-generated file from app engine.
2144         * CommitQueueStatus/queue_status.py: Added.
2145          - The core logic of this bot.  We could eventually split this file out into pieces.
2146         * CommitQueueStatus/stylesheets/main.css: Added.
2147          - Some basic lame-o CSS to make the page look less awful.
2148         * CommitQueueStatus/update_status.html: Added.
2149          - The form that the commit-queue (or a human) can use to update the status.
2150         * Scripts/bugzilla-tool:
2151          - Add some very basic update_status calls.
2152         * Scripts/modules/statusbot.py: Added.
2153          - Knows how to post to the CommitQueueStatus web application.
2154
2155 2009-09-24  David Kilzer  <ddkilzer@apple.com>
2156
2157         <http://webkit.org/b/29712> mark-bug-fixed: add -m|--comment switch
2158
2159         Reviewed by Adam Roben.
2160
2161         * Scripts/mark-bug-fixed:
2162         (MarkBugFixed.__init__): Added -m|--comment switch to list of
2163         parse options.
2164         (MarkBugFixed.main): When specified, prepend comment from
2165         -m|--comment command-line switch to the bug comment.
2166
2167 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2168
2169         Reviewed by Jan Alonzo.
2170
2171         [GTK] DRT must display window instead of just realizing, to enable synthesizing events correctly
2172         https://bugs.webkit.org/show_bug.cgi?id=29693
2173
2174         Show the window, to be able to synthesize events correctly.
2175
2176         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2177         (runTest):
2178         (main):
2179
2180 2009-09-24  Oliver Hunt  <oliver@apple.com>
2181
2182         Reviewed by NOBODY(rollout)
2183
2184         Roll out r48712 as it is incorrect.
2185
2186         * DumpRenderTree/mac/ObjCController.m:
2187         (+[ObjCController isSelectorExcludedFromWebScript:]):
2188         (+[ObjCController webScriptNameForSelector:]):
2189
2190 2009-09-24  Benjamin Poulain  <benjamin.poulain@nokia.com>
2191
2192         Reviewed by Eric Seidel.
2193
2194         https://bugs.webkit.org/show_bug.cgi?id=29005
2195         The indices of RuntimeArray should be enumerated like for a regular array.
2196
2197         * DumpRenderTree/mac/ObjCController.m:
2198         (+[ObjCController isSelectorExcludedFromWebScript:]):
2199         (+[ObjCController webScriptNameForSelector:]):
2200         (-[ObjCController arrayOfString]):
2201
2202 2009-09-23  David Kilzer  <ddkilzer@apple.com>
2203
2204         <http://webkit.org/b/28910> Move bugzilla-tool mark-fixed to standalone mark-bug-fixed tool
2205
2206         Reviewed by Darin Adler.
2207
2208         Also fixed a bug where specifying a revision on the command-line
2209         as 'r12345' would fail.  See <http://webkit.org/b/29699>.
2210
2211         * Scripts/bugzilla-tool: Updated module import statements.
2212         (parse_bug_id): Removed.  Moved to bugzilla.py.
2213         (bug_comment_from_svn_revision): Removed.  Moved to comments.py.
2214         (bug_comment_from_commit_text): Removed.  Moved to comments.py.
2215         (MarkBugFixed): Removed.  Code moved to mark-bug-fixed.
2216         (BugzillaTool.__init__): Removed mark-fixed subcommand.
2217         * Scripts/mark-bug-fixed: Added.
2218         * Scripts/modules/bugzilla.py:
2219         (parse_bug_id): Added.  Moved from bugzilla-tool.
2220         * Scripts/modules/comments.py: Added.
2221         (bug_comment_from_svn_revision): Added.  Moved from bugzilla-tool.
2222         (bug_comment_from_commit_text): Added.  Moved from bugzilla-tool.
2223
2224 2009-09-23  Marshall Culpepper  <mculpepper@appcelerator.com>
2225
2226         Reviewed by Eric Seidel.
2227         
2228          jpeg.lib is now libjpeg.lib in DRT Cairo dependencies. return
2229          "false" in non-implemented stub for setAlwaysAcceptCookies.
2230          https://bugs.webkit.org/show_bug.cgi?id=29661
2231
2232         * DumpRenderTree/win/DumpRenderTree.vcproj:
2233         * DumpRenderTree/win/DumpRenderTree.cpp:
2234
2235 2009-09-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2236
2237         Reviewed by Xan Lopez.
2238
2239         [GTK] need to dump number of pending unload handlers
2240         https://bugs.webkit.org/show_bug.cgi?id=29685
2241
2242         Implement dumping of the number of pending unload handlers.
2243
2244         The following tests will pass:
2245
2246           fast/loader/unload-form-about-blank.html
2247           fast/loader/unload-form-post-about-blank.html
2248           fast/loader/unload-form-post.html
2249           fast/loader/unload-form.html
2250           fast/loader/unload-hyperlink.html
2251           fast/loader/unload-javascript-url.html
2252           fast/loader/unload-reload.html
2253           fast/loader/unload-window-location.html
2254
2255         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2256         (getFrameNameSuitableForTestResult):
2257         (webViewLoadFinished):
2258
2259 2009-09-22  Shinichiro Hamaji  <hamaji@chromium.org>
2260
2261         Reviewed by Eric Seidel.
2262
2263         js tests should move into jstests subdirectory instead of resources/
2264         https://bugs.webkit.org/show_bug.cgi?id=25880
2265
2266         Remove support of resources directory.
2267
2268         * Scripts/make-script-test-wrappers:
2269
2270 2009-09-22  Eric Seidel  <eric@webkit.org>
2271
2272         No review, only fixing typo (missing space character).
2273
2274         Fix typo from https://bugs.webkit.org/show_bug.cgi?id=29220
2275
2276         * Scripts/run-webkit-tests:
2277
2278 2009-09-22  Eric Seidel  <eric@webkit.org>
2279
2280         Reviewed by Darin Adler.
2281
2282         run-webkit-tests needs a --repeat-each=N option (AAABBBCCC instead of ABCABCABC)
2283         https://bugs.webkit.org/show_bug.cgi?id=29220
2284
2285         * Scripts/run-webkit-tests:
2286
2287 2009-09-22  Eric Seidel  <eric@webkit.org>
2288
2289         Reviewed by David Kilzer.
2290
2291         svn-apply can't handle single-line binary file additions
2292         https://bugs.webkit.org/show_bug.cgi?id=29100
2293
2294         Fixed the regexp and added a unit test.
2295
2296         * Scripts/modules/scm_unittest.py:
2297         * Scripts/svn-apply:
2298
2299 2009-09-11  Eric Seidel  <eric@webkit.org>
2300
2301         Reviewed by David Kilzer.
2302
2303         post-diff and post-commits should be able to find bug urls in ChangeLogs.
2304         https://bugs.webkit.org/show_bug.cgi?id=29206
2305
2306         * Scripts/bugzilla-tool:
2307          - Share common options by adding a PostDiffAsPatchToBug.posting_options() method.
2308          - Rename --no-comment to --add-log-as-comment and reverse behavior.
2309            Comments tend to just be noise.  I'll eventually remove this argument if no one uses it.
2310          - Split out code into helper functions to try and make execute() more legible.
2311          - Make post-diff find the bug url in the ChangeLogs if not passed as an argument.
2312          - Fallback to bug urls in commit diffs, instead of just in commit messages,
2313            meaning post-commits will now find bug urls in ChangeLogs.
2314
2315 2009-09-21  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
2316
2317         Reviewed by Maciej Stachowiak.
2318
2319         --parse-only parameter wasn't passed to SunSpider/sunspider script.
2320         https://bugs.webkit.org/show_bug.cgi?id=29611
2321
2322         * Scripts/run-sunspider: Missing parameter passing added.
2323
2324 2009-09-20  David Kilzer  <ddkilzer@apple.com>
2325
2326         <http://webkit.org/b/29521> run-webkit-tests: use require instead eval to load DumpRenderTreeSupport module
2327
2328         Reviewed by Mark Rowe.
2329
2330         The require statement is like the use statement, except that it
2331         is run during script execution instead of during the 'BEGIN'
2332         phase.  This makes it possible to change @INC before the require
2333         statement is run.  See 'require' and 'use' in the perlfunc(1)
2334         manpage and 'BEGIN' in perlmod(1) manpage.
2335
2336         * Scripts/run-webkit-tests: Replace eval statement with require
2337         statement.
2338
2339 2009-09-18  Kevin Ollivier  <kevino@theolliviers.com>
2340
2341         wx build fixes. Fix the config name under git and allow users to specify
2342         their own waf install for experimenting with new versions.
2343
2344         * Scripts/webkitdirs.pm:
2345         * wx/build/settings.py:
2346
2347 2009-09-18  Alex Milowski  <alex@milowski.com>
2348
2349         Reviewed by Maciej Stachowiak.
2350
2351         Added checkWebCoreMathMLSupport and hasMathMLSupport to support 
2352         checking for whether MathML tests should be run
2353
2354         * Scripts/run-webkit-tests:
2355         * Scripts/webkitdirs.pm:
2356
2357 2009-08-28  Darin Adler  <darin@apple.com>
2358
2359         Reviewed by Mark Rowe.
2360
2361         Break more of run-webkit-tests into separate functions
2362         https://bugs.webkit.org/show_bug.cgi?id=29497
2363
2364         Some small steps toward improving run-webkit-tests. My goal is to
2365         refactor much more of the script into functions. Later we can add
2366         parallel test running to the tool. But better structure may help
2367         even if someone decides to translate this into another scripting
2368         language instead.
2369
2370         * Scripts/run-webkit-tests: Break more pieces of the script into
2371         seprate functions. Added readSkippedFiles, findTestsToRun, and
2372         printResults functions. Removed custom code to skip results.html
2373         and instead just put it into the ignoredFiles hash. Fixed some
2374         indentation. Sorted function declarations, global variables,
2375         and options at the top of the file alphabetically so they're not
2376         in a semi-random order.
2377
2378 2009-09-17  Kevin Ollivier  <kevino@theolliviers.com>
2379
2380         wx build fix, add missing dependency.
2381
2382         * wx/browser/wscript:
2383
2384 2009-09-16  Mark Rowe  <mrowe@apple.com>
2385
2386         Split the SnowLeopard build across a few machines.
2387
2388         * BuildSlaveSupport/build.webkit.org-config/config.json:
2389
2390 2009-09-16  Kevin Ollivier  <kevino@theolliviers.com>
2391
2392         wx build fix to support monolithic builds on Windows.
2393
2394         * wx/build/wxpresets.py:
2395
2396 2009-09-16  Kevin Ollivier  <kevino@theolliviers.com>
2397
2398         wx build fix, improve debug support and 2.9 support on MSW.
2399
2400         * wx/build/settings.py:
2401         * wx/build/wxpresets.py:
2402
2403 2009-09-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2404
2405         Blind try at fixing new test failure on Windows.
2406
2407         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2408         (FrameLoadDelegate::didReceiveTitle):
2409
2410 2009-09-15  Alex Milowski  <alex@milowski.com>
2411
2412         Reviewed by Tor Arne Vestbø.
2413
2414         Added mathml toggle
2415
2416         * Scripts/build-webkit:
2417
2418 2009-09-15  Kevin Ollivier  <kevino@theolliviers.com>
2419
2420         wx build fix. Allow waf build to support Python < 2.6.
2421
2422         * wx/build/waf_extensions.py:
2423
2424 2009-09-14  Chris Marrin  <cmarrin@apple.com>
2425
2426         Reviewed by Oliver Hunt.
2427
2428         Add LayoutTests infrastructure to enable and disable webgl tests.
2429         https://bugs.webkit.org/show_bug.cgi?id=29254
2430
2431         * Scripts/run-webkit-tests:
2432         * Scripts/webkitdirs.pm:
2433
2434 2009-09-14  Simon Fraser  <simon.fraser@apple.com>
2435
2436         Reviewed by Darin Adler.
2437         
2438         Add --iterations option to run-webkit-tests to repeat the tests N times
2439         https://bugs.webkit.org/show_bug.cgi?id=29263
2440
2441         When run with --iterations N, run-webkit-tests will repeat the tests N times.
2442
2443         * Scripts/run-webkit-tests:
2444
2445 2009-09-14  Brady Eidson  <beidson@apple.com>
2446
2447         Not reviewed, maybe should've been:
2448
2449         Cleaning up more Windows-specific fallout from the fix for:
2450         <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160
2451
2452         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2453         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):  Correct printf() formatter, 
2454           and call the correct method to get the Sender.
2455
2456 2009-09-14  Jon Honeycutt  <jhoneycutt@apple.com>
2457
2458         GTK build fix.
2459
2460         Unreviewed.
2461
2462         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2463         (AccessibilityController::setLogScrollingStartEvents):
2464
2465 2009-09-11  Jon Honeycutt  <jhoneycutt@apple.com>
2466
2467         DRT/test part of
2468         <rdar://problem/7197644> WebKit should broadcast an MSAA event when
2469         jumping to a named anchor
2470
2471         https://bugs.webkit.org/show_bug.cgi?id=28899
2472
2473         Reviewed by Adam Roben.
2474
2475         * DumpRenderTree/AccessibilityController.cpp:
2476         (logScrollingStartEventsCallback):
2477         Turn on logging of scrolling start events.
2478         (AccessibilityController::getJSClass):
2479         Add a "logScrollingStartEvents" to the AccessibilityController's JS
2480         class definition.
2481         (AccessibilityController::resetToConsistentState):
2482         Turn off logging of scrolling start events.
2483
2484         * DumpRenderTree/AccessibilityController.h:
2485         Declare setLogScrollingStartEvents(). Add a member for the scrolling
2486         start event hook.
2487
2488         * DumpRenderTree/mac/AccessibilityControllerMac.cpp:
2489         (AccessibilityController::setLogScrollingStartEvents):
2490         Stubbed.
2491
2492         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2493         (AccessibilityController::AccessibilityController):
2494         Initialize the handle to 0.
2495         (logEventProc):
2496         Renamed from logFocusEventProc; now logs scrolling start events, too.
2497         Removed the assertion that the event is a focus event. Added a switch
2498         to print a message for focus, scrolling start, and other, unknown
2499         events.
2500         (AccessibilityController::setLogFocusEvents):
2501         Changed to use logEventProc.
2502         (AccessibilityController::setLogScrollingStartEvents):
2503         If turning logging off, unhook the scrolling start event hook, and clear
2504         the member holding the handle. If turning on, query for the root
2505         accessible, so that accessibility is enabled for the WebView, and call
2506         SetWinEventHook to setup an event hook using logEventProc as the
2507         callback function.
2508
2509 2009-09-14  Brady Eidson  <beidson@apple.com>
2510
2511         Windows build fix.
2512
2513         * DumpRenderTree/LayoutTestController.cpp:
2514         (setAuthenticationPasswordCallback):
2515         (setAuthenticationUsernameCallback):
2516         
2517         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2518         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2519
2520 2009-09-14  Brady Eidson  <beidson@apple.com>
2521
2522         Reviewed by Alexey Proskuryakov.
2523
2524         Safari 4 cannot be used to update firmware on Linksys routers.
2525         <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160
2526
2527         Add the ability for DRT to handle authentication challenges.
2528
2529         * DumpRenderTree/LayoutTestController.cpp:
2530         (setAuthenticationPasswordCallback):
2531         (setAuthenticationUsernameCallback):
2532         (setHandlesAuthenticationChallengesCallback):
2533         (LayoutTestController::staticFunctions):
2534
2535         * DumpRenderTree/LayoutTestController.h:
2536         (LayoutTestController::handlesAuthenticationChallenges):
2537         (LayoutTestController::setHandlesAuthenticationChallenges):
2538         (LayoutTestController::authenticationUsername):
2539         (LayoutTestController::setAuthenticationUsername):
2540         (LayoutTestController::authenticationPassword):
2541         (LayoutTestController::setAuthenticationPassword):
2542
2543         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2544         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
2545
2546         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2547         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2548         * DumpRenderTree/win/ResourceLoadDelegate.h:
2549
2550 2009-09-12  Mark Rowe  <mrowe@apple.com>
2551
2552         Reviewed by Dan Bernstein.
2553
2554         Test for <rdar://problem/6954546> and <rdar://problem/7090444>.
2555
2556         Add a flag on the test plug-in that asks it to clear the document during the call to NPP_New.
2557         This is the trigger for both <rdar://problem/6954546> and <rdar://problem/7090444>.
2558
2559         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2560         (NPP_New):
2561
2562 2009-09-14  Kevin Ollivier  <kevino@theolliviers.com>
2563
2564         wx build fix for non-wxPython builds and a fix for errors when updating swig.py.
2565
2566         * wx/build/build_utils.py:
2567         * wx/build/settings.py:
2568
2569 2009-09-14  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
2570
2571         Reviewed by Tor Arne Vestbø.
2572
2573         [Qt] Build fix for windows build.
2574
2575         * Scripts/bisect-builds: Add missing paranthesis for tmpdir function.
2576
2577 2009-09-13  Kevin Ollivier  <kevino@theolliviers.com>
2578
2579         Fix typo accidently landed in last commit.
2580
2581         * wx/build/settings.py:
2582
2583 2009-09-13  Kevin Ollivier  <kevino@theolliviers.com>
2584
2585         wx build fix, error out if using the wrong Python.
2586
2587         * wx/build/settings.py:
2588
2589 2009-09-13  Xan Lopez  <xlopez@igalia.com>
2590
2591         Build fix for GTK+ < 2.14.
2592
2593         Do not use gtk_widget_get_window, access the window directly
2594         through the struct.
2595
2596         * DumpRenderTree/gtk/EventSender.cpp:
2597         (contextClickCallback):
2598         (mouseDownCallback):
2599         (mouseUpCallback):
2600         (mouseMoveToCallback):
2601         (keyDownCallback):
2602
2603 2009-09-13  Martin Robinson  <martin.james.robinson@gmail.com>
2604
2605         Reviewed by Xan Lopez and Jan Alonzo.
2606
2607         [GTK] EventSender does not set 'window' property on synthesized GDK events
2608         https://bugs.webkit.org/show_bug.cgi?id=29169
2609
2610         Set the window property on synthesized GDK events in the GTK+ EventSender.
2611
2612         * DumpRenderTree/gtk/EventSender.cpp:
2613         (contextClickCallback):
2614         (mouseDownCallback):
2615         (mouseUpCallback):
2616         (mouseMoveToCallback):
2617         (keyDownCallback):
2618
2619 2009-09-12  Drew Wilson  <atwilson@google.com>
2620
2621         Reviewed by Mark Rowe.
2622
2623         run-webkit-tests has a timeout value that is too low
2624         https://bugs.webkit.org/show_bug.cgi?id=29223
2625
2626         * Scripts/run-webkit-tests:
2627         Changed timeout value to 20 seconds to avoid timing out too early.
2628
2629 2009-09-11  Kevin Ollivier  <kevino@theolliviers.com>
2630
2631         wx build fix. Mark dependencies as mandatory and declare which MSVC versions and
2632         architectures are supported for building wxWebKit.
2633
2634         * wx/build/settings.py:
2635
2636 2009-09-11  Eric Seidel  <eric@webkit.org>
2637
2638         Reviewed by David Levin.
2639
2640         bugzilla-tool rollout threw exception under svn
2641         https://bugs.webkit.org/show_bug.cgi?id=29211
2642
2643         * Scripts/modules/scm.py: add missing return, and convert number arguments to strings.
2644         * Scripts/modules/scm_unittest.py: add testing for this fix.
2645
2646 2009-09-11  Brian Weinstein  <bweinstein@apple.com>
2647
2648         Add myself to the committers list.
2649
2650         * Scripts/modules/committers.py:
2651
2652 2009-09-11  Eric Seidel  <eric@webkit.org>
2653
2654         Reviewed by Adam Barth.
2655
2656         bugzilla-tool land-patches should only fail-fast in --commit-queue mode
2657         https://bugs.webkit.org/show_bug.cgi?id=29201
2658
2659         * Scripts/bugzilla-tool:
2660
2661 2009-09-11  Adam Roben  <aroben@apple.com>
2662
2663         Make commit-log-editor move common prefixes to the top of the log
2664
2665         Fies <http://webkit.org/b/29190> commit-log-editor should move common
2666         prefixes to the top of the commit log
2667
2668         Reviewed by Darin Adler.
2669
2670         * Scripts/commit-log-editor: Find and remove the longest common prefix
2671         ending in a double newline from each ChangeLog entry, then put that
2672         common prefix at the top of the commit log.
2673         (removeLongestCommonPrefixEndingInDoubleNewline): Added. Finds,
2674         removes, and returns the longest common prefix ending in a double
2675         newline from a hash of strings
2676
2677 2009-09-11  Eric Seidel  <eric@webkit.org>
2678
2679         Fix obvious typo in previous commit, no review.
2680
2681         bugzilla-tool should automate rollouts
2682         https://bugs.webkit.org/show_bug.cgi?id=26715
2683
2684         * Scripts/bugzilla-tool: add back missing "scm" argument.
2685
2686 2009-09-11  Eric Seidel  <eric@webkit.org>
2687
2688         Reviewed by Adam Barth.
2689
2690         bugzilla-tool should automate rollouts
2691         https://bugs.webkit.org/show_bug.cgi?id=26715
2692
2693         bugzilla-tool rollout will do the rollout locally and leave the diff for you to verify and commit.
2694         The --complete-rollout option will automatically land and update the bug.
2695         Eventually --complete-rollout will be default, but that will require more testing.
2696
2697         This first pass is good enough for others to try and file bugs about.
2698
2699         * Scripts/bugzilla-tool:
2700          - Move modified_changelogs into scm.py.
2701          - Move svn_revision_from_commit_text logic into scm.py.
2702          - Add RolloutCommit command.
2703         * Scripts/modules/bugzilla.py:
2704          - Add reopen_bug command used by RolloutCommit.
2705         * Scripts/modules/scm.py:
2706          - Add functions to support RolloutCommit.
2707          - Abstract find_uuid into value_from_svn_info so it can be re-used for _repository_url (needed by svn merge).
2708          - Add a str() call so that svn_commit_log can take a numeric argument.
2709          - Remove a bunch of very slow code from last_svn_commit_log and used the built-in 'BASE' alias instead.
2710          - Made dry_run commits return something that svn_revision_from_commit_text can parse.
2711         * Scripts/modules/scm_unittest.py:
2712          - Add read_from_path for easy file reading.
2713          - Put test4 on a new line to make reverts work w/o conflict.
2714          - Add an "svn update" call so that the checkout revision matches the server revision.
2715          - Add tests for svn_revision_from_commit_text.
2716          - Add a simple test for apply_reverse_diff.
2717          - Add a new self.scm member and use it in the new tests (eventually other tests can use it too).
2718          - Add test for svn_commit_log to make sure my 'BASE' change above worked as expected.
2719
2720 2009-09-11  Adam Roben  <aroben@apple.com>
2721
2722         Get user script/stylesheet tests running on Windows
2723
2724         Fixes <http://webkit.org/b/29181> User script/stylesheet tests are
2725         skipped on Windows
2726
2727         Reviewed by John Sullivan.
2728
2729         * DumpRenderTree/win/DumpRenderTree.vcproj: Link all configurations
2730         against comsuppw.lib so we can use _bstr_t.
2731
2732         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Fixed #include
2733         order, added #include of comutil.h for _bstr_t.
2734
2735         (bstrT): Helper function to convert a JSStringRef to a _bstr_t.
2736         (LayoutTestController::addUserScript):
2737         (LayoutTestController::addUserStyleSheet):
2738         Implemented. Implementations were based on those in
2739         LayoutTestControllerMac.mm.
2740
2741 2009-09-10  David Kilzer  <ddkilzer@apple.com>
2742
2743         <http://webkit.org/b/29147> run-webkit-tests:  make -h show help 
2744
2745         Reviewed by Mark Rowe.
2746
2747         * Scripts/run-webkit-tests: Updated to make -h switch show help.
2748
2749 2009-09-10  Fumitoshi Ukai  <ukai@chromium.org>
2750
2751         Reviewed by Alexey Proskuryakov.
2752
2753         Add WebCore/websockets directory in wx build system.
2754         https://bugs.webkit.org/show_bug.cgi?id=28038
2755
2756         * wx/build/settings.py:
2757
2758 2009-09-10  Martin Robinson  <martin.james.robinson@gmail.com>
2759
2760         [GTK] EventSender does not properly convert some keyDown strings
2761         https://bugs.webkit.org/show_bug.cgi?id=29119
2762
2763         Add more keyDown string to character code conversions for GTK+ EventSender.
2764
2765         * DumpRenderTree/gtk/EventSender.cpp:
2766         (keyDownCallback):
2767
2768 2009-09-09  Steve Block  <steveblock@google.com>
2769
2770         Reviewed by Maciej Stachowiak.
2771
2772         Geolocation Coordinates::toString() prints bogus values for unspecified properties.
2773         https://bugs.webkit.org/show_bug.cgi?id=29080
2774
2775         * Scripts/make-script-test-wrappers: Modified. Adds asynchronous Geolocation tests to exclusion list.
2776
2777 2009-09-09  Eric Seidel  <eric@webkit.org>
2778
2779         Reviewed by Eric Carlson.
2780
2781         reviewer/committer lookups are backwards
2782         https://bugs.webkit.org/show_bug.cgi?id=29113
2783
2784         I also moved Eric Carlson from the committer list to the reviewer list now that he is one.
2785
2786         * Scripts/modules/bugzilla.py:
2787         * Scripts/modules/committers.py:
2788
2789 2009-09-09  Cameron McCormack  <cam@mcc.id.au>
2790
2791         Reviewed by Eric Seidel.
2792
2793         svn-unapply doesn't revert directories correctly
2794         https://bugs.webkit.org/show_bug.cgi?id=29065
2795
2796         * Scripts/svn-unapply: Make svnStatus consistently return status
2797         lines including a newline.
2798         * Scripts/svn-apply: Keep svnStatus in sync with the one in
2799         svn-unapply, in lieu of moving it to a common file.
2800
2801 2009-09-09  Cameron McCormack  <cam@mcc.id.au>
2802
2803         Reviewed by Eric Seidel.
2804
2805         svn-apply doesn't handle changes to files copied to new directories properly
2806         https://bugs.webkit.org/show_bug.cgi?id=29059
2807
2808         * Scripts/svn-apply: Don't treat "--- revision 0" patches as being
2809         additions if we know that we've just copied a file to this name.
2810
2811 2009-09-09  Eric Seidel  <eric@webkit.org>
2812
2813         Reviewed by David Levin.
2814
2815         commit-queue hangs if a builder has never built
2816         https://bugs.webkit.org/show_bug.cgi?id=29091
2817
2818         * Scripts/modules/buildbot.py:
2819         * Scripts/modules/buildbot_unittest.py:
2820
2821 2009-09-09  Zan Dobersek  <zandobersek@gmail.com>
2822
2823         Reviewed by Gustavo Noronha.
2824
2825         [GTK] DumpRenderTree needs eventSender object and implementation
2826         https://bugs.webkit.org/show_bug.cgi?id=25990
2827
2828         Implements most of the EventSender object's functionality for
2829         the DumpRenderTree tool. Implementation still lacks support
2830         for drag and drop tests and forward leaps.
2831
2832         Based on work by Holger Hans Peter Freyther.
2833
2834         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2835         (runTest): Focus on the view before loading a new test.
2836         (webViewWindowObjectCleared):
2837         * DumpRenderTree/gtk/EventSender.cpp: Added.
2838         (getDragModeCallback):
2839         (setDragModeCallback):
2840         (leapForwardCallback):
2841         (contextClickCallback):
2842         (updateClickCount):
2843         (mouseDownCallback):
2844         (mouseUpCallback):
2845         (mouseMoveToCallback):
2846         (beginDragWithFilesCallback):
2847         (replaySavedEvents):
2848         (keyDownCallback):
2849         (textZoomInCallback):
2850         (textZoomOutCallback):
2851         (zoomPageInCallback):
2852         (zoomPageOutCallback):
2853         (getClass):
2854         (makeEventSender):
2855         * DumpRenderTree/gtk/EventSender.h: Added.
2856         * GNUmakefile.am: Add build rules for EventSender.
2857
2858 2009-09-09  Daniel Bates  <dbates@webkit.org>
2859
2860         Reviewed by Adam Roben.
2861         
2862         https://bugs.webkit.org/show_bug.cgi?id=28953
2863
2864         Added pre- and post- build events so that on build failure, the file 
2865         buildfailed is written to the directory $(WebKitOutputDir).
2866
2867         * WinLauncher/WinLauncher.vcproj:
2868
2869 2009-09-09  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2870
2871         Unreviewed.
2872
2873         Add myself to list of committers.
2874
2875         * Scripts/modules/committers.py:
2876
2877 2009-09-08  Eric Seidel  <eric@webkit.org>
2878
2879         Reviewed by David Levin.
2880
2881         commit-queue gets stuck if a non-committer sets commit-queue+ or review+
2882         https://bugs.webkit.org/show_bug.cgi?id=28605
2883         https://bugs.webkit.org/show_bug.cgi?id=28916
2884
2885         * Scripts/bugzilla-tool:
2886          - Fix comment and adjust reject_patch_from_commit_queue call to pass "manual commit"
2887            comment now that it's used for rejecting patches for invalid committers too.
2888          - Pass reject_invalid_patches=True for commit-queue calls, normally we just ignore patches with invalid reviewers, the commit-queue rejects them.
2889          - Make the commit queue print patches count instead of bugs count, this also fixes https://bugs.webkit.org/show_bug.cgi?id=28916.
2890         * Scripts/modules/bugzilla.py:
2891          - Make _parse_attachment_element not validate reviewer/committer.
2892          - Share flag parsing code in _parse_attachment_flag.
2893          - Add _validate* methods for validating reviewers and committers and updating bugs when validation fails.
2894          - Add reject_invalid_patches argument so the commit-queue can update bugs on failed validation and other "read only" commands will not.
2895          - Add reject_patch_from_review_queue using a new _set_flag_on_attachment abstraction.
2896         * Scripts/modules/bugzilla_unittest.py:
2897          - Update this test to no longer expect committer/reviewer validation.
2898         * Scripts/modules/committers.py:
2899          - Return None on failed lookups instead of raising Exceptions.
2900         * Scripts/modules/committers_unittest.py:
2901          - Update tests to expect None returns instead of exceptions.
2902
2903 2009-09-09  David Kilzer  <ddkilzer@apple.com>
2904
2905         <http://webkit.org/b/29061> Fix obvious copy-paste error in AccessibilityUIElement::clickPointY()
2906
2907         Reviewed by Mark Rowe.
2908
2909         No change to layout test results.
2910
2911         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2912         (AccessibilityUIElement::clickPointY): Changed to return y value
2913         instead of x value.
2914
2915 2009-09-08  Dimitri Glazkov  <dglazkov@chromium.org>
2916
2917         Reviewed by Mark Rowe.
2918
2919         Reduce dglazkov's boboiness by properly concatenating revision value.
2920
2921         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Used substitution
2922             rather than "+".
2923
2924 2009-09-08  Kevin Ollivier  <kevino@theolliviers.com>
2925
2926         wxWebKit Python extension build fix - get swig.py if it doesn't exist.
2927
2928         * wx/build/build_utils.py:
2929
2930 2009-09-08  Mark Rowe  <mrowe@apple.com>
2931
2932         Fix an incorrect variable name in UpdateChromiumSource.
2933
2934         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2935
2936 2009-09-08  Mark Rowe  <mrowe@apple.com>
2937
2938         Don't check for leaks on the release SnowLeopard builder.
2939
2940         * BuildSlaveSupport/build.webkit.org-config/config.json:
2941
2942 2009-09-08  Mark Rowe  <mrowe@apple.com>
2943
2944         Add a SnowLeopard release builder.
2945
2946         * BuildSlaveSupport/build.webkit.org-config/config.json:
2947
2948 2009-09-08  David Levin  <levin@chromium.org>
2949
2950         Reviewed by Darin Adler.
2951
2952         Remove end of line whitespace check from check-webkit-style.
2953         https://bugs.webkit.org/show_bug.cgi?id=29053
2954
2955         * Scripts/modules/cpp_style.py:
2956
2957 2009-09-08  Cameron McCormack  <cam@mcc.id.au>
2958
2959         Reviewed by Darin Adler.
2960
2961         Fix DumpRenderTree build from clean tree on Tiger
2962         https://bugs.webkit.org/show_bug.cgi?id=28927
2963
2964         * DumpRenderTree/mac/PerlSupport/Makefile: Ensure the
2965         DerivedSources/DumpRenderTree directory exists when
2966         building on Tiger.
2967
2968 2009-09-08  Kevin Ollivier  <kevino@theolliviers.com>
2969
2970         wx build fix after introduction of platform/mock directory.
2971
2972         * wx/build/settings.py:
2973
2974 2009-09-08  Yael Aharon  <yael.aharon@nokia.com>
2975
2976         Unreviewed.
2977
2978         Add myself to list of committers.
2979
2980         * Scripts/modules/committers.py:
2981
2982 2009-09-08  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2983
2984         Unreviewed.
2985
2986         Add myself to list of committers.
2987
2988         * Scripts/modules/committers.py:
2989
2990 2009-09-08  Cameron McCormack  <cam@mcc.id.au>
2991
2992         Reviewed by Darin Adler.
2993
2994         prepare-ChangeLog too chatty on file additions
2995         https://bugs.webkit.org/show_bug.cgi?id=29019
2996
2997         * Scripts/prepare-ChangeLog: Omit description of added properties
2998         on newly added files.
2999
3000 2009-09-08  Steve Block  <steveblock@google.com>
3001
3002         Reviewed by Adam Barth.
3003
3004         Adds a LayoutTestController method to set the permission state for Geolocation.
3005         This is required to use the mock Geolocation service for testing.
3006         https://bugs.webkit.org/show_bug.cgi?id=29027
3007
3008         * DumpRenderTree/LayoutTestController.cpp: Modified.
3009         (setDatabaseQuotaCallback): Modified. Style fix.
3010         (setGeolocationPermissionCallback): Added. Sets the Geolocation permission state.
3011         (LayoutTestController::staticFunctions): Modified. Registers the above function on the LayoutTestController.
3012         * DumpRenderTree/LayoutTestController.h: Modified.
3013         (LayoutTestController::setGeolocationPermission): Added. Sets the Geolocation permission state.
3014         (LayoutTestController::isGeolocationPermissionSet): Added. Returns whether the Geolocation permission has been set.
3015         (LayoutTestController::geolocationPermission): Added. Returns the Geolocation permission state.
3016         * DumpRenderTree/mac/UIDelegate.mm: Modified.
3017         (-[UIDelegate webView:frame:requestGeolocationPermission:securityOrigin:]): Added. Implement chrome method to respond to request for Geolocation permission state. Response is made using above methods to access permission state.
3018
3019 2009-09-08  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3020
3021         Reviewed by Simon Hausmann.
3022
3023         [Qt] QtWebKit single API to enable persistency
3024         https://bugs.webkit.org/show_bug.cgi?id=28682
3025
3026         Use the new enablePersistentStorage API instead 
3027         of enabling all persistent features one-by-one.
3028
3029         * DumpRenderTree/qt/DumpRenderTree.cpp:
3030         (WebCore::WebPage::WebPage):
3031         (WebCore::DumpRenderTree::DumpRenderTree):
3032
3033 2009-09-07  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3034
3035         Reviewed by Tor Arne Vestbø.
3036
3037         Refactor --strict switch to --ignore-metrics and correct the
3038         implementation to make the feature usable on all platforms.
3039         https://bugs.webkit.org/show_bug.cgi?id=28907
3040
3041         run-webkit-tests --ignore-metrics strips the font related metrics from
3042         the actual and expected data before comparing them.
3043         In this way the render trees can be checked for obvious differences but
3044         a successful test implies by no means that the layout is actually correct.
3045
3046         * Scripts/run-webkit-tests:
3047
3048 2009-09-07  Steve Block  <steveblock@google.com>
3049
3050         Reviewed by Adam Barth.
3051
3052         Adds a mock Geolocation service. This will be used to provide predictable behavior of the
3053         Geolocation API for use in LayoutTests. Later changes will integrate the the mock
3054         Geolocation service with DumpRenderTree.
3055         https://bugs.webkit.org/show_bug.cgi?id=28264
3056
3057         * DumpRenderTree/LayoutTestController.cpp: Modified.
3058         (setMockGeolocationPositionCallback): Added. Configures the mock Geolocation service.
3059         (setMockGeolocationErrorCallback): Added. Configures the mock Geolocation service.
3060         (LayoutTestController::staticFunctions): Added. Registers the above functions on the LayoutTestController.
3061         * DumpRenderTree/LayoutTestController.h: Modified.
3062         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Modified.
3063         (LayoutTestController::setMockGeolocationPosition): Added. Configures the mock Geolocation service.
3064         (LayoutTestController::setMockGeolocationError): Added. Configures the mock Geolocation service.
3065
3066 2009-09-07  Drew Wilson  <atwilson@google.com>
3067
3068         Reviewed by David Levin.
3069
3070         Enable SHARED_WORKERS by default
3071         https://bugs.webkit.org/show_bug.cgi?id=28959
3072
3073         * Scripts/build-webkit:
3074
3075 2009-09-07  Kevin Ollivier  <kevino@theolliviers.com>
3076
3077         wx build fixes for wx SVN trunk.
3078
3079         * wx/build/settings.py:
3080
3081 2009-09-04  Kevin Ollivier  <kevino@theolliviers.com>
3082
3083         wx build fix. Switch USE_ defines over to the compiler so that they can be
3084         checked by files not including config.h (like WebCorePrefix.h).
3085
3086         * wx/build/settings.py:
3087
3088 2009-09-04  Adam Barth  <abarth@webkit.org>
3089
3090         Unreviewed build fix.
3091
3092         Update declaration of FrameLoadDelegate to reflect that
3093         IWebFrameLoadDelegatePrivate2 inherits from
3094         IWebFrameLoadDelegatePrivate.
3095
3096         * DumpRenderTree/win/FrameLoadDelegate.h:
3097
3098 2009-09-04  Adam Barth  <abarth@webkit.org>
3099
3100         Reviewed by Eric Seidel.
3101
3102         https://bugs.webkit.org/show_bug.cgi?id=24696
3103
3104         Add testing instrumentation for mixed content.
3105
3106         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3107         (-[FrameLoadDelegate webView:]):
3108         (-[FrameLoadDelegate webView:didRunInsecureContent:]):
3109         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3110         (descriptionSuitableForTestResult):
3111         (FrameLoadDelegate::QueryInterface):
3112         (FrameLoadDelegate::didDisplayInsecureContent):
3113         (FrameLoadDelegate::didRunInsecureContent):
3114         * DumpRenderTree/win/FrameLoadDelegate.h:
3115
3116 2009-09-03  Kevin Watters  <kevinwatters@gmail.com>
3117
3118         Reviewed by Kevin Ollivier.
3119
3120         [wx] Frames support
3121         https://bugs.webkit.org/show_bug.cgi?id=19041
3122
3123         * wx/build-wxwebkit:
3124
3125 2009-09-02  David Kilzer  <ddkilzer@apple.com>
3126
3127         <http://webkit.org/b/28880> svn-apply --force doesn't actually work
3128
3129         Reviewed by Eric Seidel.
3130
3131         This fixes "svn-apply --force" and adds unit tests for the
3132         scm.apply_patch() method which uses this script.
3133
3134         * Scripts/svn-apply: Created $globalExitCode variable that
3135         defaults to 0.  Exit with a value of $globalExitCode when the
3136         script is finished.
3137         (applyPatch): Ignore a non-zero $exitCode if $force is true, but
3138         set $globalExitCode to $exitCode so that svn-apply exits with a
3139         non-zero status if any patches did not apply cleanly.  Also
3140         print out the actual patch command if $force was not true.
3141
3142         * Scripts/modules/scm.py:
3143         (scripts_directory): Added.  Extracted from script_path().
3144         (script_path): Extracted scripts_directory().
3145         * Scripts/modules/scm_unittest.py: Import urllib.
3146         (SVNTestRepository.setup): Save the original working directory
3147         in test_object since this represents the WebKit repository from
3148         where the unit tests are run.
3149         (SCMTest): Created new super class to hold utility methods.
3150         (SCMTest._create_patch): Creates a patch file on disk and a
3151         dictionary for use with scm.svn_apply().
3152         (SCMTest._setup_webkittools_scripts_symlink): Sets up a symlink
3153         back to WebKitTools/Scripts in the test repository so that
3154         scm.apply_patch() is able to find the svn-apply script.
3155         (SVNTest): Inherit from SCMTest instead of unittest.TestCase.
3156         (SVNTest.tearDown): Make sure to change directories back to the
3157         original_path before the next test.
3158         (SVNTest.test_apply_svn_patch): New test case for applying an
3159         svn patch with scm.apply_patch().
3160         (SVNTest.test_apply_svn_patch_force): New test case for applying
3161         an svn patch with scm.apply_patch() that conflicts.
3162         (GitTest): Inherit from SCMTest instead of unittest.TestCase.
3163         (GitTest.tearDown): Make sure to change directories back to the
3164         original_path before the next test.
3165         (GitTest.test_apply_git_patch): New test case for applying a git
3166         patch with scm.apply_patch().
3167         (GitTest.test_apply_git_patch_force): New test case for applying
3168         a git patch with scm.apply_patch() that conflicts.
3169
3170 2009-09-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3171
3172         Reviewed by Mark Rowe.
3173
3174         [Qt] Add support for platform-spesific layout-test results
3175
3176         For the Qt port we use the qt-[mac|linux|win] directories and then fall
3177         back to the generic qt directory for both test results and skipped list.
3178
3179         * Scripts/run-webkit-tests:
3180         * Scripts/webkitdirs.pm:
3181
3182 2009-09-02  Laurent Cerveau  <lcerveau@me.com>
3183
3184         Reviewed by David Kilzer.
3185
3186         <http://webkit.org/b/25517> build-webkit script should print build time at end
3187
3188         * Scripts/build-webkit:
3189         Added startTime and endTime variable so that the build time is computed and printed as
3190         part of the build message; display formatting has been separated in a dedicated subroutine.
3191
3192 2009-09-02  David Kilzer  <ddkilzer@apple.com>
3193
3194         <http://webkit.org/b/28881> svn-create-patch should check if the repo path is the same when trying to find the root
3195
3196         Reviewed by Eric Seidel.
3197
3198         * Scripts/VCSUtils.pm:
3199         (determineSvnRoot): Added back check for repository root that
3200         was removed in r46134 when this code lived in svn-create-patch.
3201         It's necessary to check both the repository root and the
3202         repository UUID in case two different working directories are
3203         checked out from the same repository.
3204
3205 2009-09-02  Timothy Hatcher  <timothy@apple.com>
3206
3207         Use new 512x512 icons for nightly builds.
3208
3209         Rubber-stamped by Mark Rowe.
3210
3211         * WebKitLauncher/webkit.icns:
3212
3213 2009-09-02  Kevin Ollivier  <kevino@theolliviers.com>
3214
3215         waf build fix. Remove local variable shadowing global.
3216
3217         * wx/build/settings.py:
3218
3219 2009-09-02  Zan Dobersek  <zandobersek@gmail.com>
3220
3221         Reviewed by David Kilzer.
3222
3223         Calls exitStatus function from the main package where it is also defined.
3224
3225         * Scripts/VCSUtils.pm:
3226
3227 2009-09-02  Kevin Ollivier  <kevino@theolliviers.com>
3228
3229         waf build fixes for Windows/MSVC and Mac/Snow Leopard.
3230
3231         * wx/browser/wscript:
3232         * wx/build/build_utils.py:
3233         * wx/build/settings.py:
3234
3235 2009-08-10  Kevin Ollivier  <kevino@theolliviers.com>
3236
3237         Reviewed by Eric Seidel.
3238
3239         Changes needed for build-webkit to support the waf build system for the wx port.
3240         
3241         https://bugs.webkit.org/show_bug.cgi?id=27619
3242
3243         * Scripts/build-webkit:
3244         * Scripts/run-launcher:
3245         * Scripts/webkitdirs.pm:
3246
3247 2009-09-02  David Kilzer  <ddkilzer@apple.com>
3248
3249         <http://webkit.org/b/27168> With Subversion 1.6, update-webkit prompts on conflicts
3250
3251         Reviewed by Eric Seidel.
3252
3253         * Scripts/update-webkit: Added "--accept postpone" to
3254         @svnOptions when running with svn-1.6 or newer.
3255
3256 2009-09-02  David Kilzer  <ddkilzer@apple.com>
3257
3258         Moved svn 1.6 version check into VCSUtils::isSVNVersion16OrNewer()
3259
3260         Reviewed by Eric Seidel.
3261
3262         * Scripts/VCSUtils.pm:
3263         (@EXPORT): Added &isSVNVersion16OrNewer.
3264         (svnVersion): Added.  Internal method that gets the SVN version
3265         and caches it.
3266         (isSVNVersion16OrNewer): Added.  Method that does the SVN 1.6
3267         version check.
3268         * Scripts/prepare-ChangeLog: Switched to use new
3269         isSVNVersion16OrNewer() method.
3270         * Scripts/resolve-ChangeLogs: Ditto.
3271         * Scripts/svn-create-patch: Ditto.
3272
3273 2009-09-02  David Kilzer  <ddkilzer@apple.com>
3274
3275         Clean up VCSUtils.pm
3276
3277         Reviewed by Eric Seidel.
3278
3279         * Scripts/VCSUtils.pm: Added proper package statement.  Fixed
3280         indentation of BEGIN block.  Listed each exported method on a
3281         line by itself.  Added methods to the export list after adding
3282         the package statement.  Sorted module variables.  Moved
3283         definiton of $gitRoot next to other module variables.
3284
3285 2009-09-01  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3286
3287         Rubber-stamped by Simon Hausmann.
3288
3289         [Qt] Fix layout-test plugins/plugin-javascript-access.html
3290
3291         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3292
3293 2009-09-02  Shinichiro Hamaji  <hamaji@chromium.org>
3294
3295         Reviewed by Eric Seidel.
3296
3297         js tests should move into jstests subdirectory instead of resources/
3298         https://bugs.webkit.org/show_bug.cgi?id=25880
3299
3300         make-script-wrappers supports both resources and script-tests directories.
3301         run-webkit-tests ignores files in script-tests.
3302         Move script tests of animations to check the new script is working.
3303
3304         * Scripts/make-script-test-wrappers:
3305         * Scripts/run-webkit-tests:
3306
3307 2009-09-02  Szabo Carol  <carol.szabo@nokia.com>
3308
3309         Reviewed by David Levin.
3310
3311         check-webkit-style uses python from /usr/bin instead of the PATH
3312         https://bugs.webkit.org/show_bug.cgi?id=28225
3313
3314         * Scripts/bugzilla-tool:
3315         * Scripts/check-webkit-style:
3316         * Scripts/run-webkit-unittests:
3317         * Scripts/update-sources-list.py:
3318           Changed the first line from
3319           #!/usr/bin/python
3320           to
3321           #!/usr/bin/env python
3322           which causes python to be invoked from the path location returned
3323           by "which python" when any of these scripts are launched.
3324           these are currently all the python scripts in WebKitTools/Scripts.
3325
3326 2009-09-01  David Kilzer  <ddkilzer@apple.com>
3327
3328         <http://webkit.org/b/28601> bugzilla-tool post-commits posts commits backwards
3329
3330         Reviewed by Adam Barth.
3331
3332         * Scripts/modules/scm.py:
3333         (Git.commit_ids_from_commitish_arguments): Reverse the list of
3334         commits returned from git-rev-list since we always want to post
3335         the oldest patches first to bugs.webkit.org.
3336         * Scripts/modules/scm_unittest.py:
3337         (run): Added return statement to return the output now that we
3338         want it sometimes.
3339         (SVNTestRepository._setup_test_commits): Added a fourth commit
3340         so the GitTest.test_commitish_order() test has more commits to
3341         work with.
3342         (GitTest.test_commitish_order): Added unit test for change to
3343         Git.commit_ids_from_commitish_arguments() in scm.py.
3344
3345 2009-09-01  David Kilzer  <ddkilzer@apple.com>
3346
3347         <http://webkit.org/b/28877> Implement bugzilla-tool mark-fixed
3348
3349         Reviewed by David Levin.
3350
3351         The mark-fixed subcommand is for those times when you don't use
3352         bugzilla-tool to commit a patch, but you want to use it to close
3353         the bug with a committed-revision message.
3354
3355         * Scripts/bugzilla-tool:
3356         (bug_comment_from_svn_revision): Added.  Extracted from
3357         bug_comment_from_commit_text().
3358         (bug_comment_from_commit_text): Extracted
3359         bug_comment_from_svn_revision() from this method.
3360         (MarkBugFixed.__init__): Added.
3361         (MarkBugFixed._fetch_commit_log): Added.  Retrieves the commit
3362         log from the last commit if no svn revision is specified, else
3363         the commit log for the specified svn revision.
3364         (MarkBugFixed._determine_bug_id_and_svn_revision): Added.
3365         Attempts to determine the bug id and svn revision if one or both
3366         were not defined on the command line.
3367         (MarkBugFixed.execute): Added.  Adds a comment about the
3368         revision that fixed the bug and closes the bug.
3369         (BugzillaTool.__init__): Added mark-fixed subcommand.
3370         * Scripts/modules/bugzilla.py:
3371         (Bugzilla.fetch_title_from_bug): Added.  Returns the title of a
3372         bug given a bug id.
3373         * Scripts/modules/scm.py:
3374         (SCM.strip_r_from_svn_revision): Added.  Utility method to strip
3375         the leading 'r' from an svn revision.
3376         (SCM.svn_commit_log): Added.  Subclasses must override.
3377         (SCM.last_svn_commit_log): Added.  Subclasses must override.
3378         (SVN.svn_commit_log): Added.  Returns svn log for a given
3379         revision.
3380         (SVN.last_svn_commit_log): Added.  Uses svnversion to find the
3381         last commit in an svn working directory and then runs svn log.
3382         (Git.svn_commit_log): Added.  Returns svn log for a given
3383         revision.
3384         (Git.last_svn_commit_log): Added.  Runs git-svn-log with a limit
3385         of one log message.
3386
3387 2009-09-01  David Kilzer  <ddkilzer@apple.com>
3388
3389         <http://webkit.org/b/28880> svn-apply --force doesn't actually work
3390
3391         Reviewed by Brady Eidson.
3392
3393         * Scripts/svn-apply:
3394         (applyPatch): Add "--force" to $options arrayref if $force is
3395         set.
3396
3397 2009-09-01  David Kilzer  <ddkilzer@apple.com>
3398
3399         <http://webkit.org/b/28725> resolve-ChangeLogs: determineVCSRoot() returns incorrect repository root during git filter-branch
3400
3401         Reviewed by Adam Roben.
3402
3403         When git-filter-branch has been invoked to rewrite ChangeLog
3404         files on series of git commits, it changes directories into
3405         .git-rewrite/t before re-running resolve-ChangeLogs.  This
3406         causes determineVCSRoot() in VCSUtils.pm to return
3407         ".git-rewrite/t", which causes that path to be prepended to all
3408         ChangeLog paths, which results in an error like this:
3409
3410             error: pathspec '.git-rewrite/t/ChangeLog' did not match any file(s) known to git.
3411             Died at WebKitTools/Scripts/resolve-ChangeLogs line 376.
3412
3413         The correct way to fix this is not to try to find the repository
3414         root when invoked by git-filter-branch.
3415
3416         * Scripts/resolve-ChangeLogs: If isInGitFilterBranch() is true,
3417         set $relativePath to '.' instead of calling
3418         chdirReturningRelativePath(determineVCSRoot()).
3419         (isInGitFilterBranch): Added.  Checks for the existence of the
3420         MAPPED_PREVIOUS_COMMIT environment variable.
3421
3422 2009-09-01  Xan Lopez  <xlopez@igalia.com>
3423
3424         Reviewed by Gustavo Noronha.
3425
3426         Add support for Fedora distros in the http tests
3427         https://bugs.webkit.org/show_bug.cgi?id=28263
3428
3429         Add detection code for Fedora distribution, and use the proper
3430         httpd conf file when needed.
3431
3432         * Scripts/run-webkit-httpd:
3433         * Scripts/run-webkit-tests:
3434         * Scripts/webkitdirs.pm:
3435
3436 2009-09-01  Jan Michael Alonzo  <jmalonzo@webkit.org>
3437
3438         Reviewed by Eric Seidel.
3439
3440         [Gtk] DRT needs implementation of overridePreference
3441         https://bugs.webkit.org/show_bug.cgi?id=28830
3442
3443         Implement overridePreference.
3444
3445         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3446         (resetDefaultsToConsistentValues):
3447         (setDefaultsToConsistentStateValuesForTesting):
3448         (runTest):
3449         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3450         (toWebSettingKey):
3451         (LayoutTestController::overridePreference):
3452
3453 2009-09-01  Joseph Pecoraro  <joepeck@webkit.org>
3454
3455         <http://webkit.org/b/28623> svn-[un]apply should change directories to the repository root before [un]applying
3456
3457         Reviewed by Eric Seidel.
3458
3459         Jump back and forth between the repository root directory (to apply) and the
3460         directory the script was run from (to find the patch).
3461
3462         * Scripts/svn-apply:
3463         * Scripts/svn-unapply:
3464
3465 2009-08-31  Adam Roben  <aroben@apple.com>
3466
3467         Fall back to a Release version of Safari if a Debug one doesn't exist
3468
3469         <http://webkit.org/b/28849>
3470
3471         Reviewed by Sam Weinig.
3472
3473         * Scripts/webkitdirs.pm:
3474         (safariPath): If the user is working with a Debug build, but there's
3475         no Debug version of Safari present, fall back to using a Release
3476         version of Safari.
3477
3478 2009-08-31  Adam Roben  <aroben@apple.com>
3479
3480         Make safariPath() work for Debug builds of Safari on Windows
3481
3482         <http://webkit.org/b/28849>
3483
3484         Reviewed by Sam Weinig.
3485
3486         * Scripts/webkitdirs.pm:
3487         (safariPath): If the user is working with a Debug build, add the
3488         _debug suffix to Safari.exe.
3489
3490 2009-08-28  Eric Seidel  <eric@webkit.org>
3491
3492         Reviewed by Adam Barth.
3493
3494         commit-queue needs a master process
3495         https://bugs.webkit.org/show_bug.cgi?id=28040
3496
3497         Add a bugzilla-tool commit-queue command
3498         Keeps per-bug logs, but doesn't yet upload them anywhere.
3499
3500         * Scripts/bugzilla-tool: Add LandPatchesFromCommitQueue to handle 'commit-queue'
3501         * Scripts/modules/buildbot.py: remove noisy log message
3502         * Scripts/modules/logging.py: add a 'tee()' call for splitting outputs in python
3503
3504 2009-08-28  Jan Michael Alonzo  <jmalonzo@webkit.org>
3505
3506         Reviewed by Gustavo Noronha.
3507
3508         [GTK] Geolocation needs permission API before being enabled by default
3509
3510         Build the Gtk port with geolocation enabled. This option is only
3511         enabled for the buildbot. The autotools option will be enabled by
3512         default once the permissions API is implemented.
3513
3514         * Scripts/build-webkit:
3515
3516 2009-08-26  Cameron McCormack  <cam@mcc.id.au>
3517
3518         Reviewed by David Kilzer.
3519
3520         Make prepare-ChangeLog notice property changes
3521         https://bugs.webkit.org/show_bug.cgi?id=28675
3522
3523         Make the generated ChangeLog entry include a short description of
3524         property changes if there were such changes.  Also make
3525         prepare-ChangeLog not bail if the only changes are property changes.
3526
3527         * Scripts/prepare-ChangeLog:
3528
3529 2009-08-26  Adam Barth  <abarth@webkit.org>
3530
3531         Reviewed by Oliver Hunt.
3532
3533         Don't let local files access web URLs
3534         https://bugs.webkit.org/show_bug.cgi?id=28480
3535
3536         A bunch of our LayoutTests rely on our old behavior, so we explicitly
3537         grant local files universal access during testing.  Mainly, these tests
3538         involve making XMLHttpRequests for data URLs.
3539
3540         * DumpRenderTree/mac/DumpRenderTree.mm:
3541         (resetDefaultsToConsistentValues):
3542         * DumpRenderTree/qt/DumpRenderTree.cpp:
3543         (WebCore::WebPage::WebPage):
3544         * DumpRenderTree/win/DumpRenderTree.cpp:
3545         (resetDefaultsToConsistentValues):
3546
3547 2009-08-26  John Gregg  <johnnyg@google.com>
3548
3549         Reviewed by David Levin.
3550
3551         Minor style correction and include fix for notifications
3552         https://bugs.webkit.org/show_bug.cgi?id=28745
3553
3554         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
3555           change to correct EnumStyle
3556         (DRTDesktopNotificationPresenter::checkNotificationPermission):
3557
3558 2009-08-26  David Levin  <levin@chromium.org>
3559
3560         Reviewed by Alexey Proskuryakov.
3561
3562         XMLHttpRequest.withCredentials=false shouldn't save cookies.
3563         https://bugs.webkit.org/show_bug.cgi?id=28743
3564
3565         Added the support to the layout test controller on OSX and
3566         Windows (for CFNETWORK) to allow for changing the accept cookie
3567         policy.
3568
3569         * DumpRenderTree/LayoutTestController.cpp:
3570         (LayoutTestController::LayoutTestController): Added a bool
3571         to track the state of accepting cookies.
3572         (setAlwaysAcceptCookiesCallback): Standard wrapper method
3573         to go from js to a C++ method.
3574         (LayoutTestController::staticFunctions): Added the
3575         setAlwaysAcceptCookies method to the js layoutTestController.
3576         * DumpRenderTree/LayoutTestController.h:
3577         (LayoutTestController::alwaysAcceptCookies): Returns the value.
3578         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3579         (LayoutTestController::setAlwaysAcceptCookies): Stub out method.
3580         * DumpRenderTree/mac/DumpRenderTree.mm:
3581         (resetDefaultsToConsistentValues): Reset the accept cookie to
3582         its default.
3583         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3584         (LayoutTestController::setAlwaysAcceptCookies): Does the work for
3585         OSX to change the cookie accept policy.
3586         * DumpRenderTree/win/DumpRenderTree.cpp:
3587         (setAlwaysAcceptCookies): Method to handle all the calls necessary
3588         to change the accept cookie policy on Windows.
3589         (resetDefaultsToConsistentValues): Reset the accept cookie to
3590         its default.
3591         * DumpRenderTree/win/DumpRenderTreeWin.h:
3592         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3593         (LayoutTestController::setAlwaysAcceptCookies): Stub out method.
3594         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3595         (LayoutTestController::setAlwaysAcceptCookies): Stub out method.
3596
3597 2009-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
3598
3599         Unreviewed.
3600
3601         Remove accidentally left in clobber option.
3602         https://bugs.webkit.org/show_bug.cgi?id=28400
3603
3604         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed clobber option.
3605
3606 2009-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
3607
3608         Reviewed by Mark Rowe.
3609
3610         Add canary-style Chromium WebKit build slave to the waterfall.
3611         https://bugs.webkit.org/show_bug.cgi?id=28400
3612
3613         * BuildSlaveSupport/build.webkit.org-config/config.json: Added one Chromium/Windows slave
3614         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added support for Chromium slave commands.
3615
3616 2009-08-25  Cameron McCormack  <cam@mcc.id.au>
3617
3618         Reviewed by Darin Adler.
3619
3620         make-script-test-wrappers should be executable
3621         https://bugs.webkit.org/show_bug.cgi?id=28669
3622
3623         Make make-script-test-wrappers and update-sources-list.py both be
3624         executable.
3625
3626         * Scripts/update-sources-list.py:
3627         * Scripts/make-script-test-wrappers:
3628
3629 2009-08-25  Brent Fulgham  <bfulgham@webkit.org>
3630
3631         Build fix
3632
3633         Revise Debug_Cairo targets to point inherit from the 
3634         debug_wincairo.vsprops property sheet so that they link
3635         against the proper libraries in Debug build.
3636
3637         * DumpRenderTree/win/DumpRenderTree.vcproj:
3638         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3639         * WinLauncher/WinLauncher.vcproj:
3640
3641 2009-08-25  David Levin  <levin@chromium.org>
3642
3643         Reviewed by Adam Roben.
3644
3645         PLATFORM(CFNETWORK) should be USE(CFNETWORK).
3646         https://bugs.webkit.org/show_bug.cgi?id=28713
3647
3648         * DumpRenderTree/win/DumpRenderTree.cpp:
3649         (main):
3650
3651 2009-08-25  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3652
3653         Reviewed by Ariya Hidayat.
3654
3655         [Qt/Mac]&nb