2009-11-03 Yuzo Fujishima <yuzo@google.com>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
2
3         Reviewed by David Levin.
4
5         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
6         https://bugs.webkit.org/show_bug.cgi?id=27491
7
8         The test path determination logic is changed to handle websocket and websocket/ssl cases.
9         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
10
11         Functions to start or stop Web Socket servers are added.
12
13         * Scripts/run-webkit-tests:
14
15 2009-11-03  Eric Seidel  <eric@webkit.org>
16
17         No review, just changing wording of log message.
18
19         Change log string to say "failed" instead of "rejected"
20         when a commit fails due to an out of date checkout.
21         This makes grepping the commit-queue log for rejected patches easier.
22
23         * Scripts/bugzilla-tool:
24
25 2009-11-03  Eric Seidel  <eric@webkit.org>
26
27         No review, adding commonly known committers missing from the file.
28
29         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
30
31 2009-11-03  Eric Seidel  <eric@webkit.org>
32
33         No review, just sort-order cleanup.
34
35         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
36
37 2009-11-03  Stephen White  <senorblanco@chromium.org>
38
39         (Unreviewed).
40
41         Add myself to committers.py.
42
43         * Scripts/modules/committers.py:
44
45 2009-11-03  Robin Dunn  <robin@alldunn.com>
46
47         Reviewed by Kevin Ollviier.
48
49         Add packaging scripts for Debian-based Linux distros.
50         
51         https://bugs.webkit.org/show_bug.cgi?id=31075
52
53         * wx/packaging/build-debian-installer.py: Added.
54         * wx/packaging/debian: Added.
55
56 2009-11-03  Dan Bernstein  <mitz@apple.com>
57
58         Reviewed by Anders Carlsson and Beth Dakin.
59
60         https://bugs.webkit.org/show_bug.cgi?id=31070
61
62         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
63         destroyed, it executes the value of the 'ondestroy' parameter as a
64         script.
65
66         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
67         (pluginAllocate): Initialize onDestroy.
68         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
69         onDestroy.
70         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
71         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
72         specified.
73         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
74
75 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
76
77         Reviewed by Xan Lopez.
78
79         https://bugs.webkit.org/show_bug.cgi?id=31035
80         [GTK] some accessibility tests hitting assertion in debug builds
81
82         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
83
84         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
85         (AccessibilityController::rootElement):
86
87 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
88
89         Reviewed by Beth Dakin.
90
91         Support ARIA "tab" roles
92         https://bugs.webkit.org/show_bug.cgi?id=30842
93
94         * DumpRenderTree/AccessibilityUIElement.cpp:
95         * DumpRenderTree/AccessibilityUIElement.h:
96         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
97         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
98         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
99
100 2009-11-01  Eric Seidel  <eric@webkit.org>
101
102         Reviewed by David Levin.
103
104         buildbots should use --exit-after-N-failures
105         https://bugs.webkit.org/show_bug.cgi?id=30809
106
107         Make the bots exit after 20 failures to prevent never-ending
108         test runs where every test spends a minute crashing.
109
110         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
111
112 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
113
114         Reviewed by Eric Seidel.
115
116         Turn on warnings for QtWebKit for gcc
117         https://bugs.webkit.org/show_bug.cgi?id=30958
118
119         * DumpRenderTree/qt/main.cpp: 
120         (crashHandler): Mark function NO_RETURN
121
122 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
123
124         Adding myself to the committers list.
125
126         * Scripts/modules/committers.py:
127
128 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
129
130         Fix an issue that Adam noticed in DRT.
131
132         Reviewed by Darin Adler.
133
134         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
135         (AccessibilityUIElement::role):
136         Get the length of the role text, and create a buffer dynamically.
137
138 2009-10-30  Eric Seidel  <eric@webkit.org>
139
140         No review, rolling out r50105.
141         http://trac.webkit.org/changeset/50105
142
143         This commit was causing:
144         https://bugs.webkit.org/show_bug.cgi?id=30869
145         We'll re-implement the feature a different way.
146
147         * Scripts/bugzilla-tool:
148
149 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
150
151         Test for MSAA: Accessibility of headings is not correct
152
153         https://bugs.webkit.org/show_bug.cgi?id=30937
154
155         Reviewed by Adam Roben.
156
157         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
158         (AccessibilityUIElement::role):
159         Allow the role returned to be a BSTR.
160         (AccessibilityUIElement::description):
161         Fix a copy/paste error.
162
163 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
164
165         Test for MSAA: Accessibility of links is wrong
166
167         https://bugs.webkit.org/show_bug.cgi?id=30928
168
169         Reviewed by Darin Adler.
170
171         * DumpRenderTree/AccessibilityUIElement.cpp:
172         (getAccessibilityValueCallback):
173         Return the accessibility value.
174         (AccessibilityUIElement::getJSClass):
175         Added "accessibilityValue" value.
176
177         * DumpRenderTree/AccessibilityUIElement.h:
178
179         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
180         (AccessibilityUIElement::accessibilityValue):
181         Stubbed.
182
183         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
184         (AccessibilityUIElement::accessibilityValue):
185         Stubbed.
186
187         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
188         (AccessibilityUIElement::accessibilityValue):
189         Get the object's value, and return it as a JS string.
190
191 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
192
193         Fix typo in command name used by wx build system.
194
195         * wx/build/build_utils.py:
196
197 2009-10-30  Adam Barth  <abarth@webkit.org>
198
199         Reviewed by Darin Adler.
200
201         Patch v1 is a dumb default name for patches
202         https://bugs.webkit.org/show_bug.cgi?id=30952
203
204         Let's use "Patch" instead.
205
206         * Scripts/bugzilla-tool:
207
208 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
209
210         Unreviewed trivial buildfix.
211
212         [Qt] Buildfix for r50333.
213
214         * DumpRenderTree/qt/DumpRenderTree.pro:
215
216 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
217
218         Reviewed by Holger Freyther.
219
220         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
221         https://bugs.webkit.org/show_bug.cgi?id=30953
222
223         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
224         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
225         makes qt DRT to share this implementation (as gtk and mac ports do).
226
227         * DumpRenderTree/qt/DumpRenderTree.pro:
228         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
229         * DumpRenderTree/qt/WorkQueue.h: Removed.
230
231 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
232
233         Unreviewed potential buildbot fix.
234
235         Second try: Reset page history before running each test.
236
237         Apparently the QWebHistory::clear() keeps the current page
238         in history which is not what we want, so we not additionally
239         sets the history capacity to 0 (forces removing everything)
240         and then sets it back to its original value.
241
242         * DumpRenderTree/qt/DumpRenderTree.cpp:
243         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
244
245 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
246
247         Unreviewed potential buildbot fix.
248
249         Reset page history before running each test.
250
251         * DumpRenderTree/qt/DumpRenderTree.cpp:
252         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
253
254 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
255
256         Reviewed by Eric Seidel.
257
258         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
259
260         Bug 28420 -  Implement HTML5 <ruby> rendering
261         (https://bugs.webkit.org/show_bug.cgi?id=28420)
262
263         No new tests (no functional change).
264
265         * Scripts/build-webkit:
266
267 2009-10-29  Dan Bernstein  <mitz@apple.com>
268
269         Reviewed by Mark Rowe.
270
271         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
272         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
273         define it.
274
275         * Scripts/VCSUtils.pm:
276         * Scripts/svn-apply:
277         * Scripts/svn-unapply:
278
279 2009-10-29  Xan Lopez  <xlopez@igalia.com>
280
281         Reviewed by Gustavo Noronha.
282
283         Use the GTK+ main loop instead of rolling our own mini-version of
284         it.
285
286         * DumpRenderTree/gtk/DumpRenderTree.cpp:
287         (dump):
288         (runTest):
289         (webViewLoadFinished):
290
291 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
292
293         Reviewed by Oliver Hunt.
294
295         Implement the Qt version of DRT dumpBackForwardList().
296
297         * DumpRenderTree/qt/DumpRenderTree.cpp:
298         (WebCore::dumpHistoryItem):
299         (WebCore::DumpRenderTree::dumpBackForwardList):
300
301 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
302
303         Reviewed by Adam Roben.
304
305         Implement DRT functionality for Qt introduced in
306         r28690 and r28705.
307
308         - Implemented pathToLocalResource which exposes the functionality of
309         converting a given unix path to the correct location on Windows.
310         - Implemented a way to remove machine-dependent information from paths
311         in layout test results.
312
313         * DumpRenderTree/qt/DumpRenderTree.cpp:
314         (WebCore::urlSuitableForTestResult):
315         (WebCore::WebPage::javaScriptConsoleMessage):
316         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
317         (LayoutTestController::pathToLocalResource):
318         * DumpRenderTree/qt/LayoutTestControllerQt.h:
319
320 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
321
322         Adding myself to the committers list.
323
324         * Scripts/modules/committers.py:
325
326 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
327
328         Adding myself to the committers list.
329
330         * Scripts/modules/committers.py:
331
332 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
333
334         Reviewed by Jan Alonzo.
335
336         [GTK] API to start inspector for a WebView
337         https://bugs.webkit.org/show_bug.cgi?id=22551
338
339         Use the new inspector API to implement the LayoutTestController
340         interfaces used to test the inspector.
341
342         * DumpRenderTree/gtk/DumpRenderTree.cpp:
343         (webInspectorInspectWebView):
344         (createWebView):
345         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
346         (LayoutTestController::showWebInspector):
347         (LayoutTestController::closeWebInspector):
348         (LayoutTestController::evaluateInWebInspector):
349
350 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
351
352         Reviewed by Eric Seidel.
353
354         [Qt] WebFrame::counterValueForElementById must not be exposed
355         https://bugs.webkit.org/show_bug.cgi?id=30882
356
357         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
358         (LayoutTestController::counterValueForElementById):
359
360 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
361
362         Rubberstamped by Oliver Hunt.
363
364         Fix the warning:
365
366         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
367         declared with attribute warn_unused_result".
368
369         by actually checking the result. In the case it is null, an
370         error has occoured, so treat it as the other fatal errors.
371
372         * DumpRenderTree/qt/DumpRenderTree.cpp:
373         (WebCore::DumpRenderTree::initializeFonts):
374
375 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
376
377         Reviewed by Darin Adler.
378
379         Provide a way to get counter values with layoutTestContoller
380         https://bugs.webkit.org/show_bug.cgi?id=30555
381
382         Define layoutTestContoller.counterValueForElementById.
383
384         * DumpRenderTree/LayoutTestController.cpp:
385         (counterValueForElementByIdCallback):
386         (LayoutTestController::staticFunctions):
387         * DumpRenderTree/LayoutTestController.h:
388         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
389         (LayoutTestController::counterValueForElementById):
390
391 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
392
393         Rubberstamped by Oliver Hunt.
394
395         Change two methods to be internal for DRT use only.
396
397         Part of [Qt] Review all new API in Qt 4.6
398         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
399
400         * DumpRenderTree/qt/DumpRenderTree.cpp:
401         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
402         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
403         (LayoutTestController::whiteListAccessFromOrigin):
404
405 2009-10-27  Eric Seidel  <eric@webkit.org>
406
407         Reviewed by Adam Barth.
408
409         REGRESSION: svn-apply exits(1) when applying a patch with a file add
410         https://bugs.webkit.org/show_bug.cgi?id=30826
411
412         * Scripts/svn-apply:
413          - Add () around all system() calls.
414          - Use the correct system() == 0 or die instead of system() or die
415          - Add descriptive messages to all die statements.
416
417 2009-10-27  Steve Block  <steveblock@google.com>
418
419         Reviewed by NOBODY.
420
421         Adds steveblock@google.com to list of committers.
422
423         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
424
425 2009-10-27  Eric Seidel  <eric@webkit.org>
426
427         Reviewed by Adam Barth.
428
429         svn-apply can exit(0) even on patch failure
430         https://bugs.webkit.org/show_bug.cgi?id=29622
431
432         * Scripts/svn-apply:
433          - Add a bunch of "or die" statements, hopefully catching all
434            possible cases where failure could still exit(0).
435
436 2009-10-27  Eric Seidel  <eric@webkit.org>
437
438         Reviewed by Adam Barth.
439
440         svn-* scripts should share code through VCSUtils.pm
441         https://bugs.webkit.org/show_bug.cgi?id=30791
442
443         Just moving code into a shared location.
444
445         * Scripts/VCSUtils.pm:
446         * Scripts/prepare-ChangeLog:
447         * Scripts/resolve-ChangeLogs:
448         * Scripts/svn-apply:
449         * Scripts/svn-create-patch:
450         * Scripts/svn-unapply:
451         * Scripts/update-webkit:
452
453 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
454
455         Suppress a huge number of MSVC warnings when building wxWebKit.
456
457         * wx/build/settings.py:
458
459 2009-10-26  Eric Seidel  <eric@webkit.org>
460
461         No review, just adding Mike Belshe to the committers list.
462
463         * Scripts/modules/committers.py:
464
465 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
466
467         Reviewed by Darin Adler.
468
469         Make .rc files compile on Windows without depending on MFC headers
470         https://bugs.webkit.org/show_bug.cgi?id=30750
471
472         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
473         windows.h instead of afxres.h because it exists even when MFC is not 
474         installed, and is all that's needed here.
475
476         * FindSafari/FindSafari.rc: Ditto
477
478 2009-10-24  Eric Seidel  <eric@webkit.org>
479
480         Reviewed by Adam Barth.
481
482         bugzilla-tool post-diff should know how to mark commit-queue=?
483         https://bugs.webkit.org/show_bug.cgi?id=29202
484
485         * Scripts/bugzilla-tool:
486          - Add --commit-queue option to post-diff, post-commits and create-bug.
487         * Scripts/modules/bugzilla.py:
488          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
489          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
490
491 2009-10-23  Eric Seidel  <eric@webkit.org>
492
493         Reviewed by Adam Barth.
494
495         bugzilla-tool commit-queue does not notice modifications to committers.py
496         https://bugs.webkit.org/show_bug.cgi?id=30084
497
498         * Scripts/bugzilla-tool:
499          - Make commit-queue re-exec itself instead of using while(1).
500          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
501          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
502
503 2009-10-22  Eric Seidel  <eric@webkit.org>
504
505         Reviewed by Adam Barth.
506
507         commit-queue will get stuck on patches if land-patches terminates unexpectedly
508         https://bugs.webkit.org/show_bug.cgi?id=30634
509
510         * Scripts/bugzilla-tool:
511          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
512          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
513
514 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
515
516         Reviewed by Eric Seidel.
517
518         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
519
520         https://bugs.webkit.org/show_bug.cgi?id=30763
521
522         * pywebsocket/mod_pywebsocket/__init__.py:
523         * pywebsocket/mod_pywebsocket/dispatch.py:
524         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
525         * pywebsocket/mod_pywebsocket/standalone.py:
526         * pywebsocket/setup.py:
527         * pywebsocket/test/test_dispatch.py:
528
529 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
530
531         Reviewed by David Levin.
532
533         REGRESSION: 2 failures in run-webkit-unittests
534         https://bugs.webkit.org/show_bug.cgi?id=30645
535
536         * Scripts/modules/cpp_style_unittest.py:
537         Fixed a few test scenarios which apparently lost some spaces from 
538         text literals.
539
540 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
541
542         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
543
544         * Scripts/webkitdirs.pm:
545
546 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
547
548         Reviewed by Darin Adler.
549
550         Unification of using null device in perl scripts.
551         https://bugs.webkit.org/show_bug.cgi?id=30572
552
553         * Scripts/VCSUtils.pm:
554         * Scripts/bisect-builds:
555         * Scripts/resolve-ChangeLogs:
556         * Scripts/run-iexploder-tests:
557         * Scripts/run-jsc:
558         * Scripts/run-mangleme-tests:
559         * Scripts/run-webkit-tests:
560         * Scripts/webkitdirs.pm:
561         Using File::Spec->devnull() instead of hard coded /dev/null.
562
563 2009-10-26  Eric Seidel  <eric@webkit.org>
564
565         Reviewed by Holger Freyther.
566
567         Reviewers are missing from committers.py
568         https://bugs.webkit.org/show_bug.cgi?id=30733
569
570         * Scripts/modules/committers.py:
571
572 2009-10-23  Eric Seidel  <eric@webkit.org>
573
574         No review, only adding Alice to the list of reviewers.
575
576         * Scripts/modules/committers.py:
577
578 2009-10-23  Eric Seidel  <eric@webkit.org>
579
580         Reviewed by Eric Carlson.
581
582         fast/media/mq-transform-02.html failed on Leopard Commit Bot
583         https://bugs.webkit.org/show_bug.cgi?id=30700
584
585         * DumpRenderTree/mac/DumpRenderTree.mm:
586         (resetDefaultsToConsistentValues): Update QuickTime version check.
587
588 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
589
590         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get 
591         character measurement APIs that are private on Tiger.
592
593         * wx/build/settings.py:
594
595 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
596
597         Reviewed by NOBODY (build fix).
598         Build fix following bug #30696.
599
600         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
601         (LayoutTestController::evaluateScriptInIsolatedWorld):
602
603 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
604
605         Reviewed by Sam Weinig & Geoff Garen.
606
607         https://bugs.webkit.org/show_bug.cgi?id=30696
608         Enable isolated-worlds tests on mac.
609
610         Add private interface for DRT to invoke execution in a given world.
611
612         * DumpRenderTree/LayoutTestController.cpp:
613         (evaluateScriptInIsolatedWorldCallback):
614         (LayoutTestController::staticFunctions):
615         * DumpRenderTree/LayoutTestController.h:
616         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
617         (LayoutTestController::evaluateScriptInIsolatedWorld):
618         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
619         (LayoutTestController::evaluateScriptInIsolatedWorld):
620
621 2009-10-21  Eric Seidel  <eric@webkit.org>
622
623         Reviewed by Adam Barth.
624
625         bugzilla-tool's "patch failed to download an apply" error should give more information
626         https://bugs.webkit.org/show_bug.cgi?id=30632
627
628         * Scripts/modules/scm.py:
629          - Use the common run_command method instead of custom POpen code.
630          - Make run_command know how to take pipes as input.
631         * Scripts/modules/scm_unittest.py:
632          - Add new tests to cover change.
633          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
634
635 2009-10-21  Kent Tamura  <tkent@chromium.org>
636
637         Unreviewed.  Adding myself to the committers list.
638
639         * Scripts/modules/committers.py:
640
641 2009-10-21  Robin Dunn  <robin@alldunn.com>
642
643         Reviewed by Kevin Ollivier.
644
645         Update the Windows installer builder to work with Vista / Win 7 and with git.
646         
647         https://bugs.webkit.org/show_bug.cgi?id=30649
648
649         * wx/build/build_utils.py:
650         * wx/packaging/build-mac-installer.py:
651         * wx/packaging/build-win-installer.py:
652         * wx/packaging/wxWebKitInstaller.iss.in:
653
654 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
655
656         Reviewed by Gustavo Noronha.
657
658         [GTK] Added conditional code to avoid using
659         gdk_window_get_root_coords if we do not have a gtk+ release newer
660         than 2.17.3.
661         https://bugs.webkit.org/show_bug.cgi?id=30636
662
663         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
664
665 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
666
667         Reviewed by Eric Seidel.
668
669         [Qt] Added dummy implementation for keepWebHistory()
670         https://bugs.webkit.org/show_bug.cgi?id=30592
671
672         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
673         (LayoutTestController::keepWebHistory):
674         * DumpRenderTree/qt/LayoutTestControllerQt.h:
675
676 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
677
678         Reviewed by Xan Lopez.
679
680         [GTK] Fixed the double click condition, it is not double click if
681         we move in just in one direction.
682         https://bugs.webkit.org/show_bug.cgi?id=30636
683
684         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
685
686 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
687
688         Reviewed by Xan Lopez.
689
690         [GTK] Initialize the events completly before emitting them.
691         https://bugs.webkit.org/show_bug.cgi?id=30633
692
693         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
694
695 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
696
697         wx build fix. Fix for when linking using --as-needed with gcc.
698
699         * wx/browser/wscript:
700
701 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
702
703         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
704         to support all the features used by CURL backend.
705         
706         * wx/build/settings.py:
707         * wx/install-unix-extras:
708
709 2009-10-20  Anton Muhin  <antonm@chromium.org>
710
711         Reviewed by Adam Barth.
712
713         Add {ager,antonm,yurys}@chromium.org into committers.py
714         https://bugs.webkit.org/show_bug.cgi?id=30560
715
716         * Scripts/modules/committers.py:
717
718 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
719
720         Reviewed by Tor Arne Vestbø.
721
722         Make the Netscape Test plugin available to the Qt launcher.
723
724         * Scripts/run-launcher:
725
726 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
727
728         Reviewed by David Levin.
729
730         Removed WebSocket runtime settings.
731         https://bugs.webkit.org/show_bug.cgi?id=29896
732
733         WebSocket runtime configuration is supported by chromium/v8 only.
734
735         * DumpRenderTree/mac/DumpRenderTree.mm:
736         (resetDefaultsToConsistentValues):
737         * DumpRenderTree/win/DumpRenderTree.cpp:
738         (resetDefaultsToConsistentValues):
739
740 2009-10-19  Nate Chapin  <japhet@chromium.org>
741
742         Reviewed by Adam Barth.
743
744         Add testFail() to test plugin so we can test our handling of a
745         plugin invoke call returning false.
746
747         https://bugs.webkit.org/show_bug.cgi?id=30239
748
749         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
750         (pluginInvoke):
751         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
752
753 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
754
755         Reviewed by Gustavo Noronha.
756
757         Enable DOM pasting when running layout tests.
758
759         * DumpRenderTree/gtk/DumpRenderTree.cpp:
760         (resetDefaultsToConsistentValues):
761
762 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
763
764         Reviewed by Simon Hausmann.
765
766         Use the setPreferredContentsSize method instead
767         of setFixedContentsSize, as the method has been renamed.
768
769         * DumpRenderTree/qt/DumpRenderTree.cpp:
770         (WebCore::DumpRenderTree::open):
771         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
772         (LayoutTestController::setFixedContentsSize):
773
774 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
775
776         Reviewed by Dan Bernstein.
777
778         https://bugs.webkit.org/show_bug.cgi?id=30456
779         Fixes for new Debug_All Windows build configuration.
780
781         * DumpRenderTree/win/DumpRenderTree.cpp:
782         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
783         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
784
785 2009-10-16  Eric Seidel  <eric@webkit.org>
786
787         Reviewed by Adam Barth.
788
789         commit-queue status bot should list which buildbot is blocking the queue
790         https://bugs.webkit.org/show_bug.cgi?id=30452
791
792         Add new methods and testing.
793
794         * Scripts/bugzilla-tool:
795         * Scripts/modules/buildbot.py:
796         * Scripts/modules/buildbot_unittest.py:
797
798 2009-10-16  Eric Seidel  <eric@webkit.org>
799
800         Reviewed by Adam Barth.
801
802         run-webkit-tests fails when CWD is not inside a WebKit checkout
803         https://bugs.webkit.org/show_bug.cgi?id=30451
804
805         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
806         * Scripts/modules/scm_unittest.py:
807           - Remove use of original_path (we don't need to restore the CWD).
808           - Don't use '.' to find the webkit checkout, use __file__ instead.
809
810 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
811
812         Reviewed by Adam Roben.
813
814         Add a Debug_All configuration to build entire stack as debug.
815         Change Debug_Internal to:
816         - stop using _debug suffix for all WebKit/Safari binaries
817         - not use _debug as a DLL naming suffix
818         - use non-debug C runtime lib.
819
820         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
821         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
822         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
823         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
824         Add missing debug.vsprops inherited property sheet.
825         Add Debug_All configuration.
826         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
827         * WinLauncher/WinLauncher.vcproj:
828         Removed extraneous definitions inherited from vsprops.
829         Add Debug_All configuration.
830
831 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
832
833         Reviewed by David Levin.
834
835         check-webkit-style is wrong about indent checking in namespaces
836         in header files and a few other things
837         https://bugs.webkit.org/show_bug.cgi?id=30362
838
839         The few other things include:
840         + check-webkit-style does not require spaces around the equal sign
841           inside 'if' statements and around binary operators that take 
842           numeric literals.
843         + check-webkit-style reports false errors for the / operator
844           when part of a filename in the #include directive.
845
846         * Scripts/modules/cpp_style.py:
847         Improved indentation checking and space checking around
848         binary operators. While the checks are still not perfect,
849         they are clearly better than before.
850         * Scripts/modules/cpp_style_unittest.py:
851         Added test cases for the newly supported checks and modified old
852         test cases to match the new guidelines
853
854 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
855
856         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
857
858         * wx/build/settings.py:
859
860 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
861
862         Reviewed by David Levin.
863
864         Add mod_pywebsocket to test Web Sockets.
865         http://code.google.com/p/pywebsocket/
866         https://bugs.webkit.org/show_bug.cgi?id=27490
867
868         * pywebsocket/COPYING: Added.
869         * pywebsocket/MANIFEST.in: Added.
870         * pywebsocket/README: Added.
871         * pywebsocket/example/echo_client.py: Added.
872         * pywebsocket/example/echo_wsh.py: Added.
873         * pywebsocket/mod_pywebsocket/__init__.py: Added.
874         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
875         * pywebsocket/mod_pywebsocket/handshake.py: Added.
876         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
877         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
878         * pywebsocket/mod_pywebsocket/standalone.py: Added.
879         * pywebsocket/mod_pywebsocket/util.py: Added.
880         * pywebsocket/setup.py: Added.
881         * pywebsocket/test/config.py: Added.
882         * pywebsocket/test/mock.py: Added.
883         * pywebsocket/test/run_all.py: Added.
884         * pywebsocket/test/test_dispatch.py: Added.
885         * pywebsocket/test/test_handshake.py: Added.
886         * pywebsocket/test/test_mock.py: Added.
887         * pywebsocket/test/test_msgutil.py: Added.
888         * pywebsocket/test/test_util.py: Added.
889         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
890         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
891         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
892         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
893         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
894         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
895         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
896         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
897
898 2009-10-15  James Robinson  <jamesr@google.com>
899
900         Reviewed by David Levin.
901
902         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
903
904         https://bugs.webkit.org/show_bug.cgi?id=30426
905
906         * Scripts/modules/cpp_style.py:
907         * Scripts/modules/cpp_style_unittest.py:
908
909 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
910
911         Reviewed by Adam Roben.
912
913         Fixes <http://webkit.org/b/30411>.
914         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
915         
916         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
917         building Chromium.
918
919         * Scripts/pdevenv:
920
921 2009-10-15  Robin Dunn  <robin@alldunn.com>
922
923         Reviewed by Kevin Ollivier.
924
925         Add Mac package building scripts for wx.
926         
927         https://bugs.webkit.org/show_bug.cgi?id=30405
928
929         * wx/build/build_utils.py:
930         * wx/build/settings.py:
931         * wx/packaging/build-mac-installer.py: Added.
932
933 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
934
935         Reviewed by Gustavo Noronha.
936
937         Enable Web Sockets support when running layout tests.
938
939         * DumpRenderTree/gtk/DumpRenderTree.cpp:
940         (resetDefaultsToConsistentValues):
941
942 2009-10-15  Xan Lopez  <xlopez@igalia.com>
943
944         Reviewed by Gustavo Noronha.
945
946         Need to initialize event.button.button, since in most cases a
947         button number is not passed as an argument.
948
949         * DumpRenderTree/gtk/EventSender.cpp:
950         (mouseDownCallback):
951         (mouseUpCallback):
952
953 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
954
955         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
956         the OS if none was explicitly set.
957
958         * wx/build/settings.py:
959
960 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
961
962         Reviewed by Timothy Hatcher.
963
964         Web Inspector: enable developers extras within inspector layout tests.
965
966         https://bugs.webkit.org/show_bug.cgi?id=30014
967
968         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
969         (LayoutTestController::showWebInspector):
970         (LayoutTestController::closeWebInspector):
971         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
972         (LayoutTestController::showWebInspector):
973         (LayoutTestController::closeWebInspector):
974
975 2009-10-14  José Millán Soto  <jmillan@igalia.com>
976
977         Reviewed by Jan Alonzo.
978
979         GtkLauncher is using a deprecated signal
980         https://bugs.webkit.org/show_bug.cgi?id=30364
981
982         Modified GtkLauncher to use notify::title signal instead of
983         deprecated title-changed signal
984
985         * GtkLauncher/main.c:
986         (notify_title_cb):
987         (create_browser):
988
989 2009-10-14  Brady Eidson  <beidson@apple.com>
990
991         Reviewed by Sam Weinig.
992
993         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
994         1 - Disables WebHistory
995         2 - Doesn't make sense in that context anyway.
996
997         * DumpRenderTree/win/DumpRenderTree.cpp:
998         (createWebViewAndOffscreenWindow):
999
1000 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
1001
1002         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
1003         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
1004
1005         * wx/build/settings.py:
1006         * wx/install-unix-extras:
1007
1008 2009-10-14  Brady Eidson  <beidson@apple.com>
1009
1010         Reviewed by Sam Weinig.
1011
1012         WebKit Win API should provide a delegate interface for global history.
1013         https://bugs.webkit.org/show_bug.cgi?id=29905
1014
1015         * DumpRenderTree/LayoutTestController.cpp:
1016         (LayoutTestController::LayoutTestController):
1017         * DumpRenderTree/LayoutTestController.h:
1018         (LayoutTestController::dumpHistoryDelegateCallbacks):
1019         (LayoutTestController::setDumpHistoryDelegateCallbacks):
1020                 
1021         * DumpRenderTree/win/DumpRenderTree.cpp:
1022         (shouldLogHistoryDelegates):
1023         (runTest):
1024         (createWebViewAndOffscreenWindow):
1025         (main):
1026         * DumpRenderTree/win/DumpRenderTree.vcproj:
1027         
1028         Add the IWebHistoryDelegate to DRT Windows:
1029         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
1030         (wstringFromBSTR):
1031         (HistoryDelegate::HistoryDelegate):
1032         (HistoryDelegate::~HistoryDelegate):
1033         (HistoryDelegate::QueryInterface):
1034         (HistoryDelegate::AddRef):
1035         (HistoryDelegate::Release):
1036         (HistoryDelegate::didNavigateWithNavigationData):
1037         (HistoryDelegate::didPerformClientRedirectFromURL):
1038         (HistoryDelegate::didPerformServerRedirectFromURL):
1039         (HistoryDelegate::updateHistoryTitle):
1040         (HistoryDelegate::populateVisitedLinksForWebView):
1041         * DumpRenderTree/win/HistoryDelegate.h: Added.
1042
1043         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1044         (LayoutTestController::removeAllVisitedLinks):
1045
1046 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
1047
1048         Reviewed by Simon Hausmann.
1049
1050         [Qt] Implement support for setPOSIXLocale on Qt.
1051         https://bugs.webkit.org/show_bug.cgi?id=30268 
1052  
1053         * DumpRenderTree/qt/DumpRenderTree.cpp:
1054         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1055         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1056         (LayoutTestController::setPOSIXLocale):
1057         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1058
1059 2009-10-13  Stephanie Lewis  <slewis@apple.com>
1060
1061         Unreviewed, adding myself to reviewers list.
1062
1063         * Scripts/modules/committers.py:
1064
1065 2009-10-13  Stephanie Lewis  <slewis@apple.com>
1066
1067         Reviewed by Mark Rowe.
1068
1069         Fix null assignment so root tests work again.
1070
1071         * Scripts/webkitdirs.pm:
1072
1073 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1074
1075         Reviewed by Simon Hausmann.
1076
1077         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
1078         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
1079         This is done in preparation of implementing missing features in DRT.
1080         No functionality changes made yet.
1081
1082         * DumpRenderTree/qt/DumpRenderTree.cpp:
1083         * DumpRenderTree/qt/DumpRenderTree.pro:
1084         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
1085         (EventSender::EventSender):
1086         (EventSender::mouseDown):
1087         (EventSender::mouseUp):
1088         (EventSender::mouseMoveTo):
1089         (EventSender::leapForward):
1090         (EventSender::keyDown):
1091         (EventSender::contextClick):
1092         (EventSender::scheduleAsynchronousClick):
1093         (EventSender::frameUnderMouse):
1094         * DumpRenderTree/qt/EventSenderQt.h: Added.
1095         (EventSender::clearKillRing):
1096         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
1097         (LayoutTestController::LayoutTestController):
1098         (LayoutTestController::reset):
1099         (LayoutTestController::processWork):
1100         (LayoutTestController::maybeDump):
1101         (LayoutTestController::waitUntilDone):
1102         (LayoutTestController::notifyDone):
1103         (LayoutTestController::windowCount):
1104         (LayoutTestController::clearBackForwardList):
1105         (LayoutTestController::dumpEditingCallbacks):
1106         (LayoutTestController::dumpResourceLoadCallbacks):
1107         (LayoutTestController::queueBackNavigation):
1108         (LayoutTestController::queueForwardNavigation):
1109         (LayoutTestController::queueLoad):
1110         (LayoutTestController::queueReload):
1111         (LayoutTestController::queueScript):
1112         (LayoutTestController::provisionalLoad):
1113         (LayoutTestController::timerEvent):
1114         (LayoutTestController::encodeHostName):
1115         (LayoutTestController::decodeHostName):
1116         (LayoutTestController::setJavaScriptProfilingEnabled):
1117         (LayoutTestController::setFixedContentsSize):
1118         (LayoutTestController::setPrivateBrowsingEnabled):
1119         (LayoutTestController::setPopupBlockingEnabled):
1120         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
1121         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
1122         (LayoutTestController::numberOfActiveAnimations):
1123         (LayoutTestController::disableImageLoading):
1124         (LayoutTestController::dispatchPendingLoadRequests):
1125         (LayoutTestController::setDatabaseQuota):
1126         (LayoutTestController::clearAllDatabases):
1127         (LayoutTestController::whiteListAccessFromOrigin):
1128         (LayoutTestController::waitForPolicyDelegate):
1129         (LayoutTestController::overridePreference):
1130         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
1131         (LayoutTestController::isLoading):
1132         (LayoutTestController::setLoading):
1133         (LayoutTestController::shouldDumpAsText):
1134         (LayoutTestController::shouldDumpBackForwardList):
1135         (LayoutTestController::shouldDumpChildrenAsText):
1136         (LayoutTestController::shouldDumpDatabaseCallbacks):
1137         (LayoutTestController::shouldDumpStatusCallbacks):
1138         (LayoutTestController::shouldWaitUntilDone):
1139         (LayoutTestController::canOpenWindows):
1140         (LayoutTestController::shouldDumpTitleChanges):
1141         (LayoutTestController::waitForPolicy):
1142         (LayoutTestController::dumpAsText):
1143         (LayoutTestController::dumpChildFramesAsText):
1144         (LayoutTestController::dumpDatabaseCallbacks):
1145         (LayoutTestController::dumpStatusCallbacks):
1146         (LayoutTestController::setCanOpenWindows):
1147         (LayoutTestController::dumpBackForwardList):
1148         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
1149         (LayoutTestController::display):
1150         (LayoutTestController::dumpTitleChanges):
1151         (LayoutTestController::dumpSelectionRect):
1152         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
1153         (TextInputController::TextInputController):
1154         (TextInputController::doCommand):
1155         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
1156         * DumpRenderTree/qt/WorkQueue.cpp:
1157         * DumpRenderTree/qt/WorkQueue.h:
1158         * DumpRenderTree/qt/WorkQueueItem.h:
1159         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
1160         (findFrameNamed):
1161         (LoadItem::invoke):
1162         (ReloadItem::invoke):
1163         (ScriptItem::invoke):
1164         (BackForwardItem::invoke):
1165         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
1166         * DumpRenderTree/qt/jsobjects.h:
1167
1168 2009-10-13  Dmitry Titov  <dimich@chromium.org>
1169
1170         Not reviewed, adding myself to the list of reviewers.
1171
1172         * Scripts/modules/committers.py:
1173
1174 2009-10-13  Anders Carlsson  <andersca@apple.com>
1175
1176         Reviewed by Sam Weinig.
1177
1178         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
1179
1180         Make the private browsing mode testable by the test plug-in.
1181         
1182         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1183         (pluginGetProperty):
1184         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
1185         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1186         (NPP_New):
1187         (NPP_SetValue):
1188
1189 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
1190
1191         No review, just adding self to the list of reviewers.
1192
1193         * Scripts/modules/committers.py:
1194
1195 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
1196
1197         Reviewed by Adam Roben.
1198
1199         Web Inspector: Use proper web view in inspector layout
1200         tests for windows.
1201
1202         https://bugs.webkit.org/show_bug.cgi?id=30298
1203
1204         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1205         (LayoutTestController::showWebInspector):
1206         (LayoutTestController::closeWebInspector):
1207         (LayoutTestController::evaluateInWebInspector):
1208
1209 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
1210
1211         Reviewed by Sam Weinig.
1212
1213         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
1214         https://bugs.webkit.org/show_bug.cgi?id=29841
1215
1216         * DumpRenderTree/mac/DumpRenderTree.mm:
1217         (resetDefaultsToConsistentValues):
1218         * DumpRenderTree/win/DumpRenderTree.cpp:
1219         (resetDefaultsToConsistentValues):
1220
1221 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
1222
1223         Reviewed by Dimitri Glazkov.
1224
1225         Chromium Port - Windows
1226         https://bugs.webkit.org/show_bug.cgi?id=29969
1227
1228         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
1229         * Scripts/webkitdirs.pm:
1230
1231 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
1232
1233         Reviewed by Darin Adler.
1234
1235         jsc scripts cleanup and Qt/GTK fix
1236         https://bugs.webkit.org/show_bug.cgi?id=30288
1237
1238         Duplicated jscPath() moved to webkitdirs.pm.
1239         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
1240         Configuration added (release/debug) to path for Qt-port on Windows.
1241
1242         * Scripts/run-javascriptcore-tests:
1243         * Scripts/run-jsc:
1244         * Scripts/run-sunspider:
1245         * Scripts/sunspider-compare-results:
1246         * Scripts/webkitdirs.pm:
1247
1248 2009-10-11  Adam Barth  <abarth@webkit.org>
1249
1250         Unreviewed.  Add Collin to committers.py.
1251
1252         * Scripts/modules/committers.py:
1253
1254 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
1255
1256         wx build fix, add bindings to source/include dirs now that there are sources there.
1257
1258         * wx/build/settings.py:
1259
1260 2009-10-09  Mark Rowe  <mrowe@apple.com>
1261
1262         Reviewed by Brady Eidson.
1263
1264         Enable plug-in halting in DumpRenderTree.
1265
1266         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
1267         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
1268
1269         * DumpRenderTree/mac/DumpRenderTree.mm:
1270         (resetDefaultsToConsistentValues):
1271         * DumpRenderTree/mac/UIDelegate.mm:
1272         (-[UIDelegate webView:shouldHaltPlugin:]):
1273
1274 2009-10-08  Brady Eidson  <beidson@apple.com>
1275
1276         Reviewed by Dan Bernstein.
1277
1278         Ask the History Delegate to populate the visited links hash.
1279         <rdar://problem/7285293> and https://webkit.org/b/29904
1280
1281         Add the ability for LayoutTestController to clear all visited links.
1282         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
1283
1284         * DumpRenderTree/LayoutTestController.cpp:
1285         (LayoutTestController::LayoutTestController):
1286         (removeAllVisitedLinksCallback):
1287         (LayoutTestController::staticFunctions):
1288         * DumpRenderTree/LayoutTestController.h:
1289         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1290         (LayoutTestController::removeAllVisitedLinks):
1291
1292         * DumpRenderTree/mac/HistoryDelegate.mm:
1293         (-[HistoryDelegate populateVisitedLinksForWebView:]):
1294
1295         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1296         (LayoutTestController::removeAllVisitedLinks):
1297         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1298         (LayoutTestController::removeAllVisitedLinks):
1299         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1300         (LayoutTestController::removeAllVisitedLinks):
1301
1302
1303 2009-10-08  Daniel Bates  <dbates@webkit.org>
1304
1305         Reviewed by Adam Roben.
1306
1307         https://bugs.webkit.org/show_bug.cgi?id=30175
1308         
1309         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
1310         the OLE drag-and-drop return value like the function it emulates. Currently, 
1311         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine 
1312         whether the drag-and-drop operation was successful or was cancelled.
1313         
1314         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop 
1315         return value according to whether the drop operation was successful or not.
1316
1317         * DumpRenderTree/win/EventSender.cpp:
1318         (doMouseUp): Added parameter oleDragAndDropReturnValue.
1319         (replaySavedEvents): Ditto.
1320         * DumpRenderTree/win/EventSender.h:
1321         * DumpRenderTree/win/UIDelegate.cpp:
1322         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
1323
1324 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
1325
1326         Reviewed by Xan Lopez.
1327
1328         [GTK] Added support for a parameter setting the button that was
1329         pressed in the mouseDown function.
1330         https://bugs.webkit.org/show_bug.cgi?id=30220
1331
1332         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
1333
1334 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
1335
1336         Reviewed by Xan Lopez.
1337
1338         [GTK] Added a line to the bottom of the expected result to match
1339         the output of the test.
1340         https://bugs.webkit.org/show_bug.cgi?id=30220
1341
1342         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
1343         expected.txt:
1344
1345 2009-10-08  Adam Roben  <aroben@apple.com>
1346
1347         Use QueryInterface to get IWebInspectorPrivate
1348
1349         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
1350         accessed in a more standard way
1351
1352         Reviewed by John Sullivan and Tim Hatcher.
1353
1354         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1355         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
1356         by calling IWebViewPrivate::inspector, then use QueryInterface to get
1357         to the IWebInspectorPrivate interface.
1358
1359 2009-10-07  Adam Roben  <aroben@apple.com>
1360
1361         Implement DRT support for origin whitelisting
1362
1363         Fixes <http://webkit.org/b/30185>.
1364
1365         Reviewed by Eric Seidel.
1366
1367         * DumpRenderTree/win/DumpRenderTree.cpp:
1368         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
1369         whitelist, to match Mac DRT.
1370         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1371         (LayoutTestController::whiteListAccessFromOrigin): Call through to
1372         IWebViewPrivate::whiteListAccessFromOrigin.
1373
1374 2009-10-07  Brady Eidson  <beidson@apple.com>
1375
1376         Reviewed by Darin Adler.
1377
1378         Send title changes to the global history delegate.
1379         <rdar://problem/7285293> and https://webkit.org/b/29904
1380
1381         * DumpRenderTree/mac/HistoryDelegate.mm:
1382         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
1383
1384 2009-10-07  Adam Barth  <abarth@webkit.org>
1385
1386         Unreviewed.  Remove some folks from committers.py who were listed on
1387         the WebKit Team wiki page but who weren't actually listed as commit+.
1388         At some point, we should coorelate this list with the committers
1389         mailing list.
1390
1391         * Scripts/modules/committers.py:
1392
1393 2009-10-07  Adam Barth  <abarth@webkit.org>
1394
1395         Unreviewed.  Import a bunch of committers from the WebKit Team page on
1396         the wiki into committers.py.
1397
1398         * Scripts/modules/committers.py:
1399
1400 2009-10-07  Adam Barth  <abarth@webkit.org>
1401
1402         Unreviewed.  Added Aaron Boodman to committers.py.
1403
1404         * Scripts/modules/committers.py:
1405
1406 2009-10-07  Evan Martin  <evan@chromium.org>
1407
1408         Reviewed by Darin Adler.
1409
1410         Add API to LayoutTestController for re/setting the system locale.
1411         https://bugs.webkit.org/show_bug.cgi?id=18994
1412
1413         * DumpRenderTree/LayoutTestController.cpp:
1414         (setLocaleCallback):
1415         (LayoutTestController::staticFunctions):
1416         (LayoutTestController::setLocale):
1417         * DumpRenderTree/LayoutTestController.h:
1418
1419 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
1420
1421         Reviewed by Jan Alonzo.
1422
1423         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
1424         https://bugs.webkit.org/show_bug.cgi?id=29689
1425
1426         Build fix by adding -lfontconfig for DumpRenderTree.
1427
1428         * GNUmakefile.am:
1429
1430 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
1431
1432         Reviewed by Simon Hausmann.
1433
1434         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
1435
1436         * Scripts/run-webkit-tests:
1437
1438 2009-10-07  Xan Lopez  <xlopez@igalia.com>
1439
1440         Reviewed by Gustavo Noronha.
1441
1442         "delete" in EventSender is the backspace key, not the delete one.
1443
1444         * DumpRenderTree/gtk/EventSender.cpp:
1445         (keyDownCallback):
1446
1447 2009-10-07  Xan Lopez  <xlopez@igalia.com>
1448
1449         Reviewed by Gustavo Noronha.
1450
1451         getChildrenWithRange expects as last parameter the end index, not
1452         the length of the range. Correct this and clarify the variable
1453         names to reflect how the code works.
1454
1455         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1456         (AccessibilityUIElement::getChildrenWithRange):
1457         (AccessibilityUIElement::getChildAtIndex):
1458
1459 2009-10-06  Mark Rowe  <mrowe@apple.com>
1460
1461         Reviewed by Simon Fraser.
1462
1463         <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
1464
1465         * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
1466         the fact we have already changed the working directory to the top of the open source tree.
1467
1468 2009-10-06  Julie Parent  <jparent@chromium.org>
1469
1470         Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
1471         rather than my committer email.
1472
1473         * Scripts/modules/committers.py:
1474
1475 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
1476
1477         Reviewed by Eric Seidel.
1478
1479         [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
1480
1481         r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
1482         it after each layout test as it should do, making the DRT dump additional output
1483         for all of the subsequent layout tests.
1484
1485         * DumpRenderTree/qt/jsobjects.cpp:
1486         (LayoutTestController::reset):
1487
1488 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
1489
1490         Reviewed by Simon Hausmann.
1491
1492         [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
1493         fast/dom/assign-to-window-status.html test, which is passing as a result.
1494
1495         https://bugs.webkit.org/show_bug.cgi?id=30127
1496
1497         * DumpRenderTree/qt/DumpRenderTree.cpp:
1498         (WebCore::DumpRenderTree::DumpRenderTree):
1499         (WebCore::DumpRenderTree::statusBarMessage):
1500         * DumpRenderTree/qt/DumpRenderTree.h:
1501         * DumpRenderTree/qt/jsobjects.h:
1502         (LayoutTestController::shouldDumpStatusCallbacks):
1503         (LayoutTestController::dumpStatusCallbacks):
1504
1505 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
1506
1507         Reviewed by Simon Hausmann.
1508
1509         [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
1510         ignores the argument indicating which mouse button to trigger.
1511         https://bugs.webkit.org/show_bug.cgi?id=30048
1512
1513         This affects the fast/events/mouse-click-events.html layout test.
1514
1515         * DumpRenderTree/qt/jsobjects.cpp:
1516         (EventSender::mouseDown):
1517         (EventSender::mouseUp):
1518         * DumpRenderTree/qt/jsobjects.h:
1519
1520 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
1521
1522         Reviewed by Simon Hausmann.
1523
1524         [Qt] Fix the EventSender::keyDown() implementation
1525         https://bugs.webkit.org/show_bug.cgi?id=30043
1526
1527         It should post both a key press event and a key release event,
1528         just like other ports do.
1529
1530         * DumpRenderTree/qt/jsobjects.cpp:
1531         (EventSender::keyDown):
1532
1533 2009-10-05  Kevin Ollivier  <kevino@theolliviers.com>
1534
1535         wx build fix. Add jpeg to the list of libs to link against.
1536
1537         * wx/build/settings.py:
1538
1539 2009-10-05  Jakub Wieczorek  <faw217@gmail.com>
1540
1541         Reviewed by Simon Hausmann.
1542
1543         [Qt] EventSender::keyDown() cannot send function-key events.
1544         https://bugs.webkit.org/show_bug.cgi?id=30044
1545
1546         This affects the fast/events/keydown-function-keys.html layout test.
1547
1548         * DumpRenderTree/qt/jsobjects.cpp:
1549         (EventSender::keyDown):
1550
1551 2009-10-05  Vadim Zeitlin  <vadim@wxwidgets.org>
1552
1553         Added --wx-compiler-prefix waf option to allow building wxWebKit with
1554         wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".
1555
1556         * wx/build/settings.py:
1557         * wx/build/wxpresets.py:
1558
1559 2009-10-05  Pavel Feldman  <pfeldman@chromium.org>
1560
1561         Reviewed by Timothy Hatcher.
1562
1563         Web Inspector: add testing harness for Web Inspector.
1564
1565         https://bugs.webkit.org/show_bug.cgi?id=30010
1566
1567         * DumpRenderTree/LayoutTestController.cpp:
1568         (showWebInspectorCallback):
1569         (closeWebInspectorCallback):
1570         (evaluateInWebInspectorCallback):
1571         (LayoutTestController::staticFunctions):
1572         * DumpRenderTree/LayoutTestController.h:
1573         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1574         (LayoutTestController::showWebInspector):
1575         (LayoutTestController::closeWebInspector):
1576         (LayoutTestController::evaluateInWebInspector):
1577         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1578         (LayoutTestController::showWebInspector):
1579         (LayoutTestController::closeWebInspector):
1580         (LayoutTestController::evaluateInWebInspector):
1581         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1582         (LayoutTestController::showWebInspector):
1583         (LayoutTestController::closeWebInspector):
1584         (LayoutTestController::evaluateInWebInspector):
1585         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1586         (LayoutTestController::showWebInspector):
1587         (LayoutTestController::closeWebInspector):
1588         (LayoutTestController::evaluateInWebInspector):
1589
1590 2009-10-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1591
1592         Reviewed by Ariyha Hidayat.
1593
1594         Pass arguments to system() as a string instead of array
1595
1596         When passed as an array entries with a space fail to translate
1597         to two arguments to the child process, so instead of manually
1598         splitting all the entries in @buildArgs we pass the whole thing
1599         as a string instead.
1600
1601         * Scripts/webkitdirs.pm:
1602
1603 2009-10-04  Carol Szabo  <carol.szabo@nokia.com>
1604
1605         Reviewed by David Levin.
1606
1607         check-webkit-style misses whitespace errors for operators:
1608         <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||.
1609         https://bugs.webkit.org/show_bug.cgi?id=30021
1610
1611         * Scripts/modules/cpp_style.py:
1612         Added the operators mentioned above to the same list as == and !=.
1613
1614 2009-10-02  Julie Parent  <jparent@chromium.org>
1615
1616         Unreviewed.
1617
1618         Adding myself and Ojan Vafai as committers, because we are committers.
1619
1620         * Scripts/modules/committers.py:
1621
1622 2009-10-02  Brian Weinstein  <bweinstein@apple.com>
1623
1624         Reviewed by Adam Roben.
1625
1626         svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
1627         this will help the patch merging process when TryBots are used.
1628
1629         * Scripts/svn-create-patch:
1630
1631 2009-10-02  Jakub Wieczorek  <faw217@gmail.com>
1632
1633         Reviewed by Simon Hausmann.
1634
1635         [Qt] Implement layoutTestController.overridePreference().
1636         https://bugs.webkit.org/show_bug.cgi?id=29970
1637
1638         * DumpRenderTree/qt/DumpRenderTree.cpp:
1639         (WebCore::WebPage::WebPage):
1640         (WebCore::WebPage::resetSettings):
1641         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1642         * DumpRenderTree/qt/jsobjects.cpp:
1643         (LayoutTestController::reset):
1644         (LayoutTestController::setPrivateBrowsingEnabled):
1645         (LayoutTestController::setPopupBlockingEnabled):
1646         (LayoutTestController::overridePreference):
1647         * DumpRenderTree/qt/jsobjects.h:
1648
1649 2009-10-01  Chris Marrin  <cmarrin@apple.com>
1650
1651         Reviewed by Oliver Hunt.
1652
1653         Turn on ENABLE_3D_CANVAS in TOT
1654         https://bugs.webkit.org/show_bug.cgi?id=29906
1655
1656         * Scripts/build-webkit:
1657
1658 2009-10-01  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1659
1660         Rubberstamped by Simon Hausmann.
1661
1662         Enable HTTP tests for Qt
1663
1664         * Scripts/run-webkit-tests:
1665
1666 2009-10-01  Yaar Schnitman  <yaar@chromium.org>
1667
1668         Reviewed by Dimitri Glazkov.
1669
1670         build-webkit --chromium now also works on cygwin.
1671
1672         https://bugs.webkit.org/show_bug.cgi?id=29973
1673
1674         * Scripts/webkitdirs.pm:
1675
1676 2009-10-01  Zoltan Horvath  <zoltan@webkit.org>
1677
1678         Reviewed by Simon Hausmann.
1679
1680         [Qt] Don't use TCmalloc in DumpRenderTree
1681         https://bugs.webkit.org/show_bug.cgi?id=27029
1682
1683         Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT.
1684
1685         * DumpRenderTree/qt/DumpRenderTree.pro:
1686
1687 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
1688
1689         Reviewed by Simon Hausmann.
1690
1691         [Qt] Implement eventSender.scheduleAsynchronousClick().
1692
1693         https://bugs.webkit.org/show_bug.cgi?id=29931
1694
1695         * DumpRenderTree/qt/jsobjects.cpp:
1696         (EventSender::scheduleAsynchronousClick):
1697         * DumpRenderTree/qt/jsobjects.h:
1698
1699 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
1700
1701         Reviewed by Simon Hausmann.
1702
1703         [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
1704         fast/events/open-window-from-another-frame.html from the Skipped list.
1705
1706         https://bugs.webkit.org/show_bug.cgi?id=29930
1707
1708         * DumpRenderTree/qt/jsobjects.cpp:
1709         (LayoutTestController::setPopupBlockingEnabled):
1710         * DumpRenderTree/qt/jsobjects.h:
1711
1712 2009-09-30  Cameron McCormack  <cam@mcc.id.au>
1713
1714         Unreviewed.
1715
1716         Added myself to the list of committers.
1717
1718         * Scripts/modules/committers.py:
1719
1720 2009-09-30  Eric Seidel  <eric@webkit.org>
1721
1722         No review, just adding Geoff to the list of reviewers.
1723
1724         * Scripts/modules/committers.py:
1725
1726 2009-09-30  Dan Bernstein  <mitz@apple.com>
1727
1728         Reviewed by Sam Weinig.
1729
1730         Added the WebKit Layout Tests fonts that are referenced in
1731         LayoutTests/platform/win/css2.1/resources/Mac-compatible-font-fallback.css
1732
1733         * DumpRenderTree/fonts/WebKit Layout Tests 2.ttf: Added.
1734         * DumpRenderTree/fonts/WebKit Layout Tests.ttf: Added.
1735
1736 2009-09-30  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
1737
1738         Reviewed by David Kilzer.
1739
1740         Make sunspider scripts work on Windows platform.
1741         https://bugs.webkit.org/show_bug.cgi?id=29656
1742
1743         * Scripts/run-sunspider: Perl scripts invoked with same Perl interpreter.
1744         * Scripts/sunspider-compare-results: Perl scripts invoked with same Perl interpreter.
1745         * Scripts/webkitdirs.pm: currentPerlPath() added.
1746
1747 2009-09-29  Brady Eidson  <beidson@apple.com>
1748
1749         Rubberstamped by Dan Bernstein.
1750
1751         Fix license and some sorting in new files.
1752
1753         * DumpRenderTree/mac/HistoryDelegate.h:
1754         * DumpRenderTree/mac/HistoryDelegate.mm:
1755
1756 2009-09-29  Yaar Schnitman  <yaar@chromium.org>
1757
1758         Reviewed by David Kilzer.
1759
1760         Fixed how error codes are handled.
1761         https://bugs.webkit.org/show_bug.cgi?id=29898
1762
1763         * Scripts/update-webkit:
1764         * Scripts/update-webkit-chromium:
1765
1766 2009-09-29  Brady Eidson  <beidson@apple.com>
1767
1768         Reviewed by John Sullivan.
1769
1770         Updated way-out-of-date sorting throughout the dump methods/flags.
1771
1772         * DumpRenderTree/LayoutTestController.cpp:
1773         (LayoutTestController::LayoutTestController):
1774         (dumpAsPDFCallback):
1775         (dumpAsTextCallback):
1776         (dumpFrameLoadCallbacksCallback):
1777         (dumpResourceLoadCallbacksCallback):
1778         (LayoutTestController::staticFunctions):
1779
1780         * DumpRenderTree/LayoutTestController.h:
1781         (LayoutTestController::dumpAsText):
1782         (LayoutTestController::setDumpAsText):
1783         (LayoutTestController::dumpFrameLoadCallbacks):
1784         (LayoutTestController::setDumpFrameLoadCallbacks):
1785         (LayoutTestController::dumpSelectionRect):
1786         (LayoutTestController::setDumpSelectionRect):
1787         (LayoutTestController::dumpSourceAsWebArchive):
1788         (LayoutTestController::setDumpSourceAsWebArchive):
1789         (LayoutTestController::dumpStatusCallbacks):
1790         (LayoutTestController::setDumpStatusCallbacks):
1791         (LayoutTestController::dumpTitleChanges):
1792         (LayoutTestController::setDumpTitleChanges):
1793         (LayoutTestController::dumpWillCacheResponse):
1794         (LayoutTestController::setDumpWillCacheResponse):
1795
1796 2009-09-29  Brady Eidson  <beidson@apple.com>
1797
1798         Reviewed by John Sullivan.
1799
1800         WebKit Mac API should provide a delegate interface for global history.
1801         <rdar://problem/7042773> and https://webkit.org/b/29904
1802
1803         Adding the dumping of global history delegate callbacks.
1804
1805         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1806
1807         Automatically dump history delegate callbacks for tests with "globalhistory/" in their URL:
1808         * DumpRenderTree/mac/DumpRenderTree.mm:
1809         (createWebViewAndOffscreenWindow):
1810         (allocateGlobalControllers):
1811         (shouldLogFrameLoadDelegates):
1812         (shouldLogHistoryDelegates):
1813         (runTest):
1814
1815         Dump history delegate callbacks:
1816         * DumpRenderTree/mac/HistoryDelegate.h: Added.
1817         * DumpRenderTree/mac/HistoryDelegate.mm: Added.
1818         (-[HistoryDelegate webView:didNavigateWithNavigationData:inFrame:]):
1819         (-[HistoryDelegate webView:didPerformClientRedirectFromURL:toURL:inFrame:]):
1820         (-[HistoryDelegate webView:didPerformServerRedirectFromURL:toURL:inFrame:]):
1821
1822 2009-09-29  Daniel Bates  <dbates@webkit.org>
1823
1824         Reviewed by Adam Roben.
1825
1826         https://bugs.webkit.org/show_bug.cgi?id=28902
1827         
1828         Fixes an issue where the drop effect returned by Window Dump Render Tree 
1829         was always DROPEFFECT_NONE (since it was hard coded to do so).
1830         
1831         This patch corrects this issue by determining the actual drop effect 
1832         performed by the corresponding drag-and-drop operation so that we can 
1833         return it.
1834
1835         * DumpRenderTree/win/DraggingInfo.h: Added field m_dropEffect to store performed drop effect.
1836         (DraggingInfo::DraggingInfo):
1837         (DraggingInfo::performedDropEffect): Added method.
1838         (DraggingInfo::setPerformedDropEffect): Added method.
1839         * DumpRenderTree/win/EventSender.cpp:
1840         (doMouseUp): Calls method DraggingInfo::setPerformedDropEffect with performed drop effect.
1841         Moved delete draggingInfo to UIDelegate::doDragDrop.
1842         * DumpRenderTree/win/UIDelegate.cpp:
1843         (UIDelegate::doDragDrop): Sets performedDropEffect to DraggingInfo::performedDropEffect().
1844
1845 2009-09-29  Dan Bernstein  <mitz@apple.com>
1846
1847         Reviewed by Adam Roben.
1848
1849         Remove copying of unnecessary or nonexistent files from the ImageDiff
1850         post-build event.
1851
1852         * DumpRenderTree/win/ImageDiff.vcproj:
1853
1854 2009-09-29  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
1855
1856         Reviewed by David Kilzer.
1857
1858         [Qt] Make build-webkit script work on Windows
1859         https://bugs.webkit.org/show_bug.cgi?id=29802
1860
1861         * Scripts/run-webkit-tests:
1862         * Scripts/webkitdirs.pm:
1863          - Removed unnecessary -p switch for mkdir on Windows.
1864          - Use canonical path, which uses slashes or backslashes depends on platform.
1865          - isWindows() only test for Windows and not for Cyqwin.
1866
1867 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1868
1869         Reviewed by Simon Hausmann.
1870
1871         Fix time measurement in build-webkit after refactoring done in r48853.
1872
1873         * Scripts/build-webkit:
1874
1875 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1876
1877         Reviewed by Tor Arne Vestbø.
1878
1879         [Qt] Default font size reconciliation to 16px/13px to match other platform's de-facto standard.
1880         This fixes https://bugs.webkit.org/show_bug.cgi?id=19674.
1881
1882         * DumpRenderTree/qt/DumpRenderTree.cpp:
1883         (WebCore::WebPage::WebPage):
1884
1885 2009-09-29  Jakub Wieczorek  <faw217@gmail.com>
1886
1887         Reviewed by Simon Hausmann.
1888
1889         [Qt] Implement eventSender.contextClick().
1890         https://bugs.webkit.org/show_bug.cgi?id=29821
1891
1892         * DumpRenderTree/qt/jsobjects.cpp:
1893         (EventSender::contextClick):
1894         * DumpRenderTree/qt/jsobjects.h:
1895
1896 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
1897
1898         Reviewed by Eric Seidel.
1899
1900         Add experimentalWebSocketsEnabled in WebPreferences.
1901         https://bugs.webkit.org/show_bug.cgi?id=28941
1902
1903         * DumpRenderTree/mac/DumpRenderTree.mm:
1904         (resetDefaultsToConsistentValues):
1905         * DumpRenderTree/win/DumpRenderTree.cpp:
1906         (resetDefaultsToConsistentValues):
1907
1908 2009-09-28  Yaar Schnitman  <yaar@chromium.org>
1909
1910         Reviewed by David Kilzer.
1911
1912         Integrated chromium port building into webkit tools update-webkit and
1913         build-webkit.
1914
1915         https://bugs.webkit.org/show_bug.cgi?id=29749
1916
1917         * Scripts/build-webkit: When --chromium is specified, will build
1918           the chromium port (currently only Mac is supported).
1919         * Scripts/update-webkit: When --chromium is specified, delegates to
1920           update-webkit-chromium.
1921         * Scripts/webkitdirs.pm: Added chromium specific defs.
1922         * Scripts/update-webkit-chromium: Uses gclient and gyp to fetch
1923           chromium port's dependencies and update its project files.
1924
1925 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
1926
1927         Unreviewed.
1928
1929         Add myself to list of committers.
1930
1931         * Scripts/modules/committers.py:
1932
1933 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
1934
1935         Reviewed by Darin Adler.
1936
1937         run-webkit-tests: Do not strip the metrics when there is no expected result for a test.
1938         https://bugs.webkit.org/show_bug.cgi?id=29771
1939
1940         * Scripts/run-webkit-tests:
1941
1942 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
1943
1944         Reviewed by Simon Hausmann.
1945
1946         [Qt] Implement layoutTestController.waitForPolicyDelegate.
1947         https://bugs.webkit.org/show_bug.cgi?id=25037
1948
1949         * DumpRenderTree/qt/DumpRenderTree.cpp:
1950         (WebCore::WebPage::acceptNavigationRequest):
1951         * DumpRenderTree/qt/DumpRenderTree.pro:
1952         * DumpRenderTree/qt/jsobjects.cpp:
1953         (LayoutTestController::reset):
1954         (LayoutTestController::notifyDone):
1955         (LayoutTestController::waitForPolicyDelegate):
1956         * DumpRenderTree/qt/jsobjects.h:
1957         (LayoutTestController::waitForPolicy):
1958
1959 2009-09-26  David Kilzer  <ddkilzer@apple.com>
1960
1961         <http://webkit.org/b/29764> mark-bug-fixed: add -o|--open switch
1962
1963         Reviewed by Eric Seidel.
1964
1965         The -o|--open switch uses the open(1) command on Mac OS X to
1966         open the bug URL in the default web browser.  If there are
1967         similar mechanisms on other platforms, they may be added later.
1968
1969         * Scripts/mark-bug-fixed:
1970         (MarkBugFixed.__init__): Added -o|--open switch to list of parse
1971         options.
1972         (MarkBugFixed._determine_bug_id_and_svn_revision): Moved logging
1973         code into main() and extracted prompting code into
1974         _prompt_user_for_correctness().
1975         (MarkBugFixed._open_bug_in_web_browser): Added.
1976         (MarkBugFixed._prompt_user_for_correctness): Added.
1977         (MarkBugFixed.main): Added logging code from
1978         _determine_bug_id_and_svn_revision().  Added code to call
1979         _open_bug_in_web_browser() if the switch is set.  Added code to
1980         call _prompt_user_for_correctness() when needed.
1981         * Scripts/modules/bugzilla.py:
1982         (Bugzilla.short_bug_url_for_bug_id): Added.
1983
1984 2009-09-26  David Kilzer  <ddkilzer@apple.com>
1985
1986         svn-unapply and svn-apply don't work when used outside multiple svn working directories
1987
1988         <http://webkit.org/b/29744>
1989         <rdar://problem/7252905>
1990
1991         Reviewed by Eric Seidel.
1992
1993         Some users have a workflow where svn-create-patch, svn-apply and
1994         svn-unapply are used outside of multiple svn working
1995         directories.  Instead of aborting the scripts in these cases,
1996         print a warning and assume that Subversion is being used.
1997
1998         * Scripts/VCSUtils.pm:
1999         (determineVCSRoot): Call warn() instead of die() if both isGit()
2000         and isSVN() initially return false.  Set $VCSUtils::isSVN to 1
2001         to enforce the assumption about Subversion, then return
2002         determineSVNRoot().
2003         * Scripts/svn-apply: Switch to using isGit() and isSVN() from
2004         VCSUtils.pm.  They both already cache their values and checking
2005         here is redundant since determineVCSRoot() is called later.
2006
2007 2009-09-26  Zan Dobersek  <zandobersek@gmail.com>
2008
2009         Reviewed by Gustavo Noronha.
2010
2011         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
2012         https://bugs.webkit.org/show_bug.cgi?id=29689
2013
2014         Load test fonts through FontConfig before each test.
2015         This ensures a more proper rendering of the tests.
2016
2017         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2018         (initializeFonts):
2019         (runTest):
2020         (main):
2021         * DumpRenderTree/gtk/fonts.conf: Copied from WebKitTools/DumpRenderTree/qt/fonts.conf.
2022         * GNUmakefile.am:
2023
2024 2009-09-25  David Kilzer  <ddkilzer@apple.com>
2025
2026         <http://webkit.org/b/29718> mark-bug-fixed: add -u|--update-only switch
2027
2028         Reviewed by Eric Seidel.
2029
2030         * Scripts/mark-bug-fixed:
2031         (MarkBugFixed.__init__): Added -u|--update-only switch to list
2032         of parse options.
2033         (MarkBugFixed.main): When -u|--update-only is specified, add a
2034         comment to the bug without marking it Resolved/Fixed.
2035
2036 2009-09-25  Darin Adler  <darin@apple.com>
2037
2038         Reviewed by Geoffrey Garen.
2039
2040         * Scripts/prepare-ChangeLog: Leave files from the script-tests directory
2041         out, just as we do for the resources directory.
2042
2043 2009-09-25  Adam Barth  <abarth@webkit.org>
2044
2045         Unreviewed.  Added Tony to committers.py because he's a
2046         committer now.
2047
2048         * Scripts/modules/committers.py:
2049
2050 2009-09-25  Eric Seidel  <eric@webkit.org>
2051
2052         Reviewed by Simon Fraser.
2053
2054         REGRESSION: media/video-pause-empty-events.html is occasionally timing out on bots
2055         https://bugs.webkit.org/show_bug.cgi?id=28624
2056
2057         Disable hardware compositing on Leopard for versions of QuickTime 7.6.4 and older.
2058
2059         * DumpRenderTree/mac/DumpRenderTree.mm:
2060         (resetDefaultsToConsistentValues):
2061
2062 2009-09-25  Eric Seidel  <eric@webkit.org>
2063
2064         Reviewed by Adam Barth.
2065
2066         commit-queue should auto-retry patches which fail to commit due to out of date files
2067         https://bugs.webkit.org/show_bug.cgi?id=28316
2068
2069         * Scripts/bugzilla-tool:
2070          - Handle new CheckoutNeedsUpdate exception.
2071         * Scripts/modules/logging_unittest.py:
2072          - Call the ScriptError constructor correctly (this test had regressed).
2073         * Scripts/modules/scm.py:
2074          - Added the ability to define custom error handlers for run_command
2075            and added a commit_error_handler which throws CheckoutNeedsUpdate
2076            instead of ScriptError.
2077          - Re-ordered ScriptError constructor arguments to make ScriptError("message text") usage possible.
2078         * Scripts/modules/scm_unittest.py:
2079          - Added tests of new error handlers.
2080
2081 2009-09-25  Eric Seidel  <eric@webkit.org>
2082
2083         Reviewed by Adam Barth.
2084
2085         commit-queue should give better feedback when failing a patch
2086         https://bugs.webkit.org/show_bug.cgi?id=29316
2087
2088         * Scripts/bugzilla-tool:
2089          - Update ScriptError uses to the new constructor format.
2090          - Move CommitQueue._run_command to WebKitLandingScripts.run_command_with_teed_output
2091            so that we can print to both stdout as well as an output buffer for error reporting.
2092          - Update run_and_throw_if_fail to use teed output so that it can report the "output" as part of ScriptError.
2093          - Use e.message_with_output() when failing a patch (this is the real fix here).
2094            I also removed use of "This patch will require manual commit." as that's not always true.
2095          - Add missing word "bug" from log message.
2096         * Scripts/modules/scm.py:
2097          - Make ScriptError save a bunch more data so that error messages can be nicer.
2098          - Update ScriptError callers.
2099
2100 2009-09-24  John Gregg  <johnnyg@google.com>
2101
2102         Reviewed by Eric Seidel.
2103
2104         Enable switch for notifications (experimental) in Page Settings
2105         https://bugs.webkit.org/show_bug.cgi?id=28930
2106
2107         Now that desktop notifications are controlled by run-time switch,
2108         set that switch to true for DumpRenderTree.
2109
2110         * DumpRenderTree/mac/DumpRenderTree.mm:
2111         (resetDefaultsToConsistentValues):
2112         * DumpRenderTree/win/DumpRenderTree.cpp:
2113         (resetDefaultsToConsistentValues):
2114         * DumpRenderTree/win/UIDelegate.cpp:
2115         (UIDelegate::QueryInterface):
2116
2117 2009-09-24  Kevin Ollivier  <kevino@theolliviers.com>
2118
2119         wx build fix. SnowLeopard fixes for Mac dependencies.
2120
2121         * wx/build/build_utils.py:
2122         * wx/build/settings.py:
2123         * wx/install-unix-extras:
2124
2125 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2126
2127         Reviewed by Oliver Hunt.
2128
2129         Add support for DRT to send mouse wheel events.
2130
2131         https://bugs.webkit.org/show_bug.cgi?id=29348
2132         [Gtk] Scrollwheel on horizontal scrollbars should slide horizontally
2133
2134         * DumpRenderTree/gtk/EventSender.cpp:
2135         (mouseWheelToCallback):
2136
2137 2009-09-17  Eric Seidel  <eric@webkit.org>
2138
2139         Reviewed by David Levin.
2140
2141         commit-queue needs web-based status reporting
2142         https://bugs.webkit.org/show_bug.cgi?id=29307
2143
2144         Add a first-pass web-based status for the commit-queue.
2145         The bot is currently reachable at:
2146         http://webkit-commit-queue.appspot.com/
2147
2148         * CommitQueueStatus/app.yaml: Added.
2149          - Application description file required by App Engine.
2150         * CommitQueueStatus/filters/__init__.py: Added.
2151          - Required by python to treat 'filters' as a module.
2152         * CommitQueueStatus/filters/webkit_extras.py: Added.
2153          - Support for turning 'bug 123' and 'patch 123' into links.
2154            This lets us use plain text strings in our logs yet display nice HTML (help prevent XSS attacks on the page).
2155         * CommitQueueStatus/index.html: Added.
2156         * CommitQueueStatus/index.yaml: Added.
2157          - Some auto-generated file from app engine.
2158         * CommitQueueStatus/queue_status.py: Added.
2159          - The core logic of this bot.  We could eventually split this file out into pieces.
2160         * CommitQueueStatus/stylesheets/main.css: Added.
2161          - Some basic lame-o CSS to make the page look less awful.
2162         * CommitQueueStatus/update_status.html: Added.
2163          - The form that the commit-queue (or a human) can use to update the status.
2164         * Scripts/bugzilla-tool:
2165          - Add some very basic update_status calls.
2166         * Scripts/modules/statusbot.py: Added.
2167          - Knows how to post to the CommitQueueStatus web application.
2168
2169 2009-09-24  David Kilzer  <ddkilzer@apple.com>
2170
2171         <http://webkit.org/b/29712> mark-bug-fixed: add -m|--comment switch
2172
2173         Reviewed by Adam Roben.
2174
2175         * Scripts/mark-bug-fixed:
2176         (MarkBugFixed.__init__): Added -m|--comment switch to list of
2177         parse options.
2178         (MarkBugFixed.main): When specified, prepend comment from
2179         -m|--comment command-line switch to the bug comment.
2180
2181 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2182
2183         Reviewed by Jan Alonzo.
2184
2185         [GTK] DRT must display window instead of just realizing, to enable synthesizing events correctly
2186         https://bugs.webkit.org/show_bug.cgi?id=29693
2187
2188         Show the window, to be able to synthesize events correctly.
2189
2190         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2191         (runTest):
2192         (main):
2193
2194 2009-09-24  Oliver Hunt  <oliver@apple.com>
2195
2196         Reviewed by NOBODY(rollout)
2197
2198         Roll out r48712 as it is incorrect.
2199
2200         * DumpRenderTree/mac/ObjCController.m:
2201         (+[ObjCController isSelectorExcludedFromWebScript:]):
2202         (+[ObjCController webScriptNameForSelector:]):
2203
2204 2009-09-24  Benjamin Poulain  <benjamin.poulain@nokia.com>
2205
2206         Reviewed by Eric Seidel.
2207
2208         https://bugs.webkit.org/show_bug.cgi?id=29005
2209         The indices of RuntimeArray should be enumerated like for a regular array.
2210
2211         * DumpRenderTree/mac/ObjCController.m:
2212         (+[ObjCController isSelectorExcludedFromWebScript:]):
2213         (+[ObjCController webScriptNameForSelector:]):
2214         (-[ObjCController arrayOfString]):
2215
2216 2009-09-23  David Kilzer  <ddkilzer@apple.com>
2217
2218         <http://webkit.org/b/28910> Move bugzilla-tool mark-fixed to standalone mark-bug-fixed tool
2219
2220         Reviewed by Darin Adler.
2221
2222         Also fixed a bug where specifying a revision on the command-line
2223         as 'r12345' would fail.  See <http://webkit.org/b/29699>.
2224
2225         * Scripts/bugzilla-tool: Updated module import statements.
2226         (parse_bug_id): Removed.  Moved to bugzilla.py.
2227         (bug_comment_from_svn_revision): Removed.  Moved to comments.py.
2228         (bug_comment_from_commit_text): Removed.  Moved to comments.py.
2229         (MarkBugFixed): Removed.  Code moved to mark-bug-fixed.
2230         (BugzillaTool.__init__): Removed mark-fixed subcommand.
2231         * Scripts/mark-bug-fixed: Added.
2232         * Scripts/modules/bugzilla.py:
2233         (parse_bug_id): Added.  Moved from bugzilla-tool.
2234         * Scripts/modules/comments.py: Added.
2235         (bug_comment_from_svn_revision): Added.  Moved from bugzilla-tool.
2236         (bug_comment_from_commit_text): Added.  Moved from bugzilla-tool.
2237
2238 2009-09-23  Marshall Culpepper  <mculpepper@appcelerator.com>
2239
2240         Reviewed by Eric Seidel.
2241         
2242          jpeg.lib is now libjpeg.lib in DRT Cairo dependencies. return
2243          "false" in non-implemented stub for setAlwaysAcceptCookies.
2244          https://bugs.webkit.org/show_bug.cgi?id=29661
2245
2246         * DumpRenderTree/win/DumpRenderTree.vcproj:
2247         * DumpRenderTree/win/DumpRenderTree.cpp:
2248
2249 2009-09-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2250
2251         Reviewed by Xan Lopez.
2252
2253         [GTK] need to dump number of pending unload handlers
2254         https://bugs.webkit.org/show_bug.cgi?id=29685
2255
2256         Implement dumping of the number of pending unload handlers.
2257
2258         The following tests will pass:
2259
2260           fast/loader/unload-form-about-blank.html
2261           fast/loader/unload-form-post-about-blank.html
2262           fast/loader/unload-form-post.html
2263           fast/loader/unload-form.html
2264           fast/loader/unload-hyperlink.html
2265           fast/loader/unload-javascript-url.html
2266           fast/loader/unload-reload.html
2267           fast/loader/unload-window-location.html
2268
2269         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2270         (getFrameNameSuitableForTestResult):
2271         (webViewLoadFinished):
2272
2273 2009-09-22  Shinichiro Hamaji  <hamaji@chromium.org>
2274
2275         Reviewed by Eric Seidel.
2276
2277         js tests should move into jstests subdirectory instead of resources/
2278         https://bugs.webkit.org/show_bug.cgi?id=25880
2279
2280         Remove support of resources directory.
2281
2282         * Scripts/make-script-test-wrappers:
2283
2284 2009-09-22  Eric Seidel  <eric@webkit.org>
2285
2286         No review, only fixing typo (missing space character).
2287
2288         Fix typo from https://bugs.webkit.org/show_bug.cgi?id=29220
2289
2290         * Scripts/run-webkit-tests:
2291
2292 2009-09-22  Eric Seidel  <eric@webkit.org>
2293
2294         Reviewed by Darin Adler.
2295
2296         run-webkit-tests needs a --repeat-each=N option (AAABBBCCC instead of ABCABCABC)
2297         https://bugs.webkit.org/show_bug.cgi?id=29220
2298
2299         * Scripts/run-webkit-tests:
2300
2301 2009-09-22  Eric Seidel  <eric@webkit.org>
2302
2303         Reviewed by David Kilzer.
2304
2305         svn-apply can't handle single-line binary file additions
2306         https://bugs.webkit.org/show_bug.cgi?id=29100
2307
2308         Fixed the regexp and added a unit test.
2309
2310         * Scripts/modules/scm_unittest.py:
2311         * Scripts/svn-apply:
2312
2313 2009-09-11  Eric Seidel  <eric@webkit.org>
2314
2315         Reviewed by David Kilzer.
2316
2317         post-diff and post-commits should be able to find bug urls in ChangeLogs.
2318         https://bugs.webkit.org/show_bug.cgi?id=29206
2319
2320         * Scripts/bugzilla-tool:
2321          - Share common options by adding a PostDiffAsPatchToBug.posting_options() method.
2322          - Rename --no-comment to --add-log-as-comment and reverse behavior.
2323            Comments tend to just be noise.  I'll eventually remove this argument if no one uses it.
2324          - Split out code into helper functions to try and make execute() more legible.
2325          - Make post-diff find the bug url in the ChangeLogs if not passed as an argument.
2326          - Fallback to bug urls in commit diffs, instead of just in commit messages,
2327            meaning post-commits will now find bug urls in ChangeLogs.
2328
2329 2009-09-21  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
2330
2331         Reviewed by Maciej Stachowiak.
2332
2333         --parse-only parameter wasn't passed to SunSpider/sunspider script.
2334         https://bugs.webkit.org/show_bug.cgi?id=29611
2335
2336         * Scripts/run-sunspider: Missing parameter passing added.
2337
2338 2009-09-20  David Kilzer  <ddkilzer@apple.com>
2339
2340         <http://webkit.org/b/29521> run-webkit-tests: use require instead eval to load DumpRenderTreeSupport module
2341
2342         Reviewed by Mark Rowe.
2343
2344         The require statement is like the use statement, except that it
2345         is run during script execution instead of during the 'BEGIN'
2346         phase.  This makes it possible to change @INC before the require
2347         statement is run.  See 'require' and 'use' in the perlfunc(1)
2348         manpage and 'BEGIN' in perlmod(1) manpage.
2349
2350         * Scripts/run-webkit-tests: Replace eval statement with require
2351         statement.
2352
2353 2009-09-18  Kevin Ollivier  <kevino@theolliviers.com>
2354
2355         wx build fixes. Fix the config name under git and allow users to specify
2356         their own waf install for experimenting with new versions.
2357
2358         * Scripts/webkitdirs.pm:
2359         * wx/build/settings.py:
2360
2361 2009-09-18  Alex Milowski  <alex@milowski.com>
2362
2363         Reviewed by Maciej Stachowiak.
2364
2365         Added checkWebCoreMathMLSupport and hasMathMLSupport to support 
2366         checking for whether MathML tests should be run
2367
2368         * Scripts/run-webkit-tests:
2369         * Scripts/webkitdirs.pm:
2370
2371 2009-08-28  Darin Adler  <darin@apple.com>
2372
2373         Reviewed by Mark Rowe.
2374
2375         Break more of run-webkit-tests into separate functions
2376         https://bugs.webkit.org/show_bug.cgi?id=29497
2377
2378         Some small steps toward improving run-webkit-tests. My goal is to
2379         refactor much more of the script into functions. Later we can add
2380         parallel test running to the tool. But better structure may help
2381         even if someone decides to translate this into another scripting
2382         language instead.
2383
2384         * Scripts/run-webkit-tests: Break more pieces of the script into
2385         seprate functions. Added readSkippedFiles, findTestsToRun, and
2386         printResults functions. Removed custom code to skip results.html
2387         and instead just put it into the ignoredFiles hash. Fixed some
2388         indentation. Sorted function declarations, global variables,
2389         and options at the top of the file alphabetically so they're not
2390         in a semi-random order.
2391
2392 2009-09-17  Kevin Ollivier  <kevino@theolliviers.com>
2393
2394         wx build fix, add missing dependency.
2395
2396         * wx/browser/wscript:
2397
2398 2009-09-16  Mark Rowe  <mrowe@apple.com>
2399
2400         Split the SnowLeopard build across a few machines.
2401
2402         * BuildSlaveSupport/build.webkit.org-config/config.json:
2403
2404 2009-09-16  Kevin Ollivier  <kevino@theolliviers.com>
2405
2406         wx build fix to support monolithic builds on Windows.
2407
2408         * wx/build/wxpresets.py:
2409
2410 2009-09-16  Kevin Ollivier  <kevino@theolliviers.com>
2411
2412         wx build fix, improve debug support and 2.9 support on MSW.
2413
2414         * wx/build/settings.py:
2415         * wx/build/wxpresets.py:
2416
2417 2009-09-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2418
2419         Blind try at fixing new test failure on Windows.
2420
2421         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2422         (FrameLoadDelegate::didReceiveTitle):
2423
2424 2009-09-15  Alex Milowski  <alex@milowski.com>
2425
2426         Reviewed by Tor Arne Vestbø.
2427
2428         Added mathml toggle
2429
2430         * Scripts/build-webkit:
2431
2432 2009-09-15  Kevin Ollivier  <kevino@theolliviers.com>
2433
2434         wx build fix. Allow waf build to support Python < 2.6.
2435
2436         * wx/build/waf_extensions.py:
2437
2438 2009-09-14  Chris Marrin  <cmarrin@apple.com>
2439
2440         Reviewed by Oliver Hunt.
2441
2442         Add LayoutTests infrastructure to enable and disable webgl tests.
2443         https://bugs.webkit.org/show_bug.cgi?id=29254
2444
2445         * Scripts/run-webkit-tests:
2446         * Scripts/webkitdirs.pm:
2447
2448 2009-09-14  Simon Fraser  <simon.fraser@apple.com>
2449
2450         Reviewed by Darin Adler.
2451         
2452         Add --iterations option to run-webkit-tests to repeat the tests N times
2453         https://bugs.webkit.org/show_bug.cgi?id=29263
2454
2455         When run with --iterations N, run-webkit-tests will repeat the tests N times.
2456
2457         * Scripts/run-webkit-tests:
2458
2459 2009-09-14  Brady Eidson  <beidson@apple.com>
2460
2461         Not reviewed, maybe should've been:
2462
2463         Cleaning up more Windows-specific fallout from the fix for:
2464         <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160
2465
2466         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2467         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):  Correct printf() formatter, 
2468           and call the correct method to get the Sender.
2469
2470 2009-09-14  Jon Honeycutt  <jhoneycutt@apple.com>
2471
2472         GTK build fix.
2473
2474         Unreviewed.
2475
2476         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2477         (AccessibilityController::setLogScrollingStartEvents):
2478
2479 2009-09-11  Jon Honeycutt  <jhoneycutt@apple.com>
2480
2481         DRT/test part of
2482         <rdar://problem/7197644> WebKit should broadcast an MSAA event when
2483         jumping to a named anchor
2484
2485         https://bugs.webkit.org/show_bug.cgi?id=28899
2486
2487         Reviewed by Adam Roben.
2488
2489         * DumpRenderTree/AccessibilityController.cpp:
2490         (logScrollingStartEventsCallback):
2491         Turn on logging of scrolling start events.
2492         (AccessibilityController::getJSClass):
2493         Add a "logScrollingStartEvents" to the AccessibilityController's JS
2494         class definition.
2495         (AccessibilityController::resetToConsistentState):
2496         Turn off logging of scrolling start events.
2497
2498         * DumpRenderTree/AccessibilityController.h:
2499         Declare setLogScrollingStartEvents(). Add a member for the scrolling
2500         start event hook.
2501
2502         * DumpRenderTree/mac/AccessibilityControllerMac.cpp:
2503         (AccessibilityController::setLogScrollingStartEvents):
2504         Stubbed.
2505
2506         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2507         (AccessibilityController::AccessibilityController):
2508         Initialize the handle to 0.
2509         (logEventProc):
2510         Renamed from logFocusEventProc; now logs scrolling start events, too.
2511         Removed the assertion that the event is a focus event. Added a switch
2512         to print a message for focus, scrolling start, and other, unknown
2513         events.
2514         (AccessibilityController::setLogFocusEvents):
2515         Changed to use logEventProc.
2516         (AccessibilityController::setLogScrollingStartEvents):
2517         If turning logging off, unhook the scrolling start event hook, and clear
2518         the member holding the handle. If turning on, query for the root
2519         accessible, so that accessibility is enabled for the WebView, and call
2520         SetWinEventHook to setup an event hook using logEventProc as the
2521         callback function.
2522
2523 2009-09-14  Brady Eidson  <beidson@apple.com>
2524
2525         Windows build fix.
2526
2527         * DumpRenderTree/LayoutTestController.cpp:
2528         (setAuthenticationPasswordCallback):
2529         (setAuthenticationUsernameCallback):
2530         
2531         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2532         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2533
2534 2009-09-14  Brady Eidson  <beidson@apple.com>
2535
2536         Reviewed by Alexey Proskuryakov.
2537
2538         Safari 4 cannot be used to update firmware on Linksys routers.
2539         <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160
2540
2541         Add the ability for DRT to handle authentication challenges.
2542
2543         * DumpRenderTree/LayoutTestController.cpp:
2544         (setAuthenticationPasswordCallback):
2545         (setAuthenticationUsernameCallback):
2546         (setHandlesAuthenticationChallengesCallback):
2547         (LayoutTestController::staticFunctions):
2548
2549         * DumpRenderTree/LayoutTestController.h:
2550         (LayoutTestController::handlesAuthenticationChallenges):
2551         (LayoutTestController::setHandlesAuthenticationChallenges):
2552         (LayoutTestController::authenticationUsername):
2553         (LayoutTestController::setAuthenticationUsername):
2554         (LayoutTestController::authenticationPassword):
2555         (LayoutTestController::setAuthenticationPassword):
2556
2557         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2558         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
2559
2560         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2561         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2562         * DumpRenderTree/win/ResourceLoadDelegate.h:
2563
2564 2009-09-12  Mark Rowe  <mrowe@apple.com>
2565
2566         Reviewed by Dan Bernstein.
2567
2568         Test for <rdar://problem/6954546> and <rdar://problem/7090444>.
2569
2570         Add a flag on the test plug-in that asks it to clear the document during the call to NPP_New.
2571         This is the trigger for both <rdar://problem/6954546> and <rdar://problem/7090444>.
2572
2573         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2574         (NPP_New):
2575
2576 2009-09-14  Kevin Ollivier  <kevino@theolliviers.com>
2577
2578         wx build fix for non-wxPython builds and a fix for errors when updating swig.py.
2579
2580         * wx/build/build_utils.py:
2581         * wx/build/settings.py:
2582
2583 2009-09-14  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
2584
2585         Reviewed by Tor Arne Vestbø.
2586
2587         [Qt] Build fix for windows build.
2588
2589         * Scripts/bisect-builds: Add missing paranthesis for tmpdir function.
2590
2591 2009-09-13  Kevin Ollivier  <kevino@theolliviers.com>
2592
2593         Fix typo accidently landed in last commit.
2594
2595         * wx/build/settings.py:
2596
2597 2009-09-13  Kevin Ollivier  <kevino@theolliviers.com>
2598
2599         wx build fix, error out if using the wrong Python.
2600
2601         * wx/build/settings.py:
2602
2603 2009-09-13  Xan Lopez  <xlopez@igalia.com>
2604
2605         Build fix for GTK+ < 2.14.
2606
2607         Do not use gtk_widget_get_window, access the window directly
2608         through the struct.
2609
2610         * DumpRenderTree/gtk/EventSender.cpp:
2611         (contextClickCallback):
2612         (mouseDownCallback):
2613         (mouseUpCallback):
2614         (mouseMoveToCallback):
2615         (keyDownCallback):
2616
2617 2009-09-13  Martin Robinson  <martin.james.robinson@gmail.com>
2618
2619         Reviewed by Xan Lopez and Jan Alonzo.
2620
2621         [GTK] EventSender does not set 'window' property on synthesized GDK events
2622         https://bugs.webkit.org/show_bug.cgi?id=29169
2623
2624         Set the window property on synthesized GDK events in the GTK+ EventSender.
2625
2626         * DumpRenderTree/gtk/EventSender.cpp:
2627         (contextClickCallback):
2628         (mouseDownCallback):
2629         (mouseUpCallback):
2630         (mouseMoveToCallback):
2631         (keyDownCallback):
2632
2633 2009-09-12  Drew Wilson  <atwilson@google.com>
2634
2635         Reviewed by Mark Rowe.
2636
2637         run-webkit-tests has a timeout value that is too low
2638         https://bugs.webkit.org/show_bug.cgi?id=29223
2639
2640         * Scripts/run-webkit-tests:
2641         Changed timeout value to 20 seconds to avoid timing out too early.
2642
2643 2009-09-11  Kevin Ollivier  <kevino@theolliviers.com>
2644
2645         wx build fix. Mark dependencies as mandatory and declare which MSVC versions and
2646         architectures are supported for building wxWebKit.
2647
2648         * wx/build/settings.py:
2649
2650 2009-09-11  Eric Seidel  <eric@webkit.org>
2651
2652         Reviewed by David Levin.
2653
2654         bugzilla-tool rollout threw exception under svn
2655         https://bugs.webkit.org/show_bug.cgi?id=29211
2656
2657         * Scripts/modules/scm.py: add missing return, and convert number arguments to strings.
2658         * Scripts/modules/scm_unittest.py: add testing for this fix.
2659
2660 2009-09-11  Brian Weinstein  <bweinstein@apple.com>
2661
2662         Add myself to the committers list.
2663
2664         * Scripts/modules/committers.py:
2665
2666 2009-09-11  Eric Seidel  <eric@webkit.org>
2667
2668         Reviewed by Adam Barth.
2669
2670         bugzilla-tool land-patches should only fail-fast in --commit-queue mode
2671         https://bugs.webkit.org/show_bug.cgi?id=29201
2672
2673         * Scripts/bugzilla-tool:
2674
2675 2009-09-11  Adam Roben  <aroben@apple.com>
2676
2677         Make commit-log-editor move common prefixes to the top of the log
2678
2679         Fies <http://webkit.org/b/29190> commit-log-editor should move common
2680         prefixes to the top of the commit log
2681
2682         Reviewed by Darin Adler.
2683
2684         * Scripts/commit-log-editor: Find and remove the longest common prefix
2685         ending in a double newline from each ChangeLog entry, then put that
2686         common prefix at the top of the commit log.
2687         (removeLongestCommonPrefixEndingInDoubleNewline): Added. Finds,
2688         removes, and returns the longest common prefix ending in a double
2689         newline from a hash of strings
2690
2691 2009-09-11  Eric Seidel  <eric@webkit.org>
2692
2693         Fix obvious typo in previous commit, no review.
2694
2695         bugzilla-tool should automate rollouts
2696         https://bugs.webkit.org/show_bug.cgi?id=26715
2697
2698         * Scripts/bugzilla-tool: add back missing "scm" argument.
2699
2700 2009-09-11  Eric Seidel  <eric@webkit.org>
2701
2702         Reviewed by Adam Barth.
2703
2704         bugzilla-tool should automate rollouts
2705         https://bugs.webkit.org/show_bug.cgi?id=26715
2706
2707         bugzilla-tool rollout will do the rollout locally and leave the diff for you to verify and commit.
2708         The --complete-rollout option will automatically land and update the bug.
2709         Eventually --complete-rollout will be default, but that will require more testing.
2710
2711         This first pass is good enough for others to try and file bugs about.
2712
2713         * Scripts/bugzilla-tool:
2714          - Move modified_changelogs into scm.py.
2715          - Move svn_revision_from_commit_text logic into scm.py.
2716          - Add RolloutCommit command.
2717         * Scripts/modules/bugzilla.py:
2718          - Add reopen_bug command used by RolloutCommit.
2719         * Scripts/modules/scm.py:
2720          - Add functions to support RolloutCommit.
2721          - Abstract find_uuid into value_from_svn_info so it can be re-used for _repository_url (needed by svn merge).
2722          - Add a str() call so that svn_commit_log can take a numeric argument.
2723          - Remove a bunch of very slow code from last_svn_commit_log and used the built-in 'BASE' alias instead.
2724          - Made dry_run commits return something that svn_revision_from_commit_text can parse.
2725         * Scripts/modules/scm_unittest.py:
2726          - Add read_from_path for easy file reading.
2727          - Put test4 on a new line to make reverts work w/o conflict.
2728          - Add an "svn update" call so that the checkout revision matches the server revision.
2729          - Add tests for svn_revision_from_commit_text.
2730          - Add a simple test for apply_reverse_diff.
2731          - Add a new self.scm member and use it in the new tests (eventually other tests can use it too).
2732          - Add test for svn_commit_log to make sure my 'BASE' change above worked as expected.
2733
2734 2009-09-11  Adam Roben  <aroben@apple.com>
2735
2736         Get user script/stylesheet tests running on Windows
2737
2738         Fixes <http://webkit.org/b/29181> User script/stylesheet tests are
2739         skipped on Windows
2740
2741         Reviewed by John Sullivan.
2742
2743         * DumpRenderTree/win/DumpRenderTree.vcproj: Link all configurations
2744         against comsuppw.lib so we can use _bstr_t.
2745
2746         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Fixed #include
2747         order, added #include of comutil.h for _bstr_t.
2748
2749         (bstrT): Helper function to convert a JSStringRef to a _bstr_t.
2750         (LayoutTestController::addUserScript):
2751         (LayoutTestController::addUserStyleSheet):
2752         Implemented. Implementations were based on those in
2753         LayoutTestControllerMac.mm.
2754
2755 2009-09-10  David Kilzer  <ddkilzer@apple.com>
2756
2757         <http://webkit.org/b/29147> run-webkit-tests:  make -h show help 
2758
2759         Reviewed by Mark Rowe.
2760
2761         * Scripts/run-webkit-tests: Updated to make -h switch show help.
2762
2763 2009-09-10  Fumitoshi Ukai  <ukai@chromium.org>
2764
2765         Reviewed by Alexey Proskuryakov.
2766
2767         Add WebCore/websockets directory in wx build system.
2768         https://bugs.webkit.org/show_bug.cgi?id=28038
2769
2770         * wx/build/settings.py:
2771
2772 2009-09-10  Martin Robinson  <martin.james.robinson@gmail.com>
2773
2774         [GTK] EventSender does not properly convert some keyDown strings
2775         https://bugs.webkit.org/show_bug.cgi?id=29119
2776
2777         Add more keyDown string to character code conversions for GTK+ EventSender.
2778
2779         * DumpRenderTree/gtk/EventSender.cpp:
2780         (keyDownCallback):
2781
2782 2009-09-09  Steve Block  <steveblock@google.com>
2783
2784         Reviewed by Maciej Stachowiak.
2785
2786         Geolocation Coordinates::toString() prints bogus values for unspecified properties.
2787         https://bugs.webkit.org/show_bug.cgi?id=29080
2788
2789         * Scripts/make-script-test-wrappers: Modified. Adds asynchronous Geolocation tests to exclusion list.
2790
2791 2009-09-09  Eric Seidel  <eric@webkit.org>
2792
2793         Reviewed by Eric Carlson.
2794
2795         reviewer/committer lookups are backwards
2796         https://bugs.webkit.org/show_bug.cgi?id=29113
2797
2798         I also moved Eric Carlson from the committer list to the reviewer list now that he is one.
2799
2800         * Scripts/modules/bugzilla.py:
2801         * Scripts/modules/committers.py:
2802
2803 2009-09-09  Cameron McCormack  <cam@mcc.id.au>
2804
2805         Reviewed by Eric Seidel.
2806
2807         svn-unapply doesn't revert directories correctly
2808         https://bugs.webkit.org/show_bug.cgi?id=29065
2809
2810         * Scripts/svn-unapply: Make svnStatus consistently return status
2811         lines including a newline.
2812         * Scripts/svn-apply: Keep svnStatus in sync with the one in
2813         svn-unapply, in lieu of moving it to a common file.
2814
2815 2009-09-09  Cameron McCormack  <cam@mcc.id.au>
2816
2817         Reviewed by Eric Seidel.
2818
2819         svn-apply doesn't handle changes to files copied to new directories properly
2820         https://bugs.webkit.org/show_bug.cgi?id=29059
2821
2822         * Scripts/svn-apply: Don't treat "--- revision 0" patches as being
2823         additions if we know that we've just copied a file to this name.
2824
2825 2009-09-09  Eric Seidel  <eric@webkit.org>
2826
2827         Reviewed by David Levin.
2828
2829         commit-queue hangs if a builder has never built
2830         https://bugs.webkit.org/show_bug.cgi?id=29091
2831
2832         * Scripts/modules/buildbot.py:
2833         * Scripts/modules/buildbot_unittest.py:
2834
2835 2009-09-09  Zan Dobersek  <zandobersek@gmail.com>
2836
2837         Reviewed by Gustavo Noronha.
2838
2839         [GTK] DumpRenderTree needs eventSender object and implementation
2840         https://bugs.webkit.org/show_bug.cgi?id=25990
2841
2842         Implements most of the EventSender object's functionality for
2843         the DumpRenderTree tool. Implementation still lacks support
2844         for drag and drop tests and forward leaps.
2845
2846         Based on work by Holger Hans Peter Freyther.
2847
2848         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2849         (runTest): Focus on the view before loading a new test.
2850         (webViewWindowObjectCleared):
2851         * DumpRenderTree/gtk/EventSender.cpp: Added.
2852         (getDragModeCallback):
2853         (setDragModeCallback):
2854         (leapForwardCallback):
2855         (contextClickCallback):
2856         (updateClickCount):
2857         (mouseDownCallback):
2858         (mouseUpCallback):
2859         (mouseMoveToCallback):
2860         (beginDragWithFilesCallback):
2861         (replaySavedEvents):
2862         (keyDownCallback):
2863         (textZoomInCallback):
2864         (textZoomOutCallback):
2865         (zoomPageInCallback):
2866         (zoomPageOutCallback):
2867         (getClass):
2868         (makeEventSender):
2869         * DumpRenderTree/gtk/EventSender.h: Added.
2870         * GNUmakefile.am: Add build rules for EventSender.
2871
2872 2009-09-09  Daniel Bates  <dbates@webkit.org>
2873
2874         Reviewed by Adam Roben.
2875         
2876         https://bugs.webkit.org/show_bug.cgi?id=28953
2877
2878         Added pre- and post- build events so that on build failure, the file 
2879         buildfailed is written to the directory $(WebKitOutputDir).
2880
2881         * WinLauncher/WinLauncher.vcproj:
2882
2883 2009-09-09  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2884
2885         Unreviewed.
2886
2887         Add myself to list of committers.
2888
2889         * Scripts/modules/committers.py:
2890
2891 2009-09-08  Eric Seidel  <eric@webkit.org>
2892
2893         Reviewed by David Levin.
2894
2895         commit-queue gets stuck if a non-committer sets commit-queue+ or review+
2896         https://bugs.webkit.org/show_bug.cgi?id=28605
2897         https://bugs.webkit.org/show_bug.cgi?id=28916
2898
2899         * Scripts/bugzilla-tool:
2900          - Fix comment and adjust reject_patch_from_commit_queue call to pass "manual commit"
2901            comment now that it's used for rejecting patches for invalid committers too.
2902          - Pass reject_invalid_patches=True for commit-queue calls, normally we just ignore patches with invalid reviewers, the commit-queue rejects them.
2903          - Make the commit queue print patches count instead of bugs count, this also fixes https://bugs.webkit.org/show_bug.cgi?id=28916.
2904         * Scripts/modules/bugzilla.py:
2905          - Make _parse_attachment_element not validate reviewer/committer.
2906          - Share flag parsing code in _parse_attachment_flag.
2907          - Add _validate* methods for validating reviewers and committers and updating bugs when validation fails.
2908          - Add reject_invalid_patches argument so the commit-queue can update bugs on failed validation and other "read only" commands will not.
2909          - Add reject_patch_from_review_queue using a new _set_flag_on_attachment abstraction.
2910         * Scripts/modules/bugzilla_unittest.py:
2911          - Update this test to no longer expect committer/reviewer validation.
2912         * Scripts/modules/committers.py:
2913          - Return None on failed lookups instead of raising Exceptions.
2914         * Scripts/modules/committers_unittest.py:
2915          - Update tests to expect None returns instead of exceptions.
2916
2917 2009-09-09  David Kilzer  <ddkilzer@apple.com>
2918
2919         <http://webkit.org/b/29061> Fix obvious copy-paste error in AccessibilityUIElement::clickPointY()
2920
2921         Reviewed by Mark Rowe.
2922
2923         No change to layout test results.
2924
2925         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2926         (AccessibilityUIElement::clickPointY): Changed to return y value
2927         instead of x value.
2928
2929 2009-09-08  Dimitri Glazkov  <dglazkov@chromium.org>
2930
2931         Reviewed by Mark Rowe.
2932
2933         Reduce dglazkov's boboiness by properly concatenating revision value.
2934
2935         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Used substitution
2936             rather than "+".
2937
2938 2009-09-08  Kevin Ollivier  <kevino@theolliviers.com>
2939
2940         wxWebKit Python extension build fix - get swig.py if it doesn't exist.
2941
2942         * wx/build/build_utils.py:
2943
2944 2009-09-08  Mark Rowe  <mrowe@apple.com>
2945
2946         Fix an incorrect variable name in UpdateChromiumSource.
2947
2948         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2949
2950 2009-09-08  Mark Rowe  <mrowe@apple.com>
2951
2952         Don't check for leaks on the release SnowLeopard builder.
2953
2954         * BuildSlaveSupport/build.webkit.org-config/config.json:
2955
2956 2009-09-08  Mark Rowe  <mrowe@apple.com>
2957
2958         Add a SnowLeopard release builder.
2959
2960         * BuildSlaveSupport/build.webkit.org-config/config.json:
2961
2962 2009-09-08  David Levin  <levin@chromium.org>
2963
2964         Reviewed by Darin Adler.
2965
2966         Remove end of line whitespace check from check-webkit-style.
2967         https://bugs.webkit.org/show_bug.cgi?id=29053
2968
2969         * Scripts/modules/cpp_style.py:
2970
2971 2009-09-08  Cameron McCormack  <cam@mcc.id.au>
2972
2973         Reviewed by Darin Adler.
2974
2975         Fix DumpRenderTree build from clean tree on Tiger
2976         https://bugs.webkit.org/show_bug.cgi?id=28927
2977
2978         * DumpRenderTree/mac/PerlSupport/Makefile: Ensure the
2979         DerivedSources/DumpRenderTree directory exists when
2980         building on Tiger.
2981
2982 2009-09-08  Kevin Ollivier  <kevino@theolliviers.com>
2983
2984         wx build fix after introduction of platform/mock directory.
2985
2986         * wx/build/settings.py:
2987
2988 2009-09-08  Yael Aharon  <yael.aharon@nokia.com>
2989
2990         Unreviewed.
2991
2992         Add myself to list of committers.
2993
2994         * Scripts/modules/committers.py:
2995
2996 2009-09-08  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2997
2998         Unreviewed.
2999
3000         Add myself to list of committers.
3001
3002         * Scripts/modules/committers.py:
3003
3004 2009-09-08  Cameron McCormack  <cam@mcc.id.au>
3005
3006         Reviewed by Darin Adler.
3007
3008         prepare-ChangeLog too chatty on file additions
3009         https://bugs.webkit.org/show_bug.cgi?id=29019
3010
3011         * Scripts/prepare-ChangeLog: Omit description of added properties
3012         on newly added files.
3013
3014 2009-09-08  Steve Block  <steveblock@google.com>
3015
3016         Reviewed by Adam Barth.
3017
3018         Adds a LayoutTestController method to set the permission state for Geolocation.
3019         This is required to use the mock Geolocation service for testing.
3020         https://bugs.webkit.org/show_bug.cgi?id=29027
3021
3022         * DumpRenderTree/LayoutTestController.cpp: Modified.
3023         (setDatabaseQuotaCallback): Modified. Style fix.
3024         (setGeolocationPermissionCallback): Added. Sets the Geolocation permission state.
3025         (LayoutTestController::staticFunctions): Modified. Registers the above function on the LayoutTestController.
3026         * DumpRenderTree/LayoutTestController.h: Modified.
3027         (LayoutTestController::setGeolocationPermission): Added. Sets the Geolocation permission state.
3028         (LayoutTestController::isGeolocationPermissionSet): Added. Returns whether the Geolocation permission has been set.
3029         (LayoutTestController::geolocationPermission): Added. Returns the Geolocation permission state.
3030         * DumpRenderTree/mac/UIDelegate.mm: Modified.
3031         (-[UIDelegate webView:frame:requestGeolocationPermission:securityOrigin:]): Added. Implement chrome method to respond to request for Geolocation permission state. Response is made using above methods to access permission state.
3032
3033 2009-09-08  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3034
3035         Reviewed by Simon Hausmann.
3036
3037         [Qt] QtWebKit single API to enable persistency
3038         https://bugs.webkit.org/show_bug.cgi?id=28682
3039
3040         Use the new enablePersistentStorage API instead 
3041         of enabling all persistent features one-by-one.
3042
3043         * DumpRenderTree/qt/DumpRenderTree.cpp:
3044         (WebCore::WebPage::WebPage):
3045         (WebCore::DumpRenderTree::DumpRenderTree):
3046
3047 2009-09-07  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3048
3049         Reviewed by Tor Arne Vestbø.
3050
3051         Refactor --strict switch to --ignore-metrics and correct the
3052         implementation to make the feature usable on all platforms.
3053         https://bugs.webkit.org/show_bug.cgi?id=28907
3054
3055         run-webkit-tests --ignore-metrics strips the font related metrics from
3056         the actual and expected data before comparing them.
3057         In this way the render trees can be checked for obvious differences but
3058         a successful test implies by no means that the layout is actually correct.
3059
3060         * Scripts/run-webkit-tests:
3061
3062 2009-09-07  Steve Block  <steveblock@google.com>
3063
3064         Reviewed by Adam Barth.
3065
3066         Adds a mock Geolocation service. This will be used to provide predictable behavior of the
3067         Geolocation API for use in LayoutTests. Later changes will integrate the the mock
3068         Geolocation service with DumpRenderTree.
3069         https://bugs.webkit.org/show_bug.cgi?id=28264
3070
3071         * DumpRenderTree/LayoutTestController.cpp: Modified.
3072         (setMockGeolocationPositionCallback): Added. Configures the mock Geolocation service.
3073         (setMockGeolocationErrorCallback): Added. Configures the mock Geolocation service.
3074         (LayoutTestController::staticFunctions): Added. Registers the above functions on the LayoutTestController.
3075         * DumpRenderTree/LayoutTestController.h: Modified.
3076         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Modified.
3077         (LayoutTestController::setMockGeolocationPosition): Added. Configures the mock Geolocation service.
3078         (LayoutTestController::setMockGeolocationError): Added. Configures the mock Geolocation service.
3079
3080 2009-09-07  Drew Wilson  <atwilson@google.com>
3081
3082         Reviewed by David Levin.
3083
3084         Enable SHARED_WORKERS by default
3085         https://bugs.webkit.org/show_bug.cgi?id=28959
3086
3087         * Scripts/build-webkit:
3088
3089 2009-09-07  Kevin Ollivier  <kevino@theolliviers.com>
3090
3091         wx build fixes for wx SVN trunk.
3092
3093         * wx/build/settings.py:
3094
3095 2009-09-04  Kevin Ollivier  <kevino@theolliviers.com>
3096
3097         wx build fix. Switch USE_ defines over to the compiler so that they can be
3098         checked by files not including config.h (like WebCorePrefix.h).
3099
3100         * wx/build/settings.py:
3101
3102 2009-09-04  Adam Barth  <abarth@webkit.org>
3103
3104         Unreviewed build fix.
3105
3106         Update declaration of FrameLoadDelegate to reflect that
3107         IWebFrameLoadDelegatePrivate2 inherits from
3108         IWebFrameLoadDelegatePrivate.
3109
3110         * DumpRenderTree/win/FrameLoadDelegate.h:
3111
3112 2009-09-04  Adam Barth  <abarth@webkit.org>
3113
3114         Reviewed by Eric Seidel.
3115
3116         https://bugs.webkit.org/show_bug.cgi?id=24696
3117
3118         Add testing instrumentation for mixed content.
3119
3120         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3121         (-[FrameLoadDelegate webView:]):
3122         (-[FrameLoadDelegate webView:didRunInsecureContent:]):
3123         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3124         (descriptionSuitableForTestResult):
3125         (FrameLoadDelegate::QueryInterface):
3126         (FrameLoadDelegate::didDisplayInsecureContent):
3127         (FrameLoadDelegate::didRunInsecureContent):
3128         * DumpRenderTree/win/FrameLoadDelegate.h:
3129
3130 2009-09-03  Kevin Watters  <kevinwatters@gmail.com>
3131
3132         Reviewed by Kevin Ollivier.
3133
3134         [wx] Frames support
3135         https://bugs.webkit.org/show_bug.cgi?id=19041
3136
3137         * wx/build-wxwebkit:
3138
3139 2009-09-02  David Kilzer  <ddkilzer@apple.com>
3140
3141         <http://webkit.org/b/28880> svn-apply --force doesn't actually work
3142
3143         Reviewed by Eric Seidel.
3144
3145         This fixes "svn-apply --force" and adds unit tests for the
3146         scm.apply_patch() method which uses this script.
3147
3148         * Scripts/svn-apply: Created $globalExitCode variable that
3149         defaults to 0.  Exit with a value of $globalExitCode when the
3150         script is finished.
3151         (applyPatch): Ignore a non-zero $exitCode if $force is true, but
3152         set $globalExitCode to $exitCode so that svn-apply exits with a
3153         non-zero status if any patches did not apply cleanly.  Also
3154         print out the actual patch command if $force was not true.
3155
3156         * Scripts/modules/scm.py:
3157         (scripts_directory): Added.  Extracted from script_path().
3158         (script_path): Extracted scripts_directory().
3159         * Scripts/modules/scm_unittest.py: Import urllib.
3160         (SVNTestRepository.setup): Save the original working directory
3161         in test_object since this represents the WebKit repository from
3162         where the unit tests are run.
3163         (SCMTest): Created new super class to hold utility methods.
3164         (SCMTest._create_patch): Creates a patch file on disk and a
3165         dictionary for use with scm.svn_apply().
3166         (SCMTest._setup_webkittools_scripts_symlink): Sets up a symlink
3167         back to WebKitTools/Scripts in the test repository so that
3168         scm.apply_patch() is able to find the svn-apply script.
3169         (SVNTest): Inherit from SCMTest instead of unittest.TestCase.
3170         (SVNTest.tearDown): Make sure to change directories back to the
3171         original_path before the next test.
3172         (SVNTest.test_apply_svn_patch): New test case for applying an
3173         svn patch with scm.apply_patch().
3174         (SVNTest.test_apply_svn_patch_force): New test case for applying
3175         an svn patch with scm.apply_patch() that conflicts.
3176         (GitTest): Inherit from SCMTest instead of unittest.TestCase.
3177         (GitTest.tearDown): Make sure to change directories back to the
3178         original_path before the next test.
3179         (GitTest.test_apply_git_patch): New test case for applying a git
3180         patch with scm.apply_patch().
3181         (GitTest.test_apply_git_patch_force): New test case for applying
3182         a git patch with scm.apply_patch() that conflicts.
3183
3184 2009-09-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3185
3186         Reviewed by Mark Rowe.
3187
3188         [Qt] Add support for platform-spesific layout-test results
3189
3190         For the Qt port we use the qt-[mac|linux|win] directories and then fall
3191         back to the generic qt directory for both test results and skipped list.
3192
3193         * Scripts/run-webkit-tests:
3194         * Scripts/webkitdirs.pm:
3195
3196 2009-09-02  Laurent Cerveau  <lcerveau@me.com>
3197
3198         Reviewed by David Kilzer.
3199
3200         <http://webkit.org/b/25517> build-webkit script should print build time at end
3201
3202         * Scripts/build-webkit:
3203         Added startTime and endTime variable so that the build time is computed and printed as
3204         part of the build message; display formatting has been separated in a dedicated subroutine.
3205
3206 2009-09-02  David Kilzer  <ddkilzer@apple.com>
3207
3208         <http://webkit.org/b/28881> svn-create-patch should check if the repo path is the same when trying to find the root
3209
3210         Reviewed by Eric Seidel.
3211
3212         * Scripts/VCSUtils.pm:
3213         (determineSvnRoot): Added back check for repository root that
3214         was removed in r46134 when this code lived in svn-create-patch.
3215         It's necessary to check both the repository root and the
3216         repository UUID in case two different working directories are
3217         checked out from the same repository.
3218
3219 2009-09-02  Timothy Hatcher  <timothy@apple.com>
3220
3221         Use new 512x512 icons for nightly builds.
3222
3223         Rubber-stamped by Mark Rowe.
3224
3225         * WebKitLauncher/webkit.icns:
3226
3227 2009-09-02  Kevin Ollivier  <kevino@theolliviers.com>
3228
3229         waf build fix. Remove local variable shadowing global.
3230
3231         * wx/build/settings.py:
3232
3233 2009-09-02  Zan Dobersek  <zandobersek@gmail.com>
3234
3235         Reviewed by David Kilzer.
3236
3237         Calls exitStatus function from the main package where it is also defined.
3238
3239         * Scripts/VCSUtils.pm:
3240
3241 2009-09-02  Kevin Ollivier  <kevino@theolliviers.com>
3242
3243         waf build fixes for Windows/MSVC and Mac/Snow Leopard.
3244
3245         * wx/browser/wscript:
3246         * wx/build/build_utils.py:
3247         * wx/build/settings.py:
3248
3249 2009-08-10  Kevin Ollivier  <kevino@theolliviers.com>
3250
3251         Reviewed by Eric Seidel.
3252
3253         Changes needed for build-webkit to support the waf build system for the wx port.
3254         
3255         https://bugs.webkit.org/show_bug.cgi?id=27619
3256
3257         * Scripts/build-webkit:
3258         * Scripts/run-launcher:
3259         * Scripts/webkitdirs.pm:
3260
3261 2009-09-02  David Kilzer  <ddkilzer@apple.com>
3262
3263         <http://webkit.org/b/27168> With Subversion 1.6, update-webkit prompts on conflicts
3264
3265         Reviewed by Eric Seidel.
3266
3267         * Scripts/update-webkit: Added "--accept postpone" to
3268         @svnOptions when running with svn-1.6 or newer.
3269
3270 2009-09-02  David Kilzer  <ddkilzer@apple.com>
3271
3272         Moved svn 1.6 version check into VCSUtils::isSVNVersion16OrNewer()
3273
3274         Reviewed by Eric Seidel.
3275
3276         * Scripts/VCSUtils.pm:
3277         (@EXPORT): Added &isSVNVersion16OrNewer.
3278         (svnVersion): Added.  Internal method that gets the SVN version
3279         and caches it.
3280         (isSVNVersion16OrNewer): Added.  Method that does the SVN 1.6
3281         version check.
3282         * Scripts/prepare-ChangeLog: Switched to use new
3283         isSVNVersion16OrNewer() method.
3284         * Scripts/resolve-ChangeLogs: Ditto.
3285         * Scripts/svn-create-patch: Ditto.
3286
3287 2009-09-02  David Kilzer  <ddkilzer@apple.com>
3288
3289         Clean up VCSUtils.pm
3290
3291         Reviewed by Eric Seidel.
3292
3293         * Scripts/VCSUtils.pm: Added proper package statement.  Fixed
3294         indentation of BEGIN block.  Listed each exported method on a
3295         line by itself.  Added methods to the export list after adding
3296         the package statement.  Sorted module variables.  Moved
3297         definiton of $gitRoot next to other module variables.
3298
3299 2009-09-01  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3300
3301         Rubber-stamped by Simon Hausmann.
3302
3303         [Qt] Fix layout-test plugins/plugin-javascript-access.html
3304
3305         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3306
3307 2009-09-02  Shinichiro Hamaji  <hamaji@chromium.org>
3308
3309         Reviewed by Eric Seidel.
3310
3311         js tests should move into jstests subdirectory instead of resources/
3312         https://bugs.webkit.org/show_bug.cgi?id=25880
3313
3314         make-script-wrappers supports both resources and script-tests directories.
3315         run-webkit-tests ignores files in script-tests.
3316         Move script tests of animations to check the new script is working.
3317
3318         * Scripts/make-script-test-wrappers:
3319         * Scripts/run-webkit-tests:
3320
3321 2009-09-02  Szabo Carol  <carol.szabo@nokia.com>
3322
3323         Reviewed by David Levin.
3324
3325         check-webkit-style uses python from /usr/bin instead of the PATH
3326         https://bugs.webkit.org/show_bug.cgi?id=28225
3327
3328         * Scripts/bugzilla-tool:
3329         * Scripts/check-webkit-style:
3330         * Scripts/run-webkit-unittests:
3331         * Scripts/update-sources-list.py:
3332           Changed the first line from
3333           #!/usr/bin/python
3334           to
3335           #!/usr/bin/env python
3336           which causes python to be invoked from the path location returned
3337           by "which python" when any of these scripts are launched.
3338           these are currently all the python scripts in WebKitTools/Scripts.
3339
3340 2009-09-01  David Kilzer  <ddkilzer@apple.com>
3341
3342         <http://webkit.org/b/28601> bugzilla-tool post-commits posts commits backwards
3343
3344         Reviewed by Adam Barth.
3345
3346         * Scripts/modules/scm.py:
3347         (Git.commit_ids_from_commitish_arguments): Reverse the list of
3348         commits returned from git-rev-list since we always want to post
3349         the oldest patches first to bugs.webkit.org.
3350         * Scripts/modules/scm_unittest.py:
3351         (run): Added return statement to return the output now that we
3352         want it sometimes.
3353         (SVNTestRepository._setup_test_commits): Added a fourth commit
3354         so the GitTest.test_commitish_order() test has more commits to
3355         work with.
3356         (GitTest.test_commitish_order): Added unit test for change to
3357         Git.commit_ids_from_commitish_arguments() in scm.py.
3358
3359 2009-09-01  David Kilzer  <ddkilzer@apple.com>
3360
3361         <http://webkit.org/b/28877> Implement bugzilla-tool mark-fixed
3362
3363         Reviewed by David Levin.
3364
3365         The mark-fixed subcommand is for those times when you don't use
3366         bugzilla-tool to commit a patch, but you want to use it to close
3367         the bug with a committed-revision message.
3368
3369         * Scripts/bugzilla-tool:
3370         (bug_comment_from_svn_revision): Added.  Extracted from
3371         bug_comment_from_commit_text().
3372         (bug_comment_from_commit_text): Extracted
3373         bug_comment_from_svn_revision() from this method.
3374         (MarkBugFixed.__init__): Added.
3375         (MarkBugFixed._fetch_commit_log): Added.  Retrieves the commit
3376         log from the last commit if no svn revision is specified, else
3377         the commit log for the specified svn revision.
3378         (MarkBugFixed._determine_bug_id_and_svn_revision): Added.
3379         Attempts to determine the bug id and svn revision if one or both
3380         were not defined on the command line.
3381         (MarkBugFixed.execute): Added.  Adds a comment about the
3382         revision that fixed the bug and closes the bug.
3383         (BugzillaTool.__init__): Added mark-fixed subcommand.
3384         * Scripts/modules/bugzilla.py:
3385         (Bugzilla.fetch_title_from_bug): Added.  Returns the title of a
3386         bug given a bug id.
3387         * Scripts/modules/scm.py:
3388         (SCM.strip_r_from_svn_revision): Added.  Utility method to strip
3389         the leading 'r' from an svn revision.
3390         (SCM.svn_commit_log): Added.  Subclasses must override.
3391         (SCM.last_svn_commit_log): Added.  Subclasses must override.
3392         (SVN.svn_commit_log): Added.  Returns svn log for a given
3393         revision.
3394         (SVN.last_svn_commit_log): Added.  Uses svnversion to find the
3395         last commit in an svn working directory and then runs svn log.
3396         (Git.svn_commit_log): Added.  Returns svn log for a given
3397         revision.
3398         (Git.last_svn_commit_log): Added.  Runs git-svn-log with a limit
3399         of one log message.
3400
3401 2009-09-01  David Kilzer  <ddkilzer@apple.com>
3402
3403         <http://webkit.org/b/28880> svn-apply --force doesn't actually work
3404
3405         Reviewed by Brady Eidson.
3406
3407         * Scripts/svn-apply:
3408         (applyPatch): Add "--force" to $options arrayref if $force is
3409         set.
3410
3411 2009-09-01  David Kilzer  <ddkilzer@apple.com>
3412
3413         <http://webkit.org/b/28725> resolve-ChangeLogs: determineVCSRoot() returns incorrect repository root during git filter-branch
3414
3415         Reviewed by Adam Roben.
3416
3417         When git-filter-branch has been invoked to rewrite ChangeLog
3418         files on series of git commits, it changes directories into
3419         .git-rewrite/t before re-running resolve-ChangeLogs.  This
3420         causes determineVCSRoot() in VCSUtils.pm to return
3421         ".git-rewrite/t", which causes that path to be prepended to all
3422         ChangeLog paths, which results in an error like this:
3423
3424             error: pathspec '.git-rewrite/t/ChangeLog' did not match any file(s) known to git.
3425             Died at WebKitTools/Scripts/resolve-ChangeLogs line 376.
3426
3427         The correct way to fix this is not to try to find the repository
3428         root when invoked by git-filter-branch.
3429
3430         * Scripts/resolve-ChangeLogs: If isInGitFilterBranch() is true,
3431         set $relativePath to '.' instead of calling
3432         chdirReturningRelativePath(determineVCSRoot()).
3433         (isInGitFilterBranch): Added.  Checks for the existence of the
3434         MAPPED_PREVIOUS_COMMIT environment variable.
3435
3436 2009-09-01  Xan Lopez  <xlopez@igalia.com>
3437
3438         Reviewed by Gustavo Noronha.
3439
3440         Add support for Fedora distros in the http tests
3441         https://bugs.webkit.org/show_bug.cgi?id=28263
3442
3443         Add detection code for Fedora distribution, and use the proper
3444         httpd conf file when needed.
3445
3446         * Scripts/run-webkit-httpd:
3447         * Scripts/run-webkit-tests:
3448         * Scripts/webkitdirs.pm:
3449
3450 2009-09-01  Jan Michael Alonzo  <jmalonzo@webkit.org>
3451
3452         Reviewed by Eric Seidel.
3453
3454         [Gtk] DRT needs implementation of overridePreference
3455         https://bugs.webkit.org/show_bug.cgi?id=28830
3456
3457         Implement overridePreference.
3458
3459         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3460         (resetDefaultsToConsistentValues):
3461         (setDefaultsToConsistentStateValuesForTesting):
3462         (runTest):
3463         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3464         (toWebSettingKey):
3465         (LayoutTestController::overridePreference):
3466
3467 2009-09-01  Joseph Pecoraro  <joepeck@webkit.org>
3468
3469         <http://webkit.org/b/28623> svn-[un]apply should change directories to the repository root before [un]applying
3470
3471         Reviewed by Eric Seidel.
3472
3473         Jump back and forth between the repository root directory (to apply) and the
3474         directory the script was run from (to find the patch).
3475
3476         * Scripts/svn-apply:
3477         * Scripts/svn-unapply:
3478
3479 2009-08-31  Adam Roben  <aroben@apple.com>
3480
3481         Fall back to a Release version of Safari if a Debug one doesn't exist
3482
3483         <http://webkit.org/b/28849>
3484
3485         Reviewed by Sam Weinig.
3486
3487         * Scripts/webkitdirs.pm:
3488         (safariPath): If the user is working with a Debug build, but there's
3489         no Debug version of Safari present, fall back to using a Release
3490         version of Safari.
3491
3492 2009-08-31  Adam Roben  <aroben@apple.com>
3493
3494         Make safariPath() work for Debug builds of Safari on Windows
3495
3496         <http://webkit.org/b/28849>
3497
3498         Reviewed by Sam Weinig.
3499
3500         * Scripts/webkitdirs.pm:
3501         (safariPath): If the user is working with a Debug build, add the
3502         _debug suffix to Safari.exe.
3503
3504 2009-08-28  Eric Seidel  <eric@webkit.org>
3505
3506         Reviewed by Adam Barth.
3507
3508         commit-queue needs a master process
3509         https://bugs.webkit.org/show_bug.cgi?id=28040
3510
3511         Add a bugzilla-tool commit-queue command
3512         Keeps per-bug logs, but doesn't yet upload them anywhere.
3513
3514         * Scripts/bugzilla-tool: Add LandPatchesFromCommitQueue to handle 'commit-queue'
3515         * Scripts/modules/buildbot.py: remove noisy log message
3516         * Scripts/modules/logging.py: add a 'tee()' call for splitting outputs in python
3517
3518 2009-08-28  Jan Michael Alonzo  <jmalonzo@webkit.org>
3519
3520         Reviewed by Gustavo Noronha.
3521
3522         [GTK] Geolocation needs permission API before being enabled by default
3523
3524         Build the Gtk port with geolocation enabled. This option is only
3525         enabled for the buildbot. The autotools option will be enabled by
3526         default once the permissions API is implemented.
3527
3528         * Scripts/build-webkit:
3529
3530 2009-08-26  Cameron McCormack  <cam@mcc.id.au>
3531
3532         Reviewed by David Kilzer.
3533
3534         Make prepare-ChangeLog notice property changes
3535         https://bugs.webkit.org/show_bug.cgi?id=28675
3536
3537         Make the generated ChangeLog entry include a short description of
3538         property changes if there were such changes.  Also make
3539         prepare-ChangeLog not bail if the only changes are property changes.
3540
3541         * Scripts/prepare-ChangeLog:
3542
3543 2009-08-26  Adam Barth  <abarth@webkit.org>
3544
3545         Reviewed by Oliver Hunt.
3546
3547         Don't let local files access web URLs
3548         https://bugs.webkit.org/show_bug.cgi?id=28480
3549
3550         A bunch of our LayoutTests rely on our old behavior, so we explicitly
3551         grant local files universal access during testing.  Mainly, these tests
3552         involve making XMLHttpRequests for data URLs.
3553
3554         * DumpRenderTree/mac/DumpRenderTree.mm:
3555         (resetDefaultsToConsistentValues):
3556         * DumpRenderTree/qt/DumpRenderTree.cpp:
3557         (WebCore::WebPage::WebPage):
3558         * DumpRenderTree/win/DumpRenderTree.cpp:
3559         (resetDefaultsToConsistentValues):
3560
3561 2009-08-26  John Gregg  <johnnyg@google.com>
3562
3563         Reviewed by David Levin.
3564
3565         Minor style correction and include fix for notifications
3566         https://bugs.webkit.org/show_bug.cgi?id=28745
3567
3568         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
3569           change to correct EnumStyle
3570         (DRTDesktopNotificationPresenter::checkNotificationPermission):
3571
3572 2009-08-26  David Levin  <levin@chromium.org>
3573
3574         Reviewed by Alexey Proskuryakov.
3575
3576         XMLHttpRequest.withCredentials=false shouldn't save cookies.
3577         https://bugs.webkit.org/show_bug.cgi?id=28743
3578
3579         Added the support to the layout test controller on OSX and
3580         Windows (for CFNETWORK) to allow for changing the accept cookie
3581         policy.
3582
3583         * DumpRenderTree/LayoutTestController.cpp:
3584         (LayoutTestController::LayoutTestController): Added a bool
3585         to track the state of accepting cookies.
3586         (setAlwaysAcceptCookiesCallback): Standard wrapper method
3587         to go from js to a C++ method.
3588         (LayoutTestController::staticFunctions): Added the
3589         setAlwaysAcceptCookies method to the js layoutTestController.
3590         * DumpRenderTree/LayoutTestController.h:
3591         (LayoutTestController::alwaysAcceptCookies): Returns the value.
3592         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3593         (LayoutTestController::setAlwaysAcceptCookies): Stub out method.
3594         * DumpRenderTree/mac/DumpRenderTree.mm:
3595         (resetDefaultsToConsistentValues): Reset the accept cookie to
3596         its default.
3597         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3598         (LayoutTestController::setAlwaysAcceptCookies): Does the work for
3599         OSX to change the cookie accept policy.
3600         * DumpRenderTree/win/DumpRenderTree.cpp:
3601         (setAlwaysAcceptCookies): Method to handle all the calls necessary
3602         to change the accept cookie policy on Windows.
3603         (resetDefaultsToConsistentValues): Reset the accept cookie to
3604         its default.
3605         * DumpRenderTree/win/DumpRenderTreeWin.h:
3606         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3607         (LayoutTestController::setAlwaysAcceptCookies): Stub out method.
3608         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3609         (LayoutTestController::setAlwaysAcceptCookies): Stub out method.
3610
3611 2009-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
3612
3613         Unreviewed.
3614
3615         Remove accidentally left in clobber option.
3616         https://bugs.webkit.org/show_bug.cgi?id=28400
3617
3618         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed clobber option.
3619
3620 2009-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
3621
3622         Reviewed by Mark Rowe.
3623
3624         Add canary-style Chromium WebKit build slave to the waterfall.
3625         https://bugs.webkit.org/show_bug.cgi?id=28400
3626
3627         * BuildSlaveSupport/build.webkit.org-config/config.json: Added one Chromium/Windows slave
3628         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added support for Chromium slave commands.
3629
3630 2009-08-25  Cameron McCormack  <cam@mcc.id.au>
3631
3632         Reviewed by Darin Adler.
3633
3634         make-script-test-wrappers should be executable
3635         https://bugs.webkit.org/show_bug.cgi?id=28669
3636
3637         Make make-script-test-wrappers and update-sources-list.py both be
3638         executable.
3639
3640         * Scripts/update-sources-list.py:
3641         * Scripts/make-script-test-wrappers:
3642
3643 2009-08-25  Brent Fulgham  <bfulgham@webkit.org>
3644
3645         Build fix
3646
3647         Revise Debug_Cairo targets to point inherit from the 
3648         debug_wincairo.vsprops property sheet so that they link
3649         against the proper libraries in Debug build.
3650
3651         * DumpRenderTree/win/DumpRenderTree.vcproj:
3652         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3653         * WinLauncher/WinLauncher.vcproj: