WebKitTools/ChangeLog

   1 2010-08-30  Zoltan Horvath  <zoltan@webkit.org>
   2
   3         Reviewed by Kenneth Rohde Christiansen.
   4
   5         [Qt] Add new window menu to MiniBrowser
   6
   7         Implement newWindow function and add a menu item for opening new window in MiniBrowser.
   8
   9         * MiniBrowser/qt/BrowserWindow.cpp:
  10         (BrowserWindow::BrowserWindow):
  11         (BrowserWindow::newWindow):
  12         * MiniBrowser/qt/BrowserWindow.h:
  13         * MiniBrowser/qt/main.cpp:
  14         (main):
  15
  16 2010-08-29  James Robinson  <jamesr@chromium.org>
  17
  18         Reviewed by David Levin.
  19
  20         Make failing the download step fail the build
  21         https://bugs.webkit.org/show_bug.cgi?id=44298
  22
  23         If the download step fails on a test bot, this ensures that
  24         the build goes red instead of only the download step going red
  25         and the overall build staying green.
  26
  27         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  28
  29 2010-08-29  Kent Tamura  <tkent@chromium.org>
  30
  31         Reviewed by Dimitri Glazkov.
  32
  33         [DRT/Chromium] Remove dependency to base/keyboard_codes.h
  34         https://bugs.webkit.org/show_bug.cgi?id=44847
  35
  36         * DumpRenderTree/chromium/EventSender.cpp:
  37          Use webkit_support::VKEY_* instead of base::VKEY_*.
  38
  39 2010-08-29  Darin Adler  <darin@apple.com>
  40
  41         https://bugs.webkit.org/show_bug.cgi?id=40589
  42
  43         * Scripts/prepare-ChangeLog: Only prepend namespaces to non-empty
  44         function names.
  45
  46 2010-08-26  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
  47
  48         Reviewed by Darin Adler.
  49
  50         [iExploder] Add new CSS Properties and HTML Attributes
  51         https://bugs.webkit.org/show_bug.cgi?id=44746
  52
  53         Updated the files with the update-iexploder-cssproperties script
  54         and manually readded the -webkit-binding CSS Property to the list.
  55
  56         * iExploder/htdocs/cssproperties.in:
  57         * iExploder/htdocs/htmlattrs.in:
  58         * iExploder/htdocs/htmltags.in:
  59
  60 2010-08-26  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
  61
  62         Reviewed by Darin Adler.
  63
  64         Fix Coverage build after the addition of ANGLE
  65         https://bugs.webkit.org/show_bug.cgi?id=44744
  66
  67         ANGLE is using libtool to build a static library and the version of
  68         libtool on Leopard refuses to handle the -fprofile-arcs and -ftest-coverage
  69         parameters. The easiest way to handle this is to not build ANGLE with
  70         coverage information.
  71
  72         This is achieved by applying the XCode options for each project
  73         separately and exclude ANGLE.
  74
  75         * Scripts/build-webkit: Remove -framework AppKit due link errors.
  76         * Scripts/webkitdirs.pm: Do not apply the XCode options for ANGLE.
  77
  78 2010-08-28  Kevin Ollivier  <kevino@theolliviers.com>
  79
  80         [wx] Build fix after directory addition.
  81
  82         * wx/build/settings.py:
  83
  84 2010-08-28  Chris Guillory   <chris.guillory@google.com>
  85
  86         Reviewed by Chris Fleizach.
  87
  88         Add AX notification for childrenChanged
  89         https://bugs.webkit.org/show_bug.cgi?id=44472
  90
  91         * DumpRenderTree/chromium/AccessibilityController.cpp:
  92         (AccessibilityController::AccessibilityController):
  93         (AccessibilityController::reset):
  94         (AccessibilityController::getRootElement):
  95         (AccessibilityController::dumpAccessibilityNotifications):
  96         * DumpRenderTree/chromium/AccessibilityController.h:
  97         (AccessibilityController::shouldDumpAccessibilityNotifications):
  98         * DumpRenderTree/chromium/WebViewHost.cpp:
  99         (WebViewHost::didChangeAccessibilityObjectChildren):
 100         * DumpRenderTree/chromium/WebViewHost.h:
 101
 102 2010-08-28  Eric Seidel  <eric@webkit.org>
 103
 104         Reviewed by Adam Barth.
 105
 106         Update commit-queue failure message
 107         https://bugs.webkit.org/show_bug.cgi?id=44798
 108
 109         The commit-queue auto-restarts itself and has for a very long time.
 110         No need for people to email me to request a restart anymore.
 111
 112         * Scripts/webkitpy/common/net/bugzilla.py:
 113         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
 114         * Scripts/webkitpy/tool/commands/queues_unittest.py:
 115
 116 2010-07-27  Jer Noble  <jer.noble@apple.com>
 117
 118         Reviewed by Eric Carlson.
 119
 120         Add JavaScript API to allow a page to go fullscreen.
 121         rdar://problem/6867795
 122
 123         Added basic full screen support to DumpRenderTree: when a webView requests
 124         that DumpRenderTree go "full screen", just call the provided callback listener object's
 125         will/did Enter/Exit full screen methods.  Also, register a new user default which
 126         enables full screen support.
 127
 128         * DumpRenderTree/mac/DumpRenderTree.mm:
 129         (resetDefaultsToConsistentValues):
 130         * DumpRenderTree/mac/UIDelegate.mm:
 131         (-[UIDelegate webView:supportsFullscreenForElement:]):
 132         (-[UIDelegate webView:enterFullscreenForElement:listener:]):
 133         (-[UIDelegate webView:exitFullscreenForElement:listener:]):
 134
 135 2010-08-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
 136
 137         Unreviewed. Add myself to the committers list.
 138
 139         * Scripts/webkitpy/common/config/committers.py:
 140
 141 2010-08-27  Kent Tamura  <tkent@chromium.org>
 142
 143         Reviewed by Pavel Feldman.
 144
 145         [DRT/Chromium] Fix inspector test failures
 146         https://bugs.webkit.org/show_bug.cgi?id=44748
 147
 148         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
 149         (DRTDevToolsAgent::createClientMessageLoop):
 150           Returns a valid WebKitClientMessageLoop instance
 151         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
 152
 153 2010-08-26  Jon Honeycutt  <jhoneycutt@apple.com>
 154
 155         Add Windows WebKit2 Tester to buildbot
 156         <rdar://problem/7887703>
 157
 158         Reviewed by Dan Bernstein.
 159
 160         * BuildSlaveSupport/build.webkit.org-config/config.json:
 161
 162 2010-08-26  Philippe Normand  <pnormand@igalia.com>
 163
 164         Reviewed by Martin Robinson.
 165
 166         [GTK] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
 167         https://bugs.webkit.org/show_bug.cgi?id=42152
 168
 169         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
 170         (LoadHTMLStringItem::invoke): Implementation using
 171         webkit_web_frame_load_string().
 172
 173 2010-08-25  Jon Honeycutt  <jhoneycutt@apple.com>
 174
 175         <rdar://problem/8334338> run-webkit-tests sometimes hangs when using
 176         WebKitTestRunner (44331)
 177
 178         Reviewed by Darin Adler.
 179
 180         * WebKitTestRunner/TestController.cpp:
 181         (WTR::TestController::initialize):
 182         The hang occurs when WebKitTestRunner begins launching the WebKit2
 183         web process then exits before it finishes launching. Work around this by
 184         looking for the --print-supported-features argument and exiting without
 185         creating the web process.
 186
 187 2010-08-26  Dirk Pranke  <dpranke@chromium.org>
 188
 189         Reviewed by Tony Chang.
 190
 191         new-run-webkit-tests: add rebaselining tests for test_expectations
 192
 193         This patch adds more unit tests for the rebaselining code in the
 194         test_expectations module. It doesn't add any tests for
 195         rebaseline_chromium_webkit_tests itself; that will come some other
 196         time.
 197
 198         https://bugs.webkit.org/show_bug.cgi?id=44648
 199
 200         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
 201         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
 202
 203 2010-08-26  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
 204
 205         Reviewed by Martin Robinson.
 206
 207         [GTK] Add HTTP caching support
 208         https://bugs.webkit.org/show_bug.cgi?id=44261
 209
 210         Ignore new soup API that we decided to merge into the soup backend
 211         while it is being cooked. It follows the libsoup style, and will
 212         be removed from WebKit as soon as it is merged into libsoup.
 213
 214         * Scripts/webkitpy/style/checker.py:
 215
 216 2010-08-26  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
 217
 218         Reviewed by Kenneth Rohde Christiansen.
 219
 220         [Qt] DumpRenderTree runs only one test from command mode
 221         https://bugs.webkit.org/show_bug.cgi?id=44012
 222
 223         Enables support to run multiple test files and single
 224         folder containing html files in stand alone mode
 225
 226         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
 227         (WebCore::DumpRenderTree::DumpRenderTree):
 228         (WebCore::DumpRenderTree::processArgsLine):
 229         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
 230         (WebCore::DumpRenderTree::processLine):
 231         (WebCore::DumpRenderTree::dump):
 232         * DumpRenderTree/qt/DumpRenderTreeQt.h:
 233         (WebCore::DumpRenderTree::setStandAloneMode):
 234         (WebCore::DumpRenderTree::isStandAloneMode):
 235         * DumpRenderTree/qt/main.cpp:
 236         (main):
 237
 238 2010-08-25  Martin Robinson  <mrobinson@igalia.com>
 239
 240         Updating webkitpy test expectations.
 241
 242         * Scripts/webkitpy/tool/steps/steps_unittest.py:
 243
 244 2010-08-25  Ojan Vafai  <ojan@chromium.org>
 245
 246         Reviewed by Eric Seidel.
 247
 248         fix the always squash git config
 249         https://bugs.webkit.org/show_bug.cgi?id=44651
 250
 251         Fix help text and apparently underscores are not allowed
 252         in git config keys.
 253
 254         * Scripts/webkitpy/common/checkout/scm.py:
 255         * Scripts/webkitpy/tool/steps/commit.py:
 256
 257 2010-08-25  Darin Adler  <darin@apple.com>
 258
 259         Reviewed by John Sullivan.
 260
 261         * Scripts/commit-log-editor: Fix perl warning for people who have no
 262         value for SVN_LOG_EDITOR or CVS_LOG_EDITOR.
 263
 264 2010-08-25  Ojan Vafai  <ojan@chromium.org>
 265
 266         Reviewed by Eric Seidel.
 267
 268         stop blocking commits when the bots are red
 269         https://bugs.webkit.org/show_bug.cgi?id=44644
 270
 271         This check currently is just annoying. It doesn't actually
 272         help keep the tree green. We can always add it back later
 273         if we decide the tree is generally more green.
 274
 275         * Scripts/webkitpy/tool/commands/download_unittest.py:
 276         * Scripts/webkitpy/tool/mocktool.py:
 277         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
 278
 279 2010-08-25  Eric Seidel  <eric@webkit.org>
 280
 281         Reviewed by Simon Fraser.
 282
 283         REGRESSION: media/video-loop.html is timing out on the commit-queue Leopard Bot
 284         https://bugs.webkit.org/show_bug.cgi?id=38912
 285
 286         I know of nothing else to do but skip all media tests for the cq.
 287
 288         * Scripts/webkitpy/tool/steps/runtests.py:
 289
 290 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
 291
 292         Reviewed by Ojan Vafai.
 293
 294         new-run-webkit-tests: add more unit tests for test_expectations
 295         This adds unit tests to cover (almost?) all of the non-rebaselining
 296         functionality.
 297
 298         https://bugs.webkit.org/show_bug.cgi?id=44579
 299
 300         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
 301         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
 302
 303 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
 304
 305         Reviewed by Ojan Vafai.
 306
 307         new-run-webkit-tests: add more unit tests
 308
 309         This change adds more unit tests for the image_diff, test_failures,
 310         and test_files modules, bringing them to 100% coverage (and adds a
 311         couple tests to run_webkit_tests while we're at it).
 312
 313         This test also turns on the "dryrun" port for testing when run on
 314         the mac, increasing coverage in a few other places.
 315
 316         https://bugs.webkit.org/show_bug.cgi?id=44578
 317
 318         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.checksum: Added.
 319         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.png: Added.
 320         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.txt: Added.
 321         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html.
 322         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.png: Added.
 323         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.txt: Added.
 324         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html.
 325         * Scripts/webkitpy/layout_tests/data/failures/expected/timeout.html: Added.
 326         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
 327         * Scripts/webkitpy/layout_tests/data/resources/README.txt: Added.
 328         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
 329         * Scripts/webkitpy/layout_tests/port/test.py:
 330         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
 331
 332 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
 333
 334         Reviewed by Ojan Vafai.
 335
 336         new-run-webkit-tests: add more unit tests for layout_package/printing.py
 337
 338         This change adds more unit tests to get the test coverage to 100%
 339         for the printing module. This code is actually pretty crufty and
 340         has some layering violations that need to be cleaned up but I'll
 341         save that for another CL after we get all the unit tests written and
 342         we fix the multithreading issues. At least now we'll be able to tell
 343         if we break things.
 344
 345         https://bugs.webkit.org/show_bug.cgi?id=44576
 346
 347         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
 348         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
 349
 350 2010-08-25  Ojan Vafai  <ojan@chromium.org>
 351
 352         Reviewed by Adam Barth.
 353
 354         new-run-webkit-tests should respect set-webkit-configuration
 355         https://bugs.webkit.org/show_bug.cgi?id=44633
 356
 357         Moves the getting of the configuration into the base Port so that
 358         chromium ports use it as well. In the downstream chromium port,
 359         this should still just return Release.
 360
 361         * Scripts/webkitpy/layout_tests/port/base.py:
 362         * Scripts/webkitpy/layout_tests/port/webkit.py:
 363
 364 2010-08-25  Tony Chang  <tony@chromium.org>
 365
 366         Not reviewed, changing svn props for a script.
 367
 368         * Scripts/deduplicate-tests: Added properties svn:executable and svn:eol-style.
 369
 370 2010-08-25  Adam Barth  <abarth@webkit.org>
 371
 372         Reviewed by Eric Seidel.
 373
 374         Remove WebKit2 from core builders
 375         https://bugs.webkit.org/show_bug.cgi?id=44625
 376
 377         This builder was added to the core builders by accident.  It doesn't
 378         appear to be green enough to be a core builder yet.
 379
 380         * Scripts/webkitpy/common/net/buildbot.py:
 381         * Scripts/webkitpy/common/net/buildbot_unittest.py:
 382
 383 2010-08-19  Adam Roben  <aroben@apple.com>
 384
 385         Test that NP_Initialize and NP_GetEntryPoints are called in the
 386         correct order
 387
 388         The order differs between Mac and Windows (see r38858).
 389
 390         Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in
 391         NP_Initialize when loading QuickTime when running
 392         plugins/embed-attributes-setting.html in WebKit2 on Windows
 393
 394         Reviewed by John Sullivan.
 395
 396         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and
 397         a boolean to record whether NP_GetEntryPoints has been called.
 398         (NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been
 399         called yet. This matches Flash and QuickTime's behavior.
 400         (NP_GetEntryPoints): Crash on Mac if NP_Initialize hasn't been called
 401         yet. This matches Silverlight's behavior.
 402
 403 2010-08-25  Martin Robinson  <mrobinson@igalia.com>
 404
 405         Reviewed by Gustavo Noronha Silva.
 406
 407         Cairo and EFL port shouldn't depend on glib.
 408         https://bugs.webkit.org/show_bug.cgi?id=44354
 409
 410         Replace occurrences of GRefPtr and adoptGRef with PlatformRefPtr and
 411         adoptPlatformRef.
 412
 413         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
 414         (AccessibilityUIElement::isSelected):
 415
 416 2010-08-25  Ojan Vafai  <ojan@chromium.org>
 417
 418         Fix order of Timothy's email address. The script, and
 419         other tools all assume that the first email is the bugzilla address.
 420
 421         * Scripts/webkitpy/common/config/committers.py:
 422
 423 2010-08-24  Kent Tamura  <tkent@chromium.org>
 424
 425         Reviewed by Pavel Feldman.
 426
 427         [DRT/Chromium] Fix 26 inspector test crashes
 428         https://bugs.webkit.org/show_bug.cgi?id=44580
 429
 430         - DRTDevToolsAgent has a reference to the main WebView. So we
 431           should not clear it in closeDevTools() and should clear it in
 432           ~TestShell().
 433         - DRTDevToolsClient has a reference to a DevTools WebView and no
 434           way to update it. So we should delete DRTDevToolsClient instances
 435           in closeDevTools().
 436
 437         * DumpRenderTree/chromium/TestShell.cpp:
 438         (TestShell::~TestShell):
 439         (TestShell::closeDevTools):
 440
 441 2010-08-24  Eric Seidel  <eric@webkit.org>
 442
 443         Reviewed by Adam Barth.
 444
 445         unicode(Exception(\u"0x1234")) is busted in python 2.5, disable tests which hit this
 446         https://bugs.webkit.org/show_bug.cgi?id=44584
 447
 448         * Scripts/webkitpy/tool/commands/queues_unittest.py:
 449
 450 2010-08-24  Eric Seidel  <eric@webkit.org>
 451
 452         Reviewed by Adam Barth.
 453
 454         commit-queue and EWS bots should report all failures
 455         https://bugs.webkit.org/show_bug.cgi?id=41820
 456
 457         Right now commit-queue/EWS only report failures when the
 458         patch under testing fails.  We should report all failures
 459         to the status server so that we can diagnose when the bots
 460         are wedged w/o needing to log into the machines.
 461
 462         I also reduced the amount of data we upload since we've seen
 463         timeouts during status upload.
 464
 465         * Scripts/webkitpy/common/system/executive.py:
 466         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
 467         * Scripts/webkitpy/tool/commands/queues.py:
 468         * Scripts/webkitpy/tool/commands/queues_unittest.py:
 469
 470 2010-08-24  Eric Seidel  <eric@webkit.org>
 471
 472         Reviewed by Adam Barth.
 473
 474         Remove HTML5 parser testing infrastructure now that we don't need it
 475         https://bugs.webkit.org/show_bug.cgi?id=44581
 476
 477         * DumpRenderTree/mac/DumpRenderTree.mm:
 478         (resetDefaultsToConsistentValues):
 479         (initializeGlobalsFromCommandLineOptions):
 480         * Scripts/old-run-webkit-tests:
 481         * Scripts/test-html5-parser: Removed.
 482
 483 2010-08-24  Kent Tamura  <tkent@chromium.org>
 484
 485         Reviewed by Dimitri Glazkov.
 486
 487         [DRT/Chromium] Fix 28 inspector test crashes
 488         https://bugs.webkit.org/show_bug.cgi?id=44574
 489
 490         Reset DevToolsClient and DevToolsAgent before closing a DevTools
 491         WebView in order to avoid accessing to a deleted WebView instance.
 492
 493         * DumpRenderTree/chromium/TestShell.cpp:
 494         (TestShell::closeDevTools):
 495
 496 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
 497
 498         Reviewed by Ojan Vafai.
 499
 500         new-run-webkit-tests: clean up code for test_types, test_failures
 501
 502         Add a bunch of unit tests for webkitpy.layout_tests.test_types and
 503         webkitpy.layout_tests.layout_package.test_failures, and remove
 504         some dead code and otherwise clean up things.
 505
 506         https://bugs.webkit.org/show_bug.cgi?id=44559
 507
 508         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
 509         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py: Added.
 510         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
 511         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
 512         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
 513         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: Added.
 514         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
 515
 516 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
 517
 518         Reviewed by Eric Seidel.
 519
 520         new-run-webkit-tests: revise unit testing strategy for test failures
 521
 522         This change revamps the way we store test data for new-run-webkit-tests.
 523         Previously we had a few copies of test files from the main test tree.
 524         Now we have a bunch of completely fake test data and use the test
 525         data to generate different kinds of test failures, getting
 526         much better coverage.
 527
 528         https://bugs.webkit.org/show_bug.cgi?id=44556
 529
 530         * Scripts/webkitpy/layout_tests/data/failures/expected/crash.html: Added.
 531         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.checksum: Added.
 532         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.png: Added.
 533         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.txt: Added.
 534         * Scripts/webkitpy/layout_tests/data/failures/expected/image.html: Added.
 535         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.checksum: Added.
 536         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.png: Added.
 537         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.txt: Added.
 538         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html: Added.
 539         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html: Added.
 540         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_text.html: Added.
 541         * Scripts/webkitpy/layout_tests/data/failures/expected/text-expected.txt: Added.
 542         * Scripts/webkitpy/layout_tests/data/failures/expected/text.html: Added.
 543         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.checksum: Added.
 544         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.png: Added.
 545         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.txt: Added.
 546         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum.html: Added.
 547         * Scripts/webkitpy/layout_tests/data/image/canvas-bg.html: Removed.
 548         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.checksum: Removed.
 549         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.png: Removed.
 550         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.txt: Removed.
 551         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom.html: Removed.
 552         * Scripts/webkitpy/layout_tests/data/misc/crash-expected.txt: Removed.
 553         * Scripts/webkitpy/layout_tests/data/misc/crash.html: Removed.
 554         * Scripts/webkitpy/layout_tests/data/misc/missing-expectation.html: Removed.
 555         * Scripts/webkitpy/layout_tests/data/misc/passing-expected.txt: Removed.
 556         * Scripts/webkitpy/layout_tests/data/misc/passing.html: Removed.
 557         * Scripts/webkitpy/layout_tests/data/passes/image-expected.checksum: Added.
 558         * Scripts/webkitpy/layout_tests/data/passes/image-expected.png: Added.
 559         * Scripts/webkitpy/layout_tests/data/passes/image-expected.txt: Added.
 560         * Scripts/webkitpy/layout_tests/data/passes/image.html: Added.
 561         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.checksum: Added.
 562         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.png: Added.
 563         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.txt: Added.
 564         * Scripts/webkitpy/layout_tests/data/passes/platform_image.html: Added.
 565         * Scripts/webkitpy/layout_tests/data/passes/text-expected.txt: Added.
 566         * Scripts/webkitpy/layout_tests/data/passes/text.html: Added.
 567         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.checksum: Removed.
 568         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.png: Removed.
 569         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.txt: Removed.
 570         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.checksum: Added.
 571         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.png: Added.
 572         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.txt: Added.
 573         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
 574         * Scripts/webkitpy/layout_tests/data/text/article-element-expected.txt: Removed.
 575         * Scripts/webkitpy/layout_tests/data/text/article-element.html: Removed.
 576         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
 577         * Scripts/webkitpy/layout_tests/port/test.py:
 578         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
 579         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
 580
 581 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
 582
 583         Reviewed by Eric Seidel.
 584
 585         speed up new-run-webkit-tests unit tests
 586
 587         Add a --no-record-results flag that turns off generating the JSON
 588         results file on every test run. Generating the file requires us to
 589         fetch the old results down from the bots, which can be slow. This
 590         flag is off by default.
 591
 592         Reduce the sleep time in wait_for_threads_to_finish from 0.1s to 0.01s.
 593
 594         These changes together shorten the test cycle from ~4.5s to ~1.5s
 595         - a 3x speedup.
 596
 597         https://bugs.webkit.org/show_bug.cgi?id=44553
 598
 599         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 600         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
 601
 602 2010-08-24  Tony Chang  <tony@chromium.org>
 603
 604         Reviewed by Eric Seidel.
 605
 606         [chromium] fix the platform result fallback order on mac/win
 607         https://bugs.webkit.org/show_bug.cgi?id=44483
 608
 609         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
 610
 611 2010-08-24  Xan Lopez  <xlopez@igalia.com>
 612
 613         Reviewed by Martin Robinson.
 614
 615         Set a device to the event struct when building with GTK+ 3.x, it's
 616         mandatory.
 617
 618         * DumpRenderTree/gtk/EventSender.cpp:
 619         (keyDownCallback):
 620
 621 2010-08-24  Martin Robinson  <mrobinson@igalia.com>
 622
 623         Reviewed by Xan Lopez.
 624
 625         [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
 626         https://bugs.webkit.org/show_bug.cgi?id=44534
 627
 628         Fix two double-frees introduced in my previous commit.
 629
 630         * DumpRenderTree/gtk/EventSender.cpp:
 631         (contextClickCallback): Copy the event before using it again.
 632         (keyDownCallback): Ditto.
 633
 634 2010-08-24  Martin Robinson  <mrobinson@igalia.com>
 635
 636         Reviewed by Xan Lopez.
 637
 638         [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
 639         https://bugs.webkit.org/show_bug.cgi?id=44534
 640
 641         * DumpRenderTree/gtk/EventSender.cpp:
 642         (prepareMouseButtonEvent): Use gdk_event_new and reference the reference the GdkWindow
 643         when setting it on the event. It is dereferenced by gdk_event_free(...).
 644         (contextClickCallback): Ditto.
 645         (mouseDownCallback): Ditto.
 646         (mouseUpCallback): Ditto.
 647         (mouseMoveToCallback): Ditto.
 648         (mouseWheelToCallback): Ditto.
 649         (sendOrQueueEvent): Take a GdkEvent* instead of a GdkEvent.
 650         (dispatchEvent): Ditto. Also free the event when we are done with it.
 651         (keyDownCallback): Use gdk_event_new and reference the GdkWindow.
 652
 653 2010-08-24  Andras Becsi  <abecsi@webkit.org>
 654
 655         [Qt] WebKit2 build fix.
 656
 657         * Scripts/enumerate-included-framework-headers:
 658         Remove stray global option form sed.
 659
 660 2010-08-24  Kent Tamura  <tkent@chromium.org>
 661
 662         Reviewed by Jeremy Orlow.
 663
 664         [DRT/Chromium] Support for IndexedDB tests
 665         https://bugs.webkit.org/show_bug.cgi?id=44490
 666
 667         * DumpRenderTree/chromium/TestShell.cpp:
 668         (TestShell::TestShell): Enable IndexedDB.
 669
 670 2010-08-23  Martin Robinson  <mrobinson@igalia.com>
 671
 672         Reviewed by Gustavo Noronha Silva.
 673
 674         [GTK] The 64-bit Release bot is showing crashes on tests that use mouse buttons
 675         https://bugs.webkit.org/show_bug.cgi?id=44465
 676
 677         Initialize the axes field of mouse button and motion events to null.
 678         This is the value that should be used for events originating from the
 679         mouse device.
 680
 681         * DumpRenderTree/gtk/EventSender.cpp:
 682         (prepareMouseButtonEvent): Initalize button event axes field to null.
 683         (mouseMoveToCallback): Initialize motion event axes field to null.
 684
 685 2010-08-23  Sheriff Bot  <webkit.review.bot@gmail.com>
 686
 687         Unreviewed, rolling out r65703.
 688         http://trac.webkit.org/changeset/65703
 689         https://bugs.webkit.org/show_bug.cgi?id=44460
 690
 691         "Causing lots of crashes on Snow Leopard when running the
 692         layout tests" (Requested by eseidel2 on #webkit).
 693
 694         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
 695         (NP_Initialize):
 696         (NP_GetEntryPoints):
 697
 698 2010-08-23  Jon Honeycutt  <jhoneycutt@apple.com>
 699
 700         Layout tests do not run when using WebKitTestRunner in a Debug build.
 701         https://bugs.webkit.org/show_bug.cgi?id=44409
 702
 703         Reviewed by Dan Bernstein.
 704
 705         * WebKitTestRunner/win/TestControllerWin.cpp:
 706         (WTR::TestController::initializeInjectedBundlePath):
 707         Use InjectedBundle_debug.dll when building Debug.
 708
 709 2010-08-23  Xan Lopez  <xlopez@igalia.com>
 710
 711         Reviewed by Martin Robinson.
 712
 713         [GTK] run-launcher fails if WebKitGTK+ compiled with GTK+-3.0 support
 714         https://bugs.webkit.org/show_bug.cgi?id=42026
 715
 716         If a GTK+ 3.x build is present return that as the library to use,
 717         otherwise fallback to the GTK+ 2.x build.
 718
 719         * Scripts/webkitdirs.pm:
 720
 721 2010-08-23  Balazs Kelemen  <kb@inf.u-szeged.hu>
 722
 723         Reviewed by Ariya Hidayat.
 724
 725         [Qt] Find needed forwarding headers for WebKit2 automatically
 726         https://bugs.webkit.org/show_bug.cgi?id=44336
 727
 728         * MiniBrowser/qt/BrowserWindow.cpp: Use normal (not framework style) includes here.
 729         The new script does not satisfy the needs of this file however using normal includes
 730         is generally better here.
 731         * MiniBrowser/qt/MiniBrowser.pro: Added include paths.
 732         * Scripts/enumerate-included-framework-headers: Enumerates headers included from the
 733         given frameworks by files in the current directory (and subdirectories).
 734         In the future this needs to be rewritten in perl for being able to use on Windows.
 735
 736 2010-08-22  No'am Rosenthal  <noam.rosenthal@nokia.com>
 737
 738         Reviewed by Ariya Hidayat.
 739
 740         [Qt] Qt test browser: enable a QGLWidget viewport with a command line argument
 741         https://bugs.webkit.org/show_bug.cgi?id=43010
 742
 743         * QtTestBrowser/launcherwindow.cpp:
 744         (LauncherWindow::applyPrefs):
 745         * QtTestBrowser/main.cpp:
 746         (LauncherApplication::handleUserOptions):
 747
 748 2010-08-21  Sam Weinig  <sam@webkit.org>
 749
 750         Reviewed by Dan Bernstein.
 751
 752         Remove specialized retain/release functions in favor of a single one for WKTypeRefs
 753         https://bugs.webkit.org/show_bug.cgi?id=44386
 754
 755         * MiniBrowser/mac/AppDelegate.m:
 756         (didRecieveMessageFromInjectedBundle):
 757         (didNavigateWithNavigationData):
 758         (-[BrowserAppDelegate init]):
 759         (-[BrowserAppDelegate applicationWillTerminate:]):
 760         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
 761         (-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
 762         (-[BrowserStatisticsWindowController dealloc]):
 763         * MiniBrowser/mac/BrowserWindowController.m:
 764         (-[BrowserWindowController initWithPageNamespace:]):
 765         (-[BrowserWindowController fetch:]):
 766         (-[BrowserWindowController windowWillClose:]):
 767         (-[BrowserWindowController applicationTerminating]):
 768         (closePage):
 769         (runJavaScriptAlert):
 770         (runJavaScriptConfirm):
 771         (runJavaScriptPrompt):
 772         (-[BrowserWindowController updateProvisionalURLForFrame:]):
 773         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
 774         (didClearWindowObjectForFrame):
 775         * MiniBrowser/win/BrowserView.cpp:
 776         (BrowserView::goToURL):
 777         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
 778         (WTR::PlatformWebView::~PlatformWebView):
 779
 780 2010-08-20  Benjamin Poulain  <benjamin.poulain@nokia.com>
 781
 782         Reviewed by Kenneth Rohde Christiansen.
 783
 784         WebKit does not build with Python 2.3
 785         https://bugs.webkit.org/show_bug.cgi?id=44373
 786
 787         Replaced the function sorted() by a call to sort()
 788         on the entry list.
 789         The function sorted() has been added to Python 2.4.
 790         The function method sort() of List works with older
 791         versions of Python.
 792
 793         * Scripts/create-html-entity-table:
 794
 795 2010-08-20  Martin Robinson  <mrobinson@igalia.com>
 796
 797         Reviewed by Pavel Feldman.
 798
 799         Web Inspector: Inspector tests were disabled for GTK.
 800         https://bugs.webkit.org/show_bug.cgi?id=43977
 801
 802         * Scripts/old-run-webkit-tests: Set the WEBKIT_INSPECTOR_PATH to the appropriate
 803         path before running tests.
 804
 805 2010-08-20  Daniel Bates  <dbates@rim.com>
 806
 807         Reviewed by Eric Seidel.
 808
 809         svn-apply doesn't detect empty line with Windows line endings
 810         after property value
 811         https://bugs.webkit.org/show_bug.cgi?id=43981
 812
 813         Part 2 of 2
 814
 815         Add unit tests that were not landed in the first commit.
 816
 817         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
 818           - Added the following test cases:
 819             "SVN: binary file (isBinary true) using Windows line endings"
 820             "SVN: property diff, followed by file change diff using Windows line endings"
 821             "SVN: two consecutive property diffs using Windows line endings"
 822             "SVN: binary file with executable bit change usng Windows line endings"
 823             "SVN: binary file followed by property change on different file using Windows line endings"
 824             "SVN: binary file followed by file change on different file using Windows line endings"
 825             "SVN: file change diff with property change, followed by property change diff using Windows line endings"
 826             "SVN: file change diff with property change, followed by file change diff using Windows line endings"
 827         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
 828           - Added the following test cases:
 829             "add svn:executable, followed by empty line and start of next diff using Windows line endings"
 830             "add svn:executable, followed by empty line and start of next property diff using Windows line endings"
 831             "multi-line '+' change, followed by empty line and start of next diff using Windows line endings"
 832             "multi-line '+' change, followed by empty line and start of next property diff using Windows line endings"
 833             "add svn:executable, followed by empty line and start of binary patch using Windows line endings"
 834             "multi-line '+' change, followed by empty line and start of binary patch using Windows line endings"
 835             "multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings"
 836             "single-line '+' with trailing new line using Windows line endings"
 837             "single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings"
 838             "single-line '-' change with trailing new line, and single-line '+' change using Windows line endings"
 839             "multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
 840         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
 841           - Added the following test cases:
 842             "single-line '-' change followed by empty line with Windows line endings"
 843             "multi-line '+' change and start of binary patch with Windows line endings"
 844
 845 2010-08-20  Daniel Bates  <dbates@rim.com>
 846
 847         Reviewed by Eric Seidel.
 848
 849         svn-apply doesn't detect empty line with Windows line endings
 850         after property value
 851         https://bugs.webkit.org/show_bug.cgi?id=43981
 852
 853         Fixes an issue where an empty line following the property value
 854         in an SVN property change diff would not be detected if it had
 855         Windows line endings (i.e. ended in CRLF). Hence it was consumed
 856         as if it was part of a multi-line property value.
 857
 858         * Scripts/VCSUtils.pm:
 859           - Modified parseSvnPropertyValue() to detect empty line
 860             with Windows line endings.
 861           - Added toWindowsLineEndings().
 862         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
 863           - Added the following test cases:
 864             "SVN: binary file (isBinary true) using Windows line endings"
 865             "SVN: property diff, followed by file change diff using Windows line endings"
 866             "SVN: two consecutive property diffs using Windows line endings"
 867             "SVN: binary file with executable bit change usng Windows line endings"
 868             "SVN: binary file followed by property change on different file using Windows line endings"
 869             "SVN: binary file followed by file change on different file using Windows line endings"
 870             "SVN: file change diff with property change, followed by property change diff using Windows line endings"
 871             "SVN: file change diff with property change, followed by file change diff using Windows line endings"
 872         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
 873           - Added the following test cases:
 874             "add svn:executable, followed by empty line and start of next diff using Windows line endings"
 875             "add svn:executable, followed by empty line and start of next property diff using Windows line endings"
 876             "multi-line '+' change, followed by empty line and start of next diff using Windows line endings"
 877             "multi-line '+' change, followed by empty line and start of next property diff using Windows line endings"
 878             "add svn:executable, followed by empty line and start of binary patch using Windows line endings"
 879             "multi-line '+' change, followed by empty line and start of binary patch using Windows line endings"
 880             "multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings"
 881             "single-line '+' with trailing new line using Windows line endings"
 882             "single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings"
 883             "single-line '-' change with trailing new line, and single-line '+' change using Windows line endings"
 884             "multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
 885         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
 886           - Added the following test cases:
 887             "single-line '-' change followed by empty line with Windows line endings"
 888             "multi-line '+' change and start of binary patch with Windows line endings"
 889
 890 2010-08-19  David Kilzer  <ddkilzer@apple.com>
 891
 892         BUILD FIX: Fix Mac build after Windows WebKit2 changes for Netscape Plug-ins
 893
 894         * MiniBrowser/mac/BrowserWindowController.m:
 895         (decidePolicyForNavigationAction): Updated method signature.
 896         (decidePolicyForNewWindowAction): Updated method signature.
 897
 898 2010-08-19  Adam Roben  <aroben@apple.com>
 899
 900         Test that NP_Initialize and NP_GetEntryPoints are called in the
 901         correct order
 902
 903         The order differs between Mac and Windows (see r38858).
 904
 905         Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in
 906         NP_Initialize when loading QuickTime when running
 907         plugins/embed-attributes-setting.html in WebKit2 on Windows
 908
 909         Reviewed by Sam Weinig.
 910
 911         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and
 912         a boolean to record whether NP_GetEntryPoints has been called.
 913         (NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been
 914         called yet. This matches Flash and QuickTime's behavior. Crash on Mac
 915         if NP_GetEntryPoints has been called already. This matches
 916         Silverlight's behavior.
 917
 918 2010-08-19  Adam Roben  <aroben@apple.com>
 919
 920         Make build-webkittestrunner build TestNetscapePlugIn on Windows
 921
 922         Fixes <http://webkit.org/b/44268> <rdar://problem/8330388>
 923
 924         Reviewed by Sam Weinig.
 925
 926         * WebKitTestRunner/WebKitTestRunner.sln: Added TestNetscapePlugIn.
 927         Threaded it in between ImageDiff and InjectedBundleGenerated.
 928
 929 2010-08-19  Ojan Vafai  <ojan@chromium.org>
 930
 931         Reviewed by Adam Barth.
 932
 933         install rietveld's upload script from a versioned url
 934         https://bugs.webkit.org/show_bug.cgi?id=44291
 935
 936         autoinstall expects the file at a given URL to never change.
 937         In order to be able to update the file, we need to be able to
 938         change the path.
 939
 940         * Scripts/webkitpy/thirdparty/__init__.py:
 941
 942 2010-08-19  Ojan Vafai  <ojan@chromium.org>
 943
 944         Reviewed by Adam Barth.
 945
 946         add --webkit_patch_id to reitveld uploads
 947         https://bugs.webkit.org/show_bug.cgi?id=44289
 948
 949         This is the first step in having rietveld store which
 950         patches have been uploaded and getting rid of the
 951         in-rietveld flag.
 952
 953         * Scripts/webkitpy/common/net/rietveld.py:
 954         * Scripts/webkitpy/tool/mocktool.py:
 955         * Scripts/webkitpy/tool/steps/postcodereview.py:
 956
 957 2010-08-19  Kenneth Russell  <kbr@google.com>
 958
 959         Reviewed by David Levin.
 960
 961         Adjust my status from committer to reviewer
 962         https://bugs.webkit.org/show_bug.cgi?id=44277
 963
 964         * Scripts/webkitpy/common/config/committers.py:
 965
 966 2010-08-19  Pavel Feldman  <pfeldman@chromium.org>
 967
 968         Reviewed by Yury Semikhatsky.
 969
 970         Chromium DevTools: remove injected script fetcher from test harness.
 971         https://bugs.webkit.org/show_bug.cgi?id=44266
 972
 973         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
 974         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
 975
 976 2010-08-19  Pavel Feldman  <pfeldman@chromium.org>
 977
 978         Reviewed by Yury Semikhatsky.
 979
 980         Chromium DevTools: There is no need in resource-based InjectedScript.js source.
 981         Now that we populate front-end after its onload handler, we don't need
 982         to install injected script early. Exposing injected script source on the WebCore
 983         level here.
 984         https://bugs.webkit.org/show_bug.cgi?id=44029
 985
 986         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
 987         (DRTDevToolsAgent::runtimePropertyChanged):
 988         (DRTDevToolsAgent::delayedFrontendLoaded):
 989         (DRTDevToolsAgent::frontendLoaded):
 990         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
 991
 992 2010-08-19  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
 993
 994         Reviewed by Kenneth Rohde Christiansen.
 995
 996         [Gtk] Enable view mode media feature layout test
 997         https://bugs.webkit.org/show_bug.cgi?id=43278
 998
 999         Add view mode media feature testing infrastructure, and add
1000         placeholder methods for the other platforms'
1001         LayoutTestControllers.
1002
1003         * DumpRenderTree/LayoutTestController.cpp:
1004         (setViewModeMediaFeatureCallback):
1005         (LayoutTestController::staticFunctions):
1006         * DumpRenderTree/LayoutTestController.h:
1007         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1008         (LayoutTestController::setViewModeMediaFeature):
1009         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1010         (LayoutTestController::setViewModeMediaFeature):
1011         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1012         (LayoutTestController::setViewModeMediaFeature):
1013         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1014         (LayoutTestController::setViewModeMediaFeature):
1015
1016 2010-08-18  Mark Rowe  <mrowe@apple.com>
1017
1018         Reviewed by Sam Weinig.
1019
1020         Make it so the WebKit2 test slave runs the WebKit2 tests
1021
1022         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1023
1024 2010-08-18  Sam Weinig  <sam@webkit.org>
1025
1026         Reviewed by Mark Rowe.
1027
1028         Make run-webkit-tests --webkit-test-runner build DumpRenderTree
1029         in addition to WebKitTestRunner to get the DumpRenderTreeSupport
1030         module and the TestNetscapePlugin.
1031
1032         * Scripts/old-run-webkit-tests:
1033
1034 2010-08-18  Adam Roben  <aroben@apple.com>
1035
1036         Fix hang when saving crash logs on Windows
1037
1038         * Scripts/old-run-webkit-tests:
1039         (setUpWindowsCrashLogSaving):
1040         (END):
1041         Pass -s to regtool so it will write the Auto value as a string instead
1042         of as a number. This was causing a "do you want to debug?" dialog to
1043         appear.
1044
1045 2010-08-17  Victor Wang  <victorw@chromium.org>
1046
1047         Unreviewed. Fixed chromium incremental test json upload.
1048         Quote builder name and test results server in url.
1049
1050         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1051
1052 2010-08-17  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1053
1054         Reviewed by Ariya Hidayat.
1055
1056         [Qt] [Symbian] Consistently use Q_OS_SYMBIAN to guard all Symbian platform dependencies
1057         https://bugs.webkit.org/show_bug.cgi?id=44124
1058
1059         Q_WS_S60 is not defined for Symbian^4 devices as Q_WS_S60 used to guard
1060         Avkon UI framework dependencies. Use Q_OS_SYMBIAN everywhere to mark
1061         Symbian dependencies.
1062
1063         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1064         (WebCore::DumpRenderTree::open):
1065         * QtTestBrowser/launcherwindow.cpp:
1066         (LauncherWindow::init):
1067         (LauncherWindow::toggleFullScreenMode):
1068         (LauncherWindow::showFPS):
1069         (LauncherWindow::updateFPS):
1070         * QtTestBrowser/launcherwindow.h:
1071         (WindowOptions::WindowOptions):
1072         * QtTestBrowser/mainwindow.cpp:
1073         (MainWindow::buildUI):
1074
1075 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
1076
1077         Reviewed by David Levin.
1078
1079         new-run-webkit-tests: remove --show-sources option
1080
1081         --show-sources is pretty much obsolete with --trace everything, so
1082         I'm removing it.
1083
1084         Also rename a couple of methods in the TestTextDiff class to make their
1085         intended visibility (private) more obvious.
1086
1087         https://bugs.webkit.org/show_bug.cgi?id=44143
1088
1089         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1090         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1091         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1092         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1093         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1094
1095 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
1096
1097         Reviewed by David Levin.
1098
1099         remove --fuzzy-image-diff in new-run-webkit-tests (it doesn't work)
1100
1101         This code bit-rotted at some point more than a year ago, and nobody seems
1102         to miss it. old-run-webkit-tests has a --tolerance flag that new-run-webkit-tests
1103         should support instead, making this flag unnecessary anyway.
1104
1105         https://bugs.webkit.org/show_bug.cgi?id=44141
1106
1107         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1108         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1109         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Removed.
1110
1111 2010-08-17  Victor Wang  <victorw@chromium.org>
1112
1113         Reviewed by Ojan Vafai.
1114
1115         Update json results generator to have incremental json including
1116         results for tests that pass in current run but failed before.
1117
1118         https://bugs.webkit.org/show_bug.cgi?id=44119
1119
1120         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1121         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1122         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1123
1124 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
1125
1126         Reviewed by Eric Seidel.
1127
1128         fix test-webkitpy, add easy way to find a checkout root
1129
1130         test-webkitpy currently doesn't work right if run from someplace other
1131         than the checkout root, and it spews a bunch of debug logging because
1132         the deduplicate_tests tests contaminates the test environment.
1133
1134         This patch cleans up the deduplicate_tests unit tests, and creates
1135         two new methods in scm.py: find_checkout_root() and default_scm(),
1136         both of which use a single algorithm for guessing what checkout root
1137         to use if you aren't explicitly told one from a path.
1138
1139         https://bugs.webkit.org/show_bug.cgi?id=44001
1140
1141         * Scripts/deduplicate-tests:
1142         * Scripts/webkitpy/common/checkout/scm.py:
1143         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1144         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
1145         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1146         * Scripts/webkitpy/layout_tests/port/test.py:
1147         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1148         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1149         * Scripts/webkitpy/tool/main.py:
1150
1151 2010-08-17  Victor Wang  <victorw@chromium.org>
1152
1153         Reviewed by Ojan Vafai.
1154
1155         Add support to the test results server for downloading json that
1156         contains test list only.
1157
1158         This is for json results generator to generate incremental json
1159         results so that it includes results not only for tests failed in
1160         current run, but also tests failed before.
1161
1162         Also set the results type to "N" (no data) instead of "P" (pass)
1163         if test results cannot be found in incremental json file.
1164
1165         https://bugs.webkit.org/show_bug.cgi?id=44117
1166
1167         * TestResultServer/handlers/testfilehandler.py:
1168         * TestResultServer/model/jsonresults.py:
1169         * TestResultServer/model/jsonresults_unittest.py:
1170
1171 2010-08-17  Adam Roben  <aroben@apple.com>
1172
1173         Use the right path style
1174
1175         * Scripts/old-run-webkit-tests:
1176
1177 2010-08-17  Adam Roben  <aroben@apple.com>
1178
1179         Fix typo
1180
1181         * Scripts/old-run-webkit-tests:
1182
1183 2010-08-17  Adam Roben  <aroben@apple.com>
1184
1185         Don't hang when running run-webkit-tests as a non-Administrator on
1186         Vista/7
1187
1188         * Scripts/old-run-webkit-tests:
1189         (setUpWindowsCrashLogSaving): Use regtool to set NTSD as the
1190         post-mortem debugger, rather than using NTSD itself. The latter waits
1191         for user input when it fails to set the registry values; the former
1192         does not.
1193
1194 2010-08-17  Adam Roben  <aroben@apple.com>
1195
1196         Teach run-webkit-tests, DumpRenderTree, and WebKitTestRunner how to
1197         save crash logs on Windows
1198
1199         The crash logs are saved to /tmp/layout-test-results and have names
1200         like CrashLog_02bc_2010-08-17_14-36-20-108.txt.
1201
1202         Unfortunately, crashes in the WebKit2 web process are recorded as
1203         time-outs by run-webkit-tests. Fixing this is covered by
1204         <http://webkit.org/b/44121>.
1205
1206         Fixes <http://webkit.org/b/37859> <rdar://problem/7883560>
1207         DumpRenderTree should save a stack trace and/or dump file when it
1208         crashes
1209
1210         Reviewed by Sam Weinig.
1211
1212         * DumpRenderTree/win/DumpRenderTree.cpp:
1213         (exceptionFilter):
1214         (main):
1215         * WebKitTestRunner/win/TestControllerWin.cpp:
1216         (WTR::exceptionFilter):
1217         (WTR::TestController::platformInitialize):
1218         These changes set up an exception filter that prints #CRASHED to
1219         stderr, then lets the exception propagate normally. This allows
1220         run-webkit-tests to detect when we've crashed even when a post-mortem
1221         debugger attaches to the process.
1222
1223         * Scripts/old-run-webkit-tests:
1224         (top level): Declared some variables used by the crash-log-saving
1225         code.
1226         (openDumpTool): Copy _NT_SYMBOL_PATH into the clean environment so
1227         that the post-mortem debugger has access to it.
1228         (toCygwinPath): Added. This is the opposite of toWindowsPath.
1229         (readFromDumpToolWithTimer): If the dump tool prints #CRASHED to
1230         stderr, consider it a crash.
1231         (setUpWindowsCrashLogSaving): Added. Saves the current post-mortem
1232         debugger, then sets ntsd as the post-mortem debugger. ntsd is
1233         configured to save a crash log and then quit automatically.
1234         (END): Added. Restores the previous post-mortem debugger when the
1235         script exits.
1236
1237 2010-08-17  Victor Wang  <victorw@chromium.org>
1238
1239         Reviewed by ojan@chromium.org.
1240
1241         Update test results server:
1242         1. Normalize test results and times after merging (prune tests where
1243            all runs pass or do not have data, truncate all test items to max
1244            number of builds)
1245         2. times should be int not string.
1246         3. when inserting a new test item, should keep old data regardless
1247            whether or not they have same item type with new one.
1248
1249         https://bugs.webkit.org/show_bug.cgi?id=43861
1250
1251         * TestResultServer/model/jsonresults.py:
1252         * TestResultServer/model/jsonresults_unittest.py:
1253
1254 2010-08-16  Sam Weinig  <sam@webkit.org>
1255
1256         Reviewed by Mark Rowe.
1257
1258         Add WebKit2 Mac tester to buildbot.
1259
1260         * BuildSlaveSupport/build.webkit.org-config/config.json:
1261         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1262
1263 2010-08-16  Paul Sawaya  <psawaya@apple.com>
1264
1265         Reviewed by Chris Marrin.
1266
1267         Added shader validation via ANGLE
1268         https://bugs.webkit.org/show_bug.cgi?id=42405
1269
1270         Added ANGLE to webkit build
1271
1272         * Scripts/build-webkit:
1273
1274 2010-08-16  Kevin Ollivier  <kevino@theolliviers.com>
1275
1276         [wx] Build fix, do not build WebCore as a convenience library as this leads to
1277         errors in the Win build w/export symbols and causes problems with DOM bindings
1278         debugging in gdb.
1279
1280         * DumpRenderTree/wscript:
1281         * Scripts/build-webkit:
1282         * wx/browser/wscript:
1283         * wx/build/settings.py:
1284         * wx/build/waf_extensions.py:
1285
1286 2010-08-16  Dan Bernstein  <mitz@apple.com>
1287
1288         Build fix.
1289
1290         * WebKitTestRunner/TestController.cpp:
1291         (WTR::createOtherPage): Initialize the contentsSizeChanged member.
1292         (WTR::TestController::initialize): Ditto.
1293
1294 2010-08-16  Balazs Kelemen  <kb@inf.u-szeged.hu>
1295
1296         Reviewed by Kenneth Rohde Christiansen.
1297
1298         Handle content size change in WebKit2
1299         Re-landing after fix.
1300
1301         https://bugs.webkit.org/show_bug.cgi?id=43198
1302
1303         * MiniBrowser/mac/BrowserWindowController.m:
1304         (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
1305         * MiniBrowser/win/BrowserView.cpp:
1306         (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.
1307
1308 2010-08-16  Sheriff Bot  <webkit.review.bot@gmail.com>
1309
1310         Unreviewed, rolling out r65419.
1311         http://trac.webkit.org/changeset/65419
1312         https://bugs.webkit.org/show_bug.cgi?id=44053
1313
1314         Broke the Windows build (Requested by bbandix on #webkit).
1315
1316         * MiniBrowser/mac/BrowserWindowController.m:
1317         (-[BrowserWindowController awakeFromNib]):
1318         * MiniBrowser/win/BrowserView.cpp:
1319         (BrowserView::create):
1320
1321 2010-08-16  Balazs Kelemen  <kb@inf.u-szeged.hu>
1322
1323         Reviewed by Kenneth Rohde Christiansen.
1324
1325         Handle content size change in WebKit2
1326
1327         https://bugs.webkit.org/show_bug.cgi?id=43198
1328
1329         * MiniBrowser/mac/BrowserWindowController.m:
1330         (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
1331         * MiniBrowser/win/BrowserView.cpp:
1332         (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.
1333
1334 2010-08-16  Ariya Hidayat  <ariya@sencha.com>
1335
1336         Add my new email address to committers.py.
1337
1338         * Scripts/webkitpy/common/config/committers.py:
1339
1340 2010-08-16  Zoltan Horvath  <zoltan@webkit.org>
1341
1342         Add my old e-mail addresses to committers.py.
1343
1344         * Scripts/webkitpy/common/config/committers.py:
1345
1346 2010-08-15  Jon Honeycutt  <jhoneycutt@apple.com>
1347
1348         WebEditorClient::didBeginEditing is never called in WebKit2
1349         https://bugs.webkit.org/show_bug.cgi?id=42939
1350
1351         Reviewed by Sam Weinig.
1352
1353         * WebKitTestRunner/PlatformWebView.h:
1354         Declare focus().
1355
1356         * WebKitTestRunner/TestController.cpp:
1357         (WTR::TestController::resetStateToConsistentValues):
1358         Focus the PlatformWebView.
1359
1360         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1361         (WTR::PlatformWebView::focus):
1362         Stubbed.
1363
1364         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1365         (WTR::PlatformWebView::focus):
1366         Focus the view.
1367
1368 2010-08-15  Jon Honeycutt  <jhoneycutt@apple.com>
1369
1370         run-webkit-tests should not strip editing callbacks when using
1371         WebKitTestRunner on Windows
1372         https://bugs.webkit.org/show_bug.cgi?id=44000
1373
1374         Reviewed by Mark Rowe.
1375
1376         * Scripts/old-run-webkit-tests:
1377         Leave $stripEditingCallbacks undefined until we look for command-line
1378         arguments. If using WebKit2, set it to 0 if not explicity set on the
1379         command line. Later, set it to isCygwin() to match old behavior if it is
1380         not yet defined.
1381
1382 2010-08-15  Kevin Ollivier  <kevino@theolliviers.com>
1383
1384         [wx] Build fix, remove define always set to the correct value by wtf/Platform.h.
1385
1386         * wx/build/settings.py:
1387
1388 2010-08-14  Martin Robinson  <mrobinson@igalia.com>
1389
1390         Reviewed by Kenneth Rohde Christiansen.
1391
1392         [GTK] autogen.sh not executed if build-webkit options change
1393         https://bugs.webkit.org/show_bug.cgi?id=42266
1394
1395         Rerun autogen.sh in situations where the arguments to build-webkit have
1396         changed since the previous build. This will fix some issues on the bots
1397         where the build does not notice changes to default build-webkit arguments.
1398
1399         * Scripts/webkitdirs.pm: Add special logic for detecting changes to build-webkit arguments.
1400
1401 2010-08-14  Eric Seidel  <eric@webkit.org>
1402
1403         Unreviewed.  Another fix to support python 2.3.
1404
1405         Add support for MathML entities
1406         https://bugs.webkit.org/show_bug.cgi?id=43949
1407
1408         * Scripts/webkitpy/thirdparty/simplejson/decoder.py:
1409          - It looks like our simplejson is version 1.7.3 which
1410            should be python 2.3 compatible.  But someone modified
1411            our copy slightly from the original source.
1412            I've removed the relative import in hopes this fixes
1413            the problem.
1414
1415 2010-08-13  Eric Seidel  <eric@webkit.org>
1416
1417         Unreviewed.  Build fix only.
1418
1419         Add support for MathML entities
1420         https://bugs.webkit.org/show_bug.cgi?id=43949
1421
1422         * Scripts/create-html-entity-table:
1423          - Hack sys.path to avoid executing 2.5 dependent python
1424            on systems (like chromium-win and Tiger) which do not have 2.5 python.
1425
1426 2010-08-13  Adam Barth  <abarth@webkit.org>
1427
1428         Reviewed by Eric Seidel.
1429
1430         Rename some concepts in HTML entity search to be more self-documenting
1431         https://bugs.webkit.org/show_bug.cgi?id=44004
1432
1433         Reflect name change in generator script.
1434
1435         * Scripts/create-html-entity-table:
1436
1437 2010-08-12  Adam Barth  <abarth@webkit.org>
1438
1439         Reviewed by Eric Seidel.
1440
1441         Add support for MathML entities
1442         https://bugs.webkit.org/show_bug.cgi?id=43949
1443
1444         A script for generating the C++ state data structure describing all the
1445         entities from a JSON description.
1446
1447         * Scripts/create-html-entity-table: Added.
1448
1449 2010-08-13  Dirk Pranke  <dpranke@chromium.org>
1450
1451         Reviewed by Eric Seidel.
1452
1453         Rewrite new-run-webkit-test's wait_for_threads_to_finish loop to
1454         check for exceptions on all threads, not just the first thread.
1455
1456         This change also changes the logging behavior for wedged threads
1457         to only dump the stacks of threads that are actually wedged.
1458
1459         Refactor the thread classes in the dump_render_tree_thread module
1460         to make the contract between TestRunner and TestShellThread clearer.
1461
1462         Added a bunch of unit tests.
1463         https://bugs.webkit.org/show_bug.cgi?id=38561
1464
1465         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1466         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1467         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1468
1469 2010-08-13  Kenichi Ishibashi  <bashi@google.com>
1470
1471         Reviewed by Shinichiro Hamaji.
1472
1473         Add test_expectations.txt syntax checker to check-webkit-style.
1474         https://bugs.webkit.org/show_bug.cgi?id=43899
1475
1476         Just utilizing layout_tests/layout_package/test_expectations.py for checking
1477         the syntax of test_expectations.txt.
1478         This change also moves tab checking class from style/checkers/text.py to
1479         style/checkers/common.py for sharing code.
1480
1481         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1482         * Scripts/webkitpy/style/checker.py:
1483         * Scripts/webkitpy/style/checkers/common.py:
1484         * Scripts/webkitpy/style/checkers/common_unittest.py:
1485         * Scripts/webkitpy/style/checkers/test_expectations.py: Added.
1486         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Added.
1487         * Scripts/webkitpy/style/checkers/text.py:
1488         * Scripts/webkitpy/style_references.py:
1489
1490 2010-08-12  Jon Honeycutt  <jhoneycutt@apple.com>
1491
1492         WebKitTestRunner does not correctly resize WebView for W3C SVG tests
1493         https://bugs.webkit.org/show_bug.cgi?id=43945
1494
1495         Reviewed by Sam Weinig.
1496
1497         * WebKitTestRunner/TestInvocation.cpp:
1498         (WTR::sizeWebViewForCurrentTest):
1499         Allow for a Windows-style path.
1500
1501         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1502         (WTR::PlatformWebView::resizeTo):
1503         Call SetWindowPos to resize the view window.
1504
1505 2010-08-12  David Levin  <levin@chromium.org>
1506
1507         Build break fix.
1508
1509         * WebKitTestRunner/TestController.cpp:
1510         (WTR::TestController::resetStateToConsistentValues): Removed usage
1511         of a variable that doesn't exist in the class.
1512
1513 2010-08-12  Jon Honeycutt  <jhoneycutt@apple.com>
1514
1515         WebKitTestRunner needs to run tests without using native controls
1516         https://bugs.webkit.org/show_bug.cgi?id=43772
1517
1518         Reviewed by Sam Weinig.
1519
1520         * WebKitTestRunner/TestController.cpp:
1521         (WTR::TestController::initialize):
1522         Call platformInitializeContext().
1523
1524         * WebKitTestRunner/TestController.h:
1525         Declare platformInitializeContext().
1526
1527         * WebKitTestRunner/mac/TestControllerMac.mm:
1528         (WTR::TestController::platformInitializeContext):
1529         Stubbed.
1530
1531         * WebKitTestRunner/win/TestControllerWin.cpp:
1532         (WTR::TestController::platformInitializeContext):
1533         Call WKContextSetShouldPaintNativeControls() to disable native control
1534         drawing.
1535
1536 2010-08-12  Sam Weinig  <sam@webkit.org>
1537
1538         Reviewed by Alexey Proskuryakov.
1539
1540         WebKitTestRunner should be more aggressive about ensuring consistent state between tests
1541         https://bugs.webkit.org/show_bug.cgi?id=43653
1542
1543         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1544         (WTR::InjectedBundle::InjectedBundle):
1545         (WTR::InjectedBundle::didReceiveMessage):
1546         (WTR::InjectedBundle::beginTesting):
1547         (WTR::InjectedBundle::done):
1548         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1549         (WTR::InjectedBundle::isTestRunning):
1550         (WTR::InjectedBundle::):
1551         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1552         (WTR::InjectedBundlePage::stopLoading):
1553         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1554         (WTR::InjectedBundlePage::dump):
1555         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1556         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1557         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
1558         (WTR::InjectedBundlePage::didClearWindowForFrame):
1559         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
1560         (WTR::InjectedBundlePage::willAddMessageToConsole):
1561         (WTR::InjectedBundlePage::willSetStatusbarText):
1562         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
1563         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
1564         (WTR::InjectedBundlePage::shouldBeginEditing):
1565         (WTR::InjectedBundlePage::shouldEndEditing):
1566         (WTR::InjectedBundlePage::shouldInsertNode):
1567         (WTR::InjectedBundlePage::shouldInsertText):
1568         (WTR::InjectedBundlePage::shouldDeleteRange):
1569         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
1570         (WTR::InjectedBundlePage::shouldApplyStyle):
1571         (WTR::InjectedBundlePage::didBeginEditing):
1572         (WTR::InjectedBundlePage::didEndEditing):
1573         (WTR::InjectedBundlePage::didChange):
1574         (WTR::InjectedBundlePage::didChangeSelection):
1575         Don't do any work if we are not currently running a test.
1576
1577         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1578         * WebKitTestRunner/StringFunctions.h:
1579         (WTR::toCF):
1580         Add conversion function for WKURLRef -> CFURLRef
1581
1582         * WebKitTestRunner/TestController.cpp:
1583         (WTR::TestController::TestController):
1584         (WTR::TestController::initialize):
1585         (WTR::TestController::resetStateToConsistentValues):
1586         (WTR::TestController::runTest):
1587         (WTR::TestController::didFinishLoadForFrame):
1588         * WebKitTestRunner/TestController.h:
1589         (WTR::TestController::):
1590         * WebKitTestRunner/TestInvocation.cpp:
1591         (WTR::TestInvocation::invoke):
1592         * WebKitTestRunner/TestInvocation.h:
1593         Move resetting code to TestController.
1594
1595         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1596         * WebKitTestRunner/mac/TestControllerMac.mm:
1597         (WTR::TestController::runUntil):
1598         * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
1599         * WebKitTestRunner/win/TestControllerWin.cpp:
1600         (WTR::TestController::runUntil):
1601         * WebKitTestRunner/win/TestInvocationWin.cpp: Removed.
1602         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1603         Move runUntil to TestController.
1604
1605 2010-08-12  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
1606
1607         Unreviewed.
1608
1609         Adding myself to the committers list.
1610
1611         * Scripts/webkitpy/common/config/committers.py:
1612
1613 2010-08-12  Hayato Ito  <hayato@chromium.org>
1614
1615         Reviewed by Tony Chang.
1616
1617         Merge pretty printers for gdb.
1618         https://bugs.webkit.org/show_bug.cgi?id=43850
1619
1620         We need to update webcore.py because basic string classes have moved to WTF from WebCore.
1621         It is good timing to merge webcore.py and wtf.py and name it 'webkit.py'.
1622         webcore.py is left for backward compatibility.
1623
1624         * gdb/webcore.py:
1625         * gdb/webkit.py: Added.
1626         * gdb/wtf.py: Removed.
1627
1628 2010-08-11  Tony Chang  <tony@chromium.org>
1629
1630         Reviewed by David Levin.
1631
1632         [chromium] add google-chrome layout test result directories
1633         https://bugs.webkit.org/show_bug.cgi?id=43889
1634
1635         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1636         * Scripts/webkitpy/layout_tests/port/factory.py:
1637         * Scripts/webkitpy/layout_tests/port/google_chrome.py: Added.
1638         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1639
1640 2010-08-11  Kent Tamura  <tkent@chromium.org>
1641
1642         Reviewed by Dimitri Glazkov.
1643
1644         [DRT/Chromium] Disable accelerated compositing
1645         https://bugs.webkit.org/show_bug.cgi?id=43894
1646
1647         Disable accelerated compositing because DRT is not ready for
1648         it. This change fixes hundreds of test crashes on Windows and
1649         Linux.
1650
1651         * DumpRenderTree/chromium/TestShell.cpp:
1652         (TestShell::resetWebSettings):
1653
1654 2010-08-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1655
1656         Unreviewed. Adding my Collabora personality to the list.
1657
1658         * Scripts/webkitpy/common/config/committers.py:
1659
1660 2010-08-11  Martin Robinson  <mrobinson@igalia.com>
1661
1662         Adding myself as a reviewer.
1663
1664         * Scripts/webkitpy/common/config/committers.py:
1665
1666 2010-08-11  Daniel Bates  <dbates@rim.com>
1667
1668         Reviewed by Darin Adler.
1669
1670         Perl warnings when running commit-log-editor
1671         https://bugs.webkit.org/show_bug.cgi?id=43856
1672
1673         Fixes Perl warnings introduced by the patch for Bug #40548.
1674
1675         Perl doesn't have symbolic names for True/False. Instead, we
1676         should use boolean values. Moreover, the variable installedEditorApplication
1677         is not be used and should be renamed builtEditorApplication so that it
1678         uses the existing machinery to set the commit log editor application.
1679
1680         * Scripts/commit-log-editor:
1681
1682 2010-08-11  Adam Barth  <abarth@webkit.org>
1683
1684         Reviewed by Eric Seidel.
1685
1686         Trying waiting for httpd lock in the EWS
1687         https://bugs.webkit.org/show_bug.cgi?id=43833
1688
1689         If this works, we can probably run the tests on the mac-ews, which
1690         would be very exciting.  :)
1691
1692         * Scripts/webkitpy/tool/steps/runtests.py:
1693
1694 2010-08-11  Marcus Bulach  <bulach@chromium.org>
1695
1696         Reviewed by Eric Seidel.
1697
1698         Check in a script to list redundant test outputs.
1699         https://bugs.webkit.org/show_bug.cgi?id=37630
1700
1701         If e.g. platform/mac-leopard is missing an expected test output, we
1702         fall back on platform/mac.  This means it's possible to grow redundant
1703         test outputs, where we have the same expected data in both a platform
1704         directory and another platform it falls back on.
1705         (original patch by Evan Marting <evan@chromium.org> https://bugs.webkit.org/attachment.cgi?id=53398)
1706
1707         * Scripts/deduplicate-tests: Added.
1708         * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Added.
1709         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: Added.
1710
1711 2010-08-11  Antonio Gomes  <tonikitoo@webkit.org>
1712
1713         Reviewed by Ariya Hidayat.
1714
1715         [Qt] QtTestBrowser: after switching between QWebView and QGraphicsWebView, rotation actions get broken
1716         https://bugs.webkit.org/show_bug.cgi?id=43853
1717
1718         LauncherWindow::createChrome is connecting menu itens to WebViewGraphicsBased's slots directly.
1719         It behaviors badly when user launches the QtTestBrowser in QWebView mode, since then switching to
1720         QGraphicsWebView mode, createChrome is not called again, and menu items end up not getting connected
1721         to slots at all.
1722
1723         * QtTestBrowser/launcherwindow.cpp:
1724         (LauncherWindow::createChrome):
1725         (LauncherWindow::animatedFlip):
1726         (LauncherWindow::animatedYFlip):
1727         * QtTestBrowser/launcherwindow.h:
1728
1729 2010-08-11  Antonio Gomes  <tonikitoo@webkit.org>
1730
1731         Reviewed by Simon Hausmann.
1732
1733         [Qt] QtTestBrowser: switching between QWebView and QGraphicsWebView modes is broken
1734         https://bugs.webkit.org/show_bug.cgi?id=43851
1735
1736         All window options data (including the bool holding if the view is either QWebView or
1737         QGraphicsWebView based) is stored in m_windowOptions, a class member of LauncherWindow.
1738         When toggle the view from QWebView to QGraphicsWebView based (and vice-versa), we were
1739         not updating LauncherWindow::WindowOptions::m_useGraphicsView bit, and then things were
1740         getting broken.
1741
1742         Patch addresses this issue.
1743
1744         * QtTestBrowser/launcherwindow.cpp:
1745         (LauncherWindow::createChrome):
1746         (LauncherWindow::toggleWebView):
1747         (LauncherWindow::toggleAcceleratedCompositing):
1748
1749 2010-08-10  Antonio Gomes  <tonikitoo@webkit.org>
1750
1751         Reviewed by Ariya Hidayat.
1752
1753         [Qt] QtTestBrowser: lazy instantiate "YRotation" state machine and related objects
1754         https://bugs.webkit.org/show_bug.cgi?id=43831
1755
1756         Only instantiate QStateMachine and friends associated to the YRotation action on demand.
1757
1758         * QtTestBrowser/webview.cpp:
1759         (WebViewGraphicsBased::WebViewGraphicsBased):
1760         (WebViewGraphicsBased::animatedYFlip):
1761
1762 2010-08-11  Darin Adler  <darin@apple.com>
1763
1764         Reviewed by John Sullivan.
1765
1766         Improved editor options for prepare-ChangeLog and commit-log-editor
1767         https://bugs.webkit.org/show_bug.cgi?id=40548
1768
1769         * Scripts/commit-log-editor: Split editor strings on spaces so EDITOR
1770         values like "xed --launch --wait" work properly.
1771
1772         * Scripts/prepare-ChangeLog: Added a new CHANGE_LOG_EDITOR so we can
1773         use a command line tool with the $openChangeLogs feature.
1774
1775 2010-08-11  Yury Semikhatsky  <yurys@chromium.org>
1776
1777         Reviewed by Pavel Feldman.
1778
1779         Web Inspector: remove InjectDispatch.js
1780         https://bugs.webkit.org/show_bug.cgi?id=43835
1781
1782         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1783         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1784
1785 2010-08-10  Dirk Pranke  <dpranke@chromium.org>
1786
1787         Reviewed by Eric Seidel.
1788
1789         webkit-patch should refuse to run under Win32 Python
1790         https://bugs.webkit.org/show_bug.cgi?id=40962
1791
1792         Given that there are lots of places in webkit-patch's code that
1793         assume unix-style filenames (forward slashes), webkit-patch fails
1794         with weird file-not-found errors when run under a native windows
1795         Python. It would be nice if we just trapped this and errored out
1796         at the beginning, rather than producing unpredictable errors.
1797
1798         * Scripts/webkit-patch:
1799
1800 2010-08-10  Kent Tamura  <tkent@chromium.org>
1801
1802         Unreviewed, build fix.
1803
1804         Chromium build fix for r65107.
1805
1806         * DumpRenderTree/chromium/LayoutTestController.cpp:
1807         (LayoutTestController::suspendAnimations):
1808         (LayoutTestController::resumeAnimations):
1809
1810 2010-08-10  Sergio Villar Senin  <svillar@igalia.com>
1811
1812         Reviewed by Xan Lopez.
1813
1814         [GTK] http/tests/media/video-cookie.html fails
1815         https://bugs.webkit.org/show_bug.cgi?id=42240
1816
1817         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1818         (LayoutTestController::setAlwaysAcceptCookies): create the
1819         SoupCookieJar if it does not exist. Otherwise the accept policy
1820         won't be set.
1821
1822 2010-08-10  Chris Marrin  <cmarrin@apple.com>
1823
1824         Reviewed by Oliver Hunt.
1825
1826         Add suspendAnimations/resumeAnimation API to DRT
1827         https://bugs.webkit.org/show_bug.cgi?id=43733
1828
1829         Adds suspendAnimations() and resumeAnimations() to LayoutTestController.
1830         Calls functions with the same names on AnimationController for the
1831         mainFrame.
1832
1833         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1834         * DumpRenderTree/LayoutTestController.cpp:
1835         (suspendAnimationsCallback):
1836         (resumeAnimationsCallback):
1837         (LayoutTestController::staticFunctions):
1838         * DumpRenderTree/LayoutTestController.h:
1839         * DumpRenderTree/chromium/LayoutTestController.cpp:
1840         (LayoutTestController::LayoutTestController):
1841         (LayoutTestController::suspendAnimations):
1842         (LayoutTestController::resumeAnimations):
1843         * DumpRenderTree/chromium/LayoutTestController.h:
1844         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1845         (LayoutTestController::suspendAnimations):
1846         (LayoutTestController::resumeAnimations):
1847         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1848         (LayoutTestController::suspendAnimations):
1849         (LayoutTestController::resumeAnimations):
1850         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1851         (LayoutTestController::suspendAnimations):
1852         (LayoutTestController::resumeAnimations):
1853         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1854         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1855         (LayoutTestController::suspendAnimations):
1856         (LayoutTestController::resumeAnimations):
1857         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1858         (LayoutTestController::suspendAnimations):
1859         (LayoutTestController::resumeAnimations):
1860
1861 2010-08-10  Dimitri Glazkov  <dglazkov@chromium.org>
1862
1863         Reviewed by Ojan Vafai.
1864
1865         [Chromium/DRT] Enable saving layout test results.
1866         https://bugs.webkit.org/show_bug.cgi?id=43796
1867
1868         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added more
1869             parameters to the new-run-webkit-tests, including the name
1870             of the test results server.
1871
1872 2010-08-10  Jian Li  <jianli@chromium.org>
1873
1874         More chromium build fix.
1875
1876         * DumpRenderTree/chromium/MockSpellCheck.cpp:
1877         (MockSpellCheck::spellCheckWord):
1878         (MockSpellCheck::initializeIfNeeded):
1879         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1880         (NotificationPresenter::grantPermission):
1881         (NotificationPresenter::show):
1882         (NotificationPresenter::checkPermission):
1883
1884 2010-08-10  Jian Li  <jianli@chromium.org>
1885
1886         Chromium build fix.
1887
1888         * DumpRenderTree/chromium/MockSpellCheck.cpp:
1889         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1890
1891 2010-08-10  Victor Wang  <victorw@chromium.org>
1892
1893         Reviewed by Ojan Vafai.
1894
1895         Update test results server merge logic so the aggregated
1896         results and times are updated for tests that are
1897         in aggragated json but not in incremental json.
1898
1899         Also update unittest to test this case.
1900
1901         https://bugs.webkit.org/show_bug.cgi?id=43769
1902
1903         * TestResultServer/model/jsonresults.py:
1904         * TestResultServer/model/jsonresults_unittest.py:
1905
1906 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
1907
1908         Reviewed by Ariya Hidayat.
1909
1910         [Qt] QtTestBrowser: proper set scene rect
1911
1912         When resizesToContents is ON scene's rect is set to the boundary of
1913         the mainFrame. However, navigating to other web page should keep resizing
1914         scene's rect according to the new document loaded. Patch addresses this issue.
1915
1916         Now resizesToContents and scrolling properly work on QtTestBrowser.
1917
1918         * QtTestBrowser/webview.cpp:
1919         (WebViewGraphicsBased::setPage):
1920         (WebViewGraphicsBased::contentsSizeChanged):
1921         (WebViewGraphicsBased::setResizesToContents):
1922         (WebViewGraphicsBased::resizeEvent):
1923         * QtTestBrowser/webview.h:
1924
1925 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
1926
1927         Reviewed by Ariya Hidayat.
1928
1929         [Qt] QtTestBrowser: Clean up LauncherWindow code.
1930
1931         * QtTestBrowser/launcherwindow.cpp:
1932         (LauncherWindow::LauncherWindow): Moves applyPrefs methods call from the constructor to init().
1933         (LauncherWindow::init): Fixed comments.
1934         (LauncherWindow::applyPrefs): Move the method around.
1935         (LauncherWindow::createChrome): Move more code of this method around, for grouping, and fixing up comments.
1936
1937 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
1938
1939         Reviewed by Ariya Hidayat.
1940
1941         [Qt] QtTestBrowser: make reset-zooming to animate when tiled backing store is on.
1942
1943         It gets control+0 the same visual effect as control++ or control-.
1944
1945         * QtTestBrowser/launcherwindow.cpp:
1946         (LauncherWindow::toggleZoomTextOnly):
1947
1948 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
1949
1950         Reviewed by Ariya Hidayat.
1951
1952         [Qt] QtTestBrowser:: make m_zoomLevels a static member.
1953
1954         Not all instances of LauncherWindow need its own m_zoomLevel.
1955
1956         * QtTestBrowser/launcherwindow.cpp:
1957         * QtTestBrowser/launcherwindow.h:
1958
1959 2010-08-09  Sam Weinig  <sam@webkit.org>
1960
1961         Reviewed by Geoffrey Garen.
1962
1963         Add zoom support for injected bundle
1964         https://bugs.webkit.org/show_bug.cgi?id=43759
1965
1966         Use zoom factor SPI to implement zoom related eventSender functions.
1967
1968         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1969         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1970         (WTR::EventSendingController::textZoomIn):
1971         (WTR::EventSendingController::textZoomOut):
1972         (WTR::EventSendingController::zoomPageIn):
1973         (WTR::EventSendingController::zoomPageOut):
1974         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1975         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1976         (WTR::InjectedBundlePage::reset): Reset zoom mode and level for each test.
1977
1978 2010-08-09  Gavin Barraclough  <barraclough@apple.com>
1979
1980         Speculative chromium build fix III.
1981
1982         * DumpRenderTree/chromium/MockSpellCheck.h:
1983         * DumpRenderTree/chromium/NotificationPresenter.h:
1984         * DumpRenderTree/chromium/WebViewHost.h:
1985         (WebViewHost::addClearHeader):
1986         (WebViewHost::clearHeaders):
1987
1988 2010-08-09  Ojan Vafai  <ojan@chromium.org>
1989
1990         Reviewed by Tony Chang.
1991
1992         increase the number of test results that we save
1993         https://bugs.webkit.org/show_bug.cgi?id=43763
1994
1995         Now that we do incremental uploads, we can increase the number of
1996         results that we save for http://test-results.appspot.com/dashboards/flakiness_dashboard.html.
1997
1998         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1999
2000 2010-08-09  Evan Martin  <evan@chromium.org>
2001
2002         Reviewed by Tony Chang.
2003
2004         [chromium] DRT error print statement incorrectly tries to print a FILE*
2005         https://bugs.webkit.org/show_bug.cgi?id=43747
2006
2007         * DumpRenderTree/chromium/ImageDiff.cpp:
2008         (writeFile): pass the correct pointer.
2009
2010 2010-08-09  Victor Wang  <victorw@chromium.org>
2011
2012         Reviewed by Ojan Vafai.
2013
2014         Upload incremental test results json to server by default.
2015
2016         https://bugs.webkit.org/show_bug.cgi?id=43743
2017
2018         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2019
2020 2010-08-09  Eric Seidel  <eric@webkit.org>
2021
2022         Reviewed by Adam Barth.
2023
2024         EWS bots wait 2 minutes between patches
2025         https://bugs.webkit.org/show_bug.cgi?id=43731
2026
2027         * Scripts/webkitpy/tool/bot/queueengine.py:
2028          - Don't sleep after failures.  This was a hold-over from
2029            an earlier design.
2030         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2031          - EWS bots were not properly reporting true/false from process_work_item.
2032            They were always returning None, thus false, thus always logging
2033            as a failure and sleeping 2 minutes after each patch.
2034
2035 2010-08-09  Sam Weinig  <sam@webkit.org>
2036
2037         Reviewed by Anders Carlsson.
2038
2039         Stub out EventSender for WebKitTestRunner
2040         https://bugs.webkit.org/show_bug.cgi?id=43703
2041
2042         * WebKitTestRunner/DerivedSources.make:
2043         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2044         Add ability to pass javascript arguments to the wrapped object.
2045
2046         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added.
2047         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: Added.
2048         (WTR::EventSendingController::create):
2049         (WTR::EventSendingController::EventSendingController):
2050         (WTR::EventSendingController::~EventSendingController):
2051         (WTR::EventSendingController::wrapperClass):
2052         (WTR::setExceptionForString):
2053         (WTR::EventSendingController::mouseDown):
2054         (WTR::EventSendingController::mouseUp):
2055         (WTR::EventSendingController::mouseMoveTo):
2056         (WTR::EventSendingController::keyDown):
2057         (WTR::EventSendingController::contextClick):
2058         (WTR::EventSendingController::leapForward):
2059         (WTR::EventSendingController::textZoomIn):
2060         (WTR::EventSendingController::textZoomOut):
2061         (WTR::EventSendingController::zoomPageIn):
2062         (WTR::EventSendingController::zoomPageOut):
2063         (WTR::EventSendingController::makeWindowObject):
2064         * WebKitTestRunner/InjectedBundle/EventSendingController.h: Added.
2065         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2066         (WTR::InjectedBundle::reset):
2067         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2068         (WTR::InjectedBundle::eventSendingController):
2069         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2070         (WTR::InjectedBundlePage::didClearWindowForFrame):
2071         Add stubbed out EventSenderController.
2072
2073         * WebKitTestRunner/InjectedBundle/GCController.h:
2074         Remove incorrect comment.
2075
2076         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2077         * WebKitTestRunner/win/InjectedBundle.vcproj:
2078         Add new files.
2079
2080 2010-08-08  Kent Tamura  <tkent@chromium.org>
2081
2082         Unreviewed, trivial fix.
2083
2084         Fix "WindowsError: [Error 32] The process cannot access the file
2085         because it is being used by another process" introduced by r64959.
2086
2087         * BuildSlaveSupport/test-result-archive:
2088
2089 2010-08-08  Kent Tamura  <tkent@chromium.org>
2090
2091         Reviewed by Tony Chang.
2092
2093         Chromium buildbot: Avoid "zip" command dependency
2094         https://bugs.webkit.org/show_bug.cgi?id=43470
2095
2096         * BuildSlaveSupport/test-result-archive:
2097          For Chromium port, creates a zip archive with zipfile package of Python
2098          instead of external "zip" command. We'd like to avoid additional
2099          command installation.
2100
2101 2010-08-08  Jon Honeycutt  <jhoneycutt@apple.com>
2102
2103         WebKitTestRunner should add the QuickTime dir to the PATH environment
2104         variable
2105         https://bugs.webkit.org/show_bug.cgi?id=43686
2106
2107         Reviewed by Dan Bernstein.
2108
2109         * WebKitTestRunner/win/TestControllerWin.cpp:
2110         (WTR::addQTDirToPATH):
2111         Copied from DRT.
2112         (WTR::TestController::platformInitialize):
2113         Call addQTDirToPath().
2114         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2115         Link to shlwapi.lib for SHGetValue.
2116
2117 2010-08-07  Sam Weinig  <sam@webkit.org>
2118
2119         Reviewed by Maciej Stachowiak.
2120
2121         WebKitTestRunner needs layoutTestController.dumpTitleChanges
2122         <rdar://problem/8213861>
2123         https://bugs.webkit.org/show_bug.cgi?id=42683
2124
2125         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2126         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2127         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
2128         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
2129         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2130         (WTR::LayoutTestController::LayoutTestController):
2131         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2132         (WTR::LayoutTestController::dumpTitleChanges):
2133         (WTR::LayoutTestController::shouldDumpTitleChanges):
2134
2135 2010-08-07  Sam Weinig  <sam@webkit.org>
2136
2137         Reviewed by Anders Carlsson.
2138
2139         WebKitTestRunner needs to print onunload handler information
2140         <rdar://problem/8213831>
2141         https://bugs.webkit.org/show_bug.cgi?id=42703
2142
2143         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2144         (WTR::operator<<):
2145         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
2146
2147 2010-08-07  Sam Weinig  <sam@webkit.org>
2148
2149         Reviewed by Anders Carlsson.
2150
2151         Add additional loader client functions need to complete WebKitTestRunner
2152         https://bugs.webkit.org/show_bug.cgi?id=43684
2153
2154         Remove unnecessary and jarring underscores as well.
2155
2156         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2157         (didClearWindowObjectForFrame):
2158         (didCreatePage):
2159         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2160         (WTR::InjectedBundlePage::InjectedBundlePage):
2161         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
2162         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
2163         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
2164         (WTR::InjectedBundlePage::didCommitLoadForFrame):
2165         (WTR::InjectedBundlePage::didFinishLoadForFrame):
2166         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
2167         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
2168         (WTR::InjectedBundlePage::didClearWindowForFrame):
2169         (WTR::InjectedBundlePage::didCancelClientRedirectForFrame):
2170         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
2171         (WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
2172         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
2173         (WTR::InjectedBundlePage::didHandleOnloadEventsForFrame):
2174         (WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
2175         (WTR::InjectedBundlePage::didRunInsecureContentForFrame):
2176         (WTR::InjectedBundlePage::willAddMessageToConsole):
2177         (WTR::InjectedBundlePage::willSetStatusbarText):
2178         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
2179         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
2180         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
2181         (WTR::InjectedBundlePage::shouldBeginEditing):
2182         (WTR::InjectedBundlePage::shouldEndEditing):
2183         (WTR::InjectedBundlePage::shouldInsertNode):
2184         (WTR::InjectedBundlePage::shouldInsertText):
2185         (WTR::InjectedBundlePage::shouldDeleteRange):
2186         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
2187         (WTR::InjectedBundlePage::shouldApplyStyle):
2188         (WTR::InjectedBundlePage::didBeginEditing):
2189         (WTR::InjectedBundlePage::didEndEditing):
2190         (WTR::InjectedBundlePage::didChange):
2191         (WTR::InjectedBundlePage::didChangeSelection):
2192         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2193
2194 2010-08-07  Dan Bernstein  <mitz@apple.com>
2195
2196         Build fix.
2197
2198         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Made the references
2199         to JSGCController.{cpp,h} relative to the build root.
2200
2201 2010-08-07  Sam Weinig  <sam@webkit.org>
2202
2203         Reviewed by Anders Carlsson.
2204
2205         WebKitTestRunner needs GCController
2206         <rdar://problem/8213834>
2207         https://bugs.webkit.org/show_bug.cgi?id=42701
2208
2209         * WebKitTestRunner/DerivedSources.make:
2210         * WebKitTestRunner/InjectedBundle/Bindings/GCController.idl: Added.
2211         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h:
2212         (WTR::setProperty):
2213         * WebKitTestRunner/InjectedBundle/GCController.cpp: Added.
2214         (WTR::GCController::create):
2215         (WTR::GCController::GCController):
2216         (WTR::GCController::~GCController):
2217         (WTR::GCController::wrapperClass):
2218         (WTR::GCController::collect):
2219         (WTR::GCController::collectOnAlternateThread):
2220         (WTR::GCController::getJSObjectCount):
2221         (WTR::GCController::makeWindowObject):
2222         * WebKitTestRunner/InjectedBundle/GCController.h: Added.
2223         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2224         (WTR::InjectedBundle::reset):
2225         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2226         (WTR::InjectedBundle::bundle):
2227         (WTR::InjectedBundle::gcController):
2228         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2229         (WTR::InjectedBundlePage::didClearWindowForFrame):
2230         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2231         (WTR::LayoutTestController::keepWebHistory):
2232         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2233         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2234         * WebKitTestRunner/win/InjectedBundle.vcproj:
2235
2236 2010-08-05  Jon Honeycutt  <jhoneycutt@apple.com>
2237
2238         WebKitTestRunner needs to be able to set the font smoothing type
2239         https://bugs.webkit.org/show_bug.cgi?id=43406
2240
2241         Reviewed by Adam Roben.
2242
2243         * WebKitTestRunner/TestInvocation.cpp:
2244         (WTR::TestInvocation::resetPreferencesToConsistentValues):
2245         Set the font smoothing level to
2246         kWKFontSmoothingLevelNoSubpixelAntiAliasing to match DRT.
2247
2248 2010-08-06  Jon Honeycutt  <jhoneycutt@apple.com>
2249
2250         Fix a missed variable rename.
2251
2252         Unreviewed.
2253
2254         * Scripts/old-run-webkit-tests:
2255
2256 2010-08-06  Jon Honeycutt  <jhoneycutt@apple.com>
2257
2258         mac-wk2/Skipped should be used on Windows when running regression tests
2259         https://bugs.webkit.org/show_bug.cgi?id=43494
2260
2261         Reviewed by Adam Roben.
2262
2263         * Scripts/old-run-webkit-tests:
2264         If the platform is win-wk2, also read the mac-wk2 skipped list.
2265
2266 2010-08-06  Kent Tamura  <tkent@chromium.org>
2267
2268         Reviewed by Dimitri Glazkov.
2269
2270         [DRT/Chromium] Should revoke scheduled tasks
2271         https://bugs.webkit.org/show_bug.cgi?id=43560
2272
2273         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2274         (DRTDevToolsAgent::reset): Calls RevokeAll().
2275         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2276         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
2277         (DRTDevToolsClient::reset): Calls RevokeAll().
2278         * DumpRenderTree/chromium/DRTDevToolsClient.h:
2279         * DumpRenderTree/chromium/EventSender.cpp:
2280         (EventSender::reset): Calls RevokeAll().
2281         * DumpRenderTree/chromium/LayoutTestController.cpp:
2282         (LayoutTestController::reset): Calls RevokeAll().
2283         * DumpRenderTree/chromium/TestShell.cpp:
2284         (TestShell::resetTestController): Calls DRTDevToolsAgent::reset() and DRTDevToolsClient::reset().
2285
2286 2010-08-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2287
2288         Reviewed by Antonio Gomes.
2289
2290         [Qt] Fix the DRT build on Mac OS X
2291
2292         * DumpRenderTree/qt/DumpRenderTree.pro:
2293
2294 2010-08-06  Jochen Eisinger  <jochen@chromium.org>
2295
2296         Reviewed by Pavel Feldman.
2297
2298         Rietvield's upload.py moved to a different location.
2299         https://bugs.webkit.org/show_bug.cgi?id=43613
2300
2301         * Scripts/webkitpy/thirdparty/__init__.py:
2302
2303 2010-05-23  Eric Seidel  <eric@webkit.org>
2304
2305         Reviewed by Adam Barth.
2306
2307         QueueStatusServer needs better queue-status pages
2308         https://bugs.webkit.org/show_bug.cgi?id=39562
2309
2310         The primary goal of this patch is to display queue
2311         positions somewhere on the site so that it's easier
2312         for commit-queue users to know when their pach will
2313         be landed.  I also tried to improve the root page
2314         to be more useful than the previous wall of status text.
2315
2316         * QueueStatusServer/handlers/recentstatus.py:
2317         * QueueStatusServer/main.py:
2318         * QueueStatusServer/model/queues.py:
2319         * QueueStatusServer/templates/recentstatus.html:
2320
2321 2010-08-05  Victor Wang  <victorw@chromium.org>
2322
2323         Reviewed by Ojan Vafai.
2324
2325         Add option to generate/upload incremental json results to test result server.
2326         Also refactor the json results generator unittest code to test
2327         incremental and aggregated json results.
2328
2329         https://bugs.webkit.org/show_bug.cgi?id=43519
2330
2331         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2332         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2333         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2334         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2335
2336 2010-08-05  Jian Li  <jianli@chromium.org>
2337
2338         Reviewed by David Levin.
2339
2340         Unify blob related feature defines to ENABLE(BLOB).
2341         https://bugs.webkit.org/show_bug.cgi?id=43081
2342
2343         * Scripts/build-webkit:
2344
2345 2010-08-05  Satish Sampath  <satish@chromium.org>
2346
2347         Reviewed by Jeremy Orlow.
2348
2349         Add speech input controller mock in WebKit and a layout test.
2350         https://bugs.webkit.org/show_bug.cgi?id=43477
2351
2352         Added LayoutTestController::setMockSpeechInputResultCallback method.
2353
2354         * DumpRenderTree/LayoutTestController.cpp:
2355         (setMockSpeechInputResultCallback): Wrapper invoking the member function.
2356         (LayoutTestController::staticFunctions):
2357         * DumpRenderTree/LayoutTestController.h:
2358         * DumpRenderTree/chromium/LayoutTestController.cpp:
2359         (LayoutTestController::LayoutTestController):
2360         (LayoutTestController::setMockSpeechInputResult): Sets the mock result.
2361         (LayoutTestController::speechInputController): Creates the mock controller.
2362         * DumpRenderTree/chromium/LayoutTestController.h:
2363         * DumpRenderTree/chromium/WebViewHost.cpp:
2364         (WebViewHost::speechInputController): Creates the mock controller.
2365         * DumpRenderTree/chromium/WebViewHost.h:
2366         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2367         (LayoutTestController::setMockSpeechInputResult): dummy method.
2368         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2369         (LayoutTestController::setMockSpeechInputResult): dummy method.
2370         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2371         (LayoutTestController::setMockSpeechInputResult): dummy method.
2372         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2373         * DumpRenderTree/win/LayoutTestControllerWin.cpp: dummy method.
2374         (LayoutTestController::setMockSpeechInputResult):
2375         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: dummy method.
2376         (LayoutTestController::setMockSpeechInputResult):
2377
2378 2010-08-04  Adam Roben  <aroben@apple.com>
2379
2380         Fix the path to TestNetscapePlugin's directory on Windows
2381
2382         Fixes <http://webkit.org/b/43513> WebKitTestRunner on Windows fails to
2383         load TestNetscapePlugin
2384
2385         Reviewed by Jon Honeycutt.
2386
2387         * WebKitTestRunner/win/TestControllerWin.cpp:
2388         (WTR::TestController::initializeTestPluginDirectory):
2389         TestNetscapePlugin is in a TestNetscapePlugin[_Debug] directory that's
2390         next to WebKitTestRunner.exe. Previously we were passing the directory
2391         that contains WebKitTestRunner.exe. Also fixed some leaks.
2392
2393 2010-08-05  Kenichi Ishibashi  <bashi@google.com>
2394
2395         Reviewed by Shinichiro Hamaji.
2396
2397         check-webkit-style returns non-zero when patch is entirely minus lines.
2398         https://bugs.webkit.org/show_bug.cgi?id=38169
2399
2400         * Scripts/check-webkit-style:
2401         Check whether a patch contains modified files that are entirely minus lines.
2402         * Scripts/webkitpy/style/filereader.py:
2403         Add a variable that holds number of files that contain only deleted lines.
2404         * Scripts/webkitpy/style/patchreader.py:
2405         Count up modified files that contain only deleted lines.
2406
2407 2010-08-05  Pavel Feldman  <pfeldman@chromium.org>
2408
2409         Reviewed by Yury Semikhatsky.
2410
2411         DevTools: get rid of delayed command dispatching on front-end side.
2412
2413         https://bugs.webkit.org/show_bug.cgi?id=43479
2414
2415         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2416         (DRTDevToolsAgent::detach):
2417         (DRTDevToolsAgent::frontendLoaded):
2418         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2419         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
2420         (DRTDevToolsClient::~DRTDevToolsClient):
2421         (DRTDevToolsClient::sendFrontendLoaded):
2422         * DumpRenderTree/chromium/DRTDevToolsClient.h:
2423
2424 2010-08-04  Kenichi Ishibashi  <bashi@google.com>
2425
2426         Reviewed by Shinichiro Hamaji.
2427
2428         Fixes check-webkit-style false positive on "new uint32_t."
2429         https://bugs.webkit.org/show_bug.cgi?id=43077
2430
2431         * Scripts/webkitpy/style/checkers/cpp.py:
2432         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2433
2434 2010-08-04  Kent Tamura  <tkent@chromium.org>
2435
2436         Reviewed by Dimitri Glazkov.
2437
2438         [DRT/Chromium] Remove base/linked_ptr.h dependency
2439         https://bugs.webkit.org/show_bug.cgi?id=43472
2440
2441         Replace linked_ptr<TestNavigationEntry> with RefPtr<TestNavigationEntry>.
2442         We need to use RefPtr<> because m_pendingEntry points an object in
2443         m_entries or not in m_entries.
2444
2445         * DumpRenderTree/chromium/TestNavigationController.cpp:
2446         (TestNavigationEntry::create): Added.
2447         (TestNavigationController::activeEntry):
2448         (TestNavigationController::didNavigateToEntry):
2449         (TestNavigationController::discardPendingEntry):
2450         (TestNavigationController::insertEntry):
2451         (TestNavigationController::navigateToPendingEntry):
2452         * DumpRenderTree/chromium/TestNavigationController.h:
2453         * DumpRenderTree/chromium/WebViewHost.cpp:
2454         (WebViewHost::loadURLForFrame):
2455          Use TestNavigationEntry::create().
2456         (WebViewHost::updateURL):
2457          Use RefPtr<>.
2458         (WebViewHost::updateSessionHistory):
2459          Remove unnecessary static_cast<>.
2460
2461 2010-08-04  Kent Tamura  <tkent@chromium.org>
2462
2463         Reviewed by Dimitri Glazkov.
2464
2465         Fix a problem that "archived test results" step doesn't work on Chromium buildbots
2466         https://bugs.webkit.org/show_bug.cgi?id=43333
2467
2468         * BuildSlaveSupport/test-result-archive:
2469           - Make layoutTestResultsDir local and pass it to archiveTestResults()
2470           - Adjust layoutTestResultsDir for Chromium
2471
2472 2010-08-04  Kent Tamura  <tkent@chromium.org>
2473
2474         Reviewed by Dimitri Glazkov.
2475
2476         NRWT: websocket_server startup detection failure
2477         https://bugs.webkit.org/show_bug.cgi?id=43466
2478
2479         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2480          Increase timeout value: 5 second -> 10 second
2481
2482 2010-08-04  Victor Wang  <victorw@chromium.org>
2483
2484         Reviewed by Ojan Vafai.
2485
2486         -. Add result.json incremental merging functionality to test results app engine.
2487         -. blobstore is not suitable for AE data merging and there is no API to
2488            programatically edit existing blob or write a new one yet, so replace blobstore
2489            with datastore. If file is oversize (>1000*1000 bytes), store file data in
2490            multiple datastore entries.
2491         -. Fix styles.
2492
2493         Test: jsonresults_unittest to test merging logics.
2494
2495         https://bugs.webkit.org/show_bug.cgi?id=38599
2496
2497         * TestResultServer/handlers/dashboardhandler.py:
2498         * TestResultServer/handlers/menu.py:
2499         * TestResultServer/handlers/testfilehandler.py:
2500         * TestResultServer/main.py:
2501         * TestResultServer/model/dashboardfile.py:
2502         * TestResultServer/model/datastorefile.py: Added.
2503         * TestResultServer/model/jsonresults.py: Added.
2504         * TestResultServer/model/jsonresults_unittest.py: Added.
2505         * TestResultServer/model/testfile.py:
2506         * TestResultServer/templates/uploadform.html:
2507
2508 2010-08-04  Antonio Gomes  <tonikitoo@webkit.org>
2509
2510         Reviewed by Kenneth Christiansen.
2511
2512         [Qt] [QtTestBrowser] Remove unneeded QAction class members
2513         https://bugs.webkit.org/show_bug.cgi?id=43518
2514
2515         LauncherWindow class has two totally unneeded class members: m_flopAnimated and
2516         m_flipYAnimated. Also, in initializeView method there are some dead code block
2517         trying to connect them at the wrong time, when they have not been instanciated.
2518
2519         This patch:
2520
2521         - removes the two cited class members in favor of local variables in createChrome method;
2522         - removes the dead code block.
2523
2524         * QtTestBrowser/launcherwindow.cpp:
2525         (LauncherWindow::LauncherWindow):
2526         (LauncherWindow::initializeView):
2527         (LauncherWindow::createChrome):
2528         * QtTestBrowser/launcherwindow.h:
2529
2530 2010-08-04  Antonio Gomes  <tonikitoo@webkit.org>
2531
2532         Reviewed by Simon Hausmann and Kenneth Christiansen.
2533
2534         [Qt] [QtTestBrowser] Clean up static and global menu state controls
2535         https://bugs.webkit.org/show_bug.cgi?id=43448
2536
2537         After LauncherWindow class was refactored out of from main.cpp, all global variables that
2538         were hanging in main.cpp became temporarily public static class members of newly added
2539         LauncherWindow class. This design was not properly handling the initial purpose of the
2540         global variables: newly created launcher windows should inherit the settings of the originating
2541         one.
2542
2543         In order to properly fix the problem, this patch introduces a WindowOptions class, as a POD. It
2544         comprises all data needed to handling the goal described above.
2545
2546         * QtTestBrowser/launcherwindow.cpp:
2547         (LauncherWindow::LauncherWindow): The class now receives an optional WindowOptions pointer object
2548                                           holding all user settings configured in the menus and command line.
2549                                           It also receices an optional QGraphicsScene points in case we are doing
2550                                           a "Clone Window".
2551         (LauncherWindow::init): Removed the usesGraphics parameter because the class member m_userData holds its
2552                                 value.
2553         (LauncherWindow::initializeView): Ditto.
2554         (LauncherWindow::createChrome): Changed all references to gXXX to m_userData.XXX
2555         (LauncherWindow::applyPrefs): Removed the "LauncherWindow* source" parameter. All data needed to properly
2556                                       apply the preferences is provided by m_userData.
2557         (LauncherWindow::toggleAcceleratedCompositing): Change gXXX by m_userData.XXX
2558         (LauncherWindow::toggleResizesToContents): Ditto.
2559         (LauncherWindow::toggleWebGL): Ditto.
2560         (LauncherWindow::toggleFrameFlattening): Ditto.
2561         (LauncherWindow::toggleQGLWidgetViewport): Ditto.
2562         (LauncherWindow::changeViewportUpdateMode): Ditto.
2563         (LauncherWindow::showFPS): Ditto.
2564         (LauncherWindow::newWindow): Changed to pass the userData.
2565         (LauncherWindow::cloneWindow): Ditto.
2566         * QtTestBrowser/launcherwindow.h:
2567         (WindowOptions::WindowOptions):
2568         * QtTestBrowser/main.cpp:
2569         (requiresGraphicsView):
2570         (LauncherApplication::handleUserOptions):
2571         (main):
2572
2573 2010-08-04  Kevin Ollivier  <kevino@theolliviers.com>
2574
2575         [wx] Build fix for gcc not importing all symbols from convenience libraries.
2576         Works on 10.6 only for Mac until the build system is reworked.
2577
2578         * wx/build/settings.py:
2579
2580 2010-08-04  Markus Goetz  <Markus.Goetz@nokia.com>
2581
2582         Reviewed by Simon Hausmann.
2583
2584         [Qt] Change wording in QtTestBrowser
2585         https://bugs.webkit.org/show_bug.cgi?id=43241
2586
2587         * QtTestBrowser/launcherwindow.cpp:
2588         (LauncherWindow::createChrome):
2589
2590 2010-08-04  Aaron Boodman  <aa@chromium.org>
2591
2592         Reviewed by Eric Seidel.
2593
2594         prepare-ChangeLog fails mysteriously if curl doesn't support ssl
2595         https://bugs.webkit.org/show_bug.cgi?id=43460
2596
2597         * Scripts/prepare-ChangeLog:
2598
2599 2010-08-03  MORITA Hajime  <morrita@google.com>
2600
2601         Reviewed by Tony Chang.
2602
2603         [DRT] Assertion failed when drag and move a draggable element.
2604         https://bugs.webkit.org/show_bug.cgi?id=41695
2605
2606         mouseMoveToX() did call [WebHTMLView mouseDragged] even if dragging started.
2607         But Cocoa doesn't call mouseDragged() until dragging is done.
2608         Other part of DumpRenderTree also assumes Cocoa behavior and an assertion
2609         on UIDelegate failed when mouseDragged() is called during dragging.
2610         This change eliminated the mouseDragged() call when dragging begins,
2611         which is implicated by draggingInfo instance.
2612
2613         * DumpRenderTree/mac/EventSendingController.mm:
2614         (-[EventSendingController mouseMoveToX:Y:]):
2615
2616         Test: fast/events/dragging-mouse-moves.html
2617
2618 2010-08-02  Steve Block  <steveblock@google.com>
2619
2620         Reviewed by Alexey Proskuryakov.
2621
2622         Adds Geolocation LayoutTests for the case where permission is not granted or denied immediately
2623         https://bugs.webkit.org/show_bug.cgi?id=40002
2624
2625         The code in LayoutTestController::setGeolocationPermission() was moved to
2626         setGeolocationPermissionCommon() to allow each port to provide its own
2627         implementation of setGeolocationPermission().
2628
2629         For the Mac port, setGeolocationPermission() notifies the UIDelegate of the
2630         new permission, so it can call back to WebCore if permission requests are in
2631         progress and are waiting for a response. A minor fix to the Mac
2632         MockGeolocationProvider was also required to make sure that the mock provider
2633         calls back to WebCore when it is first started.
2634
2635         For other ports, LayoutTestController::setGeolocationPermission() is not
2636         implemented.
2637
2638         * DumpRenderTree/LayoutTestController.cpp:
2639         (LayoutTestController::setGeolocationPermissionCommon):
2640         * DumpRenderTree/LayoutTestController.h:
2641         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2642         (LayoutTestController::setGeolocationPermission):
2643         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2644         (LayoutTestController::setGeolocationPermission):
2645         * DumpRenderTree/mac/MockGeolocationProvider.mm:
2646         (-[MockGeolocationProvider registerWebView:]):
2647         * DumpRenderTree/mac/UIDelegate.h:
2648         * DumpRenderTree/mac/UIDelegate.mm:
2649         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
2650         (-[UIDelegate setGeolocationPermission:]):
2651         (-[UIDelegate dealloc]):
2652         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2653         (LayoutTestController::setGeolocationPermission):
2654         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2655         (LayoutTestController::setGeolocationPermission):
2656
2657 2010-08-03  Kent Tamura  <tkent@chromium.org>
2658
2659         Reviewed by Dimitri Glazkov.
2660
2661         [DRT/Chromium] Implement --testshell-startup-dialog
2662         https://bugs.webkit.org/show_bug.cgi?id=40616
2663
2664         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2665         (main): Check --testshell-startup-dialog, and call openStartUpDialog()
2666         if it is specfied.
2667         * DumpRenderTree/chromium/TestShell.h:
2668           Declare openStartUpDialog().
2669         * DumpRenderTree/chromium/TestShellGtk.cpp:
2670         (openStartupDialog):
2671         * DumpRenderTree/chromium/TestShellMac.mm:
2672         (openStartupDialog):
2673         * DumpRenderTree/chromium/TestShellWin.cpp:
2674         (openStartupDialog):
2675
2676 2010-08-03  Kent Tamura  <tkent@chromium.org>
2677
2678         Reviewed by Dimitri Glazkov.
2679
2680         [DRT/Chromium] Remove dependency of base/md5.h
2681         https://bugs.webkit.org/show_bug.cgi?id=43403
2682
2683         * DumpRenderTree/chromium/TestShell.cpp:
2684         (TestShell::dumpImage): Use wtf/MD5.h
2685
2686 2010-08-03  Joseph Pecoraro  <joepeck@webkit.org>
2687
2688         Reviewed by David Kilzer.
2689
2690         Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
2691         https://bugs.webkit.org/show_bug.cgi?id=40627
2692
2693         Part 6 - LayoutTest and Cleanup
2694
2695           Allow tests to delete application caches and set application cache
2696           origin quotas, so they can be tested.
2697
2698         * DumpRenderTree/LayoutTestController.cpp:
2699         (LayoutTestController::LayoutTestController):
2700         (dumpApplicationCacheDelegateCallbacksCallback): JavaScript callback, delegates to the controller.
2701         (clearAllApplicationCachesCallback): should delete all application caches.
2702         (setApplicationCacheOriginQuotaCallback): should set the origin quota for the localhost tests.
2703         (LayoutTestController::staticFunctions):
2704         * DumpRenderTree/LayoutTestController.h:
2705         (LayoutTestController::dumpApplicationCacheDelegateCallbacks): accessor to see if application cache callbacks should be output.
2706         (LayoutTestController::setDumpApplicationCacheDelegateCallbacks): enable or disable debug output when the application cache quota is reached.
2707
2708           Mac implementation.
2709
2710         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2711         (LayoutTestController::clearAllApplicationCaches): delete application caches.
2712         (LayoutTestController::setApplicationCacheOriginQuota): set the quota for localhost.
2713         * DumpRenderTree/mac/UIDelegate.mm:
2714         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): style fix.
2715         (-[UIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:]): reset the quota.
2716
2717           Stub implementations for other platforms.
2718
2719         * DumpRenderTree/chromium/LayoutTestController.cpp:
2720         (LayoutTestController::LayoutTestController):
2721         (LayoutTestController::clearAllApplicationCaches):
2722         (LayoutTestController::setApplicationCacheOriginQuota):
2723         * DumpRenderTree/chromium/LayoutTestController.h:
2724         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2725         (LayoutTestController::clearAllApplicationCaches):
2726         (LayoutTestController::setApplicationCacheOriginQuota):
2727         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2728         (LayoutTestController::clearAllApplicationCaches):
2729         (LayoutTestController::setApplicationCacheOriginQuota):
2730         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2731         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2732         (LayoutTestController::clearAllApplicationCaches):
2733         (LayoutTestController::setApplicationCacheOriginQuota):
2734         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2735         (LayoutTestController::clearAllApplicationCaches):
2736         (LayoutTestController::setApplicationCacheOriginQuota):
2737
2738 2010-08-03  Joseph Pecoraro  <joepeck@webkit.org>
2739
2740         Reviewed by David Kilzer.
2741
2742         Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
2743         https://bugs.webkit.org/show_bug.cgi?id=40627
2744
2745         Part 5 - Refactor Quota Management in WebSecurityOrigin into Managers
2746
2747           Change old style calls to make use of the managers.
2748
2749         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2750         (LayoutTestController::setDatabaseQuota):
2751         * DumpRenderTree/mac/UIDelegate.mm:
2752         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]):
2753
2754 2010-08-03  Mark Rowe  <mrowe@apple.com>
2755
2756         Add a new Leopard build slave to run the release tests.
2757
2758         * BuildSlaveSupport/build.webkit.org-config/config.json:
2759
2760 2010-08-03  Jon Honeycutt  <jhoneycutt@apple.com>
2761
2762         WebKitTestRunner needs to activate the Mac font ascent hack
2763         https://bugs.webkit.org/show_bug.cgi?id=43404
2764
2765         Reviewed by Darin Adler.
2766
2767         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2768         (WTR::InjectedBundle::initialize):
2769         Call WKBundleActivateMacFontAscentHack().
2770
2771 2010-08-03  Alex Milowski  <alex@milowski.com>
2772
2773         Reviewed by Beth Dakin.
2774
2775         Changed the default for MathML support so that is is enabled by default.
2776
2777         * Scripts/build-webkit:
2778
2779 2010-08-03  Sam Weinig  <sam@webkit.org>
2780
2781         Roll r64566 back in this time with all the overloads in place..
2782
2783         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2784         (WTR::InjectedBundlePage::shouldInsertNode):
2785         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2786         * WebKitTestRunner/StringFunctions.h:
2787         * WebKitTestRunner/TestInvocation.cpp:
2788         (WTR::TestInvocation::resetPreferencesToConsistentValues):
2789         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2790         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2791
2792 2010-08-03  Sam Weinig  <sam@webkit.org>
2793
2794         Rollout r64566. It broke all the WebKit2 tests.
2795
2796         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2797         (WTR::operator<<):
2798         (WTR::InjectedBundlePage::shouldInsertNode):
2799         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2800         * WebKitTestRunner/StringFunctions.h: Removed.
2801         * WebKitTestRunner/TestInvocation.cpp:
2802         (WTR::createWKURL):
2803         (WTR::WKStringToUTF8):
2804         (WTR::TestInvocation::resetPreferencesToConsistentValues):
2805         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2806         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2807
2808 2010-08-03  Sam Weinig  <sam@webkit.org>
2809
2810         Reviewed by Anders Carlsson.
2811
2812         WTR: Move all the utility functions for working with strings to a shared header.
2813         https://bugs.webkit.org/show_bug.cgi?id=43386
2814
2815         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2816         (WTR::InjectedBundlePage::shouldInsertNode):
2817         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2818         * WebKitTestRunner/StringFunctions.h: Added.
2819         * WebKitTestRunner/TestInvocation.cpp:
2820         (WTR::TestInvocation::resetPreferencesToConsistentValues):
2821         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2822         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2823
2824 2010-08-02  Antonio Gomes  <tonikitoo@webkit.org>
2825
2826         Reviewed by Kenneth Christiansen.
2827
2828         [Qt] QtTestBrowser not setting preferredContentsSize for resizesToContents
2829         https://bugs.webkit.org/show_bug.cgi?id=43168
2830
2831         QGraphicsWebView resizesToContents property has to work together with QWebPage's
2832         setPreferredContentsSize as stated by the docs. Patch addresses that for QtTestBrowser.
2833
2834         * QtTestBrowser/launcherwindow.cpp:
2835         (LauncherWindow::applyPrefs):
2836         * QtTestBrowser/webview.cpp:
2837         (WebViewGraphicsBased::setResizesToContents): Properly handle scene, webview and viewport sizes
2838                                                       needed when toggle resizesToContents on/off.
2839         (WebViewGraphicsBased::resizeEvent):
2840         * QtTestBrowser/webview.h:
2841         (WebViewGraphicsBased::setCustomLayoutSize): Setter helper.
2842         (WebViewGraphicsBased::customLayoutSize): Getter helper.
2843
2844 2010-08-03  Jochen Eisinger  <jochen@chromium.org>
2845
2846         Unreviewed. Adding myself as committer.
2847
2848         * Scripts/webkitpy/common/config/committers.py:
2849
2850 2010-08-02  Pavel Feldman  <pfeldman@chromium.org>
2851
2852         Reviewed by Yury Semikhatsky.
2853
2854         Chromium DevTools: Get rid of DevTools RPC.
2855
2856         https://bugs.webkit.org/show_bug.cgi?id=43335
2857
2858         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2859         (DRTDevToolsAgent::sendMessageToInspectorFrontend):
2860         (DRTDevToolsAgent::call):
2861         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2862         * DumpRenderTree/chromium/DRTDevToolsCallArgs.h:
2863         (DRTDevToolsCallArgs::DRTDevToolsCallArgs):
2864         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
2865         (DRTDevToolsClient::sendMessageToBackend):
2866         (DRTDevToolsClient::call):
2867         * DumpRenderTree/chromium/DRTDevToolsClient.h:
2868
2869 2010-08-02  Kent Tamura  <tkent@chromium.org>
2870
2871         Reviewed by Dimitri Glazkov.
2872
2873         [DRT/Chromium] Remove dependencies to some Chromium headers
2874         https://bugs.webkit.org/show_bug.cgi?id=43396
2875
2876         * DumpRenderTree/chromium/CppVariant.h:
2877          Remove base/basictypes.h because webkit_support.h contains it.
2878         * DumpRenderTree/chromium/EventSender.cpp:
2879         (getCurrentEventTimeSec): Use new wrapper function.
2880         * DumpRenderTree/chromium/TestNavigationController.h:
2881          Remove base/basictypes.h because webkit_support.h contains it.
2882         * DumpRenderTree/chromium/TestShell.cpp:
2883         (dumpHistoryItem): Use new wrapper function.
2884         * DumpRenderTree/chromium/WebViewHost.cpp:
2885         (WebViewHost::cancelledError): Use new wrapper function.
2886         (WebViewHost::didFailResourceLoad): Use new wrapper function.
2887
2888 2010-08-02  Martin Robinson  <mrobinson@igalia.com>
2889
2890         Reviewed by Xan Lopez.
2891
2892         [GTK] DRT implement execCommand()
2893         https://bugs.webkit.org/show_bug.cgi?id=35351
2894
2895         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2896         (LayoutTestController::execCommand): Implement using webkit_web_view_execute_core_command_by_name.
2897         (LayoutTestController::isCommandEnabled): Implement using webkit_web_view_is_command_enabled.
2898         (LayoutTestController::setCacheModel): Move below LayoutTestController::isCommandEnabled.
2899
2900 2010-08-02  Sam Weinig  <sam@webkit.org>
2901
2902         Reviewed by Anders Carlsson.
2903
2904         Add alias for run-webkit-tests --webkit-test-runner (run-webkit-tests -2).
2905
2906         * Scripts/old-run-webkit-tests:
2907
2908 2010-08-02  Jon Honeycutt  <jhoneycutt@apple.com>
2909
2910         WebKitTestRunner needs to support loading custom fonts (via the
2911         WEBKIT_TESTFONTS environment variable)
2912         https://bugs.webkit.org/show_bug.cgi?id=42782
2913
2914         Reviewed by Adam Roben.
2915
2916         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:
2917         (WTR::fontsPath):
2918         Copied from DRT code. Removed the fallback to DumpRenderTree.resources/,
2919         as this directory doesn't appear to be created anymore.
2920         (WTR::activateFonts):
2921         Loop through the fonts, and call AddFontResourceExW() for each.
2922
2923 2010-08-02  Jon Honeycutt  <jhoneycutt@apple.com>
2924
2925         Restore the WebKitTestRunner.sln that was removed, and remove the
2926         correct one.
2927
2928         Rubber-stamped by Sam Weinig.
2929
2930         * WebKitTestRunner/WebKitTestRunner.sln: Added.
2931         * WebKitTestRunner/win/WebKitTestRunner.sln: Removed.
2932
2933 2010-08-02  Jon Honeycutt  <jhoneycutt@apple.com>
2934
2935         Move InjectedBundle.vcproj to where the other WebKitTestRunner vcprojs live.
2936
2937         Remove the unused WebKitTestRunner.sln.
2938
2939         Reviewed by Sam Weinig.
2940
2941         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2942         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: Removed.
2943         * WebKitTestRunner/WebKitTestRunner.sln: Removed.
2944         * WebKitTestRunner/win/InjectedBundle.vcproj: Added.
2945         * WebKitTestRunner/win/WebKitTestRunner.sln:
2946
2947 2010-08-02  Sam Weinig  <sam@webkit.org>
2948
2949         Fix the windows build.
2950
2951         * WebKitTestRunner/win/main.cpp:
2952
2953 2010-07-29  Jon Honeycutt  <jhoneycutt@apple.com>
2954
2955         Add a Skipped list on Windows, and have run-webkit-tests respect it.
2956
2957         Part of <rdar://problem/8233237> Fill WebKit2 Windows skipped list so
2958         there are zero tests failing
2959         https://bugs.webkit.org/show_bug.cgi?id=43374
2960
2961         Reviewed by Adam Roben.
2962
2963         * Scripts/old-run-webkit-tests:
2964         If using WebKitTestRunner and Apple Windows WebKit, set the platform to
2965         win-wk2. When building the result hierarchy, if the platform is win-wk2,
2966         add it first to the list of platforms.
2967
2968 2010-08-02  Darin Adler  <darin@apple.com>
2969
2970         Reviewed by Sam Weinig.
2971
2972         WebKitTestRunner needs layoutTestController.setCanOpenWindows
2973         https://bugs.webkit.org/show_bug.cgi?id=42321
2974
2975         WebKitTestRunner needs layoutTestController.setCloseRemainingWindowsWhenComplete
2976         https://bugs.webkit.org/show_bug.cgi?id=42779
2977
2978         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added
2979         setCanOpenWindows, setCloseRemainingWindowsWhenComplete, and windowCount
2980
2981         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2982         (WTR::InjectedBundle::InjectedBundle): Initialize m_mainPage to 0 instead of
2983         waiting for the first call to didCreatePage.
2984         (WTR::InjectedBundle::didCreatePage): Set m_mainPage only when the first page
2985         is created. Put other pages into a map.
2986         (WTR::InjectedBundle::willDestroyPage): Added code to handle the destruction
2987         of the main page.
2988         (WTR::InjectedBundle::closeOtherPages): Added. Closes all the pages other than
2989         the main page.
2990         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Added pageCount and
2991         closeOtherPages functions.
2992
2993         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2994         (WTR::InjectedBundlePage::didFinishLoadForFrame): Don't let pages other than
2995         the main page affect dumping.
2996         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): Ditto.
2997
2998         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2999         (WTR::LayoutTestController::LayoutTestController): Initialize the new
3000         m_shouldCloseExtraWindows member.
3001         (WTR::LayoutTestController::setCanOpenWindows): Added. Empty for now.
3002         (WTR::LayoutTestController::windowCount): Added.
3003
3004         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3005         Added setCanOpenWindows, setCloseRemainingWindowsWhenComplete,
3006         windowCount, shouldCloseExtraWindowsAfterRunningTest, and
3007         m_shouldCloseExtraWindows.
3008
3009         * WebKitTestRunner/TestController.cpp:
3010         (WTR::TestController::shared): Return a pointer to the shared copy, but
3011         don't allocate and leak it. This seemed cleaner than adding an explicit
3012         finalize call to go along with the explicit initialize call.
3013         (WTR::TestController::TestController): Added calls to the initialize and
3014         run function, which are now done automatically.
3015         (WTR::TestController::~TestController): Added, since it's called now.
3016         (WTR::closeOtherPage): Added. Used to close pages other than the main page.
3017         (WTR::createOtherPage): Added. Used to create pages other than the main page.
3018         (WTR::TestController::initialize): Added code to set up createOtherPage.
3019         (WTR::TestController::run): Removed unused return value.
3020         * WebKitTestRunner/TestController.h: Made constructor and destructor public,
3021         and initialize and run private. Changed m_mainWebView to be an OwnPtr.
3022
3023         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3024         (WTR::PlatformWebView::PlatformWebView): Added a call to setReleasedWhenClosed
3025         to avoid releasing the window twice. Another way to handle it would be to
3026         remove the release, but this approach is slightly more robust because it works
3027         even if some other code calls the close method an extra time.
3028
3029         * WebKitTestRunner/mac/main.mm:
3030         (main): Use a stack-allocated TestController object instead of calling
3031         initalize and run on a globally allocated one.
3032
3033 2010-08-02  Tony Chang  <tony@chromium.org>
3034
3035         Reviewed by David Levin.
3036
3037         add myself to the reviewers list
3038         https://bugs.webkit.org/show_bug.cgi?id=43366
3039
3040         * Scripts/webkitpy/common/config/committers.py:
3041
3042 2010-08-02  Anders Carlsson  <andersca@apple.com>
3043
3044         Reviewed by Sam Weinig.
3045
3046         Cache JSNPObjects and fix bugs in the object map
3047         https://bugs.webkit.org/show_bug.cgi?id=43368
3048
3049         Test that we correctly throw exceptions when trying to do things to a JSObject that used to
3050         wrap an NPObject that came from a plug-in that is now destroyed.
3051
3052         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3053         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3054         (PluginTest::Object::getProperty):
3055         (PluginTest::Object::NP_GetProperty):
3056         (PluginTest::Object::npClass):
3057         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp: Added.
3058         (NPRuntimeObjectFromDestroyedPlugin::NPRuntimeObjectFromDestroyedPlugin):
3059         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasProperty):
3060         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::getProperty):
3061         (NPRuntimeObjectFromDestroyedPlugin::NPP_GetValue):
3062         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3063         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3064         * GNUmakefile.am:
3065
3066 2010-08-02  Martin Robinson  <mrobinson@igalia.com>
3067
3068         Reviewed by Xan Lopez.
3069
3070         [Gtk] DOM listeners get wrong keycodes for some keys
3071         https://bugs.webkit.org/show_bug.cgi?id=35170
3072
3073         Add support to all event senders for simulating keypad insert
3074         and print screen keys.
3075
3076         * DumpRenderTree/chromium/EventSender.cpp:
3077         (EventSender::keyDown): Add support for generating keypad insert and print screen.
3078         * DumpRenderTree/gtk/EventSender.cpp:
3079         (keyDownCallback): Ditto.
3080         * DumpRenderTree/mac/EventSendingController.mm:
3081         (-[EventSendingController keyDown:withModifiers:withLocation:]): Ditto.
3082         * DumpRenderTree/qt/EventSenderQt.cpp:
3083         (EventSender::keyDown): Ditto.
3084         * DumpRenderTree/win/EventSender.cpp:
3085         (keyDownCallback): Ditto.
3086
3087 2010-08-02  Martin Robinson  <mrobinson@igalia.com>
3088
3089         Build fix for building against development versions of GTK+. GTK 2.22
3090         has not yet been released, so these function definitions must be conditionalized
3091         on the development version.
3092
3093         * DumpRenderTree/gtk/EventSender.cpp: Fix GTK+ 2.21 build.
3094
3095 2010-08-02  Tony Chang  <tony@chromium.org>
3096
3097         Reviewed by Kent Tamura.
3098
3099         [chromium] use ChromiumDriver on Linux when running webkit tests
3100         https://bugs.webkit.org/show_bug.cgi?id=43273
3101
3102         * Scripts/webkitpy/layout_tests/port/chromium.py:
3103
3104 2010-08-02  Kent Tamura  <tkent@chromium.org>
3105
3106         Reviewed by Dimitri Glazkov.
3107
3108         [DRT/Chromium] Always initialize GTK
3109         https://bugs.webkit.org/show_bug.cgi?id=43327
3110
3111         Call gtk_init() in order to fix plugin test crash.
3112
3113         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3114         (main): Pass argc/argv to platformInit().
3115         * DumpRenderTree/chromium/TestShell.h:
3116         * DumpRenderTree/chromium/TestShellGtk.cpp:
3117         (platformInit): Update parameters, call gtk_init().
3118         * DumpRenderTree/chromium/TestShellMac.mm:
3119         (platformInit): Update parameters.
3120         * DumpRenderTree/chromium/TestShellWin.cpp:
3121         (platformInit): Update parameters.
3122
3123 2010-08-02  Balazs Kelemen  <kb@inf.u-szeged.hu>
3124
3125         Reviewed by Simon Hausmann.
3126
3127         [Qt] Generate forwarding headers for WebKit2
3128
3129         https://bugs.webkit.org/show_bug.cgi?id=43336
3130
3131         * Scripts/webkitdirs.pm: Call make on WebKit2/Makefile.DerivedSources.
3132
3133 2010-08-02  Fumitoshi Ukai  <ukai@chromium.org>
3134
3135         Reviewed by Kent Tamura.
3136
3137         WebSocket server should start with SO_REUSEADDR
3138         https://bugs.webkit.org/show_bug.cgi?id=43329
3139
3140         Pulls in pywebsocket-0.5.2.
3141         pywebsocket-0.5.2 includes a small fix to start server with SO_REUSE_ADDR.
3142         http://code.google.com/p/pywebsocket/source/detail?r=273
3143
3144         * Scripts/webkitpy/thirdparty/__init__.py: Bump pywebsocket version
3145
3146 2010-08-01  Kent Tamura  <tkent@chromium.org>
3147
3148         Reviewed by Dimitri Glazkov.
3149
3150         [DRT/Chromium] Remove string_util.h dependency
3151         https://bugs.webkit.org/show_bug.cgi?id=43312
3152
3153         * DumpRenderTree/chromium/LayoutTestController.cpp:
3154         (LayoutTestController::pathToLocalResource):
3155          Use string::find() instead of StartsWithASCII().
3156         (LayoutTestController::cppVariantToInt32):
3157          Use strtol() instead of StringToNumber().
3158
3159 2010-08-01  Sam Weinig  <sam@webkit.org>
3160
3161         Reviewed by Anders Carlsson.
3162
3163         Add ability to reset frame names for WebKitTestRunner
3164         https://bugs.webkit.org/show_bug.cgi?id=43316
3165
3166         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3167         (WTR::InjectedBundle::reset):
3168         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3169         (WTR::InjectedBundlePage::reset):
3170         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3171
3172 2010-08-01  Anders Carlsson  <andersca@apple.com>
3173
3174         Reviewed by Sam Weinig.
3175
3176         Implement NPN_RemoveProperty
3177         https://bugs.webkit.org/show_bug.cgi?id=43315
3178
3179         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3180         Add NPRuntimeRemoveProperty.cpp
3181
3182         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3183         (PluginTest::NPN_GetStringIdentifier):
3184         (PluginTest::NPN_GetIntIdentifier):
3185         (PluginTest::NPN_RemoveProperty):
3186         Add NPN_ helpers.
3187
3188         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3189         Support more NPClass functions.
3190
3191         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp: Added.
3192         (NPRuntimeRemoveProperty::NPRuntimeRemoveProperty):
3193         Test for NPN_RemoveProperty.
3194
3195         (NPRuntimeRemoveProperty::TestObject::hasMethod):
3196         (NPRuntimeRemoveProperty::TestObject::invoke):
3197         Add a testRemoveProperty method.
3198
3199         (NPRuntimeRemoveProperty::NPP_GetValue):
3200         Return the test object.
3201
3202         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3203         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3204         * GNUmakefile.am:
3205         Add NPRuntimeRemoveProperty.cpp
3206
3207 2010-07-30  Anders Carlsson  <andersca@apple.com>
3208
3209         Reviewed by Sam Weinig.
3210
3211         Add an NPObject class template helper to TestNetscapePlugin
3212         https://bugs.webkit.org/show_bug.cgi?id=43288
3213
3214         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3215         Add some template magic to be able to figure out if a class has a member function of a given type.
3216
3217         (PluginTest::Object::create):
3218         Create an object.
3219
3220         (PluginTest::Object::invokeDefault):
3221         Add dummy function, this should never be called.
3222
3223         (PluginTest::Object::Object):
3224         Initialize m_pluginTest to 0.
3225
3226         (PluginTest::Object::~Object):
3227         Add virtual destructor.
3228
3229         (PluginTest::Object::NP_Allocate):
3230         Create a new object.
3231
3232         (PluginTest::Object::NP_Deallocate):
3233         Delete the object.
3234
3235         (PluginTest::Object::NP_InvokeDefault):
3236         Call invokeDefault.
3237
3238         (PluginTest::Object::npClass):
3239         Initialize the NPClass struct.
3240
3241         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
3242         (DocumentOpenInDestroyStream::NPP_DestroyStream):
3243         Move this inline.
3244
3245         * DumpRenderTree/TestNetscapePlugIn/Tests/PluginScriptableNPObjectInvokeDefault.cpp:
3246         (PluginScriptableNPObjectInvokeDefault::NPObjectWithInvokeDefault::invokeDefault):
3247         (PluginScriptableNPObjectInvokeDefault::NPP_GetValue):
3248         Use the PluginTest::Object class template.
3249
3250 2010-07-31  Sam Weinig  <sam@webkit.org>
3251
3252         Reviewed by Dan Bernstein.
3253
3254         Patch for https://bugs.webkit.org/show_bug.cgi?id=43305
3255         Add back WKBundleFrameCopyInnerText to fix ~50 test failures
3256         due to SVGElements not having the innerText function.
3257
3258         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3259         (WTR::dumpFrameText):
3260
3261 2010-07-30  Sam Weinig  <sam@webkit.org>
3262
3263         Reviewed by Maciej Stachowiak.
3264
3265         Patch for https://bugs.webkit.org/show_bug.cgi?id=43290
3266         Add structured message passing from the injected bundle to UIProcess
3267
3268         * MiniBrowser/mac/AppDelegate.m:
3269         (didRecieveMessageFromInjectedBundle):
3270         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3271         (didClearWindowForFrame):
3272         (didRecieveMessage):
3273         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3274         (WTR::InjectedBundle::done):
3275         (WTR::InjectedBundle::didReceiveMessage):
3276         * WebKitTestRunner/TestController.cpp:
3277         (WTR::TestController::initialize):
3278         (WTR::TestController::didReceiveMessageFromInjectedBundle):
3279         * WebKitTestRunner/TestController.h:
3280         * WebKitTestRunner/TestInvocation.cpp:
3281         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3282         * WebKitTestRunner/TestInvocation.h:
3283         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3284
3285 2010-07-30  Sam Weinig  <sam@webkit.org>
3286
3287         Reviewed by Anders Carlsson.
3288
3289         Patch for https://bugs.webkit.org/show_bug.cgi?id=43275
3290         Make WKArrayRef more usable.
3291
3292         Remove now unnecessary const_casts.
3293
3294         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3295         (WTR::dumpDescendantFrameScrollPositions):
3296         (WTR::dumpDescendantFramesText):
3297
3298 2010-07-30  Sam Weinig  <sam@webkit.org>
3299
3300         Reviewed by Anders Carlsson.
3301
3302         Patch for https://bugs.webkit.org/show_bug.cgi?id=43274
3303         Add first pass of structured message passing.
3304
3305         Update Minibrowser and WebKitTestRunner to work with the new post message
3306         function.
3307
3308         * MiniBrowser/mac/AppDelegate.m:
3309         (didRecieveMessageFromInjectedBundle):
3310         (-[BrowserAppDelegate init]):
3311         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
3312         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3313         (didStartProvisionalLoadForFrame):
3314         (didReceiveServerRedirectForProvisionalLoadForFrame):
3315         (didFailProvisionalLoadWithErrorForFrame):
3316         (didCommitLoadForFrame):
3317         (didFinishLoadForFrame):
3318         (didFailLoadWithErrorForFrame):
3319         (didReceiveTitleForFrame):
3320         (didClearWindowForFrame):
3321         (didCreatePage):
3322         (willDestroyPage):
3323         (didRecieveMessage):
3324         (WKBundleInitialize):
3325         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3326         (WTR::InjectedBundle::_didReceiveMessage):
3327         (WTR::InjectedBundle::didReceiveMessage):
3328         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3329         * WebKitTestRunner/TestInvocation.cpp:
3330         (WTR::TestInvocation::invoke):
3331         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3332
3333 2010-07-30  Anders Carlsson  <andersca@apple.com>
3334
3335         Try to fix the layout test failures.
3336
3337         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3338         (webkit_test_plugin_get_value):
3339
3340 2010-07-29  Anders Carlsson  <andersca@apple.com>
3341
3342         Reviewed by Adam Roben.
3343
3344         Replace plugins/npruntime/bindings-test.html with a more sophisticated test
3345         https://bugs.webkit.org/show_bug.cgi?id=43232
3346
3347         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3348         Add PluginScriptableNPObjectInvokeDefault.cpp.
3349
3350         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3351         Remove invokeDefault callback function.
3352
3353         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3354         (PluginTest::create):
3355         Move this to the top of the file.
3356
3357         (PluginTest::NPP_GetValue):
3358         Add default implementation.
3359
3360         (PluginTest::NPN_CreateObject):
3361         Add NPN_ wrapper.
3362
3363         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3364         (PluginTest::identifier):
3365         Add identifier getter.
3366
3367         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
3368         (DocumentOpenInDestroyStream::DocumentOpenInDestroyStream):
3369         Add "using namespace std".
3370
3371         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3372         (NPP_GetValue):
3373         Give PluginTest a chance to return a value.
3374
3375         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3376         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3377         * GNUmakefile.am:
3378         Add PluginScriptableNPObjectInvokeDefault.cpp.
3379
3380         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3381         (webkit_test_plugin_get_value):
3382         Give PluginTest a chance to return a value.
3383
3384 2010-07-30  Steve Block  <steveblock@google.com>
3385
3386         Reviewed by Steve Block.
3387
3388         Add LayoutTestController methods to test DeviceOrientation
3389         https://bugs.webkit.org/show_bug.cgi?id=39589
3390
3391         * DumpRenderTree/LayoutTestController.cpp:
3392         (setMockDeviceOrientationCallback):
3393         (LayoutTestController::staticFunctions):
3394         * DumpRenderTree/LayoutTestController.h:
3395         * DumpRenderTree/chromium/LayoutTestController.cpp:
3396         (LayoutTestController::LayoutTestController):
3397         (LayoutTestController::setMockDeviceOrientation):
3398         * DumpRenderTree/chromium/LayoutTestController.h:
3399         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3400         (LayoutTestController::setMockDeviceOrientation):
3401         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3402         (LayoutTestController::setMockDeviceOrientation):
3403         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3404         (LayoutTestController::setMockDeviceOrientation):
3405         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3406         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3407         (LayoutTestController::setMockDeviceOrientation):
3408         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3409         (LayoutTestController::setMockDeviceOrientation):
3410         * Scripts/build-webkit:
3411
3412 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
3413
3414         Reviewed by Kenneth Christiansen.
3415
3416         [Qt] QtTestBrowser: -resizes-to-contents command line parameter is broken
3417         https://bugs.webkit.org/show_bug.cgi?id=43209
3418
3419         When -resizes-to-content was being passed as a command line parameter it was simply
3420         not being set (although the corresponding menu item was marked as ON).
3421         User had to toggle the menu OFF and then ON again for it to take place.
3422
3423         Reason: LauncherWindow::applyPrefs method sets many user options passed in from
3424         the command line, but not resizesToContents. Patch addresses that.
3425
3426         * QtTestBrowser/launcherwindow.cpp:
3427         (LauncherWindow::createChrome):
3428         (LauncherWindow::applyPrefs):
3429         (LauncherWindow::toggleResizesToContents):
3430         * QtTestBrowser/webview.h:
3431         (WebViewGraphicsBased::resizesToContents):
3432
3433 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
3434
3435         Rubber-stamped by Simon Fraser.
3436
3437         [Qt] QtTestBrowser: more method grouping and clean ups.
3438
3439         Moving blocks of code around. Basically grouping related methods close to each.
3440
3441         * QtTestBrowser/launcherwindow.cpp:
3442         (LauncherWindow::initializeView):
3443         (LauncherWindow::createChrome):
3444         (LauncherWindow::changeViewportUpdateMode):
3445         (LauncherWindow::showFPS):
3446         (LauncherWindow::newWindow):
3447         (LauncherWindow::cloneWindow):
3448         * QtTestBrowser/launcherwindow.h:
3449
3450 2010-07-30  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
3451
3452         Reviewed by Tor Arne Vestbø.
3453
3454         [QT][Symbian] QtTestBrowser missing location capabilities
3455         https://bugs.webkit.org/show_bug.cgi?id=43235
3456
3457         QtTestBrowser missing capabilities to use QtMobility::QLocation.
3458
3459         * QtTestBrowser/QtTestBrowser.pro:
3460
3461 2010-07-29  Anders Carlsson  <andersca@apple.com>
3462
3463         Add PluginTest.cpp
3464
3465         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3466
3467 2010-07-29  Dirk Pranke  <dpranke@chromium.org>
3468
3469         Reviewed by Eric Seidel.
3470
3471         Update download URLs for python irclib package; the old URLs
3472         pointed at a specific mirror host and not the general sourceforge
3473         URLs.
3474
3475         https://bugs.webkit.org/show_bug.cgi?id=43228
3476
3477         * Scripts/webkitpy/thirdparty/__init__.py:
3478
3479 2010-07-29  Anders Carlsson  <andersca@apple.com>
3480
3481         Fix typo.
3482
3483         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3484
3485 2010-07-29  Anders Carlsson  <andersca@apple.com>
3486
3487         Another attempt at fixing the Qt and GTK+ build.
3488
3489         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3490         (webkit_test_plugin_new_instance):
3491         (webkit_test_plugin_destroy_stream):
3492
3493 2010-07-29  Anders Carlsson  <andersca@apple.com>
3494
3495         Another build fix attempt.
3496
3497         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3498         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3499         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3500         (webkit_test_plugin_new_instance):
3501         * GNUmakefile.am:
3502
3503 2010-07-29  Anders Carlsson  <andersca@apple.com>
3504
3505         Try to fix Windows and Unix builds.
3506
3507         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3508         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3509         (webkit_test_plugin_new_instance):
3510         (webkit_test_plugin_destroy_stream):
3511
3512 2010-07-29  Anders Carlsson  <andersca@apple.com>
3513
3514         Reviewed by Sam Weinig.
3515
3516         Refactor TestNetscapePlugin so tests can be split in separate files
3517         https://bugs.webkit.org/show_bug.cgi?id=43220
3518
3519         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3520         Add PluginTest.cpp, PluginTest.h and Tests/DocumentOpenInDestroyStream.cpp.
3521
3522         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3523         (pluginAllocate):
3524         Initialize pluginTest to 0. Remove testDocumentOpenInDestroyStream.
3525
3526         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
3527         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: Added.
3528         (PluginTest::PluginTest):
3529         Initialize m_npp and the test identifier.
3530
3531         (PluginTest::createTestFunctions):
3532         Return the map from identifiers to createTest functions.
3533
3534         (PluginTest::registerCreateTestFunction):
3535         Insert the identifier and create function pair in the map.
3536
3537         (PluginTest::create):
3538         Look for a createTest function. If one is found, call it. Otherwise create a vanilla PluginTest object.
3539
3540         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added.
3541         (PluginTest::Register::Register):
3542         Helper class template for registering plug-in tests.
3543
3544         (PluginTest::Register::create):
3545         Create a new test of the given type.
3546
3547         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp: Added.
3548         (DocumentOpenInDestroyStream::DocumentOpenInDestroyStream):
3549         Add a test that calls testDocumentOpen from its NPP_DestroyStream callback.
3550
3551         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3552         (NPP_New):
3553         Create a PluginTest given the identifier. Remove the check for "testdocumentopenindestroystream".
3554
3555         (NPP_DestroyStream):
3556         Call the plug-in test NPP_DestroyStream member function.
3557
3558         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3559         Add PluginTest.cpp, PluginTest.h and Tests/DocumentOpenInDestroyStream.cpp.
3560
3561 2010-07-29  Martin Robinson  <mrobinson@igalia.com>
3562
3563         Unreviewed build fix.
3564
3565         Add missing second argument to assert_lint in new style checker tests.
3566
3567         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3568
3569 2010-07-29  Anders Carlsson  <andersca@apple.com>
3570
3571         Reviewed by Adam Roben.
3572
3573         check-webkit-style shouldn't complain about NPAPI functions
3574         https://bugs.webkit.org/show_bug.cgi?id=43211
3575
3576         Allow underscores in functions that start with NPN_, NPP_ or NP_.
3577
3578         * Scripts/webkitpy/style/checkers/cpp.py:
3579         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3580
3581 2010-07-29  Victor Wang  <victorw@chromium.org>
3582
3583         Unreviewed, rolling out r64270.
3584         http://trac.webkit.org/changeset/64270
3585         https://bugs.webkit.org/show_bug.cgi?id=39589
3586
3587         The patch breaks chromium webkit unittest
3588
3589         * DumpRenderTree/LayoutTestController.cpp:
3590         (LayoutTestController::staticFunctions):
3591         * DumpRenderTree/LayoutTestController.h:
3592         * DumpRenderTree/chromium/LayoutTestController.cpp:
3593         (LayoutTestController::LayoutTestController):
3594         * DumpRenderTree/chromium/LayoutTestController.h:
3595         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3596         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3597         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3598         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3599         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3600         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3601         * Scripts/build-webkit:
3602
3603 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
3604
3605         Reviewed by Kenneth Christiansen.
3606
3607         [Qt] QtTestBrowser: Move WebPage class methods definitions from main.cpp to webpage.cpp
3608         https://bugs.webkit.org/show_bug.cgi?id=43199
3609
3610         There is no sense in keeping WebPage method definitions in main.cpp once
3611         webpage.cpp already exists.
3612
3613         No behavior change.
3614
3615         * QtTestBrowser/main.cpp:
3616         * QtTestBrowser/webpage.cpp:
3617         (WebPage::createWindow):
3618         (WebPage::createPlugin):
3619
3620 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
3621
3622         Reviewed by Kenneth Christiansen.
3623
3624         [Qt] Factor out LauncherWindow class out of main.cpp (QtTestBrowser)
3625         https://bugs.webkit.org/show_bug.cgi?id=43170
3626
3627         Moving LauncherWindow class out of main.cpp to its own .cpp and .h files:
3628         launcherwindow.{cpp|h}
3629
3630         No behavior change.
3631
3632         Also changed all global static variables (named "gXXX") from main.cpp to
3633         static public variables of the LauncherWindow class.
3634
3635         * QtTestBrowser/QtTestBrowser.pro:
3636         * QtTestBrowser/launcherwindow.cpp: Added.
3637         * QtTestBrowser/launcherwindow.h: Added.
3638         * QtTestBrowser/main.cpp:
3639         (LauncherApplication::handleUserOptions):
3640         (main):
3641
3642 2010-07-29  Martin Robinson  <mrobinson@igalia.com>
3643
3644         Reviewed by Xan Lopez.
3645
3646         Build fix for building against GTK+ 3.x. GSEAL requires that we
3647         access internals of the GdkDragContext via methods. For older versions
3648         of GTK+, define those methods.
3649
3650         * DumpRenderTree/gtk/EventSender.cpp:
3651         (gdk_drag_context_get_selected_action): Added.
3652         (gdk_drag_context_get_actions): Added.
3653         (dispatchEvent): Use the two new accessor methods.
3654
3655 2010-07-29  Adam Roben  <aroben@apple.com>
3656
3657         Always say "plugins directory" when referring to a directory
3658         containing one or more plugins
3659
3660         Fixes <http://webkit.org/b/43197> WebKit2 often says "plugin
3661         directory" when it means "plugins directory"
3662
3663         Reviewed by John Sullivan.
3664
3665         * WebKitTestRunner/TestController.cpp:
3666         (WTR::TestController::initialize): Updated for rename.
3667
3668 2010-07-29  Adam Roben  <aroben@apple.com>
3669
3670         Always say "directory" when referring to a plugin directory
3671
3672         Fixes <http://webkit.org/b/43195> WebKit2 often says "plugin path"
3673         when it means "plugin directory"
3674
3675         Reviewed by John Sullivan.
3676
3677         * WebKitTestRunner/TestController.cpp:
3678         (WTR::TestController::initialize): Updated for renames.
3679
3680         * WebKitTestRunner/TestController.h: Renamed m_testPluginPath to
3681         m_testPluginDirectory.
3682         (WTR::TestController::testPluginDirectory): Renamed from
3683         testPluginPath.
3684
3685         * WebKitTestRunner/mac/TestControllerMac.mm:
3686         (WTR::TestController::initializeTestPluginDirectory):
3687         * WebKitTestRunner/win/TestControllerWin.cpp:
3688         (WTR::TestController::initializeTestPluginDirectory):
3689         Renamed from initializeTestPluginPath and updated for rename.
3690
3691 2010-07-29  Csaba Osztrogonác  <ossy@webkit.org>
3692
3693          Reviewed by Antonio Gomes.
3694
3695          Initialize all members of NPClass struct.
3696          https://bugs.webkit.org/show_bug.cgi?id=43193
3697
3698          * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3699
3700 2010-07-29  Csaba Osztrogonác  <ossy@webkit.org>
3701
3702         Reviewed by Antonio Gomes.
3703
3704         Warning fix on platforms where XP_MACOSX is undefined.
3705         https://bugs.webkit.org/show_bug.cgi?id=43192
3706
3707         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
3708         Use #if defined(XP_MACOSX) instead of #if XP_MACOSX .
3709
3710 2010-07-29  Adam Roben  <aroben@apple.com>
3711
3712         Give find-included-framework-headers our standard license
3713
3714         * Scripts/find-included-framework-headers: Used the license from
3715         WebCore/LICENSE-APPLE.
3716
3717 2010-07-29  Adam Roben  <aroben@apple.com>
3718
3719         Speed up find-included-framework-headers
3720
3721         We only do one invocation of find now, no longer pipe to grep, and
3722         replace uniq with sort -u.
3723
3724         Also added a license header.
3725
3726         * Scripts/find-included-framework-headers:
3727
3728 2010-07-29  Steve Block  <steveblock@google.com>
3729
3730         Reviewed by Jeremy Orlow.
3731
3732         Add LayoutTestController methods to test DeviceOrientation
3733         https://bugs.webkit.org/show_bug.cgi?id=39589
3734
3735         * DumpRenderTree/LayoutTestController.cpp:
3736         (setMockDeviceOrientationCallback):
3737         (LayoutTestController::staticFunctions):
3738         * DumpRenderTree/LayoutTestController.h:
3739         * DumpRenderTree/chromium/LayoutTestController.cpp:
3740         * DumpRenderTree/chromium/LayoutTestController.h:
3741         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3742         (LayoutTestController::setMockDeviceOrientation):
3743         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3744         (LayoutTestController::setMockDeviceOrientation):
3745         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3746         (LayoutTestController::setMockDeviceOrientation):
3747         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3748         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3749         (LayoutTestController::setMockDeviceOrientation):
3750         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3751         (LayoutTestController::setMockDeviceOrientation):
3752         * Scripts/build-webkit:
3753
3754 2010-07-28  Kenichi Ishibashi  <bashi@google.com>
3755
3756         Reviewed by Shinichiro Hamaji.
3757
3758         Fixed <https://bugs.webkit.org/show_bug.cgi?id=33814>
3759         check-webkit-style gives false positives in single-line functions.
3760
3761         * Scripts/webkitpy/style/checkers/cpp.py:
3762         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3763
3764 2010-07-28  Darin Adler  <darin@apple.com>
3765
3766         Reviewed by Sam Weinig.
3767
3768         WebKitTestRunner needs to support layoutTestController.execCommand
3769         <https://bugs.webkit.org/show_bug.cgi?id=42538>
3770
3771         WebKitTestRunner needs layoutTestController.isCommandEnabled
3772         <https://bugs.webkit.org/show_bug.cgi?id=42671>
3773
3774         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3775         Added execCommand and isCommandEnabled.
3776         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3777         (WTR::LayoutTestController::execCommand): Added.
3778         (WTR::LayoutTestController::isCommandEnabled): Added.
3779         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
3780
3781 2010-07-28  Kent Tamura  <tkent@chromium.org>
3782
3783         Reviewed by Dimitri Glazkov.
3784
3785         [DRT/Chromium] Introduce drt_expectations.txt for NRWT
3786         https://bugs.webkit.org/show_bug.cgi?id=43123
3787
3788         Introduce LayoutTests/platform/chromium/drt_expectations.txt,
3789         which overrides test expectations only for DumpRenderTree, in
3790         order to manage what problems are investigated.
3791         This change will be reverted when we switch to DRT completely.
3792
3793         * Scripts/webkitpy/layout_tests/port/chromium.py:
3794          Add drt_expectations.txt content to the result of
3795          test_expectations_overrides() if --use-drt is specified.
3796
3797 2010-07-28  Brady Eidson  <beidson@apple.com>
3798
3799         Reviewed by Darin Adler.
3800
3801         First pass at visited link support for WK2
3802         https://bugs.webkit.org/show_bug.cgi?id=43157
3803
3804         * MiniBrowser/mac/AppDelegate.m:
3805         (didNavigateWithNavigationData):
3806         (didPerformClientRedirect):
3807         (didPerformServerRedirect):
3808         (didUpdateHistoryTitle):
3809         (populateVisitedLinks): Added for the new version of the HistoryClient.
3810         (-[BrowserAppDelegate init]): Set the HistoryClient right after creating the context(s)
3811
3812         * MiniBrowser/mac/BrowserWindowController.m:
3813         (-[BrowserWindowController awakeFromNib]):
3814
3815 2010-07-28  Robin Dunn  <robin@alldunn.com>
3816
3817         Reviewed by Kevin Ollivier.
3818
3819         Add DOM bindings support for wx port.
3820
3821         * DumpRenderTree/wscript:
3822         * wx/browser/wscript:
3823         * wx/build/settings.py:
3824
3825 2010-07-28  Tony Chang  <tony@chromium.org>
3826
3827         Reviewed by Kent Tamura.
3828
3829         [chromium] cleanup temp files left by Linux DRT
3830         https://bugs.webkit.org/show_bug.cgi?id=43062
3831
3832         * BuildSlaveSupport/build.webkit.org-config/config.json: Rename the chromium bots to include the OS
3833         * BuildSlaveSupport/build.webkit.org-config/master.cfg: add a step on chromium-linux to delete temp files left
3834             by crashed DRTs
3835
3836 2010-07-28  Antonio Gomes  <tonikitoo@webkit.org>
3837
3838         Rubber-stamped by Kenneth Christiansen.
3839
3840         More Developer menu items reordering.
3841
3842         Grouping related menu items together, visually and logically (in the code).
3843
3844         No behavior change.
3845
3846         * QtTestBrowser/main.cpp:
3847         (LauncherWindow::createChrome):
3848
3849 2010-07-27  Kinuko Yasuda  <kinuko@chromium.org>
3850
3851         Reviewed by Ojan Vafai.
3852
3853         Add FILE_SYSTEM build flag for FileSystem API
3854         https://bugs.webkit.org/show_bug.cgi?id=42915
3855
3856         * Scripts/build-webkit:
3857
3858 2010-07-27  Martin Robinson  <mrobinson@igalia.com>
3859
3860         Reviewed by David Levin.
3861
3862         Stylebot should not complain about NULL usage in calls to gdk_pixbuf_save_to
3863         https://bugs.webkit.org/show_bug.cgi?id=43090
3864
3865         * Scripts/webkitpy/style/checkers/cpp.py: Add exemption for some GdkPixbuf methods.
3866         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added some tests for this behavior.
3867
3868 2010-07-27  Kent Tamura  <tkent@chromium.org>
3869
3870         Unreviewed, trivial typo fix.
3871
3872         * Scripts/webkitpy/layout_tests/port/chromium.py:
3873           Fix a wrong method name committed by r64109.
3874
3875 2010-07-27  Sam Weinig  <sam@webkit.org>
3876
3877         Reviewed by Anders Carlsson.
3878
3879         Patch for https://bugs.webkit.org/show_bug.cgi?id=43087
3880         Clean up handling of strings at the WebKit2 API layer.
3881
3882         * MiniBrowser/mac/BrowserWindowController.m:
3883         (runJavaScriptAlert):
3884         (runJavaScriptConfirm):
3885         (runJavaScriptPrompt):
3886         (didNavigateWithNavigationData):
3887         (-[BrowserWindowController updateProvisionalURLForFrame:]):
3888         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3889         (_didClearWindowForFrame):
3890
3891 2010-07-27  Ojan Vafai  <ojan@chromium.org>
3892
3893         Reviewed by Eric Seidel.
3894
3895         webkit-patch post-commits is broken: AttributeError: Values instance has no attribute 'no_squash'
3896         https://bugs.webkit.org/show_bug.cgi?id=42984
3897
3898         squash and no_squash have been intentionally erroring for a couple weeks now.
3899         But post-commits was just broken. Just remove squash/no_squash.
3900
3901         * Scripts/webkitpy/tool/steps/abstractstep.py:
3902         * Scripts/webkitpy/tool/steps/options.py:
3903
3904 2010-07-27  Kevin Ollivier  <kevino@theolliviers.com>
3905
3906         [wx] Build fix after introduction of EXECUTABLE_ALLOCATOR_DEMAND.
3907
3908         * wx/build/settings.py:
3909
3910 2010-07-27  Adam Roben  <aroben@apple.com>
3911
3912         Mac build fix
3913
3914         * MiniBrowser/mac/BrowserWindowController.m:
3915         (processDidExit):
3916         (-[BrowserWindowController awakeFromNib]):
3917         Added processDidExit support.
3918
3919 2010-07-26  Antonio Gomes  <tonikitoo@webkit.org>
3920
3921         Rubber-stamped by Simon Hausmann.
3922
3923         [Qt] Reorder some items in Developers' menu so QGraphicsView one is easier accessible.
3924
3925         Move some less useful menu items on Developers menu from the top to the bottom, so
3926         QGraphicsView menu goes to the top, and becomes more quickly accessible.
3927
3928         * QtTestBrowser/main.cpp:
3929         (LauncherWindow::createChrome):
3930
3931 2010-07-26  Adam Roben  <aroben@apple.com>
3932
3933         Fix the path to InjectedBundle.dll in Debug_Internal builds
3934
3935         Fixes <http://webkit.org/b/42994> WebKitTestRunner fails to load
3936         InjectedBundle.dll in the Debug_Internal configuration
3937
3938         Reviewed by Anders Carlsson.
3939
3940         * WebKitTestRunner/win/TestControllerWin.cpp:
3941         (WTR::TestController::initializeInjectedBundlePath): Add the _debug
3942         suffix only in Debug_All builds.
3943
3944 2010-07-25  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
3945
3946         Reviewed by Darin Adler.
3947
3948         https://bugs.webkit.org/show_bug.cgi?id=42947
3949         Check for WEBKIT_TESTFONTS for qt, gtk and windows port and throw
3950         error. Without which dumpRenderTree crashes.
3951
3952         * Scripts/old-run-webkit-tests:
3953
3954 2010-07-27  Kent Tamura  <tkent@chromium.org>
3955
3956         Reviewed by Dimitri Glazkov.
3957
3958         https://bugs.webkit.org/show_bug.cgi?id=42956
3959         [DRT/Chromium] Fix "out of sync" assertion error
3960
3961         Fix an assertion error on Windows like the following:
3962         100721 20:16:46 chromium.py:386  CRITICAL Test got out of sync:
3963         |file:///c:/WebKitBuildSlave2/chromium-win-release-tests/build/LayoutTests/http/tests/local/blob/send-data-blob.html|
3964         |file:///C:/WebKitBuildSlave2/chromium-win-release-tests/build/LayoutTests/http/tests/local/blob/send-data-blob.html|
3965
3966         * Scripts/webkitpy/layout_tests/port/chromium.py:
3967         If the url matches with "file:///[a-z]:", does case-ignore comparison.
3968         GURL capitalize the driver letter of a file: URL.
3969
3970 2010-07-26  Darin Adler  <darin@apple.com>
3971
3972         Reviewed by Sam Weinig.
3973
3974         WebKitTestRunner needs to support layoutTestController.counterValueForElementById
3975         https://bugs.webkit.org/show_bug.cgi?id=42537
3976
3977         WebKitTestRunner needs layoutTestController.markerTextForListItem
3978         https://bugs.webkit.org/show_bug.cgi?id=42549
3979
3980         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3981         Fixed _paramterExpression typo. Improved support for string type as a
3982         return value, so we don't try to include DOMString.h and we can convert
3983         the string to a JSValue by calling JSValueMakeStringOrNull.
3984
3985         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
3986         Added JSValueMakeStringOrNull, used by the code generator.
3987
3988         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3989         Added counterValueForElementById and markerTextForListItem.
3990
3991         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3992         Moved constant to the top of the file.
3993         (WTR::toCF): Added. Converts strings to CFStringRef.
3994         (WTR::toWK): Added. Converts strings to WKStringRef.
3995         (WTR::toJS): Added. Converts strings to JSStringRef.
3996         (WTR::setProperty): Moved this function to the top of the file
3997         rather than having it down where it's used inside the class. Also
3998         renamed it so it's a separate function rather than an overload of
3999         JSObjectSetProperty.
4000         (WTR::propertyValue): Copied this here from InjectedBundlePage.cpp.
4001         Should move it somewhere we can share it.
4002         (WTR::propertyObject): Ditto.
4003         (WTR::getElementById): Added. Calls getElementById through the magic
4004         of JavaScript.
4005         (WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId):
4006         Chagned to use toWK instead of four local variables.
4007         (WTR::LayoutTestController::counterValueForElementById): Added.
4008         Calls WKBundleFrameCopyCounterValue.
4009         (WTR::LayoutTestController::markerTextForListItem): Added.
4010         Calls WKBundleFrameCopyMarkerText.
4011
4012         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
4013         Added counterValueForElementById and markerTextForListItem.
4014
4015 2010-07-26  Martin Robinson  <mrobinson@igalia.com>
4016
4017         Reviewed by Gustavo Noronha Silva.
4018
4019         [GTK] The EventSender should support simulating drop events
4020         https://bugs.webkit.org/show_bug.cgi?id=39844
4021
4022         Add initial dropping support to the GTK+ EventSender.
4023
4024         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4025         (createWebView): Listen for some new drag-and-drop signals.
4026         * DumpRenderTree/gtk/EventSender.cpp: Add currentDragSourceContext.
4027         (dispatchEvent):
4028         Detect situations where a drag is either starting or ending and massage
4029         GTK+ into sending the appropriate signals to the WebView.
4030         (replaySavedEvents): Remove comment.
4031         (makeEventSender): Clear the currentDragSourceContext when creating a new EventSender.
4032         (dragBeginCallback): Capture the new currentDragSourceContext when a drag begins.
4033         (dragEndCallback): Clear the currentDragSourceContext when a drag ends.
4034         (dragFailedCallback): Disable the GTK+ drag failed animation.
4035         * DumpRenderTree/gtk/EventSender.h: Add declarations for new signal callbacks.
4036
4037 2010-07-26  Daniel Bates  <dbates@rim.com>
4038
4039         Reviewed by Darin Adler.
4040
4041         svn-unapply warns of uninitialized variable when unapplying
4042         a patch that describes an svn move operation
4043         https://bugs.webkit.org/show_bug.cgi?id=42036
4044
4045         Fixes Perl uninitialized variable warnings when un-applying
4046         a patch that moves a file.
4047
4048         * Scripts/svn-unapply:
4049           - Modified patch() so that it initializes $patch to the empty
4050             string when we don't have svnConvertedText (such as when
4051             reversing a diff that represents a svn copy/move operation).
4052
4053 2010-07-26  Sam Weinig  <sam@webkit.org>
4054
4055         Reviewed by Anders Carlsson.
4056
4057         Move some non-APIish functions into private headers.
4058
4059         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4060         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
4061
4062 2010-07-26  Sam Weinig  <sam@webkit.org>
4063
4064         Reviewed by Anders Carlsson.
4065
4066         Fix for https://bugs.webkit.org/show_bug.cgi?id=42986
4067         Add prompt and confirm client functions to WebKit2
4068
4069         * MiniBrowser/mac/BrowserWindowController.m:
4070         (-[BrowserWindowController awakeFromNib]):
4071
4072 2010-07-26  Adam Roben  <aroben@apple.com>
4073
4074         Windows build fix
4075
4076         * MiniBrowser/MiniBrowser.vcproj:
4077         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
4078         Removed empty attributes so the values will be picked up from the
4079         vsprops files. (Also removed a couple of attributes that accidentally
4080         duplicated values from the vsprops files.)
4081
4082 2010-07-26  Brian Weinstein  <bweinstein@apple.com>
4083
4084         Rubber-stamped by Adam Roben.
4085
4086         Touch MiniBrowser's stdafx to fix the build.
4087
4088         * MiniBrowser/win/stdafx.h:
4089
4090 2010-07-26  Hayato Ito  <hayato@chromium.org>
4091
4092         Reviewed by Shinichiro Hamaji.
4093
4094         Add pretty printer of WTF::Vector for GDB 7.
4095
4096         https://bugs.webkit.org/show_bug.cgi?id=40909
4097
4098         * gdb/wtf.py: Added.
4099
4100 2010-07-26  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4101
4102         Reviewed by Simon Hausmann.
4103
4104         [Qt] Fix feature detection regexp
4105
4106         We were missing the last feature
4107
4108         * Scripts/webkitdirs.pm:
4109
4110 2010-07-25  Darin Adler  <darin@apple.com>
4111
4112         Reviewed by Dan Bernstein.
4113
4114         WebKitTestRunner needs to support layoutTestController.dumpSelectionRect
4115         https://bugs.webkit.org/show_bug.cgi?id=42326
4116
4117         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
4118         Added dumpSelectionRect.
4119
4120         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
4121         (WTR::LayoutTestController::dumpSelectionRect): Added. For now, this
4122         does nothing because its purpose is to change pixel test output and
4123         we do not have pixel tests implemented yet.
4124
4125 2010-07-25  Darin Adler  <darin@apple.com>
4126
4127         Reviewed by Maciej Stachowiak.
4128
4129         WebKitTestRunner needs to support layoutTestController.keepWebHistory
4130         https://bugs.webkit.org/show_bug.cgi?id=42323
4131
4132         Added keepWebHistory and computedStyleIncludingVisitedInfo.
4133
4134         Also fixed misspellings of the word "receive".
4135
4136         Also tweaked the names of some of the LayoutTestController members.
4137
4138         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
4139         Added support for a type named "object" that is passed and returns as
4140         a JSValueRef.
4141
4142         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
4143         Added keepWebHistory and computedStyleIncludingVisitedInfo. Also
4144         put setAcceptsEditing up nearer the top.
4145
4146         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4147         (WTR::InjectedBundle::_didReceiveMessage): Fixed mispellings of receive.
4148         (WTR::InjectedBundle::initialize): Ditto.
4149         (WTR::InjectedBundle::didReceiveMessage): Ditto.
4150         (WTR::InjectedBundle::reset): Reset the state of visited links between
4151         tests. Also eliminated the unused argument to the LayoutTestController
4152         create function.
4153         (WTR::InjectedBundle::setShouldTrackVisitedLinks): Added.
4154         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Ditto.
4155
4156         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4157         (WTR::InjectedBundlePage::shouldBeginEditing): Call shouldAllowEditing
4158         instead of acceptsEditing.
4159         (WTR::InjectedBundlePage::shouldEndEditing): Ditto.
4160         (WTR::InjectedBundlePage::shouldInsertNode): Ditto.
4161         (WTR::InjectedBundlePage::shouldInsertText): Ditto.
4162         (WTR::InjectedBundlePage::shouldDeleteRange): Ditto.
4163         (WTR::InjectedBundlePage::shouldChangeSelectedRange): Ditto.
4164         (WTR::InjectedBundlePage::shouldApplyStyle): Ditto.
4165
4166         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
4167         (WTR::LayoutTestController::create): Removed uneeded argument.
4168         (WTR::LayoutTestController::LayoutTestController): Removed unneeded
4169         argument. Updated for rename of m_acceptsEditing to m_shouldAllowEditing.
4170         (WTR::LayoutTestController::numberOfActiveAnimations): Added some FIXMEs
4171         about the fact that this works on the main frame.
4172         (WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId): Ditto.
4173         (WTR::LayoutTestController::keepWebHistory): Added.
4174         (WTR::LayoutTestController::computedStyleIncludingVisitedInfo): Added.
4175         (WTR::JSObjectSetProperty): Added. Helper to make the function below
4176         cleaner.
4177         (WTR::LayoutTestController::makeWindowObject): Changed to use the
4178         overload of JSObjectSetProperty above.
4179
4180         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Changes to
4181         match above.
4182
4183         * WebKitTestRunner/TestController.cpp:
4184         (WTR::TestController::initialize): Fixed mispellings of receive.
4185         (WTR::TestController::_didReceiveMessageFromInjectedBundle): Ditto.
4186         (WTR::TestController::didReceiveMessageFromInjectedBundle): Ditto.
4187         * WebKitTestRunner/TestController.h: Ditto.
4188         * WebKitTestRunner/TestInvocation.cpp:
4189         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Ditto.
4190         * WebKitTestRunner/TestInvocation.h: Ditto.
4191
4192 2010-07-25  Alexey Proskuryakov  <ap@apple.com>
4193
4194         Reviewed by Sam Weinig.
4195
4196         https://bugs.webkit.org/show_bug.cgi?id=42193
4197         Support layoutTestController.dumpEditingDelegates in WebKitTestRunner
4198
4199         Step 2 - add the rest of editing delegates.
4200
4201         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4202         (WTR::operator<<): Fixed to not crash when range is null.
4203         (WTR::InjectedBundlePage::InjectedBundlePage):
4204         (WTR::InjectedBundlePage::_shouldEndEditing):
4205         (WTR::InjectedBundlePage::_shouldInsertNode):
4206         (WTR::InjectedBundlePage::_shouldInsertText):
4207         (WTR::InjectedBundlePage::_shouldDeleteRange):
4208         (WTR::InjectedBundlePage::_shouldChangeSelectedRange):
4209         (WTR::InjectedBundlePage::_shouldApplyStyle):
4210         (WTR::InjectedBundlePage::_didBeginEditing):
4211         (WTR::InjectedBundlePage::_didEndEditing):
4212         (WTR::InjectedBundlePage::_didChange):
4213         (WTR::InjectedBundlePage::_didChangeSelection):
4214         (WTR::InjectedBundlePage::shouldEndEditing):
4215         (WTR::InjectedBundlePage::shouldInsertNode):
4216         (WTR::InjectedBundlePage::shouldInsertText):
4217         (WTR::InjectedBundlePage::shouldDeleteRange):
4218         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
4219         (WTR::InjectedBundlePage::shouldApplyStyle):
4220         (WTR::InjectedBundlePage::didBeginEditing):
4221         (WTR::InjectedBundlePage::didEndEditing):
4222         (WTR::InjectedBundlePage::didChange):
4223         (WTR::InjectedBundlePage::didChangeSelection):
4224   &nbs