2010-12-10 Joone Hur <joone@kldp.org>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-12-10  Joone Hur  <joone@kldp.org>
2
3         Reviewed by Eric Seidel.
4
5         [GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet
6         https://bugs.webkit.org/show_bug.cgi?id=50783
7
8         This patch allows to unskip the following test cases:
9         printing/page-rule-selection.html
10         printing/page-format-data.html
11
12         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
13         (LayoutTestController::pageProperty): Added.
14         (LayoutTestController::isPageBoxVisible): Ditto.
15         (LayoutTestController::pageSizeAndMarginsInPixels): Ditto.
16         (LayoutTestController::addUserStyleSheet): Ditto.
17
18 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
19
20         Reviewed by Kenneth Rohde Christiansen.
21
22         [Qt] Make QtTestBrowser spawn QNAM in a secondary thread.
23
24         A menu allows to switch QNAM back to the same thread.
25
26         * QtTestBrowser/launcherwindow.cpp:
27         (LauncherWindow::initializeView):
28         (LauncherWindow::createChrome):
29         (LauncherWindow::toggleThreadedQnam):
30         * QtTestBrowser/launcherwindow.h:
31         (WindowOptions::WindowOptions):
32         * QtTestBrowser/webpage.cpp:
33         (WebPage::WebPage):
34         (WebPage::setQnamThreaded):
35         * QtTestBrowser/webpage.h:
36         (QnamThread::QnamThread):
37         (QnamThread::~QnamThread):
38         (QnamThread::networkAccessManager):
39         (QnamThread::run):
40
41 2010-12-10  Martin Robinson  <mrobinson@igalia.com>
42
43         Reviewed by Xan Lopez.
44
45         [Gtk] style="font-family: courier" makes text disappear
46         https://bugs.webkit.org/show_bug.cgi?id=47452
47
48         Add a test that verifies that fonts without valid charmaps are
49         never selected.
50
51         * DumpRenderTree/gtk/DumpRenderTree.cpp:
52         (initializeFonts): Initialize DRT with our font (derived from Ahem)
53         that has no valid charmap.
54         * DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon: Added.
55         * DumpRenderTree/gtk/fonts/fonts.conf: Updated settings to override users'
56         settings which may disable selection of bitmap fonts.
57
58 2010-12-10  Eric Seidel  <eric@webkit.org>
59
60         Unreviewed.
61
62         The commit-queue should file bugs about flaky tests it encounters
63         https://bugs.webkit.org/show_bug.cgi?id=50803
64
65         create_bug_for_flaky_test was insufficiently tested, thus buggy.
66         Now it's tested.
67
68         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
69         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
70
71 2010-12-10  Eric Seidel  <eric@webkit.org>
72
73         Unreviewed.  Somehow this last-minute edit didn't quite get committed.
74
75         The commit-queue should file bugs about flaky tests it encounters
76         https://bugs.webkit.org/show_bug.cgi?id=50803
77
78         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
79
80 2010-12-09  Eric Seidel  <eric@webkit.org>
81
82         Reviewed by Adam Barth.
83
84         The commit-queue should file bugs about flaky tests it encounters
85         https://bugs.webkit.org/show_bug.cgi?id=50803
86
87         This change got a bit big.  I also added a new config.urls file
88         because I needed to share the view_source_url code with committervalidator.py.
89
90         This adds a new class FlakyTestReporter which holds all the logic about
91         reporting flaky tests to bugzilla.
92
93         Right now this code knows how to look up bugs for flaky tests.
94         If it can't find a bug filed from the commit-queue, it will open a new
95         one, ccing the relevant people and adding information about the failure.
96
97         It is not yet smart enough to chase down duplicate chains, or to include
98         the actual failure diff.  But those can be added in later iterations.
99
100         * Scripts/webkitpy/common/checkout/api.py:
101         * Scripts/webkitpy/common/checkout/changelog.py:
102         * Scripts/webkitpy/common/checkout/commitinfo.py:
103         * Scripts/webkitpy/common/config/committervalidator.py:
104         * Scripts/webkitpy/common/config/urls.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
105         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
106         * Scripts/webkitpy/tool/bot/flakytestreporter.py: Added.
107         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
108         * Scripts/webkitpy/tool/bot/irc_command.py:
109         * Scripts/webkitpy/tool/bot/sheriff.py:
110         * Scripts/webkitpy/tool/commands/download.py:
111         * Scripts/webkitpy/tool/commands/queues.py:
112         * Scripts/webkitpy/tool/commands/queues_unittest.py:
113         * Scripts/webkitpy/tool/comments.py:
114         * Scripts/webkitpy/tool/mocktool.py:
115         * Scripts/webkitpy/tool/steps/commit.py:
116
117 2010-12-09  Eric Seidel  <eric@webkit.org>
118
119         Reviewed by Adam Barth.
120
121         Teach webkit-patch how to search bugzilla
122         https://bugs.webkit.org/show_bug.cgi?id=50500
123
124         This is a step towards teaching webkitpy how to file
125         new bugs for flaky tests and update them when new flakes occur.
126
127         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
128         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
129         * Scripts/webkitpy/tool/commands/__init__.py:
130         * Scripts/webkitpy/tool/commands/bugsearch.py: Added.
131
132 2010-12-09  Adam Barth  <abarth@webkit.org>
133
134         Reviewed by Ojan Vafai.
135
136         commit-queue errors out due to local commits
137         https://bugs.webkit.org/show_bug.cgi?id=50766
138
139         We seem to be tripping over having local commits in the working copy a
140         lot recently.  I don't quite fully understand what the issue is, but
141         this patch attempts to solve the problem by adding an explicit clean
142         step before processing a patch.  Previously, we did the cleaning as
143         part of the apply-attachment step, so this might not actually fix the
144         problem.
145
146         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
147         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
148         * Scripts/webkitpy/tool/commands/queues_unittest.py:
149
150 2010-12-09  Dirk Pranke  <dpranke@chromium.org>
151
152         Reviewed by Ojan Vafai.
153
154         Make new-run-webkit-tests --lint-test-files log slightly better
155         messages and return -1 if lint fails. Remove the
156         'suppress_errors' keyword param to the TestExpectationsFile
157         class, and clean up logging and exception raising for error
158         handling. Also add more unit tests and clean up the unit test code a bit.
159
160         https://bugs.webkit.org/show_bug.cgi?id=50205
161
162         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
163         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
164         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py
165         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py
166         * Scripts/webkitpy/layout_tests/port/chromium.py:
167         * Scripts/webkitpy/style/checkers/test_expectations.py:
168         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
169
170 2010-12-09  Tony Chang  <tony@chromium.org>
171
172         Unreviewed, fix for windows code.  We were catching the wrong
173         exception in Windows.
174
175         * Scripts/webkitpy/common/system/filesystem.py:
176
177 2010-12-09  Antonio Gomes  <agomes@rim.com>
178
179         Reviewed by Martin Robinson.
180
181         [Gtk] Populate DumpRenderTreeSupportGtk (part IV)
182         https://bugs.webkit.org/show_bug.cgi?id=48429
183
184         Adjust call sites of webkit_thread_count to use the DumpRenderTreeSupportGtk version now.
185
186         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
187         (LayoutTestController::workerThreadCount):
188
189 2010-12-06  Philippe Normand  <pnormand@igalia.com>
190
191         Reviewed by Martin Robinson.
192
193         [GTK] Support the Mozilla-style Fullscreen Javascript API
194         https://bugs.webkit.org/show_bug.cgi?id=50572
195
196         Enable the Javascript Fullscreen support in the GtkLauncher. Also
197         make DRT update the Chrome when the WebView settings have been
198         reset to consistent values.
199
200         * DumpRenderTree/gtk/DumpRenderTree.cpp:
201         (resetDefaultsToConsistentValues):
202         * GtkLauncher/main.c:
203         (create_window):
204         * Scripts/build-webkit:
205
206 2010-12-09  Koan-Sin Tan  <koansin.tan@gmail.com>
207
208         Reviewed by Tor Arne Vestbø
209
210         [Qt] run-launcher doesn't start the browser on Mac OS X 10.6
211         https://bugs.webkit.org/show_bug.cgi?id=50742
212
213         check not only QtWebKit.framework/QtWebKit but also libQtWebKit.dylib
214
215         * Scripts/webkitdirs.pm:
216
217 2010-12-09  Joone Hur  <joone@kldp.org>
218
219          Reviewed by Martin Robinson.
220
221          [GTK] Support for viewport meta tag
222          https://bugs.webkit.org/show_bug.cgi?id=45443
223
224          Add support for testing the viewport properties for WebKitGtk.
225
226          * DumpRenderTree/LayoutTestController.cpp:
227          (dumpConfigurationForViewportCallback): Added this JS callback to set the size of the visible viewport.
228          (LayoutTestController::staticFunctions):
229          * DumpRenderTree/LayoutTestController.h:
230          * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
231          (LayoutTestController::dumpConfigurationForViewport): Added this function to test the viewport properties.
232          * DumpRenderTree/mac/LayoutTestControllerMac.mm:
233          (LayoutTestController::dumpConfigurationForViewport): Ditto.
234          * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
235          (LayoutTestController::dumpConfigurationForViewport): Ditto.
236          * DumpRenderTree/win/LayoutTestControllerWin.cpp:
237          (LayoutTestController::dumpConfigurationForViewport): Ditto.
238          * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
239          (LayoutTestController::dumpConfigurationForViewport): Ditto.
240
241 2010-12-08  William Siegrist <wsiegrist@apple.com>
242
243         Reviewed by Eric Seidel.
244
245         Migrate buildbot.py from xmlrpc to json.
246         https://bugs.webkit.org/show_bug.cgi?id=50647
247
248         * Scripts/webkitpy/common/net/buildbot.py:
249
250 2010-12-08  Tony Chang  <tony@chromium.org>
251
252         Reviewed by Eric Seidel.
253
254         make starting the websocket server more reliable on windows
255         https://bugs.webkit.org/show_bug.cgi?id=50712
256
257         * Scripts/webkitpy/common/system/filesystem.py:
258         (remove): Substitute method for os.remove to retry on error on Windows
259         * Scripts/webkitpy/common/system/filesystem_unittest.py:
260         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Use FileSystem.remove
261
262 2010-12-08  Jessie Berlin  <jberlin@apple.com>
263
264         Reviewed by Adam Roben.
265
266         WebKit2: Implement WebChromeClient::exceededDatabaseQuota
267         https://bugs.webkit.org/show_bug.cgi?id=50656
268
269         * MiniBrowser/mac/BrowserWindowController.m:
270         (-[BrowserWindowController awakeFromNib]):
271         Indicate that exceededDatabaseQuota is not implemented.
272         * MiniBrowser/win/BrowserView.cpp:
273         (BrowserView::create):
274         Ditto.
275         * WebKitTestRunner/TestController.cpp:
276         (WTR::createOtherPage):
277         Ditto.
278         (WTR::TestController::initialize):
279         Ditto.
280
281 2010-12-08  Antonio Gomes  <agomes@rim.com>
282
283         Reviewed by Martin Robinson.
284
285         [Gtk] Populate DumpRenderTreeSupportGtk (part III)
286         https://bugs.webkit.org/show_bug.cgi?id=48429
287
288         Moved the following methods from webkitprivate.h to DumpRenderTreeSupportGtk.cpp|h:
289         * webkit_gc_collect_javascript_objects;
290         * webkit_gc_collect_javascript_objects_on_alternate_thread;
291         * webkit_gc_count_javascript_objects;
292         * webkit_web_frame_layout.
293
294         These were all only used by GTK+ DRT.
295
296         * DumpRenderTree/gtk/EventSender.cpp:
297         (dispatchEvent):
298         * DumpRenderTree/gtk/GCControllerGtk.cpp:
299         (GCController::collect):
300         (GCController::collectOnAlternateThread):
301         (GCController::getJSObjectCount):
302
303 2010-12-07  Tony Chang  <tony@chromium.org>
304
305         Reviewed by Ojan Vafai.
306
307         [chromium] force NRWT to use DRT
308         https://bugs.webkit.org/show_bug.cgi?id=50359
309
310         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
311
312 2010-12-06  Sam Weinig  <sam@webkit.org>
313
314         Reviewed by Anders Carlsson.
315
316         Generalize didChangeLocationWithinPageForFrame for all same document navigations
317         https://bugs.webkit.org/show_bug.cgi?id=50584
318
319         * MiniBrowser/mac/BrowserWindowController.m:
320         (didSameDocumentNavigationForFrame):
321         (-[BrowserWindowController awakeFromNib]):
322         (-[BrowserWindowController didSameDocumentNavigationForFrame:]):
323         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
324         (TestWebKitAPI::didSameDocumentNavigationForFrame):
325         (TestWebKitAPI::TEST):
326         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
327         (WTR::InjectedBundlePage::InjectedBundlePage):
328         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame):
329         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
330         * WebKitTestRunner/TestController.cpp:
331         (WTR::TestController::initialize):
332
333 2010-12-06  Kinuko Yasuda  <kinuko@chromium.org>
334
335         Reviewed by Ojan Vafai.
336
337         Make TestResultsServer return 404 for non-existing results files.
338         https://bugs.webkit.org/show_bug.cgi?id=50581
339
340         * TestResultServer/handlers/testfilehandler.py:
341
342 2010-12-06  Tony Chang  <tony@chromium.org>
343
344         Reviewed by Ojan Vafai.
345
346         [chromium] fix an assert hit in DRT
347         https://bugs.webkit.org/show_bug.cgi?id=50575
348
349         This class uses WTF's RefPtr, but expects chrome's base::RefPtr
350         semantics.
351
352         Otherwise, we hit ASSERTION FAILED: !m_adoptionIsRequired
353         (third_party/WebKit/JavaScriptCore/wtf/RefCounted.h:37 void
354         WTF::RefCountedBase::ref()).
355
356         * DumpRenderTree/chromium/TestWebWorker.h:
357         (TestWebWorker::TestWebWorker):
358
359 2010-12-02  Ojan Vafai  <ojan@chromium.org>
360
361         Reviewed by Eric Seidel.
362
363         make webkit-patch command work when the git branch is not synced to the remote svn branch
364         https://bugs.webkit.org/show_bug.cgi?id=50424
365
366         * Scripts/webkitpy/common/checkout/scm.py:
367         * Scripts/webkitpy/common/checkout/scm_unittest.py:
368
369 2010-12-06  Patrick Gansterer  <paroga@webkit.org>
370
371         Reviewed by Andreas Kling.
372
373         [WINCE] Add build system
374         https://bugs.webkit.org/show_bug.cgi?id=50522
375
376         * CMakeListsWinCE.txt: Added.
377
378 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
379
380         Reviewed by Tony Chang.
381
382         Allow the Chromium port to have Leopard-specific baselines
383         https://bugs.webkit.org/show_bug.cgi?id=50506
384
385         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
386
387 2010-12-03  Tony Chang  <tony@chromium.org>
388
389         Reviewed by Kent Tamura.
390
391         [chromium] fix 2 bugs with inspector tests in DRT
392         https://bugs.webkit.org/show_bug.cgi?id=50492
393
394         Tasks can outlive the tasklist (even when canceled) so this was
395         causing a crash when ~WebTask() ran.  Avoid this by unregistering
396         when a task is canceled.
397
398         Also fix an assert when closing devtool windows by copying some
399         logic from test_shell.
400
401         * DumpRenderTree/chromium/Task.cpp:
402         (WebTask::~WebTask):
403         (TaskList::revokeAll):
404         * DumpRenderTree/chromium/Task.h: Canceling a task now removes it from
405             the tasklist (since the task can outlive the tasklist).
406         * DumpRenderTree/chromium/TestShell.h:
407         (TestShell::devToolsWebView):
408         * DumpRenderTree/chromium/WebViewHost.cpp:
409         (WebViewHost::~WebViewHost): Don't load about:blank when closing
410             a window if the window has devtools loaded.  This avoids an
411             ASSERT and matches test_shell.
412
413 2010-12-06  Alejandro G. Castro  <alex@igalia.com>
414
415         Reviewed by Martin Robinson.
416
417         [GTK] Fix GtkLauncher.c style, use webkit style
418         https://bugs.webkit.org/show_bug.cgi?id=50542
419
420         * GtkLauncher/main.c:
421         (activateUriEntryCb):
422         (updateTitle):
423         (linkHoverCb):
424         (notifyTitleCb):
425         (notifyLoadStatusCb):
426         (notifyProgressCb):
427         (destroyCb):
428         (goBackCb):
429         (goForwardCb):
430         (create_webViewCb):
431         (webViewReadyCb):
432         (closeWebViewCb):
433         (createBrowser):
434         (createStatusbar):
435         (createToolbar):
436         (createWindow):
437         (main):
438
439 2010-12-04  Antonio Gomes  <agomes@rim.com>
440
441         Reviewed by Martin Robinson.
442
443         [Gtk] Populate DumpRenderTreeSupportGtk (Part II)
444         https://bugs.webkit.org/show_bug.cgi?id=48429
445
446         Moved more private method declared with WEBKIT_API to
447         DumpRenderTreeSupportGtk, since they were only being used by DRT.
448
449         * DumpRenderTree/gtk/DumpRenderTree.cpp:
450         (resetDefaultsToConsistentValues):
451         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
452         (LayoutTestController::addOriginAccessWhitelistEntry):
453         (LayoutTestController::execCommand):
454         (LayoutTestController::isCommandEnabled):
455
456 2010-12-04  Antonio Gomes  <agomes@rim.com>
457
458         Reviewed by Andreas Kling.
459
460         Removed extern webkit_web_view_set_group_name from gtk/DumpRenderTree.cpp
461
462         Method was removed by http://trac.webkit.org/changeset/71604
463
464         * DumpRenderTree/gtk/DumpRenderTree.cpp:
465
466 2010-12-05  Alejandro G. Castro  <alex@igalia.com>
467
468         Reviewed by Xan Lopez.
469
470         [GTK] Fix compilation warnings reported by clang
471         https://bugs.webkit.org/show_bug.cgi?id=50252
472
473         * GtkLauncher/main.c:
474         (create_window): The create_statusbar function does not have
475         parameters.
476
477 2010-12-05  Robert Hogan  <robert@webkit.org>
478
479         Reviewed by Andreas Kling.
480
481         [Qt] Zero-sized font does not yet work
482
483         Fix fast/text/font-size-zero.html
484
485         Copy other ports by setting minimumFontSize to 0 for DRT runs.
486
487         https://bugs.webkit.org/show_bug.cgi?id=49759
488
489         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
490         (WebCore::WebPage::WebPage):
491
492 2010-12-04  Sam Weinig  <sam@webkit.org>
493
494         Reviewed by Jon Honeycutt.
495
496         WebKit2: Need client functions to notify app when the url changes due to a fragment navigation
497         https://bugs.webkit.org/show_bug.cgi?id=50511
498
499         Update tools for new didChangeLocationWithinPageForFrame client function (and changed bundle
500         signature) and added a test for the functionality (PageLoadDidChangeLocationWithinPageForFrame.cpp)
501
502         * MiniBrowser/mac/BrowserWindowController.m:
503         (didChangeLocationWithinPageForFrame):
504         (-[BrowserWindowController awakeFromNib]):
505         (-[BrowserWindowController didChangeLocationWithinPageForFrame:]):
506         * TestWebKitAPI/PlatformUtilities.cpp:
507         (TestWebKitAPI::Util::toWK):
508         * TestWebKitAPI/PlatformUtilities.h:
509         (TestWebKitAPI::Util::adoptWK):
510         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
511         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp: Added.
512         (TestWebKitAPI::nullJavaScriptCallback):
513         (TestWebKitAPI::didFinishLoadForFrame):
514         (TestWebKitAPI::didChangeLocationWithinPageForFrame):
515         (TestWebKitAPI::TEST):
516         * TestWebKitAPI/Tests/WebKit2/file-with-anchor.html: Added.
517         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
518         * TestWebKitAPI/win/copy-resources.cmd:
519         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
520         (WTR::InjectedBundlePage::InjectedBundlePage):
521         (WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
522         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
523         * WebKitTestRunner/TestController.cpp:
524         (WTR::TestController::initialize):
525
526 2010-11-08  Antonio Gomes  <agomes@rim.com>
527
528         Reviewed by Martin Robinson.
529
530         [Gtk] Populate DumpRenderTreeSupportGtk
531         https://bugs.webkit.org/show_bug.cgi?id=48429
532
533         Made the previous calls to webkit_web_frame* functions defined as private
534         APIs in webkitprivate.h go through DRTSupportGtk.
535
536         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
537         (AccessibilityController::focusedElement):
538         * DumpRenderTree/gtk/DumpRenderTree.cpp:
539         (dumpFramesAsText):
540         (resetDefaultsToConsistentValues):
541         (dump):
542         (webViewDocumentLoadFinished):
543         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
544         (LayoutTestController::counterValueForElementById):
545         (LayoutTestController::pageNumberForElementById):
546         (LayoutTestController::numberOfPages):
547         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
548         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
549         (LayoutTestController::sampleSVGAnimationForElementAtTime):
550         (LayoutTestController::numberOfActiveAnimations):
551         (LayoutTestController::suspendAnimations):
552         (LayoutTestController::resumeAnimations):
553         (LayoutTestController::markerTextForListItem):
554
555 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
556
557         Reviewed by Tony Chang.
558
559         Rebaseline server: use pretty text diff output
560         https://bugs.webkit.org/show_bug.cgi?id=50484
561         
562         Serve *-pretty-diff.html for text diff output.
563
564         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
565         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
566         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
567         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
568
569 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
570
571         Unreviewed, rolling out r73302.
572         http://trac.webkit.org/changeset/73302
573         https://bugs.webkit.org/show_bug.cgi?id=50499
574
575         Causes crashes in debug LayoutTests (Requested by xan_ on
576         #webkit).
577
578         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
579         (AccessibilityUIElement::AccessibilityUIElement):
580         (AccessibilityUIElement::parentElementCallback):
581         * DumpRenderTree/chromium/AccessibilityUIElement.h:
582         * DumpRenderTree/chromium/CppBoundClass.cpp:
583         * DumpRenderTree/chromium/CppBoundClass.h:
584
585 2010-12-03  Sam Weinig  <sam@webkit.org>
586
587         Reviewed by Maciej Stachowiak.
588
589         Enable <a ping> for Mac/Windows/WebKit2 builds
590         <rdar://problem/8504473>
591         https://bugs.webkit.org/show_bug.cgi?id=50488
592
593         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
594         (TestWebKitAPI::TEST): Test that the default value of
595         WKPreferencesGetHyperlinkAuditingEnabled is true.
596
597 2010-12-03  Chris Guillory  <chris.guillory@google.com>
598
599         Reviewed by Chris Fleizach.
600
601         Include the FrameView widget of a RenderWidget in the accessibility tree.
602         https://bugs.webkit.org/show_bug.cgi?id=49106
603
604         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
605         (AccessibilityUIElement::AccessibilityUIElement):
606         (AccessibilityUIElement::parentElementCallback):
607         (AccessibilityUIElement::isEqualCallback):
608         * DumpRenderTree/chromium/AccessibilityUIElement.h:
609         * DumpRenderTree/chromium/CppBoundClass.cpp:
610         (CppBoundClass::getFromCppVariant):
611         * DumpRenderTree/chromium/CppBoundClass.h:
612
613 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
614
615         Reviewed by Tony Chang.
616
617         Rebaseline server: organize tests by state, add dry run mode
618         https://bugs.webkit.org/show_bug.cgi?id=50473
619         
620         Group tests in the menu by state, so that it's easier to see after
621         processing the queue which failed.
622         
623         Add support for the --dry-run flag so that it's easier to test changes
624         such as this (stubs out filesystem and SCM operations).
625
626         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
627         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
628         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
629
630 2010-12-03  Brady Eidson  <beidson@apple.com>
631
632         Reviewed by Anders Carlsson.
633
634         Groundwork for <rdar://problem/7660733> and https://bugs.webkit.org/show_bug.cgi?id=50191
635         WebKit2 Authentication Support
636
637         Keep these builds working:
638         * MiniBrowser/mac/BrowserWindowController.m:
639         (-[BrowserWindowController awakeFromNib]):
640
641         * WebKitTestRunner/TestController.cpp:
642         (WTR::TestController::initialize):
643
644 2010-12-02  Mihai Parparita  <mihaip@chromium.org>
645
646         Reviewed by Tony Chang.
647
648         Rebaseline server: move existing baselines
649         https://bugs.webkit.org/show_bug.cgi?id=50421
650         
651         Implement moving of existing baselines: move all files that are about
652         to be overwriten by update baselines.
653         
654         Also fix a typo in the UI JS.
655
656         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
657         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
658         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
659
660 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
661
662         Unreviewed, rolling out r73211.
663         http://trac.webkit.org/changeset/73211
664         https://bugs.webkit.org/show_bug.cgi?id=50450
665
666         Broke Chromium's "Webkit Win (dbg)(2)" bot. (Requested by
667         yutak on #webkit).
668
669         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
670
671 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
672
673         Unreviewed, rolling out r73222.
674         http://trac.webkit.org/changeset/73222
675         https://bugs.webkit.org/show_bug.cgi?id=50449
676
677         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
678         (Requested by yutak on #webkit).
679
680         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
681         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
682         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
683         * Scripts/webkitpy/layout_tests/port/base.py:
684         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
685         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
686
687 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
688
689         Unreviewed, rolling out r73228.
690         http://trac.webkit.org/changeset/73228
691         https://bugs.webkit.org/show_bug.cgi?id=50448
692
693         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
694         (Requested by yutak on #webkit).
695
696         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
697         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
698         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
699         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
700         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
701
702 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
703
704         Unreviewed, rolling out r73231.
705         http://trac.webkit.org/changeset/73231
706         https://bugs.webkit.org/show_bug.cgi?id=50443
707
708         r73211 seemed to broke Chromium's "Webkit Win (dbg)(2)" bot.
709         (Requested by yutak on #webkit).
710
711         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
712         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
713         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
714         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
715
716 2010-12-03  David Levin  <levin@chromium.org>
717
718         Reviewed by Shinichiro Hamaji.
719
720         check-webkit-style: false positive reported for #if macro
721         https://bugs.webkit.org/show_bug.cgi?id=48242
722
723         * Scripts/webkitpy/style/checkers/cpp.py: Adjusted check to avoid
724           all preprocessor commands.
725         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test.
726
727 2010-12-02  Eric Seidel  <eric@webkit.org>
728
729         Reviewed by Adam Barth.
730
731         Update the EWSTools scripts to use modern-style git repos
732         https://bugs.webkit.org/show_bug.cgi?id=50402
733
734         * EWSTools/create-webkit-git:
735         * EWSTools/start-commit-queue.sh:
736         * EWSTools/start-queue.sh:
737
738 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
739
740         Fix Chromium Linux plugin tests by not logging
741         unconditionally from the event handling code.
742
743         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
744         (handleEventX11):
745
746 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
747
748         Reviewed by Tony Chang.
749
750         nrwt multiprocessing - move logic back into run_webkit_tests
751
752         This change moves a bunch of logic that I had put into
753         message_broker back into run_webkit_tests, in a slightly
754         different format. WorkerMessageBroker needed to become less aware of
755         the logic the TestRunner class uses, and more generic.
756         Eventually the MessageBroker will only do generic messaging and
757         thread/process-pooling, and (almost) all of the
758         run-webkit-tests-specific logic will be moved to
759         run_webkit_tests.py and dump_render_tree_thread.py.
760         
761         The biggest changes are that the Broker can now start a single
762         worker, but the responsibility for starting all of them is pushed
763         back to the TestRunner (Manager), and the logic for checking if
764         the threads are done or wedged is moved back to TestRunner. We
765         also remove WorkerMessageBroker.cleanup (not needed) and
766         cancel_workers (they have to be cancelled individually).
767         
768         The  message_broker is now encapsulated inside
769         TestRunner._run_tests(); it only needs to exist while actually
770         running the tests.
771
772         Also, delete a bunch of tests in message_broker_unittest that no
773         longer make much sense.
774
775         This patch depends on bug 50372.
776
777         https://bugs.webkit.org/show_bug.cgi?id=50374
778
779         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
780         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
781         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
782         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
783         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
784
785 2010-12-02  Hayato Ito  <hayato@chromium.org>
786
787         Reviewed by Eric Seidel.
788
789         Refactor test_types's compare_output() method so that it takes a
790         TestInput object.
791
792         compare_output() will need additional information included in a TestInput
793         object to support reftests. This change is a pre-requirement of that.
794
795         https://bugs.webkit.org/show_bug.cgi?id=50362
796
797         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
798         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
799         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
800         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
801         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
802
803 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
804
805         Reviewed by Anders Carlsson.
806
807         Add the ability to run script on 'new' and 'paint' in the test plugin
808         https://bugs.webkit.org/show_bug.cgi?id=50425
809         
810         Add "onnew" and "onpaintevent" attributes to the test plugin,
811         so that tests can run JS at these times.
812
813         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
814         (pluginAllocate):
815         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
816         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
817         (NPP_New):
818         (NPP_Destroy):
819         (handleEventCarbon):
820         (handleEventCocoa):
821         (NPP_HandleEvent):
822
823 2010-12-02  Sam Weinig  <sam@webkit.org>
824
825         Fix Qt build.
826
827         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
828         (WTR::PlatformWebView::PlatformWebView):
829
830 2010-12-02  Sam Weinig  <sam@webkit.org>
831
832         Reviewed by Anders Carlsson.
833
834         WebKit2 Preferences should be held off the PageGroup, not the Context
835         https://bugs.webkit.org/show_bug.cgi?id=50414
836
837         Update for API changes.
838
839         * WebKitTestRunner/PlatformWebView.h:
840         * WebKitTestRunner/TestController.cpp:
841         (WTR::createOtherPage):
842         (WTR::TestController::initialize):
843         (WTR::TestController::resetStateToConsistentValues):
844         * WebKitTestRunner/TestController.h:
845         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
846         (WTR::PlatformWebView::PlatformWebView):
847         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
848         (WTR::PlatformWebView::PlatformWebView):
849
850 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
851
852         Reviewed by Tony Chang.
853
854         new-run-webkit-tests: minor cleanup for multiprocessing work
855
856         This change:
857         * moves worker naming into TestShellThread, eliminating a
858           parameter to the constructor and putting the responsibility in
859           the correct place.
860         * eliminates the _WorkerState() class in message_broker, because
861           it turns out that state really needs to be in run_webkit_tests
862         * renames the Broker classes to be module-private.
863         * fixes a bunch of minor commenting and whitespace issues to
864           make subsequent patches a bit clearer.
865         * Adds a Port hook for default_worker_model() so that we can
866           accomodate the potential for different worker models on
867           different ports.
868         * merge in the fix from 50420 for the brokenness introduced in
869           bug 50367.
870
871         This patch depends on bug 50367.
872
873         https://bugs.webkit.org/show_bug.cgi?id=50372
874
875         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
876         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
877         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
878         * Scripts/webkitpy/layout_tests/port/base.py:
879         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
880         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
881
882 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
883
884         Reviewed by Tony Chang.
885
886         This change is a bunch of cleanup / refactoring of the file
887         below. It moves a bunch of free functions to methods on the
888         TestShellThread class, and restructures other methods to be
889         closer to the structure we'll need for the multiprocessing
890         rewrite.
891
892         It also makes the logic of --run-singly a *lot* easier to follow
893         by nestling all of the separate-thread logic into a single
894         routine.
895
896         There should be no semantic changes in this patch, just cleanup.
897
898         https://bugs.webkit.org/show_bug.cgi?id=50367
899
900         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
901
902 2010-12-02  Tony Chang  <tony@chromium.org>
903
904         Unreviewed, rolling out r73164.
905         http://trac.webkit.org/changeset/73164
906         https://bugs.webkit.org/show_bug.cgi?id=50359
907
908         broke debugger tests on win
909
910         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
911
912 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
913
914         Reviewed by Tony Chang.
915
916         Rebaseline server: add updating of baselines
917         https://bugs.webkit.org/show_bug.cgi?id=50305
918         
919         Implements updating of baselines, where we copy -actual.* files over
920         the current -expected.* files. To do this, we need a
921         _get_actual_result_files method to get test results files and a
922         _rebaseline_test method to actually do the file copy and SCM operation.
923         _rebaseline_test logs output into a buffer, this is useful for both
924         showing result in the UI and for unit tests.
925         
926         To make passing around of the various test environment properties
927         (results directory, filesystem, SCM, etc) easier, add a TestConfig
928         class for them.
929         
930         Moving of existing baselines is not implemented yet, this patch is big
931         enough as it is.
932
933         * Scripts/webkitpy/common/system/filesystem.py:
934         * Scripts/webkitpy/common/system/filesystem_mock.py:
935         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
936         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
937         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
938         * Scripts/webkitpy/tool/mocktool.py:
939
940 2010-12-02  Brent Fulgham  <bfulgham@webkit.org>
941
942         Unreviewed build fix after vcproj updates.
943
944         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Make sure
945         that WIN_CAIRO is defined for this build.
946         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Update file
947         to reflect new 'Debug_Cairo_CFLite' and 'Release_Cairo_CFLite'
948         (these were previously 'Debug_Cairo' and 'Release_Cairo'
949
950 2010-12-02  Sam Weinig  <sam@webkit.org>
951
952         Reviewed by Anders Carlsson.
953
954         WebKit2 needs API to turn on popup blocking
955         https://bugs.webkit.org/show_bug.cgi?id=50407
956
957         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
958         (TestWebKitAPI::TEST):
959         * WebKitTestRunner/TestController.cpp:
960         (WTR::TestController::resetStateToConsistentValues):
961
962 2010-12-01  Tony Chang  <tony@chromium.org>
963
964         Reviewed by Ojan Vafai.
965
966         [chromium] force NRWT to use DRT
967         https://bugs.webkit.org/show_bug.cgi?id=50359
968
969         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
970
971 2010-12-02  Martin Robinson  <mrobinson@igalia.com>
972
973         Reviewed by Xan Lopez.
974
975         [GTK] DumpRenderTree has two copies of JavaScriptCore
976         https://bugs.webkit.org/show_bug.cgi?id=49877
977
978         * GNUmakefile.am: Remove the second copy of JavaScriptCore from the
979         LDADD list for DumpRenderTree.
980
981 2010-12-02  Sergio Villar Senin  <svillar@igalia.com>
982
983         Unreviewed: Added myself to list of Committers.
984
985         * Scripts/webkitpy/common/config/committers.py:
986
987 2010-12-01  Mihai Parparita  <mihaip@chromium.org>
988
989         Reviewed by Adam Barth.
990
991         build-webkit --chromium always updates DEPS and re-generates project files
992         https://bugs.webkit.org/show_bug.cgi?id=50340
993         
994         Make build-webkit --chromium invoke update-webkit-chromium only when
995         --update-chromium is passed in, so that we don't add 20 seconds to all
996         builds.
997         
998         Making all invocations update was added with r61883, with the goal of
999         making EWS bots always update. The bots will switch to using this flag
1000         (as will all other webkit-patch build steps) so nothing should change
1001         for them.
1002
1003         * Scripts/webkitdirs.pm:
1004         * Scripts/webkitpy/common/config/ports.py:
1005         * Scripts/webkitpy/common/config/ports_unittest.py:
1006
1007 2010-12-01  Dirk Pranke  <dpranke@chromium.org>
1008
1009         Reviewed by Tony Chang.
1010
1011         new-run-webkit-tests: add a --dry-run / -n flag
1012         https://bugs.webkit.org/show_bug.cgi?id=50045
1013
1014         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1015         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1016
1017 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
1018
1019         Reviewed by Adam Roben.
1020
1021         WinCairo build should not use link-time code generation (LTCG)
1022         https://bugs.webkit.org/show_bug.cgi?id=50353
1023
1024         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1025         * DumpRenderTree/win/DumpRenderTree.vcproj:
1026         * DumpRenderTree/win/ImageDiff.vcproj:
1027         * FindSafari/FindSafari.vcproj:
1028         * MiniBrowser/MiniBrowser.vcproj:
1029         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1030         * WebKitAPITest/WebKitAPITest.vcproj:
1031         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1032         * WebKitTestRunner/win/InjectedBundle.vcproj:
1033         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1034         * WinLauncher/WinLauncher.vcproj:
1035         * record-memory-win/record-memory-win.vcproj:
1036
1037 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
1038
1039         Touch GetUserAgentWithNullNPPFromNPPNew.cpp in an effort to force
1040         a rebuild of TestNetscapePlugin.la on GTK+. It seems that simply
1041         adding the file to the sources list was not enough to force the rebuild.
1042
1043         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
1044         Remove an empty line at the end of this file to force a rebuild.
1045
1046 2010-12-01  Sam Weinig  <sam@webkit.org>
1047
1048         Fix windows build.
1049
1050         * MiniBrowser/win/BrowserView.cpp:
1051         (BrowserView::create):
1052
1053 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
1054
1055         Add missing file to the TestNetscapePlugin sources list after r73057.
1056
1057         * GNUmakefile.am: Add missing file.
1058
1059 2010-12-01  Sam Weinig  <sam@webkit.org>
1060
1061         Reviewed by Anders Carlsson.
1062
1063         Add PageGrouping to WebKit2 API
1064         https://bugs.webkit.org/show_bug.cgi?id=50332
1065
1066         - Update testing harnesses to deal with new PageGroup API.
1067
1068         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1069         (WKBundleInitialize):
1070         * TestWebKitAPI/InjectedBundleController.cpp:
1071         (TestWebKitAPI::InjectedBundleController::initialize):
1072         (TestWebKitAPI::InjectedBundleController::didInitializePageGroup):
1073         (TestWebKitAPI::InjectedBundleController::initializeTestNamed):
1074         * TestWebKitAPI/InjectedBundleController.h:
1075         * TestWebKitAPI/InjectedBundleTest.h:
1076         (TestWebKitAPI::InjectedBundleTest::initialize):
1077         (TestWebKitAPI::InjectedBundleTest::didInitializePageGroup):
1078         * TestWebKitAPI/PlatformUtilities.cpp:
1079         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
1080         * TestWebKitAPI/PlatformUtilities.h:
1081         * TestWebKitAPI/PlatformWebView.h:
1082         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
1083         (TestWebKitAPI::TEST):
1084         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
1085         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
1086         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1087         (TestWebKitAPI::PlatformWebView::PlatformWebView):
1088         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
1089         (TestWebKitAPI::PlatformWebView::PlatformWebView):
1090         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1091         (WTR::InjectedBundle::didInitializePageGroup):
1092         (WTR::InjectedBundle::initialize):
1093         (WTR::InjectedBundle::beginTesting):
1094         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1095         (WTR::InjectedBundle::pageGroup):
1096         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1097         (WTR::LayoutTestController::addUserScript):
1098         (WTR::LayoutTestController::addUserStyleSheet):
1099         (WTR::LayoutTestController::setXSSAuditorEnabled):
1100         * WebKitTestRunner/TestController.cpp:
1101         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1102         (WTR::PlatformWebView::PlatformWebView):
1103
1104 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
1105
1106         Reviewed by Adam Roben.
1107
1108         vcproj changes can't be applied cleanly by the Windows EWS bot
1109         https://bugs.webkit.org/show_bug.cgi?id=50328
1110
1111         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
1112         * CLWrapper/CLWrapper.vcproj: Modified property svn:eol-style.
1113         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
1114         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added property svn:eol-style.
1115         * DumpRenderTree/win/DumpRenderTree.vcproj: Modified property svn:eol-style.
1116         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added property svn:eol-style.
1117         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added property svn:eol-style.
1118         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added property svn:eol-style.
1119         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added property svn:eol-style.
1120         * DumpRenderTree/win/ImageDiff.vcproj: Modified property svn:eol-style.
1121         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added property svn:eol-style.
1122         * FindSafari/FindSafari.vcproj: Modified property svn:eol-style.
1123         * FindSafari/FindSafariCommon.vsprops: Added property svn:eol-style.
1124         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
1125         * MIDLWrapper/MIDLWrapper.vcproj: Modified property svn:eol-style.
1126         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added property svn:eol-style.
1127         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added property svn:eol-style.
1128         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added property svn:eol-style.
1129         * MiniBrowser/MiniBrowser.vcproj: Added property svn:eol-style.
1130         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added property svn:eol-style.
1131         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added property svn:eol-style.
1132         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops: Added property svn:eol-style.
1133         * TestWebKitAPI/win/TestWebKitAPI.sln: Added property svn:eol-style.
1134         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added property svn:eol-style.
1135         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added property svn:eol-style.
1136         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added property svn:eol-style.
1137         * WebKitAPITest/WebKitAPITest.vcproj: Added property svn:eol-style.
1138         * WebKitAPITest/WebKitAPITestCommon.vsprops: Added property svn:eol-style.
1139         * WebKitLauncherWin/WebKitLauncherWin.vcproj: Modified property svn:eol-style.
1140         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added property svn:eol-style.
1141         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added property svn:eol-style.
1142         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added property svn:eol-style.
1143         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops: Added property svn:eol-style.
1144         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added property svn:eol-style.
1145         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added property svn:eol-style.
1146         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added property svn:eol-style.
1147         * WebKitTestRunner/WebKitTestRunner.sln: Added property svn:eol-style.
1148         * WebKitTestRunner/win/InjectedBundle.vcproj: Added property svn:eol-style.
1149         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added property svn:eol-style.
1150         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added property svn:eol-style.
1151         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added property svn:eol-style.
1152         * WinLauncher/WinLauncher.vcproj: Modified property svn:eol-style.
1153         * WinLauncher/WinLauncherCommon.vsprops: Added property svn:eol-style.
1154         * record-memory-win/record-memory-win-common.vsprops: Added property svn:eol-style.
1155         * record-memory-win/record-memory-win.vcproj: Modified property svn:eol-style.
1156
1157 2010-12-01  Anders Carlsson  <andersca@apple.com>
1158
1159         Reviewed by Darin Adler.
1160
1161         Return a correct user agent if NPN_UserAgent is called with a null NPP from NPP_New.
1162         https://bugs.webkit.org/show_bug.cgi?id=50336
1163
1164         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1165         Add new test.
1166
1167         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1168         (PluginTest::NPP_New):
1169         Add default implementation/
1170
1171         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1172         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp: Added.
1173         (GetUserAgentWithNullNPPFromNPPNew::GetUserAgentWithNullNPPFromNPPNew):
1174         (GetUserAgentWithNullNPPFromNPPNew::NPP_New):
1175         Get the user agent.
1176
1177         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1178         (NPP_New):
1179         Call PluginTest::NPP_New.
1180
1181         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1182         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1183         Add new files.
1184
1185         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1186         (webkit_test_plugin_new_instance):
1187         Call PluginTest::NPP_New.
1188
1189 2010-12-01  Kevin Ollivier  <kevino@theolliviers.com>
1190
1191         [wx] Build fixes after recent trunk changes.
1192
1193         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1194         (LayoutTestController::findString):
1195         * wx/build/settings.py:
1196
1197 2010-12-01  Dan Bernstein  <mitz@apple.com>
1198
1199         Reviewed by Darin Adler.
1200
1201         WebKitTestRunner needs layoutTestController.findString
1202         https://bugs.webkit.org/show_bug.cgi?id=50238
1203
1204         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added findString().
1205         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1206         (WTR::LayoutTestController::findString): Updated signature for autogenerated bindings.
1207         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
1208
1209 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
1210
1211         Try using svn:eol-style native on a vcproj file.
1212
1213         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Modified property svn:eol-style.
1214
1215 2010-12-01  Patrick Gansterer  <paroga@webkit.org>
1216
1217         Reviewed by Adam Roben.
1218
1219         [WINCE] Add WinCELauncher
1220         https://bugs.webkit.org/show_bug.cgi?id=50217
1221
1222         * WinCELauncher/main.cpp: Added.
1223
1224 2010-11-30  Benjamin Poulain  <benjamin.poulain@nokia.com>
1225
1226         Reviewed by Kenneth Rohde Christiansen.
1227
1228         [Qt] Implement layoutTestController.findString
1229         https://bugs.webkit.org/show_bug.cgi?id=50236
1230
1231         Add the missing function to the LayoutTestController.
1232
1233         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1234         (LayoutTestController::findString):
1235         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1236
1237 2010-11-30  Tony Chang  <tony@chromium.org>
1238
1239         Reviewed by Adam Barth.
1240
1241         [chromium] fix get-int-identifier-special-values.html using TestNetscapePlugIn
1242         https://bugs.webkit.org/show_bug.cgi?id=49036
1243
1244         * DumpRenderTree/chromium/LayoutTestController.cpp: Use IsNumber instead of IsInt32
1245             for CppVariants.
1246         (LayoutTestController::cppVariantToBool):
1247         (LayoutTestController::cppVariantToInt32):
1248         (LayoutTestController::setDatabaseQuota):
1249         (LayoutTestController::evaluateInWebInspector):
1250         (LayoutTestController::setMockGeolocationError):
1251
1252 2010-11-30  Eric Seidel  <eric@webkit.org>
1253
1254         Reviewed by Tony Chang.
1255
1256         update-webkit should call git fetch before git svn rebase
1257         https://bugs.webkit.org/show_bug.cgi?id=50273
1258
1259         After discussion on webkit-dev, we've decided to move the "default"
1260         git setup to pulling updates from git.webkit.org in preference
1261         to rebuilding the local svn index using git svn fetch every time.
1262
1263         This change should have no effect on people using the "old" git setup
1264         and should dramatically increase the speed of updates for those using
1265         the "new" git setup along with update-webkit.  I'm about to move the
1266         EWS and other queues over to this setup once this lands.
1267
1268         * Scripts/update-webkit:
1269
1270 2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>
1271
1272         Reviewed by Xan Lopez.
1273
1274         GTK: AX: implement press in DRT
1275         https://bugs.webkit.org/show_bug.cgi?id=36146
1276
1277         Implement AccessibilityUIElement::press() for GTK.
1278
1279         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1280         (AccessibilityUIElement::press): Implemented.
1281
1282 2010-11-29  Mihai Parparita  <mihaip@chromium.org>
1283
1284         Reviewed by Tony Chang.
1285
1286         config.webkit_base_dir returns a path with a trailing slash
1287         https://bugs.webkit.org/show_bug.cgi?id=50197
1288         
1289         config.webkit_base_dir() should return a path without a trailing slash,
1290         like all the other methods that return paths.
1291         
1292         Undoes MockFileSytem changes by r72640, since they're no longer
1293         necessary for GetBaselinesTest to pass.
1294
1295         * Scripts/webkitpy/common/system/filesystem_mock.py:
1296         * Scripts/webkitpy/layout_tests/port/base.py:
1297         * Scripts/webkitpy/layout_tests/port/config.py:
1298         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1299
1300 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
1301
1302         Reviewed by Tony Chang.
1303
1304         Rebaseline server: baseline display tweaks
1305         https://bugs.webkit.org/show_bug.cgi?id=50207
1306         
1307         Determine which baselines were used when running the tests and highlight
1308         them in the UI. Sort platform names alphabetically.
1309         
1310         Also makes the server URL be launched in the user's browser
1311         automatically.
1312
1313         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1314         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1315         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
1316         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1317         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
1318
1319 2010-11-30  Dan Bernstein  <mitz@apple.com>
1320
1321         Reviewed by Anders Carlsson.
1322
1323         <rdar://problem/8710645> WebKitTestRunner needs layoutTestController.findString
1324         https://bugs.webkit.org/show_bug.cgi?id=50238
1325
1326         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1327         (WTR::LayoutTestController::findString): Added.
1328         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1329
1330 2010-11-30  Steve Falkenburg  <sfalken@apple.com>
1331
1332         Reviewed by Adam Roben.
1333
1334         All projects on Windows should use cmd files for build events
1335         https://bugs.webkit.org/show_bug.cgi?id=50213
1336
1337         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
1338         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Added.
1339         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Added.
1340         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
1341         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Added.
1342         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Added.
1343         * DumpRenderTree/win/ImageDiffCommon.vsprops:
1344         * DumpRenderTree/win/ImageDiffPostBuild.cmd: Added.
1345         * DumpRenderTree/win/ImageDiffPreBuild.cmd: Added.
1346         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops:
1347         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
1348         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops:
1349         * MiniBrowser/MiniBrowserPostBuild.cmd: Added.
1350         * MiniBrowser/MiniBrowserPreBuild.cmd: Added.
1351         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
1352         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Added.
1353         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Added.
1354         * WebKitAPITest/WebKitAPITestCommon.vsprops:
1355         * WebKitAPITest/WebKitAPITestPostBuild.cmd: Added.
1356         * WebKitAPITest/WebKitAPITestPreBuild.cmd: Added.
1357         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
1358         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
1359         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd: Added.
1360         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd: Added.
1361         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd: Added.
1362         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd: Added.
1363         * WinLauncher/WinLauncherCommon.vsprops:
1364         * WinLauncher/WinLauncherPostBuild.cmd: Added.
1365         * WinLauncher/WinLauncherPreBuild.cmd: Added.
1366
1367 2010-11-29  Dan Bernstein  <mitz@apple.com>
1368
1369         GTK DumpRenderTree build fix after r72887.
1370
1371         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1372         (LayoutTestController::findString):
1373
1374 2010-11-29  Dan Bernstein  <mitz@apple.com>
1375
1376         Windows DumpRenderTree build fix after r72887.
1377
1378         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1379         (LayoutTestController::findString): Added empty implementation.
1380
1381 2010-11-29  Dan Bernstein  <mitz@apple.com>
1382
1383         Reviewed by Darin Adler.
1384
1385         DumpRenderTree changes for testing the text search API.
1386         https://bugs.webkit.org/show_bug.cgi?id=50038
1387
1388         * DumpRenderTree/LayoutTestController.cpp:
1389         (findStringCallback):
1390         (LayoutTestController::staticFunctions):
1391         * DumpRenderTree/LayoutTestController.h:
1392         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1393         (LayoutTestController::findString):
1394         * MiniBrowser/mac/BrowserWindowController.m:
1395         (-[BrowserWindowController find:]):
1396
1397 2010-11-29  Johnny Ding  <jnd@chromium.org>
1398
1399         Unreviewed: Add myself to the list of Committers.
1400
1401         * Scripts/webkitpy/common/config/committers.py:
1402
1403 2010-11-29  Mark Rowe  <mrowe@apple.com>
1404
1405         Reviewed by Adele Peterson.
1406
1407         <rdar://problem/8694997> DumpRenderTree fails to build.
1408
1409         * DumpRenderTree/mac/PerlSupport/Makefile: Skip generating wrappers.
1410
1411 2010-11-29  Mark Rowe  <mrowe@apple.com>
1412
1413         Reviewed by Adele Peterson.
1414
1415         <rdar://problem/8694997> DumpRenderTree fails to build.
1416
1417         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm.
1418         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapTiger.c.
1419         * DumpRenderTree/mac/PerlSupport/Makefile:
1420
1421 2010-11-29  Mario Sanchez Prada  <msanchez@igalia.com>
1422
1423         Reviewed by Martin Robinson.
1424
1425         [GTK] Null-check needed in DRT's AccessibilityUIElement::allAtributes()
1426         https://bugs.webkit.org/show_bug.cgi?id=50154
1427
1428         Added missing checks to allAttributes().
1429
1430         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1431         (AccessibilityUIElement::allAttributes): Added missing checks.
1432
1433 2010-11-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1434
1435         Reviewed by Kenneth Rohde Christiansen.
1436
1437         [Qt] Allow pre-generation for package builds for WebKit2
1438         https://bugs.webkit.org/show_bug.cgi?id=50139
1439
1440         Use a build variable for the generated directory path and set the
1441         value based on CONFIG just like for WebKit1.
1442
1443         For non-package builds use a relative base path for the
1444         genrated directory just like for WebKit1.
1445
1446         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1447         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1448
1449 2010-11-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1450
1451         Reviewed by Kenneth Rohde Christiansen.
1452
1453         [Qt] Move some build logic from Qt to platform independent code
1454         https://bugs.webkit.org/show_bug.cgi?id=50134
1455
1456         Create target directories inside generate-forwarding-headers.pl.
1457
1458         * Scripts/generate-forwarding-headers.pl:
1459
1460 2010-11-24  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
1461
1462         Reviewed by Martin Robinson.
1463
1464         [GTK] Windowless plugins gets broken key input
1465         https://bugs.webkit.org/show_bug.cgi?id=49927
1466
1467         Convert the XEvent::keycode to ASCII before printing it. Not
1468         doing this was causing false positive in 
1469         plugins/keyboard-events.html.
1470
1471         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1472         (keycode_to_char):
1473         (webkit_test_plugin_handle_event):
1474
1475 2010-11-24  Jan Erik Hanssen  <jhanssen@sencha.com>
1476
1477         Reviewed by Antonio Gomes.
1478
1479         [Qt] Html autofocus not working with QGraphicsWebView
1480         https://bugs.webkit.org/show_bug.cgi?id=43169
1481
1482         Tell the scene to set the webview item as the currently
1483         focused item. This makes the input field with autofocus get
1484         focus as it should.
1485
1486         * QtTestBrowser/webview.cpp:
1487         (WebViewGraphicsBased::WebViewGraphicsBased):
1488
1489 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
1490
1491         Reviewed by Tony Chang.
1492
1493         nrwt - clean up create_driver interface and print out the
1494         command line used for DumpRenderTree/TestShell.
1495
1496         This patch adds a driver_cmd_line() call to the Port class in
1497         order to retrive the command line to print it out (as part of
1498         --print config).
1499
1500         In addition, this patch cleans up the Port.create_driver()
1501         signature and the Driver constructor interface to take a worker
1502         number and no longer require the image_path argument (Chromium's
1503         drivers now synthesize the image_path from the worker number
1504         internally).
1505
1506         https://bugs.webkit.org/show_bug.cgi?id=49934
1507
1508         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1509         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1510         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1511         * Scripts/webkitpy/layout_tests/port/base.py:
1512         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1513         * Scripts/webkitpy/layout_tests/port/chromium.py:
1514         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1515         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1516         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1517         * Scripts/webkitpy/layout_tests/port/test.py:
1518         * Scripts/webkitpy/layout_tests/port/webkit.py:
1519         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1520         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1521
1522 2010-11-24  Ojan Vafai  <ojan@chromium.org>
1523
1524         Reviewed by Tony Chang.
1525
1526         [chromium] improve memory usage for test results server and store fewer runs
1527         https://bugs.webkit.org/show_bug.cgi?id=50035
1528
1529         Store fewer runs and don't pass full files around when we only need bools.
1530         Greatly improves error rates on test-results.appspot.com.
1531
1532         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1533         * TestResultServer/handlers/testfilehandler.py:
1534         * TestResultServer/model/dashboardfile.py:
1535         * TestResultServer/model/jsonresults.py:
1536
1537 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
1538
1539         Reviewed by Tony Chang.
1540
1541         This patch implements the first part of the manager side of the
1542         Broker objects - it handles creating threads, waiting for them
1543         to complete, and running a single-threaded loop as well.
1544
1545         https://bugs.webkit.org/show_bug.cgi?id=49779
1546
1547         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1548         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
1549         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1550         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1551
1552 2010-11-24  Mihai Parparita  <mihaip@chromium.org>
1553
1554         Reviewed by David Levin.
1555
1556         DRT should not generate pixel output for text/plain tests
1557         https://bugs.webkit.org/show_bug.cgi?id=50002
1558         
1559         Modify Mac, Windows and GTK DRT implementations to disable pixel output
1560         when encountering a text/plain response (the Chromium one already does
1561         this, and none of the other ports special-case text/plain output in
1562         the first place).
1563
1564         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1565         (dump):
1566         * DumpRenderTree/mac/DumpRenderTree.mm:
1567         (dump):
1568         * DumpRenderTree/win/DumpRenderTree.cpp:
1569         (dump):
1570
1571 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
1572
1573         Unreviewed.
1574
1575         Add my other email address to committers.py.
1576
1577         * Scripts/webkitpy/common/config/committers.py:
1578
1579 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
1580
1581         Reviewed by Csaba Osztrogonác.
1582
1583         Make build-webkit --minimal build with ENABLE_INSPECTOR=0
1584         https://bugs.webkit.org/show_bug.cgi?id=49975
1585
1586         * Scripts/build-webkit: Add ENABLE_INSPECTOR define to features,
1587         to enable the script to define it 0 in case of a minimal build.
1588
1589 2010-11-24  Martin Robinson  <mrobinson@igalia.com>
1590
1591         Reviewed by Xan Lopez.
1592
1593         [GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient
1594         https://bugs.webkit.org/show_bug.cgi?id=49143
1595
1596         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1597         (createWebView): Call the new connectEditingCallbacks function.
1598         * DumpRenderTree/gtk/EditingCallbacks.cpp: Added.
1599         (dumpNodePath):
1600         (dumpRange):
1601         (insertActionString):
1602         (selectionAffinityString):
1603         (shouldBeginEditing):
1604         (shouldEndEditing):
1605         (shouldInsertNode):
1606         (shouldInsertText):
1607         (shouldDeleteRange):
1608         (shouldShowDeleteInterfaceForElement):
1609         (shouldChangeSelectedRange):
1610         (shouldApplyStyle):
1611         (editingBegan):
1612         (userChangedContents):
1613         (editingEnded):
1614         (selectionChanged):
1615         (connectEditingCallbacks):
1616         * DumpRenderTree/gtk/EditingCallbacks.h: Added.
1617         * GNUmakefile.am: Added EditingCallbacks.{h,cpp} to the source list.
1618
1619 2010-11-24  Yi Shen  <yi.4.shen@nokia.com>
1620
1621         Reviewed by Andreas Kling.
1622
1623         [Qt] Make QtTestBrowser remember the selected user agent
1624         https://bugs.webkit.org/show_bug.cgi?id=50021
1625
1626         Set user agent for a new page by using the old page's
1627
1628         * QtTestBrowser/mainwindow.cpp:
1629         (MainWindow::setPage):
1630
1631 2010-11-24 Patrick Gansterer <paroga@webkit.org>
1632
1633         Reviewed by Csaba Osztrogonác.
1634
1635         Remove Bakefile build system files
1636         https://bugs.webkit.org/show_bug.cgi?id=49983
1637
1638         r53757 only removed the content, but not the files.
1639         This patch removes that empty files.
1640
1641         * DumpRenderTree/wx/DumpRenderTree.bkl: Removed.
1642         * wx/browser/browser.bkl: Removed.
1643         * wx/build-wxwebkit: Removed.
1644
1645 2010-11-23  Dirk Pranke  <dpranke@chromium.org>
1646
1647         Reviewed by Tony Chang.
1648
1649         This patch cleans up the logic used to shard tests into groups a
1650         bit and adds the --worker-model flag to NRWT. The flag is only
1651         used at the moment to control whether to run single-threaded or
1652         not, but eventually will also allow toggling between threads and
1653         processes.
1654
1655         Also add a minor cleanup with _test_is_slow(), which just
1656         eliminates some repetition and gives slightly better encapsulation.
1657
1658         https://bugs.webkit.org/show_bug.cgi?id=49773
1659
1660         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1661         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1662
1663 2010-11-23  Mihai Parparita  <mihaip@chromium.org>
1664
1665         Reviewed by Tony Chang.
1666
1667         Rebaseline server: list current baselines and platforms
1668         https://bugs.webkit.org/show_bug.cgi?id=49991
1669         
1670         List existing baselines (with Trac links) for tests.
1671         
1672         Add dropdowns for choosing with platform baselines to target (and what
1673         to do with existing ones).
1674
1675         Also fix MockFileSystem.join to behave more like os.path.join (unit
1676         test was ending up with two consecutive slashes in a layout test
1677         path).        
1678
1679         * Scripts/webkitpy/common/system/filesystem_mock.py:
1680         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1681         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1682         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1683         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
1684         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
1685         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1686         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py: Added.
1687
1688 2010-11-23  Ojan Vafai  <ojan@chromium.org>
1689
1690         Reviewed by Tony Chang.
1691
1692         remove timeout argument to urlopen
1693         https://bugs.webkit.org/show_bug.cgi?id=49995
1694
1695         Apparently the version of python we have on the bots doesn't accept a timeout argument.
1696
1697         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
1698
1699 2010-11-23  Sheriff Bot  <webkit.review.bot@gmail.com>
1700
1701         Unreviewed, rolling out r72628.
1702         http://trac.webkit.org/changeset/72628
1703         https://bugs.webkit.org/show_bug.cgi?id=49994
1704
1705         This patch is causing layout-test failtures on GTK Linux
1706         64-bit Debug (Requested by ctguil on #webkit).
1707
1708         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
1709         (AccessibilityUIElement::AccessibilityUIElement):
1710         (AccessibilityUIElement::parentElementCallback):
1711         * DumpRenderTree/chromium/AccessibilityUIElement.h:
1712         * DumpRenderTree/chromium/CppBoundClass.cpp:
1713         * DumpRenderTree/chromium/CppBoundClass.h:
1714
1715 2010-11-22  Ojan Vafai  <ojan@chromium.org>
1716
1717         Reviewed by Tony Chang.
1718
1719         speculative fix for upload errors: stop using mechanize to upload to test-results.appspot.com
1720         https://bugs.webkit.org/show_bug.cgi?id=49944
1721
1722         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
1723
1724 2010-11-23  Chris Guillory  <chris.guillory@google.com>
1725
1726         Reviewed by Dimitri Glazkov.
1727
1728         Include the FrameView widget of a RenderWidget in the accessibility tree.
1729         https://bugs.webkit.org/show_bug.cgi?id=49106
1730
1731         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
1732         (AccessibilityUIElement::AccessibilityUIElement):
1733         (AccessibilityUIElement::parentElementCallback):
1734         (AccessibilityUIElement::isEqualCallback):
1735         * DumpRenderTree/chromium/AccessibilityUIElement.h:
1736         * DumpRenderTree/chromium/CppBoundClass.cpp:
1737         (CppBoundClass::getFromCppVariant):
1738         * DumpRenderTree/chromium/CppBoundClass.h:
1739
1740 2010-11-23  Alex Grilo  <abgrilo@profusion.mobi>
1741
1742         Reviewed by Kenneth Rohde Christiansen.
1743
1744         [EFL] Add tiled backing store to EWebLauncher
1745         https://bugs.webkit.org/show_bug.cgi?id=45777
1746
1747         Allow EWebLauncher to choose between single and tiled backing store
1748
1749         * EWebLauncher/main.c:
1750         (on_key_down):
1751         (browserCreate):
1752         (main):
1753
1754 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
1755
1756         Reviewed by Tor Arne Vestbø.
1757
1758         [Qt] Review the setUserPermission & friends API
1759         https://bugs.webkit.org/show_bug.cgi?id=46810
1760
1761         Renamed requestPermissionFromUser to featurePermissionRequested
1762         and cancelRequestsForPermission to featurePermissionRequestCanceled.
1763
1764         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1765         (WebCore::WebPage::WebPage):
1766         * QtTestBrowser/webpage.cpp:
1767         (WebPage::WebPage):
1768         (WebPage::featurePermissionRequestCanceled):
1769         * QtTestBrowser/webpage.h:
1770
1771 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
1772
1773         Reviewed by Tor Arne Vestbø.
1774
1775         [Qt] Review the setUserPermission & friends API
1776         https://bugs.webkit.org/show_bug.cgi?id=46810
1777
1778         Rename setUserPermission to setFeaturePermission
1779
1780         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1781         (WebCore::WebPage::requestPermission):
1782         (WebCore::WebPage::permissionSet):
1783         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1784         (LayoutTestController::grantDesktopNotificationPermission):
1785         * QtTestBrowser/webpage.cpp:
1786         (WebPage::requestPermission):
1787
1788 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
1789
1790         Reviewed by Tor Arne Vestbø.
1791
1792         [Qt] Review the setUserPermission & friends API
1793         https://bugs.webkit.org/show_bug.cgi?id=46810
1794
1795         Rename PermissionDomain to Feature, NotificationsPermissionDomain to Notifications
1796         and GeolocationPermissionDomain to Geolocation.
1797
1798         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1799         (WebCore::WebPage::WebPage):
1800         (WebCore::WebPage::requestPermission):
1801         (WebCore::WebPage::cancelPermission):
1802         (WebCore::WebPage::permissionSet):
1803         (WebCore::DumpRenderTree::geolocationPermissionSet):
1804         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1805         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1806         (LayoutTestController::grantDesktopNotificationPermission):
1807         * QtTestBrowser/webpage.cpp:
1808         (WebPage::WebPage):
1809         (WebPage::requestPermission):
1810         (WebPage::cancelRequestsForPermission):
1811         * QtTestBrowser/webpage.h:
1812
1813 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
1814
1815         Reviewed by Tor Arne Vestbø.
1816
1817         [Qt] Review the setUserPermission & friends API
1818         https://bugs.webkit.org/show_bug.cgi?id=46810
1819
1820         Add a ByUser suffix to PermissionGranted/Denied. In the future
1821         we can add PermissionGrantedByDefault.
1822
1823
1824         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1825         (WebCore::WebPage::requestPermission):
1826         (WebCore::WebPage::permissionSet):
1827         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1828         (LayoutTestController::grantDesktopNotificationPermission):
1829         * QtTestBrowser/webpage.cpp:
1830         (WebPage::requestPermission):
1831
1832 2010-11-18  Satish Sampath  <satish@chromium.org>
1833
1834         Reviewed by Jeremy Orlow.
1835
1836         For speech input event, send an event object containing all the recognition results and metadata.
1837         https://bugs.webkit.org/show_bug.cgi?id=49736
1838
1839         Updated DRT by renaming the mock result method on all platforms to the new signature.
1840
1841         * DumpRenderTree/LayoutTestController.cpp:
1842         (addMockSpeechInputResultCallback):
1843         (LayoutTestController::staticFunctions):
1844         * DumpRenderTree/LayoutTestController.h:
1845         * DumpRenderTree/chromium/LayoutTestController.cpp:
1846         (LayoutTestController::LayoutTestController):
1847         (LayoutTestController::addMockSpeechInputResult):
1848         * DumpRenderTree/chromium/LayoutTestController.h:
1849         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1850         (LayoutTestController::addMockSpeechInputResult):
1851         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1852         (LayoutTestController::addMockSpeechInputResult):
1853         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1854         (LayoutTestController::addMockSpeechInputResult):
1855         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1856         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1857         (LayoutTestController::addMockSpeechInputResult):
1858         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1859         (LayoutTestController::addMockSpeechInputResult):
1860
1861 2010-11-22  Dirk Pranke  <dpranke@chromium.org>
1862
1863         Reviewed by Tony Chang.
1864
1865         Fix some spacing issues with log messages with
1866         new-run-webkit-tests --verbose.
1867
1868         https://bugs.webkit.org/show_bug.cgi?id=49936
1869
1870         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1871
1872 2010-11-22  Ojan Vafai  <ojan@chromium.org>
1873
1874         Reviewed by Adam Barth.
1875
1876         update scm to work with different remote branches
1877         https://bugs.webkit.org/show_bug.cgi?id=49949
1878
1879         This works if there are multiple svn tracking branches
1880         and/or if the tracking branch is refs/remots/origin/master
1881         instead of refs/remotes/trunk which is the direction we're trying
1882         to head since that makes fetches faster.
1883
1884         * Scripts/webkitpy/common/checkout/scm.py:
1885         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1886
1887 2010-11-22  Hayato Ito  <hayato@chromium.org>
1888
1889         Reviewed by Shinichiro Hamaji.
1890
1891         Ignore reference files which will be used by reftests when collecting
1892         test cases.
1893         https://bugs.webkit.org/show_bug.cgi?id=49835
1894
1895         * Scripts/webkitpy/layout_tests/port/test_files.py:
1896         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1897
1898 2010-11-22  Adam Roben  <aroben@apple.com>
1899
1900         Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files
1901
1902         Apple's Windows build allows placing header files and import libraries for WebKit's
1903         dependencies (CoreGraphics, CFNetwork, SQLite, etc.) outside the source tree via the
1904         $WebKitLibrariesDir environment variable. This is both required for production builds and
1905         convenient for Apple-internal developer builds. Apple's production builds also require that
1906         WebKit's shared .vsprops files be accessed relative to $WebKitLibrariesDir. In production
1907         builds, the files are copied into that directory tree by the
1908         WebKitLibraries/win/tools/WinTools.make file. In Apple-internal developer builds, the
1909         copying is done by
1910         JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make.
1911
1912         This .vsprops copying is problematic in one very important case: when a developer updates
1913         their source tree and then tries to build. Visual Studio only reads .vsprops files when a
1914         project is first loaded. So, when Visual Studio is first opened after the .vsprops files are
1915         updated, it reads in the old files that were already residing in $WebKitLibrariesDir. When a
1916         build is started, JavaScriptCoreGenerated.make copies the new .vsprops files into
1917         $WebKitLibrariesDir, but Visual Studio will not pick up the changes.  The rest of the build
1918         will proceed with out-of-date .vsprops files, which will likely result in a build failure.
1919
1920         To fix this, we now use normal relative paths to access the .vsprops files in the source
1921         tree rather than in $WebKitLibrariesDir, but prefix those paths with a new environment
1922         variable, $WebKitVSPropsRedirectionDir. In developer builds, this environment variable is
1923         unset, so the normal relative paths are used to read the .vsprops files out of the source
1924         tree directly. In production builds, this environment variable is set to a fake directory
1925         that will cause the .vsprops files in $WebKitLibrariesDir to be found when the relative path
1926         is resolved.
1927         
1928         For example, JavaScriptCore.vcproj uses this path for FeatureDefines.vsprops:
1929
1930         $(WebKitVSPropsRedirectionDir)..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
1931
1932         In developer builds, where $WebKitVSPropsRedirectionDir is unset, this will point to the
1933         files in WebKitLibraries\win\tools\vsprops in the source tree. In production builds,
1934         JavaScriptCore.make sets $WebKitVSPropsRedirectionDir to
1935         "$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\", so the full path for
1936         FeatureDefines.vsprops becomes:
1937
1938         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
1939
1940         which resolves to:
1941
1942         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
1943
1944         (We rely on the fact that Windows doesn't care whether the directories "1", "2", and "3"
1945         actually exist since they are matched by an equal number of ".." path components.)
1946
1947         Note that Visual Studio still won't pick up changes made to .vsprops files while Visual
1948         Studio is open, but that problem hasn't seemed to cause developers many headaches so far.
1949
1950         Fixes <http://webkit.org/b/49181> Windows build fails mysteriously when .vsprops files are
1951         updated
1952
1953         Reviewed by Dave Hyatt.
1954
1955         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1956         * DumpRenderTree/win/DumpRenderTree.vcproj:
1957         * DumpRenderTree/win/ImageDiff.vcproj:
1958         * FindSafari/FindSafari.vcproj:
1959         * MiniBrowser/MiniBrowser.vcproj:
1960         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1961         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
1962         * WebKitAPITest/WebKitAPITest.vcproj:
1963         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1964         * WebKitTestRunner/win/InjectedBundle.vcproj:
1965         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1966         * WinLauncher/WinLauncher.vcproj:
1967         * record-memory-win/record-memory-win.vcproj:
1968         Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
1969         files.
1970
1971 2010-11-22  Adam Roben  <aroben@apple.com>
1972
1973         Make it possible to run tests on Windows without Visual Studio or VC++
1974         Express installed
1975
1976         webkitdir.pm::setupCygwinEnv dies when Visual Studio and VC++ Express
1977         are not installed. But this function doesn't need to be called when we
1978         already have a build available and are just trying to run the tests.
1979
1980         Fixes <http://webkit.org/b/49932> New Windows 7 bot can't run tests
1981         because Visual Studio/VC++ Express aren't installed
1982
1983         Reviewed by Dave Hyatt.
1984
1985         * Scripts/webkitdirs.pm:
1986         (determineConfigurationForVisualStudio): Don't call setupCygwinEnv, as
1987         it is not needed by this function. Also added a FIXME.
1988
1989         (usingVisualStudioExpress): Call setupCygwinEnv directly rather than
1990         relying on determineConfigurationForVisualStudio doing it.
1991
1992 2010-11-19  Hayato Ito  <hayato@chromium.org>
1993
1994         Reviewed by Shinichiro Hamaji.
1995
1996         Simplify Driver.run_test() so that it takes only one parameter, TestInput.
1997
1998         https://bugs.webkit.org/show_bug.cgi?id=49812
1999
2000         * Scripts/webkitpy/layout_tests/driver_test.py:
2001         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2002         * Scripts/webkitpy/layout_tests/port/base.py:
2003         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2004         * Scripts/webkitpy/layout_tests/port/chromium.py:
2005         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2006         * Scripts/webkitpy/layout_tests/port/test.py:
2007         * Scripts/webkitpy/layout_tests/port/webkit.py:
2008         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2009         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2010
2011 2010-11-22  Hayato Ito  <hayato@chromium.org>
2012
2013         Reviewed by Tony Chang.
2014
2015         [NRWT] Retry a few times in reading a png image to avoid a race condition.
2016
2017         https://bugs.webkit.org/show_bug.cgi?id=49924
2018
2019         * Scripts/webkitpy/layout_tests/port/chromium.py:
2020
2021 2010-11-22  João Paulo Rechi Vita  <jprvita@profusion.mobi>
2022
2023         Reviewed by Kenneth Rohde Christiansen.
2024
2025         Fix EWebLauncher zoom discretization
2026         https://bugs.webkit.org/show_bug.cgi?id=49810
2027
2028         * EWebLauncher/main.c:
2029         (nearest_zoom_level_get):
2030         (zoom_level_set):
2031         (on_load_finished):
2032         (on_key_down):
2033
2034 2010-11-21  Sam Weinig  <sam@webkit.org>
2035
2036         Rubber-stamped by Dan Bernstein.
2037
2038         Fix ~300 WebKit2 tests by enabling developer extras preference.
2039
2040         * WebKitTestRunner/TestController.cpp:
2041         (WTR::TestController::resetStateToConsistentValues):
2042
2043 2010-11-21  Sam Weinig  <sam@webkit.org>
2044
2045         Reviewed by Dan Bernstein.
2046
2047         Textareas should be resizable by default
2048         https://bugs.webkit.org/show_bug.cgi?id=49892
2049
2050         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2051         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp: Added.
2052         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2053         Add preferences test.
2054
2055 2010-11-19  Mihai Parparita  <mihaip@chromium.org>
2056
2057         Reviewed by Tony Chang.
2058
2059         Rebaseline server: checksum-only differences and prefetching
2060         https://bugs.webkit.org/show_bug.cgi?id=49841
2061         
2062         Add support for image test results where the only difference is in the
2063         checksum.
2064         
2065         Add prefetching of the image results from the next test.
2066         
2067         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
2068         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2069         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2070
2071 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
2072
2073         Reviewed by Tony Chang.
2074
2075         nrwt multiprocessing - add 'worker number' concept, move stuff to worker thread
2076
2077         Add the 'worker number' and 'worker name' concepts to the 
2078         TestShellThread objects, and move test_types and test_args from
2079         the TestRunner to the TestShellThread.
2080
2081         https://bugs.webkit.org/show_bug.cgi?id=49768
2082
2083         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2084         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2085
2086 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
2087
2088         Reviewed by Ojan Vafai.
2089
2090         Do some minor cleanup and bug fixing.
2091
2092         https://bugs.webkit.org/show_bug.cgi?id=49777
2093
2094         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2095         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2096
2097 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
2098
2099         Reviewed by Ojan Vafai.
2100
2101         nrwt - config.build_directory() is busted
2102
2103         Fixes a typo that was causing us to usually return the top level
2104         directory WebKitBuild instead of WebKitBuild/{Debug,Release}. The
2105         bug was hidden by test stubs that were too simplistic :(.
2106
2107         https://bugs.webkit.org/show_bug.cgi?id=49815
2108
2109         * Scripts/webkitpy/common/system/executive_mock.py:
2110         * Scripts/webkitpy/layout_tests/port/config.py:
2111         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2112
2113 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
2114
2115         Reviewed by Adam Roben.
2116
2117         Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
2118         https://bugs.webkit.org/show_bug.cgi?id=49819
2119
2120         * DumpRenderTree/DumpRenderTree.sln:
2121         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2122         * DumpRenderTree/win/DumpRenderTree.vcproj:
2123         * DumpRenderTree/win/ImageDiff.vcproj:
2124         * FindSafari/FindSafari.vcproj:
2125         * MiniBrowser/MiniBrowser.vcproj:
2126         * TestWebKitAPI/win/TestWebKitAPI.sln:
2127         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2128         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
2129         * WebKitAPITest/WebKitAPITest.vcproj:
2130         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
2131         * WebKitTestRunner/win/InjectedBundle.vcproj:
2132         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
2133         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2134         * WinLauncher/WinLauncher.vcproj:
2135         * record-memory-win/record-memory-win.vcproj:
2136
2137 2010-11-19  Adam Roben  <aroben@apple.com>
2138
2139         Add some more Windows slaves
2140
2141         This is probably more than we will be using in the immediate future,
2142         but having some extra slave names makes experimenting with different
2143         configurations easier.
2144
2145         Reviewed by Jon Honeycutt.
2146
2147         * BuildSlaveSupport/build.webkit.org-config/config.json: Added 5 more
2148         Windows slaves and distributed them among the three different Test
2149         builders.
2150
2151 2010-11-19  Kinuko Yasuda  <kinuko@chromium.org>
2152
2153         Reviewed by Ojan Vafai.
2154
2155         [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
2156         https://bugs.webkit.org/show_bug.cgi?id=49702
2157
2158         Re-landing r72357 with a test fix.
2159
2160         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2161         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2162         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2163
2164 2010-11-19  Avi Drissman  <avi@google.com>
2165
2166         Reviewed by Antonio Gomes.
2167
2168         Complete support for Unix editing mode
2169         https://bugs.webkit.org/show_bug.cgi?id=49757
2170
2171         * DumpRenderTree/LayoutTestController.cpp:
2172         (setEditingBehaviorCallback):
2173         * DumpRenderTree/chromium/LayoutTestController.cpp:
2174         (LayoutTestController::setEditingBehavior):
2175
2176 2010-11-19  Adam Roben  <aroben@apple.com>
2177
2178         Fix run-javascriptcore-tests when there's a space in the path to
2179         testapi
2180
2181         Reviewed by Sam Weinig.
2182
2183         * Scripts/run-javascriptcore-tests: Use an indirect object when calling
2184         system() to force it to interpret spaces in the path correctly.
2185
2186 2010-11-19  Adam Roben  <aroben@apple.com>
2187
2188         Update scripts for .exe name changes after r72327
2189
2190         As of r72327, the "_debug" suffix is only used in Debug_All builds.
2191
2192         Reviewed by Sam Weinig.
2193
2194         * Scripts/run-javascriptcore-tests:
2195         (testapiPath):
2196
2197         * Scripts/sunspider-compare-results:
2198         (pathToBuiltJSC):
2199
2200         * Scripts/webkitdirs.pm:
2201         (jscPath):
2202         (safariPath):
2203
2204 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
2205
2206         Reviewed by Darin Adler.
2207
2208         Normalize Cairo/CFLite project/solution configuration names
2209         https://bugs.webkit.org/show_bug.cgi?id=49818
2210
2211         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2212         * DumpRenderTree/win/DumpRenderTree.vcproj:
2213         * DumpRenderTree/win/ImageDiff.vcproj:
2214         * MiniBrowser/MiniBrowser.vcproj:
2215         * TestWebKitAPI/win/TestWebKitAPI.sln:
2216         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2217         * WebKitAPITest/WebKitAPITest.vcproj:
2218         * WebKitTestRunner/win/InjectedBundle.vcproj:
2219         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2220         * WinLauncher/WinLauncher.vcproj:
2221         * Scripts/webkitdirs.pm: Updated cairo build configs.
2222
2223 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
2224
2225         Reviewed by Adam Roben.
2226
2227         Windows vcproj configuration names should be normalized across projects
2228         https://bugs.webkit.org/show_bug.cgi?id=49776
2229
2230         * DumpRenderTree/DumpRenderTree.sln:
2231         * FindSafari/FindSafari.vcproj:
2232         * TestWebKitAPI/win/TestWebKitAPI.sln:
2233         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
2234         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added.
2235         * WebKitAPITest/WebKitAPITest.vcproj:
2236         * WebKitAPITest/WebKitAPITestCommon.vsprops:
2237         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
2238         * WebKitTestRunner/WebKitTestRunner.sln:
2239         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
2240         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added.
2241         * record-memory-win/record-memory-win.vcproj:
2242
2243 2010-11-18  Gavin Barraclough  <barraclough@apple.com>
2244
2245         Build fix - as per DRT-mac, always enabled developer extras,
2246         in win/qt/gtk DRT.
2247
2248         This is necessary to enable rich exception messages to be generated
2249         following https://bugs.webkit.org/show_bug.cgi?id=49708.
2250
2251         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2252         (shouldEnableDeveloperExtras):
2253         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2254         (WebCore::shouldEnableDeveloperExtras):
2255         * DumpRenderTree/win/DumpRenderTree.cpp:
2256         (shouldEnableDeveloperExtras):
2257
2258 2010-11-18  Sheriff Bot  <webkit.review.bot@gmail.com>
2259
2260         Unreviewed, rolling out r72357.
2261         http://trac.webkit.org/changeset/72357
2262         https://bugs.webkit.org/show_bug.cgi?id=49784
2263
2264         It broke test-webkitpy tests since the patch didn't have the
2265         corresponding test update (Requested by kinuko on #webkit).
2266
2267         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2268         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2269
2270 2010-11-18  Mihai Parparita  <mihaip@chromium.org>
2271
2272         Reviewed by Tony Chang.
2273
2274         Rebaseline server: add rebaseline queue
2275         https://bugs.webkit.org/show_bug.cgi?id=49763
2276         
2277         Add a UI queue (a multi-item <select>) where tests to be baselined
2278         can be enqueued (also supports basic removal). A queue is used instead
2279         of immediately doing rebaselines since SCM operations can take a while.
2280         It's better to go through lots of tests quickly to mark them as
2281         needing rebaselining and then batch the SCM operations.
2282         
2283         Also adds a simple log where results can be displayed.
2284
2285         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
2286         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2287         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2288         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js: Added.
2289         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
2290         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2291
2292 2010-11-18  Gavin Barraclough  <barraclough@apple.com>
2293
2294         Reviewed by Oliver Hunt.
2295
2296         Bug 49708 - Stop recompiling functions to regenerate exception info.
2297
2298         Instead only hold info as necessary – keep divot info is the inspector
2299         is enabled, line number info is debugging or profiling, and handler
2300         info for functions with try/catch.
2301
2302         * DumpRenderTree/mac/DumpRenderTree.mm:
2303         (shouldEnableDeveloperExtras):
2304             - always enable the developer tools from DRT, to ensure we
2305               produce rich error messages on JavaScript exceptions.
2306
2307 2010-11-18  Kinuko Yasuda  <kinuko@chromium.org>
2308
2309         Reviewed by Ojan Vafai.
2310
2311         [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
2312         https://bugs.webkit.org/show_bug.cgi?id=49702
2313
2314         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2315         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2316
2317 2010-11-18  Dirk Pranke  <dpranke@chromium.org>
2318
2319         Reviewed by Tony Chang.
2320
2321         new-run-webkit-tests: create first part of 'message_broker' class for multiprocessing fixes
2322
2323         Create the first version of the 'message_broker' package. This
2324         class will encapsulate all of the threading/multiprocessing and
2325         message-sending details for the communication between the
2326         'manager' object and the 'worker' objects. For the moment, it
2327         just holds some routines and tests for logging thread stacks.
2328
2329         There should be no functional changes in this patch, just moving stuff
2330         around.
2331
2332         https://bugs.webkit.org/show_bug.cgi?id=49707
2333
2334         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2335         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Removed.
2336         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Added.
2337         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: Added.
2338         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2339         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2340
2341 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
2342
2343         Reviewed by Adam Roben.
2344
2345         Remove leftover Windows Debug_Internal configurations
2346         https://bugs.webkit.org/show_bug.cgi?id=49758
2347
2348         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2349         * DumpRenderTree/win/DumpRenderTree.vcproj:
2350         * DumpRenderTree/win/ImageDiff.vcproj:
2351         * MiniBrowser/MiniBrowser.vcproj:
2352         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2353         * WebKitAPITest/WebKitAPITest.vcproj:
2354         * WebKitTestRunner/win/InjectedBundle.vcproj:
2355         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2356         * WinLauncher/WinLauncher.vcproj:
2357
2358 2010-11-18  Adam Roben  <aroben@apple.com>
2359
2360         Add three new Windows XP build slaves
2361
2362         Reviewed by Steve Falkenburg.
2363
2364         * BuildSlaveSupport/build.webkit.org-config/config.json: Added three
2365         new slaves, and added them to the Windows XP Debug (Tests) builder.
2366
2367 2010-11-18  Daniel Bates  <dbates@rim.com>
2368
2369         Reviewed by Adam Roben.
2370
2371         update-webkit-support-libs should fall back to existing
2372         WebKitSupportLibrary version if there is no internet connectivity
2373         https://bugs.webkit.org/show_bug.cgi?id=49503
2374
2375         Fall back to existing support libraries (if present) when there is
2376         no internet connection.
2377
2378         Currently, update-webkit-support-libs dies with an "out-of-date"
2379         error when there is no internet connection because it cannot
2380         retrieve versioning information from developer.apple.com. Because
2381         update-webkit-support-libs fails, build-webkit fails. Instead,
2382         if there is no internet connection and the support libraries are
2383         present then we should warn the user and exit() with success so
2384         that build-webkit can work without an internet connection.
2385
2386         * Scripts/update-webkit-support-libs:
2387
2388 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
2389
2390         Reviewed by Adam Roben.
2391
2392         Debug_Internal Windows configuration is unnecessary, should be removed
2393         https://bugs.webkit.org/show_bug.cgi?id=49753
2394
2395         * DumpRenderTree/win/DumpRenderTree.cpp:
2396         * MiniBrowser/win/stdafx.h:
2397         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2398         * WebKitTestRunner/win/TestControllerWin.cpp:
2399
2400 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
2401
2402         Reviewed by Adam Roben.
2403
2404         Clean up vcproj errors
2405         https://bugs.webkit.org/show_bug.cgi?id=49741
2406
2407         * MiniBrowser/MiniBrowser.vcproj:
2408         * WebKitAPITest/WebKitAPITest.vcproj:
2409         * WebKitTestRunner/win/InjectedBundle.vcproj:
2410         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2411
2412 2010-11-18  Hayato Ito  <hayato@chromium.org>
2413
2414         Reviewed by Shinichiro Hamaji.
2415
2416         [NRWT] Fix a break of '--new-baseline' feature in pixel_test
2417         which is caused by r72249.
2418
2419         https://bugs.webkit.org/show_bug.cgi?id=49751
2420
2421         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2422
2423 2010-11-18  Adam Roben  <aroben@apple.com>
2424
2425         Implement layoutTestController.waitForPolicyDelegate on Windows
2426
2427         Fixes <http://webkit.org/b/25038> <rdar://problem/6790213>.
2428
2429         Reviewed by Simon Fraser.
2430
2431         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2432         (LayoutTestController::waitForPolicyDelegate): Implemented by porting
2433         code from LayoutTestControllerMac.mm.
2434
2435 2010-11-18  Hayato Ito  <hayato@chromium.org>
2436
2437         Reviewed by Shinichiro Hamaji.
2438
2439         [NRWT] Fix a break of '--new-baseline' feature which is caused by r72249.
2440
2441         https://bugs.webkit.org/show_bug.cgi?id=49740
2442
2443         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2444
2445 2010-11-18  Tony Chang  <tony@chromium.org>
2446
2447         Reviewed by Adam Barth.
2448
2449         run platform/chromium/plugins/refcount-leaks.html on all platforms
2450         https://bugs.webkit.org/show_bug.cgi?id=49485
2451
2452         Add PluginObject.testObjectCount which returns the number of allocated
2453         TestObjects. Add PluginObject.testCreateTestObject which allocates
2454         and returns a TestObject.
2455
2456         Add TestObject.refCount which returns the number of refs on the
2457         TestObject.
2458
2459         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2460         (pluginGetProperty):
2461         (pluginInvoke):
2462         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
2463         (getTestObjectCount):
2464         (testAllocate):
2465         (testDeallocate):
2466         (testGetProperty):
2467         (testScriptObjectInvoke): Release a ref to a plugin object that was
2468             previously leaked.
2469         * DumpRenderTree/TestNetscapePlugIn/TestObject.h:
2470
2471 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
2472
2473         Reviewed by Adam Roben.
2474
2475         WebKitTools projects (WebKitTestRunner, record-memory-win) should use vsprops for common build settings
2476         https://bugs.webkit.org/show_bug.cgi?id=49711
2477
2478         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added.
2479         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added.
2480         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added.
2481         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2482         * record-memory-win/record-memory-win-common.vsprops: Added.
2483         * record-memory-win/record-memory-win.vcproj:
2484
2485 2010-11-18  Andras Becsi  <abecsi@inf.u-szeged.hu>
2486
2487         Reviewed by Csaba Osztrogonác.
2488
2489         [Qt][WK2] Only add user agent strings to the list which aren't listed yet.
2490
2491         * MiniBrowser/qt/BrowserWindow.cpp:
2492         (BrowserWindow::updateUserAgentList):
2493
2494 2010-11-17  Adam Roben  <aroben@apple.com>
2495
2496         Don't trigger Windows builds when chromium-win test results change
2497
2498         Reviewed by Mark Rowe.
2499
2500         * Scripts/webkitpy/common/config/build.py:
2501         (_should_file_trigger_build): Changed the regular expression used to
2502         search for directory names to only consider full directory names,
2503         rather than matching directory names where the string we care about is
2504         a suffix of the name.
2505
2506         * Scripts/webkitpy/common/config/build_unittest.py:
2507         (ShouldBuildTest): Added a test.
2508
2509 2010-11-17  Hayato Ito  <hayato@chromium.org>
2510
2511         Reviewed by Shinichiro Hamaji.
2512
2513         Remove a uri member from TestInput class.
2514
2515         https://bugs.webkit.org/show_bug.cgi?id=49691
2516
2517         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2518         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2519
2520 2010-11-17  Adam Roben  <aroben@apple.com>
2521
2522         Move FindSafari's settings into a vsprops file
2523
2524         Fixes <http://webkit.org/b/49699> FindSafari should use a vsprops file
2525
2526         Reviewed by Steve Falkenburg.
2527
2528         * FindSafari/FindSafari.vcproj:
2529         * FindSafari/FindSafariCommon.vsprops: Added.
2530
2531 2010-11-17  Adam Roben  <aroben@apple.com>
2532
2533         Use a minimum font size of 0 in DRT on Windows
2534
2535         This is the Windows equivalent of r72164.
2536
2537         Rubber-stamped by Dave Hyatt.
2538
2539         * DumpRenderTree/win/DumpRenderTree.cpp:
2540         (resetDefaultsToConsistentValues):
2541
2542 2010-11-17  Dirk Pranke  <dpranke@chromium.org>
2543
2544         Reviewed by Andreas Kling.
2545
2546         webkit-patch pretty-diff shouldn't need to be run from a checkout root in git
2547         https://bugs.webkit.org/show_bug.cgi?id=49639
2548
2549         * Scripts/webkitpy/common/checkout/scm.py:
2550
2551 2010-11-17  Mihai Parparita  <mihaip@chromium.org>
2552
2553         Reviewed by Tony Chang.
2554
2555         Rebaseline server: add loupe for image diffs
2556         https://bugs.webkit.org/show_bug.cgi?id=49692
2557         
2558         Add a loupe (magnifiying glass) for inspecting image diffs. Shows an
2559         enlarged area of the expected, actual and diff images side by side.
2560
2561         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
2562         * Scripts/webkitpy/tool/commands/data/rebaselineserver/loupe.js: Added.
2563         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2564         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2565
2566 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
2567
2568         Reviewed by Adam Roben.
2569
2570         WebKitLauncherWin should use vsprops for shared build settings
2571         https://bugs.webkit.org/show_bug.cgi?id=49696
2572
2573         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
2574         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added.
2575
2576 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
2577
2578         Reviewed by Adam Roben.
2579
2580         WinLauncher should use vsprops for shared build settings
2581         https://bugs.webkit.org/show_bug.cgi?id=49695
2582
2583         * WinLauncher/WinLauncher.cpp:
2584         (_tWinMain):
2585         (PrintView):
2586         (WndProc):
2587         (MyEditProc):
2588         * WinLauncher/WinLauncher.vcproj:
2589         * WinLauncher/WinLauncherCommon.vsprops: Added.
2590
2591 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
2592
2593         Delete unused file unintentionally added in last change.
2594
2595         * DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Removed.
2596
2597 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
2598
2599         Reviewed by Adam Roben.
2600
2601         DumpRenderTree on Windows should use a vsprops file for shared project settings
2602         https://bugs.webkit.org/show_bug.cgi?id=49690
2603
2604         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2605         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added.
2606         * DumpRenderTree/win/DumpRenderTree.vcproj:
2607         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added.
2608         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added.
2609         * DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Added.
2610         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added.
2611         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added.
2612         * DumpRenderTree/win/ImageDiff.vcproj:
2613         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added.
2614
2615 2010-11-17  Hayato Ito  <hayato@chromium.org>
2616
2617         Refactor TestTypeBase.compare_output().
2618
2619         Introduce a TestOutput class and update compare_output() of each test
2620         types so that they can take both actual and expected TestOutput objects.
2621
2622         https://bugs.webkit.org/show_bug.cgi?id=49431
2623
2624         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2625         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Added.
2626         * Scripts/webkitpy/layout_tests/port/base.py:
2627         * Scripts/webkitpy/layout_tests/port/chromium.py:
2628         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2629         * Scripts/webkitpy/layout_tests/port/test.py:
2630         * Scripts/webkitpy/layout_tests/port/webkit.py:
2631         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2632         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2633         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2634         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2635
2636 2010-11-17  Adam Roben  <aroben@apple.com>
2637
2638         Make each Windows Test builder use the same OS for all its slaves
2639
2640         Currently each WebKit1 Windows Test builder has one Windows XP slave
2641         and one Windows 7 slave. Having different OSes in a single builder
2642         meant that the builders would alternate between red and green when
2643         there were OS-specific failures.
2644
2645         Fixes <http://webkit.org/b/49688> Windows Test builders alternate
2646         between red and green because of multiple OS versions
2647
2648         Reviewed by Mark Rowe.
2649
2650         * BuildSlaveSupport/build.webkit.org-config/config.json: Renamed
2651         "Windows Release (Tests)" to "Windows 7 Release (Tests)", "Windows
2652         Debug (Tests)" to "Windows XP Debug (Tests)", and "Windows Release
2653         (WebKit2 Tests)" to "Windows 7 Release (WebKit2 Tests)". Updated the
2654         builders for the two WebKit1 builders so that they would all use the
2655         appropriate OS.
2656
2657 2010-11-17  James Robinson  <jamesr@chromium.org>
2658
2659         Reviewed by Dan Bernstein.
2660
2661         [chromium] Set minimum font size to 0 for DRT
2662         https://bugs.webkit.org/show_bug.cgi?id=49677
2663
2664         Followup for http://trac.webkit.org/changeset/72141.
2665
2666         Test: http/tests/misc/acid3.html
2667
2668         * DumpRenderTree/chromium/WebPreferences.cpp:
2669         (WebPreferences::reset):
2670
2671 2010-11-17  Andras Becsi  <abecsi@webkit.org>
2672
2673         Unreviewed build fix.
2674
2675         [Qt] Add missing file I forgot in r72220.
2676
2677         * MiniBrowser/MiniBrowser.qrc: Added.
2678
2679 2010-11-17  Andras Becsi  <abecsi@webkit.org>
2680
2681         Reviewed by Andreas Kling.
2682
2683         [Qt][WK2] Make it possible to set custom user agent strings in MiniBrowser.
2684         https://bugs.webkit.org/show_bug.cgi?id=49627
2685
2686         Add a user agent dialog and a resource file for useragentlist.txt to MiniBrowser.
2687
2688         * MiniBrowser/MiniBrowser.qrc: Added.
2689         Add it here to prevent qmake from detecting it
2690         since it needs to be copied to the build directory.
2691         * MiniBrowser/qt/BrowserWindow.cpp:
2692         (BrowserWindow::BrowserWindow):
2693         (BrowserWindow::updateUserAgentList):
2694         (BrowserWindow::showUserAgentDialog):
2695         * MiniBrowser/qt/BrowserWindow.h:
2696         * MiniBrowser/qt/MiniBrowser.pro:
2697
2698 2010-11-17  Adam Roben  <aroben@apple.com>
2699
2700         Make changes to the Mac WebKit2 Skipped file trigger Windows builds
2701
2702         We use that file on Windows!
2703
2704         Fixes <http://webkit.org/b/49643> Changes to
2705         LayoutTests/platform/mac-wk2 should trigger a Windows build, but don't
2706
2707         Reviewed by Steve Falkenburg.
2708
2709         * Scripts/webkitpy/common/config/build.py:
2710         (_should_file_trigger_build): Added the mac-wk2 directory and make it
2711         trigger builds on SnowLeopard and Windows.
2712
2713         * Scripts/webkitpy/common/config/build_unittest.py:
2714         (ShouldBuildTest.test_should_build): Added a test.
2715
2716 2010-11-17  Satish Sampath  <satish@chromium.org>
2717
2718         Reviewed by Jeremy Orlow.
2719
2720         Clear the speech input mock explicitly before each test.
2721         https://bugs.webkit.org/show_bug.cgi?id=49660
2722
2723         * DumpRenderTree/chromium/LayoutTestController.cpp:
2724         (LayoutTestController::setMockSpeechInputResult):
2725         * DumpRenderTree/chromium/LayoutTestController.h:
2726         * DumpRenderTree/chromium/WebViewHost.cpp:
2727         (WebViewHost::speechInputController):
2728         (WebViewHost::reset): Invoke speech input mock's clearResults method.
2729         * DumpRenderTree/chromium/WebViewHost.h:
2730         (WebViewHost::speechInputControllerMock): Moved mock from LayoutTestController.
2731
2732 2010-11-17  Alexander Pavlov  <apavlov@chromium.org>
2733
2734         Unreviewed, specify IRC nickname in committers.py.
2735
2736         * Scripts/webkitpy/common/config/committers.py:
2737
2738 2010-11-17  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2739
2740         Reviewed by Tony Chang.
2741
2742         [NRWT] Make http locking similar to perl implementation
2743         https://bugs.webkit.org/show_bug.cgi?id=49187
2744
2745         * Scripts/webkitpy/common/system/file_lock.py: Added.
2746         * Scripts/webkitpy/common/system/file_lock_unittest.py: Added.
2747         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2748
2749 2010-11-17  MORITA Hajime  <morrita@google.com>
2750
2751         Reviewed by Kent Tamura.
2752
2753         [Chromium][DRT] EventSender.contextClick() should aware spellchecking
2754         https://bugs.webkit.org/show_bug.cgi?id=49366
2755
2756         - EvenSender: Checked WebContextMenuData.misspelledWord and added extra context menu entries
2757           according to the spellchecker suggestion
2758         - MockSpellCheck: add fillSuggestionList to provide fake suggestions.
2759
2760         test_expectations.txt will be changed after this change is ported to test_shell.
2761         
2762         * DumpRenderTree/chromium/EventSender.cpp:
2763         (makeMenuItemStringsFor):
2764         (EventSender::contextClick):
2765         * DumpRenderTree/chromium/MockSpellCheck.cpp:
2766         (MockSpellCheck::fillSuggestionList):
2767         (MockSpellCheck::initializeIfNeeded):
2768         * DumpRenderTree/chromium/MockSpellCheck.h:
2769         * DumpRenderTree/chromium/WebViewHost.cpp:
2770         (WebViewHost::mockSpellCheck):
2771         * DumpRenderTree/chromium/WebViewHost.h:
2772
2773 2010-11-16  Dave Hyatt  <hyatt@apple.com>
2774
2775         Reviewed by Sam Weinig.
2776
2777         Make sure the pref for minimum font size is just explicitly set to 0 every time,
2778         since the bots have 1 stuck in their plist otherwise.
2779
2780         * DumpRenderTree/mac/DumpRenderTree.mm:
2781         (resetDefaultsToConsistentValues):
2782
2783 2010-11-16  Mihai Parparita  <mihaip@chromium.org>
2784
2785         Reviewed by Tony Chang.
2786
2787         Rebaseline server: compute diffs client-side
2788         https://bugs.webkit.org/show_bug.cgi?id=49640
2789         
2790         The image diff output from the DRT is pretty bad on some ports (at
2791         least the Mac one), so it's better to compute diffs on the client by
2792         using <canvas>.
2793
2794         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
2795         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2796         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2797
2798 2010-11-16  Mihai Parparita  <mihaip@chromium.org>
2799
2800         Reviewed by Tony Chang.
2801
2802         Rebaseline server: display test results
2803         https://bugs.webkit.org/show_bug.cgi?id=49626
2804         
2805         Adds basic result display to the rebaseline server. On the Python side
2806         this involves:
2807         - Parsing the unexpected_results.json into a dictionary.
2808         - Serving it as JSON under /results.json.
2809         (the JSON -> dict -> JSON transform isn't strictly necessary right now,
2810         but I'll need to have access to the parsed results on the Python side
2811         for follow-up changes).
2812         
2813         On the web UI side this adds:
2814         - Markup for display image and text results (expected, actual, diff),
2815           and JS for populating it.
2816         - Markup for breaking down test results by failure type and directory,
2817           and JS for populating it.
2818
2819         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
2820         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2821         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2822         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js: Added.
2823         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2824
2825 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
2826
2827         Reviewed by Ojan Vafai.
2828
2829         See Chromium issue http://codereview.chromium.org/5133001/ - we
2830         are modifying the build bots to pass in the builder name with
2831         the "GPU" string appended instead of appending it in the code.
2832
2833         https://bugs.webkit.org/show_bug.cgi?id=49636
2834
2835         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2836
2837 2010-11-16  Steve Falkenburg  <sfalken@apple.com>
2838
2839         Reviewed by Adam Roben.
2840
2841         Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
2842         https://bugs.webkit.org/show_bug.cgi?id=49632
2843
2844         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2845         * DumpRenderTree/win/DumpRenderTree.vcproj:
2846         * DumpRenderTree/win/ImageDiff.vcproj:
2847         * MiniBrowser/MiniBrowser.vcproj:
2848         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2849         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
2850         * WebKitTestRunner/win/InjectedBundle.vcproj:
2851         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2852         * WinLauncher/WinLauncher.vcproj:
2853         * record-memory-win/record-memory-win.vcproj:
2854
2855 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
2856
2857         Reviewed by Ojan Vafai.
2858
2859         new-run-webkit-tests: rename TestInfo to TestInput, move image hash to work thread
2860
2861         Rename the TestInfo class to TestInput to be clearer about its
2862         function, and move the checksum-reading code into dump_render_tree_thread
2863         to avoid cross-thread access.
2864
2865         https://bugs.webkit.org/show_bug.cgi?id=49573
2866
2867         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2868         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2869         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2870
2871 2010-11-16  Dave Hyatt  <hyatt@apple.com>
2872
2873         Fix bustage. Remove the minimum font size pref setting in DumpRenderTree.
2874
2875         * DumpRenderTree/mac/DumpRenderTree.mm:
2876         (resetDefaultsToConsistentValues):
2877
2878 2010-11-16  Stephanie Lewis  <slewis@apple.com>
2879
2880         Reviewed by Geoff Garen.
2881
2882         <rdar://problem/8624267> Leak creating offscreen webview running fast/dom tests
2883
2884         Use shared DeviceOrientationProviderMock. The old allocation method created a new WebDeviceOrientationProviderMock 
2885         for every WebView, and the WebKit API doesn't support that ownership model.
2886
2887         I also fixed a leak in setMockDeviceOrientation by adding a missing release.
2888
2889         * DumpRenderTree/mac/DumpRenderTree.mm:
2890         (createWebViewAndOffscreenWindow):
2891         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2892         (LayoutTestController::setMockDeviceOrientation):
2893
2894 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
2895
2896         Reviewed by Ojan Vafai.
2897
2898         new-run-webkit-tests: log the process id in --verbose mode
2899
2900         As part of the switch to multi-process mode, we should log the
2901         process id when running w/ --verbose.
2902
2903         https://bugs.webkit.org/show_bug.cgi?id=49571
2904
2905         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2906
2907 2010-11-16  Adam Roben  <aroben@apple.com>
2908
2909         Only trigger Windows builds when files that we actually use on Windows
2910         are changed
2911
2912         A new Scheduler subclass, PlatformSpecificScheduler, has been added.
2913         It uses the new webkitpy.common.config.build module to determine
2914         whether a particular change should trigger a build on a particular
2915         platform. The Windows builders have been switched to use a
2916         PlatformSpecificScheduler.
2917
2918         The logic to determine whether or not a particular change should
2919         trigger a build on a given platform has only been implemented/tested
2920         for Windows. I tried to make it easy to add more platforms in the
2921         future, but I don't have enough familiarity with all platforms to be
2922         able to implement it for them.
2923
2924         Fixes <http://webkit.org/b/49407> Windows builders kick off builds for
2925         lots irrelevant changes (e.g., rebaselining Chromium test results)
2926
2927         Reviewed by Eric Seidel.
2928
2929         * BuildSlaveSupport/build.webkit.org-config/config.json: Use a
2930         PlatformSpecificScheduler for the Windows builders.
2931
2932         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2933         (PlatformSpecificScheduler.__init__): Added. Stores our platform, sets
2934         up a ChangeFilter that filters to our branch and will call through to
2935         our filter method, and calls up to our base class.
2936         (PlatformSpecificScheduler.filter): Calls through to
2937         build.should_build to find out whether we should trigger a build for
2938         this change.
2939
2940         * Scripts/webkitpy/common/net/build.py: Added.
2941         (_should_file_trigger_build): Uses a set of directories and regexp
2942         patterns to determine whether the given file should trigger a build on
2943         the given platform. As mentioned earlier, this has only been
2944         implemented for Windows, though I did try to make some guesses about
2945         other platforms.
2946         (should_build): Returns true if any of the files should trigger a
2947         build on the given platform.
2948
2949         * Scripts/webkitpy/common/net/build_unittest.py: Added.
2950         (ShouldBuildTest.test_should_build): Does some basic testing to make
2951         sure we're triggering builds for the right files. It only tests
2952         Windows for now, though I tried to make some guesses about other
2953         platforms.
2954
2955 2010-11-16  Simon Hausmann  <simon.hausmann@nokia.com>
2956
2957         Reviewed by Andreas Kling.
2958
2959         [Qt] Remove synchronous QWebPage::checkPermissions signal
2960         https://bugs.webkit.org/show_bug.cgi?id=46810
2961
2962         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2963         (WebCore::WebPage::WebPage):
2964         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2965         (LayoutTestController::grantDesktopNotificationPermission): When granting
2966         permission, grant it directly on the QWebPage/Frame, that will remember it.
2967         * QtTestBrowser/webpage.cpp:
2968         (WebPage::WebPage):
2969         * QtTestBrowser/webpage.h:
2970
2971
2972 2010-11-16  Andras Becsi  <abecsi@inf.u-szeged.hu>
2973
2974         Reviewed by Csaba Osztrogonác.
2975
2976         [Qt] Add isPrinting and setPrinting methods to DRT's LayoutTestController.
2977
2978         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2979         (LayoutTestController::reset):
2980         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2981         (LayoutTestController::isPrinting):
2982         (LayoutTestController::setPrinting):
2983
2984 2010-11-16  Balazs Kelemen  <kbalazs@webkit.org>
2985
2986         Reviewed by Andreas Kling.
2987
2988         [Qt][WK2] Add a way to turn on tiled backing store in MiniBrowser
2989         https://bugs.webkit.org/show_bug.cgi?id=49587
2990
2991         * MiniBrowser/qt/BrowserView.cpp:
2992         (BrowserView::BrowserView): Added BackingStoreType
2993         argument to ctor. Propagating it to the QGraphicsWKView.
2994         * MiniBrowser/qt/BrowserView.h:
2995         * MiniBrowser/qt/BrowserWindow.cpp:
2996         (BrowserWindow::BrowserWindow):
2997         (BrowserWindow::newWindow): Create the new BrowserWindow
2998         with the same BackingStoreType that this instance has.
2999         * MiniBrowser/qt/BrowserWindow.h: Added BackingStoreType member.
3000         * MiniBrowser/qt/main.cpp:
3001         (main): Use tiled backing store if got -tiled command line argument.
3002         Avoid redundant copy of command line args.
3003
3004 2010-11-16  John Knottenbelt  <jknotten@chromium.org>
3005
3006         Reviewed by Jeremy Orlow.
3007
3008         Move DeviceOrientationClientMock from LayoutTestController to WebViewHost.
3009         https://bugs.webkit.org/show_bug.cgi?id=48506
3010
3011         This ensures that there is one mock per page WebView / WebViewHost. This is a
3012         design constraint of the DeviceOrientationClientMock because the m_controller
3013         field can only store a pointer to a single instance of the corresponding
3014         DeviceOrientationController.
3015
3016         Test: fast/dom/DeviceOrientation/no-page-cache.html
3017
3018         * DumpRenderTree/chromium/LayoutTestController.cpp:
3019         (LayoutTestController::setMockDeviceOrientation):
3020         (LayoutTestController::deviceOrientationClientMock):
3021         * DumpRenderTree/chromium/LayoutTestController.h:
3022         * DumpRenderTree/chromium/WebViewHost.cpp:
3023         (WebViewHost::deviceOrientationClientMock):
3024         (WebViewHost::deviceOrientationClient):
3025         (WebViewHost::reset):
3026         * DumpRenderTree/chromium/WebViewHost.h:
3027
3028 2010-11-15  Andras Becsi  <abecsi@webkit.org>
3029
3030         Reviewed by Andreas Kling.
3031
3032         [Qt][WK2] Avoid polling in WebKitTestRunner.
3033         https://bugs.webkit.org/show_bug.cgi?id=49542
3034
3035         Make the WK2 testing session about 10-15% faster and decrease random flakiness
3036         resulting from timing skew by removing the millisecond polling from TestControllerQt.
3037
3038         * WebKitTestRunner/TestController.cpp:
3039         (WTR::TestController::didFinishLoadForFrame):
3040         * WebKitTestRunner/TestController.h:
3041         * WebKitTestRunner/TestInvocation.cpp:
3042         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3043         * WebKitTestRunner/mac/TestControllerMac.mm:
3044         (WTR::TestController::notifyDone): Add method stub.
3045         * WebKitTestRunner/qt/TestControllerQt.cpp:
3046         (WTR::TestControllerRunLoop::instance):
3047         (WTR::TestControllerRunLoop::start):
3048         (WTR::TestControllerRunLoop::stop):
3049         (WTR::TestControllerRunLoop::TestControllerRunLoop):
3050         (WTR::TestControllerRunLoop::timerEvent):
3051         (WTR::TestController::notifyDone):
3052         (WTR::TestController::platformRunUntil):
3053         * WebKitTestRunner/win/TestControllerWin.cpp:
3054         (WTR::TestController::notifyDone): Add method stub.
3055
3056 2010-11-15  Darin Adler  <darin@apple.com>
3057
3058         * Scripts/webkitpy/common/net/bugzilla: Added property svn:ignore.
3059
3060 2010-11-15  Benjamin Poulain  <benjamin.poulain@nokia.com>
3061
3062         Reviewed by Andreas Kling.
3063
3064         [Qt] [WK2] Add Ctrl+L shortcut to Qt Minibrowser
3065         https://bugs.webkit.org/show_bug.cgi?id=49544
3066
3067         Add the shortcut to BrowserWindow.
3068
3069         * MiniBrowser/qt/BrowserWindow.cpp:
3070         (BrowserWindow::BrowserWindow):
3071         (BrowserWindow::openLocation):
3072         * MiniBrowser/qt/BrowserWindow.h:
3073
3074 2010-11-14  David Levin  <levin@chromium.org>
3075
3076         Reviewed by Daniel Bates.
3077
3078         check-webkit-style should detect PassRefPtr usage in functions.
3079         https://bugs.webkit.org/show_bug.cgi?id=49513
3080
3081         * Scripts/webkitpy/style/checkers/cpp.py:
3082         (check_for_function_lengths): Revert a comment change that I
3083          accidentally made in r71986.
3084         (check_pass_ptr_usage): Added the code to do the check.
3085         (process_line): Added the call to check_pass_ptr_usage.
3086         (CppChecker): Added the new error category.
3087         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3088         (CppStyleTestBase::perform_pass_ptr_check): Runs the new check for
3089          testing purposes.
3090         (PassPtrTest::*): The class/functions to unit test the new
3091          functionality.
3092
3093 2010-11-14  David Levin  <levin@chromium.org>
3094
3095         Reviewed by Shinichiro Hamaji.
3096
3097         check-webkit-style function detection and the line count style checks should be separate.
3098         https://bugs.webkit.org/show_bug.cgi?id=49512
3099
3100         * Scripts/webkitpy/style/checkers/cpp.py: Do the separation.
3101         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Adjust the test to
3102           call the detection function and fix line counts in two places now that
3103           the code really only counts the lines in the body of the function.
3104
3105 2010-11-14  Andreas Kling  <kling@webkit.org>
3106
3107         Reviewed by Antonio Gomes.
3108
3109         http/tests/plugins tests print "Unhandled variable" to stderr under Qt
3110         https://bugs.webkit.org/show_bug.cgi?id=33438
3111
3112         Stifle "Unhandled variable" warning to match what the other
3113         TestNetscapePlugin does (NPP_GetValue in TestNetscapePlugIn/main.cpp
3114         simply returns NPERR_GENERIC_ERROR for unhandled variables.)
3115
3116         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3117         (webkit_test_plugin_get_value):
3118
3119 2010-11-13  David Levin  <levin@chromium.org>
3120
3121         Reviewed by Eric Seidel.
3122
3123         check-webkit-style function detection crashes on functions in templates.
3124         https://bugs.webkit.org/show_bug.cgi?id=49504
3125
3126         For example "template <bool shouldClose(const Element*)>".
3127
3128         * Scripts/webkitpy/style/checkers/cpp.py: If not function is detected, bail out.
3129         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Modified the complex
3130           function detection test to expose this issue.
3131
3132 2010-11-12  David Levin  <levin@chromium.org>
3133
3134         Reviewed by Shinichiro Hamaji.
3135
3136         check-webkit-style function detection doesn't detect indented functions declaractions.
3137         https://bugs.webkit.org/show_bug.cgi?id=49446
3138
3139         Indented function declarations occur inside class definitions, so
3140         they are a pretty common (and worth detecting).
3141
3142         * Scripts/webkitpy/style/checkers/cpp.py:
3143           Changed regex to allow indentation.
3144           Changed the function start detection to only happen when not in a
3145           function.
3146           Changed function end detection to work based on matching braces
3147           instead of finding a close brace at the beginning of the line.
3148           Fixed close_expression to do what it says when it doesn't find
3149           the close.
3150         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Indented function test.
3151
3152 2010-11-12  Daniel Bates  <dbates@rim.com>
3153
3154         Rubber-stamped by Nikolas Zimmermann.
3155
3156         Make do-file-rename rename files in the directory WebKit2.
3157
3158         This also makes the list of searched directories in do-file-rename
3159         consistent with the list of searched directories in the script do-webcore-rename.
3160
3161         * Scripts/do-file-rename:
3162
3163 2010-11-12  Dirk Pranke  <dpranke@chromium.org>
3164
3165         Reviewed by James Robinson.
3166
3167         Attempt yet again to land the fix for bug 49360 (respecting
3168         set-webkit-configuration). We need to handle the cases where
3169         trying to run webkit-build-directory to find out where the
3170         default configuration might be fails (that shows up on some
3171         Chromium bots that apparently don't have perl installed).
3172
3173         https://bugs.webkit.org/show_bug.cgi?id=49360
3174
3175         * Scripts/webkitpy/layout_tests/port/config.py:
3176         * Scripts/webkitpy/layout_tests/port/config_standalone.py: Added.
3177         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3178
3179 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
3180
3181         Reviewed by Adam Barth.
3182
3183         webkit-patch land logs commit message twice
3184         https://bugs.webkit.org/show_bug.cgi?id=49482
3185         
3186         Don't log the comment that's used by bugzilla.close_bug_as_fixed, since
3187         that's just the commit message, which we now output following the
3188         actual commit.
3189
3190         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3191
3192 2010-11-12  Tony Chang  <tony@chromium.org>
3193
3194         Reviewed by Adam Barth.
3195
3196         run platform/chromium/plugins/script-object-invoke.html on all platforms
3197         https://bugs.webkit.org/show_bug.cgi?id=49280
3198
3199         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3200         (testScriptObjectInvoke):
3201         (pluginInvoke):
3202
3203 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
3204
3205         Reviewed by Adam Barth.
3206
3207         webkit-patch land-cowboy (and other commands) should display the committed SVN revision after landing a patch
3208         https://bugs.webkit.org/show_bug.cgi?id=49471
3209
3210         Right now there's no indication of a successful commit.
3211         
3212         * Scripts/webkitpy/tool/commands/download_unittest.py:
3213         * Scripts/webkitpy/tool/steps/commit.py:
3214
3215 2010-11-12  Kinuko Yasuda  <kinuko@chromium.org>
3216
3217         Reviewed by Ojan Vafai.
3218
3219         Include detailed test modifiers in results.json and enable incremental uploading for non-layout tests
3220         https://bugs.webkit.org/show_bug.cgi?id=49354
3221
3222         Also moved/integrated the upload method from run_webkit_tests.py to json_results_generator.py.
3223
3224         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3225         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3226         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3227         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3228
3229 2010-11-12  Tony Chang  <tony@chromium.org>
3230
3231         Reviewed by Kent Tamura.
3232
3233         [chromium] Load a blank page when closing DRT WebViewHosts
3234         https://bugs.webkit.org/show_bug.cgi?id=49417
3235
3236         In test_shell, when we close a window, we first load about:blank
3237         and run GC to fire the destruction logic of the page.  In test_shell,
3238         this happens in ~TestShell.  In DRT, we manage virtual windows as
3239         WebViewHosts, so we need to replicate this logic in ~WebViewHost.
3240
3241         Managing focus is a bit trickier, since normally you would get window
3242         events to reset the focus to the right window.  We do it manually
3243         instead.
3244
3245         This fixes 2 plugin tests on DRT.
3246
3247         * DumpRenderTree/chromium/TestShell.cpp:
3248         (TestShell::~TestShell): Move window close logic to ~WebViewHost.
3249         (TestShell::closeWindow): Move widget close() to WVH destructor and
3250             manage focus manually.
3251         (TestShell::closeRemainingWindows): Comment typo.
3252         * DumpRenderTree/chromium/WebViewHost.cpp:
3253         (WebViewHost::closeWidget):
3254         (invokeCloseWidget):
3255         (WebViewHost::closeWidgetSoon): Close the window asynchronously (matches
3256             test_shell).
3257         (WebViewHost::~WebViewHost):
3258         * DumpRenderTree/chromium/WebViewHost.h:
3259
3260 2010-11-12  David Levin  <levin@chromium.org>
3261
3262         Reviewed by Adam Barth.
3263
3264         cpp.py needs some tidying.
3265         https://bugs.webkit.org/show_bug.cgi?id=49443
3266
3267         * Scripts/webkitpy/style/checkers/cpp.py:
3268           Fix parameter ordering for iteratively_replace_matches_with_char
3269           to mirror other similar functions (and improved comments, etc.)
3270           Also, use a python-ism (for/else) to get rid of a variable that
3271           was there to determine if something had been found in the loop.
3272
3273 2010-11-12  Robert Kroeger  <rjkroege@chromium.org>
3274
3275         Reviewed by James Robinson.
3276
3277         [Chromium/DRT] Make EventSendingController send complete touch events.
3278         https://bugs.webkit.org/show_bug.cgi?id=49285
3279
3280         * DumpRenderTree/chromium/EventSender.cpp:
3281         (EventSender::addTouchPoint):
3282         (EventSender::updateTouchPoint):
3283         (EventSender::sendCurrentTouchEvent):
3284
3285 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
3286
3287         Unreviewed rollout of r71858.
3288
3289         Rollout out r71858 since it breaks new-run-webkit-httpd as used by the
3290         NaCl tests.
3291
3292         * Scripts/webkitpy/layout_tests/port/config.py:
3293         * Scripts/webkitpy/layout_tests/port/config_standalone.py: Removed.
3294         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3295
3296 2010-11-12  Benjamin Poulain  <benjamin.poulain@nokia.com>
3297
3298         Reviewed by Kenneth Rohde Christiansen.
3299
3300         [Qt] TestController::runUntil doesn't honor the timeout parameter
3301         https://bugs.webkit.org/show_bug.cgi?id=48941
3302
3303         Implement the missing timeout of WebKitTestRunner for Qt.
3304
3305         A QElapsedTimer has been added to RunUntilConditionLoop in order
3306         to measure how long the loop has been running. When the timer
3307         is bigger or equal than the timeout, the loop ends even if the
3308         condition is not met.
3309
3310         * WebKitTestRunner/qt/TestControllerQt.cpp:
3311         (WTR::RunUntilConditionLoop::start):
3312         (WTR::RunUntilConditionLoop::run):
3313         (WTR::RunUntilConditionLoop::timerEvent):
3314         (WTR::TestController::platformRunUntil):
3315
3316 2010-11-11  David Levin  <levin@chromium.org>
3317
3318         Reviewed by Shinichiro Hamaji.
3319
3320         check-webkit-style function detection doesn't handle templates with spaces.
3321         https://bugs.webkit.org/show_bug.cgi?id=49427
3322
3323         * Scripts/webkitpy/style/checkers/cpp.py: Stripped out templates when
3324           finding the function name.
3325         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Made the test have a
3326           template with a space.
3327
3328 2010-11-11  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
3329
3330         Reviewed by Shinichiro Hamaji.
3331
3332         Enable check-webkit-style on Qt files
3333         https://bugs.webkit.org/show_bug.cgi?id=48322
3334
3335         Adding exception for _q_... private slots and
3336         ..._data() methods in tests
3337
3338         * Scripts/webkitpy/style/checker.py: enable Qt dirs, add exceptions
3339         * Scripts/webkitpy/style/checker_unittest.py: improve unittests
3340
3341 2010-11-11  David Levin  <levin@chromium.org>
3342
3343         Reviewed by Shinichiro Hamaji.
3344
3345         check-webkit-style function detection doesn't work for templates and destructors.
3346         https://bugs.webkit.org/show_bug.cgi?id=49425
3347
3348         * Scripts/webkitpy/style/checkers/cpp.py: Changed regex for templates and destructors.
3349         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Made the test hit this issue.
3350
3351 2010-11-11  Joone Hur  <joone@kldp.org>
3352
3353         Reviewed by Antonio Gomes.
3354
3355         [GTK][DRT] Implement LayoutTestController::nodesFromRect
3356         https://bugs.webkit.org/show_bug.cgi?id=46598
3357
3358         Support nodesFromRect in DRT
3359
3360         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3361         (LayoutTestController::nodesFromRect):
3362
3363 2010-11-11  MORITA Hajime  <morrita@google.com>
3364
3365         Reviewed by Kent Tamura.
3366
3367         editing/selection/context-menu-on-text.html fails on chromium
3368         https://bugs.webkit.org/show_bug.cgi?id=45898
3369
3370         Enhance Chromium's EventSender::contextClick() to return
3371         array of menu strings. The implementation incomplete because
3372         Although actual context menu is implemented by the browser,
3373         it reflects editability of underlying context thus makes
3374         context-menu-on-text.html passed.
3375         
3376         * DumpRenderTree/chromium/EventSender.cpp:
3377         (makeMenuItemStringsFor): Added.
3378         (EventSender::contextClick): Now returns array of menu strings.
3379         * DumpRenderTree/chromium/WebViewHost.cpp:
3380         (WebViewHost::showContextMenu): Now storing given WebContextMenuData object.
3381         (WebViewHost::clearContextMenuData): Added.
3382         (WebViewHost::lastContextMenuData): Added.
3383         * DumpRenderTree/chromium/WebViewHost.h:
3384
3385 2010-11-11  Dirk Pranke  <dpranke@chromium.org>
3386
3387         Unreviewed, build fix.
3388
3389         fix build breakage caused by fix for bug 49380 (r71858).
3390
3391         config_standalone needs to ensure that the packages it needs are
3392         in sys.path.
3393
3394         https://bugs.webkit.org/show_bug.cgi?id=49419
3395
3396         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
3397
3398 2010-11-11  Dirk Pranke  <dpranke@chromium.org>
3399
3400         Reviewed by Adam Roben.
3401
3402         Fix NRWT to respect set-webkit-configuration again :(
3403
3404         This change fixes a typo in config.py that was causing the wrong
3405         value to be read initially and us never actually looking into
3406         the filesystem to get the default configuration.
3407         
3408         * Scripts/webkitpy/layout_tests/port/config.py:
3409         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
3410         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3411
3412 2010-11-11  Eric Seidel  <eric@webkit.org>
3413
3414         Reviewed by Adam Barth.
3415
3416         Split out Bug, Attachment and CommitterValidator from bugzilla.py
3417         https://bugs.webkit.org/show_bug.cgi?id=49403
3418
3419         CommitterValidator really had nothing to do with bugzilla.py.
3420         I've put it next to committers.py for now since its rather tied to that file.
3421
3422         * Scripts/webkitpy/common/config/committervalidator.py: Added.
3423         * Scripts/webkitpy/common/config/committervalidator_unittest.py: Added.
3424         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
3425         * Scripts/webkitpy/common/net/bugzilla/attachment.py: Added.
3426         * Scripts/webkitpy/common/net/bugzilla/bug.py: Added.
3427         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py: Added.
3428         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3429         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3430         * Scripts/webkitpy/tool/bot/feeders.py:
3431         * Scripts/webkitpy/tool/commands/queues.py:
3432
3433 2010-11-11  Dirk Pranke  <dpranke@chromium.org>
3434
3435         Reviewed by Eric Seidel.
3436
3437         fix missing 'pid' argument for http lockfile checking on win32
3438         https://bugs.webkit.org/show_bug.cgi?id=49363
3439
3440         * Scripts/webkitpy/common/system/executive.py:
3441
3442 2010-11-11  Eric Seidel  <eric@webkit.org>
3443
3444         Rubber-stamped by Adam Barth.
3445
3446         Move bugzilla.py into its own module in preparation for splitting one-file-per-class
3447         https://bugs.webkit.org/show_bug.cgi?id=49402
3448
3449         * Scripts/webkitpy/common/net/bugzilla/__init__.py: Added.
3450         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/bugzilla.py.
3451         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/bugzilla_unittest.py.
3452
3453 2010-11-10  Chris Guillory  <chris.guillory@google.com>
3454
3455         Reviewed by Chris Fleizach.
3456
3457         Use IAccessibleComparable to compare accessibility objects.
3458         https://bugs.webkit.org/show_bug.cgi?id=49118
3459
3460         * DumpRenderTree/AccessibilityUIElement.cpp:
3461         (AccessibilityUIElement::isEqual):
3462         * DumpRenderTree/AccessibilityUIElement.h:
3463         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3464         (comparableObject):
3465         (AccessibilityUIElement::isEqual):
3466
3467 2010-11-10  Csaba Osztrogonác  <ossy@webkit.org>
3468
3469         Reviewed by David Hyatt.
3470
3471         HTML5 Ruby support should be mandatory feature
3472         https://bugs.webkit.org/show_bug.cgi?id=49272
3473
3474         Remove Ruby as optional feature.
3475
3476         * Scripts/build-webkit:
3477
3478 2010-11-10  Adam Roben  <aroben@apple.com>
3479
3480         Print VC++ Express build logs in the same order that the projects are
3481         built
3482
3483         Fixes <http://webkit.org/b/49326> print-vse-failure-logs prints logs
3484         in an unhelpful order
3485
3486         Reviewed by Eric Seidel.
3487
3488         * Scripts/print-vse-failure-logs:
3489         (PrintVisualStudioExpressLogs._build_order): Added. Uses
3490         print-msvc-project-dependencies to figure out the order in which
3491         projects are built.
3492         (PrintVisualStudioExpressLogs._sort_buildlogs): Added. Sorts the logs
3493         based on their build order and project name.
3494         (PrintVisualStudioExpressLogs._obj_directory): Moved code to find the
3495         scripts directory from here...
3496         (PrintVisualStudioExpressLogs._scripts_directory): ...to here.
3497         (PrintVisualStudioExpressLogs.main): Sort the logs before printing
3498         them.
3499
3500 2010-11-10  Adam Roben  <aroben@apple.com>
3501
3502         Only print the interesting text from VC++ Express build logs
3503
3504         Fixes <http://webkit.org/b/49325> It's hard to find the interesting
3505         output from print-vse-failure-logs
3506
3507         Reviewed by Eric Seidel.
3508
3509         * Scripts/print-vse-failure-logs: Removed unnecessary os.path import,
3510         added newly-required imports. Removed a comment that was essentially a
3511         FIXME, and is now fixed.
3512         (PrintVisualStudioExpressLogs._relevant_text): Added. Uses
3513         BeautifulSoup to extract the relevant text from the build log.
3514         (PrintVisualStudioExpressLogs.main): Only print the relevant text.
3515
3516 2010-11-09  Mihai Parparita  <mihaip@chromium.org>
3517
3518         Reviewed by Tony Chang.
3519
3520         [Chromium] http/tests/security/XFrameOptions fail with Chromium DRT
3521         https://bugs.webkit.org/show_bug.cgi?id=49286
3522         
3523         The tests in http/tests/security/XFrameOptions started to fail after
3524         r71297, since it changed the WebViewHost::assignIdentifierToRequest
3525         logic to always assign identifiers to requests, even if we're not going
3526         to be dumping resource load callbacks at that point. These tests
3527         only call LayoutTestController.dumpResourceLoadCallbacks after the
3528         request is started, thus their expectations have "<unknown>" as the
3529         identifier. Change WebViewHost to the previous behavior, which also
3530         match the other ports'.
3531
3532         * DumpRenderTree/chromium/WebViewHost.cpp:
3533         (WebViewHost::assignIdentifierToRequest):
3534         (WebViewHost::removeIdentifierForRequest):
3535
3536 2010-11-08  Tony Chang  <tony@chromium.org>
3537
3538         Reviewed by Adam Barth.
3539
3540         run platform/chromium/plugins/return-npobject.html on all platforms
3541         https://bugs.webkit.org/show_bug.cgi?id=49103
3542
3543         This tests that we can get an NPObject returned through a method on
3544         an NPAPI Object.
3545
3546         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3547         (testCallbackReturn):
3548         (pluginInvoke):
3549
3550 2010-11-09  Sheriff Bot  <webkit.review.bot@gmail.com>
3551
3552         Unreviewed, rolling out r71672.
3553         http://trac.webkit.org/changeset/71672
3554         https://bugs.webkit.org/show_bug.cgi?id=49276
3555
3556         It doesn't work on Chromium Windows bot (Requested by Ossy on
3557         #webkit).
3558
3559         * Scripts/webkitpy/common/system/file_lock.py: Removed.
3560         * Scripts/webkitpy/common/system/file_lock_unittest.py: Removed.
3561         * Scripts/webkitpy/layout_tests/port/http_lock.py:
3562
3563 2010-11-09  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3564
3565         Reviewed by Tony Chang.
3566
3567         [NRWT] Make http locking similar to perl implementation
3568         https://bugs.webkit.org/show_bug.cgi?id=49187
3569
3570         * Scripts/webkitpy/common/system/file_lock.py: Added.
3571         * Scripts/webkitpy/common/system/file_lock_unittest.py: Added.
3572         * Scripts/webkitpy/layout_tests/port/http_lock.py:
3573
3574 2010-11-09  James Kozianski  <koz@chromium.org>
3575
3576         Reviewed by Eric Seidel.
3577
3578         Clean up imports for webkit-patch.
3579         https://bugs.webkit.org/show_bug.cgi?id=49083
3580
3581         Move some imports from commands into main.py where they are used.
3582         Move command imports into the __init__ of the commands module.
3583
3584         * Scripts/webkitpy/tool/commands/__init__.py:
3585         * Scripts/webkitpy/tool/commands/download.py:
3586         * Scripts/webkitpy/tool/commands/queues.py:
3587         * Scripts/webkitpy/tool/main.py:
3588
3589 2010-11-09  Yi Shen  <yi.4.shen@nokia.com>
3590
3591         Reviewed by Andreas Kling.
3592
3593         [Qt][QtTestBrowser] Don't erase incorrect url in the Url Bar
3594         https://bugs.webkit.org/show_bug.cgi?id=49047
3595