945462cd0b16d652be9de1a928adcb7311003b13
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-01-28  Jon Honeycutt  <jhoneycutt@apple.com>
2
3         MSAA: Crash when posting a notification for a detached object
4
5         https://bugs.webkit.org/show_bug.cgi?id=34309
6         <rdar://problem/7409759>
7
8         Reviewed by Darin Adler.
9
10         * DumpRenderTree/AccessibilityController.h:
11         Declare new functions. Add new members to store the event hook and the
12         mapping of accessibility elements to their JS callbacks.
13
14         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
15         (AccessibilityController::notificationReceived):
16         Stubbed.
17         (AccessibilityController::addNotificationListener):
18         Stubbed.
19
20         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
21         (AccessibilityController::notificationReceived):
22         Stubbed.
23         (AccessibilityController::addNotificationListener):
24         Stubbed.
25
26         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
27         (AccessibilityController::AccessibilityController):
28         Initialize the event hook.
29         (AccessibilityController::~AccessibilityController):
30         Remove the event hook. Unprotect all of the JS functions that are stored
31         in the map.
32         (logEventProc):
33         Clean-up a variable.
34         (stringEvent):
35         Return a string description of the MSAA event code.
36         (notificationListenerProc):
37         Get the accessible object from the event, and query it for IAccessible.
38         Call the AccessibilityController's notificationReceived().
39         (comparableObject):
40         Use QueryService to obtain the IAccessibleComparable for the
41         IServiceProvider.
42         (AccessibilityController::notificationReceived):
43         Iterate the map of objects that have registered for notification
44         callbacks. Query each for IServiceProvider, then use comparableObject()
45         to get an IAccessibleComparable. If we find an object matching the
46         notified object, call its callback, passing the event that was received.
47         (AccessibilityController::addNotificationListener):
48         If we have not created the event hook, create it. Protect the JS
49         callback function object, and add the object and its callback to our
50         map.
51
52         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
53         (AccessibilityUIElement::addNotificationListener):
54         Call through to the AccessibilityController's addNotificationListener().
55
56         * DumpRenderTree/win/DumpRenderTreeWin.h:
57         Add an extern declaration for the shared FrameLoadDelegate extern, so we
58         can access it from AccessibilityController.
59
60         * DumpRenderTree/win/FrameLoadDelegate.h:
61         (FrameLoadDelegate::accessibilityController):
62         Return the AccessibilityController.
63
64 2010-01-29  Shinichiro Hamaji  <hamaji@chromium.org>
65
66         Reviewed by Darin Adler.
67
68         prepare-ChangeLog outputs useless messages for a nonexistent bug ID
69         https://bugs.webkit.org/show_bug.cgi?id=34313
70
71         * Scripts/prepare-ChangeLog:
72
73 2010-01-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
74
75         Rubberstamped by Simon Hausmann.
76
77         [Qt] Separate implementation from class definition.
78
79         * QtLauncher/main.cpp:
80         (LauncherWindow::webView):
81         (LauncherWindow::LauncherWindow):
82         (LauncherWindow::~LauncherWindow):
83         (LauncherWindow::keyPressEvent):
84         (LauncherWindow::grabZoomKeys):
85         (LauncherWindow::sendTouchEvent):
86         (LauncherWindow::eventFilter):
87         (LauncherWindow::loadStarted):
88         (LauncherWindow::loadFinished):
89         (LauncherWindow::showLinkHover):
90         (LauncherWindow::zoomIn):
91         (LauncherWindow::zoomOut):
92         (LauncherWindow::resetZoom):
93         (LauncherWindow::toggleZoomTextOnly):
94         (LauncherWindow::print):
95         (LauncherWindow::screenshot):
96         (LauncherWindow::setEditable):
97         (LauncherWindow::dumpHtml):
98         (LauncherWindow::selectElements):
99         (LauncherWindow::setTouchMocking):
100         (LauncherWindow::newWindow):
101         (LauncherWindow::setupUI):
102
103 2010-01-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
104
105         Reviewed by Ariya Hidayat.
106
107         [Qt] On Maemo5, a click/touch in the location bar (when unfocused)
108         should result in all text selected.
109
110         * QtLauncher/locationedit.cpp:
111         (LocationEdit::focusInEvent):
112         * QtLauncher/locationedit.h:
113
114 2010-01-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
115
116         Reviewed by Ariya Hidayat.
117
118         [Qt] Show progress reaching 100% for loads.
119
120         * QtLauncher/locationedit.cpp:
121         (LocationEdit::LocationEdit):
122         (LocationEdit::setProgress):
123         (LocationEdit::reset):
124         (LocationEdit::paintEvent):
125         * QtLauncher/locationedit.h:
126
127 2010-01-29  Andreas Kling  <andreas.kling@nokia.com>
128
129         Reviewed by Kenneth Rohde Christiansen.
130
131         [Qt] Disable the QtLauncher statusbar on Maemo
132
133         https://bugs.webkit.org/show_bug.cgi?id=34330
134
135         * QtLauncher/main.cpp:
136         (LauncherWindow::showLinkHover):
137         (LauncherWindow::selectElements):
138
139 2010-01-29  Andreas Kling  <andreas.kling@nokia.com>
140
141         Reviewed by Kenneth Rohde Christiansen.
142
143         [Qt] Display page loading progress inside the QtLauncher location bar
144
145         https://bugs.webkit.org/show_bug.cgi?id=34210
146
147         * QtLauncher/QtLauncher.pro:
148         * QtLauncher/locationedit.cpp: Added.
149         (LocationEdit::LocationEdit):
150         (LocationEdit::setProgress):
151         (LocationEdit::paintEvent):
152         * QtLauncher/locationedit.h: Added.
153         * QtLauncher/mainwindow.cpp:
154         (MainWindow::buildUI):
155         * QtLauncher/mainwindow.h:
156
157 2010-01-29  Andreas Kling  <andreas.kling@nokia.com>
158
159         Reviewed by Kenneth Rohde Christiansen.
160
161         [Qt] Add support for Maemo zoom keys in QtLauncher
162
163         https://bugs.webkit.org/show_bug.cgi?id=34160
164
165         * QtLauncher/main.cpp:
166         (LauncherWindow::LauncherWindow):
167         (LauncherWindow::~LauncherWindow):
168         (LauncherWindow::keyPressEvent):
169         (LauncherWindow::grabZoomKeys):
170
171 2010-01-29  Benjamin Poulain  <benjamin.poulain@nokia.com>
172
173         Reviewed by Kenneth Rohde Christiansen.
174
175         [Qt] Implement the display() method of the layout test controller
176         https://bugs.webkit.org/show_bug.cgi?id=34258
177
178         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
179         (WebCore::DumpRenderTree::DumpRenderTree):
180         (WebCore::DumpRenderTree::showPage):
181         (WebCore::DumpRenderTree::hidePage):
182         * DumpRenderTree/qt/DumpRenderTreeQt.h:
183         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
184         (LayoutTestController::reset):
185         (LayoutTestController::display):
186         * DumpRenderTree/qt/LayoutTestControllerQt.h:
187
188 2010-01-28  Kevin Ollivier  <kevino@theolliviers.com>
189
190         [wx] Build fix for MSW, use ThreadingWin.cpp as the Windows pthreads implementation
191         implements pthread_t in a way that makes it impossible to check its validity,
192         which is needed by ThreadingPthreads.cpp.
193
194         * DumpRenderTree/wscript:
195         * wx/build/settings.py:
196
197 2010-01-28  Andras Becsi  <abecsi@webkit.org>
198
199         Adding myself to the committer list. No review needed.
200
201         * Scripts/webkitpy/committers.py:
202
203 2010-01-28  Hayato Ito  <hayato@chromium.org>
204
205         Reviewed by David Levin.
206
207         Remove NULL char from input JS file because 'grep' fails if the file contains NULL char.
208
209         https://bugs.webkit.org/show_bug.cgi?id=34252
210
211         * Scripts/make-script-test-wrappers:
212
213 2010-01-28  Kevin Ollivier  <kevino@theolliviers.com>
214
215         [wx] Build fix after removal of the zlib image decoder.
216
217         * wx/build/settings.py:
218
219 2010-01-28  Csaba Osztrogonác  <ossy@webkit.org>
220
221         [Qt] Unreviewed, roll out r54000.
222
223         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
224         (WebCore::DumpRenderTree::DumpRenderTree):
225         * DumpRenderTree/qt/DumpRenderTreeQt.h:
226         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
227         (LayoutTestController::reset):
228         * DumpRenderTree/qt/LayoutTestControllerQt.h:
229         (LayoutTestController::display):
230
231 2010-01-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
232
233         Reviewed by Kenneth Rohde Christiansen.
234
235         [Qt] Implement the display() method of the layout test controller
236         https://bugs.webkit.org/show_bug.cgi?id=34258
237
238         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
239         (WebCore::DumpRenderTree::DumpRenderTree):
240         (WebCore::DumpRenderTree::showPage):
241         (WebCore::DumpRenderTree::hidePage):
242         * DumpRenderTree/qt/DumpRenderTreeQt.h:
243         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
244         (LayoutTestController::reset):
245         (LayoutTestController::display):
246         * DumpRenderTree/qt/LayoutTestControllerQt.h:
247
248 2010-01-28  Chris Jerdonek  <cjerdonek@webkit.org>
249
250         Reviewed by Shinichiro Hamaji.
251
252         Eliminated the filename parameter from functions in
253         check-webkit-style's cpp.py where it is no longer used.
254
255         https://bugs.webkit.org/show_bug.cgi?id=34249
256
257         * Scripts/webkitpy/style/processors/cpp.py:
258           - Reduced number of occurrences of "filename" variable from
259             approximately 200 to 120.
260
261         * Scripts/webkitpy/style/processors/cpp_unittest.py:
262           - Refactored unit tests as necessary to accommodate changes to cpp.py.
263           - Fixed bug in CppStyleTestBase.perform_include_what_you_use()
264             where the incorrect file extension was getting passed to
265             cpp_style.check_language().
266
267 2010-01-28  Chris Jerdonek  <cjerdonek@webkit.org>
268
269         Reviewed by Shinichiro Hamaji.
270
271         In check-webkit-style, eliminated the dependency of
272         processors/cpp_unittest.py on checker.py.
273
274         https://bugs.webkit.org/show_bug.cgi?id=34205
275
276         * Scripts/webkitpy/style/checker.py:
277           - Addressed FIXME by removing STYLE_CATEGORIES data.
278           - Added style_categories().
279
280         * Scripts/webkitpy/style/checker_unittest.py:
281           - Minor changes.
282
283         * Scripts/webkitpy/style/processors/cpp.py:
284           - Added categories attribute to CppProcessor class (data
285             was originally checker.STYLE_CATEGORIES).
286
287         * Scripts/webkitpy/style/processors/cpp_unittest.py:
288           - Addressed FIXME by eliminating "import" from checker.py.
289
290 2010-01-28  Anton Muhin  <antonm@chromium.org>
291
292         Reviewed by Shinichiro Hamaji.
293
294         Improve treatment of conditions and rest of the line for if, else, switch and alikes
295         https://bugs.webkit.org/show_bug.cgi?id=34173
296
297         * Scripts/webkitpy/style/cpp_style.py:
298         * Scripts/webkitpy/style/cpp_style_unittest.py:
299
300 2010-01-28  Joe Mason  <jmason@rim.com>
301
302         Reviewed by Adam Barth.
303
304         Limit login retries to 5
305         https://bugs.webkit.org/show_bug.cgi?id=34193
306
307         * Scripts/webkitpy/bugzilla.py:
308
309 2010-01-27  Martin Robinson  <mrobinson@webkit.org>
310
311         Adding myself to the committer list. No review necessary.
312
313         * Scripts/webkitpy/committers.py:
314
315 2010-01-27  George Wright  <gwright@rim.com>
316
317         Reviewed by Adam Treat.
318
319         https://bugs.webkit.org/show_bug.cgi?id=34216
320
321         Add missing include for wtf/Platform.h
322
323         * DumpRenderTree/AccessibilityController.h:
324
325 2010-01-27  Diego Gonzalez  <diego.gonzalez@openbossa.org>
326
327         Reviewed by Kenneth Rohde Christiansen.
328
329         [Qt] DRT Provide worker thread ability to track counters
330         https://bugs.webkit.org/show_bug.cgi?id=34221
331
332         Implement workerThreadCount() in LayoutTestController of Qt DRT
333
334         Tests:
335         fast/workers/dedicated-worker-lifecycle.html
336         fast/workers/shared-worker-frame-lifecycle.html
337         fast/workers/shared-worker-lifecycle.html
338         fast/workers/worker-lifecycle.html
339
340         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
341         (LayoutTestController::workerThreadCount):
342         * DumpRenderTree/qt/LayoutTestControllerQt.h:
343
344 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
345
346         Rubberstamped by Simon Hausmann.
347
348         [Qt] QtLauncher refactoring:
349
350         Make the LauncherWindow depend less on the view, so that more
351         code can be shared in near future.
352
353         * QtLauncher/main.cpp:
354         (LauncherWindow::sendTouchEvent):
355         (LauncherWindow::loadFinished):
356         (LauncherWindow::zoomIn):
357         (LauncherWindow::zoomOut):
358         (LauncherWindow::resetZoom):
359         (LauncherWindow::toggleZoomTextOnly):
360         (LauncherWindow::dumpHtml):
361         (LauncherWindow::selectElements):
362         (LauncherWindow::setupUI):
363
364 2010-01-27  Kinuko Yasuda  <kinuko@chromium.org>
365
366         Reviewed by Eric Seidel.
367
368         Correctly handle the KeyLocation argument that has been introduced
369         recently to test location-dependent key events in EventSender.keyDown.
370         http://bugs.webkit.org/show_bug.cgi?id=28247
371
372         Test: fast/events/keydown-numpad-keys.html
373
374         * DumpRenderTree/gtk/EventSender.cpp:
375         (keyDownCallback):
376
377 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
378
379         Rubberstamped by Simon Hausmann.
380
381         [Qt] QtLauncher refactoring:
382
383         Move out code from the MainWindow (renamed to LauncherWindow)
384         that is not depending on the view, and add it to a new class
385         called MainWindow.
386
387         * QtLauncher/QtLauncher.pro:
388         * QtLauncher/main.cpp:
389         (LauncherWindow::LauncherWindow):
390         (LauncherWindow::eventFilter):
391         (LauncherWindow::loadStarted):
392         (LauncherWindow::loadFinished):
393         (LauncherWindow::newWindow):
394         (LauncherWindow::setupUI):
395         (WebPage::createWindow):
396         (main):
397         * QtLauncher/mainwindow.cpp: Added.
398         (MainWindow::MainWindow):
399         (MainWindow::buildUI):
400         (MainWindow::page):
401         (MainWindow::setAddressUrl):
402         (MainWindow::addCompleterEntry):
403         (MainWindow::load):
404         (MainWindow::changeLocation):
405         (MainWindow::openFile):
406         * QtLauncher/mainwindow.h: Added.
407
408 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
409
410         Rubberstamped by Simon Hausmann.
411
412         [Qt] QtLauncher, coding style fixes.
413
414         * QtLauncher/main.cpp:
415         (MainWindow::MainWindow):
416         (MainWindow::sendTouchEvent):
417         (MainWindow::eventFilter):
418         (MainWindow::loadURL):
419         (MainWindow::setupUI):
420         (WebPage::createPlugin):
421
422 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
423
424         Rubberstamped by Simon Hausmann.
425
426         [Qt] QtLauncher refactoring, separating the webview and
427         adding a QGraphicsWebView based version.
428
429         * QtLauncher/QtLauncher.pro:
430         * QtLauncher/main.cpp:
431         (MainWindow::MainWindow):
432         * QtLauncher/webpage.h:
433         * QtLauncher/webview.cpp: Added.
434         (createContextMenu):
435         (WebViewGraphicsBased::mousePressEvent):
436         (WebViewTraditional::mousePressEvent):
437         (WebViewGraphicsBased::contextMenuEvent):
438         (WebViewTraditional::contextMenuEvent):
439         * QtLauncher/webview.h: Added.
440         (WebViewGraphicsBased::WebViewGraphicsBased):
441         (WebViewTraditional::WebViewTraditional):
442
443 2010-01-27  Alexander Pavlov  <apavlov@chromium.org>
444
445         Adding myself as committer. No review necessary.
446
447         * Scripts/webkitpy/committers.py:
448
449 2010-01-27  Eric Seidel  <eric@webkit.org>
450
451         Reviewed by Darin Adler.
452
453         webkit-patch needs an open-bugs command
454         https://bugs.webkit.org/show_bug.cgi?id=30793
455
456         * Scripts/test-webkitpy: import OpenBugsTest
457         * Scripts/webkit-patch: import OpenBugs
458         * Scripts/webkitpy/commands/download_unittest.py: don't import unittest
459         * Scripts/webkitpy/commands/early_warning_system_unittest.py: ditto
460         * Scripts/webkitpy/commands/queries_unittest.py: ditto
461         * Scripts/webkitpy/commands/queues_unittest.py: ditto
462         * Scripts/webkitpy/commands/upload_unittest.py: ditto
463         * Scripts/webkitpy/mock_bugzillatool.py: log when user.open_url is called.
464
465 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
466
467         Rubberstamped by Simon Hausmann
468
469         [Qt] QtLauncher refactoring, separating utility methods.
470
471         * QtLauncher/QtLauncher.pro:
472         * QtLauncher/main.cpp:
473         * QtLauncher/utils.cpp: Added.
474         (urlFromUserInput):
475         * QtLauncher/utils.h: Added.
476
477 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
478
479         Rubberstamped by Simon Hausmann
480
481         [Qt] Refactor the code in the QtLauncher dealing with HTTP proxy.
482
483         * QtLauncher/main.cpp:
484         (MainWindow::MainWindow):
485         * QtLauncher/webpage.cpp:
486         (WebPage::WebPage):
487         (WebPage::applyProxy):
488         * QtLauncher/webpage.h:
489
490 2010-01-26  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
491
492         Reviewed by Tor Arne Vestbø.
493
494         [Qt] Corrects debug build of DumpRenderTree on Windows.
495
496         * DumpRenderTree/qt/DumpRenderTree.pro:
497
498 2010-01-26  Daniel Bates  <dbates@webkit.org>
499
500         Reviewed by Adam Barth.
501
502         https://bugs.webkit.org/show_bug.cgi?id=34070
503
504         Moves the try/catch for OSError exceptions in Executive.run_command
505         to Credentials.read_credentials() so that the unit test
506         webkitpy.scm_unittest.SCMClassTests.test_error_handlers can
507         assert that Executive.run_command throws an OSError exception.
508
509         * Scripts/webkitpy/credentials.py:
510         * Scripts/webkitpy/executive.py: Moved try/catch for OSError to
511         method Credentials.read_credentials().
512         * Scripts/webkitpy/executive_unittest.py: Removed tests that no longer
513         apply: test_run_command_with_bad_command_check_return_code and
514         test_run_command_with_bad_command_check_calls_error_handler. Added new
515         test to assert that run_command throws OSError exceptions.
516
517 2010-01-26  Diego Gonzalez  <diego.gonzalez@openbossa.org>
518
519         Reviewed by Kenneth Rohde Christiansen.
520
521         [Qt] DRT WebHistory support
522         https://bugs.webkit.org/show_bug.cgi?id=34167
523
524         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
525         (LayoutTestController::reset):
526         (LayoutTestController::webHistoryItemCount):
527         (LayoutTestController::keepWebHistory):
528         * DumpRenderTree/qt/LayoutTestControllerQt.h:
529
530 2010-01-26  Kent Tamura  <tkent@chromium.org>
531
532         Reviewed by Eric Seidel.
533
534         [Win] Add modifiers parameter support to Windows DumpRenderTree
535         https://bugs.webkit.org/show_bug.cgi?id=34068
536
537         Add support for functional name modifiers; "addSelectionKey" and
538         "rangeSelectionKey", and modifiers parameter to eventSender.mouseDown()
539         and eventSender.mouseUp().
540         This change is similar to r53498 for Mac.
541         
542         * DumpRenderTree/win/EventSender.cpp:
543         (buildModifierFlags): New function to set MK_CONTROL or MK_SHIFT to WPARAM.
544         (mouseDownCallback): Call buidlModifiersFlags().
545         (mouseUpCallback): ditto.
546         (keyDownCallback): Add support for "addSelectionkey" and "rangeSelectionKey".
547
548 2010-01-26  Chris Jerdonek  <cjerdonek@webkit.org>
549
550         Reviewed by Eric Seidel.
551
552         The Python autoinstall cache directory now only gets created
553         in the directory containing autoinstall.py.
554
555         https://bugs.webkit.org/show_bug.cgi?id=33365
556
557         * Scripts/webkitpy/autoinstall.py:
558           - Also added a README file to the cache directory saying
559             where it came from.
560
561 2010-01-26  Chris Jerdonek  <cjerdonek@webkit.org>
562
563         Reviewed by Eric Seidel.
564
565         Moved the check-webkit-style processors into a new
566         webkitpy/style/processors directory.
567
568         https://bugs.webkit.org/show_bug.cgi?id=34060
569
570         * Scripts/webkitpy/style/checker.py:
571         * Scripts/webkitpy/style/checker_unittest.py:
572         * Scripts/webkitpy/style/cpp_style.py: Removed.
573         * Scripts/webkitpy/style/cpp_style_unittest.py: Removed.
574         * Scripts/webkitpy/style/processors: Added.
575         * Scripts/webkitpy/style/processors/__init__.py: Added.
576         * Scripts/webkitpy/style/processors/cpp.py: Copied from WebKitTools/Scripts/webkitpy/style/cpp_style.py.
577         * Scripts/webkitpy/style/processors/cpp_unittest.py: Copied from WebKitTools/Scripts/webkitpy/style/cpp_style_unittest.py.
578         * Scripts/webkitpy/style/processors/text.py: Copied from WebKitTools/Scripts/webkitpy/style/text_style.py.
579         * Scripts/webkitpy/style/processors/text_unittest.py: Copied from WebKitTools/Scripts/webkitpy/style/text_style_unittest.py.
580         * Scripts/webkitpy/style/text_style.py: Removed.
581         * Scripts/webkitpy/style/text_style_unittest.py: Removed.
582         * Scripts/webkitpy/style/unittests.py:
583
584 2010-01-26  Kevin Ollivier  <kevino@theolliviers.com>
585
586         [wx] Build fix, make sure stub function returns a value.
587
588         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
589         (LayoutTestController::counterValueForElementById):
590
591 2010-01-26  Steve Falkenburg  <sfalken@apple.com>
592
593         Reviewed by Oliver Hunt.
594
595         Windows build references non-existent include paths
596         https://bugs.webkit.org/show_bug.cgi?id=34175
597
598         * DumpRenderTree/win/DumpRenderTree.vcproj:
599         * DumpRenderTree/win/ImageDiff.vcproj:
600         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
601
602 2010-01-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>
603
604         Reviewed by Ariya Hidayat.
605
606         [Qt] Separating out the UrlLoader from the QtLauncher in it's
607         own implementation and header file.
608
609         * QtLauncher/main.cpp:
610         (main):
611         * QtLauncher/urlloader.cpp: Added.
612         (UrlLoader::UrlLoader):
613         (UrlLoader::loadNext):
614         (UrlLoader::init):
615         (UrlLoader::getUrl):
616         * QtLauncher/urlloader.h: Added.
617
618 2010-01-25  Chris Jerdonek  <cjerdonek@webkit.org>
619
620         Reviewed by Shinichiro Hamaji.
621
622         Refactored check-webkit-style by removing the file path
623         parameter from the style error handler functions.
624
625         https://bugs.webkit.org/show_bug.cgi?id=34031
626
627         * Scripts/webkitpy/style/checker.py:
628           - Added _default_style_error_handler() to StyleChecker class.
629           - Moved handle_style_error() to inside _default_style_error_handler().
630
631         * Scripts/webkitpy/style/checker_unittest.py:
632           - Removed file path from calls to error handler.
633
634         * Scripts/webkitpy/style/cpp_style.py:
635           - Removed file path from calls to error handler.
636
637         * Scripts/webkitpy/style/cpp_style_unittest.py:
638           - Removed file path from calls to error handler.
639
640         * Scripts/webkitpy/style/text_style.py:
641           - Removed file path from calls to error handler.
642
643         * Scripts/webkitpy/style/text_style_unittest.py:
644           - Removed file path from calls to error handler.
645
646 2010-01-25  Jeremy Orlow  <jorlow@chromium.org>
647
648         Adding myself as reviewer.  No review necessary.
649
650         * Scripts/webkitpy/committers.py:
651
652 2010-01-25  Chris Jerdonek  <cjerdonek@webkit.org>
653
654         Reviewed by Adam Barth.
655
656         Improved prepare-ChangeLog so that it preserves the relative
657         indentation of a git commit message.
658
659         https://bugs.webkit.org/show_bug.cgi?id=34058
660
661         * Scripts/prepare-ChangeLog:
662           - Also adjusted the script so that it does not add white
663             space characters to empty lines.
664
665 2010-01-24  Eric Seidel  <eric@webkit.org>
666
667         No review, rolling out r53763.
668         http://trac.webkit.org/changeset/53763
669         https://bugs.webkit.org/show_bug.cgi?id=33895
670
671         Broke 20+ tests on Windows.
672
673         * Scripts/run-webkit-tests:
674         * Scripts/webkitdirs.pm:
675
676 2010-01-24  Adam Barth  <abarth@webkit.org>
677
678         Rubber stamped by Eric Seidel.
679
680         More pep8 compliance.
681
682         * Scripts/webkitpy/mock_bugzillatool.py:
683
684 2010-01-24  Adam Barth  <abarth@webkit.org>
685
686         Rubber stamped by Eric Seidel.
687
688         More pep8 compliance.
689
690         * Scripts/webkitpy/executive.py:
691         * Scripts/webkitpy/grammar.py:
692
693 2010-01-24  Adam Barth  <abarth@webkit.org>
694
695         Rubber stamped by Eric Seidel.
696
697         More pep8 compliance.
698
699         * Scripts/webkitpy/comments.py:
700         * Scripts/webkitpy/committers.py:
701         * Scripts/webkitpy/credentials.py:
702
703 2010-01-24  Adam Barth  <abarth@webkit.org>
704
705         Rubber stamped by Eric Seidel.
706
707         Make changelogs.py pass pep8.
708
709         * Scripts/webkitpy/changelogs.py:
710
711 2010-01-23  Kenneth Rohde Christiansen  <kenneth@webkit.org>
712
713         [Qt] Unreviewed build fix
714
715         * QtLauncher/QtLauncher.pro:
716         * QtLauncher/webinspector.h:
717
718 2010-01-23  Kenneth Rohde Christiansen  <kenneth@webkit.org>
719
720         Rubberstamped by Simon Hausmann.
721
722         [Qt] Move the WebInspector class to it's own header file.
723
724         * QtLauncher/main.cpp:
725         * QtLauncher/webinspector.h: Added.
726         (WebInspector::WebInspector):
727         (WebInspector::showEvent):
728         (WebInspector::hideEvent):
729
730 2010-01-23  Robert Hogan  <robert@roberthogan.net>
731
732         Reviewed by Kenneth Rohde Christiansen.
733
734         Qt DRT: respect window.close() and window.closed()
735         
736         Qt DRT needs to maintain a correct count of open windows
737         for windowCount(). It also needs to delete windows that
738         have been closed by window.close().
739         
740         This fixes the following tests:
741         
742         plugins/destroy-during-npp-new.html
743         fast/dom/Document/early-document-access.html
744         fast/dom/Window/window-early-properties.html
745         fast/events/open-window-from-another-frame.html
746         fast/events/popup-blocking-click-in-iframe.html
747         
748         https://bugs.webkit.org/show_bug.cgi?id=32953
749
750         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
751         (WebCore::DumpRenderTree::DumpRenderTree):
752         (WebCore::DumpRenderTree::createWindow):
753         (WebCore::DumpRenderTree::windowCloseRequested):
754         * DumpRenderTree/qt/DumpRenderTreeQt.h:
755         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
756         (LayoutTestController::maybeDump):
757
758 2010-01-23  Dan Bernstein  <mitz@apple.com>
759
760         Reviewed by Mark Rowe.
761
762         Added a user default for specifying a fallback frameworks path in case
763         the bundle does not contain frameworks for the current Mac OS X version.
764
765         * WebKitLauncher/main.m:
766         (fallbackMacOSXVersion): Added. Looks up the fallback version in a dictionary
767         keyed by the FallbackSystemVersions user default and returns it.
768         (main): If a frameworks directory for the current system version is not found,
769         try the fallback.
770
771 2010-01-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
772
773         Reviewed by Simon Hausmann.
774
775         Make run-webkit-tests work under Cygwin for the Qt port
776
777         setPathForRunningWebKitApp() is implemented for the Qt port
778         by using qmake to query for the location of the Qt libraries.
779
780         This requires the original environment (%ENV) to be untouched,
781         so launchWithCurrentEnv() was refactored to launchWithEnv(),
782         and the code in openDumpTool() to not use %ENV but a %CLEAN_ENV
783         instead. This has the added benefit of getting rid of the temp
784         variables used for storing the current env.
785
786         openDumpTool() is also refactored a bit into platform-spesific,
787         port-spesific, and generic environment variables.
788
789         Checks for undef was added a few places to fix Perl concat
790         warnings when run-webkit-tests is aborted.
791
792         https://bugs.webkit.org/show_bug.cgi?id=33895
793
794         * Scripts/run-webkit-tests:
795         * Scripts/webkitdirs.pm:
796
797 2010-01-22  Kevin Watters  <kevinwatters@gmail.com>
798
799         Reviewed by Kevin Ollivier.
800
801         [wx] Remove the Bakefile build system, which is no longer being used.
802         
803         https://bugs.webkit.org/show_bug.cgi?id=34022
804
805         * DumpRenderTree/wx/DumpRenderTree.bkl: Removed.
806         * wx/browser/browser.bkl: Removed.
807         * wx/build-wxwebkit: Removed.
808
809 2010-01-22  Gustavo Noronha Silva  <gns@gnome.org>
810
811         Reviewed by Simon Fraser.
812
813         Reset zoom level to 1.0 when resetting view state. This is causing
814         many tests to fail after svg/custom/text-zoom.xhtml changes the
815         zoom level.
816
817         * DumpRenderTree/gtk/DumpRenderTree.cpp:
818         (resetDefaultsToConsistentValues):
819
820 2010-01-22  Steve Falkenburg  <sfalken@apple.com>
821
822         Reviewed by Darin Adler.
823
824         https://bugs.webkit.org/show_bug.cgi?id=34025
825         Enable client-based Geolocation abstraction for Mac, Windows AppleWebKit targets.
826
827         * Scripts/build-webkit:
828
829 2010-01-22  Adam Barth  <abarth@webkit.org>
830
831         Unreviewed.  Arg.  Someone renamed limit to output_limit on me.
832
833         * Scripts/webkitpy/commands/queues.py:
834
835 2010-01-22  Adam Barth  <abarth@webkit.org>
836
837         Rubber stamped by Eric Seidel.
838
839         Make __init__.py and buildbot.py pass pep8 style checker.
840
841         * Scripts/webkitpy/__init__.py:
842         * Scripts/webkitpy/buildbot.py:
843
844 2010-01-21  Joe Mason  <jmason@rim.com>
845
846         Reviewed by Adam Barth.
847
848         webkit-patch should retry on invalid password
849         https://bugs.webkit.org/show_bug.cgi?id=33955
850
851         Ask for bugs.webkit.org authentication in a loop.
852
853         * Scripts/webkitpy/bugzilla.py:
854
855 2010-01-22  Adam Barth  <abarth@webkit.org>
856
857         Unreviewed.  Don't call seek on a NoneType.
858
859         * Scripts/webkitpy/statusserver.py:
860
861 2010-01-22  Petri Latvala  <petri.latvala@nomovok.com>
862
863         Reviewed by David Levin.
864
865         check-webkit-style breaks on files with unknown types
866         https://bugs.webkit.org/show_bug.cgi?id=34001
867
868         For files with type FileType.NONE, dispatch_processor returns None.
869
870         * Scripts/webkitpy/style/checker.py: Don't call process_file with a processor of value None.
871
872 2010-01-22  Adam Barth  <abarth@webkit.org>
873
874         Reviewed by Eric Seidel.
875
876         Make bugzilla.py and webkitport.py conform to pep8
877         https://bugs.webkit.org/show_bug.cgi?id=34015
878
879         This patch makes webkitport.py and bugzilla.py mostly conform to PEP8
880         style as enforced by pep8.py.  I wasn't able to get rid of all the
881         errors because I'm not sure how to wrap some lines properly.  Also,
882         there are a few deprication errors that I couldn't resolve easily.
883         However, this is a massive improvement in compliance.
884
885         * Scripts/webkitpy/bugzilla.py:
886         * Scripts/webkitpy/webkitport.py:
887
888 2010-01-22  Adam Barth  <abarth@webkit.org>
889
890         Reviewed by Darin Adler.
891
892         Limit length of EWS results to 5MB
893         https://bugs.webkit.org/show_bug.cgi?id=34016
894
895         Hopefully this will fix the bug where the results link doesn't appear.
896         Our current theory is that the results blob is too big and the server
897         is rejecting the request with a 500 error.  That causes us to re-try
898         the post, but when we re-try the StringIO buffer has its seek pointer
899         at the end.
900
901         * Scripts/webkitpy/commands/queues.py:
902         * Scripts/webkitpy/statusserver.py:
903
904 2010-01-22  Chris Jerdonek  <cjerdonek@webkit.org>
905
906         Reviewed by Adam Barth.
907
908         Made check-webkit-style able to check patches when script not
909         run from source root. Also consolidated external references
910         to a single file.
911
912         https://bugs.webkit.org/show_bug.cgi?id=33791
913
914         * Scripts/check-webkit-style:
915           - Changed to import style_references.py.
916
917         * Scripts/webkitpy/style/__init__.py:
918           - Removed __path__ hack that allowed searching Scripts/ directory.
919
920         * Scripts/webkitpy/style/checker.py:
921           - Changed to import style_references.py.
922
923         * Scripts/webkitpy/style_references.py: Added.
924
925 2010-01-22  Dmitry Titov  <dimich@chromium.org>
926
927         Reviewed by Maciej Stachowiak.
928
929         Fix the leak of ThreadIdentifiers in threadMap across threads.
930         https://bugs.webkit.org/show_bug.cgi?id=32689
931
932         Add a new test to verify the ThreadIdentifiers are not reused across threads.
933         The test runs in the beginning of DumpRenderTree and spawns 2 non-WTF treads sequentially,
934         waiting for the previous thread to terminate before starting the next.
935         The treads use WTF::currentThread() in their thread function. Without a fix, this
936         causes both threads to have the same ThreadIdentifier which triggers ASSERT in thread function.
937         It also starts another thread using WTF. Without the fix, this finds pthread handle from previous
938         threads in the WTF threadMap and asserts in WTF::establishIdentifierForPthreadHandle().
939         The test practically does not affect the DRT run time because the threads end immediately.
940
941         * DumpRenderTree/mac/DumpRenderTree.mm:
942         (runThread): Test thread function.
943         (testThreadIdentifierMap):
944         (dumpRenderTree):
945
946 2010-01-22  Kent Tamura  <tkent@chromium.org>
947
948         Reviewed by Maciej Stachowiak.
949
950         Fix a bug that mouseDown:withModifiers: is never called.
951         https://bugs.webkit.org/show_bug.cgi?id=33989
952
953         * DumpRenderTree/mac/EventSendingController.mm:
954         (+[EventSendingController isSelectorExcludedFromWebScript:]):
955         (+[EventSendingController webScriptNameForSelector:]):
956
957 2010-01-22  Kenneth Rohde Christiansen  <kenneth@webkit.org>
958
959         Rubberstamped by Antti Koivisto.
960
961         [Qt] Separate out the WebPage class into it's own
962         cpp/header files. Also, removed the assumption that
963         the view is a QWebView, in preparation of a merger
964         of the two Qt WebKit launchers.
965
966         * QtLauncher/QtLauncher.pro:
967         * QtLauncher/main.cpp:
968         (WebView::mousePressEvent):
969         * QtLauncher/webpage.cpp: Added.
970         (WebPage::supportsExtension):
971         (WebPage::extension):
972         (WebPage::acceptNavigationRequest):
973         (WebPage::openUrlInDefaultBrowser):
974         * QtLauncher/webpage.h: Added.
975         (WebPage::WebPage):
976
977 2010-01-21  Chris Jerdonek  <cjerdonek@webkit.org>
978
979         Reviewed by Shinichiro Hamaji.
980
981         Refactored to move file name and file-reading related code
982         from cpp_style.py and text_style.py to checker.py.
983
984         https://bugs.webkit.org/show_bug.cgi?id=33775
985
986         * Scripts/check-webkit-style:
987           - Updates caused by changes to checker.py.
988
989         * Scripts/webkitpy/style/checker.py:
990           - Added SKIPPED_FILES_WITH_WARNING list.
991           - Added SKIPPED_FILES_WITHOUT_WARNING list.
992           - Added FileType class.
993           - Added ProcessorDispatcher class.
994           - In StyleChecker class:
995             - Renamed process_patch() to check_patch().
996             - Renamed process_file() to check_file().
997             - Added _process_file().
998             - Related refactoring.
999             - Addressed check_patch() FIXME to share code with process_file().
1000
1001         * Scripts/webkitpy/style/checker_unittest.py:
1002           - Added ProcessorDispatcherSkipTest class.
1003           - Added ProcessorDispatcherDispatchTest class.
1004           - Added StyleCheckerCheckFileTest class.
1005
1006         * Scripts/webkitpy/style/cpp_style.py:
1007           - Renamed process_file_data() to _process_lines.
1008           - Removed process_file() (moved logic to checker.py).
1009           - Removed can_handle() (moved logic to checker.py).
1010           - Added CppProcessor class.
1011           - Removed is_exempt() (moved logic to checker.py).
1012           - Added process_file_data() back as a wrapper function.
1013
1014         * Scripts/webkitpy/style/cpp_style_unittest.py:
1015           - Removed test_can_handle().
1016           - Removed test_is_exempt().
1017           - Added CppProcessorTest class.
1018
1019         * Scripts/webkitpy/style/text_style.py:
1020           - Added TextProcessor class.
1021           - Removed process_file().
1022           - Removed can_handle().
1023
1024         * Scripts/webkitpy/style/text_style_unittest.py:
1025           - Removed test_can_handle().
1026           - Added TextProcessorTest class.
1027
1028 2010-01-21  Chris Jerdonek  <cjerdonek@webkit.org>
1029
1030         Reviewed by David Kilzer.
1031
1032         Create a unit-tested subroutine to parse patch files created
1033         by svn-create-patch.
1034
1035         https://bugs.webkit.org/show_bug.cgi?id=33475
1036
1037         * Scripts/VCSUtils.pm:
1038           - Added parseDiff().
1039           - Added parsePatch().
1040
1041         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Added.
1042           - Added unit tests for parseDiff().
1043
1044         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
1045           - Total number of tests now computed dynamically.
1046
1047         * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl: Added.
1048           - Added unit tests for parsePatch().
1049
1050 2010-01-21  Kevin Ollivier  <kevino@theolliviers.com>
1051
1052         [wx] Build fix, add new directory to dir list.
1053
1054         * wx/build/settings.py:
1055
1056 2010-01-21  Adam Barth  <abarth@webkit.org>
1057
1058         Reviewed by Eric Seidel.
1059
1060         Make the EWS transactional
1061         https://bugs.webkit.org/show_bug.cgi?id=33978
1062
1063         Now if the EWS gets interrupted in the middle of processing a patch,
1064         the bots will re-process the patch.
1065
1066         * Scripts/test-webkitpy:
1067         * Scripts/webkitpy/commands/queues.py:
1068         * Scripts/webkitpy/commands/queues_unittest.py:
1069         * Scripts/webkitpy/patchcollection.py:
1070         * Scripts/webkitpy/patchcollection_unittest.py: Added.
1071
1072 2010-01-21  Adam Barth  <abarth@webkit.org>
1073
1074         Unreviewed.  Add missing "ago" for style in the status bubble.
1075
1076         * QueueStatusServer/templates/statusbubble.html:
1077
1078 2010-01-21  Adam Barth  <abarth@webkit.org>
1079
1080         Reviewed by David Levin.
1081
1082         [style-queue] should not complain about identifier names with underscores under WebKit/gtk/webkit/
1083         https://bugs.webkit.org/show_bug.cgi?id=33356
1084
1085         White list unix_hacker_style names in WebKit/gtk/webkit because these
1086         are used in the GTK+ API.
1087
1088         * Scripts/webkitpy/style/cpp_style.py:
1089         * Scripts/webkitpy/style/cpp_style_unittest.py:
1090
1091 2010-01-21  Diego Gonzalez  <diego.gonzalez@openbossa.org>
1092
1093         Reviewed by Kenneth Rohde Christiansen.
1094
1095         [Qt] add setDomainRelaxationForbiddenForURLScheme in Qt DRT
1096         https://bugs.webkit.org/show_bug.cgi?id=33945
1097
1098         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1099         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
1100         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1101
1102 2010-01-21  Simon Hausmann  <simon.hausmann@nokia.com>
1103
1104         No review, rolling out 53615 as it causes two
1105         crashes on the bot.
1106
1107         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1108         (WebCore::DumpRenderTree::DumpRenderTree):
1109         (WebCore::DumpRenderTree::createWindow):
1110         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1111         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1112         (LayoutTestController::maybeDump):
1113
1114 2010-01-21  Robert Hogan  <robert@roberthogan.net>
1115
1116         Reviewed by Simon Hausmann.
1117
1118         Qt DRT: respect window.close() and window.closed()
1119
1120         Qt DRT needs to maintain a correct count of open windows
1121         for windowCount(). It also needs to delete windows that
1122         have been closed by window.close().
1123
1124         This fixes the following tests:
1125
1126         plugins/destroy-during-npp-new.html
1127         fast/dom/Document/early-document-access.html
1128         fast/dom/Window/window-early-properties.html
1129         fast/events/open-window-from-another-frame.html
1130         fast/events/popup-blocking-click-in-iframe.html
1131
1132         https://bugs.webkit.org/show_bug.cgi?id=32953
1133
1134         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1135         (WebCore::DumpRenderTree::DumpRenderTree):
1136         (WebCore::DumpRenderTree::createWindow):
1137         (WebCore::DumpRenderTree::windowCloseRequested):
1138         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1139         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1140         (LayoutTestController::maybeDump):
1141
1142 2010-01-20  Eric Seidel  <eric@webkit.org>
1143
1144         No review, rolling out r53593.
1145         http://trac.webkit.org/changeset/53593
1146         https://bugs.webkit.org/show_bug.cgi?id=33496
1147
1148         Re-rollout this patch, the commit-queue should not have landed
1149         it again, but it did due to land-diff and rollout both not
1150         clearing flags.
1151
1152         * Scripts/webkitpy/commands/early_warning_system.py:
1153         * Scripts/webkitpy/commands/queues.py:
1154         * Scripts/webkitpy/queueengine.py:
1155         * Scripts/webkitpy/scm.py:
1156         * Scripts/webkitpy/scm_unittest.py:
1157
1158 2010-01-20  Eric Seidel  <eric@webkit.org>
1159
1160         Reviewed by Adam Barth.
1161
1162         webkit-commit-queue status page is confusing
1163         https://bugs.webkit.org/show_bug.cgi?id=33496
1164
1165         This should improve the status page by removing more Fail messages.
1166         To do this, I re-factored the CommitQueue and the AbstractReviewQueues
1167         to behave more like one another.  This meant moving where the failure reporting was done.
1168         Previously the AbstractReviewQueue always used the parent process to report the error,
1169         while CommitQueue used the subprocess when possible, and the parent only reported errors
1170         that we didn't know how to handle (bugs in the commit-queue itself).
1171         Now the AbstractReviewQueue follow's the commit-queue's model.  This got rid of a try-block
1172         in both implementations and required teaching handle_script_error in each to post Fail messages
1173         to the status server instead of calling exit(1).
1174
1175         This will also make the style-queue share more bug posting logic with other queues:
1176         https://bugs.webkit.org/show_bug.cgi?id=33871
1177
1178         * Scripts/webkitpy/commands/early_warning_system.py:
1179          - Don't exit(1) as that will cause the calling queue to also report Fail to the status server.
1180            Implementors of handle_script_error are expected to update the status server if needed, but only exit if the error could not be handled.
1181            So we instead pass patch_has_failed_this_queue=True to _update_status_for_script_error in the case that this was a real failure.
1182            _update_status_for_script_error knows how to post the Fail message to the status server.
1183          - Teach _update_status_for_script_error how to post Fail messages to the status server.
1184         * Scripts/webkitpy/commands/queues.py:
1185          - Remove the try block from process_work_item since the caller already has one.
1186          - Only CC watchers on failure to cut down on commit-queue generated mail.
1187          - handle_unexpected_error needs to mark _did_fail now that the try block is gone from process_work_item.
1188          - Abstract _format_script_error_output_for_bug to share code between all queues.
1189          - The new _format_script_error_output_for_bug allows the style-queue to share the posting limit with other queues, as well as support linking to the full output.
1190          - Rename _can_build_and_test to _current_checkout_builds_and_passes_tests to better explain what revision it's testing.
1191          - Move logging out of _can_build_and_test and make the logs explain what revision we're testing.
1192          - handle_script_error now posts Fail instead of the try block in process_work_item handling it.
1193         * Scripts/webkitpy/queueengine.py:
1194          - QueueEngine is no longer used just by the commit-queue, update the logging to say "processing" instead of landing.
1195         * Scripts/webkitpy/scm.py:
1196          - Add new checkout_revision function.
1197         * Scripts/webkitpy/scm_unittest.py:
1198          - Test our new checkout_revision function.
1199
1200 2010-01-20  Fumitoshi Ukai  <ukai@chromium.org>
1201
1202         Reviewed by Alexey Proskuryakov.
1203
1204         WebSocket: Missing Request-URI, when no tralling slash in host
1205         https://bugs.webkit.org/show_bug.cgi?id=33689
1206
1207         Update pywebsocket to 0.4.7.1, which supports alias for resource
1208         name, so that we could test for ws://127.0.0.1:8880
1209
1210         * Scripts/run-webkit-tests:
1211         * Scripts/run-webkit-websocketserver:
1212         * pywebsocket/mod_pywebsocket/dispatch.py:
1213         * pywebsocket/mod_pywebsocket/handshake.py:
1214         * pywebsocket/mod_pywebsocket/standalone.py:
1215         * pywebsocket/setup.py:
1216         * pywebsocket/test/test_dispatch.py:
1217         * pywebsocket/test/test_handshake.py:
1218
1219 2010-01-20  Eric Seidel  <eric@webkit.org>
1220
1221         No review, rolling out r53537.
1222         http://trac.webkit.org/changeset/53537
1223         https://bugs.webkit.org/show_bug.cgi?id=33496
1224
1225         Added a failure condition to the commit-queue and looks to
1226         have broken the EWS bots
1227
1228         * Scripts/webkitpy/commands/early_warning_system.py:
1229         * Scripts/webkitpy/commands/queues.py:
1230         * Scripts/webkitpy/queueengine.py:
1231         * Scripts/webkitpy/scm.py:
1232         * Scripts/webkitpy/scm_unittest.py:
1233
1234 2010-01-20  Jon Honeycutt  <jhoneycutt@apple.com>
1235
1236         MSAA: accSelect() is not implemented
1237
1238         https://bugs.webkit.org/show_bug.cgi?id=33918
1239         <rdar://problem/7436861>
1240
1241         Reviewed by Darin Adler.
1242
1243         * DumpRenderTree/AccessibilityUIElement.cpp:
1244         (takeFocusCallback):
1245         Call the object's takeFocus() function.
1246         (takeSelectionCallback):
1247         Call its takeSelection() function.
1248         (addSelectionCallback):
1249         Call its addSelection() function.
1250         (removeSelectionCallback):
1251         Call its removeSelection() function.
1252         (AccessibilityUIElement::getJSClass):
1253         Add new functions to the JS class definition.
1254
1255         * DumpRenderTree/AccessibilityUIElement.h:
1256         Declare new functions.
1257
1258         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1259         (AccessibilityUIElement::takeFocus):
1260         Stubbed.
1261         (AccessibilityUIElement::takeSelection):
1262         Stubbed.
1263         (AccessibilityUIElement::addSelection):
1264         Stubbed.
1265         (AccessibilityUIElement::removeSelection):
1266         Stubbed.
1267
1268         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1269         (AccessibilityUIElement::takeFocus):
1270         Stubbed.
1271         (AccessibilityUIElement::takeSelection):
1272         Stubbed.
1273         (AccessibilityUIElement::addSelection):
1274         Stubbed.
1275         (AccessibilityUIElement::removeSelection):
1276         Stubbed.
1277
1278         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1279         (AccessibilityUIElement::takeFocus):
1280         Call the object's accSelect() function, passing the appropriate flag.
1281         (AccessibilityUIElement::takeSelection):
1282         Ditto.
1283         (AccessibilityUIElement::addSelection):
1284         Ditto.
1285         (AccessibilityUIElement::removeSelection):
1286         Ditto.
1287
1288 2010-01-20  Andras Becsi  <abecsi@inf.u-szeged.hu>
1289
1290         Reviewed by Alexey Proskuryakov.
1291
1292         Extract Apache handling to httpd.pm module and use the provided functionality
1293         in scripts where Apache is needed.
1294         The module httpd.pm stores the PID of Apache in a variable and cleans up
1295         the PID directory after Apache properly shut down. Catching INT and TERM
1296         signals allows the scripts to close Apache and clean up its PID directory
1297         even if the testing was interrupted.
1298
1299         https://bugs.webkit.org/show_bug.cgi?id=33153
1300
1301         * Scripts/webkitperl/httpd.pm: Added.
1302         * Scripts/run-iexploder-tests:
1303         * Scripts/run-webkit-httpd:
1304         * Scripts/run-webkit-tests:
1305
1306 2010-01-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1307
1308         Reviewed by Simon Hausmann.
1309
1310         [Qt] Make DumpRenderTree build on Windows
1311
1312         * DumpRenderTree/qt/DumpRenderTree.pro:
1313         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1314         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1315         * DumpRenderTree/qt/main.cpp:
1316
1317 2010-01-20  Steve Block  <steveblock@google.com>
1318
1319         Reviewed by Eric Seidel.
1320
1321         Fix commit bot to land patches in order of the bug last modification date.
1322         https://bugs.webkit.org/show_bug.cgi?id=33395
1323
1324         * Scripts/webkitpy/bugzilla.py: Modified. Added 'order=Last+Changed' to bugzilla commit queue URL.
1325
1326 2010-01-20  Adam Barth  <abarth@webkit.org>
1327
1328         Reviewed by Eric Seidel.
1329
1330         Teach check-webkit-style about WebKit/gtk/tests
1331         https://bugs.webkit.org/show_bug.cgi?id=33892
1332
1333         Removes false positives found in
1334         https://bugs.webkit.org/show_bug.cgi?id=30883
1335
1336         * Scripts/webkitpy/style/cpp_style.py:
1337         * Scripts/webkitpy/style/cpp_style_unittest.py:
1338
1339 2010-01-20  Adam Barth  <abarth@webkit.org>
1340
1341         Reviewed by Eric Seidel.
1342
1343         Teach check-webkit-style about QGVLauncher
1344         https://bugs.webkit.org/show_bug.cgi?id=33890
1345
1346         Remove false positives found in
1347         https://bugs.webkit.org/show_bug.cgi?id=33708
1348
1349         * Scripts/webkitpy/style/cpp_style.py:
1350         * Scripts/webkitpy/style/cpp_style_unittest.py:
1351
1352 2010-01-20  Eric Seidel  <eric@webkit.org>
1353
1354         Reviewed by Adam Barth.
1355
1356         webkit-commit-queue status page is confusing
1357         https://bugs.webkit.org/show_bug.cgi?id=33496
1358
1359         This should improve the status page by removing more Fail messages.
1360         To do this, I re-factored the CommitQueue and the AbstractReviewQueues
1361         to behave more like one another.  This meant moving where the failure reporting was done.
1362         Previously the AbstractReviewQueue always used the parent process to report the error,
1363         while CommitQueue used the subprocess when possible, and the parent only reported errors
1364         that we didn't know how to handle (bugs in the commit-queue itself).
1365         Now the AbstractReviewQueue follow's the commit-queue's model.  This got rid of a try-block
1366         in both implementations and required teaching handle_script_error in each to post Fail messages
1367         to the status server instead of calling exit(1).
1368
1369         This will also make the style-queue share more bug posting logic with other queues:
1370         https://bugs.webkit.org/show_bug.cgi?id=33871
1371
1372         * Scripts/webkitpy/commands/early_warning_system.py:
1373          - Don't exit(1) as that will cause the calling queue to also report Fail to the status server.
1374            Implementors of handle_script_error are expected to update the status server if needed, but only exit if the error could not be handled.
1375            So we instead pass patch_has_failed_this_queue=True to _update_status_for_script_error in the case that this was a real failure.
1376            _update_status_for_script_error knows how to post the Fail message to the status server.
1377          - Teach _update_status_for_script_error how to post Fail messages to the status server.
1378         * Scripts/webkitpy/commands/queues.py:
1379          - Remove the try block from process_work_item since the caller already has one.
1380          - Only CC watchers on failure to cut down on commit-queue generated mail.
1381          - handle_unexpected_error needs to mark _did_fail now that the try block is gone from process_work_item.
1382          - Abstract _format_script_error_output_for_bug to share code between all queues.
1383          - The new _format_script_error_output_for_bug allows the style-queue to share the posting limit with other queues, as well as support linking to the full output.
1384          - Rename _can_build_and_test to _current_checkout_builds_and_passes_tests to better explain what revision it's testing.
1385          - Move logging out of _can_build_and_test and make the logs explain what revision we're testing.
1386          - handle_script_error now posts Fail instead of the try block in process_work_item handling it.
1387         * Scripts/webkitpy/queueengine.py:
1388          - QueueEngine is no longer used just by the commit-queue, update the logging to say "processing" instead of landing.
1389         * Scripts/webkitpy/scm.py:
1390          - Add new checkout_revision function.
1391         * Scripts/webkitpy/scm_unittest.py:
1392          - Test our new checkout_revision function.
1393
1394 2010-01-20  Adam Barth  <abarth@webkit.org>
1395
1396         Reviewed by Darin Adler.
1397
1398         Exempt JavaScriptCore/qt/api from style checks
1399         https://bugs.webkit.org/show_bug.cgi?id=33879
1400
1401         Apparently there is a JavaScriptCore API for Qt as well as a WebKit
1402         API.
1403
1404         * Scripts/webkitpy/style/cpp_style.py:
1405         * Scripts/webkitpy/style/cpp_style_unittest.py:
1406
1407 2010-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1408
1409         Reviewed by Simon Hausmann.
1410
1411         [Qt] Don't use QSocketNotifier in the DRT for reading stdin
1412
1413         QSocketNotifier is not available on Windows. Instead we read
1414         stdin synchronously after each test using signals and slots.
1415
1416         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1417         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1418         * DumpRenderTree/qt/main.cpp:
1419
1420 2010-01-19  Adam Barth  <abarth@webkit.org>
1421
1422         Rubber stamped by Eric Seidel.
1423
1424         Move chromium-ews back to building release only to make the EWS faster.
1425
1426         * Scripts/webkitpy/commands/early_warning_system.py:
1427
1428 2010-01-17  Jon Honeycutt  <jhoneycutt@apple.com>
1429
1430         MSAA: The child <option> elements of a non-multiple <select> are not
1431         exposed
1432
1433         https://bugs.webkit.org/show_bug.cgi?id=33773
1434         <rdar://problem/7550556>
1435
1436         Reviewed by Alice Liu.
1437
1438         * DumpRenderTree/AccessibilityUIElement.cpp:
1439         (getIsVisibleCallback):
1440         Call the object's isVisible() function.
1441         (getIsOffScreenCallback):
1442         Ditto, for isOffScreen().
1443         (getIsCollapsedCallback):
1444         Ditto, for isCollapsed().
1445         (getHasPopupCallback):
1446         Ditto, for hasPopup().
1447         (AccessibilityUIElement::getJSClass):
1448         Add isVisible and isOffScreen attributes.
1449
1450         * DumpRenderTree/AccessibilityUIElement.h:
1451         Declare new functions.
1452
1453         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1454         (AccessibilityUIElement::isVisible):
1455         Stubbed.
1456         (AccessibilityUIElement::isOffScreen):
1457         Stubbed.
1458         (AccessibilityUIElement::isCollapsed):
1459         Stubbed.
1460         (AccessibilityUIElement::hasPopup):
1461         Stubbed.
1462
1463         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1464         (AccessibilityUIElement::isVisible):
1465         Stubbed.
1466         (AccessibilityUIElement::isOffScreen):
1467         Stubbed.
1468         (AccessibilityUIElement::isCollapsed):
1469         Stubbed.
1470         (AccessibilityUIElement::hasPopup):
1471         Stubbed.
1472
1473         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1474         (AccessibilityUIElement::showMenu):
1475         Call the object's accDoDefaultAction() to show its popup menu.
1476         (AccessibilityUIElement::isEnabled):
1477         Check that the object does not have the "unavailable" state.
1478         (AccessibilityUIElement::isVisible):
1479         Check that the object does not have the "invisible" state.
1480         (AccessibilityUIElement::isOffScreen):
1481         Check whether the object has the "offscreen" state.
1482         (AccessibilityUIElement::isCollapsed):
1483         Check whether the object has the "collapsed" state.
1484         (AccessibilityUIElement::hasPopup):
1485         Check whether the object has the "has popup" state.
1486
1487 2010-01-19  Victor Wang  <victorw@chromium.org>
1488
1489         Reviewed by Eric Seidel.
1490
1491         Correct committer name.
1492         https://bugs.webkit.org/show_bug.cgi?id=33868
1493
1494         * Scripts/webkitpy/committers.py:
1495
1496 2010-01-19  Kent Tamura  <tkent@chromium.org>
1497
1498         Reviewed by Darin Adler.
1499
1500         [DRT][Mac] Add modifiers parameter to eventSender.mouseDown() and eventSender.mouseUp()
1501         https://bugs.webkit.org/show_bug.cgi?id=33783
1502
1503         Some listbox tests check selection behavior by click events with
1504         "meta" or "shift" keys. Behaviors for such modifier keys are
1505         platform-dependent. The new parameter of mouseDown() and mouseUp()
1506         allows to specify not only concrete modifier keys such as
1507         "shiftKey" "metaKey", but also functional names like
1508         "addSelectionKey" "rangeSelectionKey".
1509
1510         * DumpRenderTree/mac/EventSendingController.mm:
1511         (+[EventSendingController isSelectorExcludedFromWebScript:]):
1512         (+[EventSendingController webScriptNameForSelector:]):
1513         (buildModifierFlags):
1514         (-[EventSendingController mouseDown:withModifiers:]):
1515         (-[EventSendingController mouseDown:]):
1516         (-[EventSendingController mouseUp:withModifiers:]):
1517         (-[EventSendingController mouseUp:]):
1518         (-[EventSendingController keyDown:withModifiers:withLocation:]):
1519
1520 2010-01-19  Adam Barth  <abarth@webkit.org>
1521
1522         Reviewed by Eric Seidel.
1523
1524         Unbreak --request-commit
1525         https://bugs.webkit.org/show_bug.cgi?id=33832
1526
1527         * Scripts/webkitpy/bugzilla.py:
1528
1529 2010-01-19  Eric Seidel  <eric@webkit.org>
1530
1531         Reviewed by Adam Barth.
1532
1533         validate-committer-lists throws exception and committers.py needs a refresh
1534         https://bugs.webkit.org/show_bug.cgi?id=33831
1535
1536         * Scripts/validate-committer-lists: use webkit_logging
1537         * Scripts/webkitpy/committers.py: Add recently minted committers.  Fix Simon Hausmanns email address list to include his webkit-committers@lists address.
1538
1539 2010-01-18  Adam Roben  <aroben@apple.com>
1540
1541         Add LayoutTestController support for calling new WebKit SPI to
1542         disallow setting document.domain
1543
1544         DRT part of fixing <http://webkit.org/b/33806>
1545         <rdar://problem/7552837> Would like API to disallow setting of
1546         document.domain for pages with certain URL schemes
1547
1548         Reviewed by Sam Weinig.
1549
1550         * DumpRenderTree/LayoutTestController.cpp:
1551         (setDomainRelaxationForbiddenForURLSchemeCallback): Added. Calls
1552         through to LayoutTestController.
1553         (LayoutTestController::staticFunctions): Added
1554         setDomainRelaxationForbiddenForURLScheme.
1555
1556         * DumpRenderTree/LayoutTestController.h: Added
1557         setDomainRelaxationForbiddenForURLScheme.
1558
1559         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1560         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
1561         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1562         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
1563         Added. Calls through to WebKit.
1564
1565         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1566         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
1567         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1568         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
1569         Stubbed out.
1570
1571 2010-01-18  Adam Barth  <abarth@webkit.org>
1572
1573         Reviewed by Adam Roben.
1574
1575         Rename patches-to-commit to patches-in-commit-queue
1576         https://bugs.webkit.org/show_bug.cgi?id=33789
1577
1578         The command really lists the patches in the commit-queue not all the
1579         patches that are pending-commit (as the FIXME commands).
1580
1581         * Scripts/webkitpy/commands/queries.py:
1582         * Scripts/webkitpy/commands/queries_unittest.py:
1583
1584 2010-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1585
1586         Reviewed by Simon Hausmann.
1587
1588         [Qt] Force qmake to generate a single makefile for DerivedSources.pro
1589
1590         * Scripts/webkitdirs.pm:
1591
1592 2010-01-18  Adam Roben  <aroben@apple.com>
1593
1594         Clean up use of /useenv when invoking Visual C++
1595
1596         This change reverts things to their pre-r49485 state. That revision
1597         (and, subsequently, r49664 and r51788) started passing /useenv to
1598         Visual C++, even in cases where we don't want to do so (such as when
1599         invoking Visual C++ Express), in the name of making the Chromium build
1600         work. Now that Chromium isn't using buildVisualStudioProject or
1601         pdevenv, we can put things back they way they were.
1602
1603         Fixes <http://webkit.org/b/33797> build-webkit fails with VC++ Express
1604         (due to /useenv flag)
1605
1606         Reviewed by Sam Weinig.
1607
1608         * Scripts/pdevenv: Always pass /useenv. Chromium doesn't use this
1609         script anymore.
1610         * Scripts/webkitdirs.pm:
1611         (buildVisualStudioProject): Never pass /useenv anymore. pdevenv takes
1612         care of this itself, and we don't want to pass /useenv when not using
1613         pdevenv (e.g., when using VC++ Express, because that will cause it to
1614         ignore the Platform SDK).
1615
1616 2010-01-18  Adam Barth  <abarth@webkit.org>
1617
1618         Reviewed by Eric Seidel.
1619
1620         webkit-patch land-safely should obsolete old patches
1621         https://bugs.webkit.org/show_bug.cgi?id=33788
1622
1623         When posting a commit-queue+ patch with land-safely, we should
1624         obsolete the old patches on the bug.  They're really confusing
1625         because the main use case is to address reviewer feedback on a
1626         previous patch.
1627
1628         * Scripts/webkitpy/commands/upload.py:
1629         * Scripts/webkitpy/commands/upload_unittest.py:
1630
1631 2010-01-18  Adam Barth  <abarth@webkit.org>
1632
1633         Reviewed by David Levin.
1634
1635         webkit-patch should authenticate more often
1636         https://bugs.webkit.org/show_bug.cgi?id=33701
1637
1638         This makes it easier to work with security patches.
1639
1640         * Scripts/webkitpy/bugzilla.py:
1641
1642 2010-01-18  Adam Barth  <abarth@webkit.org>
1643
1644         Reviewed by Darin Adler.
1645
1646         style checker needs to know about GObject-specific requirements
1647         inside WebCore/bindings/gobject/
1648         https://bugs.webkit.org/show_bug.cgi?id=33606
1649
1650         Add an exception to the underscore rule for certain
1651         GObject-specific names.
1652
1653         * Scripts/webkitpy/style/cpp_style.py:
1654         * Scripts/webkitpy/style/cpp_style_unittest.py:
1655
1656 2010-01-18  Adam Barth  <abarth@webkit.org>
1657
1658         Reviewed by Shinichiro Hamaji.
1659
1660         [check-webkit-style] does understand ResourceHandleWin.h
1661         https://bugs.webkit.org/show_bug.cgi?id=32975
1662
1663         I'm not 100% convinced this fix is correct, but without more examples,
1664         it's hard to generalize.  We can always generalize the fix in the
1665         future.
1666
1667         * Scripts/webkitpy/style/cpp_style.py:
1668         * Scripts/webkitpy/style/cpp_style_unittest.py:
1669
1670 2010-01-18  Adam Barth  <abarth@webkit.org>
1671
1672         Unreviewed "build" fix.
1673
1674         * Scripts/webkitpy/bugzilla.py:
1675
1676 2010-01-18  Adam Barth  <abarth@webkit.org>
1677
1678         Unreviewed.  Actually make land-safely mark commit-queue+ as
1679         discussed with Eric.
1680
1681         * Scripts/webkitpy/bugzilla.py:
1682         * Scripts/webkitpy/steps/postdiffforcommit.py:
1683
1684 2010-01-17  Adam Barth  <abarth@webkit.org>
1685
1686         Reviewed by Darin Adler.
1687
1688         style-queue complains about one-line macros that include multiple statements
1689         https://bugs.webkit.org/show_bug.cgi?id=33173
1690
1691         Add an exception for multiple statements on a line that starts a macro.
1692
1693         * Scripts/webkitpy/style/cpp_style.py:
1694         * Scripts/webkitpy/style/cpp_style_unittest.py:
1695
1696 2010-01-17  Adam Barth  <abarth@webkit.org>
1697
1698         Reviewed by Darin Adler.
1699
1700         [check-webkit-style] qt unit testing false positives
1701         https://bugs.webkit.org/show_bug.cgi?id=32833
1702
1703         Exempt the Qt API and unit tests from the style checker.
1704
1705         * Scripts/webkitpy/style/cpp_style.py:
1706         * Scripts/webkitpy/style/cpp_style_unittest.py:
1707
1708 2010-01-17  Adam Barth  <abarth@webkit.org>
1709
1710         Reviewed by Darin Adler.
1711
1712         style-check script reports loads of errors on gtk2drawing.c
1713         https://bugs.webkit.org/show_bug.cgi?id=33771
1714
1715         Exempt WebCore/platform/gtk/gtk2drawing.c and
1716         WebCore/platform/gtk/gtk2drawing.h from style checks.
1717
1718         * Scripts/webkitpy/style/cpp_style.py:
1719         * Scripts/webkitpy/style/cpp_style_unittest.py:
1720
1721 2010-01-17  Chris Jerdonek  <cjerdonek@webkit.org>
1722
1723         Reviewed by Shinichiro Hamaji.
1724
1725         Finished eliminating _cpp_style_state global state variable from
1726         check-webkit-style code and eliminating _CppStyleState class.
1727
1728         https://bugs.webkit.org/show_bug.cgi?id=33764
1729
1730         * Scripts/webkitpy/style/checker.py:
1731           - Minor updates caused by changes to cpp_style.py.
1732
1733         * Scripts/webkitpy/style/cpp_style.py:
1734           - Removed _CppStyleState class.
1735           - Removed verbose_level functions.
1736           - Added verbosity as a parameter to _FunctionState constructor.
1737           - Added verbosity as a parameter to process_file().
1738           - Added verbosity as a parameter to process_file_data().
1739
1740         * Scripts/webkitpy/style/cpp_style_unittest.py:
1741           - Added helper functions to set verbosity while running tests.
1742
1743 2010-01-17  Adam Barth  <abarth@webkit.org>
1744
1745         Reviewed by Shinichiro Hamaji.
1746
1747         check-webkit-style underscore check should be disabled for Qt methods starting with qt_
1748         https://bugs.webkit.org/show_bug.cgi?id=33663
1749
1750         * Scripts/webkitpy/style/cpp_style.py:
1751         * Scripts/webkitpy/style/cpp_style_unittest.py:
1752
1753 2010-01-17  Adam Barth  <abarth@webkit.org>
1754
1755         Reviewed by Eric Seidel.
1756
1757         style-queue complains about missing #include of config.h for non-WebCore projects
1758         https://bugs.webkit.org/show_bug.cgi?id=33170
1759
1760         WebKitAPITests are consumers of the WebKit API and therefore do not
1761         need to follow the same include discipline as the rest of WebKit.  This
1762         patch exempts them from the include checks.
1763
1764         * Scripts/webkitpy/style/cpp_style.py:
1765         * Scripts/webkitpy/style/cpp_style_unittest.py:
1766
1767 2010-01-17  Adam Barth  <abarth@webkit.org>
1768
1769         Reviewed by Eric Seidel.
1770
1771         EWS (Early Warning Systems) should build both debug and release
1772         https://bugs.webkit.org/show_bug.cgi?id=33681
1773
1774         Build both debug and release for chromium-ews.
1775
1776         * Scripts/webkitpy/commands/early_warning_system.py:
1777
1778 2010-01-17  Adam Barth  <abarth@webkit.org>
1779
1780         Reviewed by Darin Adler.
1781
1782         style-queue should include instructions for how to file bugs against check-webkit-style
1783         https://bugs.webkit.org/show_bug.cgi?id=32345
1784
1785         Added some text to the error message asking folks to file bugs against
1786         false positives.
1787
1788         * Scripts/webkitpy/commands/queues.py:
1789
1790 2010-01-17  Chris Jerdonek  <cjerdonek@webkit.org>
1791
1792         Reviewed by Adam Barth.
1793
1794         Eliminated the error_count global variable and related
1795         check-webkit-style refactoring.
1796
1797         https://bugs.webkit.org/show_bug.cgi?id=33678
1798
1799         * Scripts/check-webkit-style:
1800           - Updated to use webkit_argument_defaults().
1801           - Renamed styleChecker to style_checker.
1802
1803         * Scripts/webkitpy/style/checker.py:
1804           - Prefixed the three default arguments with WEBKIT_DEFAULT.
1805           - Added webkit_argument_defaults().
1806           - Added default filter_rules parameter to CategoryFilter constructor.
1807           - Added __ne__() to CategoryFilter class.
1808           - Added __eq__() and __ne__() to ProcessorOptions class.
1809           - Added error_count and _write_error attributes to StyleChecker class.
1810           - Made StyleChecker._handle_error() increment the error count.
1811
1812         * Scripts/webkitpy/style/checker_unittest.py:
1813           - Improved CategoryFilterTest.test_eq().
1814           - Added CategoryFilterTest.test_ne().
1815           - Added test_eq() and test_ne() to ProcessorOptionsTest class.
1816           - Updated unit tests to use webkit_argument_defaults().
1817           - Added StyleCheckerTest class.
1818
1819         * Scripts/webkitpy/style/cpp_style.py:
1820           - Removed references to global error_count.
1821
1822         * Scripts/webkitpy/style/cpp_style_unittest.py:
1823           - Removed CppStyleStateTest class.
1824
1825 2010-01-15  Jon Honeycutt  <jhoneycutt@apple.com>
1826
1827         get_accParent should try to retrieve parent AccessibilityObject, before
1828         calling upon window
1829
1830         https://bugs.webkit.org/show_bug.cgi?id=22893
1831
1832         Reviewed by Darin Adler.
1833
1834         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1835         (AccessibilityUIElement::parentElement):
1836         Get the object's parent. Query it for IAccessible, and return it.
1837
1838 2010-01-16  Dan Bernstein  <mitz@apple.com>
1839
1840         Reviewed by Mark Rowe.
1841
1842         <rdar://problem/7529519> DumpRenderTree crashes in makeLargeMallocFailSilently()
1843
1844         * DumpRenderTree/mac/CheckedMalloc.cpp:
1845         (makeLargeMallocFailSilently): Temporarily allow writing to the default
1846         malloc zone structure while modifying it.
1847
1848 2010-01-16  David Kilzer  <ddkilzer@apple.com>
1849
1850         Added back removed properties to iExploder input files
1851
1852         While the update-iexploder-cssproperties script works great to
1853         add new properties, it has the side-effect of removing old
1854         properties that once were parsed.
1855
1856         * iExploder/htdocs/cssproperties.in: Added back removed
1857         properties into their own section.
1858         * iExploder/htdocs/htmlattrs.in: Ditto.
1859
1860 2010-01-16  Holger Hans Peter Freyther  <zecke@selfish.org>
1861
1862         Reviewed by David Kilzer.
1863
1864         Update iExploder/htdocs/*.in by running update-iexploder-cssproperties 
1865         https://bugs.webkit.org/show_bug.cgi?id=33756
1866
1867         * iExploder/htdocs/cssproperties.in: New CSS attributes
1868         * iExploder/htdocs/htmlattrs.in: New HTML attributes
1869         * iExploder/htdocs/htmltags.in: New HTML tags
1870
1871 2010-01-15  Chris Jerdonek  <chris.jerdonek@gmail.com>
1872
1873         Reviewed by David Kilzer.
1874
1875         Altered parseDiffHeader() to skip unrecognized lines and
1876         other minor clean-ups.
1877
1878         https://bugs.webkit.org/show_bug.cgi?id=33476
1879
1880         * Scripts/VCSUtils.pm:
1881           - Changed parseDiffHeader() as follows:
1882             - Skips over unrecognized lines.
1883             - Addressed FIXME to remove substitution for "diff" line.
1884             - Renamed "version" header hash key to "sourceRevision".
1885             - Eliminated "copiedFromVersion" header hash key.
1886             - Included "sourceRevision" also for copied files.
1887             - Checks that copy revision number matches "sourceRevision".
1888             - No longer returns $foundHeaderEnding.
1889             - Dies if header ending not found.
1890             - Diff header dividing line now always added.
1891
1892         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
1893           - Made necessary changes in parseDiffHeader() unit tests.
1894           - Shortened the file paths in some test cases.
1895
1896 2010-01-14  Yuzo Fujishima  <yuzo@google.com>
1897
1898         Reviewed by Alexey Proskuryakov.
1899
1900         Update pywebsocket to 0.4.6
1901         https://bugs.webkit.org/show_bug.cgi?id=32299
1902         The newer pywebsocket can handle more simultaneous connections.
1903
1904         * pywebsocket/mod_pywebsocket/handshake.py:
1905         * pywebsocket/mod_pywebsocket/standalone.py:
1906         * pywebsocket/setup.py:
1907         * pywebsocket/test/test_handshake.py:
1908
1909 2010-01-14  Eric Seidel  <eric@webkit.org>
1910
1911         Reviewed by Adam Barth.
1912
1913         REGRESSION(53133): commit-queue no longer rejects patches with invalid committers, instead it hangs
1914         https://bugs.webkit.org/show_bug.cgi?id=33638
1915
1916         * Scripts/webkitpy/bugzilla.py:
1917          - Add Bug.id() to match Attachment.id()
1918          - Give Bug.reviewed_patches and commit_queued_patches the option to return patches with invalid committers/reviewers.
1919          - Add back a missing variable to _validate_setter_email found by the new unit tests!
1920         * Scripts/webkitpy/commands/queries.py:
1921          - Add FIXMEs about the commands being confusingly named.
1922         * Scripts/webkitpy/commands/queries_unittest.py:
1923          - Update results to reflect the newly restructured mock bug cache.
1924         * Scripts/webkitpy/commands/queues.py:
1925          - Add a new _validate_patches_in_commit_queue method (this is what fixes the regression).
1926          - Add a FIXME about eventually sorting the patches into some order.
1927         * Scripts/webkitpy/commands/queues_unittest.py:
1928          - Update results now that with the newly restructure mock bug cache we're testing cq+'d patches with an invalid committer.
1929         * Scripts/webkitpy/commands/upload_unittest.py:
1930          - Update results to match the newly restructured mock bug cache.
1931         * Scripts/webkitpy/mock_bugzillatool.py:
1932          - Restructure fetch_ methods to not use a manual list of ids, but rather use Bug and Attachment classes to make real queries from all of the Bugs.
1933          - Add a few more attachments and bug dictionaries for use by the tests.
1934
1935 2010-01-13  Diego Gonzalez  <diego.gonzalez@openbossa.org>
1936
1937         Reviewed by Kenneth Christiansen.
1938
1939         [Qt] DRT missing setUserStyleSheetLocation and setUserStyleSheetEnabled in LayoutTestController
1940         https://bugs.webkit.org/show_bug.cgi?id=33617
1941
1942         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1943         (WebCore::WebPage::resetSettings):
1944         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1945         (LayoutTestController::setUserStyleSheetLocation):
1946         (LayoutTestController::setUserStyleSheetEnabled):
1947         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1948
1949 2010-01-14  Adam Roben  <aroben@apple.com>
1950
1951         Add LayoutTestController API to force
1952         -webView:resource:willSendRequest:: to return null
1953
1954         Enables tests for <rdar://problem/7533333> <http://webkit.org/b/33533>
1955         window.onload never fires if page contains an <iframe> with a bad
1956         scheme or whose load is cancelled by returning null from resource load
1957         delegate's willSendRequest
1958
1959         Reviewed by Brady Eidson.
1960
1961         * DumpRenderTree/LayoutTestController.cpp:
1962         (LayoutTestController::LayoutTestController): Initialize new member.
1963         (setWillSendRequestReturnsNullCallback): Call through to
1964         LayoutTestController.
1965         (LayoutTestController::staticFunctions): Added new function.
1966
1967         * DumpRenderTree/LayoutTestController.h: Added
1968         m_willSendRequestReturnsNull.
1969         (LayoutTestController::willSendRequestReturnsNull):
1970         (LayoutTestController::setWillSendRequestReturnsNull):
1971         Added standard accessors.
1972
1973         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1974         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1975         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1976         (ResourceLoadDelegate::willSendRequest):
1977         Return null if LayoutTestController says to.
1978
1979 2010-01-14  Kevin Ollivier  <kevino@theolliviers.com>
1980
1981         [wx] Build fix after removal of XBM support.
1982
1983         * wx/build/settings.py:
1984
1985 2010-01-14  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1986
1987         Reviewed by Simon Hausmann.
1988
1989         Add support for partial building on Symbian.
1990
1991         The build happens in the source directory as out of source builds are
1992         not supported by qmake for Symbian.
1993
1994         Also the actual build isn't started but it is left to the developer
1995         to choose the architecture/configuration.
1996
1997         * Scripts/webkitdirs.pm:
1998
1999 2010-01-14  Simon Hausmann  <simon.hausmann@nokia.com>
2000
2001         Reviewed by Kenneth Rohde Christiansen.
2002
2003         Add support for "detecting" Symbian environments by either
2004         looking for the EPOCROOT environment variable or via --symbian
2005         being passed on the commandline.
2006
2007         * Scripts/webkitdirs.pm:
2008
2009 2010-01-14  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2010
2011         Unreviewed.
2012
2013         [Qt] Use a different Makefile names for sources generation and compilation.
2014         This prevents Makefile overwriting when running build-webkit twice.
2015
2016         * Scripts/webkitdirs.pm:
2017
2018 2010-01-14  Andreas Kling  <andreas.kling@nokia.com>
2019
2020         Reviewed by Kenneth Rohde Christiansen.
2021
2022         [Qt] Add an "alien_QLabel" classId for manual testing of alien widgets.
2023
2024         https://bugs.webkit.org/show_bug.cgi?id=33373
2025
2026         * QtLauncher/main.cpp:
2027         (WebPage::createPlugin):
2028
2029 2010-01-14  Eric Seidel  <eric@webkit.org>
2030
2031         No review, rolling out r53249.
2032         http://trac.webkit.org/changeset/53249
2033         https://bugs.webkit.org/show_bug.cgi?id=33617
2034
2035         This caused http/tests/security/local-user-CSS-from-
2036         remote.html to fail on the Qt Release Build Bot.
2037
2038         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2039         (WebCore::WebPage::resetSettings):
2040         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2041         (LayoutTestController::overridePreference):
2042         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2043
2044 2010-01-14  Chris Jerdonek  <chris.jerdonek@gmail.com>
2045
2046         Reviewed by Shinichiro Hamaji.
2047
2048         Moved error() from cpp_style.py to checker.py.
2049
2050         https://bugs.webkit.org/show_bug.cgi?id=33620
2051
2052         * Scripts/check-webkit-style:
2053           - Addressed FIXME to not set global state.
2054
2055         * Scripts/webkitpy/style/checker.py:
2056           - Added argument validation to ProcessorOptions constructor.
2057           - Added should_report_error() to ProcessorOptions class.
2058           - Removed set_options().
2059           - Added StyleChecker class.
2060
2061         * Scripts/webkitpy/style/checker_unittest.py:
2062           - Added unit test class for ProcessorOptions class.
2063           - Added unit test to check that parse() strips white space.
2064
2065         * Scripts/webkitpy/style/cpp_style.py:
2066           - Removed "filter" and "output_format" methods.
2067           - Removed should_print_error() and error() functions.
2068           - Removed default parameter value from process_file().
2069
2070         * Scripts/webkitpy/style/cpp_style_unittest.py:
2071           - Removed call to cpp_style._should_print_error().
2072           - Removed test_filter() and test_filter_appending().
2073
2074         * Scripts/webkitpy/style/text_style.py:
2075           - Removed default parameter value from process_file().
2076
2077 2010-01-14  Diego Gonzalez  <diego.gonzalez@openbossa.org>
2078
2079         Reviewed by Kenneth Rohde Christiansen.
2080
2081         [Qt] DRT missing setUserStyleSheetLocation and setUserStyleSheetEnabled in LayoutTestController
2082         https://bugs.webkit.org/show_bug.cgi?id=33617
2083
2084         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2085         (WebCore::WebPage::resetSettings):
2086         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2087         (LayoutTestController::setUserStyleSheetLocation):
2088         (LayoutTestController::setUserStyleSheetEnabled):
2089         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2090
2091 2010-01-13  Adam Barth  <abarth@webkit.org>
2092
2093         Reviewed by Eric Seidel.
2094
2095         Fix CloseBugForLandDiff unittest to actually run
2096         https://bugs.webkit.org/show_bug.cgi?id=33640
2097
2098         * Scripts/webkitpy/mock_bugzillatool.py:
2099         * Scripts/webkitpy/steps/closebugforlanddiff_unittest.py:
2100
2101 2010-01-12  Jon Honeycutt  <jhoneycutt@apple.com>
2102
2103         MSAA: selected, selectable, extended selectable, and multiple
2104         selectable states are not reported
2105
2106         https://bugs.webkit.org/show_bug.cgi?id=33574
2107         <rdar://problem/7536826>
2108
2109         Reviewed by Darin Adler.
2110
2111         * DumpRenderTree/AccessibilityUIElement.cpp:
2112         (getIsSelectableCallback):
2113         Return the result of calling isSelectable().
2114         (getIsMultiSelectableCallback):
2115         Return the result of calling isMultiSelectable().
2116         (AccessibilityUIElement::getJSClass):
2117         Add isSelected and isMultiSelectable properties to the JSClass
2118         definition.
2119
2120         * DumpRenderTree/AccessibilityUIElement.h:
2121         Declare isSelectable() and isMultiSelectable().
2122
2123         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2124         (AccessibilityUIElement::isSelectable):
2125         Stubbed.
2126         (AccessibilityUIElement::isMultiSelectable):
2127         Stubbed.
2128
2129         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2130         (AccessibilityUIElement::isSelectable):
2131         Stubbed.
2132         (AccessibilityUIElement::isMultiSelectable):
2133         Stubbed.
2134
2135         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2136         (accessibilityState):
2137         Get the object's state, and return it.
2138         (AccessibilityUIElement::isSelected):
2139         Check the object's selected state.
2140         (AccessibilityUIElement::isSelectable):
2141         Check the object's selectable state.
2142         (AccessibilityUIElement::isMultiSelectable):
2143         Check the object's extended/multiple selectable state.
2144
2145 2010-01-13  Adam Barth  <abarth@webkit.org>
2146
2147         Unreviewed.  Repeat the below for CloseBugForLandDiff.
2148
2149         * Scripts/test-webkitpy:
2150         * Scripts/webkitpy/steps/closebugforlanddiff.py:
2151         * Scripts/webkitpy/steps/closebugforlanddiff_unittest.py: Added.
2152
2153 2010-01-13  Adam Barth  <abarth@webkit.org>
2154
2155         Unreviewed.  Turn the mac-ews status bubbles back on now that this bot
2156         is running again.
2157
2158         * QueueStatusServer/templates/statusbubble.html:
2159
2160 2010-01-13  Adam Barth  <abarth@webkit.org>
2161
2162         Reviewed by Darin Adler.
2163
2164         REGRESSION(53133): webkit-patch land dies if it can't find a bug id.
2165         https://bugs.webkit.org/show_bug.cgi?id=33634
2166
2167         Deal with the case of no bug patch object in the state.
2168
2169         * Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py:
2170         * Scripts/webkitpy/steps/updatechangelogswithreviewer.py:
2171
2172 2010-01-13  Kenneth Russell  <kbr@google.com>
2173
2174         Unreviewed; added myself to the committers list.
2175
2176         * Scripts/webkitpy/committers.py:
2177
2178 2010-01-13  Darin Adler  <darin@apple.com>
2179
2180         Ignore compiled Python in more of webkitpy.
2181
2182         * Scripts/webkitpy/commands: Added property svn:ignore.
2183         * Scripts/webkitpy/steps: Added property svn:ignore.
2184         * Scripts/webkitpy/style: Added property svn:ignore.
2185
2186 2010-01-13  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2187
2188         Reviewed by Simon Hausmann.
2189
2190         [Qt] Fix build problem related to the pushd command
2191
2192         * Scripts/webkitdirs.pm:
2193
2194 2010-01-13  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2195
2196         Reviewed by Simon Hausmann.
2197
2198         [Qt] Split the build process in two different .pro files.
2199         This allows qmake to be run once all source files are available.
2200
2201         * Scripts/webkitdirs.pm: Add calls to make DerivedSources.pro in JSC and WC.
2202
2203 2010-01-13  Shinichiro Hamaji  <hamaji@chromium.org>
2204
2205         Unreviewed tiny typo fix in docstrings.
2206
2207         * Scripts/webkitpy/style/checker_unittest.py:
2208
2209 2010-01-13  Chris Jerdonek  <chris.jerdonek@gmail.com>
2210
2211         Reviewed by Shinichiro Hamaji.
2212
2213         Created a CategoryFilter class to encapsulate the logic of
2214         filter rules.
2215
2216         https://bugs.webkit.org/show_bug.cgi?id=33454
2217
2218         * Scripts/webkitpy/style/checker.py:
2219           - Added CategoryFilter class.
2220
2221         * Scripts/webkitpy/style/checker_unittest.py:
2222           - Added CategoryFilter unit tests.
2223
2224         * Scripts/webkitpy/style/cpp_style.py:
2225           - Updated filter methods to use CategoryFilter.
2226
2227         * Scripts/webkitpy/style/cpp_style_unittest.py:
2228           - Updated references to filters.
2229
2230 2010-01-12  Shinichiro Hamaji  <hamaji@chromium.org>
2231
2232         Unreviewed. Now I can review :)
2233
2234         * Scripts/webkitpy/committers.py:
2235
2236 2010-01-12  Brent Fulgham  <bfulgham@webkit.org>
2237
2238         Reviewed by Darin Adler.
2239
2240         Extend WinLauncher example with better printing features.
2241
2242         * WinLauncher/PrintWebUIDelegate.cpp:
2243         (PrintWebUIDelegate::webViewPrintingMarginRect): Provide slightly
2244          larger margins.
2245         (PrintWebUIDelegate::webViewHeaderHeight): Compute header height based
2246          on text metrics.
2247         (PrintWebUIDelegate::webViewFooterHeight): Compute footer height based
2248          on text metrics.
2249         (PrintWebUIDelegate::drawHeaderInRect): Write useful header, along
2250          with separating line.
2251         (PrintWebUIDelegate::drawFooterInRect):
2252         * WinLauncher/PrintWebUIDelegate.h: Remove stubs.
2253         * WinLauncher/WinLauncher.cpp:
2254         (PrintView): Correct loop used to print individual pages.
2255          Previously it started at 0, which is a wild-card to print all
2256          pages at once.
2257
2258 2010-01-12  Alexey Proskuryakov  <ap@apple.com>
2259
2260         Reviewed by Darin Adler.
2261
2262         https://bugs.webkit.org/show_bug.cgi?id=33540
2263         Make it possible to build in debug mode with assertions disabled
2264
2265         * DumpRenderTree/mac/ObjCController.m: (-[ObjCController accessStoredWebScriptObject]):
2266
2267 2010-01-11  Darin Fisher  <darin@chromium.org>
2268
2269         Reviewed by Dimitri Glazkov.
2270
2271         [Chromium] "build-webkit --chromium" should run "make all" on Linux
2272         https://bugs.webkit.org/show_bug.cgi?id=33500
2273
2274         * Scripts/webkitdirs.pm:
2275
2276 2010-01-12  Eric Seidel  <eric@webkit.org>
2277
2278         Reviewed by Adam Barth.
2279
2280         AssignToCommitter does not need to fetch bugs twice
2281         https://bugs.webkit.org/show_bug.cgi?id=33530
2282
2283         This is a no-brainer patch now that we've added Bug.reviewed_patches
2284
2285         * Scripts/webkitpy/commands/upload.py:
2286
2287 2010-01-12  Eric Seidel  <eric@webkit.org>
2288
2289         Reviewed by Adam Barth.
2290
2291         bugzilla.py should have an Attachment object instead of passing around dictionaries
2292         https://bugs.webkit.org/show_bug.cgi?id=31594
2293
2294         * Scripts/webkitpy/bugzilla.py:
2295          - Add a new Attachment class, with accessor methods for all the necessary properties.
2296          - Update Bug to carry a pointer back to bugzilla (attachments need to access Bugzilla for committer validation and url())
2297          - Move reviewed_patches and commit_queued_patches out of Bugzilla custom methods and onto Bug
2298          - Move committer validation logic into its own class.
2299          - Committer rejection is only used in one place.  Make the new Bug reviewed_patches and commit_queued_patches
2300            handle the common case (of returning "reviewer" or "committer" as None), and let CommitterValidation handle
2301            the case where we want to reject patches in bugzilla.
2302          - Simplify fetch_patches_from_commit_queue now that committer validation is simpler.
2303          - Make all self.bugzilla.fetch_bug access go through BugzillaQueries._fetch_bug.
2304          - Mark set_flag_on_attachment as non-private to denote that CommitterValidation depends on it.
2305          - Move fetch_reviewed_patches_from_bug and fetch_commit_queue_patches_from_bug logic onto the Bug class.
2306         * Scripts/webkitpy/bugzilla_unittest.py:
2307          - Move test_flag_permission_rejection_message into a new CommitterValidationTest class.
2308         * Scripts/webkitpy/commands/download.py:
2309          - Store "bug_id" in state instead of making a fake patch object.
2310          - Update to use Attachment and Bug objects.
2311         * Scripts/webkitpy/commands/download_unittest.py:
2312          - Update expected results now that our testing framework covers more code.
2313         * Scripts/webkitpy/commands/early_warning_system.py: Update to use new Attachment class.
2314         * Scripts/webkitpy/commands/queries.py: Remove unused ReviewedPatches class.
2315         * Scripts/webkitpy/commands/queries_unittest.py: ditto.
2316         * Scripts/webkitpy/commands/queues.py: Update to use new Attachment and CommitterValidator classes.
2317         * Scripts/webkitpy/commands/queuestest.py: ditto.
2318         * Scripts/webkitpy/commands/upload.py: ditto.
2319         * Scripts/webkitpy/mock_bugzillatool.py:
2320          - Now that more logic has moved into Attachment and Bug, we have to actually
2321            provide real reviewer emails as well as real reviewer flags.
2322          - Update mock methods to return Attachment objects.
2323         * Scripts/webkitpy/scm.py: Update to use Attachment class.
2324         * Scripts/webkitpy/scm_unittest.py: Update to use Attachment class.
2325         * Scripts/webkitpy/statusserver.py: ditto.
2326         * Scripts/webkitpy/steps/applypatch.py: ditto.
2327         * Scripts/webkitpy/steps/applypatchwithlocalcommit.py: ditto.
2328         * Scripts/webkitpy/steps/closebug.py: ditto.
2329         * Scripts/webkitpy/steps/closebugforlanddiff.py: Handle either state["bug_id"] or state["patch"].bug_id()
2330         * Scripts/webkitpy/steps/closepatch.py: Update to use Attachment class.
2331         * Scripts/webkitpy/steps/obsoletepatches.py: ditto.
2332         * Scripts/webkitpy/steps/updatechangelogswithreviewer.py: ditto.
2333
2334 2010-01-12  Adam Barth  <abarth@webkit.org>
2335
2336         Unreviewed typo fix.  :(
2337
2338         * Scripts/webkitpy/commands/early_warning_system.py:
2339         * Scripts/webkitpy/commands/queues.py:
2340
2341 2010-01-12  Adam Barth  <abarth@webkit.org>
2342
2343         Unreviewed.  Add "error" to the right part of the message.
2344
2345         * Scripts/webkitpy/commands/queues.py:
2346
2347 2010-01-12  Adam Barth  <abarth@webkit.org>
2348
2349         Reviewed by Eric Seidel.
2350
2351         EWS should show purple when svn-apply fails
2352         https://bugs.webkit.org/show_bug.cgi?id=33527
2353
2354         * Scripts/webkitpy/commands/early_warning_system.py:
2355         * Scripts/webkitpy/commands/queues.py:
2356
2357 2010-01-12  Adam Barth  <abarth@webkit.org>
2358
2359         Reviewed by Eric Seidel.
2360
2361         Remove copy/paste code from subclasses of AbstractReviewQueue
2362         https://bugs.webkit.org/show_bug.cgi?id=33525
2363
2364         * Scripts/webkitpy/commands/early_warning_system.py:
2365         * Scripts/webkitpy/commands/queues.py:
2366
2367 2010-01-12  Adam Barth  <abarth@webkit.org>
2368
2369         Reviewed by Eric Seidel.
2370
2371         Add Gustavo and Xan as gtk-ews watchers
2372         https://bugs.webkit.org/show_bug.cgi?id=33519
2373
2374         * Scripts/webkitpy/commands/early_warning_system.py:
2375
2376 2010-01-12  Adam Barth  <abarth@webkit.org>
2377
2378         Reviewed by Eric Seidel.
2379
2380         webkit-patch shouldn't waste my time for with a component prompt
2381         https://bugs.webkit.org/show_bug.cgi?id=33521
2382
2383         The component field isn't very useful for bugs created with
2384         webkit-patch because they're likely to be resolved quickly.  Instead of
2385         always prompting for a component, we should just default to the "New
2386         Bugs" component.  If the bug stays around for more than five minutes,
2387         we can assign it a proper component.
2388
2389         * Scripts/webkitpy/bugzilla.py:
2390
2391 2010-01-12  Adam Barth  <abarth@webkit.org>
2392
2393         Reviewed by Eric Seidel.
2394
2395         Add experimental "land-safely" command to webkit-patch
2396         https://bugs.webkit.org/show_bug.cgi?id=33518
2397
2398         * Scripts/webkitpy/commands/upload.py:
2399         * Scripts/webkitpy/commands/upload_unittest.py:
2400         * Scripts/webkitpy/steps/__init__.py:
2401         * Scripts/webkitpy/steps/postdiffforcommit.py: Added.
2402
2403 2010-01-11  Kevin Ollivier  <kevino@theolliviers.com>
2404
2405         [wx] Build fix after introduction of JS_NO_EXPORT
2406         
2407         * wx/build/settings.py:
2408
2409 2010-01-11  Eric Seidel  <eric@webkit.org>
2410
2411         No review, rolling out r53079.
2412         http://trac.webkit.org/changeset/53079
2413         https://bugs.webkit.org/show_bug.cgi?id=33197
2414
2415         Adam doens't think this actually works, and believe it caused
2416         a regression https://bugs.webkit.org/show_bug.cgi?id=33488 so
2417         rolling this out.
2418
2419         * Scripts/test-webkitpy:
2420         * Scripts/webkitpy/commands/abstractdiffcommand.py: Removed.
2421         * Scripts/webkitpy/commands/abstractdiffcommand_unittest.py: Removed.
2422         * Scripts/webkitpy/commands/download.py:
2423         * Scripts/webkitpy/commands/upload.py:
2424         * Scripts/webkitpy/mock_bugzillatool.py:
2425
2426 2010-01-10  Adam Barth  <abarth@webkit.org>
2427
2428         Reviewed by David Kilzer.
2429
2430         bugzilla-tool submit-patch mistakenly picks up bug URLs in non-ChangeLog files
2431         https://bugs.webkit.org/show_bug.cgi?id=33197
2432
2433         We should just search for bug numbers in the ChangeLogs instead of in
2434         the whole diff.
2435  
2436         * Scripts/test-webkitpy:
2437         * Scripts/webkitpy/commands/abstractdiffcommand.py: Added.
2438         * Scripts/webkitpy/commands/abstractdiffcommand_unittest.py: Added.
2439         * Scripts/webkitpy/commands/download.py:
2440         * Scripts/webkitpy/commands/upload.py:
2441         * Scripts/webkitpy/mock_bugzillatool.py:
2442
2443 2010-01-11  Chris Jerdonek  <chris.jerdonek@gmail.com>
2444
2445         Reviewed by David Kilzer.
2446
2447         Created a unit-tested function to parse the header block of
2448         a Git or SVN diff -- for future refactoring of svn-apply and
2449         svn-unapply.
2450
2451         https://bugs.webkit.org/show_bug.cgi?id=33447
2452
2453         * Scripts/VCSUtils.pm:
2454           - Added parseDiffHeader().
2455           - Removed irrelevant comment from gitdiff2svndiff().
2456
2457         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl: Added.
2458           - Added 48 unit tests for parseDiffHeader().
2459
2460 2010-01-10  Adam Barth  <abarth@webkit.org>
2461
2462         Rubber stamped by David Kilzer.
2463
2464         bugzilla-tool submit-patch mistakenly picks up bug URLs in non-ChangeLog files
2465         https://bugs.webkit.org/show_bug.cgi?id=33197
2466
2467         Fix a typo: Commmand -> Command.
2468
2469         * Scripts/webkitpy/commands/abstractsequencedcommand.py:
2470         * Scripts/webkitpy/commands/download.py:
2471         * Scripts/webkitpy/commands/queries.py:
2472         * Scripts/webkitpy/commands/upload.py:
2473         * Scripts/webkitpy/multicommandtool.py:
2474
2475 2010-01-10  Adam Barth  <abarth@webkit.org>
2476
2477         Reviewed by Darin Adler.
2478
2479         Let webkit-patch work with options in $EDITOR
2480         https://bugs.webkit.org/show_bug.cgi?id=33414
2481
2482         The $EDITOR evironment variable might have command line options like
2483         bbedit -w.  This patch lets us run those $EDITORs.
2484
2485         * Scripts/webkitpy/user.py:
2486
2487 2010-01-10  Robert Hogan  <robert@roberthogan.net>
2488
2489         Reviewed by Adam Barth.
2490
2491         [Qt] Add enableXSSAuditor support to QWebSettings and DRT.
2492
2493         https://bugs.webkit.org/show_bug.cgi?id=33419
2494
2495         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2496         (WebCore::WebPage::WebPage):
2497         (WebCore::WebPage::resetSettings):
2498         (WebCore::DumpRenderTree::createWindow):
2499         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2500         (LayoutTestController::setXSSAuditorEnabled):
2501         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2502
2503 2010-01-10  Adam Barth  <abarth@webkit.org>
2504
2505         Unreviewed cosmetic change.  Remove the status bubble for mac-ews
2506         because we don't have hardware for it at the moment.
2507
2508         * QueueStatusServer/templates/statusbubble.html:
2509
2510 2010-01-09  Daniel Bates  <dbates@webkit.org>
2511
2512         No review, rolling out r53044.
2513         http://trac.webkit.org/changeset/53044
2514         https://bugs.webkit.org/show_bug.cgi?id=33419
2515         
2516         We need to look into this some more because the Qt
2517         bot is failing the XSSAuditor tests. See bug #33419
2518         for more details.
2519
2520         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2521         (WebCore::WebPage::WebPage):
2522         (WebCore::WebPage::resetSettings):
2523         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2524         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2525
2526 2010-01-09  Daniel Bates  <dbates@webkit.org>
2527
2528         Reviewed by Adam Barth.
2529
2530         https://bugs.webkit.org/show_bug.cgi?id=33419
2531
2532         Adds support for the XSSAuditor to the Qt DRT.
2533
2534         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2535         (WebCore::WebPage::WebPage):
2536         (WebCore::WebPage::resetSettings):
2537         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2538         (LayoutTestController::setXSSAuditorEnabled):
2539         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2540
2541 2010-01-09  Adam Barth  <abarth@webkit.org>
2542
2543         Reviewed by Eric Seidel.
2544
2545         Retry writes to QueueStatusServer when we get 500 errors
2546         https://bugs.webkit.org/show_bug.cgi?id=33412
2547
2548         This prevents the queues from failing to mark a patch as "pass" or
2549         "fail" when AppEngine throws 500 errors.
2550
2551         * Scripts/test-webkitpy:
2552         * Scripts/webkitpy/networktransaction.py: Added.
2553         * Scripts/webkitpy/networktransaction_unittest.py: Added.
2554         * Scripts/webkitpy/statusserver.py:
2555         * Scripts/webkitpy/steps/closebugformarkbugfixed.py: Added.
2556         * Scripts/webkitpy/steps/closebugregardlessofpatches.py: Added.
2557         * Scripts/webkitpy/steps/findbugidfromsvnrevision.py: Added.
2558
2559 2010-01-09  David Kilzer  <ddkilzer@apple.com>
2560
2561         <http://webkit.org/b/33430> Fix rounded borders in queue status on older Firefox and Safari browsers
2562
2563         Reviewed by Eric Seidel.
2564
2565         * QueueStatusServer/templates/statusbubble.html: Added
2566         -moz-border-radius and -webkit-border-radius to provide rounded
2567         borders in older Firefox and Safari browsers.
2568
2569 2010-01-09  Chris Jerdonek  <chris.jerdonek@gmail.com>
2570
2571         Reviewed by David Kilzer.
2572
2573         Modified VCSUtils::gitdiff2svndiff() to accept strings that
2574         end in vertical white space.
2575
2576         https://bugs.webkit.org/show_bug.cgi?id=33415
2577
2578         * Scripts/VCSUtils.pm:
2579         * Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl:
2580
2581 2010-01-08  Eric Seidel  <eric@webkit.org>
2582
2583         Reviewed by Adam Barth.
2584
2585         run-javascriptcore-tests needs a --quiet flag
2586         https://bugs.webkit.org/show_bug.cgi?id=33399
2587
2588         Until run-javascriptcore-tests has a --quiet flag, lets just stiffle the output in webkit-patch.
2589
2590         * Scripts/webkitpy/steps/runtests.py:
2591
2592 2010-01-08  Andras Becsi  <abecsi@inf.u-szeged.hu>
2593
2594         Reviewed by Alexey Proskuryakov.
2595
2596         Only run http and websocket tests as last if no argument is given to be able to explicitly control the test order.
2597
2598         To be able to run multiple instances of run-webkit-tests besides each other on the same machine we need to minimize
2599         the time when Apache and WebSocketServer is locked by tests.
2600         Because closeHTTPD() and closeWebSocketServer() is only called at the end of the testing,
2601         we need to run http and websocket tests after all other tests.
2602         If one however explicitly specifies the tests to run in the argument list of run-webkit-tests
2603         we need to preserve the given order.
2604
2605         * Scripts/run-webkit-tests:
2606
2607 2010-01-08  Adam Barth  <abarth@webkit.org>
2608
2609         Reviewed by Eric Seidel.
2610
2611         Don't post style-queue pass messages to bugs
2612         https://bugs.webkit.org/show_bug.cgi?id=33404
2613
2614         These messages aren't needed any more now that we have the status
2615         bubble reporting pass events passively.
2616
2617         * Scripts/webkitpy/commands/queues.py:
2618
2619 2010-01-08  Adam Barth  <abarth@webkit.org>
2620
2621         Reviewed by Eric Seidel.
2622
2623         Optimize the number of CPUs used for building Qt and Gtk
2624         https://bugs.webkit.org/show_bug.cgi?id=33394
2625
2626         Instead of hardcoding the number 8, we should read the number of CPUs
2627         from the environment.
2628
2629         * Scripts/webkitpy/executive.py:
2630         * Scripts/webkitpy/webkitport.py:
2631         * Scripts/webkitpy/webkitport_unittest.py:
2632
2633 2010-01-08  Chris Fleizach  <cfleizach@apple.com>
2634
2635         Reviewed by Eric Seidel.
2636
2637         REGRESSION(52819?): AXLoadComplete and AXLayoutComplete causes 4 tests fail on Snow Leopard Debug bot
2638         https://bugs.webkit.org/show_bug.cgi?id=33300
2639
2640         * DumpRenderTree/AccessibilityUIElement.h:
2641         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2642         (AccessibilityUIElement::AccessibilityUIElement):
2643         (AccessibilityUIElement::~AccessibilityUIElement):
2644         (_accessibilityNotificationCallback):
2645         (AccessibilityUIElement::addNotificationListener):
2646
2647 2010-01-08  Eric Seidel  <eric@webkit.org>
2648
2649         Reviewed by Simon Hausmann.
2650
2651         commit-queue should run run-javascriptcore-tests
2652         https://bugs.webkit.org/show_bug.cgi?id=33376
2653
2654         I also made it run the python and perl unit tests.
2655
2656         * Scripts/webkitpy/steps/runtests.py:
2657         * Scripts/webkitpy/webkitport.py:
2658
2659 2010-01-07  Andras Becsi  <abecsi@inf.u-szeged.hu>
2660
2661         Reviewed by Darin Adler.
2662
2663         Run the http and websocket tests after all other tests.
2664         https://bugs.webkit.org/show_bug.cgi?id=33153
2665
2666         * Scripts/run-webkit-tests:
2667
2668 2010-01-07  Adam Barth  <abarth@webkit.org>
2669
2670         Reviewed by Eric Seidel.
2671
2672         Fix some test-webkitpy expectations
2673         https://bugs.webkit.org/show_bug.cgi?id=33345
2674
2675         I forgot to change these when I added the CheckStyle step.
2676
2677         * Scripts/webkitpy/commands/upload_unittest.py:
2678
2679 2010-01-07  Adam Barth  <abarth@webkit.org>
2680
2681         Reviewed by Eric Seidel.
2682
2683         webkit-patch edit-changelogs (or upload) will open blank files if run outside the root
2684         https://bugs.webkit.org/show_bug.cgi?id=33341
2685
2686         Fix this by moving to the root directory before editing ChangeLogs.
2687         There is a related bug with CheckStyle.
2688
2689         * Scripts/webkitpy/steps/checkstyle.py:
2690         * Scripts/webkitpy/steps/editchangelog.py:
2691
2692 2010-01-07  Eric Seidel  <eric@webkit.org>
2693
2694         Reviewed by Nikolas Zimmermann.
2695
2696         media/unsupported-tracks.html is failing on Snow Leopard Release bot
2697         https://bugs.webkit.org/show_bug.cgi?id=32339
2698
2699         This is a speculative fix.  I do not have a Snow Leopard machine to test on
2700         and I've not seen mention of someone being able to reproduce this locally.
2701
2702         Prevent watchdog timer from firing after a test completes but before
2703         the next one starts, causing the error to appear in the next test.
2704
2705         * DumpRenderTree/mac/DumpRenderTree.mm:
2706         (dump): Stop the watchdog before printing #EOF for the test content.
2707         We only need to care about the JavaScript of the test running too long
2708         or some hang in WebCore.  Any other failures will be covered by the calling
2709         script's own watchdog timer.
2710
2711 2010-01-07  Eric Seidel  <eric@webkit.org>
2712
2713         Reviewed by Adam Barth.
2714
2715         commit-queue is stuck spinning due to exception
2716         https://bugs.webkit.org/show_bug.cgi?id=33358
2717
2718         * Scripts/webkitpy/commands/queues.py:
2719          - Don't try to stringify the exception.
2720
2721 2010-01-07  Mark Rowe  <mrowe@apple.com>
2722
2723         Reviewed by Jon Honeycutt.
2724
2725         Don't leak a JSStringRef within _accessibilityNotificationCallback.
2726
2727         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2728         (_accessibilityNotificationCallback): Have a JSRetainPtr adopt the JSStringRef so that it will be cleaned up
2729         when it goes out of scope.
2730
2731 2010-01-07  Simon Fraser  <simon.fraser@apple.com>
2732
2733         Reviewed by Darin Adler.
2734
2735         Add proposed rename of HTMLPlugInImageElement to HTMLEmbeddedObjectElement.
2736
2737         * Scripts/do-webcore-rename:
2738
2739 2010-01-07  Kim Grönholm  <kim.gronholm@nomovok.com>
2740
2741         Reviewed by Antti Koivisto.
2742
2743         Wrong state and TouchLists in TouchEvents
2744         https://bugs.webkit.org/show_bug.cgi?id=32878
2745
2746         * DumpRenderTree/qt/EventSenderQt.cpp:
2747         (EventSender::touchStart):
2748         (EventSender::touchEnd):
2749         (EventSender::clearTouchPoints):
2750         * DumpRenderTree/qt/EventSenderQt.h:
2751
2752 2010-01-07  Chris Jerdonek  <chris.jerdonek@gmail.com>
2753
2754         Reviewed by Adam Barth.
2755
2756         Created a module that runs the style package unit tests.
2757
2758         https://bugs.webkit.org/show_bug.cgi?id=32973
2759
2760         * Scripts/test-webkitpy:
2761         * Scripts/webkitpy/style/unittests.py: Added.
2762
2763 2010-01-07  Adam Barth  <abarth@webkit.org>
2764
2765         Reviewed by Maciej Stachowiak.
2766
2767         Don't print a redundant message when confirming a diff
2768         https://bugs.webkit.org/show_bug.cgi?id=33315
2769
2770         Instead of saying "ERROR: User declined" we should just exit because
2771         the use knows they just declined!
2772
2773         * Scripts/webkitpy/steps/confirmdiff.py:
2774
2775 2010-01-07  Adam Barth  <abarth@webkit.org>
2776
2777         Reviewed by Maciej Stachowiak.
2778
2779         Check style before uploading a patch
2780         https://bugs.webkit.org/show_bug.cgi?id=33314
2781
2782         * Scripts/webkitpy/commands/upload.py:
2783         * Scripts/webkitpy/steps/checkstyle.py:
2784         * Scripts/webkitpy/steps/options.py:
2785
2786 2010-01-07  Adam Barth  <abarth@webkit.org>
2787
2788         Reviewed by Maciej Stachowiak.
2789
2790         Add prepare and post to webkit-patch main help
2791         https://bugs.webkit.org/show_bug.cgi?id=33313
2792
2793         * Scripts/webkitpy/commands/upload.py:
2794
2795 2010-01-07  Eric Seidel  <eric@webkit.org>
2796
2797         Reviewed by Adam Barth.
2798
2799         Add Chromium bots to the list of "core builders" (builders which stop the commit-queue when they turn red)
2800         https://bugs.webkit.org/show_bug.cgi?id=33290
2801
2802         Add the Chromium builders to our list of core builders and test that our regexps work.
2803         I also updated our regexp testing to make sure we cover all known builders at build.webkit.org.
2804
2805         * Scripts/webkitpy/buildbot.py:
2806         * Scripts/webkitpy/buildbot_unittest.py:
2807
2808 2010-01-07  Adam Barth  <abarth@webkit.org>
2809
2810         Reviewed by Eric Seidel.
2811
2812         bugzilla-tool needs a new name
2813         https://bugs.webkit.org/show_bug.cgi?id=28459
2814
2815         Rename bugzilla-tool to webkit-patch.  Also, rename some commands to
2816         make more sense with the new name.
2817
2818         * Scripts/bugzilla-tool: Removed.
2819         * Scripts/webkit-patch: Added.
2820         * Scripts/webkit-tools-completion.sh:
2821         * Scripts/webkitpy/bugzilla_unittest.py:
2822         * Scripts/webkitpy/commands/download.py:
2823         * Scripts/webkitpy/commands/download_unittest.py:
2824         * Scripts/webkitpy/commands/early_warning_system.py:
2825         * Scripts/webkitpy/commands/queries.py:
2826         * Scripts/webkitpy/commands/queues.py:
2827         * Scripts/webkitpy/commands/queues_unittest.py:
2828         * Scripts/webkitpy/commands/upload.py:
2829         * Scripts/webkitpy/commands/upload_unittest.py:
2830         * Scripts/webkitpy/queueengine.py:
2831         * Scripts/webkitpy/steps/completerollout.py:
2832
2833 2010-01-07  Chris Jerdonek  <chris.jerdonek@gmail.com>
2834
2835         Reviewed by Eric Seidel.
2836
2837         Moved style-related modules to webkitpy.style sub-package.
2838
2839         https://bugs.webkit.org/show_bug.cgi?id=32971
2840
2841         * Scripts/check-webkit-style:
2842           - Updated import statement.
2843
2844         * Scripts/test-webkitpy:
2845           - Updated import statements.
2846
2847         * Scripts/webkitpy/cpp_style.py: Removed.
2848           - Moved to webkitpy/style.
2849
2850         * Scripts/webkitpy/cpp_style_unittest.py: Removed.
2851           - Moved to webkitpy/style.
2852
2853         * Scripts/webkitpy/style.py: Removed.
2854           - Moved to webkitpy/style/checker.py.
2855
2856         * Scripts/webkitpy/style/__init__.py: Added.
2857           - Added containing webkitpy directory to package search path.
2858
2859         * Scripts/webkitpy/style/checker.py: Copied from Scripts/webkitpy/style.py.
2860         * Scripts/webkitpy/style/checker_unittest.py: Copied from Scripts/webkitpy/style_unittest.py.
2861           - Updated import statement.
2862
2863         * Scripts/webkitpy/style/cpp_style.py: Copied from Scripts/webkitpy/cpp_style.py.
2864         * Scripts/webkitpy/style/cpp_style_unittest.py: Copied from Scripts/webkitpy/cpp_style_unittest.py.
2865           - Update import statement.
2866
2867         * Scripts/webkitpy/style/text_style.py: Copied from Scripts/webkitpy/text_style.py.
2868         * Scripts/webkitpy/style/text_style_unittest.py: Copied from Scripts/webkitpy/text_style_unittest.py.
2869         * Scripts/webkitpy/style_unittest.py: Removed.
2870           - Moved to webkitpy/style/checker_unittest.py.
2871
2872         * Scripts/webkitpy/text_style.py: Removed.
2873           - Moved to webkitpy/style.
2874
2875         * Scripts/webkitpy/text_style_unittest.py: Removed.
2876           - Moved to webkitpy/style.
2877
2878 2010-01-06  Kinuko Yasuda  <kinuko@chromium.org>
2879
2880         Reviewed by Eric Seidel.
2881
2882         [Qt] Support the 3rd argument of EventSender.keyDown that
2883         has been recently added to report keyLocation
2884         (see also: https://bugs.webkit.org/show_bug.cgi?id=28247).
2885         https://bugs.webkit.org/show_bug.cgi?id=33250
2886
2887         Test: fast/events/keydown-numpad-keys.html
2888
2889         * DumpRenderTree/qt/EventSenderQt.cpp:
2890         (EventSender::keyDown):
2891         * DumpRenderTree/qt/EventSenderQt.h:
2892
2893 2010-01-06  Eric Seidel  <eric@webkit.org>
2894
2895         Reviewed by Adam Barth.
2896
2897         Add long_help for all common commands.
2898         https://bugs.webkit.org/show_bug.cgi?id=33261
2899
2900         For now these long_helps are pretty basic.
2901         These were all written to just explain the steps
2902         that each command runs.  This style long_help could
2903         be made easier by using:
2904         https://bugs.webkit.org/show_bug.cgi?id=33257
2905
2906         * Scripts/webkitpy/commands/download.py:
2907         * Scripts/webkitpy/commands/queries.py:
2908
2909 2010-01-06  Diego Gonzalez  <diego.gonzalez@openbossa.org>
2910
2911         Reviewed by Kenneth Christiansen.
2912
2913         [Qt] Add page zooming support to Qt DumpRenderTree
2914         https://bugs.webkit.org/show_bug.cgi?id=32898
2915
2916         Patch by Kim Grönholm  <kim.gronholm@nomovok.com>,
2917                  Diego Gonzalez <diego.gonzalez@openbossa.org> and
2918                  Afonso Costa <afonso.costa@openbossa.org>
2919
2920         * DumpRenderTree/qt/EventSenderQt.cpp:
2921         (EventSender::zoomPageIn):
2922         (EventSender::zoomPageOut):
2923         * DumpRenderTree/qt/EventSenderQt.h:
2924
2925 2010-01-06  Eric Seidel  <eric@webkit.org>
2926
2927         No review, just adding Mike Belshe's new bugzilla email at his request.
2928
2929         * Scripts/webkitpy/committers.py:
2930
2931 2010-01-06  Eric Seidel  <eric@webkit.org>
2932
2933         Unreviewed.  Rolling out r52869 and r52853 due to bot
2934         and local run-webkit-test failures
2935
2936         REGRESSION(52854?) fast/workers/shared-worker-constructor.html failed on Leopard Build Bot
2937         https://bugs.webkit.org/show_bug.cgi?id=33256
2938
2939         The original bug was https://bugs.webkit.org/show_bug.cgi?id=33153
2940
2941         * Scripts/run-webkit-tests:
2942
2943 2010-01-06  Eric Seidel  <eric@webkit.org>
2944
2945         Unreviewed "build" fix.  Just adding missing include.
2946
2947         bugzilla-tool rollout --complete-rollout should make a nicer bug comment
2948         https://bugs.webkit.org/show_bug.cgi?id=29212
2949
2950         * Scripts/webkitpy/steps/completerollout.py:
2951
2952 2010-01-06  Eric Seidel  <eric@webkit.org>
2953
2954         Reviewed by Adam Barth.
2955
2956         bugzilla-tool rollout --complete-rollout should make a nicer bug comment
2957         https://bugs.webkit.org/show_bug.cgi?id=29212
2958
2959         * Scripts/webkitpy/bugzilla.py:
2960          - Make reopen_bug robust against the bug already being open.
2961         * Scripts/webkitpy/commands/download.py:
2962          - Remove dead code from Rollout.
2963         * Scripts/webkitpy/steps/completerollout.py:
2964          - Improve the rollout comment.
2965
2966 2010-01-06  Andras Becsi  <abecsi@inf.u-szeged.hu>
2967
2968         Reviewed by Darin Adler.
2969
2970         Set isHttpdOpen to 0 if pidfile does not exist for some reason.
2971         Speculative fix for https://bugs.webkit.org/show_bug.cgi?id=33256.
2972
2973         * Scripts/run-webkit-tests:
2974
2975 2010-01-06  Andras Becsi  <abecsi@inf.u-szeged.hu>
2976
2977         Reviewed by Darin Adler.
2978
2979         Change hardcoded /tmp in run-webkit-tests to File::Spec->tmpdir(),
2980         and remove the httpd's pidfile directory if httpd terminated.
2981
2982         * Scripts/run-webkit-tests:
2983
2984 2010-01-05  Chris Jerdonek  <chris.jerdonek@gmail.com>
2985
2986         Reviewed by David Levin.
2987
2988         Refactored check-webkit-style's argument parser to not rely
2989         on global state, and improved its error handling and unit
2990         test coverage.
2991
2992         https://bugs.webkit.org/show_bug.cgi?id=32966
2993
2994         * Scripts/check-webkit-style:
2995           - Adjusted to use new argument parser.
2996
2997         * Scripts/webkitpy/cpp_style.py:
2998           - Changed _CppStyleState to accept an array of filter rules
2999             instead of a comma-delimited string.
3000           - Eliminated cpp_style._DEFAULT_FILTER_RULES.
3001           - Eliminated cpp_style._USAGE.
3002
3003         * Scripts/webkitpy/cpp_style_unittest.py:
3004           - Updated test_filter() and test_default_filter().
3005
3006         * Scripts/webkitpy/style.py:
3007           - Converted style._USAGE to create_usage().
3008           - Corrected usage instructions by removing 0 as a valid
3009             --verbose flag value.
3010           - Removed use_webkit_styles().
3011           - Added ProcessorOptions class.
3012           - Added ArgumentDefaults class.
3013           - Added ArgumentPrinter class.
3014           - Removed parse_arguments and added ArgumentParser class.
3015           - Moved exit_with_usage() and exit_with_categories() into
3016             ArgumentParser.
3017           - Refactored parse_arguments() as ArgumentParser.parse().
3018           - Improved parser error handling.
3019
3020         * Scripts/webkitpy/style_unittest.py:
3021           - Added DefaultArgumentsTest class.
3022           - Addressed FIXME to check style.WEBKIT_FILTER_RULES
3023             against style.STYLE_CATEGORIES.
3024           - Added ArgumentPrinterTest class.
3025           - Added ArgumentParserTest class and rewrote parser unit tests.
3026
3027 2010-01-05  Adam Roben  <aroben@apple.com>
3028
3029         Test that it's safe to call IWebView::close when
3030         IWebView::initWithFrame hasn't been called
3031
3032         Part of <http://webkit.org/b/32827> Crash when calling
3033         IWebView::close, then releasing the WebView, without calling
3034         DestroyWindow
3035
3036         Reviewed by Steve Falkenburg.
3037
3038         * WebKitAPITest/tests/WebViewDestruction.cpp:
3039         (WebKitAPITest::CloseWithoutInitWithFrame): Calls IWebView::close
3040         without ever calling IWebView::initWithFrame and tests that we don't
3041         crash or leak.
3042
3043 2010-01-05  Adam Roben  <aroben@apple.com>
3044
3045         Add more WebViewDestruction tests
3046
3047         Fixes <http://webkit.org/b/33216>.
3048
3049         Reviewed by Eric Seidel.
3050
3051         * WebKitAPITest/tests/WebViewDestruction.cpp:
3052         (WebKitAPITest::NoInitWithFrame):
3053         (WebKitAPITest::CloseThenDestroyViewWindow):
3054         (WebKitAPITest::DestroyViewWindowThenClose):
3055         (WebKitAPITest::DestroyHostWindow):
3056         (WebKitAPITest::DestroyHostWindowThenClose):
3057         (WebKitAPITest::CloseThenDestroyHostWindow):
3058         Added these tests that exercise tearing down a WebView in various
3059         ways, all of which we eventually want to have work. Some of them
3060         currently crash or leak.
3061
3062 2010-01-05  Robert Hogan  <robert@roberthogan.net>
3063
3064         Reviewed by Eric Seidel.
3065
3066         [Qt] fix DRT link failures on --no-svg builds when only making changes to DRT
3067         
3068         If you're working from a --minimal or --no-svg build and make changes to the
3069         DRT, then recompile, the build will fail.
3070         
3071         This is because the current behavior at build time is to assume that the
3072         previous Qt build supported SVG and consequently delete libQtWebKit.so.
3073         Unfortunately, just deleting libQtWebKit.so will not cause the library to
3074         re-link. Instead the build will see libQtWebKit.so.4 and co., pass over the
3075         linking phase, and attempt to link the DRT with libQtWebKit.so absent. This
3076         results in a link failure on the DRT.
3077         
3078         Since re-linking libQtWebKit can take up to ten minutes and should be avoided
3079         in cases where not actually required, remove the assumption that
3080         the previous Qt build supported SVG, and amend the symbol detection to look for
3081         a symbol name that is not present in SVG builds. Currently webkitdirs.pm looks
3082         for 'SVGElement' but even non-SVG builds contain the symbol 'isSVGElement'.
3083         
3084         https://bugs.webkit.org/show_bug.cgi?id=32992
3085
3086         * Scripts/webkitdirs.pm:
3087
3088 2010-01-05  Chris Jerdonek  <chris.jerdonek@gmail.com>
3089
3090         Reviewed by David Kilzer.
3091
3092         Switched to generating list of Perl unit test files dynamically,
3093         instead of explicitly.
3094
3095         https://bugs.webkit.org/show_bug.cgi?id=33200
3096
3097         * Scripts/test-webkitperl:
3098
3099 2010-01-05  Yael Aharon  <yael.aharon@nokia.com>
3100
3101         Reviewed by Kenneth Rohde Christiansen.
3102
3103         [Qt] Reimplement EventSender::leapForward
3104         https://bugs.webkit.org/show_bug.cgi?id=33114
3105
3106         Follow Windows implementation of leapForward. When leapForward is called, 
3107         messages are queued and posted after the timeout. A new event loop is created to
3108         handle those messages and the additional messages that are created as a result.
3109
3110         * DumpRenderTree/qt/DumpRenderTree.pro:
3111         * DumpRenderTree/qt/EventSenderQt.cpp:
3112         (EventSender::EventSender):
3113         (EventSender::mouseDown):
3114         (EventSender::mouseUp):
3115         (EventSender::mouseMoveTo):
3116         (EventSender::leapForward):
3117         (EventSender::sendOrQueueEvent):
3118         (EventSender::replaySavedEvents):
3119         (EventSender::eventFilter):
3120         * DumpRenderTree/qt/EventSenderQt.h:
3121
3122 2010-01-05  Adam Barth  <abarth@webkit.org>
3123
3124         Reviewed by Darin Adler.
3125
3126         Fix obscure queue crash in queueengine
3127         https://bugs.webkit.org/show_bug.cgi?id=33196
3128
3129         Sometimes we get an exception that can't be stringified.  For example:
3130
3131         AttributeError: 'ParseError' object has no attribute 'msg'
3132
3133         In these cases, the whole queue dies because we're in the global
3134         exception handler.  Instead of dieing here, we should just print a less
3135         informative message to the console.  We're already printing the whole
3136         backtrace anyway, so there's not much point to stringifying the
3137         exception anyway.
3138
3139         * Scripts/webkitpy/queueengine.py:
3140
3141 2010-01-05  Dominic Mazzoni  <dmazzoni@google.com>
3142
3143         Reviewed by Darin Adler.
3144
3145         https://bugs.webkit.org/show_bug.cgi?id=32571
3146
3147         For an object with an aria role of "checkbox" or "radiobutton",
3148         use the "aria-checked" attribute to determine if it's checked.
3149         These changes add an isChecked() method to AccessibilityUIElement
3150         so that we can check for this property from a layout test.
3151
3152         * DumpRenderTree/AccessibilityUIElement.cpp:
3153         (getIsCheckedCallback):
3154         (AccessibilityUIElement::getJSClass):
3155         * DumpRenderTree/AccessibilityUIElement.h:
3156         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3157         (AccessibilityUIElement::isChecked):
3158         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3159         (AccessibilityUIElement::isChecked):
3160         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3161         (AccessibilityUIElement::isChecked):
3162
3163 2010-01-05  David Levin  <levin@chromium.org>
3164
3165         Reviewed by Darin Adler.
3166
3167         Having a comment for the #endif for a header guard is not required WebKit style.
3168         https://bugs.webkit.org/show_bug.cgi?id=33214
3169
3170         * Scripts/webkitpy/cpp_style.py: removed the check and made the loop exit
3171           early when it has all the needed information to continue.
3172         * Scripts/webkitpy/cpp_style_unittest.py: removed the corresponding tests.
3173
3174 2010-01-05  Adam Roben  <aroben@apple.com>
3175
3176         Share more code in the WebViewDestruction tests
3177
3178         Part of <http://webkit.org/b/33212> Small fixes/improvements to
3179         WebKitAPITest
3180
3181         Reviewed by Sam Weinig.
3182
3183         * WebKitAPITest/tests/WebViewDestruction.cpp:
3184         (WebKitAPITest::createAndInitializeWebView): Renamed from
3185         createWebView. Now initializes the HostWindow and returns the
3186         WebView's HWND via an out-parameter.
3187         (WebKitAPITest::finishWebViewDestructionTest): Added. Code came from
3188         the CloseWithoutDestroyWindow test.
3189         (WebKitAPITest::CloseWithoutDestroyViewWindow): Renamed from
3190         CloseWithoutDestroyWindow and changed to use the new functions.
3191         (WebKitAPITest::MainFrameAfterClose): Changed to use the new
3192         functions.
3193         (WebKitAPITest::NoCloseOrDestroyViewWindow): Renamed from
3194         NoCloseOrDestroyWindow and changed to use the new functions.
3195
3196 2010-01-05  Adam Roben  <aroben@apple.com>
3197
3198         Don't show HostWindows by default
3199
3200         This was making WebKitAPITest very flashy as windows appeared and
3201         disappeared.
3202
3203         Part of <http://webkit.org/b/33212> Small fixes/improvements to
3204         WebKitAPITest
3205
3206         Reviewed by Sam Weinig.
3207
3208         * WebKitAPITest/HostWindow.cpp:
3209         (WebKitAPITest::HostWindow::initialize): Removed the WS_VISIBLE style
3210         from the window.
3211
3212 2010-01-05  Adam Roben  <aroben@apple.com>
3213
3214         Don't hang in WebKitAPITest if no messages have been posted
3215
3216         Part of <http://webkit.org/b/33212> Small fixes/improvements to
3217         WebKitAPITest
3218
3219         Reviewed by Sam Weinig.
3220
3221         * WebKitAPITest/tests/WebViewDestruction.cpp:
3222         (WebKitAPITest::runMessagePump): Use PeekMessage instead of GetMessage
3223         to avoid hanging if no messages have been posted.
3224
3225 2010-01-05  Adam Roben  <aroben@apple.com>
3226
3227         Fix WebKitCreateInstance helper
3228
3229         Part of <http://webkit.org/b/33212> Small fixes/improvements to
3230         WebKitAPITest
3231
3232         Reviewed by Sam Weinig.
3233
3234         * WebKitAPITest/tests/WebViewDestruction.cpp:
3235         (WebKitAPITest::WebKitCreateInstance): Pass the pointer straight
3236         through, instead of taking its address.
3237
3238 2010-01-04  Maciej Stachowiak  <mjs@apple.com>
3239
3240         Reviewed by Darin Fisher.
3241
3242         Reorganize, document and rename OS() platform macros.
3243         https://bugs.webkit.org/show_bug.cgi?id=33198
3244
3245         Adapt to name changes.
3246         
3247         * DumpRenderTree/DumpRenderTree.h:
3248         * DumpRenderTree/config.h:
3249
3250 2010-01-05  Chris Jerdonek  <chris.jerdonek@gmail.com>
3251
3252         Reviewed by Eric Seidel.
3253
3254         Minor improvements to test-webkit-scripts, as suggested
3255         by an earlier review.
3256
3257         https://bugs.webkit.org/show_bug.cgi?id=33125
3258
3259         * Scripts/test-webkit-scripts:
3260           - Used OptionParser class instead of getopt.getopt().
3261           - Created main() method for __main__ block.
3262           - Enclosed functions in a class.
3263
3264 2010-01-05  Chris Fleizach  <cfleizach@apple.com>
3265
3266         No review. Fix DRT breakage on Tiger/Leopard.
3267
3268         Add ARIA "Live Region" support
3269         https://bugs.webkit.org/show_bug.cgi?id=33117
3270
3271         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3272
3273 2010-01-04  Chris Fleizach  <cfleizach@apple.com>
3274
3275         Reviewed by Darin Adler.
3276
3277         Add ARIA "Live Region" support
3278         https://bugs.webkit.org/show_bug.cgi?id=33117
3279
3280         * DumpRenderTree/AccessibilityUIElement.cpp:
3281         (indexOfChildCallback):
3282         (boolAttributeValueCallback):
3283         (stringAttributeValueCallback):
3284         (addNotificationListenerCallback):
3285         (AccessibilityUIElement::getJSClass):
3286         * DumpRenderTree/AccessibilityUIElement.h:
3287         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3288         (AccessibilityUIElement::indexOfChild):
3289         (AccessibilityUIElement::stringAttributeValue):
3290         (AccessibilityUIElement::boolAttributeValue):
3291         (AccessibilityUIElement::addNotificationListener):
3292         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3293         (AccessibilityUIElement::indexOfChild):
3294         (AccessibilityUIElement::stringAttributeValue):
3295         (AccessibilityUIElement::boolAttributeValue):
3296         (_accessibilityNotificationCallback):
3297         (AccessibilityUIElement::addNotificationListener):
3298         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3299         (AccessibilityUIElement::indexOfChild):
3300         (AccessibilityUIElement::stringAttributeValue):
3301         (AccessibilityUIElement::boolAttributeValue):
3302         (AccessibilityUIElement::addNotificationListener):
3303
3304 2010-01-04  Eric Seidel  <eric@webkit.org>
3305
3306         Reviewed by Adam Barth.
3307
3308         bugzilla-tool rollout should require a reason
3309         https://bugs.webkit.org/show_bug.cgi?id=30810
3310
3311         * Scripts/webkitpy/changelogs.py: Add support for a reason, add auto-wrapping logic.
3312         * Scripts/webkitpy/changelogs_unittest.py: Test reason support.
3313         * Scripts/webkitpy/commands/download.py: rollout now requires a reason, remove unused BUGID argument
3314         * Scripts/webkitpy/commands/download_unittest.py: pass required reason
3315         * Scripts/webkitpy/steps/preparechangelogforrevert.py: pass reason to update_for_revert
3316
3317 2010-01-04  Jon Honeycutt  <jhoneycutt@apple.com>
3318
3319         MSAA: <select> elements should broadcast value change events
3320
3321         https://bugs.webkit.org/show_bug.cgi?id=33088
3322
3323         <rdar://problem/7332364>
3324
3325         Reviewed by Darin Adler.
3326
3327         * DumpRenderTree/AccessibilityController.cpp:
3328         (logValueChangeEventsCallback):
3329         Start logging value change events.
3330         (AccessibilityController::getJSClass):
3331         Add a "logValueChangeEvents" to the AccessibilityController's JS class
3332         definition.
3333         (AccessibilityController::resetToConsistentState):
3334         Disable logging of value change events.
3335
3336         * DumpRenderTree/AccessibilityController.h:
3337         Declare setLogValueChangeEvents(), and add a member variable for the
3338         value change event hook.
3339
3340         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3341         (AccessibilityController::setLogValueChangeEvents):
3342         Stubbed.
3343
3344         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3345         (AccessibilityController::setLogValueChangeEvents):
3346         Stubbed.
3347
3348         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3349         (AccessibilityController::AccessibilityController):
3350         Initialize new member var.
3351         (AccessibilityController::~AccessibilityController):
3352         Disable logging of value change events.
3353         (logEventProc):
3354         When we receive an EVENT_OBJECT_VALUECHANGE, log the name of the object
3355         and its value.
3356         (AccessibilityController::setLogValueChangeEvents):
3357         If disabling logging, unhook the event, and clear the event hook
3358         member var. Otherwise, query for the root element to enable
3359         accessibility, and hook EVENT_OBJECT_VALUECHANGE.
3360
3361 2010-01-04  Adam Barth  <abarth@webkit.org>
3362
3363         Reviewed by Eric Seidel.
3364
3365         long_help for submit-patch
3366         https://bugs.webkit.org/show_bug.cgi?id=33184
3367
3368         * Scripts/webkitpy/commands/upload.py:
3369
3370 2010-01-04  Adam Barth  <abarth@webkit.org>
3371
3372         Reviewed by Eric Seidel.
3373
3374         commit-queue can wrongly reject patches if the buildbots are behind
3375         https://bugs.webkit.org/show_bug.cgi?id=30098
3376
3377         Check to make sure we can currently build and test before trying to
3378         land a patch.
3379
3380         * Scripts/webkitpy/commands/queues.py:
3381
3382 2010-01-04  Adam Roben  <aroben@apple.com>
3383
3384         Add a test harness for the Windows WebKit API, and a few tests
3385
3386         We currently only have tests for a handful of bugs regarding WebView
3387         destruction, but more tests can easily be added later. Eventually
3388         we'll run these tests as part of run-webkit-tests.
3389
3390         Fixes <http://webkit.org/b/33167>.
3391
3392         Reviewed by Sam Weinig.
3393
3394         * WebKitAPITest/HostWindow.cpp: Added.
3395         (WebKitAPITest::HostWindow::HostWindow): Initialize m_window.
3396         (WebKitAPITest::HostWindow::~HostWindow): Destroy our window if
3397         needed.
3398         (WebKitAPITest::HostWindow::initialize): Create our window.
3399         (WebKitAPITest::HostWindow::clientRect): Return our window's client
3400         rect.
3401         (WebKitAPITest::HostWindow::registerWindowClass): Does what it says.
3402         (WebKitAPITest::HostWindow::wndProc): Just call through to
3403         DefWindowProcW.
3404
3405         * WebKitAPITest/HostWindow.h: Added.
3406         (WebKitAPITest::HostWindow::window): Simple getter.
3407
3408         * WebKitAPITest/Test.h: Added. This file defines some macros useful
3409         for writing tests.
3410
3411         * WebKitAPITest/TestsController.cpp: Added.
3412         (WebKitAPITest::TestsController::TestsController): Initialize our
3413         members.
3414         (WebKitAPITest::TestsController::shared): Return the shared instance.
3415         (WebKitAPITest::TestsController::runAllTests): Run a message pump
3416         until a WM_QUIT message is received, then return whether all tests
3417         succeeded.
3418         (WebKitAPITest::TestsController::addTest): Add the test to m_tests and
3419         start running tests soon.
3420         (WebKitAPITest::TestsController::testFailed): Record the failure and
3421         print a message about it to stdout.
3422         (WebKitAPITest::TestsController::runNextTest): If we don't have any
3423         tests to run, post a WM_QUIT message to stop the message pump.
3424         Otherwise, run the test and print whether it passed, then schedule the
3425         next test.
3426         (WebKitAPITest::TestsController::runNextTestSoon): Set a 0-delay timer
3427         to run the next test.
3428         (WebKitAPITest::TestsController::registerWindowClass): Does what it
3429         says.
3430         (WebKitAPITest::TestsController::wndProc): If the runNextTestTimer
3431         fired, call runNextTest(). Pass everything else through to
3432         DefWindowProcW.
3433
3434         * WebKitAPITest/TestsController.h: Added.
3435
3436         * WebKitAPITest/WebKitAPITest.vcproj: Added.
3437
3438         * WebKitAPITest/WebKitAPITestCommon.vsprops: Added.
3439
3440         * WebKitAPITest/main.cpp: Added.
3441         (main): (Mostly) just calls TestsController::runAllTests.
3442
3443         * WebKitAPITest/tests/WebViewDestruction.cpp: Added.
3444         (WebKitAPITest::WebKitCreateInstance): Helper function template to
3445         call through to the real WebKitCreateInstance.
3446         (WebKitAPITest::webViewCount): Helper function to call through to
3447         IWebKitStatistics::webViewCount.
3448         (WebKitAPITest::createWebView): Helper function to create a WebView
3449         and put it inside a HostWindow.
3450         (WebKitAPITest::runMessagePump): Helper function to run a message pump
3451         for a specified number of milliseconds, or until a WM_QUIT message is
3452         received.
3453         (WebKitAPITest::CloseWithoutDestroyWindow): Test for
3454         <http://webkit.org/b/32827>.
3455         (WebKitAPITest::MainFrameAfterClose): Test for
3456         <http://webkit.org/b/32868>.
3457         (WebKitAPITest::NoCloseOrDestroyWindow): Test for
3458         <http://webkit.org/b/33162>.
3459
3460 2010-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3461
3462         Reviewed by David Kilzer.
3463
3464         Add support for Git's "diff.mnemonicprefix" config option to WebKitTools
3465
3466         https://bugs.webkit.org/show_bug.cgi?id=32820
3467
3468         * Scripts/VCSUtils.pm:
3469         * Scripts/svn-apply:
3470         * Scripts/svn-unapply:
3471         * Scripts/test-webkitperl: Run gitdiff2svndiff test
3472         * Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl: Added.
3473         * Scripts/webkitpy/diff_parser.py:
3474         * Scripts/webkitpy/diff_parser_unittest.py:
3475
3476 2010-01-04  Chris Jerdonek  <chris.jerdonek@gmail.com>
3477
3478         Reviewed by David Kilzer.
3479
3480         Divided the Perl unit tests into separate files and put
3481         them in a separate directory, and renamed test-webkit-perl
3482         to test-webkitperl.
3483
3484         https://bugs.webkit.org/show_bug.cgi?id=33124
3485
3486         * Scripts/VCSUtils.pm:
3487           - Renamed generateRunPatchCommand() to generatePatchCommand().
3488
3489         * Scripts/VCSUtils_unittest.pl: Removed.
3490           - Divided into three files in Scripts/webkitperl/VCSUtils_unittest.
3491
3492         * Scripts/test-webkit-perl: Removed.
3493           - Renamed to test-webkitperl.
3494
3495         * Scripts/test-webkit-scripts:
3496           - Updated paths to test-webkitpy and test-webkitperl.
3497
3498         * Scripts/test-webkitperl: Copied from Scripts/test-webkit-perl.
3499           - Added paths to new test files.
3500
3501         * Scripts/webkitperl: Added.
3502         * Scripts/webkitperl/VCSUtils_unittest: Added.
3503         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl: Added.
3504         * Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl: Added.
3505         * Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl: Copied from Scripts/VCSUtils_unittest.pl.
3506
3507 2010-01-04  Eric Seidel  <eric@webkit.org>
3508
3509         Reviewed by Adam Barth.
3510
3511         Make bugzilla-tool rollout include a bug link in the ChangeLog entry
3512         https://bugs.webkit.org/show_bug.cgi?id=33146
3513
3514         One more step towards better rollouts.
3515
3516         * Scripts/webkitpy/changelogs.py:
3517         * Scripts/webkitpy/changelogs_unittest.py:
3518         * Scripts/webkitpy/steps/preparechangelogforrevert.py:
3519
3520 2010-01-04  Adam Barth  <abarth@webkit.org>
3521
3522         Reviewed by Eric Seidel.
3523
3524         Sort the step options
3525         https://bugs.webkit.org/show_bug.cgi?id=33144
3526
3527         * Scripts/webkitpy/steps/options.py:
3528
3529 2010-01-04  Eric Seidel  <eric@webkit.org>
3530
3531         Reviewed by Adam Barth.
3532
3533         Need support for longer text in per-command help
3534         https://bugs.webkit.org/show_bug.cgi?id=33143
3535
3536         Add some minimal additional help to land-diff and
3537         pave the way for adding better help to all commands.
3538
3539         * Scripts/webkitpy/commands/download.py: Add small amount of additional help to land-diff
3540         * Scripts/webkitpy/multicommandtool.py: support long_help
3541         * Scripts/webkitpy/multicommandtool_unittest.py: test long_help
3542
3543 2010-01-04  Adam Barth  <abarth@webkit.org>
3544
3545         Reviewed by Eric Seidel.
3546
3547         Add unit test for MarkBugFixed
3548         https://bugs.webkit.org/show_bug.cgi?id=33142
3549
3550         MarkBugFixed is way behind in command technology, but it still needs a
3551         unit test, as the FIXME commands.
3552
3553         Also, remove mark-bug-fixed and create-bug from main help since we have
3554         more modern commands to replace them.
3555
3556         * Scripts/webkitpy/commands/upload.py:
3557         * Scripts/webkitpy/commands/upload_unittest.py:
3558         * Scripts/webkitpy/mock_bugzillatool.py:
3559
3560 2010-01-04  Adam Barth  <abarth@webkit.org>
3561
3562         Reviewed by Eric Seidel.
3563
3564         Add missing unit test for CommitMessageForCurrentDiff
3565         https://bugs.webkit.org/show_bug.cgi?id=33141
3566
3567         * Scripts/webkitpy/commands/upload.py:
3568         * Scripts/webkitpy/commands/upload_unittest.py:
3569
3570 2010-01-04  Adam Barth  <abarth@webkit.org>
3571
3572         Reviewed by Eric Seidel.
3573
3574         Remove raw_input from queues in favor of user.prompt
3575         https://bugs.webkit.org/show_bug.cgi?id=33140
3576
3577         This lets up properly mock out the user interaction instead of hacking
3578         around it with the options.
3579
3580         * Scripts/webkitpy/commands/queues.py:
3581         * Scripts/webkitpy/commands/queuestest.py:
3582
3583 2010-01-04  Eric Seidel  <eric@webkit.org>
3584
3585         Reviewed by Adam Barth.
3586
3587         bugzilla-tool should not require users to install mechanize
3588         https://bugs.webkit.org/show_bug.cgi?id=32635
3589
3590         * Scripts/webkitpy/__init__.py: Add missing declaration for ClientForm (which mechanize requires).
3591
3592 2010-01-04  Eric Seidel  <eric@webkit.org>
3593
3594         Reviewed by Adam Barth.
3595
3596         bugzilla-tool should not require users to install mechanize
3597         https://bugs.webkit.org/show_bug.cgi?id=32635
3598
3599         Use the nifty "autoinstall" module from Daniel Krech:
3600         http://pypi.python.org/pypi/autoinstall/0.2
3601         http://code.google.com/p/pyautoinstall/
3602         It's available under a WebKit-compatible BSD license.
3603
3604         * Scripts/webkitpy/__init__.py:
3605          - bind "mechanize" to an autoinstall importer which will
3606            auto-download mechanize if necessary.
3607         * Scripts/webkitpy/autoinstall.py: Added.
3608         * Scripts/webkitpy/bugzilla.py: use "mechanize" instead of webkit_mechanize
3609         * Scripts/webkitpy/statusbot.py: ditto.
3610         * Scripts/webkitpy/webkit_mechanize.py: Removed.
3611
3612 2010-01-04  Adam Barth  <abarth@webkit.org>
3613
3614         Reviewed by Eric Seidel.
3615
3616         [bzt] Move AbstractSequencedCommand to a more general location
3617         https://bugs.webkit.org/show_bug.cgi?id=33137
3618
3619         I do what the FIXME tell me to do.
3620
3621         * Scripts/webkitpy/commands/abstractsequencedcommand.py: Added.
3622         * Scripts/webkitpy/commands/download.py:
3623         * Scripts/webkitpy/commands/upload.py:
3624
3625 2010-01-04  Adam Barth  <abarth@webkit.org>
3626
3627         Reviewed by Eric Seidel.
3628
3629         Rename StatusBot to StatusServer
3630         https://bugs.webkit.org/show_bug.cgi?id=33139
3631
3632         It's not a bot.  It's a server.
3633
3634         * Scripts/bugzilla-tool:
3635         * Scripts/webkitpy/bugzilla.py:
3636         * Scripts/webkitpy/commands/early_warning_system.py:
3637         * Scripts/webkitpy/commands/queues.py:
3638         * Scripts/webkitpy/mock_bugzillatool.py:
3639         * Scripts/webkitpy/queueengine.py:
3640         * Scripts/webkitpy/statusbot.py: Removed.
3641
3642 2010-01-04  Adam Barth  <abarth@webkit.org>
3643
3644         Reviewed by Eric Seidel.
3645
3646         [bzt] submit-pach should have a -o/--open option to open the bug after submit
3647         https://bugs.webkit.org/show_bug.cgi?id=33136
3648
3649         Python makes this very easy.
3650
3651         * Scripts/webkitpy/mock_bugzillatool.py:
3652         * Scripts/webkitpy/steps/options.py:
3653         * Scripts/webkitpy/steps/postdiff.py:
3654         * Scripts/webkitpy/user.py:
3655
3656 2010-01-04  Adam Barth  <abarth@webkit.org>
3657
3658         Reviewed by Eric Seidel.
3659
3660         [bzt] Move steps to a submodule
3661         https://bugs.webkit.org/show_bug.cgi?id=33135
3662
3663         For great victory.  This will probably introduce some regressions
3664         because our test coverage isn't perfect, but I've tried to be careful.
3665
3666         * Scripts/test-webkitpy:
3667         * Scripts/webkitpy/buildsteps.py: Removed.
3668         * Scripts/webkitpy/buildsteps_unittest.py: Removed.
3669         * Scripts/webkitpy/commands/download.py:
3670         * Scripts/webkitpy/commands/upload.py:
3671         * Scripts/webkitpy/steps/__init__.py: Added.
3672         * Scripts/webkitpy/steps/abstractstep.py: Added.
3673         * Scripts/webkitpy/steps/applypatch.py: Added.
3674         * Scripts/webkitpy/steps/applypatchwithlocalcommit.py: Added.
3675         * Scripts/webkitpy/steps/build.py: Added.
3676         * Scripts/webkitpy/steps/checkstyle.py: Added.
3677         * Scripts/webkitpy/steps/cleanworkingdirectory.py: Added.
3678         * Scripts/webkitpy/steps/cleanworkingdirectorywithlocalcommits.py: Added.
3679         * Scripts/webkitpy/steps/closebug.py: Added.
3680         * Scripts/webkitpy/steps/closebugforlanddiff.py: Added.
3681         * Scripts/webkitpy/steps/closepatch.py: Added.
3682         * Scripts/webkitpy/steps/commit.py: Added.
3683         * Scripts/webkitpy/steps/completerollout.py: Added.
3684         * Scripts/webkitpy/steps/confirmdiff.py: Added.
3685         * Scripts/webkitpy/steps/createbug.py: Added.
3686         * Scripts/webkitpy/steps/editchangelog.py: Added.
3687         * Scripts/webkitpy/steps/ensurebuildersaregreen.py: Added.
3688         * Scripts/webkitpy/steps/ensurelocalcommitifneeded.py: Added.
3689         * Scripts/webkitpy/steps/metastep.py: Added.
3690         * Scripts/webkitpy/steps/obsoletepatches.py: Added.
3691         * Scripts/webkitpy/steps/options.py: Added.
3692         * Scripts/webkitpy/steps/postdiff.py: Added.
3693         * Scripts/webkitpy/steps/preparechangelog.py: Added.
3694         * Scripts/webkitpy/steps/preparechangelogforrevert.py: Added.
3695         * Scripts/webkitpy/steps/promptforbugortitle.py: Added.
3696         * Scripts/webkitpy/steps/revertrevision.py: Added.
3697         * Scripts/webkitpy/steps/runtests.py: Added.
3698         * Scripts/webkitpy/steps/steps_unittest.py: Added.
3699         * Scripts/webkitpy/steps/update.py: Added.
3700         * Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py: Added.
3701         * Scripts/webkitpy/steps/updatechangelogswithreviewer.py: Added.
3702         * Scripts/webkitpy/stepsequence.py:
3703
3704 2010-01-04  Daniel Bates  <dbates@webkit.org>
3705
3706         Reviewed by Eric Seidel.
3707
3708         https://bugs.webkit.org/show_bug.cgi?id=33097
3709
3710         Cleans up the File menu to better conform to the File menu in Safari
3711         both in terms of options and keyboard shortcuts. Adds a "Quit" menu
3712         options to close all open windows. Also, renames the Tools menu to
3713         Develop.
3714
3715         * QtLauncher/main.cpp:
3716         (MainWindow::setupUI):
3717
3718 2010-01-04  Daniel Bates  <dbates@webkit.org>
3719
3720         https://bugs.webkit.org/show_bug.cgi?id=33039
3721         
3722         Unreviewed fix.
3723
3724         * Scripts/webkitpy/credentials.py:
3725         * Scripts/webkitpy/credentials_unittest.py:
3726
3727 2010-01-04  Daniel Bates  <dbates@webkit.org>
3728
3729         Reviewed by Eric Seidel.
3730
3731         https://bugs.webkit.org/show_bug.cgi?id=33039
3732
3733         [bzt] Second attempt to fix an issue where bugzilla-tool dies
3734         when the keychain lookup fails to find an entry for bugs.webkit.org.
3735
3736         * Scripts/webkitpy/credentials.py:
3737         * Scripts/webkitpy/credentials_unittest.py:
3738
3739 2010-01-04  Eric Seidel  <eric@webkit.org>
3740
3741         Reviewed by Adam Barth.
3742
3743         Make Rollout an AbstractSequencedCommmand
3744         https://bugs.webkit.org/show_bug.cgi?id=33133
3745
3746         As suggested by Adam in:
3747         https://bugs.webkit.org/show_bug.cgi?id=33131#c2
3748
3749         * Scripts/webkitpy/commands/download.py:
3750
3751 2010-01-04  Eric Seidel  <eric@webkit.org>
3752
3753         Reviewed by Adam Barth.
3754
3755         Make all commands AbstractDeclarativeCommmands instead of direct Command subclasses
3756         https://bugs.webkit.org/show_bug.cgi?id=33131
3757
3758         Evenetually we'll probably roll AbstractDeclarativeCommmand directly into Command
3759         but for now we just deploy it everywhere and don't try to fix up the few valid uses
3760         of Command.
3761
3762         * Scripts/webkitpy/commands/download.py:
3763         * Scripts/webkitpy/commands/queries.py:
3764         * Scripts/webkitpy/commands/upload.py:
3765         * Scripts/webkitpy/multicommandtool.py:
3766
3767 2010-01-03  Adam Barth  <abarth@webkit.org>
3768
3769         Unreviewed "build" fix.  Need to import ScriptError.
3770
3771         * Scripts/webkitpy/buildsteps.py:
3772
3773 2010-01-03  Adam Barth  <abarth@webkit.org>
3774
3775         Reviewed by Eric Seidel.
3776
3777         [bzt] Make it easier to run submit-patch when previous run cancelled
3778         https://bugs.webkit.org/show_bug.cgi?id=33070
3779
3780         This patch renames create-review to submit-patch (as requested by
3781         Maciej).
3782
3783         This patch makes it easier to run submit-patch after the user has
3784         already cancelled a previous run of submit-patch by detecting when we
3785         already have ChangeLogs and reading the bug number from them (and not
3786         attempting to recreate them).  Aside from performance and the extra
3787         edit step, this command should not subsume post-dif.
3788
3789         Also, added a --email command line argument so that the output of
3790         prepare-ChangeLog makes sense when it can't find the user's email
3791         address.
3792
3793         * Scripts/webkitpy/bugzilla.py:
3794         * Scripts/webkitpy/buildsteps.py:
3795         * Scripts/webkitpy/commands/upload.py:
3796         * Scripts/webkitpy/commands/upload_unittest.py:
3797         * Scripts/webkitpy/mock_bugzillatool.py:
3798         * Scripts/webkitpy/user.py:
3799
3800 2010-01-03  Eric Seidel  <eric@webkit.org>
3801
3802         Reviewed by Adam Barth.
3803
3804         Rename Scripts/modules to Scripts/webkitpy
3805         https://bugs.webkit.org/show_bug.cgi?id=33128
3806
3807         Just search-replace and svn mv commands.
3808
3809         * Scripts/bugzilla-tool:
3810         * Scripts/check-webkit-style:
3811         * Scripts/modules: Removed.
3812         * Scripts/modules/BeautifulSoup.py: Removed.
3813         * Scripts/modules/__init__.py: Removed.
3814         * Scripts/modules/bugzilla.py: Removed.
3815         * Scripts/modules/bugzilla_unittest.py: Removed.
3816         * Scripts/modules/buildbot.py: Removed.
3817         * Scripts/modules/buildbot_unittest.py: Removed.
3818         * Scripts/modules/buildsteps.py: Removed.
3819         * Scripts/modules/buildsteps_unittest.py: Removed.
3820         * Scripts/modules/changelogs.py: Removed.
3821         * Scripts/modules/changelogs_unittest.py: Removed.
3822         * Scripts/modules/commands: Removed.
3823         * Scripts/modules/commands/__init__.py: Removed.
3824         * Scripts/modules/commands/commandtest.py: Removed.
3825         * Scripts/modules/commands/download.py: Removed.
3826         * Scripts/modules/commands/download_unittest.py: Removed.
3827         * Scripts/modules/commands/early_warning_system.py: Removed.
3828         * Scripts/modules/commands/early_warning_system_unittest.py: Removed.
3829         * Scripts/modules/commands/queries.py: Removed.
3830         * Scripts/modules/commands/queries_unittest.py: Removed.
3831         * Scripts/modules/commands/queues.py: Removed.
3832         * Scripts/modules/commands/queues_unittest.py: Removed.
3833         * Scripts/modules/commands/queuestest.py: Removed.
3834         * Scripts/modules/commands/upload.py: Removed.
3835         * Scripts/modules/commands/upload_unittest.py: Removed.
3836         * Scripts/modules/comments.py: Removed.
3837         * Scripts/modules/committers.py: Removed.
3838         * Scripts/modules/committers_unittest.py: Removed.
3839         * Scripts/modules/cpp_style.py: Removed.
3840         * Scripts/modules/cpp_style_unittest.py: Removed.
3841         * Scripts/modules/credentials.py: Removed.
3842         * Scripts/modules/credentials_unittest.py: Removed.
3843         * Scripts/modules/diff_parser.py: Removed.
3844         * Scripts/modules/diff_parser_unittest.py: Removed.
3845         * Scripts/modules/executive.py: Removed.
3846         * Scripts/modules/executive_unittest.py: Removed.
3847         * Scripts/modules/grammar.py: Removed.
3848         * Scripts/modules/mock.py: Removed.
3849         * Scripts/modules/mock_bugzillatool.py: Removed.
3850         * Scripts/modules/multicommandtool.py: Removed.
3851         * Scripts/modules/multicommandtool_unittest.py: Removed.
3852         * Scripts/modules/outputcapture.py: Removed.
3853         * Scripts/modules/patchcollection.py: Removed.
3854         * Scripts/modules/queueengine.py: Removed.
3855         * Scripts/modules/queueengine_unittest.py: Removed.
3856         * Scripts/modules/scm.py: Removed.
3857         * Scripts/modules/scm_unittest.py: Removed.
3858         * Scripts/modules/statusbot.py: Removed.
3859         * Scripts/modules/stepsequence.py: Removed.
3860         * Scripts/modules/style: Removed.
3861         * Scripts/modules/style.py: Removed.
3862         * Scripts/modules/style_unittest.py: Removed.
3863         * Scripts/modules/text_style.py: Removed.
3864         * Scripts/modules/text_style_unittest.py: Removed.
3865         * Scripts/modules/user.py: Removed.
3866         * Scripts/modules/webkit_logging.py: Removed.
3867         * Scripts/modules/webkit_logging_unittest.py: Removed.
3868         * Scripts/modules/webkit_mechanize.py: Removed.
3869         * Scripts/modules/webkitport.py: Removed.
3870         * Scripts/modules/webkitport_unittest.py: Removed.
3871         * Scripts/test-webkit-python: Removed.
3872         * Scripts/test-webkitpy: Copied from WebKitTools/Scripts/test-webkit-python.
3873         * Scripts/validate-committer-lists:
3874         * Scripts/webkitpy: Copied from WebKitTools/Scripts/modules.
3875         * Scripts/webkitpy/bugzilla.py:
3876         * Scripts/webkitpy/bugzilla_unittest.py:
3877         * Scripts/webkitpy/buildbot.py:
3878         * Scripts/webkitpy/buildbot_unittest.py:
3879         * Scripts/webkitpy/buildsteps.py:
3880         * Scripts/webkitpy/buildsteps_unittest.py:
3881         * Scripts/webkitpy/commands/commandtest.py:
3882         * Scripts/webkitpy/commands/download.py:
3883         * Scripts/webkitpy/commands/download_unittest.py:
3884         * Scripts/webkitpy/commands/early_warning_system.py:
3885         * Scripts/webkitpy/commands/early_warning_system_unittest.py:
3886         * Scripts/webkitpy/commands/queries.py:
3887         * Scripts/webkitpy/commands/queries_unittest.py:
3888         * Scripts/webkitpy/commands/queues.py:
3889         * Scripts/webkitpy/commands/queues_unittest.py:
3890         * Scripts/webkitpy/commands/queuestest.py:
3891         * Scripts/webkitpy/commands/upload.py:
3892         * Scripts/webkitpy/commands/upload_unittest.py:
3893         * Scripts/webkitpy/comments.py:
3894         * Scripts/webkitpy/credentials.py:
3895         * Scripts/webkitpy/credentials_unittest.py:
3896         * Scripts/webkitpy/executive.py:
3897         * Scripts/webkitpy/executive_unittest.py:
3898         * Scripts/webkitpy/mock_bugzillatool.py:
3899         * Scripts/webkitpy/multicommandtool.py:
3900         * Scripts/webkitpy/multicommandtool_unittest.py:
3901         * Scripts/webkitpy/queueengine.py:
3902         * Scripts/webkitpy/queueengine_unittest.py:
3903         * Scripts/webkitpy/scm.py:
3904         * Scripts/webkitpy/scm_unittest.py:
3905         * Scripts/webkitpy/statusbot.py:
3906         * Scripts/webkitpy/stepsequence.py:
3907         * Scripts/webkitpy/webkit_logging_unittest.py:
3908         * Scripts/webkitpy/webkitport_unittest.py:
3909
3910 2010-01-03  Chris Jerdonek  <chris.jerdonek@gmail.com>
3911
3912         Reviewed by Eric Seidel.
3913
3914         Added script to test both Perl and Python, and renamed
3915         run-webkit-unittests to test-webkit-python.
3916
3917         https://bugs.webkit.org/show_bug.cgi?id=33045
3918
3919         * Scripts/VCSUtils_unittest.pl:
3920           - Tweaked so it can be run from outside Scripts directory.
3921
3922         * Scripts/run-webkit-unittests: Removed.
3923           - Renamed to test-webkit-python.
3924
3925         * Scripts/test-webkit-perl:
3926           - Tweaked so it can be run from outside Scripts directory.
3927
3928         * Scripts/test-webkit-python: Copied from Scripts/run-webkit-unittests.
3929
3930         * Scripts/test-webkit-scripts: Added.
3931           - Runs both test-webkit-perl and test-webkit-python.
3932
3933 2010-01-03  Adam Barth  <abarth@webkit.org>
3934
3935         Reviewed by Eric Seidel.
3936
3937         commit-queue/bugzilla-tool should build both Debug and Release
3938         https://bugs.webkit.org/show_bug.cgi?id=28450
3939
3940         Add a --build-style command that lets the master process tell the child
3941         process to build both debug and release.  Eventually we want to teach
3942         the test step to understand this option too, but that's a patch for
3943         another day.
3944
3945         * Scripts/modules/buildsteps.py:
3946         * Scripts/modules/commands/queues.py:
3947         * Scripts/modules/webkitport.py:
3948         * Scripts/modules/webkitport_unittest.py:
3949
3950 2010-01-03  Jakub Wieczorek  <faw217@gmail.com>
3951
3952         Reviewed by Eric Seidel.
3953
3954         [Qt] EventSender: add support for Enter key events
3955         https://bugs.webkit.org/show_bug.cgi?id=33064
3956
3957         Unskip 5 tests that are fixed now.
3958
3959         * DumpRenderTree/qt/EventSenderQt.cpp:
3960         (EventSender::keyDown):
3961
3962 2010-01-03  Adam Barth  <abarth@webkit.org>
3963
3964         Reviewed by Eric Seidel.
3965
3966         [bzt] Add test for previous typo fix
3967         https://bugs.webkit.org/show_bug.cgi?id=33083
3968
3969         A trivial test for a trivial fix, as requested by Eric.
3970
3971         * Scripts/modules/bugzilla_unittest.py:
3972
3973 2010-01-03  Adam Barth  <abarth@webkit.org>
3974
3975         Reviewed by Eric Seidel.
3976
3977         Implement mac-ews
3978         https://bugs.webkit.org/show_bug.cgi?id=33072
3979
3980         The mac-ews is slightly different than the other early warning systems
3981         because we can't run Mac OS X inside a VM.  For that reason, we only
3982         process patches that were uploaded by committers.  This isn't as much
3983         coverage as the other EWS bots, but it's better than nothing.
3984
3985         * Scripts/modules/commands/early_warning_system.py:
3986         * Scripts/modules/commands/early_warning_system_unittest.py:
3987         * Scripts/modules/commands/queues.py:
3988         * Scripts/modules/commands/queuestest.py:
3989         * Scripts/modules/mock_bugzillatool.py:
3990
3991 2010-01-03  Chris Jerdonek  <chris.jerdonek@gmail.com>
3992
3993         Reviewed by David Kilzer.
3994
3995         Refactored svn-apply and svn-unapply to use a common "patch"
3996         command method, and added unit tests for this new method.
3997
3998         https://bugs.webkit.org/show_bug.cgi?id=33098
3999
4000         * Scripts/VCSUtils.pm:
4001           - Added generateRunPatchCommand().
4002           - Added runPatchCommand().
4003           - Added exitStatus() from webkitdirs.pm to address FIXME.
4004
4005         * Scripts/VCSUtils_unittest.pl:
4006           - Added 10 unit tests for generateRunPatchCommand().
4007           - Added 4 unit tests for runPatchCommand().
4008           - Added callSilently() method.
4009
4010         * Scripts/svn-apply:
4011           - Refactored applyPatch().
4012           - Removed $pathScriptWasRunFrom global variable.
4013           - Addressed issue where "--force" option was getting added twice.
4014
4015         * Scripts/svn-unapply:
4016           - Refactored applyPatch().
4017           - Removed $pathScriptWasRunFrom global variable.
4018           - Added support for --force option.
4019           - Enhanced to return meaningful exit status.
4020
4021         * Scripts/webkitdirs.pm:
4022           - Moved exitStatus() implementation to VCSUtils.pm.
4023
4024 2009-12-31  Adam Barth  <abarth@webkit.org>
4025
4026         Reviewed by Eric Seidel.
4027
4028         [bzt] Implement build-and-test
4029         https://bugs.webkit.org/show_bug.cgi?id=33073
4030
4031         Some of the early warning system bots want to use build-and-test so
4032         they can cover LayoutTests in addition to just compilation.
4033
4034         * Scripts/modules/commands/download.py:
4035         * Scripts/modules/commands/download_unittest.py:
4036
4037 2009-12-31  Adam Barth  <abarth@webkit.org>
4038
4039         Reviewed by Eric Seidel.
4040
4041         Show mac-ews status on QueueStatusServer
4042         https://bugs.webkit.org/show_bug.cgi?id=33076
4043
4044         Also make error status purple.
4045
4046         * QueueStatusServer/model/attachment.py:
4047         * QueueStatusServer/model/queues.py:
4048         * QueueStatusServer/templates/dashboard.html:
4049         * QueueStatusServer/templates/statusbubble.html:
4050
4051 2009-12-31  Adam Barth  <abarth@webkit.org>
4052
4053         Unreviewed.
4054
4055         [bzt] REGRESSION: Bugzila is a typo
4056         https://bugs.webkit.org/show_bug.cgi?id=33074
4057
4058         Eric should test his code before landing!  :)
4059
4060         * Scripts/modules/bugzilla.py:
4061
4062 2009-12-31  Adam Barth  <abarth@webkit.org>
4063
4064         Unreviewed.  Fix the unit tests!
4065
4066         * Scripts/run-webkit-unittests:
4067
4068 2009-12-30  Kevin Watters  <kevinwatters@gmail.com>
4069
4070         Reviewed by Kevin Ollivier.
4071
4072         [wx] Alter a couple of default settings in the test app.
4073         
4074         https://bugs.webkit.org/show_bug.cgi?id=32956
4075
4076         * wx/browser/browser.cpp:
4077         (MyApp::OnInit):
4078
4079 2009-12-30  Eric Seidel  <eric@webkit.org>
4080
4081         Reviewed by Adam Barth.
4082
4083         logging.py should be renamed to webkit_logging.py and eventually die
4084         https://bugs.webkit.org/show_bug.cgi?id=33058
4085
4086         Change all imports of "logging" to webkit_logging,
4087         except the ones which came from Google's cpp_lint.py and diff_parser.py
4088         which clearly are assuming python's logging.py.
4089
4090         * Scripts/modules/bugzilla.py:
4091         * Scripts/modules/buildbot.py:
4092         * Scripts/modules/buildsteps.py:
4093         * Scripts/modules/commands/download.py:
4094         * Scripts/modules/commands/queries.py:
4095         * Scripts/modules/commands/queues.py:
4096         * Scripts/modules/commands/upload.py:
4097         * Scripts/modules/credentials.py:
4098         * Scripts/modules/executive.py:
4099         * Scripts/modules/multicommandtool.py:
4100         * Scripts/modules/queueengine.py:
4101         * Scripts/modules/scm.py:
4102         * Scripts/modules/statusbot.py:
4103         * Scripts/modules/stepsequence.py:
4104         * Scripts/modules/webkit_logging.py: Renamed from WebKitTools/Scripts/modules/logging.py.
4105         * Scripts/modules/webkit_logging_unittest.py: Renamed from WebKitTools/Scripts/modules/logging_unittest.py.
4106
4107 2009-12-30  Jakub Wieczorek  <faw217@gmail.com>
4108
4109         Reviewed by Simon Hausmann.
4110
4111         [Qt] layoutTestController.pathToLocalResource() should return a path, not an URL
4112         https://bugs.webkit.org/show_bug.cgi?id=33051
4113
4114         Moreover, its primary function is to normalize the path in regard of platform
4115         specific directory separators. Therefore, it can simply make use of the
4116         QDir::toNativeSeparators function.
4117
4118         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4119         (LayoutTestController::pathToLocalResource):
4120
4121 2009-12-30  David D. Kilzer  <ddkilzer@webkit.org>
4122
4123         Fix executable bits for r52646
4124
4125         * Scripts/VCSUtils_unittest.pl: Added property svn:executable.
4126         * Scripts/test-webkit-perl: Ditto.
4127
4128 2009-12-29  Chris Jerdonek  <chris.jerdonek@gmail.com>
4129
4130         Reviewed by David Kilzer.
4131
4132         Fixed a bug in fixChangeLogPatch, made it work correctly in
4133         more circumstances, and added unit tests.
4134
4135         https://bugs.webkit.org/show_bug.cgi?id=32919
4136
4137         * Scripts/VCSUtils.pm:
4138           Rewrote fixChangeLogPatch.
4139           
4140         * Scripts/VCSUtils_unittest.pl: Added.
4141           Added 7 unit tests for fixChangeLogPatch.
4142
4143         * Scripts/test-webkit-perl: Added.
4144           Added test harness for unit tests of Perl code.
4145
4146 2009-12-29  Eric Seidel  <eric@webkit.org>
4147
4148         Reviewed by Adam Barth.
4149
4150         Split out BugzillaQueries class from Bugzilla
4151         https://bugs.webkit.org/show_bug.cgi?id=33042
4152
4153         * Scripts/modules/bugzilla.py:
4154          - Split out BugzillaQueries from Bugzilla.
4155          - Try to isolate self.bugzilla usage into helper functions whenever possible.
4156          - Add a bunch of FIXMEs.
4157          - Rename fetch_bug_ids_from_needs_commit_list to fetch_bug_ids_from_pending_commit_list
4158         * Scripts/modules/bugzilla_unittest.py:
4159          - Create a new BugzillaQueriesTest testcase and move logic there.
4160         * Scripts/modules/buildsteps_unittest.py:
4161          - Use Bug 75 instead of 1 since bug 1 doesn't actually exist.
4162         * Scripts/modules/commands/queries.py:
4163          - Update to use bugzilla.queries
4164         * Scripts/modules/commands/queues.py:
4165          - Ditto.
4166         * Scripts/modules/commands/upload.py:
4167          - Ditto.
4168         * Scripts/modules/mock_bugzillatool.py:
4169          - Add a MockBugzillaQueries.
4170          - Make patches and bugs global privates.
4171          - Let _id_to_object_dictionary take a variable argument list instead of an array.
4172
4173 2009-12-29  Daniel Bates  <dbates@webkit.org>
4174
4175         Reviewed by Eric Seidel.
4176
4177         https://bugs.webkit.org/show_bug.cgi?id=33041
4178
4179         Speed up the test method test_read_credentials_with_SVN by not actually
4180         creating an SVN repository to test against (by default). Instead, it is
4181         sufficient to create a temporary directory that does not contain a Git
4182         repository.
4183
4184         Also, renamed method test_read_credentials_with_SVN to
4185         test_read_credentials_without_git_repo, to better reflect what it is
4186         testing.
4187
4188         * Scripts/modules/credentials_unittest.py:
4189
4190 2009-12-29  Daniel Bates  <dbates@webkit.org>
4191
4192         Reviewed by Adam Barth.
4193
4194         https://bugs.webkit.org/show_bug.cgi?id=33039
4195
4196         [bzt] Fixes an issue where bugzilla-tool dies when the keychain lookup
4197         fails to find an entry for bugs.webkit.org.
4198         
4199         Under Mac OS X, bugzilla-tool tries to query the keychain and Security
4200         framework (via /usr/sbin/security) for an internet-password entry for
4201         bugs.webkit.org so that it can use it to login to bugs.webkit.org.
4202         However, if no such entry exists then bugzilla-tool dies with an error.
4203
4204         * Scripts/modules/credentials.py: Modified method _parse_security_tool_output to return
4205         [None, None] if /usr/sbin/security cannot find keychain entry for bugs.webkit.org.
4206         * Scripts/modules/credentials_unittest.py: Added method test_security_output_parse_entry_not_found.
4207
4208 2009-12-29  Eric Seidel  <eric@webkit.org>
4209
4210         Rubber-stamped by Adam Barth.
4211
4212         Remove unused BugzillaException.
4213
4214         * Scripts/modules/bugzilla.py:
4215
4216 2009-12-29  Eric Seidel  <eric@webkit.org>
4217
4218         Reviewed by Adam Barth.
4219
4220         Need a script to assign bugs with r+ patches to committers for landing
4221         https://bugs.webkit.org/show_bug.cgi?id=33009
4222
4223         This is just one more small tool to help in the fight against our
4224         ever-growing list of to-be-committed patches.
4225
4226         * Scripts/modules/bugzilla.py:
4227          - Rename assign_to_email to assigned_to_email (typo).
4228          - Add assigned_to_email() method on Bug.
4229          - Add reassign_bug method.
4230          - Add Bugzilla.unassigned_email, eventually should move to some webkit_config.py module.
4231         * Scripts/modules/bugzilla_unittest.py:
4232          - Update test after assigned_to_email rename.
4233         * Scripts/modules/commands/commandtest.py:
4234          - Call bind_to_tool to that self.tool works in Command testing.
4235         * Scripts/modules/commands/download.py:
4236          - Move AbstractDeclarativeCommmand multicommandtool.py, it should be part of Command.
4237         * Scripts/modules/commands/queries_unittest.py:
4238          - One of the test patches is now posted by "eric@webkit.org" which is a committer.
4239          - Eventually we'll mock out CommitterList and be able to better control what's a committer and what's not.
4240         * Scripts/modules/commands/upload.py:
4241          - Add new assign-to-committer command.
4242         * Scripts/modules/commands/upload_unittest.py:
4243          - Add basic assign-to-committer test.
4244         * Scripts/modules/committers.py:
4245          - Add bugzilla_email() accessor.
4246         * Scripts/modules/committers_unittest.py:
4247          - Test our assumption that bugzilla_email is the first email.
4248         * Scripts/modules/mock_bugzillatool.py:
4249          - Add _id_to_object_dictionary for generating bug_cache from list of bugs.
4250          - Remove unused fetch_attachments_from_bug.
4251          - Add fetch_bug support and a bug_cache.
4252         * Scripts/modules/multicommandtool.py:
4253          - Move AbstractDeclarativeCommmand here from download.py
4254
4255 2009-12-29  Adam Barth  <abarth@webkit.org>
4256
4257         Reviewed by Eric Seidel.
4258
4259         [bzt] Don't crash if user types a number during PromptForBugOrTitleStep
4260         https://bugs.webkit.org/show_bug.cgi?id=33038
4261
4262         Simple fix with test.
4263
4264         * Scripts/modules/buildsteps.py:
4265