2010-10-14 Adam Barth <abarth@webkit.org>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-10-14  Adam Barth  <abarth@webkit.org>
2
3         Reviewed by Eric Seidel.
4
5         ChromiumXVFBPort.run_webkit_tests_command has infinite recursion
6         https://bugs.webkit.org/show_bug.cgi?id=47655
7
8         * Scripts/webkitpy/common/config/ports.py:
9         * Scripts/webkitpy/common/config/ports_unittest.py:
10
11 2010-10-13  Eric Seidel  <eric@webkit.org>
12
13         Reviewed by Adam Barth.
14
15         beat diff_parser with the ugly stick
16         https://bugs.webkit.org/show_bug.cgi?id=47626
17
18         * Scripts/webkitpy/common/checkout/diff_parser.py:
19         * Scripts/webkitpy/style/patchreader.py:
20         * Scripts/webkitpy/style/patchreader_unittest.py:
21
22 2010-10-13  Eric Seidel  <eric@webkit.org>
23
24         Reviewed by Adam Barth.
25
26         Break LayoutTestResults out into its own file
27         https://bugs.webkit.org/show_bug.cgi?id=47637
28
29         * Scripts/webkitpy/common/net/buildbot.py:
30         * Scripts/webkitpy/common/net/buildbot_unittest.py:
31         * Scripts/webkitpy/common/net/layouttestresults.py: Added.
32         * Scripts/webkitpy/common/net/layouttestresults_unittest.py: Added.
33
34 2010-10-13  Adam Barth  <abarth@webkit.org>
35
36         Unreviewed.
37
38         Chromium port can't run JavaScriptCore tests
39         https://bugs.webkit.org/show_bug.cgi?id=47654
40
41         This lets webkit-patch build-and-test work on Chromium.
42
43         * Scripts/webkitpy/common/config/ports.py:
44         * Scripts/webkitpy/tool/steps/runtests.py:
45
46 2010-10-13  Adam Barth  <abarth@webkit.org>
47
48         Reviewed by Eric Seidel.
49
50         Make --port a global option and pass the port information to the commit-queue subprocess
51         https://bugs.webkit.org/show_bug.cgi?id=47650
52
53         This patch paves the way to run the commit-queue on a non-Mac port.
54
55         * Scripts/webkitpy/tool/commands/queues.py:
56         * Scripts/webkitpy/tool/commands/queues_unittest.py:
57         * Scripts/webkitpy/tool/commands/queuestest.py:
58         * Scripts/webkitpy/tool/main.py:
59         * Scripts/webkitpy/tool/steps/options.py:
60         * Scripts/webkitpy/tool/steps/preparechangelog.py:
61         * Scripts/webkitpy/tool/steps/runtests.py:
62         * Scripts/webkitpy/tool/steps/update.py:
63
64 2010-10-13  Adam Barth  <abarth@webkit.org>
65
66         Reviewed by Eric Seidel.
67
68         Introduce the ChromiumXVFBPort for running commit-queue on EC2
69         https://bugs.webkit.org/show_bug.cgi?id=47653
70
71         I'm not entirely sure this is the best way to do this, but we need to
72         run the tests under XVFB on EC2 because the EC2 instances don't have a
73         real monitor hooked up.  This patch adds a ChromiumXVFBPort that runs
74         that way.  The idea is that XVFB is like a platform for the Chromium
75         port, but we don't have a real notion of platform separate from port.
76
77         * Scripts/webkitpy/common/config/ports.py:
78
79 2010-10-13  Sergio Villar Senin  <svillar@igalia.com>
80
81         Reviewed by Martin Robinson.
82
83         [GTK] Add HTTP caching support
84         https://bugs.webkit.org/show_bug.cgi?id=44261
85
86         Add include paths for the new soup HTTP cache code.
87
88         * GNUmakefile.am: Add paths for the new soup HTTP cache code.
89
90 2010-10-13  Yi Shen  <yi.4.shen@nokia.com>
91
92         Reviewed by Antonio Gomes.
93
94         [Qt] QtTestBrowser shows two Url input fields
95         https://bugs.webkit.org/show_bug.cgi?id=47613
96
97         * QtTestBrowser/mainwindow.cpp:
98         (MainWindow::MainWindow):
99         (MainWindow::buildUI):
100
101 2010-10-13  Yi Shen  <yi.4.shen@nokia.com>
102
103         Reviewed by Tony Chang.
104
105         [gdb] Add pretty-print supports for UString, Identifier and JSString
106         https://bugs.webkit.org/show_bug.cgi?id=47601
107
108         * gdb/webkit.py:
109
110 2010-10-13  Adam Barth  <abarth@webkit.org>
111
112         Reviewed by Eric Seidel.
113
114         Add list of Ubuntu packages needed by the EWS bots
115         https://bugs.webkit.org/show_bug.cgi?id=47628
116
117         I've been copy/pasting this list between bots, but it's better to have
118         this checked in.
119
120         * EWSTools/ubuntu-ews-packages: Added.
121
122 2010-10-13  Leandro Pereira  <leandro@profusion.mobi>
123
124         Reviewed by Csaba Osztrogonác.
125
126         [EFL] Adds a build slave.
127         https://bugs.webkit.org/show_bug.cgi?id=47290
128
129         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
130         entry for a release build of the EFL port.
131         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
132         flag to build the EFL port.
133
134 2010-10-13  Adam Barth  <abarth@webkit.org>
135
136         Reviewed by Csaba Osztrogonác.
137
138         webkit-patch build shouldn't need --build to actually build!
139         https://bugs.webkit.org/show_bug.cgi?id=47438
140
141         Yeah, requiring --build for the build command is really dumb.  We did
142         this originally because the build step is usually optional in other
143         commands.  We don't have a good way of reversing the default for an
144         option in one command.  This approach is slightly hacky since --build
145         still shows up as an option on the help page, but at least it makes
146         progress.  Passing --build is harmless, so the EWS bots shouldn't
147         explode because of this change.
148
149         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
150         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
151         * Scripts/webkitpy/tool/commands/download.py:
152         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
153         * Scripts/webkitpy/tool/commands/queues_unittest.py:
154
155 2010-10-13  Sheriff Bot  <webkit.review.bot@gmail.com>
156
157         Unreviewed, rolling out r69638.
158         http://trac.webkit.org/changeset/69638
159         https://bugs.webkit.org/show_bug.cgi?id=47595
160
161         "Broke win and chromium-win bots" (Requested by dglazkov on
162         #webkit).
163
164         * Scripts/webkitpy/common/system/path.py:
165         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
166         * Scripts/webkitpy/layout_tests/port/base.py:
167         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
168         * Scripts/webkitpy/layout_tests/port/chromium.py:
169         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
170
171 2010-10-13  John Knottenbelt  <jknotten@chromium.org>
172
173         Reviewed by Steve Block.
174
175         First step towards client-based Geolocation in Chromium. Build
176         fixes for CLIENT_BASED_GEOLOCATION preprocessor feature define.
177         https://bugs.webkit.org/show_bug.cgi?id=47586
178
179         * DumpRenderTree/chromium/WebViewHost.cpp:
180         * DumpRenderTree/chromium/WebViewHost.h:
181
182 2010-10-13  Adam Roben  <aroben@apple.com>
183
184         Test that pressing the spacebar in a text field does not scroll the
185         document
186
187         Test for <http://webkit.org/b/47544> <rdar://problem/8540645>
188         REGRESSION: Pressing spacebar in a text field in WebKit2 does not
189         insert a space, scrolls the page instead
190
191         Reviewed by Sam Weinig.
192
193         * TestWebKitAPI/PlatformUtilities.h: Added isKeyDown.
194
195         * TestWebKitAPI/PlatformWebView.h: Added simulateSpacebarKeyPress.
196
197         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
198         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
199         * TestWebKitAPI/win/copy-resources.cmd:
200         Added new files.
201
202         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: Added.
203         (TestWebKitAPI::JavaScriptCallbackContext::JavaScriptCallbackContext):
204         We use this to track what the result of calling into JavaScript was.
205         (TestWebKitAPI::didFinishLoadForFrame): Records when the page
206         finishes loading.
207         (TestWebKitAPI::didNotHandleKeyEventCallback): Records when a key down
208         event is not handled.
209         (TestWebKitAPI::javaScriptCallback): Records that JavaScript finished
210         executing and whether the result matched our expectation.
211         (TestWebKitAPI::wk): Turns a UTF-8 C string into a WKStringRef.
212         (TestWebKitAPI::runJSTest): Calls into JS, waits for the call to
213         complete, and returns whether we got back the expected result.
214         (TestWebKitAPI::WebKit2_SpacebarScrolling): Tests that pressing
215         spacebar inside a text field does not scroll the document and that
216         pressing it outside the text field does scroll the document.
217
218         * TestWebKitAPI/Tests/WebKit2/spacebar-scrolling.html: Added.
219
220         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
221         (TestWebKitAPI::Util::isKeyDown): Checks the event's type.
222
223         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
224         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Copied
225         code from DRT's EventSendingController.
226
227         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
228         (TestWebKitAPI::Util::isKeyDown): Checks the message's type.
229
230         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
231         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Send the
232         same messages that get sent when you press spacebar in Notepad.
233
234 2010-10-13  Adam Roben  <aroben@apple.com>
235
236         Fix a couple of issues with the TestWebKitAPI build
237
238         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops:
239         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops:
240         Fixed a typo.
241
242         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Use common.vsprops
243         to set our output and intermediate directories so that we don't spew
244         files into the source tree.
245
246 2010-10-13  Balazs Kelemen  <kbalazs@webkit.org>
247
248         Reviewed by Csaba Osztrogonác.
249
250         WTR should accept relative paths
251         https://bugs.webkit.org/show_bug.cgi?id=47486
252
253         * WebKitTestRunner/StringFunctions.h:
254         * WebKitTestRunner/TestInvocation.cpp:
255         (WTR::createWKURL): Moved from StringFunctions.h since it is
256         used only here. Extend relative paths to absolute.
257
258 2010-10-12  Adam Roben  <aroben@apple.com>
259
260         Make TestWebKitAPI work on Windows
261
262         Fixes <http://webkit.org/b/47552> <rdar://problem/8541708>.
263
264         Reviewed by Sam Weinig.
265
266         * Scripts/build-api-tests: Build TestWebKitAPI.sln on Windows.
267
268         * Scripts/run-api-tests: Fix the PATH so that TestWebKitAPI can be
269         run on Windows.
270         (runTest): Added code to run TestWebKitAPI.exe on Windows and to die
271         on unsupported platforms.
272         (populateTests): Added code to run TestWebKitAPI.exe on Windows and to
273         die on other platforms. Extracted some formerly-Mac-specific code to
274         be cross-platform and made it handle any style of line-endings.
275
276         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added.
277         Links against CFLite.
278
279         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added.
280         Contains most properties for the project.
281
282         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops:
283         Added. Links against CoreFoundation.
284
285         * TestWebKitAPI/TestWebKitAPIPrefix.h: Added a Windows-specific
286         section and moved the cross-platform section after the
287         platform-specific parts.
288
289         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Added.
290         (TestWebKitAPI::Util::run): Runs a normal message pump until we're
291         done.
292         (TestWebKitAPI::Util::cf): Turns a UTF-8 C string into a CFString.
293         (TestWebKitAPI::Util::createURLForResource): Uses CFBundle to get the
294         resource path.
295         (TestWebKitAPI::Util::URLForNonExistentResource): Creates a bogus
296         WKURL.
297
298         * TestWebKitAPI/win/PlatformWebViewWin.cpp: Added.
299         (TestWebKitAPI::registerWindowClass):
300         (TestWebKitAPI::PlatformWebView::PlatformWebView):
301         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
302         (TestWebKitAPI::PlatformWebView::page):
303         This was mostly copied from WebKitTestRunner's PlatformWebView.
304
305         * TestWebKitAPI/win/TestWebKitAPI.sln: Added. Builds both
306         TestWebKitAPI and TestWebKitAPIGeneratd. This is used by the
307         build-api-tests script.
308
309         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added. Builds
310         TestWebKitAPI.exe.
311
312         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added. Just calls
313         through to copy-resources.cmd.
314
315         * TestWebKitAPI/win/copy-resources.cmd: Added. Copies resources into
316         or deletes resources from TestWebKitAPI.resources.
317
318         * TestWebKitAPI/win/main.cpp: Added.
319         (main): Calls through to TestsController.
320
321 2010-10-13  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
322
323         Reviewed by Kenneth Rohde Christiansen.
324
325         [EFL] Support viewport configuration and add new arguments for WebKit EFL
326         https://bugs.webkit.org/show_bug.cgi?id=47084
327
328         Opera spec regarding to viewport meta tag was adjusted to WebCore. So, EFL port
329         needs to be modified according to the changes.
330
331         * EWebLauncher/main.c:
332         (on_viewport_changed):
333
334 2010-10-12  Dirk Pranke  <dpranke@chromium.org>
335
336         Reviewed by Eric Seidel.
337
338         This patch enables new-run-webkit-tests (in particular the
339         chromium-win port) to run under Cygwin as well as Win32. Mostly
340         this just required some conversions from cygwin paths to Win32
341         paths when we spawn off Win32 binaries like test_shell.
342
343         https://bugs.webkit.org/show_bug.cgi?id=47220
344
345         * Scripts/webkitpy/common/system/path.py:
346         - Expose the cygpath() function for path conversion
347
348         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
349         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
350         - shift filename->uri conversion in the TestInfo objects to the
351           dump_render_tree thread
352
353         * Scripts/webkitpy/layout_tests/port/base.py:
354         * Scripts/webkitpy/layout_tests/port/chromium.py:
355         - use cygpath()
356
357 2010-10-12  Yuta Kitamura  <yutak@chromium.org>
358
359         Unreviewed. Add Yuta Kitamura (yutak) to the committers list.
360
361         * Scripts/webkitpy/common/config/committers.py:
362
363 2010-10-12  Sam Weinig  <sam@webkit.org>
364
365         Reviewed by Dan Bernstein.
366
367         When a provisional load fails, the provisional URL returned
368         from WKFrameCopyProvisionalURL should be empty
369         <rdar://problem/8540878>
370         https://bugs.webkit.org/show_bug.cgi?id=47546
371
372         Add test.
373
374         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
375         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
376
377 2010-10-12  Anders Carlsson  <andersca@apple.com>
378
379         Reviewed by Sam Weinig.
380
381         Start fleshing out find page overlays
382         https://bugs.webkit.org/show_bug.cgi?id=47559
383
384         * MiniBrowser/mac/BrowserWindowController.m:
385         (-[BrowserWindowController find:]):
386         Pass kWKFindOptionsShowOverlay to WKPageFindString.
387
388 2010-10-12  Robert Hogan  <robert@webkit.org>
389
390         Reviewed by Antonio Gomes.
391
392         [Qt] editing/input/emacs-ctrl-o.html
393
394         ctrl-o is bound to a sequence of commands on Mac, namely:
395         insertParagraphSeparator then moveLeft. In the DRT, we just interpret
396         ctrl-o in EventSenderQt as '\n', i.e. insertParagraphSeparator. As a
397         result we only issue one command, so don't generate the change in caret
398         position that results in the extra editing delegate messages.
399
400         So for the sake of not managing suspicious-looking differences, just
401         make DRT issue the appropriate edit commands to pass the test.
402
403         https://bugs.webkit.org/show_bug.cgi?id=47548
404
405         * DumpRenderTree/qt/EventSenderQt.cpp:
406         (EventSender::keyDown):
407
408 2010-10-12  Anders Carlsson  <andersca@apple.com>
409
410         Reviewed by Sam Weinig.
411
412         Add a simple Find UI to MiniBrowser
413         https://bugs.webkit.org/show_bug.cgi?id=47553
414
415         * MiniBrowser/mac/BrowserWindow.xib:
416         Add Find panel.
417
418         * MiniBrowser/mac/BrowserWindowController.h:
419         * MiniBrowser/mac/BrowserWindowController.m:
420         (-[BrowserWindowController performFindPanelAction:]):
421         Show the find panel.
422
423         (-[BrowserWindowController find:]):
424         Tell the WKPageRef to find the given string.
425
426 2010-10-12  Tony Chang  <tony@chromium.org>
427
428         Unreviewed, fixing DRT compile on Windows after r69586.
429
430         * DumpRenderTree/chromium/WebThemeEngineDRT.h:
431
432 2010-10-12  Tony Chang  <tony@chromium.org>
433
434         Unreviewed, trying to fix NRWT on Windows.
435
436         * Scripts/webkitpy/layout_tests/port/http_lock.py:
437
438 2010-10-12  Balazs Kelemen  <kbalazs@webkit.org>
439
440         Reviewed by Kenneth Rohde Christiansen.
441
442         [Qt][WTR] Checking the path of the injected bundle is bogus
443         https://bugs.webkit.org/show_bug.cgi?id=47541
444
445         * WebKitTestRunner/qt/TestControllerQt.cpp:
446         (WTR::isExistingLibrary): Added (static helper).
447         Extend the path with the appropriate suffix(es) on the
448         platform and check that the file exists.
449         (WTR::TestController::initializeInjectedBundlePath):
450         There were two bugs with the path checking:
451             - the condition should have been inverted
452             - QLibrary::fileName does not give back the filename
453               with the library suffix so we cannot check
454               that existance of the file this way.
455
456 2010-10-12  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
457
458         Reviewed by Tony Chang.
459
460         Implement http locking in NRWT.
461         https://bugs.webkit.org/show_bug.cgi?id=47072
462
463         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
464         * Scripts/webkitpy/layout_tests/port/base.py:
465         * Scripts/webkitpy/layout_tests/port/http_lock.py: Added.
466         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py: Added.
467         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
468
469 2010-10-12  Mark Rowe  <mrowe@apple.com>
470
471         Fix the 32-bit WebKit2 build.
472
473         * MiniBrowser/mac/BrowserWindowController.m:
474         (getWindowFrame): Use NSRect rather than CGRect since that's what -frame returns.
475         (setWindowFrame): Use NSMakeRect rather than CGRectMake since that's what -setFrame:display: expects.
476
477 2010-10-11  Tony Chang  <tony@chromium.org>
478
479         Reviewed by Adam Barth.
480
481         change the order of mrobinson's email addresses so bugs.webkit.org suggests the right one
482         https://bugs.webkit.org/show_bug.cgi?id=47513
483
484         bugs.webkit.org suggests mrobinson@igalia.com as an autocomplete,
485         which doesn't actually work.
486
487         * Scripts/webkitpy/common/config/committers.py:
488
489 2010-10-11  Prasad Tammana  <prasadt@chromium.org>
490
491         Reviewed by Dmitry Titov.
492
493         Added support for showModalDialog on chromium port.
494
495         Implement showModalDialog for Layout tests for chromium port
496         https://bugs.webkit.org/show_bug.cgi?id=46759
497
498         * DumpRenderTree/chromium/WebViewHost.cpp:
499         (WebViewHost::closeWidgetSoon): Quit current message loop if in a modal loop.
500         (WebViewHost::runModal):  Start a nested message loop and remember that.
501         (WebViewHost::WebViewHost):  Initialize m_inModalLoop.
502         * DumpRenderTree/chromium/WebViewHost.h:  Add m_inModalLoop.
503
504 2010-10-11  Martin Robinson  <mrobinson@igalia.com>
505
506         Reviewed by Gustavo Noronha Silva.
507
508         [GTK] Cleanup font selection code for the Freetype backend
509         https://bugs.webkit.org/show_bug.cgi?id=47503
510
511         Update DRT to set values for the cursive and fantasy font families, so
512         that we can generate consistent results for tests that use these families.
513         Add some missing information to fonts.conf.
514
515         * DumpRenderTree/gtk/DumpRenderTree.cpp:
516         (resetDefaultsToConsistentValues): Always set the fantasy and cursive font
517         family names.
518         * DumpRenderTree/gtk/fonts/fonts.conf: Add aliases for cursive and fantasy fonts
519         to our default serif font. Eventually we may want to import or require some "real"
520         fonts, but this should at least ensure consistent rendering during test runs. Also
521         add aliases for some other commonly used fonts in tests (Arial and Lucida Grande).
522         Finally, add a missing oblique specification for DejaVu Serif, which was resulting
523         in some incorrect baselines for the synthetic oblique test.
524
525 2010-10-11  Adam Barth  <abarth@webkit.org>
526
527         Unreviewed.
528
529         Fix sheriffbot not to crash when there are failing tests.  It turns out
530         Python sets don't support the + operator.  We need to use union
531         instead.  There's a more elegant way to do this in Python 2.6, but we
532         need this code to work in 2.5.
533
534         * Scripts/webkitpy/common/net/failuremap.py:
535         * Scripts/webkitpy/common/net/failuremap_unittest.py:
536
537 2010-10-10  Robert Hogan  <robert@webkit.org>
538
539         Unreviewed, fix failing test from r69468.
540
541         [Qt] Put all DRT-created pages in a page group
542
543         Fix on r69468.
544
545         Because we don't delete closed pages immediately in DRT we need
546         to remove them from the page group explicitly instead.
547
548         Fixes failure of fast/events/popup-blocked-from-fake-user-gesture.html
549
550         https://bugs.webkit.org/show_bug.cgi?id=47469
551
552         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
553         (WebCore::DumpRenderTree::windowCloseRequested):
554
555 2010-10-10  Leandro Pereira  <leandro@profusion.mobi>
556
557         Reviewed by Adam Barth.
558
559         commit-queue: Add EFL-EWS status bubble to Bugzilla, now that the
560         EFL-EWS bot is up and running.
561         https://bugs.webkit.org/show_bug.cgi?id=47277
562
563         * QueueStatusServer/handlers/statusbubble.py:
564
565 2010-10-10  Robert Hogan  <robert@webkit.org>
566
567         Reviewed by Antonio Gomes.
568
569         [Qt] Put all DRT-created pages in a page group
570
571         https://bugs.webkit.org/show_bug.cgi?id=47469
572
573         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
574         (WebCore::DumpRenderTree::DumpRenderTree):
575         (WebCore::DumpRenderTree::createWindow):
576
577 2010-10-09  Sam Weinig  <sam@webkit.org>
578
579         Reviewed by Dan Bernstein.
580
581         WKFrameGetFrameLoadState() returns kWKFrameLoadStateCommitted after the load has been stopped
582         <rdar://problem/8173667>
583         https://bugs.webkit.org/show_bug.cgi?id=47461
584
585         * TestWebKitAPI/PlatformUtilities.h:
586         * TestWebKitAPI/Test.h:
587         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
588         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp: Added.
589         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
590         (TestWebKitAPI::TEST):
591         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
592         (TestWebKitAPI::Util::URLForNonExistentResource):
593         Adds a test for the frame load state after a failed provisional load. I wanted to test
594         the frame load state after a committed load failed, but I don't believe that is possible
595         to do without hooking up the http server to serve a long loading page.
596
597 2010-10-09  Sam Weinig  <sam@webkit.org>
598
599         Reviewed by Dan Bernstein.
600
601         Add WebKit2 version of runBeforeUnloadConfirmPanelWithMessage
602         <rdar://problem/8447690>
603         https://bugs.webkit.org/show_bug.cgi?id=47459
604
605         * MiniBrowser/mac/BrowserWindowController.m:
606         (runBeforeUnloadConfirmPanel):
607         (-[BrowserWindowController awakeFromNib]):
608         * WebKitTestRunner/TestController.cpp:
609         (WTR::createOtherPage):
610         (WTR::TestController::initialize):
611
612 2010-10-09  Sam Weinig  <sam@webkit.org>
613
614         Reviewed by Dan Bernstein.
615
616         Need implementation of ChromeClient windowRect related functions.
617         <rdar://problem/8469476>
618         https://bugs.webkit.org/show_bug.cgi?id=47386
619
620         * MiniBrowser/mac/BrowserWindowController.m:
621         (getWindowFrame):
622         (setWindowFrame):
623         (-[BrowserWindowController awakeFromNib]):
624         * WebKitTestRunner/PlatformWebView.h:
625         * WebKitTestRunner/TestController.cpp:
626         (WTR::TestController::initialize):
627         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
628         (WTR::PlatformWebView::windowFrame):
629         (WTR::PlatformWebView::setWindowFrame):
630         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
631         (WTR::PlatformWebView::windowFrame):
632         (WTR::PlatformWebView::setWindowFrame):
633         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
634         (WTR::PlatformWebView::windowFrame):
635         (WTR::PlatformWebView::setWindowFrame):
636
637 2010-10-08  Adam Barth  <abarth@webkit.org>
638
639         Unreviewed (Eric is on vacation in this change is trivial).
640
641         Add a "clean" command to webkit-patch to clean the working directory
642         https://bugs.webkit.org/show_bug.cgi?id=47436
643
644         This command is useful when using SVN because "svn revert" leaves
645         unversioned files behind.
646
647         * Scripts/webkitpy/tool/commands/download.py:
648
649 2010-10-08  Andras Becsi  <abecsi@webkit.org>
650
651         Unreviewed build fix.
652
653         [Qt] Add missing limits.h include since the Qt version currently
654         ran on the bot does need that.
655
656         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
657
658 2010-10-08  Balazs Kelemen  <kbalazs@webkit.org>
659
660         Reviewed by Csaba Osztrogonác.
661
662         [Qt] Turn on building WTR
663         https://bugs.webkit.org/show_bug.cgi?id=47349
664
665         * Scripts/webkitdirs.pm:
666
667 2010-10-08  Balazs Kelemen  <kbalazs@webkit.org>
668
669         Reviewed by Andreas Kling.
670
671         [Qt] TestController needs its platform dependent methods
672         https://bugs.webkit.org/show_bug.cgi?id=47413
673
674         * WebKitTestRunner/qt/TestControllerQt.cpp:
675         (WTR::TestController::initializeInjectedBundlePath):
676         If the WTR_INJECTEDBUNDLE_PATH environmental variable is
677         set then use that otherwise use the path where the bundle
678         lives in a normal trunk build.
679         (WTR::TestController::initializeTestPluginDirectory):
680         Set the bundle's value. It is not used currently.
681         (WTR::TestController::platformInitializeContext):
682         * WebKitTestRunner/qt/WebKitTestRunner.pro:
683
684 2010-10-08  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
685
686         Reviewed by Kenneth Rohde Christiansen.
687
688         WTR: Prevent sending the Done message twice on test timeout.
689         https://bugs.webkit.org/show_bug.cgi?id=47410
690
691         When InjectedBundle::done() calls stopLoading, this may trigger
692         InjectedBundlePage::didFailLoadWithErrorForFrame which calls
693         InjectedBundle::done() itself later in the stack.
694         This would output the timeout failure message twice and confuse
695         the run-webkit-tests script.
696
697         This patch adds a third state, Stopping, which prevents WebCore
698         errors to trigger done() when testing is over.
699
700         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
701         (WTR::InjectedBundle::done):
702         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
703
704 2010-10-08  Andras Becsi  <abecsi@webkit.org>
705
706         Reviewed by Kenneth Rohde Christiansen.
707
708         [Qt] Add an activateFonts() implementation similar to DRT's initializeFonts().
709         Original code by Simon Hausmann.
710         https://bugs.webkit.org/show_bug.cgi?id=47402
711
712         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: Added.
713         (WTR::activateFonts):
714
715 2010-10-08  Andras Becsi  <abecsi@webkit.org>
716
717         Reviewed by Csaba Osztrogonác.
718
719         [Qt] Add support for Qt's WebKitTestRunner to old-run-webkit-tests.
720         https://bugs.webkit.org/show_bug.cgi?id=47401
721
722         * Scripts/build-webkittestrunner:
723         * Scripts/old-run-webkit-tests:
724
725 2010-10-07  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
726
727         Reviewed by Kenneth Rohde Christiansen.
728
729         [Qt] WTR first compile: fix compile issues.
730         https://bugs.webkit.org/show_bug.cgi?id=47343
731
732         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
733         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
734         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
735         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
736         * WebKitTestRunner/TestController.cpp:
737         * WebKitTestRunner/TestInvocation.cpp:
738
739 2010-10-07  Antonio Gomes  <agomes@rim.com>
740
741         Reviewed by Simon Fraser.
742
743         [Mac] [DRT] implement setSpatialNavigationEnabled
744         https://bugs.webkit.org/show_bug.cgi?id=47291
745
746         Implemented LayoutTestController::setSpatialNavigationEnabled for Mac's DRT
747         so it can track regression on the existing implementation and future improvements
748         we are making.
749
750         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
751         (LayoutTestController::setSpatialNavigationEnabled):
752
753 2010-10-07  Dirk Pranke  <dpranke@chromium.org>
754
755         Reviewed by Adam Barth.
756
757         rebaseline-chromium-webkit-tests relied on the filename_to_uri()
758         hook in the Port infrastructure to generate URIs for the files
759         in its summary HTML report; however, that method is supposed to only
760         be used for test files (and should really be renamed), so this would
761         crash.
762
763         This change adds a new "path" module to the system package with a
764         routine called abspath_to_uri() that handles converting paths to
765         file: URIs independently of anything in the layout_tests package,
766         and changes the code to use this. At some point in the near future
767         the layout_tests/port/* code should use this as well.
768
769         This change also deletes a bunch of unused code and fixes some
770         comments in rebaseline_chromium_webkit_tests.py.
771
772         https://bugs.webkit.org/show_bug.cgi?id=47319
773
774         * Scripts/webkitpy/common/system/path.py: Added.
775         * Scripts/webkitpy/common/system/path_unittest.py: Added.
776         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
777         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
778
779 2010-10-07  Martin Robinson  <mrobinson@igalia.com>
780
781         Reviewed by Gustavo Noronha Silva.
782
783         [GTK] The FreeType backend does not respect the FC_EMBOLDEN property
784         https://bugs.webkit.org/show_bug.cgi?id=46216
785
786         Fix my latest commit, as it contained some bad changes from a merge gone wrong.
787
788         * DumpRenderTree/gtk/DumpRenderTree.cpp:
789         (initializeFonts): Also initialize the DevaVu Sans font.
790
791 2010-10-07  Daniel Cheng  <dcheng@chromium.org>
792
793         Reviewed by Tony Chang.
794
795         [chromium] Minor naming cleanup in WebDragData, part 2
796         https://bugs.webkit.org/show_bug.cgi?id=47227
797
798         Update DRT to use the renamed methods.
799
800         * DumpRenderTree/chromium/EventSender.cpp:
801         (EventSender::beginDragWithFiles):
802         * DumpRenderTree/chromium/WebViewHost.cpp:
803         (addDRTFakeFileToDataObject):
804
805 2010-10-07  Anders Carlsson  <andersca@apple.com>
806
807         Reviewed by Sam Weinig.
808
809         Add a WKPageFindClient, hook up WKPageCountStringMatches
810         https://bugs.webkit.org/show_bug.cgi?id=47373
811
812         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
813         Remove hard coded paths.
814
815         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
816         (TestWebKitAPI::TEST):
817         Fix expected result.
818
819         * TestWebKitAPI/Tests/WebKit2/Find.cpp: Added.
820         (TestWebKitAPI::didFinishLoadForFrame):
821         (TestWebKitAPI::didCountStringMatches):
822         (TestWebKitAPI::TEST):
823         * TestWebKitAPI/Tests/WebKit2/find.html: Added.
824         Add test for WKPageCountStringMatches.
825
826 2010-09-21  Martin Robinson  <mrobinson@igalia.com>
827
828         Reviewed by Chris Fleizach.
829
830         [GTK] The FreeType backend does not respect the FC_EMBOLDEN property
831         https://bugs.webkit.org/show_bug.cgi?id=46216
832
833         * DumpRenderTree/gtk/fonts/fonts.conf: Add a setting which enables FC_EMBOLDEN
834         for DejaVu Serif when there is no bold version available. This is necessary to
835         properly test the property in layout tests.
836
837 2010-10-07  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>, Andras Becsi  <abecsi@webkit.org>, Balazs Kelemen  <kbalazs@webkit.org>
838
839         Reviewed by Kenneth Rohde Christiansen.
840
841         [Qt] Add WTR's InjectedBundle build files.
842         https://bugs.webkit.org/show_bug.cgi?id=47333
843
844         * Scripts/webkitdirs.pm:
845         * WebKitTestRunner/DerivedSources.pro: Added.
846         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Added.
847         * WebKitTestRunner/WebKitTestRunner.pro: Added.
848         * WebKitTestRunner/qt/DerivedSources.pro: Removed.
849         Content merged in ../DerivedSources.pro
850
851 2010-10-07  Sheriff Bot  <webkit.review.bot@gmail.com>
852
853         Unreviewed, rolling out r69315.
854         http://trac.webkit.org/changeset/69315
855         https://bugs.webkit.org/show_bug.cgi?id=47363
856
857         Forgot to add the new files (Requested by kbalazs on #webkit).
858
859         * Scripts/webkitdirs.pm:
860         * WebKitTestRunner/qt/DerivedSources.pro: Added.
861
862 2010-10-07  Sam Weinig  <sam@webkit.org>
863
864         Reviewed by Anders Carlsson.
865
866         Change API tester to ask the executable for the list of all
867         tests instead of relying on the directory structure.
868         https://bugs.webkit.org/show_bug.cgi?id=47359
869
870         * Scripts/run-test-webkit-api: Added.
871         * Scripts/webkitdirs.pm:
872         Add additional script to just launch the api tester with the correct settings.
873
874         * Scripts/run-api-tests:
875         Change to use the new --dump-tests options to build the list of tests and change
876         output to reflect a (suite, testcase) tuple for each test. Also adds some color.
877
878         * TestWebKitAPI/Test.h:
879         (TestWebKitAPI::Test::Register::Register):
880         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
881         (TestWebKitAPI::TEST):
882         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
883         (TestWebKitAPI::TEST):
884         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
885         (TestWebKitAPI::TEST):
886         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
887         (TestWebKitAPI::TEST):
888         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
889         (TestWebKitAPI::TEST):
890         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
891         (TestWebKitAPI::TEST):
892         Give each test a suite name in addition to the test name.
893
894         * TestWebKitAPI/TestsController.cpp:
895         (TestWebKitAPI::TestsController::dumpTestNames):
896         (TestWebKitAPI::TestsController::runTestNamed):
897         * TestWebKitAPI/TestsController.h:
898         * TestWebKitAPI/mac/main.mm:
899         (main):
900         Add option to print all registered tests.
901
902 2010-10-07  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>, Andras Becsi  <abecsi@webkit.org>, Balazs Kelemen  <kbalazs@webkit.org>
903
904         Reviewed by Kenneth Rohde Christiansen.
905
906         [Qt] Add WTR's InjectedBundle build files.
907         https://bugs.webkit.org/show_bug.cgi?id=47333
908
909         * Scripts/webkitdirs.pm:
910         * WebKitTestRunner/DerivedSources.pro: Added.
911         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Added.
912         * WebKitTestRunner/WebKitTestRunner.pro: Added.
913         * WebKitTestRunner/qt/DerivedSources.pro: Removed.
914         Content merged in ../DerivedSources.pro
915
916 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
917
918         Unreviewed. Do a renaming that was recommended by the reviewer
919         (Kenneth) but I forgot to do before landing (http://trac.webkit.org/changeset/69253)
920
921         * WebKitTestRunner/qt/TestControllerQt.cpp:
922         (WTR::RunUntilConditionLoop::start):
923         (WTR::RunUntilConditionLoop::RunUntilConditionLoop):
924         (WTR::TestController::runUntil):
925
926 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
927
928         Reviewed by Kenneth Rohde Christiansen.
929
930         [Qt] Watchdog timer implementation for WTR
931         https://bugs.webkit.org/show_bug.cgi?id=47337
932
933         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Factor out
934         the definition of the timer type to a typedef.
935         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp: Added.
936         Timer implementation with QTimer and a helper QObject class.
937         (WTR::WatchdogTimerHelper::instance):
938         (WTR::WatchdogTimerHelper::timerFired):
939         (WTR::WatchdogTimerHelper::WatchdogTimerHelper):
940         (WTR::LayoutTestController::platformInitialize):
941         (WTR::LayoutTestController::invalidateWaitToDumpWatchdogTimer):
942         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
943
944 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
945
946         Unreviewed buildfix for 69297 again
947
948         * WebKitTestRunner/TestController.cpp:
949         (WTR::blankURL):
950
951 2010-10-07  Balazs Kelemen  <Balazs Kelemen>
952
953         Unreviewed trivial build fix for r69297
954
955         * WebKitTestRunner/TestController.cpp:
956         (WTR::blankURL):
957
958 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
959
960         Reviewed by Kenneth Rohde Christiansen.
961
962         WebKitTestRunner should be portable
963         https://bugs.webkit.org/show_bug.cgi?id=45393
964
965         Use only the WebKit API for working with urls.
966         * WebKitTestRunner/StringFunctions.h:
967         (WTR::createWKURL):
968         * WebKitTestRunner/TestController.cpp:
969         (WTR::blankURL):
970         (WTR::TestController::resetStateToConsistentValues):
971         (WTR::TestController::didFinishLoadForFrame):
972
973 2010-10-07  Carlos Garcia Campos  <cgarcia@igalia.com>
974
975         Reviewed by Xan Lopez.
976
977         [GTK] Use gtk_widget_draw() instead of gtk_widget_get_snapshot() in PixelDumpSupportGtk when building with gtk3
978         https://bugs.webkit.org/show_bug.cgi?id=47332
979
980         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
981         (createBitmapContextFromWebView):
982
983 2010-10-06  Chris Guillory  <chris.guillory@google.com>
984
985         Reviewed by Chris Fleizach.
986
987         Remove unused accessibility functions from webkit.
988         https://bugs.webkit.org/attachment.cgi?bugid=46707
989
990         * DumpRenderTree/chromium/WebViewHost.cpp:
991         (WebViewHost::postAccessibilityNotification):
992         * DumpRenderTree/chromium/WebViewHost.h:
993
994 2010-10-06  Lucas Forschler  <lforschler@apple.com>
995
996         Reviewed by Adam Roben.
997
998         Fix the sunspider-compare-results to actually use the passed in value for $root.
999
1000         * Scripts/sunspider-compare-results:
1001
1002 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
1003
1004         Reviewed by Kenneth Rohde Christiansen.
1005
1006         [Qt] Runloop implementation for WTR
1007         https://bugs.webkit.org/show_bug.cgi?id=47280
1008
1009         * WebKitTestRunner/qt/TestControllerQt.cpp:
1010         Implemented TestController::runUntil by a timerEvent
1011         and a QEventLoop. We step into the event loop from runUntil.
1012         While we are waiting in the loop a timerEvent is periodically
1013         checking the value of the condition. Once the condition has
1014         becoming true the timerEvent wakes us up.
1015         (WTR::RunUntilLoop::start):
1016         (WTR::RunUntilLoop::RunUntilLoop):
1017         (WTR::RunUntilLoop::run):
1018         (WTR::RunUntilLoop::timerEvent):
1019         (WTR::TestController::platformInitialize):
1020         (WTR::TestController::runUntil):
1021         * WebKitTestRunner/qt/main.cpp:
1022         Start the main event loop first and creating the TestController later.
1023         (Launcher::Launcher):
1024         (Launcher::~Launcher):
1025         (Launcher::launch): Creating the TestController.
1026         (main): Setting up a timer for calling Launcher::launch from
1027         the main event loop.
1028
1029 2010-10-06  Dirk Pranke  <dpranke@chromium.org>
1030
1031         Reviewed by Kenneth Russell.
1032
1033         new-run-webkit-tests: fix typo in chromium-gpu that was trying to
1034         enable 'accelerated-composting' instead of 'accelerated-compositing'.
1035
1036         https://bugs.webkit.org/show_bug.cgi?id=47312
1037
1038         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1039         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1040
1041 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
1042
1043         Reviewed by Kenneth Rohde Christiansen.
1044
1045         [Qt] PlatformWebView implementation for WebKitTestRunner
1046         https://bugs.webkit.org/show_bug.cgi?id=47276
1047
1048         The implementation follows the way how
1049         we use the API in MiniBrowser.
1050         * WebKitTestRunner/PlatformWebView.h:
1051         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1052         (WTR::WebView::wkView):
1053         (WTR::WebView::~WebView):
1054         (WTR::WebView::WebView):
1055         (WTR::PlatformWebView::PlatformWebView):
1056         (WTR::PlatformWebView::~PlatformWebView):
1057         (WTR::PlatformWebView::resizeTo):
1058         (WTR::PlatformWebView::page):
1059         (WTR::PlatformWebView::focus):
1060         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1061
1062 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
1063
1064         Reviewed by Kenneth Rohde Christiansen.
1065
1066         [Qt] Add WebKitTestRunner's build files
1067         https://bugs.webkit.org/show_bug.cgi?id=44155
1068
1069         Parts was taken by Zoltan Horvath's patch.
1070
1071         * Scripts/generate-forwarding-headers.pl: Moved from WebKit2.
1072         * Scripts/webkitdirs.pm: Make the generated files needed by WTR.
1073         * WebKitTestRunner/PlatformWebView.h: Addeed typedefs for
1074         PlatformWKView and PlatformWindow (void* for now).
1075         Buildfix the case when __APPLE__ is not defined.
1076         * WebKitTestRunner/qt/DerivedSources.pro: Added.
1077         * WebKitTestRunner/qt/PlatformWebViewQt.cpp: Added.
1078         Empty stub implementation.
1079         (WTR::registerWindowClass):
1080         (WTR::PlatformWebView::PlatformWebView):
1081         (WTR::PlatformWebView::~PlatformWebView):
1082         (WTR::PlatformWebView::resizeTo):
1083         (WTR::PlatformWebView::page):
1084         (WTR::PlatformWebView::focus):
1085         * WebKitTestRunner/qt/TestControllerQt.cpp: Added.
1086         Empty stub implementation.
1087         (WTR::registerWindowClass):
1088         (WTR::TestController::runUntil):
1089         (WTR::TestController::platformInitialize):
1090         (WTR::TestController::initializeInjectedBundlePath):
1091         (WTR::TestController::initializeTestPluginDirectory):
1092         (WTR::TestController::platformInitializeContext):
1093         * WebKitTestRunner/qt/WebKitTestRunner.pro: Added.
1094         * WebKitTestRunner/qt/main.cpp: Added.
1095         (main):
1096
1097 2010-10-06  Tony Chang  <tony@chromium.org>
1098
1099         Unreviewed, rolling out r69202.
1100         http://trac.webkit.org/changeset/69202
1101         https://bugs.webkit.org/show_bug.cgi?id=46937
1102
1103         Broke compile of test_shell
1104
1105         * DumpRenderTree/chromium/EventSender.cpp:
1106         (EventSender::beginDragWithFiles):
1107         * DumpRenderTree/chromium/WebViewHost.cpp:
1108         (addDRTFakeFileToDataObject):
1109
1110 2010-10-06  Daniel Cheng  <dcheng@chromium.org>
1111
1112         Reviewed by Tony Chang.
1113
1114         [chromium] Minor naming cleanup in WebDragData, part 2
1115         https://bugs.webkit.org/show_bug.cgi?id=46937
1116
1117         Update DRT to use the renamed methods.
1118
1119         * DumpRenderTree/chromium/EventSender.cpp:
1120         (EventSender::beginDragWithFiles):
1121         * DumpRenderTree/chromium/WebViewHost.cpp:
1122         (addDRTFakeFileToDataObject):
1123
1124 2010-10-06  David Kilzer  <ddkilzer@apple.com>
1125
1126         <http://webkit.org/b/47270> Move WebArchive serialization code into its own file
1127
1128         Reviewed by Adam Roben.
1129
1130         This is the first step in making webarchive tests work on
1131         Windows.
1132
1133         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added
1134         new files to the project.
1135         * DumpRenderTree/mac/DumpRenderTree.mm: Removed code that moved
1136         to WebArchiveDumpSupport.mm.
1137         * DumpRenderTree/mac/WebArchiveDumpSupport.h: Added.
1138         * DumpRenderTree/mac/WebArchiveDumpSupport.mm: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm.
1139         (serializeWebArchiveToXML):
1140
1141 2010-10-05  Daniel Bates  <dbates@rim.com>
1142
1143         Reviewed by David Kilzer.
1144
1145         Add infrastructure to towards detecting change log diffs that aren't at the top of the ChangeLog
1146         https://bugs.webkit.org/show_bug.cgi?id=46058
1147
1148         Make VCSUtils::fixChangeLogPatch() return a reference to a hash
1149         structure so as to support returning additional information
1150         about a change log diff.
1151
1152         Currently, VCSUtils::fixChangeLogPatch() returns a string that
1153         represents the change log diff. Towards supporting the return
1154         of additional information, such as whether the change log diff
1155         inserts an entry at the top of the ChangeLog file, we need to
1156         make VCSUtils::fixChangeLogPatch() return a reference to hash
1157         structure.
1158
1159         * Scripts/VCSUtils.pm:
1160           - Modified fixChangeLogPatch() to return a reference to a
1161             hash structure.
1162           - Added documentation to fixChangeLogPatch().
1163           - Modified call site in mergeChangeLogs() as necessary.
1164         * Scripts/svn-apply:
1165           - Modified call site in patch() as necessary.
1166         * Scripts/svn-create-patch:
1167           - Modified call site in generateDiff() as necessary.
1168         * Scripts/svn-unapply:
1169           - Modified call site in patch() as necessary.
1170         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
1171           - Modified the unit tests as necessary.
1172
1173 2010-10-05  Tony Chang  <tony@chromium.org>
1174
1175         Reviewed by Darin Adler.
1176
1177         fix the link to the expected image on windows
1178         https://bugs.webkit.org/show_bug.cgi?id=47228
1179
1180         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: On
1181             windows, the file must be opened in binary mode when writing
1182             binary data.
1183
1184 2010-10-05  Adam Barth  <abarth@webkit.org>
1185
1186         Update expected result of unittest to match Tony's change below.
1187
1188         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1189
1190 2010-10-05  Tony Chang  <tony@chromium.org>
1191
1192         Reviewed by Ojan Vafai (over the shoulder).
1193
1194         Paper over errors in image_diff so we don't crash the whole test run.
1195
1196         * Scripts/webkitpy/layout_tests/port/chromium.py:
1197
1198 2010-10-05  Tony Chang  <tony@chromium.org>
1199
1200         Unreviewed, make shutil.rmtree more resiliant to errors
1201         since windows was raising WindowsError: The process cannot access the file because it
1202         is being used by another process.
1203
1204         * Scripts/webkitpy/layout_tests/port/chromium.py:
1205
1206 2010-10-05  Tony Chang  <tony@chromium.org>
1207
1208         Reviewed by Ojan Vafai.
1209
1210         [chromium] fix image diffing in NRWT
1211         https://bugs.webkit.org/show_bug.cgi?id=47128
1212
1213         * Scripts/webkitpy/layout_tests/port/chromium.py: Stop using
1214             NamedTemporaryFile since it doesn't work on Windows.
1215         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1216
1217 2010-10-05  Kenneth Russell  <kbr@google.com>
1218
1219         Reviewed by Tony Chang.
1220
1221         [chromium] Implement layerTreeAsText in DumpRenderTree
1222         https://bugs.webkit.org/show_bug.cgi?id=47216
1223
1224         Plumbed Frame::layerTreeAsText through Chromium's WebKit API to
1225         make it callable from DumpRenderTree.
1226
1227         No new tests; verified with existing compositor layout tests.
1228
1229         * DumpRenderTree/chromium/LayoutTestController.cpp:
1230         (LayoutTestController::LayoutTestController):
1231         (LayoutTestController::layerTreeAsText):
1232         * DumpRenderTree/chromium/LayoutTestController.h:
1233
1234 2010-10-05  Brent Fulgham  <bfulgham@webkit.org>
1235
1236         Unreviewed build correction.
1237
1238         * DumpRenderTree/win/ImageDiff.vcproj: Use WinCairo debug
1239         property sheet so proper libraries are linked.
1240
1241 2010-10-05  Robert Hogan  <robert@webkit.org>
1242
1243         Reviewed by Andreas Kling.
1244
1245         [Qt] Fix url conversion in QWebHistory
1246
1247         Converting from KURL to WFT::String to QUrl does not
1248         permit proper percent encoding later.
1249
1250         https://bugs.webkit.org/show_bug.cgi?id=47048
1251
1252         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1253         (WebCore::dumpHistoryItem):
1254
1255 2010-10-05  Anders Carlsson  <andersca@apple.com>
1256
1257         Reviewed by Sam Weinig.
1258
1259         REGRESSION (r68966?): All dumpAsText test fail on WebKit2
1260         https://bugs.webkit.org/show_bug.cgi?id=47188
1261         <rdar://problem/8514104>
1262
1263         When constructing the std::string, use the real string length instead of the maximum buffer size.
1264
1265         * TestWebKitAPI/PlatformUtilities.h:
1266         (TestWebKitAPI::Util::toSTD):
1267         * WebKitTestRunner/StringFunctions.h:
1268         (WTR::toSTD):
1269
1270 2010-10-04  Sam Weinig  <sam@webkit.org>
1271
1272         Reviewed by Mark Rowe.
1273
1274         Add MIMEType accessor to WKFrame
1275         <rdar://problem/8347683>
1276         https://bugs.webkit.org/show_bug.cgi?id=47138
1277
1278         * TestWebKitAPI/PlatformUtilities.h:
1279         (TestWebKitAPI::Util::toSTD):
1280         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1281         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp: Added.
1282         (TestWebKitAPI::didStartProvisionalLoadForFrame):
1283         (TestWebKitAPI::didCommitLoadForFrame):
1284         (TestWebKitAPI::didFinishLoadForFrame):
1285         (TestWebKitAPI::TEST):
1286         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp: Added.
1287         (TestWebKitAPI::didStartProvisionalLoadForFrame):
1288         (TestWebKitAPI::didCommitLoadForFrame):
1289         (TestWebKitAPI::didFinishLoadForFrame):
1290         (TestWebKitAPI::TEST):
1291         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1292         (TestWebKitAPI::TEST):
1293         * TestWebKitAPI/Tests/WebKit2/basic-1.html: Removed.
1294         * TestWebKitAPI/Tests/WebKit2/icon.png: Added.
1295         * TestWebKitAPI/Tests/WebKit2/simple.html: Added.
1296         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1297         (TestWebKitAPI::Util::createURLForResource):
1298
1299 2010-10-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1300
1301         Reviewed by Ojan Vafai.
1302
1303         [NRWT] Rename current_dir to current_group because it's not a directory
1304         https://bugs.webkit.org/show_bug.cgi?id=47169
1305
1306         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1307         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1308
1309 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
1310
1311         Unreviewed, build fix.
1312
1313         r69065 broke test-webkitpy by trying to create a '/tmp-X' directory,
1314         which can't always be done. This test uses tempfile.mkdtemp(), which
1315         should be safe.
1316
1317         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1318
1319 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
1320
1321         Unreviewed, build fix.
1322
1323         Add missing "from __future__ import with_statement" that was
1324         breaking test-webkitpy on the Leopard bots (broke in r69040).
1325
1326         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1327
1328 2010-10-04  Sheriff Bot  <webkit.review.bot@gmail.com>
1329
1330         Unreviewed, rolling out r69066.
1331         http://trac.webkit.org/changeset/69066
1332         https://bugs.webkit.org/show_bug.cgi?id=47163
1333
1334         Made NRWT reliability worse. (Requested by tkent on #webkit).
1335
1336         * Scripts/webkitpy/layout_tests/port/chromium.py:
1337         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1338
1339 2010-10-04  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1340
1341         Reviewed by Tony Chang.
1342
1343         [NRWT] Reverse the http tests to alphabetical order.
1344         https://bugs.webkit.org/show_bug.cgi?id=47075
1345
1346         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1347
1348 2010-10-04  Robert Hogan  <robert@webkit.org>
1349
1350         Reviewed by Andreas Kling.
1351
1352         [Qt] Fix timeout on http/tests/navigation/post-goback2.html and postredirect-goback2.html
1353
1354         We need to queue back and forward navigations in the DRT from the
1355         LayoutTestController so that maybeDump() knows about them.
1356
1357         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1358         (LayoutTestController::queueBackNavigation):
1359         (LayoutTestController::queueForwardNavigation):
1360
1361 2010-10-04  Tony Chang  <tony@chromium.org>
1362
1363         Reviewed by Kent Tamura.
1364
1365         [chromium] fix image diffing in NRWT
1366         https://bugs.webkit.org/show_bug.cgi?id=47128
1367
1368         * Scripts/webkitpy/layout_tests/port/chromium.py: Flush data to the
1369               temp file and check the image_diff error code more carefully
1370         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1371
1372 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
1373
1374         Reviewed by Adam Barth.
1375
1376         aroben's change in r68792 actually broke new-run-webkit-tests when
1377         running the DRT code path. His change was intended to fix the
1378         way we were converting windows paths to URIs when running under
1379         Cygwin (the paths were getting one too many "/" on the front).
1380         However, the change ended up breaking the chromium_win port, which
1381         had slightly different logic.
1382
1383         This patch removes the port-specific code and adds tests to make
1384         sure we're getting the behavior we expect. The Port object no longer
1385         exposes a get_absolute_path() method that can be used outside of
1386         of converting test filenames, because it's unreliable otherwise
1387         (we don't have the right context to know which conversion is intended).
1388
1389         https://bugs.webkit.org/show_bug.cgi?id=47140
1390
1391         * Scripts/webkitpy/layout_tests/port/base.py:
1392         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1393         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1394         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1395         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1396
1397 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
1398
1399         Unreviewed, build fix.
1400
1401         Handle crash introduced in r69040 if we are not running in a
1402         Chromium checkout.
1403
1404         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1405
1406 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
1407
1408         Reviewed by Tony Chang.
1409
1410         Add a way for us to have test expectations that are specific to the
1411         official builds of Google Chrome (as opposed to Chromium). This change
1412         looks for an additional "test_expectations_chrome.txt" file in
1413         Chromium's repository (webkit/tools/layout_tests), and uses the
1414         concatenation of that file and the regular test_expectations.txt
1415         file for test overrides.
1416
1417         https://bugs.webkit.org/show_bug.cgi?id=46854
1418
1419         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1420         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1421
1422 2010-10-04  Simon Fraser  <simon.fraser@apple.com>
1423
1424         Color tests in the list based on existing pass/fail result.
1425         
1426         Fix the summary data to account for htmlOnly and nonHTML tests.
1427
1428         * CSSTestSuiteHarness/harness/harness.css:
1429         (#test-list > option.pass):
1430         (#test-list > option.fail):
1431         (#test-list > option.skipped):
1432         * CSSTestSuiteHarness/harness/harness.js:
1433         (Test):
1434         (Test.prototype.statusForFormat):
1435         (TestSuite.prototype.fillTestList):
1436         (TestSuite.prototype.updateTestList):
1437         (TestSuite.prototype.recordResult):
1438         (TestSuite.prototype.markTestCompleted):
1439         (TestSuite.prototype.countTestsWithFlag):
1440         (TestSuite.prototype.queryDatabaseForSummary.this.db.transaction):
1441         (TestSuite.prototype.queryDatabaseForSummary):
1442
1443 2010-10-04  Chris Fleizach  <cfleizach@apple.com>
1444
1445         Reviewed by Beth Dakin.
1446
1447         AX: doAXRangeForLine does not work
1448         https://bugs.webkit.org/show_bug.cgi?id=47101
1449
1450         DRT support to handle NSAccessibilityRangeForLineParameterizedAttribute.
1451
1452         * DumpRenderTree/AccessibilityUIElement.cpp:
1453         (rangeForLineCallback):
1454         (AccessibilityUIElement::rangeForLine):
1455         (AccessibilityUIElement::getJSClass):
1456         * DumpRenderTree/AccessibilityUIElement.h:
1457         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1458         (AccessibilityUIElement::rangeForLine):
1459
1460 2010-10-04  Andrey Kosyakov  <caseq@chromium.org>
1461
1462         Unreviewed. Adding myself to the committers list.
1463
1464         * Scripts/webkitpy/common/config/committers.py:
1465
1466 2010-10-04  Sam Weinig  <sam@webkit.org>
1467
1468         Reviewed by Anders Carlsson.
1469
1470         Add ability to set the CacheModel in Webkit2
1471         https://bugs.webkit.org/show_bug.cgi?id=47066
1472
1473         * MiniBrowser/mac/AppDelegate.m:
1474         (-[BrowserAppDelegate init]): Opt minibrowser into
1475         a PrimaryWebBrowser cache model.
1476
1477 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
1478
1479         Make sure to enter all tests when creating the database
1480         for the first time.
1481         
1482         When migrating to a new version of the suite, be sure to
1483         sync up the database and testinfo.data by removing old
1484         tests, and inserting new ones.
1485
1486         * CSSTestSuiteHarness/harness/harness.js:
1487         (TestSuite.prototype.openDatabase.creation):
1488         (TestSuite.prototype.databaseCreated):
1489         (TestSuite.prototype.populateDatabaseFromTestInfoData):
1490         (TestSuite.prototype.insertTest):
1491
1492 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
1493
1494         More work on treating HTML4 and XHTML1 independently; when 
1495         changing the format, rebuild the test list, and update the 
1496         numbers in the chapter popup.
1497
1498         * CSSTestSuiteHarness/harness/harness.js:
1499         (Test):
1500         (Test.prototype.runForFormat):
1501         (Test.prototype.completedForFormat):
1502         (ChapterSection):
1503         (ChapterSection.prototype.countTests):
1504         (Chapter):
1505         (Chapter.prototype.description):
1506         (Chapter.prototype.countTests):
1507         (Chapter.prototype.testCount):
1508         (Chapter.prototype.untestedCount):
1509         (TestSuite.prototype.buildChapters):
1510         (TestSuite.prototype.loadCurrentTest):
1511         (TestSuite.prototype.updateProgressLabel):
1512         (TestSuite.prototype.processFlags):
1513         (TestSuite.prototype.formatChanged):
1514
1515 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
1516
1517         Update test suite version 20101001.
1518         
1519         Handle database migration, and delete tests from the db that are
1520         not present in testinfo.data.
1521         
1522         Load about:blank into the test frame before the test url, to make
1523         missing tests more obvious.
1524         
1525         * CSSTestSuiteHarness/harness/harness.js:
1526         (TestSuite.prototype.loadTest):
1527         (TestSuite.prototype.openDatabase.creation):
1528         (TestSuite.prototype.openDatabase.migration1_0To1_1):
1529         (TestSuite.prototype.openDatabase.if.return):
1530         (TestSuite.prototype.databaseReady):
1531         (TestSuite.prototype.populateDatabaseFromTestInfoData):
1532         (TestSuite.prototype.syncDatabaseWithTestInfoData.this.db.transaction):
1533         (TestSuite.prototype.syncDatabaseWithTestInfoData):
1534
1535 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
1536
1537         Add the ability to jump to a specific test.
1538
1539         * CSSTestSuiteHarness/harness/harness.html:
1540         * CSSTestSuiteHarness/harness/harness.js:
1541         (TestSuite.prototype.goToTestByName):
1542         (TestSuite.prototype.switchToFormat):
1543
1544 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
1545
1546         For a ref test, load the ref in the same format (HTML4 vs XHTML1)
1547         as the test.
1548
1549         * CSSTestSuiteHarness/harness/harness.js:
1550         (TestSuite.prototype.loadRef):
1551
1552 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
1553
1554         Update the UI to reflect the fact that each test needs to be tested
1555         in both HTML4 and XHTML1 format.
1556         
1557         * CSSTestSuiteHarness/harness/harness.js:
1558         (Test):
1559         (Chapter.prototype.description):
1560         (Chapter.prototype.untestedCount):
1561         (TestSuite.prototype.fillChapterPopup):
1562         (TestSuite.prototype.updateChapterPopup):
1563         (TestSuite.prototype.fillTestList):
1564         (TestSuite.prototype.updateTestList):
1565         (TestSuite.prototype.goToNextIncompleteTest):
1566         (TestSuite.prototype.firstIncompleteTestIndex):
1567         (TestSuite.prototype.recordResult):
1568         (TestSuite.prototype.formatChanged):
1569         (TestSuite.prototype.markTestCompleted):
1570         (TestSuite.prototype.resetTestStatus):
1571
1572 2010-10-01  Simon Fraser  <simon.fraser@apple.com>
1573
1574         Add the ability to remove results for re-testing, and
1575         to import results.
1576
1577         * CSSTestSuiteHarness/harness/harness.css:
1578         (.custom button):
1579         (#overlay):
1580         (#overlay.visible):
1581         (.overlay-contents):
1582         (.overlay-contents textarea):
1583         (.overlay-contents .buttons):
1584         (.overlay-contents .note):
1585         (.overlay-contents .buttons button):
1586         * CSSTestSuiteHarness/harness/harness.html:
1587         * CSSTestSuiteHarness/harness/harness.js:
1588         (TestSuite.prototype.importResults):
1589         (TestSuite.prototype.clearResults):
1590         (TestSuite.prototype.markTestCompleted):
1591         (TestSuite.prototype.resetTestStatus):
1592         (TestSuite.prototype.storeTestResult):
1593         (TestSuite.prototype.importTestResults):
1594         (TestSuite.prototype.clearTestResults):
1595
1596 2010-10-01  Sam Weinig  <sam@webkit.org>
1597
1598         Reviewed by Jon Honeycutt.
1599
1600         Deploy the new WKString functions to remove most uses of CF from
1601         the WebKitTestRunner.
1602
1603         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1604         (WTR::InjectedBundle::didReceiveMessage):
1605         (WTR::InjectedBundle::done):
1606         * WebKitTestRunner/StringFunctions.h:
1607         (WTR::toWK):
1608         (WTR::toJS):
1609         (WTR::toSTD):
1610         (WTR::operator<<):
1611         (WTR::copyURLString):
1612         * WebKitTestRunner/TestController.cpp:
1613         (WTR::TestController::resetStateToConsistentValues):
1614         (WTR::TestController::didFinishLoadForFrame):
1615         * WebKitTestRunner/TestInvocation.cpp:
1616         (WTR::TestInvocation::invoke):
1617         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1618
1619 2010-10-01  Mihai Parparita  <mihaip@chromium.org>
1620
1621         Unreviewed TestResultsServer change.
1622
1623         Add files introduced by http://crrev.com/61273 to the list of dashboard 
1624         files to update.
1625
1626         * TestResultServer/handlers/dashboardhandler.py:
1627
1628 2010-10-01  Brian Weinstein  <bweinstein@apple.com>
1629
1630         Build Fix for Windows.
1631
1632         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Don't copy ForwardingHeaders from
1633             WebKitTestRunner/ForwardingHeaders, instead, add $(WebKitOutputDir)/include/WebCore/
1634             ForwardingHeaders to the include path.
1635
1636 2010-10-01  Sam Weinig  <sam@webkit.org>
1637
1638         Reviewed by Anders Carlsson.
1639
1640         Add SPI to convert a WKStringRef to a JSStringRef and vice-versa.
1641
1642         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1643         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
1644         (TestWebKitAPI::TEST):
1645         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp: Added.
1646         (TestWebKitAPI::TEST):
1647
1648 2010-10-01  Sam Weinig  <sam@webkit.org>
1649
1650         Reviewed by Kenneth Rohde Christiansen.
1651
1652         Add additional WKString API
1653         https://bugs.webkit.org/show_bug.cgi?id=46958
1654
1655         Add basic WKStringRef tests.
1656
1657         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1658         * TestWebKitAPI/Tests/WebKit2/WKString.cpp: Added.
1659
1660 2010-10-01  Sam Weinig  <sam@webkit.org>
1661
1662         Reviewed by Dan Bernstein.
1663
1664         Add makefile for TestWebKitAPI and call it from the base makefile.
1665
1666         * Makefile:
1667         * TestWebKitAPI/Makefile: Added.
1668
1669 2010-10-01  Sam Weinig  <sam@webkit.org>
1670
1671         Reviewed by Adam Roben.
1672
1673         Remove unnecessary ForwardingHeaders from test runners.
1674         https://bugs.webkit.org/show_bug.cgi?id=47010
1675
1676         * TestWebKitAPI/Configurations/Base.xcconfig:
1677         * TestWebKitAPI/ForwardingHeaders: Removed.
1678         * WebKitTestRunner/Configurations/Base.xcconfig:
1679         * WebKitTestRunner/ForwardingHeaders: Removed.
1680
1681 2010-09-30  Adam Barth  <abarth@webkit.org>
1682
1683         Reviewed by Eric Seidel.
1684
1685         WebSocket tests are flaky
1686         https://bugs.webkit.org/show_bug.cgi?id=46956
1687
1688         Update these tools to understand how to run the WebSocket tests off the
1689         Apache server.
1690
1691         * Scripts/old-run-webkit-tests:
1692         * Scripts/webkitpy/layout_tests/port/base.py:
1693         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1694         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1695
1696 2010-10-01  Adam Roben  <aroben@apple.com>
1697
1698         Encode Executive command arguments using UTF-8 on Cygwin
1699
1700         Cygwin's Python's os.execv doesn't support unicode command arguments.
1701         Cygwin's execv expects arguments to be encoded using the current code
1702         page. But code pages are limited in what characters they can handle,
1703         and our tests include characters that the English code page can't
1704         handle.  So for now we'll just encode everything in UTF-8 on Cygwin,
1705         which can handle all characters but might confuse some commands, for
1706         expediency's sake. I'm sure we'll run into cases where UTF-8 isn't
1707         good enough, but we can deal with that when the problem arises.
1708
1709         Reviewed by Adam Barth.
1710
1711         Fixes <http://webkit.org/b/46892> <rdar://problem/8496639>
1712         webkitpy.common.system.executive_unittest.ExecutiveTest.test_run_command_with_unicode
1713         fails on Windows
1714
1715         * Scripts/webkitpy/common/system/executive.py:
1716         (Executive._run_command_with_teed_output):
1717         (Executive.run_command):
1718         On Cygwin, encode arguments using UTF-8.
1719
1720 2010-10-01  Sam Weinig  <sam@webkit.org>
1721
1722         Reviewed by Adam Roben.
1723
1724         Add simple API tester for WebKit2
1725         https://bugs.webkit.org/show_bug.cgi?id=46953
1726
1727         This adds a very simple testing infrastructure for testing APIs exposed
1728         through the WebKit project. It consists of two parts: 1) a project that
1729         builds the all the tests 2) a script that searches the tests directory and
1730         calls the tester once for each test.
1731
1732         This adds the infrastructure and two tests:
1733         - Tests/WTF/Vector1.cpp - A proof of concept test of WTF data-structures.
1734         - Tests/WebKit2/BasicTest1.cpp - A proof of concept test of WebKit2 API.
1735
1736         This currently only works on the mac, but is designed to be easily ported 
1737         to any platform.
1738
1739         * Scripts/run-api-tests: Added.
1740         * Scripts/build-api-tests: Added.
1741         Scripts to build/run the tests.
1742
1743         * TestWebKitAPI: Added.
1744         * TestWebKitAPI/Configurations: Added.
1745         * TestWebKitAPI/Configurations/Base.xcconfig: Added.
1746         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Added.
1747         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Added.
1748         * TestWebKitAPI/ForwardingHeaders: Added.
1749         * TestWebKitAPI/ForwardingHeaders/wtf: Added.
1750         * TestWebKitAPI/PlatformUtilities.h: Added.
1751         * TestWebKitAPI/PlatformWebView.h: Added.
1752         (TestWebKitAPI::PlatformWebView::platformView):
1753         * TestWebKitAPI/StringFunctions.h: Added.
1754         * TestWebKitAPI/Test.h: Added.
1755         (TestWebKitAPI::Test::~Test):
1756         (TestWebKitAPI::Test::name):
1757         (TestWebKitAPI::Test::Register::Register):
1758         (TestWebKitAPI::Test::Register::create):
1759         (TestWebKitAPI::Test::Test):
1760         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Added.
1761         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added.
1762         * TestWebKitAPI/TestWebKitAPIPrefix.h: Added.
1763         * TestWebKitAPI/TestsController.cpp: Added.
1764         (TestWebKitAPI::TestsController::shared):
1765         (TestWebKitAPI::TestsController::TestsController):
1766         (TestWebKitAPI::TestsController::runTestNamed):
1767         (TestWebKitAPI::TestsController::testFailed):
1768         (TestWebKitAPI::TestsController::registerCreateTestFunction):
1769         * TestWebKitAPI/TestsController.h: Added.
1770         * TestWebKitAPI/mac: Added.
1771         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm: Added.
1772         (TestWebKitAPI::Util::run):
1773         (TestWebKitAPI::Util::createURLForResource):
1774         * TestWebKitAPI/mac/PlatformWebViewMac.mm: Added.
1775         (TestWebKitAPI::PlatformWebView::PlatformWebView):
1776         (TestWebKitAPI::PlatformWebView::resizeTo):
1777         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
1778         (TestWebKitAPI::PlatformWebView::page):
1779         (TestWebKitAPI::PlatformWebView::focus):
1780         * TestWebKitAPI/mac/main.mm: Added.
1781         Infrastructure.
1782
1783         * TestWebKitAPI/Tests: Added.
1784         * TestWebKitAPI/Tests/WTF: Added.
1785         * TestWebKitAPI/Tests/WTF/Vector1.cpp: Added.
1786         * TestWebKitAPI/Tests/WebKit2: Added.
1787         * TestWebKitAPI/Tests/WebKit2/BasicTest1.cpp: Added.
1788         (TestWebKitAPI::State::State):
1789         * TestWebKitAPI/Tests/WebKit2/basic-1.html: Added.
1790         Proof of concept tests.
1791
1792 2010-10-01  Adam Roben  <aroben@apple.com>
1793
1794         Don't assume AccessibleObjectFromEvent succeeds
1795
1796         Fixes <http://webkit.org/b/44136> <rdar://problem/8321684> Crash in
1797         DumpRenderTree!notificationListenerProc when running
1798         plugins/access-after-page-destroyed.html
1799
1800         Reviewed by Sam Weinig.
1801
1802         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1803         (notificationListenerProc): Check both the return value of
1804         AccessibleObjectFromEvent and the object it returns, as MSDN
1805         recommends.
1806
1807 2010-10-01  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1808
1809         Reviewed by Tony Chang.
1810
1811         [NRWT] Put the http and websocket tests first in the test list.
1812         https://bugs.webkit.org/show_bug.cgi?id=46453
1813
1814         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1815         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1816
1817 2010-10-01  Fady Samuel  <fsamuel@chromium.org>
1818
1819         Unreviewed, adding myself to the committer list.
1820
1821         * Scripts/webkitpy/common/config/committers.py:
1822
1823 2010-10-01  Adam Roben  <aroben@apple.com>
1824
1825         Test NPN_GetValue(NPNVnetscapeWindow)
1826
1827         Test for <http://webkit.org/b/46726> <rdar://problem/8486319>
1828         Right-clicking on windowless Flash plugin in WebKit2 makes a context
1829         menu appear in the bottom-right corner of the screen
1830
1831         Reviewed by Anders Carlsson.
1832
1833         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1834         (PluginTest::NPN_GetValue): Added. Calls through to the browser.
1835
1836         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added NPN_GetValue.
1837
1838         * DumpRenderTree/TestNetscapePlugIn/Tests/win/GetValueNetscapeWindow.cpp: Added.
1839         (GetValueNetscapeWindow::GetValueNetscapeWindow): Initialize members.
1840         (GetValueNetscapeWindow::NPP_SetWindow): Test that
1841         NPN_GetValue(NPNVnetscapeWindow) returns a valid HWND and that it
1842         isn't our HWND.
1843
1844         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1845         Added GetValueNetscapeWindow.
1846
1847 2010-10-01  Andreas Kling  <andreas.kling@nokia.com>
1848
1849         Unreviewed, adding my webkit.org identity to reviewer list.
1850
1851         * Scripts/webkitpy/common/config/committers.py:
1852
1853 2010-09-30  Adam Barth  <abarth@webkit.org>
1854
1855         Reviewed by Eric Seidel.
1856
1857         The WebSocket server should flush its logs
1858         https://bugs.webkit.org/show_bug.cgi?id=46946
1859
1860         The WebSocket server logs are truncated because the driver just
1861         terminates the child.  It should run Python without buffering so we can
1862         see the end of the log.
1863
1864         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1865
1866 2010-09-30  Simon Fraser  <simon.fraser@apple.com>
1867
1868         Add a button to jump to the next untested test.
1869         
1870         * CSSTestSuiteHarness/harness/harness.css:
1871         (.test-type):
1872         (.name > button):
1873         * CSSTestSuiteHarness/harness/harness.html:
1874         * CSSTestSuiteHarness/harness/harness.js:
1875         (Chapter.prototype.description):
1876         (Chapter.prototype.untestedCount):
1877         (TestSuite.prototype.testInfoDataLoaded):
1878         (TestSuite.prototype.fillChapterPopup):
1879         (TestSuite.prototype.updateChapterPopup):
1880         (TestSuite.prototype.buildTestListForChapter):
1881         (TestSuite.prototype.goToNextIncompleteTest):
1882         (TestSuite.prototype.firstIncompleteTestIndex):
1883         (TestSuite.prototype.testCompletionStateChanged):
1884
1885 2010-09-29  Jon Honeycutt  <jhoneycutt@apple.com>
1886
1887         WebKit2 on Windows should use Windows fonts for the various standard
1888         font families
1889         https://bugs.webkit.org/show_bug.cgi?id=43499
1890         <rdar://problem/8272758>
1891
1892         Reviewed by Adam Roben.
1893
1894         * WebKitTestRunner/TestController.cpp:
1895         (WTR::TestController::resetStateToConsistentValues):
1896         Use the Mac fonts for running tests. This matches DRT behavior.
1897
1898 2010-09-30  Adam Barth  <abarth@webkit.org>
1899
1900         Third attempt.  We need a better integration test environment.
1901
1902         * Scripts/webkitpy/common/net/failuremap.py:
1903         * Scripts/webkitpy/common/net/failuremap_unittest.py:
1904
1905 2010-09-30  Robert Hogan  <robert@webkit.org>
1906
1907         Reviewed by Andreas Kling.
1908
1909         [Qt] Support for PlainTextController
1910
1911         Unskip editing/text-iterator/basic-iteration.html
1912
1913         https://bugs.webkit.org/show_bug.cgi?id=38805
1914
1915         * DumpRenderTree/qt/DumpRenderTree.pro:
1916         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1917         (WebCore::DumpRenderTree::DumpRenderTree):
1918         (WebCore::DumpRenderTree::initJSObjects):
1919         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1920         * DumpRenderTree/qt/PlainTextControllerQt.cpp: Added.
1921         (PlainTextController::PlainTextController):
1922         (PlainTextController::plainText):
1923         * DumpRenderTree/qt/PlainTextControllerQt.h: Added.
1924
1925 2010-09-30  Adam Barth  <abarth@webkit.org>
1926
1927         Unreviewed.  Second attempt to fix sheriffbot.
1928
1929         * Scripts/webkitpy/common/net/buildbot.py:
1930
1931 2010-09-30  Adam Barth  <abarth@webkit.org>
1932
1933         Unreviewed.
1934
1935         This patch should stop the sheriffbot from throwing an exception.
1936
1937         * Scripts/webkitpy/common/net/buildbot.py:
1938
1939 2010-09-30  Brian Weinstein  <bweinstein@apple.com>
1940
1941         Reviewed by Adam Roben.
1942
1943         The same bots shouldn't run both Windows Debug Tests and Windows Release Tests.
1944         https://bugs.webkit.org/show_bug.cgi?id=46926
1945
1946         * BuildSlaveSupport/build.webkit.org-config/config.json: Have two bots running Windows 
1947             Release Tests, and two bots running Windows Debug Tests, instead of four running both.
1948
1949 2010-09-30  Adam Barth  <abarth@webkit.org>
1950
1951         Reviewed by Eric Seidel.
1952
1953         webkit-patch find-flaky-tests should print results URLs
1954         https://bugs.webkit.org/show_bug.cgi?id=46917
1955
1956         Printing out the results URL makes find-flaky-tests more actionable
1957         because you can see what happens when a test fails.  The output from
1958         the script is still pretty noisy, but it seems useful.
1959
1960         * Scripts/webkitpy/tool/commands/queries.py:
1961
1962 2010-09-30  Chris Marrin  <cmarrin@apple.com>
1963
1964         Reviewed by Simon Fraser.
1965
1966         Make 2D accelerated canvas rendering build on Mac
1967         https://bugs.webkit.org/show_bug.cgi?id=46007
1968         
1969         Added ACCELERATED_2D_CANVAS to build-webkit
1970
1971         * Scripts/build-webkit:
1972
1973 2010-09-29  Kenneth Russell  <kbr@google.com>
1974
1975         Reviewed by Dimitri Glazkov.
1976
1977         [chromium] Add accelerated compositing support to DumpRenderTree and test_shell
1978         https://bugs.webkit.org/show_bug.cgi?id=46849
1979
1980         Added offscreen code path for WebGraphicsContext3DDefaultImpl which
1981         works with the compositor integration in both DumpRenderTree and
1982         test_shell, since both pass a non-null WebCanvas* to WebViewImpl::paint
1983         and thereby trigger the compositor's readback code path. Added support
1984         for --enable-accelerated-compositing to DumpRenderTree.
1985
1986         Tested in both test_shell and DumpRenderTree on Linux, the latter by
1987         modifying a compositing layout test, dumping the pixels and verifying
1988         that they matched the output when the compositor was active.
1989
1990         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1991         (main):
1992         * DumpRenderTree/chromium/TestShell.cpp:
1993         (TestShell::TestShell):
1994         (TestShell::resetWebSettings):
1995         * DumpRenderTree/chromium/TestShell.h:
1996         (TestShell::setAcceleratedCompositingEnabled):
1997         * DumpRenderTree/chromium/WebPreferences.cpp:
1998         (WebPreferences::reset):
1999         (WebPreferences::applyTo):
2000         * DumpRenderTree/chromium/WebPreferences.h:
2001         * DumpRenderTree/chromium/WebViewHost.cpp:
2002         (WebViewHost::scheduleComposite):
2003         * DumpRenderTree/chromium/WebViewHost.h:
2004
2005 2010-09-30  Adam Roben  <aroben@apple.com>
2006
2007         Ensure that QueueEngine cleans up its log files when its delegate
2008         tells it to stop processing work
2009
2010         Reviewed by Adam Barth.
2011
2012         Fixes <http://webkit.org/b/46891> <rdar://problem/8496638> Many tests
2013         in webkitpy.tool.bot.queueengine_unittest.QueueEngineTest crash on
2014         Windows
2015
2016         * Scripts/webkitpy/tool/bot/queueengine.py:
2017         (QueueEngine.run): Stop ourselves normally (including cleaning up log
2018         files) when the delegate tells us to stop processing work.
2019
2020         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2021         (LoggingDelegate.__init__): Moved code here from
2022         RaisingDelegate.__init__.
2023         (LoggingDelegate.expeced_callbacks): Added the stop_work_queue
2024         callback.
2025         (LoggingDelegate.stop_work_queue): Moved here from RaisingDelegate.
2026         (RaisingDelegate.__init__): Removed code that LoggingDelegate takes
2027         care of for us now.
2028         (QueueEngineTest.test_trivial): Make sure we got the expected stop
2029         message.
2030         (QueueEngineTest.test_not_safe_to_proceed): Changed to explicitly
2031         remove the callbacks that are related to processing a single work
2032         item, rather than removing all callbacks after a certain point, as
2033         there are now more callbacks we expect to receive at the end.
2034
2035 2010-09-30  Adam Roben  <aroben@apple.com>
2036
2037         Fix path -> URL conversion on Cygwin
2038
2039         Reviewed by Adam Barth.
2040
2041         Fixes <http://webkit.org/b/46890> <rdar://problem/8496637> Many tests
2042         in webkitpy.layout_tests.run_webkit_tests_unittest assert on Windows
2043
2044         * Scripts/webkitpy/layout_tests/port/base.py:
2045         (Port.filename_to_uri): Treat Cygwin like other UNIX-y platforms by
2046         assuming paths already have a leading slash.
2047
2048 2010-09-30  Adam Roben  <aroben@apple.com>
2049
2050         Teach WindowGeometryInitializedBeforeSetWindow that NPP_SetWindow can
2051         be called more than once
2052
2053         The NPP_SetWindow call made when the plugin is torn down was confusing
2054         us, and was causing us to spew an error into the next test.
2055
2056         Fixes <http://webkit.org/b/46900> <rdar://problem/8496888> REGRESSION
2057         (r68520): plugins/access-after-page-destroyed.html failing on Windows
2058
2059         Reviewed by Anders Carlsson.
2060
2061         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:
2062         (WindowGeometryInitializedBeforeSetWindow::WindowGeometryInitializedBeforeSetWindow):
2063         Initialize member.
2064         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Bail if
2065         this isn't the first time this is called.
2066
2067 2010-09-30  Eric Seidel  <eric@webkit.org>
2068
2069         Reviewed by Adam Barth.
2070
2071         webkit-patch upload warns that I'm using Xcode when I'm not
2072         https://bugs.webkit.org/show_bug.cgi?id=46869
2073
2074         String.find returns -1 when not found, so switched to "in".
2075
2076         * Scripts/webkitpy/common/system/user.py:
2077         * Scripts/webkitpy/common/system/user_unittest.py:
2078
2079 2010-09-30  Eric Seidel  <eric@webkit.org>
2080
2081         Reviewed by Adam Barth.
2082
2083         webkit-patch failure-reason dies if non-trunk commits are in the blame range
2084         https://bugs.webkit.org/show_bug.cgi?id=46866
2085
2086         I also made failure-reason use RegressionWindow in a cleaner way.
2087
2088         * Scripts/webkitpy/tool/commands/queries.py:
2089
2090 2010-09-29  Adam Barth  <abarth@webkit.org>
2091
2092         Reviewed by Eric Seidel.
2093
2094         webkit-patch find-flaky-tests
2095         https://bugs.webkit.org/show_bug.cgi?id=46876
2096
2097         This command helps us find flaky tests so we can squash them.
2098
2099         * Scripts/webkitpy/tool/commands/queries.py:
2100
2101 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
2102
2103         Fix export to use '?' instead of 'null' for
2104         tests with no results.
2105         
2106         * CSSTestSuiteHarness/harness/harness.js:
2107
2108 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
2109
2110         Add a warning when a test requires special steps.
2111         Add a Print Preview button for 'paged' tests that
2112         brings up the print dialog, allowing the user to 
2113         judge paged media tests.
2114
2115         * CSSTestSuiteHarness/harness/harness.css:
2116         * CSSTestSuiteHarness/harness/harness.html:
2117         * CSSTestSuiteHarness/harness/harness.js:
2118         (TestSuite.prototype.loadTest):
2119         (TestSuite.prototype.processFlags):
2120
2121 2010-09-29  Adam Barth  <abarth@webkit.org>
2122
2123         Reviewed by Eric Seidel.
2124
2125         Remove revisions_casuing_failures
2126         https://bugs.webkit.org/show_bug.cgi?id=46872
2127
2128         This function exists only to be unit tested.
2129
2130         * Scripts/webkitpy/common/net/failuremap.py:
2131         * Scripts/webkitpy/common/net/failuremap_unittest.py:
2132         * Scripts/webkitpy/tool/mocktool.py:
2133
2134 2010-09-29  Adam Barth  <abarth@webkit.org>
2135
2136         Reviewed by Eric Seidel.
2137
2138         SheriffBot should post the list of failing tests to bugs
2139         https://bugs.webkit.org/show_bug.cgi?id=46871
2140
2141         * Scripts/webkitpy/common/net/buildbot.py:
2142         * Scripts/webkitpy/common/net/failuremap.py:
2143         * Scripts/webkitpy/common/net/regressionwindow.py:
2144         * Scripts/webkitpy/tool/bot/sheriff.py:
2145         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
2146         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2147         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2148         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2149         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2150         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2151         * Scripts/webkitpy/tool/mocktool.py:
2152
2153 2010-09-29  Brent Fulgham  <bfulgham@webkit.org>
2154
2155         Reviewed by Martin Robinson, Eric Seidel, and Mark Rowe.
2156
2157         [WinCairo] Adds a build slave.
2158         https://bugs.webkit.org/show_bug.cgi?id=46360
2159
2160         * BuildSlaveSupport/build.webkit.org-config/config.json: Add
2161         entries for a debug build of the WinCairo port.
2162         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add
2163         platform flag to configuration for wincairo (like gtk, chromium, etc.)
2164         * Scripts/build-webkit: Change 'cairo-win32' labeling to 'wincairo'
2165         * Scripts/webkitdirs.pm: Change 'cairo-win32' labeling to 'wincairo'
2166
2167 2010-09-29  Adam Barth  <abarth@webkit.org>
2168
2169         Reviewed by Eric Seidel.
2170
2171         Move more SheriffBot smarts into FailureMap
2172         https://bugs.webkit.org/show_bug.cgi?id=46703
2173
2174         This patch pushes the FailureMap model object further into the
2175         SheriffBot machine.  In addition, it moves a couple operations on this
2176         object from SheriffBot itself to the model.
2177
2178         Eventually, FailureMap will be the canonical context object for
2179         SheriffBot operations.  FailureMap represents a map of the current
2180         failures on the bots that might require remediation.
2181
2182         * Scripts/webkitpy/common/net/failuremap.py:
2183         * Scripts/webkitpy/common/net/regressionwindow.py:
2184         * Scripts/webkitpy/tool/commands/queries.py:
2185         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2186         * Scripts/webkitpy/tool/mocktool.py:
2187
2188 2010-09-29  Tony Chang  <tony@chromium.org>
2189
2190         Reviewed by James Robinson.
2191
2192         [chromium] enable -Werror for DRT and webkit_unit_tests on Linux
2193         https://bugs.webkit.org/show_bug.cgi?id=46829
2194
2195         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
2196         (DRTDevToolsClient::DRTDevToolsClient):
2197         * DumpRenderTree/chromium/TestShell.cpp:
2198         (TestShell::TestShell):
2199         * DumpRenderTree/chromium/WebViewHost.cpp:
2200         (WebViewHost::postAccessibilityNotification):
2201         (WebViewHost::WebViewHost):
2202
2203 2010-09-29  Chris Fleizach  <cfleizach@apple.com>
2204
2205         Reviewed by Darin Adler.
2206
2207         AX: implement CSS3 Speech "speak"
2208         https://bugs.webkit.org/show_bug.cgi?id=46827
2209
2210         * DumpRenderTree/AccessibilityUIElement.cpp:
2211         (speakCallback):
2212         (AccessibilityUIElement::speak):
2213         (AccessibilityUIElement::getJSClass):
2214         * DumpRenderTree/AccessibilityUIElement.h:
2215         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2216         (AccessibilityUIElement::speak):
2217
2218 2010-09-29  Mihai Parparita  <mihaip@chromium.org>
2219
2220         Reviewed by Adam Barth.
2221
2222         Record bot ID when updating queue status
2223         https://bugs.webkit.org/show_bug.cgi?id=46764
2224         
2225         Since we now have multiple bots handling patches from the commit queue,
2226         we need to differentiate status updates from them, so that we can group
2227         the queue status page in a less confusing way.
2228
2229         * QueueStatusServer/handlers/updatestatus.py: Accept bot_id as input
2230         * QueueStatusServer/model/queuestatus.py: Add bot_id property
2231         * QueueStatusServer/templates/updatestatus.html: Add bot_id input
2232         * Scripts/webkitpy/common/net/bugzilla_unittest.py: Extract MockBrowser
2233         * Scripts/webkitpy/common/net/statusserver.py: Add bot_id
2234         * Scripts/webkitpy/common/net/statusserver_unittest.py: Added.
2235         * Scripts/webkitpy/tool/main.py: Add --bot-id
2236         * Scripts/webkitpy/tool/mocktool.py: Add MockBrowser
2237
2238 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
2239
2240         No review.
2241         
2242         References always refert to a file in .xht format, even
2243         for HTML tests, so fix their loading.
2244
2245         * CSSTestSuiteHarness/harness/harness.js:
2246         (TestSuite.prototype.loadRef):
2247
2248 2010-09-28  Johnny Ding  <jnd@chromium.org>
2249
2250         Reviewed by Adam Barth.
2251
2252         https://bugs.webkit.org/show_bug.cgi?id=41292
2253         Add a new parameter to the test plugin to allow specifying a script 
2254         and a mouse/keyboard event. The specified script will be evaluated
2255         in the browser when the specified event is received by the plugin.
2256
2257         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2258         (pluginAllocate):
2259         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
2260         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2261         (NPP_New):
2262         (handleEventCarbon):
2263         (handleEventCocoa):
2264
2265 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
2266
2267         Fix export by adding missing argument.
2268
2269         * CSSTestSuiteHarness/harness/harness.js:
2270         (TestSuite.prototype.showResultsForAllTests):
2271
2272 2010-09-28  Kevin Ollivier  <kevino@theolliviers.com>
2273
2274         [wx] Build fix, add missing import.
2275
2276         * wx/packaging/build-win-installer.py:
2277
2278 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
2279
2280         No review
2281         
2282         Show which tests have been run by dimming them out in the test list.
2283         
2284         Adjust some element sizes.
2285         
2286         * CSSTestSuiteHarness/harness/harness.css:
2287         (#test-list > option.untested):
2288         (#test-list > option.completed):
2289         (#output):
2290         (.output-options):
2291         * CSSTestSuiteHarness/harness/harness.js:
2292         (Test):
2293         (TestSuite.prototype.fillTestList):
2294         (TestSuite.prototype.updateTestList):
2295         (TestSuite.prototype.setSelectedChapter):
2296         (TestSuite.prototype.recordResult):
2297         (TestSuite.prototype.markTestCompleted):
2298         (TestSuite.prototype.testCompletionStateChanged):
2299         (TestSuite.prototype.loadTestStatus):
2300
2301 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
2302
2303         No review.
2304         
2305         Implement export of various queries on the test database, sharing
2306         code with that which displays results inline.
2307
2308         * CSSTestSuiteHarness/harness/harness.js:
2309         ():
2310         (TestSuite.prototype.exportResultsCompletion.var):
2311         (TestSuite.prototype.exportResultsCompletion):
2312         (TestSuite.prototype.showResultsForCompletedTests):
2313         (TestSuite.prototype.exportResultsForCompletedTests):
2314         (TestSuite.prototype.showResultsForAllTests):
2315         (TestSuite.prototype.exportResultsForAllTests):
2316         (TestSuite.prototype.exportResultsForTestsNotRun):
2317         (TestSuite.prototype.exportResultsForTestsWithStatus):
2318         (TestSuite.prototype.exportResultsForTestsWithMismatchedResults):
2319
2320 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
2321
2322         No review.
2323
2324         Work around uncertainty about the order of database
2325         transactions when creating the database, so that we don't
2326         try to query the table before it has been created.
2327
2328         * CSSTestSuiteHarness/harness/harness.js:
2329         (TestSuite):
2330         (TestSuite.prototype.databaseCreated):
2331         (TestSuite.prototype.storeTestResult):
2332         (TestSuite.prototype.populateDatabaseFromTestInfoData):
2333         (TestSuite.prototype.queryDatabaseForTestsWithStatus):
2334         (TestSuite.prototype.queryDatabaseForTestsWithMixedStatus):
2335         (TestSuite.prototype.queryDatabaseForCompletedTests):
2336         (TestSuite.prototype.queryDatabaseForTestsNotRun):
2337
2338 2010-09-28  Tony Chang  <tony@chromium.org>
2339
2340         Reviewed by Eric Seidel.
2341
2342         add python keyring support to webkit-patch
2343         https://bugs.webkit.org/show_bug.cgi?id=41269
2344
2345         * Scripts/webkitpy/common/net/credentials.py: Add the ability to read passwords using
2346             the python keyring module
2347         * Scripts/webkitpy/common/net/credentials_unittest.py:
2348         * Scripts/webkitpy/common/system/user.py: Allow confirm() to default to no and add testing params.
2349         * Scripts/webkitpy/common/system/user_unittest.py:
2350         * Scripts/webkitpy/tool/mocktool.py:
2351
2352 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
2353
2354         Reviewed by Gustavo Noronha Silva.
2355
2356         [Cairo] FreeType fonts should obey FontConfig hinting/anti-aliasing settings
2357         https://bugs.webkit.org/show_bug.cgi?id=46740
2358
2359         * DumpRenderTree/gtk/fonts/fonts.conf: Add specialized variants of common
2360         fonts which can be used to fully test FontConfig rendering settings.
2361
2362 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
2363
2364         Reviewed by Gustavo Noronha Silva.
2365
2366         [gtk] Fedora has a different path for the liberation fonts
2367         https://bugs.webkit.org/show_bug.cgi?id=46709
2368
2369         When searching for DRT fonts, also look in the path where those fonts
2370         are commonly found on Fedora systems.
2371
2372         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2373         (initializeFonts): Include logic for looking for Fedora-style font paths.
2374
2375 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
2376
2377         Reviewed by Andreas Kling.
2378
2379         run-webkit-tests needs an updated list of directories with webgl tests
2380         https://bugs.webkit.org/show_bug.cgi?id=46747
2381
2382         Update the list of directories containing WebGL tests and a unit test
2383         which depends on this list.
2384
2385         * Scripts/old-run-webkit-tests: Update the list of directories.
2386         * Scripts/webkitpy/layout_tests/port/webkit.py: Ditto.
2387         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Update the expected result.
2388
2389 2010-09-28  Adam Barth  <abarth@webkit.org>
2390
2391         Reviewed by Eric Seidel.
2392
2393         Introduce FailureMap to summaries the failures status of all the bots
2394         https://bugs.webkit.org/show_bug.cgi?id=46700
2395
2396         This patch gives the SheriffBot a handle on the list of failing tests.
2397
2398         * Scripts/webkitpy/common/net/buildbot.py:
2399         * Scripts/webkitpy/common/net/failuremap.py: Added.
2400         * Scripts/webkitpy/tool/commands/queries.py:
2401         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2402         * Scripts/webkitpy/tool/mocktool.py:
2403
2404 2010-09-28  Adam Roben  <aroben@apple.com>
2405
2406         Update for the addition of WKPageUIClient::didNotHandleKeyEvent
2407
2408         Fixes <http://webkit.org/b/46660> <rdar://problem/8483465> Need API to
2409         tell a WebKit2 client application that a key event was not handled
2410
2411         Reviewed by Kenneth Rohde Christiansen and Sam Weinig.
2412
2413         * MiniBrowser/mac/BrowserWindowController.m:
2414         (-[BrowserWindowController awakeFromNib]):
2415         * MiniBrowser/win/BrowserView.cpp:
2416         (BrowserView::create):
2417         * WebKitTestRunner/TestController.cpp:
2418         (WTR::createOtherPage):
2419         (WTR::TestController::initialize):
2420
2421 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
2422
2423         Unreviewed.
2424
2425         Update the CSSTestSuiteHarness to not scrape the XHTML chapter files
2426         for the test order, but instead use information from testinfo.data.
2427         
2428         * CSSTestSuiteHarness/harness/harness.html:
2429         * CSSTestSuiteHarness/harness/harness.js:
2430
2431 2010-09-28  Kevin Ollivier  <kevino@theolliviers.com>
2432
2433         [wx] Build fix, don't try to get the svn revision from the git repo when packaging,
2434         it causes the process to hang on the gitorious repo.
2435
2436         * wx/packaging/build-mac-installer.py:
2437         * wx/packaging/build-win-installer.py:
2438
2439 2010-09-28  Adam Roben  <aroben@apple.com>
2440
2441         Test that a plugin's HWND is sized/positioned before NPP_SetWindow is
2442         called
2443
2444         Reviewed by Anders Carlsson.
2445
2446         Test for <http://webkit.org/b/46716> <rdar://problem/8482014>
2447         Full-page Adobe Reader does not paint until window is resized
2448
2449         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2450         (PluginTest::NPP_SetWindow): Added. Just returns NPERR_NO_ERROR at
2451         this level.
2452
2453         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Declared
2454         NPP_SetWindow.
2455
2456         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp: Added.
2457         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Checks that
2458         the plugin's HWND has a non-zero size and that its size/position
2459         matches that specified in the NPWindow.
2460
2461         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2462         (NPP_SetWindow): Call through to the PluginTest.
2463
2464         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2465         Added WindowGeometryInitializedBeforeSetWindow.cpp, and let VS reorder
2466         the files as it saw fit.
2467
2468 2010-09-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
2469
2470         Reviewed by Andreas Kling.
2471
2472         [Qt] Remove support for Qt 4.5
2473         https://bugs.webkit.org/show_bug.cgi?id=46718
2474
2475         Remove the code for versions of Qt prior to 4.6.
2476
2477         * DumpRenderTree/qt/EventSenderQt.cpp:
2478         (EventSender::addTouchPoint):
2479         (EventSender::updateTouchPoint):
2480         (EventSender::setTouchModifier):
2481         (EventSender::touchStart):
2482         (EventSender::touchMove):
2483         (EventSender::touchEnd):
2484         (EventSender::clearTouchPoints):
2485         (EventSender::releaseTouchPoint):
2486         (EventSender::sendTouchEvent):
2487         * DumpRenderTree/qt/EventSenderQt.h:
2488         * DumpRenderTree/qt/TextInputControllerQt.cpp:
2489         (TextInputController::setMarkedText):
2490         * QtTestBrowser/launcherwindow.cpp:
2491         (LauncherWindow::LauncherWindow):
2492         (LauncherWindow::initializeView):
2493         (LauncherWindow::createChrome):
2494         (LauncherWindow::sendTouchEvent):
2495         (LauncherWindow::eventFilter):
2496         (LauncherWindow::applyZoom):
2497         (LauncherWindow::setTouchMocking):
2498         * QtTestBrowser/launcherwindow.h:
2499         * QtTestBrowser/utils.cpp:
2500         (urlFromUserInput):
2501         * QtTestBrowser/webview.cpp:
2502         (WebViewGraphicsBased::animatedFlip):
2503         (WebViewGraphicsBased::animatedYFlip):
2504         * QtTestBrowser/webview.h:
2505         (WebViewGraphicsBased::setYRotation):
2506
2507 2010-09-28  İsmail Dönmez  <ismail@namtrac.org>
2508
2509         Reviewed by Andreas Kling.
2510
2511         Fix DRT compilation on WinCE. Introduce a WCECOMPAT variable
2512         which should point to wcecompat installation. Needs wcecompat
2513         library from http://github.com/mauricek/wcecompat .
2514
2515         * DumpRenderTree/qt/DumpRenderTree.pro:
2516         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2517         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2518
2519 2010-09-28  Daniel Bates  <dbates@rim.com>
2520
2521         Rollout changeset 68493 <http://trac.webkit.org/changeset/68493>
2522         <https://bugs.webkit.org/show_bug.cgi?id=39136>
2523
2524         Rollout changeset 68493 because it broke Sheriffbot's rollout feature.
2525         In particular, this change caused Sheriffbot to raise an exception when
2526         trying to parse the bug id on a bug page. We need to look into this
2527         some more.
2528
2529         * Scripts/webkitpy/common/net/bugzilla.py:
2530         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
2531         * Scripts/webkitpy/tool/bot/sheriff.py:
2532         * Scripts/webkitpy/tool/commands/download.py:
2533         * Scripts/webkitpy/tool/commands/queues.py:
2534         * Scripts/webkitpy/tool/commands/upload.py:
2535         * Scripts/webkitpy/tool/steps/closebug.py:
2536         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
2537         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2538         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
2539
2540 2010-09-28  Adam Barth  <abarth@webkit.org>
2541
2542         Reviewed by Eric Seidel.
2543
2544         Move RegressionWindow further up the dependency chain
2545         https://bugs.webkit.org/show_bug.cgi?id=46698
2546
2547         Baby steps towards pushing this information into bug posts.
2548
2549         * Scripts/webkitpy/common/net/buildbot.py:
2550         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2551         * Scripts/webkitpy/common/net/regressionwindow.py:
2552         * Scripts/webkitpy/tool/commands/queries.py:
2553
2554 2010-09-27  Daniel Bates  <dbates@rim.com>
2555
2556         Reviewed by Adam Barth.
2557
2558         sheriffbot can't roll out security patches
2559         https://bugs.webkit.org/show_bug.cgi?id=39136
2560
2561         Make SheriffBot determine if it's authorized to view a bug
2562         whose change it wants to rollout before it tries to rollout
2563         the change.
2564
2565         Moreover, make both webkit-patch and Sheriffbot provide human-
2566         readable error messages when they are not authorized to view
2567         a bug and when a bug number is invalid.
2568
2569         Currently, Sheriffbot does not parse Bugzilla bugs for
2570         <bug error="...">, which indicates an error when retrieving
2571         a bug. In particular, error="NotPermitted" if a person (or bot)
2572         is not authorized to view a bug. For such error="NotPermitted" bugs,
2573         Sheriffbot raises an exception when parsing the bug report and
2574         this exception does not explicitly indicate Sheriffbot's lack
2575         of authorization. Instead, Sheriffbot should explicitly check
2576         for the presence <bug error="..."> before operating on a bug
2577         and error with a human-readable message if it's not permitted
2578         to view it.
2579
2580         * Scripts/webkitpy/common/net/bugzilla.py: Added BugzillaError class.
2581         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
2582           - Added unit test test_bug_parsing_for_bugzilla_not_permitted_error().
2583           - Added unit test test_bug_parsing_for_bugzilla_not_found_error().
2584           - Added unit test test_bug_parsing_for_bugzilla_invalid_bug_id_error().
2585         * Scripts/webkitpy/tool/bot/sheriff.py: Modified to catch BugzillaError.
2586         * Scripts/webkitpy/tool/commands/download.py: Ditto.
2587         * Scripts/webkitpy/tool/commands/queues.py: Ditto.
2588         * Scripts/webkitpy/tool/commands/upload.py: Ditto.
2589         * Scripts/webkitpy/tool/steps/closebug.py: Ditto.
2590         * Scripts/webkitpy/tool/steps/obsoletepatches.py: Ditto.
2591         * Scripts/webkitpy/tool/steps/preparechangelog.py: Ditto.
2592         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: Ditto.
2593
2594 2010-09-27  Adam Barth  <abarth@webkit.org>
2595
2596         Reviewed by Eric Seidel.
2597
2598         Expose more more failure information from Buildbot to SheriffBot
2599         https://bugs.webkit.org/show_bug.cgi?id=46697
2600
2601         This patch moves the information about what tests failured closer to
2602         SheriffBot.  There are still a couple more patches to go before
2603         SheriffBot can post this information to bugs, but this is a step in
2604         that direction.  Yay for unit tests, which caught some bugs in earlier
2605         versions of this patch.
2606
2607         * Scripts/webkitpy/common/net/buildbot.py:
2608         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2609         * Scripts/webkitpy/common/net/regressionwindow.py: Added.
2610         * Scripts/webkitpy/tool/commands/queries.py:
2611
2612 2010-09-27  Eric Seidel  <eric@webkit.org>
2613
2614         Unreviewed.  Fixing 500 error seen in the status server.
2615
2616         It turns out that a = b = []; b.append(1); then a[0] will be 1!
2617         This should have been obvious to me, I guess, but it was not what I was expecting.
2618
2619         * QueueStatusServer/model/activeworkitems.py:
2620
2621 2010-09-27  Adam Barth  <abarth@webkit.org>
2622
2623         Reviewed by Eric Seidel.
2624
2625         commit-queue should reject patches that fail to land
2626         https://bugs.webkit.org/show_bug.cgi?id=46694
2627
2628         This can happen, for example, if there's no reviewer.  Without this
2629         patch, we'll keep retrying the patch.
2630
2631         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2632         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2633
2634 2010-09-27  Simon Fraser  <simon.fraser@apple.com>
2635
2636         Rubber-stamped by Adele Peterson.
2637
2638         Add a harness for running the CSS 2.1 test suite.
2639         
2640         This harness assumes that you've got a local a copy of the suite
2641         adjacent to the 'harness' directory.
2642         
2643         The harness lets you go through the tests in chapter order,
2644         denoting pass/fail/skipped for each test.
2645         
2646         It uses a client-side database to store the results of testing.
2647
2648         * CSSTestSuiteHarness/harness/harness.css: Added.
2649         * CSSTestSuiteHarness/harness/harness.html: Added.
2650         * CSSTestSuiteHarness/harness/harness.js: Added.
2651
2652 2010-09-27  Eric Seidel  <eric@webkit.org>
2653
2654         Reviewed by Adam Barth.
2655
2656         Patch locks should expire if a patch is marked for retry
2657         https://bugs.webkit.org/show_bug.cgi?id=46682
2658
2659         This was part Adam's original CommitQueueTask design,
2660         but support for it was missing from the server.
2661         I added the support, but triggering lock-release based on this
2662         special "retry" status feels a bit strange so I added a FIXME.
2663
2664         I also changed the text in queuestatus.html to say "Lock Acquired"
2665         since "Last Activity" isn't really true.  We only update the lock
2666         date when the patch is started, not on every status update.
2667
2668         I also noticed an exception in next-patch, which I fixed by re-writing
2669         the unzip logic in activeworkitems.py again.
2670
2671         * QueueStatusServer/handlers/updatestatus.py:
2672         * QueueStatusServer/model/activeworkitems.py:
2673         * QueueStatusServer/templates/queuestatus.html:
2674
2675 2010-09-27  Tony Chang  <tony@chromium.org>
2676
2677         Reviewed by David Levin.
2678
2679         [chromium] fix a warning when compiling DRT on 32-bit linux
2680         https://bugs.webkit.org/show_bug.cgi?id=46641
2681
2682         * DumpRenderTree/chromium/TestEventPrinter.cpp:
2683         (DRTPrinter::handleImage):
2684
2685 2010-09-27  Eric Seidel  <eric@webkit.org>
2686
2687         Reviewed by Adam Barth.
2688
2689         queue-status should report when the patch was last locked to a queue
2690         https://bugs.webkit.org/show_bug.cgi?id=46674
2691
2692         This isn't necessarily the best way to expose this information
2693         but having this accessible via the web interface is very
2694         useful until we come up with a nicer way to display this.
2695
2696         I also cleaned up the code in activeworkitems.py a little
2697         to use list comprehensions and to have the code work with
2698         pairs instead of two lists at once.  Eventually I think those
2699         item/time pairs need to be their own little helper class.
2700
2701         * QueueStatusServer/handlers/queuestatus.py:
2702         * QueueStatusServer/model/activeworkitems.py:
2703         * QueueStatusServer/templates/queuestatus.html:
2704
2705 2010-09-27  Tony Chang  <tony@chromium.org>
2706
2707         Reviewed by David Levin.
2708
2709         [chromium] fix detection of missing fonts on DRT
2710         https://bugs.webkit.org/show_bug.cgi?id=46651
2711
2712         * DumpRenderTree/chromium/TestShellGtk.cpp:
2713         (setupFontconfig):  Only print an error message if lohit isn't found in both locations.
2714
2715 2010-09-27  Tony Chang  <tony@chromium.org>
2716
2717         Reviewed by Dimitri Glazkov.
2718
2719         add webkit unit tests to the chromium testers
2720         https://bugs.webkit.org/show_bug.cgi?id=46669
2721
2722         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2723         * Scripts/run-chromium-webkit-unit-tests: Fix a bug where we weren't using the right configuration.
2724
2725 2010-09-27  Kwang Yul Seo  <skyul@company100.net>
2726
2727         Unreviewed.
2728
2729         Adding myself to the committers list.
2730
2731         * Scripts/webkitpy/common/config/committers.py:
2732
2733 2010-09-27  Mihai Parparita  <mihaip@chromium.org>
2734
2735         Reviewed by Eric Seidel.
2736
2737         webkitpy.common.system.user_unittest.UserTest.test_prompt_with_list spams the console
2738         https://bugs.webkit.org/show_bug.cgi?id=46634
2739         
2740         Use OutputCapture to prevent console spam (and also check for expected
2741         output).
2742
2743         * Scripts/webkitpy/common/system/user_unittest.py:
2744
2745 2010-09-27  Eric Seidel  <eric@webkit.org>
2746
2747         Reviewed by James Robinson.
2748
2749         start-commit-queue should abort any rebases in progress
2750         https://bugs.webkit.org/show_bug.cgi?id=46640
2751
2752         webkit-patch commit-queue would do this itself, but this just
2753         helps ensure that the commit-queue script is properly updated
2754         before we run it (in the case where a previous rebase is in
2755         progress the git svn rebase would not work before we run the
2756         commit-queue).
2757
2758         * EWSTools/start-commit-queue.sh:
2759
2760 2010-09-18  Martin Robinson  <mrobinson@igalia.com>
2761
2762         Reviewed by Gustavo Noronha Silva.
2763
2764         [GTK] Clean up the DRT fonts.conf and switch to Liberation
2765         https://bugs.webkit.org/show_bug.cgi?id=46038
2766
2767         Switch to Liberation fonts for GTK+ layout tests. This will make our
2768         test results metric-compatible with many Windows/Chromium results. It
2769         also simplifies the fonts.conf that we load and prepares the way for
2770         fixing many font bugs.
2771
2772         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2773         (initializeFonts): Initialize a known list of fonts instead of loading
2774         every font in the WEBKIT_TESTFONTS directory.
2775         * DumpRenderTree/gtk/fonts.conf: Removed.
2776         * DumpRenderTree/gtk/fonts/AHEM____.TTF: Copied from WebKitTools/DumpRenderTree/qt/fonts/AHEM____.TTF.
2777         * DumpRenderTree/gtk/fonts/fonts.conf: Added.
2778         * GNUmakefile.am: Modify FONTS_CONF_FILE to be FONTS_CONF_DIR, so that
2779         we can load both fonts.conf and AHEM____.TTF from this location.
2780         * Scripts/old-run-webkit-tests: Remove the check for WEBKIT_TESTFONTS, since
2781         it is no longer used.
2782
2783 2010-09-26  Mihai Parparita  <mihaip@chromium.org>
2784
2785         Reviewed by Ojan Vafai.
2786
2787         new-run-webkit-httpd fails if Perl is not installed
2788         https://bugs.webkit.org/show_bug.cgi?id=46602
2789         
2790         Make Port._read_configuration catch all exceptions, since trying to run
2791         perl (because of _webkit_build_directory) when it's not installed throws
2792         a WindowsError or OSError, not an IOError (this became an issue after 
2793         r68268, since ChromiumPort ends up calling Port.default_configuration in
2794         its constructor, which means that we're ending up on this codepath in
2795         non-NRWT cases too, e.g. for the Chromium NaCl tests, which use
2796         new-run-webkit-httpd).
2797
2798         * Scripts/webkitpy/layout_tests/port/base.py:
2799         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2800
2801 2010-09-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2802
2803         Reviewed by Antonio Gomes.
2804
2805         [EFL] Add setting API to set a local storage database path.
2806         https://bugs.webkit.org/show_bug.cgi?id=45446
2807
2808         Add a setting API to set local storage database path.
2809
2810         * EWebLauncher/main.c:
2811         (on_key_down):
2812         (browserCreate):
2813         (main):
2814
2815 2010-09-26  Sam Weinig  <sam@webkit.org>
2816
2817         Reviewed by Anders Carlsson.
2818
2819         Move shared WebKit2 API (used by both bundle and main API) to WebKit2/Shared/API
2820         https://bugs.webkit.org/show_bug.cgi?id=46587
2821
2822         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2823
2824 2010-09-26  Antonio Gomes  <agomes@rim.com>
2825
2826         Reviewed by Kenneth Rohde Christiansen.
2827
2828         DRT/Mac nodesFromRect support
2829
2830         [Mac][DRT] Implement LayoutTestController::nodesFromRect
2831         https://bugs.webkit.org/show_bug.cgi?id=46580
2832
2833         Implements LayoutTestController::nodesFromRect for Mac DRT, and
2834         adding stubs for GTK+ and Windows.
2835
2836         * DumpRenderTree/LayoutTestController.cpp:
2837         (nodesFromRectCallback):
2838         (LayoutTestController::staticFunctions):
2839         * DumpRenderTree/LayoutTestController.h:
2840         (LayoutTestController::LayoutTestController::nodesFromRect):
2841         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2842         (LayoutTestController::nodesFromRect):
2843
2844 2010-09-25  Nicolas Weber  <thakis@chromium.org>
2845
2846         Reviewed by Adam Barth.
2847
2848         https://bugs.webkit.org/show_bug.cgi?id=46555
2849         Fix typo in prepare-ChangeLog's help output.
2850
2851         * Scripts/prepare-ChangeLog:
2852
2853 2010-09-24  Sam Weinig  <sam@webkit.org>
2854
2855         Reviewed by Darin Adler.
2856
2857         Implement WebKit2 callback equivalent to -[WebUIDelegate mouseDidMoveOverElement:modifierFlags:]
2858         <rdar://problem/8359279>
2859         https://bugs.webkit.org/show_bug.cgi?id=46546
2860
2861         * MiniBrowser/mac/BrowserWindowController.m:
2862         (mouseDidMoveOverElement):
2863         (-[BrowserWindowController awakeFromNib]):
2864         * MiniBrowser/win/BrowserView.cpp:
2865         (mouseDidMoveOverElement):
2866         (BrowserView::create):
2867         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2868         (WTR::InjectedBundlePage::InjectedBundlePage):
2869         * WebKitTestRunner/TestController.cpp:
2870         (WTR::createOtherPage):
2871         (WTR::TestController::initialize):
2872
2873 2010-09-24  Mihai Parparita  <mihaip@chromium.org>
2874
2875         Reviewed by Adam Barth.
2876
2877         Allow rebaselines for webkit-patch rebaseline to be chosen
2878         https://bugs.webkit.org/show_bug.cgi?id=46407
2879         
2880         Instead of always rebaselining all failing tests, allow a subset to be
2881         chosen.
2882
2883         * Scripts/webkitpy/common/system/user.py:
2884         * Scripts/webkitpy/tool/commands/rebaseline.py:
2885
2886 2010-09-24  Ryosuke Niwa  <rniwa@webkit.org>
2887
2888         Reviewed by Tony Chang.
2889
2890         [chromium] Implement TextInputController::firstRectForCharacterRange
2891         https://bugs.webkit.org/show_bug.cgi?id=38100
2892
2893         Implemented TextInputController::firstRectForCharacterRange for chromium platform.
2894         No new tests are added since we need to implement the same feature in chromium side
2895         in order to enable any tests that uses this function.
2896
2897         * DumpRenderTree/chromium/TextInputController.cpp:
2898         (TextInputController::firstRectForCharacterRange): Added.
2899
2900 2010-09-24  Adam Barth  <abarth@webkit.org>
2901
2902         Reviewed by Eric Seidel.
2903
2904         commit-queue reports land failures as "PASS"
2905         https://bugs.webkit.org/show_bug.cgi?id=46530
2906
2907         We were ignoring the return value of land instead of passing it back to
2908         CommitQueue.  Of course, this was the one case I forgot to test!
2909
2910         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2911         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2912
2913 2010-09-24  Kenichi Ishibashi  <bashi@google.com>
2914
2915         Reviewed by Eric Seidel.
2916
2917         new-run-webkit-tests prints out nothing when build-dumprendertree fails
2918         https://bugs.webkit.org/show_bug.cgi?id=37563
2919
2920         Print error message when build-dumprendertree fails.
2921
2922         * Scripts/webkitpy/layout_tests/port/webkit.py:
2923         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2924
2925 2010-09-24  Mihai Parparita  <mihaip@chromium.org>
2926
2927         Reviewed by Tony Chang.
2928
2929         NRWT doesn't respect config set with set-webkit-configuration
2930         https://bugs.webkit.org/show_bug.cgi?id=46278
2931         
2932         Use Port.default_configuration() instead of hardcoding Release in
2933         ChromiumPort configuration initialization, so that we still inherit the
2934         configuration set by set-webkit-configuration.
2935
2936         * Scripts/webkitpy/layout_tests/port/chromium.py:
2937         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2938
2939 2010-09-24  Chang Shu  <chang.shu@nokia.com>
2940
2941         Reviewed by Csaba Osztrogonác.
2942
2943         [Qt] Fix the code to check file existence.
2944         https://bugs.webkit.org/show_bug.cgi?id=46465
2945
2946         * QtTestBrowser/main.cpp:
2947         (main):
2948
2949 2010-09-23  Tony Chang  <tony@chromium.org>
2950
2951         Unreviewed, rolling out r68232.
2952         http://trac.webkit.org/changeset/68232
2953
2954         Broken NRWT on the canary bots.
2955
2956         * Scripts/webkitpy/layout_tests/port/chromium.py:
2957
2958 2010-09-23  Dirk Pranke  <dpranke@chromium.org>
2959
2960         Unreviewed, build fix.
2961
2962         r68008 broke new-run-webkit-tests in that the chromium ports no
2963         longer respect set-webkit-configuration. The correct fix for this
2964         is being pursued in bug 46278 (along with a bunch of unit tests),
2965         but in the meantime I'm reverting the particular lines that broke
2966         things. This was tested by hand.
2967
2968         * Scripts/webkitpy/layout_tests/port/chromium.py:
2969
2970 2010-09-23  Sam Weinig  <sam@webkit.org>
2971
2972         Reviewed by Anders Carlsson.
2973
2974         WebKit2 API: Need way to know when a frame is removed from the hierarchy
2975         <rdar://problem/8414062>
2976         https://bugs.webkit.org/show_bug.cgi?id=46432
2977
2978         * MiniBrowser/mac/BrowserWindowController.m:
2979         (didRemoveFrameFromHierarchy):
2980         (-[BrowserWindowController awakeFromNib]):
2981         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2982         (WTR::InjectedBundlePage::InjectedBundlePage):
2983         * WebKitTestRunner/TestController.cpp:
2984         (WTR::TestController::initialize):
2985
2986 2010-09-23  Tony Chang  <tony@chromium.org>
2987
2988         Reviewed by Dimitri Glazkov.
2989
2990         [chromium] implement layoutTestController.sampleSVGAnimationForElementAtTime
2991         https://bugs.webkit.org/show_bug.cgi?id=46426
2992
2993         * DumpRenderTree/chromium/LayoutTestController.cpp:
2994         (LayoutTestController::LayoutTestController):
2995         (LayoutTestController::sampleSVGAnimationForElementAtTime):
2996         * DumpRenderTree/chromium/LayoutTestController.h:
2997
2998 2010-09-23  Martin Robinson  <mrobinson@igalia.com>
2999
3000         Reviewed by Nate Chapin.
3001
3002         [GTK] r68199 introduced two test failures
3003         https://bugs.webkit.org/show_bug.cgi?id=46424
3004
3005         Fix a regression handling preference overrides that are attached to boolean properties.
3006
3007         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3008         (LayoutTestController::overridePreference): g_strcasecmp returns 0 when strings match
3009         so we must check for that when converting a string to a boolean.
3010
3011 2010-09-23  Dimitri Glazkov  <dglazkov@chromium.org>
3012
3013         Reviewed by David Levin.
3014
3015         Fix a condition check in ServerProcess, which becomes relevant when reading binary data.
3016         https://bugs.webkit.org/show_bug.cgi?id=46406
3017
3018         This breaks when the method is called with specified size of data (image data), and the
3019         buffer hasn't yet reached this size.
3020
3021         * Scripts/webkitpy/layout_tests/port/server_process.py: Changed to check for values of
3022           index larger than 0.
3023
3024 2010-09-23  Martin Robinson  <mrobinson@igalia.com>
3025
3026         Reviewed by Nate Chapin.
3027
3028         [GTK] Some tests from r68174 fail on the GTK+ bots
3029         https://bugs.webkit.org/show_bug.cgi?id=46396
3030
3031         Simplify LayoutTestController::overridePreference to make it easier for
3032         people unfamiliar with the code to keep the list of preferences up to date.
3033         Add the conversion for enable-hyperlink-auditing.
3034
3035         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3036         (LayoutTestController::overridePreference): Use a simple if-else block to determine
3037         out the property name for overrridePreference. Also simplify the logic for setting
3038         string properties. Add the conversion for enable-hyperlink-auditing.
3039
3040 2010-09-23  Tony Chang  <tony@chromium.org>
3041
3042         Reviewed by David Levin.
3043
3044         [chromium] add caretBrowsingEnabled to WebSettings and DRT
3045         https://bugs.webkit.org/show_bug.cgi?id=46388
3046
3047         * DumpRenderTree/chromium/LayoutTestController.cpp:
3048         (LayoutTestController::overridePreference):
3049         * DumpRenderTree/chromium/WebPreferences.cpp:
3050         (WebPreferences::reset):
3051         (WebPreferences::applyTo):
3052         * DumpRenderTree/chromium/WebPreferences.h:
3053
3054 2010-09-23  Nate Chapin  <japhet@chromium.org>
3055
3056         Reviewed by Darin Fisher.
3057
3058         Allow DRT to toggle hyperlink auditing (i.e., <a ping>).
3059         https://bugs.webkit.org/show_bug.cgi?id=30458
3060
3061         * DumpRenderTree/chromium/LayoutTestController.cpp:
3062         (LayoutTestController::overridePreference):
3063         * DumpRenderTree/chromium/WebPreferences.cpp:
3064         (WebPreferences::reset):
3065         (WebPreferences::applyTo):
3066         * DumpRenderTree/chromium/WebPreferences.h:
3067         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3068         (resetDefaultsToConsistentValues):
3069         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3070         (LayoutTestController::overridePreference):
3071
3072 2010-09-21  Stephen White  <senorblanco@chromium.org>
3073
3074         Reviewed by David Levin.
3075
3076         Implement --enable-accelerated-2d-canvas flag in DumpRenderTree.
3077         https://bugs.webkit.org/show_bug.cgi?id=46208
3078
3079         This flag allows the layout tests to be run with or without accelerated
3080         2D canvas rendering.
3081
3082         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3083         (main):
3084         Declare the new flag string, and check for it on startup.
3085         * DumpRenderTree/chromium/TestShell.cpp:
3086         (TestShell::TestShell):
3087         Add a boolean for the new flag, in order to preserve its value over
3088         preferences reset.
3089         (TestShell::resetWebSettings):
3090         Set the new flag to the stored value on reset.
3091         * DumpRenderTree/chromium/TestShell.h:
3092         (TestShell::setAccelerated2dCanvasEnabled):
3093         Add an accessor for the new flag.
3094         * DumpRenderTree/chromium/WebPreferences.cpp:
3095         (WebPreferences::reset):
3096         Initialize the new flag to false.
3097         (WebPreferences::applyTo):
3098         Copy the flag's value to the WebSettings.
3099         * DumpRenderTree/chromium/WebPreferences.h:
3100         Add the new flag.
3101
3102 2010-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3103
3104         Reviewed by Simon Hausmann.
3105
3106         [Qt] Refactor QtWebKitPlatformPlugin interface
3107
3108         Make it easier to keep source-compability for the
3109         QtWebKitPlatformPlugin interface, and run qmake
3110         on the example (but not build) for convenience. 
3111
3112         https://bugs.webkit.org/show_bug.cgi?id=46345
3113
3114         * Scripts/webkitdirs.pm:
3115
3116 2010-09-23  Adam Barth  <abarth@webkit.org>
3117
3118         Reviewed by Eric Seidel.
3119
3120         Tweak some status messages that Eric thought were confusing
3121         https://bugs.webkit.org/show_bug.cgi?id=46342
3122
3123         * Scripts/webkitpy/tool/commands/queues.py:
3124         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3125
3126 2010-09-22  Adam Barth  <abarth@webkit.org>
3127
3128         Reviewed by Eric Seidel.
3129
3130         Fix comm-queue typo
3131         https://bugs.webkit.org/show_bug.cgi?id=46339
3132
3133         We were missing a "self".  The real problem is that we didn't have an
3134         integration test for the failure case.
3135
3136         * Scripts/webkitpy/tool/commands/queues.py:
3137         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3138
3139 2010-09-22  Adam Barth  <abarth@webkit.org>
3140
3141         Reviewed by Eric Seidel.
3142
3143         commit-queue should log more detailed messages to the QueueStatusServer
3144         https://bugs.webkit.org/show_bug.cgi?id=46333
3145
3146         When I created CommitQueueTask, I removed most of the previous logging.
3147         This patch adds back more detailed logging so folks can see their patch
3148         progress through the queue.
3149
3150         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3151         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3152         * Scripts/webkitpy/tool/commands/queues.py:
3153         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3154
3155 2010-09-22  Mihai Parparita  <mihaip@chromium.org>
3156
3157         Reviewed by Darin Fisher.
3158
3159         [Chromium] User style layout tests don't pass on Chromium
3160         https://bugs.webkit.org/show_bug.cgi?id=46069
3161
3162         Fix a typo in LayoutTestController::addUserStyleSheet that was causing a
3163         crash the Chromium DRT. Pass InjectInExistingDocuments to mimic DRT
3164         behavior from other ports.
3165
3166         * DumpRenderTree/chromium/LayoutTestController.cpp:
3167         (LayoutTestController::addUserStyleSheet):
3168
3169 2010-09-22  Brent Fulgham  <bfulgham@webkit.org>
3170
3171         Reviewed by Martin Robinson.
3172
3173         [WinCairo] Part 2: Update WebKitTestRunner and DumpRenderTree Build.
3174         https://bugs.webkit.org/show_bug.cgi?id=46303.
3175
3176         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added.
3177         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Moved
3178         CoreFoundation-specific stuff to new MiniBrowserCoreFoundation
3179         property sheet.
3180         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added.
3181         * MiniBrowser/MiniBrowser.vcproj: Updated configuration to use
3182         appropriate property sheet for the build types.
3183         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Updated the
3184         configuration to use appropriate property sheet for CoreFoundation
3185         and CFLite-style builds.
3186
3187 2010-09-22  Adam Barth  <abarth@webkit.org>
3188
3189         Reviewed by Eric Seidel.
3190
3191         Optimize commit-queue performance for green trees
3192         https://bugs.webkit.org/show_bug.cgi?id=46254
3193
3194         This patch redesigns the controller logic for the commit-queue.  In the
3195         new design, the controller exercises much finer-grained control over
3196         the landing process.  In particular:
3197
3198         - Patches that fail to apply now get rejected almost immediately.
3199         - Patches that fail to build get rejects after two builds (instead of
3200           three builds and one test run).
3201         - Patches that run into a flaky test now get accepted after one build
3202           and two test runs instead of three full build-and-test runs.
3203
3204         The main cost of these optimizations is that we don't find out the tree
3205         has a failing test until the very end of the process, but if the tree
3206         has a busted test, there's not much we can do anyway.  We might as well
3207         burn commit-queue resources spinning optimisticly.
3208
3209         * Scripts/webkitpy/tool/bot/commitqueuetask.py: Added.
3210         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: Added.
3211         * Scripts/webkitpy/tool/commands/queues.py:
3212
3213 2010-09-22  Brent Fulgham  <bfulgham@webkit.org>
3214
3215         Reviewed by Martin Robinson.
3216
3217         [WinCairo] Update WebKitTestRunner and DumpRenderTree Build.
3218         https://bugs.webkit.org/show_bug.cgi?id=46303.
3219
3220         * DumpRenderTree/win/DumpRenderTree.vcproj: Disable local MD5 sources
3221         for Cairo build. Copy wtf MD5 header to ForwardingHeaders for the
3222         WinCairo build.
3223         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added.
3224         * WebKitTestRunner/win/InjectedBundle.vcproj: Update win new *_Cairo
3225         build targets that use the new InjectedBundleCFLite.vsprops file.
3226
3227 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
3228
3229         Unreviewed, build fix.
3230
3231         Fix bustage of rebaseline-chromium-webkit-tests resulting from
3232         r67974. Really need better unit tests for this tool :(
3233
3234         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3235
3236 2010-09-22  Adam Roben  <aroben@apple.com>
3237
3238         Unbreak test-webkitpy
3239
3240         * Scripts/webkitpy/test/main.py:
3241         (Tester.run_tests): Add a line that mysteriously got deleted.
3242
3243 2010-09-22  Adam Roben  <aroben@apple.com>
3244
3245         Make test-webkitpy test WebKit2's scripts
3246
3247         These scripts can't be in WebKitTools due to limitations of Apple's
3248         build process. But that doesn't mean we can't test them!
3249
3250         Fixes <http://webkit.org/b/46297> test-webkitpy should test code in
3251         WebKit2/Scripts
3252
3253         Reviewed by Adam Barth.
3254
3255         * Scripts/test-webkitpy:
3256         (_clean_packages_with_test): Renamed from _clean_webkitpy_with_test.
3257         Now takes an external_package_paths parameter and cleans both webkitpy
3258         and any external packages.
3259         (init): Added an external_package_paths parameter which we pass along
3260         to _clean_packages_with_test.
3261         (top level): Add WebKit2/Scripts/webkit2 as our only external package
3262         and pass it along to init and Tester.run_tests.
3263
3264         * Scripts/webkitpy/test/main.py:
3265         (Tester.run_tests): Added an optional external_package_paths
3266         parameter. We modify sys.path so that the external packages can be
3267         imported, and search for unittest files inside all external packages
3268         in addition to inside webkitpy.
3269
3270 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
3271
3272         Reviewed by Tony Chang.
3273
3274         new-run-webkit-tests: r68063 broke linux python tests
3275
3276         Add a missing "from __future__ import with_statement" to this
3277         new file; the perils of testing only on the Mac and by review :(
3278
3279         https://bugs.webkit.org/show_bug.cgi?id=46293
3280
3281         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3282
3283 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
3284
3285         Reviewed by Tony Chang.
3286
3287         Add a 'chromium-gpu' set of ports that will test the accelerated
3288         GPU paths. This patch adds:
3289
3290         - support for the '--accelerated-compositing' and
3291           'accelerated-2d-canvas' flags to new-run-webkit-tests (and the
3292           'no-' flags)
3293         - adds a new set of Ports that will look under
3294           platform/chromium-gpu-$OS/ for baselines before looking in the
3295           regular chromium search path
3296         - adds a new test_expectations.txt file in platform/chromium-gpu
3297           that skips all but the tests we actually want to run with
3298           acceleration.
3299
3300         This patch will allow us to run both with and without acceleration
3301         and to change the defaults for both the regular and -gpu options
3302         as the code evolves.
3303
3304         We plan to add both --chromium-$OS and --chromium-gpu-$OS runs to
3305         each test bot.
3306
3307         https://bugs.webkit.org/show_bug.cgi?id=46225
3308
3309         * Scripts/webkitpy/layout_tests/port/chromium.py:
3310         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3311         * Scripts/webkitpy/layout_tests/port/factory.py:
3312         * Scripts/webkitpy/layout_tests/port/webkit.py:
3313
3314 2010-09-22  Jamey Hicks  <jamey.hicks@nokia.com>
3315
3316         Reviewed by Kenneth Rohde Christiansen.
3317
3318         [Qt] Web Inspector: Remote Web Inspector support for QtWebKit
3319         https://bugs.webkit.org/show_bug.cgi?id=43988
3320
3321         Runs a web debug server on port specified by QtTestBrowser
3322         argument -remote-inspector-port. Property
3323         _q_webInspectorServerPort of the QWebPage instance will be set
3324         according to the argument. All pages with that property set will
3325         be remotely inspectable.
3326
3327         URL for remote inspection of first QWebPage is
3328             http://localhost:9222/webkit/inspector/inspector.html?page=1
3329         where 1 is the number of the QWebPage instance.
3330
3331         The base URL yields an index page with links to the individual inspectors:
3332             http://localhost:9222/
3333
3334         * QtTestBrowser/launcherwindow.cpp:
3335         (LauncherWindow::init):
3336         * QtTestBrowser/launcherwindow.h:
3337         * QtTestBrowser/main.cpp:
3338         (LauncherApplication::handleUserOptions):
3339
3340 2010-09-22  Adam Roben  <aroben@apple.com>
3341
3342         Fix webkit-patch failure-reason now that build.webkit.org has been
3343         updated
3344
3345         Fixes <http://webkit.org/b/46273> webkit-patch failure-reason crashes
3346         every time
3347
3348         Reviewed by Eric Seidel.
3349
3350         * Scripts/webkitpy/common/net/buildbot.py:
3351         (BuildBot._file_cell_text): Added. Travels down the firstChild chain
3352         looking for an element that contains text, then returns it.
3353         (BuildBot._parse_twisted_file_row): Use _file_cell_text to get the
3354         text out of the cells. This way it doesn't matter whether the cells
3355         have <b> children (as for cells in directory rows) or not (as for
3356         cells in file rows)
3357         (BuildBot._parse_twisted_directory_listing): Look for rows that have
3358         the "directory" or "file" class, rather than rows with any class,
3359         since header rows now have a class attribute.
3360
3361         * Scripts/webkitpy/common/net/buildbot_unittest.py:
3362         (BuildBotTest._example_directory_listing): Updated to more closely
3363         match the markup that build.webkit.org is producing now.
3364
3365 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
3366
3367         Unreviewed, build fix.
3368
3369         new-run-webkit-tests: fix bug introduced in r68008 where if you
3370         specify --chromium and no --platform, and you're running on
3371         windows, you use the 'chromium-win' port by default instead of the
3372         version-specific port. This breaks the buildbots.
3373
3374         It will be good for this refactoring to settle down so I can
3375         rewrite the logic for default ports and the unit tests to be
3376         clearer (and the testing more comprehensive).
3377
3378         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3379
3380 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
3381
3382         Reviewed by Adam Barth.
3383
3384         Modify the Port interface to take only a series of keyword arguments
3385         in the constructor, and modify Port/factory.get() to accomodate that,
3386         and to accept user=XXX as an argument so we can pass
3387         webkitpy.common.system.user.User objects in.
3388
3389         Then, modify new-run-webkit-tests and rebaseline-chromium-webkit-tests
3390         to use the common routine in webkitpy.common.system.user.open_url()
3391         to display HTML files.
3392
3393         There was a routine in the Port interface to do the same thing,
3394         but I see no need for a port-specific hook for this, since it is
3395         something that will always be executed by the host environment
3396         and displaying web pages has nothing to do with running layout tests.
3397
3398         Note that new-run-webkit-tests used to use test_shell to display
3399         the page; this is potentially useful so that you can actually click
3400         from a result to the broken page; however, since DumpRenderTree
3401         doesn't support this functionality, it will be going away eventually.
3402
3403         https://bugs.webkit.org/show_bug.cgi?id=46128
3404
3405         * Scripts/webkitpy/layout_tests/port/base.py:
3406         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3407         * Scripts/webkitpy/layout_tests/port/chromium.py:
3408         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3409         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3410         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3411         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3412         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3413         * Scripts/webkitpy/layout_tests/port/factory.py:
3414         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3415         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3416         * Scripts/webkitpy/layout_tests/port/gtk.py:
3417         * Scripts/webkitpy/layout_tests/port/mac.py:
3418         * Scripts/webkitpy/layout_tests/port/qt.py:
3419         * Scripts/webkitpy/layout_tests/port/test.py:
3420         * Scripts/webkitpy/layout_tests/port/webkit.py:
3421         * Scripts/webkitpy/layout_tests/port/win.py:
3422         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3423         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3424         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3425
3426 2010-09-21  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3427
3428         Reviewed by Kenneth Rohde Christiansen.
3429
3430         [EFL] Get fresh theme when running EWebLauncher
3431         https://bugs.webkit.org/show_bug.cgi?id=46210
3432
3433         If user tried to run EWebLauncher outside of the build tree, it would
3434         not find the theme and fallback to the installed one. However, since
3435         EWebLauncher is not installed, we always want to take the theme from
3436         the just compiled source code. If user had never installed WebKit's
3437         EFL port it could even receive a segv since no theme would be found.
3438
3439         Now EWebLauncher does not fallback to the installed theme and CMake
3440         gives as DATA_DIR the directory of the theme it has just built.
3441
3442         * CMakeListsEfl.txt: Pass the build directory as DATA_DIR to
3443         EWebLauncher.
3444         * EWebLauncher/main.c: Use only the theme from build director. Do not
3445         fallback to others as this could hide real bugs.
3446         (quit):
3447         (browserCreate):
3448         (findThemePath):
3449         (main):
3450
3451 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
3452
3453         Unreviewed, build fix.
3454
3455         Don't pass the --test-shell arg to the Chromium Mac port of DRT;
3456         it just confuses it.
3457
3458         https://bugs.webkit.org/show_bug.cgi?id=46230
3459
3460         * Scripts/webkitpy/layout_tests/port/webkit.py:
3461
3462 2010-09-21  Lucas Forschler  <lforschler@apple.com>
3463
3464         Reviewed by Stephanie Lewis.
3465
3466         Make a new buildbot for Leopard Debug Test
3467
3468         * BuildSlaveSupport/build.webkit.org-config/config.json:
3469
3470 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
3471
3472         Unreviewed, build fix.
3473
3474         Fix breakage of Chromium Mac DRT port caused by r67905.
3475
3476         https://bugs.webkit.org/show_bug.cgi?id=46230
3477
3478         * Scripts/webkitpy/layout_tests/port/webkit.py:
3479
3480 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
3481
3482         Unreviewed, build fix.
3483
3484         Add missing import of 'tempfile'.
3485
3486         * Scripts/webkitpy/layout_tests/port/chromium.py:
3487
3488 2010-09-17  Dirk Pranke  <dpranke@chromium.org>
3489
3490         Reviewed by Ojan Vafai.
3491
3492         new-run-webkit-tests: pull the list of tests from the Port, and
3493            make it possible to run with no actual test files in the filesystem.
3494
3495         This set of changes allows us to delete the special
3496         webkitpy/layout_tests/data directory and test the generic code without
3497         touching the filesystem (except to write results). This speeds up
3498         test-webkitpy substantially.
3499
3500         This also cleans up and removes several code paths in the generic
3501         code and fixes some minor bugs, notably in the test_expectations
3502         parsing, which was previously fragile if the tests weren't present.
3503
3504         We also change the way we diff image results to be able to do so
3505         in memory, without relying on files. This slows down chromium
3506         test_shell, which always writes images to files, but should speed
3507         up DRT and ImageDiff-based implementations slightly.
3508
3509         Note that pulling the list of tests to run from the Port will allow
3510         ports to specify what tests to run as an inclusive list; previously
3511         you could only do this as an exclusive list by using a 
3512         test_expectations file or Skipped files; nothing actually uses this
3513         feature yet and it's unclear if it should be used.
3514
3515         Note that there are no functional changes -- apart from now 
3516         always printing out the location of the checksum file when we are
3517         tracing test runs -- and the total number of lines of non-test code
3518         actually drops by two.
3519
3520         There is some more cleanup that can be done in the Port/Driver 
3521         interface and in some handling of filenames, but I'll save that
3522         for another change.
3523
3524         https://bugs.webkit.org/show_bug.cgi?id=45801
3525
3526         * Scripts/webkitpy/layout_tests/data/*: Removed.
3527             - no longer need special mock layout_tests_directory in the
3528               repository.
3529         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3530             - add code to display missing text files, checksums when tracing
3531             - update to not look at the filesystem directly.
3532         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3533             - add more unit tests
3534         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3535             - remove tests_are_present flag
3536             - update with changes in Port interface - no longer access
3537               the filesystem directly, although we still use os.path for
3538               filename manipulation.
3539         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3540             - add more unit tests
3541         * Scripts/webkitpy/layout_tests/layout_package/test_files.py: Removed.
3542             - renamed to port/test_files.py
3543         * Scripts/webkitpy/layout_tests/port/base.py:
3544             - change diff_image() to expect actual image data, not filenames
3545             - add expected_checksum(), expected_image(), expected_text() to
3546               return the content of the files so that we don't need a filesystem
3547             - add path_exists(), path_isdir() for filesystem-like access.
3548             - add test_dirs() to keep clobber-test-results from needing to
3549               actually look at a real layout tests dir
3550             - add tests() to return the list of tests to run on the port
3551               (calls port/test_files to do the work).
3552             - add update_baseline() to be able to save new baselines
3553             - add uri_to_test_name() from port/dryrun.py so we can easily check
3554               filename_to_uri()
3555         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3556             - add more unit tests
3557         * Scripts/webkitpy/layout_tests/port/chromium.py:
3558             - change diff_image() to accept image content, not filenames.
3559               This will be slower for test_shell/image_diff, but faster
3560               for DRT/ImageDiff.
3561         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3562             - add more unit tests
3563         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3564             - simplify greatly
3565         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3566             - add more unit tests
3567         * Scripts/webkitpy/layout_tests/port/test.py:
3568             - massive rewrite to use in-script list of tests and expectations
3569         * Scripts/webkitpy/layout_tests/port/test_files.py:
3570             - rename from layout_package/test_files.
3571         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
3572             - add unit tests
3573         * Scripts/webkitpy/layout_tests/port/webkit.py:
3574             - update diff_image() to take image contents, not files. Should
3575               make things slightly faster.
3576         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3577             - update with changes to diff_image()
3578         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
3579             - update with changes to diff_image()
3580         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3581             - remove tests_are_present from test_expectations
3582             - pull the list of tests from port.tests() instead
3583               of calling test_files.py directly.
3584         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3585             - update unit tests
3586         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
3587             - update with changes to 
3588         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
3589             - update with change in Port&nb