2009-12-18 Fumitoshi Ukai <ukai@chromium.org>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-12-18  Fumitoshi Ukai  <ukai@chromium.org>
2
3         Reviewed by David Levin.
4
5         Check one space before end of line comments.
6         https://bugs.webkit.org/show_bug.cgi?id=32597
7         
8         Fix to check one space before end of line comments in whitespace and build/header_guard.
9         Also fix build/header_guard to use WebKit header guard defines.
10
11         * Scripts/modules/cpp_style.py:
12         * Scripts/modules/cpp_style_unittest.py:
13
14 2009-12-17  Sam Weinig  <sam@webkit.org>
15
16         Reviewed by Mark Rowe.
17
18         Add BUILDING_ON_SNOW_LEOPARD #define.
19
20         * DumpRenderTree/mac/DumpRenderTreeMac.h:
21
22 2009-12-17  Yuzo Fujishima  <yuzo@google.com>
23
24         Reviewed by Alexey Proskuryakov.
25
26         Update pywebsocket to 0.4.5 and make handshake checking stricter
27         https://bugs.webkit.org/show_bug.cgi?id=32249
28
29         * Scripts/run-webkit-tests:
30         * pywebsocket/mod_pywebsocket/handshake.py:
31         * pywebsocket/mod_pywebsocket/memorizingfile.py: Added.
32         * pywebsocket/mod_pywebsocket/standalone.py:
33         * pywebsocket/setup.py:
34         * pywebsocket/test/test_handshake.py:
35         * pywebsocket/test/test_memorizingfile.py: Added.
36
37 2009-12-17  Eric Seidel  <eric@webkit.org>
38
39         Reviewed by Adam Barth.
40
41         Command.show_in_main_help should default to False
42         https://bugs.webkit.org/show_bug.cgi?id=32686
43
44         * Scripts/modules/commands/download.py:
45         * Scripts/modules/commands/queries.py:
46         * Scripts/modules/commands/queues.py:
47         * Scripts/modules/commands/upload.py:
48         * Scripts/modules/multicommandtool.py:
49
50 2009-12-17  Alejandro G. Castro  <alex@igalia.com>
51
52         Reviewed by Eric Seidel.
53
54         Added the key WebKitEnableCaretBrowsing to the
55         layoutTestController.overridePreference in order to activate caret
56         browsing.
57         https://bugs.webkit.org/show_bug.cgi?id=32612
58
59         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added the reset value of
60         the setting.
61         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Inserted the new
62         key in the keytable.
63
64 2009-12-17  Chris Fleizach  <cfleizach@apple.com>
65
66         Reviewed by David Kilzer.
67
68         AX: DRT needs to support URL for accessibility
69         https://bugs.webkit.org/show_bug.cgi?id=32666
70
71         * DumpRenderTree/AccessibilityUIElement.cpp:
72         (getURLCallback):
73         (AccessibilityUIElement::getJSClass):
74         * DumpRenderTree/AccessibilityUIElement.h:
75         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
76         (AccessibilityUIElement::url):
77         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
78         (AccessibilityUIElement::url):
79         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
80         (AccessibilityUIElement::url):
81
82 2009-12-17  Philippe Normand  <pnormand@igalia.com>
83
84         Unreviewed; added myself to committers
85
86         * Scripts/modules/committers.py:
87
88 2009-12-17  Benjamin Otte  <otte@gnome.org>
89
90         Unreviewed; added myself to committers
91
92         * Scripts/modules/committers.py:
93
94 2009-12-17  Adam Barth  <abarth@webkit.org>
95
96         Rubber stamp by Seidel.
97
98         Clean up exception handling in WorkQueue.  Basically, a bunch of the
99         delegate messages can throw exceptions because of network errors.  We
100         want the queues to keep on ticking instead of erroring out.  That means
101         we want to catch generic exceptions and continue looping.
102
103         Also, cleaned up the exception handling in the EWS to properly log
104         failures.
105
106         * Scripts/modules/commands/early_warning_system.py:
107         * Scripts/modules/commands/queues.py:
108         * Scripts/modules/workqueue.py:
109
110 2009-12-16  Adam Barth  <abarth@webkit.org>
111
112         Reviewed by Eric Seidel.
113
114         [bzt] Make UpdateStep quiet
115         https://bugs.webkit.org/show_bug.cgi?id=32599
116
117         * Scripts/modules/buildsteps.py:
118         * Scripts/modules/buildsteps_unittest.py:
119
120 2009-12-16  Evan Martin  <evan@chromium.org>
121
122         Reviewed by Adam Barth.
123
124         Add Gtk to the early warning system WebKit port list.
125
126         https://bugs.webkit.org/show_bug.cgi?id=32629
127
128         * Scripts/modules/commands/early_warning_system.py:
129         * Scripts/modules/webkitport.py:
130         * Scripts/modules/webkitport_unittest.py:
131
132 2009-12-16  Eric Seidel  <eric@webkit.org>
133
134         Reviewed by Adam Barth.
135
136         post-diff is failing with exception under guess_reviewer_from_bug
137         https://bugs.webkit.org/show_bug.cgi?id=32642
138
139         Also refactor output capturing code into
140         OutputCapture.assert_outputs to share more code between tests.
141
142         * Scripts/modules/buildsteps.py:
143          - Add the missing include.
144          - Give guess_reviewer_from_bug a private underscore.
145         * Scripts/modules/buildsteps_unittest.py: Added.
146          - Test to make sure _guess_reviewer_from_bug works as expected.
147         * Scripts/modules/commands/commandtest.py:
148          - Custom code is now obsoleted by OutputCapture.assert_outputs
149         * Scripts/modules/commands/queues_unittest.py:
150          - ditto
151         * Scripts/modules/credentials_unittest.py:
152          - ditto
153         * Scripts/modules/mock_bugzillatool.py:
154          - fetch_reviewed_patches_from_bug can never return None
155         * Scripts/modules/multicommandtool_unittest.py:
156          - Custom code is now obsoleted by OutputCapture.assert_outputs
157         * Scripts/modules/outputcapture.py:
158          - Add assert_outputs to share more code between tests.
159         * Scripts/run-webkit-unittests:
160          - Add buildsteps_unittest.py
161
162 2009-12-16  Adam Barth  <abarth@webkit.org>
163
164         Unreviewed.  Added a default argument to _update_status so that callers
165         don't have to explictly pass None when they don't have a patch object.
166
167         * Scripts/modules/commands/queues.py:
168
169 2009-12-16  Kent Tamura  <tkent@chromium.org>
170
171         Reviewed by David Levin.
172
173         check-webkit-style supports for TAB check against text files.
174         https://bugs.webkit.org/show_bug.cgi?id=32538
175
176         * Scripts/check-webkit-style:
177           Move process_patch() to style.py.
178         * Scripts/modules/cpp_style.py:
179           Add can_handle().
180         * Scripts/modules/cpp_style_unittest.py:
181           Add tests for can_handle().
182         * Scripts/modules/style.py:
183           Added. This is a front-end of cpp_style and text_style. It dispatches
184           files to an appropriate linter.
185         * Scripts/modules/text_style.py:
186           Added. This is a linter module for generic text files. It supports
187           only for TAB checking at this moment.
188         * Scripts/modules/text_style_unittest.py:
189           Added. Tests for text_style.py.
190         * Scripts/run-webkit-unittests:
191           Add text_style_unittest.
192
193 2009-12-16  Eric Seidel  <eric@webkit.org>
194
195         Reviewed by David Levin.
196
197         bugzilla-tool should not require users to install mechanize
198         https://bugs.webkit.org/show_bug.cgi?id=32635
199
200         Centralize our import logic.
201
202         * Scripts/modules/bugzilla.py: use webkit_mechanize
203         * Scripts/modules/statusbot.py: use webkit_mechanize
204         * Scripts/modules/webkit_mechanize.py: Added.
205
206 2009-12-16  Eric Seidel  <eric@webkit.org>
207
208         Reviewed by Adam Barth.
209
210         Generalize commit-queue recent status page for all queues
211         https://bugs.webkit.org/show_bug.cgi?id=32633
212
213         * QueueStatusServer/index.html:
214          - Generalize to support other queues.
215         * QueueStatusServer/queue_status.py:
216          - Generalize MainPage to support other queues.
217
218 2009-12-16  Evan Martin  <evan@chromium.org>
219
220         Reviewed by Adam Barth.
221
222         Early warning system server should display output as UTF-8.
223
224         https://bugs.webkit.org/show_bug.cgi?id=32625
225
226         * QueueStatusServer/queue_status.py:
227
228 2009-12-16  Adam Barth  <abarth@webkit.org>
229
230         Reviewed by Eric Seidel.
231
232         [bzt] Add error handling to the early warning system
233         https://bugs.webkit.org/show_bug.cgi?id=32594
234
235         This should be the last step in making the EWS operational.  When we
236         have a build error, we post the log to QueueStatusServer and add a link
237         to the bug.
238
239         * Scripts/modules/commands/early_warning_system.py:
240         * Scripts/modules/commands/queues.py:
241         * Scripts/modules/executive.py:
242
243 2009-12-16  Simon Hausmann  <simon.hausmann@nokia.com>
244
245         Reviewed by Holger Freyther.
246
247         Fix crash with tests that use custom font faces.
248
249         https://bugs.webkit.org/show_bug.cgi?id=32600
250
251         In the DRT we call QApplication::removeAllApplicationFonts(), to make sure
252         that custom font faces between tests don't influence each other. Calling this
253         function in Qt however also invalidates all existing handles with QFontDatabase.
254
255         In order to make sure that WebCore also drops these handles we call QWebSettings::clearMemoryCaches(),
256         which implies a call to WebCore::FontCache::fontCache()->invalidate().
257
258         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
259         (WebCore::DumpRenderTree::open):
260
261 2009-12-16  Andreas Kling  <andreas.kling@nokia.com>
262
263         Reviewed by Simon Hausmann.
264
265         [Qt] Maintain button state between mouse events.
266
267         This allows eventSender to generate drag events.
268
269         https://bugs.webkit.org/show_bug.cgi?id=32601
270
271         * DumpRenderTree/qt/EventSenderQt.cpp:
272         (EventSender::mouseDown):
273         (EventSender::mouseUp):
274         (EventSender::mouseMoveTo):
275         * DumpRenderTree/qt/EventSenderQt.h:
276
277 2009-12-15  Chris Jerdonek  <chris.jerdonek@gmail.com>
278
279         Reviewed by David Levin.
280
281         Code clean-up in check-webkit-style as described below.
282         The only functional changes are minor improvements to the
283         script's help output.
284         
285         https://bugs.webkit.org/show_bug.cgi?id=32487
286
287         * Scripts/check-webkit-style:
288           - Added the module docstring from cpp_style.py.
289           - Improved wording of the --help output and added some of the
290             default values as substitution strings.
291           - Called cpp_style.exit_with_usage instead of sys.stderr.write
292             in main function.
293           - Made changes caused by changes to cpp_style.py.
294
295         * Scripts/modules/cpp_style.py:
296           - Removed module docstring, as well as redundant _USAGE string
297             and main() function obsoleted by check-webkit-style.
298           - Moved specification of default script values from within a
299             function definition to global variables.
300           - Moved the default webkit filter rules to be near the other
301             global variables.
302           - Renamed "FILTER" global variables to "FILTER_RULES" to
303             establish unambiguous terminology.
304           - Renamed _ERROR_CATEGORIES to _STYLE_CATEGORIES.
305           - Changed _STYLE_CATEGORIES from a string to a list.
306           - Added default webkit filter rules to --filter= output.
307           - Renamed "print_" methods to "exit_with_" since they exist
308             and added a temporary display_help parameter.
309           - Added a temporary display_help parameter to parse_arguments.
310
311         * Scripts/modules/cpp_style_unittest.py:
312           - Made changes caused by changes to cpp_style.py.
313           - Lower-cased ErrorCollector's ERROR_CATEGORIES instance 
314             variables since they are not global.
315
316 2009-12-15  Adam Barth  <abarth@webkit.org>
317
318         Unreviewed fix for the style-queue.
319         Typo: _updates_status -> _update_status
320
321         We need to improve our testing infrastructure for the queues.
322
323         * Scripts/modules/commands/queues.py:
324
325 2009-12-15  Adam Barth  <abarth@webkit.org>
326
327         Unreviewed fix for the style-queue.  I suspect this is a recent
328         regression from Eric's change below.
329
330         * Scripts/modules/commands/queues.py:
331
332 2009-12-15  Yaar Schnitman  <yaar@chromium.org>
333
334         Reviewed by Darin Fisher.
335
336         update-webkit-chromium to auto-install gclient
337
338         https://bugs.webkit.org/show_bug.cgi?id=32587
339
340         * Scripts/update-webkit-chromium:
341
342 2009-12-15  Eric Seidel  <eric@webkit.org>
343
344         Reviewed by Adam Barth.
345
346         bugzilla-tool / commit-queue should add results links to bugs when more results are available on the status bot
347         https://bugs.webkit.org/show_bug.cgi?id=32546
348
349         You can see an example of this working in:
350         https://bugs.webkit.org/show_bug.cgi?id=32585#c3
351
352         * QueueStatusServer/queue_status.py:
353          - Output the id of the newly created status.
354         * Scripts/modules/commands/queues.py:
355          - Tweak the commit-queue logging to include a full status link.
356         * Scripts/modules/statusbot.py:
357          - update_status should return the newly created status id.
358
359 2009-12-15  Andras Becsi  <abecsi@inf.u-szeged.hu>
360
361         Reviewed by Tor Arne Vestbø.
362
363         [Qt] Rename Qt DRT components to match other ports' naming convention and to be more understandable.
364
365         * DumpRenderTree/qt/DumpRenderTree.cpp: Removed.
366         * DumpRenderTree/qt/DumpRenderTree.h: Removed.
367         * DumpRenderTree/qt/DumpRenderTree.pro: Updated.
368         * DumpRenderTree/qt/DumpRenderTreeQt.cpp: Copied from WebKitTools/DumpRenderTree/qt/DumpRenderTree.cpp.
369         * DumpRenderTree/qt/DumpRenderTreeQt.h: Copied from WebKitTools/DumpRenderTree/qt/DumpRenderTree.h.
370         * DumpRenderTree/qt/GCControllerQt.cpp: Copied from WebKitTools/DumpRenderTree/qt/jsobjects.cpp.
371         (GCController::GCController):
372         * DumpRenderTree/qt/GCControllerQt.h: Copied from WebKitTools/DumpRenderTree/qt/jsobjects.h.
373         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
374         * DumpRenderTree/qt/WorkQueueItem.h: Removed.
375         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Updated includes.
376         * DumpRenderTree/qt/WorkQueueItemQt.h: Copied from WebKitTools/DumpRenderTree/qt/WorkQueueItem.h.
377         * DumpRenderTree/qt/jsobjects.cpp: Removed.
378         * DumpRenderTree/qt/jsobjects.h: Removed.
379         * DumpRenderTree/qt/main.cpp: Updated includes.
380
381 2009-12-15  Adam Barth  <abarth@webkit.org>
382
383         Reviewed by Eric Seidel.
384
385         We have two mark-fixed commands
386         https://bugs.webkit.org/show_bug.cgi?id=32073
387
388         * Scripts/mark-bug-fixed: Removed.
389         * Scripts/modules/commands/upload.py:
390         * Scripts/modules/commands/upload_unittest.py:
391
392 2009-12-15  Eric Seidel  <eric@webkit.org>
393
394         Reviewed by Adam Barth.
395
396         bugzilla-tool/commit-queue needs to upload failure logs when patches are rejected
397         https://bugs.webkit.org/show_bug.cgi?id=28286
398
399         * QueueStatusServer/index.html:
400          - Show [results] links if a results log was uploaded.
401         * QueueStatusServer/queue_status.py:
402          - Empty file uploads appear as u"" and Blob does not handle unicode, so convert to str().
403         * Scripts/modules/commands/queues.py:
404          - Post to the status bot when a patch fails and include the failure log as a results file.
405
406 2009-12-15  Eric Seidel  <eric@webkit.org>
407
408         Reviewed by Adam Barth.
409
410         queue sub-commands need --status-host so they can report status
411         https://bugs.webkit.org/show_bug.cgi?id=32313
412
413         Make --status-bot a global option and make
414         run_bugzilla_tool pass --status-bot to sub-commands.
415
416         * Scripts/bugzilla-tool:
417          - Rename _status to status_bot and make it non-lazy.
418         * Scripts/modules/commands/queues.py:
419          - Move status updates out of WorkQueue and into individual queues.
420         * Scripts/modules/commands/queues_unittest.py:
421          - Test that --status-host is passed to bugzilla-tool when run as subcommand.
422         * Scripts/modules/mock_bugzillatool.py:
423          - Add a MockStatusBot
424         * Scripts/modules/workqueue.py:
425          - Remove status_host and work_work_logs_directory callbacks.
426          - Add new work_item_log_path callback so that WorkQueue doesn't need to know about patches!
427         * Scripts/modules/workqueue_unittest.py:
428          - Update unit tests to reflect new callbacks.
429
430 2009-12-15  Adam Barth  <abarth@webkit.org>
431
432         Reviewed by Eric Seidel.
433
434         scm_unittest.py is too slow
435         https://bugs.webkit.org/show_bug.cgi?id=31818
436
437         Now we don't run the SCM unit tests unless we get the --all flag on the
438         command line.  Eric and I were commenting out this test because it was
439         too painful to run.
440
441         * Scripts/run-webkit-unittests:
442
443 2009-12-14  Adam Barth  <abarth@webkit.org>
444
445         Unreviewed.  Fix failing unittest.
446
447         * Scripts/modules/bugzilla_unittest.py:
448
449 2009-12-14  Eric Seidel  <eric@webkit.org>
450
451         Reviewed by Adam Barth.
452
453         Move Credential handling out into a separate module
454         https://bugs.webkit.org/show_bug.cgi?id=32531
455
456         * Scripts/modules/bugzilla.py:
457         * Scripts/modules/credentials.py: Added.
458         * Scripts/modules/credentials_unittest.py: Added.
459         * Scripts/run-webkit-unittests:
460
461 2009-12-14  Adam Barth  <abarth@webkit.org>
462
463         Reviewed by Eric Seidel.
464
465         Kill _create_step_sequence
466         https://bugs.webkit.org/show_bug.cgi?id=32539
467
468         It's cleaner to represent not having these sequences as an empty
469         sequence instead of None.
470
471         * Scripts/modules/commands/download.py:
472         * Scripts/modules/stepsequence.py:
473
474 2009-12-14  Adam Barth  <abarth@webkit.org>
475
476         Unreviewed.  Address reviewer comments from an earlier patch.  I didn't
477         do this earlier because I was worried about conflicts in dependent
478         patches.
479
480         * Scripts/modules/commands/download.py:
481
482 2009-12-14  Adam Barth  <abarth@webkit.org>
483
484         Reviewed by Eric Seidel.
485
486         [bzt] Make download commands declarative
487         https://bugs.webkit.org/show_bug.cgi?id=32469
488
489         This patch "properly" factors most of the download commands.  These
490         commands are now largely declarative, which is the final step of this
491         grand refactoring.
492
493         * Scripts/modules/buildsteps.py:
494         * Scripts/modules/commands/download.py:
495
496 2009-12-14  Adam Barth  <abarth@webkit.org>
497
498         Reviewed by Eric Seidel.
499
500         [bzt] Add AbstractPatchSequencingCommand to remove redundant code
501         https://bugs.webkit.org/show_bug.cgi?id=32468
502
503         Redundant code is bad.  This patch moves us towards more declarative
504         commands.
505
506         * Scripts/modules/commands/download.py:
507
508 2009-12-14  Adam Barth  <abarth@webkit.org>
509
510         Reviewed by Eric Seidel.
511
512         [bzt] Kill WebKitApplyingScripts
513         https://bugs.webkit.org/show_bug.cgi?id=32467
514
515         Ah!  I've been wanting to do this for a long time.  This patch brings
516         the applying commands into the patch processing fold.
517
518         * Scripts/bugzilla-tool:
519         * Scripts/modules/buildsteps.py:
520         * Scripts/modules/commands/download.py:
521         * Scripts/modules/commands/download_unittest.py:
522         * Scripts/modules/mock_bugzillatool.py:
523
524 2009-12-14  Adam Barth  <abarth@webkit.org>
525
526         Reviewed by Eric Seidel.
527
528         [bzt] Convert rollout to StepSequence
529         https://bugs.webkit.org/show_bug.cgi?id=32406
530
531         * Scripts/modules/buildsteps.py:
532         * Scripts/modules/commands/download.py:
533         * Scripts/modules/commands/download_unittest.py:
534         * Scripts/modules/mock_bugzillatool.py:
535
536 2009-12-14  Adam Barth  <abarth@webkit.org>
537
538         Reviewed by Eric Seidel.
539
540         [bzt] Kill LandingSequence
541         https://bugs.webkit.org/show_bug.cgi?id=32464
542
543         Removes LandingSequence in favor of StepSequence.  This required
544         changing the Step API slightly to carry a general notion of state
545         instead of carrying patches specifically.
546
547         * Scripts/modules/buildsteps.py:
548         * Scripts/modules/commands/download.py:
549         * Scripts/modules/commands/queues.py:
550         * Scripts/modules/landingsequence.py: Removed.
551         * Scripts/modules/stepsequence.py:
552
553 2009-12-14  Robert Hogan  <robert@roberthogan.net>
554
555         Reviewed by Eric Seidel.
556
557         [Qt] Fix https://bugs.webkit.org/show_bug.cgi?id=32437
558         
559         Amend the behaviour of DRT::notifyDone to dump only when
560         the page has finished loading.
561         
562         This fix permits removal of the following tests from the Qt skipped list:
563         fast/forms/textarea-linewrap-dynamic.html
564         fast/forms/textarea-setvalue-submit.html
565         fast/forms/textarea-hard-linewrap-empty.html
566         fast/forms/submit-to-url-fragment.html
567         http/tests/misc/percent-sign-in-form-field-name.html
568         http/tests/security/escape-form-data-field-names.html
569         
570         However it also requires the following two to be added to the skipped list:
571         
572         http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html
573         svg/custom/use-instanceRoot-as-event-target.xhtml
574         
575         It appears the behaviour of notifyDone was masking problems with these two
576         tests.
577
578         * DumpRenderTree/qt/DumpRenderTree.cpp:
579         (WebCore::DumpRenderTree::DumpRenderTree):
580         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
581         (LayoutTestController::reset):
582         (LayoutTestController::processWork):
583         (LayoutTestController::maybeDump):
584         (LayoutTestController::notifyDone):
585         (LayoutTestController::provisionalLoad):
586         * DumpRenderTree/qt/LayoutTestControllerQt.h:
587         (LayoutTestController::resetLoadFinished):
588
589 2009-12-14  Simon Hausmann  <hausmann@webkit.org>
590
591         Reviewed by Holger Freyther.
592
593         [Qt] Add support for keyboard modifiers to Qt DRT's EventSender for touch events
594
595         https://bugs.webkit.org/show_bug.cgi?id=32482
596
597         * DumpRenderTree/qt/EventSenderQt.cpp:
598         (EventSender::setTouchModifier):
599         (EventSender::clearTouchPoints):
600         (EventSender::sendTouchEvent):
601         * DumpRenderTree/qt/EventSenderQt.h:
602
603 2009-12-13  Maciej Stachowiak  <mjs@apple.com>
604
605         Reviewed by Gavin Barraclaugh.
606
607         Fix minor problem in sunspider-compare-results which left it broken.
608
609         * Scripts/sunspider-compare-results: Declare $parseonly
610
611 2009-12-12  Maciej Stachowiak  <mjs@apple.com>
612
613         Reviewed by Oliver Hunt.
614
615         Give command-line sunspider the ability to handle multiple suites and versions
616         https://bugs.webkit.org/show_bug.cgi?id=32477
617
618         * Scripts/run-sunspider: Updated for changes to command-line parameters.
619         * Scripts/sunspider-compare-results: ditto
620
621 2009-12-12  Maciej Stachowiak  <mjs@apple.com>
622
623         Not reviewed, fixing previous comment.
624
625         Remove accidental change to sunspider-compare-results
626
627         * Scripts/sunspider-compare-results:
628
629 2009-12-11  Yael Aharon  <yael.aharon@nokia.com>
630
631         Unreviewed build fix for Qt versions < 4.6. 
632         Guard every slot individually with #ifdef.
633
634         * DumpRenderTree/qt/EventSenderQt.cpp:
635         (EventSender::addTouchPoint):
636         (EventSender::updateTouchPoint):
637         (EventSender::touchStart):
638         (EventSender::touchMove):
639         (EventSender::touchEnd):
640         (EventSender::clearTouchPoints):
641         (EventSender::releaseTouchPoint):
642         (EventSender::sendTouchEvent):
643         * DumpRenderTree/qt/EventSenderQt.h:
644
645 2009-12-11  Eric Seidel  <eric@webkit.org>
646
647         Reviewed by Adam Barth.
648
649         CommandsTest.assert_execute_outputs doesn't check stderr
650         https://bugs.webkit.org/show_bug.cgi?id=32352
651
652         Fix assert_execute_outputs to check stderr
653         and then fix all the unit tests which needed to
654         pass stderr output.
655
656         * Scripts/modules/commands/commandtest.py:
657         * Scripts/modules/commands/download_unittest.py:
658         * Scripts/modules/commands/upload_unittest.py:
659
660 2009-12-11  Adam Barth  <abarth@webkit.org>
661
662         Reviewed by Eric Seidel.
663
664         [check-webkit-style] False positive for tst_QWebFrame
665         https://bugs.webkit.org/show_bug.cgi?id=32436
666
667         Add an exception for function names that start with "tst_".  These are
668         used by the Qt unit testing framework.
669
670         * Scripts/modules/cpp_style.py:
671         * Scripts/modules/cpp_style_unittest.py:
672
673 2009-12-11  Simon Hausmann  <hausmann@webkit.org>, Kim Grönholm  <kim.gronholm@nomovok.com>
674
675         Reviewed by Antti Koivisto.
676
677         Added support for creating synthetic touch events with EventSender
678         in Qt's DumpRenderTree.
679
680         https://bugs.webkit.org/show_bug.cgi?id=32114
681
682         * DumpRenderTree/qt/EventSenderQt.cpp:
683         (EventSender::addTouchPoint):
684         (EventSender::updateTouchPoint):
685         (EventSender::touchStart):
686         (EventSender::touchMove):
687         (EventSender::touchEnd):
688         (EventSender::clearTouchPoints):
689         (EventSender::releaseTouchPoint):
690         (EventSender::sendTouchEvent):
691         * DumpRenderTree/qt/EventSenderQt.h:
692
693 2009-12-11  Benjamin Poulain  <benjamin.poulain@nokia.com>
694
695         Reviewed by Darin Adler.
696
697         The values of RuntimeArray are not enumerable
698         https://bugs.webkit.org/show_bug.cgi?id=29005
699
700         * DumpRenderTree/mac/ObjCController.m:
701         (+[ObjCController isSelectorExcludedFromWebScript:]):
702         (+[ObjCController webScriptNameForSelector:]):
703         (-[ObjCController arrayOfString]):
704
705 2009-12-10  Eric Seidel  <eric@webkit.org>
706
707         No review, just updating unit tests to match recent checkins.
708
709         * Scripts/modules/mock_bugzillatool.py:
710          - Add missing red_core_builders_names method causing exception.
711         * Scripts/modules/workqueue_unittest.py:
712          - processutils is dead, use executive.py instead.
713
714 2009-12-10  Eric Seidel  <eric@webkit.org>
715
716         Reviewed by Adam Barth.
717
718         Move run_command onto Executive to make code which uses run_command testable
719         https://bugs.webkit.org/show_bug.cgi?id=32396
720
721         * Scripts/modules/executive.py:
722          - Move run_command and error handlers onto Executive.
723         * Scripts/modules/scm.py:
724         * Scripts/modules/scm_unittest.py:
725
726 2009-12-09  Eric Seidel  <eric@webkit.org>
727
728         Reviewed by Adam Barth.
729
730         bugzilla-tool needs a command to list patches needing cq+
731         https://bugs.webkit.org/show_bug.cgi?id=32351
732
733         * Scripts/modules/bugzilla.py:
734          - Parse attacher_email from attachment xml.
735         * Scripts/modules/bugzilla_unittest.py:
736          - Test new attacher_email parsing.
737         * Scripts/modules/commands/queries.py:
738          - Add PatchesToCommitQueue
739         * Scripts/modules/commands/queries_unittest.py:
740          - Tests for PatchesToCommitQueue
741         * Scripts/modules/mock_bugzillatool.py:
742          - Add necessary mock methods for running PatchesToCommitQueue
743
744 2009-12-10  Adam Barth  <abarth@webkit.org>
745
746         Unreviewed.  Turns out every StepSequence command needs a --quiet
747         option.
748
749         * Scripts/modules/stepsequence.py:
750
751 2009-12-10  Eric Z. Ayers  <zundel@google.com>
752
753         Reviewed by Pavel Feldman.
754
755         Implements displayWebView() to force an invalidation and repaint.
756         This fixes a problem running the timeline-paint.html unit test.
757
758         https://bugs.webkit.org/show_bug.cgi?id=31729
759
760         * DumpRenderTree/gtk/DumpRenderTree.cpp:
761         (displayWebView):
762
763 2009-12-10  Adam Barth  <abarth@webkit.org>
764
765         Reviewed by Eric Seidel.
766
767         [bzt] Convert more commands to StepSequences
768         https://bugs.webkit.org/show_bug.cgi?id=32362
769
770         We should eventually convert all the commands, but I'm starting with
771         the easy ones.
772
773         * Scripts/modules/commands/download.py:
774
775 2009-12-10  Xan Lopez  <xlopez@igalia.com>
776
777         Reviewed by Jan Alonzo.
778
779         [GTK] editing/selection/shrink-selection-after-shift-pagedown.html failing
780         https://bugs.webkit.org/show_bug.cgi?id=31103
781
782         Give focus to the webviews when we create them, since some tests expect this.
783
784         * DumpRenderTree/gtk/DumpRenderTree.cpp:
785         (main):
786
787 2009-12-10  Eric Seidel  <eric@webkit.org>
788
789         Reviewed by Adam Barth.
790
791         bugzilla-tool "builders are red" error should tell you which builders
792         https://bugs.webkit.org/show_bug.cgi?id=32211
793
794         * Scripts/modules/buildsteps.py:
795
796 2009-12-09  Marwan Al Jubeh  <marwan.aljubeh@gmail.com>
797
798         Reviewed by Adam Roben.
799
800         Fixes: https://bugs.webkit.org/show_bug.cgi?id=31228
801         Set the WebKitOutputDir, WebKitLibrariesDir and Cygwin environment variables automatically
802         in Windows as part of running update_webkit.
803
804         * Scripts/update-webkit:
805          - Run setupAppleWinEnv() on Apple's Windows port.
806         * Scripts/webkitdirs.pm:
807          - Added functions that return the source directory, libraries directory and default build directory on Windows.
808          - Added isWindowsNT() which tests if the current Windows version is from the Windows NT family.
809          - Implemented setupAppleWinEnv() which sets the environment variables WebKitOutputDir, WebKitLibrariesDir
810            and Cygwin to their desired values.
811
812 2009-12-09  Adam Barth  <abarth@webkit.org>
813
814         Reviewed by Eric Seidel.
815
816         exception thrown when running apply-patches
817         https://bugs.webkit.org/show_bug.cgi?id=32344
818
819         The update step now takes a port option.  Once we finish the Steps
820         refactoring, we won't have to worry about this kind of bug again.
821
822         * Scripts/modules/commands/download.py:
823
824 2009-12-09  Adam Barth  <abarth@webkit.org>
825
826         Unreviewed.  Fix ScriptError includes.  I don't understand why these
827         didn't throw during unit testing...
828
829         * Scripts/modules/commands/download.py:
830         * Scripts/modules/logging_unittest.py:
831         * Scripts/modules/workqueue.py:
832
833 2009-12-09  Adam Barth  <abarth@webkit.org>
834
835         Reviewed by Eric Seidel.
836
837         [bzt] Remove unused PatchCollection class
838         https://bugs.webkit.org/show_bug.cgi?id=32312
839
840         It's dead code.
841
842         * Scripts/modules/patchcollection.py:
843         * Scripts/modules/patchcollection_unittest.py: Removed.
844
845 2009-12-09  Adam Barth  <abarth@webkit.org>
846
847         Unreviewed "build" fix.  CheckStyle needs a --no-upate option.
848
849         * Scripts/modules/commands/download.py:
850
851 2009-12-09  Adam Barth  <abarth@webkit.org>
852
853         Reviewed by Eric Seidel.
854
855         [bzt] Convert Build to use Sequence
856         https://bugs.webkit.org/show_bug.cgi?id=32310
857
858         So much prettier.
859
860         * Scripts/modules/buildsteps.py:
861         * Scripts/modules/commands/download.py:
862         * Scripts/modules/landingsequence.py:
863         * Scripts/modules/stepsequence.py: Added.
864
865 2009-12-09  Adam Barth  <abarth@webkit.org>
866
867         Add missing file.
868
869         * Scripts/modules/executive.py: Added.
870
871 2009-12-09  Adam Barth  <abarth@webkit.org>
872
873         Unreviewed "build" fix.
874
875         * Scripts/modules/landingsequence.py:
876
877 2009-12-09  Adam Barth  <abarth@webkit.org>
878
879         Reviewed by Eric Seidel.
880
881         [bzt] Implement abstract Steps
882         https://bugs.webkit.org/show_bug.cgi?id=32212
883
884         This is a fairly disruptive change that refactors how we build
885         commands.  Instead of using a landing sequence, we can now assemble a
886         sequence of steps directly.  We still use the landing sequence in the
887         interim, but this will be removed soon.
888
889         * Scripts/bugzilla-tool:
890         * Scripts/modules/buildsteps.py:
891         * Scripts/modules/commands/download.py:
892         * Scripts/modules/commands/early_warning_system.py:
893         * Scripts/modules/commands/queues.py:
894         * Scripts/modules/commands/queues_unittest.py:
895         * Scripts/modules/landingsequence.py:
896         * Scripts/modules/mock_bugzillatool.py:
897         * Scripts/modules/processutils.py: Removed.
898         * Scripts/modules/scm.py:
899         * Scripts/modules/scm_unittest.py:
900         * Scripts/modules/webkitport.py:
901
902 2009-12-08  Eric Seidel  <eric@webkit.org>
903
904         Reviewed by Adam Barth.
905
906         run_command and ScriptError should move into processutils.py
907         https://bugs.webkit.org/show_bug.cgi?id=32305
908
909         Turns out there are a zillion callers to run_command.
910
911         * Scripts/modules/commands/download.py:
912         * Scripts/modules/commands/early_warning_system.py:
913         * Scripts/modules/commands/queues.py:
914         * Scripts/modules/landingsequence.py:
915         * Scripts/modules/logging_unittest.py:
916         * Scripts/modules/processutils.py:
917         * Scripts/modules/scm.py:
918         * Scripts/modules/scm_unittest.py:
919         * Scripts/modules/workqueue.py:
920         * Scripts/modules/workqueue_unittest.py:
921
922 2009-12-08  Kevin Watters  <kevinwatters@gmail.com>
923
924         Reviewed by Kevin Ollivier.
925
926         [wx] Mac plugins support.
927         
928         https://bugs.webkit.org/show_bug.cgi?id=32236
929
930         * wx/browser/wscript:
931
932 2009-12-08  David Levin  <levin@chromium.org>
933
934         Reviewed by Adam Barth.
935
936         [check-webkit-style] False positive for DEFINE_OPCODE(op_jtrue) {
937         https://bugs.webkit.org/show_bug.cgi?id=32193
938
939         * Scripts/modules/cpp_style.py: For the function { rule, if there is space
940           at the beginning of line, ignore lines which then have a macro.
941         * Scripts/modules/cpp_style_unittest.py: Add tests to verify the
942           new behavior.
943
944 2009-12-08  Dmitry Titov  <dimich@chromium.org>
945
946         Rubber-stamped by David Levin.
947
948         Revert and reopen "Add asserts to RefCounted to make sure ref/deref happens on the right thread."
949         It may have caused massive increase of reported leaks on the bots.
950         https://bugs.webkit.org/show_bug.cgi?id=31639
951
952         * DumpRenderTree/ForwardingHeaders/wtf/ThreadVerifier.h: Removed.
953
954 2009-12-08  Dmitry Titov  <dimich@chromium.org>
955
956         Reviewed by Darin Adler.
957
958         Add asserts to RefCounted to make sure ref/deref happens on the right thread.
959         https://bugs.webkit.org/show_bug.cgi?id=31639
960
961         * DumpRenderTree/ForwardingHeaders/wtf/ThreadVerifier.h: Added.
962
963 2009-12-08  David Levin  <levin@chromium.org>
964
965         Reviewed by Adam Barth.
966
967         [check-webkit-style] False positive for camel case of JSC op codes
968         https://bugs.webkit.org/show_bug.cgi?id=32192
969
970         * Scripts/modules/cpp_style.py: Added an exception for the JSC op
971           code functions and const_iterator as well since I noticed a false
972           positive there when testing the fix.
973         * Scripts/modules/cpp_style_unittest.py: Added tests for these
974           changes.
975
976 2009-12-08  Nikolas Zimmermann  <nzimmermann@rim.com>
977
978         Rubber-stamped by Maciej Stachowiak.
979
980         Turn on (SVG) Filters for Win.
981         https://bugs.webkit.org/show_bug.cgi?id=32224
982
983         * Scripts/webkitdirs.pm:
984
985 2009-12-08  Nikolas Zimmermann  <nzimmermann@rim.com>
986
987         Rubber-stamped by Maciej Stachowiak.
988
989         Turn on (SVG) Filters for Gtk.
990         https://bugs.webkit.org/show_bug.cgi?id=32224
991
992         * Scripts/build-webkit:
993
994 2009-12-07  Shinichiro Hamaji  <hamaji@chromium.org>
995
996         Reviewed by David Levin.
997
998         [check-webkit-style] S_OK is a fine identifier
999         https://bugs.webkit.org/show_bug.cgi?id=32225
1000
1001         * Scripts/modules/cpp_style.py:
1002         * Scripts/modules/cpp_style_unittest.py:
1003
1004 2009-12-07  Nikolas Zimmermann  <nzimmermann@rim.com>
1005
1006         Rubber-stamped by Maciej Stachowiak.
1007
1008         Turn on (SVG) Filters for Qt.
1009         https://bugs.webkit.org/show_bug.cgi?id=32224
1010
1011         * Scripts/build-webkit:
1012
1013 2009-12-07  Yuzo Fujishima  <yuzo@google.com>
1014
1015         Reviewed by Alexey Proskuryakov.
1016
1017         Make run-webkit-websocketserver log to stderr rather than to a file.
1018         https://bugs.webkit.org/show_bug.cgi?id=32234
1019
1020         * Scripts/run-webkit-websocketserver:
1021
1022 2009-12-07  Dmitry Titov  <dimich@chromium.org>
1023
1024         Rubber-stamped by Darin Adler.
1025
1026         Remove ENABLE_SHARED_SCRIPT flags
1027         https://bugs.webkit.org/show_bug.cgi?id=32245
1028         This patch was obtained by "git revert" command and then un-reverting of ChangeLog files.
1029
1030         * Scripts/build-webkit:
1031
1032 2009-12-07  Simon Fraser  <simon.fraser@apple.com>
1033
1034         Reviewed by Darin Adler.
1035
1036         <rdar://problem/7450481> One compositing test keeps DRT in "compositing mode", breaks repaint tests
1037
1038         The counter that WebView used to keep track of the number of enclosed WebHTMLViews using
1039         accelerated compositing was hard to manage, and maintained incorrectly in a number of cases.
1040         This caused one compositing test make DumpRenderTree think that all subsequent tests
1041         were compositing too.
1042
1043         Replace this counter with notifications, which are only fired if a client (DRT) requests them. The
1044         notification informs the client that a WebHTMLView entered compositing mode (or an already-
1045         compositing WebHTML was added); it does not say when a view becomes uncomposited, or all
1046         compositing subviews were removed, since this is tricky to get right.
1047         
1048         DumpRenderTreeWindow listens for this notification, and uses it to turn on window
1049         autodisplay, which is necessary to kick-start Core Animation rendering and animations.
1050         We ensure that window autodisplay is turned off before every test.
1051
1052         * DumpRenderTree/mac/DumpRenderTree.mm:
1053         (createWebViewAndOffscreenWindow):
1054         (resetWebViewToConsistentStateBeforeTesting):
1055         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1056         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1057         (-[DumpRenderTreeWindow close]):
1058         (-[DumpRenderTreeWindow startListeningForAcceleratedCompositingChanges]):
1059         (-[DumpRenderTreeWindow webViewStartedAcceleratedCompositing:]):
1060
1061 2009-12-07  Nikolas Zimmermann  <nzimmermann@rim.com>
1062
1063         Reviewed by Holger Hans Peter Freyther.
1064
1065         Turn on (SVG) Filters support, by default.
1066         https://bugs.webkit.org/show_bug.cgi?id=32224
1067
1068         For now only enable FILTERS build flag on WebKit/mac. Other platforms will follow soon.
1069
1070         * Scripts/build-webkit:
1071
1072 2009-12-07  Yaar Schnitman  <yaar@chromium.org>
1073
1074         Reviewed by Darin Fisher.
1075
1076         Chromium buildbots are not red when they fail
1077         https://bugs.webkit.org/show_bug.cgi?id=32235
1078
1079         * Scripts/build-webkit:
1080
1081 2009-12-07  Yaar Schnitman  <yaar@chromium.org>
1082
1083         Reviewed by Darin Fisher.
1084
1085         Typo in chromium linux builder
1086         https://bugs.webkit.org/show_bug.cgi?id=32238
1087
1088         * Scripts/webkitdirs.pm:
1089
1090 2009-12-07  Yaar Schnitman  <yaar@chromium.org>
1091
1092         Reviewed by Darin Fisher.
1093
1094         fixes to build-webkit --chromium
1095         https://bugs.webkit.org/show_bug.cgi?id=32179
1096
1097         * Scripts/webkitdirs.pm:
1098
1099 2009-12-07  Eric Seidel  <eric@webkit.org>
1100
1101         No review, just adding two recently approved committers.
1102
1103         * Scripts/modules/committers.py:
1104
1105 2009-12-07  Alexey Proskuryakov  <ap@apple.com>
1106
1107         * Scripts/run-webkit-websocketserver: Added property svn:executable.
1108
1109 2009-12-07  Yuzo Fujishima  <yuzo@google.com>
1110
1111         Reviewed by Alexey Proskuryakov.
1112
1113         Add run-webkit-websocketserver
1114
1115         https://bugs.webkit.org/show_bug.cgi?id=31390
1116
1117         * Scripts/run-webkit-websocketserver: Added.
1118
1119 2009-12-07  Steve Falkenburg  <sfalken@apple.com>
1120
1121         Build fix. Be flexible about which version of ICU is used on Windows.
1122
1123         * DumpRenderTree/win/DumpRenderTree.vcproj: Add optional xcopy commands to copy ICU 4.2.
1124
1125 2009-12-07  Dirk Schulze  <krit@webkit.org>
1126
1127         Not reviewed, adding myself to the reviewers list.
1128
1129         * Scripts/modules/committers.py:
1130
1131 2009-12-06  Eric Seidel  <eric@webkit.org>
1132
1133         Reviewed by Adam Barth.
1134
1135         Add an API for uploading results files to StatusBot
1136         https://bugs.webkit.org/show_bug.cgi?id=32210
1137
1138         Add Content-Type: plain/text which was forgotten
1139         from the previous commit when I landed with land-patches
1140         instead of land-diff.
1141
1142         * QueueStatusServer/queue_status.py:
1143
1144 2009-12-06  Eric Seidel  <eric@webkit.org>
1145
1146         Reviewed by Adam Barth.
1147
1148         Status Server needs a way to handle uploaded results
1149         https://bugs.webkit.org/show_bug.cgi?id=32209
1150
1151         * QueueStatusServer/queue_status.py: Add a ShowResults (results/*) command
1152         * QueueStatusServer/update_status.html: Add file upload.
1153
1154 2009-12-06  Eric Seidel  <eric@webkit.org>
1155
1156         Reviewed by Adam Barth.
1157
1158         Add an API for uploading results files to StatusBot
1159         https://bugs.webkit.org/show_bug.cgi?id=32210
1160
1161         * Scripts/modules/statusbot.py:
1162
1163 2009-12-06  Eric Seidel  <eric@webkit.org>
1164
1165         Reviewed by Adam Barth.
1166
1167         Status Server needs a way to handle uploaded results
1168         https://bugs.webkit.org/show_bug.cgi?id=32209
1169
1170         * QueueStatusServer/queue_status.py: Add a ShowResults (results/*) command
1171         * QueueStatusServer/update_status.html: Add file upload.
1172
1173 2009-12-06  Adam Barth  <abarth@webkit.org>
1174
1175         Reviewed by Eric Seidel.
1176
1177         [bzt] BuildAttachment should not check the builders
1178         https://bugs.webkit.org/show_bug.cgi?id=32207
1179
1180         This is code that got copied here by accident when the class was created.
1181
1182         * Scripts/modules/commands/download.py:
1183
1184 2009-12-06  Adam Barth  <abarth@webkit.org>
1185
1186         Reviewed by Eric Seidel.
1187
1188         [bzt] Make LandingSequence.update aware of ports
1189         https://bugs.webkit.org/show_bug.cgi?id=32208
1190
1191         This is required to make build work on the Chromium port because
1192         Chromium has a custom update-webkit.
1193
1194         * Scripts/modules/landingsequence.py:
1195
1196 2009-12-06  Adam Barth  <abarth@webkit.org>
1197
1198         Reviewed by Eric Seidel.
1199
1200         Add early warning system commands to bugzilla-tool.
1201
1202         * Scripts/bugzilla-tool:
1203         * Scripts/modules/landingsequence.py:
1204         * Scripts/modules/webkitport.py:
1205
1206 2009-12-06  Adam Barth  <abarth@webkit.org>
1207
1208         Reviewed by Eric Seidel.
1209
1210         [bzt] Implement Qt EarlyWarningSystem and Chromium EarlyWarningSystem
1211         https://bugs.webkit.org/show_bug.cgi?id=32205
1212
1213         * Scripts/modules/commands/early_warning_system.py: Added.
1214         * Scripts/modules/commands/queues.py:
1215
1216 2009-12-06  Dan Bernstein  <mitz@apple.com>
1217
1218         Reviewed by Adele Peterson.
1219
1220         REGRESSION (r51728): update-webkit fails when the current directory is
1221         not inside a Subversion working copy
1222         https://bugs.webkit.org/show_bug.cgi?id=32204
1223
1224         * Scripts/update-webkit: Invoke isSVN() in the correct working
1225         directory.
1226
1227 2009-12-06  Adam Barth  <abarth@webkit.org>
1228
1229         Reviewed by Eric Seidel.
1230
1231         [bzt] Rename AbstractTryQueue to AbstractReviewQueue
1232         https://bugs.webkit.org/show_bug.cgi?id=32202
1233
1234         * Scripts/modules/commands/queues.py:
1235
1236 2009-12-05  Adam Barth  <abarth@webkit.org>
1237
1238         Reviewed by Eric Seidel.
1239
1240         [bzt] Implement ChromiumPort
1241         https://bugs.webkit.org/show_bug.cgi?id=32182
1242
1243         * Scripts/modules/webkitport.py:
1244         * Scripts/modules/webkitport_unittest.py:
1245
1246 2009-12-05  Adam Barth  <abarth@webkit.org>
1247
1248         Reviewed by Eric Seidel.
1249
1250         Move update-webkit into BuildSteps
1251         https://bugs.webkit.org/show_bug.cgi?id=32181
1252
1253         We need to move update-webkit out of SCM.py because SCM isn't supposed to know
1254         that WebKit exists.  The proper place for the knowledge of the existence of
1255         update-webkit is in WebKitPort because some ports have specialized update
1256         scripts (analogous to build-webkit).
1257
1258         * Scripts/modules/buildsteps.py:
1259         * Scripts/modules/commands/download.py:
1260         * Scripts/modules/landingsequence.py:
1261         * Scripts/modules/scm.py:
1262         * Scripts/modules/webkitport.py:
1263
1264 2009-12-05  Adam Barth  <abarth@webkit.org>
1265
1266         Reviewed by Eric Seidel.
1267
1268         update-webkit should call git svn rebase and resolve-ChangeLogs -f
1269         https://bugs.webkit.org/show_bug.cgi?id=27162
1270
1271         Teach update-webkit about Git.  I didn't add the call to
1272         resolve-ChangeLogs -f because sometimes that script goes bananas.  We
1273         can iterate from here, however.
1274
1275         * Scripts/update-webkit:
1276
1277 2009-12-04  Yael Aharon  <yael.aharon@nokia.com>
1278
1279         Unreviewed build fix.
1280
1281         [Qt] build fix after r51634 removed unused QBoxLayout include which included limits.h.
1282
1283         * DumpRenderTree/qt/DumpRenderTree.cpp:
1284
1285 2009-12-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1286
1287         Reviewed by Adam Treat.
1288
1289         Add some missing methods for showing and hiding the
1290         Web Inspector.
1291
1292         * DumpRenderTree/qt/DumpRenderTree.cpp:
1293         (WebCore::WebPage::WebPage):
1294         (WebCore::WebPage::~WebPage):
1295         (WebCore::WebPage::webInspector):
1296         * DumpRenderTree/qt/DumpRenderTree.h:
1297         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1298         (LayoutTestController::showWebInspector):
1299         (LayoutTestController::hideWebInspector):
1300         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1301
1302 2009-12-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1303
1304         Reviewed by Adam Treat.
1305
1306         Implement the setAllowUniversalAccessFromFileURLs method
1307         for the Qt LayoutTestController.
1308
1309         * DumpRenderTree/qt/DumpRenderTree.cpp:
1310         (WebCore::WebPage::resetSettings):
1311         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1312         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1313         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1314
1315 2009-12-04  Chris Fleizach  <cfleizach@apple.com>
1316
1317         Reviewed by Darin Adler.
1318
1319         REGRESSION: AX: buttons now extremely repetitive
1320         https://bugs.webkit.org/show_bug.cgi?id=32164
1321
1322         * DumpRenderTree/AccessibilityUIElement.cpp:
1323         (isAttributeSupportedCallback):
1324         (AccessibilityUIElement::getJSClass):
1325         * DumpRenderTree/AccessibilityUIElement.h:
1326         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1327         (AccessibilityUIElement::isAttributeSupported):
1328         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1329         (AccessibilityUIElement::isAttributeSupported):
1330         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1331         (AccessibilityUIElement::isAttributeSupported):
1332
1333 2009-12-03  Shinichiro Hamaji  <hamaji@chromium.org>
1334
1335         Reviewed by David Levin.
1336
1337         check-webkit-style should check for camelCase variable names
1338         https://bugs.webkit.org/show_bug.cgi?id=32051
1339
1340         * Scripts/modules/cpp_style.py:
1341         * Scripts/modules/cpp_style_unittest.py:
1342
1343 2009-12-03  Chris Fleizach  <cfleizach@apple.com>
1344
1345         Reviewed by Eric Seidel.
1346
1347         AX: VO just says "term" on many web sites
1348         https://bugs.webkit.org/show_bug.cgi?id=32139
1349
1350         * DumpRenderTree/AccessibilityUIElement.cpp:
1351         (getRoleDescriptionCallback):
1352         (AccessibilityUIElement::getJSClass):
1353         * DumpRenderTree/AccessibilityUIElement.h:
1354         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1355         (AccessibilityUIElement::roleDescription):
1356         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1357         (AccessibilityUIElement::roleDescription):
1358         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1359         (AccessibilityUIElement::roleDescription):
1360
1361 2009-12-03  Chris Fleizach  <cfleizach@apple.com>
1362
1363         Reviewed by Beth Dakin.
1364
1365         Implement WAI-ARIA scrollbar role and related property aria-orientation
1366         https://bugs.webkit.org/show_bug.cgi?id=32126
1367
1368         * DumpRenderTree/AccessibilityUIElement.cpp:
1369         (getOrientationCallback):
1370         (AccessibilityUIElement::getJSClass):
1371         * DumpRenderTree/AccessibilityUIElement.h:
1372         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1373         (AccessibilityUIElement::orientation):
1374         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1375         (AccessibilityUIElement::orientation):
1376         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1377         (AccessibilityUIElement::orientation):
1378
1379 2009-12-03  Eric Carlson  <eric.carlson@apple.com>
1380
1381         Reviewed by Adam Roben.
1382
1383         Minor correction to r51663.
1384
1385         * DumpRenderTree/win/DumpRenderTree.cpp:
1386         (addQTDirToPATH):
1387             GetEnvironmentVariable -> GetEnvironmentVariableW.
1388
1389 2009-12-03  Eric Carlson  <eric.carlson@apple.com>
1390
1391         Reviewed by Adam Roben.
1392
1393         ~96 regression tests fail when using QuickTime 7.6 (they pass with QuickTime 7.3)
1394         https://bugs.webkit.org/show_bug.cgi?id=30256
1395
1396         Add the QuickTime dll directory to the PATH environment variable so
1397         inialization can succeed.
1398
1399         * DumpRenderTree/win/DumpRenderTree.cpp:
1400         (addQTDirToPATH):
1401         (initialize):
1402
1403 2009-12-03  Shu Chang  <Chang.Shu@nokia.com>
1404
1405         Reviewed by Kenneth Rohde Christiansen.
1406
1407         [Qt] After revision 32643, sender() is of type QWebPage instead of QWebFrame.
1408
1409         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1410         (LayoutTestController::maybeDump):
1411
1412 2009-12-03  Yuzo Fujishima  <yuzo@google.com>
1413
1414         Reviewed by Eric Seidel.
1415
1416         Update pywebsocket to 0.4.3
1417         This version logs friendlier and higher-level messages in WARN level, which is used for LayoutTests.
1418         Stack trace is logged now in INFO level.
1419         https://bugs.webkit.org/show_bug.cgi?id=32097
1420
1421         * pywebsocket/mod_pywebsocket/dispatch.py:
1422         * pywebsocket/mod_pywebsocket/msgutil.py:
1423         * pywebsocket/mod_pywebsocket/standalone.py:
1424         * pywebsocket/mod_pywebsocket/util.py:
1425         * pywebsocket/setup.py:
1426         * pywebsocket/test/test_dispatch.py:
1427         * pywebsocket/test/test_util.py:
1428
1429 2009-12-03  Sam Weinig  <sam@webkit.org>
1430
1431         Reviewed by Gavin Barraclough.
1432
1433         Fix JSClassRef leak.
1434
1435         * DumpRenderTree/AccessibilityController.cpp:
1436         (AccessibilityController::makeWindowObject):
1437         * DumpRenderTree/GCController.cpp:
1438         (GCController::makeWindowObject):
1439         * DumpRenderTree/LayoutTestController.cpp:
1440         (LayoutTestController::makeWindowObject):
1441
1442 2009-12-03  Brady Eidson  <beidson@apple.com>
1443
1444         Reviewed by Sam Weinig.
1445
1446         <rdar://problem/7214236> and http://webkit.org/b/32052 - Implement HTML5 state object history API
1447
1448         Keep DRT-win building...
1449
1450         * DumpRenderTree/win/FrameLoadDelegate.h:
1451         (FrameLoadDelegate::didPushStateWithinPageForFrame):
1452         (FrameLoadDelegate::didReplaceStateWithinPageForFrame):
1453         (FrameLoadDelegate::didPopStateWithinPageForFrame):
1454
1455 2009-12-03  Andras Becsi  <abecsi@inf.u-szeged.hu>
1456
1457         Unreviewed build fix.
1458
1459         [Qt] ARM-Linux build fix after r51634 removed unused QBoxLayout include which included limits.h on ARM.
1460
1461         * DumpRenderTree/qt/DumpRenderTree.cpp:
1462
1463 2009-12-03  Andras Becsi  <abecsi@inf.u-szeged.hu>
1464
1465         Reviewed by Kenneth Rohde Christiansen.
1466
1467         [Qt] Refactor DRT to not crash on tests which open child windows from javascript.
1468         Prevent DRT from showing the main view if these childs get deleted.
1469         This fixes https://bugs.webkit.org/show_bug.cgi?id=31591.
1470
1471         * DumpRenderTree/qt/DumpRenderTree.cpp:
1472         (WebCore::WebPage::WebPage):
1473         (WebCore::DumpRenderTree::DumpRenderTree):
1474         (WebCore::DumpRenderTree::~DumpRenderTree):
1475         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1476         (WebCore::DumpRenderTree::open):
1477         (WebCore::DumpRenderTree::closeRemainingWindows):
1478         (WebCore::DumpRenderTree::createWindow):
1479         (WebCore::DumpRenderTree::windowCount):
1480         * DumpRenderTree/qt/DumpRenderTree.h:
1481
1482 2009-12-02  Eric Seidel  <eric@webkit.org>
1483
1484         Reviewed by Adam Barth.
1485
1486         REGRESSION(51595): commit-queue is throwing exceptions
1487         https://bugs.webkit.org/show_bug.cgi?id=32083
1488
1489         * Scripts/modules/commands/queues.py:
1490          - Don't use default value of [] as it ends up getting shared.
1491          - Make log_progress accept arrays of ints as well as strings.
1492          - Return an exit code from execute()
1493         * Scripts/modules/commands/queues_unittest.py: Added.
1494          - Test to make sure log_progress will accept ints.
1495          - Test to make sure run_bugzilla_tool will accept ints.
1496         * Scripts/modules/workqueue.py:
1497          - Print the stack trace on unexpected exceptions for easier debugging.
1498         * Scripts/run-webkit-unittests:
1499          - Add queues_unittest.
1500
1501         * Scripts/modules/commands/queues.py:
1502         * Scripts/modules/commands/queues_unittest.py: Copied from WebKitTools/Scripts/modules/commands/commandtest.py.
1503         * Scripts/modules/mock_bugzillatool.py:
1504         * Scripts/modules/workqueue.py:
1505         * Scripts/run-webkit-unittests:
1506
1507 2009-12-02  David Levin  <levin@chromium.org>
1508
1509         Reviewed by Adam Barth.
1510
1511         check-webkit-style is too noisy about namespace indenting issues.
1512         https://bugs.webkit.org/show_bug.cgi?id=32096
1513
1514         * Scripts/modules/cpp_style.py:
1515         Added a _FileState object to be able to track file level information. In this
1516         case, it simply tracks whether the error has already been given, so that it isn't
1517         done again.
1518         * Scripts/modules/cpp_style_unittest.py:
1519         Modified test cases to pass in the _FileState object and fix a test that expected
1520         to see the namespace error twice (now it only occurs once). No new tests because
1521         existing tests cover the change in functionality.
1522
1523 2009-12-01  Kevin Ollivier  <kevino@theolliviers.com>
1524
1525         Reviewed by Eric Seidel.
1526
1527         [wx] Get DumpRenderTree building after waf switch.
1528         
1529         https://bugs.webkit.org/show_bug.cgi?id=32041
1530
1531         * DumpRenderTree/wscript: Added.
1532         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1533         (LayoutTestController::setTimelineProfilingEnabled):
1534         (LayoutTestController::evaluateScriptInIsolatedWorld):
1535         (LayoutTestController::disableImageLoading):
1536         (LayoutTestController::whiteListAccessFromOrigin):
1537         (LayoutTestController::counterValueForElementById):
1538         * Scripts/build-webkit:
1539
1540 2009-12-02  Adam Barth  <abarth@webkit.org>
1541
1542         Reviewed by Eric Seidel.
1543
1544         [bzt] build-attachment shouldn't check whether the builders are red
1545         https://bugs.webkit.org/show_bug.cgi?id=32062
1546
1547         build-attachment doesn't touch the remote repository, so there isn't a
1548         need to hold off when the builders are red.
1549
1550         * Scripts/modules/commands/download.py:
1551         * Scripts/modules/landingsequence.py:
1552
1553 2009-12-02  Eric Seidel  <eric@webkit.org>
1554
1555         Reviewed by Adam Barth.
1556
1557         REGRESSION(51590): style-queue and build-queue think their empty when they are not
1558         https://bugs.webkit.org/show_bug.cgi?id=32061
1559
1560         * Scripts/modules/bugzilla.py: make all id lookups return ints instead of strings.
1561         * Scripts/modules/bugzilla_unittest.py: Add and update unit tests to use ints.
1562
1563 2009-12-02  Eric Seidel  <eric@webkit.org>
1564
1565         Reviewed by Adam Barth.
1566
1567         build-queue is throwing exceptions and complaining about
1568         lack of --no-update on build-attachment.  Make it stop.
1569
1570         * Scripts/modules/buildsteps.py:
1571         * Scripts/modules/commands/download.py:
1572
1573 2009-12-02  Adam Barth  <abarth@webkit.org>
1574
1575         Unreviewed "build" fix.  Forgot to declare my variables.  :(
1576
1577         * QueueStatusServer/queue_status.py:
1578
1579 2009-12-02  Adam Barth  <abarth@webkit.org>
1580
1581         Reviewed by Eric Seidel.
1582
1583         [bzt] Implement status bubble view
1584         https://bugs.webkit.org/show_bug.cgi?id=32057
1585
1586         The status bubble is a compact representation of the queue status for a
1587         given patch.  This will eventually help us reduce the comment spam from
1588         the queues.
1589
1590         * QueueStatusServer/index.html: Added HTML5 doctype for sanity.
1591         * QueueStatusServer/queue_status.py:
1592         * QueueStatusServer/status_bubble.html: Added.
1593
1594 2009-12-02  Eric Seidel  <eric@webkit.org>
1595
1596         Reviewed by Adam Barth.
1597
1598         trim commands/*.py includes now that commands are unit tested
1599         https://bugs.webkit.org/show_bug.cgi?id=32056
1600
1601         In the course of ensuring that the unit tests still
1602         passed after this change, I had to actually make them
1603         pass in the first place.
1604
1605         * Scripts/modules/bugzilla.py:
1606          - Fix _parse_attachment_ids_request_query to return ints instead of strings.
1607         * Scripts/modules/commands/download.py: Remove unneeded imports.
1608         * Scripts/modules/commands/queries.py: Ditto.
1609         * Scripts/modules/commands/queues.py: Ditto.
1610         * Scripts/modules/commands/upload.py: Ditto.
1611         * Scripts/modules/scm_unittest.py:
1612          - Fix to expect the \n after the path since echo adds an \n.
1613
1614 2009-12-01  Yaar Schnitman  <yaar@chromium.org>
1615
1616         build-webkit: Remove flex,bison,gperf check for chromium
1617         https://bugs.webkit.org/show_bug.cgi?id=32043
1618
1619         * Scripts/webkitdirs.pm:
1620
1621 2009-12-01  Chris Fleizach  <cfleizach@apple.com>
1622
1623         Build fixage for Windows/GTK for DumpRenderTree.
1624
1625         WAI-ARIA: implement support for ARIA drag and drop
1626         https://bugs.webkit.org/show_bug.cgi?id=32007
1627
1628         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1629         (AccessibilityUIElement::ariaIsGrabbed):
1630         (AccessibilityUIElement::ariaDropEffects):
1631         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1632         (AccessibilityUIElement::ariaIsGrabbed):
1633         (AccessibilityUIElement::ariaDropEffects):
1634
1635 2009-12-01  Chris Fleizach  <cfleizach@apple.com>
1636
1637         Reviewed by Darin Adler.
1638
1639         WAI-ARIA: implement support for ARIA drag and drop
1640         https://bugs.webkit.org/show_bug.cgi?id=32007
1641
1642         * DumpRenderTree/AccessibilityUIElement.cpp:
1643         (getARIADropEffectsCallback):
1644         (getARIAIsGrabbedCallback):
1645         (AccessibilityUIElement::getJSClass):
1646         * DumpRenderTree/AccessibilityUIElement.h:
1647         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1648         (AccessibilityUIElement::ariaIsGrabbed):
1649         (AccessibilityUIElement::ariaDropEffects):
1650
1651 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
1652
1653         Not reviewed. GTK DRT try 2.
1654
1655         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1656         (LayoutTestController::sampleSVGAnimationForElementAtTime):
1657
1658 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
1659
1660         Not reviewed. Try to fix gtk DRT build.
1661
1662         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1663
1664 2009-12-01  David Levin  <levin@chromium.org>
1665
1666         Reviewed by Eric Seidel.
1667
1668         check-webkit-style does not understand (Prefix)Foo(Custom|Gtk|CG|Mac).cpp including Foo.h
1669         https://bugs.webkit.org/show_bug.cgi?id=32033
1670
1671         * Scripts/modules/cpp_style.py: Changed check for a possible primary header to use find
1672                                         instead of startswith.
1673         * Scripts/modules/cpp_style_unittest.py: Added a unit test for the new behavior.
1674
1675 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
1676
1677         Not reviewed. Qt build almost fixed, DumpRenderTree should compile now as well.
1678
1679         * DumpRenderTree/qt/LayoutTestControllerQt.h: Update old function signature.
1680
1681 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
1682
1683         Reviewed by Simon Fraser.
1684
1685         Add SVG animation test framework with 'snapshot' functionality
1686         https://bugs.webkit.org/show_bug.cgi?id=31897
1687
1688         Add new 'sampleSVGAnimationForElementAtTime' DRT method,
1689         used by the new SVG animation testing framework, implemented
1690         for qt/gtk/win/mac.
1691
1692         * DumpRenderTree/LayoutTestController.cpp:
1693         (sampleSVGAnimationForElementAtTimeCallback):
1694         (LayoutTestController::staticFunctions):
1695         * DumpRenderTree/LayoutTestController.h:
1696         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1697         (LayoutTestController::sampleSVGAnimationForElementAtTime):
1698         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1699         (LayoutTestController::sampleSVGAnimationForElementAtTime):
1700         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1701         (LayoutTestController::sampleSVGAnimationForElementAtTime):
1702         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1703         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1704         (LayoutTestController::sampleSVGAnimationForElementAtTime):
1705         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1706         (LayoutTestController::sampleSVGAnimationForElementAtTime):
1707
1708 2009-12-01  Adam Roben  <aroben@apple.com>
1709
1710         Remove user content before running each test on Windows
1711
1712         Fixes <http://webkit.org/b/31479> Make websocket tests work on Windows
1713
1714         Reviewed by Alexey Proskuryakov.
1715
1716         * DumpRenderTree/win/DumpRenderTree.cpp:
1717         (resetWebViewToConsistentStateBeforeTesting): Remove all user content
1718         before each test, which matches Mac.
1719
1720 2009-12-01  Yuzo Fujishima  <yuzo@google.com>
1721
1722         Reviewed by Alexey Proskuryakov.
1723
1724         Make pywebsocket log errors to a file
1725         https://bugs.webkit.org/show_bug.cgi?id=31604
1726
1727         * Scripts/run-webkit-tests: Log output to a pywebsocket_log.txt file in results directory
1728         (by passing the path to the server via a recently added -l option).
1729
1730 2009-12-01  Adam Roben  <aroben@apple.com>
1731
1732         Fix tests that use the TestNetscapePlugin in Debug_Internal builds
1733
1734         Reviewed by Ada Chan.
1735
1736         Fixes <http://webkit.org/b/32027> REGRESSION (r49705): Tests that use
1737         TestNetscapePlugin fail in Debug_Internal builds
1738
1739         * DumpRenderTree/win/DumpRenderTree.cpp: Use the "_Debug" plugin
1740         directory in Debug and Debug_All builds, but not in Debug_Internal
1741         builds.
1742
1743 2009-12-01  Adam Roben  <aroben@apple.com>
1744
1745         Re-enable DRT's watchdog timer on Windows
1746
1747         It was accidentally disabled in r50907.
1748
1749         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1750         (LayoutTestController::setWaitToDump): Remove a "false &&" that snuck
1751         into an if condition.
1752
1753 2009-12-01  Adam Barth  <abarth@webkit.org>
1754
1755         Reviewed by Eric Seidel.
1756
1757         check-webkit-style complains about #imports with / in them
1758         https://bugs.webkit.org/show_bug.cgi?id=32022
1759
1760         We need to exclude #import directives in addition to #include from the
1761         binary operator whitespace checks.
1762
1763         * Scripts/modules/cpp_style.py:
1764         * Scripts/modules/cpp_style_unittest.py:
1765
1766 2009-11-30  Adam Barth  <abarth@webkit.org>
1767
1768         Reviewed by Eric Seidel.
1769
1770         check-webkit-style is slightly too verbose
1771         https://bugs.webkit.org/show_bug.cgi?id=32010
1772
1773         check-webkit-style prints out a bunch of "done" lines that seem redundant,
1774         especially for the style-queue.
1775
1776         * Scripts/modules/cpp_style.py:
1777
1778 2009-11-30  Alejandro G. Castro  <alex@igalia.com>
1779
1780         Reviewed by Eric Seidel.
1781
1782         [GTK] Moved the functions that are closing the result log of the
1783         tests to the last line of the runTest function, this avoids
1784         reporting crashes in the wrong test if there is a problem when
1785         reseting the state after the test.
1786
1787         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1788         (dump):
1789         (runTest):
1790
1791 2009-11-30  Sam Weinig  <sam@webkit.org>
1792
1793         Reviewed by Geoffrey Garen.
1794
1795         Fix for https://bugs.webkit.org/show_bug.cgi?id=31286
1796         fast/js/date-proto-generic-invocation breaks another test
1797
1798         Don't cache JSClassRefs, a change to the prototype chain will
1799         last between tests.
1800
1801         * DumpRenderTree/AccessibilityController.cpp:
1802         (AccessibilityController::getJSClass):
1803         * DumpRenderTree/GCController.cpp:
1804         (GCController::getJSClass):
1805         * DumpRenderTree/GCController.h:
1806         * DumpRenderTree/LayoutTestController.cpp:
1807         (LayoutTestController::getJSClass):
1808
1809 2009-11-30  Yuzo Fujishima  <yuzo@google.com>
1810
1811         Reviewed by Alexey Proskuryakov.
1812
1813         Update pywebsocket to 0.4.2.1.
1814         This is to fix a bug that some messages are logged to stderr even when the log file is specified.
1815         https://bugs.webkit.org/show_bug.cgi?id=31976
1816
1817         * pywebsocket/mod_pywebsocket/standalone.py:
1818         * pywebsocket/setup.py:
1819
1820 2009-11-30  Adam Barth  <abarth@webkit.org>
1821
1822         Reviewed by Eric Seidel.
1823
1824         [bzt] Generate pass messages for style-queue
1825         https://bugs.webkit.org/show_bug.cgi?id=31995
1826
1827         With this change, the style-queue posts "pass" messages to bugs as
1828         well.  Also, added more information to the state store w.r.t. passing
1829         and failing.
1830
1831         * Scripts/modules/commands/queues.py:
1832         * Scripts/modules/patchcollection.py:
1833
1834 2009-11-30  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1835
1836         Reviewed by Simon Fraser.
1837
1838         Check for WEBKIT_TESTFONTS environment variable in
1839         run-webkit-tests, for GTK+, to have a more prominent error
1840         message.
1841
1842         * Scripts/run-webkit-tests:
1843
1844 2009-11-30  Yaar Schnitman  <yaar@chromium.org>
1845
1846         Reviewed by Dimitri Glazkov.
1847
1848         update-webkit --chromium forces gclient sync
1849
1850         https://bugs.webkit.org/show_bug.cgi?id=31967
1851
1852         * Scripts/update-webkit-chromium:
1853
1854 2009-11-29  Eric Seidel  <eric@webkit.org>
1855
1856         Add Erik Arvidsson to committers.py since by r51326 he clear has commit rights.
1857
1858         * Scripts/modules/committers.py:
1859
1860 2009-11-29  Eric Seidel  <eric@webkit.org>
1861
1862         No review, just adding missing svn property.
1863
1864         Set svn:executable property on new scripts.
1865         These were added by commit-queue commits, but the executable
1866         property was lost due to a bug in svn-apply:
1867         https://bugs.webkit.org/show_bug.cgi?id=27204
1868
1869         * Scripts/update-webkit-chromium: Added property svn:executable.
1870         * Scripts/validate-committer-lists: Added property svn:executable.
1871
1872 2009-11-29  Eric Seidel  <eric@webkit.org>
1873
1874         Reviewed by Adam Barth.
1875
1876         Need a way to validate that committers.py includes all committers/reviewers
1877         https://bugs.webkit.org/show_bug.cgi?id=30970
1878
1879         Add a script which knows how to compare our public committer/reviewer
1880         lists and show discrepancies between them.
1881
1882         Validates mailing lists vs. committers.py:
1883         - committers.py committers missing from webkit-committers@lists
1884         - webkit-committers@lists members missing from committers.py
1885         - committers.py reviewers missing from webkit-reviewers@lists
1886         - webkit-reviewers@lists members missing from committers.py
1887         - webkit-reviewers@lists members missing from committers.py reviewer list
1888
1889         Validates committers.py vs. trunk/ SVN history:
1890         - committers who have not committed in over a year
1891         - SVN committers missing from committers.py
1892         - committers.py members who have no record in SVN.
1893
1894         All of these lists still show "false positives" until a few more committers.py updates are made, like:
1895         https://bugs.webkit.org/show_bug.cgi?id=31366
1896
1897         * Scripts/validate-committer-lists: Added.
1898
1899 2009-11-28  Adam Barth  <abarth@webkit.org>
1900
1901         Reviewed by Eric Seidel.
1902
1903         [bzt] style-queue sends ~100 requests to QueueStatusServer every 5 minutes
1904         https://bugs.webkit.org/show_bug.cgi?id=31950
1905
1906         Now we cache the last status that we get back from QueueStatusServer.
1907         Eventually we'll have to do something more fancy if we want to support
1908         a "try again" button on QueueStatusServer, but we can cross that bridge
1909         when we come to it.
1910
1911         * Scripts/modules/patchcollection.py:
1912
1913 2009-11-28  Adam Barth  <abarth@webkit.org>
1914
1915         Reviewed by Eric Seidel.
1916
1917         StyleQueue scans ~100 bug pages every 5 minutes
1918         https://bugs.webkit.org/show_bug.cgi?id=31947
1919
1920         Instead of getting the pending-review attachment ids by scanning each
1921         bug (which results in a network request), we should just get them all
1922         from webkit.org/pending-review in one shot.
1923
1924         * Scripts/modules/bugzilla.py:
1925         * Scripts/modules/bugzilla_unittest.py:
1926         * Scripts/modules/commands/queries.py:
1927         * Scripts/modules/commands/queries_unittest.py:
1928         * Scripts/modules/commands/queues.py:
1929         * Scripts/modules/mock_bugzillatool.py:
1930         * Scripts/modules/patchcollection.py:
1931
1932 2009-11-28  Adam Barth  <abarth@webkit.org>
1933
1934         Reviewed by Eric Seidel.
1935
1936         [bzt] CC webkit-bot-watchers whenever the bots touch bugs
1937         https://bugs.webkit.org/show_bug.cgi?id=31952
1938
1939         The mailing list is open for anyone to subscribe.
1940
1941         * Scripts/modules/bugzilla.py:
1942         * Scripts/modules/commands/queues.py:
1943
1944 2009-11-28  Adam Barth  <abarth@webkit.org>
1945
1946         Reviewed by Eric Seidel.
1947
1948         [bzt] style-queue should report style errors to bugzilla
1949         https://bugs.webkit.org/show_bug.cgi?id=31945
1950
1951         Currently, we're just logging the style errors locally.  With this
1952         patch we'll actually log the errors to bugzilla.  Note: I plan to run
1953         with the "local-only" logging during development.
1954
1955         * Scripts/modules/commands/queues.py:
1956         * Scripts/modules/scm.py:
1957
1958 2009-11-28  Adam Barth  <abarth@webkit.org>
1959
1960         Reviewed by Eric Seidel.
1961
1962         [bzt] style-queue shouldn't reject patches from the commit-queue
1963         https://bugs.webkit.org/show_bug.cgi?id=31944
1964
1965         Currently the style-queue subprocess gets confused and thinks its the
1966         commit-queue.  If the patch has an error, it rejects it from the
1967         commit-queue.  Instead, we should have style-queue specific logic.
1968         This patch doesn't add that logic, but it gives us a callback we can
1969         use to add that logic.
1970
1971         * Scripts/modules/buildsteps.py:
1972         * Scripts/modules/commands/queues.py:
1973         * Scripts/modules/landingsequence.py:
1974
1975 2009-11-27  Adam Barth  <abarth@webkit.org>
1976
1977         Rubber stamped by Eric Seidel.
1978
1979         Rename CommitQueueStatus to QueueStatusServer to allow for more queues.
1980
1981         * CommitQueueStatus: Removed.
1982         * CommitQueueStatus/app.yaml: Removed.
1983         * CommitQueueStatus/filters: Removed.
1984         * CommitQueueStatus/filters/__init__.py: Removed.
1985         * CommitQueueStatus/filters/webkit_extras.py: Removed.
1986         * CommitQueueStatus/index.html: Removed.
1987         * CommitQueueStatus/index.yaml: Removed.
1988         * CommitQueueStatus/queue_status.py: Removed.
1989         * CommitQueueStatus/stylesheets: Removed.
1990         * CommitQueueStatus/stylesheets/main.css: Removed.
1991         * CommitQueueStatus/update_status.html: Removed.
1992         * QueueStatusServer: Copied from WebKitTools/CommitQueueStatus.
1993
1994 2009-11-27  Adam Barth  <abarth@webkit.org>
1995
1996         Reviewed by Eric Seidel.
1997
1998         style-queue should only process each patch once
1999         https://bugs.webkit.org/show_bug.cgi?id=31939
2000
2001         Actually address reviewer comments!
2002
2003         * Scripts/bugzilla-tool:
2004
2005 2009-11-27  Adam Barth  <abarth@webkit.org>
2006
2007         Reviewed by Eric Seidel.
2008
2009         [bzt] style-queue fails to apply a bunch of patches for no reason
2010         https://bugs.webkit.org/show_bug.cgi?id=31942
2011
2012         By passing --non-interactive to check-style, we convince check-style
2013         to pass --force to svn-apply, which lets it apply more patches.
2014
2015         * Scripts/modules/commands/queues.py:
2016
2017 2009-11-27  Adam Barth  <abarth@webkit.org>
2018
2019         Reviewed by Eric Seidel.
2020
2021         [bzt] Support --status-host in style-queue
2022         https://bugs.webkit.org/show_bug.cgi?id=31941
2023
2024         * Scripts/modules/commands/queues.py:
2025         * Scripts/modules/statusbot.py:
2026
2027 2009-11-27  Adam Barth  <abarth@webkit.org>
2028
2029         Reviewed by Eric Seidel.
2030
2031         style-queue should only process each patch once
2032         https://bugs.webkit.org/show_bug.cgi?id=31939
2033
2034         Before processing a patch, the try-queues now ask the web service
2035         whether they have already processed the patch.  This is an initial cut
2036         of this functionality.  I expect we're make it richer over time.
2037
2038         * Scripts/bugzilla-tool:
2039         * Scripts/modules/commands/queues.py:
2040         * Scripts/modules/patchcollection.py:
2041
2042 2009-11-27  Adam Barth  <abarth@webkit.org>
2043
2044         Reviewed by Eric Seidel.
2045
2046         PatchStatus does not return status
2047         https://bugs.webkit.org/show_bug.cgi?id=31938
2048
2049         We need to parse attachment_id as an int.  Otherwise, we can't find
2050         anything in the datastore.
2051
2052         * CommitQueueStatus/queue_status.py:
2053
2054 2009-11-27  Adam Barth  <abarth@webkit.org>
2055
2056         Reviewed by Eric Seidel.
2057
2058         Make commit-queue status not throw an exception where there is not
2059         status
2060         https://bugs.webkit.org/show_bug.cgi?id=31936
2061
2062         We need to actually fetch the results of the query to see what's in the
2063         datastore.
2064
2065         * CommitQueueStatus/queue_status.py:
2066
2067 2009-11-27  Adam Barth  <abarth@webkit.org>
2068
2069         Reviewed by Eric Seidel.
2070
2071         [bzt] unit test ApplyPatches and ApplyAttachment
2072         https://bugs.webkit.org/show_bug.cgi?id=31935
2073
2074         * Scripts/modules/commands/download.py:
2075         * Scripts/modules/commands/download_unittest.py:
2076
2077 2009-11-27  Adam Barth  <abarth@webkit.org>
2078
2079         Reviewed by Eric Seidel.
2080
2081         [bzt] Unit test download commands
2082         https://bugs.webkit.org/show_bug.cgi?id=31923
2083
2084         Adds download_unittest and fixes a bug found while testing.
2085
2086         * Scripts/modules/commands/commandtest.py:
2087         * Scripts/modules/commands/download.py:
2088             Fixed a bug where we'd throw an error because [].append returns
2089             None.
2090         * Scripts/modules/commands/download_unittest.py: Added.
2091         * Scripts/modules/mock_bugzillatool.py:
2092         * Scripts/run-webkit-unittests:
2093
2094 2009-11-27  Adam Barth  <abarth@webkit.org>
2095
2096         Unreviewed "build" fix found while writing unit tests.
2097
2098         * Scripts/modules/commands/download.py:
2099
2100 2009-11-27  Adam Barth  <abarth@webkit.org>
2101
2102         Reviewed by Eric Seidel.
2103
2104         [bzt] Kill WebKitLandingScripts
2105         https://bugs.webkit.org/show_bug.cgi?id=31904
2106
2107         Step 6: Kill the rest.
2108
2109         * Scripts/modules/buildsteps.py:
2110         * Scripts/modules/commands/download.py:
2111         * Scripts/modules/commands/queries.py:
2112         * Scripts/modules/commands/upload.py:
2113         * Scripts/modules/landingsequence.py:
2114         * Scripts/modules/scm.py:
2115         * Scripts/modules/webkitlandingscripts.py: Removed.
2116
2117 2009-11-27  Adam Barth  <abarth@webkit.org>
2118
2119         Reviewed by Eric Seidel.
2120
2121         [bzt] Unit test upload commands
2122         https://bugs.webkit.org/show_bug.cgi?id=31903
2123
2124         Adds unit tests for all but two of the upload commands.  The two
2125         remaining ones are more difficult.  I'll return to them later.  The
2126         goal of these tests is just to run the commands.  We can test more
2127         detailed behavior later.
2128
2129         * Scripts/modules/commands/commandtest.py:
2130         * Scripts/modules/commands/upload.py:
2131         * Scripts/modules/commands/upload_unittest.py:
2132         * Scripts/modules/mock.py: Added.
2133         * Scripts/modules/mock_bugzillatool.py:
2134
2135 2009-11-26  Adam Barth  <abarth@webkit.org>
2136
2137         Reviewed by Eric Seidel.
2138
2139         [bzt] Kill WebKitLandingScripts
2140         https://bugs.webkit.org/show_bug.cgi?id=31904
2141
2142         Step 5: Kill run_and_throw_if_fail.
2143
2144         * Scripts/modules/buildsteps.py:
2145         * Scripts/modules/processutils.py: Added.
2146         * Scripts/modules/webkitlandingscripts.py:
2147
2148 2009-11-26  Adam Barth  <abarth@webkit.org>
2149
2150         Reviewed by Eric Seidel.
2151
2152         [bzt] Kill WebKitLandingScripts
2153         https://bugs.webkit.org/show_bug.cgi?id=31904
2154
2155         Step 4: Kill run_webkit_script.
2156
2157         * Scripts/modules/buildsteps.py:
2158         * Scripts/modules/commands/download.py:
2159         * Scripts/modules/webkitlandingscripts.py:
2160
2161 2009-11-26  Adam Barth  <abarth@webkit.org>
2162
2163         Reviewed by Eric Seidel.
2164
2165         [bzt] Kill WebKitLandingScripts
2166         https://bugs.webkit.org/show_bug.cgi?id=31904
2167
2168         Step 3: Kill build_webkit.
2169
2170         * Scripts/modules/buildsteps.py:
2171         * Scripts/modules/landingsequence.py:
2172         * Scripts/modules/webkitlandingscripts.py:
2173
2174 2009-11-26  Adam Barth  <abarth@webkit.org>
2175
2176         Reviewed by Eric Seidel.
2177
2178         [bzt] Kill WebKitLandingScripts
2179         https://bugs.webkit.org/show_bug.cgi?id=31904
2180
2181         Step 2: Kill ensure_builders_are_green.
2182
2183         * Scripts/modules/buildsteps.py:
2184         * Scripts/modules/commands/download.py:
2185         * Scripts/modules/landingsequence.py:
2186         * Scripts/modules/webkitlandingscripts.py:
2187
2188 2009-11-26  Adam Barth  <abarth@webkit.org>
2189
2190         Reviewed by Eric Seidel.
2191
2192         [bzt] Kill WebKitLandingScripts
2193         https://bugs.webkit.org/show_bug.cgi?id=31904
2194
2195         Step 1: Kill prepare_clean_working_directory and run_webkit_tests.
2196
2197         * Scripts/bugzilla-tool:
2198         * Scripts/modules/buildsteps.py: Added.
2199         * Scripts/modules/commands/download.py:
2200         * Scripts/modules/landingsequence.py:
2201         * Scripts/modules/webkitlandingscripts.py:
2202
2203 2009-11-26  Zoltan Horvath  <zoltan@webkit.org>
2204
2205         Reviewed by Adam Barth.
2206
2207         Remove directory prefixes from linux commands
2208
2209         SCM unittests can cause errors on some systems if we use absolute reference to
2210         the commands, so directory prefixes have been removed.
2211
2212         * Scripts/modules/scm_unittest.py:
2213
2214 2009-11-21  Holger Hans Peter Freyther  <zecke@selfish.org>
2215
2216         Reviewed by Kenneth Rohde Christiansen.
2217
2218         Link DumpRenderTree to the Qt Ui Tools
2219         https://bugs.webkit.org/show_bug.cgi?id=31203
2220
2221         Implement QWebPage::createPlugin using the Qt Ui Tools
2222         to be able to create classes like QProgressBar from within
2223         the <object></object> tags This is required for the
2224         new automatic test of Qt Plugins.
2225
2226         * DumpRenderTree/qt/DumpRenderTree.cpp:
2227         (WebCore::WebPage::createPlugin):
2228         * DumpRenderTree/qt/DumpRenderTree.h:
2229         * DumpRenderTree/qt/DumpRenderTree.pro:
2230
2231 2009-11-25  Yuzo Fujishima  <yuzo@google.com>
2232
2233         Reviewed by Eric Seidel.
2234
2235         Update pywebsocket to 0.4.2
2236
2237         Update pywebsocket to 0.4.2
2238         https://bugs.webkit.org/show_bug.cgi?id=31861
2239
2240         * pywebsocket/example/echo_client.py:
2241         * pywebsocket/example/echo_wsh.py:
2242         * pywebsocket/mod_pywebsocket/__init__.py:
2243         * pywebsocket/mod_pywebsocket/dispatch.py:
2244         * pywebsocket/mod_pywebsocket/msgutil.py:
2245         * pywebsocket/mod_pywebsocket/standalone.py:
2246         * pywebsocket/setup.py:
2247         * pywebsocket/test/test_dispatch.py:
2248         * pywebsocket/test/test_msgutil.py:
2249
2250 2009-11-25  Adam Barth  <abarth@webkit.org>
2251
2252         Reviewed by Eric Seidel.
2253
2254         Add unit test for mark-fixed
2255         https://bugs.webkit.org/show_bug.cgi?id=31896
2256
2257         * Scripts/modules/commands/commandtest.py: Added.
2258         * Scripts/modules/commands/queries_unittest.py:
2259         * Scripts/modules/commands/upload_unittest.py: Added.
2260         * Scripts/modules/mock_bugzillatool.py:
2261         * Scripts/run-webkit-unittests:
2262
2263 2009-11-25  Adam Barth  <abarth@webkit.org>
2264
2265         Reviewed by Eric Seidel.
2266
2267         bugzilla-tool should have a mark-fixed command
2268         https://bugs.webkit.org/show_bug.cgi?id=31853
2269
2270         Pretty simple stuff.
2271
2272         * Scripts/modules/commands/upload.py:
2273
2274 2009-11-25  Eric Seidel  <eric@webkit.org>
2275
2276         Reviewed by Adam Barth.
2277
2278         'bugzilla-tool help' should only show common commands like how 'git help' does
2279         https://bugs.webkit.org/show_bug.cgi?id=31772
2280
2281         I also took this opportunity to make 'help' a real Command.
2282         Making 'help' a real command required adding Command.tool (which we've wanted to do for a while).
2283
2284         * Scripts/bugzilla-tool:
2285          - change should_show_command_help to should_show_in_main_help
2286         * Scripts/modules/commands/download.py:
2287          - Mark commands as being shown in main help or not.
2288          - show_in_main_help = False is not required (default is false),
2289            but it seemed to make the commands more self-documenting.
2290         * Scripts/modules/commands/queries.py: ditto
2291         * Scripts/modules/commands/queues.py: ditto
2292         * Scripts/modules/commands/upload.py: ditto
2293         * Scripts/modules/multicommandtool.py:
2294          - Make Command hold a pointer to tool in self.tool.  Most Command
2295            subclasses do not take advantage of this yet, but it was required
2296            for HelpCommand to be able to reach the tool from _help_epilog().
2297          - Move MultiCommandTool._standalone_help_for_command to Command.standalone_help
2298          - Move MultiCommandTool._help_epilog to Command._help_epilog
2299          - Move "help" logic into HelpCommand.execute()
2300          - Change should_show_command_help to should_show_in_main_help and add a default implementation.
2301         * Scripts/modules/multicommandtool_unittest.py:
2302          - Test hiding of Commands in --help, and that all commands are shown in 'help --all-commands'
2303
2304 2009-11-25  Brian Weinstein  <bweinstein@apple.com>
2305
2306         Reviewed by Dan Bernstein.
2307         
2308         Patch by Mark Rowe.
2309
2310         The buildbots are failing on Windows because when they were upgraded
2311         to 4.0.4, Apple Application Support was not in their path. Add it to
2312         the path to fix the buildots.
2313
2314         * Scripts/webkitdirs.pm:
2315
2316 2009-11-25  Csaba Osztrogonác  <ossy@webkit.org>
2317
2318         Reviewed by David Kilzer.
2319
2320         run-webkit-tests doesn't accept directories/files with --skipped=only parameter
2321         https://bugs.webkit.org/show_bug.cgi?id=31799
2322
2323         * Scripts/run-webkit-tests: Fixed.
2324
2325 2009-11-25  Zoltan Horvath  <zoltan@webkit.org>
2326
2327         Reviewed by Eric Seidel.
2328
2329         Change run_command to give back stderr by default
2330         https://bugs.webkit.org/show_bug.cgi?id=31734
2331
2332         Change run_command to give back stderr by default.
2333         Set run_commands's 'svn-create-patch' calling to put only the stdout into the patches.
2334         Change the related unittest call.
2335
2336         * Scripts/modules/scm.py:
2337         * Scripts/modules/scm_unittest.py:
2338
2339 2009-11-25  Eric Seidel  <eric@webkit.org>
2340
2341         Reviewed by Adam Barth.
2342
2343         Centralize required argument parsing in Command
2344         https://bugs.webkit.org/show_bug.cgi?id=31872
2345
2346         * Scripts/modules/commands/download.py: remove custom required arg message.
2347         * Scripts/modules/commands/upload.py: ditto.
2348         * Scripts/modules/multicommandtool.py:
2349          - Add _parse_required_arguments.
2350          - Pass program name off to OptionParser.
2351          - Add name() for access to tool name.
2352          - Add check_arguments_and_execute and make it return a return code.
2353          - Replace a couple uses of + with %.
2354         * Scripts/modules/multicommandtool_unittest.py: test _parse_required_arguments
2355
2356 2009-11-25  Eric Seidel  <eric@webkit.org>
2357
2358         Reviewed by Adam Barth.
2359
2360         Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests.
2361         https://bugs.webkit.org/show_bug.cgi?id=31870
2362
2363         * Scripts/modules/commands/queries_unittest.py: Use the new class.
2364         * Scripts/modules/multicommandtool_unittest.py: Ditto.
2365         * Scripts/modules/outputcapture.py: Added.
2366
2367 2009-11-24  Dmitry Titov  <dimich@chromium.org>
2368
2369         Reviewed by Eric Seidel.
2370
2371         Add ENABLE_SHARED_SCRIPT feature define and flag for build-webkit
2372         https://bugs.webkit.org/show_bug.cgi?id=31444
2373
2374         * Scripts/build-webkit:
2375
2376 2009-11-24  Chris Marrin  <cmarrin@apple.com>
2377
2378         Reviewed by Simon Fraser.
2379
2380         Changes the way 3D_RENDERING and ACCELERATED_COMPOSITING related tests are excluded
2381         https://bugs.webkit.org/show_bug.cgi?id=27314
2382         
2383         Now the script allows the directories with these tests to be included on all
2384         platforms but Mac, where they behave the same as always. For all other platforms
2385         the tests need to be excluded using the Skipped files, which is currently done
2386         for all platforms (including win since we're not turned on yet)
2387
2388         * Scripts/webkitdirs.pm:
2389
2390 2009-11-24  Eric Seidel  <eric@webkit.org>
2391
2392         Reviewed by Adam Barth.
2393
2394         queries_unittest.py should test command output
2395         https://bugs.webkit.org/show_bug.cgi?id=31845
2396
2397         * Scripts/modules/commands/queries_unittest.py:
2398          - Capture stdout and stderr and compare with expected strings.
2399
2400 2009-11-24  Simon Fraser  <simon.fraser@apple.com>
2401
2402         No Review.
2403
2404         Fix spelling error ("depenedencies").
2405
2406         * Scripts/build-webkit:
2407
2408 2009-11-24  Mark Rowe  <mrowe@apple.com>
2409
2410         Land the configuration that includes the two debug GTK Linux builders.
2411
2412         * BuildSlaveSupport/build.webkit.org-config/config.json:
2413
2414 2009-11-24  David Kilzer  <ddkilzer@apple.com>
2415
2416         <http://webkit.org/b/31840> bisect-builds broke after r50080
2417
2418         Reviewed by Dan Bernstein.
2419
2420         * Scripts/bisect-builds:
2421         (mountAndRunNightly): Switched back to using backticks to run
2422         the hdiutil command since exec() will terminate the existing
2423         script, which is not what we want.  Store the output of
2424         File::Spec->devnull() in a variable for use in the hdiutil
2425         detach commands.
2426
2427 2009-11-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2428
2429         Reviewed by Kenneth Rohde Christiansen.
2430
2431         Include "config.h" to meet Coding Style Guidelines
2432         https://bugs.webkit.org/show_bug.cgi?id=31792
2433
2434         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
2435         * DumpRenderTree/qt/jsobjects.cpp:
2436         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2437
2438 2009-11-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2439
2440         Reviewed by Oliver Hunt.
2441
2442         Implement new required function to pass test we used to pass. This
2443         change is required since r51294.
2444
2445         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2446         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
2447
2448 2009-11-23  Jakub Wieczorek  <faw217@gmail.com>
2449
2450         Reviewed by Kenneth Rohde Christiansen.
2451
2452         [Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
2453         https://bugs.webkit.org/show_bug.cgi?id=31775
2454
2455         LayoutTestController::dumpBackForwardList() should work with local URLs
2456         as well as with normal URLs (in http tests for instance).
2457         Currently it does not output the latter properly.
2458
2459         Unskip a bunch of passing http/navigation tests.
2460
2461         * DumpRenderTree/qt/DumpRenderTree.cpp:
2462         (WebCore::dumpHistoryItem):
2463
2464 2009-11-22  Chris Fleizach  <cfleizach@apple.com>
2465
2466         Reviewed by Oliver Hunt.
2467
2468         ARIA: support aria-flowto
2469         https://bugs.webkit.org/show_bug.cgi?id=31762
2470
2471         * DumpRenderTree/AccessibilityUIElement.cpp:
2472         (ariaFlowToElementAtIndexCallback):
2473         (AccessibilityUIElement::getJSClass):
2474         * DumpRenderTree/AccessibilityUIElement.h:
2475         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2476         (AccessibilityUIElement::ariaFlowToElementAtIndex):
2477         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2478         (AccessibilityUIElement::ariaFlowToElementAtIndex):
2479         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2480         (AccessibilityUIElement::ariaFlowToElementAtIndex):
2481
2482 2009-11-22  Antonio Gomes  <tonikitoo@webkit.org>
2483
2484         Reviewed by Kenneth Christiansen.
2485
2486         [Qt] fast/history/back-forward-reset-after-error-handling.html failing due to WorkQueue not being un-frozen
2487         https://bugs.webkit.org/show_bug.cgi?id=31638
2488
2489         Unfreeze WorkQueue after each test execution.
2490
2491         * DumpRenderTree/qt/DumpRenderTree.cpp:
2492         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2493
2494 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
2495
2496         Reviewed by Adam Barth.
2497
2498         [Qt] DumpRenderTree should explicitly ignore any SSL certificate errors
2499         for localhost and 127.0.0.1.
2500         https://bugs.webkit.org/show_bug.cgi?id=31783
2501
2502         Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now.
2503
2504         * DumpRenderTree/qt/DumpRenderTree.cpp:
2505         (WebCore::NetworkAccessManager::NetworkAccessManager):
2506         (WebCore::NetworkAccessManager::sslErrorsEncountered):
2507         (WebCore::WebPage::WebPage):
2508         * DumpRenderTree/qt/DumpRenderTree.h:
2509
2510 2009-11-22  Chris Evans  <cevans@chromium.org>
2511
2512         Reviewed by Adam Barth.
2513
2514         Disable access to file:/// directory listings
2515         https://bugs.webkit.org/show_bug.cgi?id=31329
2516
2517         Implemented setAllowUniversalAccessFromFileURLs to support testing of
2518         file URL security.
2519
2520         * DumpRenderTree/LayoutTestController.cpp:
2521         (setAllowUniversalAccessFromFileURLsCallback):
2522         (LayoutTestController::staticFunctions):
2523         * DumpRenderTree/LayoutTestController.h:
2524         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2525         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
2526         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2527         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
2528         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2529         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
2530         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2531         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
2532
2533 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
2534
2535         Reviewed by Kenneth Rohde Christiansen.
2536
2537         [Qt] Fix the timeout of fast/frames/frame-navigation.html
2538         https://bugs.webkit.org/show_bug.cgi?id=31638
2539
2540         The test is timeouting, because it uses the WorkQueue to load a document in one
2541         of the child frames and once the loading is finished, the DRT does not dump the
2542         tree. This is because it waits for the QWebFrame::loadFinished() signal from
2543         the main frame, while it should connect to QWebPage::loadFinished().
2544
2545         * DumpRenderTree/qt/DumpRenderTree.cpp:
2546         (WebCore::DumpRenderTree::DumpRenderTree):
2547
2548 2009-11-21  Eric Seidel  <eric@webkit.org>
2549
2550         Reviewed by Adam Barth.
2551
2552         bugzilla-tool --help spews way too much text
2553         https://bugs.webkit.org/show_bug.cgi?id=31771
2554
2555         * Scripts/bugzilla-tool:
2556          - Remove self.cached_scm initialization hack.
2557         * Scripts/modules/buildbot.py:
2558          - Make default_host accessible to callers.
2559         * Scripts/modules/commands/download.py:
2560          - Phrase help for all commands consistently and remove spurious help text punctuation.
2561         * Scripts/modules/commands/queries.py: Ditto.
2562         * Scripts/modules/commands/queues.py: Ditto.
2563         * Scripts/modules/commands/upload.py: Ditto.
2564         * Scripts/modules/multicommandtool.py:
2565          - Add HelpPrintingOptionParser.format_epilog to replace
2566            NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize
2567            per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
2568          - Make --help only show a list of commands like "svn help" and "git help" do --
2569            previously --help was listing all commands and options.
2570          - Sort list of commands alphabetically.
2571
2572 2009-11-21  Eric Seidel  <eric@webkit.org>
2573
2574         No review.  Fixing a typo from the previous patch for bug 31767.
2575
2576         AbstractQueue.run_bugzilla_tool throws an exception
2577         https://bugs.webkit.org/show_bug.cgi?id=31769
2578
2579         * Scripts/modules/commands/queues.py:
2580
2581 2009-11-21  Eric Seidel  <eric@webkit.org>
2582
2583         Reviewed by Adam Barth.
2584
2585         commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
2586         https://bugs.webkit.org/show_bug.cgi?id=31767
2587
2588         What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
2589         Since we don't have a good way to test BugzillaTool pieces, I've
2590         left out a test for now.
2591
2592         * Scripts/bugzilla-tool:
2593          - Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue.
2594         * Scripts/modules/commands/queues.py:
2595          - Use tool.path() instead of __file__.
2596         * Scripts/modules/multicommandtool.py:
2597          - Add a new path() method to MultiComandTool.
2598         * Scripts/modules/multicommandtool_unittest.py:
2599          - Provide a path() method.  Little point in testing this mock implementation.
2600
2601 2009-11-21  Adam Barth  <abarth@webkit.org>
2602
2603         Unreviewed "build" fix.  Turns out I was testing the wrong copy of
2604         WebKitTools.
2605
2606         * Scripts/modules/commands/download.py:
2607
2608 2009-11-21  Adam Barth  <abarth@webkit.org>
2609
2610         Reviewed by Eric Seidel.
2611
2612         Convert check-style to use LandingSequence
2613         https://bugs.webkit.org/show_bug.cgi?id=31763
2614
2615         Instead of manipulating the working copy by hand, we should use the
2616         LandingSequence in CheckStyle.  This will make this code eaiser to
2617         test.
2618
2619         * Scripts/modules/commands/download.py:
2620
2621 2009-11-20  Adam Barth  <abarth@webkit.org>
2622
2623         Reviewed by Eric Seidel.
2624
2625         Unit test query commands
2626         https://bugs.webkit.org/show_bug.cgi?id=31755
2627
2628         These tests are pretty rough, but hopefully they'll grow.
2629
2630         * Scripts/modules/commands/queries_unittest.py: Added.
2631         * Scripts/modules/mock_bugzillatool.py: Added.
2632         * Scripts/run-webkit-unittests:
2633
2634 2009-11-20  Eric Seidel  <eric@webkit.org>
2635
2636         Reviewed by Adam Barth.
2637
2638         Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
2639         https://bugs.webkit.org/show_bug.cgi?id=31758
2640
2641         * Scripts/modules/multicommandtool.py:
2642          - Allow passing of explicit commands to MultiCommandTool.__init__
2643         * Scripts/modules/multicommandtool_unittest.py:
2644          - Use new Command.name naming system.
2645          - Test Command auto-discovery.
2646         * Scripts/modules/workqueue.py:
2647          - bug_id no longer exists, use patch['bug_id'] instead.
2648         * Scripts/modules/workqueue_unittest.py:
2649          - WorkQueues require names now.
2650          - should_proceed_with_work_item must return a patch object.
2651
2652 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
2653
2654         Reviewed by Beth Dakin.
2655
2656         WAI-ARIA: add support for aria-owns
2657         https://bugs.webkit.org/show_bug.cgi?id=31702
2658
2659         * DumpRenderTree/AccessibilityUIElement.cpp:
2660         (ariaOwnsElementAtIndexCallback):
2661         (AccessibilityUIElement::getJSClass):
2662         * DumpRenderTree/AccessibilityUIElement.h:
2663         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2664         (AccessibilityUIElement::ariaOwnsElementAtIndex):
2665         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2666         (AccessibilityUIElement::ariaOwnsElementAtIndex):
2667         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2668         (AccessibilityUIElement::ariaOwnsElementAtIndex):
2669
2670 2009-11-20  Eric Seidel  <eric@webkit.org>
2671
2672         Reviewed by Adam Barth.
2673
2674         Fix exception thrown when running the commit-queue.
2675
2676         * Scripts/modules/statusbot.py: patch is optional.
2677         * Scripts/modules/workqueue.py: WorkQUeue requires a name.
2678
2679 2009-11-20  Eric Seidel  <eric@webkit.org>
2680
2681         Reviewed by Adam Barth.
2682
2683         Teach the StatusBot how to support more than just the commit-queue
2684         https://bugs.webkit.org/show_bug.cgi?id=31754
2685
2686         * Scripts/modules/workqueue.py: Another typo.
2687
2688 2009-11-20  Eric Seidel  <eric@webkit.org>
2689
2690         Reviewed by Adam Barth.
2691
2692         Teach the StatusBot how to support more than just the commit-queue
2693         https://bugs.webkit.org/show_bug.cgi?id=31754
2694
2695         * Scripts/modules/commands/queues.py: Fix silly typo.
2696
2697 2009-11-20  Eric Seidel  <eric@webkit.org>
2698
2699         Reviewed by Adam Barth.
2700
2701         Teach the StatusBot how to support more than just the commit-queue
2702         https://bugs.webkit.org/show_bug.cgi?id=31754
2703
2704         * CommitQueueStatus/index.yaml:
2705          - Add indices required for the new queries.
2706         * CommitQueueStatus/queue_status.py:
2707          - Add a patch-status page and move update_status to update-status.
2708          - Only display "commit-queue" status records for the commit-queue.
2709          - Add support for a queue_name property on status records.
2710          - Fix _int_from_request to actually work.
2711         * CommitQueueStatus/update_status.html:
2712          - Add support for a queue_name on status records.
2713          - Remove unused list of bug ids.
2714          * Scripts/modules/commands/queues.py
2715           - Make the queues pass the patch instead of the bug_id to StatusBot.
2716         * Scripts/modules/statusbot.py:
2717          - Support passing the queue_name to the status updates.
2718          - Support fetching patch status with patch_status().
2719         * Scripts/modules/workqueue.py:
2720          - Pass the patch to the StatusBot instead of the bug_id.
2721          - Let WorkQueues have a name.
2722
2723 2009-11-20  Adam Barth  <abarth@webkit.org>
2724
2725         Reviewed by Eric Seidel.
2726
2727         Move bugzilla-tool commands into their own file
2728         https://bugs.webkit.org/show_bug.cgi?id=31752
2729
2730         This will let us write unit tests.
2731
2732         * Scripts/bugzilla-tool:
2733         * Scripts/modules/commands/__init__.py: Added.
2734         * Scripts/modules/commands/download.py: Added.
2735         * Scripts/modules/commands/queries.py: Added.
2736         * Scripts/modules/commands/queues.py: Added.
2737         * Scripts/modules/commands/upload.py: Added.
2738         * Scripts/modules/grammar.py: Added.
2739
2740 2009-11-20  Adam Barth  <abarth@webkit.org>
2741
2742         Reviewed by Eric Seidel.
2743
2744         BuildQueue should check if the tree is currently buildable
2745         https://bugs.webkit.org/show_bug.cgi?id=31744
2746
2747         * Scripts/bugzilla-tool:
2748         * Scripts/modules/landingsequence.py:
2749         * Scripts/modules/webkitlandingscripts.py:
2750
2751 2009-11-20  Adam Barth  <abarth@webkit.org>
2752
2753         Reviewed by Eric Seidel.
2754
2755         Move prepare_clean_working_directory into the LandingSequence
2756         https://bugs.webkit.org/show_bug.cgi?id=31743
2757
2758         * Scripts/bugzilla-tool:
2759         * Scripts/modules/landingsequence.py:
2760
2761 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
2762
2763         Reviewed by Kenneth Rohde Christiansen.
2764
2765         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
2766         https://bugs.webkit.org/show_bug.cgi?id=30460
2767
2768         Added code for calling NPN_ReloadPlugins with reloadPages true and false.
2769
2770         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2771         (pluginInvoke):
2772
2773 2009-11-20  Adam Barth  <abarth@webkit.org>
2774
2775         Reviewed by Eric Seidel.
2776
2777         Pass the port information to the child process
2778         https://bugs.webkit.org/show_bug.cgi?id=31736
2779
2780         We need to do this so the child process knows what to build!
2781
2782         * Scripts/bugzilla-tool:
2783         * Scripts/modules/landingsequence.py:
2784         * Scripts/modules/webkitport.py:
2785         * Scripts/modules/webkitport_unittest.py:
2786
2787 2009-11-20  Adam Barth  <abarth@webkit.org>
2788
2789         Reviewed by Eric Seidel.
2790
2791         Support Qt port in build-queue
2792         https://bugs.webkit.org/show_bug.cgi?id=31733
2793
2794         * Scripts/bugzilla-tool:
2795
2796 2009-11-20  Adam Barth  <abarth@webkit.org>
2797
2798         Reviewed by Eric Seidel.
2799
2800         Implement a build-queue
2801         https://bugs.webkit.org/show_bug.cgi?id=31725
2802
2803         Currently this just builds the first 10 patches in the review queue.
2804         We'll want to do something smarter soon.
2805
2806         * Scripts/bugzilla-tool:
2807
2808 2009-11-20  Adam Barth  <abarth@webkit.org>
2809
2810         Reviewed by Eric Seidel.
2811
2812         Make commit-queue and style-queue show up in help
2813         https://bugs.webkit.org/show_bug.cgi?id=31724
2814
2815         We need to store their names on their class to make these commands
2816         properly register themselves with MultiCommandTool.
2817
2818         * Scripts/bugzilla-tool:
2819
2820 2009-11-20  Adam Barth  <abarth@webkit.org>
2821
2822         Reviewed by Eric Seidel.
2823
2824         Implement bugzilla-tool build-attachment
2825         https://bugs.webkit.org/show_bug.cgi?id=31722
2826
2827         This command builds an attachment from bugzilla.  It leaves the built
2828         patch in the working copy.
2829
2830         * Scripts/bugzilla-tool:
2831         * Scripts/modules/landingsequence.py:
2832         * Scripts/modules/webkitlandingscripts.py:
2833
2834 2009-11-20  Alejandro G. Castro  <alex@igalia.com>
2835
2836         Reviewed by Xan Lopez.
2837
2838         [GTK] DRT release event does not create the state correctly
2839         https://bugs.webkit.org/show_bug.cgi?id=31717
2840
2841         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2842
2843 2009-11-20  Eric Seidel  <eric@webkit.org>
2844
2845         Reviewed by Adam Barth.
2846
2847         MultiCommandTool should find Command objects automatically instead of with a manual list
2848         https://bugs.webkit.org/show_bug.cgi?id=31710
2849
2850         * Scripts/bugzilla-tool:
2851         * Scripts/modules/multicommandtool.py:
2852          - Use some wild python-fu to crawl all the known subclasses of Command.
2853
2854 2009-11-20  Adam Barth  <abarth@webkit.org>
2855
2856         Unreviewed "build" fix.  Added missing import.
2857
2858         * Scripts/bugzilla-tool:
2859
2860 2009-11-20  Adam Barth  <abarth@webkit.org>
2861
2862         Unreviewed "build" fix.  I failed to update LandingSequence.test
2863         properly.
2864
2865         * Scripts/modules/landingsequence.py:
2866
2867 2009-11-20  Adam Barth  <abarth@webkit.org>
2868
2869         Reviewed by Eric Seidel.
2870
2871         Create LandingSequence as the all-sing, all-dance landing class
2872         https://bugs.webkit.org/show_bug.cgi?id=31709
2873
2874         Client can inherit from this class to carefully control exactly which
2875         steps they wish to have happen in the landing sequence.
2876
2877         * Scripts/bugzilla-tool:
2878         * Scripts/modules/landingsequence.py: Added.
2879         * Scripts/modules/webkitlandingscripts.py: Added.
2880
2881 2009-11-19  Adam Barth  <abarth@webkit.org>
2882
2883         Reviewed by Eric Seidel.
2884
2885         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
2886         https://bugs.webkit.org/show_bug.cgi?id=31707
2887
2888         This is to help when we implement build-attachment.
2889
2890         * Scripts/bugzilla-tool:
2891
2892 2009-11-19  Adam Barth  <abarth@webkit.org>
2893
2894         Reviewed by Eric Seidel.
2895
2896         Support Qt port in bugzilla-tool
2897         https://bugs.webkit.org/show_bug.cgi?id=31701
2898
2899         Now we support building with Qt!
2900
2901         * Scripts/bugzilla-tool:
2902         * Scripts/modules/webkitport.py: Added.
2903         * Scripts/modules/webkitport_unittest.py: Added.
2904         * Scripts/run-webkit-unittests:
2905
2906 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
2907
2908         Reviewed by Adam Barth.
2909
2910         Remove inserting stderr into patch in bugzilla-tool
2911         https://bugs.webkit.org/show_bug.cgi?id=29914
2912
2913         Modify SCM python module's run_command function to avoid return of stderr
2914         by default, so stderr won't be inserted into the patches.
2915         Modify the related unit test.
2916
2917         * Scripts/modules/scm.py:
2918         * Scripts/modules/scm_unittest.py:
2919
2920 2009-11-19  Eric Seidel  <eric@webkit.org>
2921
2922         Reviewed by Adam Barth.
2923
2924         bugzilla-tool needs per-command help
2925         https://bugs.webkit.org/show_bug.cgi?id=31697
2926
2927         Added support for "bugzilla-tool help command-name"
2928         and a unit test to make sure it works.
2929
2930         * Scripts/modules/multicommandtool.py:
2931         * Scripts/modules/multicommandtool_unittest.py:
2932
2933 2009-11-19  Eric Seidel  <eric@webkit.org>
2934
2935         Reviewed by Adam Barth.
2936
2937         Move MultiCommandTool and Command into a separate file and add some basic unit tests
2938         https://bugs.webkit.org/show_bug.cgi?id=31695
2939
2940         * Scripts/bugzilla-tool:
2941         * Scripts/modules/multicommandtool.py: Added.
2942         * Scripts/modules/multicommandtool_unittest.py: Added.
2943         * Scripts/run-webkit-unittests:
2944
2945 2009-11-19  Eric Seidel  <eric@webkit.org>
2946
2947         No review, just adding a FIXME.
2948
2949         Split out command parsing and help printing from BugzillaTool
2950         https://bugs.webkit.org/show_bug.cgi?id=31688
2951
2952         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
2953
2954 2009-11-19  Eric Seidel  <eric@webkit.org>
2955
2956         Reviewed by Adam Barth.
2957
2958         Split out command parsing and help printing from BugzillaTool
2959         https://bugs.webkit.org/show_bug.cgi?id=31688
2960
2961         * Scripts/bugzilla-tool:
2962          - Add new MultiCommandTool class to contain option parsing and help printing logic.
2963          - Rename private methods to use _ pattern.
2964          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
2965          - 
2966
2967 2009-11-19  Eric Seidel  <eric@webkit.org>
2968
2969         Reviewed by Adam Barth.
2970
2971         Re-factor help printing to use modern python idioms
2972         https://bugs.webkit.org/show_bug.cgi?id=31685
2973
2974         * Scripts/bugzilla-tool:
2975
2976 2009-11-19  Eric Seidel  <eric@webkit.org>
2977
2978         Reviewed by Darin Adler.
2979
2980         commit-queue empty queue logs twice
2981         https://bugs.webkit.org/show_bug.cgi?id=31679
2982
2983         * Scripts/bugzilla-tool:
2984
2985 2009-11-19  Eric Seidel  <eric@webkit.org>
2986
2987         Reviewed by Darin Adler.
2988
2989         bugzilla-tool's reviewer/committer rejection message should be clearer
2990         https://bugs.webkit.org/show_bug.cgi?id=31126
2991
2992         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
2993
2994         * Scripts/modules/bugzilla.py:
2995
2996 2009-11-19  Eric Z. Ayers  <zundel@google.com>
2997
2998         Reviewed by Pavel Feldman.
2999
3000         Forces a WM_PAINT event on calling layoutTestController.display()
3001         in order to enable the timeline-paint.html test on Windows.
3002         ::UpdateWindow() does not force an event becaue the window is 
3003         not visible.
3004
3005         https://bugs.webkit.org/show_bug.cgi?id=31402
3006
3007         * DumpRenderTree/win/DumpRenderTree.cpp:
3008         (displayWebView):
3009
3010 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
3011
3012         No review needed.
3013
3014         Added myself to committers list.
3015
3016         * Scripts/modules/committers.py:
3017
3018 2009-11-19  Adam Barth  <abarth@webkit.org>
3019
3020         Reviewed by Eric Seidel.
3021
3022         Bugzilla-tool command classes should match command names
3023         https://bugs.webkit.org/show_bug.cgi?id=31666
3024
3025         I renamed all the commands except CommitMessageForCurrentDiff because
3026         the new name would conflict with an existing class.
3027
3028         * Scripts/bugzilla-tool:
3029
3030 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
3031
3032         Reviewed by Gustavo Noronha Silva.
3033
3034         Web Inspector: Implement "show inspector" in WebKit GTK
3035         API and enable console tests.
3036
3037         https://bugs.webkit.org/show_bug.cgi?id=31669
3038
3039         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3040         (LayoutTestController::showWebInspector):
3041
3042 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3043
3044         Reviewed by Simon Hausmann.
3045
3046         Minor refactoring + more documentation.
3047
3048         * DumpRenderTree/qt/DumpRenderTree.cpp:
3049         (WebCore::clearHistory):
3050         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3051
3052 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
3053
3054         Reviewed by Eric Seidel.
3055
3056         Ignore websocket tests when --no-http is specified.
3057         https://bugs.webkit.org/show_bug.cgi?id=31662
3058
3059         * Scripts/run-webkit-tests:
3060
3061 2009-11-18  Adam Barth  <abarth@webkit.org>
3062
3063         Reviewed by Eric Seidel.
3064
3065         Normalize ' and " in bugzilla-tool
3066         https://bugs.webkit.org/show_bug.cgi?id=31655
3067
3068         We decided " is better than ' and we should be consistent.
3069
3070         * Scripts/bugzilla-tool:
3071
3072 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3073
3074         Reviewed by Kenneth Rohde Christiansen.
3075
3076         [Qt] Remove support for Qt v4.3 or older versions
3077         https://bugs.webkit.org/show_bug.cgi?id=29469
3078
3079         * DumpRenderTree/qt/DumpRenderTree.pro:
3080         * DumpRenderTree/qt/ImageDiff.pro:
3081
3082 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
3083
3084         Reviewed by Eric Seidel.
3085
3086         GitTest.test_create_binary_patch fails if /tmp is symlink
3087         https://bugs.webkit.org/show_bug.cgi?id=31536
3088
3089         * Scripts/modules/scm_unittest.py:
3090
3091 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
3092
3093         Reviewed by Darin Adler.
3094
3095         Configuration for Chromium Build Slaves.
3096
3097         https://bugs.webkit.org/show_bug.cgi?id=31442
3098
3099         * BuildSlaveSupport/build.webkit.org-config/config.json:
3100         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3101
3102 2009-11-18  Eric Seidel  <eric@webkit.org>
3103
3104         Reviewed by Darin Adler.
3105
3106         workqueue.py results in totally broken commit-queue UI
3107         https://bugs.webkit.org/show_bug.cgi?id=31645
3108
3109         * Scripts/bugzilla-tool:
3110          - Remove unneeded use of PatchCollection.
3111          - Grab a new copy of the cq'd patches every run of the queue.
3112
3113 2009-11-18  Sam Weinig  <sam@webkit.org>
3114
3115         Reviewed by Anders Carlsson.
3116
3117         Make the Mac Geolocation API async.
3118
3119         Update DRT to use the new async Mac Geolocation API.
3120
3121         * DumpRenderTree/mac/UIDelegate.mm:
3122         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
3123
3124 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3125
3126         Reviewed by Kenneth Rohde Christiansen.
3127
3128         Add and option to toggle HTML5 datalist support to build-webkit
3129         https://bugs.webkit.org/show_bug.cgi?id=31599
3130
3131         * Scripts/build-webkit:
3132
3133 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
3134
3135         Reviewed by Kevin Ollivier.
3136
3137         Enable wx plugin support using the Windows implementation as a base.
3138         
3139         https://bugs.webkit.org/show_bug.cgi?id=31636
3140
3141         * wx/build/settings.py:
3142
3143 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3144
3145         Reviewed by Simon Hausmann.
3146
3147         Change the initialization order so that the controllers
3148         will be created before exporting them to the JS DOM window.
3149
3150         * DumpRenderTree/qt/DumpRenderTree.cpp:
3151         (WebCore::DumpRenderTree::DumpRenderTree):
3152
3153 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3154
3155         Reviewed by Simon Hausmann.
3156
3157         Fix a code copy and paste error. m_page should be page.
3158
3159         * DumpRenderTree/qt/DumpRenderTree.cpp:
3160         (WebCore::DumpRenderTree::createWindow):
3161
3162 2009-11-17  Mark Rowe  <mrowe@apple.com>
3163
3164         Reviewed by Alexey Proskuryakov.
3165
3166         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
3167
3168         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
3169         This prevents symlinks from confusing the descendant check.
3170
3171 2009-11-17  Mark Rowe  <mrowe@apple.com>
3172
3173         Reviewed by Alexey Proskuryakov.
3174
3175         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
3176
3177         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
3178         server to be up rather than having run-webkit-tests abort immediately.
3179
3180         * Scripts/run-webkit-tests:
3181
3182 2009-11-17  Eric Seidel  <eric@webkit.org>
3183
3184         Reviewed by Darin Adler.
3185
3186         commit-queue is failing to set reviewer in ChangeLogs
3187         https://bugs.webkit.org/show_bug.cgi?id=31592
3188
3189         * Scripts/bugzilla-tool: Clarify the "applying" log message.
3190         * Scripts/modules/bugzilla.py:
3191          - Add a new _validate_committer_and_reviewer function as a
3192            temporary solution until we can make a real Attachment object
3193            which knows how to fill in its committer/reviewer fields automatically.
3194
3195 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3196
3197         Unreviewed buildbot fix.
3198
3199         Revert part of earlier patch and add comment, as it
3200         was causing timeouts on the buildbot.
3201
3202         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3203         (LayoutTestController::notifyDone):
3204
3205 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3206
3207         Reviewed by Oliver Hunt.
3208
3209         Make the timeout 15 sec as for the other DRT's and make
3210         it print out the same output when a test timeout.
3211
3212         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3213         (LayoutTestController::waitUntilDone):
3214         (LayoutTestController::notifyDone):
3215         (LayoutTestController::timerEvent):
3216
3217 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
3218
3219         Reviewed by Timothy Hatcher.
3220
3221         Fixed typos in comments.
3222
3223         * Scripts/modules/committers.py:
3224
3225 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
3226
3227         Reviewed by Timothy Hatcher.
3228
3229         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
3230         - Updated DRT to show/close inspector for all tests under /inspector
3231         - Introduced LayoutTestController::setTimelineProfilingEnabled and
3232           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
3233         - Removed reload on each inspector test
3234         - Renamed fast/inspector to fast/inspector-support in order not to trigger
3235         inspector for those.
3236         - Reimplemented timeline tests in order to get rid of reload there.
3237         - Moved tests that don't require harness into the fast group.
3238
3239         https://bugs.webkit.org/show_bug.cgi?id=31472
3240
3241         * DumpRenderTree/LayoutTestController.cpp:
3242         (setTimelineProfilingEnabledCallback):
3243         (closeWebInspectorCallback):
3244         (LayoutTestController::staticFunctions):
3245         * DumpRenderTree/LayoutTestController.h:
3246         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3247         (shouldOpenWebInspector):
3248         (runTest):
3249         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3250         (LayoutTestController::setTimelineProfilingEnabled):
3251         * DumpRenderTree/mac/DumpRenderTree.mm:
3252         (shouldOpenWebInspector):
3253         (runTest):
3254         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3255         (LayoutTestController::setTimelineProfilingEnabled):
3256         * DumpRenderTree/win/DumpRenderTree.cpp:
3257         (shouldOpenWebInspector):
3258         (runTest):
3259         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3260         (LayoutTestController::setTimelineProfilingEnabled):
3261
3262 2009-11-17  Oliver Hunt  <oliver@apple.com>
3263
3264         Reviewed by Maciej Stachowiak.
3265
3266         Incorrect use of JavaScriptCore API in DumpRenderTree
3267         https://bugs.webkit.org/show_bug.cgi?id=31577
3268
3269         Return undefined rather than a literal null.
3270
3271         * DumpRenderTree/AccessibilityUIElement.cpp:
3272         (setSelectedTextRangeCallback):
3273         (incrementCallback):
3274         (decrementCallback):
3275         (showMenuCallback):
3276
3277 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
3278
3279         Reviewed by Beth Dakin.
3280
3281         AX: aria-labelledby duplicates some of its WAI-ARIA label
3282         https://bugs.webkit.org/show_bug.cgi?id=31565
3283
3284         * DumpRenderTree/AccessibilityUIElement.cpp:
3285         (titleUIElementCallback):
3286         (getIsValidCallback):
3287         (AccessibilityUIElement::getJSClass):
3288
3289 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3290
3291         Reviewed by Simon Hausmann.
3292
3293         r50942 broke output from created windows. Make the
3294         m_enableTextOutput a member of the DRT and not the
3295         WebPage.
3296
3297         * DumpRenderTree/qt/DumpRenderTree.cpp:
3298         (WebCore::WebPage::WebPage):
3299         (WebCore::WebPage::javaScriptAlert):
3300         (WebCore::WebPage::javaScriptConsoleMessage):
3301         (WebCore::WebPage::javaScriptConfirm):
3302         (WebCore::WebPage::javaScriptPrompt):
3303         (WebCore::WebPage::acceptNavigationRequest):
3304         (WebCore::DumpRenderTree::DumpRenderTree):
3305         (WebCore::DumpRenderTree::open):
3306         (WebCore::DumpRenderTree::createWindow):
3307         * DumpRenderTree/qt/DumpRenderTree.h:
3308         (WebCore::DumpRenderTree::setTextOutputEnabled):
3309         (WebCore::DumpRenderTree::isTextOutputEnabled):
3310         (WebCore::WebPage::shouldInterruptJavaScript):
3311         (WebCore::WebPage::isTextOutputEnabled):
3312         (WebCore::WebPage::setViewGeometry):
3313
3314 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3315
3316         Reviewed by Gustavo Noronha Silva.
3317
3318         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
3319         as the implementation is being used by at least Qt and Gtk+.
3320
3321         Update buildsystems as well.
3322
3323         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3324         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
3325         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
3326         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
3327         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3328         * GNUmakefile.am:
3329
3330 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
3331
3332         Reviewed by Alexey Proskuryakov.
3333
3334         Disable wss until all platforms support pyOpenSSL
3335
3336         https://bugs.webkit.org/show_bug.cgi?id=31479
3337
3338         * Scripts/run-webkit-tests:
3339
3340 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
3341
3342         Reviewed by Kenneth Christiansen.
3343
3344         [Qt] Implement load error pages support for Qt's DRT.
3345         https://bugs.webkit.org/show_bug.cgi?id=31509
3346
3347         For now, it will not be a default feature, and layout tests
3348         that want to make use of this have to explicitily call
3349         'handleErrorPages();' for the test source.
3350
3351         Any of the other DumpRenderTree's (mac, win and gtk)
3352         support handling error pages. Qt's will be the first.
3353
3354         * DumpRenderTree/qt/DumpRenderTree.cpp:
3355         (WebCore::WebPage::supportsExtension):
3356         (WebCore::WebPage::extension):
3357         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3358         (LayoutTestController::reset):
3359         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3360         (LayoutTestController::shouldHandleErrorPages):
3361         (LayoutTestController::handleErrorPages):
3362
3363 2009-11-16  Eric Seidel  <eric@webkit.org>
3364
3365         Reviewed by Adam Barth.
3366
3367         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
3368         https://bugs.webkit.org/show_bug.cgi?id=31549
3369
3370         Renamed --commit-queue to --non-interactive in most places
3371         and remove the code in land-patches which is no longer needed.
3372
3373         * Scripts/bugzilla-tool:
3374
3375 2009-11-16  Eric Seidel  <eric@webkit.org>
3376
3377         Reviewed by Adam Barth.
3378
3379         The commit-queue should use land-attachment
3380         https://bugs.webkit.org/show_bug.cgi?id=31548
3381
3382         * Scripts/bugzilla-tool:
3383
3384 2009-11-16  Adam Barth  <abarth@webkit.org>
3385
3386         Reviewed by Eric Seidel.
3387
3388         Convert CommitQueue over to PatchCollection
3389         https://bugs.webkit.org/show_bug.cgi?id=31547
3390
3391         Also fixes a bug in workqueue and adds a test!
3392
3393         * Scripts/bugzilla-tool:
3394         * Scripts/modules/workqueue.py:
3395         * Scripts/modules/workqueue_unittest.py:
3396
3397 2009-11-16  Adam Barth  <abarth@webkit.org>
3398
3399         Reviewed by Eric Seidel.
3400
3401         Move StyleQueue over to using PatchCollection
3402         https://bugs.webkit.org/show_bug.cgi?id=31544
3403
3404         That's what the class it's for.
3405
3406         * Scripts/bugzilla-tool:
3407         * Scripts/modules/patchcollection.py:
3408         * Scripts/modules/patchcollection_unittest.py:
3409
3410 2009-11-16  Eric Seidel  <eric@webkit.org>
3411
3412         Reviewed by Adam Barth.
3413
3414         bugzilla-tool needs a land-attachment command
3415         https://bugs.webkit.org/show_bug.cgi?id=31546
3416
3417         * Scripts/bugzilla-tool:
3418          - Move all the logic into AbstractLandingCommand and
3419            add a new LandAttachment command subclass.
3420          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
3421
3422 2009-11-16  Eric Seidel  <eric@webkit.org>
3423
3424         Reviewed by Adam Barth.
3425
3426         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
3427         https://bugs.webkit.org/show_bug.cgi?id=31543
3428
3429         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
3430
3431         * Scripts/bugzilla-tool:
3432
3433 2009-11-16  Eric Seidel  <eric@webkit.org>
3434
3435         Reviewed by Adam Barth.
3436
3437         Disable the style queue from posting to the commit queue status page.
3438
3439         * Scripts/bugzilla-tool:
3440
3441 2009-11-16  Adam Barth  <abarth@webkit.org>
3442
3443         Reviewed by Eric Seidel.
3444
3445         Implement PatchCollection
3446         https://bugs.webkit.org/show_bug.cgi?id=31541
3447
3448         This class holds a set of patches and lets clients iterate through
3449         them.  Optionally, clients can install a filter.
3450
3451         * Scripts/modules/patchcollection.py: Added.
3452         * Scripts/modules/patchcollection_unittest.py: Added.
3453         * Scripts/run-webkit-unittests:
3454
3455 2009-11-16  Eric Seidel  <eric@webkit.org>
3456
3457         Reviewed by Adam Barth.
3458
3459         bugzilla-tool land-patches will close bugs with patches r=?
3460         https://bugs.webkit.org/show_bug.cgi?id=28230
3461
3462         The commit-queue shouldn't close patches with outstanding reviews on them,
3463         even if many reviewers seem to be against multi-patch bugs.
3464
3465         * Scripts/bugzilla-tool:
3466
3467 2009-11-16  Eric Seidel  <eric@webkit.org>
3468
3469         Reviewed by Adam Barth.
3470
3471         bugzilla-tool check-style should work with attachment ids instead of bug ids
3472         https://bugs.webkit.org/show_bug.cgi?id=31540
3473
3474         * Scripts/bugzilla-tool:
3475
3476 2009-11-16  Eric Seidel  <eric@webkit.org>
3477
3478         Reviewed by Adam Barth.
3479
3480         WorkQueue is the only place that should know about special exit codes
3481         https://bugs.webkit.org/show_bug.cgi?id=31534
3482
3483         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
3484         and add tests for handling exit codes.
3485         I also cleaned up workqueue_unittest.py more.
3486
3487         * Scripts/bugzilla-tool:
3488         * Scripts/modules/workqueue.py:
3489         * Scripts/modules/workqueue_unittest.py:
3490
3491 2009-11-16  Eric Seidel  <eric@webkit.org>
3492
3493         Reviewed by Adam Barth.
3494
3495         Re-factor workqueue_unittest to allow for more than one test.
3496         https://bugs.webkit.org/show_bug.cgi?id=31535
3497
3498         * Scripts/modules/workqueue_unittest.py:
3499
3500 2009-11-16  Eric Seidel  <eric@webkit.org>
3501
3502         Reviewed by Adam Barth.
3503
3504         land-patches needs to be re-factored into smaller chunks
3505         https://bugs.webkit.org/show_bug.cgi?id=31532
3506
3507         * Scripts/bugzilla-tool: fix a couple obvious typos.
3508
3509 2009-11-16  Eric Seidel  <eric@webkit.org>
3510
3511         Reviewed by Adam Barth.
3512
3513         land-patches needs to be re-factored into smaller chunks
3514         https://bugs.webkit.org/show_bug.cgi?id=31532
3515
3516         The next patch will move these methods into WebKitLandingScripts.
3517
3518         * Scripts/bugzilla-tool:
3519          - Split out _land_patch and _close_bug_if_no_active_patches.
3520
3521 2009-11-16  Adam Barth  <abarth@webkit.org>
3522
3523         Reviewed by Eric Seidel.
3524
3525         Fix silly copy-and-paste code.  I am a terrible coder.
3526
3527         * Scripts/modules/bugzilla.py:
3528
3529 2009-11-16  Adam Barth  <abarth@webkit.org>
3530
3531         Reviewed by Eric Seidel.
3532
3533         Implement a StyleQueue
3534         https://bugs.webkit.org/show_bug.cgi?id=31537
3535
3536         The first iteration of the style queue only produces output locally.
3537         There is also a limit of 10 patches because it's not that useful to
3538         iterate through the entire review queue at this point.  We can remove
3539         the limit later.
3540
3541         * Scripts/bugzilla-tool:
3542         * Scripts/modules/bugzilla.py:
3543
3544 2009-11-16  Adam Barth  <abarth@webkit.org>
3545
3546         Reviewed by Eric Seidel.
3547
3548         Unit test WorkQueue
3549         https://bugs.webkit.org/show_bug.cgi?id=31531
3550
3551         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
3552
3553         * Scripts/bugzilla-tool:
3554         * Scripts/modules/statusbot.py:
3555         * Scripts/modules/workqueue.py:
3556         * Scripts/modules/workqueue_unittest.py: Added.
3557         * Scripts/run-webkit-unittests:
3558
3559 2009-11-16  Eric Seidel  <eric@webkit.org>
3560
3561         Reviewed by Adam Barth.
3562
3563         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
3564         https://bugs.webkit.org/show_bug.cgi?id=31530
3565
3566         * Scripts/bugzilla-tool:
3567
3568 2009-11-16  Eric Seidel  <eric@webkit.org>
3569
3570         Reviewed by Adam Barth.
3571
3572         bugzilla-tool needs apply-attachment
3573         https://bugs.webkit.org/show_bug.cgi?id=31528
3574
3575         * Scripts/bugzilla-tool:
3576          - Add ApplyAttachment command.
3577          - Abstract applying code into WebKitApplyingScripts.
3578          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
3579         * Scripts/modules/bugzilla.py:
3580          - Add fetch_attachment and bug_id_for_attachment_id.
3581         * Scripts/modules/bugzilla_unittest.py:
3582          - Add test for new parsing.
3583          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
3584
3585 2009-11-16  Eric Seidel  <eric@webkit.org>
3586
3587         Reviewed by Adam Barth.
3588
3589         Document check-style's use of force_clean.
3590
3591         * Scripts/bugzilla-tool:
3592         * Scripts/modules/scm.py:
3593
3594 2009-11-16  Adam Barth  <abarth@webkit.org>
3595
3596         Reviewed by Eric Seidel.
3597
3598         Move WorkQueue to its own file
3599         https://bugs.webkit.org/show_bug.cgi?id=31529
3600
3601         WorkQueue and WorkQueueDelegate are separate concerns from
3602         bugzilla-tool.  Also added a missing include to logging.py.
3603
3604         * Scripts/bugzilla-tool:
3605         * Scripts/modules/logging.py:
3606         * Scripts/modules/workqueue.py:
3607
3608 2009-11-16  Adam Barth  <abarth@webkit.org>
3609
3610         Reviewed by Eric Seidel.
3611
3612         Move OutputTee to logging.py.
3613
3614         * Scripts/bugzilla-tool:
3615         * Scripts/modules/logging.py:
3616
3617 2009-11-15  Adam Barth  <abarth@webkit.org>
3618
3619         Reviewed by Eric Seidel.
3620
3621         Refactor bugzilla-tool to allow for multiple queues
3622         https://bugs.webkit.org/show_bug.cgi?id=31513
3623
3624         Divide the commit queue class into three class to make creating
3625         additional queues easier.
3626
3627         * Scripts/bugzilla-tool:
3628
3629 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
3630
3631         Reviewed by Eric Seidel.
3632
3633         svn-apply may not handle git patches created by bugzilla-tool
3634         https://bugs.webkit.org/show_bug.cgi?id=31457
3635
3636         * Scripts/modules/scm.py:
3637         * Scripts/modules/scm_unittest.py:
3638
3639 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
3640
3641         Reviewed by Eric Seidel.
3642
3643         bugzilla-tool should post git binary diff
3644         https://bugs.webkit.org/show_bug.cgi?id=31458
3645
3646         Add --binary option to Git.create_patch.
3647
3648         * Scripts/modules/scm.py:
3649         * Scripts/modules/scm_unittest.py:
3650
3651 2009-11-15  Adam Barth  <abarth@webkit.org>
3652
3653         Reviewed by Darin Adler.
3654
3655         Add bugzilla-tool check-style
3656         https://bugs.webkit.org/show_bug.cgi?id=31515
3657
3658         * Scripts/bugzilla-tool:
3659         * Scripts/modules/bugzilla.py:
3660
3661 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3662
3663         Reviewed by Simon Hausmann.
3664
3665         Make the Qt Linux only --valgrind feature, suppress errors
3666         defined in the SuppressedValgrindErrors file.
3667
3668         * Scripts/run-webkit-tests:
3669
3670 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3671
3672         Reviewed by Simon Hausmann.
3673
3674         Set the locale to C and not to the current one in use on the system.
3675
3676         * DumpRenderTree/qt/DumpRenderTree.cpp:
3677         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3678
3679 2009-11-13  Adam Roben  <aroben@apple.com>
3680
3681         Add support for
3682         http/tests/security/isolatedWorld/didClearWindowObject.html
3683
3684         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
3685         window objects in isolated worlds are cleared
3686
3687         Reviewed by Dave Hyatt.
3688
3689         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
3690
3691         * DumpRenderTree/mac/FrameLoadDelegate.mm: