8c6b5c5529000d769542efdd343a321f1ac7b56b
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-07-14  Maciej Stachowiak  <mjs@apple.com>
2
3         Reviewed by Mark Rowe.
4
5         Lower WebKitTestRunner notifyDone timeout to 6.0 for now, to make it easier to grind through the failures.
6
7         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
8
9 2010-07-14  Sheriff Bot  <webkit.review.bot@gmail.com>
10
11         Unreviewed, rolling out r63346.
12         http://trac.webkit.org/changeset/63346
13         https://bugs.webkit.org/show_bug.cgi?id=42295
14
15         Broke lots of tests, some of which probably just need new
16         results (Requested by aroben on #webkit).
17
18         * DumpRenderTree/win/DumpRenderTree.cpp:
19         (urlSuitableForTestResult):
20
21 2010-07-14  Adam Roben  <aroben@apple.com>
22
23         Speed up killing of Apache on Windows
24
25         Fixes <http://webkit.org/b/42289> Killing Apache (and thus quitting
26         run-webkit-tests) takes a long time on Windows
27
28         Reviewed by Darin Adler and Jon Honeycutt.
29
30         * Scripts/webkitperl/httpd.pm:
31         (closeHTTPD): Use taskkill to kill Apache and its child processes.
32         Perl's kill seems ineffectual. We were already using taskkill, but
33         only after trying kill 20 times. Since kill never works, let's just
34         skip it entirely.
35
36 2010-07-14  Johnny Ding  <jnd@chromium.org>
37
38         Reviewed by Adam Barth.
39
40         https://bugs.webkit.org/show_bug.cgi?id=41292
41         Add a new parameter to the test plugin to allow to specify a script and a
42         mouse/keyboard event. The specified script will be evaluated in the browser
43         when the specified event is received by the plugin.
44
45         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
46         (pluginAllocate):
47         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
48         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
49         (NPP_New):
50         (handleEventCarbon):
51         (handleEventCocoa):
52
53 2010-07-14  Adam Roben  <aroben@apple.com>
54
55         Make urlSuitableForTestResult work for http: URLs, too
56
57         Fixes <http://webkit.org/b/42276>
58         http/tests/loading/preload-slow-loading.php and
59         http/tests/mime/uppercase-mime-type.html fail on Windows.
60
61         Reviewed by Darin Adler.
62
63         * DumpRenderTree/win/DumpRenderTree.cpp:
64         (urlSuitableForTestResult): Don't bail if the URL starts with http://.
65         We want this function to work for those URLs, too!
66
67 2010-07-13  Maciej Stachowiak  <mjs@apple.com>
68
69         Reviewed by Oliver Hunt.
70
71         Add placebo versions of some repaint test functions to WebKitTestRunner - good enough for non-pixel tests
72         https://bugs.webkit.org/show_bug.cgi?id=42227
73
74         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
75         (WTR::LayoutTestController::LayoutTestController): Initialize new bool
76         members.
77         (WTR::LayoutTestController::display): Dummy method.
78         (WTR::displayCallback): Call the dummy.
79         (WTR::repaintSweepHorizontallyCallback): ditto
80         (WTR::testRepaintCallback): ditto
81         (WTR::LayoutTestController::staticFunctions): Expose new methods.
82         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
83         (WTR::LayoutTestController::setTestRepaint): Set the flag (which currently does
84         nothing).
85         (WTR::LayoutTestController::setTestRepaintSweepHorizontally): ditto
86
87 2010-07-13  Andreas Kling  <andreas.kling@nokia.com>
88
89         Unreviewed. Adding myself as committer.
90
91         * Scripts/webkitpy/common/config/committers.py:
92
93 2010-07-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
94
95         Reviewed by Darin Adler.
96
97         Prevent assertion/duplicate loads for non-deferred subtitute-data loads
98
99         https://bugs.webkit.org/show_bug.cgi?id=30879
100
101         MainResourceLoader uses the member m_initialRequest to store requests for future
102         deferred loads. When doing the actual load in handleDataLoadNow(), we therefore
103         have to clear this request so that subsequent entries into the loader will not
104         start yet another load.
105
106         This can happen as a result of a PageGroupLoadDeferrer going out of scope when
107         returning from Chrome::runJavaScriptAlert(), which calls setDeferredLoading(false),
108         but only in the case of using both substitute-data and non-deferred main resource
109         load together. That's why two new DRT functions were added:
110
111          * queueLoadHTMLString()
112          * setDeferMainResourceLoad()
113
114         The change adds DRT hooks for Mac, Win and Qt for these two functions. For Mac
115         and Win the hook uses new SPI in WebDataSource. For Qt a new static member was
116         added to the FrameLoaderClientQt and accessed though DumpRenderTreeSupportQt.
117
118         * DumpRenderTree/LayoutTestController.cpp:
119         (LayoutTestController::LayoutTestController):
120         (queueLoadHTMLStringCallback):
121         (setDeferMainResourceDataLoadCallback):
122         (LayoutTestController::staticFunctions):
123         (LayoutTestController::queueLoadHTMLString):
124         * DumpRenderTree/LayoutTestController.h:
125         (LayoutTestController::deferMainResourceDataLoad):
126         (LayoutTestController::setDeferMainResourceDataLoad):
127         * DumpRenderTree/WorkQueueItem.h:
128         (LoadHTMLStringItem::LoadHTMLStringItem):
129         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
130         (LoadHTMLStringItem::invoke):
131         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
132         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
133         * DumpRenderTree/mac/WorkQueueItemMac.mm:
134         (LoadHTMLStringItem::invoke):
135         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
136         (LayoutTestController::reset):
137         (LayoutTestController::setDeferMainResourceDataLoad):
138         (LayoutTestController::queueLoadHTMLString):
139         * DumpRenderTree/qt/LayoutTestControllerQt.h:
140         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
141         (LoadHTMLStringItem::invoke):
142         * DumpRenderTree/qt/WorkQueueItemQt.h:
143         (LoadHTMLStringItem::LoadHTMLStringItem):
144         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
145         (ResourceLoadDelegate::willSendRequest):
146         * DumpRenderTree/win/WorkQueueItemWin.cpp:
147         (LoadHTMLStringItem::invoke):
148         * DumpRenderTree/wx/WorkQueueItemWx.cpp:
149         (LoadHTMLStringItem::invoke):
150
151 2010-07-13  Maciej Stachowiak  <mjs@apple.com>
152
153         Reviewed by Nikolas Zimmermann.
154
155         Activate test fonts for layout tests in WebKitTestRunner (on Mac)
156         https://bugs.webkit.org/show_bug.cgi?id=42153
157
158         * WebKitTestRunner/InjectedBundle/ActivateFonts.h: Added.
159         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
160         (WTR::InjectedBundle::initialize): Activate fonts on startup.
161         * WebKitTestRunner/InjectedBundle/mac: Added.
162         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm: Added.
163         (WTR::activateFonts): Activate our fonts.
164         * WebKitTestRunner/InjectedBundle/win: Added.
165         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp: Added.
166         (WTR::activateFonts): Dummy version.
167         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Copy fonts to bundle;
168         add more files.
169         * WebKitTestRunner/fonts: Added.
170         * WebKitTestRunner/fonts/AHEM____.TTF: Added.
171         * WebKitTestRunner/fonts/ColorBits-A.png: Added.
172         * WebKitTestRunner/fonts/ColorBits.ttf: Added.
173         * WebKitTestRunner/fonts/WebKit Layout Tests 2.ttf: Added.
174         * WebKitTestRunner/fonts/WebKit Layout Tests.ttf: Added.
175         * WebKitTestRunner/fonts/WebKitWeightWatcher100.ttf: Added.
176         * WebKitTestRunner/fonts/WebKitWeightWatcher200.ttf: Added.
177         * WebKitTestRunner/fonts/WebKitWeightWatcher300.ttf: Added.
178         * WebKitTestRunner/fonts/WebKitWeightWatcher400.ttf: Added.
179         * WebKitTestRunner/fonts/WebKitWeightWatcher500.ttf: Added.
180         * WebKitTestRunner/fonts/WebKitWeightWatcher600.ttf: Added.
181         * WebKitTestRunner/fonts/WebKitWeightWatcher700.ttf: Added.
182         * WebKitTestRunner/fonts/WebKitWeightWatcher800.ttf: Added.
183         * WebKitTestRunner/fonts/WebKitWeightWatcher900.ttf: Added.
184
185 2010-07-13  Dumitru Daniliuc  <dumi@chromium.org>
186
187         Reviewed by Eric Seidel.
188
189         Remove check-header-includes, as it didn't turn out to be very useful.
190         https://bugs.webkit.org/show_bug.cgi?id=41970
191
192         * Scripts/check-header-includes: Removed.
193
194 2010-07-12  Steve Falkenburg  <sfalken@apple.com>
195
196         Reviewed by Maciej Stachowiak.
197
198         Make WebKit2 be built by build-webkit (so it will be built by build.webkit.org bots)
199         https://bugs.webkit.org/show_bug.cgi?id=40922
200         
201         Always build WebKit2 on Windows. Necessary since our WebKit build on
202         Windows is packaged into a DLL with WebKit2.
203
204         * Scripts/build-webkit: Always build WebKit2 on Windows.
205
206 2010-07-12  Brian Weinstein  <bweinstein@apple.com>
207
208         Reviewed by Steve Falkenburg.
209
210         One http test timing out on Windows can cause all future tests to time out
211         https://bugs.webkit.org/show_bug.cgi?id=42146
212         
213         There have been multiple times on the Windows bots where one http test timing out causes all future
214         http tests to time out. This is because the httpd process becomes unresponsive. When an http test
215         times out, we should restart httpd on Cygwin to prevent this.
216
217         * Scripts/old-run-webkit-tests: If an http test timed out on Cygwin, close httpd and restart it.
218         * Scripts/webkitperl/httpd.pm: Add additional logic to closeHTTPD to teach it about taskkill if
219             using kill fails.
220
221 2010-07-12  Maciej Stachowiak  <mjs@apple.com>
222
223         Reviewed by Dan Bernstein.
224
225         Remove use of auto_ptr in WebKitTestRunner
226         https://bugs.webkit.org/show_bug.cgi?id=42134
227         
228         Replaced auto_ptr with PassOwnPtr / OwnPtr.
229
230         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
231         (WTR::WKStringToUTF8):
232         (WTR::InjectedBundlePage::dump):
233         (WTR::InjectedBundlePage::addMessageToConsole):
234         * WebKitTestRunner/TestInvocation.cpp:
235         (WTR::WKStringToUTF8):
236         (WTR::TestInvocation::didRecieveMessageFromInjectedBundle):
237
238 2010-07-12  Maciej Stachowiak  <mjs@apple.com>
239
240         Reviewed by Sam Weinig.
241
242         Need support for a WebKit2-specific Skipped list (and initially add accessibility tests to it)
243         https://bugs.webkit.org/show_bug.cgi?id=42132
244
245         * Scripts/old-run-webkit-tests: In --webkit-test-runner mode, add mac-wk2 to list of
246         platform directories.
247
248 2010-07-12  Maciej Stachowiak  <mjs@apple.com>
249
250         Reviewed by Anders Carlsson.
251
252         Make WebKitTestRunner resize the view specially for the W3C SVG tests.
253         https://bugs.webkit.org/show_bug.cgi?id=42126
254
255         * WebKitTestRunner/PlatformWebView.h:
256         * WebKitTestRunner/TestInvocation.cpp:
257         (WTR::TestInvocation::TestInvocation): Store the path as a C
258         string for later use.
259         (WTR::TestInvocation::~TestInvocation):
260         (WTR::sizeWebViewForCurrentTest): Resize the WebView to the proper
261         size, depending on whether this is a W3C SVG test.
262         (WTR::TestInvocation::invoke): Call the size function.
263         * WebKitTestRunner/TestInvocation.h:
264         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
265         (WTR::PlatformWebView::resizeTo): Implement.
266         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
267         (WTR::PlatformWebView::resizeTo): Placeholder.
268
269 2010-07-12  Mario Sanchez Prada  <msanchez@igalia.com>
270
271         Reviewed by Xan Lopez.
272
273         Ensure DRT loads GAIL (Gtk+ module), for a11y tests
274         https://bugs.webkit.org/show_bug.cgi?id=38648
275
276         Add the GTK_MODULES envvar (set to "gail") to the clean
277         environment when running DRT for the Gtk+ port
278
279         * Scripts/old-run-webkit-tests:
280
281 2010-07-12  Martin Robinson  <mrobinson@igalia.com>
282
283         Reviewed by Dirk Schulze.
284
285         [GTK] Support pixel tests
286         https://bugs.webkit.org/show_bug.cgi?id=31518
287
288         Finish support for pixel tests on GTK+.
289
290         * DumpRenderTree/PixelDumpSupport.cpp: Remove unecessary RetainPtr include (only
291         works on CoreFoundation systems) and add missing cstdio include.
292         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp: Switch to using the MD5 support found
293         in JSC library. MD5.cpp and MD5.h are only available for the Windows build.
294         (computeMD5HashStringForBitmapContext): The number of bytes per row should be the row stride
295         of the image, not the row stride multiplied by the width. Use JSC MD5 implementation to calculate
296         the MD5 hash here. According to glibc manpages, using snprintf to build a string in unsupported
297         by the ANSI standard and this fails on Linux, so unroll the loop here.
298         * DumpRenderTree/cairo/PixelDumpSupportCairo.h: Correct some constructor misbehavior.
299         (BitmapContext::BitmapContext): There is no reason to check the value of the
300         m_context member in the constructor and it certainly should not be freed. Instead
301         just initialize it with the incoming value.
302         * DumpRenderTree/gtk/DumpRenderTree.cpp: Fix the order of includes.
303         (dump): Actually call dumpWebViewAsPixelsAndCompareWithExpected when it is time to
304         dump pixels.
305         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Added.
306         (createBitmapContextFromWebView):
307         * GNUmakefile.am: Add new files to the build.
308
309 2010-07-12  Adam Barth  <abarth@webkit.org>
310
311         Unreviewed.
312
313         Remove stray "raise e" that got included in a previous patch.  This
314         caused the EWS bots to turn red instead of purple when a patch failed
315         to apply.
316
317         * Scripts/webkitpy/tool/commands/stepsequence.py:
318
319 2010-07-12  Sheriff Bot  <webkit.review.bot@gmail.com>
320
321         Unreviewed, rolling out r63101.
322         http://trac.webkit.org/changeset/63101
323         https://bugs.webkit.org/show_bug.cgi?id=42103
324
325         Broke one API test (Requested by xan_ on #webkit).
326
327         * Scripts/old-run-webkit-tests:
328
329 2010-07-12  Alexey Proskuryakov  <ap@apple.com>
330
331         Reviewed by Adam Roben.
332
333         https://bugs.webkit.org/show_bug.cgi?id=13075
334         XMLHttpRequest with failed authentication should set status to 401
335
336         https://bugs.webkit.org/show_bug.cgi?id=6871
337         <rdar://problem/3363403> 401 error page is never shown
338
339         Fix crashes in Windows DumpRenderTree.
340
341         * DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
342         If we return an error, WebKit will call continueWithoutCredentialForAuthenticationChallenge()
343         again on a destroyed sender.
344
345 2010-07-12  Adam Roben  <aroben@apple.com>
346
347         Windows failure-to-launch fix
348
349         * DumpRenderTree/win/DumpRenderTree.vcproj: Copy CoreVideo.dll and
350         CoreVideo.pdb into WebKitOutputDir in the post-build event, too, like
351         we already do for CoreFoundation, CFNetwork, etc.
352
353 2010-07-12  Mario Sanchez Prada  <msanchez@igalia.com>
354
355         Reviewed by Xan Lopez.
356
357         Ensure DRT loads GAIL (Gtk+ module), for a11y tests
358         https://bugs.webkit.org/show_bug.cgi?id=38648
359
360         Add the GTK_MODULES envvar (set to "gail") to the clean
361         environment when running DRT for the Gtk+ port
362
363         * Scripts/old-run-webkit-tests:
364
365 2010-07-09  Alexey Proskuryakov  <ap@apple.com>
366
367         Reviewed by Darin Adler.
368
369         https://bugs.webkit.org/show_bug.cgi?id=13075
370         XMLHttpRequest with failed authentication should set status to 401
371
372         https://bugs.webkit.org/show_bug.cgi?id=6871
373         <rdar://problem/3363403> 401 error page is never shown
374
375         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
376         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
377         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
378         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
379         Do respond even if handlesAuthenticationChallenges() is false. Pretend that the user pressed
380         the Cancel button.
381
382 2010-07-12  Andreas Kling  <andreas.kling@nokia.com>
383
384         Reviewed by Tor Arne Vestbø.
385
386         [Qt] Add location bar (Ctrl+L) shortcut in QtTestBrowser
387         https://bugs.webkit.org/show_bug.cgi?id=42082
388
389         * QtTestBrowser/main.cpp:
390         (LauncherWindow::createChrome):
391         * QtTestBrowser/mainwindow.cpp:
392         (MainWindow::openLocation):
393         * QtTestBrowser/mainwindow.h:
394
395 2010-07-12  Adam Roben  <aroben@apple.com>
396
397         Make the Python autoinstaller not use a dead SourceForge server
398
399         Fixes <http://webkit.org/b/42080> webkit-patch is broken due to
400         offline SourceForge server
401
402         Reviewed by Anders Carlsson.
403
404         * Scripts/webkitpy/thirdparty/__init__.py: Use
405         surfnet.dl.sourceforge.net instead of hivelocity.dl.sourceforge.net,
406         which seems to be down.
407
408 2010-07-12  Adam Roben  <aroben@apple.com>
409
410         Make run-webkit-tests print how many tests timed out when exiting
411         early
412
413         The number of timed-out tests is taken into account when deciding
414         whether to exit early. Leaving it out of the output just makes the
415         script look buggy (because it might say something like "Exiting early
416         after 0 crashes.").
417
418         Fixes <http://webkit.org/b/42077> run-webkit-tests prints confusing
419         messages when exiting early due to crashes and time-outs
420
421         Reviewed by Anders Carlsson.
422
423         * Scripts/old-run-webkit-tests:
424         (stopRunningTestsEarlyIfNeeded): When stopping, print the number of
425         timed-out tests, too.
426
427 2010-07-11  Maciej Stachowiak  <mjs@apple.com>
428
429         Reviewed by Dan Bernstein.
430
431         Implement animation-related methods for WebKitTestRunner
432         https://bugs.webkit.org/show_bug.cgi?id=42053
433         
434         Implemented numberOfActiveAnimatiosn and pauseAnimationAtTimeOnElementWithId. Many
435         animation tests were hanging otherwise.
436
437         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
438         (WTR::LayoutTestController::numberOfActiveAnimations):
439         (WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId):
440         (WTR::numberOfActiveAnimationsCallback):
441         (WTR::pauseAnimationAtTimeOnElementWithIdCallback):
442         (WTR::LayoutTestController::staticFunctions):
443         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
444
445 2010-07-11  Daniel Bates  <dbates@rim.com>
446
447         Reviewed by David Kilzer.
448
449         Enable executable support for svn-apply and svn-unapply
450         https://bugs.webkit.org/show_bug.cgi?id=39409
451
452         Connect up the Git and SVN executable bit support in parseDiff() so that
453         executable bit changes are propagated via the returned diff hash to the
454         patch function in svn-apply and svn-unapply.
455
456         * Scripts/VCSUtils.pm:
457           - Modified parseDiff() to call parseSvnDiffProperties when
458             it finds the start of an SVN property change diff.
459           - Removed FIXME comment above parseSvnDiffProperties() since
460             it is now being used by parseDiff().
461           - Export method scmToggleExecutableBit() now that we added the
462             executableBitDelta hash key. (This should have been exported
463             when we added this function in Bug #38423 <https://bugs.webkit.org/show_bug.cgi?id=38423>).
464         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
465           - Updated results for:
466             "rename (with executable bit change)"
467               - Test value of executableBitDelta (now that we have support).
468             "SVN: binary file (isBinary true)"
469               - Remove the property change diff from svnConvertedText. We plan
470                 to remove svnConvertedText in the future. So, we decided
471                 against adding such support to any new code, such as the
472                 property parsing routines. Therefore, we do not keep SVN
473                 converted text for property change diffs.
474           - Added unit tests:
475             "SVN: file change diff with property change diff"
476             "SVN: file change diff, followed by property change diff on different file"
477             "SVN: property diff, followed by file change diff"
478             "SVN: copied file with property change"
479             "SVN: two consecutive property diffs"
480             "SVN: binary file with executable bit change"
481             "SVN: binary file followed by property change on different file"
482             "SVN: binary file followed by file change on different file"
483             "SVN: file change diff with property change, followed by property change diff"
484             "SVN: file change diff with property change, followed by file change diff"
485
486 2010-07-11  Maciej Stachowiak  <mjs@apple.com>
487
488         Reviewed by Dan Bernstein.
489
490         Implement waitUntilDone and notifyDone for WebKitTestRunner
491         https://bugs.webkit.org/show_bug.cgi?id=42049
492
493         With this fix, most of the DOM tests pass.
494         
495         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
496         (WTR::InjectedBundle::didCreatePage): Track the main page. Not
497         a great way to do it in the future case where we may get multiple
498         pages - we really need a way to send it over from the ui process.
499         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
500         (WTR::InjectedBundle::page): A way to get the main page.
501         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
502         (WTR::InjectedBundlePage::InjectedBundlePage): Initialize m_isLoading to false.
503         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): Track that we
504         are loading.
505         (WTR::InjectedBundlePage::dump): Factor into a method so this can be
506         called by the layout test controller. Also, cancel any pending watchdogs.
507         (WTR::InjectedBundlePage::didFinishLoadForFrame): Note that we are done loading.
508         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): Ditto.
509         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
510         (WTR::InjectedBundlePage::isLoading): A way to track if we are loading.
511         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
512         (WTR::LayoutTestController::LayoutTestController): Initialize m_waitToDump
513         to false.
514         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Invalidate 
515         the watchdog.
516         (WTR::waitUntilDoneWatchdogFired): Static helper for the watchdog timer.
517         (WTR::LayoutTestController::setWaitToDump): Set the flag.
518         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Handle the case
519         where waitUntilDone times out.
520         (WTR::LayoutTestController::notifyDone): Dump, if loading is done.
521         (WTR::waitUntilDoneCallback): JS glue for waitUntilDone.
522         (WTR::notifyDoneCallback): JS glue for notifyDone.
523         (WTR::LayoutTestController::staticFunctions): Add waitUntilDone and notifyDone
524         to the layoutController.
525         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
526         (WTR::LayoutTestController::waitToDump): Inline method to get the wait state.
527
528 2010-07-09  Brian Weinstein  <bweinstein@apple.com>
529
530         Rubber-stamped by Dan Bernstein.
531
532         Windows testers running Windows 7 were hanging during test_kill_process. Changing the
533         number of attempts from 3 to 10 fixes the problem on the new bots (and doesn't seem to
534         slow down the tests).
535
536         * Scripts/webkitpy/common/system/executive.py:
537
538 2010-07-09  Luiz Agostini  <luiz.agostini@openbossa.org>
539
540         Reviewed by Kenneth Rohde Christiansen.
541
542         [Qt] Mac build fix
543         https://bugs.webkit.org/show_bug.cgi?id=41967
544
545         Adding file PluginObjectMac.mm and frameworks Cocoa and QuartzCore.
546
547         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
548
549 2010-07-09  Diego Gonzalez  <diegohcg@webkit.org>
550
551         Reviewed by Antonio Gomes.
552
553         [Qt] [WebKit2] Add navigation actions to MiniBrowser toolbar
554         https://bugs.webkit.org/show_bug.cgi?id=41966
555
556         * MiniBrowser/qt/BrowserWindow.cpp:
557         (BrowserWindow::BrowserWindow):
558
559 2010-07-09  Leon Clarke  <leonclarke@google.com>
560
561         Reviewed by Adam Barth.
562
563         add support for link prefetching
564         https://bugs.webkit.org/show_bug.cgi?id=3652
565
566         * Scripts/build-webkit:
567
568 2010-07-09  Ojan Vafai  <ojan@chromium.org>
569
570         Reviewed by Adam Barth.
571
572         r63004 broke some python tests
573         https://bugs.webkit.org/show_bug.cgi?id=42007
574
575         AbstractStep now checks options.no_squash and options.squash, so
576         they needed to have real values. Mock would return an object for those,
577         which would then act as if the values were True.
578
579         * Scripts/webkitpy/tool/commands/commandtest.py:
580         * Scripts/webkitpy/tool/commands/download_unittest.py:
581         * Scripts/webkitpy/tool/commands/stepsequence.py:
582         * Scripts/webkitpy/tool/commands/upload_unittest.py:
583         * Scripts/webkitpy/tool/mocktool.py:
584         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
585         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
586         * Scripts/webkitpy/tool/steps/steps_unittest.py:
587         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
588         * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py:
589
590 2010-07-09  Ojan Vafai  <ojan@chromium.org>
591
592         Reviewed by Adam Barth.
593
594         --squash should go away and become the default
595         https://bugs.webkit.org/show_bug.cgi?id=39624
596
597         If there are local commits and working copy changes, then prompt the user
598         whether to continue. Setting git config webkit-patch.commit_should_always_squash
599         true bypasses the prompt.
600
601         --git-commit=HEAD.. operates on working copy changes only.
602         --git-commit=committish operates on a range of commits as a single commit.
603             e.g. --git-commit=HEAD only operates on the HEAD commit.
604             --git-commit=HEAD~4..HEAD~2 will operate on HEAD~3 and HEAD~2 as a single commit.
605
606         --no-squash and --squash are left in with descriptive error messages if used.
607
608         * Scripts/check-webkit-style:
609         * Scripts/webkitpy/common/checkout/api.py:
610         * Scripts/webkitpy/common/checkout/api_unittest.py:
611         * Scripts/webkitpy/common/checkout/scm.py:
612         * Scripts/webkitpy/common/checkout/scm_unittest.py:
613         * Scripts/webkitpy/common/net/rietveld.py:
614         * Scripts/webkitpy/common/system/user.py:
615         * Scripts/webkitpy/style/optparser.py:
616         * Scripts/webkitpy/style_references.py:
617         * Scripts/webkitpy/tool/commands/download.py:
618         * Scripts/webkitpy/tool/commands/upload.py:
619         * Scripts/webkitpy/tool/mocktool.py:
620         * Scripts/webkitpy/tool/steps/abstractstep.py:
621         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
622         * Scripts/webkitpy/tool/steps/checkstyle.py:
623         * Scripts/webkitpy/tool/steps/checkstyle_unittest.py: Removed.
624         * Scripts/webkitpy/tool/steps/commit.py:
625         * Scripts/webkitpy/tool/steps/options.py:
626         * Scripts/webkitpy/tool/steps/preparechangelog.py:
627         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
628         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
629         * Scripts/webkitpy/tool/steps/validatereviewer.py:
630
631 2010-07-09  Mark Rowe  <mrowe@apple.com>
632
633         Add two new Windows test build slaves.
634
635         * BuildSlaveSupport/build.webkit.org-config/config.json:
636
637 2010-07-09  Albert J. Wong  <ajwong@chromium.org>
638
639         Reviewed by David Levin.
640
641         rebaseline_chromium_webkit_tests missing --use_drt option on linux
642         https://bugs.webkit.org/show_bug.cgi?id=41985
643
644         This adds in the --use_drt option for rebaseline_chromium_webkit_tests
645         so that it works on linux. This is essentially a "compile-fix" for the
646         script.
647
648         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
649
650 2010-07-09  Nico Weber  <thakis@chromium.org>
651
652         Unreviewed. Adding myself as committer.
653
654         * Scripts/webkitpy/common/config/committers.py:
655
656 2010-07-09  David Kilzer  <ddkilzer@apple.com>
657
658         Revert "<http://webkit.org/b/41788> commit-log-editor: wrong ChangeLog read when invoked from subdir with git"
659
660         This reverts commit r62692.
661
662         * Scripts/commit-log-editor:
663
664 2010-07-08  Kinuko Yasuda  <kinuko@chromium.org>
665
666         Reviewed by Ojan Vafai.
667
668         cleanup json_results_generator dependencies so that non-layout-tests can also use it safely
669         https://bugs.webkit.org/show_bug.cgi?id=38693
670
671         Introduced a new base class JSONResultsGeneratorBase that doesn't
672         have any dependency on layout_tests packages.
673         Turned JSONResultsGenerator into a wrapper class of the base class
674         so that the old code can work with it during the cleanup.
675
676         Added json_results_generator_unittest.py.
677
678         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
679         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
680         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py: Added
681
682 2010-07-09  Abhishek Arya  <inferno@chromium.org>
683
684         Unreviewed.
685
686         Marking myself as a committer.
687
688         * Scripts/webkitpy/common/config/committers.py:
689
690 2010-07-09  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
691
692         Reviewed by Antti Koivisto.
693
694         Implement MiniBrowser for Qt.
695         https://bugs.webkit.org/show_bug.cgi?id=40233
696
697         * MiniBrowser/qt/BrowserWindow.cpp: Added.
698         (createNewPage):
699         (BrowserView::BrowserView):
700         (BrowserView::resizeEvent):
701         (BrowserView::load):
702         (BrowserView::view):
703         (BrowserWindow::BrowserWindow):
704         (BrowserWindow::load):
705         (BrowserWindow::changeLocation):
706         (BrowserWindow::~BrowserWindow):
707         * MiniBrowser/qt/BrowserWindow.h: Added.
708         (BrowserView::~BrowserView):
709         * MiniBrowser/qt/MiniBrowser.pro: Added.
710         * MiniBrowser/qt/main.cpp: Added.
711         (main):
712
713 2010-07-09  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
714
715         Reviewed by Simon Hausmann.
716
717         Introduce the Qt autotest launcher.
718
719         Qt autotests should be executed more frequently, ideally by the Qt
720         build bot. This is the first step to provide the tests more accessible.
721
722         [Qt] It should be easier to run all Qt's autotests.
723         https://bugs.webkit.org/show_bug.cgi?id=31625
724
725         * Scripts/run-qtwebkit-tests: Added.
726
727 2010-07-09  Adam Barth  <abarth@webkit.org>
728
729         Reviewed by Eric Seidel.
730
731         commit-queue should merge to TOT when checkout needs update
732         https://bugs.webkit.org/show_bug.cgi?id=41944
733
734         There are a bunch of different designs that are possible here.  This
735         one merges to top of tree by cleaning out the working copy and
736         re-applying the patch.  Once you decide to merge that way, you need to
737         decide who's going to retry.  In this patch, we retry in the child
738         process instead of plumbing the failure reason to the master process.
739
740         This patch is difficult to test end-to-end, but hopefully it will work.
741         :)
742
743         * Scripts/webkitpy/tool/commands/queues.py:
744         * Scripts/webkitpy/tool/commands/stepsequence.py:
745         * Scripts/webkitpy/tool/multicommandtool.py:
746         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
747
748 2010-07-09  Dumitru Daniliuc  <dumi@chromium.org>
749
750         Reviewed by Darin Adler.
751
752         Add a script to check for unnecessary includes in header files.
753         https://bugs.webkit.org/show_bug.cgi?id=41894
754
755         * Scripts/check-header-includes: Added.
756
757 2010-07-09  Adam Barth  <abarth@webkit.org>
758
759         Reviewed by Eric Seidel.
760
761         Add --html5-treebuilder option to run-webkit-tests
762         https://bugs.webkit.org/show_bug.cgi?id=41922
763
764         We're down to one or two regressions in the HTML5lib test suite.  It's
765         getting to be time to look at fixing LayoutTests.
766
767         * Scripts/old-run-webkit-tests:
768
769 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
770
771         Fix Tiger plugin test failures; the #ifdefs were incorrect, resulting
772         in the drawing model never getting set on Tiger.
773
774         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
775         (NPP_New):
776
777 2010-07-08  Aaron Boodman  <aa@chromium.org>
778
779         Reviewed by Timothy Hatcher.
780
781         Add the ability for user scripts and user styles to affect just the top frame.
782
783         https://bugs.webkit.org/show_bug.cgi?id=41529
784
785         * DumpRenderTree/LayoutTestController.h: Added new allFrames param.
786         * DumpRenderTree/LayoutTestController.cpp: Ditto.
787         (addUserScriptCallback):
788         (addUserStyleSheetCallback):
789         * DumpRenderTree/chromium/LayoutTestController.cpp: Ditto.
790         (LayoutTestController::addUserScript):
791         (LayoutTestController::addUserStyleSheet):
792         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Ditto.
793         (LayoutTestController::addUserScript):
794         (LayoutTestController::addUserStyleSheet):
795         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Ditto.
796         (LayoutTestController::addUserScript):
797         (LayoutTestController::addUserStyleSheet):
798         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Ditto.
799         (LayoutTestController::addUserScript):
800         (LayoutTestController::addUserStyleSheet):
801         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Ditto.
802         (LayoutTestController::addUserScript):
803         (LayoutTestController::addUserStyleSheet):
804
805 2010-07-08  Adele Peterson  <adele@apple.com>
806
807         Reviewed by Jon Honeycutt, Adam Roben, and Darin Adler.
808
809         Test infrastructure for https://bugs.webkit.org/show_bug.cgi?id=41721
810         <rdar://problem/8158561> Missing plug-in indicator should have a pressed state
811
812         Log when the missing plugin button is pressed.
813
814         * DumpRenderTree/mac/UIDelegate.mm:
815         (-[UIDelegate webView:didPressMissingPluginButton:]):
816         * DumpRenderTree/win/UIDelegate.cpp:
817         (UIDelegate::QueryInterface):
818         (UIDelegate::createWebViewWithRequest):
819         (UIDelegate::drawBackground):
820         (UIDelegate::decidePolicyForGeolocationRequest):
821         (UIDelegate::didPressMissingPluginButton):
822         * DumpRenderTree/win/UIDelegate.h:
823
824 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
825
826         Fix the Tiger build.
827
828         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
829         (NPP_New):
830
831 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
832
833         Fix windows build.
834
835         #ifdef code for Mac.
836
837         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
838         (NPP_New):
839
840 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
841
842         Reviewed by Anders Carlsson.
843
844         Allow the TestPlugin to use Core Animation rendering for testing
845         https://bugs.webkit.org/show_bug.cgi?id=41872
846         
847         Add the ability for the TestPlugin to use the CoreAnimation rendering model
848         when available, based on the "drawingmodel" attribute of the embed tag:
849             drawingmodel="coreanimation"
850
851         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add PluginObjectMac.mm
852         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Add some macros so we can detect
853         when building on Tiger. Add a void* coreAnimationLayer member.
854         
855         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm: Added.
856         (createCoreAnimationLayer): Obj-C method to create the CALayer.
857         
858         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
859         (NPP_New): Look for the drawingmodel attribute to decide which drawing
860         model to use.
861         (NPP_Destroy): Release the CALayer if we have one.
862         (NPP_GetValue): Return the retained CALayer.
863
864 2010-07-08  Martin Robinson  <mrobinson@igalia.com>
865
866         Reviewed by Xan Lopez.
867
868         [GTK] Support pixel tests
869         https://bugs.webkit.org/show_bug.cgi?id=31518
870
871         Convert this file from CRLF to NL line endings. It will soon
872         be used on more than just the WinCairo platform.
873
874         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
875         (writeFunction):
876         (printPNG):
877         (computeMD5HashStringForBitmapContext):
878         (dumpBitmap):
879
880 2010-07-08  Steve Falkenburg  <sfalken@apple.com>
881
882         Reviewed by Darin Adler.
883
884         Enable Data Execution Prevention for our test harnesses on Windows
885         https://bugs.webkit.org/show_bug.cgi?id=41882
886
887         * DumpRenderTree/win/DumpRenderTree.vcproj:
888         * DumpRenderTree/win/ImageDiff.vcproj:
889         * WebKitAPITest/WebKitAPITest.vcproj:
890         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
891
892 2010-07-07  Robert Hogan  <robert@webkit.org>
893
894         Reviewed by Kenneth Rohde Christiansen.
895
896         [Qt] Add DRT support for pageProperty etc.
897
898         https://bugs.webkit.org/show_bug.cgi?id=41584
899
900         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
901         (LayoutTestController::isPageBoxVisible):
902         (LayoutTestController::pageSizeAndMarginsInPixels):
903         (LayoutTestController::pageProperty):
904         (LayoutTestController::addUserStyleSheet):
905         * DumpRenderTree/qt/LayoutTestControllerQt.h:
906
907 2010-07-08  Martin Robinson  <mrobinson@igalia.com>
908
909         Reviewed by Xan Lopez.
910
911         Remove a warnings from the ImageDiff build by using the proper
912         printf format string for the gsize data type.
913
914         * DumpRenderTree/gtk/ImageDiff.cpp:
915         (printImage): Use the proper printf format string for the gsize data type.
916
917 2010-07-08  Alice Liu  <alice.liu@apple.com>
918
919         Reviewed by Sam Weinig.
920
921         https://bugs.webkit.org/show_bug.cgi?id=41653
922         Add new WebKitTestRunner project for Windows
923
924         * WebKitTestRunner/WebKitTestRunnerPrefix.h: 
925         Similar to how it's done in DumpRenderTree, define max and min early
926         on so that they don't get replaced by a macro requiring 2 arguments.
927
928         * WebKitTestRunner/win: Added.
929         * WebKitTestRunner/win/WebKitTestRunner.sln: Added.
930         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added.
931         * WebKitTestRunner/win/main.cpp: Added.
932         (main): Implemented
933
934         Added these files with stubbed out functions:
935         * WebKitTestRunner/win/PlatformWebViewWin.cpp: Added.
936         (WTR::PlatformWebView::PlatformWebView):
937         (WTR::PlatformWebView::~PlatformWebView):
938         (WTR::PlatformWebView::page):
939         * WebKitTestRunner/win/TestControllerWin.cpp: Added.
940         (WTR::TestController::initializeInjectedBundlePath):
941         * WebKitTestRunner/win/TestInvocationWin.cpp: Added.
942         (WTR::TestInvocation::runUntil):
943
944 2010-07-07  Martin Robinson  <mrobinson@igalia.com>
945
946         Reviewed by Gustavo Noronha Silva.
947
948         [GTK] Implement ImageDiff and add it to the build system
949         https://bugs.webkit.org/show_bug.cgi?id=41779
950
951         Add the initial implementation of the ImageDiff tool for the GTK+
952         port. This is an essential tool for doing pixel tests. The implementation
953         is based on the Mac and Chromium ports.
954
955         * DumpRenderTree/gtk/ImageDiff.cpp: Added.
956         (readPixbufFromStdin): Added.
957         (differenceImageFromDifferenceBuffer): Ditto.
958         (calculateDifference): Ditto.
959         (printImage): Ditto.
960         (printImageDifferences): Ditto.
961         (main): Ditto.
962         * GNUmakefile.am: Add ImageDiff to the WebKitTools build scripts.
963
964 2010-07-08  Jay Civelli  <jcivelli@chromium.org>
965
966         Unreviewed. Adding myself as a committer.
967
968         * Scripts/webkitpy/common/config/committers.py:
969
970 2010-07-08  Adam Roben  <aroben@apple.com>
971
972         Make Windows stop running tests from platform/mac
973
974         r62742 made a change (at my suggestion!) that caused us to start
975         looking for tests in platform/mac, rather than just looking for
976         expected results in platform/mac. This patch just undoes that part of
977         r62742.
978
979         Fixes <http://webkit.org/b/41855> REGRESSION (r62742): Windows runs
980         tests from platform/mac, but shouldn't
981
982         Reviewed by Antti Koivisto and Anders Carlsson.
983
984         * Scripts/old-run-webkit-tests:
985         (top level): Removed "mac-snowleopard" and "mac" from @winPlatforms,
986         so we won't look in those directories for tests to run.
987         (expectedDirectoryForTest): Added back code from pre-r62742 to look in
988         platform/mac-snowleopard and platform/mac for expected results.
989
990 2010-07-08  Antonio Gomes  <tonikitoo@webkit.org>
991
992         Unreviewed. Adding myself as a reviewer.
993
994         * Scripts/webkitpy/common/config/committers.py:
995
996 2010-07-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
997
998         Update my e-mail in committers.py
999
1000         * Scripts/webkitpy/common/config/committers.py:
1001
1002 2010-07-07  Daniel Bates  <dbates@rim.com>
1003
1004         Reviewed by Dumitru Daniliuc.
1005
1006         VCSUtils.pm complains about uninitialized value $newLine
1007         https://bugs.webkit.org/show_bug.cgi?id=41333
1008
1009         Fixes an issue where VCSUtils::fixChangeLogPatch() may read off the end of
1010         an array when fixing a change log entry that overlaps with an earlier
1011         entry. In particular, when a patch contains a change log entry inserted
1012         earlier in the change log file, but after an entry with the same author
1013         and date.
1014
1015         * Scripts/VCSUtils.pm:
1016             - Added for-loop constraint to fixChangeLogPatch() so that it does not
1017               read off the end of the @overlappingLines array.
1018         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl: Added unit test.
1019
1020 2010-07-07  Anders Carlsson  <andersca@apple.com>
1021
1022         Comment out a part of TestNetscapePlugin that caused tests to fail on Tiger and Leopard.
1023
1024         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1025         (NPP_New):
1026
1027 2010-07-07  Kent Tamura  <tkent@chromium.org>
1028
1029         Reviewed by Adam Barth.
1030
1031         [DRT/Chromium] Support for indeterminate checkbox
1032         https://bugs.webkit.org/show_bug.cgi?id=41747
1033
1034         Import http://src.chromium.org/viewvc/chrome?view=rev&revision=51499
1035
1036         * DumpRenderTree/chromium/WebThemeControlDRT.cpp:
1037         (WebThemeControlDRT::draw):
1038         * DumpRenderTree/chromium/WebThemeControlDRT.h:
1039         (WebThemeControlDRT::):
1040         * DumpRenderTree/chromium/WebThemeEngineDRT.cpp:
1041         (WebThemeEngineDRT::paintButton):
1042
1043 2010-07-07  Sam Weinig  <sam@webkit.org>
1044
1045         Reviewed by Mark Rowe.
1046
1047         Clean up MiniBrowser Xcode project.
1048
1049         - Use xcconfig files.
1050         - Rename plists to canonical Info.plist
1051         - Remove localizations.
1052
1053         * MiniBrowser/Configurations: Added.
1054         * MiniBrowser/Configurations/Base.xcconfig: Added.
1055         * MiniBrowser/Configurations/DebugRelease.xcconfig: Added.
1056         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Added.
1057         * MiniBrowser/Configurations/WebBundle.xcconfig: Added.
1058         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1059         * MiniBrowser/WebBundle-Info.plist: Removed.
1060         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
1061         (-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
1062         * MiniBrowser/mac/BrowserWindow.xib: Added.
1063         * MiniBrowser/mac/BrowserWindowController.m:
1064         (-[BrowserWindowController initWithPageNamespace:]):
1065         * MiniBrowser/mac/English.lproj: Removed.
1066         * MiniBrowser/mac/English.lproj/BrowserWindow.xib: Removed.
1067         * MiniBrowser/mac/English.lproj/InfoPlist.strings: Removed.
1068         * MiniBrowser/mac/English.lproj/MainMenu.xib: Removed.
1069         * MiniBrowser/mac/Info.plist: Copied from MiniBrowser/mac/MiniBrowser-Info.plist.
1070         * MiniBrowser/mac/MainMenu.xib: Added.
1071         * MiniBrowser/mac/MiniBrowser-Info.plist: Removed.
1072         * MiniBrowser/mac/WebBundle/Info.plist: Copied from MiniBrowser/WebBundle-Info.plist.
1073
1074 2010-07-07  Kent Tamura  <tkent@chromium.org>
1075
1076         Reviewed by Dimitri Glazkov.
1077
1078         [DRT/Chromium] Fix two regressions
1079         https://bugs.webkit.org/show_bug.cgi?id=41745
1080
1081         * DumpRenderTree/chromium/WebViewHost.cpp:
1082         (WebViewHost::paintInvalidatedRegion):
1083          Repaint three times to fix svg/W3C-SVG-1.1/struct-use-01-t.svg
1084          and svg/custom/use-on-g-containing-foreignObject-and-image.svg
1085          though test_shell does it twice. Probably DRT needs it because
1086          DRT delays painting as possible.
1087
1088 2010-07-07  Anders Carlsson  <andersca@apple.com>
1089
1090         Try to fix build.
1091
1092         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1093         (webkit_test_plugin_destroy_stream):
1094
1095 2010-07-07  Anders Carlsson  <andersca@apple.com>
1096
1097         Try to fix the GTK+ and Qt test failures by merging the newly added code from TestNetscapePlugin/main.cpp
1098
1099         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1100         (webkit_test_plugin_new_stream):
1101         (webkit_test_plugin_destroy_stream):
1102         (webkit_test_plugin_write_ready):
1103         (webkit_test_plugin_write):
1104
1105 2010-07-07  Sam Weinig  <sam@webkit.org>
1106
1107         Reviewed by Mark Rowe.
1108
1109         Don't hard code the Mac OS X 10.6 SDK for MiniBrowser. 
1110
1111         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1112
1113 2010-07-07  Anders Carlsson  <andersca@apple.com>
1114
1115         Use the correct XP_MACOSX define instead of XP_MAC. This was causing test failures on some platforms.
1116
1117         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1118         (NPP_New):
1119         (NPP_HandleEvent):
1120
1121 2010-07-07  Brian Weinstein  <bweinstein@apple.com>
1122
1123         Reviewed by Adam Roben.
1124
1125         Need to have a way to specify different results for Windows XP and 7
1126         https://bugs.webkit.org/show_bug.cgi?id=41776
1127         
1128         Add the ability to have platform/win-xp, platform/win-vista, and platform/win-7
1129         subdirectories, so we can have different results for tests on Windows XP, Windows
1130         Vista, and Windows 7.
1131
1132         Windows XP will try the order: win-xp, win-vista, win-7, win, mac-snowleopard, mac.
1133         Windows Vista will try the order: win-vista, win-7, win, mac-snowleopard, mac.
1134         Windows 7 will try the order: win-7, win, mac-snowleopard, mac.
1135
1136         This matches the behavior of the mac.
1137
1138         * Scripts/old-run-webkit-tests: Add multiple platforms for Windows, and if we are on XP
1139             or Vista, try looking in other win-* subdirectories before win.
1140         * Scripts/webkitdirs.pm: Add some helper functions to determine what version of Windows
1141             we are running.
1142
1143 2010-07-07  Kent Tamura  <tkent@chromium.org>
1144
1145         Reviewed by Dimitri Glazkov.
1146
1147         [DRT/Chromium] Remove ASSERT_NOT_REACHED in some functions
1148         https://bugs.webkit.org/show_bug.cgi?id=41753
1149
1150         The original code of the following functions in
1151         test_shell_devtools_client.cc have NOTIMPLEMENTED(), not
1152         ASSERT_NOT_REACHED(). The program shouldn't stop at these
1153         functions.
1154
1155         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1156         (DRTDevToolsClient::activateWindow):
1157         (DRTDevToolsClient::closeWindow):
1158         (DRTDevToolsClient::dockWindow):
1159         (DRTDevToolsClient::undockWindow):
1160
1161 2010-07-07  Anders Carlsson  <andersca@apple.com>
1162
1163         Reviewed by Sam Weinig.
1164
1165         Test that we call NPP_DestroyStream if a plug-in returns -1 from its NPP_Write function
1166         https://bugs.webkit.org/show_bug.cgi?id=41821
1167
1168         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1169         (pluginGetProperty):
1170         (pluginSetProperty):
1171         (pluginAllocate):
1172         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
1173         Add and initialize the returnNegativeOneFromWrite property.
1174
1175         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1176         (NPP_NewStream):
1177         Set the stream type to NP_NORMAL so we'll get write callbacks.
1178
1179         (NPP_DestroyStream):
1180         Treat the onstreamdestroy attribute as a function name and not a string.
1181
1182         (NPP_WriteReady):
1183         Have this return a nonzero value.
1184
1185         (NPP_Write):
1186         If returnNegativeOneFromWrite is true return -1.
1187
1188 2010-07-07  Kevin Ollivier  <kevino@theolliviers.com>
1189
1190         [wx] Build fix for machines with both MSVC 2005 and 2008 installed. Ensures the
1191         latest version is selected by default, and allows the version to be specified.
1192
1193         * wx/build/settings.py:
1194
1195 2010-07-07  Chris Fleizach  <cfleizach@apple.com>
1196
1197         Reviewed by Darin Adler.
1198
1199         AX: TextArea should return AXSelectedTextRange of 0,0 if the cursor is not in the text area
1200         https://bugs.webkit.org/show_bug.cgi?id=41810
1201
1202         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1203         (AccessibilityUIElement::selectedTextRange):
1204
1205 2010-07-07  Martin Robinson  <mrobinson@igalia.com>
1206
1207         Unreviewed.
1208
1209         Build fix after r62700.
1210
1211         * GNUmakefile.am: Update the source list to reflect the new TestNetscapePlugIn
1212         source file locations.
1213
1214 2010-07-07  Ojan Vafai  <ojan@chromium.org>
1215
1216         Reviewed by David Levin.
1217
1218         change --exit-after-n-crashes to --exit-after-n-crashes-or-timeouts
1219         https://bugs.webkit.org/show_bug.cgi?id=41814
1220
1221         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1222         * Scripts/old-run-webkit-tests:
1223
1224 2010-07-07  Ojan Vafai  <ojan@chromium.org>
1225
1226         Reviewed by David Levin.
1227
1228         add --exit-after-n-crashes to run-webkit-tests
1229         https://bugs.webkit.org/show_bug.cgi?id=41811
1230
1231         Change the bots at build.webkit.org to use --exit-after-n-crashes
1232         instead of --exit-after-n-failures since we want to be able to have
1233         more than 20 failures on those bots, but more than 20 crashes means
1234         something should be rolled out.
1235
1236         * Scripts/old-run-webkit-tests:
1237         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1238
1239 2010-07-07  Brian Weinstein  <bweinstein@apple.com>
1240
1241         Fix the Windows build by removing win/TestNetscapePlugin/main.cpp from the
1242         TestNetscapePlugin project, because this was removed from the tree.
1243
1244         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1245
1246 2010-07-07  Anders Carlsson  <andersca@apple.com>
1247
1248         Reviewed by Simon Fraser.
1249
1250         Unify Mac and Windows TestNetscapePlugin main.cpp files
1251         https://bugs.webkit.org/show_bug.cgi?id=41798
1252         
1253         * DumpRenderTree/DumpRenderTree.sln:
1254         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1255         (strcasecmp):
1256         (NP_Initialize):
1257         (NP_GetEntryPoints):
1258         (NP_Shutdown):
1259         (NPP_New):
1260         (NPP_Destroy):
1261         (NPP_HandleEvent):
1262         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1263         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Removed.
1264
1265 2010-07-07  Kevin Ollivier  <kevino@theolliviers.com>
1266
1267         [wx] Build fix. pageProperty needs to return a value.
1268
1269         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1270         (LayoutTestController::pageProperty):
1271
1272 2010-07-07  David Kilzer  <ddkilzer@apple.com>
1273
1274         <http://webkit.org/b/41788> commit-log-editor: wrong ChangeLog read when invoked from subdir with git
1275
1276         Reviewed by Anders Carlsson.
1277
1278         For both svn and git, commit-log-editor is invoked from the root
1279         of the working directory.  Unlike svn, git returns a list of
1280         changed files that are relative to the directory where the
1281         command was invoked.  This caused the ChangeLog file in the root
1282         directory to be read instead of the ChangeLog in the current
1283         directory.
1284
1285         The fix is to use $ENV{PWD} as the base directory when fixing
1286         the path to the ChangeLog files.  With svn, this has no net
1287         effect since $ENV{PWD} is the root of the working directory and
1288         the ChangeLog paths are already relative to that directory.
1289         With git, $ENV{PWD} is the directory that the commit was invoked
1290         from, which fixes the ChangeLog paths so that the correct files
1291         are read when creating the commit log entry.
1292
1293         Note that the call to makeFilePathRelative() was supposed to
1294         address this issue, but it doesn't because (a) it does nothing
1295         with svn working directories by design, and (b) it does nothing
1296         with git working directories because it's invoked when the
1297         current directory is the root of the working directory, thus
1298         giving no relative path.
1299
1300         * Scripts/commit-log-editor: Removed call to
1301         makeFilePathRelative() since since it does nothing.  Moved code
1302         to fix up $changeLog path so that it's fixed before trying to
1303         open the file, and use $ENV{PWD} as the base path.  Also use
1304         canonicalizePath() to clean up paths with "../" in them.
1305
1306 2010-07-07  Anders Carlsson  <andersca@apple.com>
1307
1308         Another attempt at fixing the Qt build.
1309
1310         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1311
1312 2010-07-07  Anders Carlsson  <andersca@apple.com>
1313
1314         Try to fix Qt build.
1315
1316         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1317
1318 2010-07-07  Anders Carlsson  <andersca@apple.com>
1319
1320         Reviewed by Simon Fraser.
1321
1322         Rename TestNetscapePlugin.subproj and move platform specific files to subdirectories
1323         https://bugs.webkit.org/show_bug.cgi?id=41781
1324
1325         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1326         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp.
1327         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h.
1328         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp.
1329         * DumpRenderTree/TestNetscapePlugIn/TestObject.h: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.h.
1330         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/Info.plist.
1331         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp.
1332         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.def: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.def.
1333         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc.
1334         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added.
1335         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin_debug.def: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin_debug.def.
1336         * DumpRenderTree/TestNetscapePlugIn/win/resource.h: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/resource.h.
1337         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed.
1338
1339 2010-07-07  Andras Becsi  <abecsi@webkit.org>
1340
1341         Unreviewed trivial fix.
1342
1343         Remove DUMPRENDERTREE_TEMP environment variable from NRWT
1344         which was checked in accidentally in r62635.
1345
1346         * Scripts/webkitpy/layout_tests/port/webkit.py:
1347
1348 2010-07-07  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1349
1350         Reviewed by Eric Seidel.
1351
1352         Pass port specific environment to server process.
1353         https://bugs.webkit.org/show_bug.cgi?id=41593
1354
1355         * Scripts/webkitpy/layout_tests/port/qt.py:
1356         * Scripts/webkitpy/layout_tests/port/webkit.py:
1357
1358 2010-07-06  Kent Tamura  <tkent@chromium.org>
1359
1360         Reviewed by Shinichiro Hamaji.
1361
1362         Fix a wrong dup detection of rebaseline-chromium-webkit-tests
1363         https://bugs.webkit.org/show_bug.cgi?id=41644
1364
1365         rebaseline-chromium-webkit-tests used ImageDiff with 0.1%
1366         tolerance. We don't need tolerance for rebaseline.
1367
1368         * Scripts/webkitpy/layout_tests/port/base.py:
1369           Add optional tolerance parameter to diff_image().
1370         * Scripts/webkitpy/layout_tests/port/test.py:
1371           Add optional tolerance parameter to diff_image().
1372         * Scripts/webkitpy/layout_tests/port/webkit.py:
1373           Add optional tolerance parameter to diff_image(), and pass it to ImageDiff command.
1374         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1375           diff_files() always calls diff_image() with tolerance=0.
1376           diff_files() is used only by rebaseline-chromium-webkit-tests.
1377
1378 2010-07-06  Sam Weinig  <sam@webkit.org>
1379
1380         Fix MiniBrowser build.
1381
1382         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1383
1384 2010-07-06  Sam Weinig  <sam@webkit.org>
1385
1386         Reviewed by Anders Carlsson.
1387
1388         Add support for dumping the contents of messages to the console to WebKitTestRunner
1389
1390         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1391         (WTR::InjectedBundlePage::InjectedBundlePage):
1392         (WTR::InjectedBundlePage::_addMessageToConsole):
1393         (WTR::InjectedBundlePage::addMessageToConsole):
1394         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1395
1396 2010-07-06  Sam Weinig  <sam@webkit.org>
1397
1398         Reviewed by Anders Carlsson.
1399
1400         Patch for https://bugs.webkit.org/show_bug.cgi?id=41708
1401         Add dumpAsText support for WebKitTestRunner
1402
1403         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1404         (WTR::InjectedBundle::InjectedBundle):
1405         (WTR::InjectedBundle::reset): Reset the LayoutTestController for each test.
1406         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1407         (WTR::InjectedBundlePage::didFinishLoadForFrame): Use the new WKBundleFrameCopyInnerText
1408         API to dump the main frames text.
1409
1410 2010-07-06  Darin Adler  <darin@apple.com>
1411
1412         Fix Chromium build.
1413
1414         * DumpRenderTree/chromium/WebViewHost.cpp:
1415         (WebViewHost::didCreateDataSource): Call leakPtr instead of release.
1416         (WebViewHost::didNavigateWithinPage): Ditto.
1417         (WebViewHost::updateURL): Ditto.
1418
1419 2010-07-06  Martin Robinson  <mrobinson@igalia.com>
1420
1421         Reviewed by Xan Lopez.
1422
1423         [GTK] build-webkit should not run autogen.sh unconditionally
1424         https://bugs.webkit.org/show_bug.cgi?id=41704
1425
1426         * Scripts/webkitdirs.pm: Only run autogen.sh during a build if GNUmakefile
1427         doesn't exist. Autotools should re-run autogen.sh when necessary. Also do
1428         some very minor cleanup.
1429
1430 2010-07-06  Darin Adler  <darin@apple.com>
1431
1432         Try to fix Chromium build.
1433
1434         * DumpRenderTree/chromium/WebViewHost.cpp: Added include of PassOwnPtr.h.
1435
1436 2010-07-06  Darin Adler  <darin@apple.com>
1437
1438         Fix build.
1439
1440         * WebKitAPITest/TestsController.cpp:
1441         (WebKitAPITest::TestsController::addTest): Use leakPtr instead of release.
1442
1443 2010-07-06  Roland Steiner  <rolandsteiner@chromium.org>
1444
1445         Reviewed by Kent Tamura.
1446
1447         Bug 40558 - [DRT/Chromium] Upstream TestShellDevTools for Chromium DRT
1448         https://bugs.webkit.org/show_bug.cgi?id=40558
1449
1450         Upstream DevTools for Chromium DRT.
1451         (original Chromium files rev. 51287)
1452
1453         * DumpRenderTree/DumpRenderTree.gypi:
1454         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Added.
1455         (DRTDevToolsAgent::DRTDevToolsAgent):
1456         (DRTDevToolsAgent::setWebView):
1457         (DRTDevToolsAgent::sendMessageToFrontend):
1458         (DRTDevToolsAgent::forceRepaint):
1459         (DRTDevToolsAgent::runtimeFeatureStateChanged):
1460         (DRTDevToolsAgent::injectedScriptSource):
1461         (DRTDevToolsAgent::injectedScriptDispatcherSource):
1462         (DRTDevToolsAgent::debuggerScriptSource):
1463         (DRTDevToolsAgent::asyncCall):
1464         (DRTDevToolsAgent::call):
1465         (DRTDevToolsAgent::webDevToolsAgent):
1466         (DRTDevToolsAgent::attach):
1467         (DRTDevToolsAgent::detach):
1468         (DRTDevToolsAgent::setTimelineProfilingEnabled):
1469         (DRTDevToolsAgent::evaluateInWebInspector):
1470         (DRTDevToolsAgent::dispatchMessageLoop):
1471         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Added.
1472         (DRTDevToolsAgent::~DRTDevToolsAgent):
1473         (DRTDevToolsAgent::hostIdentifier):
1474         * DumpRenderTree/chromium/DRTDevToolsCallArgs.cpp:
1475         * DumpRenderTree/chromium/DRTDevToolsCallArgs.h:
1476         (DRTDevToolsCallArgs::DRTDevToolsCallArgs):
1477         (DRTDevToolsCallArgs::~DRTDevToolsCallArgs):
1478         (DRTDevToolsCallArgs::callsCount):
1479         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Added.
1480         (DRTDevToolsClient::DRTDevToolsClient):
1481         (DRTDevToolsClient::~DRTDevToolsClient):
1482         (DRTDevToolsClient::sendMessageToAgent):
1483         (DRTDevToolsClient::sendDebuggerCommandToAgent):
1484         (DRTDevToolsClient::activateWindow):
1485         (DRTDevToolsClient::closeWindow):
1486         (DRTDevToolsClient::dockWindow):
1487         (DRTDevToolsClient::undockWindow):
1488         (DRTDevToolsClient::asyncCall):
1489         (DRTDevToolsClient::call):
1490         (DRTDevToolsClient::allMessagesProcessed):
1491         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1492         * DumpRenderTree/chromium/EventSender.cpp:
1493         * DumpRenderTree/chromium/LayoutTestController.cpp:
1494         (LayoutTestController::LayoutTestController):
1495         (LayoutTestController::closeWebInspector):
1496         (LayoutTestController::setTimelineProfilingEnabled):
1497         (LayoutTestController::evaluateInWebInspector):
1498         * DumpRenderTree/chromium/LayoutTestController.h:
1499         * DumpRenderTree/chromium/TestShell.cpp:
1500         (TestShell::TestShell):
1501         (TestShell::~TestShell):
1502         (TestShell::createDRTDevToolsClient):
1503         (TestShell::showDevTools):
1504         (TestShell::closeDevTools):
1505         (TestShell::runFileTest):
1506         (TestShell::createNewWindow):
1507         * DumpRenderTree/chromium/TestShell.h:
1508         (TestShell::drtDevToolsAgent):
1509         (TestShell::drtDevToolsClient):
1510         * DumpRenderTree/chromium/config.h:
1511
1512 2010-07-06  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1513
1514         Reviewed by Eric Seidel.
1515
1516         Don't pass image hash to DRT when pixel tests are disabled.
1517         https://bugs.webkit.org/show_bug.cgi?id=41597
1518
1519         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1520
1521 2010-07-05  Csaba Osztrogonác  <ossy@webkit.org>
1522
1523         Reviewed by Eric Seidel.
1524
1525         REGRESSION(r60652): WebKitTools/Scripts/ensure-valid-python should cleanup temporary directory
1526         https://bugs.webkit.org/show_bug.cgi?id=41612
1527
1528         * Scripts/ensure-valid-python: File::Temp::tempdir call fixed.
1529
1530 2010-07-05  Adam Barth  <abarth@webkit.org>
1531
1532         Reviewed by Eric Seidel.
1533
1534         We should be able to specify a bug to block for webkit-patch upload
1535         https://bugs.webkit.org/show_bug.cgi?id=41648
1536
1537         This will be useful for working on the HTML5 parser.
1538
1539         * Scripts/webkitpy/tool/steps/createbug.py:
1540         * Scripts/webkitpy/tool/steps/options.py:
1541
1542 2010-07-05  Martin Robinson  <mrobinson@igalia.com>
1543
1544         Reviewed by Oliver Hunt.
1545
1546         The style checker exempts gtk2drawing.h when it should exempt gtkdrawing.h
1547         https://bugs.webkit.org/show_bug.cgi?id=41017
1548
1549         * Scripts/webkitpy/style/checker.py: Exempt gtkdrawing.h instead of gtk2drawing.h
1550         * Scripts/webkitpy/style/checker_unittest.py: Update the unit test to reflect the change.
1551
1552 2010-07-04  MORITA Hajime  <morrita@google.com>
1553
1554         rebaseline-chromium-webkit-tests: UnicodeDecodeError
1555         https://bugs.webkit.org/show_bug.cgi?id=41589
1556
1557         * run() method can result non-utf-8 bytes, that causes utf-8
1558           decoding fail.  Fixed to disable decoding.
1559         * Fixed Git.find_checkout_root() to make a test pass.
1560
1561         * Scripts/webkitpy/common/checkout/scm.py:
1562         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1563
1564 2010-07-03  Patrick Gansterer  <paroga@paroga.com>
1565
1566         Reviewed by Simon Hausmann.
1567
1568         [Qt] Fix DumpRenderTree userStyleSheet handling.
1569         https://bugs.webkit.org/show_bug.cgi?id=41570
1570
1571         DumpRenderTree did only set the userStyleSheet at
1572         layoutTestController.setUserStyleSheetEnabled().
1573
1574         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1575         (LayoutTestController::reset):
1576         (LayoutTestController::setUserStyleSheetLocation):
1577         (LayoutTestController::setUserStyleSheetEnabled):
1578         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1579
1580 2010-07-03  Robert Hogan  <robert@webkit.org>
1581
1582         Reviewed by Kenneth Rohde Christiansen.
1583
1584         [Qt] support dumpChildFrameScrollPositions
1585
1586         https://bugs.webkit.org/show_bug.cgi?id=41088
1587
1588         Unskip:
1589
1590         http/tests/navigation/anchor-subframeload.html
1591         http/tests/navigation/relativeanchor-frames.html
1592
1593         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1594         (WebCore::DumpRenderTree::dumpFrameScrollPosition):
1595         (WebCore::DumpRenderTree::dump):
1596         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1597         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1598         (LayoutTestController::reset):
1599         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1600         (LayoutTestController::shouldDumpChildFrameScrollPositions):
1601         (LayoutTestController::dumpChildFrameScrollPositions):
1602
1603 2010-07-02  Sam Weinig  <sam@webkit.org>
1604
1605         Reviewed by Anders Carlsson.
1606
1607         Rename new scripts so that they don't make autocompleting run-webkit-tests annoying.
1608
1609         * Scripts/debug-test-runner: Copied from Scripts/debug-webkittestrunner.
1610         * Scripts/debug-webkittestrunner: Removed.
1611         * Scripts/run-test-runner: Copied from Scripts/run-webkittestrunner.
1612         * Scripts/run-webkittestrunner: Removed.
1613
1614 2010-07-02  Brian Weinstein  <bweinstein@apple.com>
1615
1616         Reviewed by Steve Falkenburg.
1617
1618         Some http tests fail on Windows with Cygwin 1.7
1619         https://bugs.webkit.org/show_bug.cgi?id=41537
1620         
1621         With Cygwin 1.7, the registry key at SOFTWARE\\Cygnus Solutions\\Cygwin\\mounts v2\\/
1622         doesn't exist anymore, because the mount points are stored in /etc/fstab. However, we
1623         just need root mount point, which is defined in SOFTWARE\\Cygwin\\setup.
1624
1625         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1626         (resolveCygwinPath): Fall back to SOFTWARE\\Cygwin\\setup if 
1627             SOFTWARE\\Cygnus Solutions\\Cygwin\\mounts v2\\/ doesn't work.
1628
1629 2010-06-23  Martin Robinson  <mrobinson@igalia.com>
1630
1631         Reviewed by Gustavo Noronha Silva.
1632
1633         [GTK] Separate DerivedSources per-project
1634         https://bugs.webkit.org/show_bug.cgi?id=41109
1635
1636         The JavaScriptCore cppflags used to include the top-level DerivedSources directory
1637         allowing the tools to build as a side-effect. Now that the top-level directory
1638         is no longer in the list of JavaScriptCore includes, include it explicitly.
1639
1640         * GNUmakefile.am:
1641
1642 2010-07-01  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1643
1644         Reviewed by Kenneth Rohde Christiansen.
1645
1646         [Qt] Make context menus show up in the right place in QTestBrowser
1647
1648         Context menus were shown at scene-relative coordinates for
1649         QGraphicsWebView while QMenu expects them to be global. The
1650         change to the QWidget case was to get rid of the mapToGlobal.
1651
1652         * QtTestBrowser/webview.cpp:
1653
1654 2010-07-01  Robert Hogan <robert@webkit.org>
1655
1656         Reviewed by Kenneth Rohde Christiansen.
1657
1658         [Qt] dump frames in ascending alphabetical order of title
1659
1660         https://bugs.webkit.org/show_bug.cgi?id=41261
1661
1662         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1663         (WebCore::dumpHistoryItem):
1664
1665 2010-07-01  Martin Robinson  <mrobinson@igalia.com>
1666
1667         Unreviewed. 
1668
1669         Fix the GTK+ build after r62278.
1670
1671         * Scripts/webkitdirs.pm: If the make arguments have already been specified,
1672         let them override the automatic CPU detection for autotools builds.
1673
1674 2010-07-01  Martin Robinson  <mrobinson@igalia.com>
1675
1676         Unreviewed.
1677
1678         Fix the Windows build after r62278.
1679
1680         * Scripts/num-cpus: Use FindBin to add the Scripts directory to the list of library directories.
1681
1682 2010-07-01  Martin Robinson  <mrobinson@igalia.com>
1683
1684         Reviewed by Gustavo Noronha Silva.
1685
1686         [GTK] build-webkit does not detect the number of CPUs
1687         https://bugs.webkit.org/show_bug.cgi?id=41469
1688
1689         Pass the appropriate -j<#> flag to make when building autotools builds.
1690         This causes make to spawn that many number of child processes for doing
1691         parallel builds.
1692
1693         * Scripts/num-cpus: Use the newly abstracted numberOfCPUs to return the number
1694         of CPUs. This makes the script work across more platforms.
1695         * Scripts/webkitdirs.pm: Create a numberOfCPUs/determineNumberOfCPUs to determine the
1696         number of CPUs across several platforms. Use this new function to determine the appropriate
1697         arguments to pass to make for doing parallel builds with autotools build files.
1698
1699 2010-07-01  Simon Hausmann  <simon.hausmann@nokia.com>
1700
1701         Rubber-stamped by Laszlo Gombos.
1702
1703         [Qt][Symbian] Bumped up the maximum heap size to 96MB
1704
1705         * QtTestBrowser/QtTestBrowser.pro: Removed explicit heap size declaration
1706         and use the one from WebKit.pri instead.
1707
1708 2010-07-01  Adam Barth  <abarth@webkit.org>
1709
1710         Reviewed by Eric Seidel.
1711
1712         Promote webkit-patch land-safely to main help
1713         https://bugs.webkit.org/show_bug.cgi?id=41446
1714
1715         I've been using this command a bunch and recommending it to folks.  We
1716         should show it in main help as it's past the experimental phase.
1717
1718         * Scripts/webkitpy/tool/commands/upload.py:
1719
1720 2010-06-28  MORITA Hajime  <morrita@google.com>
1721
1722         Reviewed by Shinichiro Hamaji.
1723
1724         rebaseline-chromium-webkit-tests doesn't do diffs right with a Git checkout of WebKit
1725         https://bugs.webkit.org/show_bug.cgi?id=38775
1726
1727         - Introduced SCM.show_head() and SCM.diff_for_file().
1728         - Replaced direct svn invocations with newly implement SCM methods.
1729
1730         * Scripts/webkitpy/common/checkout/scm.py:
1731         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1732         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1733
1734 2010-06-30  Simon Fraser  <simon.fraser@apple.com>
1735
1736         Reviewed by Sam Weinig.
1737
1738         Allow MiniBrowser to open local files
1739         https://bugs.webkit.org/show_bug.cgi?id=41104
1740
1741         Wire up the openDocument: message with an NSOpenPanel, so we can open
1742         local files.
1743         
1744         Also change the xib so that the window remembers its size.
1745         
1746         * MiniBrowser/mac/AppDelegate.m:
1747         (-[BrowserAppDelegate frontmostBrowserWindowController]):
1748         (-[BrowserAppDelegate openDocument:]):
1749         (-[BrowserAppDelegate openPanelDidEnd:returnCode:contextInfo:]):
1750         * MiniBrowser/mac/English.lproj/BrowserWindow.xib:
1751
1752 2010-06-30  Sam Weinig  <sam@webkit.org>
1753
1754         Rubber-stamped by Anders Carlsson.
1755
1756         Add debug-webkittestrunner and cleanup related scripts.
1757
1758         * Scripts/debug-webkittestrunner: Added.
1759         * Scripts/run-webkittestrunner:
1760         * Scripts/webkitdirs.pm:
1761
1762 2010-06-30  Kevin Ollivier  <kevino@theolliviers.com>
1763
1764         [wx] Build fix after recent changes to LayoutTestController.
1765
1766         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1767         (LayoutTestController::pageSizeAndMarginsInPixels):
1768
1769 2010-06-29  Sam Weinig  <sam@webkit.org>
1770
1771         Reviewed by Anders Carlsson.
1772
1773         Patch for https://bugs.webkit.org/show_bug.cgi?id=41389
1774         Make WebKitTestRunner work with more than one test at a time.
1775
1776         This converts WebKitTestRunner to a similar model as DumpRenderTree,
1777         where there is a single WKView and each test is run it, rather than
1778         the design I was using where each test got its own WKView.
1779
1780         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1781         (WTR::InjectedBundle::didRecieveMessage):
1782         (WTR::InjectedBundle::reset):
1783         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1784         * WebKitTestRunner/TestController.cpp:
1785         (WTR::TestController::initialize):
1786         (WTR::TestController::runTest):
1787         (WTR::TestController::_didRecieveMessageFromInjectedBundle):
1788         (WTR::TestController::didRecieveMessageFromInjectedBundle):
1789         * WebKitTestRunner/TestController.h:
1790         (WTR::TestController::mainWebView):
1791         (WTR::TestController::pageNamespace):
1792         (WTR::TestController::context):
1793         * WebKitTestRunner/TestInvocation.cpp:
1794         (WTR::TestInvocation::TestInvocation):
1795         (WTR::TestInvocation::~TestInvocation):
1796         (WTR::TestInvocation::invoke):
1797         (WTR::TestInvocation::didRecieveMessageFromInjectedBundle):
1798         * WebKitTestRunner/TestInvocation.h:
1799
1800 2010-06-30  Simon Hausmann  <simon.hausmann@nokia.com>
1801
1802         Reviewed by Laszlo Gombos.
1803
1804         [Qt][Symbian] Only 10 websites can be loaded consecutively when using QtWebkit 2.0
1805         https://bugs.webkit.org/show_bug.cgi?id=40446
1806
1807         We quickly run out of memory on Symbian when loading web pages. This is
1808         caused by the default heap size, which is not suited for a web browser.
1809
1810         This change bumps the max heap size to 32MB.
1811
1812         * QtTestBrowser/QtTestBrowser.pro:
1813
1814 2010-06-30  Eric Seidel  <eric@webkit.org>
1815
1816         Reviewed by Adam Barth.
1817
1818         webkit-patch land allow the user to continue even if the builders are red
1819         https://bugs.webkit.org/show_bug.cgi?id=41395
1820
1821         I don't think it's good that we've been teaching people
1822         to always pass --ignore-builders.  At least land is now
1823         useable w/o --ignore-builders.
1824
1825         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
1826
1827 2010-06-29  Robert Hogan  <robert@webkit.org>
1828
1829         Reviewed by Kenneth Rohde Christiansen.
1830
1831         [Qt] support dumpResourceResponseMIMETypes
1832         https://bugs.webkit.org/show_bug.cgi?id=41260
1833
1834         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1835         (LayoutTestController::reset):
1836         (LayoutTestController::dumpResourceResponseMIMETypes):
1837         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1838
1839 2010-06-29  Diego Gonzalez  <diegohcg@webkit.org>
1840
1841         Reviewed by Kenneth Rohde Christiansen.
1842
1843         [Qt] Resize scene when Qt DRT WebPage receives a geometry change request
1844         https://bugs.webkit.org/show_bug.cgi?id=41173
1845
1846         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1847         (WebCore::WebPage::setViewGeometry):
1848         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1849
1850 2010-06-29  Diego Gonzalez  <diegohcg@webkit.org>
1851
1852         Reviewed by Simon Hausmann.
1853
1854         [Qt] Deal with postEvent in case of graphics based DRT
1855         https://bugs.webkit.org/show_bug.cgi?id=41174
1856
1857         QGraphicsScene does not have a postEvent method, so make scene
1858         send the event, in case of graphics based DRT, and delete it after that.
1859
1860         * DumpRenderTree/qt/EventSenderQt.cpp:
1861         (EventSender::scheduleAsynchronousClick):
1862         (EventSender::replaySavedEvents):
1863         (EventSender::postEvent):
1864         * DumpRenderTree/qt/EventSenderQt.h:
1865
1866 2010-06-29  Diego Gonzalez  <diegohcg@webkit.org>
1867
1868         Reviewed by Kenneth Rohde Christiansen.
1869
1870         [Qt] Make switchFocus() method works with QGraphicsWebView in Qt DRT
1871         https://bugs.webkit.org/show_bug.cgi?id=41172
1872
1873         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1874         (WebCore::DumpRenderTree::switchFocus):
1875
1876 2010-06-29  Mario Sanchez Prada  <msanchez@igalia.com>
1877
1878         Reviewed by Xan Lopez.
1879
1880         [Gtk] Make DRT more coherent with other ports to allow reusing more tests
1881         https://bugs.webkit.org/show_bug.cgi?id=40009
1882
1883         Make sure "AXRole: ", "AXTitle: " and "AXDescription: " prefixes
1884         are used when returning those values, for coherency with other ports.
1885
1886         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1887         (AccessibilityUIElement::role):
1888         (AccessibilityUIElement::title):
1889         (AccessibilityUIElement::description):
1890
1891 2010-06-29  Sheriff Bot  <webkit.review.bot@gmail.com>
1892
1893         Unreviewed, rolling out r62106.
1894         http://trac.webkit.org/changeset/62106
1895         https://bugs.webkit.org/show_bug.cgi?id=41346
1896
1897         "Broke editing tests" (Requested by xan_ on #webkit).
1898
1899         * Scripts/old-run-webkit-tests:
1900
1901 2010-06-29  Mario Sanchez Prada  <msanchez@igalia.com>
1902
1903         Reviewed by Xan Lopez.
1904
1905         Ensure DRT loads GAIL (Gtk+ module), for a11y tests
1906         https://bugs.webkit.org/show_bug.cgi?id=38648
1907
1908         Add the GTK_MODULES envvar (set to "gail") to the clean
1909         environment when running DRT for the Gtk+ port
1910
1911         * Scripts/old-run-webkit-tests:
1912
1913 2010-06-28  Adam Barth  <abarth@webkit.org>
1914
1915         Unreviewed.
1916
1917         Switch test-html5-parser back to using runner.html.
1918
1919         * Scripts/test-html5-parser:
1920
1921 2010-06-28  Adam Barth  <abarth@webkit.org>
1922
1923         Reviewed by Eric Seidel.
1924
1925         Restore webkit-runner.html for use with new tree builder
1926         https://bugs.webkit.org/show_bug.cgi?id=41317
1927
1928         For now, we just want to run webkit-runner when we test-html5-parser.
1929
1930         * Scripts/test-html5-parser:
1931
1932 2010-06-23  John Gregg  <johnnyg@google.com>
1933
1934         Reviewed by Kent Tamura.
1935
1936         add ENABLE_DIRECTORY_UPLOAD build support
1937         https://bugs.webkit.org/show_bug.cgi?id=41100
1938
1939         * Scripts/build-webkit:
1940
1941 2010-06-28  Gustavo Noronha Silva  <gns@gnome.org>
1942
1943         Rubber-stamped by Xan Lopez.
1944
1945         Update webkitdirs's knowledge of our library's name.
1946
1947         * Scripts/webkitdirs.pm:
1948
1949 2010-06-28  Sam Weinig  <sam@webkit.org>
1950
1951         Reviewed by Anders Carlsson.
1952
1953         Patch for https://bugs.webkit.org/show_bug.cgi?id=41299
1954         Build up WebKitTestRunner output in the InjectedBundle
1955
1956         Simplify WebKitTestRunner by building up the output in the InjectedBundle
1957         and sending it over postMessage when done, instead of using the async
1958         WKPageRenderTreeExternalRepresentation.
1959
1960         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1961         (WTR::InjectedBundle::done):
1962         (WTR::InjectedBundle::didRecieveMessage):
1963         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1964         (WTR::InjectedBundle::os):
1965         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1966         (WTR::WKStringToUTF8):
1967         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1968         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1969         * WebKitTestRunner/TestInvocation.cpp:
1970         (WTR::WKStringToUTF8):
1971         (WTR::TestInvocation::TestInvocation):
1972         (WTR::TestInvocation::invoke):
1973         (WTR::TestInvocation::initializeMainWebView):
1974         (WTR::TestInvocation::_didRecieveMessageFromInjectedBundle):
1975         (WTR::TestInvocation::didRecieveMessageFromInjectedBundle):
1976         * WebKitTestRunner/TestInvocation.h:
1977
1978 2010-06-28  Robert Hogan  <robert@webkit.org>
1979
1980         Unreviewed, rolling out r62021.
1981         http://trac.webkit.org/changeset/62021
1982         https://bugs.webkit.org/show_bug.cgi?id=41261
1983
1984         Broke http/navigation tests among other
1985
1986         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1987         (WebCore::DumpRenderTree::dumpFramesAsText):
1988
1989 2010-06-28  Sam Weinig  <sam@webkit.org>
1990
1991         Reviewed by Anders Carlsson.
1992
1993         Add run-webkittestrunner to run WebKitTestRunner with the appropriate
1994         environment.
1995
1996         * Scripts/run-webkittestrunner: Added.
1997         * Scripts/webkitdirs.pm:
1998
1999 2010-06-28  Robert Hogan  <robert@webkit.org>
2000
2001         Reviewed by Kenneth Rohde Christiansen.
2002
2003         [Qt] dump frames in ascending alphabetical order of title
2004
2005         https://bugs.webkit.org/show_bug.cgi?id=41261
2006
2007         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2008         (WebCore::DumpRenderTree::dumpFramesAsText):
2009
2010 2010-06-28  Robert Hogan  <robert@webkit.org>
2011
2012         Reviewed by Kenneth Rohde Christiansen.
2013
2014         [Qt] dump bf history of child windows
2015
2016         https://bugs.webkit.org/show_bug.cgi?id=41266
2017
2018         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2019         (WebCore::DumpRenderTree::dumpBackForwardList):
2020         (WebCore::DumpRenderTree::dump):
2021         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2022
2023 2010-06-28  Sam Weinig  <sam@webkit.org>
2024
2025         Reviewed by Anders Carlsson.
2026
2027         Patch for https://bugs.webkit.org/show_bug.cgi?id=41288
2028         WebKit2: Add frame API for InjectedBundle code
2029
2030         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2031         (_didClearWindowForFrame):
2032
2033 2010-06-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2034
2035         Reviewed by Kenneth Rohde Christiansen.
2036
2037         [Qt] QtTestBrowser does not have a "Load" button ; therefore, unable to load pages on touch only symbian devices (portrait mode).
2038         https://bugs.webkit.org/show_bug.cgi?id=38597
2039
2040         Fix behavior so reload button really acts as a load and a reload button.
2041
2042         * QtTestBrowser/mainwindow.cpp:
2043         (MainWindow::changeLocation):
2044
2045 2010-06-28  Xan Lopez  <xlopez@igalia.com>
2046
2047         Reviewed by Gustavo Noronha.
2048
2049         [GTK] Does not compile with -DGSEAL_ENABLE
2050         https://bugs.webkit.org/show_bug.cgi?id=37851
2051
2052         Fix build with GSEAL enabled.
2053
2054         * DumpRenderTree/gtk/EventSender.cpp:
2055         (gtk_widget_get_window):
2056         (prepareMouseButtonEvent):
2057         (mouseMoveToCallback):
2058         (mouseWheelToCallback):
2059         (keyDownCallback):
2060
2061 2010-06-28  Xan Lopez  <xlopez@igalia.com>
2062
2063         Reviewed by Gustavo Noronha.
2064
2065         [GTK] Add support for GTK+3
2066         https://bugs.webkit.org/show_bug.cgi?id=41253
2067
2068         Adapt build system for 3.x support.
2069
2070         * GNUmakefile.am:
2071
2072 2010-06-10  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2073
2074         Reviewed by Simon Hausmann.
2075
2076         [QT][S60] build-webkit scripts picks wrong make spec for windows build
2077         https://bugs.webkit.org/show_bug.cgi?id=41198
2078
2079         Instead of checking for existence of %EPOCROOT% on windows, mandatory use of --symbian flag for symbian builds. 
2080
2081         * Scripts/webkitdirs.pm:
2082         (determineIsSymbian): remove check for %EPOCROOT% as one can build for windows port of QT as well
2083
2084 2010-06-28  Eric Seidel  <eric@webkit.org>
2085
2086         Reviewed by Adam Barth.
2087
2088         Make it possible to test the new HTML5 TreeBuilder
2089         https://bugs.webkit.org/show_bug.cgi?id=41276
2090
2091         Adam was concerned that someone might make their port
2092         depend on this setting (I guess we had some trouble with that
2093         with the HTML5Parser setting), so I littered the code with warnings.
2094
2095         test-html5-parser now tests this code path.
2096
2097         * DumpRenderTree/mac/DumpRenderTree.mm:
2098         (resetDefaultsToConsistentValues):
2099         (initializeGlobalsFromCommandLineOptions):
2100         * Scripts/test-html5-parser:
2101
2102 2010-06-27  MORITA Hajime  <morrita@google.com>
2103
2104         Unreviewed. 
2105         
2106         Some never-called @staticmethods touched self. 
2107         Fixed it to replace these self with a class.
2108
2109         * Scripts/webkitpy/common/checkout/scm.py:
2110
2111 2010-06-27  MORITA Hajime  <morrita@google.com>
2112
2113         Unreviewed.
2114         
2115         Fixed exception raising syntax that is pointed out at
2116         https://bugs.webkit.org/show_bug.cgi?id=41153
2117
2118         * Scripts/webkitpy/common/checkout/scm.py:
2119         * Scripts/webkitpy/common/checkout/scm_unittest.py: 
2120           Removed a bad line that I accidentally checked-in at last revision.
2121
2122 2010-06-24  MORITA Hajime  <morrita@google.com>
2123
2124         Reviewed by Eric Seidel.
2125
2126         rebaseline-chromium-webkit-tests should add or remove files to local git repository
2127         https://bugs.webkit.org/show_bug.cgi?id=41153
2128
2129         - Added SCM.add() and SCM.remove()
2130         - Replaced "svn add" and "svn remove"
2131           rebaseline_chromium_webkit_tests.py: in with SCM method equivalents.
2132         - add "-U" and "-q" options to rebaseline_chromium_webkit_tests.py
2133           for debugging purpose.
2134
2135         * Scripts/webkitpy/common/checkout/scm.py:
2136         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2137         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2138
2139 2010-06-25  Yuzo Fujishima  <yuzo@google.com>
2140
2141         Reviewed by Shinichiro Hamaji.
2142
2143         Improve default value handling for page format properties.
2144         https://bugs.webkit.org/show_bug.cgi?id=41150
2145
2146         * DumpRenderTree/LayoutTestController.cpp:
2147         (parsePageNumber):
2148         (parsePageNumberSizeMarings):
2149         (pageSizeAndMarginsInPixelsCallback):
2150         (LayoutTestController::staticFunctions):
2151         * DumpRenderTree/LayoutTestController.h:
2152         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2153         (LayoutTestController::pageSizeAndMarginsInPixels):
2154         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2155         (LayoutTestController::pageSizeAndMarginsInPixels):
2156         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2157         (LayoutTestController::pageSizeAndMarginsInPixels):
2158
2159 2010-06-21  Robert Hogan  <robert@webkit.org>
2160
2161         Reviewed by Kenneth Rohde Christiansen.
2162
2163         [Qt] DRT Support for setCustomPolicyDelegate
2164
2165         https://bugs.webkit.org/show_bug.cgi?id=39564
2166
2167         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2168         (LayoutTestController::setCustomPolicyDelegate):
2169         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2170
2171 2010-06-26  Robert Hogan  <robert@webkit.org>
2172
2173         Unreviewed, Qt build fix following http://trac.webkit.org/changeset/61879
2174         
2175         Remove qwebscriptworld.h from LayoutTestControllerQt.cpp - it is no longer
2176         exported.
2177
2178         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2179
2180 2010-06-26  Tony Gentilcore  <tonyg@chromium.org>
2181
2182         Reviewed by Dimitri Glazkov.
2183
2184         Add a build-webkit option for enabling Web Timing support.
2185         https://bugs.webkit.org/show_bug.cgi?id=38924
2186
2187         * Scripts/build-webkit:
2188
2189 2010-06-25  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2190
2191         Reviewed by Kenneth Rohde Christiansen.
2192
2193         [Qt] QtTestBrowser does not have a "Load" button ; therefore, unable to load pages on touch only symbian devices (portrait mode).
2194         https://bugs.webkit.org/show_bug.cgi?id=38597
2195
2196         Make the reload button act as a load button as well.
2197
2198         * QtTestBrowser/mainwindow.cpp:
2199         (MainWindow::buildUI):
2200         (MainWindow::changeLocation):
2201
2202 2010-06-25  Prasad Tammana  <prasadt@chromium.org>
2203
2204         Reviewed by Dmitry Titov.
2205
2206         Add empty abortModal() method to all platforms.
2207         https://bugs.webkit.org/show_bug.cgi?id=40864
2208
2209         Add an empty abortModal() stub to LayoutTestController on all platforms to get rid of platform specific #ifs in
2210         platform independent LayoutTestController code.  Without this change, layout tests using LayoutTestController tests
2211         that use abortModal will become mac specific which is not desirable.
2212
2213         * DumpRenderTree/LayoutTestController.cpp:
2214         (abortModalCallback):
2215         (LayoutTestController::staticFunctions):
2216         * DumpRenderTree/LayoutTestController.h:
2217         * DumpRenderTree/chromium/LayoutTestController.cpp:
2218         (LayoutTestController::LayoutTestController):
2219         (LayoutTestController::abortModal):
2220         * DumpRenderTree/chromium/LayoutTestController.h:
2221         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2222         (LayoutTestController::abortModal):
2223         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2224         (LayoutTestController::abortModal):
2225         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2226         (LayoutTestController::abortModal):
2227         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2228         (LayoutTestController::abortModal):
2229
2230 2010-06-25  Sam Weinig  <sam@webkit.org>
2231
2232         Reviewed by Anders Carlsson.
2233
2234         Patch for https://bugs.webkit.org/show_bug.cgi?id=41226
2235         Flesh out injected bundle code for WebKitTestRunner and add basic LayoutTestController.
2236
2237         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Added.
2238         (WTR::InjectedBundle::shared):
2239         (WTR::InjectedBundle::InjectedBundle):
2240         (WTR::InjectedBundle::_didCreatePage):
2241         (WTR::InjectedBundle::_willDestroyPage):
2242         (WTR::InjectedBundle::_didRecieveMessage):
2243         (WTR::InjectedBundle::initialize):
2244         (WTR::InjectedBundle::didCreatePage):
2245         (WTR::InjectedBundle::willDestroyPage):
2246         (WTR::InjectedBundle::didRecieveMessage):
2247         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Added.
2248         (WTR::InjectedBundle::layoutTestController):
2249         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
2250         (WKBundleInitialize):
2251         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Added.
2252         (WTR::InjectedBundlePage::InjectedBundlePage):
2253         (WTR::InjectedBundlePage::~InjectedBundlePage):
2254         (WTR::InjectedBundlePage::_didStartProvisionalLoadForFrame):
2255         (WTR::InjectedBundlePage::_didReceiveServerRedirectForProvisionalLoadForFrame):
2256         (WTR::InjectedBundlePage::_didFailProvisionalLoadWithErrorForFrame):
2257         (WTR::InjectedBundlePage::_didCommitLoadForFrame):
2258         (WTR::InjectedBundlePage::_didFinishLoadForFrame):
2259         (WTR::InjectedBundlePage::_didFailLoadWithErrorForFrame):
2260         (WTR::InjectedBundlePage::_didReceiveTitleForFrame):
2261         (WTR::InjectedBundlePage::_didClearWindowForFrame):
2262         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
2263         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
2264         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
2265         (WTR::InjectedBundlePage::didCommitLoadForFrame):
2266         (WTR::InjectedBundlePage::didFinishLoadForFrame):
2267         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
2268         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
2269         (WTR::InjectedBundlePage::didClearWindowForFrame):
2270         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added.
2271         (WTR::InjectedBundlePage::page):
2272         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Added.
2273         (WTR::LayoutTestController::create):
2274         (WTR::LayoutTestController::LayoutTestController):
2275         (WTR::LayoutTestController::~LayoutTestController):
2276         (WTR::dumpAsTextCallback):
2277         (WTR::layoutTestControllerObjectFinalize):
2278         (WTR::LayoutTestController::makeWindowObject):
2279         (WTR::LayoutTestController::getJSClass):
2280         (WTR::LayoutTestController::staticFunctions):
2281         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added.
2282         (WTR::LayoutTestController::dumpAsText):
2283         (WTR::LayoutTestController::setDumpAsText):
2284         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2285
2286 2010-06-25  Sam Weinig  <sam@webkit.org>
2287
2288         Reviewed by Anders Carlsson.
2289
2290         Make WebKitTestRunner really work with run-webkit-tests. 
2291
2292         - Add Forwarding headers to allow some cleanup.
2293
2294         * WebKitTestRunner/ForwardingHeaders: Added.
2295         * WebKitTestRunner/ForwardingHeaders/wtf: Added.
2296         * WebKitTestRunner/ForwardingHeaders/wtf/ASCIICType.h: Added.
2297         * WebKitTestRunner/ForwardingHeaders/wtf/Assertions.h: Added.
2298         * WebKitTestRunner/ForwardingHeaders/wtf/Atomics.h: Added.
2299         * WebKitTestRunner/ForwardingHeaders/wtf/FastMalloc.h: Added.
2300         * WebKitTestRunner/ForwardingHeaders/wtf/HashMap.h: Added.
2301         * WebKitTestRunner/ForwardingHeaders/wtf/HashSet.h: Added.
2302         * WebKitTestRunner/ForwardingHeaders/wtf/HashTraits.h: Added.
2303         * WebKitTestRunner/ForwardingHeaders/wtf/Locker.h: Added.
2304         * WebKitTestRunner/ForwardingHeaders/wtf/MainThread.h: Added.
2305         * WebKitTestRunner/ForwardingHeaders/wtf/MathExtras.h: Added.
2306         * WebKitTestRunner/ForwardingHeaders/wtf/Noncopyable.h: Added.
2307         * WebKitTestRunner/ForwardingHeaders/wtf/OwnPtr.h: Added.
2308         * WebKitTestRunner/ForwardingHeaders/wtf/OwnPtrCommon.h: Added.
2309         * WebKitTestRunner/ForwardingHeaders/wtf/PassOwnPtr.h: Added.
2310         * WebKitTestRunner/ForwardingHeaders/wtf/PassRefPtr.h: Added.
2311         * WebKitTestRunner/ForwardingHeaders/wtf/Platform.h: Added.
2312         * WebKitTestRunner/ForwardingHeaders/wtf/RefCounted.h: Added.
2313         * WebKitTestRunner/ForwardingHeaders/wtf/RefPtr.h: Added.
2314         * WebKitTestRunner/ForwardingHeaders/wtf/RetainPtr.h: Added.
2315         * WebKitTestRunner/ForwardingHeaders/wtf/StringExtras.h: Added.
2316         * WebKitTestRunner/ForwardingHeaders/wtf/ThreadSafeShared.h: Added.
2317         * WebKitTestRunner/ForwardingHeaders/wtf/Threading.h: Added.
2318         * WebKitTestRunner/ForwardingHeaders/wtf/ThreadingPrimitives.h: Added.
2319         * WebKitTestRunner/ForwardingHeaders/wtf/Vector.h: Added.
2320         * WebKitTestRunner/TestInvocation.cpp:
2321         (WTR::TestInvocation::dump): Dump the right number of #EOFs.
2322         * WebKitTestRunner/TestInvocation.h:
2323
2324 2010-06-25  Sam Weinig  <sam@webkit.org>
2325
2326         Reviewed by Mark Rowe.
2327
2328         Add support for WebKitTestRunner to old-run-webkit-tests
2329
2330         - Also adds a script to build WebKitTestRunner for old-run-webkit-tests to use.
2331
2332         * Scripts/build-webkittestrunner: Added.
2333         * Scripts/old-run-webkit-tests:
2334
2335 2010-06-25  Adam Barth  <abarth@webkit.org>
2336
2337         Reviewed by David Levin.
2338
2339         Incremental build failed on Chromium ews
2340         https://bugs.webkit.org/show_bug.cgi?id=41011
2341
2342         The division of responsibility between update-webkit --chromium and
2343         build-webkit --chromium is slightly unclear.  In this patch, we make
2344         build-webkit --chromium also update DEPS and re-run GYP in case the
2345         developer has changed either since they updated.
2346
2347         This change is also helpful for the EWS, which wants to update DEPS and
2348         re-run GYP after applying patches, but the EWS doesn't want to run
2349         update-webkit --chromium because it has a dirty working copy.
2350
2351         * Scripts/webkitdirs.pm:
2352
2353 2010-06-25  Robert Hogan  <robert@webkit.org>
2354
2355         Reviewed by Simon Hausmann.
2356
2357         [Qt] Support evaluateScriptInIsolatedWorld()
2358
2359         https://bugs.webkit.org/show_bug.cgi?id=40079
2360
2361         Remove evaluateScriptInIsolatedWorld() from QtWebKit API.
2362         Remove QWebScriptWorld from exported headers.
2363         Confine support to DumpRenderTreeSupportQt so that the tests can pass.
2364
2365         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2366         (LayoutTestController::reset):
2367         (LayoutTestController::evaluateScriptInIsolatedWorld):
2368         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2369
2370 2010-06-25  Anders Carlsson  <andersca@apple.com>
2371
2372         Revert accidental part and add a newline.
2373
2374         * MiniBrowser/mac/AppDelegate.m:
2375         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2376
2377 2010-06-25  Anders Carlsson  <andersca@apple.com>
2378
2379         Rubber-stamped by Dan Bernstein.
2380
2381         Add a LOG macro that expands to a no-op by default.
2382
2383         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2384         * MiniBrowser/mac/AppDelegate.m:
2385         (_didRecieveMessageFromInjectedBundle):
2386         * MiniBrowser/mac/BrowserWindowController.m:
2387         (-[BrowserWindowController windowShouldClose:]):
2388         (_didStartProvisionalLoadForFrame):
2389         (_didReceiveServerRedirectForProvisionalLoadForFrame):
2390         (_didFailProvisionalLoadWithErrorForFrame):
2391         (_didCommitLoadForFrame):
2392         (_didFinishLoadForFrame):
2393         (_didFailLoadWithErrorForFrame):
2394         (_didReceiveTitleForFrame):
2395         (_didFirstLayoutForFrame):
2396         (_didFirstVisuallyNonEmptyLayoutForFrame):
2397         (_didBecomeUnresponsive):
2398         (_didBecomeResponsive):
2399         (_decidePolicyForNavigationAction):
2400         (_decidePolicyForNewWindowAction):
2401         (_createNewPage):
2402         (_showPage):
2403         (_closePage):
2404         (_didNavigateWithNavigationData):
2405         (_didPerformClientRedirect):
2406         (_didPerformServerRedirect):
2407         (_didUpdateHistoryTitle):
2408         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2409         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2410         (_didClearWindowForFrame):
2411         (_didCreatePage):
2412         (_willDestroyPage):
2413         (_didRecieveMessage):
2414
2415 2010-06-24  Adam Barth  <abarth@webkit.org>
2416
2417         Reviewed by Eric Seidel.
2418
2419         commit-queue is taking too long to land patches because of red trees
2420         https://bugs.webkit.org/show_bug.cgi?id=41194
2421
2422         Instead of checking for the tree to be green, we'll just spin hot
2423         trying to land patches.  This is probably too extreme in ignoring the
2424         tree, but I think we should try it for a while to see if we have
2425         trouble.  That will help us find the right balance.
2426
2427         * Scripts/webkitpy/tool/commands/queues.py:
2428         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2429
2430 2010-06-24  Martin Robinson  <mrobinson@igalia.com>
2431
2432         Reviewed by Xan Lopez.
2433
2434         [GTK] Clean up the use of gdk_window_get_root_coords in EventSender
2435         https://bugs.webkit.org/show_bug.cgi?id=40843
2436
2437         Define the version for old GTK+s in a way that is forward-compatible
2438         and clean up the logic a bit.
2439
2440         * DumpRenderTree/gtk/EventSender.cpp:
2441         (gdk_window_get_root_coords): Renamed and cleaned up.
2442         (prepareMouseButtonEvent): Remove #ifdefs.
2443         (mouseMoveToCallback): Remove #ifdefs.
2444
2445 2010-06-24  Dimitri Glazkov  <dglazkov@chromium.org>
2446
2447         Reviewed by Eric Seidel.
2448
2449         Fix NewRunWebKitTests to work on Windows.
2450         https://bugs.webkit.org/show_bug.cgi?id=41180
2451
2452         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added "perl" as first arguments,
2453             because Windows fails to understand what we're asking of it.
2454
2455 2010-06-24  Martin Robinson  <mrobinson@igalia.com>
2456
2457         Reviewed by Xan Lopez.
2458
2459         [GTK] The url passed to the WebView during layout tests is invalid
2460         https://bugs.webkit.org/show_bug.cgi?id=40832
2461
2462         Set the test URL to the full real file URL and do a small cleanup.
2463         Previously a URL like file://relative/path/to/test.html was passed
2464         to the WebView. This malformed file URL would be returned by
2465         webkit_web_view_get_url and webkit_web_frame_get_url.
2466
2467         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2468         (shouldLogFrameLoadDelegates): Change to take a const string& as the argument.
2469         (shouldOpenWebInspector): Change to take a const string& as the argument.
2470         (shouldEnableDeveloperExtras): Change to take a const string& as the argument.
2471         (runTest): Pass the full file:// URL to the view. Remove the superfluous url variable.
2472
2473 2010-06-24  Sam Weinig  <sam@webkit.org>
2474
2475         Reviewed by Anders Carlsson.
2476
2477         Fix WebKitTestRunner Makefile typos.
2478
2479         * WebKitTestRunner/Makefile:
2480
2481 2010-06-24  Adele Peterson  <adele@apple.com>
2482
2483         Reviewed by Eric Carlson.
2484
2485         DumpRenderTree part of testing <rdar://problem/8093680> "Paste and Match Style" should fire paste events
2486         https://bugs.webkit.org/show_bug.cgi?id=41085
2487
2488         * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
2489         Clear the general pasteboard in between tests so Cut,Copy, and setData on ClipboardData won't have lasting effects.
2490
2491 2010-06-23  Sam Weinig  <sam@webkit.org>
2492
2493         Reviewed by Anders Carlsson.
2494
2495         Patch for https://bugs.webkit.org/show_bug.cgi?id=41086
2496         Add new WebKitTestRunner project (ie. DRT for WebKit2).
2497
2498         - Mac only.
2499         - run-webkit-tests has not been modified to call it yet.
2500         - Only dumps the render tree at this time. 
2501
2502         * WebKitTestRunner: Added.
2503         * WebKitTestRunner/Configurations: Added.
2504         * WebKitTestRunner/Configurations/Base.xcconfig: Added.
2505         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Added.
2506         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Added.
2507         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Added.
2508         * WebKitTestRunner/InjectedBundle: Added.
2509         * WebKitTestRunner/InjectedBundle-Info.plist: Added.
2510         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp: Added.
2511         (_didStartProvisionalLoadForFrame):
2512         (_didReceiveServerRedirectForProvisionalLoadForFrame):
2513         (_didFailProvisionalLoadWithErrorForFrame):
2514         (_didCommitLoadForFrame):
2515         (_didFinishLoadForFrame):
2516         (_didFailLoadWithErrorForFrame):
2517         (_didReceiveTitleForFrame):
2518         (_didClearWindow):
2519         (_didCreatePage):
2520         (_willDestroyPage):
2521         (_didRecieveMessage):
2522         (WKBundleInitialize):
2523         * WebKitTestRunner/Makefile: Added.
2524         * WebKitTestRunner/PlatformWebView.h: Added.
2525         (WTR::PlatformWebView::platformView):
2526         * WebKitTestRunner/TestController.cpp: Added.
2527         (WTR::TestController::shared):
2528         (WTR::TestController::TestController):
2529         (WTR::TestController::initialize):
2530         (WTR::TestController::runTest):
2531         (WTR::TestController::runTestingServerLoop):
2532         (WTR::TestController::run):
2533         * WebKitTestRunner/TestController.h: Added.
2534         (WTR::TestController::verbose):
2535         (WTR::TestController::injectedBundlePath):
2536         * WebKitTestRunner/TestInvocation.cpp: Added.
2537         (WTR::createWKURL):
2538         (WTR::TestInvocation::TestInvocation):
2539         (WTR::TestInvocation::~TestInvocation):
2540         (WTR::TestInvocation::invoke):
2541         (WTR::TestInvocation::dump):
2542         (WTR::TestInvocation::initializeMainWebView):
2543         (WTR::TestInvocation::didStartProvisionalLoadForFrame):
2544         (WTR::TestInvocation::didReceiveServerRedirectForProvisionalLoadForFrame):
2545         (WTR::TestInvocation::didFailProvisionalLoadWithErrorForFrame):
2546         (WTR::TestInvocation::didCommitLoadForFrame):
2547         (WTR::TestInvocation::didFinishLoadForFrame):
2548         (WTR::TestInvocation::didFailLoadForFrame):
2549         (WTR::TestInvocation::renderTreeExternalRepresentationFunction):
2550         (WTR::TestInvocation::renderTreeExternalRepresentationDisposeFunction):
2551         * WebKitTestRunner/TestInvocation.h: Added.
2552         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Added.
2553         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added.
2554         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Added.
2555         * WebKitTestRunner/mac: Added.
2556         * WebKitTestRunner/mac/PlatformWebViewMac.mm: Added.
2557         (WTR::PlatformWebView::PlatformWebView):
2558         (WTR::PlatformWebView::~PlatformWebView):
2559         (WTR::PlatformWebView::page):
2560         * WebKitTestRunner/mac/TestInvocationMac.mm: Added.
2561         (WTR::TestInvocation::runUntil):
2562         * WebKitTestRunner/mac/main.mm: Added.
2563         (main):
2564
2565 2010-06-24  Luiz Agostini  <luiz.agostini@openbossa.org>
2566
2567         Unreviewed. Adding myself to the committers list.
2568
2569         * Scripts/webkitpy/common/config/committers.py:
2570
2571 2010-06-23  Kevin Ollivier  <kevino@theolliviers.com>
2572
2573         [wx] Build fix, adding new LayoutTestController methods and enabling SVG_FOREIGN_OBJECT.
2574
2575         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2576         (LayoutTestController::isPageBoxVisible):
2577         (LayoutTestController::pageAreaRectInPixels):
2578         (LayoutTestController::preferredPageSizeInPixels):
2579         * wx/build/settings.py:
2580
2581 2010-06-23  James Robinson  <jamesr@chromium.org>
2582
2583         Unreviewed.  Add my IRC handle to committers.py so the sheriffbot can yell at me.
2584
2585         * Scripts/webkitpy/common/config/committers.py:
2586
2587 2010-06-23  Kent Tamura  <tkent@chromium.org>
2588
2589         Reviewed by Dimitri Glazkov.
2590
2591         Correct Chromium test configuration
2592         https://bugs.webkit.org/show_bug.cgi?id=41057
2593
2594         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2595          - Add "--use-drt" option for NRWT. It is required for Chromium and
2596            ignored for other platforms.
2597          - Skip JSC test on Chromium
2598         * BuildSlaveSupport/test-result-archive:
2599           Add Chromium support.
2600
2601 2010-06-23  Sam Weinig  <sam@webkit.org>
2602
2603         Reviewed by Anders Carlsson.
2604
2605         Fix for https://bugs.webkit.org/show_bug.cgi?id=41073
2606         WebKit2: Flesh out more of the InjectedBundle client API
2607
2608         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2609         (_didStartProvisionalLoadForFrame):
2610         (_didReceiveServerRedirectForProvisionalLoadForFrame):
2611         (_didFailProvisionalLoadWithErrorForFrame):
2612         (_didCommitLoadForFrame):
2613         (_didFinishLoadForFrame):
2614         (_didFailLoadWithErrorForFrame):
2615         (_didReceiveTitleForFrame):
2616         (_didClearWindowForFrame):
2617         (_didCreatePage):
2618         (_willDestroyPage):
2619         (WKBundleInitialize):
2620
2621 2010-06-23  Yuzo Fujishima  <yuzo@google.com>
2622
2623         Reviewed by Shinichiro Hamaji.
2624
2625         Implement page format data programming interface.
2626         Add methods for testing.
2627         https://bugs.webkit.org/show_bug.cgi?id=37538
2628
2629         * DumpRenderTree/LayoutTestController.cpp:
2630         (parsePageNumber):
2631         (isPageBoxVisibleCallback):
2632         (pageAreaRectInPixelsCallback):
2633         (preferredPageSizeInPixelsCallback):
2634         (LayoutTestController::staticFunctions):
2635         * DumpRenderTree/LayoutTestController.h:
2636         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2637         (LayoutTestController::isPageBoxVisible):
2638         (LayoutTestController::pageAreaRectInPixels):
2639         (LayoutTestController::preferredPageSizeInPixels):
2640         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2641         (LayoutTestController::isPageBoxVisible):
2642         (LayoutTestController::pageAreaRectInPixels):
2643         (LayoutTestController::preferredPageSizeInPixels):
2644         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2645         (LayoutTestController::isPageBoxVisible):
2646         (LayoutTestController::pageAreaRectInPixels):
2647         (LayoutTestController::preferredPageSizeInPixels):
2648
2649 2010-06-23  Sam Magnuson  <smagnuson@netflix.com>
2650
2651         Reviewed by Shinichiro Hamaji.
2652
2653         Follow proper convention for if/switch/while as I've discovered
2654         them to be through my review processes.
2655         https://bugs.webkit.org/show_bug.cgi?id=40723
2656
2657         Modified test so that if( foo ) is not allowed as it appears not
2658         to be the accepted convention.
2659
2660         * Scripts/webkitpy/style/checkers/cpp.py:
2661         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2662
2663 2010-06-22  Eric Seidel  <eric@webkit.org>
2664
2665         Reviewed by Adam Barth.
2666
2667         Run clean-header-guards to fix some header guards
2668         https://bugs.webkit.org/show_bug.cgi?id=41044
2669
2670         No functional changes, thus no tests.
2671
2672         This entire change was generated by running
2673         clean-header-guards, and then reverting changes
2674         to files which shouldn't be changed.  Those which
2675         are left all should be updated.
2676
2677         Some of these changes are just fixing 755 permissions
2678         to be 644, since it seems various files have the wrong
2679         execute bit which don't need it.  clean-header-guards
2680         made those (welcome) permission fixes unintentionally.
2681
2682         * DumpRenderTree/chromium/WebThemeControlDRT.h:
2683         * DumpRenderTree/chromium/WebThemeEngineDRT.h:
2684         * QtTestBrowser/fpstimer.h:
2685
2686 2010-06-22  Adam Barth  <abarth@webkit.org>
2687
2688         Reviewed by Eric Seidel.
2689
2690         Rename HTMLDocumentParser to LegacyHTMLDocumentParser
2691         https://bugs.webkit.org/show_bug.cgi?id=41043
2692
2693         Update the hash.
2694
2695         * Scripts/do-webcore-rename:
2696
2697 2010-06-22  Sam Magnuson  <smagnuson@netflix.com>
2698
2699         Reviewed by Shinichiro Hamaji.
2700
2701         Follow proper convention for variable declaration spacing.
2702         https://bugs.webkit.org/show_bug.cgi?id=40724
2703
2704         Modified test so that 'int   a;' is not allowed.
2705
2706         * Scripts/webkitpy/style/checkers/cpp.py:
2707         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2708
2709 2010-06-22  Eric Seidel  <eric@webkit.org>
2710
2711         Unreviewed.  Add Tony Gentilcore now that he's a committer.
2712
2713         * Scripts/webkitpy/common/config/committers.py:
2714
2715 2010-06-22  Eric Seidel  <eric@webkit.org>
2716
2717         Reviewed by Adam Barth.
2718
2719         Remove Gtk 64-Release bot from core since it's broken
2720         https://bugs.webkit.org/show_bug.cgi?id=41022
2721
2722         This bot alone has been responsible for more than 72 hours of
2723         commit-queue blockage in the last week.  The bot is broken -- keeps
2724         losing its display server or similar.  Until the Gtk folks can fix the
2725         bot, we need to remove it from core.  The WebKit community can't keep
2726         it green as is.
2727
2728         * Scripts/webkitpy/common/net/buildbot.py:
2729         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2730
2731 2010-06-21  Dumitru Daniliuc  <dumi@chromium.org>
2732
2733         Reviewed by Eric Seidel.
2734
2735         Fix the Windows build.
2736         https://bugs.webkit.org/show_bug.cgi?id=40972
2737
2738         * DumpRenderTree/win/ImageDiff.vcproj:
2739
2740 2010-06-21  Prasad Tammana  <prasadt@chromium.org>
2741
2742         Reviewed by Darin Adler, Dmitry Titov.
2743
2744         DumpRenderTree should allow tests with modal dialogs
2745         https://bugs.webkit.org/show_bug.cgi?id=35350
2746
2747         * DumpRenderTree/LayoutTestController.cpp:
2748         (abortModalCallback):
2749         (LayoutTestController::staticFunctions):
2750         * DumpRenderTree/LayoutTestController.h:
2751         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2752         (LayoutTestController::abortModal):
2753         Add abortModal method to LayoutTestController and make it available from script.
2754
2755         * DumpRenderTree/mac/UIDelegate.mm: Add support for showModalDialog.
2756         (-[UIDelegate modalWindowWillClose:]): Observer for NSWindowWillCloseNotifications to call
2757         abortModal from when modal window closes.
2758         (-[UIDelegate webViewRunModal:]): Delegate method for showModalDialog to run the modal loop.
2759
2760 2010-06-21  Simon Fraser  <simon.fraser@apple.com>
2761
2762         Reviewed by Anders Carlsson.
2763         
2764         Rename DrawingAreaProxyUpdateChunk to ChunkedUpdateDrawingArea
2765         https://bugs.webkit.org/show_bug.cgi?id=40948
2766         
2767         Have the script look in WebKit2.
2768
2769         * Scripts/do-webcore-rename:
2770
2771 2010-06-21  Robert Hogan  <robert@webkit.org>
2772
2773         Reviewed by Kenneth Rohde Christiansen.
2774
2775         [Qt] Unskip plugins/get-url-that-the-resource-load-delegate-will-disallow.html
2776
2777         It's a Mac-specific test so just add the required LayoutTestController
2778         function as a no-op to avoid failing. Similar approach adopted by other
2779         ports.
2780
2781         https://bugs.webkit.org/show_bug.cgi?id=33344
2782
2783         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2784         (LayoutTestController::addDisallowedURL):
2785
2786 2010-06-21  Sam Weinig  <sam@webkit.org>
2787
2788         Reviewed by Anders Carlsson.
2789
2790         Patch for https://bugs.webkit.org/show_bug.cgi?id=40940
2791         Add message passing support to the WebKit2 API.
2792
2793         - Add some test messages.
2794
2795         * MiniBrowser/mac/AppDelegate.m:
2796         (_didRecieveMessageFromInjectedBundle):
2797         (-[BrowserAppDelegate init]):
2798         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2799         (_didClearWindow):
2800         (_didCreatePage):
2801         (_didRecieveMessage):
2802         (WKBundleInitialize):
2803
2804 2010-06-21  Drew Wilson  <atwilson@chromium.org>
2805
2806         Unreviewed.
2807
2808         Rolling back 61551 and 61555 due to test failures.
2809
2810         * DumpRenderTree/LayoutTestController.cpp:
2811         (LayoutTestController::staticFunctions):
2812         * DumpRenderTree/LayoutTestController.h:
2813         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2814         (LayoutTestController::setEditingBehavior):
2815         * DumpRenderTree/mac/UIDelegate.mm:
2816
2817 2010-06-21  Anders Carlsson  <andersca@apple.com>
2818
2819         Reviewed by Sam Weinig.
2820
2821         Make DumpRenderTree build with clang++
2822
2823         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
2824         (-[LocalPasteboard setPropertyList:forType:]):
2825         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2826         (-[DumpRenderTreeWindow keyDown:]):
2827         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2828         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
2829         (LayoutTestController::isCommandEnabled):
2830
2831 2010-06-21  Satish Sampath  <satish@chromium.org>
2832
2833         Reviewed by Steve Block.
2834
2835         Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
2836         https://bugs.webkit.org/show_bug.cgi?id=40878
2837
2838         * Scripts/build-webkit:
2839
2840 2010-06-21  Kent Tamura  <tkent@chromium.org>
2841
2842         Reviewed by Dimitri Glazkov.
2843
2844         [DRT/Chromium] Initialization for http/tests/loading/
2845         https://bugs.webkit.org/show_bug.cgi?id=40902
2846
2847         * DumpRenderTree/chromium/TestShell.cpp:
2848         (TestShell::runFileTest):
2849
2850 2010-06-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2851
2852         Unreviewed.
2853
2854         Adding myself to the committers list.
2855
2856         * Scripts/webkitpy/common/config/committers.py:
2857
2858 2010-06-20  Kent Tamura  <tkent@chromium.org>
2859
2860         Reviewed by Dimitri Glazkov.
2861
2862         [DRT/Chromium] Add --allow-external-pages option
2863         https://bugs.webkit.org/show_bug.cgi?id=40762
2864
2865         Add --allow-external-pages introduced by Chromium r45403.
2866         http://src.chromium.org/viewvc/chrome?view=rev&revision=45403
2867
2868         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2869         (main):
2870         * DumpRenderTree/chromium/TestShell.cpp:
2871         (TestShell::TestShell):
2872         * DumpRenderTree/chromium/TestShell.h:
2873         (TestShell::allowExternalPages):
2874         (TestShell::setAllowExternalPages):
2875         * DumpRenderTree/chromium/WebViewHost.cpp:
2876         (WebViewHost::willSendRequest):
2877
2878 2010-06-20  Joseph Pecoraro  <joepeck@webkit.org>
2879
2880         Reviewed by Adam Barth.
2881
2882         Sheriffbot: Should allow "r" in SVN_REVISION
2883         https://bugs.webkit.org/show_bug.cgi?id=40889
2884
2885         * Scripts/webkitpy/tool/bot/irc_command.py: remove a leading "r" from SVN_REVISION if it exists
2886         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: test an SVN_REVISION with a leading r.
2887
2888 2010-06-20  Joseph Pecoraro  <joepeck@webkit.org>
2889
2890         Reviewed by Dimitri Glazkov.
2891
2892         Python Tests Fail after r61508
2893         https://bugs.webkit.org/show_bug.cgi?id=40891
2894
2895         Test's regex list needed to be updated to match the new
2896         regex list in the source code. Added new bots to the
2897         example_buildbots list.
2898
2899         Regex list fixed in r61512. Updated bot list.
2900
2901         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2902
2903 2010-06-20  Dimitri Glazkov  <dglazkov@chromium.org>
2904
2905         Unreviewed, build fix.
2906
2907         Tweak test regexp list to match the change in http://trac.webkit.org/changeset/61508.
2908
2909         * Scripts/webkitpy/common/net/buildbot_unittest.py: Tweaked regexp.
2910
2911 2010-06-19  Justin Schuh  <jschuh@chromium.org>
2912
2913         Unreviewed.
2914
2915         Adding myself to the committers list.
2916
2917         * Scripts/webkitpy/common/config/committers.py:
2918
2919 2010-06-19  Sam Weinig  <sam@webkit.org>
2920
2921         Reviewed by Anders Carlsson.
2922
2923         Fix for https://bugs.webkit.org/show_bug.cgi?id=40882
2924         Add ability to have a WebProcess per WebContext.
2925
2926         Move to use new shared contexts API.
2927
2928         * MiniBrowser/mac/AppDelegate.h:
2929         * MiniBrowser/mac/AppDelegate.m:
2930         (-[BrowserAppDelegate init]):
2931         (-[BrowserAppDelegate getCurrentPageNamespace]):
2932         (-[BrowserAppDelegate validateMenuItem:]):
2933         (-[BrowserAppDelegate _setProcessModel:]):
2934         (-[BrowserAppDelegate setSharedProcessProcessModel:]):
2935         (-[BrowserAppDelegate setSharedThreadProcessModel:]):
2936         * MiniBrowser/win/BrowserView.cpp:
2937         (BrowserView::create):
2938
2939 2010-06-02  Robert Hogan  <robert@webkit.org>
2940
2941         Reviewed by Adam Barth.
2942
2943         [Qt] Support evaluateScriptInIsolatedWorld()
2944
2945         https://bugs.webkit.org/show_bug.cgi?id=40079
2946
2947         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2948         (LayoutTestController::evaluateScriptInIsolatedWorld):
2949         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2950
2951 2010-06-18  Dimitri Glazkov  <dglazkov@chromium.org>
2952
2953         Reviewed by Darin Adler.
2954
2955         Add three more non-core Chromium builders to start testing DumpRenderTree.
2956         https://bugs.webkit.org/show_bug.cgi?id=40335
2957
2958         * BuildSlaveSupport/build.webkit.org-config/config.json: Added 3 builders.
2959
2960 2010-06-18  Drew Wilson  <atwilson@chromium.org>
2961
2962         Reviewed by Darin Fisher.
2963
2964         [Chromium] Plumbing for top-level frame names
2965         https://bugs.webkit.org/show_bug.cgi?id=40430
2966
2967         * DumpRenderTree/chromium/WebViewHost.cpp:
2968         (WebViewHost::reset):
2969         Changed obsolete call to clearName() to use setName(WebString()) instead.
2970
2971 2010-06-18  Sam Weinig  <weinig@apple.com>
2972
2973         Rolling http://trac.webkit.org/changeset/61297 back in.
2974
2975         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2976         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Removed.
2977         * MiniBrowser/mac/WebBundle/WebBundleMain.m: Added.
2978         (_didClearWindow):
2979         (_didCreatePage):
2980         (WKBundleInitialize):
2981
2982 2010-06-18  Alexey Proskuryakov  <ap@apple.com>
2983
2984         Reviewed by Darin Adler.
2985
2986         https://bugs.webkit.org/show_bug.cgi?id=40803
2987         TestNetscapePlugin has an incorrect implementation of "property" property
2988
2989         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginGetProperty): Don't
2990         pass a static string back, it's going to be released by NPAPI implementation.
2991
2992 2010-06-18  Leandro Pereira  <leandro@profusion.mobi>
2993
2994         Unreviewed.
2995
2996         Adding myself to the committers list.
2997
2998         * Scripts/webkitpy/common/config/committers.py:
2999
3000 2010-06-17  Tony Chang  <tony@chromium.org>
3001
3002         Reviewed by Kent Tamura.
3003
3004         [chromium] cleanup redundant DEPS value and remove buildbot cleanup code
3005         https://bugs.webkit.org/show_bug.cgi?id=40615
3006
3007         * Scripts/update-webkit-chromium: remove directory removal of third_party in old checkouts
3008
3009 2010-06-17  Ada Chan  <adachan@apple.com>
3010
3011         Rolling out http://trac.webkit.org/changeset/61297 due to build errors.
3012
3013         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3014         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Copied from MiniBrowser/mac/WebBundle/WebBundleMain.c.
3015         * MiniBrowser/mac/WebBundle/WebBundleMain.m: Removed.
3016
3017 2010-06-17  Darin Adler  <darin@apple.com>
3018
3019         One more try at fix for Chromium build.
3020
3021         * DumpRenderTree/chromium/TestShell.cpp:
3022         (TestShell::TestShell): Use set again instead of =.
3023
3024 2010-06-17  Darin Adler  <darin@apple.com>
3025
3026         Fix Chromium build.
3027
3028         I didn't realize that neither Chromium nor Qt share the DumpRenderTree
3029         code with all the other platforms! Wow, that should be fixed at some point.
3030
3031         * DumpRenderTree/chromium/TestShell.cpp:
3032         (TestShell::TestShell): Changed back to using "new".
3033         * DumpRenderTree/chromium/TestShell.h: Changed back to OwnPtr.
3034
3035 2010-06-17  Simon Hausmann  <simon.hausmann@nokia.com>
3036
3037         Unreviewed Qt build fix.
3038
3039         LayoutTestController in the Qt DRT is not using refs :)
3040
3041         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3042         (WebCore::DumpRenderTree::DumpRenderTree):
3043
3044 2010-06-17  Darin Adler  <darin@apple.com>
3045
3046         Reviewed by Sam Weinig.
3047
3048         Use adoptRef and create functions in more code paths
3049         https://bugs.webkit.org/show_bug.cgi?id=40760
3050
3051         * DumpRenderTree/DumpRenderTree.h: Change gLayoutTestController to a RefPtr.
3052
3053         * DumpRenderTree/LayoutTestController.cpp:
3054         (LayoutTestController::create): Added.
3055         * DumpRenderTree/LayoutTestController.h: Declare the create function.
3056
3057         * DumpRenderTree/chromium/TestShell.cpp:
3058         (TestShell::TestShell): Use create instead of new.
3059         * DumpRenderTree/chromium/TestShell.h: Use RefPtr instead of OwnPtr.
3060
3061         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3062         (runTest): Use RefPtr and create instead of OwnPtr and new.
3063
3064         * DumpRenderTree/mac/DumpRenderTree.mm:
3065         (runTest): Use RefPtr and create instead of OwnPtr and new.
3066
3067         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3068         (WebCore::DumpRenderTree::DumpRenderTree): Use create and releaseRef
3069         instead of new.
3070
3071         * DumpRenderTree/win/DumpRenderTree.cpp:
3072         (runTest): Use RefPtr and create instead of OwnPtr and new.
3073
3074         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
3075         (runTest): Use RefPtr and create instead of OwnPtr and new.
3076         (MyApp::OnInit): Removed unneeded code to delete the layout
3077         test controller. This is done during each test.
3078
3079 2010-06-17  Kent Tamura  <tkent@chromium.org>
3080
3081         Reviewed by Shinichiro Hamaji.
3082
3083         [DRT/Chromium] Fix a bug of Windows pixel tests
3084         https://bugs.webkit.org/show_bug.cgi?id=40763
3085
3086         * DumpRenderTree/chromium/TestEventPrinter.cpp:
3087         (TestShellPrinter::handleImage):
3088
3089 2010-06-16  Kent Tamura  <tkent@chromium.org>
3090
3091         Reviewed by Shinichiro Hamaji.
3092
3093         [DRT/Chromium] Fix crash on Mac Release
3094         https://bugs.webkit.org/show_bug.cgi?id=40759
3095
3096         * DumpRenderTree/chromium/WebViewHost.cpp:
3097         (WebViewHost::paintRect): We should not use m_canvas directly because
3098           it is created lazily in canvas().
3099
3100 2010-06-16  Kevin Ollivier  <kevino@theolliviers.com>
3101
3102         [wx] Build fix after new method addition.
3103
3104         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3105         (LayoutTestController::pageProperty):
3106
3107 2010-06-16  Kent Tamura  <tkent@chromium.org>
3108
3109         Reviewed by Dimitri Glazkov.
3110
3111         [DRT/Chromium] Set current working directory for each of tests
3112         https://bugs.webkit.org/show_bug.cgi?id=40668
3113
3114         This change fixes tests with eventSender.beginDragWithFiles().
3115
3116         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3117         (runTest):
3118
3119 2010-06-16  Martin Robinson  <mrobinson@igalia.com>
3120
3121         Reviewed by Gustavo Noronha Silva.
3122
3123         [GTK] r60803 broke media/controls-drag-timebar.html
3124         https://bugs.webkit.org/show_bug.cgi?id=40269
3125
3126         Only queue events while the mouse button is down, if drag mode is enabled. Some
3127         tests may disable drag mode, to prevent the queuing of events in this situation.
3128
3129         * DumpRenderTree/gtk/EventSender.cpp:
3130         (sendOrQueueEvent): Only queue events here if dragMode is true.
3131
3132 2010-06-16  Martin Robinson  <mrobinson@igalia.com>
3133
3134         Reviewed by Gustavo Noronha Silva.
3135
3136         [GTK] Remove the abuse of GDK_CURRENT_TIME in the DRT
3137         https://bugs.webkit.org/show_bug.cgi?id=40600
3138
3139         * DumpRenderTree/gtk/EventSender.cpp:
3140         (prepareMouseButtonEvent): Remove logic adding an offset to GDK_CURRENT_TIME.
3141
3142 2010-06-16  Adam Barth  <abarth@webkit.org>
3143
3144         Reviewed by Dimitri Glazkov.
3145
3146         Add a hidden land-cowboy command to webkit-patch to help land quick
3147         build fixes.
3148
3149         * Scripts/webkitpy/tool/commands/download.py:
3150         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3151
3152 2010-06-16  Adam Roben  <aroben@apple.com>
3153
3154         Convert console messages to UTF-8 before printing them
3155
3156         Speculative fix for <http://webkit.org/b/40731> REGRESSION (r61234):
3157         http/tests/security/xssAuditor/embed-tag-null-char.html and
3158         http/tests/security/xssAuditor/object-embed-tag-null-char.html fail on
3159         Windows. (I can't test the fix because Apache is crashing on my
3160         computer.)
3161
3162         Reviewed by Alexey Proskuryakov.
3163
3164         * DumpRenderTree/win/DumpRenderTree.cpp:
3165         (toUTF8): Extracted the code into an overload that takes a wide string
3166         and a length, then added an overload that takes a wstring.
3167
3168         * DumpRenderTree/win/DumpRenderTreeWin.h: Declare the new toUTF8
3169         overload.
3170
3171         * DumpRenderTree/win/UIDelegate.cpp:
3172         (UIDelegate::webViewAddMessageToConsole): Use toUTF8 to convert to
3173         UTF-8 instead of letting printf convert to the current code page.
3174
3175 2010-06-16  Drew Wilson  <atwilson@chromium.org>
3176
3177         Reviewed by Kent Tamura.
3178
3179         [Chromium] Plumbing for top-level frame names
3180         https://bugs.webkit.org/show_bug.cgi?id=40430
3181
3182         * DumpRenderTree/chromium/WebViewHost.cpp:
3183         (WebViewHost::createView):
3184         Migrate to new createView() API.
3185         * DumpRenderTree/chromium/WebViewHost.h:
3186         Remove obsolete createView() methods, add new createView() API that takes a frameName parameter.
3187
3188 2010-06-16  Diego Gonzalez  <diegohcg@webkit.org>
3189
3190         Reviewed by Kenneth Rohde Christiansen.
3191
3192         [Qt] Scroll wheel event support to graphics based DRT
3193         https://bugs.webkit.org/show_bug.cgi?id=40577
3194
3195         * DumpRenderTree/qt/EventSenderQt.cpp:
3196         (EventSender::continuousMouseScrollBy):
3197         (EventSender::createGraphicsSceneWheelEvent):
3198         * DumpRenderTree/qt/EventSenderQt.h:
3199
3200 2010-06-16  Adam Roben  <aroben@apple.com>
3201
3202         Remove a stray newline from the Windows version of TestNetscapePlugin
3203
3204         Reviewed by Alexey Proskuryakov.
3205
3206         Fixes <http://webkit.org/b/40728>
3207         plugins/geturlnotify-during-document-teardown.html fails on Windows
3208
3209         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
3210         (NPP_Destroy): Removed extra newline that the Mac version doesn't
3211         have.
3212
3213 2010-06-16  Adam Roben  <aroben@apple.com>
3214
3215         Respect LayoutTestController::isPrinting on Windows
3216
3217         This gets some printing tests closer to passing (like
3218         printing/page-rule-in-media-query.html).
3219
3220         Fixes <http://webkit.org/b/40727>.
3221
3222         Reviewed by Dan Bernstein.
3223
3224         * DumpRenderTree/win/DumpRenderTree.cpp:
3225         (dump): Pass LayoutTestController::isPrinting to
3226         IWebFramePrivate::renderTreeAsExternalRepresentation.
3227
3228 2010-06-15  Adam Barth  <abarth@webkit.org>
3229
3230         Reviewed by Eric Seidel.
3231
3232         Enable HTML5 lexer
3233         https://bugs.webkit.org/show_bug.cgi?id=40650
3234
3235         * DumpRenderTree/mac/DumpRenderTree.mm:
3236         (initializeGlobalsFromCommandLineOptions):
3237
3238 2010-06-10  Yuzo Fujishima  <yuzo@google.com>
3239
3240         Reviewed by Shinichiro Hamaji.
3241
3242         Implement render style selection for pages to support CSS3 Paged Media.
3243         https://bugs.webkit.org/show_bug.cgi?id=35961
3244
3245         * DumpRenderTree/LayoutTestController.cpp:
3246         (parsePagePropertyParameters):
3247         (pagePropertyCallback):
3248         (LayoutTestController::staticFunctions):
3249         * DumpRenderTree/LayoutTestController.h:
3250         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3251         (LayoutTestController::pageProperty):
3252         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3253         (LayoutTestController::pageProperty):
3254         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3255         (LayoutTestController::pageProperty):
3256
3257 2010-06-15  Sam Weinig  <sam@webkit.org>
3258
3259         Reviewed by Anders Carlsson.
3260
3261         Fix for https://bugs.webkit.org/show_bug.cgi?id=40630
3262         WebKit2: Add mechanism to inject code into the WebProcess on startup
3263
3264         Add initial InjectedBundle support.
3265
3266         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3267         * MiniBrowser/WebBundle-Info.plist: Added.
3268         Add test InjectedBundle to the project.
3269
3270         * MiniBrowser/mac/AppDelegate.m:
3271         (-[BrowserAppDelegate init]):
3272         Get the path to the WebBundle from the the main bundle and pass it to the new
3273         WKContextCreateWithInjectedBundlePath function.
3274
3275         * MiniBrowser/mac/BrowserWindowController.m:
3276         (_didChangeProgress):
3277         Fix the build.  This has been broken for a while.
3278
3279         * MiniBrowser/mac/WebBundle: Added.
3280         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Added.
3281         (_didCreatePage):
3282         (WKBundleInitialize):
3283         Add really basic InjectedBundle.
3284
3285         * MiniBrowser/win/BrowserView.cpp:
3286         (BrowserView::create):
3287         Switch from WKContextCreateWithProcessModel to WKContextCreate and remove commented out code.
3288
3289 2010-06-15  Dumitru Daniliuc  <dumi@chromium.org>
3290
3291         Reviewed by Darin Adler.
3292
3293         Adding myself to the reviewers list.
3294         https://bugs.webkit.org/show_bug.cgi?id=40693
3295
3296         * Scripts/webkitpy/common/config/committers.py:
3297
3298 2010-06-15  Martin Robinson  <mrobinson@igalia.com>
3299
3300         Reviewed by Xan Lopez.
3301
3302         Switch to using GIO methods instead of realpath in GtkLauncher to determine
3303         the file URI. This should remove warnings about realpath being undefined
3304         when compiling with '-ansi'.
3305
3306         * GtkLauncher/main.c:
3307         (filenameToURL): Use GIO instead of realpath to determine file URI.
3308
3309 2010-06-15  Adam Roben  <aroben@apple.com>
3310
3311         Remove the redundant set-apple-windows-environment-variables script
3312
3313         Apparently update-webkit does this for you these days.
3314
3315         Rubber-stamped by Steve Falkenburg.
3316
3317         * Scripts/set-apple-windows-environment-variables: Removed.
3318
3319 2010-06-14  Adam Roben  <aroben@apple.com>
3320
3321         Add a script to set the WebKitOutputDir and WebKitLibrariesDir
3322         environment variables
3323
3324         Fixes <http://webkit.org/b/40595>.
3325
3326         Reviewed by Steve Falkenburg.
3327
3328         * Scripts/set-apple-windows-environment-variables: Added.
3329         (to_windows_path): Passes the passed-in path through cygpath to
3330         generate a Windows-style path.
3331         (main): Sets the WebKitOutputDir and WebKitLibrariesDir environment
3332         variables to their defaults, if they aren't already set.
3333
3334 2010-06-14  Adam Roben  <aroben@apple.com>
3335
3336         Speed up run-safari/debug-safari on Windows
3337
3338         Fixes <http://webkit.org/b/40586>.
3339
3340         Reviewed by Steve Falkenburg.
3341
3342         * Scripts/webkitdirs.pm:
3343         (runSafari): When debugging, set up the environment to run Safari
3344         using the built WebKit.dll, then use "devenv /debugexe Safari.exe" to
3345         actually launch the debugger. When not debugging, just run WebKit.exe
3346         and it will do the rest for us.
3347
3348 2010-06-15  Diego Gonzalez  <diegohcg@webkit.org>
3349
3350         Reviewed by Kenneth Rohde Christiansen.
3351
3352         [Qt] DRT EventSender support to graphics context events
3353         https://bugs.webkit.org/show_bug.cgi?id=40324
3354
3355         * DumpRenderTree/qt/EventSenderQt.cpp:
3356         (EventSender::contextClick):
3357
3358 2010-06-14  Tony Chang  <tony@chromium.org>
3359
3360         Reviewed by Darin Fisher.
3361
3362         [chromium] checkout chromium third_party directly
3363         https://bugs.webkit.org/show_bug.cgi?id=40556
3364
3365         * Scripts/update-webkit-chromium: some migration code for the bots
3366
3367 2010-06-14  Alexey Proskuryakov  <ap@apple.com>
3368
3369         Chromium build fix.
3370
3371         * DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown): Chromium uses differently
3372         named constants for Windows virtual key codes, replacing VK_DELETE with VKEY_DELETE.
3373
3374 2010-06-14  Alexey Proskuryakov  <ap@apple.com>
3375
3376         Reviewed by Darin Adler.
3377
3378         https://bugs.webkit.org/show_bug.cgi?id=40529
3379         eventSender.keyDown("delete") incorrectly sends a backspace on some platforms
3380
3381         * DumpRenderTree/mac/EventSendingController.mm:
3382         (-[EventSendingController keyDown:withModifiers:withLocation:]): We were sending a broken
3383         event for "delete" - it had virtual key code from forward delete, and text from backspace.
3384         Fixed "delete" to mean forward delete.
3385
3386         * DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown):
3387         * DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback):
3388         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
3389         Mac DRT confusion has propagated to other platforms, fixing those.
3390
3391 2010-06-14  Martin Robinson  <mrobinson@igalia.com>
3392
3393         Reviewed by Xan Lopez.
3394
3395         Small GtkLauncher build fix for some systems.
3396
3397         * GtkLauncher/main.c: Add <limit.h> include.
3398
3399 2010-06-14  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
3400
3401         Reviewed by Laszlo Gombos.
3402
3403         [Qt] navigator.geolocation support for Qt port
3404         https://bugs.webkit.org/show_bug.cgi?id=39724
3405
3406         Implementation for geolocation cases to DumpRenderTreeQt
3407
3408         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3409         (WebCore::WebPage::allowGeolocationRequest):
3410         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3411         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3412         (LayoutTestController::setGeolocationPermission):
3413         (LayoutTestController::setMockGeolocationError):
3414         (LayoutTestController::setMockGeolocationPosition):
3415         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3416         (LayoutTestController::isGeolocationPermissionSet):
3417         (LayoutTestController::geolocationPermission):
3418
3419 2010-06-13  Nathan Lawrence  <nlawrence@apple.com>
3420
3421         Reviewed by Darin Adler.
3422
3423         Outside of Xcode (make or WebKitTools/Scripts), there doesn't seem to
3424         be a way of overwriting the Xcode system path.  Making
3425         $WEBKITOUTPUTDIR take precedence over the system default would make
3426         this possible.
3427
3428         * Scripts/webkitdirs.pm:
3429
3430 2010-06-13  Chris Fleizach  <cfleizach@apple.com>
3431
3432         Reviewed by Darin Adler.
3433
3434         AX: link won't return linked element if URL contains #
3435         https://bugs.webkit.org/show_bug.cgi?id=40192
3436
3437         * DumpRenderTree/AccessibilityUIElement.cpp:
3438         (linkedUIElementAtIndexCallback):
3439         (AccessibilityUIElement::getJSClass):
3440         * DumpRenderTree/AccessibilityUIElement.h:
3441         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3442         (AccessibilityUIElement::linkedUIElementAtIndex):
3443         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3444         (AccessibilityUIElement::linkedUIElementAtIndex):
3445         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3446         (AccessibilityUIElement::linkedUIElementAtIndex):
3447
3448 2010-06-13  Adam Barth  <abarth@webkit.org>
3449
3450         Reviewed by Darin Adler.
3451
3452         webkit-patch should add a bug URL to ChangeLogs if they don't have one yet
3453         https://bugs.webkit.org/show_bug.cgi?id=39550
3454
3455         This can cause an extra request to bugs.webkit.org durig upload, but it
3456         shouldn't be too bad.  Also, this won't work if you remove the
3457         boilerplate created by prepare-ChangeLog.
3458
3459         * Scripts/webkitpy/common/checkout/changelog.py:
3460         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3461         * Scripts/webkitpy/common/net/bugzilla.py:
3462         * Scripts/webkitpy/tool/steps/abstractstep.py:
3463         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3464         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py: Added.
3465
3466 2010-06-08  Robert Hogan  <robert@webkit.org>
3467
3468         Reviewed by Eric Seidel.
3469
3470         [Qt] Add support for callShouldCloseOnWebView() to DRT
3471         https://bugs.webkit.org/show_bug.cgi?id=40330
3472
3473         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3474         (LayoutTestController::callShouldCloseOnWebView):
3475         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3476         (LayoutTestController::setCallCloseOnWebViews):
3477
3478 2010-06-12  Eric Seidel  <eric@webkit.org>
3479
3480         Reviewed by Daniel Bates.
3481
3482         do-webcore-rename should have a --verbose option
3483         https://bugs.webkit.org/show_bug.cgi?id=40497
3484
3485         * Scripts/do-webcore-rename:
3486          - Unified how we handle skipping files/directories
3487            this will allow us to "black list" certain files and
3488            directories when performing renames.
3489          - Made do-webcore-rename log what it's skipping when passed --verbose.
3490
3491 2010-06-12  Darin Adler  <darin@apple.com>
3492
3493         * Scripts/run-bindings-tests: Fixed a typo in a message.
3494
3495 2010-06-12  Kent Tamura  <tkent@chromium.org>
3496
3497         Reviewed by Dimitri Glazkov.
3498
3499         [Chromium] new-run-webkit-tests --use-drt should work with Chromium checkout
3500         https://bugs.webkit.org/show_bug.cgi?id=40402
3501
3502         _build_path() of each Chromium port check existence of build path
3503         of Chromium checkout first, then check existence of build path of
3504         WebKit-only checkout.
3505
3506         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3507         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3508         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3509
3510 2010-06-12  Robert Hogan  <robert@webkit.org>
3511
3512         Reviewed by Kenneth Rohde Christiansen.
3513
3514         [Qt] Back-forward list dumping is incorrect
3515
3516         https://bugs.webkit.org/show_bug.cgi?id=36392
3517
3518         Support dumping child history items in DRT.
3519
3520         Unskip:
3521
3522         fast/loader/frame-src-change-added-to-history.html
3523         fast/loader/frame-src-change-not-added-to-history.html
3524         fast/loader/frame-location-change-not-added-to-history.html
3525
3526         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3527         (WebCore::dumpHistoryItem):
3528
3529 2010-06-10  Ojan Vafai  <ojan@chromium.org>
3530
3531         Reviewed by Eric Seidel.
3532
3533         upload all patches that lack in-rietveld to rietveld
3534         https://bugs.webkit.org/show_bug.cgi?id=40444
3535
3536         If it's a patch, then we'll try to upload it as long as it
3537         doesn't have in-rietveld set. No longer set in-rietveld? since
3538         it's not needed.
3539
3540         * Scripts/webkitpy/common/net/bugzilla.py:
3541
3542 2010-06-10  Ojan Vafai  <ojan@chromium.org>
3543
3544         Reviewed by Darin Fisher.
3545
3546         Fix rietveld upload when message length > 100 characters
3547         https://bugs.webkit.org/show_bug.cgi?id=40457
3548
3549         * Scripts/webkitpy/common/net/rietveld.py:
3550
3551 2010-06-11  Yael Aharon  <yael.aharon@nokia.com>
3552
3553         Reviewed by Laszlo Gombos.
3554
3555         [Qt] There should be a way to enable popups in QtTestBrowser
3556         https://bugs.webkit.org/show_bug.cgi?id=40427
3557
3558         * QtTestBrowser/main.cpp:
3559         (LauncherWindow::toggleJavascriptCanOpenWindows):
3560         (LauncherWindow::createChrome):
3561
3562 2010-06-10  Adam Barth  <abarth@webkit.org>
3563
3564         Reviewed by Daniel Bates.
3565
3566         Make SheriffBot more chatty
3567         https://bugs.webkit.org/show_bug.cgi?id=40463
3568
3569         People seem to like to talk to SheriffBot, so let's make him chat back.
3570
3571         * Scripts/webkitpy/thirdparty/__init__.py:
3572         * Scripts/webkitpy/tool/bot/irc_command.py:
3573         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Added.
3574         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
3575         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3576
3577 2010-06-10  Brian Weinstein  <bweinstein@apple.com>
3578
3579         Reviewed by Darin Adler.
3580
3581         Fix the Windows buildbot when WebKitAuxiliaryLibs.zip cannot be found on our server.
3582         
3583         Robustify update-webkit-auxiliary-libs to be able to handle the case when WebKitAuxiliaryLibs.zip doesn't exist,
3584         and allow the script to fall back to an existing file, only failing if there is no fallback file. Also switch to checking
3585         WEXITSTATUS on $result instead of just comparing $result to 0.
3586
3587         * Scripts/update-webkit-auxiliary-libs:
3588
3589 2010-06-10  Ojan Vafai  <ojan@chromium.org>
3590
3591         Reviewed by Alexey Proskuryakov.
3592
3593         don't use Exception.message as it's deprecated in python 2.6+
3594         https://bugs.webkit.org/show_bug.cgi?id=40449
3595
3596         * Scripts/webkitpy/tool/commands/queues.py:
3597
3598 2010-06-10  Ojan Vafai  <ojan@chromium.org>
3599
3600         Reviewed by Adam Barth.
3601
3602         fix handle_script_error in rietveld upload queue and add testing for handle_script_error
3603         https://bugs.webkit.org/show_bug.cgi?id=40436
3604
3605         * Scripts/webkitpy/common/system/outputcapture.py:
3606         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3607         * Scripts/webkitpy/tool/commands/queues.py:
3608         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3609         * Scripts/webkitpy/tool/commands/queuestest.py:
3610         * Scripts/webkitpy/tool/mocktool.py:
3611
3612 2010-06-10  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
3613
3614         Reviewed by Simon Hausmann.
3615
3616         [Qt] *All* WebGL layout tests fail!
3617         https://bugs.webkit.org/show_bug.cgi?id=40296
3618
3619         Added test for WebKitWebGLEnabled to
3620         LayoutTestController::overridePreference().
3621
3622         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3623         (LayoutTestController::overridePreference):
3624
3625 2010-06-10  Diego Gonzalez  <diegohcg@webkit.org>
3626
3627         Reviewed by Kenneth Rohde Christiansen.
3628
3629         [Qt] DRT EventSender support to graphics mouse events activation
3630         https://bugs.webkit.org/show_bug.cgi?id=40017
3631
3632         * DumpRenderTree/qt/EventSenderQt.cpp:
3633         (EventSender::mouseDown):
3634         (EventSender::mouseUp):
3635         (EventSender::mouseMoveTo):
3636         (EventSender::keyDown):
3637         (EventSender::contextClick):
3638         (EventSender::sendTouchEvent):
3639         (EventSender::sendOrQueueEvent):
3640         (EventSender::eventFilter):
3641         (EventSender::createGraphicsSceneMouseEvent):
3642         (EventSender::sendEvent):
3643         * DumpRenderTree/qt/EventSenderQt.h:
3644         (EventSender::isGraphicsBased):
3645
3646 2010-06-09  Adam Barth  <abarth@webkit.org>
3647
3648         Reviewed by Ojan Vafai.
3649
3650         webkit-patch upload fails for security bugs because there's no rietveld flag
3651         https://bugs.webkit.org/show_bug.cgi?id=40309
3652
3653         There's probably a more elegant way of seeing whether the form control
3654         exists, but this seems to work.
3655
3656         * Scripts/webkitpy/common/net/bugzilla.py:
3657
3658 2010-06-09  Ojan Vafai  <ojan@chromium.org>
3659
3660         Reviewed by Adam Barth.
3661
3662         make rietveld upload faster and avoid posting to bug on errors
3663         https://bugs.webkit.org/show_bug.cgi?id=40389
3664
3665         Only grab the first item of the upload queue instead of trying
3666         to compute the whole list upfront (which is O(n) bugzilla lookups!).
3667
3668         Also, don't post comments to the bug when uploading fails.
3669
3670         * Scripts/webkitpy/common/net/bugzilla.py:
3671         * Scripts/webkitpy/tool/commands/queues.py:
3672         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3673         * Scripts/webkitpy/tool/commands/stepsequence.py:
3674         * Scripts/webkitpy/tool/mocktool.py:
3675
3676 2010-06-09  Ojan Vafai  <ojan@chromium.org>
3677
3678         Reviewed by Adam Barth.
3679
3680         Rietveld upload queue fails when setting in-rietveld flag
3681         https://bugs.webkit.org/show_bug.cgi?id=40371
3682
3683         Make the comment arguments to set_flag_on_attachment optional
3684         and add it to the MockBugzilla.
3685
3686         * Scripts/webkitpy/common/net/bugzilla.py:
3687         * Scripts/webkitpy/tool/bot/queueengine.py:
3688         * Scripts/webkitpy/tool/commands/download_unittest.py:
3689         * Scripts/webkitpy/tool/commands/queues.py:
3690         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3691         * Scripts/webkitpy/tool/mocktool.py:
3692
3693 2010-06-09  Kenneth Russell  <kbr@google.com>
3694
3695         Reviewed by Dimitri Glazkov.
3696
3697         Rename FloatArray to Float32Array
3698         https://bugs.webkit.org/show_bug.cgi?id=40323
3699
3700         Used do-webcore-rename to perform renaming. Manually undid
3701         incorrect changes to WebCore/bridge/jni/jsc/JNIBridgeJSC.cpp,
3702         WebCore/manual-tests/resources/ArrayParameterTestApplet.java and
3703         ArrayParameterTestApplet.class. Updated LayoutTests. Built and ran
3704         all layout tests on Safari; built Chromium and ran selected WebGL
3705         tests.
3706
3707         * Scripts/do-webcore-rename:
3708
3709 2010-06-08  Tony Chang  <tony@chromium.org>
3710
3711         Reviewed by David Levin.
3712
3713         [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out
3714         https://bugs.webkit.org/show_bug.cgi?id=40285
3715
3716         * Scripts/webkitdirs.pm:
3717         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3718
3719 2010-06-03  Roland Steiner  <rolandsteiner@chromium.org>
3720
3721         Reviewed by Tamura Kent.
3722
3723         Bug 40052 - [DRT/Chromium] Upstream test_shell_webthemeengine as WebThemeEngineDRT
3724         https://bugs.webkit.org/show_bug.cgi?id=40052
3725         
3726         Add WebThemeEngineDRT and WebThemeControlDRT ported from Chromium rev. 48907
3727
3728         * DumpRenderTree/DumpRenderTree.gypi:
3729         * DumpRenderTree/chromium/TestShellWin.cpp:
3730         (platformInit):
3731         * DumpRenderTree/chromium/WebThemeControlDRT.cpp: Added.
3732         (WebKit::):
3733         (WebKit::WebThemeControlDRT::WebThemeControlDRT):
3734         (WebKit::WebThemeControlDRT::~WebThemeControlDRT):
3735         (WebKit::WebThemeControlDRT::box):
3736         (WebKit::WebThemeControlDRT::line):
3737         (WebKit::WebThemeControlDRT::triangle):
3738         (WebKit::WebThemeControlDRT::roundRect):
3739         (WebKit::WebThemeControlDRT::oval):
3740         (WebKit::WebThemeControlDRT::circle):
3741         (WebKit::WebThemeControlDRT::nestedBoxes):
3742         (WebKit::WebThemeControlDRT::markState):
3743         (WebKit::WebThemeControlDRT::draw):
3744         (WebKit::WebThemeControlDRT::drawTextField):
3745         (WebKit::WebThemeControlDRT::drawProgressBar):
3746         * DumpRenderTree/chromium/WebThemeControlDRT.h: Added.
3747         (WebKit::WebThemeControlDRT::):
3748         * DumpRenderTree/chromium/WebThemeEngineDRT.cpp: Added.
3749         (WebKit::):
3750         (WebKit::WebThemeEngineDRT::paintButton):
3751         (WebKit::WebThemeEngineDRT::paintMenuList):
3752         (WebKit::WebThemeEngineDRT::paintScrollbarArrow):
3753         (WebKit::WebThemeEngineDRT::paintScrollbarThumb):
3754         (WebKit::WebThemeEngineDRT::paintScrollbarTrack):
3755         (WebKit::WebThemeEngineDRT::paintTextField):
3756         (WebKit::WebThemeEngineDRT::paintTrackbar):
3757         (WebKit::WebThemeEngineDRT::paintProgressBar):
3758         * DumpRenderTree/chromium/WebThemeEngineDRT.h: Added.
3759         (WebKit::WebThemeEngineDRT::WebThemeEngineDRT):
3760
3761 2010-06-08  Sheriff Bot  <webkit.review.bot@gmail.com>
3762
3763         Unreviewed, rolling out r60878.
3764         http://trac.webkit.org/changeset/60878
3765         https://bugs.webkit.org/show_bug.cgi?id=40349
3766
3767         broke linux build (Requested by tony^work on #webkit).
3768
3769         * Scripts/webkitdirs.pm:
3770         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3771
3772 2010-06-08  Tony Chang  <tony@chromium.org>
3773
3774         Reviewed by David Levin.
3775
3776         [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out
3777         https://bugs.webkit.org/show_bug.cgi?id=40285
3778
3779         * Scripts/webkitdirs.pm:
3780         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3781
3782 2010-06-08  Kenneth Russell  <kbr@google.com>
3783
3784         Unreviewed, build fix.
3785
3786         Fix build breakage from 38145
3787         https://bugs.webkit.org/show_bug.cgi?id=40346
3788
3789         The fix for bug 38145 broke the Chromium Win build because
3790         Microsoft's cmath doesn't define log2. Suggested fix by zmo is to
3791         change log2(x) to log(x) / log(2). Built and ran WebGL layout
3792         tests in Safari on Mac OS X. Changed download mirrors for
3793         python-irclib to working ones.
3794
3795         * Scripts/webkitpy/thirdparty/__init__.py:
3796
3797 2010-06-08  Fumitoshi Ukai  <ukai@chromium.org>
3798
3799         Reviewed by Eric Seidel.
3800
3801         old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
3802         https://bugs.webkit.org/show_bug.cgi?id=39058
3803
3804         * Scripts/old-run-webkit-tests:
3805          use sourceDir() to find ensure-valid-python in checkPythonVersion()
3806
3807 2010-06-08  Andras Becsi  <abecsi@webkit.org>
3808
3809         Unreviewed buildfix after r60479.
3810
3811         [GTK] Move the declaration of getRootCoords higher up to fix the build on GTK
3812         versions other than 2.17.3.
3813
3814         * DumpRenderTree/gtk/EventSender.cpp:
3815         (getRootCoords):
3816
3817 2010-06-07  Martin Robinson  <mrobinson@igalia.com>
3818
3819         Reviewed by Oliver Hunt.
3820
3821         [GTK] Mouse movement should not trigger a replay of saved events in the event sender
3822         https://bugs.webkit.org/show_bug.cgi?id=40267
3823
3824         When a mouse button is down, automatically queue mouse motion events and
3825         do not play them back until the mouse button is released. This matches the
3826         behavior of other ports' EventSenders.
3827
3828         * DumpRenderTree/gtk/EventSender.cpp:
3829         (mouseMoveToCallback): Don't automatically replaySavedEvents for mouse motion.
3830         (sendOrQueueEvent): Add a shouldReplaySavedEvents argument defaulting to true.
3831
3832 2010-06-07  Nikolas Zimmermann  <nzimmermann@rim.com>
3833
3834         Reviewed by Sam Weinig.
3835
3836         Add CPP bindings generator
3837         https://bugs.webkit.org/show_bug.cgi?id=38279
3838
3839         Integrate CPP bindings in run-bindings-tests.
3840
3841         * Scripts/run-bindings-tests:
3842
3843 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
3844
3845         Reviewed by Ojan Vafai.
3846
3847         Rename 'svn_merge_base' -> 'remote_merge_base'. This was left out of r60633.
3848         https://bugs.webkit.org/show_bug.cgi?id=40183
3849
3850         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3851
3852 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
3853
3854         Unreviewed.
3855
3856         Add my new email and IRC nick to committers.py.
3857
3858         * Scripts/webkitpy/common/config/committers.py:
3859
3860 2010-06-04  Kinuko Yasuda  <kinuko@chromium.org>
3861
3862         Unreviewed.
3863
3864         Revert changes in json_results_generator.py's _get_svn_revision.
3865
3866         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3867
3868 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
3869
3870         Reviewed by Xan Lopez.
3871
3872         [GTK] GtkLauncher should support relative file paths
3873         https://bugs.webkit.org/show_bug.cgi?id=39944
3874
3875         Allow GtkLauncher to handle relative file paths passed via command-line arguments.
3876
3877         * GtkLauncher/main.c:
3878         (filename_to_url): Added.
3879         (main): Try to resolve arguments as relative file URLs first.
3880
3881 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
3882
3883         Reviewed by Xan Lopez.
3884
3885         [GTK] EventSender should call gtk_main_do_event instead of invoking signal handlers directly
3886         https://bugs.webkit.org/show_bug.cgi?id=40182
3887
3888         Instead of invoking signal handlers directly via g_signal_emit_by_name, call
3889         gtk_main_do_event. This will allow us to call gtk_get_current_event() in WebKit
3890         without breaking DRT.
3891
3892         * DumpRenderTree/gtk/EventSender.cpp:
3893         (dispatchEvent): Use gtk_main_do_event instead of invoking signal handlers directly.
3894         (keyDownCallback): Use dispatchEvent here which now uses gtk_main_do_event.
3895
3896 2010-06-04  Anders Carlsson  <andersca@apple.com>
3897
3898         Reviewed by David Hyatt.
3899
3900         Make the editing/spelling/context-menu-suggestions.html test more robust
3901         https://bugs.webkit.org/show_bug.cgi?id=40178
3902
3903         Change the contextClick method to return an array of strings describing the context menu items.
3904
3905         * DumpRenderTree/mac/EventSendingController.mm:
3906         (+[EventSendingController isSelectorExcludedFromWebScript:]):
3907         (+[EventSendingController webScriptNameForSelector:]):
3908         (-[EventSendingController contextClick]):
3909
3910 2010-06-03  Kinuko Yasuda  <kinuko@chromium.org>
3911
3912         Reviewed by Shinichiro Hamaji.
3913
3914         Clean up chromium-specific code from json_results_generator.py.
3915         https://bugs.webkit.org/show_bug.cgi?id=39665
3916
3917         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3918         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3919         * Scripts/webkitpy/layout_tests/port/base.py:
3920         * Scripts/webkitpy/layout_tests/port/chromium.py:
3921
3922 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
3923
3924         Reviewed by Adam Barth.
3925
3926         Utilize new takeFirst() method where appropriate.
3927         https://bugs.webkit.org/show_bug.cgi?id=40089
3928
3929         * DumpRenderTree/chromium/EventSender.cpp:
3930         (EventSender::replaySavedEvents):
3931         * DumpRenderTree/chromium/LayoutTestController.cpp:
3932         (LayoutTestController::WorkQueue::processWork):
3933         (LayoutTestController::WorkQueue::reset):
3934
3935 2010-06-04  Yael Aharon  <yael.aharon@nokia.com>
3936
3937         Reviewed by Simon Hausmann.
3938
3939         [Qt] QtTestLauncher should allow notifications by default.
3940         https://bugs.webkit.org/show_bug.cgi?id=40078
3941
3942         * QtTestBrowser/main.cpp:
3943         (NotificationsPermissionController::NotificationsPermissionController):
3944         (NotificationsPermissionController::checkPermission):
3945         (NotificationsPermissionController::requestPermission):
3946         (LauncherWindow::LauncherWindow):
3947
3948 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
3949
3950         Reviewed by Adam Barth.
3951
3952         Detect whether the user's environment can open a browser.
3953         https://bugs.webkit.org/show_bug.cgi?id=40136
3954
3955         Some environments like cygwin silently fail webbrowser.open() causing
3956         webkit-patch upload not to display any diff. This detects environments
3957         where webbrowser.open() would fail by testing if webbrowser.get()
3958         raises an exception.
3959
3960         * Scripts/webkitpy/common/system/user.py:
3961         * Scripts/webkitpy/tool/mocktool.py:
3962         * Scripts/webkitpy/tool/steps/confirmdiff.py:
3963
3964 2010-06-03  Tony Gentilcore  <tonyg@chromium.org>
3965
3966         Reviewed by David Levin.
3967
3968         Add dependencies required to link with VS Express 2005.
3969         https://bugs.webkit.org/show_bug.cgi?id=40038
3970
3971         Visual Studio implicitly links against these libs.
3972         VC++ Express does not.
3973
3974         * WebKitAPITest/WebKitAPITestCommon.vsprops:
3975         * WinLauncher/WinLauncher.vcproj:
3976
3977 2010-06-03  Fumitoshi Ukai  <ukai@chromium.org>
3978
3979         Reviewed by David Levin.
3980
3981         bad codecs.open in webkitpy/layout_tests/ports/websocket_server.py
3982         https://bugs.webkit.org/show_bug.cgi?id=40105
3983
3984         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
3985         - kill pywebsocket process when url is not alive and the process is not
3986           terminated, not to leave pywebsocket server running.
3987         - fix codecs.open parameters.
3988
3989 2010-06-03  Fumitoshi Ukai  <ukai@chromium.org>
3990
3991         Reviewed by Alexey Proskuryakov.
3992
3993         old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
3994         https://bugs.webkit.org/show_bug.cgi?id=39058
3995
3996         * Scripts/ensure-valid-python:
3997           - Perl 5.8 doesn't have File::Temp->newdir().  Use File::Temp->tempdir() instead.
3998           - Add --check-only and --help option.
3999           - --check-only option only checks python version and don't try to install Python 2.5.
4000           - Set executable bit.
4001         * Scripts/old-run-webkit-tests:
4002           - Check if it can run the websocket tests by calling ensure-valid-python --check-only.
4003
4004 2010-05-14  Ojan Vafai  <ojan@chromium.org>
4005
4006         Reviewed by Adam Barth.
4007
4008         add a RietveldUploadQueue to upload in-rietveld? patches to rietveld
4009         https://bugs.webkit.org/show_bug.cgi?id=38918
4010
4011         Patches with in-rietveld? get uploaded to rietveld and get marked
4012         in-rietveld+. If the upload fails, they are marked in-rietveld-
4013         and an error is logged to the bug, like the commit-queue.
4014
4015         Also, get rid of --fancy-review and the ability to upload to rietveld
4016         using webkit-patch upload/post.
4017
4018         * Scripts/webkitpy/common/net/bugzilla.py:
4019         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
4020         * Scripts/webkitpy/tool/commands/download.py:
4021         * Scripts/webkitpy/tool/commands/download_unittest.py:
4022         * Scripts/webkitpy/tool/commands/queues.py:
4023         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4024         * Scripts/webkitpy/tool/commands/upload.py:
4025         * Scripts/webkitpy/tool/commands/upload_unittest.py:
4026         * Scripts/webkitpy/tool/mocktool.py:
4027         * Scripts/webkitpy/tool/steps/options.py:
4028         * Scripts/webkitpy/tool/steps/postcodereview.py:
4029
4030 2010-05-24  Ojan Vafai  <ojan@chromium.org>
4031
4032         Reviewed by Chris Jerdonek.
4033
4034         many webkit-patch commands fail in a non-svn tracking git checkout
4035         https://bugs.webkit.org/show_bug.cgi?id=38156
4036
4037         If the svn-tracking-branch (trunk) doesn't exist, fallback to the git remote-tracking-branch (master).
4038         If neither exists, then error out. This makes webkit-patch work
4039         for anyone that follows the intructions at http://trac.webkit.org/wiki/UsingGitWithWebKit
4040         to checkout webkit. The fallback to master is for people who don't
4041         do the steps on that page for tracking svn.
4042
4043         * Scripts/webkitpy/common/checkout/scm.py:
4044         * Scripts/webkitpy/common/checkout/scm_unittest.py:
4045
4046 2010-06-03  Mike Fenton  <mifenton@rim.com>
4047
4048         Unreviewed.
4049
4050         Reverse e-mail for myself in committers.py to correspond with bugzilla account.
4051
4052         * Scripts/webkitpy/common/config/committers.py:
4053
4054 2010-06-03  Pavel Feldman  <pfeldman@chromium.org>
4055
4056         Reviewed by Yury Semikhatsky.
4057
4058         Web Inspector: a number of fixes that make InspectorController
4059         happy with null redirects.
4060
4061         https://bugs.webkit.org/show_bug.cgi?id=40109
4062
4063         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4064         (runTest):
4065         * DumpRenderTree/mac/DumpRenderTree.mm:
4066         (runTest):
4067         * DumpRenderTree/win/DumpRenderTree.cpp:
4068         (runTest):
4069
4070 2010-06-02  Tasuku Suzuki  <tasuku.suzuki@nokia.com>
4071
4072         Reviewed by Shinichiro Hamaji.
4073
4074         [Qt] Fix compilation with QT_NO_PROPERTIES
4075         https://bugs.webkit.org/show_bug.cgi?id=38324
4076
4077         * QtTestBrowser/main.cpp:
4078         (LauncherWindow::init):
4079
4080 2010-06-02  Diego Gonzalez  <diegohcg@webkit.org>
4081
4082         Reviewed by Kenneth Rohde Christiansen.
4083
4084         [Qt] Make possible run DRT with QGraphicsWebView
4085         https://bugs.webkit.org/show_bug.cgi?id=40016
4086
4087         Make possible to use a environment variable for switching backend.
4088         Usage: QT_DRT_WEBVIEW_MODE=graphics WebKitTools/Scripts/run-webkit-tests --qt
4089
4090         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4091         (WebCore::WebViewGraphicsBased::WebViewGraphicsBased):
4092         (WebCore::DumpRenderTree::DumpRenderTree):
4093         * DumpRenderTree/qt/DumpRenderTreeQt.h:
4094         (WebCore::DumpRenderTree::setGraphicsBased):
4095         (WebCore::DumpRenderTree::isGraphicsBased):
4096         (WebCore::WebViewGraphicsBased::graphicsView):
4097         (WebCore::WebViewGraphicsBased::setPage):
4098         * Scripts/old-run-webkit-tests:
4099
4100 2010-06-02  Csaba Osztrogonác  <ossy@webkit.org>
4101
4102         Reviewed by Eric Seidel.
4103
4104         Slave lost shouldn't be recognized as build failed.
4105         https://bugs.webkit.org/show_bug.cgi?id=39282
4106
4107         * Scripts/webkitpy/common/net/buildbot.py: Treat slave lost as green.
4108         * Scripts/webkitpy/common/net/buildbot_unittest.py: Add unit test for slave lost.
4109
4110 2010-06-01  Yael Aharon  <yael.aharon@nokia.com>
4111
4112         Reviewed by Kenneth Rohde Christiansen.
4113
4114         [Qt] Fix the lifecycle of notification objects
4115         https://bugs.webkit.org/show_bug.cgi?id=40003
4116
4117         Remove the dependency of notifications on QWebPage.
4118
4119         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4120         (WebCore::requestPermissionCallback):
4121         (WebCore::WebPage::WebPage):
4122         (WebCore::DumpRenderTree::requestPermission):
4123         * DumpRenderTree/qt/DumpRenderTreeQt.h:
4124
4125 2010-06-02  Sheriff Bot  <webkit.review.bot@gmail.com>
4126
4127         Unreviewed, rolling out r60559.
4128         http://trac.webkit.org/changeset/60559
4129         https://bugs.webkit.org/show_bug.cgi?id=40055
4130
4131         It broke python unit test (Requested by Ossy on #webkit).
4132
4133         * Scripts/webkitpy/common/net/buildbot.py:
4134
4135 2010-06-02  Csaba Osztrogonác  <ossy@webkit.org>
4136
4137         Reviewed by Eric Seidel.
4138
4139         Slave lost shouldn't be recognized as build failed.
4140         https://bugs.webkit.org/show_bug.cgi?id=39282
4141
4142         * Scripts/webkitpy/common/net/buildbot.py:
4143
4144 2010-06-02  Tony Gentilcore  <tonyg@chromium.org>
4145
4146         Reviewed by Eric Seidel.
4147
4148         Fix crash caused when assigned_to is disabled
4149         https://bugs.webkit.org/show_bug.cgi?id=40039
4150
4151         * Scripts/webkitpy/common/net/bugzilla.py:
4152
4153 2010-06-02  Sterling Swigart  <sswigart@google.com>
4154
4155         Reviewed by David Levin.
4156
4157         Image Resizer Patch 0: Added compilation argument to conditionally compile pending patches.
4158         https://bugs.webkit.org/show_bug.cgi?id=39906
4159
4160         * Scripts/build-webkit:
4161
4162 2010-06-01  Raine Makelainen  <raine.makelainen@nokia.com>
4163
4164         Reviewed by Simon Hausmann.
4165
4166         Fixed tests to use QWebSettings::JavascriptCanAccessClipboard instead of QWebSettings::JavaScriptCanAccessClipboard.
4167
4168         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4169         (WebCore::WebPage::WebPage):
4170         (WebCore::WebPage::resetSettings):
4171         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4172         (LayoutTestController::setJavaScriptCanAccessClipboard):
4173
4174 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
4175
4176         Reviewed by Mark Rowe.
4177
4178         A nicer Tiger build fix.
4179
4180         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4181         * DumpRenderTree/mac/Configurations/Base.xcconfig:
4182         Enable GCC_OBJC_CALL_CXX_CDTORS via .xcconfig.
4183
4184 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
4185
4186         A real Tiger build fix.
4187
4188         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Enable GCC_OBJC_CALL_CXX_CDTORS
4189         for all configurations, not just debug.
4190
4191 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
4192
4193         Tiger build fix.
4194
4195         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Enable GCC_OBJC_CALL_CXX_CDTORS.
4196
4197 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
4198
4199         Reviewed by Xan Lopez.
4200
4201         [GTK] Get more mouse tests passing
4202         https://bugs.webkit.org/show_bug.cgi?id=39040
4203
4204         Reproduce the logic from the Windows EventSender for mapping
4205         button numbers to GDK button numbers. Move this logic to the
4206         prepareMouseButtonEvent helper.
4207
4208         * DumpRenderTree/gtk/EventSender.cpp:
4209         (prepareMouseButtonEvent): Reproduce Windows logic.
4210         (contextClickCallback): Move mapping logic to prepareMouseButtonEvent.
4211         (mouseDownCallback): Ditto.
4212         (mouseUpCallback): Ditto.
4213
4214 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
4215
4216         Reviewed by Sam Weinig.
4217
4218         https://bugs.webkit.org/show_bug.cgi?id=39434
4219         REGRESSION (r59811): Geolocation callbacks cannot be created
4220
4221         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added MockGeolocationProvider.
4222
4223         * DumpRenderTree/mac/DumpRenderTree.mm:
4224         (createWebViewAndOffscreenWindow): Tell the view to use MockGeolocationProvider. 
4225         (resetWebViewToConsistentStateBeforeTesting): Make sure that mock notifications don't leak
4226         into subsequent tests.
4227
4228         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4229         (LayoutTestController::setMockGeolocationPosition): Changed to use MockGeolocationProvider.
4230         (LayoutTestController::setMockGeolocationError): Ditto.
4231
4232         * DumpRenderTree/mac/MockGeolocationProvider.h: Added.
4233         * DumpRenderTree/mac/MockGeolocationProvider.mm: Added.
4234         (+[MockGeolocationProvider shared]):
4235         (-[MockGeolocationProvider dealloc]):
4236         (-[MockGeolocationProvider setPosition:]):
4237         (-[MockGeolocationProvider setError:]):
4238         (-[MockGeolocationProvider registerWebView:]):
4239         (-[MockGeolocationProvider unregisterWebView:]):
4240         (-[MockGeolocationProvider lastPosition]):
4241         (-[MockGeolocationProvider stopTimer]):
4242         (-[MockGeolocationProvider timerFired]):
4243
4244         * DumpRenderTree/mac/UIDelegate.mm:
4245         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
4246         This delegate method must send a response. I'm not sure what the two-stage check is supposed
4247         to achieve, it seems unnecessary.
4248
4249 2010-05-12  Martin Robinson  <mrobinson@igalia.com>
4250
4251         Reviewed by Xan Lopez.
4252
4253         [GTK] Double clicks cause three button press events
4254         https://bugs.webkit.org/show_bug.cgi?id=38853
4255
4256         WebKit now filters the extra GDK_BUTTON_PRESS before GDK_2BUTTON_PRESS
4257         and GDK_3BUTTON_PRESS via gdk_event_peek(). Since EventSender bypasses
4258         the GDK event queue entirely, we simply do not send the extra event.
4259
4260         * DumpRenderTree/gtk/EventSender.cpp:
4261         (mouseDownCallback): Do not send extra event. Send GDK_3BUTTON_PRESS appropriately.
4262         (dispatchEvent): Properly handle GDK_3BUTTON_PRESS.
4263
4264 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
4265
4266         Not reviewed. Build fix.
4267
4268         Fix GTK+ build caused by a bad merge.
4269
4270         * DumpRenderTree/gtk/EventSender.cpp: 
4271         (prepareMouseButtonEvent): Use the GdkEvent union as a pointer here.
4272
4273 2010-06-01  Martin Robinson  <mrobinson@webkit.org>
4274
4275         Reviewed by Xan Lopez.
4276
4277         [GTK] Double clicks cause three button press events
4278         https://bugs.webkit.org/show_bug.cgi?id=38853
4279
4280         Small EventSender