2010-08-16 Paul Sawaya <psawaya@apple.com>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-08-16  Paul Sawaya  <psawaya@apple.com>
2
3         Reviewed by Chris Marrin.
4
5         Added shader validation via ANGLE
6         https://bugs.webkit.org/show_bug.cgi?id=42405
7
8         Added ANGLE to webkit build
9
10         * Scripts/build-webkit:
11
12 2010-08-16  Kevin Ollivier  <kevino@theolliviers.com>
13
14         [wx] Build fix, do not build WebCore as a convenience library as this leads to
15         errors in the Win build w/export symbols and causes problems with DOM bindings
16         debugging in gdb.
17
18         * DumpRenderTree/wscript:
19         * Scripts/build-webkit:
20         * wx/browser/wscript:
21         * wx/build/settings.py:
22         * wx/build/waf_extensions.py:
23
24 2010-08-16  Dan Bernstein  <mitz@apple.com>
25
26         Build fix.
27
28         * WebKitTestRunner/TestController.cpp:
29         (WTR::createOtherPage): Initialize the contentsSizeChanged member.
30         (WTR::TestController::initialize): Ditto.
31
32 2010-08-16  Balazs Kelemen  <kb@inf.u-szeged.hu>
33
34         Reviewed by Kenneth Rohde Christiansen.
35
36         Handle content size change in WebKit2
37         Re-landing after fix.
38
39         https://bugs.webkit.org/show_bug.cgi?id=43198
40
41         * MiniBrowser/mac/BrowserWindowController.m:
42         (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
43         * MiniBrowser/win/BrowserView.cpp:
44         (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.
45
46 2010-08-16  Sheriff Bot  <webkit.review.bot@gmail.com>
47
48         Unreviewed, rolling out r65419.
49         http://trac.webkit.org/changeset/65419
50         https://bugs.webkit.org/show_bug.cgi?id=44053
51
52         Broke the Windows build (Requested by bbandix on #webkit).
53
54         * MiniBrowser/mac/BrowserWindowController.m:
55         (-[BrowserWindowController awakeFromNib]):
56         * MiniBrowser/win/BrowserView.cpp:
57         (BrowserView::create):
58
59 2010-08-16  Balazs Kelemen  <kb@inf.u-szeged.hu>
60
61         Reviewed by Kenneth Rohde Christiansen.
62
63         Handle content size change in WebKit2
64
65         https://bugs.webkit.org/show_bug.cgi?id=43198
66
67         * MiniBrowser/mac/BrowserWindowController.m:
68         (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
69         * MiniBrowser/win/BrowserView.cpp:
70         (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.
71
72 2010-08-16  Ariya Hidayat  <ariya@sencha.com>
73
74         Add my new email address to committers.py.
75
76         * Scripts/webkitpy/common/config/committers.py:
77
78 2010-08-16  Zoltan Horvath  <zoltan@webkit.org>
79
80         Add my old e-mail addresses to committers.py.
81
82         * Scripts/webkitpy/common/config/committers.py:
83
84 2010-08-15  Jon Honeycutt  <jhoneycutt@apple.com>
85
86         WebEditorClient::didBeginEditing is never called in WebKit2
87         https://bugs.webkit.org/show_bug.cgi?id=42939
88
89         Reviewed by Sam Weinig.
90
91         * WebKitTestRunner/PlatformWebView.h:
92         Declare focus().
93
94         * WebKitTestRunner/TestController.cpp:
95         (WTR::TestController::resetStateToConsistentValues):
96         Focus the PlatformWebView.
97
98         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
99         (WTR::PlatformWebView::focus):
100         Stubbed.
101
102         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
103         (WTR::PlatformWebView::focus):
104         Focus the view.
105
106 2010-08-15  Jon Honeycutt  <jhoneycutt@apple.com>
107
108         run-webkit-tests should not strip editing callbacks when using
109         WebKitTestRunner on Windows
110         https://bugs.webkit.org/show_bug.cgi?id=44000
111
112         Reviewed by Mark Rowe.
113
114         * Scripts/old-run-webkit-tests:
115         Leave $stripEditingCallbacks undefined until we look for command-line
116         arguments. If using WebKit2, set it to 0 if not explicity set on the
117         command line. Later, set it to isCygwin() to match old behavior if it is
118         not yet defined.
119
120 2010-08-15  Kevin Ollivier  <kevino@theolliviers.com>
121
122         [wx] Build fix, remove define always set to the correct value by wtf/Platform.h.
123
124         * wx/build/settings.py:
125
126 2010-08-14  Martin Robinson  <mrobinson@igalia.com>
127
128         Reviewed by Kenneth Rohde Christiansen.
129
130         [GTK] autogen.sh not executed if build-webkit options change
131         https://bugs.webkit.org/show_bug.cgi?id=42266
132
133         Rerun autogen.sh in situations where the arguments to build-webkit have
134         changed since the previous build. This will fix some issues on the bots
135         where the build does not notice changes to default build-webkit arguments.
136
137         * Scripts/webkitdirs.pm: Add special logic for detecting changes to build-webkit arguments.
138
139 2010-08-14  Eric Seidel  <eric@webkit.org>
140
141         Unreviewed.  Another fix to support python 2.3.
142
143         Add support for MathML entities
144         https://bugs.webkit.org/show_bug.cgi?id=43949
145
146         * Scripts/webkitpy/thirdparty/simplejson/decoder.py:
147          - It looks like our simplejson is version 1.7.3 which
148            should be python 2.3 compatible.  But someone modified
149            our copy slightly from the original source.
150            I've removed the relative import in hopes this fixes
151            the problem.
152
153 2010-08-13  Eric Seidel  <eric@webkit.org>
154
155         Unreviewed.  Build fix only.
156
157         Add support for MathML entities
158         https://bugs.webkit.org/show_bug.cgi?id=43949
159
160         * Scripts/create-html-entity-table:
161          - Hack sys.path to avoid executing 2.5 dependent python
162            on systems (like chromium-win and Tiger) which do not have 2.5 python.
163
164 2010-08-13  Adam Barth  <abarth@webkit.org>
165
166         Reviewed by Eric Seidel.
167
168         Rename some concepts in HTML entity search to be more self-documenting
169         https://bugs.webkit.org/show_bug.cgi?id=44004
170
171         Reflect name change in generator script.
172
173         * Scripts/create-html-entity-table:
174
175 2010-08-12  Adam Barth  <abarth@webkit.org>
176
177         Reviewed by Eric Seidel.
178
179         Add support for MathML entities
180         https://bugs.webkit.org/show_bug.cgi?id=43949
181
182         A script for generating the C++ state data structure describing all the
183         entities from a JSON description.
184
185         * Scripts/create-html-entity-table: Added.
186
187 2010-08-13  Dirk Pranke  <dpranke@chromium.org>
188
189         Reviewed by Eric Seidel.
190
191         Rewrite new-run-webkit-test's wait_for_threads_to_finish loop to
192         check for exceptions on all threads, not just the first thread.
193         
194         This change also changes the logging behavior for wedged threads
195         to only dump the stacks of threads that are actually wedged.
196
197         Refactor the thread classes in the dump_render_tree_thread module
198         to make the contract between TestRunner and TestShellThread clearer.
199
200         Added a bunch of unit tests.
201         https://bugs.webkit.org/show_bug.cgi?id=38561
202
203         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
204         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
205         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
206
207 2010-08-13  Kenichi Ishibashi  <bashi@google.com>
208
209         Reviewed by Shinichiro Hamaji.
210
211         Add test_expectations.txt syntax checker to check-webkit-style.
212         https://bugs.webkit.org/show_bug.cgi?id=43899
213
214         Just utilizing layout_tests/layout_package/test_expectations.py for checking
215         the syntax of test_expectations.txt.
216         This change also moves tab checking class from style/checkers/text.py to
217         style/checkers/common.py for sharing code.
218
219         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
220         * Scripts/webkitpy/style/checker.py:
221         * Scripts/webkitpy/style/checkers/common.py:
222         * Scripts/webkitpy/style/checkers/common_unittest.py:
223         * Scripts/webkitpy/style/checkers/test_expectations.py: Added.
224         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Added.
225         * Scripts/webkitpy/style/checkers/text.py:
226         * Scripts/webkitpy/style_references.py:
227
228 2010-08-12  Jon Honeycutt  <jhoneycutt@apple.com>
229
230         WebKitTestRunner does not correctly resize WebView for W3C SVG tests
231         https://bugs.webkit.org/show_bug.cgi?id=43945
232
233         Reviewed by Sam Weinig.
234
235         * WebKitTestRunner/TestInvocation.cpp:
236         (WTR::sizeWebViewForCurrentTest):
237         Allow for a Windows-style path.
238
239         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
240         (WTR::PlatformWebView::resizeTo):
241         Call SetWindowPos to resize the view window.
242
243 2010-08-12  David Levin  <levin@chromium.org>
244
245         Build break fix.
246
247         * WebKitTestRunner/TestController.cpp:
248         (WTR::TestController::resetStateToConsistentValues): Removed usage
249         of a variable that doesn't exist in the class.
250
251 2010-08-12  Jon Honeycutt  <jhoneycutt@apple.com>
252
253         WebKitTestRunner needs to run tests without using native controls
254         https://bugs.webkit.org/show_bug.cgi?id=43772
255
256         Reviewed by Sam Weinig.
257
258         * WebKitTestRunner/TestController.cpp:
259         (WTR::TestController::initialize):
260         Call platformInitializeContext().
261
262         * WebKitTestRunner/TestController.h:
263         Declare platformInitializeContext().
264
265         * WebKitTestRunner/mac/TestControllerMac.mm:
266         (WTR::TestController::platformInitializeContext):
267         Stubbed.
268
269         * WebKitTestRunner/win/TestControllerWin.cpp:
270         (WTR::TestController::platformInitializeContext):
271         Call WKContextSetShouldPaintNativeControls() to disable native control
272         drawing.
273
274 2010-08-12  Sam Weinig  <sam@webkit.org>
275
276         Reviewed by Alexey Proskuryakov.
277
278         WebKitTestRunner should be more aggressive about ensuring consistent state between tests
279         https://bugs.webkit.org/show_bug.cgi?id=43653
280
281         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
282         (WTR::InjectedBundle::InjectedBundle):
283         (WTR::InjectedBundle::didReceiveMessage):
284         (WTR::InjectedBundle::beginTesting):
285         (WTR::InjectedBundle::done):
286         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
287         (WTR::InjectedBundle::isTestRunning):
288         (WTR::InjectedBundle::):
289         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
290         (WTR::InjectedBundlePage::stopLoading):
291         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
292         (WTR::InjectedBundlePage::dump):
293         (WTR::InjectedBundlePage::didFinishLoadForFrame):
294         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
295         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
296         (WTR::InjectedBundlePage::didClearWindowForFrame):
297         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
298         (WTR::InjectedBundlePage::willAddMessageToConsole):
299         (WTR::InjectedBundlePage::willSetStatusbarText):
300         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
301         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
302         (WTR::InjectedBundlePage::shouldBeginEditing):
303         (WTR::InjectedBundlePage::shouldEndEditing):
304         (WTR::InjectedBundlePage::shouldInsertNode):
305         (WTR::InjectedBundlePage::shouldInsertText):
306         (WTR::InjectedBundlePage::shouldDeleteRange):
307         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
308         (WTR::InjectedBundlePage::shouldApplyStyle):
309         (WTR::InjectedBundlePage::didBeginEditing):
310         (WTR::InjectedBundlePage::didEndEditing):
311         (WTR::InjectedBundlePage::didChange):
312         (WTR::InjectedBundlePage::didChangeSelection):
313         Don't do any work if we are not currently running a test.
314
315         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
316         * WebKitTestRunner/StringFunctions.h:
317         (WTR::toCF):
318         Add conversion function for WKURLRef -> CFURLRef
319
320         * WebKitTestRunner/TestController.cpp:
321         (WTR::TestController::TestController):
322         (WTR::TestController::initialize):
323         (WTR::TestController::resetStateToConsistentValues):
324         (WTR::TestController::runTest):
325         (WTR::TestController::didFinishLoadForFrame):
326         * WebKitTestRunner/TestController.h:
327         (WTR::TestController::):
328         * WebKitTestRunner/TestInvocation.cpp:
329         (WTR::TestInvocation::invoke):
330         * WebKitTestRunner/TestInvocation.h:
331         Move resetting code to TestController.
332
333         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
334         * WebKitTestRunner/mac/TestControllerMac.mm:
335         (WTR::TestController::runUntil):
336         * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
337         * WebKitTestRunner/win/TestControllerWin.cpp:
338         (WTR::TestController::runUntil):
339         * WebKitTestRunner/win/TestInvocationWin.cpp: Removed.
340         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
341         Move runUntil to TestController.
342
343 2010-08-12  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
344
345         Unreviewed.
346
347         Adding myself to the committers list.
348
349         * Scripts/webkitpy/common/config/committers.py:
350
351 2010-08-12  Hayato Ito  <hayato@chromium.org>
352
353         Reviewed by Tony Chang.
354
355         Merge pretty printers for gdb.
356         https://bugs.webkit.org/show_bug.cgi?id=43850
357
358         We need to update webcore.py because basic string classes have moved to WTF from WebCore.
359         It is good timing to merge webcore.py and wtf.py and name it 'webkit.py'.
360         webcore.py is left for backward compatibility.
361
362         * gdb/webcore.py:
363         * gdb/webkit.py: Added.
364         * gdb/wtf.py: Removed.
365
366 2010-08-11  Tony Chang  <tony@chromium.org>
367
368         Reviewed by David Levin.
369
370         [chromium] add google-chrome layout test result directories
371         https://bugs.webkit.org/show_bug.cgi?id=43889
372
373         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
374         * Scripts/webkitpy/layout_tests/port/factory.py:
375         * Scripts/webkitpy/layout_tests/port/google_chrome.py: Added.
376         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
377
378 2010-08-11  Kent Tamura  <tkent@chromium.org>
379
380         Reviewed by Dimitri Glazkov.
381
382         [DRT/Chromium] Disable accelerated compositing
383         https://bugs.webkit.org/show_bug.cgi?id=43894
384
385         Disable accelerated compositing because DRT is not ready for
386         it. This change fixes hundreds of test crashes on Windows and
387         Linux.
388
389         * DumpRenderTree/chromium/TestShell.cpp:
390         (TestShell::resetWebSettings):
391
392 2010-08-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
393
394         Unreviewed. Adding my Collabora personality to the list.
395
396         * Scripts/webkitpy/common/config/committers.py:
397
398 2010-08-11  Martin Robinson  <mrobinson@igalia.com>
399
400         Adding myself as a reviewer.
401
402         * Scripts/webkitpy/common/config/committers.py:
403
404 2010-08-11  Daniel Bates  <dbates@rim.com>
405
406         Reviewed by Darin Adler.
407
408         Perl warnings when running commit-log-editor
409         https://bugs.webkit.org/show_bug.cgi?id=43856
410
411         Fixes Perl warnings introduced by the patch for Bug #40548.
412
413         Perl doesn't have symbolic names for True/False. Instead, we
414         should use boolean values. Moreover, the variable installedEditorApplication
415         is not be used and should be renamed builtEditorApplication so that it
416         uses the existing machinery to set the commit log editor application.
417
418         * Scripts/commit-log-editor:
419
420 2010-08-11  Adam Barth  <abarth@webkit.org>
421
422         Reviewed by Eric Seidel.
423
424         Trying waiting for httpd lock in the EWS
425         https://bugs.webkit.org/show_bug.cgi?id=43833
426
427         If this works, we can probably run the tests on the mac-ews, which
428         would be very exciting.  :)
429
430         * Scripts/webkitpy/tool/steps/runtests.py:
431
432 2010-08-11  Marcus Bulach  <bulach@chromium.org>
433
434         Reviewed by Eric Seidel.
435
436         Check in a script to list redundant test outputs.
437         https://bugs.webkit.org/show_bug.cgi?id=37630
438
439         If e.g. platform/mac-leopard is missing an expected test output, we
440         fall back on platform/mac.  This means it's possible to grow redundant
441         test outputs, where we have the same expected data in both a platform
442         directory and another platform it falls back on.
443         (original patch by Evan Marting <evan@chromium.org> https://bugs.webkit.org/attachment.cgi?id=53398)
444
445         * Scripts/deduplicate-tests: Added.
446         * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Added.
447         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: Added.
448
449 2010-08-11  Antonio Gomes  <tonikitoo@webkit.org>
450
451         Reviewed by Ariya Hidayat.
452
453         [Qt] QtTestBrowser: after switching between QWebView and QGraphicsWebView, rotation actions get broken
454         https://bugs.webkit.org/show_bug.cgi?id=43853
455
456         LauncherWindow::createChrome is connecting menu itens to WebViewGraphicsBased's slots directly.
457         It behaviors badly when user launches the QtTestBrowser in QWebView mode, since then switching to
458         QGraphicsWebView mode, createChrome is not called again, and menu items end up not getting connected
459         to slots at all.
460
461         * QtTestBrowser/launcherwindow.cpp:
462         (LauncherWindow::createChrome):
463         (LauncherWindow::animatedFlip):
464         (LauncherWindow::animatedYFlip):
465         * QtTestBrowser/launcherwindow.h:
466
467 2010-08-11  Antonio Gomes  <tonikitoo@webkit.org>
468
469         Reviewed by Simon Hausmann.
470
471         [Qt] QtTestBrowser: switching between QWebView and QGraphicsWebView modes is broken
472         https://bugs.webkit.org/show_bug.cgi?id=43851
473
474         All window options data (including the bool holding if the view is either QWebView or
475         QGraphicsWebView based) is stored in m_windowOptions, a class member of LauncherWindow.
476         When toggle the view from QWebView to QGraphicsWebView based (and vice-versa), we were
477         not updating LauncherWindow::WindowOptions::m_useGraphicsView bit, and then things were
478         getting broken.
479
480         Patch addresses this issue.
481
482         * QtTestBrowser/launcherwindow.cpp:
483         (LauncherWindow::createChrome):
484         (LauncherWindow::toggleWebView):
485         (LauncherWindow::toggleAcceleratedCompositing):
486
487 2010-08-10  Antonio Gomes  <tonikitoo@webkit.org>
488
489         Reviewed by Ariya Hidayat.
490
491         [Qt] QtTestBrowser: lazy instantiate "YRotation" state machine and related objects
492         https://bugs.webkit.org/show_bug.cgi?id=43831
493
494         Only instantiate QStateMachine and friends associated to the YRotation action on demand.
495
496         * QtTestBrowser/webview.cpp:
497         (WebViewGraphicsBased::WebViewGraphicsBased):
498         (WebViewGraphicsBased::animatedYFlip):
499
500 2010-08-11  Darin Adler  <darin@apple.com>
501
502         Reviewed by John Sullivan.
503
504         Improved editor options for prepare-ChangeLog and commit-log-editor
505         https://bugs.webkit.org/show_bug.cgi?id=40548
506
507         * Scripts/commit-log-editor: Split editor strings on spaces so EDITOR
508         values like "xed --launch --wait" work properly.
509
510         * Scripts/prepare-ChangeLog: Added a new CHANGE_LOG_EDITOR so we can
511         use a command line tool with the $openChangeLogs feature.
512
513 2010-08-11  Yury Semikhatsky  <yurys@chromium.org>
514
515         Reviewed by Pavel Feldman.
516
517         Web Inspector: remove InjectDispatch.js
518         https://bugs.webkit.org/show_bug.cgi?id=43835
519
520         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
521         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
522
523 2010-08-10  Dirk Pranke  <dpranke@chromium.org>
524
525         Reviewed by Eric Seidel.
526
527         webkit-patch should refuse to run under Win32 Python
528         https://bugs.webkit.org/show_bug.cgi?id=40962
529
530         Given that there are lots of places in webkit-patch's code that
531         assume unix-style filenames (forward slashes), webkit-patch fails
532         with weird file-not-found errors when run under a native windows
533         Python. It would be nice if we just trapped this and errored out
534         at the beginning, rather than producing unpredictable errors.
535
536         * Scripts/webkit-patch:
537
538 2010-08-10  Kent Tamura  <tkent@chromium.org>
539
540         Unreviewed, build fix.
541         
542         Chromium build fix for r65107.
543
544         * DumpRenderTree/chromium/LayoutTestController.cpp:
545         (LayoutTestController::suspendAnimations):
546         (LayoutTestController::resumeAnimations):
547
548 2010-08-10  Sergio Villar Senin  <svillar@igalia.com>
549
550         Reviewed by Xan Lopez.
551
552         [GTK] http/tests/media/video-cookie.html fails
553         https://bugs.webkit.org/show_bug.cgi?id=42240
554
555         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
556         (LayoutTestController::setAlwaysAcceptCookies): create the
557         SoupCookieJar if it does not exist. Otherwise the accept policy
558         won't be set.
559
560 2010-08-10  Chris Marrin  <cmarrin@apple.com>
561
562         Reviewed by Oliver Hunt.
563
564         Add suspendAnimations/resumeAnimation API to DRT
565         https://bugs.webkit.org/show_bug.cgi?id=43733
566         
567         Adds suspendAnimations() and resumeAnimations() to LayoutTestController.
568         Calls functions with the same names on AnimationController for the 
569         mainFrame.
570
571         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
572         * DumpRenderTree/LayoutTestController.cpp:
573         (suspendAnimationsCallback):
574         (resumeAnimationsCallback):
575         (LayoutTestController::staticFunctions):
576         * DumpRenderTree/LayoutTestController.h:
577         * DumpRenderTree/chromium/LayoutTestController.cpp:
578         (LayoutTestController::LayoutTestController):
579         (LayoutTestController::suspendAnimations):
580         (LayoutTestController::resumeAnimations):
581         * DumpRenderTree/chromium/LayoutTestController.h:
582         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
583         (LayoutTestController::suspendAnimations):
584         (LayoutTestController::resumeAnimations):
585         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
586         (LayoutTestController::suspendAnimations):
587         (LayoutTestController::resumeAnimations):
588         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
589         (LayoutTestController::suspendAnimations):
590         (LayoutTestController::resumeAnimations):
591         * DumpRenderTree/qt/LayoutTestControllerQt.h:
592         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
593         (LayoutTestController::suspendAnimations):
594         (LayoutTestController::resumeAnimations):
595         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
596         (LayoutTestController::suspendAnimations):
597         (LayoutTestController::resumeAnimations):
598
599 2010-08-10  Dimitri Glazkov  <dglazkov@chromium.org>
600
601         Reviewed by Ojan Vafai.
602
603         [Chromium/DRT] Enable saving layout test results.
604         https://bugs.webkit.org/show_bug.cgi?id=43796
605
606         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added more
607             parameters to the new-run-webkit-tests, including the name
608             of the test results server.
609
610 2010-08-10  Jian Li  <jianli@chromium.org>
611
612         More chromium build fix.
613
614         * DumpRenderTree/chromium/MockSpellCheck.cpp:
615         (MockSpellCheck::spellCheckWord):
616         (MockSpellCheck::initializeIfNeeded):
617         * DumpRenderTree/chromium/NotificationPresenter.cpp:
618         (NotificationPresenter::grantPermission):
619         (NotificationPresenter::show):
620         (NotificationPresenter::checkPermission):
621
622 2010-08-10  Jian Li  <jianli@chromium.org>
623
624         Chromium build fix.
625
626         * DumpRenderTree/chromium/MockSpellCheck.cpp:
627         * DumpRenderTree/chromium/NotificationPresenter.cpp:
628
629 2010-08-10  Victor Wang  <victorw@chromium.org>
630
631         Reviewed by Ojan Vafai.
632
633         Update test results server merge logic so the aggregated
634         results and times are updated for tests that are
635         in aggragated json but not in incremental json.
636
637         Also update unittest to test this case.
638
639         https://bugs.webkit.org/show_bug.cgi?id=43769
640
641         * TestResultServer/model/jsonresults.py:
642         * TestResultServer/model/jsonresults_unittest.py:
643
644 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
645
646         Reviewed by Ariya Hidayat.
647
648         [Qt] QtTestBrowser: proper set scene rect
649
650         When resizesToContents is ON scene's rect is set to the boundary of
651         the mainFrame. However, navigating to other web page should keep resizing
652         scene's rect according to the new document loaded. Patch addresses this issue.
653
654         Now resizesToContents and scrolling properly work on QtTestBrowser.
655
656         * QtTestBrowser/webview.cpp:
657         (WebViewGraphicsBased::setPage):
658         (WebViewGraphicsBased::contentsSizeChanged):
659         (WebViewGraphicsBased::setResizesToContents):
660         (WebViewGraphicsBased::resizeEvent):
661         * QtTestBrowser/webview.h:
662
663 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
664
665         Reviewed by Ariya Hidayat.
666
667         [Qt] QtTestBrowser: Clean up LauncherWindow code.
668
669         * QtTestBrowser/launcherwindow.cpp:
670         (LauncherWindow::LauncherWindow): Moves applyPrefs methods call from the constructor to init().
671         (LauncherWindow::init): Fixed comments.
672         (LauncherWindow::applyPrefs): Move the method around.
673         (LauncherWindow::createChrome): Move more code of this method around, for grouping, and fixing up comments.
674
675 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
676
677         Reviewed by Ariya Hidayat.
678
679         [Qt] QtTestBrowser: make reset-zooming to animate when tiled backing store is on.
680
681         It gets control+0 the same visual effect as control++ or control-.
682
683         * QtTestBrowser/launcherwindow.cpp:
684         (LauncherWindow::toggleZoomTextOnly):
685
686 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
687
688         Reviewed by Ariya Hidayat.
689
690         [Qt] QtTestBrowser:: make m_zoomLevels a static member.
691
692         Not all instances of LauncherWindow need its own m_zoomLevel.
693
694         * QtTestBrowser/launcherwindow.cpp:
695         * QtTestBrowser/launcherwindow.h:
696
697 2010-08-09  Sam Weinig  <sam@webkit.org>
698
699         Reviewed by Geoffrey Garen.
700
701         Add zoom support for injected bundle
702         https://bugs.webkit.org/show_bug.cgi?id=43759
703
704         Use zoom factor SPI to implement zoom related eventSender functions.
705
706         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
707         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
708         (WTR::EventSendingController::textZoomIn):
709         (WTR::EventSendingController::textZoomOut):
710         (WTR::EventSendingController::zoomPageIn):
711         (WTR::EventSendingController::zoomPageOut):
712         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
713         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
714         (WTR::InjectedBundlePage::reset): Reset zoom mode and level for each test.
715
716 2010-08-09  Gavin Barraclough  <barraclough@apple.com>
717
718         Speculative chromium build fix III.
719
720         * DumpRenderTree/chromium/MockSpellCheck.h:
721         * DumpRenderTree/chromium/NotificationPresenter.h:
722         * DumpRenderTree/chromium/WebViewHost.h:
723         (WebViewHost::addClearHeader):
724         (WebViewHost::clearHeaders):
725
726 2010-08-09  Ojan Vafai  <ojan@chromium.org>
727
728         Reviewed by Tony Chang.
729
730         increase the number of test results that we save
731         https://bugs.webkit.org/show_bug.cgi?id=43763
732
733         Now that we do incremental uploads, we can increase the number of
734         results that we save for http://test-results.appspot.com/dashboards/flakiness_dashboard.html.
735
736         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
737
738 2010-08-09  Evan Martin  <evan@chromium.org>
739
740         Reviewed by Tony Chang.
741
742         [chromium] DRT error print statement incorrectly tries to print a FILE*
743         https://bugs.webkit.org/show_bug.cgi?id=43747
744
745         * DumpRenderTree/chromium/ImageDiff.cpp:
746         (writeFile): pass the correct pointer.
747
748 2010-08-09  Victor Wang  <victorw@chromium.org>
749
750         Reviewed by Ojan Vafai.
751
752         Upload incremental test results json to server by default.
753
754         https://bugs.webkit.org/show_bug.cgi?id=43743
755
756         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
757
758 2010-08-09  Eric Seidel  <eric@webkit.org>
759
760         Reviewed by Adam Barth.
761
762         EWS bots wait 2 minutes between patches
763         https://bugs.webkit.org/show_bug.cgi?id=43731
764
765         * Scripts/webkitpy/tool/bot/queueengine.py:
766          - Don't sleep after failures.  This was a hold-over from
767            an earlier design.
768         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
769          - EWS bots were not properly reporting true/false from process_work_item.
770            They were always returning None, thus false, thus always logging
771            as a failure and sleeping 2 minutes after each patch.
772
773 2010-08-09  Sam Weinig  <sam@webkit.org>
774
775         Reviewed by Anders Carlsson.
776
777         Stub out EventSender for WebKitTestRunner
778         https://bugs.webkit.org/show_bug.cgi?id=43703
779
780         * WebKitTestRunner/DerivedSources.make:
781         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
782         Add ability to pass javascript arguments to the wrapped object.
783
784         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added.
785         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: Added.
786         (WTR::EventSendingController::create):
787         (WTR::EventSendingController::EventSendingController):
788         (WTR::EventSendingController::~EventSendingController):
789         (WTR::EventSendingController::wrapperClass):
790         (WTR::setExceptionForString):
791         (WTR::EventSendingController::mouseDown):
792         (WTR::EventSendingController::mouseUp):
793         (WTR::EventSendingController::mouseMoveTo):
794         (WTR::EventSendingController::keyDown):
795         (WTR::EventSendingController::contextClick):
796         (WTR::EventSendingController::leapForward):
797         (WTR::EventSendingController::textZoomIn):
798         (WTR::EventSendingController::textZoomOut):
799         (WTR::EventSendingController::zoomPageIn):
800         (WTR::EventSendingController::zoomPageOut):
801         (WTR::EventSendingController::makeWindowObject):
802         * WebKitTestRunner/InjectedBundle/EventSendingController.h: Added.
803         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
804         (WTR::InjectedBundle::reset):
805         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
806         (WTR::InjectedBundle::eventSendingController):
807         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
808         (WTR::InjectedBundlePage::didClearWindowForFrame):
809         Add stubbed out EventSenderController.
810
811         * WebKitTestRunner/InjectedBundle/GCController.h:
812         Remove incorrect comment.
813
814         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
815         * WebKitTestRunner/win/InjectedBundle.vcproj:
816         Add new files.
817
818 2010-08-08  Kent Tamura  <tkent@chromium.org>
819
820         Unreviewed, trivial fix.
821
822         Fix "WindowsError: [Error 32] The process cannot access the file
823         because it is being used by another process" introduced by r64959.
824
825         * BuildSlaveSupport/test-result-archive:
826
827 2010-08-08  Kent Tamura  <tkent@chromium.org>
828
829         Reviewed by Tony Chang.
830
831         Chromium buildbot: Avoid "zip" command dependency
832         https://bugs.webkit.org/show_bug.cgi?id=43470
833
834         * BuildSlaveSupport/test-result-archive:
835          For Chromium port, creates a zip archive with zipfile package of Python
836          instead of external "zip" command. We'd like to avoid additional
837          command installation.
838
839 2010-08-08  Jon Honeycutt  <jhoneycutt@apple.com>
840
841         WebKitTestRunner should add the QuickTime dir to the PATH environment
842         variable
843         https://bugs.webkit.org/show_bug.cgi?id=43686
844
845         Reviewed by Dan Bernstein.
846
847         * WebKitTestRunner/win/TestControllerWin.cpp:
848         (WTR::addQTDirToPATH):
849         Copied from DRT.
850         (WTR::TestController::platformInitialize):
851         Call addQTDirToPath().
852         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
853         Link to shlwapi.lib for SHGetValue.
854
855 2010-08-07  Sam Weinig  <sam@webkit.org>
856
857         Reviewed by Maciej Stachowiak.
858
859         WebKitTestRunner needs layoutTestController.dumpTitleChanges
860         <rdar://problem/8213861>
861         https://bugs.webkit.org/show_bug.cgi?id=42683
862
863         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
864         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
865         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
866         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
867         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
868         (WTR::LayoutTestController::LayoutTestController):
869         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
870         (WTR::LayoutTestController::dumpTitleChanges):
871         (WTR::LayoutTestController::shouldDumpTitleChanges):
872
873 2010-08-07  Sam Weinig  <sam@webkit.org>
874
875         Reviewed by Anders Carlsson.
876
877         WebKitTestRunner needs to print onunload handler information
878         <rdar://problem/8213831>
879         https://bugs.webkit.org/show_bug.cgi?id=42703
880
881         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
882         (WTR::operator<<):
883         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
884
885 2010-08-07  Sam Weinig  <sam@webkit.org>
886
887         Reviewed by Anders Carlsson.
888
889         Add additional loader client functions need to complete WebKitTestRunner
890         https://bugs.webkit.org/show_bug.cgi?id=43684
891
892         Remove unnecessary and jarring underscores as well.
893
894         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
895         (didClearWindowObjectForFrame):
896         (didCreatePage):
897         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
898         (WTR::InjectedBundlePage::InjectedBundlePage):
899         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
900         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
901         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
902         (WTR::InjectedBundlePage::didCommitLoadForFrame):
903         (WTR::InjectedBundlePage::didFinishLoadForFrame):
904         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
905         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
906         (WTR::InjectedBundlePage::didClearWindowForFrame):
907         (WTR::InjectedBundlePage::didCancelClientRedirectForFrame):
908         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
909         (WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
910         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
911         (WTR::InjectedBundlePage::didHandleOnloadEventsForFrame):
912         (WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
913         (WTR::InjectedBundlePage::didRunInsecureContentForFrame):
914         (WTR::InjectedBundlePage::willAddMessageToConsole):
915         (WTR::InjectedBundlePage::willSetStatusbarText):
916         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
917         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
918         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
919         (WTR::InjectedBundlePage::shouldBeginEditing):
920         (WTR::InjectedBundlePage::shouldEndEditing):
921         (WTR::InjectedBundlePage::shouldInsertNode):
922         (WTR::InjectedBundlePage::shouldInsertText):
923         (WTR::InjectedBundlePage::shouldDeleteRange):
924         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
925         (WTR::InjectedBundlePage::shouldApplyStyle):
926         (WTR::InjectedBundlePage::didBeginEditing):
927         (WTR::InjectedBundlePage::didEndEditing):
928         (WTR::InjectedBundlePage::didChange):
929         (WTR::InjectedBundlePage::didChangeSelection):
930         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
931
932 2010-08-07  Dan Bernstein  <mitz@apple.com>
933
934         Build fix.
935
936         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Made the references
937         to JSGCController.{cpp,h} relative to the build root.
938
939 2010-08-07  Sam Weinig  <sam@webkit.org>
940
941         Reviewed by Anders Carlsson.
942
943         WebKitTestRunner needs GCController
944         <rdar://problem/8213834>
945         https://bugs.webkit.org/show_bug.cgi?id=42701
946
947         * WebKitTestRunner/DerivedSources.make:
948         * WebKitTestRunner/InjectedBundle/Bindings/GCController.idl: Added.
949         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h:
950         (WTR::setProperty):
951         * WebKitTestRunner/InjectedBundle/GCController.cpp: Added.
952         (WTR::GCController::create):
953         (WTR::GCController::GCController):
954         (WTR::GCController::~GCController):
955         (WTR::GCController::wrapperClass):
956         (WTR::GCController::collect):
957         (WTR::GCController::collectOnAlternateThread):
958         (WTR::GCController::getJSObjectCount):
959         (WTR::GCController::makeWindowObject):
960         * WebKitTestRunner/InjectedBundle/GCController.h: Added.
961         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
962         (WTR::InjectedBundle::reset):
963         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
964         (WTR::InjectedBundle::bundle):
965         (WTR::InjectedBundle::gcController):
966         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
967         (WTR::InjectedBundlePage::didClearWindowForFrame):
968         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
969         (WTR::LayoutTestController::keepWebHistory):
970         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
971         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
972         * WebKitTestRunner/win/InjectedBundle.vcproj:
973
974 2010-08-05  Jon Honeycutt  <jhoneycutt@apple.com>
975
976         WebKitTestRunner needs to be able to set the font smoothing type
977         https://bugs.webkit.org/show_bug.cgi?id=43406
978
979         Reviewed by Adam Roben.
980
981         * WebKitTestRunner/TestInvocation.cpp:
982         (WTR::TestInvocation::resetPreferencesToConsistentValues):
983         Set the font smoothing level to
984         kWKFontSmoothingLevelNoSubpixelAntiAliasing to match DRT.
985
986 2010-08-06  Jon Honeycutt  <jhoneycutt@apple.com>
987
988         Fix a missed variable rename.
989
990         Unreviewed.
991
992         * Scripts/old-run-webkit-tests:
993
994 2010-08-06  Jon Honeycutt  <jhoneycutt@apple.com>
995
996         mac-wk2/Skipped should be used on Windows when running regression tests
997         https://bugs.webkit.org/show_bug.cgi?id=43494
998
999         Reviewed by Adam Roben.
1000
1001         * Scripts/old-run-webkit-tests:
1002         If the platform is win-wk2, also read the mac-wk2 skipped list.
1003
1004 2010-08-06  Kent Tamura  <tkent@chromium.org>
1005
1006         Reviewed by Dimitri Glazkov.
1007
1008         [DRT/Chromium] Should revoke scheduled tasks
1009         https://bugs.webkit.org/show_bug.cgi?id=43560
1010
1011         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1012         (DRTDevToolsAgent::reset): Calls RevokeAll().
1013         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1014         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1015         (DRTDevToolsClient::reset): Calls RevokeAll().
1016         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1017         * DumpRenderTree/chromium/EventSender.cpp:
1018         (EventSender::reset): Calls RevokeAll().
1019         * DumpRenderTree/chromium/LayoutTestController.cpp:
1020         (LayoutTestController::reset): Calls RevokeAll().
1021         * DumpRenderTree/chromium/TestShell.cpp:
1022         (TestShell::resetTestController): Calls DRTDevToolsAgent::reset() and DRTDevToolsClient::reset().
1023
1024 2010-08-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1025
1026         Reviewed by Antonio Gomes.
1027
1028         [Qt] Fix the DRT build on Mac OS X
1029
1030         * DumpRenderTree/qt/DumpRenderTree.pro:
1031
1032 2010-08-06  Jochen Eisinger  <jochen@chromium.org>
1033
1034         Reviewed by Pavel Feldman.
1035
1036         Rietvield's upload.py moved to a different location.
1037         https://bugs.webkit.org/show_bug.cgi?id=43613
1038
1039         * Scripts/webkitpy/thirdparty/__init__.py:
1040
1041 2010-05-23  Eric Seidel  <eric@webkit.org>
1042
1043         Reviewed by Adam Barth.
1044
1045         QueueStatusServer needs better queue-status pages
1046         https://bugs.webkit.org/show_bug.cgi?id=39562
1047
1048         The primary goal of this patch is to display queue
1049         positions somewhere on the site so that it's easier
1050         for commit-queue users to know when their pach will
1051         be landed.  I also tried to improve the root page
1052         to be more useful than the previous wall of status text.
1053
1054         * QueueStatusServer/handlers/recentstatus.py:
1055         * QueueStatusServer/main.py:
1056         * QueueStatusServer/model/queues.py:
1057         * QueueStatusServer/templates/recentstatus.html:
1058
1059 2010-08-05  Victor Wang  <victorw@chromium.org>
1060
1061         Reviewed by Ojan Vafai.
1062
1063         Add option to generate/upload incremental json results to test result server.
1064         Also refactor the json results generator unittest code to test
1065         incremental and aggregated json results.
1066
1067         https://bugs.webkit.org/show_bug.cgi?id=43519
1068
1069         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1070         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1071         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1072         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1073
1074 2010-08-05  Jian Li  <jianli@chromium.org>
1075
1076         Reviewed by David Levin.
1077
1078         Unify blob related feature defines to ENABLE(BLOB).
1079         https://bugs.webkit.org/show_bug.cgi?id=43081
1080
1081         * Scripts/build-webkit:
1082
1083 2010-08-05  Satish Sampath  <satish@chromium.org>
1084
1085         Reviewed by Jeremy Orlow.
1086
1087         Add speech input controller mock in WebKit and a layout test.
1088         https://bugs.webkit.org/show_bug.cgi?id=43477
1089
1090         Added LayoutTestController::setMockSpeechInputResultCallback method.
1091
1092         * DumpRenderTree/LayoutTestController.cpp:
1093         (setMockSpeechInputResultCallback): Wrapper invoking the member function.
1094         (LayoutTestController::staticFunctions):
1095         * DumpRenderTree/LayoutTestController.h:
1096         * DumpRenderTree/chromium/LayoutTestController.cpp:
1097         (LayoutTestController::LayoutTestController):
1098         (LayoutTestController::setMockSpeechInputResult): Sets the mock result.
1099         (LayoutTestController::speechInputController): Creates the mock controller.
1100         * DumpRenderTree/chromium/LayoutTestController.h:
1101         * DumpRenderTree/chromium/WebViewHost.cpp:
1102         (WebViewHost::speechInputController): Creates the mock controller.
1103         * DumpRenderTree/chromium/WebViewHost.h:
1104         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1105         (LayoutTestController::setMockSpeechInputResult): dummy method.
1106         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1107         (LayoutTestController::setMockSpeechInputResult): dummy method.
1108         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1109         (LayoutTestController::setMockSpeechInputResult): dummy method.
1110         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1111         * DumpRenderTree/win/LayoutTestControllerWin.cpp: dummy method.
1112         (LayoutTestController::setMockSpeechInputResult):
1113         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: dummy method.
1114         (LayoutTestController::setMockSpeechInputResult):
1115
1116 2010-08-04  Adam Roben  <aroben@apple.com>
1117
1118         Fix the path to TestNetscapePlugin's directory on Windows
1119
1120         Fixes <http://webkit.org/b/43513> WebKitTestRunner on Windows fails to
1121         load TestNetscapePlugin
1122
1123         Reviewed by Jon Honeycutt.
1124
1125         * WebKitTestRunner/win/TestControllerWin.cpp:
1126         (WTR::TestController::initializeTestPluginDirectory):
1127         TestNetscapePlugin is in a TestNetscapePlugin[_Debug] directory that's
1128         next to WebKitTestRunner.exe. Previously we were passing the directory
1129         that contains WebKitTestRunner.exe. Also fixed some leaks.
1130
1131 2010-08-05  Kenichi Ishibashi  <bashi@google.com>
1132
1133         Reviewed by Shinichiro Hamaji.
1134
1135         check-webkit-style returns non-zero when patch is entirely minus lines.
1136         https://bugs.webkit.org/show_bug.cgi?id=38169
1137
1138         * Scripts/check-webkit-style:
1139         Check whether a patch contains modified files that are entirely minus lines.
1140         * Scripts/webkitpy/style/filereader.py:
1141         Add a variable that holds number of files that contain only deleted lines.
1142         * Scripts/webkitpy/style/patchreader.py:
1143         Count up modified files that contain only deleted lines.
1144
1145 2010-08-05  Pavel Feldman  <pfeldman@chromium.org>
1146
1147         Reviewed by Yury Semikhatsky.
1148
1149         DevTools: get rid of delayed command dispatching on front-end side.
1150
1151         https://bugs.webkit.org/show_bug.cgi?id=43479
1152
1153         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1154         (DRTDevToolsAgent::detach):
1155         (DRTDevToolsAgent::frontendLoaded):
1156         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1157         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1158         (DRTDevToolsClient::~DRTDevToolsClient):
1159         (DRTDevToolsClient::sendFrontendLoaded):
1160         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1161
1162 2010-08-04  Kenichi Ishibashi  <bashi@google.com>
1163
1164         Reviewed by Shinichiro Hamaji.
1165
1166         Fixes check-webkit-style false positive on "new uint32_t."
1167         https://bugs.webkit.org/show_bug.cgi?id=43077
1168
1169         * Scripts/webkitpy/style/checkers/cpp.py:
1170         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1171
1172 2010-08-04  Kent Tamura  <tkent@chromium.org>
1173
1174         Reviewed by Dimitri Glazkov.
1175
1176         [DRT/Chromium] Remove base/linked_ptr.h dependency
1177         https://bugs.webkit.org/show_bug.cgi?id=43472
1178
1179         Replace linked_ptr<TestNavigationEntry> with RefPtr<TestNavigationEntry>.
1180         We need to use RefPtr<> because m_pendingEntry points an object in
1181         m_entries or not in m_entries.
1182
1183         * DumpRenderTree/chromium/TestNavigationController.cpp:
1184         (TestNavigationEntry::create): Added.
1185         (TestNavigationController::activeEntry):
1186         (TestNavigationController::didNavigateToEntry):
1187         (TestNavigationController::discardPendingEntry):
1188         (TestNavigationController::insertEntry):
1189         (TestNavigationController::navigateToPendingEntry):
1190         * DumpRenderTree/chromium/TestNavigationController.h:
1191         * DumpRenderTree/chromium/WebViewHost.cpp:
1192         (WebViewHost::loadURLForFrame):
1193          Use TestNavigationEntry::create().
1194         (WebViewHost::updateURL):
1195          Use RefPtr<>.
1196         (WebViewHost::updateSessionHistory):
1197          Remove unnecessary static_cast<>.
1198
1199 2010-08-04  Kent Tamura  <tkent@chromium.org>
1200
1201         Reviewed by Dimitri Glazkov.
1202
1203         Fix a problem that "archived test results" step doesn't work on Chromium buildbots
1204         https://bugs.webkit.org/show_bug.cgi?id=43333
1205
1206         * BuildSlaveSupport/test-result-archive:
1207           - Make layoutTestResultsDir local and pass it to archiveTestResults()
1208           - Adjust layoutTestResultsDir for Chromium
1209
1210 2010-08-04  Kent Tamura  <tkent@chromium.org>
1211
1212         Reviewed by Dimitri Glazkov.
1213
1214         NRWT: websocket_server startup detection failure
1215         https://bugs.webkit.org/show_bug.cgi?id=43466
1216
1217         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1218          Increase timeout value: 5 second -> 10 second
1219
1220 2010-08-04  Victor Wang  <victorw@chromium.org>
1221
1222         Reviewed by Ojan Vafai.
1223
1224         -. Add result.json incremental merging functionality to test results app engine.
1225         -. blobstore is not suitable for AE data merging and there is no API to
1226            programatically edit existing blob or write a new one yet, so replace blobstore
1227            with datastore. If file is oversize (>1000*1000 bytes), store file data in
1228            multiple datastore entries.
1229         -. Fix styles.
1230
1231         Test: jsonresults_unittest to test merging logics.
1232
1233         https://bugs.webkit.org/show_bug.cgi?id=38599
1234
1235         * TestResultServer/handlers/dashboardhandler.py:
1236         * TestResultServer/handlers/menu.py:
1237         * TestResultServer/handlers/testfilehandler.py:
1238         * TestResultServer/main.py:
1239         * TestResultServer/model/dashboardfile.py:
1240         * TestResultServer/model/datastorefile.py: Added.
1241         * TestResultServer/model/jsonresults.py: Added.
1242         * TestResultServer/model/jsonresults_unittest.py: Added.
1243         * TestResultServer/model/testfile.py:
1244         * TestResultServer/templates/uploadform.html:
1245
1246 2010-08-04  Antonio Gomes  <tonikitoo@webkit.org>
1247
1248         Reviewed by Kenneth Christiansen.
1249
1250         [Qt] [QtTestBrowser] Remove unneeded QAction class members
1251         https://bugs.webkit.org/show_bug.cgi?id=43518
1252
1253         LauncherWindow class has two totally unneeded class members: m_flopAnimated and
1254         m_flipYAnimated. Also, in initializeView method there are some dead code block
1255         trying to connect them at the wrong time, when they have not been instanciated.
1256
1257         This patch:
1258
1259         - removes the two cited class members in favor of local variables in createChrome method;
1260         - removes the dead code block.
1261
1262         * QtTestBrowser/launcherwindow.cpp:
1263         (LauncherWindow::LauncherWindow):
1264         (LauncherWindow::initializeView):
1265         (LauncherWindow::createChrome):
1266         * QtTestBrowser/launcherwindow.h:
1267
1268 2010-08-04  Antonio Gomes  <tonikitoo@webkit.org>
1269
1270         Reviewed by Simon Hausmann and Kenneth Christiansen.
1271
1272         [Qt] [QtTestBrowser] Clean up static and global menu state controls
1273         https://bugs.webkit.org/show_bug.cgi?id=43448
1274
1275         After LauncherWindow class was refactored out of from main.cpp, all global variables that
1276         were hanging in main.cpp became temporarily public static class members of newly added
1277         LauncherWindow class. This design was not properly handling the initial purpose of the
1278         global variables: newly created launcher windows should inherit the settings of the originating
1279         one.
1280
1281         In order to properly fix the problem, this patch introduces a WindowOptions class, as a POD. It
1282         comprises all data needed to handling the goal described above.
1283
1284         * QtTestBrowser/launcherwindow.cpp:
1285         (LauncherWindow::LauncherWindow): The class now receives an optional WindowOptions pointer object
1286                                           holding all user settings configured in the menus and command line.
1287                                           It also receices an optional QGraphicsScene points in case we are doing
1288                                           a "Clone Window".
1289         (LauncherWindow::init): Removed the usesGraphics parameter because the class member m_userData holds its
1290                                 value.
1291         (LauncherWindow::initializeView): Ditto.
1292         (LauncherWindow::createChrome): Changed all references to gXXX to m_userData.XXX
1293         (LauncherWindow::applyPrefs): Removed the "LauncherWindow* source" parameter. All data needed to properly
1294                                       apply the preferences is provided by m_userData.
1295         (LauncherWindow::toggleAcceleratedCompositing): Change gXXX by m_userData.XXX
1296         (LauncherWindow::toggleResizesToContents): Ditto.
1297         (LauncherWindow::toggleWebGL): Ditto.
1298         (LauncherWindow::toggleFrameFlattening): Ditto.
1299         (LauncherWindow::toggleQGLWidgetViewport): Ditto.
1300         (LauncherWindow::changeViewportUpdateMode): Ditto.
1301         (LauncherWindow::showFPS): Ditto.
1302         (LauncherWindow::newWindow): Changed to pass the userData.
1303         (LauncherWindow::cloneWindow): Ditto.
1304         * QtTestBrowser/launcherwindow.h:
1305         (WindowOptions::WindowOptions):
1306         * QtTestBrowser/main.cpp:
1307         (requiresGraphicsView):
1308         (LauncherApplication::handleUserOptions):
1309         (main):
1310
1311 2010-08-04  Kevin Ollivier  <kevino@theolliviers.com>
1312
1313         [wx] Build fix for gcc not importing all symbols from convenience libraries.
1314         Works on 10.6 only for Mac until the build system is reworked. 
1315
1316         * wx/build/settings.py:
1317
1318 2010-08-04  Markus Goetz  <Markus.Goetz@nokia.com>
1319
1320         Reviewed by Simon Hausmann.
1321
1322         [Qt] Change wording in QtTestBrowser
1323         https://bugs.webkit.org/show_bug.cgi?id=43241
1324
1325         * QtTestBrowser/launcherwindow.cpp:
1326         (LauncherWindow::createChrome):
1327
1328 2010-08-04  Aaron Boodman  <aa@chromium.org>
1329
1330         Reviewed by Eric Seidel.
1331
1332         prepare-ChangeLog fails mysteriously if curl doesn't support ssl
1333         https://bugs.webkit.org/show_bug.cgi?id=43460
1334
1335         * Scripts/prepare-ChangeLog:
1336
1337 2010-08-03  MORITA Hajime  <morrita@google.com>
1338
1339         Reviewed by Tony Chang.
1340
1341         [DRT] Assertion failed when drag and move a draggable element.
1342         https://bugs.webkit.org/show_bug.cgi?id=41695
1343
1344         mouseMoveToX() did call [WebHTMLView mouseDragged] even if dragging started.
1345         But Cocoa doesn't call mouseDragged() until dragging is done.
1346         Other part of DumpRenderTree also assumes Cocoa behavior and an assertion
1347         on UIDelegate failed when mouseDragged() is called during dragging.
1348         This change eliminated the mouseDragged() call when dragging begins,
1349         which is implicated by draggingInfo instance.
1350         
1351         * DumpRenderTree/mac/EventSendingController.mm:
1352         (-[EventSendingController mouseMoveToX:Y:]):
1353
1354         Test: fast/events/dragging-mouse-moves.html
1355         
1356 2010-08-02  Steve Block  <steveblock@google.com>
1357
1358         Reviewed by Alexey Proskuryakov.
1359
1360         Adds Geolocation LayoutTests for the case where permission is not granted or denied immediately
1361         https://bugs.webkit.org/show_bug.cgi?id=40002
1362
1363         The code in LayoutTestController::setGeolocationPermission() was moved to
1364         setGeolocationPermissionCommon() to allow each port to provide its own
1365         implementation of setGeolocationPermission().
1366
1367         For the Mac port, setGeolocationPermission() notifies the UIDelegate of the
1368         new permission, so it can call back to WebCore if permission requests are in
1369         progress and are waiting for a response. A minor fix to the Mac
1370         MockGeolocationProvider was also required to make sure that the mock provider
1371         calls back to WebCore when it is first started.
1372
1373         For other ports, LayoutTestController::setGeolocationPermission() is not
1374         implemented.
1375
1376         * DumpRenderTree/LayoutTestController.cpp:
1377         (LayoutTestController::setGeolocationPermissionCommon):
1378         * DumpRenderTree/LayoutTestController.h:
1379         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1380         (LayoutTestController::setGeolocationPermission):
1381         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1382         (LayoutTestController::setGeolocationPermission):
1383         * DumpRenderTree/mac/MockGeolocationProvider.mm:
1384         (-[MockGeolocationProvider registerWebView:]):
1385         * DumpRenderTree/mac/UIDelegate.h:
1386         * DumpRenderTree/mac/UIDelegate.mm:
1387         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
1388         (-[UIDelegate setGeolocationPermission:]):
1389         (-[UIDelegate dealloc]):
1390         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1391         (LayoutTestController::setGeolocationPermission):
1392         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1393         (LayoutTestController::setGeolocationPermission):
1394
1395 2010-08-03  Kent Tamura  <tkent@chromium.org>
1396
1397         Reviewed by Dimitri Glazkov.
1398
1399         [DRT/Chromium] Implement --testshell-startup-dialog
1400         https://bugs.webkit.org/show_bug.cgi?id=40616
1401
1402         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1403         (main): Check --testshell-startup-dialog, and call openStartUpDialog()
1404         if it is specfied.
1405         * DumpRenderTree/chromium/TestShell.h:
1406           Declare openStartUpDialog().
1407         * DumpRenderTree/chromium/TestShellGtk.cpp:
1408         (openStartupDialog):
1409         * DumpRenderTree/chromium/TestShellMac.mm:
1410         (openStartupDialog):
1411         * DumpRenderTree/chromium/TestShellWin.cpp:
1412         (openStartupDialog):
1413
1414 2010-08-03  Kent Tamura  <tkent@chromium.org>
1415
1416         Reviewed by Dimitri Glazkov.
1417
1418         [DRT/Chromium] Remove dependency of base/md5.h
1419         https://bugs.webkit.org/show_bug.cgi?id=43403
1420
1421         * DumpRenderTree/chromium/TestShell.cpp:
1422         (TestShell::dumpImage): Use wtf/MD5.h
1423
1424 2010-08-03  Joseph Pecoraro  <joepeck@webkit.org>
1425
1426         Reviewed by David Kilzer.
1427
1428         Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
1429         https://bugs.webkit.org/show_bug.cgi?id=40627
1430
1431         Part 6 - LayoutTest and Cleanup
1432
1433           Allow tests to delete application caches and set application cache
1434           origin quotas, so they can be tested.
1435
1436         * DumpRenderTree/LayoutTestController.cpp:
1437         (LayoutTestController::LayoutTestController):
1438         (dumpApplicationCacheDelegateCallbacksCallback): JavaScript callback, delegates to the controller.
1439         (clearAllApplicationCachesCallback): should delete all application caches.
1440         (setApplicationCacheOriginQuotaCallback): should set the origin quota for the localhost tests.
1441         (LayoutTestController::staticFunctions):
1442         * DumpRenderTree/LayoutTestController.h:
1443         (LayoutTestController::dumpApplicationCacheDelegateCallbacks): accessor to see if application cache callbacks should be output.
1444         (LayoutTestController::setDumpApplicationCacheDelegateCallbacks): enable or disable debug output when the application cache quota is reached.
1445
1446           Mac implementation.
1447
1448         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1449         (LayoutTestController::clearAllApplicationCaches): delete application caches.
1450         (LayoutTestController::setApplicationCacheOriginQuota): set the quota for localhost.
1451         * DumpRenderTree/mac/UIDelegate.mm:
1452         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): style fix.
1453         (-[UIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:]): reset the quota.
1454
1455           Stub implementations for other platforms.
1456
1457         * DumpRenderTree/chromium/LayoutTestController.cpp:
1458         (LayoutTestController::LayoutTestController):
1459         (LayoutTestController::clearAllApplicationCaches):
1460         (LayoutTestController::setApplicationCacheOriginQuota):
1461         * DumpRenderTree/chromium/LayoutTestController.h:
1462         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1463         (LayoutTestController::clearAllApplicationCaches):
1464         (LayoutTestController::setApplicationCacheOriginQuota):
1465         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1466         (LayoutTestController::clearAllApplicationCaches):
1467         (LayoutTestController::setApplicationCacheOriginQuota):
1468         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1469         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1470         (LayoutTestController::clearAllApplicationCaches):
1471         (LayoutTestController::setApplicationCacheOriginQuota):
1472         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1473         (LayoutTestController::clearAllApplicationCaches):
1474         (LayoutTestController::setApplicationCacheOriginQuota):
1475
1476 2010-08-03  Joseph Pecoraro  <joepeck@webkit.org>
1477
1478         Reviewed by David Kilzer.
1479
1480         Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
1481         https://bugs.webkit.org/show_bug.cgi?id=40627
1482
1483         Part 5 - Refactor Quota Management in WebSecurityOrigin into Managers
1484
1485           Change old style calls to make use of the managers.
1486
1487         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1488         (LayoutTestController::setDatabaseQuota):
1489         * DumpRenderTree/mac/UIDelegate.mm:
1490         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]):
1491
1492 2010-08-03  Mark Rowe  <mrowe@apple.com>
1493
1494         Add a new Leopard build slave to run the release tests.
1495
1496         * BuildSlaveSupport/build.webkit.org-config/config.json:
1497
1498 2010-08-03  Jon Honeycutt  <jhoneycutt@apple.com>
1499
1500         WebKitTestRunner needs to activate the Mac font ascent hack
1501         https://bugs.webkit.org/show_bug.cgi?id=43404
1502
1503         Reviewed by Darin Adler.
1504
1505         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1506         (WTR::InjectedBundle::initialize):
1507         Call WKBundleActivateMacFontAscentHack().
1508
1509 2010-08-03  Alex Milowski  <alex@milowski.com>
1510
1511         Reviewed by Beth Dakin.
1512
1513         Changed the default for MathML support so that is is enabled by default.
1514
1515         * Scripts/build-webkit:
1516
1517 2010-08-03  Sam Weinig  <sam@webkit.org>
1518
1519         Roll r64566 back in this time with all the overloads in place..
1520
1521         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1522         (WTR::InjectedBundlePage::shouldInsertNode):
1523         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1524         * WebKitTestRunner/StringFunctions.h:
1525         * WebKitTestRunner/TestInvocation.cpp:
1526         (WTR::TestInvocation::resetPreferencesToConsistentValues):
1527         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1528         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1529
1530 2010-08-03  Sam Weinig  <sam@webkit.org>
1531
1532         Rollout r64566. It broke all the WebKit2 tests.
1533
1534         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1535         (WTR::operator<<):
1536         (WTR::InjectedBundlePage::shouldInsertNode):
1537         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1538         * WebKitTestRunner/StringFunctions.h: Removed.
1539         * WebKitTestRunner/TestInvocation.cpp:
1540         (WTR::createWKURL):
1541         (WTR::WKStringToUTF8):
1542         (WTR::TestInvocation::resetPreferencesToConsistentValues):
1543         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1544         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1545
1546 2010-08-03  Sam Weinig  <sam@webkit.org>
1547
1548         Reviewed by Anders Carlsson.
1549
1550         WTR: Move all the utility functions for working with strings to a shared header.
1551         https://bugs.webkit.org/show_bug.cgi?id=43386
1552
1553         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1554         (WTR::InjectedBundlePage::shouldInsertNode):
1555         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1556         * WebKitTestRunner/StringFunctions.h: Added.
1557         * WebKitTestRunner/TestInvocation.cpp:
1558         (WTR::TestInvocation::resetPreferencesToConsistentValues):
1559         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1560         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1561
1562 2010-08-02  Antonio Gomes  <tonikitoo@webkit.org>
1563
1564         Reviewed by Kenneth Christiansen.
1565
1566         [Qt] QtTestBrowser not setting preferredContentsSize for resizesToContents
1567         https://bugs.webkit.org/show_bug.cgi?id=43168
1568
1569         QGraphicsWebView resizesToContents property has to work together with QWebPage's
1570         setPreferredContentsSize as stated by the docs. Patch addresses that for QtTestBrowser.
1571
1572         * QtTestBrowser/launcherwindow.cpp:
1573         (LauncherWindow::applyPrefs):
1574         * QtTestBrowser/webview.cpp:
1575         (WebViewGraphicsBased::setResizesToContents): Properly handle scene, webview and viewport sizes
1576                                                       needed when toggle resizesToContents on/off.
1577         (WebViewGraphicsBased::resizeEvent):
1578         * QtTestBrowser/webview.h:
1579         (WebViewGraphicsBased::setCustomLayoutSize): Setter helper.
1580         (WebViewGraphicsBased::customLayoutSize): Getter helper.
1581
1582 2010-08-03  Jochen Eisinger  <jochen@chromium.org>
1583
1584         Unreviewed. Adding myself as committer.
1585
1586         * Scripts/webkitpy/common/config/committers.py:
1587
1588 2010-08-02  Pavel Feldman  <pfeldman@chromium.org>
1589
1590         Reviewed by Yury Semikhatsky.
1591
1592         Chromium DevTools: Get rid of DevTools RPC.
1593
1594         https://bugs.webkit.org/show_bug.cgi?id=43335
1595
1596         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1597         (DRTDevToolsAgent::sendMessageToInspectorFrontend):
1598         (DRTDevToolsAgent::call):
1599         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1600         * DumpRenderTree/chromium/DRTDevToolsCallArgs.h:
1601         (DRTDevToolsCallArgs::DRTDevToolsCallArgs):
1602         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1603         (DRTDevToolsClient::sendMessageToBackend):
1604         (DRTDevToolsClient::call):
1605         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1606
1607 2010-08-02  Kent Tamura  <tkent@chromium.org>
1608
1609         Reviewed by Dimitri Glazkov.
1610
1611         [DRT/Chromium] Remove dependencies to some Chromium headers
1612         https://bugs.webkit.org/show_bug.cgi?id=43396
1613
1614         * DumpRenderTree/chromium/CppVariant.h:
1615          Remove base/basictypes.h because webkit_support.h contains it.
1616         * DumpRenderTree/chromium/EventSender.cpp:
1617         (getCurrentEventTimeSec): Use new wrapper function.
1618         * DumpRenderTree/chromium/TestNavigationController.h:
1619          Remove base/basictypes.h because webkit_support.h contains it.
1620         * DumpRenderTree/chromium/TestShell.cpp:
1621         (dumpHistoryItem): Use new wrapper function.
1622         * DumpRenderTree/chromium/WebViewHost.cpp:
1623         (WebViewHost::cancelledError): Use new wrapper function.
1624         (WebViewHost::didFailResourceLoad): Use new wrapper function.
1625
1626 2010-08-02  Martin Robinson  <mrobinson@igalia.com>
1627
1628         Reviewed by Xan Lopez.
1629
1630         [GTK] DRT implement execCommand()
1631         https://bugs.webkit.org/show_bug.cgi?id=35351
1632
1633         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1634         (LayoutTestController::execCommand): Implement using webkit_web_view_execute_core_command_by_name.
1635         (LayoutTestController::isCommandEnabled): Implement using webkit_web_view_is_command_enabled.
1636         (LayoutTestController::setCacheModel): Move below LayoutTestController::isCommandEnabled.
1637
1638 2010-08-02  Sam Weinig  <sam@webkit.org>
1639
1640         Reviewed by Anders Carlsson.
1641
1642         Add alias for run-webkit-tests --webkit-test-runner (run-webkit-tests -2).
1643
1644         * Scripts/old-run-webkit-tests:
1645
1646 2010-08-02  Jon Honeycutt  <jhoneycutt@apple.com>
1647
1648         WebKitTestRunner needs to support loading custom fonts (via the
1649         WEBKIT_TESTFONTS environment variable)
1650         https://bugs.webkit.org/show_bug.cgi?id=42782
1651
1652         Reviewed by Adam Roben.
1653
1654         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:
1655         (WTR::fontsPath):
1656         Copied from DRT code. Removed the fallback to DumpRenderTree.resources/,
1657         as this directory doesn't appear to be created anymore.
1658         (WTR::activateFonts):
1659         Loop through the fonts, and call AddFontResourceExW() for each.
1660
1661 2010-08-02  Jon Honeycutt  <jhoneycutt@apple.com>
1662
1663         Restore the WebKitTestRunner.sln that was removed, and remove the
1664         correct one.
1665
1666         Rubber-stamped by Sam Weinig.
1667
1668         * WebKitTestRunner/WebKitTestRunner.sln: Added.
1669         * WebKitTestRunner/win/WebKitTestRunner.sln: Removed.
1670
1671 2010-08-02  Jon Honeycutt  <jhoneycutt@apple.com>
1672
1673         Move InjectedBundle.vcproj to where the other WebKitTestRunner vcprojs live.
1674
1675         Remove the unused WebKitTestRunner.sln.
1676
1677         Reviewed by Sam Weinig.
1678
1679         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
1680         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: Removed.
1681         * WebKitTestRunner/WebKitTestRunner.sln: Removed.
1682         * WebKitTestRunner/win/InjectedBundle.vcproj: Added.
1683         * WebKitTestRunner/win/WebKitTestRunner.sln:
1684
1685 2010-08-02  Sam Weinig  <sam@webkit.org>
1686
1687         Fix the windows build.
1688
1689         * WebKitTestRunner/win/main.cpp:
1690
1691 2010-07-29  Jon Honeycutt  <jhoneycutt@apple.com>
1692
1693         Add a Skipped list on Windows, and have run-webkit-tests respect it.
1694
1695         Part of <rdar://problem/8233237> Fill WebKit2 Windows skipped list so
1696         there are zero tests failing
1697         https://bugs.webkit.org/show_bug.cgi?id=43374
1698
1699         Reviewed by Adam Roben.
1700
1701         * Scripts/old-run-webkit-tests:
1702         If using WebKitTestRunner and Apple Windows WebKit, set the platform to
1703         win-wk2. When building the result hierarchy, if the platform is win-wk2,
1704         add it first to the list of platforms.
1705
1706 2010-08-02  Darin Adler  <darin@apple.com>
1707
1708         Reviewed by Sam Weinig.
1709
1710         WebKitTestRunner needs layoutTestController.setCanOpenWindows
1711         https://bugs.webkit.org/show_bug.cgi?id=42321
1712
1713         WebKitTestRunner needs layoutTestController.setCloseRemainingWindowsWhenComplete
1714         https://bugs.webkit.org/show_bug.cgi?id=42779
1715
1716         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added
1717         setCanOpenWindows, setCloseRemainingWindowsWhenComplete, and windowCount
1718
1719         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1720         (WTR::InjectedBundle::InjectedBundle): Initialize m_mainPage to 0 instead of
1721         waiting for the first call to didCreatePage.
1722         (WTR::InjectedBundle::didCreatePage): Set m_mainPage only when the first page
1723         is created. Put other pages into a map.
1724         (WTR::InjectedBundle::willDestroyPage): Added code to handle the destruction
1725         of the main page.
1726         (WTR::InjectedBundle::closeOtherPages): Added. Closes all the pages other than
1727         the main page.
1728         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Added pageCount and
1729         closeOtherPages functions.
1730
1731         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1732         (WTR::InjectedBundlePage::didFinishLoadForFrame): Don't let pages other than
1733         the main page affect dumping.
1734         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): Ditto.
1735
1736         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1737         (WTR::LayoutTestController::LayoutTestController): Initialize the new
1738         m_shouldCloseExtraWindows member.
1739         (WTR::LayoutTestController::setCanOpenWindows): Added. Empty for now.
1740         (WTR::LayoutTestController::windowCount): Added.
1741
1742         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1743         Added setCanOpenWindows, setCloseRemainingWindowsWhenComplete,
1744         windowCount, shouldCloseExtraWindowsAfterRunningTest, and
1745         m_shouldCloseExtraWindows.
1746
1747         * WebKitTestRunner/TestController.cpp:
1748         (WTR::TestController::shared): Return a pointer to the shared copy, but
1749         don't allocate and leak it. This seemed cleaner than adding an explicit
1750         finalize call to go along with the explicit initialize call.
1751         (WTR::TestController::TestController): Added calls to the initialize and
1752         run function, which are now done automatically.
1753         (WTR::TestController::~TestController): Added, since it's called now.
1754         (WTR::closeOtherPage): Added. Used to close pages other than the main page.
1755         (WTR::createOtherPage): Added. Used to create pages other than the main page.
1756         (WTR::TestController::initialize): Added code to set up createOtherPage.
1757         (WTR::TestController::run): Removed unused return value.
1758         * WebKitTestRunner/TestController.h: Made constructor and destructor public,
1759         and initialize and run private. Changed m_mainWebView to be an OwnPtr.
1760
1761         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1762         (WTR::PlatformWebView::PlatformWebView): Added a call to setReleasedWhenClosed
1763         to avoid releasing the window twice. Another way to handle it would be to
1764         remove the release, but this approach is slightly more robust because it works
1765         even if some other code calls the close method an extra time.
1766
1767         * WebKitTestRunner/mac/main.mm:
1768         (main): Use a stack-allocated TestController object instead of calling
1769         initalize and run on a globally allocated one.
1770
1771 2010-08-02  Tony Chang  <tony@chromium.org>
1772
1773         Reviewed by David Levin.
1774
1775         add myself to the reviewers list
1776         https://bugs.webkit.org/show_bug.cgi?id=43366
1777
1778         * Scripts/webkitpy/common/config/committers.py:
1779
1780 2010-08-02  Anders Carlsson  <andersca@apple.com>
1781
1782         Reviewed by Sam Weinig.
1783
1784         Cache JSNPObjects and fix bugs in the object map
1785         https://bugs.webkit.org/show_bug.cgi?id=43368
1786
1787         Test that we correctly throw exceptions when trying to do things to a JSObject that used to
1788         wrap an NPObject that came from a plug-in that is now destroyed.
1789
1790         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1791         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1792         (PluginTest::Object::getProperty):
1793         (PluginTest::Object::NP_GetProperty):
1794         (PluginTest::Object::npClass):
1795         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp: Added.
1796         (NPRuntimeObjectFromDestroyedPlugin::NPRuntimeObjectFromDestroyedPlugin):
1797         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasProperty):
1798         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::getProperty):
1799         (NPRuntimeObjectFromDestroyedPlugin::NPP_GetValue):
1800         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1801         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1802         * GNUmakefile.am:
1803
1804 2010-08-02  Martin Robinson  <mrobinson@igalia.com>
1805
1806         Reviewed by Xan Lopez.
1807
1808         [Gtk] DOM listeners get wrong keycodes for some keys
1809         https://bugs.webkit.org/show_bug.cgi?id=35170
1810
1811         Add support to all event senders for simulating keypad insert
1812         and print screen keys.
1813
1814         * DumpRenderTree/chromium/EventSender.cpp:
1815         (EventSender::keyDown): Add support for generating keypad insert and print screen.
1816         * DumpRenderTree/gtk/EventSender.cpp:
1817         (keyDownCallback): Ditto.
1818         * DumpRenderTree/mac/EventSendingController.mm:
1819         (-[EventSendingController keyDown:withModifiers:withLocation:]): Ditto.
1820         * DumpRenderTree/qt/EventSenderQt.cpp:
1821         (EventSender::keyDown): Ditto.
1822         * DumpRenderTree/win/EventSender.cpp:
1823         (keyDownCallback): Ditto.
1824
1825 2010-08-02  Martin Robinson  <mrobinson@igalia.com>
1826
1827         Build fix for building against development versions of GTK+. GTK 2.22
1828         has not yet been released, so these function definitions must be conditionalized
1829         on the development version.
1830
1831         * DumpRenderTree/gtk/EventSender.cpp: Fix GTK+ 2.21 build.
1832
1833 2010-08-02  Tony Chang  <tony@chromium.org>
1834
1835         Reviewed by Kent Tamura.
1836
1837         [chromium] use ChromiumDriver on Linux when running webkit tests
1838         https://bugs.webkit.org/show_bug.cgi?id=43273
1839
1840         * Scripts/webkitpy/layout_tests/port/chromium.py:
1841
1842 2010-08-02  Kent Tamura  <tkent@chromium.org>
1843
1844         Reviewed by Dimitri Glazkov.
1845
1846         [DRT/Chromium] Always initialize GTK
1847         https://bugs.webkit.org/show_bug.cgi?id=43327
1848
1849         Call gtk_init() in order to fix plugin test crash.
1850
1851         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1852         (main): Pass argc/argv to platformInit().
1853         * DumpRenderTree/chromium/TestShell.h:
1854         * DumpRenderTree/chromium/TestShellGtk.cpp:
1855         (platformInit): Update parameters, call gtk_init().
1856         * DumpRenderTree/chromium/TestShellMac.mm:
1857         (platformInit): Update parameters.
1858         * DumpRenderTree/chromium/TestShellWin.cpp:
1859         (platformInit): Update parameters.
1860
1861 2010-08-02  Balazs Kelemen  <kb@inf.u-szeged.hu>
1862
1863         Reviewed by Simon Hausmann.
1864
1865         [Qt] Generate forwarding headers for WebKit2
1866
1867         https://bugs.webkit.org/show_bug.cgi?id=43336
1868
1869         * Scripts/webkitdirs.pm: Call make on WebKit2/Makefile.DerivedSources.
1870
1871 2010-08-02  Fumitoshi Ukai  <ukai@chromium.org>
1872
1873         Reviewed by Kent Tamura.
1874
1875         WebSocket server should start with SO_REUSEADDR
1876         https://bugs.webkit.org/show_bug.cgi?id=43329
1877
1878         Pulls in pywebsocket-0.5.2.
1879         pywebsocket-0.5.2 includes a small fix to start server with SO_REUSE_ADDR.
1880         http://code.google.com/p/pywebsocket/source/detail?r=273
1881
1882         * Scripts/webkitpy/thirdparty/__init__.py: Bump pywebsocket version
1883
1884 2010-08-01  Kent Tamura  <tkent@chromium.org>
1885
1886         Reviewed by Dimitri Glazkov.
1887
1888         [DRT/Chromium] Remove string_util.h dependency
1889         https://bugs.webkit.org/show_bug.cgi?id=43312
1890
1891         * DumpRenderTree/chromium/LayoutTestController.cpp:
1892         (LayoutTestController::pathToLocalResource):
1893          Use string::find() instead of StartsWithASCII().
1894         (LayoutTestController::cppVariantToInt32):
1895          Use strtol() instead of StringToNumber().
1896
1897 2010-08-01  Sam Weinig  <sam@webkit.org>
1898
1899         Reviewed by Anders Carlsson.
1900
1901         Add ability to reset frame names for WebKitTestRunner
1902         https://bugs.webkit.org/show_bug.cgi?id=43316
1903
1904         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1905         (WTR::InjectedBundle::reset):
1906         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1907         (WTR::InjectedBundlePage::reset):
1908         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1909
1910 2010-08-01  Anders Carlsson  <andersca@apple.com>
1911
1912         Reviewed by Sam Weinig.
1913
1914         Implement NPN_RemoveProperty
1915         https://bugs.webkit.org/show_bug.cgi?id=43315
1916
1917         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1918         Add NPRuntimeRemoveProperty.cpp
1919         
1920         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1921         (PluginTest::NPN_GetStringIdentifier):
1922         (PluginTest::NPN_GetIntIdentifier):
1923         (PluginTest::NPN_RemoveProperty):
1924         Add NPN_ helpers.
1925
1926         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1927         Support more NPClass functions.
1928
1929         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp: Added.
1930         (NPRuntimeRemoveProperty::NPRuntimeRemoveProperty):
1931         Test for NPN_RemoveProperty.
1932
1933         (NPRuntimeRemoveProperty::TestObject::hasMethod):        
1934         (NPRuntimeRemoveProperty::TestObject::invoke):
1935         Add a testRemoveProperty method.
1936
1937         (NPRuntimeRemoveProperty::NPP_GetValue):
1938         Return the test object.
1939
1940         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1941         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1942         * GNUmakefile.am:
1943         Add NPRuntimeRemoveProperty.cpp
1944
1945 2010-07-30  Anders Carlsson  <andersca@apple.com>
1946
1947         Reviewed by Sam Weinig.
1948
1949         Add an NPObject class template helper to TestNetscapePlugin
1950         https://bugs.webkit.org/show_bug.cgi?id=43288
1951
1952         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1953         Add some template magic to be able to figure out if a class has a member function of a given type.
1954
1955         (PluginTest::Object::create):
1956         Create an object.
1957
1958         (PluginTest::Object::invokeDefault):
1959         Add dummy function, this should never be called.
1960
1961         (PluginTest::Object::Object):
1962         Initialize m_pluginTest to 0.
1963
1964         (PluginTest::Object::~Object):
1965         Add virtual destructor.
1966
1967         (PluginTest::Object::NP_Allocate):
1968         Create a new object.
1969
1970         (PluginTest::Object::NP_Deallocate):
1971         Delete the object.
1972
1973         (PluginTest::Object::NP_InvokeDefault):
1974         Call invokeDefault.
1975
1976         (PluginTest::Object::npClass):
1977         Initialize the NPClass struct.
1978
1979         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
1980         (DocumentOpenInDestroyStream::NPP_DestroyStream):
1981         Move this inline.
1982
1983         * DumpRenderTree/TestNetscapePlugIn/Tests/PluginScriptableNPObjectInvokeDefault.cpp:
1984         (PluginScriptableNPObjectInvokeDefault::NPObjectWithInvokeDefault::invokeDefault):
1985         (PluginScriptableNPObjectInvokeDefault::NPP_GetValue):
1986         Use the PluginTest::Object class template.
1987
1988 2010-07-31  Sam Weinig  <sam@webkit.org>
1989
1990         Reviewed by Dan Bernstein.
1991
1992         Patch for https://bugs.webkit.org/show_bug.cgi?id=43305
1993         Add back WKBundleFrameCopyInnerText to fix ~50 test failures
1994         due to SVGElements not having the innerText function.
1995
1996         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1997         (WTR::dumpFrameText):
1998
1999 2010-07-30  Sam Weinig  <sam@webkit.org>
2000
2001         Reviewed by Maciej Stachowiak.
2002
2003         Patch for https://bugs.webkit.org/show_bug.cgi?id=43290
2004         Add structured message passing from the injected bundle to UIProcess
2005
2006         * MiniBrowser/mac/AppDelegate.m:
2007         (didRecieveMessageFromInjectedBundle):
2008         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2009         (didClearWindowForFrame):
2010         (didRecieveMessage):
2011         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2012         (WTR::InjectedBundle::done):
2013         (WTR::InjectedBundle::didReceiveMessage):
2014         * WebKitTestRunner/TestController.cpp:
2015         (WTR::TestController::initialize):
2016         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2017         * WebKitTestRunner/TestController.h:
2018         * WebKitTestRunner/TestInvocation.cpp:
2019         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2020         * WebKitTestRunner/TestInvocation.h:
2021         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2022
2023 2010-07-30  Sam Weinig  <sam@webkit.org>
2024
2025         Reviewed by Anders Carlsson.
2026
2027         Patch for https://bugs.webkit.org/show_bug.cgi?id=43275
2028         Make WKArrayRef more usable.
2029
2030         Remove now unnecessary const_casts.
2031
2032         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2033         (WTR::dumpDescendantFrameScrollPositions):
2034         (WTR::dumpDescendantFramesText):
2035
2036 2010-07-30  Sam Weinig  <sam@webkit.org>
2037
2038         Reviewed by Anders Carlsson.
2039
2040         Patch for https://bugs.webkit.org/show_bug.cgi?id=43274
2041         Add first pass of structured message passing.
2042
2043         Update Minibrowser and WebKitTestRunner to work with the new post message
2044         function.
2045
2046         * MiniBrowser/mac/AppDelegate.m:
2047         (didRecieveMessageFromInjectedBundle):
2048         (-[BrowserAppDelegate init]):
2049         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2050         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2051         (didStartProvisionalLoadForFrame):
2052         (didReceiveServerRedirectForProvisionalLoadForFrame):
2053         (didFailProvisionalLoadWithErrorForFrame):
2054         (didCommitLoadForFrame):
2055         (didFinishLoadForFrame):
2056         (didFailLoadWithErrorForFrame):
2057         (didReceiveTitleForFrame):
2058         (didClearWindowForFrame):
2059         (didCreatePage):
2060         (willDestroyPage):
2061         (didRecieveMessage):
2062         (WKBundleInitialize):
2063         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2064         (WTR::InjectedBundle::_didReceiveMessage):
2065         (WTR::InjectedBundle::didReceiveMessage):
2066         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2067         * WebKitTestRunner/TestInvocation.cpp:
2068         (WTR::TestInvocation::invoke):
2069         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2070
2071 2010-07-30  Anders Carlsson  <andersca@apple.com>
2072
2073         Try to fix the layout test failures.
2074
2075         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2076         (webkit_test_plugin_get_value):
2077
2078 2010-07-29  Anders Carlsson  <andersca@apple.com>
2079
2080         Reviewed by Adam Roben.
2081
2082         Replace plugins/npruntime/bindings-test.html with a more sophisticated test
2083         https://bugs.webkit.org/show_bug.cgi?id=43232
2084
2085         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2086         Add PluginScriptableNPObjectInvokeDefault.cpp.
2087
2088         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2089         Remove invokeDefault callback function.
2090
2091         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2092         (PluginTest::create):
2093         Move this to the top of the file.
2094
2095         (PluginTest::NPP_GetValue):
2096         Add default implementation.
2097
2098         (PluginTest::NPN_CreateObject):
2099         Add NPN_ wrapper.
2100
2101         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2102         (PluginTest::identifier):
2103         Add identifier getter.
2104
2105         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
2106         (DocumentOpenInDestroyStream::DocumentOpenInDestroyStream):
2107         Add "using namespace std".
2108
2109         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2110         (NPP_GetValue):
2111         Give PluginTest a chance to return a value.
2112
2113         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2114         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2115         * GNUmakefile.am:
2116         Add PluginScriptableNPObjectInvokeDefault.cpp.
2117         
2118         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2119         (webkit_test_plugin_get_value):
2120         Give PluginTest a chance to return a value.
2121
2122 2010-07-30  Steve Block  <steveblock@google.com>
2123
2124         Reviewed by Steve Block.
2125
2126         Add LayoutTestController methods to test DeviceOrientation
2127         https://bugs.webkit.org/show_bug.cgi?id=39589
2128
2129         * DumpRenderTree/LayoutTestController.cpp:
2130         (setMockDeviceOrientationCallback):
2131         (LayoutTestController::staticFunctions):
2132         * DumpRenderTree/LayoutTestController.h:
2133         * DumpRenderTree/chromium/LayoutTestController.cpp:
2134         (LayoutTestController::LayoutTestController):
2135         (LayoutTestController::setMockDeviceOrientation):
2136         * DumpRenderTree/chromium/LayoutTestController.h:
2137         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2138         (LayoutTestController::setMockDeviceOrientation):
2139         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2140         (LayoutTestController::setMockDeviceOrientation):
2141         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2142         (LayoutTestController::setMockDeviceOrientation):
2143         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2144         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2145         (LayoutTestController::setMockDeviceOrientation):
2146         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2147         (LayoutTestController::setMockDeviceOrientation):
2148         * Scripts/build-webkit:
2149
2150 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
2151
2152         Reviewed by Kenneth Christiansen.
2153
2154         [Qt] QtTestBrowser: -resizes-to-contents command line parameter is broken
2155         https://bugs.webkit.org/show_bug.cgi?id=43209
2156
2157         When -resizes-to-content was being passed as a command line parameter it was simply
2158         not being set (although the corresponding menu item was marked as ON).
2159         User had to toggle the menu OFF and then ON again for it to take place.
2160
2161         Reason: LauncherWindow::applyPrefs method sets many user options passed in from
2162         the command line, but not resizesToContents. Patch addresses that.
2163
2164         * QtTestBrowser/launcherwindow.cpp:
2165         (LauncherWindow::createChrome):
2166         (LauncherWindow::applyPrefs):
2167         (LauncherWindow::toggleResizesToContents):
2168         * QtTestBrowser/webview.h:
2169         (WebViewGraphicsBased::resizesToContents):
2170
2171 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
2172
2173         Rubber-stamped by Simon Fraser.
2174
2175         [Qt] QtTestBrowser: more method grouping and clean ups.
2176
2177         Moving blocks of code around. Basically grouping related methods close to each.
2178
2179         * QtTestBrowser/launcherwindow.cpp:
2180         (LauncherWindow::initializeView):
2181         (LauncherWindow::createChrome):
2182         (LauncherWindow::changeViewportUpdateMode):
2183         (LauncherWindow::showFPS):
2184         (LauncherWindow::newWindow):
2185         (LauncherWindow::cloneWindow):
2186         * QtTestBrowser/launcherwindow.h:
2187
2188 2010-07-30  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2189
2190         Reviewed by Tor Arne Vestbø.
2191
2192         [QT][Symbian] QtTestBrowser missing location capabilities
2193         https://bugs.webkit.org/show_bug.cgi?id=43235
2194
2195         QtTestBrowser missing capabilities to use QtMobility::QLocation. 
2196
2197         * QtTestBrowser/QtTestBrowser.pro:
2198
2199 2010-07-29  Anders Carlsson  <andersca@apple.com>
2200
2201         Add PluginTest.cpp
2202
2203         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2204
2205 2010-07-29  Dirk Pranke  <dpranke@chromium.org>
2206
2207         Reviewed by Eric Seidel.
2208
2209         Update download URLs for python irclib package; the old URLs 
2210         pointed at a specific mirror host and not the general sourceforge
2211         URLs.
2212
2213         https://bugs.webkit.org/show_bug.cgi?id=43228
2214
2215         * Scripts/webkitpy/thirdparty/__init__.py:
2216
2217 2010-07-29  Anders Carlsson  <andersca@apple.com>
2218
2219         Fix typo.
2220
2221         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2222
2223 2010-07-29  Anders Carlsson  <andersca@apple.com>
2224
2225         Another attempt at fixing the Qt and GTK+ build.
2226
2227         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2228         (webkit_test_plugin_new_instance):
2229         (webkit_test_plugin_destroy_stream):
2230
2231 2010-07-29  Anders Carlsson  <andersca@apple.com>
2232
2233         Another build fix attempt.
2234
2235         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2236         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2237         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2238         (webkit_test_plugin_new_instance):
2239         * GNUmakefile.am:
2240
2241 2010-07-29  Anders Carlsson  <andersca@apple.com>
2242
2243         Try to fix Windows and Unix builds.
2244
2245         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2246         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2247         (webkit_test_plugin_new_instance):
2248         (webkit_test_plugin_destroy_stream):
2249
2250 2010-07-29  Anders Carlsson  <andersca@apple.com>
2251
2252         Reviewed by Sam Weinig.
2253
2254         Refactor TestNetscapePlugin so tests can be split in separate files
2255         https://bugs.webkit.org/show_bug.cgi?id=43220
2256
2257         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2258         Add PluginTest.cpp, PluginTest.h and Tests/DocumentOpenInDestroyStream.cpp.
2259
2260         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2261         (pluginAllocate):
2262         Initialize pluginTest to 0. Remove testDocumentOpenInDestroyStream.
2263
2264         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
2265         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: Added.
2266         (PluginTest::PluginTest):
2267         Initialize m_npp and the test identifier.
2268         
2269         (PluginTest::createTestFunctions):
2270         Return the map from identifiers to createTest functions.
2271
2272         (PluginTest::registerCreateTestFunction):
2273         Insert the identifier and create function pair in the map.
2274
2275         (PluginTest::create):
2276         Look for a createTest function. If one is found, call it. Otherwise create a vanilla PluginTest object.
2277
2278         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added.
2279         (PluginTest::Register::Register):
2280         Helper class template for registering plug-in tests.
2281         
2282         (PluginTest::Register::create):
2283         Create a new test of the given type.
2284
2285         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp: Added.
2286         (DocumentOpenInDestroyStream::DocumentOpenInDestroyStream):
2287         Add a test that calls testDocumentOpen from its NPP_DestroyStream callback.
2288
2289         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2290         (NPP_New):
2291         Create a PluginTest given the identifier. Remove the check for "testdocumentopenindestroystream".
2292
2293         (NPP_DestroyStream):
2294         Call the plug-in test NPP_DestroyStream member function.
2295
2296         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2297         Add PluginTest.cpp, PluginTest.h and Tests/DocumentOpenInDestroyStream.cpp.
2298
2299 2010-07-29  Martin Robinson  <mrobinson@igalia.com>
2300
2301         Unreviewed build fix.
2302
2303         Add missing second argument to assert_lint in new style checker tests.
2304
2305         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2306
2307 2010-07-29  Anders Carlsson  <andersca@apple.com>
2308
2309         Reviewed by Adam Roben.
2310
2311         check-webkit-style shouldn't complain about NPAPI functions
2312         https://bugs.webkit.org/show_bug.cgi?id=43211
2313
2314         Allow underscores in functions that start with NPN_, NPP_ or NP_.
2315
2316         * Scripts/webkitpy/style/checkers/cpp.py:
2317         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2318
2319 2010-07-29  Victor Wang  <victorw@chromium.org>
2320
2321         Unreviewed, rolling out r64270.
2322         http://trac.webkit.org/changeset/64270
2323         https://bugs.webkit.org/show_bug.cgi?id=39589
2324
2325         The patch breaks chromium webkit unittest
2326
2327         * DumpRenderTree/LayoutTestController.cpp:
2328         (LayoutTestController::staticFunctions):
2329         * DumpRenderTree/LayoutTestController.h:
2330         * DumpRenderTree/chromium/LayoutTestController.cpp:
2331         (LayoutTestController::LayoutTestController):
2332         * DumpRenderTree/chromium/LayoutTestController.h:
2333         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2334         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2335         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2336         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2337         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2338         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2339         * Scripts/build-webkit:
2340
2341 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
2342
2343         Reviewed by Kenneth Christiansen.
2344
2345         [Qt] QtTestBrowser: Move WebPage class methods definitions from main.cpp to webpage.cpp
2346         https://bugs.webkit.org/show_bug.cgi?id=43199
2347
2348         There is no sense in keeping WebPage method definitions in main.cpp once
2349         webpage.cpp already exists.
2350
2351         No behavior change.
2352
2353         * QtTestBrowser/main.cpp:
2354         * QtTestBrowser/webpage.cpp:
2355         (WebPage::createWindow):
2356         (WebPage::createPlugin):
2357
2358 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
2359
2360         Reviewed by Kenneth Christiansen.
2361
2362         [Qt] Factor out LauncherWindow class out of main.cpp (QtTestBrowser)
2363         https://bugs.webkit.org/show_bug.cgi?id=43170
2364
2365         Moving LauncherWindow class out of main.cpp to its own .cpp and .h files:
2366         launcherwindow.{cpp|h}
2367
2368         No behavior change.
2369
2370         Also changed all global static variables (named "gXXX") from main.cpp to
2371         static public variables of the LauncherWindow class.
2372
2373         * QtTestBrowser/QtTestBrowser.pro:
2374         * QtTestBrowser/launcherwindow.cpp: Added.
2375         * QtTestBrowser/launcherwindow.h: Added.
2376         * QtTestBrowser/main.cpp:
2377         (LauncherApplication::handleUserOptions):
2378         (main):
2379
2380 2010-07-29  Martin Robinson  <mrobinson@igalia.com>
2381
2382         Reviewed by Xan Lopez.
2383
2384         Build fix for building against GTK+ 3.x. GSEAL requires that we
2385         access internals of the GdkDragContext via methods. For older versions
2386         of GTK+, define those methods.
2387
2388         * DumpRenderTree/gtk/EventSender.cpp:
2389         (gdk_drag_context_get_selected_action): Added.
2390         (gdk_drag_context_get_actions): Added.
2391         (dispatchEvent): Use the two new accessor methods.
2392
2393 2010-07-29  Adam Roben  <aroben@apple.com>
2394
2395         Always say "plugins directory" when referring to a directory
2396         containing one or more plugins
2397
2398         Fixes <http://webkit.org/b/43197> WebKit2 often says "plugin
2399         directory" when it means "plugins directory"
2400
2401         Reviewed by John Sullivan.
2402
2403         * WebKitTestRunner/TestController.cpp:
2404         (WTR::TestController::initialize): Updated for rename.
2405
2406 2010-07-29  Adam Roben  <aroben@apple.com>
2407
2408         Always say "directory" when referring to a plugin directory
2409
2410         Fixes <http://webkit.org/b/43195> WebKit2 often says "plugin path"
2411         when it means "plugin directory"
2412
2413         Reviewed by John Sullivan.
2414
2415         * WebKitTestRunner/TestController.cpp:
2416         (WTR::TestController::initialize): Updated for renames.
2417
2418         * WebKitTestRunner/TestController.h: Renamed m_testPluginPath to
2419         m_testPluginDirectory.
2420         (WTR::TestController::testPluginDirectory): Renamed from
2421         testPluginPath.
2422
2423         * WebKitTestRunner/mac/TestControllerMac.mm:
2424         (WTR::TestController::initializeTestPluginDirectory):
2425         * WebKitTestRunner/win/TestControllerWin.cpp:
2426         (WTR::TestController::initializeTestPluginDirectory):
2427         Renamed from initializeTestPluginPath and updated for rename.
2428
2429 2010-07-29  Csaba Osztrogonác  <ossy@webkit.org>
2430
2431          Reviewed by Antonio Gomes.
2432
2433          Initialize all members of NPClass struct.
2434          https://bugs.webkit.org/show_bug.cgi?id=43193
2435
2436          * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2437
2438 2010-07-29  Csaba Osztrogonác  <ossy@webkit.org>
2439
2440         Reviewed by Antonio Gomes.
2441
2442         Warning fix on platforms where XP_MACOSX is undefined.
2443         https://bugs.webkit.org/show_bug.cgi?id=43192
2444
2445         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
2446         Use #if defined(XP_MACOSX) instead of #if XP_MACOSX .
2447
2448 2010-07-29  Adam Roben  <aroben@apple.com>
2449
2450         Give find-included-framework-headers our standard license
2451
2452         * Scripts/find-included-framework-headers: Used the license from
2453         WebCore/LICENSE-APPLE.
2454
2455 2010-07-29  Adam Roben  <aroben@apple.com>
2456
2457         Speed up find-included-framework-headers
2458
2459         We only do one invocation of find now, no longer pipe to grep, and
2460         replace uniq with sort -u.
2461
2462         Also added a license header.
2463
2464         * Scripts/find-included-framework-headers:
2465
2466 2010-07-29  Steve Block  <steveblock@google.com>
2467
2468         Reviewed by Jeremy Orlow.
2469
2470         Add LayoutTestController methods to test DeviceOrientation
2471         https://bugs.webkit.org/show_bug.cgi?id=39589
2472
2473         * DumpRenderTree/LayoutTestController.cpp:
2474         (setMockDeviceOrientationCallback):
2475         (LayoutTestController::staticFunctions):
2476         * DumpRenderTree/LayoutTestController.h:
2477         * DumpRenderTree/chromium/LayoutTestController.cpp:
2478         * DumpRenderTree/chromium/LayoutTestController.h:
2479         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2480         (LayoutTestController::setMockDeviceOrientation):
2481         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2482         (LayoutTestController::setMockDeviceOrientation):
2483         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2484         (LayoutTestController::setMockDeviceOrientation):
2485         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2486         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2487         (LayoutTestController::setMockDeviceOrientation):
2488         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2489         (LayoutTestController::setMockDeviceOrientation):
2490         * Scripts/build-webkit:
2491
2492 2010-07-28  Kenichi Ishibashi  <bashi@google.com>
2493
2494         Reviewed by Shinichiro Hamaji.
2495
2496         Fixed <https://bugs.webkit.org/show_bug.cgi?id=33814>
2497         check-webkit-style gives false positives in single-line functions.
2498
2499         * Scripts/webkitpy/style/checkers/cpp.py:
2500         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2501
2502 2010-07-28  Darin Adler  <darin@apple.com>
2503
2504         Reviewed by Sam Weinig.
2505
2506         WebKitTestRunner needs to support layoutTestController.execCommand
2507         <https://bugs.webkit.org/show_bug.cgi?id=42538>
2508
2509         WebKitTestRunner needs layoutTestController.isCommandEnabled
2510         <https://bugs.webkit.org/show_bug.cgi?id=42671>
2511
2512         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2513         Added execCommand and isCommandEnabled.
2514         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2515         (WTR::LayoutTestController::execCommand): Added.
2516         (WTR::LayoutTestController::isCommandEnabled): Added.
2517         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
2518
2519 2010-07-28  Kent Tamura  <tkent@chromium.org>
2520
2521         Reviewed by Dimitri Glazkov.
2522
2523         [DRT/Chromium] Introduce drt_expectations.txt for NRWT
2524         https://bugs.webkit.org/show_bug.cgi?id=43123
2525
2526         Introduce LayoutTests/platform/chromium/drt_expectations.txt,
2527         which overrides test expectations only for DumpRenderTree, in
2528         order to manage what problems are investigated.
2529         This change will be reverted when we switch to DRT completely.
2530
2531         * Scripts/webkitpy/layout_tests/port/chromium.py:
2532          Add drt_expectations.txt content to the result of
2533          test_expectations_overrides() if --use-drt is specified.
2534
2535 2010-07-28  Brady Eidson  <beidson@apple.com>
2536
2537         Reviewed by Darin Adler.
2538
2539         First pass at visited link support for WK2
2540         https://bugs.webkit.org/show_bug.cgi?id=43157
2541
2542         * MiniBrowser/mac/AppDelegate.m:
2543         (didNavigateWithNavigationData):
2544         (didPerformClientRedirect):
2545         (didPerformServerRedirect):
2546         (didUpdateHistoryTitle):
2547         (populateVisitedLinks): Added for the new version of the HistoryClient.
2548         (-[BrowserAppDelegate init]): Set the HistoryClient right after creating the context(s)
2549         
2550         * MiniBrowser/mac/BrowserWindowController.m:
2551         (-[BrowserWindowController awakeFromNib]):
2552
2553 2010-07-28  Robin Dunn  <robin@alldunn.com>
2554
2555         Reviewed by Kevin Ollivier.
2556
2557         Add DOM bindings support for wx port.
2558
2559         * DumpRenderTree/wscript:
2560         * wx/browser/wscript:
2561         * wx/build/settings.py:
2562
2563 2010-07-28  Tony Chang  <tony@chromium.org>
2564
2565         Reviewed by Kent Tamura.
2566
2567         [chromium] cleanup temp files left by Linux DRT
2568         https://bugs.webkit.org/show_bug.cgi?id=43062
2569
2570         * BuildSlaveSupport/build.webkit.org-config/config.json: Rename the chromium bots to include the OS
2571         * BuildSlaveSupport/build.webkit.org-config/master.cfg: add a step on chromium-linux to delete temp files left
2572             by crashed DRTs
2573
2574 2010-07-28  Antonio Gomes  <tonikitoo@webkit.org>
2575
2576         Rubber-stamped by Kenneth Christiansen.
2577
2578         More Developer menu items reordering.
2579
2580         Grouping related menu items together, visually and logically (in the code).
2581
2582         No behavior change.
2583
2584         * QtTestBrowser/main.cpp:
2585         (LauncherWindow::createChrome):
2586
2587 2010-07-27  Kinuko Yasuda  <kinuko@chromium.org>
2588
2589         Reviewed by Ojan Vafai.
2590
2591         Add FILE_SYSTEM build flag for FileSystem API
2592         https://bugs.webkit.org/show_bug.cgi?id=42915
2593
2594         * Scripts/build-webkit:
2595
2596 2010-07-27  Martin Robinson  <mrobinson@igalia.com>
2597
2598         Reviewed by David Levin.
2599
2600         Stylebot should not complain about NULL usage in calls to gdk_pixbuf_save_to
2601         https://bugs.webkit.org/show_bug.cgi?id=43090
2602
2603         * Scripts/webkitpy/style/checkers/cpp.py: Add exemption for some GdkPixbuf methods.
2604         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added some tests for this behavior.
2605
2606 2010-07-27  Kent Tamura  <tkent@chromium.org>
2607
2608         Unreviewed, trivial typo fix.
2609
2610         * Scripts/webkitpy/layout_tests/port/chromium.py:
2611           Fix a wrong method name committed by r64109.
2612
2613 2010-07-27  Sam Weinig  <sam@webkit.org>
2614
2615         Reviewed by Anders Carlsson.
2616
2617         Patch for https://bugs.webkit.org/show_bug.cgi?id=43087
2618         Clean up handling of strings at the WebKit2 API layer.
2619
2620         * MiniBrowser/mac/BrowserWindowController.m:
2621         (runJavaScriptAlert):
2622         (runJavaScriptConfirm):
2623         (runJavaScriptPrompt):
2624         (didNavigateWithNavigationData):
2625         (-[BrowserWindowController updateProvisionalURLForFrame:]):
2626         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2627         (_didClearWindowForFrame):
2628
2629 2010-07-27  Ojan Vafai  <ojan@chromium.org>
2630
2631         Reviewed by Eric Seidel.
2632
2633         webkit-patch post-commits is broken: AttributeError: Values instance has no attribute 'no_squash'
2634         https://bugs.webkit.org/show_bug.cgi?id=42984
2635
2636         squash and no_squash have been intentionally erroring for a couple weeks now.
2637         But post-commits was just broken. Just remove squash/no_squash.
2638
2639         * Scripts/webkitpy/tool/steps/abstractstep.py:
2640         * Scripts/webkitpy/tool/steps/options.py:
2641
2642 2010-07-27  Kevin Ollivier  <kevino@theolliviers.com>
2643
2644         [wx] Build fix after introduction of EXECUTABLE_ALLOCATOR_DEMAND.
2645
2646         * wx/build/settings.py:
2647
2648 2010-07-27  Adam Roben  <aroben@apple.com>
2649
2650         Mac build fix
2651
2652         * MiniBrowser/mac/BrowserWindowController.m:
2653         (processDidExit):
2654         (-[BrowserWindowController awakeFromNib]):
2655         Added processDidExit support.
2656
2657 2010-07-26  Antonio Gomes  <tonikitoo@webkit.org>
2658
2659         Rubber-stamped by Simon Hausmann.
2660
2661         [Qt] Reorder some items in Developers' menu so QGraphicsView one is easier accessible.
2662
2663         Move some less useful menu items on Developers menu from the top to the bottom, so
2664         QGraphicsView menu goes to the top, and becomes more quickly accessible.
2665
2666         * QtTestBrowser/main.cpp:
2667         (LauncherWindow::createChrome):
2668
2669 2010-07-26  Adam Roben  <aroben@apple.com>
2670
2671         Fix the path to InjectedBundle.dll in Debug_Internal builds
2672
2673         Fixes <http://webkit.org/b/42994> WebKitTestRunner fails to load
2674         InjectedBundle.dll in the Debug_Internal configuration
2675
2676         Reviewed by Anders Carlsson.
2677
2678         * WebKitTestRunner/win/TestControllerWin.cpp:
2679         (WTR::TestController::initializeInjectedBundlePath): Add the _debug
2680         suffix only in Debug_All builds.
2681
2682 2010-07-25  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2683
2684         Reviewed by Darin Adler.
2685
2686         https://bugs.webkit.org/show_bug.cgi?id=42947
2687         Check for WEBKIT_TESTFONTS for qt, gtk and windows port and throw 
2688         error. Without which dumpRenderTree crashes.
2689
2690         * Scripts/old-run-webkit-tests:
2691
2692 2010-07-27  Kent Tamura  <tkent@chromium.org>
2693
2694         Reviewed by Dimitri Glazkov.
2695
2696         https://bugs.webkit.org/show_bug.cgi?id=42956
2697         [DRT/Chromium] Fix "out of sync" assertion error
2698
2699         Fix an assertion error on Windows like the following:
2700         100721 20:16:46 chromium.py:386  CRITICAL Test got out of sync:
2701         |file:///c:/WebKitBuildSlave2/chromium-win-release-tests/build/LayoutTests/http/tests/local/blob/send-data-blob.html|
2702         |file:///C:/WebKitBuildSlave2/chromium-win-release-tests/build/LayoutTests/http/tests/local/blob/send-data-blob.html|
2703
2704         * Scripts/webkitpy/layout_tests/port/chromium.py:
2705         If the url matches with "file:///[a-z]:", does case-ignore comparison.
2706         GURL capitalize the driver letter of a file: URL.
2707
2708 2010-07-26  Darin Adler  <darin@apple.com>
2709
2710         Reviewed by Sam Weinig.
2711
2712         WebKitTestRunner needs to support layoutTestController.counterValueForElementById
2713         https://bugs.webkit.org/show_bug.cgi?id=42537
2714
2715         WebKitTestRunner needs layoutTestController.markerTextForListItem
2716         https://bugs.webkit.org/show_bug.cgi?id=42549
2717
2718         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2719         Fixed _paramterExpression typo. Improved support for string type as a
2720         return value, so we don't try to include DOMString.h and we can convert
2721         the string to a JSValue by calling JSValueMakeStringOrNull.
2722
2723         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
2724         Added JSValueMakeStringOrNull, used by the code generator.
2725
2726         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2727         Added counterValueForElementById and markerTextForListItem.
2728
2729         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2730         Moved constant to the top of the file.
2731         (WTR::toCF): Added. Converts strings to CFStringRef.
2732         (WTR::toWK): Added. Converts strings to WKStringRef.
2733         (WTR::toJS): Added. Converts strings to JSStringRef.
2734         (WTR::setProperty): Moved this function to the top of the file
2735         rather than having it down where it's used inside the class. Also
2736         renamed it so it's a separate function rather than an overload of
2737         JSObjectSetProperty.
2738         (WTR::propertyValue): Copied this here from InjectedBundlePage.cpp.
2739         Should move it somewhere we can share it.
2740         (WTR::propertyObject): Ditto.
2741         (WTR::getElementById): Added. Calls getElementById through the magic
2742         of JavaScript.
2743         (WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId):
2744         Chagned to use toWK instead of four local variables.
2745         (WTR::LayoutTestController::counterValueForElementById): Added.
2746         Calls WKBundleFrameCopyCounterValue.
2747         (WTR::LayoutTestController::markerTextForListItem): Added.
2748         Calls WKBundleFrameCopyMarkerText.
2749
2750         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2751         Added counterValueForElementById and markerTextForListItem.
2752
2753 2010-07-26  Martin Robinson  <mrobinson@igalia.com>
2754
2755         Reviewed by Gustavo Noronha Silva.
2756
2757         [GTK] The EventSender should support simulating drop events
2758         https://bugs.webkit.org/show_bug.cgi?id=39844
2759
2760         Add initial dropping support to the GTK+ EventSender.
2761
2762         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2763         (createWebView): Listen for some new drag-and-drop signals.
2764         * DumpRenderTree/gtk/EventSender.cpp: Add currentDragSourceContext.
2765         (dispatchEvent):
2766         Detect situations where a drag is either starting or ending and massage
2767         GTK+ into sending the appropriate signals to the WebView.
2768         (replaySavedEvents): Remove comment.
2769         (makeEventSender): Clear the currentDragSourceContext when creating a new EventSender.
2770         (dragBeginCallback): Capture the new currentDragSourceContext when a drag begins.
2771         (dragEndCallback): Clear the currentDragSourceContext when a drag ends.
2772         (dragFailedCallback): Disable the GTK+ drag failed animation.
2773         * DumpRenderTree/gtk/EventSender.h: Add declarations for new signal callbacks.
2774
2775 2010-07-26  Daniel Bates  <dbates@rim.com>
2776
2777         Reviewed by Darin Adler.
2778
2779         svn-unapply warns of uninitialized variable when unapplying
2780         a patch that describes an svn move operation
2781         https://bugs.webkit.org/show_bug.cgi?id=42036
2782
2783         Fixes Perl uninitialized variable warnings when un-applying
2784         a patch that moves a file.
2785
2786         * Scripts/svn-unapply:
2787           - Modified patch() so that it initializes $patch to the empty
2788             string when we don't have svnConvertedText (such as when
2789             reversing a diff that represents a svn copy/move operation).
2790
2791 2010-07-26  Sam Weinig  <sam@webkit.org>
2792
2793         Reviewed by Anders Carlsson.
2794
2795         Move some non-APIish functions into private headers.
2796
2797         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2798         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2799
2800 2010-07-26  Sam Weinig  <sam@webkit.org>
2801
2802         Reviewed by Anders Carlsson.
2803
2804         Fix for https://bugs.webkit.org/show_bug.cgi?id=42986
2805         Add prompt and confirm client functions to WebKit2
2806
2807         * MiniBrowser/mac/BrowserWindowController.m:
2808         (-[BrowserWindowController awakeFromNib]):
2809
2810 2010-07-26  Adam Roben  <aroben@apple.com>
2811
2812         Windows build fix
2813
2814         * MiniBrowser/MiniBrowser.vcproj:
2815         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
2816         Removed empty attributes so the values will be picked up from the
2817         vsprops files. (Also removed a couple of attributes that accidentally
2818         duplicated values from the vsprops files.)
2819
2820 2010-07-26  Brian Weinstein  <bweinstein@apple.com>
2821
2822         Rubber-stamped by Adam Roben.
2823         
2824         Touch MiniBrowser's stdafx to fix the build.
2825
2826         * MiniBrowser/win/stdafx.h:
2827
2828 2010-07-26  Hayato Ito  <hayato@chromium.org>
2829
2830         Reviewed by Shinichiro Hamaji.
2831
2832         Add pretty printer of WTF::Vector for GDB 7.
2833
2834         https://bugs.webkit.org/show_bug.cgi?id=40909
2835
2836         * gdb/wtf.py: Added.
2837
2838 2010-07-26  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2839
2840         Reviewed by Simon Hausmann.
2841
2842         [Qt] Fix feature detection regexp
2843
2844         We were missing the last feature
2845
2846         * Scripts/webkitdirs.pm:
2847
2848 2010-07-25  Darin Adler  <darin@apple.com>
2849
2850         Reviewed by Dan Bernstein.
2851
2852         WebKitTestRunner needs to support layoutTestController.dumpSelectionRect
2853         https://bugs.webkit.org/show_bug.cgi?id=42326
2854
2855         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2856         Added dumpSelectionRect.
2857
2858         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2859         (WTR::LayoutTestController::dumpSelectionRect): Added. For now, this
2860         does nothing because its purpose is to change pixel test output and
2861         we do not have pixel tests implemented yet.
2862
2863 2010-07-25  Darin Adler  <darin@apple.com>
2864
2865         Reviewed by Maciej Stachowiak.
2866
2867         WebKitTestRunner needs to support layoutTestController.keepWebHistory
2868         https://bugs.webkit.org/show_bug.cgi?id=42323
2869
2870         Added keepWebHistory and computedStyleIncludingVisitedInfo.
2871
2872         Also fixed misspellings of the word "receive".
2873
2874         Also tweaked the names of some of the LayoutTestController members.
2875
2876         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2877         Added support for a type named "object" that is passed and returns as
2878         a JSValueRef.
2879
2880         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2881         Added keepWebHistory and computedStyleIncludingVisitedInfo. Also
2882         put setAcceptsEditing up nearer the top.
2883
2884         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2885         (WTR::InjectedBundle::_didReceiveMessage): Fixed mispellings of receive.
2886         (WTR::InjectedBundle::initialize): Ditto.
2887         (WTR::InjectedBundle::didReceiveMessage): Ditto.
2888         (WTR::InjectedBundle::reset): Reset the state of visited links between
2889         tests. Also eliminated the unused argument to the LayoutTestController
2890         create function.
2891         (WTR::InjectedBundle::setShouldTrackVisitedLinks): Added.
2892         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Ditto.
2893
2894         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2895         (WTR::InjectedBundlePage::shouldBeginEditing): Call shouldAllowEditing
2896         instead of acceptsEditing.
2897         (WTR::InjectedBundlePage::shouldEndEditing): Ditto.
2898         (WTR::InjectedBundlePage::shouldInsertNode): Ditto.
2899         (WTR::InjectedBundlePage::shouldInsertText): Ditto.
2900         (WTR::InjectedBundlePage::shouldDeleteRange): Ditto.
2901         (WTR::InjectedBundlePage::shouldChangeSelectedRange): Ditto.
2902         (WTR::InjectedBundlePage::shouldApplyStyle): Ditto.
2903
2904         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2905         (WTR::LayoutTestController::create): Removed uneeded argument.
2906         (WTR::LayoutTestController::LayoutTestController): Removed unneeded
2907         argument. Updated for rename of m_acceptsEditing to m_shouldAllowEditing.
2908         (WTR::LayoutTestController::numberOfActiveAnimations): Added some FIXMEs
2909         about the fact that this works on the main frame.
2910         (WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId): Ditto.
2911         (WTR::LayoutTestController::keepWebHistory): Added.
2912         (WTR::LayoutTestController::computedStyleIncludingVisitedInfo): Added.
2913         (WTR::JSObjectSetProperty): Added. Helper to make the function below
2914         cleaner.
2915         (WTR::LayoutTestController::makeWindowObject): Changed to use the
2916         overload of JSObjectSetProperty above.
2917
2918         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Changes to
2919         match above.
2920
2921         * WebKitTestRunner/TestController.cpp:
2922         (WTR::TestController::initialize): Fixed mispellings of receive.
2923         (WTR::TestController::_didReceiveMessageFromInjectedBundle): Ditto.
2924         (WTR::TestController::didReceiveMessageFromInjectedBundle): Ditto.
2925         * WebKitTestRunner/TestController.h: Ditto.
2926         * WebKitTestRunner/TestInvocation.cpp:
2927         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Ditto.
2928         * WebKitTestRunner/TestInvocation.h: Ditto.
2929
2930 2010-07-25  Alexey Proskuryakov  <ap@apple.com>
2931
2932         Reviewed by Sam Weinig.
2933
2934         https://bugs.webkit.org/show_bug.cgi?id=42193
2935         Support layoutTestController.dumpEditingDelegates in WebKitTestRunner
2936
2937         Step 2 - add the rest of editing delegates.
2938
2939         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2940         (WTR::operator<<): Fixed to not crash when range is null.
2941         (WTR::InjectedBundlePage::InjectedBundlePage):
2942         (WTR::InjectedBundlePage::_shouldEndEditing):
2943         (WTR::InjectedBundlePage::_shouldInsertNode):
2944         (WTR::InjectedBundlePage::_shouldInsertText):
2945         (WTR::InjectedBundlePage::_shouldDeleteRange):
2946         (WTR::InjectedBundlePage::_shouldChangeSelectedRange):
2947         (WTR::InjectedBundlePage::_shouldApplyStyle):
2948         (WTR::InjectedBundlePage::_didBeginEditing):
2949         (WTR::InjectedBundlePage::_didEndEditing):
2950         (WTR::InjectedBundlePage::_didChange):
2951         (WTR::InjectedBundlePage::_didChangeSelection):
2952         (WTR::InjectedBundlePage::shouldEndEditing):
2953         (WTR::InjectedBundlePage::shouldInsertNode):
2954         (WTR::InjectedBundlePage::shouldInsertText):
2955         (WTR::InjectedBundlePage::shouldDeleteRange):
2956         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
2957         (WTR::InjectedBundlePage::shouldApplyStyle):
2958         (WTR::InjectedBundlePage::didBeginEditing):
2959         (WTR::InjectedBundlePage::didEndEditing):
2960         (WTR::InjectedBundlePage::didChange):
2961         (WTR::InjectedBundlePage::didChangeSelection):
2962         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2963
2964 2010-07-24  Chris Fleizach  <cfleizach@apple.com>
2965
2966         Reviewed by David Kilzer.
2967
2968         AX: need a layout test testing misspelled words in attributed strings
2969         https://bugs.webkit.org/show_bug.cgi?id=42899
2970
2971         * DumpRenderTree/AccessibilityUIElement.cpp:
2972         (attributedStringForRangeCallback):
2973         (attributedStringRangeIsMisspelledCallback):
2974         (AccessibilityUIElement::getJSClass):
2975         * DumpRenderTree/AccessibilityUIElement.h:
2976         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2977         (AccessibilityUIElement::attributedStringForRange):
2978         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
2979         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2980         (AccessibilityUIElement::attributedStringForRange):
2981         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
2982         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2983         (AccessibilityUIElement::attributedStringForRange):
2984         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
2985
2986 2010-07-23  David Kilzer  <ddkilzer@apple.com>
2987
2988         <http://webkit.org/b/42911> Update ruby tools to work with shallow framework bundles
2989
2990         Reviewed by Mark Rowe.
2991
2992         * Scripts/check-for-inappropriate-files-in-framework: Added
2993         check for the SHALLOW_BUNDLE environment variable so that the
2994         script will work with iOS WebKit builds.
2995         * Scripts/check-for-webkit-framework-include-consistency: Ditto.
2996
2997 2010-07-22  Darin Adler  <darin@apple.com>
2998
2999         Reviewed by Sam Weinig.
3000
3001         Eliminate unneeded WKBundleFrameCopyInnerText function from WebKit2
3002         https://bugs.webkit.org/show_bug.cgi?id=42847
3003
3004         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3005         (WTR::operator<<): Replaced the WKStringToUTF8 function with
3006         a set of overloaded stream operators.
3007         (WTR::dumpPath): Changed to use ostringstream and return a string.
3008         (WTR::propertyValue): Added.
3009         (WTR::propertyObject): Added.
3010         (WTR::propertyString): Added.
3011         (WTR::numericWindowPropertyValue): Changed to call propertyValue.
3012         (WTR::dumpFrameScrollPosition): Removed now unneeded WKStringToUTF8 sequence
3013         since we now have suitable streaming functions.
3014         (WTR::dumpFrameText): Use propertyObject and propertyString instead of
3015         WKBundleFrameCopyInnerText.
3016         (WTR::dumpDescendantFramesText): Removed now unneeded WKStringToUTF8 sequence
3017         since we now have suitable streaming functions.
3018         (WTR::InjectedBundlePage::dump): Ditto.
3019         (WTR::InjectedBundlePage::willAddMessageToConsole): Ditto.
3020         (WTR::InjectedBundlePage::willSetStatusbarText): Ditto.
3021         (WTR::InjectedBundlePage::willRunJavaScriptAlert): Ditto.
3022         (WTR::InjectedBundlePage::willRunJavaScriptConfirm): Ditto.
3023         (WTR::InjectedBundlePage::willRunJavaScriptPrompt): Ditto.
3024
3025 2010-07-22  Alexey Proskuryakov  <ap@apple.com>
3026
3027         Reviewed by Sam Weinig and Darin Adler.
3028
3029         https://bugs.webkit.org/show_bug.cgi?id=42193
3030         Support layoutTestController.dumpEditingDelegates in WebKitTestRunner
3031
3032         Step 1: Add the method, and implement one actual delegate call as proof of concept. No tests
3033         fixed, but this makes difference one line smaller on many editing tests.
3034
3035         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3036         Added dumpEditingCallbacks() and setAcceptsEditing().
3037
3038         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3039         (WTR::dumpPath): Dump path to a node in a format that's compatible with DumpRenderTree.
3040         (WTR::operator<<): Print a range.
3041         (WTR::InjectedBundlePage::InjectedBundlePage): Set editor client in addition to existing
3042         clients.
3043         (WTR::InjectedBundlePage::_shouldBeginEditing): The only client method implemented so far.
3044         (WTR::InjectedBundlePage::shouldBeginEditing): Ditto.
3045         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added a section for editor client
3046         calls.
3047
3048         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3049         (WTR::LayoutTestController::LayoutTestController):
3050         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3051         (WTR::LayoutTestController::dumpEditingCallbacks):
3052         (WTR::LayoutTestController::setAcceptsEditing):
3053         (WTR::LayoutTestController::acceptsEditing):
3054         (WTR::LayoutTestController::shouldDumpEditingCallbacks):
3055         Store m_acceptsEditing and m_dumpEditingCallbacks.
3056
3057 2010-07-22  Yael Aharon  <yael.aharon@nokia.com>
3058
3059         Reviewed by Laszlo Gombos.
3060
3061         [Qt] QtWebKit needs public API for Notifications.
3062         https://bugs.webkit.org/show_bug.cgi?id=41413
3063
3064         Update DumpRenderTree and QtTestBrowser to use the new API.
3065         Add new DRT API to flag that notifications permission requests should be ignored.
3066
3067         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3068         (WebCore::WebPage::WebPage):
3069         (WebCore::WebPage::requestPermission):
3070         (WebCore::WebPage::checkPermission):
3071         (WebCore::WebPage::cancelRequestsForPermission):
3072         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3073         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3074         (LayoutTestController::reset):
3075         (LayoutTestController::ignoreDesktopNotificationPermissionRequests):
3076         (LayoutTestController::checkDesktopNotificationPermission):
3077         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3078         (LayoutTestController::ignoreReqestForPermission):
3079         * QtTestBrowser/main.cpp:
3080         (LauncherWindow::LauncherWindow):
3081         * QtTestBrowser/webpage.cpp:
3082         (WebPage::WebPage):
3083         (WebPage::requestPermission):
3084         (WebPage::checkPermission):
3085         (WebPage::cancelRequestsForPermission):
3086         * QtTestBrowser/webpage.h:
3087
3088 2010-07-22  Darin Adler  <darin@apple.com>
3089
3090         Reviewed by Sam Weinig.
3091
3092         WebKitTestRunner needs to support layoutTestController.dumpChildFramesAsText
3093         https://bugs.webkit.org/show_bug.cgi?id=42325
3094
3095         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3096         Added dumpChildFramesAsText.
3097
3098         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3099         (WTR::dumpFrameText): Added.
3100         (WTR::dumpDescendantFramesText): Added.
3101         (WTR::InjectedBundlePage::dumpAllFramesText): Added.
3102         (WTR::InjectedBundlePage::dump): Changed to use the new whatToDump function
3103         instead of the shouldDumpAsText function, and added a case for AllFramesText.
3104
3105         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added dumpAllFramesText.
3106
3107         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3108         (WTR::LayoutTestController::LayoutTestController): Replaced m_dumpAsText with
3109         m_whatToDump.
3110
3111         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added
3112         dumpChildFramesAsText. Removed shouldDumpAsText, shouldDumpDOMAsWebArchive,
3113         and shouldDumpSourceAsWebArchive. Added whatToDump.
3114
3115 2010-07-22  Adam Roben  <aroben@apple.com>
3116
3117         Windows build fix
3118
3119         Inspired by r63881.
3120
3121         * MiniBrowser/MiniBrowser.vcproj:
3122         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
3123         Removed pre- and post-build events so they will be inherited from the
3124         vsprops files.
3125
3126 2010-07-21  Darin Adler  <darin@apple.com>
3127
3128         Reviewed by Sam Weinig.
3129
3130         WebKitTestRunner needs layoutTestController.dumpChildFrameScrollPositions
3131         https://bugs.webkit.org/show_bug.cgi?id=42548
3132
3133         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3134         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3135         (WTR::numericWindowPropertyValue): Renamed this and moved it up higher in the file.
3136         (WTR::dumpFrameScrollPosition): Added argument telling whether to dump the frame name.
3137         Changed to a file-internal function instead of a member function.
3138         (WTR::dumpDescendantFrameScrollPositions): Added.
3139         (WTR::InjectedBundlePage::dumpAllFrameScrollPositions): Added.
3140         (WTR::InjectedBundlePage::dump): Changed to call dumpAllFrameScrollPositions when
3141         appropriate. Also streamlined all the WKStringToUTF8 call sites.
3142         (WTR::InjectedBundlePage::willAddMessageToConsole): Streamlined use of WKStringToUTF8.
3143         (WTR::InjectedBundlePage::willSetStatusbarText): Ditto.
3144         (WTR::InjectedBundlePage::willRunJavaScriptAlert): Ditto.
3145         (WTR::InjectedBundlePage::willRunJavaScriptConfirm): Ditto.
3146         (WTR::InjectedBundlePage::willRunJavaScriptPrompt): Ditto.
3147
3148         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Updated for above changes.
3149
3150         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3151         (WTR::LayoutTestController::LayoutTestController): Initialize
3152         m_shouldDumpAllFrameScrollPositions.
3153         (WTR::LayoutTestController::shouldDumpMainFrameScrollPosition): Renamed from
3154         shouldDumpFrameScrollPositions.
3155
3156         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Reorganized the file a
3157         bit, added dumpChildFrameScrollPositions and shouldDumpAllFrameScrollPositions,
3158         and renamed shouldDumpFrameScrollPositions to shouldDumpMainFrameScrollPosition.
3159
3160 2010-07-21  Darin Adler  <darin@apple.com>
3161
3162         Reviewed by Sam Weinig.
3163
3164         WebKitTestRunner needs to support dumping of scroll position
3165         https://bugs.webkit.org/show_bug.cgi?id=42514
3166
3167         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3168         (_didClearWindowForFrame): Use JSGlobalContextRef instead of JSContextRef.
3169
3170         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3171         (WTR::InjectedBundlePage::_didClearWindowForFrame): Use JSGlobalContextRef
3172         instead of JSContextRef.
3173         (WTR::InjectedBundlePage::dump): Call dumpFrameScrollPosition when appropriate.
3174         (WTR::numericWindowProperty): Added. Helper for dumpFrameScrollPosition.
3175         (WTR::InjectedBundlePage::dumpFrameScrollPosition): Added.
3176         (WTR::InjectedBundlePage::didClearWindowForFrame): Use JSGlobalContextRef
3177         instead of JSContextRef.
3178
3179         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Removed names from
3180         arguments that simply repeat the argument type. Added dumpFrameScrollPosition.
3181
3182         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3183         (WTR::LayoutTestController::shouldDumpDOMAsWebArchive): Added. Currently
3184         returns false.
3185         (WTR::LayoutTestController::shouldDumpSourceAsWebArchive): Added. Currently
3186         returns false.
3187         (WTR::LayoutTestController::shouldDumpFrameScrollPositions): Added. Matches
3188         the logic in DumpRenderTree.
3189
3190         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Updated for above changes.
3191
3192         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Added property svn:ignore.
3193
3194 2010-07-21  Kevin Ollivier  <kevino@theolliviers.com>
3195
3196         [wx] Build fix, adding the WebCore/bindings/generic dir to the list of build dirs.
3197
3198         * wx/build/settings.py:
3199
3200 2010-07-21  Sam Weinig  <sam@webkit.org>
3201
3202         Reviewed by Anders Carlsson.
3203
3204         Patch for https://bugs.webkit.org/show_bug.cgi?id=42539
3205         WebKitTestRunner needs to support printing ALERT, PROMPT and CONFIRM messages
3206
3207         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3208         (WTR::InjectedBundlePage::InjectedBundlePage):
3209         (WTR::InjectedBundlePage::_willAddMessageToConsole):
3210         (WTR::InjectedBundlePage::_willSetStatusbarText):
3211         (WTR::InjectedBundlePage::_willRunJavaScriptAlert):
3212         (WTR::InjectedBundlePage::_willRunJavaScriptConfirm):
3213         (WTR::InjectedBundlePage::_willRunJavaScriptPrompt):
3214         (WTR::InjectedBundlePage::willAddMessageToConsole):
3215         (WTR::InjectedBundlePage::willSetStatusbarText):
3216         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
3217         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
3218         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
3219         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3220
3221 2010-07-21  Adam Roben  <aroben@apple.com>
3222
3223         Give InjectedBundle our standard set of configurations (minus the
3224         *_Cairo variants)
3225
3226         InjectedBundle's Debug_All configuration was the same as is Debug
3227         configuration, and it was missing a Debug_Internal configuration.
3228
3229         Fixes <http://webkit.org/b/42749> InjectedBundle's build
3230         configurations are screwy
3231
3232         Reviewed by Darin Adler.
3233
3234         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: Added
3235         debug_internal.vsprops and debug_all.vsprops to the Debug_All
3236         configuration. Added a Debug_Internal configuration.
3237
3238         * WebKitTestRunner/WebKitTestRunner.sln: Build the Debug_Internal
3239         variant of InjectedBundle when we're using the Debug_Internal solution
3240         configuration.
3241
3242 2010-07-21  Adam Roben  <aroben@apple.com>
3243
3244         Move InjectedBundle's settings to a vsprops file
3245
3246         This will make it easier to change settings for all configurations,
3247         and to add new configurations.
3248
3249         Fixes <http://webkit.org/b/42748> InjectedBundle should use vsprops
3250         files
3251
3252         Reviewed by Darin Adler.
3253
3254         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added.
3255         Moved settings here...
3256         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: ...from
3257         here.
3258
3259 2010-07-21  Adam Roben  <aroben@apple.com>
3260
3261         Give MiniBrowser our standard set of configurations (minus the *_Cairo
3262         variants)
3263
3264         MiniBrowser already had a configuration called "Release", but it was
3265         using mostly the same settings as Debug. And its Debug configuration
3266         was using the settings that Debug_Internal should be using.
3267
3268         Fixes <http://webkit.org/b/42746> MiniBrowser's build configurations
3269         are screwy
3270
3271         Reviewed by Darin Adler.
3272
3273         * MiniBrowser/MiniBrowser.vcproj: Removed debug_internal.vsprops from
3274         the Debug configuration. Remove debug.vsprops and
3275         debug_internal.vsprops from the Release configuration and replace them
3276         with release.vsprops. Added Debug_Internal and Debug_All
3277         configurations.
3278
3279 2010-07-21  Adam Roben  <aroben@apple.com>
3280
3281         Move MiniBrowser's settings to a vsprops file
3282
3283         This will make it easier to change settings for all configurations,
3284         and to add new configurations.
3285
3286         MiniBrowser should use vsprops files
3287         https://bugs.webkit.org/show_bug.cgi?id=42745
3288
3289         Reviewed by Darin Adler.
3290
3291         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added. Moved
3292         settings here...
3293         * MiniBrowser/MiniBrowser.vcproj: ...from here.
3294
3295 2010-07-21  Adam Roben  <aroben@apple.com>
3296
3297         Fix compiler warnings when building MiniBrowser
3298
3299         Also cleaned up the .vcproj a bit.
3300
3301         Fixes <http://webkit.org/b/42743>.
3302
3303         Reviewed by Darin Adler.
3304
3305         * MiniBrowser/MiniBrowser.vcproj: Removed all settings that are
3306         already defined in .vsprops files. This also fixes a warning about
3307         /EDITANDCONTINUE being incompatible with /SAFESEH.
3308
3309         * MiniBrowser/win/MiniBrowser.rc: Replaced afxres.h with winresrc.h so
3310         that we stop getting warnings about ID_FILE_OPEN and ID_FILE_CLOSE
3311         being redefined. (I think this will also get us closer to building
3312         with VC++ Express.)
3313
3314 2010-07-20  Sam Weinig  <sam@webkit.org>
3315
3316         Reviewed by Jon Honeycutt.
3317
3318         Fix obvious typo.
3319
3320         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3321         (WTR::InjectedBundlePage::setStatusbarText): Need to call ->data() to actually get the string value.
3322
3323 2010-07-20  Tony Chang  <tony@chromium.org>
3324
3325         Reviewed by Kent Tamura.
3326
3327         [chromium] by default, dumpAsText should disable pixel results
3328         https://bugs.webkit.org/show_bug.cgi?id=42715
3329
3330         * DumpRenderTree/chromium/LayoutTestController.cpp:
3331         (LayoutTestController::dumpAsText): disable pixel results, but allow JS to override
3332
3333 2010-07-20  Adam Roben  <aroben@apple.com>
3334
3335         Windows build fix
3336
3337         * MiniBrowser/MiniBrowser.vcproj: Link against the new, shiny
3338         WebKit.lib instead of the old, dusty WebKit2.lib.
3339
3340 2010-07-20  Adam Roben  <aroben@apple.com>
3341
3342         Stop linking WebKitTestRunner against getopt
3343
3344         Use of getopt was removed in r63700.
3345
3346         Fixes <http://webkit.org/b/42714> WebKitTestRunner links against
3347         getopt, but doesn't need to
3348
3349         Reviewed by Sam Weinig.
3350
3351         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Removed getopt.lib
3352         from all configurations.
3353
3354 2010-07-20  Adam Roben  <aroben@apple.com>
3355
3356         Make run-webkit-tests --webkit-test-runner "work" on Windows
3357
3358         WebKitTestRunner crashes on launch, but at least the scripts build and
3359         launch it!
3360
3361         Fixes <http://webkit.org/b/42709> run-webkit-tests
3362         --webkit-test-runner bails with an error on Windows
3363
3364         Reviewed by Anders Carlsson.
3365
3366         * Scripts/build-webkittestrunner: Build WebKitTestRunner.sln on
3367         Windows.
3368         * WebKitTestRunner/WebKitTestRunner.sln: Added. Contains the following
3369         projects (from first-built to last-built): FindSafari, ImageDiff,
3370         InjectedBundleGenerated, InjectedBundle, WebKitTestRunner.
3371
3372 2010-07-20  Adam Roben  <aroben@apple.com>
3373
3374         Change build-webkit back to building WebKit.sln on Windows
3375
3376         WebKit.sln builds all the same projects as WebKit2.sln, and the latter
3377         is being removed.
3378
3379         Rubber-stamped in advance by Steve Falkenburg.
3380
3381         * Scripts/build-webkit:
3382
3383 2010-07-20  Adam Roben  <aroben@apple.com>
3384
3385         Windows build fix
3386
3387         * MiniBrowser/win/BrowserWindow.cpp: Added missing #include.
3388
3389 2010-07-20  Joseph Pecoraro  <joepeck@webkit.org>
3390
3391         Reviewed by Geoffrey Garen.
3392
3393         WebScriptObject Should Allow Safely Checking For Key Existence
3394         https://bugs.webkit.org/show_bug.cgi?id=42613
3395
3396         Normal ObjCController workflow for a WebScriptObject test.
3397
3398         * DumpRenderTree/mac/ObjCController.m:
3399         (+[ObjCController isSelectorExcludedFromWebScript:]):
3400         (+[ObjCController webScriptNameForSelector:]):
3401         (-[ObjCController testHasWebScriptKey:]):
3402
3403 2010-07-20  Chris Marrin  <cmarrin@apple.com>
3404
3405         Reviewed by Simon Fraser.
3406
3407         https://bugs.webkit.org/show_bug.cgi?id=42118
3408         Disable compositing/webgl tests if WebGL is not enabled
3409
3410         * Scripts/old-run-webkit-tests:
3411
3412 2010-07-20  Anton Muhin  <antonm@chromium.org>
3413
3414         Reviewed by Darin Adler.
3415
3416         Print additional information about exception if failed to connect to apache (in verbose mode).
3417         https://bugs.webkit.org/show_bug.cgi?id=42627
3418
3419         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
3420
3421 2010-07-20  Tony Chang  <tony@chromium.org>
3422
3423         Reviewed by David Levin.
3424
3425         [chromium] only pass --force to gclient sync if explicitly stated
3426         https://bugs.webkit.org/show_bug.cgi?id=42581
3427
3428         * BuildSlaveSupport/build.webkit.org-config/master.cfg: bots should
3429               always pass --force since it's hard to do manual cleanups
3430         * Scripts/update-webkit-chromium: only pass --force if --force is
3431               passed in
3432
3433 2010-07-19  Anders Carlsson  <andersca@apple.com>
3434
3435         Fix build.
3436
3437         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3438         Paths of generated files should be relative to the build product.
3439
3440 2010-07-19  Daniel Bates  <dbates@rim.com>
3441
3442         Reviewed by Adam Roben.
3443
3444         [Win] Implement LayoutTestController::markerTextForListItem()
3445         https://bugs.webkit.org/show_bug.cgi?id=37930
3446
3447         Implements DRT support for markerTextForListItem in the Windows port.
3448
3449         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3450         (LayoutTestController::markerTextForListItem): Implemented.
3451
3452 2010-07-19  Jessie Berlin  <jberlin@apple.com>
3453
3454         Windows build fix. Unreviewed.
3455
3456         * WebKitTestRunner/win/TestControllerWin.cpp:
3457         (WTR::TestController::initializeTestPluginPath):
3458
3459 2010-07-19  Sam Weinig  <sam@webkit.org>
3460
3461         Reviewed by Jon Honeycutt.
3462
3463         Remove dependency on getopt from WebKitTestRunner.
3464
3465         - Simplify options parsing and eliminate unused options.
3466
3467         * WebKitTestRunner/TestController.cpp:
3468         (WTR::TestController::TestController):
3469         (WTR::TestController::initialize):
3470         * WebKitTestRunner/TestController.h:
3471         (WTR::TestController::testPluginPath):
3472         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3473         * WebKitTestRunner/mac/TestControllerMac.mm:
3474         (WTR::TestController::platformInitialize):
3475         (WTR::TestController::initializeTestPluginPath):
3476         * WebKitTestRunner/win/TestControllerWin.cpp:
3477         (WTR::TestController::platformInitialize):
3478         (WTR::TestController::initializeTestPluginPath):
3479
3480 2010-07-19  Diego Gonzalez  <diegohcg@webkit.org>
3481
3482         Reviewed by Antonio Gomes.
3483
3484         [Qt] MiniBrowser: Progress indication at address bar
3485         https://bugs.webkit.org/show_bug.cgi?id=42565
3486
3487         Make possible to see load progress at address bar based on
3488         QtTestBrowser solution
3489
3490         * MiniBrowser/qt/BrowserWindow.cpp:
3491         (BrowserWindow::BrowserWindow):
3492         (BrowserWindow::loadProgress):
3493         * MiniBrowser/qt/BrowserWindow.h:
3494
3495 2010-07-19  Diego Gonzalez  <diegohcg@webkit.org>
3496
3497         Reviewed by Antonio Gomes.
3498
3499         [Qt] Add MiniBrowser features: urlChanged, titleChanged and from user input load
3500         https://bugs.webkit.org/show_bug.cgi?id=42564
3501
3502         * MiniBrowser/qt/BrowserWindow.cpp:
3503         (BrowserView::load):
3504         (BrowserWindow::BrowserWindow):
3505         (BrowserWindow::titleChanged):
3506         (BrowserWindow::urlChanged):
3507         * MiniBrowser/qt/BrowserWindow.h:
3508
3509 2010-07-19  Sam Weinig  <weinig@apple.com>
3510
3511         Reviewed by Adam Roben.
3512
3513         Patch for https://bugs.webkit.org/show_bug.cgi?id=42532
3514         Auto-generate the JS bindings for WebKitTestRunner's script objects.
3515
3516         * WebKitTestRunner/Configurations/Base.xcconfig:
3517         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3518         * WebKitTestRunner/DerivedSources.make: Added.
3519         * WebKitTestRunner/ForwardingHeaders/wtf/GetPtr.h: Added.
3520         * WebKitTestRunner/InjectedBundle/Bindings: Added.
3521         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Added.
3522         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h: Added.
3523         (WTR::JSWrappable::~JSWrappable):
3524         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp: Added.
3525         (WTR::JSWrapper::wrap):
3526         (WTR::JSWrapper::unwrap):
3527         (WTR::unwrapObject):
3528         (WTR::JSWrapper::initialize):
3529         (WTR::JSWrapper::finalize):
3530         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h: Added.
3531         (WTR::toJS):
3532         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added.
3533         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3534         (WTR::InjectedBundlePage::dump):
3535         (WTR::InjectedBundlePage::setStatusbarText):
3536         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3537         (WTR::LayoutTestController::wrapperClass):
3538         (WTR::LayoutTestController::waitUntilDone):
3539         (WTR::LayoutTestController::makeWindowObject):
3540         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3541         (WTR::LayoutTestController::shouldDumpAsText):
3542         (WTR::LayoutTestController::dumpAsText):
3543         (WTR::LayoutTestController::shouldDumpStatusCallbacks):
3544         (WTR::LayoutTestController::dumpStatusCallbacks):
3545         (WTR::LayoutTestController::waitToDump):
3546         (WTR::LayoutTestController::testRepaint):
3547         (WTR::LayoutTestController::repaintSweepHorizontally):
3548         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
3549         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3550         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added.
3551         * WebKitTestRunner/win/build-generated-files.sh: Added.
3552
3553 2010-07-19  Mark Rowe  <mrowe@apple.com>
3554
3555         Clean up the buildbot configuration a little.
3556
3557         * BuildSlaveSupport/build.webkit.org-config/config.json:
3558
3559 2010-07-19  Chris Marrin  <cmarrin@apple.com>
3560
3561         Reviewed by Darin Adler.
3562
3563         https://bugs.webkit.org/show_bug.cgi?id=42118
3564         Disable WebGL on Leopard for now. 
3565
3566         LayoutTests fail on some graphics hardware on Leopard because one of the features we use,
3567         GL_ARB_framebuffer_object, is not universally available in Leopard like it is in
3568         SnowLeopard. This will allow LayoutTests to pass on Leopard until we add logic to use a
3569         software OpenGL driver on machines without this support.
3570
3571         * Scripts/build-webkit:
3572
3573 2010-07-19  Simon Fraser  <simon.fraser@apple.com>
3574
3575         Reviewed by Brady Eidson.
3576
3577         Fix MiniBrowser to update URL as you browse
3578         https://bugs.webkit.org/show_bug.cgi?id=42591
3579         
3580         Hook up various loading notifications to update the URL bar in MiniBrowser.
3581
3582         * MiniBrowser/mac/BrowserWindowController.m:
3583         (_didStartProvisionalLoadForFrame):
3584         (_didReceiveServerRedirectForProvisionalLoadForFrame):
3585         (_didFailProvisionalLoadWithErrorForFrame):
3586         (_didCommitLoadForFrame):
3587         (_didFailLoadWithErrorForFrame):
3588         (-[BrowserWindowController updateProvisionalURLForFrame:]):
3589         (-[BrowserWindowController didStartProvisionalLoadForFrame:]):
3590         (-[BrowserWindowController didReceiveServerRedirectForProvisionalLoadForFrame:]):
3591         (-[BrowserWindowController didFailProvisionalLoadWithErrorForFrame:]):
3592         (-[BrowserWindowController didFailLoadWithErrorForFrame:]):
3593         (-[BrowserWindowController didCommitLoadForFrame:]):
3594
3595 2010-07-19  Alexey Proskuryakov  <ap@apple.com>
3596
3597         Reviewed by Darin Adler.
3598
3599         https://bugs.webkit.org/show_bug.cgi?id=42586
3600         Log all canceled authentication attempts in DumpRenderTree
3601
3602         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3603         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
3604         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3605         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
3606         It's important to know whether an auth shee