8b25bd0a28ee2d6b81f9bb1afab3d09a97963928
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-03-02  Dirk Pranke  <dpranke@chromium.org>
2
3         Reviewed by David Levin.
4
5         Revert r55339 - the Chromium codebase downstream had a temporary
6         need for WebKitTools/pywebsocket to still exist after Chris Jerdonek
7         had moved it (scripts still referenced the old location). Those
8         scripts have been updated to the new location, so it should be safe
9         to delete this now.
10
11         https://bugs.webkit.org/show_bug.cgi?id=35614
12
13         * pywebsocket/mod_pywebsocket/standalone.py: Removed.
14
15 2010-03-02  Dirk Pranke  <dpranke@chromium.org>
16
17         Reviewed by Dimitri Glazkov.
18
19         new-run-webkit-tests on chromium-linux tests to see if
20         layout_test_helper exists, but we don't use layout_test_helper on
21         linux. The test derefences a None object, and we crash. This fixes
22         that.
23
24         https://bugs.webkit.org/show_bug.cgi?id=35602
25
26         * Scripts/webkitpy/layout_tests/port/chromium.py:
27
28  2010-03-02  Dirk Pranke  <dpranke@chromium.org>
29
30         Reviewed by Dimitri Glazkov.
31
32         r55388 (bug 35553) worked around a bug in Python's subprocess.Popen()
33         that was causing DRT to hang on exit in new-run-webkit-tests.
34         Unfortunately, that workaround doesn't work on chromium-win
35         (and the script fails completely). The good news is that the check
36         isn't actually necessary, and so this change makes it conditional.
37
38         https://bugs.webkit.org/show_bug.cgi?id=35601
39
40         * Scripts/webkitpy/layout_tests/port/chromium.py:
41
42 2010-03-02  Mark Rowe  <mrowe@apple.com>
43
44         Reviewed by Darin Adler.
45
46         Bug 35576: WebKit should tell plug-in instances when private browsing state changes
47         <http://webkit.org/b/35576>
48
49         TestNetscapePlugin is another bit of plug-in code where copy-paste was heavily used
50         when porting.  Update the Windows and UNIX implementations of NPP_New and NPP_SetValue
51         to provide the expected behavior related to NPNVprivateModeBool.  Hopefully this code
52         duplication can be cleaned up in the future.
53
54         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
55         (webkit_test_plugin_new_instance):
56         (webkit_test_plugin_set_value):
57         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
58         (NPP_New):
59         (NPP_SetValue):
60
61 2010-03-02  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
62
63         Reviewed by Alexey Proskuryakov.
64
65         Test plugin still has issues with releasing objects, and variants
66         https://bugs.webkit.org/show_bug.cgi?id=35587
67
68         Fix the conditions for releasing the variants after calling
69         invoke, and avoid having a number of objects leak.
70
71         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
72         (testDocumentOpen):
73         (testWindowOpen):
74
75 2010-03-02  Chris Jerdonek  <cjerdonek@webkit.org>
76
77         Reviewed by Shinichiro Hamaji.
78
79         Refactored the StyleChecker class's file-processing method
80         _process_file().  This will make it easier to add new
81         file-processing capabilities to check-webkit-style.
82
83         https://bugs.webkit.org/show_bug.cgi?id=35490
84
85         * Scripts/webkitpy/style/checker.py:
86           - Added a _read_lines() method to the StyleChecker class
87             that extracts the lines from a file.
88           - Replaced part of _process_file() with a call to the new
89             _read_lines() method.
90           - Replaced another part of _process_file() with a call
91             to the new CarriageReturnProcessor.process() method.
92
93         * Scripts/webkitpy/style/processors/common.py:
94           - Replaced the check_no_carriage_return() function with a
95             new CarriageReturnProcessor class.
96
97         * Scripts/webkitpy/style/processors/common_unittest.py:
98           - Renamed the CarriageReturnTest class to
99             CarriageReturnProcessorTest and updated it as necessary.
100
101 2010-03-02  Chris Jerdonek  <cjerdonek@webkit.org>
102
103         Reviewed by Shinichiro Hamaji.
104
105         Started using the logging module in check-webkit-style.
106         This provides more options for debugging and a more flexible,
107         uniform way to report messages to the end-user.
108
109         https://bugs.webkit.org/show_bug.cgi?id=35484
110
111         Also included classes in a central location to facilitate
112         the unit testing of logging code (setUp and tearDown of unit
113         test logging configurations, etc).
114
115         * Scripts/check-webkit-style:
116           - Added a call to configure_logging() in the beginning of main().
117           - Replaced two calls to sys.stderr.write() with appropriate
118             logging calls.
119
120         * Scripts/webkitpy/init/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py.
121
122         * Scripts/webkitpy/init/logtesting.py: Added.
123           - Added a UnitTestLogStream class to capture log output
124             during unit tests.
125           - Added a UnitTestLog class that provides convenience methods
126             for unit-testing logging code.
127
128         * Scripts/webkitpy/style/checker.py:
129           - Added a configure_logging() method.
130           - Added a _LevelLoggingFilter class to filter out log messages
131             above a certain logging level.
132           - Removed the _stderr_write() method from the StyleChecker class
133             and replaced its use with appropriate logging calls.
134
135         * Scripts/webkitpy/style/checker_unittest.py:
136           - Added a ConfigureLoggingTest class to unit test the
137             configure_logging() method.
138           - Updated the StyleCheckerCheckFileTest class as necessary.
139
140         * Scripts/webkitpy/style_references.py:
141           - Added references to logtesting.UnitTestLog and
142             logtesting.UnitTestLogStream.
143
144 2010-03-01  Chris Fleizach  <cfleizach@apple.com>
145
146         Fixing broken DRT on Leopard/Tiger. Second try.
147
148         AX: changes to WAI-ARIA grid aren't perceived correctly by VoiceOver
149         https://bugs.webkit.org/show_bug.cgi?id=35514
150
151         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
152
153 2010-03-01  Chris Fleizach  <cfleizach@apple.com>
154
155         Fixing broken DRT on Leopard/Tiger.
156
157         AX: changes to WAI-ARIA grid aren't perceived correctly by VoiceOver
158         https://bugs.webkit.org/show_bug.cgi?id=35514
159
160         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
161
162 2010-03-01  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
163
164         Reviewed by Eric Seidel.
165
166         [GTK] plugins/setProperty.html fails on 64bit Release
167         https://bugs.webkit.org/show_bug.cgi?id=35425
168
169         Check invoke's return code before releasing the variant, since
170         there's a chance it won't be properly initialized, leading to
171         memory corruption, in some cases.
172
173         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
174         (testCallback):
175         (testEnumerate):
176         (testDocumentOpen):
177         (testWindowOpen):
178         (handleCallback):
179
180 2010-03-01  Dirk Pranke  <dpranke@chromium.org>
181
182         Reviewed by nobody. Build bustage :(
183
184         Fix stupid typo that I committed even after David Levin pointed
185         it out to me :(
186
187         https://bugs.webkit.org/show_bug.cgi?id=35553
188
189         * Scripts/webkitpy/layout_tests/port/mac.py:
190
191 2010-03-01  Chris Fleizach  <cfleizach@apple.com>
192
193         Reviewed by Darin Adler.
194
195         AX: changes to WAI-ARIA grid aren't perceived correctly by VoiceOver
196         https://bugs.webkit.org/show_bug.cgi?id=35514
197
198         Add rowCount, columnCount for tables.
199
200         * DumpRenderTree/AccessibilityUIElement.cpp:
201         (rowCountCallback):
202         (columnCountCallback):
203         (AccessibilityUIElement::getJSClass):
204         * DumpRenderTree/AccessibilityUIElement.h:
205         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
206         (AccessibilityUIElement::rowCount):
207         (AccessibilityUIElement::columnCount):
208         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
209         (AccessibilityUIElement::rowCount):
210         (AccessibilityUIElement::columnCount):
211         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
212         (AccessibilityUIElement::rowCount):
213         (AccessibilityUIElement::columnCount):
214
215 2010-03-01  Dirk Pranke  <dpranke@chromium.org>
216
217         Reviewed by Eric Seidel.
218
219         Work around a bug in Python's subprocess.Popen() that keeps us from
220         cleaning up DumpRenderTree / test_shell properly when we finish the
221         tests in new-run-webkit-tests.
222
223         https://bugs.webkit.org/show_bug.cgi?id=35553
224
225         * Scripts/webkitpy/layout_tests/port/chromium.py:
226         * Scripts/webkitpy/layout_tests/port/mac.py:
227
228 2010-03-01  Arno Renevier  <arno@renevier.net>
229
230         Reviewed by Xan Lopez.
231
232         webkit-build could pass unknown arguments to autogen.sh
233         https://bugs.webkit.org/show_bug.cgi?id=35454
234
235         * Scripts/build-webkit:
236
237 2010-03-01  Dirk Pranke  <dpranke@chromium.org>
238
239         Rubber-stamped by Dimitri Glazkov.
240
241         Fix breakage from r55372.
242
243         https://bugs.webkit.org/show_bug.cgi?id=35549
244
245         * Scripts/webkitpy/layout_tests/port/chromium.py:
246
247 2010-03-01  Adam Barth  <abarth@webkit.org>
248
249         Reviewed by Eric Seidel.
250
251         EWS can hang for five hours when compile output is too big
252         https://bugs.webkit.org/show_bug.cgi?id=35545
253
254         * Scripts/webkitpy/commands/queues.py: Limit uploads to 1MB instead of
255         5MB.  AppEngine seems to not like 5MB uploads.  I'm not sure what the
256         limit is.  Let's try 1MB for a while and see how it goes.
257         * Scripts/webkitpy/networktransaction.py: Tune the default parameters
258         to our exponential backoff.  I'm not sure why I picked five hours as
259         the retry limit.  That seems way too large.
260
261 2010-03-01  Brady Eidson  <beidson@apple.com>
262
263         Reviewed by Sam Weinig.
264
265         REGRESSION: Telling a WebView to go to its current WebHistoryItem is broken.
266         <rdar://problem/7699371> and https://bugs.webkit.org/show_bug.cgi?id=35532
267
268         * DumpRenderTree/LayoutTestController.cpp:
269         (apiTestGoToCurrentBackForwardItemCallback):
270         (LayoutTestController::staticFunctions):
271         * DumpRenderTree/LayoutTestController.h:
272         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
273         (LayoutTestController::apiTestGoToCurrentBackForwardItem):
274
275         Stubs for now:
276         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
277         (LayoutTestController::apiTestGoToCurrentBackForwardItem):
278         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
279         (LayoutTestController::apiTestGoToCurrentBackForwardItem):
280         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
281         (LayoutTestController::apiTestGoToCurrentBackForwardItem):
282
283 2010-03-01  Dirk Pranke  <dpranke@chromium.org>
284
285         Reviewed by David Levin.
286
287         General cleanup of error handling in new-run-webkit-tests.
288
289         Add Port.check_build() call that is separate from Port.check_sys_deps()
290         (and add a --nocheck-build flag to skip). This breaks a circular
291         dependency where you would start the layout test helper before
292         checking sys deps, but checking sys deps was the thing that told
293         you if your binaries where there.
294
295         Also, made Port.check_sys_deps(), start_helper() and stop_helper()
296         optional by providing default implementations in the base class
297         rather than requiring ports to implement the routines regardless
298         of whether or not they were needed.
299
300         Lastly, tweak a bunch of log messages to be cleaner, including
301         changing messages in thirdparty/autoinstall.py to be silent at
302         the default log level.
303
304         http://bugs.webkit.org/show_bug.cgi?id=35416
305
306         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
307         * Scripts/webkitpy/layout_tests/port/base.py:
308         * Scripts/webkitpy/layout_tests/port/chromium.py:
309         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
310         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
311         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
312         * Scripts/webkitpy/layout_tests/port/mac.py:
313         * Scripts/webkitpy/layout_tests/port/passing.py:
314         * Scripts/webkitpy/layout_tests/port/test.py:
315         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
316         * Scripts/webkitpy/thirdparty/autoinstall.py
317
318 2010-03-01  Dirk Pranke <dpranke@chromium.org>
319
320          Reviewed by David Levin.
321
322          new-chromium-webkit-tests --platform=mac-leopard diffs are backwards
323          https://bugs.webkit.org/show_bug.cgi?id=35265
324
325          Some parts of the code passed arguments as
326          "actual, expected" and some passed as "expected, actual".
327          As you might imagine, this lead to great confusion and wrongness.
328          Standardize on "expected, actual" as that's the order which is
329          passed to the underlying diff tool.
330
331          Based on a patch by Eric Siedel <eric@webkit.org>.
332
333          * Scripts/webkitpy/layout_tests/port/base.py:
334          * Scripts/webkitpy/layout_tests/port/chromium.py:
335          * Scripts/webkitpy/layout_tests/port/test.py:
336          * Scripts/webkitpy/layout_tests/test_types/image_diff.py
337
338 2010-03-01  Chris Jerdonek  <cjerdonek@webkit.org>
339
340         Unreviewed.
341
342         Rolling out: http://trac.webkit.org/changeset/55348
343
344         https://bugs.webkit.org/show_bug.cgi?id=35163
345
346         Rolling out since the changes to autoinstall do not work
347         with Python 2.4. In particular, ZipFile.extractall() was
348         added in Python 2.6.
349
350         * Scripts/webkitpy/__init__.py:
351         * Scripts/webkitpy/bugzilla.py:
352         * Scripts/webkitpy/init/__init__.py: Removed.
353         * Scripts/webkitpy/init/autoinstall.py: Removed.
354         * Scripts/webkitpy/networktransaction.py:
355         * Scripts/webkitpy/networktransaction_unittest.py:
356         * Scripts/webkitpy/statusserver.py:
357         * Scripts/webkitpy/thirdparty/autoinstall.py: Added.
358
359 2010-03-01  Chris Jerdonek  <cjerdonek@webkit.org>
360
361         Unreviewed.
362
363         Rolling out r55350: http://trac.webkit.org/changeset/55350
364
365         https://bugs.webkit.org/show_bug.cgi?id=33639
366
367         Need to roll out because this patch (pep8) depends on the newly
368         rewritten autoinstall.py (r55348), which is breaking for people
369         with Python 2.4:
370
371         https://bugs.webkit.org/show_bug.cgi?id=35163#c21
372
373         That revision also needs to be rolled out and will be rolled out next.
374
375         * Scripts/webkitpy/style/checker.py:
376         * Scripts/webkitpy/style/checker_unittest.py:
377         * Scripts/webkitpy/style/processors/python.py: Removed.
378         * Scripts/webkitpy/style/processors/python_unittest.py: Removed.
379         * Scripts/webkitpy/style/processors/python_unittest_input.py: Removed.
380         * Scripts/webkitpy/style/unittests.py:
381         * Scripts/webkitpy/style_references.py:
382
383 2010-02-28  Chris Jerdonek  <cjerdonek@webkit.org>
384
385         Reviewed by Shinichiro Hamaji.
386
387         Exempted WebKitTools/Scripts/webkitpy/thirdparty from all
388         style checks except for the whitespace/carriage_return check
389         and the pep8 tab and trailing white space checks.
390
391         https://bugs.webkit.org/show_bug.cgi?id=35497
392
393         * Scripts/webkitpy/style/checker.py:
394           - Adjusted the _PATH_RULES_SPECIFIER configuration as necessary.
395           - Added enough pep8 categories to _all_categories() for the
396             unit tests to pass.
397
398         * Scripts/webkitpy/style/checker_unittest.py:
399           - Updated the test_path_rules_specifier() unit test.
400
401 2010-02-27  Chris Jerdonek  <cjerdonek@webkit.org>
402
403         Reviewed by David Levin.
404
405         Added Python style checking to check-webkit-style using
406         the third-party pep8 module (via autoinstall).
407
408         https://bugs.webkit.org/show_bug.cgi?id=33639
409
410         * Scripts/webkitpy/style/checker.py:
411           - Added PYTHON to FileType.
412           - Updated ProcessorDispatcher to return a PythonProcessor
413             for *.py files.
414
415         * Scripts/webkitpy/style/checker_unittest.py:
416           - Updated the ProcessorDispatcher unit tests for *.py files.
417
418         * Scripts/webkitpy/style/processors/python.py: Added.
419           - Added PythonProcessor class.
420
421         * Scripts/webkitpy/style/processors/python_unittest.py: Added.
422           - Added PythonProcessor unit tests.
423
424         * Scripts/webkitpy/style/processors/python_unittest_input.py: Added.
425           - Added a sample Python file to test the PythonProcessor.process()
426             code path (since pep8 accepts a file path).
427
428         * Scripts/webkitpy/style/unittests.py:
429           - Updated the style unit test file to import python_unittest.py.
430
431         * Scripts/webkitpy/style_references.py:
432           - Adjusted style references to import pep8.
433
434 2010-02-26  Chris Jerdonek  <cjerdonek@webkit.org>
435
436         Reviewed by David Levin.
437
438         Rewrote autoinstall.py to support unzipping *.zip files after
439         download, unzipping and extracting *.tar.gz files after download,
440         and copying installed files to a destination directory.
441
442         https://bugs.webkit.org/show_bug.cgi?id=35163
443
444         These changes will allow us to autoinstall pep8.py from the web
445         and to put our third-party autoinstalled code in an explicit
446         directory like webkitpy/thirdparty/autoinstalled. They should
447         also speed up imports from autoinstalled *.zip packages slightly
448         since *.pyc files cannot be generated when importing from
449         zipped packages.
450
451         * Scripts/webkitpy/__init__.py:
452           - Updated the autoinstall lines to use the new autoinstall methods.
453           - Added pep8.py to the list of auto-installed packages.
454
455         * Scripts/webkitpy/bugzilla.py:
456           - Updated mechanize import path.
457
458         * Scripts/webkitpy/init/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py.
459
460         * Scripts/webkitpy/init/autoinstall.py: Added.
461           - Added AutoInstaller class.
462           - Added sample testing usage to __main__.
463
464         * Scripts/webkitpy/networktransaction.py:
465           - Updated mechanize import path.
466
467         * Scripts/webkitpy/networktransaction_unittest.py:
468           - Updated mechanize import path.
469
470         * Scripts/webkitpy/statusserver.py:
471           - Updated mechanize import path.
472
473         * Scripts/webkitpy/thirdparty/autoinstall.py: Removed.
474           - Replaced with rewritten autoinstall in init/autoinstall.py.
475
476 2010-02-26  Dirk Pranke  <dpranke@chromium.org>
477
478         Reviewed by Adam Barth.
479
480         Change the default port for new-run-webkit-tests when running on
481         a Mac from 'chromium-mac' to 'mac'. Add a '--chromium' switch to
482         pick up the default platform-specific version of chromium instead.
483
484         https://bugs.webkit.org/show_bug.cgi?id=35462
485
486         * Scripts/webkitpy/layout_tests/port/factory.py:
487         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
488
489 2010-02-26  Dirk Pranke  <dpranke@chromium.org>
490
491         Unreviewed, build fix
492
493         third time's the charm getting this path right?
494
495         * pywebsocket/mod_pywebsocket/standalone.py:
496
497 2010-02-26  Dumitru Daniliuc  <dumi@chromium.org>
498
499         Unreviewed, build fix.
500
501         * pywebsocket/mod_pywebsocket/standalone.py:
502
503 2010-02-26  Dumitru Daniliuc  <dumi@chromium.org>
504
505         Reviewed by Dimitri Glazkov.
506
507         Moving the script to the right location.
508
509         * pywebsocket/mod_pywebsocket: Added.
510         * pywebsocket/mod_pywebsocket/standalone.py: Copied from WebKitTools/pywebsocket/standalone.py.
511         * pywebsocket/standalone.py: Removed.
512
513 2010-02-26  Dumitru Daniliuc  <dumi@chromium.org>
514
515         Unreviewed, fixing the license.
516
517         * pywebsocket/standalone.py:
518
519 2010-02-26  Dumitru Daniliuc  <dumi@chromium.org>
520
521         Reviewed by Adam Barth.
522
523         Adding pywebsocket/standalone.py back to fix the Chromium webkit
524         canaries. Once all layout tests pass, we can get in the patch that
525         moves this directorty to WebKitTools/Scripts, update all Chromium
526         scripts, and revert this patch.
527
528         https://bugs.webkit.org/show_bug.cgi?id=35464
529
530         * pywebsocket: Added.
531         * pywebsocket/standalone.py: Added.
532
533 2010-02-26  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
534
535         Reviewed by Xan Lopez.
536
537         [GTK] Needs proper reporting of frame loader callbacks, in DRT
538         https://bugs.webkit.org/show_bug.cgi?id=32170
539
540         Fix reporting of unload handlers, so that it is emitted where
541         needed, not after it.
542
543         * DumpRenderTree/gtk/DumpRenderTree.cpp:
544         (webViewLoadFinished):
545         (webViewDocumentLoadFinished):
546         (createWebView):
547
548 2010-02-26  Antonio Gomes  <tonikitoo@webkit.org>
549
550         Reviewed by Gustavo Noronha.
551         Patch by Antonio Gomes <tonikitoo@webkit.org>
552
553         [Gtk] Make DRT EventSender::keyDown to consider 'hardware_keycode' field when synthesizing an event.
554         https://bugs.webkit.org/show_bug.cgi?id=35432
555
556         When a directional key-press event (arrow keys, End, Home, PageUp,
557         PageDown, etc) is synthesized by DRT's EventSender and it targets
558         an editor (e.g. <input type=text>, <textare>, etc), event is processed
559         by WebCore::EventHandler. On the other hand, if event target is not
560         an editor, event is bubbled up to Gtk+ for processing. In such cases,
561         if 'hardware_keycode' is not provided at event synthesize time
562         its processing fails (at some point in gtk_bindings_activate_event),
563         and no scroll action is performed.
564
565         Unskip fast/events/node-event-anchor-lock.html
566
567         * DumpRenderTree/win/EventSender.cpp:
568         (keyDownCallback):
569         * platform/gtk/Skipped:
570
571 2010-02-26  Dimitri Glazkov  <dglazkov@chromium.org>
572
573         Reviewed by David Levin.
574
575         new-webkit-run-tests: Extraneous parenthesis in websocket_server.py
576         https://bugs.webkit.org/show_bug.cgi?id=35436
577
578          * Scripts/webkitpy/layout_tests/port/websocket_server.py: Removed extra paren.
579
580 2010-02-26  Chris Jerdonek  <cjerdonek@webkit.org>
581
582         Reviewed by David Levin.
583
584         Moved pywebsocket into the webkitpy/thirdparty directory and added
585         an associated README.webkit file to the pywebsocket directory.
586         This makes pywebsocket more consistent with the other third-party
587         Python code in our repository.
588
589         https://bugs.webkit.org/show_bug.cgi?id=35198
590
591         * Scripts/run-webkit-tests:
592           - Updated paths to pywebsocket.
593
594         * Scripts/run-webkit-websocketserver:
595           - Updated paths to pywebsocket.
596
597         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
598           - Updated paths to pywebsocket.
599
600         * Scripts/webkitpy/thirdparty/pywebsocket: Copied from WebKitTools/pywebsocket.
601         * Scripts/webkitpy/thirdparty/pywebsocket/README.webkit: Added.
602           - Added a file containing information about the contents
603             of the pywebsocket directory. This will make it easier to
604             understand where the third-party code came from and what
605             local changes have been made.
606
607         * pywebsocket: Removed.
608         * pywebsocket/COPYING: Removed.
609         * pywebsocket/MANIFEST.in: Removed.
610         * pywebsocket/README: Removed.
611         * pywebsocket/example: Removed.
612         * pywebsocket/example/echo_client.py: Removed.
613         * pywebsocket/example/echo_wsh.py: Removed.
614         * pywebsocket/mod_pywebsocket: Removed.
615         * pywebsocket/mod_pywebsocket/__init__.py: Removed.
616         * pywebsocket/mod_pywebsocket/dispatch.py: Removed.
617         * pywebsocket/mod_pywebsocket/handshake.py: Removed.
618         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Removed.
619         * pywebsocket/mod_pywebsocket/memorizingfile.py: Removed.
620         * pywebsocket/mod_pywebsocket/msgutil.py: Removed.
621         * pywebsocket/mod_pywebsocket/standalone.py: Removed.
622         * pywebsocket/mod_pywebsocket/util.py: Removed.
623         * pywebsocket/setup.py: Removed.
624         * pywebsocket/test: Removed.
625         * pywebsocket/test/config.py: Removed.
626         * pywebsocket/test/mock.py: Removed.
627         * pywebsocket/test/run_all.py: Removed.
628         * pywebsocket/test/test_dispatch.py: Removed.
629         * pywebsocket/test/test_handshake.py: Removed.
630         * pywebsocket/test/test_memorizingfile.py: Removed.
631         * pywebsocket/test/test_mock.py: Removed.
632         * pywebsocket/test/test_msgutil.py: Removed.
633         * pywebsocket/test/test_util.py: Removed.
634         * pywebsocket/test/testdata: Removed.
635         * pywebsocket/test/testdata/handlers: Removed.
636         * pywebsocket/test/testdata/handlers/blank_wsh.py: Removed.
637         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Removed.
638         * pywebsocket/test/testdata/handlers/sub: Removed.
639         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Removed.
640         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Removed.
641         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Removed.
642         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Removed.
643         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Removed.
644         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Removed.
645
646 2010-02-26  Chris Jerdonek  <cjerdonek@webkit.org>
647
648         Reviewed by Eric Seidel.
649
650         Changed the diff_parser module to log to a module-specific
651         logging.logger rather than the root logger.
652
653         https://bugs.webkit.org/show_bug.cgi?id=35391
654
655         * Scripts/webkitpy/diff_parser.py:
656
657 2010-02-26  Csaba Osztrogonác  <ossy@webkit.org>
658
659         Reviewed by Kenneth Rohde Christiansen.
660
661         [Qt] LayoutTestController.numberOfPages() should have default parameters
662         https://bugs.webkit.org/show_bug.cgi?id=35428
663
664         * DumpRenderTree/qt/DumpRenderTreeQt.cpp: maxViewWidth and maxViewHeight moved to
665         LayoutTestController to converge to platform independent implementation.
666         (WebCore::DumpRenderTree::DumpRenderTree):
667         (WebCore::DumpRenderTree::open):
668         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Initialization of maxViewWidth and maxViewHeight added.
669         * DumpRenderTree/qt/LayoutTestControllerQt.h:
670          - Default parameters for LayoutTestController.numberOfPages() added.
671          - maxViewWidth and maxViewHeight members added.
672
673 2010-02-26  Jamey Hicks  <jamey.hicks@nokia.com>
674
675         Reviewed by Laszlo Gombos.
676
677         [Qt] added QWebSettings::setInspectorUrl() and QWebSettings::inspectorUrl()
678
679         Enables the use of alternate Web Inspector frontends by changing
680         the location of the frontend. The location is specified by providing 
681             -inspector-url url
682         as an argument to QtLauncher.
683
684         This is required so that the Web Inspector may be run from an
685         external process or an external tool such as Eclipse or Aptana may
686         be used instead of the in-process Web Inspector UI.
687         
688         https://bugs.webkit.org/show_bug.cgi?id=35340
689
690         * QtLauncher/main.cpp:
691         (LauncherWindow::init):
692         (LauncherApplication::handleUserOptions):
693
694 2010-02-25  Dirk Pranke  <dpranke@chromium.org>
695
696         Reviewed by Eric Seidel.
697
698         Add a 'passing' port implementation to new-run-webkit-tests that
699         acts as a wrapper around an existing implementation but stubs out
700         the actual test invocations (instead, the expected results are echoed
701         back to the harness). This is useful for coverage and perf testing
702         of the harness (especially perf testing as it essentially provides
703         a lower bound on how fast the harness can run).
704
705         Also added a --nostart-helper flag to new-run-webkit-tests so that
706         you can skip starting the layout_test_helper and actually run the
707         harness even if you don't have a build of that port.
708
709         Also fix a bug in the 'test' port implementation to actually
710         create the results directory under /tmp instead of /.
711
712         https://bugs.webkit.org/show_bug.cgi?id=35370
713
714         * Scripts/webkitpy/layout_tests/port/factory.py: Modified.
715         * Scripts/webkitpy/layout_tests/port/passing.py: Added.
716         * Scripts/webkitpy/layout_tests/port/test.py: Added.
717         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Modified.
718
719 2010-02-25  Eric Seidel  <eric@webkit.org>
720
721         Fix typo in my last change.  No review.
722
723         Rename run-chromium-webkit-tests to new-run-webkit-tests to stop confusion
724         https://bugs.webkit.org/show_bug.cgi?id=35408
725
726         * Scripts/new-run-webkit-tests:
727
728 2010-02-25  Eric Seidel  <eric@webkit.org>
729
730         Reviewed by Adam Barth.
731
732         Rename run-chromium-webkit-tests to new-run-webkit-tests to stop confusion
733         https://bugs.webkit.org/show_bug.cgi?id=35408
734
735         * Scripts/new-run-webkit-tests: Added.
736         * Scripts/run-chromium-webkit-tests: Removed.
737         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py.
738
739 2010-02-25  Adam Barth  <abarth@webkit.org>
740
741         Reviewed by David Levin.
742
743         EWS leaks memory slowly
744         https://bugs.webkit.org/show_bug.cgi?id=35395
745
746         The EWS bots leak memory very slowly.  If you run them for about a
747         month, each one will take up around 1 GB of virutal memory.  If you run
748         several of them on one machine, you'll eventually exhaust all available
749         memory and grind the bots to a halt.
750
751         This patch introduces a --exit-after-iteration option to the queues so
752         that we run them for a finite amount of time.  Once they exit and
753         restart, they'll reclaim the leaked memory.  I'm not sure how many
754         iterations I'll end up running them for.  I'll need to sort that out
755         operationally, but my initial guess is around 1000.
756
757         * Scripts/webkitpy/commands/queues.py:
758         * Scripts/webkitpy/commands/queues_unittest.py:
759
760 2010-02-25  Jarkko Sakkinen  <jarkko.sakkinen@tieto.com>
761
762         Reviewed by Kenneth Rohde Christiansen.
763
764         Qt WebGL support
765
766         Adds toggling of WebGL support to QtLauncher.
767         https://bugs.webkit.org/show_bug.cgi?id=35153
768
769         * QtLauncher/main.cpp:
770         (LauncherWindow::toggleWebGL):
771         (LauncherWindow::setupUI):
772
773 2010-02-25  Ben Murdoch  <benm@google.com>
774
775         Reviewed by Kenneth Rohde Christiansen.
776
777         The target element of a Touch should be the target where that touch originated, not where it is now.
778         https://bugs.webkit.org/show_bug.cgi?id=34585
779
780         * DumpRenderTree/qt/EventSenderQt.cpp:
781         (EventSender::addTouchPoint): Fix a bug where touch points were not being given unique ids.
782
783 2010-02-24  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
784
785         Reviewed by Kenneth Rohde Christiansen.
786
787         [Qt] QtLauncher has a border when running on QGraphicsView mode
788         https://bugs.webkit.org/show_bug.cgi?id=35352
789
790         Fix 2-pixels frame on each border of QtLauncher when running on QGraphicsView mode.
791
792         * QtLauncher/webview.cpp:
793         (WebViewGraphicsBased::WebViewGraphicsBased):
794
795 2010-02-23  Dirk Pranke  <dpranke@chromium.org>
796
797         Reviewed by David Levin.
798
799         When the run-chromium-webkit-tests code was landed and the code was
800         refactored into the 'port' package, I accidentally broke using
801         http_server.py or websocket_server.py as command-line scripts
802         (the constructors needed a port object they weren't getting). This
803         change fixes them so that --server start|stop actually works.
804
805         As a part of this, the two files need to be able to call port.get(),
806         but doing that is awkward from a file inside the package, so I moved
807         get() into factory.py and imported that into __init__.py so that
808         http_server.py and websocket_server.py can just import factory.
809
810         https://bugs.webkit.org/show_bug.cgi?id=35316
811
812         * Scripts/webkitpy/layout_tests/port/__init__.py:
813         * Scripts/webkitpy/layout_tests/port/factory.py:
814         * Scripts/webkitpy/layout_tests/port/http_server.py:
815         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
816
817 2010-02-24  Dirk Pranke  <dpranke@chromium.org>
818
819         Reviewed by David Levin.
820
821         Fix the function signature for check_sys_deps on the mac port, and
822         fix the ordering of port_obj.check_sys_deps() and
823         port_obj.start_helper() (helper needs to be started before we check
824         the system configuration).
825
826         http://bugs.webkit.org/show_bug.cgi?id=35367
827
828         * Scripts/webkitpy/layout_tests/port/mac.py:
829         * Scripts/webkitpy/layout_tests/port/test.py:
830         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
831
832 2010-02-24  James Robinson  <jamesr@chromium.org>
833
834         Reviewed by Eric Seidel.
835
836         Provide default username parameter to SVN.commit_with_message().
837
838         * Scripts/webkitpy/scm.py:
839
840 2010-02-24  Dirk Pranke  <dpranke@chromium.org>
841
842         Reviewed by Eric Siedel.
843
844         Check the proper directory for a WebKit SVN version (Chromium does
845         not check out the entire WebKit tree directly, but rather pulls
846         individual subdirectories. So, checking for the SVN version in
847         WebKit/WebCore rather than just in WebKit works more reliably across
848         different ports).
849
850         http://bugs.webkit.org/show_bug.cgi?id=35321
851
852         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
853
854 2010-02-24  Alexey Proskuryakov  <ap@apple.com>
855
856         Reviewed by Dan Bernstein.
857
858         https://bugs.webkit.org/show_bug.cgi?id=35357
859         Two editing tests fail after DumpRenderTree run loop changes
860
861         AppKit decided that it wanted to group all editing commands for some reason (and thus undo
862         reverted them all at once).
863
864         * DumpRenderTree/mac/DumpRenderTree.mm:
865         (dump): Reverted the change that made DumpRenderTree use -[NSApplication run].
866         (runTest): Ditto.
867         (-[DumpRenderTreeApplication isRunning]): Override isRunning with a function that always
868         returns YES. This is another way to make the Java plug-in work.
869
870 2010-02-23  Adam Roben  <aroben@apple.com>
871
872         Make commit-log-editor find just-added ChangeLog files
873
874         Fixes <http://webkit.org/b/35294> commit-log-editor doesn't find
875         just-added ChangeLog files
876
877         Reviewed by Dave Levin.
878
879         * Scripts/commit-log-editor:
880         (top level): Modified the regular expression that's used to find
881         modified ChangeLog files to also look for just-added ChangeLog files.
882
883 2010-02-24  Shinichiro Hamaji  <hamaji@chromium.org>
884
885         Reviewed by Darin Adler.
886
887         check-webkit-style false positive for WebCore forwarding header
888         https://bugs.webkit.org/show_bug.cgi?id=34604
889
890         * Scripts/webkitpy/style/checker.py:
891         * Scripts/webkitpy/style/checker_unittest.py:
892
893 2010-02-23  Alexey Proskuryakov  <ap@apple.com>
894
895         Reviewed by Mark Rowe.
896
897         https://bugs.webkit.org/show_bug.cgi?id=22602
898         Enable Java in DumpRenderTree (on Mac)
899
900         * DumpRenderTree/mac/DumpRenderTree.mm:
901         (exitApplicationRunLoop):
902         (dump):
903         (runTest):
904         DumpRenderTree now runs an NSApplication, not just an event loop. This way, the Java plug-in
905         can start without freezing.
906
907         * Scripts/run-webkit-tests: Compile java sources in LayputTests/java.
908
909 2010-02-23  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
910
911         Reviewed by Kenneth Rohde Christiansen.
912
913         [Qt] Need a final integration between QtLauncher and QGVLauncher
914         https://bugs.webkit.org/show_bug.cgi?id=35292
915
916         WebKit coding style fixes.
917
918         * QtLauncher/main.cpp:
919         (LauncherWindow::resetZoom):
920
921 2010-02-23  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
922
923         Reviewed by Kenneth Rohde Christiansen.
924
925         [Qt] Need a final integration between QtLauncher and QGVLauncher
926         https://bugs.webkit.org/show_bug.cgi?id=35292
927
928         Add cloneWindow feature to QtLauncher, when running on QGraphicsView mode.
929
930         * QtLauncher/main.cpp:
931         (LauncherWindow::LauncherWindow):
932         (LauncherWindow::~LauncherWindow):
933         (LauncherWindow::init):
934         (LauncherWindow::cloneWindow):
935         (LauncherWindow::setupUI):
936
937 2010-02-23  Dirk Pranke  <dpranke@chromium.org>
938
939         Reviewed by Dimitri Glazkov.
940
941         Fix handling of check_wdiff_install when wdiff isn't installed.
942
943         http://bugs.webkit.org/show_bug.cgi?id=35304
944
945         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
946
947 2010-02-23  Leandro Pereira  <leandro@profusion.mobi>
948
949         Reviewed by NOBODY.
950
951         Fix false positives for 'delete *pointer' statements.
952         http://webkit.org/b/35235
953
954         * WebKitTools/Scripts/webkitpy/style/processors/cpp.py:
955
956 2010-02-23  Shinichiro Hamaji  <hamaji@chromium.org>
957
958         Reviewed by Eric Seidel.
959
960         [Gtk] Implement layoutTestController.numberOfPages
961         https://bugs.webkit.org/show_bug.cgi?id=35228
962
963         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
964         (LayoutTestController::numberOfPages):
965
966 2010-02-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
967
968         Reviewed by Kenneth Rohde Christiansen.
969
970         [Qt] QtLauncher should not use internal JavaScriptCore and WebCore interfaces
971         https://bugs.webkit.org/show_bug.cgi?id=35248
972
973         * QtLauncher/QtLauncher.pro:
974         * QtLauncher/utils.h:
975
976 2010-02-23  Daniel Bates  <dbates@rim.com>
977
978         Reviewed by Eric Seidel.
979
980         https://bugs.webkit.org/show_bug.cgi?id=34439
981
982         Prompts a person for their SVN username if not already cached (by Subversion).
983
984         Currently, webkit-patch is unable to commit to the SVN repo. unless the
985         WebKit SVN username is already cached (from of a prior commit by hand)
986         because "svn commit" (called by webkit-patch) defaults to using the system
987         login name unless the username is already cached or specified on the
988         command line.
989
990         * Scripts/webkitpy/scm.py: Added methods SVN.has_authorization_for_realm and
991         modified SVN.commit_with_message to call it. Added optional username parameter
992         to method SVN.commit_with_message.
993         * Scripts/webkitpy/scm_unittest.py: Added unit test methods: SVNTest.test_commit_with_username,
994         SVNTest.test_has_authorization_for_realm, and SVNTest.test_not_have_authorization_for_realm.
995
996 2010-02-22  Dirk Pranke  <dpranke@chromium.org>
997
998         Reviewed by Eric Siedel.
999
1000         Add more checking for missing binaries and packages to check_sys_deps()
1001
1002         https://bugs.webkit.org/show_bug.cgi?id=35062
1003
1004         * Scripts/webkitpy/layout_tests/port/base.py:
1005         * Scripts/webkitpy/layout_tests/port/chromium.py:
1006         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1007         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1008         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1009         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
1010
1011 2010-02-22  Shinichiro Hamaji  <hamaji@chromium.org>
1012
1013         Reviewed by David Levin.
1014
1015         [Gtk] check-webkit-style: GTK style should be allowed in WebKitTools/DumpRenderTree/gtk
1016         https://bugs.webkit.org/show_bug.cgi?id=35229
1017
1018         * Scripts/webkitpy/style/checker.py:
1019         * Scripts/webkitpy/style/checker_unittest.py:
1020
1021 2010-02-22  James Robinson  <jamesr@chromium.org>
1022
1023         Unreviewed. Adding myself to committers list.
1024
1025         * Scripts/webkitpy/committers.py:
1026
1027 2010-02-22  Simon Fraser  <simon.fraser@apple.com>
1028
1029         Reviewed by Darin Adler.
1030
1031         Remove DRT hack that turns off hardware acceleration with older QuickTimes
1032         https://bugs.webkit.org/show_bug.cgi?id=35275
1033         
1034         Now that WebKit does a version check to avoid a QuickTime-related
1035         crash (r55100), DumpRenderTree does not need to.
1036
1037         * DumpRenderTree/mac/DumpRenderTree.mm:
1038         (resetDefaultsToConsistentValues):
1039
1040 2010-02-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1041
1042         Reviewed by Kenneth Rohde Christiansen.
1043
1044         [Qt] Build the DRT in debug on Mac OS X
1045
1046         * DumpRenderTree/qt/DumpRenderTree.pro:
1047
1048 2010-02-22  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1049
1050         Reviewed by Kenneth Rohde Christiansen.
1051
1052         [Qt] Add support for layout tests on Symbian
1053         https://bugs.webkit.org/show_bug.cgi?id=31589
1054
1055         * DumpRenderTree/qt/DumpRenderTree.pro:
1056         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1057         * DumpRenderTree/qt/main.cpp:
1058         (main):
1059
1060 2010-02-20  Chris Jerdonek  <cjerdonek@webkit.org>
1061
1062         Reviewed by Adam Barth.
1063
1064         Moved simplejson into webkitpy/thirdparty directory.
1065
1066         https://bugs.webkit.org/show_bug.cgi?id=35196
1067
1068         * Scripts/run-chromium-webkit-tests:
1069           - Added webkitpy/thirdparty to the script's search path.
1070
1071         * Scripts/webkitpy/thirdparty/simplejson: Copied from WebKitTools/simplejson.
1072           - Copied simplejson directory.
1073
1074         * simplejson: Removed.
1075         * simplejson/LICENSE.txt: Removed.
1076         * simplejson/README.txt: Removed.
1077         * simplejson/__init__.py: Removed.
1078         * simplejson/_speedups.c: Removed.
1079         * simplejson/decoder.py: Removed.
1080         * simplejson/encoder.py: Removed.
1081         * simplejson/jsonfilter.py: Removed.
1082         * simplejson/scanner.py: Removed.
1083
1084 2010-02-20  Chris Jerdonek  <cjerdonek@webkit.org>
1085
1086         Reviewed by Adam Barth.
1087
1088         Moved BeautifulSoup to webkitpy/thirdparty directory.
1089
1090         https://bugs.webkit.org/show_bug.cgi?id=35195
1091
1092         * Scripts/webkitpy/BeautifulSoup.py: Removed.
1093           - Moved to webkitpy/thirdparty.
1094
1095         * Scripts/webkitpy/bugzilla.py:
1096           - Updated import statement.
1097
1098         * Scripts/webkitpy/bugzilla_unittest.py:
1099           - Updated import statement.
1100
1101         * Scripts/webkitpy/buildbot.py:
1102           - Updated import statement.
1103
1104         * Scripts/webkitpy/buildbot_unittest.py:
1105           - Updated import statement.
1106
1107         * Scripts/webkitpy/statusserver.py:
1108           - Updated import statement.
1109
1110         * Scripts/webkitpy/thirdparty/BeautifulSoup.py: Copied from WebKitTools/Scripts/webkitpy/BeautifulSoup.py.
1111
1112 2010-02-20  Chris Jerdonek  <cjerdonek@webkit.org>
1113
1114         Reviewed by Adam Barth.
1115
1116         Created a directory for third-party Python code, and moved
1117         autoinstall.py into it.
1118
1119         https://bugs.webkit.org/show_bug.cgi?id=34540
1120
1121         * Scripts/webkitpy/__init__.py:
1122           - Updated "import autoinstall" statement.
1123
1124         * Scripts/webkitpy/autoinstall.py: Removed.
1125           - Moved to thirdparty/autoinstall.py.
1126
1127         * Scripts/webkitpy/thirdparty: Added.
1128         * Scripts/webkitpy/thirdparty/__init__.py: Added.
1129         * Scripts/webkitpy/thirdparty/autoinstall.py: Copied from WebKitTools/Scripts/webkitpy/autoinstall.py.
1130
1131 2010-02-20  Gustavo Noronha Silva  <gns@gnome.org>
1132
1133         Unreviewed, obvious fix for the python failure in our new buildbot
1134         step:
1135
1136         http://build.webkit.org/builders/GTK Linux 32-bit Release/builds/9075/steps/API tests/logs/err.text
1137
1138         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1139
1140 2010-02-19  Maciej Stachowiak  <mjs@apple.com>
1141
1142         Reviewed by David Levin.
1143
1144         Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
1145         https://bugs.webkit.org/show_bug.cgi?id=35147
1146
1147         * Scripts/build-webkit: Handle new flag.
1148
1149 2010-02-19  Leandro Pereira  <leandro@profusion.mobi>
1150
1151         Reviewed by Shinichiro Hamaji.
1152
1153         [style-queue] should not complain about identifier names with underscores under WebKit/efl/ewk/
1154         https://bugs.webkit.org/show_bug.cgi?id=35091
1155
1156         White list unix_hacker_style names in WebKit/efl/ewk because these
1157         are used in the EFL API.
1158
1159         * Scripts/webkitpy/style/checker.py:
1160          - Filter out readability/naming on WebKit/efl/ewk.
1161
1162 2010-02-19  Eric Seidel  <eric@webkit.org>
1163
1164         Reviewed by Adam Barth.
1165
1166         Split out "prepare-rollout" from "rollout" and make --complete-rollout default
1167         https://bugs.webkit.org/show_bug.cgi?id=33745
1168
1169         * Scripts/webkitpy/commands/download.py:
1170          - Add a new AbstractRolloutPrepCommand to share code between PrepareRollout and Rollout
1171          - Add PrepareRollout
1172         * Scripts/webkitpy/commands/download_unittest.py: Test PrepareRollout, remove CompleteRollout tests.
1173         * Scripts/webkitpy/steps/__init__.py: include ReopenBugAfterRollout step.
1174         * Scripts/webkitpy/steps/completerollout.py: Removed.
1175         * Scripts/webkitpy/steps/options.py: remove complete_rollout
1176         * Scripts/webkitpy/steps/reopenbugafterrollout.py: Added.
1177
1178 2010-02-19  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1179
1180         Reviewed by Kenneth Rohde Christiansen.
1181
1182         [Qt] Need a final integration between QtLauncher and QGVLauncher
1183         https://bugs.webkit.org/show_bug.cgi?id=35161
1184
1185         Add animated flip support to QtLauncher when running on QGraphicsView mode.
1186
1187         * QtLauncher/main.cpp:
1188         (LauncherWindow::initializeView):
1189         (LauncherWindow::setupUI):
1190         * QtLauncher/webview.cpp:
1191         (WebViewGraphicsBased::WebViewGraphicsBased):
1192         (WebViewGraphicsBased::animatedFlip):
1193         (WebViewGraphicsBased::animatedYFlip):
1194         * QtLauncher/webview.h:
1195         (WebViewGraphicsBased::setYRotation):
1196         (WebViewGraphicsBased::yRotation):
1197
1198 2010-02-19  Andras Becsi  <abecsi@webkit.org>
1199
1200         Reviewed by Kenneth Rohde Christiansen.
1201
1202         [Qt] Implement textZoomIn() and textZoomOut() in DRT's EventSender, add results
1203         for passing new tests and unskip the passing ones from the Skipped list.
1204         https://bugs.webkit.org/show_bug.cgi?id=35159
1205
1206         * DumpRenderTree/qt/EventSenderQt.cpp:
1207         (EventSender::textZoomIn):
1208         (EventSender::textZoomOut):
1209         * DumpRenderTree/qt/EventSenderQt.h:
1210
1211 2010-02-19  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1212
1213         Reviewed by Eric Seidel.
1214
1215         [Qt] Clean-up the handling of HTML5 persistent data for LayoutTests
1216         https://bugs.webkit.org/show_bug.cgi?id=35004
1217
1218         DumpRenderTreeQt.cpp calls QWebSettings::enablePersistentStorage which sets up 
1219         and enables all HTML5 persistent data. All the other calls for setting the 
1220         persistent path or enabling the persistent feature are redundant. 
1221
1222         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1223         (WebCore::WebPage::WebPage): No need to enable AppCache again.
1224         * DumpRenderTree/qt/main.cpp:
1225         (main): No need to setup and enable HTML5 LocalStorage again.
1226
1227 2010-02-19  Diego Gonzalez  <diego.gonzalez@openbossa.org>
1228
1229         Reviewed by Kenneth Rohde Christiansen.
1230
1231         Send the context menu event from contextClick() of EventSender
1232         and do not show context menu in DRT.
1233
1234         LayoutTests:
1235             fast/events/contextmenu-scrolled-page-with-frame.html
1236
1237         [Qt] DRT: Send context menu event from EventSender
1238         https://bugs.webkit.org/show_bug.cgi?id=35131
1239
1240         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1241         (WebCore::DumpRenderTree::DumpRenderTree):
1242         * DumpRenderTree/qt/EventSenderQt.cpp:
1243         (EventSender::contextClick):
1244
1245 2010-02-18  Chris Jerdonek  <cjerdonek@webkit.org>
1246
1247         Reviewed by Shinichiro Hamaji.
1248
1249         Moved parsing-related code to a separate file. Also increased
1250         the unit test coverage in some affected areas.
1251
1252         https://bugs.webkit.org/show_bug.cgi?id=34675
1253
1254         This revision contains no new functionality.
1255
1256         * Scripts/check-webkit-style:
1257           - Adjusted to call check_webkit_style_parser().
1258
1259         * Scripts/webkitpy/style/checker.py:
1260           - Added check_webkit_style_parser() to pass checker.py
1261             configuration settings to optparser.py.
1262           - Moved _create_usage() and the CommandOptionValues,
1263             DefaultCommandOptionValues, ArgumentPrinter, and
1264             ArgumentParser classes to optparser.py.
1265
1266         * Scripts/webkitpy/style/checker_unittest.py:
1267           - Moved the ProcessorOptionsTest, ArgumentPrinterTest, and
1268             ArgumentParserTest classes to optparser.py.
1269           - Added the CheckWebKitStyleFunctionTest class to check
1270             the check_webkit_style_configuration() and
1271             check_webkit_style_parser() code paths.
1272
1273         * Scripts/webkitpy/style/optparser.py: Added.
1274           - From checker.py, added _create_usage() and the
1275             CommandOptionValues, DefaultCommandOptionValues,
1276             ArgumentPrinter, and ArgumentParser classes.
1277           - In the ArgumentParser constructor--
1278             - Added all_categories as a required parameter.
1279             - Removed the default value from the default_options parameter.
1280
1281         * Scripts/webkitpy/style/optparser_unittest.py: Added.
1282           - From checker_unittest.py, added the ProcessorOptionsTest,
1283             ArgumentPrinterTest, and ArgumentParserTest classes.
1284           - Added the CreateUsageTest class to test _create_usage().
1285
1286         * Scripts/webkitpy/style/unittests.py:
1287           - Added optparser_unittest import.
1288
1289 2010-02-18  Alexey Proskuryakov  <ap@apple.com>
1290
1291         Reviewed by Dan Bernstein.
1292
1293         https://bugs.webkit.org/show_bug.cgi?id=35134
1294         <rdar://problem/7246280> Crash when a plugin calls NPN_SetStatus(0)
1295
1296         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1297         (testSetStatus):
1298         (pluginInvoke):
1299         Added a setStatus() method.
1300
1301 2010-02-18  Brady Eidson  <beidson@apple.com>
1302
1303         Reviewed by Sam Weinig.
1304
1305         Particularly constructed WebFrames can try to access a null HistoryItem
1306         <rdar://problem/7638892> and https://bugs.webkit.org/show_bug.cgi?id=35063
1307
1308         Add the specific ability to test this API pattern. 
1309
1310         For now only on Mac, perhaps on the main Windows port later, probably not relevant for other ports.
1311
1312         * DumpRenderTree/LayoutTestController.cpp:
1313         (apiTestNewWindowDataLoadBaseURLCallback):
1314         (LayoutTestController::staticFunctions):
1315         * DumpRenderTree/LayoutTestController.h:
1316
1317         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1318         (-[APITestDelegate initWithCompletionCondition:]):
1319         (-[APITestDelegate webView:didFailLoadWithError:forFrame:]):
1320         (-[APITestDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1321         (-[APITestDelegate webView:didFinishLoadForFrame:]):
1322         (LayoutTestController::apiTestNewWindowDataLoadBaseURL): Create a WebView, do a loadData: in its
1323           mainFrame, and synchronously wait for main load completion.
1324
1325         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1326         (LayoutTestController::apiTestNewWindowDataLoadBaseURL):
1327         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1328         (LayoutTestController::apiTestNewWindowDataLoadBaseURL):
1329         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1330         (LayoutTestController::apiTestNewWindowDataLoadBaseURL):
1331
1332 2010-02-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1333
1334         Reviewed by Eric Seidel.
1335
1336         Teach resolve-ChangeLogs to act as a merge-driver for Git
1337
1338         https://bugs.webkit.org/show_bug.cgi?id=28721
1339
1340         To enable automatic merging of ChangeLog files, use the following command:
1341
1342         git config merge.changelog.driver "resolve-ChangeLogs --merge-driver %O %A %B"
1343
1344         The driver always works in "downstream" merge mode, meaning
1345         it will always put the user's changelog entries on top.
1346
1347         * Scripts/resolve-ChangeLogs:
1348
1349 2009-12-05  Gustavo Noronha Silva  <gns@gnome.org>
1350
1351         Reviewed by Eric Seidel.
1352
1353         Enable running of GTK+ API tests.
1354
1355         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1356         * Scripts/run-gtk-tests: Added.
1357
1358 2010-02-18  Shinichiro Hamaji  <hamaji@chromium.org>
1359
1360         Reviewed by Adam Barth.
1361
1362         debug-safari doesn't pass --debug option to gdb-safari on MacOSX
1363         https://bugs.webkit.org/show_bug.cgi?id=34411
1364
1365         * Scripts/webkitdirs.pm:
1366
1367 2010-02-18  Eric Seidel  <eric@webkit.org>
1368
1369         Reviewed by Adam Barth.
1370
1371         run-chromium-webkit-tests --platform=mac-leopard needs to run build-dumprendertree
1372         https://bugs.webkit.org/show_bug.cgi?id=35053
1373
1374         * Scripts/webkitpy/layout_tests/port/base.py: Add script_path() function for finding scripts.
1375         * Scripts/webkitpy/layout_tests/port/chromium.py: Remove unused argument.
1376         * Scripts/webkitpy/layout_tests/port/mac.py:
1377          - Make sure that calling webkit-build-directory works even if Scripts/ is not in the user's path.
1378          - Call build-dumprendertree (and make sure it succeeds) before running the tests.
1379
1380 2010-02-16  Chris Jerdonek  <cjerdonek@webkit.org>
1381
1382         Reviewed by Shinichiro Hamaji.
1383
1384         Refactored check-webkit-style's ProcessorOptions class into two
1385         classes. This revision contains no new functionality.
1386
1387         https://bugs.webkit.org/show_bug.cgi?id=34674
1388
1389         Divided the ProcessorOptions class into a CommandOptionValues
1390         class (the result of parsing the command-line options) and
1391         a StyleCheckerConfiguration class (which configures the main
1392         StyleChecker).
1393
1394         * Scripts/check-webkit-style:
1395           - Updated main() to convert the parsed command option values
1396             to a StyleCheckConfiguration instance prior to constructing
1397             a StyleChecker.
1398
1399         * Scripts/webkitpy/style/checker.py:
1400           - Added check_webkit_style_configuration() to convert a
1401             CommandOptionValues instance into a StyleCheckerConfiguration
1402             instance.
1403           - Renamed the ProcessorOptions class to CommandOptionValues.
1404           - In the CommandOptionValues class--
1405             - Replaced the filter_configuration attribute with the
1406               simpler filter_rules attribute.
1407             - Removed the max_reports_per_error attribute.
1408             - Moved the is_reportable() method to the new
1409               StyleCheckerConfiguration class.
1410           - Removed the base_filter_rules attribute from the
1411             DefaultCommandOptionValues class.
1412           - In the ArgumentParser class--
1413             - Added base_filter_rules to the constructor.
1414             - Changed the parse() method to return a CommandOptionValues
1415               instance instead of a ProcessorOptions instance.
1416           - Created a StyleCheckerConfiguration class.
1417             - Added the data attributes max_reports_per_category,
1418               stderr_write, and verbosity.
1419             - Added is_reportable() (moved from the ProcessorOptions
1420               class) and write_style_error() (moved from the
1421               DefaultStyleErrorHandler class).
1422           - In the StyleChecker class--
1423             - Replaced the ProcessorOptions options attribute with the
1424               StyleCheckerConfiguration _configuration attribute.
1425             - Removed the _stderr_write attribute.
1426
1427         * Scripts/webkitpy/style/checker_unittest.py:
1428           - Updated the existing unit test classes as necessary.
1429           - Added a StyleCheckerConfigurationTest class.
1430
1431         * Scripts/webkitpy/style/error_handlers.py:
1432           - Updated the DefaultStyleErrorHandler class to accept a
1433             StyleCheckerConfiguration instance instead of a ProcessorOptions
1434             instance and an stderr_write method.
1435
1436         * Scripts/webkitpy/style/error_handlers_unittest.py:
1437           - Updated the unit test classes as necessary.
1438
1439         * Scripts/webkitpy/style/filter.py:
1440           - Addressed the FIXME in the FilterConfiguration class to change
1441             the user_rules attribute to _user_rules (since it is now
1442             accessed only internally).
1443
1444         * Scripts/webkitpy/style/filter_unittest.py:
1445           - Updated to reflect the change from user_rules to _user_rules.
1446
1447 2010-02-17  Shinichiro Hamaji  <hamaji@chromium.org>
1448
1449         Reviewed by Eric Seidel.
1450
1451         Share the DRT values maxViewWidth/Height among ports
1452         https://bugs.webkit.org/show_bug.cgi?id=34474
1453
1454         * DumpRenderTree/LayoutTestController.cpp:
1455         (pageNumberForElementByIdCallback):
1456         * DumpRenderTree/LayoutTestController.h:
1457         (LayoutTestController::maxViewWidth):
1458         (LayoutTestController::maxViewHeight):
1459         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1460         (runTest):
1461         * DumpRenderTree/mac/DumpRenderTree.mm:
1462         (createWebViewAndOffscreenWindow):
1463         (sizeWebViewForCurrentTest):
1464         * DumpRenderTree/win/DumpRenderTree.cpp:
1465         (dump):
1466         (createWebViewAndOffscreenWindow):
1467
1468 2010-02-17  Shinichiro Hamaji  <hamaji@chromium.org>
1469
1470         Reviewed by Eric Seidel.
1471
1472         [Win] Implement test functions for printing
1473         https://bugs.webkit.org/show_bug.cgi?id=34570
1474
1475         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1476         (LayoutTestController::pageNumberForElementById):
1477         (LayoutTestController::numberOfPages):
1478
1479 2010-02-17  Fumitoshi Ukai  <ukai@chromium.org>
1480
1481         Reviewed by Eric Seidel.
1482
1483         websocket/tests/cookies/httponly-cookie.pl fails every time under run-chromium-webkit-tests
1484         https://bugs.webkit.org/show_bug.cgi?id=35001
1485
1486         * Scripts/webkitpy/layout_tests/port/websocket_server.py: add -x flag to run pywebsocket.
1487
1488 2010-02-17  Shinichiro Hamaji  <hamaji@chromium.org>
1489
1490         Reviewed by Eric Seidel.
1491
1492         check-webkit-style: Misses variables that contain underscores.
1493         https://bugs.webkit.org/show_bug.cgi?id=33724
1494
1495         - Check identifiers whose types are unsigned.
1496         - Check bitfields properly.
1497
1498         * Scripts/webkitpy/style/processors/cpp.py:
1499         * Scripts/webkitpy/style/processors/cpp_unittest.py:
1500
1501 2010-02-17  Shinichiro Hamaji  <hamaji@chromium.org>
1502
1503         Reviewed by Eric Seidel.
1504
1505         check-webkit-style should report the number of files checked
1506         https://bugs.webkit.org/show_bug.cgi?id=34971
1507
1508         * Scripts/check-webkit-style:
1509         * Scripts/webkitpy/style/checker.py:
1510         * Scripts/webkitpy/style/checker_unittest.py:
1511
1512 2010-02-17  Diego Gonzalez  <diego.gonzalez@openbossa.org>
1513
1514         Reviewed by Ariya Hidayat.
1515
1516         Make possible Qt DRT to get total number of pages to be printed
1517
1518         LayoutTests:
1519             printing/numberOfPages.html
1520
1521         [Qt] DRT: Get total number of pages to be printed
1522         https://bugs.webkit.org/show_bug.cgi?id=34955
1523
1524         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1525         (LayoutTestController::numberOfPages):
1526         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1527
1528 2010-02-17  Xan Lopez  <xlopez@igalia.com>
1529
1530         Reviewed by Gustavo Noronha.
1531
1532         Update to use new property name.
1533
1534         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1535         (resetDefaultsToConsistentValues):
1536
1537 2010-02-17  Julien Chaffraix  <jchaffraix@webkit.org>
1538
1539         Reviewed by Ariya Hidayat.
1540
1541         Remove some warnings seen when building Qt
1542         https://bugs.webkit.org/show_bug.cgi?id=35017
1543
1544         Using a machine without the needed tools to build WebKit leads to
1545         several errors and warnings.
1546
1547         * Scripts/webkitdirs.pm: Refactored the code testing the command's
1548         presence into a commandExists routine. While doing so removed, stderr
1549         output as it usually does not give anything more than our message. Also
1550         added a Qt check for qmake that was missing.
1551
1552 2010-02-17  Xan Lopez  <xlopez@igalia.com>
1553
1554         Rubber-stamped by Gustavo Noronha.
1555
1556         Disable Java by default in DRT.
1557
1558         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1559         (resetDefaultsToConsistentValues):
1560
1561 2010-02-15  Chris Jerdonek  <cjerdonek@webkit.org>
1562
1563         Reviewed by Shinichiro Hamaji.
1564
1565         Some minor check-webkit-style code clean-ups.  This revision
1566         contains no new functionality.
1567
1568         https://bugs.webkit.org/show_bug.cgi?id=34932
1569
1570         * Scripts/check-webkit-style:
1571           - Replaced the call to webkit_argument_defaults() with a
1572             default parameter in the ArgumentParser constructor.
1573
1574         * Scripts/webkitpy/style/checker.py:
1575           - Removed the WEBKIT prefix from the default global variables.
1576           - Prefixed several of the global variables with an underscore
1577             to reflect that they are used internally.
1578           - Renamed _DEFAULT_FILTER_RULES to _BASE_FILTER_RULES.
1579           - Addressed a FIXME by changing the _PATH_RULES_SPECIFIER
1580             configuration from list-tuple pairs to list-list pairs.
1581           - Renamed style_categories() to _all_categories().
1582           - Renamed webkit_argument_defaults() to _check_webkit_style_defaults().
1583           - Renamed the ArgumentDefaults class to DefaultCommandOptionValues.
1584           - In the ArgumentParser class--
1585             - Renamed the doc_print attribute to stderr_write.
1586             - Other minor updates.
1587
1588         * Scripts/webkitpy/style/checker_unittest.py:
1589           - Updated the import statements and unit test classes as necessary.
1590           - Added assertions to test _PATH_RULES_SPECIFIER more fully.
1591
1592         * Scripts/webkitpy/style/error_handlers_unittest.py:
1593           - Updated the unit test classes as necessary.
1594           - Changed StyleErrorHandlerTestBase to store a list of error
1595             messages rather than just the last one.
1596
1597         * Scripts/webkitpy/style/filter.py:
1598           - Altered FilterConfiguration._path_rules_from_path()
1599             to convert the path_rules list to a tuple.
1600
1601         * Scripts/webkitpy/style/filter_unittest.py:
1602           - Updated the unit tests to reflect the change from tuples to
1603             lists in the _PATH_RULES_SPECIFIER configuration variable.
1604
1605 2010-02-16  Mark Rowe  <mrowe@apple.com>
1606
1607         Let's not check garbage in to common build scripts and hose the world now eh guys?
1608
1609         * Scripts/webkitdirs.pm:
1610
1611 2010-02-16  Eric Seidel  <eric@webkit.org>
1612
1613         Reviewed by Adam Barth.
1614
1615         re-factor Skipped list parsing code into multiple functions and unit test it
1616         https://bugs.webkit.org/show_bug.cgi?id=34986
1617
1618         * Scripts/test-webkitpy: Add new unit test.
1619         * Scripts/webkitpy/layout_tests/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py.
1620         * Scripts/webkitpy/layout_tests/port/mac.py: Split parsing function into multiple functions for testing.
1621         * Scripts/webkitpy/layout_tests/port/mac_unittest.py: Added.
1622
1623 2010-02-16  Xan Lopez  <xlopez@igalia.com>
1624
1625         Reviewed by Gustavo Noronha.
1626
1627         Enable 'auto-resize-window' in our DRT.
1628
1629         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1630         (resetDefaultsToConsistentValues):
1631
1632 2010-02-15  Martin Robinson  <mrobinson@webkit.org>
1633
1634         Reviewed by Darin Adler.
1635
1636         check-webkit-style should not complain about NULL sentinel in calls to g_strconcat and g_strjoin
1637         https://bugs.webkit.org/show_bug.cgi?id=34834
1638
1639         * Scripts/webkitpy/style/processors/cpp.py:
1640         * Scripts/webkitpy/style/processors/cpp_unittest.py:
1641
1642 2010-02-12  Alexey Proskuryakov  <ap@apple.com>
1643
1644         Reviewed by Kevin Decker.
1645
1646         <rdar://problem/7130641> Browser objects identity is not preserved by Safari
1647
1648         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1649         (pluginInvoke): Added methods for checking object identity (via refcount).
1650
1651 2010-02-15  Robert Hogan  <robert@roberthogan.net>
1652
1653         Reviewed by Simon Hausmann.
1654
1655         [Qt] DRT: Support evaluateInWebInspector(), setTimelineProfilingEnabled().
1656
1657         Support LayoutTestController.evaluateInWebInspector(), setTimelineProfilingEnabled() in Qt DRT.
1658
1659         https://bugs.webkit.org/show_bug.cgi?id=33096
1660
1661         This allows the following tests to pass:
1662
1663         inspector/console-format-collections.html
1664         inspector/styles-iframe.html
1665         inspector/syntax-highlight-css.html
1666         inspector/syntax-highlight-javascript.html
1667         inspector/timeline-enum-stability.html
1668         inspector/timeline-layout.html
1669         inspector/timeline-mark-timeline.html
1670         inspector/timeline-paint.html
1671         inspector/timeline-parse-html.html
1672         inspector/timeline-recalculate-styles.html
1673         inspector/timeline-script-tag-1.html
1674         inspector/timeline-script-tag-2.html
1675         inspector/timeline-trivial.html
1676         inspector/cookie-resource-match.html
1677         inspector/elements-img-tooltip.html
1678         inspector/elements-panel-selection-on-refresh.html
1679         inspector/inspected-objects-not-overriden.html
1680         inspector/timeline-event-dispatch.html
1681         inspector/timeline-network-resource.html
1682         inspector/elements-panel-rewrite-href.html
1683         inspector/console-dir.html
1684         inspector/console-dirxml.html
1685         inspector/console-format.html
1686         inspector/console-tests.html
1687         inspector/elements-panel-structure.html
1688         inspector/evaluate-in-frontend.html
1689         inspector/console-clear.html
1690
1691         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1692         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1693         (WebCore::isWebInspectorTest):
1694         (WebCore::DumpRenderTree::open):
1695         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1696         (WebCore::DumpRenderTree::display):
1697         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1698         (LayoutTestController::closeWebInspector):
1699         (LayoutTestController::showWebInspector):
1700         (LayoutTestController::evaluateInWebInspector):
1701         (LayoutTestController::setTimelineProfilingEnabled):
1702         (LayoutTestController::display):
1703         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1704
1705 2010-02-14  Dirk Pranke  <dpranke@chromium.org>
1706
1707         Reviewed by Eric Seidel.
1708
1709         Update rebaseline-chromium-webkit-tests to work with the new code
1710         structure (port objects instead of path_utils and platform_utils).
1711
1712         Added a path_to_test_expectations_file() to the Port interface.
1713   
1714         Fixed a bug in the chromium_* platform implementations where the
1715         'target' option was assumed to be set.
1716
1717         * Scripts/rebaseline-chromium-webkit-tests:
1718         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1719         * Scripts/webkitpy/layout_tests/port/base.py:
1720         * Scripts/webkitpy/layout_tests/port/chromium.py:
1721         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1722         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1723         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1724         * Scripts/webkitpy/layout_tests/port/test.py:
1725         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1726
1727 2010-02-14  Eric Seidel  <eric@webkit.org>
1728
1729         Reviewed by Darin Adler.
1730
1731         webkit-build-directory misuses terms
1732         https://bugs.webkit.org/show_bug.cgi?id=34822
1733
1734         * Scripts/webkit-build-directory:
1735          - Add --top-level and --configuration options and make using one of them required.
1736         * Scripts/webkitpy/layout_tests/port/mac.py:
1737          - Use --top-level instead of --base.
1738
1739 2010-02-14  Chang Shu  <Chang.Shu@nokia.com>
1740
1741         Reviewed by Laszlo Gombos.
1742
1743         [Qt] Enable appcache feature.
1744         https://bugs.webkit.org/show_bug.cgi?id=34713
1745
1746         Re-land r54543 without the change in DumpRenderTree/qt/main.cpp.
1747         Persistent storage for AppCache is already initialized in
1748         DumpRenderTreeQt.cpp.
1749
1750         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1751         (WebCore::WebPage::WebPage):
1752
1753 2010-02-12  Chang Shu  <Chang.Shu@nokia.com>
1754
1755         Not Reviewed.
1756
1757         Change case of my email address as a work-around for the following bug.
1758         https://bugs.webkit.org/show_bug.cgi?id=34717
1759
1760         * Scripts/webkitpy/committers.py:
1761
1762 2010-02-12  Darin Adler  <darin@apple.com>
1763
1764         Ignore compiled Python in more of webkitpy.
1765
1766         * Scripts/webkitpy/style/processors: Added property svn:ignore.
1767
1768 2010-02-12  Diego Gonzalez  <diego.gonzalez@openbossa.org>
1769
1770         Reviewed by Kenneth Rohde Christiansen.
1771
1772         Qt DRT now dump the frame loader callbacks when LayoutTestController()
1773         method is called.
1774
1775         LayoutTests:
1776             http/tests/security/mixedContent/data-url-script-in-iframe.html
1777             http/tests/security/mixedContent/empty-url-plugin-in-frame.html
1778             http/tests/security/mixedContent/insecure-css-in-iframe.html
1779             http/tests/security/mixedContent/insecure-iframe-in-iframe.html
1780             http/tests/security/mixedContent/insecure-image-in-iframe.html
1781             http/tests/security/mixedContent/insecure-plugin-in-iframe.html
1782             http/tests/security/mixedContent/insecure-script-in-iframe.html
1783             http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe.html
1784             http/tests/security/mixedContent/redirect-https-to-http-script-in-iframe.html
1785
1786         [Qt] Make possible Qt DRT dump frame load callbacks
1787         https://bugs.webkit.org/show_bug.cgi?id=34702
1788
1789         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1790         (LayoutTestController::reset):
1791         (LayoutTestController::dumpFrameLoadCallbacks):
1792         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1793
1794 2010-02-12  Simon Hausmann  <simon.hausmann@nokia.com>
1795
1796         Reviewed by Antti Koivisto.
1797
1798         Make QtLauncher somewhat useable on S60.
1799
1800         Show the window fullscreen to make scrollbars appear, resize
1801         the toolbar buttons to 16x16 to give more screen space to
1802         web content and moved the location lineedit into a separate
1803         line.
1804
1805         * QtLauncher/main.cpp:
1806         (LauncherWindow::LauncherWindow):
1807         * QtLauncher/mainwindow.cpp:
1808         (MainWindow::buildUI):
1809
1810 2010-02-12  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1811
1812         Reviewed by Kenneth Rohde Christiansen.
1813
1814         Support frameset flattening
1815         https://bugs.webkit.org/show_bug.cgi?id=32717
1816
1817         Add FrameSet Flattening support to Mac DRT.
1818
1819         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1820         (LayoutTestController::setFrameSetFlatteningEnabled):
1821         * DumpRenderTree/win/DumpRenderTree.cpp:
1822         (resetDefaultsToConsistentValues):
1823         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1824         (LayoutTestController::setXSSAuditorEnabled):
1825         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1826         (LayoutTestController::setFrameSetFlatteningEnabled):
1827         * DumpRenderTree/LayoutTestController.cpp:
1828         (setFrameSetFlatteningEnabledCallback):
1829         (LayoutTestController::staticFunctions):
1830         * DumpRenderTree/LayoutTestController.h:
1831         * DumpRenderTree/mac/DumpRenderTree.mm:
1832         (resetDefaultsToConsistentValues):
1833         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1834         (LayoutTestController::setFrameSetFlatteningEnabled):
1835
1836 2010-02-12  Dirk Pranke  <dpranke@chromium.org>
1837
1838         Reviewed by Eric Seidel.
1839
1840         Fix typos in driver_test.py 
1841
1842         https://bugs.webkit.org/show_bug.cgi?id=34810
1843
1844         * Scripts/webkitpy/layout_tests/driver_test.py:
1845
1846 2010-02-12  Simon Hausmann  <simon.hausmann@nokia.com>
1847
1848         Reviewed by Kenneth Rohde Christiansen.
1849
1850         [Qt] Make it possible to toggle the use of QGraphicsView in QtLauncher at run-time
1851         https://bugs.webkit.org/show_bug.cgi?id=34844
1852
1853         * QtLauncher/main.cpp:
1854         (LauncherWindow::LauncherWindow):
1855         (LauncherWindow::initializeView):
1856         (LauncherWindow::setupUI):
1857         * QtLauncher/webview.cpp:
1858         (WebViewGraphicsBased::WebViewGraphicsBased):
1859
1860 2010-02-11  Fumitoshi Ukai  <ukai@chromium.org>
1861
1862         Reviewed by Alexey Proskuryakov.
1863
1864         WebSocket ignores HttpOnly cookies, but should use in Handshake.
1865         https://bugs.webkit.org/show_bug.cgi?id=34289
1866
1867         Update pywebsocket to 0.4.8, which supports cgi directories.
1868         run-webkit-tests and run-webkit-websocketserver will run
1869         pywebsocket, specifying /websocket/test/cookies as cgi directory.
1870
1871         * Scripts/run-webkit-tests:
1872         * Scripts/run-webkit-websocketserver:
1873         * pywebsocket/mod_pywebsocket/standalone.py:
1874         * pywebsocket/setup.py:
1875
1876 2010-02-11  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1877
1878         Reviewed by Dan Bernstein.
1879
1880         [Mac] Duplicated setXSSAuditorEnabled preference at Mac DRT
1881         https://bugs.webkit.org/show_bug.cgi?id=34798
1882
1883         Remove duplicated setXSSAuditorEnabled preference at Mac DRT
1884
1885         * DumpRenderTree/mac/DumpRenderTree.mm:
1886         (resetDefaultsToConsistentValues):
1887
1888 2010-02-11  Eric Seidel  <eric@webkit.org>
1889
1890         No review, build fix only.
1891
1892         webkitdirs.pm has a crazy amount of duplicated feature detection code
1893         https://bugs.webkit.org/show_bug.cgi?id=34869
1894
1895         * Scripts/build-webkit: Fix typo which broke bots.
1896
1897 2010-02-11  Eric Seidel  <eric@webkit.org>
1898
1899         Reviewed by Adam Barth.
1900
1901         webkitdirs.pm has a crazy amount of duplicated feature detection code
1902         https://bugs.webkit.org/show_bug.cgi?id=34869
1903
1904         * Scripts/build-webkit: Use the new hotness.
1905         * Scripts/run-webkit-tests: ditto
1906         * Scripts/webkitdirs.pm: Remove a bunch of bad duplicate code.
1907         * Scripts/webkitperl/features.pm: Added.
1908          - Simplified the 10 methods in webkitdirs.pm into 2 exported methods in this new file.
1909
1910 2010-02-11  Daniel Bates  <dbates@rim.com>
1911
1912         Reviewed by Adam Barth.
1913
1914         https://bugs.webkit.org/show_bug.cgi?id=34830
1915
1916         Makes method User.prompt static and adds the parameter repeat
1917         to prompt the user up to repeat times.
1918
1919         * Scripts/test-webkitpy:
1920         * Scripts/webkitpy/bugzilla.py: Substituted method User.prompt for method raw_input.
1921         * Scripts/webkitpy/commands/upload.py: Ditto
1922         * Scripts/webkitpy/credentials.py: Ditto
1923         * Scripts/mock_bugzillatool.py: Updated prototype of MockUser.prompt to match User.prompt.
1924         * Scripts/webkitpy/user.py: Made method prompt static and added parameter repeat.
1925         * Scripts/webkitpy/user_unittest.py: Added.
1926
1927 2010-02-10  Yuzo Fujishima  <yuzo@google.com>
1928
1929         Reviewed by Darin Adler.
1930
1931         Allow underscored identifiers in CSSParser.cpp
1932
1933         Flex (http://flex.sourceforge.net/) uses identifiers named as yy_*.
1934         WebCore/css/CSSParser.cpp needs to handle some such identifiers.
1935         We should relax the style rule for the file to allow underscored identifiers.
1936
1937         https://bugs.webkit.org/show_bug.cgi?id=34787
1938
1939         * Scripts/webkitpy/style/checker.py:
1940
1941 2010-02-11  Eric Seidel  <eric@webkit.org>
1942
1943         Rubber-stamped by Adam Barth.
1944
1945         Remove DrawTest, the application I used when bringing up SVG support on the Mac.
1946         The code hasn't been touched (or used) in years.  No sense in keeping it in trunk.
1947
1948         * Scripts/build-drawtest: Removed.
1949         * Scripts/run-drawtest: Removed.
1950         * DrawTest: Removed.
1951
1952 2010-02-11  Eric Seidel  <eric@webkit.org>
1953
1954         Reviewed by Adam Barth.
1955
1956         Need a command to clear r+ on obsolete patches in the pending-commit queue.
1957         https://bugs.webkit.org/show_bug.cgi?id=34863
1958
1959         Unfortunately our http://webkit.org/pending-commit bugzilla query is not
1960         smart enough to ignore obsolete patches, so bugs show up there which are
1961         still open, but do not have patches ready for landing on them.
1962         This new command "clean-pending-commit" will remove r+ from obsolete patches
1963         in the pending-commit list.
1964
1965         * Scripts/test-webkitpy: Add grammar_unittest
1966         * Scripts/webkitpy/commands/upload.py: Add clean-pending-commit and make assign-to-committer ignore cq+'d patches.
1967         * Scripts/webkitpy/grammar.py: Add join_with_separators
1968         * Scripts/webkitpy/grammar_unittest.py: Added.
1969
1970 2010-02-11  Eric Seidel  <eric@webkit.org>
1971
1972         Reviewed by Adam Barth.
1973
1974         run-chromium-webkit-tests fails random pixel tests on Mac
1975         https://bugs.webkit.org/show_bug.cgi?id=34862
1976
1977         This is due to the fact that the Mac port has an
1978         invalid path to the image diff tool.  Currently it points
1979         to image_diff even though ImageDiff would be correct.  We
1980         can't change it to the right path yet without causing the
1981         script to hang.  ImageDiff expects to be long-running and
1982         be passed image data over stdin.  image_diff (chromium's fork)
1983         expects to be passed command line arguments.
1984         This fix works around the random failures by disabling pixel
1985         tests on mac and logging if the user was trying to run with pixel
1986         tests enabled.
1987
1988         * Scripts/webkitpy/layout_tests/port/mac.py:
1989
1990 2010-02-11  Nikolas Zimmermann  <nzimmermann@rim.com>
1991
1992         Reviewed by Adam Roben.
1993         Try to fix build breakage from r54665.
1994         
1995         * Scripts/check-for-global-initializers:
1996
1997 2010-02-11  Simon Hausmann  <simon.hausmann@nokia.com>
1998
1999         Reviewed by Tor Arne Vestbø.
2000
2001         Make it possible to toggle accelerated compositing from the menu
2002         at run-time.
2003
2004         * QtLauncher/main.cpp:
2005         (LauncherWindow::toggleAcceleratedCompositing):
2006         (LauncherWindow::setupUI):
2007
2008 2010-02-08  Maciej Stachowiak  <mjs@apple.com>
2009
2010         Reviewed by Cameron Zwarich.
2011
2012         Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose.
2013         https://bugs.webkit.org/show_bug.cgi?id=34698
2014
2015         * Scripts/build-webkit:
2016
2017 2010-02-10  Dirk Pranke  <dpranke@chromium.org>
2018
2019         Reviewed by Eric Seidel.
2020
2021         Fix various minor bugs keeping run-chromium-webkit-tests from actually
2022         working on the linux and win ports of Chromium.
2023
2024         https://bugs.webkit.org/show_bug.cgi?id=34739
2025
2026         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
2027         * Scripts/webkitpy/layout_tests/port/__init__.py:
2028         * Scripts/webkitpy/layout_tests/port/base.py:
2029         * Scripts/webkitpy/layout_tests/port/chromium.py:
2030         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2031         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2032         * Scripts/webkitpy/layout_tests/port/http_server.py:
2033         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2034
2035 2010-02-10  Eric Seidel  <eric@webkit.org>
2036
2037         Reviewed by David Levin.
2038
2039         run-chromium-webkit-tests --platform=mac-leopard crashes when using a custom build directory
2040         https://bugs.webkit.org/show_bug.cgi?id=34817
2041
2042         This doesn't fix the root cause of us not
2043         correctly failing when support binaries are missing.
2044         This only causes the DumpRenderTree binary not to be
2045         missing in the custom build directory case.
2046         Later patches will make us correctly fail fast when
2047         support binaries (like DumpRenderTree or ImageDiff) are missing.
2048
2049         * Scripts/webkit-build-directory: Added.
2050          - Need a way to re-use the perl logic for finding build directories in non-perl scripts.
2051         * Scripts/webkitpy/layout_tests/port/base.py: Add a FIXME.
2052         * Scripts/webkitpy/layout_tests/port/mac.py:
2053          - Call webkit-build-directory to find the build directory instead of assuming "WebKitBuild"
2054         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Add FIXMEs.
2055
2056 2010-02-10  Kevin Watters  <kevinwatters@gmail.com>
2057
2058         Reviewed by Kevin Ollivier.
2059
2060         [wx] Add Windows complex text support.
2061         
2062         https://bugs.webkit.org/show_bug.cgi?id=34759
2063
2064         * wx/build/settings.py:
2065
2066 2010-02-10  Kevin Ollivier  <kevino@theolliviers.com>
2067
2068         [wx] Build fix. Add stub for new LayoutTestController method.
2069
2070         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2071         (LayoutTestController::numberOfPages):
2072
2073 2010-02-10  Csaba Osztrogonác  <ossy@webkit.org>
2074
2075         Unreviewed. Roll out r54626, because it broke GTK and Win build.
2076         https://bugs.webkit.org/show_bug.cgi?id=32717
2077
2078         * DumpRenderTree/LayoutTestController.cpp:
2079         (LayoutTestController::staticFunctions):
2080         * DumpRenderTree/LayoutTestController.h:
2081         * DumpRenderTree/mac/DumpRenderTree.mm:
2082         (resetDefaultsToConsistentValues):
2083         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2084
2085 2010-02-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2086
2087         Reviewed by Kenneth Rohde Christiansen.
2088
2089         Support frameset flattening
2090         https://bugs.webkit.org/show_bug.cgi?id=32717
2091
2092         Add FrameSet Flattening support to Mac DRT.
2093
2094         * DumpRenderTree/LayoutTestController.cpp:
2095         (setFrameSetFlatteningEnabledCallback):
2096         (LayoutTestController::staticFunctions):
2097         * DumpRenderTree/LayoutTestController.h:
2098         * DumpRenderTree/mac/DumpRenderTree.mm:
2099         (resetDefaultsToConsistentValues):
2100         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2101         (LayoutTestController::setFrameSetFlatteningEnabled):
2102
2103 2010-02-08  Jon Honeycutt  <jhoneycutt@apple.com>
2104
2105         <rdar://problem/7436875> Crash in Flash when visiting
2106         http://www.cctv.com/default.shtml (WER ID 819298200) [watson 2502260]
2107
2108         Reviewed by Darin Adler.
2109
2110         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
2111         (executeScript):
2112         Moved to an earlier point in the file.
2113         (NPP_New):
2114         If the plug-in has an onDestroy attribute, store its value.
2115         (NPP_Destroy):
2116         If the plug-in has code to run on destruction, run it and free it.
2117
2118 2010-02-10  Diego Gonzalez  <diego.gonzalez@openbossa.org>
2119
2120         Reviewed by Kenneth Rohde Christiansen.
2121
2122         Implement pageNumberForElementById() method in Qt DRT LayoutTestController,
2123         to make Qt DRT able to get page number.
2124
2125         LayoutTests:
2126             printing/page-break-always.html
2127             printing/pageNumerForElementById.html
2128             printing/css2.1/page-break-before-000.html
2129             printing/css2.1/page-break-after-000.html
2130             printing/css2.1/page-break-after-004.html
2131             printing/css2.1/page-break-before-001.html
2132             printing/css2.1/page-break-after-001.html
2133             printing/css2.1/page-break-after-002.html
2134             printing/css2.1/page-break-before-002.html
2135             printing/css2.1/page-break-inside-000.html
2136
2137         [Qt] Make possible Qt DRT get a page number for element by ID
2138         https://bugs.webkit.org/show_bug.cgi?id=34777
2139
2140         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2141         (LayoutTestController::pageNumberForElementById):
2142         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2143
2144 2010-02-10  Andras Becsi  <abecsi@webkit.org>
2145
2146         Reviewed by Adam Barth.
2147
2148         Make run-iexploder-tests work on Linux.
2149         https://bugs.webkit.org/show_bug.cgi?id=34748
2150
2151         Extract the platform dependant Apache configuration checking code in httpd.pm to a separate function
2152         called getHTTPDConfigPathForTestDirectory and use run-launcher instead of run-safari if run on Linux.
2153
2154         * Scripts/run-iexploder-tests:
2155         * Scripts/webkitperl/httpd.pm:
2156
2157 2010-02-09  Csaba Osztrogonác  <ossy@webkit.org>
2158
2159         [Qt] Unreviewed. Roll-out r54543, because layout tests crash in debug mode.
2160         https://bugs.webkit.org/show_bug.cgi?id=34713
2161
2162         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2163         (WebCore::WebPage::WebPage):
2164         * DumpRenderTree/qt/main.cpp:
2165         (main):
2166
2167 2010-02-09  Alejandro G. Castro  <alex@igalia.com>
2168
2169         Unreviewed; added myself to committers
2170
2171         * Scripts/webkitpy/committers.py:
2172
2173 2010-02-09  Yael Aharon  <yael.aharon@nokia.com>
2174
2175         Reviewed by Kenneth Rohde Christiansen.
2176
2177         [Qt] Webkit in Qt does not have window.showModalDialog
2178         https://bugs.webkit.org/show_bug.cgi?id=25585
2179
2180         Set the modality flag when createWindow is called with window type WebWindowDialog.
2181
2182         * QtLauncher/main.cpp:
2183         (WebPage::createWindow):
2184
2185 2010-02-09  Andras Becsi  <abecsi@webkit.org>
2186
2187         Unreviewed trivial warning fix.
2188
2189         * Scripts/build-webkit:
2190
2191 2010-02-09 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu>
2192
2193         Reviewed by Tor Arne Vestbø.
2194
2195         Add possibility of passing parameters to build-webkit by environment variable,
2196         because the buildbot slaves can't control the arguments.
2197
2198         * Scripts/build-webkit:
2199
2200 2010-02-09  Chang Shu  <Chang.Shu@nokia.com>
2201
2202         Reviewed by Laszlo Gombos.
2203
2204         [Qt] Enable appcache feature.
2205         https://bugs.webkit.org/show_bug.cgi?id=34713
2206
2207
2208         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2209         (WebCore::WebPage::WebPage):
2210         * DumpRenderTree/qt/main.cpp:
2211         (main):
2212
2213 2010-02-09  Shinichiro Hamaji  <hamaji@chromium.org>
2214
2215         Reviewed by Darin Adler.
2216
2217         Provide a way to get total number of pages to be printed
2218         https://bugs.webkit.org/show_bug.cgi?id=34699
2219
2220         * DumpRenderTree/LayoutTestController.cpp:
2221         (parsePageParameters):
2222         (pageNumberForElementByIdCallback):
2223         (numberOfPagesCallback):
2224         (LayoutTestController::staticFunctions):
2225         * DumpRenderTree/LayoutTestController.h:
2226         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2227         (LayoutTestController::numberOfPages):
2228         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2229         (LayoutTestController::numberOfPages):
2230         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2231         (LayoutTestController::numberOfPages):
2232
2233 2010-02-08  Alexey Proskuryakov  <ap@apple.com>
2234
2235         Reviewed by Darin Adler.
2236
2237         https://bugs.webkit.org/show_bug.cgi?id=34727
2238         Assertion crashes and freezes when plug-in property access results in an exception
2239
2240         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2241         (pluginGetProperty): Raise an exception when accessing a particular property.
2242         (pluginSetProperty): Ditto.
2243         (pluginInvoke): Added methods to get and set host object properties.
2244
2245 2010-02-08  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2246
2247         Reviewed by Ariya Hidayat.
2248
2249         [Qt] Backport No'am Rosenthal's frame rate measurement
2250
2251         * QtLauncher/main.cpp:
2252         (LauncherWindow::LauncherWindow):
2253         (LauncherApplication::handleUserOptions):
2254         * QtLauncher/webview.cpp:
2255         (WebViewGraphicsBased::WebViewGraphicsBased):
2256         (WebViewGraphicsBased::enableFrameRateMeasurement):
2257         (WebViewGraphicsBased::updateFrameRate):
2258         (WebViewGraphicsBased::paintEvent):
2259         * QtLauncher/webview.h:
2260
2261 2010-02-08  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2262
2263         Reviewed by Tor Arne Vestbø.
2264
2265         [Qt] Make overridePreference complain when it does not
2266         support the preference given.
2267
2268         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2269         (LayoutTestController::overridePreference):
2270
2271 2010-02-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2272
2273         Reviewed by Kenneth Rohde Christiansen.
2274
2275         [Qt] Set stdout/stderr to binary mode for DRT on Windows
2276
2277         This makes sure we don't end up with lots of CRLFs in the
2278         DRT output, which breaks tons of results. Matches what
2279         the Windows DRT does.
2280
2281         * DumpRenderTree/qt/main.cpp:
2282
2283 2010-02-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2284
2285         Reviewed by Kenneth Rohde Christiansen.
2286
2287         Build fix for Qt on Windows.
2288
2289         Don't use noreturn directly since it's a gcc attribute.
2290         Instead use the NO_RETURN macro from AlwaysInline.h
2291
2292         * QtLauncher/QtLauncher.pro:
2293         * QtLauncher/utils.h:
2294
2295 2010-02-05  Chris Jerdonek  <cjerdonek@webkit.org>
2296
2297         Reviewed by Shinichiro Hamaji.
2298
2299         Suppressed check-webkit-style's underscore check in Qt's autotests.
2300         Also made the path-specific filter check case-insensitive.
2301
2302         https://bugs.webkit.org/show_bug.cgi?id=34574
2303
2304         * Scripts/webkitpy/style/checker.py:
2305           - Added a list element to _PATH_RULES_SPECIFIER for
2306             directories that should be excluded from the
2307             "readability/naming" category (the category that relates to
2308             underscores in identifiers, for example).
2309
2310         * Scripts/webkitpy/style/checker_unittest.py:
2311           - Added an "end-to-end" test for "WebKit/qt/tests/".
2312
2313         * Scripts/webkitpy/style/filter.py:
2314           - Altered FilterConfiguration's should_check() method to
2315             check for path substring matches case-insensitively.
2316
2317         * Scripts/webkitpy/style/filter_unittest.py:
2318           - Added a test to check case-insensitive path substring matching.
2319
2320         * Scripts/webkitpy/style/processors/cpp.py:
2321           - Removed the hard-coded "WebKit/gtk/webkit/" path reference
2322             since this is now taken care of by the _PATH_RULES_SPECIFIER
2323             configuration variable.
2324
2325         * Scripts/webkitpy/style/processors/cpp_unittest.py:
2326           - Removed the unit test for the GTK directory since this
2327             is now taken care of by the checker._PATH_RULES_SPECIFIER
2328             end-to-end tests.
2329
2330 2010-02-08  Leith Bade  <leith@leithalweapon.geek.nz>
2331
2332         Reviewed by Darin Adler.
2333
2334         Fixes: https://bugs.webkit.org/show_bug.cgi?id=34637
2335         Corrects the newline inserted into WebKitOutputDir, and WebKitLibrariesDir Windows
2336         environemnt variables when there is a space in the user's /home path.
2337
2338         * Scripts/webkitdirs.pm:
2339          - Added missing quotes around $sourceDir in argument list of cygpath in determineWindowsSourceDir().
2340
2341 2010-02-05  Alexey Proskuryakov  <ap@apple.com>
2342
2343         Reviewed by Oliver Hunt.
2344
2345         https://bugs.webkit.org/show_bug.cgi?id=34670
2346         TestNetscapePlugin should work with Firefox
2347
2348         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New): Default to Carbon if
2349         browser doesn't tell what it supports.
2350
2351 2010-02-05  Shinichiro Hamaji  <hamaji@chromium.org>
2352
2353         Reviewed by Gustavo Noronha Silva.
2354
2355         [Gtk] Implement layoutTestController.pageNumberForElementById
2356         https://bugs.webkit.org/show_bug.cgi?id=34572
2357
2358         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2359         (LayoutTestController::pageNumberForElementById):
2360
2361 2010-02-03  Dirk Pranke  <dpranke@chromium.org>
2362
2363         Reviewed by Eric Seidel.
2364
2365         Add a simple test implementation and the WebKit Mac implementation
2366         for the layout_tests/port package. Also add a simple test driver of
2367         that interface.
2368
2369         https://bugs.webkit.org/show_bug.cgi?id=34511
2370
2371         * Scripts/webkitpy/layout_tests/driver_test.py: Added.
2372         * Scripts/webkitpy/layout_tests/port/__init__.py:
2373         * Scripts/webkitpy/layout_tests/port/mac.py: Added.
2374         * Scripts/webkitpy/layout_tests/port/test.py: Added.
2375
2376 2010-02-03  Dirk Pranke  <dpranke@chromium.org>
2377
2378         Reviewed by Eric Siedel.
2379
2380         Refactor the port package into an object-oriented style and merge
2381         path_utils into it. We add a 'base' and a 'chromium' object to the
2382         port package; this will allow us to easily add new ports (like
2383         WebKit Mac).
2384
2385         https://bugs.webkit.org/show_bug.cgi?id=34511
2386
2387         * Scripts/rebaseline-chromium-webkit-tests:
2388         * Scripts/run-chromium-webkit-tests:
2389         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2390         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2391         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2392         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
2393         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
2394         * Scripts/webkitpy/layout_tests/port/__init__.py:
2395         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2396         * Scripts/webkitpy/layout_tests/port/base.py: Added.
2397         * Scripts/webkitpy/layout_tests/port/chromium.py: Added.
2398         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2399         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2400         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2401         * Scripts/webkitpy/layout_tests/port/http_server.py:
2402         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
2403         * Scripts/webkitpy/layout_tests/port/path_utils.py: Removed.
2404         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2405         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2406         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
2407         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
2408         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2409         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2410         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2411
2412 2010-01-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2413
2414         Reviewed by Dave Hyatt.
2415
2416         Implement flattening of framesets
2417         https://bugs.webkit.org/show_bug.cgi?id=32717
2418
2419         Add support for testing frame flattening with the Qt DRT
2420
2421         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2422         (LayoutTestController::setFrameSetFlatteningEnabled):
2423         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2424
2425 2010-02-03  Chris Jerdonek  <cjerdonek@webkit.org>
2426
2427         Reviewed by Shinichiro Hamaji.
2428
2429         Provided a way in check-webkit-style to specify filter rules
2430         on a per file or folder basis, via a configuration variable.
2431
2432         https://bugs.webkit.org/show_bug.cgi?id=33684
2433
2434         * Scripts/webkitpy/style/checker.py:
2435           - Added _PATH_RULES_SPECIFIER configuration variable.
2436           - In ProcessorOptions class--
2437             - Changed the CategoryFilter attribute to FilterConfiguration.
2438             - Added path parameter to is_reportable().
2439           - Renamed ArgumentDefaults filter_rules attribute to
2440             base_filter_rules.
2441           - Updated ArgumentPrinter class.
2442           - Added filter rule validation to ArgumentParser (instead of
2443             in CategoryFilter constructor).
2444
2445         * Scripts/webkitpy/style/checker_unittest.py:
2446           - Updated unit tests as necessary.
2447           - Added unit tests for PATH_RULES_SPECIFIER.
2448
2449         * Scripts/webkitpy/style/error_handlers.py:
2450           - Updated DefaultStyleErrorHandler to use file path when
2451             calling is_reportable().
2452
2453         * Scripts/webkitpy/style/error_handlers_unittest.py:
2454           - Updated unit tests as necessary.
2455
2456         * Scripts/webkitpy/style/filter.py:
2457           - Marked CategoryFilter internal with an underscore.
2458           - Removed argument validation from CategoryFilter.
2459           - Added FilterConfiguration class.
2460
2461         * Scripts/webkitpy/style/filter_unittest.py:
2462           - Updated CategoryFilterTest class.
2463           - Added FilterConfigurationTest unit tests.
2464
2465         * Scripts/webkitpy/style/processors/cpp.py:
2466           - Removed _is_test_filename() code.
2467           - Removed hard-coded path checks from check_include_line().
2468
2469         * Scripts/webkitpy/style/processors/cpp_unittest.py:
2470           - Removed three unit tests related to exempted files.
2471
2472 2010-02-05  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2473
2474         Reviewed by Ariya Hidayat.
2475
2476         [Qt] Apply the command line options as settings to the
2477         graphics system.
2478
2479         * QtLauncher/main.cpp:
2480         (LauncherWindow::LauncherWindow):
2481         (requiresGraphicsView):
2482         (LauncherApplication::handleUserOptions):
2483         * QtLauncher/webview.h:
2484         (WebViewGraphicsBased::setItemCacheMode):
2485
2486 2010-02-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2487
2488         Reviewed by Simon Hausmann.
2489
2490         Notify user that run-webkit-tests has to be run under Cygwin
2491
2492         The script will bail out if run under Windows shell or Msys.
2493
2494         * Scripts/run-webkit-tests:
2495         * Scripts/webkitdirs.pm:
2496
2497 2010-02-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2498
2499         Reviewed by Simon Hausmann.
2500
2501         [Qt] Generate convenience headers (QWebView, etc) using qmake
2502
2503         In Qt this is done using syncqt, but we use a pro-file instead
2504         that generates makefile-rules for each of the extra headers.
2505
2506         These extra headers are installed alongside the normal headers.
2507
2508         * Scripts/webkitdirs.pm: Run qmake and make on new API-DerivedSources
2509
2510 2010-02-05  Andras Becsi  <abecsi@webkit.org>
2511
2512         Unreviewed typo fix.
2513
2514         Fix wrong whitespace alignment introduced in r54342.
2515
2516         * Scripts/run-webkit-tests:
2517
2518 2010-02-04  Mark Rowe  <mrowe@apple.com>
2519
2520         Reviewed by Timothy Hatcher.
2521
2522         Build fix.  Remove a symbol corresponding to an inline function from the linker export
2523         file to prevent a weak external failure.
2524
2525         * Scripts/check-for-weak-vtables-and-externals: Renamed from WebKitTools/Scripts/check-for-weak-vtables.
2526         Teach the script how to detect weak external symbols so that these errors can be caught immediately
2527         in the future.
2528
2529 2010-02-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2530
2531         Rubberstamped by Oliver Hunt.
2532
2533         [Qt] Make it possible to choose whether the launcher should
2534         use the traditional QWidget based QWebView or the newer
2535         QGraphics based QGraphicsWebView on a QGraphicsView.
2536
2537         * QtLauncher/main.cpp:
2538         (LauncherWindow::LauncherWindow):
2539         (LauncherWindow::eventFilter):
2540         (LauncherWindow::loadStarted):
2541         (LauncherWindow::print):
2542         (LauncherWindow::screenshot):
2543         (LauncherWindow::setEditable):
2544         (LauncherWindow::setupUI):
2545         (main):
2546         * QtLauncher/webview.cpp:
2547         (WebViewGraphicsBased::WebViewGraphicsBased):
2548         (WebViewGraphicsBased::resizeEvent):
2549         (GraphicsWebView::mousePressEvent):
2550         (GraphicsWebView::contextMenuEvent):
2551         * QtLauncher/webview.h:
2552         (WebViewTraditional::WebViewTraditional):
2553         (GraphicsWebView::GraphicsWebView):
2554         (WebViewGraphicsBased::setPage):
2555
2556 2010-02-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2557
2558         Rubberstamped by Oliver Hunt.
2559
2560         [Qt] QtLauncher cleanup.
2561
2562         Refactor option handling out in utility functions and make the
2563         arguments more Qt compatible.
2564
2565         * QtLauncher/main.cpp:
2566         (requiresGraphicsView):
2567         (LauncherApplication::handleUserOptions):
2568         * QtLauncher/utils.cpp:
2569         (takeOptionValue):
2570         (formatKeys):
2571         (enumToKeys):
2572         (appQuit):
2573         * QtLauncher/utils.h:
2574
2575 2010-02-04  Andras Becsi  <abecsi@inf.u-szeged.hu>
2576
2577         Reviewed by Tor Arne Vestbø.
2578
2579         Implement a locking and scheduling mechanism for http testing sessions to be able
2580         to run multiple instances of run-webkit-tests parallel on the same machine.
2581         If a test session wants to run http tests and this feature is enabled, the pending
2582         sessions create lockfiles with sequential lock numbers. These locks are used to schedule
2583         the running test sessions in first come first served order. An exclusive lock ensures
2584         that the lock numbers are sequential to avoid deadlocks and starvation.
2585         Because the buildbot master specifies the flags used by slaves we need an environment
2586         variable too to be able to use the feature per-slave.
2587         Exporting WEBKIT_WAIT_FOR_HTTPD=1 before testing or using the --wait-for-httpd
2588         flag enables this feature, otherwise this patch has no effect on the testing whatsoever.
2589
2590         https://bugs.webkit.org/show_bug.cgi?id=33153
2591
2592         * Scripts/run-webkit-tests:
2593         * Scripts/webkitperl/httpd.pm:
2594
2595 2010-01-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2596
2597         Reviewed by Simon Hausmann.
2598
2599         Make run-webkit-tests work under Cygwin for the Qt port
2600
2601         setPathForRunningWebKitApp() is implemented for the Qt port
2602         by using qmake to query for the location of the Qt libraries.
2603
2604         This requires the original environment (%ENV) to be untouched,
2605         so launchWithCurrentEnv() was refactored to launchWithEnv(),
2606         and the code in openDumpTool() to not use %ENV but a %CLEAN_ENV
2607         instead. This has the added benefit of getting rid of the temp
2608         variables used for storing the current env.
2609
2610         openDumpTool() is also refactored a bit into platform-spesific,
2611         port-spesific, and generic environment variables.
2612
2613         Checks for undef was added a few places to fix Perl concat
2614         warnings when run-webkit-tests is aborted.
2615
2616         https://bugs.webkit.org/show_bug.cgi?id=33895
2617
2618         * Scripts/run-webkit-tests:
2619         * Scripts/webkitdirs.pm:
2620
2621 2010-02-04  Yuzo Fujishima  <yuzo@google.com>
2622
2623         Unreviewed.
2624
2625         Add Yuzo to the committers list.
2626
2627         * Scripts/webkitpy/committers.py:
2628
2629 2010-02-03  Dirk Pranke  <dpranke@chromium.org>
2630
2631         Rubber-stamped by Eric Seidel.
2632
2633         Change "the Chromium name" to "the name of Google Inc." in the licenses
2634
2635         https://bugs.webkit.org/show_bug.cgi?id=34511
2636
2637         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2638         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2639         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
2640         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2641         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2642         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
2643         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
2644         * Scripts/webkitpy/layout_tests/port/__init__.py:
2645         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2646         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2647         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2648         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2649         * Scripts/webkitpy/layout_tests/port/http_server.py:
2650         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
2651         * Scripts/webkitpy/layout_tests/port/path_utils.py:
2652         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2653         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2654         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
2655         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
2656         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2657         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2658         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2659
2660 2010-02-03  Dirk Pranke  <dpranke@chromium.org>
2661
2662         Rubber-stamped by Eric Siedel.
2663
2664         Rename files as part of refactoring the layout_tests package. All
2665         the platform_utils* module, the path_utils.py module, and
2666         the http server and web socket server modules are moved into a new
2667         port/ package.
2668
2669         https://bugs.webkit.org/show_bug.cgi?id=34511
2670
2671         * Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py: Removed.
2672         * Scripts/webkitpy/layout_tests/layout_package/http_server.py: Removed.
2673         * Scripts/webkitpy/layout_tests/layout_package/http_server_base.py: Removed.
2674         * Scripts/webkitpy/layout_tests/layout_package/httpd2.pem: Removed.
2675         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2676         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2677         * Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf: Removed.
2678         * Scripts/webkitpy/layout_tests/layout_package/path_utils.py: Removed.
2679         * Scripts/webkitpy/layout_tests/layout_package/platform_utils.py: Removed.
2680         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py: Removed.
2681         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py: Removed.
2682         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py: Removed.
2683         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2684         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
2685         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
2686         * Scripts/webkitpy/layout_tests/layout_package/websocket_server.py: Removed.
2687         * Scripts/webkitpy/layout_tests/port: Added.
2688         * Scripts/webkitpy/layout_tests/port/__init__.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils.py.
2689         * Scripts/webkitpy/layout_tests/port/apache_http_server.py: Copied from Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py.
2690         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py.
2691         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py.
2692         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py.
2693         * Scripts/webkitpy/layout_tests/port/http_server.py: Copied from Scripts/webkitpy/layout_tests/layout_package/http_server.py.
2694         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Copied from Scripts/webkitpy/layout_tests/layout_package/http_server_base.py.
2695         * Scripts/webkitpy/layout_tests/port/httpd2.pem: Copied from Scripts/webkitpy/layout_tests/layout_package/httpd2.pem.
2696         * Scripts/webkitpy/layout_tests/port/lighttpd.conf: Copied from Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf.
2697         * Scripts/webkitpy/layout_tests/port/path_utils.py: Copied from Scripts/webkitpy/layout_tests/layout_package/path_utils.py.
2698         * Scripts/webkitpy/layout_tests/port/websocket_server.py: Copied from Scripts/webkitpy/layout_tests/layout_package/websocket_server.py.
2699         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2700         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
2701         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
2702         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2703         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2704         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2705
2706
2707 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
2708
2709         Rubber-stamped by Eric Seidel.
2710
2711         Roll back r53559 and r54084 again, because roll out didn't solve flakeyness on the Windows Test bots
2712         https://bugs.webkit.org/show_bug.cgi?id=34399
2713
2714         * Scripts/run-iexploder-tests:
2715         * Scripts/run-webkit-httpd:
2716         * Scripts/run-webkit-tests:
2717         * Scripts/webkitperl/httpd.pm: Added.
2718
2719 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
2720
2721         Rubber-stamped by Eric Seidel.
2722
2723         Roll out r53559 and r54084, because it might caused flakeyness on the Windows Test bots
2724
2725         * Scripts/run-iexploder-tests:
2726         * Scripts/run-webkit-httpd:
2727         * Scripts/run-webkit-tests:
2728         * Scripts/webkitperl/httpd.pm: Removed.
2729
2730 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
2731
2732         Rubber-stamped by Ariya Hidayat.
2733
2734         Roll back r53889 again, because roll out didn't solve flakeyness on the Windows Test bots
2735         https://bugs.webkit.org/show_bug.cgi?id=34399
2736
2737         * DumpRenderTree/win/EventSender.cpp:
2738         (buildModifierFlags):
2739         (mouseDownCallback):
2740         (mouseUpCallback):
2741         (keyDownCallback):
2742
2743 2010-02-03  Eric Seidel  <eric@webkit.org>
2744
2745         No review, just fixing copyrights.
2746
2747         Concerns were expressed about "The Chromium Authors" being
2748         a valid legal entity for copyright assignment in the WebKit repository,
2749         so this change removes all "The Chromium Authors".
2750
2751         I looked at the svn logs in src.chromium.org and failed to find any
2752         non-google contributions to these files, so they are all now
2753         marked as copyright "Google Inc" as all Google contributers assign
2754         copyright to "Google Inc" as part of their employment agreement.
2755
2756         * Scripts/rebaseline-chromium-webkit-tests:
2757         * Scripts/run-chromium-webkit-tests:
2758         * Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py:
2759         * Scripts/webkitpy/layout_tests/layout_package/http_server.py:
2760         * Scripts/webkitpy/layout_tests/layout_package/http_server_base.py:
2761         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2762         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2763         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
2764         * Scripts/webkitpy/layout_tests/layout_package/path_utils.py:
2765         * Scripts/webkitpy/layout_tests/layout_package/platform_utils.py:
2766         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py:
2767         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py:
2768         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py:
2769         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2770         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2771         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
2772         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
2773         * Scripts/webkitpy/layout_tests/layout_package/websocket_server.py:
2774         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2775         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
2776         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
2777         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2778         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2779         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2780
2781 2010-02-03  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2782
2783         Reviewed by Ariya Hidayat.
2784
2785         [Qt] QtLauncher, refactor argument handling in preparation of merge
2786         with QGVLauncher
2787
2788         * QtLauncher/main.cpp:
2789         (LauncherApplication::urls):
2790         (LauncherApplication::isRobotized):
2791         (LauncherApplication::applyDefaultSettings):
2792         (LauncherApplication::LauncherApplication):
2793         (LauncherApplication::formatKeys):
2794         (LauncherApplication::enumToKeys):
2795         (fail):
2796         (LauncherApplication::handleUserOptions):
2797         (main):
2798
2799 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
2800
2801         Rubber-stamped by Ariya Hidayat.
2802
2803         Rolling out r53889, because it might caused flakeyness on the Windows Test bots
2804         https://bugs.webkit.org/show_bug.cgi?id=34399
2805
2806         * DumpRenderTree/win/EventSender.cpp:
2807         (mouseDownCallback):
2808         (mouseUpCallback):
2809         (keyDownCallback):
2810
2811 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
2812
2813         Reviewed by Ariya Hidayat.
2814
2815         [Qt] Fix pixel tests support.
2816         https://bugs.webkit.org/show_bug.cgi?id=27813
2817
2818         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2819         (WebCore::DumpRenderTree::open):
2820         (WebCore::DumpRenderTree::processLine):
2821          - Hash processing mechanism moved from DumpRenderTree::open to DumpRenderTree::processLine.
2822         (WebCore::DumpRenderTree::dump): Fixed and renamed variables.
2823
2824 2010-02-03  Kevin Watters  <kevinwatters@gmail.com>
2825
2826         Reviewed by Kevin Ollivier.
2827
2828         [wx] Enable JIT compilation for wx.
2829         
2830         https://bugs.webkit.org/show_bug.cgi?id=34536
2831
2832         * wx/build/settings.py:
2833
2834 2010-02-02  Kevin Ollivier  <kevino@theolliviers.com>
2835
2836         [wx] Build fix after introduction of pageNumberForElementById.
2837
2838         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2839         (LayoutTestController::pageNumberForElementById):
2840
2841 2010-02-02  Shu Chang  <Chang.Shu@nokia.com>
2842
2843         Unreviewed.
2844
2845         Add myself to list of committers.
2846
2847         * Scripts/webkitpy/committers.py:
2848
2849 2010-02-02  Chris Jerdonek  <cjerdonek@webkit.org>
2850
2851         Reviewed by Shinichiro Hamaji.
2852
2853         Moved filter-related check-webkit-style code into a separate
2854         filter module.
2855
2856         https://bugs.webkit.org/show_bug.cgi?id=34408
2857
2858         This is preparatory refactoring for Bug 33684, which will allow
2859         file and folder-specific filter rules.
2860
2861         * Scripts/webkitpy/style/checker.py:
2862           - Removed CategoryFilter class (moved to filter.py).
2863
2864         * Scripts/webkitpy/style/checker_unittest.py:
2865           - Removed CategoryFilter unit tests (moved to filter_unittest.py).
2866
2867         * Scripts/webkitpy/style/filter.py: Added.
2868           - Added CategoryFilter class (moved from checker.py).
2869
2870         * Scripts/webkitpy/style/filter_unittest.py: Added.
2871           - Added CategoryFilter unit tests (moved from checker_unittest.py).
2872
2873         * Scripts/webkitpy/style/unittests.py:
2874           - Added reference to filter_unittest.py.
2875
2876 2010-02-01  Chris Jerdonek  <cjerdonek@webkit.org>
2877
2878         Reviewed by Shinichiro Hamaji.
2879
2880         Addressed FIXME in check-webkit-style so that the carriage-return
2881         check will work for patches.
2882
2883         https://bugs.webkit.org/show_bug.cgi?id=34260
2884
2885         Also added support for limiting the number of errors reported
2886         per category, per file.
2887
2888         * Scripts/webkitpy/style/checker.py:
2889           - Added new "whitespace/carriage_return" category from common.py.
2890           - Added MAX_REPORTS_PER_CATEGORY dictionary.
2891           - Added max_reports_per_category attribute to ProcessorOptions class.
2892           - Refactored StyleChecker._process_file().
2893
2894         * Scripts/webkitpy/style/checker_unittest.py:
2895           - Updated ProcessorOptionsTest tests.
2896           - Added test to check MAX_REPORTS_PER_CATEGORY.
2897
2898         * Scripts/webkitpy/style/error_handlers.py:
2899           - Added support for suppressing the display of errors after
2900             reaching a per-category maximum (from max_reports_per_category).
2901
2902         * Scripts/webkitpy/style/error_handlers_unittest.py:
2903           - Added test for suppressing error display.
2904
2905         * Scripts/webkitpy/style/processors/common.py: Added.
2906           - Moved carriage-return check to new file.
2907
2908         * Scripts/webkitpy/style/processors/common_unittest.py: Added.
2909           - Added unit tests for carriage-return check.
2910
2911         * Scripts/webkitpy/style/unittests.py:
2912           - Added reference to common_unittest.py.
2913
2914 2010-02-01  Shinichiro Hamaji  <hamaji@chromium.org>
2915
2916         Reviewed by Eric Seidel.
2917
2918         Provide a way to get page number with layoutTestController
2919         https://bugs.webkit.org/show_bug.cgi?id=33840
2920
2921         * DumpRenderTree/LayoutTestController.cpp:
2922         (pageNumberForElementByIdCallback):
2923         (LayoutTestController::staticFunctions):
2924         * DumpRenderTree/LayoutTestController.h:
2925         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2926         (LayoutTestController::pageNumberForElementById):
2927         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2928         (LayoutTestController::pageNumberForElementById):
2929         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2930         (LayoutTestController::pageNumberForElementById):
2931
2932 2010-02-01  Shinichiro Hamaji  <hamaji@chromium.org>
2933
2934         Unreviewed fix for an invalid function call.
2935
2936         check-webkit-style: Remove filename parameter from all functions where no longer used
2937         https://bugs.webkit.org/show_bug.cgi?id=34249
2938
2939         * Scripts/webkitpy/style/checker.py:
2940
2941 2010-02-01  Diego Gonzalez  <diego.gonzalez@openbossa.org>
2942
2943         Reviewed by Kenneth Rohde Christiansen.
2944
2945         [Qt] DRT Provide global flag ability
2946         https://bugs.webkit.org/show_bug.cgi?id=34418
2947
2948         Add the globalFlag property to the Qt LayoutTestController to allow
2949         cross-domain indications.
2950
2951         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2952         (LayoutTestController::reset):
2953         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2954         (LayoutTestController::globalFlag):
2955         (LayoutTestController::setGlobalFlag):
2956
2957 2010-02-01  Brady Eidson  <beidson@apple.com>
2958
2959         Reviewed by Adele Peterson.
2960
2961         Crash in Safari opening new tabs to "same page"
2962         <rdar://problem/7593857> and https://bugs.webkit.org/show_bug.cgi?id=34444
2963
2964         Add a mode (Mac-only for now) that exercises the WebView SPI _loadBackForwardListFromOtherView:
2965
2966         * DumpRenderTree/LayoutTestController.cpp:
2967         (LayoutTestController::LayoutTestController):
2968         (setNewWindowsCopyBackForwardListCallback):
2969         (LayoutTestController::staticFunctions):
2970
2971         * DumpRenderTree/LayoutTestController.h:
2972         (LayoutTestController::newWindowsCopyBackForwardList):
2973         (LayoutTestController::setNewWindowsCopyBackForwardList):
2974
2975         * DumpRenderTree/mac/UIDelegate.mm:
2976         (-[UIDelegate webView:createWebViewWithRequest:]):
2977
2978 2010-02-01  Carol Szabo  <carol.szabo@nokia.com>
2979
2980         Unreviewed.
2981
2982         Add myself to list of committers.
2983
2984         * Scripts/webkitpy/committers.py:
2985
2986 2010-02-01  Nate Chapin  <japhet@chromium.org>
2987
2988         Rubber-stamped by David Levin.
2989
2990         Add myself to reviewer list.
2991
2992         * Scripts/webkitpy/committers.py:
2993
2994 2010-01-31  Chris Jerdonek  <cjerdonek@webkit.org>
2995
2996         Reviewed by Shinichiro Hamaji.
2997
2998         Moved style error handler code to their own classes, and
2999         related refactoring. Increased unit test code coverage of
3000         style error handling.
3001
3002         https://bugs.webkit.org/show_bug.cgi?id=34379
3003
3004         * Scripts/check-webkit-style:
3005           - Minor change: added error_count variable.
3006
3007         * Scripts/webkitpy/style/checker.py:
3008           - Renamed ProcessorOptions.should_report_error() to is_reportable().
3009           - In the StyleChecker class--
3010             - Removed _default_style_error_handler().
3011             - Added _increment_error_count().
3012             - Refactored to use DefaultStyleErrorHandler and
3013               PatchStyleErrorHandler constructors.
3014
3015         * Scripts/webkitpy/style/checker_unittest.py:
3016           - In the StyleStyleCheckerTest class--
3017             - Removed write_sample_error().
3018             - Removed test_default_style_error_handler().
3019
3020         * Scripts/webkitpy/style/error_handlers.py: Added.
3021           - Added DefaultStyleErrorHandler class.
3022           - Added PatchStyleErrorHandler class.
3023
3024         * Scripts/webkitpy/style/error_handlers_unittest.py: Added.
3025           - Added unit tests for DefaultStyleErrorHandler and
3026             PatchStyleErrorHandler.
3027
3028         * Scripts/webkitpy/style/unittests.py:
3029           - Added error_handlers unit tests.
3030
3031 2010-01-29  Mark Rowe  <mrowe@apple.com>
3032
3033         Rubber-stamped by Stephanie Lewis.
3034
3035         Fix run-leaks with newer versions of the leaks tool.
3036
3037         * Scripts/run-leaks:
3038
3039 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
3040
3041         Reviewed by Eric Siedel.
3042
3043         Top-level test drivers for running the Chromium port of run-webkit-tests
3044         and being able to rebaseline test results from the test bots.  The
3045         files in the Scripts directory are simply wrappers around the files
3046         in webkitpy/layout_tests for convenience.
3047  
3048         https://bugs.webkit.org/show_bug.cgi?id=31498
3049
3050         * Scripts/rebaseline-chromium-webkit-tests: Added.
3051         * Scripts/run-chromium-webkit-tests: Added.
3052         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Added.
3053         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py: Added.
3054
3055 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
3056
3057         Reviewed by Eric Siedel.
3058
3059         Add in the second block of python code for the Chromium port
3060         of run-webkit-tests. These files execute different diffs to classify
3061         the various types of failures from a test.
3062
3063         * Scripts/webkitpy/layout_tests/test_types: Added.
3064         * Scripts/webkitpy/layout_tests/test_types/__init__.py: Added.
3065         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Added.
3066         * Scripts/webkitpy/layout_tests/test_types/image_diff.py: Added.
3067         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: Added.
3068         * Scripts/webkitpy/layout_tests/test_types/text_diff.py: Added.
3069
3070 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
3071
3072         Reviewed by Eric Siedel.
3073
3074         Check in the first part of the Chromium Python port of the 
3075         run-webkit-tests test driver. The files under 
3076         layout_tests/layout_layout constitute most of the implementation;
3077         they can be roughly divided into code that parses the 
3078         "test_expectations.txt" file that describes how we expect tests to
3079         pass or fail, platform-specific hooks for the different Chromium 
3080         ports (in platform_utils*), code for parsing the output of the
3081         tests and generating results files and HTML and JSON for the
3082         dashboards, auxiliary scripts for starting and stopping HTTP and
3083         Web Socket servers, and then one of the actual driver files 
3084         (test_shell_thread). Code for actually parsing test output for 
3085         failures and the top-level driver scripts will follow shortly.
3086
3087         https://bugs.webkit.org/show_bug.cgi?id=31498
3088
3089         * Scripts/webkitpy/layout_tests: Added.
3090         * Scripts/webkitpy/layout_tests/layout_package: Added.
3091         * Scripts/webkitpy/layout_tests/layout_package/__init__.py: Added.
3092         * Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py: Added.
3093         * Scripts/webkitpy/layout_tests/layout_package/http_server.py: Added.
3094         * Scripts/webkitpy/layout_tests/layout_package/http_server_base.py: Added.
3095         * Scripts/webkitpy/layout_tests/layout_package/httpd2.pem: Added.
3096           - scripts to start and stop apache. Note that the apache file
3097             generates a conf file dynamically, and we should switch to 
3098             using the same static conf file that the regular run-webkit-tests
3099             uses, and we can also use the same httpd2.pem file.
3100
3101         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: Added.
3102         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: Added.
3103           - scripts to generate the JSON layout test dashboard and the
3104             flakiness dashboard
3105         * Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf: Added.
3106           - default configuration for LigHTTPd (used on Windows)
3107         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py: Added.
3108           - utility class that implements progress bars on the console to
3109             be displayed while the tests are running
3110         * Scripts/webkitpy/layout_tests/layout_package/path_utils.py: Added.
3111           - various routines for manipulating paths and URIs
3112         * Scripts/webkitpy/layout_tests/layout_package/platform_utils.py: Added.
3113         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py: Added.
3114         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py: Added.
3115         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py: Added.
3116           - platform-specific aspects of the drivers (binary names, paths,
3117             process control, etc.)
3118         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Added.
3119           - code for parsing the 'test_expectations.txt' file to determine
3120             which tests are expected to fail (and how) on which platforms
3121         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: Added.
3122           - code for handling different kinds of failures (generating output
3123             in the results, etc.)
3124         * Scripts/webkitpy/layout_tests/layout_package/test_files.py: Added.
3125           - code to gather the lists of tests
3126         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py: Added.
3127           - code to actually execute tests via TestShell and process
3128             the output
3129         * Scripts/webkitpy/layout_tests/layout_package/websocket_server.py: Added.
3130           - scripts to start and stop the pywebsocket server
3131
3132 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
3133
3134         Reviewed by Eric Seidel.
3135
3136         Check in a copy of the simplejson library; it will be used by
3137         the Chromium port of run-webkit-tests.
3138         
3139         https://bugs.webkit.org/show_bug.cgi?id=31498
3140
3141         * simplejson: Added.
3142         * simplejson/LICENSE.txt: Added.
3143         * simplejson/README.txt: Added.
3144         * simplejson/__init__.py: Added.
3145         * simplejson/_speedups.c: Added.
3146         (ascii_escape_char):
3147         (ascii_escape_unicode):
3148         (ascii_escape_str):
3149         (py_encode_basestring_ascii):
3150         (init_speedups):
3151         * simplejson/decoder.py: Added.
3152         * simplejson/encoder.py: Added.
3153         * simplejson/jsonfilter.py: Added.
3154         * simplejson/scanner.py: Added.
3155
3156 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
3157
3158         No review
3159
3160         Add myself to the committers list
3161
3162         * Scripts/webkitpy/committers.py:
3163
3164 2010-01-29  Jeremy Orlow  <jorlow@chromium.org>
3165
3166         Reviewed by Dimitri Glazkov.
3167
3168         A first step towards the Indexed Database API
3169         https://bugs.webkit.org/show_bug.cgi?id=34342
3170
3171         Add indexed database API.
3172
3173         * Scripts/build-webkit:
3174
3175 2010-01-29  Andras Becsi  <abecsi@webkit.org>
3176
3177         Reviewed by Alexey Proskuryakov.
3178
3179         Correct openHTTPD() to print requests to stdout if run-webkit-httpd is used.
3180         This fixes a regression introduced in r53559.
3181
3182         https://bugs.webkit.org/show_bug.cgi?id=34336
3183
3184         * Scripts/webkitperl/httpd.pm:
3185
3186 2010-01-28  Jon Honeycutt  <jhoneycutt@apple.com>
3187
3188         MSAA: Crash when posting a notification for a detached object
3189
3190         https://bugs.webkit.org/show_bug.cgi?id=34309
3191         <rdar://problem/7409759>
3192
3193         Reviewed by Darin Adler.
3194
3195         * DumpRenderTree/AccessibilityController.h:
3196         Declare new functions. Add new members to store the event hook and the
3197         mapping of accessibility elements to their JS callbacks.
3198
3199         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3200         (AccessibilityController::notificationReceived):
3201         Stubbed.
3202         (AccessibilityController::addNotificationListener):
3203         Stubbed.
3204
3205         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3206         (AccessibilityController::notificationReceived):
3207         Stubbed.
3208         (AccessibilityController::addNotificationListener):
3209         Stubbed.
3210
3211         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3212         (AccessibilityController::AccessibilityController):
3213         Initialize the event hook.
3214         (AccessibilityController::~AccessibilityController):
3215         Remove the event hook. Unprotect all of the JS functions that are stored
3216         in the map.
3217         (logEventProc):
3218         Clean-up a variable.
3219         (stringEvent):
3220         Return a string description of the MSAA event code.
3221         (notificationListenerProc):
3222         Get the accessible object from the event, and query it for IAccessible.
3223         Call the AccessibilityController's notificationReceived().
3224         (comparableObject):
3225         Use QueryService to obtain the IAccessibleComparable for the
3226         IServiceProvider.
3227         (AccessibilityController::notificationReceived):
3228         Iterate the map of objects that have registered for notification
3229         callbacks. Query each for IServiceProvider, then use comparableObject()
3230         to get an IAccessibleComparable. If we find an object matching the
3231         notified object, call its callback, passing the event that was received.
3232         (AccessibilityController::addNotificationListener):
3233         If we have not created the event hook, create it. Protect the JS
3234         callback function object, and add the object and its callback to our
3235         map.
3236
3237         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3238         (AccessibilityUIElement::addNotificationListener):
3239         Call through to the AccessibilityController's addNotificationListener().
3240
3241         * DumpRenderTree/win/DumpRenderTreeWin.h:
3242         Add an extern declaration for the shared FrameLoadDelegate extern, so we
3243         can access it from AccessibilityController.
3244
3245         * DumpRenderTree/win/FrameLoadDelegate.h:
3246         (FrameLoadDelegate::accessibilityController):
3247         Return the AccessibilityController.
3248
3249 2010-01-29  Shinichiro Hamaji  <hamaji@chromium.org>
3250
3251         Reviewed by Darin Adler.
3252
3253         prepare-ChangeLog outputs useless messages for a nonexistent bug ID
3254         https://bugs.webkit.org/show_bug.cgi?id=34313
3255
3256         * Scripts/prepare-ChangeLog:
3257
3258 2010-01-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3259
3260         Rubberstamped by Simon Hausmann.
3261
3262         [Qt] Separate implementation from class definition.
3263
3264         * QtLauncher/main.cpp:
3265         (LauncherWindow::webView):
3266         (LauncherWindow::LauncherWindow):
3267         (LauncherWindow::~LauncherWindow):
3268         (LauncherWindow::keyPressEvent):
3269         (LauncherWindow::grabZoomKeys):
3270         (LauncherWindow::sendTouchEvent):
3271         (LauncherWindow::eventFilter):
3272         (LauncherWindow::loadStarted):
3273         (LauncherWindow::loadFinished):
3274         (LauncherWindow::showLinkHover):
3275         (LauncherWindow::zoomIn):
3276         (LauncherWindow::zoomOut):
3277         (LauncherWindow::resetZoom):
3278         (LauncherWindow::toggleZoomTextOnly):
3279         (LauncherWindow::print):
3280         (LauncherWindow::screenshot):
3281         (LauncherWindow::setEditable):
3282         (LauncherWindow::dumpHtml):
3283         (LauncherWindow::selectElements):
3284         (LauncherWindow::setTouchMocking):
3285         (LauncherWindow::newWindow):
3286         (LauncherWindow::setupUI):
3287
3288 2010-01-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3289
3290         Reviewed by Ariya Hidayat.
3291
3292         [Qt] On Maemo5, a click/touch in the location bar (when unfocused)
3293         should result in all text selected.
3294
3295         * QtLauncher/locationedit.cpp:
3296         (LocationEdit::focusInEvent):
3297         * QtLauncher/locationedit.h:
3298
3299 2010-01-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3300
3301         Reviewed by Ariya Hidayat.
3302
3303         [Qt] Show progress reaching 100% for loads.
3304
3305         * QtLauncher/locationedit.cpp:
3306         (LocationEdit::LocationEdit):
3307         (LocationEdit::setProgress):
3308         (LocationEdit::reset):
3309         (LocationEdit::paintEvent):
3310         * QtLauncher/locationedit.h:
3311
3312 2010-01-29  Andreas Kling  <andreas.kling@nokia.com>
3313
3314         Reviewed by Kenneth Rohde Christiansen.
3315
3316         [Qt] Disable the QtLauncher statusbar on Maemo
3317
3318         https://bugs.webkit.org/show_bug.cgi?id=34330
3319
3320         * QtLauncher/main.cpp:
3321         (LauncherWindow::showLinkHover):
3322         (LauncherWindow::selectElements):
3323
3324 2010-01-29  Andreas Kling  <andreas.kling@nokia.com>
3325
3326         Reviewed by Kenneth Rohde Christiansen.
3327
3328         [Qt] Display page loading progress inside the QtLauncher location bar
3329
3330         https://bugs.webkit.org/show_bug.cgi?id=34210
3331
3332         * QtLauncher/QtLauncher.pro:
3333         * QtLauncher/locationedit.cpp: Added.
3334         (LocationEdit::LocationEdit):
3335         (LocationEdit::setProgress):
3336         (LocationEdit::paintEvent):
3337         * QtLauncher/locationedit.h: Added.
3338         * QtLauncher/mainwindow.cpp:
3339         (MainWindow::buildUI):
3340         * QtLauncher/mainwindow.h:
3341
3342 2010-01-29  Andreas Kling  <andreas.kling@nokia.com>
3343
3344         Reviewed by Kenneth Rohde Christiansen.
3345
3346         [Qt] Add support for Maemo zoom keys in QtLauncher
3347
3348         https://bugs.webkit.org/show_bug.cgi?id=34160
3349
3350         * QtLauncher/main.cpp:
3351         (LauncherWindow::LauncherWindow):
3352         (LauncherWindow::~LauncherWindow):
3353         (LauncherWindow::keyPressEvent):
3354         (LauncherWindow::grabZoomKeys):
3355
3356 2010-01-29  Benjamin Poulain  <benjamin.poulain@nokia.com>
3357
3358         Reviewed by Kenneth Rohde Christiansen.
3359
3360         [Qt] Implement the display() method of the layout test controller
3361         https://bugs.webkit.org/show_bug.cgi?id=34258
3362
3363         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3364         (WebCore::DumpRenderTree::DumpRenderTree):
3365         (WebCore::DumpRenderTree::showPage):
3366         (WebCore::DumpRenderTree::hidePage):
3367         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3368         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3369         (LayoutTestController::reset):
3370         (LayoutTestController::display):
3371         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3372
3373 2010-01-28  Kevin Ollivier  <kevino@theolliviers.com>
3374
3375         [wx] Build fix for MSW, use ThreadingWin.cpp as the Windows pthreads implementation
3376         implements pthread_t in a way that makes it impossible to check its validity,
3377         which is needed by ThreadingPthreads.cpp.
3378
3379         * DumpRenderTree/wscript:
3380         * wx/build/settings.py:
3381
3382 2010-01-28  Andras Becsi  <abecsi@webkit.org>
3383
3384         Adding myself to the committer list. No review needed.
3385
3386         * Scripts/webkitpy/committers.py:
3387
3388 2010-01-28  Hayato Ito  <hayato@chromium.org>
3389
3390         Reviewed by David Levin.
3391
3392         Remove NULL char from input JS file because 'grep' fails if the file contains NULL char.
3393
3394         https://bugs.webkit.org/show_bug.cgi?id=34252
3395
3396         * Scripts/make-script-test-wrappers:
3397
3398 2010-01-28  Kevin Ollivier  <kevino@theolliviers.com>
3399
3400         [wx] Build fix after removal of the zlib image decoder.
3401
3402         * wx/build/settings.py:
3403
3404 2010-01-28  Csaba Osztrogonác  <ossy@webkit.org>
3405
3406         [Qt] Unreviewed, roll out r54000.
3407
3408         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3409         (WebCore::DumpRenderTree::DumpRenderTree):
3410         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3411         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3412         (LayoutTestController::reset):
3413         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3414         (LayoutTestController::display):
3415
3416 2010-01-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
3417
3418         Reviewed by Kenneth Rohde Christiansen.
3419
3420         [Qt] Implement the display() method of the layout test controller
3421         https://bugs.webkit.org/show_bug.cgi?id=34258
3422
3423         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3424         (WebCore::DumpRenderTree::DumpRenderTree):
3425         (WebCore::DumpRenderTree::showPage):
3426         (WebCore::DumpRenderTree::hidePage):
3427         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3428         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3429         (LayoutTestController::reset):
3430         (LayoutTestController::display):
3431         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3432
3433 2010-01-28  Chris Jerdonek  <cjerdonek@webkit.org>
3434
3435         Reviewed by Shinichiro Hamaji.
3436
3437         Eliminated the filename parameter from functions in
3438         check-webkit-style's cpp.py where it is no longer used.
3439
3440         https://bugs.webkit.org/show_bug.cgi?id=34249
3441
3442         * Scripts/webkitpy/style/processors/cpp.py:
3443           - Reduced number of occurrences of "filename" variable from
3444             approximately 200 to 120.
3445
3446         * Scripts/webkitpy/style/processors/cpp_unittest.py:
3447           - Refactored unit tests as necessary to accommodate changes to cpp.py.
3448           - Fixed bug in CppStyleTestBase.perform_include_what_you_use()
3449             where the incorrect file extension was getting passed to
3450             cpp_style.check_language().
3451
3452 2010-01-28  Chris Jerdonek  <cjerdonek@webkit.org>
3453
3454         Reviewed by Shinichiro Hamaji.
3455
3456         In check-webkit-style, eliminated the dependency of
3457         processors/cpp_unittest.py on checker.py.
3458
3459         https://bugs.webkit.org/show_bug.cgi?id=34205
3460
3461         * Scripts/webkitpy/style/checker.py:
3462           - Addressed FIXME by removing STYLE_CATEGORIES data.
3463           - Added style_categories().
3464
3465         * Scripts/webkitpy/style/checker_unittest.py:
3466           - Minor changes.
3467
3468         * Scripts/webkitpy/style/processors/cpp.py:
3469           - Added categories attribute to CppProcessor class (data
3470             was originally checker.STYLE_CATEGORIES).
3471
3472         * Scripts/webkitpy/style/processors/cpp_unittest.py:
3473           - Addressed FIXME by eliminating "import" from checker.py.
3474
3475 2010-01-28  Anton Muhin  <antonm@chromium.org>
3476
3477         Reviewed by Shinichiro Hamaji.
3478
3479         Improve treatment of conditions and rest of the line for if, else, switch and alikes
3480         https://bugs.webkit.org/show_bug.cgi?id=34173
3481
3482         * Scripts/webkitpy/style/cpp_style.py:
3483         * Scripts/webkitpy/style/cpp_style_unittest.py:
3484
3485 2010-01-28  Joe Mason  <jmason@rim.com>
3486
3487         Reviewed by Adam Barth.
3488
3489         Limit login retries to 5
3490         https://bugs.webkit.org/show_bug.cgi?id=34193
3491
3492         * Scripts/webkitpy/bugzilla.py:
3493
3494 2010-01-27  Martin Robinson  <mrobinson@webkit.org>
3495
3496         Adding myself to the committer list. No review necessary.
3497
3498         * Scripts/webkitpy/committers.py:
3499
3500 2010-01-27  George Wright  <gwright@rim.com>
3501
3502         Reviewed by Adam Treat.
3503
3504         https://bugs.webkit.org/show_bug.cgi?id=34216
3505
3506         Add missing include for wtf/Platform.h
3507
3508         * DumpRenderTree/AccessibilityController.h:
3509
3510 2010-01-27  Diego Gonzalez  <diego.gonzalez@openbossa.org>
3511
3512         Reviewed by Kenneth Rohde Christiansen.
3513
3514         [Qt] DRT Provide worker thread ability to track counters
3515         https://bugs.webkit.org/show_bug.cgi?id=34221
3516
3517         Implement workerThreadCount() in LayoutTestController of Qt DRT
3518
3519         Tests:
3520         fast/workers/dedicated-worker-lifecycle.html
3521         fast/workers/shared-worker-frame-lifecycle.html
3522         fast/workers/shared-worker-lifecycle.html
3523         fast/workers/worker-lifecycle.html
3524
3525         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3526         (LayoutTestController::workerThreadCount):
3527         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3528
3529 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3530
3531         Rubberstamped by Simon Hausmann.
3532
3533         [Qt] QtLauncher refactoring:
3534
3535         Make the LauncherWindow depend less on the view, so that more
3536         code can be shared in near future.
3537
3538         * QtLauncher/main.cpp:
3539         (LauncherWindow::sendTouchEvent):
3540         (LauncherWindow::loadFinished):
3541         (LauncherWindow::zoomIn):
3542         (LauncherWindow::zoomOut):
3543         (LauncherWindow::resetZoom):
3544         (LauncherWindow::toggleZoomTextOnly):
3545         (LauncherWindow::dumpHtml):
3546         (LauncherWindow::selectElements):
3547         (LauncherWindow::setupUI):
3548
3549 2010-01-27  Kinuko Yasuda  <kinuko@chromium.org>
3550
3551         Reviewed by Eric Seidel.
3552
3553         Correctly handle the KeyLocation argument that has been introduced
3554         recently to test location-dependent key events in EventSender.keyDown.
3555         http://bugs.webkit.org/show_bug.cgi?id=28247
3556
3557         Test: fast/events/keydown-numpad-keys.html
3558
3559         * DumpRenderTree/gtk/EventSender.cpp:
3560         (keyDownCallback):
3561
3562 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3563
3564         Rubberstamped by Simon Hausmann.
3565
3566         [Qt] QtLauncher refactoring:
3567
3568         Move out code from the MainWindow (renamed to LauncherWindow)
3569         that is not depending on the view, and add it to a new class
3570         called MainWindow.
3571
3572         * QtLauncher/QtLauncher.pro:
3573         * QtLauncher/main.cpp:
3574         (LauncherWindow::LauncherWindow):
3575         (LauncherWindow::eventFilter):
3576         (LauncherWindow::loadStarted):
3577         (LauncherWindow::loadFinished):
3578         (LauncherWindow::newWindow):
3579         (LauncherWindow::setupUI):
3580         (WebPage::createWindow):
3581         (main):
3582         * QtLauncher/mainwindow.cpp: Added.
3583         (MainWindow::MainWindow):
3584         (MainWindow::buildUI):
3585         (MainWindow::page):
3586         (MainWindow::setAddressUrl):
3587         (MainWindow::addCompleterEntry):
3588         (MainWindow::load):
3589         (MainWindow::changeLocation):
3590         (MainWindow::openFile):
3591         * QtLauncher/mainwindow.h: Added.
3592
3593 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3594
3595         Rubberstamped by Simon Hausmann.
3596
3597         [Qt] QtLauncher, coding style fixes.
3598
3599         * QtLauncher/main.cpp:
3600         (MainWindow::MainWindow):
3601         (MainWindow::sendTouchEvent):
3602         (MainWindow::eventFilter):
3603         (MainWindow::loadURL):
3604         (MainWindow::setupUI):
3605         (WebPage::createPlugin):
3606
3607 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3608
3609         Rubberstamped by Simon Hausmann.
3610
3611         [Qt] QtLauncher refactoring, separating the webview and
3612         adding a QGraphicsWebView based version.
3613
3614         * QtLauncher/QtLauncher.pro:
3615         * QtLauncher/main.cpp:
3616         (MainWindow::MainWindow):
3617         * QtLauncher/webpage.h:
3618         * QtLauncher/webview.cpp: Added.
3619         (createContextMenu):
3620         (WebViewGraphicsBased::mousePressEvent):
3621         (WebViewTraditional::mousePressEvent):
3622         (WebViewGraphicsBased::contextMenuEvent):
3623         (WebViewTraditional::contextMenuEvent):
3624         * QtLauncher/webview.h: Added.
3625         (WebViewGraphicsBased::WebViewGraphicsBased):
3626         (WebViewTraditional::WebViewTraditional):
3627
3628 2010-01-27  Alexander Pavlov  <apavlov@chromium.org>
3629
3630         Adding myself as committer. No review necessary.
3631
3632         * Scripts/webkitpy/committers.py:
3633
3634 2010-01-27  Eric Seidel  <eric@webkit.org>
3635
3636         Reviewed by Darin Adler.
3637
3638         webkit-patch needs an open-bugs command
3639         https://bugs.webkit.org/show_bug.cgi?id=30793
3640
3641         * Scripts/test-webkitpy: import OpenBugsTest
3642         * Scripts/webkit-patch: import OpenBugs
3643         * Scripts/webkitpy/commands/download_unittest.py: don't import unittest
3644         * Scripts/webkitpy/commands/early_warning_system_unittest.py: ditto
3645         * Scripts/webkitpy/commands/queries_unittest.py: ditto
3646         * Scripts/webkitpy/commands/queues_unittest.py: ditto
3647         * Scripts/webkitpy/commands/upload_unittest.py: ditto
3648         * Scripts/webkitpy/mock_bugzillatool.py: log when user.open_url is called.
3649
3650 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3651
3652         Rubberstamped by Simon Hausmann
3653
3654         [Qt] QtLauncher refactoring, separating utility methods.
3655
3656         * QtLauncher/QtLauncher.pro:
3657         * QtLauncher/main.cpp:
3658         * QtLauncher/utils.cpp: Added.
3659         (urlFromUserInput):
3660         * QtLauncher/utils.h: Added.
3661
3662 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3663
3664         Rubberstamped by Simon Hausmann
3665
3666         [Qt] Refactor the code in the QtLauncher dealing with HTTP proxy.
3667
3668         * QtLauncher/main.cpp:
3669         (MainWindow::MainWindow):
3670         * QtLauncher/webpage.cpp:
3671         (WebPage::WebPage):
3672         (WebPage::applyProxy):
3673         * QtLauncher/webpage.h:
3674
3675 2010-01-26  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3676
3677         Reviewed by Tor Arne Vestbø.
3678
3679         [Qt] Corrects debug build of DumpRenderTree on Windows.
3680
3681         * DumpRenderTree/qt/DumpRenderTree.pro:
3682
3683 2010-01-26  Daniel Bates  <dbates@webkit.org>
3684
3685         Reviewed by Adam Barth.
3686
3687         https://bugs.webkit.org/show_bug.cgi?id=34070
3688
3689         Moves the try/catch for OSError exceptions in Executive.run_command
3690         to Credentials.read_credentials() so that the unit test
3691         webkitpy.scm_unittest.SCMClassTests.test_error_handlers can
3692         assert that Executive.run_command throws an OSError exception.
3693
3694         * Scripts/webkitpy/credentials.py:
3695         * Scripts/webkitpy/executive.py: Moved try/catch for OSError to
3696         method Credentials.read_credentials().
3697         * Scripts/webkitpy/executive_unittest.py: Removed tests that no longer
3698         apply: test_run_command_with_bad_command_check_return_code and
3699         test_run_command_with_bad_command_check_calls_error_handler. Added new
3700         test to assert that run_command throws OSError exceptions.
3701
3702 2010-01-26  Diego Gonzalez  <diego.gonzalez@openbossa.org>
3703
3704         Reviewed by Kenneth Rohde Christiansen.
3705
3706         [Qt] DRT WebHistory support
3707         https://bugs.webkit.org/show_bug.cgi?id=34167
3708
3709         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3710         (LayoutTestController::reset):
3711         (LayoutTestController::webHistoryItemCount):
3712         (LayoutTestController::keepWebHistory):
3713         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3714
3715 2010-01-26  Kent Tamura  <tkent@chromium.org>
3716
3717         Reviewed by Eric Seidel.
3718
3719         [Win] Add modifiers parameter support to Windows DumpRenderTree
3720         https://bugs.webkit.org/show_bug.cgi?id=34068
3721
3722         Add support for functional name modifiers; "addSelectionKey" and
3723         "rangeSelectionKey", and modifiers parameter to eventSender.mouseDown()
3724         and eventSender.mouseUp().
3725         This change is similar to r53498 for Mac.
3726         
3727         * DumpRenderTree/win/EventSender.cpp:
3728         (buildModifierFlags): New function to set MK_CONTROL or MK_SHIFT to WPARAM.
3729         (mouseDownCallback): Call buidlModifiersFlags().
3730         (mouseUpCallback): ditto.
3731         (keyDownCallback): Add support for "addSelectionkey" and "rangeSelectionKey".
3732
3733 2010-01-26  Chris Jerdonek  <cjerdonek@webkit.org>
3734
3735         Reviewed by Eric Seidel.
3736
3737         The Python autoinstall cache directory now only gets created
3738         in the directory containing autoinstall.py.
3739
3740         https://bugs.webkit.org/show_bug.cgi?id=33365
3741
3742         * Scripts/webkitpy/autoinstall.py:
3743           - Also added a README file to the cache directory saying
3744             where it came from.
3745
3746 2010-01-26  Chris Jerdonek  <cjerdonek@webkit.org>
3747
3748         Reviewed by Eric Seidel.
3749
3750         Moved the check-webkit-style processors into a new
3751         webkitpy/style/processors directory.
3752
3753         https://bugs.webkit.org/show_bug.cgi?id=34060
3754
3755         * Scripts/webkitpy/style/checker.py:
3756         * Scripts/webkitpy/style/checker_unittest.py:
3757         * Scripts/webkitpy/style/cpp_style.py: Removed.
3758         * Scripts/webkitpy/style/cpp_style_unittest.py: Removed.
3759         * Scripts/webkitpy/style/processors: Added.
3760         * Scripts/webkitpy/style/processors/__init__.py: Added.
3761         * Scripts/webkitpy/style/processors/cpp.py: Copied from WebKitTools/Scripts/webkitpy/style/cpp_style.py.
3762         * Scripts/webkitpy/style/processors/cpp_unittest.py: Copied from WebKitTools/Scripts/webkitpy/style/cpp_style_unittest.py.
3763         * Scripts/webkitpy/style/processors/text.py: Copied from WebKitTools/Scripts/webkitpy/style/text_style.py.
3764         * Scripts/webkitpy/style/processors/text_unittest.py: Copied from WebKitTools/Scripts/webkitpy/style/text_style_unittest.py.
3765         * Scripts/webkitpy/style/text_style.py: Removed.
3766         * Scripts/webkitpy/style/text_style_unittest.py: Removed.
3767         * Scripts/webkitpy/style/unittests.py:
3768
3769 2010-01-26  Kevin Ollivier  <kevino@theolliviers.com>
3770
3771         [wx] Build fix, make sure stub function returns a value.
3772
3773         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3774         (LayoutTestController::counterValueForElementById):
3775
3776 2010-01-26  Steve Falkenburg  <sfalken@apple.com>
3777
3778         Reviewed by Oliver Hunt.
3779
3780         Windows build references non-existent include paths
3781         https://bugs.webkit.org/show_bug.cgi?id=34175
3782
3783         * DumpRenderTree/win/DumpRenderTree.vcproj:
3784         * DumpRenderTree/win/ImageDiff.vcproj:
3785         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3786
3787 2010-01-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3788
3789         Reviewed by Ariya Hidayat.
3790
3791         [Qt] Separating out the UrlLoader from the QtLauncher in it's
3792         own implementation and header file.
3793
3794         * QtLauncher/main.cpp:
3795         (main):
3796         * QtLauncher/urlloader.cpp: Added.
3797         (UrlLoader::UrlLoader):
3798         (UrlLoader::loadNext):
3799         (UrlLoader::init):
3800         (UrlLoader::getUrl):
3801         * QtLauncher/urlloader.h: Added.
3802
3803 2010-01-25  Chris Jerdonek  <cjerdonek@webkit.org>
3804
3805         Reviewed by Shinichiro Hamaji.
3806
3807         Refactored check-webkit-style by removing the file path
3808         parameter from the style error handler functions.
3809
3810         https://bugs.webkit.org/show_bug.cgi?id=34031
3811
3812         * Scripts/webkitpy/style/checker.py:
3813           - Added _default_style_error_handler() to StyleChecker class.
3814           - Moved handle_style_error() to inside _default_style_error_handler().
3815
3816         * Scripts/webkitpy/style/checker_unittest.py:
3817           - Removed file path from calls to error handler.
3818
3819         * Scripts/webkitpy/style/cpp_style.py:
3820           - Removed file path from calls to error handler.
3821
3822         * Scripts/webkitpy/style/cpp_style_unittest.py:
3823           - Removed file path from calls to error handler.
3824
3825         * Scripts/webkitpy/style/text_style.py:
3826           - Removed file path from calls to error handler.
3827
3828         * Scripts/webkitpy/style/text_style_unittest.py:
3829           - Removed file path from calls to error handler.
3830
3831 2010-01-25  Jeremy Orlow  <jorlow@chromium.org>
3832
3833         Adding myself as reviewer.  No review necessary.
3834
3835         * Scripts/webkitpy/committers.py:
3836
3837 2010-01-25  Chris Jerdonek  <cjerdonek@webkit.org>
3838
3839         Reviewed by Adam Barth.
3840
3841         Improved prepare-ChangeLog so that it preserves the relative
3842         indentation of a git commit message.
3843
3844         https://bugs.webkit.org/show_bug.cgi?id=34058
3845
3846         * Scripts/prepare-ChangeLog:
3847           - Also adjusted the script so that it does not add white
3848             space characters to empty lines.
3849
3850 2010-01-24  Eric Seidel  <eric@webkit.org>
3851
3852         No review, rolling out r53763.
3853         http://trac.webkit.org/changeset/53763
3854         https://bugs.webkit.org/show_bug.cgi?id=33895
3855
3856         Broke 20+ tests on Windows.
3857
3858         * Scripts/run-webkit-tests:
3859         * Scripts/webkitdirs.pm:
3860
3861 2010-01-24  Adam Barth  <abarth@webkit.org>
3862
3863         Rubber stamped by Eric Seidel.
3864
3865         More pep8 compliance.
3866
3867         * Scripts/webkitpy/mock_bugzillatool.py:
3868
3869 2010-01-24  Adam Barth  <abarth@webkit.org>
3870
3871         Rubber stamped by Eric Seidel.
3872
3873         More pep8 compliance.
3874
3875         * Scripts/webkitpy/executive.py:
3876         * Scripts/webkitpy/grammar.py:
3877
3878 2010-01-24  Adam Barth  <abarth@webkit.org>
3879
3880         Rubber stamped by Eric Seidel.
3881
3882         More pep8 compliance.
3883
3884         * Scripts/webkitpy/comments.py:
3885         * Scripts/webkitpy/committers.py:
3886         * Scripts/webkitpy/credentials.py:
3887
3888 2010-01-24  Adam Barth  <abarth@webkit.org>
3889
3890         Rubber stamped by Eric Seidel.
3891
3892         Make changelogs.py pass pep8.
3893
3894         * Scripts/webkitpy/changelogs.py:
3895
3896 2010-01-23  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3897
3898         [Qt] Unreviewed build fix
3899
3900         * QtLauncher/QtLauncher.pro:
3901         * QtLauncher/webinspector.h:
3902
3903 2010-01-23  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3904
3905         Rubberstamped by Simon Hausmann.
3906
3907         [Qt] Move the WebInspector class to it's own header file.
3908
3909         * QtLauncher/main.cpp:
3910         * QtLauncher/webinspector.h: Added.
3911         (WebInspector::WebInspector):
3912         (WebInspector::showEvent):
3913         (WebInspector::hideEvent):
3914
3915 2010-01-23  Robert Hogan  <robert@roberthogan.net>
3916
3917         Reviewed by Kenneth Rohde Christiansen.
3918
3919         Qt DRT: respect window.close() and window.closed()
3920         
3921         Qt DRT needs to maintain a correct count of open windows
3922         for windowCount(). It also needs to delete windows that
3923         have been closed by window.close().
3924         
3925         This fixes the following tests:
3926         
3927         plugins/destroy-during-npp-new.html
3928         fast/dom/Document/early-document-access.html
3929         fast/dom/Window/window-early-properties.html
3930         fast/events/open-window-from-another-frame.html
3931         fast/events/popup-blocking-click-in-iframe.html
3932         
3933         https://bugs.webkit.org/show_bug.cgi?id=32953
3934
3935         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3936         (WebCore::DumpRenderTree::DumpRenderTree):
3937         (WebCore::DumpRenderTree::createWindow):
3938         (WebCore::DumpRenderTree::windowCloseRequested):
3939         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3940         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3941         (LayoutTestController::maybeDump):
3942
3943 2010-01-23  Dan Bernstein  <mitz@apple.com>
3944
3945         Reviewed by Mark Rowe.
3946
3947         Added a user default for specifying a fallback frameworks path in case
3948         the bundle does not contain frameworks for the current Mac OS X version.
3949
3950         * WebKitLauncher/main.m:
3951         (fallbackMacOSXVersion): Added. Looks up the fallback version in a dictionary
3952         keyed by the FallbackSystemVersions user default and returns it.
3953         (main): If a frameworks directory for the current system version is not found,
3954         try the fallback.
3955
3956 2010-01-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3957
3958         Reviewed by Simon Hausmann.
3959
3960         Make run-webkit-tests work under Cygwin for the Qt port
3961
3962         setPathForRunningWebKitApp() is implemented for the Qt port
3963         by using qmake to query for the location of the Qt libraries.
3964
3965         This requires the original environment (%ENV) to be untouched,
3966         so launchWithCurrentEnv() was refactored to launchWithEnv(),
3967         and the code in openDumpTool() to not use %ENV but a %CLEAN_ENV
3968         instead. This has the added benefit of getting rid of the temp
3969         variables used for storing the current env.
3970
3971         openDumpTool() is also refactored a bit into platform-spesific,
3972         port-spesific, and generic environment variables.
3973
3974         Checks for undef was added a few places to fix Perl concat
3975         warnings when run-webkit-tests is aborted.
3976
3977         https://bugs.webkit.org/show_bug.cgi?id=33895
3978
3979         * Scripts/run-webkit-tests:
3980         * Scripts/webkitdirs.pm:
3981
3982 2010-01-22  Kevin Watters  <kevinwatters@gmail.com>
3983
3984         Reviewed by Kevin Ollivier.
3985
3986         [wx] Remove the Bakefile build system, which is no longer being used.
3987         
3988         https://bugs.webkit.org/show_bug.cgi?id=34022
3989
3990         * DumpRenderTree/wx/DumpRenderTree.bkl: Removed.
3991         * wx/browser/browser.bkl: Removed.
3992         * wx/build-wxwebkit: Removed.
3993
3994 2010-01-22  Gustavo Noronha Silva  <gns@gnome.org>
3995
3996         Reviewed by Simon Fraser.
3997
3998         Reset zoom level to 1.0 when resetting view state. This is causing
3999         many tests to fail after svg/custom/text-zoom.xhtml changes the
4000         zoom level.
4001
4002         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4003         (resetDefaultsToConsistentValues):
4004
4005 2010-01-22  Steve Falkenburg  <sfalken@apple.com>
4006
4007         Reviewed by Darin Adler.
4008
4009         https://bugs.webkit.org/show_bug.cgi?id=34025
4010         Enable client-based Geolocation abstraction for Mac, Windows AppleWebKit targets.
4011
4012         * Scripts/build-webkit:
4013
4014 2010-01-22  Adam Barth  <abarth@webkit.org>
4015
4016         Unreviewed.  Arg.  Someone renamed limit to output_limit on me.
4017
4018         * Scripts/webkitpy/commands/queues.py:
4019
4020 2010-01-22  Adam Barth  <abarth@webkit.org>
4021
4022         Rubber stamped by Eric Seidel.
4023
4024         Make __init__.py and buildbot.py pass pep8 style checker.
4025
4026         * Scripts/webkitpy/__init__.py:
4027         * Scripts/webkitpy/buildbot.py:
4028
4029 2010-01-21  Joe Mason  <jmason@rim.com>
4030
4031         Reviewed by Adam Barth.
4032
4033         webkit-patch should retry on invalid password
4034         https://bugs.webkit.org/show_bug.cgi?id=33955
4035
4036         Ask for bugs.webkit.org authentication in a loop.
4037
4038         * Scripts/webkitpy/bugzilla.py:
4039
4040 2010-01-22  Adam Barth  <abarth@webkit.org>
4041
4042         Unreviewed.  Don't call seek on a NoneType.
4043
4044         * Scripts/webkitpy/statusserver.py:
4045
4046 2010-01-22  Petri Latvala  <petri.latvala@nomovok.com>
4047
4048         Reviewed by David Levin.
4049
4050         check-webkit-style breaks on files with unknown types
4051         https://bugs.webkit.org/show_bug.cgi?id=34001
4052
4053         For files with type FileType.NONE, dispatch_processor returns None.
4054
4055         * Scripts/webkitpy/style/checker.py: Don't call process_file with a processor of value None.
4056
4057 2010-01-22  Adam Barth  <abarth@webkit.org>
4058
4059         Reviewed by Eric Seidel.
4060
4061         Make bugzilla.py and webkitport.py conform to pep8
4062         https://bugs.webkit.org/show_bug.cgi?id=34015
4063
4064         This patch makes webkitport.py and bugzilla.py mostly conform to PEP8
4065         style as enforced by pep8.py.  I wasn't able to get rid of all the
4066         errors because I'm not sure how to wrap some lines properly.  Also,
4067         there are a few deprication errors that I couldn't resolve easily.
4068         However, this is a massive improvement in compliance.
4069
4070         * Scripts/webkitpy/bugzilla.py:
4071         * Scripts/webkitpy/webkitport.py:
4072
4073 2010-01-22  Adam Barth  <abarth@webkit.org>
4074
4075         Reviewed by Darin Adler.
4076
4077         Limit length of EWS results to 5MB
4078         https://bugs.webkit.org/show_bug.cgi?id=34016
4079
4080         Hopefully this will fix the bug where the results link doesn't appear.
4081         Our current theory is that the results blob is too big and the server
4082         is rejecting the request with a 500 error.  That causes us to re-try
4083         the post, but when we re-try the StringIO buffer has its seek pointer
4084         at the end.
4085
4086         * Scripts/webkitpy/commands/queues.py:
4087         * Scripts/webkitpy/statusserver.py:
4088
4089 2010-01-22  Chris Jerdonek  <cjerdonek@webkit.org>
4090
4091         Reviewed by Adam Barth.
4092
4093         Made check-webkit-style able to check patches when script not
4094         run from source root. Also consolidated external references
4095         to a single file.
4096
4097         https://bugs.webkit.org/show_bug.cgi?id=33791
4098
4099         * Scripts/check-webkit-style:
4100           - Changed to import style_references.py.
4101
4102         * Scripts/webkitpy/style/__init__.py:
4103           - Removed __path__ hack that allowed searching Scripts/ directory.
4104
4105         * Scripts/webkitpy/style/checker.py:
4106           - Changed to import style_references.py.
4107
4108         * Scripts/webkitpy/style_references.py: Added.
4109
4110 2010-01-22  Dmitry Titov  <dimich@chromium.org>
4111
4112         Reviewed by Maciej Stachowiak.
4113
4114         Fix the leak of ThreadIdentifiers in threadMap across threads.
4115         https://bugs.webkit.org/show_bug.cgi?id=32689
4116
4117         Add a new test to verify the ThreadIdentifiers are not reused across threads.
4118         The test runs in the beginning of DumpRenderTree and spawns 2 non-WTF treads sequentially,
4119         waiting for the previous thread to terminate before starting the next.
4120         The treads use WTF::currentThread() in their thread function. Without a fix, this
4121         causes both threads to have the same ThreadIdentifier which triggers ASSERT in thread function.
4122         It also starts another thread using WTF. Without the fix, this finds pthread handle from previous
4123         threads in the WTF threadMap and asserts in WTF::establishIdentifierForPthreadHandle().
4124         The test practically does not affect the DRT run time because the threads end immediately.
4125
4126         * DumpRenderTree/mac/DumpRenderTree.mm:
4127         (runThread): Test thread function.
4128         (testThreadIdentifierMap):
4129         (dumpRenderTree):
4130
4131 2010-01-22  Kent Tamura  <tkent@chromium.org>
4132
4133         Reviewed by Maciej Stachowiak.
4134
4135         Fix a bug that mouseDown:withModifiers: is never called.
4136         https://bugs.webkit.org/show_bug.cgi?id=33989
4137
4138         * DumpRenderTree/mac/EventSendingController.mm:
4139         (+[EventSendingController isSelectorExcludedFromWebScript:]):
4140         (+[EventSendingController webScriptNameForSelector:]):
4141
4142 2010-01-22  Kenneth Rohde Christiansen  <kenneth@webkit.org>
4143
4144         Rubberstamped by Antti Koivisto.
4145
4146         [Qt] Separate out the WebPage class into it's own
4147         cpp/header files. Also, removed the assumption that
4148         the view is a QWebView, in preparation of a merger
4149         of the two Qt WebKit launchers.
4150
4151         * QtLauncher/QtLauncher.pro:
4152         * QtLauncher/main.cpp:
4153         (WebView::mousePressEvent):
4154         * QtLauncher/webpage.cpp: Added.
4155         (WebPage::supportsExtension):
4156         (WebPage::extension):
4157         (WebPage::acceptNavigationRequest):
4158         (WebPage::openUrlInDefaultBrowser):
4159         * QtLauncher/webpage.h: Added.
4160         (WebPage::WebPage):
4161
4162 2010-01-21  Chris Jerdonek  <cjerdonek@webkit.org>
4163
4164         Reviewed by Shinichiro Hamaji.
4165
4166         Refactored to move file name and file-reading related code
4167         from cpp_style.py and text_style.py to checker.py.
4168
4169         https://bugs.webkit.org/show_bug.cgi?id=33775
4170
4171         * Scripts/check-webkit-style:
4172           - Updates caused by changes to checker.py.
4173
4174         * Scripts/webkitpy/style/checker.py:
4175           - Added SKIPPED_FILES_WITH_WARNING list.
4176           - Added SKIPPED_FILES_WITHOUT_WARNING list.
4177           - Added FileType class.
4178           - Added ProcessorDispatcher class.
4179           - In StyleChecker class:
4180             - Renamed process_patch() to check_patch().
4181             - Renamed process_file() to check_file().
4182             - Added _process_file().
4183             - Related refactoring.
4184             - Addressed check_patch() FIXME to share code with process_file().
4185
4186         * Scripts/webkitpy/style/checker_unittest.py:
4187           - Added ProcessorDispatcherSkipTest class.
4188           - Added ProcessorDispatcherDispatchTest class.
4189           - Added StyleCheckerCheckFileTest class.
4190
4191         * Scripts/webkitpy/style/cpp_style.py:
4192           - Renamed process_file_data() to _process_lines.
4193           - Removed process_file() (moved logic to checker.py).
4194           - Removed can_handle() (moved logic to checker.py).
4195           - Added CppProcessor class.
4196           - Removed is_exempt() (moved logic to checker.py).
4197           - Added process_file_data() back as a wrapper function.
4198
4199         * Scripts/webkitpy/style/cpp_style_unittest.py:
4200           - Removed test_can_handle().
4201           - Removed test_is_exempt().
4202           - Added CppProcessorTest class.
4203
4204         * Scripts/webkitpy/style/text_style.py:
4205           - Added TextProcessor class.
4206           - Removed process_file().
4207           - Removed can_handle().
4208
4209         * Scripts/webkitpy/style/text_style_unittest.py:
4210           - Removed test_can_handle().
4211           - Added TextProcessorTest class.
4212
4213 2010-01-21  Chris Jerdonek  <cjerdonek@webkit.org>
4214
4215         Reviewed by David Kilzer.
4216
4217         Create a unit-tested subroutine to parse patch files created
4218         by svn-create-patch.
4219
4220         https://bugs.webkit.org/show_bug.cgi?id=33475
4221
4222         * Scripts/VCSUtils.pm:
4223           - Added parseDiff().
4224           - Added parsePatch().
4225
4226         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Added.
4227           - Added unit tests for parseDiff().
4228
4229         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
4230           - Total number of tests now computed dynamically.
4231
4232         * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl: Added.
4233           - Added unit tests for parsePatch().
4234
4235 2010-01-21  Kevin Ollivier  <kevino@theolliviers.com>
4236
4237         [wx] Build fix, add new directory to dir list.
4238
4239         * wx/build/settings.py:
4240
4241 2010-01-21  Adam Barth  <abarth@webkit.org>
4242
4243         Reviewed by Eric Seidel.
4244
4245         Make the EWS transactional
4246         https://bugs.webkit.org/show_bug.cgi?id=33978
4247
4248         Now if the EWS gets interrupted in the middle of processing a patch,
4249         the bots will re-process the patch.
4250
4251         * Scripts/test-webkitpy:
4252         * Scripts/webkitpy/commands/queues.py:
4253         * Scripts/webkitpy/commands/queues_unittest.py:
4254         * Scripts/webkitpy/patchcollection.py:
4255         * Scripts/webkitpy/patchcollection_unittest.py: Added.
4256
4257 2010-01-21  Adam Barth  <abarth@webkit.org>