8ac400b74f5f15836b75ba0ca0abcbf3f3119655
[WebKit-https.git] / WebKitTools / ChangeLog
1 2007-12-18  Steve Falkenburg  <sfalken@apple.com>
2
3         Add script to run Drosera as part of the nightly.
4         
5         Reviewed by Kevin M.
6
7         * Scripts/run-drosera.cmd: Added.
8
9 2007-12-18  Darin Adler  <darin@apple.com>
10
11         * Scripts/do-webcore-rename: Remove a stray K.
12
13 2007-12-18  Darin Adler  <darin@apple.com>
14
15         * Scripts/do-webcore-rename: Plan more renaming.
16
17 2007-12-14  Juan A. Suarez Romero  <jasuarez@igalia.com>
18
19         Reviewed by Alp Toker.
20
21         http://bugs.webkit.org/show_bug.cgi?id=16042
22         [GTK] Eliminate webkit_init()
23
24         Moving webkit initialization to WebView class init.
25
26         * DumpRenderTree/gtk/DumpRenderTree.cpp:
27         (main):
28         * GtkLauncher/main.c:
29         (main):
30
31 2007-12-17  Luca Bruno  <lethalman88@gmail.com>
32
33         Reviewed by Alp Toker.
34
35         http://bugs.webkit.org/show_bug.cgi?id=13542
36         gdklauncher doesnt change URL in adress GTKEntry.
37
38         * GtkLauncher/main.c:
39         (load_commit_cb): added
40         (title_change_cb):
41         (create_browser):
42
43 2007-12-16  Dimitri Glazkov  <dimitri@glazkov.com>
44
45         Reviewed by Adam Roben.
46
47         Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.
48
49         * FindSafari/FindSafari.cpp:
50         (_tmain):
51
52 2007-12-16  Brent Fulgham  <bfulgham@gmail.com>
53
54         Reviewed by Adam Roben.
55
56         http://bugs.webkit.org/show_bug.cgi?id=16315
57         FindSafari needs a path-only option.
58
59         * FindSafari/FindSafari.cpp:
60         (_tmain):
61
62 2007-12-16  Alexey Proskuryakov  <ap@webkit.org>
63
64         Reviewed by Darin.
65
66         http://bugs.webkit.org/show_bug.cgi?id=16462
67         REGRESSION: access keys broken on Windows
68
69         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Send system key events
70         if Alt is pressed.
71
72 2007-12-15  Sam Weinig  <sam@webkit.org>
73
74         Reviewed by Mark Rowe.
75
76         Fix urlSuitableForTestResult to correctly identify wstring::npos as
77         the case when wstring.find doesn't find anything.
78
79         * DumpRenderTree/win/DumpRenderTree.cpp:
80         (urlSuitableForTestResult):
81
82 2007-12-15  Alp Toker  <alp@atoker.com>
83
84         GTK+ DRT build fix for GLib < 2.14.
85
86         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
87         (LayoutTestController::setWaitToDump):
88
89 2007-12-05  Mark Rowe  <mrowe@apple.com>
90
91         Reviewed by Alp Toker.
92
93         Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.  This prevents
94         many layout tests from hanging while waiting on user responses to dialogs.
95
96         * DumpRenderTree/gtk/DumpRenderTree.cpp:
97         (invalidateAnyPreviousWaitToDumpWatchdog):
98         (webViewScriptAlert):
99         (webViewScriptPrompt):
100         (webViewScriptConfirm):
101         (main):
102         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
103         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
104         (waitToDumpWatchdogFired):
105         (LayoutTestController::setWaitToDump):
106
107 2007-12-05  Mark Rowe  <mrowe@apple.com>
108
109         Reviewed by Alp Toker.
110
111         Flesh out DumpRenderTree for Gtk.  After these changes, the majority of the tests in fast/js pass.
112
113         * DumpRenderTree/gtk/DumpRenderTree.cpp:
114         (dumpFramesAsText): Don't print the frame name when dumping the main frame as text.
115         (dump):
116         (runTest):
117         (webViewLoadStarted): Store the top frame when it starts loading so we can use it to determine when to dump.
118         (webViewLoadFinished): Dump when the top frame load completes if we're not waiting for a JS callback and the
119         work queue is empty.
120         (webViewWindowObjectCleared): Set up window.layoutTestController.
121         (webViewConsoleMessage): Match the console message format expected by the layout test results.
122         (main): Hook up the new signals.
123         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
124         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Only notify done if the top frame has completed loading to avoid
125         dumping multiple times.
126         * Scripts/build-dumprendertree: Ensure build-dumprendertree is a no-op for Gtk too.
127         * Scripts/run-webkit-tests: Teach run-webkit-tests that Gtk is like Qt in many ways.  Use run-launcher to open test results.
128
129 2007-12-14  Anders Carlsson  <andersca@apple.com>
130
131         Reviewed by Brady.
132
133         Assert that a web frame that's loading a resource always has either a data source or 
134         a provisional data source.
135         
136         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
137         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
138
139 2007-12-14  Darin Adler  <darin@apple.com>
140
141         - fix mistake causing nearly all tests to fail on Windows
142
143         * DumpRenderTree/win/UIDelegate.cpp:
144         (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with
145         npos, not 0. Also pass URL in to URL function rather than passing the entire message.
146
147         * DumpRenderTree/mac/UIDelegate.mm:
148         (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather
149         than passing the entire message.
150
151 2007-12-14  Darin Adler  <darin@apple.com>
152
153         - fix Tiger build
154
155         * DumpRenderTree/mac/UIDelegate.mm:
156         (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any
157         new-to-Leopard methods.
158
159 2007-12-14  Darin Adler  <darin@apple.com>
160
161         * DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method
162         since it now triggers unwanted icon loading. We only had it because we implemented "all"
163         delegate methods here.
164
165 2007-12-14  Anders Carlsson  <andersca@apple.com>
166
167         Reviewed by Darin and Geoff.
168
169         <rdar://problem/5619295> 
170         REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
171         
172         Add property getting methods to the plug-in.
173         
174         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
175         (pluginInvoke):
176
177 2007-12-14  Kevin McCullough  <kmccullough@apple.com>
178
179         Reviewed by Darin.
180
181         - Layout test fix for mac. When dumped to the console local file paths
182         now only show the name of the resource not the whole path.  This is to
183         make the results machine and OS independent.
184
185         * DumpRenderTree/mac/UIDelegate.mm:
186         (-[UIDelegate webView:addMessageToConsole:]):
187
188 2007-12-13  Kevin McCullough  <kmccullough@apple.com>
189
190         Reviewed by Adam.
191
192         - Layout tests fix.  We need a way to remove machine-dependent
193         information from paths in layout test results. The UIDelegate now does
194         this.
195
196         * DumpRenderTree/DumpRenderTree.h:
197         * DumpRenderTree/win/DumpRenderTree.cpp:
198         (urlSuitableForTestResult):
199         * DumpRenderTree/win/DumpRenderTreeWin.h:
200         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
201         * DumpRenderTree/win/UIDelegate.cpp:
202         (UIDelegate::webViewAddMessageToConsole):
203
204 2007-12-13  Alp Toker  <alp@atoker.com>
205
206         Build fix for DRT breakage introduced in r28690.
207
208         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
209         (LayoutTestController::pathToLocalResource):
210
211 2007-12-12  Kevin McCullough  <kmccullough@apple.com>
212
213         Reviewed by Alice and Sam.
214
215         - <rdar://5621435> Need a way to specify local resources (being loaded
216         from HTTP tests) on Windows.
217         - Implemented pathToLocalResource which exposes the functionality of
218         converting a given unix path to the correct location on Windows.
219
220         * DumpRenderTree/LayoutTestController.cpp:
221         (pathToLocalResourceCallback):
222         (LayoutTestController::staticFunctions):
223         * DumpRenderTree/LayoutTestController.h:
224         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
225         (LayoutTestController::pathToLocalResource):
226         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
227         (LayoutTestController::pathToLocalResource):
228
229 2007-12-12  Anders Carlsson  <andersca@apple.com>
230
231         Reviewed by Sam.
232
233         <rdar://problem/5132003>
234         dumpResourceLoadCallbacks is not implemented in DRT on Windows.
235
236         * DumpRenderTree/win/DumpRenderTree.cpp:
237         (main):
238         Set the resource load delegate.
239         
240         * DumpRenderTree/win/DumpRenderTree.vcproj:
241         
242         * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
243         * DumpRenderTree/win/ResourceLoadDelegate.h: Added.
244
245 2007-12-12  Alexey Proskuryakov  <ap@webkit.org>
246
247         Reviewed by Adam Roben.
248
249         Fix conversion from double to LPARAM in dispatchMessage().
250
251         * DumpRenderTree/win/EventSender.cpp:
252         (dispatchMessageCallback):
253
254 2007-12-11  Dan Bernstein  <mitz@apple.com>
255
256         Reviewed by Mark Rowe and Sam Weinig too!
257
258         - added Helvetica Oblique and Helvetica Bold Oblique to the list of
259           fonts DumpRenderTree registers.
260
261         * DumpRenderTree/win/DumpRenderTree.cpp:
262         (initialize):
263
264 2007-12-11  Brady Eidson  <beidson@apple.com>
265
266         Reviewed by Anders
267
268         Make DumpRenderTree on mac use its own path for Databases testing
269
270         * DumpRenderTree/mac/DumpRenderTree.mm:
271         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree 
272           for future DRT-only use, then use it to construct the Databases path and set that default
273
274 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
275
276         Reviewed by Darin.
277
278         <rdar://problem/5535636>
279         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
280
281         http://bugs.webkit.org/show_bug.cgi?id=13916
282         JavaScript detects Tab as a character input on a textfield validation
283
284         * DumpRenderTree/mac/EventSendingController.mm:
285         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
286         Dispatch a keyup to better match what happens when a key is physically pressed.
287
288         * DumpRenderTree/win/EventSender.cpp:
289         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
290         returning from keyDown().
291         (getConstantCallback): Fixed a couple copy/paste mistakes.
292
293 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
294
295         Reviewed by Oliver.
296
297         - <rdar://5599845> Drosera: Does not show loal files in the file list
298         on the left side.
299
300         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
301         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
302         so the open source community can build.
303
304 2007-12-10  Brady Eidson  <beidson@apple.com>
305
306         Rubberstamped by Sam Weinig
307
308         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
309
310         * DumpRenderTree/mac/UIDelegate.mm:
311         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
312         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
313
314 2007-12-08  Oliver Hunt  <oliver@apple.com>
315
316         Reviewed by Sam W.
317
318         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
319         
320         Fixes <rdar://problem/5620249> Must disable SVG animation
321         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
322         
323         In order to allow finer grained control over the set of SVG features
324         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
325         distinct flags:
326         ENABLE_SVG_ANIMATION
327         ENABLE_SVG_FILTERS
328         ENABLE_SVG_FONTS
329         ENABLE_SVG_AS_IMAGE
330         ENABLE_SVG_USE
331         
332         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
333         
334         Script handles all the new build flags, and allows --svg-experimental
335         to automatically enable all features.
336
337         * Scripts/build-webkit:
338
339 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
340
341         Fix version parsing.
342
343         Rubber-stamped by Oliver.
344
345         * Drosera/win/Drosera.vcproj/auto-version.sh:
346
347 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
348
349         Build modifications for Drosera.
350
351         Reviewed by Adam.
352
353         * Drosera/DroseraWin.make: Added.
354         * Drosera/win/Drosera.vcproj/Drosera.rc:
355         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
356         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
357         * Drosera/win/Drosera.vcproj/VERSION: Added.
358         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
359
360 2007-12-06  Adam Roben  <aroben@apple.com>
361
362         Explicitly turn on the Mac font ascent hack on Windows
363
364         This keeps our font metrics matching those from Mac.
365
366         Reviewed by Hyatt.
367
368         * DumpRenderTree/win/DumpRenderTree.cpp:
369         (main):
370
371 2007-12-06  Anders Carlsson  <andersca@apple.com>
372
373         Rename main.c to main.cpp here too.
374         
375         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
376
377 2007-12-06  Sam Weinig  <sam@webkit.org>
378
379         Rubber stamped by Geoff.
380
381         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
382
383 2007-12-06  Darin Adler  <darin@apple.com>
384
385         * Scripts/do-webcore-rename: Some more renaming plans.
386
387 2007-12-06  Anders Carlsson  <andersca@apple.com>
388
389         Restore implementation of testGetIntIdentifier that was accidentally
390         removed somehow (possibly when I made PluginObject be a cpp file).
391         
392         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
393         (pluginInvoke):
394
395 2007-12-05  Anders Carlsson  <andersca@apple.com>
396
397         Make the entry points extern "C".
398         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
399         
400 2007-12-05  Anders Carlsson  <andersca@apple.com>
401
402         C++ warning fixes.
403         
404         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
405         (NPP_New):
406         (NPP_Destroy):
407         (NPP_SetWindow):
408         (NPP_NewStream):
409         (NPP_HandleEvent):
410         (NPP_URLNotify):
411         (NPP_GetValue):
412
413 2007-12-05  Anders Carlsson  <andersca@apple.com>
414
415         Add the .cpp files to the TestNetscapePlugIn target.
416
417         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
418
419 2007-12-05  Anders Carlsson  <andersca@apple.com>
420
421         Reviewed by Geoff.
422         
423         Rename the TestNetscapePlugIn .c files to be .cpp.
424
425         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
426         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
427         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
428         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
429         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
430         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
431         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
432         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
433
434 2007-12-05  Adam Roben  <aroben@apple.com>
435
436         Fix case of keypresses from the Windows implementation of eventSender.keyDown
437
438         This fixes several regression tests.
439
440         Reviewed by Alice.
441
442         * DumpRenderTree/win/EventSender.cpp:
443         (keyDownCallback): Virtual keycodes for ASCII characters are always
444         uppercase, so we need to check the case of the original character
445         passed in to eventSender.keyDown.
446
447 2007-12-05  Adam Roben  <aroben@apple.com>
448
449         Learn from Tim's mistakes
450
451         * DumpRenderTree/win/DumpRenderTree.cpp:
452         (runTest): Reset the authorAndUserStylesEnabled preference for each
453         test.
454
455 2007-12-05  Alp Toker  <alp@atoker.com>
456
457         Reviewed by Mark Rowe.
458
459         Initialize GTK+ and WebKit so the tests can run.
460
461         Reorganize the headers a little.
462
463         * DumpRenderTree/gtk/DumpRenderTree.cpp:
464         (main):
465
466 2007-12-04  Anders Carlsson  <andersca@apple.com>
467
468         Remove IWebScriptScope include.
469         
470         * Drosera/win/DebuggerDocumentPlatform.cpp:
471
472 2007-12-04  Sam Weinig  <sam@webkit.org>
473
474         Rubber stamped by Mark Rowe.
475
476         Define CF as platform for mac and revert r28409
477
478         * DumpRenderTree/DumpRenderTree.h:
479         * DumpRenderTree/mac/DumpRenderTreeMac.h:
480
481 2007-12-04  Sam Weinig  <sam@webkit.org>
482
483         Define CF as platform for windows.
484
485         Reviewed by Adam Roben.
486
487         * DumpRenderTree/win/DumpRenderTreeWin.h:
488
489 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
490
491         Reviewed by Adam and Darin.
492
493         - Removed a needless BSTR cleanup.
494
495         * Drosera/win/DebuggerDocumentPlatform.cpp:
496         (DebuggerDocument::getPlatformCurrentFunctionStack):
497
498 2007-11-27  Adam Roben  <aroben@apple.com>
499
500         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
501
502         Reviewed by Maciej.
503
504         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
505         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
506
507 2007-12-04  Alp Toker  <alp@atoker.com>
508
509         Prospective Win DRT build fix.
510
511         * DumpRenderTree/DumpRenderTree.h:
512
513 2007-12-04  Alp Toker  <alp@atoker.com>
514
515         Fix a clobbered copyright header.
516
517         * DumpRenderTree/gtk/DumpRenderTree.cpp:
518
519 2007-12-04  Xan Lopez  <xan@gnome.org>
520
521         Reviewed by Alp Toker.
522
523         http://bugs.webkit.org/show_bug.cgi?id=15561
524         GTK port needs DumpRenderTree implementation
525
526         Start work on the GTK+ DRT.
527
528         This does not work yet, and there are a few lingering style issues
529         (nothing major) but this patch has been stuck in the bug tracker for
530         too long already.
531
532         * DumpRenderTree/DumpRenderTree.h:
533         * DumpRenderTree/gtk: Added.
534         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
535         (autocorrectURL):
536         (shouldLogFrameLoadDelegates):
537         (dumpFrameScrollPosition):
538         (displayWebView):
539         (appendString):
540         (dumpFramesAsText):
541         (dumpRenderTreeAsText):
542         (dump):
543         (runTest):
544         (main):
545         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
546         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
547         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
548         (GCController::collect):
549         (GCController::collectOnAlternateThread):
550         (GCController::getJSObjectCount):
551         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
552         (LayoutTestController::~LayoutTestController):
553         (LayoutTestController::addDisallowedURL):
554         (LayoutTestController::clearBackForwardList):
555         (LayoutTestController::copyDecodedHostName):
556         (LayoutTestController::copyEncodedHostName):
557         (LayoutTestController::display):
558         (LayoutTestController::keepWebHistory):
559         (LayoutTestController::notifyDone):
560         (LayoutTestController::queueBackNavigation):
561         (LayoutTestController::queueForwardNavigation):
562         (LayoutTestController::queueLoad):
563         (LayoutTestController::queueReload):
564         (LayoutTestController::queueScript):
565         (LayoutTestController::setAcceptsEditing):
566         (LayoutTestController::setCustomPolicyDelegate):
567         (LayoutTestController::setMainFrameIsFirstResponder):
568         (LayoutTestController::setTabKeyCyclesThroughElements):
569         (LayoutTestController::setUseDashboardCompatibilityMode):
570         (LayoutTestController::setUserStyleSheetEnabled):
571         (LayoutTestController::setUserStyleSheetLocation):
572         (LayoutTestController::setWindowIsKey):
573         (LayoutTestController::setWaitToDump):
574         (LayoutTestController::windowCount):
575         (LayoutTestController::setPrivateBrowsingEnabled):
576         (LayoutTestController::setAuthorAndUserStylesEnabled):
577         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
578         (JSStringCopyUTF8CString):
579         (LoadItem::invoke):
580         (ReloadItem::invoke):
581         (ScriptItem::invoke):
582         (BackForwardItem::invoke):
583
584 2007-12-03  Sam Weinig  <sam@webkit.org>
585
586         Move JavaScriptCore thread testing code to pthread specific directory
587         and remove the dependance on CoreFoundation by using WTF::HashSet.
588
589         Reviewed by Geoff and Oliver.
590
591         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
592         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
593         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
594         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
595         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
596         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
597         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
598         * DumpRenderTree/pthreads: Added.
599         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
600         (javaScriptThreads):
601         (runJavaScriptThread):
602         (startJavaScriptThreads):
603         (stopJavaScriptThreads):
604
605 2007-12-03  Andrew Bonventre  <andybons@google.com>
606
607         Reviewed by Darin Adler.
608
609         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
610         Symbol lookup menu broken in debugger view
611
612         * Drosera/debugger.js: Fixed javascript error where document property
613         should have been used instead of contentDocument in switchFunction that
614         was breaking the select symbol dropdown menu.  This is because
615         window.frames will return a Window object and not a frame object like
616         the author was originally expecting.
617
618 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
619
620         Reviewed by Adam.
621
622         - <rdar://5618942> Drosera: Console window does not process everything
623         correctly.
624         - <rdar://5619005> Drosera: could be sped up by moving the 
625         WebScriptScope stuff into the WebScriptCallFrame.
626         - Now the console can correctly process objects and does not receive
627         notifications from JavaScriptCore about the JavaScript in Drosera's
628         own process.
629
630         * Drosera/win/DebuggerDocumentPlatform.cpp:
631         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
632         (DebuggerDocument::platformValueForScopeVariableNamed):
633
634 2007-12-03  Stephanie  <slewis@apple.com>
635
636         Reviewed by Darin.
637
638         Check to see if we are building a debug root
639
640         * Scripts/check-for-global-initializers: 
641
642 2007-12-03  Dan Bernstein  <mitz@apple.com>
643
644         Reviewed by Darin Adler.
645
646         - added a testGetIntIdentifier() method to TestNetscapePlugIn
647
648         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
649         (pluginInvoke):
650
651 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
652
653         Reviewed by Oliver.
654
655         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
656         in a more fine-grained manner than eventSender.keyDown().
657
658         * DumpRenderTree/win/EventSender.cpp:
659         (getConstantCallback):
660         (dispatchMessageCallback):
661
662 2007-12-02  Darin Adler  <darin@apple.com>
663
664         * Scripts/do-webcore-rename: More planned renaming.
665
666 2007-12-02  Sam Weinig  <sam@webkit.org>
667
668         Rubber stamped by Anders.
669
670         Use [NSURL absoluteString] instead of [NSURL description] in order to get
671         more uniform results cross platform.
672
673         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
674         (-[NSURL _drt_descriptionSuitableForTestResult]):
675
676 2007-12-02  Sam Weinig  <sam@webkit.org>
677
678         Rubber stamped by Niko.
679
680         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
681
682         * DumpRenderTree/win/DumpRenderTree.cpp:
683         * DumpRenderTree/win/DumpRenderTree.vcproj:
684         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
685         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
686         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
687         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
688
689 2007-12-01  Alp Toker  <alp@atoker.com>
690
691         Reviewed by Adam Roben.
692
693         Make use of the newly introduced webkit.h convenience header.
694
695         * GtkLauncher/main.c:
696
697 2007-12-01  Adam Treat  <treat@kde.org>
698
699         Reviewed by Simon.
700
701         * Check to see if the directory exists and exit if not.
702
703         * DumpRenderTree/qt/main.cpp:
704         (main):
705
706 2007-12-01  Adam Treat  <treat@kde.org>
707
708         Reviewed by Simon.
709
710         * Don't hide symbols when in Debug mode
711         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
712
713
714         * DumpRenderTree/qt/main.cpp:
715         (messageHandler):
716
717 2007-11-30  Alp Toker  <alp@atoker.com>
718
719         Reviewed by Adam Roben.
720
721         http://bugs.webkit.org/show_bug.cgi?id=15691
722         [GTK] Public API does not follow GTK+ conventions
723
724         Refactor the WebKit/GTK+ public API. Changes:
725           WebKitPage -> WebKitWebView
726           WebKitFrame -> WebKitWebFrame
727
728         Public API source and header names have been updated to mirror the API
729         changes.
730
731         The API is now kept in WebKit/gtk/WebView to match other ports in the
732         same class such as Mac and Win.
733
734         * GtkLauncher/main.c:
735         (activate_uri_entry_cb):
736         (link_hover_cb):
737         (title_change_cb):
738         (progress_change_cb):
739         (go_back_cb):
740         (go_forward_cb):
741         (create_browser):
742         (main):
743
744 2007-11-30  Adam Roben  <aroben@apple.com>
745
746         Hopefully the final build fix
747
748         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
749         pull in WTF's assertion/logging functions.
750
751 2007-11-30  Adam Roben  <aroben@apple.com>
752
753         Another build fix
754
755         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
756         WebKit.lib.
757
758 2007-11-30  Adam Roben  <aroben@apple.com>
759
760         Debug build fix
761
762         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
763         configuration.
764         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
765         projects.
766         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
767         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
768         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
769
770 2007-11-30  Sam Weinig  <sam@webkit.org>
771
772         Reviewed by Adam Roben.
773
774         Fix drawSelectionRect to actually draw the selection rect.
775
776         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
777         (drawSelectionRect):
778
779 2007-11-30  Darin Adler  <darin@apple.com>
780
781         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
782
783 2007-11-30  Darin Adler  <darin@apple.com>
784
785         * Scripts/do-webcore-rename: Get ready for some future renaming.
786
787 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
788
789         Reviewed by Adam.
790
791         - Removed some unnecessary functions and changed an unused return type. 
792
793         * Drosera/win/DebuggerClient.cpp:
794         (registerConsoleClass):
795         * Drosera/win/DebuggerClient.h:
796         * Drosera/win/Drosera.cpp:
797         (registerDroseraClass):
798
799 2007-11-28  Alp Toker  <alp@atoker.com>
800
801         Reviewed by Timothy Hatcher.
802
803         http://bugs.webkit.org/show_bug.cgi?id=16174
804         [GTK] Use "URI" not "URL" in public API
805
806         Replace use of the term "URL" with "URI" in public headers,
807         documentation and some internal code to match GLib/GTK+ convention.
808
809         This is now mentioned in the API guidelines:
810           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
811
812         * GtkLauncher/main.c:
813         (activate_uri_entry_cb):
814         (title_change_cb):
815         (create_toolbar):
816         (main):
817
818 2007-11-29  Anders Carlsson  <andersca@apple.com>
819
820         Reviewed by Sam.
821
822         <rdar://problem/5230478>
823         FrameLoadDelegate callbacks are not dumped in DRT.
824         
825         * DumpRenderTree/win/DumpRenderTree.cpp:
826         (shouldLogFrameLoadDelegates):
827         (runTest):
828         (main):
829         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
830         (BSTRtoString):
831         (descriptionSuitableForTestResult):
832         (FrameLoadDelegate::QueryInterface):
833         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
834         (FrameLoadDelegate::didFailProvisionalLoadWithError):
835         (FrameLoadDelegate::didCommitLoadForFrame):
836         (FrameLoadDelegate::didFinishLoadForFrame):
837         (FrameLoadDelegate::willCloseFrame):
838         (FrameLoadDelegate::didClearWindowObject):
839         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
840         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
841         * DumpRenderTree/win/FrameLoaderDelegate.h:
842         (FrameLoadDelegate::windowScriptObjectAvailable):
843         (FrameLoadDelegate::didFirstLayoutInFrame):
844
845 2007-11-29  Sam Weinig  <sam@webkit.org>
846
847         Reviewed by Anders.
848
849         Add database quota UIDelegates methods to DRT UIDelegate.
850
851         * DumpRenderTree/mac/UIDelegate.mm:
852         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
853         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
854
855 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
856
857         Reviewed by Sam.
858
859         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
860         dying and vice versa.
861         - This fix will allow Drosera and Safari to reconnect if either of them
862         closes correctly, but does not fix the case where one of them dies
863         silently.
864
865         * Drosera/win/ServerConnection.cpp:
866         (ServerConnection::attemptToCreateServerConnection): Added a safety
867         check, because it's possilbe to try to connect to a server that's dying.
868         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
869         the server has died.
870         * Drosera/win/ServerConnection.h: Added the new function and removed
871         an unnecessary member.
872
873 2007-11-29  Anders Carlsson  <andersca@apple.com>
874
875         * DumpRenderTree/win/DumpRenderTree.vcproj:
876         Add shlwapi.lib to all configurations.
877
878 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
879
880         - Build fix.  Added additional includes for VS Express to the Release
881         project.
882
883         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
884
885 2007-11-29  Anders Carlsson  <andersca@apple.com>
886
887         Reviewed by Adam.
888
889         <rdar://problem/5132005>
890         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
891         
892         * DumpRenderTree/win/DumpRenderTree.vcproj:
893         Add shlwapi.lib
894         
895         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
896         (LayoutTestController::setUserStyleSheetEnabled):
897         Implement this.
898         
899         (appendComponentToPath):
900         New method which wraps the Win32 API PathAppend.
901         
902         (followShortcuts):
903         New method which checks if a file points to a shortcut and
904         follows the shortcut.
905         
906         (resolveCygwinPath):
907         New method that takes a cygwin unix-style path and returns the Win32 path.
908         
909         (cfStringRefToWString):
910         
911         (LayoutTestController::setUserStyleSheetLocation):
912         Implement this.
913
914 2007-11-29  Alice Liu  <alice.liu@apple.com>
915
916         Reviewed by Adam.
917
918         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
919
920         * DumpRenderTree/win/EventSender.cpp:
921         (keyDownCallback):
922         uppercase letters were being sent as lowercase letters without the shift key down.
923
924 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
925
926         - Windows build fix. VS express needs some love.
927
928         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
929
930 2007-11-28  Darin Adler  <darin@apple.com>
931
932         Reviewed by Adam Roben.
933
934         * DumpRenderTree/mac/EventSendingController.mm:
935         (-[EventSendingController keyDown:withModifiers:]):
936         Send capital letters through as lowercase letters with the shift key down
937         rather than sending them as if they were highly unusual "capital letter keys".
938
939         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
940         where you need to update results and more tests are failing than before.
941
942 2007-11-28  Anders Carlsson  <andersca@apple.com>
943
944         Reviewed by Darin.
945
946         <rdar://problem/5132001>
947         contextClick is not implemented in DRT on Windows.
948         
949         * DumpRenderTree/win/EventSender.cpp:
950         (contextClickCallback):
951         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
952         by a WM_RBUTTONUP message.
953         
954         * DumpRenderTree/win/UIDelegate.cpp:
955         (UIDelegate::hasCustomMenuImplementation):
956         (UIDelegate::trackCustomPopupMenu):
957         * DumpRenderTree/win/UIDelegate.h:
958         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
959         menu from being shown (and causing the DRT to hang).
960
961 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
962
963         Reviewed by Darin.
964
965         Fix DumpRenderTree ObjC bug comparing strings.
966
967         * DumpRenderTree/mac/ObjCController.m:
968         (-[ObjCController identityIsEqual::]): Compare strings with string
969         equality instead of identiy equality.
970
971 2007-11-27  Timothy Hatcher  <timothy@apple.com>
972
973         Reviewed by Sam.
974
975         Reset the authorAndUserStylesEnabled preference
976         back to YES for each test. Fixes the broken tests.
977
978         * DumpRenderTree/mac/DumpRenderTree.mm:
979         (resetWebViewToConsistentStateBeforeTesting):
980
981 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
982
983         Reviewed by Adam.
984
985         - Drosera now displays the console window, although it cannot currently
986         process JavaScript.
987
988         * Drosera/win/DebuggerClient.cpp: Shows the console window.
989         (registerConsoleClass): Implemented.
990         (consoleWndProc): Implemented.
991         (DebuggerClient::onSize): Implemented.
992         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
993         new window.
994         * Drosera/win/DebuggerClient.h: Added needed method and members for 
995         creating and maintaining a new window.
996         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
997         lines of code to more appropriate places.
998         (Drosera::handleCommand):
999         (Drosera::initUI):
1000         (Drosera::onSize):
1001         (Drosera::attach):
1002
1003 2007-11-27  Timothy Hatcher  <timothy@apple.com>
1004
1005         Reviewed by Dave Hyatt.
1006
1007         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
1008         
1009         Add support for disabling author and user styles for testing.
1010
1011         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1012         * DumpRenderTree/LayoutTestController.cpp:
1013         (setAuthorAndUserStylesEnabledCallback):
1014         (LayoutTestController::staticFunctions):
1015         * DumpRenderTree/LayoutTestController.h:
1016         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1017         (LayoutTestController::setAuthorAndUserStylesEnabled):
1018         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1019         (LayoutTestController::setAuthorAndUserStylesEnabled):
1020
1021 2007-11-26  Dan Bernstein  <mitz@apple.com>
1022
1023         - Tiger build fix.
1024
1025         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1026
1027 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
1028
1029         Reviewed by Maciej.
1030
1031         - Implemented displaying variables for Drosera on Win.
1032
1033         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
1034         that retrieve variables to not hold onto the return value since it's
1035         not returned.  Also changed to use the new signatures of the retrieval
1036         functions.
1037         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1038         (DebuggerDocument::platformValueForScopeVariableNamed):
1039         * Drosera/win/Drosera.cpp: Removed a needless TODO.
1040         (droseraWndProc):
1041
1042 2007-11-26  Sam Weinig  <sam@webkit.org>
1043
1044         Cleanup names of painting and repainting functions.
1045
1046         Reviewed by Adam Roben.
1047
1048         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1049         (drawSelectionRect): was drawSelectionRectIntoContext.
1050         (dumpWebViewAsPixelsAndCompareWithExpected):
1051         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1052         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1053         (paintWebView): was drawWebViewIntoContext.
1054         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
1055
1056 2007-11-26  Sam Weinig  <sam@webkit.org>
1057
1058         Reviewed by Dan Bernstein.
1059
1060         - Leopard build fix
1061
1062         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1063
1064 2007-11-26  Sam Weinig  <sam@webkit.org>
1065
1066         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
1067         Use shared PixelDumpSupport for Mac DRT
1068
1069         Reviewed by Adam Roben.
1070
1071         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1072         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
1073         * DumpRenderTree/cg/ImageDiffCG.cpp:
1074         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1075         (drawSelectionRectIntoContext):
1076         (dumpWebViewAsPixelsAndCompareWithExpected):
1077         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1078         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1079         * DumpRenderTree/mac/DumpRenderTree.mm:
1080         (dump):
1081         * DumpRenderTree/mac/ImageDiff.m: Removed.
1082         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
1083         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
1084         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
1085         (setDefaultColorProfileToRGB):
1086         (getBitmapContextFromWebView):
1087         (drawWebViewIntoContext):
1088         (repaintWithVerticalSweep):
1089         (repaintWithHorizontalSweep):
1090         (getSelectionRect):
1091         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
1092
1093 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
1094
1095         Bug 16052: prepare-ChangeLog doesn't report deleted files
1096         <http://bugs.webkit.org/show_bug.cgi?id=16052>
1097
1098         Reviewed by Sam.
1099
1100         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
1101
1102 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
1103
1104         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
1105         <http://bugs.webkit.org/show_bug.cgi?id=15864>
1106
1107         Reviewed by Adam.
1108
1109         Roll functionality of merge-changelog into resolve-ChangeLogs
1110         script.  The script now checks for ChangeLog.rej and
1111         ChangeLog.orig files first.  If it finds them, it uses the
1112         ChangeLog.rej file as a patch (in old contextual diff format) to
1113         apply with --fuzz=3.
1114
1115         * Scripts/merge-changelog: Removed.
1116         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
1117
1118 2007-11-25  Sam Weinig  <sam@webkit.org>
1119
1120         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
1121
1122         Reviewed by Mark Rowe.
1123
1124         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1125         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1126         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1127         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
1128         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
1129
1130 2007-11-25  Sam Weinig  <sam@webkit.org>
1131
1132         Convert DumpRenderTree to ues .xcconfig files.
1133
1134         Reviewed by Mark Rowe.
1135
1136         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1137         * DumpRenderTree/mac/Configurations: Added.
1138         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
1139         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
1140         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
1141
1142 2007-11-25  Sam Weinig  <sam@webkit.org>
1143
1144         Add ForwardingHeaders to wtf for DumpRenderTree.
1145
1146         Reviewed by Mark Rowe.
1147
1148         * DumpRenderTree/DumpRenderTree.h:
1149         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1150         * DumpRenderTree/ForwardingHeaders: Added.
1151         * DumpRenderTree/ForwardingHeaders/wtf: Added.
1152         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
1153         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
1154         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
1155         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
1156         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
1157         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
1158         * DumpRenderTree/LayoutTestController.cpp:
1159         * DumpRenderTree/WorkQueue.cpp:
1160         * DumpRenderTree/mac/DumpRenderTree.mm:
1161         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1162         * DumpRenderTree/mac/JavaScriptThreading.cpp:
1163         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1164         * DumpRenderTree/mac/ObjCController.m:
1165         * DumpRenderTree/mac/UIDelegate.mm:
1166         * DumpRenderTree/mac/WorkQueueItemMac.mm:
1167
1168 2007-11-25  Adam Roben  <aroben@apple.com>
1169
1170         Fix some test failures caused by r28019
1171
1172         Now that stdout is in binary mode, we need to always use printf
1173         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
1174         the output.
1175
1176         Reviewed by Sam.
1177
1178         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
1179         printf.
1180         (UIDelegate::runJavaScriptAlertPanelWithMessage):
1181         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
1182         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
1183         (UIDelegate::webViewAddMessageToConsole):
1184
1185 2007-11-25  Adam Roben  <aroben@apple.com>
1186
1187         Set the font smoothing preference in DRT
1188
1189         This makes the pixel results on Windows closer to the Mac results.
1190
1191         Reviewed by Mitz.
1192
1193         * DumpRenderTree/win/DumpRenderTree.cpp:
1194         (initializePreferences):
1195
1196 2007-11-25  Adam Roben  <aroben@apple.com>
1197
1198         Port ImageDiff to CG and C++
1199
1200         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
1201         <rdar://5071708>
1202
1203         Reviewed by Sam.
1204
1205         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
1206         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
1207         (main):
1208         (createImageFromStdin):
1209         (compareImages):
1210         (getDifferenceBitmap):
1211         (computePercentageDifferent):
1212         * DumpRenderTree/win/ImageDiff.vcproj: Added.
1213
1214 2007-11-25  Adam Roben  <aroben@apple.com>
1215
1216         Fix image diff link generation on Windows
1217
1218         Reviewed by Sam.
1219
1220         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
1221         to toURL.
1222
1223 2007-11-25  Adam Roben  <aroben@apple.com>
1224
1225         Implement pixel dumping in Windows DRT
1226
1227         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
1228         <rdar://5071708>
1229
1230         Reviewed by Sam.
1231
1232         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
1233         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
1234         Content-Length header.
1235         (getMD5HashStringForBitmap):
1236         (dumpWebViewAsPixelsAndCompareWithExpected):
1237         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
1238         * DumpRenderTree/win/DumpRenderTree.cpp:
1239         (dump): Do a pixel dump if requested.
1240         (main): Parse pixel test options.
1241         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
1242         the cg/ subdirectory to the include path.
1243         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
1244         available in a header or import library, so we have to go through this
1245         LoadLibrary/GetProcAddress dance to use them.
1246         (cryptDLL):
1247         (init):
1248         (update):
1249         (final):
1250         (MD5_Init):
1251         (MD5_Update):
1252         (MD5_Final):
1253         * DumpRenderTree/win/MD5.h: Added.
1254         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
1255         moved up to the top level to share it with Mac eventually.
1256         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
1257         (getBitmapContextFromWebView): Forces the WebView to paint using a
1258         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
1259
1260 2007-11-25  Adam Roben  <aroben@apple.com>
1261
1262         Clean up Windows DRT's option parsing a little bit
1263
1264         Reviewed by Sam.
1265
1266         * DumpRenderTree/win/DumpRenderTree.cpp:
1267         (main): Put non-option arguments into a Vector.
1268
1269 2007-11-25  Adam Roben  <aroben@apple.com>
1270
1271         Make Windows DRT stop changing LF into CRLF
1272
1273         Reviewed by Sam.
1274
1275         * DumpRenderTree/win/DumpRenderTree.cpp:
1276         (main): Put stdout in binary mode.
1277         * Scripts/run-webkit-tests: Remove the CRLF hack.
1278
1279 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
1280
1281         Removed empty directory.
1282
1283         * Scripts/resources: Removed.
1284
1285 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
1286
1287         Fix bisect-builds to work with recent WebKit nightly builds.
1288
1289         Reviewed by Dan.
1290
1291         * Scripts/bisect-builds: Check for the 
1292         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
1293         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
1294         to WebKit.app/Contents/Resources.
1295
1296 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
1297
1298         Reviewed by Maciej.
1299
1300         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
1301         not closed (affects digg.com)
1302
1303         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
1304         one after finishing with a test to avoid having its delayed onload handler firing when
1305         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
1306         but it helps somewhat.
1307
1308 2007-11-22  Mark Rowe  <mrowe@apple.com>
1309
1310         Reviewed by Alp Toker.
1311
1312         Fix build-webkit to propagate make's exit status if it fails.
1313
1314         * Scripts/webkitdirs.pm:
1315
1316 2007-11-22  Dan Bernstein  <mitz@apple.com>
1317
1318         Reviewed by Mark Rowe.
1319
1320         - fix crash when running pixel tests
1321
1322         * DumpRenderTree/mac/DumpRenderTree.mm:
1323         (dumpRenderTree): Parse the command line options before setting up the
1324         environment so that we know if we need to set up the pixel dump
1325         machinery.
1326
1327 2007-11-21  Eric Seidel  <eric@webkit.org>
1328
1329         Speculative build fix for Tiger.
1330
1331         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
1332
1333 2007-11-21  Eric Seidel  <eric@webkit.org>
1334
1335         Reviewed by Tim Hatcher.
1336
1337         Break out more of DumpRenderTree.mm into individual files
1338
1339         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1340         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
1341         (checkedMalloc):
1342         (checkedRealloc):
1343         (makeLargeMallocFailSilently):
1344         * DumpRenderTree/mac/CheckedMalloc.h: Added.
1345         * DumpRenderTree/mac/DumpRenderTree.mm:
1346         (crashHandler):
1347         (dump):
1348         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1349         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
1350         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
1351         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1352         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1353         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
1354         (javaScriptThreads):
1355         (runJavaScriptThread):
1356         (startJavaScriptThreads):
1357         (stopJavaScriptThreads):
1358         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
1359         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
1360         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
1361         (restoreColorSpace):
1362         (setDefaultColorProfileToRGB):
1363         (initializeColorSpaceAndScreeBufferForPixelTests):
1364         (md5HashStringForBitmap):
1365         (dumpWebViewAsPixelsAndCompareWithExpected):
1366
1367 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
1368
1369         Move install-unix-extras to wx directory as it seems only to be used by that 
1370         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
1371         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
1372         have install-unix-extras install into WebKitLibraries as per
1373         convention.
1374         
1375         Reviewed by Mark Rowe.
1376
1377         * Scripts/install-unix-extras: Removed.
1378         * wx/build-wxwebkit:
1379         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
1380
1381 2007-11-21  Eric Seidel  <eric@webkit.org>
1382
1383         Reviewed by Adam.
1384
1385         More refactoring for greater code readability
1386
1387         * DumpRenderTree/mac/DumpRenderTree.mm:
1388         (initializeGlobalsFromCommandLineOptions):
1389         (initializeColorSpaceAndScreeBufferForPixelTests):
1390         (addTestPluginsToPluginSearchPath):
1391         (useLongRunningServerMode):
1392         (runTestingServerLoop):
1393         (prepareConsistentTestingEnvironment):
1394         (dumpRenderTree):
1395         (main):
1396         (dumpFramesAsText):
1397         (dumpBackForwardListForWebView):
1398         (sizeWebViewForCurrentTest):
1399         (methodNameStringForFailedTest):
1400         (dumpBackForwardListForAllWindows):
1401         (dumpWebViewAsPixelsAndCompareWithExpected):
1402         (invalidateAnyPreviousWaitToDumpWatchdog):
1403         (dump):
1404         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1405         * DumpRenderTree/mac/UIDelegate.mm:
1406         (-[UIDelegate webView:createWebViewWithRequest:]):
1407
1408 2007-11-21  Eric Seidel  <eric@webkit.org>
1409
1410         Reviewed by Tim Hatcher.
1411
1412         Abstract more of DRT into static methods
1413
1414         * DumpRenderTree/mac/DumpRenderTree.mm:
1415         (setDefaultsToConsistentValuesForTesting):
1416         (setupSignalHandlers):
1417         (allocateGlobalControllers):
1418         (releaseAndZero):
1419         (releaseGlobalControllers):
1420         (dumpRenderTree):
1421         (shouldLogFrameLoadDelegates):
1422         (createCFURLFromPathOrURL):
1423         (resetWebViewToConsistentStateBeforeTesting):
1424         (runTest):
1425
1426 2007-11-21  Eric Seidel  <eric@webkit.org>
1427
1428         Reviewed by Tim Hatcher.
1429
1430         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
1431
1432         * DumpRenderTree/DumpRenderTree.h:
1433         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1434         * DumpRenderTree/mac/DumpRenderTree.mm:
1435         (dumpRenderTree):
1436         (dump):
1437         (runTest):
1438         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
1439         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
1440         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
1441         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
1442         (-[DumpRenderTreePasteboard declareType:owner:]):
1443         (+[LocalPasteboard alloc]):
1444         (-[LocalPasteboard init]):
1445         (-[LocalPasteboard dealloc]):
1446         (-[LocalPasteboard name]):
1447         (-[LocalPasteboard releaseGlobally]):
1448         (-[LocalPasteboard declareTypes:owner:]):
1449         (-[LocalPasteboard addTypes:owner:]):
1450         (-[LocalPasteboard changeCount]):
1451         (-[LocalPasteboard types]):
1452         (-[LocalPasteboard availableTypeFromArray:]):
1453         (-[LocalPasteboard setData:forType:]):
1454         (-[LocalPasteboard dataForType:]):
1455         (-[LocalPasteboard setPropertyList:forType:]):
1456         (-[LocalPasteboard setString:forType:]):
1457         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
1458         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
1459         (+[DumpRenderTreeWindow allWindows]):
1460         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
1461         (-[DumpRenderTreeWindow dealloc]):
1462         (-[DumpRenderTreeWindow isKeyWindow]):
1463         (-[DumpRenderTreeWindow keyDown:]):
1464
1465 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
1466
1467         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
1468         it indiscriminately copies any headers inside JavaScriptCore,
1469         which includes Tiger ICU headers. 
1470
1471         * wx/build-wxwebkit:
1472         Don't run WebCore/move-js-headers.sh any longer.
1473
1474 2007-11-20  Adam Treat  <treat@kde.org>
1475
1476         Reviewed by David Kilzer.
1477
1478         * Prepend git branch name to $baseProductDir
1479
1480         * Scripts/VCSUtils.pm:
1481         * Scripts/webkitdirs.pm:
1482
1483 2007-11-20  Mark Rowe  <mrowe@apple.com>
1484
1485         Reviewed by Simon Hausmann.
1486
1487         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
1488         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
1489         Have it trigger a "make distclean" rather than "make clean" to ensure that the
1490         built product and generated Makefile's are removed.
1491
1492 2007-11-19  Alp Toker  <alp@atoker.com>
1493
1494         Reviewed by Mark Rowe.
1495
1496         http://bugs.webkit.org/show_bug.cgi?id=16040
1497         [GTK] GtkLauncher should be written in C
1498
1499         Port GtkLauncher to plain C.
1500
1501         Use a more conventional GTK+ coding style.
1502
1503         Use a toolbar instead of menus.
1504
1505         Various signature fixes and cleanups.
1506
1507         Add a license header. Assume all previous modifications were copyright
1508         assigned to Apple Inc. by default.
1509
1510         * GtkLauncher/GtkLauncher.pro:
1511         * GtkLauncher/main.c: Added.
1512         (activate_url_entry_cb):
1513         (update_title):
1514         (link_hover_cb):
1515         (title_change_cb):
1516         (progress_change_cb):
1517         (destroy_cb):
1518         (go_back_cb):
1519         (go_forward_cb):
1520         (create_browser):
1521         (create_statusbar):
1522         (create_toolbar):
1523         (create_window):
1524         (main):
1525         * GtkLauncher/main.cpp: Removed.
1526
1527 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
1528
1529         Build script fixes to ensure they do the right thing for the 
1530         wx port, and update build-wxwebkit to reflect the way the
1531         build scripts now work.
1532
1533         Reviewed by Adam.
1534
1535         * Scripts/build-testkjs:
1536         * Scripts/build-webkit:
1537         * Scripts/run-javascriptcore-tests:
1538         * Scripts/webkitdirs.pm:
1539         * wx/build-wxwebkit:
1540
1541 2007-11-18  Eric Seidel  <eric@webkit.org>
1542
1543         Reviewed by Anders.
1544
1545         Make run-javascriptcore-tests report failures on exit (to support git bisect)
1546
1547         * Scripts/run-javascriptcore-tests:
1548
1549 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
1550
1551         Reviewed by Adam Roben.
1552
1553         Make run-webkit-tests work with Windows debug build.
1554
1555         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
1556         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
1557         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
1558         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
1559         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
1560
1561 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
1562
1563         Add wxWebKit sample and build script, and integrate it with 
1564         build-webkit. Also make build-webkit --clean work for all
1565         ports.
1566
1567         Reviewed by Darin Adler.
1568
1569         * Scripts/build-webkit:
1570         * Scripts/webkitdirs.pm:
1571         * wx: Added.
1572         * wx/browser: Added.
1573         * wx/browser/browser.bkl: Added.
1574         * wx/browser/browser.cpp: Added.
1575         * wx/build-wxwebkit: Added.
1576
1577 2007-11-17  Adam Roben  <aroben@apple.com>
1578
1579         Make it easy to run Safari in the debugger on Windows
1580
1581         I've added a new script, debug-safari, which launches Safari in the
1582         debugger. On OS X it just calls gdb-safari.
1583
1584         Reviewed by Mark Rowe.
1585
1586         * FindSafari/FindSafari.cpp:
1587         (_tmain): Added a /debugger flag, which in combination with
1588         /printSafariLauncher will print a script that launches Safari in the
1589         debugger.
1590         * Scripts/debug-safari: Added.
1591         * Scripts/run-safari: Changed to call runSafari().
1592         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
1593         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
1594         first argument along to FindSafari.
1595         * Scripts/webkitdirs.pm:
1596         (sub runSafari): Added.
1597
1598 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
1599
1600         Reviewed by Adam Roben.
1601
1602         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
1603
1604 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
1605
1606         Reviewed by David Kilzer.
1607
1608         The git config command was renamed to repo-config at some point. This
1609         change tries git config and then git repo-config if the first fails.
1610
1611         * Scripts/prepare-ChangeLog:
1612         (gitConfig):
1613
1614 2007-11-16  Dan Bernstein  <mitz@apple.com>
1615
1616         Reviewed by Darin Adler and Sam Weinig.
1617
1618         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
1619
1620         * DumpRenderTree/win/EventSender.cpp:
1621         (keyDownCallback): For characters that cannot be entered on the active
1622         keyboard layout, send a WM_CHAR message with the character along with
1623         a WM_KEYDOWN message with a virtual key code of 255.
1624
1625 2007-11-16  Mark Rowe  <mrowe@apple.com>
1626
1627         Reviewed by Tim Hatcher.
1628
1629         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
1630
1631         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1632         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1633
1634 2007-11-15  Adam Roben  <aroben@apple.com>
1635
1636         Make run-safari actually work on Windows
1637
1638         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
1639         chdir call.
1640
1641 2007-11-14  Adam Roben  <aroben@apple.com>
1642
1643         Updates to Safari launching now that 3.0.4 is released
1644
1645         Reviewed by Sam.
1646
1647         * FindSafari/FindSafari.cpp:
1648         (getWebViewCLSID): Use version-independent ProgID.
1649         * Scripts/run-safari: Use run-webkit-nightly.cmd.
1650
1651 2007-11-14  Anders Carlsson  <andersca@apple.com>
1652
1653         Reviewed by Adam.
1654
1655         <rdar://problem/5309081>
1656         In DRT, "plugin.logDestroy = true" not working on Windows.
1657         
1658         * DumpRenderTree/win/TestNetscapePlugin/main.c:
1659         (NPP_Destroy):
1660
1661 2007-11-14  Eric Seidel  <eric@webkit.org>
1662
1663         Reviewed by Sam.
1664
1665         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
1666
1667 2007-11-14  Anders Carlsson  <andersca@apple.com>
1668
1669         Reviewed by Adam.
1670
1671         <rdar://problem/5141186>
1672         window.layoutTestController.setWindowIsKey is not implemented in DRT.
1673         
1674         Implement setWindowIsKey.
1675         
1676         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1677         (LayoutTestController::setWindowIsKey):
1678
1679 2007-11-13  Sam Weinig  <sam@webkit.org>
1680
1681         Reviewed by Adam Roben.
1682
1683         Fix for <rdar://problem/5382579>
1684         http/tests/security/cross-frame-access-put.html reports large 
1685         negative numbers for screenLeft and screenTop (Mac reports "0")
1686
1687         * DumpRenderTree/win/UIDelegate.cpp:
1688         (UIDelegate::UIDelegate): Initialize the RECT.
1689         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
1690         (UIDelegate::webViewFrame): ditto.
1691         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
1692
1693 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
1694
1695         Reviewed by Adam.
1696
1697         - Make Drosera show source, source URLs, and function stack on Windows,
1698         and some minor fixes.
1699
1700         * Drosera/DebuggerDocument.cpp: Force source to always update display.
1701         (DebuggerDocument::updateFileSource):
1702         * Drosera/debugger.js: Force source to always update display.
1703         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
1704         menu controls.
1705         (DebuggerClient::resume):
1706         (DebuggerClient::pause):
1707         (DebuggerClient::stepInto):
1708         (DebuggerClient::stepOver):
1709         (DebuggerClient::stepOut):
1710         (DebuggerClient::showConsole):
1711         (DebuggerClient::closeCurrentFile):
1712         * Drosera/win/DebuggerClient.h: Ditto.
1713         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
1714         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
1715         removed two bugs.  1) caller could be in a bad state when asked to
1716         assign into it. 2) BSTRs were not created correctly.
1717         (DebuggerDocument::getPlatformCurrentFunctionStack):
1718         * Drosera/win/Drosera.cpp: Hook up the menu controls.
1719         (droseraWndProc):
1720         (handleCommand):
1721         (Drosera::resume):
1722         (Drosera::pause):
1723         (Drosera::stepInto):
1724         (Drosera::stepOver):
1725         (Drosera::stepOut):
1726         (Drosera::showConsole):
1727         (Drosera::closeCurrentFile):
1728         * Drosera/win/Drosera.h: Hook up the menu controls.
1729         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
1730         functions, added a null check, and fixed another bug where caller could
1731         be in a bad state when asked to assign into it.
1732         (ServerConnection::didLoadMainResourceForDataSource):
1733         (ServerConnection::getCallerFrame):
1734         * Drosera/win/ServerConnection.h: Safety first.
1735
1736 2007-11-13  Dan Bernstein  <mitz@apple.com>
1737
1738         Reviewed by Darin Adler.
1739
1740         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
1741           DumpRenderTree --pixel-tests renders each test twice
1742
1743         * DumpRenderTree/mac/DumpRenderTree.mm:
1744         (dumpRenderTree): Removed the --paint option because the painting code
1745         is always exercised as a result of
1746         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
1747         calling -displayIfNeeded.
1748         (dump): Changed to always grab the image from the window since the view
1749         is always displayed.
1750         (runTest):
1751         (displayWebView):
1752         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
1753         because it always paints.
1754
1755 2007-11-12  Antti Koivisto  <antti@apple.com>
1756
1757         Reviewed by Adele.
1758         
1759         Add support for http media tests
1760
1761         * Scripts/run-webkit-tests:
1762
1763 2007-11-12  Sam Weinig  <sam@webkit.org>
1764
1765         Reviewed by Adam Roben.
1766
1767         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
1768
1769         * DumpRenderTree/win/DumpRenderTree.cpp:
1770         (runTest):
1771         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1772         (LayoutTestController::setPrivateBrowsingEnabled):
1773
1774 2007-11-12  Adam Roben  <aroben@apple.com>
1775
1776         * Scripts/update-webkit-localizable-strings: Changed to only scan the
1777         mac and win subdirectories.
1778
1779 2007-11-11  Adam Roben  <aroben@apple.com>
1780
1781         Fix <rdar://5133816> keepWebHistory is not implemented
1782
1783         Fixes fast/history/clicked-link-is-visited.html.
1784
1785         Reviewed by Darin.
1786
1787         * DumpRenderTree/win/DumpRenderTree.cpp:
1788         (runTest): Clear the optionalSharedHistory.
1789         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1790         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
1791
1792 2007-11-10  Sam Weinig  <sam@webkit.org>
1793
1794         Reviewed by Tim Hatcher.
1795
1796         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
1797         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
1798         is turned on)
1799
1800         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
1801
1802         Added test: http/tests/security/cross-frame-access-private-browsing.html
1803
1804         * DumpRenderTree/LayoutTestController.cpp:
1805         (setPrivateBrowsingEnabledCallback):
1806         (LayoutTestController::staticFunctions):
1807         * DumpRenderTree/LayoutTestController.h:
1808         * DumpRenderTree/mac/DumpRenderTree.mm:
1809         (runTest): Default to private browsing disabled.
1810         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1811         (LayoutTestController::setPrivateBrowsingEnabled):
1812         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1813         (LayoutTestController::setPrivateBrowsingEnabled):
1814
1815 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1816
1817         Reviewed by Adam.
1818
1819         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
1820         WebCore's!
1821
1822         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
1823         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
1824         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
1825         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
1826         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
1827         * Drosera/win/Drosera.cpp:
1828         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1829
1830 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1831
1832         Reviewed by Sam.
1833
1834         - Use the new IWebFrame [local] function signature and get the shared
1835         server correctly.
1836
1837         * Drosera/win/DebuggerClient.cpp:
1838         (DebuggerClient::didFinishLoadForFrame):
1839         * Drosera/win/ServerConnection.cpp:
1840         (ServerConnection::attemptToCreateServerConnection):
1841
1842 2007-11-07  Dan Bernstein  <mitz@apple.com>
1843
1844         Reviewed by Darin Adler.
1845
1846         - add an option to run-webkit-tests to ignore pixel test failures where
1847           all pixels differ by no more than a specified threshold
1848
1849         * DumpRenderTree/mac/ImageDiff.m:
1850         (main):
1851         (compareImages):
1852         (computePercentageDifferent):
1853         * Scripts/run-webkit-tests:
1854
1855 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1856
1857         Reviewed by Lars.
1858
1859         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
1860
1861         * DumpRenderTree/qt/DumpRenderTree.cpp:
1862
1863 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1864
1865         Reviewed by Lars.
1866
1867         Reworked the QWebSettings API.
1868         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
1869
1870         * DumpRenderTree/qt/DumpRenderTree.cpp:
1871
1872 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1873
1874         Reviewed by Lars.
1875
1876         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
1877
1878         * DumpRenderTree/qt/jsobjects.cpp:
1879
1880 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1881
1882         Reviewed by Lars Knoll <lars@trolltech.com>.
1883
1884         Add a QWebPage::frameCreated() signal and fix DRT
1885         
1886         The removal of createFrame in QWebPage broke the re-implementation
1887         in DumpRenderTree. Instead emit a frameCreated() signal and
1888         connect to it in DumpRenderTree.
1889         
1890
1891         * DumpRenderTree/qt/DumpRenderTree.cpp:
1892         (WebCore::WebPage::WebPage):
1893         (WebCore::DumpRenderTree::dump):
1894         (WebCore::DumpRenderTree::connectFrame):
1895         * DumpRenderTree/qt/DumpRenderTree.h:
1896
1897 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1898
1899         Reviewed by Lars Knoll <lars@trolltech.com>.
1900
1901         Moved all the event handlers from QWebFrame into QWebPage.
1902         
1903         This cleans up the public API and allows us to remove the
1904         HackWebFrame hack in DumpRenderTree.
1905         
1906
1907         * DumpRenderTree/qt/jsobjects.cpp:
1908         (EventSender::mouseDown):
1909         (EventSender::mouseUp):
1910         (EventSender::mouseMoveTo):
1911
1912 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1913
1914         Reviewed by Mark.
1915
1916         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
1917         to prevent the default implementation from popping up messageboxes.
1918
1919         * DumpRenderTree/qt/DumpRenderTree.cpp:
1920         (WebCore::WebPage::javaScriptConfirm):
1921         (WebCore::WebPage::javaScriptPrompt):
1922
1923 2007-11-06  Eric Seidel  <eric@webkit.org>
1924
1925         * Scripts/build-testkjs: build fix... too many $$
1926
1927 2007-11-06  Eric Seidel  <eric@webkit.org>
1928
1929         Reviewed by Mark Rowe.
1930
1931         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
1932
1933 2007-11-05  Adam Roben  <aroben@apple.com>
1934
1935         Add support on Windows for WEBKIT_TESTFONTS
1936
1937         This environment variable lets you specify where the fonts to be used
1938         by DumpRenderTree reside. The Qt port is already using this, so I'm
1939         just following their lead.
1940
1941         Reviewed by Darin.
1942
1943         * DumpRenderTree/win/DumpRenderTree.cpp:
1944         (exePath): Refactored code out of initialize().
1945         (fontsPath): Returns either $WEBKIT_TESTFONTS or
1946         DumpRenderTree.resources.
1947         (initialize): Use the new fontsPath function.
1948         (main): Use the new exePath function.
1949         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
1950         variable to DRT, like Qt does.
1951
1952 2007-11-05  Mark Rowe  <mrowe@apple.com>
1953
1954         Rubber-stamped by Alp Toker.
1955
1956         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
1957
1958         * GtkLauncher/main.cpp:
1959         (goToURLBarText):
1960         (main):
1961
1962 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
1963
1964         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
1965         <http://bugs.webkit.org/show_bug.cgi?id=15830>
1966
1967         Reviewed by Timothy.
1968
1969         Restrict the range of nightly builds used by the bisect-builds script
1970         based on the version of Safari and the version of Mac OS X being used.
1971
1972         Mac OS X 10.4: Safari 2.0: r11976 or newer
1973         Mac OS X 10.4: Safari 3.0: r19992 or newer
1974
1975         Mac OS X 10.5: Safari 2.0: r19594 or newer
1976         Mac OS X 10.5: Safari 3.0: r25124 or newer
1977
1978         * Scripts/bisect-builds:
1979         (findMacOSXVersion): Added.
1980         (makeNightlyList): Added argument to provide version of Mac OS X.
1981         Restrict range of nightly builds based on Safari and Mac OS X versions.
1982
1983 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
1984
1985         Reviewed by Maciej.
1986
1987         - This patch involves several changes, all of them were noticed that
1988         they were needed by the work being done in WebKit to get Drosera and
1989         WebKit working together on Windows.
1990         - The changes are:
1991         1) Added a debugger console for output messages.
1992         2) Drosera now listens for the WebKit server (before, the server would
1993         have to be running before Drosera was started.)
1994         3) Fixed a bug where the WebView started out as 0x0 pixels.
1995         4) Fixed a bug when there is no scope.
1996         5) Added the HTML, JS, and CSS to the project file to make them easy to
1997         find.
1998         6) Made the ServerConnection functions virtual.
1999
2000         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
2001         for the WebKit server.
2002         (DebuggerClient::DebuggerClient):
2003         (DebuggerClient::~DebuggerClient):
2004         (DebuggerClient::didFinishLoadForFrame):
2005         (DebuggerClient::serverConnected):
2006         (DebuggerClient::attemptToCreateServerConnection):
2007         * Drosera/win/DebuggerClient.h: Ditto.
2008         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
2009         scope.
2010         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2011         (DebuggerDocument::platformValueForScopeVariableNamed):
2012         * Drosera/win/Drosera.cpp:
2013         (_tWinMain): Added a console in debug for output messages.
2014         (Drosera::Drosera): Listen for server.
2015         (Drosera::initUI): The server now Initializes COM.
2016         (Drosera::serverConnected): Part of the listening for the server.
2017         (Drosera::attemptToCreateServerConnection): Ditto.
2018         * Drosera/win/Drosera.h: New interface for listening for the server.
2019         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
2020         files to the VS project.
2021         * Drosera/win/ServerConnection.cpp: Part of listening for the server
2022         connection.
2023         (ServerConnection::ServerConnection):
2024         (ServerConnection::attemptToCreateServerConnection):
2025         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
2026         methods.
2027         (ServerConnection::serverConnected):
2028
2029 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
2030
2031         Reviewed by Maciej.
2032
2033         http://bugs.webkit.org/show_bug.cgi?id=15832
2034         fast/dom/gc-10.html crashes when run alone
2035
2036         Check for !done before using objects that can be already deallocated.
2037
2038         * DumpRenderTree/mac/EditingDelegate.mm:
2039         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
2040         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
2041         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
2042         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
2043         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
2044         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2045         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
2046         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
2047         (-[EditingDelegate webViewDidBeginEditing:]):
2048         (-[EditingDelegate webViewDidChange:]):
2049         (-[EditingDelegate webViewDidEndEditing:]):
2050         (-[EditingDelegate webViewDidChangeTypingStyle:]):
2051         (-[EditingDelegate webViewDidChangeSelection:]):
2052         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2053         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2054         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2055         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2056         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
2057         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
2058         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
2059         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2060         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
2061         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
2062         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2063         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
2064         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
2065         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
2066         (-[FrameLoadDelegate webView:willCloseFrame:]):
2067         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
2068         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
2069         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2070         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2071         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2072         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
2073         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
2074         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
2075         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
2076
2077 2007-11-04  Mark Rowe  <mrowe@apple.com>
2078
2079         Build fix.  Don't use Carbon.h as the prefix header as it triggers
2080         warnings that would otherwise be suppressed due to it being a system header.
2081
2082         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2083
2084 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
2085
2086         Rubber stamped by Adam.
2087         
2088         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
2089
2090         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2091
2092 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2093
2094         Sort files(...); sections of Xcode project files.
2095
2096         Rubber-stamped by Darin.
2097
2098         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
2099         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2100         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2101         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2102
2103 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2104
2105         Script to sort "files(...);" sections in Xcode project.pbxproj files.
2106
2107         Reviewed by Darin.
2108
2109         * Scripts/sort-Xcode-project-file: Added.
2110
2111 2007-11-02  Darin Adler  <darin@apple.com>
2112
2113         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
2114
2115 2007-11-02  Darin Adler  <darin@apple.com>
2116
2117         Reviewed by Maciej.
2118
2119         * Scripts/run-sunspider: Pass the "--base" option through.
2120
2121         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
2122         the real script do that. Default configuration to Release to match run-sunspider
2123         so we don't end up building Debug just to compare results.
2124
2125 2007-11-01  Adam Roben  <aroben@apple.com>
2126
2127         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
2128
2129         Reviewed by Sam.
2130
2131         * Scripts/commit-log-editor: Show all the directories beneath the
2132         source root, instead of just the last one.
2133
2134 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
2135
2136         Reviewed by Adam Roben.
2137
2138         Print out an error message when the Windows build fails
2139         and provide guidance on how to find out what went wrong.
2140
2141         * Scripts/build-webkit:
2142         * Scripts/webkitdirs.pm:
2143
2144 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
2145
2146         Rubber-stamped by Adam Roben.
2147
2148         Rolled out r27326 - debug CRT seems to cause no problems after all.
2149
2150         * DumpRenderTree/win/DumpRenderTree.vcproj:
2151
2152 2007-10-31  Adam Roben  <aroben@apple.com>
2153
2154         Switch the Debug configuration to using the non-debug CRT
2155
2156         This matches WebKit.
2157
2158         Reviewed by Steve.
2159
2160         * DumpRenderTree/win/DumpRenderTree.vcproj:
2161
2162 2007-10-31  Antti Koivisto  <antti@apple.com>
2163
2164         Reviewed by bdash.
2165         
2166         Disable media tests when doing leak checking on Tiger.
2167         They crash in QuickTime (rdar://problem/5537157).
2168
2169         * Scripts/run-webkit-tests:
2170
2171 2007-10-29  Antti Koivisto  <antti@apple.com>
2172
2173         Reviewed by Maciej.
2174         
2175         Build media support by default on OSX only.
2176
2177         * Scripts/build-webkit:
2178
2179 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2180
2181         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
2182         get caught by the pre-commit hooks.
2183
2184 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2185
2186         Reviewed by Adam.
2187
2188         - This is a collection of relatively unrelated changes and cleanups
2189         to Drosera to prepare it for interacting with WebKit.  A lot of these
2190         changes are just correcting mistakes, for example removing included
2191         headers that are no longer needed.
2192
2193         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
2194         this will be needed by the DebuggerClient.
2195         (DebuggerDocument::server):
2196         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
2197         * Drosera/win/DebuggerClient.cpp: 
2198         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
2199         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
2200         (DebuggerClient::createWebViewWithRequest): Added comment about its
2201         purpose. 
2202         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
2203         declarations.
2204         (DebuggerClient::webViewLoaded): Moved.
2205         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
2206         file, since this was the only place it was used.
2207         (cfStringToBSTR):
2208         * Drosera/win/Drosera.h: Cleaned up the includes.
2209         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
2210         * Drosera/win/HelperFunctions.h: Removed.
2211
2212 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2213
2214         Reviewed by Adam.
2215
2216         - Small cleanup in the ServerConnection class.
2217
2218         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
2219         and added an include.
2220         (ServerConnection::currentFrame):
2221         (ServerConnection::getCallerFrame):
2222         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
2223         made a pointer into a COMPtr, and cleaned up the includes.
2224
2225 2007-10-29  Timothy Hatcher  <timothy@apple.com>
2226
2227         Reviewed by John Sullivan.
2228         
2229         - Place the Localizable.strings file in mac or win directories
2230           if that location exists.
2231         - Also look for UI_STRING in .c files.
2232
2233         * Scripts/extract-localizable-strings:
2234
2235 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2236
2237         Reviewed by Adam.
2238
2239         - Set the eol-style to native and made all the line endings the same
2240         so that I avoid messy diffs that show eol changes.
2241
2242         * Drosera/win/ServerConnection.cpp:
2243         (ServerConnection::didParseSource):
2244         (ServerConnection::didEnterCallFrame):
2245         (ServerConnection::willExecuteStatement):
2246         (ServerConnection::willLeaveCallFrame):
2247         (ServerConnection::exceptionWasRaised):
2248
2249 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2250
2251         Reviewed by Adam.
2252
2253         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
2254         functionality that could not have existed previously without the new
2255         interfaces.
2256         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
2257         from a BSTR to a JSValueRef.
2258         (DebuggerDocument::platformEvaluateScript): Implemented.
2259         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
2260         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2261         Implemented.
2262         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
2263         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
2264         * Drosera/win/ServerConnection.cpp: Added a helper function.
2265         (ServerConnection::getCallerFrame):
2266         * Drosera/win/ServerConnection.h: Added a helper function.
2267
2268 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
2269
2270         updated reviewers for my previous changelog.
2271
2272 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
2273         Reviewed by Maciej and Adam and Geoff.
2274
2275         - Minor mac-side improvements including moving a function to a more
2276         appropriate location, fixing a warning, and correctly checking
2277         exceptions.
2278
2279         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
2280         (DebuggerDocument::willExecuteStatement):
2281         (DebuggerDocument::didEnterCallFrame):
2282         (DebuggerDocument::willLeaveCallFrame):
2283         (DebuggerDocument::windowScriptObjectAvailable):
2284         (DebuggerDocument::callFunctionOnObject):
2285         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
2286         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
2287         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
2288         because it doesn't require the ServerConnection at all.
2289         (NSStringCreateWithJSStringRef): Made an argument const.
2290         (JSValueRefCreateWithNSString): Made an argument const.
2291         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
2292         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2293         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
2294         * Drosera/mac/ServerConnection.mm: Ditto.
2295         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
2296
2297 2007-10-29  Sam Weinig  <sam@webkit.org>
2298
2299         Reviewed by Adam Roben.
2300
2301         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
2302
2303         * DumpRenderTree/LayoutTestController.cpp:
2304         (LayoutTestController::LayoutTestController):
2305         (getGlobalFlagCallback):
2306         (setGlobalFlagCallback):
2307         (LayoutTestController::getJSClass):
2308         (LayoutTestController::staticValues):
2309         * DumpRenderTree/LayoutTestController.h:
2310         (LayoutTestController::globalFlag):
2311         (LayoutTestController::setGlobalFlag):
2312
2313 2007-10-29  Darin Adler  <darin@apple.com>
2314
2315         Reviewed by Maciej.
2316
2317         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
2318         resolution instead of its default.
2319
2320 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
2321
2322         Fixed showStatus() to print status for successfully resolved conflicts when using git.
2323
2324         Reviewed by Mark Rowe.
2325
2326         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
2327         was successfully resolved, but this would not show any status because the change had
2328         already been cached in the index using "git add".  The solution is to add an optional
2329         second argument to showStatus() which adds the "--cached" switch to the command.
2330
2331         * Scripts/resolve-ChangeLogs:
2332         (showStatus):
2333
2334 2007-10-28  Eric Seidel  <eric@webkit.org>
2335
2336         Reviewed by Maciej and Geoff, in unison.
2337
2338         * Scripts/run-webkit-tests: remove broken --svg option
2339
2340 2007-10-28  Darin Adler  <darin@apple.com>
2341
2342         Reviewed by Adam.
2343
2344         * Scripts/run-sunspider: Default to "Release" configuration rather than
2345         defaulting to the last configuration used as other scripts do. This can
2346         still be overriden on the command line with "--debug" if there's some
2347         reason to do so. Also fix a typo.
2348
2349         * Scripts/sunspider-compare-results: Fix a typo.
2350
2351 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
2352
2353         Reviewed by Adam.
2354
2355         - Implemented the WebScriptDebugListener functions now that the
2356         WebScriptDebugServer exists
2357
2358         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
2359         functions.
2360         (ServerConnection::currentFrame):
2361         (ServerConnection::didLoadMainResourceForDataSource):
2362         (ServerConnection::didParseSource):
2363         (ServerConnection::failedToParseSource):
2364         (ServerConnection::didEnterCallFrame):
2365         (ServerConnection::willExecuteStatement):
2366         (ServerConnection::willLeaveCallFrame):
2367         (ServerConnection::exceptionWasRaised):
2368         * Drosera/win/ServerConnection.h: Removed unused arguments from the
2369         members arguments list.
2370
2371 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
2372
2373         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
2374         <http://bugs.webkit.org/show_bug.cgi?id=15600>
2375
2376         Reviewed by Darin.
2377
2378         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
2379         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
2380         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
2381         file.  Note that it may also be used as a stand-alone script.
2382
2383         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
2384         * Scripts/resolve-ChangeLogs: Added.
2385         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
2386
2387 2007-10-26  Mark Rowe  <mrowe@apple.com>
2388
2389         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
2390         to the Qt port on the assumption that it was an implementation of the cross-platform
2391         LayoutTestController class.  It is not, so it did not need to be changed.
2392
2393         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
2394
2395 2007-10-25  Mark Rowe  <mrowe@apple.com>
2396
2397         Reviewed by Maciej.
2398
2399         Fix builds with code coverage enabled.
2400
2401         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
2402
2403 2007-10-25  Darin Adler  <darin@apple.com>
2404
2405         Reviewed by Mark Rowe.
2406
2407         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
2408         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
2409
2410 2007-10-25  Stephanie  <slewis@apple.com>
2411
2412         build Fix
2413
2414         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2415
2416 2007-10-25  Stephanie  <slewis@apple.com>
2417
2418         Reviewed by Mark Rowe, Adam Roben.
2419
2420         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
2421
2422         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
2423
2424 2007-10-25  Alice Liu  <alice.liu@apple.com>
2425
2426         Reviewed by Adam.
2427
2428         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
2429
2430         Moving destructor into platform-specific files
2431         * DumpRenderTree/LayoutTestController.cpp:
2432         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2433         (LayoutTestController::~LayoutTestController):
2434         * DumpRenderTree/qt/jsobjects.cpp:
2435         (LayoutTestController::~LayoutTestController):
2436
2437         LayoutTestController wasn't being destroyed
2438         * DumpRenderTree/win/DumpRenderTree.cpp:
2439         (runTest):
2440
2441         Added declspec
2442         * DumpRenderTree/win/EditingDelegate.h:
2443
2444         Reset certain values on the webview (or related delegate) that might 
2445         have changed while running a test
2446         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2447         (LayoutTestController::~LayoutTestController):
2448
2449 2007-10-25  Adam Roben  <aroben@apple.com>
2450
2451         Make sunspider-compare-results work with relative paths
2452
2453         Reviewed by Sam.
2454
2455         * Scripts/sunspider-compare-results: Convert arguments to absolute
2456         paths before we chdir.
2457
2458 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
2459
2460         Reviewed by Sam.
2461
2462         - Implemented server calls now the WebScriptDebugServer exists.
2463         - Also removed no longer needed call to initialize CG.
2464
2465         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
2466         automatically now.
2467         (_tWinMain):
2468         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
2469         (ServerConnection::ServerConnection):
2470         (ServerConnection::~ServerConnection):
2471         (ServerConnection::pause):
2472         (ServerConnection::resume):
2473         (ServerConnection::stepInto):
2474         (ServerConnection::applicationTerminating):
2475         (ServerConnection::serverConnectionDidDie):
2476         * Drosera/win/ServerConnection.h: Now uses the COM class.
2477
2478 2007-10-24  George Staikos  <staikos@kde.org>
2479
2480         Unbreak Qt build.
2481
2482         * Scripts/build-webkit:
2483
2484 2007-10-24  Adam Roben  <aroben@apple.com>
2485
2486         Remove now-unnecessary call to InitializeCoreGraphics
2487
2488         WebKit takes care of this now.
2489
2490         Reviewed by Ada.
2491
2492         * DumpRenderTree/win/DumpRenderTree.cpp:
2493         (initialize):
2494
2495 2007-10-24  Adam Roben  <aroben@apple.com>
2496
2497         Use WebTextRenderer in DRT
2498
2499         Reviewed by Ada.
2500
2501         * DumpRenderTree/win/DumpRenderTree.cpp:
2502         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
2503
2504 2007-10-24  Sven Herzberg  <sven@imendio.com>
2505
2506         Reviewed by Mark Rowe.
2507
2508         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
2509         Bug 15614: [GTK] qmake based backends don't build on OS X
2510
2511         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
2512         GTK backend on a Mac
2513         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
2514         isDarwin() to make it reusable in other places (like the workaround-
2515         for-prebuilt-qmake in build-webkit)
2516
2517 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2518
2519         Refurbish update-webkit script.
2520
2521         Reviewed by Adam.
2522
2523         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
2524         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
2525         multi-argument version of system() for flexibility and security.  Check for existence
2526         of Internal directory using -d test instead of -x.
2527
2528 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2529
2530         Minor clean-up of prepare-ChangeLog script.
2531
2532         Reviewed by Adam.
2533
2534         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
2535         of a string.  Use multi-argument versions of open() and system() for flexibility and
2536         security.
2537
2538 2007-10-24  Alice Liu  <alice.liu@apple.com>
2539
2540         Reviewed by Oliver.
2541
2542         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
2543
2544         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
2545         replay the saved events when we're still processing the mousedown that starts the drag
2546         * DumpRenderTree/win/EventSender.cpp:
2547         (doMouseMove):
2548         * DumpRenderTree/win/UIDelegate.cpp:
2549         (UIDelegate::doDragDrop):
2550
2551 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
2552
2553         Reviewed by Sam, Steve and Darin.
2554
2555         - Stubbed out the WebScriptDebugListener functionality in the Server
2556         Connection class to prepare it for receiving those callbacks.
2557         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
2558         and the ServerConnection to not need to be initialized with a server
2559         name, since that is not the way we connect to the WebKit server. 
2560
2561         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
2562         no exception.  Now it only loggs when there is an exception
2563         (DebuggerDocument::willExecuteStatement):
2564         (DebuggerDocument::didEnterCallFrame):
2565         (DebuggerDocument::willLeaveCallFrame):
2566         (DebuggerDocument::windowScriptObjectAvailable):
2567         (DebuggerDocument::callFunctionOnObject):
2568         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
2569         to be instantiated with a server's name.
2570         (DebuggerClient::DebuggerClient):
2571         (DebuggerClient::didFinishLoadForFrame):
2572         * Drosera/win/DebuggerClient.h: Removed unsued variable.
2573         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
2574         a server name.
2575         (Drosera::init):
2576         (Drosera::initServer):
2577         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
2578         instantiated with a server's name.
2579         * Drosera/win/ServerConnection.cpp: 
2580         (ServerConnection::ServerConnection): No longer needs a server name
2581         (ServerConnection::~ServerConnection): Only release the global context
2582         if there is one.
2583         (ServerConnection::serverConnectionDidDie): Stub for
2584         IWebScriptDebugListener
2585         (ServerConnection::QueryInterface): ditto
2586         (ServerConnection::AddRef): ditto
2587         (ServerConnection::Release): ditto
2588         (ServerConnection::didLoadMainResourceForDataSource): ditto
2589         (ServerConnection::didParseSource): ditto
2590         (ServerConnection::failedToParseSource): ditto
2591         (ServerConnection::didEnterCallFrame): ditto
2592         (ServerConnection::willExecuteStatement): ditto
2593         (ServerConnection::willLeaveCallFrame): ditto
2594         (ServerConnection::exceptionWasRaised): ditto
2595         * Drosera/win/ServerConnection.h: Stubbed out the
2596         IWebScriptDebugListener functions, and this class no longer needs to be
2597         instantiated with a server name.
2598
2599 2007-10-24  Lars Knoll  <lars@trolltech.com>
2600
2601         Reviewed by Simon.
2602
2603         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
2604
2605         * DumpRenderTree/qt/jsobjects.h:
2606
2607 2007-10-24  Lars Knoll  <lars@trolltech.com>
2608
2609         Reviewed by Simon.
2610
2611         add another command.
2612
2613         * DumpRenderTree/qt/jsobjects.cpp:
2614         (TextInputController::doCommand):
2615
2616 2007-10-24  Lars Knoll  <lars@trolltech.com>
2617
2618         Reviewed by Simon.
2619
2620         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
2621
2622         * DumpRenderTree/qt/jsobjects.cpp:
2623         (EventSender::keyDown):
2624         * DumpRenderTree/qt/jsobjects.h:
2625
2626 2007-10-24  Lars Knoll  <lars@trolltech.com>
2627
2628         Reviewed by Simon.
2629
2630         implement eventSender.keyDown().
2631
2632         * DumpRenderTree/qt/jsobjects.cpp:
2633         (EventSender::keyDown):
2634
2635 2007-10-24  Lars Knoll  <lars@trolltech.com>
2636
2637         Reviewed by Simon.
2638
2639         some smaller fixes to the editing support in DRT. Makes another few tests pass.
2640
2641         * DumpRenderTree/qt/DumpRenderTree.cpp:
2642         (WebCore::DumpRenderTree::DumpRenderTree):
2643         (WebCore::DumpRenderTree::initJSObjects):
2644         * DumpRenderTree/qt/jsobjects.cpp:
2645         (TextInputController::doCommand):
2646
2647 2007-10-24  Lars Knoll  <lars@trolltech.com>
2648
2649         Reviewed by Simon.
2650
2651         first bit of implementation for the textinputcontroller.
2652
2653         * DumpRenderTree/qt/DumpRenderTree.cpp:
2654         (WebCore::DumpRenderTree::DumpRenderTree):
2655         * DumpRenderTree/qt/DumpRenderTree.h:
2656         * DumpRenderTree/qt/jsobjects.cpp:
2657         (TextInputController::TextInputController):
2658         (TextInputController::doCommand):
2659         * DumpRenderTree/qt/jsobjects.h:
2660
2661 2007-10-24  Lars Knoll  <lars@trolltech.com>
2662
2663         Reviewed by Simon.
2664
2665         make the man webpage believe it has focus, so the editing tests work correctly.
2666
2667         * DumpRenderTree/qt/DumpRenderTree.cpp:
2668         (WebCore::DumpRenderTree::DumpRenderTree):
2669
2670 2007-10-24  Lars Knoll  <lars@trolltech.com>
2671
2672         Reviewed by Simon.
2673
2674         implement layoutTestController.dumpEditingCallbacks() correctly.
2675
2676         * DumpRenderTree/qt/DumpRenderTree.cpp:
2677         (WebCore::DumpRenderTree::DumpRenderTree):
2678         * DumpRenderTree/qt/jsobjects.cpp:
2679         (LayoutTestController::reset):
2680         (LayoutTestController::dumpEditingCallbacks):
2681
2682 2007-10-24  Lars Knoll  <lars@trolltech.com>
2683
2684         Reviewed by Simon.
2685
2686         Implement support for testing editing.
2687
2688         * DumpRenderTree/qt/DumpRenderTree.cpp:
2689         (WebCore::DumpRenderTree::DumpRenderTree):
2690
2691 2007-10-23  Sam Weinig  <sam@webkit.org>
2692
2693         Check for null BSTR that can be passed to the UIDelegate methods
2694         from javascript null and undefined.  Fixes a failing test case on
2695         Windows (fast/dom/Window/alert-undefined.html)
2696
2697         Reviewed by Eric Seidel.
2698
2699         * DumpRenderTree/win/UIDelegate.cpp:
2700         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2701         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2702         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2703         (UIDelegate::webViewAddMessageToConsole):
2704
2705 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2706
2707         Reviewed by Darin.
2708         
2709         Don't print a massive pile of setenvs from tools that automatically build testkjs.
2710
2711         * Scripts/build-testkjs:
2712
2713 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2714
2715         Reviewed by Darin.
2716
2717         - add wrapper that finds the right copy of testkjs
2718         
2719         * Scripts/sunspider-compare-results: Added.
2720
2721 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
2722
2723         Reviewed by Sam.
2724
2725         - After talking with Steve I now see that the WebKit server must be
2726         running for DCOM to create the distributed objects, which makes sense
2727         and currently WebKit only allows one instance to be running at a time
2728         which avoids accidentally connecting to the wrong server
2729         - In light of this I have removed the code for the attach box and
2730         NotificationServer and known server names, since they are all extranious
2731         now.
2732
2733         * Drosera/win/Drosera.cpp: Removed notification classes and known server
2734         names.
2735         (_tWinMain): Uses init instead of initUI.
2736         (droseraWndProc): No longer creats an attach dialog box.
2737         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
2738         it's not manditory to call init before doing COM stuff.
2739         (Drosera::init): calls initUI and will call attach when the
2740         functionality exists. 
2741         (Drosera::initUI): Has changed very little.
2742         (Drosera::attach): Changed the signature to reflect that we no longer
2743         need the dictionary of known server names.
2744         * Drosera/win/Drosera.h: Removed notification classes and known server
2745         names.  Also renamed and moved some functions.
2746         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
2747         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
2748         headers to the resources folder. 
2749         * Drosera/win/resource.h: Removed the Attach box.
2750
2751 2007-10-22  Adam Roben  <aroben@apple.com>
2752
2753         Windows build fix
2754
2755         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
2756
2757 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
2758
2759         - Removed a leak that was fixed.
2760
2761         * Scripts/run-webkit-tests:
2762
2763 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2764
2765         Reviewed by Darin.
2766
2767         - Changed the Client so that the DebuggerDocument now own the
2768         ServerConnection.  This simplifies ownership and cleanup. 
2769
2770         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
2771         ServerConnection.
2772         (DebuggerClient::initWithServerName):
2773         (DebuggerClient::didFinishLoadForFrame):
2774         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
2775         ServerConnection.
2776         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
2777         until after we have a server which we are attached to.
2778         (Drosera::initUI):
2779         (Drosera::attach):
2780         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
2781         out previously.
2782
2783 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2784
2785         Reviewed by Nikolas.
2786
2787         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
2788
2789         * Scripts/run-javascriptcore-tests:
2790
2791 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2792
2793         Reviewed by Nikolas.
2794
2795         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
2796
2797         * Scripts/build-drosera:
2798         * Scripts/build-dumprendertree:
2799         * Scripts/build-testkjs:
2800         * Scripts/build-webkit:
2801         * Scripts/run-javascriptcore-tests:
2802         * Scripts/run-sunspider:
2803         * Scripts/run-webkit-tests:
2804         * Scripts/webkitdirs.pm:
2805
2806 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
2807
2808         Reviewed by Mark Rowe.
2809         
2810         Fix for local database support after r26879
2811         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
2812
2813         * Scripts/build-webkit:
2814
2815 2007-10-22  Holger Freyther  <zecke@selfish.org>
2816
2817         Reviewed by Simon Hausmann <hausmann@kde.org>.
2818
2819         - Do not build testkjs as an application bundle. This is
2820         needed for run-javascriptcore-tests on OSX.
2821         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
2822         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
2823         as we do not have -rpath on OSX.
2824
2825         * DumpRenderTree/qt/DumpRenderTree.pro:
2826         * Scripts/run-webkit-tests:
2827
2828 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2829
2830         Reviewed by aroben.
2831
2832         Fix support for Signed-off-by detection in prepare-ChangeLog
2833         --git-commit. The Signed-off-by tag does not appear in the header
2834         but usually at the end.
2835
2836         * Scripts/prepare-ChangeLog:
2837
2838 2007-10-21  Mark Rowe  <mrowe@apple.com>
2839
2840         Reviewed by Eric.
2841
2842         Fix run-javascriptcore-tests for Gtk.
2843
2844         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
2845
2846 2007-10-20  Eric Seidel  <eric@webkit.org>
2847
2848         Reviewed by aroben.
2849
2850         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
2851
2852 2007-10-20  Eric Seidel  <eric@webkit.org>
2853
2854         Reviewed by darin.
2855         
2856         Add improved argument handling to run-sunspider, including
2857         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
2858         Also re-factor code into subroutines
2859
2860         * Scripts/build-dumprendertree: removed bogus comments
2861         * Scripts/build-testkjs: Added.
2862         * Scripts/run-javascriptcore-tests: use build-testkjs
2863         * Scripts/run-sunspider: improved argument handling, abstraction
2864         * Scripts/run-webkit-tests: improved abstraction
2865
2866 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
2867
2868         Not reviewed, Windows build fix.
2869
2870         * DumpRenderTree/win/EventSender.cpp:
2871         (keyDownCallback):
2872
2873 2007-10-20  Darin Adler  <darin@apple.com>
2874
2875         Reviewed by Tim Hatcher.
2876
2877         - http://bugs.webkit.org/show_bug.cgi?id=15544
2878           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
2879           not rely on Apple-specific key codes
2880
2881         * DumpRenderTree/mac/EventSendingController.mm:
2882         (-[EventSendingController keyDown:withModifiers:]):
2883         Added named key "rightArrow". Later we could have a whole table of these.
2884         Also tweaked modifiers code a little.
2885
2886         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
2887
2888 2007-10-19  Darin Adler  <darin@apple.com>
2889
2890         Reviewed by Eric.
2891
2892         - http://bugs.webkit.org/show_bug.cgi?id=15566
2893           possible fix for leak seen in DumpRenderTree
2894
2895         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
2896         Delete the item if it's not put on the queue, since the caller has
2897         no way of knowing that. Would be better to have the parameter type
2898         be auto_ptr to express the fact that we take ownership.
2899
2900         - unrelated change
2901
2902         * Drosera/mac/main.m: Add missing include.
2903
2904 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2905
2906         Reviewed by Adam.
2907
2908         - This change should be identical but for some reason was not working
2909         on my machine.
2910
2911         * Scripts/prepare-ChangeLog:
2912
2913 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2914
2915         Reviewed by Oliver and Tim.
2916
2917         - Made use of RetainPtr to avoid retain and release issues and moved the
2918         log function to DebuggerDocumentPlatform, which seems to be a more
2919         logical place for it to live.
2920         - Also moved knownServers from the ServerConnection to
2921         DebuggerApplication to match the Windows code and because it makes sense
2922         that a connection knows its own server but not all of them.
2923
2924         * Drosera/mac/DebuggerClient.h: Moved the log function to
2925           DebuggerDocumentPlatform.
2926         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
2927           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
2928           call for the server name up from the ServerConnection class.
2929         (-[DebuggerClient dealloc]):
2930         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
2931           for the server name up from the ServerConnection.
2932         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
2933         (DebuggerDocument::platformPause):
2934         (DebuggerDocument::platformResume):
2935         (DebuggerDocument::platformStepInto):
2936         (DebuggerDocument::platformEvaluateScript):
2937         (DebuggerDocument::getPlatformCurrentFunctionStack):
2938         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2939         (DebuggerDocument::platformValueForScopeVariableNamed):
2940         (DebuggerDocument::platformLog): Log directly from here. No need to call
2941           DebuggerClient.
2942         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
2943           way I see it, a ServerConnection should only know about its connection
2944           and the group of all possible servers should be kept by the
2945           application.
2946         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
2947           currentServerName, it makes sense that the connection should know that
2948           name.
2949         (-[ServerConnection currentServerName]):
2950
2951 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2952
2953         Reviewed by Adam.
2954
2955         - Integrated changes from mac drosera.  Recently I've encapsulated
2956         out the server connection object from the rest of Drosera because
2957         it is very platform dependent right now and RPC is not implemented on
2958         windows.  This functionality, of communicating with the WebKit server
2959         is the next area I will be focusing on in Windows.
2960
2961         - Other changes and cleanup were made to organize the code and add notes
2962         on which parts still need work.  Also some mac code is added and
2963         commented out, to act as pseudocode for the logic of those parts.
2964
2965         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
2966           pointer.
2967         * Drosera/config.h: Added whitespace.
2968         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
2969           these files got moved into Drosera.h/cpp
2970         * Drosera/win/DebuggerApplication.h: Removed.
2971         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
2972           happened here to better match the logic flow of the same code on the 
2973           mac side and to use the new ServerConnection class.
2974         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
2975         (DebuggerClient::initWithServerName): Initializer that will set up the
2976           class to use a ServerConnection object.  This was necessary so I could
2977           create a DebuggerClient without having to initilaize it at
2978           construction.
2979         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
2980           will be the UIDelegate and FrameLoadDelegate.
2981         (DebuggerClient::AddRef): For IUnknown.
2982         (DebuggerClient::Release): For IUnknown.
2983         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
2984           this still needs to set the global context of the server, but
2985           IWebFrame does not have an accessor for the global context yet. 
2986         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
2987           this is a pass through for the same function in the document.
2988         (DebuggerClient::didReceiveTitle): Unimplemented part of
2989           FrameLoadDelegate this would change the title of the window.
2990         (DebuggerClient::createWebViewWithRequest): Part of the
2991           FrameLoadDelegate.  This is about new windows via Window.open() and
2992           how their delegates are set.
2993         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
2994           UIDelegate.  Just a debug function for printing messages.
2995         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
2996           because the Client should be the UIDelegate and FrameLoadDelegate
2997           to match the delegates on mac.
2998         (DebuggerClient::webViewLoaded): Added accessor method.
2999         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
3000           forgotten to add this file before.  This is where the platform
3001           dependent versions of the Documents functions live. Most of these are
3002           unimplemented because some piece of functionality does not exist on
3003           Windows yet.
3004         (DebuggerDocument::platformPause):
3005         (DebuggerDocument::platformResume):
3006         (DebuggerDocument::platformStepInto):
3007         (DebuggerDocument::platformEvaluateScript):
3008         (DebuggerDocument::getPlatformCurrentFunctionStack):
3009         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3010         (DebuggerDocument::platformValueForScopeVariableNamed):
3011         (DebuggerDocument::platformLog):
3012         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
3013           responsibilities becaue they belong in the Client. Also I laid the
3014           groundwork for attaching Drosera to a WebKit process
3015         (attachWndProc): Now if a server is selected the Client becomes it's
3016           delegate.
3017         (Drosera::Drosera): Added the construction of the Client and dictionary
3018           of server names. 
3019         (Drosera::initUI): This is no longer the delegates, the Client is.
3020         (Drosera::webViewLoaded): Now asks the Client instead of holding local
3021           state. 
3022         (Drosera::applicationDidFinishLaunching): Placeholder for needed
3023           notification registration when it's possible to implement.
3024         (Drosera::serverLoaded): Ditto
3025         (Drosera::serverUnloaded): Ditto
3026         (Drosera::attach): Attach Drosera to the WebKit server.
3027         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
3028         (Drosera::getInst): 
3029         (Drosera::setInst):
3030         (Drosera::knownServers):
3031         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
3032           and added the ServerConnection.
3033         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
3034         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
3035           Most of the functions are completely unimlemented because they cannot
3036           connect with the WebKit server, because one does not exist on Windows
3037           yet.
3038         (ServerConnection::initWithServerName): 
3039         (ServerConnection::~ServerConnection):
3040         (ServerConnection::setGlobalContext):
3041         (ServerConnection::pause):
3042         (ServerConnection::resume):
3043         (ServerConnection::stepInto):
3044         (ServerConnection::switchToServerNamed):
3045         (ServerConnection::applicationTerminating):
3046         (ServerConnection::serverConnectionDidDie):
3047         (ServerConnection::currentFrame):
3048         * Drosera/win/ServerConnection.h: Added. Ditto.
3049         (ServerConnection::ServerConnection):
3050
3051 2007-10-19  Alice Liu  <alice.liu@apple.com>
3052
3053         Reviewed by Darin.
3054
3055         Fix for these broken layout tests on Windows:
3056         
3057         fast/forms/focus-selection-input.html
3058         fast/forms/focus-selection-textarea.html
3059         fast/forms/select-accesskey.html
3060         
3061         * DumpRenderTree/win/EventSender.cpp:
3062         (keyDownCallback):
3063         correct the VK code for alt key.
3064         
3065 2007-10-19  Eric Seidel  <eric@webkit.org>
3066
3067         Reviewed by Mark Rowe.
3068         
3069         Make the GtkLauncher code slightly more readable.
3070
3071         * GtkLauncher/main.cpp:
3072         (setupMainMenu): Added.
3073         (setupMainWindowUI): Added.
3074         (main):
3075
3076 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
3077
3078         Rubber stamped by Adam.
3079         
3080         - don't delay-load WebKit in DumpRenderTree.
3081
3082         * DumpRenderTree/win/DumpRenderTree.vcproj:
3083
3084 2007-10-18  Dan Bernstein  <mitz@apple.com>
3085
3086         Reviewed by Adam Roben.
3087
3088         - fix <rdar://problem/5313523>
3089         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
3090
3091         * DumpRenderTree/mac/DumpRenderTree.mm:
3092         (dump): Changed to use _responseMIMEType.
3093
3094 2007-10-17  Adam Roben  <aroben@apple.com>
3095
3096         Make it possible to have Windows-specific tests and results
3097
3098         When searching for tests to run and the Skipped file, we will only
3099         look in platform/win and the cross-platform directory. When looking
3100         for expected results, we will look in platform/win, then
3101         platform/mac-leopard, then platform/mac, then finally the
3102         cross-platform directory.
3103
3104         Reviewed by Sam.
3105
3106         * Scripts/run-webkit-tests:
3107         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
3108         searching in the cross-platform directory.
3109         (sub buildPlatformHierarchy): Removed some unneeded calls to
3110         dirname/basename.
3111
3112 2007-10-17  Adam Roben  <aroben@apple.com>
3113
3114         Add back the call to register WebKit that we had before WebKitInitializer existed
3115
3116         This is needed to ensure that the right WebKit is used when
3117         instantiating COM objects.
3118
3119         Reviewed by Oliver.
3120
3121         * DumpRenderTree/win/debug_internal.vsprops: Define
3122         DEBUG_WEBKIT_HAS_SUFFIX.
3123         * DumpRenderTree/win/DumpRenderTree.cpp:
3124         (initialize):
3125
3126 2007-10-17  Adam Roben  <aroben@apple.com>
3127
3128         Import File::Basename in webkitdirs since we use it
3129
3130         * Scripts/webkitdirs.pm:
3131
3132 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
3133
3134         - Updated the tiger leaks list to make the internal bots green.
3135
3136         * Scripts/run-webkit-tests:
3137
3138 2007-10-17  Adam Roben  <aroben@apple.com>
3139
3140         Build fix for VC++ Express
3141
3142         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
3143         and ole32.lib.
3144
3145 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
3146
3147         Reviewed by Sam.
3148
3149         - Minor mac improvements based on observations I made while implementing the
3150         Windows code.
3151
3152         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
3153         then hand it to the Client who will retain it, it should just be the client who
3154         creates and owns the server.
3155         (-[DebuggerApplication attach:]):
3156         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
3157         * Drosera/mac/DebuggerClient.mm: Creates the server.
3158         (-[DebuggerClient initWithServerName:]):
3159         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
3160         can instead forward declare what it needs.
3161
3162 2007-10-16  Darin Adler  <darin@apple.com>
3163
3164         Reviewed by Geoff Garen.
3165
3166         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
3167         want to turn failing tests into platform-specific test results. Also did a
3168         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
3169         would take the type of results into account only some of the time.
3170
3171 2007-10-16  Adam Roben  <aroben@apple.com>
3172
3173         Add a new nightly launcher script for Windows
3174
3175         This new script is for versions of Safari that don't delay-load
3176         WebKit. I had to make FindSafari be able to print out the nightly
3177         launcher script on stdout because Windows shell scripts can't capture
3178         the output from a command into an environment variable.
3179
3180         Reviewed by Steve.
3181
3182         * FindSafari/FindSafari.cpp:
3183         (_tmain): Added /printSafariLauncher option.
3184         * Scripts/run-webkit-nightly.cmd: Added.
3185
3186 2007-10-16  Adam Roben  <aroben@apple.com>
3187
3188         Replace WebKitInitializer with FindSafari
3189
3190         We now rely on setting the PATH environment variable to tell Windows
3191         where to find WebKit and its dependencies (similar to
3192         DYLD_FRAMEWORK_PATH on Mac).
3193
3194         This change also make DumpRenderTree no longer delay-load WebKit.
3195
3196         Reviewed by Sam.
3197
3198         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
3199         FindSafari.
3200         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
3201         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
3202         WebKitInitializer, don't delay-load WebKit.
3203         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
3204         * Scripts/run-webkit-tests: Ditto.
3205         * Scripts/webkitdirs.pm:
3206         (sub setPathForRunningWebKitApp): Added.
3207         * WebKitInitializer/WebKitInitializer.cpp: Removed.
3208         * WebKitInitializer/WebKitInitializer.h: Removed.
3209         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
3210         * WebKitInitializer/debug.vsprops: Removed.
3211         * WebKitInitializer/debug_internal.vsprops: Removed.
3212         * WebKitInitializer/release.vsprops: Removed.
3213
3214 2007-10-16  Adam Roben  <aroben@apple.com>
3215
3216         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
3217
3218         http://bugs.webkit.org/show_bug.cgi?id=15532
3219
3220         FindSafari simply prints the location of an installed Safari.exe on
3221         stdout.
3222
3223         Reviewed by Darin.
3224
3225         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
3226         (getStringValue):
3227         (getWebViewCLSID):
3228         (getInstalledWebKitDirectory):
3229         (_tmain):
3230         * FindSafari/FindSafari.vcproj: Added.
3231         * Scripts/webkitdirs.pm:
3232         (sub installedSafariPath): Added. Calls FindSafari on Windows.
3233
3234 2007-10-16  Adam Roben  <aroben@apple.com>
3235
3236         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
3237
3238         Reviewed by Kevin McCullough.
3239
3240         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
3241         when referring to WebKit.dll.
3242         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
3243         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
3244         * DumpRenderTree/win/release.vsprops: Ditto.
3245         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
3246         never have a _debug suffix on WebKit.dll.
3247         * WebKitInitializer/WebKitInitializer.cpp:
3248         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
3249         specified.
3250         * WebKitInitializer/debug_internal.vsprops: Added
3251         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
3252
3253 2007-10-16  Darin Adler  <darin@apple.com>
3254
3255         Reviewed by Adele.
3256
3257         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
3258         Remove now-unneeded control/alt key hack; the tests have been updated.
3259
3260 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
3261
3262         - Updated leaks list because our internal bot upgraded it's version of leopard and 
3263         one of the leaks was fixed between that revision and the bot's previous version of
3264         leopard.
3265
3266         * Scripts/run-webkit-tests:
3267
3268 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
3269
3270         Reviewed by Tim.
3271
3272         - I encapsulated out the server connecton functionality because it is a specific part
3273         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
3274         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
3275         Windows.  So the majority of this patch is moving preexisting functionality.
3276
3277         - Also I removed the prefix header and changed to use config.h because it is more
3278         standard on how we use config.h in windows and it didn't make much sense to keep
3279         the prefix header and the config.h
3280
3281         * Drosera/DebuggerDocument.cpp:
3282         (DebuggerDocument::DebuggerDocument):
3283         * Drosera/DebuggerDocument.h:
3284         * Drosera/config.h:
3285         * Drosera/mac/DebuggerApplication.mm:
3286         (-[DebuggerApplication attach:]):
3287         * Drosera/mac/DebuggerClient.h:
3288         * Drosera/mac/DebuggerClient.mm:
3289         (-[DebuggerClient initWithServerConnection:]):
3290         (-[DebuggerClient dealloc]):
3291         (-[DebuggerClient windowDidLoad]):
3292         (-[DebuggerClient windowWillClose:]):
3293         (-[DebuggerClient webView:didFinishLoadForFrame:]):
3294         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
3295         * Drosera/mac/DebuggerDocumentPlatform.mm:
3296         (DebuggerDocument::platformPause):
3297         (DebuggerDocument::platformResume):
3298         (DebuggerDocument::platformStepInto):
3299         (DebuggerDocument::platformEvaluateScript):
3300         (DebuggerDocument::getPlatformCurrentFunctionStack):
3301         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3302         (DebuggerDocument::platformValueForScopeVariableNamed):
3303         (DebuggerDocument::platformLog):
3304         * Drosera/mac/Drosera.pch: Removed.
3305         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3306         * Drosera/mac/ServerConnection.h: Added.
3307         * Drosera/mac/ServerConnection.mm: Added.
3308         (-[ServerConnection initWithServerName:]):
3309         (-[ServerConnection dealloc]):
3310         (-[ServerConnection setGlobalContext:]):
3311         (-[ServerConnection pause]):
3312         (-[ServerConnection resume]):
3313         (-[ServerConnection stepInto]):
3314         (-[ServerConnection switchToServerNamed:]):
3315         (-[ServerConnection applicationTerminating:]):
3316         (-[ServerConnection serverConnectionDidDie:]):
3317         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
3318         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
3319         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
3320         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
3321         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
3322         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
3323         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
3324         (-[ServerConnection currentFrame]):
3325         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
3326         (-[ServerConnection knownServers]):
3327
3328 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
3329
3330         Reviewed by Eric.
3331
3332         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
3333           Script to automatically search nightly builds for regressions (bisect-builds)
3334
3335         * Scripts/bisect-builds: Added.
3336
3337 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
3338
3339         Reviewed by Darin.
3340
3341         - New JavaScript benchmark
3342         http://bugs.webkit.org/show_bug.cgi?id=15515
3343
3344         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
3345         current development or release build of JavaScriptCore.
3346
3347 2007-10-15  Mark Rowe  <mrowe@apple.com>
3348
3349         Reviewed by Sam.
3350
3351         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
3352
3353         * Scripts/webkitdirs.pm:
3354         - Change checkArgv to remove the options from @ARGV to prevent
3355         them from interfering with further option processing.
3356         - Fix logic error in determineIsQt that would prevent it from bailing out early.
3357         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
3358         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
3359         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
3360
3361 2007-10-15  Darin Adler  <darin@apple.com>
3362
3363         Reviewed by Sam.
3364
3365         - added logging of window.prompt and window.confirm
3366
3367         * DumpRenderTree/mac/UIDelegate.mm:
3368         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
3369         Implement the recommended delegate rather than the deprecated one.
3370         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
3371         Added.
3372         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
3373         Added.
3374
3375         * DumpRenderTree/win/UIDelegate.h:
3376         * DumpRenderTree/win/UIDelegate.cpp:
3377         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
3378         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
3379         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
3380         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
3381
3382 2007-10-15  Alice Liu  <alice.liu@apple.com>
3383
3384         Reviewed by Sam Weinig.
3385
3386         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
3387
3388         * DumpRenderTree/win/DumpRenderTree.cpp:
3389         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
3390         (main): allocate the global policy delegate for DRT's custom use
3391         * DumpRenderTree/win/DumpRenderTree.vcproj:
3392         Adding files to project
3393         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
3394         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3395         (LayoutTestController::setCustomPolicyDelegate):
3396         set the webview's policy delegate to DRT's custom one if the test requests it.
3397         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
3398         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
3399         (PolicyDelegate::PolicyDelegate):
3400         (PolicyDelegate::QueryInterface):
3401         (PolicyDelegate::AddRef):
3402         (PolicyDelegate::Release):
3403         (PolicyDelegate::decidePolicyForNavigationAction):
3404         * DumpRenderTree/win/PolicyDelegate.h: Added.
3405         (PolicyDelegate::decidePolicyForNewWindowAction):
3406         (PolicyDelegate::decidePolicyForMIMEType):
3407         (PolicyDelegate::unableToImplementPolicyWithError):
3408
3409 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
3410
3411         Reviewed by Mark.
3412
3413         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
3414         when querying for QMAKE_MKSPECS.
3415
3416 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
3417
3418         Reviewed by Adam Roben.
3419         
3420         Fix run-webkit-tests is too greedy calculating platform hierarchy
3421         http://bugs.webkit.org/show_bug.cgi?id=15465
3422         
3423         Fix run-webkit-tests being too greedy in trying to split the platform name up
3424         causing it to try and find tests in every directory above the first "-" in the
3425         path to the LayoutTests
3426
3427         * Scripts/run-webkit-tests:
3428
3429 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
3430
3431         Reviewed by Darin.
3432
3433         http://bugs.webkit.org/show_bug.cgi?id=15006
3434         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
3435         to reduce code duplication.
3436
3437         * Scripts/build-webkit:
3438         * Scripts/webkitdirs.pm:
3439         buildQMakeProject() renamed to buildQMakeQtProject().
3440         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
3441         unused $colorize has been removed.
3442
3443 === Start merge of feature-branch 2007-10-12 ===
3444
3445 2007-10-08  Eric Seidel  <eric@webkit.org>
3446
3447         Reviewed by Mark Rowe.
3448
3449         * Scripts/build-webkit: add --help, remove unused --color
3450
3451 2007-10-07  Eric Seidel  <eric@webkit.org>
3452
3453         Reviewed by darin.
3454
3455         * Drosera/mac/DebuggerDocumentPlatform.mm:
3456         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
3457
3458 2007-10-03  Rob Buis  <buis@kde.org>
3459
3460         Reviewed by Olliej.
3461
3462         Adapt to changed location of Ahem font.
3463
3464         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3465
3466 2007-10-02  Eric Seidel  <eric@webkit.org>
3467
3468         Reviewed by Adam Roben.
3469         
3470         Make pixel tests more useful!
3471         Finally fix the image diff 0.00% mystery problem
3472         Highlight any image differences in the image diff.
3473         Add a link from image diffs back to original test file.
3474
3475         * DumpRenderTree/mac/ImageDiff.m:
3476         (compareImages): highlight any differences
3477         (computePercentageDifferent): round to two decimal places
3478         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
3479
3480 2007-10-02  Eric Seidel  <eric@webkit.org>
3481
3482         Reviewed by Alexey Proskuryakov.
3483
3484         * Scripts/run-webkit-tests: print the % image difference on main results page
3485
3486 2007-10-02  Mark Rowe  <mrowe@apple.com>
3487
3488         Reviewed by Oliver.
3489
3490         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
3491
3492         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
3493         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
3494
3495 2007-10-01  Mark Rowe  <mrowe@apple.com>
3496
3497         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
3498
3499 2007-09-25  Eric Seidel  <eric@webkit.org>
3500
3501         Reviewed by Mark Rowe.
3502         
3503         DerivedSources.make was finding "ENABLE_SVG" in the string
3504         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
3505         quite correctly.
3506
3507         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
3508
3509 2007-09-25  Mark Rowe  <mrowe@apple.com>
3510
3511         Rubber-stamped by Eric.
3512
3513         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
3514         This makes it possible to automate nightly builds for the feature-branch.
3515
3516 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
3517
3518         Rubber stamped by Mark.
3519
3520         Enable svg experimental features as default here in feature-branch.
3521
3522         * Scripts/build-webkit:
3523
3524 2007-06-29  Antti Koivisto  <antti@apple.com>
3525
3526         Reviewed by Weinig.
3527         
3528         Add VIDEO flag for timed media features
3529
3530         * Scripts/build-webkit
3531         
3532 === End merge of feature-branch 2007-10-12 ===
3533
3534 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
3535
3536         Reviewed by Darin.
3537
3538         - Updated rational for the leaks list to be more clear.
3539
3540         * Scripts/run-webkit-tests:
3541
3542 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
3543
3544         Rubber Stamp by Sam.
3545
3546         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
3547         I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
3548
3549         * Scripts/run-webkit-tests:
3550
3551 2007-10-10  Simon Hausmann  <hausmann@kde.org>
3552
3553         Reviewed by Lars.
3554
3555         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
3556         includes are needed for INT_MAX, std::auto_ptr and the like.
3557
3558         * DumpRenderTree/qt/main.cpp:
3559
3560 2007-10-09  Lars Knoll  <lars@trolltech.com>
3561
3562         Reviewed by Simon.
3563
3564         implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
3565
3566         * DumpRenderTree/qt/jsobjects.cpp:
3567         (LayoutTestController::encodeHostName):
3568         (LayoutTestController::decodeHostName):
3569         * DumpRenderTree/qt/jsobjects.h:
3570
3571 2007-10-09  Lars Knoll  <lars@trolltech.com>
3572
3573         Reviewed by Simon.
3574
3575         Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
3576
3577         * DumpRenderTree/qt/DumpRenderTree.cpp:
3578         (WebCore::WebPage::createFrame):
3579         (WebCore::DumpRenderTree::DumpRenderTree):
3580         (WebCore::DumpRenderTree::titleChanged):
3581         * DumpRenderTree/qt/DumpRenderTree.h:
3582         * DumpRenderTree/qt/jsobjects.cpp:
3583         (LayoutTestController::reset):
3584         * DumpRenderTree/qt/jsobjects.h:
3585
3586 2007-10-09  Lars Knoll  <lars@trolltech.com>
3587
3588         Reviewed by Simon.
3589
3590         add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
3591
3592         * DumpRenderTree/qt/DumpRenderTree.h:
3593         * DumpRenderTree/qt/jsobjects.cpp:
3594         (LayoutTestController::clearBackForwardList):
3595         * DumpRenderTree/qt/jsobjects.h:
3596
3597 2007-10-09  Lars Knoll  <lars@trolltech.com>
3598
3599         Reviewed by Simon.
3600
3601         make --git-reviewer work again.
3602
3603         * Scripts/prepare-ChangeLog:
3604
3605 2007-10-07  Holger Hans Peter Freyther  <zecke@selfish.org>
3606
3607         Rubber stamped by Eric.
3608
3609         Connect to the "hovering-over-link" signal emitted by WebKitPage and
3610         show the current link inside the statusbar.
3611         This shows how to make use of this signal and allows to easily test
3612         http://bugs.webkit.org/show_bug.cgi?id=15299.
3613
3614         * GtkLauncher/main.cpp:
3615         (hoveringOverLink):
3616         (main):
3617
3618 2007-10-05  Lars Knoll  <lars@trolltech.com>
3619
3620         add proper error messages to the FrameLoaderClient.
3621         Implement ChromeClientQt::closeWindowSoon and
3622         FrameLoaderClientQt::dispatchCreatePage (which should go away IMO).
3623         Some fixes in DRT to make it work correctly with multiple windows.
3624
3625         Reviewed by Maciej.
3626
3627         * DumpRenderTree/qt/DumpRenderTree.cpp:
3628         (WebCore::DumpRenderTree::DumpRenderTree):
3629         (WebCore::DumpRenderTree::createWindow):
3630         (WebCore::DumpRenderTree::windowCount):
3631         * DumpRenderTree/qt/DumpRenderTree.h:
3632         * DumpRenderTree/qt/jsobjects.cpp:
3633         (LayoutTestController::maybeDump):
3634         (LayoutTestController::windowCount):
3635         * DumpRenderTree/qt/jsobjects.h:
3636
3637 2007-10-05  Lars Knoll  <lars@trolltech.com>
3638
3639         Add a dummy plugin to DRT  to fix fast/dom/Window/Plug-Ins.html.
3640         Add support for layoutTextController.setCanOpenWindows() to DRT
3641         fixing another 2 test cases in fast/dom/Window.
3642
3643         Reviewed by Maciej.
3644
3645         * DumpRenderTree/qt/DumpRenderTree.cpp:
3646         (WebCore::WebPage::WebPage):
3647         (WebCore::WebPage::createWindow):
3648         (WebCore::DumpRenderTree::resetJSObjects):
3649         (WebCore::DumpRenderTree::createWindow):
3650         * DumpRenderTree/qt/DumpRenderTree.h:
3651         * DumpRenderTree/qt/DumpRenderTree.pro:
3652         * DumpRenderTree/qt/jsobjects.cpp:
3653         (LayoutTestController::LayoutTestController):
3654         (LayoutTestController::reset):
3655         * DumpRenderTree/qt/jsobjects.h:
3656         * DumpRenderTree/qt/main.cpp:
3657         * DumpRenderTree/qt/testplugin.cpp: Added.
3658         * DumpRenderTree/qt/testplugin.h: Added.
3659
3660 2007-10-04  Sam Weinig  <sam@webkit.org>
3661
3662         Rubber stamped by Adam.
3663
3664         Remove empty directories.
3665
3666         * DumpRenderTree/DumpRenderTree.qtproj: Removed.
3667         * DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.
3668
3669 2007-10-03  Darin Adler  <darin@apple.com>
3670
3671         Reviewed by Adam.
3672
3673         * Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if
3674         we find the internal libraries in the libraries directory. This
3675         is helpful for Safari team engineers at Apple.
3676
3677 2007-10-03  Adam Roben  <aroben@apple.com>
3678
3679         Update the location of AHEM___.TTF after r25968
3680
3681         Reviewed by Sam.
3682
3683         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3684
3685 2007-10-03  Alp Toker  <alp@atoker.com>
3686
3687         Reviewed by Adam.
3688
3689         http://bugs.webkit.org/show_bug.cgi?id=14726
3690         [gtk] API design. Mapping the WebView delegates to signals.
3691
3692         Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.
3693
3694         * GtkLauncher/main.cpp:
3695         (goToURLBarText):
3696         (titleChanged):
3697         (progressChanged):
3698         (menuMainBackCallback):
3699         (menuMainForwardCallback):
3700         (main):
3701
3702 2007-10-03  Lars Knoll  <lars@trolltech.com>
3703
3704         Reviewed by Rob.
3705
3706         This fixes --strict mode in run-webkit-tests again after
3707         the platform dependent test results have been moved.
3708
3709         * Scripts/run-webkit-tests:
3710
3711 2007-10-03  Lars Knoll  <lars@trolltech.com>
3712
3713         Reviewed by bdash.
3714
3715         remove the hack in run-webkit-tests that forced text only test
3716         to be taken from the platform independent dir. It was only left
3717         there from early days.
3718         
3719         Remove platform dependent results for tests that are text only nowadays,
3720         and add one platform dependent result for a text only test that requires it.
3721
3722         * Scripts/run-webkit-tests:
3723
3724 2007-10-03  Lars Knoll  <lars@trolltech.com>
3725
3726         Reviewed by olliej.
3727
3728         Move the Qt version of DRT into the correct place and put the binary into BUILDDIR/bin.
3729
3730         * DumpRenderTree/qt/DumpRenderTree.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp.
3731         (WebCore::WebFrame::WebFrame):
3732         (WebCore::WebPage::WebPage):
3733         (WebCore::WebPage::createFrame):
3734         (WebCore::WebPage::javaScriptAlert):
3735         (WebCore::WebPage::javaScriptConsoleMessage):
3736         (WebCore::DumpRenderTree::DumpRenderTree):
3737         (WebCore::DumpRenderTree::~DumpRenderTree):
3738         (WebCore::DumpRenderTree::open):
3739         (WebCore::DumpRenderTree::readStdin):
3740         (WebCore::DumpRenderTree::resetJSObjects):
3741         (WebCore::DumpRenderTree::initJSObjects):
3742         (WebCore::DumpRenderTree::dumpFramesAsText):
3743         (WebCore::DumpRenderTree::dump):
3744         * DumpRenderTree/qt/DumpRenderTree.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h.
3745         (WebCore::DumpRenderTree::layoutTestController):
3746         (WebCore::DumpRenderTree::eventSender):
3747         * DumpRenderTree/qt/DumpRenderTree.pro: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro.
3748         * DumpRenderTree/qt/fonts.conf: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts.conf.
3749         * DumpRenderTree/qt/fonts/AHEM____.TTF: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts/AHEM____.TTF.
3750         * DumpRenderTree/qt/jsobjects.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp.
3751         (HackWebFrame::mousePressEvent):
3752         (HackWebFrame::mouseReleaseEvent):
3753         (HackWebFrame::mouseMoveEvent):
3754         (HackWebFrame::HackWebFrame):
3755         (HackWebFrame::~HackWebFrame):
3756         (LayoutTestController::LayoutTestController):
3757         (LayoutTestController::reset):
3758         (LayoutTestController::maybeDump):
3759         (LayoutTestController::waitUntilDone):
3760         (LayoutTestController::notifyDone):
3761         (LayoutTestController::dumpEditingCallbacks):
3762         (LayoutTestController::queueReload):
3763         (LayoutTestController::provisionalLoad):
3764         (LayoutTestController::timerEvent):
3765         (EventSender::EventSender):
3766         (EventSender::mouseDown):
3767         (EventSender::mouseUp):
3768         (EventSender::mouseMoveTo):
3769         (EventSender::leapForward):
3770         (EventSender::keyDown):
3771         (EventSender::frameUnderMouse):
3772         * DumpRenderTree/qt/jsobjects.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h.
3773         (LayoutTestController::isLoading):
3774         (LayoutTestController::setLoading):
3775         (LayoutTestController::shouldDumpAsText):
3776         (LayoutTestController::shouldDumpChildrenAsText):
3777         (LayoutTestController::shouldWaitUntilDone):
3778         (LayoutTestController::dumpAsText):
3779         (LayoutTestController::dumpChildFramesAsText):
3780         * DumpRenderTree/qt/main.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/main.cpp.
3781         (messageHandler):
3782         (crashHandler):
3783         (main):
3784         * Scripts/run-webkit-tests:
3785
3786 2007-10-03  Mark Rowe  <mrowe@apple.com>
3787
3788         Reviewed by Alp Toker.
3789
3790         Fix build-webkit when both QTDIR and --gtk are set.  The presence of --gtk
3791         should take precedence over QTDIR when determining which port we are working with.
3792
3793         * Scripts/webkitdirs.pm: 
3794
3795 2007-10-02  Adam Roben  <aroben@apple.com>
3796
3797         Add keychain to the list of default packages to install
3798
3799         Rubberstamped by Sam.
3800
3801         * CygwinDownloader/cygwin-downloader.py:
3802         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
3803
3804 2007-10-02  David Kilzer  <ddkilzer@webkit.org>
3805
3806         Reviewed by Adam.
3807
3808         Make "--git-commit trunk..HEAD" work with prepare-ChangeLog.
3809         Also makes WebCore regression test case logic work when using git.
3810
3811         * Scripts/prepare-ChangeLog:
3812         (reviewerAndDescriptionForGitCommit): Added.
3813
3814 2007-10-02  Lars Knoll  <lars@trolltech.com>
3815
3816         Reviewed by bdash.
3817
3818         Add API to retrieve the frame name from QWebFrame.
3819         Implement support for DRT::dumpChildrenAsText.
3820
3821         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3822         (WebCore::DumpRenderTree::dumpFramesAsText):
3823         (WebCore::DumpRenderTree::dump):
3824         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
3825         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3826         (LayoutTestController::LayoutTestController):
3827         (LayoutTestController::reset):
3828         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
3829
3830 2007-10-02  Lars Knoll  <lars@trolltech.com>
3831
3832         Reviewed by bdash.
3833
3834         Fix the handling of the response header for data urls. Make sure we always pass absolute URLs to WebKit from both DRT and QtLauncher.
3835
3836         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3837         (WebCore::DumpRenderTree::readStdin):
3838
3839 2007-10-02  Mark Rowe  <mrowe@apple.com>
3840
3841         Reviewed by Oliver.
3842
3843         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
3844
3845         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
3846         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
3847
3848 2007-10-02  Mark Rowe  <mrowe@apple.com>
3849
3850         Rubber-stamped by Maciej.
3851
3852         Configuration changes from build.webkit.org.  The major change is refactoring to work
3853         with Buildbot 0.7.6, but it does include other smaller changes that have been made in the
3854         last few weeks.
3855
3856         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3857         * BuildSlaveSupport/build.webkit.org-config/webkit/auth.py:
3858         * BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py:
3859         * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
3860         * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
3861         * BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py:
3862         * BuildSlaveSupport/build.webkit.org-config/webkit/status.py:
3863         * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
3864
3865 2007-10-02  Lars Knoll  <lars@trolltech.com>
3866
3867         Reviewed by Maciej.
3868
3869         Add support for eventSender.mouseMove to DRT.
3870         Fixes fast/css/hover-affects-child.html
3871
3872         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3873         (EventSender::mouseMoveTo):
3874
3875 2007-10-01  Mark Rowe  <mrowe@apple.com>
3876
3877         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
3878
3879 2007-10-01  David Kilzer  <ddkilzer@webkit.org>
3880
3881         Reviewed by Hyatt.
3882
3883         Make svn-apply and svn-unapply work with added files in git-diff formatted patches.
3884
3885         * Scripts/svn-apply:
3886         (gitdiff2svndiff): Ignore lines beginning with "new file".
3887         * Scripts/svn-unapply:
3888         (gitdiff2svndiff): Ditto.
3889
3890 2007-09-30  George Staikos  <staikos@kde.org>
3891
3892         Qt build fix (Mac OS X specific)
3893
3894         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro:
3895
3896 2007-09-29  Holger Hans Peter Freyther  <zecke@selfish.org>
3897
3898         Reviewed by Mark.
3899
3900         -Fix http://bugs.webkit.org/show_bug.cgi?id=13226.
3901         Remove Bakefiles from svn.
3902
3903         * GtkLauncher/Bakefiles.bkgen: Removed.
3904         * GtkLauncher/ENV: Removed.
3905         * GtkLauncher/gdklauncher.bkl: Removed.
3906         * GtkLauncher/mk: Removed.
3907         * Scripts/regenerate-makefiles: Removed.
3908
3909 2007-09-25  Kevin McCullough  <kmccullough@apple.com>
3910
3911         Reviewed by John.
3912
3913         - Updating leopard leak list to refelct bugs that have been fixed and no longer leak.
3914
3915         * Scripts/run-webkit-tests:
3916
3917 2007-09-26  Adam Roben  <aroben@apple.com>
3918
3919         Make not finding an installed WebKit non-fatal
3920
3921         What really matters is that we are able to load WebKit and its
3922         dependencies, not whether we think we've found an installed WebKit.
3923
3924         Reviewed by Sam.
3925
3926         * WebKitInitializer/WebKitInitializer.cpp:
3927         (getWebViewCLSID): Use new LOG_WARNING macro.
3928         (getInstalledWebKitDirectory): Ditto.
3929         (initializeWebKit): Don't die if we didn't find an installed WebKit,
3930         and use new macros.
3931         * WebKitInitializer/WebKitInitializer.vcproj: Disabled a warning.
3932
3933 2007-09-26  Adam Roben  <aroben@apple.com>
3934
3935         Committed this file before saving it
3936
3937         * WebKitInitializer/debug_internal.vsprops:
3938
3939 2007-09-26  Adam Roben  <aroben@apple.com>
3940
3941         Load WebKit and its dependencies manually so they come from DllDirectory
3942
3943         I had to change WebKitInitializer to use malloc/free instead of
3944         new/delete to avoid pulling in WebKit (and its dependencies) early
3945         through use of fastMalloc.
3946
3947         Reviewed by Oliver.
3948
3949         * WebKitInitializer/WebKitInitializer.cpp:
3950         (getStringValue): Changed to use malloc/free.
3951         (getInstalledWebKitDirectory): Ditto.
3952         (initializeWebKit): Call SetDllDirectory first, then load all of
3953         WebKit's dependencies manually, finally followed by WebKit itself.
3954         * WebKitInitializer/WebKitInitializer.vcproj: Added a new
3955         configuration to match our other projects.
3956         * WebKitInitializer/debug_internal.vsprops: Added.
3957
3958 2007-09-25  Adam Roben  <aroben@apple.com>
3959
3960         Actually define DEBUG/NDEBUG so that we load WebKit correctly
3961
3962         Rubberstamped by Sam.
3963
3964         * WebKitInitializer/WebKitInitializer.vcproj:
3965
3966 2007-09-25  Adam Roben  <aroben@apple.com>
3967
3968         Make DumpRenderTree delay-load its dependencies
3969
3970         This lets WebKitInitializer re-route the dependencies to be loaded out
3971         of the Safari installation directory.
3972
3973         Also replaced all uses of kCFAllocatorDefault with 0 (which means the
3974         same thing), since we can't import the kCFAllocatorDefault symbol when
3975         delay-loading CoreFoundation.dll.
3976
3977         Rubberstamped by Sam.
3978
3979         * DumpRenderTree/win/DumpRenderTree.cpp:
3980         (runTest):
3981         (javaScriptThreads):
3982         * DumpRenderTree/win/DumpRenderTree.vcproj:
3983         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3984         (LayoutTestController::setWaitToDump):
3985
3986 2007-09-25  Adam Roben  <aroben@apple.com>
3987
3988         Pull ole32.lib into WebKitInitializer
3989
3990         Rubberstamped by Sam.
3991
3992         * WebKitInitializer/WebKitInitializer.vcproj:
3993
3994 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
3995
3996         Reviewed by Adam.
3997
3998         - Fix http://bugs.webkit.org/show_bug.cgi?id=14885
3999           LGPL'ed files contain incorrect FSF address
4000
4001         * Drosera/config.h:
4002
4003 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
4004
4005         Reviewed by Adam.
4006
4007         Make svn-apply and svn-unapply work with git-diff formatted patches.
4008
4009         * Scripts/svn-apply: Apply a filter to the input if we find a git-diff marker before a patch.
4010         (gitdiff2svndiff): Added.
4011         * Scripts/svn-unapply: Ditto.
4012         (gitdiff2svndiff): Added.
4013
4014 2007-09-25  Adam Roben  <aroben@apple.com>
4015
4016         Pull advapi32.lib into WebKitInitializer
4017
4018         This is needed to get the registry functions we use.
4019
4020         Rubberstamped by Sam.
4021
4022         * WebKitInitializer/WebKitInitializer.vcproj:
4023
4024 2007-09-25  Adam Roben  <aroben@apple.com>
4025
4026         Add python and rsync to cygwin-downloader
4027
4028         Our build slaves need this, and it can't hurt for everyone else to
4029         have it, too.
4030
4031         Reviewed by Sam.
4032
4033         * CygwinDownloader/cygwin-downloader.py: Added python and rsync.
4034         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
4035
4036 2007-09-25  Adam Roben  <aroben@apple.com>
4037
4038         Add WebKitInitializer and use it in DumpRenderTree
4039
4040         WebKitInitializer is a static library that has one function,
4041         initializeWebKit(). This registers WebKit and sets up the DLL search
4042         path so that WebKit's dependencies that are installed with Safari can
4043         be found.
4044
4045         Reviewed by Sam.
4046
4047         * DumpRenderTree/DumpRenderTree.sln: Added WebKitInitializer and made
4048         DumpRenderTree depend on it.
4049         * DumpRenderTree/win/DumpRenderTree.cpp:
4050         (initialize): Call initializeWebKit.
4051         * DumpRenderTree/win/DumpRenderTree.vcproj: Link against
4052         WebKitInitializer.lib.
4053         * WebKitInitializer/WebKitInitializer.cpp: Added.
4054         (getStringValue):
4055         (getWebViewCLSID):
4056         (getInstalledWebKitDirectory):
4057         (initializeWebKit):
4058         * WebKitInitializer/WebKitInitializer.h: Added.
4059         * WebKitInitializer/WebKitInitializer.vcproj: Added.
4060         * WebKitInitializer/debug.vsprops: Added.
4061         * WebKitInitializer/release.vsprops: Added.
4062
4063 2007-09-25  Adam Roben  <aroben@apple.com>
4064
4065         Make run-webkit-tests respect set-webkit-configuration
4066
4067         Reviewed by Sam.
4068
4069         * Scripts/run-webkit-tests: Initialize $configuration to whatever
4070         set-webkit-configuration was last set to.
4071
4072 2007-09-25  Mark Rowe  <mrowe@apple.com>
4073
4074         Rubber-stamped by Eric.
4075
4076         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
4077         This makes it possible to automate nightly builds for the feature-branch.
4078
4079 2007-09-25  Adam Roben  <aroben@apple.com>
4080
4081         A couple of fixes/enhancements to update-webkit-*-libs
4082
4083         You can now specify WEBKITSUPPORTLIBRARIESZIPDIR=C:\my\special\place
4084         to tell update-webkit-support-libraries where it should find the
4085         WebKitSupportLibrary.zip file you downloaded.
4086
4087         These scripts also now correctly interpret WEBKITLIBRARIESDIR as a
4088         Windows-style path.
4089
4090         Reviewed by Sam.
4091
4092         * Scripts/update-webkit-auxiliary-libs: Also renamed $supportLibsURL
4093         to $auxiliaryLibsURL and removed an irrelevant comment.
4094         * Scripts/update-webkit-support-libs:
4095
4096 2007-09-25  Adam Treat  <treat@kde.org>
4097
4098         Reviewed by Simon and Lars.
4099
4100         Refactors and cleans up Qt DRT member variable names, member variable
4101         initialization, style fixes and general code cleanup.
4102
4103         Adds queueReload slot to LayoutTestController that some tests require.
4104
4105         Subclasses QWebFrame to make sure that all frames have an associated
4106         LayoutTestController JS window object.
4107
4108         Takes advantage of new QWebFrame provisionalLoad signal to ensure frames
4109         aren't dumped twice.
4110
4111         EOF fixes.
4112
4113         Together, this patch fixes some 20+ layout tests in QtWebKit.
4114
4115         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
4116         (WebCore::WebFrame::WebFrame):
4117         (WebCore::WebPage::WebPage):
4118         (WebCore::WebPage::createFrame):
4119         (WebCore::DumpRenderTree::DumpRenderTree):
4120         (WebCore::DumpRenderTree::open):
4121         (WebCore::DumpRenderTree::readStdin):
4122         (WebCore::DumpRenderTree::initJSObjects):
4123         (WebCore::DumpRenderTree::dump):
4124         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
4125         (WebCore::DumpRenderTree::layoutTestController):
4126         (WebCore::DumpRenderTree::eventSender):
4127         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
4128         (LayoutTestController::LayoutTestController):
4129         (LayoutTestController::reset):
4130         (LayoutTestController::maybeDump):
4131         (LayoutTestController::waitUntilDone):
4132         (LayoutTestController::notifyDone):
4133         (LayoutTestController::queueReload):
4134         (LayoutTestController::provisionalLoad):
4135         (EventSender::EventSender):
4136         (EventSender::mouseDown):
4137         (EventSender::mouseUp):
4138         (EventSender::mouseMoveTo):
4139         (EventSender::frameUnderMouse):
4140         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
4141         (LayoutTestController::isLoading):
4142         (LayoutTestController::setLoading):
4143         (LayoutTestController::dumpAsText):
4144         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
4145         (main):
4146
4147 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
4148
4149
4150         - Reverted an accidentally checked in file.
4151
4152         * Drosera/win/DebuggerDocumentPlatform.cpp: Removed.
4153
4154 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
4155         Reviewed by Sam.
4156
4157         - Updated project files to not use Edit and Continue for Debug Information since it doesn't work and breaks some functionality.
4158
4159         * DumpRenderTree/win/DumpRenderTree.vcproj:
4160         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
4161
4162 2007-09-20  Holger Hans Peter Freyther  <zecke@selfish.org>
4163
4164         Rubber stamped by Adam.
4165
4166         * GdkLauncher: Removed.
4167         * GdkLauncher/Bakefiles.bkgen: Removed.
4168         * GdkLauncher/ENV: Removed.
4169         * GdkLauncher/GdkLauncher.pro: Removed.
4170         * GdkLauncher/gdklauncher.bkl: Removed.
4171         * GdkLauncher/main.cpp: Removed.
4172         * GdkLauncher/mk: Removed.
4173         * GdkLauncher/simple.svg: Removed.
4174         * GdkLauncher/text.html: Removed.
4175         * GtkLauncher: Added.
4176         * GtkLauncher/GdkLauncher.pro: Removed.
4177         * GtkLauncher/GtkLauncher.pro: Added.
4178         * GtkLauncher/main.cpp:
4179         (updateWindowTitle):
4180         (main):
4181         * Scripts/build-webkit:
4182         * Scripts/regenerate-makefiles:
4183         * Scripts/run-javascriptcore-tests:
4184         * Scripts/run-launcher:
4185         * Scripts/run-webkit-tests:
4186         * Scripts/webkitdirs.pm:
4187
4188 2007-09-21  Timothy Hatcher  <timothy@apple.com>
4189
4190         Reviewed by Darin.
4191
4192         <rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded (breaks EA Sports Online)
4193
4194         Assert that the -[WebScriptObject JSObject] return value is only NULL for non-window objects.
4195         This is tested by plugins/root-object-premature-delete-crash.html.
4196
4197         * DumpRenderTree/mac/ObjCController.m:
4198         (-[ObjCController accessStoredWebScriptObject]):
4199
4200 2007-09-21  Kevin McCullough  <kmccullough@apple.com>
4201
4202         Reviewed by Oliver.
4203
4204         - We need to initialize the ref count to 1 at initialization so that objects are not garbage collected. (actual patch written by Oliver)
4205
4206         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
4207         (FrameLoadDelegate::FrameLoadDelegate):
4208
4209 2007-09-20  Julien Chaffraix  <julien.chaffraix@gmail.com>
4210
4211         Reviewed by Adam.
4212
4213         Fix: http://bugs.webkit.org/show_bug.cgi?id=15223
4214         webkitdir.pm::isQt() is not working properly in run-webkit-tests under Linux/Qt
4215
4216         Added determineIsQt() and determineIsGdk() to webkitdirs.pm.
4217         Now isQt() and isGdk() use global variables that are only set once.
4218
4219         An array of all the parameters is now given to build-dumprender which includes
4220         the platform on linux.
4221
4222         * Scripts/build-dumprendertree:
4223         * Scripts/run-webkit-tests:
4224         * Scripts/webkitdirs.pm:
4225
4226 2007-09-19  Adam Roben  <aroben@apple.com>
4227
4228         Rubberstamped by Hyatt.
4229
4230         * Spinneret: Removed.
4231
4232 2007-09-19  Tuukka Hastrup  <Tuukka.Hastrup@iki.fi>
4233
4234         Reviewed by David Kilzer.
4235
4236         * Scripts/webkitdirs.pm: On Gdk and Qt, check that flex, bison, gperf are available.
4237
4238 2007-09-18  Sam Weinig  <sam@webkit.org>
4239
4240         Add JSRetainPtr.h #include to fix some builds.
4241
4242         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4243
4244 2007-09-18  Mike Hommey  <glandium@debian.org>
4245
4246         Reviewed by Adam.
4247
4248         * Scripts/prepare-ChangeLog:
4249         - Properly parse GECOS field.
4250         - Use git configuration for user name and email when appropriate.
4251
4252 2007-09-17  Sam Weinig  <sam@webkit.org>
4253
4254         Build fix.
4255
4256         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4257
4258 2007-09-17  Sam Weinig  <sam@webkit.org>
4259
4260         Reviewed by Adam Roben.
4261
4262         Share more code between mac and windows DRT.
4263             - GCController is now shared.
4264             - Rename WaitUntilDoneDelegate to FrameLoadDelegate for consistency.
4265
4266         * DumpRenderTree/GCController.cpp:
4267         * DumpRenderTree/win/DumpRenderTree.cpp:
4268         * DumpRenderTree/win/DumpRenderTree.vcproj:
4269         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.cpp.
4270         (FrameLoadDelegate::FrameLoadDelegate):
4271         (FrameLoadDelegate::~FrameLoadDelegate):
4272         (FrameLoadDelegate::windowScriptObjectAvailable):
4273         * DumpRenderTree/win/FrameLoaderDelegate.h: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.h.
4274         * DumpRenderTree/win/GCController.cpp: Removed.
4275         * DumpRenderTree/win/GCController.h: Removed.
4276         * DumpRenderTre