2010-08-30 Alejandro G. Castro <alex@igalia.com>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-08-30  Alejandro G. Castro  <alex@igalia.com>
2
3         Reviewed by Martin Robinson.
4
5         [Gtk] gdk_display_get_core_pointer and gdk_device_get_core_pointer
6         are deprecated
7         https://bugs.webkit.org/show_bug.cgi?id=44787
8
9         We have replaced GtkVersioning.cpp with GtkVersioning.c and
10         created a function (getDefaultGDKPointerDevice) to get the pointer
11         of the window with the new APIs. We added that function to DRT and
12         copyandpaste unit test.
13
14         * DumpRenderTree/gtk/EventSender.cpp:
15         (prepareMouseButtonEvent):
16         (mouseMoveToCallback):
17         (keyDownCallback):
18         * GNUmakefile.am:
19
20 2010-08-30  Zoltan Horvath  <zoltan@webkit.org>
21
22         Reviewed by Kenneth Rohde Christiansen.
23
24         [Qt] Add new window menu to MiniBrowser
25
26         Implement newWindow function and add a menu item for opening new window in MiniBrowser.
27
28         * MiniBrowser/qt/BrowserWindow.cpp:
29         (BrowserWindow::BrowserWindow):
30         (BrowserWindow::newWindow):
31         * MiniBrowser/qt/BrowserWindow.h:
32         * MiniBrowser/qt/main.cpp:
33         (main):
34
35 2010-08-29  James Robinson  <jamesr@chromium.org>
36
37         Reviewed by David Levin.
38
39         Make failing the download step fail the build
40         https://bugs.webkit.org/show_bug.cgi?id=44298
41
42         If the download step fails on a test bot, this ensures that
43         the build goes red instead of only the download step going red
44         and the overall build staying green.
45
46         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
47
48 2010-08-29  Kent Tamura  <tkent@chromium.org>
49
50         Reviewed by Dimitri Glazkov.
51
52         [DRT/Chromium] Remove dependency to base/keyboard_codes.h
53         https://bugs.webkit.org/show_bug.cgi?id=44847
54
55         * DumpRenderTree/chromium/EventSender.cpp:
56          Use webkit_support::VKEY_* instead of base::VKEY_*.
57
58 2010-08-29  Darin Adler  <darin@apple.com>
59
60         https://bugs.webkit.org/show_bug.cgi?id=40589
61
62         * Scripts/prepare-ChangeLog: Only prepend namespaces to non-empty
63         function names.
64
65 2010-08-26  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
66
67         Reviewed by Darin Adler.
68
69         [iExploder] Add new CSS Properties and HTML Attributes
70         https://bugs.webkit.org/show_bug.cgi?id=44746
71
72         Updated the files with the update-iexploder-cssproperties script
73         and manually readded the -webkit-binding CSS Property to the list.
74
75         * iExploder/htdocs/cssproperties.in:
76         * iExploder/htdocs/htmlattrs.in:
77         * iExploder/htdocs/htmltags.in:
78
79 2010-08-26  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
80
81         Reviewed by Darin Adler.
82
83         Fix Coverage build after the addition of ANGLE
84         https://bugs.webkit.org/show_bug.cgi?id=44744
85
86         ANGLE is using libtool to build a static library and the version of
87         libtool on Leopard refuses to handle the -fprofile-arcs and -ftest-coverage
88         parameters. The easiest way to handle this is to not build ANGLE with
89         coverage information.
90
91         This is achieved by applying the XCode options for each project
92         separately and exclude ANGLE.
93
94         * Scripts/build-webkit: Remove -framework AppKit due link errors.
95         * Scripts/webkitdirs.pm: Do not apply the XCode options for ANGLE.
96
97 2010-08-28  Kevin Ollivier  <kevino@theolliviers.com>
98
99         [wx] Build fix after directory addition.
100
101         * wx/build/settings.py:
102
103 2010-08-28  Chris Guillory   <chris.guillory@google.com>
104
105         Reviewed by Chris Fleizach.
106
107         Add AX notification for childrenChanged
108         https://bugs.webkit.org/show_bug.cgi?id=44472
109
110         * DumpRenderTree/chromium/AccessibilityController.cpp:
111         (AccessibilityController::AccessibilityController):
112         (AccessibilityController::reset):
113         (AccessibilityController::getRootElement):
114         (AccessibilityController::dumpAccessibilityNotifications):
115         * DumpRenderTree/chromium/AccessibilityController.h:
116         (AccessibilityController::shouldDumpAccessibilityNotifications):
117         * DumpRenderTree/chromium/WebViewHost.cpp:
118         (WebViewHost::didChangeAccessibilityObjectChildren):
119         * DumpRenderTree/chromium/WebViewHost.h:
120
121 2010-08-28  Eric Seidel  <eric@webkit.org>
122
123         Reviewed by Adam Barth.
124
125         Update commit-queue failure message
126         https://bugs.webkit.org/show_bug.cgi?id=44798
127
128         The commit-queue auto-restarts itself and has for a very long time.
129         No need for people to email me to request a restart anymore.
130
131         * Scripts/webkitpy/common/net/bugzilla.py:
132         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
133         * Scripts/webkitpy/tool/commands/queues_unittest.py:
134
135 2010-07-27  Jer Noble  <jer.noble@apple.com>
136
137         Reviewed by Eric Carlson.
138
139         Add JavaScript API to allow a page to go fullscreen.
140         rdar://problem/6867795
141         
142         Added basic full screen support to DumpRenderTree: when a webView requests
143         that DumpRenderTree go "full screen", just call the provided callback listener object's
144         will/did Enter/Exit full screen methods.  Also, register a new user default which 
145         enables full screen support.
146
147         * DumpRenderTree/mac/DumpRenderTree.mm:
148         (resetDefaultsToConsistentValues):
149         * DumpRenderTree/mac/UIDelegate.mm:
150         (-[UIDelegate webView:supportsFullscreenForElement:]):
151         (-[UIDelegate webView:enterFullscreenForElement:listener:]):
152         (-[UIDelegate webView:exitFullscreenForElement:listener:]):
153
154 2010-08-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
155
156         Unreviewed. Add myself to the committers list.
157
158         * Scripts/webkitpy/common/config/committers.py:
159
160 2010-08-27  Kent Tamura  <tkent@chromium.org>
161
162         Reviewed by Pavel Feldman.
163
164         [DRT/Chromium] Fix inspector test failures
165         https://bugs.webkit.org/show_bug.cgi?id=44748
166
167         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
168         (DRTDevToolsAgent::createClientMessageLoop):
169           Returns a valid WebKitClientMessageLoop instance
170         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
171
172 2010-08-26  Jon Honeycutt  <jhoneycutt@apple.com>
173
174         Add Windows WebKit2 Tester to buildbot
175         <rdar://problem/7887703>
176
177         Reviewed by Dan Bernstein.
178
179         * BuildSlaveSupport/build.webkit.org-config/config.json:
180
181 2010-08-26  Philippe Normand  <pnormand@igalia.com>
182
183         Reviewed by Martin Robinson.
184
185         [GTK] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
186         https://bugs.webkit.org/show_bug.cgi?id=42152
187
188         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
189         (LoadHTMLStringItem::invoke): Implementation using
190         webkit_web_frame_load_string().
191
192 2010-08-25  Jon Honeycutt  <jhoneycutt@apple.com>
193
194         <rdar://problem/8334338> run-webkit-tests sometimes hangs when using
195         WebKitTestRunner (44331)
196
197         Reviewed by Darin Adler.
198
199         * WebKitTestRunner/TestController.cpp:
200         (WTR::TestController::initialize):
201         The hang occurs when WebKitTestRunner begins launching the WebKit2
202         web process then exits before it finishes launching. Work around this by
203         looking for the --print-supported-features argument and exiting without
204         creating the web process.
205
206 2010-08-26  Dirk Pranke  <dpranke@chromium.org>
207
208         Reviewed by Tony Chang.
209
210         new-run-webkit-tests: add rebaselining tests for test_expectations
211         
212         This patch adds more unit tests for the rebaselining code in the
213         test_expectations module. It doesn't add any tests for
214         rebaseline_chromium_webkit_tests itself; that will come some other
215         time.
216
217         https://bugs.webkit.org/show_bug.cgi?id=44648
218
219         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
220         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
221
222 2010-08-26  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
223
224         Reviewed by Martin Robinson.
225
226         [GTK] Add HTTP caching support
227         https://bugs.webkit.org/show_bug.cgi?id=44261
228
229         Ignore new soup API that we decided to merge into the soup backend
230         while it is being cooked. It follows the libsoup style, and will
231         be removed from WebKit as soon as it is merged into libsoup.
232
233         * Scripts/webkitpy/style/checker.py:
234
235 2010-08-26  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
236
237         Reviewed by Kenneth Rohde Christiansen.
238
239         [Qt] DumpRenderTree runs only one test from command mode
240         https://bugs.webkit.org/show_bug.cgi?id=44012
241
242         Enables support to run multiple test files and single
243         folder containing html files in stand alone mode
244
245         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
246         (WebCore::DumpRenderTree::DumpRenderTree):
247         (WebCore::DumpRenderTree::processArgsLine):
248         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
249         (WebCore::DumpRenderTree::processLine):
250         (WebCore::DumpRenderTree::dump):
251         * DumpRenderTree/qt/DumpRenderTreeQt.h:
252         (WebCore::DumpRenderTree::setStandAloneMode):
253         (WebCore::DumpRenderTree::isStandAloneMode):
254         * DumpRenderTree/qt/main.cpp:
255         (main):
256
257 2010-08-25  Martin Robinson  <mrobinson@igalia.com>
258
259         Updating webkitpy test expectations.
260
261         * Scripts/webkitpy/tool/steps/steps_unittest.py:
262
263 2010-08-25  Ojan Vafai  <ojan@chromium.org>
264
265         Reviewed by Eric Seidel.
266
267         fix the always squash git config
268         https://bugs.webkit.org/show_bug.cgi?id=44651
269
270         Fix help text and apparently underscores are not allowed
271         in git config keys.
272
273         * Scripts/webkitpy/common/checkout/scm.py:
274         * Scripts/webkitpy/tool/steps/commit.py:
275
276 2010-08-25  Darin Adler  <darin@apple.com>
277
278         Reviewed by John Sullivan.
279
280         * Scripts/commit-log-editor: Fix perl warning for people who have no
281         value for SVN_LOG_EDITOR or CVS_LOG_EDITOR.
282
283 2010-08-25  Ojan Vafai  <ojan@chromium.org>
284
285         Reviewed by Eric Seidel.
286
287         stop blocking commits when the bots are red
288         https://bugs.webkit.org/show_bug.cgi?id=44644
289
290         This check currently is just annoying. It doesn't actually
291         help keep the tree green. We can always add it back later
292         if we decide the tree is generally more green.
293
294         * Scripts/webkitpy/tool/commands/download_unittest.py:
295         * Scripts/webkitpy/tool/mocktool.py:
296         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
297
298 2010-08-25  Eric Seidel  <eric@webkit.org>
299
300         Reviewed by Simon Fraser.
301
302         REGRESSION: media/video-loop.html is timing out on the commit-queue Leopard Bot
303         https://bugs.webkit.org/show_bug.cgi?id=38912
304
305         I know of nothing else to do but skip all media tests for the cq.
306
307         * Scripts/webkitpy/tool/steps/runtests.py:
308
309 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
310
311         Reviewed by Ojan Vafai.
312
313         new-run-webkit-tests: add more unit tests for test_expectations
314         This adds unit tests to cover (almost?) all of the non-rebaselining
315         functionality.
316
317         https://bugs.webkit.org/show_bug.cgi?id=44579
318
319         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
320         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
321
322 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
323
324         Reviewed by Ojan Vafai.
325
326         new-run-webkit-tests: add more unit tests
327
328         This change adds more unit tests for the image_diff, test_failures,
329         and test_files modules, bringing them to 100% coverage (and adds a
330         couple tests to run_webkit_tests while we're at it).
331
332         This test also turns on the "dryrun" port for testing when run on
333         the mac, increasing coverage in a few other places.
334
335         https://bugs.webkit.org/show_bug.cgi?id=44578
336
337         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.checksum: Added.
338         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.png: Added.
339         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.txt: Added.
340         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html.
341         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.png: Added.
342         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.txt: Added.
343         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html.
344         * Scripts/webkitpy/layout_tests/data/failures/expected/timeout.html: Added.
345         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
346         * Scripts/webkitpy/layout_tests/data/resources/README.txt: Added.
347         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
348         * Scripts/webkitpy/layout_tests/port/test.py:
349         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
350
351 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
352
353         Reviewed by Ojan Vafai.
354
355         new-run-webkit-tests: add more unit tests for layout_package/printing.py
356
357         This change adds more unit tests to get the test coverage to 100%
358         for the printing module. This code is actually pretty crufty and
359         has some layering violations that need to be cleaned up but I'll
360         save that for another CL after we get all the unit tests written and
361         we fix the multithreading issues. At least now we'll be able to tell
362         if we break things.
363
364         https://bugs.webkit.org/show_bug.cgi?id=44576
365
366         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
367         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
368
369 2010-08-25  Ojan Vafai  <ojan@chromium.org>
370
371         Reviewed by Adam Barth.
372
373         new-run-webkit-tests should respect set-webkit-configuration
374         https://bugs.webkit.org/show_bug.cgi?id=44633
375
376         Moves the getting of the configuration into the base Port so that
377         chromium ports use it as well. In the downstream chromium port,
378         this should still just return Release.
379
380         * Scripts/webkitpy/layout_tests/port/base.py:
381         * Scripts/webkitpy/layout_tests/port/webkit.py:
382
383 2010-08-25  Tony Chang  <tony@chromium.org>
384
385         Not reviewed, changing svn props for a script.
386
387         * Scripts/deduplicate-tests: Added properties svn:executable and svn:eol-style.
388
389 2010-08-25  Adam Barth  <abarth@webkit.org>
390
391         Reviewed by Eric Seidel.
392
393         Remove WebKit2 from core builders
394         https://bugs.webkit.org/show_bug.cgi?id=44625
395
396         This builder was added to the core builders by accident.  It doesn't
397         appear to be green enough to be a core builder yet.
398
399         * Scripts/webkitpy/common/net/buildbot.py:
400         * Scripts/webkitpy/common/net/buildbot_unittest.py:
401
402 2010-08-19  Adam Roben  <aroben@apple.com>
403
404         Test that NP_Initialize and NP_GetEntryPoints are called in the
405         correct order
406
407         The order differs between Mac and Windows (see r38858).
408
409         Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in
410         NP_Initialize when loading QuickTime when running
411         plugins/embed-attributes-setting.html in WebKit2 on Windows
412
413         Reviewed by John Sullivan.
414
415         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and
416         a boolean to record whether NP_GetEntryPoints has been called.
417         (NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been
418         called yet. This matches Flash and QuickTime's behavior.
419         (NP_GetEntryPoints): Crash on Mac if NP_Initialize hasn't been called
420         yet. This matches Silverlight's behavior.
421
422 2010-08-25  Martin Robinson  <mrobinson@igalia.com>
423
424         Reviewed by Gustavo Noronha Silva.
425
426         Cairo and EFL port shouldn't depend on glib.
427         https://bugs.webkit.org/show_bug.cgi?id=44354
428
429         Replace occurrences of GRefPtr and adoptGRef with PlatformRefPtr and
430         adoptPlatformRef.
431
432         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
433         (AccessibilityUIElement::isSelected):
434
435 2010-08-25  Ojan Vafai  <ojan@chromium.org>
436
437         Fix order of Timothy's email address. The script, and
438         other tools all assume that the first email is the bugzilla address.
439
440         * Scripts/webkitpy/common/config/committers.py:
441
442 2010-08-24  Kent Tamura  <tkent@chromium.org>
443
444         Reviewed by Pavel Feldman.
445
446         [DRT/Chromium] Fix 26 inspector test crashes
447         https://bugs.webkit.org/show_bug.cgi?id=44580
448
449         - DRTDevToolsAgent has a reference to the main WebView. So we
450           should not clear it in closeDevTools() and should clear it in
451           ~TestShell().
452         - DRTDevToolsClient has a reference to a DevTools WebView and no
453           way to update it. So we should delete DRTDevToolsClient instances
454           in closeDevTools().
455
456         * DumpRenderTree/chromium/TestShell.cpp:
457         (TestShell::~TestShell):
458         (TestShell::closeDevTools):
459
460 2010-08-24  Eric Seidel  <eric@webkit.org>
461
462         Reviewed by Adam Barth.
463
464         unicode(Exception(\u"0x1234")) is busted in python 2.5, disable tests which hit this
465         https://bugs.webkit.org/show_bug.cgi?id=44584
466
467         * Scripts/webkitpy/tool/commands/queues_unittest.py:
468
469 2010-08-24  Eric Seidel  <eric@webkit.org>
470
471         Reviewed by Adam Barth.
472
473         commit-queue and EWS bots should report all failures
474         https://bugs.webkit.org/show_bug.cgi?id=41820
475
476         Right now commit-queue/EWS only report failures when the
477         patch under testing fails.  We should report all failures
478         to the status server so that we can diagnose when the bots
479         are wedged w/o needing to log into the machines.
480
481         I also reduced the amount of data we upload since we've seen
482         timeouts during status upload.
483
484         * Scripts/webkitpy/common/system/executive.py:
485         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
486         * Scripts/webkitpy/tool/commands/queues.py:
487         * Scripts/webkitpy/tool/commands/queues_unittest.py:
488
489 2010-08-24  Eric Seidel  <eric@webkit.org>
490
491         Reviewed by Adam Barth.
492
493         Remove HTML5 parser testing infrastructure now that we don't need it
494         https://bugs.webkit.org/show_bug.cgi?id=44581
495
496         * DumpRenderTree/mac/DumpRenderTree.mm:
497         (resetDefaultsToConsistentValues):
498         (initializeGlobalsFromCommandLineOptions):
499         * Scripts/old-run-webkit-tests:
500         * Scripts/test-html5-parser: Removed.
501
502 2010-08-24  Kent Tamura  <tkent@chromium.org>
503
504         Reviewed by Dimitri Glazkov.
505
506         [DRT/Chromium] Fix 28 inspector test crashes
507         https://bugs.webkit.org/show_bug.cgi?id=44574
508
509         Reset DevToolsClient and DevToolsAgent before closing a DevTools
510         WebView in order to avoid accessing to a deleted WebView instance.
511
512         * DumpRenderTree/chromium/TestShell.cpp:
513         (TestShell::closeDevTools):
514
515 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
516
517         Reviewed by Ojan Vafai.
518
519         new-run-webkit-tests: clean up code for test_types, test_failures
520
521         Add a bunch of unit tests for webkitpy.layout_tests.test_types and
522         webkitpy.layout_tests.layout_package.test_failures, and remove
523         some dead code and otherwise clean up things.
524
525         https://bugs.webkit.org/show_bug.cgi?id=44559
526
527         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
528         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py: Added.
529         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
530         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
531         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
532         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: Added.
533         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
534
535 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
536
537         Reviewed by Eric Seidel.
538
539         new-run-webkit-tests: revise unit testing strategy for test failures
540     
541         This change revamps the way we store test data for new-run-webkit-tests.
542         Previously we had a few copies of test files from the main test tree.
543         Now we have a bunch of completely fake test data and use the test
544         data to generate different kinds of test failures, getting
545         much better coverage.
546
547         https://bugs.webkit.org/show_bug.cgi?id=44556
548
549         * Scripts/webkitpy/layout_tests/data/failures/expected/crash.html: Added.
550         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.checksum: Added.
551         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.png: Added.
552         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.txt: Added.
553         * Scripts/webkitpy/layout_tests/data/failures/expected/image.html: Added.
554         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.checksum: Added.
555         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.png: Added.
556         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.txt: Added.
557         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html: Added.
558         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html: Added.
559         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_text.html: Added.
560         * Scripts/webkitpy/layout_tests/data/failures/expected/text-expected.txt: Added.
561         * Scripts/webkitpy/layout_tests/data/failures/expected/text.html: Added.
562         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.checksum: Added.
563         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.png: Added.
564         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.txt: Added.
565         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum.html: Added.
566         * Scripts/webkitpy/layout_tests/data/image/canvas-bg.html: Removed.
567         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.checksum: Removed.
568         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.png: Removed.
569         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.txt: Removed.
570         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom.html: Removed.
571         * Scripts/webkitpy/layout_tests/data/misc/crash-expected.txt: Removed.
572         * Scripts/webkitpy/layout_tests/data/misc/crash.html: Removed.
573         * Scripts/webkitpy/layout_tests/data/misc/missing-expectation.html: Removed.
574         * Scripts/webkitpy/layout_tests/data/misc/passing-expected.txt: Removed.
575         * Scripts/webkitpy/layout_tests/data/misc/passing.html: Removed.
576         * Scripts/webkitpy/layout_tests/data/passes/image-expected.checksum: Added.
577         * Scripts/webkitpy/layout_tests/data/passes/image-expected.png: Added.
578         * Scripts/webkitpy/layout_tests/data/passes/image-expected.txt: Added.
579         * Scripts/webkitpy/layout_tests/data/passes/image.html: Added.
580         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.checksum: Added.
581         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.png: Added.
582         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.txt: Added.
583         * Scripts/webkitpy/layout_tests/data/passes/platform_image.html: Added.
584         * Scripts/webkitpy/layout_tests/data/passes/text-expected.txt: Added.
585         * Scripts/webkitpy/layout_tests/data/passes/text.html: Added.
586         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.checksum: Removed.
587         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.png: Removed.
588         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.txt: Removed.
589         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.checksum: Added.
590         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.png: Added.
591         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.txt: Added.
592         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
593         * Scripts/webkitpy/layout_tests/data/text/article-element-expected.txt: Removed.
594         * Scripts/webkitpy/layout_tests/data/text/article-element.html: Removed.
595         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
596         * Scripts/webkitpy/layout_tests/port/test.py:
597         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
598         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
599
600 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
601
602         Reviewed by Eric Seidel.
603
604         speed up new-run-webkit-tests unit tests
605
606         Add a --no-record-results flag that turns off generating the JSON
607         results file on every test run. Generating the file requires us to
608         fetch the old results down from the bots, which can be slow. This
609         flag is off by default.
610     
611         Reduce the sleep time in wait_for_threads_to_finish from 0.1s to 0.01s.
612     
613         These changes together shorten the test cycle from ~4.5s to ~1.5s
614         - a 3x speedup.
615
616         https://bugs.webkit.org/show_bug.cgi?id=44553
617
618         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
619         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
620
621 2010-08-24  Tony Chang  <tony@chromium.org>
622
623         Reviewed by Eric Seidel.
624
625         [chromium] fix the platform result fallback order on mac/win
626         https://bugs.webkit.org/show_bug.cgi?id=44483
627
628         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
629
630 2010-08-24  Xan Lopez  <xlopez@igalia.com>
631
632         Reviewed by Martin Robinson.
633
634         Set a device to the event struct when building with GTK+ 3.x, it's
635         mandatory.
636
637         * DumpRenderTree/gtk/EventSender.cpp:
638         (keyDownCallback):
639
640 2010-08-24  Martin Robinson  <mrobinson@igalia.com>
641
642         Reviewed by Xan Lopez.
643
644         [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
645         https://bugs.webkit.org/show_bug.cgi?id=44534
646
647         Fix two double-frees introduced in my previous commit.
648
649         * DumpRenderTree/gtk/EventSender.cpp:
650         (contextClickCallback): Copy the event before using it again.
651         (keyDownCallback): Ditto.
652
653 2010-08-24  Martin Robinson  <mrobinson@igalia.com>
654
655         Reviewed by Xan Lopez.
656
657         [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
658         https://bugs.webkit.org/show_bug.cgi?id=44534
659
660         * DumpRenderTree/gtk/EventSender.cpp:
661         (prepareMouseButtonEvent): Use gdk_event_new and reference the reference the GdkWindow
662         when setting it on the event. It is dereferenced by gdk_event_free(...).
663         (contextClickCallback): Ditto.
664         (mouseDownCallback): Ditto.
665         (mouseUpCallback): Ditto.
666         (mouseMoveToCallback): Ditto.
667         (mouseWheelToCallback): Ditto.
668         (sendOrQueueEvent): Take a GdkEvent* instead of a GdkEvent.
669         (dispatchEvent): Ditto. Also free the event when we are done with it.
670         (keyDownCallback): Use gdk_event_new and reference the GdkWindow.
671
672 2010-08-24  Andras Becsi  <abecsi@webkit.org>
673
674         [Qt] WebKit2 build fix.
675
676         * Scripts/enumerate-included-framework-headers:
677         Remove stray global option form sed.
678
679 2010-08-24  Kent Tamura  <tkent@chromium.org>
680
681         Reviewed by Jeremy Orlow.
682
683         [DRT/Chromium] Support for IndexedDB tests
684         https://bugs.webkit.org/show_bug.cgi?id=44490
685
686         * DumpRenderTree/chromium/TestShell.cpp:
687         (TestShell::TestShell): Enable IndexedDB.
688
689 2010-08-23  Martin Robinson  <mrobinson@igalia.com>
690
691         Reviewed by Gustavo Noronha Silva.
692
693         [GTK] The 64-bit Release bot is showing crashes on tests that use mouse buttons
694         https://bugs.webkit.org/show_bug.cgi?id=44465
695
696         Initialize the axes field of mouse button and motion events to null.
697         This is the value that should be used for events originating from the
698         mouse device.
699
700         * DumpRenderTree/gtk/EventSender.cpp:
701         (prepareMouseButtonEvent): Initalize button event axes field to null.
702         (mouseMoveToCallback): Initialize motion event axes field to null.
703
704 2010-08-23  Sheriff Bot  <webkit.review.bot@gmail.com>
705
706         Unreviewed, rolling out r65703.
707         http://trac.webkit.org/changeset/65703
708         https://bugs.webkit.org/show_bug.cgi?id=44460
709
710         "Causing lots of crashes on Snow Leopard when running the
711         layout tests" (Requested by eseidel2 on #webkit).
712
713         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
714         (NP_Initialize):
715         (NP_GetEntryPoints):
716
717 2010-08-23  Jon Honeycutt  <jhoneycutt@apple.com>
718
719         Layout tests do not run when using WebKitTestRunner in a Debug build.
720         https://bugs.webkit.org/show_bug.cgi?id=44409
721
722         Reviewed by Dan Bernstein.
723
724         * WebKitTestRunner/win/TestControllerWin.cpp:
725         (WTR::TestController::initializeInjectedBundlePath):
726         Use InjectedBundle_debug.dll when building Debug.
727
728 2010-08-23  Xan Lopez  <xlopez@igalia.com>
729
730         Reviewed by Martin Robinson.
731
732         [GTK] run-launcher fails if WebKitGTK+ compiled with GTK+-3.0 support
733         https://bugs.webkit.org/show_bug.cgi?id=42026
734
735         If a GTK+ 3.x build is present return that as the library to use,
736         otherwise fallback to the GTK+ 2.x build.
737
738         * Scripts/webkitdirs.pm:
739
740 2010-08-23  Balazs Kelemen  <kb@inf.u-szeged.hu>
741
742         Reviewed by Ariya Hidayat.
743
744         [Qt] Find needed forwarding headers for WebKit2 automatically
745         https://bugs.webkit.org/show_bug.cgi?id=44336
746
747         * MiniBrowser/qt/BrowserWindow.cpp: Use normal (not framework style) includes here.
748         The new script does not satisfy the needs of this file however using normal includes
749         is generally better here.
750         * MiniBrowser/qt/MiniBrowser.pro: Added include paths.
751         * Scripts/enumerate-included-framework-headers: Enumerates headers included from the 
752         given frameworks by files in the current directory (and subdirectories).
753         In the future this needs to be rewritten in perl for being able to use on Windows.
754
755 2010-08-22  No'am Rosenthal  <noam.rosenthal@nokia.com>
756
757         Reviewed by Ariya Hidayat.
758
759         [Qt] Qt test browser: enable a QGLWidget viewport with a command line argument
760         https://bugs.webkit.org/show_bug.cgi?id=43010
761
762         * QtTestBrowser/launcherwindow.cpp:
763         (LauncherWindow::applyPrefs):
764         * QtTestBrowser/main.cpp:
765         (LauncherApplication::handleUserOptions):
766
767 2010-08-21  Sam Weinig  <sam@webkit.org>
768
769         Reviewed by Dan Bernstein.
770
771         Remove specialized retain/release functions in favor of a single one for WKTypeRefs
772         https://bugs.webkit.org/show_bug.cgi?id=44386
773
774         * MiniBrowser/mac/AppDelegate.m:
775         (didRecieveMessageFromInjectedBundle):
776         (didNavigateWithNavigationData):
777         (-[BrowserAppDelegate init]):
778         (-[BrowserAppDelegate applicationWillTerminate:]):
779         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
780         (-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
781         (-[BrowserStatisticsWindowController dealloc]):
782         * MiniBrowser/mac/BrowserWindowController.m:
783         (-[BrowserWindowController initWithPageNamespace:]):
784         (-[BrowserWindowController fetch:]):
785         (-[BrowserWindowController windowWillClose:]):
786         (-[BrowserWindowController applicationTerminating]):
787         (closePage):
788         (runJavaScriptAlert):
789         (runJavaScriptConfirm):
790         (runJavaScriptPrompt):
791         (-[BrowserWindowController updateProvisionalURLForFrame:]):
792         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
793         (didClearWindowObjectForFrame):
794         * MiniBrowser/win/BrowserView.cpp:
795         (BrowserView::goToURL):
796         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
797         (WTR::PlatformWebView::~PlatformWebView):
798
799 2010-08-20  Benjamin Poulain  <benjamin.poulain@nokia.com>
800
801         Reviewed by Kenneth Rohde Christiansen.
802
803         WebKit does not build with Python 2.3
804         https://bugs.webkit.org/show_bug.cgi?id=44373
805
806         Replaced the function sorted() by a call to sort()
807         on the entry list.
808         The function sorted() has been added to Python 2.4.
809         The function method sort() of List works with older
810         versions of Python.
811
812         * Scripts/create-html-entity-table:
813
814 2010-08-20  Martin Robinson  <mrobinson@igalia.com>
815
816         Reviewed by Pavel Feldman.
817
818         Web Inspector: Inspector tests were disabled for GTK.
819         https://bugs.webkit.org/show_bug.cgi?id=43977
820
821         * Scripts/old-run-webkit-tests: Set the WEBKIT_INSPECTOR_PATH to the appropriate
822         path before running tests.
823
824 2010-08-20  Daniel Bates  <dbates@rim.com>
825
826         Reviewed by Eric Seidel.
827
828         svn-apply doesn't detect empty line with Windows line endings
829         after property value
830         https://bugs.webkit.org/show_bug.cgi?id=43981
831
832         Part 2 of 2
833
834         Add unit tests that were not landed in the first commit.
835
836         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
837           - Added the following test cases:
838             "SVN: binary file (isBinary true) using Windows line endings"
839             "SVN: property diff, followed by file change diff using Windows line endings"
840             "SVN: two consecutive property diffs using Windows line endings"
841             "SVN: binary file with executable bit change usng Windows line endings"
842             "SVN: binary file followed by property change on different file using Windows line endings"
843             "SVN: binary file followed by file change on different file using Windows line endings"
844             "SVN: file change diff with property change, followed by property change diff using Windows line endings"
845             "SVN: file change diff with property change, followed by file change diff using Windows line endings"
846         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
847           - Added the following test cases:
848             "add svn:executable, followed by empty line and start of next diff using Windows line endings"
849             "add svn:executable, followed by empty line and start of next property diff using Windows line endings"
850             "multi-line '+' change, followed by empty line and start of next diff using Windows line endings"
851             "multi-line '+' change, followed by empty line and start of next property diff using Windows line endings"
852             "add svn:executable, followed by empty line and start of binary patch using Windows line endings"
853             "multi-line '+' change, followed by empty line and start of binary patch using Windows line endings"
854             "multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings"
855             "single-line '+' with trailing new line using Windows line endings"
856             "single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings"
857             "single-line '-' change with trailing new line, and single-line '+' change using Windows line endings"
858             "multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
859         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
860           - Added the following test cases:
861             "single-line '-' change followed by empty line with Windows line endings"
862             "multi-line '+' change and start of binary patch with Windows line endings"
863
864 2010-08-20  Daniel Bates  <dbates@rim.com>
865
866         Reviewed by Eric Seidel.
867
868         svn-apply doesn't detect empty line with Windows line endings
869         after property value
870         https://bugs.webkit.org/show_bug.cgi?id=43981
871
872         Fixes an issue where an empty line following the property value
873         in an SVN property change diff would not be detected if it had
874         Windows line endings (i.e. ended in CRLF). Hence it was consumed
875         as if it was part of a multi-line property value. 
876
877         * Scripts/VCSUtils.pm:
878           - Modified parseSvnPropertyValue() to detect empty line
879             with Windows line endings.
880           - Added toWindowsLineEndings().
881         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
882           - Added the following test cases:
883             "SVN: binary file (isBinary true) using Windows line endings"
884             "SVN: property diff, followed by file change diff using Windows line endings"
885             "SVN: two consecutive property diffs using Windows line endings"
886             "SVN: binary file with executable bit change usng Windows line endings"
887             "SVN: binary file followed by property change on different file using Windows line endings"
888             "SVN: binary file followed by file change on different file using Windows line endings"
889             "SVN: file change diff with property change, followed by property change diff using Windows line endings"
890             "SVN: file change diff with property change, followed by file change diff using Windows line endings"
891         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
892           - Added the following test cases:
893             "add svn:executable, followed by empty line and start of next diff using Windows line endings"
894             "add svn:executable, followed by empty line and start of next property diff using Windows line endings"
895             "multi-line '+' change, followed by empty line and start of next diff using Windows line endings"
896             "multi-line '+' change, followed by empty line and start of next property diff using Windows line endings"
897             "add svn:executable, followed by empty line and start of binary patch using Windows line endings"
898             "multi-line '+' change, followed by empty line and start of binary patch using Windows line endings"
899             "multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings"
900             "single-line '+' with trailing new line using Windows line endings"
901             "single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings"
902             "single-line '-' change with trailing new line, and single-line '+' change using Windows line endings"
903             "multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
904         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
905           - Added the following test cases:
906             "single-line '-' change followed by empty line with Windows line endings"
907             "multi-line '+' change and start of binary patch with Windows line endings"
908
909 2010-08-19  David Kilzer  <ddkilzer@apple.com>
910
911         BUILD FIX: Fix Mac build after Windows WebKit2 changes for Netscape Plug-ins
912
913         * MiniBrowser/mac/BrowserWindowController.m:
914         (decidePolicyForNavigationAction): Updated method signature.
915         (decidePolicyForNewWindowAction): Updated method signature.
916
917 2010-08-19  Adam Roben  <aroben@apple.com>
918
919         Test that NP_Initialize and NP_GetEntryPoints are called in the
920         correct order
921
922         The order differs between Mac and Windows (see r38858).
923
924         Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in
925         NP_Initialize when loading QuickTime when running
926         plugins/embed-attributes-setting.html in WebKit2 on Windows
927
928         Reviewed by Sam Weinig.
929
930         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and
931         a boolean to record whether NP_GetEntryPoints has been called.
932         (NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been
933         called yet. This matches Flash and QuickTime's behavior. Crash on Mac
934         if NP_GetEntryPoints has been called already. This matches
935         Silverlight's behavior.
936
937 2010-08-19  Adam Roben  <aroben@apple.com>
938
939         Make build-webkittestrunner build TestNetscapePlugIn on Windows
940
941         Fixes <http://webkit.org/b/44268> <rdar://problem/8330388>
942
943         Reviewed by Sam Weinig.
944
945         * WebKitTestRunner/WebKitTestRunner.sln: Added TestNetscapePlugIn.
946         Threaded it in between ImageDiff and InjectedBundleGenerated.
947
948 2010-08-19  Ojan Vafai  <ojan@chromium.org>
949
950         Reviewed by Adam Barth.
951
952         install rietveld's upload script from a versioned url
953         https://bugs.webkit.org/show_bug.cgi?id=44291
954
955         autoinstall expects the file at a given URL to never change.
956         In order to be able to update the file, we need to be able to
957         change the path.
958
959         * Scripts/webkitpy/thirdparty/__init__.py:
960
961 2010-08-19  Ojan Vafai  <ojan@chromium.org>
962
963         Reviewed by Adam Barth.
964
965         add --webkit_patch_id to reitveld uploads
966         https://bugs.webkit.org/show_bug.cgi?id=44289
967
968         This is the first step in having rietveld store which
969         patches have been uploaded and getting rid of the
970         in-rietveld flag.
971
972         * Scripts/webkitpy/common/net/rietveld.py:
973         * Scripts/webkitpy/tool/mocktool.py:
974         * Scripts/webkitpy/tool/steps/postcodereview.py:
975
976 2010-08-19  Kenneth Russell  <kbr@google.com>
977
978         Reviewed by David Levin.
979
980         Adjust my status from committer to reviewer
981         https://bugs.webkit.org/show_bug.cgi?id=44277
982
983         * Scripts/webkitpy/common/config/committers.py:
984
985 2010-08-19  Pavel Feldman  <pfeldman@chromium.org>
986
987         Reviewed by Yury Semikhatsky.
988
989         Chromium DevTools: remove injected script fetcher from test harness.
990         https://bugs.webkit.org/show_bug.cgi?id=44266
991
992         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
993         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
994
995 2010-08-19  Pavel Feldman  <pfeldman@chromium.org>
996
997         Reviewed by Yury Semikhatsky.
998
999         Chromium DevTools: There is no need in resource-based InjectedScript.js source.
1000         Now that we populate front-end after its onload handler, we don't need
1001         to install injected script early. Exposing injected script source on the WebCore
1002         level here.
1003         https://bugs.webkit.org/show_bug.cgi?id=44029
1004
1005         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1006         (DRTDevToolsAgent::runtimePropertyChanged):
1007         (DRTDevToolsAgent::delayedFrontendLoaded):
1008         (DRTDevToolsAgent::frontendLoaded):
1009         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1010
1011 2010-08-19  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1012
1013         Reviewed by Kenneth Rohde Christiansen.
1014
1015         [Gtk] Enable view mode media feature layout test
1016         https://bugs.webkit.org/show_bug.cgi?id=43278
1017
1018         Add view mode media feature testing infrastructure, and add
1019         placeholder methods for the other platforms'
1020         LayoutTestControllers.
1021
1022         * DumpRenderTree/LayoutTestController.cpp:
1023         (setViewModeMediaFeatureCallback):
1024         (LayoutTestController::staticFunctions):
1025         * DumpRenderTree/LayoutTestController.h:
1026         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1027         (LayoutTestController::setViewModeMediaFeature):
1028         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1029         (LayoutTestController::setViewModeMediaFeature):
1030         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1031         (LayoutTestController::setViewModeMediaFeature):
1032         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1033         (LayoutTestController::setViewModeMediaFeature):
1034
1035 2010-08-18  Mark Rowe  <mrowe@apple.com>
1036
1037         Reviewed by Sam Weinig.
1038
1039         Make it so the WebKit2 test slave runs the WebKit2 tests
1040
1041         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1042
1043 2010-08-18  Sam Weinig  <sam@webkit.org>
1044
1045         Reviewed by Mark Rowe.
1046
1047         Make run-webkit-tests --webkit-test-runner build DumpRenderTree
1048         in addition to WebKitTestRunner to get the DumpRenderTreeSupport
1049         module and the TestNetscapePlugin.
1050
1051         * Scripts/old-run-webkit-tests:
1052
1053 2010-08-18  Adam Roben  <aroben@apple.com>
1054
1055         Fix hang when saving crash logs on Windows
1056
1057         * Scripts/old-run-webkit-tests:
1058         (setUpWindowsCrashLogSaving):
1059         (END):
1060         Pass -s to regtool so it will write the Auto value as a string instead
1061         of as a number. This was causing a "do you want to debug?" dialog to
1062         appear.
1063
1064 2010-08-17  Victor Wang  <victorw@chromium.org>
1065
1066         Unreviewed. Fixed chromium incremental test json upload.
1067         Quote builder name and test results server in url.
1068
1069         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1070
1071 2010-08-17  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1072
1073         Reviewed by Ariya Hidayat.
1074
1075         [Qt] [Symbian] Consistently use Q_OS_SYMBIAN to guard all Symbian platform dependencies
1076         https://bugs.webkit.org/show_bug.cgi?id=44124
1077
1078         Q_WS_S60 is not defined for Symbian^4 devices as Q_WS_S60 used to guard 
1079         Avkon UI framework dependencies. Use Q_OS_SYMBIAN everywhere to mark
1080         Symbian dependencies.
1081
1082         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1083         (WebCore::DumpRenderTree::open):
1084         * QtTestBrowser/launcherwindow.cpp:
1085         (LauncherWindow::init):
1086         (LauncherWindow::toggleFullScreenMode):
1087         (LauncherWindow::showFPS):
1088         (LauncherWindow::updateFPS):
1089         * QtTestBrowser/launcherwindow.h:
1090         (WindowOptions::WindowOptions):
1091         * QtTestBrowser/mainwindow.cpp:
1092         (MainWindow::buildUI):
1093
1094 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
1095
1096         Reviewed by David Levin.
1097
1098         new-run-webkit-tests: remove --show-sources option
1099
1100         --show-sources is pretty much obsolete with --trace everything, so
1101         I'm removing it.
1102
1103         Also rename a couple of methods in the TestTextDiff class to make their
1104         intended visibility (private) more obvious.
1105
1106         https://bugs.webkit.org/show_bug.cgi?id=44143
1107
1108         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1109         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1110         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1111         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1112         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1113
1114 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
1115
1116         Reviewed by David Levin.
1117
1118         remove --fuzzy-image-diff in new-run-webkit-tests (it doesn't work)
1119
1120         This code bit-rotted at some point more than a year ago, and nobody seems
1121         to miss it. old-run-webkit-tests has a --tolerance flag that new-run-webkit-tests
1122         should support instead, making this flag unnecessary anyway.
1123
1124         https://bugs.webkit.org/show_bug.cgi?id=44141
1125
1126         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1127         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1128         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Removed.
1129
1130 2010-08-17  Victor Wang  <victorw@chromium.org>
1131
1132         Reviewed by Ojan Vafai.
1133
1134         Update json results generator to have incremental json including
1135         results for tests that pass in current run but failed before.
1136
1137         https://bugs.webkit.org/show_bug.cgi?id=44119
1138
1139         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1140         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1141         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1142
1143 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
1144
1145         Reviewed by Eric Seidel.
1146
1147         fix test-webkitpy, add easy way to find a checkout root
1148
1149         test-webkitpy currently doesn't work right if run from someplace other
1150         than the checkout root, and it spews a bunch of debug logging because
1151         the deduplicate_tests tests contaminates the test environment.
1152
1153         This patch cleans up the deduplicate_tests unit tests, and creates
1154         two new methods in scm.py: find_checkout_root() and default_scm(),
1155         both of which use a single algorithm for guessing what checkout root
1156         to use if you aren't explicitly told one from a path.
1157
1158         https://bugs.webkit.org/show_bug.cgi?id=44001
1159
1160         * Scripts/deduplicate-tests:
1161         * Scripts/webkitpy/common/checkout/scm.py:
1162         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1163         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
1164         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1165         * Scripts/webkitpy/layout_tests/port/test.py:
1166         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1167         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1168         * Scripts/webkitpy/tool/main.py:
1169
1170 2010-08-17  Victor Wang  <victorw@chromium.org>
1171
1172         Reviewed by Ojan Vafai.
1173
1174         Add support to the test results server for downloading json that
1175         contains test list only.
1176
1177         This is for json results generator to generate incremental json
1178         results so that it includes results not only for tests failed in
1179         current run, but also tests failed before.
1180
1181         Also set the results type to "N" (no data) instead of "P" (pass)
1182         if test results cannot be found in incremental json file.
1183
1184         https://bugs.webkit.org/show_bug.cgi?id=44117
1185
1186         * TestResultServer/handlers/testfilehandler.py:
1187         * TestResultServer/model/jsonresults.py:
1188         * TestResultServer/model/jsonresults_unittest.py:
1189
1190 2010-08-17  Adam Roben  <aroben@apple.com>
1191
1192         Use the right path style
1193
1194         * Scripts/old-run-webkit-tests:
1195
1196 2010-08-17  Adam Roben  <aroben@apple.com>
1197
1198         Fix typo
1199
1200         * Scripts/old-run-webkit-tests:
1201
1202 2010-08-17  Adam Roben  <aroben@apple.com>
1203
1204         Don't hang when running run-webkit-tests as a non-Administrator on
1205         Vista/7
1206
1207         * Scripts/old-run-webkit-tests:
1208         (setUpWindowsCrashLogSaving): Use regtool to set NTSD as the
1209         post-mortem debugger, rather than using NTSD itself. The latter waits
1210         for user input when it fails to set the registry values; the former
1211         does not.
1212
1213 2010-08-17  Adam Roben  <aroben@apple.com>
1214
1215         Teach run-webkit-tests, DumpRenderTree, and WebKitTestRunner how to
1216         save crash logs on Windows
1217
1218         The crash logs are saved to /tmp/layout-test-results and have names
1219         like CrashLog_02bc_2010-08-17_14-36-20-108.txt.
1220
1221         Unfortunately, crashes in the WebKit2 web process are recorded as
1222         time-outs by run-webkit-tests. Fixing this is covered by
1223         <http://webkit.org/b/44121>.
1224
1225         Fixes <http://webkit.org/b/37859> <rdar://problem/7883560>
1226         DumpRenderTree should save a stack trace and/or dump file when it
1227         crashes
1228
1229         Reviewed by Sam Weinig.
1230
1231         * DumpRenderTree/win/DumpRenderTree.cpp:
1232         (exceptionFilter):
1233         (main):
1234         * WebKitTestRunner/win/TestControllerWin.cpp:
1235         (WTR::exceptionFilter):
1236         (WTR::TestController::platformInitialize):
1237         These changes set up an exception filter that prints #CRASHED to
1238         stderr, then lets the exception propagate normally. This allows
1239         run-webkit-tests to detect when we've crashed even when a post-mortem
1240         debugger attaches to the process.
1241
1242         * Scripts/old-run-webkit-tests:
1243         (top level): Declared some variables used by the crash-log-saving
1244         code.
1245         (openDumpTool): Copy _NT_SYMBOL_PATH into the clean environment so
1246         that the post-mortem debugger has access to it.
1247         (toCygwinPath): Added. This is the opposite of toWindowsPath.
1248         (readFromDumpToolWithTimer): If the dump tool prints #CRASHED to
1249         stderr, consider it a crash.
1250         (setUpWindowsCrashLogSaving): Added. Saves the current post-mortem
1251         debugger, then sets ntsd as the post-mortem debugger. ntsd is
1252         configured to save a crash log and then quit automatically.
1253         (END): Added. Restores the previous post-mortem debugger when the
1254         script exits.
1255
1256 2010-08-17  Victor Wang  <victorw@chromium.org>
1257
1258         Reviewed by ojan@chromium.org.
1259
1260         Update test results server:
1261         1. Normalize test results and times after merging (prune tests where
1262            all runs pass or do not have data, truncate all test items to max
1263            number of builds)
1264         2. times should be int not string.
1265         3. when inserting a new test item, should keep old data regardless
1266            whether or not they have same item type with new one.
1267
1268         https://bugs.webkit.org/show_bug.cgi?id=43861
1269
1270         * TestResultServer/model/jsonresults.py:
1271         * TestResultServer/model/jsonresults_unittest.py:
1272
1273 2010-08-16  Sam Weinig  <sam@webkit.org>
1274
1275         Reviewed by Mark Rowe.
1276
1277         Add WebKit2 Mac tester to buildbot.
1278
1279         * BuildSlaveSupport/build.webkit.org-config/config.json:
1280         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1281
1282 2010-08-16  Paul Sawaya  <psawaya@apple.com>
1283
1284         Reviewed by Chris Marrin.
1285
1286         Added shader validation via ANGLE
1287         https://bugs.webkit.org/show_bug.cgi?id=42405
1288
1289         Added ANGLE to webkit build
1290
1291         * Scripts/build-webkit:
1292
1293 2010-08-16  Kevin Ollivier  <kevino@theolliviers.com>
1294
1295         [wx] Build fix, do not build WebCore as a convenience library as this leads to
1296         errors in the Win build w/export symbols and causes problems with DOM bindings
1297         debugging in gdb.
1298
1299         * DumpRenderTree/wscript:
1300         * Scripts/build-webkit:
1301         * wx/browser/wscript:
1302         * wx/build/settings.py:
1303         * wx/build/waf_extensions.py:
1304
1305 2010-08-16  Dan Bernstein  <mitz@apple.com>
1306
1307         Build fix.
1308
1309         * WebKitTestRunner/TestController.cpp:
1310         (WTR::createOtherPage): Initialize the contentsSizeChanged member.
1311         (WTR::TestController::initialize): Ditto.
1312
1313 2010-08-16  Balazs Kelemen  <kb@inf.u-szeged.hu>
1314
1315         Reviewed by Kenneth Rohde Christiansen.
1316
1317         Handle content size change in WebKit2
1318         Re-landing after fix.
1319
1320         https://bugs.webkit.org/show_bug.cgi?id=43198
1321
1322         * MiniBrowser/mac/BrowserWindowController.m:
1323         (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
1324         * MiniBrowser/win/BrowserView.cpp:
1325         (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.
1326
1327 2010-08-16  Sheriff Bot  <webkit.review.bot@gmail.com>
1328
1329         Unreviewed, rolling out r65419.
1330         http://trac.webkit.org/changeset/65419
1331         https://bugs.webkit.org/show_bug.cgi?id=44053
1332
1333         Broke the Windows build (Requested by bbandix on #webkit).
1334
1335         * MiniBrowser/mac/BrowserWindowController.m:
1336         (-[BrowserWindowController awakeFromNib]):
1337         * MiniBrowser/win/BrowserView.cpp:
1338         (BrowserView::create):
1339
1340 2010-08-16  Balazs Kelemen  <kb@inf.u-szeged.hu>
1341
1342         Reviewed by Kenneth Rohde Christiansen.
1343
1344         Handle content size change in WebKit2
1345
1346         https://bugs.webkit.org/show_bug.cgi?id=43198
1347
1348         * MiniBrowser/mac/BrowserWindowController.m:
1349         (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
1350         * MiniBrowser/win/BrowserView.cpp:
1351         (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.
1352
1353 2010-08-16  Ariya Hidayat  <ariya@sencha.com>
1354
1355         Add my new email address to committers.py.
1356
1357         * Scripts/webkitpy/common/config/committers.py:
1358
1359 2010-08-16  Zoltan Horvath  <zoltan@webkit.org>
1360
1361         Add my old e-mail addresses to committers.py.
1362
1363         * Scripts/webkitpy/common/config/committers.py:
1364
1365 2010-08-15  Jon Honeycutt  <jhoneycutt@apple.com>
1366
1367         WebEditorClient::didBeginEditing is never called in WebKit2
1368         https://bugs.webkit.org/show_bug.cgi?id=42939
1369
1370         Reviewed by Sam Weinig.
1371
1372         * WebKitTestRunner/PlatformWebView.h:
1373         Declare focus().
1374
1375         * WebKitTestRunner/TestController.cpp:
1376         (WTR::TestController::resetStateToConsistentValues):
1377         Focus the PlatformWebView.
1378
1379         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1380         (WTR::PlatformWebView::focus):
1381         Stubbed.
1382
1383         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1384         (WTR::PlatformWebView::focus):
1385         Focus the view.
1386
1387 2010-08-15  Jon Honeycutt  <jhoneycutt@apple.com>
1388
1389         run-webkit-tests should not strip editing callbacks when using
1390         WebKitTestRunner on Windows
1391         https://bugs.webkit.org/show_bug.cgi?id=44000
1392
1393         Reviewed by Mark Rowe.
1394
1395         * Scripts/old-run-webkit-tests:
1396         Leave $stripEditingCallbacks undefined until we look for command-line
1397         arguments. If using WebKit2, set it to 0 if not explicity set on the
1398         command line. Later, set it to isCygwin() to match old behavior if it is
1399         not yet defined.
1400
1401 2010-08-15  Kevin Ollivier  <kevino@theolliviers.com>
1402
1403         [wx] Build fix, remove define always set to the correct value by wtf/Platform.h.
1404
1405         * wx/build/settings.py:
1406
1407 2010-08-14  Martin Robinson  <mrobinson@igalia.com>
1408
1409         Reviewed by Kenneth Rohde Christiansen.
1410
1411         [GTK] autogen.sh not executed if build-webkit options change
1412         https://bugs.webkit.org/show_bug.cgi?id=42266
1413
1414         Rerun autogen.sh in situations where the arguments to build-webkit have
1415         changed since the previous build. This will fix some issues on the bots
1416         where the build does not notice changes to default build-webkit arguments.
1417
1418         * Scripts/webkitdirs.pm: Add special logic for detecting changes to build-webkit arguments.
1419
1420 2010-08-14  Eric Seidel  <eric@webkit.org>
1421
1422         Unreviewed.  Another fix to support python 2.3.
1423
1424         Add support for MathML entities
1425         https://bugs.webkit.org/show_bug.cgi?id=43949
1426
1427         * Scripts/webkitpy/thirdparty/simplejson/decoder.py:
1428          - It looks like our simplejson is version 1.7.3 which
1429            should be python 2.3 compatible.  But someone modified
1430            our copy slightly from the original source.
1431            I've removed the relative import in hopes this fixes
1432            the problem.
1433
1434 2010-08-13  Eric Seidel  <eric@webkit.org>
1435
1436         Unreviewed.  Build fix only.
1437
1438         Add support for MathML entities
1439         https://bugs.webkit.org/show_bug.cgi?id=43949
1440
1441         * Scripts/create-html-entity-table:
1442          - Hack sys.path to avoid executing 2.5 dependent python
1443            on systems (like chromium-win and Tiger) which do not have 2.5 python.
1444
1445 2010-08-13  Adam Barth  <abarth@webkit.org>
1446
1447         Reviewed by Eric Seidel.
1448
1449         Rename some concepts in HTML entity search to be more self-documenting
1450         https://bugs.webkit.org/show_bug.cgi?id=44004
1451
1452         Reflect name change in generator script.
1453
1454         * Scripts/create-html-entity-table:
1455
1456 2010-08-12  Adam Barth  <abarth@webkit.org>
1457
1458         Reviewed by Eric Seidel.
1459
1460         Add support for MathML entities
1461         https://bugs.webkit.org/show_bug.cgi?id=43949
1462
1463         A script for generating the C++ state data structure describing all the
1464         entities from a JSON description.
1465
1466         * Scripts/create-html-entity-table: Added.
1467
1468 2010-08-13  Dirk Pranke  <dpranke@chromium.org>
1469
1470         Reviewed by Eric Seidel.
1471
1472         Rewrite new-run-webkit-test's wait_for_threads_to_finish loop to
1473         check for exceptions on all threads, not just the first thread.
1474         
1475         This change also changes the logging behavior for wedged threads
1476         to only dump the stacks of threads that are actually wedged.
1477
1478         Refactor the thread classes in the dump_render_tree_thread module
1479         to make the contract between TestRunner and TestShellThread clearer.
1480
1481         Added a bunch of unit tests.
1482         https://bugs.webkit.org/show_bug.cgi?id=38561
1483
1484         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1485         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1486         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1487
1488 2010-08-13  Kenichi Ishibashi  <bashi@google.com>
1489
1490         Reviewed by Shinichiro Hamaji.
1491
1492         Add test_expectations.txt syntax checker to check-webkit-style.
1493         https://bugs.webkit.org/show_bug.cgi?id=43899
1494
1495         Just utilizing layout_tests/layout_package/test_expectations.py for checking
1496         the syntax of test_expectations.txt.
1497         This change also moves tab checking class from style/checkers/text.py to
1498         style/checkers/common.py for sharing code.
1499
1500         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1501         * Scripts/webkitpy/style/checker.py:
1502         * Scripts/webkitpy/style/checkers/common.py:
1503         * Scripts/webkitpy/style/checkers/common_unittest.py:
1504         * Scripts/webkitpy/style/checkers/test_expectations.py: Added.
1505         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Added.
1506         * Scripts/webkitpy/style/checkers/text.py:
1507         * Scripts/webkitpy/style_references.py:
1508
1509 2010-08-12  Jon Honeycutt  <jhoneycutt@apple.com>
1510
1511         WebKitTestRunner does not correctly resize WebView for W3C SVG tests
1512         https://bugs.webkit.org/show_bug.cgi?id=43945
1513
1514         Reviewed by Sam Weinig.
1515
1516         * WebKitTestRunner/TestInvocation.cpp:
1517         (WTR::sizeWebViewForCurrentTest):
1518         Allow for a Windows-style path.
1519
1520         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1521         (WTR::PlatformWebView::resizeTo):
1522         Call SetWindowPos to resize the view window.
1523
1524 2010-08-12  David Levin  <levin@chromium.org>
1525
1526         Build break fix.
1527
1528         * WebKitTestRunner/TestController.cpp:
1529         (WTR::TestController::resetStateToConsistentValues): Removed usage
1530         of a variable that doesn't exist in the class.
1531
1532 2010-08-12  Jon Honeycutt  <jhoneycutt@apple.com>
1533
1534         WebKitTestRunner needs to run tests without using native controls
1535         https://bugs.webkit.org/show_bug.cgi?id=43772
1536
1537         Reviewed by Sam Weinig.
1538
1539         * WebKitTestRunner/TestController.cpp:
1540         (WTR::TestController::initialize):
1541         Call platformInitializeContext().
1542
1543         * WebKitTestRunner/TestController.h:
1544         Declare platformInitializeContext().
1545
1546         * WebKitTestRunner/mac/TestControllerMac.mm:
1547         (WTR::TestController::platformInitializeContext):
1548         Stubbed.
1549
1550         * WebKitTestRunner/win/TestControllerWin.cpp:
1551         (WTR::TestController::platformInitializeContext):
1552         Call WKContextSetShouldPaintNativeControls() to disable native control
1553         drawing.
1554
1555 2010-08-12  Sam Weinig  <sam@webkit.org>
1556
1557         Reviewed by Alexey Proskuryakov.
1558
1559         WebKitTestRunner should be more aggressive about ensuring consistent state between tests
1560         https://bugs.webkit.org/show_bug.cgi?id=43653
1561
1562         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1563         (WTR::InjectedBundle::InjectedBundle):
1564         (WTR::InjectedBundle::didReceiveMessage):
1565         (WTR::InjectedBundle::beginTesting):
1566         (WTR::InjectedBundle::done):
1567         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1568         (WTR::InjectedBundle::isTestRunning):
1569         (WTR::InjectedBundle::):
1570         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1571         (WTR::InjectedBundlePage::stopLoading):
1572         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1573         (WTR::InjectedBundlePage::dump):
1574         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1575         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1576         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
1577         (WTR::InjectedBundlePage::didClearWindowForFrame):
1578         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
1579         (WTR::InjectedBundlePage::willAddMessageToConsole):
1580         (WTR::InjectedBundlePage::willSetStatusbarText):
1581         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
1582         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
1583         (WTR::InjectedBundlePage::shouldBeginEditing):
1584         (WTR::InjectedBundlePage::shouldEndEditing):
1585         (WTR::InjectedBundlePage::shouldInsertNode):
1586         (WTR::InjectedBundlePage::shouldInsertText):
1587         (WTR::InjectedBundlePage::shouldDeleteRange):
1588         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
1589         (WTR::InjectedBundlePage::shouldApplyStyle):
1590         (WTR::InjectedBundlePage::didBeginEditing):
1591         (WTR::InjectedBundlePage::didEndEditing):
1592         (WTR::InjectedBundlePage::didChange):
1593         (WTR::InjectedBundlePage::didChangeSelection):
1594         Don't do any work if we are not currently running a test.
1595
1596         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1597         * WebKitTestRunner/StringFunctions.h:
1598         (WTR::toCF):
1599         Add conversion function for WKURLRef -> CFURLRef
1600
1601         * WebKitTestRunner/TestController.cpp:
1602         (WTR::TestController::TestController):
1603         (WTR::TestController::initialize):
1604         (WTR::TestController::resetStateToConsistentValues):
1605         (WTR::TestController::runTest):
1606         (WTR::TestController::didFinishLoadForFrame):
1607         * WebKitTestRunner/TestController.h:
1608         (WTR::TestController::):
1609         * WebKitTestRunner/TestInvocation.cpp:
1610         (WTR::TestInvocation::invoke):
1611         * WebKitTestRunner/TestInvocation.h:
1612         Move resetting code to TestController.
1613
1614         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1615         * WebKitTestRunner/mac/TestControllerMac.mm:
1616         (WTR::TestController::runUntil):
1617         * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
1618         * WebKitTestRunner/win/TestControllerWin.cpp:
1619         (WTR::TestController::runUntil):
1620         * WebKitTestRunner/win/TestInvocationWin.cpp: Removed.
1621         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1622         Move runUntil to TestController.
1623
1624 2010-08-12  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
1625
1626         Unreviewed.
1627
1628         Adding myself to the committers list.
1629
1630         * Scripts/webkitpy/common/config/committers.py:
1631
1632 2010-08-12  Hayato Ito  <hayato@chromium.org>
1633
1634         Reviewed by Tony Chang.
1635
1636         Merge pretty printers for gdb.
1637         https://bugs.webkit.org/show_bug.cgi?id=43850
1638
1639         We need to update webcore.py because basic string classes have moved to WTF from WebCore.
1640         It is good timing to merge webcore.py and wtf.py and name it 'webkit.py'.
1641         webcore.py is left for backward compatibility.
1642
1643         * gdb/webcore.py:
1644         * gdb/webkit.py: Added.
1645         * gdb/wtf.py: Removed.
1646
1647 2010-08-11  Tony Chang  <tony@chromium.org>
1648
1649         Reviewed by David Levin.
1650
1651         [chromium] add google-chrome layout test result directories
1652         https://bugs.webkit.org/show_bug.cgi?id=43889
1653
1654         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1655         * Scripts/webkitpy/layout_tests/port/factory.py:
1656         * Scripts/webkitpy/layout_tests/port/google_chrome.py: Added.
1657         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1658
1659 2010-08-11  Kent Tamura  <tkent@chromium.org>
1660
1661         Reviewed by Dimitri Glazkov.
1662
1663         [DRT/Chromium] Disable accelerated compositing
1664         https://bugs.webkit.org/show_bug.cgi?id=43894
1665
1666         Disable accelerated compositing because DRT is not ready for
1667         it. This change fixes hundreds of test crashes on Windows and
1668         Linux.
1669
1670         * DumpRenderTree/chromium/TestShell.cpp:
1671         (TestShell::resetWebSettings):
1672
1673 2010-08-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1674
1675         Unreviewed. Adding my Collabora personality to the list.
1676
1677         * Scripts/webkitpy/common/config/committers.py:
1678
1679 2010-08-11  Martin Robinson  <mrobinson@igalia.com>
1680
1681         Adding myself as a reviewer.
1682
1683         * Scripts/webkitpy/common/config/committers.py:
1684
1685 2010-08-11  Daniel Bates  <dbates@rim.com>
1686
1687         Reviewed by Darin Adler.
1688
1689         Perl warnings when running commit-log-editor
1690         https://bugs.webkit.org/show_bug.cgi?id=43856
1691
1692         Fixes Perl warnings introduced by the patch for Bug #40548.
1693
1694         Perl doesn't have symbolic names for True/False. Instead, we
1695         should use boolean values. Moreover, the variable installedEditorApplication
1696         is not be used and should be renamed builtEditorApplication so that it
1697         uses the existing machinery to set the commit log editor application.
1698
1699         * Scripts/commit-log-editor:
1700
1701 2010-08-11  Adam Barth  <abarth@webkit.org>
1702
1703         Reviewed by Eric Seidel.
1704
1705         Trying waiting for httpd lock in the EWS
1706         https://bugs.webkit.org/show_bug.cgi?id=43833
1707
1708         If this works, we can probably run the tests on the mac-ews, which
1709         would be very exciting.  :)
1710
1711         * Scripts/webkitpy/tool/steps/runtests.py:
1712
1713 2010-08-11  Marcus Bulach  <bulach@chromium.org>
1714
1715         Reviewed by Eric Seidel.
1716
1717         Check in a script to list redundant test outputs.
1718         https://bugs.webkit.org/show_bug.cgi?id=37630
1719
1720         If e.g. platform/mac-leopard is missing an expected test output, we
1721         fall back on platform/mac.  This means it's possible to grow redundant
1722         test outputs, where we have the same expected data in both a platform
1723         directory and another platform it falls back on.
1724         (original patch by Evan Marting <evan@chromium.org> https://bugs.webkit.org/attachment.cgi?id=53398)
1725
1726         * Scripts/deduplicate-tests: Added.
1727         * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Added.
1728         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: Added.
1729
1730 2010-08-11  Antonio Gomes  <tonikitoo@webkit.org>
1731
1732         Reviewed by Ariya Hidayat.
1733
1734         [Qt] QtTestBrowser: after switching between QWebView and QGraphicsWebView, rotation actions get broken
1735         https://bugs.webkit.org/show_bug.cgi?id=43853
1736
1737         LauncherWindow::createChrome is connecting menu itens to WebViewGraphicsBased's slots directly.
1738         It behaviors badly when user launches the QtTestBrowser in QWebView mode, since then switching to
1739         QGraphicsWebView mode, createChrome is not called again, and menu items end up not getting connected
1740         to slots at all.
1741
1742         * QtTestBrowser/launcherwindow.cpp:
1743         (LauncherWindow::createChrome):
1744         (LauncherWindow::animatedFlip):
1745         (LauncherWindow::animatedYFlip):
1746         * QtTestBrowser/launcherwindow.h:
1747
1748 2010-08-11  Antonio Gomes  <tonikitoo@webkit.org>
1749
1750         Reviewed by Simon Hausmann.
1751
1752         [Qt] QtTestBrowser: switching between QWebView and QGraphicsWebView modes is broken
1753         https://bugs.webkit.org/show_bug.cgi?id=43851
1754
1755         All window options data (including the bool holding if the view is either QWebView or
1756         QGraphicsWebView based) is stored in m_windowOptions, a class member of LauncherWindow.
1757         When toggle the view from QWebView to QGraphicsWebView based (and vice-versa), we were
1758         not updating LauncherWindow::WindowOptions::m_useGraphicsView bit, and then things were
1759         getting broken.
1760
1761         Patch addresses this issue.
1762
1763         * QtTestBrowser/launcherwindow.cpp:
1764         (LauncherWindow::createChrome):
1765         (LauncherWindow::toggleWebView):
1766         (LauncherWindow::toggleAcceleratedCompositing):
1767
1768 2010-08-10  Antonio Gomes  <tonikitoo@webkit.org>
1769
1770         Reviewed by Ariya Hidayat.
1771
1772         [Qt] QtTestBrowser: lazy instantiate "YRotation" state machine and related objects
1773         https://bugs.webkit.org/show_bug.cgi?id=43831
1774
1775         Only instantiate QStateMachine and friends associated to the YRotation action on demand.
1776
1777         * QtTestBrowser/webview.cpp:
1778         (WebViewGraphicsBased::WebViewGraphicsBased):
1779         (WebViewGraphicsBased::animatedYFlip):
1780
1781 2010-08-11  Darin Adler  <darin@apple.com>
1782
1783         Reviewed by John Sullivan.
1784
1785         Improved editor options for prepare-ChangeLog and commit-log-editor
1786         https://bugs.webkit.org/show_bug.cgi?id=40548
1787
1788         * Scripts/commit-log-editor: Split editor strings on spaces so EDITOR
1789         values like "xed --launch --wait" work properly.
1790
1791         * Scripts/prepare-ChangeLog: Added a new CHANGE_LOG_EDITOR so we can
1792         use a command line tool with the $openChangeLogs feature.
1793
1794 2010-08-11  Yury Semikhatsky  <yurys@chromium.org>
1795
1796         Reviewed by Pavel Feldman.
1797
1798         Web Inspector: remove InjectDispatch.js
1799         https://bugs.webkit.org/show_bug.cgi?id=43835
1800
1801         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1802         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1803
1804 2010-08-10  Dirk Pranke  <dpranke@chromium.org>
1805
1806         Reviewed by Eric Seidel.
1807
1808         webkit-patch should refuse to run under Win32 Python
1809         https://bugs.webkit.org/show_bug.cgi?id=40962
1810
1811         Given that there are lots of places in webkit-patch's code that
1812         assume unix-style filenames (forward slashes), webkit-patch fails
1813         with weird file-not-found errors when run under a native windows
1814         Python. It would be nice if we just trapped this and errored out
1815         at the beginning, rather than producing unpredictable errors.
1816
1817         * Scripts/webkit-patch:
1818
1819 2010-08-10  Kent Tamura  <tkent@chromium.org>
1820
1821         Unreviewed, build fix.
1822         
1823         Chromium build fix for r65107.
1824
1825         * DumpRenderTree/chromium/LayoutTestController.cpp:
1826         (LayoutTestController::suspendAnimations):
1827         (LayoutTestController::resumeAnimations):
1828
1829 2010-08-10  Sergio Villar Senin  <svillar@igalia.com>
1830
1831         Reviewed by Xan Lopez.
1832
1833         [GTK] http/tests/media/video-cookie.html fails
1834         https://bugs.webkit.org/show_bug.cgi?id=42240
1835
1836         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1837         (LayoutTestController::setAlwaysAcceptCookies): create the
1838         SoupCookieJar if it does not exist. Otherwise the accept policy
1839         won't be set.
1840
1841 2010-08-10  Chris Marrin  <cmarrin@apple.com>
1842
1843         Reviewed by Oliver Hunt.
1844
1845         Add suspendAnimations/resumeAnimation API to DRT
1846         https://bugs.webkit.org/show_bug.cgi?id=43733
1847         
1848         Adds suspendAnimations() and resumeAnimations() to LayoutTestController.
1849         Calls functions with the same names on AnimationController for the 
1850         mainFrame.
1851
1852         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1853         * DumpRenderTree/LayoutTestController.cpp:
1854         (suspendAnimationsCallback):
1855         (resumeAnimationsCallback):
1856         (LayoutTestController::staticFunctions):
1857         * DumpRenderTree/LayoutTestController.h:
1858         * DumpRenderTree/chromium/LayoutTestController.cpp:
1859         (LayoutTestController::LayoutTestController):
1860         (LayoutTestController::suspendAnimations):
1861         (LayoutTestController::resumeAnimations):
1862         * DumpRenderTree/chromium/LayoutTestController.h:
1863         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1864         (LayoutTestController::suspendAnimations):
1865         (LayoutTestController::resumeAnimations):
1866         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1867         (LayoutTestController::suspendAnimations):
1868         (LayoutTestController::resumeAnimations):
1869         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1870         (LayoutTestController::suspendAnimations):
1871         (LayoutTestController::resumeAnimations):
1872         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1873         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1874         (LayoutTestController::suspendAnimations):
1875         (LayoutTestController::resumeAnimations):
1876         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1877         (LayoutTestController::suspendAnimations):
1878         (LayoutTestController::resumeAnimations):
1879
1880 2010-08-10  Dimitri Glazkov  <dglazkov@chromium.org>
1881
1882         Reviewed by Ojan Vafai.
1883
1884         [Chromium/DRT] Enable saving layout test results.
1885         https://bugs.webkit.org/show_bug.cgi?id=43796
1886
1887         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added more
1888             parameters to the new-run-webkit-tests, including the name
1889             of the test results server.
1890
1891 2010-08-10  Jian Li  <jianli@chromium.org>
1892
1893         More chromium build fix.
1894
1895         * DumpRenderTree/chromium/MockSpellCheck.cpp:
1896         (MockSpellCheck::spellCheckWord):
1897         (MockSpellCheck::initializeIfNeeded):
1898         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1899         (NotificationPresenter::grantPermission):
1900         (NotificationPresenter::show):
1901         (NotificationPresenter::checkPermission):
1902
1903 2010-08-10  Jian Li  <jianli@chromium.org>
1904
1905         Chromium build fix.
1906
1907         * DumpRenderTree/chromium/MockSpellCheck.cpp:
1908         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1909
1910 2010-08-10  Victor Wang  <victorw@chromium.org>
1911
1912         Reviewed by Ojan Vafai.
1913
1914         Update test results server merge logic so the aggregated
1915         results and times are updated for tests that are
1916         in aggragated json but not in incremental json.
1917
1918         Also update unittest to test this case.
1919
1920         https://bugs.webkit.org/show_bug.cgi?id=43769
1921
1922         * TestResultServer/model/jsonresults.py:
1923         * TestResultServer/model/jsonresults_unittest.py:
1924
1925 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
1926
1927         Reviewed by Ariya Hidayat.
1928
1929         [Qt] QtTestBrowser: proper set scene rect
1930
1931         When resizesToContents is ON scene's rect is set to the boundary of
1932         the mainFrame. However, navigating to other web page should keep resizing
1933         scene's rect according to the new document loaded. Patch addresses this issue.
1934
1935         Now resizesToContents and scrolling properly work on QtTestBrowser.
1936
1937         * QtTestBrowser/webview.cpp:
1938         (WebViewGraphicsBased::setPage):
1939         (WebViewGraphicsBased::contentsSizeChanged):
1940         (WebViewGraphicsBased::setResizesToContents):
1941         (WebViewGraphicsBased::resizeEvent):
1942         * QtTestBrowser/webview.h:
1943
1944 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
1945
1946         Reviewed by Ariya Hidayat.
1947
1948         [Qt] QtTestBrowser: Clean up LauncherWindow code.
1949
1950         * QtTestBrowser/launcherwindow.cpp:
1951         (LauncherWindow::LauncherWindow): Moves applyPrefs methods call from the constructor to init().
1952         (LauncherWindow::init): Fixed comments.
1953         (LauncherWindow::applyPrefs): Move the method around.
1954         (LauncherWindow::createChrome): Move more code of this method around, for grouping, and fixing up comments.
1955
1956 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
1957
1958         Reviewed by Ariya Hidayat.
1959
1960         [Qt] QtTestBrowser: make reset-zooming to animate when tiled backing store is on.
1961
1962         It gets control+0 the same visual effect as control++ or control-.
1963
1964         * QtTestBrowser/launcherwindow.cpp:
1965         (LauncherWindow::toggleZoomTextOnly):
1966
1967 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
1968
1969         Reviewed by Ariya Hidayat.
1970
1971         [Qt] QtTestBrowser:: make m_zoomLevels a static member.
1972
1973         Not all instances of LauncherWindow need its own m_zoomLevel.
1974
1975         * QtTestBrowser/launcherwindow.cpp:
1976         * QtTestBrowser/launcherwindow.h:
1977
1978 2010-08-09  Sam Weinig  <sam@webkit.org>
1979
1980         Reviewed by Geoffrey Garen.
1981
1982         Add zoom support for injected bundle
1983         https://bugs.webkit.org/show_bug.cgi?id=43759
1984
1985         Use zoom factor SPI to implement zoom related eventSender functions.
1986
1987         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1988         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1989         (WTR::EventSendingController::textZoomIn):
1990         (WTR::EventSendingController::textZoomOut):
1991         (WTR::EventSendingController::zoomPageIn):
1992         (WTR::EventSendingController::zoomPageOut):
1993         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1994         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1995         (WTR::InjectedBundlePage::reset): Reset zoom mode and level for each test.
1996
1997 2010-08-09  Gavin Barraclough  <barraclough@apple.com>
1998
1999         Speculative chromium build fix III.
2000
2001         * DumpRenderTree/chromium/MockSpellCheck.h:
2002         * DumpRenderTree/chromium/NotificationPresenter.h:
2003         * DumpRenderTree/chromium/WebViewHost.h:
2004         (WebViewHost::addClearHeader):
2005         (WebViewHost::clearHeaders):
2006
2007 2010-08-09  Ojan Vafai  <ojan@chromium.org>
2008
2009         Reviewed by Tony Chang.
2010
2011         increase the number of test results that we save
2012         https://bugs.webkit.org/show_bug.cgi?id=43763
2013
2014         Now that we do incremental uploads, we can increase the number of
2015         results that we save for http://test-results.appspot.com/dashboards/flakiness_dashboard.html.
2016
2017         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2018
2019 2010-08-09  Evan Martin  <evan@chromium.org>
2020
2021         Reviewed by Tony Chang.
2022
2023         [chromium] DRT error print statement incorrectly tries to print a FILE*
2024         https://bugs.webkit.org/show_bug.cgi?id=43747
2025
2026         * DumpRenderTree/chromium/ImageDiff.cpp:
2027         (writeFile): pass the correct pointer.
2028
2029 2010-08-09  Victor Wang  <victorw@chromium.org>
2030
2031         Reviewed by Ojan Vafai.
2032
2033         Upload incremental test results json to server by default.
2034
2035         https://bugs.webkit.org/show_bug.cgi?id=43743
2036
2037         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2038
2039 2010-08-09  Eric Seidel  <eric@webkit.org>
2040
2041         Reviewed by Adam Barth.
2042
2043         EWS bots wait 2 minutes between patches
2044         https://bugs.webkit.org/show_bug.cgi?id=43731
2045
2046         * Scripts/webkitpy/tool/bot/queueengine.py:
2047          - Don't sleep after failures.  This was a hold-over from
2048            an earlier design.
2049         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2050          - EWS bots were not properly reporting true/false from process_work_item.
2051            They were always returning None, thus false, thus always logging
2052            as a failure and sleeping 2 minutes after each patch.
2053
2054 2010-08-09  Sam Weinig  <sam@webkit.org>
2055
2056         Reviewed by Anders Carlsson.
2057
2058         Stub out EventSender for WebKitTestRunner
2059         https://bugs.webkit.org/show_bug.cgi?id=43703
2060
2061         * WebKitTestRunner/DerivedSources.make:
2062         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2063         Add ability to pass javascript arguments to the wrapped object.
2064
2065         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added.
2066         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: Added.
2067         (WTR::EventSendingController::create):
2068         (WTR::EventSendingController::EventSendingController):
2069         (WTR::EventSendingController::~EventSendingController):
2070         (WTR::EventSendingController::wrapperClass):
2071         (WTR::setExceptionForString):
2072         (WTR::EventSendingController::mouseDown):
2073         (WTR::EventSendingController::mouseUp):
2074         (WTR::EventSendingController::mouseMoveTo):
2075         (WTR::EventSendingController::keyDown):
2076         (WTR::EventSendingController::contextClick):
2077         (WTR::EventSendingController::leapForward):
2078         (WTR::EventSendingController::textZoomIn):
2079         (WTR::EventSendingController::textZoomOut):
2080         (WTR::EventSendingController::zoomPageIn):
2081         (WTR::EventSendingController::zoomPageOut):
2082         (WTR::EventSendingController::makeWindowObject):
2083         * WebKitTestRunner/InjectedBundle/EventSendingController.h: Added.
2084         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2085         (WTR::InjectedBundle::reset):
2086         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2087         (WTR::InjectedBundle::eventSendingController):
2088         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2089         (WTR::InjectedBundlePage::didClearWindowForFrame):
2090         Add stubbed out EventSenderController.
2091
2092         * WebKitTestRunner/InjectedBundle/GCController.h:
2093         Remove incorrect comment.
2094
2095         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2096         * WebKitTestRunner/win/InjectedBundle.vcproj:
2097         Add new files.
2098
2099 2010-08-08  Kent Tamura  <tkent@chromium.org>
2100
2101         Unreviewed, trivial fix.
2102
2103         Fix "WindowsError: [Error 32] The process cannot access the file
2104         because it is being used by another process" introduced by r64959.
2105
2106         * BuildSlaveSupport/test-result-archive:
2107
2108 2010-08-08  Kent Tamura  <tkent@chromium.org>
2109
2110         Reviewed by Tony Chang.
2111
2112         Chromium buildbot: Avoid "zip" command dependency
2113         https://bugs.webkit.org/show_bug.cgi?id=43470
2114
2115         * BuildSlaveSupport/test-result-archive:
2116          For Chromium port, creates a zip archive with zipfile package of Python
2117          instead of external "zip" command. We'd like to avoid additional
2118          command installation.
2119
2120 2010-08-08  Jon Honeycutt  <jhoneycutt@apple.com>
2121
2122         WebKitTestRunner should add the QuickTime dir to the PATH environment
2123         variable
2124         https://bugs.webkit.org/show_bug.cgi?id=43686
2125
2126         Reviewed by Dan Bernstein.
2127
2128         * WebKitTestRunner/win/TestControllerWin.cpp:
2129         (WTR::addQTDirToPATH):
2130         Copied from DRT.
2131         (WTR::TestController::platformInitialize):
2132         Call addQTDirToPath().
2133         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2134         Link to shlwapi.lib for SHGetValue.
2135
2136 2010-08-07  Sam Weinig  <sam@webkit.org>
2137
2138         Reviewed by Maciej Stachowiak.
2139
2140         WebKitTestRunner needs layoutTestController.dumpTitleChanges
2141         <rdar://problem/8213861>
2142         https://bugs.webkit.org/show_bug.cgi?id=42683
2143
2144         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2145         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2146         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
2147         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
2148         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2149         (WTR::LayoutTestController::LayoutTestController):
2150         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2151         (WTR::LayoutTestController::dumpTitleChanges):
2152         (WTR::LayoutTestController::shouldDumpTitleChanges):
2153
2154 2010-08-07  Sam Weinig  <sam@webkit.org>
2155
2156         Reviewed by Anders Carlsson.
2157
2158         WebKitTestRunner needs to print onunload handler information
2159         <rdar://problem/8213831>
2160         https://bugs.webkit.org/show_bug.cgi?id=42703
2161
2162         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2163         (WTR::operator<<):
2164         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
2165
2166 2010-08-07  Sam Weinig  <sam@webkit.org>
2167
2168         Reviewed by Anders Carlsson.
2169
2170         Add additional loader client functions need to complete WebKitTestRunner
2171         https://bugs.webkit.org/show_bug.cgi?id=43684
2172
2173         Remove unnecessary and jarring underscores as well.
2174
2175         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2176         (didClearWindowObjectForFrame):
2177         (didCreatePage):
2178         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2179         (WTR::InjectedBundlePage::InjectedBundlePage):
2180         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
2181         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
2182         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
2183         (WTR::InjectedBundlePage::didCommitLoadForFrame):
2184         (WTR::InjectedBundlePage::didFinishLoadForFrame):
2185         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
2186         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
2187         (WTR::InjectedBundlePage::didClearWindowForFrame):
2188         (WTR::InjectedBundlePage::didCancelClientRedirectForFrame):
2189         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
2190         (WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
2191         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
2192         (WTR::InjectedBundlePage::didHandleOnloadEventsForFrame):
2193         (WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
2194         (WTR::InjectedBundlePage::didRunInsecureContentForFrame):
2195         (WTR::InjectedBundlePage::willAddMessageToConsole):
2196         (WTR::InjectedBundlePage::willSetStatusbarText):
2197         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
2198         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
2199         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
2200         (WTR::InjectedBundlePage::shouldBeginEditing):
2201         (WTR::InjectedBundlePage::shouldEndEditing):
2202         (WTR::InjectedBundlePage::shouldInsertNode):
2203         (WTR::InjectedBundlePage::shouldInsertText):
2204         (WTR::InjectedBundlePage::shouldDeleteRange):
2205         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
2206         (WTR::InjectedBundlePage::shouldApplyStyle):
2207         (WTR::InjectedBundlePage::didBeginEditing):
2208         (WTR::InjectedBundlePage::didEndEditing):
2209         (WTR::InjectedBundlePage::didChange):
2210         (WTR::InjectedBundlePage::didChangeSelection):
2211         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2212
2213 2010-08-07  Dan Bernstein  <mitz@apple.com>
2214
2215         Build fix.
2216
2217         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Made the references
2218         to JSGCController.{cpp,h} relative to the build root.
2219
2220 2010-08-07  Sam Weinig  <sam@webkit.org>
2221
2222         Reviewed by Anders Carlsson.
2223
2224         WebKitTestRunner needs GCController
2225         <rdar://problem/8213834>
2226         https://bugs.webkit.org/show_bug.cgi?id=42701
2227
2228         * WebKitTestRunner/DerivedSources.make:
2229         * WebKitTestRunner/InjectedBundle/Bindings/GCController.idl: Added.
2230         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h:
2231         (WTR::setProperty):
2232         * WebKitTestRunner/InjectedBundle/GCController.cpp: Added.
2233         (WTR::GCController::create):
2234         (WTR::GCController::GCController):
2235         (WTR::GCController::~GCController):
2236         (WTR::GCController::wrapperClass):
2237         (WTR::GCController::collect):
2238         (WTR::GCController::collectOnAlternateThread):
2239         (WTR::GCController::getJSObjectCount):
2240         (WTR::GCController::makeWindowObject):
2241         * WebKitTestRunner/InjectedBundle/GCController.h: Added.
2242         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2243         (WTR::InjectedBundle::reset):
2244         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2245         (WTR::InjectedBundle::bundle):
2246         (WTR::InjectedBundle::gcController):
2247         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2248         (WTR::InjectedBundlePage::didClearWindowForFrame):
2249         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2250         (WTR::LayoutTestController::keepWebHistory):
2251         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2252         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2253         * WebKitTestRunner/win/InjectedBundle.vcproj:
2254
2255 2010-08-05  Jon Honeycutt  <jhoneycutt@apple.com>
2256
2257         WebKitTestRunner needs to be able to set the font smoothing type
2258         https://bugs.webkit.org/show_bug.cgi?id=43406
2259
2260         Reviewed by Adam Roben.
2261
2262         * WebKitTestRunner/TestInvocation.cpp:
2263         (WTR::TestInvocation::resetPreferencesToConsistentValues):
2264         Set the font smoothing level to
2265         kWKFontSmoothingLevelNoSubpixelAntiAliasing to match DRT.
2266
2267 2010-08-06  Jon Honeycutt  <jhoneycutt@apple.com>
2268
2269         Fix a missed variable rename.
2270
2271         Unreviewed.
2272
2273         * Scripts/old-run-webkit-tests:
2274
2275 2010-08-06  Jon Honeycutt  <jhoneycutt@apple.com>
2276
2277         mac-wk2/Skipped should be used on Windows when running regression tests
2278         https://bugs.webkit.org/show_bug.cgi?id=43494
2279
2280         Reviewed by Adam Roben.
2281
2282         * Scripts/old-run-webkit-tests:
2283         If the platform is win-wk2, also read the mac-wk2 skipped list.
2284
2285 2010-08-06  Kent Tamura  <tkent@chromium.org>
2286
2287         Reviewed by Dimitri Glazkov.
2288
2289         [DRT/Chromium] Should revoke scheduled tasks
2290         https://bugs.webkit.org/show_bug.cgi?id=43560
2291
2292         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2293         (DRTDevToolsAgent::reset): Calls RevokeAll().
2294         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2295         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
2296         (DRTDevToolsClient::reset): Calls RevokeAll().
2297         * DumpRenderTree/chromium/DRTDevToolsClient.h:
2298         * DumpRenderTree/chromium/EventSender.cpp:
2299         (EventSender::reset): Calls RevokeAll().
2300         * DumpRenderTree/chromium/LayoutTestController.cpp:
2301         (LayoutTestController::reset): Calls RevokeAll().
2302         * DumpRenderTree/chromium/TestShell.cpp:
2303         (TestShell::resetTestController): Calls DRTDevToolsAgent::reset() and DRTDevToolsClient::reset().
2304
2305 2010-08-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2306
2307         Reviewed by Antonio Gomes.
2308
2309         [Qt] Fix the DRT build on Mac OS X
2310
2311         * DumpRenderTree/qt/DumpRenderTree.pro:
2312
2313 2010-08-06  Jochen Eisinger  <jochen@chromium.org>
2314
2315         Reviewed by Pavel Feldman.
2316
2317         Rietvield's upload.py moved to a different location.
2318         https://bugs.webkit.org/show_bug.cgi?id=43613
2319
2320         * Scripts/webkitpy/thirdparty/__init__.py:
2321
2322 2010-05-23  Eric Seidel  <eric@webkit.org>
2323
2324         Reviewed by Adam Barth.
2325
2326         QueueStatusServer needs better queue-status pages
2327         https://bugs.webkit.org/show_bug.cgi?id=39562
2328
2329         The primary goal of this patch is to display queue
2330         positions somewhere on the site so that it's easier
2331         for commit-queue users to know when their pach will
2332         be landed.  I also tried to improve the root page
2333         to be more useful than the previous wall of status text.
2334
2335         * QueueStatusServer/handlers/recentstatus.py:
2336         * QueueStatusServer/main.py:
2337         * QueueStatusServer/model/queues.py:
2338         * QueueStatusServer/templates/recentstatus.html:
2339
2340 2010-08-05  Victor Wang  <victorw@chromium.org>
2341
2342         Reviewed by Ojan Vafai.
2343
2344         Add option to generate/upload incremental json results to test result server.
2345         Also refactor the json results generator unittest code to test
2346         incremental and aggregated json results.
2347
2348         https://bugs.webkit.org/show_bug.cgi?id=43519
2349
2350         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2351         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2352         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2353         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2354
2355 2010-08-05  Jian Li  <jianli@chromium.org>
2356
2357         Reviewed by David Levin.
2358
2359         Unify blob related feature defines to ENABLE(BLOB).
2360         https://bugs.webkit.org/show_bug.cgi?id=43081
2361
2362         * Scripts/build-webkit:
2363
2364 2010-08-05  Satish Sampath  <satish@chromium.org>
2365
2366         Reviewed by Jeremy Orlow.
2367
2368         Add speech input controller mock in WebKit and a layout test.
2369         https://bugs.webkit.org/show_bug.cgi?id=43477
2370
2371         Added LayoutTestController::setMockSpeechInputResultCallback method.
2372
2373         * DumpRenderTree/LayoutTestController.cpp:
2374         (setMockSpeechInputResultCallback): Wrapper invoking the member function.
2375         (LayoutTestController::staticFunctions):
2376         * DumpRenderTree/LayoutTestController.h:
2377         * DumpRenderTree/chromium/LayoutTestController.cpp:
2378         (LayoutTestController::LayoutTestController):
2379         (LayoutTestController::setMockSpeechInputResult): Sets the mock result.
2380         (LayoutTestController::speechInputController): Creates the mock controller.
2381         * DumpRenderTree/chromium/LayoutTestController.h:
2382         * DumpRenderTree/chromium/WebViewHost.cpp:
2383         (WebViewHost::speechInputController): Creates the mock controller.
2384         * DumpRenderTree/chromium/WebViewHost.h:
2385         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2386         (LayoutTestController::setMockSpeechInputResult): dummy method.
2387         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2388         (LayoutTestController::setMockSpeechInputResult): dummy method.
2389         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2390         (LayoutTestController::setMockSpeechInputResult): dummy method.
2391         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2392         * DumpRenderTree/win/LayoutTestControllerWin.cpp: dummy method.
2393         (LayoutTestController::setMockSpeechInputResult):
2394         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: dummy method.
2395         (LayoutTestController::setMockSpeechInputResult):
2396
2397 2010-08-04  Adam Roben  <aroben@apple.com>
2398
2399         Fix the path to TestNetscapePlugin's directory on Windows
2400
2401         Fixes <http://webkit.org/b/43513> WebKitTestRunner on Windows fails to
2402         load TestNetscapePlugin
2403
2404         Reviewed by Jon Honeycutt.
2405
2406         * WebKitTestRunner/win/TestControllerWin.cpp:
2407         (WTR::TestController::initializeTestPluginDirectory):
2408         TestNetscapePlugin is in a TestNetscapePlugin[_Debug] directory that's
2409         next to WebKitTestRunner.exe. Previously we were passing the directory
2410         that contains WebKitTestRunner.exe. Also fixed some leaks.
2411
2412 2010-08-05  Kenichi Ishibashi  <bashi@google.com>
2413
2414         Reviewed by Shinichiro Hamaji.
2415
2416         check-webkit-style returns non-zero when patch is entirely minus lines.
2417         https://bugs.webkit.org/show_bug.cgi?id=38169
2418
2419         * Scripts/check-webkit-style:
2420         Check whether a patch contains modified files that are entirely minus lines.
2421         * Scripts/webkitpy/style/filereader.py:
2422         Add a variable that holds number of files that contain only deleted lines.
2423         * Scripts/webkitpy/style/patchreader.py:
2424         Count up modified files that contain only deleted lines.
2425
2426 2010-08-05  Pavel Feldman  <pfeldman@chromium.org>
2427
2428         Reviewed by Yury Semikhatsky.
2429
2430         DevTools: get rid of delayed command dispatching on front-end side.
2431
2432         https://bugs.webkit.org/show_bug.cgi?id=43479
2433
2434         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2435         (DRTDevToolsAgent::detach):
2436         (DRTDevToolsAgent::frontendLoaded):
2437         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2438         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
2439         (DRTDevToolsClient::~DRTDevToolsClient):
2440         (DRTDevToolsClient::sendFrontendLoaded):
2441         * DumpRenderTree/chromium/DRTDevToolsClient.h:
2442
2443 2010-08-04  Kenichi Ishibashi  <bashi@google.com>
2444
2445         Reviewed by Shinichiro Hamaji.
2446
2447         Fixes check-webkit-style false positive on "new uint32_t."
2448         https://bugs.webkit.org/show_bug.cgi?id=43077
2449
2450         * Scripts/webkitpy/style/checkers/cpp.py:
2451         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2452
2453 2010-08-04  Kent Tamura  <tkent@chromium.org>
2454
2455         Reviewed by Dimitri Glazkov.
2456
2457         [DRT/Chromium] Remove base/linked_ptr.h dependency
2458         https://bugs.webkit.org/show_bug.cgi?id=43472
2459
2460         Replace linked_ptr<TestNavigationEntry> with RefPtr<TestNavigationEntry>.
2461         We need to use RefPtr<> because m_pendingEntry points an object in
2462         m_entries or not in m_entries.
2463
2464         * DumpRenderTree/chromium/TestNavigationController.cpp:
2465         (TestNavigationEntry::create): Added.
2466         (TestNavigationController::activeEntry):
2467         (TestNavigationController::didNavigateToEntry):
2468         (TestNavigationController::discardPendingEntry):
2469         (TestNavigationController::insertEntry):
2470         (TestNavigationController::navigateToPendingEntry):
2471         * DumpRenderTree/chromium/TestNavigationController.h:
2472         * DumpRenderTree/chromium/WebViewHost.cpp:
2473         (WebViewHost::loadURLForFrame):
2474          Use TestNavigationEntry::create().
2475         (WebViewHost::updateURL):
2476          Use RefPtr<>.
2477         (WebViewHost::updateSessionHistory):
2478          Remove unnecessary static_cast<>.
2479
2480 2010-08-04  Kent Tamura  <tkent@chromium.org>
2481
2482         Reviewed by Dimitri Glazkov.
2483
2484         Fix a problem that "archived test results" step doesn't work on Chromium buildbots
2485         https://bugs.webkit.org/show_bug.cgi?id=43333
2486
2487         * BuildSlaveSupport/test-result-archive:
2488           - Make layoutTestResultsDir local and pass it to archiveTestResults()
2489           - Adjust layoutTestResultsDir for Chromium
2490
2491 2010-08-04  Kent Tamura  <tkent@chromium.org>
2492
2493         Reviewed by Dimitri Glazkov.
2494
2495         NRWT: websocket_server startup detection failure
2496         https://bugs.webkit.org/show_bug.cgi?id=43466
2497
2498         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2499          Increase timeout value: 5 second -> 10 second
2500
2501 2010-08-04  Victor Wang  <victorw@chromium.org>
2502
2503         Reviewed by Ojan Vafai.
2504
2505         -. Add result.json incremental merging functionality to test results app engine.
2506         -. blobstore is not suitable for AE data merging and there is no API to
2507            programatically edit existing blob or write a new one yet, so replace blobstore
2508            with datastore. If file is oversize (>1000*1000 bytes), store file data in
2509            multiple datastore entries.
2510         -. Fix styles.
2511
2512         Test: jsonresults_unittest to test merging logics.
2513
2514         https://bugs.webkit.org/show_bug.cgi?id=38599
2515
2516         * TestResultServer/handlers/dashboardhandler.py:
2517         * TestResultServer/handlers/menu.py:
2518         * TestResultServer/handlers/testfilehandler.py:
2519         * TestResultServer/main.py:
2520         * TestResultServer/model/dashboardfile.py:
2521         * TestResultServer/model/datastorefile.py: Added.
2522         * TestResultServer/model/jsonresults.py: Added.
2523         * TestResultServer/model/jsonresults_unittest.py: Added.
2524         * TestResultServer/model/testfile.py:
2525         * TestResultServer/templates/uploadform.html:
2526
2527 2010-08-04  Antonio Gomes  <tonikitoo@webkit.org>
2528
2529         Reviewed by Kenneth Christiansen.
2530
2531         [Qt] [QtTestBrowser] Remove unneeded QAction class members
2532         https://bugs.webkit.org/show_bug.cgi?id=43518
2533
2534         LauncherWindow class has two totally unneeded class members: m_flopAnimated and
2535         m_flipYAnimated. Also, in initializeView method there are some dead code block
2536         trying to connect them at the wrong time, when they have not been instanciated.
2537
2538         This patch:
2539
2540         - removes the two cited class members in favor of local variables in createChrome method;
2541         - removes the dead code block.
2542
2543         * QtTestBrowser/launcherwindow.cpp:
2544         (LauncherWindow::LauncherWindow):
2545         (LauncherWindow::initializeView):
2546         (LauncherWindow::createChrome):
2547         * QtTestBrowser/launcherwindow.h:
2548
2549 2010-08-04  Antonio Gomes  <tonikitoo@webkit.org>
2550
2551         Reviewed by Simon Hausmann and Kenneth Christiansen.
2552
2553         [Qt] [QtTestBrowser] Clean up static and global menu state controls
2554         https://bugs.webkit.org/show_bug.cgi?id=43448
2555
2556         After LauncherWindow class was refactored out of from main.cpp, all global variables that
2557         were hanging in main.cpp became temporarily public static class members of newly added
2558         LauncherWindow class. This design was not properly handling the initial purpose of the
2559         global variables: newly created launcher windows should inherit the settings of the originating
2560         one.
2561
2562         In order to properly fix the problem, this patch introduces a WindowOptions class, as a POD. It
2563         comprises all data needed to handling the goal described above.
2564
2565         * QtTestBrowser/launcherwindow.cpp:
2566         (LauncherWindow::LauncherWindow): The class now receives an optional WindowOptions pointer object
2567                                           holding all user settings configured in the menus and command line.
2568                                           It also receices an optional QGraphicsScene points in case we are doing
2569                                           a "Clone Window".
2570         (LauncherWindow::init): Removed the usesGraphics parameter because the class member m_userData holds its
2571                                 value.
2572         (LauncherWindow::initializeView): Ditto.
2573         (LauncherWindow::createChrome): Changed all references to gXXX to m_userData.XXX
2574         (LauncherWindow::applyPrefs): Removed the "LauncherWindow* source" parameter. All data needed to properly
2575                                       apply the preferences is provided by m_userData.
2576         (LauncherWindow::toggleAcceleratedCompositing): Change gXXX by m_userData.XXX
2577         (LauncherWindow::toggleResizesToContents): Ditto.
2578         (LauncherWindow::toggleWebGL): Ditto.
2579         (LauncherWindow::toggleFrameFlattening): Ditto.
2580         (LauncherWindow::toggleQGLWidgetViewport): Ditto.
2581         (LauncherWindow::changeViewportUpdateMode): Ditto.
2582         (LauncherWindow::showFPS): Ditto.
2583         (LauncherWindow::newWindow): Changed to pass the userData.
2584         (LauncherWindow::cloneWindow): Ditto.
2585         * QtTestBrowser/launcherwindow.h:
2586         (WindowOptions::WindowOptions):
2587         * QtTestBrowser/main.cpp:
2588         (requiresGraphicsView):
2589         (LauncherApplication::handleUserOptions):
2590         (main):
2591
2592 2010-08-04  Kevin Ollivier  <kevino@theolliviers.com>
2593
2594         [wx] Build fix for gcc not importing all symbols from convenience libraries.
2595         Works on 10.6 only for Mac until the build system is reworked. 
2596
2597         * wx/build/settings.py:
2598
2599 2010-08-04  Markus Goetz  <Markus.Goetz@nokia.com>
2600
2601         Reviewed by Simon Hausmann.
2602
2603         [Qt] Change wording in QtTestBrowser
2604         https://bugs.webkit.org/show_bug.cgi?id=43241
2605
2606         * QtTestBrowser/launcherwindow.cpp:
2607         (LauncherWindow::createChrome):
2608
2609 2010-08-04  Aaron Boodman  <aa@chromium.org>
2610
2611         Reviewed by Eric Seidel.
2612
2613         prepare-ChangeLog fails mysteriously if curl doesn't support ssl
2614         https://bugs.webkit.org/show_bug.cgi?id=43460
2615
2616         * Scripts/prepare-ChangeLog:
2617
2618 2010-08-03  MORITA Hajime  <morrita@google.com>
2619
2620         Reviewed by Tony Chang.
2621
2622         [DRT] Assertion failed when drag and move a draggable element.
2623         https://bugs.webkit.org/show_bug.cgi?id=41695
2624
2625         mouseMoveToX() did call [WebHTMLView mouseDragged] even if dragging started.
2626         But Cocoa doesn't call mouseDragged() until dragging is done.
2627         Other part of DumpRenderTree also assumes Cocoa behavior and an assertion
2628         on UIDelegate failed when mouseDragged() is called during dragging.
2629         This change eliminated the mouseDragged() call when dragging begins,
2630         which is implicated by draggingInfo instance.
2631         
2632         * DumpRenderTree/mac/EventSendingController.mm:
2633         (-[EventSendingController mouseMoveToX:Y:]):
2634
2635         Test: fast/events/dragging-mouse-moves.html
2636         
2637 2010-08-02  Steve Block  <steveblock@google.com>
2638
2639         Reviewed by Alexey Proskuryakov.
2640
2641         Adds Geolocation LayoutTests for the case where permission is not granted or denied immediately
2642         https://bugs.webkit.org/show_bug.cgi?id=40002
2643
2644         The code in LayoutTestController::setGeolocationPermission() was moved to
2645         setGeolocationPermissionCommon() to allow each port to provide its own
2646         implementation of setGeolocationPermission().
2647
2648         For the Mac port, setGeolocationPermission() notifies the UIDelegate of the
2649         new permission, so it can call back to WebCore if permission requests are in
2650         progress and are waiting for a response. A minor fix to the Mac
2651         MockGeolocationProvider was also required to make sure that the mock provider
2652         calls back to WebCore when it is first started.
2653
2654         For other ports, LayoutTestController::setGeolocationPermission() is not
2655         implemented.
2656
2657         * DumpRenderTree/LayoutTestController.cpp:
2658         (LayoutTestController::setGeolocationPermissionCommon):
2659         * DumpRenderTree/LayoutTestController.h:
2660         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2661         (LayoutTestController::setGeolocationPermission):
2662         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2663         (LayoutTestController::setGeolocationPermission):
2664         * DumpRenderTree/mac/MockGeolocationProvider.mm:
2665         (-[MockGeolocationProvider registerWebView:]):
2666         * DumpRenderTree/mac/UIDelegate.h:
2667         * DumpRenderTree/mac/UIDelegate.mm:
2668         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
2669         (-[UIDelegate setGeolocationPermission:]):
2670         (-[UIDelegate dealloc]):
2671         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2672         (LayoutTestController::setGeolocationPermission):
2673         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2674         (LayoutTestController::setGeolocationPermission):
2675
2676 2010-08-03  Kent Tamura  <tkent@chromium.org>
2677
2678         Reviewed by Dimitri Glazkov.
2679
2680         [DRT/Chromium] Implement --testshell-startup-dialog
2681         https://bugs.webkit.org/show_bug.cgi?id=40616
2682
2683         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2684         (main): Check --testshell-startup-dialog, and call openStartUpDialog()
2685         if it is specfied.
2686         * DumpRenderTree/chromium/TestShell.h:
2687           Declare openStartUpDialog().
2688         * DumpRenderTree/chromium/TestShellGtk.cpp:
2689         (openStartupDialog):
2690         * DumpRenderTree/chromium/TestShellMac.mm:
2691         (openStartupDialog):
2692         * DumpRenderTree/chromium/TestShellWin.cpp:
2693         (openStartupDialog):
2694
2695 2010-08-03  Kent Tamura  <tkent@chromium.org>
2696
2697         Reviewed by Dimitri Glazkov.
2698
2699         [DRT/Chromium] Remove dependency of base/md5.h
2700         https://bugs.webkit.org/show_bug.cgi?id=43403
2701
2702         * DumpRenderTree/chromium/TestShell.cpp:
2703         (TestShell::dumpImage): Use wtf/MD5.h
2704
2705 2010-08-03  Joseph Pecoraro  <joepeck@webkit.org>
2706
2707         Reviewed by David Kilzer.
2708
2709         Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
2710         https://bugs.webkit.org/show_bug.cgi?id=40627
2711
2712         Part 6 - LayoutTest and Cleanup
2713
2714           Allow tests to delete application caches and set application cache
2715           origin quotas, so they can be tested.
2716
2717         * DumpRenderTree/LayoutTestController.cpp:
2718         (LayoutTestController::LayoutTestController):
2719         (dumpApplicationCacheDelegateCallbacksCallback): JavaScript callback, delegates to the controller.
2720         (clearAllApplicationCachesCallback): should delete all application caches.
2721         (setApplicationCacheOriginQuotaCallback): should set the origin quota for the localhost tests.
2722         (LayoutTestController::staticFunctions):
2723         * DumpRenderTree/LayoutTestController.h:
2724         (LayoutTestController::dumpApplicationCacheDelegateCallbacks): accessor to see if application cache callbacks should be output.
2725         (LayoutTestController::setDumpApplicationCacheDelegateCallbacks): enable or disable debug output when the application cache quota is reached.
2726
2727           Mac implementation.
2728
2729         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2730         (LayoutTestController::clearAllApplicationCaches): delete application caches.
2731         (LayoutTestController::setApplicationCacheOriginQuota): set the quota for localhost.
2732         * DumpRenderTree/mac/UIDelegate.mm:
2733         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): style fix.
2734         (-[UIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:]): reset the quota.
2735
2736           Stub implementations for other platforms.
2737
2738         * DumpRenderTree/chromium/LayoutTestController.cpp:
2739         (LayoutTestController::LayoutTestController):
2740         (LayoutTestController::clearAllApplicationCaches):
2741         (LayoutTestController::setApplicationCacheOriginQuota):
2742         * DumpRenderTree/chromium/LayoutTestController.h:
2743         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2744         (LayoutTestController::clearAllApplicationCaches):
2745         (LayoutTestController::setApplicationCacheOriginQuota):
2746         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2747         (LayoutTestController::clearAllApplicationCaches):
2748         (LayoutTestController::setApplicationCacheOriginQuota):
2749         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2750         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2751         (LayoutTestController::clearAllApplicationCaches):
2752         (LayoutTestController::setApplicationCacheOriginQuota):
2753         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2754         (LayoutTestController::clearAllApplicationCaches):
2755         (LayoutTestController::setApplicationCacheOriginQuota):
2756
2757 2010-08-03  Joseph Pecoraro  <joepeck@webkit.org>
2758
2759         Reviewed by David Kilzer.
2760
2761         Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
2762         https://bugs.webkit.org/show_bug.cgi?id=40627
2763
2764         Part 5 - Refactor Quota Management in WebSecurityOrigin into Managers
2765
2766           Change old style calls to make use of the managers.
2767
2768         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2769         (LayoutTestController::setDatabaseQuota):
2770         * DumpRenderTree/mac/UIDelegate.mm:
2771         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]):
2772
2773 2010-08-03  Mark Rowe  <mrowe@apple.com>
2774
2775         Add a new Leopard build slave to run the release tests.
2776
2777         * BuildSlaveSupport/build.webkit.org-config/config.json:
2778
2779 2010-08-03  Jon Honeycutt  <jhoneycutt@apple.com>
2780
2781         WebKitTestRunner needs to activate the Mac font ascent hack
2782         https://bugs.webkit.org/show_bug.cgi?id=43404
2783
2784         Reviewed by Darin Adler.
2785
2786         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2787         (WTR::InjectedBundle::initialize):
2788         Call WKBundleActivateMacFontAscentHack().
2789
2790 2010-08-03  Alex Milowski  <alex@milowski.com>
2791
2792         Reviewed by Beth Dakin.
2793
2794         Changed the default for MathML support so that is is enabled by default.
2795
2796         * Scripts/build-webkit:
2797
2798 2010-08-03  Sam Weinig  <sam@webkit.org>
2799
2800         Roll r64566 back in this time with all the overloads in place..
2801
2802         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2803         (WTR::InjectedBundlePage::shouldInsertNode):
2804         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2805         * WebKitTestRunner/StringFunctions.h:
2806         * WebKitTestRunner/TestInvocation.cpp:
2807         (WTR::TestInvocation::resetPreferencesToConsistentValues):
2808         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2809         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2810
2811 2010-08-03  Sam Weinig  <sam@webkit.org>
2812
2813         Rollout r64566. It broke all the WebKit2 tests.
2814
2815         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2816         (WTR::operator<<):
2817         (WTR::InjectedBundlePage::shouldInsertNode):
2818         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2819         * WebKitTestRunner/StringFunctions.h: Removed.
2820         * WebKitTestRunner/TestInvocation.cpp:
2821         (WTR::createWKURL):
2822         (WTR::WKStringToUTF8):
2823         (WTR::TestInvocation::resetPreferencesToConsistentValues):
2824         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2825         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2826
2827 2010-08-03  Sam Weinig  <sam@webkit.org>
2828
2829         Reviewed by Anders Carlsson.
2830
2831         WTR: Move all the utility functions for working with strings to a shared header.
2832         https://bugs.webkit.org/show_bug.cgi?id=43386
2833
2834         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2835         (WTR::InjectedBundlePage::shouldInsertNode):
2836         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2837         * WebKitTestRunner/StringFunctions.h: Added.
2838         * WebKitTestRunner/TestInvocation.cpp:
2839         (WTR::TestInvocation::resetPreferencesToConsistentValues):
2840         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2841         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2842
2843 2010-08-02  Antonio Gomes  <tonikitoo@webkit.org>
2844
2845         Reviewed by Kenneth Christiansen.
2846
2847         [Qt] QtTestBrowser not setting preferredContentsSize for resizesToContents
2848         https://bugs.webkit.org/show_bug.cgi?id=43168
2849
2850         QGraphicsWebView resizesToContents property has to work together with QWebPage's
2851         setPreferredContentsSize as stated by the docs. Patch addresses that for QtTestBrowser.
2852
2853         * QtTestBrowser/launcherwindow.cpp:
2854         (LauncherWindow::applyPrefs):
2855         * QtTestBrowser/webview.cpp:
2856         (WebViewGraphicsBased::setResizesToContents): Properly handle scene, webview and viewport sizes
2857                                                       needed when toggle resizesToContents on/off.
2858         (WebViewGraphicsBased::resizeEvent):
2859         * QtTestBrowser/webview.h:
2860         (WebViewGraphicsBased::setCustomLayoutSize): Setter helper.
2861         (WebViewGraphicsBased::customLayoutSize): Getter helper.
2862
2863 2010-08-03  Jochen Eisinger  <jochen@chromium.org>
2864
2865         Unreviewed. Adding myself as committer.
2866
2867         * Scripts/webkitpy/common/config/committers.py:
2868
2869 2010-08-02  Pavel Feldman  <pfeldman@chromium.org>
2870
2871         Reviewed by Yury Semikhatsky.
2872
2873         Chromium DevTools: Get rid of DevTools RPC.
2874
2875         https://bugs.webkit.org/show_bug.cgi?id=43335
2876
2877         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2878         (DRTDevToolsAgent::sendMessageToInspectorFrontend):
2879         (DRTDevToolsAgent::call):
2880         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2881         * DumpRenderTree/chromium/DRTDevToolsCallArgs.h:
2882         (DRTDevToolsCallArgs::DRTDevToolsCallArgs):
2883         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
2884         (DRTDevToolsClient::sendMessageToBackend):
2885         (DRTDevToolsClient::call):
2886         * DumpRenderTree/chromium/DRTDevToolsClient.h:
2887
2888 2010-08-02  Kent Tamura  <tkent@chromium.org>
2889
2890         Reviewed by Dimitri Glazkov.
2891
2892         [DRT/Chromium] Remove dependencies to some Chromium headers
2893         https://bugs.webkit.org/show_bug.cgi?id=43396
2894
2895         * DumpRenderTree/chromium/CppVariant.h:
2896          Remove base/basictypes.h because webkit_support.h contains it.
2897         * DumpRenderTree/chromium/EventSender.cpp:
2898         (getCurrentEventTimeSec): Use new wrapper function.
2899         * DumpRenderTree/chromium/TestNavigationController.h:
2900          Remove base/basictypes.h because webkit_support.h contains it.
2901         * DumpRenderTree/chromium/TestShell.cpp:
2902         (dumpHistoryItem): Use new wrapper function.
2903         * DumpRenderTree/chromium/WebViewHost.cpp:
2904         (WebViewHost::cancelledError): Use new wrapper function.
2905         (WebViewHost::didFailResourceLoad): Use new wrapper function.
2906
2907 2010-08-02  Martin Robinson  <mrobinson@igalia.com>
2908
2909         Reviewed by Xan Lopez.
2910
2911         [GTK] DRT implement execCommand()
2912         https://bugs.webkit.org/show_bug.cgi?id=35351
2913
2914         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2915         (LayoutTestController::execCommand): Implement using webkit_web_view_execute_core_command_by_name.
2916         (LayoutTestController::isCommandEnabled): Implement using webkit_web_view_is_command_enabled.
2917         (LayoutTestController::setCacheModel): Move below LayoutTestController::isCommandEnabled.
2918
2919 2010-08-02  Sam Weinig  <sam@webkit.org>
2920
2921         Reviewed by Anders Carlsson.
2922
2923         Add alias for run-webkit-tests --webkit-test-runner (run-webkit-tests -2).
2924
2925         * Scripts/old-run-webkit-tests:
2926
2927 2010-08-02  Jon Honeycutt  <jhoneycutt@apple.com>
2928
2929         WebKitTestRunner needs to support loading custom fonts (via the
2930         WEBKIT_TESTFONTS environment variable)
2931         https://bugs.webkit.org/show_bug.cgi?id=42782
2932
2933         Reviewed by Adam Roben.
2934
2935         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:
2936         (WTR::fontsPath):
2937         Copied from DRT code. Removed the fallback to DumpRenderTree.resources/,
2938         as this directory doesn't appear to be created anymore.
2939         (WTR::activateFonts):
2940         Loop through the fonts, and call AddFontResourceExW() for each.
2941
2942 2010-08-02  Jon Honeycutt  <jhoneycutt@apple.com>
2943
2944         Restore the WebKitTestRunner.sln that was removed, and remove the
2945         correct one.
2946
2947         Rubber-stamped by Sam Weinig.
2948
2949         * WebKitTestRunner/WebKitTestRunner.sln: Added.
2950         * WebKitTestRunner/win/WebKitTestRunner.sln: Removed.
2951
2952 2010-08-02  Jon Honeycutt  <jhoneycutt@apple.com>
2953
2954         Move InjectedBundle.vcproj to where the other WebKitTestRunner vcprojs live.
2955
2956         Remove the unused WebKitTestRunner.sln.
2957
2958         Reviewed by Sam Weinig.
2959
2960         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2961         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: Removed.
2962         * WebKitTestRunner/WebKitTestRunner.sln: Removed.
2963         * WebKitTestRunner/win/InjectedBundle.vcproj: Added.
2964         * WebKitTestRunner/win/WebKitTestRunner.sln:
2965
2966 2010-08-02  Sam Weinig  <sam@webkit.org>
2967
2968         Fix the windows build.
2969
2970         * WebKitTestRunner/win/main.cpp:
2971
2972 2010-07-29  Jon Honeycutt  <jhoneycutt@apple.com>
2973
2974         Add a Skipped list on Windows, and have run-webkit-tests respect it.
2975
2976         Part of <rdar://problem/8233237> Fill WebKit2 Windows skipped list so
2977         there are zero tests failing
2978         https://bugs.webkit.org/show_bug.cgi?id=43374
2979
2980         Reviewed by Adam Roben.
2981
2982         * Scripts/old-run-webkit-tests:
2983         If using WebKitTestRunner and Apple Windows WebKit, set the platform to
2984         win-wk2. When building the result hierarchy, if the platform is win-wk2,
2985         add it first to the list of platforms.
2986
2987 2010-08-02  Darin Adler  <darin@apple.com>
2988
2989         Reviewed by Sam Weinig.
2990
2991         WebKitTestRunner needs layoutTestController.setCanOpenWindows
2992         https://bugs.webkit.org/show_bug.cgi?id=42321
2993
2994         WebKitTestRunner needs layoutTestController.setCloseRemainingWindowsWhenComplete
2995         https://bugs.webkit.org/show_bug.cgi?id=42779
2996
2997         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added
2998         setCanOpenWindows, setCloseRemainingWindowsWhenComplete, and windowCount
2999
3000         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3001         (WTR::InjectedBundle::InjectedBundle): Initialize m_mainPage to 0 instead of
3002         waiting for the first call to didCreatePage.
3003         (WTR::InjectedBundle::didCreatePage): Set m_mainPage only when the first page
3004         is created. Put other pages into a map.
3005         (WTR::InjectedBundle::willDestroyPage): Added code to handle the destruction
3006         of the main page.
3007         (WTR::InjectedBundle::closeOtherPages): Added. Closes all the pages other than
3008         the main page.
3009         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Added pageCount and
3010         closeOtherPages functions.
3011
3012         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3013         (WTR::InjectedBundlePage::didFinishLoadForFrame): Don't let pages other than
3014         the main page affect dumping.
3015         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): Ditto.
3016
3017         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3018         (WTR::LayoutTestController::LayoutTestController): Initialize the new
3019         m_shouldCloseExtraWindows member.
3020         (WTR::LayoutTestController::setCanOpenWindows): Added. Empty for now.
3021         (WTR::LayoutTestController::windowCount): Added.
3022
3023         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3024         Added setCanOpenWindows, setCloseRemainingWindowsWhenComplete,
3025         windowCount, shouldCloseExtraWindowsAfterRunningTest, and
3026         m_shouldCloseExtraWindows.
3027
3028         * WebKitTestRunner/TestController.cpp:
3029         (WTR::TestController::shared): Return a pointer to the shared copy, but
3030         don't allocate and leak it. This seemed cleaner than adding an explicit
3031         finalize call to go along with the explicit initialize call.
3032         (WTR::TestController::TestController): Added calls to the initialize and
3033         run function, which are now done automatically.
3034         (WTR::TestController::~TestController): Added, since it's called now.
3035         (WTR::closeOtherPage): Added. Used to close pages other than the main page.
3036         (WTR::createOtherPage): Added. Used to create pages other than the main page.
3037         (WTR::TestController::initialize): Added code to set up createOtherPage.
3038         (WTR::TestController::run): Removed unused return value.
3039         * WebKitTestRunner/TestController.h: Made constructor and destructor public,
3040         and initialize and run private. Changed m_mainWebView to be an OwnPtr.
3041
3042         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3043         (WTR::PlatformWebView::PlatformWebView): Added a call to setReleasedWhenClosed
3044         to avoid releasing the window twice. Another way to handle it would be to
3045         remove the release, but this approach is slightly more robust because it works
3046         even if some other code calls the close method an extra time.
3047
3048         * WebKitTestRunner/mac/main.mm:
3049         (main): Use a stack-allocated TestController object instead of calling
3050         initalize and run on a globally allocated one.
3051
3052 2010-08-02  Tony Chang  <tony@chromium.org>
3053
3054         Reviewed by David Levin.
3055
3056         add myself to the reviewers list
3057         https://bugs.webkit.org/show_bug.cgi?id=43366
3058
3059         * Scripts/webkitpy/common/config/committers.py:
3060
3061 2010-08-02  Anders Carlsson  <andersca@apple.com>
3062
3063         Reviewed by Sam Weinig.
3064
3065         Cache JSNPObjects and fix bugs in the object map
3066         https://bugs.webkit.org/show_bug.cgi?id=43368
3067
3068         Test that we correctly throw exceptions when trying to do things to a JSObject that used to
3069         wrap an NPObject that came from a plug-in that is now destroyed.
3070
3071         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3072         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3073         (PluginTest::Object::getProperty):
3074         (PluginTest::Object::NP_GetProperty):
3075         (PluginTest::Object::npClass):
3076         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp: Added.
3077         (NPRuntimeObjectFromDestroyedPlugin::NPRuntimeObjectFromDestroyedPlugin):
3078         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasProperty):
3079         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::getProperty):
3080         (NPRuntimeObjectFromDestroyedPlugin::NPP_GetValue):
3081         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3082         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3083         * GNUmakefile.am:
3084
3085 2010-08-02  Martin Robinson  <mrobinson@igalia.com>
3086
3087         Reviewed by Xan Lopez.
3088
3089         [Gtk] DOM listeners get wrong keycodes for some keys
3090         https://bugs.webkit.org/show_bug.cgi?id=35170
3091
3092         Add support to all event senders for simulating keypad insert
3093         and print screen keys.
3094
3095         * DumpRenderTree/chromium/EventSender.cpp:
3096         (EventSender::keyDown): Add support for generating keypad insert and print screen.
3097         * DumpRenderTree/gtk/EventSender.cpp:
3098         (keyDownCallback): Ditto.
3099         * DumpRenderTree/mac/EventSendingController.mm:
3100         (-[EventSendingController keyDown:withModifiers:withLocation:]): Ditto.
3101         * DumpRenderTree/qt/EventSenderQt.cpp:
3102         (EventSender::keyDown): Ditto.
3103         * DumpRenderTree/win/EventSender.cpp:
3104         (keyDownCallback): Ditto.
3105
3106 2010-08-02  Martin Robinson  <mrobinson@igalia.com>
3107
3108         Build fix for building against development versions of GTK+. GTK 2.22
3109         has not yet been released, so these function definitions must be conditionalized
3110         on the development version.
3111
3112         * DumpRenderTree/gtk/EventSender.cpp: Fix GTK+ 2.21 build.
3113
3114 2010-08-02  Tony Chang  <tony@chromium.org>
3115
3116         Reviewed by Kent Tamura.
3117
3118         [chromium] use ChromiumDriver on Linux when running webkit tests
3119         https://bugs.webkit.org/show_bug.cgi?id=43273
3120
3121         * Scripts/webkitpy/layout_tests/port/chromium.py:
3122
3123 2010-08-02  Kent Tamura  <tkent@chromium.org>
3124
3125         Reviewed by Dimitri Glazkov.
3126
3127         [DRT/Chromium] Always initialize GTK
3128         https://bugs.webkit.org/show_bug.cgi?id=43327
3129
3130         Call gtk_init() in order to fix plugin test crash.
3131
3132         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3133         (main): Pass argc/argv to platformInit().
3134         * DumpRenderTree/chromium/TestShell.h:
3135         * DumpRenderTree/chromium/TestShellGtk.cpp:
3136         (platformInit): Update parameters, call gtk_init().
3137         * DumpRenderTree/chromium/TestShellMac.mm:
3138         (platformInit): Update parameters.
3139         * DumpRenderTree/chromium/TestShellWin.cpp:
3140         (platformInit): Update parameters.
3141
3142 2010-08-02  Balazs Kelemen  <kb@inf.u-szeged.hu>
3143
3144         Reviewed by Simon Hausmann.
3145
3146         [Qt] Generate forwarding headers for WebKit2
3147
3148         https://bugs.webkit.org/show_bug.cgi?id=43336
3149
3150         * Scripts/webkitdirs.pm: Call make on WebKit2/Makefile.DerivedSources.
3151
3152 2010-08-02  Fumitoshi Ukai  <ukai@chromium.org>
3153
3154         Reviewed by Kent Tamura.
3155
3156         WebSocket server should start with SO_REUSEADDR
3157         https://bugs.webkit.org/show_bug.cgi?id=43329
3158
3159         Pulls in pywebsocket-0.5.2.
3160         pywebsocket-0.5.2 includes a small fix to start server with SO_REUSE_ADDR.
3161         http://code.google.com/p/pywebsocket/source/detail?r=273
3162
3163         * Scripts/webkitpy/thirdparty/__init__.py: Bump pywebsocket version
3164
3165 2010-08-01  Kent Tamura  <tkent@chromium.org>
3166
3167         Reviewed by Dimitri Glazkov.
3168
3169         [DRT/Chromium] Remove string_util.h dependency
3170         https://bugs.webkit.org/show_bug.cgi?id=43312
3171
3172         * DumpRenderTree/chromium/LayoutTestController.cpp:
3173         (LayoutTestController::pathToLocalResource):
3174          Use string::find() instead of StartsWithASCII().
3175         (LayoutTestController::cppVariantToInt32):
3176          Use strtol() instead of StringToNumber().
3177
3178 2010-08-01  Sam Weinig  <sam@webkit.org>
3179
3180         Reviewed by Anders Carlsson.
3181
3182         Add ability to reset frame names for WebKitTestRunner
3183         https://bugs.webkit.org/show_bug.cgi?id=43316
3184
3185         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3186         (WTR::InjectedBundle::reset):
3187         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3188         (WTR::InjectedBundlePage::reset):
3189         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3190
3191 2010-08-01  Anders Carlsson  <andersca@apple.com>
3192
3193         Reviewed by Sam Weinig.
3194
3195         Implement NPN_RemoveProperty
3196         https://bugs.webkit.org/show_bug.cgi?id=43315
3197
3198         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3199         Add NPRuntimeRemoveProperty.cpp
3200         
3201         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3202         (PluginTest::NPN_GetStringIdentifier):
3203         (PluginTest::NPN_GetIntIdentifier):
3204         (PluginTest::NPN_RemoveProperty):
3205         Add NPN_ helpers.
3206
3207         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3208         Support more NPClass functions.
3209
3210         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp: Added.
3211         (NPRuntimeRemoveProperty::NPRuntimeRemoveProperty):
3212         Test for NPN_RemoveProperty.
3213
3214         (NPRuntimeRemoveProperty::TestObject::hasMethod):        
3215         (NPRuntimeRemoveProperty::TestObject::invoke):
3216         Add a testRemoveProperty method.
3217
3218         (NPRuntimeRemoveProperty::NPP_GetValue):
3219         Return the test object.
3220
3221         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3222         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3223         * GNUmakefile.am:
3224         Add NPRuntimeRemoveProperty.cpp
3225
3226 2010-07-30  Anders Carlsson  <andersca@apple.com>
3227
3228         Reviewed by Sam Weinig.
3229
3230         Add an NPObject class template helper to TestNetscapePlugin
3231         https://bugs.webkit.org/show_bug.cgi?id=43288
3232
3233         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3234         Add some template magic to be able to figure out if a class has a member function of a given type.
3235
3236         (PluginTest::Object::create):
3237         Create an object.
3238
3239         (PluginTest::Object::invokeDefault):
3240         Add dummy function, this should never be called.
3241
3242         (PluginTest::Object::Object):
3243         Initialize m_pluginTest to 0.
3244
3245         (PluginTest::Object::~Object):
3246         Add virtual destructor.
3247
3248         (PluginTest::Object::NP_Allocate):
3249         Create a new object.
3250
3251         (PluginTest::Object::NP_Deallocate):
3252         Delete the object.
3253
3254         (PluginTest::Object::NP_InvokeDefault):
3255         Call invokeDefault.
3256
3257         (PluginTest::Object::npClass):
3258         Initialize the NPClass struct.
3259
3260         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
3261         (DocumentOpenInDestroyStream::NPP_DestroyStream):
3262         Move this inline.
3263
3264         * DumpRenderTree/TestNetscapePlugIn/Tests/PluginScriptableNPObjectInvokeDefault.cpp:
3265         (PluginScriptableNPObjectInvokeDefault::NPObjectWithInvokeDefault::invokeDefault):
3266         (PluginScriptableNPObjectInvokeDefault::NPP_GetValue):
3267         Use the PluginTest::Object class template.
3268
3269 2010-07-31  Sam Weinig  <sam@webkit.org>
3270
3271         Reviewed by Dan Bernstein.
3272
3273         Patch for https://bugs.webkit.org/show_bug.cgi?id=43305
3274         Add back WKBundleFrameCopyInnerText to fix ~50 test failures
3275         due to SVGElements not having the innerText function.
3276
3277         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3278         (WTR::dumpFrameText):
3279
3280 2010-07-30  Sam Weinig  <sam@webkit.org>
3281
3282         Reviewed by Maciej Stachowiak.
3283
3284         Patch for https://bugs.webkit.org/show_bug.cgi?id=43290
3285         Add structured message passing from the injected bundle to UIProcess
3286
3287         * MiniBrowser/mac/AppDelegate.m:
3288         (didRecieveMessageFromInjectedBundle):
3289         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3290         (didClearWindowForFrame):
3291         (didRecieveMessage):
3292         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3293         (WTR::InjectedBundle::done):
3294         (WTR::InjectedBundle::didReceiveMessage):
3295         * WebKitTestRunner/TestController.cpp:
3296         (WTR::TestController::initialize):
3297         (WTR::TestController::didReceiveMessageFromInjectedBundle):
3298         * WebKitTestRunner/TestController.h:
3299         * WebKitTestRunner/TestInvocation.cpp:
3300         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3301         * WebKitTestRunner/TestInvocation.h:
3302         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3303
3304 2010-07-30  Sam Weinig  <sam@webkit.org>
3305
3306         Reviewed by Anders Carlsson.
3307
3308         Patch for https://bugs.webkit.org/show_bug.cgi?id=43275
3309         Make WKArrayRef more usable.
3310
3311         Remove now unnecessary const_casts.
3312
3313         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3314         (WTR::dumpDescendantFrameScrollPositions):
3315         (WTR::dumpDescendantFramesText):
3316
3317 2010-07-30  Sam Weinig  <sam@webkit.org>
3318
3319         Reviewed by Anders Carlsson.
3320
3321         Patch for https://bugs.webkit.org/show_bug.cgi?id=43274
3322         Add first pass of structured message passing.
3323
3324         Update Minibrowser and WebKitTestRunner to work with the new post message
3325         function.
3326
3327         * MiniBrowser/mac/AppDelegate.m:
3328         (didRecieveMessageFromInjectedBundle):
3329         (-[BrowserAppDelegate init]):
3330         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
3331         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3332         (didStartProvisionalLoadForFrame):
3333         (didReceiveServerRedirectForProvisionalLoadForFrame):
3334         (didFailProvisionalLoadWithErrorForFrame):
3335         (didCommitLoadForFrame):
3336         (didFinishLoadForFrame):
3337         (didFailLoadWithErrorForFrame):
3338         (didReceiveTitleForFrame):
3339         (didClearWindowForFrame):
3340         (didCreatePage):
3341         (willDestroyPage):
3342         (didRecieveMessage):
3343         (WKBundleInitialize):
3344         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3345         (WTR::InjectedBundle::_didReceiveMessage):
3346         (WTR::InjectedBundle::didReceiveMessage):
3347         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3348         * WebKitTestRunner/TestInvocation.cpp:
3349         (WTR::TestInvocation::invoke):
3350         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3351
3352 2010-07-30  Anders Carlsson  <andersca@apple.com>
3353
3354         Try to fix the layout test failures.
3355
3356         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3357         (webkit_test_plugin_get_value):
3358
3359 2010-07-29  Anders Carlsson  <andersca@apple.com>
3360
3361         Reviewed by Adam Roben.
3362
3363         Replace plugins/npruntime/bindings-test.html with a more sophisticated test
3364         https://bugs.webkit.org/show_bug.cgi?id=43232
3365
3366         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3367         Add PluginScriptableNPObjectInvokeDefault.cpp.
3368
3369         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3370         Remove invokeDefault callback function.
3371
3372         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3373         (PluginTest::create):
3374         Move this to the top of the file.
3375
3376         (PluginTest::NPP_GetValue):
3377         Add default implementation.
3378
3379         (PluginTest::NPN_CreateObject):
3380         Add NPN_ wrapper.
3381
3382         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3383         (PluginTest::identifier):
3384         Add identifier getter.
3385
3386         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
3387         (DocumentOpenInDestroyStream::DocumentOpenInDestroyStream):
3388         Add "using namespace std".
3389
3390         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3391         (NPP_GetValue):
3392         Give PluginTest a chance to return a value.
3393
3394         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3395         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3396         * GNUmakefile.am:
3397         Add PluginScriptableNPObjectInvokeDefault.cpp.
3398         
3399         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3400         (webkit_test_plugin_get_value):
3401         Give PluginTest a chance to return a value.
3402
3403 2010-07-30  Steve Block  <steveblock@google.com>
3404
3405         Reviewed by Steve Block.
3406
3407         Add LayoutTestController methods to test DeviceOrientation
3408         https://bugs.webkit.org/show_bug.cgi?id=39589
3409
3410         * DumpRenderTree/LayoutTestController.cpp:
3411         (setMockDeviceOrientationCallback):
3412         (LayoutTestController::staticFunctions):
3413         * DumpRenderTree/LayoutTestController.h:
3414         * DumpRenderTree/chromium/LayoutTestController.cpp:
3415         (LayoutTestController::LayoutTestController):
3416         (LayoutTestController::setMockDeviceOrientation):
3417         * DumpRenderTree/chromium/LayoutTestController.h:
3418         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3419         (LayoutTestController::setMockDeviceOrientation):
3420         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3421         (LayoutTestController::setMockDeviceOrientation):
3422         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3423         (LayoutTestController::setMockDeviceOrientation):
3424         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3425         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3426         (LayoutTestController::setMockDeviceOrientation):
3427         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3428         (LayoutTestController::setMockDeviceOrientation):
3429         * Scripts/build-webkit:
3430
3431 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
3432
3433         Reviewed by Kenneth Christiansen.
3434
3435         [Qt] QtTestBrowser: -resizes-to-contents command line parameter is broken
3436         https://bugs.webkit.org/show_bug.cgi?id=43209
3437
3438         When -resizes-to-content was being passed as a command line parameter it was simply
3439         not being set (although the corresponding menu item was marked as ON).
3440         User had to toggle the menu OFF and then ON again for it to take place.
3441
3442         Reason: LauncherWindow::applyPrefs method sets many user options passed in from
3443         the command line, but not resizesToContents. Patch addresses that.
3444
3445         * QtTestBrowser/launcherwindow.cpp:
3446         (LauncherWindow::createChrome):
3447         (LauncherWindow::applyPrefs):
3448         (LauncherWindow::toggleResizesToContents):
3449         * QtTestBrowser/webview.h:
3450         (WebViewGraphicsBased::resizesToContents):
3451
3452 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
3453
3454         Rubber-stamped by Simon Fraser.
3455
3456         [Qt] QtTestBrowser: more method grouping and clean ups.
3457
3458         Moving blocks of code around. Basically grouping related methods close to each.
3459
3460         * QtTestBrowser/launcherwindow.cpp:
3461         (LauncherWindow::initializeView):
3462         (LauncherWindow::createChrome):
3463         (LauncherWindow::changeViewportUpdateMode):
3464         (LauncherWindow::showFPS):
3465         (LauncherWindow::newWindow):
3466         (LauncherWindow::cloneWindow):
3467         * QtTestBrowser/launcherwindow.h:
3468
3469 2010-07-30  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
3470
3471         Reviewed by Tor Arne Vestbø.
3472
3473         [QT][Symbian] QtTestBrowser missing location capabilities
3474         https://bugs.webkit.org/show_bug.cgi?id=43235
3475
3476         QtTestBrowser missing capabilities to use QtMobility::QLocation. 
3477
3478         * QtTestBrowser/QtTestBrowser.pro:
3479
3480 2010-07-29  Anders Carlsson  <andersca@apple.com>
3481
3482         Add PluginTest.cpp
3483
3484         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3485
3486 2010-07-29  Dirk Pranke  <dpranke@chromium.org>
3487
3488         Reviewed by Eric Seidel.
3489
3490         Update download URLs for python irclib package; the old URLs 
3491         pointed at a specific mirror host and not the general sourceforge
3492         URLs.
3493
3494         https://bugs.webkit.org/show_bug.cgi?id=43228
3495
3496         * Scripts/webkitpy/thirdparty/__init__.py:
3497
3498 2010-07-29  Anders Carlsson  <andersca@apple.com>
3499
3500         Fix typo.
3501
3502         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3503
3504 2010-07-29  Anders Carlsson  <andersca@apple.com>
3505
3506         Another attempt at fixing the Qt and GTK+ build.
3507
3508         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3509         (webkit_test_plugin_new_instance):
3510         (webkit_test_plugin_destroy_stream):
3511
3512 2010-07-29  Anders Carlsson  <andersca@apple.com>
3513
3514         Another build fix attempt.
3515
3516         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3517         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3518         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3519         (webkit_test_plugin_new_instance):
3520         * GNUmakefile.am:
3521
3522 2010-07-29  Anders Carlsson  <andersca@apple.com>
3523
3524         Try to fix Windows and Unix builds.
3525
3526         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3527         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3528         (webkit_test_plugin_new_instance):
3529         (webkit_test_plugin_destroy_stream):
3530
3531 2010-07-29  Anders Carlsson  <andersca@apple.com>
3532
3533         Reviewed by Sam Weinig.
3534
3535         Refactor TestNetscapePlugin so tests can be split in separate files
3536         https://bugs.webkit.org/show_bug.cgi?id=43220
3537
3538         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3539         Add PluginTest.cpp, PluginTest.h and Tests/DocumentOpenInDestroyStream.cpp.
3540
3541         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3542         (pluginAllocate):
3543         Initialize pluginTest to 0. Remove testDocumentOpenInDestroyStream.
3544
3545         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
3546         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: Added.
3547         (PluginTest::PluginTest):
3548         Initialize m_npp and the test identifier.
3549         
3550         (PluginTest::createTestFunctions):
3551         Return the map from identifiers to createTest functions.
3552
3553         (PluginTest::registerCreateTestFunction):
3554         Insert the identifier and create function pair in the map.
3555
3556         (PluginTest::create):
3557         Look for a createTest function. If one is found, call it. Otherwise create a vanilla PluginTest object.
3558
3559         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added.
3560         (PluginTest::Register::Register):
3561         Helper class template for registering plug-in tests.
3562         
3563         (PluginTest::Register::create):
3564         Create a new test of the given type.
3565
3566         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp: Added.
3567         (DocumentOpenInDestroyStream::DocumentOpenInDestroyStream):
3568         Add a test that calls testDocumentOpen from its NPP_DestroyStream callback.
3569
3570         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3571         (NPP_New):
3572         Create a PluginTest given the identifier. Remove the check for "testdocumentopenindestroystream".
3573
3574         (NPP_DestroyStream):
3575         Call the plug-in test NPP_DestroyStream member function.
3576
3