2010-10-13 Sergio Villar Senin <svillar@igalia.com>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-10-13  Sergio Villar Senin  <svillar@igalia.com>
2
3         Reviewed by Martin Robinson.
4
5         [GTK] Add HTTP caching support
6         https://bugs.webkit.org/show_bug.cgi?id=44261
7
8         Add include paths for the new soup HTTP cache code.
9
10         * GNUmakefile.am: Add paths for the new soup HTTP cache code.
11
12 2010-10-13  Yi Shen  <yi.4.shen@nokia.com>
13
14         Reviewed by Antonio Gomes.
15
16         [Qt] QtTestBrowser shows two Url input fields
17         https://bugs.webkit.org/show_bug.cgi?id=47613
18
19         * QtTestBrowser/mainwindow.cpp:
20         (MainWindow::MainWindow):
21         (MainWindow::buildUI):
22
23 2010-10-13  Yi Shen  <yi.4.shen@nokia.com>
24
25         Reviewed by Tony Chang.
26
27         [gdb] Add pretty-print supports for UString, Identifier and JSString
28         https://bugs.webkit.org/show_bug.cgi?id=47601
29
30         * gdb/webkit.py:
31
32 2010-10-13  Adam Barth  <abarth@webkit.org>
33
34         Reviewed by Eric Seidel.
35
36         Add list of Ubuntu packages needed by the EWS bots
37         https://bugs.webkit.org/show_bug.cgi?id=47628
38
39         I've been copy/pasting this list between bots, but it's better to have
40         this checked in.
41
42         * EWSTools/ubuntu-ews-packages: Added.
43
44 2010-10-13  Leandro Pereira  <leandro@profusion.mobi>
45
46         Reviewed by Csaba Osztrogonác.
47
48         [EFL] Adds a build slave.
49         https://bugs.webkit.org/show_bug.cgi?id=47290
50
51         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
52         entry for a release build of the EFL port.
53         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
54         flag to build the EFL port.
55
56 2010-10-13  Adam Barth  <abarth@webkit.org>
57
58         Reviewed by Csaba Osztrogonác.
59
60         webkit-patch build shouldn't need --build to actually build!
61         https://bugs.webkit.org/show_bug.cgi?id=47438
62
63         Yeah, requiring --build for the build command is really dumb.  We did
64         this originally because the build step is usually optional in other
65         commands.  We don't have a good way of reversing the default for an
66         option in one command.  This approach is slightly hacky since --build
67         still shows up as an option on the help page, but at least it makes
68         progress.  Passing --build is harmless, so the EWS bots shouldn't
69         explode because of this change.
70
71         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
72         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
73         * Scripts/webkitpy/tool/commands/download.py:
74         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
75         * Scripts/webkitpy/tool/commands/queues_unittest.py:
76
77 2010-10-13  Sheriff Bot  <webkit.review.bot@gmail.com>
78
79         Unreviewed, rolling out r69638.
80         http://trac.webkit.org/changeset/69638
81         https://bugs.webkit.org/show_bug.cgi?id=47595
82
83         "Broke win and chromium-win bots" (Requested by dglazkov on
84         #webkit).
85
86         * Scripts/webkitpy/common/system/path.py:
87         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
88         * Scripts/webkitpy/layout_tests/port/base.py:
89         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
90         * Scripts/webkitpy/layout_tests/port/chromium.py:
91         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
92
93 2010-10-13  John Knottenbelt  <jknotten@chromium.org>
94
95         Reviewed by Steve Block.
96
97         First step towards client-based Geolocation in Chromium. Build
98         fixes for CLIENT_BASED_GEOLOCATION preprocessor feature define.
99         https://bugs.webkit.org/show_bug.cgi?id=47586
100
101         * DumpRenderTree/chromium/WebViewHost.cpp:
102         * DumpRenderTree/chromium/WebViewHost.h:
103
104 2010-10-13  Adam Roben  <aroben@apple.com>
105
106         Test that pressing the spacebar in a text field does not scroll the
107         document
108
109         Test for <http://webkit.org/b/47544> <rdar://problem/8540645>
110         REGRESSION: Pressing spacebar in a text field in WebKit2 does not
111         insert a space, scrolls the page instead
112
113         Reviewed by Sam Weinig.
114
115         * TestWebKitAPI/PlatformUtilities.h: Added isKeyDown.
116
117         * TestWebKitAPI/PlatformWebView.h: Added simulateSpacebarKeyPress.
118
119         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
120         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
121         * TestWebKitAPI/win/copy-resources.cmd:
122         Added new files.
123
124         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: Added.
125         (TestWebKitAPI::JavaScriptCallbackContext::JavaScriptCallbackContext):
126         We use this to track what the result of calling into JavaScript was.
127         (TestWebKitAPI::didFinishLoadForFrame): Records when the page
128         finishes loading.
129         (TestWebKitAPI::didNotHandleKeyEventCallback): Records when a key down
130         event is not handled.
131         (TestWebKitAPI::javaScriptCallback): Records that JavaScript finished
132         executing and whether the result matched our expectation.
133         (TestWebKitAPI::wk): Turns a UTF-8 C string into a WKStringRef.
134         (TestWebKitAPI::runJSTest): Calls into JS, waits for the call to
135         complete, and returns whether we got back the expected result.
136         (TestWebKitAPI::WebKit2_SpacebarScrolling): Tests that pressing
137         spacebar inside a text field does not scroll the document and that
138         pressing it outside the text field does scroll the document.
139
140         * TestWebKitAPI/Tests/WebKit2/spacebar-scrolling.html: Added.
141
142         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
143         (TestWebKitAPI::Util::isKeyDown): Checks the event's type.
144
145         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
146         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Copied
147         code from DRT's EventSendingController.
148
149         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
150         (TestWebKitAPI::Util::isKeyDown): Checks the message's type.
151
152         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
153         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Send the
154         same messages that get sent when you press spacebar in Notepad.
155
156 2010-10-13  Adam Roben  <aroben@apple.com>
157
158         Fix a couple of issues with the TestWebKitAPI build
159
160         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops:
161         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops:
162         Fixed a typo.
163
164         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Use common.vsprops
165         to set our output and intermediate directories so that we don't spew
166         files into the source tree.
167
168 2010-10-13  Balazs Kelemen  <kbalazs@webkit.org>
169
170         Reviewed by Csaba Osztrogonác.
171
172         WTR should accept relative paths
173         https://bugs.webkit.org/show_bug.cgi?id=47486
174
175         * WebKitTestRunner/StringFunctions.h:
176         * WebKitTestRunner/TestInvocation.cpp:
177         (WTR::createWKURL): Moved from StringFunctions.h since it is
178         used only here. Extend relative paths to absolute.
179
180 2010-10-12  Adam Roben  <aroben@apple.com>
181
182         Make TestWebKitAPI work on Windows
183
184         Fixes <http://webkit.org/b/47552> <rdar://problem/8541708>.
185
186         Reviewed by Sam Weinig.
187
188         * Scripts/build-api-tests: Build TestWebKitAPI.sln on Windows.
189
190         * Scripts/run-api-tests: Fix the PATH so that TestWebKitAPI can be
191         run on Windows.
192         (runTest): Added code to run TestWebKitAPI.exe on Windows and to die
193         on unsupported platforms.
194         (populateTests): Added code to run TestWebKitAPI.exe on Windows and to
195         die on other platforms. Extracted some formerly-Mac-specific code to
196         be cross-platform and made it handle any style of line-endings.
197
198         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added.
199         Links against CFLite.
200
201         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added.
202         Contains most properties for the project.
203
204         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops:
205         Added. Links against CoreFoundation.
206
207         * TestWebKitAPI/TestWebKitAPIPrefix.h: Added a Windows-specific
208         section and moved the cross-platform section after the
209         platform-specific parts.
210
211         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Added.
212         (TestWebKitAPI::Util::run): Runs a normal message pump until we're
213         done.
214         (TestWebKitAPI::Util::cf): Turns a UTF-8 C string into a CFString.
215         (TestWebKitAPI::Util::createURLForResource): Uses CFBundle to get the
216         resource path.
217         (TestWebKitAPI::Util::URLForNonExistentResource): Creates a bogus
218         WKURL.
219
220         * TestWebKitAPI/win/PlatformWebViewWin.cpp: Added.
221         (TestWebKitAPI::registerWindowClass):
222         (TestWebKitAPI::PlatformWebView::PlatformWebView):
223         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
224         (TestWebKitAPI::PlatformWebView::page):
225         This was mostly copied from WebKitTestRunner's PlatformWebView.
226
227         * TestWebKitAPI/win/TestWebKitAPI.sln: Added. Builds both
228         TestWebKitAPI and TestWebKitAPIGeneratd. This is used by the
229         build-api-tests script.
230
231         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added. Builds
232         TestWebKitAPI.exe.
233
234         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added. Just calls
235         through to copy-resources.cmd.
236
237         * TestWebKitAPI/win/copy-resources.cmd: Added. Copies resources into
238         or deletes resources from TestWebKitAPI.resources.
239
240         * TestWebKitAPI/win/main.cpp: Added.
241         (main): Calls through to TestsController.
242
243 2010-10-13  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
244
245         Reviewed by Kenneth Rohde Christiansen.
246
247         [EFL] Support viewport configuration and add new arguments for WebKit EFL
248         https://bugs.webkit.org/show_bug.cgi?id=47084
249
250         Opera spec regarding to viewport meta tag was adjusted to WebCore. So, EFL port
251         needs to be modified according to the changes.
252
253         * EWebLauncher/main.c:
254         (on_viewport_changed):
255
256 2010-10-12  Dirk Pranke  <dpranke@chromium.org>
257
258         Reviewed by Eric Seidel.
259
260         This patch enables new-run-webkit-tests (in particular the
261         chromium-win port) to run under Cygwin as well as Win32. Mostly
262         this just required some conversions from cygwin paths to Win32
263         paths when we spawn off Win32 binaries like test_shell.
264
265         https://bugs.webkit.org/show_bug.cgi?id=47220
266
267         * Scripts/webkitpy/common/system/path.py:
268         - Expose the cygpath() function for path conversion
269
270         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
271         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
272         - shift filename->uri conversion in the TestInfo objects to the
273           dump_render_tree thread
274
275         * Scripts/webkitpy/layout_tests/port/base.py:
276         * Scripts/webkitpy/layout_tests/port/chromium.py:
277         - use cygpath()
278
279 2010-10-12  Yuta Kitamura  <yutak@chromium.org>
280
281         Unreviewed. Add Yuta Kitamura (yutak) to the committers list.
282
283         * Scripts/webkitpy/common/config/committers.py:
284
285 2010-10-12  Sam Weinig  <sam@webkit.org>
286
287         Reviewed by Dan Bernstein.
288
289         When a provisional load fails, the provisional URL returned
290         from WKFrameCopyProvisionalURL should be empty
291         <rdar://problem/8540878>
292         https://bugs.webkit.org/show_bug.cgi?id=47546
293
294         Add test.
295
296         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
297         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
298
299 2010-10-12  Anders Carlsson  <andersca@apple.com>
300
301         Reviewed by Sam Weinig.
302
303         Start fleshing out find page overlays
304         https://bugs.webkit.org/show_bug.cgi?id=47559
305
306         * MiniBrowser/mac/BrowserWindowController.m:
307         (-[BrowserWindowController find:]):
308         Pass kWKFindOptionsShowOverlay to WKPageFindString.
309
310 2010-10-12  Robert Hogan  <robert@webkit.org>
311
312         Reviewed by Antonio Gomes.
313
314         [Qt] editing/input/emacs-ctrl-o.html
315
316         ctrl-o is bound to a sequence of commands on Mac, namely:
317         insertParagraphSeparator then moveLeft. In the DRT, we just interpret
318         ctrl-o in EventSenderQt as '\n', i.e. insertParagraphSeparator. As a
319         result we only issue one command, so don't generate the change in caret
320         position that results in the extra editing delegate messages.
321
322         So for the sake of not managing suspicious-looking differences, just
323         make DRT issue the appropriate edit commands to pass the test.
324
325         https://bugs.webkit.org/show_bug.cgi?id=47548
326
327         * DumpRenderTree/qt/EventSenderQt.cpp:
328         (EventSender::keyDown):
329
330 2010-10-12  Anders Carlsson  <andersca@apple.com>
331
332         Reviewed by Sam Weinig.
333
334         Add a simple Find UI to MiniBrowser
335         https://bugs.webkit.org/show_bug.cgi?id=47553
336
337         * MiniBrowser/mac/BrowserWindow.xib:
338         Add Find panel.
339
340         * MiniBrowser/mac/BrowserWindowController.h:
341         * MiniBrowser/mac/BrowserWindowController.m:
342         (-[BrowserWindowController performFindPanelAction:]):
343         Show the find panel.
344
345         (-[BrowserWindowController find:]):
346         Tell the WKPageRef to find the given string.
347
348 2010-10-12  Tony Chang  <tony@chromium.org>
349
350         Unreviewed, fixing DRT compile on Windows after r69586.
351
352         * DumpRenderTree/chromium/WebThemeEngineDRT.h:
353
354 2010-10-12  Tony Chang  <tony@chromium.org>
355
356         Unreviewed, trying to fix NRWT on Windows.
357
358         * Scripts/webkitpy/layout_tests/port/http_lock.py:
359
360 2010-10-12  Balazs Kelemen  <kbalazs@webkit.org>
361
362         Reviewed by Kenneth Rohde Christiansen.
363
364         [Qt][WTR] Checking the path of the injected bundle is bogus
365         https://bugs.webkit.org/show_bug.cgi?id=47541
366
367         * WebKitTestRunner/qt/TestControllerQt.cpp:
368         (WTR::isExistingLibrary): Added (static helper).
369         Extend the path with the appropriate suffix(es) on the
370         platform and check that the file exists.
371         (WTR::TestController::initializeInjectedBundlePath):
372         There were two bugs with the path checking:
373             - the condition should have been inverted
374             - QLibrary::fileName does not give back the filename
375               with the library suffix so we cannot check
376               that existance of the file this way.
377
378 2010-10-12  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
379
380         Reviewed by Tony Chang.
381
382         Implement http locking in NRWT.
383         https://bugs.webkit.org/show_bug.cgi?id=47072
384
385         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
386         * Scripts/webkitpy/layout_tests/port/base.py:
387         * Scripts/webkitpy/layout_tests/port/http_lock.py: Added.
388         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py: Added.
389         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
390
391 2010-10-12  Mark Rowe  <mrowe@apple.com>
392
393         Fix the 32-bit WebKit2 build.
394
395         * MiniBrowser/mac/BrowserWindowController.m:
396         (getWindowFrame): Use NSRect rather than CGRect since that's what -frame returns.
397         (setWindowFrame): Use NSMakeRect rather than CGRectMake since that's what -setFrame:display: expects.
398
399 2010-10-11  Tony Chang  <tony@chromium.org>
400
401         Reviewed by Adam Barth.
402
403         change the order of mrobinson's email addresses so bugs.webkit.org suggests the right one
404         https://bugs.webkit.org/show_bug.cgi?id=47513
405
406         bugs.webkit.org suggests mrobinson@igalia.com as an autocomplete,
407         which doesn't actually work.
408
409         * Scripts/webkitpy/common/config/committers.py:
410
411 2010-10-11  Prasad Tammana  <prasadt@chromium.org>
412
413         Reviewed by Dmitry Titov.
414
415         Added support for showModalDialog on chromium port.
416
417         Implement showModalDialog for Layout tests for chromium port
418         https://bugs.webkit.org/show_bug.cgi?id=46759
419
420         * DumpRenderTree/chromium/WebViewHost.cpp:
421         (WebViewHost::closeWidgetSoon): Quit current message loop if in a modal loop.
422         (WebViewHost::runModal):  Start a nested message loop and remember that.
423         (WebViewHost::WebViewHost):  Initialize m_inModalLoop.
424         * DumpRenderTree/chromium/WebViewHost.h:  Add m_inModalLoop.
425
426 2010-10-11  Martin Robinson  <mrobinson@igalia.com>
427
428         Reviewed by Gustavo Noronha Silva.
429
430         [GTK] Cleanup font selection code for the Freetype backend
431         https://bugs.webkit.org/show_bug.cgi?id=47503
432
433         Update DRT to set values for the cursive and fantasy font families, so
434         that we can generate consistent results for tests that use these families.
435         Add some missing information to fonts.conf.
436
437         * DumpRenderTree/gtk/DumpRenderTree.cpp:
438         (resetDefaultsToConsistentValues): Always set the fantasy and cursive font
439         family names.
440         * DumpRenderTree/gtk/fonts/fonts.conf: Add aliases for cursive and fantasy fonts
441         to our default serif font. Eventually we may want to import or require some "real"
442         fonts, but this should at least ensure consistent rendering during test runs. Also
443         add aliases for some other commonly used fonts in tests (Arial and Lucida Grande).
444         Finally, add a missing oblique specification for DejaVu Serif, which was resulting
445         in some incorrect baselines for the synthetic oblique test.
446
447 2010-10-11  Adam Barth  <abarth@webkit.org>
448
449         Unreviewed.
450
451         Fix sheriffbot not to crash when there are failing tests.  It turns out
452         Python sets don't support the + operator.  We need to use union
453         instead.  There's a more elegant way to do this in Python 2.6, but we
454         need this code to work in 2.5.
455
456         * Scripts/webkitpy/common/net/failuremap.py:
457         * Scripts/webkitpy/common/net/failuremap_unittest.py:
458
459 2010-10-10  Robert Hogan  <robert@webkit.org>
460
461         Unreviewed, fix failing test from r69468.
462
463         [Qt] Put all DRT-created pages in a page group
464
465         Fix on r69468.
466
467         Because we don't delete closed pages immediately in DRT we need
468         to remove them from the page group explicitly instead.
469
470         Fixes failure of fast/events/popup-blocked-from-fake-user-gesture.html
471
472         https://bugs.webkit.org/show_bug.cgi?id=47469
473
474         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
475         (WebCore::DumpRenderTree::windowCloseRequested):
476
477 2010-10-10  Leandro Pereira  <leandro@profusion.mobi>
478
479         Reviewed by Adam Barth.
480
481         commit-queue: Add EFL-EWS status bubble to Bugzilla, now that the
482         EFL-EWS bot is up and running.
483         https://bugs.webkit.org/show_bug.cgi?id=47277
484
485         * QueueStatusServer/handlers/statusbubble.py:
486
487 2010-10-10  Robert Hogan  <robert@webkit.org>
488
489         Reviewed by Antonio Gomes.
490
491         [Qt] Put all DRT-created pages in a page group
492
493         https://bugs.webkit.org/show_bug.cgi?id=47469
494
495         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
496         (WebCore::DumpRenderTree::DumpRenderTree):
497         (WebCore::DumpRenderTree::createWindow):
498
499 2010-10-09  Sam Weinig  <sam@webkit.org>
500
501         Reviewed by Dan Bernstein.
502
503         WKFrameGetFrameLoadState() returns kWKFrameLoadStateCommitted after the load has been stopped
504         <rdar://problem/8173667>
505         https://bugs.webkit.org/show_bug.cgi?id=47461
506
507         * TestWebKitAPI/PlatformUtilities.h:
508         * TestWebKitAPI/Test.h:
509         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
510         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp: Added.
511         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
512         (TestWebKitAPI::TEST):
513         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
514         (TestWebKitAPI::Util::URLForNonExistentResource):
515         Adds a test for the frame load state after a failed provisional load. I wanted to test
516         the frame load state after a committed load failed, but I don't believe that is possible
517         to do without hooking up the http server to serve a long loading page.
518
519 2010-10-09  Sam Weinig  <sam@webkit.org>
520
521         Reviewed by Dan Bernstein.
522
523         Add WebKit2 version of runBeforeUnloadConfirmPanelWithMessage
524         <rdar://problem/8447690>
525         https://bugs.webkit.org/show_bug.cgi?id=47459
526
527         * MiniBrowser/mac/BrowserWindowController.m:
528         (runBeforeUnloadConfirmPanel):
529         (-[BrowserWindowController awakeFromNib]):
530         * WebKitTestRunner/TestController.cpp:
531         (WTR::createOtherPage):
532         (WTR::TestController::initialize):
533
534 2010-10-09  Sam Weinig  <sam@webkit.org>
535
536         Reviewed by Dan Bernstein.
537
538         Need implementation of ChromeClient windowRect related functions.
539         <rdar://problem/8469476>
540         https://bugs.webkit.org/show_bug.cgi?id=47386
541
542         * MiniBrowser/mac/BrowserWindowController.m:
543         (getWindowFrame):
544         (setWindowFrame):
545         (-[BrowserWindowController awakeFromNib]):
546         * WebKitTestRunner/PlatformWebView.h:
547         * WebKitTestRunner/TestController.cpp:
548         (WTR::TestController::initialize):
549         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
550         (WTR::PlatformWebView::windowFrame):
551         (WTR::PlatformWebView::setWindowFrame):
552         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
553         (WTR::PlatformWebView::windowFrame):
554         (WTR::PlatformWebView::setWindowFrame):
555         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
556         (WTR::PlatformWebView::windowFrame):
557         (WTR::PlatformWebView::setWindowFrame):
558
559 2010-10-08  Adam Barth  <abarth@webkit.org>
560
561         Unreviewed (Eric is on vacation in this change is trivial).
562
563         Add a "clean" command to webkit-patch to clean the working directory
564         https://bugs.webkit.org/show_bug.cgi?id=47436
565
566         This command is useful when using SVN because "svn revert" leaves
567         unversioned files behind.
568
569         * Scripts/webkitpy/tool/commands/download.py:
570
571 2010-10-08  Andras Becsi  <abecsi@webkit.org>
572
573         Unreviewed build fix.
574
575         [Qt] Add missing limits.h include since the Qt version currently
576         ran on the bot does need that.
577
578         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
579
580 2010-10-08  Balazs Kelemen  <kbalazs@webkit.org>
581
582         Reviewed by Csaba Osztrogonác.
583
584         [Qt] Turn on building WTR
585         https://bugs.webkit.org/show_bug.cgi?id=47349
586
587         * Scripts/webkitdirs.pm:
588
589 2010-10-08  Balazs Kelemen  <kbalazs@webkit.org>
590
591         Reviewed by Andreas Kling.
592
593         [Qt] TestController needs its platform dependent methods
594         https://bugs.webkit.org/show_bug.cgi?id=47413
595
596         * WebKitTestRunner/qt/TestControllerQt.cpp:
597         (WTR::TestController::initializeInjectedBundlePath):
598         If the WTR_INJECTEDBUNDLE_PATH environmental variable is
599         set then use that otherwise use the path where the bundle
600         lives in a normal trunk build.
601         (WTR::TestController::initializeTestPluginDirectory):
602         Set the bundle's value. It is not used currently.
603         (WTR::TestController::platformInitializeContext):
604         * WebKitTestRunner/qt/WebKitTestRunner.pro:
605
606 2010-10-08  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
607
608         Reviewed by Kenneth Rohde Christiansen.
609
610         WTR: Prevent sending the Done message twice on test timeout.
611         https://bugs.webkit.org/show_bug.cgi?id=47410
612
613         When InjectedBundle::done() calls stopLoading, this may trigger
614         InjectedBundlePage::didFailLoadWithErrorForFrame which calls
615         InjectedBundle::done() itself later in the stack.
616         This would output the timeout failure message twice and confuse
617         the run-webkit-tests script.
618
619         This patch adds a third state, Stopping, which prevents WebCore
620         errors to trigger done() when testing is over.
621
622         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
623         (WTR::InjectedBundle::done):
624         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
625
626 2010-10-08  Andras Becsi  <abecsi@webkit.org>
627
628         Reviewed by Kenneth Rohde Christiansen.
629
630         [Qt] Add an activateFonts() implementation similar to DRT's initializeFonts().
631         Original code by Simon Hausmann.
632         https://bugs.webkit.org/show_bug.cgi?id=47402
633
634         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: Added.
635         (WTR::activateFonts):
636
637 2010-10-08  Andras Becsi  <abecsi@webkit.org>
638
639         Reviewed by Csaba Osztrogonác.
640
641         [Qt] Add support for Qt's WebKitTestRunner to old-run-webkit-tests.
642         https://bugs.webkit.org/show_bug.cgi?id=47401
643
644         * Scripts/build-webkittestrunner:
645         * Scripts/old-run-webkit-tests:
646
647 2010-10-07  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
648
649         Reviewed by Kenneth Rohde Christiansen.
650
651         [Qt] WTR first compile: fix compile issues.
652         https://bugs.webkit.org/show_bug.cgi?id=47343
653
654         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
655         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
656         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
657         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
658         * WebKitTestRunner/TestController.cpp:
659         * WebKitTestRunner/TestInvocation.cpp:
660
661 2010-10-07  Antonio Gomes  <agomes@rim.com>
662
663         Reviewed by Simon Fraser.
664
665         [Mac] [DRT] implement setSpatialNavigationEnabled
666         https://bugs.webkit.org/show_bug.cgi?id=47291
667
668         Implemented LayoutTestController::setSpatialNavigationEnabled for Mac's DRT
669         so it can track regression on the existing implementation and future improvements
670         we are making.
671
672         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
673         (LayoutTestController::setSpatialNavigationEnabled):
674
675 2010-10-07  Dirk Pranke  <dpranke@chromium.org>
676
677         Reviewed by Adam Barth.
678
679         rebaseline-chromium-webkit-tests relied on the filename_to_uri()
680         hook in the Port infrastructure to generate URIs for the files
681         in its summary HTML report; however, that method is supposed to only
682         be used for test files (and should really be renamed), so this would
683         crash.
684
685         This change adds a new "path" module to the system package with a
686         routine called abspath_to_uri() that handles converting paths to
687         file: URIs independently of anything in the layout_tests package,
688         and changes the code to use this. At some point in the near future
689         the layout_tests/port/* code should use this as well.
690
691         This change also deletes a bunch of unused code and fixes some
692         comments in rebaseline_chromium_webkit_tests.py.
693
694         https://bugs.webkit.org/show_bug.cgi?id=47319
695
696         * Scripts/webkitpy/common/system/path.py: Added.
697         * Scripts/webkitpy/common/system/path_unittest.py: Added.
698         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
699         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
700
701 2010-10-07  Martin Robinson  <mrobinson@igalia.com>
702
703         Reviewed by Gustavo Noronha Silva.
704
705         [GTK] The FreeType backend does not respect the FC_EMBOLDEN property
706         https://bugs.webkit.org/show_bug.cgi?id=46216
707
708         Fix my latest commit, as it contained some bad changes from a merge gone wrong.
709
710         * DumpRenderTree/gtk/DumpRenderTree.cpp:
711         (initializeFonts): Also initialize the DevaVu Sans font.
712
713 2010-10-07  Daniel Cheng  <dcheng@chromium.org>
714
715         Reviewed by Tony Chang.
716
717         [chromium] Minor naming cleanup in WebDragData, part 2
718         https://bugs.webkit.org/show_bug.cgi?id=47227
719
720         Update DRT to use the renamed methods.
721
722         * DumpRenderTree/chromium/EventSender.cpp:
723         (EventSender::beginDragWithFiles):
724         * DumpRenderTree/chromium/WebViewHost.cpp:
725         (addDRTFakeFileToDataObject):
726
727 2010-10-07  Anders Carlsson  <andersca@apple.com>
728
729         Reviewed by Sam Weinig.
730
731         Add a WKPageFindClient, hook up WKPageCountStringMatches
732         https://bugs.webkit.org/show_bug.cgi?id=47373
733
734         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
735         Remove hard coded paths.
736
737         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
738         (TestWebKitAPI::TEST):
739         Fix expected result.
740
741         * TestWebKitAPI/Tests/WebKit2/Find.cpp: Added.
742         (TestWebKitAPI::didFinishLoadForFrame):
743         (TestWebKitAPI::didCountStringMatches):
744         (TestWebKitAPI::TEST):
745         * TestWebKitAPI/Tests/WebKit2/find.html: Added.
746         Add test for WKPageCountStringMatches.
747
748 2010-09-21  Martin Robinson  <mrobinson@igalia.com>
749
750         Reviewed by Chris Fleizach.
751
752         [GTK] The FreeType backend does not respect the FC_EMBOLDEN property
753         https://bugs.webkit.org/show_bug.cgi?id=46216
754
755         * DumpRenderTree/gtk/fonts/fonts.conf: Add a setting which enables FC_EMBOLDEN
756         for DejaVu Serif when there is no bold version available. This is necessary to
757         properly test the property in layout tests.
758
759 2010-10-07  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>, Andras Becsi  <abecsi@webkit.org>, Balazs Kelemen  <kbalazs@webkit.org>
760
761         Reviewed by Kenneth Rohde Christiansen.
762
763         [Qt] Add WTR's InjectedBundle build files.
764         https://bugs.webkit.org/show_bug.cgi?id=47333
765
766         * Scripts/webkitdirs.pm:
767         * WebKitTestRunner/DerivedSources.pro: Added.
768         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Added.
769         * WebKitTestRunner/WebKitTestRunner.pro: Added.
770         * WebKitTestRunner/qt/DerivedSources.pro: Removed.
771         Content merged in ../DerivedSources.pro
772
773 2010-10-07  Sheriff Bot  <webkit.review.bot@gmail.com>
774
775         Unreviewed, rolling out r69315.
776         http://trac.webkit.org/changeset/69315
777         https://bugs.webkit.org/show_bug.cgi?id=47363
778
779         Forgot to add the new files (Requested by kbalazs on #webkit).
780
781         * Scripts/webkitdirs.pm:
782         * WebKitTestRunner/qt/DerivedSources.pro: Added.
783
784 2010-10-07  Sam Weinig  <sam@webkit.org>
785
786         Reviewed by Anders Carlsson.
787
788         Change API tester to ask the executable for the list of all
789         tests instead of relying on the directory structure.
790         https://bugs.webkit.org/show_bug.cgi?id=47359
791
792         * Scripts/run-test-webkit-api: Added.
793         * Scripts/webkitdirs.pm:
794         Add additional script to just launch the api tester with the correct settings.
795
796         * Scripts/run-api-tests:
797         Change to use the new --dump-tests options to build the list of tests and change
798         output to reflect a (suite, testcase) tuple for each test. Also adds some color.
799
800         * TestWebKitAPI/Test.h:
801         (TestWebKitAPI::Test::Register::Register):
802         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
803         (TestWebKitAPI::TEST):
804         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
805         (TestWebKitAPI::TEST):
806         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
807         (TestWebKitAPI::TEST):
808         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
809         (TestWebKitAPI::TEST):
810         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
811         (TestWebKitAPI::TEST):
812         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
813         (TestWebKitAPI::TEST):
814         Give each test a suite name in addition to the test name.
815
816         * TestWebKitAPI/TestsController.cpp:
817         (TestWebKitAPI::TestsController::dumpTestNames):
818         (TestWebKitAPI::TestsController::runTestNamed):
819         * TestWebKitAPI/TestsController.h:
820         * TestWebKitAPI/mac/main.mm:
821         (main):
822         Add option to print all registered tests.
823
824 2010-10-07  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>, Andras Becsi  <abecsi@webkit.org>, Balazs Kelemen  <kbalazs@webkit.org>
825
826         Reviewed by Kenneth Rohde Christiansen.
827
828         [Qt] Add WTR's InjectedBundle build files.
829         https://bugs.webkit.org/show_bug.cgi?id=47333
830
831         * Scripts/webkitdirs.pm:
832         * WebKitTestRunner/DerivedSources.pro: Added.
833         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Added.
834         * WebKitTestRunner/WebKitTestRunner.pro: Added.
835         * WebKitTestRunner/qt/DerivedSources.pro: Removed.
836         Content merged in ../DerivedSources.pro
837
838 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
839
840         Unreviewed. Do a renaming that was recommended by the reviewer
841         (Kenneth) but I forgot to do before landing (http://trac.webkit.org/changeset/69253)
842
843         * WebKitTestRunner/qt/TestControllerQt.cpp:
844         (WTR::RunUntilConditionLoop::start):
845         (WTR::RunUntilConditionLoop::RunUntilConditionLoop):
846         (WTR::TestController::runUntil):
847
848 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
849
850         Reviewed by Kenneth Rohde Christiansen.
851
852         [Qt] Watchdog timer implementation for WTR
853         https://bugs.webkit.org/show_bug.cgi?id=47337
854
855         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Factor out
856         the definition of the timer type to a typedef.
857         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp: Added.
858         Timer implementation with QTimer and a helper QObject class.
859         (WTR::WatchdogTimerHelper::instance):
860         (WTR::WatchdogTimerHelper::timerFired):
861         (WTR::WatchdogTimerHelper::WatchdogTimerHelper):
862         (WTR::LayoutTestController::platformInitialize):
863         (WTR::LayoutTestController::invalidateWaitToDumpWatchdogTimer):
864         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
865
866 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
867
868         Unreviewed buildfix for 69297 again
869
870         * WebKitTestRunner/TestController.cpp:
871         (WTR::blankURL):
872
873 2010-10-07  Balazs Kelemen  <Balazs Kelemen>
874
875         Unreviewed trivial build fix for r69297
876
877         * WebKitTestRunner/TestController.cpp:
878         (WTR::blankURL):
879
880 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
881
882         Reviewed by Kenneth Rohde Christiansen.
883
884         WebKitTestRunner should be portable
885         https://bugs.webkit.org/show_bug.cgi?id=45393
886
887         Use only the WebKit API for working with urls.
888         * WebKitTestRunner/StringFunctions.h:
889         (WTR::createWKURL):
890         * WebKitTestRunner/TestController.cpp:
891         (WTR::blankURL):
892         (WTR::TestController::resetStateToConsistentValues):
893         (WTR::TestController::didFinishLoadForFrame):
894
895 2010-10-07  Carlos Garcia Campos  <cgarcia@igalia.com>
896
897         Reviewed by Xan Lopez.
898
899         [GTK] Use gtk_widget_draw() instead of gtk_widget_get_snapshot() in PixelDumpSupportGtk when building with gtk3
900         https://bugs.webkit.org/show_bug.cgi?id=47332
901
902         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
903         (createBitmapContextFromWebView):
904
905 2010-10-06  Chris Guillory  <chris.guillory@google.com>
906
907         Reviewed by Chris Fleizach.
908
909         Remove unused accessibility functions from webkit.
910         https://bugs.webkit.org/attachment.cgi?bugid=46707
911
912         * DumpRenderTree/chromium/WebViewHost.cpp:
913         (WebViewHost::postAccessibilityNotification):
914         * DumpRenderTree/chromium/WebViewHost.h:
915
916 2010-10-06  Lucas Forschler  <lforschler@apple.com>
917
918         Reviewed by Adam Roben.
919
920         Fix the sunspider-compare-results to actually use the passed in value for $root.
921
922         * Scripts/sunspider-compare-results:
923
924 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
925
926         Reviewed by Kenneth Rohde Christiansen.
927
928         [Qt] Runloop implementation for WTR
929         https://bugs.webkit.org/show_bug.cgi?id=47280
930
931         * WebKitTestRunner/qt/TestControllerQt.cpp:
932         Implemented TestController::runUntil by a timerEvent
933         and a QEventLoop. We step into the event loop from runUntil.
934         While we are waiting in the loop a timerEvent is periodically
935         checking the value of the condition. Once the condition has
936         becoming true the timerEvent wakes us up.
937         (WTR::RunUntilLoop::start):
938         (WTR::RunUntilLoop::RunUntilLoop):
939         (WTR::RunUntilLoop::run):
940         (WTR::RunUntilLoop::timerEvent):
941         (WTR::TestController::platformInitialize):
942         (WTR::TestController::runUntil):
943         * WebKitTestRunner/qt/main.cpp:
944         Start the main event loop first and creating the TestController later.
945         (Launcher::Launcher):
946         (Launcher::~Launcher):
947         (Launcher::launch): Creating the TestController.
948         (main): Setting up a timer for calling Launcher::launch from
949         the main event loop.
950
951 2010-10-06  Dirk Pranke  <dpranke@chromium.org>
952
953         Reviewed by Kenneth Russell.
954
955         new-run-webkit-tests: fix typo in chromium-gpu that was trying to
956         enable 'accelerated-composting' instead of 'accelerated-compositing'.
957
958         https://bugs.webkit.org/show_bug.cgi?id=47312
959
960         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
961         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
962
963 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
964
965         Reviewed by Kenneth Rohde Christiansen.
966
967         [Qt] PlatformWebView implementation for WebKitTestRunner
968         https://bugs.webkit.org/show_bug.cgi?id=47276
969
970         The implementation follows the way how
971         we use the API in MiniBrowser.
972         * WebKitTestRunner/PlatformWebView.h:
973         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
974         (WTR::WebView::wkView):
975         (WTR::WebView::~WebView):
976         (WTR::WebView::WebView):
977         (WTR::PlatformWebView::PlatformWebView):
978         (WTR::PlatformWebView::~PlatformWebView):
979         (WTR::PlatformWebView::resizeTo):
980         (WTR::PlatformWebView::page):
981         (WTR::PlatformWebView::focus):
982         * WebKitTestRunner/qt/WebKitTestRunner.pro:
983
984 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
985
986         Reviewed by Kenneth Rohde Christiansen.
987
988         [Qt] Add WebKitTestRunner's build files
989         https://bugs.webkit.org/show_bug.cgi?id=44155
990
991         Parts was taken by Zoltan Horvath's patch.
992
993         * Scripts/generate-forwarding-headers.pl: Moved from WebKit2.
994         * Scripts/webkitdirs.pm: Make the generated files needed by WTR.
995         * WebKitTestRunner/PlatformWebView.h: Addeed typedefs for
996         PlatformWKView and PlatformWindow (void* for now).
997         Buildfix the case when __APPLE__ is not defined.
998         * WebKitTestRunner/qt/DerivedSources.pro: Added.
999         * WebKitTestRunner/qt/PlatformWebViewQt.cpp: Added.
1000         Empty stub implementation.
1001         (WTR::registerWindowClass):
1002         (WTR::PlatformWebView::PlatformWebView):
1003         (WTR::PlatformWebView::~PlatformWebView):
1004         (WTR::PlatformWebView::resizeTo):
1005         (WTR::PlatformWebView::page):
1006         (WTR::PlatformWebView::focus):
1007         * WebKitTestRunner/qt/TestControllerQt.cpp: Added.
1008         Empty stub implementation.
1009         (WTR::registerWindowClass):
1010         (WTR::TestController::runUntil):
1011         (WTR::TestController::platformInitialize):
1012         (WTR::TestController::initializeInjectedBundlePath):
1013         (WTR::TestController::initializeTestPluginDirectory):
1014         (WTR::TestController::platformInitializeContext):
1015         * WebKitTestRunner/qt/WebKitTestRunner.pro: Added.
1016         * WebKitTestRunner/qt/main.cpp: Added.
1017         (main):
1018
1019 2010-10-06  Tony Chang  <tony@chromium.org>
1020
1021         Unreviewed, rolling out r69202.
1022         http://trac.webkit.org/changeset/69202
1023         https://bugs.webkit.org/show_bug.cgi?id=46937
1024
1025         Broke compile of test_shell
1026
1027         * DumpRenderTree/chromium/EventSender.cpp:
1028         (EventSender::beginDragWithFiles):
1029         * DumpRenderTree/chromium/WebViewHost.cpp:
1030         (addDRTFakeFileToDataObject):
1031
1032 2010-10-06  Daniel Cheng  <dcheng@chromium.org>
1033
1034         Reviewed by Tony Chang.
1035
1036         [chromium] Minor naming cleanup in WebDragData, part 2
1037         https://bugs.webkit.org/show_bug.cgi?id=46937
1038
1039         Update DRT to use the renamed methods.
1040
1041         * DumpRenderTree/chromium/EventSender.cpp:
1042         (EventSender::beginDragWithFiles):
1043         * DumpRenderTree/chromium/WebViewHost.cpp:
1044         (addDRTFakeFileToDataObject):
1045
1046 2010-10-06  David Kilzer  <ddkilzer@apple.com>
1047
1048         <http://webkit.org/b/47270> Move WebArchive serialization code into its own file
1049
1050         Reviewed by Adam Roben.
1051
1052         This is the first step in making webarchive tests work on
1053         Windows.
1054
1055         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added
1056         new files to the project.
1057         * DumpRenderTree/mac/DumpRenderTree.mm: Removed code that moved
1058         to WebArchiveDumpSupport.mm.
1059         * DumpRenderTree/mac/WebArchiveDumpSupport.h: Added.
1060         * DumpRenderTree/mac/WebArchiveDumpSupport.mm: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm.
1061         (serializeWebArchiveToXML):
1062
1063 2010-10-05  Daniel Bates  <dbates@rim.com>
1064
1065         Reviewed by David Kilzer.
1066
1067         Add infrastructure to towards detecting change log diffs that aren't at the top of the ChangeLog
1068         https://bugs.webkit.org/show_bug.cgi?id=46058
1069
1070         Make VCSUtils::fixChangeLogPatch() return a reference to a hash
1071         structure so as to support returning additional information
1072         about a change log diff.
1073
1074         Currently, VCSUtils::fixChangeLogPatch() returns a string that
1075         represents the change log diff. Towards supporting the return
1076         of additional information, such as whether the change log diff
1077         inserts an entry at the top of the ChangeLog file, we need to
1078         make VCSUtils::fixChangeLogPatch() return a reference to hash
1079         structure.
1080
1081         * Scripts/VCSUtils.pm:
1082           - Modified fixChangeLogPatch() to return a reference to a
1083             hash structure.
1084           - Added documentation to fixChangeLogPatch().
1085           - Modified call site in mergeChangeLogs() as necessary.
1086         * Scripts/svn-apply:
1087           - Modified call site in patch() as necessary.
1088         * Scripts/svn-create-patch:
1089           - Modified call site in generateDiff() as necessary.
1090         * Scripts/svn-unapply:
1091           - Modified call site in patch() as necessary.
1092         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
1093           - Modified the unit tests as necessary.
1094
1095 2010-10-05  Tony Chang  <tony@chromium.org>
1096
1097         Reviewed by Darin Adler.
1098
1099         fix the link to the expected image on windows
1100         https://bugs.webkit.org/show_bug.cgi?id=47228
1101
1102         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: On
1103             windows, the file must be opened in binary mode when writing
1104             binary data.
1105
1106 2010-10-05  Adam Barth  <abarth@webkit.org>
1107
1108         Update expected result of unittest to match Tony's change below.
1109
1110         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1111
1112 2010-10-05  Tony Chang  <tony@chromium.org>
1113
1114         Reviewed by Ojan Vafai (over the shoulder).
1115
1116         Paper over errors in image_diff so we don't crash the whole test run.
1117
1118         * Scripts/webkitpy/layout_tests/port/chromium.py:
1119
1120 2010-10-05  Tony Chang  <tony@chromium.org>
1121
1122         Unreviewed, make shutil.rmtree more resiliant to errors
1123         since windows was raising WindowsError: The process cannot access the file because it
1124         is being used by another process.
1125
1126         * Scripts/webkitpy/layout_tests/port/chromium.py:
1127
1128 2010-10-05  Tony Chang  <tony@chromium.org>
1129
1130         Reviewed by Ojan Vafai.
1131
1132         [chromium] fix image diffing in NRWT
1133         https://bugs.webkit.org/show_bug.cgi?id=47128
1134
1135         * Scripts/webkitpy/layout_tests/port/chromium.py: Stop using
1136             NamedTemporaryFile since it doesn't work on Windows.
1137         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1138
1139 2010-10-05  Kenneth Russell  <kbr@google.com>
1140
1141         Reviewed by Tony Chang.
1142
1143         [chromium] Implement layerTreeAsText in DumpRenderTree
1144         https://bugs.webkit.org/show_bug.cgi?id=47216
1145
1146         Plumbed Frame::layerTreeAsText through Chromium's WebKit API to
1147         make it callable from DumpRenderTree.
1148
1149         No new tests; verified with existing compositor layout tests.
1150
1151         * DumpRenderTree/chromium/LayoutTestController.cpp:
1152         (LayoutTestController::LayoutTestController):
1153         (LayoutTestController::layerTreeAsText):
1154         * DumpRenderTree/chromium/LayoutTestController.h:
1155
1156 2010-10-05  Brent Fulgham  <bfulgham@webkit.org>
1157
1158         Unreviewed build correction.
1159
1160         * DumpRenderTree/win/ImageDiff.vcproj: Use WinCairo debug
1161         property sheet so proper libraries are linked.
1162
1163 2010-10-05  Robert Hogan  <robert@webkit.org>
1164
1165         Reviewed by Andreas Kling.
1166
1167         [Qt] Fix url conversion in QWebHistory
1168
1169         Converting from KURL to WFT::String to QUrl does not
1170         permit proper percent encoding later.
1171
1172         https://bugs.webkit.org/show_bug.cgi?id=47048
1173
1174         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1175         (WebCore::dumpHistoryItem):
1176
1177 2010-10-05  Anders Carlsson  <andersca@apple.com>
1178
1179         Reviewed by Sam Weinig.
1180
1181         REGRESSION (r68966?): All dumpAsText test fail on WebKit2
1182         https://bugs.webkit.org/show_bug.cgi?id=47188
1183         <rdar://problem/8514104>
1184
1185         When constructing the std::string, use the real string length instead of the maximum buffer size.
1186
1187         * TestWebKitAPI/PlatformUtilities.h:
1188         (TestWebKitAPI::Util::toSTD):
1189         * WebKitTestRunner/StringFunctions.h:
1190         (WTR::toSTD):
1191
1192 2010-10-04  Sam Weinig  <sam@webkit.org>
1193
1194         Reviewed by Mark Rowe.
1195
1196         Add MIMEType accessor to WKFrame
1197         <rdar://problem/8347683>
1198         https://bugs.webkit.org/show_bug.cgi?id=47138
1199
1200         * TestWebKitAPI/PlatformUtilities.h:
1201         (TestWebKitAPI::Util::toSTD):
1202         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1203         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp: Added.
1204         (TestWebKitAPI::didStartProvisionalLoadForFrame):
1205         (TestWebKitAPI::didCommitLoadForFrame):
1206         (TestWebKitAPI::didFinishLoadForFrame):
1207         (TestWebKitAPI::TEST):
1208         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp: Added.
1209         (TestWebKitAPI::didStartProvisionalLoadForFrame):
1210         (TestWebKitAPI::didCommitLoadForFrame):
1211         (TestWebKitAPI::didFinishLoadForFrame):
1212         (TestWebKitAPI::TEST):
1213         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1214         (TestWebKitAPI::TEST):
1215         * TestWebKitAPI/Tests/WebKit2/basic-1.html: Removed.
1216         * TestWebKitAPI/Tests/WebKit2/icon.png: Added.
1217         * TestWebKitAPI/Tests/WebKit2/simple.html: Added.
1218         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1219         (TestWebKitAPI::Util::createURLForResource):
1220
1221 2010-10-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1222
1223         Reviewed by Ojan Vafai.
1224
1225         [NRWT] Rename current_dir to current_group because it's not a directory
1226         https://bugs.webkit.org/show_bug.cgi?id=47169
1227
1228         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1229         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1230
1231 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
1232
1233         Unreviewed, build fix.
1234
1235         r69065 broke test-webkitpy by trying to create a '/tmp-X' directory,
1236         which can't always be done. This test uses tempfile.mkdtemp(), which
1237         should be safe.
1238
1239         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1240
1241 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
1242
1243         Unreviewed, build fix.
1244
1245         Add missing "from __future__ import with_statement" that was
1246         breaking test-webkitpy on the Leopard bots (broke in r69040).
1247
1248         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1249
1250 2010-10-04  Sheriff Bot  <webkit.review.bot@gmail.com>
1251
1252         Unreviewed, rolling out r69066.
1253         http://trac.webkit.org/changeset/69066
1254         https://bugs.webkit.org/show_bug.cgi?id=47163
1255
1256         Made NRWT reliability worse. (Requested by tkent on #webkit).
1257
1258         * Scripts/webkitpy/layout_tests/port/chromium.py:
1259         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1260
1261 2010-10-04  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1262
1263         Reviewed by Tony Chang.
1264
1265         [NRWT] Reverse the http tests to alphabetical order.
1266         https://bugs.webkit.org/show_bug.cgi?id=47075
1267
1268         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1269
1270 2010-10-04  Robert Hogan  <robert@webkit.org>
1271
1272         Reviewed by Andreas Kling.
1273
1274         [Qt] Fix timeout on http/tests/navigation/post-goback2.html and postredirect-goback2.html
1275
1276         We need to queue back and forward navigations in the DRT from the
1277         LayoutTestController so that maybeDump() knows about them.
1278
1279         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1280         (LayoutTestController::queueBackNavigation):
1281         (LayoutTestController::queueForwardNavigation):
1282
1283 2010-10-04  Tony Chang  <tony@chromium.org>
1284
1285         Reviewed by Kent Tamura.
1286
1287         [chromium] fix image diffing in NRWT
1288         https://bugs.webkit.org/show_bug.cgi?id=47128
1289
1290         * Scripts/webkitpy/layout_tests/port/chromium.py: Flush data to the
1291               temp file and check the image_diff error code more carefully
1292         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1293
1294 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
1295
1296         Reviewed by Adam Barth.
1297
1298         aroben's change in r68792 actually broke new-run-webkit-tests when
1299         running the DRT code path. His change was intended to fix the
1300         way we were converting windows paths to URIs when running under
1301         Cygwin (the paths were getting one too many "/" on the front).
1302         However, the change ended up breaking the chromium_win port, which
1303         had slightly different logic.
1304
1305         This patch removes the port-specific code and adds tests to make
1306         sure we're getting the behavior we expect. The Port object no longer
1307         exposes a get_absolute_path() method that can be used outside of
1308         of converting test filenames, because it's unreliable otherwise
1309         (we don't have the right context to know which conversion is intended).
1310
1311         https://bugs.webkit.org/show_bug.cgi?id=47140
1312
1313         * Scripts/webkitpy/layout_tests/port/base.py:
1314         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1315         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1316         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1317         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1318
1319 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
1320
1321         Unreviewed, build fix.
1322
1323         Handle crash introduced in r69040 if we are not running in a
1324         Chromium checkout.
1325
1326         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1327
1328 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
1329
1330         Reviewed by Tony Chang.
1331
1332         Add a way for us to have test expectations that are specific to the
1333         official builds of Google Chrome (as opposed to Chromium). This change
1334         looks for an additional "test_expectations_chrome.txt" file in
1335         Chromium's repository (webkit/tools/layout_tests), and uses the
1336         concatenation of that file and the regular test_expectations.txt
1337         file for test overrides.
1338
1339         https://bugs.webkit.org/show_bug.cgi?id=46854
1340
1341         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1342         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1343
1344 2010-10-04  Simon Fraser  <simon.fraser@apple.com>
1345
1346         Color tests in the list based on existing pass/fail result.
1347         
1348         Fix the summary data to account for htmlOnly and nonHTML tests.
1349
1350         * CSSTestSuiteHarness/harness/harness.css:
1351         (#test-list > option.pass):
1352         (#test-list > option.fail):
1353         (#test-list > option.skipped):
1354         * CSSTestSuiteHarness/harness/harness.js:
1355         (Test):
1356         (Test.prototype.statusForFormat):
1357         (TestSuite.prototype.fillTestList):
1358         (TestSuite.prototype.updateTestList):
1359         (TestSuite.prototype.recordResult):
1360         (TestSuite.prototype.markTestCompleted):
1361         (TestSuite.prototype.countTestsWithFlag):
1362         (TestSuite.prototype.queryDatabaseForSummary.this.db.transaction):
1363         (TestSuite.prototype.queryDatabaseForSummary):
1364
1365 2010-10-04  Chris Fleizach  <cfleizach@apple.com>
1366
1367         Reviewed by Beth Dakin.
1368
1369         AX: doAXRangeForLine does not work
1370         https://bugs.webkit.org/show_bug.cgi?id=47101
1371
1372         DRT support to handle NSAccessibilityRangeForLineParameterizedAttribute.
1373
1374         * DumpRenderTree/AccessibilityUIElement.cpp:
1375         (rangeForLineCallback):
1376         (AccessibilityUIElement::rangeForLine):
1377         (AccessibilityUIElement::getJSClass):
1378         * DumpRenderTree/AccessibilityUIElement.h:
1379         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1380         (AccessibilityUIElement::rangeForLine):
1381
1382 2010-10-04  Andrey Kosyakov  <caseq@chromium.org>
1383
1384         Unreviewed. Adding myself to the committers list.
1385
1386         * Scripts/webkitpy/common/config/committers.py:
1387
1388 2010-10-04  Sam Weinig  <sam@webkit.org>
1389
1390         Reviewed by Anders Carlsson.
1391
1392         Add ability to set the CacheModel in Webkit2
1393         https://bugs.webkit.org/show_bug.cgi?id=47066
1394
1395         * MiniBrowser/mac/AppDelegate.m:
1396         (-[BrowserAppDelegate init]): Opt minibrowser into
1397         a PrimaryWebBrowser cache model.
1398
1399 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
1400
1401         Make sure to enter all tests when creating the database
1402         for the first time.
1403         
1404         When migrating to a new version of the suite, be sure to
1405         sync up the database and testinfo.data by removing old
1406         tests, and inserting new ones.
1407
1408         * CSSTestSuiteHarness/harness/harness.js:
1409         (TestSuite.prototype.openDatabase.creation):
1410         (TestSuite.prototype.databaseCreated):
1411         (TestSuite.prototype.populateDatabaseFromTestInfoData):
1412         (TestSuite.prototype.insertTest):
1413
1414 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
1415
1416         More work on treating HTML4 and XHTML1 independently; when 
1417         changing the format, rebuild the test list, and update the 
1418         numbers in the chapter popup.
1419
1420         * CSSTestSuiteHarness/harness/harness.js:
1421         (Test):
1422         (Test.prototype.runForFormat):
1423         (Test.prototype.completedForFormat):
1424         (ChapterSection):
1425         (ChapterSection.prototype.countTests):
1426         (Chapter):
1427         (Chapter.prototype.description):
1428         (Chapter.prototype.countTests):
1429         (Chapter.prototype.testCount):
1430         (Chapter.prototype.untestedCount):
1431         (TestSuite.prototype.buildChapters):
1432         (TestSuite.prototype.loadCurrentTest):
1433         (TestSuite.prototype.updateProgressLabel):
1434         (TestSuite.prototype.processFlags):
1435         (TestSuite.prototype.formatChanged):
1436
1437 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
1438
1439         Update test suite version 20101001.
1440         
1441         Handle database migration, and delete tests from the db that are
1442         not present in testinfo.data.
1443         
1444         Load about:blank into the test frame before the test url, to make
1445         missing tests more obvious.
1446         
1447         * CSSTestSuiteHarness/harness/harness.js:
1448         (TestSuite.prototype.loadTest):
1449         (TestSuite.prototype.openDatabase.creation):
1450         (TestSuite.prototype.openDatabase.migration1_0To1_1):
1451         (TestSuite.prototype.openDatabase.if.return):
1452         (TestSuite.prototype.databaseReady):
1453         (TestSuite.prototype.populateDatabaseFromTestInfoData):
1454         (TestSuite.prototype.syncDatabaseWithTestInfoData.this.db.transaction):
1455         (TestSuite.prototype.syncDatabaseWithTestInfoData):
1456
1457 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
1458
1459         Add the ability to jump to a specific test.
1460
1461         * CSSTestSuiteHarness/harness/harness.html:
1462         * CSSTestSuiteHarness/harness/harness.js:
1463         (TestSuite.prototype.goToTestByName):
1464         (TestSuite.prototype.switchToFormat):
1465
1466 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
1467
1468         For a ref test, load the ref in the same format (HTML4 vs XHTML1)
1469         as the test.
1470
1471         * CSSTestSuiteHarness/harness/harness.js:
1472         (TestSuite.prototype.loadRef):
1473
1474 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
1475
1476         Update the UI to reflect the fact that each test needs to be tested
1477         in both HTML4 and XHTML1 format.
1478         
1479         * CSSTestSuiteHarness/harness/harness.js:
1480         (Test):
1481         (Chapter.prototype.description):
1482         (Chapter.prototype.untestedCount):
1483         (TestSuite.prototype.fillChapterPopup):
1484         (TestSuite.prototype.updateChapterPopup):
1485         (TestSuite.prototype.fillTestList):
1486         (TestSuite.prototype.updateTestList):
1487         (TestSuite.prototype.goToNextIncompleteTest):
1488         (TestSuite.prototype.firstIncompleteTestIndex):
1489         (TestSuite.prototype.recordResult):
1490         (TestSuite.prototype.formatChanged):
1491         (TestSuite.prototype.markTestCompleted):
1492         (TestSuite.prototype.resetTestStatus):
1493
1494 2010-10-01  Simon Fraser  <simon.fraser@apple.com>
1495
1496         Add the ability to remove results for re-testing, and
1497         to import results.
1498
1499         * CSSTestSuiteHarness/harness/harness.css:
1500         (.custom button):
1501         (#overlay):
1502         (#overlay.visible):
1503         (.overlay-contents):
1504         (.overlay-contents textarea):
1505         (.overlay-contents .buttons):
1506         (.overlay-contents .note):
1507         (.overlay-contents .buttons button):
1508         * CSSTestSuiteHarness/harness/harness.html:
1509         * CSSTestSuiteHarness/harness/harness.js:
1510         (TestSuite.prototype.importResults):
1511         (TestSuite.prototype.clearResults):
1512         (TestSuite.prototype.markTestCompleted):
1513         (TestSuite.prototype.resetTestStatus):
1514         (TestSuite.prototype.storeTestResult):
1515         (TestSuite.prototype.importTestResults):
1516         (TestSuite.prototype.clearTestResults):
1517
1518 2010-10-01  Sam Weinig  <sam@webkit.org>
1519
1520         Reviewed by Jon Honeycutt.
1521
1522         Deploy the new WKString functions to remove most uses of CF from
1523         the WebKitTestRunner.
1524
1525         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1526         (WTR::InjectedBundle::didReceiveMessage):
1527         (WTR::InjectedBundle::done):
1528         * WebKitTestRunner/StringFunctions.h:
1529         (WTR::toWK):
1530         (WTR::toJS):
1531         (WTR::toSTD):
1532         (WTR::operator<<):
1533         (WTR::copyURLString):
1534         * WebKitTestRunner/TestController.cpp:
1535         (WTR::TestController::resetStateToConsistentValues):
1536         (WTR::TestController::didFinishLoadForFrame):
1537         * WebKitTestRunner/TestInvocation.cpp:
1538         (WTR::TestInvocation::invoke):
1539         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1540
1541 2010-10-01  Mihai Parparita  <mihaip@chromium.org>
1542
1543         Unreviewed TestResultsServer change.
1544
1545         Add files introduced by http://crrev.com/61273 to the list of dashboard 
1546         files to update.
1547
1548         * TestResultServer/handlers/dashboardhandler.py:
1549
1550 2010-10-01  Brian Weinstein  <bweinstein@apple.com>
1551
1552         Build Fix for Windows.
1553
1554         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Don't copy ForwardingHeaders from
1555             WebKitTestRunner/ForwardingHeaders, instead, add $(WebKitOutputDir)/include/WebCore/
1556             ForwardingHeaders to the include path.
1557
1558 2010-10-01  Sam Weinig  <sam@webkit.org>
1559
1560         Reviewed by Anders Carlsson.
1561
1562         Add SPI to convert a WKStringRef to a JSStringRef and vice-versa.
1563
1564         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1565         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
1566         (TestWebKitAPI::TEST):
1567         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp: Added.
1568         (TestWebKitAPI::TEST):
1569
1570 2010-10-01  Sam Weinig  <sam@webkit.org>
1571
1572         Reviewed by Kenneth Rohde Christiansen.
1573
1574         Add additional WKString API
1575         https://bugs.webkit.org/show_bug.cgi?id=46958
1576
1577         Add basic WKStringRef tests.
1578
1579         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1580         * TestWebKitAPI/Tests/WebKit2/WKString.cpp: Added.
1581
1582 2010-10-01  Sam Weinig  <sam@webkit.org>
1583
1584         Reviewed by Dan Bernstein.
1585
1586         Add makefile for TestWebKitAPI and call it from the base makefile.
1587
1588         * Makefile:
1589         * TestWebKitAPI/Makefile: Added.
1590
1591 2010-10-01  Sam Weinig  <sam@webkit.org>
1592
1593         Reviewed by Adam Roben.
1594
1595         Remove unnecessary ForwardingHeaders from test runners.
1596         https://bugs.webkit.org/show_bug.cgi?id=47010
1597
1598         * TestWebKitAPI/Configurations/Base.xcconfig:
1599         * TestWebKitAPI/ForwardingHeaders: Removed.
1600         * WebKitTestRunner/Configurations/Base.xcconfig:
1601         * WebKitTestRunner/ForwardingHeaders: Removed.
1602
1603 2010-09-30  Adam Barth  <abarth@webkit.org>
1604
1605         Reviewed by Eric Seidel.
1606
1607         WebSocket tests are flaky
1608         https://bugs.webkit.org/show_bug.cgi?id=46956
1609
1610         Update these tools to understand how to run the WebSocket tests off the
1611         Apache server.
1612
1613         * Scripts/old-run-webkit-tests:
1614         * Scripts/webkitpy/layout_tests/port/base.py:
1615         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1616         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1617
1618 2010-10-01  Adam Roben  <aroben@apple.com>
1619
1620         Encode Executive command arguments using UTF-8 on Cygwin
1621
1622         Cygwin's Python's os.execv doesn't support unicode command arguments.
1623         Cygwin's execv expects arguments to be encoded using the current code
1624         page. But code pages are limited in what characters they can handle,
1625         and our tests include characters that the English code page can't
1626         handle.  So for now we'll just encode everything in UTF-8 on Cygwin,
1627         which can handle all characters but might confuse some commands, for
1628         expediency's sake. I'm sure we'll run into cases where UTF-8 isn't
1629         good enough, but we can deal with that when the problem arises.
1630
1631         Reviewed by Adam Barth.
1632
1633         Fixes <http://webkit.org/b/46892> <rdar://problem/8496639>
1634         webkitpy.common.system.executive_unittest.ExecutiveTest.test_run_command_with_unicode
1635         fails on Windows
1636
1637         * Scripts/webkitpy/common/system/executive.py:
1638         (Executive._run_command_with_teed_output):
1639         (Executive.run_command):
1640         On Cygwin, encode arguments using UTF-8.
1641
1642 2010-10-01  Sam Weinig  <sam@webkit.org>
1643
1644         Reviewed by Adam Roben.
1645
1646         Add simple API tester for WebKit2
1647         https://bugs.webkit.org/show_bug.cgi?id=46953
1648
1649         This adds a very simple testing infrastructure for testing APIs exposed
1650         through the WebKit project. It consists of two parts: 1) a project that
1651         builds the all the tests 2) a script that searches the tests directory and
1652         calls the tester once for each test.
1653
1654         This adds the infrastructure and two tests:
1655         - Tests/WTF/Vector1.cpp - A proof of concept test of WTF data-structures.
1656         - Tests/WebKit2/BasicTest1.cpp - A proof of concept test of WebKit2 API.
1657
1658         This currently only works on the mac, but is designed to be easily ported 
1659         to any platform.
1660
1661         * Scripts/run-api-tests: Added.
1662         * Scripts/build-api-tests: Added.
1663         Scripts to build/run the tests.
1664
1665         * TestWebKitAPI: Added.
1666         * TestWebKitAPI/Configurations: Added.
1667         * TestWebKitAPI/Configurations/Base.xcconfig: Added.
1668         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Added.
1669         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Added.
1670         * TestWebKitAPI/ForwardingHeaders: Added.
1671         * TestWebKitAPI/ForwardingHeaders/wtf: Added.
1672         * TestWebKitAPI/PlatformUtilities.h: Added.
1673         * TestWebKitAPI/PlatformWebView.h: Added.
1674         (TestWebKitAPI::PlatformWebView::platformView):
1675         * TestWebKitAPI/StringFunctions.h: Added.
1676         * TestWebKitAPI/Test.h: Added.
1677         (TestWebKitAPI::Test::~Test):
1678         (TestWebKitAPI::Test::name):
1679         (TestWebKitAPI::Test::Register::Register):
1680         (TestWebKitAPI::Test::Register::create):
1681         (TestWebKitAPI::Test::Test):
1682         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Added.
1683         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added.
1684         * TestWebKitAPI/TestWebKitAPIPrefix.h: Added.
1685         * TestWebKitAPI/TestsController.cpp: Added.
1686         (TestWebKitAPI::TestsController::shared):
1687         (TestWebKitAPI::TestsController::TestsController):
1688         (TestWebKitAPI::TestsController::runTestNamed):
1689         (TestWebKitAPI::TestsController::testFailed):
1690         (TestWebKitAPI::TestsController::registerCreateTestFunction):
1691         * TestWebKitAPI/TestsController.h: Added.
1692         * TestWebKitAPI/mac: Added.
1693         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm: Added.
1694         (TestWebKitAPI::Util::run):
1695         (TestWebKitAPI::Util::createURLForResource):
1696         * TestWebKitAPI/mac/PlatformWebViewMac.mm: Added.
1697         (TestWebKitAPI::PlatformWebView::PlatformWebView):
1698         (TestWebKitAPI::PlatformWebView::resizeTo):
1699         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
1700         (TestWebKitAPI::PlatformWebView::page):
1701         (TestWebKitAPI::PlatformWebView::focus):
1702         * TestWebKitAPI/mac/main.mm: Added.
1703         Infrastructure.
1704
1705         * TestWebKitAPI/Tests: Added.
1706         * TestWebKitAPI/Tests/WTF: Added.
1707         * TestWebKitAPI/Tests/WTF/Vector1.cpp: Added.
1708         * TestWebKitAPI/Tests/WebKit2: Added.
1709         * TestWebKitAPI/Tests/WebKit2/BasicTest1.cpp: Added.
1710         (TestWebKitAPI::State::State):
1711         * TestWebKitAPI/Tests/WebKit2/basic-1.html: Added.
1712         Proof of concept tests.
1713
1714 2010-10-01  Adam Roben  <aroben@apple.com>
1715
1716         Don't assume AccessibleObjectFromEvent succeeds
1717
1718         Fixes <http://webkit.org/b/44136> <rdar://problem/8321684> Crash in
1719         DumpRenderTree!notificationListenerProc when running
1720         plugins/access-after-page-destroyed.html
1721
1722         Reviewed by Sam Weinig.
1723
1724         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1725         (notificationListenerProc): Check both the return value of
1726         AccessibleObjectFromEvent and the object it returns, as MSDN
1727         recommends.
1728
1729 2010-10-01  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1730
1731         Reviewed by Tony Chang.
1732
1733         [NRWT] Put the http and websocket tests first in the test list.
1734         https://bugs.webkit.org/show_bug.cgi?id=46453
1735
1736         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1737         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1738
1739 2010-10-01  Fady Samuel  <fsamuel@chromium.org>
1740
1741         Unreviewed, adding myself to the committer list.
1742
1743         * Scripts/webkitpy/common/config/committers.py:
1744
1745 2010-10-01  Adam Roben  <aroben@apple.com>
1746
1747         Test NPN_GetValue(NPNVnetscapeWindow)
1748
1749         Test for <http://webkit.org/b/46726> <rdar://problem/8486319>
1750         Right-clicking on windowless Flash plugin in WebKit2 makes a context
1751         menu appear in the bottom-right corner of the screen
1752
1753         Reviewed by Anders Carlsson.
1754
1755         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1756         (PluginTest::NPN_GetValue): Added. Calls through to the browser.
1757
1758         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added NPN_GetValue.
1759
1760         * DumpRenderTree/TestNetscapePlugIn/Tests/win/GetValueNetscapeWindow.cpp: Added.
1761         (GetValueNetscapeWindow::GetValueNetscapeWindow): Initialize members.
1762         (GetValueNetscapeWindow::NPP_SetWindow): Test that
1763         NPN_GetValue(NPNVnetscapeWindow) returns a valid HWND and that it
1764         isn't our HWND.
1765
1766         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1767         Added GetValueNetscapeWindow.
1768
1769 2010-10-01  Andreas Kling  <andreas.kling@nokia.com>
1770
1771         Unreviewed, adding my webkit.org identity to reviewer list.
1772
1773         * Scripts/webkitpy/common/config/committers.py:
1774
1775 2010-09-30  Adam Barth  <abarth@webkit.org>
1776
1777         Reviewed by Eric Seidel.
1778
1779         The WebSocket server should flush its logs
1780         https://bugs.webkit.org/show_bug.cgi?id=46946
1781
1782         The WebSocket server logs are truncated because the driver just
1783         terminates the child.  It should run Python without buffering so we can
1784         see the end of the log.
1785
1786         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1787
1788 2010-09-30  Simon Fraser  <simon.fraser@apple.com>
1789
1790         Add a button to jump to the next untested test.
1791         
1792         * CSSTestSuiteHarness/harness/harness.css:
1793         (.test-type):
1794         (.name > button):
1795         * CSSTestSuiteHarness/harness/harness.html:
1796         * CSSTestSuiteHarness/harness/harness.js:
1797         (Chapter.prototype.description):
1798         (Chapter.prototype.untestedCount):
1799         (TestSuite.prototype.testInfoDataLoaded):
1800         (TestSuite.prototype.fillChapterPopup):
1801         (TestSuite.prototype.updateChapterPopup):
1802         (TestSuite.prototype.buildTestListForChapter):
1803         (TestSuite.prototype.goToNextIncompleteTest):
1804         (TestSuite.prototype.firstIncompleteTestIndex):
1805         (TestSuite.prototype.testCompletionStateChanged):
1806
1807 2010-09-29  Jon Honeycutt  <jhoneycutt@apple.com>
1808
1809         WebKit2 on Windows should use Windows fonts for the various standard
1810         font families
1811         https://bugs.webkit.org/show_bug.cgi?id=43499
1812         <rdar://problem/8272758>
1813
1814         Reviewed by Adam Roben.
1815
1816         * WebKitTestRunner/TestController.cpp:
1817         (WTR::TestController::resetStateToConsistentValues):
1818         Use the Mac fonts for running tests. This matches DRT behavior.
1819
1820 2010-09-30  Adam Barth  <abarth@webkit.org>
1821
1822         Third attempt.  We need a better integration test environment.
1823
1824         * Scripts/webkitpy/common/net/failuremap.py:
1825         * Scripts/webkitpy/common/net/failuremap_unittest.py:
1826
1827 2010-09-30  Robert Hogan  <robert@webkit.org>
1828
1829         Reviewed by Andreas Kling.
1830
1831         [Qt] Support for PlainTextController
1832
1833         Unskip editing/text-iterator/basic-iteration.html
1834
1835         https://bugs.webkit.org/show_bug.cgi?id=38805
1836
1837         * DumpRenderTree/qt/DumpRenderTree.pro:
1838         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1839         (WebCore::DumpRenderTree::DumpRenderTree):
1840         (WebCore::DumpRenderTree::initJSObjects):
1841         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1842         * DumpRenderTree/qt/PlainTextControllerQt.cpp: Added.
1843         (PlainTextController::PlainTextController):
1844         (PlainTextController::plainText):
1845         * DumpRenderTree/qt/PlainTextControllerQt.h: Added.
1846
1847 2010-09-30  Adam Barth  <abarth@webkit.org>
1848
1849         Unreviewed.  Second attempt to fix sheriffbot.
1850
1851         * Scripts/webkitpy/common/net/buildbot.py:
1852
1853 2010-09-30  Adam Barth  <abarth@webkit.org>
1854
1855         Unreviewed.
1856
1857         This patch should stop the sheriffbot from throwing an exception.
1858
1859         * Scripts/webkitpy/common/net/buildbot.py:
1860
1861 2010-09-30  Brian Weinstein  <bweinstein@apple.com>
1862
1863         Reviewed by Adam Roben.
1864
1865         The same bots shouldn't run both Windows Debug Tests and Windows Release Tests.
1866         https://bugs.webkit.org/show_bug.cgi?id=46926
1867
1868         * BuildSlaveSupport/build.webkit.org-config/config.json: Have two bots running Windows 
1869             Release Tests, and two bots running Windows Debug Tests, instead of four running both.
1870
1871 2010-09-30  Adam Barth  <abarth@webkit.org>
1872
1873         Reviewed by Eric Seidel.
1874
1875         webkit-patch find-flaky-tests should print results URLs
1876         https://bugs.webkit.org/show_bug.cgi?id=46917
1877
1878         Printing out the results URL makes find-flaky-tests more actionable
1879         because you can see what happens when a test fails.  The output from
1880         the script is still pretty noisy, but it seems useful.
1881
1882         * Scripts/webkitpy/tool/commands/queries.py:
1883
1884 2010-09-30  Chris Marrin  <cmarrin@apple.com>
1885
1886         Reviewed by Simon Fraser.
1887
1888         Make 2D accelerated canvas rendering build on Mac
1889         https://bugs.webkit.org/show_bug.cgi?id=46007
1890         
1891         Added ACCELERATED_2D_CANVAS to build-webkit
1892
1893         * Scripts/build-webkit:
1894
1895 2010-09-29  Kenneth Russell  <kbr@google.com>
1896
1897         Reviewed by Dimitri Glazkov.
1898
1899         [chromium] Add accelerated compositing support to DumpRenderTree and test_shell
1900         https://bugs.webkit.org/show_bug.cgi?id=46849
1901
1902         Added offscreen code path for WebGraphicsContext3DDefaultImpl which
1903         works with the compositor integration in both DumpRenderTree and
1904         test_shell, since both pass a non-null WebCanvas* to WebViewImpl::paint
1905         and thereby trigger the compositor's readback code path. Added support
1906         for --enable-accelerated-compositing to DumpRenderTree.
1907
1908         Tested in both test_shell and DumpRenderTree on Linux, the latter by
1909         modifying a compositing layout test, dumping the pixels and verifying
1910         that they matched the output when the compositor was active.
1911
1912         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1913         (main):
1914         * DumpRenderTree/chromium/TestShell.cpp:
1915         (TestShell::TestShell):
1916         (TestShell::resetWebSettings):
1917         * DumpRenderTree/chromium/TestShell.h:
1918         (TestShell::setAcceleratedCompositingEnabled):
1919         * DumpRenderTree/chromium/WebPreferences.cpp:
1920         (WebPreferences::reset):
1921         (WebPreferences::applyTo):
1922         * DumpRenderTree/chromium/WebPreferences.h:
1923         * DumpRenderTree/chromium/WebViewHost.cpp:
1924         (WebViewHost::scheduleComposite):
1925         * DumpRenderTree/chromium/WebViewHost.h:
1926
1927 2010-09-30  Adam Roben  <aroben@apple.com>
1928
1929         Ensure that QueueEngine cleans up its log files when its delegate
1930         tells it to stop processing work
1931
1932         Reviewed by Adam Barth.
1933
1934         Fixes <http://webkit.org/b/46891> <rdar://problem/8496638> Many tests
1935         in webkitpy.tool.bot.queueengine_unittest.QueueEngineTest crash on
1936         Windows
1937
1938         * Scripts/webkitpy/tool/bot/queueengine.py:
1939         (QueueEngine.run): Stop ourselves normally (including cleaning up log
1940         files) when the delegate tells us to stop processing work.
1941
1942         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1943         (LoggingDelegate.__init__): Moved code here from
1944         RaisingDelegate.__init__.
1945         (LoggingDelegate.expeced_callbacks): Added the stop_work_queue
1946         callback.
1947         (LoggingDelegate.stop_work_queue): Moved here from RaisingDelegate.
1948         (RaisingDelegate.__init__): Removed code that LoggingDelegate takes
1949         care of for us now.
1950         (QueueEngineTest.test_trivial): Make sure we got the expected stop
1951         message.
1952         (QueueEngineTest.test_not_safe_to_proceed): Changed to explicitly
1953         remove the callbacks that are related to processing a single work
1954         item, rather than removing all callbacks after a certain point, as
1955         there are now more callbacks we expect to receive at the end.
1956
1957 2010-09-30  Adam Roben  <aroben@apple.com>
1958
1959         Fix path -> URL conversion on Cygwin
1960
1961         Reviewed by Adam Barth.
1962
1963         Fixes <http://webkit.org/b/46890> <rdar://problem/8496637> Many tests
1964         in webkitpy.layout_tests.run_webkit_tests_unittest assert on Windows
1965
1966         * Scripts/webkitpy/layout_tests/port/base.py:
1967         (Port.filename_to_uri): Treat Cygwin like other UNIX-y platforms by
1968         assuming paths already have a leading slash.
1969
1970 2010-09-30  Adam Roben  <aroben@apple.com>
1971
1972         Teach WindowGeometryInitializedBeforeSetWindow that NPP_SetWindow can
1973         be called more than once
1974
1975         The NPP_SetWindow call made when the plugin is torn down was confusing
1976         us, and was causing us to spew an error into the next test.
1977
1978         Fixes <http://webkit.org/b/46900> <rdar://problem/8496888> REGRESSION
1979         (r68520): plugins/access-after-page-destroyed.html failing on Windows
1980
1981         Reviewed by Anders Carlsson.
1982
1983         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:
1984         (WindowGeometryInitializedBeforeSetWindow::WindowGeometryInitializedBeforeSetWindow):
1985         Initialize member.
1986         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Bail if
1987         this isn't the first time this is called.
1988
1989 2010-09-30  Eric Seidel  <eric@webkit.org>
1990
1991         Reviewed by Adam Barth.
1992
1993         webkit-patch upload warns that I'm using Xcode when I'm not
1994         https://bugs.webkit.org/show_bug.cgi?id=46869
1995
1996         String.find returns -1 when not found, so switched to "in".
1997
1998         * Scripts/webkitpy/common/system/user.py:
1999         * Scripts/webkitpy/common/system/user_unittest.py:
2000
2001 2010-09-30  Eric Seidel  <eric@webkit.org>
2002
2003         Reviewed by Adam Barth.
2004
2005         webkit-patch failure-reason dies if non-trunk commits are in the blame range
2006         https://bugs.webkit.org/show_bug.cgi?id=46866
2007
2008         I also made failure-reason use RegressionWindow in a cleaner way.
2009
2010         * Scripts/webkitpy/tool/commands/queries.py:
2011
2012 2010-09-29  Adam Barth  <abarth@webkit.org>
2013
2014         Reviewed by Eric Seidel.
2015
2016         webkit-patch find-flaky-tests
2017         https://bugs.webkit.org/show_bug.cgi?id=46876
2018
2019         This command helps us find flaky tests so we can squash them.
2020
2021         * Scripts/webkitpy/tool/commands/queries.py:
2022
2023 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
2024
2025         Fix export to use '?' instead of 'null' for
2026         tests with no results.
2027         
2028         * CSSTestSuiteHarness/harness/harness.js:
2029
2030 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
2031
2032         Add a warning when a test requires special steps.
2033         Add a Print Preview button for 'paged' tests that
2034         brings up the print dialog, allowing the user to 
2035         judge paged media tests.
2036
2037         * CSSTestSuiteHarness/harness/harness.css:
2038         * CSSTestSuiteHarness/harness/harness.html:
2039         * CSSTestSuiteHarness/harness/harness.js:
2040         (TestSuite.prototype.loadTest):
2041         (TestSuite.prototype.processFlags):
2042
2043 2010-09-29  Adam Barth  <abarth@webkit.org>
2044
2045         Reviewed by Eric Seidel.
2046
2047         Remove revisions_casuing_failures
2048         https://bugs.webkit.org/show_bug.cgi?id=46872
2049
2050         This function exists only to be unit tested.
2051
2052         * Scripts/webkitpy/common/net/failuremap.py:
2053         * Scripts/webkitpy/common/net/failuremap_unittest.py:
2054         * Scripts/webkitpy/tool/mocktool.py:
2055
2056 2010-09-29  Adam Barth  <abarth@webkit.org>
2057
2058         Reviewed by Eric Seidel.
2059
2060         SheriffBot should post the list of failing tests to bugs
2061         https://bugs.webkit.org/show_bug.cgi?id=46871
2062
2063         * Scripts/webkitpy/common/net/buildbot.py:
2064         * Scripts/webkitpy/common/net/failuremap.py:
2065         * Scripts/webkitpy/common/net/regressionwindow.py:
2066         * Scripts/webkitpy/tool/bot/sheriff.py:
2067         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
2068         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2069         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2070         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2071         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2072         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2073         * Scripts/webkitpy/tool/mocktool.py:
2074
2075 2010-09-29  Brent Fulgham  <bfulgham@webkit.org>
2076
2077         Reviewed by Martin Robinson, Eric Seidel, and Mark Rowe.
2078
2079         [WinCairo] Adds a build slave.
2080         https://bugs.webkit.org/show_bug.cgi?id=46360
2081
2082         * BuildSlaveSupport/build.webkit.org-config/config.json: Add
2083         entries for a debug build of the WinCairo port.
2084         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add
2085         platform flag to configuration for wincairo (like gtk, chromium, etc.)
2086         * Scripts/build-webkit: Change 'cairo-win32' labeling to 'wincairo'
2087         * Scripts/webkitdirs.pm: Change 'cairo-win32' labeling to 'wincairo'
2088
2089 2010-09-29  Adam Barth  <abarth@webkit.org>
2090
2091         Reviewed by Eric Seidel.
2092
2093         Move more SheriffBot smarts into FailureMap
2094         https://bugs.webkit.org/show_bug.cgi?id=46703
2095
2096         This patch pushes the FailureMap model object further into the
2097         SheriffBot machine.  In addition, it moves a couple operations on this
2098         object from SheriffBot itself to the model.
2099
2100         Eventually, FailureMap will be the canonical context object for
2101         SheriffBot operations.  FailureMap represents a map of the current
2102         failures on the bots that might require remediation.
2103
2104         * Scripts/webkitpy/common/net/failuremap.py:
2105         * Scripts/webkitpy/common/net/regressionwindow.py:
2106         * Scripts/webkitpy/tool/commands/queries.py:
2107         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2108         * Scripts/webkitpy/tool/mocktool.py:
2109
2110 2010-09-29  Tony Chang  <tony@chromium.org>
2111
2112         Reviewed by James Robinson.
2113
2114         [chromium] enable -Werror for DRT and webkit_unit_tests on Linux
2115         https://bugs.webkit.org/show_bug.cgi?id=46829
2116
2117         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
2118         (DRTDevToolsClient::DRTDevToolsClient):
2119         * DumpRenderTree/chromium/TestShell.cpp:
2120         (TestShell::TestShell):
2121         * DumpRenderTree/chromium/WebViewHost.cpp:
2122         (WebViewHost::postAccessibilityNotification):
2123         (WebViewHost::WebViewHost):
2124
2125 2010-09-29  Chris Fleizach  <cfleizach@apple.com>
2126
2127         Reviewed by Darin Adler.
2128
2129         AX: implement CSS3 Speech "speak"
2130         https://bugs.webkit.org/show_bug.cgi?id=46827
2131
2132         * DumpRenderTree/AccessibilityUIElement.cpp:
2133         (speakCallback):
2134         (AccessibilityUIElement::speak):
2135         (AccessibilityUIElement::getJSClass):
2136         * DumpRenderTree/AccessibilityUIElement.h:
2137         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2138         (AccessibilityUIElement::speak):
2139
2140 2010-09-29  Mihai Parparita  <mihaip@chromium.org>
2141
2142         Reviewed by Adam Barth.
2143
2144         Record bot ID when updating queue status
2145         https://bugs.webkit.org/show_bug.cgi?id=46764
2146         
2147         Since we now have multiple bots handling patches from the commit queue,
2148         we need to differentiate status updates from them, so that we can group
2149         the queue status page in a less confusing way.
2150
2151         * QueueStatusServer/handlers/updatestatus.py: Accept bot_id as input
2152         * QueueStatusServer/model/queuestatus.py: Add bot_id property
2153         * QueueStatusServer/templates/updatestatus.html: Add bot_id input
2154         * Scripts/webkitpy/common/net/bugzilla_unittest.py: Extract MockBrowser
2155         * Scripts/webkitpy/common/net/statusserver.py: Add bot_id
2156         * Scripts/webkitpy/common/net/statusserver_unittest.py: Added.
2157         * Scripts/webkitpy/tool/main.py: Add --bot-id
2158         * Scripts/webkitpy/tool/mocktool.py: Add MockBrowser
2159
2160 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
2161
2162         No review.
2163         
2164         References always refert to a file in .xht format, even
2165         for HTML tests, so fix their loading.
2166
2167         * CSSTestSuiteHarness/harness/harness.js:
2168         (TestSuite.prototype.loadRef):
2169
2170 2010-09-28  Johnny Ding  <jnd@chromium.org>
2171
2172         Reviewed by Adam Barth.
2173
2174         https://bugs.webkit.org/show_bug.cgi?id=41292
2175         Add a new parameter to the test plugin to allow specifying a script 
2176         and a mouse/keyboard event. The specified script will be evaluated
2177         in the browser when the specified event is received by the plugin.
2178
2179         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2180         (pluginAllocate):
2181         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
2182         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2183         (NPP_New):
2184         (handleEventCarbon):
2185         (handleEventCocoa):
2186
2187 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
2188
2189         Fix export by adding missing argument.
2190
2191         * CSSTestSuiteHarness/harness/harness.js:
2192         (TestSuite.prototype.showResultsForAllTests):
2193
2194 2010-09-28  Kevin Ollivier  <kevino@theolliviers.com>
2195
2196         [wx] Build fix, add missing import.
2197
2198         * wx/packaging/build-win-installer.py:
2199
2200 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
2201
2202         No review
2203         
2204         Show which tests have been run by dimming them out in the test list.
2205         
2206         Adjust some element sizes.
2207         
2208         * CSSTestSuiteHarness/harness/harness.css:
2209         (#test-list > option.untested):
2210         (#test-list > option.completed):
2211         (#output):
2212         (.output-options):
2213         * CSSTestSuiteHarness/harness/harness.js:
2214         (Test):
2215         (TestSuite.prototype.fillTestList):
2216         (TestSuite.prototype.updateTestList):
2217         (TestSuite.prototype.setSelectedChapter):
2218         (TestSuite.prototype.recordResult):
2219         (TestSuite.prototype.markTestCompleted):
2220         (TestSuite.prototype.testCompletionStateChanged):
2221         (TestSuite.prototype.loadTestStatus):
2222
2223 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
2224
2225         No review.
2226         
2227         Implement export of various queries on the test database, sharing
2228         code with that which displays results inline.
2229
2230         * CSSTestSuiteHarness/harness/harness.js:
2231         ():
2232         (TestSuite.prototype.exportResultsCompletion.var):
2233         (TestSuite.prototype.exportResultsCompletion):
2234         (TestSuite.prototype.showResultsForCompletedTests):
2235         (TestSuite.prototype.exportResultsForCompletedTests):
2236         (TestSuite.prototype.showResultsForAllTests):
2237         (TestSuite.prototype.exportResultsForAllTests):
2238         (TestSuite.prototype.exportResultsForTestsNotRun):
2239         (TestSuite.prototype.exportResultsForTestsWithStatus):
2240         (TestSuite.prototype.exportResultsForTestsWithMismatchedResults):
2241
2242 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
2243
2244         No review.
2245
2246         Work around uncertainty about the order of database
2247         transactions when creating the database, so that we don't
2248         try to query the table before it has been created.
2249
2250         * CSSTestSuiteHarness/harness/harness.js:
2251         (TestSuite):
2252         (TestSuite.prototype.databaseCreated):
2253         (TestSuite.prototype.storeTestResult):
2254         (TestSuite.prototype.populateDatabaseFromTestInfoData):
2255         (TestSuite.prototype.queryDatabaseForTestsWithStatus):
2256         (TestSuite.prototype.queryDatabaseForTestsWithMixedStatus):
2257         (TestSuite.prototype.queryDatabaseForCompletedTests):
2258         (TestSuite.prototype.queryDatabaseForTestsNotRun):
2259
2260 2010-09-28  Tony Chang  <tony@chromium.org>
2261
2262         Reviewed by Eric Seidel.
2263
2264         add python keyring support to webkit-patch
2265         https://bugs.webkit.org/show_bug.cgi?id=41269
2266
2267         * Scripts/webkitpy/common/net/credentials.py: Add the ability to read passwords using
2268             the python keyring module
2269         * Scripts/webkitpy/common/net/credentials_unittest.py:
2270         * Scripts/webkitpy/common/system/user.py: Allow confirm() to default to no and add testing params.
2271         * Scripts/webkitpy/common/system/user_unittest.py:
2272         * Scripts/webkitpy/tool/mocktool.py:
2273
2274 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
2275
2276         Reviewed by Gustavo Noronha Silva.
2277
2278         [Cairo] FreeType fonts should obey FontConfig hinting/anti-aliasing settings
2279         https://bugs.webkit.org/show_bug.cgi?id=46740
2280
2281         * DumpRenderTree/gtk/fonts/fonts.conf: Add specialized variants of common
2282         fonts which can be used to fully test FontConfig rendering settings.
2283
2284 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
2285
2286         Reviewed by Gustavo Noronha Silva.
2287
2288         [gtk] Fedora has a different path for the liberation fonts
2289         https://bugs.webkit.org/show_bug.cgi?id=46709
2290
2291         When searching for DRT fonts, also look in the path where those fonts
2292         are commonly found on Fedora systems.
2293
2294         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2295         (initializeFonts): Include logic for looking for Fedora-style font paths.
2296
2297 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
2298
2299         Reviewed by Andreas Kling.
2300
2301         run-webkit-tests needs an updated list of directories with webgl tests
2302         https://bugs.webkit.org/show_bug.cgi?id=46747
2303
2304         Update the list of directories containing WebGL tests and a unit test
2305         which depends on this list.
2306
2307         * Scripts/old-run-webkit-tests: Update the list of directories.
2308         * Scripts/webkitpy/layout_tests/port/webkit.py: Ditto.
2309         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Update the expected result.
2310
2311 2010-09-28  Adam Barth  <abarth@webkit.org>
2312
2313         Reviewed by Eric Seidel.
2314
2315         Introduce FailureMap to summaries the failures status of all the bots
2316         https://bugs.webkit.org/show_bug.cgi?id=46700
2317
2318         This patch gives the SheriffBot a handle on the list of failing tests.
2319
2320         * Scripts/webkitpy/common/net/buildbot.py:
2321         * Scripts/webkitpy/common/net/failuremap.py: Added.
2322         * Scripts/webkitpy/tool/commands/queries.py:
2323         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2324         * Scripts/webkitpy/tool/mocktool.py:
2325
2326 2010-09-28  Adam Roben  <aroben@apple.com>
2327
2328         Update for the addition of WKPageUIClient::didNotHandleKeyEvent
2329
2330         Fixes <http://webkit.org/b/46660> <rdar://problem/8483465> Need API to
2331         tell a WebKit2 client application that a key event was not handled
2332
2333         Reviewed by Kenneth Rohde Christiansen and Sam Weinig.
2334
2335         * MiniBrowser/mac/BrowserWindowController.m:
2336         (-[BrowserWindowController awakeFromNib]):
2337         * MiniBrowser/win/BrowserView.cpp:
2338         (BrowserView::create):
2339         * WebKitTestRunner/TestController.cpp:
2340         (WTR::createOtherPage):
2341         (WTR::TestController::initialize):
2342
2343 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
2344
2345         Unreviewed.
2346
2347         Update the CSSTestSuiteHarness to not scrape the XHTML chapter files
2348         for the test order, but instead use information from testinfo.data.
2349         
2350         * CSSTestSuiteHarness/harness/harness.html:
2351         * CSSTestSuiteHarness/harness/harness.js:
2352
2353 2010-09-28  Kevin Ollivier  <kevino@theolliviers.com>
2354
2355         [wx] Build fix, don't try to get the svn revision from the git repo when packaging,
2356         it causes the process to hang on the gitorious repo.
2357
2358         * wx/packaging/build-mac-installer.py:
2359         * wx/packaging/build-win-installer.py:
2360
2361 2010-09-28  Adam Roben  <aroben@apple.com>
2362
2363         Test that a plugin's HWND is sized/positioned before NPP_SetWindow is
2364         called
2365
2366         Reviewed by Anders Carlsson.
2367
2368         Test for <http://webkit.org/b/46716> <rdar://problem/8482014>
2369         Full-page Adobe Reader does not paint until window is resized
2370
2371         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2372         (PluginTest::NPP_SetWindow): Added. Just returns NPERR_NO_ERROR at
2373         this level.
2374
2375         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Declared
2376         NPP_SetWindow.
2377
2378         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp: Added.
2379         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Checks that
2380         the plugin's HWND has a non-zero size and that its size/position
2381         matches that specified in the NPWindow.
2382
2383         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2384         (NPP_SetWindow): Call through to the PluginTest.
2385
2386         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2387         Added WindowGeometryInitializedBeforeSetWindow.cpp, and let VS reorder
2388         the files as it saw fit.
2389
2390 2010-09-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
2391
2392         Reviewed by Andreas Kling.
2393
2394         [Qt] Remove support for Qt 4.5
2395         https://bugs.webkit.org/show_bug.cgi?id=46718
2396
2397         Remove the code for versions of Qt prior to 4.6.
2398
2399         * DumpRenderTree/qt/EventSenderQt.cpp:
2400         (EventSender::addTouchPoint):
2401         (EventSender::updateTouchPoint):
2402         (EventSender::setTouchModifier):
2403         (EventSender::touchStart):
2404         (EventSender::touchMove):
2405         (EventSender::touchEnd):
2406         (EventSender::clearTouchPoints):
2407         (EventSender::releaseTouchPoint):
2408         (EventSender::sendTouchEvent):
2409         * DumpRenderTree/qt/EventSenderQt.h:
2410         * DumpRenderTree/qt/TextInputControllerQt.cpp:
2411         (TextInputController::setMarkedText):
2412         * QtTestBrowser/launcherwindow.cpp:
2413         (LauncherWindow::LauncherWindow):
2414         (LauncherWindow::initializeView):
2415         (LauncherWindow::createChrome):
2416         (LauncherWindow::sendTouchEvent):
2417         (LauncherWindow::eventFilter):
2418         (LauncherWindow::applyZoom):
2419         (LauncherWindow::setTouchMocking):
2420         * QtTestBrowser/launcherwindow.h:
2421         * QtTestBrowser/utils.cpp:
2422         (urlFromUserInput):
2423         * QtTestBrowser/webview.cpp:
2424         (WebViewGraphicsBased::animatedFlip):
2425         (WebViewGraphicsBased::animatedYFlip):
2426         * QtTestBrowser/webview.h:
2427         (WebViewGraphicsBased::setYRotation):
2428
2429 2010-09-28  İsmail Dönmez  <ismail@namtrac.org>
2430
2431         Reviewed by Andreas Kling.
2432
2433         Fix DRT compilation on WinCE. Introduce a WCECOMPAT variable
2434         which should point to wcecompat installation. Needs wcecompat
2435         library from http://github.com/mauricek/wcecompat .
2436
2437         * DumpRenderTree/qt/DumpRenderTree.pro:
2438         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2439         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2440
2441 2010-09-28  Daniel Bates  <dbates@rim.com>
2442
2443         Rollout changeset 68493 <http://trac.webkit.org/changeset/68493>
2444         <https://bugs.webkit.org/show_bug.cgi?id=39136>
2445
2446         Rollout changeset 68493 because it broke Sheriffbot's rollout feature.
2447         In particular, this change caused Sheriffbot to raise an exception when
2448         trying to parse the bug id on a bug page. We need to look into this
2449         some more.
2450
2451         * Scripts/webkitpy/common/net/bugzilla.py:
2452         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
2453         * Scripts/webkitpy/tool/bot/sheriff.py:
2454         * Scripts/webkitpy/tool/commands/download.py:
2455         * Scripts/webkitpy/tool/commands/queues.py:
2456         * Scripts/webkitpy/tool/commands/upload.py:
2457         * Scripts/webkitpy/tool/steps/closebug.py:
2458         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
2459         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2460         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
2461
2462 2010-09-28  Adam Barth  <abarth@webkit.org>
2463
2464         Reviewed by Eric Seidel.
2465
2466         Move RegressionWindow further up the dependency chain
2467         https://bugs.webkit.org/show_bug.cgi?id=46698
2468
2469         Baby steps towards pushing this information into bug posts.
2470
2471         * Scripts/webkitpy/common/net/buildbot.py:
2472         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2473         * Scripts/webkitpy/common/net/regressionwindow.py:
2474         * Scripts/webkitpy/tool/commands/queries.py:
2475
2476 2010-09-27  Daniel Bates  <dbates@rim.com>
2477
2478         Reviewed by Adam Barth.
2479
2480         sheriffbot can't roll out security patches
2481         https://bugs.webkit.org/show_bug.cgi?id=39136
2482
2483         Make SheriffBot determine if it's authorized to view a bug
2484         whose change it wants to rollout before it tries to rollout
2485         the change.
2486
2487         Moreover, make both webkit-patch and Sheriffbot provide human-
2488         readable error messages when they are not authorized to view
2489         a bug and when a bug number is invalid.
2490
2491         Currently, Sheriffbot does not parse Bugzilla bugs for
2492         <bug error="...">, which indicates an error when retrieving
2493         a bug. In particular, error="NotPermitted" if a person (or bot)
2494         is not authorized to view a bug. For such error="NotPermitted" bugs,
2495         Sheriffbot raises an exception when parsing the bug report and
2496         this exception does not explicitly indicate Sheriffbot's lack
2497         of authorization. Instead, Sheriffbot should explicitly check
2498         for the presence <bug error="..."> before operating on a bug
2499         and error with a human-readable message if it's not permitted
2500         to view it.
2501
2502         * Scripts/webkitpy/common/net/bugzilla.py: Added BugzillaError class.
2503         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
2504           - Added unit test test_bug_parsing_for_bugzilla_not_permitted_error().
2505           - Added unit test test_bug_parsing_for_bugzilla_not_found_error().
2506           - Added unit test test_bug_parsing_for_bugzilla_invalid_bug_id_error().
2507         * Scripts/webkitpy/tool/bot/sheriff.py: Modified to catch BugzillaError.
2508         * Scripts/webkitpy/tool/commands/download.py: Ditto.
2509         * Scripts/webkitpy/tool/commands/queues.py: Ditto.
2510         * Scripts/webkitpy/tool/commands/upload.py: Ditto.
2511         * Scripts/webkitpy/tool/steps/closebug.py: Ditto.
2512         * Scripts/webkitpy/tool/steps/obsoletepatches.py: Ditto.
2513         * Scripts/webkitpy/tool/steps/preparechangelog.py: Ditto.
2514         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: Ditto.
2515
2516 2010-09-27  Adam Barth  <abarth@webkit.org>
2517
2518         Reviewed by Eric Seidel.
2519
2520         Expose more more failure information from Buildbot to SheriffBot
2521         https://bugs.webkit.org/show_bug.cgi?id=46697
2522
2523         This patch moves the information about what tests failured closer to
2524         SheriffBot.  There are still a couple more patches to go before
2525         SheriffBot can post this information to bugs, but this is a step in
2526         that direction.  Yay for unit tests, which caught some bugs in earlier
2527         versions of this patch.
2528
2529         * Scripts/webkitpy/common/net/buildbot.py:
2530         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2531         * Scripts/webkitpy/common/net/regressionwindow.py: Added.
2532         * Scripts/webkitpy/tool/commands/queries.py:
2533
2534 2010-09-27  Eric Seidel  <eric@webkit.org>
2535
2536         Unreviewed.  Fixing 500 error seen in the status server.
2537
2538         It turns out that a = b = []; b.append(1); then a[0] will be 1!
2539         This should have been obvious to me, I guess, but it was not what I was expecting.
2540
2541         * QueueStatusServer/model/activeworkitems.py:
2542
2543 2010-09-27  Adam Barth  <abarth@webkit.org>
2544
2545         Reviewed by Eric Seidel.
2546
2547         commit-queue should reject patches that fail to land
2548         https://bugs.webkit.org/show_bug.cgi?id=46694
2549
2550         This can happen, for example, if there's no reviewer.  Without this
2551         patch, we'll keep retrying the patch.
2552
2553         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2554         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2555
2556 2010-09-27  Simon Fraser  <simon.fraser@apple.com>
2557
2558         Rubber-stamped by Adele Peterson.
2559
2560         Add a harness for running the CSS 2.1 test suite.
2561         
2562         This harness assumes that you've got a local a copy of the suite
2563         adjacent to the 'harness' directory.
2564         
2565         The harness lets you go through the tests in chapter order,
2566         denoting pass/fail/skipped for each test.
2567         
2568         It uses a client-side database to store the results of testing.
2569
2570         * CSSTestSuiteHarness/harness/harness.css: Added.
2571         * CSSTestSuiteHarness/harness/harness.html: Added.
2572         * CSSTestSuiteHarness/harness/harness.js: Added.
2573
2574 2010-09-27  Eric Seidel  <eric@webkit.org>
2575
2576         Reviewed by Adam Barth.
2577
2578         Patch locks should expire if a patch is marked for retry
2579         https://bugs.webkit.org/show_bug.cgi?id=46682
2580
2581         This was part Adam's original CommitQueueTask design,
2582         but support for it was missing from the server.
2583         I added the support, but triggering lock-release based on this
2584         special "retry" status feels a bit strange so I added a FIXME.
2585
2586         I also changed the text in queuestatus.html to say "Lock Acquired"
2587         since "Last Activity" isn't really true.  We only update the lock
2588         date when the patch is started, not on every status update.
2589
2590         I also noticed an exception in next-patch, which I fixed by re-writing
2591         the unzip logic in activeworkitems.py again.
2592
2593         * QueueStatusServer/handlers/updatestatus.py:
2594         * QueueStatusServer/model/activeworkitems.py:
2595         * QueueStatusServer/templates/queuestatus.html:
2596
2597 2010-09-27  Tony Chang  <tony@chromium.org>
2598
2599         Reviewed by David Levin.
2600
2601         [chromium] fix a warning when compiling DRT on 32-bit linux
2602         https://bugs.webkit.org/show_bug.cgi?id=46641
2603
2604         * DumpRenderTree/chromium/TestEventPrinter.cpp:
2605         (DRTPrinter::handleImage):
2606
2607 2010-09-27  Eric Seidel  <eric@webkit.org>
2608
2609         Reviewed by Adam Barth.
2610
2611         queue-status should report when the patch was last locked to a queue
2612         https://bugs.webkit.org/show_bug.cgi?id=46674
2613
2614         This isn't necessarily the best way to expose this information
2615         but having this accessible via the web interface is very
2616         useful until we come up with a nicer way to display this.
2617
2618         I also cleaned up the code in activeworkitems.py a little
2619         to use list comprehensions and to have the code work with
2620         pairs instead of two lists at once.  Eventually I think those
2621         item/time pairs need to be their own little helper class.
2622
2623         * QueueStatusServer/handlers/queuestatus.py:
2624         * QueueStatusServer/model/activeworkitems.py:
2625         * QueueStatusServer/templates/queuestatus.html:
2626
2627 2010-09-27  Tony Chang  <tony@chromium.org>
2628
2629         Reviewed by David Levin.
2630
2631         [chromium] fix detection of missing fonts on DRT
2632         https://bugs.webkit.org/show_bug.cgi?id=46651
2633
2634         * DumpRenderTree/chromium/TestShellGtk.cpp:
2635         (setupFontconfig):  Only print an error message if lohit isn't found in both locations.
2636
2637 2010-09-27  Tony Chang  <tony@chromium.org>
2638
2639         Reviewed by Dimitri Glazkov.
2640
2641         add webkit unit tests to the chromium testers
2642         https://bugs.webkit.org/show_bug.cgi?id=46669
2643
2644         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2645         * Scripts/run-chromium-webkit-unit-tests: Fix a bug where we weren't using the right configuration.
2646
2647 2010-09-27  Kwang Yul Seo  <skyul@company100.net>
2648
2649         Unreviewed.
2650
2651         Adding myself to the committers list.
2652
2653         * Scripts/webkitpy/common/config/committers.py:
2654
2655 2010-09-27  Mihai Parparita  <mihaip@chromium.org>
2656
2657         Reviewed by Eric Seidel.
2658
2659         webkitpy.common.system.user_unittest.UserTest.test_prompt_with_list spams the console
2660         https://bugs.webkit.org/show_bug.cgi?id=46634
2661         
2662         Use OutputCapture to prevent console spam (and also check for expected
2663         output).
2664
2665         * Scripts/webkitpy/common/system/user_unittest.py:
2666
2667 2010-09-27  Eric Seidel  <eric@webkit.org>
2668
2669         Reviewed by James Robinson.
2670
2671         start-commit-queue should abort any rebases in progress
2672         https://bugs.webkit.org/show_bug.cgi?id=46640
2673
2674         webkit-patch commit-queue would do this itself, but this just
2675         helps ensure that the commit-queue script is properly updated
2676         before we run it (in the case where a previous rebase is in
2677         progress the git svn rebase would not work before we run the
2678         commit-queue).
2679
2680         * EWSTools/start-commit-queue.sh:
2681
2682 2010-09-18  Martin Robinson  <mrobinson@igalia.com>
2683
2684         Reviewed by Gustavo Noronha Silva.
2685
2686         [GTK] Clean up the DRT fonts.conf and switch to Liberation
2687         https://bugs.webkit.org/show_bug.cgi?id=46038
2688
2689         Switch to Liberation fonts for GTK+ layout tests. This will make our
2690         test results metric-compatible with many Windows/Chromium results. It
2691         also simplifies the fonts.conf that we load and prepares the way for
2692         fixing many font bugs.
2693
2694         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2695         (initializeFonts): Initialize a known list of fonts instead of loading
2696         every font in the WEBKIT_TESTFONTS directory.
2697         * DumpRenderTree/gtk/fonts.conf: Removed.
2698         * DumpRenderTree/gtk/fonts/AHEM____.TTF: Copied from WebKitTools/DumpRenderTree/qt/fonts/AHEM____.TTF.
2699         * DumpRenderTree/gtk/fonts/fonts.conf: Added.
2700         * GNUmakefile.am: Modify FONTS_CONF_FILE to be FONTS_CONF_DIR, so that
2701         we can load both fonts.conf and AHEM____.TTF from this location.
2702         * Scripts/old-run-webkit-tests: Remove the check for WEBKIT_TESTFONTS, since
2703         it is no longer used.
2704
2705 2010-09-26  Mihai Parparita  <mihaip@chromium.org>
2706
2707         Reviewed by Ojan Vafai.
2708
2709         new-run-webkit-httpd fails if Perl is not installed
2710         https://bugs.webkit.org/show_bug.cgi?id=46602
2711         
2712         Make Port._read_configuration catch all exceptions, since trying to run
2713         perl (because of _webkit_build_directory) when it's not installed throws
2714         a WindowsError or OSError, not an IOError (this became an issue after 
2715         r68268, since ChromiumPort ends up calling Port.default_configuration in
2716         its constructor, which means that we're ending up on this codepath in
2717         non-NRWT cases too, e.g. for the Chromium NaCl tests, which use
2718         new-run-webkit-httpd).
2719
2720         * Scripts/webkitpy/layout_tests/port/base.py:
2721         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2722
2723 2010-09-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2724
2725         Reviewed by Antonio Gomes.
2726
2727         [EFL] Add setting API to set a local storage database path.
2728         https://bugs.webkit.org/show_bug.cgi?id=45446
2729
2730         Add a setting API to set local storage database path.
2731
2732         * EWebLauncher/main.c:
2733         (on_key_down):
2734         (browserCreate):
2735         (main):
2736
2737 2010-09-26  Sam Weinig  <sam@webkit.org>
2738
2739         Reviewed by Anders Carlsson.
2740
2741         Move shared WebKit2 API (used by both bundle and main API) to WebKit2/Shared/API
2742         https://bugs.webkit.org/show_bug.cgi?id=46587
2743
2744         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2745
2746 2010-09-26  Antonio Gomes  <agomes@rim.com>
2747
2748         Reviewed by Kenneth Rohde Christiansen.
2749
2750         DRT/Mac nodesFromRect support
2751
2752         [Mac][DRT] Implement LayoutTestController::nodesFromRect
2753         https://bugs.webkit.org/show_bug.cgi?id=46580
2754
2755         Implements LayoutTestController::nodesFromRect for Mac DRT, and
2756         adding stubs for GTK+ and Windows.
2757
2758         * DumpRenderTree/LayoutTestController.cpp:
2759         (nodesFromRectCallback):
2760         (LayoutTestController::staticFunctions):
2761         * DumpRenderTree/LayoutTestController.h:
2762         (LayoutTestController::LayoutTestController::nodesFromRect):
2763         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2764         (LayoutTestController::nodesFromRect):
2765
2766 2010-09-25  Nicolas Weber  <thakis@chromium.org>
2767
2768         Reviewed by Adam Barth.
2769
2770         https://bugs.webkit.org/show_bug.cgi?id=46555
2771         Fix typo in prepare-ChangeLog's help output.
2772
2773         * Scripts/prepare-ChangeLog:
2774
2775 2010-09-24  Sam Weinig  <sam@webkit.org>
2776
2777         Reviewed by Darin Adler.
2778
2779         Implement WebKit2 callback equivalent to -[WebUIDelegate mouseDidMoveOverElement:modifierFlags:]
2780         <rdar://problem/8359279>
2781         https://bugs.webkit.org/show_bug.cgi?id=46546
2782
2783         * MiniBrowser/mac/BrowserWindowController.m:
2784         (mouseDidMoveOverElement):
2785         (-[BrowserWindowController awakeFromNib]):
2786         * MiniBrowser/win/BrowserView.cpp:
2787         (mouseDidMoveOverElement):
2788         (BrowserView::create):
2789         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2790         (WTR::InjectedBundlePage::InjectedBundlePage):
2791         * WebKitTestRunner/TestController.cpp:
2792         (WTR::createOtherPage):
2793         (WTR::TestController::initialize):
2794
2795 2010-09-24  Mihai Parparita  <mihaip@chromium.org>
2796
2797         Reviewed by Adam Barth.
2798
2799         Allow rebaselines for webkit-patch rebaseline to be chosen
2800         https://bugs.webkit.org/show_bug.cgi?id=46407
2801         
2802         Instead of always rebaselining all failing tests, allow a subset to be
2803         chosen.
2804
2805         * Scripts/webkitpy/common/system/user.py:
2806         * Scripts/webkitpy/tool/commands/rebaseline.py:
2807
2808 2010-09-24  Ryosuke Niwa  <rniwa@webkit.org>
2809
2810         Reviewed by Tony Chang.
2811
2812         [chromium] Implement TextInputController::firstRectForCharacterRange
2813         https://bugs.webkit.org/show_bug.cgi?id=38100
2814
2815         Implemented TextInputController::firstRectForCharacterRange for chromium platform.
2816         No new tests are added since we need to implement the same feature in chromium side
2817         in order to enable any tests that uses this function.
2818
2819         * DumpRenderTree/chromium/TextInputController.cpp:
2820         (TextInputController::firstRectForCharacterRange): Added.
2821
2822 2010-09-24  Adam Barth  <abarth@webkit.org>
2823
2824         Reviewed by Eric Seidel.
2825
2826         commit-queue reports land failures as "PASS"
2827         https://bugs.webkit.org/show_bug.cgi?id=46530
2828
2829         We were ignoring the return value of land instead of passing it back to
2830         CommitQueue.  Of course, this was the one case I forgot to test!
2831
2832         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2833         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2834
2835 2010-09-24  Kenichi Ishibashi  <bashi@google.com>
2836
2837         Reviewed by Eric Seidel.
2838
2839         new-run-webkit-tests prints out nothing when build-dumprendertree fails
2840         https://bugs.webkit.org/show_bug.cgi?id=37563
2841
2842         Print error message when build-dumprendertree fails.
2843
2844         * Scripts/webkitpy/layout_tests/port/webkit.py:
2845         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2846
2847 2010-09-24  Mihai Parparita  <mihaip@chromium.org>
2848
2849         Reviewed by Tony Chang.
2850
2851         NRWT doesn't respect config set with set-webkit-configuration
2852         https://bugs.webkit.org/show_bug.cgi?id=46278
2853         
2854         Use Port.default_configuration() instead of hardcoding Release in
2855         ChromiumPort configuration initialization, so that we still inherit the
2856         configuration set by set-webkit-configuration.
2857
2858         * Scripts/webkitpy/layout_tests/port/chromium.py:
2859         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2860
2861 2010-09-24  Chang Shu  <chang.shu@nokia.com>
2862
2863         Reviewed by Csaba Osztrogonác.
2864
2865         [Qt] Fix the code to check file existence.
2866         https://bugs.webkit.org/show_bug.cgi?id=46465
2867
2868         * QtTestBrowser/main.cpp:
2869         (main):
2870
2871 2010-09-23  Tony Chang  <tony@chromium.org>
2872
2873         Unreviewed, rolling out r68232.
2874         http://trac.webkit.org/changeset/68232
2875
2876         Broken NRWT on the canary bots.
2877
2878         * Scripts/webkitpy/layout_tests/port/chromium.py:
2879
2880 2010-09-23  Dirk Pranke  <dpranke@chromium.org>
2881
2882         Unreviewed, build fix.
2883
2884         r68008 broke new-run-webkit-tests in that the chromium ports no
2885         longer respect set-webkit-configuration. The correct fix for this
2886         is being pursued in bug 46278 (along with a bunch of unit tests),
2887         but in the meantime I'm reverting the particular lines that broke
2888         things. This was tested by hand.
2889
2890         * Scripts/webkitpy/layout_tests/port/chromium.py:
2891
2892 2010-09-23  Sam Weinig  <sam@webkit.org>
2893
2894         Reviewed by Anders Carlsson.
2895
2896         WebKit2 API: Need way to know when a frame is removed from the hierarchy
2897         <rdar://problem/8414062>
2898         https://bugs.webkit.org/show_bug.cgi?id=46432
2899
2900         * MiniBrowser/mac/BrowserWindowController.m:
2901         (didRemoveFrameFromHierarchy):
2902         (-[BrowserWindowController awakeFromNib]):
2903         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2904         (WTR::InjectedBundlePage::InjectedBundlePage):
2905         * WebKitTestRunner/TestController.cpp:
2906         (WTR::TestController::initialize):
2907
2908 2010-09-23  Tony Chang  <tony@chromium.org>
2909
2910         Reviewed by Dimitri Glazkov.
2911
2912         [chromium] implement layoutTestController.sampleSVGAnimationForElementAtTime
2913         https://bugs.webkit.org/show_bug.cgi?id=46426
2914
2915         * DumpRenderTree/chromium/LayoutTestController.cpp:
2916         (LayoutTestController::LayoutTestController):
2917         (LayoutTestController::sampleSVGAnimationForElementAtTime):
2918         * DumpRenderTree/chromium/LayoutTestController.h:
2919
2920 2010-09-23  Martin Robinson  <mrobinson@igalia.com>
2921
2922         Reviewed by Nate Chapin.
2923
2924         [GTK] r68199 introduced two test failures
2925         https://bugs.webkit.org/show_bug.cgi?id=46424
2926
2927         Fix a regression handling preference overrides that are attached to boolean properties.
2928
2929         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2930         (LayoutTestController::overridePreference): g_strcasecmp returns 0 when strings match
2931         so we must check for that when converting a string to a boolean.
2932
2933 2010-09-23  Dimitri Glazkov  <dglazkov@chromium.org>
2934
2935         Reviewed by David Levin.
2936
2937         Fix a condition check in ServerProcess, which becomes relevant when reading binary data.
2938         https://bugs.webkit.org/show_bug.cgi?id=46406
2939
2940         This breaks when the method is called with specified size of data (image data), and the
2941         buffer hasn't yet reached this size.
2942
2943         * Scripts/webkitpy/layout_tests/port/server_process.py: Changed to check for values of
2944           index larger than 0.
2945
2946 2010-09-23  Martin Robinson  <mrobinson@igalia.com>
2947
2948         Reviewed by Nate Chapin.
2949
2950         [GTK] Some tests from r68174 fail on the GTK+ bots
2951         https://bugs.webkit.org/show_bug.cgi?id=46396
2952
2953         Simplify LayoutTestController::overridePreference to make it easier for
2954         people unfamiliar with the code to keep the list of preferences up to date.
2955         Add the conversion for enable-hyperlink-auditing.
2956
2957         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2958         (LayoutTestController::overridePreference): Use a simple if-else block to determine
2959         out the property name for overrridePreference. Also simplify the logic for setting
2960         string properties. Add the conversion for enable-hyperlink-auditing.
2961
2962 2010-09-23  Tony Chang  <tony@chromium.org>
2963
2964         Reviewed by David Levin.
2965
2966         [chromium] add caretBrowsingEnabled to WebSettings and DRT
2967         https://bugs.webkit.org/show_bug.cgi?id=46388
2968
2969         * DumpRenderTree/chromium/LayoutTestController.cpp:
2970         (LayoutTestController::overridePreference):
2971         * DumpRenderTree/chromium/WebPreferences.cpp:
2972         (WebPreferences::reset):
2973         (WebPreferences::applyTo):
2974         * DumpRenderTree/chromium/WebPreferences.h:
2975
2976 2010-09-23  Nate Chapin  <japhet@chromium.org>
2977
2978         Reviewed by Darin Fisher.
2979
2980         Allow DRT to toggle hyperlink auditing (i.e., <a ping>).
2981         https://bugs.webkit.org/show_bug.cgi?id=30458
2982
2983         * DumpRenderTree/chromium/LayoutTestController.cpp:
2984         (LayoutTestController::overridePreference):
2985         * DumpRenderTree/chromium/WebPreferences.cpp:
2986         (WebPreferences::reset):
2987         (WebPreferences::applyTo):
2988         * DumpRenderTree/chromium/WebPreferences.h:
2989         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2990         (resetDefaultsToConsistentValues):
2991         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2992         (LayoutTestController::overridePreference):
2993
2994 2010-09-21  Stephen White  <senorblanco@chromium.org>
2995
2996         Reviewed by David Levin.
2997
2998         Implement --enable-accelerated-2d-canvas flag in DumpRenderTree.
2999         https://bugs.webkit.org/show_bug.cgi?id=46208
3000
3001         This flag allows the layout tests to be run with or without accelerated
3002         2D canvas rendering.
3003
3004         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3005         (main):
3006         Declare the new flag string, and check for it on startup.
3007         * DumpRenderTree/chromium/TestShell.cpp:
3008         (TestShell::TestShell):
3009         Add a boolean for the new flag, in order to preserve its value over
3010         preferences reset.
3011         (TestShell::resetWebSettings):
3012         Set the new flag to the stored value on reset.
3013         * DumpRenderTree/chromium/TestShell.h:
3014         (TestShell::setAccelerated2dCanvasEnabled):
3015         Add an accessor for the new flag.
3016         * DumpRenderTree/chromium/WebPreferences.cpp:
3017         (WebPreferences::reset):
3018         Initialize the new flag to false.
3019         (WebPreferences::applyTo):
3020         Copy the flag's value to the WebSettings.
3021         * DumpRenderTree/chromium/WebPreferences.h:
3022         Add the new flag.
3023
3024 2010-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3025
3026         Reviewed by Simon Hausmann.
3027
3028         [Qt] Refactor QtWebKitPlatformPlugin interface
3029
3030         Make it easier to keep source-compability for the
3031         QtWebKitPlatformPlugin interface, and run qmake
3032         on the example (but not build) for convenience. 
3033
3034         https://bugs.webkit.org/show_bug.cgi?id=46345
3035
3036         * Scripts/webkitdirs.pm:
3037
3038 2010-09-23  Adam Barth  <abarth@webkit.org>
3039
3040         Reviewed by Eric Seidel.
3041
3042         Tweak some status messages that Eric thought were confusing
3043         https://bugs.webkit.org/show_bug.cgi?id=46342
3044
3045         * Scripts/webkitpy/tool/commands/queues.py:
3046         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3047
3048 2010-09-22  Adam Barth  <abarth@webkit.org>
3049
3050         Reviewed by Eric Seidel.
3051
3052         Fix comm-queue typo
3053         https://bugs.webkit.org/show_bug.cgi?id=46339
3054
3055         We were missing a "self".  The real problem is that we didn't have an
3056         integration test for the failure case.
3057
3058         * Scripts/webkitpy/tool/commands/queues.py:
3059         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3060
3061 2010-09-22  Adam Barth  <abarth@webkit.org>
3062
3063         Reviewed by Eric Seidel.
3064
3065         commit-queue should log more detailed messages to the QueueStatusServer
3066         https://bugs.webkit.org/show_bug.cgi?id=46333
3067
3068         When I created CommitQueueTask, I removed most of the previous logging.
3069         This patch adds back more detailed logging so folks can see their patch
3070         progress through the queue.
3071
3072         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3073         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3074         * Scripts/webkitpy/tool/commands/queues.py:
3075         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3076
3077 2010-09-22  Mihai Parparita  <mihaip@chromium.org>
3078
3079         Reviewed by Darin Fisher.
3080
3081         [Chromium] User style layout tests don't pass on Chromium
3082         https://bugs.webkit.org/show_bug.cgi?id=46069
3083
3084         Fix a typo in LayoutTestController::addUserStyleSheet that was causing a
3085         crash the Chromium DRT. Pass InjectInExistingDocuments to mimic DRT
3086         behavior from other ports.
3087
3088         * DumpRenderTree/chromium/LayoutTestController.cpp:
3089         (LayoutTestController::addUserStyleSheet):
3090
3091 2010-09-22  Brent Fulgham  <bfulgham@webkit.org>
3092
3093         Reviewed by Martin Robinson.
3094
3095         [WinCairo] Part 2: Update WebKitTestRunner and DumpRenderTree Build.
3096         https://bugs.webkit.org/show_bug.cgi?id=46303.
3097
3098         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added.
3099         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Moved
3100         CoreFoundation-specific stuff to new MiniBrowserCoreFoundation
3101         property sheet.
3102         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added.
3103         * MiniBrowser/MiniBrowser.vcproj: Updated configuration to use
3104         appropriate property sheet for the build types.
3105         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Updated the
3106         configuration to use appropriate property sheet for CoreFoundation
3107         and CFLite-style builds.
3108
3109 2010-09-22  Adam Barth  <abarth@webkit.org>
3110
3111         Reviewed by Eric Seidel.
3112
3113         Optimize commit-queue performance for green trees
3114         https://bugs.webkit.org/show_bug.cgi?id=46254
3115
3116         This patch redesigns the controller logic for the commit-queue.  In the
3117         new design, the controller exercises much finer-grained control over
3118         the landing process.  In particular:
3119
3120         - Patches that fail to apply now get rejected almost immediately.
3121         - Patches that fail to build get rejects after two builds (instead of
3122           three builds and one test run).
3123         - Patches that run into a flaky test now get accepted after one build
3124           and two test runs instead of three full build-and-test runs.
3125
3126         The main cost of these optimizations is that we don't find out the tree
3127         has a failing test until the very end of the process, but if the tree
3128         has a busted test, there's not much we can do anyway.  We might as well
3129         burn commit-queue resources spinning optimisticly.
3130
3131         * Scripts/webkitpy/tool/bot/commitqueuetask.py: Added.
3132         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: Added.
3133         * Scripts/webkitpy/tool/commands/queues.py:
3134
3135 2010-09-22  Brent Fulgham  <bfulgham@webkit.org>
3136
3137         Reviewed by Martin Robinson.
3138
3139         [WinCairo] Update WebKitTestRunner and DumpRenderTree Build.
3140         https://bugs.webkit.org/show_bug.cgi?id=46303.
3141
3142         * DumpRenderTree/win/DumpRenderTree.vcproj: Disable local MD5 sources
3143         for Cairo build. Copy wtf MD5 header to ForwardingHeaders for the
3144         WinCairo build.
3145         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added.
3146         * WebKitTestRunner/win/InjectedBundle.vcproj: Update win new *_Cairo
3147         build targets that use the new InjectedBundleCFLite.vsprops file.
3148
3149 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
3150
3151         Unreviewed, build fix.
3152
3153         Fix bustage of rebaseline-chromium-webkit-tests resulting from
3154         r67974. Really need better unit tests for this tool :(
3155
3156         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3157
3158 2010-09-22  Adam Roben  <aroben@apple.com>
3159
3160         Unbreak test-webkitpy
3161
3162         * Scripts/webkitpy/test/main.py:
3163         (Tester.run_tests): Add a line that mysteriously got deleted.
3164
3165 2010-09-22  Adam Roben  <aroben@apple.com>
3166
3167         Make test-webkitpy test WebKit2's scripts
3168
3169         These scripts can't be in WebKitTools due to limitations of Apple's
3170         build process. But that doesn't mean we can't test them!
3171
3172         Fixes <http://webkit.org/b/46297> test-webkitpy should test code in
3173         WebKit2/Scripts
3174
3175         Reviewed by Adam Barth.
3176
3177         * Scripts/test-webkitpy:
3178         (_clean_packages_with_test): Renamed from _clean_webkitpy_with_test.
3179         Now takes an external_package_paths parameter and cleans both webkitpy
3180         and any external packages.
3181         (init): Added an external_package_paths parameter which we pass along
3182         to _clean_packages_with_test.
3183         (top level): Add WebKit2/Scripts/webkit2 as our only external package
3184         and pass it along to init and Tester.run_tests.
3185
3186         * Scripts/webkitpy/test/main.py:
3187         (Tester.run_tests): Added an optional external_package_paths
3188         parameter. We modify sys.path so that the external packages can be
3189         imported, and search for unittest files inside all external packages
3190         in addition to inside webkitpy.
3191
3192 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
3193
3194         Reviewed by Tony Chang.
3195
3196         new-run-webkit-tests: r68063 broke linux python tests
3197
3198         Add a missing "from __future__ import with_statement" to this
3199         new file; the perils of testing only on the Mac and by review :(
3200
3201         https://bugs.webkit.org/show_bug.cgi?id=46293
3202
3203         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3204
3205 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
3206
3207         Reviewed by Tony Chang.
3208
3209         Add a 'chromium-gpu' set of ports that will test the accelerated
3210         GPU paths. This patch adds:
3211
3212         - support for the '--accelerated-compositing' and
3213           'accelerated-2d-canvas' flags to new-run-webkit-tests (and the
3214           'no-' flags)
3215         - adds a new set of Ports that will look under
3216           platform/chromium-gpu-$OS/ for baselines before looking in the
3217           regular chromium search path
3218         - adds a new test_expectations.txt file in platform/chromium-gpu
3219           that skips all but the tests we actually want to run with
3220           acceleration.
3221
3222         This patch will allow us to run both with and without acceleration
3223         and to change the defaults for both the regular and -gpu options
3224         as the code evolves.
3225
3226         We plan to add both --chromium-$OS and --chromium-gpu-$OS runs to
3227         each test bot.
3228
3229         https://bugs.webkit.org/show_bug.cgi?id=46225
3230
3231         * Scripts/webkitpy/layout_tests/port/chromium.py:
3232         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3233         * Scripts/webkitpy/layout_tests/port/factory.py:
3234         * Scripts/webkitpy/layout_tests/port/webkit.py:
3235
3236 2010-09-22  Jamey Hicks  <jamey.hicks@nokia.com>
3237
3238         Reviewed by Kenneth Rohde Christiansen.
3239
3240         [Qt] Web Inspector: Remote Web Inspector support for QtWebKit
3241         https://bugs.webkit.org/show_bug.cgi?id=43988
3242
3243         Runs a web debug server on port specified by QtTestBrowser
3244         argument -remote-inspector-port. Property
3245         _q_webInspectorServerPort of the QWebPage instance will be set
3246         according to the argument. All pages with that property set will
3247         be remotely inspectable.
3248
3249         URL for remote inspection of first QWebPage is
3250             http://localhost:9222/webkit/inspector/inspector.html?page=1
3251         where 1 is the number of the QWebPage instance.
3252
3253         The base URL yields an index page with links to the individual inspectors:
3254             http://localhost:9222/
3255
3256         * QtTestBrowser/launcherwindow.cpp:
3257         (LauncherWindow::init):
3258         * QtTestBrowser/launcherwindow.h:
3259         * QtTestBrowser/main.cpp:
3260         (LauncherApplication::handleUserOptions):
3261
3262 2010-09-22  Adam Roben  <aroben@apple.com>
3263
3264         Fix webkit-patch failure-reason now that build.webkit.org has been
3265         updated
3266
3267         Fixes <http://webkit.org/b/46273> webkit-patch failure-reason crashes
3268         every time
3269
3270         Reviewed by Eric Seidel.
3271
3272         * Scripts/webkitpy/common/net/buildbot.py:
3273         (BuildBot._file_cell_text): Added. Travels down the firstChild chain
3274         looking for an element that contains text, then returns it.
3275         (BuildBot._parse_twisted_file_row): Use _file_cell_text to get the
3276         text out of the cells. This way it doesn't matter whether the cells
3277         have <b> children (as for cells in directory rows) or not (as for
3278         cells in file rows)
3279         (BuildBot._parse_twisted_directory_listing): Look for rows that have
3280         the "directory" or "file" class, rather than rows with any class,
3281         since header rows now have a class attribute.
3282
3283         * Scripts/webkitpy/common/net/buildbot_unittest.py:
3284         (BuildBotTest._example_directory_listing): Updated to more closely
3285         match the markup that build.webkit.org is producing now.
3286
3287 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
3288
3289         Unreviewed, build fix.
3290
3291         new-run-webkit-tests: fix bug introduced in r68008 where if you
3292         specify --chromium and no --platform, and you're running on
3293         windows, you use the 'chromium-win' port by default instead of the
3294         version-specific port. This breaks the buildbots.
3295
3296         It will be good for this refactoring to settle down so I can
3297         rewrite the logic for default ports and the unit tests to be
3298         clearer (and the testing more comprehensive).
3299
3300         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3301
3302 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
3303
3304         Reviewed by Adam Barth.
3305
3306         Modify the Port interface to take only a series of keyword arguments
3307         in the constructor, and modify Port/factory.get() to accomodate that,
3308         and to accept user=XXX as an argument so we can pass
3309         webkitpy.common.system.user.User objects in.
3310
3311         Then, modify new-run-webkit-tests and rebaseline-chromium-webkit-tests
3312         to use the common routine in webkitpy.common.system.user.open_url()
3313         to display HTML files.
3314
3315         There was a routine in the Port interface to do the same thing,
3316         but I see no need for a port-specific hook for this, since it is
3317         something that will always be executed by the host environment
3318         and displaying web pages has nothing to do with running layout tests.
3319
3320         Note that new-run-webkit-tests used to use test_shell to display
3321         the page; this is potentially useful so that you can actually click
3322         from a result to the broken page; however, since DumpRenderTree
3323         doesn't support this functionality, it will be going away eventually.
3324
3325         https://bugs.webkit.org/show_bug.cgi?id=46128
3326
3327         * Scripts/webkitpy/layout_tests/port/base.py:
3328         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3329         * Scripts/webkitpy/layout_tests/port/chromium.py:
3330         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3331         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3332         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3333         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3334         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3335         * Scripts/webkitpy/layout_tests/port/factory.py:
3336         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3337         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3338         * Scripts/webkitpy/layout_tests/port/gtk.py:
3339         * Scripts/webkitpy/layout_tests/port/mac.py:
3340         * Scripts/webkitpy/layout_tests/port/qt.py:
3341         * Scripts/webkitpy/layout_tests/port/test.py:
3342         * Scripts/webkitpy/layout_tests/port/webkit.py:
3343         * Scripts/webkitpy/layout_tests/port/win.py:
3344         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3345         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3346         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3347
3348 2010-09-21  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3349
3350         Reviewed by Kenneth Rohde Christiansen.
3351
3352         [EFL] Get fresh theme when running EWebLauncher
3353         https://bugs.webkit.org/show_bug.cgi?id=46210
3354
3355         If user tried to run EWebLauncher outside of the build tree, it would
3356         not find the theme and fallback to the installed one. However, since
3357         EWebLauncher is not installed, we always want to take the theme from
3358         the just compiled source code. If user had never installed WebKit's
3359         EFL port it could even receive a segv since no theme would be found.
3360
3361         Now EWebLauncher does not fallback to the installed theme and CMake
3362         gives as DATA_DIR the directory of the theme it has just built.
3363
3364         * CMakeListsEfl.txt: Pass the build directory as DATA_DIR to
3365         EWebLauncher.
3366         * EWebLauncher/main.c: Use only the theme from build director. Do not
3367         fallback to others as this could hide real bugs.
3368         (quit):
3369         (browserCreate):
3370         (findThemePath):
3371         (main):
3372
3373 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
3374
3375         Unreviewed, build fix.
3376
3377         Don't pass the --test-shell arg to the Chromium Mac port of DRT;
3378         it just confuses it.
3379
3380         https://bugs.webkit.org/show_bug.cgi?id=46230
3381
3382         * Scripts/webkitpy/layout_tests/port/webkit.py:
3383
3384 2010-09-21  Lucas Forschler  <lforschler@apple.com>
3385
3386         Reviewed by Stephanie Lewis.
3387
3388         Make a new buildbot for Leopard Debug Test
3389
3390         * BuildSlaveSupport/build.webkit.org-config/config.json:
3391
3392 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
3393
3394         Unreviewed, build fix.
3395
3396         Fix breakage of Chromium Mac DRT port caused by r67905.
3397
3398         https://bugs.webkit.org/show_bug.cgi?id=46230
3399
3400         * Scripts/webkitpy/layout_tests/port/webkit.py:
3401
3402 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
3403
3404         Unreviewed, build fix.
3405
3406         Add missing import of 'tempfile'.
3407
3408         * Scripts/webkitpy/layout_tests/port/chromium.py:
3409
3410 2010-09-17  Dirk Pranke  <dpranke@chromium.org>
3411
3412         Reviewed by Ojan Vafai.
3413
3414         new-run-webkit-tests: pull the list of tests from the Port, and
3415            make it possible to run with no actual test files in the filesystem.
3416
3417         This set of changes allows us to delete the special
3418         webkitpy/layout_tests/data directory and test the generic code without
3419         touching the filesystem (except to write results). This speeds up
3420         test-webkitpy substantially.
3421
3422         This also cleans up and removes several code paths in the generic
3423         code and fixes some minor bugs, notably in the test_expectations
3424         parsing, which was previously fragile if the tests weren't present.
3425
3426         We also change the way we diff image results to be able to do so
3427         in memory, without relying on files. This slows down chromium
3428         test_shell, which always writes images to files, but should speed
3429         up DRT and ImageDiff-based implementations slightly.
3430
3431         Note that pulling the list of tests to run from the Port will allow
3432         ports to specify what tests to run as an inclusive list; previously
3433         you could only do this as an exclusive list by using a 
3434         test_expectations file or Skipped files; nothing actually uses this
3435         feature yet and it's unclear if it should be used.
3436
3437         Note that there are no functional changes -- apart from now 
3438         always printing out the location of the checksum file when we are
3439         tracing test runs -- and the total number of lines of non-test code
3440         actually drops by two.
3441
3442         There is some more cleanup that can be done in the Port/Driver 
3443         interface and in some handling of filenames, but I'll save that
3444         for another change.
3445
3446         https://bugs.webkit.org/show_bug.cgi?id=45801
3447
3448         * Scripts/webkitpy/layout_tests/data/*: Removed.
3449             - no longer need special mock layout_tests_directory in the
3450               repository.
3451         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3452             - add code to display missing text files, checksums when tracing
3453             - update to not look at the filesystem directly.
3454         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3455             - add more unit tests
3456         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3457             - remove tests_are_present flag
3458             - update with changes in Port interface - no longer access
3459               the filesystem directly, although we still use os.path for
3460               filename manipulation.
3461         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3462             - add more unit tests
3463         * Scripts/webkitpy/layout_tests/layout_package/test_files.py: Removed.
3464             - renamed to port/test_files.py
3465         * Scripts/webkitpy/layout_tests/port/base.py:
3466             - change diff_image() to expect actual image data, not filenames
3467             - add expected_checksum(), expected_image(), expected_text() to
3468               return the content of the files so that we don't need a filesystem
3469             - add path_exists(), path_isdir() for filesystem-like access.
3470             - add test_dirs() to keep clobber-test-results from needing to
3471               actually look at a real layout tests dir
3472             - add tests() to return the list of tests to run on the port
3473               (calls port/test_files to do the work).
3474             - add update_baseline() to be able to save new baselines
3475             - add uri_to_test_name() from port/dryrun.py so we can easily check
3476               filename_to_uri()
3477         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3478             - add more unit tests
3479         * Scripts/webkitpy/layout_tests/port/chromium.py:
3480             - change diff_image() to accept image content, not filenames.
3481               This will be slower for test_shell/image_diff, but faster
3482               for DRT/ImageDiff.
3483         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3484             - add more unit tests
3485         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3486             - simplify greatly
3487         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3488             - add more unit tests
3489         * Scripts/webkitpy/layout_tests/port/test.py:
3490             - massive rewrite to use in-script list of tests and expectations
3491         * Scripts/webkitpy/layout_tests/port/test_files.py:
3492             - rename from layout_package/test_files.
3493         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
3494             - add unit tests
3495         * Scripts/webkitpy/layout_tests/port/webkit.py:
3496             - update diff_image() to take image contents, not files. Should
3497               make things slightly faster.
3498         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3499             - update with changes to diff_image()
3500         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
3501             - update with changes to diff_image()
3502         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3503             - remove tests_are_present from test_expectations
3504             - pull the list of tests from port.tests() instead
3505               of calling test_files.py directly.
3506         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3507             - update unit tests
3508         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
3509             - update with changes to 
3510         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
3511             - update with change in Port interface
3512         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3513             - update with change in Port interface
3514         * Scripts/webkitpy/style/checkers/test_expectations.py:
3515             - remove the tests_are_present flag
3516
3517 2010-09-21  Anders Carlsson  <andersca@apple.com>
3518
3519         Disable logging.
3520
3521         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
3522
3523 2010-09-21  Tony Chang  <tony@chromium.org>
3524
3525         Reviewed by Kent Tamura.
3526
3527         add a script for running webkit_unit_tests
3528         https://bugs.webkit.org/show_bug.cgi?id=46014
3529
3530         * Scripts/run-chromium-webkit-unit-tests: Added.
3531
3532 2010-09-21  Fridrich Strba  <fridrich.strba@bluewin.ch>
3533
3534         Reviewed by Martin Robinson.
3535
3536         Fix linking problems on Windows.
3537         https://bugs.webkit.org/show_bug.cgi?id=45844
3538
3539         * GNUmakefile.am: link the executables with winmm.dll
3540
3541 2010-09-21  Adam Barth  <abarth@webkit.org>
3542
3543         Reviewed by Eric Seidel.
3544
3545         feeder-queue svn updates more often than needed
3546         https://bugs.webkit.org/show_bug.cgi?id=46171
3547
3548         We don't need to poll SVN every time we feed the feeders.  Rather, we
3549         can count on the wrapper shell script to auto-update the queue.
3550
3551         * Scripts/webkitpy/tool/commands/queues.py:
3552         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3553
3554 2010-09-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3555
3556         Reviewed by Andreas Kling.
3557
3558         [Qt] Add robot loader timeout and extra time options.
3559         https://bugs.webkit.org/show_bug.cgi?id=46172
3560
3561         [-robot-timeout <s>]: Load the next page after s seconds if the current
3562         page didn't finish loading.
3563         [-robot-extra-time <s>]: Wait s seconds after the current page finished
3564         loading before loading the next one. This should allow some time for the
3565         page's JavaScript to execute.
3566
3567         * QtTestBrowser/launcherwindow.cpp:
3568         (LauncherWindow::applyPrefs):
3569         * QtTestBrowser/main.cpp:
3570         (LauncherApplication::robotTimeout):
3571         (LauncherApplication::robotExtraTime):
3572         (LauncherApplication::LauncherApplication):
3573         (LauncherApplication::handleUserOptions):
3574         (main):
3575         * QtTestBrowser/urlloader.cpp:
3576         (UrlLoader::UrlLoader):
3577         (UrlLoader::loadNext):
3578         (UrlLoader::loadUrlList):
3579         * QtTestBrowser/urlloader.h:
3580
3581 2010-09-21  Pavel Podivilov  <podivilov@chromium.org>
3582
3583         Unreviewed.
3584
3585         Adding myself to the committers list.
3586
3587         * Scripts/webkitpy/common/config/committers.py:
3588
3589 2010-09-20  Philippe Normand  <pnormand@igalia.com>
3590