2010-02-04 Andras Becsi <abecsi@inf.u-szeged.hu>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-02-04  Andras Becsi  <abecsi@inf.u-szeged.hu>
2
3         Reviewed by Tor Arne Vestbø.
4
5         Implement a locking and scheduling mechanism for http testing sessions to be able
6         to run multiple instances of run-webkit-tests parallel on the same machine.
7         If a test session wants to run http tests and this feature is enabled, the pending
8         sessions create lockfiles with sequential lock numbers. These locks are used to schedule
9         the running test sessions in first come first served order. An exclusive lock ensures
10         that the lock numbers are sequential to avoid deadlocks and starvation.
11         Because the buildbot master specifies the flags used by slaves we need an environment
12         variable too to be able to use the feature per-slave.
13         Exporting WEBKIT_WAIT_FOR_HTTPD=1 before testing or using the --wait-for-httpd
14         flag enables this feature, otherwise this patch has no effect on the testing whatsoever.
15
16         https://bugs.webkit.org/show_bug.cgi?id=33153
17
18         * Scripts/run-webkit-tests:
19         * Scripts/webkitperl/httpd.pm:
20
21 2010-01-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
22
23         Reviewed by Simon Hausmann.
24
25         Make run-webkit-tests work under Cygwin for the Qt port
26
27         setPathForRunningWebKitApp() is implemented for the Qt port
28         by using qmake to query for the location of the Qt libraries.
29
30         This requires the original environment (%ENV) to be untouched,
31         so launchWithCurrentEnv() was refactored to launchWithEnv(),
32         and the code in openDumpTool() to not use %ENV but a %CLEAN_ENV
33         instead. This has the added benefit of getting rid of the temp
34         variables used for storing the current env.
35
36         openDumpTool() is also refactored a bit into platform-spesific,
37         port-spesific, and generic environment variables.
38
39         Checks for undef was added a few places to fix Perl concat
40         warnings when run-webkit-tests is aborted.
41
42         https://bugs.webkit.org/show_bug.cgi?id=33895
43
44         * Scripts/run-webkit-tests:
45         * Scripts/webkitdirs.pm:
46
47 2010-02-04  Yuzo Fujishima  <yuzo@google.com>
48
49         Unreviewed.
50
51         Add Yuzo to the committers list.
52
53         * Scripts/webkitpy/committers.py:
54
55 2010-02-03  Dirk Pranke  <dpranke@chromium.org>
56
57         Rubber-stamped by Eric Seidel.
58
59         Change "the Chromium name" to "the name of Google Inc." in the licenses
60
61         https://bugs.webkit.org/show_bug.cgi?id=34511
62
63         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
64         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
65         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
66         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
67         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
68         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
69         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
70         * Scripts/webkitpy/layout_tests/port/__init__.py:
71         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
72         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
73         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
74         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
75         * Scripts/webkitpy/layout_tests/port/http_server.py:
76         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
77         * Scripts/webkitpy/layout_tests/port/path_utils.py:
78         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
79         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
80         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
81         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
82         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
83         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
84         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
85
86 2010-02-03  Dirk Pranke  <dpranke@chromium.org>
87
88         Rubber-stamped by Eric Siedel.
89
90         Rename files as part of refactoring the layout_tests package. All
91         the platform_utils* module, the path_utils.py module, and
92         the http server and web socket server modules are moved into a new
93         port/ package.
94
95         https://bugs.webkit.org/show_bug.cgi?id=34511
96
97         * Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py: Removed.
98         * Scripts/webkitpy/layout_tests/layout_package/http_server.py: Removed.
99         * Scripts/webkitpy/layout_tests/layout_package/http_server_base.py: Removed.
100         * Scripts/webkitpy/layout_tests/layout_package/httpd2.pem: Removed.
101         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
102         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
103         * Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf: Removed.
104         * Scripts/webkitpy/layout_tests/layout_package/path_utils.py: Removed.
105         * Scripts/webkitpy/layout_tests/layout_package/platform_utils.py: Removed.
106         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py: Removed.
107         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py: Removed.
108         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py: Removed.
109         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
110         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
111         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
112         * Scripts/webkitpy/layout_tests/layout_package/websocket_server.py: Removed.
113         * Scripts/webkitpy/layout_tests/port: Added.
114         * Scripts/webkitpy/layout_tests/port/__init__.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils.py.
115         * Scripts/webkitpy/layout_tests/port/apache_http_server.py: Copied from Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py.
116         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py.
117         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py.
118         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py.
119         * Scripts/webkitpy/layout_tests/port/http_server.py: Copied from Scripts/webkitpy/layout_tests/layout_package/http_server.py.
120         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Copied from Scripts/webkitpy/layout_tests/layout_package/http_server_base.py.
121         * Scripts/webkitpy/layout_tests/port/httpd2.pem: Copied from Scripts/webkitpy/layout_tests/layout_package/httpd2.pem.
122         * Scripts/webkitpy/layout_tests/port/lighttpd.conf: Copied from Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf.
123         * Scripts/webkitpy/layout_tests/port/path_utils.py: Copied from Scripts/webkitpy/layout_tests/layout_package/path_utils.py.
124         * Scripts/webkitpy/layout_tests/port/websocket_server.py: Copied from Scripts/webkitpy/layout_tests/layout_package/websocket_server.py.
125         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
126         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
127         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
128         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
129         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
130         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
131
132
133 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
134
135         Rubber-stamped by Eric Seidel.
136
137         Roll back r53559 and r54084 again, because roll out didn't solve flakeyness on the Windows Test bots
138         https://bugs.webkit.org/show_bug.cgi?id=34399
139
140         * Scripts/run-iexploder-tests:
141         * Scripts/run-webkit-httpd:
142         * Scripts/run-webkit-tests:
143         * Scripts/webkitperl/httpd.pm: Added.
144
145 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
146
147         Rubber-stamped by Eric Seidel.
148
149         Roll out r53559 and r54084, because it might caused flakeyness on the Windows Test bots
150
151         * Scripts/run-iexploder-tests:
152         * Scripts/run-webkit-httpd:
153         * Scripts/run-webkit-tests:
154         * Scripts/webkitperl/httpd.pm: Removed.
155
156 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
157
158         Rubber-stamped by Ariya Hidayat.
159
160         Roll back r53889 again, because roll out didn't solve flakeyness on the Windows Test bots
161         https://bugs.webkit.org/show_bug.cgi?id=34399
162
163         * DumpRenderTree/win/EventSender.cpp:
164         (buildModifierFlags):
165         (mouseDownCallback):
166         (mouseUpCallback):
167         (keyDownCallback):
168
169 2010-02-03  Eric Seidel  <eric@webkit.org>
170
171         No review, just fixing copyrights.
172
173         Concerns were expressed about "The Chromium Authors" being
174         a valid legal entity for copyright assignment in the WebKit repository,
175         so this change removes all "The Chromium Authors".
176
177         I looked at the svn logs in src.chromium.org and failed to find any
178         non-google contributions to these files, so they are all now
179         marked as copyright "Google Inc" as all Google contributers assign
180         copyright to "Google Inc" as part of their employment agreement.
181
182         * Scripts/rebaseline-chromium-webkit-tests:
183         * Scripts/run-chromium-webkit-tests:
184         * Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py:
185         * Scripts/webkitpy/layout_tests/layout_package/http_server.py:
186         * Scripts/webkitpy/layout_tests/layout_package/http_server_base.py:
187         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
188         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
189         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
190         * Scripts/webkitpy/layout_tests/layout_package/path_utils.py:
191         * Scripts/webkitpy/layout_tests/layout_package/platform_utils.py:
192         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py:
193         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py:
194         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py:
195         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
196         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
197         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
198         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
199         * Scripts/webkitpy/layout_tests/layout_package/websocket_server.py:
200         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
201         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
202         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
203         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
204         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
205         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
206
207 2010-02-03  Kenneth Rohde Christiansen  <kenneth@webkit.org>
208
209         Reviewed by Ariya Hidayat.
210
211         [Qt] QtLauncher, refactor argument handling in preparation of merge
212         with QGVLauncher
213
214         * QtLauncher/main.cpp:
215         (LauncherApplication::urls):
216         (LauncherApplication::isRobotized):
217         (LauncherApplication::applyDefaultSettings):
218         (LauncherApplication::LauncherApplication):
219         (LauncherApplication::formatKeys):
220         (LauncherApplication::enumToKeys):
221         (fail):
222         (LauncherApplication::handleUserOptions):
223         (main):
224
225 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
226
227         Rubber-stamped by Ariya Hidayat.
228
229         Rolling out r53889, because it might caused flakeyness on the Windows Test bots
230         https://bugs.webkit.org/show_bug.cgi?id=34399
231
232         * DumpRenderTree/win/EventSender.cpp:
233         (mouseDownCallback):
234         (mouseUpCallback):
235         (keyDownCallback):
236
237 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
238
239         Reviewed by Ariya Hidayat.
240
241         [Qt] Fix pixel tests support.
242         https://bugs.webkit.org/show_bug.cgi?id=27813
243
244         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
245         (WebCore::DumpRenderTree::open):
246         (WebCore::DumpRenderTree::processLine):
247          - Hash processing mechanism moved from DumpRenderTree::open to DumpRenderTree::processLine.
248         (WebCore::DumpRenderTree::dump): Fixed and renamed variables.
249
250 2010-02-03  Kevin Watters  <kevinwatters@gmail.com>
251
252         Reviewed by Kevin Ollivier.
253
254         [wx] Enable JIT compilation for wx.
255         
256         https://bugs.webkit.org/show_bug.cgi?id=34536
257
258         * wx/build/settings.py:
259
260 2010-02-02  Kevin Ollivier  <kevino@theolliviers.com>
261
262         [wx] Build fix after introduction of pageNumberForElementById.
263
264         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
265         (LayoutTestController::pageNumberForElementById):
266
267 2010-02-02  Shu Chang  <Chang.Shu@nokia.com>
268
269         Unreviewed.
270
271         Add myself to list of committers.
272
273         * Scripts/webkitpy/committers.py:
274
275 2010-02-02  Chris Jerdonek  <cjerdonek@webkit.org>
276
277         Reviewed by Shinichiro Hamaji.
278
279         Moved filter-related check-webkit-style code into a separate
280         filter module.
281
282         https://bugs.webkit.org/show_bug.cgi?id=34408
283
284         This is preparatory refactoring for Bug 33684, which will allow
285         file and folder-specific filter rules.
286
287         * Scripts/webkitpy/style/checker.py:
288           - Removed CategoryFilter class (moved to filter.py).
289
290         * Scripts/webkitpy/style/checker_unittest.py:
291           - Removed CategoryFilter unit tests (moved to filter_unittest.py).
292
293         * Scripts/webkitpy/style/filter.py: Added.
294           - Added CategoryFilter class (moved from checker.py).
295
296         * Scripts/webkitpy/style/filter_unittest.py: Added.
297           - Added CategoryFilter unit tests (moved from checker_unittest.py).
298
299         * Scripts/webkitpy/style/unittests.py:
300           - Added reference to filter_unittest.py.
301
302 2010-02-01  Chris Jerdonek  <cjerdonek@webkit.org>
303
304         Reviewed by Shinichiro Hamaji.
305
306         Addressed FIXME in check-webkit-style so that the carriage-return
307         check will work for patches.
308
309         https://bugs.webkit.org/show_bug.cgi?id=34260
310
311         Also added support for limiting the number of errors reported
312         per category, per file.
313
314         * Scripts/webkitpy/style/checker.py:
315           - Added new "whitespace/carriage_return" category from common.py.
316           - Added MAX_REPORTS_PER_CATEGORY dictionary.
317           - Added max_reports_per_category attribute to ProcessorOptions class.
318           - Refactored StyleChecker._process_file().
319
320         * Scripts/webkitpy/style/checker_unittest.py:
321           - Updated ProcessorOptionsTest tests.
322           - Added test to check MAX_REPORTS_PER_CATEGORY.
323
324         * Scripts/webkitpy/style/error_handlers.py:
325           - Added support for suppressing the display of errors after
326             reaching a per-category maximum (from max_reports_per_category).
327
328         * Scripts/webkitpy/style/error_handlers_unittest.py:
329           - Added test for suppressing error display.
330
331         * Scripts/webkitpy/style/processors/common.py: Added.
332           - Moved carriage-return check to new file.
333
334         * Scripts/webkitpy/style/processors/common_unittest.py: Added.
335           - Added unit tests for carriage-return check.
336
337         * Scripts/webkitpy/style/unittests.py:
338           - Added reference to common_unittest.py.
339
340 2010-02-01  Shinichiro Hamaji  <hamaji@chromium.org>
341
342         Reviewed by Eric Seidel.
343
344         Provide a way to get page number with layoutTestController
345         https://bugs.webkit.org/show_bug.cgi?id=33840
346
347         * DumpRenderTree/LayoutTestController.cpp:
348         (pageNumberForElementByIdCallback):
349         (LayoutTestController::staticFunctions):
350         * DumpRenderTree/LayoutTestController.h:
351         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
352         (LayoutTestController::pageNumberForElementById):
353         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
354         (LayoutTestController::pageNumberForElementById):
355         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
356         (LayoutTestController::pageNumberForElementById):
357
358 2010-02-01  Shinichiro Hamaji  <hamaji@chromium.org>
359
360         Unreviewed fix for an invalid function call.
361
362         check-webkit-style: Remove filename parameter from all functions where no longer used
363         https://bugs.webkit.org/show_bug.cgi?id=34249
364
365         * Scripts/webkitpy/style/checker.py:
366
367 2010-02-01  Diego Gonzalez  <diego.gonzalez@openbossa.org>
368
369         Reviewed by Kenneth Rohde Christiansen.
370
371         [Qt] DRT Provide global flag ability
372         https://bugs.webkit.org/show_bug.cgi?id=34418
373
374         Add the globalFlag property to the Qt LayoutTestController to allow
375         cross-domain indications.
376
377         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
378         (LayoutTestController::reset):
379         * DumpRenderTree/qt/LayoutTestControllerQt.h:
380         (LayoutTestController::globalFlag):
381         (LayoutTestController::setGlobalFlag):
382
383 2010-02-01  Brady Eidson  <beidson@apple.com>
384
385         Reviewed by Adele Peterson.
386
387         Crash in Safari opening new tabs to "same page"
388         <rdar://problem/7593857> and https://bugs.webkit.org/show_bug.cgi?id=34444
389
390         Add a mode (Mac-only for now) that exercises the WebView SPI _loadBackForwardListFromOtherView:
391
392         * DumpRenderTree/LayoutTestController.cpp:
393         (LayoutTestController::LayoutTestController):
394         (setNewWindowsCopyBackForwardListCallback):
395         (LayoutTestController::staticFunctions):
396
397         * DumpRenderTree/LayoutTestController.h:
398         (LayoutTestController::newWindowsCopyBackForwardList):
399         (LayoutTestController::setNewWindowsCopyBackForwardList):
400
401         * DumpRenderTree/mac/UIDelegate.mm:
402         (-[UIDelegate webView:createWebViewWithRequest:]):
403
404 2010-02-01  Carol Szabo  <carol.szabo@nokia.com>
405
406         Unreviewed.
407
408         Add myself to list of committers.
409
410         * Scripts/webkitpy/committers.py:
411
412 2010-02-01  Nate Chapin  <japhet@chromium.org>
413
414         Rubber-stamped by David Levin.
415
416         Add myself to reviewer list.
417
418         * Scripts/webkitpy/committers.py:
419
420 2010-01-31  Chris Jerdonek  <cjerdonek@webkit.org>
421
422         Reviewed by Shinichiro Hamaji.
423
424         Moved style error handler code to their own classes, and
425         related refactoring. Increased unit test code coverage of
426         style error handling.
427
428         https://bugs.webkit.org/show_bug.cgi?id=34379
429
430         * Scripts/check-webkit-style:
431           - Minor change: added error_count variable.
432
433         * Scripts/webkitpy/style/checker.py:
434           - Renamed ProcessorOptions.should_report_error() to is_reportable().
435           - In the StyleChecker class--
436             - Removed _default_style_error_handler().
437             - Added _increment_error_count().
438             - Refactored to use DefaultStyleErrorHandler and
439               PatchStyleErrorHandler constructors.
440
441         * Scripts/webkitpy/style/checker_unittest.py:
442           - In the StyleStyleCheckerTest class--
443             - Removed write_sample_error().
444             - Removed test_default_style_error_handler().
445
446         * Scripts/webkitpy/style/error_handlers.py: Added.
447           - Added DefaultStyleErrorHandler class.
448           - Added PatchStyleErrorHandler class.
449
450         * Scripts/webkitpy/style/error_handlers_unittest.py: Added.
451           - Added unit tests for DefaultStyleErrorHandler and
452             PatchStyleErrorHandler.
453
454         * Scripts/webkitpy/style/unittests.py:
455           - Added error_handlers unit tests.
456
457 2010-01-29  Mark Rowe  <mrowe@apple.com>
458
459         Rubber-stamped by Stephanie Lewis.
460
461         Fix run-leaks with newer versions of the leaks tool.
462
463         * Scripts/run-leaks:
464
465 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
466
467         Reviewed by Eric Siedel.
468
469         Top-level test drivers for running the Chromium port of run-webkit-tests
470         and being able to rebaseline test results from the test bots.  The
471         files in the Scripts directory are simply wrappers around the files
472         in webkitpy/layout_tests for convenience.
473  
474         https://bugs.webkit.org/show_bug.cgi?id=31498
475
476         * Scripts/rebaseline-chromium-webkit-tests: Added.
477         * Scripts/run-chromium-webkit-tests: Added.
478         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Added.
479         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py: Added.
480
481 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
482
483         Reviewed by Eric Siedel.
484
485         Add in the second block of python code for the Chromium port
486         of run-webkit-tests. These files execute different diffs to classify
487         the various types of failures from a test.
488
489         * Scripts/webkitpy/layout_tests/test_types: Added.
490         * Scripts/webkitpy/layout_tests/test_types/__init__.py: Added.
491         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Added.
492         * Scripts/webkitpy/layout_tests/test_types/image_diff.py: Added.
493         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: Added.
494         * Scripts/webkitpy/layout_tests/test_types/text_diff.py: Added.
495
496 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
497
498         Reviewed by Eric Siedel.
499
500         Check in the first part of the Chromium Python port of the 
501         run-webkit-tests test driver. The files under 
502         layout_tests/layout_layout constitute most of the implementation;
503         they can be roughly divided into code that parses the 
504         "test_expectations.txt" file that describes how we expect tests to
505         pass or fail, platform-specific hooks for the different Chromium 
506         ports (in platform_utils*), code for parsing the output of the
507         tests and generating results files and HTML and JSON for the
508         dashboards, auxiliary scripts for starting and stopping HTTP and
509         Web Socket servers, and then one of the actual driver files 
510         (test_shell_thread). Code for actually parsing test output for 
511         failures and the top-level driver scripts will follow shortly.
512
513         https://bugs.webkit.org/show_bug.cgi?id=31498
514
515         * Scripts/webkitpy/layout_tests: Added.
516         * Scripts/webkitpy/layout_tests/layout_package: Added.
517         * Scripts/webkitpy/layout_tests/layout_package/__init__.py: Added.
518         * Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py: Added.
519         * Scripts/webkitpy/layout_tests/layout_package/http_server.py: Added.
520         * Scripts/webkitpy/layout_tests/layout_package/http_server_base.py: Added.
521         * Scripts/webkitpy/layout_tests/layout_package/httpd2.pem: Added.
522           - scripts to start and stop apache. Note that the apache file
523             generates a conf file dynamically, and we should switch to 
524             using the same static conf file that the regular run-webkit-tests
525             uses, and we can also use the same httpd2.pem file.
526
527         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: Added.
528         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: Added.
529           - scripts to generate the JSON layout test dashboard and the
530             flakiness dashboard
531         * Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf: Added.
532           - default configuration for LigHTTPd (used on Windows)
533         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py: Added.
534           - utility class that implements progress bars on the console to
535             be displayed while the tests are running
536         * Scripts/webkitpy/layout_tests/layout_package/path_utils.py: Added.
537           - various routines for manipulating paths and URIs
538         * Scripts/webkitpy/layout_tests/layout_package/platform_utils.py: Added.
539         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py: Added.
540         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py: Added.
541         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py: Added.
542           - platform-specific aspects of the drivers (binary names, paths,
543             process control, etc.)
544         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Added.
545           - code for parsing the 'test_expectations.txt' file to determine
546             which tests are expected to fail (and how) on which platforms
547         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: Added.
548           - code for handling different kinds of failures (generating output
549             in the results, etc.)
550         * Scripts/webkitpy/layout_tests/layout_package/test_files.py: Added.
551           - code to gather the lists of tests
552         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py: Added.
553           - code to actually execute tests via TestShell and process
554             the output
555         * Scripts/webkitpy/layout_tests/layout_package/websocket_server.py: Added.
556           - scripts to start and stop the pywebsocket server
557
558 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
559
560         Reviewed by Eric Seidel.
561
562         Check in a copy of the simplejson library; it will be used by
563         the Chromium port of run-webkit-tests.
564         
565         https://bugs.webkit.org/show_bug.cgi?id=31498
566
567         * simplejson: Added.
568         * simplejson/LICENSE.txt: Added.
569         * simplejson/README.txt: Added.
570         * simplejson/__init__.py: Added.
571         * simplejson/_speedups.c: Added.
572         (ascii_escape_char):
573         (ascii_escape_unicode):
574         (ascii_escape_str):
575         (py_encode_basestring_ascii):
576         (init_speedups):
577         * simplejson/decoder.py: Added.
578         * simplejson/encoder.py: Added.
579         * simplejson/jsonfilter.py: Added.
580         * simplejson/scanner.py: Added.
581
582 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
583
584         No review
585
586         Add myself to the committers list
587
588         * Scripts/webkitpy/committers.py:
589
590 2010-01-29  Jeremy Orlow  <jorlow@chromium.org>
591
592         Reviewed by Dimitri Glazkov.
593
594         A first step towards the Indexed Database API
595         https://bugs.webkit.org/show_bug.cgi?id=34342
596
597         Add indexed database API.
598
599         * Scripts/build-webkit:
600
601 2010-01-29  Andras Becsi  <abecsi@webkit.org>
602
603         Reviewed by Alexey Proskuryakov.
604
605         Correct openHTTPD() to print requests to stdout if run-webkit-httpd is used.
606         This fixes a regression introduced in r53559.
607
608         https://bugs.webkit.org/show_bug.cgi?id=34336
609
610         * Scripts/webkitperl/httpd.pm:
611
612 2010-01-28  Jon Honeycutt  <jhoneycutt@apple.com>
613
614         MSAA: Crash when posting a notification for a detached object
615
616         https://bugs.webkit.org/show_bug.cgi?id=34309
617         <rdar://problem/7409759>
618
619         Reviewed by Darin Adler.
620
621         * DumpRenderTree/AccessibilityController.h:
622         Declare new functions. Add new members to store the event hook and the
623         mapping of accessibility elements to their JS callbacks.
624
625         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
626         (AccessibilityController::notificationReceived):
627         Stubbed.
628         (AccessibilityController::addNotificationListener):
629         Stubbed.
630
631         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
632         (AccessibilityController::notificationReceived):
633         Stubbed.
634         (AccessibilityController::addNotificationListener):
635         Stubbed.
636
637         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
638         (AccessibilityController::AccessibilityController):
639         Initialize the event hook.
640         (AccessibilityController::~AccessibilityController):
641         Remove the event hook. Unprotect all of the JS functions that are stored
642         in the map.
643         (logEventProc):
644         Clean-up a variable.
645         (stringEvent):
646         Return a string description of the MSAA event code.
647         (notificationListenerProc):
648         Get the accessible object from the event, and query it for IAccessible.
649         Call the AccessibilityController's notificationReceived().
650         (comparableObject):
651         Use QueryService to obtain the IAccessibleComparable for the
652         IServiceProvider.
653         (AccessibilityController::notificationReceived):
654         Iterate the map of objects that have registered for notification
655         callbacks. Query each for IServiceProvider, then use comparableObject()
656         to get an IAccessibleComparable. If we find an object matching the
657         notified object, call its callback, passing the event that was received.
658         (AccessibilityController::addNotificationListener):
659         If we have not created the event hook, create it. Protect the JS
660         callback function object, and add the object and its callback to our
661         map.
662
663         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
664         (AccessibilityUIElement::addNotificationListener):
665         Call through to the AccessibilityController's addNotificationListener().
666
667         * DumpRenderTree/win/DumpRenderTreeWin.h:
668         Add an extern declaration for the shared FrameLoadDelegate extern, so we
669         can access it from AccessibilityController.
670
671         * DumpRenderTree/win/FrameLoadDelegate.h:
672         (FrameLoadDelegate::accessibilityController):
673         Return the AccessibilityController.
674
675 2010-01-29  Shinichiro Hamaji  <hamaji@chromium.org>
676
677         Reviewed by Darin Adler.
678
679         prepare-ChangeLog outputs useless messages for a nonexistent bug ID
680         https://bugs.webkit.org/show_bug.cgi?id=34313
681
682         * Scripts/prepare-ChangeLog:
683
684 2010-01-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
685
686         Rubberstamped by Simon Hausmann.
687
688         [Qt] Separate implementation from class definition.
689
690         * QtLauncher/main.cpp:
691         (LauncherWindow::webView):
692         (LauncherWindow::LauncherWindow):
693         (LauncherWindow::~LauncherWindow):
694         (LauncherWindow::keyPressEvent):
695         (LauncherWindow::grabZoomKeys):
696         (LauncherWindow::sendTouchEvent):
697         (LauncherWindow::eventFilter):
698         (LauncherWindow::loadStarted):
699         (LauncherWindow::loadFinished):
700         (LauncherWindow::showLinkHover):
701         (LauncherWindow::zoomIn):
702         (LauncherWindow::zoomOut):
703         (LauncherWindow::resetZoom):
704         (LauncherWindow::toggleZoomTextOnly):
705         (LauncherWindow::print):
706         (LauncherWindow::screenshot):
707         (LauncherWindow::setEditable):
708         (LauncherWindow::dumpHtml):
709         (LauncherWindow::selectElements):
710         (LauncherWindow::setTouchMocking):
711         (LauncherWindow::newWindow):
712         (LauncherWindow::setupUI):
713
714 2010-01-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
715
716         Reviewed by Ariya Hidayat.
717
718         [Qt] On Maemo5, a click/touch in the location bar (when unfocused)
719         should result in all text selected.
720
721         * QtLauncher/locationedit.cpp:
722         (LocationEdit::focusInEvent):
723         * QtLauncher/locationedit.h:
724
725 2010-01-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
726
727         Reviewed by Ariya Hidayat.
728
729         [Qt] Show progress reaching 100% for loads.
730
731         * QtLauncher/locationedit.cpp:
732         (LocationEdit::LocationEdit):
733         (LocationEdit::setProgress):
734         (LocationEdit::reset):
735         (LocationEdit::paintEvent):
736         * QtLauncher/locationedit.h:
737
738 2010-01-29  Andreas Kling  <andreas.kling@nokia.com>
739
740         Reviewed by Kenneth Rohde Christiansen.
741
742         [Qt] Disable the QtLauncher statusbar on Maemo
743
744         https://bugs.webkit.org/show_bug.cgi?id=34330
745
746         * QtLauncher/main.cpp:
747         (LauncherWindow::showLinkHover):
748         (LauncherWindow::selectElements):
749
750 2010-01-29  Andreas Kling  <andreas.kling@nokia.com>
751
752         Reviewed by Kenneth Rohde Christiansen.
753
754         [Qt] Display page loading progress inside the QtLauncher location bar
755
756         https://bugs.webkit.org/show_bug.cgi?id=34210
757
758         * QtLauncher/QtLauncher.pro:
759         * QtLauncher/locationedit.cpp: Added.
760         (LocationEdit::LocationEdit):
761         (LocationEdit::setProgress):
762         (LocationEdit::paintEvent):
763         * QtLauncher/locationedit.h: Added.
764         * QtLauncher/mainwindow.cpp:
765         (MainWindow::buildUI):
766         * QtLauncher/mainwindow.h:
767
768 2010-01-29  Andreas Kling  <andreas.kling@nokia.com>
769
770         Reviewed by Kenneth Rohde Christiansen.
771
772         [Qt] Add support for Maemo zoom keys in QtLauncher
773
774         https://bugs.webkit.org/show_bug.cgi?id=34160
775
776         * QtLauncher/main.cpp:
777         (LauncherWindow::LauncherWindow):
778         (LauncherWindow::~LauncherWindow):
779         (LauncherWindow::keyPressEvent):
780         (LauncherWindow::grabZoomKeys):
781
782 2010-01-29  Benjamin Poulain  <benjamin.poulain@nokia.com>
783
784         Reviewed by Kenneth Rohde Christiansen.
785
786         [Qt] Implement the display() method of the layout test controller
787         https://bugs.webkit.org/show_bug.cgi?id=34258
788
789         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
790         (WebCore::DumpRenderTree::DumpRenderTree):
791         (WebCore::DumpRenderTree::showPage):
792         (WebCore::DumpRenderTree::hidePage):
793         * DumpRenderTree/qt/DumpRenderTreeQt.h:
794         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
795         (LayoutTestController::reset):
796         (LayoutTestController::display):
797         * DumpRenderTree/qt/LayoutTestControllerQt.h:
798
799 2010-01-28  Kevin Ollivier  <kevino@theolliviers.com>
800
801         [wx] Build fix for MSW, use ThreadingWin.cpp as the Windows pthreads implementation
802         implements pthread_t in a way that makes it impossible to check its validity,
803         which is needed by ThreadingPthreads.cpp.
804
805         * DumpRenderTree/wscript:
806         * wx/build/settings.py:
807
808 2010-01-28  Andras Becsi  <abecsi@webkit.org>
809
810         Adding myself to the committer list. No review needed.
811
812         * Scripts/webkitpy/committers.py:
813
814 2010-01-28  Hayato Ito  <hayato@chromium.org>
815
816         Reviewed by David Levin.
817
818         Remove NULL char from input JS file because 'grep' fails if the file contains NULL char.
819
820         https://bugs.webkit.org/show_bug.cgi?id=34252
821
822         * Scripts/make-script-test-wrappers:
823
824 2010-01-28  Kevin Ollivier  <kevino@theolliviers.com>
825
826         [wx] Build fix after removal of the zlib image decoder.
827
828         * wx/build/settings.py:
829
830 2010-01-28  Csaba Osztrogonác  <ossy@webkit.org>
831
832         [Qt] Unreviewed, roll out r54000.
833
834         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
835         (WebCore::DumpRenderTree::DumpRenderTree):
836         * DumpRenderTree/qt/DumpRenderTreeQt.h:
837         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
838         (LayoutTestController::reset):
839         * DumpRenderTree/qt/LayoutTestControllerQt.h:
840         (LayoutTestController::display):
841
842 2010-01-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
843
844         Reviewed by Kenneth Rohde Christiansen.
845
846         [Qt] Implement the display() method of the layout test controller
847         https://bugs.webkit.org/show_bug.cgi?id=34258
848
849         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
850         (WebCore::DumpRenderTree::DumpRenderTree):
851         (WebCore::DumpRenderTree::showPage):
852         (WebCore::DumpRenderTree::hidePage):
853         * DumpRenderTree/qt/DumpRenderTreeQt.h:
854         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
855         (LayoutTestController::reset):
856         (LayoutTestController::display):
857         * DumpRenderTree/qt/LayoutTestControllerQt.h:
858
859 2010-01-28  Chris Jerdonek  <cjerdonek@webkit.org>
860
861         Reviewed by Shinichiro Hamaji.
862
863         Eliminated the filename parameter from functions in
864         check-webkit-style's cpp.py where it is no longer used.
865
866         https://bugs.webkit.org/show_bug.cgi?id=34249
867
868         * Scripts/webkitpy/style/processors/cpp.py:
869           - Reduced number of occurrences of "filename" variable from
870             approximately 200 to 120.
871
872         * Scripts/webkitpy/style/processors/cpp_unittest.py:
873           - Refactored unit tests as necessary to accommodate changes to cpp.py.
874           - Fixed bug in CppStyleTestBase.perform_include_what_you_use()
875             where the incorrect file extension was getting passed to
876             cpp_style.check_language().
877
878 2010-01-28  Chris Jerdonek  <cjerdonek@webkit.org>
879
880         Reviewed by Shinichiro Hamaji.
881
882         In check-webkit-style, eliminated the dependency of
883         processors/cpp_unittest.py on checker.py.
884
885         https://bugs.webkit.org/show_bug.cgi?id=34205
886
887         * Scripts/webkitpy/style/checker.py:
888           - Addressed FIXME by removing STYLE_CATEGORIES data.
889           - Added style_categories().
890
891         * Scripts/webkitpy/style/checker_unittest.py:
892           - Minor changes.
893
894         * Scripts/webkitpy/style/processors/cpp.py:
895           - Added categories attribute to CppProcessor class (data
896             was originally checker.STYLE_CATEGORIES).
897
898         * Scripts/webkitpy/style/processors/cpp_unittest.py:
899           - Addressed FIXME by eliminating "import" from checker.py.
900
901 2010-01-28  Anton Muhin  <antonm@chromium.org>
902
903         Reviewed by Shinichiro Hamaji.
904
905         Improve treatment of conditions and rest of the line for if, else, switch and alikes
906         https://bugs.webkit.org/show_bug.cgi?id=34173
907
908         * Scripts/webkitpy/style/cpp_style.py:
909         * Scripts/webkitpy/style/cpp_style_unittest.py:
910
911 2010-01-28  Joe Mason  <jmason@rim.com>
912
913         Reviewed by Adam Barth.
914
915         Limit login retries to 5
916         https://bugs.webkit.org/show_bug.cgi?id=34193
917
918         * Scripts/webkitpy/bugzilla.py:
919
920 2010-01-27  Martin Robinson  <mrobinson@webkit.org>
921
922         Adding myself to the committer list. No review necessary.
923
924         * Scripts/webkitpy/committers.py:
925
926 2010-01-27  George Wright  <gwright@rim.com>
927
928         Reviewed by Adam Treat.
929
930         https://bugs.webkit.org/show_bug.cgi?id=34216
931
932         Add missing include for wtf/Platform.h
933
934         * DumpRenderTree/AccessibilityController.h:
935
936 2010-01-27  Diego Gonzalez  <diego.gonzalez@openbossa.org>
937
938         Reviewed by Kenneth Rohde Christiansen.
939
940         [Qt] DRT Provide worker thread ability to track counters
941         https://bugs.webkit.org/show_bug.cgi?id=34221
942
943         Implement workerThreadCount() in LayoutTestController of Qt DRT
944
945         Tests:
946         fast/workers/dedicated-worker-lifecycle.html
947         fast/workers/shared-worker-frame-lifecycle.html
948         fast/workers/shared-worker-lifecycle.html
949         fast/workers/worker-lifecycle.html
950
951         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
952         (LayoutTestController::workerThreadCount):
953         * DumpRenderTree/qt/LayoutTestControllerQt.h:
954
955 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
956
957         Rubberstamped by Simon Hausmann.
958
959         [Qt] QtLauncher refactoring:
960
961         Make the LauncherWindow depend less on the view, so that more
962         code can be shared in near future.
963
964         * QtLauncher/main.cpp:
965         (LauncherWindow::sendTouchEvent):
966         (LauncherWindow::loadFinished):
967         (LauncherWindow::zoomIn):
968         (LauncherWindow::zoomOut):
969         (LauncherWindow::resetZoom):
970         (LauncherWindow::toggleZoomTextOnly):
971         (LauncherWindow::dumpHtml):
972         (LauncherWindow::selectElements):
973         (LauncherWindow::setupUI):
974
975 2010-01-27  Kinuko Yasuda  <kinuko@chromium.org>
976
977         Reviewed by Eric Seidel.
978
979         Correctly handle the KeyLocation argument that has been introduced
980         recently to test location-dependent key events in EventSender.keyDown.
981         http://bugs.webkit.org/show_bug.cgi?id=28247
982
983         Test: fast/events/keydown-numpad-keys.html
984
985         * DumpRenderTree/gtk/EventSender.cpp:
986         (keyDownCallback):
987
988 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
989
990         Rubberstamped by Simon Hausmann.
991
992         [Qt] QtLauncher refactoring:
993
994         Move out code from the MainWindow (renamed to LauncherWindow)
995         that is not depending on the view, and add it to a new class
996         called MainWindow.
997
998         * QtLauncher/QtLauncher.pro:
999         * QtLauncher/main.cpp:
1000         (LauncherWindow::LauncherWindow):
1001         (LauncherWindow::eventFilter):
1002         (LauncherWindow::loadStarted):
1003         (LauncherWindow::loadFinished):
1004         (LauncherWindow::newWindow):
1005         (LauncherWindow::setupUI):
1006         (WebPage::createWindow):
1007         (main):
1008         * QtLauncher/mainwindow.cpp: Added.
1009         (MainWindow::MainWindow):
1010         (MainWindow::buildUI):
1011         (MainWindow::page):
1012         (MainWindow::setAddressUrl):
1013         (MainWindow::addCompleterEntry):
1014         (MainWindow::load):
1015         (MainWindow::changeLocation):
1016         (MainWindow::openFile):
1017         * QtLauncher/mainwindow.h: Added.
1018
1019 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1020
1021         Rubberstamped by Simon Hausmann.
1022
1023         [Qt] QtLauncher, coding style fixes.
1024
1025         * QtLauncher/main.cpp:
1026         (MainWindow::MainWindow):
1027         (MainWindow::sendTouchEvent):
1028         (MainWindow::eventFilter):
1029         (MainWindow::loadURL):
1030         (MainWindow::setupUI):
1031         (WebPage::createPlugin):
1032
1033 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1034
1035         Rubberstamped by Simon Hausmann.
1036
1037         [Qt] QtLauncher refactoring, separating the webview and
1038         adding a QGraphicsWebView based version.
1039
1040         * QtLauncher/QtLauncher.pro:
1041         * QtLauncher/main.cpp:
1042         (MainWindow::MainWindow):
1043         * QtLauncher/webpage.h:
1044         * QtLauncher/webview.cpp: Added.
1045         (createContextMenu):
1046         (WebViewGraphicsBased::mousePressEvent):
1047         (WebViewTraditional::mousePressEvent):
1048         (WebViewGraphicsBased::contextMenuEvent):
1049         (WebViewTraditional::contextMenuEvent):
1050         * QtLauncher/webview.h: Added.
1051         (WebViewGraphicsBased::WebViewGraphicsBased):
1052         (WebViewTraditional::WebViewTraditional):
1053
1054 2010-01-27  Alexander Pavlov  <apavlov@chromium.org>
1055
1056         Adding myself as committer. No review necessary.
1057
1058         * Scripts/webkitpy/committers.py:
1059
1060 2010-01-27  Eric Seidel  <eric@webkit.org>
1061
1062         Reviewed by Darin Adler.
1063
1064         webkit-patch needs an open-bugs command
1065         https://bugs.webkit.org/show_bug.cgi?id=30793
1066
1067         * Scripts/test-webkitpy: import OpenBugsTest
1068         * Scripts/webkit-patch: import OpenBugs
1069         * Scripts/webkitpy/commands/download_unittest.py: don't import unittest
1070         * Scripts/webkitpy/commands/early_warning_system_unittest.py: ditto
1071         * Scripts/webkitpy/commands/queries_unittest.py: ditto
1072         * Scripts/webkitpy/commands/queues_unittest.py: ditto
1073         * Scripts/webkitpy/commands/upload_unittest.py: ditto
1074         * Scripts/webkitpy/mock_bugzillatool.py: log when user.open_url is called.
1075
1076 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1077
1078         Rubberstamped by Simon Hausmann
1079
1080         [Qt] QtLauncher refactoring, separating utility methods.
1081
1082         * QtLauncher/QtLauncher.pro:
1083         * QtLauncher/main.cpp:
1084         * QtLauncher/utils.cpp: Added.
1085         (urlFromUserInput):
1086         * QtLauncher/utils.h: Added.
1087
1088 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1089
1090         Rubberstamped by Simon Hausmann
1091
1092         [Qt] Refactor the code in the QtLauncher dealing with HTTP proxy.
1093
1094         * QtLauncher/main.cpp:
1095         (MainWindow::MainWindow):
1096         * QtLauncher/webpage.cpp:
1097         (WebPage::WebPage):
1098         (WebPage::applyProxy):
1099         * QtLauncher/webpage.h:
1100
1101 2010-01-26  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1102
1103         Reviewed by Tor Arne Vestbø.
1104
1105         [Qt] Corrects debug build of DumpRenderTree on Windows.
1106
1107         * DumpRenderTree/qt/DumpRenderTree.pro:
1108
1109 2010-01-26  Daniel Bates  <dbates@webkit.org>
1110
1111         Reviewed by Adam Barth.
1112
1113         https://bugs.webkit.org/show_bug.cgi?id=34070
1114
1115         Moves the try/catch for OSError exceptions in Executive.run_command
1116         to Credentials.read_credentials() so that the unit test
1117         webkitpy.scm_unittest.SCMClassTests.test_error_handlers can
1118         assert that Executive.run_command throws an OSError exception.
1119
1120         * Scripts/webkitpy/credentials.py:
1121         * Scripts/webkitpy/executive.py: Moved try/catch for OSError to
1122         method Credentials.read_credentials().
1123         * Scripts/webkitpy/executive_unittest.py: Removed tests that no longer
1124         apply: test_run_command_with_bad_command_check_return_code and
1125         test_run_command_with_bad_command_check_calls_error_handler. Added new
1126         test to assert that run_command throws OSError exceptions.
1127
1128 2010-01-26  Diego Gonzalez  <diego.gonzalez@openbossa.org>
1129
1130         Reviewed by Kenneth Rohde Christiansen.
1131
1132         [Qt] DRT WebHistory support
1133         https://bugs.webkit.org/show_bug.cgi?id=34167
1134
1135         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1136         (LayoutTestController::reset):
1137         (LayoutTestController::webHistoryItemCount):
1138         (LayoutTestController::keepWebHistory):
1139         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1140
1141 2010-01-26  Kent Tamura  <tkent@chromium.org>
1142
1143         Reviewed by Eric Seidel.
1144
1145         [Win] Add modifiers parameter support to Windows DumpRenderTree
1146         https://bugs.webkit.org/show_bug.cgi?id=34068
1147
1148         Add support for functional name modifiers; "addSelectionKey" and
1149         "rangeSelectionKey", and modifiers parameter to eventSender.mouseDown()
1150         and eventSender.mouseUp().
1151         This change is similar to r53498 for Mac.
1152         
1153         * DumpRenderTree/win/EventSender.cpp:
1154         (buildModifierFlags): New function to set MK_CONTROL or MK_SHIFT to WPARAM.
1155         (mouseDownCallback): Call buidlModifiersFlags().
1156         (mouseUpCallback): ditto.
1157         (keyDownCallback): Add support for "addSelectionkey" and "rangeSelectionKey".
1158
1159 2010-01-26  Chris Jerdonek  <cjerdonek@webkit.org>
1160
1161         Reviewed by Eric Seidel.
1162
1163         The Python autoinstall cache directory now only gets created
1164         in the directory containing autoinstall.py.
1165
1166         https://bugs.webkit.org/show_bug.cgi?id=33365
1167
1168         * Scripts/webkitpy/autoinstall.py:
1169           - Also added a README file to the cache directory saying
1170             where it came from.
1171
1172 2010-01-26  Chris Jerdonek  <cjerdonek@webkit.org>
1173
1174         Reviewed by Eric Seidel.
1175
1176         Moved the check-webkit-style processors into a new
1177         webkitpy/style/processors directory.
1178
1179         https://bugs.webkit.org/show_bug.cgi?id=34060
1180
1181         * Scripts/webkitpy/style/checker.py:
1182         * Scripts/webkitpy/style/checker_unittest.py:
1183         * Scripts/webkitpy/style/cpp_style.py: Removed.
1184         * Scripts/webkitpy/style/cpp_style_unittest.py: Removed.
1185         * Scripts/webkitpy/style/processors: Added.
1186         * Scripts/webkitpy/style/processors/__init__.py: Added.
1187         * Scripts/webkitpy/style/processors/cpp.py: Copied from WebKitTools/Scripts/webkitpy/style/cpp_style.py.
1188         * Scripts/webkitpy/style/processors/cpp_unittest.py: Copied from WebKitTools/Scripts/webkitpy/style/cpp_style_unittest.py.
1189         * Scripts/webkitpy/style/processors/text.py: Copied from WebKitTools/Scripts/webkitpy/style/text_style.py.
1190         * Scripts/webkitpy/style/processors/text_unittest.py: Copied from WebKitTools/Scripts/webkitpy/style/text_style_unittest.py.
1191         * Scripts/webkitpy/style/text_style.py: Removed.
1192         * Scripts/webkitpy/style/text_style_unittest.py: Removed.
1193         * Scripts/webkitpy/style/unittests.py:
1194
1195 2010-01-26  Kevin Ollivier  <kevino@theolliviers.com>
1196
1197         [wx] Build fix, make sure stub function returns a value.
1198
1199         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1200         (LayoutTestController::counterValueForElementById):
1201
1202 2010-01-26  Steve Falkenburg  <sfalken@apple.com>
1203
1204         Reviewed by Oliver Hunt.
1205
1206         Windows build references non-existent include paths
1207         https://bugs.webkit.org/show_bug.cgi?id=34175
1208
1209         * DumpRenderTree/win/DumpRenderTree.vcproj:
1210         * DumpRenderTree/win/ImageDiff.vcproj:
1211         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1212
1213 2010-01-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1214
1215         Reviewed by Ariya Hidayat.
1216
1217         [Qt] Separating out the UrlLoader from the QtLauncher in it's
1218         own implementation and header file.
1219
1220         * QtLauncher/main.cpp:
1221         (main):
1222         * QtLauncher/urlloader.cpp: Added.
1223         (UrlLoader::UrlLoader):
1224         (UrlLoader::loadNext):
1225         (UrlLoader::init):
1226         (UrlLoader::getUrl):
1227         * QtLauncher/urlloader.h: Added.
1228
1229 2010-01-25  Chris Jerdonek  <cjerdonek@webkit.org>
1230
1231         Reviewed by Shinichiro Hamaji.
1232
1233         Refactored check-webkit-style by removing the file path
1234         parameter from the style error handler functions.
1235
1236         https://bugs.webkit.org/show_bug.cgi?id=34031
1237
1238         * Scripts/webkitpy/style/checker.py:
1239           - Added _default_style_error_handler() to StyleChecker class.
1240           - Moved handle_style_error() to inside _default_style_error_handler().
1241
1242         * Scripts/webkitpy/style/checker_unittest.py:
1243           - Removed file path from calls to error handler.
1244
1245         * Scripts/webkitpy/style/cpp_style.py:
1246           - Removed file path from calls to error handler.
1247
1248         * Scripts/webkitpy/style/cpp_style_unittest.py:
1249           - Removed file path from calls to error handler.
1250
1251         * Scripts/webkitpy/style/text_style.py:
1252           - Removed file path from calls to error handler.
1253
1254         * Scripts/webkitpy/style/text_style_unittest.py:
1255           - Removed file path from calls to error handler.
1256
1257 2010-01-25  Jeremy Orlow  <jorlow@chromium.org>
1258
1259         Adding myself as reviewer.  No review necessary.
1260
1261         * Scripts/webkitpy/committers.py:
1262
1263 2010-01-25  Chris Jerdonek  <cjerdonek@webkit.org>
1264
1265         Reviewed by Adam Barth.
1266
1267         Improved prepare-ChangeLog so that it preserves the relative
1268         indentation of a git commit message.
1269
1270         https://bugs.webkit.org/show_bug.cgi?id=34058
1271
1272         * Scripts/prepare-ChangeLog:
1273           - Also adjusted the script so that it does not add white
1274             space characters to empty lines.
1275
1276 2010-01-24  Eric Seidel  <eric@webkit.org>
1277
1278         No review, rolling out r53763.
1279         http://trac.webkit.org/changeset/53763
1280         https://bugs.webkit.org/show_bug.cgi?id=33895
1281
1282         Broke 20+ tests on Windows.
1283
1284         * Scripts/run-webkit-tests:
1285         * Scripts/webkitdirs.pm:
1286
1287 2010-01-24  Adam Barth  <abarth@webkit.org>
1288
1289         Rubber stamped by Eric Seidel.
1290
1291         More pep8 compliance.
1292
1293         * Scripts/webkitpy/mock_bugzillatool.py:
1294
1295 2010-01-24  Adam Barth  <abarth@webkit.org>
1296
1297         Rubber stamped by Eric Seidel.
1298
1299         More pep8 compliance.
1300
1301         * Scripts/webkitpy/executive.py:
1302         * Scripts/webkitpy/grammar.py:
1303
1304 2010-01-24  Adam Barth  <abarth@webkit.org>
1305
1306         Rubber stamped by Eric Seidel.
1307
1308         More pep8 compliance.
1309
1310         * Scripts/webkitpy/comments.py:
1311         * Scripts/webkitpy/committers.py:
1312         * Scripts/webkitpy/credentials.py:
1313
1314 2010-01-24  Adam Barth  <abarth@webkit.org>
1315
1316         Rubber stamped by Eric Seidel.
1317
1318         Make changelogs.py pass pep8.
1319
1320         * Scripts/webkitpy/changelogs.py:
1321
1322 2010-01-23  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1323
1324         [Qt] Unreviewed build fix
1325
1326         * QtLauncher/QtLauncher.pro:
1327         * QtLauncher/webinspector.h:
1328
1329 2010-01-23  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1330
1331         Rubberstamped by Simon Hausmann.
1332
1333         [Qt] Move the WebInspector class to it's own header file.
1334
1335         * QtLauncher/main.cpp:
1336         * QtLauncher/webinspector.h: Added.
1337         (WebInspector::WebInspector):
1338         (WebInspector::showEvent):
1339         (WebInspector::hideEvent):
1340
1341 2010-01-23  Robert Hogan  <robert@roberthogan.net>
1342
1343         Reviewed by Kenneth Rohde Christiansen.
1344
1345         Qt DRT: respect window.close() and window.closed()
1346         
1347         Qt DRT needs to maintain a correct count of open windows
1348         for windowCount(). It also needs to delete windows that
1349         have been closed by window.close().
1350         
1351         This fixes the following tests:
1352         
1353         plugins/destroy-during-npp-new.html
1354         fast/dom/Document/early-document-access.html
1355         fast/dom/Window/window-early-properties.html
1356         fast/events/open-window-from-another-frame.html
1357         fast/events/popup-blocking-click-in-iframe.html
1358         
1359         https://bugs.webkit.org/show_bug.cgi?id=32953
1360
1361         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1362         (WebCore::DumpRenderTree::DumpRenderTree):
1363         (WebCore::DumpRenderTree::createWindow):
1364         (WebCore::DumpRenderTree::windowCloseRequested):
1365         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1366         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1367         (LayoutTestController::maybeDump):
1368
1369 2010-01-23  Dan Bernstein  <mitz@apple.com>
1370
1371         Reviewed by Mark Rowe.
1372
1373         Added a user default for specifying a fallback frameworks path in case
1374         the bundle does not contain frameworks for the current Mac OS X version.
1375
1376         * WebKitLauncher/main.m:
1377         (fallbackMacOSXVersion): Added. Looks up the fallback version in a dictionary
1378         keyed by the FallbackSystemVersions user default and returns it.
1379         (main): If a frameworks directory for the current system version is not found,
1380         try the fallback.
1381
1382 2010-01-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1383
1384         Reviewed by Simon Hausmann.
1385
1386         Make run-webkit-tests work under Cygwin for the Qt port
1387
1388         setPathForRunningWebKitApp() is implemented for the Qt port
1389         by using qmake to query for the location of the Qt libraries.
1390
1391         This requires the original environment (%ENV) to be untouched,
1392         so launchWithCurrentEnv() was refactored to launchWithEnv(),
1393         and the code in openDumpTool() to not use %ENV but a %CLEAN_ENV
1394         instead. This has the added benefit of getting rid of the temp
1395         variables used for storing the current env.
1396
1397         openDumpTool() is also refactored a bit into platform-spesific,
1398         port-spesific, and generic environment variables.
1399
1400         Checks for undef was added a few places to fix Perl concat
1401         warnings when run-webkit-tests is aborted.
1402
1403         https://bugs.webkit.org/show_bug.cgi?id=33895
1404
1405         * Scripts/run-webkit-tests:
1406         * Scripts/webkitdirs.pm:
1407
1408 2010-01-22  Kevin Watters  <kevinwatters@gmail.com>
1409
1410         Reviewed by Kevin Ollivier.
1411
1412         [wx] Remove the Bakefile build system, which is no longer being used.
1413         
1414         https://bugs.webkit.org/show_bug.cgi?id=34022
1415
1416         * DumpRenderTree/wx/DumpRenderTree.bkl: Removed.
1417         * wx/browser/browser.bkl: Removed.
1418         * wx/build-wxwebkit: Removed.
1419
1420 2010-01-22  Gustavo Noronha Silva  <gns@gnome.org>
1421
1422         Reviewed by Simon Fraser.
1423
1424         Reset zoom level to 1.0 when resetting view state. This is causing
1425         many tests to fail after svg/custom/text-zoom.xhtml changes the
1426         zoom level.
1427
1428         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1429         (resetDefaultsToConsistentValues):
1430
1431 2010-01-22  Steve Falkenburg  <sfalken@apple.com>
1432
1433         Reviewed by Darin Adler.
1434
1435         https://bugs.webkit.org/show_bug.cgi?id=34025
1436         Enable client-based Geolocation abstraction for Mac, Windows AppleWebKit targets.
1437
1438         * Scripts/build-webkit:
1439
1440 2010-01-22  Adam Barth  <abarth@webkit.org>
1441
1442         Unreviewed.  Arg.  Someone renamed limit to output_limit on me.
1443
1444         * Scripts/webkitpy/commands/queues.py:
1445
1446 2010-01-22  Adam Barth  <abarth@webkit.org>
1447
1448         Rubber stamped by Eric Seidel.
1449
1450         Make __init__.py and buildbot.py pass pep8 style checker.
1451
1452         * Scripts/webkitpy/__init__.py:
1453         * Scripts/webkitpy/buildbot.py:
1454
1455 2010-01-21  Joe Mason  <jmason@rim.com>
1456
1457         Reviewed by Adam Barth.
1458
1459         webkit-patch should retry on invalid password
1460         https://bugs.webkit.org/show_bug.cgi?id=33955
1461
1462         Ask for bugs.webkit.org authentication in a loop.
1463
1464         * Scripts/webkitpy/bugzilla.py:
1465
1466 2010-01-22  Adam Barth  <abarth@webkit.org>
1467
1468         Unreviewed.  Don't call seek on a NoneType.
1469
1470         * Scripts/webkitpy/statusserver.py:
1471
1472 2010-01-22  Petri Latvala  <petri.latvala@nomovok.com>
1473
1474         Reviewed by David Levin.
1475
1476         check-webkit-style breaks on files with unknown types
1477         https://bugs.webkit.org/show_bug.cgi?id=34001
1478
1479         For files with type FileType.NONE, dispatch_processor returns None.
1480
1481         * Scripts/webkitpy/style/checker.py: Don't call process_file with a processor of value None.
1482
1483 2010-01-22  Adam Barth  <abarth@webkit.org>
1484
1485         Reviewed by Eric Seidel.
1486
1487         Make bugzilla.py and webkitport.py conform to pep8
1488         https://bugs.webkit.org/show_bug.cgi?id=34015
1489
1490         This patch makes webkitport.py and bugzilla.py mostly conform to PEP8
1491         style as enforced by pep8.py.  I wasn't able to get rid of all the
1492         errors because I'm not sure how to wrap some lines properly.  Also,
1493         there are a few deprication errors that I couldn't resolve easily.
1494         However, this is a massive improvement in compliance.
1495
1496         * Scripts/webkitpy/bugzilla.py:
1497         * Scripts/webkitpy/webkitport.py:
1498
1499 2010-01-22  Adam Barth  <abarth@webkit.org>
1500
1501         Reviewed by Darin Adler.
1502
1503         Limit length of EWS results to 5MB
1504         https://bugs.webkit.org/show_bug.cgi?id=34016
1505
1506         Hopefully this will fix the bug where the results link doesn't appear.
1507         Our current theory is that the results blob is too big and the server
1508         is rejecting the request with a 500 error.  That causes us to re-try
1509         the post, but when we re-try the StringIO buffer has its seek pointer
1510         at the end.
1511
1512         * Scripts/webkitpy/commands/queues.py:
1513         * Scripts/webkitpy/statusserver.py:
1514
1515 2010-01-22  Chris Jerdonek  <cjerdonek@webkit.org>
1516
1517         Reviewed by Adam Barth.
1518
1519         Made check-webkit-style able to check patches when script not
1520         run from source root. Also consolidated external references
1521         to a single file.
1522
1523         https://bugs.webkit.org/show_bug.cgi?id=33791
1524
1525         * Scripts/check-webkit-style:
1526           - Changed to import style_references.py.
1527
1528         * Scripts/webkitpy/style/__init__.py:
1529           - Removed __path__ hack that allowed searching Scripts/ directory.
1530
1531         * Scripts/webkitpy/style/checker.py:
1532           - Changed to import style_references.py.
1533
1534         * Scripts/webkitpy/style_references.py: Added.
1535
1536 2010-01-22  Dmitry Titov  <dimich@chromium.org>
1537
1538         Reviewed by Maciej Stachowiak.
1539
1540         Fix the leak of ThreadIdentifiers in threadMap across threads.
1541         https://bugs.webkit.org/show_bug.cgi?id=32689
1542
1543         Add a new test to verify the ThreadIdentifiers are not reused across threads.
1544         The test runs in the beginning of DumpRenderTree and spawns 2 non-WTF treads sequentially,
1545         waiting for the previous thread to terminate before starting the next.
1546         The treads use WTF::currentThread() in their thread function. Without a fix, this
1547         causes both threads to have the same ThreadIdentifier which triggers ASSERT in thread function.
1548         It also starts another thread using WTF. Without the fix, this finds pthread handle from previous
1549         threads in the WTF threadMap and asserts in WTF::establishIdentifierForPthreadHandle().
1550         The test practically does not affect the DRT run time because the threads end immediately.
1551
1552         * DumpRenderTree/mac/DumpRenderTree.mm:
1553         (runThread): Test thread function.
1554         (testThreadIdentifierMap):
1555         (dumpRenderTree):
1556
1557 2010-01-22  Kent Tamura  <tkent@chromium.org>
1558
1559         Reviewed by Maciej Stachowiak.
1560
1561         Fix a bug that mouseDown:withModifiers: is never called.
1562         https://bugs.webkit.org/show_bug.cgi?id=33989
1563
1564         * DumpRenderTree/mac/EventSendingController.mm:
1565         (+[EventSendingController isSelectorExcludedFromWebScript:]):
1566         (+[EventSendingController webScriptNameForSelector:]):
1567
1568 2010-01-22  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1569
1570         Rubberstamped by Antti Koivisto.
1571
1572         [Qt] Separate out the WebPage class into it's own
1573         cpp/header files. Also, removed the assumption that
1574         the view is a QWebView, in preparation of a merger
1575         of the two Qt WebKit launchers.
1576
1577         * QtLauncher/QtLauncher.pro:
1578         * QtLauncher/main.cpp:
1579         (WebView::mousePressEvent):
1580         * QtLauncher/webpage.cpp: Added.
1581         (WebPage::supportsExtension):
1582         (WebPage::extension):
1583         (WebPage::acceptNavigationRequest):
1584         (WebPage::openUrlInDefaultBrowser):
1585         * QtLauncher/webpage.h: Added.
1586         (WebPage::WebPage):
1587
1588 2010-01-21  Chris Jerdonek  <cjerdonek@webkit.org>
1589
1590         Reviewed by Shinichiro Hamaji.
1591
1592         Refactored to move file name and file-reading related code
1593         from cpp_style.py and text_style.py to checker.py.
1594
1595         https://bugs.webkit.org/show_bug.cgi?id=33775
1596
1597         * Scripts/check-webkit-style:
1598           - Updates caused by changes to checker.py.
1599
1600         * Scripts/webkitpy/style/checker.py:
1601           - Added SKIPPED_FILES_WITH_WARNING list.
1602           - Added SKIPPED_FILES_WITHOUT_WARNING list.
1603           - Added FileType class.
1604           - Added ProcessorDispatcher class.
1605           - In StyleChecker class:
1606             - Renamed process_patch() to check_patch().
1607             - Renamed process_file() to check_file().
1608             - Added _process_file().
1609             - Related refactoring.
1610             - Addressed check_patch() FIXME to share code with process_file().
1611
1612         * Scripts/webkitpy/style/checker_unittest.py:
1613           - Added ProcessorDispatcherSkipTest class.
1614           - Added ProcessorDispatcherDispatchTest class.
1615           - Added StyleCheckerCheckFileTest class.
1616
1617         * Scripts/webkitpy/style/cpp_style.py:
1618           - Renamed process_file_data() to _process_lines.
1619           - Removed process_file() (moved logic to checker.py).
1620           - Removed can_handle() (moved logic to checker.py).
1621           - Added CppProcessor class.
1622           - Removed is_exempt() (moved logic to checker.py).
1623           - Added process_file_data() back as a wrapper function.
1624
1625         * Scripts/webkitpy/style/cpp_style_unittest.py:
1626           - Removed test_can_handle().
1627           - Removed test_is_exempt().
1628           - Added CppProcessorTest class.
1629
1630         * Scripts/webkitpy/style/text_style.py:
1631           - Added TextProcessor class.
1632           - Removed process_file().
1633           - Removed can_handle().
1634
1635         * Scripts/webkitpy/style/text_style_unittest.py:
1636           - Removed test_can_handle().
1637           - Added TextProcessorTest class.
1638
1639 2010-01-21  Chris Jerdonek  <cjerdonek@webkit.org>
1640
1641         Reviewed by David Kilzer.
1642
1643         Create a unit-tested subroutine to parse patch files created
1644         by svn-create-patch.
1645
1646         https://bugs.webkit.org/show_bug.cgi?id=33475
1647
1648         * Scripts/VCSUtils.pm:
1649           - Added parseDiff().
1650           - Added parsePatch().
1651
1652         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Added.
1653           - Added unit tests for parseDiff().
1654
1655         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
1656           - Total number of tests now computed dynamically.
1657
1658         * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl: Added.
1659           - Added unit tests for parsePatch().
1660
1661 2010-01-21  Kevin Ollivier  <kevino@theolliviers.com>
1662
1663         [wx] Build fix, add new directory to dir list.
1664
1665         * wx/build/settings.py:
1666
1667 2010-01-21  Adam Barth  <abarth@webkit.org>
1668
1669         Reviewed by Eric Seidel.
1670
1671         Make the EWS transactional
1672         https://bugs.webkit.org/show_bug.cgi?id=33978
1673
1674         Now if the EWS gets interrupted in the middle of processing a patch,
1675         the bots will re-process the patch.
1676
1677         * Scripts/test-webkitpy:
1678         * Scripts/webkitpy/commands/queues.py:
1679         * Scripts/webkitpy/commands/queues_unittest.py:
1680         * Scripts/webkitpy/patchcollection.py:
1681         * Scripts/webkitpy/patchcollection_unittest.py: Added.
1682
1683 2010-01-21  Adam Barth  <abarth@webkit.org>
1684
1685         Unreviewed.  Add missing "ago" for style in the status bubble.
1686
1687         * QueueStatusServer/templates/statusbubble.html:
1688
1689 2010-01-21  Adam Barth  <abarth@webkit.org>
1690
1691         Reviewed by David Levin.
1692
1693         [style-queue] should not complain about identifier names with underscores under WebKit/gtk/webkit/
1694         https://bugs.webkit.org/show_bug.cgi?id=33356
1695
1696         White list unix_hacker_style names in WebKit/gtk/webkit because these
1697         are used in the GTK+ API.
1698
1699         * Scripts/webkitpy/style/cpp_style.py:
1700         * Scripts/webkitpy/style/cpp_style_unittest.py:
1701
1702 2010-01-21  Diego Gonzalez  <diego.gonzalez@openbossa.org>
1703
1704         Reviewed by Kenneth Rohde Christiansen.
1705
1706         [Qt] add setDomainRelaxationForbiddenForURLScheme in Qt DRT
1707         https://bugs.webkit.org/show_bug.cgi?id=33945
1708
1709         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1710         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
1711         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1712
1713 2010-01-21  Simon Hausmann  <simon.hausmann@nokia.com>
1714
1715         No review, rolling out 53615 as it causes two
1716         crashes on the bot.
1717
1718         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1719         (WebCore::DumpRenderTree::DumpRenderTree):
1720         (WebCore::DumpRenderTree::createWindow):
1721         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1722         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1723         (LayoutTestController::maybeDump):
1724
1725 2010-01-21  Robert Hogan  <robert@roberthogan.net>
1726
1727         Reviewed by Simon Hausmann.
1728
1729         Qt DRT: respect window.close() and window.closed()
1730
1731         Qt DRT needs to maintain a correct count of open windows
1732         for windowCount(). It also needs to delete windows that
1733         have been closed by window.close().
1734
1735         This fixes the following tests:
1736
1737         plugins/destroy-during-npp-new.html
1738         fast/dom/Document/early-document-access.html
1739         fast/dom/Window/window-early-properties.html
1740         fast/events/open-window-from-another-frame.html
1741         fast/events/popup-blocking-click-in-iframe.html
1742
1743         https://bugs.webkit.org/show_bug.cgi?id=32953
1744
1745         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1746         (WebCore::DumpRenderTree::DumpRenderTree):
1747         (WebCore::DumpRenderTree::createWindow):
1748         (WebCore::DumpRenderTree::windowCloseRequested):
1749         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1750         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1751         (LayoutTestController::maybeDump):
1752
1753 2010-01-20  Eric Seidel  <eric@webkit.org>
1754
1755         No review, rolling out r53593.
1756         http://trac.webkit.org/changeset/53593
1757         https://bugs.webkit.org/show_bug.cgi?id=33496
1758
1759         Re-rollout this patch, the commit-queue should not have landed
1760         it again, but it did due to land-diff and rollout both not
1761         clearing flags.
1762
1763         * Scripts/webkitpy/commands/early_warning_system.py:
1764         * Scripts/webkitpy/commands/queues.py:
1765         * Scripts/webkitpy/queueengine.py:
1766         * Scripts/webkitpy/scm.py:
1767         * Scripts/webkitpy/scm_unittest.py:
1768
1769 2010-01-20  Eric Seidel  <eric@webkit.org>
1770
1771         Reviewed by Adam Barth.
1772
1773         webkit-commit-queue status page is confusing
1774         https://bugs.webkit.org/show_bug.cgi?id=33496
1775
1776         This should improve the status page by removing more Fail messages.
1777         To do this, I re-factored the CommitQueue and the AbstractReviewQueues
1778         to behave more like one another.  This meant moving where the failure reporting was done.
1779         Previously the AbstractReviewQueue always used the parent process to report the error,
1780         while CommitQueue used the subprocess when possible, and the parent only reported errors
1781         that we didn't know how to handle (bugs in the commit-queue itself).
1782         Now the AbstractReviewQueue follow's the commit-queue's model.  This got rid of a try-block
1783         in both implementations and required teaching handle_script_error in each to post Fail messages
1784         to the status server instead of calling exit(1).
1785
1786         This will also make the style-queue share more bug posting logic with other queues:
1787         https://bugs.webkit.org/show_bug.cgi?id=33871
1788
1789         * Scripts/webkitpy/commands/early_warning_system.py:
1790          - Don't exit(1) as that will cause the calling queue to also report Fail to the status server.
1791            Implementors of handle_script_error are expected to update the status server if needed, but only exit if the error could not be handled.
1792            So we instead pass patch_has_failed_this_queue=True to _update_status_for_script_error in the case that this was a real failure.
1793            _update_status_for_script_error knows how to post the Fail message to the status server.
1794          - Teach _update_status_for_script_error how to post Fail messages to the status server.
1795         * Scripts/webkitpy/commands/queues.py:
1796          - Remove the try block from process_work_item since the caller already has one.
1797          - Only CC watchers on failure to cut down on commit-queue generated mail.
1798          - handle_unexpected_error needs to mark _did_fail now that the try block is gone from process_work_item.
1799          - Abstract _format_script_error_output_for_bug to share code between all queues.
1800          - The new _format_script_error_output_for_bug allows the style-queue to share the posting limit with other queues, as well as support linking to the full output.
1801          - Rename _can_build_and_test to _current_checkout_builds_and_passes_tests to better explain what revision it's testing.
1802          - Move logging out of _can_build_and_test and make the logs explain what revision we're testing.
1803          - handle_script_error now posts Fail instead of the try block in process_work_item handling it.
1804         * Scripts/webkitpy/queueengine.py:
1805          - QueueEngine is no longer used just by the commit-queue, update the logging to say "processing" instead of landing.
1806         * Scripts/webkitpy/scm.py:
1807          - Add new checkout_revision function.
1808         * Scripts/webkitpy/scm_unittest.py:
1809          - Test our new checkout_revision function.
1810
1811 2010-01-20  Fumitoshi Ukai  <ukai@chromium.org>
1812
1813         Reviewed by Alexey Proskuryakov.
1814
1815         WebSocket: Missing Request-URI, when no tralling slash in host
1816         https://bugs.webkit.org/show_bug.cgi?id=33689
1817
1818         Update pywebsocket to 0.4.7.1, which supports alias for resource
1819         name, so that we could test for ws://127.0.0.1:8880
1820
1821         * Scripts/run-webkit-tests:
1822         * Scripts/run-webkit-websocketserver:
1823         * pywebsocket/mod_pywebsocket/dispatch.py:
1824         * pywebsocket/mod_pywebsocket/handshake.py:
1825         * pywebsocket/mod_pywebsocket/standalone.py:
1826         * pywebsocket/setup.py:
1827         * pywebsocket/test/test_dispatch.py:
1828         * pywebsocket/test/test_handshake.py:
1829
1830 2010-01-20  Eric Seidel  <eric@webkit.org>
1831
1832         No review, rolling out r53537.
1833         http://trac.webkit.org/changeset/53537
1834         https://bugs.webkit.org/show_bug.cgi?id=33496
1835
1836         Added a failure condition to the commit-queue and looks to
1837         have broken the EWS bots
1838
1839         * Scripts/webkitpy/commands/early_warning_system.py:
1840         * Scripts/webkitpy/commands/queues.py:
1841         * Scripts/webkitpy/queueengine.py:
1842         * Scripts/webkitpy/scm.py:
1843         * Scripts/webkitpy/scm_unittest.py:
1844
1845 2010-01-20  Jon Honeycutt  <jhoneycutt@apple.com>
1846
1847         MSAA: accSelect() is not implemented
1848
1849         https://bugs.webkit.org/show_bug.cgi?id=33918
1850         <rdar://problem/7436861>
1851
1852         Reviewed by Darin Adler.
1853
1854         * DumpRenderTree/AccessibilityUIElement.cpp:
1855         (takeFocusCallback):
1856         Call the object's takeFocus() function.
1857         (takeSelectionCallback):
1858         Call its takeSelection() function.
1859         (addSelectionCallback):
1860         Call its addSelection() function.
1861         (removeSelectionCallback):
1862         Call its removeSelection() function.
1863         (AccessibilityUIElement::getJSClass):
1864         Add new functions to the JS class definition.
1865
1866         * DumpRenderTree/AccessibilityUIElement.h:
1867         Declare new functions.
1868
1869         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1870         (AccessibilityUIElement::takeFocus):
1871         Stubbed.
1872         (AccessibilityUIElement::takeSelection):
1873         Stubbed.
1874         (AccessibilityUIElement::addSelection):
1875         Stubbed.
1876         (AccessibilityUIElement::removeSelection):
1877         Stubbed.
1878
1879         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1880         (AccessibilityUIElement::takeFocus):
1881         Stubbed.
1882         (AccessibilityUIElement::takeSelection):
1883         Stubbed.
1884         (AccessibilityUIElement::addSelection):
1885         Stubbed.
1886         (AccessibilityUIElement::removeSelection):
1887         Stubbed.
1888
1889         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1890         (AccessibilityUIElement::takeFocus):
1891         Call the object's accSelect() function, passing the appropriate flag.
1892         (AccessibilityUIElement::takeSelection):
1893         Ditto.
1894         (AccessibilityUIElement::addSelection):
1895         Ditto.
1896         (AccessibilityUIElement::removeSelection):
1897         Ditto.
1898
1899 2010-01-20  Andras Becsi  <abecsi@inf.u-szeged.hu>
1900
1901         Reviewed by Alexey Proskuryakov.
1902
1903         Extract Apache handling to httpd.pm module and use the provided functionality
1904         in scripts where Apache is needed.
1905         The module httpd.pm stores the PID of Apache in a variable and cleans up
1906         the PID directory after Apache properly shut down. Catching INT and TERM
1907         signals allows the scripts to close Apache and clean up its PID directory
1908         even if the testing was interrupted.
1909
1910         https://bugs.webkit.org/show_bug.cgi?id=33153
1911
1912         * Scripts/webkitperl/httpd.pm: Added.
1913         * Scripts/run-iexploder-tests:
1914         * Scripts/run-webkit-httpd:
1915         * Scripts/run-webkit-tests:
1916
1917 2010-01-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1918
1919         Reviewed by Simon Hausmann.
1920
1921         [Qt] Make DumpRenderTree build on Windows
1922
1923         * DumpRenderTree/qt/DumpRenderTree.pro:
1924         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1925         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1926         * DumpRenderTree/qt/main.cpp:
1927
1928 2010-01-20  Steve Block  <steveblock@google.com>
1929
1930         Reviewed by Eric Seidel.
1931
1932         Fix commit bot to land patches in order of the bug last modification date.
1933         https://bugs.webkit.org/show_bug.cgi?id=33395
1934
1935         * Scripts/webkitpy/bugzilla.py: Modified. Added 'order=Last+Changed' to bugzilla commit queue URL.
1936
1937 2010-01-20  Adam Barth  <abarth@webkit.org>
1938
1939         Reviewed by Eric Seidel.
1940
1941         Teach check-webkit-style about WebKit/gtk/tests
1942         https://bugs.webkit.org/show_bug.cgi?id=33892
1943
1944         Removes false positives found in
1945         https://bugs.webkit.org/show_bug.cgi?id=30883
1946
1947         * Scripts/webkitpy/style/cpp_style.py:
1948         * Scripts/webkitpy/style/cpp_style_unittest.py:
1949
1950 2010-01-20  Adam Barth  <abarth@webkit.org>
1951
1952         Reviewed by Eric Seidel.
1953
1954         Teach check-webkit-style about QGVLauncher
1955         https://bugs.webkit.org/show_bug.cgi?id=33890
1956
1957         Remove false positives found in
1958         https://bugs.webkit.org/show_bug.cgi?id=33708
1959
1960         * Scripts/webkitpy/style/cpp_style.py:
1961         * Scripts/webkitpy/style/cpp_style_unittest.py:
1962
1963 2010-01-20  Eric Seidel  <eric@webkit.org>
1964
1965         Reviewed by Adam Barth.
1966
1967         webkit-commit-queue status page is confusing
1968         https://bugs.webkit.org/show_bug.cgi?id=33496
1969
1970         This should improve the status page by removing more Fail messages.
1971         To do this, I re-factored the CommitQueue and the AbstractReviewQueues
1972         to behave more like one another.  This meant moving where the failure reporting was done.
1973         Previously the AbstractReviewQueue always used the parent process to report the error,
1974         while CommitQueue used the subprocess when possible, and the parent only reported errors
1975         that we didn't know how to handle (bugs in the commit-queue itself).
1976         Now the AbstractReviewQueue follow's the commit-queue's model.  This got rid of a try-block
1977         in both implementations and required teaching handle_script_error in each to post Fail messages
1978         to the status server instead of calling exit(1).
1979
1980         This will also make the style-queue share more bug posting logic with other queues:
1981         https://bugs.webkit.org/show_bug.cgi?id=33871
1982
1983         * Scripts/webkitpy/commands/early_warning_system.py:
1984          - Don't exit(1) as that will cause the calling queue to also report Fail to the status server.
1985            Implementors of handle_script_error are expected to update the status server if needed, but only exit if the error could not be handled.
1986            So we instead pass patch_has_failed_this_queue=True to _update_status_for_script_error in the case that this was a real failure.
1987            _update_status_for_script_error knows how to post the Fail message to the status server.
1988          - Teach _update_status_for_script_error how to post Fail messages to the status server.
1989         * Scripts/webkitpy/commands/queues.py:
1990          - Remove the try block from process_work_item since the caller already has one.
1991          - Only CC watchers on failure to cut down on commit-queue generated mail.
1992          - handle_unexpected_error needs to mark _did_fail now that the try block is gone from process_work_item.
1993          - Abstract _format_script_error_output_for_bug to share code between all queues.
1994          - The new _format_script_error_output_for_bug allows the style-queue to share the posting limit with other queues, as well as support linking to the full output.
1995          - Rename _can_build_and_test to _current_checkout_builds_and_passes_tests to better explain what revision it's testing.
1996          - Move logging out of _can_build_and_test and make the logs explain what revision we're testing.
1997          - handle_script_error now posts Fail instead of the try block in process_work_item handling it.
1998         * Scripts/webkitpy/queueengine.py:
1999          - QueueEngine is no longer used just by the commit-queue, update the logging to say "processing" instead of landing.
2000         * Scripts/webkitpy/scm.py:
2001          - Add new checkout_revision function.
2002         * Scripts/webkitpy/scm_unittest.py:
2003          - Test our new checkout_revision function.
2004
2005 2010-01-20  Adam Barth  <abarth@webkit.org>
2006
2007         Reviewed by Darin Adler.
2008
2009         Exempt JavaScriptCore/qt/api from style checks
2010         https://bugs.webkit.org/show_bug.cgi?id=33879
2011
2012         Apparently there is a JavaScriptCore API for Qt as well as a WebKit
2013         API.
2014
2015         * Scripts/webkitpy/style/cpp_style.py:
2016         * Scripts/webkitpy/style/cpp_style_unittest.py:
2017
2018 2010-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2019
2020         Reviewed by Simon Hausmann.
2021
2022         [Qt] Don't use QSocketNotifier in the DRT for reading stdin
2023
2024         QSocketNotifier is not available on Windows. Instead we read
2025         stdin synchronously after each test using signals and slots.
2026
2027         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2028         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2029         * DumpRenderTree/qt/main.cpp:
2030
2031 2010-01-19  Adam Barth  <abarth@webkit.org>
2032
2033         Rubber stamped by Eric Seidel.
2034
2035         Move chromium-ews back to building release only to make the EWS faster.
2036
2037         * Scripts/webkitpy/commands/early_warning_system.py:
2038
2039 2010-01-17  Jon Honeycutt  <jhoneycutt@apple.com>
2040
2041         MSAA: The child <option> elements of a non-multiple <select> are not
2042         exposed
2043
2044         https://bugs.webkit.org/show_bug.cgi?id=33773
2045         <rdar://problem/7550556>
2046
2047         Reviewed by Alice Liu.
2048
2049         * DumpRenderTree/AccessibilityUIElement.cpp:
2050         (getIsVisibleCallback):
2051         Call the object's isVisible() function.
2052         (getIsOffScreenCallback):
2053         Ditto, for isOffScreen().
2054         (getIsCollapsedCallback):
2055         Ditto, for isCollapsed().
2056         (getHasPopupCallback):
2057         Ditto, for hasPopup().
2058         (AccessibilityUIElement::getJSClass):
2059         Add isVisible and isOffScreen attributes.
2060
2061         * DumpRenderTree/AccessibilityUIElement.h:
2062         Declare new functions.
2063
2064         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2065         (AccessibilityUIElement::isVisible):
2066         Stubbed.
2067         (AccessibilityUIElement::isOffScreen):
2068         Stubbed.
2069         (AccessibilityUIElement::isCollapsed):
2070         Stubbed.
2071         (AccessibilityUIElement::hasPopup):
2072         Stubbed.
2073
2074         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2075         (AccessibilityUIElement::isVisible):
2076         Stubbed.
2077         (AccessibilityUIElement::isOffScreen):
2078         Stubbed.
2079         (AccessibilityUIElement::isCollapsed):
2080         Stubbed.
2081         (AccessibilityUIElement::hasPopup):
2082         Stubbed.
2083
2084         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2085         (AccessibilityUIElement::showMenu):
2086         Call the object's accDoDefaultAction() to show its popup menu.
2087         (AccessibilityUIElement::isEnabled):
2088         Check that the object does not have the "unavailable" state.
2089         (AccessibilityUIElement::isVisible):
2090         Check that the object does not have the "invisible" state.
2091         (AccessibilityUIElement::isOffScreen):
2092         Check whether the object has the "offscreen" state.
2093         (AccessibilityUIElement::isCollapsed):
2094         Check whether the object has the "collapsed" state.
2095         (AccessibilityUIElement::hasPopup):
2096         Check whether the object has the "has popup" state.
2097
2098 2010-01-19  Victor Wang  <victorw@chromium.org>
2099
2100         Reviewed by Eric Seidel.
2101
2102         Correct committer name.
2103         https://bugs.webkit.org/show_bug.cgi?id=33868
2104
2105         * Scripts/webkitpy/committers.py:
2106
2107 2010-01-19  Kent Tamura  <tkent@chromium.org>
2108
2109         Reviewed by Darin Adler.
2110
2111         [DRT][Mac] Add modifiers parameter to eventSender.mouseDown() and eventSender.mouseUp()
2112         https://bugs.webkit.org/show_bug.cgi?id=33783
2113
2114         Some listbox tests check selection behavior by click events with
2115         "meta" or "shift" keys. Behaviors for such modifier keys are
2116         platform-dependent. The new parameter of mouseDown() and mouseUp()
2117         allows to specify not only concrete modifier keys such as
2118         "shiftKey" "metaKey", but also functional names like
2119         "addSelectionKey" "rangeSelectionKey".
2120
2121         * DumpRenderTree/mac/EventSendingController.mm:
2122         (+[EventSendingController isSelectorExcludedFromWebScript:]):
2123         (+[EventSendingController webScriptNameForSelector:]):
2124         (buildModifierFlags):
2125         (-[EventSendingController mouseDown:withModifiers:]):
2126         (-[EventSendingController mouseDown:]):
2127         (-[EventSendingController mouseUp:withModifiers:]):
2128         (-[EventSendingController mouseUp:]):
2129         (-[EventSendingController keyDown:withModifiers:withLocation:]):
2130
2131 2010-01-19  Adam Barth  <abarth@webkit.org>
2132
2133         Reviewed by Eric Seidel.
2134
2135         Unbreak --request-commit
2136         https://bugs.webkit.org/show_bug.cgi?id=33832
2137
2138         * Scripts/webkitpy/bugzilla.py:
2139
2140 2010-01-19  Eric Seidel  <eric@webkit.org>
2141
2142         Reviewed by Adam Barth.
2143
2144         validate-committer-lists throws exception and committers.py needs a refresh
2145         https://bugs.webkit.org/show_bug.cgi?id=33831
2146
2147         * Scripts/validate-committer-lists: use webkit_logging
2148         * Scripts/webkitpy/committers.py: Add recently minted committers.  Fix Simon Hausmanns email address list to include his webkit-committers@lists address.
2149
2150 2010-01-18  Adam Roben  <aroben@apple.com>
2151
2152         Add LayoutTestController support for calling new WebKit SPI to
2153         disallow setting document.domain
2154
2155         DRT part of fixing <http://webkit.org/b/33806>
2156         <rdar://problem/7552837> Would like API to disallow setting of
2157         document.domain for pages with certain URL schemes
2158
2159         Reviewed by Sam Weinig.
2160
2161         * DumpRenderTree/LayoutTestController.cpp:
2162         (setDomainRelaxationForbiddenForURLSchemeCallback): Added. Calls
2163         through to LayoutTestController.
2164         (LayoutTestController::staticFunctions): Added
2165         setDomainRelaxationForbiddenForURLScheme.
2166
2167         * DumpRenderTree/LayoutTestController.h: Added
2168         setDomainRelaxationForbiddenForURLScheme.
2169
2170         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2171         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
2172         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2173         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
2174         Added. Calls through to WebKit.
2175
2176         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2177         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
2178         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2179         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
2180         Stubbed out.
2181
2182 2010-01-18  Adam Barth  <abarth@webkit.org>
2183
2184         Reviewed by Adam Roben.
2185
2186         Rename patches-to-commit to patches-in-commit-queue
2187         https://bugs.webkit.org/show_bug.cgi?id=33789
2188
2189         The command really lists the patches in the commit-queue not all the
2190         patches that are pending-commit (as the FIXME commands).
2191
2192         * Scripts/webkitpy/commands/queries.py:
2193         * Scripts/webkitpy/commands/queries_unittest.py:
2194
2195 2010-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2196
2197         Reviewed by Simon Hausmann.
2198
2199         [Qt] Force qmake to generate a single makefile for DerivedSources.pro
2200
2201         * Scripts/webkitdirs.pm:
2202
2203 2010-01-18  Adam Roben  <aroben@apple.com>
2204
2205         Clean up use of /useenv when invoking Visual C++
2206
2207         This change reverts things to their pre-r49485 state. That revision
2208         (and, subsequently, r49664 and r51788) started passing /useenv to
2209         Visual C++, even in cases where we don't want to do so (such as when
2210         invoking Visual C++ Express), in the name of making the Chromium build
2211         work. Now that Chromium isn't using buildVisualStudioProject or
2212         pdevenv, we can put things back they way they were.
2213
2214         Fixes <http://webkit.org/b/33797> build-webkit fails with VC++ Express
2215         (due to /useenv flag)
2216
2217         Reviewed by Sam Weinig.
2218
2219         * Scripts/pdevenv: Always pass /useenv. Chromium doesn't use this
2220         script anymore.
2221         * Scripts/webkitdirs.pm:
2222         (buildVisualStudioProject): Never pass /useenv anymore. pdevenv takes
2223         care of this itself, and we don't want to pass /useenv when not using
2224         pdevenv (e.g., when using VC++ Express, because that will cause it to
2225         ignore the Platform SDK).
2226
2227 2010-01-18  Adam Barth  <abarth@webkit.org>
2228
2229         Reviewed by Eric Seidel.
2230
2231         webkit-patch land-safely should obsolete old patches
2232         https://bugs.webkit.org/show_bug.cgi?id=33788
2233
2234         When posting a commit-queue+ patch with land-safely, we should
2235         obsolete the old patches on the bug.  They're really confusing
2236         because the main use case is to address reviewer feedback on a
2237         previous patch.
2238
2239         * Scripts/webkitpy/commands/upload.py:
2240         * Scripts/webkitpy/commands/upload_unittest.py:
2241
2242 2010-01-18  Adam Barth  <abarth@webkit.org>
2243
2244         Reviewed by David Levin.
2245
2246         webkit-patch should authenticate more often
2247         https://bugs.webkit.org/show_bug.cgi?id=33701
2248
2249         This makes it easier to work with security patches.
2250
2251         * Scripts/webkitpy/bugzilla.py:
2252
2253 2010-01-18  Adam Barth  <abarth@webkit.org>
2254
2255         Reviewed by Darin Adler.
2256
2257         style checker needs to know about GObject-specific requirements
2258         inside WebCore/bindings/gobject/
2259         https://bugs.webkit.org/show_bug.cgi?id=33606
2260
2261         Add an exception to the underscore rule for certain
2262         GObject-specific names.
2263
2264         * Scripts/webkitpy/style/cpp_style.py:
2265         * Scripts/webkitpy/style/cpp_style_unittest.py:
2266
2267 2010-01-18  Adam Barth  <abarth@webkit.org>
2268
2269         Reviewed by Shinichiro Hamaji.
2270
2271         [check-webkit-style] does understand ResourceHandleWin.h
2272         https://bugs.webkit.org/show_bug.cgi?id=32975
2273
2274         I'm not 100% convinced this fix is correct, but without more examples,
2275         it's hard to generalize.  We can always generalize the fix in the
2276         future.
2277
2278         * Scripts/webkitpy/style/cpp_style.py:
2279         * Scripts/webkitpy/style/cpp_style_unittest.py:
2280
2281 2010-01-18  Adam Barth  <abarth@webkit.org>
2282
2283         Unreviewed "build" fix.
2284
2285         * Scripts/webkitpy/bugzilla.py:
2286
2287 2010-01-18  Adam Barth  <abarth@webkit.org>
2288
2289         Unreviewed.  Actually make land-safely mark commit-queue+ as
2290         discussed with Eric.
2291
2292         * Scripts/webkitpy/bugzilla.py:
2293         * Scripts/webkitpy/steps/postdiffforcommit.py:
2294
2295 2010-01-17  Adam Barth  <abarth@webkit.org>
2296
2297         Reviewed by Darin Adler.
2298
2299         style-queue complains about one-line macros that include multiple statements
2300         https://bugs.webkit.org/show_bug.cgi?id=33173
2301
2302         Add an exception for multiple statements on a line that starts a macro.
2303
2304         * Scripts/webkitpy/style/cpp_style.py:
2305         * Scripts/webkitpy/style/cpp_style_unittest.py:
2306
2307 2010-01-17  Adam Barth  <abarth@webkit.org>
2308
2309         Reviewed by Darin Adler.
2310
2311         [check-webkit-style] qt unit testing false positives
2312         https://bugs.webkit.org/show_bug.cgi?id=32833
2313
2314         Exempt the Qt API and unit tests from the style checker.
2315
2316         * Scripts/webkitpy/style/cpp_style.py:
2317         * Scripts/webkitpy/style/cpp_style_unittest.py:
2318
2319 2010-01-17  Adam Barth  <abarth@webkit.org>
2320
2321         Reviewed by Darin Adler.
2322
2323         style-check script reports loads of errors on gtk2drawing.c
2324         https://bugs.webkit.org/show_bug.cgi?id=33771
2325
2326         Exempt WebCore/platform/gtk/gtk2drawing.c and
2327         WebCore/platform/gtk/gtk2drawing.h from style checks.
2328
2329         * Scripts/webkitpy/style/cpp_style.py:
2330         * Scripts/webkitpy/style/cpp_style_unittest.py:
2331
2332 2010-01-17  Chris Jerdonek  <cjerdonek@webkit.org>
2333
2334         Reviewed by Shinichiro Hamaji.
2335
2336         Finished eliminating _cpp_style_state global state variable from
2337         check-webkit-style code and eliminating _CppStyleState class.
2338
2339         https://bugs.webkit.org/show_bug.cgi?id=33764
2340
2341         * Scripts/webkitpy/style/checker.py:
2342           - Minor updates caused by changes to cpp_style.py.
2343
2344         * Scripts/webkitpy/style/cpp_style.py:
2345           - Removed _CppStyleState class.
2346           - Removed verbose_level functions.
2347           - Added verbosity as a parameter to _FunctionState constructor.
2348           - Added verbosity as a parameter to process_file().
2349           - Added verbosity as a parameter to process_file_data().
2350
2351         * Scripts/webkitpy/style/cpp_style_unittest.py:
2352           - Added helper functions to set verbosity while running tests.
2353
2354 2010-01-17  Adam Barth  <abarth@webkit.org>
2355
2356         Reviewed by Shinichiro Hamaji.
2357
2358         check-webkit-style underscore check should be disabled for Qt methods starting with qt_
2359         https://bugs.webkit.org/show_bug.cgi?id=33663
2360
2361         * Scripts/webkitpy/style/cpp_style.py:
2362         * Scripts/webkitpy/style/cpp_style_unittest.py:
2363
2364 2010-01-17  Adam Barth  <abarth@webkit.org>
2365
2366         Reviewed by Eric Seidel.
2367
2368         style-queue complains about missing #include of config.h for non-WebCore projects
2369         https://bugs.webkit.org/show_bug.cgi?id=33170
2370
2371         WebKitAPITests are consumers of the WebKit API and therefore do not
2372         need to follow the same include discipline as the rest of WebKit.  This
2373         patch exempts them from the include checks.
2374
2375         * Scripts/webkitpy/style/cpp_style.py:
2376         * Scripts/webkitpy/style/cpp_style_unittest.py:
2377
2378 2010-01-17  Adam Barth  <abarth@webkit.org>
2379
2380         Reviewed by Eric Seidel.
2381
2382         EWS (Early Warning Systems) should build both debug and release
2383         https://bugs.webkit.org/show_bug.cgi?id=33681
2384
2385         Build both debug and release for chromium-ews.
2386
2387         * Scripts/webkitpy/commands/early_warning_system.py:
2388
2389 2010-01-17  Adam Barth  <abarth@webkit.org>
2390
2391         Reviewed by Darin Adler.
2392
2393         style-queue should include instructions for how to file bugs against check-webkit-style
2394         https://bugs.webkit.org/show_bug.cgi?id=32345
2395
2396         Added some text to the error message asking folks to file bugs against
2397         false positives.
2398
2399         * Scripts/webkitpy/commands/queues.py:
2400
2401 2010-01-17  Chris Jerdonek  <cjerdonek@webkit.org>
2402
2403         Reviewed by Adam Barth.
2404
2405         Eliminated the error_count global variable and related
2406         check-webkit-style refactoring.
2407
2408         https://bugs.webkit.org/show_bug.cgi?id=33678
2409
2410         * Scripts/check-webkit-style:
2411           - Updated to use webkit_argument_defaults().
2412           - Renamed styleChecker to style_checker.
2413
2414         * Scripts/webkitpy/style/checker.py:
2415           - Prefixed the three default arguments with WEBKIT_DEFAULT.
2416           - Added webkit_argument_defaults().
2417           - Added default filter_rules parameter to CategoryFilter constructor.
2418           - Added __ne__() to CategoryFilter class.
2419           - Added __eq__() and __ne__() to ProcessorOptions class.
2420           - Added error_count and _write_error attributes to StyleChecker class.
2421           - Made StyleChecker._handle_error() increment the error count.
2422
2423         * Scripts/webkitpy/style/checker_unittest.py:
2424           - Improved CategoryFilterTest.test_eq().
2425           - Added CategoryFilterTest.test_ne().
2426           - Added test_eq() and test_ne() to ProcessorOptionsTest class.
2427           - Updated unit tests to use webkit_argument_defaults().
2428           - Added StyleCheckerTest class.
2429
2430         * Scripts/webkitpy/style/cpp_style.py:
2431           - Removed references to global error_count.
2432
2433         * Scripts/webkitpy/style/cpp_style_unittest.py:
2434           - Removed CppStyleStateTest class.
2435
2436 2010-01-15  Jon Honeycutt  <jhoneycutt@apple.com>
2437
2438         get_accParent should try to retrieve parent AccessibilityObject, before
2439         calling upon window
2440
2441         https://bugs.webkit.org/show_bug.cgi?id=22893
2442
2443         Reviewed by Darin Adler.
2444
2445         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2446         (AccessibilityUIElement::parentElement):
2447         Get the object's parent. Query it for IAccessible, and return it.
2448
2449 2010-01-16  Dan Bernstein  <mitz@apple.com>
2450
2451         Reviewed by Mark Rowe.
2452
2453         <rdar://problem/7529519> DumpRenderTree crashes in makeLargeMallocFailSilently()
2454
2455         * DumpRenderTree/mac/CheckedMalloc.cpp:
2456         (makeLargeMallocFailSilently): Temporarily allow writing to the default
2457         malloc zone structure while modifying it.
2458
2459 2010-01-16  David Kilzer  <ddkilzer@apple.com>
2460
2461         Added back removed properties to iExploder input files
2462
2463         While the update-iexploder-cssproperties script works great to
2464         add new properties, it has the side-effect of removing old
2465         properties that once were parsed.
2466
2467         * iExploder/htdocs/cssproperties.in: Added back removed
2468         properties into their own section.
2469         * iExploder/htdocs/htmlattrs.in: Ditto.
2470
2471 2010-01-16  Holger Hans Peter Freyther  <zecke@selfish.org>
2472
2473         Reviewed by David Kilzer.
2474
2475         Update iExploder/htdocs/*.in by running update-iexploder-cssproperties 
2476         https://bugs.webkit.org/show_bug.cgi?id=33756
2477
2478         * iExploder/htdocs/cssproperties.in: New CSS attributes
2479         * iExploder/htdocs/htmlattrs.in: New HTML attributes
2480         * iExploder/htdocs/htmltags.in: New HTML tags
2481
2482 2010-01-15  Chris Jerdonek  <chris.jerdonek@gmail.com>
2483
2484         Reviewed by David Kilzer.
2485
2486         Altered parseDiffHeader() to skip unrecognized lines and
2487         other minor clean-ups.
2488
2489         https://bugs.webkit.org/show_bug.cgi?id=33476
2490
2491         * Scripts/VCSUtils.pm:
2492           - Changed parseDiffHeader() as follows:
2493             - Skips over unrecognized lines.
2494             - Addressed FIXME to remove substitution for "diff" line.
2495             - Renamed "version" header hash key to "sourceRevision".
2496             - Eliminated "copiedFromVersion" header hash key.
2497             - Included "sourceRevision" also for copied files.
2498             - Checks that copy revision number matches "sourceRevision".
2499             - No longer returns $foundHeaderEnding.
2500             - Dies if header ending not found.
2501             - Diff header dividing line now always added.
2502
2503         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
2504           - Made necessary changes in parseDiffHeader() unit tests.
2505           - Shortened the file paths in some test cases.
2506
2507 2010-01-14  Yuzo Fujishima  <yuzo@google.com>
2508
2509         Reviewed by Alexey Proskuryakov.
2510
2511         Update pywebsocket to 0.4.6
2512         https://bugs.webkit.org/show_bug.cgi?id=32299
2513         The newer pywebsocket can handle more simultaneous connections.
2514
2515         * pywebsocket/mod_pywebsocket/handshake.py:
2516         * pywebsocket/mod_pywebsocket/standalone.py:
2517         * pywebsocket/setup.py:
2518         * pywebsocket/test/test_handshake.py:
2519
2520 2010-01-14  Eric Seidel  <eric@webkit.org>
2521
2522         Reviewed by Adam Barth.
2523
2524         REGRESSION(53133): commit-queue no longer rejects patches with invalid committers, instead it hangs
2525         https://bugs.webkit.org/show_bug.cgi?id=33638
2526
2527         * Scripts/webkitpy/bugzilla.py:
2528          - Add Bug.id() to match Attachment.id()
2529          - Give Bug.reviewed_patches and commit_queued_patches the option to return patches with invalid committers/reviewers.
2530          - Add back a missing variable to _validate_setter_email found by the new unit tests!
2531         * Scripts/webkitpy/commands/queries.py:
2532          - Add FIXMEs about the commands being confusingly named.
2533         * Scripts/webkitpy/commands/queries_unittest.py:
2534          - Update results to reflect the newly restructured mock bug cache.
2535         * Scripts/webkitpy/commands/queues.py:
2536          - Add a new _validate_patches_in_commit_queue method (this is what fixes the regression).
2537          - Add a FIXME about eventually sorting the patches into some order.
2538         * Scripts/webkitpy/commands/queues_unittest.py:
2539          - Update results now that with the newly restructure mock bug cache we're testing cq+'d patches with an invalid committer.
2540         * Scripts/webkitpy/commands/upload_unittest.py:
2541          - Update results to match the newly restructured mock bug cache.
2542         * Scripts/webkitpy/mock_bugzillatool.py:
2543          - Restructure fetch_ methods to not use a manual list of ids, but rather use Bug and Attachment classes to make real queries from all of the Bugs.
2544          - Add a few more attachments and bug dictionaries for use by the tests.
2545
2546 2010-01-13  Diego Gonzalez  <diego.gonzalez@openbossa.org>
2547
2548         Reviewed by Kenneth Christiansen.
2549
2550         [Qt] DRT missing setUserStyleSheetLocation and setUserStyleSheetEnabled in LayoutTestController
2551         https://bugs.webkit.org/show_bug.cgi?id=33617
2552
2553         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2554         (WebCore::WebPage::resetSettings):
2555         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2556         (LayoutTestController::setUserStyleSheetLocation):
2557         (LayoutTestController::setUserStyleSheetEnabled):
2558         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2559
2560 2010-01-14  Adam Roben  <aroben@apple.com>
2561
2562         Add LayoutTestController API to force
2563         -webView:resource:willSendRequest:: to return null
2564
2565         Enables tests for <rdar://problem/7533333> <http://webkit.org/b/33533>
2566         window.onload never fires if page contains an <iframe> with a bad
2567         scheme or whose load is cancelled by returning null from resource load
2568         delegate's willSendRequest
2569
2570         Reviewed by Brady Eidson.
2571
2572         * DumpRenderTree/LayoutTestController.cpp:
2573         (LayoutTestController::LayoutTestController): Initialize new member.
2574         (setWillSendRequestReturnsNullCallback): Call through to
2575         LayoutTestController.
2576         (LayoutTestController::staticFunctions): Added new function.
2577
2578         * DumpRenderTree/LayoutTestController.h: Added
2579         m_willSendRequestReturnsNull.
2580         (LayoutTestController::willSendRequestReturnsNull):
2581         (LayoutTestController::setWillSendRequestReturnsNull):
2582         Added standard accessors.
2583
2584         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2585         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2586         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2587         (ResourceLoadDelegate::willSendRequest):
2588         Return null if LayoutTestController says to.
2589
2590 2010-01-14  Kevin Ollivier  <kevino@theolliviers.com>
2591
2592         [wx] Build fix after removal of XBM support.
2593
2594         * wx/build/settings.py:
2595
2596 2010-01-14  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2597
2598         Reviewed by Simon Hausmann.
2599
2600         Add support for partial building on Symbian.
2601
2602         The build happens in the source directory as out of source builds are
2603         not supported by qmake for Symbian.
2604
2605         Also the actual build isn't started but it is left to the developer
2606         to choose the architecture/configuration.
2607
2608         * Scripts/webkitdirs.pm:
2609
2610 2010-01-14  Simon Hausmann  <simon.hausmann@nokia.com>
2611
2612         Reviewed by Kenneth Rohde Christiansen.
2613
2614         Add support for "detecting" Symbian environments by either
2615         looking for the EPOCROOT environment variable or via --symbian
2616         being passed on the commandline.
2617
2618         * Scripts/webkitdirs.pm:
2619
2620 2010-01-14  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2621
2622         Unreviewed.
2623
2624         [Qt] Use a different Makefile names for sources generation and compilation.
2625         This prevents Makefile overwriting when running build-webkit twice.
2626
2627         * Scripts/webkitdirs.pm:
2628
2629 2010-01-14  Andreas Kling  <andreas.kling@nokia.com>
2630
2631         Reviewed by Kenneth Rohde Christiansen.
2632
2633         [Qt] Add an "alien_QLabel" classId for manual testing of alien widgets.
2634
2635         https://bugs.webkit.org/show_bug.cgi?id=33373
2636
2637         * QtLauncher/main.cpp:
2638         (WebPage::createPlugin):
2639
2640 2010-01-14  Eric Seidel  <eric@webkit.org>
2641
2642         No review, rolling out r53249.
2643         http://trac.webkit.org/changeset/53249
2644         https://bugs.webkit.org/show_bug.cgi?id=33617
2645
2646         This caused http/tests/security/local-user-CSS-from-
2647         remote.html to fail on the Qt Release Build Bot.
2648
2649         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2650         (WebCore::WebPage::resetSettings):
2651         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2652         (LayoutTestController::overridePreference):
2653         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2654
2655 2010-01-14  Chris Jerdonek  <chris.jerdonek@gmail.com>
2656
2657         Reviewed by Shinichiro Hamaji.
2658
2659         Moved error() from cpp_style.py to checker.py.
2660
2661         https://bugs.webkit.org/show_bug.cgi?id=33620
2662
2663         * Scripts/check-webkit-style:
2664           - Addressed FIXME to not set global state.
2665
2666         * Scripts/webkitpy/style/checker.py:
2667           - Added argument validation to ProcessorOptions constructor.
2668           - Added should_report_error() to ProcessorOptions class.
2669           - Removed set_options().
2670           - Added StyleChecker class.
2671
2672         * Scripts/webkitpy/style/checker_unittest.py:
2673           - Added unit test class for ProcessorOptions class.
2674           - Added unit test to check that parse() strips white space.
2675
2676         * Scripts/webkitpy/style/cpp_style.py:
2677           - Removed "filter" and "output_format" methods.
2678           - Removed should_print_error() and error() functions.
2679           - Removed default parameter value from process_file().
2680
2681         * Scripts/webkitpy/style/cpp_style_unittest.py:
2682           - Removed call to cpp_style._should_print_error().
2683           - Removed test_filter() and test_filter_appending().
2684
2685         * Scripts/webkitpy/style/text_style.py:
2686           - Removed default parameter value from process_file().
2687
2688 2010-01-14  Diego Gonzalez  <diego.gonzalez@openbossa.org>
2689
2690         Reviewed by Kenneth Rohde Christiansen.
2691
2692         [Qt] DRT missing setUserStyleSheetLocation and setUserStyleSheetEnabled in LayoutTestController
2693         https://bugs.webkit.org/show_bug.cgi?id=33617
2694
2695         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2696         (WebCore::WebPage::resetSettings):
2697         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2698         (LayoutTestController::setUserStyleSheetLocation):
2699         (LayoutTestController::setUserStyleSheetEnabled):
2700         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2701
2702 2010-01-13  Adam Barth  <abarth@webkit.org>
2703
2704         Reviewed by Eric Seidel.
2705
2706         Fix CloseBugForLandDiff unittest to actually run
2707         https://bugs.webkit.org/show_bug.cgi?id=33640
2708
2709         * Scripts/webkitpy/mock_bugzillatool.py:
2710         * Scripts/webkitpy/steps/closebugforlanddiff_unittest.py:
2711
2712 2010-01-12  Jon Honeycutt  <jhoneycutt@apple.com>
2713
2714         MSAA: selected, selectable, extended selectable, and multiple
2715         selectable states are not reported
2716
2717         https://bugs.webkit.org/show_bug.cgi?id=33574
2718         <rdar://problem/7536826>
2719
2720         Reviewed by Darin Adler.
2721
2722         * DumpRenderTree/AccessibilityUIElement.cpp:
2723         (getIsSelectableCallback):
2724         Return the result of calling isSelectable().
2725         (getIsMultiSelectableCallback):
2726         Return the result of calling isMultiSelectable().
2727         (AccessibilityUIElement::getJSClass):
2728         Add isSelected and isMultiSelectable properties to the JSClass
2729         definition.
2730
2731         * DumpRenderTree/AccessibilityUIElement.h:
2732         Declare isSelectable() and isMultiSelectable().
2733
2734         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2735         (AccessibilityUIElement::isSelectable):
2736         Stubbed.
2737         (AccessibilityUIElement::isMultiSelectable):
2738         Stubbed.
2739
2740         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2741         (AccessibilityUIElement::isSelectable):
2742         Stubbed.
2743         (AccessibilityUIElement::isMultiSelectable):
2744         Stubbed.
2745
2746         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2747         (accessibilityState):
2748         Get the object's state, and return it.
2749         (AccessibilityUIElement::isSelected):
2750         Check the object's selected state.
2751         (AccessibilityUIElement::isSelectable):
2752         Check the object's selectable state.
2753         (AccessibilityUIElement::isMultiSelectable):
2754         Check the object's extended/multiple selectable state.
2755
2756 2010-01-13  Adam Barth  <abarth@webkit.org>
2757
2758         Unreviewed.  Repeat the below for CloseBugForLandDiff.
2759
2760         * Scripts/test-webkitpy:
2761         * Scripts/webkitpy/steps/closebugforlanddiff.py:
2762         * Scripts/webkitpy/steps/closebugforlanddiff_unittest.py: Added.
2763
2764 2010-01-13  Adam Barth  <abarth@webkit.org>
2765
2766         Unreviewed.  Turn the mac-ews status bubbles back on now that this bot
2767         is running again.
2768
2769         * QueueStatusServer/templates/statusbubble.html:
2770
2771 2010-01-13  Adam Barth  <abarth@webkit.org>
2772
2773         Reviewed by Darin Adler.
2774
2775         REGRESSION(53133): webkit-patch land dies if it can't find a bug id.
2776         https://bugs.webkit.org/show_bug.cgi?id=33634
2777
2778         Deal with the case of no bug patch object in the state.
2779
2780         * Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py:
2781         * Scripts/webkitpy/steps/updatechangelogswithreviewer.py:
2782
2783 2010-01-13  Kenneth Russell  <kbr@google.com>
2784
2785         Unreviewed; added myself to the committers list.
2786
2787         * Scripts/webkitpy/committers.py:
2788
2789 2010-01-13  Darin Adler  <darin@apple.com>
2790
2791         Ignore compiled Python in more of webkitpy.
2792
2793         * Scripts/webkitpy/commands: Added property svn:ignore.
2794         * Scripts/webkitpy/steps: Added property svn:ignore.
2795         * Scripts/webkitpy/style: Added property svn:ignore.
2796
2797 2010-01-13  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2798
2799         Reviewed by Simon Hausmann.
2800
2801         [Qt] Fix build problem related to the pushd command
2802
2803         * Scripts/webkitdirs.pm:
2804
2805 2010-01-13  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2806
2807         Reviewed by Simon Hausmann.
2808
2809         [Qt] Split the build process in two different .pro files.
2810         This allows qmake to be run once all source files are available.
2811
2812         * Scripts/webkitdirs.pm: Add calls to make DerivedSources.pro in JSC and WC.
2813
2814 2010-01-13  Shinichiro Hamaji  <hamaji@chromium.org>
2815
2816         Unreviewed tiny typo fix in docstrings.
2817
2818         * Scripts/webkitpy/style/checker_unittest.py:
2819
2820 2010-01-13  Chris Jerdonek  <chris.jerdonek@gmail.com>
2821
2822         Reviewed by Shinichiro Hamaji.
2823
2824         Created a CategoryFilter class to encapsulate the logic of
2825         filter rules.
2826
2827         https://bugs.webkit.org/show_bug.cgi?id=33454
2828
2829         * Scripts/webkitpy/style/checker.py:
2830           - Added CategoryFilter class.
2831
2832         * Scripts/webkitpy/style/checker_unittest.py:
2833           - Added CategoryFilter unit tests.
2834
2835         * Scripts/webkitpy/style/cpp_style.py:
2836           - Updated filter methods to use CategoryFilter.
2837
2838         * Scripts/webkitpy/style/cpp_style_unittest.py:
2839           - Updated references to filters.
2840
2841 2010-01-12  Shinichiro Hamaji  <hamaji@chromium.org>
2842
2843         Unreviewed. Now I can review :)
2844
2845         * Scripts/webkitpy/committers.py:
2846
2847 2010-01-12  Brent Fulgham  <bfulgham@webkit.org>
2848
2849         Reviewed by Darin Adler.
2850
2851         Extend WinLauncher example with better printing features.
2852
2853         * WinLauncher/PrintWebUIDelegate.cpp:
2854         (PrintWebUIDelegate::webViewPrintingMarginRect): Provide slightly
2855          larger margins.
2856         (PrintWebUIDelegate::webViewHeaderHeight): Compute header height based
2857          on text metrics.
2858         (PrintWebUIDelegate::webViewFooterHeight): Compute footer height based
2859          on text metrics.
2860         (PrintWebUIDelegate::drawHeaderInRect): Write useful header, along
2861          with separating line.
2862         (PrintWebUIDelegate::drawFooterInRect):
2863         * WinLauncher/PrintWebUIDelegate.h: Remove stubs.
2864         * WinLauncher/WinLauncher.cpp:
2865         (PrintView): Correct loop used to print individual pages.
2866          Previously it started at 0, which is a wild-card to print all
2867          pages at once.
2868
2869 2010-01-12  Alexey Proskuryakov  <ap@apple.com>
2870
2871         Reviewed by Darin Adler.
2872
2873         https://bugs.webkit.org/show_bug.cgi?id=33540
2874         Make it possible to build in debug mode with assertions disabled
2875
2876         * DumpRenderTree/mac/ObjCController.m: (-[ObjCController accessStoredWebScriptObject]):
2877
2878 2010-01-11  Darin Fisher  <darin@chromium.org>
2879
2880         Reviewed by Dimitri Glazkov.
2881
2882         [Chromium] "build-webkit --chromium" should run "make all" on Linux
2883         https://bugs.webkit.org/show_bug.cgi?id=33500
2884
2885         * Scripts/webkitdirs.pm:
2886
2887 2010-01-12  Eric Seidel  <eric@webkit.org>
2888
2889         Reviewed by Adam Barth.
2890
2891         AssignToCommitter does not need to fetch bugs twice
2892         https://bugs.webkit.org/show_bug.cgi?id=33530
2893
2894         This is a no-brainer patch now that we've added Bug.reviewed_patches
2895
2896         * Scripts/webkitpy/commands/upload.py:
2897
2898 2010-01-12  Eric Seidel  <eric@webkit.org>
2899
2900         Reviewed by Adam Barth.
2901
2902         bugzilla.py should have an Attachment object instead of passing around dictionaries
2903         https://bugs.webkit.org/show_bug.cgi?id=31594
2904
2905         * Scripts/webkitpy/bugzilla.py:
2906          - Add a new Attachment class, with accessor methods for all the necessary properties.
2907          - Update Bug to carry a pointer back to bugzilla (attachments need to access Bugzilla for committer validation and url())
2908          - Move reviewed_patches and commit_queued_patches out of Bugzilla custom methods and onto Bug
2909          - Move committer validation logic into its own class.
2910          - Committer rejection is only used in one place.  Make the new Bug reviewed_patches and commit_queued_patches
2911            handle the common case (of returning "reviewer" or "committer" as None), and let CommitterValidation handle
2912            the case where we want to reject patches in bugzilla.
2913          - Simplify fetch_patches_from_commit_queue now that committer validation is simpler.
2914          - Make all self.bugzilla.fetch_bug access go through BugzillaQueries._fetch_bug.
2915          - Mark set_flag_on_attachment as non-private to denote that CommitterValidation depends on it.
2916          - Move fetch_reviewed_patches_from_bug and fetch_commit_queue_patches_from_bug logic onto the Bug class.
2917         * Scripts/webkitpy/bugzilla_unittest.py:
2918          - Move test_flag_permission_rejection_message into a new CommitterValidationTest class.
2919         * Scripts/webkitpy/commands/download.py:
2920          - Store "bug_id" in state instead of making a fake patch object.
2921          - Update to use Attachment and Bug objects.
2922         * Scripts/webkitpy/commands/download_unittest.py:
2923          - Update expected results now that our testing framework covers more code.
2924         * Scripts/webkitpy/commands/early_warning_system.py: Update to use new Attachment class.
2925         * Scripts/webkitpy/commands/queries.py: Remove unused ReviewedPatches class.
2926         * Scripts/webkitpy/commands/queries_unittest.py: ditto.
2927         * Scripts/webkitpy/commands/queues.py: Update to use new Attachment and CommitterValidator classes.
2928         * Scripts/webkitpy/commands/queuestest.py: ditto.
2929         * Scripts/webkitpy/commands/upload.py: ditto.
2930         * Scripts/webkitpy/mock_bugzillatool.py:
2931          - Now that more logic has moved into Attachment and Bug, we have to actually
2932            provide real reviewer emails as well as real reviewer flags.
2933          - Update mock methods to return Attachment objects.
2934         * Scripts/webkitpy/scm.py: Update to use Attachment class.
2935         * Scripts/webkitpy/scm_unittest.py: Update to use Attachment class.
2936         * Scripts/webkitpy/statusserver.py: ditto.
2937         * Scripts/webkitpy/steps/applypatch.py: ditto.
2938         * Scripts/webkitpy/steps/applypatchwithlocalcommit.py: ditto.
2939         * Scripts/webkitpy/steps/closebug.py: ditto.
2940         * Scripts/webkitpy/steps/closebugforlanddiff.py: Handle either state["bug_id"] or state["patch"].bug_id()
2941         * Scripts/webkitpy/steps/closepatch.py: Update to use Attachment class.
2942         * Scripts/webkitpy/steps/obsoletepatches.py: ditto.
2943         * Scripts/webkitpy/steps/updatechangelogswithreviewer.py: ditto.
2944
2945 2010-01-12  Adam Barth  <abarth@webkit.org>
2946
2947         Unreviewed typo fix.  :(
2948
2949         * Scripts/webkitpy/commands/early_warning_system.py:
2950         * Scripts/webkitpy/commands/queues.py:
2951
2952 2010-01-12  Adam Barth  <abarth@webkit.org>
2953
2954         Unreviewed.  Add "error" to the right part of the message.
2955
2956         * Scripts/webkitpy/commands/queues.py:
2957
2958 2010-01-12  Adam Barth  <abarth@webkit.org>
2959
2960         Reviewed by Eric Seidel.
2961
2962         EWS should show purple when svn-apply fails
2963         https://bugs.webkit.org/show_bug.cgi?id=33527
2964
2965         * Scripts/webkitpy/commands/early_warning_system.py:
2966         * Scripts/webkitpy/commands/queues.py:
2967
2968 2010-01-12  Adam Barth  <abarth@webkit.org>
2969
2970         Reviewed by Eric Seidel.
2971
2972         Remove copy/paste code from subclasses of AbstractReviewQueue
2973         https://bugs.webkit.org/show_bug.cgi?id=33525
2974
2975         * Scripts/webkitpy/commands/early_warning_system.py:
2976         * Scripts/webkitpy/commands/queues.py:
2977
2978 2010-01-12  Adam Barth  <abarth@webkit.org>
2979
2980         Reviewed by Eric Seidel.
2981
2982         Add Gustavo and Xan as gtk-ews watchers
2983         https://bugs.webkit.org/show_bug.cgi?id=33519
2984
2985         * Scripts/webkitpy/commands/early_warning_system.py:
2986
2987 2010-01-12  Adam Barth  <abarth@webkit.org>
2988
2989         Reviewed by Eric Seidel.
2990
2991         webkit-patch shouldn't waste my time for with a component prompt
2992         https://bugs.webkit.org/show_bug.cgi?id=33521
2993
2994         The component field isn't very useful for bugs created with
2995         webkit-patch because they're likely to be resolved quickly.  Instead of
2996         always prompting for a component, we should just default to the "New
2997         Bugs" component.  If the bug stays around for more than five minutes,
2998         we can assign it a proper component.
2999
3000         * Scripts/webkitpy/bugzilla.py:
3001
3002 2010-01-12  Adam Barth  <abarth@webkit.org>
3003
3004         Reviewed by Eric Seidel.
3005
3006         Add experimental "land-safely" command to webkit-patch
3007         https://bugs.webkit.org/show_bug.cgi?id=33518
3008
3009         * Scripts/webkitpy/commands/upload.py:
3010         * Scripts/webkitpy/commands/upload_unittest.py:
3011         * Scripts/webkitpy/steps/__init__.py:
3012         * Scripts/webkitpy/steps/postdiffforcommit.py: Added.
3013
3014 2010-01-11  Kevin Ollivier  <kevino@theolliviers.com>
3015
3016         [wx] Build fix after introduction of JS_NO_EXPORT
3017         
3018         * wx/build/settings.py:
3019
3020 2010-01-11  Eric Seidel  <eric@webkit.org>
3021
3022         No review, rolling out r53079.
3023         http://trac.webkit.org/changeset/53079
3024         https://bugs.webkit.org/show_bug.cgi?id=33197
3025
3026         Adam doens't think this actually works, and believe it caused
3027         a regression https://bugs.webkit.org/show_bug.cgi?id=33488 so
3028         rolling this out.
3029
3030         * Scripts/test-webkitpy:
3031         * Scripts/webkitpy/commands/abstractdiffcommand.py: Removed.
3032         * Scripts/webkitpy/commands/abstractdiffcommand_unittest.py: Removed.
3033         * Scripts/webkitpy/commands/download.py:
3034         * Scripts/webkitpy/commands/upload.py:
3035         * Scripts/webkitpy/mock_bugzillatool.py:
3036
3037 2010-01-10  Adam Barth  <abarth@webkit.org>
3038
3039         Reviewed by David Kilzer.
3040
3041         bugzilla-tool submit-patch mistakenly picks up bug URLs in non-ChangeLog files
3042         https://bugs.webkit.org/show_bug.cgi?id=33197
3043
3044         We should just search for bug numbers in the ChangeLogs instead of in
3045         the whole diff.
3046  
3047         * Scripts/test-webkitpy:
3048         * Scripts/webkitpy/commands/abstractdiffcommand.py: Added.
3049         * Scripts/webkitpy/commands/abstractdiffcommand_unittest.py: Added.
3050         * Scripts/webkitpy/commands/download.py:
3051         * Scripts/webkitpy/commands/upload.py:
3052         * Scripts/webkitpy/mock_bugzillatool.py:
3053
3054 2010-01-11  Chris Jerdonek  <chris.jerdonek@gmail.com>
3055
3056         Reviewed by David Kilzer.
3057
3058         Created a unit-tested function to parse the header block of
3059         a Git or SVN diff -- for future refactoring of svn-apply and
3060         svn-unapply.
3061
3062         https://bugs.webkit.org/show_bug.cgi?id=33447
3063
3064         * Scripts/VCSUtils.pm:
3065           - Added parseDiffHeader().
3066           - Removed irrelevant comment from gitdiff2svndiff().
3067
3068         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl: Added.
3069           - Added 48 unit tests for parseDiffHeader().
3070
3071 2010-01-10  Adam Barth  <abarth@webkit.org>
3072
3073         Rubber stamped by David Kilzer.
3074
3075         bugzilla-tool submit-patch mistakenly picks up bug URLs in non-ChangeLog files
3076         https://bugs.webkit.org/show_bug.cgi?id=33197
3077
3078         Fix a typo: Commmand -> Command.
3079
3080         * Scripts/webkitpy/commands/abstractsequencedcommand.py:
3081         * Scripts/webkitpy/commands/download.py:
3082         * Scripts/webkitpy/commands/queries.py:
3083         * Scripts/webkitpy/commands/upload.py:
3084         * Scripts/webkitpy/multicommandtool.py:
3085
3086 2010-01-10  Adam Barth  <abarth@webkit.org>
3087
3088         Reviewed by Darin Adler.
3089
3090         Let webkit-patch work with options in $EDITOR
3091         https://bugs.webkit.org/show_bug.cgi?id=33414
3092
3093         The $EDITOR evironment variable might have command line options like
3094         bbedit -w.  This patch lets us run those $EDITORs.
3095
3096         * Scripts/webkitpy/user.py:
3097
3098 2010-01-10  Robert Hogan  <robert@roberthogan.net>
3099
3100         Reviewed by Adam Barth.
3101
3102         [Qt] Add enableXSSAuditor support to QWebSettings and DRT.
3103
3104         https://bugs.webkit.org/show_bug.cgi?id=33419
3105
3106         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3107         (WebCore::WebPage::WebPage):
3108         (WebCore::WebPage::resetSettings):
3109         (WebCore::DumpRenderTree::createWindow):
3110         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3111         (LayoutTestController::setXSSAuditorEnabled):
3112         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3113
3114 2010-01-10  Adam Barth  <abarth@webkit.org>
3115
3116         Unreviewed cosmetic change.  Remove the status bubble for mac-ews
3117         because we don't have hardware for it at the moment.
3118
3119         * QueueStatusServer/templates/statusbubble.html:
3120
3121 2010-01-09  Daniel Bates  <dbates@webkit.org>
3122
3123         No review, rolling out r53044.
3124         http://trac.webkit.org/changeset/53044
3125         https://bugs.webkit.org/show_bug.cgi?id=33419
3126         
3127         We need to look into this some more because the Qt
3128         bot is failing the XSSAuditor tests. See bug #33419
3129         for more details.
3130
3131         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3132         (WebCore::WebPage::WebPage):
3133         (WebCore::WebPage::resetSettings):
3134         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3135         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3136
3137 2010-01-09  Daniel Bates  <dbates@webkit.org>
3138
3139         Reviewed by Adam Barth.
3140
3141         https://bugs.webkit.org/show_bug.cgi?id=33419
3142
3143         Adds support for the XSSAuditor to the Qt DRT.
3144
3145         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3146         (WebCore::WebPage::WebPage):
3147         (WebCore::WebPage::resetSettings):
3148         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3149         (LayoutTestController::setXSSAuditorEnabled):
3150         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3151
3152 2010-01-09  Adam Barth  <abarth@webkit.org>
3153
3154         Reviewed by Eric Seidel.
3155
3156         Retry writes to QueueStatusServer when we get 500 errors
3157         https://bugs.webkit.org/show_bug.cgi?id=33412
3158
3159         This prevents the queues from failing to mark a patch as "pass" or
3160         "fail" when AppEngine throws 500 errors.
3161
3162         * Scripts/test-webkitpy:
3163         * Scripts/webkitpy/networktransaction.py: Added.
3164         * Scripts/webkitpy/networktransaction_unittest.py: Added.
3165         * Scripts/webkitpy/statusserver.py:
3166         * Scripts/webkitpy/steps/closebugformarkbugfixed.py: Added.
3167         * Scripts/webkitpy/steps/closebugregardlessofpatches.py: Added.
3168         * Scripts/webkitpy/steps/findbugidfromsvnrevision.py: Added.
3169
3170 2010-01-09  David Kilzer  <ddkilzer@apple.com>
3171
3172         <http://webkit.org/b/33430> Fix rounded borders in queue status on older Firefox and Safari browsers
3173
3174         Reviewed by Eric Seidel.
3175
3176         * QueueStatusServer/templates/statusbubble.html: Added
3177         -moz-border-radius and -webkit-border-radius to provide rounded
3178         borders in older Firefox and Safari browsers.
3179
3180 2010-01-09  Chris Jerdonek  <chris.jerdonek@gmail.com>
3181
3182         Reviewed by David Kilzer.
3183
3184         Modified VCSUtils::gitdiff2svndiff() to accept strings that
3185         end in vertical white space.
3186
3187         https://bugs.webkit.org/show_bug.cgi?id=33415
3188
3189         * Scripts/VCSUtils.pm:
3190         * Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl:
3191
3192 2010-01-08  Eric Seidel  <eric@webkit.org>
3193
3194         Reviewed by Adam Barth.
3195
3196         run-javascriptcore-tests needs a --quiet flag
3197         https://bugs.webkit.org/show_bug.cgi?id=33399
3198
3199         Until run-javascriptcore-tests has a --quiet flag, lets just stiffle the output in webkit-patch.
3200
3201         * Scripts/webkitpy/steps/runtests.py:
3202
3203 2010-01-08  Andras Becsi  <abecsi@inf.u-szeged.hu>
3204
3205         Reviewed by Alexey Proskuryakov.
3206
3207         Only run http and websocket tests as last if no argument is given to be able to explicitly control the test order.
3208
3209         To be able to run multiple instances of run-webkit-tests besides each other on the same machine we need to minimize
3210         the time when Apache and WebSocketServer is locked by tests.
3211         Because closeHTTPD() and closeWebSocketServer() is only called at the end of the testing,
3212         we need to run http and websocket tests after all other tests.
3213         If one however explicitly specifies the tests to run in the argument list of run-webkit-tests
3214         we need to preserve the given order.
3215
3216         * Scripts/run-webkit-tests:
3217
3218 2010-01-08  Adam Barth  <abarth@webkit.org>
3219
3220         Reviewed by Eric Seidel.
3221
3222         Don't post style-queue pass messages to bugs
3223         https://bugs.webkit.org/show_bug.cgi?id=33404
3224
3225         These messages aren't needed any more now that we have the status
3226         bubble reporting pass events passively.
3227
3228         * Scripts/webkitpy/commands/queues.py:
3229
3230 2010-01-08  Adam Barth  <abarth@webkit.org>
3231
3232         Reviewed by Eric Seidel.
3233
3234         Optimize the number of CPUs used for building Qt and Gtk
3235         https://bugs.webkit.org/show_bug.cgi?id=33394
3236
3237         Instead of hardcoding the number 8, we should read the number of CPUs
3238         from the environment.
3239
3240         * Scripts/webkitpy/executive.py:
3241         * Scripts/webkitpy/webkitport.py:
3242         * Scripts/webkitpy/webkitport_unittest.py:
3243
3244 2010-01-08  Chris Fleizach  <cfleizach@apple.com>
3245
3246         Reviewed by Eric Seidel.
3247
3248         REGRESSION(52819?): AXLoadComplete and AXLayoutComplete causes 4 tests fail on Snow Leopard Debug bot
3249         https://bugs.webkit.org/show_bug.cgi?id=33300
3250
3251         * DumpRenderTree/AccessibilityUIElement.h:
3252         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3253         (AccessibilityUIElement::AccessibilityUIElement):
3254         (AccessibilityUIElement::~AccessibilityUIElement):
3255         (_accessibilityNotificationCallback):
3256         (AccessibilityUIElement::addNotificationListener):
3257
3258 2010-01-08  Eric Seidel  <eric@webkit.org>
3259
3260         Reviewed by Simon Hausmann.
3261
3262         commit-queue should run run-javascriptcore-tests
3263         https://bugs.webkit.org/show_bug.cgi?id=33376
3264
3265         I also made it run the python and perl unit tests.
3266
3267         * Scripts/webkitpy/steps/runtests.py:
3268         * Scripts/webkitpy/webkitport.py:
3269
3270 2010-01-07  Andras Becsi  <abecsi@inf.u-szeged.hu>
3271
3272         Reviewed by Darin Adler.
3273
3274         Run the http and websocket tests after all other tests.
3275         https://bugs.webkit.org/show_bug.cgi?id=33153
3276
3277         * Scripts/run-webkit-tests:
3278
3279 2010-01-07  Adam Barth  <abarth@webkit.org>
3280
3281         Reviewed by Eric Seidel.
3282
3283         Fix some test-webkitpy expectations
3284         https://bugs.webkit.org/show_bug.cgi?id=33345
3285
3286         I forgot to change these when I added the CheckStyle step.
3287
3288         * Scripts/webkitpy/commands/upload_unittest.py:
3289
3290 2010-01-07  Adam Barth  <abarth@webkit.org>
3291
3292         Reviewed by Eric Seidel.
3293
3294         webkit-patch edit-changelogs (or upload) will open blank files if run outside the root
3295         https://bugs.webkit.org/show_bug.cgi?id=33341
3296
3297         Fix this by moving to the root directory before editing ChangeLogs.
3298         There is a related bug with CheckStyle.
3299
3300         * Scripts/webkitpy/steps/checkstyle.py:
3301         * Scripts/webkitpy/steps/editchangelog.py:
3302
3303 2010-01-07  Eric Seidel  <eric@webkit.org>
3304
3305         Reviewed by Nikolas Zimmermann.
3306
3307         media/unsupported-tracks.html is failing on Snow Leopard Release bot
3308         https://bugs.webkit.org/show_bug.cgi?id=32339
3309
3310         This is a speculative fix.  I do not have a Snow Leopard machine to test on
3311         and I've not seen mention of someone being able to reproduce this locally.
3312
3313         Prevent watchdog timer from firing after a test completes but before
3314         the next one starts, causing the error to appear in the next test.
3315
3316         * DumpRenderTree/mac/DumpRenderTree.mm:
3317         (dump): Stop the watchdog before printing #EOF for the test content.
3318         We only need to care about the JavaScript of the test running too long
3319         or some hang in WebCore.  Any other failures will be covered by the calling
3320         script's own watchdog timer.
3321
3322 2010-01-07  Eric Seidel  <eric@webkit.org>
3323
3324         Reviewed by Adam Barth.
3325
3326         commit-queue is stuck spinning due to exception
3327         https://bugs.webkit.org/show_bug.cgi?id=33358
3328
3329         * Scripts/webkitpy/commands/queues.py:
3330          - Don't try to stringify the exception.
3331
3332 2010-01-07  Mark Rowe  <mrowe@apple.com>
3333
3334         Reviewed by Jon Honeycutt.
3335
3336         Don't leak a JSStringRef within _accessibilityNotificationCallback.
3337
3338         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3339         (_accessibilityNotificationCallback): Have a JSRetainPtr adopt the JSStringRef so that it will be cleaned up
3340         when it goes out of scope.
3341
3342 2010-01-07  Simon Fraser  <simon.fraser@apple.com>
3343
3344         Reviewed by Darin Adler.
3345
3346         Add proposed rename of HTMLPlugInImageElement to HTMLEmbeddedObjectElement.
3347
3348         * Scripts/do-webcore-rename:
3349
3350 2010-01-07  Kim Grönholm  <kim.gronholm@nomovok.com>
3351
3352         Reviewed by Antti Koivisto.
3353
3354         Wrong state and TouchLists in TouchEvents
3355         https://bugs.webkit.org/show_bug.cgi?id=32878
3356
3357         * DumpRenderTree/qt/EventSenderQt.cpp:
3358         (EventSender::touchStart):
3359         (EventSender::touchEnd):
3360         (EventSender::clearTouchPoints):
3361         * DumpRenderTree/qt/EventSenderQt.h:
3362
3363 2010-01-07  Chris Jerdonek  <chris.jerdonek@gmail.com>
3364
3365         Reviewed by Adam Barth.
3366
3367         Created a module that runs the style package unit tests.
3368
3369         https://bugs.webkit.org/show_bug.cgi?id=32973
3370
3371         * Scripts/test-webkitpy:
3372         * Scripts/webkitpy/style/unittests.py: Added.
3373
3374 2010-01-07  Adam Barth  <abarth@webkit.org>
3375
3376         Reviewed by Maciej Stachowiak.
3377
3378         Don't print a redundant message when confirming a diff
3379         https://bugs.webkit.org/show_bug.cgi?id=33315
3380
3381         Instead of saying "ERROR: User declined" we should just exit because
3382         the use knows they just declined!
3383
3384         * Scripts/webkitpy/steps/confirmdiff.py:
3385
3386 2010-01-07  Adam Barth  <abarth@webkit.org>
3387
3388         Reviewed by Maciej Stachowiak.
3389
3390         Check style before uploading a patch
3391         https://bugs.webkit.org/show_bug.cgi?id=33314
3392
3393         * Scripts/webkitpy/commands/upload.py:
3394         * Scripts/webkitpy/steps/checkstyle.py:
3395         * Scripts/webkitpy/steps/options.py:
3396
3397 2010-01-07  Adam Barth  <abarth@webkit.org>
3398
3399         Reviewed by Maciej Stachowiak.
3400
3401         Add prepare and post to webkit-patch main help
3402         https://bugs.webkit.org/show_bug.cgi?id=33313
3403
3404         * Scripts/webkitpy/commands/upload.py:
3405
3406 2010-01-07  Eric Seidel  <eric@webkit.org>
3407
3408         Reviewed by Adam Barth.
3409
3410         Add Chromium bots to the list of "core builders" (builders which stop the commit-queue when they turn red)
3411         https://bugs.webkit.org/show_bug.cgi?id=33290
3412
3413         Add the Chromium builders to our list of core builders and test that our regexps work.
3414         I also updated our regexp testing to make sure we cover all known builders at build.webkit.org.
3415
3416         * Scripts/webkitpy/buildbot.py:
3417         * Scripts/webkitpy/buildbot_unittest.py:
3418
3419 2010-01-07  Adam Barth  <abarth@webkit.org>
3420
3421         Reviewed by Eric Seidel.
3422
3423         bugzilla-tool needs a new name
3424         https://bugs.webkit.org/show_bug.cgi?id=28459
3425
3426         Rename bugzilla-tool to webkit-patch.  Also, rename some commands to
3427         make more sense with the new name.
3428
3429         * Scripts/bugzilla-tool: Removed.
3430         * Scripts/webkit-patch: Added.
3431         * Scripts/webkit-tools-completion.sh:
3432         * Scripts/webkitpy/bugzilla_unittest.py:
3433         * Scripts/webkitpy/commands/download.py:
3434         * Scripts/webkitpy/commands/download_unittest.py:
3435         * Scripts/webkitpy/commands/early_warning_system.py:
3436         * Scripts/webkitpy/commands/queries.py:
3437         * Scripts/webkitpy/commands/queues.py:
3438         * Scripts/webkitpy/commands/queues_unittest.py:
3439         * Scripts/webkitpy/commands/upload.py:
3440         * Scripts/webkitpy/commands/upload_unittest.py:
3441         * Scripts/webkitpy/queueengine.py:
3442         * Scripts/webkitpy/steps/completerollout.py:
3443
3444 2010-01-07  Chris Jerdonek  <chris.jerdonek@gmail.com>
3445
3446         Reviewed by Eric Seidel.
3447
3448         Moved style-related modules to webkitpy.style sub-package.
3449
3450         https://bugs.webkit.org/show_bug.cgi?id=32971
3451
3452         * Scripts/check-webkit-style:
3453           - Updated import statement.
3454
3455         * Scripts/test-webkitpy:
3456           - Updated import statements.
3457
3458         * Scripts/webkitpy/cpp_style.py: Removed.
3459           - Moved to webkitpy/style.
3460
3461         * Scripts/webkitpy/cpp_style_unittest.py: Removed.
3462           - Moved to webkitpy/style.
3463
3464         * Scripts/webkitpy/style.py: Removed.
3465           - Moved to webkitpy/style/checker.py.
3466
3467         * Scripts/webkitpy/style/__init__.py: Added.
3468           - Added containing webkitpy directory to package search path.
3469
3470         * Scripts/webkitpy/style/checker.py: Copied from Scripts/webkitpy/style.py.
3471         * Scripts/webkitpy/style/checker_unittest.py: Copied from Scripts/webkitpy/style_unittest.py.
3472           - Updated import statement.
3473
3474         * Scripts/webkitpy/style/cpp_style.py: Copied from Scripts/webkitpy/cpp_style.py.
3475         * Scripts/webkitpy/style/cpp_style_unittest.py: Copied from Scripts/webkitpy/cpp_style_unittest.py.
3476           - Update import statement.
3477
3478         * Scripts/webkitpy/style/text_style.py: Copied from Scripts/webkitpy/text_style.py.
3479         * Scripts/webkitpy/style/text_style_unittest.py: Copied from Scripts/webkitpy/text_style_unittest.py.
3480         * Scripts/webkitpy/style_unittest.py: Removed.
3481           - Moved to webkitpy/style/checker_unittest.py.
3482
3483         * Scripts/webkitpy/text_style.py: Removed.
3484           - Moved to webkitpy/style.
3485
3486         * Scripts/webkitpy/text_style_unittest.py: Removed.
3487           - Moved to webkitpy/style.
3488
3489 2010-01-06  Kinuko Yasuda  <kinuko@chromium.org>
3490
3491         Reviewed by Eric Seidel.
3492
3493         [Qt] Support the 3rd argument of EventSender.keyDown that
3494         has been recently added to report keyLocation
3495         (see also: https://bugs.webkit.org/show_bug.cgi?id=28247).
3496         https://bugs.webkit.org/show_bug.cgi?id=33250
3497
3498         Test: fast/events/keydown-numpad-keys.html
3499
3500         * DumpRenderTree/qt/EventSenderQt.cpp:
3501         (EventSender::keyDown):
3502         * DumpRenderTree/qt/EventSenderQt.h:
3503
3504 2010-01-06  Eric Seidel  <eric@webkit.org>
3505
3506         Reviewed by Adam Barth.
3507
3508         Add long_help for all common commands.
3509         https://bugs.webkit.org/show_bug.cgi?id=33261
3510
3511         For now these long_helps are pretty basic.
3512         These were all written to just explain the steps
3513         that each command runs.  This style long_help could
3514         be made easier by using:
3515         https://bugs.webkit.org/show_bug.cgi?id=33257
3516
3517         * Scripts/webkitpy/commands/download.py:
3518         * Scripts/webkitpy/commands/queries.py:
3519
3520 2010-01-06  Diego Gonzalez  <diego.gonzalez@openbossa.org>
3521
3522         Reviewed by Kenneth Christiansen.
3523
3524         [Qt] Add page zooming support to Qt DumpRenderTree
3525         https://bugs.webkit.org/show_bug.cgi?id=32898
3526
3527         Patch by Kim Grönholm  <kim.gronholm@nomovok.com>,
3528                  Diego Gonzalez <diego.gonzalez@openbossa.org> and
3529                  Afonso Costa <afonso.costa@openbossa.org>
3530
3531         * DumpRenderTree/qt/EventSenderQt.cpp:
3532         (EventSender::zoomPageIn):
3533         (EventSender::zoomPageOut):
3534         * DumpRenderTree/qt/EventSenderQt.h:
3535
3536 2010-01-06  Eric Seidel  <eric@webkit.org>
3537
3538         No review, just adding Mike Belshe's new bugzilla email at his request.
3539
3540         * Scripts/webkitpy/committers.py:
3541
3542 2010-01-06  Eric Seidel  <eric@webkit.org>
3543
3544         Unreviewed.  Rolling out r52869 and r52853 due to bot
3545         and local run-webkit-test failures
3546
3547         REGRESSION(52854?) fast/workers/shared-worker-constructor.html failed on Leopard Build Bot
3548         https://bugs.webkit.org/show_bug.cgi?id=33256
3549
3550         The original bug was https://bugs.webkit.org/show_bug.cgi?id=33153
3551
3552         * Scripts/run-webkit-tests:
3553
3554 2010-01-06  Eric Seidel  <eric@webkit.org>
3555
3556         Unreviewed "build" fix.  Just adding missing include.
3557
3558         bugzilla-tool rollout --complete-rollout should make a nicer bug comment
3559         https://bugs.webkit.org/show_bug.cgi?id=29212
3560
3561         * Scripts/webkitpy/steps/completerollout.py:
3562
3563 2010-01-06  Eric Seidel  <eric@webkit.org>
3564
3565         Reviewed by Adam Barth.
3566
3567         bugzilla-tool rollout --complete-rollout should make a nicer bug comment
3568         https://bugs.webkit.org/show_bug.cgi?id=29212
3569
3570         * Scripts/webkitpy/bugzilla.py:
3571          - Make reopen_bug robust against the bug already being open.
3572         * Scripts/webkitpy/commands/download.py:
3573          - Remove dead code from Rollout.
3574         * Scripts/webkitpy/steps/completerollout.py:
3575          - Improve the rollout comment.
3576
3577 2010-01-06  Andras Becsi  <abecsi@inf.u-szeged.hu>
3578
3579         Reviewed by Darin Adler.
3580
3581         Set isHttpdOpen to 0 if pidfile does not exist for some reason.
3582         Speculative fix for https://bugs.webkit.org/show_bug.cgi?id=33256.
3583
3584         * Scripts/run-webkit-tests:
3585
3586 2010-01-06  Andras Becsi  <abecsi@inf.u-szeged.hu>
3587
3588         Reviewed by Darin Adler.
3589
3590         Change hardcoded /tmp in run-webkit-tests to File::Spec->tmpdir(),
3591         and remove the httpd's pidfile directory if httpd terminated.
3592
3593         * Scripts/run-webkit-tests:
3594
3595 2010-01-05  Chris Jerdonek  <chris.jerdonek@gmail.com>
3596
3597         Reviewed by David Levin.
3598
3599         Refactored check-webkit-style's argument parser to not rely
3600         on global state, and improved its error handling and unit
3601         test coverage.
3602
3603         https://bugs.webkit.org/show_bug.cgi?id=32966
3604
3605         * Scripts/check-webkit-style:
3606           - Adjusted to use new argument parser.
3607
3608         * Scripts/webkitpy/cpp_style.py: