Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.
[WebKit-https.git] / WebKitTools / ChangeLog
1 2007-12-05  Mark Rowe  <mrowe@apple.com>
2
3         Reviewed by Alp Toker.
4
5         Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.  This prevents
6         many layout tests from hanging while waiting on user responses to dialogs.
7
8         * DumpRenderTree/gtk/DumpRenderTree.cpp:
9         (invalidateAnyPreviousWaitToDumpWatchdog):
10         (webViewScriptAlert):
11         (webViewScriptPrompt):
12         (webViewScriptConfirm):
13         (main):
14         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
15         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
16         (waitToDumpWatchdogFired):
17         (LayoutTestController::setWaitToDump):
18
19 2007-12-05  Mark Rowe  <mrowe@apple.com>
20
21         Reviewed by Alp Toker.
22
23         Flesh out DumpRenderTree for Gtk.  After these changes, the majority of the tests in fast/js pass.
24
25         * DumpRenderTree/gtk/DumpRenderTree.cpp:
26         (dumpFramesAsText): Don't print the frame name when dumping the main frame as text.
27         (dump):
28         (runTest):
29         (webViewLoadStarted): Store the top frame when it starts loading so we can use it to determine when to dump.
30         (webViewLoadFinished): Dump when the top frame load completes if we're not waiting for a JS callback and the
31         work queue is empty.
32         (webViewWindowObjectCleared): Set up window.layoutTestController.
33         (webViewConsoleMessage): Match the console message format expected by the layout test results.
34         (main): Hook up the new signals.
35         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
36         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Only notify done if the top frame has completed loading to avoid
37         dumping multiple times.
38         * Scripts/build-dumprendertree: Ensure build-dumprendertree is a no-op for Gtk too.
39         * Scripts/run-webkit-tests: Teach run-webkit-tests that Gtk is like Qt in many ways.  Use run-launcher to open test results.
40
41 2007-12-14  Anders Carlsson  <andersca@apple.com>
42
43         Reviewed by Brady.
44
45         Assert that a web frame that's loading a resource always has either a data source or 
46         a provisional data source.
47         
48         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
49         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
50
51 2007-12-14  Darin Adler  <darin@apple.com>
52
53         - fix mistake causing nearly all tests to fail on Windows
54
55         * DumpRenderTree/win/UIDelegate.cpp:
56         (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with
57         npos, not 0. Also pass URL in to URL function rather than passing the entire message.
58
59         * DumpRenderTree/mac/UIDelegate.mm:
60         (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather
61         than passing the entire message.
62
63 2007-12-14  Darin Adler  <darin@apple.com>
64
65         - fix Tiger build
66
67         * DumpRenderTree/mac/UIDelegate.mm:
68         (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any
69         new-to-Leopard methods.
70
71 2007-12-14  Darin Adler  <darin@apple.com>
72
73         * DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method
74         since it now triggers unwanted icon loading. We only had it because we implemented "all"
75         delegate methods here.
76
77 2007-12-14  Anders Carlsson  <andersca@apple.com>
78
79         Reviewed by Darin and Geoff.
80
81         <rdar://problem/5619295> 
82         REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
83         
84         Add property getting methods to the plug-in.
85         
86         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
87         (pluginInvoke):
88
89 2007-12-14  Kevin McCullough  <kmccullough@apple.com>
90
91         Reviewed by Darin.
92
93         - Layout test fix for mac. When dumped to the console local file paths
94         now only show the name of the resource not the whole path.  This is to
95         make the results machine and OS independent.
96
97         * DumpRenderTree/mac/UIDelegate.mm:
98         (-[UIDelegate webView:addMessageToConsole:]):
99
100 2007-12-13  Kevin McCullough  <kmccullough@apple.com>
101
102         Reviewed by Adam.
103
104         - Layout tests fix.  We need a way to remove machine-dependent
105         information from paths in layout test results. The UIDelegate now does
106         this.
107
108         * DumpRenderTree/DumpRenderTree.h:
109         * DumpRenderTree/win/DumpRenderTree.cpp:
110         (urlSuitableForTestResult):
111         * DumpRenderTree/win/DumpRenderTreeWin.h:
112         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
113         * DumpRenderTree/win/UIDelegate.cpp:
114         (UIDelegate::webViewAddMessageToConsole):
115
116 2007-12-13  Alp Toker  <alp@atoker.com>
117
118         Build fix for DRT breakage introduced in r28690.
119
120         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
121         (LayoutTestController::pathToLocalResource):
122
123 2007-12-12  Kevin McCullough  <kmccullough@apple.com>
124
125         Reviewed by Alice and Sam.
126
127         - <rdar://5621435> Need a way to specify local resources (being loaded
128         from HTTP tests) on Windows.
129         - Implemented pathToLocalResource which exposes the functionality of
130         converting a given unix path to the correct location on Windows.
131
132         * DumpRenderTree/LayoutTestController.cpp:
133         (pathToLocalResourceCallback):
134         (LayoutTestController::staticFunctions):
135         * DumpRenderTree/LayoutTestController.h:
136         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
137         (LayoutTestController::pathToLocalResource):
138         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
139         (LayoutTestController::pathToLocalResource):
140
141 2007-12-12  Anders Carlsson  <andersca@apple.com>
142
143         Reviewed by Sam.
144
145         <rdar://problem/5132003>
146         dumpResourceLoadCallbacks is not implemented in DRT on Windows.
147
148         * DumpRenderTree/win/DumpRenderTree.cpp:
149         (main):
150         Set the resource load delegate.
151         
152         * DumpRenderTree/win/DumpRenderTree.vcproj:
153         
154         * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
155         * DumpRenderTree/win/ResourceLoadDelegate.h: Added.
156
157 2007-12-12  Alexey Proskuryakov  <ap@webkit.org>
158
159         Reviewed by Adam Roben.
160
161         Fix conversion from double to LPARAM in dispatchMessage().
162
163         * DumpRenderTree/win/EventSender.cpp:
164         (dispatchMessageCallback):
165
166 2007-12-11  Dan Bernstein  <mitz@apple.com>
167
168         Reviewed by Mark Rowe and Sam Weinig too!
169
170         - added Helvetica Oblique and Helvetica Bold Oblique to the list of
171           fonts DumpRenderTree registers.
172
173         * DumpRenderTree/win/DumpRenderTree.cpp:
174         (initialize):
175
176 2007-12-11  Brady Eidson  <beidson@apple.com>
177
178         Reviewed by Anders
179
180         Make DumpRenderTree on mac use its own path for Databases testing
181
182         * DumpRenderTree/mac/DumpRenderTree.mm:
183         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree 
184           for future DRT-only use, then use it to construct the Databases path and set that default
185
186 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
187
188         Reviewed by Darin.
189
190         <rdar://problem/5535636>
191         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
192
193         http://bugs.webkit.org/show_bug.cgi?id=13916
194         JavaScript detects Tab as a character input on a textfield validation
195
196         * DumpRenderTree/mac/EventSendingController.mm:
197         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
198         Dispatch a keyup to better match what happens when a key is physically pressed.
199
200         * DumpRenderTree/win/EventSender.cpp:
201         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
202         returning from keyDown().
203         (getConstantCallback): Fixed a couple copy/paste mistakes.
204
205 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
206
207         Reviewed by Oliver.
208
209         - <rdar://5599845> Drosera: Does not show loal files in the file list
210         on the left side.
211
212         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
213         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
214         so the open source community can build.
215
216 2007-12-10  Brady Eidson  <beidson@apple.com>
217
218         Rubberstamped by Sam Weinig
219
220         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
221
222         * DumpRenderTree/mac/UIDelegate.mm:
223         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
224         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
225
226 2007-12-08  Oliver Hunt  <oliver@apple.com>
227
228         Reviewed by Sam W.
229
230         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
231         
232         Fixes <rdar://problem/5620249> Must disable SVG animation
233         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
234         
235         In order to allow finer grained control over the set of SVG features
236         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
237         distinct flags:
238         ENABLE_SVG_ANIMATION
239         ENABLE_SVG_FILTERS
240         ENABLE_SVG_FONTS
241         ENABLE_SVG_AS_IMAGE
242         ENABLE_SVG_USE
243         
244         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
245         
246         Script handles all the new build flags, and allows --svg-experimental
247         to automatically enable all features.
248
249         * Scripts/build-webkit:
250
251 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
252
253         Fix version parsing.
254
255         Rubber-stamped by Oliver.
256
257         * Drosera/win/Drosera.vcproj/auto-version.sh:
258
259 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
260
261         Build modifications for Drosera.
262
263         Reviewed by Adam.
264
265         * Drosera/DroseraWin.make: Added.
266         * Drosera/win/Drosera.vcproj/Drosera.rc:
267         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
268         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
269         * Drosera/win/Drosera.vcproj/VERSION: Added.
270         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
271
272 2007-12-06  Adam Roben  <aroben@apple.com>
273
274         Explicitly turn on the Mac font ascent hack on Windows
275
276         This keeps our font metrics matching those from Mac.
277
278         Reviewed by Hyatt.
279
280         * DumpRenderTree/win/DumpRenderTree.cpp:
281         (main):
282
283 2007-12-06  Anders Carlsson  <andersca@apple.com>
284
285         Rename main.c to main.cpp here too.
286         
287         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
288
289 2007-12-06  Sam Weinig  <sam@webkit.org>
290
291         Rubber stamped by Geoff.
292
293         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
294
295 2007-12-06  Darin Adler  <darin@apple.com>
296
297         * Scripts/do-webcore-rename: Some more renaming plans.
298
299 2007-12-06  Anders Carlsson  <andersca@apple.com>
300
301         Restore implementation of testGetIntIdentifier that was accidentally
302         removed somehow (possibly when I made PluginObject be a cpp file).
303         
304         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
305         (pluginInvoke):
306
307 2007-12-05  Anders Carlsson  <andersca@apple.com>
308
309         Make the entry points extern "C".
310         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
311         
312 2007-12-05  Anders Carlsson  <andersca@apple.com>
313
314         C++ warning fixes.
315         
316         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
317         (NPP_New):
318         (NPP_Destroy):
319         (NPP_SetWindow):
320         (NPP_NewStream):
321         (NPP_HandleEvent):
322         (NPP_URLNotify):
323         (NPP_GetValue):
324
325 2007-12-05  Anders Carlsson  <andersca@apple.com>
326
327         Add the .cpp files to the TestNetscapePlugIn target.
328
329         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
330
331 2007-12-05  Anders Carlsson  <andersca@apple.com>
332
333         Reviewed by Geoff.
334         
335         Rename the TestNetscapePlugIn .c files to be .cpp.
336
337         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
338         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
339         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
340         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
341         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
342         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
343         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
344         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
345
346 2007-12-05  Adam Roben  <aroben@apple.com>
347
348         Fix case of keypresses from the Windows implementation of eventSender.keyDown
349
350         This fixes several regression tests.
351
352         Reviewed by Alice.
353
354         * DumpRenderTree/win/EventSender.cpp:
355         (keyDownCallback): Virtual keycodes for ASCII characters are always
356         uppercase, so we need to check the case of the original character
357         passed in to eventSender.keyDown.
358
359 2007-12-05  Adam Roben  <aroben@apple.com>
360
361         Learn from Tim's mistakes
362
363         * DumpRenderTree/win/DumpRenderTree.cpp:
364         (runTest): Reset the authorAndUserStylesEnabled preference for each
365         test.
366
367 2007-12-05  Alp Toker  <alp@atoker.com>
368
369         Reviewed by Mark Rowe.
370
371         Initialize GTK+ and WebKit so the tests can run.
372
373         Reorganize the headers a little.
374
375         * DumpRenderTree/gtk/DumpRenderTree.cpp:
376         (main):
377
378 2007-12-04  Anders Carlsson  <andersca@apple.com>
379
380         Remove IWebScriptScope include.
381         
382         * Drosera/win/DebuggerDocumentPlatform.cpp:
383
384 2007-12-04  Sam Weinig  <sam@webkit.org>
385
386         Rubber stamped by Mark Rowe.
387
388         Define CF as platform for mac and revert r28409
389
390         * DumpRenderTree/DumpRenderTree.h:
391         * DumpRenderTree/mac/DumpRenderTreeMac.h:
392
393 2007-12-04  Sam Weinig  <sam@webkit.org>
394
395         Define CF as platform for windows.
396
397         Reviewed by Adam Roben.
398
399         * DumpRenderTree/win/DumpRenderTreeWin.h:
400
401 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
402
403         Reviewed by Adam and Darin.
404
405         - Removed a needless BSTR cleanup.
406
407         * Drosera/win/DebuggerDocumentPlatform.cpp:
408         (DebuggerDocument::getPlatformCurrentFunctionStack):
409
410 2007-11-27  Adam Roben  <aroben@apple.com>
411
412         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
413
414         Reviewed by Maciej.
415
416         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
417         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
418
419 2007-12-04  Alp Toker  <alp@atoker.com>
420
421         Prospective Win DRT build fix.
422
423         * DumpRenderTree/DumpRenderTree.h:
424
425 2007-12-04  Alp Toker  <alp@atoker.com>
426
427         Fix a clobbered copyright header.
428
429         * DumpRenderTree/gtk/DumpRenderTree.cpp:
430
431 2007-12-04  Xan Lopez  <xan@gnome.org>
432
433         Reviewed by Alp Toker.
434
435         http://bugs.webkit.org/show_bug.cgi?id=15561
436         GTK port needs DumpRenderTree implementation
437
438         Start work on the GTK+ DRT.
439
440         This does not work yet, and there are a few lingering style issues
441         (nothing major) but this patch has been stuck in the bug tracker for
442         too long already.
443
444         * DumpRenderTree/DumpRenderTree.h:
445         * DumpRenderTree/gtk: Added.
446         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
447         (autocorrectURL):
448         (shouldLogFrameLoadDelegates):
449         (dumpFrameScrollPosition):
450         (displayWebView):
451         (appendString):
452         (dumpFramesAsText):
453         (dumpRenderTreeAsText):
454         (dump):
455         (runTest):
456         (main):
457         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
458         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
459         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
460         (GCController::collect):
461         (GCController::collectOnAlternateThread):
462         (GCController::getJSObjectCount):
463         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
464         (LayoutTestController::~LayoutTestController):
465         (LayoutTestController::addDisallowedURL):
466         (LayoutTestController::clearBackForwardList):
467         (LayoutTestController::copyDecodedHostName):
468         (LayoutTestController::copyEncodedHostName):
469         (LayoutTestController::display):
470         (LayoutTestController::keepWebHistory):
471         (LayoutTestController::notifyDone):
472         (LayoutTestController::queueBackNavigation):
473         (LayoutTestController::queueForwardNavigation):
474         (LayoutTestController::queueLoad):
475         (LayoutTestController::queueReload):
476         (LayoutTestController::queueScript):
477         (LayoutTestController::setAcceptsEditing):
478         (LayoutTestController::setCustomPolicyDelegate):
479         (LayoutTestController::setMainFrameIsFirstResponder):
480         (LayoutTestController::setTabKeyCyclesThroughElements):
481         (LayoutTestController::setUseDashboardCompatibilityMode):
482         (LayoutTestController::setUserStyleSheetEnabled):
483         (LayoutTestController::setUserStyleSheetLocation):
484         (LayoutTestController::setWindowIsKey):
485         (LayoutTestController::setWaitToDump):
486         (LayoutTestController::windowCount):
487         (LayoutTestController::setPrivateBrowsingEnabled):
488         (LayoutTestController::setAuthorAndUserStylesEnabled):
489         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
490         (JSStringCopyUTF8CString):
491         (LoadItem::invoke):
492         (ReloadItem::invoke):
493         (ScriptItem::invoke):
494         (BackForwardItem::invoke):
495
496 2007-12-03  Sam Weinig  <sam@webkit.org>
497
498         Move JavaScriptCore thread testing code to pthread specific directory
499         and remove the dependance on CoreFoundation by using WTF::HashSet.
500
501         Reviewed by Geoff and Oliver.
502
503         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
504         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
505         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
506         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
507         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
508         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
509         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
510         * DumpRenderTree/pthreads: Added.
511         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
512         (javaScriptThreads):
513         (runJavaScriptThread):
514         (startJavaScriptThreads):
515         (stopJavaScriptThreads):
516
517 2007-12-03  Andrew Bonventre  <andybons@google.com>
518
519         Reviewed by Darin Adler.
520
521         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
522         Symbol lookup menu broken in debugger view
523
524         * Drosera/debugger.js: Fixed javascript error where document property
525         should have been used instead of contentDocument in switchFunction that
526         was breaking the select symbol dropdown menu.  This is because
527         window.frames will return a Window object and not a frame object like
528         the author was originally expecting.
529
530 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
531
532         Reviewed by Adam.
533
534         - <rdar://5618942> Drosera: Console window does not process everything
535         correctly.
536         - <rdar://5619005> Drosera: could be sped up by moving the 
537         WebScriptScope stuff into the WebScriptCallFrame.
538         - Now the console can correctly process objects and does not receive
539         notifications from JavaScriptCore about the JavaScript in Drosera's
540         own process.
541
542         * Drosera/win/DebuggerDocumentPlatform.cpp:
543         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
544         (DebuggerDocument::platformValueForScopeVariableNamed):
545
546 2007-12-03  Stephanie  <slewis@apple.com>
547
548         Reviewed by Darin.
549
550         Check to see if we are building a debug root
551
552         * Scripts/check-for-global-initializers: 
553
554 2007-12-03  Dan Bernstein  <mitz@apple.com>
555
556         Reviewed by Darin Adler.
557
558         - added a testGetIntIdentifier() method to TestNetscapePlugIn
559
560         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
561         (pluginInvoke):
562
563 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
564
565         Reviewed by Oliver.
566
567         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
568         in a more fine-grained manner than eventSender.keyDown().
569
570         * DumpRenderTree/win/EventSender.cpp:
571         (getConstantCallback):
572         (dispatchMessageCallback):
573
574 2007-12-02  Darin Adler  <darin@apple.com>
575
576         * Scripts/do-webcore-rename: More planned renaming.
577
578 2007-12-02  Sam Weinig  <sam@webkit.org>
579
580         Rubber stamped by Anders.
581
582         Use [NSURL absoluteString] instead of [NSURL description] in order to get
583         more uniform results cross platform.
584
585         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
586         (-[NSURL _drt_descriptionSuitableForTestResult]):
587
588 2007-12-02  Sam Weinig  <sam@webkit.org>
589
590         Rubber stamped by Niko.
591
592         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
593
594         * DumpRenderTree/win/DumpRenderTree.cpp:
595         * DumpRenderTree/win/DumpRenderTree.vcproj:
596         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
597         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
598         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
599         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
600
601 2007-12-01  Alp Toker  <alp@atoker.com>
602
603         Reviewed by Adam Roben.
604
605         Make use of the newly introduced webkit.h convenience header.
606
607         * GtkLauncher/main.c:
608
609 2007-12-01  Adam Treat  <treat@kde.org>
610
611         Reviewed by Simon.
612
613         * Check to see if the directory exists and exit if not.
614
615         * DumpRenderTree/qt/main.cpp:
616         (main):
617
618 2007-12-01  Adam Treat  <treat@kde.org>
619
620         Reviewed by Simon.
621
622         * Don't hide symbols when in Debug mode
623         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
624
625
626         * DumpRenderTree/qt/main.cpp:
627         (messageHandler):
628
629 2007-11-30  Alp Toker  <alp@atoker.com>
630
631         Reviewed by Adam Roben.
632
633         http://bugs.webkit.org/show_bug.cgi?id=15691
634         [GTK] Public API does not follow GTK+ conventions
635
636         Refactor the WebKit/GTK+ public API. Changes:
637           WebKitPage -> WebKitWebView
638           WebKitFrame -> WebKitWebFrame
639
640         Public API source and header names have been updated to mirror the API
641         changes.
642
643         The API is now kept in WebKit/gtk/WebView to match other ports in the
644         same class such as Mac and Win.
645
646         * GtkLauncher/main.c:
647         (activate_uri_entry_cb):
648         (link_hover_cb):
649         (title_change_cb):
650         (progress_change_cb):
651         (go_back_cb):
652         (go_forward_cb):
653         (create_browser):
654         (main):
655
656 2007-11-30  Adam Roben  <aroben@apple.com>
657
658         Hopefully the final build fix
659
660         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
661         pull in WTF's assertion/logging functions.
662
663 2007-11-30  Adam Roben  <aroben@apple.com>
664
665         Another build fix
666
667         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
668         WebKit.lib.
669
670 2007-11-30  Adam Roben  <aroben@apple.com>
671
672         Debug build fix
673
674         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
675         configuration.
676         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
677         projects.
678         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
679         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
680         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
681
682 2007-11-30  Sam Weinig  <sam@webkit.org>
683
684         Reviewed by Adam Roben.
685
686         Fix drawSelectionRect to actually draw the selection rect.
687
688         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
689         (drawSelectionRect):
690
691 2007-11-30  Darin Adler  <darin@apple.com>
692
693         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
694
695 2007-11-30  Darin Adler  <darin@apple.com>
696
697         * Scripts/do-webcore-rename: Get ready for some future renaming.
698
699 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
700
701         Reviewed by Adam.
702
703         - Removed some unnecessary functions and changed an unused return type. 
704
705         * Drosera/win/DebuggerClient.cpp:
706         (registerConsoleClass):
707         * Drosera/win/DebuggerClient.h:
708         * Drosera/win/Drosera.cpp:
709         (registerDroseraClass):
710
711 2007-11-28  Alp Toker  <alp@atoker.com>
712
713         Reviewed by Timothy Hatcher.
714
715         http://bugs.webkit.org/show_bug.cgi?id=16174
716         [GTK] Use "URI" not "URL" in public API
717
718         Replace use of the term "URL" with "URI" in public headers,
719         documentation and some internal code to match GLib/GTK+ convention.
720
721         This is now mentioned in the API guidelines:
722           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
723
724         * GtkLauncher/main.c:
725         (activate_uri_entry_cb):
726         (title_change_cb):
727         (create_toolbar):
728         (main):
729
730 2007-11-29  Anders Carlsson  <andersca@apple.com>
731
732         Reviewed by Sam.
733
734         <rdar://problem/5230478>
735         FrameLoadDelegate callbacks are not dumped in DRT.
736         
737         * DumpRenderTree/win/DumpRenderTree.cpp:
738         (shouldLogFrameLoadDelegates):
739         (runTest):
740         (main):
741         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
742         (BSTRtoString):
743         (descriptionSuitableForTestResult):
744         (FrameLoadDelegate::QueryInterface):
745         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
746         (FrameLoadDelegate::didFailProvisionalLoadWithError):
747         (FrameLoadDelegate::didCommitLoadForFrame):
748         (FrameLoadDelegate::didFinishLoadForFrame):
749         (FrameLoadDelegate::willCloseFrame):
750         (FrameLoadDelegate::didClearWindowObject):
751         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
752         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
753         * DumpRenderTree/win/FrameLoaderDelegate.h:
754         (FrameLoadDelegate::windowScriptObjectAvailable):
755         (FrameLoadDelegate::didFirstLayoutInFrame):
756
757 2007-11-29  Sam Weinig  <sam@webkit.org>
758
759         Reviewed by Anders.
760
761         Add database quota UIDelegates methods to DRT UIDelegate.
762
763         * DumpRenderTree/mac/UIDelegate.mm:
764         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
765         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
766
767 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
768
769         Reviewed by Sam.
770
771         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
772         dying and vice versa.
773         - This fix will allow Drosera and Safari to reconnect if either of them
774         closes correctly, but does not fix the case where one of them dies
775         silently.
776
777         * Drosera/win/ServerConnection.cpp:
778         (ServerConnection::attemptToCreateServerConnection): Added a safety
779         check, because it's possilbe to try to connect to a server that's dying.
780         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
781         the server has died.
782         * Drosera/win/ServerConnection.h: Added the new function and removed
783         an unnecessary member.
784
785 2007-11-29  Anders Carlsson  <andersca@apple.com>
786
787         * DumpRenderTree/win/DumpRenderTree.vcproj:
788         Add shlwapi.lib to all configurations.
789
790 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
791
792         - Build fix.  Added additional includes for VS Express to the Release
793         project.
794
795         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
796
797 2007-11-29  Anders Carlsson  <andersca@apple.com>
798
799         Reviewed by Adam.
800
801         <rdar://problem/5132005>
802         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
803         
804         * DumpRenderTree/win/DumpRenderTree.vcproj:
805         Add shlwapi.lib
806         
807         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
808         (LayoutTestController::setUserStyleSheetEnabled):
809         Implement this.
810         
811         (appendComponentToPath):
812         New method which wraps the Win32 API PathAppend.
813         
814         (followShortcuts):
815         New method which checks if a file points to a shortcut and
816         follows the shortcut.
817         
818         (resolveCygwinPath):
819         New method that takes a cygwin unix-style path and returns the Win32 path.
820         
821         (cfStringRefToWString):
822         
823         (LayoutTestController::setUserStyleSheetLocation):
824         Implement this.
825
826 2007-11-29  Alice Liu  <alice.liu@apple.com>
827
828         Reviewed by Adam.
829
830         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
831
832         * DumpRenderTree/win/EventSender.cpp:
833         (keyDownCallback):
834         uppercase letters were being sent as lowercase letters without the shift key down.
835
836 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
837
838         - Windows build fix. VS express needs some love.
839
840         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
841
842 2007-11-28  Darin Adler  <darin@apple.com>
843
844         Reviewed by Adam Roben.
845
846         * DumpRenderTree/mac/EventSendingController.mm:
847         (-[EventSendingController keyDown:withModifiers:]):
848         Send capital letters through as lowercase letters with the shift key down
849         rather than sending them as if they were highly unusual "capital letter keys".
850
851         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
852         where you need to update results and more tests are failing than before.
853
854 2007-11-28  Anders Carlsson  <andersca@apple.com>
855
856         Reviewed by Darin.
857
858         <rdar://problem/5132001>
859         contextClick is not implemented in DRT on Windows.
860         
861         * DumpRenderTree/win/EventSender.cpp:
862         (contextClickCallback):
863         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
864         by a WM_RBUTTONUP message.
865         
866         * DumpRenderTree/win/UIDelegate.cpp:
867         (UIDelegate::hasCustomMenuImplementation):
868         (UIDelegate::trackCustomPopupMenu):
869         * DumpRenderTree/win/UIDelegate.h:
870         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
871         menu from being shown (and causing the DRT to hang).
872
873 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
874
875         Reviewed by Darin.
876
877         Fix DumpRenderTree ObjC bug comparing strings.
878
879         * DumpRenderTree/mac/ObjCController.m:
880         (-[ObjCController identityIsEqual::]): Compare strings with string
881         equality instead of identiy equality.
882
883 2007-11-27  Timothy Hatcher  <timothy@apple.com>
884
885         Reviewed by Sam.
886
887         Reset the authorAndUserStylesEnabled preference
888         back to YES for each test. Fixes the broken tests.
889
890         * DumpRenderTree/mac/DumpRenderTree.mm:
891         (resetWebViewToConsistentStateBeforeTesting):
892
893 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
894
895         Reviewed by Adam.
896
897         - Drosera now displays the console window, although it cannot currently
898         process JavaScript.
899
900         * Drosera/win/DebuggerClient.cpp: Shows the console window.
901         (registerConsoleClass): Implemented.
902         (consoleWndProc): Implemented.
903         (DebuggerClient::onSize): Implemented.
904         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
905         new window.
906         * Drosera/win/DebuggerClient.h: Added needed method and members for 
907         creating and maintaining a new window.
908         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
909         lines of code to more appropriate places.
910         (Drosera::handleCommand):
911         (Drosera::initUI):
912         (Drosera::onSize):
913         (Drosera::attach):
914
915 2007-11-27  Timothy Hatcher  <timothy@apple.com>
916
917         Reviewed by Dave Hyatt.
918
919         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
920         
921         Add support for disabling author and user styles for testing.
922
923         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
924         * DumpRenderTree/LayoutTestController.cpp:
925         (setAuthorAndUserStylesEnabledCallback):
926         (LayoutTestController::staticFunctions):
927         * DumpRenderTree/LayoutTestController.h:
928         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
929         (LayoutTestController::setAuthorAndUserStylesEnabled):
930         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
931         (LayoutTestController::setAuthorAndUserStylesEnabled):
932
933 2007-11-26  Dan Bernstein  <mitz@apple.com>
934
935         - Tiger build fix.
936
937         * DumpRenderTree/mac/Configurations/Base.xcconfig:
938
939 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
940
941         Reviewed by Maciej.
942
943         - Implemented displaying variables for Drosera on Win.
944
945         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
946         that retrieve variables to not hold onto the return value since it's
947         not returned.  Also changed to use the new signatures of the retrieval
948         functions.
949         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
950         (DebuggerDocument::platformValueForScopeVariableNamed):
951         * Drosera/win/Drosera.cpp: Removed a needless TODO.
952         (droseraWndProc):
953
954 2007-11-26  Sam Weinig  <sam@webkit.org>
955
956         Cleanup names of painting and repainting functions.
957
958         Reviewed by Adam Roben.
959
960         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
961         (drawSelectionRect): was drawSelectionRectIntoContext.
962         (dumpWebViewAsPixelsAndCompareWithExpected):
963         * DumpRenderTree/cg/PixelDumpSupportCG.h:
964         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
965         (paintWebView): was drawWebViewIntoContext.
966         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
967
968 2007-11-26  Sam Weinig  <sam@webkit.org>
969
970         Reviewed by Dan Bernstein.
971
972         - Leopard build fix
973
974         * DumpRenderTree/mac/Configurations/Base.xcconfig:
975
976 2007-11-26  Sam Weinig  <sam@webkit.org>
977
978         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
979         Use shared PixelDumpSupport for Mac DRT
980
981         Reviewed by Adam Roben.
982
983         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
984         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
985         * DumpRenderTree/cg/ImageDiffCG.cpp:
986         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
987         (drawSelectionRectIntoContext):
988         (dumpWebViewAsPixelsAndCompareWithExpected):
989         * DumpRenderTree/cg/PixelDumpSupportCG.h:
990         * DumpRenderTree/mac/Configurations/Base.xcconfig:
991         * DumpRenderTree/mac/DumpRenderTree.mm:
992         (dump):
993         * DumpRenderTree/mac/ImageDiff.m: Removed.
994         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
995         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
996         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
997         (setDefaultColorProfileToRGB):
998         (getBitmapContextFromWebView):
999         (drawWebViewIntoContext):
1000         (repaintWithVerticalSweep):
1001         (repaintWithHorizontalSweep):
1002         (getSelectionRect):
1003         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
1004
1005 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
1006
1007         Bug 16052: prepare-ChangeLog doesn't report deleted files
1008         <http://bugs.webkit.org/show_bug.cgi?id=16052>
1009
1010         Reviewed by Sam.
1011
1012         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
1013
1014 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
1015
1016         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
1017         <http://bugs.webkit.org/show_bug.cgi?id=15864>
1018
1019         Reviewed by Adam.
1020
1021         Roll functionality of merge-changelog into resolve-ChangeLogs
1022         script.  The script now checks for ChangeLog.rej and
1023         ChangeLog.orig files first.  If it finds them, it uses the
1024         ChangeLog.rej file as a patch (in old contextual diff format) to
1025         apply with --fuzz=3.
1026
1027         * Scripts/merge-changelog: Removed.
1028         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
1029
1030 2007-11-25  Sam Weinig  <sam@webkit.org>
1031
1032         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
1033
1034         Reviewed by Mark Rowe.
1035
1036         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1037         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1038         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1039         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
1040         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
1041
1042 2007-11-25  Sam Weinig  <sam@webkit.org>
1043
1044         Convert DumpRenderTree to ues .xcconfig files.
1045
1046         Reviewed by Mark Rowe.
1047
1048         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1049         * DumpRenderTree/mac/Configurations: Added.
1050         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
1051         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
1052         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
1053
1054 2007-11-25  Sam Weinig  <sam@webkit.org>
1055
1056         Add ForwardingHeaders to wtf for DumpRenderTree.
1057
1058         Reviewed by Mark Rowe.
1059
1060         * DumpRenderTree/DumpRenderTree.h:
1061         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1062         * DumpRenderTree/ForwardingHeaders: Added.
1063         * DumpRenderTree/ForwardingHeaders/wtf: Added.
1064         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
1065         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
1066         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
1067         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
1068         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
1069         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
1070         * DumpRenderTree/LayoutTestController.cpp:
1071         * DumpRenderTree/WorkQueue.cpp:
1072         * DumpRenderTree/mac/DumpRenderTree.mm:
1073         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1074         * DumpRenderTree/mac/JavaScriptThreading.cpp:
1075         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1076         * DumpRenderTree/mac/ObjCController.m:
1077         * DumpRenderTree/mac/UIDelegate.mm:
1078         * DumpRenderTree/mac/WorkQueueItemMac.mm:
1079
1080 2007-11-25  Adam Roben  <aroben@apple.com>
1081
1082         Fix some test failures caused by r28019
1083
1084         Now that stdout is in binary mode, we need to always use printf
1085         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
1086         the output.
1087
1088         Reviewed by Sam.
1089
1090         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
1091         printf.
1092         (UIDelegate::runJavaScriptAlertPanelWithMessage):
1093         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
1094         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
1095         (UIDelegate::webViewAddMessageToConsole):
1096
1097 2007-11-25  Adam Roben  <aroben@apple.com>
1098
1099         Set the font smoothing preference in DRT
1100
1101         This makes the pixel results on Windows closer to the Mac results.
1102
1103         Reviewed by Mitz.
1104
1105         * DumpRenderTree/win/DumpRenderTree.cpp:
1106         (initializePreferences):
1107
1108 2007-11-25  Adam Roben  <aroben@apple.com>
1109
1110         Port ImageDiff to CG and C++
1111
1112         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
1113         <rdar://5071708>
1114
1115         Reviewed by Sam.
1116
1117         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
1118         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
1119         (main):
1120         (createImageFromStdin):
1121         (compareImages):
1122         (getDifferenceBitmap):
1123         (computePercentageDifferent):
1124         * DumpRenderTree/win/ImageDiff.vcproj: Added.
1125
1126 2007-11-25  Adam Roben  <aroben@apple.com>
1127
1128         Fix image diff link generation on Windows
1129
1130         Reviewed by Sam.
1131
1132         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
1133         to toURL.
1134
1135 2007-11-25  Adam Roben  <aroben@apple.com>
1136
1137         Implement pixel dumping in Windows DRT
1138
1139         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
1140         <rdar://5071708>
1141
1142         Reviewed by Sam.
1143
1144         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
1145         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
1146         Content-Length header.
1147         (getMD5HashStringForBitmap):
1148         (dumpWebViewAsPixelsAndCompareWithExpected):
1149         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
1150         * DumpRenderTree/win/DumpRenderTree.cpp:
1151         (dump): Do a pixel dump if requested.
1152         (main): Parse pixel test options.
1153         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
1154         the cg/ subdirectory to the include path.
1155         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
1156         available in a header or import library, so we have to go through this
1157         LoadLibrary/GetProcAddress dance to use them.
1158         (cryptDLL):
1159         (init):
1160         (update):
1161         (final):
1162         (MD5_Init):
1163         (MD5_Update):
1164         (MD5_Final):
1165         * DumpRenderTree/win/MD5.h: Added.
1166         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
1167         moved up to the top level to share it with Mac eventually.
1168         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
1169         (getBitmapContextFromWebView): Forces the WebView to paint using a
1170         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
1171
1172 2007-11-25  Adam Roben  <aroben@apple.com>
1173
1174         Clean up Windows DRT's option parsing a little bit
1175
1176         Reviewed by Sam.
1177
1178         * DumpRenderTree/win/DumpRenderTree.cpp:
1179         (main): Put non-option arguments into a Vector.
1180
1181 2007-11-25  Adam Roben  <aroben@apple.com>
1182
1183         Make Windows DRT stop changing LF into CRLF
1184
1185         Reviewed by Sam.
1186
1187         * DumpRenderTree/win/DumpRenderTree.cpp:
1188         (main): Put stdout in binary mode.
1189         * Scripts/run-webkit-tests: Remove the CRLF hack.
1190
1191 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
1192
1193         Removed empty directory.
1194
1195         * Scripts/resources: Removed.
1196
1197 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
1198
1199         Fix bisect-builds to work with recent WebKit nightly builds.
1200
1201         Reviewed by Dan.
1202
1203         * Scripts/bisect-builds: Check for the 
1204         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
1205         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
1206         to WebKit.app/Contents/Resources.
1207
1208 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
1209
1210         Reviewed by Maciej.
1211
1212         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
1213         not closed (affects digg.com)
1214
1215         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
1216         one after finishing with a test to avoid having its delayed onload handler firing when
1217         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
1218         but it helps somewhat.
1219
1220 2007-11-22  Mark Rowe  <mrowe@apple.com>
1221
1222         Reviewed by Alp Toker.
1223
1224         Fix build-webkit to propagate make's exit status if it fails.
1225
1226         * Scripts/webkitdirs.pm:
1227
1228 2007-11-22  Dan Bernstein  <mitz@apple.com>
1229
1230         Reviewed by Mark Rowe.
1231
1232         - fix crash when running pixel tests
1233
1234         * DumpRenderTree/mac/DumpRenderTree.mm:
1235         (dumpRenderTree): Parse the command line options before setting up the
1236         environment so that we know if we need to set up the pixel dump
1237         machinery.
1238
1239 2007-11-21  Eric Seidel  <eric@webkit.org>
1240
1241         Speculative build fix for Tiger.
1242
1243         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
1244
1245 2007-11-21  Eric Seidel  <eric@webkit.org>
1246
1247         Reviewed by Tim Hatcher.
1248
1249         Break out more of DumpRenderTree.mm into individual files
1250
1251         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1252         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
1253         (checkedMalloc):
1254         (checkedRealloc):
1255         (makeLargeMallocFailSilently):
1256         * DumpRenderTree/mac/CheckedMalloc.h: Added.
1257         * DumpRenderTree/mac/DumpRenderTree.mm:
1258         (crashHandler):
1259         (dump):
1260         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1261         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
1262         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
1263         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1264         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1265         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
1266         (javaScriptThreads):
1267         (runJavaScriptThread):
1268         (startJavaScriptThreads):
1269         (stopJavaScriptThreads):
1270         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
1271         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
1272         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
1273         (restoreColorSpace):
1274         (setDefaultColorProfileToRGB):
1275         (initializeColorSpaceAndScreeBufferForPixelTests):
1276         (md5HashStringForBitmap):
1277         (dumpWebViewAsPixelsAndCompareWithExpected):
1278
1279 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
1280
1281         Move install-unix-extras to wx directory as it seems only to be used by that 
1282         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
1283         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
1284         have install-unix-extras install into WebKitLibraries as per
1285         convention.
1286         
1287         Reviewed by Mark Rowe.
1288
1289         * Scripts/install-unix-extras: Removed.
1290         * wx/build-wxwebkit:
1291         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
1292
1293 2007-11-21  Eric Seidel  <eric@webkit.org>
1294
1295         Reviewed by Adam.
1296
1297         More refactoring for greater code readability
1298
1299         * DumpRenderTree/mac/DumpRenderTree.mm:
1300         (initializeGlobalsFromCommandLineOptions):
1301         (initializeColorSpaceAndScreeBufferForPixelTests):
1302         (addTestPluginsToPluginSearchPath):
1303         (useLongRunningServerMode):
1304         (runTestingServerLoop):
1305         (prepareConsistentTestingEnvironment):
1306         (dumpRenderTree):
1307         (main):
1308         (dumpFramesAsText):
1309         (dumpBackForwardListForWebView):
1310         (sizeWebViewForCurrentTest):
1311         (methodNameStringForFailedTest):
1312         (dumpBackForwardListForAllWindows):
1313         (dumpWebViewAsPixelsAndCompareWithExpected):
1314         (invalidateAnyPreviousWaitToDumpWatchdog):
1315         (dump):
1316         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1317         * DumpRenderTree/mac/UIDelegate.mm:
1318         (-[UIDelegate webView:createWebViewWithRequest:]):
1319
1320 2007-11-21  Eric Seidel  <eric@webkit.org>
1321
1322         Reviewed by Tim Hatcher.
1323
1324         Abstract more of DRT into static methods
1325
1326         * DumpRenderTree/mac/DumpRenderTree.mm:
1327         (setDefaultsToConsistentValuesForTesting):
1328         (setupSignalHandlers):
1329         (allocateGlobalControllers):
1330         (releaseAndZero):
1331         (releaseGlobalControllers):
1332         (dumpRenderTree):
1333         (shouldLogFrameLoadDelegates):
1334         (createCFURLFromPathOrURL):
1335         (resetWebViewToConsistentStateBeforeTesting):
1336         (runTest):
1337
1338 2007-11-21  Eric Seidel  <eric@webkit.org>
1339
1340         Reviewed by Tim Hatcher.
1341
1342         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
1343
1344         * DumpRenderTree/DumpRenderTree.h:
1345         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1346         * DumpRenderTree/mac/DumpRenderTree.mm:
1347         (dumpRenderTree):
1348         (dump):
1349         (runTest):
1350         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
1351         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
1352         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
1353         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
1354         (-[DumpRenderTreePasteboard declareType:owner:]):
1355         (+[LocalPasteboard alloc]):
1356         (-[LocalPasteboard init]):
1357         (-[LocalPasteboard dealloc]):
1358         (-[LocalPasteboard name]):
1359         (-[LocalPasteboard releaseGlobally]):
1360         (-[LocalPasteboard declareTypes:owner:]):
1361         (-[LocalPasteboard addTypes:owner:]):
1362         (-[LocalPasteboard changeCount]):
1363         (-[LocalPasteboard types]):
1364         (-[LocalPasteboard availableTypeFromArray:]):
1365         (-[LocalPasteboard setData:forType:]):
1366         (-[LocalPasteboard dataForType:]):
1367         (-[LocalPasteboard setPropertyList:forType:]):
1368         (-[LocalPasteboard setString:forType:]):
1369         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
1370         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
1371         (+[DumpRenderTreeWindow allWindows]):
1372         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
1373         (-[DumpRenderTreeWindow dealloc]):
1374         (-[DumpRenderTreeWindow isKeyWindow]):
1375         (-[DumpRenderTreeWindow keyDown:]):
1376
1377 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
1378
1379         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
1380         it indiscriminately copies any headers inside JavaScriptCore,
1381         which includes Tiger ICU headers. 
1382
1383         * wx/build-wxwebkit:
1384         Don't run WebCore/move-js-headers.sh any longer.
1385
1386 2007-11-20  Adam Treat  <treat@kde.org>
1387
1388         Reviewed by David Kilzer.
1389
1390         * Prepend git branch name to $baseProductDir
1391
1392         * Scripts/VCSUtils.pm:
1393         * Scripts/webkitdirs.pm:
1394
1395 2007-11-20  Mark Rowe  <mrowe@apple.com>
1396
1397         Reviewed by Simon Hausmann.
1398
1399         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
1400         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
1401         Have it trigger a "make distclean" rather than "make clean" to ensure that the
1402         built product and generated Makefile's are removed.
1403
1404 2007-11-19  Alp Toker  <alp@atoker.com>
1405
1406         Reviewed by Mark Rowe.
1407
1408         http://bugs.webkit.org/show_bug.cgi?id=16040
1409         [GTK] GtkLauncher should be written in C
1410
1411         Port GtkLauncher to plain C.
1412
1413         Use a more conventional GTK+ coding style.
1414
1415         Use a toolbar instead of menus.
1416
1417         Various signature fixes and cleanups.
1418
1419         Add a license header. Assume all previous modifications were copyright
1420         assigned to Apple Inc. by default.
1421
1422         * GtkLauncher/GtkLauncher.pro:
1423         * GtkLauncher/main.c: Added.
1424         (activate_url_entry_cb):
1425         (update_title):
1426         (link_hover_cb):
1427         (title_change_cb):
1428         (progress_change_cb):
1429         (destroy_cb):
1430         (go_back_cb):
1431         (go_forward_cb):
1432         (create_browser):
1433         (create_statusbar):
1434         (create_toolbar):
1435         (create_window):
1436         (main):
1437         * GtkLauncher/main.cpp: Removed.
1438
1439 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
1440
1441         Build script fixes to ensure they do the right thing for the 
1442         wx port, and update build-wxwebkit to reflect the way the
1443         build scripts now work.
1444
1445         Reviewed by Adam.
1446
1447         * Scripts/build-testkjs:
1448         * Scripts/build-webkit:
1449         * Scripts/run-javascriptcore-tests:
1450         * Scripts/webkitdirs.pm:
1451         * wx/build-wxwebkit:
1452
1453 2007-11-18  Eric Seidel  <eric@webkit.org>
1454
1455         Reviewed by Anders.
1456
1457         Make run-javascriptcore-tests report failures on exit (to support git bisect)
1458
1459         * Scripts/run-javascriptcore-tests:
1460
1461 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
1462
1463         Reviewed by Adam Roben.
1464
1465         Make run-webkit-tests work with Windows debug build.
1466
1467         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
1468         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
1469         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
1470         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
1471         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
1472
1473 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
1474
1475         Add wxWebKit sample and build script, and integrate it with 
1476         build-webkit. Also make build-webkit --clean work for all
1477         ports.
1478
1479         Reviewed by Darin Adler.
1480
1481         * Scripts/build-webkit:
1482         * Scripts/webkitdirs.pm:
1483         * wx: Added.
1484         * wx/browser: Added.
1485         * wx/browser/browser.bkl: Added.
1486         * wx/browser/browser.cpp: Added.
1487         * wx/build-wxwebkit: Added.
1488
1489 2007-11-17  Adam Roben  <aroben@apple.com>
1490
1491         Make it easy to run Safari in the debugger on Windows
1492
1493         I've added a new script, debug-safari, which launches Safari in the
1494         debugger. On OS X it just calls gdb-safari.
1495
1496         Reviewed by Mark Rowe.
1497
1498         * FindSafari/FindSafari.cpp:
1499         (_tmain): Added a /debugger flag, which in combination with
1500         /printSafariLauncher will print a script that launches Safari in the
1501         debugger.
1502         * Scripts/debug-safari: Added.
1503         * Scripts/run-safari: Changed to call runSafari().
1504         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
1505         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
1506         first argument along to FindSafari.
1507         * Scripts/webkitdirs.pm:
1508         (sub runSafari): Added.
1509
1510 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
1511
1512         Reviewed by Adam Roben.
1513
1514         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
1515
1516 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
1517
1518         Reviewed by David Kilzer.
1519
1520         The git config command was renamed to repo-config at some point. This
1521         change tries git config and then git repo-config if the first fails.
1522
1523         * Scripts/prepare-ChangeLog:
1524         (gitConfig):
1525
1526 2007-11-16  Dan Bernstein  <mitz@apple.com>
1527
1528         Reviewed by Darin Adler and Sam Weinig.
1529
1530         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
1531
1532         * DumpRenderTree/win/EventSender.cpp:
1533         (keyDownCallback): For characters that cannot be entered on the active
1534         keyboard layout, send a WM_CHAR message with the character along with
1535         a WM_KEYDOWN message with a virtual key code of 255.
1536
1537 2007-11-16  Mark Rowe  <mrowe@apple.com>
1538
1539         Reviewed by Tim Hatcher.
1540
1541         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
1542
1543         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1544         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1545
1546 2007-11-15  Adam Roben  <aroben@apple.com>
1547
1548         Make run-safari actually work on Windows
1549
1550         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
1551         chdir call.
1552
1553 2007-11-14  Adam Roben  <aroben@apple.com>
1554
1555         Updates to Safari launching now that 3.0.4 is released
1556
1557         Reviewed by Sam.
1558
1559         * FindSafari/FindSafari.cpp:
1560         (getWebViewCLSID): Use version-independent ProgID.
1561         * Scripts/run-safari: Use run-webkit-nightly.cmd.
1562
1563 2007-11-14  Anders Carlsson  <andersca@apple.com>
1564
1565         Reviewed by Adam.
1566
1567         <rdar://problem/5309081>
1568         In DRT, "plugin.logDestroy = true" not working on Windows.
1569         
1570         * DumpRenderTree/win/TestNetscapePlugin/main.c:
1571         (NPP_Destroy):
1572
1573 2007-11-14  Eric Seidel  <eric@webkit.org>
1574
1575         Reviewed by Sam.
1576
1577         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
1578
1579 2007-11-14  Anders Carlsson  <andersca@apple.com>
1580
1581         Reviewed by Adam.
1582
1583         <rdar://problem/5141186>
1584         window.layoutTestController.setWindowIsKey is not implemented in DRT.
1585         
1586         Implement setWindowIsKey.
1587         
1588         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1589         (LayoutTestController::setWindowIsKey):
1590
1591 2007-11-13  Sam Weinig  <sam@webkit.org>
1592
1593         Reviewed by Adam Roben.
1594
1595         Fix for <rdar://problem/5382579>
1596         http/tests/security/cross-frame-access-put.html reports large 
1597         negative numbers for screenLeft and screenTop (Mac reports "0")
1598
1599         * DumpRenderTree/win/UIDelegate.cpp:
1600         (UIDelegate::UIDelegate): Initialize the RECT.
1601         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
1602         (UIDelegate::webViewFrame): ditto.
1603         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
1604
1605 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
1606
1607         Reviewed by Adam.
1608
1609         - Make Drosera show source, source URLs, and function stack on Windows,
1610         and some minor fixes.
1611
1612         * Drosera/DebuggerDocument.cpp: Force source to always update display.
1613         (DebuggerDocument::updateFileSource):
1614         * Drosera/debugger.js: Force source to always update display.
1615         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
1616         menu controls.
1617         (DebuggerClient::resume):
1618         (DebuggerClient::pause):
1619         (DebuggerClient::stepInto):
1620         (DebuggerClient::stepOver):
1621         (DebuggerClient::stepOut):
1622         (DebuggerClient::showConsole):
1623         (DebuggerClient::closeCurrentFile):
1624         * Drosera/win/DebuggerClient.h: Ditto.
1625         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
1626         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
1627         removed two bugs.  1) caller could be in a bad state when asked to
1628         assign into it. 2) BSTRs were not created correctly.
1629         (DebuggerDocument::getPlatformCurrentFunctionStack):
1630         * Drosera/win/Drosera.cpp: Hook up the menu controls.
1631         (droseraWndProc):
1632         (handleCommand):
1633         (Drosera::resume):
1634         (Drosera::pause):
1635         (Drosera::stepInto):
1636         (Drosera::stepOver):
1637         (Drosera::stepOut):
1638         (Drosera::showConsole):
1639         (Drosera::closeCurrentFile):
1640         * Drosera/win/Drosera.h: Hook up the menu controls.
1641         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
1642         functions, added a null check, and fixed another bug where caller could
1643         be in a bad state when asked to assign into it.
1644         (ServerConnection::didLoadMainResourceForDataSource):
1645         (ServerConnection::getCallerFrame):
1646         * Drosera/win/ServerConnection.h: Safety first.
1647
1648 2007-11-13  Dan Bernstein  <mitz@apple.com>
1649
1650         Reviewed by Darin Adler.
1651
1652         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
1653           DumpRenderTree --pixel-tests renders each test twice
1654
1655         * DumpRenderTree/mac/DumpRenderTree.mm:
1656         (dumpRenderTree): Removed the --paint option because the painting code
1657         is always exercised as a result of
1658         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
1659         calling -displayIfNeeded.
1660         (dump): Changed to always grab the image from the window since the view
1661         is always displayed.
1662         (runTest):
1663         (displayWebView):
1664         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
1665         because it always paints.
1666
1667 2007-11-12  Antti Koivisto  <antti@apple.com>
1668
1669         Reviewed by Adele.
1670         
1671         Add support for http media tests
1672
1673         * Scripts/run-webkit-tests:
1674
1675 2007-11-12  Sam Weinig  <sam@webkit.org>
1676
1677         Reviewed by Adam Roben.
1678
1679         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
1680
1681         * DumpRenderTree/win/DumpRenderTree.cpp:
1682         (runTest):
1683         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1684         (LayoutTestController::setPrivateBrowsingEnabled):
1685
1686 2007-11-12  Adam Roben  <aroben@apple.com>
1687
1688         * Scripts/update-webkit-localizable-strings: Changed to only scan the
1689         mac and win subdirectories.
1690
1691 2007-11-11  Adam Roben  <aroben@apple.com>
1692
1693         Fix <rdar://5133816> keepWebHistory is not implemented
1694
1695         Fixes fast/history/clicked-link-is-visited.html.
1696
1697         Reviewed by Darin.
1698
1699         * DumpRenderTree/win/DumpRenderTree.cpp:
1700         (runTest): Clear the optionalSharedHistory.
1701         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1702         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
1703
1704 2007-11-10  Sam Weinig  <sam@webkit.org>
1705
1706         Reviewed by Tim Hatcher.
1707
1708         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
1709         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
1710         is turned on)
1711
1712         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
1713
1714         Added test: http/tests/security/cross-frame-access-private-browsing.html
1715
1716         * DumpRenderTree/LayoutTestController.cpp:
1717         (setPrivateBrowsingEnabledCallback):
1718         (LayoutTestController::staticFunctions):
1719         * DumpRenderTree/LayoutTestController.h:
1720         * DumpRenderTree/mac/DumpRenderTree.mm:
1721         (runTest): Default to private browsing disabled.
1722         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1723         (LayoutTestController::setPrivateBrowsingEnabled):
1724         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1725         (LayoutTestController::setPrivateBrowsingEnabled):
1726
1727 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1728
1729         Reviewed by Adam.
1730
1731         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
1732         WebCore's!
1733
1734         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
1735         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
1736         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
1737         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
1738         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
1739         * Drosera/win/Drosera.cpp:
1740         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1741
1742 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1743
1744         Reviewed by Sam.
1745
1746         - Use the new IWebFrame [local] function signature and get the shared
1747         server correctly.
1748
1749         * Drosera/win/DebuggerClient.cpp:
1750         (DebuggerClient::didFinishLoadForFrame):
1751         * Drosera/win/ServerConnection.cpp:
1752         (ServerConnection::attemptToCreateServerConnection):
1753
1754 2007-11-07  Dan Bernstein  <mitz@apple.com>
1755
1756         Reviewed by Darin Adler.
1757
1758         - add an option to run-webkit-tests to ignore pixel test failures where
1759           all pixels differ by no more than a specified threshold
1760
1761         * DumpRenderTree/mac/ImageDiff.m:
1762         (main):
1763         (compareImages):
1764         (computePercentageDifferent):
1765         * Scripts/run-webkit-tests:
1766
1767 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1768
1769         Reviewed by Lars.
1770
1771         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
1772
1773         * DumpRenderTree/qt/DumpRenderTree.cpp:
1774
1775 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1776
1777         Reviewed by Lars.
1778
1779         Reworked the QWebSettings API.
1780         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
1781
1782         * DumpRenderTree/qt/DumpRenderTree.cpp:
1783
1784 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1785
1786         Reviewed by Lars.
1787
1788         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
1789
1790         * DumpRenderTree/qt/jsobjects.cpp:
1791
1792 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1793
1794         Reviewed by Lars Knoll <lars@trolltech.com>.
1795
1796         Add a QWebPage::frameCreated() signal and fix DRT
1797         
1798         The removal of createFrame in QWebPage broke the re-implementation
1799         in DumpRenderTree. Instead emit a frameCreated() signal and
1800         connect to it in DumpRenderTree.
1801         
1802
1803         * DumpRenderTree/qt/DumpRenderTree.cpp:
1804         (WebCore::WebPage::WebPage):
1805         (WebCore::DumpRenderTree::dump):
1806         (WebCore::DumpRenderTree::connectFrame):
1807         * DumpRenderTree/qt/DumpRenderTree.h:
1808
1809 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1810
1811         Reviewed by Lars Knoll <lars@trolltech.com>.
1812
1813         Moved all the event handlers from QWebFrame into QWebPage.
1814         
1815         This cleans up the public API and allows us to remove the
1816         HackWebFrame hack in DumpRenderTree.
1817         
1818
1819         * DumpRenderTree/qt/jsobjects.cpp:
1820         (EventSender::mouseDown):
1821         (EventSender::mouseUp):
1822         (EventSender::mouseMoveTo):
1823
1824 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1825
1826         Reviewed by Mark.
1827
1828         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
1829         to prevent the default implementation from popping up messageboxes.
1830
1831         * DumpRenderTree/qt/DumpRenderTree.cpp:
1832         (WebCore::WebPage::javaScriptConfirm):
1833         (WebCore::WebPage::javaScriptPrompt):
1834
1835 2007-11-06  Eric Seidel  <eric@webkit.org>
1836
1837         * Scripts/build-testkjs: build fix... too many $$
1838
1839 2007-11-06  Eric Seidel  <eric@webkit.org>
1840
1841         Reviewed by Mark Rowe.
1842
1843         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
1844
1845 2007-11-05  Adam Roben  <aroben@apple.com>
1846
1847         Add support on Windows for WEBKIT_TESTFONTS
1848
1849         This environment variable lets you specify where the fonts to be used
1850         by DumpRenderTree reside. The Qt port is already using this, so I'm
1851         just following their lead.
1852
1853         Reviewed by Darin.
1854
1855         * DumpRenderTree/win/DumpRenderTree.cpp:
1856         (exePath): Refactored code out of initialize().
1857         (fontsPath): Returns either $WEBKIT_TESTFONTS or
1858         DumpRenderTree.resources.
1859         (initialize): Use the new fontsPath function.
1860         (main): Use the new exePath function.
1861         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
1862         variable to DRT, like Qt does.
1863
1864 2007-11-05  Mark Rowe  <mrowe@apple.com>
1865
1866         Rubber-stamped by Alp Toker.
1867
1868         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
1869
1870         * GtkLauncher/main.cpp:
1871         (goToURLBarText):
1872         (main):
1873
1874 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
1875
1876         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
1877         <http://bugs.webkit.org/show_bug.cgi?id=15830>
1878
1879         Reviewed by Timothy.
1880
1881         Restrict the range of nightly builds used by the bisect-builds script
1882         based on the version of Safari and the version of Mac OS X being used.
1883
1884         Mac OS X 10.4: Safari 2.0: r11976 or newer
1885         Mac OS X 10.4: Safari 3.0: r19992 or newer
1886
1887         Mac OS X 10.5: Safari 2.0: r19594 or newer
1888         Mac OS X 10.5: Safari 3.0: r25124 or newer
1889
1890         * Scripts/bisect-builds:
1891         (findMacOSXVersion): Added.
1892         (makeNightlyList): Added argument to provide version of Mac OS X.
1893         Restrict range of nightly builds based on Safari and Mac OS X versions.
1894
1895 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
1896
1897         Reviewed by Maciej.
1898
1899         - This patch involves several changes, all of them were noticed that
1900         they were needed by the work being done in WebKit to get Drosera and
1901         WebKit working together on Windows.
1902         - The changes are:
1903         1) Added a debugger console for output messages.
1904         2) Drosera now listens for the WebKit server (before, the server would
1905         have to be running before Drosera was started.)
1906         3) Fixed a bug where the WebView started out as 0x0 pixels.
1907         4) Fixed a bug when there is no scope.
1908         5) Added the HTML, JS, and CSS to the project file to make them easy to
1909         find.
1910         6) Made the ServerConnection functions virtual.
1911
1912         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
1913         for the WebKit server.
1914         (DebuggerClient::DebuggerClient):
1915         (DebuggerClient::~DebuggerClient):
1916         (DebuggerClient::didFinishLoadForFrame):
1917         (DebuggerClient::serverConnected):
1918         (DebuggerClient::attemptToCreateServerConnection):
1919         * Drosera/win/DebuggerClient.h: Ditto.
1920         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
1921         scope.
1922         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1923         (DebuggerDocument::platformValueForScopeVariableNamed):
1924         * Drosera/win/Drosera.cpp:
1925         (_tWinMain): Added a console in debug for output messages.
1926         (Drosera::Drosera): Listen for server.
1927         (Drosera::initUI): The server now Initializes COM.
1928         (Drosera::serverConnected): Part of the listening for the server.
1929         (Drosera::attemptToCreateServerConnection): Ditto.
1930         * Drosera/win/Drosera.h: New interface for listening for the server.
1931         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
1932         files to the VS project.
1933         * Drosera/win/ServerConnection.cpp: Part of listening for the server
1934         connection.
1935         (ServerConnection::ServerConnection):
1936         (ServerConnection::attemptToCreateServerConnection):
1937         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
1938         methods.
1939         (ServerConnection::serverConnected):
1940
1941 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
1942
1943         Reviewed by Maciej.
1944
1945         http://bugs.webkit.org/show_bug.cgi?id=15832
1946         fast/dom/gc-10.html crashes when run alone
1947
1948         Check for !done before using objects that can be already deallocated.
1949
1950         * DumpRenderTree/mac/EditingDelegate.mm:
1951         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
1952         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
1953         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
1954         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
1955         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
1956         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
1957         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
1958         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
1959         (-[EditingDelegate webViewDidBeginEditing:]):
1960         (-[EditingDelegate webViewDidChange:]):
1961         (-[EditingDelegate webViewDidEndEditing:]):
1962         (-[EditingDelegate webViewDidChangeTypingStyle:]):
1963         (-[EditingDelegate webViewDidChangeSelection:]):
1964         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1965         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1966         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
1967         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1968         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
1969         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
1970         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
1971         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
1972         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
1973         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
1974         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
1975         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
1976         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
1977         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
1978         (-[FrameLoadDelegate webView:willCloseFrame:]):
1979         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
1980         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
1981         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1982         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1983         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1984         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
1985         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
1986         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
1987         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
1988
1989 2007-11-04  Mark Rowe  <mrowe@apple.com>
1990
1991         Build fix.  Don't use Carbon.h as the prefix header as it triggers
1992         warnings that would otherwise be suppressed due to it being a system header.
1993
1994         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1995
1996 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
1997
1998         Rubber stamped by Adam.
1999         
2000         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
2001
2002         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2003
2004 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2005
2006         Sort files(...); sections of Xcode project files.
2007
2008         Rubber-stamped by Darin.
2009
2010         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
2011         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2012         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2013         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2014
2015 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2016
2017         Script to sort "files(...);" sections in Xcode project.pbxproj files.
2018
2019         Reviewed by Darin.
2020
2021         * Scripts/sort-Xcode-project-file: Added.
2022
2023 2007-11-02  Darin Adler  <darin@apple.com>
2024
2025         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
2026
2027 2007-11-02  Darin Adler  <darin@apple.com>
2028
2029         Reviewed by Maciej.
2030
2031         * Scripts/run-sunspider: Pass the "--base" option through.
2032
2033         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
2034         the real script do that. Default configuration to Release to match run-sunspider
2035         so we don't end up building Debug just to compare results.
2036
2037 2007-11-01  Adam Roben  <aroben@apple.com>
2038
2039         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
2040
2041         Reviewed by Sam.
2042
2043         * Scripts/commit-log-editor: Show all the directories beneath the
2044         source root, instead of just the last one.
2045
2046 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
2047
2048         Reviewed by Adam Roben.
2049
2050         Print out an error message when the Windows build fails
2051         and provide guidance on how to find out what went wrong.
2052
2053         * Scripts/build-webkit:
2054         * Scripts/webkitdirs.pm:
2055
2056 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
2057
2058         Rubber-stamped by Adam Roben.
2059
2060         Rolled out r27326 - debug CRT seems to cause no problems after all.
2061
2062         * DumpRenderTree/win/DumpRenderTree.vcproj:
2063
2064 2007-10-31  Adam Roben  <aroben@apple.com>
2065
2066         Switch the Debug configuration to using the non-debug CRT
2067
2068         This matches WebKit.
2069
2070         Reviewed by Steve.
2071
2072         * DumpRenderTree/win/DumpRenderTree.vcproj:
2073
2074 2007-10-31  Antti Koivisto  <antti@apple.com>
2075
2076         Reviewed by bdash.
2077         
2078         Disable media tests when doing leak checking on Tiger.
2079         They crash in QuickTime (rdar://problem/5537157).
2080
2081         * Scripts/run-webkit-tests:
2082
2083 2007-10-29  Antti Koivisto  <antti@apple.com>
2084
2085         Reviewed by Maciej.
2086         
2087         Build media support by default on OSX only.
2088
2089         * Scripts/build-webkit:
2090
2091 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2092
2093         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
2094         get caught by the pre-commit hooks.
2095
2096 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2097
2098         Reviewed by Adam.
2099
2100         - This is a collection of relatively unrelated changes and cleanups
2101         to Drosera to prepare it for interacting with WebKit.  A lot of these
2102         changes are just correcting mistakes, for example removing included
2103         headers that are no longer needed.
2104
2105         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
2106         this will be needed by the DebuggerClient.
2107         (DebuggerDocument::server):
2108         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
2109         * Drosera/win/DebuggerClient.cpp: 
2110         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
2111         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
2112         (DebuggerClient::createWebViewWithRequest): Added comment about its
2113         purpose. 
2114         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
2115         declarations.
2116         (DebuggerClient::webViewLoaded): Moved.
2117         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
2118         file, since this was the only place it was used.
2119         (cfStringToBSTR):
2120         * Drosera/win/Drosera.h: Cleaned up the includes.
2121         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
2122         * Drosera/win/HelperFunctions.h: Removed.
2123
2124 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2125
2126         Reviewed by Adam.
2127
2128         - Small cleanup in the ServerConnection class.
2129
2130         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
2131         and added an include.
2132         (ServerConnection::currentFrame):
2133         (ServerConnection::getCallerFrame):
2134         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
2135         made a pointer into a COMPtr, and cleaned up the includes.
2136
2137 2007-10-29  Timothy Hatcher  <timothy@apple.com>
2138
2139         Reviewed by John Sullivan.
2140         
2141         - Place the Localizable.strings file in mac or win directories
2142           if that location exists.
2143         - Also look for UI_STRING in .c files.
2144
2145         * Scripts/extract-localizable-strings:
2146
2147 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2148
2149         Reviewed by Adam.
2150
2151         - Set the eol-style to native and made all the line endings the same
2152         so that I avoid messy diffs that show eol changes.
2153
2154         * Drosera/win/ServerConnection.cpp:
2155         (ServerConnection::didParseSource):
2156         (ServerConnection::didEnterCallFrame):
2157         (ServerConnection::willExecuteStatement):
2158         (ServerConnection::willLeaveCallFrame):
2159         (ServerConnection::exceptionWasRaised):
2160
2161 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2162
2163         Reviewed by Adam.
2164
2165         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
2166         functionality that could not have existed previously without the new
2167         interfaces.
2168         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
2169         from a BSTR to a JSValueRef.
2170         (DebuggerDocument::platformEvaluateScript): Implemented.
2171         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
2172         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2173         Implemented.
2174         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
2175         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
2176         * Drosera/win/ServerConnection.cpp: Added a helper function.
2177         (ServerConnection::getCallerFrame):
2178         * Drosera/win/ServerConnection.h: Added a helper function.
2179
2180 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
2181
2182         updated reviewers for my previous changelog.
2183
2184 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
2185         Reviewed by Maciej and Adam and Geoff.
2186
2187         - Minor mac-side improvements including moving a function to a more
2188         appropriate location, fixing a warning, and correctly checking
2189         exceptions.
2190
2191         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
2192         (DebuggerDocument::willExecuteStatement):
2193         (DebuggerDocument::didEnterCallFrame):
2194         (DebuggerDocument::willLeaveCallFrame):
2195         (DebuggerDocument::windowScriptObjectAvailable):
2196         (DebuggerDocument::callFunctionOnObject):
2197         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
2198         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
2199         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
2200         because it doesn't require the ServerConnection at all.
2201         (NSStringCreateWithJSStringRef): Made an argument const.
2202         (JSValueRefCreateWithNSString): Made an argument const.
2203         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
2204         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2205         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
2206         * Drosera/mac/ServerConnection.mm: Ditto.
2207         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
2208
2209 2007-10-29  Sam Weinig  <sam@webkit.org>
2210
2211         Reviewed by Adam Roben.
2212
2213         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
2214
2215         * DumpRenderTree/LayoutTestController.cpp:
2216         (LayoutTestController::LayoutTestController):
2217         (getGlobalFlagCallback):
2218         (setGlobalFlagCallback):
2219         (LayoutTestController::getJSClass):
2220         (LayoutTestController::staticValues):
2221         * DumpRenderTree/LayoutTestController.h:
2222         (LayoutTestController::globalFlag):
2223         (LayoutTestController::setGlobalFlag):
2224
2225 2007-10-29  Darin Adler  <darin@apple.com>
2226
2227         Reviewed by Maciej.
2228
2229         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
2230         resolution instead of its default.
2231
2232 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
2233
2234         Fixed showStatus() to print status for successfully resolved conflicts when using git.
2235
2236         Reviewed by Mark Rowe.
2237
2238         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
2239         was successfully resolved, but this would not show any status because the change had
2240         already been cached in the index using "git add".  The solution is to add an optional
2241         second argument to showStatus() which adds the "--cached" switch to the command.
2242
2243         * Scripts/resolve-ChangeLogs:
2244         (showStatus):
2245
2246 2007-10-28  Eric Seidel  <eric@webkit.org>
2247
2248         Reviewed by Maciej and Geoff, in unison.
2249
2250         * Scripts/run-webkit-tests: remove broken --svg option
2251
2252 2007-10-28  Darin Adler  <darin@apple.com>
2253
2254         Reviewed by Adam.
2255
2256         * Scripts/run-sunspider: Default to "Release" configuration rather than
2257         defaulting to the last configuration used as other scripts do. This can
2258         still be overriden on the command line with "--debug" if there's some
2259         reason to do so. Also fix a typo.
2260
2261         * Scripts/sunspider-compare-results: Fix a typo.
2262
2263 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
2264
2265         Reviewed by Adam.
2266
2267         - Implemented the WebScriptDebugListener functions now that the
2268         WebScriptDebugServer exists
2269
2270         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
2271         functions.
2272         (ServerConnection::currentFrame):
2273         (ServerConnection::didLoadMainResourceForDataSource):
2274         (ServerConnection::didParseSource):
2275         (ServerConnection::failedToParseSource):
2276         (ServerConnection::didEnterCallFrame):
2277         (ServerConnection::willExecuteStatement):
2278         (ServerConnection::willLeaveCallFrame):
2279         (ServerConnection::exceptionWasRaised):
2280         * Drosera/win/ServerConnection.h: Removed unused arguments from the
2281         members arguments list.
2282
2283 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
2284
2285         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
2286         <http://bugs.webkit.org/show_bug.cgi?id=15600>
2287
2288         Reviewed by Darin.
2289
2290         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
2291         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
2292         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
2293         file.  Note that it may also be used as a stand-alone script.
2294
2295         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
2296         * Scripts/resolve-ChangeLogs: Added.
2297         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
2298
2299 2007-10-26  Mark Rowe  <mrowe@apple.com>
2300
2301         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
2302         to the Qt port on the assumption that it was an implementation of the cross-platform
2303         LayoutTestController class.  It is not, so it did not need to be changed.
2304
2305         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
2306
2307 2007-10-25  Mark Rowe  <mrowe@apple.com>
2308
2309         Reviewed by Maciej.
2310
2311         Fix builds with code coverage enabled.
2312
2313         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
2314
2315 2007-10-25  Darin Adler  <darin@apple.com>
2316
2317         Reviewed by Mark Rowe.
2318
2319         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
2320         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
2321
2322 2007-10-25  Stephanie  <slewis@apple.com>
2323
2324         build Fix
2325
2326         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2327
2328 2007-10-25  Stephanie  <slewis@apple.com>
2329
2330         Reviewed by Mark Rowe, Adam Roben.
2331
2332         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
2333
2334         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
2335
2336 2007-10-25  Alice Liu  <alice.liu@apple.com>
2337
2338         Reviewed by Adam.
2339
2340         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
2341
2342         Moving destructor into platform-specific files
2343         * DumpRenderTree/LayoutTestController.cpp:
2344         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2345         (LayoutTestController::~LayoutTestController):
2346         * DumpRenderTree/qt/jsobjects.cpp:
2347         (LayoutTestController::~LayoutTestController):
2348
2349         LayoutTestController wasn't being destroyed
2350         * DumpRenderTree/win/DumpRenderTree.cpp:
2351         (runTest):
2352
2353         Added declspec
2354         * DumpRenderTree/win/EditingDelegate.h:
2355
2356         Reset certain values on the webview (or related delegate) that might 
2357         have changed while running a test
2358         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2359         (LayoutTestController::~LayoutTestController):
2360
2361 2007-10-25  Adam Roben  <aroben@apple.com>
2362
2363         Make sunspider-compare-results work with relative paths
2364
2365         Reviewed by Sam.
2366
2367         * Scripts/sunspider-compare-results: Convert arguments to absolute
2368         paths before we chdir.
2369
2370 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
2371
2372         Reviewed by Sam.
2373
2374         - Implemented server calls now the WebScriptDebugServer exists.
2375         - Also removed no longer needed call to initialize CG.
2376
2377         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
2378         automatically now.
2379         (_tWinMain):
2380         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
2381         (ServerConnection::ServerConnection):
2382         (ServerConnection::~ServerConnection):
2383         (ServerConnection::pause):
2384         (ServerConnection::resume):
2385         (ServerConnection::stepInto):
2386         (ServerConnection::applicationTerminating):
2387         (ServerConnection::serverConnectionDidDie):
2388         * Drosera/win/ServerConnection.h: Now uses the COM class.
2389
2390 2007-10-24  George Staikos  <staikos@kde.org>
2391
2392         Unbreak Qt build.
2393
2394         * Scripts/build-webkit:
2395
2396 2007-10-24  Adam Roben  <aroben@apple.com>
2397
2398         Remove now-unnecessary call to InitializeCoreGraphics
2399
2400         WebKit takes care of this now.
2401
2402         Reviewed by Ada.
2403
2404         * DumpRenderTree/win/DumpRenderTree.cpp:
2405         (initialize):
2406
2407 2007-10-24  Adam Roben  <aroben@apple.com>
2408
2409         Use WebTextRenderer in DRT
2410
2411         Reviewed by Ada.
2412
2413         * DumpRenderTree/win/DumpRenderTree.cpp:
2414         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
2415
2416 2007-10-24  Sven Herzberg  <sven@imendio.com>
2417
2418         Reviewed by Mark Rowe.
2419
2420         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
2421         Bug 15614: [GTK] qmake based backends don't build on OS X
2422
2423         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
2424         GTK backend on a Mac
2425         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
2426         isDarwin() to make it reusable in other places (like the workaround-
2427         for-prebuilt-qmake in build-webkit)
2428
2429 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2430
2431         Refurbish update-webkit script.
2432
2433         Reviewed by Adam.
2434
2435         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
2436         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
2437         multi-argument version of system() for flexibility and security.  Check for existence
2438         of Internal directory using -d test instead of -x.
2439
2440 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2441
2442         Minor clean-up of prepare-ChangeLog script.
2443
2444         Reviewed by Adam.
2445
2446         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
2447         of a string.  Use multi-argument versions of open() and system() for flexibility and
2448         security.
2449
2450 2007-10-24  Alice Liu  <alice.liu@apple.com>
2451
2452         Reviewed by Oliver.
2453
2454         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
2455
2456         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
2457         replay the saved events when we're still processing the mousedown that starts the drag
2458         * DumpRenderTree/win/EventSender.cpp:
2459         (doMouseMove):
2460         * DumpRenderTree/win/UIDelegate.cpp:
2461         (UIDelegate::doDragDrop):
2462
2463 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
2464
2465         Reviewed by Sam, Steve and Darin.
2466
2467         - Stubbed out the WebScriptDebugListener functionality in the Server
2468         Connection class to prepare it for receiving those callbacks.
2469         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
2470         and the ServerConnection to not need to be initialized with a server
2471         name, since that is not the way we connect to the WebKit server. 
2472
2473         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
2474         no exception.  Now it only loggs when there is an exception
2475         (DebuggerDocument::willExecuteStatement):
2476         (DebuggerDocument::didEnterCallFrame):
2477         (DebuggerDocument::willLeaveCallFrame):
2478         (DebuggerDocument::windowScriptObjectAvailable):
2479         (DebuggerDocument::callFunctionOnObject):
2480         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
2481         to be instantiated with a server's name.
2482         (DebuggerClient::DebuggerClient):
2483         (DebuggerClient::didFinishLoadForFrame):
2484         * Drosera/win/DebuggerClient.h: Removed unsued variable.
2485         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
2486         a server name.
2487         (Drosera::init):
2488         (Drosera::initServer):
2489         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
2490         instantiated with a server's name.
2491         * Drosera/win/ServerConnection.cpp: 
2492         (ServerConnection::ServerConnection): No longer needs a server name
2493         (ServerConnection::~ServerConnection): Only release the global context
2494         if there is one.
2495         (ServerConnection::serverConnectionDidDie): Stub for
2496         IWebScriptDebugListener
2497         (ServerConnection::QueryInterface): ditto
2498         (ServerConnection::AddRef): ditto
2499         (ServerConnection::Release): ditto
2500         (ServerConnection::didLoadMainResourceForDataSource): ditto
2501         (ServerConnection::didParseSource): ditto
2502         (ServerConnection::failedToParseSource): ditto
2503         (ServerConnection::didEnterCallFrame): ditto
2504         (ServerConnection::willExecuteStatement): ditto
2505         (ServerConnection::willLeaveCallFrame): ditto
2506         (ServerConnection::exceptionWasRaised): ditto
2507         * Drosera/win/ServerConnection.h: Stubbed out the
2508         IWebScriptDebugListener functions, and this class no longer needs to be
2509         instantiated with a server name.
2510
2511 2007-10-24  Lars Knoll  <lars@trolltech.com>
2512
2513         Reviewed by Simon.
2514
2515         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
2516
2517         * DumpRenderTree/qt/jsobjects.h:
2518
2519 2007-10-24  Lars Knoll  <lars@trolltech.com>
2520
2521         Reviewed by Simon.
2522
2523         add another command.
2524
2525         * DumpRenderTree/qt/jsobjects.cpp:
2526         (TextInputController::doCommand):
2527
2528 2007-10-24  Lars Knoll  <lars@trolltech.com>
2529
2530         Reviewed by Simon.
2531
2532         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
2533
2534         * DumpRenderTree/qt/jsobjects.cpp:
2535         (EventSender::keyDown):
2536         * DumpRenderTree/qt/jsobjects.h:
2537
2538 2007-10-24  Lars Knoll  <lars@trolltech.com>
2539
2540         Reviewed by Simon.
2541
2542         implement eventSender.keyDown().
2543
2544         * DumpRenderTree/qt/jsobjects.cpp:
2545         (EventSender::keyDown):
2546
2547 2007-10-24  Lars Knoll  <lars@trolltech.com>
2548
2549         Reviewed by Simon.
2550
2551         some smaller fixes to the editing support in DRT. Makes another few tests pass.
2552
2553         * DumpRenderTree/qt/DumpRenderTree.cpp:
2554         (WebCore::DumpRenderTree::DumpRenderTree):
2555         (WebCore::DumpRenderTree::initJSObjects):
2556         * DumpRenderTree/qt/jsobjects.cpp:
2557         (TextInputController::doCommand):
2558
2559 2007-10-24  Lars Knoll  <lars@trolltech.com>
2560
2561         Reviewed by Simon.
2562
2563         first bit of implementation for the textinputcontroller.
2564
2565         * DumpRenderTree/qt/DumpRenderTree.cpp:
2566         (WebCore::DumpRenderTree::DumpRenderTree):
2567         * DumpRenderTree/qt/DumpRenderTree.h:
2568         * DumpRenderTree/qt/jsobjects.cpp:
2569         (TextInputController::TextInputController):
2570         (TextInputController::doCommand):
2571         * DumpRenderTree/qt/jsobjects.h:
2572
2573 2007-10-24  Lars Knoll  <lars@trolltech.com>
2574
2575         Reviewed by Simon.
2576
2577         make the man webpage believe it has focus, so the editing tests work correctly.
2578
2579         * DumpRenderTree/qt/DumpRenderTree.cpp:
2580         (WebCore::DumpRenderTree::DumpRenderTree):
2581
2582 2007-10-24  Lars Knoll  <lars@trolltech.com>
2583
2584         Reviewed by Simon.
2585
2586         implement layoutTestController.dumpEditingCallbacks() correctly.
2587
2588         * DumpRenderTree/qt/DumpRenderTree.cpp:
2589         (WebCore::DumpRenderTree::DumpRenderTree):
2590         * DumpRenderTree/qt/jsobjects.cpp:
2591         (LayoutTestController::reset):
2592         (LayoutTestController::dumpEditingCallbacks):
2593
2594 2007-10-24  Lars Knoll  <lars@trolltech.com>
2595
2596         Reviewed by Simon.
2597
2598         Implement support for testing editing.
2599
2600         * DumpRenderTree/qt/DumpRenderTree.cpp:
2601         (WebCore::DumpRenderTree::DumpRenderTree):
2602
2603 2007-10-23  Sam Weinig  <sam@webkit.org>
2604
2605         Check for null BSTR that can be passed to the UIDelegate methods
2606         from javascript null and undefined.  Fixes a failing test case on
2607         Windows (fast/dom/Window/alert-undefined.html)
2608
2609         Reviewed by Eric Seidel.
2610
2611         * DumpRenderTree/win/UIDelegate.cpp:
2612         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2613         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2614         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2615         (UIDelegate::webViewAddMessageToConsole):
2616
2617 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2618
2619         Reviewed by Darin.
2620         
2621         Don't print a massive pile of setenvs from tools that automatically build testkjs.
2622
2623         * Scripts/build-testkjs:
2624
2625 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2626
2627         Reviewed by Darin.
2628
2629         - add wrapper that finds the right copy of testkjs
2630         
2631         * Scripts/sunspider-compare-results: Added.
2632
2633 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
2634
2635         Reviewed by Sam.
2636
2637         - After talking with Steve I now see that the WebKit server must be
2638         running for DCOM to create the distributed objects, which makes sense
2639         and currently WebKit only allows one instance to be running at a time
2640         which avoids accidentally connecting to the wrong server
2641         - In light of this I have removed the code for the attach box and
2642         NotificationServer and known server names, since they are all extranious
2643         now.
2644
2645         * Drosera/win/Drosera.cpp: Removed notification classes and known server
2646         names.
2647         (_tWinMain): Uses init instead of initUI.
2648         (droseraWndProc): No longer creats an attach dialog box.
2649         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
2650         it's not manditory to call init before doing COM stuff.
2651         (Drosera::init): calls initUI and will call attach when the
2652         functionality exists. 
2653         (Drosera::initUI): Has changed very little.
2654         (Drosera::attach): Changed the signature to reflect that we no longer
2655         need the dictionary of known server names.
2656         * Drosera/win/Drosera.h: Removed notification classes and known server
2657         names.  Also renamed and moved some functions.
2658         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
2659         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
2660         headers to the resources folder. 
2661         * Drosera/win/resource.h: Removed the Attach box.
2662
2663 2007-10-22  Adam Roben  <aroben@apple.com>
2664
2665         Windows build fix
2666
2667         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
2668
2669 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
2670
2671         - Removed a leak that was fixed.
2672
2673         * Scripts/run-webkit-tests:
2674
2675 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2676
2677         Reviewed by Darin.
2678
2679         - Changed the Client so that the DebuggerDocument now own the
2680         ServerConnection.  This simplifies ownership and cleanup. 
2681
2682         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
2683         ServerConnection.
2684         (DebuggerClient::initWithServerName):
2685         (DebuggerClient::didFinishLoadForFrame):
2686         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
2687         ServerConnection.
2688         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
2689         until after we have a server which we are attached to.
2690         (Drosera::initUI):
2691         (Drosera::attach):
2692         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
2693         out previously.
2694
2695 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2696
2697         Reviewed by Nikolas.
2698
2699         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
2700
2701         * Scripts/run-javascriptcore-tests:
2702
2703 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2704
2705         Reviewed by Nikolas.
2706
2707         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
2708
2709         * Scripts/build-drosera:
2710         * Scripts/build-dumprendertree:
2711         * Scripts/build-testkjs:
2712         * Scripts/build-webkit:
2713         * Scripts/run-javascriptcore-tests:
2714         * Scripts/run-sunspider:
2715         * Scripts/run-webkit-tests:
2716         * Scripts/webkitdirs.pm:
2717
2718 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
2719
2720         Reviewed by Mark Rowe.
2721         
2722         Fix for local database support after r26879
2723         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
2724
2725         * Scripts/build-webkit:
2726
2727 2007-10-22  Holger Freyther  <zecke@selfish.org>
2728
2729         Reviewed by Simon Hausmann <hausmann@kde.org>.
2730
2731         - Do not build testkjs as an application bundle. This is
2732         needed for run-javascriptcore-tests on OSX.
2733         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
2734         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
2735         as we do not have -rpath on OSX.
2736
2737         * DumpRenderTree/qt/DumpRenderTree.pro:
2738         * Scripts/run-webkit-tests:
2739
2740 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2741
2742         Reviewed by aroben.
2743
2744         Fix support for Signed-off-by detection in prepare-ChangeLog
2745         --git-commit. The Signed-off-by tag does not appear in the header
2746         but usually at the end.
2747
2748         * Scripts/prepare-ChangeLog:
2749
2750 2007-10-21  Mark Rowe  <mrowe@apple.com>
2751
2752         Reviewed by Eric.
2753
2754         Fix run-javascriptcore-tests for Gtk.
2755
2756         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
2757
2758 2007-10-20  Eric Seidel  <eric@webkit.org>
2759
2760         Reviewed by aroben.
2761
2762         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
2763
2764 2007-10-20  Eric Seidel  <eric@webkit.org>
2765
2766         Reviewed by darin.
2767         
2768         Add improved argument handling to run-sunspider, including
2769         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
2770         Also re-factor code into subroutines
2771
2772         * Scripts/build-dumprendertree: removed bogus comments
2773         * Scripts/build-testkjs: Added.
2774         * Scripts/run-javascriptcore-tests: use build-testkjs
2775         * Scripts/run-sunspider: improved argument handling, abstraction
2776         * Scripts/run-webkit-tests: improved abstraction
2777
2778 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
2779
2780         Not reviewed, Windows build fix.
2781
2782         * DumpRenderTree/win/EventSender.cpp:
2783         (keyDownCallback):
2784
2785 2007-10-20  Darin Adler  <darin@apple.com>
2786
2787         Reviewed by Tim Hatcher.
2788
2789         - http://bugs.webkit.org/show_bug.cgi?id=15544
2790           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
2791           not rely on Apple-specific key codes
2792
2793         * DumpRenderTree/mac/EventSendingController.mm:
2794         (-[EventSendingController keyDown:withModifiers:]):
2795         Added named key "rightArrow". Later we could have a whole table of these.
2796         Also tweaked modifiers code a little.
2797
2798         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
2799
2800 2007-10-19  Darin Adler  <darin@apple.com>
2801
2802         Reviewed by Eric.
2803
2804         - http://bugs.webkit.org/show_bug.cgi?id=15566
2805           possible fix for leak seen in DumpRenderTree
2806
2807         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
2808         Delete the item if it's not put on the queue, since the caller has
2809         no way of knowing that. Would be better to have the parameter type
2810         be auto_ptr to express the fact that we take ownership.
2811
2812         - unrelated change
2813
2814         * Drosera/mac/main.m: Add missing include.
2815
2816 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2817
2818         Reviewed by Adam.
2819
2820         - This change should be identical but for some reason was not working
2821         on my machine.
2822
2823         * Scripts/prepare-ChangeLog:
2824
2825 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2826
2827         Reviewed by Oliver and Tim.
2828
2829         - Made use of RetainPtr to avoid retain and release issues and moved the
2830         log function to DebuggerDocumentPlatform, which seems to be a more
2831         logical place for it to live.
2832         - Also moved knownServers from the ServerConnection to
2833         DebuggerApplication to match the Windows code and because it makes sense
2834         that a connection knows its own server but not all of them.
2835
2836         * Drosera/mac/DebuggerClient.h: Moved the log function to
2837           DebuggerDocumentPlatform.
2838         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
2839           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
2840           call for the server name up from the ServerConnection class.
2841         (-[DebuggerClient dealloc]):
2842         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
2843           for the server name up from the ServerConnection.
2844         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
2845         (DebuggerDocument::platformPause):
2846         (DebuggerDocument::platformResume):
2847         (DebuggerDocument::platformStepInto):
2848         (DebuggerDocument::platformEvaluateScript):
2849         (DebuggerDocument::getPlatformCurrentFunctionStack):
2850         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2851         (DebuggerDocument::platformValueForScopeVariableNamed):
2852         (DebuggerDocument::platformLog): Log directly from here. No need to call
2853           DebuggerClient.
2854         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
2855           way I see it, a ServerConnection should only know about its connection
2856           and the group of all possible servers should be kept by the
2857           application.
2858         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
2859           currentServerName, it makes sense that the connection should know that
2860           name.
2861         (-[ServerConnection currentServerName]):
2862
2863 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2864
2865         Reviewed by Adam.
2866
2867         - Integrated changes from mac drosera.  Recently I've encapsulated
2868         out the server connection object from the rest of Drosera because
2869         it is very platform dependent right now and RPC is not implemented on
2870         windows.  This functionality, of communicating with the WebKit server
2871         is the next area I will be focusing on in Windows.
2872
2873         - Other changes and cleanup were made to organize the code and add notes
2874         on which parts still need work.  Also some mac code is added and
2875         commented out, to act as pseudocode for the logic of those parts.
2876
2877         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
2878           pointer.
2879         * Drosera/config.h: Added whitespace.
2880         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
2881           these files got moved into Drosera.h/cpp
2882         * Drosera/win/DebuggerApplication.h: Removed.
2883         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
2884           happened here to better match the logic flow of the same code on the 
2885           mac side and to use the new ServerConnection class.
2886         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
2887         (DebuggerClient::initWithServerName): Initializer that will set up the
2888           class to use a ServerConnection object.  This was necessary so I could
2889           create a DebuggerClient without having to initilaize it at
2890           construction.
2891         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
2892           will be the UIDelegate and FrameLoadDelegate.
2893         (DebuggerClient::AddRef): For IUnknown.
2894         (DebuggerClient::Release): For IUnknown.
2895         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
2896           this still needs to set the global context of the server, but
2897           IWebFrame does not have an accessor for the global context yet. 
2898         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
2899           this is a pass through for the same function in the document.
2900         (DebuggerClient::didReceiveTitle): Unimplemented part of
2901           FrameLoadDelegate this would change the title of the window.
2902         (DebuggerClient::createWebViewWithRequest): Part of the
2903           FrameLoadDelegate.  This is about new windows via Window.open() and
2904           how their delegates are set.
2905         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
2906           UIDelegate.  Just a debug function for printing messages.
2907         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
2908           because the Client should be the UIDelegate and FrameLoadDelegate
2909           to match the delegates on mac.
2910         (DebuggerClient::webViewLoaded): Added accessor method.
2911         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
2912           forgotten to add this file before.  This is where the platform
2913           dependent versions of the Documents functions live. Most of these are
2914           unimplemented because some piece of functionality does not exist on
2915           Windows yet.
2916         (DebuggerDocument::platformPause):
2917         (DebuggerDocument::platformResume):
2918         (DebuggerDocument::platformStepInto):
2919         (DebuggerDocument::platformEvaluateScript):
2920         (DebuggerDocument::getPlatformCurrentFunctionStack):
2921         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2922         (DebuggerDocument::platformValueForScopeVariableNamed):
2923         (DebuggerDocument::platformLog):
2924         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
2925           responsibilities becaue they belong in the Client. Also I laid the
2926           groundwork for attaching Drosera to a WebKit process
2927         (attachWndProc): Now if a server is selected the Client becomes it's
2928           delegate.
2929         (Drosera::Drosera): Added the construction of the Client and dictionary
2930           of server names. 
2931         (Drosera::initUI): This is no longer the delegates, the Client is.
2932         (Drosera::webViewLoaded): Now asks the Client instead of holding local
2933           state. 
2934         (Drosera::applicationDidFinishLaunching): Placeholder for needed
2935           notification registration when it's possible to implement.
2936         (Drosera::serverLoaded): Ditto
2937         (Drosera::serverUnloaded): Ditto
2938         (Drosera::attach): Attach Drosera to the WebKit server.
2939         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
2940         (Drosera::getInst): 
2941         (Drosera::setInst):
2942         (Drosera::knownServers):
2943         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
2944           and added the ServerConnection.
2945         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
2946         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
2947           Most of the functions are completely unimlemented because they cannot
2948           connect with the WebKit server, because one does not exist on Windows
2949           yet.
2950         (ServerConnection::initWithServerName): 
2951         (ServerConnection::~ServerConnection):
2952         (ServerConnection::setGlobalContext):
2953         (ServerConnection::pause):
2954         (ServerConnection::resume):
2955         (ServerConnection::stepInto):
2956         (ServerConnection::switchToServerNamed):
2957         (ServerConnection::applicationTerminating):
2958         (ServerConnection::serverConnectionDidDie):
2959         (ServerConnection::currentFrame):
2960         * Drosera/win/ServerConnection.h: Added. Ditto.
2961         (ServerConnection::ServerConnection):
2962
2963 2007-10-19  Alice Liu  <alice.liu@apple.com>
2964
2965         Reviewed by Darin.
2966
2967         Fix for these broken layout tests on Windows:
2968         
2969         fast/forms/focus-selection-input.html
2970         fast/forms/focus-selection-textarea.html
2971         fast/forms/select-accesskey.html
2972         
2973         * DumpRenderTree/win/EventSender.cpp:
2974         (keyDownCallback):
2975         correct the VK code for alt key.
2976         
2977 2007-10-19  Eric Seidel  <eric@webkit.org>
2978
2979         Reviewed by Mark Rowe.
2980         
2981         Make the GtkLauncher code slightly more readable.
2982
2983         * GtkLauncher/main.cpp:
2984         (setupMainMenu): Added.
2985         (setupMainWindowUI): Added.
2986         (main):
2987
2988 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
2989
2990         Rubber stamped by Adam.
2991         
2992         - don't delay-load WebKit in DumpRenderTree.
2993
2994         * DumpRenderTree/win/DumpRenderTree.vcproj:
2995
2996 2007-10-18  Dan Bernstein  <mitz@apple.com>
2997
2998         Reviewed by Adam Roben.
2999
3000         - fix <rdar://problem/5313523>
3001         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
3002
3003         * DumpRenderTree/mac/DumpRenderTree.mm:
3004         (dump): Changed to use _responseMIMEType.
3005
3006 2007-10-17  Adam Roben  <aroben@apple.com>
3007
3008         Make it possible to have Windows-specific tests and results
3009
3010         When searching for tests to run and the Skipped file, we will only
3011         look in platform/win and the cross-platform directory. When looking
3012         for expected results, we will look in platform/win, then
3013         platform/mac-leopard, then platform/mac, then finally the
3014         cross-platform directory.
3015
3016         Reviewed by Sam.
3017
3018         * Scripts/run-webkit-tests:
3019         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
3020         searching in the cross-platform directory.
3021         (sub buildPlatformHierarchy): Removed some unneeded calls to
3022         dirname/basename.
3023
3024 2007-10-17  Adam Roben  <aroben@apple.com>
3025
3026         Add back the call to register WebKit that we had before WebKitInitializer existed
3027
3028         This is needed to ensure that the right WebKit is used when
3029         instantiating COM objects.
3030
3031         Reviewed by Oliver.
3032
3033         * DumpRenderTree/win/debug_internal.vsprops: Define
3034         DEBUG_WEBKIT_HAS_SUFFIX.
3035         * DumpRenderTree/win/DumpRenderTree.cpp:
3036         (initialize):
3037
3038 2007-10-17  Adam Roben  <aroben@apple.com>
3039
3040         Import File::Basename in webkitdirs since we use it
3041
3042         * Scripts/webkitdirs.pm:
3043
3044 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
3045
3046         - Updated the tiger leaks list to make the internal bots green.
3047
3048         * Scripts/run-webkit-tests:
3049
3050 2007-10-17  Adam Roben  <aroben@apple.com>
3051
3052         Build fix for VC++ Express
3053
3054         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
3055         and ole32.lib.
3056
3057 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
3058
3059         Reviewed by Sam.
3060
3061         - Minor mac improvements based on observations I made while implementing the
3062         Windows code.
3063
3064         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
3065         then hand it to the Client who will retain it, it should just be the client who
3066         creates and owns the server.
3067         (-[DebuggerApplication attach:]):
3068         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
3069         * Drosera/mac/DebuggerClient.mm: Creates the server.
3070         (-[DebuggerClient initWithServerName:]):
3071         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
3072         can instead forward declare what it needs.
3073
3074 2007-10-16  Darin Adler  <darin@apple.com>
3075
3076         Reviewed by Geoff Garen.
3077
3078         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
3079         want to turn failing tests into platform-specific test results. Also did a
3080         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
3081         would take the type of results into account only some of the time.
3082
3083 2007-10-16  Adam Roben  <aroben@apple.com>
3084
3085         Add a new nightly launcher script for Windows
3086
3087         This new script is for versions of Safari that don't delay-load
3088         WebKit. I had to make FindSafari be able to print out the nightly
3089         launcher script on stdout because Windows shell scripts can't capture
3090         the output from a command into an environment variable.
3091
3092         Reviewed by Steve.
3093
3094         * FindSafari/FindSafari.cpp:
3095         (_tmain): Added /printSafariLauncher option.
3096         * Scripts/run-webkit-nightly.cmd: Added.
3097
3098 2007-10-16  Adam Roben  <aroben@apple.com>
3099
3100         Replace WebKitInitializer with FindSafari
3101
3102         We now rely on setting the PATH environment variable to tell Windows
3103         where to find WebKit and its dependencies (similar to
3104         DYLD_FRAMEWORK_PATH on Mac).
3105
3106         This change also make DumpRenderTree no longer delay-load WebKit.
3107
3108         Reviewed by Sam.
3109
3110         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
3111         FindSafari.
3112         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
3113         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
3114         WebKitInitializer, don't delay-load WebKit.
3115         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
3116         * Scripts/run-webkit-tests: Ditto.
3117         * Scripts/webkitdirs.pm:
3118         (sub setPathForRunningWebKitApp): Added.
3119         * WebKitInitializer/WebKitInitializer.cpp: Removed.
3120         * WebKitInitializer/WebKitInitializer.h: Removed.
3121         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
3122         * WebKitInitializer/debug.vsprops: Removed.
3123         * WebKitInitializer/debug_internal.vsprops: Removed.
3124         * WebKitInitializer/release.vsprops: Removed.
3125
3126 2007-10-16  Adam Roben  <aroben@apple.com>
3127
3128         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
3129
3130         http://bugs.webkit.org/show_bug.cgi?id=15532
3131
3132         FindSafari simply prints the location of an installed Safari.exe on
3133         stdout.
3134
3135         Reviewed by Darin.
3136
3137         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
3138         (getStringValue):
3139         (getWebViewCLSID):
3140         (getInstalledWebKitDirectory):
3141         (_tmain):
3142         * FindSafari/FindSafari.vcproj: Added.
3143         * Scripts/webkitdirs.pm:
3144         (sub installedSafariPath): Added. Calls FindSafari on Windows.
3145
3146 2007-10-16  Adam Roben  <aroben@apple.com>
3147
3148         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
3149
3150         Reviewed by Kevin McCullough.
3151
3152         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
3153         when referring to WebKit.dll.
3154         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
3155         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
3156         * DumpRenderTree/win/release.vsprops: Ditto.
3157         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
3158         never have a _debug suffix on WebKit.dll.
3159         * WebKitInitializer/WebKitInitializer.cpp:
3160         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
3161         specified.
3162         * WebKitInitializer/debug_internal.vsprops: Added
3163         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
3164
3165 2007-10-16  Darin Adler  <darin@apple.com>
3166
3167         Reviewed by Adele.
3168
3169         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
3170         Remove now-unneeded control/alt key hack; the tests have been updated.
3171
3172 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
3173
3174         - Updated leaks list because our internal bot upgraded it's version of leopard and 
3175         one of the leaks was fixed between that revision and the bot's previous version of
3176         leopard.
3177
3178         * Scripts/run-webkit-tests:
3179
3180 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
3181
3182         Reviewed by Tim.
3183
3184         - I encapsulated out the server connecton functionality because it is a specific part
3185         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
3186         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
3187         Windows.  So the majority of this patch is moving preexisting functionality.
3188
3189         - Also I removed the prefix header and changed to use config.h because it is more
3190         standard on how we use config.h in windows and it didn't make much sense to keep
3191         the prefix header and the config.h
3192
3193         * Drosera/DebuggerDocument.cpp:
3194         (DebuggerDocument::DebuggerDocument):
3195         * Drosera/DebuggerDocument.h:
3196         * Drosera/config.h:
3197         * Drosera/mac/DebuggerApplication.mm:
3198         (-[DebuggerApplication attach:]):
3199         * Drosera/mac/DebuggerClient.h:
3200         * Drosera/mac/DebuggerClient.mm:
3201         (-[DebuggerClient initWithServerConnection:]):
3202         (-[DebuggerClient dealloc]):
3203         (-[DebuggerClient windowDidLoad]):
3204         (-[DebuggerClient windowWillClose:]):
3205         (-[DebuggerClient webView:didFinishLoadForFrame:]):
3206         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
3207         * Drosera/mac/DebuggerDocumentPlatform.mm:
3208         (DebuggerDocument::platformPause):
3209         (DebuggerDocument::platformResume):
3210         (DebuggerDocument::platformStepInto):
3211         (DebuggerDocument::platformEvaluateScript):
3212         (DebuggerDocument::getPlatformCurrentFunctionStack):
3213         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3214         (DebuggerDocument::platformValueForScopeVariableNamed):
3215         (DebuggerDocument::platformLog):
3216         * Drosera/mac/Drosera.pch: Removed.
3217         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3218         * Drosera/mac/ServerConnection.h: Added.
3219         * Drosera/mac/ServerConnection.mm: Added.
3220         (-[ServerConnection initWithServerName:]):
3221         (-[ServerConnection dealloc]):
3222         (-[ServerConnection setGlobalContext:]):
3223         (-[ServerConnection pause]):
3224         (-[ServerConnection resume]):
3225         (-[ServerConnection stepInto]):
3226         (-[ServerConnection switchToServerNamed:]):
3227         (-[ServerConnection applicationTerminating:]):
3228         (-[ServerConnection serverConnectionDidDie:]):
3229         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
3230         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
3231         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
3232         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
3233         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
3234         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
3235         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
3236         (-[ServerConnection currentFrame]):
3237         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
3238         (-[ServerConnection knownServers]):
3239
3240 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
3241
3242         Reviewed by Eric.
3243
3244         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
3245           Script to automatically search nightly builds for regressions (bisect-builds)
3246
3247         * Scripts/bisect-builds: Added.
3248
3249 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
3250
3251         Reviewed by Darin.
3252
3253         - New JavaScript benchmark
3254         http://bugs.webkit.org/show_bug.cgi?id=15515
3255
3256         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
3257         current development or release build of JavaScriptCore.
3258
3259 2007-10-15  Mark Rowe  <mrowe@apple.com>
3260
3261         Reviewed by Sam.
3262
3263         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
3264
3265         * Scripts/webkitdirs.pm:
3266         - Change checkArgv to remove the options from @ARGV to prevent
3267         them from interfering with further option processing.
3268         - Fix logic error in determineIsQt that would prevent it from bailing out early.
3269         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
3270         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
3271         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
3272
3273 2007-10-15  Darin Adler  <darin@apple.com>
3274
3275         Reviewed by Sam.
3276
3277         - added logging of window.prompt and window.confirm
3278
3279         * DumpRenderTree/mac/UIDelegate.mm:
3280         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
3281         Implement the recommended delegate rather than the deprecated one.
3282         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
3283         Added.
3284         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
3285         Added.
3286
3287         * DumpRenderTree/win/UIDelegate.h:
3288         * DumpRenderTree/win/UIDelegate.cpp:
3289         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
3290         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
3291         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
3292         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
3293
3294 2007-10-15  Alice Liu  <alice.liu@apple.com>
3295
3296         Reviewed by Sam Weinig.
3297
3298         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
3299
3300         * DumpRenderTree/win/DumpRenderTree.cpp:
3301         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
3302         (main): allocate the global policy delegate for DRT's custom use
3303         * DumpRenderTree/win/DumpRenderTree.vcproj:
3304         Adding files to project
3305         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
3306         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3307         (LayoutTestController::setCustomPolicyDelegate):
3308         set the webview's policy delegate to DRT's custom one if the test requests it.
3309         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
3310         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
3311         (PolicyDelegate::PolicyDelegate):
3312         (PolicyDelegate::QueryInterface):
3313         (PolicyDelegate::AddRef):
3314         (PolicyDelegate::Release):
3315         (PolicyDelegate::decidePolicyForNavigationAction):
3316         * DumpRenderTree/win/PolicyDelegate.h: Added.
3317         (PolicyDelegate::decidePolicyForNewWindowAction):
3318         (PolicyDelegate::decidePolicyForMIMEType):
3319         (PolicyDelegate::unableToImplementPolicyWithError):
3320
3321 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
3322
3323         Reviewed by Mark.
3324
3325         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
3326         when querying for QMAKE_MKSPECS.
3327
3328 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
3329
3330         Reviewed by Adam Roben.
3331         
3332         Fix run-webkit-tests is too greedy calculating platform hierarchy
3333         http://bugs.webkit.org/show_bug.cgi?id=15465
3334         
3335         Fix run-webkit-tests being too greedy in trying to split the platform name up
3336         causing it to try and find tests in every directory above the first "-" in the
3337         path to the LayoutTests
3338
3339         * Scripts/run-webkit-tests:
3340
3341 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
3342
3343         Reviewed by Darin.
3344
3345         http://bugs.webkit.org/show_bug.cgi?id=15006
3346         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
3347         to reduce code duplication.
3348
3349         * Scripts/build-webkit:
3350         * Scripts/webkitdirs.pm:
3351         buildQMakeProject() renamed to buildQMakeQtProject().
3352         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
3353         unused $colorize has been removed.
3354
3355 === Start merge of feature-branch 2007-10-12 ===
3356
3357 2007-10-08  Eric Seidel  <eric@webkit.org>
3358
3359         Reviewed by Mark Rowe.
3360
3361         * Scripts/build-webkit: add --help, remove unused --color
3362
3363 2007-10-07  Eric Seidel  <eric@webkit.org>
3364
3365         Reviewed by darin.
3366
3367         * Drosera/mac/DebuggerDocumentPlatform.mm:
3368         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
3369
3370 2007-10-03  Rob Buis  <buis@kde.org>
3371
3372         Reviewed by Olliej.
3373
3374         Adapt to changed location of Ahem font.
3375
3376         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3377
3378 2007-10-02  Eric Seidel  <eric@webkit.org>
3379
3380         Reviewed by Adam Roben.
3381         
3382         Make pixel tests more useful!
3383         Finally fix the image diff 0.00% mystery problem
3384         Highlight any image differences in the image diff.
3385         Add a link from image diffs back to original test file.
3386
3387         * DumpRenderTree/mac/ImageDiff.m:
3388         (compareImages): highlight any differences
3389         (computePercentageDifferent): round to two decimal places
3390         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
3391
3392 2007-10-02  Eric Seidel  <eric@webkit.org>
3393
3394         Reviewed by Alexey Proskuryakov.
3395
3396         * Scripts/run-webkit-tests: print the % image difference on main results page
3397
3398 2007-10-02  Mark Rowe  <mrowe@apple.com>
3399
3400         Reviewed by Oliver.
3401
3402         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
3403
3404         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
3405         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
3406
3407 2007-10-01  Mark Rowe  <mrowe@apple.com>
3408
3409         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
3410
3411 2007-09-25  Eric Seidel  <eric@webkit.org>
3412
3413         Reviewed by Mark Rowe.
3414         
3415         DerivedSources.make was finding "ENABLE_SVG" in the string
3416         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
3417         quite correctly.
3418
3419         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
3420
3421 2007-09-25  Mark Rowe  <mrowe@apple.com>
3422
3423         Rubber-stamped by Eric.
3424
3425         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
3426         This makes it possible to automate nightly builds for the feature-branch.
3427
3428 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
3429
3430         Rubber stamped by Mark.
3431
3432         Enable svg experimental features as default here in feature-branch.
3433
3434         * Scripts/build-webkit:
3435
3436 2007-06-29  Antti Koivisto  <antti@apple.com>
3437
3438         Reviewed by Weinig.
3439         
3440         Add VIDEO flag for timed media features
3441
3442         * Scripts/build-webkit
3443         
3444 === End merge of feature-branch 2007-10-12 ===
3445
3446 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
3447
3448         Reviewed by Darin.
3449
3450         - Updated rational for the leaks list to be more clear.
3451
3452         * Scripts/run-webkit-tests:
3453
3454 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
3455
3456         Rubber Stamp by Sam.
3457
3458         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
3459         I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
3460
3461         * Scripts/run-webkit-tests:
3462
3463 2007-10-10  Simon Hausmann  <hausmann@kde.org>
3464
3465         Reviewed by Lars.
3466
3467         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
3468         includes are needed for INT_MAX, std::auto_ptr and the like.
3469
3470         * DumpRenderTree/qt/main.cpp:
3471
3472 2007-10-09  Lars Knoll  <lars@trolltech.com>
3473
3474         Reviewed by Simon.
3475
3476         implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
3477
3478         * DumpRenderTree/qt/jsobjects.cpp:
3479         (LayoutTestController::encodeHostName):
3480         (LayoutTestController::decodeHostName):
3481         * DumpRenderTree/qt/jsobjects.h:
3482
3483 2007-10-09  Lars Knoll  <lars@trolltech.com>
3484
3485         Reviewed by Simon.
3486
3487         Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
3488
3489         * DumpRenderTree/qt/DumpRenderTree.cpp:
3490         (WebCore::WebPage::createFrame):
3491         (WebCore::DumpRenderTree::DumpRenderTree):
3492         (WebCore::DumpRenderTree::titleChanged):
3493         * DumpRenderTree/qt/DumpRenderTree.h:
3494         * DumpRenderTree/qt/jsobjects.cpp:
3495         (LayoutTestController::reset):
3496         * DumpRenderTree/qt/jsobjects.h:
3497
3498 2007-10-09  Lars Knoll  <lars@trolltech.com>
3499
3500         Reviewed by Simon.
3501
3502         add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
3503
3504         * DumpRenderTree/qt/DumpRenderTree.h:
3505         * DumpRenderTree/qt/jsobjects.cpp:
3506         (LayoutTestController::clearBackForwardList):
3507         * DumpRenderTree/qt/jsobjects.h:
3508
3509 2007-10-09  Lars Knoll  <lars@trolltech.com>
3510
3511         Reviewed by Simon.
3512
3513         make --git-reviewer work again.
3514
3515         * Scripts/prepare-ChangeLog:
3516
3517 2007-10-07  Holger Hans Peter Freyther  <zecke@selfish.org>
3518
3519         Rubber stamped by Eric.
3520
3521         Connect to the "hovering-over-link" signal emitted by WebKitPage and
3522         show the current link inside the statusbar.
3523         This shows how to make use of this signal and allows to easily test
3524         http://bugs.webkit.org/show_bug.cgi?id=15299.
3525
3526         * GtkLauncher/main.cpp:
3527         (hoveringOverLink):
3528         (main):
3529
3530 2007-10-05  Lars Knoll  <lars@trolltech.com>
3531
3532         add proper error messages to the FrameLoaderClient.
3533         Implement ChromeClientQt::closeWindowSoon and
3534         FrameLoaderClientQt::dispatchCreatePage (which should go away IMO).
3535         Some fixes in DRT to make it work correctly with multiple windows.
3536
3537         Reviewed by Maciej.
3538
3539         * DumpRenderTree/qt/DumpRenderTree.cpp:
3540         (WebCore::DumpRenderTree::DumpRenderTree):
3541         (WebCore::DumpRenderTree::createWindow):
3542         (WebCore::DumpRenderTree::windowCount):
3543         * DumpRenderTree/qt/DumpRenderTree.h:
3544         * DumpRenderTree/qt/jsobjects.cpp:
3545         (LayoutTestController::maybeDump):
3546         (LayoutTestController::windowCount):
3547         * DumpRenderTree/qt/jsobjects.h:
3548
3549 2007-10-05  Lars Knoll  <lars@trolltech.com>
3550
3551         Add a dummy plugin to DRT  to fix fast/dom/Window/Plug-Ins.html.
3552         Add support for layoutTextController.setCanOpenWindows() to DRT
3553         fixing another 2 test cases in fast/dom/Window.
3554
3555         Reviewed by Maciej.
3556
3557         * DumpRenderTree/qt/DumpRenderTree.cpp:
3558         (WebCore::WebPage::WebPage):
3559         (WebCore::WebPage::createWindow):
3560         (WebCore::DumpRenderTree::resetJSObjects):
3561         (WebCore::DumpRenderTree::createWindow):
3562         * DumpRenderTree/qt/DumpRenderTree.h:
3563         * DumpRenderTree/qt/DumpRenderTree.pro:
3564         * DumpRenderTree/qt/jsobjects.cpp:
3565         (LayoutTestController::LayoutTestController):
3566         (LayoutTestController::reset):
3567         * DumpRenderTree/qt/jsobjects.h:
3568         * DumpRenderTree/qt/main.cpp:
3569         * DumpRenderTree/qt/testplugin.cpp: Added.
3570         * DumpRenderTree/qt/testplugin.h: Added.
3571
3572 2007-10-04  Sam Weinig  <sam@webkit.org>
3573
3574         Rubber stamped by Adam.
3575
3576         Remove empty directories.
3577
3578         * DumpRenderTree/DumpRenderTree.qtproj: Removed.
3579         * DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.
3580
3581 2007-10-03  Darin Adler  <darin@apple.com>
3582
3583         Reviewed by Adam.
3584
3585         * Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if
3586         we find the internal libraries in the libraries directory. This
3587         is helpful for Safari team engineers at Apple.
3588
3589 2007-10-03  Adam Roben  <aroben@apple.com>
3590
3591         Update the location of AHEM___.TTF after r25968
3592
3593         Reviewed by Sam.
3594
3595         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3596
3597 2007-10-03  Alp Toker  <alp@atoker.com>
3598
3599         Reviewed by Adam.
3600
3601         http://bugs.webkit.org/show_bug.cgi?id=14726
3602         [gtk] API design. Mapping the WebView delegates to signals.
3603
3604         Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.
3605
3606         * GtkLauncher/main.cpp:
3607         (goToURLBarText):
3608         (titleChanged):
3609         (progressChanged):
3610         (menuMainBackCallback):