WebKitTools/ChangeLog

   1 2010-01-28  Hayato Ito  <hayato@chromium.org>
   2
   3         Reviewed by David Levin.
   4
   5         Remove NULL char from input JS file because 'grep' fails if the file contains NULL char.
   6
   7         https://bugs.webkit.org/show_bug.cgi?id=34252
   8
   9         * Scripts/make-script-test-wrappers:
  10
  11 2010-01-28  Kevin Ollivier  <kevino@theolliviers.com>
  12
  13         [wx] Build fix after removal of the zlib image decoder.
  14
  15         * wx/build/settings.py:
  16
  17 2010-01-28  Csaba Osztrogonác  <ossy@webkit.org>
  18
  19         [Qt] Unreviewed, roll out r54000.
  20
  21         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  22         (WebCore::DumpRenderTree::DumpRenderTree):
  23         * DumpRenderTree/qt/DumpRenderTreeQt.h:
  24         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  25         (LayoutTestController::reset):
  26         * DumpRenderTree/qt/LayoutTestControllerQt.h:
  27         (LayoutTestController::display):
  28
  29 2010-01-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
  30
  31         Reviewed by Kenneth Rohde Christiansen.
  32
  33         [Qt] Implement the display() method of the layout test controller
  34         https://bugs.webkit.org/show_bug.cgi?id=34258
  35
  36         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  37         (WebCore::DumpRenderTree::DumpRenderTree):
  38         (WebCore::DumpRenderTree::showPage):
  39         (WebCore::DumpRenderTree::hidePage):
  40         * DumpRenderTree/qt/DumpRenderTreeQt.h:
  41         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  42         (LayoutTestController::reset):
  43         (LayoutTestController::display):
  44         * DumpRenderTree/qt/LayoutTestControllerQt.h:
  45
  46 2010-01-28  Chris Jerdonek  <cjerdonek@webkit.org>
  47
  48         Reviewed by Shinichiro Hamaji.
  49
  50         Eliminated the filename parameter from functions in
  51         check-webkit-style's cpp.py where it is no longer used.
  52
  53         https://bugs.webkit.org/show_bug.cgi?id=34249
  54
  55         * Scripts/webkitpy/style/processors/cpp.py:
  56           - Reduced number of occurrences of "filename" variable from
  57             approximately 200 to 120.
  58
  59         * Scripts/webkitpy/style/processors/cpp_unittest.py:
  60           - Refactored unit tests as necessary to accommodate changes to cpp.py.
  61           - Fixed bug in CppStyleTestBase.perform_include_what_you_use()
  62             where the incorrect file extension was getting passed to
  63             cpp_style.check_language().
  64
  65 2010-01-28  Chris Jerdonek  <cjerdonek@webkit.org>
  66
  67         Reviewed by Shinichiro Hamaji.
  68
  69         In check-webkit-style, eliminated the dependency of
  70         processors/cpp_unittest.py on checker.py.
  71
  72         https://bugs.webkit.org/show_bug.cgi?id=34205
  73
  74         * Scripts/webkitpy/style/checker.py:
  75           - Addressed FIXME by removing STYLE_CATEGORIES data.
  76           - Added style_categories().
  77
  78         * Scripts/webkitpy/style/checker_unittest.py:
  79           - Minor changes.
  80
  81         * Scripts/webkitpy/style/processors/cpp.py:
  82           - Added categories attribute to CppProcessor class (data
  83             was originally checker.STYLE_CATEGORIES).
  84
  85         * Scripts/webkitpy/style/processors/cpp_unittest.py:
  86           - Addressed FIXME by eliminating "import" from checker.py.
  87
  88 2010-01-28  Anton Muhin  <antonm@chromium.org>
  89
  90         Reviewed by Shinichiro Hamaji.
  91
  92         Improve treatment of conditions and rest of the line for if, else, switch and alikes
  93         https://bugs.webkit.org/show_bug.cgi?id=34173
  94
  95         * Scripts/webkitpy/style/cpp_style.py:
  96         * Scripts/webkitpy/style/cpp_style_unittest.py:
  97
  98 2010-01-28  Joe Mason  <jmason@rim.com>
  99
 100         Reviewed by Adam Barth.
 101
 102         Limit login retries to 5
 103         https://bugs.webkit.org/show_bug.cgi?id=34193
 104
 105         * Scripts/webkitpy/bugzilla.py:
 106
 107 2010-01-27  Martin Robinson  <mrobinson@webkit.org>
 108
 109         Adding myself to the committer list. No review necessary.
 110
 111         * Scripts/webkitpy/committers.py:
 112
 113 2010-01-27  George Wright  <gwright@rim.com>
 114
 115         Reviewed by Adam Treat.
 116
 117         https://bugs.webkit.org/show_bug.cgi?id=34216
 118
 119         Add missing include for wtf/Platform.h
 120
 121         * DumpRenderTree/AccessibilityController.h:
 122
 123 2010-01-27  Diego Gonzalez  <diego.gonzalez@openbossa.org>
 124
 125         Reviewed by Kenneth Rohde Christiansen.
 126
 127         [Qt] DRT Provide worker thread ability to track counters
 128         https://bugs.webkit.org/show_bug.cgi?id=34221
 129
 130         Implement workerThreadCount() in LayoutTestController of Qt DRT
 131
 132         Tests:
 133         fast/workers/dedicated-worker-lifecycle.html
 134         fast/workers/shared-worker-frame-lifecycle.html
 135         fast/workers/shared-worker-lifecycle.html
 136         fast/workers/worker-lifecycle.html
 137
 138         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 139         (LayoutTestController::workerThreadCount):
 140         * DumpRenderTree/qt/LayoutTestControllerQt.h:
 141
 142 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 143
 144         Rubberstamped by Simon Hausmann.
 145
 146         [Qt] QtLauncher refactoring:
 147
 148         Make the LauncherWindow depend less on the view, so that more
 149         code can be shared in near future.
 150
 151         * QtLauncher/main.cpp:
 152         (LauncherWindow::sendTouchEvent):
 153         (LauncherWindow::loadFinished):
 154         (LauncherWindow::zoomIn):
 155         (LauncherWindow::zoomOut):
 156         (LauncherWindow::resetZoom):
 157         (LauncherWindow::toggleZoomTextOnly):
 158         (LauncherWindow::dumpHtml):
 159         (LauncherWindow::selectElements):
 160         (LauncherWindow::setupUI):
 161
 162 2010-01-27  Kinuko Yasuda  <kinuko@chromium.org>
 163
 164         Reviewed by Eric Seidel.
 165
 166         Correctly handle the KeyLocation argument that has been introduced
 167         recently to test location-dependent key events in EventSender.keyDown.
 168         http://bugs.webkit.org/show_bug.cgi?id=28247
 169
 170         Test: fast/events/keydown-numpad-keys.html
 171
 172         * DumpRenderTree/gtk/EventSender.cpp:
 173         (keyDownCallback):
 174
 175 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 176
 177         Rubberstamped by Simon Hausmann.
 178
 179         [Qt] QtLauncher refactoring:
 180
 181         Move out code from the MainWindow (renamed to LauncherWindow)
 182         that is not depending on the view, and add it to a new class
 183         called MainWindow.
 184
 185         * QtLauncher/QtLauncher.pro:
 186         * QtLauncher/main.cpp:
 187         (LauncherWindow::LauncherWindow):
 188         (LauncherWindow::eventFilter):
 189         (LauncherWindow::loadStarted):
 190         (LauncherWindow::loadFinished):
 191         (LauncherWindow::newWindow):
 192         (LauncherWindow::setupUI):
 193         (WebPage::createWindow):
 194         (main):
 195         * QtLauncher/mainwindow.cpp: Added.
 196         (MainWindow::MainWindow):
 197         (MainWindow::buildUI):
 198         (MainWindow::page):
 199         (MainWindow::setAddressUrl):
 200         (MainWindow::addCompleterEntry):
 201         (MainWindow::load):
 202         (MainWindow::changeLocation):
 203         (MainWindow::openFile):
 204         * QtLauncher/mainwindow.h: Added.
 205
 206 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 207
 208         Rubberstamped by Simon Hausmann.
 209
 210         [Qt] QtLauncher, coding style fixes.
 211
 212         * QtLauncher/main.cpp:
 213         (MainWindow::MainWindow):
 214         (MainWindow::sendTouchEvent):
 215         (MainWindow::eventFilter):
 216         (MainWindow::loadURL):
 217         (MainWindow::setupUI):
 218         (WebPage::createPlugin):
 219
 220 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 221
 222         Rubberstamped by Simon Hausmann.
 223
 224         [Qt] QtLauncher refactoring, separating the webview and
 225         adding a QGraphicsWebView based version.
 226
 227         * QtLauncher/QtLauncher.pro:
 228         * QtLauncher/main.cpp:
 229         (MainWindow::MainWindow):
 230         * QtLauncher/webpage.h:
 231         * QtLauncher/webview.cpp: Added.
 232         (createContextMenu):
 233         (WebViewGraphicsBased::mousePressEvent):
 234         (WebViewTraditional::mousePressEvent):
 235         (WebViewGraphicsBased::contextMenuEvent):
 236         (WebViewTraditional::contextMenuEvent):
 237         * QtLauncher/webview.h: Added.
 238         (WebViewGraphicsBased::WebViewGraphicsBased):
 239         (WebViewTraditional::WebViewTraditional):
 240
 241 2010-01-27  Alexander Pavlov  <apavlov@chromium.org>
 242
 243         Adding myself as committer. No review necessary.
 244
 245         * Scripts/webkitpy/committers.py:
 246
 247 2010-01-27  Eric Seidel  <eric@webkit.org>
 248
 249         Reviewed by Darin Adler.
 250
 251         webkit-patch needs an open-bugs command
 252         https://bugs.webkit.org/show_bug.cgi?id=30793
 253
 254         * Scripts/test-webkitpy: import OpenBugsTest
 255         * Scripts/webkit-patch: import OpenBugs
 256         * Scripts/webkitpy/commands/download_unittest.py: don't import unittest
 257         * Scripts/webkitpy/commands/early_warning_system_unittest.py: ditto
 258         * Scripts/webkitpy/commands/queries_unittest.py: ditto
 259         * Scripts/webkitpy/commands/queues_unittest.py: ditto
 260         * Scripts/webkitpy/commands/upload_unittest.py: ditto
 261         * Scripts/webkitpy/mock_bugzillatool.py: log when user.open_url is called.
 262
 263 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 264
 265         Rubberstamped by Simon Hausmann
 266
 267         [Qt] QtLauncher refactoring, separating utility methods.
 268
 269         * QtLauncher/QtLauncher.pro:
 270         * QtLauncher/main.cpp:
 271         * QtLauncher/utils.cpp: Added.
 272         (urlFromUserInput):
 273         * QtLauncher/utils.h: Added.
 274
 275 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 276
 277         Rubberstamped by Simon Hausmann
 278
 279         [Qt] Refactor the code in the QtLauncher dealing with HTTP proxy.
 280
 281         * QtLauncher/main.cpp:
 282         (MainWindow::MainWindow):
 283         * QtLauncher/webpage.cpp:
 284         (WebPage::WebPage):
 285         (WebPage::applyProxy):
 286         * QtLauncher/webpage.h:
 287
 288 2010-01-26  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
 289
 290         Reviewed by Tor Arne Vestbø.
 291
 292         [Qt] Corrects debug build of DumpRenderTree on Windows.
 293
 294         * DumpRenderTree/qt/DumpRenderTree.pro:
 295
 296 2010-01-26  Daniel Bates  <dbates@webkit.org>
 297
 298         Reviewed by Adam Barth.
 299
 300         https://bugs.webkit.org/show_bug.cgi?id=34070
 301
 302         Moves the try/catch for OSError exceptions in Executive.run_command
 303         to Credentials.read_credentials() so that the unit test
 304         webkitpy.scm_unittest.SCMClassTests.test_error_handlers can
 305         assert that Executive.run_command throws an OSError exception.
 306
 307         * Scripts/webkitpy/credentials.py:
 308         * Scripts/webkitpy/executive.py: Moved try/catch for OSError to
 309         method Credentials.read_credentials().
 310         * Scripts/webkitpy/executive_unittest.py: Removed tests that no longer
 311         apply: test_run_command_with_bad_command_check_return_code and
 312         test_run_command_with_bad_command_check_calls_error_handler. Added new
 313         test to assert that run_command throws OSError exceptions.
 314
 315 2010-01-26  Diego Gonzalez  <diego.gonzalez@openbossa.org>
 316
 317         Reviewed by Kenneth Rohde Christiansen.
 318
 319         [Qt] DRT WebHistory support
 320         https://bugs.webkit.org/show_bug.cgi?id=34167
 321
 322         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 323         (LayoutTestController::reset):
 324         (LayoutTestController::webHistoryItemCount):
 325         (LayoutTestController::keepWebHistory):
 326         * DumpRenderTree/qt/LayoutTestControllerQt.h:
 327
 328 2010-01-26  Kent Tamura  <tkent@chromium.org>
 329
 330         Reviewed by Eric Seidel.
 331
 332         [Win] Add modifiers parameter support to Windows DumpRenderTree
 333         https://bugs.webkit.org/show_bug.cgi?id=34068
 334
 335         Add support for functional name modifiers; "addSelectionKey" and
 336         "rangeSelectionKey", and modifiers parameter to eventSender.mouseDown()
 337         and eventSender.mouseUp().
 338         This change is similar to r53498 for Mac.
 339
 340         * DumpRenderTree/win/EventSender.cpp:
 341         (buildModifierFlags): New function to set MK_CONTROL or MK_SHIFT to WPARAM.
 342         (mouseDownCallback): Call buidlModifiersFlags().
 343         (mouseUpCallback): ditto.
 344         (keyDownCallback): Add support for "addSelectionkey" and "rangeSelectionKey".
 345
 346 2010-01-26  Chris Jerdonek  <cjerdonek@webkit.org>
 347
 348         Reviewed by Eric Seidel.
 349
 350         The Python autoinstall cache directory now only gets created
 351         in the directory containing autoinstall.py.
 352
 353         https://bugs.webkit.org/show_bug.cgi?id=33365
 354
 355         * Scripts/webkitpy/autoinstall.py:
 356           - Also added a README file to the cache directory saying
 357             where it came from.
 358
 359 2010-01-26  Chris Jerdonek  <cjerdonek@webkit.org>
 360
 361         Reviewed by Eric Seidel.
 362
 363         Moved the check-webkit-style processors into a new
 364         webkitpy/style/processors directory.
 365
 366         https://bugs.webkit.org/show_bug.cgi?id=34060
 367
 368         * Scripts/webkitpy/style/checker.py:
 369         * Scripts/webkitpy/style/checker_unittest.py:
 370         * Scripts/webkitpy/style/cpp_style.py: Removed.
 371         * Scripts/webkitpy/style/cpp_style_unittest.py: Removed.
 372         * Scripts/webkitpy/style/processors: Added.
 373         * Scripts/webkitpy/style/processors/__init__.py: Added.
 374         * Scripts/webkitpy/style/processors/cpp.py: Copied from WebKitTools/Scripts/webkitpy/style/cpp_style.py.
 375         * Scripts/webkitpy/style/processors/cpp_unittest.py: Copied from WebKitTools/Scripts/webkitpy/style/cpp_style_unittest.py.
 376         * Scripts/webkitpy/style/processors/text.py: Copied from WebKitTools/Scripts/webkitpy/style/text_style.py.
 377         * Scripts/webkitpy/style/processors/text_unittest.py: Copied from WebKitTools/Scripts/webkitpy/style/text_style_unittest.py.
 378         * Scripts/webkitpy/style/text_style.py: Removed.
 379         * Scripts/webkitpy/style/text_style_unittest.py: Removed.
 380         * Scripts/webkitpy/style/unittests.py:
 381
 382 2010-01-26  Kevin Ollivier  <kevino@theolliviers.com>
 383
 384         [wx] Build fix, make sure stub function returns a value.
 385
 386         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
 387         (LayoutTestController::counterValueForElementById):
 388
 389 2010-01-26  Steve Falkenburg  <sfalken@apple.com>
 390
 391         Reviewed by Oliver Hunt.
 392
 393         Windows build references non-existent include paths
 394         https://bugs.webkit.org/show_bug.cgi?id=34175
 395
 396         * DumpRenderTree/win/DumpRenderTree.vcproj:
 397         * DumpRenderTree/win/ImageDiff.vcproj:
 398         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
 399
 400 2010-01-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 401
 402         Reviewed by Ariya Hidayat.
 403
 404         [Qt] Separating out the UrlLoader from the QtLauncher in it's
 405         own implementation and header file.
 406
 407         * QtLauncher/main.cpp:
 408         (main):
 409         * QtLauncher/urlloader.cpp: Added.
 410         (UrlLoader::UrlLoader):
 411         (UrlLoader::loadNext):
 412         (UrlLoader::init):
 413         (UrlLoader::getUrl):
 414         * QtLauncher/urlloader.h: Added.
 415
 416 2010-01-25  Chris Jerdonek  <cjerdonek@webkit.org>
 417
 418         Reviewed by Shinichiro Hamaji.
 419
 420         Refactored check-webkit-style by removing the file path
 421         parameter from the style error handler functions.
 422
 423         https://bugs.webkit.org/show_bug.cgi?id=34031
 424
 425         * Scripts/webkitpy/style/checker.py:
 426           - Added _default_style_error_handler() to StyleChecker class.
 427           - Moved handle_style_error() to inside _default_style_error_handler().
 428
 429         * Scripts/webkitpy/style/checker_unittest.py:
 430           - Removed file path from calls to error handler.
 431
 432         * Scripts/webkitpy/style/cpp_style.py:
 433           - Removed file path from calls to error handler.
 434
 435         * Scripts/webkitpy/style/cpp_style_unittest.py:
 436           - Removed file path from calls to error handler.
 437
 438         * Scripts/webkitpy/style/text_style.py:
 439           - Removed file path from calls to error handler.
 440
 441         * Scripts/webkitpy/style/text_style_unittest.py:
 442           - Removed file path from calls to error handler.
 443
 444 2010-01-25  Jeremy Orlow  <jorlow@chromium.org>
 445
 446         Adding myself as reviewer.  No review necessary.
 447
 448         * Scripts/webkitpy/committers.py:
 449
 450 2010-01-25  Chris Jerdonek  <cjerdonek@webkit.org>
 451
 452         Reviewed by Adam Barth.
 453
 454         Improved prepare-ChangeLog so that it preserves the relative
 455         indentation of a git commit message.
 456
 457         https://bugs.webkit.org/show_bug.cgi?id=34058
 458
 459         * Scripts/prepare-ChangeLog:
 460           - Also adjusted the script so that it does not add white
 461             space characters to empty lines.
 462
 463 2010-01-24  Eric Seidel  <eric@webkit.org>
 464
 465         No review, rolling out r53763.
 466         http://trac.webkit.org/changeset/53763
 467         https://bugs.webkit.org/show_bug.cgi?id=33895
 468
 469         Broke 20+ tests on Windows.
 470
 471         * Scripts/run-webkit-tests:
 472         * Scripts/webkitdirs.pm:
 473
 474 2010-01-24  Adam Barth  <abarth@webkit.org>
 475
 476         Rubber stamped by Eric Seidel.
 477
 478         More pep8 compliance.
 479
 480         * Scripts/webkitpy/mock_bugzillatool.py:
 481
 482 2010-01-24  Adam Barth  <abarth@webkit.org>
 483
 484         Rubber stamped by Eric Seidel.
 485
 486         More pep8 compliance.
 487
 488         * Scripts/webkitpy/executive.py:
 489         * Scripts/webkitpy/grammar.py:
 490
 491 2010-01-24  Adam Barth  <abarth@webkit.org>
 492
 493         Rubber stamped by Eric Seidel.
 494
 495         More pep8 compliance.
 496
 497         * Scripts/webkitpy/comments.py:
 498         * Scripts/webkitpy/committers.py:
 499         * Scripts/webkitpy/credentials.py:
 500
 501 2010-01-24  Adam Barth  <abarth@webkit.org>
 502
 503         Rubber stamped by Eric Seidel.
 504
 505         Make changelogs.py pass pep8.
 506
 507         * Scripts/webkitpy/changelogs.py:
 508
 509 2010-01-23  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 510
 511         [Qt] Unreviewed build fix
 512
 513         * QtLauncher/QtLauncher.pro:
 514         * QtLauncher/webinspector.h:
 515
 516 2010-01-23  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 517
 518         Rubberstamped by Simon Hausmann.
 519
 520         [Qt] Move the WebInspector class to it's own header file.
 521
 522         * QtLauncher/main.cpp:
 523         * QtLauncher/webinspector.h: Added.
 524         (WebInspector::WebInspector):
 525         (WebInspector::showEvent):
 526         (WebInspector::hideEvent):
 527
 528 2010-01-23  Robert Hogan  <robert@roberthogan.net>
 529
 530         Reviewed by Kenneth Rohde Christiansen.
 531
 532         Qt DRT: respect window.close() and window.closed()
 533
 534         Qt DRT needs to maintain a correct count of open windows
 535         for windowCount(). It also needs to delete windows that
 536         have been closed by window.close().
 537
 538         This fixes the following tests:
 539
 540         plugins/destroy-during-npp-new.html
 541         fast/dom/Document/early-document-access.html
 542         fast/dom/Window/window-early-properties.html
 543         fast/events/open-window-from-another-frame.html
 544         fast/events/popup-blocking-click-in-iframe.html
 545
 546         https://bugs.webkit.org/show_bug.cgi?id=32953
 547
 548         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
 549         (WebCore::DumpRenderTree::DumpRenderTree):
 550         (WebCore::DumpRenderTree::createWindow):
 551         (WebCore::DumpRenderTree::windowCloseRequested):
 552         * DumpRenderTree/qt/DumpRenderTreeQt.h:
 553         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 554         (LayoutTestController::maybeDump):
 555
 556 2010-01-23  Dan Bernstein  <mitz@apple.com>
 557
 558         Reviewed by Mark Rowe.
 559
 560         Added a user default for specifying a fallback frameworks path in case
 561         the bundle does not contain frameworks for the current Mac OS X version.
 562
 563         * WebKitLauncher/main.m:
 564         (fallbackMacOSXVersion): Added. Looks up the fallback version in a dictionary
 565         keyed by the FallbackSystemVersions user default and returns it.
 566         (main): If a frameworks directory for the current system version is not found,
 567         try the fallback.
 568
 569 2010-01-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
 570
 571         Reviewed by Simon Hausmann.
 572
 573         Make run-webkit-tests work under Cygwin for the Qt port
 574
 575         setPathForRunningWebKitApp() is implemented for the Qt port
 576         by using qmake to query for the location of the Qt libraries.
 577
 578         This requires the original environment (%ENV) to be untouched,
 579         so launchWithCurrentEnv() was refactored to launchWithEnv(),
 580         and the code in openDumpTool() to not use %ENV but a %CLEAN_ENV
 581         instead. This has the added benefit of getting rid of the temp
 582         variables used for storing the current env.
 583
 584         openDumpTool() is also refactored a bit into platform-spesific,
 585         port-spesific, and generic environment variables.
 586
 587         Checks for undef was added a few places to fix Perl concat
 588         warnings when run-webkit-tests is aborted.
 589
 590         https://bugs.webkit.org/show_bug.cgi?id=33895
 591
 592         * Scripts/run-webkit-tests:
 593         * Scripts/webkitdirs.pm:
 594
 595 2010-01-22  Kevin Watters  <kevinwatters@gmail.com>
 596
 597         Reviewed by Kevin Ollivier.
 598
 599         [wx] Remove the Bakefile build system, which is no longer being used.
 600
 601         https://bugs.webkit.org/show_bug.cgi?id=34022
 602
 603         * DumpRenderTree/wx/DumpRenderTree.bkl: Removed.
 604         * wx/browser/browser.bkl: Removed.
 605         * wx/build-wxwebkit: Removed.
 606
 607 2010-01-22  Gustavo Noronha Silva  <gns@gnome.org>
 608
 609         Reviewed by Simon Fraser.
 610
 611         Reset zoom level to 1.0 when resetting view state. This is causing
 612         many tests to fail after svg/custom/text-zoom.xhtml changes the
 613         zoom level.
 614
 615         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 616         (resetDefaultsToConsistentValues):
 617
 618 2010-01-22  Steve Falkenburg  <sfalken@apple.com>
 619
 620         Reviewed by Darin Adler.
 621
 622         https://bugs.webkit.org/show_bug.cgi?id=34025
 623         Enable client-based Geolocation abstraction for Mac, Windows AppleWebKit targets.
 624
 625         * Scripts/build-webkit:
 626
 627 2010-01-22  Adam Barth  <abarth@webkit.org>
 628
 629         Unreviewed.  Arg.  Someone renamed limit to output_limit on me.
 630
 631         * Scripts/webkitpy/commands/queues.py:
 632
 633 2010-01-22  Adam Barth  <abarth@webkit.org>
 634
 635         Rubber stamped by Eric Seidel.
 636
 637         Make __init__.py and buildbot.py pass pep8 style checker.
 638
 639         * Scripts/webkitpy/__init__.py:
 640         * Scripts/webkitpy/buildbot.py:
 641
 642 2010-01-21  Joe Mason  <jmason@rim.com>
 643
 644         Reviewed by Adam Barth.
 645
 646         webkit-patch should retry on invalid password
 647         https://bugs.webkit.org/show_bug.cgi?id=33955
 648
 649         Ask for bugs.webkit.org authentication in a loop.
 650
 651         * Scripts/webkitpy/bugzilla.py:
 652
 653 2010-01-22  Adam Barth  <abarth@webkit.org>
 654
 655         Unreviewed.  Don't call seek on a NoneType.
 656
 657         * Scripts/webkitpy/statusserver.py:
 658
 659 2010-01-22  Petri Latvala  <petri.latvala@nomovok.com>
 660
 661         Reviewed by David Levin.
 662
 663         check-webkit-style breaks on files with unknown types
 664         https://bugs.webkit.org/show_bug.cgi?id=34001
 665
 666         For files with type FileType.NONE, dispatch_processor returns None.
 667
 668         * Scripts/webkitpy/style/checker.py: Don't call process_file with a processor of value None.
 669
 670 2010-01-22  Adam Barth  <abarth@webkit.org>
 671
 672         Reviewed by Eric Seidel.
 673
 674         Make bugzilla.py and webkitport.py conform to pep8
 675         https://bugs.webkit.org/show_bug.cgi?id=34015
 676
 677         This patch makes webkitport.py and bugzilla.py mostly conform to PEP8
 678         style as enforced by pep8.py.  I wasn't able to get rid of all the
 679         errors because I'm not sure how to wrap some lines properly.  Also,
 680         there are a few deprication errors that I couldn't resolve easily.
 681         However, this is a massive improvement in compliance.
 682
 683         * Scripts/webkitpy/bugzilla.py:
 684         * Scripts/webkitpy/webkitport.py:
 685
 686 2010-01-22  Adam Barth  <abarth@webkit.org>
 687
 688         Reviewed by Darin Adler.
 689
 690         Limit length of EWS results to 5MB
 691         https://bugs.webkit.org/show_bug.cgi?id=34016
 692
 693         Hopefully this will fix the bug where the results link doesn't appear.
 694         Our current theory is that the results blob is too big and the server
 695         is rejecting the request with a 500 error.  That causes us to re-try
 696         the post, but when we re-try the StringIO buffer has its seek pointer
 697         at the end.
 698
 699         * Scripts/webkitpy/commands/queues.py:
 700         * Scripts/webkitpy/statusserver.py:
 701
 702 2010-01-22  Chris Jerdonek  <cjerdonek@webkit.org>
 703
 704         Reviewed by Adam Barth.
 705
 706         Made check-webkit-style able to check patches when script not
 707         run from source root. Also consolidated external references
 708         to a single file.
 709
 710         https://bugs.webkit.org/show_bug.cgi?id=33791
 711
 712         * Scripts/check-webkit-style:
 713           - Changed to import style_references.py.
 714
 715         * Scripts/webkitpy/style/__init__.py:
 716           - Removed __path__ hack that allowed searching Scripts/ directory.
 717
 718         * Scripts/webkitpy/style/checker.py:
 719           - Changed to import style_references.py.
 720
 721         * Scripts/webkitpy/style_references.py: Added.
 722
 723 2010-01-22  Dmitry Titov  <dimich@chromium.org>
 724
 725         Reviewed by Maciej Stachowiak.
 726
 727         Fix the leak of ThreadIdentifiers in threadMap across threads.
 728         https://bugs.webkit.org/show_bug.cgi?id=32689
 729
 730         Add a new test to verify the ThreadIdentifiers are not reused across threads.
 731         The test runs in the beginning of DumpRenderTree and spawns 2 non-WTF treads sequentially,
 732         waiting for the previous thread to terminate before starting the next.
 733         The treads use WTF::currentThread() in their thread function. Without a fix, this
 734         causes both threads to have the same ThreadIdentifier which triggers ASSERT in thread function.
 735         It also starts another thread using WTF. Without the fix, this finds pthread handle from previous
 736         threads in the WTF threadMap and asserts in WTF::establishIdentifierForPthreadHandle().
 737         The test practically does not affect the DRT run time because the threads end immediately.
 738
 739         * DumpRenderTree/mac/DumpRenderTree.mm:
 740         (runThread): Test thread function.
 741         (testThreadIdentifierMap):
 742         (dumpRenderTree):
 743
 744 2010-01-22  Kent Tamura  <tkent@chromium.org>
 745
 746         Reviewed by Maciej Stachowiak.
 747
 748         Fix a bug that mouseDown:withModifiers: is never called.
 749         https://bugs.webkit.org/show_bug.cgi?id=33989
 750
 751         * DumpRenderTree/mac/EventSendingController.mm:
 752         (+[EventSendingController isSelectorExcludedFromWebScript:]):
 753         (+[EventSendingController webScriptNameForSelector:]):
 754
 755 2010-01-22  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 756
 757         Rubberstamped by Antti Koivisto.
 758
 759         [Qt] Separate out the WebPage class into it's own
 760         cpp/header files. Also, removed the assumption that
 761         the view is a QWebView, in preparation of a merger
 762         of the two Qt WebKit launchers.
 763
 764         * QtLauncher/QtLauncher.pro:
 765         * QtLauncher/main.cpp:
 766         (WebView::mousePressEvent):
 767         * QtLauncher/webpage.cpp: Added.
 768         (WebPage::supportsExtension):
 769         (WebPage::extension):
 770         (WebPage::acceptNavigationRequest):
 771         (WebPage::openUrlInDefaultBrowser):
 772         * QtLauncher/webpage.h: Added.
 773         (WebPage::WebPage):
 774
 775 2010-01-21  Chris Jerdonek  <cjerdonek@webkit.org>
 776
 777         Reviewed by Shinichiro Hamaji.
 778
 779         Refactored to move file name and file-reading related code
 780         from cpp_style.py and text_style.py to checker.py.
 781
 782         https://bugs.webkit.org/show_bug.cgi?id=33775
 783
 784         * Scripts/check-webkit-style:
 785           - Updates caused by changes to checker.py.
 786
 787         * Scripts/webkitpy/style/checker.py:
 788           - Added SKIPPED_FILES_WITH_WARNING list.
 789           - Added SKIPPED_FILES_WITHOUT_WARNING list.
 790           - Added FileType class.
 791           - Added ProcessorDispatcher class.
 792           - In StyleChecker class:
 793             - Renamed process_patch() to check_patch().
 794             - Renamed process_file() to check_file().
 795             - Added _process_file().
 796             - Related refactoring.
 797             - Addressed check_patch() FIXME to share code with process_file().
 798
 799         * Scripts/webkitpy/style/checker_unittest.py:
 800           - Added ProcessorDispatcherSkipTest class.
 801           - Added ProcessorDispatcherDispatchTest class.
 802           - Added StyleCheckerCheckFileTest class.
 803
 804         * Scripts/webkitpy/style/cpp_style.py:
 805           - Renamed process_file_data() to _process_lines.
 806           - Removed process_file() (moved logic to checker.py).
 807           - Removed can_handle() (moved logic to checker.py).
 808           - Added CppProcessor class.
 809           - Removed is_exempt() (moved logic to checker.py).
 810           - Added process_file_data() back as a wrapper function.
 811
 812         * Scripts/webkitpy/style/cpp_style_unittest.py:
 813           - Removed test_can_handle().
 814           - Removed test_is_exempt().
 815           - Added CppProcessorTest class.
 816
 817         * Scripts/webkitpy/style/text_style.py:
 818           - Added TextProcessor class.
 819           - Removed process_file().
 820           - Removed can_handle().
 821
 822         * Scripts/webkitpy/style/text_style_unittest.py:
 823           - Removed test_can_handle().
 824           - Added TextProcessorTest class.
 825
 826 2010-01-21  Chris Jerdonek  <cjerdonek@webkit.org>
 827
 828         Reviewed by David Kilzer.
 829
 830         Create a unit-tested subroutine to parse patch files created
 831         by svn-create-patch.
 832
 833         https://bugs.webkit.org/show_bug.cgi?id=33475
 834
 835         * Scripts/VCSUtils.pm:
 836           - Added parseDiff().
 837           - Added parsePatch().
 838
 839         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Added.
 840           - Added unit tests for parseDiff().
 841
 842         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
 843           - Total number of tests now computed dynamically.
 844
 845         * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl: Added.
 846           - Added unit tests for parsePatch().
 847
 848 2010-01-21  Kevin Ollivier  <kevino@theolliviers.com>
 849
 850         [wx] Build fix, add new directory to dir list.
 851
 852         * wx/build/settings.py:
 853
 854 2010-01-21  Adam Barth  <abarth@webkit.org>
 855
 856         Reviewed by Eric Seidel.
 857
 858         Make the EWS transactional
 859         https://bugs.webkit.org/show_bug.cgi?id=33978
 860
 861         Now if the EWS gets interrupted in the middle of processing a patch,
 862         the bots will re-process the patch.
 863
 864         * Scripts/test-webkitpy:
 865         * Scripts/webkitpy/commands/queues.py:
 866         * Scripts/webkitpy/commands/queues_unittest.py:
 867         * Scripts/webkitpy/patchcollection.py:
 868         * Scripts/webkitpy/patchcollection_unittest.py: Added.
 869
 870 2010-01-21  Adam Barth  <abarth@webkit.org>
 871
 872         Unreviewed.  Add missing "ago" for style in the status bubble.
 873
 874         * QueueStatusServer/templates/statusbubble.html:
 875
 876 2010-01-21  Adam Barth  <abarth@webkit.org>
 877
 878         Reviewed by David Levin.
 879
 880         [style-queue] should not complain about identifier names with underscores under WebKit/gtk/webkit/
 881         https://bugs.webkit.org/show_bug.cgi?id=33356
 882
 883         White list unix_hacker_style names in WebKit/gtk/webkit because these
 884         are used in the GTK+ API.
 885
 886         * Scripts/webkitpy/style/cpp_style.py:
 887         * Scripts/webkitpy/style/cpp_style_unittest.py:
 888
 889 2010-01-21  Diego Gonzalez  <diego.gonzalez@openbossa.org>
 890
 891         Reviewed by Kenneth Rohde Christiansen.
 892
 893         [Qt] add setDomainRelaxationForbiddenForURLScheme in Qt DRT
 894         https://bugs.webkit.org/show_bug.cgi?id=33945
 895
 896         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 897         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
 898         * DumpRenderTree/qt/LayoutTestControllerQt.h:
 899
 900 2010-01-21  Simon Hausmann  <simon.hausmann@nokia.com>
 901
 902         No review, rolling out 53615 as it causes two
 903         crashes on the bot.
 904
 905         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
 906         (WebCore::DumpRenderTree::DumpRenderTree):
 907         (WebCore::DumpRenderTree::createWindow):
 908         * DumpRenderTree/qt/DumpRenderTreeQt.h:
 909         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 910         (LayoutTestController::maybeDump):
 911
 912 2010-01-21  Robert Hogan  <robert@roberthogan.net>
 913
 914         Reviewed by Simon Hausmann.
 915
 916         Qt DRT: respect window.close() and window.closed()
 917
 918         Qt DRT needs to maintain a correct count of open windows
 919         for windowCount(). It also needs to delete windows that
 920         have been closed by window.close().
 921
 922         This fixes the following tests:
 923
 924         plugins/destroy-during-npp-new.html
 925         fast/dom/Document/early-document-access.html
 926         fast/dom/Window/window-early-properties.html
 927         fast/events/open-window-from-another-frame.html
 928         fast/events/popup-blocking-click-in-iframe.html
 929
 930         https://bugs.webkit.org/show_bug.cgi?id=32953
 931
 932         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
 933         (WebCore::DumpRenderTree::DumpRenderTree):
 934         (WebCore::DumpRenderTree::createWindow):
 935         (WebCore::DumpRenderTree::windowCloseRequested):
 936         * DumpRenderTree/qt/DumpRenderTreeQt.h:
 937         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 938         (LayoutTestController::maybeDump):
 939
 940 2010-01-20  Eric Seidel  <eric@webkit.org>
 941
 942         No review, rolling out r53593.
 943         http://trac.webkit.org/changeset/53593
 944         https://bugs.webkit.org/show_bug.cgi?id=33496
 945
 946         Re-rollout this patch, the commit-queue should not have landed
 947         it again, but it did due to land-diff and rollout both not
 948         clearing flags.
 949
 950         * Scripts/webkitpy/commands/early_warning_system.py:
 951         * Scripts/webkitpy/commands/queues.py:
 952         * Scripts/webkitpy/queueengine.py:
 953         * Scripts/webkitpy/scm.py:
 954         * Scripts/webkitpy/scm_unittest.py:
 955
 956 2010-01-20  Eric Seidel  <eric@webkit.org>
 957
 958         Reviewed by Adam Barth.
 959
 960         webkit-commit-queue status page is confusing
 961         https://bugs.webkit.org/show_bug.cgi?id=33496
 962
 963         This should improve the status page by removing more Fail messages.
 964         To do this, I re-factored the CommitQueue and the AbstractReviewQueues
 965         to behave more like one another.  This meant moving where the failure reporting was done.
 966         Previously the AbstractReviewQueue always used the parent process to report the error,
 967         while CommitQueue used the subprocess when possible, and the parent only reported errors
 968         that we didn't know how to handle (bugs in the commit-queue itself).
 969         Now the AbstractReviewQueue follow's the commit-queue's model.  This got rid of a try-block
 970         in both implementations and required teaching handle_script_error in each to post Fail messages
 971         to the status server instead of calling exit(1).
 972
 973         This will also make the style-queue share more bug posting logic with other queues:
 974         https://bugs.webkit.org/show_bug.cgi?id=33871
 975
 976         * Scripts/webkitpy/commands/early_warning_system.py:
 977          - Don't exit(1) as that will cause the calling queue to also report Fail to the status server.
 978            Implementors of handle_script_error are expected to update the status server if needed, but only exit if the error could not be handled.
 979            So we instead pass patch_has_failed_this_queue=True to _update_status_for_script_error in the case that this was a real failure.
 980            _update_status_for_script_error knows how to post the Fail message to the status server.
 981          - Teach _update_status_for_script_error how to post Fail messages to the status server.
 982         * Scripts/webkitpy/commands/queues.py:
 983          - Remove the try block from process_work_item since the caller already has one.
 984          - Only CC watchers on failure to cut down on commit-queue generated mail.
 985          - handle_unexpected_error needs to mark _did_fail now that the try block is gone from process_work_item.
 986          - Abstract _format_script_error_output_for_bug to share code between all queues.
 987          - The new _format_script_error_output_for_bug allows the style-queue to share the posting limit with other queues, as well as support linking to the full output.
 988          - Rename _can_build_and_test to _current_checkout_builds_and_passes_tests to better explain what revision it's testing.
 989          - Move logging out of _can_build_and_test and make the logs explain what revision we're testing.
 990          - handle_script_error now posts Fail instead of the try block in process_work_item handling it.
 991         * Scripts/webkitpy/queueengine.py:
 992          - QueueEngine is no longer used just by the commit-queue, update the logging to say "processing" instead of landing.
 993         * Scripts/webkitpy/scm.py:
 994          - Add new checkout_revision function.
 995         * Scripts/webkitpy/scm_unittest.py:
 996          - Test our new checkout_revision function.
 997
 998 2010-01-20  Fumitoshi Ukai  <ukai@chromium.org>
 999
1000         Reviewed by Alexey Proskuryakov.
1001
1002         WebSocket: Missing Request-URI, when no tralling slash in host
1003         https://bugs.webkit.org/show_bug.cgi?id=33689
1004
1005         Update pywebsocket to 0.4.7.1, which supports alias for resource
1006         name, so that we could test for ws://127.0.0.1:8880
1007
1008         * Scripts/run-webkit-tests:
1009         * Scripts/run-webkit-websocketserver:
1010         * pywebsocket/mod_pywebsocket/dispatch.py:
1011         * pywebsocket/mod_pywebsocket/handshake.py:
1012         * pywebsocket/mod_pywebsocket/standalone.py:
1013         * pywebsocket/setup.py:
1014         * pywebsocket/test/test_dispatch.py:
1015         * pywebsocket/test/test_handshake.py:
1016
1017 2010-01-20  Eric Seidel  <eric@webkit.org>
1018
1019         No review, rolling out r53537.
1020         http://trac.webkit.org/changeset/53537
1021         https://bugs.webkit.org/show_bug.cgi?id=33496
1022
1023         Added a failure condition to the commit-queue and looks to
1024         have broken the EWS bots
1025
1026         * Scripts/webkitpy/commands/early_warning_system.py:
1027         * Scripts/webkitpy/commands/queues.py:
1028         * Scripts/webkitpy/queueengine.py:
1029         * Scripts/webkitpy/scm.py:
1030         * Scripts/webkitpy/scm_unittest.py:
1031
1032 2010-01-20  Jon Honeycutt  <jhoneycutt@apple.com>
1033
1034         MSAA: accSelect() is not implemented
1035
1036         https://bugs.webkit.org/show_bug.cgi?id=33918
1037         <rdar://problem/7436861>
1038
1039         Reviewed by Darin Adler.
1040
1041         * DumpRenderTree/AccessibilityUIElement.cpp:
1042         (takeFocusCallback):
1043         Call the object's takeFocus() function.
1044         (takeSelectionCallback):
1045         Call its takeSelection() function.
1046         (addSelectionCallback):
1047         Call its addSelection() function.
1048         (removeSelectionCallback):
1049         Call its removeSelection() function.
1050         (AccessibilityUIElement::getJSClass):
1051         Add new functions to the JS class definition.
1052
1053         * DumpRenderTree/AccessibilityUIElement.h:
1054         Declare new functions.
1055
1056         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1057         (AccessibilityUIElement::takeFocus):
1058         Stubbed.
1059         (AccessibilityUIElement::takeSelection):
1060         Stubbed.
1061         (AccessibilityUIElement::addSelection):
1062         Stubbed.
1063         (AccessibilityUIElement::removeSelection):
1064         Stubbed.
1065
1066         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1067         (AccessibilityUIElement::takeFocus):
1068         Stubbed.
1069         (AccessibilityUIElement::takeSelection):
1070         Stubbed.
1071         (AccessibilityUIElement::addSelection):
1072         Stubbed.
1073         (AccessibilityUIElement::removeSelection):
1074         Stubbed.
1075
1076         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1077         (AccessibilityUIElement::takeFocus):
1078         Call the object's accSelect() function, passing the appropriate flag.
1079         (AccessibilityUIElement::takeSelection):
1080         Ditto.
1081         (AccessibilityUIElement::addSelection):
1082         Ditto.
1083         (AccessibilityUIElement::removeSelection):
1084         Ditto.
1085
1086 2010-01-20  Andras Becsi  <abecsi@inf.u-szeged.hu>
1087
1088         Reviewed by Alexey Proskuryakov.
1089
1090         Extract Apache handling to httpd.pm module and use the provided functionality
1091         in scripts where Apache is needed.
1092         The module httpd.pm stores the PID of Apache in a variable and cleans up
1093         the PID directory after Apache properly shut down. Catching INT and TERM
1094         signals allows the scripts to close Apache and clean up its PID directory
1095         even if the testing was interrupted.
1096
1097         https://bugs.webkit.org/show_bug.cgi?id=33153
1098
1099         * Scripts/webkitperl/httpd.pm: Added.
1100         * Scripts/run-iexploder-tests:
1101         * Scripts/run-webkit-httpd:
1102         * Scripts/run-webkit-tests:
1103
1104 2010-01-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1105
1106         Reviewed by Simon Hausmann.
1107
1108         [Qt] Make DumpRenderTree build on Windows
1109
1110         * DumpRenderTree/qt/DumpRenderTree.pro:
1111         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1112         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1113         * DumpRenderTree/qt/main.cpp:
1114
1115 2010-01-20  Steve Block  <steveblock@google.com>
1116
1117         Reviewed by Eric Seidel.
1118
1119         Fix commit bot to land patches in order of the bug last modification date.
1120         https://bugs.webkit.org/show_bug.cgi?id=33395
1121
1122         * Scripts/webkitpy/bugzilla.py: Modified. Added 'order=Last+Changed' to bugzilla commit queue URL.
1123
1124 2010-01-20  Adam Barth  <abarth@webkit.org>
1125
1126         Reviewed by Eric Seidel.
1127
1128         Teach check-webkit-style about WebKit/gtk/tests
1129         https://bugs.webkit.org/show_bug.cgi?id=33892
1130
1131         Removes false positives found in
1132         https://bugs.webkit.org/show_bug.cgi?id=30883
1133
1134         * Scripts/webkitpy/style/cpp_style.py:
1135         * Scripts/webkitpy/style/cpp_style_unittest.py:
1136
1137 2010-01-20  Adam Barth  <abarth@webkit.org>
1138
1139         Reviewed by Eric Seidel.
1140
1141         Teach check-webkit-style about QGVLauncher
1142         https://bugs.webkit.org/show_bug.cgi?id=33890
1143
1144         Remove false positives found in
1145         https://bugs.webkit.org/show_bug.cgi?id=33708
1146
1147         * Scripts/webkitpy/style/cpp_style.py:
1148         * Scripts/webkitpy/style/cpp_style_unittest.py:
1149
1150 2010-01-20  Eric Seidel  <eric@webkit.org>
1151
1152         Reviewed by Adam Barth.
1153
1154         webkit-commit-queue status page is confusing
1155         https://bugs.webkit.org/show_bug.cgi?id=33496
1156
1157         This should improve the status page by removing more Fail messages.
1158         To do this, I re-factored the CommitQueue and the AbstractReviewQueues
1159         to behave more like one another.  This meant moving where the failure reporting was done.
1160         Previously the AbstractReviewQueue always used the parent process to report the error,
1161         while CommitQueue used the subprocess when possible, and the parent only reported errors
1162         that we didn't know how to handle (bugs in the commit-queue itself).
1163         Now the AbstractReviewQueue follow's the commit-queue's model.  This got rid of a try-block
1164         in both implementations and required teaching handle_script_error in each to post Fail messages
1165         to the status server instead of calling exit(1).
1166
1167         This will also make the style-queue share more bug posting logic with other queues:
1168         https://bugs.webkit.org/show_bug.cgi?id=33871
1169
1170         * Scripts/webkitpy/commands/early_warning_system.py:
1171          - Don't exit(1) as that will cause the calling queue to also report Fail to the status server.
1172            Implementors of handle_script_error are expected to update the status server if needed, but only exit if the error could not be handled.
1173            So we instead pass patch_has_failed_this_queue=True to _update_status_for_script_error in the case that this was a real failure.
1174            _update_status_for_script_error knows how to post the Fail message to the status server.
1175          - Teach _update_status_for_script_error how to post Fail messages to the status server.
1176         * Scripts/webkitpy/commands/queues.py:
1177          - Remove the try block from process_work_item since the caller already has one.
1178          - Only CC watchers on failure to cut down on commit-queue generated mail.
1179          - handle_unexpected_error needs to mark _did_fail now that the try block is gone from process_work_item.
1180          - Abstract _format_script_error_output_for_bug to share code between all queues.
1181          - The new _format_script_error_output_for_bug allows the style-queue to share the posting limit with other queues, as well as support linking to the full output.
1182          - Rename _can_build_and_test to _current_checkout_builds_and_passes_tests to better explain what revision it's testing.
1183          - Move logging out of _can_build_and_test and make the logs explain what revision we're testing.
1184          - handle_script_error now posts Fail instead of the try block in process_work_item handling it.
1185         * Scripts/webkitpy/queueengine.py:
1186          - QueueEngine is no longer used just by the commit-queue, update the logging to say "processing" instead of landing.
1187         * Scripts/webkitpy/scm.py:
1188          - Add new checkout_revision function.
1189         * Scripts/webkitpy/scm_unittest.py:
1190          - Test our new checkout_revision function.
1191
1192 2010-01-20  Adam Barth  <abarth@webkit.org>
1193
1194         Reviewed by Darin Adler.
1195
1196         Exempt JavaScriptCore/qt/api from style checks
1197         https://bugs.webkit.org/show_bug.cgi?id=33879
1198
1199         Apparently there is a JavaScriptCore API for Qt as well as a WebKit
1200         API.
1201
1202         * Scripts/webkitpy/style/cpp_style.py:
1203         * Scripts/webkitpy/style/cpp_style_unittest.py:
1204
1205 2010-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1206
1207         Reviewed by Simon Hausmann.
1208
1209         [Qt] Don't use QSocketNotifier in the DRT for reading stdin
1210
1211         QSocketNotifier is not available on Windows. Instead we read
1212         stdin synchronously after each test using signals and slots.
1213
1214         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1215         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1216         * DumpRenderTree/qt/main.cpp:
1217
1218 2010-01-19  Adam Barth  <abarth@webkit.org>
1219
1220         Rubber stamped by Eric Seidel.
1221
1222         Move chromium-ews back to building release only to make the EWS faster.
1223
1224         * Scripts/webkitpy/commands/early_warning_system.py:
1225
1226 2010-01-17  Jon Honeycutt  <jhoneycutt@apple.com>
1227
1228         MSAA: The child <option> elements of a non-multiple <select> are not
1229         exposed
1230
1231         https://bugs.webkit.org/show_bug.cgi?id=33773
1232         <rdar://problem/7550556>
1233
1234         Reviewed by Alice Liu.
1235
1236         * DumpRenderTree/AccessibilityUIElement.cpp:
1237         (getIsVisibleCallback):
1238         Call the object's isVisible() function.
1239         (getIsOffScreenCallback):
1240         Ditto, for isOffScreen().
1241         (getIsCollapsedCallback):
1242         Ditto, for isCollapsed().
1243         (getHasPopupCallback):
1244         Ditto, for hasPopup().
1245         (AccessibilityUIElement::getJSClass):
1246         Add isVisible and isOffScreen attributes.
1247
1248         * DumpRenderTree/AccessibilityUIElement.h:
1249         Declare new functions.
1250
1251         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1252         (AccessibilityUIElement::isVisible):
1253         Stubbed.
1254         (AccessibilityUIElement::isOffScreen):
1255         Stubbed.
1256         (AccessibilityUIElement::isCollapsed):
1257         Stubbed.
1258         (AccessibilityUIElement::hasPopup):
1259         Stubbed.
1260
1261         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1262         (AccessibilityUIElement::isVisible):
1263         Stubbed.
1264         (AccessibilityUIElement::isOffScreen):
1265         Stubbed.
1266         (AccessibilityUIElement::isCollapsed):
1267         Stubbed.
1268         (AccessibilityUIElement::hasPopup):
1269         Stubbed.
1270
1271         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1272         (AccessibilityUIElement::showMenu):
1273         Call the object's accDoDefaultAction() to show its popup menu.
1274         (AccessibilityUIElement::isEnabled):
1275         Check that the object does not have the "unavailable" state.
1276         (AccessibilityUIElement::isVisible):
1277         Check that the object does not have the "invisible" state.
1278         (AccessibilityUIElement::isOffScreen):
1279         Check whether the object has the "offscreen" state.
1280         (AccessibilityUIElement::isCollapsed):
1281         Check whether the object has the "collapsed" state.
1282         (AccessibilityUIElement::hasPopup):
1283         Check whether the object has the "has popup" state.
1284
1285 2010-01-19  Victor Wang  <victorw@chromium.org>
1286
1287         Reviewed by Eric Seidel.
1288
1289         Correct committer name.
1290         https://bugs.webkit.org/show_bug.cgi?id=33868
1291
1292         * Scripts/webkitpy/committers.py:
1293
1294 2010-01-19  Kent Tamura  <tkent@chromium.org>
1295
1296         Reviewed by Darin Adler.
1297
1298         [DRT][Mac] Add modifiers parameter to eventSender.mouseDown() and eventSender.mouseUp()
1299         https://bugs.webkit.org/show_bug.cgi?id=33783
1300
1301         Some listbox tests check selection behavior by click events with
1302         "meta" or "shift" keys. Behaviors for such modifier keys are
1303         platform-dependent. The new parameter of mouseDown() and mouseUp()
1304         allows to specify not only concrete modifier keys such as
1305         "shiftKey" "metaKey", but also functional names like
1306         "addSelectionKey" "rangeSelectionKey".
1307
1308         * DumpRenderTree/mac/EventSendingController.mm:
1309         (+[EventSendingController isSelectorExcludedFromWebScript:]):
1310         (+[EventSendingController webScriptNameForSelector:]):
1311         (buildModifierFlags):
1312         (-[EventSendingController mouseDown:withModifiers:]):
1313         (-[EventSendingController mouseDown:]):
1314         (-[EventSendingController mouseUp:withModifiers:]):
1315         (-[EventSendingController mouseUp:]):
1316         (-[EventSendingController keyDown:withModifiers:withLocation:]):
1317
1318 2010-01-19  Adam Barth  <abarth@webkit.org>
1319
1320         Reviewed by Eric Seidel.
1321
1322         Unbreak --request-commit
1323         https://bugs.webkit.org/show_bug.cgi?id=33832
1324
1325         * Scripts/webkitpy/bugzilla.py:
1326
1327 2010-01-19  Eric Seidel  <eric@webkit.org>
1328
1329         Reviewed by Adam Barth.
1330
1331         validate-committer-lists throws exception and committers.py needs a refresh
1332         https://bugs.webkit.org/show_bug.cgi?id=33831
1333
1334         * Scripts/validate-committer-lists: use webkit_logging
1335         * Scripts/webkitpy/committers.py: Add recently minted committers.  Fix Simon Hausmanns email address list to include his webkit-committers@lists address.
1336
1337 2010-01-18  Adam Roben  <aroben@apple.com>
1338
1339         Add LayoutTestController support for calling new WebKit SPI to
1340         disallow setting document.domain
1341
1342         DRT part of fixing <http://webkit.org/b/33806>
1343         <rdar://problem/7552837> Would like API to disallow setting of
1344         document.domain for pages with certain URL schemes
1345
1346         Reviewed by Sam Weinig.
1347
1348         * DumpRenderTree/LayoutTestController.cpp:
1349         (setDomainRelaxationForbiddenForURLSchemeCallback): Added. Calls
1350         through to LayoutTestController.
1351         (LayoutTestController::staticFunctions): Added
1352         setDomainRelaxationForbiddenForURLScheme.
1353
1354         * DumpRenderTree/LayoutTestController.h: Added
1355         setDomainRelaxationForbiddenForURLScheme.
1356
1357         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1358         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
1359         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1360         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
1361         Added. Calls through to WebKit.
1362
1363         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1364         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
1365         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1366         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
1367         Stubbed out.
1368
1369 2010-01-18  Adam Barth  <abarth@webkit.org>
1370
1371         Reviewed by Adam Roben.
1372
1373         Rename patches-to-commit to patches-in-commit-queue
1374         https://bugs.webkit.org/show_bug.cgi?id=33789
1375
1376         The command really lists the patches in the commit-queue not all the
1377         patches that are pending-commit (as the FIXME commands).
1378
1379         * Scripts/webkitpy/commands/queries.py:
1380         * Scripts/webkitpy/commands/queries_unittest.py:
1381
1382 2010-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1383
1384         Reviewed by Simon Hausmann.
1385
1386         [Qt] Force qmake to generate a single makefile for DerivedSources.pro
1387
1388         * Scripts/webkitdirs.pm:
1389
1390 2010-01-18  Adam Roben  <aroben@apple.com>
1391
1392         Clean up use of /useenv when invoking Visual C++
1393
1394         This change reverts things to their pre-r49485 state. That revision
1395         (and, subsequently, r49664 and r51788) started passing /useenv to
1396         Visual C++, even in cases where we don't want to do so (such as when
1397         invoking Visual C++ Express), in the name of making the Chromium build
1398         work. Now that Chromium isn't using buildVisualStudioProject or
1399         pdevenv, we can put things back they way they were.
1400
1401         Fixes <http://webkit.org/b/33797> build-webkit fails with VC++ Express
1402         (due to /useenv flag)
1403
1404         Reviewed by Sam Weinig.
1405
1406         * Scripts/pdevenv: Always pass /useenv. Chromium doesn't use this
1407         script anymore.
1408         * Scripts/webkitdirs.pm:
1409         (buildVisualStudioProject): Never pass /useenv anymore. pdevenv takes
1410         care of this itself, and we don't want to pass /useenv when not using
1411         pdevenv (e.g., when using VC++ Express, because that will cause it to
1412         ignore the Platform SDK).
1413
1414 2010-01-18  Adam Barth  <abarth@webkit.org>
1415
1416         Reviewed by Eric Seidel.
1417
1418         webkit-patch land-safely should obsolete old patches
1419         https://bugs.webkit.org/show_bug.cgi?id=33788
1420
1421         When posting a commit-queue+ patch with land-safely, we should
1422         obsolete the old patches on the bug.  They're really confusing
1423         because the main use case is to address reviewer feedback on a
1424         previous patch.
1425
1426         * Scripts/webkitpy/commands/upload.py:
1427         * Scripts/webkitpy/commands/upload_unittest.py:
1428
1429 2010-01-18  Adam Barth  <abarth@webkit.org>
1430
1431         Reviewed by David Levin.
1432
1433         webkit-patch should authenticate more often
1434         https://bugs.webkit.org/show_bug.cgi?id=33701
1435
1436         This makes it easier to work with security patches.
1437
1438         * Scripts/webkitpy/bugzilla.py:
1439
1440 2010-01-18  Adam Barth  <abarth@webkit.org>
1441
1442         Reviewed by Darin Adler.
1443
1444         style checker needs to know about GObject-specific requirements
1445         inside WebCore/bindings/gobject/
1446         https://bugs.webkit.org/show_bug.cgi?id=33606
1447
1448         Add an exception to the underscore rule for certain
1449         GObject-specific names.
1450
1451         * Scripts/webkitpy/style/cpp_style.py:
1452         * Scripts/webkitpy/style/cpp_style_unittest.py:
1453
1454 2010-01-18  Adam Barth  <abarth@webkit.org>
1455
1456         Reviewed by Shinichiro Hamaji.
1457
1458         [check-webkit-style] does understand ResourceHandleWin.h
1459         https://bugs.webkit.org/show_bug.cgi?id=32975
1460
1461         I'm not 100% convinced this fix is correct, but without more examples,
1462         it's hard to generalize.  We can always generalize the fix in the
1463         future.
1464
1465         * Scripts/webkitpy/style/cpp_style.py:
1466         * Scripts/webkitpy/style/cpp_style_unittest.py:
1467
1468 2010-01-18  Adam Barth  <abarth@webkit.org>
1469
1470         Unreviewed "build" fix.
1471
1472         * Scripts/webkitpy/bugzilla.py:
1473
1474 2010-01-18  Adam Barth  <abarth@webkit.org>
1475
1476         Unreviewed.  Actually make land-safely mark commit-queue+ as
1477         discussed with Eric.
1478
1479         * Scripts/webkitpy/bugzilla.py:
1480         * Scripts/webkitpy/steps/postdiffforcommit.py:
1481
1482 2010-01-17  Adam Barth  <abarth@webkit.org>
1483
1484         Reviewed by Darin Adler.
1485
1486         style-queue complains about one-line macros that include multiple statements
1487         https://bugs.webkit.org/show_bug.cgi?id=33173
1488
1489         Add an exception for multiple statements on a line that starts a macro.
1490
1491         * Scripts/webkitpy/style/cpp_style.py:
1492         * Scripts/webkitpy/style/cpp_style_unittest.py:
1493
1494 2010-01-17  Adam Barth  <abarth@webkit.org>
1495
1496         Reviewed by Darin Adler.
1497
1498         [check-webkit-style] qt unit testing false positives
1499         https://bugs.webkit.org/show_bug.cgi?id=32833
1500
1501         Exempt the Qt API and unit tests from the style checker.
1502
1503         * Scripts/webkitpy/style/cpp_style.py:
1504         * Scripts/webkitpy/style/cpp_style_unittest.py:
1505
1506 2010-01-17  Adam Barth  <abarth@webkit.org>
1507
1508         Reviewed by Darin Adler.
1509
1510         style-check script reports loads of errors on gtk2drawing.c
1511         https://bugs.webkit.org/show_bug.cgi?id=33771
1512
1513         Exempt WebCore/platform/gtk/gtk2drawing.c and
1514         WebCore/platform/gtk/gtk2drawing.h from style checks.
1515
1516         * Scripts/webkitpy/style/cpp_style.py:
1517         * Scripts/webkitpy/style/cpp_style_unittest.py:
1518
1519 2010-01-17  Chris Jerdonek  <cjerdonek@webkit.org>
1520
1521         Reviewed by Shinichiro Hamaji.
1522
1523         Finished eliminating _cpp_style_state global state variable from
1524         check-webkit-style code and eliminating _CppStyleState class.
1525
1526         https://bugs.webkit.org/show_bug.cgi?id=33764
1527
1528         * Scripts/webkitpy/style/checker.py:
1529           - Minor updates caused by changes to cpp_style.py.
1530
1531         * Scripts/webkitpy/style/cpp_style.py:
1532           - Removed _CppStyleState class.
1533           - Removed verbose_level functions.
1534           - Added verbosity as a parameter to _FunctionState constructor.
1535           - Added verbosity as a parameter to process_file().
1536           - Added verbosity as a parameter to process_file_data().
1537
1538         * Scripts/webkitpy/style/cpp_style_unittest.py:
1539           - Added helper functions to set verbosity while running tests.
1540
1541 2010-01-17  Adam Barth  <abarth@webkit.org>
1542
1543         Reviewed by Shinichiro Hamaji.
1544
1545         check-webkit-style underscore check should be disabled for Qt methods starting with qt_
1546         https://bugs.webkit.org/show_bug.cgi?id=33663
1547
1548         * Scripts/webkitpy/style/cpp_style.py:
1549         * Scripts/webkitpy/style/cpp_style_unittest.py:
1550
1551 2010-01-17  Adam Barth  <abarth@webkit.org>
1552
1553         Reviewed by Eric Seidel.
1554
1555         style-queue complains about missing #include of config.h for non-WebCore projects
1556         https://bugs.webkit.org/show_bug.cgi?id=33170
1557
1558         WebKitAPITests are consumers of the WebKit API and therefore do not
1559         need to follow the same include discipline as the rest of WebKit.  This
1560         patch exempts them from the include checks.
1561
1562         * Scripts/webkitpy/style/cpp_style.py:
1563         * Scripts/webkitpy/style/cpp_style_unittest.py:
1564
1565 2010-01-17  Adam Barth  <abarth@webkit.org>
1566
1567         Reviewed by Eric Seidel.
1568
1569         EWS (Early Warning Systems) should build both debug and release
1570         https://bugs.webkit.org/show_bug.cgi?id=33681
1571
1572         Build both debug and release for chromium-ews.
1573
1574         * Scripts/webkitpy/commands/early_warning_system.py:
1575
1576 2010-01-17  Adam Barth  <abarth@webkit.org>
1577
1578         Reviewed by Darin Adler.
1579
1580         style-queue should include instructions for how to file bugs against check-webkit-style
1581         https://bugs.webkit.org/show_bug.cgi?id=32345
1582
1583         Added some text to the error message asking folks to file bugs against
1584         false positives.
1585
1586         * Scripts/webkitpy/commands/queues.py:
1587
1588 2010-01-17  Chris Jerdonek  <cjerdonek@webkit.org>
1589
1590         Reviewed by Adam Barth.
1591
1592         Eliminated the error_count global variable and related
1593         check-webkit-style refactoring.
1594
1595         https://bugs.webkit.org/show_bug.cgi?id=33678
1596
1597         * Scripts/check-webkit-style:
1598           - Updated to use webkit_argument_defaults().
1599           - Renamed styleChecker to style_checker.
1600
1601         * Scripts/webkitpy/style/checker.py:
1602           - Prefixed the three default arguments with WEBKIT_DEFAULT.
1603           - Added webkit_argument_defaults().
1604           - Added default filter_rules parameter to CategoryFilter constructor.
1605           - Added __ne__() to CategoryFilter class.
1606           - Added __eq__() and __ne__() to ProcessorOptions class.
1607           - Added error_count and _write_error attributes to StyleChecker class.
1608           - Made StyleChecker._handle_error() increment the error count.
1609
1610         * Scripts/webkitpy/style/checker_unittest.py:
1611           - Improved CategoryFilterTest.test_eq().
1612           - Added CategoryFilterTest.test_ne().
1613           - Added test_eq() and test_ne() to ProcessorOptionsTest class.
1614           - Updated unit tests to use webkit_argument_defaults().
1615           - Added StyleCheckerTest class.
1616
1617         * Scripts/webkitpy/style/cpp_style.py:
1618           - Removed references to global error_count.
1619
1620         * Scripts/webkitpy/style/cpp_style_unittest.py:
1621           - Removed CppStyleStateTest class.
1622
1623 2010-01-15  Jon Honeycutt  <jhoneycutt@apple.com>
1624
1625         get_accParent should try to retrieve parent AccessibilityObject, before
1626         calling upon window
1627
1628         https://bugs.webkit.org/show_bug.cgi?id=22893
1629
1630         Reviewed by Darin Adler.
1631
1632         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1633         (AccessibilityUIElement::parentElement):
1634         Get the object's parent. Query it for IAccessible, and return it.
1635
1636 2010-01-16  Dan Bernstein  <mitz@apple.com>
1637
1638         Reviewed by Mark Rowe.
1639
1640         <rdar://problem/7529519> DumpRenderTree crashes in makeLargeMallocFailSilently()
1641
1642         * DumpRenderTree/mac/CheckedMalloc.cpp:
1643         (makeLargeMallocFailSilently): Temporarily allow writing to the default
1644         malloc zone structure while modifying it.
1645
1646 2010-01-16  David Kilzer  <ddkilzer@apple.com>
1647
1648         Added back removed properties to iExploder input files
1649
1650         While the update-iexploder-cssproperties script works great to
1651         add new properties, it has the side-effect of removing old
1652         properties that once were parsed.
1653
1654         * iExploder/htdocs/cssproperties.in: Added back removed
1655         properties into their own section.
1656         * iExploder/htdocs/htmlattrs.in: Ditto.
1657
1658 2010-01-16  Holger Hans Peter Freyther  <zecke@selfish.org>
1659
1660         Reviewed by David Kilzer.
1661
1662         Update iExploder/htdocs/*.in by running update-iexploder-cssproperties
1663         https://bugs.webkit.org/show_bug.cgi?id=33756
1664
1665         * iExploder/htdocs/cssproperties.in: New CSS attributes
1666         * iExploder/htdocs/htmlattrs.in: New HTML attributes
1667         * iExploder/htdocs/htmltags.in: New HTML tags
1668
1669 2010-01-15  Chris Jerdonek  <chris.jerdonek@gmail.com>
1670
1671         Reviewed by David Kilzer.
1672
1673         Altered parseDiffHeader() to skip unrecognized lines and
1674         other minor clean-ups.
1675
1676         https://bugs.webkit.org/show_bug.cgi?id=33476
1677
1678         * Scripts/VCSUtils.pm:
1679           - Changed parseDiffHeader() as follows:
1680             - Skips over unrecognized lines.
1681             - Addressed FIXME to remove substitution for "diff" line.
1682             - Renamed "version" header hash key to "sourceRevision".
1683             - Eliminated "copiedFromVersion" header hash key.
1684             - Included "sourceRevision" also for copied files.
1685             - Checks that copy revision number matches "sourceRevision".
1686             - No longer returns $foundHeaderEnding.
1687             - Dies if header ending not found.
1688             - Diff header dividing line now always added.
1689
1690         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
1691           - Made necessary changes in parseDiffHeader() unit tests.
1692           - Shortened the file paths in some test cases.
1693
1694 2010-01-14  Yuzo Fujishima  <yuzo@google.com>
1695
1696         Reviewed by Alexey Proskuryakov.
1697
1698         Update pywebsocket to 0.4.6
1699         https://bugs.webkit.org/show_bug.cgi?id=32299
1700         The newer pywebsocket can handle more simultaneous connections.
1701
1702         * pywebsocket/mod_pywebsocket/handshake.py:
1703         * pywebsocket/mod_pywebsocket/standalone.py:
1704         * pywebsocket/setup.py:
1705         * pywebsocket/test/test_handshake.py:
1706
1707 2010-01-14  Eric Seidel  <eric@webkit.org>
1708
1709         Reviewed by Adam Barth.
1710
1711         REGRESSION(53133): commit-queue no longer rejects patches with invalid committers, instead it hangs
1712         https://bugs.webkit.org/show_bug.cgi?id=33638
1713
1714         * Scripts/webkitpy/bugzilla.py:
1715          - Add Bug.id() to match Attachment.id()
1716          - Give Bug.reviewed_patches and commit_queued_patches the option to return patches with invalid committers/reviewers.
1717          - Add back a missing variable to _validate_setter_email found by the new unit tests!
1718         * Scripts/webkitpy/commands/queries.py:
1719          - Add FIXMEs about the commands being confusingly named.
1720         * Scripts/webkitpy/commands/queries_unittest.py:
1721          - Update results to reflect the newly restructured mock bug cache.
1722         * Scripts/webkitpy/commands/queues.py:
1723          - Add a new _validate_patches_in_commit_queue method (this is what fixes the regression).
1724          - Add a FIXME about eventually sorting the patches into some order.
1725         * Scripts/webkitpy/commands/queues_unittest.py:
1726          - Update results now that with the newly restructure mock bug cache we're testing cq+'d patches with an invalid committer.
1727         * Scripts/webkitpy/commands/upload_unittest.py:
1728          - Update results to match the newly restructured mock bug cache.
1729         * Scripts/webkitpy/mock_bugzillatool.py:
1730          - Restructure fetch_ methods to not use a manual list of ids, but rather use Bug and Attachment classes to make real queries from all of the Bugs.
1731          - Add a few more attachments and bug dictionaries for use by the tests.
1732
1733 2010-01-13  Diego Gonzalez  <diego.gonzalez@openbossa.org>
1734
1735         Reviewed by Kenneth Christiansen.
1736
1737         [Qt] DRT missing setUserStyleSheetLocation and setUserStyleSheetEnabled in LayoutTestController
1738         https://bugs.webkit.org/show_bug.cgi?id=33617
1739
1740         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1741         (WebCore::WebPage::resetSettings):
1742         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1743         (LayoutTestController::setUserStyleSheetLocation):
1744         (LayoutTestController::setUserStyleSheetEnabled):
1745         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1746
1747 2010-01-14  Adam Roben  <aroben@apple.com>
1748
1749         Add LayoutTestController API to force
1750         -webView:resource:willSendRequest:: to return null
1751
1752         Enables tests for <rdar://problem/7533333> <http://webkit.org/b/33533>
1753         window.onload never fires if page contains an <iframe> with a bad
1754         scheme or whose load is cancelled by returning null from resource load
1755         delegate's willSendRequest
1756
1757         Reviewed by Brady Eidson.
1758
1759         * DumpRenderTree/LayoutTestController.cpp:
1760         (LayoutTestController::LayoutTestController): Initialize new member.
1761         (setWillSendRequestReturnsNullCallback): Call through to
1762         LayoutTestController.
1763         (LayoutTestController::staticFunctions): Added new function.
1764
1765         * DumpRenderTree/LayoutTestController.h: Added
1766         m_willSendRequestReturnsNull.
1767         (LayoutTestController::willSendRequestReturnsNull):
1768         (LayoutTestController::setWillSendRequestReturnsNull):
1769         Added standard accessors.
1770
1771         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1772         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1773         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1774         (ResourceLoadDelegate::willSendRequest):
1775         Return null if LayoutTestController says to.
1776
1777 2010-01-14  Kevin Ollivier  <kevino@theolliviers.com>
1778
1779         [wx] Build fix after removal of XBM support.
1780
1781         * wx/build/settings.py:
1782
1783 2010-01-14  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1784
1785         Reviewed by Simon Hausmann.
1786
1787         Add support for partial building on Symbian.
1788
1789         The build happens in the source directory as out of source builds are
1790         not supported by qmake for Symbian.
1791
1792         Also the actual build isn't started but it is left to the developer
1793         to choose the architecture/configuration.
1794
1795         * Scripts/webkitdirs.pm:
1796
1797 2010-01-14  Simon Hausmann  <simon.hausmann@nokia.com>
1798
1799         Reviewed by Kenneth Rohde Christiansen.
1800
1801         Add support for "detecting" Symbian environments by either
1802         looking for the EPOCROOT environment variable or via --symbian
1803         being passed on the commandline.
1804
1805         * Scripts/webkitdirs.pm:
1806
1807 2010-01-14  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1808
1809         Unreviewed.
1810
1811         [Qt] Use a different Makefile names for sources generation and compilation.
1812         This prevents Makefile overwriting when running build-webkit twice.
1813
1814         * Scripts/webkitdirs.pm:
1815
1816 2010-01-14  Andreas Kling  <andreas.kling@nokia.com>
1817
1818         Reviewed by Kenneth Rohde Christiansen.
1819
1820         [Qt] Add an "alien_QLabel" classId for manual testing of alien widgets.
1821
1822         https://bugs.webkit.org/show_bug.cgi?id=33373
1823
1824         * QtLauncher/main.cpp:
1825         (WebPage::createPlugin):
1826
1827 2010-01-14  Eric Seidel  <eric@webkit.org>
1828
1829         No review, rolling out r53249.
1830         http://trac.webkit.org/changeset/53249
1831         https://bugs.webkit.org/show_bug.cgi?id=33617
1832
1833         This caused http/tests/security/local-user-CSS-from-
1834         remote.html to fail on the Qt Release Build Bot.
1835
1836         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1837         (WebCore::WebPage::resetSettings):
1838         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1839         (LayoutTestController::overridePreference):
1840         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1841
1842 2010-01-14  Chris Jerdonek  <chris.jerdonek@gmail.com>
1843
1844         Reviewed by Shinichiro Hamaji.
1845
1846         Moved error() from cpp_style.py to checker.py.
1847
1848         https://bugs.webkit.org/show_bug.cgi?id=33620
1849
1850         * Scripts/check-webkit-style:
1851           - Addressed FIXME to not set global state.
1852
1853         * Scripts/webkitpy/style/checker.py:
1854           - Added argument validation to ProcessorOptions constructor.
1855           - Added should_report_error() to ProcessorOptions class.
1856           - Removed set_options().
1857           - Added StyleChecker class.
1858
1859         * Scripts/webkitpy/style/checker_unittest.py:
1860           - Added unit test class for ProcessorOptions class.
1861           - Added unit test to check that parse() strips white space.
1862
1863         * Scripts/webkitpy/style/cpp_style.py:
1864           - Removed "filter" and "output_format" methods.
1865           - Removed should_print_error() and error() functions.
1866           - Removed default parameter value from process_file().
1867
1868         * Scripts/webkitpy/style/cpp_style_unittest.py:
1869           - Removed call to cpp_style._should_print_error().
1870           - Removed test_filter() and test_filter_appending().
1871
1872         * Scripts/webkitpy/style/text_style.py:
1873           - Removed default parameter value from process_file().
1874
1875 2010-01-14  Diego Gonzalez  <diego.gonzalez@openbossa.org>
1876
1877         Reviewed by Kenneth Rohde Christiansen.
1878
1879         [Qt] DRT missing setUserStyleSheetLocation and setUserStyleSheetEnabled in LayoutTestController
1880         https://bugs.webkit.org/show_bug.cgi?id=33617
1881
1882         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1883         (WebCore::WebPage::resetSettings):
1884         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1885         (LayoutTestController::setUserStyleSheetLocation):
1886         (LayoutTestController::setUserStyleSheetEnabled):
1887         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1888
1889 2010-01-13  Adam Barth  <abarth@webkit.org>
1890
1891         Reviewed by Eric Seidel.
1892
1893         Fix CloseBugForLandDiff unittest to actually run
1894         https://bugs.webkit.org/show_bug.cgi?id=33640
1895
1896         * Scripts/webkitpy/mock_bugzillatool.py:
1897         * Scripts/webkitpy/steps/closebugforlanddiff_unittest.py:
1898
1899 2010-01-12  Jon Honeycutt  <jhoneycutt@apple.com>
1900
1901         MSAA: selected, selectable, extended selectable, and multiple
1902         selectable states are not reported
1903
1904         https://bugs.webkit.org/show_bug.cgi?id=33574
1905         <rdar://problem/7536826>
1906
1907         Reviewed by Darin Adler.
1908
1909         * DumpRenderTree/AccessibilityUIElement.cpp:
1910         (getIsSelectableCallback):
1911         Return the result of calling isSelectable().
1912         (getIsMultiSelectableCallback):
1913         Return the result of calling isMultiSelectable().
1914         (AccessibilityUIElement::getJSClass):
1915         Add isSelected and isMultiSelectable properties to the JSClass
1916         definition.
1917
1918         * DumpRenderTree/AccessibilityUIElement.h:
1919         Declare isSelectable() and isMultiSelectable().
1920
1921         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1922         (AccessibilityUIElement::isSelectable):
1923         Stubbed.
1924         (AccessibilityUIElement::isMultiSelectable):
1925         Stubbed.
1926
1927         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1928         (AccessibilityUIElement::isSelectable):
1929         Stubbed.
1930         (AccessibilityUIElement::isMultiSelectable):
1931         Stubbed.
1932
1933         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1934         (accessibilityState):
1935         Get the object's state, and return it.
1936         (AccessibilityUIElement::isSelected):
1937         Check the object's selected state.
1938         (AccessibilityUIElement::isSelectable):
1939         Check the object's selectable state.
1940         (AccessibilityUIElement::isMultiSelectable):
1941         Check the object's extended/multiple selectable state.
1942
1943 2010-01-13  Adam Barth  <abarth@webkit.org>
1944
1945         Unreviewed.  Repeat the below for CloseBugForLandDiff.
1946
1947         * Scripts/test-webkitpy:
1948         * Scripts/webkitpy/steps/closebugforlanddiff.py:
1949         * Scripts/webkitpy/steps/closebugforlanddiff_unittest.py: Added.
1950
1951 2010-01-13  Adam Barth  <abarth@webkit.org>
1952
1953         Unreviewed.  Turn the mac-ews status bubbles back on now that this bot
1954         is running again.
1955
1956         * QueueStatusServer/templates/statusbubble.html:
1957
1958 2010-01-13  Adam Barth  <abarth@webkit.org>
1959
1960         Reviewed by Darin Adler.
1961
1962         REGRESSION(53133): webkit-patch land dies if it can't find a bug id.
1963         https://bugs.webkit.org/show_bug.cgi?id=33634
1964
1965         Deal with the case of no bug patch object in the state.
1966
1967         * Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py:
1968         * Scripts/webkitpy/steps/updatechangelogswithreviewer.py:
1969
1970 2010-01-13  Kenneth Russell  <kbr@google.com>
1971
1972         Unreviewed; added myself to the committers list.
1973
1974         * Scripts/webkitpy/committers.py:
1975
1976 2010-01-13  Darin Adler  <darin@apple.com>
1977
1978         Ignore compiled Python in more of webkitpy.
1979
1980         * Scripts/webkitpy/commands: Added property svn:ignore.
1981         * Scripts/webkitpy/steps: Added property svn:ignore.
1982         * Scripts/webkitpy/style: Added property svn:ignore.
1983
1984 2010-01-13  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1985
1986         Reviewed by Simon Hausmann.
1987
1988         [Qt] Fix build problem related to the pushd command
1989
1990         * Scripts/webkitdirs.pm:
1991
1992 2010-01-13  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1993
1994         Reviewed by Simon Hausmann.
1995
1996         [Qt] Split the build process in two different .pro files.
1997         This allows qmake to be run once all source files are available.
1998
1999         * Scripts/webkitdirs.pm: Add calls to make DerivedSources.pro in JSC and WC.
2000
2001 2010-01-13  Shinichiro Hamaji  <hamaji@chromium.org>
2002
2003         Unreviewed tiny typo fix in docstrings.
2004
2005         * Scripts/webkitpy/style/checker_unittest.py:
2006
2007 2010-01-13  Chris Jerdonek  <chris.jerdonek@gmail.com>
2008
2009         Reviewed by Shinichiro Hamaji.
2010
2011         Created a CategoryFilter class to encapsulate the logic of
2012         filter rules.
2013
2014         https://bugs.webkit.org/show_bug.cgi?id=33454
2015
2016         * Scripts/webkitpy/style/checker.py:
2017           - Added CategoryFilter class.
2018
2019         * Scripts/webkitpy/style/checker_unittest.py:
2020           - Added CategoryFilter unit tests.
2021
2022         * Scripts/webkitpy/style/cpp_style.py:
2023           - Updated filter methods to use CategoryFilter.
2024
2025         * Scripts/webkitpy/style/cpp_style_unittest.py:
2026           - Updated references to filters.
2027
2028 2010-01-12  Shinichiro Hamaji  <hamaji@chromium.org>
2029
2030         Unreviewed. Now I can review :)
2031
2032         * Scripts/webkitpy/committers.py:
2033
2034 2010-01-12  Brent Fulgham  <bfulgham@webkit.org>
2035
2036         Reviewed by Darin Adler.
2037
2038         Extend WinLauncher example with better printing features.
2039
2040         * WinLauncher/PrintWebUIDelegate.cpp:
2041         (PrintWebUIDelegate::webViewPrintingMarginRect): Provide slightly
2042          larger margins.
2043         (PrintWebUIDelegate::webViewHeaderHeight): Compute header height based
2044          on text metrics.
2045         (PrintWebUIDelegate::webViewFooterHeight): Compute footer height based
2046          on text metrics.
2047         (PrintWebUIDelegate::drawHeaderInRect): Write useful header, along
2048          with separating line.
2049         (PrintWebUIDelegate::drawFooterInRect):
2050         * WinLauncher/PrintWebUIDelegate.h: Remove stubs.
2051         * WinLauncher/WinLauncher.cpp:
2052         (PrintView): Correct loop used to print individual pages.
2053          Previously it started at 0, which is a wild-card to print all
2054          pages at once.
2055
2056 2010-01-12  Alexey Proskuryakov  <ap@apple.com>
2057
2058         Reviewed by Darin Adler.
2059
2060         https://bugs.webkit.org/show_bug.cgi?id=33540
2061         Make it possible to build in debug mode with assertions disabled
2062
2063         * DumpRenderTree/mac/ObjCController.m: (-[ObjCController accessStoredWebScriptObject]):
2064
2065 2010-01-11  Darin Fisher  <darin@chromium.org>
2066
2067         Reviewed by Dimitri Glazkov.
2068
2069         [Chromium] "build-webkit --chromium" should run "make all" on Linux
2070         https://bugs.webkit.org/show_bug.cgi?id=33500
2071
2072         * Scripts/webkitdirs.pm:
2073
2074 2010-01-12  Eric Seidel  <eric@webkit.org>
2075
2076         Reviewed by Adam Barth.
2077
2078         AssignToCommitter does not need to fetch bugs twice
2079         https://bugs.webkit.org/show_bug.cgi?id=33530
2080
2081         This is a no-brainer patch now that we've added Bug.reviewed_patches
2082
2083         * Scripts/webkitpy/commands/upload.py:
2084
2085 2010-01-12  Eric Seidel  <eric@webkit.org>
2086
2087         Reviewed by Adam Barth.
2088
2089         bugzilla.py should have an Attachment object instead of passing around dictionaries
2090         https://bugs.webkit.org/show_bug.cgi?id=31594
2091
2092         * Scripts/webkitpy/bugzilla.py:
2093          - Add a new Attachment class, with accessor methods for all the necessary properties.
2094          - Update Bug to carry a pointer back to bugzilla (attachments need to access Bugzilla for committer validation and url())
2095          - Move reviewed_patches and commit_queued_patches out of Bugzilla custom methods and onto Bug
2096          - Move committer validation logic into its own class.
2097          - Committer rejection is only used in one place.  Make the new Bug reviewed_patches and commit_queued_patches
2098            handle the common case (of returning "reviewer" or "committer" as None), and let CommitterValidation handle
2099            the case where we want to reject patches in bugzilla.
2100          - Simplify fetch_patches_from_commit_queue now that committer validation is simpler.
2101          - Make all self.bugzilla.fetch_bug access go through BugzillaQueries._fetch_bug.
2102          - Mark set_flag_on_attachment as non-private to denote that CommitterValidation depends on it.
2103          - Move fetch_reviewed_patches_from_bug and fetch_commit_queue_patches_from_bug logic onto the Bug class.
2104         * Scripts/webkitpy/bugzilla_unittest.py:
2105          - Move test_flag_permission_rejection_message into a new CommitterValidationTest class.
2106         * Scripts/webkitpy/commands/download.py:
2107          - Store "bug_id" in state instead of making a fake patch object.
2108          - Update to use Attachment and Bug objects.
2109         * Scripts/webkitpy/commands/download_unittest.py:
2110          - Update expected results now that our testing framework covers more code.
2111         * Scripts/webkitpy/commands/early_warning_system.py: Update to use new Attachment class.
2112         * Scripts/webkitpy/commands/queries.py: Remove unused ReviewedPatches class.
2113         * Scripts/webkitpy/commands/queries_unittest.py: ditto.
2114         * Scripts/webkitpy/commands/queues.py: Update to use new Attachment and CommitterValidator classes.
2115         * Scripts/webkitpy/commands/queuestest.py: ditto.
2116         * Scripts/webkitpy/commands/upload.py: ditto.
2117         * Scripts/webkitpy/mock_bugzillatool.py:
2118          - Now that more logic has moved into Attachment and Bug, we have to actually
2119            provide real reviewer emails as well as real reviewer flags.
2120          - Update mock methods to return Attachment objects.
2121         * Scripts/webkitpy/scm.py: Update to use Attachment class.
2122         * Scripts/webkitpy/scm_unittest.py: Update to use Attachment class.
2123         * Scripts/webkitpy/statusserver.py: ditto.
2124         * Scripts/webkitpy/steps/applypatch.py: ditto.
2125         * Scripts/webkitpy/steps/applypatchwithlocalcommit.py: ditto.
2126         * Scripts/webkitpy/steps/closebug.py: ditto.
2127         * Scripts/webkitpy/steps/closebugforlanddiff.py: Handle either state["bug_id"] or state["patch"].bug_id()
2128         * Scripts/webkitpy/steps/closepatch.py: Update to use Attachment class.
2129         * Scripts/webkitpy/steps/obsoletepatches.py: ditto.
2130         * Scripts/webkitpy/steps/updatechangelogswithreviewer.py: ditto.
2131
2132 2010-01-12  Adam Barth  <abarth@webkit.org>
2133
2134         Unreviewed typo fix.  :(
2135
2136         * Scripts/webkitpy/commands/early_warning_system.py:
2137         * Scripts/webkitpy/commands/queues.py:
2138
2139 2010-01-12  Adam Barth  <abarth@webkit.org>
2140
2141         Unreviewed.  Add "error" to the right part of the message.
2142
2143         * Scripts/webkitpy/commands/queues.py:
2144
2145 2010-01-12  Adam Barth  <abarth@webkit.org>
2146
2147         Reviewed by Eric Seidel.
2148
2149         EWS should show purple when svn-apply fails
2150         https://bugs.webkit.org/show_bug.cgi?id=33527
2151
2152         * Scripts/webkitpy/commands/early_warning_system.py:
2153         * Scripts/webkitpy/commands/queues.py:
2154
2155 2010-01-12  Adam Barth  <abarth@webkit.org>
2156
2157         Reviewed by Eric Seidel.
2158
2159         Remove copy/paste code from subclasses of AbstractReviewQueue
2160         https://bugs.webkit.org/show_bug.cgi?id=33525
2161
2162         * Scripts/webkitpy/commands/early_warning_system.py:
2163         * Scripts/webkitpy/commands/queues.py:
2164
2165 2010-01-12  Adam Barth  <abarth@webkit.org>
2166
2167         Reviewed by Eric Seidel.
2168
2169         Add Gustavo and Xan as gtk-ews watchers
2170         https://bugs.webkit.org/show_bug.cgi?id=33519
2171
2172         * Scripts/webkitpy/commands/early_warning_system.py:
2173
2174 2010-01-12  Adam Barth  <abarth@webkit.org>
2175
2176         Reviewed by Eric Seidel.
2177
2178         webkit-patch shouldn't waste my time for with a component prompt
2179         https://bugs.webkit.org/show_bug.cgi?id=33521
2180
2181         The component field isn't very useful for bugs created with
2182         webkit-patch because they're likely to be resolved quickly.  Instead of
2183         always prompting for a component, we should just default to the "New
2184         Bugs" component.  If the bug stays around for more than five minutes,
2185         we can assign it a proper component.
2186
2187         * Scripts/webkitpy/bugzilla.py:
2188
2189 2010-01-12  Adam Barth  <abarth@webkit.org>
2190
2191         Reviewed by Eric Seidel.
2192
2193         Add experimental "land-safely" command to webkit-patch
2194         https://bugs.webkit.org/show_bug.cgi?id=33518
2195
2196         * Scripts/webkitpy/commands/upload.py:
2197         * Scripts/webkitpy/commands/upload_unittest.py:
2198         * Scripts/webkitpy/steps/__init__.py:
2199         * Scripts/webkitpy/steps/postdiffforcommit.py: Added.
2200
2201 2010-01-11  Kevin Ollivier  <kevino@theolliviers.com>
2202
2203         [wx] Build fix after introduction of JS_NO_EXPORT
2204
2205         * wx/build/settings.py:
2206
2207 2010-01-11  Eric Seidel  <eric@webkit.org>
2208
2209         No review, rolling out r53079.
2210         http://trac.webkit.org/changeset/53079
2211         https://bugs.webkit.org/show_bug.cgi?id=33197
2212
2213         Adam doens't think this actually works, and believe it caused
2214         a regression https://bugs.webkit.org/show_bug.cgi?id=33488 so
2215         rolling this out.
2216
2217         * Scripts/test-webkitpy:
2218         * Scripts/webkitpy/commands/abstractdiffcommand.py: Removed.
2219         * Scripts/webkitpy/commands/abstractdiffcommand_unittest.py: Removed.
2220         * Scripts/webkitpy/commands/download.py:
2221         * Scripts/webkitpy/commands/upload.py:
2222         * Scripts/webkitpy/mock_bugzillatool.py:
2223
2224 2010-01-10  Adam Barth  <abarth@webkit.org>
2225
2226         Reviewed by David Kilzer.
2227
2228         bugzilla-tool submit-patch mistakenly picks up bug URLs in non-ChangeLog files
2229         https://bugs.webkit.org/show_bug.cgi?id=33197
2230
2231         We should just search for bug numbers in the ChangeLogs instead of in
2232         the whole diff.
2233
2234         * Scripts/test-webkitpy:
2235         * Scripts/webkitpy/commands/abstractdiffcommand.py: Added.
2236         * Scripts/webkitpy/commands/abstractdiffcommand_unittest.py: Added.
2237         * Scripts/webkitpy/commands/download.py:
2238         * Scripts/webkitpy/commands/upload.py:
2239         * Scripts/webkitpy/mock_bugzillatool.py:
2240
2241 2010-01-11  Chris Jerdonek  <chris.jerdonek@gmail.com>
2242
2243         Reviewed by David Kilzer.
2244
2245         Created a unit-tested function to parse the header block of
2246         a Git or SVN diff -- for future refactoring of svn-apply and
2247         svn-unapply.
2248
2249         https://bugs.webkit.org/show_bug.cgi?id=33447
2250
2251         * Scripts/VCSUtils.pm:
2252           - Added parseDiffHeader().
2253           - Removed irrelevant comment from gitdiff2svndiff().
2254
2255         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl: Added.
2256           - Added 48 unit tests for parseDiffHeader().
2257
2258 2010-01-10  Adam Barth  <abarth@webkit.org>
2259
2260         Rubber stamped by David Kilzer.
2261
2262         bugzilla-tool submit-patch mistakenly picks up bug URLs in non-ChangeLog files
2263         https://bugs.webkit.org/show_bug.cgi?id=33197
2264
2265         Fix a typo: Commmand -> Command.
2266
2267         * Scripts/webkitpy/commands/abstractsequencedcommand.py:
2268         * Scripts/webkitpy/commands/download.py:
2269         * Scripts/webkitpy/commands/queries.py:
2270         * Scripts/webkitpy/commands/upload.py:
2271         * Scripts/webkitpy/multicommandtool.py:
2272
2273 2010-01-10  Adam Barth  <abarth@webkit.org>
2274
2275         Reviewed by Darin Adler.
2276
2277         Let webkit-patch work with options in $EDITOR
2278         https://bugs.webkit.org/show_bug.cgi?id=33414
2279
2280         The $EDITOR evironment variable might have command line options like
2281         bbedit -w.  This patch lets us run those $EDITORs.
2282
2283         * Scripts/webkitpy/user.py:
2284
2285 2010-01-10  Robert Hogan  <robert@roberthogan.net>
2286
2287         Reviewed by Adam Barth.
2288
2289         [Qt] Add enableXSSAuditor support to QWebSettings and DRT.
2290
2291         https://bugs.webkit.org/show_bug.cgi?id=33419
2292
2293         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2294         (WebCore::WebPage::WebPage):
2295         (WebCore::WebPage::resetSettings):
2296         (WebCore::DumpRenderTree::createWindow):
2297         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2298         (LayoutTestController::setXSSAuditorEnabled):
2299         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2300
2301 2010-01-10  Adam Barth  <abarth@webkit.org>
2302
2303         Unreviewed cosmetic change.  Remove the status bubble for mac-ews
2304         because we don't have hardware for it at the moment.
2305
2306         * QueueStatusServer/templates/statusbubble.html:
2307
2308 2010-01-09  Daniel Bates  <dbates@webkit.org>
2309
2310         No review, rolling out r53044.
2311         http://trac.webkit.org/changeset/53044
2312         https://bugs.webkit.org/show_bug.cgi?id=33419
2313
2314         We need to look into this some more because the Qt
2315         bot is failing the XSSAuditor tests. See bug #33419
2316         for more details.
2317
2318         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2319         (WebCore::WebPage::WebPage):
2320         (WebCore::WebPage::resetSettings):
2321         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2322         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2323
2324 2010-01-09  Daniel Bates  <dbates@webkit.org>
2325
2326         Reviewed by Adam Barth.
2327
2328         https://bugs.webkit.org/show_bug.cgi?id=33419
2329
2330         Adds support for the XSSAuditor to the Qt DRT.
2331
2332         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2333         (WebCore::WebPage::WebPage):
2334         (WebCore::WebPage::resetSettings):
2335         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2336         (LayoutTestController::setXSSAuditorEnabled):
2337         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2338
2339 2010-01-09  Adam Barth  <abarth@webkit.org>
2340
2341         Reviewed by Eric Seidel.
2342
2343         Retry writes to QueueStatusServer when we get 500 errors
2344         https://bugs.webkit.org/show_bug.cgi?id=33412
2345
2346         This prevents the queues from failing to mark a patch as "pass" or
2347         "fail" when AppEngine throws 500 errors.
2348
2349         * Scripts/test-webkitpy:
2350         * Scripts/webkitpy/networktransaction.py: Added.
2351         * Scripts/webkitpy/networktransaction_unittest.py: Added.
2352         * Scripts/webkitpy/statusserver.py:
2353         * Scripts/webkitpy/steps/closebugformarkbugfixed.py: Added.
2354         * Scripts/webkitpy/steps/closebugregardlessofpatches.py: Added.
2355         * Scripts/webkitpy/steps/findbugidfromsvnrevision.py: Added.
2356
2357 2010-01-09  David Kilzer  <ddkilzer@apple.com>
2358
2359         <http://webkit.org/b/33430> Fix rounded borders in queue status on older Firefox and Safari browsers
2360
2361         Reviewed by Eric Seidel.
2362
2363         * QueueStatusServer/templates/statusbubble.html: Added
2364         -moz-border-radius and -webkit-border-radius to provide rounded
2365         borders in older Firefox and Safari browsers.
2366
2367 2010-01-09  Chris Jerdonek  <chris.jerdonek@gmail.com>
2368
2369         Reviewed by David Kilzer.
2370
2371         Modified VCSUtils::gitdiff2svndiff() to accept strings that
2372         end in vertical white space.
2373
2374         https://bugs.webkit.org/show_bug.cgi?id=33415
2375
2376         * Scripts/VCSUtils.pm:
2377         * Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl:
2378
2379 2010-01-08  Eric Seidel  <eric@webkit.org>
2380
2381         Reviewed by Adam Barth.
2382
2383         run-javascriptcore-tests needs a --quiet flag
2384         https://bugs.webkit.org/show_bug.cgi?id=33399
2385
2386         Until run-javascriptcore-tests has a --quiet flag, lets just stiffle the output in webkit-patch.
2387
2388         * Scripts/webkitpy/steps/runtests.py:
2389
2390 2010-01-08  Andras Becsi  <abecsi@inf.u-szeged.hu>
2391
2392         Reviewed by Alexey Proskuryakov.
2393
2394         Only run http and websocket tests as last if no argument is given to be able to explicitly control the test order.
2395
2396         To be able to run multiple instances of run-webkit-tests besides each other on the same machine we need to minimize
2397         the time when Apache and WebSocketServer is locked by tests.
2398         Because closeHTTPD() and closeWebSocketServer() is only called at the end of the testing,
2399         we need to run http and websocket tests after all other tests.
2400         If one however explicitly specifies the tests to run in the argument list of run-webkit-tests
2401         we need to preserve the given order.
2402
2403         * Scripts/run-webkit-tests:
2404
2405 2010-01-08  Adam Barth  <abarth@webkit.org>
2406
2407         Reviewed by Eric Seidel.
2408
2409         Don't post style-queue pass messages to bugs
2410         https://bugs.webkit.org/show_bug.cgi?id=33404
2411
2412         These messages aren't needed any more now that we have the status
2413         bubble reporting pass events passively.
2414
2415         * Scripts/webkitpy/commands/queues.py:
2416
2417 2010-01-08  Adam Barth  <abarth@webkit.org>
2418
2419         Reviewed by Eric Seidel.
2420
2421         Optimize the number of CPUs used for building Qt and Gtk
2422         https://bugs.webkit.org/show_bug.cgi?id=33394
2423
2424         Instead of hardcoding the number 8, we should read the number of CPUs
2425         from the environment.
2426
2427         * Scripts/webkitpy/executive.py:
2428         * Scripts/webkitpy/webkitport.py:
2429         * Scripts/webkitpy/webkitport_unittest.py:
2430
2431 2010-01-08  Chris Fleizach  <cfleizach@apple.com>
2432
2433         Reviewed by Eric Seidel.
2434
2435         REGRESSION(52819?): AXLoadComplete and AXLayoutComplete causes 4 tests fail on Snow Leopard Debug bot
2436         https://bugs.webkit.org/show_bug.cgi?id=33300
2437
2438         * DumpRenderTree/AccessibilityUIElement.h:
2439         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2440         (AccessibilityUIElement::AccessibilityUIElement):
2441         (AccessibilityUIElement::~AccessibilityUIElement):
2442         (_accessibilityNotificationCallback):
2443         (AccessibilityUIElement::addNotificationListener):
2444
2445 2010-01-08  Eric Seidel  <eric@webkit.org>
2446
2447         Reviewed by Simon Hausmann.
2448
2449         commit-queue should run run-javascriptcore-tests
2450         https://bugs.webkit.org/show_bug.cgi?id=33376
2451
2452         I also made it run the python and perl unit tests.
2453
2454         * Scripts/webkitpy/steps/runtests.py:
2455         * Scripts/webkitpy/webkitport.py:
2456
2457 2010-01-07  Andras Becsi  <abecsi@inf.u-szeged.hu>
2458
2459         Reviewed by Darin Adler.
2460
2461         Run the http and websocket tests after all other tests.
2462         https://bugs.webkit.org/show_bug.cgi?id=33153
2463
2464         * Scripts/run-webkit-tests:
2465
2466 2010-01-07  Adam Barth  <abarth@webkit.org>
2467
2468         Reviewed by Eric Seidel.
2469
2470         Fix some test-webkitpy expectations
2471         https://bugs.webkit.org/show_bug.cgi?id=33345
2472
2473         I forgot to change these when I added the CheckStyle step.
2474
2475         * Scripts/webkitpy/commands/upload_unittest.py:
2476
2477 2010-01-07  Adam Barth  <abarth@webkit.org>
2478
2479         Reviewed by Eric Seidel.
2480
2481         webkit-patch edit-changelogs (or upload) will open blank files if run outside the root
2482         https://bugs.webkit.org/show_bug.cgi?id=33341
2483
2484         Fix this by moving to the root directory before editing ChangeLogs.
2485         There is a related bug with CheckStyle.
2486
2487         * Scripts/webkitpy/steps/checkstyle.py:
2488         * Scripts/webkitpy/steps/editchangelog.py:
2489
2490 2010-01-07  Eric Seidel  <eric@webkit.org>
2491
2492         Reviewed by Nikolas Zimmermann.
2493
2494         media/unsupported-tracks.html is failing on Snow Leopard Release bot
2495         https://bugs.webkit.org/show_bug.cgi?id=32339
2496
2497         This is a speculative fix.  I do not have a Snow Leopard machine to test on
2498         and I've not seen mention of someone being able to reproduce this locally.
2499
2500         Prevent watchdog timer from firing after a test completes but before
2501         the next one starts, causing the error to appear in the next test.
2502
2503         * DumpRenderTree/mac/DumpRenderTree.mm:
2504         (dump): Stop the watchdog before printing #EOF for the test content.
2505         We only need to care about the JavaScript of the test running too long
2506         or some hang in WebCore.  Any other failures will be covered by the calling
2507         script's own watchdog timer.
2508
2509 2010-01-07  Eric Seidel  <eric@webkit.org>
2510
2511         Reviewed by Adam Barth.
2512
2513         commit-queue is stuck spinning due to exception
2514         https://bugs.webkit.org/show_bug.cgi?id=33358
2515
2516         * Scripts/webkitpy/commands/queues.py:
2517          - Don't try to stringify the exception.
2518
2519 2010-01-07  Mark Rowe  <mrowe@apple.com>
2520
2521         Reviewed by Jon Honeycutt.
2522
2523         Don't leak a JSStringRef within _accessibilityNotificationCallback.
2524
2525         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2526         (_accessibilityNotificationCallback): Have a JSRetainPtr adopt the JSStringRef so that it will be cleaned up
2527         when it goes out of scope.
2528
2529 2010-01-07  Simon Fraser  <simon.fraser@apple.com>
2530
2531         Reviewed by Darin Adler.
2532
2533         Add proposed rename of HTMLPlugInImageElement to HTMLEmbeddedObjectElement.
2534
2535         * Scripts/do-webcore-rename:
2536
2537 2010-01-07  Kim Grönholm  <kim.gronholm@nomovok.com>
2538
2539         Reviewed by Antti Koivisto.
2540
2541         Wrong state and TouchLists in TouchEvents
2542         https://bugs.webkit.org/show_bug.cgi?id=32878
2543
2544         * DumpRenderTree/qt/EventSenderQt.cpp:
2545         (EventSender::touchStart):
2546         (EventSender::touchEnd):
2547         (EventSender::clearTouchPoints):
2548         * DumpRenderTree/qt/EventSenderQt.h:
2549
2550 2010-01-07  Chris Jerdonek  <chris.jerdonek@gmail.com>
2551
2552         Reviewed by Adam Barth.
2553
2554         Created a module that runs the style package unit tests.
2555
2556         https://bugs.webkit.org/show_bug.cgi?id=32973
2557
2558         * Scripts/test-webkitpy:
2559         * Scripts/webkitpy/style/unittests.py: Added.
2560
2561 2010-01-07  Adam Barth  <abarth@webkit.org>
2562
2563         Reviewed by Maciej Stachowiak.
2564
2565         Don't print a redundant message when confirming a diff
2566         https://bugs.webkit.org/show_bug.cgi?id=33315
2567
2568         Instead of saying "ERROR: User declined" we should just exit because
2569         the use knows they just declined!
2570
2571         * Scripts/webkitpy/steps/confirmdiff.py:
2572
2573 2010-01-07  Adam Barth  <abarth@webkit.org>
2574
2575         Reviewed by Maciej Stachowiak.
2576
2577         Check style before uploading a patch
2578         https://bugs.webkit.org/show_bug.cgi?id=33314
2579
2580         * Scripts/webkitpy/commands/upload.py:
2581         * Scripts/webkitpy/steps/checkstyle.py:
2582         * Scripts/webkitpy/steps/options.py:
2583
2584 2010-01-07  Adam Barth  <abarth@webkit.org>
2585
2586         Reviewed by Maciej Stachowiak.
2587
2588         Add prepare and post to webkit-patch main help
2589         https://bugs.webkit.org/show_bug.cgi?id=33313
2590
2591         * Scripts/webkitpy/commands/upload.py:
2592
2593 2010-01-07  Eric Seidel  <eric@webkit.org>
2594
2595         Reviewed by Adam Barth.
2596
2597         Add Chromium bots to the list of "core builders" (builders which stop the commit-queue when they turn red)
2598         https://bugs.webkit.org/show_bug.cgi?id=33290
2599
2600         Add the Chromium builders to our list of core builders and test that our regexps work.
2601         I also updated our regexp testing to make sure we cover all known builders at build.webkit.org.
2602
2603         * Scripts/webkitpy/buildbot.py:
2604         * Scripts/webkitpy/buildbot_unittest.py:
2605
2606 2010-01-07  Adam Barth  <abarth@webkit.org>
2607
2608         Reviewed by Eric Seidel.
2609
2610         bugzilla-tool needs a new name
2611         https://bugs.webkit.org/show_bug.cgi?id=28459
2612
2613         Rename bugzilla-tool to webkit-patch.  Also, rename some commands to
2614         make more sense with the new name.
2615
2616         * Scripts/bugzilla-tool: Removed.
2617         * Scripts/webkit-patch: Added.
2618         * Scripts/webkit-tools-completion.sh:
2619         * Scripts/webkitpy/bugzilla_unittest.py:
2620         * Scripts/webkitpy/commands/download.py:
2621         * Scripts/webkitpy/commands/download_unittest.py:
2622         * Scripts/webkitpy/commands/early_warning_system.py:
2623         * Scripts/webkitpy/commands/queries.py:
2624         * Scripts/webkitpy/commands/queues.py:
2625         * Scripts/webkitpy/commands/queues_unittest.py:
2626         * Scripts/webkitpy/commands/upload.py:
2627         * Scripts/webkitpy/commands/upload_unittest.py:
2628         * Scripts/webkitpy/queueengine.py:
2629         * Scripts/webkitpy/steps/completerollout.py:
2630
2631 2010-01-07  Chris Jerdonek  <chris.jerdonek@gmail.com>
2632
2633         Reviewed by Eric Seidel.
2634
2635         Moved style-related modules to webkitpy.style sub-package.
2636
2637         https://bugs.webkit.org/show_bug.cgi?id=32971
2638
2639         * Scripts/check-webkit-style:
2640           - Updated import statement.
2641
2642         * Scripts/test-webkitpy:
2643           - Updated import statements.
2644
2645         * Scripts/webkitpy/cpp_style.py: Removed.
2646           - Moved to webkitpy/style.
2647
2648         * Scripts/webkitpy/cpp_style_unittest.py: Removed.
2649           - Moved to webkitpy/style.
2650
2651         * Scripts/webkitpy/style.py: Removed.
2652           - Moved to webkitpy/style/checker.py.
2653
2654         * Scripts/webkitpy/style/__init__.py: Added.
2655           - Added containing webkitpy directory to package search path.
2656
2657         * Scripts/webkitpy/style/checker.py: Copied from Scripts/webkitpy/style.py.
2658         * Scripts/webkitpy/style/checker_unittest.py: Copied from Scripts/webkitpy/style_unittest.py.
2659           - Updated import statement.
2660
2661         * Scripts/webkitpy/style/cpp_style.py: Copied from Scripts/webkitpy/cpp_style.py.
2662         * Scripts/webkitpy/style/cpp_style_unittest.py: Copied from Scripts/webkitpy/cpp_style_unittest.py.
2663           - Update import statement.
2664
2665         * Scripts/webkitpy/style/text_style.py: Copied from Scripts/webkitpy/text_style.py.
2666         * Scripts/webkitpy/style/text_style_unittest.py: Copied from Scripts/webkitpy/text_style_unittest.py.
2667         * Scripts/webkitpy/style_unittest.py: Removed.
2668           - Moved to webkitpy/style/checker_unittest.py.
2669
2670         * Scripts/webkitpy/text_style.py: Removed.
2671           - Moved to webkitpy/style.
2672
2673         * Scripts/webkitpy/text_style_unittest.py: Removed.
2674           - Moved to webkitpy/style.
2675
2676 2010-01-06  Kinuko Yasuda  <kinuko@chromium.org>
2677
2678         Reviewed by Eric Seidel.
2679
2680         [Qt] Support the 3rd argument of EventSender.keyDown that
2681         has been recently added to report keyLocation
2682         (see also: https://bugs.webkit.org/show_bug.cgi?id=28247).
2683         https://bugs.webkit.org/show_bug.cgi?id=33250
2684
2685         Test: fast/events/keydown-numpad-keys.html
2686
2687         * DumpRenderTree/qt/EventSenderQt.cpp:
2688         (EventSender::keyDown):
2689         * DumpRenderTree/qt/EventSenderQt.h:
2690
2691 2010-01-06  Eric Seidel  <eric@webkit.org>
2692
2693         Reviewed by Adam Barth.
2694
2695         Add long_help for all common commands.
2696         https://bugs.webkit.org/show_bug.cgi?id=33261
2697
2698         For now these long_helps are pretty basic.
2699         These were all written to just explain the steps
2700         that each command runs.  This style long_help could
2701         be made easier by using:
2702         https://bugs.webkit.org/show_bug.cgi?id=33257
2703
2704         * Scripts/webkitpy/commands/download.py:
2705         * Scripts/webkitpy/commands/queries.py:
2706
2707 2010-01-06  Diego Gonzalez  <diego.gonzalez@openbossa.org>
2708
2709         Reviewed by Kenneth Christiansen.
2710
2711         [Qt] Add page zooming support to Qt DumpRenderTree
2712         https://bugs.webkit.org/show_bug.cgi?id=32898
2713
2714         Patch by Kim Grönholm  <kim.gronholm@nomovok.com>,
2715                  Diego Gonzalez <diego.gonzalez@openbossa.org> and
2716                  Afonso Costa <afonso.costa@openbossa.org>
2717
2718         * DumpRenderTree/qt/EventSenderQt.cpp:
2719         (EventSender::zoomPageIn):
2720         (EventSender::zoomPageOut):
2721         * DumpRenderTree/qt/EventSenderQt.h:
2722
2723 2010-01-06  Eric Seidel  <eric@webkit.org>
2724
2725         No review, just adding Mike Belshe's new bugzilla email at his request.
2726
2727         * Scripts/webkitpy/committers.py:
2728
2729 2010-01-06  Eric Seidel  <eric@webkit.org>
2730
2731         Unreviewed.  Rolling out r52869 and r52853 due to bot
2732         and local run-webkit-test failures
2733
2734         REGRESSION(52854?) fast/workers/shared-worker-constructor.html failed on Leopard Build Bot
2735         https://bugs.webkit.org/show_bug.cgi?id=33256
2736
2737         The original bug was https://bugs.webkit.org/show_bug.cgi?id=33153
2738
2739         * Scripts/run-webkit-tests:
2740
2741 2010-01-06  Eric Seidel  <eric@webkit.org>
2742
2743         Unreviewed "build" fix.  Just adding missing include.
2744
2745         bugzilla-tool rollout --complete-rollout should make a nicer bug comment
2746         https://bugs.webkit.org/show_bug.cgi?id=29212
2747
2748         * Scripts/webkitpy/steps/completerollout.py:
2749
2750 2010-01-06  Eric Seidel  <eric@webkit.org>
2751
2752         Reviewed by Adam Barth.
2753
2754         bugzilla-tool rollout --complete-rollout should make a nicer bug comment
2755         https://bugs.webkit.org/show_bug.cgi?id=29212
2756
2757         * Scripts/webkitpy/bugzilla.py:
2758          - Make reopen_bug robust against the bug already being open.
2759         * Scripts/webkitpy/commands/download.py:
2760          - Remove dead code from Rollout.
2761         * Scripts/webkitpy/steps/completerollout.py:
2762          - Improve the rollout comment.
2763
2764 2010-01-06  Andras Becsi  <abecsi@inf.u-szeged.hu>
2765
2766         Reviewed by Darin Adler.
2767
2768         Set isHttpdOpen to 0 if pidfile does not exist for some reason.
2769         Speculative fix for https://bugs.webkit.org/show_bug.cgi?id=33256.
2770
2771         * Scripts/run-webkit-tests:
2772
2773 2010-01-06  Andras Becsi  <abecsi@inf.u-szeged.hu>
2774
2775         Reviewed by Darin Adler.
2776
2777         Change hardcoded /tmp in run-webkit-tests to File::Spec->tmpdir(),
2778         and remove the httpd's pidfile directory if httpd terminated.
2779
2780         * Scripts/run-webkit-tests:
2781
2782 2010-01-05  Chris Jerdonek  <chris.jerdonek@gmail.com>
2783
2784         Reviewed by David Levin.
2785
2786         Refactored check-webkit-style's argument parser to not rely
2787         on global state, and improved its error handling and unit
2788         test coverage.
2789
2790         https://bugs.webkit.org/show_bug.cgi?id=32966
2791
2792         * Scripts/check-webkit-style:
2793           - Adjusted to use new argument parser.
2794
2795         * Scripts/webkitpy/cpp_style.py:
2796           - Changed _CppStyleState to accept an array of filter rules
2797             instead of a comma-delimited string.
2798           - Eliminated cpp_style._DEFAULT_FILTER_RULES.
2799           - Eliminated cpp_style._USAGE.
2800
2801         * Scripts/webkitpy/cpp_style_unittest.py:
2802           - Updated test_filter() and test_default_filter().
2803
2804         * Scripts/webkitpy/style.py:
2805           - Converted style._USAGE to create_usage().
2806           - Corrected usage instructions by removing 0 as a valid
2807             --verbose flag value.
2808           - Removed use_webkit_styles().
2809           - Added ProcessorOptions class.
2810           - Added ArgumentDefaults class.
2811           - Added ArgumentPrinter class.
2812           - Removed parse_arguments and added ArgumentParser class.
2813           - Moved exit_with_usage() and exit_with_categories() into
2814             ArgumentParser.
2815           - Refactored parse_arguments() as ArgumentParser.parse().
2816           - Improved parser error handling.
2817
2818         * Scripts/webkitpy/style_unittest.py:
2819           - Added DefaultArgumentsTest class.
2820           - Addressed FIXME to check style.WEBKIT_FILTER_RULES
2821             against style.STYLE_CATEGORIES.
2822           - Added ArgumentPrinterTest class.
2823           - Added ArgumentParserTest class and rewrote parser unit tests.
2824
2825 2010-01-05  Adam Roben  <aroben@apple.com>
2826
2827         Test that it's safe to call IWebView::close when
2828         IWebView::initWithFrame hasn't been called
2829
2830         Part of <http://webkit.org/b/32827> Crash when calling
2831         IWebView::close, then releasing the WebView, without calling
2832         DestroyWindow
2833
2834         Reviewed by Steve Falkenburg.
2835
2836         * WebKitAPITest/tests/WebViewDestruction.cpp:
2837         (WebKitAPITest::CloseWithoutInitWithFrame): Calls IWebView::close
2838         without ever calling IWebView::initWithFrame and tests that we don't
2839         crash or leak.
2840
2841 2010-01-05  Adam Roben  <aroben@apple.com>
2842
2843         Add more WebViewDestruction tests
2844
2845         Fixes <http://webkit.org/b/33216>.
2846
2847         Reviewed by Eric Seidel.
2848
2849         * WebKitAPITest/tests/WebViewDestruction.cpp:
2850         (WebKitAPITest::NoInitWithFrame):
2851         (WebKitAPITest::CloseThenDestroyViewWindow):
2852         (WebKitAPITest::DestroyViewWindowThenClose):
2853         (WebKitAPITest::DestroyHostWindow):
2854         (WebKitAPITest::DestroyHostWindowThenClose):
2855         (WebKitAPITest::CloseThenDestroyHostWindow):
2856         Added these tests that exercise tearing down a WebView in various
2857         ways, all of which we eventually want to have work. Some of them
2858         currently crash or leak.
2859
2860 2010-01-05  Robert Hogan  <robert@roberthogan.net>
2861
2862         Reviewed by Eric Seidel.
2863
2864         [Qt] fix DRT link failures on --no-svg builds when only making changes to DRT
2865
2866         If you're working from a --minimal or --no-svg build and make changes to the
2867         DRT, then recompile, the build will fail.
2868
2869         This is because the current behavior at build time is to assume that the
2870         previous Qt build supported SVG and consequently delete libQtWebKit.so.
2871         Unfortunately, just deleting libQtWebKit.so will not cause the library to
2872         re-link. Instead the build will see libQtWebKit.so.4 and co., pass over the
2873         linking phase, and attempt to link the DRT with libQtWebKit.so absent. This
2874         results in a link failure on the DRT.
2875
2876         Since re-linking libQtWebKit can take up to ten minutes and should be avoided
2877         in cases where not actually required, remove the assumption that
2878         the previous Qt build supported SVG, and amend the symbol detection to look for
2879         a symbol name that is not present in SVG builds. Currently webkitdirs.pm looks
2880         for 'SVGElement' but even non-SVG builds contain the symbol 'isSVGElement'.
2881
2882         https://bugs.webkit.org/show_bug.cgi?id=32992
2883
2884         * Scripts/webkitdirs.pm:
2885
2886 2010-01-05  Chris Jerdonek  <chris.jerdonek@gmail.com>
2887
2888         Reviewed by David Kilzer.
2889
2890         Switched to generating list of Perl unit test files dynamically,
2891         instead of explicitly.
2892
2893         https://bugs.webkit.org/show_bug.cgi?id=33200
2894
2895         * Scripts/test-webkitperl:
2896
2897 2010-01-05  Yael Aharon  <yael.aharon@nokia.com>
2898
2899         Reviewed by Kenneth Rohde Christiansen.
2900
2901         [Qt] Reimplement EventSender::leapForward
2902         https://bugs.webkit.org/show_bug.cgi?id=33114
2903
2904         Follow Windows implementation of leapForward. When leapForward is called,
2905         messages are queued and posted after the timeout. A new event loop is created to
2906         handle those messages and the additional messages that are created as a result.
2907
2908         * DumpRenderTree/qt/DumpRenderTree.pro:
2909         * DumpRenderTree/qt/EventSenderQt.cpp:
2910         (EventSender::EventSender):
2911         (EventSender::mouseDown):
2912         (EventSender::mouseUp):
2913         (EventSender::mouseMoveTo):
2914         (EventSender::leapForward):
2915         (EventSender::sendOrQueueEvent):
2916         (EventSender::replaySavedEvents):
2917         (EventSender::eventFilter):
2918         * DumpRenderTree/qt/EventSenderQt.h:
2919
2920 2010-01-05  Adam Barth  <abarth@webkit.org>
2921
2922         Reviewed by Darin Adler.
2923
2924         Fix obscure queue crash in queueengine
2925         https://bugs.webkit.org/show_bug.cgi?id=33196
2926
2927         Sometimes we get an exception that can't be stringified.  For example:
2928
2929         AttributeError: 'ParseError' object has no attribute 'msg'
2930
2931         In these cases, the whole queue dies because we're in the global
2932         exception handler.  Instead of dieing here, we should just print a less
2933         informative message to the console.  We're already printing the whole
2934         backtrace anyway, so there's not much point to stringifying the
2935         exception anyway.
2936
2937         * Scripts/webkitpy/queueengine.py:
2938
2939 2010-01-05  Dominic Mazzoni  <dmazzoni@google.com>
2940
2941         Reviewed by Darin Adler.
2942
2943         https://bugs.webkit.org/show_bug.cgi?id=32571
2944
2945         For an object with an aria role of "checkbox" or "radiobutton",
2946         use the "aria-checked" attribute to determine if it's checked.
2947         These changes add an isChecked() method to AccessibilityUIElement
2948         so that we can check for this property from a layout test.
2949
2950         * DumpRenderTree/AccessibilityUIElement.cpp:
2951         (getIsCheckedCallback):
2952         (AccessibilityUIElement::getJSClass):
2953         * DumpRenderTree/AccessibilityUIElement.h:
2954         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2955         (AccessibilityUIElement::isChecked):
2956         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2957         (AccessibilityUIElement::isChecked):
2958         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2959         (AccessibilityUIElement::isChecked):
2960
2961 2010-01-05  David Levin  <levin@chromium.org>
2962
2963         Reviewed by Darin Adler.
2964
2965         Having a comment for the #endif for a header guard is not required WebKit style.
2966         https://bugs.webkit.org/show_bug.cgi?id=33214
2967
2968         * Scripts/webkitpy/cpp_style.py: removed the check and made the loop exit
2969           early when it has all the needed information to continue.
2970         * Scripts/webkitpy/cpp_style_unittest.py: removed the corresponding tests.
2971
2972 2010-01-05  Adam Roben  <aroben@apple.com>
2973
2974         Share more code in the WebViewDestruction tests
2975
2976         Part of <http://webkit.org/b/33212> Small fixes/improvements to
2977         WebKitAPITest
2978
2979         Reviewed by Sam Weinig.
2980
2981         * WebKitAPITest/tests/WebViewDestruction.cpp:
2982         (WebKitAPITest::createAndInitializeWebView): Renamed from
2983         createWebView. Now initializes the HostWindow and returns the
2984         WebView's HWND via an out-parameter.
2985         (WebKitAPITest::finishWebViewDestructionTest): Added. Code came from
2986         the CloseWithoutDestroyWindow test.
2987         (WebKitAPITest::CloseWithoutDestroyViewWindow): Renamed from
2988         CloseWithoutDestroyWindow and changed to use the new functions.
2989         (WebKitAPITest::MainFrameAfterClose): Changed to use the new
2990         functions.
2991         (WebKitAPITest::NoCloseOrDestroyViewWindow): Renamed from
2992         NoCloseOrDestroyWindow and changed to use the new functions.
2993
2994 2010-01-05  Adam Roben  <aroben@apple.com>
2995
2996         Don't show HostWindows by default
2997
2998         This was making WebKitAPITest very flashy as windows appeared and
2999         disappeared.
3000
3001         Part of <http://webkit.org/b/33212> Small fixes/improvements to
3002         WebKitAPITest
3003
3004         Reviewed by Sam Weinig.
3005
3006         * WebKitAPITest/HostWindow.cpp:
3007         (WebKitAPITest::HostWindow::initialize): Removed the WS_VISIBLE style
3008         from the window.
3009
3010 2010-01-05  Adam Roben  <aroben@apple.com>
3011
3012         Don't hang in WebKitAPITest if no messages have been posted
3013
3014         Part of <http://webkit.org/b/33212> Small fixes/improvements to
3015         WebKitAPITest
3016
3017         Reviewed by Sam Weinig.
3018
3019         * WebKitAPITest/tests/WebViewDestruction.cpp:
3020         (WebKitAPITest::runMessagePump): Use PeekMessage instead of GetMessage
3021         to avoid hanging if no messages have been posted.
3022
3023 2010-01-05  Adam Roben  <aroben@apple.com>
3024
3025         Fix WebKitCreateInstance helper
3026
3027         Part of <http://webkit.org/b/33212> Small fixes/improvements to
3028         WebKitAPITest
3029
3030         Reviewed by Sam Weinig.
3031
3032         * WebKitAPITest/tests/WebViewDestruction.cpp:
3033         (WebKitAPITest::WebKitCreateInstance): Pass the pointer straight
3034         through, instead of taking its address.
3035
3036 2010-01-04  Maciej Stachowiak  <mjs@apple.com>
3037
3038         Reviewed by Darin Fisher.
3039
3040         Reorganize, document and rename OS() platform macros.
3041         https://bugs.webkit.org/show_bug.cgi?id=33198
3042
3043         Adapt to name changes.
3044
3045         * DumpRenderTree/DumpRenderTree.h:
3046         * DumpRenderTree/config.h:
3047
3048 2010-01-05  Chris Jerdonek  <chris.jerdonek@gmail.com>
3049
3050         Reviewed by Eric Seidel.
3051
3052         Minor improvements to test-webkit-scripts, as suggested
3053         by an earlier review.
3054
3055         https://bugs.webkit.org/show_bug.cgi?id=33125
3056
3057         * Scripts/test-webkit-scripts:
3058           - Used OptionParser class instead of getopt.getopt().
3059           - Created main() method for __main__ block.
3060           - Enclosed functions in a class.
3061
3062 2010-01-05  Chris Fleizach  <cfleizach@apple.com>
3063
3064         No review. Fix DRT breakage on Tiger/Leopard.
3065
3066         Add ARIA "Live Region" support
3067         https://bugs.webkit.org/show_bug.cgi?id=33117
3068
3069         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3070
3071 2010-01-04  Chris Fleizach  <cfleizach@apple.com>
3072
3073         Reviewed by Darin Adler.
3074
3075         Add ARIA "Live Region" support
3076         https://bugs.webkit.org/show_bug.cgi?id=33117
3077
3078         * DumpRenderTree/AccessibilityUIElement.cpp:
3079         (indexOfChildCallback):
3080         (boolAttributeValueCallback):
3081         (stringAttributeValueCallback):
3082         (addNotificationListenerCallback):
3083         (AccessibilityUIElement::getJSClass):
3084         * DumpRenderTree/AccessibilityUIElement.h:
3085         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3086         (AccessibilityUIElement::indexOfChild):
3087         (AccessibilityUIElement::stringAttributeValue):
3088         (AccessibilityUIElement::boolAttributeValue):
3089         (AccessibilityUIElement::addNotificationListener):
3090         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3091         (AccessibilityUIElement::indexOfChild):
3092         (AccessibilityUIElement::stringAttributeValue):
3093         (AccessibilityUIElement::boolAttributeValue):
3094         (_accessibilityNotificationCallback):
3095         (AccessibilityUIElement::addNotificationListener):
3096         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3097         (AccessibilityUIElement::indexOfChild):
3098         (AccessibilityUIElement::stringAttributeValue):
3099         (AccessibilityUIElement::boolAttributeValue):
3100         (AccessibilityUIElement::addNotificationListener):
3101
3102 2010-01-04  Eric Seidel  <eric@webkit.org>
3103
3104         Reviewed by Adam Barth.
3105
3106         bugzilla-tool rollout should require a reason
3107         https://bugs.webkit.org/show_bug.cgi?id=30810
3108
3109         * Scripts/webkitpy/changelogs.py: Add support for a reason, add auto-wrapping logic.
3110         * Scripts/webkitpy/changelogs_unittest.py: Test reason support.
3111         * Scripts/webkitpy/commands/download.py: rollout now requires a reason, remove unused BUGID argument
3112         * Scripts/webkitpy/commands/download_unittest.py: pass required reason
3113         * Scripts/webkitpy/steps/preparechangelogforrevert.py: pass reason to update_for_revert
3114
3115 2010-01-04  Jon Honeycutt  <jhoneycutt@apple.com>
3116
3117         MSAA: <select> elements should broadcast value change events
3118
3119         https://bugs.webkit.org/show_bug.cgi?id=33088
3120
3121         <rdar://problem/7332364>
3122
3123         Reviewed by Darin Adler.
3124
3125         * DumpRenderTree/AccessibilityController.cpp:
3126         (logValueChangeEventsCallback):
3127         Start logging value change events.
3128         (AccessibilityController::getJSClass):
3129         Add a "logValueChangeEvents" to the AccessibilityController's JS class
3130         definition.
3131         (AccessibilityController::resetToConsistentState):
3132         Disable logging of value change events.
3133
3134         * DumpRenderTree/AccessibilityController.h:
3135         Declare setLogValueChangeEvents(), and add a member variable for the
3136         value change event hook.
3137
3138         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3139         (AccessibilityController::setLogValueChangeEvents):
3140         Stubbed.
3141
3142         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3143         (AccessibilityController::setLogValueChangeEvents):
3144         Stubbed.
3145
3146         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3147         (AccessibilityController::AccessibilityController):
3148         Initialize new member var.
3149         (AccessibilityController::~AccessibilityController):
3150         Disable logging of value change events.
3151         (logEventProc):
3152         When we receive an EVENT_OBJECT_VALUECHANGE, log the name of the object
3153         and its value.
3154         (AccessibilityController::setLogValueChangeEvents):
3155         If disabling logging, unhook the event, and clear the event hook
3156         member var. Otherwise, query for the root element to enable
3157         accessibility, and hook EVENT_OBJECT_VALUECHANGE.
3158
3159 2010-01-04  Adam Barth  <abarth@webkit.org>
3160
3161         Reviewed by Eric Seidel.
3162
3163         long_help for submit-patch
3164         https://bugs.webkit.org/show_bug.cgi?id=33184
3165
3166         * Scripts/webkitpy/commands/upload.py:
3167
3168 2010-01-04  Adam Barth  <abarth@webkit.org>
3169
3170         Reviewed by Eric Seidel.
3171
3172         commit-queue can wrongly reject patches if the buildbots are behind
3173         https://bugs.webkit.org/show_bug.cgi?id=30098
3174
3175         Check to make sure we can currently build and test before trying to
3176         land a patch.
3177
3178         * Scripts/webkitpy/commands/queues.py:
3179
3180 2010-01-04  Adam Roben  <aroben@apple.com>
3181
3182         Add a test harness for the Windows WebKit API, and a few tests
3183
3184         We currently only have tests for a handful of bugs regarding WebView
3185         destruction, but more tests can easily be added later. Eventually
3186         we'll run these tests as part of run-webkit-tests.
3187
3188         Fixes <http://webkit.org/b/33167>.
3189
3190         Reviewed by Sam Weinig.
3191
3192         * WebKitAPITest/HostWindow.cpp: Added.
3193         (WebKitAPITest::HostWindow::HostWindow): Initialize m_window.
3194         (WebKitAPITest::HostWindow::~HostWindow): Destroy our window if
3195         needed.
3196         (WebKitAPITest::HostWindow::initialize): Create our window.
3197         (WebKitAPITest::HostWindow::clientRect): Return our window's client
3198         rect.
3199         (WebKitAPITest::HostWindow::registerWindowClass): Does what it says.
3200         (WebKitAPITest::HostWindow::wndProc): Just call through to
3201         DefWindowProcW.
3202
3203         * WebKitAPITest/HostWindow.h: Added.
3204         (WebKitAPITest::HostWindow::window): Simple getter.
3205
3206         * WebKitAPITest/Test.h: Added. This file defines some macros useful
3207         for writing tests.
3208
3209         * WebKitAPITest/TestsController.cpp: Added.
3210         (WebKitAPITest::TestsController::TestsController): Initialize our
3211         members.
3212         (WebKitAPITest::TestsController::shared): Return the shared instance.
3213         (WebKitAPITest::TestsController::runAllTests): Run a message pump
3214         until a WM_QUIT message is received, then return whether all tests
3215         succeeded.
3216         (WebKitAPITest::TestsController::addTest): Add the test to m_tests and
3217         start running tests soon.
3218         (WebKitAPITest::TestsController::testFailed): Record the failure and
3219         print a message about it to stdout.
3220         (WebKitAPITest::TestsController::runNextTest): If we don't have any
3221         tests to run, post a WM_QUIT message to stop the message pump.
3222         Otherwise, run the test and print whether it passed, then schedule the
3223         next test.
3224         (WebKitAPITest::TestsController::runNextTestSoon): Set a 0-delay timer
3225         to run the next test.
3226         (WebKitAPITest::TestsController::registerWindowClass): Does what it
3227         says.
3228         (WebKitAPITest::TestsController::wndProc): If the runNextTestTimer
3229         fired, call runNextTest(). Pass everything else through to
3230         DefWindowProcW.
3231
3232         * WebKitAPITest/TestsController.h: Added.
3233
3234         * WebKitAPITest/WebKitAPITest.vcproj: Added.
3235
3236         * WebKitAPITest/WebKitAPITestCommon.vsprops: Added.
3237
3238         * WebKitAPITest/main.cpp: Added.
3239         (main): (Mostly) just calls TestsController::runAllTests.
3240
3241         * WebKitAPITest/tests/WebViewDestruction.cpp: Added.
3242         (WebKitAPITest::WebKitCreateInstance): Helper function template to
3243         call through to the real WebKitCreateInstance.
3244         (WebKitAPITest::webViewCount): Helper function to call through to
3245         IWebKitStatistics::webViewCount.
3246         (WebKitAPITest::createWebView): Helper function to create a WebView
3247         and put it inside a HostWindow.
3248         (WebKitAPITest::runMessagePump): Helper function to run a message pump
3249         for a specified number of milliseconds, or until a WM_QUIT message is
3250         received.
3251         (WebKitAPITest::CloseWithoutDestroyWindow): Test for
3252         <http://webkit.org/b/32827>.
3253         (WebKitAPITest::MainFrameAfterClose): Test for
3254         <http://webkit.org/b/32868>.
3255         (WebKitAPITest::NoCloseOrDestroyWindow): Test for
3256         <http://webkit.org/b/33162>.
3257
3258 2010-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3259
3260         Reviewed by David Kilzer.
3261
3262         Add support for Git's "diff.mnemonicprefix" config option to WebKitTools
3263
3264         https://bugs.webkit.org/show_bug.cgi?id=32820
3265
3266         * Scripts/VCSUtils.pm:
3267         * Scripts/svn-apply:
3268         * Scripts/svn-unapply:
3269         * Scripts/test-webkitperl: Run gitdiff2svndiff test
3270         * Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl: Added.
3271         * Scripts/webkitpy/diff_parser.py:
3272         * Scripts/webkitpy/diff_parser_unittest.py:
3273
3274 2010-01-04  Chris Jerdonek  <chris.jerdonek@gmail.com>
3275
3276         Reviewed by David Kilzer.
3277
3278         Divided the Perl unit tests into separate files and put
3279         them in a separate directory, and renamed test-webkit-perl
3280         to test-webkitperl.
3281
3282         https://bugs.webkit.org/show_bug.cgi?id=33124
3283
3284         * Scripts/VCSUtils.pm:
3285           - Renamed generateRunPatchCommand() to generatePatchCommand().
3286
3287         * Scripts/VCSUtils_unittest.pl: Removed.
3288           - Divided into three files in Scripts/webkitperl/VCSUtils_unittest.
3289
3290         * Scripts/test-webkit-perl: Removed.
3291           - Renamed to test-webkitperl.
3292
3293         * Scripts/test-webkit-scripts:
3294           - Updated paths to test-webkitpy and test-webkitperl.
3295
3296         * Scripts/test-webkitperl: Copied from Scripts/test-webkit-perl.
3297           - Added paths to new test files.
3298
3299         * Scripts/webkitperl: Added.
3300         * Scripts/webkitperl/VCSUtils_unittest: Added.
3301         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl: Added.
3302         * Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl: Added.
3303         * Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl: Copied from Scripts/VCSUtils_unittest.pl.
3304
3305 2010-01-04  Eric Seidel  <eric@webkit.org>
3306
3307         Reviewed by Adam Barth.
3308
3309         Make bugzilla-tool rollout include a bug link in the ChangeLog entry
3310         https://bugs.webkit.org/show_bug.cgi?id=33146
3311
3312         One more step towards better rollouts.
3313
3314         * Scripts/webkitpy/changelogs.py:
3315         * Scripts/webkitpy/changelogs_unittest.py:
3316         * Scripts/webkitpy/steps/preparechangelogforrevert.py:
3317
3318 2010-01-04  Adam Barth  <abarth@webkit.org>
3319
3320         Reviewed by Eric Seidel.
3321
3322         Sort the step options
3323         https://bugs.webkit.org/show_bug.cgi?id=33144
3324
3325         * Scripts/webkitpy/steps/options.py:
3326
3327 2010-01-04  Eric Seidel  <eric@webkit.org>
3328
3329         Reviewed by Adam Barth.
3330
3331         Need support for longer text in per-command help
3332         https://bugs.webkit.org/show_bug.cgi?id=33143
3333
3334         Add some minimal additional help to land-diff and
3335         pave the way for adding better help to all commands.
3336
3337         * Scripts/webkitpy/commands/download.py: Add small amount of additional help to land-diff
3338         * Scripts/webkitpy/multicommandtool.py: support long_help
3339         * Scripts/webkitpy/multicommandtool_unittest.py: test long_help
3340
3341 2010-01-04  Adam Barth  <abarth@webkit.org>
3342
3343         Reviewed by Eric Seidel.
3344
3345         Add unit test for MarkBugFixed
3346         https://bugs.webkit.org/show_bug.cgi?id=33142
3347
3348         MarkBugFixed is way behind in command technology, but it still needs a
3349         unit test, as the FIXME commands.
3350
3351         Also, remove mark-bug-fixed and create-bug from main help since we have
3352         more modern commands to replace them.
3353
3354         * Scripts/webkitpy/commands/upload.py:
3355         * Scripts/webkitpy/commands/upload_unittest.py:
3356         * Scripts/webkitpy/mock_bugzillatool.py:
3357
3358 2010-01-04  Adam Barth  <abarth@webkit.org>
3359
3360         Reviewed by Eric Seidel.
3361
3362         Add missing unit test for CommitMessageForCurrentDiff
3363         https://bugs.webkit.org/show_bug.cgi?id=33141
3364
3365         * Scripts/webkitpy/commands/upload.py:
3366         * Scripts/webkitpy/commands/upload_unittest.py:
3367
3368 2010-01-04  Adam Barth  <abarth@webkit.org>
3369
3370         Reviewed by Eric Seidel.
3371
3372         Remove raw_input from queues in favor of user.prompt
3373         https://bugs.webkit.org/show_bug.cgi?id=33140
3374
3375         This lets up properly mock out the user interaction instead of hacking
3376         around it with the options.
3377
3378         * Scripts/webkitpy/commands/queues.py:
3379         * Scripts/webkitpy/commands/queuestest.py:
3380
3381 2010-01-04  Eric Seidel  <eric@webkit.org>
3382
3383         Reviewed by Adam Barth.
3384
3385         bugzilla-tool should not require users to install mechanize
3386         https://bugs.webkit.org/show_bug.cgi?id=32635
3387
3388         * Scripts/webkitpy/__init__.py: Add missing declaration for ClientForm (which mechanize requires).
3389
3390 2010-01-04  Eric Seidel  <eric@webkit.org>
3391
3392         Reviewed by Adam Barth.
3393
3394         bugzilla-tool should not require users to install mechanize
3395         https://bugs.webkit.org/show_bug.cgi?id=32635
3396
3397         Use the nifty "autoinstall" module from Daniel Krech:
3398         http://pypi.python.org/pypi/autoinstall/0.2
3399         http://code.google.com/p/pyautoinstall/
3400         It's available under a WebKit-compatible BSD license.
3401
3402         * Scripts/webkitpy/__init__.py:
3403          - bind "mechanize" to an autoinstall importer which will
3404            auto-download mechanize if necessary.
3405         * Scripts/webkitpy/autoinstall.py: Added.
3406         * Scripts/webkitpy/bugzilla.py: use "mechanize" instead of webkit_mechanize
3407         * Scripts/webkitpy/statusbot.py: ditto.
3408         * Scripts/webkitpy/webkit_mechanize.py: Removed.
3409
3410 2010-01-04  Adam Barth  <abarth@webkit.org>
3411
3412         Reviewed by Eric Seidel.
3413
3414         [bzt] Move AbstractSequencedCommand to a more general location
3415         https://bugs.webkit.org/show_bug.cgi?id=33137
3416
3417         I do what the FIXME tell me to do.
3418
3419         * Scripts/webkitpy/commands/abstractsequencedcommand.py: Added.
3420         * Scripts/webkitpy/commands/download.py:
3421         * Scripts/webkitpy/commands/upload.py:
3422
3423 2010-01-04  Adam Barth  <abarth@webkit.org>
3424
3425         Reviewed by Eric Seidel.
3426
3427         Rename StatusBot to StatusServer
3428         https://bugs.webkit.org/show_bug.cgi?id=33139
3429
3430         It's not a bot.  It's a server.
3431
3432         * Scripts/bugzilla-tool:
3433         * Scripts/webkitpy/bugzilla.py:
3434         * Scripts/webkitpy/commands/early_warning_system.py:
3435         * Scripts/webkitpy/commands/queues.py:
3436         * Scripts/webkitpy/mock_bugzillatool.py:
3437         * Scripts/webkitpy/queueengine.py:
3438         * Scripts/webkitpy/statusbot.py: Removed.
3439
3440 2010-01-04  Adam Barth  <abarth@webkit.org>
3441
3442         Reviewed by Eric Seidel.
3443
3444         [bzt] submit-pach should have a -o/--open option to open the bug after submit
3445         https://bugs.webkit.org/show_bug.cgi?id=33136
3446
3447         Python makes this very easy.
3448
3449         * Scripts/webkitpy/mock_bugzillatool.py:
3450         * Scripts/webkitpy/steps/options.py:
3451         * Scripts/webkitpy/steps/postdiff.py:
3452         * Scripts/webkitpy/user.py:
3453
3454 2010-01-04  Adam Barth  <abarth@webkit.org>
3455
3456         Reviewed by Eric Seidel.
3457
3458         [bzt] Move steps to a submodule
3459         https://bugs.webkit.org/show_bug.cgi?id=33135
3460
3461         For great victory.  This will probably introduce some regressions
3462         because our test coverage isn't perfect, but I've tried to be careful.
3463
3464         * Scripts/test-webkitpy:
3465         * Scripts/webkitpy/buildsteps.py: Removed.
3466         * Scripts/webkitpy/buildsteps_unittest.py: Removed.
3467         * Scripts/webkitpy/commands/download.py:
3468         * Scripts/webkitpy/commands/upload.py:
3469         * Scripts/webkitpy/steps/__init__.py: Added.
3470         * Scripts/webkitpy/steps/abstractstep.py: Added.
3471         * Scripts/webkitpy/steps/applypatch.py: Added.
3472         * Scripts/webkitpy/steps/applypatchwithlocalcommit.py: Added.
3473         * Scripts/webkitpy/steps/build.py: Added.
3474         * Scripts/webkitpy/steps/checkstyle.py: Added.
3475         * Scripts/webkitpy/steps/cleanworkingdirectory.py: Added.
3476         * Scripts/webkitpy/steps/cleanworkingdirectorywithlocalcommits.py: Added.
3477         * Scripts/webkitpy/steps/closebug.py: Added.
3478         * Scripts/webkitpy/steps/closebugforlanddiff.py: Added.
3479         * Scripts/webkitpy/steps/closepatch.py: Added.
3480         * Scripts/webkitpy/steps/commit.py: Added.
3481         * Scripts/webkitpy/steps/completerollout.py: Added.
3482         * Scripts/webkitpy/steps/confirmdiff.py: Added.
3483         * Scripts/webkitpy/steps/createbug.py: Added.
3484         * Scripts/webkitpy/steps/editchangelog.py: Added.
3485         * Scripts/webkitpy/steps/ensurebuildersaregreen.py: Added.
3486         * Scripts/webkitpy/steps/ensurelocalcommitifneeded.py: Added.
3487         * Scripts/webkitpy/steps/metastep.py: Added.
3488         * Scripts/webkitpy/steps/obsoletepatches.py: Added.
3489         * Scripts/webkitpy/steps/options.py: Added.
3490         * Scripts/webkitpy/steps/postdiff.py: Added.
3491         * Scripts/webkitpy/steps/preparechangelog.py: Added.
3492         * Scripts/webkitpy/steps/preparechangelogforrevert.py: Added.
3493         * Scripts/webkitpy/steps/promptforbugortitle.py: Added.
3494         * Scripts/webkitpy/steps/revertrevision.py: Added.
3495         * Scripts/webkitpy/steps/runtests.py: Added.
3496         * Scripts/webkitpy/steps/steps_unittest.py: Added.
3497         * Scripts/webkitpy/steps/update.py: Added.
3498         * Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py: Added.
3499         * Scripts/webkitpy/steps/updatechangelogswithreviewer.py: Added.
3500         * Scripts/webkitpy/stepsequence.py:
3501
3502 2010-01-04  Daniel Bates  <dbates@webkit.org>
3503
3504         Reviewed by Eric Seidel.
3505
3506         https://bugs.webkit.org/show_bug.cgi?id=33097
3507
3508         Cleans up the File menu to better conform to the File menu in Safari
3509         both in terms of options and keyboard shortcuts. Adds a "Quit" menu
3510         options to close all open windows. Also, renames the Tools menu to
3511         Develop.
3512
3513         * QtLauncher/main.cpp:
3514         (MainWindow::setupUI):
3515
3516 2010-01-04  Daniel Bates  <dbates@webkit.org>
3517
3518         https://bugs.webkit.org/show_bug.cgi?id=33039
3519
3520         Unreviewed fix.
3521
3522         * Scripts/webkitpy/credentials.py:
3523         * Scripts/webkitpy/credentials_unittest.py:
3524
3525 2010-01-04  Daniel Bates  <dbates@webkit.org>
3526
3527         Reviewed by Eric Seidel.
3528
3529         https://bugs.webkit.org/show_bug.cgi?id=33039
3530
3531         [bzt] Second attempt to fix an issue where bugzilla-tool dies
3532         when the keychain lookup fails to find an entry for bugs.webkit.org.
3533
3534         * Scripts/webkitpy/credentials.py:
3535         * Scripts/webkitpy/credentials_unittest.py:
3536
3537 2010-01-04  Eric Seidel  <eric@webkit.org>
3538
3539         Reviewed by Adam Barth.
3540
3541         Make Rollout an AbstractSequencedCommmand
3542         https://bugs.webkit.org/show_bug.cgi?id=33133
3543
3544         As suggested by Adam in:
3545         https://bugs.webkit.org/show_bug.cgi?id=33131#c2
3546
3547         * Scripts/webkitpy/commands/download.py:
3548
3549 2010-01-04  Eric Seidel  <eric@webkit.org>
3550
3551         Reviewed by Adam Barth.
3552
3553         Make all commands AbstractDeclarativeCommmands instead of direct Command subclasses
3554         https://bugs.webkit.org/show_bug.cgi?id=33131
3555
3556         Evenetually we'll probably roll AbstractDeclarativeCommmand directly into Command
3557         but for now we just deploy it everywhere and don't try to fix up the few valid uses
3558         of Command.
3559
3560         * Scripts/webkitpy/commands/download.py:
3561         * Scripts/webkitpy/commands/queries.py:
3562         * Scripts/webkitpy/commands/upload.py:
3563         * Scripts/webkitpy/multicommandtool.py:
3564
3565 2010-01-03  Adam Barth  <abarth@webkit.org>
3566
3567         Unreviewed "build" fix.  Need to import ScriptError.
3568
3569         * Scripts/webkitpy/buildsteps.py:
3570
3571 2010-01-03  Adam Barth  <abarth@webkit.org>
3572
3573         Reviewed by Eric Seidel.
3574
3575         [bzt] Make it easier to run submit-patch when previous run cancelled
3576         https://bugs.webkit.org/show_bug.cgi?id=33070
3577
3578         This patch renames create-review to submit-patch (as requested by
3579         Maciej).
3580
3581         This patch makes it easier to run submit-patch after the user has
3582         already cancelled a previous run of submit-patch by detecting when we
3583         already have ChangeLogs and reading the bug number from them (and not
3584         attempting to recreate them).  Aside from performance and the extra
3585         edit step, this command should not subsume post-dif.
3586
3587         Also, added a --email command line argument so that the output of
3588         prepare-ChangeLog makes sense when it can't find the user's email
3589         address.
3590
3591         * Scripts/webkitpy/bugzilla.py:
3592         * Scripts/webkitpy/buildsteps.py:
3593         * Scripts/webkitpy/commands/upload.py:
3594         * Scripts/webkitpy/commands/upload_unittest.py:
3595         * Scripts/webkitpy/mock_bugzillatool.py:
3596         * Scripts/webkitpy/user.py:
3597
3598 2010-01-03  Eric Seidel  <eric@webkit.org>
3599
3600         Reviewed by Adam Barth.
3601
3602         Rename Scripts/modules to Scripts/webkitpy
3603         https://bugs.webkit.org/show_bug.cgi?id=33128
3604
3605         Just search-replace and svn mv commands.
3606
3607         * Scripts/bugzilla-tool:
3608         * Scripts/check-webkit-style:
3609         * Scripts/modules: Removed.
3610         * Scripts/modules/BeautifulSoup.py: Removed.
3611         * Scripts/modules/__init__.py: Removed.
3612         * Scripts/modules/bugzilla.py: Removed.
3613         * Scripts/modules/bugzilla_unittest.py: Removed.
3614         * Scripts/modules/buildbot.py: Removed.
3615         * Scripts/modules/buildbot_unittest.py: Removed.
3616         * Scripts/modules/buildsteps.py: Removed.
3617         * Scripts/modules/buildsteps_unittest.py: Removed.
3618         * Scripts/modules/changelogs.py: Removed.
3619         * Scripts/modules/changelogs_unittest.py: Removed.
3620         * Scripts/modules/commands: Removed.
3621         * Scripts/modules/commands/__init__.py: Removed.
3622         * Scripts/modules/commands/commandtest.py: Removed.
3623         * Scripts/modules/commands/download.py: Removed.
3624         * Scripts/modules/commands/download_unittest.py: Removed.
3625         * Scripts/modules/commands/early_warning_system.py: Removed.
3626         * Scripts/modules/commands/early_warning_system_unittest.py: Removed.
3627         * Scripts/modules/commands/queries.py: Removed.
3628         * Scripts/modules/commands/queries_unittest.py: Removed.
3629         * Scripts/modules/commands/queues.py: Removed.
3630         * Scripts/modules/commands/queues_unittest.py: Removed.
3631         * Scripts/modules/commands/queuestest.py: Removed.
3632         * Scripts/modules/commands/upload.py: Removed.
3633         * Scripts/modules/commands/upload_unittest.py: Removed.
3634         * Scripts/modules/comments.py: Removed.
3635         * Scripts/modules/committers.py: Removed.
3636         * Scripts/modules/committers_unittest.py: Removed.
3637         * Scripts/modules/cpp_style.py: Removed.
3638         * Scripts/modules/cpp_style_unittest.py: Removed.
3639         * Scripts/modules/credentials.py: Removed.
3640         * Scripts/modules/credentials_unittest.py: Removed.
3641         * Scripts/modules/diff_parser.py: Removed.
3642         * Scripts/modules/diff_parser_unittest.py: Removed.
3643         * Scripts/modules/executive.py: Removed.
3644         * Scripts/modules/executive_unittest.py: Removed.
3645         * Scripts/modules/grammar.py: Removed.
3646         * Scripts/modules/mock.py: Removed.
3647         * Scripts/modules/mock_bugzillatool.py: Removed.
3648         * Scripts/modules/multicommandtool.py: Removed.
3649         * Scripts/modules/multicommandtool_unittest.py: Removed.
3650         * Scripts/modules/outputcapture.py: Removed.
3651         * Scripts/modules/patchcollection.py: Removed.
3652         * Scripts/modules/queueengine.py: Removed.
3653         * Scripts/modules/queueengine_unittest.py: Removed.
3654         * Scripts/modules/scm.py: Removed.
3655         * Scripts/modules/scm_unittest.py: Removed.
3656         * Scripts/modules/statusbot.py: Removed.
3657         * Scripts/modules/stepsequence.py: Removed.
3658         * Scripts/modules/style: Removed.
3659         * Scripts/modules/style.py: Removed.
3660         * Scripts/modules/style_unittest.py: Removed.
3661         * Scripts/modules/text_style.py: Removed.
3662         * Scripts/modules/text_style_unittest.py: Removed.
3663         * Scripts/modules/user.py: Removed.
3664         * Scripts/modules/webkit_logging.py: Removed.
3665         * Scripts/modules/webkit_logging_unittest.py: Removed.
3666         * Scripts/modules/webkit_mechanize.py: Removed.
3667         * Scripts/modules/webkitport.py: Removed.
3668         * Scripts/modules/webkitport_unittest.py: Removed.
3669         * Scripts/test-webkit-python: Removed.
3670         * Scripts/test-webkitpy: Copied from WebKitTools/Scripts/test-webkit-python.
3671         * Scripts/validate-committer-lists:
3672         * Scripts/webkitpy: Copied from WebKitTools/Scripts/modules.
3673         * Scripts/webkitpy/bugzilla.py:
3674         * Scripts/webkitpy/bugzilla_unittest.py:
3675         * Scripts/webkitpy/buildbot.py:
3676         * Scripts/webkitpy/buildbot_unittest.py:
3677         * Scripts/webkitpy/buildsteps.py:
3678         * Scripts/webkitpy/buildsteps_unittest.py:
3679         * Scripts/webkitpy/commands/commandtest.py:
3680         * Scripts/webkitpy/commands/download.py:
3681         * Scripts/webkitpy/commands/download_unittest.py:
3682         * Scripts/webkitpy/commands/early_warning_system.py:
3683         * Scripts/webkitpy/commands/early_warning_system_unittest.py:
3684         * Scripts/webkitpy/commands/queries.py:
3685         * Scripts/webkitpy/commands/queries_unittest.py:
3686         * Scripts/webkitpy/commands/queues.py:
3687         * Scripts/webkitpy/commands/queues_unittest.py:
3688         * Scripts/webkitpy/commands/queuestest.py:
3689         * Scripts/webkitpy/commands/upload.py:
3690         * Scripts/webkitpy/commands/upload_unittest.py:
3691         * Scripts/webkitpy/comments.py:
3692         * Scripts/webkitpy/credentials.py:
3693         * Scripts/webkitpy/credentials_unittest.py:
3694         * Scripts/webkitpy/executive.py:
3695         * Scripts/webkitpy/executive_unittest.py:
3696         * Scripts/webkitpy/mock_bugzillatool.py:
3697         * Scripts/webkitpy/multicommandtool.py:
3698         * Scripts/webkitpy/multicommandtool_unittest.py:
3699         * Scripts/webkitpy/queueengine.py:
3700         * Scripts/webkitpy/queueengine_unittest.py:
3701         * Scripts/webkitpy/scm.py:
3702         * Scripts/webkitpy/scm_unittest.py:
3703         * Scripts/webkitpy/statusbot.py:
3704         * Scripts/webkitpy/stepsequence.py:
3705         * Scripts/webkitpy/webkit_logging_unittest.py:
3706         * Scripts/webkitpy/webkitport_unittest.py:
3707
3708 2010-01-03  Chris Jerdonek  <chris.jerdonek@gmail.com>
3709
3710         Reviewed by Eric Seidel.
3711
3712         Added script to test both Perl and Python, and renamed
3713         run-webkit-unittests to test-webkit-python.
3714
3715         https://bugs.webkit.org/show_bug.cgi?id=33045
3716
3717         * Scripts/VCSUtils_unittest.pl:
3718           - Tweaked so it can be run from outside Scripts directory.
3719
3720         * Scripts/run-webkit-unittests: Removed.
3721           - Renamed to test-webkit-python.
3722
3723         * Scripts/test-webkit-perl:
3724           - Tweaked so it can be run from outside Scripts directory.
3725
3726         * Scripts/test-webkit-python: Copied from Scripts/run-webkit-unittests.
3727
3728         * Scripts/test-webkit-scripts: Added.
3729           - Runs both test-webkit-perl and test-webkit-python.
3730
3731 2010-01-03  Adam Barth  <abarth@webkit.org>
3732
3733         Reviewed by Eric Seidel.
3734
3735         commit-queue/bugzilla-tool should build both Debug and Release
3736         https://bugs.webkit.org/show_bug.cgi?id=28450
3737
3738         Add a --build-style command that lets the master process tell the child
3739         process to build both debug and release.  Eventually we want to teach
3740         the test step to understand this option too, but that's a patch for
3741         another day.
3742
3743         * Scripts/modules/buildsteps.py:
3744         * Scripts/modules/commands/queues.py:
3745         * Scripts/modules/webkitport.py:
3746         * Scripts/modules/webkitport_unittest.py:
3747
3748 2010-01-03  Jakub Wieczorek  <faw217@gmail.com>
3749
3750         Reviewed by Eric Seidel.
3751
3752         [Qt] EventSender: add support for Enter key events
3753         https://bugs.webkit.org/show_bug.cgi?id=33064
3754
3755         Unskip 5 tests that are fixed now.
3756
3757         * DumpRenderTree/qt/EventSenderQt.cpp:
3758         (EventSender::keyDown):
3759
3760 2010-01-03  Adam Barth  <abarth@webkit.org>
3761
3762         Reviewed by Eric Seidel.
3763
3764         [bzt] Add test for previous typo fix
3765         https://bugs.webkit.org/show_bug.cgi?id=33083
3766
3767         A trivial test for a trivial fix, as requested by Eric.
3768
3769         * Scripts/modules/bugzilla_unittest.py:
3770
3771 2010-01-03  Adam Barth  <abarth@webkit.org>
3772
3773         Reviewed by Eric Seidel.
3774
3775         Implement mac-ews
3776         https://bugs.webkit.org/show_bug.cgi?id=33072
3777
3778         The mac-ews is slightly different than the other early warning systems
3779         because we can't run Mac OS X inside a VM.  For that reason, we only
3780         process patches that were uploaded by committers.  This isn't as much
3781         coverage as the other EWS bots, but it's better than nothing.
3782
3783         * Scripts/modules/commands/early_warning_system.py:
3784         * Scripts/modules/commands/early_warning_system_unittest.py:
3785         * Scripts/modules/commands/queues.py:
3786         * Scripts/modules/commands/queuestest.py:
3787         * Scripts/modules/mock_bugzillatool.py:
3788
3789 2010-01-03  Chris Jerdonek  <chris.jerdonek@gmail.com>
3790
3791         Reviewed by David Kilzer.
3792
3793         Refactored svn-apply and svn-unapply to use a common "patch"
3794         command method, and added unit tests for this new method.
3795
3796         https://bugs.webkit.org/show_bug.cgi?id=33098
3797
3798         * Scripts/VCSUtils.pm:
3799           - Added generateRunPatchCommand().
3800           - Added runPatchCommand().
3801           - Added exitStatus() from webkitdirs.pm to address FIXME.
3802
3803         * Scripts/VCSUtils_unittest.pl:
3804           - Added 10 unit tests for generateRunPatchCommand().
3805           - Added 4 unit tests for runPatchCommand().
3806           - Added callSilently() method.
3807
3808         * Scripts/svn-apply:
3809           - Refactored applyPatch().
3810           - Removed $pathScriptWasRunFrom global variable.
3811           - Addressed issue where "--force" option was getting added twice.
3812
3813         * Scripts/svn-unapply:
3814           - Refactored applyPatch().
3815           - Removed $pathScriptWasRunFrom global variable.
3816           - Added support for --force option.
3817           - Enhanced to return meaningful exit status.
3818
3819         * Scripts/webkitdirs.pm:
3820           - Moved exitStatus() implementation to VCSUtils.pm.
3821
3822 2009-12-31  Adam Barth  <abarth@webkit.org>
3823
3824         Reviewed by Eric Seidel.
3825
3826         [bzt] Implement build-and-test
3827         https://bugs.webkit.org/show_bug.cgi?id=33073
3828
3829         Some of the early warning system bots want to use build-and-test so
3830         they can cover LayoutTests in addition to just compilation.
3831
3832         * Scripts/modules/commands/download.py:
3833         * Scripts/modules/commands/download_unittest.py:
3834
3835 2009-12-31  Adam Barth  <abarth@webkit.org>
3836
3837         Reviewed by Eric Seidel.
3838
3839         Show mac-ews status on QueueStatusServer
3840         https://bugs.webkit.org/show_bug.cgi?id=33076
3841
3842         Also make error status purple.
3843
3844         * QueueStatusServer/model/attachment.py:
3845         * QueueStatusServer/model/queues.py:
3846         * QueueStatusServer/templates/dashboard.html:
3847         * QueueStatusServer/templates/statusbubble.html:
3848
3849 2009-12-31  Adam Barth  <abarth@webkit.org>
3850
3851         Unreviewed.
3852
3853         [bzt] REGRESSION: Bugzila is a typo
3854         https://bugs.webkit.org/show_bug.cgi?id=33074
3855
3856         Eric should test his code before landing!  :)
3857
3858         * Scripts/modules/bugzilla.py:
3859
3860 2009-12-31  Adam Barth  <abarth@webkit.org>
3861
3862         Unreviewed.  Fix the unit tests!
3863
3864         * Scripts/run-webkit-unittests:
3865
3866 2009-12-30  Kevin Watters  <kevinwatters@gmail.com>
3867
3868         Reviewed by Kevin Ollivier.
3869
3870         [wx] Alter a couple of default settings in the test app.
3871
3872         https://bugs.webkit.org/show_bug.cgi?id=32956
3873
3874         * wx/browser/browser.cpp:
3875         (MyApp::OnInit):
3876
3877 2009-12-30  Eric Seidel  <eric@webkit.org>
3878
3879         Reviewed by Adam Barth.
3880
3881         logging.py should be renamed to webkit_logging.py and eventually die
3882         https://bugs.webkit.org/show_bug.cgi?id=33058
3883
3884         Change all imports of "logging" to webkit_logging,
3885         except the ones which came from Google's cpp_lint.py and diff_parser.py
3886         which clearly are assuming python's logging.py.
3887
3888         * Scripts/modules/bugzilla.py:
3889         * Scripts/modules/buildbot.py:
3890         * Scripts/modules/buildsteps.py:
3891         * Scripts/modules/commands/download.py:
3892         * Scripts/modules/commands/queries.py:
3893         * Scripts/modules/commands/queues.py:
3894         * Scripts/modules/commands/upload.py:
3895         * Scripts/modules/credentials.py:
3896         * Scripts/modules/executive.py:
3897         * Scripts/modules/multicommandtool.py:
3898         * Scripts/modules/queueengine.py:
3899         * Scripts/modules/scm.py:
3900         * Scripts/modules/statusbot.py:
3901         * Scripts/modules/stepsequence.py:
3902         * Scripts/modules/webkit_logging.py: Renamed from WebKitTools/Scripts/modules/logging.py.
3903         * Scripts/modules/webkit_logging_unittest.py: Renamed from WebKitTools/Scripts/modules/logging_unittest.py.
3904
3905 2009-12-30  Jakub Wieczorek  <faw217@gmail.com>
3906
3907         Reviewed by Simon Hausmann.
3908
3909         [Qt] layoutTestController.pathToLocalResource() should return a path, not an URL
3910         https://bugs.webkit.org/show_bug.cgi?id=33051
3911
3912         Moreover, its primary function is to normalize the path in regard of platform
3913         specific directory separators. Therefore, it can simply make use of the
3914         QDir::toNativeSeparators function.
3915
3916         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3917         (LayoutTestController::pathToLocalResource):
3918
3919 2009-12-30  David D. Kilzer  <ddkilzer@webkit.org>
3920
3921         Fix executable bits for r52646
3922
3923         * Scripts/VCSUtils_unittest.pl: Added property svn:executable.
3924         * Scripts/test-webkit-perl: Ditto.
3925
3926 2009-12-29  Chris Jerdonek  <chris.jerdonek@gmail.com>
3927
3928         Reviewed by David Kilzer.
3929
3930         Fixed a bug in fixChangeLogPatch, made it work correctly in
3931         more circumstances, and added unit tests.
3932
3933         https://bugs.webkit.org/show_bug.cgi?id=32919
3934
3935         * Scripts/VCSUtils.pm:
3936           Rewrote fixChangeLogPatch.
3937
3938         * Scripts/VCSUtils_unittest.pl: Added.
3939           Added 7 unit tests for fixChangeLogPatch.
3940
3941         * Scripts/test-webkit-perl: Added.
3942           Added test harness for unit tests of Perl code.
3943
3944 2009-12-29  Eric Seidel  <eric@webkit.org>
3945
3946         Reviewed by Adam Barth.
3947
3948         Split out BugzillaQueries class from Bugzilla
3949         https://bugs.webkit.org/show_bug.cgi?id=33042
3950
3951         * Scripts/modules/bugzilla.py:
3952          - Split out BugzillaQueries from Bugzilla.
3953          - Try to isolate self.bugzilla usage into helper functions whenever possible.
3954          - Add a bunch of FIXMEs.
3955          - Rename fetch_bug_ids_from_needs_commit_list to fetch_bug_ids_from_pending_commit_list
3956         * Scripts/modules/bugzilla_unittest.py:
3957          - Create a new BugzillaQueriesTest testcase and move logic there.
3958         * Scripts/modules/buildsteps_unittest.py:
3959          - Use Bug 75 instead of 1 since bug 1 doesn't actually exist.
3960         * Scripts/modules/commands/queries.py:
3961          - Update to use bugzilla.queries
3962         * Scripts/modules/commands/queues.py:
3963          - Ditto.
3964         * Scripts/modules/commands/upload.py:
3965          - Ditto.
3966         * Scripts/modules/mock_bugzillatool.py:
3967          - Add a MockBugzillaQueries.
3968          - Make patches and bugs global privates.
3969          - Let _id_to_object_dictionary take a variable argument list instead of an array.
3970
3971 2009-12-29  Daniel Bates  <dbates@webkit.org>
3972
3973         Reviewed by Eric Seidel.
3974
3975         https://bugs.webkit.org/show_bug.cgi?id=33041
3976
3977         Speed up the test method test_read_credentials_with_SVN by not actually
3978         creating an SVN repository to test against (by default). Instead, it is
3979         sufficient to create a temporary directory that does not contain a Git
3980         repository.
3981
3982         Also, renamed method test_read_credentials_with_SVN to
3983         test_read_credentials_without_git_repo, to better reflect what it is
3984         testing.
3985
3986         * Scripts/modules/credentials_unittest.py:
3987
3988 2009-12-29  Daniel Bates  <dbates@webkit.org>
3989
3990         Reviewed by Adam Barth.
3991
3992         https://bugs.webkit.org/show_bug.cgi?id=33039
3993
3994         [bzt] Fixes an issue where bugzilla-tool dies when the keychain lookup
3995         fails to find an entry for bugs.webkit.org.
3996
3997         Under Mac OS X, bugzilla-tool tries to query the keychain and Security
3998         framework (via /usr/sbin/security) for an internet-password entry for
3999         bugs.webkit.org so that it can use it to login to bugs.webkit.org.
4000         However, if no such entry exists then bugzilla-tool dies with an error.
4001
4002         * Scripts/modules/credentials.py: Modified method _parse_security_tool_output to return
4003         [None, None] if /usr/sbin/security cannot find keychain entry for bugs.webkit.org.
4004         * Scripts/modules/credentials_unittest.py: Added method test_security_output_parse_entry_not_found.
4005
4006 2009-12-29  Eric Seidel  <eric@webkit.org>
4007
4008         Rubber-stamped by Adam Barth.
4009
4010         Remove unused BugzillaException.
4011
4012         * Scripts/modules/bugzilla.py:
4013
4014 2009-12-29  Eric Seidel  <eric@webkit.org>
4015
4016         Reviewed by Adam Barth.
4017
4018         Need a script to assign bugs with r+ patches to committers for landing
4019         https://bugs.webkit.org/show_bug.cgi?id=33009
4020
4021         This is just one more small tool to help in the fight against our
4022         ever-growing list of to-be-committed patches.
4023
4024         * Scripts/modules/bugzilla.py:
4025          - Rename assign_to_email to assigned_to_email (typo).
4026          - Add assigned_to_email() method on Bug.
4027          - Add reassign_bug method.
4028          - Add Bugzilla.unassigned_email, eventually should move to some webkit_config.py module.
4029         * Scripts/modules/bugzilla_unittest.py:
4030          - Update test after assigned_to_email rename.
4031         * Scripts/modules/commands/commandtest.py:
4032          - Call bind_to_tool to that self.tool works in Command testing.
4033         * Scripts/modules/commands/download.py:
4034          - Move AbstractDeclarativeCommmand multicommandtool.py, it should be part of Command.
4035         * Scripts/modules/commands/queries_unittest.py:
4036          - One of the test patches is now posted by "eric@webkit.org" which is a committer.
4037          - Eventually we'll mock out CommitterList and be able to better control what's a committer and what's not.
4038         * Scripts/modules/commands/upload.py:
4039          - Add new assign-to-committer command.
4040         * Scripts/modules/commands/upload_unittest.py:
4041          - Add basic assign-to-committer test.
4042         * Scripts/modules/committers.py:
4043          - Add bugzilla_email() accessor.
4044         * Scripts/modules/committers_unittest.py:
4045          - Test our assumption that bugzilla_email is the first email.
4046         * Scripts/modules/mock_bugzillatool.py:
4047          - Add _id_to_object_dictionary for generating bug_cache from list of bugs.
4048          - Remove unused fetch_attachments_from_bug.
4049          - Add fetch_bug support and a bug_cache.
4050         * Scripts/modules/multicommandtool.py:
4051          - Move AbstractDeclarativeCommmand here from download.py
4052
4053 2009-12-29  Adam Barth  <abarth@webkit.org>
4054
4055         Reviewed by Eric Seidel.
4056
4057         [bzt] Don't crash if user types a number during PromptForBugOrTitleStep
4058         https://bugs.webkit.org/show_bug.cgi?id=33038
4059
4060         Simple fix with test.
4061
4062         * Scripts/modules/buildsteps.py:
4063         * Scripts/modules/buildsteps_unittest.py:
4064
4065 2009-12-29  Adam Barth  <abarth@webkit.org>
4066
4067         Reviewed by Eric Seidel.
4068
4069         [bzt] post-diff requires reading to the end
4070         https://bugs.webkit.org/show_bug.cgi?id=33036
4071
4072         Catch the IOError caused by not reading to the end of the diff.  We
4073         don't have a good way to test this currently.
4074
4075         * Scripts/modules/user.py:
4076
4077 2009-12-29  Chang Shu  <Chang.Shu@nokia.com>
4078
4079         Reviewed by Adam Barth.
4080
4081         [Qt] Move logic that handles Qt headers before primary headers
4082         so that Qt headers won't be treated as primary headers by mistake.
4083         https://bugs.webkit.org/show_bug.cgi?id=32991
4084
4085         * Scripts/modules/cpp_style.py:
4086         * Scripts/modules/cpp_style_unittest.py:
4087
4088 2009-12-29  Eric Seidel  <eric@webkit.org>
4089
4090         Reviewed by Adam Barth.
4091
4092         Add the start of a Bug object for bugzilla.py
4093         https://bugs.webkit.org/show_bug.cgi?id=32995
4094
4095         This allowed us to get rid of some duplicated "is_obsolete" checks.
4096
4097         * Scripts/modules/bugzilla.py:
4098          - Add a new Bug class, and move patches/unreviewed_patches filtering logic there.
4099          - Add _fetch_bug_page for possible future mocking.
4100            (I did not try to test fetch_*_from_bug now due to difficulties with our current validate_reviewer logic.)
4101          - Rename fetch_bug to fetch_bug_dictionary and add a new fetch_bug which returns a Bug object.
4102          - Use fetch_bug and attachments(), patches(), etc. instead of custom fetch_*_from_bug methods.
4103          - Reduce code in fetch_patches_from_pending_commit_list and fetch_patches_from_review_queue
4104            using list comprehensions. Use a sum(list, []) trick to flatten a list of lists into a single list.
4105         * Scripts/modules/bugzilla_unittest.py:
4106          - Remove an unneeded unicode string marker.
4107         * Scripts/modules/buildsteps.py:
4108          - define __all__ to include just the BuildSteps
4109         * Scripts/modules/commands/download.py:
4110          - import * now that we have an __all__ defined.
4111         * Scripts/modules/commands/upload.py:
4112          - Use fetch_bug_dictionary instead of fetch_bug.
4113
4114 2009-12-29  Daniel Bates  <dbates@webkit.org>
4115
4116         Reviewed by Ariya Hidayat.
4117
4118         https://bugs.webkit.org/show_bug.cgi?id=32925
4119
4120         Adds an Open File dialog to make it convenient to open a file
4121         to view in the browser.
4122
4123         Currently a person must either specify the path to a file as a
4124         command-line argument or type a file URL. Instead, we should
4125         have a file dialog to allow a person to open a file without
4126         memorizing its path.
4127
4128         * QtLauncher/main.cpp:
4129         (MainWindow::MainWindow): Changed urlEdit->setText(qurl.toEncoded())
4130         to urlEdit->setText(qurl.toString()).
4131         (MainWindow::openFile): Added.
4132         (MainWindow::changeLocation): Moved code to load URL into method
4133         MainWindow::loadURL.
4134         (MainWindow::loadURL): Added.
4135         (MainWindow::setupUI): Added menu item Open File.
4136
4137 2009-12-29  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
4138
4139         Reviewed by Holger Freyther.
4140
4141         [GTK] fails fast/harness/use-page-cache.html
4142         https://bugs.webkit.org/show_bug.cgi?id=33013
4143
4144         Make sure settings are forwarded to child WebViews.
4145
4146         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4147         (createWebView):
4148
4149 2009-12-29  Daniel Bates  <dbates@webkit.org>
4150
4151         Reviewed by Eric Seidel.
4152
4153         https://bugs.webkit.org/show_bug.cgi?id=32778
4154
4155         Changes $diffPercentage to be a number to resolve Perl
4156         warning about comparing a string to a number.
4157
4158         * Scripts/run-webkit-tests:
4159
4160 2009-12-29  Jakub Wieczorek  <faw217@gmail.com>
4161
4162         Reviewed by Eric Seidel.
4163
4164         [Qt] DRT: Frame loader callbacks differ from the Mac port
4165         https://bugs.webkit.org/show_bug.cgi?id=32989
4166
4167         Remove messages from the callbacks that should not dump them to match
4168         the expected results for the http/loading tests.
4169
4170         Unskip some http/loading tests which succeed now.
4171
4172         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4173         (WebCore::DumpRenderTree::dump):
4174
4175 2009-12-29  Robert Hogan  <robert@roberthogan.net>
4176
4177         Reviewed by Eric Seidel.
4178
4179         [Qt] fix fast/dom/Window/window-onFocus.html
4180
4181         Add support for layouttestcontroller.windowIsKey to Qt DRT and fix issue where
4182         window.onblur was getting dispatched twice from QtWebKit.
4183
4184         https://bugs.webkit.org/show_bug.cgi?id=32990
4185
4186         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4187         (WebCore::DumpRenderTree::DumpRenderTree):
4188         (WebCore::DumpRenderTree::switchFocus):
4189         * DumpRenderTree/qt/DumpRenderTreeQt.h:
4190         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4191         (LayoutTestController::setWindowIsKey):
4192         (LayoutTestController::setMainFrameIsFirstResponder):
4193         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4194
4195 2009-12-28  Kinuko Yasuda  <kinuko@chromium.org>
4196
4197         Reviewed by Maciej Stachowiak.
4198
4199         Extended EventSender.keyDown method to take another (3rd) argument
4200         for indicating the keyLocation to make numeric pad key events testable.
4201         Expected values for the argument is one of the KeyLocationCode
4202         specified in DOM Level 3
4203         (http://www.w3.org/TR/DOM-Level-3-Events/#events-keyboardevents).
4204         https://bugs.webkit.org/show_bug.cgi?id=28247
4205
4206         Test: fast/events/keydown-numpad-keys.html
4207
4208         * DumpRenderTree/mac/EventSendingController.mm:
4209         (+[EventSendingController isSelectorExcludedFromWebScript:]):
4210         (+[EventSendingController webScriptNameForSelector:]):
4211         (-[EventSendingController keyDown:withModifiers:withLocation:]):
4212
4213 2009-12-28  Ariya Hidayat  <ariya.hidayat@gmail.com>
4214
4215         Unreviewed, update my email address.
4216
4217         * Scripts/modules/committers.py:
4218
4219 2009-12-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
4220
4221         Reviewed by Adam Barth.
4222
4223         [Qt] Fix build break for Qt 4.4
4224         https://bugs.webkit.org/show_bug.cgi?id=30327
4225
4226         * DumpRenderTree/qt/DumpRenderTreeQt.cpp: Include QLocale
4227         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Ditto.
4228         * QtLauncher/main.cpp:
4229         (MainWindow::MainWindow): Qt::WA_TranslucentBackground was
4230         introduced in Qt version 4.5
4231
4232 2009-12-28  Adam Barth  <abarth@webkit.org>
4233
4234         Reviewed by Eric Seidel.
4235
4236         [bzt] Add an edit-changelog command
4237         https://bugs.webkit.org/show_bug.cgi?id=32986
4238
4239         This command makes it easier to edit ChangeLogs.  It's similar to
4240         prepare-ChangeLog -o, except it works with already existing ChangeLogs.
4241
4242         * Scripts/modules/commands/upload.py:
4243         * Scripts/modules/commands/upload_unittest.py:
4244
4245 2009-12-28  Adam Barth  <abarth@webkit.org>
4246
4247         Reviewed by Eric Seidel.
4248
4249         [bzt] Create an ASAD command for uploading a patch
4250         https://bugs.webkit.org/show_bug.cgi?id=32979
4251
4252         The create-review command goes through the whole process of preparing a
4253         code review, including creating a bug, editing the ChangeLogs, and
4254         uploading the patch.  It is indeed the All Sing, All Dance upload
4255         command.
4256
4257         * Scripts/modules/buildsteps.py:
4258         * Scripts/modules/commands/upload.py:
4259         * Scripts/modules/commands/upload_unittest.py:
4260         * Scripts/modules/mock_bugzillatool.py:
4261         * Scripts/modules/user.py: