WebKitTools/ChangeLog

   1 2010-02-19  Andras Becsi  <abecsi@webkit.org>
   2
   3         Reviewed by Kenneth Rohde Christiansen.
   4
   5         [Qt] Implement textZoomIn() and textZoomOut() in DRT's EventSender, add results
   6         for passing new tests and unskip the passing ones from the Skipped list.
   7         https://bugs.webkit.org/show_bug.cgi?id=35159
   8
   9         * DumpRenderTree/qt/EventSenderQt.cpp:
  10         (EventSender::textZoomIn):
  11         (EventSender::textZoomOut):
  12         * DumpRenderTree/qt/EventSenderQt.h:
  13
  14 2010-02-19  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
  15
  16         Reviewed by Eric Seidel.
  17
  18         [Qt] Clean-up the handling of HTML5 persistent data for LayoutTests
  19         https://bugs.webkit.org/show_bug.cgi?id=35004
  20
  21         DumpRenderTreeQt.cpp calls QWebSettings::enablePersistentStorage which sets up
  22         and enables all HTML5 persistent data. All the other calls for setting the
  23         persistent path or enabling the persistent feature are redundant.
  24
  25         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  26         (WebCore::WebPage::WebPage): No need to enable AppCache again.
  27         * DumpRenderTree/qt/main.cpp:
  28         (main): No need to setup and enable HTML5 LocalStorage again.
  29
  30 2010-02-19  Diego Gonzalez  <diego.gonzalez@openbossa.org>
  31
  32         Reviewed by Kenneth Rohde Christiansen.
  33
  34         Send the context menu event from contextClick() of EventSender
  35         and do not show context menu in DRT.
  36
  37         LayoutTests:
  38             fast/events/contextmenu-scrolled-page-with-frame.html
  39
  40         [Qt] DRT: Send context menu event from EventSender
  41         https://bugs.webkit.org/show_bug.cgi?id=35131
  42
  43         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  44         (WebCore::DumpRenderTree::DumpRenderTree):
  45         * DumpRenderTree/qt/EventSenderQt.cpp:
  46         (EventSender::contextClick):
  47
  48 2010-02-18  Chris Jerdonek  <cjerdonek@webkit.org>
  49
  50         Reviewed by Shinichiro Hamaji.
  51
  52         Moved parsing-related code to a separate file. Also increased
  53         the unit test coverage in some affected areas.
  54
  55         https://bugs.webkit.org/show_bug.cgi?id=34675
  56
  57         This revision contains no new functionality.
  58
  59         * Scripts/check-webkit-style:
  60           - Adjusted to call check_webkit_style_parser().
  61
  62         * Scripts/webkitpy/style/checker.py:
  63           - Added check_webkit_style_parser() to pass checker.py
  64             configuration settings to optparser.py.
  65           - Moved _create_usage() and the CommandOptionValues,
  66             DefaultCommandOptionValues, ArgumentPrinter, and
  67             ArgumentParser classes to optparser.py.
  68
  69         * Scripts/webkitpy/style/checker_unittest.py:
  70           - Moved the ProcessorOptionsTest, ArgumentPrinterTest, and
  71             ArgumentParserTest classes to optparser.py.
  72           - Added the CheckWebKitStyleFunctionTest class to check
  73             the check_webkit_style_configuration() and
  74             check_webkit_style_parser() code paths.
  75
  76         * Scripts/webkitpy/style/optparser.py: Added.
  77           - From checker.py, added _create_usage() and the
  78             CommandOptionValues, DefaultCommandOptionValues,
  79             ArgumentPrinter, and ArgumentParser classes.
  80           - In the ArgumentParser constructor--
  81             - Added all_categories as a required parameter.
  82             - Removed the default value from the default_options parameter.
  83
  84         * Scripts/webkitpy/style/optparser_unittest.py: Added.
  85           - From checker_unittest.py, added the ProcessorOptionsTest,
  86             ArgumentPrinterTest, and ArgumentParserTest classes.
  87           - Added the CreateUsageTest class to test _create_usage().
  88
  89         * Scripts/webkitpy/style/unittests.py:
  90           - Added optparser_unittest import.
  91
  92 2010-02-18  Alexey Proskuryakov  <ap@apple.com>
  93
  94         Reviewed by Dan Bernstein.
  95
  96         https://bugs.webkit.org/show_bug.cgi?id=35134
  97         <rdar://problem/7246280> Crash when a plugin calls NPN_SetStatus(0)
  98
  99         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
 100         (testSetStatus):
 101         (pluginInvoke):
 102         Added a setStatus() method.
 103
 104 2010-02-18  Brady Eidson  <beidson@apple.com>
 105
 106         Reviewed by Sam Weinig.
 107
 108         Particularly constructed WebFrames can try to access a null HistoryItem
 109         <rdar://problem/7638892> and https://bugs.webkit.org/show_bug.cgi?id=35063
 110
 111         Add the specific ability to test this API pattern.
 112
 113         For now only on Mac, perhaps on the main Windows port later, probably not relevant for other ports.
 114
 115         * DumpRenderTree/LayoutTestController.cpp:
 116         (apiTestNewWindowDataLoadBaseURLCallback):
 117         (LayoutTestController::staticFunctions):
 118         * DumpRenderTree/LayoutTestController.h:
 119
 120         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 121         (-[APITestDelegate initWithCompletionCondition:]):
 122         (-[APITestDelegate webView:didFailLoadWithError:forFrame:]):
 123         (-[APITestDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
 124         (-[APITestDelegate webView:didFinishLoadForFrame:]):
 125         (LayoutTestController::apiTestNewWindowDataLoadBaseURL): Create a WebView, do a loadData: in its
 126           mainFrame, and synchronously wait for main load completion.
 127
 128         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 129         (LayoutTestController::apiTestNewWindowDataLoadBaseURL):
 130         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
 131         (LayoutTestController::apiTestNewWindowDataLoadBaseURL):
 132         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 133         (LayoutTestController::apiTestNewWindowDataLoadBaseURL):
 134
 135 2010-02-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
 136
 137         Reviewed by Eric Seidel.
 138
 139         Teach resolve-ChangeLogs to act as a merge-driver for Git
 140
 141         https://bugs.webkit.org/show_bug.cgi?id=28721
 142
 143         To enable automatic merging of ChangeLog files, use the following command:
 144
 145         git config merge.changelog.driver "resolve-ChangeLogs --merge-driver %O %A %B"
 146
 147         The driver always works in "downstream" merge mode, meaning
 148         it will always put the user's changelog entries on top.
 149
 150         * Scripts/resolve-ChangeLogs:
 151
 152 2009-12-05  Gustavo Noronha Silva  <gns@gnome.org>
 153
 154         Reviewed by Eric Seidel.
 155
 156         Enable running of GTK+ API tests.
 157
 158         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 159         * Scripts/run-gtk-tests: Added.
 160
 161 2010-02-18  Shinichiro Hamaji  <hamaji@chromium.org>
 162
 163         Reviewed by Adam Barth.
 164
 165         debug-safari doesn't pass --debug option to gdb-safari on MacOSX
 166         https://bugs.webkit.org/show_bug.cgi?id=34411
 167
 168         * Scripts/webkitdirs.pm:
 169
 170 2010-02-18  Eric Seidel  <eric@webkit.org>
 171
 172         Reviewed by Adam Barth.
 173
 174         run-chromium-webkit-tests --platform=mac-leopard needs to run build-dumprendertree
 175         https://bugs.webkit.org/show_bug.cgi?id=35053
 176
 177         * Scripts/webkitpy/layout_tests/port/base.py: Add script_path() function for finding scripts.
 178         * Scripts/webkitpy/layout_tests/port/chromium.py: Remove unused argument.
 179         * Scripts/webkitpy/layout_tests/port/mac.py:
 180          - Make sure that calling webkit-build-directory works even if Scripts/ is not in the user's path.
 181          - Call build-dumprendertree (and make sure it succeeds) before running the tests.
 182
 183 2010-02-16  Chris Jerdonek  <cjerdonek@webkit.org>
 184
 185         Reviewed by Shinichiro Hamaji.
 186
 187         Refactored check-webkit-style's ProcessorOptions class into two
 188         classes. This revision contains no new functionality.
 189
 190         https://bugs.webkit.org/show_bug.cgi?id=34674
 191
 192         Divided the ProcessorOptions class into a CommandOptionValues
 193         class (the result of parsing the command-line options) and
 194         a StyleCheckerConfiguration class (which configures the main
 195         StyleChecker).
 196
 197         * Scripts/check-webkit-style:
 198           - Updated main() to convert the parsed command option values
 199             to a StyleCheckConfiguration instance prior to constructing
 200             a StyleChecker.
 201
 202         * Scripts/webkitpy/style/checker.py:
 203           - Added check_webkit_style_configuration() to convert a
 204             CommandOptionValues instance into a StyleCheckerConfiguration
 205             instance.
 206           - Renamed the ProcessorOptions class to CommandOptionValues.
 207           - In the CommandOptionValues class--
 208             - Replaced the filter_configuration attribute with the
 209               simpler filter_rules attribute.
 210             - Removed the max_reports_per_error attribute.
 211             - Moved the is_reportable() method to the new
 212               StyleCheckerConfiguration class.
 213           - Removed the base_filter_rules attribute from the
 214             DefaultCommandOptionValues class.
 215           - In the ArgumentParser class--
 216             - Added base_filter_rules to the constructor.
 217             - Changed the parse() method to return a CommandOptionValues
 218               instance instead of a ProcessorOptions instance.
 219           - Created a StyleCheckerConfiguration class.
 220             - Added the data attributes max_reports_per_category,
 221               stderr_write, and verbosity.
 222             - Added is_reportable() (moved from the ProcessorOptions
 223               class) and write_style_error() (moved from the
 224               DefaultStyleErrorHandler class).
 225           - In the StyleChecker class--
 226             - Replaced the ProcessorOptions options attribute with the
 227               StyleCheckerConfiguration _configuration attribute.
 228             - Removed the _stderr_write attribute.
 229
 230         * Scripts/webkitpy/style/checker_unittest.py:
 231           - Updated the existing unit test classes as necessary.
 232           - Added a StyleCheckerConfigurationTest class.
 233
 234         * Scripts/webkitpy/style/error_handlers.py:
 235           - Updated the DefaultStyleErrorHandler class to accept a
 236             StyleCheckerConfiguration instance instead of a ProcessorOptions
 237             instance and an stderr_write method.
 238
 239         * Scripts/webkitpy/style/error_handlers_unittest.py:
 240           - Updated the unit test classes as necessary.
 241
 242         * Scripts/webkitpy/style/filter.py:
 243           - Addressed the FIXME in the FilterConfiguration class to change
 244             the user_rules attribute to _user_rules (since it is now
 245             accessed only internally).
 246
 247         * Scripts/webkitpy/style/filter_unittest.py:
 248           - Updated to reflect the change from user_rules to _user_rules.
 249
 250 2010-02-17  Shinichiro Hamaji  <hamaji@chromium.org>
 251
 252         Reviewed by Eric Seidel.
 253
 254         Share the DRT values maxViewWidth/Height among ports
 255         https://bugs.webkit.org/show_bug.cgi?id=34474
 256
 257         * DumpRenderTree/LayoutTestController.cpp:
 258         (pageNumberForElementByIdCallback):
 259         * DumpRenderTree/LayoutTestController.h:
 260         (LayoutTestController::maxViewWidth):
 261         (LayoutTestController::maxViewHeight):
 262         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 263         (runTest):
 264         * DumpRenderTree/mac/DumpRenderTree.mm:
 265         (createWebViewAndOffscreenWindow):
 266         (sizeWebViewForCurrentTest):
 267         * DumpRenderTree/win/DumpRenderTree.cpp:
 268         (dump):
 269         (createWebViewAndOffscreenWindow):
 270
 271 2010-02-17  Shinichiro Hamaji  <hamaji@chromium.org>
 272
 273         Reviewed by Eric Seidel.
 274
 275         [Win] Implement test functions for printing
 276         https://bugs.webkit.org/show_bug.cgi?id=34570
 277
 278         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 279         (LayoutTestController::pageNumberForElementById):
 280         (LayoutTestController::numberOfPages):
 281
 282 2010-02-17  Fumitoshi Ukai  <ukai@chromium.org>
 283
 284         Reviewed by Eric Seidel.
 285
 286         websocket/tests/cookies/httponly-cookie.pl fails every time under run-chromium-webkit-tests
 287         https://bugs.webkit.org/show_bug.cgi?id=35001
 288
 289         * Scripts/webkitpy/layout_tests/port/websocket_server.py: add -x flag to run pywebsocket.
 290
 291 2010-02-17  Shinichiro Hamaji  <hamaji@chromium.org>
 292
 293         Reviewed by Eric Seidel.
 294
 295         check-webkit-style: Misses variables that contain underscores.
 296         https://bugs.webkit.org/show_bug.cgi?id=33724
 297
 298         - Check identifiers whose types are unsigned.
 299         - Check bitfields properly.
 300
 301         * Scripts/webkitpy/style/processors/cpp.py:
 302         * Scripts/webkitpy/style/processors/cpp_unittest.py:
 303
 304 2010-02-17  Shinichiro Hamaji  <hamaji@chromium.org>
 305
 306         Reviewed by Eric Seidel.
 307
 308         check-webkit-style should report the number of files checked
 309         https://bugs.webkit.org/show_bug.cgi?id=34971
 310
 311         * Scripts/check-webkit-style:
 312         * Scripts/webkitpy/style/checker.py:
 313         * Scripts/webkitpy/style/checker_unittest.py:
 314
 315 2010-02-17  Diego Gonzalez  <diego.gonzalez@openbossa.org>
 316
 317         Reviewed by Ariya Hidayat.
 318
 319         Make possible Qt DRT to get total number of pages to be printed
 320
 321         LayoutTests:
 322             printing/numberOfPages.html
 323
 324         [Qt] DRT: Get total number of pages to be printed
 325         https://bugs.webkit.org/show_bug.cgi?id=34955
 326
 327         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 328         (LayoutTestController::numberOfPages):
 329         * DumpRenderTree/qt/LayoutTestControllerQt.h:
 330
 331 2010-02-17  Xan Lopez  <xlopez@igalia.com>
 332
 333         Reviewed by Gustavo Noronha.
 334
 335         Update to use new property name.
 336
 337         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 338         (resetDefaultsToConsistentValues):
 339
 340 2010-02-17  Julien Chaffraix  <jchaffraix@webkit.org>
 341
 342         Reviewed by Ariya Hidayat.
 343
 344         Remove some warnings seen when building Qt
 345         https://bugs.webkit.org/show_bug.cgi?id=35017
 346
 347         Using a machine without the needed tools to build WebKit leads to
 348         several errors and warnings.
 349
 350         * Scripts/webkitdirs.pm: Refactored the code testing the command's
 351         presence into a commandExists routine. While doing so removed, stderr
 352         output as it usually does not give anything more than our message. Also
 353         added a Qt check for qmake that was missing.
 354
 355 2010-02-17  Xan Lopez  <xlopez@igalia.com>
 356
 357         Rubber-stamped by Gustavo Noronha.
 358
 359         Disable Java by default in DRT.
 360
 361         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 362         (resetDefaultsToConsistentValues):
 363
 364 2010-02-15  Chris Jerdonek  <cjerdonek@webkit.org>
 365
 366         Reviewed by Shinichiro Hamaji.
 367
 368         Some minor check-webkit-style code clean-ups.  This revision
 369         contains no new functionality.
 370
 371         https://bugs.webkit.org/show_bug.cgi?id=34932
 372
 373         * Scripts/check-webkit-style:
 374           - Replaced the call to webkit_argument_defaults() with a
 375             default parameter in the ArgumentParser constructor.
 376
 377         * Scripts/webkitpy/style/checker.py:
 378           - Removed the WEBKIT prefix from the default global variables.
 379           - Prefixed several of the global variables with an underscore
 380             to reflect that they are used internally.
 381           - Renamed _DEFAULT_FILTER_RULES to _BASE_FILTER_RULES.
 382           - Addressed a FIXME by changing the _PATH_RULES_SPECIFIER
 383             configuration from list-tuple pairs to list-list pairs.
 384           - Renamed style_categories() to _all_categories().
 385           - Renamed webkit_argument_defaults() to _check_webkit_style_defaults().
 386           - Renamed the ArgumentDefaults class to DefaultCommandOptionValues.
 387           - In the ArgumentParser class--
 388             - Renamed the doc_print attribute to stderr_write.
 389             - Other minor updates.
 390
 391         * Scripts/webkitpy/style/checker_unittest.py:
 392           - Updated the import statements and unit test classes as necessary.
 393           - Added assertions to test _PATH_RULES_SPECIFIER more fully.
 394
 395         * Scripts/webkitpy/style/error_handlers_unittest.py:
 396           - Updated the unit test classes as necessary.
 397           - Changed StyleErrorHandlerTestBase to store a list of error
 398             messages rather than just the last one.
 399
 400         * Scripts/webkitpy/style/filter.py:
 401           - Altered FilterConfiguration._path_rules_from_path()
 402             to convert the path_rules list to a tuple.
 403
 404         * Scripts/webkitpy/style/filter_unittest.py:
 405           - Updated the unit tests to reflect the change from tuples to
 406             lists in the _PATH_RULES_SPECIFIER configuration variable.
 407
 408 2010-02-16  Mark Rowe  <mrowe@apple.com>
 409
 410         Let's not check garbage in to common build scripts and hose the world now eh guys?
 411
 412         * Scripts/webkitdirs.pm:
 413
 414 2010-02-16  Eric Seidel  <eric@webkit.org>
 415
 416         Reviewed by Adam Barth.
 417
 418         re-factor Skipped list parsing code into multiple functions and unit test it
 419         https://bugs.webkit.org/show_bug.cgi?id=34986
 420
 421         * Scripts/test-webkitpy: Add new unit test.
 422         * Scripts/webkitpy/layout_tests/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py.
 423         * Scripts/webkitpy/layout_tests/port/mac.py: Split parsing function into multiple functions for testing.
 424         * Scripts/webkitpy/layout_tests/port/mac_unittest.py: Added.
 425
 426 2010-02-16  Xan Lopez  <xlopez@igalia.com>
 427
 428         Reviewed by Gustavo Noronha.
 429
 430         Enable 'auto-resize-window' in our DRT.
 431
 432         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 433         (resetDefaultsToConsistentValues):
 434
 435 2010-02-15  Martin Robinson  <mrobinson@webkit.org>
 436
 437         Reviewed by Darin Adler.
 438
 439         check-webkit-style should not complain about NULL sentinel in calls to g_strconcat and g_strjoin
 440         https://bugs.webkit.org/show_bug.cgi?id=34834
 441
 442         * Scripts/webkitpy/style/processors/cpp.py:
 443         * Scripts/webkitpy/style/processors/cpp_unittest.py:
 444
 445 2010-02-12  Alexey Proskuryakov  <ap@apple.com>
 446
 447         Reviewed by Kevin Decker.
 448
 449         <rdar://problem/7130641> Browser objects identity is not preserved by Safari
 450
 451         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
 452         (pluginInvoke): Added methods for checking object identity (via refcount).
 453
 454 2010-02-15  Robert Hogan  <robert@roberthogan.net>
 455
 456         Reviewed by Simon Hausmann.
 457
 458         [Qt] DRT: Support evaluateInWebInspector(), setTimelineProfilingEnabled().
 459
 460         Support LayoutTestController.evaluateInWebInspector(), setTimelineProfilingEnabled() in Qt DRT.
 461
 462         https://bugs.webkit.org/show_bug.cgi?id=33096
 463
 464         This allows the following tests to pass:
 465
 466         inspector/console-format-collections.html
 467         inspector/styles-iframe.html
 468         inspector/syntax-highlight-css.html
 469         inspector/syntax-highlight-javascript.html
 470         inspector/timeline-enum-stability.html
 471         inspector/timeline-layout.html
 472         inspector/timeline-mark-timeline.html
 473         inspector/timeline-paint.html
 474         inspector/timeline-parse-html.html
 475         inspector/timeline-recalculate-styles.html
 476         inspector/timeline-script-tag-1.html
 477         inspector/timeline-script-tag-2.html
 478         inspector/timeline-trivial.html
 479         inspector/cookie-resource-match.html
 480         inspector/elements-img-tooltip.html
 481         inspector/elements-panel-selection-on-refresh.html
 482         inspector/inspected-objects-not-overriden.html
 483         inspector/timeline-event-dispatch.html
 484         inspector/timeline-network-resource.html
 485         inspector/elements-panel-rewrite-href.html
 486         inspector/console-dir.html
 487         inspector/console-dirxml.html
 488         inspector/console-format.html
 489         inspector/console-tests.html
 490         inspector/elements-panel-structure.html
 491         inspector/evaluate-in-frontend.html
 492         inspector/console-clear.html
 493
 494         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
 495         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
 496         (WebCore::isWebInspectorTest):
 497         (WebCore::DumpRenderTree::open):
 498         * DumpRenderTree/qt/DumpRenderTreeQt.h:
 499         (WebCore::DumpRenderTree::display):
 500         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 501         (LayoutTestController::closeWebInspector):
 502         (LayoutTestController::showWebInspector):
 503         (LayoutTestController::evaluateInWebInspector):
 504         (LayoutTestController::setTimelineProfilingEnabled):
 505         (LayoutTestController::display):
 506         * DumpRenderTree/qt/LayoutTestControllerQt.h:
 507
 508 2010-02-14  Dirk Pranke  <dpranke@chromium.org>
 509
 510         Reviewed by Eric Seidel.
 511
 512         Update rebaseline-chromium-webkit-tests to work with the new code
 513         structure (port objects instead of path_utils and platform_utils).
 514
 515         Added a path_to_test_expectations_file() to the Port interface.
 516
 517         Fixed a bug in the chromium_* platform implementations where the
 518         'target' option was assumed to be set.
 519
 520         * Scripts/rebaseline-chromium-webkit-tests:
 521         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
 522         * Scripts/webkitpy/layout_tests/port/base.py:
 523         * Scripts/webkitpy/layout_tests/port/chromium.py:
 524         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
 525         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
 526         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
 527         * Scripts/webkitpy/layout_tests/port/test.py:
 528         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
 529
 530 2010-02-14  Eric Seidel  <eric@webkit.org>
 531
 532         Reviewed by Darin Adler.
 533
 534         webkit-build-directory misuses terms
 535         https://bugs.webkit.org/show_bug.cgi?id=34822
 536
 537         * Scripts/webkit-build-directory:
 538          - Add --top-level and --configuration options and make using one of them required.
 539         * Scripts/webkitpy/layout_tests/port/mac.py:
 540          - Use --top-level instead of --base.
 541
 542 2010-02-14  Chang Shu  <Chang.Shu@nokia.com>
 543
 544         Reviewed by Laszlo Gombos.
 545
 546         [Qt] Enable appcache feature.
 547         https://bugs.webkit.org/show_bug.cgi?id=34713
 548
 549         Re-land r54543 without the change in DumpRenderTree/qt/main.cpp.
 550         Persistent storage for AppCache is already initialized in
 551         DumpRenderTreeQt.cpp.
 552
 553         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
 554         (WebCore::WebPage::WebPage):
 555
 556 2010-02-12  Chang Shu  <Chang.Shu@nokia.com>
 557
 558         Not Reviewed.
 559
 560         Change case of my email address as a work-around for the following bug.
 561         https://bugs.webkit.org/show_bug.cgi?id=34717
 562
 563         * Scripts/webkitpy/committers.py:
 564
 565 2010-02-12  Darin Adler  <darin@apple.com>
 566
 567         Ignore compiled Python in more of webkitpy.
 568
 569         * Scripts/webkitpy/style/processors: Added property svn:ignore.
 570
 571 2010-02-12  Diego Gonzalez  <diego.gonzalez@openbossa.org>
 572
 573         Reviewed by Kenneth Rohde Christiansen.
 574
 575         Qt DRT now dump the frame loader callbacks when LayoutTestController()
 576         method is called.
 577
 578         LayoutTests:
 579             http/tests/security/mixedContent/data-url-script-in-iframe.html
 580             http/tests/security/mixedContent/empty-url-plugin-in-frame.html
 581             http/tests/security/mixedContent/insecure-css-in-iframe.html
 582             http/tests/security/mixedContent/insecure-iframe-in-iframe.html
 583             http/tests/security/mixedContent/insecure-image-in-iframe.html
 584             http/tests/security/mixedContent/insecure-plugin-in-iframe.html
 585             http/tests/security/mixedContent/insecure-script-in-iframe.html
 586             http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe.html
 587             http/tests/security/mixedContent/redirect-https-to-http-script-in-iframe.html
 588
 589         [Qt] Make possible Qt DRT dump frame load callbacks
 590         https://bugs.webkit.org/show_bug.cgi?id=34702
 591
 592         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 593         (LayoutTestController::reset):
 594         (LayoutTestController::dumpFrameLoadCallbacks):
 595         * DumpRenderTree/qt/LayoutTestControllerQt.h:
 596
 597 2010-02-12  Simon Hausmann  <simon.hausmann@nokia.com>
 598
 599         Reviewed by Antti Koivisto.
 600
 601         Make QtLauncher somewhat useable on S60.
 602
 603         Show the window fullscreen to make scrollbars appear, resize
 604         the toolbar buttons to 16x16 to give more screen space to
 605         web content and moved the location lineedit into a separate
 606         line.
 607
 608         * QtLauncher/main.cpp:
 609         (LauncherWindow::LauncherWindow):
 610         * QtLauncher/mainwindow.cpp:
 611         (MainWindow::buildUI):
 612
 613 2010-02-12  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
 614
 615         Reviewed by Kenneth Rohde Christiansen.
 616
 617         Support frameset flattening
 618         https://bugs.webkit.org/show_bug.cgi?id=32717
 619
 620         Add FrameSet Flattening support to Mac DRT.
 621
 622         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 623         (LayoutTestController::setFrameSetFlatteningEnabled):
 624         * DumpRenderTree/win/DumpRenderTree.cpp:
 625         (resetDefaultsToConsistentValues):
 626         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 627         (LayoutTestController::setXSSAuditorEnabled):
 628         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
 629         (LayoutTestController::setFrameSetFlatteningEnabled):
 630         * DumpRenderTree/LayoutTestController.cpp:
 631         (setFrameSetFlatteningEnabledCallback):
 632         (LayoutTestController::staticFunctions):
 633         * DumpRenderTree/LayoutTestController.h:
 634         * DumpRenderTree/mac/DumpRenderTree.mm:
 635         (resetDefaultsToConsistentValues):
 636         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 637         (LayoutTestController::setFrameSetFlatteningEnabled):
 638
 639 2010-02-12  Dirk Pranke  <dpranke@chromium.org>
 640
 641         Reviewed by Eric Seidel.
 642
 643         Fix typos in driver_test.py
 644
 645         https://bugs.webkit.org/show_bug.cgi?id=34810
 646
 647         * Scripts/webkitpy/layout_tests/driver_test.py:
 648
 649 2010-02-12  Simon Hausmann  <simon.hausmann@nokia.com>
 650
 651         Reviewed by Kenneth Rohde Christiansen.
 652
 653         [Qt] Make it possible to toggle the use of QGraphicsView in QtLauncher at run-time
 654         https://bugs.webkit.org/show_bug.cgi?id=34844
 655
 656         * QtLauncher/main.cpp:
 657         (LauncherWindow::LauncherWindow):
 658         (LauncherWindow::initializeView):
 659         (LauncherWindow::setupUI):
 660         * QtLauncher/webview.cpp:
 661         (WebViewGraphicsBased::WebViewGraphicsBased):
 662
 663 2010-02-11  Fumitoshi Ukai  <ukai@chromium.org>
 664
 665         Reviewed by Alexey Proskuryakov.
 666
 667         WebSocket ignores HttpOnly cookies, but should use in Handshake.
 668         https://bugs.webkit.org/show_bug.cgi?id=34289
 669
 670         Update pywebsocket to 0.4.8, which supports cgi directories.
 671         run-webkit-tests and run-webkit-websocketserver will run
 672         pywebsocket, specifying /websocket/test/cookies as cgi directory.
 673
 674         * Scripts/run-webkit-tests:
 675         * Scripts/run-webkit-websocketserver:
 676         * pywebsocket/mod_pywebsocket/standalone.py:
 677         * pywebsocket/setup.py:
 678
 679 2010-02-11  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
 680
 681         Reviewed by Dan Bernstein.
 682
 683         [Mac] Duplicated setXSSAuditorEnabled preference at Mac DRT
 684         https://bugs.webkit.org/show_bug.cgi?id=34798
 685
 686         Remove duplicated setXSSAuditorEnabled preference at Mac DRT
 687
 688         * DumpRenderTree/mac/DumpRenderTree.mm:
 689         (resetDefaultsToConsistentValues):
 690
 691 2010-02-11  Eric Seidel  <eric@webkit.org>
 692
 693         No review, build fix only.
 694
 695         webkitdirs.pm has a crazy amount of duplicated feature detection code
 696         https://bugs.webkit.org/show_bug.cgi?id=34869
 697
 698         * Scripts/build-webkit: Fix typo which broke bots.
 699
 700 2010-02-11  Eric Seidel  <eric@webkit.org>
 701
 702         Reviewed by Adam Barth.
 703
 704         webkitdirs.pm has a crazy amount of duplicated feature detection code
 705         https://bugs.webkit.org/show_bug.cgi?id=34869
 706
 707         * Scripts/build-webkit: Use the new hotness.
 708         * Scripts/run-webkit-tests: ditto
 709         * Scripts/webkitdirs.pm: Remove a bunch of bad duplicate code.
 710         * Scripts/webkitperl/features.pm: Added.
 711          - Simplified the 10 methods in webkitdirs.pm into 2 exported methods in this new file.
 712
 713 2010-02-11  Daniel Bates  <dbates@rim.com>
 714
 715         Reviewed by Adam Barth.
 716
 717         https://bugs.webkit.org/show_bug.cgi?id=34830
 718
 719         Makes method User.prompt static and adds the parameter repeat
 720         to prompt the user up to repeat times.
 721
 722         * Scripts/test-webkitpy:
 723         * Scripts/webkitpy/bugzilla.py: Substituted method User.prompt for method raw_input.
 724         * Scripts/webkitpy/commands/upload.py: Ditto
 725         * Scripts/webkitpy/credentials.py: Ditto
 726         * Scripts/mock_bugzillatool.py: Updated prototype of MockUser.prompt to match User.prompt.
 727         * Scripts/webkitpy/user.py: Made method prompt static and added parameter repeat.
 728         * Scripts/webkitpy/user_unittest.py: Added.
 729
 730 2010-02-10  Yuzo Fujishima  <yuzo@google.com>
 731
 732         Reviewed by Darin Adler.
 733
 734         Allow underscored identifiers in CSSParser.cpp
 735
 736         Flex (http://flex.sourceforge.net/) uses identifiers named as yy_*.
 737         WebCore/css/CSSParser.cpp needs to handle some such identifiers.
 738         We should relax the style rule for the file to allow underscored identifiers.
 739
 740         https://bugs.webkit.org/show_bug.cgi?id=34787
 741
 742         * Scripts/webkitpy/style/checker.py:
 743
 744 2010-02-11  Eric Seidel  <eric@webkit.org>
 745
 746         Rubber-stamped by Adam Barth.
 747
 748         Remove DrawTest, the application I used when bringing up SVG support on the Mac.
 749         The code hasn't been touched (or used) in years.  No sense in keeping it in trunk.
 750
 751         * Scripts/build-drawtest: Removed.
 752         * Scripts/run-drawtest: Removed.
 753         * DrawTest: Removed.
 754
 755 2010-02-11  Eric Seidel  <eric@webkit.org>
 756
 757         Reviewed by Adam Barth.
 758
 759         Need a command to clear r+ on obsolete patches in the pending-commit queue.
 760         https://bugs.webkit.org/show_bug.cgi?id=34863
 761
 762         Unfortunately our http://webkit.org/pending-commit bugzilla query is not
 763         smart enough to ignore obsolete patches, so bugs show up there which are
 764         still open, but do not have patches ready for landing on them.
 765         This new command "clean-pending-commit" will remove r+ from obsolete patches
 766         in the pending-commit list.
 767
 768         * Scripts/test-webkitpy: Add grammar_unittest
 769         * Scripts/webkitpy/commands/upload.py: Add clean-pending-commit and make assign-to-committer ignore cq+'d patches.
 770         * Scripts/webkitpy/grammar.py: Add join_with_separators
 771         * Scripts/webkitpy/grammar_unittest.py: Added.
 772
 773 2010-02-11  Eric Seidel  <eric@webkit.org>
 774
 775         Reviewed by Adam Barth.
 776
 777         run-chromium-webkit-tests fails random pixel tests on Mac
 778         https://bugs.webkit.org/show_bug.cgi?id=34862
 779
 780         This is due to the fact that the Mac port has an
 781         invalid path to the image diff tool.  Currently it points
 782         to image_diff even though ImageDiff would be correct.  We
 783         can't change it to the right path yet without causing the
 784         script to hang.  ImageDiff expects to be long-running and
 785         be passed image data over stdin.  image_diff (chromium's fork)
 786         expects to be passed command line arguments.
 787         This fix works around the random failures by disabling pixel
 788         tests on mac and logging if the user was trying to run with pixel
 789         tests enabled.
 790
 791         * Scripts/webkitpy/layout_tests/port/mac.py:
 792
 793 2010-02-11  Nikolas Zimmermann  <nzimmermann@rim.com>
 794
 795         Reviewed by Adam Roben.
 796         Try to fix build breakage from r54665.
 797
 798         * Scripts/check-for-global-initializers:
 799
 800 2010-02-11  Simon Hausmann  <simon.hausmann@nokia.com>
 801
 802         Reviewed by Tor Arne Vestbø.
 803
 804         Make it possible to toggle accelerated compositing from the menu
 805         at run-time.
 806
 807         * QtLauncher/main.cpp:
 808         (LauncherWindow::toggleAcceleratedCompositing):
 809         (LauncherWindow::setupUI):
 810
 811 2010-02-08  Maciej Stachowiak  <mjs@apple.com>
 812
 813         Reviewed by Cameron Zwarich.
 814
 815         Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose.
 816         https://bugs.webkit.org/show_bug.cgi?id=34698
 817
 818         * Scripts/build-webkit:
 819
 820 2010-02-10  Dirk Pranke  <dpranke@chromium.org>
 821
 822         Reviewed by Eric Seidel.
 823
 824         Fix various minor bugs keeping run-chromium-webkit-tests from actually
 825         working on the linux and win ports of Chromium.
 826
 827         https://bugs.webkit.org/show_bug.cgi?id=34739
 828
 829         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
 830         * Scripts/webkitpy/layout_tests/port/__init__.py:
 831         * Scripts/webkitpy/layout_tests/port/base.py:
 832         * Scripts/webkitpy/layout_tests/port/chromium.py:
 833         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
 834         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
 835         * Scripts/webkitpy/layout_tests/port/http_server.py:
 836         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
 837
 838 2010-02-10  Eric Seidel  <eric@webkit.org>
 839
 840         Reviewed by David Levin.
 841
 842         run-chromium-webkit-tests --platform=mac-leopard crashes when using a custom build directory
 843         https://bugs.webkit.org/show_bug.cgi?id=34817
 844
 845         This doesn't fix the root cause of us not
 846         correctly failing when support binaries are missing.
 847         This only causes the DumpRenderTree binary not to be
 848         missing in the custom build directory case.
 849         Later patches will make us correctly fail fast when
 850         support binaries (like DumpRenderTree or ImageDiff) are missing.
 851
 852         * Scripts/webkit-build-directory: Added.
 853          - Need a way to re-use the perl logic for finding build directories in non-perl scripts.
 854         * Scripts/webkitpy/layout_tests/port/base.py: Add a FIXME.
 855         * Scripts/webkitpy/layout_tests/port/mac.py:
 856          - Call webkit-build-directory to find the build directory instead of assuming "WebKitBuild"
 857         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Add FIXMEs.
 858
 859 2010-02-10  Kevin Watters  <kevinwatters@gmail.com>
 860
 861         Reviewed by Kevin Ollivier.
 862
 863         [wx] Add Windows complex text support.
 864
 865         https://bugs.webkit.org/show_bug.cgi?id=34759
 866
 867         * wx/build/settings.py:
 868
 869 2010-02-10  Kevin Ollivier  <kevino@theolliviers.com>
 870
 871         [wx] Build fix. Add stub for new LayoutTestController method.
 872
 873         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
 874         (LayoutTestController::numberOfPages):
 875
 876 2010-02-10  Csaba Osztrogonác  <ossy@webkit.org>
 877
 878         Unreviewed. Roll out r54626, because it broke GTK and Win build.
 879         https://bugs.webkit.org/show_bug.cgi?id=32717
 880
 881         * DumpRenderTree/LayoutTestController.cpp:
 882         (LayoutTestController::staticFunctions):
 883         * DumpRenderTree/LayoutTestController.h:
 884         * DumpRenderTree/mac/DumpRenderTree.mm:
 885         (resetDefaultsToConsistentValues):
 886         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 887
 888 2010-02-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
 889
 890         Reviewed by Kenneth Rohde Christiansen.
 891
 892         Support frameset flattening
 893         https://bugs.webkit.org/show_bug.cgi?id=32717
 894
 895         Add FrameSet Flattening support to Mac DRT.
 896
 897         * DumpRenderTree/LayoutTestController.cpp:
 898         (setFrameSetFlatteningEnabledCallback):
 899         (LayoutTestController::staticFunctions):
 900         * DumpRenderTree/LayoutTestController.h:
 901         * DumpRenderTree/mac/DumpRenderTree.mm:
 902         (resetDefaultsToConsistentValues):
 903         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 904         (LayoutTestController::setFrameSetFlatteningEnabled):
 905
 906 2010-02-08  Jon Honeycutt  <jhoneycutt@apple.com>
 907
 908         <rdar://problem/7436875> Crash in Flash when visiting
 909         http://www.cctv.com/default.shtml (WER ID 819298200) [watson 2502260]
 910
 911         Reviewed by Darin Adler.
 912
 913         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
 914         (executeScript):
 915         Moved to an earlier point in the file.
 916         (NPP_New):
 917         If the plug-in has an onDestroy attribute, store its value.
 918         (NPP_Destroy):
 919         If the plug-in has code to run on destruction, run it and free it.
 920
 921 2010-02-10  Diego Gonzalez  <diego.gonzalez@openbossa.org>
 922
 923         Reviewed by Kenneth Rohde Christiansen.
 924
 925         Implement pageNumberForElementById() method in Qt DRT LayoutTestController,
 926         to make Qt DRT able to get page number.
 927
 928         LayoutTests:
 929             printing/page-break-always.html
 930             printing/pageNumerForElementById.html
 931             printing/css2.1/page-break-before-000.html
 932             printing/css2.1/page-break-after-000.html
 933             printing/css2.1/page-break-after-004.html
 934             printing/css2.1/page-break-before-001.html
 935             printing/css2.1/page-break-after-001.html
 936             printing/css2.1/page-break-after-002.html
 937             printing/css2.1/page-break-before-002.html
 938             printing/css2.1/page-break-inside-000.html
 939
 940         [Qt] Make possible Qt DRT get a page number for element by ID
 941         https://bugs.webkit.org/show_bug.cgi?id=34777
 942
 943         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 944         (LayoutTestController::pageNumberForElementById):
 945         * DumpRenderTree/qt/LayoutTestControllerQt.h:
 946
 947 2010-02-10  Andras Becsi  <abecsi@webkit.org>
 948
 949         Reviewed by Adam Barth.
 950
 951         Make run-iexploder-tests work on Linux.
 952         https://bugs.webkit.org/show_bug.cgi?id=34748
 953
 954         Extract the platform dependant Apache configuration checking code in httpd.pm to a separate function
 955         called getHTTPDConfigPathForTestDirectory and use run-launcher instead of run-safari if run on Linux.
 956
 957         * Scripts/run-iexploder-tests:
 958         * Scripts/webkitperl/httpd.pm:
 959
 960 2010-02-09  Csaba Osztrogonác  <ossy@webkit.org>
 961
 962         [Qt] Unreviewed. Roll-out r54543, because layout tests crash in debug mode.
 963         https://bugs.webkit.org/show_bug.cgi?id=34713
 964
 965         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
 966         (WebCore::WebPage::WebPage):
 967         * DumpRenderTree/qt/main.cpp:
 968         (main):
 969
 970 2010-02-09  Alejandro G. Castro  <alex@igalia.com>
 971
 972         Unreviewed; added myself to committers
 973
 974         * Scripts/webkitpy/committers.py:
 975
 976 2010-02-09  Yael Aharon  <yael.aharon@nokia.com>
 977
 978         Reviewed by Kenneth Rohde Christiansen.
 979
 980         [Qt] Webkit in Qt does not have window.showModalDialog
 981         https://bugs.webkit.org/show_bug.cgi?id=25585
 982
 983         Set the modality flag when createWindow is called with window type WebWindowDialog.
 984
 985         * QtLauncher/main.cpp:
 986         (WebPage::createWindow):
 987
 988 2010-02-09  Andras Becsi  <abecsi@webkit.org>
 989
 990         Unreviewed trivial warning fix.
 991
 992         * Scripts/build-webkit:
 993
 994 2010-02-09 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu>
 995
 996         Reviewed by Tor Arne Vestbø.
 997
 998         Add possibility of passing parameters to build-webkit by environment variable,
 999         because the buildbot slaves can't control the arguments.
1000
1001         * Scripts/build-webkit:
1002
1003 2010-02-09  Chang Shu  <Chang.Shu@nokia.com>
1004
1005         Reviewed by Laszlo Gombos.
1006
1007         [Qt] Enable appcache feature.
1008         https://bugs.webkit.org/show_bug.cgi?id=34713
1009
1010
1011         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1012         (WebCore::WebPage::WebPage):
1013         * DumpRenderTree/qt/main.cpp:
1014         (main):
1015
1016 2010-02-09  Shinichiro Hamaji  <hamaji@chromium.org>
1017
1018         Reviewed by Darin Adler.
1019
1020         Provide a way to get total number of pages to be printed
1021         https://bugs.webkit.org/show_bug.cgi?id=34699
1022
1023         * DumpRenderTree/LayoutTestController.cpp:
1024         (parsePageParameters):
1025         (pageNumberForElementByIdCallback):
1026         (numberOfPagesCallback):
1027         (LayoutTestController::staticFunctions):
1028         * DumpRenderTree/LayoutTestController.h:
1029         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1030         (LayoutTestController::numberOfPages):
1031         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1032         (LayoutTestController::numberOfPages):
1033         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1034         (LayoutTestController::numberOfPages):
1035
1036 2010-02-08  Alexey Proskuryakov  <ap@apple.com>
1037
1038         Reviewed by Darin Adler.
1039
1040         https://bugs.webkit.org/show_bug.cgi?id=34727
1041         Assertion crashes and freezes when plug-in property access results in an exception
1042
1043         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1044         (pluginGetProperty): Raise an exception when accessing a particular property.
1045         (pluginSetProperty): Ditto.
1046         (pluginInvoke): Added methods to get and set host object properties.
1047
1048 2010-02-08  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1049
1050         Reviewed by Ariya Hidayat.
1051
1052         [Qt] Backport No'am Rosenthal's frame rate measurement
1053
1054         * QtLauncher/main.cpp:
1055         (LauncherWindow::LauncherWindow):
1056         (LauncherApplication::handleUserOptions):
1057         * QtLauncher/webview.cpp:
1058         (WebViewGraphicsBased::WebViewGraphicsBased):
1059         (WebViewGraphicsBased::enableFrameRateMeasurement):
1060         (WebViewGraphicsBased::updateFrameRate):
1061         (WebViewGraphicsBased::paintEvent):
1062         * QtLauncher/webview.h:
1063
1064 2010-02-08  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1065
1066         Reviewed by Tor Arne Vestbø.
1067
1068         [Qt] Make overridePreference complain when it does not
1069         support the preference given.
1070
1071         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1072         (LayoutTestController::overridePreference):
1073
1074 2010-02-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1075
1076         Reviewed by Kenneth Rohde Christiansen.
1077
1078         [Qt] Set stdout/stderr to binary mode for DRT on Windows
1079
1080         This makes sure we don't end up with lots of CRLFs in the
1081         DRT output, which breaks tons of results. Matches what
1082         the Windows DRT does.
1083
1084         * DumpRenderTree/qt/main.cpp:
1085
1086 2010-02-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1087
1088         Reviewed by Kenneth Rohde Christiansen.
1089
1090         Build fix for Qt on Windows.
1091
1092         Don't use noreturn directly since it's a gcc attribute.
1093         Instead use the NO_RETURN macro from AlwaysInline.h
1094
1095         * QtLauncher/QtLauncher.pro:
1096         * QtLauncher/utils.h:
1097
1098 2010-02-05  Chris Jerdonek  <cjerdonek@webkit.org>
1099
1100         Reviewed by Shinichiro Hamaji.
1101
1102         Suppressed check-webkit-style's underscore check in Qt's autotests.
1103         Also made the path-specific filter check case-insensitive.
1104
1105         https://bugs.webkit.org/show_bug.cgi?id=34574
1106
1107         * Scripts/webkitpy/style/checker.py:
1108           - Added a list element to _PATH_RULES_SPECIFIER for
1109             directories that should be excluded from the
1110             "readability/naming" category (the category that relates to
1111             underscores in identifiers, for example).
1112
1113         * Scripts/webkitpy/style/checker_unittest.py:
1114           - Added an "end-to-end" test for "WebKit/qt/tests/".
1115
1116         * Scripts/webkitpy/style/filter.py:
1117           - Altered FilterConfiguration's should_check() method to
1118             check for path substring matches case-insensitively.
1119
1120         * Scripts/webkitpy/style/filter_unittest.py:
1121           - Added a test to check case-insensitive path substring matching.
1122
1123         * Scripts/webkitpy/style/processors/cpp.py:
1124           - Removed the hard-coded "WebKit/gtk/webkit/" path reference
1125             since this is now taken care of by the _PATH_RULES_SPECIFIER
1126             configuration variable.
1127
1128         * Scripts/webkitpy/style/processors/cpp_unittest.py:
1129           - Removed the unit test for the GTK directory since this
1130             is now taken care of by the checker._PATH_RULES_SPECIFIER
1131             end-to-end tests.
1132
1133 2010-02-08  Leith Bade  <leith@leithalweapon.geek.nz>
1134
1135         Reviewed by Darin Adler.
1136
1137         Fixes: https://bugs.webkit.org/show_bug.cgi?id=34637
1138         Corrects the newline inserted into WebKitOutputDir, and WebKitLibrariesDir Windows
1139         environemnt variables when there is a space in the user's /home path.
1140
1141         * Scripts/webkitdirs.pm:
1142          - Added missing quotes around $sourceDir in argument list of cygpath in determineWindowsSourceDir().
1143
1144 2010-02-05  Alexey Proskuryakov  <ap@apple.com>
1145
1146         Reviewed by Oliver Hunt.
1147
1148         https://bugs.webkit.org/show_bug.cgi?id=34670
1149         TestNetscapePlugin should work with Firefox
1150
1151         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New): Default to Carbon if
1152         browser doesn't tell what it supports.
1153
1154 2010-02-05  Shinichiro Hamaji  <hamaji@chromium.org>
1155
1156         Reviewed by Gustavo Noronha Silva.
1157
1158         [Gtk] Implement layoutTestController.pageNumberForElementById
1159         https://bugs.webkit.org/show_bug.cgi?id=34572
1160
1161         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1162         (LayoutTestController::pageNumberForElementById):
1163
1164 2010-02-03  Dirk Pranke  <dpranke@chromium.org>
1165
1166         Reviewed by Eric Seidel.
1167
1168         Add a simple test implementation and the WebKit Mac implementation
1169         for the layout_tests/port package. Also add a simple test driver of
1170         that interface.
1171
1172         https://bugs.webkit.org/show_bug.cgi?id=34511
1173
1174         * Scripts/webkitpy/layout_tests/driver_test.py: Added.
1175         * Scripts/webkitpy/layout_tests/port/__init__.py:
1176         * Scripts/webkitpy/layout_tests/port/mac.py: Added.
1177         * Scripts/webkitpy/layout_tests/port/test.py: Added.
1178
1179 2010-02-03  Dirk Pranke  <dpranke@chromium.org>
1180
1181         Reviewed by Eric Siedel.
1182
1183         Refactor the port package into an object-oriented style and merge
1184         path_utils into it. We add a 'base' and a 'chromium' object to the
1185         port package; this will allow us to easily add new ports (like
1186         WebKit Mac).
1187
1188         https://bugs.webkit.org/show_bug.cgi?id=34511
1189
1190         * Scripts/rebaseline-chromium-webkit-tests:
1191         * Scripts/run-chromium-webkit-tests:
1192         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1193         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1194         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1195         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
1196         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
1197         * Scripts/webkitpy/layout_tests/port/__init__.py:
1198         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1199         * Scripts/webkitpy/layout_tests/port/base.py: Added.
1200         * Scripts/webkitpy/layout_tests/port/chromium.py: Added.
1201         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1202         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1203         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1204         * Scripts/webkitpy/layout_tests/port/http_server.py:
1205         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1206         * Scripts/webkitpy/layout_tests/port/path_utils.py: Removed.
1207         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1208         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1209         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
1210         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
1211         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1212         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1213         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1214
1215 2010-01-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1216
1217         Reviewed by Dave Hyatt.
1218
1219         Implement flattening of framesets
1220         https://bugs.webkit.org/show_bug.cgi?id=32717
1221
1222         Add support for testing frame flattening with the Qt DRT
1223
1224         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1225         (LayoutTestController::setFrameSetFlatteningEnabled):
1226         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1227
1228 2010-02-03  Chris Jerdonek  <cjerdonek@webkit.org>
1229
1230         Reviewed by Shinichiro Hamaji.
1231
1232         Provided a way in check-webkit-style to specify filter rules
1233         on a per file or folder basis, via a configuration variable.
1234
1235         https://bugs.webkit.org/show_bug.cgi?id=33684
1236
1237         * Scripts/webkitpy/style/checker.py:
1238           - Added _PATH_RULES_SPECIFIER configuration variable.
1239           - In ProcessorOptions class--
1240             - Changed the CategoryFilter attribute to FilterConfiguration.
1241             - Added path parameter to is_reportable().
1242           - Renamed ArgumentDefaults filter_rules attribute to
1243             base_filter_rules.
1244           - Updated ArgumentPrinter class.
1245           - Added filter rule validation to ArgumentParser (instead of
1246             in CategoryFilter constructor).
1247
1248         * Scripts/webkitpy/style/checker_unittest.py:
1249           - Updated unit tests as necessary.
1250           - Added unit tests for PATH_RULES_SPECIFIER.
1251
1252         * Scripts/webkitpy/style/error_handlers.py:
1253           - Updated DefaultStyleErrorHandler to use file path when
1254             calling is_reportable().
1255
1256         * Scripts/webkitpy/style/error_handlers_unittest.py:
1257           - Updated unit tests as necessary.
1258
1259         * Scripts/webkitpy/style/filter.py:
1260           - Marked CategoryFilter internal with an underscore.
1261           - Removed argument validation from CategoryFilter.
1262           - Added FilterConfiguration class.
1263
1264         * Scripts/webkitpy/style/filter_unittest.py:
1265           - Updated CategoryFilterTest class.
1266           - Added FilterConfigurationTest unit tests.
1267
1268         * Scripts/webkitpy/style/processors/cpp.py:
1269           - Removed _is_test_filename() code.
1270           - Removed hard-coded path checks from check_include_line().
1271
1272         * Scripts/webkitpy/style/processors/cpp_unittest.py:
1273           - Removed three unit tests related to exempted files.
1274
1275 2010-02-05  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1276
1277         Reviewed by Ariya Hidayat.
1278
1279         [Qt] Apply the command line options as settings to the
1280         graphics system.
1281
1282         * QtLauncher/main.cpp:
1283         (LauncherWindow::LauncherWindow):
1284         (requiresGraphicsView):
1285         (LauncherApplication::handleUserOptions):
1286         * QtLauncher/webview.h:
1287         (WebViewGraphicsBased::setItemCacheMode):
1288
1289 2010-02-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1290
1291         Reviewed by Simon Hausmann.
1292
1293         Notify user that run-webkit-tests has to be run under Cygwin
1294
1295         The script will bail out if run under Windows shell or Msys.
1296
1297         * Scripts/run-webkit-tests:
1298         * Scripts/webkitdirs.pm:
1299
1300 2010-02-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1301
1302         Reviewed by Simon Hausmann.
1303
1304         [Qt] Generate convenience headers (QWebView, etc) using qmake
1305
1306         In Qt this is done using syncqt, but we use a pro-file instead
1307         that generates makefile-rules for each of the extra headers.
1308
1309         These extra headers are installed alongside the normal headers.
1310
1311         * Scripts/webkitdirs.pm: Run qmake and make on new API-DerivedSources
1312
1313 2010-02-05  Andras Becsi  <abecsi@webkit.org>
1314
1315         Unreviewed typo fix.
1316
1317         Fix wrong whitespace alignment introduced in r54342.
1318
1319         * Scripts/run-webkit-tests:
1320
1321 2010-02-04  Mark Rowe  <mrowe@apple.com>
1322
1323         Reviewed by Timothy Hatcher.
1324
1325         Build fix.  Remove a symbol corresponding to an inline function from the linker export
1326         file to prevent a weak external failure.
1327
1328         * Scripts/check-for-weak-vtables-and-externals: Renamed from WebKitTools/Scripts/check-for-weak-vtables.
1329         Teach the script how to detect weak external symbols so that these errors can be caught immediately
1330         in the future.
1331
1332 2010-02-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1333
1334         Rubberstamped by Oliver Hunt.
1335
1336         [Qt] Make it possible to choose whether the launcher should
1337         use the traditional QWidget based QWebView or the newer
1338         QGraphics based QGraphicsWebView on a QGraphicsView.
1339
1340         * QtLauncher/main.cpp:
1341         (LauncherWindow::LauncherWindow):
1342         (LauncherWindow::eventFilter):
1343         (LauncherWindow::loadStarted):
1344         (LauncherWindow::print):
1345         (LauncherWindow::screenshot):
1346         (LauncherWindow::setEditable):
1347         (LauncherWindow::setupUI):
1348         (main):
1349         * QtLauncher/webview.cpp:
1350         (WebViewGraphicsBased::WebViewGraphicsBased):
1351         (WebViewGraphicsBased::resizeEvent):
1352         (GraphicsWebView::mousePressEvent):
1353         (GraphicsWebView::contextMenuEvent):
1354         * QtLauncher/webview.h:
1355         (WebViewTraditional::WebViewTraditional):
1356         (GraphicsWebView::GraphicsWebView):
1357         (WebViewGraphicsBased::setPage):
1358
1359 2010-02-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1360
1361         Rubberstamped by Oliver Hunt.
1362
1363         [Qt] QtLauncher cleanup.
1364
1365         Refactor option handling out in utility functions and make the
1366         arguments more Qt compatible.
1367
1368         * QtLauncher/main.cpp:
1369         (requiresGraphicsView):
1370         (LauncherApplication::handleUserOptions):
1371         * QtLauncher/utils.cpp:
1372         (takeOptionValue):
1373         (formatKeys):
1374         (enumToKeys):
1375         (appQuit):
1376         * QtLauncher/utils.h:
1377
1378 2010-02-04  Andras Becsi  <abecsi@inf.u-szeged.hu>
1379
1380         Reviewed by Tor Arne Vestbø.
1381
1382         Implement a locking and scheduling mechanism for http testing sessions to be able
1383         to run multiple instances of run-webkit-tests parallel on the same machine.
1384         If a test session wants to run http tests and this feature is enabled, the pending
1385         sessions create lockfiles with sequential lock numbers. These locks are used to schedule
1386         the running test sessions in first come first served order. An exclusive lock ensures
1387         that the lock numbers are sequential to avoid deadlocks and starvation.
1388         Because the buildbot master specifies the flags used by slaves we need an environment
1389         variable too to be able to use the feature per-slave.
1390         Exporting WEBKIT_WAIT_FOR_HTTPD=1 before testing or using the --wait-for-httpd
1391         flag enables this feature, otherwise this patch has no effect on the testing whatsoever.
1392
1393         https://bugs.webkit.org/show_bug.cgi?id=33153
1394
1395         * Scripts/run-webkit-tests:
1396         * Scripts/webkitperl/httpd.pm:
1397
1398 2010-01-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1399
1400         Reviewed by Simon Hausmann.
1401
1402         Make run-webkit-tests work under Cygwin for the Qt port
1403
1404         setPathForRunningWebKitApp() is implemented for the Qt port
1405         by using qmake to query for the location of the Qt libraries.
1406
1407         This requires the original environment (%ENV) to be untouched,
1408         so launchWithCurrentEnv() was refactored to launchWithEnv(),
1409         and the code in openDumpTool() to not use %ENV but a %CLEAN_ENV
1410         instead. This has the added benefit of getting rid of the temp
1411         variables used for storing the current env.
1412
1413         openDumpTool() is also refactored a bit into platform-spesific,
1414         port-spesific, and generic environment variables.
1415
1416         Checks for undef was added a few places to fix Perl concat
1417         warnings when run-webkit-tests is aborted.
1418
1419         https://bugs.webkit.org/show_bug.cgi?id=33895
1420
1421         * Scripts/run-webkit-tests:
1422         * Scripts/webkitdirs.pm:
1423
1424 2010-02-04  Yuzo Fujishima  <yuzo@google.com>
1425
1426         Unreviewed.
1427
1428         Add Yuzo to the committers list.
1429
1430         * Scripts/webkitpy/committers.py:
1431
1432 2010-02-03  Dirk Pranke  <dpranke@chromium.org>
1433
1434         Rubber-stamped by Eric Seidel.
1435
1436         Change "the Chromium name" to "the name of Google Inc." in the licenses
1437
1438         https://bugs.webkit.org/show_bug.cgi?id=34511
1439
1440         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1441         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1442         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
1443         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1444         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1445         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
1446         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
1447         * Scripts/webkitpy/layout_tests/port/__init__.py:
1448         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1449         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1450         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1451         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1452         * Scripts/webkitpy/layout_tests/port/http_server.py:
1453         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1454         * Scripts/webkitpy/layout_tests/port/path_utils.py:
1455         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1456         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1457         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
1458         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
1459         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1460         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1461         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1462
1463 2010-02-03  Dirk Pranke  <dpranke@chromium.org>
1464
1465         Rubber-stamped by Eric Siedel.
1466
1467         Rename files as part of refactoring the layout_tests package. All
1468         the platform_utils* module, the path_utils.py module, and
1469         the http server and web socket server modules are moved into a new
1470         port/ package.
1471
1472         https://bugs.webkit.org/show_bug.cgi?id=34511
1473
1474         * Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py: Removed.
1475         * Scripts/webkitpy/layout_tests/layout_package/http_server.py: Removed.
1476         * Scripts/webkitpy/layout_tests/layout_package/http_server_base.py: Removed.
1477         * Scripts/webkitpy/layout_tests/layout_package/httpd2.pem: Removed.
1478         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1479         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1480         * Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf: Removed.
1481         * Scripts/webkitpy/layout_tests/layout_package/path_utils.py: Removed.
1482         * Scripts/webkitpy/layout_tests/layout_package/platform_utils.py: Removed.
1483         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py: Removed.
1484         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py: Removed.
1485         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py: Removed.
1486         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1487         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
1488         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
1489         * Scripts/webkitpy/layout_tests/layout_package/websocket_server.py: Removed.
1490         * Scripts/webkitpy/layout_tests/port: Added.
1491         * Scripts/webkitpy/layout_tests/port/__init__.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils.py.
1492         * Scripts/webkitpy/layout_tests/port/apache_http_server.py: Copied from Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py.
1493         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py.
1494         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py.
1495         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py.
1496         * Scripts/webkitpy/layout_tests/port/http_server.py: Copied from Scripts/webkitpy/layout_tests/layout_package/http_server.py.
1497         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Copied from Scripts/webkitpy/layout_tests/layout_package/http_server_base.py.
1498         * Scripts/webkitpy/layout_tests/port/httpd2.pem: Copied from Scripts/webkitpy/layout_tests/layout_package/httpd2.pem.
1499         * Scripts/webkitpy/layout_tests/port/lighttpd.conf: Copied from Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf.
1500         * Scripts/webkitpy/layout_tests/port/path_utils.py: Copied from Scripts/webkitpy/layout_tests/layout_package/path_utils.py.
1501         * Scripts/webkitpy/layout_tests/port/websocket_server.py: Copied from Scripts/webkitpy/layout_tests/layout_package/websocket_server.py.
1502         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1503         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
1504         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
1505         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1506         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1507         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1508
1509
1510 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
1511
1512         Rubber-stamped by Eric Seidel.
1513
1514         Roll back r53559 and r54084 again, because roll out didn't solve flakeyness on the Windows Test bots
1515         https://bugs.webkit.org/show_bug.cgi?id=34399
1516
1517         * Scripts/run-iexploder-tests:
1518         * Scripts/run-webkit-httpd:
1519         * Scripts/run-webkit-tests:
1520         * Scripts/webkitperl/httpd.pm: Added.
1521
1522 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
1523
1524         Rubber-stamped by Eric Seidel.
1525
1526         Roll out r53559 and r54084, because it might caused flakeyness on the Windows Test bots
1527
1528         * Scripts/run-iexploder-tests:
1529         * Scripts/run-webkit-httpd:
1530         * Scripts/run-webkit-tests:
1531         * Scripts/webkitperl/httpd.pm: Removed.
1532
1533 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
1534
1535         Rubber-stamped by Ariya Hidayat.
1536
1537         Roll back r53889 again, because roll out didn't solve flakeyness on the Windows Test bots
1538         https://bugs.webkit.org/show_bug.cgi?id=34399
1539
1540         * DumpRenderTree/win/EventSender.cpp:
1541         (buildModifierFlags):
1542         (mouseDownCallback):
1543         (mouseUpCallback):
1544         (keyDownCallback):
1545
1546 2010-02-03  Eric Seidel  <eric@webkit.org>
1547
1548         No review, just fixing copyrights.
1549
1550         Concerns were expressed about "The Chromium Authors" being
1551         a valid legal entity for copyright assignment in the WebKit repository,
1552         so this change removes all "The Chromium Authors".
1553
1554         I looked at the svn logs in src.chromium.org and failed to find any
1555         non-google contributions to these files, so they are all now
1556         marked as copyright "Google Inc" as all Google contributers assign
1557         copyright to "Google Inc" as part of their employment agreement.
1558
1559         * Scripts/rebaseline-chromium-webkit-tests:
1560         * Scripts/run-chromium-webkit-tests:
1561         * Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py:
1562         * Scripts/webkitpy/layout_tests/layout_package/http_server.py:
1563         * Scripts/webkitpy/layout_tests/layout_package/http_server_base.py:
1564         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1565         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1566         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
1567         * Scripts/webkitpy/layout_tests/layout_package/path_utils.py:
1568         * Scripts/webkitpy/layout_tests/layout_package/platform_utils.py:
1569         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py:
1570         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py:
1571         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py:
1572         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1573         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1574         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
1575         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
1576         * Scripts/webkitpy/layout_tests/layout_package/websocket_server.py:
1577         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1578         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
1579         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
1580         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1581         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1582         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1583
1584 2010-02-03  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1585
1586         Reviewed by Ariya Hidayat.
1587
1588         [Qt] QtLauncher, refactor argument handling in preparation of merge
1589         with QGVLauncher
1590
1591         * QtLauncher/main.cpp:
1592         (LauncherApplication::urls):
1593         (LauncherApplication::isRobotized):
1594         (LauncherApplication::applyDefaultSettings):
1595         (LauncherApplication::LauncherApplication):
1596         (LauncherApplication::formatKeys):
1597         (LauncherApplication::enumToKeys):
1598         (fail):
1599         (LauncherApplication::handleUserOptions):
1600         (main):
1601
1602 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
1603
1604         Rubber-stamped by Ariya Hidayat.
1605
1606         Rolling out r53889, because it might caused flakeyness on the Windows Test bots
1607         https://bugs.webkit.org/show_bug.cgi?id=34399
1608
1609         * DumpRenderTree/win/EventSender.cpp:
1610         (mouseDownCallback):
1611         (mouseUpCallback):
1612         (keyDownCallback):
1613
1614 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
1615
1616         Reviewed by Ariya Hidayat.
1617
1618         [Qt] Fix pixel tests support.
1619         https://bugs.webkit.org/show_bug.cgi?id=27813
1620
1621         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1622         (WebCore::DumpRenderTree::open):
1623         (WebCore::DumpRenderTree::processLine):
1624          - Hash processing mechanism moved from DumpRenderTree::open to DumpRenderTree::processLine.
1625         (WebCore::DumpRenderTree::dump): Fixed and renamed variables.
1626
1627 2010-02-03  Kevin Watters  <kevinwatters@gmail.com>
1628
1629         Reviewed by Kevin Ollivier.
1630
1631         [wx] Enable JIT compilation for wx.
1632
1633         https://bugs.webkit.org/show_bug.cgi?id=34536
1634
1635         * wx/build/settings.py:
1636
1637 2010-02-02  Kevin Ollivier  <kevino@theolliviers.com>
1638
1639         [wx] Build fix after introduction of pageNumberForElementById.
1640
1641         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1642         (LayoutTestController::pageNumberForElementById):
1643
1644 2010-02-02  Shu Chang  <Chang.Shu@nokia.com>
1645
1646         Unreviewed.
1647
1648         Add myself to list of committers.
1649
1650         * Scripts/webkitpy/committers.py:
1651
1652 2010-02-02  Chris Jerdonek  <cjerdonek@webkit.org>
1653
1654         Reviewed by Shinichiro Hamaji.
1655
1656         Moved filter-related check-webkit-style code into a separate
1657         filter module.
1658
1659         https://bugs.webkit.org/show_bug.cgi?id=34408
1660
1661         This is preparatory refactoring for Bug 33684, which will allow
1662         file and folder-specific filter rules.
1663
1664         * Scripts/webkitpy/style/checker.py:
1665           - Removed CategoryFilter class (moved to filter.py).
1666
1667         * Scripts/webkitpy/style/checker_unittest.py:
1668           - Removed CategoryFilter unit tests (moved to filter_unittest.py).
1669
1670         * Scripts/webkitpy/style/filter.py: Added.
1671           - Added CategoryFilter class (moved from checker.py).
1672
1673         * Scripts/webkitpy/style/filter_unittest.py: Added.
1674           - Added CategoryFilter unit tests (moved from checker_unittest.py).
1675
1676         * Scripts/webkitpy/style/unittests.py:
1677           - Added reference to filter_unittest.py.
1678
1679 2010-02-01  Chris Jerdonek  <cjerdonek@webkit.org>
1680
1681         Reviewed by Shinichiro Hamaji.
1682
1683         Addressed FIXME in check-webkit-style so that the carriage-return
1684         check will work for patches.
1685
1686         https://bugs.webkit.org/show_bug.cgi?id=34260
1687
1688         Also added support for limiting the number of errors reported
1689         per category, per file.
1690
1691         * Scripts/webkitpy/style/checker.py:
1692           - Added new "whitespace/carriage_return" category from common.py.
1693           - Added MAX_REPORTS_PER_CATEGORY dictionary.
1694           - Added max_reports_per_category attribute to ProcessorOptions class.
1695           - Refactored StyleChecker._process_file().
1696
1697         * Scripts/webkitpy/style/checker_unittest.py:
1698           - Updated ProcessorOptionsTest tests.
1699           - Added test to check MAX_REPORTS_PER_CATEGORY.
1700
1701         * Scripts/webkitpy/style/error_handlers.py:
1702           - Added support for suppressing the display of errors after
1703             reaching a per-category maximum (from max_reports_per_category).
1704
1705         * Scripts/webkitpy/style/error_handlers_unittest.py:
1706           - Added test for suppressing error display.
1707
1708         * Scripts/webkitpy/style/processors/common.py: Added.
1709           - Moved carriage-return check to new file.
1710
1711         * Scripts/webkitpy/style/processors/common_unittest.py: Added.
1712           - Added unit tests for carriage-return check.
1713
1714         * Scripts/webkitpy/style/unittests.py:
1715           - Added reference to common_unittest.py.
1716
1717 2010-02-01  Shinichiro Hamaji  <hamaji@chromium.org>
1718
1719         Reviewed by Eric Seidel.
1720
1721         Provide a way to get page number with layoutTestController
1722         https://bugs.webkit.org/show_bug.cgi?id=33840
1723
1724         * DumpRenderTree/LayoutTestController.cpp:
1725         (pageNumberForElementByIdCallback):
1726         (LayoutTestController::staticFunctions):
1727         * DumpRenderTree/LayoutTestController.h:
1728         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1729         (LayoutTestController::pageNumberForElementById):
1730         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1731         (LayoutTestController::pageNumberForElementById):
1732         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1733         (LayoutTestController::pageNumberForElementById):
1734
1735 2010-02-01  Shinichiro Hamaji  <hamaji@chromium.org>
1736
1737         Unreviewed fix for an invalid function call.
1738
1739         check-webkit-style: Remove filename parameter from all functions where no longer used
1740         https://bugs.webkit.org/show_bug.cgi?id=34249
1741
1742         * Scripts/webkitpy/style/checker.py:
1743
1744 2010-02-01  Diego Gonzalez  <diego.gonzalez@openbossa.org>
1745
1746         Reviewed by Kenneth Rohde Christiansen.
1747
1748         [Qt] DRT Provide global flag ability
1749         https://bugs.webkit.org/show_bug.cgi?id=34418
1750
1751         Add the globalFlag property to the Qt LayoutTestController to allow
1752         cross-domain indications.
1753
1754         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1755         (LayoutTestController::reset):
1756         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1757         (LayoutTestController::globalFlag):
1758         (LayoutTestController::setGlobalFlag):
1759
1760 2010-02-01  Brady Eidson  <beidson@apple.com>
1761
1762         Reviewed by Adele Peterson.
1763
1764         Crash in Safari opening new tabs to "same page"
1765         <rdar://problem/7593857> and https://bugs.webkit.org/show_bug.cgi?id=34444
1766
1767         Add a mode (Mac-only for now) that exercises the WebView SPI _loadBackForwardListFromOtherView:
1768
1769         * DumpRenderTree/LayoutTestController.cpp:
1770         (LayoutTestController::LayoutTestController):
1771         (setNewWindowsCopyBackForwardListCallback):
1772         (LayoutTestController::staticFunctions):
1773
1774         * DumpRenderTree/LayoutTestController.h:
1775         (LayoutTestController::newWindowsCopyBackForwardList):
1776         (LayoutTestController::setNewWindowsCopyBackForwardList):
1777
1778         * DumpRenderTree/mac/UIDelegate.mm:
1779         (-[UIDelegate webView:createWebViewWithRequest:]):
1780
1781 2010-02-01  Carol Szabo  <carol.szabo@nokia.com>
1782
1783         Unreviewed.
1784
1785         Add myself to list of committers.
1786
1787         * Scripts/webkitpy/committers.py:
1788
1789 2010-02-01  Nate Chapin  <japhet@chromium.org>
1790
1791         Rubber-stamped by David Levin.
1792
1793         Add myself to reviewer list.
1794
1795         * Scripts/webkitpy/committers.py:
1796
1797 2010-01-31  Chris Jerdonek  <cjerdonek@webkit.org>
1798
1799         Reviewed by Shinichiro Hamaji.
1800
1801         Moved style error handler code to their own classes, and
1802         related refactoring. Increased unit test code coverage of
1803         style error handling.
1804
1805         https://bugs.webkit.org/show_bug.cgi?id=34379
1806
1807         * Scripts/check-webkit-style:
1808           - Minor change: added error_count variable.
1809
1810         * Scripts/webkitpy/style/checker.py:
1811           - Renamed ProcessorOptions.should_report_error() to is_reportable().
1812           - In the StyleChecker class--
1813             - Removed _default_style_error_handler().
1814             - Added _increment_error_count().
1815             - Refactored to use DefaultStyleErrorHandler and
1816               PatchStyleErrorHandler constructors.
1817
1818         * Scripts/webkitpy/style/checker_unittest.py:
1819           - In the StyleStyleCheckerTest class--
1820             - Removed write_sample_error().
1821             - Removed test_default_style_error_handler().
1822
1823         * Scripts/webkitpy/style/error_handlers.py: Added.
1824           - Added DefaultStyleErrorHandler class.
1825           - Added PatchStyleErrorHandler class.
1826
1827         * Scripts/webkitpy/style/error_handlers_unittest.py: Added.
1828           - Added unit tests for DefaultStyleErrorHandler and
1829             PatchStyleErrorHandler.
1830
1831         * Scripts/webkitpy/style/unittests.py:
1832           - Added error_handlers unit tests.
1833
1834 2010-01-29  Mark Rowe  <mrowe@apple.com>
1835
1836         Rubber-stamped by Stephanie Lewis.
1837
1838         Fix run-leaks with newer versions of the leaks tool.
1839
1840         * Scripts/run-leaks:
1841
1842 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
1843
1844         Reviewed by Eric Siedel.
1845
1846         Top-level test drivers for running the Chromium port of run-webkit-tests
1847         and being able to rebaseline test results from the test bots.  The
1848         files in the Scripts directory are simply wrappers around the files
1849         in webkitpy/layout_tests for convenience.
1850
1851         https://bugs.webkit.org/show_bug.cgi?id=31498
1852
1853         * Scripts/rebaseline-chromium-webkit-tests: Added.
1854         * Scripts/run-chromium-webkit-tests: Added.
1855         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Added.
1856         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py: Added.
1857
1858 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
1859
1860         Reviewed by Eric Siedel.
1861
1862         Add in the second block of python code for the Chromium port
1863         of run-webkit-tests. These files execute different diffs to classify
1864         the various types of failures from a test.
1865
1866         * Scripts/webkitpy/layout_tests/test_types: Added.
1867         * Scripts/webkitpy/layout_tests/test_types/__init__.py: Added.
1868         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Added.
1869         * Scripts/webkitpy/layout_tests/test_types/image_diff.py: Added.
1870         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: Added.
1871         * Scripts/webkitpy/layout_tests/test_types/text_diff.py: Added.
1872
1873 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
1874
1875         Reviewed by Eric Siedel.
1876
1877         Check in the first part of the Chromium Python port of the
1878         run-webkit-tests test driver. The files under
1879         layout_tests/layout_layout constitute most of the implementation;
1880         they can be roughly divided into code that parses the
1881         "test_expectations.txt" file that describes how we expect tests to
1882         pass or fail, platform-specific hooks for the different Chromium
1883         ports (in platform_utils*), code for parsing the output of the
1884         tests and generating results files and HTML and JSON for the
1885         dashboards, auxiliary scripts for starting and stopping HTTP and
1886         Web Socket servers, and then one of the actual driver files
1887         (test_shell_thread). Code for actually parsing test output for
1888         failures and the top-level driver scripts will follow shortly.
1889
1890         https://bugs.webkit.org/show_bug.cgi?id=31498
1891
1892         * Scripts/webkitpy/layout_tests: Added.
1893         * Scripts/webkitpy/layout_tests/layout_package: Added.
1894         * Scripts/webkitpy/layout_tests/layout_package/__init__.py: Added.
1895         * Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py: Added.
1896         * Scripts/webkitpy/layout_tests/layout_package/http_server.py: Added.
1897         * Scripts/webkitpy/layout_tests/layout_package/http_server_base.py: Added.
1898         * Scripts/webkitpy/layout_tests/layout_package/httpd2.pem: Added.
1899           - scripts to start and stop apache. Note that the apache file
1900             generates a conf file dynamically, and we should switch to
1901             using the same static conf file that the regular run-webkit-tests
1902             uses, and we can also use the same httpd2.pem file.
1903
1904         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: Added.
1905         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: Added.
1906           - scripts to generate the JSON layout test dashboard and the
1907             flakiness dashboard
1908         * Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf: Added.
1909           - default configuration for LigHTTPd (used on Windows)
1910         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py: Added.
1911           - utility class that implements progress bars on the console to
1912             be displayed while the tests are running
1913         * Scripts/webkitpy/layout_tests/layout_package/path_utils.py: Added.
1914           - various routines for manipulating paths and URIs
1915         * Scripts/webkitpy/layout_tests/layout_package/platform_utils.py: Added.
1916         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py: Added.
1917         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py: Added.
1918         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py: Added.
1919           - platform-specific aspects of the drivers (binary names, paths,
1920             process control, etc.)
1921         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Added.
1922           - code for parsing the 'test_expectations.txt' file to determine
1923             which tests are expected to fail (and how) on which platforms
1924         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: Added.
1925           - code for handling different kinds of failures (generating output
1926             in the results, etc.)
1927         * Scripts/webkitpy/layout_tests/layout_package/test_files.py: Added.
1928           - code to gather the lists of tests
1929         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py: Added.
1930           - code to actually execute tests via TestShell and process
1931             the output
1932         * Scripts/webkitpy/layout_tests/layout_package/websocket_server.py: Added.
1933           - scripts to start and stop the pywebsocket server
1934
1935 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
1936
1937         Reviewed by Eric Seidel.
1938
1939         Check in a copy of the simplejson library; it will be used by
1940         the Chromium port of run-webkit-tests.
1941
1942         https://bugs.webkit.org/show_bug.cgi?id=31498
1943
1944         * simplejson: Added.
1945         * simplejson/LICENSE.txt: Added.
1946         * simplejson/README.txt: Added.
1947         * simplejson/__init__.py: Added.
1948         * simplejson/_speedups.c: Added.
1949         (ascii_escape_char):
1950         (ascii_escape_unicode):
1951         (ascii_escape_str):
1952         (py_encode_basestring_ascii):
1953         (init_speedups):
1954         * simplejson/decoder.py: Added.
1955         * simplejson/encoder.py: Added.
1956         * simplejson/jsonfilter.py: Added.
1957         * simplejson/scanner.py: Added.
1958
1959 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
1960
1961         No review
1962
1963         Add myself to the committers list
1964
1965         * Scripts/webkitpy/committers.py:
1966
1967 2010-01-29  Jeremy Orlow  <jorlow@chromium.org>
1968
1969         Reviewed by Dimitri Glazkov.
1970
1971         A first step towards the Indexed Database API
1972         https://bugs.webkit.org/show_bug.cgi?id=34342
1973
1974         Add indexed database API.
1975
1976         * Scripts/build-webkit:
1977
1978 2010-01-29  Andras Becsi  <abecsi@webkit.org>
1979
1980         Reviewed by Alexey Proskuryakov.
1981
1982         Correct openHTTPD() to print requests to stdout if run-webkit-httpd is used.
1983         This fixes a regression introduced in r53559.
1984
1985         https://bugs.webkit.org/show_bug.cgi?id=34336
1986
1987         * Scripts/webkitperl/httpd.pm:
1988
1989 2010-01-28  Jon Honeycutt  <jhoneycutt@apple.com>
1990
1991         MSAA: Crash when posting a notification for a detached object
1992
1993         https://bugs.webkit.org/show_bug.cgi?id=34309
1994         <rdar://problem/7409759>
1995
1996         Reviewed by Darin Adler.
1997
1998         * DumpRenderTree/AccessibilityController.h:
1999         Declare new functions. Add new members to store the event hook and the
2000         mapping of accessibility elements to their JS callbacks.
2001
2002         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2003         (AccessibilityController::notificationReceived):
2004         Stubbed.
2005         (AccessibilityController::addNotificationListener):
2006         Stubbed.
2007
2008         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2009         (AccessibilityController::notificationReceived):
2010         Stubbed.
2011         (AccessibilityController::addNotificationListener):
2012         Stubbed.
2013
2014         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2015         (AccessibilityController::AccessibilityController):
2016         Initialize the event hook.
2017         (AccessibilityController::~AccessibilityController):
2018         Remove the event hook. Unprotect all of the JS functions that are stored
2019         in the map.
2020         (logEventProc):
2021         Clean-up a variable.
2022         (stringEvent):
2023         Return a string description of the MSAA event code.
2024         (notificationListenerProc):
2025         Get the accessible object from the event, and query it for IAccessible.
2026         Call the AccessibilityController's notificationReceived().
2027         (comparableObject):
2028         Use QueryService to obtain the IAccessibleComparable for the
2029         IServiceProvider.
2030         (AccessibilityController::notificationReceived):
2031         Iterate the map of objects that have registered for notification
2032         callbacks. Query each for IServiceProvider, then use comparableObject()
2033         to get an IAccessibleComparable. If we find an object matching the
2034         notified object, call its callback, passing the event that was received.
2035         (AccessibilityController::addNotificationListener):
2036         If we have not created the event hook, create it. Protect the JS
2037         callback function object, and add the object and its callback to our
2038         map.
2039
2040         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2041         (AccessibilityUIElement::addNotificationListener):
2042         Call through to the AccessibilityController's addNotificationListener().
2043
2044         * DumpRenderTree/win/DumpRenderTreeWin.h:
2045         Add an extern declaration for the shared FrameLoadDelegate extern, so we
2046         can access it from AccessibilityController.
2047
2048         * DumpRenderTree/win/FrameLoadDelegate.h:
2049         (FrameLoadDelegate::accessibilityController):
2050         Return the AccessibilityController.
2051
2052 2010-01-29  Shinichiro Hamaji  <hamaji@chromium.org>
2053
2054         Reviewed by Darin Adler.
2055
2056         prepare-ChangeLog outputs useless messages for a nonexistent bug ID
2057         https://bugs.webkit.org/show_bug.cgi?id=34313
2058
2059         * Scripts/prepare-ChangeLog:
2060
2061 2010-01-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2062
2063         Rubberstamped by Simon Hausmann.
2064
2065         [Qt] Separate implementation from class definition.
2066
2067         * QtLauncher/main.cpp:
2068         (LauncherWindow::webView):
2069         (LauncherWindow::LauncherWindow):
2070         (LauncherWindow::~LauncherWindow):
2071         (LauncherWindow::keyPressEvent):
2072         (LauncherWindow::grabZoomKeys):
2073         (LauncherWindow::sendTouchEvent):
2074         (LauncherWindow::eventFilter):
2075         (LauncherWindow::loadStarted):
2076         (LauncherWindow::loadFinished):
2077         (LauncherWindow::showLinkHover):
2078         (LauncherWindow::zoomIn):
2079         (LauncherWindow::zoomOut):
2080         (LauncherWindow::resetZoom):
2081         (LauncherWindow::toggleZoomTextOnly):
2082         (LauncherWindow::print):
2083         (LauncherWindow::screenshot):
2084         (LauncherWindow::setEditable):
2085         (LauncherWindow::dumpHtml):
2086         (LauncherWindow::selectElements):
2087         (LauncherWindow::setTouchMocking):
2088         (LauncherWindow::newWindow):
2089         (LauncherWindow::setupUI):
2090
2091 2010-01-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2092
2093         Reviewed by Ariya Hidayat.
2094
2095         [Qt] On Maemo5, a click/touch in the location bar (when unfocused)
2096         should result in all text selected.
2097
2098         * QtLauncher/locationedit.cpp:
2099         (LocationEdit::focusInEvent):
2100         * QtLauncher/locationedit.h:
2101
2102 2010-01-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2103
2104         Reviewed by Ariya Hidayat.
2105
2106         [Qt] Show progress reaching 100% for loads.
2107
2108         * QtLauncher/locationedit.cpp:
2109         (LocationEdit::LocationEdit):
2110         (LocationEdit::setProgress):
2111         (LocationEdit::reset):
2112         (LocationEdit::paintEvent):
2113         * QtLauncher/locationedit.h:
2114
2115 2010-01-29  Andreas Kling  <andreas.kling@nokia.com>
2116
2117         Reviewed by Kenneth Rohde Christiansen.
2118
2119         [Qt] Disable the QtLauncher statusbar on Maemo
2120
2121         https://bugs.webkit.org/show_bug.cgi?id=34330
2122
2123         * QtLauncher/main.cpp:
2124         (LauncherWindow::showLinkHover):
2125         (LauncherWindow::selectElements):
2126
2127 2010-01-29  Andreas Kling  <andreas.kling@nokia.com>
2128
2129         Reviewed by Kenneth Rohde Christiansen.
2130
2131         [Qt] Display page loading progress inside the QtLauncher location bar
2132
2133         https://bugs.webkit.org/show_bug.cgi?id=34210
2134
2135         * QtLauncher/QtLauncher.pro:
2136         * QtLauncher/locationedit.cpp: Added.
2137         (LocationEdit::LocationEdit):
2138         (LocationEdit::setProgress):
2139         (LocationEdit::paintEvent):
2140         * QtLauncher/locationedit.h: Added.
2141         * QtLauncher/mainwindow.cpp:
2142         (MainWindow::buildUI):
2143         * QtLauncher/mainwindow.h:
2144
2145 2010-01-29  Andreas Kling  <andreas.kling@nokia.com>
2146
2147         Reviewed by Kenneth Rohde Christiansen.
2148
2149         [Qt] Add support for Maemo zoom keys in QtLauncher
2150
2151         https://bugs.webkit.org/show_bug.cgi?id=34160
2152
2153         * QtLauncher/main.cpp:
2154         (LauncherWindow::LauncherWindow):
2155         (LauncherWindow::~LauncherWindow):
2156         (LauncherWindow::keyPressEvent):
2157         (LauncherWindow::grabZoomKeys):
2158
2159 2010-01-29  Benjamin Poulain  <benjamin.poulain@nokia.com>
2160
2161         Reviewed by Kenneth Rohde Christiansen.
2162
2163         [Qt] Implement the display() method of the layout test controller
2164         https://bugs.webkit.org/show_bug.cgi?id=34258
2165
2166         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2167         (WebCore::DumpRenderTree::DumpRenderTree):
2168         (WebCore::DumpRenderTree::showPage):
2169         (WebCore::DumpRenderTree::hidePage):
2170         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2171         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2172         (LayoutTestController::reset):
2173         (LayoutTestController::display):
2174         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2175
2176 2010-01-28  Kevin Ollivier  <kevino@theolliviers.com>
2177
2178         [wx] Build fix for MSW, use ThreadingWin.cpp as the Windows pthreads implementation
2179         implements pthread_t in a way that makes it impossible to check its validity,
2180         which is needed by ThreadingPthreads.cpp.
2181
2182         * DumpRenderTree/wscript:
2183         * wx/build/settings.py:
2184
2185 2010-01-28  Andras Becsi  <abecsi@webkit.org>
2186
2187         Adding myself to the committer list. No review needed.
2188
2189         * Scripts/webkitpy/committers.py:
2190
2191 2010-01-28  Hayato Ito  <hayato@chromium.org>
2192
2193         Reviewed by David Levin.
2194
2195         Remove NULL char from input JS file because 'grep' fails if the file contains NULL char.
2196
2197         https://bugs.webkit.org/show_bug.cgi?id=34252
2198
2199         * Scripts/make-script-test-wrappers:
2200
2201 2010-01-28  Kevin Ollivier  <kevino@theolliviers.com>
2202
2203         [wx] Build fix after removal of the zlib image decoder.
2204
2205         * wx/build/settings.py:
2206
2207 2010-01-28  Csaba Osztrogonác  <ossy@webkit.org>
2208
2209         [Qt] Unreviewed, roll out r54000.
2210
2211         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2212         (WebCore::DumpRenderTree::DumpRenderTree):
2213         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2214         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2215         (LayoutTestController::reset):
2216         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2217         (LayoutTestController::display):
2218
2219 2010-01-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
2220
2221         Reviewed by Kenneth Rohde Christiansen.
2222
2223         [Qt] Implement the display() method of the layout test controller
2224         https://bugs.webkit.org/show_bug.cgi?id=34258
2225
2226         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2227         (WebCore::DumpRenderTree::DumpRenderTree):
2228         (WebCore::DumpRenderTree::showPage):
2229         (WebCore::DumpRenderTree::hidePage):
2230         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2231         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2232         (LayoutTestController::reset):
2233         (LayoutTestController::display):
2234         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2235
2236 2010-01-28  Chris Jerdonek  <cjerdonek@webkit.org>
2237
2238         Reviewed by Shinichiro Hamaji.
2239
2240         Eliminated the filename parameter from functions in
2241         check-webkit-style's cpp.py where it is no longer used.
2242
2243         https://bugs.webkit.org/show_bug.cgi?id=34249
2244
2245         * Scripts/webkitpy/style/processors/cpp.py:
2246           - Reduced number of occurrences of "filename" variable from
2247             approximately 200 to 120.
2248
2249         * Scripts/webkitpy/style/processors/cpp_unittest.py:
2250           - Refactored unit tests as necessary to accommodate changes to cpp.py.
2251           - Fixed bug in CppStyleTestBase.perform_include_what_you_use()
2252             where the incorrect file extension was getting passed to
2253             cpp_style.check_language().
2254
2255 2010-01-28  Chris Jerdonek  <cjerdonek@webkit.org>
2256
2257         Reviewed by Shinichiro Hamaji.
2258
2259         In check-webkit-style, eliminated the dependency of
2260         processors/cpp_unittest.py on checker.py.
2261
2262         https://bugs.webkit.org/show_bug.cgi?id=34205
2263
2264         * Scripts/webkitpy/style/checker.py:
2265           - Addressed FIXME by removing STYLE_CATEGORIES data.
2266           - Added style_categories().
2267
2268         * Scripts/webkitpy/style/checker_unittest.py:
2269           - Minor changes.
2270
2271         * Scripts/webkitpy/style/processors/cpp.py:
2272           - Added categories attribute to CppProcessor class (data
2273             was originally checker.STYLE_CATEGORIES).
2274
2275         * Scripts/webkitpy/style/processors/cpp_unittest.py:
2276           - Addressed FIXME by eliminating "import" from checker.py.
2277
2278 2010-01-28  Anton Muhin  <antonm@chromium.org>
2279
2280         Reviewed by Shinichiro Hamaji.
2281
2282         Improve treatment of conditions and rest of the line for if, else, switch and alikes
2283         https://bugs.webkit.org/show_bug.cgi?id=34173
2284
2285         * Scripts/webkitpy/style/cpp_style.py:
2286         * Scripts/webkitpy/style/cpp_style_unittest.py:
2287
2288 2010-01-28  Joe Mason  <jmason@rim.com>
2289
2290         Reviewed by Adam Barth.
2291
2292         Limit login retries to 5
2293         https://bugs.webkit.org/show_bug.cgi?id=34193
2294
2295         * Scripts/webkitpy/bugzilla.py:
2296
2297 2010-01-27  Martin Robinson  <mrobinson@webkit.org>
2298
2299         Adding myself to the committer list. No review necessary.
2300
2301         * Scripts/webkitpy/committers.py:
2302
2303 2010-01-27  George Wright  <gwright@rim.com>
2304
2305         Reviewed by Adam Treat.
2306
2307         https://bugs.webkit.org/show_bug.cgi?id=34216
2308
2309         Add missing include for wtf/Platform.h
2310
2311         * DumpRenderTree/AccessibilityController.h:
2312
2313 2010-01-27  Diego Gonzalez  <diego.gonzalez@openbossa.org>
2314
2315         Reviewed by Kenneth Rohde Christiansen.
2316
2317         [Qt] DRT Provide worker thread ability to track counters
2318         https://bugs.webkit.org/show_bug.cgi?id=34221
2319
2320         Implement workerThreadCount() in LayoutTestController of Qt DRT
2321
2322         Tests:
2323         fast/workers/dedicated-worker-lifecycle.html
2324         fast/workers/shared-worker-frame-lifecycle.html
2325         fast/workers/shared-worker-lifecycle.html
2326         fast/workers/worker-lifecycle.html
2327
2328         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2329         (LayoutTestController::workerThreadCount):
2330         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2331
2332 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2333
2334         Rubberstamped by Simon Hausmann.
2335
2336         [Qt] QtLauncher refactoring:
2337
2338         Make the LauncherWindow depend less on the view, so that more
2339         code can be shared in near future.
2340
2341         * QtLauncher/main.cpp:
2342         (LauncherWindow::sendTouchEvent):
2343         (LauncherWindow::loadFinished):
2344         (LauncherWindow::zoomIn):
2345         (LauncherWindow::zoomOut):
2346         (LauncherWindow::resetZoom):
2347         (LauncherWindow::toggleZoomTextOnly):
2348         (LauncherWindow::dumpHtml):
2349         (LauncherWindow::selectElements):
2350         (LauncherWindow::setupUI):
2351
2352 2010-01-27  Kinuko Yasuda  <kinuko@chromium.org>
2353
2354         Reviewed by Eric Seidel.
2355
2356         Correctly handle the KeyLocation argument that has been introduced
2357         recently to test location-dependent key events in EventSender.keyDown.
2358         http://bugs.webkit.org/show_bug.cgi?id=28247
2359
2360         Test: fast/events/keydown-numpad-keys.html
2361
2362         * DumpRenderTree/gtk/EventSender.cpp:
2363         (keyDownCallback):
2364
2365 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2366
2367         Rubberstamped by Simon Hausmann.
2368
2369         [Qt] QtLauncher refactoring:
2370
2371         Move out code from the MainWindow (renamed to LauncherWindow)
2372         that is not depending on the view, and add it to a new class
2373         called MainWindow.
2374
2375         * QtLauncher/QtLauncher.pro:
2376         * QtLauncher/main.cpp:
2377         (LauncherWindow::LauncherWindow):
2378         (LauncherWindow::eventFilter):
2379         (LauncherWindow::loadStarted):
2380         (LauncherWindow::loadFinished):
2381         (LauncherWindow::newWindow):
2382         (LauncherWindow::setupUI):
2383         (WebPage::createWindow):
2384         (main):
2385         * QtLauncher/mainwindow.cpp: Added.
2386         (MainWindow::MainWindow):
2387         (MainWindow::buildUI):
2388         (MainWindow::page):
2389         (MainWindow::setAddressUrl):
2390         (MainWindow::addCompleterEntry):
2391         (MainWindow::load):
2392         (MainWindow::changeLocation):
2393         (MainWindow::openFile):
2394         * QtLauncher/mainwindow.h: Added.
2395
2396 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2397
2398         Rubberstamped by Simon Hausmann.
2399
2400         [Qt] QtLauncher, coding style fixes.
2401
2402         * QtLauncher/main.cpp:
2403         (MainWindow::MainWindow):
2404         (MainWindow::sendTouchEvent):
2405         (MainWindow::eventFilter):
2406         (MainWindow::loadURL):
2407         (MainWindow::setupUI):
2408         (WebPage::createPlugin):
2409
2410 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2411
2412         Rubberstamped by Simon Hausmann.
2413
2414         [Qt] QtLauncher refactoring, separating the webview and
2415         adding a QGraphicsWebView based version.
2416
2417         * QtLauncher/QtLauncher.pro:
2418         * QtLauncher/main.cpp:
2419         (MainWindow::MainWindow):
2420         * QtLauncher/webpage.h:
2421         * QtLauncher/webview.cpp: Added.
2422         (createContextMenu):
2423         (WebViewGraphicsBased::mousePressEvent):
2424         (WebViewTraditional::mousePressEvent):
2425         (WebViewGraphicsBased::contextMenuEvent):
2426         (WebViewTraditional::contextMenuEvent):
2427         * QtLauncher/webview.h: Added.
2428         (WebViewGraphicsBased::WebViewGraphicsBased):
2429         (WebViewTraditional::WebViewTraditional):
2430
2431 2010-01-27  Alexander Pavlov  <apavlov@chromium.org>
2432
2433         Adding myself as committer. No review necessary.
2434
2435         * Scripts/webkitpy/committers.py:
2436
2437 2010-01-27  Eric Seidel  <eric@webkit.org>
2438
2439         Reviewed by Darin Adler.
2440
2441         webkit-patch needs an open-bugs command
2442         https://bugs.webkit.org/show_bug.cgi?id=30793
2443
2444         * Scripts/test-webkitpy: import OpenBugsTest
2445         * Scripts/webkit-patch: import OpenBugs
2446         * Scripts/webkitpy/commands/download_unittest.py: don't import unittest
2447         * Scripts/webkitpy/commands/early_warning_system_unittest.py: ditto
2448         * Scripts/webkitpy/commands/queries_unittest.py: ditto
2449         * Scripts/webkitpy/commands/queues_unittest.py: ditto
2450         * Scripts/webkitpy/commands/upload_unittest.py: ditto
2451         * Scripts/webkitpy/mock_bugzillatool.py: log when user.open_url is called.
2452
2453 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2454
2455         Rubberstamped by Simon Hausmann
2456
2457         [Qt] QtLauncher refactoring, separating utility methods.
2458
2459         * QtLauncher/QtLauncher.pro:
2460         * QtLauncher/main.cpp:
2461         * QtLauncher/utils.cpp: Added.
2462         (urlFromUserInput):
2463         * QtLauncher/utils.h: Added.
2464
2465 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2466
2467         Rubberstamped by Simon Hausmann
2468
2469         [Qt] Refactor the code in the QtLauncher dealing with HTTP proxy.
2470
2471         * QtLauncher/main.cpp:
2472         (MainWindow::MainWindow):
2473         * QtLauncher/webpage.cpp:
2474         (WebPage::WebPage):
2475         (WebPage::applyProxy):
2476         * QtLauncher/webpage.h:
2477
2478 2010-01-26  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2479
2480         Reviewed by Tor Arne Vestbø.
2481
2482         [Qt] Corrects debug build of DumpRenderTree on Windows.
2483
2484         * DumpRenderTree/qt/DumpRenderTree.pro:
2485
2486 2010-01-26  Daniel Bates  <dbates@webkit.org>
2487
2488         Reviewed by Adam Barth.
2489
2490         https://bugs.webkit.org/show_bug.cgi?id=34070
2491
2492         Moves the try/catch for OSError exceptions in Executive.run_command
2493         to Credentials.read_credentials() so that the unit test
2494         webkitpy.scm_unittest.SCMClassTests.test_error_handlers can
2495         assert that Executive.run_command throws an OSError exception.
2496
2497         * Scripts/webkitpy/credentials.py:
2498         * Scripts/webkitpy/executive.py: Moved try/catch for OSError to
2499         method Credentials.read_credentials().
2500         * Scripts/webkitpy/executive_unittest.py: Removed tests that no longer
2501         apply: test_run_command_with_bad_command_check_return_code and
2502         test_run_command_with_bad_command_check_calls_error_handler. Added new
2503         test to assert that run_command throws OSError exceptions.
2504
2505 2010-01-26  Diego Gonzalez  <diego.gonzalez@openbossa.org>
2506
2507         Reviewed by Kenneth Rohde Christiansen.
2508
2509         [Qt] DRT WebHistory support
2510         https://bugs.webkit.org/show_bug.cgi?id=34167
2511
2512         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2513         (LayoutTestController::reset):
2514         (LayoutTestController::webHistoryItemCount):
2515         (LayoutTestController::keepWebHistory):
2516         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2517
2518 2010-01-26  Kent Tamura  <tkent@chromium.org>
2519
2520         Reviewed by Eric Seidel.
2521
2522         [Win] Add modifiers parameter support to Windows DumpRenderTree
2523         https://bugs.webkit.org/show_bug.cgi?id=34068
2524
2525         Add support for functional name modifiers; "addSelectionKey" and
2526         "rangeSelectionKey", and modifiers parameter to eventSender.mouseDown()
2527         and eventSender.mouseUp().
2528         This change is similar to r53498 for Mac.
2529
2530         * DumpRenderTree/win/EventSender.cpp:
2531         (buildModifierFlags): New function to set MK_CONTROL or MK_SHIFT to WPARAM.
2532         (mouseDownCallback): Call buidlModifiersFlags().
2533         (mouseUpCallback): ditto.
2534         (keyDownCallback): Add support for "addSelectionkey" and "rangeSelectionKey".
2535
2536 2010-01-26  Chris Jerdonek  <cjerdonek@webkit.org>
2537
2538         Reviewed by Eric Seidel.
2539
2540         The Python autoinstall cache directory now only gets created
2541         in the directory containing autoinstall.py.
2542
2543         https://bugs.webkit.org/show_bug.cgi?id=33365
2544
2545         * Scripts/webkitpy/autoinstall.py:
2546           - Also added a README file to the cache directory saying
2547             where it came from.
2548
2549 2010-01-26  Chris Jerdonek  <cjerdonek@webkit.org>
2550
2551         Reviewed by Eric Seidel.
2552
2553         Moved the check-webkit-style processors into a new
2554         webkitpy/style/processors directory.
2555
2556         https://bugs.webkit.org/show_bug.cgi?id=34060
2557
2558         * Scripts/webkitpy/style/checker.py:
2559         * Scripts/webkitpy/style/checker_unittest.py:
2560         * Scripts/webkitpy/style/cpp_style.py: Removed.
2561         * Scripts/webkitpy/style/cpp_style_unittest.py: Removed.
2562         * Scripts/webkitpy/style/processors: Added.
2563         * Scripts/webkitpy/style/processors/__init__.py: Added.
2564         * Scripts/webkitpy/style/processors/cpp.py: Copied from WebKitTools/Scripts/webkitpy/style/cpp_style.py.
2565         * Scripts/webkitpy/style/processors/cpp_unittest.py: Copied from WebKitTools/Scripts/webkitpy/style/cpp_style_unittest.py.
2566         * Scripts/webkitpy/style/processors/text.py: Copied from WebKitTools/Scripts/webkitpy/style/text_style.py.
2567         * Scripts/webkitpy/style/processors/text_unittest.py: Copied from WebKitTools/Scripts/webkitpy/style/text_style_unittest.py.
2568         * Scripts/webkitpy/style/text_style.py: Removed.
2569         * Scripts/webkitpy/style/text_style_unittest.py: Removed.
2570         * Scripts/webkitpy/style/unittests.py:
2571
2572 2010-01-26  Kevin Ollivier  <kevino@theolliviers.com>
2573
2574         [wx] Build fix, make sure stub function returns a value.
2575
2576         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2577         (LayoutTestController::counterValueForElementById):
2578
2579 2010-01-26  Steve Falkenburg  <sfalken@apple.com>
2580
2581         Reviewed by Oliver Hunt.
2582
2583         Windows build references non-existent include paths
2584         https://bugs.webkit.org/show_bug.cgi?id=34175
2585
2586         * DumpRenderTree/win/DumpRenderTree.vcproj:
2587         * DumpRenderTree/win/ImageDiff.vcproj:
2588         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2589
2590 2010-01-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2591
2592         Reviewed by Ariya Hidayat.
2593
2594         [Qt] Separating out the UrlLoader from the QtLauncher in it's
2595         own implementation and header file.
2596
2597         * QtLauncher/main.cpp:
2598         (main):
2599         * QtLauncher/urlloader.cpp: Added.
2600         (UrlLoader::UrlLoader):
2601         (UrlLoader::loadNext):
2602         (UrlLoader::init):
2603         (UrlLoader::getUrl):
2604         * QtLauncher/urlloader.h: Added.
2605
2606 2010-01-25  Chris Jerdonek  <cjerdonek@webkit.org>
2607
2608         Reviewed by Shinichiro Hamaji.
2609
2610         Refactored check-webkit-style by removing the file path
2611         parameter from the style error handler functions.
2612
2613         https://bugs.webkit.org/show_bug.cgi?id=34031
2614
2615         * Scripts/webkitpy/style/checker.py:
2616           - Added _default_style_error_handler() to StyleChecker class.
2617           - Moved handle_style_error() to inside _default_style_error_handler().
2618
2619         * Scripts/webkitpy/style/checker_unittest.py:
2620           - Removed file path from calls to error handler.
2621
2622         * Scripts/webkitpy/style/cpp_style.py:
2623           - Removed file path from calls to error handler.
2624
2625         * Scripts/webkitpy/style/cpp_style_unittest.py:
2626           - Removed file path from calls to error handler.
2627
2628         * Scripts/webkitpy/style/text_style.py:
2629           - Removed file path from calls to error handler.
2630
2631         * Scripts/webkitpy/style/text_style_unittest.py:
2632           - Removed file path from calls to error handler.
2633
2634 2010-01-25  Jeremy Orlow  <jorlow@chromium.org>
2635
2636         Adding myself as reviewer.  No review necessary.
2637
2638         * Scripts/webkitpy/committers.py:
2639
2640 2010-01-25  Chris Jerdonek  <cjerdonek@webkit.org>
2641
2642         Reviewed by Adam Barth.
2643
2644         Improved prepare-ChangeLog so that it preserves the relative
2645         indentation of a git commit message.
2646
2647         https://bugs.webkit.org/show_bug.cgi?id=34058
2648
2649         * Scripts/prepare-ChangeLog:
2650           - Also adjusted the script so that it does not add white
2651             space characters to empty lines.
2652
2653 2010-01-24  Eric Seidel  <eric@webkit.org>
2654
2655         No review, rolling out r53763.
2656         http://trac.webkit.org/changeset/53763
2657         https://bugs.webkit.org/show_bug.cgi?id=33895
2658
2659         Broke 20+ tests on Windows.
2660
2661         * Scripts/run-webkit-tests:
2662         * Scripts/webkitdirs.pm:
2663
2664 2010-01-24  Adam Barth  <abarth@webkit.org>
2665
2666         Rubber stamped by Eric Seidel.
2667
2668         More pep8 compliance.
2669
2670         * Scripts/webkitpy/mock_bugzillatool.py:
2671
2672 2010-01-24  Adam Barth  <abarth@webkit.org>
2673
2674         Rubber stamped by Eric Seidel.
2675
2676         More pep8 compliance.
2677
2678         * Scripts/webkitpy/executive.py:
2679         * Scripts/webkitpy/grammar.py:
2680
2681 2010-01-24  Adam Barth  <abarth@webkit.org>
2682
2683         Rubber stamped by Eric Seidel.
2684
2685         More pep8 compliance.
2686
2687         * Scripts/webkitpy/comments.py:
2688         * Scripts/webkitpy/committers.py:
2689         * Scripts/webkitpy/credentials.py:
2690
2691 2010-01-24  Adam Barth  <abarth@webkit.org>
2692
2693         Rubber stamped by Eric Seidel.
2694
2695         Make changelogs.py pass pep8.
2696
2697         * Scripts/webkitpy/changelogs.py:
2698
2699 2010-01-23  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2700
2701         [Qt] Unreviewed build fix
2702
2703         * QtLauncher/QtLauncher.pro:
2704         * QtLauncher/webinspector.h:
2705
2706 2010-01-23  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2707
2708         Rubberstamped by Simon Hausmann.
2709
2710         [Qt] Move the WebInspector class to it's own header file.
2711
2712         * QtLauncher/main.cpp:
2713         * QtLauncher/webinspector.h: Added.
2714         (WebInspector::WebInspector):
2715         (WebInspector::showEvent):
2716         (WebInspector::hideEvent):
2717
2718 2010-01-23  Robert Hogan  <robert@roberthogan.net>
2719
2720         Reviewed by Kenneth Rohde Christiansen.
2721
2722         Qt DRT: respect window.close() and window.closed()
2723
2724         Qt DRT needs to maintain a correct count of open windows
2725         for windowCount(). It also needs to delete windows that
2726         have been closed by window.close().
2727
2728         This fixes the following tests:
2729
2730         plugins/destroy-during-npp-new.html
2731         fast/dom/Document/early-document-access.html
2732         fast/dom/Window/window-early-properties.html
2733         fast/events/open-window-from-another-frame.html
2734         fast/events/popup-blocking-click-in-iframe.html
2735
2736         https://bugs.webkit.org/show_bug.cgi?id=32953
2737
2738         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2739         (WebCore::DumpRenderTree::DumpRenderTree):
2740         (WebCore::DumpRenderTree::createWindow):
2741         (WebCore::DumpRenderTree::windowCloseRequested):
2742         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2743         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2744         (LayoutTestController::maybeDump):
2745
2746 2010-01-23  Dan Bernstein  <mitz@apple.com>
2747
2748         Reviewed by Mark Rowe.
2749
2750         Added a user default for specifying a fallback frameworks path in case
2751         the bundle does not contain frameworks for the current Mac OS X version.
2752
2753         * WebKitLauncher/main.m:
2754         (fallbackMacOSXVersion): Added. Looks up the fallback version in a dictionary
2755         keyed by the FallbackSystemVersions user default and returns it.
2756         (main): If a frameworks directory for the current system version is not found,
2757         try the fallback.
2758
2759 2010-01-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2760
2761         Reviewed by Simon Hausmann.
2762
2763         Make run-webkit-tests work under Cygwin for the Qt port
2764
2765         setPathForRunningWebKitApp() is implemented for the Qt port
2766         by using qmake to query for the location of the Qt libraries.
2767
2768         This requires the original environment (%ENV) to be untouched,
2769         so launchWithCurrentEnv() was refactored to launchWithEnv(),
2770         and the code in openDumpTool() to not use %ENV but a %CLEAN_ENV
2771         instead. This has the added benefit of getting rid of the temp
2772         variables used for storing the current env.
2773
2774         openDumpTool() is also refactored a bit into platform-spesific,
2775         port-spesific, and generic environment variables.
2776
2777         Checks for undef was added a few places to fix Perl concat
2778         warnings when run-webkit-tests is aborted.
2779
2780         https://bugs.webkit.org/show_bug.cgi?id=33895
2781
2782         * Scripts/run-webkit-tests:
2783         * Scripts/webkitdirs.pm:
2784
2785 2010-01-22  Kevin Watters  <kevinwatters@gmail.com>
2786
2787         Reviewed by Kevin Ollivier.
2788
2789         [wx] Remove the Bakefile build system, which is no longer being used.
2790
2791         https://bugs.webkit.org/show_bug.cgi?id=34022
2792
2793         * DumpRenderTree/wx/DumpRenderTree.bkl: Removed.
2794         * wx/browser/browser.bkl: Removed.
2795         * wx/build-wxwebkit: Removed.
2796
2797 2010-01-22  Gustavo Noronha Silva  <gns@gnome.org>
2798
2799         Reviewed by Simon Fraser.
2800
2801         Reset zoom level to 1.0 when resetting view state. This is causing
2802         many tests to fail after svg/custom/text-zoom.xhtml changes the
2803         zoom level.
2804
2805         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2806         (resetDefaultsToConsistentValues):
2807
2808 2010-01-22  Steve Falkenburg  <sfalken@apple.com>
2809
2810         Reviewed by Darin Adler.
2811
2812         https://bugs.webkit.org/show_bug.cgi?id=34025
2813         Enable client-based Geolocation abstraction for Mac, Windows AppleWebKit targets.
2814
2815         * Scripts/build-webkit:
2816
2817 2010-01-22  Adam Barth  <abarth@webkit.org>
2818
2819         Unreviewed.  Arg.  Someone renamed limit to output_limit on me.
2820
2821         * Scripts/webkitpy/commands/queues.py:
2822
2823 2010-01-22  Adam Barth  <abarth@webkit.org>
2824
2825         Rubber stamped by Eric Seidel.
2826
2827         Make __init__.py and buildbot.py pass pep8 style checker.
2828
2829         * Scripts/webkitpy/__init__.py:
2830         * Scripts/webkitpy/buildbot.py:
2831
2832 2010-01-21  Joe Mason  <jmason@rim.com>
2833
2834         Reviewed by Adam Barth.
2835
2836         webkit-patch should retry on invalid password
2837         https://bugs.webkit.org/show_bug.cgi?id=33955
2838
2839         Ask for bugs.webkit.org authentication in a loop.
2840
2841         * Scripts/webkitpy/bugzilla.py:
2842
2843 2010-01-22  Adam Barth  <abarth@webkit.org>
2844
2845         Unreviewed.  Don't call seek on a NoneType.
2846
2847         * Scripts/webkitpy/statusserver.py:
2848
2849 2010-01-22  Petri Latvala  <petri.latvala@nomovok.com>
2850
2851         Reviewed by David Levin.
2852
2853         check-webkit-style breaks on files with unknown types
2854         https://bugs.webkit.org/show_bug.cgi?id=34001
2855
2856         For files with type FileType.NONE, dispatch_processor returns None.
2857
2858         * Scripts/webkitpy/style/checker.py: Don't call process_file with a processor of value None.
2859
2860 2010-01-22  Adam Barth  <abarth@webkit.org>
2861
2862         Reviewed by Eric Seidel.
2863
2864         Make bugzilla.py and webkitport.py conform to pep8
2865         https://bugs.webkit.org/show_bug.cgi?id=34015
2866
2867         This patch makes webkitport.py and bugzilla.py mostly conform to PEP8
2868         style as enforced by pep8.py.  I wasn't able to get rid of all the
2869         errors because I'm not sure how to wrap some lines properly.  Also,
2870         there are a few deprication errors that I couldn't resolve easily.
2871         However, this is a massive improvement in compliance.
2872
2873         * Scripts/webkitpy/bugzilla.py:
2874         * Scripts/webkitpy/webkitport.py:
2875
2876 2010-01-22  Adam Barth  <abarth@webkit.org>
2877
2878         Reviewed by Darin Adler.
2879
2880         Limit length of EWS results to 5MB
2881         https://bugs.webkit.org/show_bug.cgi?id=34016
2882
2883         Hopefully this will fix the bug where the results link doesn't appear.
2884         Our current theory is that the results blob is too big and the server
2885         is rejecting the request with a 500 error.  That causes us to re-try
2886         the post, but when we re-try the StringIO buffer has its seek pointer
2887         at the end.
2888
2889         * Scripts/webkitpy/commands/queues.py:
2890         * Scripts/webkitpy/statusserver.py:
2891
2892 2010-01-22  Chris Jerdonek  <cjerdonek@webkit.org>
2893
2894         Reviewed by Adam Barth.
2895
2896         Made check-webkit-style able to check patches when script not
2897         run from source root. Also consolidated external references
2898         to a single file.
2899
2900         https://bugs.webkit.org/show_bug.cgi?id=33791
2901
2902         * Scripts/check-webkit-style:
2903           - Changed to import style_references.py.
2904
2905         * Scripts/webkitpy/style/__init__.py:
2906           - Removed __path__ hack that allowed searching Scripts/ directory.
2907
2908         * Scripts/webkitpy/style/checker.py:
2909           - Changed to import style_references.py.
2910
2911         * Scripts/webkitpy/style_references.py: Added.
2912
2913 2010-01-22  Dmitry Titov  <dimich@chromium.org>
2914
2915         Reviewed by Maciej Stachowiak.
2916
2917         Fix the leak of ThreadIdentifiers in threadMap across threads.
2918         https://bugs.webkit.org/show_bug.cgi?id=32689
2919
2920         Add a new test to verify the ThreadIdentifiers are not reused across threads.
2921         The test runs in the beginning of DumpRenderTree and spawns 2 non-WTF treads sequentially,
2922         waiting for the previous thread to terminate before starting the next.
2923         The treads use WTF::currentThread() in their thread function. Without a fix, this
2924         causes both threads to have the same ThreadIdentifier which triggers ASSERT in thread function.
2925         It also starts another thread using WTF. Without the fix, this finds pthread handle from previous
2926         threads in the WTF threadMap and asserts in WTF::establishIdentifierForPthreadHandle().
2927         The test practically does not affect the DRT run time because the threads end immediately.
2928
2929         * DumpRenderTree/mac/DumpRenderTree.mm:
2930         (runThread): Test thread function.
2931         (testThreadIdentifierMap):
2932         (dumpRenderTree):
2933
2934 2010-01-22  Kent Tamura  <tkent@chromium.org>
2935
2936         Reviewed by Maciej Stachowiak.
2937
2938         Fix a bug that mouseDown:withModifiers: is never called.
2939         https://bugs.webkit.org/show_bug.cgi?id=33989
2940
2941         * DumpRenderTree/mac/EventSendingController.mm:
2942         (+[EventSendingController isSelectorExcludedFromWebScript:]):
2943         (+[EventSendingController webScriptNameForSelector:]):
2944
2945 2010-01-22  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2946
2947         Rubberstamped by Antti Koivisto.
2948
2949         [Qt] Separate out the WebPage class into it's own
2950         cpp/header files. Also, removed the assumption that
2951         the view is a QWebView, in preparation of a merger
2952         of the two Qt WebKit launchers.
2953
2954         * QtLauncher/QtLauncher.pro:
2955         * QtLauncher/main.cpp:
2956         (WebView::mousePressEvent):
2957         * QtLauncher/webpage.cpp: Added.
2958         (WebPage::supportsExtension):
2959         (WebPage::extension):
2960         (WebPage::acceptNavigationRequest):
2961         (WebPage::openUrlInDefaultBrowser):
2962         * QtLauncher/webpage.h: Added.
2963         (WebPage::WebPage):
2964
2965 2010-01-21  Chris Jerdonek  <cjerdonek@webkit.org>
2966
2967         Reviewed by Shinichiro Hamaji.
2968
2969         Refactored to move file name and file-reading related code
2970         from cpp_style.py and text_style.py to checker.py.
2971
2972         https://bugs.webkit.org/show_bug.cgi?id=33775
2973
2974         * Scripts/check-webkit-style:
2975           - Updates caused by changes to checker.py.
2976
2977         * Scripts/webkitpy/style/checker.py:
2978           - Added SKIPPED_FILES_WITH_WARNING list.
2979           - Added SKIPPED_FILES_WITHOUT_WARNING list.
2980           - Added FileType class.
2981           - Added ProcessorDispatcher class.
2982           - In StyleChecker class:
2983             - Renamed process_patch() to check_patch().
2984             - Renamed process_file() to check_file().
2985             - Added _process_file().
2986             - Related refactoring.
2987             - Addressed check_patch() FIXME to share code with process_file().
2988
2989         * Scripts/webkitpy/style/checker_unittest.py:
2990           - Added ProcessorDispatcherSkipTest class.
2991           - Added ProcessorDispatcherDispatchTest class.
2992           - Added StyleCheckerCheckFileTest class.
2993
2994         * Scripts/webkitpy/style/cpp_style.py:
2995           - Renamed process_file_data() to _process_lines.
2996           - Removed process_file() (moved logic to checker.py).
2997           - Removed can_handle() (moved logic to checker.py).
2998           - Added CppProcessor class.
2999           - Removed is_exempt() (moved logic to checker.py).
3000           - Added process_file_data() back as a wrapper function.
3001
3002         * Scripts/webkitpy/style/cpp_style_unittest.py:
3003           - Removed test_can_handle().
3004           - Removed test_is_exempt().
3005           - Added CppProcessorTest class.
3006
3007         * Scripts/webkitpy/style/text_style.py:
3008           - Added TextProcessor class.
3009           - Removed process_file().
3010           - Removed can_handle().
3011
3012         * Scripts/webkitpy/style/text_style_unittest.py:
3013           - Removed test_can_handle().
3014           - Added TextProcessorTest class.
3015
3016 2010-01-21  Chris Jerdonek  <cjerdonek@webkit.org>
3017
3018         Reviewed by David Kilzer.
3019
3020         Create a unit-tested subroutine to parse patch files created
3021         by svn-create-patch.
3022
3023         https://bugs.webkit.org/show_bug.cgi?id=33475
3024
3025         * Scripts/VCSUtils.pm:
3026           - Added parseDiff().
3027           - Added parsePatch().
3028
3029         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Added.
3030           - Added unit tests for parseDiff().
3031
3032         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
3033           - Total number of tests now computed dynamically.
3034
3035         * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl: Added.
3036           - Added unit tests for parsePatch().
3037
3038 2010-01-21  Kevin Ollivier  <kevino@theolliviers.com>
3039
3040         [wx] Build fix, add new directory to dir list.
3041
3042         * wx/build/settings.py:
3043
3044 2010-01-21  Adam Barth  <abarth@webkit.org>
3045
3046         Reviewed by Eric Seidel.
3047
3048         Make the EWS transactional
3049         https://bugs.webkit.org/show_bug.cgi?id=33978
3050
3051         Now if the EWS gets interrupted in the middle of processing a patch,
3052         the bots will re-process the patch.
3053
3054         * Scripts/test-webkitpy:
3055         * Scripts/webkitpy/commands/queues.py:
3056         * Scripts/webkitpy/commands/queues_unittest.py:
3057         * Scripts/webkitpy/patchcollection.py:
3058         * Scripts/webkitpy/patchcollection_unittest.py: Added.
3059
3060 2010-01-21  Adam Barth  <abarth@webkit.org>
3061
3062         Unreviewed.  Add missing "ago" for style in the status bubble.
3063
3064         * QueueStatusServer/templates/statusbubble.html:
3065
3066 2010-01-21  Adam Barth  <abarth@webkit.org>
3067
3068         Reviewed by David Levin.
3069
3070         [style-queue] should not complain about identifier names with underscores under WebKit/gtk/webkit/
3071         https://bugs.webkit.org/show_bug.cgi?id=33356
3072
3073         White list unix_hacker_style names in WebKit/gtk/webkit because these
3074         are used in the GTK+ API.
3075
3076         * Scripts/webkitpy/style/cpp_style.py:
3077         * Scripts/webkitpy/style/cpp_style_unittest.py:
3078
3079 2010-01-21  Diego Gonzalez  <diego.gonzalez@openbossa.org>
3080
3081         Reviewed by Kenneth Rohde Christiansen.
3082
3083         [Qt] add setDomainRelaxationForbiddenForURLScheme in Qt DRT
3084         https://bugs.webkit.org/show_bug.cgi?id=33945
3085
3086         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3087         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
3088         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3089
3090 2010-01-21  Simon Hausmann  <simon.hausmann@nokia.com>
3091
3092         No review, rolling out 53615 as it causes two
3093         crashes on the bot.
3094
3095         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3096         (WebCore::DumpRenderTree::DumpRenderTree):
3097         (WebCore::DumpRenderTree::createWindow):
3098         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3099         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3100         (LayoutTestController::maybeDump):
3101
3102 2010-01-21  Robert Hogan  <robert@roberthogan.net>
3103
3104         Reviewed by Simon Hausmann.
3105
3106         Qt DRT: respect window.close() and window.closed()
3107
3108         Qt DRT needs to maintain a correct count of open windows
3109         for windowCount(). It also needs to delete windows that
3110         have been closed by window.close().
3111
3112         This fixes the following tests:
3113
3114         plugins/destroy-during-npp-new.html
3115         fast/dom/Document/early-document-access.html
3116         fast/dom/Window/window-early-properties.html
3117         fast/events/open-window-from-another-frame.html
3118         fast/events/popup-blocking-click-in-iframe.html
3119
3120         https://bugs.webkit.org/show_bug.cgi?id=32953
3121
3122         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3123         (WebCore::DumpRenderTree::DumpRenderTree):
3124         (WebCore::DumpRenderTree::createWindow):
3125         (WebCore::DumpRenderTree::windowCloseRequested):
3126         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3127         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3128         (LayoutTestController::maybeDump):
3129
3130 2010-01-20  Eric Seidel  <eric@webkit.org>
3131
3132         No review, rolling out r53593.
3133         http://trac.webkit.org/changeset/53593
3134         https://bugs.webkit.org/show_bug.cgi?id=33496
3135
3136         Re-rollout this patch, the commit-queue should not have landed
3137         it again, but it did due to land-diff and rollout both not
3138         clearing flags.
3139
3140         * Scripts/webkitpy/commands/early_warning_system.py:
3141         * Scripts/webkitpy/commands/queues.py:
3142         * Scripts/webkitpy/queueengine.py:
3143         * Scripts/webkitpy/scm.py:
3144         * Scripts/webkitpy/scm_unittest.py:
3145
3146 2010-01-20  Eric Seidel  <eric@webkit.org>
3147
3148         Reviewed by Adam Barth.
3149
3150         webkit-commit-queue status page is confusing
3151         https://bugs.webkit.org/show_bug.cgi?id=33496
3152
3153         This should improve the status page by removing more Fail messages.
3154         To do this, I re-factored the CommitQueue and the AbstractReviewQueues
3155         to behave more like one another.  This meant moving where the failure reporting was done.
3156         Previously the AbstractReviewQueue always used the parent process to report the error,
3157         while CommitQueue used the subprocess when possible, and the parent only reported errors
3158         that we didn't know how to handle (bugs in the commit-queue itself).
3159         Now the AbstractReviewQueue follow's the commit-queue's model.  This got rid of a try-block
3160         in both implementations and required teaching handle_script_error in each to post Fail messages
3161         to the status server instead of calling exit(1).
3162
3163         This will also make the style-queue share more bug posting logic with other queues:
3164         https://bugs.webkit.org/show_bug.cgi?id=33871
3165
3166         * Scripts/webkitpy/commands/early_warning_system.py:
3167          - Don't exit(1) as that will cause the calling queue to also report Fail to the status server.
3168            Implementors of handle_script_error are expected to update the status server if needed, but only exit if the error could not be handled.
3169            So we instead pass patch_has_failed_this_queue=True to _update_status_for_script_error in the case that this was a real failure.
3170            _update_status_for_script_error knows how to post the Fail message to the status server.
3171          - Teach _update_status_for_script_error how to post Fail messages to the status server.
3172         * Scripts/webkitpy/commands/queues.py:
3173          - Remove the try block from process_work_item since the caller already has one.
3174          - Only CC watchers on failure to cut down on commit-queue generated mail.
3175          - handle_unexpected_error needs to mark _did_fail now that the try block is gone from process_work_item.
3176          - Abstract _format_script_error_output_for_bug to share code between all queues.
3177          - The new _format_script_error_output_for_bug allows the style-queue to share the posting limit with other queues, as well as support linking to the full output.
3178          - Rename _can_build_and_test to _current_checkout_builds_and_passes_tests to better explain what revision it's testing.
3179          - Move logging out of _can_build_and_test and make the logs explain what revision we're testing.
3180          - handle_script_error now posts Fail instead of the try block in process_work_item handling it.
3181         * Scripts/webkitpy/queueengine.py:
3182          - QueueEngine is no longer used just by the commit-queue, update the logging to say "processing" instead of landing.
3183         * Scripts/webkitpy/scm.py:
3184          - Add new checkout_revision function.
3185         * Scripts/webkitpy/scm_unittest.py:
3186          - Test our new checkout_revision function.
3187
3188 2010-01-20  Fumitoshi Ukai  <ukai@chromium.org>
3189
3190         Reviewed by Alexey Proskuryakov.
3191
3192         WebSocket: Missing Request-URI, when no tralling slash in host
3193         https://bugs.webkit.org/show_bug.cgi?id=33689
3194
3195         Update pywebsocket to 0.4.7.1, which supports alias for resource
3196         name, so that we could test for ws://127.0.0.1:8880
3197
3198         * Scripts/run-webkit-tests:
3199         * Scripts/run-webkit-websocketserver:
3200         * pywebsocket/mod_pywebsocket/dispatch.py:
3201         * pywebsocket/mod_pywebsocket/handshake.py:
3202         * pywebsocket/mod_pywebsocket/standalone.py:
3203         * pywebsocket/setup.py:
3204         * pywebsocket/test/test_dispatch.py:
3205         * pywebsocket/test/test_handshake.py:
3206
3207 2010-01-20  Eric Seidel  <eric@webkit.org>
3208
3209         No review, rolling out r53537.
3210         http://trac.webkit.org/changeset/53537
3211         https://bugs.webkit.org/show_bug.cgi?id=33496
3212
3213         Added a failure condition to the commit-queue and looks to
3214         have broken the EWS bots
3215
3216         * Scripts/webkitpy/commands/early_warning_system.py:
3217         * Scripts/webkitpy/commands/queues.py:
3218         * Scripts/webkitpy/queueengine.py:
3219         * Scripts/webkitpy/scm.py:
3220         * Scripts/webkitpy/scm_unittest.py:
3221
3222 2010-01-20  Jon Honeycutt  <jhoneycutt@apple.com>
3223
3224         MSAA: accSelect() is not implemented
3225
3226         https://bugs.webkit.org/show_bug.cgi?id=33918
3227         <rdar://problem/7436861>
3228
3229         Reviewed by Darin Adler.
3230
3231         * DumpRenderTree/AccessibilityUIElement.cpp:
3232         (takeFocusCallback):
3233         Call the object's takeFocus() function.
3234         (takeSelectionCallback):
3235         Call its takeSelection() function.
3236         (addSelectionCallback):
3237         Call its addSelection() function.
3238         (removeSelectionCallback):
3239         Call its removeSelection() function.
3240         (AccessibilityUIElement::getJSClass):
3241         Add new functions to the JS class definition.
3242
3243         * DumpRenderTree/AccessibilityUIElement.h:
3244         Declare new functions.
3245
3246         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3247         (AccessibilityUIElement::takeFocus):
3248         Stubbed.
3249         (AccessibilityUIElement::takeSelection):
3250         Stubbed.
3251         (AccessibilityUIElement::addSelection):
3252         Stubbed.
3253         (AccessibilityUIElement::removeSelection):
3254         Stubbed.
3255
3256         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3257         (AccessibilityUIElement::takeFocus):
3258         Stubbed.
3259         (AccessibilityUIElement::takeSelection):
3260         Stubbed.
3261         (AccessibilityUIElement::addSelection):
3262         Stubbed.
3263         (AccessibilityUIElement::removeSelection):
3264         Stubbed.
3265
3266         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3267         (AccessibilityUIElement::takeFocus):
3268         Call the object's accSelect() function, passing the appropriate flag.
3269         (AccessibilityUIElement::takeSelection):
3270         Ditto.
3271         (AccessibilityUIElement::addSelection):
3272         Ditto.
3273         (AccessibilityUIElement::removeSelection):
3274         Ditto.
3275
3276 2010-01-20  Andras Becsi  <abecsi@inf.u-szeged.hu>
3277
3278         Reviewed by Alexey Proskuryakov.
3279
3280         Extract Apache handling to httpd.pm module and use the provided functionality
3281         in scripts where Apache is needed.
3282         The module httpd.pm stores the PID of Apache in a variable and cleans up
3283         the PID directory after Apache properly shut down. Catching INT and TERM
3284         signals allows the scripts to close Apache and clean up its PID directory
3285         even if the testing was interrupted.
3286
3287         https://bugs.webkit.org/show_bug.cgi?id=33153
3288
3289         * Scripts/webkitperl/httpd.pm: Added.
3290         * Scripts/run-iexploder-tests:
3291         * Scripts/run-webkit-httpd:
3292         * Scripts/run-webkit-tests:
3293
3294 2010-01-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3295
3296         Reviewed by Simon Hausmann.
3297
3298         [Qt] Make DumpRenderTree build on Windows
3299
3300         * DumpRenderTree/qt/DumpRenderTree.pro:
3301         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3302         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3303         * DumpRenderTree/qt/main.cpp:
3304
3305 2010-01-20  Steve Block  <steveblock@google.com>
3306
3307         Reviewed by Eric Seidel.
3308
3309         Fix commit bot to land patches in order of the bug last modification date.
3310         https://bugs.webkit.org/show_bug.cgi?id=33395
3311
3312         * Scripts/webkitpy/bugzilla.py: Modified. Added 'order=Last+Changed' to bugzilla commit queue URL.
3313
3314 2010-01-20  Adam Barth  <abarth@webkit.org>
3315
3316         Reviewed by Eric Seidel.
3317
3318         Teach check-webkit-style about WebKit/gtk/tests
3319         https://bugs.webkit.org/show_bug.cgi?id=33892
3320
3321         Removes false positives found in
3322         https://bugs.webkit.org/show_bug.cgi?id=30883
3323
3324         * Scripts/webkitpy/style/cpp_style.py:
3325         * Scripts/webkitpy/style/cpp_style_unittest.py:
3326
3327 2010-01-20  Adam Barth  <abarth@webkit.org>
3328
3329         Reviewed by Eric Seidel.
3330
3331         Teach check-webkit-style about QGVLauncher
3332         https://bugs.webkit.org/show_bug.cgi?id=33890
3333
3334         Remove false positives found in
3335         https://bugs.webkit.org/show_bug.cgi?id=33708
3336
3337         * Scripts/webkitpy/style/cpp_style.py:
3338         * Scripts/webkitpy/style/cpp_style_unittest.py:
3339
3340 2010-01-20  Eric Seidel  <eric@webkit.org>
3341
3342         Reviewed by Adam Barth.
3343
3344         webkit-commit-queue status page is confusing
3345         https://bugs.webkit.org/show_bug.cgi?id=33496
3346
3347         This should improve the status page by removing more Fail messages.
3348         To do this, I re-factored the CommitQueue and the AbstractReviewQueues
3349         to behave more like one another.  This meant moving where the failure reporting was done.
3350         Previously the AbstractReviewQueue always used the parent process to report the error,
3351         while CommitQueue used the subprocess when possible, and the parent only reported errors
3352         that we didn't know how to handle (bugs in the commit-queue itself).
3353         Now the AbstractReviewQueue follow's the commit-queue's model.  This got rid of a try-block
3354         in both implementations and required teaching handle_script_error in each to post Fail messages
3355         to the status server instead of calling exit(1).
3356
3357         This will also make the style-queue share more bug posting logic with other queues:
3358         https://bugs.webkit.org/show_bug.cgi?id=33871
3359
3360         * Scripts/webkitpy/commands/early_warning_system.py:
3361          - Don't exit(1) as that will cause the calling queue to also report Fail to the status server.
3362            Implementors of handle_script_error are expected to update the status server if needed, but only exit if the error could not be handled.
3363            So we instead pass patch_has_failed_this_queue=True to _update_status_for_script_error in the case that this was a real failure.
3364            _update_status_for_script_error knows how to post the Fail message to the status server.
3365          - Teach _update_status_for_script_error how to post Fail messages to the status server.
3366         * Scripts/webkitpy/commands/queues.py:
3367          - Remove the try block from process_work_item since the caller already has one.
3368          - Only CC watchers on failure to cut down on commit-queue generated mail.
3369          - handle_unexpected_error needs to mark _did_fail now that the try block is gone from process_work_item.
3370          - Abstract _format_script_error_output_for_bug to share code between all queues.
3371          - The new _format_script_error_output_for_bug allows the style-queue to share the posting limit with other queues, as well as support linking to the full output.
3372          - Rename _can_build_and_test to _current_checkout_builds_and_passes_tests to better explain what revision it's testing.
3373          - Move logging out of _can_build_and_test and make the logs explain what revision we're testing.
3374          - handle_script_error now posts Fail instead of the try block in process_work_item handling it.
3375         * Scripts/webkitpy/queueengine.py:
3376          - QueueEngine is no longer used just by the commit-queue, update the logging to say "processing" instead of landing.
3377         * Scripts/webkitpy/scm.py:
3378          - Add new checkout_revision function.
3379         * Scripts/webkitpy/scm_unittest.py:
3380          - Test our new checkout_revision function.
3381
3382 2010-01-20  Adam Barth  <abarth@webkit.org>
3383
3384         Reviewed by Darin Adler.
3385
3386         Exempt JavaScriptCore/qt/api from style checks
3387         https://bugs.webkit.org/show_bug.cgi?id=33879
3388
3389         Apparently there is a JavaScriptCore API for Qt as well as a WebKit
3390         API.
3391
3392         * Scripts/webkitpy/style/cpp_style.py:
3393         * Scripts/webkitpy/style/cpp_style_unittest.py:
3394
3395 2010-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3396
3397         Reviewed by Simon Hausmann.
3398
3399         [Qt] Don't use QSocketNotifier in the DRT for reading stdin
3400
3401         QSocketNotifier is not available on Windows. Instead we read
3402         stdin synchronously after each test using signals and slots.
3403
3404         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3405         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3406         * DumpRenderTree/qt/main.cpp:
3407
3408 2010-01-19  Adam Barth  <abarth@webkit.org>
3409
3410         Rubber stamped by Eric Seidel.
3411
3412         Move chromium-ews back to building release only to make the EWS faster.
3413
3414         * Scripts/webkitpy/commands/early_warning_system.py:
3415
3416 2010-01-17  Jon Honeycutt  <jhoneycutt@apple.com>
3417
3418         MSAA: The child <option> elements of a non-multiple <select> are not
3419         exposed
3420
3421         https://bugs.webkit.org/show_bug.cgi?id=33773
3422         <rdar://problem/7550556>
3423
3424         Reviewed by Alice Liu.
3425
3426         * DumpRenderTree/AccessibilityUIElement.cpp:
3427         (getIsVisibleCallback):
3428         Call the object's isVisible() function.
3429         (getIsOffScreenCallback):
3430         Ditto, for isOffScreen().
3431         (getIsCollapsedCallback):
3432         Ditto, for isCollapsed().
3433         (getHasPopupCallback):
3434         Ditto, for hasPopup().
3435         (AccessibilityUIElement::getJSClass):
3436         Add isVisible and isOffScreen attributes.
3437
3438         * DumpRenderTree/AccessibilityUIElement.h:
3439         Declare new functions.
3440
3441         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3442         (AccessibilityUIElement::isVisible):
3443         Stubbed.
3444         (AccessibilityUIElement::isOffScreen):
3445         Stubbed.
3446         (AccessibilityUIElement::isCollapsed):
3447         Stubbed.
3448         (AccessibilityUIElement::hasPopup):
3449         Stubbed.
3450
3451         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3452         (AccessibilityUIElement::isVisible):
3453         Stubbed.
3454         (AccessibilityUIElement::isOffScreen):
3455         Stubbed.
3456         (AccessibilityUIElement::isCollapsed):
3457         Stubbed.
3458         (AccessibilityUIElement::hasPopup):
3459         Stubbed.
3460
3461         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3462         (AccessibilityUIElement::showMenu):
3463         Call the object's accDoDefaultAction() to show its popup menu.
3464         (AccessibilityUIElement::isEnabled):
3465         Check that the object does not have the "unavailable" state.
3466         (AccessibilityUIElement::isVisible):
3467         Check that the object does not have the "invisible" state.
3468         (AccessibilityUIElement::isOffScreen):
3469         Check whether the object has the "offscreen" state.
3470         (AccessibilityUIElement::isCollapsed):
3471         Check whether the object has the "collapsed" state.
3472         (AccessibilityUIElement::hasPopup):
3473         Check whether the object has the "has popup" state.
3474
3475 2010-01-19  Victor Wang  <victorw@chromium.org>
3476
3477         Reviewed by Eric Seidel.
3478
3479         Correct committer name.
3480         https://bugs.webkit.org/show_bug.cgi?id=33868
3481
3482         * Scripts/webkitpy/committers.py:
3483
3484 2010-01-19  Kent Tamura  <tkent@chromium.org>
3485
3486         Reviewed by Darin Adler.
3487
3488         [DRT][Mac] Add modifiers parameter to eventSender.mouseDown() and eventSender.mouseUp()
3489         https://bugs.webkit.org/show_bug.cgi?id=33783
3490
3491         Some listbox tests check selection behavior by click events with
3492         "meta" or "shift" keys. Behaviors for such modifier keys are
3493         platform-dependent. The new parameter of mouseDown() and mouseUp()
3494         allows to specify not only concrete modifier keys such as
3495         "shiftKey" "metaKey", but also functional names like
3496         "addSelectionKey" "rangeSelectionKey".
3497
3498         * DumpRenderTree/mac/EventSendingController.mm:
3499         (+[EventSendingController isSelectorExcludedFromWebScript:]):
3500         (+[EventSendingController webScriptNameForSelector:]):
3501         (buildModifierFlags):
3502         (-[EventSendingController mouseDown:withModifiers:]):
3503         (-[EventSendingController mouseDown:]):
3504         (-[EventSendingController mouseUp:withModifiers:]):
3505         (-[EventSendingController mouseUp:]):
3506         (-[EventSendingController keyDown:withModifiers:withLocation:]):
3507
3508 2010-01-19  Adam Barth  <abarth@webkit.org>
3509
3510         Reviewed by Eric Seidel.
3511
3512         Unbreak --request-commit
3513         https://bugs.webkit.org/show_bug.cgi?id=33832
3514
3515         * Scripts/webkitpy/bugzilla.py:
3516
3517 2010-01-19  Eric Seidel  <eric@webkit.org>
3518
3519         Reviewed by Adam Barth.
3520
3521         validate-committer-lists throws exception and committers.py needs a refresh
3522         https://bugs.webkit.org/show_bug.cgi?id=33831
3523
3524         * Scripts/validate-committer-lists: use webkit_logging
3525         * Scripts/webkitpy/committers.py: Add recently minted committers.  Fix Simon Hausmanns email address list to include his webkit-committers@lists address.
3526
3527 2010-01-18  Adam Roben  <aroben@apple.com>
3528
3529         Add LayoutTestController support for calling new WebKit SPI to
3530         disallow setting document.domain
3531
3532         DRT part of fixing <http://webkit.org/b/33806>
3533         <rdar://problem/7552837> Would like API to disallow setting of
3534         document.domain for pages with certain URL schemes
3535
3536         Reviewed by Sam Weinig.
3537
3538         * DumpRenderTree/LayoutTestController.cpp:
3539         (setDomainRelaxationForbiddenForURLSchemeCallback): Added. Calls
3540         through to LayoutTestController.
3541         (LayoutTestController::staticFunctions): Added
3542         setDomainRelaxationForbiddenForURLScheme.
3543
3544         * DumpRenderTree/LayoutTestController.h: Added
3545         setDomainRelaxationForbiddenForURLScheme.
3546
3547         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3548         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
3549         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3550         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
3551         Added. Calls through to WebKit.
3552
3553         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3554         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
3555         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3556         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
3557         Stubbed out.
3558
3559 2010-01-18  Adam Barth  <abarth@webkit.org>
3560
3561         Reviewed by Adam Roben.
3562
3563         Rename patches-to-commit to patches-in-commit-queue
3564         https://bugs.webkit.org/show_bug.cgi?id=33789
3565
3566         The command really lists the patches in the commit-queue not all the
3567         patches that are pending-commit (as the FIXME commands).
3568
3569         * Scripts/webkitpy/commands/queries.py:
3570         * Scripts/webkitpy/commands/queries_unittest.py:
3571
3572 2010-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3573
3574         Reviewed by Simon Hausmann.
3575
3576         [Qt] Force qmake to generate a single makefile for DerivedSources.pro
3577
3578         * Scripts/webkitdirs.pm:
3579
3580 2010-01-18  Adam Roben  <aroben@apple.com>
3581
3582         Clean up use of /useenv when invoking Visual C++
3583
3584         This change reverts things to their pre-r49485 state. That revision
3585         (and, subsequently, r49664 and r51788) started passing /useenv to
3586         Visual C++, even in cases where we don't want to do so (such as when
3587         invoking Visual C++ Express), in the name of making the Chromium build
3588         work. Now that Chromium isn't using buildVisualStudioProject or
3589         pdevenv, we can put things back they way they were.
3590
3591         Fixes <http://webkit.org/b/33797> build-webkit fails with VC++ Express
3592         (due to /useenv flag)
3593