https://bugs.webkit.org/show_bug.cgi?id=30456
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2
3         Reviewed by Dan Bernstein.
4
5         https://bugs.webkit.org/show_bug.cgi?id=30456
6         Fixes for new Debug_All Windows build configuration.
7
8         * DumpRenderTree/win/DumpRenderTree.cpp:
9         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
10         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
11
12 2009-10-16  Eric Seidel  <eric@webkit.org>
13
14         Reviewed by Adam Barth.
15
16         commit-queue status bot should list which buildbot is blocking the queue
17         https://bugs.webkit.org/show_bug.cgi?id=30452
18
19         Add new methods and testing.
20
21         * Scripts/bugzilla-tool:
22         * Scripts/modules/buildbot.py:
23         * Scripts/modules/buildbot_unittest.py:
24
25 2009-10-16  Eric Seidel  <eric@webkit.org>
26
27         Reviewed by Adam Barth.
28
29         run-webkit-tests fails when CWD is not inside a WebKit checkout
30         https://bugs.webkit.org/show_bug.cgi?id=30451
31
32         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
33         * Scripts/modules/scm_unittest.py:
34           - Remove use of original_path (we don't need to restore the CWD).
35           - Don't use '.' to find the webkit checkout, use __file__ instead.
36
37 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
38
39         Reviewed by Adam Roben.
40
41         Add a Debug_All configuration to build entire stack as debug.
42         Change Debug_Internal to:
43         - stop using _debug suffix for all WebKit/Safari binaries
44         - not use _debug as a DLL naming suffix
45         - use non-debug C runtime lib.
46
47         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
48         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
49         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
50         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
51         Add missing debug.vsprops inherited property sheet.
52         Add Debug_All configuration.
53         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
54         * WinLauncher/WinLauncher.vcproj:
55         Removed extraneous definitions inherited from vsprops.
56         Add Debug_All configuration.
57
58 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
59
60         Reviewed by David Levin.
61
62         check-webkit-style is wrong about indent checking in namespaces
63         in header files and a few other things
64         https://bugs.webkit.org/show_bug.cgi?id=30362
65
66         The few other things include:
67         + check-webkit-style does not require spaces around the equal sign
68           inside 'if' statements and around binary operators that take 
69           numeric literals.
70         + check-webkit-style reports false errors for the / operator
71           when part of a filename in the #include directive.
72
73         * Scripts/modules/cpp_style.py:
74         Improved indentation checking and space checking around
75         binary operators. While the checks are still not perfect,
76         they are clearly better than before.
77         * Scripts/modules/cpp_style_unittest.py:
78         Added test cases for the newly supported checks and modified old
79         test cases to match the new guidelines
80
81 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
82
83         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
84
85         * wx/build/settings.py:
86
87 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
88
89         Reviewed by David Levin.
90
91         Add mod_pywebsocket to test Web Sockets.
92         http://code.google.com/p/pywebsocket/
93         https://bugs.webkit.org/show_bug.cgi?id=27490
94
95         * pywebsocket/COPYING: Added.
96         * pywebsocket/MANIFEST.in: Added.
97         * pywebsocket/README: Added.
98         * pywebsocket/example/echo_client.py: Added.
99         * pywebsocket/example/echo_wsh.py: Added.
100         * pywebsocket/mod_pywebsocket/__init__.py: Added.
101         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
102         * pywebsocket/mod_pywebsocket/handshake.py: Added.
103         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
104         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
105         * pywebsocket/mod_pywebsocket/standalone.py: Added.
106         * pywebsocket/mod_pywebsocket/util.py: Added.
107         * pywebsocket/setup.py: Added.
108         * pywebsocket/test/config.py: Added.
109         * pywebsocket/test/mock.py: Added.
110         * pywebsocket/test/run_all.py: Added.
111         * pywebsocket/test/test_dispatch.py: Added.
112         * pywebsocket/test/test_handshake.py: Added.
113         * pywebsocket/test/test_mock.py: Added.
114         * pywebsocket/test/test_msgutil.py: Added.
115         * pywebsocket/test/test_util.py: Added.
116         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
117         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
118         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
119         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
120         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
121         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
122         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
123         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
124
125 2009-10-15  James Robinson  <jamesr@google.com>
126
127         Reviewed by David Levin.
128
129         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
130
131         https://bugs.webkit.org/show_bug.cgi?id=30426
132
133         * Scripts/modules/cpp_style.py:
134         * Scripts/modules/cpp_style_unittest.py:
135
136 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
137
138         Reviewed by Adam Roben.
139
140         Fixes <http://webkit.org/b/30411>.
141         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
142         
143         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
144         building Chromium.
145
146         * Scripts/pdevenv:
147
148 2009-10-15  Robin Dunn  <robin@alldunn.com>
149
150         Reviewed by Kevin Ollivier.
151
152         Add Mac package building scripts for wx.
153         
154         https://bugs.webkit.org/show_bug.cgi?id=30405
155
156         * wx/build/build_utils.py:
157         * wx/build/settings.py:
158         * wx/packaging/build-mac-installer.py: Added.
159
160 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
161
162         Reviewed by Gustavo Noronha.
163
164         Enable Web Sockets support when running layout tests.
165
166         * DumpRenderTree/gtk/DumpRenderTree.cpp:
167         (resetDefaultsToConsistentValues):
168
169 2009-10-15  Xan Lopez  <xlopez@igalia.com>
170
171         Reviewed by Gustavo Noronha.
172
173         Need to initialize event.button.button, since in most cases a
174         button number is not passed as an argument.
175
176         * DumpRenderTree/gtk/EventSender.cpp:
177         (mouseDownCallback):
178         (mouseUpCallback):
179
180 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
181
182         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
183         the OS if none was explicitly set.
184
185         * wx/build/settings.py:
186
187 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
188
189         Reviewed by Timothy Hatcher.
190
191         Web Inspector: enable developers extras within inspector layout tests.
192
193         https://bugs.webkit.org/show_bug.cgi?id=30014
194
195         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
196         (LayoutTestController::showWebInspector):
197         (LayoutTestController::closeWebInspector):
198         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
199         (LayoutTestController::showWebInspector):
200         (LayoutTestController::closeWebInspector):
201
202 2009-10-14  José Millán Soto  <jmillan@igalia.com>
203
204         Reviewed by Jan Alonzo.
205
206         GtkLauncher is using a deprecated signal
207         https://bugs.webkit.org/show_bug.cgi?id=30364
208
209         Modified GtkLauncher to use notify::title signal instead of
210         deprecated title-changed signal
211
212         * GtkLauncher/main.c:
213         (notify_title_cb):
214         (create_browser):
215
216 2009-10-14  Brady Eidson  <beidson@apple.com>
217
218         Reviewed by Sam Weinig.
219
220         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
221         1 - Disables WebHistory
222         2 - Doesn't make sense in that context anyway.
223
224         * DumpRenderTree/win/DumpRenderTree.cpp:
225         (createWebViewAndOffscreenWindow):
226
227 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
228
229         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
230         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
231
232         * wx/build/settings.py:
233         * wx/install-unix-extras:
234
235 2009-10-14  Brady Eidson  <beidson@apple.com>
236
237         Reviewed by Sam Weinig.
238
239         WebKit Win API should provide a delegate interface for global history.
240         https://bugs.webkit.org/show_bug.cgi?id=29905
241
242         * DumpRenderTree/LayoutTestController.cpp:
243         (LayoutTestController::LayoutTestController):
244         * DumpRenderTree/LayoutTestController.h:
245         (LayoutTestController::dumpHistoryDelegateCallbacks):
246         (LayoutTestController::setDumpHistoryDelegateCallbacks):
247                 
248         * DumpRenderTree/win/DumpRenderTree.cpp:
249         (shouldLogHistoryDelegates):
250         (runTest):
251         (createWebViewAndOffscreenWindow):
252         (main):
253         * DumpRenderTree/win/DumpRenderTree.vcproj:
254         
255         Add the IWebHistoryDelegate to DRT Windows:
256         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
257         (wstringFromBSTR):
258         (HistoryDelegate::HistoryDelegate):
259         (HistoryDelegate::~HistoryDelegate):
260         (HistoryDelegate::QueryInterface):
261         (HistoryDelegate::AddRef):
262         (HistoryDelegate::Release):
263         (HistoryDelegate::didNavigateWithNavigationData):
264         (HistoryDelegate::didPerformClientRedirectFromURL):
265         (HistoryDelegate::didPerformServerRedirectFromURL):
266         (HistoryDelegate::updateHistoryTitle):
267         (HistoryDelegate::populateVisitedLinksForWebView):
268         * DumpRenderTree/win/HistoryDelegate.h: Added.
269
270         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
271         (LayoutTestController::removeAllVisitedLinks):
272
273 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
274
275         Reviewed by Simon Hausmann.
276
277         [Qt] Implement support for setPOSIXLocale on Qt.
278         https://bugs.webkit.org/show_bug.cgi?id=30268 
279  
280         * DumpRenderTree/qt/DumpRenderTree.cpp:
281         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
282         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
283         (LayoutTestController::setPOSIXLocale):
284         * DumpRenderTree/qt/LayoutTestControllerQt.h:
285
286 2009-10-13  Stephanie Lewis  <slewis@apple.com>
287
288         Unreviewed, adding myself to reviewers list.
289
290         * Scripts/modules/committers.py:
291
292 2009-10-13  Stephanie Lewis  <slewis@apple.com>
293
294         Reviewed by Mark Rowe.
295
296         Fix null assignment so root tests work again.
297
298         * Scripts/webkitdirs.pm:
299
300 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
301
302         Reviewed by Simon Hausmann.
303
304         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
305         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
306         This is done in preparation of implementing missing features in DRT.
307         No functionality changes made yet.
308
309         * DumpRenderTree/qt/DumpRenderTree.cpp:
310         * DumpRenderTree/qt/DumpRenderTree.pro:
311         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
312         (EventSender::EventSender):
313         (EventSender::mouseDown):
314         (EventSender::mouseUp):
315         (EventSender::mouseMoveTo):
316         (EventSender::leapForward):
317         (EventSender::keyDown):
318         (EventSender::contextClick):
319         (EventSender::scheduleAsynchronousClick):
320         (EventSender::frameUnderMouse):
321         * DumpRenderTree/qt/EventSenderQt.h: Added.
322         (EventSender::clearKillRing):
323         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
324         (LayoutTestController::LayoutTestController):
325         (LayoutTestController::reset):
326         (LayoutTestController::processWork):
327         (LayoutTestController::maybeDump):
328         (LayoutTestController::waitUntilDone):
329         (LayoutTestController::notifyDone):
330         (LayoutTestController::windowCount):
331         (LayoutTestController::clearBackForwardList):
332         (LayoutTestController::dumpEditingCallbacks):
333         (LayoutTestController::dumpResourceLoadCallbacks):
334         (LayoutTestController::queueBackNavigation):
335         (LayoutTestController::queueForwardNavigation):
336         (LayoutTestController::queueLoad):
337         (LayoutTestController::queueReload):
338         (LayoutTestController::queueScript):
339         (LayoutTestController::provisionalLoad):
340         (LayoutTestController::timerEvent):
341         (LayoutTestController::encodeHostName):
342         (LayoutTestController::decodeHostName):
343         (LayoutTestController::setJavaScriptProfilingEnabled):
344         (LayoutTestController::setFixedContentsSize):
345         (LayoutTestController::setPrivateBrowsingEnabled):
346         (LayoutTestController::setPopupBlockingEnabled):
347         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
348         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
349         (LayoutTestController::numberOfActiveAnimations):
350         (LayoutTestController::disableImageLoading):
351         (LayoutTestController::dispatchPendingLoadRequests):
352         (LayoutTestController::setDatabaseQuota):
353         (LayoutTestController::clearAllDatabases):
354         (LayoutTestController::whiteListAccessFromOrigin):
355         (LayoutTestController::waitForPolicyDelegate):
356         (LayoutTestController::overridePreference):
357         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
358         (LayoutTestController::isLoading):
359         (LayoutTestController::setLoading):
360         (LayoutTestController::shouldDumpAsText):
361         (LayoutTestController::shouldDumpBackForwardList):
362         (LayoutTestController::shouldDumpChildrenAsText):
363         (LayoutTestController::shouldDumpDatabaseCallbacks):
364         (LayoutTestController::shouldDumpStatusCallbacks):
365         (LayoutTestController::shouldWaitUntilDone):
366         (LayoutTestController::canOpenWindows):
367         (LayoutTestController::shouldDumpTitleChanges):
368         (LayoutTestController::waitForPolicy):
369         (LayoutTestController::dumpAsText):
370         (LayoutTestController::dumpChildFramesAsText):
371         (LayoutTestController::dumpDatabaseCallbacks):
372         (LayoutTestController::dumpStatusCallbacks):
373         (LayoutTestController::setCanOpenWindows):
374         (LayoutTestController::dumpBackForwardList):
375         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
376         (LayoutTestController::display):
377         (LayoutTestController::dumpTitleChanges):
378         (LayoutTestController::dumpSelectionRect):
379         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
380         (TextInputController::TextInputController):
381         (TextInputController::doCommand):
382         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
383         * DumpRenderTree/qt/WorkQueue.cpp:
384         * DumpRenderTree/qt/WorkQueue.h:
385         * DumpRenderTree/qt/WorkQueueItem.h:
386         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
387         (findFrameNamed):
388         (LoadItem::invoke):
389         (ReloadItem::invoke):
390         (ScriptItem::invoke):
391         (BackForwardItem::invoke):
392         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
393         * DumpRenderTree/qt/jsobjects.h:
394
395 2009-10-13  Dmitry Titov  <dimich@chromium.org>
396
397         Not reviewed, adding myself to the list of reviewers.
398
399         * Scripts/modules/committers.py:
400
401 2009-10-13  Anders Carlsson  <andersca@apple.com>
402
403         Reviewed by Sam Weinig.
404
405         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
406
407         Make the private browsing mode testable by the test plug-in.
408         
409         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
410         (pluginGetProperty):
411         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
412         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
413         (NPP_New):
414         (NPP_SetValue):
415
416 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
417
418         No review, just adding self to the list of reviewers.
419
420         * Scripts/modules/committers.py:
421
422 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
423
424         Reviewed by Adam Roben.
425
426         Web Inspector: Use proper web view in inspector layout
427         tests for windows.
428
429         https://bugs.webkit.org/show_bug.cgi?id=30298
430
431         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
432         (LayoutTestController::showWebInspector):
433         (LayoutTestController::closeWebInspector):
434         (LayoutTestController::evaluateInWebInspector):
435
436 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
437
438         Reviewed by Sam Weinig.
439
440         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
441         https://bugs.webkit.org/show_bug.cgi?id=29841
442
443         * DumpRenderTree/mac/DumpRenderTree.mm:
444         (resetDefaultsToConsistentValues):
445         * DumpRenderTree/win/DumpRenderTree.cpp:
446         (resetDefaultsToConsistentValues):
447
448 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
449
450         Reviewed by Dimitri Glazkov.
451
452         Chromium Port - Windows
453         https://bugs.webkit.org/show_bug.cgi?id=29969
454
455         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
456         * Scripts/webkitdirs.pm:
457
458 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
459
460         Reviewed by Darin Adler.
461
462         jsc scripts cleanup and Qt/GTK fix
463         https://bugs.webkit.org/show_bug.cgi?id=30288
464
465         Duplicated jscPath() moved to webkitdirs.pm.
466         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
467         Configuration added (release/debug) to path for Qt-port on Windows.
468
469         * Scripts/run-javascriptcore-tests:
470         * Scripts/run-jsc:
471         * Scripts/run-sunspider:
472         * Scripts/sunspider-compare-results:
473         * Scripts/webkitdirs.pm:
474
475 2009-10-11  Adam Barth  <abarth@webkit.org>
476
477         Unreviewed.  Add Collin to committers.py.
478
479         * Scripts/modules/committers.py:
480
481 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
482
483         wx build fix, add bindings to source/include dirs now that there are sources there.
484
485         * wx/build/settings.py:
486
487 2009-10-09  Mark Rowe  <mrowe@apple.com>
488
489         Reviewed by Brady Eidson.
490
491         Enable plug-in halting in DumpRenderTree.
492
493         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
494         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
495
496         * DumpRenderTree/mac/DumpRenderTree.mm:
497         (resetDefaultsToConsistentValues):
498         * DumpRenderTree/mac/UIDelegate.mm:
499         (-[UIDelegate webView:shouldHaltPlugin:]):
500
501 2009-10-08  Brady Eidson  <beidson@apple.com>
502
503         Reviewed by Dan Bernstein.
504
505         Ask the History Delegate to populate the visited links hash.
506         <rdar://problem/7285293> and https://webkit.org/b/29904
507
508         Add the ability for LayoutTestController to clear all visited links.
509         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
510
511         * DumpRenderTree/LayoutTestController.cpp:
512         (LayoutTestController::LayoutTestController):
513         (removeAllVisitedLinksCallback):
514         (LayoutTestController::staticFunctions):
515         * DumpRenderTree/LayoutTestController.h:
516         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
517         (LayoutTestController::removeAllVisitedLinks):
518
519         * DumpRenderTree/mac/HistoryDelegate.mm:
520         (-[HistoryDelegate populateVisitedLinksForWebView:]):
521
522         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
523         (LayoutTestController::removeAllVisitedLinks):
524         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
525         (LayoutTestController::removeAllVisitedLinks):
526         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
527         (LayoutTestController::removeAllVisitedLinks):
528
529
530 2009-10-08  Daniel Bates  <dbates@webkit.org>
531
532         Reviewed by Adam Roben.
533
534         https://bugs.webkit.org/show_bug.cgi?id=30175
535         
536         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
537         the OLE drag-and-drop return value like the function it emulates. Currently, 
538         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine 
539         whether the drag-and-drop operation was successful or was cancelled.
540         
541         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop 
542         return value according to whether the drop operation was successful or not.
543
544         * DumpRenderTree/win/EventSender.cpp:
545         (doMouseUp): Added parameter oleDragAndDropReturnValue.
546         (replaySavedEvents): Ditto.
547         * DumpRenderTree/win/EventSender.h:
548         * DumpRenderTree/win/UIDelegate.cpp:
549         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
550
551 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
552
553         Reviewed by Xan Lopez.
554
555         [GTK] Added support for a parameter setting the button that was
556         pressed in the mouseDown function.
557         https://bugs.webkit.org/show_bug.cgi?id=30220
558
559         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
560
561 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
562
563         Reviewed by Xan Lopez.
564
565         [GTK] Added a line to the bottom of the expected result to match
566         the output of the test.
567         https://bugs.webkit.org/show_bug.cgi?id=30220
568
569         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
570         expected.txt:
571
572 2009-10-08  Adam Roben  <aroben@apple.com>
573
574         Use QueryInterface to get IWebInspectorPrivate
575
576         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
577         accessed in a more standard way
578
579         Reviewed by John Sullivan and Tim Hatcher.
580
581         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
582         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
583         by calling IWebViewPrivate::inspector, then use QueryInterface to get
584         to the IWebInspectorPrivate interface.
585
586 2009-10-07  Adam Roben  <aroben@apple.com>
587
588         Implement DRT support for origin whitelisting
589
590         Fixes <http://webkit.org/b/30185>.
591
592         Reviewed by Eric Seidel.
593
594         * DumpRenderTree/win/DumpRenderTree.cpp:
595         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
596         whitelist, to match Mac DRT.
597         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
598         (LayoutTestController::whiteListAccessFromOrigin): Call through to
599         IWebViewPrivate::whiteListAccessFromOrigin.
600
601 2009-10-07  Brady Eidson  <beidson@apple.com>
602
603         Reviewed by Darin Adler.
604
605         Send title changes to the global history delegate.
606         <rdar://problem/7285293> and https://webkit.org/b/29904
607
608         * DumpRenderTree/mac/HistoryDelegate.mm:
609         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
610
611 2009-10-07  Adam Barth  <abarth@webkit.org>
612
613         Unreviewed.  Remove some folks from committers.py who were listed on
614         the WebKit Team wiki page but who weren't actually listed as commit+.
615         At some point, we should coorelate this list with the committers
616         mailing list.
617
618         * Scripts/modules/committers.py:
619
620 2009-10-07  Adam Barth  <abarth@webkit.org>
621
622         Unreviewed.  Import a bunch of committers from the WebKit Team page on
623         the wiki into committers.py.
624
625         * Scripts/modules/committers.py:
626
627 2009-10-07  Adam Barth  <abarth@webkit.org>
628
629         Unreviewed.  Added Aaron Boodman to committers.py.
630
631         * Scripts/modules/committers.py:
632
633 2009-10-07  Evan Martin  <evan@chromium.org>
634
635         Reviewed by Darin Adler.
636
637         Add API to LayoutTestController for re/setting the system locale.
638         https://bugs.webkit.org/show_bug.cgi?id=18994
639
640         * DumpRenderTree/LayoutTestController.cpp:
641         (setLocaleCallback):
642         (LayoutTestController::staticFunctions):
643         (LayoutTestController::setLocale):
644         * DumpRenderTree/LayoutTestController.h:
645
646 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
647
648         Reviewed by Jan Alonzo.
649
650         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
651         https://bugs.webkit.org/show_bug.cgi?id=29689
652
653         Build fix by adding -lfontconfig for DumpRenderTree.
654
655         * GNUmakefile.am:
656
657 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
658
659         Reviewed by Simon Hausmann.
660
661         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
662
663         * Scripts/run-webkit-tests:
664
665 2009-10-07  Xan Lopez  <xlopez@igalia.com>
666
667         Reviewed by Gustavo Noronha.
668
669         "delete" in EventSender is the backspace key, not the delete one.
670
671         * DumpRenderTree/gtk/EventSender.cpp:
672         (keyDownCallback):
673
674 2009-10-07  Xan Lopez  <xlopez@igalia.com>
675
676         Reviewed by Gustavo Noronha.
677
678         getChildrenWithRange expects as last parameter the end index, not
679         the length of the range. Correct this and clarify the variable
680         names to reflect how the code works.
681
682         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
683         (AccessibilityUIElement::getChildrenWithRange):
684         (AccessibilityUIElement::getChildAtIndex):
685
686 2009-10-06  Mark Rowe  <mrowe@apple.com>
687
688         Reviewed by Simon Fraser.
689
690         <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
691
692         * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
693         the fact we have already changed the working directory to the top of the open source tree.
694
695 2009-10-06  Julie Parent  <jparent@chromium.org>
696
697         Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
698         rather than my committer email.
699
700         * Scripts/modules/committers.py:
701
702 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
703
704         Reviewed by Eric Seidel.
705
706         [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
707
708         r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
709         it after each layout test as it should do, making the DRT dump additional output
710         for all of the subsequent layout tests.
711
712         * DumpRenderTree/qt/jsobjects.cpp:
713         (LayoutTestController::reset):
714
715 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
716
717         Reviewed by Simon Hausmann.
718
719         [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
720         fast/dom/assign-to-window-status.html test, which is passing as a result.
721
722         https://bugs.webkit.org/show_bug.cgi?id=30127
723
724         * DumpRenderTree/qt/DumpRenderTree.cpp:
725         (WebCore::DumpRenderTree::DumpRenderTree):
726         (WebCore::DumpRenderTree::statusBarMessage):
727         * DumpRenderTree/qt/DumpRenderTree.h:
728         * DumpRenderTree/qt/jsobjects.h:
729         (LayoutTestController::shouldDumpStatusCallbacks):
730         (LayoutTestController::dumpStatusCallbacks):
731
732 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
733
734         Reviewed by Simon Hausmann.
735
736         [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
737         ignores the argument indicating which mouse button to trigger.
738         https://bugs.webkit.org/show_bug.cgi?id=30048
739
740         This affects the fast/events/mouse-click-events.html layout test.
741
742         * DumpRenderTree/qt/jsobjects.cpp:
743         (EventSender::mouseDown):
744         (EventSender::mouseUp):
745         * DumpRenderTree/qt/jsobjects.h:
746
747 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
748
749         Reviewed by Simon Hausmann.
750
751         [Qt] Fix the EventSender::keyDown() implementation
752         https://bugs.webkit.org/show_bug.cgi?id=30043
753
754         It should post both a key press event and a key release event,
755         just like other ports do.
756
757         * DumpRenderTree/qt/jsobjects.cpp:
758         (EventSender::keyDown):
759
760 2009-10-05  Kevin Ollivier  <kevino@theolliviers.com>
761
762         wx build fix. Add jpeg to the list of libs to link against.
763
764         * wx/build/settings.py:
765
766 2009-10-05  Jakub Wieczorek  <faw217@gmail.com>
767
768         Reviewed by Simon Hausmann.
769
770         [Qt] EventSender::keyDown() cannot send function-key events.
771         https://bugs.webkit.org/show_bug.cgi?id=30044
772
773         This affects the fast/events/keydown-function-keys.html layout test.
774
775         * DumpRenderTree/qt/jsobjects.cpp:
776         (EventSender::keyDown):
777
778 2009-10-05  Vadim Zeitlin  <vadim@wxwidgets.org>
779
780         Added --wx-compiler-prefix waf option to allow building wxWebKit with
781         wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".
782
783         * wx/build/settings.py:
784         * wx/build/wxpresets.py:
785
786 2009-10-05  Pavel Feldman  <pfeldman@chromium.org>
787
788         Reviewed by Timothy Hatcher.
789
790         Web Inspector: add testing harness for Web Inspector.
791
792         https://bugs.webkit.org/show_bug.cgi?id=30010
793
794         * DumpRenderTree/LayoutTestController.cpp:
795         (showWebInspectorCallback):
796         (closeWebInspectorCallback):
797         (evaluateInWebInspectorCallback):
798         (LayoutTestController::staticFunctions):
799         * DumpRenderTree/LayoutTestController.h:
800         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
801         (LayoutTestController::showWebInspector):
802         (LayoutTestController::closeWebInspector):
803         (LayoutTestController::evaluateInWebInspector):
804         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
805         (LayoutTestController::showWebInspector):
806         (LayoutTestController::closeWebInspector):
807         (LayoutTestController::evaluateInWebInspector):
808         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
809         (LayoutTestController::showWebInspector):
810         (LayoutTestController::closeWebInspector):
811         (LayoutTestController::evaluateInWebInspector):
812         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
813         (LayoutTestController::showWebInspector):
814         (LayoutTestController::closeWebInspector):
815         (LayoutTestController::evaluateInWebInspector):
816
817 2009-10-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
818
819         Reviewed by Ariyha Hidayat.
820
821         Pass arguments to system() as a string instead of array
822
823         When passed as an array entries with a space fail to translate
824         to two arguments to the child process, so instead of manually
825         splitting all the entries in @buildArgs we pass the whole thing
826         as a string instead.
827
828         * Scripts/webkitdirs.pm:
829
830 2009-10-04  Carol Szabo  <carol.szabo@nokia.com>
831
832         Reviewed by David Levin.
833
834         check-webkit-style misses whitespace errors for operators:
835         <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||.
836         https://bugs.webkit.org/show_bug.cgi?id=30021
837
838         * Scripts/modules/cpp_style.py:
839         Added the operators mentioned above to the same list as == and !=.
840
841 2009-10-02  Julie Parent  <jparent@chromium.org>
842
843         Unreviewed.
844
845         Adding myself and Ojan Vafai as committers, because we are committers.
846
847         * Scripts/modules/committers.py:
848
849 2009-10-02  Brian Weinstein  <bweinstein@apple.com>
850
851         Reviewed by Adam Roben.
852
853         svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
854         this will help the patch merging process when TryBots are used.
855
856         * Scripts/svn-create-patch:
857
858 2009-10-02  Jakub Wieczorek  <faw217@gmail.com>
859
860         Reviewed by Simon Hausmann.
861
862         [Qt] Implement layoutTestController.overridePreference().
863         https://bugs.webkit.org/show_bug.cgi?id=29970
864
865         * DumpRenderTree/qt/DumpRenderTree.cpp:
866         (WebCore::WebPage::WebPage):
867         (WebCore::WebPage::resetSettings):
868         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
869         * DumpRenderTree/qt/jsobjects.cpp:
870         (LayoutTestController::reset):
871         (LayoutTestController::setPrivateBrowsingEnabled):
872         (LayoutTestController::setPopupBlockingEnabled):
873         (LayoutTestController::overridePreference):
874         * DumpRenderTree/qt/jsobjects.h:
875
876 2009-10-01  Chris Marrin  <cmarrin@apple.com>
877
878         Reviewed by Oliver Hunt.
879
880         Turn on ENABLE_3D_CANVAS in TOT
881         https://bugs.webkit.org/show_bug.cgi?id=29906
882
883         * Scripts/build-webkit:
884
885 2009-10-01  Kenneth Rohde Christiansen  <kenneth@webkit.org>
886
887         Rubberstamped by Simon Hausmann.
888
889         Enable HTTP tests for Qt
890
891         * Scripts/run-webkit-tests:
892
893 2009-10-01  Yaar Schnitman  <yaar@chromium.org>
894
895         Reviewed by Dimitri Glazkov.
896
897         build-webkit --chromium now also works on cygwin.
898
899         https://bugs.webkit.org/show_bug.cgi?id=29973
900
901         * Scripts/webkitdirs.pm:
902
903 2009-10-01  Zoltan Horvath  <zoltan@webkit.org>
904
905         Reviewed by Simon Hausmann.
906
907         [Qt] Don't use TCmalloc in DumpRenderTree
908         https://bugs.webkit.org/show_bug.cgi?id=27029
909
910         Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT.
911
912         * DumpRenderTree/qt/DumpRenderTree.pro:
913
914 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
915
916         Reviewed by Simon Hausmann.
917
918         [Qt] Implement eventSender.scheduleAsynchronousClick().
919
920         https://bugs.webkit.org/show_bug.cgi?id=29931
921
922         * DumpRenderTree/qt/jsobjects.cpp:
923         (EventSender::scheduleAsynchronousClick):
924         * DumpRenderTree/qt/jsobjects.h:
925
926 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
927
928         Reviewed by Simon Hausmann.
929
930         [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
931         fast/events/open-window-from-another-frame.html from the Skipped list.
932
933         https://bugs.webkit.org/show_bug.cgi?id=29930
934
935         * DumpRenderTree/qt/jsobjects.cpp:
936         (LayoutTestController::setPopupBlockingEnabled):
937         * DumpRenderTree/qt/jsobjects.h:
938
939 2009-09-30  Cameron McCormack  <cam@mcc.id.au>
940
941         Unreviewed.
942
943         Added myself to the list of committers.
944
945         * Scripts/modules/committers.py:
946
947 2009-09-30  Eric Seidel  <eric@webkit.org>
948
949         No review, just adding Geoff to the list of reviewers.
950
951         * Scripts/modules/committers.py:
952
953 2009-09-30  Dan Bernstein  <mitz@apple.com>
954
955         Reviewed by Sam Weinig.
956
957         Added the WebKit Layout Tests fonts that are referenced in
958         LayoutTests/platform/win/css2.1/resources/Mac-compatible-font-fallback.css
959
960         * DumpRenderTree/fonts/WebKit Layout Tests 2.ttf: Added.
961         * DumpRenderTree/fonts/WebKit Layout Tests.ttf: Added.
962
963 2009-09-30  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
964
965         Reviewed by David Kilzer.
966
967         Make sunspider scripts work on Windows platform.
968         https://bugs.webkit.org/show_bug.cgi?id=29656
969
970         * Scripts/run-sunspider: Perl scripts invoked with same Perl interpreter.
971         * Scripts/sunspider-compare-results: Perl scripts invoked with same Perl interpreter.
972         * Scripts/webkitdirs.pm: currentPerlPath() added.
973
974 2009-09-29  Brady Eidson  <beidson@apple.com>
975
976         Rubberstamped by Dan Bernstein.
977
978         Fix license and some sorting in new files.
979
980         * DumpRenderTree/mac/HistoryDelegate.h:
981         * DumpRenderTree/mac/HistoryDelegate.mm:
982
983 2009-09-29  Yaar Schnitman  <yaar@chromium.org>
984
985         Reviewed by David Kilzer.
986
987         Fixed how error codes are handled.
988         https://bugs.webkit.org/show_bug.cgi?id=29898
989
990         * Scripts/update-webkit:
991         * Scripts/update-webkit-chromium:
992
993 2009-09-29  Brady Eidson  <beidson@apple.com>
994
995         Reviewed by John Sullivan.
996
997         Updated way-out-of-date sorting throughout the dump methods/flags.
998
999         * DumpRenderTree/LayoutTestController.cpp:
1000         (LayoutTestController::LayoutTestController):
1001         (dumpAsPDFCallback):
1002         (dumpAsTextCallback):
1003         (dumpFrameLoadCallbacksCallback):
1004         (dumpResourceLoadCallbacksCallback):
1005         (LayoutTestController::staticFunctions):
1006
1007         * DumpRenderTree/LayoutTestController.h:
1008         (LayoutTestController::dumpAsText):
1009         (LayoutTestController::setDumpAsText):
1010         (LayoutTestController::dumpFrameLoadCallbacks):
1011         (LayoutTestController::setDumpFrameLoadCallbacks):
1012         (LayoutTestController::dumpSelectionRect):
1013         (LayoutTestController::setDumpSelectionRect):
1014         (LayoutTestController::dumpSourceAsWebArchive):
1015         (LayoutTestController::setDumpSourceAsWebArchive):
1016         (LayoutTestController::dumpStatusCallbacks):
1017         (LayoutTestController::setDumpStatusCallbacks):
1018         (LayoutTestController::dumpTitleChanges):
1019         (LayoutTestController::setDumpTitleChanges):
1020         (LayoutTestController::dumpWillCacheResponse):
1021         (LayoutTestController::setDumpWillCacheResponse):
1022
1023 2009-09-29  Brady Eidson  <beidson@apple.com>
1024
1025         Reviewed by John Sullivan.
1026
1027         WebKit Mac API should provide a delegate interface for global history.
1028         <rdar://problem/7042773> and https://webkit.org/b/29904
1029
1030         Adding the dumping of global history delegate callbacks.
1031
1032         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1033
1034         Automatically dump history delegate callbacks for tests with "globalhistory/" in their URL:
1035         * DumpRenderTree/mac/DumpRenderTree.mm:
1036         (createWebViewAndOffscreenWindow):
1037         (allocateGlobalControllers):
1038         (shouldLogFrameLoadDelegates):
1039         (shouldLogHistoryDelegates):
1040         (runTest):
1041
1042         Dump history delegate callbacks:
1043         * DumpRenderTree/mac/HistoryDelegate.h: Added.
1044         * DumpRenderTree/mac/HistoryDelegate.mm: Added.
1045         (-[HistoryDelegate webView:didNavigateWithNavigationData:inFrame:]):
1046         (-[HistoryDelegate webView:didPerformClientRedirectFromURL:toURL:inFrame:]):
1047         (-[HistoryDelegate webView:didPerformServerRedirectFromURL:toURL:inFrame:]):
1048
1049 2009-09-29  Daniel Bates  <dbates@webkit.org>
1050
1051         Reviewed by Adam Roben.
1052
1053         https://bugs.webkit.org/show_bug.cgi?id=28902
1054         
1055         Fixes an issue where the drop effect returned by Window Dump Render Tree 
1056         was always DROPEFFECT_NONE (since it was hard coded to do so).
1057         
1058         This patch corrects this issue by determining the actual drop effect 
1059         performed by the corresponding drag-and-drop operation so that we can 
1060         return it.
1061
1062         * DumpRenderTree/win/DraggingInfo.h: Added field m_dropEffect to store performed drop effect.
1063         (DraggingInfo::DraggingInfo):
1064         (DraggingInfo::performedDropEffect): Added method.
1065         (DraggingInfo::setPerformedDropEffect): Added method.
1066         * DumpRenderTree/win/EventSender.cpp:
1067         (doMouseUp): Calls method DraggingInfo::setPerformedDropEffect with performed drop effect.
1068         Moved delete draggingInfo to UIDelegate::doDragDrop.
1069         * DumpRenderTree/win/UIDelegate.cpp:
1070         (UIDelegate::doDragDrop): Sets performedDropEffect to DraggingInfo::performedDropEffect().
1071
1072 2009-09-29  Dan Bernstein  <mitz@apple.com>
1073
1074         Reviewed by Adam Roben.
1075
1076         Remove copying of unnecessary or nonexistent files from the ImageDiff
1077         post-build event.
1078
1079         * DumpRenderTree/win/ImageDiff.vcproj:
1080
1081 2009-09-29  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
1082
1083         Reviewed by David Kilzer.
1084
1085         [Qt] Make build-webkit script work on Windows
1086         https://bugs.webkit.org/show_bug.cgi?id=29802
1087
1088         * Scripts/run-webkit-tests:
1089         * Scripts/webkitdirs.pm:
1090          - Removed unnecessary -p switch for mkdir on Windows.
1091          - Use canonical path, which uses slashes or backslashes depends on platform.
1092          - isWindows() only test for Windows and not for Cyqwin.
1093
1094 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1095
1096         Reviewed by Simon Hausmann.
1097
1098         Fix time measurement in build-webkit after refactoring done in r48853.
1099
1100         * Scripts/build-webkit:
1101
1102 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1103
1104         Reviewed by Tor Arne Vestbø.
1105
1106         [Qt] Default font size reconciliation to 16px/13px to match other platform's de-facto standard.
1107         This fixes https://bugs.webkit.org/show_bug.cgi?id=19674.
1108
1109         * DumpRenderTree/qt/DumpRenderTree.cpp:
1110         (WebCore::WebPage::WebPage):
1111
1112 2009-09-29  Jakub Wieczorek  <faw217@gmail.com>
1113
1114         Reviewed by Simon Hausmann.
1115
1116         [Qt] Implement eventSender.contextClick().
1117         https://bugs.webkit.org/show_bug.cgi?id=29821
1118
1119         * DumpRenderTree/qt/jsobjects.cpp:
1120         (EventSender::contextClick):
1121         * DumpRenderTree/qt/jsobjects.h:
1122
1123 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
1124
1125         Reviewed by Eric Seidel.
1126
1127         Add experimentalWebSocketsEnabled in WebPreferences.
1128         https://bugs.webkit.org/show_bug.cgi?id=28941
1129
1130         * DumpRenderTree/mac/DumpRenderTree.mm:
1131         (resetDefaultsToConsistentValues):
1132         * DumpRenderTree/win/DumpRenderTree.cpp:
1133         (resetDefaultsToConsistentValues):
1134
1135 2009-09-28  Yaar Schnitman  <yaar@chromium.org>
1136
1137         Reviewed by David Kilzer.
1138
1139         Integrated chromium port building into webkit tools update-webkit and
1140         build-webkit.
1141
1142         https://bugs.webkit.org/show_bug.cgi?id=29749
1143
1144         * Scripts/build-webkit: When --chromium is specified, will build
1145           the chromium port (currently only Mac is supported).
1146         * Scripts/update-webkit: When --chromium is specified, delegates to
1147           update-webkit-chromium.
1148         * Scripts/webkitdirs.pm: Added chromium specific defs.
1149         * Scripts/update-webkit-chromium: Uses gclient and gyp to fetch
1150           chromium port's dependencies and update its project files.
1151
1152 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
1153
1154         Unreviewed.
1155
1156         Add myself to list of committers.
1157
1158         * Scripts/modules/committers.py:
1159
1160 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
1161
1162         Reviewed by Darin Adler.
1163
1164         run-webkit-tests: Do not strip the metrics when there is no expected result for a test.
1165         https://bugs.webkit.org/show_bug.cgi?id=29771
1166
1167         * Scripts/run-webkit-tests:
1168
1169 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
1170
1171         Reviewed by Simon Hausmann.
1172
1173         [Qt] Implement layoutTestController.waitForPolicyDelegate.
1174         https://bugs.webkit.org/show_bug.cgi?id=25037
1175
1176         * DumpRenderTree/qt/DumpRenderTree.cpp:
1177         (WebCore::WebPage::acceptNavigationRequest):
1178         * DumpRenderTree/qt/DumpRenderTree.pro:
1179         * DumpRenderTree/qt/jsobjects.cpp:
1180         (LayoutTestController::reset):
1181         (LayoutTestController::notifyDone):
1182         (LayoutTestController::waitForPolicyDelegate):
1183         * DumpRenderTree/qt/jsobjects.h:
1184         (LayoutTestController::waitForPolicy):
1185
1186 2009-09-26  David Kilzer  <ddkilzer@apple.com>
1187
1188         <http://webkit.org/b/29764> mark-bug-fixed: add -o|--open switch
1189
1190         Reviewed by Eric Seidel.
1191
1192         The -o|--open switch uses the open(1) command on Mac OS X to
1193         open the bug URL in the default web browser.  If there are
1194         similar mechanisms on other platforms, they may be added later.
1195
1196         * Scripts/mark-bug-fixed:
1197         (MarkBugFixed.__init__): Added -o|--open switch to list of parse
1198         options.
1199         (MarkBugFixed._determine_bug_id_and_svn_revision): Moved logging
1200         code into main() and extracted prompting code into
1201         _prompt_user_for_correctness().
1202         (MarkBugFixed._open_bug_in_web_browser): Added.
1203         (MarkBugFixed._prompt_user_for_correctness): Added.
1204         (MarkBugFixed.main): Added logging code from
1205         _determine_bug_id_and_svn_revision().  Added code to call
1206         _open_bug_in_web_browser() if the switch is set.  Added code to
1207         call _prompt_user_for_correctness() when needed.
1208         * Scripts/modules/bugzilla.py:
1209         (Bugzilla.short_bug_url_for_bug_id): Added.
1210
1211 2009-09-26  David Kilzer  <ddkilzer@apple.com>
1212
1213         svn-unapply and svn-apply don't work when used outside multiple svn working directories
1214
1215         <http://webkit.org/b/29744>
1216         <rdar://problem/7252905>
1217
1218         Reviewed by Eric Seidel.
1219
1220         Some users have a workflow where svn-create-patch, svn-apply and
1221         svn-unapply are used outside of multiple svn working
1222         directories.  Instead of aborting the scripts in these cases,
1223         print a warning and assume that Subversion is being used.
1224
1225         * Scripts/VCSUtils.pm:
1226         (determineVCSRoot): Call warn() instead of die() if both isGit()
1227         and isSVN() initially return false.  Set $VCSUtils::isSVN to 1
1228         to enforce the assumption about Subversion, then return
1229         determineSVNRoot().
1230         * Scripts/svn-apply: Switch to using isGit() and isSVN() from
1231         VCSUtils.pm.  They both already cache their values and checking
1232         here is redundant since determineVCSRoot() is called later.
1233
1234 2009-09-26  Zan Dobersek  <zandobersek@gmail.com>
1235
1236         Reviewed by Gustavo Noronha.
1237
1238         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
1239         https://bugs.webkit.org/show_bug.cgi?id=29689
1240
1241         Load test fonts through FontConfig before each test.
1242         This ensures a more proper rendering of the tests.
1243
1244         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1245         (initializeFonts):
1246         (runTest):
1247         (main):
1248         * DumpRenderTree/gtk/fonts.conf: Copied from WebKitTools/DumpRenderTree/qt/fonts.conf.
1249         * GNUmakefile.am:
1250
1251 2009-09-25  David Kilzer  <ddkilzer@apple.com>
1252
1253         <http://webkit.org/b/29718> mark-bug-fixed: add -u|--update-only switch
1254
1255         Reviewed by Eric Seidel.
1256
1257         * Scripts/mark-bug-fixed:
1258         (MarkBugFixed.__init__): Added -u|--update-only switch to list
1259         of parse options.
1260         (MarkBugFixed.main): When -u|--update-only is specified, add a
1261         comment to the bug without marking it Resolved/Fixed.
1262
1263 2009-09-25  Darin Adler  <darin@apple.com>
1264
1265         Reviewed by Geoffrey Garen.
1266
1267         * Scripts/prepare-ChangeLog: Leave files from the script-tests directory
1268         out, just as we do for the resources directory.
1269
1270 2009-09-25  Adam Barth  <abarth@webkit.org>
1271
1272         Unreviewed.  Added Tony to committers.py because he's a
1273         committer now.
1274
1275         * Scripts/modules/committers.py:
1276
1277 2009-09-25  Eric Seidel  <eric@webkit.org>
1278
1279         Reviewed by Simon Fraser.
1280
1281         REGRESSION: media/video-pause-empty-events.html is occasionally timing out on bots
1282         https://bugs.webkit.org/show_bug.cgi?id=28624
1283
1284         Disable hardware compositing on Leopard for versions of QuickTime 7.6.4 and older.
1285
1286         * DumpRenderTree/mac/DumpRenderTree.mm:
1287         (resetDefaultsToConsistentValues):
1288
1289 2009-09-25  Eric Seidel  <eric@webkit.org>
1290
1291         Reviewed by Adam Barth.
1292
1293         commit-queue should auto-retry patches which fail to commit due to out of date files
1294         https://bugs.webkit.org/show_bug.cgi?id=28316
1295
1296         * Scripts/bugzilla-tool:
1297          - Handle new CheckoutNeedsUpdate exception.
1298         * Scripts/modules/logging_unittest.py:
1299          - Call the ScriptError constructor correctly (this test had regressed).
1300         * Scripts/modules/scm.py:
1301          - Added the ability to define custom error handlers for run_command
1302            and added a commit_error_handler which throws CheckoutNeedsUpdate
1303            instead of ScriptError.
1304          - Re-ordered ScriptError constructor arguments to make ScriptError("message text") usage possible.
1305         * Scripts/modules/scm_unittest.py:
1306          - Added tests of new error handlers.
1307
1308 2009-09-25  Eric Seidel  <eric@webkit.org>
1309
1310         Reviewed by Adam Barth.
1311
1312         commit-queue should give better feedback when failing a patch
1313         https://bugs.webkit.org/show_bug.cgi?id=29316
1314
1315         * Scripts/bugzilla-tool:
1316          - Update ScriptError uses to the new constructor format.
1317          - Move CommitQueue._run_command to WebKitLandingScripts.run_command_with_teed_output
1318            so that we can print to both stdout as well as an output buffer for error reporting.
1319          - Update run_and_throw_if_fail to use teed output so that it can report the "output" as part of ScriptError.
1320          - Use e.message_with_output() when failing a patch (this is the real fix here).
1321            I also removed use of "This patch will require manual commit." as that's not always true.
1322          - Add missing word "bug" from log message.
1323         * Scripts/modules/scm.py:
1324          - Make ScriptError save a bunch more data so that error messages can be nicer.
1325          - Update ScriptError callers.
1326
1327 2009-09-24  John Gregg  <johnnyg@google.com>
1328
1329         Reviewed by Eric Seidel.
1330
1331         Enable switch for notifications (experimental) in Page Settings
1332         https://bugs.webkit.org/show_bug.cgi?id=28930
1333
1334         Now that desktop notifications are controlled by run-time switch,
1335         set that switch to true for DumpRenderTree.
1336
1337         * DumpRenderTree/mac/DumpRenderTree.mm:
1338         (resetDefaultsToConsistentValues):
1339         * DumpRenderTree/win/DumpRenderTree.cpp:
1340         (resetDefaultsToConsistentValues):
1341         * DumpRenderTree/win/UIDelegate.cpp:
1342         (UIDelegate::QueryInterface):
1343
1344 2009-09-24  Kevin Ollivier  <kevino@theolliviers.com>
1345
1346         wx build fix. SnowLeopard fixes for Mac dependencies.
1347
1348         * wx/build/build_utils.py:
1349         * wx/build/settings.py:
1350         * wx/install-unix-extras:
1351
1352 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1353
1354         Reviewed by Oliver Hunt.
1355
1356         Add support for DRT to send mouse wheel events.
1357
1358         https://bugs.webkit.org/show_bug.cgi?id=29348
1359         [Gtk] Scrollwheel on horizontal scrollbars should slide horizontally
1360
1361         * DumpRenderTree/gtk/EventSender.cpp:
1362         (mouseWheelToCallback):
1363
1364 2009-09-17  Eric Seidel  <eric@webkit.org>
1365
1366         Reviewed by David Levin.
1367
1368         commit-queue needs web-based status reporting
1369         https://bugs.webkit.org/show_bug.cgi?id=29307
1370
1371         Add a first-pass web-based status for the commit-queue.
1372         The bot is currently reachable at:
1373         http://webkit-commit-queue.appspot.com/
1374
1375         * CommitQueueStatus/app.yaml: Added.
1376          - Application description file required by App Engine.
1377         * CommitQueueStatus/filters/__init__.py: Added.
1378          - Required by python to treat 'filters' as a module.
1379         * CommitQueueStatus/filters/webkit_extras.py: Added.
1380          - Support for turning 'bug 123' and 'patch 123' into links.
1381            This lets us use plain text strings in our logs yet display nice HTML (help prevent XSS attacks on the page).
1382         * CommitQueueStatus/index.html: Added.
1383         * CommitQueueStatus/index.yaml: Added.
1384          - Some auto-generated file from app engine.
1385         * CommitQueueStatus/queue_status.py: Added.
1386          - The core logic of this bot.  We could eventually split this file out into pieces.
1387         * CommitQueueStatus/stylesheets/main.css: Added.
1388          - Some basic lame-o CSS to make the page look less awful.
1389         * CommitQueueStatus/update_status.html: Added.
1390          - The form that the commit-queue (or a human) can use to update the status.
1391         * Scripts/bugzilla-tool:
1392          - Add some very basic update_status calls.
1393         * Scripts/modules/statusbot.py: Added.
1394          - Knows how to post to the CommitQueueStatus web application.
1395
1396 2009-09-24  David Kilzer  <ddkilzer@apple.com>
1397
1398         <http://webkit.org/b/29712> mark-bug-fixed: add -m|--comment switch
1399
1400         Reviewed by Adam Roben.
1401
1402         * Scripts/mark-bug-fixed:
1403         (MarkBugFixed.__init__): Added -m|--comment switch to list of
1404         parse options.
1405         (MarkBugFixed.main): When specified, prepend comment from
1406         -m|--comment command-line switch to the bug comment.
1407
1408 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1409
1410         Reviewed by Jan Alonzo.
1411
1412         [GTK] DRT must display window instead of just realizing, to enable synthesizing events correctly
1413         https://bugs.webkit.org/show_bug.cgi?id=29693
1414
1415         Show the window, to be able to synthesize events correctly.
1416
1417         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1418         (runTest):
1419         (main):
1420
1421 2009-09-24  Oliver Hunt  <oliver@apple.com>
1422
1423         Reviewed by NOBODY(rollout)
1424
1425         Roll out r48712 as it is incorrect.
1426
1427         * DumpRenderTree/mac/ObjCController.m:
1428         (+[ObjCController isSelectorExcludedFromWebScript:]):
1429         (+[ObjCController webScriptNameForSelector:]):
1430
1431 2009-09-24  Benjamin Poulain  <benjamin.poulain@nokia.com>
1432
1433         Reviewed by Eric Seidel.
1434
1435         https://bugs.webkit.org/show_bug.cgi?id=29005
1436         The indices of RuntimeArray should be enumerated like for a regular array.
1437
1438         * DumpRenderTree/mac/ObjCController.m:
1439         (+[ObjCController isSelectorExcludedFromWebScript:]):
1440         (+[ObjCController webScriptNameForSelector:]):
1441         (-[ObjCController arrayOfString]):
1442
1443 2009-09-23  David Kilzer  <ddkilzer@apple.com>
1444
1445         <http://webkit.org/b/28910> Move bugzilla-tool mark-fixed to standalone mark-bug-fixed tool
1446
1447         Reviewed by Darin Adler.
1448
1449         Also fixed a bug where specifying a revision on the command-line
1450         as 'r12345' would fail.  See <http://webkit.org/b/29699>.
1451
1452         * Scripts/bugzilla-tool: Updated module import statements.
1453         (parse_bug_id): Removed.  Moved to bugzilla.py.
1454         (bug_comment_from_svn_revision): Removed.  Moved to comments.py.
1455         (bug_comment_from_commit_text): Removed.  Moved to comments.py.
1456         (MarkBugFixed): Removed.  Code moved to mark-bug-fixed.
1457         (BugzillaTool.__init__): Removed mark-fixed subcommand.
1458         * Scripts/mark-bug-fixed: Added.
1459         * Scripts/modules/bugzilla.py:
1460         (parse_bug_id): Added.  Moved from bugzilla-tool.
1461         * Scripts/modules/comments.py: Added.
1462         (bug_comment_from_svn_revision): Added.  Moved from bugzilla-tool.
1463         (bug_comment_from_commit_text): Added.  Moved from bugzilla-tool.
1464
1465 2009-09-23  Marshall Culpepper  <mculpepper@appcelerator.com>
1466
1467         Reviewed by Eric Seidel.
1468         
1469          jpeg.lib is now libjpeg.lib in DRT Cairo dependencies. return
1470          "false" in non-implemented stub for setAlwaysAcceptCookies.
1471          https://bugs.webkit.org/show_bug.cgi?id=29661
1472
1473         * DumpRenderTree/win/DumpRenderTree.vcproj:
1474         * DumpRenderTree/win/DumpRenderTree.cpp:
1475
1476 2009-09-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1477
1478         Reviewed by Xan Lopez.
1479
1480         [GTK] need to dump number of pending unload handlers
1481         https://bugs.webkit.org/show_bug.cgi?id=29685
1482
1483         Implement dumping of the number of pending unload handlers.
1484
1485         The following tests will pass:
1486
1487           fast/loader/unload-form-about-blank.html
1488           fast/loader/unload-form-post-about-blank.html
1489           fast/loader/unload-form-post.html
1490           fast/loader/unload-form.html
1491           fast/loader/unload-hyperlink.html
1492           fast/loader/unload-javascript-url.html
1493           fast/loader/unload-reload.html
1494           fast/loader/unload-window-location.html
1495
1496         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1497         (getFrameNameSuitableForTestResult):
1498         (webViewLoadFinished):
1499
1500 2009-09-22  Shinichiro Hamaji  <hamaji@chromium.org>
1501
1502         Reviewed by Eric Seidel.
1503
1504         js tests should move into jstests subdirectory instead of resources/
1505         https://bugs.webkit.org/show_bug.cgi?id=25880
1506
1507         Remove support of resources directory.
1508
1509         * Scripts/make-script-test-wrappers:
1510
1511 2009-09-22  Eric Seidel  <eric@webkit.org>
1512
1513         No review, only fixing typo (missing space character).
1514
1515         Fix typo from https://bugs.webkit.org/show_bug.cgi?id=29220
1516
1517         * Scripts/run-webkit-tests:
1518
1519 2009-09-22  Eric Seidel  <eric@webkit.org>
1520
1521         Reviewed by Darin Adler.
1522
1523         run-webkit-tests needs a --repeat-each=N option (AAABBBCCC instead of ABCABCABC)
1524         https://bugs.webkit.org/show_bug.cgi?id=29220
1525
1526         * Scripts/run-webkit-tests:
1527
1528 2009-09-22  Eric Seidel  <eric@webkit.org>
1529
1530         Reviewed by David Kilzer.
1531
1532         svn-apply can't handle single-line binary file additions
1533         https://bugs.webkit.org/show_bug.cgi?id=29100
1534
1535         Fixed the regexp and added a unit test.
1536
1537         * Scripts/modules/scm_unittest.py:
1538         * Scripts/svn-apply:
1539
1540 2009-09-11  Eric Seidel  <eric@webkit.org>
1541
1542         Reviewed by David Kilzer.
1543
1544         post-diff and post-commits should be able to find bug urls in ChangeLogs.
1545         https://bugs.webkit.org/show_bug.cgi?id=29206
1546
1547         * Scripts/bugzilla-tool:
1548          - Share common options by adding a PostDiffAsPatchToBug.posting_options() method.
1549          - Rename --no-comment to --add-log-as-comment and reverse behavior.
1550            Comments tend to just be noise.  I'll eventually remove this argument if no one uses it.
1551          - Split out code into helper functions to try and make execute() more legible.
1552          - Make post-diff find the bug url in the ChangeLogs if not passed as an argument.
1553          - Fallback to bug urls in commit diffs, instead of just in commit messages,
1554            meaning post-commits will now find bug urls in ChangeLogs.
1555
1556 2009-09-21  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
1557
1558         Reviewed by Maciej Stachowiak.
1559
1560         --parse-only parameter wasn't passed to SunSpider/sunspider script.
1561         https://bugs.webkit.org/show_bug.cgi?id=29611
1562
1563         * Scripts/run-sunspider: Missing parameter passing added.
1564
1565 2009-09-20  David Kilzer  <ddkilzer@apple.com>
1566
1567         <http://webkit.org/b/29521> run-webkit-tests: use require instead eval to load DumpRenderTreeSupport module
1568
1569         Reviewed by Mark Rowe.
1570
1571         The require statement is like the use statement, except that it
1572         is run during script execution instead of during the 'BEGIN'
1573         phase.  This makes it possible to change @INC before the require
1574         statement is run.  See 'require' and 'use' in the perlfunc(1)
1575         manpage and 'BEGIN' in perlmod(1) manpage.
1576
1577         * Scripts/run-webkit-tests: Replace eval statement with require
1578         statement.
1579
1580 2009-09-18  Kevin Ollivier  <kevino@theolliviers.com>
1581
1582         wx build fixes. Fix the config name under git and allow users to specify
1583         their own waf install for experimenting with new versions.
1584
1585         * Scripts/webkitdirs.pm:
1586         * wx/build/settings.py:
1587
1588 2009-09-18  Alex Milowski  <alex@milowski.com>
1589
1590         Reviewed by Maciej Stachowiak.
1591
1592         Added checkWebCoreMathMLSupport and hasMathMLSupport to support 
1593         checking for whether MathML tests should be run
1594
1595         * Scripts/run-webkit-tests:
1596         * Scripts/webkitdirs.pm:
1597
1598 2009-08-28  Darin Adler  <darin@apple.com>
1599
1600         Reviewed by Mark Rowe.
1601
1602         Break more of run-webkit-tests into separate functions
1603         https://bugs.webkit.org/show_bug.cgi?id=29497
1604
1605         Some small steps toward improving run-webkit-tests. My goal is to
1606         refactor much more of the script into functions. Later we can add
1607         parallel test running to the tool. But better structure may help
1608         even if someone decides to translate this into another scripting
1609         language instead.
1610
1611         * Scripts/run-webkit-tests: Break more pieces of the script into
1612         seprate functions. Added readSkippedFiles, findTestsToRun, and
1613         printResults functions. Removed custom code to skip results.html
1614         and instead just put it into the ignoredFiles hash. Fixed some
1615         indentation. Sorted function declarations, global variables,
1616         and options at the top of the file alphabetically so they're not
1617         in a semi-random order.
1618
1619 2009-09-17  Kevin Ollivier  <kevino@theolliviers.com>
1620
1621         wx build fix, add missing dependency.
1622
1623         * wx/browser/wscript:
1624
1625 2009-09-16  Mark Rowe  <mrowe@apple.com>
1626
1627         Split the SnowLeopard build across a few machines.
1628
1629         * BuildSlaveSupport/build.webkit.org-config/config.json:
1630
1631 2009-09-16  Kevin Ollivier  <kevino@theolliviers.com>
1632
1633         wx build fix to support monolithic builds on Windows.
1634
1635         * wx/build/wxpresets.py:
1636
1637 2009-09-16  Kevin Ollivier  <kevino@theolliviers.com>
1638
1639         wx build fix, improve debug support and 2.9 support on MSW.
1640
1641         * wx/build/settings.py:
1642         * wx/build/wxpresets.py:
1643
1644 2009-09-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1645
1646         Blind try at fixing new test failure on Windows.
1647
1648         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1649         (FrameLoadDelegate::didReceiveTitle):
1650
1651 2009-09-15  Alex Milowski  <alex@milowski.com>
1652
1653         Reviewed by Tor Arne Vestbø.
1654
1655         Added mathml toggle
1656
1657         * Scripts/build-webkit:
1658
1659 2009-09-15  Kevin Ollivier  <kevino@theolliviers.com>
1660
1661         wx build fix. Allow waf build to support Python < 2.6.
1662
1663         * wx/build/waf_extensions.py:
1664
1665 2009-09-14  Chris Marrin  <cmarrin@apple.com>
1666
1667         Reviewed by Oliver Hunt.
1668
1669         Add LayoutTests infrastructure to enable and disable webgl tests.
1670         https://bugs.webkit.org/show_bug.cgi?id=29254
1671
1672         * Scripts/run-webkit-tests:
1673         * Scripts/webkitdirs.pm:
1674
1675 2009-09-14  Simon Fraser  <simon.fraser@apple.com>
1676
1677         Reviewed by Darin Adler.
1678         
1679         Add --iterations option to run-webkit-tests to repeat the tests N times
1680         https://bugs.webkit.org/show_bug.cgi?id=29263
1681
1682         When run with --iterations N, run-webkit-tests will repeat the tests N times.
1683
1684         * Scripts/run-webkit-tests:
1685
1686 2009-09-14  Brady Eidson  <beidson@apple.com>
1687
1688         Not reviewed, maybe should've been:
1689
1690         Cleaning up more Windows-specific fallout from the fix for:
1691         <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160
1692
1693         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1694         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):  Correct printf() formatter, 
1695           and call the correct method to get the Sender.
1696
1697 2009-09-14  Jon Honeycutt  <jhoneycutt@apple.com>
1698
1699         GTK build fix.
1700
1701         Unreviewed.
1702
1703         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1704         (AccessibilityController::setLogScrollingStartEvents):
1705
1706 2009-09-11  Jon Honeycutt  <jhoneycutt@apple.com>
1707
1708         DRT/test part of
1709         <rdar://problem/7197644> WebKit should broadcast an MSAA event when
1710         jumping to a named anchor
1711
1712         https://bugs.webkit.org/show_bug.cgi?id=28899
1713
1714         Reviewed by Adam Roben.
1715
1716         * DumpRenderTree/AccessibilityController.cpp:
1717         (logScrollingStartEventsCallback):
1718         Turn on logging of scrolling start events.
1719         (AccessibilityController::getJSClass):
1720         Add a "logScrollingStartEvents" to the AccessibilityController's JS
1721         class definition.
1722         (AccessibilityController::resetToConsistentState):
1723         Turn off logging of scrolling start events.
1724
1725         * DumpRenderTree/AccessibilityController.h:
1726         Declare setLogScrollingStartEvents(). Add a member for the scrolling
1727         start event hook.
1728
1729         * DumpRenderTree/mac/AccessibilityControllerMac.cpp:
1730         (AccessibilityController::setLogScrollingStartEvents):
1731         Stubbed.
1732
1733         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1734         (AccessibilityController::AccessibilityController):
1735         Initialize the handle to 0.
1736         (logEventProc):
1737         Renamed from logFocusEventProc; now logs scrolling start events, too.
1738         Removed the assertion that the event is a focus event. Added a switch
1739         to print a message for focus, scrolling start, and other, unknown
1740         events.
1741         (AccessibilityController::setLogFocusEvents):
1742         Changed to use logEventProc.
1743         (AccessibilityController::setLogScrollingStartEvents):
1744         If turning logging off, unhook the scrolling start event hook, and clear
1745         the member holding the handle. If turning on, query for the root
1746         accessible, so that accessibility is enabled for the WebView, and call
1747         SetWinEventHook to setup an event hook using logEventProc as the
1748         callback function.
1749
1750 2009-09-14  Brady Eidson  <beidson@apple.com>
1751
1752         Windows build fix.
1753
1754         * DumpRenderTree/LayoutTestController.cpp:
1755         (setAuthenticationPasswordCallback):
1756         (setAuthenticationUsernameCallback):
1757         
1758         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1759         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
1760
1761 2009-09-14  Brady Eidson  <beidson@apple.com>
1762
1763         Reviewed by Alexey Proskuryakov.
1764
1765         Safari 4 cannot be used to update firmware on Linksys routers.
1766         <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160
1767
1768         Add the ability for DRT to handle authentication challenges.
1769
1770         * DumpRenderTree/LayoutTestController.cpp:
1771         (setAuthenticationPasswordCallback):
1772         (setAuthenticationUsernameCallback):
1773         (setHandlesAuthenticationChallengesCallback):
1774         (LayoutTestController::staticFunctions):
1775
1776         * DumpRenderTree/LayoutTestController.h:
1777         (LayoutTestController::handlesAuthenticationChallenges):
1778         (LayoutTestController::setHandlesAuthenticationChallenges):
1779         (LayoutTestController::authenticationUsername):
1780         (LayoutTestController::setAuthenticationUsername):
1781         (LayoutTestController::authenticationPassword):
1782         (LayoutTestController::setAuthenticationPassword):
1783
1784         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1785         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
1786
1787         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1788         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
1789         * DumpRenderTree/win/ResourceLoadDelegate.h:
1790
1791 2009-09-12  Mark Rowe  <mrowe@apple.com>
1792
1793         Reviewed by Dan Bernstein.
1794
1795         Test for <rdar://problem/6954546> and <rdar://problem/7090444>.
1796
1797         Add a flag on the test plug-in that asks it to clear the document during the call to NPP_New.
1798         This is the trigger for both <rdar://problem/6954546> and <rdar://problem/7090444>.
1799
1800         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1801         (NPP_New):
1802
1803 2009-09-14  Kevin Ollivier  <kevino@theolliviers.com>
1804
1805         wx build fix for non-wxPython builds and a fix for errors when updating swig.py.
1806
1807         * wx/build/build_utils.py:
1808         * wx/build/settings.py:
1809
1810 2009-09-14  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
1811
1812         Reviewed by Tor Arne Vestbø.
1813
1814         [Qt] Build fix for windows build.
1815
1816         * Scripts/bisect-builds: Add missing paranthesis for tmpdir function.
1817
1818 2009-09-13  Kevin Ollivier  <kevino@theolliviers.com>
1819
1820         Fix typo accidently landed in last commit.
1821
1822         * wx/build/settings.py:
1823
1824 2009-09-13  Kevin Ollivier  <kevino@theolliviers.com>
1825
1826         wx build fix, error out if using the wrong Python.
1827
1828         * wx/build/settings.py:
1829
1830 2009-09-13  Xan Lopez  <xlopez@igalia.com>
1831
1832         Build fix for GTK+ < 2.14.
1833
1834         Do not use gtk_widget_get_window, access the window directly
1835         through the struct.
1836
1837         * DumpRenderTree/gtk/EventSender.cpp:
1838         (contextClickCallback):
1839         (mouseDownCallback):
1840         (mouseUpCallback):
1841         (mouseMoveToCallback):
1842         (keyDownCallback):
1843
1844 2009-09-13  Martin Robinson  <martin.james.robinson@gmail.com>
1845
1846         Reviewed by Xan Lopez and Jan Alonzo.
1847
1848         [GTK] EventSender does not set 'window' property on synthesized GDK events
1849         https://bugs.webkit.org/show_bug.cgi?id=29169
1850
1851         Set the window property on synthesized GDK events in the GTK+ EventSender.
1852
1853         * DumpRenderTree/gtk/EventSender.cpp:
1854         (contextClickCallback):
1855         (mouseDownCallback):
1856         (mouseUpCallback):
1857         (mouseMoveToCallback):
1858         (keyDownCallback):
1859
1860 2009-09-12  Drew Wilson  <atwilson@google.com>
1861
1862         Reviewed by Mark Rowe.
1863
1864         run-webkit-tests has a timeout value that is too low
1865         https://bugs.webkit.org/show_bug.cgi?id=29223
1866
1867         * Scripts/run-webkit-tests:
1868         Changed timeout value to 20 seconds to avoid timing out too early.
1869
1870 2009-09-11  Kevin Ollivier  <kevino@theolliviers.com>
1871
1872         wx build fix. Mark dependencies as mandatory and declare which MSVC versions and
1873         architectures are supported for building wxWebKit.
1874
1875         * wx/build/settings.py:
1876
1877 2009-09-11  Eric Seidel  <eric@webkit.org>
1878
1879         Reviewed by David Levin.
1880
1881         bugzilla-tool rollout threw exception under svn
1882         https://bugs.webkit.org/show_bug.cgi?id=29211
1883
1884         * Scripts/modules/scm.py: add missing return, and convert number arguments to strings.
1885         * Scripts/modules/scm_unittest.py: add testing for this fix.
1886
1887 2009-09-11  Brian Weinstein  <bweinstein@apple.com>
1888
1889         Add myself to the committers list.
1890
1891         * Scripts/modules/committers.py:
1892
1893 2009-09-11  Eric Seidel  <eric@webkit.org>
1894
1895         Reviewed by Adam Barth.
1896
1897         bugzilla-tool land-patches should only fail-fast in --commit-queue mode
1898         https://bugs.webkit.org/show_bug.cgi?id=29201
1899
1900         * Scripts/bugzilla-tool:
1901
1902 2009-09-11  Adam Roben  <aroben@apple.com>
1903
1904         Make commit-log-editor move common prefixes to the top of the log
1905
1906         Fies <http://webkit.org/b/29190> commit-log-editor should move common
1907         prefixes to the top of the commit log
1908
1909         Reviewed by Darin Adler.
1910
1911         * Scripts/commit-log-editor: Find and remove the longest common prefix
1912         ending in a double newline from each ChangeLog entry, then put that
1913         common prefix at the top of the commit log.
1914         (removeLongestCommonPrefixEndingInDoubleNewline): Added. Finds,
1915         removes, and returns the longest common prefix ending in a double
1916         newline from a hash of strings
1917
1918 2009-09-11  Eric Seidel  <eric@webkit.org>
1919
1920         Fix obvious typo in previous commit, no review.
1921
1922         bugzilla-tool should automate rollouts
1923         https://bugs.webkit.org/show_bug.cgi?id=26715
1924
1925         * Scripts/bugzilla-tool: add back missing "scm" argument.
1926
1927 2009-09-11  Eric Seidel  <eric@webkit.org>
1928
1929         Reviewed by Adam Barth.
1930
1931         bugzilla-tool should automate rollouts
1932         https://bugs.webkit.org/show_bug.cgi?id=26715
1933
1934         bugzilla-tool rollout will do the rollout locally and leave the diff for you to verify and commit.
1935         The --complete-rollout option will automatically land and update the bug.
1936         Eventually --complete-rollout will be default, but that will require more testing.
1937
1938         This first pass is good enough for others to try and file bugs about.
1939
1940         * Scripts/bugzilla-tool:
1941          - Move modified_changelogs into scm.py.
1942          - Move svn_revision_from_commit_text logic into scm.py.
1943          - Add RolloutCommit command.
1944         * Scripts/modules/bugzilla.py:
1945          - Add reopen_bug command used by RolloutCommit.
1946         * Scripts/modules/scm.py:
1947          - Add functions to support RolloutCommit.
1948          - Abstract find_uuid into value_from_svn_info so it can be re-used for _repository_url (needed by svn merge).
1949          - Add a str() call so that svn_commit_log can take a numeric argument.
1950          - Remove a bunch of very slow code from last_svn_commit_log and used the built-in 'BASE' alias instead.
1951          - Made dry_run commits return something that svn_revision_from_commit_text can parse.
1952         * Scripts/modules/scm_unittest.py:
1953          - Add read_from_path for easy file reading.
1954          - Put test4 on a new line to make reverts work w/o conflict.
1955          - Add an "svn update" call so that the checkout revision matches the server revision.
1956          - Add tests for svn_revision_from_commit_text.
1957          - Add a simple test for apply_reverse_diff.
1958          - Add a new self.scm member and use it in the new tests (eventually other tests can use it too).
1959          - Add test for svn_commit_log to make sure my 'BASE' change above worked as expected.
1960
1961 2009-09-11  Adam Roben  <aroben@apple.com>
1962
1963         Get user script/stylesheet tests running on Windows
1964
1965         Fixes <http://webkit.org/b/29181> User script/stylesheet tests are
1966         skipped on Windows
1967
1968         Reviewed by John Sullivan.
1969
1970         * DumpRenderTree/win/DumpRenderTree.vcproj: Link all configurations
1971         against comsuppw.lib so we can use _bstr_t.
1972
1973         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Fixed #include
1974         order, added #include of comutil.h for _bstr_t.
1975
1976         (bstrT): Helper function to convert a JSStringRef to a _bstr_t.
1977         (LayoutTestController::addUserScript):
1978         (LayoutTestController::addUserStyleSheet):
1979         Implemented. Implementations were based on those in
1980         LayoutTestControllerMac.mm.
1981
1982 2009-09-10  David Kilzer  <ddkilzer@apple.com>
1983
1984         <http://webkit.org/b/29147> run-webkit-tests:  make -h show help 
1985
1986         Reviewed by Mark Rowe.
1987
1988         * Scripts/run-webkit-tests: Updated to make -h switch show help.
1989
1990 2009-09-10  Fumitoshi Ukai  <ukai@chromium.org>
1991
1992         Reviewed by Alexey Proskuryakov.
1993
1994         Add WebCore/websockets directory in wx build system.
1995         https://bugs.webkit.org/show_bug.cgi?id=28038
1996
1997         * wx/build/settings.py:
1998
1999 2009-09-10  Martin Robinson  <martin.james.robinson@gmail.com>
2000
2001         [GTK] EventSender does not properly convert some keyDown strings
2002         https://bugs.webkit.org/show_bug.cgi?id=29119
2003
2004         Add more keyDown string to character code conversions for GTK+ EventSender.
2005
2006         * DumpRenderTree/gtk/EventSender.cpp:
2007         (keyDownCallback):
2008
2009 2009-09-09  Steve Block  <steveblock@google.com>
2010
2011         Reviewed by Maciej Stachowiak.
2012
2013         Geolocation Coordinates::toString() prints bogus values for unspecified properties.
2014         https://bugs.webkit.org/show_bug.cgi?id=29080
2015
2016         * Scripts/make-script-test-wrappers: Modified. Adds asynchronous Geolocation tests to exclusion list.
2017
2018 2009-09-09  Eric Seidel  <eric@webkit.org>
2019
2020         Reviewed by Eric Carlson.
2021
2022         reviewer/committer lookups are backwards
2023         https://bugs.webkit.org/show_bug.cgi?id=29113
2024
2025         I also moved Eric Carlson from the committer list to the reviewer list now that he is one.
2026
2027         * Scripts/modules/bugzilla.py:
2028         * Scripts/modules/committers.py:
2029
2030 2009-09-09  Cameron McCormack  <cam@mcc.id.au>
2031
2032         Reviewed by Eric Seidel.
2033
2034         svn-unapply doesn't revert directories correctly
2035         https://bugs.webkit.org/show_bug.cgi?id=29065
2036
2037         * Scripts/svn-unapply: Make svnStatus consistently return status
2038         lines including a newline.
2039         * Scripts/svn-apply: Keep svnStatus in sync with the one in
2040         svn-unapply, in lieu of moving it to a common file.
2041
2042 2009-09-09  Cameron McCormack  <cam@mcc.id.au>
2043
2044         Reviewed by Eric Seidel.
2045
2046         svn-apply doesn't handle changes to files copied to new directories properly
2047         https://bugs.webkit.org/show_bug.cgi?id=29059
2048
2049         * Scripts/svn-apply: Don't treat "--- revision 0" patches as being
2050         additions if we know that we've just copied a file to this name.
2051
2052 2009-09-09  Eric Seidel  <eric@webkit.org>
2053
2054         Reviewed by David Levin.
2055
2056         commit-queue hangs if a builder has never built
2057         https://bugs.webkit.org/show_bug.cgi?id=29091
2058
2059         * Scripts/modules/buildbot.py:
2060         * Scripts/modules/buildbot_unittest.py:
2061
2062 2009-09-09  Zan Dobersek  <zandobersek@gmail.com>
2063
2064         Reviewed by Gustavo Noronha.
2065
2066         [GTK] DumpRenderTree needs eventSender object and implementation
2067         https://bugs.webkit.org/show_bug.cgi?id=25990
2068
2069         Implements most of the EventSender object's functionality for
2070         the DumpRenderTree tool. Implementation still lacks support
2071         for drag and drop tests and forward leaps.
2072
2073         Based on work by Holger Hans Peter Freyther.
2074
2075         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2076         (runTest): Focus on the view before loading a new test.
2077         (webViewWindowObjectCleared):
2078         * DumpRenderTree/gtk/EventSender.cpp: Added.
2079         (getDragModeCallback):
2080         (setDragModeCallback):
2081         (leapForwardCallback):
2082         (contextClickCallback):
2083         (updateClickCount):
2084         (mouseDownCallback):
2085         (mouseUpCallback):
2086         (mouseMoveToCallback):
2087         (beginDragWithFilesCallback):
2088         (replaySavedEvents):
2089         (keyDownCallback):
2090         (textZoomInCallback):
2091         (textZoomOutCallback):
2092         (zoomPageInCallback):
2093         (zoomPageOutCallback):
2094         (getClass):
2095         (makeEventSender):
2096         * DumpRenderTree/gtk/EventSender.h: Added.
2097         * GNUmakefile.am: Add build rules for EventSender.
2098
2099 2009-09-09  Daniel Bates  <dbates@webkit.org>
2100
2101         Reviewed by Adam Roben.
2102         
2103         https://bugs.webkit.org/show_bug.cgi?id=28953
2104
2105         Added pre- and post- build events so that on build failure, the file 
2106         buildfailed is written to the directory $(WebKitOutputDir).
2107
2108         * WinLauncher/WinLauncher.vcproj:
2109
2110 2009-09-09  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2111
2112         Unreviewed.
2113
2114         Add myself to list of committers.
2115
2116         * Scripts/modules/committers.py:
2117
2118 2009-09-08  Eric Seidel  <eric@webkit.org>
2119
2120         Reviewed by David Levin.
2121
2122         commit-queue gets stuck if a non-committer sets commit-queue+ or review+
2123         https://bugs.webkit.org/show_bug.cgi?id=28605
2124         https://bugs.webkit.org/show_bug.cgi?id=28916
2125
2126         * Scripts/bugzilla-tool:
2127          - Fix comment and adjust reject_patch_from_commit_queue call to pass "manual commit"
2128            comment now that it's used for rejecting patches for invalid committers too.
2129          - Pass reject_invalid_patches=True for commit-queue calls, normally we just ignore patches with invalid reviewers, the commit-queue rejects them.
2130          - Make the commit queue print patches count instead of bugs count, this also fixes https://bugs.webkit.org/show_bug.cgi?id=28916.
2131         * Scripts/modules/bugzilla.py:
2132          - Make _parse_attachment_element not validate reviewer/committer.
2133          - Share flag parsing code in _parse_attachment_flag.
2134          - Add _validate* methods for validating reviewers and committers and updating bugs when validation fails.
2135          - Add reject_invalid_patches argument so the commit-queue can update bugs on failed validation and other "read only" commands will not.
2136          - Add reject_patch_from_review_queue using a new _set_flag_on_attachment abstraction.
2137         * Scripts/modules/bugzilla_unittest.py:
2138          - Update this test to no longer expect committer/reviewer validation.
2139         * Scripts/modules/committers.py:
2140          - Return None on failed lookups instead of raising Exceptions.
2141         * Scripts/modules/committers_unittest.py:
2142          - Update tests to expect None returns instead of exceptions.
2143
2144 2009-09-09  David Kilzer  <ddkilzer@apple.com>
2145
2146         <http://webkit.org/b/29061> Fix obvious copy-paste error in AccessibilityUIElement::clickPointY()
2147
2148         Reviewed by Mark Rowe.
2149
2150         No change to layout test results.
2151
2152         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2153         (AccessibilityUIElement::clickPointY): Changed to return y value
2154         instead of x value.
2155
2156 2009-09-08  Dimitri Glazkov  <dglazkov@chromium.org>
2157
2158         Reviewed by Mark Rowe.
2159
2160         Reduce dglazkov's boboiness by properly concatenating revision value.
2161
2162         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Used substitution
2163             rather than "+".
2164
2165 2009-09-08  Kevin Ollivier  <kevino@theolliviers.com>
2166
2167         wxWebKit Python extension build fix - get swig.py if it doesn't exist.
2168
2169         * wx/build/build_utils.py:
2170
2171 2009-09-08  Mark Rowe  <mrowe@apple.com>
2172
2173         Fix an incorrect variable name in UpdateChromiumSource.
2174
2175         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2176
2177 2009-09-08  Mark Rowe  <mrowe@apple.com>
2178
2179         Don't check for leaks on the release SnowLeopard builder.
2180
2181         * BuildSlaveSupport/build.webkit.org-config/config.json:
2182
2183 2009-09-08  Mark Rowe  <mrowe@apple.com>
2184
2185         Add a SnowLeopard release builder.
2186
2187         * BuildSlaveSupport/build.webkit.org-config/config.json:
2188
2189 2009-09-08  David Levin  <levin@chromium.org>
2190
2191         Reviewed by Darin Adler.
2192
2193         Remove end of line whitespace check from check-webkit-style.
2194         https://bugs.webkit.org/show_bug.cgi?id=29053
2195
2196         * Scripts/modules/cpp_style.py:
2197
2198 2009-09-08  Cameron McCormack  <cam@mcc.id.au>
2199
2200         Reviewed by Darin Adler.
2201
2202         Fix DumpRenderTree build from clean tree on Tiger
2203         https://bugs.webkit.org/show_bug.cgi?id=28927
2204
2205         * DumpRenderTree/mac/PerlSupport/Makefile: Ensure the
2206         DerivedSources/DumpRenderTree directory exists when
2207         building on Tiger.
2208
2209 2009-09-08  Kevin Ollivier  <kevino@theolliviers.com>
2210
2211         wx build fix after introduction of platform/mock directory.
2212
2213         * wx/build/settings.py:
2214
2215 2009-09-08  Yael Aharon  <yael.aharon@nokia.com>
2216
2217         Unreviewed.
2218
2219         Add myself to list of committers.
2220
2221         * Scripts/modules/committers.py:
2222
2223 2009-09-08  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2224
2225         Unreviewed.
2226
2227         Add myself to list of committers.
2228
2229         * Scripts/modules/committers.py:
2230
2231 2009-09-08  Cameron McCormack  <cam@mcc.id.au>
2232
2233         Reviewed by Darin Adler.
2234
2235         prepare-ChangeLog too chatty on file additions
2236         https://bugs.webkit.org/show_bug.cgi?id=29019
2237
2238         * Scripts/prepare-ChangeLog: Omit description of added properties
2239         on newly added files.
2240
2241 2009-09-08  Steve Block  <steveblock@google.com>
2242
2243         Reviewed by Adam Barth.
2244
2245         Adds a LayoutTestController method to set the permission state for Geolocation.
2246         This is required to use the mock Geolocation service for testing.
2247         https://bugs.webkit.org/show_bug.cgi?id=29027
2248
2249         * DumpRenderTree/LayoutTestController.cpp: Modified.
2250         (setDatabaseQuotaCallback): Modified. Style fix.
2251         (setGeolocationPermissionCallback): Added. Sets the Geolocation permission state.
2252         (LayoutTestController::staticFunctions): Modified. Registers the above function on the LayoutTestController.
2253         * DumpRenderTree/LayoutTestController.h: Modified.
2254         (LayoutTestController::setGeolocationPermission): Added. Sets the Geolocation permission state.
2255         (LayoutTestController::isGeolocationPermissionSet): Added. Returns whether the Geolocation permission has been set.
2256         (LayoutTestController::geolocationPermission): Added. Returns the Geolocation permission state.
2257         * DumpRenderTree/mac/UIDelegate.mm: Modified.
2258         (-[UIDelegate webView:frame:requestGeolocationPermission:securityOrigin:]): Added. Implement chrome method to respond to request for Geolocation permission state. Response is made using above methods to access permission state.
2259
2260 2009-09-08  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2261
2262         Reviewed by Simon Hausmann.
2263
2264         [Qt] QtWebKit single API to enable persistency
2265         https://bugs.webkit.org/show_bug.cgi?id=28682
2266
2267         Use the new enablePersistentStorage API instead 
2268         of enabling all persistent features one-by-one.
2269
2270         * DumpRenderTree/qt/DumpRenderTree.cpp:
2271         (WebCore::WebPage::WebPage):
2272         (WebCore::DumpRenderTree::DumpRenderTree):
2273
2274 2009-09-07  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2275
2276         Reviewed by Tor Arne Vestbø.
2277
2278         Refactor --strict switch to --ignore-metrics and correct the
2279         implementation to make the feature usable on all platforms.
2280         https://bugs.webkit.org/show_bug.cgi?id=28907
2281
2282         run-webkit-tests --ignore-metrics strips the font related metrics from
2283         the actual and expected data before comparing them.
2284         In this way the render trees can be checked for obvious differences but
2285         a successful test implies by no means that the layout is actually correct.
2286
2287         * Scripts/run-webkit-tests:
2288
2289 2009-09-07  Steve Block  <steveblock@google.com>
2290
2291         Reviewed by Adam Barth.
2292
2293         Adds a mock Geolocation service. This will be used to provide predictable behavior of the
2294         Geolocation API for use in LayoutTests. Later changes will integrate the the mock
2295         Geolocation service with DumpRenderTree.
2296         https://bugs.webkit.org/show_bug.cgi?id=28264
2297
2298         * DumpRenderTree/LayoutTestController.cpp: Modified.
2299         (setMockGeolocationPositionCallback): Added. Configures the mock Geolocation service.
2300         (setMockGeolocationErrorCallback): Added. Configures the mock Geolocation service.
2301         (LayoutTestController::staticFunctions): Added. Registers the above functions on the LayoutTestController.
2302         * DumpRenderTree/LayoutTestController.h: Modified.
2303         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Modified.
2304         (LayoutTestController::setMockGeolocationPosition): Added. Configures the mock Geolocation service.
2305         (LayoutTestController::setMockGeolocationError): Added. Configures the mock Geolocation service.
2306
2307 2009-09-07  Drew Wilson  <atwilson@google.com>
2308
2309         Reviewed by David Levin.
2310
2311         Enable SHARED_WORKERS by default
2312         https://bugs.webkit.org/show_bug.cgi?id=28959
2313
2314         * Scripts/build-webkit:
2315
2316 2009-09-07  Kevin Ollivier  <kevino@theolliviers.com>
2317
2318         wx build fixes for wx SVN trunk.
2319
2320         * wx/build/settings.py:
2321
2322 2009-09-04  Kevin Ollivier  <kevino@theolliviers.com>
2323
2324         wx build fix. Switch USE_ defines over to the compiler so that they can be
2325         checked by files not including config.h (like WebCorePrefix.h).
2326
2327         * wx/build/settings.py:
2328
2329 2009-09-04  Adam Barth  <abarth@webkit.org>
2330
2331         Unreviewed build fix.
2332
2333         Update declaration of FrameLoadDelegate to reflect that
2334         IWebFrameLoadDelegatePrivate2 inherits from
2335         IWebFrameLoadDelegatePrivate.
2336
2337         * DumpRenderTree/win/FrameLoadDelegate.h:
2338
2339 2009-09-04  Adam Barth  <abarth@webkit.org>
2340
2341         Reviewed by Eric Seidel.
2342
2343         https://bugs.webkit.org/show_bug.cgi?id=24696
2344
2345         Add testing instrumentation for mixed content.
2346
2347         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2348         (-[FrameLoadDelegate webView:]):
2349         (-[FrameLoadDelegate webView:didRunInsecureContent:]):
2350         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2351         (descriptionSuitableForTestResult):
2352         (FrameLoadDelegate::QueryInterface):
2353         (FrameLoadDelegate::didDisplayInsecureContent):
2354         (FrameLoadDelegate::didRunInsecureContent):
2355         * DumpRenderTree/win/FrameLoadDelegate.h:
2356
2357 2009-09-03  Kevin Watters  <kevinwatters@gmail.com>
2358
2359         Reviewed by Kevin Ollivier.
2360
2361         [wx] Frames support
2362         https://bugs.webkit.org/show_bug.cgi?id=19041
2363
2364         * wx/build-wxwebkit:
2365
2366 2009-09-02  David Kilzer  <ddkilzer@apple.com>
2367
2368         <http://webkit.org/b/28880> svn-apply --force doesn't actually work
2369
2370         Reviewed by Eric Seidel.
2371
2372         This fixes "svn-apply --force" and adds unit tests for the
2373         scm.apply_patch() method which uses this script.
2374
2375         * Scripts/svn-apply: Created $globalExitCode variable that
2376         defaults to 0.  Exit with a value of $globalExitCode when the
2377         script is finished.
2378         (applyPatch): Ignore a non-zero $exitCode if $force is true, but
2379         set $globalExitCode to $exitCode so that svn-apply exits with a
2380         non-zero status if any patches did not apply cleanly.  Also
2381         print out the actual patch command if $force was not true.
2382
2383         * Scripts/modules/scm.py:
2384         (scripts_directory): Added.  Extracted from script_path().
2385         (script_path): Extracted scripts_directory().
2386         * Scripts/modules/scm_unittest.py: Import urllib.
2387         (SVNTestRepository.setup): Save the original working directory
2388         in test_object since this represents the WebKit repository from
2389         where the unit tests are run.
2390         (SCMTest): Created new super class to hold utility methods.
2391         (SCMTest._create_patch): Creates a patch file on disk and a
2392         dictionary for use with scm.svn_apply().
2393         (SCMTest._setup_webkittools_scripts_symlink): Sets up a symlink
2394         back to WebKitTools/Scripts in the test repository so that
2395         scm.apply_patch() is able to find the svn-apply script.
2396         (SVNTest): Inherit from SCMTest instead of unittest.TestCase.
2397         (SVNTest.tearDown): Make sure to change directories back to the
2398         original_path before the next test.
2399         (SVNTest.test_apply_svn_patch): New test case for applying an
2400         svn patch with scm.apply_patch().
2401         (SVNTest.test_apply_svn_patch_force): New test case for applying
2402         an svn patch with scm.apply_patch() that conflicts.
2403         (GitTest): Inherit from SCMTest instead of unittest.TestCase.
2404         (GitTest.tearDown): Make sure to change directories back to the
2405         original_path before the next test.
2406         (GitTest.test_apply_git_patch): New test case for applying a git
2407         patch with scm.apply_patch().
2408         (GitTest.test_apply_git_patch_force): New test case for applying
2409         a git patch with scm.apply_patch() that conflicts.
2410
2411 2009-09-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2412
2413         Reviewed by Mark Rowe.
2414
2415         [Qt] Add support for platform-spesific layout-test results
2416
2417         For the Qt port we use the qt-[mac|linux|win] directories and then fall
2418         back to the generic qt directory for both test results and skipped list.
2419
2420         * Scripts/run-webkit-tests:
2421         * Scripts/webkitdirs.pm:
2422
2423 2009-09-02  Laurent Cerveau  <lcerveau@me.com>
2424
2425         Reviewed by David Kilzer.
2426
2427         <http://webkit.org/b/25517> build-webkit script should print build time at end
2428
2429         * Scripts/build-webkit:
2430         Added startTime and endTime variable so that the build time is computed and printed as
2431         part of the build message; display formatting has been separated in a dedicated subroutine.
2432
2433 2009-09-02  David Kilzer  <ddkilzer@apple.com>
2434
2435         <http://webkit.org/b/28881> svn-create-patch should check if the repo path is the same when trying to find the root
2436
2437         Reviewed by Eric Seidel.
2438
2439         * Scripts/VCSUtils.pm:
2440         (determineSvnRoot): Added back check for repository root that
2441         was removed in r46134 when this code lived in svn-create-patch.
2442         It's necessary to check both the repository root and the
2443         repository UUID in case two different working directories are
2444         checked out from the same repository.
2445
2446 2009-09-02  Timothy Hatcher  <timothy@apple.com>
2447
2448         Use new 512x512 icons for nightly builds.
2449
2450         Rubber-stamped by Mark Rowe.
2451
2452         * WebKitLauncher/webkit.icns:
2453
2454 2009-09-02  Kevin Ollivier  <kevino@theolliviers.com>
2455
2456         waf build fix. Remove local variable shadowing global.
2457
2458         * wx/build/settings.py:
2459
2460 2009-09-02  Zan Dobersek  <zandobersek@gmail.com>
2461
2462         Reviewed by David Kilzer.
2463
2464         Calls exitStatus function from the main package where it is also defined.
2465
2466         * Scripts/VCSUtils.pm:
2467
2468 2009-09-02  Kevin Ollivier  <kevino@theolliviers.com>
2469
2470         waf build fixes for Windows/MSVC and Mac/Snow Leopard.
2471
2472         * wx/browser/wscript:
2473         * wx/build/build_utils.py:
2474         * wx/build/settings.py:
2475
2476 2009-08-10  Kevin Ollivier  <kevino@theolliviers.com>
2477
2478         Reviewed by Eric Seidel.
2479
2480         Changes needed for build-webkit to support the waf build system for the wx port.
2481         
2482         https://bugs.webkit.org/show_bug.cgi?id=27619
2483
2484         * Scripts/build-webkit:
2485         * Scripts/run-launcher:
2486         * Scripts/webkitdirs.pm:
2487
2488 2009-09-02  David Kilzer  <ddkilzer@apple.com>
2489
2490         <http://webkit.org/b/27168> With Subversion 1.6, update-webkit prompts on conflicts
2491
2492         Reviewed by Eric Seidel.
2493
2494         * Scripts/update-webkit: Added "--accept postpone" to
2495         @svnOptions when running with svn-1.6 or newer.
2496
2497 2009-09-02  David Kilzer  <ddkilzer@apple.com>
2498
2499         Moved svn 1.6 version check into VCSUtils::isSVNVersion16OrNewer()
2500
2501         Reviewed by Eric Seidel.
2502
2503         * Scripts/VCSUtils.pm:
2504         (@EXPORT): Added &isSVNVersion16OrNewer.
2505         (svnVersion): Added.  Internal method that gets the SVN version
2506         and caches it.
2507         (isSVNVersion16OrNewer): Added.  Method that does the SVN 1.6
2508         version check.
2509         * Scripts/prepare-ChangeLog: Switched to use new
2510         isSVNVersion16OrNewer() method.
2511         * Scripts/resolve-ChangeLogs: Ditto.
2512         * Scripts/svn-create-patch: Ditto.
2513
2514 2009-09-02  David Kilzer  <ddkilzer@apple.com>
2515
2516         Clean up VCSUtils.pm
2517
2518         Reviewed by Eric Seidel.
2519
2520         * Scripts/VCSUtils.pm: Added proper package statement.  Fixed
2521         indentation of BEGIN block.  Listed each exported method on a
2522         line by itself.  Added methods to the export list after adding
2523         the package statement.  Sorted module variables.  Moved
2524         definiton of $gitRoot next to other module variables.
2525
2526 2009-09-01  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2527
2528         Rubber-stamped by Simon Hausmann.
2529
2530         [Qt] Fix layout-test plugins/plugin-javascript-access.html
2531
2532         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2533
2534 2009-09-02  Shinichiro Hamaji  <hamaji@chromium.org>
2535
2536         Reviewed by Eric Seidel.
2537
2538         js tests should move into jstests subdirectory instead of resources/
2539         https://bugs.webkit.org/show_bug.cgi?id=25880
2540
2541         make-script-wrappers supports both resources and script-tests directories.
2542         run-webkit-tests ignores files in script-tests.
2543         Move script tests of animations to check the new script is working.
2544
2545         * Scripts/make-script-test-wrappers:
2546         * Scripts/run-webkit-tests:
2547
2548 2009-09-02  Szabo Carol  <carol.szabo@nokia.com>
2549
2550         Reviewed by David Levin.
2551
2552         check-webkit-style uses python from /usr/bin instead of the PATH
2553         https://bugs.webkit.org/show_bug.cgi?id=28225
2554
2555         * Scripts/bugzilla-tool:
2556         * Scripts/check-webkit-style:
2557         * Scripts/run-webkit-unittests:
2558         * Scripts/update-sources-list.py:
2559           Changed the first line from
2560           #!/usr/bin/python
2561           to
2562           #!/usr/bin/env python
2563           which causes python to be invoked from the path location returned
2564           by "which python" when any of these scripts are launched.
2565           these are currently all the python scripts in WebKitTools/Scripts.
2566
2567 2009-09-01  David Kilzer  <ddkilzer@apple.com>
2568
2569         <http://webkit.org/b/28601> bugzilla-tool post-commits posts commits backwards
2570
2571         Reviewed by Adam Barth.
2572
2573         * Scripts/modules/scm.py:
2574         (Git.commit_ids_from_commitish_arguments): Reverse the list of
2575         commits returned from git-rev-list since we always want to post
2576         the oldest patches first to bugs.webkit.org.
2577         * Scripts/modules/scm_unittest.py:
2578         (run): Added return statement to return the output now that we
2579         want it sometimes.
2580         (SVNTestRepository._setup_test_commits): Added a fourth commit
2581         so the GitTest.test_commitish_order() test has more commits to
2582         work with.
2583         (GitTest.test_commitish_order): Added unit test for change to
2584         Git.commit_ids_from_commitish_arguments() in scm.py.
2585
2586 2009-09-01  David Kilzer  <ddkilzer@apple.com>
2587
2588         <http://webkit.org/b/28877> Implement bugzilla-tool mark-fixed
2589
2590         Reviewed by David Levin.
2591
2592         The mark-fixed subcommand is for those times when you don't use
2593         bugzilla-tool to commit a patch, but you want to use it to close
2594         the bug with a committed-revision message.
2595
2596         * Scripts/bugzilla-tool:
2597         (bug_comment_from_svn_revision): Added.  Extracted from
2598         bug_comment_from_commit_text().
2599         (bug_comment_from_commit_text): Extracted
2600         bug_comment_from_svn_revision() from this method.
2601         (MarkBugFixed.__init__): Added.
2602         (MarkBugFixed._fetch_commit_log): Added.  Retrieves the commit
2603         log from the last commit if no svn revision is specified, else
2604         the commit log for the specified svn revision.
2605         (MarkBugFixed._determine_bug_id_and_svn_revision): Added.
2606         Attempts to determine the bug id and svn revision if one or both
2607         were not defined on the command line.
2608         (MarkBugFixed.execute): Added.  Adds a comment about the
2609         revision that fixed the bug and closes the bug.
2610         (BugzillaTool.__init__): Added mark-fixed subcommand.
2611         * Scripts/modules/bugzilla.py:
2612         (Bugzilla.fetch_title_from_bug): Added.  Returns the title of a
2613         bug given a bug id.
2614         * Scripts/modules/scm.py:
2615         (SCM.strip_r_from_svn_revision): Added.  Utility method to strip
2616         the leading 'r' from an svn revision.
2617         (SCM.svn_commit_log): Added.  Subclasses must override.
2618         (SCM.last_svn_commit_log): Added.  Subclasses must override.
2619         (SVN.svn_commit_log): Added.  Returns svn log for a given
2620         revision.
2621         (SVN.last_svn_commit_log): Added.  Uses svnversion to find the
2622         last commit in an svn working directory and then runs svn log.
2623         (Git.svn_commit_log): Added.  Returns svn log for a given
2624         revision.
2625         (Git.last_svn_commit_log): Added.  Runs git-svn-log with a limit
2626         of one log message.
2627
2628 2009-09-01  David Kilzer  <ddkilzer@apple.com>
2629
2630         <http://webkit.org/b/28880> svn-apply --force doesn't actually work
2631
2632         Reviewed by Brady Eidson.
2633
2634         * Scripts/svn-apply:
2635         (applyPatch): Add "--force" to $options arrayref if $force is
2636         set.
2637
2638 2009-09-01  David Kilzer  <ddkilzer@apple.com>
2639
2640         <http://webkit.org/b/28725> resolve-ChangeLogs: determineVCSRoot() returns incorrect repository root during git filter-branch
2641
2642         Reviewed by Adam Roben.
2643
2644         When git-filter-branch has been invoked to rewrite ChangeLog
2645         files on series of git commits, it changes directories into
2646         .git-rewrite/t before re-running resolve-ChangeLogs.  This
2647         causes determineVCSRoot() in VCSUtils.pm to return
2648         ".git-rewrite/t", which causes that path to be prepended to all
2649         ChangeLog paths, which results in an error like this:
2650
2651             error: pathspec '.git-rewrite/t/ChangeLog' did not match any file(s) known to git.
2652             Died at WebKitTools/Scripts/resolve-ChangeLogs line 376.
2653
2654         The correct way to fix this is not to try to find the repository
2655         root when invoked by git-filter-branch.
2656
2657         * Scripts/resolve-ChangeLogs: If isInGitFilterBranch() is true,
2658         set $relativePath to '.' instead of calling
2659         chdirReturningRelativePath(determineVCSRoot()).
2660         (isInGitFilterBranch): Added.  Checks for the existence of the
2661         MAPPED_PREVIOUS_COMMIT environment variable.
2662
2663 2009-09-01  Xan Lopez  <xlopez@igalia.com>
2664
2665         Reviewed by Gustavo Noronha.
2666
2667         Add support for Fedora distros in the http tests
2668         https://bugs.webkit.org/show_bug.cgi?id=28263
2669
2670         Add detection code for Fedora distribution, and use the proper
2671         httpd conf file when needed.
2672
2673         * Scripts/run-webkit-httpd:
2674         * Scripts/run-webkit-tests:
2675         * Scripts/webkitdirs.pm:
2676
2677 2009-09-01  Jan Michael Alonzo  <jmalonzo@webkit.org>
2678
2679         Reviewed by Eric Seidel.
2680
2681         [Gtk] DRT needs implementation of overridePreference
2682         https://bugs.webkit.org/show_bug.cgi?id=28830
2683
2684         Implement overridePreference.
2685
2686         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2687         (resetDefaultsToConsistentValues):
2688         (setDefaultsToConsistentStateValuesForTesting):
2689         (runTest):
2690         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2691         (toWebSettingKey):
2692         (LayoutTestController::overridePreference):
2693
2694 2009-09-01  Joseph Pecoraro  <joepeck@webkit.org>
2695
2696         <http://webkit.org/b/28623> svn-[un]apply should change directories to the repository root before [un]applying
2697
2698         Reviewed by Eric Seidel.
2699
2700         Jump back and forth between the repository root directory (to apply) and the
2701         directory the script was run from (to find the patch).
2702
2703         * Scripts/svn-apply:
2704         * Scripts/svn-unapply:
2705
2706 2009-08-31  Adam Roben  <aroben@apple.com>
2707
2708         Fall back to a Release version of Safari if a Debug one doesn't exist
2709
2710         <http://webkit.org/b/28849>
2711
2712         Reviewed by Sam Weinig.
2713
2714         * Scripts/webkitdirs.pm:
2715         (safariPath): If the user is working with a Debug build, but there's
2716         no Debug version of Safari present, fall back to using a Release
2717         version of Safari.
2718
2719 2009-08-31  Adam Roben  <aroben@apple.com>
2720
2721         Make safariPath() work for Debug builds of Safari on Windows
2722
2723         <http://webkit.org/b/28849>
2724
2725         Reviewed by Sam Weinig.
2726
2727         * Scripts/webkitdirs.pm:
2728         (safariPath): If the user is working with a Debug build, add the
2729         _debug suffix to Safari.exe.
2730
2731 2009-08-28  Eric Seidel  <eric@webkit.org>
2732
2733         Reviewed by Adam Barth.
2734
2735         commit-queue needs a master process
2736         https://bugs.webkit.org/show_bug.cgi?id=28040
2737
2738         Add a bugzilla-tool commit-queue command
2739         Keeps per-bug logs, but doesn't yet upload them anywhere.
2740
2741         * Scripts/bugzilla-tool: Add LandPatchesFromCommitQueue to handle 'commit-queue'
2742         * Scripts/modules/buildbot.py: remove noisy log message
2743         * Scripts/modules/logging.py: add a 'tee()' call for splitting outputs in python
2744
2745 2009-08-28  Jan Michael Alonzo  <jmalonzo@webkit.org>
2746
2747         Reviewed by Gustavo Noronha.
2748
2749         [GTK] Geolocation needs permission API before being enabled by default
2750
2751         Build the Gtk port with geolocation enabled. This option is only
2752         enabled for the buildbot. The autotools option will be enabled by
2753         default once the permissions API is implemented.
2754
2755         * Scripts/build-webkit:
2756
2757 2009-08-26  Cameron McCormack  <cam@mcc.id.au>
2758
2759         Reviewed by David Kilzer.
2760
2761         Make prepare-ChangeLog notice property changes
2762         https://bugs.webkit.org/show_bug.cgi?id=28675
2763
2764         Make the generated ChangeLog entry include a short description of
2765         property changes if there were such changes.  Also make
2766         prepare-ChangeLog not bail if the only changes are property changes.
2767
2768         * Scripts/prepare-ChangeLog:
2769
2770 2009-08-26  Adam Barth  <abarth@webkit.org>
2771
2772         Reviewed by Oliver Hunt.
2773
2774         Don't let local files access web URLs
2775         https://bugs.webkit.org/show_bug.cgi?id=28480
2776
2777         A bunch of our LayoutTests rely on our old behavior, so we explicitly
2778         grant local files universal access during testing.  Mainly, these tests
2779         involve making XMLHttpRequests for data URLs.
2780
2781         * DumpRenderTree/mac/DumpRenderTree.mm:
2782         (resetDefaultsToConsistentValues):
2783         * DumpRenderTree/qt/DumpRenderTree.cpp:
2784         (WebCore::WebPage::WebPage):
2785         * DumpRenderTree/win/DumpRenderTree.cpp:
2786         (resetDefaultsToConsistentValues):
2787
2788 2009-08-26  John Gregg  <johnnyg@google.com>
2789
2790         Reviewed by David Levin.
2791
2792         Minor style correction and include fix for notifications
2793         https://bugs.webkit.org/show_bug.cgi?id=28745
2794
2795         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2796           change to correct EnumStyle
2797         (DRTDesktopNotificationPresenter::checkNotificationPermission):
2798
2799 2009-08-26  David Levin  <levin@chromium.org>
2800
2801         Reviewed by Alexey Proskuryakov.
2802
2803         XMLHttpRequest.withCredentials=false shouldn't save cookies.
2804         https://bugs.webkit.org/show_bug.cgi?id=28743
2805
2806         Added the support to the layout test controller on OSX and
2807         Windows (for CFNETWORK) to allow for changing the accept cookie
2808         policy.
2809
2810         * DumpRenderTree/LayoutTestController.cpp:
2811         (LayoutTestController::LayoutTestController): Added a bool
2812         to track the state of accepting cookies.
2813         (setAlwaysAcceptCookiesCallback): Standard wrapper method
2814         to go from js to a C++ method.
2815         (LayoutTestController::staticFunctions): Added the
2816         setAlwaysAcceptCookies method to the js layoutTestController.
2817         * DumpRenderTree/LayoutTestController.h:
2818         (LayoutTestController::alwaysAcceptCookies): Returns the value.
2819         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2820         (LayoutTestController::setAlwaysAcceptCookies): Stub out method.
2821         * DumpRenderTree/mac/DumpRenderTree.mm:
2822         (resetDefaultsToConsistentValues): Reset the accept cookie to
2823         its default.
2824         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2825         (LayoutTestController::setAlwaysAcceptCookies): Does the work for
2826         OSX to change the cookie accept policy.
2827         * DumpRenderTree/win/DumpRenderTree.cpp:
2828         (setAlwaysAcceptCookies): Method to handle all the calls necessary
2829         to change the accept cookie policy on Windows.
2830         (resetDefaultsToConsistentValues): Reset the accept cookie to
2831         its default.
2832         * DumpRenderTree/win/DumpRenderTreeWin.h:
2833         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2834         (LayoutTestController::setAlwaysAcceptCookies): Stub out method.
2835         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2836         (LayoutTestController::setAlwaysAcceptCookies): Stub out method.
2837
2838 2009-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
2839
2840         Unreviewed.
2841
2842         Remove accidentally left in clobber option.
2843         https://bugs.webkit.org/show_bug.cgi?id=28400
2844
2845         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed clobber option.
2846
2847 2009-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
2848
2849         Reviewed by Mark Rowe.
2850
2851         Add canary-style Chromium WebKit build slave to the waterfall.
2852         https://bugs.webkit.org/show_bug.cgi?id=28400
2853
2854         * BuildSlaveSupport/build.webkit.org-config/config.json: Added one Chromium/Windows slave
2855         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added support for Chromium slave commands.
2856
2857 2009-08-25  Cameron McCormack  <cam@mcc.id.au>
2858
2859         Reviewed by Darin Adler.
2860
2861         make-script-test-wrappers should be executable
2862         https://bugs.webkit.org/show_bug.cgi?id=28669
2863
2864         Make make-script-test-wrappers and update-sources-list.py both be
2865         executable.
2866
2867         * Scripts/update-sources-list.py:
2868         * Scripts/make-script-test-wrappers:
2869
2870 2009-08-25  Brent Fulgham  <bfulgham@webkit.org>
2871
2872         Build fix
2873
2874         Revise Debug_Cairo targets to point inherit from the 
2875         debug_wincairo.vsprops property sheet so that they link
2876         against the proper libraries in Debug build.
2877
2878         * DumpRenderTree/win/DumpRenderTree.vcproj:
2879         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2880         * WinLauncher/WinLauncher.vcproj:
2881
2882 2009-08-25  David Levin  <levin@chromium.org>
2883
2884         Reviewed by Adam Roben.
2885
2886         PLATFORM(CFNETWORK) should be USE(CFNETWORK).
2887         https://bugs.webkit.org/show_bug.cgi?id=28713
2888
2889         * DumpRenderTree/win/DumpRenderTree.cpp:
2890         (main):
2891
2892 2009-08-25  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2893
2894         Reviewed by Ariya Hidayat.
2895
2896         [Qt/Mac] Use CONFIG+=build_all only when building libraries
2897
2898         If no configuration is specified when building WebKit we pass the
2899         debug_and_release option to QMake which results in Makefiles for
2900         both configurations being generated.
2901
2902         Previously we built both of these configurations by default, for
2903         all targets (both the QtWebKit framework/dyldlib and the various
2904         executables such as QtLauncher and tests). This makes sense for
2905         the libraries, which get the _debug suffix and can be loaded on
2906         demand by setting the DYLD_IMAGE_SUFFIX, but for executables we
2907         ended up building the same executable twice.
2908
2909         We now only build one instance of each executable, and since this
2910         is a developer build we build the debug-version. Passing either
2911         --debug or --release to build-webkit will override this, and
2912         even in the default case the release version can still be built
2913         by running 'make release' in the the build directory of each
2914         target.
2915
2916         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2917         * Scripts/webkitdirs.pm:
2918
2919 2009-08-24  Hironori Bono  <hbono@chromium.org>
2920
2921         Reviewed by Adam Barth.
2922
2923         Fix Bug 27827 "[Chromium] Functions Keys don't work in google spreadsheet".
2924         <https://bugs.webkit.org/show_bug.cgi?id=27827>.
2925
2926         Because of the lack of mappings from GDK key-codes to WebKit key-codes,
2927         Chromium cannot send valid key-codes to JavaScript when a user types
2928         function keys. This change just copies the mappings from 'KeyEventGtk.cpp'.
2929
2930         To write layout tests for this issue, added mappings from function-key
2931         names to platform-specific key-codes to EventSendingController objects
2932         so that eventSender.keyDown() can send function-key events without using
2933         platform-specific key codes. (Unfortunately, this eventSender.keyDown() change
2934         is only for Mac. So this change adds this new test to Skipped tests for other
2935         platforms to prevent this change from crashing the build trees.)
2936
2937         * DumpRenderTree/mac/EventSendingController.mm:
2938         (-[EventSendingController keyDown:withModifiers:]):
2939
2940 2009-08-23  Jan Michael Alonzo  <jmalonzo@webkit.org>
2941
2942         Reviewed by Xan Lopez.
2943
2944         [Gtk] API for disabling local file access to web URLs
2945         https://bugs.webkit.org/show_bug.cgi?id=28663
2946
2947         Enable this setting for DRT.
2948
2949         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2950         (resetWebViewToConsistentStateBeforeTesting):
2951
2952 2009-08-22  Adam Barth  <abarth@webkit.org>
2953
2954         Revert 47684.  We're going to do this later once clients have had a
2955         chance to opt into the setting they like.
2956
2957         * DumpRenderTree/mac/DumpRenderTree.mm:
2958         (resetDefaultsToConsistentValues):
2959         * DumpRenderTree/qt/DumpRenderTree.cpp:
2960         (WebCore::WebPage::WebPage):
2961         * DumpRenderTree/win/DumpRenderTree.cpp:
2962         (resetDefaultsToConsistentValues):
2963
2964 2009-08-22  Adam Barth  <abarth@webkit.org>
2965
2966         Reviewed by Eric Seidel.
2967
2968         Don't let local files access web URLs
2969         https://bugs.webkit.org/show_bug.cgi?id=28480
2970
2971         A bunch of our LayoutTests rely on our old behavior, so we explicitly
2972         grant local files universal access during testing.  Mainly, these tests
2973         involve making XMLHttpRequests for data URLs.
2974
2975         * DumpRenderTree/mac/DumpRenderTree.mm:
2976         (resetDefaultsToConsistentValues):
2977         * DumpRenderTree/qt/DumpRenderTree.cpp:
2978         (WebCore::WebPage::WebPage):
2979         * DumpRenderTree/win/DumpRenderTree.cpp:
2980         (resetDefaultsToConsistentValues):
2981
2982 2009-08-22  Mark Rowe  <mrowe@apple.com>
2983
2984         Rubber-stamped by Anders Carlsson.
2985
2986         Bring signed updates to the Mac nightly builds.
2987
2988         * WebKitLauncher/Info.plist:
2989         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2990         * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
2991         (initializeSparkle):
2992         * WebKitLauncher/nightly.webkit.org.public.pem: Added.
2993
2994 2009-08-21  Jan Michael Alonzo  <jmalonzo@webkit.org>
2995
2996         Rubberstamped by Simon Fraser.
2997
2998         Remove GNOME keyring support in build-webkit. This dependency's
2999         already been removed in the Gtk port.
3000
3001         * Scripts/build-webkit:
3002
3003 2009-08-20  Brian Weinstein  <bweinstein@apple.com>
3004
3005         Reviewed by Adam Roben.
3006         Based on original patch by Stephanie Lewis.
3007
3008         Added support of the Windows malloc history format to parse-malloc history, so we can
3009         read and parse it.
3010
3011         * Scripts/parse-malloc-history:
3012
3013 2009-08-20  Chris Fleizach  <cfleizach@apple.com>
3014
3015         Reviewed by Darin Adler.
3016
3017         Enable various "grouping" ARIA roles
3018         https://bugs.webkit.org/show_bug.cgi?id=28486
3019
3020         Expose the ability to retrieve the subrole through accessibility for DRT.
3021
3022         * DumpRenderTree/AccessibilityUIElement.cpp:
3023         * DumpRenderTree/AccessibilityUIElement.h:
3024         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3025         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3026         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3027
3028 2009-08-20  Joseph Pecoraro  <joepeck@webkit.org>
3029
3030         Unreviewed.
3031
3032         Added myself as a committer.
3033
3034         * Scripts/modules/committers.py:
3035
3036 2009-08-20  Xan Lopez  <xlopez@igalia.com>
3037
3038         Reviewed by Gustavo Noronha.
3039
3040         Fix memory leaks.
3041
3042         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3043         (LayoutTestController::whiteListAccessFromOrigin):
3044         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
3045         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
3046
3047 2009-08-20  Eric Seidel  <eric@webkit.org>
3048
3049         Reviewed by Adam Barth.
3050
3051         bugzilla-tool post-diff can post partial diffs from SVN checkouts.
3052         https://bugs.webkit.org/show_bug.cgi?id=28445
3053
3054         Pass the checkout root as the cwd.  Also wrote a test to ensure this.
3055
3056         * Scripts/modules/scm.py:
3057         * Scripts/modules/scm_unittest.py:
3058
3059 2009-08-20  Mark Rowe  <mrowe@apple.com>
3060
3061         Reviewed by Adele Peterson.
3062
3063         Don't leak the JSStringRef returned by AccessibilityUIElement::attributeValue.
3064
3065         * DumpRenderTree/AccessibilityUIElement.cpp:
3066         (attributeValueCallback):
3067
3068 2009-08-20  Ariya Hidayat  <ariya.hidayat@nokia.com>
3069
3070         Unreviewed, build fix.
3071
3072         [Qt] The template-based qMax() compares two qreals.
3073
3074         * DumpRenderTree/qt/ImageDiff.cpp:
3075         (main):
3076
3077 2009-08-20  David Levin  <levin@chromium.org>
3078
3079         Reviewed by David Kilzer.
3080
3081         bugzilla-tool patch retrieval should handle 302 redirects.
3082         https://bugs.webkit.org/show_bug.cgi?id=28485
3083
3084         * Scripts/modules/scm.py: Pass the --location parameter to curl
3085         so that 302's are followed.
3086
3087 2009-08-20  Aaron Boodman  <aa@chromium.org>
3088
3089         One more speculative build for gtk.
3090
3091         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3092
3093 2009-08-20  Aaron Boodman  <aa@chromium.org>
3094
3095         Speculative build for gtk.
3096
3097         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3098         (LayoutTestController::whiteListAccessFromOrigin):
3099
3100 2009-08-20  Mark Rowe  <mrowe@apple.com>
3101
3102         Ignore some leaks that are known to originate from ImageIO.
3103
3104         * Scripts/run-webkit-tests:
3105
3106 2009-08-20  Aaron Boodman  <aa@chromium.org>
3107
3108         With David Levin.
3109
3110         Speculative build fix for qt.
3111
3112         * DumpRenderTree/qt/jsobjects.cpp:
3113         (LayoutTestController::whiteListAccessFromOrigin):
3114         * DumpRenderTree/qt/jsobjects.h:
3115
3116 2009-08-19  Mark Rowe  <mrowe@apple.com>
3117
3118         Reviewed by Dan Bernstein.
3119
3120         Fix <http://webkit.org/b/28484> Plug-in-related leaks seen on the build bot
3121
3122         Update check-for-global-initializers to accommodate the new uses of RefCountedLeakCounter in WebKit.
3123
3124         * Scripts/check-for-global-initializers:
3125
3126 2009-08-19  Aaron Boodman  <aa@chromium.org>
3127
3128         Reviewed by David Levin.
3129
3130         https://bugs.webkit.org/show_bug.cgi?id=24853: Provide a way for WebKit clients to
3131         specify a more granular policy for cross-origin XHR access.
3132
3133         * DumpRenderTree/LayoutTestController.cpp: Expose whiteListAccessFromOrigin() to layout tests.
3134         (whiteListAccessFromOriginCallback): Ditto.
3135         (LayoutTestController::staticFunctions): Ditto.
3136         * DumpRenderTree/LayoutTestController.h: Ditto.
3137         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Ditto.
3138         (LayoutTestController::whiteListAccessToOrigin): Ditto.
3139         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Ditto.
3140         (LayoutTestController::whiteListAccessFromOrigin): Ditto.
3141         * DumpRenderTree/qt/jsobjects.cpp: Ditto.
3142         (LayoutTestController::whiteListAccessFromOrigin): Ditto.
3143         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Stub out whiteListAccessFromOrigin().
3144         (LayoutTestController::whiteListAccessFromOrigin): Ditto.
3145         * DumpRenderTree/gtk/DumpRenderTree.cpp: Reset origin access lists before each test.
3146         (resetWebViewToConsistentStateBeforeTesting): Ditto.
3147         * DumpRenderTree/mac/DumpRenderTree.mm: Ditto.
3148         (resetWebViewToConsistentStateBeforeTesting): Ditto.
3149         * DumpRenderTree/qt/DumpRenderTree.cpp: Ditto.
3150         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Ditto.
3151
3152 2009-08-19  Mark Rowe  <mrowe@apple.com>
3153
3154         Rubber-stamped by Dan Bernstein.
3155
3156         Ignore some leaks that are known to originate from QTKit.
3157
3158         * Scripts/run-webkit-tests:
3159
3160 2009-08-19  Eric Seidel  <eric@webkit.org>
3161
3162         Reviewed by Adam Barth.
3163
3164         commit-queue/bugzilla-tool can get wedged if git is mid-rebase
3165         https://bugs.webkit.org/show_bug.cgi?id=28436
3166
3167         Make clean_working_directory cancel rebases too (even though that's a bit of a hack).
3168         This code will only ever be run when --force-clean is passed.
3169
3170         I also added a new unit test to make sure this code actually works. :)
3171
3172         * Scripts/modules/scm.py:
3173         * Scripts/modules/scm_unittest.py:
3174
3175 2009-08-19  Eric Seidel  <eric@webkit.org>
3176
3177         Reviewed by David Levin.
3178
3179         WebKit needs a changelogs.py to hold changelog-related code
3180         https://bugs.webkit.org/show_bug.cgi?id=28477
3181
3182         This is moving code and adding tests.  There was only one functional
3183         change (which was removing a trailing newline from the last_entry() result).
3184
3185         * Scripts/bugzilla-tool:
3186         * Scripts/modules/changelogs.py: Added.
3187         * Scripts/modules/changelogs_unittest.py: Added.
3188         * Scripts/run-webkit-unittests:
3189
3190 2009-08-20  Eric Seidel  <eric@webkit.org>
3191
3192         Reviewed by Adam Barth.
3193
3194         bugzilla-tool needs a way to ask build.webkit.org if the bots are passing
3195         https://bugs.webkit.org/show_bug.cgi?id=28222
3196
3197         Basic support for now.  This has been in testing for 24 hours now and worked great!
3198
3199         * Scripts/bugzilla-tool:
3200         * Scripts/modules/buildbot.py: Added.
3201         * Scripts/modules/buildbot_unittest.py: Added.
3202         * Scripts/run-webkit-unittests:
3203
3204 2009-08-19  Jan Michael Alonzo  <jmalonzo@webkit.org>
3205
3206         Reviewed by Gustavo Noronha.
3207
3208         [Gtk] Bump waitToDumpWatchdog interval to 15 seconds to match the
3209         default timeout used by run-webkit-tests. Mac and Win ports were
3210         recently bumped in http://trac.webkit.org/changeset/r47465.
3211
3212         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3213         (LayoutTestController::setWaitToDump):
3214
3215 2009-08-19  David D. Kilzer  <ddkilzer@webkit.org>
3216
3217         DumpRenderTreeSupport.pm: provide pre-generated swig source for Tiger
3218
3219         Reviewed by Mark Rowe.
3220
3221         Provide pre-generated swig source files for Tiger so it may
3222         benefit from the faster run-webkit-tests.
3223
3224         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm:
3225         Generated by swig.
3226         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapTiger.c: Added.
3227         Generated by swig.
3228         (swig_type_info::SWIG_TypeNameComp):
3229         (swig_type_info::SWIG_TypeEquiv):
3230         (swig_type_info::SWIG_TypeRegisterTL):
3231         (swig_type_info::SWIG_TypeCheck):
3232         (swig_type_info::SWIG_TypeCast):
3233         (swig_type_info::SWIG_TypeDynamicCast):
3234         (swig_type_info::SWIG_TypeName):
3235         (swig_type_info::SWIG_TypePrettyName):
3236         (swig_type_info::SWIG_TypeQueryTL):
3237         (swig_type_info::SWIG_TypeClientDataTL):
3238         (swig_type_info::SWIG_PackData):
3239         (swig_type_info::SWIG_UnpackData):
3240         (swig_type_info::SWIG_PropagateClientDataTL):
3241         (swig_type_info::SWIG_PackVoidPtr):
3242         (swig_type_info::SWIG_UnpackVoidPtr):
3243         (swig_type_info::SWIG_PackDataName):
3244         (swig_type_info::SWIG_UnpackDataName):
3245         * DumpRenderTree/mac/PerlSupport/Makefile: Updated to build on
3246         Tiger using pre-generated files.
3247
3248 2009-08-18  Shinichiro Hamaji  <hamaji@chromium.org>
3249
3250         Reviewed by David Kilzer.
3251
3252         run-webkit-tests hangs when WebCore tries to log too much
3253         https://bugs.webkit.org/show_bug.cgi?id=15743
3254
3255         Read stdout and stderr in parallel.
3256
3257         * Scripts/run-webkit-tests:
3258
3259 2009-08-18  Mark Rowe  <mrowe@apple.com>
3260
3261         Rubber-stamped by Oliver Hunt.
3262
3263         Add a new build configuration that checks for leaks during the layout tests,
3264         and hook a new machine up to it.
3265
3266         * BuildSlaveSupport/build.webkit.org-config/config.json:
3267         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3268
3269 2009-08-18  Aaron Boodman  <aa@chromium.org>
3270
3271         Reviewed by Maciej Stachowiak.
3272
3273         https://bugs.webkit.org/show_bug.cgi?id=28412: Leak of WebCore::XMLHttpRequest object during layout tests.
3274
3275         No new tests: Already covered by existing tests.
3276
3277         * Scripts/check-for-global-initializers: Allow global initialization of WTF::RefCountedLeakCounter for XMLHttpRequest.
3278
3279 2009-08-18  Mark Rowe  <mrowe@apple.com>
3280
3281         Rubber-stamped by Geoff Garen.
3282
3283         Bump waitToDumpWatchdogInterval to 15 seconds to match the time-out used by run-webkit-tests.
3284
3285         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3286         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3287
3288 2009-08-18  Brian Weinstein  <bweinstein@apple.com>
3289
3290         Rubber-stamped by Adam Roben.
3291
3292         Changed use of CComBSTR in exceededDatabaseQuota to BSTRs, and free them,
3293         and removed include to fix building on VC++ Express.
3294
3295         * DumpRenderTree/win/UIDelegate.cpp:
3296         (UIDelegate::exceededDatabaseQuota):
3297
3298 2009-08-18  Brian Weinstein  <bweinstein@apple.com>
3299
3300         Reviewed by Oliver Hunt.
3301
3302         Fix of <https://bugs.webkit.org/show_bug.cgi?id=28326> DRT on Windows doesn't support 
3303         LayoutTestController::setQuota or print a callback on UIDelegate::exceededDatabaseQuota.
3304         
3305         Implemenent setDatabaseQuota and added a new function to the IWebDatabaseManager interface.
3306         Also added a console output on UIDelegate::exceededDatabaseQuota to match the mac.
3307
3308         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3309         (LayoutTestController::setDatabaseQuota):
3310         * DumpRenderTree/win/UIDelegate.cpp:
3311         (UIDelegate::exceededDatabaseQuota):
3312
3313 2009-08-18  Peter Kasting  <pkasting@google.com>
3314
3315         Reviewed by Eric Seidel.
3316
3317         https://bugs.webkit.org/show_bug.cgi?id=28415
3318         Set svn:eol-style CRLF on all .sln and .vcproj files that don't already
3319         have it.
3320
3321         * record-memory-win/record-memory-win.vcproj:
3322         * WinLauncher/WinLauncher.vcproj:
3323         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3324         * DumpRenderTree/win/ImageDiff.vcproj:
3325         * FindSafari/FindSafari.vcproj:
3326
3327 2009-08-18  Drew Wilson  <atwilson@google.com>
3328
3329         Reviewed by Eric Seidel.
3330
3331         Need to extend DumpRenderTree to expose number of worker threads
3332         https://bugs.webkit.org/show_bug.cgi?id=28292
3333
3334         Added layoutTestController.workerThreadCount, and implementations on various platforms that call into WebKit.
3335
3336         * DumpRenderTree/LayoutTestController.cpp:
3337         (getWorkerThreadCountCallback):
3338         (LayoutTestController::staticValues):
3339         * DumpRenderTree/LayoutTestController.h:
3340         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3341         (LayoutTestController::workerThreadCount):
3342         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3343         (LayoutTestController::workerThreadCount):
3344         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3345         (LayoutTestController::workerThreadCount):
3346         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3347         (LayoutTestController::workerThreadCount):
3348
3349 2009-08-18  Xan Lopez  <xlopez@igalia.com>
3350
3351         Reviewed by Jan Alonzo.
3352
3353         Initialize x and y in the GtkAllocation structure to shut up
3354         valgrind.
3355
3356         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3357         (runTest):
3358
3359 2009-08-17  Shinichiro Hamaji  <hamaji@chromium.org>
3360
3361         Reviewed by Darin Adler.
3362
3363         Some HTMLs are modified by make-script-test-wrappers
3364         https://bugs.webkit.org/show_bug.cgi?id=28213
3365
3366         Add fast/js/const.js and fast/canvas/canvas-2d-imageData-create-nonfinite.js into
3367         the exclude list, modified fast/dom/Geolocation/resources/TEMPLATE.html, and
3368         re-generated wml/* and Geolocation/* .
3369
3370         * Scripts/make-script-test-wrappers:
3371
3372 2009-08-17  Shinichiro Hamaji  <hamaji@chromium.org>
3373
3374         Reviewed by Eric Seidel.
3375
3376         -webkit-box-orient:horizontal doesn't work on <button> tag
3377         https://bugs.webkit.org/show_bug.cgi?id=34445
3378
3379         Make a flexible button's anonymous child flexible and pass the
3380         parent's box-orient to the anonymous child.
3381
3382         Also, added a renderName for anonymous flexible boxes.
3383
3384         * Scripts/make-script-test-wrappers:
3385
3386 2009-08-17  Eric Seidel  <eric@webkit.org>
3387
3388         Reviewed by Darin Adler.
3389
3390         Can no longer --reset-results of a layout test directory
3391         https://bugs.webkit.org/show_bug.cgi?id=28336
3392
3393         --reset-results and --exit-after-n-failures are incompatible.
3394
3395         * Scripts/run-webkit-tests:
3396
3397 2009-08-17  David Kilzer  <ddkilzer@apple.com>
3398
3399         <http://webkit.org/b/26920> bugzilla-tool dumps too much junk the the commit comment from git
3400
3401         Reviewed by Adam Roben.
3402
3403         New commit message:
3404             Committed r12345: <http://trac.webkit.org/changeset/12345>
3405
3406         * Scripts/bugzilla-tool:
3407         (bug_comment_from_commit_text): Print out a compact,
3408         standardized commit message for both git and svn.
3409
3410 2009-08-17  Peter Kasting  <pkasting@google.com>
3411
3412         Reviewed by Steve Falkenburg.
3413
3414         https://bugs.webkit.org/show_bug.cgi?id=27323
3415         Only add Cygwin to the path when it isn't already there.  This avoids
3416         causing problems for people who purposefully have non-Cygwin versions of
3417         executables like svn in front of the Cygwin ones in their paths.
3418
3419         * DumpRenderTree/win/DumpRenderTree.vcproj:
3420         * DumpRenderTree/win/ImageDiff.vcproj:
3421         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3422
3423 2009-08-17  David Kilzer  <ddkilzer@apple.com>
3424
3425         <http://webkit.org/b/28393> check-webkit-style: add check for use of std::max()/std::min() instead of MAX()/MIN()
3426
3427         Reviewed by David Levin.
3428
3429         * Scripts/modules/cpp_style.py:
3430         (_ERROR_CATEGORIES): Added 'runtime/max_min_macros'.
3431         (check_max_min_macros): Added.  Returns level 4 error when MAX()
3432         and MIN() macros are used in header files and C++ source files.
3433         (check_style): Added call to check_max_min_macros().
3434         * Scripts/modules/cpp_style_unittest.py: Added unit tests.
3435         (test_max_macro): Added.
3436         (test_min_macro): Added.
3437
3438 2009-08-13  Mike Fenton  <mike.fenton@torchmobile.com>
3439
3440         Reviewed by Eric Seidel.
3441
3442         Move adjustLineToPixelBoundaries overlapping function to GraphicsContext.cpp
3443         and remove from GraphicsContextCairo.cpp and GraphicsContextQt.cpp.
3444
3445         https://bugs.webkit.org/show_bug.cgi?id=28268
3446
3447         * platform/graphics/GraphicsContext.cpp:
3448         (WebCore::GraphicsContext::adjustLineToPixelBoundaries):
3449         * platform/graphics/GraphicsContext.h:
3450         * platform/graphics/cairo/GraphicsContextCairo.cpp:
3451         * platform/graphics/qt/GraphicsContextQt.cpp:
3452
3453 2009-08-10  Mike Fenton  <mike.fenton@torchmobile.com>
3454
3455         Reviewed by Adam Treat.
3456
3457         Style fixes for DumpRenderTree/qt/jsobjects.cpp based on cpp_style.py and
3458         WebKit style guide.
3459
3460         https://bugs.webkit.org/show_bug.cgi?id=28161
3461
3462         * DumpRenderTree/qt/jsobjects.cpp:
3463         (findFrameNamed):
3464         (LoadItem::invoke):
3465         (LayoutTestController::provisionalLoad):
3466         (LayoutTestController::timerEvent):
3467         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
3468         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
3469         (LayoutTestController::numberOfActiveAnimations):
3470         (EventSender::keyDown):
3471         (EventSender::frameUnderMouse):
3472         (TextInputController::doCommand):
3473
3474 2009-08-16  David Kilzer  <ddkilzer@apple.com>
3475
3476         <http://webkit.org/b/28370> check-webkit-style: add check for 'using std::foo;' statements
3477
3478         Reviewed by David Levin.
3479
3480         In <http://webkit.org/b/28355#c1>, it was noted that new source
3481         files use 'using namespace std;' instead of individual
3482         'using std::foo;' statements.  This adds a level 4 check for
3483         such statements.
3484
3485         * Scripts/modules/cpp_style.py:
3486         (_ERROR_CATEGORIES): Added 'build/using_std'.
3487         (check_using_std): Added.
3488         (check_style): Added call to check_using_std().
3489         * Scripts/modules/cpp_style_unittest.py:
3490         (WebKitStyleTest.test_using_std): Added unit test.
3491
3492 2009-08-16  David Kilzer  <ddkilzer@apple.com>
3493
3494         Backed out r47343 which was mistakenly committed
3495
3496         * Scripts/bugzilla-tool:
3497         * Scripts/modules/scm.py:
3498
3499 2009-08-16  David Kilzer  <ddkilzer@apple.com>
3500
3501         <http://webkit.org/b/28367> bugzilla.py: replace ScriptError class with BugzillaError class
3502
3503         Reviewed by David Levin.
3504
3505         The ScriptError class doesn't exist in bugzilla.py, so any
3506         errors print error messages about ScriptError instead of the
3507         actual error:
3508
3509             NameError: global name 'ScriptError' is not defined
3510
3511         * Scripts/modules/bugzilla.py:
3512         (BugzillaError): Added class.  Modeled after ScriptError class
3513         in scm.py.
3514         (Bugzilla.authenticate): Changed to use BugzillaError instead of
3515         ScriptError.
3516         (Bugzilla._check_create_bug_response): Ditto.
3517
3518 2009-08-14  Adam Bergkvist  <adam.bergkvist@ericsson.com>
3519
3520         Reviewed by Sam Weinig.
3521
3522         Added EventSource to the build script (default on).
3523         https://bugs.webkit.org/show_bug.cgi?id=14997 
3524
3525         * Scripts/build-webkit:
3526
3527 2009-08-15  Ryosuke Niwa  <rniwa@webkit.org>
3528
3529         Unreviewed.
3530
3531         Add myself to list of committers.
3532
3533         * Scripts/modules/committers.py:
3534
3535 2009-08-15  Jon Honeycutt  <jhoneycutt@apple.com>
3536
3537         Fix layout test failures after r47312.
3538
3539         Reviewed by Cameron Zwarich.
3540
3541         * DumpRenderTree/AccessibilityController.h:
3542         Replaced logFocusEvents() with setLogFocusEvents(), which takes a
3543         boolean argument to turn logging of focus events on or off.
3544         Added a function to reset the AccessibilityController to a consistent
3545         state.
3546
3547         * DumpRenderTree/AccessibilityController.cpp:
3548         (logFocusEventsCallback):
3549         Call setLogFocusEvents() to enable logging.
3550         (AccessibilityController::resetToConsistentState):
3551         Call setLogFocusEvents() to disable logging.
3552
3553         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3554         (AccessibilityController::setLogFocusEvents):
3555         Update stub.
3556
3557         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3558         (AccessibilityController::setLogFocusEvents):
3559         Update stub.
3560
3561         * DumpRenderTree/mac/DumpRenderTree.mm:
3562         (resetWebViewToConsistentStateBeforeTesting):
3563         Call the FrameLoadDelegate's resetToConsistentState method.
3564
3565         * DumpRenderTree/mac/FrameLoadDelegate.h:
3566         Declare the resetToConsistentState method.
3567
3568         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3569         (-[FrameLoadDelegate resetToConsistentState]):
3570         Call the AccessibilityController's resetToConsistentState() function.
3571
3572         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3573         (AccessibilityController::~AccessibilityController):
3574         Turn off focus event logging when the controller is destroyed.
3575         (AccessibilityController::setLogFocusEvents):
3576         If the caller passes false, unhook the focus event, and clear
3577         m_focusEventHook.
3578
3579         * DumpRenderTree/win/DumpRenderTree.cpp:
3580         (resetWebViewToConsistentStateBeforeTesting):
3581         Call the FrameLoadDelegate's resetToConsistentState function.
3582
3583         * DumpRenderTree/win/FrameLoadDelegate.h:
3584         Declare the resetToConsistentState() function.
3585
3586         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3587         (FrameLoadDelegate::resetToConsistentState):
3588         Call the AccessibilityController's resetToConsistentState() function.
3589
3590
3591 2009-08-14  Jon Honeycutt  <jhoneycutt@apple.com>
3592
3593         Add a mechanism for logging MSAA focus events.
3594
3595         Part of <rdar://problem/6218721> No MSAA focus events fired for Webkit
3596         nightly (20866)
3597
3598         https://bugs.webkit.org/show_bug.cgi?id=20866
3599
3600         Reviewed by Oliver Hunt.
3601
3602         * DumpRenderTree/AccessibilityController.cpp:
3603         (logFocusEventsCallback):
3604         Call the AccessibilityController's logFocusEvents() function.
3605         (AccessibilityController::getJSClass):
3606         Add a "logFocusEvents" function to the AccessibilityController's JS
3607         class definition.
3608
3609         * DumpRenderTree/AccessibilityController.h:
3610         On Windows, include windows.h, and add a member variable to hold the
3611         handle to the event hook for focus events. Add a declaration for a
3612         function that enables logging of focus events.
3613
3614         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3615         (AccessibilityController::logFocusEvents):
3616         Stubbed.
3617
3618         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3619         (AccessibilityController::logFocusEvents):
3620         Stubbed.
3621
3622         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3623         (AccessibilityController::AccessibilityController):
3624         (AccessibilityController::~AccessibilityController):
3625         If we hooked the focus event, unhook it.
3626         (logFocusEventProc):
3627         When we receive a focus event, get the accessible object for the event,
3628         and log its name to stdout.
3629         (AccessibilityController::logFocusEvents):
3630         Setup the focus event hook to listen for events in the current process.
3631
3632 2009-08-14  Eric Seidel  <eric@webkit.org>
3633
3634         No review.  Fix 5-space indent to be 4-spaces.
3635
3636         * Scripts/bugzilla-tool:
3637