WebKit2: Implement WebChromeClient::exceededDatabaseQuota
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-12-08  Jessie Berlin  <jberlin@apple.com>
2
3         Reviewed by Adam Roben.
4
5         WebKit2: Implement WebChromeClient::exceededDatabaseQuota
6         https://bugs.webkit.org/show_bug.cgi?id=50656
7
8         * MiniBrowser/mac/BrowserWindowController.m:
9         (-[BrowserWindowController awakeFromNib]):
10         Indicate that exceededDatabaseQuota is not implemented.
11         * MiniBrowser/win/BrowserView.cpp:
12         (BrowserView::create):
13         Ditto.
14         * WebKitTestRunner/TestController.cpp:
15         (WTR::createOtherPage):
16         Ditto.
17         (WTR::TestController::initialize):
18         Ditto.
19
20 2010-12-08  Antonio Gomes  <agomes@rim.com>
21
22         Reviewed by Martin Robinson.
23
24         [Gtk] Populate DumpRenderTreeSupportGtk (part III)
25         https://bugs.webkit.org/show_bug.cgi?id=48429
26
27         Moved the following methods from webkitprivate.h to DumpRenderTreeSupportGtk.cpp|h:
28         * webkit_gc_collect_javascript_objects;
29         * webkit_gc_collect_javascript_objects_on_alternate_thread;
30         * webkit_gc_count_javascript_objects;
31         * webkit_web_frame_layout.
32
33         These were all only used by GTK+ DRT.
34
35         * DumpRenderTree/gtk/EventSender.cpp:
36         (dispatchEvent):
37         * DumpRenderTree/gtk/GCControllerGtk.cpp:
38         (GCController::collect):
39         (GCController::collectOnAlternateThread):
40         (GCController::getJSObjectCount):
41
42 2010-12-07  Tony Chang  <tony@chromium.org>
43
44         Reviewed by Ojan Vafai.
45
46         [chromium] force NRWT to use DRT
47         https://bugs.webkit.org/show_bug.cgi?id=50359
48
49         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
50
51 2010-12-06  Sam Weinig  <sam@webkit.org>
52
53         Reviewed by Anders Carlsson.
54
55         Generalize didChangeLocationWithinPageForFrame for all same document navigations
56         https://bugs.webkit.org/show_bug.cgi?id=50584
57
58         * MiniBrowser/mac/BrowserWindowController.m:
59         (didSameDocumentNavigationForFrame):
60         (-[BrowserWindowController awakeFromNib]):
61         (-[BrowserWindowController didSameDocumentNavigationForFrame:]):
62         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
63         (TestWebKitAPI::didSameDocumentNavigationForFrame):
64         (TestWebKitAPI::TEST):
65         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
66         (WTR::InjectedBundlePage::InjectedBundlePage):
67         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame):
68         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
69         * WebKitTestRunner/TestController.cpp:
70         (WTR::TestController::initialize):
71
72 2010-12-06  Kinuko Yasuda  <kinuko@chromium.org>
73
74         Reviewed by Ojan Vafai.
75
76         Make TestResultsServer return 404 for non-existing results files.
77         https://bugs.webkit.org/show_bug.cgi?id=50581
78
79         * TestResultServer/handlers/testfilehandler.py:
80
81 2010-12-06  Tony Chang  <tony@chromium.org>
82
83         Reviewed by Ojan Vafai.
84
85         [chromium] fix an assert hit in DRT
86         https://bugs.webkit.org/show_bug.cgi?id=50575
87
88         This class uses WTF's RefPtr, but expects chrome's base::RefPtr
89         semantics.
90
91         Otherwise, we hit ASSERTION FAILED: !m_adoptionIsRequired
92         (third_party/WebKit/JavaScriptCore/wtf/RefCounted.h:37 void
93         WTF::RefCountedBase::ref()).
94
95         * DumpRenderTree/chromium/TestWebWorker.h:
96         (TestWebWorker::TestWebWorker):
97
98 2010-12-02  Ojan Vafai  <ojan@chromium.org>
99
100         Reviewed by Eric Seidel.
101
102         make webkit-patch command work when the git branch is not synced to the remote svn branch
103         https://bugs.webkit.org/show_bug.cgi?id=50424
104
105         * Scripts/webkitpy/common/checkout/scm.py:
106         * Scripts/webkitpy/common/checkout/scm_unittest.py:
107
108 2010-12-06  Patrick Gansterer  <paroga@webkit.org>
109
110         Reviewed by Andreas Kling.
111
112         [WINCE] Add build system
113         https://bugs.webkit.org/show_bug.cgi?id=50522
114
115         * CMakeListsWinCE.txt: Added.
116
117 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
118
119         Reviewed by Tony Chang.
120
121         Allow the Chromium port to have Leopard-specific baselines
122         https://bugs.webkit.org/show_bug.cgi?id=50506
123
124         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
125
126 2010-12-03  Tony Chang  <tony@chromium.org>
127
128         Reviewed by Kent Tamura.
129
130         [chromium] fix 2 bugs with inspector tests in DRT
131         https://bugs.webkit.org/show_bug.cgi?id=50492
132
133         Tasks can outlive the tasklist (even when canceled) so this was
134         causing a crash when ~WebTask() ran.  Avoid this by unregistering
135         when a task is canceled.
136
137         Also fix an assert when closing devtool windows by copying some
138         logic from test_shell.
139
140         * DumpRenderTree/chromium/Task.cpp:
141         (WebTask::~WebTask):
142         (TaskList::revokeAll):
143         * DumpRenderTree/chromium/Task.h: Canceling a task now removes it from
144             the tasklist (since the task can outlive the tasklist).
145         * DumpRenderTree/chromium/TestShell.h:
146         (TestShell::devToolsWebView):
147         * DumpRenderTree/chromium/WebViewHost.cpp:
148         (WebViewHost::~WebViewHost): Don't load about:blank when closing
149             a window if the window has devtools loaded.  This avoids an
150             ASSERT and matches test_shell.
151
152 2010-12-06  Alejandro G. Castro  <alex@igalia.com>
153
154         Reviewed by Martin Robinson.
155
156         [GTK] Fix GtkLauncher.c style, use webkit style
157         https://bugs.webkit.org/show_bug.cgi?id=50542
158
159         * GtkLauncher/main.c:
160         (activateUriEntryCb):
161         (updateTitle):
162         (linkHoverCb):
163         (notifyTitleCb):
164         (notifyLoadStatusCb):
165         (notifyProgressCb):
166         (destroyCb):
167         (goBackCb):
168         (goForwardCb):
169         (create_webViewCb):
170         (webViewReadyCb):
171         (closeWebViewCb):
172         (createBrowser):
173         (createStatusbar):
174         (createToolbar):
175         (createWindow):
176         (main):
177
178 2010-12-04  Antonio Gomes  <agomes@rim.com>
179
180         Reviewed by Martin Robinson.
181
182         [Gtk] Populate DumpRenderTreeSupportGtk (Part II)
183         https://bugs.webkit.org/show_bug.cgi?id=48429
184
185         Moved more private method declared with WEBKIT_API to
186         DumpRenderTreeSupportGtk, since they were only being used by DRT.
187
188         * DumpRenderTree/gtk/DumpRenderTree.cpp:
189         (resetDefaultsToConsistentValues):
190         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
191         (LayoutTestController::addOriginAccessWhitelistEntry):
192         (LayoutTestController::execCommand):
193         (LayoutTestController::isCommandEnabled):
194
195 2010-12-04  Antonio Gomes  <agomes@rim.com>
196
197         Reviewed by Andreas Kling.
198
199         Removed extern webkit_web_view_set_group_name from gtk/DumpRenderTree.cpp
200
201         Method was removed by http://trac.webkit.org/changeset/71604
202
203         * DumpRenderTree/gtk/DumpRenderTree.cpp:
204
205 2010-12-05  Alejandro G. Castro  <alex@igalia.com>
206
207         Reviewed by Xan Lopez.
208
209         [GTK] Fix compilation warnings reported by clang
210         https://bugs.webkit.org/show_bug.cgi?id=50252
211
212         * GtkLauncher/main.c:
213         (create_window): The create_statusbar function does not have
214         parameters.
215
216 2010-12-05  Robert Hogan  <robert@webkit.org>
217
218         Reviewed by Andreas Kling.
219
220         [Qt] Zero-sized font does not yet work
221
222         Fix fast/text/font-size-zero.html
223
224         Copy other ports by setting minimumFontSize to 0 for DRT runs.
225
226         https://bugs.webkit.org/show_bug.cgi?id=49759
227
228         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
229         (WebCore::WebPage::WebPage):
230
231 2010-12-04  Sam Weinig  <sam@webkit.org>
232
233         Reviewed by Jon Honeycutt.
234
235         WebKit2: Need client functions to notify app when the url changes due to a fragment navigation
236         https://bugs.webkit.org/show_bug.cgi?id=50511
237
238         Update tools for new didChangeLocationWithinPageForFrame client function (and changed bundle
239         signature) and added a test for the functionality (PageLoadDidChangeLocationWithinPageForFrame.cpp)
240
241         * MiniBrowser/mac/BrowserWindowController.m:
242         (didChangeLocationWithinPageForFrame):
243         (-[BrowserWindowController awakeFromNib]):
244         (-[BrowserWindowController didChangeLocationWithinPageForFrame:]):
245         * TestWebKitAPI/PlatformUtilities.cpp:
246         (TestWebKitAPI::Util::toWK):
247         * TestWebKitAPI/PlatformUtilities.h:
248         (TestWebKitAPI::Util::adoptWK):
249         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
250         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp: Added.
251         (TestWebKitAPI::nullJavaScriptCallback):
252         (TestWebKitAPI::didFinishLoadForFrame):
253         (TestWebKitAPI::didChangeLocationWithinPageForFrame):
254         (TestWebKitAPI::TEST):
255         * TestWebKitAPI/Tests/WebKit2/file-with-anchor.html: Added.
256         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
257         * TestWebKitAPI/win/copy-resources.cmd:
258         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
259         (WTR::InjectedBundlePage::InjectedBundlePage):
260         (WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
261         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
262         * WebKitTestRunner/TestController.cpp:
263         (WTR::TestController::initialize):
264
265 2010-11-08  Antonio Gomes  <agomes@rim.com>
266
267         Reviewed by Martin Robinson.
268
269         [Gtk] Populate DumpRenderTreeSupportGtk
270         https://bugs.webkit.org/show_bug.cgi?id=48429
271
272         Made the previous calls to webkit_web_frame* functions defined as private
273         APIs in webkitprivate.h go through DRTSupportGtk.
274
275         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
276         (AccessibilityController::focusedElement):
277         * DumpRenderTree/gtk/DumpRenderTree.cpp:
278         (dumpFramesAsText):
279         (resetDefaultsToConsistentValues):
280         (dump):
281         (webViewDocumentLoadFinished):
282         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
283         (LayoutTestController::counterValueForElementById):
284         (LayoutTestController::pageNumberForElementById):
285         (LayoutTestController::numberOfPages):
286         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
287         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
288         (LayoutTestController::sampleSVGAnimationForElementAtTime):
289         (LayoutTestController::numberOfActiveAnimations):
290         (LayoutTestController::suspendAnimations):
291         (LayoutTestController::resumeAnimations):
292         (LayoutTestController::markerTextForListItem):
293
294 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
295
296         Reviewed by Tony Chang.
297
298         Rebaseline server: use pretty text diff output
299         https://bugs.webkit.org/show_bug.cgi?id=50484
300         
301         Serve *-pretty-diff.html for text diff output.
302
303         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
304         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
305         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
306         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
307
308 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
309
310         Unreviewed, rolling out r73302.
311         http://trac.webkit.org/changeset/73302
312         https://bugs.webkit.org/show_bug.cgi?id=50499
313
314         Causes crashes in debug LayoutTests (Requested by xan_ on
315         #webkit).
316
317         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
318         (AccessibilityUIElement::AccessibilityUIElement):
319         (AccessibilityUIElement::parentElementCallback):
320         * DumpRenderTree/chromium/AccessibilityUIElement.h:
321         * DumpRenderTree/chromium/CppBoundClass.cpp:
322         * DumpRenderTree/chromium/CppBoundClass.h:
323
324 2010-12-03  Sam Weinig  <sam@webkit.org>
325
326         Reviewed by Maciej Stachowiak.
327
328         Enable <a ping> for Mac/Windows/WebKit2 builds
329         <rdar://problem/8504473>
330         https://bugs.webkit.org/show_bug.cgi?id=50488
331
332         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
333         (TestWebKitAPI::TEST): Test that the default value of
334         WKPreferencesGetHyperlinkAuditingEnabled is true.
335
336 2010-12-03  Chris Guillory  <chris.guillory@google.com>
337
338         Reviewed by Chris Fleizach.
339
340         Include the FrameView widget of a RenderWidget in the accessibility tree.
341         https://bugs.webkit.org/show_bug.cgi?id=49106
342
343         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
344         (AccessibilityUIElement::AccessibilityUIElement):
345         (AccessibilityUIElement::parentElementCallback):
346         (AccessibilityUIElement::isEqualCallback):
347         * DumpRenderTree/chromium/AccessibilityUIElement.h:
348         * DumpRenderTree/chromium/CppBoundClass.cpp:
349         (CppBoundClass::getFromCppVariant):
350         * DumpRenderTree/chromium/CppBoundClass.h:
351
352 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
353
354         Reviewed by Tony Chang.
355
356         Rebaseline server: organize tests by state, add dry run mode
357         https://bugs.webkit.org/show_bug.cgi?id=50473
358         
359         Group tests in the menu by state, so that it's easier to see after
360         processing the queue which failed.
361         
362         Add support for the --dry-run flag so that it's easier to test changes
363         such as this (stubs out filesystem and SCM operations).
364
365         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
366         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
367         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
368
369 2010-12-03  Brady Eidson  <beidson@apple.com>
370
371         Reviewed by Anders Carlsson.
372
373         Groundwork for <rdar://problem/7660733> and https://bugs.webkit.org/show_bug.cgi?id=50191
374         WebKit2 Authentication Support
375
376         Keep these builds working:
377         * MiniBrowser/mac/BrowserWindowController.m:
378         (-[BrowserWindowController awakeFromNib]):
379
380         * WebKitTestRunner/TestController.cpp:
381         (WTR::TestController::initialize):
382
383 2010-12-02  Mihai Parparita  <mihaip@chromium.org>
384
385         Reviewed by Tony Chang.
386
387         Rebaseline server: move existing baselines
388         https://bugs.webkit.org/show_bug.cgi?id=50421
389         
390         Implement moving of existing baselines: move all files that are about
391         to be overwriten by update baselines.
392         
393         Also fix a typo in the UI JS.
394
395         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
396         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
397         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
398
399 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
400
401         Unreviewed, rolling out r73211.
402         http://trac.webkit.org/changeset/73211
403         https://bugs.webkit.org/show_bug.cgi?id=50450
404
405         Broke Chromium's "Webkit Win (dbg)(2)" bot. (Requested by
406         yutak on #webkit).
407
408         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
409
410 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
411
412         Unreviewed, rolling out r73222.
413         http://trac.webkit.org/changeset/73222
414         https://bugs.webkit.org/show_bug.cgi?id=50449
415
416         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
417         (Requested by yutak on #webkit).
418
419         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
420         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
421         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
422         * Scripts/webkitpy/layout_tests/port/base.py:
423         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
424         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
425
426 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
427
428         Unreviewed, rolling out r73228.
429         http://trac.webkit.org/changeset/73228
430         https://bugs.webkit.org/show_bug.cgi?id=50448
431
432         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
433         (Requested by yutak on #webkit).
434
435         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
436         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
437         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
438         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
439         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
440
441 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
442
443         Unreviewed, rolling out r73231.
444         http://trac.webkit.org/changeset/73231
445         https://bugs.webkit.org/show_bug.cgi?id=50443
446
447         r73211 seemed to broke Chromium's "Webkit Win (dbg)(2)" bot.
448         (Requested by yutak on #webkit).
449
450         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
451         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
452         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
453         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
454
455 2010-12-03  David Levin  <levin@chromium.org>
456
457         Reviewed by Shinichiro Hamaji.
458
459         check-webkit-style: false positive reported for #if macro
460         https://bugs.webkit.org/show_bug.cgi?id=48242
461
462         * Scripts/webkitpy/style/checkers/cpp.py: Adjusted check to avoid
463           all preprocessor commands.
464         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test.
465
466 2010-12-02  Eric Seidel  <eric@webkit.org>
467
468         Reviewed by Adam Barth.
469
470         Update the EWSTools scripts to use modern-style git repos
471         https://bugs.webkit.org/show_bug.cgi?id=50402
472
473         * EWSTools/create-webkit-git:
474         * EWSTools/start-commit-queue.sh:
475         * EWSTools/start-queue.sh:
476
477 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
478
479         Fix Chromium Linux plugin tests by not logging
480         unconditionally from the event handling code.
481
482         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
483         (handleEventX11):
484
485 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
486
487         Reviewed by Tony Chang.
488
489         nrwt multiprocessing - move logic back into run_webkit_tests
490
491         This change moves a bunch of logic that I had put into
492         message_broker back into run_webkit_tests, in a slightly
493         different format. WorkerMessageBroker needed to become less aware of
494         the logic the TestRunner class uses, and more generic.
495         Eventually the MessageBroker will only do generic messaging and
496         thread/process-pooling, and (almost) all of the
497         run-webkit-tests-specific logic will be moved to
498         run_webkit_tests.py and dump_render_tree_thread.py.
499         
500         The biggest changes are that the Broker can now start a single
501         worker, but the responsibility for starting all of them is pushed
502         back to the TestRunner (Manager), and the logic for checking if
503         the threads are done or wedged is moved back to TestRunner. We
504         also remove WorkerMessageBroker.cleanup (not needed) and
505         cancel_workers (they have to be cancelled individually).
506         
507         The  message_broker is now encapsulated inside
508         TestRunner._run_tests(); it only needs to exist while actually
509         running the tests.
510
511         Also, delete a bunch of tests in message_broker_unittest that no
512         longer make much sense.
513
514         This patch depends on bug 50372.
515
516         https://bugs.webkit.org/show_bug.cgi?id=50374
517
518         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
519         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
520         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
521         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
522         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
523
524 2010-12-02  Hayato Ito  <hayato@chromium.org>
525
526         Reviewed by Eric Seidel.
527
528         Refactor test_types's compare_output() method so that it takes a
529         TestInput object.
530
531         compare_output() will need additional information included in a TestInput
532         object to support reftests. This change is a pre-requirement of that.
533
534         https://bugs.webkit.org/show_bug.cgi?id=50362
535
536         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
537         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
538         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
539         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
540         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
541
542 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
543
544         Reviewed by Anders Carlsson.
545
546         Add the ability to run script on 'new' and 'paint' in the test plugin
547         https://bugs.webkit.org/show_bug.cgi?id=50425
548         
549         Add "onnew" and "onpaintevent" attributes to the test plugin,
550         so that tests can run JS at these times.
551
552         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
553         (pluginAllocate):
554         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
555         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
556         (NPP_New):
557         (NPP_Destroy):
558         (handleEventCarbon):
559         (handleEventCocoa):
560         (NPP_HandleEvent):
561
562 2010-12-02  Sam Weinig  <sam@webkit.org>
563
564         Fix Qt build.
565
566         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
567         (WTR::PlatformWebView::PlatformWebView):
568
569 2010-12-02  Sam Weinig  <sam@webkit.org>
570
571         Reviewed by Anders Carlsson.
572
573         WebKit2 Preferences should be held off the PageGroup, not the Context
574         https://bugs.webkit.org/show_bug.cgi?id=50414
575
576         Update for API changes.
577
578         * WebKitTestRunner/PlatformWebView.h:
579         * WebKitTestRunner/TestController.cpp:
580         (WTR::createOtherPage):
581         (WTR::TestController::initialize):
582         (WTR::TestController::resetStateToConsistentValues):
583         * WebKitTestRunner/TestController.h:
584         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
585         (WTR::PlatformWebView::PlatformWebView):
586         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
587         (WTR::PlatformWebView::PlatformWebView):
588
589 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
590
591         Reviewed by Tony Chang.
592
593         new-run-webkit-tests: minor cleanup for multiprocessing work
594
595         This change:
596         * moves worker naming into TestShellThread, eliminating a
597           parameter to the constructor and putting the responsibility in
598           the correct place.
599         * eliminates the _WorkerState() class in message_broker, because
600           it turns out that state really needs to be in run_webkit_tests
601         * renames the Broker classes to be module-private.
602         * fixes a bunch of minor commenting and whitespace issues to
603           make subsequent patches a bit clearer.
604         * Adds a Port hook for default_worker_model() so that we can
605           accomodate the potential for different worker models on
606           different ports.
607         * merge in the fix from 50420 for the brokenness introduced in
608           bug 50367.
609
610         This patch depends on bug 50367.
611
612         https://bugs.webkit.org/show_bug.cgi?id=50372
613
614         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
615         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
616         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
617         * Scripts/webkitpy/layout_tests/port/base.py:
618         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
619         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
620
621 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
622
623         Reviewed by Tony Chang.
624
625         This change is a bunch of cleanup / refactoring of the file
626         below. It moves a bunch of free functions to methods on the
627         TestShellThread class, and restructures other methods to be
628         closer to the structure we'll need for the multiprocessing
629         rewrite.
630
631         It also makes the logic of --run-singly a *lot* easier to follow
632         by nestling all of the separate-thread logic into a single
633         routine.
634
635         There should be no semantic changes in this patch, just cleanup.
636
637         https://bugs.webkit.org/show_bug.cgi?id=50367
638
639         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
640
641 2010-12-02  Tony Chang  <tony@chromium.org>
642
643         Unreviewed, rolling out r73164.
644         http://trac.webkit.org/changeset/73164
645         https://bugs.webkit.org/show_bug.cgi?id=50359
646
647         broke debugger tests on win
648
649         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
650
651 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
652
653         Reviewed by Tony Chang.
654
655         Rebaseline server: add updating of baselines
656         https://bugs.webkit.org/show_bug.cgi?id=50305
657         
658         Implements updating of baselines, where we copy -actual.* files over
659         the current -expected.* files. To do this, we need a
660         _get_actual_result_files method to get test results files and a
661         _rebaseline_test method to actually do the file copy and SCM operation.
662         _rebaseline_test logs output into a buffer, this is useful for both
663         showing result in the UI and for unit tests.
664         
665         To make passing around of the various test environment properties
666         (results directory, filesystem, SCM, etc) easier, add a TestConfig
667         class for them.
668         
669         Moving of existing baselines is not implemented yet, this patch is big
670         enough as it is.
671
672         * Scripts/webkitpy/common/system/filesystem.py:
673         * Scripts/webkitpy/common/system/filesystem_mock.py:
674         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
675         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
676         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
677         * Scripts/webkitpy/tool/mocktool.py:
678
679 2010-12-02  Brent Fulgham  <bfulgham@webkit.org>
680
681         Unreviewed build fix after vcproj updates.
682
683         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Make sure
684         that WIN_CAIRO is defined for this build.
685         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Update file
686         to reflect new 'Debug_Cairo_CFLite' and 'Release_Cairo_CFLite'
687         (these were previously 'Debug_Cairo' and 'Release_Cairo'
688
689 2010-12-02  Sam Weinig  <sam@webkit.org>
690
691         Reviewed by Anders Carlsson.
692
693         WebKit2 needs API to turn on popup blocking
694         https://bugs.webkit.org/show_bug.cgi?id=50407
695
696         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
697         (TestWebKitAPI::TEST):
698         * WebKitTestRunner/TestController.cpp:
699         (WTR::TestController::resetStateToConsistentValues):
700
701 2010-12-01  Tony Chang  <tony@chromium.org>
702
703         Reviewed by Ojan Vafai.
704
705         [chromium] force NRWT to use DRT
706         https://bugs.webkit.org/show_bug.cgi?id=50359
707
708         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
709
710 2010-12-02  Martin Robinson  <mrobinson@igalia.com>
711
712         Reviewed by Xan Lopez.
713
714         [GTK] DumpRenderTree has two copies of JavaScriptCore
715         https://bugs.webkit.org/show_bug.cgi?id=49877
716
717         * GNUmakefile.am: Remove the second copy of JavaScriptCore from the
718         LDADD list for DumpRenderTree.
719
720 2010-12-02  Sergio Villar Senin  <svillar@igalia.com>
721
722         Unreviewed: Added myself to list of Committers.
723
724         * Scripts/webkitpy/common/config/committers.py:
725
726 2010-12-01  Mihai Parparita  <mihaip@chromium.org>
727
728         Reviewed by Adam Barth.
729
730         build-webkit --chromium always updates DEPS and re-generates project files
731         https://bugs.webkit.org/show_bug.cgi?id=50340
732         
733         Make build-webkit --chromium invoke update-webkit-chromium only when
734         --update-chromium is passed in, so that we don't add 20 seconds to all
735         builds.
736         
737         Making all invocations update was added with r61883, with the goal of
738         making EWS bots always update. The bots will switch to using this flag
739         (as will all other webkit-patch build steps) so nothing should change
740         for them.
741
742         * Scripts/webkitdirs.pm:
743         * Scripts/webkitpy/common/config/ports.py:
744         * Scripts/webkitpy/common/config/ports_unittest.py:
745
746 2010-12-01  Dirk Pranke  <dpranke@chromium.org>
747
748         Reviewed by Tony Chang.
749
750         new-run-webkit-tests: add a --dry-run / -n flag
751         https://bugs.webkit.org/show_bug.cgi?id=50045
752
753         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
754         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
755
756 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
757
758         Reviewed by Adam Roben.
759
760         WinCairo build should not use link-time code generation (LTCG)
761         https://bugs.webkit.org/show_bug.cgi?id=50353
762
763         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
764         * DumpRenderTree/win/DumpRenderTree.vcproj:
765         * DumpRenderTree/win/ImageDiff.vcproj:
766         * FindSafari/FindSafari.vcproj:
767         * MiniBrowser/MiniBrowser.vcproj:
768         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
769         * WebKitAPITest/WebKitAPITest.vcproj:
770         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
771         * WebKitTestRunner/win/InjectedBundle.vcproj:
772         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
773         * WinLauncher/WinLauncher.vcproj:
774         * record-memory-win/record-memory-win.vcproj:
775
776 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
777
778         Touch GetUserAgentWithNullNPPFromNPPNew.cpp in an effort to force
779         a rebuild of TestNetscapePlugin.la on GTK+. It seems that simply
780         adding the file to the sources list was not enough to force the rebuild.
781
782         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
783         Remove an empty line at the end of this file to force a rebuild.
784
785 2010-12-01  Sam Weinig  <sam@webkit.org>
786
787         Fix windows build.
788
789         * MiniBrowser/win/BrowserView.cpp:
790         (BrowserView::create):
791
792 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
793
794         Add missing file to the TestNetscapePlugin sources list after r73057.
795
796         * GNUmakefile.am: Add missing file.
797
798 2010-12-01  Sam Weinig  <sam@webkit.org>
799
800         Reviewed by Anders Carlsson.
801
802         Add PageGrouping to WebKit2 API
803         https://bugs.webkit.org/show_bug.cgi?id=50332
804
805         - Update testing harnesses to deal with new PageGroup API.
806
807         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
808         (WKBundleInitialize):
809         * TestWebKitAPI/InjectedBundleController.cpp:
810         (TestWebKitAPI::InjectedBundleController::initialize):
811         (TestWebKitAPI::InjectedBundleController::didInitializePageGroup):
812         (TestWebKitAPI::InjectedBundleController::initializeTestNamed):
813         * TestWebKitAPI/InjectedBundleController.h:
814         * TestWebKitAPI/InjectedBundleTest.h:
815         (TestWebKitAPI::InjectedBundleTest::initialize):
816         (TestWebKitAPI::InjectedBundleTest::didInitializePageGroup):
817         * TestWebKitAPI/PlatformUtilities.cpp:
818         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
819         * TestWebKitAPI/PlatformUtilities.h:
820         * TestWebKitAPI/PlatformWebView.h:
821         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
822         (TestWebKitAPI::TEST):
823         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
824         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
825         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
826         (TestWebKitAPI::PlatformWebView::PlatformWebView):
827         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
828         (TestWebKitAPI::PlatformWebView::PlatformWebView):
829         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
830         (WTR::InjectedBundle::didInitializePageGroup):
831         (WTR::InjectedBundle::initialize):
832         (WTR::InjectedBundle::beginTesting):
833         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
834         (WTR::InjectedBundle::pageGroup):
835         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
836         (WTR::LayoutTestController::addUserScript):
837         (WTR::LayoutTestController::addUserStyleSheet):
838         (WTR::LayoutTestController::setXSSAuditorEnabled):
839         * WebKitTestRunner/TestController.cpp:
840         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
841         (WTR::PlatformWebView::PlatformWebView):
842
843 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
844
845         Reviewed by Adam Roben.
846
847         vcproj changes can't be applied cleanly by the Windows EWS bot
848         https://bugs.webkit.org/show_bug.cgi?id=50328
849
850         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
851         * CLWrapper/CLWrapper.vcproj: Modified property svn:eol-style.
852         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
853         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added property svn:eol-style.
854         * DumpRenderTree/win/DumpRenderTree.vcproj: Modified property svn:eol-style.
855         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added property svn:eol-style.
856         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added property svn:eol-style.
857         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added property svn:eol-style.
858         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added property svn:eol-style.
859         * DumpRenderTree/win/ImageDiff.vcproj: Modified property svn:eol-style.
860         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added property svn:eol-style.
861         * FindSafari/FindSafari.vcproj: Modified property svn:eol-style.
862         * FindSafari/FindSafariCommon.vsprops: Added property svn:eol-style.
863         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
864         * MIDLWrapper/MIDLWrapper.vcproj: Modified property svn:eol-style.
865         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added property svn:eol-style.
866         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added property svn:eol-style.
867         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added property svn:eol-style.
868         * MiniBrowser/MiniBrowser.vcproj: Added property svn:eol-style.
869         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added property svn:eol-style.
870         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added property svn:eol-style.
871         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops: Added property svn:eol-style.
872         * TestWebKitAPI/win/TestWebKitAPI.sln: Added property svn:eol-style.
873         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added property svn:eol-style.
874         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added property svn:eol-style.
875         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added property svn:eol-style.
876         * WebKitAPITest/WebKitAPITest.vcproj: Added property svn:eol-style.
877         * WebKitAPITest/WebKitAPITestCommon.vsprops: Added property svn:eol-style.
878         * WebKitLauncherWin/WebKitLauncherWin.vcproj: Modified property svn:eol-style.
879         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added property svn:eol-style.
880         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added property svn:eol-style.
881         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added property svn:eol-style.
882         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops: Added property svn:eol-style.
883         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added property svn:eol-style.
884         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added property svn:eol-style.
885         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added property svn:eol-style.
886         * WebKitTestRunner/WebKitTestRunner.sln: Added property svn:eol-style.
887         * WebKitTestRunner/win/InjectedBundle.vcproj: Added property svn:eol-style.
888         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added property svn:eol-style.
889         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added property svn:eol-style.
890         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added property svn:eol-style.
891         * WinLauncher/WinLauncher.vcproj: Modified property svn:eol-style.
892         * WinLauncher/WinLauncherCommon.vsprops: Added property svn:eol-style.
893         * record-memory-win/record-memory-win-common.vsprops: Added property svn:eol-style.
894         * record-memory-win/record-memory-win.vcproj: Modified property svn:eol-style.
895
896 2010-12-01  Anders Carlsson  <andersca@apple.com>
897
898         Reviewed by Darin Adler.
899
900         Return a correct user agent if NPN_UserAgent is called with a null NPP from NPP_New.
901         https://bugs.webkit.org/show_bug.cgi?id=50336
902
903         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
904         Add new test.
905
906         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
907         (PluginTest::NPP_New):
908         Add default implementation/
909
910         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
911         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp: Added.
912         (GetUserAgentWithNullNPPFromNPPNew::GetUserAgentWithNullNPPFromNPPNew):
913         (GetUserAgentWithNullNPPFromNPPNew::NPP_New):
914         Get the user agent.
915
916         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
917         (NPP_New):
918         Call PluginTest::NPP_New.
919
920         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
921         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
922         Add new files.
923
924         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
925         (webkit_test_plugin_new_instance):
926         Call PluginTest::NPP_New.
927
928 2010-12-01  Kevin Ollivier  <kevino@theolliviers.com>
929
930         [wx] Build fixes after recent trunk changes.
931
932         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
933         (LayoutTestController::findString):
934         * wx/build/settings.py:
935
936 2010-12-01  Dan Bernstein  <mitz@apple.com>
937
938         Reviewed by Darin Adler.
939
940         WebKitTestRunner needs layoutTestController.findString
941         https://bugs.webkit.org/show_bug.cgi?id=50238
942
943         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added findString().
944         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
945         (WTR::LayoutTestController::findString): Updated signature for autogenerated bindings.
946         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
947
948 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
949
950         Try using svn:eol-style native on a vcproj file.
951
952         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Modified property svn:eol-style.
953
954 2010-12-01  Patrick Gansterer  <paroga@webkit.org>
955
956         Reviewed by Adam Roben.
957
958         [WINCE] Add WinCELauncher
959         https://bugs.webkit.org/show_bug.cgi?id=50217
960
961         * WinCELauncher/main.cpp: Added.
962
963 2010-11-30  Benjamin Poulain  <benjamin.poulain@nokia.com>
964
965         Reviewed by Kenneth Rohde Christiansen.
966
967         [Qt] Implement layoutTestController.findString
968         https://bugs.webkit.org/show_bug.cgi?id=50236
969
970         Add the missing function to the LayoutTestController.
971
972         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
973         (LayoutTestController::findString):
974         * DumpRenderTree/qt/LayoutTestControllerQt.h:
975
976 2010-11-30  Tony Chang  <tony@chromium.org>
977
978         Reviewed by Adam Barth.
979
980         [chromium] fix get-int-identifier-special-values.html using TestNetscapePlugIn
981         https://bugs.webkit.org/show_bug.cgi?id=49036
982
983         * DumpRenderTree/chromium/LayoutTestController.cpp: Use IsNumber instead of IsInt32
984             for CppVariants.
985         (LayoutTestController::cppVariantToBool):
986         (LayoutTestController::cppVariantToInt32):
987         (LayoutTestController::setDatabaseQuota):
988         (LayoutTestController::evaluateInWebInspector):
989         (LayoutTestController::setMockGeolocationError):
990
991 2010-11-30  Eric Seidel  <eric@webkit.org>
992
993         Reviewed by Tony Chang.
994
995         update-webkit should call git fetch before git svn rebase
996         https://bugs.webkit.org/show_bug.cgi?id=50273
997
998         After discussion on webkit-dev, we've decided to move the "default"
999         git setup to pulling updates from git.webkit.org in preference
1000         to rebuilding the local svn index using git svn fetch every time.
1001
1002         This change should have no effect on people using the "old" git setup
1003         and should dramatically increase the speed of updates for those using
1004         the "new" git setup along with update-webkit.  I'm about to move the
1005         EWS and other queues over to this setup once this lands.
1006
1007         * Scripts/update-webkit:
1008
1009 2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>
1010
1011         Reviewed by Xan Lopez.
1012
1013         GTK: AX: implement press in DRT
1014         https://bugs.webkit.org/show_bug.cgi?id=36146
1015
1016         Implement AccessibilityUIElement::press() for GTK.
1017
1018         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1019         (AccessibilityUIElement::press): Implemented.
1020
1021 2010-11-29  Mihai Parparita  <mihaip@chromium.org>
1022
1023         Reviewed by Tony Chang.
1024
1025         config.webkit_base_dir returns a path with a trailing slash
1026         https://bugs.webkit.org/show_bug.cgi?id=50197
1027         
1028         config.webkit_base_dir() should return a path without a trailing slash,
1029         like all the other methods that return paths.
1030         
1031         Undoes MockFileSytem changes by r72640, since they're no longer
1032         necessary for GetBaselinesTest to pass.
1033
1034         * Scripts/webkitpy/common/system/filesystem_mock.py:
1035         * Scripts/webkitpy/layout_tests/port/base.py:
1036         * Scripts/webkitpy/layout_tests/port/config.py:
1037         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1038
1039 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
1040
1041         Reviewed by Tony Chang.
1042
1043         Rebaseline server: baseline display tweaks
1044         https://bugs.webkit.org/show_bug.cgi?id=50207
1045         
1046         Determine which baselines were used when running the tests and highlight
1047         them in the UI. Sort platform names alphabetically.
1048         
1049         Also makes the server URL be launched in the user's browser
1050         automatically.
1051
1052         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1053         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1054         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
1055         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1056         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
1057
1058 2010-11-30  Dan Bernstein  <mitz@apple.com>
1059
1060         Reviewed by Anders Carlsson.
1061
1062         <rdar://problem/8710645> WebKitTestRunner needs layoutTestController.findString
1063         https://bugs.webkit.org/show_bug.cgi?id=50238
1064
1065         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1066         (WTR::LayoutTestController::findString): Added.
1067         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1068
1069 2010-11-30  Steve Falkenburg  <sfalken@apple.com>
1070
1071         Reviewed by Adam Roben.
1072
1073         All projects on Windows should use cmd files for build events
1074         https://bugs.webkit.org/show_bug.cgi?id=50213
1075
1076         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
1077         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Added.
1078         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Added.
1079         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
1080         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Added.
1081         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Added.
1082         * DumpRenderTree/win/ImageDiffCommon.vsprops:
1083         * DumpRenderTree/win/ImageDiffPostBuild.cmd: Added.
1084         * DumpRenderTree/win/ImageDiffPreBuild.cmd: Added.
1085         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops:
1086         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
1087         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops:
1088         * MiniBrowser/MiniBrowserPostBuild.cmd: Added.
1089         * MiniBrowser/MiniBrowserPreBuild.cmd: Added.
1090         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
1091         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Added.
1092         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Added.
1093         * WebKitAPITest/WebKitAPITestCommon.vsprops:
1094         * WebKitAPITest/WebKitAPITestPostBuild.cmd: Added.
1095         * WebKitAPITest/WebKitAPITestPreBuild.cmd: Added.
1096         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
1097         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
1098         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd: Added.
1099         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd: Added.
1100         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd: Added.
1101         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd: Added.
1102         * WinLauncher/WinLauncherCommon.vsprops:
1103         * WinLauncher/WinLauncherPostBuild.cmd: Added.
1104         * WinLauncher/WinLauncherPreBuild.cmd: Added.
1105
1106 2010-11-29  Dan Bernstein  <mitz@apple.com>
1107
1108         GTK DumpRenderTree build fix after r72887.
1109
1110         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1111         (LayoutTestController::findString):
1112
1113 2010-11-29  Dan Bernstein  <mitz@apple.com>
1114
1115         Windows DumpRenderTree build fix after r72887.
1116
1117         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1118         (LayoutTestController::findString): Added empty implementation.
1119
1120 2010-11-29  Dan Bernstein  <mitz@apple.com>
1121
1122         Reviewed by Darin Adler.
1123
1124         DumpRenderTree changes for testing the text search API.
1125         https://bugs.webkit.org/show_bug.cgi?id=50038
1126
1127         * DumpRenderTree/LayoutTestController.cpp:
1128         (findStringCallback):
1129         (LayoutTestController::staticFunctions):
1130         * DumpRenderTree/LayoutTestController.h:
1131         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1132         (LayoutTestController::findString):
1133         * MiniBrowser/mac/BrowserWindowController.m:
1134         (-[BrowserWindowController find:]):
1135
1136 2010-11-29  Johnny Ding  <jnd@chromium.org>
1137
1138         Unreviewed: Add myself to the list of Committers.
1139
1140         * Scripts/webkitpy/common/config/committers.py:
1141
1142 2010-11-29  Mark Rowe  <mrowe@apple.com>
1143
1144         Reviewed by Adele Peterson.
1145
1146         <rdar://problem/8694997> DumpRenderTree fails to build.
1147
1148         * DumpRenderTree/mac/PerlSupport/Makefile: Skip generating wrappers.
1149
1150 2010-11-29  Mark Rowe  <mrowe@apple.com>
1151
1152         Reviewed by Adele Peterson.
1153
1154         <rdar://problem/8694997> DumpRenderTree fails to build.
1155
1156         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm.
1157         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapTiger.c.
1158         * DumpRenderTree/mac/PerlSupport/Makefile:
1159
1160 2010-11-29  Mario Sanchez Prada  <msanchez@igalia.com>
1161
1162         Reviewed by Martin Robinson.
1163
1164         [GTK] Null-check needed in DRT's AccessibilityUIElement::allAtributes()
1165         https://bugs.webkit.org/show_bug.cgi?id=50154
1166
1167         Added missing checks to allAttributes().
1168
1169         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1170         (AccessibilityUIElement::allAttributes): Added missing checks.
1171
1172 2010-11-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1173
1174         Reviewed by Kenneth Rohde Christiansen.
1175
1176         [Qt] Allow pre-generation for package builds for WebKit2
1177         https://bugs.webkit.org/show_bug.cgi?id=50139
1178
1179         Use a build variable for the generated directory path and set the
1180         value based on CONFIG just like for WebKit1.
1181
1182         For non-package builds use a relative base path for the
1183         genrated directory just like for WebKit1.
1184
1185         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1186         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1187
1188 2010-11-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1189
1190         Reviewed by Kenneth Rohde Christiansen.
1191
1192         [Qt] Move some build logic from Qt to platform independent code
1193         https://bugs.webkit.org/show_bug.cgi?id=50134
1194
1195         Create target directories inside generate-forwarding-headers.pl.
1196
1197         * Scripts/generate-forwarding-headers.pl:
1198
1199 2010-11-24  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
1200
1201         Reviewed by Martin Robinson.
1202
1203         [GTK] Windowless plugins gets broken key input
1204         https://bugs.webkit.org/show_bug.cgi?id=49927
1205
1206         Convert the XEvent::keycode to ASCII before printing it. Not
1207         doing this was causing false positive in 
1208         plugins/keyboard-events.html.
1209
1210         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1211         (keycode_to_char):
1212         (webkit_test_plugin_handle_event):
1213
1214 2010-11-24  Jan Erik Hanssen  <jhanssen@sencha.com>
1215
1216         Reviewed by Antonio Gomes.
1217
1218         [Qt] Html autofocus not working with QGraphicsWebView
1219         https://bugs.webkit.org/show_bug.cgi?id=43169
1220
1221         Tell the scene to set the webview item as the currently
1222         focused item. This makes the input field with autofocus get
1223         focus as it should.
1224
1225         * QtTestBrowser/webview.cpp:
1226         (WebViewGraphicsBased::WebViewGraphicsBased):
1227
1228 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
1229
1230         Reviewed by Tony Chang.
1231
1232         nrwt - clean up create_driver interface and print out the
1233         command line used for DumpRenderTree/TestShell.
1234
1235         This patch adds a driver_cmd_line() call to the Port class in
1236         order to retrive the command line to print it out (as part of
1237         --print config).
1238
1239         In addition, this patch cleans up the Port.create_driver()
1240         signature and the Driver constructor interface to take a worker
1241         number and no longer require the image_path argument (Chromium's
1242         drivers now synthesize the image_path from the worker number
1243         internally).
1244
1245         https://bugs.webkit.org/show_bug.cgi?id=49934
1246
1247         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1248         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1249         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1250         * Scripts/webkitpy/layout_tests/port/base.py:
1251         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1252         * Scripts/webkitpy/layout_tests/port/chromium.py:
1253         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1254         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1255         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1256         * Scripts/webkitpy/layout_tests/port/test.py:
1257         * Scripts/webkitpy/layout_tests/port/webkit.py:
1258         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1259         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1260
1261 2010-11-24  Ojan Vafai  <ojan@chromium.org>
1262
1263         Reviewed by Tony Chang.
1264
1265         [chromium] improve memory usage for test results server and store fewer runs
1266         https://bugs.webkit.org/show_bug.cgi?id=50035
1267
1268         Store fewer runs and don't pass full files around when we only need bools.
1269         Greatly improves error rates on test-results.appspot.com.
1270
1271         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1272         * TestResultServer/handlers/testfilehandler.py:
1273         * TestResultServer/model/dashboardfile.py:
1274         * TestResultServer/model/jsonresults.py:
1275
1276 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
1277
1278         Reviewed by Tony Chang.
1279
1280         This patch implements the first part of the manager side of the
1281         Broker objects - it handles creating threads, waiting for them
1282         to complete, and running a single-threaded loop as well.
1283
1284         https://bugs.webkit.org/show_bug.cgi?id=49779
1285
1286         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1287         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
1288         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1289         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1290
1291 2010-11-24  Mihai Parparita  <mihaip@chromium.org>
1292
1293         Reviewed by David Levin.
1294
1295         DRT should not generate pixel output for text/plain tests
1296         https://bugs.webkit.org/show_bug.cgi?id=50002
1297         
1298         Modify Mac, Windows and GTK DRT implementations to disable pixel output
1299         when encountering a text/plain response (the Chromium one already does
1300         this, and none of the other ports special-case text/plain output in
1301         the first place).
1302
1303         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1304         (dump):
1305         * DumpRenderTree/mac/DumpRenderTree.mm:
1306         (dump):
1307         * DumpRenderTree/win/DumpRenderTree.cpp:
1308         (dump):
1309
1310 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
1311
1312         Unreviewed.
1313
1314         Add my other email address to committers.py.
1315
1316         * Scripts/webkitpy/common/config/committers.py:
1317
1318 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
1319
1320         Reviewed by Csaba Osztrogonác.
1321
1322         Make build-webkit --minimal build with ENABLE_INSPECTOR=0
1323         https://bugs.webkit.org/show_bug.cgi?id=49975
1324
1325         * Scripts/build-webkit: Add ENABLE_INSPECTOR define to features,
1326         to enable the script to define it 0 in case of a minimal build.
1327
1328 2010-11-24  Martin Robinson  <mrobinson@igalia.com>
1329
1330         Reviewed by Xan Lopez.
1331
1332         [GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient
1333         https://bugs.webkit.org/show_bug.cgi?id=49143
1334
1335         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1336         (createWebView): Call the new connectEditingCallbacks function.
1337         * DumpRenderTree/gtk/EditingCallbacks.cpp: Added.
1338         (dumpNodePath):
1339         (dumpRange):
1340         (insertActionString):
1341         (selectionAffinityString):
1342         (shouldBeginEditing):
1343         (shouldEndEditing):
1344         (shouldInsertNode):
1345         (shouldInsertText):
1346         (shouldDeleteRange):
1347         (shouldShowDeleteInterfaceForElement):
1348         (shouldChangeSelectedRange):
1349         (shouldApplyStyle):
1350         (editingBegan):
1351         (userChangedContents):
1352         (editingEnded):
1353         (selectionChanged):
1354         (connectEditingCallbacks):
1355         * DumpRenderTree/gtk/EditingCallbacks.h: Added.
1356         * GNUmakefile.am: Added EditingCallbacks.{h,cpp} to the source list.
1357
1358 2010-11-24  Yi Shen  <yi.4.shen@nokia.com>
1359
1360         Reviewed by Andreas Kling.
1361
1362         [Qt] Make QtTestBrowser remember the selected user agent
1363         https://bugs.webkit.org/show_bug.cgi?id=50021
1364
1365         Set user agent for a new page by using the old page's
1366
1367         * QtTestBrowser/mainwindow.cpp:
1368         (MainWindow::setPage):
1369
1370 2010-11-24 Patrick Gansterer <paroga@webkit.org>
1371
1372         Reviewed by Csaba Osztrogonác.
1373
1374         Remove Bakefile build system files
1375         https://bugs.webkit.org/show_bug.cgi?id=49983
1376
1377         r53757 only removed the content, but not the files.
1378         This patch removes that empty files.
1379
1380         * DumpRenderTree/wx/DumpRenderTree.bkl: Removed.
1381         * wx/browser/browser.bkl: Removed.
1382         * wx/build-wxwebkit: Removed.
1383
1384 2010-11-23  Dirk Pranke  <dpranke@chromium.org>
1385
1386         Reviewed by Tony Chang.
1387
1388         This patch cleans up the logic used to shard tests into groups a
1389         bit and adds the --worker-model flag to NRWT. The flag is only
1390         used at the moment to control whether to run single-threaded or
1391         not, but eventually will also allow toggling between threads and
1392         processes.
1393
1394         Also add a minor cleanup with _test_is_slow(), which just
1395         eliminates some repetition and gives slightly better encapsulation.
1396
1397         https://bugs.webkit.org/show_bug.cgi?id=49773
1398
1399         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1400         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1401
1402 2010-11-23  Mihai Parparita  <mihaip@chromium.org>
1403
1404         Reviewed by Tony Chang.
1405
1406         Rebaseline server: list current baselines and platforms
1407         https://bugs.webkit.org/show_bug.cgi?id=49991
1408         
1409         List existing baselines (with Trac links) for tests.
1410         
1411         Add dropdowns for choosing with platform baselines to target (and what
1412         to do with existing ones).
1413
1414         Also fix MockFileSystem.join to behave more like os.path.join (unit
1415         test was ending up with two consecutive slashes in a layout test
1416         path).        
1417
1418         * Scripts/webkitpy/common/system/filesystem_mock.py:
1419         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1420         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1421         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1422         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
1423         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
1424         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1425         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py: Added.
1426
1427 2010-11-23  Ojan Vafai  <ojan@chromium.org>
1428
1429         Reviewed by Tony Chang.
1430
1431         remove timeout argument to urlopen
1432         https://bugs.webkit.org/show_bug.cgi?id=49995
1433
1434         Apparently the version of python we have on the bots doesn't accept a timeout argument.
1435
1436         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
1437
1438 2010-11-23  Sheriff Bot  <webkit.review.bot@gmail.com>
1439
1440         Unreviewed, rolling out r72628.
1441         http://trac.webkit.org/changeset/72628
1442         https://bugs.webkit.org/show_bug.cgi?id=49994
1443
1444         This patch is causing layout-test failtures on GTK Linux
1445         64-bit Debug (Requested by ctguil on #webkit).
1446
1447         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
1448         (AccessibilityUIElement::AccessibilityUIElement):
1449         (AccessibilityUIElement::parentElementCallback):
1450         * DumpRenderTree/chromium/AccessibilityUIElement.h:
1451         * DumpRenderTree/chromium/CppBoundClass.cpp:
1452         * DumpRenderTree/chromium/CppBoundClass.h:
1453
1454 2010-11-22  Ojan Vafai  <ojan@chromium.org>
1455
1456         Reviewed by Tony Chang.
1457
1458         speculative fix for upload errors: stop using mechanize to upload to test-results.appspot.com
1459         https://bugs.webkit.org/show_bug.cgi?id=49944
1460
1461         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
1462
1463 2010-11-23  Chris Guillory  <chris.guillory@google.com>
1464
1465         Reviewed by Dimitri Glazkov.
1466
1467         Include the FrameView widget of a RenderWidget in the accessibility tree.
1468         https://bugs.webkit.org/show_bug.cgi?id=49106
1469
1470         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
1471         (AccessibilityUIElement::AccessibilityUIElement):
1472         (AccessibilityUIElement::parentElementCallback):
1473         (AccessibilityUIElement::isEqualCallback):
1474         * DumpRenderTree/chromium/AccessibilityUIElement.h:
1475         * DumpRenderTree/chromium/CppBoundClass.cpp:
1476         (CppBoundClass::getFromCppVariant):
1477         * DumpRenderTree/chromium/CppBoundClass.h:
1478
1479 2010-11-23  Alex Grilo  <abgrilo@profusion.mobi>
1480
1481         Reviewed by Kenneth Rohde Christiansen.
1482
1483         [EFL] Add tiled backing store to EWebLauncher
1484         https://bugs.webkit.org/show_bug.cgi?id=45777
1485
1486         Allow EWebLauncher to choose between single and tiled backing store
1487
1488         * EWebLauncher/main.c:
1489         (on_key_down):
1490         (browserCreate):
1491         (main):
1492
1493 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
1494
1495         Reviewed by Tor Arne Vestbø.
1496
1497         [Qt] Review the setUserPermission & friends API
1498         https://bugs.webkit.org/show_bug.cgi?id=46810
1499
1500         Renamed requestPermissionFromUser to featurePermissionRequested
1501         and cancelRequestsForPermission to featurePermissionRequestCanceled.
1502
1503         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1504         (WebCore::WebPage::WebPage):
1505         * QtTestBrowser/webpage.cpp:
1506         (WebPage::WebPage):
1507         (WebPage::featurePermissionRequestCanceled):
1508         * QtTestBrowser/webpage.h:
1509
1510 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
1511
1512         Reviewed by Tor Arne Vestbø.
1513
1514         [Qt] Review the setUserPermission & friends API
1515         https://bugs.webkit.org/show_bug.cgi?id=46810
1516
1517         Rename setUserPermission to setFeaturePermission
1518
1519         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1520         (WebCore::WebPage::requestPermission):
1521         (WebCore::WebPage::permissionSet):
1522         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1523         (LayoutTestController::grantDesktopNotificationPermission):
1524         * QtTestBrowser/webpage.cpp:
1525         (WebPage::requestPermission):
1526
1527 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
1528
1529         Reviewed by Tor Arne Vestbø.
1530
1531         [Qt] Review the setUserPermission & friends API
1532         https://bugs.webkit.org/show_bug.cgi?id=46810
1533
1534         Rename PermissionDomain to Feature, NotificationsPermissionDomain to Notifications
1535         and GeolocationPermissionDomain to Geolocation.
1536
1537         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1538         (WebCore::WebPage::WebPage):
1539         (WebCore::WebPage::requestPermission):
1540         (WebCore::WebPage::cancelPermission):
1541         (WebCore::WebPage::permissionSet):
1542         (WebCore::DumpRenderTree::geolocationPermissionSet):
1543         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1544         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1545         (LayoutTestController::grantDesktopNotificationPermission):
1546         * QtTestBrowser/webpage.cpp:
1547         (WebPage::WebPage):
1548         (WebPage::requestPermission):
1549         (WebPage::cancelRequestsForPermission):
1550         * QtTestBrowser/webpage.h:
1551
1552 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
1553
1554         Reviewed by Tor Arne Vestbø.
1555
1556         [Qt] Review the setUserPermission & friends API
1557         https://bugs.webkit.org/show_bug.cgi?id=46810
1558
1559         Add a ByUser suffix to PermissionGranted/Denied. In the future
1560         we can add PermissionGrantedByDefault.
1561
1562
1563         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1564         (WebCore::WebPage::requestPermission):
1565         (WebCore::WebPage::permissionSet):
1566         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1567         (LayoutTestController::grantDesktopNotificationPermission):
1568         * QtTestBrowser/webpage.cpp:
1569         (WebPage::requestPermission):
1570
1571 2010-11-18  Satish Sampath  <satish@chromium.org>
1572
1573         Reviewed by Jeremy Orlow.
1574
1575         For speech input event, send an event object containing all the recognition results and metadata.
1576         https://bugs.webkit.org/show_bug.cgi?id=49736
1577
1578         Updated DRT by renaming the mock result method on all platforms to the new signature.
1579
1580         * DumpRenderTree/LayoutTestController.cpp:
1581         (addMockSpeechInputResultCallback):
1582         (LayoutTestController::staticFunctions):
1583         * DumpRenderTree/LayoutTestController.h:
1584         * DumpRenderTree/chromium/LayoutTestController.cpp:
1585         (LayoutTestController::LayoutTestController):
1586         (LayoutTestController::addMockSpeechInputResult):
1587         * DumpRenderTree/chromium/LayoutTestController.h:
1588         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1589         (LayoutTestController::addMockSpeechInputResult):
1590         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1591         (LayoutTestController::addMockSpeechInputResult):
1592         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1593         (LayoutTestController::addMockSpeechInputResult):
1594         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1595         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1596         (LayoutTestController::addMockSpeechInputResult):
1597         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1598         (LayoutTestController::addMockSpeechInputResult):
1599
1600 2010-11-22  Dirk Pranke  <dpranke@chromium.org>
1601
1602         Reviewed by Tony Chang.
1603
1604         Fix some spacing issues with log messages with
1605         new-run-webkit-tests --verbose.
1606
1607         https://bugs.webkit.org/show_bug.cgi?id=49936
1608
1609         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1610
1611 2010-11-22  Ojan Vafai  <ojan@chromium.org>
1612
1613         Reviewed by Adam Barth.
1614
1615         update scm to work with different remote branches
1616         https://bugs.webkit.org/show_bug.cgi?id=49949
1617
1618         This works if there are multiple svn tracking branches
1619         and/or if the tracking branch is refs/remots/origin/master
1620         instead of refs/remotes/trunk which is the direction we're trying
1621         to head since that makes fetches faster.
1622
1623         * Scripts/webkitpy/common/checkout/scm.py:
1624         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1625
1626 2010-11-22  Hayato Ito  <hayato@chromium.org>
1627
1628         Reviewed by Shinichiro Hamaji.
1629
1630         Ignore reference files which will be used by reftests when collecting
1631         test cases.
1632         https://bugs.webkit.org/show_bug.cgi?id=49835
1633
1634         * Scripts/webkitpy/layout_tests/port/test_files.py:
1635         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1636
1637 2010-11-22  Adam Roben  <aroben@apple.com>
1638
1639         Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files
1640
1641         Apple's Windows build allows placing header files and import libraries for WebKit's
1642         dependencies (CoreGraphics, CFNetwork, SQLite, etc.) outside the source tree via the
1643         $WebKitLibrariesDir environment variable. This is both required for production builds and
1644         convenient for Apple-internal developer builds. Apple's production builds also require that
1645         WebKit's shared .vsprops files be accessed relative to $WebKitLibrariesDir. In production
1646         builds, the files are copied into that directory tree by the
1647         WebKitLibraries/win/tools/WinTools.make file. In Apple-internal developer builds, the
1648         copying is done by
1649         JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make.
1650
1651         This .vsprops copying is problematic in one very important case: when a developer updates
1652         their source tree and then tries to build. Visual Studio only reads .vsprops files when a
1653         project is first loaded. So, when Visual Studio is first opened after the .vsprops files are
1654         updated, it reads in the old files that were already residing in $WebKitLibrariesDir. When a
1655         build is started, JavaScriptCoreGenerated.make copies the new .vsprops files into
1656         $WebKitLibrariesDir, but Visual Studio will not pick up the changes.  The rest of the build
1657         will proceed with out-of-date .vsprops files, which will likely result in a build failure.
1658
1659         To fix this, we now use normal relative paths to access the .vsprops files in the source
1660         tree rather than in $WebKitLibrariesDir, but prefix those paths with a new environment
1661         variable, $WebKitVSPropsRedirectionDir. In developer builds, this environment variable is
1662         unset, so the normal relative paths are used to read the .vsprops files out of the source
1663         tree directly. In production builds, this environment variable is set to a fake directory
1664         that will cause the .vsprops files in $WebKitLibrariesDir to be found when the relative path
1665         is resolved.
1666         
1667         For example, JavaScriptCore.vcproj uses this path for FeatureDefines.vsprops:
1668
1669         $(WebKitVSPropsRedirectionDir)..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
1670
1671         In developer builds, where $WebKitVSPropsRedirectionDir is unset, this will point to the
1672         files in WebKitLibraries\win\tools\vsprops in the source tree. In production builds,
1673         JavaScriptCore.make sets $WebKitVSPropsRedirectionDir to
1674         "$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\", so the full path for
1675         FeatureDefines.vsprops becomes:
1676
1677         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
1678
1679         which resolves to:
1680
1681         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
1682
1683         (We rely on the fact that Windows doesn't care whether the directories "1", "2", and "3"
1684         actually exist since they are matched by an equal number of ".." path components.)
1685
1686         Note that Visual Studio still won't pick up changes made to .vsprops files while Visual
1687         Studio is open, but that problem hasn't seemed to cause developers many headaches so far.
1688
1689         Fixes <http://webkit.org/b/49181> Windows build fails mysteriously when .vsprops files are
1690         updated
1691
1692         Reviewed by Dave Hyatt.
1693
1694         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1695         * DumpRenderTree/win/DumpRenderTree.vcproj:
1696         * DumpRenderTree/win/ImageDiff.vcproj:
1697         * FindSafari/FindSafari.vcproj:
1698         * MiniBrowser/MiniBrowser.vcproj:
1699         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1700         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
1701         * WebKitAPITest/WebKitAPITest.vcproj:
1702         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1703         * WebKitTestRunner/win/InjectedBundle.vcproj:
1704         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1705         * WinLauncher/WinLauncher.vcproj:
1706         * record-memory-win/record-memory-win.vcproj:
1707         Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
1708         files.
1709
1710 2010-11-22  Adam Roben  <aroben@apple.com>
1711
1712         Make it possible to run tests on Windows without Visual Studio or VC++
1713         Express installed
1714
1715         webkitdir.pm::setupCygwinEnv dies when Visual Studio and VC++ Express
1716         are not installed. But this function doesn't need to be called when we
1717         already have a build available and are just trying to run the tests.
1718
1719         Fixes <http://webkit.org/b/49932> New Windows 7 bot can't run tests
1720         because Visual Studio/VC++ Express aren't installed
1721
1722         Reviewed by Dave Hyatt.
1723
1724         * Scripts/webkitdirs.pm:
1725         (determineConfigurationForVisualStudio): Don't call setupCygwinEnv, as
1726         it is not needed by this function. Also added a FIXME.
1727
1728         (usingVisualStudioExpress): Call setupCygwinEnv directly rather than
1729         relying on determineConfigurationForVisualStudio doing it.
1730
1731 2010-11-19  Hayato Ito  <hayato@chromium.org>
1732
1733         Reviewed by Shinichiro Hamaji.
1734
1735         Simplify Driver.run_test() so that it takes only one parameter, TestInput.
1736
1737         https://bugs.webkit.org/show_bug.cgi?id=49812
1738
1739         * Scripts/webkitpy/layout_tests/driver_test.py:
1740         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1741         * Scripts/webkitpy/layout_tests/port/base.py:
1742         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1743         * Scripts/webkitpy/layout_tests/port/chromium.py:
1744         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1745         * Scripts/webkitpy/layout_tests/port/test.py:
1746         * Scripts/webkitpy/layout_tests/port/webkit.py:
1747         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1748         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1749
1750 2010-11-22  Hayato Ito  <hayato@chromium.org>
1751
1752         Reviewed by Tony Chang.
1753
1754         [NRWT] Retry a few times in reading a png image to avoid a race condition.
1755
1756         https://bugs.webkit.org/show_bug.cgi?id=49924
1757
1758         * Scripts/webkitpy/layout_tests/port/chromium.py:
1759
1760 2010-11-22  João Paulo Rechi Vita  <jprvita@profusion.mobi>
1761
1762         Reviewed by Kenneth Rohde Christiansen.
1763
1764         Fix EWebLauncher zoom discretization
1765         https://bugs.webkit.org/show_bug.cgi?id=49810
1766
1767         * EWebLauncher/main.c:
1768         (nearest_zoom_level_get):
1769         (zoom_level_set):
1770         (on_load_finished):
1771         (on_key_down):
1772
1773 2010-11-21  Sam Weinig  <sam@webkit.org>
1774
1775         Rubber-stamped by Dan Bernstein.
1776
1777         Fix ~300 WebKit2 tests by enabling developer extras preference.
1778
1779         * WebKitTestRunner/TestController.cpp:
1780         (WTR::TestController::resetStateToConsistentValues):
1781
1782 2010-11-21  Sam Weinig  <sam@webkit.org>
1783
1784         Reviewed by Dan Bernstein.
1785
1786         Textareas should be resizable by default
1787         https://bugs.webkit.org/show_bug.cgi?id=49892
1788
1789         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1790         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp: Added.
1791         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1792         Add preferences test.
1793
1794 2010-11-19  Mihai Parparita  <mihaip@chromium.org>
1795
1796         Reviewed by Tony Chang.
1797
1798         Rebaseline server: checksum-only differences and prefetching
1799         https://bugs.webkit.org/show_bug.cgi?id=49841
1800         
1801         Add support for image test results where the only difference is in the
1802         checksum.
1803         
1804         Add prefetching of the image results from the next test.
1805         
1806         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1807         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1808         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1809
1810 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
1811
1812         Reviewed by Tony Chang.
1813
1814         nrwt multiprocessing - add 'worker number' concept, move stuff to worker thread
1815
1816         Add the 'worker number' and 'worker name' concepts to the 
1817         TestShellThread objects, and move test_types and test_args from
1818         the TestRunner to the TestShellThread.
1819
1820         https://bugs.webkit.org/show_bug.cgi?id=49768
1821
1822         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1823         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1824
1825 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
1826
1827         Reviewed by Ojan Vafai.
1828
1829         Do some minor cleanup and bug fixing.
1830
1831         https://bugs.webkit.org/show_bug.cgi?id=49777
1832
1833         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1834         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1835
1836 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
1837
1838         Reviewed by Ojan Vafai.
1839
1840         nrwt - config.build_directory() is busted
1841
1842         Fixes a typo that was causing us to usually return the top level
1843         directory WebKitBuild instead of WebKitBuild/{Debug,Release}. The
1844         bug was hidden by test stubs that were too simplistic :(.
1845
1846         https://bugs.webkit.org/show_bug.cgi?id=49815
1847
1848         * Scripts/webkitpy/common/system/executive_mock.py:
1849         * Scripts/webkitpy/layout_tests/port/config.py:
1850         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1851
1852 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
1853
1854         Reviewed by Adam Roben.
1855
1856         Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
1857         https://bugs.webkit.org/show_bug.cgi?id=49819
1858
1859         * DumpRenderTree/DumpRenderTree.sln:
1860         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1861         * DumpRenderTree/win/DumpRenderTree.vcproj:
1862         * DumpRenderTree/win/ImageDiff.vcproj:
1863         * FindSafari/FindSafari.vcproj:
1864         * MiniBrowser/MiniBrowser.vcproj:
1865         * TestWebKitAPI/win/TestWebKitAPI.sln:
1866         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1867         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
1868         * WebKitAPITest/WebKitAPITest.vcproj:
1869         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1870         * WebKitTestRunner/win/InjectedBundle.vcproj:
1871         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
1872         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1873         * WinLauncher/WinLauncher.vcproj:
1874         * record-memory-win/record-memory-win.vcproj:
1875
1876 2010-11-19  Adam Roben  <aroben@apple.com>
1877
1878         Add some more Windows slaves
1879
1880         This is probably more than we will be using in the immediate future,
1881         but having some extra slave names makes experimenting with different
1882         configurations easier.
1883
1884         Reviewed by Jon Honeycutt.
1885
1886         * BuildSlaveSupport/build.webkit.org-config/config.json: Added 5 more
1887         Windows slaves and distributed them among the three different Test
1888         builders.
1889
1890 2010-11-19  Kinuko Yasuda  <kinuko@chromium.org>
1891
1892         Reviewed by Ojan Vafai.
1893
1894         [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
1895         https://bugs.webkit.org/show_bug.cgi?id=49702
1896
1897         Re-landing r72357 with a test fix.
1898
1899         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1900         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1901         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1902
1903 2010-11-19  Avi Drissman  <avi@google.com>
1904
1905         Reviewed by Antonio Gomes.
1906
1907         Complete support for Unix editing mode
1908         https://bugs.webkit.org/show_bug.cgi?id=49757
1909
1910         * DumpRenderTree/LayoutTestController.cpp:
1911         (setEditingBehaviorCallback):
1912         * DumpRenderTree/chromium/LayoutTestController.cpp:
1913         (LayoutTestController::setEditingBehavior):
1914
1915 2010-11-19  Adam Roben  <aroben@apple.com>
1916
1917         Fix run-javascriptcore-tests when there's a space in the path to
1918         testapi
1919
1920         Reviewed by Sam Weinig.
1921
1922         * Scripts/run-javascriptcore-tests: Use an indirect object when calling
1923         system() to force it to interpret spaces in the path correctly.
1924
1925 2010-11-19  Adam Roben  <aroben@apple.com>
1926
1927         Update scripts for .exe name changes after r72327
1928
1929         As of r72327, the "_debug" suffix is only used in Debug_All builds.
1930
1931         Reviewed by Sam Weinig.
1932
1933         * Scripts/run-javascriptcore-tests:
1934         (testapiPath):
1935
1936         * Scripts/sunspider-compare-results:
1937         (pathToBuiltJSC):
1938
1939         * Scripts/webkitdirs.pm:
1940         (jscPath):
1941         (safariPath):
1942
1943 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
1944
1945         Reviewed by Darin Adler.
1946
1947         Normalize Cairo/CFLite project/solution configuration names
1948         https://bugs.webkit.org/show_bug.cgi?id=49818
1949
1950         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1951         * DumpRenderTree/win/DumpRenderTree.vcproj:
1952         * DumpRenderTree/win/ImageDiff.vcproj:
1953         * MiniBrowser/MiniBrowser.vcproj:
1954         * TestWebKitAPI/win/TestWebKitAPI.sln:
1955         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1956         * WebKitAPITest/WebKitAPITest.vcproj:
1957         * WebKitTestRunner/win/InjectedBundle.vcproj:
1958         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1959         * WinLauncher/WinLauncher.vcproj:
1960         * Scripts/webkitdirs.pm: Updated cairo build configs.
1961
1962 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
1963
1964         Reviewed by Adam Roben.
1965
1966         Windows vcproj configuration names should be normalized across projects
1967         https://bugs.webkit.org/show_bug.cgi?id=49776
1968
1969         * DumpRenderTree/DumpRenderTree.sln:
1970         * FindSafari/FindSafari.vcproj:
1971         * TestWebKitAPI/win/TestWebKitAPI.sln:
1972         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
1973         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added.
1974         * WebKitAPITest/WebKitAPITest.vcproj:
1975         * WebKitAPITest/WebKitAPITestCommon.vsprops:
1976         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1977         * WebKitTestRunner/WebKitTestRunner.sln:
1978         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
1979         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added.
1980         * record-memory-win/record-memory-win.vcproj:
1981
1982 2010-11-18  Gavin Barraclough  <barraclough@apple.com>
1983
1984         Build fix - as per DRT-mac, always enabled developer extras,
1985         in win/qt/gtk DRT.
1986
1987         This is necessary to enable rich exception messages to be generated
1988         following https://bugs.webkit.org/show_bug.cgi?id=49708.
1989
1990         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1991         (shouldEnableDeveloperExtras):
1992         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1993         (WebCore::shouldEnableDeveloperExtras):
1994         * DumpRenderTree/win/DumpRenderTree.cpp:
1995         (shouldEnableDeveloperExtras):
1996
1997 2010-11-18  Sheriff Bot  <webkit.review.bot@gmail.com>
1998
1999         Unreviewed, rolling out r72357.
2000         http://trac.webkit.org/changeset/72357
2001         https://bugs.webkit.org/show_bug.cgi?id=49784
2002
2003         It broke test-webkitpy tests since the patch didn't have the
2004         corresponding test update (Requested by kinuko on #webkit).
2005
2006         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2007         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2008
2009 2010-11-18  Mihai Parparita  <mihaip@chromium.org>
2010
2011         Reviewed by Tony Chang.
2012
2013         Rebaseline server: add rebaseline queue
2014         https://bugs.webkit.org/show_bug.cgi?id=49763
2015         
2016         Add a UI queue (a multi-item <select>) where tests to be baselined
2017         can be enqueued (also supports basic removal). A queue is used instead
2018         of immediately doing rebaselines since SCM operations can take a while.
2019         It's better to go through lots of tests quickly to mark them as
2020         needing rebaselining and then batch the SCM operations.
2021         
2022         Also adds a simple log where results can be displayed.
2023
2024         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
2025         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2026         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2027         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js: Added.
2028         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
2029         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2030
2031 2010-11-18  Gavin Barraclough  <barraclough@apple.com>
2032
2033         Reviewed by Oliver Hunt.
2034
2035         Bug 49708 - Stop recompiling functions to regenerate exception info.
2036
2037         Instead only hold info as necessary – keep divot info is the inspector
2038         is enabled, line number info is debugging or profiling, and handler
2039         info for functions with try/catch.
2040
2041         * DumpRenderTree/mac/DumpRenderTree.mm:
2042         (shouldEnableDeveloperExtras):
2043             - always enable the developer tools from DRT, to ensure we
2044               produce rich error messages on JavaScript exceptions.
2045
2046 2010-11-18  Kinuko Yasuda  <kinuko@chromium.org>
2047
2048         Reviewed by Ojan Vafai.
2049
2050         [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
2051         https://bugs.webkit.org/show_bug.cgi?id=49702
2052
2053         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2054         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2055
2056 2010-11-18  Dirk Pranke  <dpranke@chromium.org>
2057
2058         Reviewed by Tony Chang.
2059
2060         new-run-webkit-tests: create first part of 'message_broker' class for multiprocessing fixes
2061
2062         Create the first version of the 'message_broker' package. This
2063         class will encapsulate all of the threading/multiprocessing and
2064         message-sending details for the communication between the
2065         'manager' object and the 'worker' objects. For the moment, it
2066         just holds some routines and tests for logging thread stacks.
2067
2068         There should be no functional changes in this patch, just moving stuff
2069         around.
2070
2071         https://bugs.webkit.org/show_bug.cgi?id=49707
2072
2073         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2074         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Removed.
2075         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Added.
2076         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: Added.
2077         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2078         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2079
2080 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
2081
2082         Reviewed by Adam Roben.
2083
2084         Remove leftover Windows Debug_Internal configurations
2085         https://bugs.webkit.org/show_bug.cgi?id=49758
2086
2087         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2088         * DumpRenderTree/win/DumpRenderTree.vcproj:
2089         * DumpRenderTree/win/ImageDiff.vcproj:
2090         * MiniBrowser/MiniBrowser.vcproj:
2091         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2092         * WebKitAPITest/WebKitAPITest.vcproj:
2093         * WebKitTestRunner/win/InjectedBundle.vcproj:
2094         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2095         * WinLauncher/WinLauncher.vcproj:
2096
2097 2010-11-18  Adam Roben  <aroben@apple.com>
2098
2099         Add three new Windows XP build slaves
2100
2101         Reviewed by Steve Falkenburg.
2102
2103         * BuildSlaveSupport/build.webkit.org-config/config.json: Added three
2104         new slaves, and added them to the Windows XP Debug (Tests) builder.
2105
2106 2010-11-18  Daniel Bates  <dbates@rim.com>
2107
2108         Reviewed by Adam Roben.
2109
2110         update-webkit-support-libs should fall back to existing
2111         WebKitSupportLibrary version if there is no internet connectivity
2112         https://bugs.webkit.org/show_bug.cgi?id=49503
2113
2114         Fall back to existing support libraries (if present) when there is
2115         no internet connection.
2116
2117         Currently, update-webkit-support-libs dies with an "out-of-date"
2118         error when there is no internet connection because it cannot
2119         retrieve versioning information from developer.apple.com. Because
2120         update-webkit-support-libs fails, build-webkit fails. Instead,
2121         if there is no internet connection and the support libraries are
2122         present then we should warn the user and exit() with success so
2123         that build-webkit can work without an internet connection.
2124
2125         * Scripts/update-webkit-support-libs:
2126
2127 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
2128
2129         Reviewed by Adam Roben.
2130
2131         Debug_Internal Windows configuration is unnecessary, should be removed
2132         https://bugs.webkit.org/show_bug.cgi?id=49753
2133
2134         * DumpRenderTree/win/DumpRenderTree.cpp:
2135         * MiniBrowser/win/stdafx.h:
2136         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2137         * WebKitTestRunner/win/TestControllerWin.cpp:
2138
2139 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
2140
2141         Reviewed by Adam Roben.
2142
2143         Clean up vcproj errors
2144         https://bugs.webkit.org/show_bug.cgi?id=49741
2145
2146         * MiniBrowser/MiniBrowser.vcproj:
2147         * WebKitAPITest/WebKitAPITest.vcproj:
2148         * WebKitTestRunner/win/InjectedBundle.vcproj:
2149         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2150
2151 2010-11-18  Hayato Ito  <hayato@chromium.org>
2152
2153         Reviewed by Shinichiro Hamaji.
2154
2155         [NRWT] Fix a break of '--new-baseline' feature in pixel_test
2156         which is caused by r72249.
2157
2158         https://bugs.webkit.org/show_bug.cgi?id=49751
2159
2160         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2161
2162 2010-11-18  Adam Roben  <aroben@apple.com>
2163
2164         Implement layoutTestController.waitForPolicyDelegate on Windows
2165
2166         Fixes <http://webkit.org/b/25038> <rdar://problem/6790213>.
2167
2168         Reviewed by Simon Fraser.
2169
2170         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2171         (LayoutTestController::waitForPolicyDelegate): Implemented by porting
2172         code from LayoutTestControllerMac.mm.
2173
2174 2010-11-18  Hayato Ito  <hayato@chromium.org>
2175
2176         Reviewed by Shinichiro Hamaji.
2177
2178         [NRWT] Fix a break of '--new-baseline' feature which is caused by r72249.
2179
2180         https://bugs.webkit.org/show_bug.cgi?id=49740
2181
2182         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2183
2184 2010-11-18  Tony Chang  <tony@chromium.org>
2185
2186         Reviewed by Adam Barth.
2187
2188         run platform/chromium/plugins/refcount-leaks.html on all platforms
2189         https://bugs.webkit.org/show_bug.cgi?id=49485
2190
2191         Add PluginObject.testObjectCount which returns the number of allocated
2192         TestObjects. Add PluginObject.testCreateTestObject which allocates
2193         and returns a TestObject.
2194
2195         Add TestObject.refCount which returns the number of refs on the
2196         TestObject.
2197
2198         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2199         (pluginGetProperty):
2200         (pluginInvoke):
2201         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
2202         (getTestObjectCount):
2203         (testAllocate):
2204         (testDeallocate):
2205         (testGetProperty):
2206         (testScriptObjectInvoke): Release a ref to a plugin object that was
2207             previously leaked.
2208         * DumpRenderTree/TestNetscapePlugIn/TestObject.h:
2209
2210 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
2211
2212         Reviewed by Adam Roben.
2213
2214         WebKitTools projects (WebKitTestRunner, record-memory-win) should use vsprops for common build settings
2215         https://bugs.webkit.org/show_bug.cgi?id=49711
2216
2217         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added.
2218         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added.
2219         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added.
2220         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2221         * record-memory-win/record-memory-win-common.vsprops: Added.
2222         * record-memory-win/record-memory-win.vcproj:
2223
2224 2010-11-18  Andras Becsi  <abecsi@inf.u-szeged.hu>
2225
2226         Reviewed by Csaba Osztrogonác.
2227
2228         [Qt][WK2] Only add user agent strings to the list which aren't listed yet.
2229
2230         * MiniBrowser/qt/BrowserWindow.cpp:
2231         (BrowserWindow::updateUserAgentList):
2232
2233 2010-11-17  Adam Roben  <aroben@apple.com>
2234
2235         Don't trigger Windows builds when chromium-win test results change
2236
2237         Reviewed by Mark Rowe.
2238
2239         * Scripts/webkitpy/common/config/build.py:
2240         (_should_file_trigger_build): Changed the regular expression used to
2241         search for directory names to only consider full directory names,
2242         rather than matching directory names where the string we care about is
2243         a suffix of the name.
2244
2245         * Scripts/webkitpy/common/config/build_unittest.py:
2246         (ShouldBuildTest): Added a test.
2247
2248 2010-11-17  Hayato Ito  <hayato@chromium.org>
2249
2250         Reviewed by Shinichiro Hamaji.
2251
2252         Remove a uri member from TestInput class.
2253
2254         https://bugs.webkit.org/show_bug.cgi?id=49691
2255
2256         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2257         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2258
2259 2010-11-17  Adam Roben  <aroben@apple.com>
2260
2261         Move FindSafari's settings into a vsprops file
2262
2263         Fixes <http://webkit.org/b/49699> FindSafari should use a vsprops file
2264
2265         Reviewed by Steve Falkenburg.
2266
2267         * FindSafari/FindSafari.vcproj:
2268         * FindSafari/FindSafariCommon.vsprops: Added.
2269
2270 2010-11-17  Adam Roben  <aroben@apple.com>
2271
2272         Use a minimum font size of 0 in DRT on Windows
2273
2274         This is the Windows equivalent of r72164.
2275
2276         Rubber-stamped by Dave Hyatt.
2277
2278         * DumpRenderTree/win/DumpRenderTree.cpp:
2279         (resetDefaultsToConsistentValues):
2280
2281 2010-11-17  Dirk Pranke  <dpranke@chromium.org>
2282
2283         Reviewed by Andreas Kling.
2284
2285         webkit-patch pretty-diff shouldn't need to be run from a checkout root in git
2286         https://bugs.webkit.org/show_bug.cgi?id=49639
2287
2288         * Scripts/webkitpy/common/checkout/scm.py:
2289
2290 2010-11-17  Mihai Parparita  <mihaip@chromium.org>
2291
2292         Reviewed by Tony Chang.
2293
2294         Rebaseline server: add loupe for image diffs
2295         https://bugs.webkit.org/show_bug.cgi?id=49692
2296         
2297         Add a loupe (magnifiying glass) for inspecting image diffs. Shows an
2298         enlarged area of the expected, actual and diff images side by side.
2299
2300         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
2301         * Scripts/webkitpy/tool/commands/data/rebaselineserver/loupe.js: Added.
2302         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2303         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2304
2305 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
2306
2307         Reviewed by Adam Roben.
2308
2309         WebKitLauncherWin should use vsprops for shared build settings
2310         https://bugs.webkit.org/show_bug.cgi?id=49696
2311
2312         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
2313         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added.
2314
2315 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
2316
2317         Reviewed by Adam Roben.
2318
2319         WinLauncher should use vsprops for shared build settings
2320         https://bugs.webkit.org/show_bug.cgi?id=49695
2321
2322         * WinLauncher/WinLauncher.cpp:
2323         (_tWinMain):
2324         (PrintView):
2325         (WndProc):
2326         (MyEditProc):
2327         * WinLauncher/WinLauncher.vcproj:
2328         * WinLauncher/WinLauncherCommon.vsprops: Added.
2329
2330 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
2331
2332         Delete unused file unintentionally added in last change.
2333
2334         * DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Removed.
2335
2336 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
2337
2338         Reviewed by Adam Roben.
2339
2340         DumpRenderTree on Windows should use a vsprops file for shared project settings
2341         https://bugs.webkit.org/show_bug.cgi?id=49690
2342
2343         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2344         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added.
2345         * DumpRenderTree/win/DumpRenderTree.vcproj:
2346         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added.
2347         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added.
2348         * DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Added.
2349         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added.
2350         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added.
2351         * DumpRenderTree/win/ImageDiff.vcproj:
2352         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added.
2353
2354 2010-11-17  Hayato Ito  <hayato@chromium.org>
2355
2356         Refactor TestTypeBase.compare_output().
2357
2358         Introduce a TestOutput class and update compare_output() of each test
2359         types so that they can take both actual and expected TestOutput objects.
2360
2361         https://bugs.webkit.org/show_bug.cgi?id=49431
2362
2363         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2364         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Added.
2365         * Scripts/webkitpy/layout_tests/port/base.py:
2366         * Scripts/webkitpy/layout_tests/port/chromium.py:
2367         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2368         * Scripts/webkitpy/layout_tests/port/test.py:
2369         * Scripts/webkitpy/layout_tests/port/webkit.py:
2370         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2371         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2372         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2373         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2374
2375 2010-11-17  Adam Roben  <aroben@apple.com>
2376
2377         Make each Windows Test builder use the same OS for all its slaves
2378
2379         Currently each WebKit1 Windows Test builder has one Windows XP slave
2380         and one Windows 7 slave. Having different OSes in a single builder
2381         meant that the builders would alternate between red and green when
2382         there were OS-specific failures.
2383
2384         Fixes <http://webkit.org/b/49688> Windows Test builders alternate
2385         between red and green because of multiple OS versions
2386
2387         Reviewed by Mark Rowe.
2388
2389         * BuildSlaveSupport/build.webkit.org-config/config.json: Renamed
2390         "Windows Release (Tests)" to "Windows 7 Release (Tests)", "Windows
2391         Debug (Tests)" to "Windows XP Debug (Tests)", and "Windows Release
2392         (WebKit2 Tests)" to "Windows 7 Release (WebKit2 Tests)". Updated the
2393         builders for the two WebKit1 builders so that they would all use the
2394         appropriate OS.
2395
2396 2010-11-17  James Robinson  <jamesr@chromium.org>
2397
2398         Reviewed by Dan Bernstein.
2399
2400         [chromium] Set minimum font size to 0 for DRT
2401         https://bugs.webkit.org/show_bug.cgi?id=49677
2402
2403         Followup for http://trac.webkit.org/changeset/72141.
2404
2405         Test: http/tests/misc/acid3.html
2406
2407         * DumpRenderTree/chromium/WebPreferences.cpp:
2408         (WebPreferences::reset):
2409
2410 2010-11-17  Andras Becsi  <abecsi@webkit.org>
2411
2412         Unreviewed build fix.
2413
2414         [Qt] Add missing file I forgot in r72220.
2415
2416         * MiniBrowser/MiniBrowser.qrc: Added.
2417
2418 2010-11-17  Andras Becsi  <abecsi@webkit.org>
2419
2420         Reviewed by Andreas Kling.
2421
2422         [Qt][WK2] Make it possible to set custom user agent strings in MiniBrowser.
2423         https://bugs.webkit.org/show_bug.cgi?id=49627
2424
2425         Add a user agent dialog and a resource file for useragentlist.txt to MiniBrowser.
2426
2427         * MiniBrowser/MiniBrowser.qrc: Added.
2428         Add it here to prevent qmake from detecting it
2429         since it needs to be copied to the build directory.
2430         * MiniBrowser/qt/BrowserWindow.cpp:
2431         (BrowserWindow::BrowserWindow):
2432         (BrowserWindow::updateUserAgentList):
2433         (BrowserWindow::showUserAgentDialog):
2434         * MiniBrowser/qt/BrowserWindow.h:
2435         * MiniBrowser/qt/MiniBrowser.pro:
2436
2437 2010-11-17  Adam Roben  <aroben@apple.com>
2438
2439         Make changes to the Mac WebKit2 Skipped file trigger Windows builds
2440
2441         We use that file on Windows!
2442
2443         Fixes <http://webkit.org/b/49643> Changes to
2444         LayoutTests/platform/mac-wk2 should trigger a Windows build, but don't
2445
2446         Reviewed by Steve Falkenburg.
2447
2448         * Scripts/webkitpy/common/config/build.py:
2449         (_should_file_trigger_build): Added the mac-wk2 directory and make it
2450         trigger builds on SnowLeopard and Windows.
2451
2452         * Scripts/webkitpy/common/config/build_unittest.py:
2453         (ShouldBuildTest.test_should_build): Added a test.
2454
2455 2010-11-17  Satish Sampath  <satish@chromium.org>
2456
2457         Reviewed by Jeremy Orlow.
2458
2459         Clear the speech input mock explicitly before each test.
2460         https://bugs.webkit.org/show_bug.cgi?id=49660
2461
2462         * DumpRenderTree/chromium/LayoutTestController.cpp:
2463         (LayoutTestController::setMockSpeechInputResult):
2464         * DumpRenderTree/chromium/LayoutTestController.h:
2465         * DumpRenderTree/chromium/WebViewHost.cpp:
2466         (WebViewHost::speechInputController):
2467         (WebViewHost::reset): Invoke speech input mock's clearResults method.
2468         * DumpRenderTree/chromium/WebViewHost.h:
2469         (WebViewHost::speechInputControllerMock): Moved mock from LayoutTestController.
2470
2471 2010-11-17  Alexander Pavlov  <apavlov@chromium.org>
2472
2473         Unreviewed, specify IRC nickname in committers.py.
2474
2475         * Scripts/webkitpy/common/config/committers.py:
2476
2477 2010-11-17  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2478
2479         Reviewed by Tony Chang.
2480
2481         [NRWT] Make http locking similar to perl implementation
2482         https://bugs.webkit.org/show_bug.cgi?id=49187
2483
2484         * Scripts/webkitpy/common/system/file_lock.py: Added.
2485         * Scripts/webkitpy/common/system/file_lock_unittest.py: Added.
2486         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2487
2488 2010-11-17  MORITA Hajime  <morrita@google.com>
2489
2490         Reviewed by Kent Tamura.
2491
2492         [Chromium][DRT] EventSender.contextClick() should aware spellchecking
2493         https://bugs.webkit.org/show_bug.cgi?id=49366
2494
2495         - EvenSender: Checked WebContextMenuData.misspelledWord and added extra context menu entries
2496           according to the spellchecker suggestion
2497         - MockSpellCheck: add fillSuggestionList to provide fake suggestions.
2498
2499         test_expectations.txt will be changed after this change is ported to test_shell.
2500         
2501         * DumpRenderTree/chromium/EventSender.cpp:
2502         (makeMenuItemStringsFor):
2503         (EventSender::contextClick):
2504         * DumpRenderTree/chromium/MockSpellCheck.cpp:
2505         (MockSpellCheck::fillSuggestionList):
2506         (MockSpellCheck::initializeIfNeeded):
2507         * DumpRenderTree/chromium/MockSpellCheck.h:
2508         * DumpRenderTree/chromium/WebViewHost.cpp:
2509         (WebViewHost::mockSpellCheck):
2510         * DumpRenderTree/chromium/WebViewHost.h:
2511
2512 2010-11-16  Dave Hyatt  <hyatt@apple.com>
2513
2514         Reviewed by Sam Weinig.
2515
2516         Make sure the pref for minimum font size is just explicitly set to 0 every time,
2517         since the bots have 1 stuck in their plist otherwise.
2518
2519         * DumpRenderTree/mac/DumpRenderTree.mm:
2520         (resetDefaultsToConsistentValues):
2521
2522 2010-11-16  Mihai Parparita  <mihaip@chromium.org>
2523
2524         Reviewed by Tony Chang.
2525
2526         Rebaseline server: compute diffs client-side
2527         https://bugs.webkit.org/show_bug.cgi?id=49640
2528         
2529         The image diff output from the DRT is pretty bad on some ports (at
2530         least the Mac one), so it's better to compute diffs on the client by
2531         using <canvas>.
2532
2533         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
2534         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2535         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2536
2537 2010-11-16  Mihai Parparita  <mihaip@chromium.org>
2538
2539         Reviewed by Tony Chang.
2540
2541         Rebaseline server: display test results
2542         https://bugs.webkit.org/show_bug.cgi?id=49626
2543         
2544         Adds basic result display to the rebaseline server. On the Python side
2545         this involves:
2546         - Parsing the unexpected_results.json into a dictionary.
2547         - Serving it as JSON under /results.json.
2548         (the JSON -> dict -> JSON transform isn't strictly necessary right now,
2549         but I'll need to have access to the parsed results on the Python side
2550         for follow-up changes).
2551         
2552         On the web UI side this adds:
2553         - Markup for display image and text results (expected, actual, diff),
2554           and JS for populating it.
2555         - Markup for breaking down test results by failure type and directory,
2556           and JS for populating it.
2557
2558         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
2559         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2560         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2561         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js: Added.
2562         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2563
2564 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
2565
2566         Reviewed by Ojan Vafai.
2567
2568         See Chromium issue http://codereview.chromium.org/5133001/ - we
2569         are modifying the build bots to pass in the builder name with
2570         the "GPU" string appended instead of appending it in the code.
2571
2572         https://bugs.webkit.org/show_bug.cgi?id=49636
2573
2574         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2575
2576 2010-11-16  Steve Falkenburg  <sfalken@apple.com>
2577
2578         Reviewed by Adam Roben.
2579
2580         Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
2581         https://bugs.webkit.org/show_bug.cgi?id=49632
2582
2583         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2584         * DumpRenderTree/win/DumpRenderTree.vcproj:
2585         * DumpRenderTree/win/ImageDiff.vcproj:
2586         * MiniBrowser/MiniBrowser.vcproj:
2587         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2588         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
2589         * WebKitTestRunner/win/InjectedBundle.vcproj:
2590         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2591         * WinLauncher/WinLauncher.vcproj:
2592         * record-memory-win/record-memory-win.vcproj:
2593
2594 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
2595
2596         Reviewed by Ojan Vafai.
2597
2598         new-run-webkit-tests: rename TestInfo to TestInput, move image hash to work thread
2599
2600         Rename the TestInfo class to TestInput to be clearer about its
2601         function, and move the checksum-reading code into dump_render_tree_thread
2602         to avoid cross-thread access.
2603
2604         https://bugs.webkit.org/show_bug.cgi?id=49573
2605
2606         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2607         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2608         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2609
2610 2010-11-16  Dave Hyatt  <hyatt@apple.com>
2611
2612         Fix bustage. Remove the minimum font size pref setting in DumpRenderTree.
2613
2614         * DumpRenderTree/mac/DumpRenderTree.mm:
2615         (resetDefaultsToConsistentValues):
2616
2617 2010-11-16  Stephanie Lewis  <slewis@apple.com>
2618
2619         Reviewed by Geoff Garen.
2620
2621         <rdar://problem/8624267> Leak creating offscreen webview running fast/dom tests
2622
2623         Use shared DeviceOrientationProviderMock. The old allocation method created a new WebDeviceOrientationProviderMock 
2624         for every WebView, and the WebKit API doesn't support that ownership model.
2625
2626         I also fixed a leak in setMockDeviceOrientation by adding a missing release.
2627
2628         * DumpRenderTree/mac/DumpRenderTree.mm:
2629         (createWebViewAndOffscreenWindow):
2630         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2631         (LayoutTestController::setMockDeviceOrientation):
2632
2633 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
2634
2635         Reviewed by Ojan Vafai.
2636
2637         new-run-webkit-tests: log the process id in --verbose mode
2638
2639         As part of the switch to multi-process mode, we should log the
2640         process id when running w/ --verbose.
2641
2642         https://bugs.webkit.org/show_bug.cgi?id=49571
2643
2644         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2645
2646 2010-11-16  Adam Roben  <aroben@apple.com>
2647
2648         Only trigger Windows builds when files that we actually use on Windows
2649         are changed
2650
2651         A new Scheduler subclass, PlatformSpecificScheduler, has been added.
2652         It uses the new webkitpy.common.config.build module to determine
2653         whether a particular change should trigger a build on a particular
2654         platform. The Windows builders have been switched to use a
2655         PlatformSpecificScheduler.
2656
2657         The logic to determine whether or not a particular change should
2658         trigger a build on a given platform has only been implemented/tested
2659         for Windows. I tried to make it easy to add more platforms in the
2660         future, but I don't have enough familiarity with all platforms to be
2661         able to implement it for them.
2662
2663         Fixes <http://webkit.org/b/49407> Windows builders kick off builds for
2664         lots irrelevant changes (e.g., rebaselining Chromium test results)
2665
2666         Reviewed by Eric Seidel.
2667
2668         * BuildSlaveSupport/build.webkit.org-config/config.json: Use a
2669         PlatformSpecificScheduler for the Windows builders.
2670
2671         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2672         (PlatformSpecificScheduler.__init__): Added. Stores our platform, sets
2673         up a ChangeFilter that filters to our branch and will call through to
2674         our filter method, and calls up to our base class.
2675         (PlatformSpecificScheduler.filter): Calls through to
2676         build.should_build to find out whether we should trigger a build for
2677         this change.
2678
2679         * Scripts/webkitpy/common/net/build.py: Added.
2680         (_should_file_trigger_build): Uses a set of directories and regexp
2681         patterns to determine whether the given file should trigger a build on
2682         the given platform. As mentioned earlier, this has only been
2683         implemented for Windows, though I did try to make some guesses about
2684         other platforms.
2685         (should_build): Returns true if any of the files should trigger a
2686         build on the given platform.
2687
2688         * Scripts/webkitpy/common/net/build_unittest.py: Added.
2689         (ShouldBuildTest.test_should_build): Does some basic testing to make
2690         sure we're triggering builds for the right files. It only tests
2691         Windows for now, though I tried to make some guesses about other
2692         platforms.
2693
2694 2010-11-16  Simon Hausmann  <simon.hausmann@nokia.com>
2695
2696         Reviewed by Andreas Kling.
2697
2698         [Qt] Remove synchronous QWebPage::checkPermissions signal
2699         https://bugs.webkit.org/show_bug.cgi?id=46810
2700
2701         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2702         (WebCore::WebPage::WebPage):
2703         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2704         (LayoutTestController::grantDesktopNotificationPermission): When granting
2705         permission, grant it directly on the QWebPage/Frame, that will remember it.
2706         * QtTestBrowser/webpage.cpp:
2707         (WebPage::WebPage):
2708         * QtTestBrowser/webpage.h:
2709
2710
2711 2010-11-16  Andras Becsi  <abecsi@inf.u-szeged.hu>
2712
2713         Reviewed by Csaba Osztrogonác.
2714
2715         [Qt] Add isPrinting and setPrinting methods to DRT's LayoutTestController.
2716
2717         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2718         (LayoutTestController::reset):
2719         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2720         (LayoutTestController::isPrinting):
2721         (LayoutTestController::setPrinting):
2722
2723 2010-11-16  Balazs Kelemen  <kbalazs@webkit.org>
2724
2725         Reviewed by Andreas Kling.
2726
2727         [Qt][WK2] Add a way to turn on tiled backing store in MiniBrowser
2728         https://bugs.webkit.org/show_bug.cgi?id=49587
2729
2730         * MiniBrowser/qt/BrowserView.cpp:
2731         (BrowserView::BrowserView): Added BackingStoreType
2732         argument to ctor. Propagating it to the QGraphicsWKView.
2733         * MiniBrowser/qt/BrowserView.h:
2734         * MiniBrowser/qt/BrowserWindow.cpp:
2735         (BrowserWindow::BrowserWindow):
2736         (BrowserWindow::newWindow): Create the new BrowserWindow
2737         with the same BackingStoreType that this instance has.
2738         * MiniBrowser/qt/BrowserWindow.h: Added BackingStoreType member.
2739         * MiniBrowser/qt/main.cpp:
2740         (main): Use tiled backing store if got -tiled command line argument.
2741         Avoid redundant copy of command line args.
2742
2743 2010-11-16  John Knottenbelt  <jknotten@chromium.org>
2744
2745         Reviewed by Jeremy Orlow.
2746
2747         Move DeviceOrientationClientMock from LayoutTestController to WebViewHost.
2748         https://bugs.webkit.org/show_bug.cgi?id=48506
2749
2750         This ensures that there is one mock per page WebView / WebViewHost. This is a
2751         design constraint of the DeviceOrientationClientMock because the m_controller
2752         field can only store a pointer to a single instance of the corresponding
2753         DeviceOrientationController.
2754
2755         Test: fast/dom/DeviceOrientation/no-page-cache.html
2756
2757         * DumpRenderTree/chromium/LayoutTestController.cpp:
2758         (LayoutTestController::setMockDeviceOrientation):
2759         (LayoutTestController::deviceOrientationClientMock):
2760         * DumpRenderTree/chromium/LayoutTestController.h:
2761         * DumpRenderTree/chromium/WebViewHost.cpp:
2762         (WebViewHost::deviceOrientationClientMock):
2763         (WebViewHost::deviceOrientationClient):
2764         (WebViewHost::reset):
2765         * DumpRenderTree/chromium/WebViewHost.h:
2766
2767 2010-11-15  Andras Becsi  <abecsi@webkit.org>
2768
2769         Reviewed by Andreas Kling.
2770
2771         [Qt][WK2] Avoid polling in WebKitTestRunner.
2772         https://bugs.webkit.org/show_bug.cgi?id=49542
2773
2774         Make the WK2 testing session about 10-15% faster and decrease random flakiness
2775         resulting from timing skew by removing the millisecond polling from TestControllerQt.
2776
2777         * WebKitTestRunner/TestController.cpp:
2778         (WTR::TestController::didFinishLoadForFrame):
2779         * WebKitTestRunner/TestController.h:
2780         * WebKitTestRunner/TestInvocation.cpp:
2781         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2782         * WebKitTestRunner/mac/TestControllerMac.mm:
2783         (WTR::TestController::notifyDone): Add method stub.
2784         * WebKitTestRunner/qt/TestControllerQt.cpp:
2785         (WTR::TestControllerRunLoop::instance):
2786         (WTR::TestControllerRunLoop::start):
2787         (WTR::TestControllerRunLoop::stop):
2788         (WTR::TestControllerRunLoop::TestControllerRunLoop):
2789         (WTR::TestControllerRunLoop::timerEvent):
2790         (WTR::TestController::notifyDone):
2791         (WTR::TestController::platformRunUntil):
2792         * WebKitTestRunner/win/TestControllerWin.cpp:
2793         (WTR::TestController::notifyDone): Add method stub.
2794
2795 2010-11-15  Darin Adler  <darin@apple.com>
2796
2797         * Scripts/webkitpy/common/net/bugzilla: Added property svn:ignore.
2798
2799 2010-11-15  Benjamin Poulain  <benjamin.poulain@nokia.com>
2800
2801         Reviewed by Andreas Kling.
2802
2803         [Qt] [WK2] Add Ctrl+L shortcut to Qt Minibrowser
2804         https://bugs.webkit.org/show_bug.cgi?id=49544
2805
2806         Add the shortcut to BrowserWindow.
2807
2808         * MiniBrowser/qt/BrowserWindow.cpp:
2809         (BrowserWindow::BrowserWindow):
2810         (BrowserWindow::openLocation):
2811         * MiniBrowser/qt/BrowserWindow.h:
2812
2813 2010-11-14  David Levin  <levin@chromium.org>
2814
2815         Reviewed by Daniel Bates.
2816
2817         check-webkit-style should detect PassRefPtr usage in functions.
2818         https://bugs.webkit.org/show_bug.cgi?id=49513
2819
2820         * Scripts/webkitpy/style/checkers/cpp.py:
2821         (check_for_function_lengths): Revert a comment change that I
2822          accidentally made in r71986.
2823         (check_pass_ptr_usage): Added the code to do the check.
2824         (process_line): Added the call to check_pass_ptr_usage.
2825         (CppChecker): Added the new error category.
2826         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2827         (CppStyleTestBase::perform_pass_ptr_check): Runs the new check for
2828          testing purposes.
2829         (PassPtrTest::*): The class/functions to unit test the new
2830          functionality.
2831
2832 2010-11-14  David Levin  <levin@chromium.org>
2833
2834         Reviewed by Shinichiro Hamaji.
2835
2836         check-webkit-style function detection and the line count style checks should be separate.
2837         https://bugs.webkit.org/show_bug.cgi?id=49512
2838
2839         * Scripts/webkitpy/style/checkers/cpp.py: Do the separation.
2840         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Adjust the test to
2841           call the detection function and fix line counts in two places now that
2842           the code really only counts the lines in the body of the function.
2843
2844 2010-11-14  Andreas Kling  <kling@webkit.org>
2845
2846         Reviewed by Antonio Gomes.
2847
2848         http/tests/plugins tests print "Unhandled variable" to stderr under Qt
2849         https://bugs.webkit.org/show_bug.cgi?id=33438
2850
2851         Stifle "Unhandled variable" warning to match what the other
2852         TestNetscapePlugin does (NPP_GetValue in TestNetscapePlugIn/main.cpp
2853         simply returns NPERR_GENERIC_ERROR for unhandled variables.)
2854
2855         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2856         (webkit_test_plugin_get_value):
2857
2858 2010-11-13  David Levin  <levin@chromium.org>
2859
2860         Reviewed by Eric Seidel.
2861
2862         check-webkit-style function detection crashes on functions in templates.
2863         https://bugs.webkit.org/show_bug.cgi?id=49504
2864
2865         For example "template <bool shouldClose(const Element*)>".
2866
2867         * Scripts/webkitpy/style/checkers/cpp.py: If not function is detected, bail out.
2868         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Modified the complex
2869           function detection test to expose this issue.
2870
2871 2010-11-12  David Levin  <levin@chromium.org>
2872
2873         Reviewed by Shinichiro Hamaji.
2874
2875         check-webkit-style function detection doesn't detect indented functions declaractions.
2876         https://bugs.webkit.org/show_bug.cgi?id=49446
2877
2878         Indented function declarations occur inside class definitions, so
2879         they are a pretty common (and worth detecting).
2880
2881         * Scripts/webkitpy/style/checkers/cpp.py:
2882           Changed regex to allow indentation.
2883           Changed the function start detection to only happen when not in a
2884           function.
2885           Changed function end detection to work based on matching braces
2886           instead of finding a close brace at the beginning of the line.
2887           Fixed close_expression to do what it says when it doesn't find
2888           the close.
2889         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Indented function test.
2890
2891 2010-11-12  Daniel Bates  <dbates@rim.com>
2892
2893         Rubber-stamped by Nikolas Zimmermann.
2894
2895         Make do-file-rename rename files in the directory WebKit2.
2896
2897         This also makes the list of searched directories in do-file-rename
2898         consistent with the list of searched directories in the script do-webcore-rename.
2899
2900         * Scripts/do-file-rename:
2901
2902 2010-11-12  Dirk Pranke  <dpranke@chromium.org>
2903
2904         Reviewed by James Robinson.
2905
2906         Attempt yet again to land the fix for bug 49360 (respecting
2907         set-webkit-configuration). We need to handle the cases where
2908         trying to run webkit-build-directory to find out where the
2909         default configuration might be fails (that shows up on some
2910         Chromium bots that apparently don't have perl installed).
2911
2912         https://bugs.webkit.org/show_bug.cgi?id=49360
2913
2914         * Scripts/webkitpy/layout_tests/port/config.py:
2915         * Scripts/webkitpy/layout_tests/port/config_standalone.py: Added.
2916         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2917
2918 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
2919
2920         Reviewed by Adam Barth.
2921
2922         webkit-patch land logs commit message twice
2923         https://bugs.webkit.org/show_bug.cgi?id=49482
2924         
2925         Don't log the comment that's used by bugzilla.close_bug_as_fixed, since
2926         that's just the commit message, which we now output following the
2927         actual commit.
2928
2929         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2930
2931 2010-11-12  Tony Chang  <tony@chromium.org>
2932
2933         Reviewed by Adam Barth.
2934
2935         run platform/chromium/plugins/script-object-invoke.html on all platforms
2936         https://bugs.webkit.org/show_bug.cgi?id=49280
2937
2938         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2939         (testScriptObjectInvoke):
2940         (pluginInvoke):
2941
2942 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
2943
2944         Reviewed by Adam Barth.
2945
2946         webkit-patch land-cowboy (and other commands) should display the committed SVN revision after landing a patch
2947         https://bugs.webkit.org/show_bug.cgi?id=49471
2948
2949         Right now there's no indication of a successful commit.
2950         
2951         * Scripts/webkitpy/tool/commands/download_unittest.py:
2952         * Scripts/webkitpy/tool/steps/commit.py:
2953
2954 2010-11-12  Kinuko Yasuda  <kinuko@chromium.org>
2955
2956         Reviewed by Ojan Vafai.
2957
2958         Include detailed test modifiers in results.json and enable incremental uploading for non-layout tests
2959         https://bugs.webkit.org/show_bug.cgi?id=49354
2960
2961         Also moved/integrated the upload method from run_webkit_tests.py to json_results_generator.py.
2962
2963         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2964         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2965         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2966         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2967
2968 2010-11-12  Tony Chang  <tony@chromium.org>
2969
2970         Reviewed by Kent Tamura.
2971
2972         [chromium] Load a blank page when closing DRT WebViewHosts
2973         https://bugs.webkit.org/show_bug.cgi?id=49417
2974
2975         In test_shell, when we close a window, we first load about:blank
2976         and run GC to fire the destruction logic of the page.  In test_shell,
2977         this happens in ~TestShell.  In DRT, we manage virtual windows as
2978         WebViewHosts, so we need to replicate this logic in ~WebViewHost.
2979
2980         Managing focus is a bit trickier, since normally you would get window
2981         events to reset the focus to the right window.  We do it manually
2982         instead.
2983
2984         This fixes 2 plugin tests on DRT.
2985
2986         * DumpRenderTree/chromium/TestShell.cpp:
2987         (TestShell::~TestShell): Move window close logic to ~WebViewHost.
2988         (TestShell::closeWindow): Move widget close() to WVH destructor and
2989             manage focus manually.
2990         (TestShell::closeRemainingWindows): Comment typo.
2991         * DumpRenderTree/chromium/WebViewHost.cpp:
2992         (WebViewHost::closeWidget):
2993         (invokeCloseWidget):
2994         (WebViewHost::closeWidgetSoon): Close the window asynchronously (matches
2995             test_shell).
2996         (WebViewHost::~WebViewHost):
2997         * DumpRenderTree/chromium/WebViewHost.h:
2998
2999 2010-11-12  David Levin  <levin@chromium.org>
3000
3001         Reviewed by Adam Barth.
3002
3003         cpp.py needs some tidying.
3004         https://bugs.webkit.org/show_bug.cgi?id=49443
3005
3006         * Scripts/webkitpy/style/checkers/cpp.py:
3007           Fix parameter ordering for iteratively_replace_matches_with_char
3008           to mirror other similar functions (and improved comments, etc.)
3009           Also, use a python-ism (for/else) to get rid of a variable that
3010           was there to determine if something had been found in the loop.
3011
3012 2010-11-12  Robert Kroeger  <rjkroege@chromium.org>
3013
3014         Reviewed by James Robinson.
3015
3016         [Chromium/DRT] Make EventSendingController send complete touch events.
3017         https://bugs.webkit.org/show_bug.cgi?id=49285
3018
3019         * DumpRenderTree/chromium/EventSender.cpp:
3020         (EventSender::addTouchPoint):
3021         (EventSender::updateTouchPoint):
3022         (EventSender::sendCurrentTouchEvent):
3023
3024 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
3025
3026         Unreviewed rollout of r71858.
3027
3028         Rollout out r71858 since it breaks new-run-webkit-httpd as used by the
3029         NaCl tests.
3030
3031         * Scripts/webkitpy/layout_tests/port/config.py:
3032         * Scripts/webkitpy/layout_tests/port/config_standalone.py: Removed.
3033         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3034
3035 2010-11-12  Benjamin Poulain  <benjamin.poulain@nokia.com>
3036
3037         Reviewed by Kenneth Rohde Christiansen.
3038
3039         [Qt] TestController::runUntil doesn't honor the timeout parameter
3040         https://bugs.webkit.org/show_bug.cgi?id=48941
3041
3042         Implement the missing timeout of WebKitTestRunner for Qt.
3043
3044         A QElapsedTimer has been added to RunUntilConditionLoop in order
3045         to measure how long the loop has been running. When the timer
3046         is bigger or equal than the timeout, the loop ends even if the
3047         condition is not met.
3048
3049         * WebKitTestRunner/qt/TestControllerQt.cpp:
3050         (WTR::RunUntilConditionLoop::start):
3051         (WTR::RunUntilConditionLoop::run):
3052         (WTR::RunUntilConditionLoop::timerEvent):
3053         (WTR::TestController::platformRunUntil):
3054
3055 2010-11-11  David Levin  <levin@chromium.org>
3056
3057         Reviewed by Shinichiro Hamaji.
3058
3059         check-webkit-style function detection doesn't handle templates with spaces.
3060         https://bugs.webkit.org/show_bug.cgi?id=49427
3061
3062         * Scripts/webkitpy/style/checkers/cpp.py: Stripped out templates when
3063           finding the function name.
3064         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Made the test have a
3065           template with a space.
3066
3067 2010-11-11  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
3068
3069         Reviewed by Shinichiro Hamaji.
3070
3071         Enable check-webkit-style on Qt files
3072         https://bugs.webkit.org/show_bug.cgi?id=48322
3073
3074         Adding exception for _q_... private slots and
3075         ..._data() methods in tests
3076
3077         * Scripts/webkitpy/style/checker.py: enable Qt dirs, add exceptions
3078         * Scripts/webkitpy/style/checker_unittest.py: improve unittests
3079
3080 2010-11-11  David Levin  <levin@chromium.org>
3081
3082         Reviewed by Shinichiro Hamaji.
3083
3084         check-webkit-style function detection doesn't work for templates and destructors.
3085         https://bugs.webkit.org/show_bug.cgi?id=49425
3086
3087         * Scripts/webkitpy/style/checkers/cpp.py: Changed regex for templates and destructors.
3088         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Made the test hit this issue.
3089
3090 2010-11-11  Joone Hur  <joone@kldp.org>
3091
3092         Reviewed by Antonio Gomes.
3093
3094         [GTK][DRT] Implement LayoutTestController::nodesFromRect
3095         https://bugs.webkit.org/show_bug.cgi?id=46598
3096
3097         Support nodesFromRect in DRT
3098
3099         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3100         (LayoutTestController::nodesFromRect):
3101
3102 2010-11-11  MORITA Hajime  <morrita@google.com>
3103
3104         Reviewed by Kent Tamura.
3105
3106         editing/selection/context-menu-on-text.html fails on chromium
3107         https://bugs.webkit.org/show_bug.cgi?id=45898
3108
3109         Enhance Chromium's EventSender::contextClick() to return
3110         array of menu strings. The implementation incomplete because
3111         Although actual context menu is implemented by the browser,
3112         it reflects editability of underlying context thus makes
3113         context-menu-on-text.html passed.
3114         
3115         * DumpRenderTree/chromium/EventSender.cpp:
3116         (makeMenuItemStringsFor): Added.
3117         (EventSender::contextClick): Now returns array of menu strings.
3118         * DumpRenderTree/chromium/WebViewHost.cpp:
3119         (WebViewHost::showContextMenu): Now storing given WebContextMenuData object.
3120         (WebViewHost::clearContextMenuData): Added.
3121         (WebViewHost::lastContextMenuData): Added.
3122         * DumpRenderTree/chromium/WebViewHost.h:
3123
3124 2010-11-11  Dirk Pranke  <dpranke@chromium.org>
3125
3126         Unreviewed, build fix.
3127
3128         fix build breakage caused by fix for bug 49380 (r71858).
3129
3130         config_standalone needs to ensure that the packages it needs are
3131         in sys.path.
3132
3133         https://bugs.webkit.org/show_bug.cgi?id=49419
3134
3135         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
3136
3137 2010-11-11  Dirk Pranke  <dpranke@chromium.org>
3138
3139         Reviewed by Adam Roben.
3140
3141         Fix NRWT to respect set-webkit-configuration again :(
3142
3143         This change fixes a typo in config.py that was causing the wrong
3144         value to be read initially and us never actually looking into
3145         the filesystem to get the default configuration.
3146         
3147         * Scripts/webkitpy/layout_tests/port/config.py:
3148         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
3149         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3150
3151 2010-11-11  Eric Seidel  <eric@webkit.org>
3152
3153         Reviewed by Adam Barth.
3154
3155         Split out Bug, Attachment and CommitterValidator from bugzilla.py
3156         https://bugs.webkit.org/show_bug.cgi?id=49403
3157
3158         CommitterValidator really had nothing to do with bugzilla.py.
3159         I've put it next to committers.py for now since its rather tied to that file.
3160
3161         * Scripts/webkitpy/common/config/committervalidator.py: Added.
3162         * Scripts/webkitpy/common/config/committervalidator_unittest.py: Added.
3163         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
3164         * Scripts/webkitpy/common/net/bugzilla/attachment.py: Added.
3165         * Scripts/webkitpy/common/net/bugzilla/bug.py: Added.
3166         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py: Added.
3167         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3168         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3169         * Scripts/webkitpy/tool/bot/feeders.py:
3170         * Scripts/webkitpy/tool/commands/queues.py:
3171
3172 2010-11-11  Dirk Pranke  <dpranke@chromium.org>
3173
3174         Reviewed by Eric Seidel.
3175
3176         fix missing 'pid' argument for http lockfile checking on win32
3177         https://bugs.webkit.org/show_bug.cgi?id=49363
3178
3179         * Scripts/webkitpy/common/system/executive.py:
3180
3181 2010-11-11  Eric Seidel  <eric@webkit.org>
3182
3183         Rubber-stamped by Adam Barth.
3184
3185         Move bugzilla.py into its own module in preparation for splitting one-file-per-class
3186         https://bugs.webkit.org/show_bug.cgi?id=49402
3187
3188         * Scripts/webkitpy/common/net/bugzilla/__init__.py: Added.
3189         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/bugzilla.py.
3190         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/bugzilla_unittest.py.
3191
3192 2010-11-10  Chris Guillory  <chris.guillory@google.com>
3193
3194         Reviewed by Chris Fleizach.
3195
3196         Use IAccessibleComparable to compare accessibility objects.
3197         https://bugs.webkit.org/show_bug.cgi?id=49118
3198
3199         * DumpRenderTree/AccessibilityUIElement.cpp:
3200         (AccessibilityUIElement::isEqual):
3201         * DumpRenderTree/AccessibilityUIElement.h:
3202         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3203         (comparableObject):
3204         (AccessibilityUIElement::isEqual):
3205
3206 2010-11-10  Csaba Osztrogonác  <ossy@webkit.org>
3207
3208         Reviewed by David Hyatt.
3209
3210         HTML5 Ruby support should be mandatory feature
3211         https://bugs.webkit.org/show_bug.cgi?id=49272
3212
3213         Remove Ruby as optional feature.
3214
3215         * Scripts/build-webkit:
3216
3217 2010-11-10  Adam Roben  <aroben@apple.com>
3218
3219         Print VC++ Express build logs in the same order that the projects are
3220         built
3221
3222         Fixes <http://webkit.org/b/49326> print-vse-failure-logs prints logs
3223         in an unhelpful order
3224
3225         Reviewed by Eric Seidel.
3226
3227         * Scripts/print-vse-failure-logs:
3228         (PrintVisualStudioExpressLogs._build_order): Added. Uses
3229         print-msvc-project-dependencies to figure out the order in which
3230         projects are built.
3231         (PrintVisualStudioExpressLogs._sort_buildlogs): Added. Sorts the logs
3232         based on their build order and project name.
3233         (PrintVisualStudioExpressLogs._obj_directory): Moved code to find the
3234         scripts directory from here...
3235         (PrintVisualStudioExpressLogs._scripts_directory): ...to here.
3236         (PrintVisualStudioExpressLogs.main): Sort the logs before printing
3237         them.
3238
3239 2010-11-10  Adam Roben  <aroben@apple.com>
3240
3241         Only print the interesting text from VC++ Express build logs
3242
3243         Fixes <http://webkit.org/b/49325> It's hard to find the interesting
3244         output from print-vse-failure-logs
3245
3246         Reviewed by Eric Seidel.
3247
3248         * Scripts/print-vse-failure-logs: Removed unnecessary os.path import,
3249         added newly-required imports. Removed a comment that was essentially a
3250         FIXME, and is now fixed.
3251         (PrintVisualStudioExpressLogs._relevant_text): Added. Uses
3252         BeautifulSoup to extract the relevant text from the build log.
3253         (PrintVisualStudioExpressLogs.main): Only print the relevant text.
3254
3255 2010-11-09  Mihai Parparita  <mihaip@chromium.org>
3256
3257         Reviewed by Tony Chang.
3258
3259         [Chromium] http/tests/security/XFrameOptions fail with Chromium DRT
3260         https://bugs.webkit.org/show_bug.cgi?id=49286
3261         
3262         The tests in http/tests/security/XFrameOptions started to fail after
3263         r71297, since it changed the WebViewHost::assignIdentifierToRequest
3264         logic to always assign identifiers to requests, even if we're not going
3265         to be dumping resource load callbacks at that point. These tests
3266         only call LayoutTestController.dumpResourceLoadCallbacks after the
3267         request is started, thus their expectations have "<unknown>" as the
3268         identifier. Change WebViewHost to the previous behavior, which also
3269         match the other ports'.
3270
3271         * DumpRenderTree/chromium/WebViewHost.cpp:
3272         (WebViewHost::assignIdentifierToRequest):
3273         (WebViewHost::removeIdentifierForRequest):
3274
3275 2010-11-08  Tony Chang  <tony@chromium.org>
3276
3277         Reviewed by Adam Barth.
3278
3279         run platform/chromium/plugins/return-npobject.html on all platforms
3280         https://bugs.webkit.org/show_bug.cgi?id=49103
3281
3282         This tests that we can get an NPObject returned through a method on
3283         an NPAPI Object.
3284
3285         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3286         (testCallbackReturn):
3287         (pluginInvoke):
3288
3289 2010-11-09  Sheriff Bot  <webkit.review.bot@gmail.com>
3290
3291         Unreviewed, rolling out r71672.
3292         http://trac.webkit.org/changeset/71672
3293         https://bugs.webkit.org/show_bug.cgi?id=49276
3294
3295         It doesn't work on Chromium Windows bot (Requested by Ossy on
3296         #webkit).
3297
3298         * Scripts/webkitpy/common/system/file_lock.py: Removed.
3299         * Scripts/webkitpy/common/system/file_lock_unittest.py: Removed.
3300         * Scripts/webkitpy/layout_tests/port/http_lock.py:
3301
3302 2010-11-09  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3303
3304         Reviewed by Tony Chang.
3305
3306         [NRWT] Make http locking similar to perl implementation
3307         https://bugs.webkit.org/show_bug.cgi?id=49187
3308
3309         * Scripts/webkitpy/common/system/file_lock.py: Added.
3310         * Scripts/webkitpy/common/system/file_lock_unittest.py: Added.
3311         * Scripts/webkitpy/layout_tests/port/http_lock.py:
3312
3313 2010-11-09  James Kozianski  <koz@chromium.org>
3314
3315         Reviewed by Eric Seidel.
3316
3317         Clean up imports for webkit-patch.
3318         https://bugs.webkit.org/show_bug.cgi?id=49083
3319
3320         Move some imports from commands into main.py where they are used.
3321         Move command imports into the __init__ of the commands module.
3322
3323         * Scripts/webkitpy/tool/commands/__init__.py:
3324         * Scripts/webkitpy/tool/commands/download.py:
3325         * Scripts/webkitpy/tool/commands/queues.py:
3326         * Scripts/webkitpy/tool/main.py:
3327
3328 2010-11-09  Yi Shen  <yi.4.shen@nokia.com>
3329
3330         Reviewed by Andreas Kling.
3331
3332         [Qt][QtTestBrowser] Don't erase incorrect url in the Url Bar
3333         https://bugs.webkit.org/show_bug.cgi?id=49047
3334
3335         * QtTestBrowser/mainwindow.cpp:
3336         (MainWindow::setAddressUrl):
3337
3338 2010-11-09  Andras Becsi  <abecsi@webkit.org>
3339
3340         Reviewed by Csaba Osztrogonác.
3341
3342         Improve old-run-webkit-tests --verbose to show DumpTool opening/closing
3343         https://bugs.webkit.org/show_bug.cgi?id=49252
3344
3345         * Scripts/old-run-webkit-tests:
3346
3347 2010-11-09  Csaba Osztrogonác  <ossy@webkit.org>
3348
3349         Reviewed by Tor Arne Vestbø.
3350
3351         Output of old-run-webkit-tests is buggy in verbose mode
3352         https://bugs.webkit.org/show_bug.cgi?id=49249
3353
3354         * Scripts/old-run-webkit-tests: Redundant outputs removed.
3355
3356 2010-11-08  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
3357
3358         Reviewed by Martin Robinson.
3359
3360         [GTK] Link with target name set does not work
3361         https://bugs.webkit.org/show_bug.cgi?id=48865
3362
3363         When a new page is created with a name (target=myFrame), the new
3364         mainFrame could not be found because they where not stored in the
3365         same PageGroup. As PageGroup are not exposed externally so the
3366         simpliest solution is to use a global page group name. This also fixes
3367         issue with visited link coloration across pages. After this change the
3368         private function webkit_web_view_set_group_name() was no longer used
3369         so it was removed completly.
3370
3371         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3372         (createWebView):
3373
3374 2010-11-08  John Knottenbelt  <jknotten@chromium.org>
3375
3376         Reviewed by Kent Tamura.
3377
3378         WebViewHost::reset() uses placement new.
3379         https://bugs.webkit.org/show_bug.cgi?id=49069
3380
3381         WebViewHost is using placement destruction / new to simulate a fresh
3382         WebViewHost object at the same address. This is because the WebView remains
3383         open across tests and maintains a pointer to the WebViewHost.
3384         This change resets member variables explictly instead of the placement new dance.
3385
3386         * DumpRenderTree/chromium/WebViewHost.cpp:
3387         (WebViewHost::WebViewHost):
3388         (WebViewHost::reset):
3389
3390 2010-11-08  Dirk Pranke <dpranke@chromium.org>
3391
3392         Reviewed by Eric Seidel.
3393
3394         Fix the webkit_base_dir logic in webkitpy/layout_tests/port/config.py. 
3395         It turns out that NRWT can't use the code in scm.find_checkout_root()
3396         because the Chromium bots don't do full checkouts of the WebKit
3397         tree; they only check out subdirectories like WebKitTools/Scripts.
3398         Until we can figure out a better approach for this, I've
3399         restored the base_dir-detecting code from NRWT, which works in
3400         any directory tree, scm or no.
3401
3402         This also restores the files modified in r71475 and r71474.
3403
3404         https://bugs.webkit.org/show_bug.cgi?id=49151
3405
3406         * WebKitTools/Scripts/webkitpy/layout_tests/port/config.py
3407         * WebKitTools/Scripts/webkitpy/layout_tests/port/config_unittest.py
3408
3409 2010-11-08  Eric Seidel  <eric@webkit.org>
3410
3411         Reviewed by Adam Barth.
3412
3413         webkit-patch failure-reason explodes if a build is missing
3414         https://bugs.webkit.org/show_bug.cgi?id=49195
3415
3416         This is likely a recent regression.  Adding a unit test for this case.
3417
3418         * Scripts/webkitpy/common/net/buildbot.py:
3419         * Scripts/webkitpy/common/net/buildbot_unittest.py:
3420
3421 2010-11-08  Dan Bernstein  <mitz@apple.com>
3422
3423         Reviewed by Darin Adler.
3424
3425         Ignore the system scrollbar setting.
3426
3427         * DumpRenderTree/mac/DumpRenderTree.mm:
3428         (resetDefaultsToConsistentValues): Set the scrollbar default.
3429
3430 2010-11-05  Adam Roben  <aroben@apple.com>
3431
3432         Make webkitpy.common.system.executive_unittest pass when running under
3433         Win32 Python
3434
3435         Fixes <http://webkit.org/b/49033>.
3436
3437         Reviewed by Dave Levin and Eric Seidel.
3438
3439         * Scripts/webkitpy/common/system/executive.py:
3440         (Executive._run_command_with_teed_output): Pass the arguments through
3441         encode_argument_if_needed rather than using Cygwin-specific code here.
3442         (Executive.run_and_throw_if_fail): Use child_process_encoding to decode
3443         the output.
3444         (Executive.run_command): Use encode_argument_if_needed to encode the
3445         arguments and child_process_encoding to decode the output.
3446         (Executive._child_process_encoding): Returns the encoding that should be
3447         used when communicating with child processes. On Windows we use mbcs,
3448         which maps to the current code page. On all other platforms we use
3449         UTF-8.
3450         (Executive._should_encode_child_process_arguments): Returns True if
3451         arguments to child processes need to be encoded. This is currently
3452         only needed on Cygwin and Win32 Python 2.x.
3453         (Executive._encode_argument_if_needed): Encode the argument using
3454         child_process_encoding if we need to encode arguments to child
3455         processes on this platform.
3456
3457         * Scripts/webkitpy/common/system/executive_unittest.py:
3458         (never_ending_command): Added. Returns arguments to run a command that
3459         will not quit until we kill it. On Windows we use wmic, on other
3460         platforms we use yes.
3461         (ExecutiveTest.test_run_command_with_unicode): Changed to expect the
3462         mbcs encoding to be used and for output from the child processes to
3463         have been roundtripped through encode/decode on Win32 Python. When
3464         UTF-8 is the encoding the roundtripping is undetectable, but with mbcs
3465         it's possible that some characters will not be able to be converted
3466         and will be replaced by question marks; the round-tripping allows us
3467         to expect this result.
3468
3469         (ExecutiveTest.test_kill_process):
3470         (ExecutiveTest.test_kill_all):
3471         Use never_ending_command instead of invoking "yes" directly. Expect an
3472         exit code of 1 when using Win32 Python, as that's what seems to happen.
3473
3474 2010-11-08  Adam Roben  <aroben@apple.com>
3475
3476         Roll out r71532
3477
3478         It broke the build for Cygwin 1.7 installs. Cygwin 1.7's default
3479         .bashrc unsets %TEMP%, which broke copy-tools.cmd.
3480
3481         * Scripts/webkitdirs.pm:
3482
3483 2010-11-08  Tony Chang  <tony@chromium.org>
3484
3485         Reviewed by Adam Barth.
3486
3487         run platform/chromium/plugins/nested-plugin-objects.html on all platforms
3488         https://bugs.webkit.org/show_bug.cgi?id=49094
3489
3490         This tests that objects created by plugins are proplery cleaned up.
3491
3492         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3493         (testPassTestObject):
3494         (pluginInvoke):
3495         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
3496         (testAllocate):
3497         (testDeallocate):
3498         (testGetProperty):
3499         (testConstruct):
3500
3501 2010-11-08  Adam Roben  <aroben@apple.com>
3502
3503         Mark Windows builds triggered from Perl as being non-interactive
3504
3505         This affects whether some of our scripts will show alerts vs. printing
3506         to the build log.
3507
3508         Fixes <http://webkit.org/b/49181> Windows build fail mysteriously when
3509         .vsprops files are updated
3510
3511         Reviewed by Steve Falkenburg.
3512
3513         * Scripts/webkitdirs.pm:
3514         (buildVisualStudioProject): Set WEBKIT_NONINTERACTIVE_BUILD to 1.
3515
3516 2010-11-08  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3517
3518         Reviewed by Ojan Vafai.
3519
3520         Make http locking default in NRWT.
3521         https://bugs.webkit.org/show_bug.cgi?id=48053
3522
3523         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3524         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3525
3526 2010-11-08  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3527
3528         Reviewed by Csaba Osztrogonác.
3529
3530         [NRWT] If the http lock fails we shouldn't do any locking
3531         https://bugs.webkit.org/show_bug.cgi?id=49164
3532
3533         If something goes wrong with the locking, the test should keep going.
3534
3535         * Scripts/webkitpy/layout_tests/port/http_lock.py:
3536
3537 2010-11-08  Adam Roben  <aroben@apple.com>
3538
3539         Switch back to using kCGImageAlphaPremultipliedFirst when generating
3540         pixel dumps on Windows
3541
3542         I changed this behavior in r71418 thinking that it was required for
3543         getting plugins to show up in pixel dumps. But it doesn't seem to be
3544         necessary, and was making it impossible to compare new Windows pixel
3545         dumps with existing Windows or Mac pixel dumps (because ImageDiff won't
3546         compare an image with alpha to an image without alpha).
3547
3548         Fixes <http://webkit.org/b/49172> REGRESION (r71418): Can't compare
3549         new Windows pixel results to existing Windows or Mac results
3550
3551         Reviewed by Antti Koivisto.
3552
3553         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3554         (createBitmapContextFromWebView): Replaced kCGImageAlphaNoneSkipFirst
3555         with kCGImageAlphaPremultipliedFirst.
3556
3557 2010-11-08  Csaba Osztrogonac  <ossy@webkit.org>
3558
3559         Unreviewed, rolling out r71466.
3560         http://trac.webkit.org/changeset/71466
3561         https://bugs.webkit.org/show_bug.cgi?id=48865
3562
3563         It broke layout tests on GTK bots.
3564
3565         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3566         (createWebView):
3567
3568 2010-11-08  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3569
3570         Reviewed by Csaba Osztrogonác.
3571
3572         Enable running of Qt API tests on BuildBot
3573         https://bugs.webkit.org/show_bug.cgi?id=49004
3574
3575         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3576
3577 2010-11-08  Eric Seidel  <eric@webkit.org>
3578
3579         Reviewed by Adam Barth.
3580
3581         Add clean-review-queue command to remove closed bugs from the webkit.org/pending-review
3582         https://bugs.webkit.org/show_bug.cgi?id=49160
3583
3584         Bugzilla doesn't automatically remove r? when a bug gets closed.
3585         This script takes care of that for webkit.org.
3586
3587         * Scripts/webkitpy/common/net/bugzilla.py:
3588         * Scripts/webkitpy/tool/commands/upload.py:
3589
3590 2010-11-07  Fumitoshi Ukai  <ukai@chromium.org>
3591
3592         Unreviewed, rolling out r71474.
3593         http://trac.webkit.org/changeset/71474
3594         https://bugs.webkit.org/show_bug.cgi?id=48280
3595
3596         breaks chromium webkit tests