6d8e04f41d2cbc83a920287891e2a1d66655a91a
[WebKit-https.git] / WebKitTools / ChangeLog
1 2008-01-19  Mark Rowe  <mrowe@apple.com>
2
3         Reviewed by Alp Toker.
4
5         Allow the --http flag to run-webkit-tests to override
6         the default behaviour of disabling HTTP tests for Qt,
7         Gtk and Wx.
8
9         * Scripts/run-webkit-tests:
10
11 2008-01-19  David Kilzer  <ddkilzer@apple.com>
12
13         <rdar://problem/5695344> check-for-global-initializers script never checks any object files
14
15         Reviewed by Darin.
16
17         We now touch a check-for-global-initializers.timestamp file in
18         the TARGET_TEMP_DIR directory to determine when new object files
19         have been compiled and thus need to be checked.  If the timestamp
20         file doesn't exist, all object files will be checked.
21
22         Previously the modification time of the "executable" (the
23         framework binary, e.g., WebKit.framework/WebKit) was used, but
24         since this was the last file modified at the end of the compile
25         phase, no object files would ever get checked!
26
27         Also added JSCustomSQLTransactionCallback.o to the list of files
28         since it has static initializers in Debug builds of WebCore.
29
30         * Scripts/check-for-global-initializers:
31
32 2008-01-18  Adam Roben  <aroben@apple.com>
33
34         Build fix
35
36         * Scripts/build-webkit:
37
38 2008-01-18  Beth Dakin  <bdakin@apple.com>
39
40         Reviewed by Oliver.
41
42         Update build-webkit to account for foreign-object being disabled by 
43         default.
44
45         * Scripts/build-webkit:
46
47 2008-01-18  Adam Roben  <aroben@apple.com>
48
49         Updated for method renames
50
51         Reviewed by Adele.
52
53         * DumpRenderTree/mac/FrameLoadDelegate.mm:
54         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
55         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
56         (LayoutTestController::setMainFrameIsFirstResponder):
57         (LayoutTestController::setWindowIsKey):
58         * DumpRenderTree/mac/UIDelegate.mm:
59         (-[UIDelegate webViewFocus:]):
60         * DumpRenderTree/win/FrameLoadDelegate.cpp:
61         (FrameLoadDelegate::didCommitLoadForFrame):
62
63 2008-01-18  Alexey Proskuryakov  <ap@webkit.org>
64
65         Reviewed by Adam Roben.
66
67         Fix plugin-related tests in Debug_Internal configuration, which are failing because of CRT version mismatch
68         between DRT and TestNetscapePlugin.
69
70         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Added a Debug_Internal configuration.
71         * DumpRenderTree/DumpRenderTree.sln: Use this configuration.
72
73 2008-01-18  Simon Hausmann  <hausmann@webkit.org>
74
75         Reviewed by Holger.
76
77         Fix fast/dom/Window/window-resize.html
78         
79         In DRT connect the page's geometryChangeRequest signal to a slot that
80         sets the geometry of the view widget.
81         
82
83         * DumpRenderTree/qt/DumpRenderTree.cpp:
84         (WebCore::WebPage::setViewGeometry):
85         (WebCore::WebPage::WebPage):
86
87 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
88
89         Build fix.
90
91         * Drosera/DroseraWin.make:
92
93 2008-01-17  Darin Adler  <darin@apple.com>
94
95         * Scripts/run-webkit-tests: Fixed a bug number.
96
97 2008-01-17  Alexey Proskuryakov  <ap@webkit.org>
98
99         Reviewed by Adam Roben.
100
101         http://bugs.webkit.org/show_bug.cgi?id=16908
102         run-webkit-tests complains about missing FindSafari.exe
103
104         * Scripts/webkitdirs.pm: Append _debug as appropriate.
105
106 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
107
108         Re-add DEBUG_WEBKIT_HAS_SUFFIX.
109         
110         Rubber-stamped by Jon Honeycutt.
111
112         * DumpRenderTree/win/DumpRenderTree.vcproj:
113
114 2008-01-16  Alp Toker  <alp@atoker.com>
115
116         Reviewed by Mark Rowe.
117
118         http://bugs.webkit.org/show_bug.cgi?id=16218
119         [GTK] API: Should this entry point be called go_back rather than go_backward?
120
121         Track back/forward API changes in the tools.
122
123         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
124         (BackForwardItem::invoke):
125         * GtkLauncher/main.c:
126         (go_back_cb):
127
128 2008-01-16  Adam Roben  <aroben@apple.com>
129
130         Windows build fix after r29488
131
132         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
133         Build into a subdirectory of $WebKitOutputDir\bin to match where DRT
134         expects to find the plugin.
135
136 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
137
138         Reviewed by Sam Weinig.
139         
140         Fixed the waitUntilDone watchdog timer -- the old code never added the
141         timer to the run loop, so it didn't do anything.
142
143         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
144         (LayoutTestController::setWaitToDump):
145         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
146         (LayoutTestController::setWaitToDump):
147
148 2008-01-14  Steve Falkenburg  <sfalken@apple.com>
149
150         Use shared vsprops for most vcproj properties.
151         
152         Reviewed by Darin.
153
154         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
155         * DumpRenderTree/win/DumpRenderTree.vcproj:
156         * DumpRenderTree/win/ImageDiff.vcproj:
157         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
158         * FindSafari/FindSafari.vcproj:
159
160 2008-01-14  Stephanie  <slewis@apple.com>
161
162        Reviewed by NOBODY.
163   
164        revert accidental character.
165
166        * Scripts/run-webkit-tests:
167
168 2008-01-14  Stephanie  <slewis@apple.com>
169
170         RS=Oliver
171
172         add Quicktime PPC only leaks to Leopard exclude list. See <rdar://problem/5667132>
173
174         * Scripts/run-webkit-tests:
175
176 2008-01-14  Darin Adler  <darin@apple.com>
177
178         * Scripts/do-webcore-rename: Queue up another rename.
179
180 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
181
182         Reviewed by Darin.
183
184         * Allow to run the tests in reverse order to spot test cases where the result depends on the order
185         the tests were ran.
186         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
187
188         * Scripts/run-webkit-tests:
189
190 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
191
192         Reviewed by Darin.
193
194         * Randomize tests array to spot test cases where the results depends on the order
195         the tests are ran.
196         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
197
198         * Scripts/run-webkit-tests:
199
200 2008-01-14  Darin Adler  <darin@apple.com>
201
202         * Scripts/run-webkit-tests: More ignore list tweaking.
203
204 2008-01-14  Darin Adler  <darin@apple.com>
205
206         * Scripts/run-webkit-tests: Add another leak to the ignore list.
207
208 2008-01-14  Dan Bernstein  <mitz@apple.com>
209
210         Reviewed by Adam Roben.
211
212         - try to fix failure in fast/dom/Window/window-onFocus.html seen on the
213           build bots
214
215         * DumpRenderTree/win/DumpRenderTree.cpp:
216         (resetWebViewToConsistentStateBeforeTesting): Focus the web view.
217
218 2008-01-13  Steve Falkenburg  <sfalken@apple.com>
219
220         Share common files across projects.
221         
222         Unify vsprops files
223         Debug:          common.vsprops, debug.vsprops
224         Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
225         Release:        common.vsprops, release.vsprops
226         
227         Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
228         debug_internal.vsprops will be mostly empty except for file path prefix modifiers.
229
230         Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.
231
232         Reviewed by Adam Roben.
233
234         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
235         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Removed.
236         * Drosera/win/Drosera.vcproj/VERSION: Removed.
237         * Drosera/win/Drosera.vcproj/auto-version.sh: Removed.
238         * Drosera/win/Drosera.vcproj/debug.vsprops: Removed.
239         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Removed.
240         * Drosera/win/Drosera.vcproj/release.vsprops: Removed.
241         * DumpRenderTree/win/DumpRenderTree.vcproj:
242         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
243         * DumpRenderTree/win/debug.vsprops: Removed.
244         * DumpRenderTree/win/debug_internal.vsprops: Removed.
245         * DumpRenderTree/win/release.vsprops: Removed.
246
247 2008-01-13  Brent Fulgham  <bfulgham@gmail.com>
248
249         Reviewed by Maciej.
250
251         - http://bugs.webkit.org/show_bug.cgi?id=16314
252           Script to launch Drosera
253
254         * Scripts/gdb-drosera: Added.
255         * Scripts/run-drosera: Added.
256         * Scripts/run-drosera-nightly.cmd: Added.
257         * Scripts/webkitdirs.pm: Added runDrosera function.
258
259 2008-01-13  Dan Bernstein  <mitz@apple.com>
260
261         - fix breakage due to last-minute change
262
263         * DumpRenderTree/win/DumpRenderTree.cpp:
264         (runTest): Declare the loop variable.
265
266 2008-01-13  Dan Bernstein  <mitz@apple.com>
267
268         Reviewed by Adam Roben.
269
270         - fix <rdar://problem/5132009> Windows DRT does not support multiple windows
271
272         * DumpRenderTree/win/DumpRenderTree.cpp:
273         (DumpRenderTreeWndProc):
274         (initialize):
275         (dumpBackForwardList):
276         (dumpBackForwardListForAllWindows):
277         (dump):
278         (resetWebViewToConsistentStateBeforeTesting): Factored out of
279         runTest().
280         (runTest):
281         (allWindows): Added. Returns a vector of all open windows.
282         (windowToWebViewMap): Added. Returns a map from open windows to their
283         WebViews.
284         (createWebViewAndOffscreenWindow): Factored out of main() to be
285         reusable for creating extra windows.
286         (main):
287         * DumpRenderTree/win/DumpRenderTreeWin.h:
288         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
289         (LayoutTestController::windowCount): Implemented.
290         * DumpRenderTree/win/UIDelegate.cpp:
291         (UIDelegate::createWebViewWithRequest): Implemented.
292         (UIDelegate::webViewClose): Implemented.
293         * DumpRenderTree/win/UIDelegate.h:
294
295 2008-01-12  Alp Toker  <alp@atoker.com>
296
297         Reviewed by Mark Rowe.
298
299         Hide non-public symbols in GTK+/autotools release builds.
300
301         * GNUmakefile.am:
302
303 2008-01-12  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
304
305         Reviewed by Ap.
306
307         * Make launching of the WebKit httpd work on GNU/Debian/Linux
308         
309         The configuration of Apache2 and installation does not depend on
310         the kernel but on the distribution policy. Make launching of httpd
311         work for Debian derived distributions.
312
313         * Scripts/run-webkit-httpd:
314         * Scripts/run-webkit-tests:
315         * Scripts/webkitdirs.pm:
316
317 2008-01-12  Mark Rowe  <mrowe@apple.com>
318
319         Reviewed by Maciej Stachowiak.
320
321         Fix crash in http/tests/security/local-JavaScript-from-remote.html under guard malloc.
322
323         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Retain string before returning it to
324         match the callers expectations that it can take ownership of the string.
325
326 2008-01-11  Alexey Proskuryakov  <ap@webkit.org>
327
328         Reviewed by Adam Roben.
329
330         <rdar://problem/5667275> fast/dynamic/layer-hit-test-crash.html is failing
331
332         * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ignore WM_MOUSELEAVE events,
333         as these are only posted because the test window is not a normal visible one, and
334         they confuse drag&drop machinery.
335
336 2008-01-11  Adam Roben  <aroben@apple.com>
337
338         Fix a crash when pathToLocalResource fails and a leak
339
340         Reviewed by Darin.
341
342         * DumpRenderTree/LayoutTestController.cpp:
343         (pathToLocalResourceCallback): Dont leak the JSStringRef, and make
344         sure not to pass null to JSValueMakeString.
345         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
346         (LayoutTestController::pathToLocalResource): Print an error message if
347         the conversion fails so it's clear what happened.
348
349 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
350
351         Reviewed by John Sullivan.
352
353         * DumpRenderTree/mac/GCControllerMac.mm:
354         (GCController::collectOnAlternateThread): Updated for name change.
355
356 2008-01-10  Kevin Ollivier  <kevino@theolliviers.com>
357
358         wx build fix. Don't build dftables any longer since it's now a Perl
359         script.
360
361         * wx/build-wxwebkit:
362
363 2008-01-10  Sam Weinig  <sam@webkit.org>
364
365         Reviewed by Anders Carlsson.
366
367         Make DRT track open windows instead of allocated windows so that
368         we can avoid ASSERTION due to late deallocs out of our control.
369
370         * DumpRenderTree/mac/DumpRenderTree.mm:
371         (dumpBackForwardListForAllWindows):
372         (runTest):
373         * DumpRenderTree/mac/DumpRenderTreeMac.h:
374         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
375         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
376         (+[DumpRenderTreeWindow openWindows]):
377         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
378         (-[DumpRenderTreeWindow close]):
379         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
380         (LayoutTestController::windowCount):
381
382 2008-01-10  Ada Chan  <adachan@apple.com>
383
384         Meta key is not the same as Alt key on windows.
385
386         Reviewed by Darin.
387
388         * DumpRenderTree/win/EventSender.cpp:
389         (keyDownCallback):
390
391 2008-01-09  Kevin McCullough  <kmccullough@apple.com>
392
393         Reviewed by Darin, Sam and Adam.
394
395         -<rdar://problem/5654486> REGRESSION (Safari 3.0.4-TOT): clicking on
396         link in gmail message displays JavaScript alert falsely complaining
397         about pop-up blocking.
398         - Added the ability to enable the pop-up blocker via the
399         LayoutTestController.
400
401         * DumpRenderTree/LayoutTestController.cpp:
402         (setPopupBlockingEnabledCallback):
403         (LayoutTestController::staticFunctions):
404         * DumpRenderTree/LayoutTestController.h:
405         * DumpRenderTree/mac/DumpRenderTree.mm:
406         (setDefaultsToConsistentValuesForTesting):
407         (resetWebViewToConsistentStateBeforeTesting):
408         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
409         (LayoutTestController::setPopupBlockingEnabled):
410
411 2008-01-10  Lars Knoll  <lars@trolltech.com>
412
413         Reviewed by Simon.
414
415         rename QWebPageHistory to QWebHistory.
416         
417
418         * DumpRenderTree/qt/jsobjects.cpp:
419
420 2008-01-09  Maciej Stachowiak  <mjs@apple.com>
421
422         Reviewed by Darin.
423         
424         - add some more renames, adjust some
425
426         * Scripts/do-webcore-rename:
427
428 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
429
430         Reviewed by Oliver.
431
432         Enable SVG Fonts support by default.
433
434         * Scripts/build-webkit:
435
436 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
437
438         Reviewed by Adam.
439
440         Fixes: http://bugs.webkit.org/show_bug.cgi?id=16244
441         DRT doesn't handle platform specific pixel test results correctly.
442
443         <test>-expected.txt files and <test>-expected.png files may now live
444         in different directories (ie. a cross-platform <test>-expected.txt file
445         and a platform-specific <test>-expected.png file).
446
447         * Scripts/run-webkit-tests:
448
449 2008-01-04  Kevin McCullough  <kmccullough@apple.com>
450
451         Reviewed by Darin.
452
453         - <rdar://problem/5666914> fast/regex/test{1,4}.html are failing
454         DRT did not correctly handle printing the '\0' char.  Now it does.
455
456         * DumpRenderTree/win/DumpRenderTree.cpp:
457         (dumpFramesAsText):
458         (dump):
459
460 2008-01-07  Simon Hausmann  <hausmann@webkit.org>
461
462         Reviewed by Lars.
463
464         Ported of the network backend of the Qt platform to Qt 4.4's new networking API.
465         
466
467         * DumpRenderTree/qt/main.cpp:
468         * DumpRenderTree/qt/testplugin.cpp:
469         * DumpRenderTree/qt/testplugin.h:
470
471 2008-01-05  Mark Rowe  <mrowe@apple.com>
472
473         Reviewed by Alp Toker.
474
475         Fix hang in fast/frames/frame-display-none-focus.html during Gtk layout tests.
476
477         * DumpRenderTree/gtk/DumpRenderTree.cpp:
478         (processWork): Process pending work.
479         (webViewLoadFinished): Schedule processing of pending work.
480         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Use webkit_web_frame_reload.
481
482 2008-01-05  Darin Adler  <darin@apple.com>
483
484         * Scripts/do-webcore-rename: Some more renaming plans.
485
486 2008-01-04  Alice Liu  <alice.liu@apple.com>
487
488         Reviewed by Alexey and Darin.
489
490         Adding "home" and "end" to DRT's keydown since
491         DOM key events can't handle keyIdentifiers at this point. 
492
493         * DumpRenderTree/mac/EventSendingController.mm:
494         (-[EventSendingController keyDown:withModifiers:]):
495         * DumpRenderTree/win/EventSender.cpp:
496         (keyDownCallback):
497
498 2008-01-04  Lars Knoll  <lars@trolltech.com>
499
500         Reviewed by Simon.
501
502         fix DRT after the changes to QWebPage.
503         
504         The great thing is that we actually don't have
505         any regressions from the QWebPage change :)
506         
507
508         * DumpRenderTree/qt/DumpRenderTree.cpp:
509         (WebCore::DumpRenderTree::DumpRenderTree):
510
511 2008-01-04  Lars Knoll  <lars@trolltech.com>
512
513         Reviewed by Simon.
514
515         make QWebPage a QObject and get things to compile.
516         
517         Nothing works currently though.
518         
519
520         * DumpRenderTree/qt/DumpRenderTree.cpp:
521         (WebCore::DumpRenderTree::DumpRenderTree):
522
523 2008-01-04  Lars Knoll  <lars@trolltech.com>
524
525         Reviewed by Simon.
526
527         take a QString as identifier in QWebFrame::addToJSWindowObject.
528
529         * DumpRenderTree/qt/DumpRenderTree.cpp:
530         (WebCore::DumpRenderTree::initJSObjects):
531
532 2008-01-04  Alp Toker  <alp@atoker.com>
533
534         GTK+ DRT build fix for breakage introduced in r29149.
535
536         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
537         (LayoutTestController::execCommand):
538
539 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
540
541         Reviewed by Darin.
542
543         <rdar://problem/5463489> A number of layout tests should be using execCommand instead of textInputController
544
545         Added layoutTestController.execCommand to access editor commands that are not available
546         via document.execCommand.
547
548         * DumpRenderTree/LayoutTestController.cpp:
549         (execCommandCallback):
550         (LayoutTestController::staticFunctions):
551         * DumpRenderTree/LayoutTestController.h:
552         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
553         (LayoutTestController::execCommand):
554         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
555         (LayoutTestController::queueLoad):
556         (LayoutTestController::execCommand):
557
558 2008-01-03  Alice Liu  <alice.liu@apple.com>
559
560         Reviewed by Darin, Mitz.
561
562         fixed <rdar://5130762> mousedowns in different locations increase the clickcount incorrectly
563
564         the clickcount should not increase if the last click was at a different location.  it's a new click.
565
566         * DumpRenderTree/mac/DumpRenderTree.mm:
567         (runTest):
568         * DumpRenderTree/mac/EventSendingController.h:
569         * DumpRenderTree/mac/EventSendingController.mm:
570         (-[EventSendingController mouseDown]):
571         (-[EventSendingController mouseUp]):
572
573 2008-01-03  Darin Adler  <darin@apple.com>
574
575         Reviewed by Adam.
576
577         * Scripts/update-webkit: Make this work a little better for the people at Apple
578         who have a directory named Internal.
579
580 2008-01-03  Adam Roben  <aroben@apple.com>
581
582         Use HTTP::Date instead of Date::Parse because it's installed by Cygwin by default
583
584         Rubberstamped by Mark.
585
586         * Scripts/update-webkit-auxiliary-libs:
587
588 2008-01-03  Adam Roben  <aroben@apple.com>
589
590         Fix Bug 15663: update-webkit re-downloads WebKitAuxiliaryLibrary unnecessarily
591
592         http://bugs.webkit.org/show_bug.cgi?id=15663
593
594         Added a fuzz factor into the Last-Modified comparison for downloading
595         WebKitAuxiliaryLibrary.zip.
596
597         The zip file is served from a set of mirrors who give Last-Modified
598         times that are off by 1-3 seconds from each other. This was causing
599         the build bots to redownload WebKitAuxiliaryLibrary for every build,
600         which would then cause all of WebCore to rebuild each time.
601
602         Reviewed by Mark.
603
604         * Scripts/update-webkit-auxiliary-libs: Check if the new zip file is
605         at least 30 seconds newer than the old one -- otherwise we assume that
606         the difference in time is due to the mirrors being slightly offset
607         from each other.
608         (sub lastModifiedToUnixTime): Added.
609
610 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
611
612         Windows build fix.
613
614         * DumpRenderTree/ForwardingHeaders/wtf/HashTraits.h: Added (needed by COMPtr.h).
615
616 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
617
618         Reviewed by Lars.
619
620         Moved QWebPage::open to QWebFrame::load and added setHtml.
621         
622
623         * DumpRenderTree/qt/DumpRenderTree.cpp:
624         (WebCore::DumpRenderTree::open):
625
626 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
627
628         Reviewed by Lars.
629
630         Added the first revision of QWebView and started moving functionality from QWebPave over to QWebView and QWebFrame.
631         
632
633         * DumpRenderTree/qt/DumpRenderTree.cpp:
634         (WebCore::DumpRenderTree::DumpRenderTree):
635
636 2008-01-02  Sam Weinig  <sam@webkit.org>
637
638         * Scripts/do-webcore-rename: Yet more renaming ideas.
639
640 2008-01-02  Darin Adler  <darin@apple.com>
641
642         * Scripts/do-webcore-rename: More renaming ideas. (Maciej, please merge yours with mine.)
643
644 2008-01-02  Alice Liu  <alice.liu@apple.com>
645
646         Reviewed by Sam Weinig.
647
648         fixing assertion hit with editing/selection/move-begin-end.html
649
650         * DumpRenderTree/ForwardingHeaders/wtf/ASCIICType.h: Added.
651         * DumpRenderTree/win/DumpRenderTree.vcproj:
652         * DumpRenderTree/win/EventSender.cpp:
653         (keyDownCallback):
654         using isupper will cause an assertion for inputs outside of ascii range. use isASCIIUpper instead.
655
656 2008-01-02  Darin Adler  <darin@apple.com>
657
658         * Scripts/do-webcore-rename: Some more name change plans.
659
660 2008-01-02  Alice Liu  <alice.liu@apple.com>
661
662         Reviewed by Maciej.
663
664         Added handling for page up and page down in EventSender
665
666         * DumpRenderTree/mac/EventSendingController.mm:
667         (-[EventSendingController keyDown:withModifiers:]):
668         * DumpRenderTree/win/EventSender.cpp:
669         (keyDownCallback):
670
671 2008-01-02  Alexey Proskuryakov  <ap@webkit.org>
672
673         Reviewed by Darin.
674
675         Fix fast/events/arrow-keys-on-body.html for real.
676
677         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Pass proper keyData for WM_KEYUP, too.
678
679 2008-01-02  Luca Bruno  <lethalman88@gmail.com>
680
681         Reviewed by Darin.
682
683         http://bugs.webkit.org/show_bug.cgi?id=16674
684         [GTK] run-launcher sets wrong LD_LIBRARY_PATH
685
686         * Scripts/run-launcher:
687
688 2007-12-31  Darin Adler  <darin@apple.com>
689
690         Suggested by Antti.
691
692         * Scripts/webkitdirs.pm: Turned off the QuickTime requirement for Windows until
693         we get it installed on the build bots.
694
695 2007-12-30  Eric Seidel  <eric@webkit.org>
696
697         Reviewed by Sam.
698
699         * Scripts/do-webcore-rename: Add a few more planned renames s/(\w+)Imp/\1/
700
701 2007-12-29  Darin Adler  <darin@apple.com>
702
703         Reviewed by Oliver.
704
705         - fix http://bugs.webkit.org/show_bug.cgi?id=16663
706           leak bot shows createCStringFromNPVariant result leaking
707
708         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
709         (pluginInvoke): Added a missing free.
710
711 2007-12-26  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
712
713         Reviewed by Alp Toker.
714
715         http://bugs.webkit.org/show_bug.cgi?id=16390
716         Use autotools or GNU make as the build system for the GTK port
717
718         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: include glib.h
719         * GNUmakefile.am: Added.
720
721 2007-12-24  Alexey Proskuryakov  <ap@webkit.org>
722
723         Reviewed by Oliver.
724
725         Fix fast/events/arrow-keys-on-body.html, failing on Windows.
726
727         * DumpRenderTree/win/EventSender.cpp:
728         (keyDownCallback): Add KF_EXTENDED flag to arrow keys. Also add a count
729         of 1, even though WebKit currently ignores it.
730
731 2007-12-23  Kevin Ollivier  <kevino@theolliviers.com>
732
733         wx buildbot fix. Update libpng dl script to the latest version.
734
735         * wx/install-unix-extras:
736
737 2007-12-22  Antti Koivisto  <antti@apple.com>
738
739         Fix a typo.
740
741         * Scripts/webkitdirs.pm:
742
743 2007-12-21  Sam Weinig  <sam@webkit.org>
744
745         Reviewed by Mark Rowe.
746
747         - Disable the back/forward cache using the new WebPreferences API
748           instead of through the BackForwardList.  This makes us match what
749           we do on Windows.
750
751         * DumpRenderTree/mac/DumpRenderTree.mm:
752         (createWebViewAndOffscreenWindow):
753         (setDefaultsToConsistentValuesForTesting):
754
755 2007-12-21  Dan Bernstein  <mitz@apple.com>
756
757         Reviewed by Mark Rowe.
758
759         - disable the back/forward cache in Windows DumpRenderTree. It is
760           already disabled in Mac DumpRenderTree.
761
762         * DumpRenderTree/win/DumpRenderTree.cpp:
763         (initializePreferences):
764
765 2007-12-13  Antti Koivisto  <antti@apple.com>
766
767         Reviewed by Darin and Steve.
768         
769         - check for QuickTime SDK on Windows.
770         - build media support on Windows by default
771
772         * Scripts/build-webkit:
773         * Scripts/webkitdirs.pm:
774
775 2007-12-21  Kevin Ollivier  <kevino@theolliviers.com>
776
777         Build script fix for buildbot.
778
779         * wx/build-wxwebkit:
780
781 2007-12-20  Eric Seidel  <eric@webkit.org>
782
783         Reviewed by mjs.
784
785         * Scripts/run-sunspider: change --runs default to 10 for better accuracy
786
787 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
788
789         Reviewed by Steve.
790
791         - <rdar://5656485> Drosera: Win: Nightly does not reliably connect to
792         WebKit.
793
794         - Drosera and Safari need to use the same ProgIDs in order for
795         CoCreateInstance to work properly.  The most robust way to do this is
796         for WebKit to dynamically publish those ProgIDs.
797
798         * Drosera/win/DebuggerClient.cpp: Use the published ProgIDs
799         (DebuggerClient::createWebViewWithRequest):
800         * Drosera/win/Drosera.cpp: Use the published ProgIDs and rename some
801         statics.
802         (Drosera::initUI):
803         (Drosera::attach):
804         (Drosera::attemptToCreateServerConnection):
805         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Fix a runtime failure.
806         * Drosera/win/ServerConnection.cpp: Reformat the connection function and
807         make use of the published ProgIDs.
808         (ServerConnection::attemptToCreateServerConnection):
809
810 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
811
812         - <rdar://problem/5658317> REGRESSION: 20+ leaks seen on buildbots.
813         - Build bot and leak fix.
814
815         * DumpRenderTree/LayoutTestController.cpp:
816         (pathToLocalResourceCallback):
817
818 2007-12-19  David Kilzer  <ddkilzer@apple.com>
819
820         Make svn-apply/svn-unapply work with patches from git-format-patch.
821
822         Reviewed by Darin.
823
824         * Scripts/svn-apply:
825         (patch): If 'Index:' can't be found in the text passed in, print it
826         out with a warning and return early.
827         * Scripts/svn-unapply:
828         (patch): Ditto.
829
830 2007-12-18  Kevin Ollivier  <kevino@theolliviers.com>
831
832         Reviewed by Alp Toker.
833
834         Build related fixes.
835
836         * wx/build-wxwebkit:
837         - Check to make sure the user is running a supported wx port
838         - More robust checks for Cygwin
839         - Only run install-unix-extras on Mac, it's not the right solution
840           for Linux distros.
841         - Remove outdated Linux instructions after successful build
842         - Clean Bakefile-generated files during a clean operation
843
844 2007-12-18  Darin Adler  <darin@apple.com>
845
846         * Scripts/make-js-test-wrappers: Don't generate a wrapper for select-options-remove.js.
847
848 2007-12-18  Steve Falkenburg  <sfalken@apple.com>
849
850         Add script to run Drosera as part of the nightly.
851         
852         Reviewed by Kevin M.
853
854         * Scripts/run-drosera.cmd: Added.
855
856 2007-12-18  Darin Adler  <darin@apple.com>
857
858         * Scripts/do-webcore-rename: Remove a stray K.
859
860 2007-12-18  Darin Adler  <darin@apple.com>
861
862         * Scripts/do-webcore-rename: Plan more renaming.
863
864 2007-12-14  Juan A. Suarez Romero  <jasuarez@igalia.com>
865
866         Reviewed by Alp Toker.
867
868         http://bugs.webkit.org/show_bug.cgi?id=16042
869         [GTK] Eliminate webkit_init()
870
871         Moving webkit initialization to WebView class init.
872
873         * DumpRenderTree/gtk/DumpRenderTree.cpp:
874         (main):
875         * GtkLauncher/main.c:
876         (main):
877
878 2007-12-17  Luca Bruno  <lethalman88@gmail.com>
879
880         Reviewed by Alp Toker.
881
882         http://bugs.webkit.org/show_bug.cgi?id=13542
883         gdklauncher doesnt change URL in adress GTKEntry.
884
885         * GtkLauncher/main.c:
886         (load_commit_cb): added
887         (title_change_cb):
888         (create_browser):
889
890 2007-12-16  Dimitri Glazkov  <dimitri@glazkov.com>
891
892         Reviewed by Adam Roben.
893
894         Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.
895
896         * FindSafari/FindSafari.cpp:
897         (_tmain):
898
899 2007-12-16  Brent Fulgham  <bfulgham@gmail.com>
900
901         Reviewed by Adam Roben.
902
903         http://bugs.webkit.org/show_bug.cgi?id=16315
904         FindSafari needs a path-only option.
905
906         * FindSafari/FindSafari.cpp:
907         (_tmain):
908
909 2007-12-16  Alexey Proskuryakov  <ap@webkit.org>
910
911         Reviewed by Darin.
912
913         http://bugs.webkit.org/show_bug.cgi?id=16462
914         REGRESSION: access keys broken on Windows
915
916         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Send system key events
917         if Alt is pressed.
918
919 2007-12-15  Sam Weinig  <sam@webkit.org>
920
921         Reviewed by Mark Rowe.
922
923         Fix urlSuitableForTestResult to correctly identify wstring::npos as
924         the case when wstring.find doesn't find anything.
925
926         * DumpRenderTree/win/DumpRenderTree.cpp:
927         (urlSuitableForTestResult):
928
929 2007-12-15  Alp Toker  <alp@atoker.com>
930
931         GTK+ DRT build fix for GLib < 2.14.
932
933         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
934         (LayoutTestController::setWaitToDump):
935
936 2007-12-05  Mark Rowe  <mrowe@apple.com>
937
938         Reviewed by Alp Toker.
939
940         Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.  This prevents
941         many layout tests from hanging while waiting on user responses to dialogs.
942
943         * DumpRenderTree/gtk/DumpRenderTree.cpp:
944         (invalidateAnyPreviousWaitToDumpWatchdog):
945         (webViewScriptAlert):
946         (webViewScriptPrompt):
947         (webViewScriptConfirm):
948         (main):
949         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
950         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
951         (waitToDumpWatchdogFired):
952         (LayoutTestController::setWaitToDump):
953
954 2007-12-05  Mark Rowe  <mrowe@apple.com>
955
956         Reviewed by Alp Toker.
957
958         Flesh out DumpRenderTree for Gtk.  After these changes, the majority of the tests in fast/js pass.
959
960         * DumpRenderTree/gtk/DumpRenderTree.cpp:
961         (dumpFramesAsText): Don't print the frame name when dumping the main frame as text.
962         (dump):
963         (runTest):
964         (webViewLoadStarted): Store the top frame when it starts loading so we can use it to determine when to dump.
965         (webViewLoadFinished): Dump when the top frame load completes if we're not waiting for a JS callback and the
966         work queue is empty.
967         (webViewWindowObjectCleared): Set up window.layoutTestController.
968         (webViewConsoleMessage): Match the console message format expected by the layout test results.
969         (main): Hook up the new signals.
970         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
971         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Only notify done if the top frame has completed loading to avoid
972         dumping multiple times.
973         * Scripts/build-dumprendertree: Ensure build-dumprendertree is a no-op for Gtk too.
974         * Scripts/run-webkit-tests: Teach run-webkit-tests that Gtk is like Qt in many ways.  Use run-launcher to open test results.
975
976 2007-12-14  Anders Carlsson  <andersca@apple.com>
977
978         Reviewed by Brady.
979
980         Assert that a web frame that's loading a resource always has either a data source or 
981         a provisional data source.
982         
983         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
984         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
985
986 2007-12-14  Darin Adler  <darin@apple.com>
987
988         - fix mistake causing nearly all tests to fail on Windows
989
990         * DumpRenderTree/win/UIDelegate.cpp:
991         (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with
992         npos, not 0. Also pass URL in to URL function rather than passing the entire message.
993
994         * DumpRenderTree/mac/UIDelegate.mm:
995         (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather
996         than passing the entire message.
997
998 2007-12-14  Darin Adler  <darin@apple.com>
999
1000         - fix Tiger build
1001
1002         * DumpRenderTree/mac/UIDelegate.mm:
1003         (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any
1004         new-to-Leopard methods.
1005
1006 2007-12-14  Darin Adler  <darin@apple.com>
1007
1008         * DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method
1009         since it now triggers unwanted icon loading. We only had it because we implemented "all"
1010         delegate methods here.
1011
1012 2007-12-14  Anders Carlsson  <andersca@apple.com>
1013
1014         Reviewed by Darin and Geoff.
1015
1016         <rdar://problem/5619295> 
1017         REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
1018         
1019         Add property getting methods to the plug-in.
1020         
1021         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1022         (pluginInvoke):
1023
1024 2007-12-14  Kevin McCullough  <kmccullough@apple.com>
1025
1026         Reviewed by Darin.
1027
1028         - Layout test fix for mac. When dumped to the console local file paths
1029         now only show the name of the resource not the whole path.  This is to
1030         make the results machine and OS independent.
1031
1032         * DumpRenderTree/mac/UIDelegate.mm:
1033         (-[UIDelegate webView:addMessageToConsole:]):
1034
1035 2007-12-13  Kevin McCullough  <kmccullough@apple.com>
1036
1037         Reviewed by Adam.
1038
1039         - Layout tests fix.  We need a way to remove machine-dependent
1040         information from paths in layout test results. The UIDelegate now does
1041         this.
1042
1043         * DumpRenderTree/DumpRenderTree.h:
1044         * DumpRenderTree/win/DumpRenderTree.cpp:
1045         (urlSuitableForTestResult):
1046         * DumpRenderTree/win/DumpRenderTreeWin.h:
1047         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1048         * DumpRenderTree/win/UIDelegate.cpp:
1049         (UIDelegate::webViewAddMessageToConsole):
1050
1051 2007-12-13  Alp Toker  <alp@atoker.com>
1052
1053         Build fix for DRT breakage introduced in r28690.
1054
1055         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1056         (LayoutTestController::pathToLocalResource):
1057
1058 2007-12-12  Kevin McCullough  <kmccullough@apple.com>
1059
1060         Reviewed by Alice and Sam.
1061
1062         - <rdar://5621435> Need a way to specify local resources (being loaded
1063         from HTTP tests) on Windows.
1064         - Implemented pathToLocalResource which exposes the functionality of
1065         converting a given unix path to the correct location on Windows.
1066
1067         * DumpRenderTree/LayoutTestController.cpp:
1068         (pathToLocalResourceCallback):
1069         (LayoutTestController::staticFunctions):
1070         * DumpRenderTree/LayoutTestController.h:
1071         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1072         (LayoutTestController::pathToLocalResource):
1073         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1074         (LayoutTestController::pathToLocalResource):
1075
1076 2007-12-12  Anders Carlsson  <andersca@apple.com>
1077
1078         Reviewed by Sam.
1079
1080         <rdar://problem/5132003>
1081         dumpResourceLoadCallbacks is not implemented in DRT on Windows.
1082
1083         * DumpRenderTree/win/DumpRenderTree.cpp:
1084         (main):
1085         Set the resource load delegate.
1086         
1087         * DumpRenderTree/win/DumpRenderTree.vcproj:
1088         
1089         * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
1090         * DumpRenderTree/win/ResourceLoadDelegate.h: Added.
1091
1092 2007-12-12  Alexey Proskuryakov  <ap@webkit.org>
1093
1094         Reviewed by Adam Roben.
1095
1096         Fix conversion from double to LPARAM in dispatchMessage().
1097
1098         * DumpRenderTree/win/EventSender.cpp:
1099         (dispatchMessageCallback):
1100
1101 2007-12-11  Dan Bernstein  <mitz@apple.com>
1102
1103         Reviewed by Mark Rowe and Sam Weinig too!
1104
1105         - added Helvetica Oblique and Helvetica Bold Oblique to the list of
1106           fonts DumpRenderTree registers.
1107
1108         * DumpRenderTree/win/DumpRenderTree.cpp:
1109         (initialize):
1110
1111 2007-12-11  Brady Eidson  <beidson@apple.com>
1112
1113         Reviewed by Anders
1114
1115         Make DumpRenderTree on mac use its own path for Databases testing
1116
1117         * DumpRenderTree/mac/DumpRenderTree.mm:
1118         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree 
1119           for future DRT-only use, then use it to construct the Databases path and set that default
1120
1121 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
1122
1123         Reviewed by Darin.
1124
1125         <rdar://problem/5535636>
1126         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
1127
1128         http://bugs.webkit.org/show_bug.cgi?id=13916
1129         JavaScript detects Tab as a character input on a textfield validation
1130
1131         * DumpRenderTree/mac/EventSendingController.mm:
1132         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
1133         Dispatch a keyup to better match what happens when a key is physically pressed.
1134
1135         * DumpRenderTree/win/EventSender.cpp:
1136         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
1137         returning from keyDown().
1138         (getConstantCallback): Fixed a couple copy/paste mistakes.
1139
1140 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
1141
1142         Reviewed by Oliver.
1143
1144         - <rdar://5599845> Drosera: Does not show loal files in the file list
1145         on the left side.
1146
1147         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
1148         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
1149         so the open source community can build.
1150
1151 2007-12-10  Brady Eidson  <beidson@apple.com>
1152
1153         Rubberstamped by Sam Weinig
1154
1155         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
1156
1157         * DumpRenderTree/mac/UIDelegate.mm:
1158         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
1159         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
1160
1161 2007-12-08  Oliver Hunt  <oliver@apple.com>
1162
1163         Reviewed by Sam W.
1164
1165         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
1166         
1167         Fixes <rdar://problem/5620249> Must disable SVG animation
1168         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
1169         
1170         In order to allow finer grained control over the set of SVG features
1171         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
1172         distinct flags:
1173         ENABLE_SVG_ANIMATION
1174         ENABLE_SVG_FILTERS
1175         ENABLE_SVG_FONTS
1176         ENABLE_SVG_AS_IMAGE
1177         ENABLE_SVG_USE
1178         
1179         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
1180         
1181         Script handles all the new build flags, and allows --svg-experimental
1182         to automatically enable all features.
1183
1184         * Scripts/build-webkit:
1185
1186 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
1187
1188         Fix version parsing.
1189
1190         Rubber-stamped by Oliver.
1191
1192         * Drosera/win/Drosera.vcproj/auto-version.sh:
1193
1194 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
1195
1196         Build modifications for Drosera.
1197
1198         Reviewed by Adam.
1199
1200         * Drosera/DroseraWin.make: Added.
1201         * Drosera/win/Drosera.vcproj/Drosera.rc:
1202         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1203         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
1204         * Drosera/win/Drosera.vcproj/VERSION: Added.
1205         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
1206
1207 2007-12-06  Adam Roben  <aroben@apple.com>
1208
1209         Explicitly turn on the Mac font ascent hack on Windows
1210
1211         This keeps our font metrics matching those from Mac.
1212
1213         Reviewed by Hyatt.
1214
1215         * DumpRenderTree/win/DumpRenderTree.cpp:
1216         (main):
1217
1218 2007-12-06  Anders Carlsson  <andersca@apple.com>
1219
1220         Rename main.c to main.cpp here too.
1221         
1222         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
1223
1224 2007-12-06  Sam Weinig  <sam@webkit.org>
1225
1226         Rubber stamped by Geoff.
1227
1228         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
1229
1230 2007-12-06  Darin Adler  <darin@apple.com>
1231
1232         * Scripts/do-webcore-rename: Some more renaming plans.
1233
1234 2007-12-06  Anders Carlsson  <andersca@apple.com>
1235
1236         Restore implementation of testGetIntIdentifier that was accidentally
1237         removed somehow (possibly when I made PluginObject be a cpp file).
1238         
1239         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1240         (pluginInvoke):
1241
1242 2007-12-05  Anders Carlsson  <andersca@apple.com>
1243
1244         Make the entry points extern "C".
1245         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1246         
1247 2007-12-05  Anders Carlsson  <andersca@apple.com>
1248
1249         C++ warning fixes.
1250         
1251         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1252         (NPP_New):
1253         (NPP_Destroy):
1254         (NPP_SetWindow):
1255         (NPP_NewStream):
1256         (NPP_HandleEvent):
1257         (NPP_URLNotify):
1258         (NPP_GetValue):
1259
1260 2007-12-05  Anders Carlsson  <andersca@apple.com>
1261
1262         Add the .cpp files to the TestNetscapePlugIn target.
1263
1264         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1265
1266 2007-12-05  Anders Carlsson  <andersca@apple.com>
1267
1268         Reviewed by Geoff.
1269         
1270         Rename the TestNetscapePlugIn .c files to be .cpp.
1271
1272         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1273         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
1274         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
1275         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
1276         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
1277         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
1278         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
1279         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1280
1281 2007-12-05  Adam Roben  <aroben@apple.com>
1282
1283         Fix case of keypresses from the Windows implementation of eventSender.keyDown
1284
1285         This fixes several regression tests.
1286
1287         Reviewed by Alice.
1288
1289         * DumpRenderTree/win/EventSender.cpp:
1290         (keyDownCallback): Virtual keycodes for ASCII characters are always
1291         uppercase, so we need to check the case of the original character
1292         passed in to eventSender.keyDown.
1293
1294 2007-12-05  Adam Roben  <aroben@apple.com>
1295
1296         Learn from Tim's mistakes
1297
1298         * DumpRenderTree/win/DumpRenderTree.cpp:
1299         (runTest): Reset the authorAndUserStylesEnabled preference for each
1300         test.
1301
1302 2007-12-05  Alp Toker  <alp@atoker.com>
1303
1304         Reviewed by Mark Rowe.
1305
1306         Initialize GTK+ and WebKit so the tests can run.
1307
1308         Reorganize the headers a little.
1309
1310         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1311         (main):
1312
1313 2007-12-04  Anders Carlsson  <andersca@apple.com>
1314
1315         Remove IWebScriptScope include.
1316         
1317         * Drosera/win/DebuggerDocumentPlatform.cpp:
1318
1319 2007-12-04  Sam Weinig  <sam@webkit.org>
1320
1321         Rubber stamped by Mark Rowe.
1322
1323         Define CF as platform for mac and revert r28409
1324
1325         * DumpRenderTree/DumpRenderTree.h:
1326         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1327
1328 2007-12-04  Sam Weinig  <sam@webkit.org>
1329
1330         Define CF as platform for windows.
1331
1332         Reviewed by Adam Roben.
1333
1334         * DumpRenderTree/win/DumpRenderTreeWin.h:
1335
1336 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
1337
1338         Reviewed by Adam and Darin.
1339
1340         - Removed a needless BSTR cleanup.
1341
1342         * Drosera/win/DebuggerDocumentPlatform.cpp:
1343         (DebuggerDocument::getPlatformCurrentFunctionStack):
1344
1345 2007-11-27  Adam Roben  <aroben@apple.com>
1346
1347         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
1348
1349         Reviewed by Maciej.
1350
1351         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1352         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
1353
1354 2007-12-04  Alp Toker  <alp@atoker.com>
1355
1356         Prospective Win DRT build fix.
1357
1358         * DumpRenderTree/DumpRenderTree.h:
1359
1360 2007-12-04  Alp Toker  <alp@atoker.com>
1361
1362         Fix a clobbered copyright header.
1363
1364         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1365
1366 2007-12-04  Xan Lopez  <xan@gnome.org>
1367
1368         Reviewed by Alp Toker.
1369
1370         http://bugs.webkit.org/show_bug.cgi?id=15561
1371         GTK port needs DumpRenderTree implementation
1372
1373         Start work on the GTK+ DRT.
1374
1375         This does not work yet, and there are a few lingering style issues
1376         (nothing major) but this patch has been stuck in the bug tracker for
1377         too long already.
1378
1379         * DumpRenderTree/DumpRenderTree.h:
1380         * DumpRenderTree/gtk: Added.
1381         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
1382         (autocorrectURL):
1383         (shouldLogFrameLoadDelegates):
1384         (dumpFrameScrollPosition):
1385         (displayWebView):
1386         (appendString):
1387         (dumpFramesAsText):
1388         (dumpRenderTreeAsText):
1389         (dump):
1390         (runTest):
1391         (main):
1392         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
1393         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
1394         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
1395         (GCController::collect):
1396         (GCController::collectOnAlternateThread):
1397         (GCController::getJSObjectCount):
1398         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
1399         (LayoutTestController::~LayoutTestController):
1400         (LayoutTestController::addDisallowedURL):
1401         (LayoutTestController::clearBackForwardList):
1402         (LayoutTestController::copyDecodedHostName):
1403         (LayoutTestController::copyEncodedHostName):
1404         (LayoutTestController::display):
1405         (LayoutTestController::keepWebHistory):
1406         (LayoutTestController::notifyDone):
1407         (LayoutTestController::queueBackNavigation):
1408         (LayoutTestController::queueForwardNavigation):
1409         (LayoutTestController::queueLoad):
1410         (LayoutTestController::queueReload):
1411         (LayoutTestController::queueScript):
1412         (LayoutTestController::setAcceptsEditing):
1413         (LayoutTestController::setCustomPolicyDelegate):
1414         (LayoutTestController::setMainFrameIsFirstResponder):
1415         (LayoutTestController::setTabKeyCyclesThroughElements):
1416         (LayoutTestController::setUseDashboardCompatibilityMode):
1417         (LayoutTestController::setUserStyleSheetEnabled):
1418         (LayoutTestController::setUserStyleSheetLocation):
1419         (LayoutTestController::setWindowIsKey):
1420         (LayoutTestController::setWaitToDump):
1421         (LayoutTestController::windowCount):
1422         (LayoutTestController::setPrivateBrowsingEnabled):
1423         (LayoutTestController::setAuthorAndUserStylesEnabled):
1424         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
1425         (JSStringCopyUTF8CString):
1426         (LoadItem::invoke):
1427         (ReloadItem::invoke):
1428         (ScriptItem::invoke):
1429         (BackForwardItem::invoke):
1430
1431 2007-12-03  Sam Weinig  <sam@webkit.org>
1432
1433         Move JavaScriptCore thread testing code to pthread specific directory
1434         and remove the dependance on CoreFoundation by using WTF::HashSet.
1435
1436         Reviewed by Geoff and Oliver.
1437
1438         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1439         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
1440         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
1441         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
1442         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
1443         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
1444         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
1445         * DumpRenderTree/pthreads: Added.
1446         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
1447         (javaScriptThreads):
1448         (runJavaScriptThread):
1449         (startJavaScriptThreads):
1450         (stopJavaScriptThreads):
1451
1452 2007-12-03  Andrew Bonventre  <andybons@google.com>
1453
1454         Reviewed by Darin Adler.
1455
1456         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
1457         Symbol lookup menu broken in debugger view
1458
1459         * Drosera/debugger.js: Fixed javascript error where document property
1460         should have been used instead of contentDocument in switchFunction that
1461         was breaking the select symbol dropdown menu.  This is because
1462         window.frames will return a Window object and not a frame object like
1463         the author was originally expecting.
1464
1465 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
1466
1467         Reviewed by Adam.
1468
1469         - <rdar://5618942> Drosera: Console window does not process everything
1470         correctly.
1471         - <rdar://5619005> Drosera: could be sped up by moving the 
1472         WebScriptScope stuff into the WebScriptCallFrame.
1473         - Now the console can correctly process objects and does not receive
1474         notifications from JavaScriptCore about the JavaScript in Drosera's
1475         own process.
1476
1477         * Drosera/win/DebuggerDocumentPlatform.cpp:
1478         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1479         (DebuggerDocument::platformValueForScopeVariableNamed):
1480
1481 2007-12-03  Stephanie  <slewis@apple.com>
1482
1483         Reviewed by Darin.
1484
1485         Check to see if we are building a debug root
1486
1487         * Scripts/check-for-global-initializers: 
1488
1489 2007-12-03  Dan Bernstein  <mitz@apple.com>
1490
1491         Reviewed by Darin Adler.
1492
1493         - added a testGetIntIdentifier() method to TestNetscapePlugIn
1494
1495         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
1496         (pluginInvoke):
1497
1498 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
1499
1500         Reviewed by Oliver.
1501
1502         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
1503         in a more fine-grained manner than eventSender.keyDown().
1504
1505         * DumpRenderTree/win/EventSender.cpp:
1506         (getConstantCallback):
1507         (dispatchMessageCallback):
1508
1509 2007-12-02  Darin Adler  <darin@apple.com>
1510
1511         * Scripts/do-webcore-rename: More planned renaming.
1512
1513 2007-12-02  Sam Weinig  <sam@webkit.org>
1514
1515         Rubber stamped by Anders.
1516
1517         Use [NSURL absoluteString] instead of [NSURL description] in order to get
1518         more uniform results cross platform.
1519
1520         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1521         (-[NSURL _drt_descriptionSuitableForTestResult]):
1522
1523 2007-12-02  Sam Weinig  <sam@webkit.org>
1524
1525         Rubber stamped by Niko.
1526
1527         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
1528
1529         * DumpRenderTree/win/DumpRenderTree.cpp:
1530         * DumpRenderTree/win/DumpRenderTree.vcproj:
1531         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
1532         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
1533         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
1534         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
1535
1536 2007-12-01  Alp Toker  <alp@atoker.com>
1537
1538         Reviewed by Adam Roben.
1539
1540         Make use of the newly introduced webkit.h convenience header.
1541
1542         * GtkLauncher/main.c:
1543
1544 2007-12-01  Adam Treat  <treat@kde.org>
1545
1546         Reviewed by Simon.
1547
1548         * Check to see if the directory exists and exit if not.
1549
1550         * DumpRenderTree/qt/main.cpp:
1551         (main):
1552
1553 2007-12-01  Adam Treat  <treat@kde.org>
1554
1555         Reviewed by Simon.
1556
1557         * Don't hide symbols when in Debug mode
1558         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
1559
1560
1561         * DumpRenderTree/qt/main.cpp:
1562         (messageHandler):
1563
1564 2007-11-30  Alp Toker  <alp@atoker.com>
1565
1566         Reviewed by Adam Roben.
1567
1568         http://bugs.webkit.org/show_bug.cgi?id=15691
1569         [GTK] Public API does not follow GTK+ conventions
1570
1571         Refactor the WebKit/GTK+ public API. Changes:
1572           WebKitPage -> WebKitWebView
1573           WebKitFrame -> WebKitWebFrame
1574
1575         Public API source and header names have been updated to mirror the API
1576         changes.
1577
1578         The API is now kept in WebKit/gtk/WebView to match other ports in the
1579         same class such as Mac and Win.
1580
1581         * GtkLauncher/main.c:
1582         (activate_uri_entry_cb):
1583         (link_hover_cb):
1584         (title_change_cb):
1585         (progress_change_cb):
1586         (go_back_cb):
1587         (go_forward_cb):
1588         (create_browser):
1589         (main):
1590
1591 2007-11-30  Adam Roben  <aroben@apple.com>
1592
1593         Hopefully the final build fix
1594
1595         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
1596         pull in WTF's assertion/logging functions.
1597
1598 2007-11-30  Adam Roben  <aroben@apple.com>
1599
1600         Another build fix
1601
1602         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
1603         WebKit.lib.
1604
1605 2007-11-30  Adam Roben  <aroben@apple.com>
1606
1607         Debug build fix
1608
1609         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
1610         configuration.
1611         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
1612         projects.
1613         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
1614         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
1615         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
1616
1617 2007-11-30  Sam Weinig  <sam@webkit.org>
1618
1619         Reviewed by Adam Roben.
1620
1621         Fix drawSelectionRect to actually draw the selection rect.
1622
1623         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1624         (drawSelectionRect):
1625
1626 2007-11-30  Darin Adler  <darin@apple.com>
1627
1628         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
1629
1630 2007-11-30  Darin Adler  <darin@apple.com>
1631
1632         * Scripts/do-webcore-rename: Get ready for some future renaming.
1633
1634 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1635
1636         Reviewed by Adam.
1637
1638         - Removed some unnecessary functions and changed an unused return type. 
1639
1640         * Drosera/win/DebuggerClient.cpp:
1641         (registerConsoleClass):
1642         * Drosera/win/DebuggerClient.h:
1643         * Drosera/win/Drosera.cpp:
1644         (registerDroseraClass):
1645
1646 2007-11-28  Alp Toker  <alp@atoker.com>
1647
1648         Reviewed by Timothy Hatcher.
1649
1650         http://bugs.webkit.org/show_bug.cgi?id=16174
1651         [GTK] Use "URI" not "URL" in public API
1652
1653         Replace use of the term "URL" with "URI" in public headers,
1654         documentation and some internal code to match GLib/GTK+ convention.
1655
1656         This is now mentioned in the API guidelines:
1657           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
1658
1659         * GtkLauncher/main.c:
1660         (activate_uri_entry_cb):
1661         (title_change_cb):
1662         (create_toolbar):
1663         (main):
1664
1665 2007-11-29  Anders Carlsson  <andersca@apple.com>
1666
1667         Reviewed by Sam.
1668
1669         <rdar://problem/5230478>
1670         FrameLoadDelegate callbacks are not dumped in DRT.
1671         
1672         * DumpRenderTree/win/DumpRenderTree.cpp:
1673         (shouldLogFrameLoadDelegates):
1674         (runTest):
1675         (main):
1676         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
1677         (BSTRtoString):
1678         (descriptionSuitableForTestResult):
1679         (FrameLoadDelegate::QueryInterface):
1680         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
1681         (FrameLoadDelegate::didFailProvisionalLoadWithError):
1682         (FrameLoadDelegate::didCommitLoadForFrame):
1683         (FrameLoadDelegate::didFinishLoadForFrame):
1684         (FrameLoadDelegate::willCloseFrame):
1685         (FrameLoadDelegate::didClearWindowObject):
1686         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
1687         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
1688         * DumpRenderTree/win/FrameLoaderDelegate.h:
1689         (FrameLoadDelegate::windowScriptObjectAvailable):
1690         (FrameLoadDelegate::didFirstLayoutInFrame):
1691
1692 2007-11-29  Sam Weinig  <sam@webkit.org>
1693
1694         Reviewed by Anders.
1695
1696         Add database quota UIDelegates methods to DRT UIDelegate.
1697
1698         * DumpRenderTree/mac/UIDelegate.mm:
1699         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
1700         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
1701
1702 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1703
1704         Reviewed by Sam.
1705
1706         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
1707         dying and vice versa.
1708         - This fix will allow Drosera and Safari to reconnect if either of them
1709         closes correctly, but does not fix the case where one of them dies
1710         silently.
1711
1712         * Drosera/win/ServerConnection.cpp:
1713         (ServerConnection::attemptToCreateServerConnection): Added a safety
1714         check, because it's possilbe to try to connect to a server that's dying.
1715         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
1716         the server has died.
1717         * Drosera/win/ServerConnection.h: Added the new function and removed
1718         an unnecessary member.
1719
1720 2007-11-29  Anders Carlsson  <andersca@apple.com>
1721
1722         * DumpRenderTree/win/DumpRenderTree.vcproj:
1723         Add shlwapi.lib to all configurations.
1724
1725 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1726
1727         - Build fix.  Added additional includes for VS Express to the Release
1728         project.
1729
1730         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1731
1732 2007-11-29  Anders Carlsson  <andersca@apple.com>
1733
1734         Reviewed by Adam.
1735
1736         <rdar://problem/5132005>
1737         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
1738         
1739         * DumpRenderTree/win/DumpRenderTree.vcproj:
1740         Add shlwapi.lib
1741         
1742         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1743         (LayoutTestController::setUserStyleSheetEnabled):
1744         Implement this.
1745         
1746         (appendComponentToPath):
1747         New method which wraps the Win32 API PathAppend.
1748         
1749         (followShortcuts):
1750         New method which checks if a file points to a shortcut and
1751         follows the shortcut.
1752         
1753         (resolveCygwinPath):
1754         New method that takes a cygwin unix-style path and returns the Win32 path.
1755         
1756         (cfStringRefToWString):
1757         
1758         (LayoutTestController::setUserStyleSheetLocation):
1759         Implement this.
1760
1761 2007-11-29  Alice Liu  <alice.liu@apple.com>
1762
1763         Reviewed by Adam.
1764
1765         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
1766
1767         * DumpRenderTree/win/EventSender.cpp:
1768         (keyDownCallback):
1769         uppercase letters were being sent as lowercase letters without the shift key down.
1770
1771 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1772
1773         - Windows build fix. VS express needs some love.
1774
1775         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1776
1777 2007-11-28  Darin Adler  <darin@apple.com>
1778
1779         Reviewed by Adam Roben.
1780
1781         * DumpRenderTree/mac/EventSendingController.mm:
1782         (-[EventSendingController keyDown:withModifiers:]):
1783         Send capital letters through as lowercase letters with the shift key down
1784         rather than sending them as if they were highly unusual "capital letter keys".
1785
1786         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
1787         where you need to update results and more tests are failing than before.
1788
1789 2007-11-28  Anders Carlsson  <andersca@apple.com>
1790
1791         Reviewed by Darin.
1792
1793         <rdar://problem/5132001>
1794         contextClick is not implemented in DRT on Windows.
1795         
1796         * DumpRenderTree/win/EventSender.cpp:
1797         (contextClickCallback):
1798         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
1799         by a WM_RBUTTONUP message.
1800         
1801         * DumpRenderTree/win/UIDelegate.cpp:
1802         (UIDelegate::hasCustomMenuImplementation):
1803         (UIDelegate::trackCustomPopupMenu):
1804         * DumpRenderTree/win/UIDelegate.h:
1805         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
1806         menu from being shown (and causing the DRT to hang).
1807
1808 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
1809
1810         Reviewed by Darin.
1811
1812         Fix DumpRenderTree ObjC bug comparing strings.
1813
1814         * DumpRenderTree/mac/ObjCController.m:
1815         (-[ObjCController identityIsEqual::]): Compare strings with string
1816         equality instead of identiy equality.
1817
1818 2007-11-27  Timothy Hatcher  <timothy@apple.com>
1819
1820         Reviewed by Sam.
1821
1822         Reset the authorAndUserStylesEnabled preference
1823         back to YES for each test. Fixes the broken tests.
1824
1825         * DumpRenderTree/mac/DumpRenderTree.mm:
1826         (resetWebViewToConsistentStateBeforeTesting):
1827
1828 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
1829
1830         Reviewed by Adam.
1831
1832         - Drosera now displays the console window, although it cannot currently
1833         process JavaScript.
1834
1835         * Drosera/win/DebuggerClient.cpp: Shows the console window.
1836         (registerConsoleClass): Implemented.
1837         (consoleWndProc): Implemented.
1838         (DebuggerClient::onSize): Implemented.
1839         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
1840         new window.
1841         * Drosera/win/DebuggerClient.h: Added needed method and members for 
1842         creating and maintaining a new window.
1843         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
1844         lines of code to more appropriate places.
1845         (Drosera::handleCommand):
1846         (Drosera::initUI):
1847         (Drosera::onSize):
1848         (Drosera::attach):
1849
1850 2007-11-27  Timothy Hatcher  <timothy@apple.com>
1851
1852         Reviewed by Dave Hyatt.
1853
1854         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
1855         
1856         Add support for disabling author and user styles for testing.
1857
1858         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1859         * DumpRenderTree/LayoutTestController.cpp:
1860         (setAuthorAndUserStylesEnabledCallback):
1861         (LayoutTestController::staticFunctions):
1862         * DumpRenderTree/LayoutTestController.h:
1863         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1864         (LayoutTestController::setAuthorAndUserStylesEnabled):
1865         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1866         (LayoutTestController::setAuthorAndUserStylesEnabled):
1867
1868 2007-11-26  Dan Bernstein  <mitz@apple.com>
1869
1870         - Tiger build fix.
1871
1872         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1873
1874 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
1875
1876         Reviewed by Maciej.
1877
1878         - Implemented displaying variables for Drosera on Win.
1879
1880         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
1881         that retrieve variables to not hold onto the return value since it's
1882         not returned.  Also changed to use the new signatures of the retrieval
1883         functions.
1884         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1885         (DebuggerDocument::platformValueForScopeVariableNamed):
1886         * Drosera/win/Drosera.cpp: Removed a needless TODO.
1887         (droseraWndProc):
1888
1889 2007-11-26  Sam Weinig  <sam@webkit.org>
1890
1891         Cleanup names of painting and repainting functions.
1892
1893         Reviewed by Adam Roben.
1894
1895         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1896         (drawSelectionRect): was drawSelectionRectIntoContext.
1897         (dumpWebViewAsPixelsAndCompareWithExpected):
1898         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1899         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1900         (paintWebView): was drawWebViewIntoContext.
1901         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
1902
1903 2007-11-26  Sam Weinig  <sam@webkit.org>
1904
1905         Reviewed by Dan Bernstein.
1906
1907         - Leopard build fix
1908
1909         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1910
1911 2007-11-26  Sam Weinig  <sam@webkit.org>
1912
1913         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
1914         Use shared PixelDumpSupport for Mac DRT
1915
1916         Reviewed by Adam Roben.
1917
1918         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1919         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
1920         * DumpRenderTree/cg/ImageDiffCG.cpp:
1921         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1922         (drawSelectionRectIntoContext):
1923         (dumpWebViewAsPixelsAndCompareWithExpected):
1924         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1925         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1926         * DumpRenderTree/mac/DumpRenderTree.mm:
1927         (dump):
1928         * DumpRenderTree/mac/ImageDiff.m: Removed.
1929         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
1930         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
1931         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
1932         (setDefaultColorProfileToRGB):
1933         (getBitmapContextFromWebView):
1934         (drawWebViewIntoContext):
1935         (repaintWithVerticalSweep):
1936         (repaintWithHorizontalSweep):
1937         (getSelectionRect):
1938         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
1939
1940 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
1941
1942         Bug 16052: prepare-ChangeLog doesn't report deleted files
1943         <http://bugs.webkit.org/show_bug.cgi?id=16052>
1944
1945         Reviewed by Sam.
1946
1947         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
1948
1949 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
1950
1951         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
1952         <http://bugs.webkit.org/show_bug.cgi?id=15864>
1953
1954         Reviewed by Adam.
1955
1956         Roll functionality of merge-changelog into resolve-ChangeLogs
1957         script.  The script now checks for ChangeLog.rej and
1958         ChangeLog.orig files first.  If it finds them, it uses the
1959         ChangeLog.rej file as a patch (in old contextual diff format) to
1960         apply with --fuzz=3.
1961
1962         * Scripts/merge-changelog: Removed.
1963         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
1964
1965 2007-11-25  Sam Weinig  <sam@webkit.org>
1966
1967         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
1968
1969         Reviewed by Mark Rowe.
1970
1971         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1972         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1973         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1974         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
1975         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
1976
1977 2007-11-25  Sam Weinig  <sam@webkit.org>
1978
1979         Convert DumpRenderTree to ues .xcconfig files.
1980
1981         Reviewed by Mark Rowe.
1982
1983         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1984         * DumpRenderTree/mac/Configurations: Added.
1985         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
1986         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
1987         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
1988
1989 2007-11-25  Sam Weinig  <sam@webkit.org>
1990
1991         Add ForwardingHeaders to wtf for DumpRenderTree.
1992
1993         Reviewed by Mark Rowe.
1994
1995         * DumpRenderTree/DumpRenderTree.h:
1996         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1997         * DumpRenderTree/ForwardingHeaders: Added.
1998         * DumpRenderTree/ForwardingHeaders/wtf: Added.
1999         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
2000         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
2001         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
2002         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
2003         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
2004         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
2005         * DumpRenderTree/LayoutTestController.cpp:
2006         * DumpRenderTree/WorkQueue.cpp:
2007         * DumpRenderTree/mac/DumpRenderTree.mm:
2008         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2009         * DumpRenderTree/mac/JavaScriptThreading.cpp:
2010         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2011         * DumpRenderTree/mac/ObjCController.m:
2012         * DumpRenderTree/mac/UIDelegate.mm:
2013         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2014
2015 2007-11-25  Adam Roben  <aroben@apple.com>
2016
2017         Fix some test failures caused by r28019
2018
2019         Now that stdout is in binary mode, we need to always use printf
2020         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
2021         the output.
2022
2023         Reviewed by Sam.
2024
2025         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
2026         printf.
2027         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2028         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2029         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2030         (UIDelegate::webViewAddMessageToConsole):
2031
2032 2007-11-25  Adam Roben  <aroben@apple.com>
2033
2034         Set the font smoothing preference in DRT
2035
2036         This makes the pixel results on Windows closer to the Mac results.
2037
2038         Reviewed by Mitz.
2039
2040         * DumpRenderTree/win/DumpRenderTree.cpp:
2041         (initializePreferences):
2042
2043 2007-11-25  Adam Roben  <aroben@apple.com>
2044
2045         Port ImageDiff to CG and C++
2046
2047         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
2048         <rdar://5071708>
2049
2050         Reviewed by Sam.
2051
2052         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
2053         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
2054         (main):
2055         (createImageFromStdin):
2056         (compareImages):
2057         (getDifferenceBitmap):
2058         (computePercentageDifferent):
2059         * DumpRenderTree/win/ImageDiff.vcproj: Added.
2060
2061 2007-11-25  Adam Roben  <aroben@apple.com>
2062
2063         Fix image diff link generation on Windows
2064
2065         Reviewed by Sam.
2066
2067         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
2068         to toURL.
2069
2070 2007-11-25  Adam Roben  <aroben@apple.com>
2071
2072         Implement pixel dumping in Windows DRT
2073
2074         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
2075         <rdar://5071708>
2076
2077         Reviewed by Sam.
2078
2079         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
2080         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
2081         Content-Length header.
2082         (getMD5HashStringForBitmap):
2083         (dumpWebViewAsPixelsAndCompareWithExpected):
2084         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
2085         * DumpRenderTree/win/DumpRenderTree.cpp:
2086         (dump): Do a pixel dump if requested.
2087         (main): Parse pixel test options.
2088         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
2089         the cg/ subdirectory to the include path.
2090         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
2091         available in a header or import library, so we have to go through this
2092         LoadLibrary/GetProcAddress dance to use them.
2093         (cryptDLL):
2094         (init):
2095         (update):
2096         (final):
2097         (MD5_Init):
2098         (MD5_Update):
2099         (MD5_Final):
2100         * DumpRenderTree/win/MD5.h: Added.
2101         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
2102         moved up to the top level to share it with Mac eventually.
2103         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
2104         (getBitmapContextFromWebView): Forces the WebView to paint using a
2105         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
2106
2107 2007-11-25  Adam Roben  <aroben@apple.com>
2108
2109         Clean up Windows DRT's option parsing a little bit
2110
2111         Reviewed by Sam.
2112
2113         * DumpRenderTree/win/DumpRenderTree.cpp:
2114         (main): Put non-option arguments into a Vector.
2115
2116 2007-11-25  Adam Roben  <aroben@apple.com>
2117
2118         Make Windows DRT stop changing LF into CRLF
2119
2120         Reviewed by Sam.
2121
2122         * DumpRenderTree/win/DumpRenderTree.cpp:
2123         (main): Put stdout in binary mode.
2124         * Scripts/run-webkit-tests: Remove the CRLF hack.
2125
2126 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
2127
2128         Removed empty directory.
2129
2130         * Scripts/resources: Removed.
2131
2132 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
2133
2134         Fix bisect-builds to work with recent WebKit nightly builds.
2135
2136         Reviewed by Dan.
2137
2138         * Scripts/bisect-builds: Check for the 
2139         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
2140         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
2141         to WebKit.app/Contents/Resources.
2142
2143 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
2144
2145         Reviewed by Maciej.
2146
2147         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
2148         not closed (affects digg.com)
2149
2150         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
2151         one after finishing with a test to avoid having its delayed onload handler firing when
2152         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
2153         but it helps somewhat.
2154
2155 2007-11-22  Mark Rowe  <mrowe@apple.com>
2156
2157         Reviewed by Alp Toker.
2158
2159         Fix build-webkit to propagate make's exit status if it fails.
2160
2161         * Scripts/webkitdirs.pm:
2162
2163 2007-11-22  Dan Bernstein  <mitz@apple.com>
2164
2165         Reviewed by Mark Rowe.
2166
2167         - fix crash when running pixel tests
2168
2169         * DumpRenderTree/mac/DumpRenderTree.mm:
2170         (dumpRenderTree): Parse the command line options before setting up the
2171         environment so that we know if we need to set up the pixel dump
2172         machinery.
2173
2174 2007-11-21  Eric Seidel  <eric@webkit.org>
2175
2176         Speculative build fix for Tiger.
2177
2178         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
2179
2180 2007-11-21  Eric Seidel  <eric@webkit.org>
2181
2182         Reviewed by Tim Hatcher.
2183
2184         Break out more of DumpRenderTree.mm into individual files
2185
2186         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2187         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
2188         (checkedMalloc):
2189         (checkedRealloc):
2190         (makeLargeMallocFailSilently):
2191         * DumpRenderTree/mac/CheckedMalloc.h: Added.
2192         * DumpRenderTree/mac/DumpRenderTree.mm:
2193         (crashHandler):
2194         (dump):
2195         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2196         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
2197         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
2198         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2199         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2200         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
2201         (javaScriptThreads):
2202         (runJavaScriptThread):
2203         (startJavaScriptThreads):
2204         (stopJavaScriptThreads):
2205         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
2206         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
2207         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
2208         (restoreColorSpace):
2209         (setDefaultColorProfileToRGB):
2210         (initializeColorSpaceAndScreeBufferForPixelTests):
2211         (md5HashStringForBitmap):
2212         (dumpWebViewAsPixelsAndCompareWithExpected):
2213
2214 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
2215
2216         Move install-unix-extras to wx directory as it seems only to be used by that 
2217         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
2218         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
2219         have install-unix-extras install into WebKitLibraries as per
2220         convention.
2221         
2222         Reviewed by Mark Rowe.
2223
2224         * Scripts/install-unix-extras: Removed.
2225         * wx/build-wxwebkit:
2226         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
2227
2228 2007-11-21  Eric Seidel  <eric@webkit.org>
2229
2230         Reviewed by Adam.
2231
2232         More refactoring for greater code readability
2233
2234         * DumpRenderTree/mac/DumpRenderTree.mm:
2235         (initializeGlobalsFromCommandLineOptions):
2236         (initializeColorSpaceAndScreeBufferForPixelTests):
2237         (addTestPluginsToPluginSearchPath):
2238         (useLongRunningServerMode):
2239         (runTestingServerLoop):
2240         (prepareConsistentTestingEnvironment):
2241         (dumpRenderTree):
2242         (main):
2243         (dumpFramesAsText):
2244         (dumpBackForwardListForWebView):
2245         (sizeWebViewForCurrentTest):
2246         (methodNameStringForFailedTest):
2247         (dumpBackForwardListForAllWindows):
2248         (dumpWebViewAsPixelsAndCompareWithExpected):
2249         (invalidateAnyPreviousWaitToDumpWatchdog):
2250         (dump):
2251         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2252         * DumpRenderTree/mac/UIDelegate.mm:
2253         (-[UIDelegate webView:createWebViewWithRequest:]):
2254
2255 2007-11-21  Eric Seidel  <eric@webkit.org>
2256
2257         Reviewed by Tim Hatcher.
2258
2259         Abstract more of DRT into static methods
2260
2261         * DumpRenderTree/mac/DumpRenderTree.mm:
2262         (setDefaultsToConsistentValuesForTesting):
2263         (setupSignalHandlers):
2264         (allocateGlobalControllers):
2265         (releaseAndZero):
2266         (releaseGlobalControllers):
2267         (dumpRenderTree):
2268         (shouldLogFrameLoadDelegates):
2269         (createCFURLFromPathOrURL):
2270         (resetWebViewToConsistentStateBeforeTesting):
2271         (runTest):
2272
2273 2007-11-21  Eric Seidel  <eric@webkit.org>
2274
2275         Reviewed by Tim Hatcher.
2276
2277         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
2278
2279         * DumpRenderTree/DumpRenderTree.h:
2280         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2281         * DumpRenderTree/mac/DumpRenderTree.mm:
2282         (dumpRenderTree):
2283         (dump):
2284         (runTest):
2285         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
2286         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
2287         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
2288         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
2289         (-[DumpRenderTreePasteboard declareType:owner:]):
2290         (+[LocalPasteboard alloc]):
2291         (-[LocalPasteboard init]):
2292         (-[LocalPasteboard dealloc]):
2293         (-[LocalPasteboard name]):
2294         (-[LocalPasteboard releaseGlobally]):
2295         (-[LocalPasteboard declareTypes:owner:]):
2296         (-[LocalPasteboard addTypes:owner:]):
2297         (-[LocalPasteboard changeCount]):
2298         (-[LocalPasteboard types]):
2299         (-[LocalPasteboard availableTypeFromArray:]):
2300         (-[LocalPasteboard setData:forType:]):
2301         (-[LocalPasteboard dataForType:]):
2302         (-[LocalPasteboard setPropertyList:forType:]):
2303         (-[LocalPasteboard setString:forType:]):
2304         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
2305         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
2306         (+[DumpRenderTreeWindow allWindows]):
2307         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
2308         (-[DumpRenderTreeWindow dealloc]):
2309         (-[DumpRenderTreeWindow isKeyWindow]):
2310         (-[DumpRenderTreeWindow keyDown:]):
2311
2312 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
2313
2314         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
2315         it indiscriminately copies any headers inside JavaScriptCore,
2316         which includes Tiger ICU headers. 
2317
2318         * wx/build-wxwebkit:
2319         Don't run WebCore/move-js-headers.sh any longer.
2320
2321 2007-11-20  Adam Treat  <treat@kde.org>
2322
2323         Reviewed by David Kilzer.
2324
2325         * Prepend git branch name to $baseProductDir
2326
2327         * Scripts/VCSUtils.pm:
2328         * Scripts/webkitdirs.pm:
2329
2330 2007-11-20  Mark Rowe  <mrowe@apple.com>
2331
2332         Reviewed by Simon Hausmann.
2333
2334         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
2335         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
2336         Have it trigger a "make distclean" rather than "make clean" to ensure that the
2337         built product and generated Makefile's are removed.
2338
2339 2007-11-19  Alp Toker  <alp@atoker.com>
2340
2341         Reviewed by Mark Rowe.
2342
2343         http://bugs.webkit.org/show_bug.cgi?id=16040
2344         [GTK] GtkLauncher should be written in C
2345
2346         Port GtkLauncher to plain C.
2347
2348         Use a more conventional GTK+ coding style.
2349
2350         Use a toolbar instead of menus.
2351
2352         Various signature fixes and cleanups.
2353
2354         Add a license header. Assume all previous modifications were copyright
2355         assigned to Apple Inc. by default.
2356
2357         * GtkLauncher/GtkLauncher.pro:
2358         * GtkLauncher/main.c: Added.
2359         (activate_url_entry_cb):
2360         (update_title):
2361         (link_hover_cb):
2362         (title_change_cb):
2363         (progress_change_cb):
2364         (destroy_cb):
2365         (go_back_cb):
2366         (go_forward_cb):
2367         (create_browser):
2368         (create_statusbar):
2369         (create_toolbar):
2370         (create_window):
2371         (main):
2372         * GtkLauncher/main.cpp: Removed.
2373
2374 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
2375
2376         Build script fixes to ensure they do the right thing for the 
2377         wx port, and update build-wxwebkit to reflect the way the
2378         build scripts now work.
2379
2380         Reviewed by Adam.
2381
2382         * Scripts/build-testkjs:
2383         * Scripts/build-webkit:
2384         * Scripts/run-javascriptcore-tests:
2385         * Scripts/webkitdirs.pm:
2386         * wx/build-wxwebkit:
2387
2388 2007-11-18  Eric Seidel  <eric@webkit.org>
2389
2390         Reviewed by Anders.
2391
2392         Make run-javascriptcore-tests report failures on exit (to support git bisect)
2393
2394         * Scripts/run-javascriptcore-tests:
2395
2396 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
2397
2398         Reviewed by Adam Roben.
2399
2400         Make run-webkit-tests work with Windows debug build.
2401
2402         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
2403         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
2404         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
2405         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
2406         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
2407
2408 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
2409
2410         Add wxWebKit sample and build script, and integrate it with 
2411         build-webkit. Also make build-webkit --clean work for all
2412         ports.
2413
2414         Reviewed by Darin Adler.
2415
2416         * Scripts/build-webkit:
2417         * Scripts/webkitdirs.pm:
2418         * wx: Added.
2419         * wx/browser: Added.
2420         * wx/browser/browser.bkl: Added.
2421         * wx/browser/browser.cpp: Added.
2422         * wx/build-wxwebkit: Added.
2423
2424 2007-11-17  Adam Roben  <aroben@apple.com>
2425
2426         Make it easy to run Safari in the debugger on Windows
2427
2428         I've added a new script, debug-safari, which launches Safari in the
2429         debugger. On OS X it just calls gdb-safari.
2430
2431         Reviewed by Mark Rowe.
2432
2433         * FindSafari/FindSafari.cpp:
2434         (_tmain): Added a /debugger flag, which in combination with
2435         /printSafariLauncher will print a script that launches Safari in the
2436         debugger.
2437         * Scripts/debug-safari: Added.
2438         * Scripts/run-safari: Changed to call runSafari().
2439         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
2440         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
2441         first argument along to FindSafari.
2442         * Scripts/webkitdirs.pm:
2443         (sub runSafari): Added.
2444
2445 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
2446
2447         Reviewed by Adam Roben.
2448
2449         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
2450
2451 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
2452
2453         Reviewed by David Kilzer.
2454
2455         The git config command was renamed to repo-config at some point. This
2456         change tries git config and then git repo-config if the first fails.
2457
2458         * Scripts/prepare-ChangeLog:
2459         (gitConfig):
2460
2461 2007-11-16  Dan Bernstein  <mitz@apple.com>
2462
2463         Reviewed by Darin Adler and Sam Weinig.
2464
2465         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
2466
2467         * DumpRenderTree/win/EventSender.cpp:
2468         (keyDownCallback): For characters that cannot be entered on the active
2469         keyboard layout, send a WM_CHAR message with the character along with
2470         a WM_KEYDOWN message with a virtual key code of 255.
2471
2472 2007-11-16  Mark Rowe  <mrowe@apple.com>
2473
2474         Reviewed by Tim Hatcher.
2475
2476         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
2477
2478         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2479         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2480
2481 2007-11-15  Adam Roben  <aroben@apple.com>
2482
2483         Make run-safari actually work on Windows
2484
2485         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
2486         chdir call.
2487
2488 2007-11-14  Adam Roben  <aroben@apple.com>
2489
2490         Updates to Safari launching now that 3.0.4 is released
2491
2492         Reviewed by Sam.
2493
2494         * FindSafari/FindSafari.cpp:
2495         (getWebViewCLSID): Use version-independent ProgID.
2496         * Scripts/run-safari: Use run-webkit-nightly.cmd.
2497
2498 2007-11-14  Anders Carlsson  <andersca@apple.com>
2499
2500         Reviewed by Adam.
2501
2502         <rdar://problem/5309081>
2503         In DRT, "plugin.logDestroy = true" not working on Windows.
2504         
2505         * DumpRenderTree/win/TestNetscapePlugin/main.c:
2506         (NPP_Destroy):
2507
2508 2007-11-14  Eric Seidel  <eric@webkit.org>
2509
2510         Reviewed by Sam.
2511
2512         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
2513
2514 2007-11-14  Anders Carlsson  <andersca@apple.com>
2515
2516         Reviewed by Adam.
2517
2518         <rdar://problem/5141186>
2519         window.layoutTestController.setWindowIsKey is not implemented in DRT.
2520         
2521         Implement setWindowIsKey.
2522         
2523         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2524         (LayoutTestController::setWindowIsKey):
2525
2526 2007-11-13  Sam Weinig  <sam@webkit.org>
2527
2528         Reviewed by Adam Roben.
2529
2530         Fix for <rdar://problem/5382579>
2531         http/tests/security/cross-frame-access-put.html reports large 
2532         negative numbers for screenLeft and screenTop (Mac reports "0")
2533
2534         * DumpRenderTree/win/UIDelegate.cpp:
2535         (UIDelegate::UIDelegate): Initialize the RECT.
2536         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
2537         (UIDelegate::webViewFrame): ditto.
2538         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
2539
2540 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
2541
2542         Reviewed by Adam.
2543
2544         - Make Drosera show source, source URLs, and function stack on Windows,
2545         and some minor fixes.
2546
2547         * Drosera/DebuggerDocument.cpp: Force source to always update display.
2548         (DebuggerDocument::updateFileSource):
2549         * Drosera/debugger.js: Force source to always update display.
2550         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
2551         menu controls.
2552         (DebuggerClient::resume):
2553         (DebuggerClient::pause):
2554         (DebuggerClient::stepInto):
2555         (DebuggerClient::stepOver):
2556         (DebuggerClient::stepOut):
2557         (DebuggerClient::showConsole):
2558         (DebuggerClient::closeCurrentFile):
2559         * Drosera/win/DebuggerClient.h: Ditto.
2560         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
2561         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
2562         removed two bugs.  1) caller could be in a bad state when asked to
2563         assign into it. 2) BSTRs were not created correctly.
2564         (DebuggerDocument::getPlatformCurrentFunctionStack):
2565         * Drosera/win/Drosera.cpp: Hook up the menu controls.
2566         (droseraWndProc):
2567         (handleCommand):
2568         (Drosera::resume):
2569         (Drosera::pause):
2570         (Drosera::stepInto):
2571         (Drosera::stepOver):
2572         (Drosera::stepOut):
2573         (Drosera::showConsole):
2574         (Drosera::closeCurrentFile):
2575         * Drosera/win/Drosera.h: Hook up the menu controls.
2576         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
2577         functions, added a null check, and fixed another bug where caller could
2578         be in a bad state when asked to assign into it.
2579         (ServerConnection::didLoadMainResourceForDataSource):
2580         (ServerConnection::getCallerFrame):
2581         * Drosera/win/ServerConnection.h: Safety first.
2582
2583 2007-11-13  Dan Bernstein  <mitz@apple.com>
2584
2585         Reviewed by Darin Adler.
2586
2587         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
2588           DumpRenderTree --pixel-tests renders each test twice
2589
2590         * DumpRenderTree/mac/DumpRenderTree.mm:
2591         (dumpRenderTree): Removed the --paint option because the painting code
2592         is always exercised as a result of
2593         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
2594         calling -displayIfNeeded.
2595         (dump): Changed to always grab the image from the window since the view
2596         is always displayed.
2597         (runTest):
2598         (displayWebView):
2599         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
2600         because it always paints.
2601
2602 2007-11-12  Antti Koivisto  <antti@apple.com>
2603
2604         Reviewed by Adele.
2605         
2606         Add support for http media tests
2607
2608         * Scripts/run-webkit-tests:
2609
2610 2007-11-12  Sam Weinig  <sam@webkit.org>
2611
2612         Reviewed by Adam Roben.
2613
2614         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
2615
2616         * DumpRenderTree/win/DumpRenderTree.cpp:
2617         (runTest):
2618         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2619         (LayoutTestController::setPrivateBrowsingEnabled):
2620
2621 2007-11-12  Adam Roben  <aroben@apple.com>
2622
2623         * Scripts/update-webkit-localizable-strings: Changed to only scan the
2624         mac and win subdirectories.
2625
2626 2007-11-11  Adam Roben  <aroben@apple.com>
2627
2628         Fix <rdar://5133816> keepWebHistory is not implemented
2629
2630         Fixes fast/history/clicked-link-is-visited.html.
2631
2632         Reviewed by Darin.
2633
2634         * DumpRenderTree/win/DumpRenderTree.cpp:
2635         (runTest): Clear the optionalSharedHistory.
2636         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2637         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
2638
2639 2007-11-10  Sam Weinig  <sam@webkit.org>
2640
2641         Reviewed by Tim Hatcher.
2642
2643         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
2644         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
2645         is turned on)
2646
2647         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
2648
2649         Added test: http/tests/security/cross-frame-access-private-browsing.html
2650
2651         * DumpRenderTree/LayoutTestController.cpp:
2652         (setPrivateBrowsingEnabledCallback):
2653         (LayoutTestController::staticFunctions):
2654         * DumpRenderTree/LayoutTestController.h:
2655         * DumpRenderTree/mac/DumpRenderTree.mm:
2656         (runTest): Default to private browsing disabled.
2657         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2658         (LayoutTestController::setPrivateBrowsingEnabled):
2659         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2660         (LayoutTestController::setPrivateBrowsingEnabled):
2661
2662 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
2663
2664         Reviewed by Adam.
2665
2666         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
2667         WebCore's!
2668
2669         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
2670         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
2671         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
2672         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
2673         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
2674         * Drosera/win/Drosera.cpp:
2675         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2676
2677 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
2678
2679         Reviewed by Sam.
2680
2681         - Use the new IWebFrame [local] function signature and get the shared
2682         server correctly.
2683
2684         * Drosera/win/DebuggerClient.cpp:
2685         (DebuggerClient::didFinishLoadForFrame):
2686         * Drosera/win/ServerConnection.cpp:
2687         (ServerConnection::attemptToCreateServerConnection):
2688
2689 2007-11-07  Dan Bernstein  <mitz@apple.com>
2690
2691         Reviewed by Darin Adler.
2692
2693         - add an option to run-webkit-tests to ignore pixel test failures where
2694           all pixels differ by no more than a specified threshold
2695
2696         * DumpRenderTree/mac/ImageDiff.m:
2697         (main):
2698         (compareImages):
2699         (computePercentageDifferent):
2700         * Scripts/run-webkit-tests:
2701
2702 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2703
2704         Reviewed by Lars.
2705
2706         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
2707
2708         * DumpRenderTree/qt/DumpRenderTree.cpp:
2709
2710 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2711
2712         Reviewed by Lars.
2713
2714         Reworked the QWebSettings API.
2715         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
2716
2717         * DumpRenderTree/qt/DumpRenderTree.cpp:
2718
2719 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2720
2721         Reviewed by Lars.
2722
2723         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
2724
2725         * DumpRenderTree/qt/jsobjects.cpp:
2726
2727 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2728
2729         Reviewed by Lars Knoll <lars@trolltech.com>.
2730
2731         Add a QWebPage::frameCreated() signal and fix DRT
2732         
2733         The removal of createFrame in QWebPage broke the re-implementation
2734         in DumpRenderTree. Instead emit a frameCreated() signal and
2735         connect to it in DumpRenderTree.
2736         
2737
2738         * DumpRenderTree/qt/DumpRenderTree.cpp:
2739         (WebCore::WebPage::WebPage):
2740         (WebCore::DumpRenderTree::dump):
2741         (WebCore::DumpRenderTree::connectFrame):
2742         * DumpRenderTree/qt/DumpRenderTree.h:
2743
2744 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2745
2746         Reviewed by Lars Knoll <lars@trolltech.com>.
2747
2748         Moved all the event handlers from QWebFrame into QWebPage.
2749         
2750         This cleans up the public API and allows us to remove the
2751         HackWebFrame hack in DumpRenderTree.
2752         
2753
2754         * DumpRenderTree/qt/jsobjects.cpp:
2755         (EventSender::mouseDown):
2756         (EventSender::mouseUp):
2757         (EventSender::mouseMoveTo):
2758
2759 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2760
2761         Reviewed by Mark.
2762
2763         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
2764         to prevent the default implementation from popping up messageboxes.
2765
2766         * DumpRenderTree/qt/DumpRenderTree.cpp:
2767         (WebCore::WebPage::javaScriptConfirm):
2768         (WebCore::WebPage::javaScriptPrompt):
2769
2770 2007-11-06  Eric Seidel  <eric@webkit.org>
2771
2772         * Scripts/build-testkjs: build fix... too many $$
2773
2774 2007-11-06  Eric Seidel  <eric@webkit.org>
2775
2776         Reviewed by Mark Rowe.
2777
2778         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
2779
2780 2007-11-05  Adam Roben  <aroben@apple.com>
2781
2782         Add support on Windows for WEBKIT_TESTFONTS
2783
2784         This environment variable lets you specify where the fonts to be used
2785         by DumpRenderTree reside. The Qt port is already using this, so I'm
2786         just following their lead.
2787
2788         Reviewed by Darin.
2789
2790         * DumpRenderTree/win/DumpRenderTree.cpp:
2791         (exePath): Refactored code out of initialize().
2792         (fontsPath): Returns either $WEBKIT_TESTFONTS or
2793         DumpRenderTree.resources.
2794         (initialize): Use the new fontsPath function.
2795         (main): Use the new exePath function.
2796         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
2797         variable to DRT, like Qt does.
2798
2799 2007-11-05  Mark Rowe  <mrowe@apple.com>
2800
2801         Rubber-stamped by Alp Toker.
2802
2803         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
2804
2805         * GtkLauncher/main.cpp:
2806         (goToURLBarText):
2807         (main):
2808
2809 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
2810
2811         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
2812         <http://bugs.webkit.org/show_bug.cgi?id=15830>
2813
2814         Reviewed by Timothy.
2815
2816         Restrict the range of nightly builds used by the bisect-builds script
2817         based on the version of Safari and the version of Mac OS X being used.
2818
2819         Mac OS X 10.4: Safari 2.0: r11976 or newer
2820         Mac OS X 10.4: Safari 3.0: r19992 or newer
2821
2822         Mac OS X 10.5: Safari 2.0: r19594 or newer
2823         Mac OS X 10.5: Safari 3.0: r25124 or newer
2824
2825         * Scripts/bisect-builds:
2826         (findMacOSXVersion): Added.
2827         (makeNightlyList): Added argument to provide version of Mac OS X.
2828         Restrict range of nightly builds based on Safari and Mac OS X versions.
2829
2830 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
2831
2832         Reviewed by Maciej.
2833
2834         - This patch involves several changes, all of them were noticed that
2835         they were needed by the work being done in WebKit to get Drosera and
2836         WebKit working together on Windows.
2837         - The changes are:
2838         1) Added a debugger console for output messages.
2839         2) Drosera now listens for the WebKit server (before, the server would
2840         have to be running before Drosera was started.)
2841         3) Fixed a bug where the WebView started out as 0x0 pixels.
2842         4) Fixed a bug when there is no scope.
2843         5) Added the HTML, JS, and CSS to the project file to make them easy to
2844         find.
2845         6) Made the ServerConnection functions virtual.
2846
2847         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
2848         for the WebKit server.
2849         (DebuggerClient::DebuggerClient):
2850         (DebuggerClient::~DebuggerClient):
2851         (DebuggerClient::didFinishLoadForFrame):
2852         (DebuggerClient::serverConnected):
2853         (DebuggerClient::attemptToCreateServerConnection):
2854         * Drosera/win/DebuggerClient.h: Ditto.
2855         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
2856         scope.
2857         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2858         (DebuggerDocument::platformValueForScopeVariableNamed):
2859         * Drosera/win/Drosera.cpp:
2860         (_tWinMain): Added a console in debug for output messages.
2861         (Drosera::Drosera): Listen for server.
2862         (Drosera::initUI): The server now Initializes COM.
2863         (Drosera::serverConnected): Part of the listening for the server.
2864         (Drosera::attemptToCreateServerConnection): Ditto.
2865         * Drosera/win/Drosera.h: New interface for listening for the server.
2866         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
2867         files to the VS project.
2868         * Drosera/win/ServerConnection.cpp: Part of listening for the server
2869         connection.
2870         (ServerConnection::ServerConnection):
2871         (ServerConnection::attemptToCreateServerConnection):
2872         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
2873         methods.
2874         (ServerConnection::serverConnected):
2875
2876 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
2877
2878         Reviewed by Maciej.
2879
2880         http://bugs.webkit.org/show_bug.cgi?id=15832
2881         fast/dom/gc-10.html crashes when run alone
2882
2883         Check for !done before using objects that can be already deallocated.
2884
2885         * DumpRenderTree/mac/EditingDelegate.mm:
2886         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
2887         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
2888         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
2889         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
2890         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
2891         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2892         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
2893         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
2894         (-[EditingDelegate webViewDidBeginEditing:]):
2895         (-[EditingDelegate webViewDidChange:]):
2896         (-[EditingDelegate webViewDidEndEditing:]):
2897         (-[EditingDelegate webViewDidChangeTypingStyle:]):
2898         (-[EditingDelegate webViewDidChangeSelection:]):
2899         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2900         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2901         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2902         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2903         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
2904         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
2905         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
2906         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2907         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
2908         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
2909         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2910         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
2911         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
2912         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
2913         (-[FrameLoadDelegate webView:willCloseFrame:]):
2914         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
2915         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
2916         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2917         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2918         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2919         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
2920         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
2921         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
2922         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
2923
2924 2007-11-04  Mark Rowe  <mrowe@apple.com>
2925
2926         Build fix.  Don't use Carbon.h as the prefix header as it triggers
2927         warnings that would otherwise be suppressed due to it being a system header.
2928
2929         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2930
2931 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
2932
2933         Rubber stamped by Adam.
2934         
2935         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
2936
2937         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2938
2939 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2940
2941         Sort files(...); sections of Xcode project files.
2942
2943         Rubber-stamped by Darin.
2944
2945         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
2946         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2947         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2948         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2949
2950 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2951
2952         Script to sort "files(...);" sections in Xcode project.pbxproj files.
2953
2954         Reviewed by Darin.
2955
2956         * Scripts/sort-Xcode-project-file: Added.
2957
2958 2007-11-02  Darin Adler  <darin@apple.com>
2959
2960         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
2961
2962 2007-11-02  Darin Adler  <darin@apple.com>
2963
2964         Reviewed by Maciej.
2965
2966         * Scripts/run-sunspider: Pass the "--base" option through.
2967
2968         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
2969         the real script do that. Default configuration to Release to match run-sunspider
2970         so we don't end up building Debug just to compare results.
2971
2972 2007-11-01  Adam Roben  <aroben@apple.com>
2973
2974         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
2975
2976         Reviewed by Sam.
2977
2978         * Scripts/commit-log-editor: Show all the directories beneath the
2979         source root, instead of just the last one.
2980
2981 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
2982
2983         Reviewed by Adam Roben.
2984
2985         Print out an error message when the Windows build fails
2986         and provide guidance on how to find out what went wrong.
2987
2988         * Scripts/build-webkit:
2989         * Scripts/webkitdirs.pm:
2990
2991 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
2992
2993         Rubber-stamped by Adam Roben.
2994
2995         Rolled out r27326 - debug CRT seems to cause no problems after all.
2996
2997         * DumpRenderTree/win/DumpRenderTree.vcproj:
2998
2999 2007-10-31  Adam Roben  <aroben@apple.com>
3000
3001         Switch the Debug configuration to using the non-debug CRT
3002
3003         This matches WebKit.
3004
3005         Reviewed by Steve.
3006
3007         * DumpRenderTree/win/DumpRenderTree.vcproj:
3008
3009 2007-10-31  Antti Koivisto  <antti@apple.com>
3010
3011         Reviewed by bdash.
3012         
3013         Disable media tests when doing leak checking on Tiger.
3014         They crash in QuickTime (rdar://problem/5537157).
3015
3016         * Scripts/run-webkit-tests:
3017
3018 2007-10-29  Antti Koivisto  <antti@apple.com>
3019
3020         Reviewed by Maciej.
3021         
3022         Build media support by default on OSX only.
3023
3024         * Scripts/build-webkit:
3025
3026 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3027
3028         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
3029         get caught by the pre-commit hooks.
3030
3031 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3032
3033         Reviewed by Adam.
3034
3035         - This is a collection of relatively unrelated changes and cleanups
3036         to Drosera to prepare it for interacting with WebKit.  A lot of these
3037         changes are just correcting mistakes, for example removing included
3038         headers that are no longer needed.
3039
3040         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
3041         this will be needed by the DebuggerClient.
3042         (DebuggerDocument::server):
3043         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
3044         * Drosera/win/DebuggerClient.cpp: 
3045         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
3046         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
3047         (DebuggerClient::createWebViewWithRequest): Added comment about its
3048         purpose. 
3049         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
3050         declarations.
3051         (DebuggerClient::webViewLoaded): Moved.
3052         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
3053         file, since this was the only place it was used.
3054         (cfStringToBSTR):
3055         * Drosera/win/Drosera.h: Cleaned up the includes.
3056         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
3057         * Drosera/win/HelperFunctions.h: Removed.
3058
3059 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3060
3061         Reviewed by Adam.
3062
3063         - Small cleanup in the ServerConnection class.
3064
3065         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
3066         and added an include.
3067         (ServerConnection::currentFrame):
3068         (ServerConnection::getCallerFrame):
3069         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
3070         made a pointer into a COMPtr, and cleaned up the includes.
3071
3072 2007-10-29  Timothy Hatcher  <timothy@apple.com>
3073
3074         Reviewed by John Sullivan.
3075         
3076         - Place the Localizable.strings file in mac or win directories
3077           if that location exists.
3078         - Also look for UI_STRING in .c files.
3079
3080         * Scripts/extract-localizable-strings:
3081
3082 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3083
3084         Reviewed by Adam.
3085
3086         - Set the eol-style to native and made all the line endings the same
3087         so that I avoid messy diffs that show eol changes.
3088
3089         * Drosera/win/ServerConnection.cpp:
3090         (ServerConnection::didParseSource):
3091         (ServerConnection::didEnterCallFrame):
3092         (ServerConnection::willExecuteStatement):
3093         (ServerConnection::willLeaveCallFrame):
3094         (ServerConnection::exceptionWasRaised):
3095
3096 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3097
3098         Reviewed by Adam.
3099
3100         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
3101         functionality that could not have existed previously without the new
3102         interfaces.
3103         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
3104         from a BSTR to a JSValueRef.
3105         (DebuggerDocument::platformEvaluateScript): Implemented.
3106         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
3107         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3108         Implemented.
3109         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
3110         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
3111         * Drosera/win/ServerConnection.cpp: Added a helper function.
3112         (ServerConnection::getCallerFrame):
3113         * Drosera/win/ServerConnection.h: Added a helper function.
3114
3115 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
3116
3117         updated reviewers for my previous changelog.
3118
3119 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
3120         Reviewed by Maciej and Adam and Geoff.
3121
3122         - Minor mac-side improvements including moving a function to a more
3123         appropriate location, fixing a warning, and correctly checking
3124         exceptions.
3125
3126         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
3127         (DebuggerDocument::willExecuteStatement):
3128         (DebuggerDocument::didEnterCallFrame):
3129         (DebuggerDocument::willLeaveCallFrame):
3130         (DebuggerDocument::windowScriptObjectAvailable):
3131         (DebuggerDocument::callFunctionOnObject):
3132         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
3133         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
3134         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
3135         because it doesn't require the ServerConnection at all.
3136         (NSStringCreateWithJSStringRef): Made an argument const.
3137         (JSValueRefCreateWithNSString): Made an argument const.
3138         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
3139         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3140         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
3141         * Drosera/mac/ServerConnection.mm: Ditto.
3142         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
3143
3144 2007-10-29  Sam Weinig  <sam@webkit.org>
3145
3146         Reviewed by Adam Roben.
3147
3148         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
3149
3150         * DumpRenderTree/LayoutTestController.cpp:
3151         (LayoutTestController::LayoutTestController):
3152         (getGlobalFlagCallback):
3153         (setGlobalFlagCallback):
3154         (LayoutTestController::getJSClass):
3155         (LayoutTestController::staticValues):
3156         * DumpRenderTree/LayoutTestController.h:
3157         (LayoutTestController::globalFlag):
3158         (LayoutTestController::setGlobalFlag):
3159
3160 2007-10-29  Darin Adler  <darin@apple.com>
3161
3162         Reviewed by Maciej.
3163
3164         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
3165         resolution instead of its default.
3166
3167 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
3168
3169         Fixed showStatus() to print status for successfully resolved conflicts when using git.
3170
3171         Reviewed by Mark Rowe.
3172
3173         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
3174         was successfully resolved, but this would not show any status because the change had
3175         already been cached in the index using "git add".  The solution is to add an optional
3176         second argument to showStatus() which adds the "--cached" switch to the command.
3177
3178         * Scripts/resolve-ChangeLogs:
3179         (showStatus):
3180
3181 2007-10-28  Eric Seidel  <eric@webkit.org>
3182
3183         Reviewed by Maciej and Geoff, in unison.
3184
3185         * Scripts/run-webkit-tests: remove broken --svg option
3186
3187 2007-10-28  Darin Adler  <darin@apple.com>
3188
3189         Reviewed by Adam.
3190
3191         * Scripts/run-sunspider: Default to "Release" configuration rather than
3192         defaulting to the last configuration used as other scripts do. This can
3193         still be overriden on the command line with "--debug" if there's some
3194         reason to do so. Also fix a typo.
3195
3196         * Scripts/sunspider-compare-results: Fix a typo.
3197
3198 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
3199
3200         Reviewed by Adam.
3201
3202         - Implemented the WebScriptDebugListener functions now that the
3203         WebScriptDebugServer exists
3204
3205         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
3206         functions.
3207         (ServerConnection::currentFrame):
3208         (ServerConnection::didLoadMainResourceForDataSource):
3209         (ServerConnection::didParseSource):
3210         (ServerConnection::failedToParseSource):
3211         (ServerConnection::didEnterCallFrame):
3212         (ServerConnection::willExecuteStatement):
3213         (ServerConnection::willLeaveCallFrame):
3214         (ServerConnection::exceptionWasRaised):
3215         * Drosera/win/ServerConnection.h: Removed unused arguments from the
3216         members arguments list.
3217
3218 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
3219
3220         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
3221         <http://bugs.webkit.org/show_bug.cgi?id=15600>
3222
3223         Reviewed by Darin.
3224
3225         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
3226         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
3227         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
3228         file.  Note that it may also be used as a stand-alone script.
3229
3230         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
3231         * Scripts/resolve-ChangeLogs: Added.
3232         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
3233
3234 2007-10-26  Mark Rowe  <mrowe@apple.com>
3235
3236         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
3237         to the Qt port on the assumption that it was an implementation of the cross-platform
3238         LayoutTestController class.  It is not, so it did not need to be changed.
3239
3240         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
3241
3242 2007-10-25  Mark Rowe  <mrowe@apple.com>
3243
3244         Reviewed by Maciej.
3245
3246         Fix builds with code coverage enabled.
3247
3248         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
3249
3250 2007-10-25  Darin Adler  <darin@apple.com>
3251
3252         Reviewed by Mark Rowe.
3253
3254         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
3255         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
3256
3257 2007-10-25  Stephanie  <slewis@apple.com>
3258
3259         build Fix
3260
3261         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3262
3263 2007-10-25  Stephanie  <slewis@apple.com>
3264
3265         Reviewed by Mark Rowe, Adam Roben.
3266
3267         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
3268
3269         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
3270
3271 2007-10-25  Alice Liu  <alice.liu@apple.com>
3272
3273         Reviewed by Adam.
3274
3275         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
3276
3277         Moving destructor into platform-specific files
3278         * DumpRenderTree/LayoutTestController.cpp:
3279         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3280         (LayoutTestController::~LayoutTestController):
3281         * DumpRenderTree/qt/jsobjects.cpp:
3282         (LayoutTestController::~LayoutTestController):
3283
3284         LayoutTestController wasn't being destroyed
3285         * DumpRenderTree/win/DumpRenderTree.cpp:
3286         (runTest):
3287
3288         Added declspec
3289         * DumpRenderTree/win/EditingDelegate.h:
3290
3291         Reset certain values on the webview (or related delegate) that might 
3292         have changed while running a test
3293         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3294         (LayoutTestController::~LayoutTestController):
3295
3296 2007-10-25  Adam Roben  <aroben@apple.com>
3297
3298         Make sunspider-compare-results work with relative paths
3299
3300         Reviewed by Sam.
3301
3302         * Scripts/sunspider-compare-results: Convert arguments to absolute
3303         paths before we chdir.
3304
3305 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
3306
3307         Reviewed by Sam.
3308
3309         - Implemented server calls now the WebScriptDebugServer exists.
3310         - Also removed no longer needed call to initialize CG.
3311
3312         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
3313         automatically now.
3314         (_tWinMain):
3315         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
3316         (ServerConnection::ServerConnection):
3317         (ServerConnection::~ServerConnection):
3318         (ServerConnection::pause):
3319         (ServerConnection::resume):
3320         (ServerConnection::stepInto):
3321         (ServerConnection::applicationTerminating):
3322         (ServerConnection::serverConnectionDidDie):
3323         * Drosera/win/ServerConnection.h: Now uses the COM class.
3324
3325 2007-10-24  George Staikos  <staikos@kde.org>
3326
3327         Unbreak Qt build.
3328
3329         * Scripts/build-webkit:
3330
3331 2007-10-24  Adam Roben  <aroben@apple.com>
3332
3333         Remove now-unnecessary call to InitializeCoreGraphics
3334
3335         WebKit takes care of this now.
3336
3337         Reviewed by Ada.
3338
3339         * DumpRenderTree/win/DumpRenderTree.cpp:
3340         (initialize):
3341
3342 2007-10-24  Adam Roben  <aroben@apple.com>
3343
3344         Use WebTextRenderer in DRT
3345
3346         Reviewed by Ada.
3347
3348         * DumpRenderTree/win/DumpRenderTree.cpp:
3349         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
3350
3351 2007-10-24  Sven Herzberg  <sven@imendio.com>
3352
3353         Reviewed by Mark Rowe.
3354
3355         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
3356         Bug 15614: [GTK] qmake based backends don't build on OS X
3357
3358         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
3359         GTK backend on a Mac
3360         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
3361         isDarwin() to make it reusable in other places (like the workaround-
3362         for-prebuilt-qmake in build-webkit)
3363
3364 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
3365
3366         Refurbish update-webkit script.
3367
3368         Reviewed by Adam.
3369
3370         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
3371         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
3372         multi-argument version of system() for flexibility and security.  Check for existence
3373         of Internal directory using -d test instead of -x.
3374
3375 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
3376
3377         Minor clean-up of prepare-ChangeLog script.
3378
3379         Reviewed by Adam.
3380
3381         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
3382         of a string.  Use multi-argument versions of open() and system() for flexibility and
3383         security.
3384
3385 2007-10-24  Alice Liu  <alice.liu@apple.com>
3386
3387         Reviewed by Oliver.
3388
3389         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
3390
3391         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
3392         replay the saved events when we're still processing the mousedown that starts the drag
3393         * DumpRenderTree/win/EventSender.cpp:
3394         (doMouseMove):
3395         * DumpRenderTree/win/UIDelegate.cpp:
3396         (UIDelegate::doDragDrop):
3397
3398 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
3399
3400         Reviewed by Sam, Steve and Darin.
3401
3402         - Stubbed out the WebScriptDebugListener functionality in the Server
3403         Connection class to prepare it for receiving those callbacks.
3404         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
3405         and the ServerConnection to not need to be initialized with a server
3406         name, since that is not the way we connect to the WebKit server. 
3407
3408         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
3409         no exception.  Now it only loggs when there is an exception
3410         (DebuggerDocument::willExecuteStatement):
3411         (DebuggerDocument::didEnterCallFrame):
3412         (DebuggerDocument::willLeaveCallFrame):
3413         (DebuggerDocument::windowScriptObjectAvailable):
3414         (DebuggerDocument::callFunctionOnObject):
3415         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
3416         to be instantiated with a server's name.
3417         (DebuggerClient::DebuggerClient):
3418         (DebuggerClient::didFinishLoadForFrame):
3419         * Drosera/win/DebuggerClient.h: Removed unsued variable.
3420         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
3421         a server name.
3422         (Drosera::init):
3423         (Drosera::initServer):
3424         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
3425         instantiated with a server's name.
3426         * Drosera/win/ServerConnection.cpp: 
3427         (ServerConnection::ServerConnection): No longer needs a server name
3428         (ServerConnection::~ServerConnection): Only release the global context
3429         if there is one.
3430         (ServerConnection::serverConnectionDidDie): Stub for
3431         IWebScriptDebugListener
3432         (ServerConnection::QueryInterface): ditto
3433         (ServerConnection::AddRef): ditto
3434         (ServerConnection::Release): ditto
3435         (ServerConnection::didLoadMainResourceForDataSource): ditto
3436         (ServerConnection::didParseSource): ditto
3437         (ServerConnection::failedToParseSource): ditto
3438         (ServerConnection::didEnterCallFrame): ditto
3439         (ServerConnection::willExecuteStatement): ditto
3440         (ServerConnection::willLeaveCallFrame): ditto
3441         (ServerConnection::exceptionWasRaised): ditto
3442         * Drosera/win/ServerConnection.h: Stubbed out the
3443         IWebScriptDebugListener functions, and this class no longer needs to be
3444         instantiated with a server name.
3445
3446 2007-10-24  Lars Knoll  <lars@trolltech.com>
3447
3448         Reviewed by Simon.
3449
3450         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
3451
3452         * DumpRenderTree/qt/jsobjects.h:
3453
3454 2007-10-24  Lars Knoll  <lars@trolltech.com>
3455
3456         Reviewed by Simon.
3457
3458         add another command.
3459
3460         * DumpRenderTree/qt/jsobjects.cpp:
3461         (TextInputController::doCommand):
3462
3463 2007-10-24  Lars Knoll  <lars@trolltech.com>
3464
3465         Reviewed by Simon.
3466
3467         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
3468
3469         * DumpRenderTree/qt/jsobjects.cpp:
3470         (EventSender::keyDown):
3471         * DumpRenderTree/qt/jsobjects.h:
3472
3473 2007-10-24  Lars Knoll  <lars@trolltech.com>
3474
3475         Reviewed by Simon.
3476
3477         implement eventSender.keyDown().
3478
3479         * DumpRenderTree/qt/jsobjects.cpp:
3480         (EventSender::keyDown):
3481
3482 2007-10-24  Lars Knoll  <lars@trolltech.com>
3483
3484         Reviewed by Simon.
3485
3486         some smaller fixes to the editing support in DRT. Makes another few tests pass.
3487
3488         * DumpRenderTree/qt/DumpRenderTree.cpp:
3489         (WebCore::DumpRenderTree::DumpRenderTree):
3490         (WebCore::DumpRenderTree::initJSObjects):
3491         * DumpRenderTree/qt/jsobjects.cpp:
3492         (TextInputController::doCommand):
3493
3494 2007-10-24  Lars Knoll  <lars@trolltech.com>
3495
3496         Reviewed by Simon.
3497
3498         first bit of implementation for the textinputcontroller.
3499
3500         * DumpRenderTree/qt/DumpRenderTree.cpp:
3501         (WebCore::DumpRenderTree::DumpRenderTree):
3502         * DumpRenderTree/qt/DumpRenderTree.h:
3503         * DumpRenderTree/qt/jsobjects.cpp:
3504         (TextInputController::TextInputController):
3505         (TextInputController::doCommand):
3506         * DumpRenderTree/qt/jsobjects.h:
3507
3508 2007-10-24  Lars Knoll  <lars@trolltech.com>
3509
3510         Reviewed by Simon.
3511
3512         make the man webpage believe it has focus, so the editing tests work correctly.
3513
3514         * DumpRenderTree/qt/DumpRenderTree.cpp:
3515         (WebCore::DumpRenderTree::DumpRenderTree):
3516
3517 2007-10-24  Lars Knoll  <lars@trolltech.com>
3518
3519         Reviewed by Simon.
3520
3521         implement layoutTestController.dumpEditingCallbacks() correctly.
3522
3523         * DumpRenderTree/qt/DumpRenderTree.cpp:
3524         (WebCore::DumpRenderTree::DumpRenderTree):
3525         * DumpRenderTree/qt/jsobjects.cpp:
3526         (LayoutTestController::reset):
3527         (LayoutTestController::dumpEditingCallbacks):
3528
3529 2007-10-24  Lars Knoll  <lars@trolltech.com>
3530
3531         Reviewed by Simon.
3532
3533         Implement support for testing editing.
3534
3535         * DumpRenderTree/qt/DumpRenderTree.cpp:
3536         (WebCore::DumpRenderTree::DumpRenderTree):
3537
3538 2007-10-23  Sam Weinig  <sam@webkit.org>
3539
3540         Check for null BSTR that can be passed to the UIDelegate methods
3541         from javascript null and undefined.  Fixes a failing test case on
3542         Windows (fast/dom/Window/alert-undefined.html)
3543
3544         Reviewed by Eric Seidel.
3545
3546         * DumpRenderTree/win/UIDelegate.cpp:
3547         (UIDelegate::runJavaScriptAlertPanelWithMessage):
3548         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
3549         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
3550         (UIDelegate::webViewAddMessageToConsole):
3551
3552 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
3553
3554         Reviewed by Darin.
3555         
3556         Don't print a massive pile of setenvs from tools that automatically build testkjs.
3557
3558         * Scripts/build-testkjs:
3559
3560 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
3561
3562         Reviewed by Darin.
3563
3564         - add wrapper that finds the right copy of testkjs
3565         
3566         * Scripts/sunspider-compare-results: Added.
3567
3568 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
3569
3570         Reviewed by Sam.
3571
3572         - After talking with Steve I now see that the WebKit server must be
3573         running for DCOM to create the distributed objects, which makes sense
3574         and currently WebKit only allows one instance to be running at a time
3575         which avoids accidentally connecting to the wrong server
3576         - In light of this I have removed the code for the attach box and
3577         NotificationServer and known server names, since they are all extranious
3578         now.
3579
3580         * Drosera/win/Drosera.cpp: Removed notification classes and known server
3581         names.
3582         (_tWinMain): Uses init instead of initUI.
3583         (droseraWndProc): No longer creats an attach dialog box.
3584         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
3585         it's not manditory to call init before doing COM stuff.
3586         (Drosera::init): calls initUI and will call attach when the
3587         functionality exists. 
3588         (Drosera::initUI): Has changed very little.
3589         (Drosera::attach): Changed the signature to reflect that we no longer
3590         need the dictionary of known server names.
3591         * Drosera/win/Drosera.h: Removed notification classes and known server
3592         names.  Also renamed and moved some functions.
3593         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
3594         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
3595         headers to the resources folder. 
3596         * Drosera/win/resource.h: Removed the Attach box.
3597
3598 2007-10-22  Adam Roben  <aroben@apple.com>
3599
3600         Windows build fix
3601
3602         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
3603
3604 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
3605
3606         - Removed a leak that was fixed.
3607
3608         * Scripts/run-webkit-tests:
3609
3610 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3611
3612         Reviewed by Darin.
3613
3614         - Changed the Client so that the DebuggerDocument now own the
3615         ServerConnection.  This simplifies ownership and cleanup. 
3616
3617         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
3618         ServerConnection.
3619         (DebuggerClient::initWithServerName):
3620         (DebuggerClient::didFinishLoadForFrame):
3621         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
3622         ServerConnection.
3623         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
3624         until after we have a server which we are attached to.
3625         (Drosera::initUI):
3626         (Drosera::attach):
3627         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
3628         out previously.
3629
3630 2007-10-22  Simon Hausmann  <hausmann@kde.org>
3631
3632         Reviewed by Nikolas.
3633
3634         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
3635
3636         * Scripts/run-javascriptcore-tests:
3637
3638 2007-10-22  Simon Hausmann  <hausmann@kde.org>
3639
3640         Reviewed by Nikolas.
3641
3642         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
3643
3644         * Scripts/build-drosera:
3645         * Scripts/build-dumprendertree:
3646         * Scripts/build-testkjs:
3647         * Scripts/build-webkit:
3648         * Scripts/run-javascriptcore-tests:
3649         * Scripts/run-sunspider:
3650         * Scripts/run-webkit-tests:
3651         * Scripts/webkitdirs.pm:
3652
3653 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
3654
3655         Reviewed by Mark Rowe.
3656         
3657         Fix for local database support after r26879
3658         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
3659
3660         * Scripts/build-webkit:
3661
3662 2007-10-22  Holger Freyther  <zecke@selfish.org>
3663
3664         Reviewed by Simon Hausmann <hausmann@kde.org>.
3665
3666         - Do not build testkjs as an application bundle. This is
3667         needed for run-javascriptcore-tests on OSX.
3668         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
3669         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
3670         as we do not have -rpath on OSX.
3671
3672         * DumpRenderTree/qt/DumpRenderTree.pro:
3673         * Scripts/run-webkit-tests:
3674
3675 2007-10-22  Simon Hausmann  <hausmann@kde.org>
3676
3677         Reviewed by aroben.
3678
3679         Fix support for Signed-off-by detection in prepare-ChangeLog
3680         --git-commit. The Signed-off-by tag does not appear in the header
3681         but usually at the end.
3682
3683         * Scripts/prepare-ChangeLog:
3684
3685 2007-10-21  Mark Rowe  <mrowe@apple.com>
3686
3687         Reviewed by Eric.
3688
3689         Fix run-javascriptcore-tests for Gtk.
3690
3691         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
3692
3693 2007-10-20  Eric Seidel  <eric@webkit.org>
3694
3695         Reviewed by aroben.
3696
3697         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
3698
3699 2007-10-20  Eric Seidel  <eric@webkit.org>
3700
3701         Reviewed by darin.
3702         
3703         Add improved argument handling to run-sunspider, including
3704         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
3705         Also re-factor code into subroutines
3706
3707         * Scripts/build-dumprendertree: removed bogus comments
3708         * Scripts/build-testkjs: Added.
3709         * Scripts/run-javascriptcore-tests: use build-testkjs
3710         * Scripts/run-sunspider: improved argument handling, abstraction
3711         * Scripts/run-webkit-tests: improved abstraction
3712
3713 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
3714
3715         Not reviewed, Windows build fix.
3716
3717         * DumpRenderTree/win/EventSender.cpp:
3718         (keyDownCallback):
3719
3720 2007-10-20  Darin Adler  <darin@apple.com>
3721
3722         Reviewed by Tim Hatcher.
3723
3724         - http://bugs.webkit.org/show_bug.cgi?id=15544
3725           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
3726           not rely on Apple-specific key codes
3727
3728         * DumpRenderTree/mac/EventSendingController.mm:
3729         (-[EventSendingController keyDown:withModifiers:]):
3730         Added named key "rightArrow". Later we could have a whole table of these.
3731         Also tweaked modifiers code a little.
3732
3733         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
3734
3735 2007-10-19  Darin Adler  <darin@apple.com>
3736
3737         Reviewed by Eric.
3738
3739         - http://bugs.webkit.org/show_bug.cgi?id=15566
3740           possible fix for leak seen in DumpRenderTree
3741
3742         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
3743         Delete the item if it's not put on the queue, since the caller has
3744         no way of knowing that. Would be better to have the parameter type
3745         be auto_ptr to express the fact that we take ownership.
3746
3747         - unrelated change
3748
3749         * Drosera/mac/main.m: Add missing include.
3750
3751 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3752
3753         Reviewed by Adam.
3754
3755         - This change should be identical but for some reason was not working
3756         on my machine.
3757
3758         * Scripts/prepare-ChangeLog:
3759
3760 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3761
3762         Reviewed by Oliver and Tim.
3763
3764         - Made use of RetainPtr to avoid retain and release issues and moved the
3765         log function to DebuggerDocumentPlatform, which seems to be a more
3766         logical place for it to live.
3767         - Also moved knownServers from the ServerConnection to
3768         DebuggerApplication to match the Windows code and because it makes sense
3769         that a connection knows its own server but not all of them.
3770
3771         * Drosera/mac/DebuggerClient.h: Moved the log function to
3772           DebuggerDocumentPlatform.
3773         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
3774           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
3775           call for the server name up from the ServerConnection class.
3776         (-[DebuggerClient dealloc]):
3777         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
3778           for the server name up from the ServerConnection.
3779         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
3780         (DebuggerDocument::platformPause):
3781         (DebuggerDocument::platformResume):
3782         (DebuggerDocument::platformStepInto):
3783         (DebuggerDocument::platformEvaluateScript):
3784         (DebuggerDocument::getPlatformCurrentFunctionStack):
3785         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3786         (DebuggerDocument::platformValueForScopeVariableNamed):
3787         (DebuggerDocument::platformLog): Log directly from here. No need to call
3788           DebuggerClient.
3789         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
3790           way I see it, a ServerConnection should only know about its connection
3791           and the group of all possible servers should be kept by the
3792           application.
3793         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
3794           currentServerName, it makes sense that the connection should know that
3795           name.
3796         (-[ServerConnection currentServerName]):
3797
3798 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3799
3800         Reviewed by Adam.
3801
3802         - Integrated changes from mac drosera.  Recently I've encapsulated
3803         out the server connection object from the rest of Drosera because
3804         it is very platform dependent right now and RPC is not implemented on
3805         windows.  This functionality, of communicating with the WebKit server
3806         is the next area I will be focusing on in Windows.
3807
3808         - Other changes and cleanup were made to organize the code and add notes
3809         on which parts still need work.  Also some mac code is added and
3810         commented out, to act as pseudocode for the logic of those parts.
3811
3812         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
3813           pointer.
3814         * Drosera/config.h: Added whitespace.
3815         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
3816           these files got moved into Drosera.h/cpp
3817         * Drosera/win/DebuggerApplication.h: Removed.
3818         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
3819           happened here to better match the logic flow of the same code on the 
3820           mac side and to use the new ServerConnection class.
3821         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
3822         (DebuggerClient::initWithServerName): Initializer that will set up the
3823           class to use a ServerConnection object.  This was necessary so I could
3824           create a DebuggerClient without having to initilaize it at
3825           construction.
3826         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
3827           will be the UIDelegate and FrameLoadDelegate.
3828         (DebuggerClient::AddRef): For IUnknown.
3829         (DebuggerClient::Release): For IUnknown.
3830         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
3831           this still needs to set the global context of the server, but
3832           IWebFrame does not have an accessor for the global context yet. 
3833         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
3834           this is a pass through for the same function in the document.
3835         (DebuggerClient::didReceiveTitle): Unimplemented part of
3836           FrameLoadDelegate this would change the title of the window.
3837         (DebuggerClient::createWebViewWithRequest): Part of the
3838           FrameLoadDelegate.  This is about new windows via Window.open() and
3839           how their delegates are set.
3840         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
3841           UIDelegate.  Just a debug function for printing messages.
3842         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
3843           because the Client should be the UIDelegate and FrameLoadDelegate
3844           to match the delegates on mac.
3845         (DebuggerClient::webViewLoaded): Added accessor method.
3846         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
3847           forgotten to add this file before.  This is where the platform
3848           dependent versions of the Documents functions live. Most of these are
3849           unimplemented because some piece of functionality does not exist on
3850           Windows yet.
3851         (DebuggerDocument::platformPause):
3852         (DebuggerDocument::platformResume):
3853         (DebuggerDocument::platformStepInto):
3854         (DebuggerDocument::platformEvaluateScript):
3855         (DebuggerDocument::getPlatformCurrentFunctionStack):
3856         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3857         (DebuggerDocument::platformValueForScopeVariableNamed):
3858         (DebuggerDocument::platformLog):
3859         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
3860           responsibilities becaue they belong in the Client. Also I laid the
3861           groundwork for attaching Drosera to a WebKit process
3862         (attachWndProc): Now if a server is selected the Client becomes it's
3863           delegate.
3864         (Drosera::Drosera): Added the construction of the Client and dictionary
3865           of server names. 
3866         (Drosera::initUI): This is no longer the delegates, the Client is.
3867         (Drosera::webViewLoaded): Now asks the Client instead of holding local
3868           state. 
3869         (Drosera::applicationDidFinishLaunching): Placeholder for needed
3870           notification registration when it's possible to implement.
3871         (Drosera::serverLoaded): Ditto
3872         (Drosera::serverUnloaded): Ditto
3873         (Drosera::attach): Attach Drosera to the WebKit server.
3874         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
3875         (Drosera::getInst): 
3876         (Drosera::setInst):
3877         (Drosera::knownServers):
3878         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
3879           and added the ServerConnection.
3880         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
3881         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
3882           Most of the functions are completely unimlemented because they cannot
3883           connect with the WebKit server, because one does not exist on Windows
3884           yet.
3885         (ServerConnection::initWithServerName): 
3886         (ServerConnection::~ServerConnection):
3887         (ServerConnection::setGlobalContext):
3888         (ServerConnection::pause):
3889         (ServerConnection::resume):
3890         (ServerConnection::stepInto):
3891         (ServerConnection::switchToServerNamed):
3892         (ServerConnection::applicationTerminating):
3893         (ServerConnection::serverConnectionDidDie):
3894         (ServerConnection::currentFrame):
3895         * Drosera/win/ServerConnection.h: Added. Ditto.
3896         (ServerConnection::ServerConnection):
3897
3898 2007-10-19  Alice Liu  <alice.liu@apple.com>
3899
3900         Reviewed by Darin.
3901
3902         Fix for these broken layout tests on Windows:
3903         
3904         fast/forms/focus-selection-input.html
3905         fast/forms/focus-selection-textarea.html
3906         fast/forms/select-accesskey.html
3907         
3908         * DumpRenderTree/win/EventSender.cpp:
3909         (keyDownCallback):
3910         correct the VK code for alt key.
3911         
3912 2007-10-19  Eric Seidel  <eric@webkit.org>
3913
3914         Reviewed by Mark Rowe.
3915         
3916         Make the GtkLauncher code slightly more readable.
3917
3918         * GtkLauncher/main.cpp:
3919         (setupMainMenu): Added.
3920         (setupMainWindowUI): Added.
3921         (main):
3922
3923 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
3924
3925         Rubber stamped by Adam.
3926         
3927         - don't delay-load WebKit in DumpRenderTree.
3928
3929         * DumpRenderTree/win/DumpRenderTree.vcproj:
3930
3931 2007-10-18  Dan Bernstein  <mitz@apple.com>
3932
3933         Reviewed by Adam Roben.
3934
3935         - fix <rdar://problem/5313523>
3936         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
3937
3938         * DumpRenderTree/mac/DumpRenderTree.mm:
3939         (dump): Changed to use _responseMIMEType.
3940
3941 2007-10-17  Adam Roben  <aroben@apple.com>
3942
3943         Make it possible to have Windows-specific tests and results
3944
3945         When searching for tests to run and the Skipped file, we will only
3946         look in platform/win and the cross-platform directory. When looking
3947         for expected results, we will look in platform/win, then
3948         platform/mac-leopard, then platform/mac, then finally the
3949         cross-platform directory.
3950
3951         Reviewed by Sam.
3952
3953         * Scripts/run-webkit-tests:
3954         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
3955         searching in the cross-platform directory.
3956         (sub buildPlatformHierarchy): Removed some unneeded calls to
3957         dirname/basename.
3958
3959 2007-10-17  Adam Roben  <aroben@apple.com>
3960
3961         Add back the call to register WebKit that we had before WebKitInitializer existed
3962
3963         This is needed to ensure that the right WebKit is used when
3964         instantiating COM objects.
3965
3966         Reviewed by Oliver.
3967
3968         * DumpRenderTree/win/debug_internal.vsprops: Define
3969         DEBUG_WEBKIT_HAS_SUFFIX.
3970         * DumpRenderTree/win/DumpRenderTree.cpp:
3971         (initialize):
3972
3973 2007-10-17  Adam Roben  <aroben@apple.com>
3974
3975         Import File::Basename in webkitdirs since we use it
3976
3977         * Scripts/webkitdirs.pm:
3978
3979 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
3980
3981         - Updated the tiger leaks list to make the internal bots green.
3982
3983         * Scripts/run-webkit-tests:
3984
3985 2007-10-17  Adam Roben  <aroben@apple.com>
3986
3987         Build fix for VC++ Express
3988
3989         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
3990         and ole32.lib.
3991
3992 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
3993
3994         Reviewed by Sam.
3995
3996         - Minor mac improvements based on observations I made while implementing the
3997         Windows code.
3998
3999         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
4000         then hand it to the Client who will retain it, it should just be the client who
4001         creates and owns the server.
4002         (-[DebuggerApplication attach:]):
4003         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
4004         * Drosera/mac/DebuggerClient.mm: Creates the server.
4005         (-[DebuggerClient initWithServerName:]):
4006         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
4007         can instead forward declare what it needs.
4008
4009 2007-10-16  Darin Adler  <darin@apple.com>
4010
4011         Reviewed by Geoff Garen.
4012
4013         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
4014         want to turn failing tests into platform-specific test results. Also did a
4015         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
4016         would take the type of results into account only some of the time.
4017
4018 2007-10-16  Adam Roben  <aroben@apple.com>
4019
4020         Add a new nightly launcher script for Windows
4021
4022         This new script is for versions of Safari that don't delay-load
4023         WebKit. I had to make FindSafari be able to print out the nightly
4024         launcher script on stdout because Windows shell scripts can't capture
4025         the output from a command into an environment variable.
4026
4027         Reviewed by Steve.
4028
4029         * FindSafari/FindSafari.cpp:
4030         (_tmain): Added /printSafariLauncher option.
4031         * Scripts/run-webkit-nightly.cmd: Added.
4032
4033 2007-10-16  Adam Roben  <aroben@apple.com>
4034
4035         Replace WebKitInitializer with FindSafari
4036
4037         We now rely on setting the PATH environment variable to tell Windows
4038         where to find WebKit and its dependencies (similar to
4039         DYLD_FRAMEWORK_PATH on Mac).
4040
4041         This change also make DumpRenderTree no longer delay-load WebKit.
4042
4043         Reviewed by Sam.
4044
4045         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
4046         FindSafari.
4047         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
4048         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
4049         WebKitInitializer, don't delay-load WebKit.
4050         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
4051         * Scripts/run-webkit-tests: Ditto.
4052         * Scripts/webkitdirs.pm:
4053         (sub setPathForRunningWebKitApp): Added.
4054         * WebKitInitializer/WebKitInitializer.cpp: Removed.
4055         * WebKitInitializer/WebKitInitializer.h: Removed.
4056         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
4057         * WebKitInitializer/debug.vsprops: Removed.
4058         * WebKitInitializer/debug_internal.vsprops: Removed.
4059         * WebKitInitializer/release.vsprops: Removed.
4060
4061 2007-10-16  Adam Roben  <aroben@apple.com>
4062
4063         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
4064
4065         http://bugs.webkit.org/show_bug.cgi?id=15532
4066
4067         FindSafari simply prints the location of an installed Safari.exe on
4068         stdout.
4069
4070         Reviewed by Darin.
4071
4072         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
4073         (getStringValue):
4074         (getWebViewCLSID):
4075         (getInstalledWebKitDirectory):
4076         (_tmain):
4077         * FindSafari/FindSafari.vcproj: Added.
4078         * Scripts/webkitdirs.pm:
4079         (sub installedSafariPath): Added. Calls FindSafari on Windows.
4080
4081 2007-10-16  Adam Roben  <aroben@apple.com>
4082
4083         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
4084
4085         Reviewed by Kevin McCullough.
4086
4087         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
4088         when referring to WebKit.dll.
4089         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
4090         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
4091         * DumpRenderTree/win/release.vsprops: Ditto.
4092         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
4093         never have a _debug suffix on WebKit.dll.
4094         * WebKitInitializer/WebKitInitializer.cpp:
4095         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
4096         specified.
4097         * WebKitInitializer/debug_internal.vsprops: Added
4098         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
4099
4100 2007-10-16  Darin Adler  <darin@apple.com>
4101
4102         Reviewed by Adele.
4103
4104         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
4105         Remove now-unneeded control/alt key hack; the tests have been updated.
4106
4107 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
4108
4109         - Updated leaks list because our internal bot upgraded it's version of leopard and 
4110         one of the leaks was fixed between that revision and the bot's previous version of
4111         leopard.
4112
4113         * Scripts/run-webkit-tests:
4114
4115 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
4116
4117         Reviewed by Tim.
4118
4119         - I encapsulated out the server connecton functionality because it is a specific part
4120         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
4121         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
4122         Windows.  So the majority of this patch is moving preexisting functionality.
4123
4124         - Also I removed the prefix header and changed to use config.h because it is more
4125         standard on how we use config.h in windows and it didn't make much sense to keep
4126         the prefix header and the config.h
4127
4128         * Drosera/DebuggerDocument.cpp:
4129         (DebuggerDocument::DebuggerDocument):
4130         * Drosera/DebuggerDocument.h:
4131         * Drosera/config.h:
4132         * Drosera/mac/DebuggerApplication.mm:
4133         (-[DebuggerApplication attach:]):
4134         * Drosera/mac/DebuggerClient.h:
4135         * Drosera/mac/DebuggerClient.mm:
4136         (-[DebuggerClient initWithServerConnection:]):
4137         (-[DebuggerClient dealloc]):
4138         (-[DebuggerClient windowDidLoad]):
4139         (-[DebuggerClient windowWillClose:]):
4140         (-[DebuggerClient webView:didFinishLoadForFrame:]):
4141         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
4142         * Drosera/mac/DebuggerDocumentPlatform.mm:
4143         (DebuggerDocument::platformPause):
4144         (DebuggerDocument::platformResume):
4145         (DebuggerDocument::platformStepInto):
4146         (DebuggerDocument::platformEvaluateScript):
4147         (DebuggerDocument::getPlatformCurrentFunctionStack):
4148         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
4149         (DebuggerDocument::platformValueForScopeVariableNamed):
4150         (DebuggerDocument::platformLog):
4151         * Drosera/mac/Drosera.pch: Removed.
4152         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
4153         * Drosera/mac/ServerConnection.h: Added.
4154         * Drosera/mac/ServerConnection.mm: Added.
4155         (-[ServerConnection initWithServerName:]):
4156         (-[ServerConnection dealloc]):
4157         (-[ServerConnection setGlobalContext:]):
4158         (-[ServerConnection pause]):
4159         (-[ServerConnection resume]):
4160         (-[ServerConnection stepInto]):
4161         (-[ServerConnection switchToServerNamed:]):
4162         (-[ServerConnection applicationTerminating:]):
4163         (-[ServerConnection serverConnectionDidDie:]):
4164         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
4165         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
4166         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
4167         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
4168         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
4169         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
4170         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
4171         (-[ServerConnection currentFrame]):
4172         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
4173         (-[ServerConnection knownServers]):
4174
4175 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
4176
4177         Reviewed by Eric.
4178
4179         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
4180           Script to automatically search nightly builds for regressions (bisect-builds)
4181
4182         * Scripts/bisect-builds: Added.
4183
4184 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
4185
4186         Reviewed by Darin.
4187
4188         - New JavaScript benchmark
4189         http://bugs.webkit.org/show_bug.cgi?id=15515
4190
4191         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
4192         current development or release build of JavaScriptCore.
4193
4194 2007-10-15  Mark Rowe  <mrowe@apple.com>
4195
4196         Reviewed by Sam.
4197
4198         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
4199
4200         * Scripts/webkitdirs.pm:
4201         - Change checkArgv to remove the options from @ARGV to prevent
4202         them from interfering with further option processing.
4203         - Fix logic error in determineIsQt that would prevent it from bailing out early.
4204         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
4205         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
4206         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
4207
4208 2007-10-15  Darin Adler  <darin@apple.com>
4209
4210         Reviewed by Sam.
4211
4212         - added logging of window.prompt and window.confirm
4213
4214         * DumpRenderTree/mac/UIDelegate.mm:
4215         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
4216         Implement the recommended delegate rather than the deprecated one.
4217         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
4218         Added.
4219         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
4220         Added.
4221
4222         * DumpRenderTree/win/UIDelegate.h:
4223         * DumpRenderTree/win/UIDelegate.cpp:
4224         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
4225         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
4226         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
4227         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
4228
4229 2007-10-15  Alice Liu  <alice.liu@apple.com>
4230
4231         Reviewed by Sam Weinig.
4232
4233         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
4234
4235         * DumpRenderTree/win/DumpRenderTree.cpp:
4236         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
4237         (main): allocate the global policy delegate for DRT's custom use
4238         * DumpRenderTree/win/DumpRenderTree.vcproj:
4239         Adding files to project
4240         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
4241         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4242         (LayoutTestController::setCustomPolicyDelegate):
4243         set the webview's policy delegate to DRT's custom one if the test requests it.
4244         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
4245         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
4246         (PolicyDelegate::PolicyDelegate):
4247         (PolicyDelegate::QueryInterface):
4248         (PolicyDelegate::AddRef):
4249         (PolicyDelegate::Release):
4250         (PolicyDelegate::decidePolicyForNavigationAction):
4251         * DumpRenderTree/win/PolicyDelegate.h: Added.
4252         (PolicyDelegate::decidePolicyForNewWindowAction):
4253         (PolicyDelegate::decidePolicyForMIMEType):
4254         (PolicyDelegate::unableToImplementPolicyWithError):
4255
4256 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
4257
4258         Reviewed by Mark.
4259
4260         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
4261         when querying for QMAKE_MKSPECS.
4262
4263 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
4264
4265         Reviewed by Adam Roben.
4266         
4267         Fix run-webkit-tests is too greedy calculating platform hierarchy
4268         http://bugs.webkit.org/show_bug.cgi?id=15465
4269         
4270         Fix run-webkit-tests being too greedy in trying to split the platform name up
4271         causing it to try and find tests in every directory above the first "-" in the
4272         path to the LayoutTests
4273
4274         * Scripts/run-webkit-tests:
4275
4276 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
4277
4278         Reviewed by Darin.
4279
4280         http://bugs.webkit.org/show_bug.cgi?id=15006
4281         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
4282         to reduce code duplication.
4283
4284         * Scripts/build-webkit:
4285         * Scripts/webkitdirs.pm:
4286         buildQMakeProject() renamed to buildQMakeQtProject().
4287         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
4288         unused $colorize has been removed.
4289
4290 === Start merge of feature-branch 2007-10-12 ===
4291
4292 2007-10-08  Eric Seidel  <eric@webkit.org>
4293