WebKitTools/ChangeLog

   1 2008-02-14  Adam Roben  <aroben@apple.com>
   2
   3         Conditionalize cross-document messaging support
   4
   5         The cross-document messaging parts of HTML 5 are in flux and we want
   6         ports to be able to turn off the support as needed.
   7
   8         Note that the support is turned off by default right now. A subsequent
   9         commit will turn it on by default.
  10
  11         Reviewed by Darin.
  12
  13         * Scripts/build-webkit:
  14
  15 2008-02-14  Darin Adler  <darin@apple.com>
  16
  17        - fix Windows build
  18
  19         * DumpRenderTree/win/UIDelegate.cpp:
  20         (UIDelegate::setStatusText): Update parameter types to match declaration.
  21
  22 2008-02-14  Oliver Hunt  <oliver@apple.com>
  23
  24         Reviewed by Geoff G and Weinig.
  25
  26         Add ability for DRT to report tests setting the status text.
  27
  28         * DumpRenderTree/LayoutTestController.cpp:
  29         (LayoutTestController::LayoutTestController):
  30         (dumpStatusCallbacksCallback):
  31         (LayoutTestController::staticFunctions):
  32         * DumpRenderTree/LayoutTestController.h:
  33         * DumpRenderTree/mac/UIDelegate.mm:
  34         (-[UIDelegate webView:setStatusText:]):
  35         * DumpRenderTree/win/UIDelegate.cpp:
  36         * DumpRenderTree/win/UIDelegate.h:
  37
  38 2008-02-13  Adam Roben  <aroben@apple.com>
  39
  40         Windows build fix
  41
  42         * DumpRenderTree/ForwardingHeaders/wtf/MathExtras.h: Added.
  43
  44 2008-02-13  Adam Roben  <aroben@apple.com>
  45
  46         Windows/GTK+ build fix
  47
  48         * DumpRenderTree/LayoutTestController.cpp: #include MathExtras.h to
  49         get isnan.
  50
  51 2008-02-13  Brady Eidson  <beidson@apple.com>
  52
  53         Reviewed by Darin Adler
  54
  55         Add some much needed Database support to DRT
  56
  57         * DumpRenderTree/LayoutTestController.cpp:
  58         (LayoutTestController::LayoutTestController):
  59         (dumpDatabaseCallbacksCallback): Flag to control if the UIDelegate methods related to
  60           databases are called
  61         (clearAllDatabasesCallback): Allow a test to delete all databases
  62         (setDatabaseQuotaCallback): Allow a test to set the quota new origins will get
  63         (LayoutTestController::staticFunctions):
  64
  65         * DumpRenderTree/LayoutTestController.h:
  66         (LayoutTestController::dumpDatabaseCallbacks):
  67         (LayoutTestController::setDumpDatabaseCallbacks):
  68
  69         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  70         (LayoutTestController::clearAllDatabases):
  71         (LayoutTestController::setDatabaseQuota):
  72
  73         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  74         (LayoutTestController::clearAllDatabases): Stubbed out
  75         (LayoutTestController::setDatabaseQuota): Ditto
  76         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  77         (LayoutTestController::clearAllDatabases): Stubbed out with error message
  78         (LayoutTestController::setDatabaseQuota): Ditto
  79
  80         * DumpRenderTree/mac/UIDelegate.mm:
  81         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): Print a
  82           message with details about the event then return a 5mb quota like before
  83
  84
  85 2008-02-12  Steve Falkenburg  <sfalken@apple.com>
  86
  87         Changes to support merged MIDL output.
  88
  89         All COM interfaces are now generated to WebKit.h.
  90
  91         Reviewed by Sam, Ada.
  92
  93         * Drosera/win/BaseDelegate.h:
  94         * Drosera/win/DebuggerClient.cpp:
  95         * Drosera/win/DebuggerDocumentPlatform.cpp:
  96         * Drosera/win/Drosera.cpp:
  97         * Drosera/win/ServerConnection.cpp:
  98         * Drosera/win/ServerConnection.h:
  99         * DumpRenderTree/win/DumpRenderTree.cpp:
 100         * DumpRenderTree/win/EditingDelegate.h:
 101         * DumpRenderTree/win/EventSender.cpp:
 102         * DumpRenderTree/win/FrameLoadDelegate.cpp:
 103         * DumpRenderTree/win/FrameLoadDelegate.h:
 104         * DumpRenderTree/win/GCControllerWin.cpp:
 105         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 106         * DumpRenderTree/win/PolicyDelegate.h:
 107         * DumpRenderTree/win/ResourceLoadDelegate.h:
 108         * DumpRenderTree/win/UIDelegate.cpp:
 109         * DumpRenderTree/win/UIDelegate.h:
 110         * DumpRenderTree/win/WorkQueueItemWin.cpp:
 111
 112 2008-02-10  Dan Bernstein  <mitz@apple.com>
 113
 114         Reviewed by Oliver Hunt.
 115
 116         - fix a memory leak
 117
 118         * DumpRenderTree/cg/ImageDiffCG.cpp:
 119         (getDifferenceBitmap): Use a static CFMutableData instead of allocating
 120         and leaking the buffer each time.
 121
 122 2008-02-07  Adam Roben  <aroben@apple.com>
 123
 124         Fix error in bisect-builds when responding "broken" for the first
 125         build
 126
 127         Reviewed by Dave Kilzer.
 128
 129         * Scripts/bisect-builds: Only try to test the build if the nightly
 130         info for the current index has not been deleted.
 131
 132 2008-02-07  Geoffrey Garen  <ggaren@apple.com>
 133
 134         Reviewed by Alexey Proskuryakov.
 135
 136         Fixed two minor typos in the --root option, to get it working.
 137
 138         * Scripts/run-sunspider:
 139             1. Actually assign the function argument to our local variable.
 140             2. Actually set the $root variable, so we don't try to build later.
 141
 142 2008-02-05  Oliver Hunt  <oliver@apple.com>
 143
 144         RS=Eric.
 145
 146         Re-enable foreignObject by default as it is needed for a number of non-fO
 147         related SVG tests and none of the old known crashes occur anymore.
 148
 149         * Scripts/build-webkit:
 150
 151 2008-02-05  Steve Falkenburg  <sfalken@apple.com>
 152
 153         Build fix.  Don't override intermediate directory.
 154
 155         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
 156
 157 2008-02-05  Holger Hans Peter Freyther  <zecke@selfish.org>
 158
 159         Build fix for Windows. willCloseFrame is a pure virtual and we are
 160         forced to have an implementation.
 161
 162         This partially reverts r30014.
 163
 164         * DumpRenderTree/win/FrameLoadDelegate.cpp:
 165         (FrameLoadDelegate::willCloseFrame):
 166         * DumpRenderTree/win/FrameLoadDelegate.h:
 167
 168 2008-02-05  Nikolas Zimmermann  <zimmermann@kde.org>
 169
 170         Reviewed by Holger.
 171
 172         Don't build wrapper for SVGTestCase.js (special file for svg/dynamic-updates)
 173
 174         * Scripts/make-js-test-wrappers:
 175
 176 2008-02-05  Holger Freyther  <zecke@selfish.org>
 177
 178         Reviewed by Darin.
 179
 180         In http://bugs.webkit.org/show_bug.cgi?id=16853 it was identified that the
 181         the output of the willCloseFrame and didClearWindowObject FrameLoadDelegate
 182         depends on the order the tests are executed.
 183
 184         Propose to remove willCloseFrame and didlCearWindowObject output from the
 185         FrameLoadDelegate and update the test results. The output of didClearWindowObject
 186         is not interesting for any of the current tests and we have other ways to find
 187         out if a frame was closed or not.
 188
 189         * DumpRenderTree/mac/FrameLoadDelegate.mm:
 190         * DumpRenderTree/win/FrameLoadDelegate.cpp:
 191         (FrameLoadDelegate::didClearWindowObject):
 192         * DumpRenderTree/win/FrameLoadDelegate.h:
 193
 194 2008-02-04  Mark Rowe  <mrowe@apple.com>
 195
 196         Reviewed by Oliver Hunt.
 197
 198         Workaround for http://bugs.webkit.org/show_bug.cgi?id=16842
 199         Bug 16842: Hang in DRT in leaks mode due to signal handler doing unsafe things
 200
 201         Don't install the signal handler unless we are running the pixel tests.
 202         It is currently only used to restore the color profile, but by catching
 203         signals we can trigger a deadlock in DRT while running leak tests.
 204         The deadlock is tracked by http://bugs.webkit.org/show_bug.cgi?id=16842,
 205         and a more complete fix will need to be developed to address this for
 206         pixel tests as well.
 207
 208         * DumpRenderTree/mac/DumpRenderTree.mm:
 209         (dumpRenderTree):
 210
 211 2008-02-04  Mark Rowe  <mrowe@apple.com>
 212
 213        Gtk qmake build fix.
 214
 215         * Scripts/webkitdirs.pm:  Fix perl's complaint about an odd number of elements in anonymous hash.
 216
 217 2008-02-04  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
 218
 219         Reviewed by Alp Toker and Mark Rowe.
 220
 221         http://bugs.webkit.org/show_bug.cgi?id=16618
 222         [GTK] build-webkit and run-webkit-tests autootools support
 223
 224         * Scripts/build-webkit: added --database and --icon-database options
 225         * Scripts/run-launcher:
 226         * Scripts/run-webkit-tests:
 227         * Scripts/webkitdirs.pm:
 228
 229 2008-02-04  Oliver Hunt  <oliver@apple.com>
 230
 231         Reviewed by Steve F.
 232
 233         Partial fix for <rdar://5621244> Drag & Drop doesn't work correctly in DRT
 234
 235         Implement required DRT functionality to allow majority of Drag and Drop testcases to work.
 236         Issues include:
 237           * Uses Sleep() to implement leapForward reliably.
 238           * 3 DND tests still fail for reasons that i have not yet determined
 239           * Has to explicitly ignore an extraneous WM_MOUSELEAVE that i am at a loss to explain
 240
 241         * DumpRenderTree/win/EventSender.cpp:
 242         (leapForwardCallback):
 243         (mouseDownCallback):
 244         (doMouseUp):
 245         (mouseUpCallback):
 246         (doMouseMove):
 247         (mouseMoveToCallback):
 248           Minor updates to these functions to handle the different message queue structure.
 249
 250         (replaySavedEvents):
 251           More complicated now.  Where possible we just use the old while-loop model of execution,
 252           but when leapForward has been used we have to jump through some hoops and set up an
 253           inner event loop so that we can ensure messages get the correct time stamp.
 254
 255         * DumpRenderTree/win/UIDelegate.cpp:
 256         (UIDelegate::doDragDrop):
 257           Call replaySavedEvents directly to force synchronous handling of drag and drop.
 258
 259 2008-02-04  Rodney Dawes  <dobey@wayofthemonkey.com>
 260
 261         Reviewed by Alp Toker and Mark Rowe.
 262
 263         Fix http://bugs.webkit.org/show_bug.cgi?id=17175.
 264         Bug 17175: Use of C++ compiler flags in CFLAGS
 265
 266         * GNUmakefile.am: Use global_cxxflags as well as global_cflags in CXXFLAGS.
 267
 268 2008-02-04  Darin Adler  <darin@apple.com>
 269
 270         Reviewed by Geoff.
 271
 272         * Scripts/make-js-test-wrappers: Look at the whole LayoutTests tree, not just the fast
 273         and svg subdirectories. Added some more exceptions for the benefit of the fast/dom
 274         subdirectory.
 275
 276 2008-02-04  Adam Roben  <aroben@apple.com>
 277
 278         Windows Apple-only build fix
 279
 280         * DumpRenderTree/win/DumpRenderTree.vcproj: Added a new include
 281         directory.
 282
 283 2008-02-04  Alp Toker  <alp@atoker.com>
 284
 285         Rubber-stamped by Mark Rowe.
 286
 287         Remove all trailing whitespace in the GTK+ port and related
 288         components.
 289
 290         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
 291         * DumpRenderTree/gtk/GCControllerGtk.cpp:
 292         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 293         * GNUmakefile.am:
 294
 295 2008-02-01  Eric Seidel  <eric@webkit.org>
 296
 297         Reviewed by Oliver.
 298
 299         Also search LayoutTests/svg for js-based tests.
 300
 301         * Scripts/make-js-test-wrappers:
 302
 303 2008-01-31  Alp Toker  <alp@atoker.com>
 304
 305         Rubber-stamped by Adam Roben.
 306
 307         http://bugs.webkit.org/show_bug.cgi?id=17006
 308         [GTK] Header path should be webkit/webkit.h
 309
 310         Move the GTK+ API sources as needed and update the build systems.
 311
 312         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 313         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
 314         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
 315         * GNUmakefile.am:
 316         * GtkLauncher/main.c:
 317
 318 2008-01-30  Stephanie  <slewis@apple.com>
 319
 320         Reviewed by Geoff.
 321
 322         Add an option to run-webkit-tests to merge leaks results and print the number of unique leaks found under a certain call depth.  This should make it easier for the buildbots to track new leaks.
 323
 324         * Scripts/run-webkit-tests:
 325
 326 2008-01-30  Alexey Proskuryakov  <ap@webkit.org>
 327
 328         Reviewed by Adam Roben.
 329
 330         One more debug (external) fix.
 331
 332         * DumpRenderTree/win/DumpRenderTree.cpp: TestNetscapePlugin is built with a _debug suffix in both DebugInternal
 333         and Debug configurations.
 334
 335 2008-01-29  Geoffrey Garen  <ggaren@apple.com>
 336
 337         Reviewed by Sam Weinig. Sam Weinig.
 338
 339         Fixed <rdar://problem/5692566> fast/encoding/mailto-always-utf-8.html
 340         fails when run after fast/dom/Window/window-property-shadowing.html (16902)
 341
 342         Modified our policy delegates not to output window.name. Since a
 343         previous test may have explicitly set window.name, we can't rely on its
 344         implicit value in test results.
 345
 346         * DumpRenderTree/mac/PolicyDelegate.mm:
 347         (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
 348
 349         * DumpRenderTree/win/PolicyDelegate.cpp:
 350         (PolicyDelegate::decidePolicyForNavigationAction):
 351
 352 2008-01-29  Mark Rowe  <mrowe@apple.com>
 353
 354         Reviewed by Tim Hatcher.
 355
 356         <rdar://problem/5600926> WebCore on Tiger must link to its own copy of SQLite 3.4 or newer (so HTML database behavior will be correct).
 357
 358         * Scripts/build-webkit: Copy SQLite static library and headers into the build directory.
 359
 360 2008-01-29  David Kilzer  <ddkilzer@apple.com>
 361
 362         Refactor ChangeLog path code
 363
 364         Reviewed by Adam.
 365
 366         * Scripts/prepare-ChangeLog: Simplify code in one foreach() loop, and extract
 367         duplicate code in another foreach() loop.
 368
 369 2008-01-29  Alexey Proskuryakov  <ap@webkit.org>
 370
 371         Reviewed by Darin.
 372
 373         <rdar://problem/5710692> All storage tests fail/crash
 374
 375         * DumpRenderTree/mac/UIDelegate.mm:
 376         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): Set an
 377         arbitrary quota of 5 megabytes.
 378
 379         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
 380         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
 381         Removed unused (I think) code.
 382
 383         * DumpRenderTree/win/UIDelegate.cpp:
 384         (UIDelegate::QueryInterface): IWebUIDelegatePrivate3 is now supported.
 385         (UIDelegate::webViewPainted): A stub implementation.
 386         (UIDelegate::exceededDatabaseQuota): Set an arbitrary quota of 5 megabytes.
 387         * DumpRenderTree/win/UIDelegate.h:
 388
 389 2008-01-27  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
 390
 391         GTK+ DRT build fix for breakage introduced in r29822.
 392
 393         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 394         (LayoutTestController::setPersistentUserStyleSheetLocation):
 395         (LayoutTestController::clearPersistentUserStyleSheet):
 396
 397 2008-01-27  Dan Bernstein  <mitz@apple.com>
 398
 399         Reviewed by Darin Adler.
 400
 401         - add support for directory prologues and epilogues to run-webkit-tests
 402         - allow setting a persistent user style sheet in DumpRenderTree
 403         - activate the WebKit Layout Tests font in Windows DumpRenderTree
 404
 405         * DumpRenderTree/LayoutTestController.cpp:
 406         (clearPersistentUserStyleSheetCallback): Added.
 407         (setPersistentUserStyleSheetLocationCallback): Added.
 408         (LayoutTestController::staticFunctions): Added.
 409         clearPersistentUserStyleSheet and setPersistentUserStyleSheet.
 410         * DumpRenderTree/LayoutTestController.h:
 411         * DumpRenderTree/mac/DumpRenderTree.mm:
 412         (setPersistentUserStyleSheetLocation): Added.
 413         (resetWebViewToConsistentStateBeforeTesting): Added the user style sheet
 414         to the set of things this function resets. Now it either disables the
 415         user style sheet or sets it to the persistent user style sheet and
 416         enables it.
 417         * DumpRenderTree/mac/DumpRenderTreeMac.h:
 418         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 419         (LayoutTestController::setPersistentUserStyleSheetLocation): Added.
 420         (LayoutTestController::clearPersistentUserStyleSheet): Added.
 421         * DumpRenderTree/win/DumpRenderTree.cpp:
 422         (setPersistentUserStyleSheetLocation): Added.
 423         (initialize): Added the WebKit Layout Tests font to the set of fonts to
 424         install.
 425         (resetWebViewToConsistentStateBeforeTesting): See DumpRenderTree.mm.
 426         * DumpRenderTree/win/DumpRenderTreeWin.h:
 427         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 428         (LayoutTestController::setPersistentUserStyleSheetLocation): Added.
 429         (LayoutTestController::clearPersistentUserStyleSheet): Added.
 430         * Scripts/run-webkit-tests: Changed to look for, and if found process in
 431         DumpRenderTree, files named run-webkit-tests-prologue.html and
 432         run-webkit-tests-epilogue.html in the resources subdirectory of any
 433         test directory and platform test results directory. The prologues are
 434         processed before the first test from the directory (and its
 435         subdirectories) is run, and the epilogues are processed after the last
 436         test from the directory is run. Platform-specific prologues and
 437         epilogues are processed in order of specificity.
 438
 439 2008-01-25  Alexey Proskuryakov  <ap@webkit.org>
 440
 441         Reviewed by Mark Rowe.
 442
 443         <rdar://problem/5699933> http/tests/security/cross-frame-access-get.html is still failing
 444
 445         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Clear HTTP cache to ensure consistent test environment
 446         (matching Mac DRT).
 447         * DumpRenderTree/win/DumpRenderTree.vcproj: Link to CFNetwork.
 448
 449 2008-01-24  Sam Weinig  <sam@webkit.org>
 450
 451         Reviewed by Ada Chan.
 452
 453         Fix for <rdar://5131975> DumpRenderTree doesn't support undo/redo
 454
 455         - Adds simplified UndoManager to windows DRT to allow testing the
 456           undo/redo code paths in WebCore and WebKit.  This is a temporary
 457           solution to an issue that should eventually be solved by having a
 458           shared UndoManager in WebKit.
 459
 460         * DumpRenderTree/win/DumpRenderTree.cpp:
 461         (runTest):
 462         * DumpRenderTree/win/UIDelegate.cpp:
 463         (DRTUndoObject::DRTUndoObject):
 464         (DRTUndoObject::invoke):
 465         (DRTUndoStack::~DRTUndoStack):
 466         (DRTUndoStack::isEmpty):
 467         (DRTUndoStack::clear):
 468         (DRTUndoStack::push):
 469         (DRTUndoStack::pop):
 470         (DRTUndoManager::canRedo):
 471         (DRTUndoManager::canUndo):
 472         (DRTUndoManager::DRTUndoManager):
 473         (DRTUndoManager::removeAllActions):
 474         (DRTUndoManager::registerUndoWithTarget):
 475         (DRTUndoManager::redo):
 476         (DRTUndoManager::undo):
 477         (UIDelegate::UIDelegate):
 478         (UIDelegate::resetUndoManager):
 479         (UIDelegate::registerUndoWithTarget):
 480         (UIDelegate::removeAllActionsWithTarget):
 481         (UIDelegate::setActionTitle):
 482         (UIDelegate::undo):
 483         (UIDelegate::redo):
 484         (UIDelegate::canUndo):
 485         (UIDelegate::canRedo):
 486         * DumpRenderTree/win/UIDelegate.h:
 487
 488 2008-01-23  Adam Roben  <aroben@apple.com>
 489
 490         Allow directories containing ChangeLogs to be passed to
 491         resolve-ChangeLogs
 492
 493         Reviewed by David Kilzer.
 494
 495         * Scripts/resolve-ChangeLogs:
 496         (sub findChangeLog): Return a ChangeLog contained within the specified
 497         directory if one exists.
 498
 499 2008-01-23  Steve Falkenburg  <sfalken@apple.com>
 500
 501         <rdar://problem/5698732> Copyright strings should include 2008
 502
 503         Reviewed by Sam.
 504
 505         * Drosera/win/Drosera.vcproj/Drosera.rc:
 506         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc:
 507
 508 2008-01-23  Alp Toker  <alp@atoker.com>
 509
 510         Rubber-stamped by Mark Rowe.
 511
 512         Remove whitespace after -I in automake include lists.
 513
 514         * GNUmakefile.am:
 515
 516 2008-01-23  Michael Goddard <michael.goddard@trolltech.com>
 517
 518         Reviewed by Lars Knoll <lars@trolltech.com>.
 519
 520         Reworked the JavaScriptCore Qt bindings:
 521
 522         * Update JS DRT controller for Qt JS binding changes.
 523         There were two functions that needed some changes
 524         so that the layout tests would work, so this makes
 525         a few tests pass again.
 526
 527         * Bump the timeout for layout tests up to 11s.
 528         At least some tests have an internal timeout of
 529         10 seconds, so make the waitUntilDone approach
 530         wait at least 11s.  fast/dom/open-and-close-by-DOM.html
 531         is one of these - now the failure message is more
 532         accurate.
 533
 534
 535         * DumpRenderTree/qt/jsobjects.cpp:
 536         (LayoutTestController::waitUntilDone):
 537         * DumpRenderTree/qt/jsobjects.h:
 538
 539 2008-01-22  Anders Carlsson  <andersca@apple.com>
 540
 541         Reviewed by Darin and Adam.
 542
 543         <rdar://problem/5688975>
 544         div element on microsoft site has wrong left offset.
 545
 546         Add new method for testing the return vale of NPN_GetProperty.
 547
 548         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
 549         (pluginInvoke):
 550
 551 2008-01-22  Alexey Proskuryakov  <ap@webkit.org>
 552
 553         Reviewed by Adam Roben.
 554
 555         <rdar://problem/5670257> editing/selection/4895428-3.html makes editing/selection/5131716-2.html fail
 556
 557         * DumpRenderTree/win/EventSender.cpp: (makeEventSender): Reset static variables for a new test.
 558
 559 2008-01-21  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
 560
 561         Reviewed by Alp Toker.
 562
 563         http://bugs.webkit.org/show_bug.cgi?id=16955
 564         Get errors when cross-compile webkit-gtk
 565
 566         * GNUmakefile.am: Removed ICU_CFLAGS
 567
 568 2008-01-21  Darin Adler  <darin@apple.com>
 569
 570         Reviewed by Mitz and Adam.
 571
 572         * Scripts/svn-create-patch: Sort ChangeLog files first. Also slightly improved the
 573         sorting speed by doing all sort criteria in a single pass instead of three sorts.
 574
 575 2008-01-21  Simon Hausmann  <hausmann@webkit.org>
 576
 577         Reviewed by Holger.
 578
 579         Fix focus chain handling and cycling through focusable objects (links) using tab/backtab.
 580
 581         * Fix GraphicsContext::drawFocusRing to also draw single focus rects.
 582         * Implemented QWebPage::focusNextPrevChild by sending fake tab/shift-tab events
 583         and make the return value depend on whether we successfully determined a focusable
 584         node or not.
 585         * Changed QWebView::focusNextPrevChild() to call the base QWidget implementation correctly
 586         if we could not handle the focus chain ourselves.
 587         * Changed the focus policy of QWebView to correctly use WheelFocus instead of ClickFocus.
 588         * Made ChromeClientQt::canTakeFocus() and takeFocus() dummy method since they are only
 589         used to control the situation of stepping out of the focus chain inside the page.
 590         * Made inclusion of links in the focus chain configurable through QWebSettings::LinksIncludedInFocusChain.
 591         The layout tests expect this to be disabled but for the user it seems sensible to have it
 592         on by default, hence the default in qwebsettings.cpp
 593
 594
 595         * DumpRenderTree/qt/DumpRenderTree.cpp:
 596         (WebCore::WebPage::WebPage):
 597
 598 2008-01-19  Mark Rowe  <mrowe@apple.com>
 599
 600         Reviewed by Alp Toker.
 601
 602         Allow the --http flag to run-webkit-tests to override
 603         the default behaviour of disabling HTTP tests for Qt,
 604         Gtk and Wx.
 605
 606         * Scripts/run-webkit-tests:
 607
 608 2008-01-19  David Kilzer  <ddkilzer@apple.com>
 609
 610         <rdar://problem/5695344> check-for-global-initializers script never checks any object files
 611
 612         Reviewed by Darin.
 613
 614         We now touch a check-for-global-initializers.timestamp file in
 615         the TARGET_TEMP_DIR directory to determine when new object files
 616         have been compiled and thus need to be checked.  If the timestamp
 617         file doesn't exist, all object files will be checked.
 618
 619         Previously the modification time of the "executable" (the
 620         framework binary, e.g., WebKit.framework/WebKit) was used, but
 621         since this was the last file modified at the end of the compile
 622         phase, no object files would ever get checked!
 623
 624         Also added JSCustomSQLTransactionCallback.o to the list of files
 625         since it has static initializers in Debug builds of WebCore.
 626
 627         * Scripts/check-for-global-initializers:
 628
 629 2008-01-18  Adam Roben  <aroben@apple.com>
 630
 631         Build fix
 632
 633         * Scripts/build-webkit:
 634
 635 2008-01-18  Beth Dakin  <bdakin@apple.com>
 636
 637         Reviewed by Oliver.
 638
 639         Update build-webkit to account for foreign-object being disabled by
 640         default.
 641
 642         * Scripts/build-webkit:
 643
 644 2008-01-18  Adam Roben  <aroben@apple.com>
 645
 646         Updated for method renames
 647
 648         Reviewed by Adele.
 649
 650         * DumpRenderTree/mac/FrameLoadDelegate.mm:
 651         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
 652         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 653         (LayoutTestController::setMainFrameIsFirstResponder):
 654         (LayoutTestController::setWindowIsKey):
 655         * DumpRenderTree/mac/UIDelegate.mm:
 656         (-[UIDelegate webViewFocus:]):
 657         * DumpRenderTree/win/FrameLoadDelegate.cpp:
 658         (FrameLoadDelegate::didCommitLoadForFrame):
 659
 660 2008-01-18  Alexey Proskuryakov  <ap@webkit.org>
 661
 662         Reviewed by Adam Roben.
 663
 664         Fix plugin-related tests in Debug_Internal configuration, which are failing because of CRT version mismatch
 665         between DRT and TestNetscapePlugin.
 666
 667         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Added a Debug_Internal configuration.
 668         * DumpRenderTree/DumpRenderTree.sln: Use this configuration.
 669
 670 2008-01-18  Simon Hausmann  <hausmann@webkit.org>
 671
 672         Reviewed by Holger.
 673
 674         Fix fast/dom/Window/window-resize.html
 675
 676         In DRT connect the page's geometryChangeRequest signal to a slot that
 677         sets the geometry of the view widget.
 678
 679
 680         * DumpRenderTree/qt/DumpRenderTree.cpp:
 681         (WebCore::WebPage::setViewGeometry):
 682         (WebCore::WebPage::WebPage):
 683
 684 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
 685
 686         Build fix.
 687
 688         * Drosera/DroseraWin.make:
 689
 690 2008-01-17  Darin Adler  <darin@apple.com>
 691
 692         * Scripts/run-webkit-tests: Fixed a bug number.
 693
 694 2008-01-17  Alexey Proskuryakov  <ap@webkit.org>
 695
 696         Reviewed by Adam Roben.
 697
 698         http://bugs.webkit.org/show_bug.cgi?id=16908
 699         run-webkit-tests complains about missing FindSafari.exe
 700
 701         * Scripts/webkitdirs.pm: Append _debug as appropriate.
 702
 703 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
 704
 705         Re-add DEBUG_WEBKIT_HAS_SUFFIX.
 706
 707         Rubber-stamped by Jon Honeycutt.
 708
 709         * DumpRenderTree/win/DumpRenderTree.vcproj:
 710
 711 2008-01-16  Alp Toker  <alp@atoker.com>
 712
 713         Reviewed by Mark Rowe.
 714
 715         http://bugs.webkit.org/show_bug.cgi?id=16218
 716         [GTK] API: Should this entry point be called go_back rather than go_backward?
 717
 718         Track back/forward API changes in the tools.
 719
 720         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
 721         (BackForwardItem::invoke):
 722         * GtkLauncher/main.c:
 723         (go_back_cb):
 724
 725 2008-01-16  Adam Roben  <aroben@apple.com>
 726
 727         Windows build fix after r29488
 728
 729         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
 730         Build into a subdirectory of $WebKitOutputDir\bin to match where DRT
 731         expects to find the plugin.
 732
 733 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
 734
 735         Reviewed by Sam Weinig.
 736
 737         Fixed the waitUntilDone watchdog timer -- the old code never added the
 738         timer to the run loop, so it didn't do anything.
 739
 740         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 741         (LayoutTestController::setWaitToDump):
 742         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 743         (LayoutTestController::setWaitToDump):
 744
 745 2008-01-14  Steve Falkenburg  <sfalken@apple.com>
 746
 747         Use shared vsprops for most vcproj properties.
 748
 749         Reviewed by Darin.
 750
 751         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
 752         * DumpRenderTree/win/DumpRenderTree.vcproj:
 753         * DumpRenderTree/win/ImageDiff.vcproj:
 754         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
 755         * FindSafari/FindSafari.vcproj:
 756
 757 2008-01-14  Stephanie  <slewis@apple.com>
 758
 759        Reviewed by NOBODY.
 760
 761        revert accidental character.
 762
 763        * Scripts/run-webkit-tests:
 764
 765 2008-01-14  Stephanie  <slewis@apple.com>
 766
 767         RS=Oliver
 768
 769         add Quicktime PPC only leaks to Leopard exclude list. See <rdar://problem/5667132>
 770
 771         * Scripts/run-webkit-tests:
 772
 773 2008-01-14  Darin Adler  <darin@apple.com>
 774
 775         * Scripts/do-webcore-rename: Queue up another rename.
 776
 777 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
 778
 779         Reviewed by Darin.
 780
 781         * Allow to run the tests in reverse order to spot test cases where the result depends on the order
 782         the tests were ran.
 783         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
 784
 785         * Scripts/run-webkit-tests:
 786
 787 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
 788
 789         Reviewed by Darin.
 790
 791         * Randomize tests array to spot test cases where the results depends on the order
 792         the tests are ran.
 793         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
 794
 795         * Scripts/run-webkit-tests:
 796
 797 2008-01-14  Darin Adler  <darin@apple.com>
 798
 799         * Scripts/run-webkit-tests: More ignore list tweaking.
 800
 801 2008-01-14  Darin Adler  <darin@apple.com>
 802
 803         * Scripts/run-webkit-tests: Add another leak to the ignore list.
 804
 805 2008-01-14  Dan Bernstein  <mitz@apple.com>
 806
 807         Reviewed by Adam Roben.
 808
 809         - try to fix failure in fast/dom/Window/window-onFocus.html seen on the
 810           build bots
 811
 812         * DumpRenderTree/win/DumpRenderTree.cpp:
 813         (resetWebViewToConsistentStateBeforeTesting): Focus the web view.
 814
 815 2008-01-13  Steve Falkenburg  <sfalken@apple.com>
 816
 817         Share common files across projects.
 818
 819         Unify vsprops files
 820         Debug:          common.vsprops, debug.vsprops
 821         Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
 822         Release:        common.vsprops, release.vsprops
 823
 824         Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
 825         debug_internal.vsprops will be mostly empty except for file path prefix modifiers.
 826
 827         Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.
 828
 829         Reviewed by Adam Roben.
 830
 831         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
 832         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Removed.
 833         * Drosera/win/Drosera.vcproj/VERSION: Removed.
 834         * Drosera/win/Drosera.vcproj/auto-version.sh: Removed.
 835         * Drosera/win/Drosera.vcproj/debug.vsprops: Removed.
 836         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Removed.
 837         * Drosera/win/Drosera.vcproj/release.vsprops: Removed.
 838         * DumpRenderTree/win/DumpRenderTree.vcproj:
 839         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
 840         * DumpRenderTree/win/debug.vsprops: Removed.
 841         * DumpRenderTree/win/debug_internal.vsprops: Removed.
 842         * DumpRenderTree/win/release.vsprops: Removed.
 843
 844 2008-01-13  Brent Fulgham  <bfulgham@gmail.com>
 845
 846         Reviewed by Maciej.
 847
 848         - http://bugs.webkit.org/show_bug.cgi?id=16314
 849           Script to launch Drosera
 850
 851         * Scripts/gdb-drosera: Added.
 852         * Scripts/run-drosera: Added.
 853         * Scripts/run-drosera-nightly.cmd: Added.
 854         * Scripts/webkitdirs.pm: Added runDrosera function.
 855
 856 2008-01-13  Dan Bernstein  <mitz@apple.com>
 857
 858         - fix breakage due to last-minute change
 859
 860         * DumpRenderTree/win/DumpRenderTree.cpp:
 861         (runTest): Declare the loop variable.
 862
 863 2008-01-13  Dan Bernstein  <mitz@apple.com>
 864
 865         Reviewed by Adam Roben.
 866
 867         - fix <rdar://problem/5132009> Windows DRT does not support multiple windows
 868
 869         * DumpRenderTree/win/DumpRenderTree.cpp:
 870         (DumpRenderTreeWndProc):
 871         (initialize):
 872         (dumpBackForwardList):
 873         (dumpBackForwardListForAllWindows):
 874         (dump):
 875         (resetWebViewToConsistentStateBeforeTesting): Factored out of
 876         runTest().
 877         (runTest):
 878         (allWindows): Added. Returns a vector of all open windows.
 879         (windowToWebViewMap): Added. Returns a map from open windows to their
 880         WebViews.
 881         (createWebViewAndOffscreenWindow): Factored out of main() to be
 882         reusable for creating extra windows.
 883         (main):
 884         * DumpRenderTree/win/DumpRenderTreeWin.h:
 885         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 886         (LayoutTestController::windowCount): Implemented.
 887         * DumpRenderTree/win/UIDelegate.cpp:
 888         (UIDelegate::createWebViewWithRequest): Implemented.
 889         (UIDelegate::webViewClose): Implemented.
 890         * DumpRenderTree/win/UIDelegate.h:
 891
 892 2008-01-12  Alp Toker  <alp@atoker.com>
 893
 894         Reviewed by Mark Rowe.
 895
 896         Hide non-public symbols in GTK+/autotools release builds.
 897
 898         * GNUmakefile.am:
 899
 900 2008-01-12  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
 901
 902         Reviewed by Ap.
 903
 904         * Make launching of the WebKit httpd work on GNU/Debian/Linux
 905
 906         The configuration of Apache2 and installation does not depend on
 907         the kernel but on the distribution policy. Make launching of httpd
 908         work for Debian derived distributions.
 909
 910         * Scripts/run-webkit-httpd:
 911         * Scripts/run-webkit-tests:
 912         * Scripts/webkitdirs.pm:
 913
 914 2008-01-12  Mark Rowe  <mrowe@apple.com>
 915
 916         Reviewed by Maciej Stachowiak.
 917
 918         Fix crash in http/tests/security/local-JavaScript-from-remote.html under guard malloc.
 919
 920         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Retain string before returning it to
 921         match the callers expectations that it can take ownership of the string.
 922
 923 2008-01-11  Alexey Proskuryakov  <ap@webkit.org>
 924
 925         Reviewed by Adam Roben.
 926
 927         <rdar://problem/5667275> fast/dynamic/layer-hit-test-crash.html is failing
 928
 929         * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ignore WM_MOUSELEAVE events,
 930         as these are only posted because the test window is not a normal visible one, and
 931         they confuse drag&drop machinery.
 932
 933 2008-01-11  Adam Roben  <aroben@apple.com>
 934
 935         Fix a crash when pathToLocalResource fails and a leak
 936
 937         Reviewed by Darin.
 938
 939         * DumpRenderTree/LayoutTestController.cpp:
 940         (pathToLocalResourceCallback): Dont leak the JSStringRef, and make
 941         sure not to pass null to JSValueMakeString.
 942         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 943         (LayoutTestController::pathToLocalResource): Print an error message if
 944         the conversion fails so it's clear what happened.
 945
 946 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
 947
 948         Reviewed by John Sullivan.
 949
 950         * DumpRenderTree/mac/GCControllerMac.mm:
 951         (GCController::collectOnAlternateThread): Updated for name change.
 952
 953 2008-01-10  Kevin Ollivier  <kevino@theolliviers.com>
 954
 955         wx build fix. Don't build dftables any longer since it's now a Perl
 956         script.
 957
 958         * wx/build-wxwebkit:
 959
 960 2008-01-10  Sam Weinig  <sam@webkit.org>
 961
 962         Reviewed by Anders Carlsson.
 963
 964         Make DRT track open windows instead of allocated windows so that
 965         we can avoid ASSERTION due to late deallocs out of our control.
 966
 967         * DumpRenderTree/mac/DumpRenderTree.mm:
 968         (dumpBackForwardListForAllWindows):
 969         (runTest):
 970         * DumpRenderTree/mac/DumpRenderTreeMac.h:
 971         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
 972         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
 973         (+[DumpRenderTreeWindow openWindows]):
 974         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
 975         (-[DumpRenderTreeWindow close]):
 976         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 977         (LayoutTestController::windowCount):
 978
 979 2008-01-10  Ada Chan  <adachan@apple.com>
 980
 981         Meta key is not the same as Alt key on windows.
 982
 983         Reviewed by Darin.
 984
 985         * DumpRenderTree/win/EventSender.cpp:
 986         (keyDownCallback):
 987
 988 2008-01-09  Kevin McCullough  <kmccullough@apple.com>
 989
 990         Reviewed by Darin, Sam and Adam.
 991
 992         -<rdar://problem/5654486> REGRESSION (Safari 3.0.4-TOT): clicking on
 993         link in gmail message displays JavaScript alert falsely complaining
 994         about pop-up blocking.
 995         - Added the ability to enable the pop-up blocker via the
 996         LayoutTestController.
 997
 998         * DumpRenderTree/LayoutTestController.cpp:
 999         (setPopupBlockingEnabledCallback):
1000         (LayoutTestController::staticFunctions):
1001         * DumpRenderTree/LayoutTestController.h:
1002         * DumpRenderTree/mac/DumpRenderTree.mm:
1003         (setDefaultsToConsistentValuesForTesting):
1004         (resetWebViewToConsistentStateBeforeTesting):
1005         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1006         (LayoutTestController::setPopupBlockingEnabled):
1007
1008 2008-01-10  Lars Knoll  <lars@trolltech.com>
1009
1010         Reviewed by Simon.
1011
1012         rename QWebPageHistory to QWebHistory.
1013
1014
1015         * DumpRenderTree/qt/jsobjects.cpp:
1016
1017 2008-01-09  Maciej Stachowiak  <mjs@apple.com>
1018
1019         Reviewed by Darin.
1020
1021         - add some more renames, adjust some
1022
1023         * Scripts/do-webcore-rename:
1024
1025 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
1026
1027         Reviewed by Oliver.
1028
1029         Enable SVG Fonts support by default.
1030
1031         * Scripts/build-webkit:
1032
1033 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
1034
1035         Reviewed by Adam.
1036
1037         Fixes: http://bugs.webkit.org/show_bug.cgi?id=16244
1038         DRT doesn't handle platform specific pixel test results correctly.
1039
1040         <test>-expected.txt files and <test>-expected.png files may now live
1041         in different directories (ie. a cross-platform <test>-expected.txt file
1042         and a platform-specific <test>-expected.png file).
1043
1044         * Scripts/run-webkit-tests:
1045
1046 2008-01-04  Kevin McCullough  <kmccullough@apple.com>
1047
1048         Reviewed by Darin.
1049
1050         - <rdar://problem/5666914> fast/regex/test{1,4}.html are failing
1051         DRT did not correctly handle printing the '\0' char.  Now it does.
1052
1053         * DumpRenderTree/win/DumpRenderTree.cpp:
1054         (dumpFramesAsText):
1055         (dump):
1056
1057 2008-01-07  Simon Hausmann  <hausmann@webkit.org>
1058
1059         Reviewed by Lars.
1060
1061         Ported of the network backend of the Qt platform to Qt 4.4's new networking API.
1062
1063
1064         * DumpRenderTree/qt/main.cpp:
1065         * DumpRenderTree/qt/testplugin.cpp:
1066         * DumpRenderTree/qt/testplugin.h:
1067
1068 2008-01-05  Mark Rowe  <mrowe@apple.com>
1069
1070         Reviewed by Alp Toker.
1071
1072         Fix hang in fast/frames/frame-display-none-focus.html during Gtk layout tests.
1073
1074         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1075         (processWork): Process pending work.
1076         (webViewLoadFinished): Schedule processing of pending work.
1077         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Use webkit_web_frame_reload.
1078
1079 2008-01-05  Darin Adler  <darin@apple.com>
1080
1081         * Scripts/do-webcore-rename: Some more renaming plans.
1082
1083 2008-01-04  Alice Liu  <alice.liu@apple.com>
1084
1085         Reviewed by Alexey and Darin.
1086
1087         Adding "home" and "end" to DRT's keydown since
1088         DOM key events can't handle keyIdentifiers at this point.
1089
1090         * DumpRenderTree/mac/EventSendingController.mm:
1091         (-[EventSendingController keyDown:withModifiers:]):
1092         * DumpRenderTree/win/EventSender.cpp:
1093         (keyDownCallback):
1094
1095 2008-01-04  Lars Knoll  <lars@trolltech.com>
1096
1097         Reviewed by Simon.
1098
1099         fix DRT after the changes to QWebPage.
1100
1101         The great thing is that we actually don't have
1102         any regressions from the QWebPage change :)
1103
1104
1105         * DumpRenderTree/qt/DumpRenderTree.cpp:
1106         (WebCore::DumpRenderTree::DumpRenderTree):
1107
1108 2008-01-04  Lars Knoll  <lars@trolltech.com>
1109
1110         Reviewed by Simon.
1111
1112         make QWebPage a QObject and get things to compile.
1113
1114         Nothing works currently though.
1115
1116
1117         * DumpRenderTree/qt/DumpRenderTree.cpp:
1118         (WebCore::DumpRenderTree::DumpRenderTree):
1119
1120 2008-01-04  Lars Knoll  <lars@trolltech.com>
1121
1122         Reviewed by Simon.
1123
1124         take a QString as identifier in QWebFrame::addToJSWindowObject.
1125
1126         * DumpRenderTree/qt/DumpRenderTree.cpp:
1127         (WebCore::DumpRenderTree::initJSObjects):
1128
1129 2008-01-04  Alp Toker  <alp@atoker.com>
1130
1131         GTK+ DRT build fix for breakage introduced in r29149.
1132
1133         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1134         (LayoutTestController::execCommand):
1135
1136 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
1137
1138         Reviewed by Darin.
1139
1140         <rdar://problem/5463489> A number of layout tests should be using execCommand instead of textInputController
1141
1142         Added layoutTestController.execCommand to access editor commands that are not available
1143         via document.execCommand.
1144
1145         * DumpRenderTree/LayoutTestController.cpp:
1146         (execCommandCallback):
1147         (LayoutTestController::staticFunctions):
1148         * DumpRenderTree/LayoutTestController.h:
1149         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1150         (LayoutTestController::execCommand):
1151         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1152         (LayoutTestController::queueLoad):
1153         (LayoutTestController::execCommand):
1154
1155 2008-01-03  Alice Liu  <alice.liu@apple.com>
1156
1157         Reviewed by Darin, Mitz.
1158
1159         fixed <rdar://5130762> mousedowns in different locations increase the clickcount incorrectly
1160
1161         the clickcount should not increase if the last click was at a different location.  it's a new click.
1162
1163         * DumpRenderTree/mac/DumpRenderTree.mm:
1164         (runTest):
1165         * DumpRenderTree/mac/EventSendingController.h:
1166         * DumpRenderTree/mac/EventSendingController.mm:
1167         (-[EventSendingController mouseDown]):
1168         (-[EventSendingController mouseUp]):
1169
1170 2008-01-03  Darin Adler  <darin@apple.com>
1171
1172         Reviewed by Adam.
1173
1174         * Scripts/update-webkit: Make this work a little better for the people at Apple
1175         who have a directory named Internal.
1176
1177 2008-01-03  Adam Roben  <aroben@apple.com>
1178
1179         Use HTTP::Date instead of Date::Parse because it's installed by Cygwin by default
1180
1181         Rubberstamped by Mark.
1182
1183         * Scripts/update-webkit-auxiliary-libs:
1184
1185 2008-01-03  Adam Roben  <aroben@apple.com>
1186
1187         Fix Bug 15663: update-webkit re-downloads WebKitAuxiliaryLibrary unnecessarily
1188
1189         http://bugs.webkit.org/show_bug.cgi?id=15663
1190
1191         Added a fuzz factor into the Last-Modified comparison for downloading
1192         WebKitAuxiliaryLibrary.zip.
1193
1194         The zip file is served from a set of mirrors who give Last-Modified
1195         times that are off by 1-3 seconds from each other. This was causing
1196         the build bots to redownload WebKitAuxiliaryLibrary for every build,
1197         which would then cause all of WebCore to rebuild each time.
1198
1199         Reviewed by Mark.
1200
1201         * Scripts/update-webkit-auxiliary-libs: Check if the new zip file is
1202         at least 30 seconds newer than the old one -- otherwise we assume that
1203         the difference in time is due to the mirrors being slightly offset
1204         from each other.
1205         (sub lastModifiedToUnixTime): Added.
1206
1207 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
1208
1209         Windows build fix.
1210
1211         * DumpRenderTree/ForwardingHeaders/wtf/HashTraits.h: Added (needed by COMPtr.h).
1212
1213 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
1214
1215         Reviewed by Lars.
1216
1217         Moved QWebPage::open to QWebFrame::load and added setHtml.
1218
1219
1220         * DumpRenderTree/qt/DumpRenderTree.cpp:
1221         (WebCore::DumpRenderTree::open):
1222
1223 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
1224
1225         Reviewed by Lars.
1226
1227         Added the first revision of QWebView and started moving functionality from QWebPave over to QWebView and QWebFrame.
1228
1229
1230         * DumpRenderTree/qt/DumpRenderTree.cpp:
1231         (WebCore::DumpRenderTree::DumpRenderTree):
1232
1233 2008-01-02  Sam Weinig  <sam@webkit.org>
1234
1235         * Scripts/do-webcore-rename: Yet more renaming ideas.
1236
1237 2008-01-02  Darin Adler  <darin@apple.com>
1238
1239         * Scripts/do-webcore-rename: More renaming ideas. (Maciej, please merge yours with mine.)
1240
1241 2008-01-02  Alice Liu  <alice.liu@apple.com>
1242
1243         Reviewed by Sam Weinig.
1244
1245         fixing assertion hit with editing/selection/move-begin-end.html
1246
1247         * DumpRenderTree/ForwardingHeaders/wtf/ASCIICType.h: Added.
1248         * DumpRenderTree/win/DumpRenderTree.vcproj:
1249         * DumpRenderTree/win/EventSender.cpp:
1250         (keyDownCallback):
1251         using isupper will cause an assertion for inputs outside of ascii range. use isASCIIUpper instead.
1252
1253 2008-01-02  Darin Adler  <darin@apple.com>
1254
1255         * Scripts/do-webcore-rename: Some more name change plans.
1256
1257 2008-01-02  Alice Liu  <alice.liu@apple.com>
1258
1259         Reviewed by Maciej.
1260
1261         Added handling for page up and page down in EventSender
1262
1263         * DumpRenderTree/mac/EventSendingController.mm:
1264         (-[EventSendingController keyDown:withModifiers:]):
1265         * DumpRenderTree/win/EventSender.cpp:
1266         (keyDownCallback):
1267
1268 2008-01-02  Alexey Proskuryakov  <ap@webkit.org>
1269
1270         Reviewed by Darin.
1271
1272         Fix fast/events/arrow-keys-on-body.html for real.
1273
1274         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Pass proper keyData for WM_KEYUP, too.
1275
1276 2008-01-02  Luca Bruno  <lethalman88@gmail.com>
1277
1278         Reviewed by Darin.
1279
1280         http://bugs.webkit.org/show_bug.cgi?id=16674
1281         [GTK] run-launcher sets wrong LD_LIBRARY_PATH
1282
1283         * Scripts/run-launcher:
1284
1285 2007-12-31  Darin Adler  <darin@apple.com>
1286
1287         Suggested by Antti.
1288
1289         * Scripts/webkitdirs.pm: Turned off the QuickTime requirement for Windows until
1290         we get it installed on the build bots.
1291
1292 2007-12-30  Eric Seidel  <eric@webkit.org>
1293
1294         Reviewed by Sam.
1295
1296         * Scripts/do-webcore-rename: Add a few more planned renames s/(\w+)Imp/\1/
1297
1298 2007-12-29  Darin Adler  <darin@apple.com>
1299
1300         Reviewed by Oliver.
1301
1302         - fix http://bugs.webkit.org/show_bug.cgi?id=16663
1303           leak bot shows createCStringFromNPVariant result leaking
1304
1305         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1306         (pluginInvoke): Added a missing free.
1307
1308 2007-12-26  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
1309
1310         Reviewed by Alp Toker.
1311
1312         http://bugs.webkit.org/show_bug.cgi?id=16390
1313         Use autotools or GNU make as the build system for the GTK port
1314
1315         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: include glib.h
1316         * GNUmakefile.am: Added.
1317
1318 2007-12-24  Alexey Proskuryakov  <ap@webkit.org>
1319
1320         Reviewed by Oliver.
1321
1322         Fix fast/events/arrow-keys-on-body.html, failing on Windows.
1323
1324         * DumpRenderTree/win/EventSender.cpp:
1325         (keyDownCallback): Add KF_EXTENDED flag to arrow keys. Also add a count
1326         of 1, even though WebKit currently ignores it.
1327
1328 2007-12-23  Kevin Ollivier  <kevino@theolliviers.com>
1329
1330         wx buildbot fix. Update libpng dl script to the latest version.
1331
1332         * wx/install-unix-extras:
1333
1334 2007-12-22  Antti Koivisto  <antti@apple.com>
1335
1336         Fix a typo.
1337
1338         * Scripts/webkitdirs.pm:
1339
1340 2007-12-21  Sam Weinig  <sam@webkit.org>
1341
1342         Reviewed by Mark Rowe.
1343
1344         - Disable the back/forward cache using the new WebPreferences API
1345           instead of through the BackForwardList.  This makes us match what
1346           we do on Windows.
1347
1348         * DumpRenderTree/mac/DumpRenderTree.mm:
1349         (createWebViewAndOffscreenWindow):
1350         (setDefaultsToConsistentValuesForTesting):
1351
1352 2007-12-21  Dan Bernstein  <mitz@apple.com>
1353
1354         Reviewed by Mark Rowe.
1355
1356         - disable the back/forward cache in Windows DumpRenderTree. It is
1357           already disabled in Mac DumpRenderTree.
1358
1359         * DumpRenderTree/win/DumpRenderTree.cpp:
1360         (initializePreferences):
1361
1362 2007-12-13  Antti Koivisto  <antti@apple.com>
1363
1364         Reviewed by Darin and Steve.
1365
1366         - check for QuickTime SDK on Windows.
1367         - build media support on Windows by default
1368
1369         * Scripts/build-webkit:
1370         * Scripts/webkitdirs.pm:
1371
1372 2007-12-21  Kevin Ollivier  <kevino@theolliviers.com>
1373
1374         Build script fix for buildbot.
1375
1376         * wx/build-wxwebkit:
1377
1378 2007-12-20  Eric Seidel  <eric@webkit.org>
1379
1380         Reviewed by mjs.
1381
1382         * Scripts/run-sunspider: change --runs default to 10 for better accuracy
1383
1384 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
1385
1386         Reviewed by Steve.
1387
1388         - <rdar://5656485> Drosera: Win: Nightly does not reliably connect to
1389         WebKit.
1390
1391         - Drosera and Safari need to use the same ProgIDs in order for
1392         CoCreateInstance to work properly.  The most robust way to do this is
1393         for WebKit to dynamically publish those ProgIDs.
1394
1395         * Drosera/win/DebuggerClient.cpp: Use the published ProgIDs
1396         (DebuggerClient::createWebViewWithRequest):
1397         * Drosera/win/Drosera.cpp: Use the published ProgIDs and rename some
1398         statics.
1399         (Drosera::initUI):
1400         (Drosera::attach):
1401         (Drosera::attemptToCreateServerConnection):
1402         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Fix a runtime failure.
1403         * Drosera/win/ServerConnection.cpp: Reformat the connection function and
1404         make use of the published ProgIDs.
1405         (ServerConnection::attemptToCreateServerConnection):
1406
1407 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
1408
1409         - <rdar://problem/5658317> REGRESSION: 20+ leaks seen on buildbots.
1410         - Build bot and leak fix.
1411
1412         * DumpRenderTree/LayoutTestController.cpp:
1413         (pathToLocalResourceCallback):
1414
1415 2007-12-19  David Kilzer  <ddkilzer@apple.com>
1416
1417         Make svn-apply/svn-unapply work with patches from git-format-patch.
1418
1419         Reviewed by Darin.
1420
1421         * Scripts/svn-apply:
1422         (patch): If 'Index:' can't be found in the text passed in, print it
1423         out with a warning and return early.
1424         * Scripts/svn-unapply:
1425         (patch): Ditto.
1426
1427 2007-12-18  Kevin Ollivier  <kevino@theolliviers.com>
1428
1429         Reviewed by Alp Toker.
1430
1431         Build related fixes.
1432
1433         * wx/build-wxwebkit:
1434         - Check to make sure the user is running a supported wx port
1435         - More robust checks for Cygwin
1436         - Only run install-unix-extras on Mac, it's not the right solution
1437           for Linux distros.
1438         - Remove outdated Linux instructions after successful build
1439         - Clean Bakefile-generated files during a clean operation
1440
1441 2007-12-18  Darin Adler  <darin@apple.com>
1442
1443         * Scripts/make-js-test-wrappers: Don't generate a wrapper for select-options-remove.js.
1444
1445 2007-12-18  Steve Falkenburg  <sfalken@apple.com>
1446
1447         Add script to run Drosera as part of the nightly.
1448
1449         Reviewed by Kevin M.
1450
1451         * Scripts/run-drosera.cmd: Added.
1452
1453 2007-12-18  Darin Adler  <darin@apple.com>
1454
1455         * Scripts/do-webcore-rename: Remove a stray K.
1456
1457 2007-12-18  Darin Adler  <darin@apple.com>
1458
1459         * Scripts/do-webcore-rename: Plan more renaming.
1460
1461 2007-12-14  Juan A. Suarez Romero  <jasuarez@igalia.com>
1462
1463         Reviewed by Alp Toker.
1464
1465         http://bugs.webkit.org/show_bug.cgi?id=16042
1466         [GTK] Eliminate webkit_init()
1467
1468         Moving webkit initialization to WebView class init.
1469
1470         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1471         (main):
1472         * GtkLauncher/main.c:
1473         (main):
1474
1475 2007-12-17  Luca Bruno  <lethalman88@gmail.com>
1476
1477         Reviewed by Alp Toker.
1478
1479         http://bugs.webkit.org/show_bug.cgi?id=13542
1480         gdklauncher doesnt change URL in adress GTKEntry.
1481
1482         * GtkLauncher/main.c:
1483         (load_commit_cb): added
1484         (title_change_cb):
1485         (create_browser):
1486
1487 2007-12-16  Dimitri Glazkov  <dimitri@glazkov.com>
1488
1489         Reviewed by Adam Roben.
1490
1491         Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.
1492
1493         * FindSafari/FindSafari.cpp:
1494         (_tmain):
1495
1496 2007-12-16  Brent Fulgham  <bfulgham@gmail.com>
1497
1498         Reviewed by Adam Roben.
1499
1500         http://bugs.webkit.org/show_bug.cgi?id=16315
1501         FindSafari needs a path-only option.
1502
1503         * FindSafari/FindSafari.cpp:
1504         (_tmain):
1505
1506 2007-12-16  Alexey Proskuryakov  <ap@webkit.org>
1507
1508         Reviewed by Darin.
1509
1510         http://bugs.webkit.org/show_bug.cgi?id=16462
1511         REGRESSION: access keys broken on Windows
1512
1513         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Send system key events
1514         if Alt is pressed.
1515
1516 2007-12-15  Sam Weinig  <sam@webkit.org>
1517
1518         Reviewed by Mark Rowe.
1519
1520         Fix urlSuitableForTestResult to correctly identify wstring::npos as
1521         the case when wstring.find doesn't find anything.
1522
1523         * DumpRenderTree/win/DumpRenderTree.cpp:
1524         (urlSuitableForTestResult):
1525
1526 2007-12-15  Alp Toker  <alp@atoker.com>
1527
1528         GTK+ DRT build fix for GLib < 2.14.
1529
1530         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1531         (LayoutTestController::setWaitToDump):
1532
1533 2007-12-05  Mark Rowe  <mrowe@apple.com>
1534
1535         Reviewed by Alp Toker.
1536
1537         Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.  This prevents
1538         many layout tests from hanging while waiting on user responses to dialogs.
1539
1540         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1541         (invalidateAnyPreviousWaitToDumpWatchdog):
1542         (webViewScriptAlert):
1543         (webViewScriptPrompt):
1544         (webViewScriptConfirm):
1545         (main):
1546         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
1547         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1548         (waitToDumpWatchdogFired):
1549         (LayoutTestController::setWaitToDump):
1550
1551 2007-12-05  Mark Rowe  <mrowe@apple.com>
1552
1553         Reviewed by Alp Toker.
1554
1555         Flesh out DumpRenderTree for Gtk.  After these changes, the majority of the tests in fast/js pass.
1556
1557         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1558         (dumpFramesAsText): Don't print the frame name when dumping the main frame as text.
1559         (dump):
1560         (runTest):
1561         (webViewLoadStarted): Store the top frame when it starts loading so we can use it to determine when to dump.
1562         (webViewLoadFinished): Dump when the top frame load completes if we're not waiting for a JS callback and the
1563         work queue is empty.
1564         (webViewWindowObjectCleared): Set up window.layoutTestController.
1565         (webViewConsoleMessage): Match the console message format expected by the layout test results.
1566         (main): Hook up the new signals.
1567         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
1568         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Only notify done if the top frame has completed loading to avoid
1569         dumping multiple times.
1570         * Scripts/build-dumprendertree: Ensure build-dumprendertree is a no-op for Gtk too.
1571         * Scripts/run-webkit-tests: Teach run-webkit-tests that Gtk is like Qt in many ways.  Use run-launcher to open test results.
1572
1573 2007-12-14  Anders Carlsson  <andersca@apple.com>
1574
1575         Reviewed by Brady.
1576
1577         Assert that a web frame that's loading a resource always has either a data source or
1578         a provisional data source.
1579
1580         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1581         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1582
1583 2007-12-14  Darin Adler  <darin@apple.com>
1584
1585         - fix mistake causing nearly all tests to fail on Windows
1586
1587         * DumpRenderTree/win/UIDelegate.cpp:
1588         (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with
1589         npos, not 0. Also pass URL in to URL function rather than passing the entire message.
1590
1591         * DumpRenderTree/mac/UIDelegate.mm:
1592         (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather
1593         than passing the entire message.
1594
1595 2007-12-14  Darin Adler  <darin@apple.com>
1596
1597         - fix Tiger build
1598
1599         * DumpRenderTree/mac/UIDelegate.mm:
1600         (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any
1601         new-to-Leopard methods.
1602
1603 2007-12-14  Darin Adler  <darin@apple.com>
1604
1605         * DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method
1606         since it now triggers unwanted icon loading. We only had it because we implemented "all"
1607         delegate methods here.
1608
1609 2007-12-14  Anders Carlsson  <andersca@apple.com>
1610
1611         Reviewed by Darin and Geoff.
1612
1613         <rdar://problem/5619295>
1614         REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
1615
1616         Add property getting methods to the plug-in.
1617
1618         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1619         (pluginInvoke):
1620
1621 2007-12-14  Kevin McCullough  <kmccullough@apple.com>
1622
1623         Reviewed by Darin.
1624
1625         - Layout test fix for mac. When dumped to the console local file paths
1626         now only show the name of the resource not the whole path.  This is to
1627         make the results machine and OS independent.
1628
1629         * DumpRenderTree/mac/UIDelegate.mm:
1630         (-[UIDelegate webView:addMessageToConsole:]):
1631
1632 2007-12-13  Kevin McCullough  <kmccullough@apple.com>
1633
1634         Reviewed by Adam.
1635
1636         - Layout tests fix.  We need a way to remove machine-dependent
1637         information from paths in layout test results. The UIDelegate now does
1638         this.
1639
1640         * DumpRenderTree/DumpRenderTree.h:
1641         * DumpRenderTree/win/DumpRenderTree.cpp:
1642         (urlSuitableForTestResult):
1643         * DumpRenderTree/win/DumpRenderTreeWin.h:
1644         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1645         * DumpRenderTree/win/UIDelegate.cpp:
1646         (UIDelegate::webViewAddMessageToConsole):
1647
1648 2007-12-13  Alp Toker  <alp@atoker.com>
1649
1650         Build fix for DRT breakage introduced in r28690.
1651
1652         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1653         (LayoutTestController::pathToLocalResource):
1654
1655 2007-12-12  Kevin McCullough  <kmccullough@apple.com>
1656
1657         Reviewed by Alice and Sam.
1658
1659         - <rdar://5621435> Need a way to specify local resources (being loaded
1660         from HTTP tests) on Windows.
1661         - Implemented pathToLocalResource which exposes the functionality of
1662         converting a given unix path to the correct location on Windows.
1663
1664         * DumpRenderTree/LayoutTestController.cpp:
1665         (pathToLocalResourceCallback):
1666         (LayoutTestController::staticFunctions):
1667         * DumpRenderTree/LayoutTestController.h:
1668         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1669         (LayoutTestController::pathToLocalResource):
1670         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1671         (LayoutTestController::pathToLocalResource):
1672
1673 2007-12-12  Anders Carlsson  <andersca@apple.com>
1674
1675         Reviewed by Sam.
1676
1677         <rdar://problem/5132003>
1678         dumpResourceLoadCallbacks is not implemented in DRT on Windows.
1679
1680         * DumpRenderTree/win/DumpRenderTree.cpp:
1681         (main):
1682         Set the resource load delegate.
1683
1684         * DumpRenderTree/win/DumpRenderTree.vcproj:
1685
1686         * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
1687         * DumpRenderTree/win/ResourceLoadDelegate.h: Added.
1688
1689 2007-12-12  Alexey Proskuryakov  <ap@webkit.org>
1690
1691         Reviewed by Adam Roben.
1692
1693         Fix conversion from double to LPARAM in dispatchMessage().
1694
1695         * DumpRenderTree/win/EventSender.cpp:
1696         (dispatchMessageCallback):
1697
1698 2007-12-11  Dan Bernstein  <mitz@apple.com>
1699
1700         Reviewed by Mark Rowe and Sam Weinig too!
1701
1702         - added Helvetica Oblique and Helvetica Bold Oblique to the list of
1703           fonts DumpRenderTree registers.
1704
1705         * DumpRenderTree/win/DumpRenderTree.cpp:
1706         (initialize):
1707
1708 2007-12-11  Brady Eidson  <beidson@apple.com>
1709
1710         Reviewed by Anders
1711
1712         Make DumpRenderTree on mac use its own path for Databases testing
1713
1714         * DumpRenderTree/mac/DumpRenderTree.mm:
1715         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree
1716           for future DRT-only use, then use it to construct the Databases path and set that default
1717
1718 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
1719
1720         Reviewed by Darin.
1721
1722         <rdar://problem/5535636>
1723         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
1724
1725         http://bugs.webkit.org/show_bug.cgi?id=13916
1726         JavaScript detects Tab as a character input on a textfield validation
1727
1728         * DumpRenderTree/mac/EventSendingController.mm:
1729         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
1730         Dispatch a keyup to better match what happens when a key is physically pressed.
1731
1732         * DumpRenderTree/win/EventSender.cpp:
1733         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
1734         returning from keyDown().
1735         (getConstantCallback): Fixed a couple copy/paste mistakes.
1736
1737 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
1738
1739         Reviewed by Oliver.
1740
1741         - <rdar://5599845> Drosera: Does not show loal files in the file list
1742         on the left side.
1743
1744         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
1745         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
1746         so the open source community can build.
1747
1748 2007-12-10  Brady Eidson  <beidson@apple.com>
1749
1750         Rubberstamped by Sam Weinig
1751
1752         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
1753
1754         * DumpRenderTree/mac/UIDelegate.mm:
1755         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
1756         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
1757
1758 2007-12-08  Oliver Hunt  <oliver@apple.com>
1759
1760         Reviewed by Sam W.
1761
1762         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
1763
1764         Fixes <rdar://problem/5620249> Must disable SVG animation
1765         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
1766
1767         In order to allow finer grained control over the set of SVG features
1768         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
1769         distinct flags:
1770         ENABLE_SVG_ANIMATION
1771         ENABLE_SVG_FILTERS
1772         ENABLE_SVG_FONTS
1773         ENABLE_SVG_AS_IMAGE
1774         ENABLE_SVG_USE
1775
1776         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
1777
1778         Script handles all the new build flags, and allows --svg-experimental
1779         to automatically enable all features.
1780
1781         * Scripts/build-webkit:
1782
1783 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
1784
1785         Fix version parsing.
1786
1787         Rubber-stamped by Oliver.
1788
1789         * Drosera/win/Drosera.vcproj/auto-version.sh:
1790
1791 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
1792
1793         Build modifications for Drosera.
1794
1795         Reviewed by Adam.
1796
1797         * Drosera/DroseraWin.make: Added.
1798         * Drosera/win/Drosera.vcproj/Drosera.rc:
1799         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1800         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
1801         * Drosera/win/Drosera.vcproj/VERSION: Added.
1802         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
1803
1804 2007-12-06  Adam Roben  <aroben@apple.com>
1805
1806         Explicitly turn on the Mac font ascent hack on Windows
1807
1808         This keeps our font metrics matching those from Mac.
1809
1810         Reviewed by Hyatt.
1811
1812         * DumpRenderTree/win/DumpRenderTree.cpp:
1813         (main):
1814
1815 2007-12-06  Anders Carlsson  <andersca@apple.com>
1816
1817         Rename main.c to main.cpp here too.
1818
1819         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
1820
1821 2007-12-06  Sam Weinig  <sam@webkit.org>
1822
1823         Rubber stamped by Geoff.
1824
1825         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
1826
1827 2007-12-06  Darin Adler  <darin@apple.com>
1828
1829         * Scripts/do-webcore-rename: Some more renaming plans.
1830
1831 2007-12-06  Anders Carlsson  <andersca@apple.com>
1832
1833         Restore implementation of testGetIntIdentifier that was accidentally
1834         removed somehow (possibly when I made PluginObject be a cpp file).
1835
1836         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1837         (pluginInvoke):
1838
1839 2007-12-05  Anders Carlsson  <andersca@apple.com>
1840
1841         Make the entry points extern "C".
1842         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1843
1844 2007-12-05  Anders Carlsson  <andersca@apple.com>
1845
1846         C++ warning fixes.
1847
1848         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1849         (NPP_New):
1850         (NPP_Destroy):
1851         (NPP_SetWindow):
1852         (NPP_NewStream):
1853         (NPP_HandleEvent):
1854         (NPP_URLNotify):
1855         (NPP_GetValue):
1856
1857 2007-12-05  Anders Carlsson  <andersca@apple.com>
1858
1859         Add the .cpp files to the TestNetscapePlugIn target.
1860
1861         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1862
1863 2007-12-05  Anders Carlsson  <andersca@apple.com>
1864
1865         Reviewed by Geoff.
1866
1867         Rename the TestNetscapePlugIn .c files to be .cpp.
1868
1869         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1870         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
1871         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
1872         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
1873         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
1874         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
1875         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
1876         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1877
1878 2007-12-05  Adam Roben  <aroben@apple.com>
1879
1880         Fix case of keypresses from the Windows implementation of eventSender.keyDown
1881
1882         This fixes several regression tests.
1883
1884         Reviewed by Alice.
1885
1886         * DumpRenderTree/win/EventSender.cpp:
1887         (keyDownCallback): Virtual keycodes for ASCII characters are always
1888         uppercase, so we need to check the case of the original character
1889         passed in to eventSender.keyDown.
1890
1891 2007-12-05  Adam Roben  <aroben@apple.com>
1892
1893         Learn from Tim's mistakes
1894
1895         * DumpRenderTree/win/DumpRenderTree.cpp:
1896         (runTest): Reset the authorAndUserStylesEnabled preference for each
1897         test.
1898
1899 2007-12-05  Alp Toker  <alp@atoker.com>
1900
1901         Reviewed by Mark Rowe.
1902
1903         Initialize GTK+ and WebKit so the tests can run.
1904
1905         Reorganize the headers a little.
1906
1907         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1908         (main):
1909
1910 2007-12-04  Anders Carlsson  <andersca@apple.com>
1911
1912         Remove IWebScriptScope include.
1913
1914         * Drosera/win/DebuggerDocumentPlatform.cpp:
1915
1916 2007-12-04  Sam Weinig  <sam@webkit.org>
1917
1918         Rubber stamped by Mark Rowe.
1919
1920         Define CF as platform for mac and revert r28409
1921
1922         * DumpRenderTree/DumpRenderTree.h:
1923         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1924
1925 2007-12-04  Sam Weinig  <sam@webkit.org>
1926
1927         Define CF as platform for windows.
1928
1929         Reviewed by Adam Roben.
1930
1931         * DumpRenderTree/win/DumpRenderTreeWin.h:
1932
1933 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
1934
1935         Reviewed by Adam and Darin.
1936
1937         - Removed a needless BSTR cleanup.
1938
1939         * Drosera/win/DebuggerDocumentPlatform.cpp:
1940         (DebuggerDocument::getPlatformCurrentFunctionStack):
1941
1942 2007-11-27  Adam Roben  <aroben@apple.com>
1943
1944         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
1945
1946         Reviewed by Maciej.
1947
1948         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1949         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
1950
1951 2007-12-04  Alp Toker  <alp@atoker.com>
1952
1953         Prospective Win DRT build fix.
1954
1955         * DumpRenderTree/DumpRenderTree.h:
1956
1957 2007-12-04  Alp Toker  <alp@atoker.com>
1958
1959         Fix a clobbered copyright header.
1960
1961         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1962
1963 2007-12-04  Xan Lopez  <xan@gnome.org>
1964
1965         Reviewed by Alp Toker.
1966
1967         http://bugs.webkit.org/show_bug.cgi?id=15561
1968         GTK port needs DumpRenderTree implementation
1969
1970         Start work on the GTK+ DRT.
1971
1972         This does not work yet, and there are a few lingering style issues
1973         (nothing major) but this patch has been stuck in the bug tracker for
1974         too long already.
1975
1976         * DumpRenderTree/DumpRenderTree.h:
1977         * DumpRenderTree/gtk: Added.
1978         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
1979         (autocorrectURL):
1980         (shouldLogFrameLoadDelegates):
1981         (dumpFrameScrollPosition):
1982         (displayWebView):
1983         (appendString):
1984         (dumpFramesAsText):
1985         (dumpRenderTreeAsText):
1986         (dump):
1987         (runTest):
1988         (main):
1989         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
1990         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
1991         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
1992         (GCController::collect):
1993         (GCController::collectOnAlternateThread):
1994         (GCController::getJSObjectCount):
1995         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
1996         (LayoutTestController::~LayoutTestController):
1997         (LayoutTestController::addDisallowedURL):
1998         (LayoutTestController::clearBackForwardList):
1999         (LayoutTestController::copyDecodedHostName):
2000         (LayoutTestController::copyEncodedHostName):
2001         (LayoutTestController::display):
2002         (LayoutTestController::keepWebHistory):
2003         (LayoutTestController::notifyDone):
2004         (LayoutTestController::queueBackNavigation):
2005         (LayoutTestController::queueForwardNavigation):
2006         (LayoutTestController::queueLoad):
2007         (LayoutTestController::queueReload):
2008         (LayoutTestController::queueScript):
2009         (LayoutTestController::setAcceptsEditing):
2010         (LayoutTestController::setCustomPolicyDelegate):
2011         (LayoutTestController::setMainFrameIsFirstResponder):
2012         (LayoutTestController::setTabKeyCyclesThroughElements):
2013         (LayoutTestController::setUseDashboardCompatibilityMode):
2014         (LayoutTestController::setUserStyleSheetEnabled):
2015         (LayoutTestController::setUserStyleSheetLocation):
2016         (LayoutTestController::setWindowIsKey):
2017         (LayoutTestController::setWaitToDump):
2018         (LayoutTestController::windowCount):
2019         (LayoutTestController::setPrivateBrowsingEnabled):
2020         (LayoutTestController::setAuthorAndUserStylesEnabled):
2021         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
2022         (JSStringCopyUTF8CString):
2023         (LoadItem::invoke):
2024         (ReloadItem::invoke):
2025         (ScriptItem::invoke):
2026         (BackForwardItem::invoke):
2027
2028 2007-12-03  Sam Weinig  <sam@webkit.org>
2029
2030         Move JavaScriptCore thread testing code to pthread specific directory
2031         and remove the dependance on CoreFoundation by using WTF::HashSet.
2032
2033         Reviewed by Geoff and Oliver.
2034
2035         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2036         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
2037         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
2038         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
2039         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
2040         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
2041         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
2042         * DumpRenderTree/pthreads: Added.
2043         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
2044         (javaScriptThreads):
2045         (runJavaScriptThread):
2046         (startJavaScriptThreads):
2047         (stopJavaScriptThreads):
2048
2049 2007-12-03  Andrew Bonventre  <andybons@google.com>
2050
2051         Reviewed by Darin Adler.
2052
2053         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
2054         Symbol lookup menu broken in debugger view
2055
2056         * Drosera/debugger.js: Fixed javascript error where document property
2057         should have been used instead of contentDocument in switchFunction that
2058         was breaking the select symbol dropdown menu.  This is because
2059         window.frames will return a Window object and not a frame object like
2060         the author was originally expecting.
2061
2062 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
2063
2064         Reviewed by Adam.
2065
2066         - <rdar://5618942> Drosera: Console window does not process everything
2067         correctly.
2068         - <rdar://5619005> Drosera: could be sped up by moving the
2069         WebScriptScope stuff into the WebScriptCallFrame.
2070         - Now the console can correctly process objects and does not receive
2071         notifications from JavaScriptCore about the JavaScript in Drosera's
2072         own process.
2073
2074         * Drosera/win/DebuggerDocumentPlatform.cpp:
2075         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2076         (DebuggerDocument::platformValueForScopeVariableNamed):
2077
2078 2007-12-03  Stephanie  <slewis@apple.com>
2079
2080         Reviewed by Darin.
2081
2082         Check to see if we are building a debug root
2083
2084         * Scripts/check-for-global-initializers:
2085
2086 2007-12-03  Dan Bernstein  <mitz@apple.com>
2087
2088         Reviewed by Darin Adler.
2089
2090         - added a testGetIntIdentifier() method to TestNetscapePlugIn
2091
2092         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
2093         (pluginInvoke):
2094
2095 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
2096
2097         Reviewed by Oliver.
2098
2099         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
2100         in a more fine-grained manner than eventSender.keyDown().
2101
2102         * DumpRenderTree/win/EventSender.cpp:
2103         (getConstantCallback):
2104         (dispatchMessageCallback):
2105
2106 2007-12-02  Darin Adler  <darin@apple.com>
2107
2108         * Scripts/do-webcore-rename: More planned renaming.
2109
2110 2007-12-02  Sam Weinig  <sam@webkit.org>
2111
2112         Rubber stamped by Anders.
2113
2114         Use [NSURL absoluteString] instead of [NSURL description] in order to get
2115         more uniform results cross platform.
2116
2117         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2118         (-[NSURL _drt_descriptionSuitableForTestResult]):
2119
2120 2007-12-02  Sam Weinig  <sam@webkit.org>
2121
2122         Rubber stamped by Niko.
2123
2124         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
2125
2126         * DumpRenderTree/win/DumpRenderTree.cpp:
2127         * DumpRenderTree/win/DumpRenderTree.vcproj:
2128         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
2129         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
2130         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
2131         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
2132
2133 2007-12-01  Alp Toker  <alp@atoker.com>
2134
2135         Reviewed by Adam Roben.
2136
2137         Make use of the newly introduced webkit.h convenience header.
2138
2139         * GtkLauncher/main.c:
2140
2141 2007-12-01  Adam Treat  <treat@kde.org>
2142
2143         Reviewed by Simon.
2144
2145         * Check to see if the directory exists and exit if not.
2146
2147         * DumpRenderTree/qt/main.cpp:
2148         (main):
2149
2150 2007-12-01  Adam Treat  <treat@kde.org>
2151
2152         Reviewed by Simon.
2153
2154         * Don't hide symbols when in Debug mode
2155         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
2156
2157
2158         * DumpRenderTree/qt/main.cpp:
2159         (messageHandler):
2160
2161 2007-11-30  Alp Toker  <alp@atoker.com>
2162
2163         Reviewed by Adam Roben.
2164
2165         http://bugs.webkit.org/show_bug.cgi?id=15691
2166         [GTK] Public API does not follow GTK+ conventions
2167
2168         Refactor the WebKit/GTK+ public API. Changes:
2169           WebKitPage -> WebKitWebView
2170           WebKitFrame -> WebKitWebFrame
2171
2172         Public API source and header names have been updated to mirror the API
2173         changes.
2174
2175         The API is now kept in WebKit/gtk/WebView to match other ports in the
2176         same class such as Mac and Win.
2177
2178         * GtkLauncher/main.c:
2179         (activate_uri_entry_cb):
2180         (link_hover_cb):
2181         (title_change_cb):
2182         (progress_change_cb):
2183         (go_back_cb):
2184         (go_forward_cb):
2185         (create_browser):
2186         (main):
2187
2188 2007-11-30  Adam Roben  <aroben@apple.com>
2189
2190         Hopefully the final build fix
2191
2192         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
2193         pull in WTF's assertion/logging functions.
2194
2195 2007-11-30  Adam Roben  <aroben@apple.com>
2196
2197         Another build fix
2198
2199         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
2200         WebKit.lib.
2201
2202 2007-11-30  Adam Roben  <aroben@apple.com>
2203
2204         Debug build fix
2205
2206         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
2207         configuration.
2208         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
2209         projects.
2210         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
2211         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
2212         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
2213
2214 2007-11-30  Sam Weinig  <sam@webkit.org>
2215
2216         Reviewed by Adam Roben.
2217
2218         Fix drawSelectionRect to actually draw the selection rect.
2219
2220         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2221         (drawSelectionRect):
2222
2223 2007-11-30  Darin Adler  <darin@apple.com>
2224
2225         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
2226
2227 2007-11-30  Darin Adler  <darin@apple.com>
2228
2229         * Scripts/do-webcore-rename: Get ready for some future renaming.
2230
2231 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
2232
2233         Reviewed by Adam.
2234
2235         - Removed some unnecessary functions and changed an unused return type.
2236
2237         * Drosera/win/DebuggerClient.cpp:
2238         (registerConsoleClass):
2239         * Drosera/win/DebuggerClient.h:
2240         * Drosera/win/Drosera.cpp:
2241         (registerDroseraClass):
2242
2243 2007-11-28  Alp Toker  <alp@atoker.com>
2244
2245         Reviewed by Timothy Hatcher.
2246
2247         http://bugs.webkit.org/show_bug.cgi?id=16174
2248         [GTK] Use "URI" not "URL" in public API
2249
2250         Replace use of the term "URL" with "URI" in public headers,
2251         documentation and some internal code to match GLib/GTK+ convention.
2252
2253         This is now mentioned in the API guidelines:
2254           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
2255
2256         * GtkLauncher/main.c:
2257         (activate_uri_entry_cb):
2258         (title_change_cb):
2259         (create_toolbar):
2260         (main):
2261
2262 2007-11-29  Anders Carlsson  <andersca@apple.com>
2263
2264         Reviewed by Sam.
2265
2266         <rdar://problem/5230478>
2267         FrameLoadDelegate callbacks are not dumped in DRT.
2268
2269         * DumpRenderTree/win/DumpRenderTree.cpp:
2270         (shouldLogFrameLoadDelegates):
2271         (runTest):
2272         (main):
2273         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
2274         (BSTRtoString):
2275         (descriptionSuitableForTestResult):
2276         (FrameLoadDelegate::QueryInterface):
2277         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
2278         (FrameLoadDelegate::didFailProvisionalLoadWithError):
2279         (FrameLoadDelegate::didCommitLoadForFrame):
2280         (FrameLoadDelegate::didFinishLoadForFrame):
2281         (FrameLoadDelegate::willCloseFrame):
2282         (FrameLoadDelegate::didClearWindowObject):
2283         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
2284         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
2285         * DumpRenderTree/win/FrameLoaderDelegate.h:
2286         (FrameLoadDelegate::windowScriptObjectAvailable):
2287         (FrameLoadDelegate::didFirstLayoutInFrame):
2288
2289 2007-11-29  Sam Weinig  <sam@webkit.org>
2290
2291         Reviewed by Anders.
2292
2293         Add database quota UIDelegates methods to DRT UIDelegate.
2294
2295         * DumpRenderTree/mac/UIDelegate.mm:
2296         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
2297         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
2298
2299 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
2300
2301         Reviewed by Sam.
2302
2303         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
2304         dying and vice versa.
2305         - This fix will allow Drosera and Safari to reconnect if either of them
2306         closes correctly, but does not fix the case where one of them dies
2307         silently.
2308
2309         * Drosera/win/ServerConnection.cpp:
2310         (ServerConnection::attemptToCreateServerConnection): Added a safety
2311         check, because it's possilbe to try to connect to a server that's dying.
2312         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
2313         the server has died.
2314         * Drosera/win/ServerConnection.h: Added the new function and removed
2315         an unnecessary member.
2316
2317 2007-11-29  Anders Carlsson  <andersca@apple.com>
2318
2319         * DumpRenderTree/win/DumpRenderTree.vcproj:
2320         Add shlwapi.lib to all configurations.
2321
2322 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
2323
2324         - Build fix.  Added additional includes for VS Express to the Release
2325         project.
2326
2327         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2328
2329 2007-11-29  Anders Carlsson  <andersca@apple.com>
2330
2331         Reviewed by Adam.
2332
2333         <rdar://problem/5132005>
2334         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
2335
2336         * DumpRenderTree/win/DumpRenderTree.vcproj:
2337         Add shlwapi.lib
2338
2339         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2340         (LayoutTestController::setUserStyleSheetEnabled):
2341         Implement this.
2342
2343         (appendComponentToPath):
2344         New method which wraps the Win32 API PathAppend.
2345
2346         (followShortcuts):
2347         New method which checks if a file points to a shortcut and
2348         follows the shortcut.
2349
2350         (resolveCygwinPath):
2351         New method that takes a cygwin unix-style path and returns the Win32 path.
2352
2353         (cfStringRefToWString):
2354
2355         (LayoutTestController::setUserStyleSheetLocation):
2356         Implement this.
2357
2358 2007-11-29  Alice Liu  <alice.liu@apple.com>
2359
2360         Reviewed by Adam.
2361
2362         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
2363
2364         * DumpRenderTree/win/EventSender.cpp:
2365         (keyDownCallback):
2366         uppercase letters were being sent as lowercase letters without the shift key down.
2367
2368 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
2369
2370         - Windows build fix. VS express needs some love.
2371
2372         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2373
2374 2007-11-28  Darin Adler  <darin@apple.com>
2375
2376         Reviewed by Adam Roben.
2377
2378         * DumpRenderTree/mac/EventSendingController.mm:
2379         (-[EventSendingController keyDown:withModifiers:]):
2380         Send capital letters through as lowercase letters with the shift key down
2381         rather than sending them as if they were highly unusual "capital letter keys".
2382
2383         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
2384         where you need to update results and more tests are failing than before.
2385
2386 2007-11-28  Anders Carlsson  <andersca@apple.com>
2387
2388         Reviewed by Darin.
2389
2390         <rdar://problem/5132001>
2391         contextClick is not implemented in DRT on Windows.
2392
2393         * DumpRenderTree/win/EventSender.cpp:
2394         (contextClickCallback):
2395         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
2396         by a WM_RBUTTONUP message.
2397
2398         * DumpRenderTree/win/UIDelegate.cpp:
2399         (UIDelegate::hasCustomMenuImplementation):
2400         (UIDelegate::trackCustomPopupMenu):
2401         * DumpRenderTree/win/UIDelegate.h:
2402         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
2403         menu from being shown (and causing the DRT to hang).
2404
2405 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
2406
2407         Reviewed by Darin.
2408
2409         Fix DumpRenderTree ObjC bug comparing strings.
2410
2411         * DumpRenderTree/mac/ObjCController.m:
2412         (-[ObjCController identityIsEqual::]): Compare strings with string
2413         equality instead of identiy equality.
2414
2415 2007-11-27  Timothy Hatcher  <timothy@apple.com>
2416
2417         Reviewed by Sam.
2418
2419         Reset the authorAndUserStylesEnabled preference
2420         back to YES for each test. Fixes the broken tests.
2421
2422         * DumpRenderTree/mac/DumpRenderTree.mm:
2423         (resetWebViewToConsistentStateBeforeTesting):
2424
2425 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
2426
2427         Reviewed by Adam.
2428
2429         - Drosera now displays the console window, although it cannot currently
2430         process JavaScript.
2431
2432         * Drosera/win/DebuggerClient.cpp: Shows the console window.
2433         (registerConsoleClass): Implemented.
2434         (consoleWndProc): Implemented.
2435         (DebuggerClient::onSize): Implemented.
2436         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
2437         new window.
2438         * Drosera/win/DebuggerClient.h: Added needed method and members for
2439         creating and maintaining a new window.
2440         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
2441         lines of code to more appropriate places.
2442         (Drosera::handleCommand):
2443         (Drosera::initUI):
2444         (Drosera::onSize):
2445         (Drosera::attach):
2446
2447 2007-11-27  Timothy Hatcher  <timothy@apple.com>
2448
2449         Reviewed by Dave Hyatt.
2450
2451         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
2452
2453         Add support for disabling author and user styles for testing.
2454
2455         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2456         * DumpRenderTree/LayoutTestController.cpp:
2457         (setAuthorAndUserStylesEnabledCallback):
2458         (LayoutTestController::staticFunctions):
2459         * DumpRenderTree/LayoutTestController.h:
2460         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2461         (LayoutTestController::setAuthorAndUserStylesEnabled):
2462         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2463         (LayoutTestController::setAuthorAndUserStylesEnabled):
2464
2465 2007-11-26  Dan Bernstein  <mitz@apple.com>
2466
2467         - Tiger build fix.
2468
2469         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2470
2471 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
2472
2473         Reviewed by Maciej.
2474
2475         - Implemented displaying variables for Drosera on Win.
2476
2477         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
2478         that retrieve variables to not hold onto the return value since it's
2479         not returned.  Also changed to use the new signatures of the retrieval
2480         functions.
2481         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2482         (DebuggerDocument::platformValueForScopeVariableNamed):
2483         * Drosera/win/Drosera.cpp: Removed a needless TODO.
2484         (droseraWndProc):
2485
2486 2007-11-26  Sam Weinig  <sam@webkit.org>
2487
2488         Cleanup names of painting and repainting functions.
2489
2490         Reviewed by Adam Roben.
2491
2492         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2493         (drawSelectionRect): was drawSelectionRectIntoContext.
2494         (dumpWebViewAsPixelsAndCompareWithExpected):
2495         * DumpRenderTree/cg/PixelDumpSupportCG.h:
2496         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2497         (paintWebView): was drawWebViewIntoContext.
2498         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
2499
2500 2007-11-26  Sam Weinig  <sam@webkit.org>
2501
2502         Reviewed by Dan Bernstein.
2503
2504         - Leopard build fix
2505
2506         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2507
2508 2007-11-26  Sam Weinig  <sam@webkit.org>
2509
2510         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
2511         Use shared PixelDumpSupport for Mac DRT
2512
2513         Reviewed by Adam Roben.
2514
2515         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2516         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
2517         * DumpRenderTree/cg/ImageDiffCG.cpp:
2518         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2519         (drawSelectionRectIntoContext):
2520         (dumpWebViewAsPixelsAndCompareWithExpected):
2521         * DumpRenderTree/cg/PixelDumpSupportCG.h:
2522         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2523         * DumpRenderTree/mac/DumpRenderTree.mm:
2524         (dump):
2525         * DumpRenderTree/mac/ImageDiff.m: Removed.
2526         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
2527         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
2528         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
2529         (setDefaultColorProfileToRGB):
2530         (getBitmapContextFromWebView):
2531         (drawWebViewIntoContext):
2532         (repaintWithVerticalSweep):
2533         (repaintWithHorizontalSweep):
2534         (getSelectionRect):
2535         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
2536
2537 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
2538
2539         Bug 16052: prepare-ChangeLog doesn't report deleted files
2540         <http://bugs.webkit.org/show_bug.cgi?id=16052>
2541
2542         Reviewed by Sam.
2543
2544         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
2545
2546 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
2547
2548         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
2549         <http://bugs.webkit.org/show_bug.cgi?id=15864>
2550
2551         Reviewed by Adam.
2552
2553         Roll functionality of merge-changelog into resolve-ChangeLogs
2554         script.  The script now checks for ChangeLog.rej and
2555         ChangeLog.orig files first.  If it finds them, it uses the
2556         ChangeLog.rej file as a patch (in old contextual diff format) to
2557         apply with --fuzz=3.
2558
2559         * Scripts/merge-changelog: Removed.
2560         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
2561
2562 2007-11-25  Sam Weinig  <sam@webkit.org>
2563
2564         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
2565
2566         Reviewed by Mark Rowe.
2567
2568         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2569         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2570         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2571         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
2572         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
2573
2574 2007-11-25  Sam Weinig  <sam@webkit.org>
2575
2576         Convert DumpRenderTree to ues .xcconfig files.
2577
2578         Reviewed by Mark Rowe.
2579
2580         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2581         * DumpRenderTree/mac/Configurations: Added.
2582         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
2583         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
2584         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
2585
2586 2007-11-25  Sam Weinig  <sam@webkit.org>
2587
2588         Add ForwardingHeaders to wtf for DumpRenderTree.
2589
2590         Reviewed by Mark Rowe.
2591
2592         * DumpRenderTree/DumpRenderTree.h:
2593         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2594         * DumpRenderTree/ForwardingHeaders: Added.
2595         * DumpRenderTree/ForwardingHeaders/wtf: Added.
2596         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
2597         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
2598         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
2599         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
2600         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
2601         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
2602         * DumpRenderTree/LayoutTestController.cpp:
2603         * DumpRenderTree/WorkQueue.cpp:
2604         * DumpRenderTree/mac/DumpRenderTree.mm:
2605         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2606         * DumpRenderTree/mac/JavaScriptThreading.cpp:
2607         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2608         * DumpRenderTree/mac/ObjCController.m:
2609         * DumpRenderTree/mac/UIDelegate.mm:
2610         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2611
2612 2007-11-25  Adam Roben  <aroben@apple.com>
2613
2614         Fix some test failures caused by r28019
2615
2616         Now that stdout is in binary mode, we need to always use printf
2617         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
2618         the output.
2619
2620         Reviewed by Sam.
2621
2622         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
2623         printf.
2624         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2625         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2626         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2627         (UIDelegate::webViewAddMessageToConsole):
2628
2629 2007-11-25  Adam Roben  <aroben@apple.com>
2630
2631         Set the font smoothing preference in DRT
2632
2633         This makes the pixel results on Windows closer to the Mac results.
2634
2635         Reviewed by Mitz.
2636
2637         * DumpRenderTree/win/DumpRenderTree.cpp:
2638         (initializePreferences):
2639
2640 2007-11-25  Adam Roben  <aroben@apple.com>
2641
2642         Port ImageDiff to CG and C++
2643
2644         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
2645         <rdar://5071708>
2646
2647         Reviewed by Sam.
2648
2649         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
2650         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
2651         (main):
2652         (createImageFromStdin):
2653         (compareImages):
2654         (getDifferenceBitmap):
2655         (computePercentageDifferent):
2656         * DumpRenderTree/win/ImageDiff.vcproj: Added.
2657
2658 2007-11-25  Adam Roben  <aroben@apple.com>
2659
2660         Fix image diff link generation on Windows
2661
2662         Reviewed by Sam.
2663
2664         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
2665         to toURL.
2666
2667 2007-11-25  Adam Roben  <aroben@apple.com>
2668
2669         Implement pixel dumping in Windows DRT
2670
2671         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
2672         <rdar://5071708>
2673
2674         Reviewed by Sam.
2675
2676         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
2677         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
2678         Content-Length header.
2679         (getMD5HashStringForBitmap):
2680         (dumpWebViewAsPixelsAndCompareWithExpected):
2681         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
2682         * DumpRenderTree/win/DumpRenderTree.cpp:
2683         (dump): Do a pixel dump if requested.
2684         (main): Parse pixel test options.
2685         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
2686         the cg/ subdirectory to the include path.
2687         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
2688         available in a header or import library, so we have to go through this
2689         LoadLibrary/GetProcAddress dance to use them.
2690         (cryptDLL):
2691         (init):
2692         (update):
2693         (final):
2694         (MD5_Init):
2695         (MD5_Update):
2696         (MD5_Final):
2697         * DumpRenderTree/win/MD5.h: Added.
2698         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
2699         moved up to the top level to share it with Mac eventually.
2700         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
2701         (getBitmapContextFromWebView): Forces the WebView to paint using a
2702         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
2703
2704 2007-11-25  Adam Roben  <aroben@apple.com>
2705
2706         Clean up Windows DRT's option parsing a little bit
2707
2708         Reviewed by Sam.
2709
2710         * DumpRenderTree/win/DumpRenderTree.cpp:
2711         (main): Put non-option arguments into a Vector.
2712
2713 2007-11-25  Adam Roben  <aroben@apple.com>
2714
2715         Make Windows DRT stop changing LF into CRLF
2716
2717         Reviewed by Sam.
2718
2719         * DumpRenderTree/win/DumpRenderTree.cpp:
2720         (main): Put stdout in binary mode.
2721         * Scripts/run-webkit-tests: Remove the CRLF hack.
2722
2723 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
2724
2725         Removed empty directory.
2726
2727         * Scripts/resources: Removed.
2728
2729 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
2730
2731         Fix bisect-builds to work with recent WebKit nightly builds.
2732
2733         Reviewed by Dan.
2734
2735         * Scripts/bisect-builds: Check for the
2736         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
2737         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
2738         to WebKit.app/Contents/Resources.
2739
2740 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
2741
2742         Reviewed by Maciej.
2743
2744         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
2745         not closed (affects digg.com)
2746
2747         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
2748         one after finishing with a test to avoid having its delayed onload handler firing when
2749         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
2750         but it helps somewhat.
2751
2752 2007-11-22  Mark Rowe  <mrowe@apple.com>
2753
2754         Reviewed by Alp Toker.
2755
2756         Fix build-webkit to propagate make's exit status if it fails.
2757
2758         * Scripts/webkitdirs.pm:
2759
2760 2007-11-22  Dan Bernstein  <mitz@apple.com>
2761
2762         Reviewed by Mark Rowe.
2763
2764         - fix crash when running pixel tests
2765
2766         * DumpRenderTree/mac/DumpRenderTree.mm:
2767         (dumpRenderTree): Parse the command line options before setting up the
2768         environment so that we know if we need to set up the pixel dump
2769         machinery.
2770
2771 2007-11-21  Eric Seidel  <eric@webkit.org>
2772
2773         Speculative build fix for Tiger.
2774
2775         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
2776
2777 2007-11-21  Eric Seidel  <eric@webkit.org>
2778
2779         Reviewed by Tim Hatcher.
2780
2781         Break out more of DumpRenderTree.mm into individual files
2782
2783         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2784         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
2785         (checkedMalloc):
2786         (checkedRealloc):
2787         (makeLargeMallocFailSilently):
2788         * DumpRenderTree/mac/CheckedMalloc.h: Added.
2789         * DumpRenderTree/mac/DumpRenderTree.mm:
2790         (crashHandler):
2791         (dump):
2792         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2793         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
2794         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
2795         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2796         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2797         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
2798         (javaScriptThreads):
2799         (runJavaScriptThread):
2800         (startJavaScriptThreads):
2801         (stopJavaScriptThreads):
2802         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
2803         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
2804         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
2805         (restoreColorSpace):
2806         (setDefaultColorProfileToRGB):
2807         (initializeColorSpaceAndScreeBufferForPixelTests):
2808         (md5HashStringForBitmap):
2809         (dumpWebViewAsPixelsAndCompareWithExpected):
2810
2811 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
2812
2813         Move install-unix-extras to wx directory as it seems only to be used by that
2814         port now. It now supports universal binaries on Mac and adds libpng and libjpeg.
2815         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
2816         have install-unix-extras install into WebKitLibraries as per
2817         convention.
2818
2819         Reviewed by Mark Rowe.
2820
2821         * Scripts/install-unix-extras: Removed.
2822         * wx/build-wxwebkit:
2823         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
2824
2825 2007-11-21  Eric Seidel  <eric@webkit.org>
2826
2827         Reviewed by Adam.
2828
2829         More refactoring for greater code readability
2830
2831         * DumpRenderTree/mac/DumpRenderTree.mm:
2832         (initializeGlobalsFromCommandLineOptions):
2833         (initializeColorSpaceAndScreeBufferForPixelTests):
2834         (addTestPluginsToPluginSearchPath):
2835         (useLongRunningServerMode):
2836         (runTestingServerLoop):
2837         (prepareConsistentTestingEnvironment):
2838         (dumpRenderTree):
2839         (main):
2840         (dumpFramesAsText):
2841         (dumpBackForwardListForWebView):
2842         (sizeWebViewForCurrentTest):
2843         (methodNameStringForFailedTest):
2844         (dumpBackForwardListForAllWindows):
2845         (dumpWebViewAsPixelsAndCompareWithExpected):
2846         (invalidateAnyPreviousWaitToDumpWatchdog):
2847         (dump):
2848         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2849         * DumpRenderTree/mac/UIDelegate.mm:
2850         (-[UIDelegate webView:createWebViewWithRequest:]):
2851
2852 2007-11-21  Eric Seidel  <eric@webkit.org>
2853
2854         Reviewed by Tim Hatcher.
2855
2856         Abstract more of DRT into static methods
2857
2858         * DumpRenderTree/mac/DumpRenderTree.mm:
2859         (setDefaultsToConsistentValuesForTesting):
2860         (setupSignalHandlers):
2861         (allocateGlobalControllers):
2862         (releaseAndZero):
2863         (releaseGlobalControllers):
2864         (dumpRenderTree):
2865         (shouldLogFrameLoadDelegates):
2866         (createCFURLFromPathOrURL):
2867         (resetWebViewToConsistentStateBeforeTesting):
2868         (runTest):
2869
2870 2007-11-21  Eric Seidel  <eric@webkit.org>
2871
2872         Reviewed by Tim Hatcher.
2873
2874         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
2875
2876         * DumpRenderTree/DumpRenderTree.h:
2877         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2878         * DumpRenderTree/mac/DumpRenderTree.mm:
2879         (dumpRenderTree):
2880         (dump):
2881         (runTest):
2882         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
2883         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
2884         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
2885         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
2886         (-[DumpRenderTreePasteboard declareType:owner:]):
2887         (+[LocalPasteboard alloc]):
2888         (-[LocalPasteboard init]):
2889         (-[LocalPasteboard dealloc]):
2890         (-[LocalPasteboard name]):
2891         (-[LocalPasteboard releaseGlobally]):
2892         (-[LocalPasteboard declareTypes:owner:]):
2893         (-[LocalPasteboard addTypes:owner:]):
2894         (-[LocalPasteboard changeCount]):
2895         (-[LocalPasteboard types]):
2896         (-[LocalPasteboard availableTypeFromArray:]):
2897         (-[LocalPasteboard setData:forType:]):
2898         (-[LocalPasteboard dataForType:]):
2899         (-[LocalPasteboard setPropertyList:forType:]):
2900         (-[LocalPasteboard setString:forType:]):
2901         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
2902         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
2903         (+[DumpRenderTreeWindow allWindows]):
2904         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
2905         (-[DumpRenderTreeWindow dealloc]):
2906         (-[DumpRenderTreeWindow isKeyWindow]):
2907         (-[DumpRenderTreeWindow keyDown:]):
2908
2909 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
2910
2911         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
2912         it indiscriminately copies any headers inside JavaScriptCore,
2913         which includes Tiger ICU headers.
2914
2915         * wx/build-wxwebkit:
2916         Don't run WebCore/move-js-headers.sh any longer.
2917
2918 2007-11-20  Adam Treat  <treat@kde.org>
2919
2920         Reviewed by David Kilzer.
2921
2922         * Prepend git branch name to $baseProductDir
2923
2924         * Scripts/VCSUtils.pm:
2925         * Scripts/webkitdirs.pm:
2926
2927 2007-11-20  Mark Rowe  <mrowe@apple.com>
2928
2929         Reviewed by Simon Hausmann.
2930
2931         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
2932         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
2933         Have it trigger a "make distclean" rather than "make clean" to ensure that the
2934         built product and generated Makefile's are removed.
2935
2936 2007-11-19  Alp Toker  <alp@atoker.com>
2937
2938         Reviewed by Mark Rowe.
2939
2940         http://bugs.webkit.org/show_bug.cgi?id=16040
2941         [GTK] GtkLauncher should be written in C
2942
2943         Port GtkLauncher to plain C.
2944
2945         Use a more conventional GTK+ coding style.
2946
2947         Use a toolbar instead of menus.
2948
2949         Various signature fixes and cleanups.
2950
2951         Add a license header. Assume all previous modifications were copyright
2952         assigned to Apple Inc. by default.
2953
2954         * GtkLauncher/GtkLauncher.pro:
2955         * GtkLauncher/main.c: Added.
2956         (activate_url_entry_cb):
2957         (update_title):
2958         (link_hover_cb):
2959         (title_change_cb):
2960         (progress_change_cb):
2961         (destroy_cb):
2962         (go_back_cb):
2963         (go_forward_cb):
2964         (create_browser):
2965         (create_statusbar):
2966         (create_toolbar):
2967         (create_window):
2968         (main):
2969         * GtkLauncher/main.cpp: Removed.
2970
2971 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
2972
2973         Build script fixes to ensure they do the right thing for the
2974         wx port, and update build-wxwebkit to reflect the way the
2975         build scripts now work.
2976
2977         Reviewed by Adam.
2978
2979         * Scripts/build-testkjs:
2980         * Scripts/build-webkit:
2981         * Scripts/run-javascriptcore-tests:
2982         * Scripts/webkitdirs.pm:
2983         * wx/build-wxwebkit:
2984
2985 2007-11-18  Eric Seidel  <eric@webkit.org>
2986
2987         Reviewed by Anders.
2988
2989         Make run-javascriptcore-tests report failures on exit (to support git bisect)
2990
2991         * Scripts/run-javascriptcore-tests:
2992
2993 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
2994
2995         Reviewed by Adam Roben.
2996
2997         Make run-webkit-tests work with Windows debug build.
2998
2999         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
3000         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
3001         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
3002         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
3003         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
3004
3005 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
3006
3007         Add wxWebKit sample and build script, and integrate it with
3008         build-webkit. Also make build-webkit --clean work for all
3009         ports.
3010
3011         Reviewed by Darin Adler.
3012
3013         * Scripts/build-webkit:
3014         * Scripts/webkitdirs.pm:
3015         * wx: Added.
3016         * wx/browser: Added.
3017         * wx/browser/browser.bkl: Added.
3018         * wx/browser/browser.cpp: Added.
3019         * wx/build-wxwebkit: Added.
3020
3021 2007-11-17  Adam Roben  <aroben@apple.com>
3022
3023         Make it easy to run Safari in the debugger on Windows
3024
3025         I've added a new script, debug-safari, which launches Safari in the
3026         debugger. On OS X it just calls gdb-safari.
3027
3028         Reviewed by Mark Rowe.
3029
3030         * FindSafari/FindSafari.cpp:
3031         (_tmain): Added a /debugger flag, which in combination with
3032         /printSafariLauncher will print a script that launches Safari in the
3033         debugger.
3034         * Scripts/debug-safari: Added.
3035         * Scripts/run-safari: Changed to call runSafari().
3036         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
3037         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
3038         first argument along to FindSafari.
3039         * Scripts/webkitdirs.pm:
3040         (sub runSafari): Added.
3041
3042 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
3043
3044         Reviewed by Adam Roben.
3045
3046         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined.
3047
3048 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
3049
3050         Reviewed by David Kilzer.
3051
3052         The git config command was renamed to repo-config at some point. This
3053         change tries git config and then git repo-config if the first fails.
3054
3055         * Scripts/prepare-ChangeLog:
3056         (gitConfig):
3057
3058 2007-11-16  Dan Bernstein  <mitz@apple.com>
3059
3060         Reviewed by Darin Adler and Sam Weinig.
3061
3062         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
3063
3064         * DumpRenderTree/win/EventSender.cpp:
3065         (keyDownCallback): For characters that cannot be entered on the active
3066         keyboard layout, send a WM_CHAR message with the character along with
3067         a WM_KEYDOWN message with a virtual key code of 255.
3068
3069 2007-11-16  Mark Rowe  <mrowe@apple.com>
3070
3071         Reviewed by Tim Hatcher.
3072
3073         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
3074
3075         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3076         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3077
3078 2007-11-15  Adam Roben  <aroben@apple.com>
3079
3080         Make run-safari actually work on Windows
3081
3082         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
3083         chdir call.
3084
3085 2007-11-14  Adam Roben  <aroben@apple.com>
3086
3087         Updates to Safari launching now that 3.0.4 is released
3088
3089         Reviewed by Sam.
3090
3091         * FindSafari/FindSafari.cpp:
3092         (getWebViewCLSID): Use version-independent ProgID.
3093         * Scripts/run-safari: Use run-webkit-nightly.cmd.
3094
3095 2007-11-14  Anders Carlsson  <andersca@apple.com>
3096
3097         Reviewed by Adam.
3098
3099         <rdar://problem/5309081>
3100         In DRT, "plugin.logDestroy = true" not working on Windows.
3101
3102         * DumpRenderTree/win/TestNetscapePlugin/main.c:
3103         (NPP_Destroy):
3104
3105 2007-11-14  Eric Seidel  <eric@webkit.org>
3106
3107         Reviewed by Sam.
3108
3109         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
3110
3111 2007-11-14  Anders Carlsson  <andersca@apple.com>
3112
3113         Reviewed by Adam.
3114
3115         <rdar://problem/5141186>
3116         window.layoutTestController.setWindowIsKey is not implemented in DRT.
3117
3118         Implement setWindowIsKey.
3119
3120         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3121         (LayoutTestController::setWindowIsKey):
3122
3123 2007-11-13  Sam Weinig  <sam@webkit.org>
3124
3125         Reviewed by Adam Roben.
3126
3127         Fix for <rdar://problem/5382579>
3128         http/tests/security/cross-frame-access-put.html reports large
3129         negative numbers for screenLeft and screenTop (Mac reports "0")
3130
3131         * DumpRenderTree/win/UIDelegate.cpp:
3132         (UIDelegate::UIDelegate): Initialize the RECT.
3133         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
3134         (UIDelegate::webViewFrame): ditto.
3135         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
3136
3137 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
3138
3139         Reviewed by Adam.
3140
3141         - Make Drosera show source, source URLs, and function stack on Windows,
3142         and some minor fixes.
3143
3144         * Drosera/DebuggerDocument.cpp: Force source to always update display.
3145         (DebuggerDocument::updateFileSource):
3146         * Drosera/debugger.js: Force source to always update display.
3147         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
3148         menu controls.
3149         (DebuggerClient::resume):
3150         (DebuggerClient::pause):
3151         (DebuggerClient::stepInto):
3152         (DebuggerClient::stepOver):
3153         (DebuggerClient::stepOut):
3154         (DebuggerClient::showConsole):
3155         (DebuggerClient::closeCurrentFile):
3156         * Drosera/win/DebuggerClient.h: Ditto.
3157         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
3158         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
3159         removed two bugs.  1) caller could be in a bad state when asked to
3160         assign into it. 2) BSTRs were not created correctly.
3161         (DebuggerDocument::getPlatformCurrentFunctionStack):
3162         * Drosera/win/Drosera.cpp: Hook up the menu controls.
3163         (droseraWndProc):
3164         (handleCommand):
3165         (Drosera::resume):
3166         (Drosera::pause):
3167         (Drosera::stepInto):
3168         (Drosera::stepOver):
3169         (Drosera::stepOut):
3170         (Drosera::showConsole):
3171         (Drosera::closeCurrentFile):
3172         * Drosera/win/Drosera.h: Hook up the menu controls.
3173         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
3174         functions, added a null check, and fixed another bug where caller could
3175         be in a bad state when asked to assign into it.
3176         (ServerConnection::didLoadMainResourceForDataSource):
3177         (ServerConnection::getCallerFrame):
3178         * Drosera/win/ServerConnection.h: Safety first.
3179
3180 2007-11-13  Dan Bernstein  <mitz@apple.com>
3181
3182         Reviewed by Darin Adler.
3183
3184         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
3185           DumpRenderTree --pixel-tests renders each test twice
3186
3187         * DumpRenderTree/mac/DumpRenderTree.mm:
3188         (dumpRenderTree): Removed the --paint option because the painting code
3189         is always exercised as a result of
3190         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
3191         calling -displayIfNeeded.
3192         (dump): Changed to always grab the image from the window since the view
3193         is always displayed.
3194         (runTest):
3195         (displayWebView):
3196         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
3197         because it always paints.
3198
3199 2007-11-12  Antti Koivisto  <antti@apple.com>
3200
3201         Reviewed by Adele.
3202
3203         Add support for http media tests
3204
3205         * Scripts/run-webkit-tests:
3206
3207 2007-11-12  Sam Weinig  <sam@webkit.org>
3208
3209         Reviewed by Adam Roben.
3210
3211         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
3212
3213         * DumpRenderTree/win/DumpRenderTree.cpp:
3214         (runTest):
3215         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3216         (LayoutTestController::setPrivateBrowsingEnabled):
3217
3218 2007-11-12  Adam Roben  <aroben@apple.com>
3219
3220         * Scripts/update-webkit-localizable-strings: Changed to only scan the
3221         mac and win subdirectories.
3222
3223 2007-11-11  Adam Roben  <aroben@apple.com>
3224
3225         Fix <rdar://5133816> keepWebHistory is not implemented
3226
3227         Fixes fast/history/clicked-link-is-visited.html.
3228
3229         Reviewed by Darin.
3230
3231         * DumpRenderTree/win/DumpRenderTree.cpp:
3232         (runTest): Clear the optionalSharedHistory.
3233         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3234         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
3235
3236 2007-11-10  Sam Weinig  <sam@webkit.org>
3237
3238         Reviewed by Tim Hatcher.
3239
3240         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript
3241         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions
3242         is turned on)
3243
3244         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
3245
3246         Added test: http/tests/security/cross-frame-access-private-browsing.html
3247
3248         * DumpRenderTree/LayoutTestController.cpp:
3249         (setPrivateBrowsingEnabledCallback):
3250         (LayoutTestController::staticFunctions):
3251         * DumpRenderTree/LayoutTestController.h:
3252         * DumpRenderTree/mac/DumpRenderTree.mm:
3253         (runTest): Default to private browsing disabled.
3254         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3255         (LayoutTestController::setPrivateBrowsingEnabled):
3256         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3257         (LayoutTestController::setPrivateBrowsingEnabled):
3258
3259 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
3260
3261         Reviewed by Adam.
3262
3263         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
3264         WebCore's!
3265
3266         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
3267         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
3268         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
3269         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
3270         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
3271         * Drosera/win/Drosera.cpp:
3272         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
3273
3274 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
3275
3276         Reviewed by Sam.
3277
3278         - Use the new IWebFrame [local] function signature and get the shared
3279         server correctly.
3280
3281         * Drosera/win/DebuggerClient.cpp:
3282         (DebuggerClient::didFinishLoadForFrame):
3283         * Drosera/win/ServerConnection.cpp:
3284         (ServerConnection::attemptToCreateServerConnection):
3285
3286 2007-11-07  Dan Bernstein  <mitz@apple.com>
3287
3288         Reviewed by Darin Adler.
3289
3290         - add an option to run-webkit-tests to ignore pixel test failures where
3291           all pixels differ by no more than a specified threshold
3292
3293         * DumpRenderTree/mac/ImageDiff.m:
3294         (main):
3295         (compareImages):
3296         (computePercentageDifferent):
3297         * Scripts/run-webkit-tests:
3298
3299 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3300
3301         Reviewed by Lars.
3302
3303         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
3304
3305         * DumpRenderTree/qt/DumpRenderTree.cpp:
3306
3307 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3308
3309         Reviewed by Lars.
3310
3311         Reworked the QWebSettings API.
3312         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
3313
3314         * DumpRenderTree/qt/DumpRenderTree.cpp:
3315
3316 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3317
3318         Reviewed by Lars.
3319
3320         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
3321
3322         * DumpRenderTree/qt/jsobjects.cpp:
3323
3324 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3325
3326         Reviewed by Lars Knoll <lars@trolltech.com>.
3327
3328         Add a QWebPage::frameCreated() signal and fix DRT
3329
3330         The removal of createFrame in QWebPage broke the re-implementation
3331         in DumpRenderTree. Instead emit a frameCreated() signal and
3332         connect to it in DumpRenderTree.
3333
3334
3335         * DumpRenderTree/qt/DumpRenderTree.cpp:
3336         (WebCore::WebPage::WebPage):
3337         (WebCore::DumpRenderTree::dump):
3338         (WebCore::DumpRenderTree::connectFrame):
3339         * DumpRenderTree/qt/DumpRenderTree.h:
3340
3341 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3342
3343         Reviewed by Lars Knoll <lars@trolltech.com>.
3344
3345         Moved all the event handlers from QWebFrame into QWebPage.
3346
3347         This cleans up the public API and allows us to remove the
3348         HackWebFrame hack in DumpRenderTree.
3349
3350
3351         * DumpRenderTree/qt/jsobjects.cpp:
3352         (EventSender::mouseDown):
3353         (EventSender::mouseUp):
3354         (EventSender::mouseMoveTo):
3355
3356 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3357
3358         Reviewed by Mark.
3359
3360         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
3361         to prevent the default implementation from popping up messageboxes.
3362
3363         * DumpRenderTree/qt/DumpRenderTree.cpp:
3364         (WebCore::WebPage::javaScriptConfirm):
3365         (WebCore::WebPage::javaScriptPrompt):
3366
3367 2007-11-06  Eric Seidel  <eric@webkit.org>
3368
3369         * Scripts/build-testkjs: build fix... too many $$
3370
3371 2007-11-06  Eric Seidel  <eric@webkit.org>
3372
3373         Reviewed by Mark Rowe.
3374
3375         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
3376
3377 2007-11-05  Adam Roben  <aroben@apple.com>
3378
3379         Add support on Windows for WEBKIT_TESTFONTS
3380
3381         This environment variable lets you specify where the fonts to be used
3382         by DumpRenderTree reside. The Qt port is already using this, so I'm
3383         just following their lead.
3384
3385         Reviewed by Darin.
3386
3387         * DumpRenderTree/win/DumpRenderTree.cpp:
3388         (exePath): Refactored code out of initialize().
3389         (fontsPath): Returns either $WEBKIT_TESTFONTS or
3390         DumpRenderTree.resources.
3391         (initialize): Use the new fontsPath function.
3392         (main): Use the new exePath function.
3393         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
3394         variable to DRT, like Qt does.
3395
3396 2007-11-05  Mark Rowe  <mrowe@apple.com>
3397
3398         Rubber-stamped by Alp Toker.
3399
3400         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
3401
3402         * GtkLauncher/main.cpp:
3403         (goToURLBarText):
3404         (main):
3405
3406 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
3407
3408         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
3409         <http://bugs.webkit.org/show_bug.cgi?id=15830>
3410
3411         Reviewed by Timothy.
3412
3413         Restrict the range of nightly builds used by the bisect-builds script
3414         based on the version of Safari and the version of Mac OS X being used.
3415
3416         Mac OS X 10.4: Safari 2.0: r11976 or newer
3417         Mac OS X 10.4: Safari 3.0: r19992 or newer
3418
3419         Mac OS X 10.5: Safari 2.0: r19594 or newer
3420         Mac OS X 10.5: Safari 3.0: r25124 or newer
3421
3422         * Scripts/bisect-builds:
3423         (findMacOSXVersion): Added.
3424         (makeNightlyList): Added argument to provide version of Mac OS X.
3425         Restrict range of nightly builds based on Safari and Mac OS X versions.
3426
3427 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
3428
3429         Reviewed by Maciej.
3430
3431         - This patch involves several changes, all of them were noticed that
3432         they were needed by the work being done in WebKit to get Drosera and
3433         WebKit working together on Windows.
3434         - The changes are:
3435         1) Added a debugger console for output messages.
3436         2) Drosera now listens for the WebKit server (before, the server would
3437         have to be running before Drosera was started.)
3438         3) Fixed a bug where the WebView started out as 0x0 pixels.
3439         4) Fixed a bug when there is no scope.
3440         5) Added the HTML, JS, and CSS to the project file to make them easy to
3441         find.
3442         6) Made the ServerConnection functions virtual.
3443
3444         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
3445         for the WebKit server.
3446         (DebuggerClient::DebuggerClient):
3447         (DebuggerClient::~DebuggerClient):
3448         (DebuggerClient::didFinishLoadForFrame):
3449         (DebuggerClient::serverConnected):
3450         (DebuggerClient::attemptToCreateServerConnection):
3451         * Drosera/win/DebuggerClient.h: Ditto.
3452         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
3453         scope.
3454         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3455         (DebuggerDocument::platformValueForScopeVariableNamed):
3456         * Drosera/win/Drosera.cpp:
3457         (_tWinMain): Added a console in debug for output messages.
3458         (Drosera::Drosera): Listen for server.
3459         (Drosera::initUI): The server now Initializes COM.
3460         (Drosera::serverConnected): Part of the listening for the server.
3461         (Drosera::attemptToCreateServerConnection): Ditto.
3462         * Drosera/win/Drosera.h: New interface for listening for the server.
3463         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
3464         files to the VS project.
3465         * Drosera/win/ServerConnection.cpp: Part of listening for the server
3466         connection.
3467         (ServerConnection::ServerConnection):
3468         (ServerConnection::attemptToCreateServerConnection):
3469         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
3470         methods.
3471         (ServerConnection::serverConnected):
3472
3473 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
3474
3475         Reviewed by Maciej.
3476
3477         http://bugs.webkit.org/show_bug.cgi?id=15832
3478         fast/dom/gc-10.html crashes when run alone
3479
3480         Check for !done before using objects that can be already deallocated.
3481
3482         * DumpRenderTree/mac/EditingDelegate.mm:
3483         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
3484         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
3485         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
3486         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
3487         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
3488         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
3489         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
3490         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
3491         (-[EditingDelegate webViewDidBeginEditing:]):
3492         (-[EditingDelegate webViewDidChange:]):
3493         (-[EditingDelegate webViewDidEndEditing:]):
3494         (-[EditingDelegate webViewDidChangeTypingStyle:]):
3495         (-[EditingDelegate webViewDidChangeSelection:]):
3496         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3497         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
3498         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
3499         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3500         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
3501         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
3502         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
3503         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3504         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
3505         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
3506         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
3507         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
3508         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
3509         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
3510         (-[FrameLoadDelegate webView:willCloseFrame:]):
3511         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
3512         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
3513         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3514         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
3515         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3516         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
3517         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
3518         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
3519         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
3520
3521 2007-11-04  Mark Rowe  <mrowe@apple.com>
3522
3523         Build fix.  Don't use Carbon.h as the prefix header as it triggers
3524         warnings that would otherwise be suppressed due to it being a system header.
3525
3526         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3527
3528 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
3529
3530         Rubber stamped by Adam.
3531
3532         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
3533
3534         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3535
3536 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
3537
3538         Sort files(...); sections of Xcode project files.
3539
3540         Rubber-stamped by Darin.
3541
3542         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
3543         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3544         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3545         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
3546
3547 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
3548
3549         Script to sort "files(...);" sections in Xcode project.pbxproj files.
3550
3551         Reviewed by Darin.
3552
3553         * Scripts/sort-Xcode-project-file: Added.
3554
3555 2007-11-02  Darin Adler  <darin@apple.com>
3556
3557         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
3558
3559 2007-11-02  Darin Adler  <darin@apple.com>
3560
3561         Reviewed by Maciej.
3562
3563         * Scripts/run-sunspider: Pass the "--base" option through.
3564
3565         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
3566         the real script do that. Default configuration to Release to match run-sunspider
3567         so we don't end up building Debug just to compare results.
3568
3569 2007-11-01  Adam Roben  <aroben@apple.com>
3570
3571         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
3572
3573         Reviewed by Sam.
3574
3575         * Scripts/commit-log-editor: Show all the directories beneath the
3576         source root, instead of just the last one.
3577
3578 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
3579
3580         Reviewed by Adam Roben.
3581
3582         Print out an error message when the Windows build fails
3583         and provide guidance on how to find out what went wrong.
3584
3585         * Scripts/build-webkit:
3586         * Scripts/webkitdirs.pm:
3587
3588 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
3589
3590         Rubber-stamped by Adam Roben.
3591
3592         Rolled out r27326 - debug CRT seems to cause no problems after all.
3593
3594         * DumpRenderTree/win/DumpRenderTree.vcproj:
3595
3596 2007-10-31  Adam Roben  <aroben@apple.com>
3597
3598         Switch the Debug configuration to using the non-debug CRT
3599
3600         This matches WebKit.
3601
3602         Reviewed by Steve.
3603
3604         * DumpRenderTree/win/DumpRenderTree.vcproj:
3605
3606 2007-10-31  Antti Koivisto  <antti@apple.com>
3607
3608         Reviewed by bdash.
3609
3610         Disable media tests when doing leak checking on Tiger.
3611         They crash in QuickTime (rdar://problem/5537157).
3612
3613         * Scripts/run-webkit-tests:
3614
3615 2007-10-29  Antti Koivisto  <antti@apple.com>
3616
3617         Reviewed by Maciej.
3618
3619         Build media support by default on OSX only.
3620
3621         * Scripts/build-webkit:
3622
3623 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3624
3625         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
3626         get caught by the pre-commit hooks.
3627
3628 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3629
3630         Reviewed by Adam.
3631
3632         - This is a collection of relatively unrelated changes and cleanups
3633         to Drosera to prepare it for interacting with WebKit.  A lot of these
3634         changes are just correcting mistakes, for example removing included
3635         headers that are no longer needed.
3636
3637         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
3638         this will be needed by the DebuggerClient.
3639         (DebuggerDocument::server):
3640         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
3641         * Drosera/win/DebuggerClient.cpp:
3642         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
3643         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
3644         (DebuggerClient::createWebViewWithRequest): Added comment about its
3645         purpose.
3646         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
3647         declarations.
3648         (DebuggerClient::webViewLoaded): Moved.
3649         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
3650         file, since this was the only place it was used.
3651         (cfStringToBSTR):
3652         * Drosera/win/Drosera.h: Cleaned up the includes.
3653         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
3654         * Drosera/win/HelperFunctions.h: Removed.
3655
3656 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3657
3658         Reviewed by Adam.
3659
3660         - Small cleanup in the ServerConnection class.
3661
3662         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
3663         and added an include.
3664         (ServerConnection::currentFrame):
3665         (ServerConnection::getCallerFrame):
3666         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
3667         made a pointer into a COMPtr, and cleaned up the includes.
3668
3669 2007-10-29  Timothy Hatcher  <timothy@apple.com>
3670
3671         Reviewed by John Sullivan.
3672
3673         - Place the Localizable.strings file in mac or win directories
3674           if that location exists.
3675         - Also look for UI_STRING in .c files.
3676
3677         * Scripts/extract-localizable-strings:
3678
3679 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3680
3681         Reviewed by Adam.
3682
3683         - Set the eol-style to native and made all the line endings the same
3684         so that I avoid messy diffs that show eol changes.
3685
3686         * Drosera/win/ServerConnection.cpp:
3687         (ServerConnection::didParseSource):
3688         (ServerConnection::didEnterCallFrame):
3689         (ServerConnection::willExecuteStatement):
3690         (ServerConnection::willLeaveCallFrame):
3691         (ServerConnection::exceptionWasRaised):
3692
3693 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3694
3695         Reviewed by Adam.
3696
3697         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
3698         functionality that could not have existed previously without the new
3699         interfaces.
3700         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
3701         from a BSTR to a JSValueRef.
3702         (DebuggerDocument::platformEvaluateScript): Implemented.
3703         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
3704         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3705         Implemented.
3706         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
3707         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
3708         * Drosera/win/ServerConnection.cpp: Added a helper function.
3709         (ServerConnection::getCallerFrame):
3710         * Drosera/win/ServerConnection.h: Added a helper function.
3711
3712 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
3713
3714         updated reviewers for my previous changelog.
3715
3716 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
3717         Reviewed by Maciej and Adam and Geoff.
3718
3719         - Minor mac-side improvements including moving a function to a more
3720         appropriate location, fixing a warning, and correctly checking
3721         exceptions.
3722
3723         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
3724         (DebuggerDocument::willExecuteStatement):
3725         (DebuggerDocument::didEnterCallFrame):
3726         (DebuggerDocument::willLeaveCallFrame):
3727         (DebuggerDocument::windowScriptObjectAvailable):
3728         (DebuggerDocument::callFunctionOnObject):
3729         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
3730         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
3731         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
3732         because it doesn't require the ServerConnection at all.
3733         (NSStringCreateWithJSStringRef): Made an argument const.
3734         (JSValueRefCreateWithNSString): Made an argument const.
3735         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
3736         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3737         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
3738         * Drosera/mac/ServerConnection.mm: Ditto.
3739         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
3740
3741 2007-10-29  Sam Weinig  <sam@webkit.org>
3742
3743         Reviewed by Adam Roben.
3744
3745         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
3746
3747         * DumpRenderTree/LayoutTestController.cpp:
3748         (LayoutTestController::LayoutTestController):
3749         (getGlobalFlagCallback):
3750         (setGlobalFlagCallback):
3751         (LayoutTestController::getJSClass):
3752         (LayoutTestController::staticValues):
3753         * DumpRenderTree/LayoutTestController.h:
3754         (LayoutTestController::globalFlag):
3755         (LayoutTestController::setGlobalFlag):
3756
3757 2007-10-29  Darin Adler  <darin@apple.com>
3758
3759         Reviewed by Maciej.
3760
3761         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
3762         resolution instead of its default.
3763
3764 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
3765
3766         Fixed showStatus() to print status for successfully resolved conflicts when using git.
3767
3768         Reviewed by Mark Rowe.
3769
3770         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
3771         was successfully resolved, but this would not show any status because the change had
3772         already been cached in the index using "git add".  The solution is to add an optional
3773         second argument to showStatus() which adds the "--cached" switch to the command.
3774
3775         * Scripts/resolve-ChangeLogs:
3776         (showStatus):
3777
3778 2007-10-28  Eric Seidel  <eric@webkit.org>
3779
3780         Reviewed by Maciej and Geoff, in unison.
3781
3782         * Scripts/run-webkit-tests: remove broken --svg option
3783
3784 2007-10-28  Darin Adler  <darin@apple.com>
3785
3786         Reviewed by Adam.
3787
3788         * Scripts/run-sunspider: Default to "Release" configuration rather than
3789         defaulting to the last configuration used as other scripts do. This can
3790         still be overriden on the command line with "--debug" if there's some
3791         reason to do so. Also fix a typo.
3792
3793         * Scripts/sunspider-compare-results: Fix a typo.
3794
3795 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
3796
3797         Reviewed by Adam.
3798
3799         - Implemented the WebScriptDebugListener functions now that the
3800         WebScriptDebugServer exists
3801
3802         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
3803         functions.
3804         (ServerConnection::currentFrame):
3805         (ServerConnection::didLoadMainResourceForDataSource):
3806         (ServerConnection::didParseSource):
3807         (ServerConnection::failedToParseSource):
3808         (ServerConnection::didEnterCallFrame):
3809         (ServerConnection::willExecuteStatement):
3810         (ServerConnection::willLeaveCallFrame):
3811         (ServerConnection::exceptionWasRaised):
3812         * Drosera/win/ServerConnection.h: Removed unused arguments from the
3813         members arguments list.
3814
3815 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
3816
3817         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
3818         <http://bugs.webkit.org/show_bug.cgi?id=15600>
3819
3820         Reviewed by Darin.
3821
3822         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
3823         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
3824         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
3825         file.  Note that it may also be used as a stand-alone script.
3826
3827         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
3828         * Scripts/resolve-ChangeLogs: Added.
3829         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
3830
3831 2007-10-26  Mark Rowe  <mrowe@apple.com>
3832
3833         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
3834         to the Qt port on the assumption that it was an implementation of the cross-platform
3835         LayoutTestController class.  It is not, so it did not need to be changed.
3836
3837         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
3838
3839 2007-10-25  Mark Rowe  <mrowe@apple.com>
3840
3841         Reviewed by Maciej.
3842
3843         Fix builds with code coverage enabled.
3844
3845         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
3846
3847 2007-10-25  Darin Adler  <darin@apple.com>
3848
3849         Reviewed by Mark Rowe.
3850
3851         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
3852         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
3853
3854 2007-10-25  Stephanie  <slewis@apple.com>
3855
3856         build Fix
3857
3858         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3859
3860 2007-10-25  Stephanie  <slewis@apple.com>
3861
3862         Reviewed by Mark Rowe, Adam Roben.
3863
3864         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
3865
3866         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3867
3868 2007-10-25  Alice Liu  <alice.liu@apple.com>
3869
3870         Reviewed by Adam.
3871
3872         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
3873
3874         Moving destructor into platform-specific files
3875         * DumpRenderTree/LayoutTestController.cpp:
3876         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3877         (LayoutTestController::~LayoutTestController):
3878         * DumpRenderTree/qt/jsobjects.cpp:
3879         (LayoutTestController::~LayoutTestController):
3880
3881         LayoutTestController wasn't being destroyed
3882         * DumpRenderTree/win/DumpRenderTree.cpp:
3883         (runTest):
3884
3885         Added declspec
3886         * DumpRenderTree/win/EditingDelegate.h:
3887
3888         Reset certain values on the webview (or related delegate) that might
3889         have changed while running a test
3890         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3891         (LayoutTestController::~LayoutTestController):
3892
3893 2007-10-25  Adam Roben  <aroben@apple.com>
3894
3895         Make sunspider-compare-results work with relative paths
3896
3897         Reviewed by Sam.
3898
3899         * Scripts/sunspider-compare-results: Convert arguments to absolute
3900         paths before we chdir.
3901
3902 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
3903
3904         Reviewed by Sam.
3905
3906         - Implemented server calls now the WebScriptDebugServer exists.
3907         - Also removed no longer needed call to initialize CG.
3908
3909         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
3910         automatically now.
3911         (_tWinMain):
3912         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
3913         (ServerConnection::ServerConnection):
3914         (ServerConnection::~ServerConnection):
3915         (ServerConnection::pause):
3916         (ServerConnection::resume):
3917         (ServerConnection::stepInto):
3918         (ServerConnection::applicationTerminating):
3919         (ServerConnection::serverConnectionDidDie):
3920         * Drosera/win/ServerConnection.h: Now uses the COM class.
3921
3922 2007-10-24  George Staikos  <staikos@kde.org>
3923
3924         Unbreak Qt build.
3925
3926         * Scripts/build-webkit:
3927
3928 2007-10-24  Adam Roben  <aroben@apple.com>
3929
3930         Remove now-unnecessary call to InitializeCoreGraphics
3931
3932         WebKit takes care of this now.
3933
3934         Reviewed by Ada.
3935
3936         * DumpRenderTree/win/DumpRenderTree.cpp:
3937         (initialize):
3938
3939 2007-10-24  Adam Roben  <aroben@apple.com>
3940
3941         Use WebTextRenderer in DRT
3942
3943         Reviewed by Ada.
3944
3945         * DumpRenderTree/win/DumpRenderTree.cpp:
3946         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
3947
3948 2007-10-24  Sven Herzberg  <sven@imendio.com>
3949
3950         Reviewed by Mark Rowe.
3951
3952         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
3953         Bug 15614: [GTK] qmake based backends don't build on OS X
3954
3955         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
3956         GTK backend on a Mac
3957         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
3958         isDarwin() to make it reusable in other places (like the workaround-
3959         for-prebuilt-qmake in build-webkit)
3960
3961 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
3962
3963         Refurbish update-webkit script.
3964
3965         Reviewed by Adam.
3966
3967         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
3968         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
3969         multi-argument version of system() for flexibility and security.  Check for existence
3970         of Internal directory using -d test instead of -x.
3971
3972 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
3973
3974         Minor clean-up of prepare-ChangeLog script.
3975
3976         Reviewed by Adam.
3977
3978         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
3979         of a string.  Use multi-argument versions of open() and system() for flexibility and
3980         security.
3981
3982 2007-10-24  Alice Liu  <alice.liu@apple.com>
3983
3984         Reviewed by Oliver.
3985
3986         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
3987
3988         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to
3989         replay the saved events when we're still processing the mousedown that starts the drag
3990         * DumpRenderTree/win/EventSender.cpp:
3991         (doMouseMove):
3992         * DumpRenderTree/win/UIDelegate.cpp:
3993         (UIDelegate::doDragDrop):
3994
3995 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
3996
3997         Reviewed by Sam, Steve and Darin.
3998
3999         - Stubbed out the WebScriptDebugListener functionality in the Server
4000         Connection class to prepare it for receiving those callbacks.
4001         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
4002         and the ServerConnection to not need to be initialized with a server
4003         name, since that is not the way we connect to the WebKit server.
4004
4005         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
4006         no exception.  Now it only loggs when there is an exception
4007         (DebuggerDocument::willExecuteStatement):
4008         (DebuggerDocument::didEnterCallFrame):
4009         (DebuggerDocument::willLeaveCallFrame):
4010         (DebuggerDocument::windowScriptObjectAvailable):
4011         (DebuggerDocument::callFunctionOnObject):
4012         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
4013         to be instantiated with a server's name.
4014         (DebuggerClient::DebuggerClient):
4015         (DebuggerClient::didFinishLoadForFrame):
4016         * Drosera/win/DebuggerClient.h: Removed unsued variable.
4017         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
4018         a server name.
4019         (Drosera::init):
4020         (Drosera::initServer):
4021         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
4022         instantiated with a server's name.
4023         * Drosera/win/ServerConnection.cpp:
4024         (ServerConnection::ServerConnection): No longer needs a server name
4025         (ServerConnection::~ServerConnection): Only release the global context
4026         if there is one.
4027         (ServerConnection::serverConnectionDidDie): Stub for
4028         IWebScriptDebugListener
4029         (ServerConnection::QueryInterface): ditto
4030         (ServerConnection::AddRef): ditto
4031         (ServerConnection::Release): ditto
4032         (ServerConnection::didLoadMainResourceForDataSource): ditto
4033         (ServerConnection::didParseSource): ditto
4034         (ServerConnection::failedToParseSource): ditto
4035         (ServerConnection::didEnterCallFrame): ditto
4036         (ServerConnection::willExecuteStatement): ditto
4037         (ServerConnection::willLeaveCallFrame): ditto
4038         (ServerConnection::exceptionWasRaised): ditto
4039         * Drosera/win/ServerConnection.h: Stubbed out the
4040         IWebScriptDebugListener functions, and this class no longer needs to be
4041         instantiated with a server name.
4042
4043 2007-10-24  Lars Knoll  <lars@trolltech.com>
4044
4045         Reviewed by Simon.
4046
4047         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
4048
4049         * DumpRenderTree/qt/jsobjects.h:
4050
4051 2007-10-24  Lars Knoll  <lars@trolltech.com>
4052
4053         Reviewed by Simon.
4054
4055         add another command.
4056
4057         * DumpRenderTree/qt/jsobjects.cpp:
4058         (TextInputController::doCommand):
4059
4060 2007-10-24  Lars Knoll  <lars@trolltech.com>
4061
4062         Reviewed by Simon.
4063
4064         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
4065
4066         * DumpRenderTree/qt/jsobjects.cpp:
4067         (EventSender::keyDown):
4068         * DumpRenderTree/qt/jsobjects.h:
4069
4070 2007-10-24  Lars Knoll  <lars@trolltech.com>
4071
4072         Reviewed by Simon.
4073
4074         implement eventSender.keyDown().
4075
4076         * DumpRenderTree/qt/jsobjects.cpp:
4077         (EventSender::keyDown):
4078
4079 2007-10-24  Lars Knoll  <lars@trolltech.com>
4080
4081         Reviewed by Simon.
4082
4083         some smaller fixes to the editing support in DRT. Makes another few tests pass.
4084
4085         * DumpRenderTree/qt/DumpRenderTree.cpp:
4086         (WebCore::DumpRenderTree::DumpRenderTree):
4087         (WebCore::DumpRenderTree::initJSObjects):
4088         * DumpRenderTree/qt/jsobjects.cpp:
4089         (TextInputController::doCommand):
4090
4091 2007-10-24  Lars Knoll  <lars@trolltech.com>
4092
4093         Reviewed by Simon.
4094
4095         first bit of implementation for the textinputcontroller.
4096
4097         * DumpRenderTree/qt/DumpRenderTree.cpp:
4098         (WebCore::DumpRenderTree::DumpRenderTree):
4099         * DumpRenderTree/qt/DumpRenderTree.h:
4100         * DumpRenderTree/qt/jsobjects.cpp:
4101         (TextInputController::TextInputController):
4102         (TextInputController::doCommand):
4103         * DumpRenderTree/qt/jsobjects.h:
4104
4105 2007-10-24  Lars Knoll  <lars@trolltech.com>
4106
4107         Reviewed by Simon.
4108
4109         make the man webpage believe it has focus, so the editing tests work correctly.
4110
4111         * DumpRenderTree/qt/DumpRenderTree.cpp:
4112         (WebCore::DumpRenderTree::DumpRenderTree):
4113
4114 2007-10-24  Lars Knoll  <lars@trolltech.com>
4115
4116         Reviewed by Simon.
4117
4118         implement layoutTestController.dumpEditingCallbacks() correctly.
4119
4120         * DumpRenderTree/qt/DumpRenderTree.cpp:
4121         (WebCore::DumpRenderTree::DumpRenderTree):
4122         * DumpRenderTree/qt/jsobjects.cpp:
4123         (LayoutTestController::reset):
4124         (LayoutTestController::dumpEditingCallbacks):
4125
4126 2007-10-24  Lars Knoll  <lars@trolltech.com>
4127
4128         Reviewed by Simon.
4129
4130         Implement support for testing editing.
4131
4132         * DumpRenderTree/qt/DumpRenderTree.cpp:
4133         (WebCore::DumpRenderTree::DumpRenderTree):
4134
4135 2007-10-23  Sam Weinig  <sam@webkit.org>
4136
4137         Check for null BSTR that can be passed to the UIDelegate methods
4138         from javascript null and undefined.  Fixes a failing test case on
4139         Windows (fast/dom/Window/alert-undefined.html)
4140
4141         Reviewed by Eric Seidel.
4142
4143         * DumpRenderTree/win/UIDelegate.cpp:
4144         (UIDelegate::runJavaScriptAlertPanelWithMessage):
4145         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
4146         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
4147         (UIDelegate::webViewAddMessageToConsole):
4148
4149 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
4150
4151         Reviewed by Darin.
4152
4153         Don't print a massive pile of setenvs from tools that automatically build testkjs.
4154
4155         * Scripts/build-testkjs:
4156
4157 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
4158
4159         Reviewed by Darin.
4160
4161         - add wrapper that finds the right copy of testkjs
4162
4163         * Scripts/sunspider-compare-results: Added.
4164
4165 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
4166
4167         Reviewed by Sam.
4168
4169         - After talking with Steve I now see that the WebKit server must be
4170         running for DCOM to create the distributed objects, which makes sense
4171         and currently WebKit only allows one instance to be running at a time
4172         which avoids accidentally connecting to the wrong server
4173         - In light of this I have removed the code for the attach box and
4174         NotificationServer and known server names, since they are all extranious
4175         now.
4176
4177         * Drosera/win/Drosera.cpp: Removed notification classes and known server
4178         names.
4179         (_tWinMain): Uses init instead of initUI.
4180         (droseraWndProc): No longer creats an attach dialog box.
4181         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
4182         it's not manditory to call init before doing COM stuff.
4183         (Drosera::init): calls initUI and will call attach when the
4184         functionality exists.
4185         (Drosera::initUI): Has changed very little.
4186         (Drosera::attach): Changed the signature to reflect that we no longer
4187         need the dictionary of known server names.
4188         * Drosera/win/Drosera.h: Removed notification classes and known server
4189         names.  Also renamed and moved some functions.
4190         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
4191         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
4192         headers to the resources folder.
4193         * Drosera/win/resource.h: Removed the Attach box.
4194
4195 2007-10-22  Adam Roben  <aroben@apple.com>
4196
4197         Windows build fix
4198
4199         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
4200
4201 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
4202
4203         - Removed a leak that was fixed.
4204
4205         * Scripts/run-webkit-tests:
4206
4207 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
4208
4209         Reviewed by Darin.
4210
4211         - Changed the Client so that the DebuggerDocument now own the
4212         ServerConnection.  This simplifies ownership and cleanup.
4213
4214         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
4215         ServerConnection.
4216         (DebuggerClient::initWithServerName):
4217         (DebuggerClient::didFinishLoadForFrame):
4218         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the
4219         ServerConnection.
4220         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
4221         until after we have a server which we are attached to.
4222         (Drosera::initUI):
4223         (Drosera::attach):
4224         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
4225         out previously.
4226
4227 2007-10-22  Simon Hausmann  <hausmann@kde.org>
4228
4229         Reviewed by Nikolas.
4230
4231         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
4232
4233         * Scripts/run-javascriptcore-tests:
4234
4235 2007-10-22  Simon Hausmann  <hausmann@kde.org>
4236
4237         Reviewed by Nikolas.
4238
4239         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
4240
4241         * Scripts/build-drosera:
4242         * Scripts/build-dumprendertree:
4243         * Scripts/build-testkjs:
4244         * Scripts/build-webkit:
4245         * Scripts/run-javascriptcore-tests:
4246         * Scripts/run-sunspider:
4247         * Scripts/run-webkit-tests:
4248         * Scripts/webkitdirs.pm:
4249
4250 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
4251
4252         Reviewed by Mark Rowe.
4253
4254         Fix for local database support after r26879
4255         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
4256
4257         * Scripts/build-webkit:
4258
4259 2007-10-22  Holger Freyther  <zecke@selfish.org>
4260
4261         Reviewed by Simon Hausmann <hausmann@kde.org>.
4262
4263         - Do not build testkjs as an application bundle. This is
4264         needed for run-javascriptcore-tests on OSX.
4265         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
4266         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
4267         as we do not have -rpath on OSX.
4268
4269         * DumpRenderTree/qt/DumpRenderTree.pro:
4270         * Scripts/run-webkit-tests:
4271
4272 2007-10-22  Simon Hausmann  <hausmann@kde.org>
4273
4274         Reviewed by aroben.
4275
4276         Fix support for Signed-off-by detection in prepare-ChangeLog
4277         --git-commit. The Signed-off-by tag does not appear in the header
4278         but usually at the end.
4279
4280         * Scripts/prepare-ChangeLog:
4281
4282 2007-10-21  Mark Rowe  <mrowe@apple.com>
4283
4284         Reviewed by Eric.
4285
4286         Fix run-javascriptcore-tests for Gtk.
4287
4288         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
4289
4290 2007-10-20  Eric Seidel  <eric@webkit.org>
4291
4292         Reviewed by aroben.
4293
4294         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
4295
4296 2007-10-20  Eric Seidel  <eric@webkit.org>
4297
4298         Reviewed by darin.
4299
4300         Add improved argument handling to run-sunspider, including
4301         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
4302         Also re-factor code into subroutines
4303
4304         * Scripts/build-dumprendertree: removed bogus comments
4305         * Scripts/build-testkjs: Added.
4306         * Scripts/run-javascriptcore-tests: use build-testkjs
4307         * Scripts/run-sunspider: improved argument handling, abstraction
4308         * Scripts/run-webkit-tests: improved abstraction
4309
4310 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
4311
4312         Not reviewed, Windows build fix.
4313
4314         * DumpRenderTree/win/EventSender.cpp:
4315         (keyDownCallback):
4316
4317 2007-10-20  Darin Adler  <darin@apple.com>
4318
4319         Reviewed by Tim Hatcher.
4320
4321         - http://bugs.webkit.org/show_bug.cgi?id=15544
4322           <rdar://problem/5076426> fast/events/arrow-navigation.html needs&nbs