6618203e5c31bacadd3265f4e1ab518330a8b71a
[WebKit-https.git] / WebKitTools / ChangeLog
1 2008-02-04  Oliver Hunt  <oliver@apple.com>
2
3         Reviewed by Steve F.
4
5         Partial fix for <rdar://5621244> Drag & Drop doesn't work correctly in DRT
6
7         Implement required DRT functionality to allow majority of Drag and Drop testcases to work.
8         Issues include:
9           * Uses Sleep() to implement leapForward reliably.
10           * 3 DND tests still fail for reasons that i have not yet determined
11           * Has to explicitly ignore an extraneous WM_MOUSELEAVE that i am at a loss to explain 
12
13         * DumpRenderTree/win/EventSender.cpp:
14         (leapForwardCallback):
15         (mouseDownCallback):
16         (doMouseUp):
17         (mouseUpCallback):
18         (doMouseMove):
19         (mouseMoveToCallback):
20           Minor updates to these functions to handle the different message queue structure.
21
22         (replaySavedEvents):
23           More complicated now.  Where possible we just use the old while-loop model of execution,
24           but when leapForward has been used we have to jump through some hoops and set up an 
25           inner event loop so that we can ensure messages get the correct time stamp.
26
27         * DumpRenderTree/win/UIDelegate.cpp:
28         (UIDelegate::doDragDrop):
29           Call replaySavedEvents directly to force synchronous handling of drag and drop.
30
31 2008-02-04  Rodney Dawes  <dobey@wayofthemonkey.com>
32
33         Reviewed by Alp Toker and Mark Rowe.
34
35         Fix http://bugs.webkit.org/show_bug.cgi?id=17175.
36         Bug 17175: Use of C++ compiler flags in CFLAGS
37
38         * GNUmakefile.am: Use global_cxxflags as well as global_cflags in CXXFLAGS.
39
40 2008-02-04  Darin Adler  <darin@apple.com>
41
42         Reviewed by Geoff.
43
44         * Scripts/make-js-test-wrappers: Look at the whole LayoutTests tree, not just the fast
45         and svg subdirectories. Added some more exceptions for the benefit of the fast/dom
46         subdirectory.
47
48 2008-02-04  Adam Roben  <aroben@apple.com>
49
50         Windows Apple-only build fix
51
52         * DumpRenderTree/win/DumpRenderTree.vcproj: Added a new include
53         directory.
54
55 2008-02-04  Alp Toker  <alp@atoker.com>
56
57         Rubber-stamped by Mark Rowe.
58
59         Remove all trailing whitespace in the GTK+ port and related
60         components.
61
62         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
63         * DumpRenderTree/gtk/GCControllerGtk.cpp:
64         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
65         * GNUmakefile.am:
66
67 2008-02-01  Eric Seidel  <eric@webkit.org>
68
69         Reviewed by Oliver.
70
71         Also search LayoutTests/svg for js-based tests.
72
73         * Scripts/make-js-test-wrappers:
74
75 2008-01-31  Alp Toker  <alp@atoker.com>
76
77         Rubber-stamped by Adam Roben.
78
79         http://bugs.webkit.org/show_bug.cgi?id=17006
80         [GTK] Header path should be webkit/webkit.h
81
82         Move the GTK+ API sources as needed and update the build systems.
83
84         * DumpRenderTree/gtk/DumpRenderTree.cpp:
85         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
86         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
87         * GNUmakefile.am:
88         * GtkLauncher/main.c:
89
90 2008-01-30  Stephanie  <slewis@apple.com>
91
92         Reviewed by Geoff.
93
94         Add an option to run-webkit-tests to merge leaks results and print the number of unique leaks found under a certain call depth.  This should make it easier for the buildbots to track new leaks.
95
96         * Scripts/run-webkit-tests:
97
98 2008-01-30  Alexey Proskuryakov  <ap@webkit.org>
99
100         Reviewed by Adam Roben.
101
102         One more debug (external) fix.
103
104         * DumpRenderTree/win/DumpRenderTree.cpp: TestNetscapePlugin is built with a _debug suffix in both DebugInternal
105         and Debug configurations. 
106
107 2008-01-29  Geoffrey Garen  <ggaren@apple.com>
108
109         Reviewed by Sam Weinig. Sam Weinig.
110         
111         Fixed <rdar://problem/5692566> fast/encoding/mailto-always-utf-8.html
112         fails when run after fast/dom/Window/window-property-shadowing.html (16902)
113
114         Modified our policy delegates not to output window.name. Since a
115         previous test may have explicitly set window.name, we can't rely on its
116         implicit value in test results.
117
118         * DumpRenderTree/mac/PolicyDelegate.mm:
119         (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
120
121         * DumpRenderTree/win/PolicyDelegate.cpp:
122         (PolicyDelegate::decidePolicyForNavigationAction):
123
124 2008-01-29  Mark Rowe  <mrowe@apple.com>
125
126         Reviewed by Tim Hatcher.
127
128         <rdar://problem/5600926> WebCore on Tiger must link to its own copy of SQLite 3.4 or newer (so HTML database behavior will be correct).
129
130         * Scripts/build-webkit: Copy SQLite static library and headers into the build directory.
131
132 2008-01-29  David Kilzer  <ddkilzer@apple.com>
133
134         Refactor ChangeLog path code
135
136         Reviewed by Adam.
137
138         * Scripts/prepare-ChangeLog: Simplify code in one foreach() loop, and extract
139         duplicate code in another foreach() loop.
140
141 2008-01-29  Alexey Proskuryakov  <ap@webkit.org>
142
143         Reviewed by Darin.
144
145         <rdar://problem/5710692> All storage tests fail/crash
146
147         * DumpRenderTree/mac/UIDelegate.mm:
148         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): Set an
149         arbitrary quota of 5 megabytes.
150
151         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
152         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
153         Removed unused (I think) code.
154         
155         * DumpRenderTree/win/UIDelegate.cpp:
156         (UIDelegate::QueryInterface): IWebUIDelegatePrivate3 is now supported.
157         (UIDelegate::webViewPainted): A stub implementation.
158         (UIDelegate::exceededDatabaseQuota): Set an arbitrary quota of 5 megabytes.
159         * DumpRenderTree/win/UIDelegate.h:
160
161 2008-01-27  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
162
163         GTK+ DRT build fix for breakage introduced in r29822.
164
165         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
166         (LayoutTestController::setPersistentUserStyleSheetLocation):
167         (LayoutTestController::clearPersistentUserStyleSheet):
168
169 2008-01-27  Dan Bernstein  <mitz@apple.com>
170
171         Reviewed by Darin Adler.
172
173         - add support for directory prologues and epilogues to run-webkit-tests
174         - allow setting a persistent user style sheet in DumpRenderTree
175         - activate the WebKit Layout Tests font in Windows DumpRenderTree
176
177         * DumpRenderTree/LayoutTestController.cpp:
178         (clearPersistentUserStyleSheetCallback): Added.
179         (setPersistentUserStyleSheetLocationCallback): Added.
180         (LayoutTestController::staticFunctions): Added.
181         clearPersistentUserStyleSheet and setPersistentUserStyleSheet.
182         * DumpRenderTree/LayoutTestController.h:
183         * DumpRenderTree/mac/DumpRenderTree.mm:
184         (setPersistentUserStyleSheetLocation): Added.
185         (resetWebViewToConsistentStateBeforeTesting): Added the user style sheet
186         to the set of things this function resets. Now it either disables the
187         user style sheet or sets it to the persistent user style sheet and
188         enables it.
189         * DumpRenderTree/mac/DumpRenderTreeMac.h:
190         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
191         (LayoutTestController::setPersistentUserStyleSheetLocation): Added.
192         (LayoutTestController::clearPersistentUserStyleSheet): Added.
193         * DumpRenderTree/win/DumpRenderTree.cpp:
194         (setPersistentUserStyleSheetLocation): Added.
195         (initialize): Added the WebKit Layout Tests font to the set of fonts to
196         install.
197         (resetWebViewToConsistentStateBeforeTesting): See DumpRenderTree.mm.
198         * DumpRenderTree/win/DumpRenderTreeWin.h:
199         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
200         (LayoutTestController::setPersistentUserStyleSheetLocation): Added.
201         (LayoutTestController::clearPersistentUserStyleSheet): Added.
202         * Scripts/run-webkit-tests: Changed to look for, and if found process in
203         DumpRenderTree, files named run-webkit-tests-prologue.html and
204         run-webkit-tests-epilogue.html in the resources subdirectory of any
205         test directory and platform test results directory. The prologues are
206         processed before the first test from the directory (and its
207         subdirectories) is run, and the epilogues are processed after the last
208         test from the directory is run. Platform-specific prologues and
209         epilogues are processed in order of specificity.
210
211 2008-01-25  Alexey Proskuryakov  <ap@webkit.org>
212
213         Reviewed by Mark Rowe.
214
215         <rdar://problem/5699933> http/tests/security/cross-frame-access-get.html is still failing
216
217         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Clear HTTP cache to ensure consistent test environment
218         (matching Mac DRT).
219         * DumpRenderTree/win/DumpRenderTree.vcproj: Link to CFNetwork.
220
221 2008-01-24  Sam Weinig  <sam@webkit.org>
222
223         Reviewed by Ada Chan.
224
225         Fix for <rdar://5131975> DumpRenderTree doesn't support undo/redo
226
227         - Adds simplified UndoManager to windows DRT to allow testing the
228           undo/redo code paths in WebCore and WebKit.  This is a temporary
229           solution to an issue that should eventually be solved by having a
230           shared UndoManager in WebKit.
231
232         * DumpRenderTree/win/DumpRenderTree.cpp:
233         (runTest):
234         * DumpRenderTree/win/UIDelegate.cpp:
235         (DRTUndoObject::DRTUndoObject):
236         (DRTUndoObject::invoke):
237         (DRTUndoStack::~DRTUndoStack):
238         (DRTUndoStack::isEmpty):
239         (DRTUndoStack::clear):
240         (DRTUndoStack::push):
241         (DRTUndoStack::pop):
242         (DRTUndoManager::canRedo):
243         (DRTUndoManager::canUndo):
244         (DRTUndoManager::DRTUndoManager):
245         (DRTUndoManager::removeAllActions):
246         (DRTUndoManager::registerUndoWithTarget):
247         (DRTUndoManager::redo):
248         (DRTUndoManager::undo):
249         (UIDelegate::UIDelegate):
250         (UIDelegate::resetUndoManager):
251         (UIDelegate::registerUndoWithTarget):
252         (UIDelegate::removeAllActionsWithTarget):
253         (UIDelegate::setActionTitle):
254         (UIDelegate::undo):
255         (UIDelegate::redo):
256         (UIDelegate::canUndo):
257         (UIDelegate::canRedo):
258         * DumpRenderTree/win/UIDelegate.h:
259
260 2008-01-23  Adam Roben  <aroben@apple.com>
261
262         Allow directories containing ChangeLogs to be passed to
263         resolve-ChangeLogs
264
265         Reviewed by David Kilzer.
266
267         * Scripts/resolve-ChangeLogs:
268         (sub findChangeLog): Return a ChangeLog contained within the specified
269         directory if one exists.
270
271 2008-01-23  Steve Falkenburg  <sfalken@apple.com>
272
273         <rdar://problem/5698732> Copyright strings should include 2008
274
275         Reviewed by Sam.
276
277         * Drosera/win/Drosera.vcproj/Drosera.rc:
278         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc:
279
280 2008-01-23  Alp Toker  <alp@atoker.com>
281
282         Rubber-stamped by Mark Rowe.
283
284         Remove whitespace after -I in automake include lists.
285
286         * GNUmakefile.am:
287
288 2008-01-23  Michael Goddard <michael.goddard@trolltech.com>
289
290         Reviewed by Lars Knoll <lars@trolltech.com>.
291
292         Reworked the JavaScriptCore Qt bindings:
293         
294         * Update JS DRT controller for Qt JS binding changes.
295         There were two functions that needed some changes
296         so that the layout tests would work, so this makes
297         a few tests pass again.
298         
299         * Bump the timeout for layout tests up to 11s.
300         At least some tests have an internal timeout of
301         10 seconds, so make the waitUntilDone approach
302         wait at least 11s.  fast/dom/open-and-close-by-DOM.html
303         is one of these - now the failure message is more
304         accurate.
305         
306
307         * DumpRenderTree/qt/jsobjects.cpp:
308         (LayoutTestController::waitUntilDone):
309         * DumpRenderTree/qt/jsobjects.h:
310
311 2008-01-22  Anders Carlsson  <andersca@apple.com>
312
313         Reviewed by Darin and Adam.
314
315         <rdar://problem/5688975>
316         div element on microsoft site has wrong left offset.
317         
318         Add new method for testing the return vale of NPN_GetProperty.
319         
320         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
321         (pluginInvoke):
322
323 2008-01-22  Alexey Proskuryakov  <ap@webkit.org>
324
325         Reviewed by Adam Roben.
326
327         <rdar://problem/5670257> editing/selection/4895428-3.html makes editing/selection/5131716-2.html fail
328
329         * DumpRenderTree/win/EventSender.cpp: (makeEventSender): Reset static variables for a new test.
330
331 2008-01-21  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
332
333         Reviewed by Alp Toker.
334
335         http://bugs.webkit.org/show_bug.cgi?id=16955
336         Get errors when cross-compile webkit-gtk
337
338         * GNUmakefile.am: Removed ICU_CFLAGS 
339
340 2008-01-21  Darin Adler  <darin@apple.com>
341
342         Reviewed by Mitz and Adam.
343
344         * Scripts/svn-create-patch: Sort ChangeLog files first. Also slightly improved the
345         sorting speed by doing all sort criteria in a single pass instead of three sorts.
346
347 2008-01-21  Simon Hausmann  <hausmann@webkit.org>
348
349         Reviewed by Holger.
350
351         Fix focus chain handling and cycling through focusable objects (links) using tab/backtab.
352         
353         * Fix GraphicsContext::drawFocusRing to also draw single focus rects.
354         * Implemented QWebPage::focusNextPrevChild by sending fake tab/shift-tab events
355         and make the return value depend on whether we successfully determined a focusable
356         node or not.
357         * Changed QWebView::focusNextPrevChild() to call the base QWidget implementation correctly
358         if we could not handle the focus chain ourselves.
359         * Changed the focus policy of QWebView to correctly use WheelFocus instead of ClickFocus.
360         * Made ChromeClientQt::canTakeFocus() and takeFocus() dummy method since they are only
361         used to control the situation of stepping out of the focus chain inside the page.
362         * Made inclusion of links in the focus chain configurable through QWebSettings::LinksIncludedInFocusChain.
363         The layout tests expect this to be disabled but for the user it seems sensible to have it
364         on by default, hence the default in qwebsettings.cpp
365         
366
367         * DumpRenderTree/qt/DumpRenderTree.cpp:
368         (WebCore::WebPage::WebPage):
369
370 2008-01-19  Mark Rowe  <mrowe@apple.com>
371
372         Reviewed by Alp Toker.
373
374         Allow the --http flag to run-webkit-tests to override
375         the default behaviour of disabling HTTP tests for Qt,
376         Gtk and Wx.
377
378         * Scripts/run-webkit-tests:
379
380 2008-01-19  David Kilzer  <ddkilzer@apple.com>
381
382         <rdar://problem/5695344> check-for-global-initializers script never checks any object files
383
384         Reviewed by Darin.
385
386         We now touch a check-for-global-initializers.timestamp file in
387         the TARGET_TEMP_DIR directory to determine when new object files
388         have been compiled and thus need to be checked.  If the timestamp
389         file doesn't exist, all object files will be checked.
390
391         Previously the modification time of the "executable" (the
392         framework binary, e.g., WebKit.framework/WebKit) was used, but
393         since this was the last file modified at the end of the compile
394         phase, no object files would ever get checked!
395
396         Also added JSCustomSQLTransactionCallback.o to the list of files
397         since it has static initializers in Debug builds of WebCore.
398
399         * Scripts/check-for-global-initializers:
400
401 2008-01-18  Adam Roben  <aroben@apple.com>
402
403         Build fix
404
405         * Scripts/build-webkit:
406
407 2008-01-18  Beth Dakin  <bdakin@apple.com>
408
409         Reviewed by Oliver.
410
411         Update build-webkit to account for foreign-object being disabled by 
412         default.
413
414         * Scripts/build-webkit:
415
416 2008-01-18  Adam Roben  <aroben@apple.com>
417
418         Updated for method renames
419
420         Reviewed by Adele.
421
422         * DumpRenderTree/mac/FrameLoadDelegate.mm:
423         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
424         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
425         (LayoutTestController::setMainFrameIsFirstResponder):
426         (LayoutTestController::setWindowIsKey):
427         * DumpRenderTree/mac/UIDelegate.mm:
428         (-[UIDelegate webViewFocus:]):
429         * DumpRenderTree/win/FrameLoadDelegate.cpp:
430         (FrameLoadDelegate::didCommitLoadForFrame):
431
432 2008-01-18  Alexey Proskuryakov  <ap@webkit.org>
433
434         Reviewed by Adam Roben.
435
436         Fix plugin-related tests in Debug_Internal configuration, which are failing because of CRT version mismatch
437         between DRT and TestNetscapePlugin.
438
439         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Added a Debug_Internal configuration.
440         * DumpRenderTree/DumpRenderTree.sln: Use this configuration.
441
442 2008-01-18  Simon Hausmann  <hausmann@webkit.org>
443
444         Reviewed by Holger.
445
446         Fix fast/dom/Window/window-resize.html
447         
448         In DRT connect the page's geometryChangeRequest signal to a slot that
449         sets the geometry of the view widget.
450         
451
452         * DumpRenderTree/qt/DumpRenderTree.cpp:
453         (WebCore::WebPage::setViewGeometry):
454         (WebCore::WebPage::WebPage):
455
456 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
457
458         Build fix.
459
460         * Drosera/DroseraWin.make:
461
462 2008-01-17  Darin Adler  <darin@apple.com>
463
464         * Scripts/run-webkit-tests: Fixed a bug number.
465
466 2008-01-17  Alexey Proskuryakov  <ap@webkit.org>
467
468         Reviewed by Adam Roben.
469
470         http://bugs.webkit.org/show_bug.cgi?id=16908
471         run-webkit-tests complains about missing FindSafari.exe
472
473         * Scripts/webkitdirs.pm: Append _debug as appropriate.
474
475 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
476
477         Re-add DEBUG_WEBKIT_HAS_SUFFIX.
478         
479         Rubber-stamped by Jon Honeycutt.
480
481         * DumpRenderTree/win/DumpRenderTree.vcproj:
482
483 2008-01-16  Alp Toker  <alp@atoker.com>
484
485         Reviewed by Mark Rowe.
486
487         http://bugs.webkit.org/show_bug.cgi?id=16218
488         [GTK] API: Should this entry point be called go_back rather than go_backward?
489
490         Track back/forward API changes in the tools.
491
492         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
493         (BackForwardItem::invoke):
494         * GtkLauncher/main.c:
495         (go_back_cb):
496
497 2008-01-16  Adam Roben  <aroben@apple.com>
498
499         Windows build fix after r29488
500
501         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
502         Build into a subdirectory of $WebKitOutputDir\bin to match where DRT
503         expects to find the plugin.
504
505 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
506
507         Reviewed by Sam Weinig.
508         
509         Fixed the waitUntilDone watchdog timer -- the old code never added the
510         timer to the run loop, so it didn't do anything.
511
512         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
513         (LayoutTestController::setWaitToDump):
514         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
515         (LayoutTestController::setWaitToDump):
516
517 2008-01-14  Steve Falkenburg  <sfalken@apple.com>
518
519         Use shared vsprops for most vcproj properties.
520         
521         Reviewed by Darin.
522
523         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
524         * DumpRenderTree/win/DumpRenderTree.vcproj:
525         * DumpRenderTree/win/ImageDiff.vcproj:
526         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
527         * FindSafari/FindSafari.vcproj:
528
529 2008-01-14  Stephanie  <slewis@apple.com>
530
531        Reviewed by NOBODY.
532   
533        revert accidental character.
534
535        * Scripts/run-webkit-tests:
536
537 2008-01-14  Stephanie  <slewis@apple.com>
538
539         RS=Oliver
540
541         add Quicktime PPC only leaks to Leopard exclude list. See <rdar://problem/5667132>
542
543         * Scripts/run-webkit-tests:
544
545 2008-01-14  Darin Adler  <darin@apple.com>
546
547         * Scripts/do-webcore-rename: Queue up another rename.
548
549 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
550
551         Reviewed by Darin.
552
553         * Allow to run the tests in reverse order to spot test cases where the result depends on the order
554         the tests were ran.
555         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
556
557         * Scripts/run-webkit-tests:
558
559 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
560
561         Reviewed by Darin.
562
563         * Randomize tests array to spot test cases where the results depends on the order
564         the tests are ran.
565         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
566
567         * Scripts/run-webkit-tests:
568
569 2008-01-14  Darin Adler  <darin@apple.com>
570
571         * Scripts/run-webkit-tests: More ignore list tweaking.
572
573 2008-01-14  Darin Adler  <darin@apple.com>
574
575         * Scripts/run-webkit-tests: Add another leak to the ignore list.
576
577 2008-01-14  Dan Bernstein  <mitz@apple.com>
578
579         Reviewed by Adam Roben.
580
581         - try to fix failure in fast/dom/Window/window-onFocus.html seen on the
582           build bots
583
584         * DumpRenderTree/win/DumpRenderTree.cpp:
585         (resetWebViewToConsistentStateBeforeTesting): Focus the web view.
586
587 2008-01-13  Steve Falkenburg  <sfalken@apple.com>
588
589         Share common files across projects.
590         
591         Unify vsprops files
592         Debug:          common.vsprops, debug.vsprops
593         Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
594         Release:        common.vsprops, release.vsprops
595         
596         Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
597         debug_internal.vsprops will be mostly empty except for file path prefix modifiers.
598
599         Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.
600
601         Reviewed by Adam Roben.
602
603         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
604         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Removed.
605         * Drosera/win/Drosera.vcproj/VERSION: Removed.
606         * Drosera/win/Drosera.vcproj/auto-version.sh: Removed.
607         * Drosera/win/Drosera.vcproj/debug.vsprops: Removed.
608         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Removed.
609         * Drosera/win/Drosera.vcproj/release.vsprops: Removed.
610         * DumpRenderTree/win/DumpRenderTree.vcproj:
611         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
612         * DumpRenderTree/win/debug.vsprops: Removed.
613         * DumpRenderTree/win/debug_internal.vsprops: Removed.
614         * DumpRenderTree/win/release.vsprops: Removed.
615
616 2008-01-13  Brent Fulgham  <bfulgham@gmail.com>
617
618         Reviewed by Maciej.
619
620         - http://bugs.webkit.org/show_bug.cgi?id=16314
621           Script to launch Drosera
622
623         * Scripts/gdb-drosera: Added.
624         * Scripts/run-drosera: Added.
625         * Scripts/run-drosera-nightly.cmd: Added.
626         * Scripts/webkitdirs.pm: Added runDrosera function.
627
628 2008-01-13  Dan Bernstein  <mitz@apple.com>
629
630         - fix breakage due to last-minute change
631
632         * DumpRenderTree/win/DumpRenderTree.cpp:
633         (runTest): Declare the loop variable.
634
635 2008-01-13  Dan Bernstein  <mitz@apple.com>
636
637         Reviewed by Adam Roben.
638
639         - fix <rdar://problem/5132009> Windows DRT does not support multiple windows
640
641         * DumpRenderTree/win/DumpRenderTree.cpp:
642         (DumpRenderTreeWndProc):
643         (initialize):
644         (dumpBackForwardList):
645         (dumpBackForwardListForAllWindows):
646         (dump):
647         (resetWebViewToConsistentStateBeforeTesting): Factored out of
648         runTest().
649         (runTest):
650         (allWindows): Added. Returns a vector of all open windows.
651         (windowToWebViewMap): Added. Returns a map from open windows to their
652         WebViews.
653         (createWebViewAndOffscreenWindow): Factored out of main() to be
654         reusable for creating extra windows.
655         (main):
656         * DumpRenderTree/win/DumpRenderTreeWin.h:
657         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
658         (LayoutTestController::windowCount): Implemented.
659         * DumpRenderTree/win/UIDelegate.cpp:
660         (UIDelegate::createWebViewWithRequest): Implemented.
661         (UIDelegate::webViewClose): Implemented.
662         * DumpRenderTree/win/UIDelegate.h:
663
664 2008-01-12  Alp Toker  <alp@atoker.com>
665
666         Reviewed by Mark Rowe.
667
668         Hide non-public symbols in GTK+/autotools release builds.
669
670         * GNUmakefile.am:
671
672 2008-01-12  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
673
674         Reviewed by Ap.
675
676         * Make launching of the WebKit httpd work on GNU/Debian/Linux
677         
678         The configuration of Apache2 and installation does not depend on
679         the kernel but on the distribution policy. Make launching of httpd
680         work for Debian derived distributions.
681
682         * Scripts/run-webkit-httpd:
683         * Scripts/run-webkit-tests:
684         * Scripts/webkitdirs.pm:
685
686 2008-01-12  Mark Rowe  <mrowe@apple.com>
687
688         Reviewed by Maciej Stachowiak.
689
690         Fix crash in http/tests/security/local-JavaScript-from-remote.html under guard malloc.
691
692         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Retain string before returning it to
693         match the callers expectations that it can take ownership of the string.
694
695 2008-01-11  Alexey Proskuryakov  <ap@webkit.org>
696
697         Reviewed by Adam Roben.
698
699         <rdar://problem/5667275> fast/dynamic/layer-hit-test-crash.html is failing
700
701         * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ignore WM_MOUSELEAVE events,
702         as these are only posted because the test window is not a normal visible one, and
703         they confuse drag&drop machinery.
704
705 2008-01-11  Adam Roben  <aroben@apple.com>
706
707         Fix a crash when pathToLocalResource fails and a leak
708
709         Reviewed by Darin.
710
711         * DumpRenderTree/LayoutTestController.cpp:
712         (pathToLocalResourceCallback): Dont leak the JSStringRef, and make
713         sure not to pass null to JSValueMakeString.
714         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
715         (LayoutTestController::pathToLocalResource): Print an error message if
716         the conversion fails so it's clear what happened.
717
718 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
719
720         Reviewed by John Sullivan.
721
722         * DumpRenderTree/mac/GCControllerMac.mm:
723         (GCController::collectOnAlternateThread): Updated for name change.
724
725 2008-01-10  Kevin Ollivier  <kevino@theolliviers.com>
726
727         wx build fix. Don't build dftables any longer since it's now a Perl
728         script.
729
730         * wx/build-wxwebkit:
731
732 2008-01-10  Sam Weinig  <sam@webkit.org>
733
734         Reviewed by Anders Carlsson.
735
736         Make DRT track open windows instead of allocated windows so that
737         we can avoid ASSERTION due to late deallocs out of our control.
738
739         * DumpRenderTree/mac/DumpRenderTree.mm:
740         (dumpBackForwardListForAllWindows):
741         (runTest):
742         * DumpRenderTree/mac/DumpRenderTreeMac.h:
743         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
744         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
745         (+[DumpRenderTreeWindow openWindows]):
746         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
747         (-[DumpRenderTreeWindow close]):
748         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
749         (LayoutTestController::windowCount):
750
751 2008-01-10  Ada Chan  <adachan@apple.com>
752
753         Meta key is not the same as Alt key on windows.
754
755         Reviewed by Darin.
756
757         * DumpRenderTree/win/EventSender.cpp:
758         (keyDownCallback):
759
760 2008-01-09  Kevin McCullough  <kmccullough@apple.com>
761
762         Reviewed by Darin, Sam and Adam.
763
764         -<rdar://problem/5654486> REGRESSION (Safari 3.0.4-TOT): clicking on
765         link in gmail message displays JavaScript alert falsely complaining
766         about pop-up blocking.
767         - Added the ability to enable the pop-up blocker via the
768         LayoutTestController.
769
770         * DumpRenderTree/LayoutTestController.cpp:
771         (setPopupBlockingEnabledCallback):
772         (LayoutTestController::staticFunctions):
773         * DumpRenderTree/LayoutTestController.h:
774         * DumpRenderTree/mac/DumpRenderTree.mm:
775         (setDefaultsToConsistentValuesForTesting):
776         (resetWebViewToConsistentStateBeforeTesting):
777         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
778         (LayoutTestController::setPopupBlockingEnabled):
779
780 2008-01-10  Lars Knoll  <lars@trolltech.com>
781
782         Reviewed by Simon.
783
784         rename QWebPageHistory to QWebHistory.
785         
786
787         * DumpRenderTree/qt/jsobjects.cpp:
788
789 2008-01-09  Maciej Stachowiak  <mjs@apple.com>
790
791         Reviewed by Darin.
792         
793         - add some more renames, adjust some
794
795         * Scripts/do-webcore-rename:
796
797 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
798
799         Reviewed by Oliver.
800
801         Enable SVG Fonts support by default.
802
803         * Scripts/build-webkit:
804
805 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
806
807         Reviewed by Adam.
808
809         Fixes: http://bugs.webkit.org/show_bug.cgi?id=16244
810         DRT doesn't handle platform specific pixel test results correctly.
811
812         <test>-expected.txt files and <test>-expected.png files may now live
813         in different directories (ie. a cross-platform <test>-expected.txt file
814         and a platform-specific <test>-expected.png file).
815
816         * Scripts/run-webkit-tests:
817
818 2008-01-04  Kevin McCullough  <kmccullough@apple.com>
819
820         Reviewed by Darin.
821
822         - <rdar://problem/5666914> fast/regex/test{1,4}.html are failing
823         DRT did not correctly handle printing the '\0' char.  Now it does.
824
825         * DumpRenderTree/win/DumpRenderTree.cpp:
826         (dumpFramesAsText):
827         (dump):
828
829 2008-01-07  Simon Hausmann  <hausmann@webkit.org>
830
831         Reviewed by Lars.
832
833         Ported of the network backend of the Qt platform to Qt 4.4's new networking API.
834         
835
836         * DumpRenderTree/qt/main.cpp:
837         * DumpRenderTree/qt/testplugin.cpp:
838         * DumpRenderTree/qt/testplugin.h:
839
840 2008-01-05  Mark Rowe  <mrowe@apple.com>
841
842         Reviewed by Alp Toker.
843
844         Fix hang in fast/frames/frame-display-none-focus.html during Gtk layout tests.
845
846         * DumpRenderTree/gtk/DumpRenderTree.cpp:
847         (processWork): Process pending work.
848         (webViewLoadFinished): Schedule processing of pending work.
849         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Use webkit_web_frame_reload.
850
851 2008-01-05  Darin Adler  <darin@apple.com>
852
853         * Scripts/do-webcore-rename: Some more renaming plans.
854
855 2008-01-04  Alice Liu  <alice.liu@apple.com>
856
857         Reviewed by Alexey and Darin.
858
859         Adding "home" and "end" to DRT's keydown since
860         DOM key events can't handle keyIdentifiers at this point. 
861
862         * DumpRenderTree/mac/EventSendingController.mm:
863         (-[EventSendingController keyDown:withModifiers:]):
864         * DumpRenderTree/win/EventSender.cpp:
865         (keyDownCallback):
866
867 2008-01-04  Lars Knoll  <lars@trolltech.com>
868
869         Reviewed by Simon.
870
871         fix DRT after the changes to QWebPage.
872         
873         The great thing is that we actually don't have
874         any regressions from the QWebPage change :)
875         
876
877         * DumpRenderTree/qt/DumpRenderTree.cpp:
878         (WebCore::DumpRenderTree::DumpRenderTree):
879
880 2008-01-04  Lars Knoll  <lars@trolltech.com>
881
882         Reviewed by Simon.
883
884         make QWebPage a QObject and get things to compile.
885         
886         Nothing works currently though.
887         
888
889         * DumpRenderTree/qt/DumpRenderTree.cpp:
890         (WebCore::DumpRenderTree::DumpRenderTree):
891
892 2008-01-04  Lars Knoll  <lars@trolltech.com>
893
894         Reviewed by Simon.
895
896         take a QString as identifier in QWebFrame::addToJSWindowObject.
897
898         * DumpRenderTree/qt/DumpRenderTree.cpp:
899         (WebCore::DumpRenderTree::initJSObjects):
900
901 2008-01-04  Alp Toker  <alp@atoker.com>
902
903         GTK+ DRT build fix for breakage introduced in r29149.
904
905         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
906         (LayoutTestController::execCommand):
907
908 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
909
910         Reviewed by Darin.
911
912         <rdar://problem/5463489> A number of layout tests should be using execCommand instead of textInputController
913
914         Added layoutTestController.execCommand to access editor commands that are not available
915         via document.execCommand.
916
917         * DumpRenderTree/LayoutTestController.cpp:
918         (execCommandCallback):
919         (LayoutTestController::staticFunctions):
920         * DumpRenderTree/LayoutTestController.h:
921         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
922         (LayoutTestController::execCommand):
923         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
924         (LayoutTestController::queueLoad):
925         (LayoutTestController::execCommand):
926
927 2008-01-03  Alice Liu  <alice.liu@apple.com>
928
929         Reviewed by Darin, Mitz.
930
931         fixed <rdar://5130762> mousedowns in different locations increase the clickcount incorrectly
932
933         the clickcount should not increase if the last click was at a different location.  it's a new click.
934
935         * DumpRenderTree/mac/DumpRenderTree.mm:
936         (runTest):
937         * DumpRenderTree/mac/EventSendingController.h:
938         * DumpRenderTree/mac/EventSendingController.mm:
939         (-[EventSendingController mouseDown]):
940         (-[EventSendingController mouseUp]):
941
942 2008-01-03  Darin Adler  <darin@apple.com>
943
944         Reviewed by Adam.
945
946         * Scripts/update-webkit: Make this work a little better for the people at Apple
947         who have a directory named Internal.
948
949 2008-01-03  Adam Roben  <aroben@apple.com>
950
951         Use HTTP::Date instead of Date::Parse because it's installed by Cygwin by default
952
953         Rubberstamped by Mark.
954
955         * Scripts/update-webkit-auxiliary-libs:
956
957 2008-01-03  Adam Roben  <aroben@apple.com>
958
959         Fix Bug 15663: update-webkit re-downloads WebKitAuxiliaryLibrary unnecessarily
960
961         http://bugs.webkit.org/show_bug.cgi?id=15663
962
963         Added a fuzz factor into the Last-Modified comparison for downloading
964         WebKitAuxiliaryLibrary.zip.
965
966         The zip file is served from a set of mirrors who give Last-Modified
967         times that are off by 1-3 seconds from each other. This was causing
968         the build bots to redownload WebKitAuxiliaryLibrary for every build,
969         which would then cause all of WebCore to rebuild each time.
970
971         Reviewed by Mark.
972
973         * Scripts/update-webkit-auxiliary-libs: Check if the new zip file is
974         at least 30 seconds newer than the old one -- otherwise we assume that
975         the difference in time is due to the mirrors being slightly offset
976         from each other.
977         (sub lastModifiedToUnixTime): Added.
978
979 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
980
981         Windows build fix.
982
983         * DumpRenderTree/ForwardingHeaders/wtf/HashTraits.h: Added (needed by COMPtr.h).
984
985 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
986
987         Reviewed by Lars.
988
989         Moved QWebPage::open to QWebFrame::load and added setHtml.
990         
991
992         * DumpRenderTree/qt/DumpRenderTree.cpp:
993         (WebCore::DumpRenderTree::open):
994
995 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
996
997         Reviewed by Lars.
998
999         Added the first revision of QWebView and started moving functionality from QWebPave over to QWebView and QWebFrame.
1000         
1001
1002         * DumpRenderTree/qt/DumpRenderTree.cpp:
1003         (WebCore::DumpRenderTree::DumpRenderTree):
1004
1005 2008-01-02  Sam Weinig  <sam@webkit.org>
1006
1007         * Scripts/do-webcore-rename: Yet more renaming ideas.
1008
1009 2008-01-02  Darin Adler  <darin@apple.com>
1010
1011         * Scripts/do-webcore-rename: More renaming ideas. (Maciej, please merge yours with mine.)
1012
1013 2008-01-02  Alice Liu  <alice.liu@apple.com>
1014
1015         Reviewed by Sam Weinig.
1016
1017         fixing assertion hit with editing/selection/move-begin-end.html
1018
1019         * DumpRenderTree/ForwardingHeaders/wtf/ASCIICType.h: Added.
1020         * DumpRenderTree/win/DumpRenderTree.vcproj:
1021         * DumpRenderTree/win/EventSender.cpp:
1022         (keyDownCallback):
1023         using isupper will cause an assertion for inputs outside of ascii range. use isASCIIUpper instead.
1024
1025 2008-01-02  Darin Adler  <darin@apple.com>
1026
1027         * Scripts/do-webcore-rename: Some more name change plans.
1028
1029 2008-01-02  Alice Liu  <alice.liu@apple.com>
1030
1031         Reviewed by Maciej.
1032
1033         Added handling for page up and page down in EventSender
1034
1035         * DumpRenderTree/mac/EventSendingController.mm:
1036         (-[EventSendingController keyDown:withModifiers:]):
1037         * DumpRenderTree/win/EventSender.cpp:
1038         (keyDownCallback):
1039
1040 2008-01-02  Alexey Proskuryakov  <ap@webkit.org>
1041
1042         Reviewed by Darin.
1043
1044         Fix fast/events/arrow-keys-on-body.html for real.
1045
1046         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Pass proper keyData for WM_KEYUP, too.
1047
1048 2008-01-02  Luca Bruno  <lethalman88@gmail.com>
1049
1050         Reviewed by Darin.
1051
1052         http://bugs.webkit.org/show_bug.cgi?id=16674
1053         [GTK] run-launcher sets wrong LD_LIBRARY_PATH
1054
1055         * Scripts/run-launcher:
1056
1057 2007-12-31  Darin Adler  <darin@apple.com>
1058
1059         Suggested by Antti.
1060
1061         * Scripts/webkitdirs.pm: Turned off the QuickTime requirement for Windows until
1062         we get it installed on the build bots.
1063
1064 2007-12-30  Eric Seidel  <eric@webkit.org>
1065
1066         Reviewed by Sam.
1067
1068         * Scripts/do-webcore-rename: Add a few more planned renames s/(\w+)Imp/\1/
1069
1070 2007-12-29  Darin Adler  <darin@apple.com>
1071
1072         Reviewed by Oliver.
1073
1074         - fix http://bugs.webkit.org/show_bug.cgi?id=16663
1075           leak bot shows createCStringFromNPVariant result leaking
1076
1077         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1078         (pluginInvoke): Added a missing free.
1079
1080 2007-12-26  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
1081
1082         Reviewed by Alp Toker.
1083
1084         http://bugs.webkit.org/show_bug.cgi?id=16390
1085         Use autotools or GNU make as the build system for the GTK port
1086
1087         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: include glib.h
1088         * GNUmakefile.am: Added.
1089
1090 2007-12-24  Alexey Proskuryakov  <ap@webkit.org>
1091
1092         Reviewed by Oliver.
1093
1094         Fix fast/events/arrow-keys-on-body.html, failing on Windows.
1095
1096         * DumpRenderTree/win/EventSender.cpp:
1097         (keyDownCallback): Add KF_EXTENDED flag to arrow keys. Also add a count
1098         of 1, even though WebKit currently ignores it.
1099
1100 2007-12-23  Kevin Ollivier  <kevino@theolliviers.com>
1101
1102         wx buildbot fix. Update libpng dl script to the latest version.
1103
1104         * wx/install-unix-extras:
1105
1106 2007-12-22  Antti Koivisto  <antti@apple.com>
1107
1108         Fix a typo.
1109
1110         * Scripts/webkitdirs.pm:
1111
1112 2007-12-21  Sam Weinig  <sam@webkit.org>
1113
1114         Reviewed by Mark Rowe.
1115
1116         - Disable the back/forward cache using the new WebPreferences API
1117           instead of through the BackForwardList.  This makes us match what
1118           we do on Windows.
1119
1120         * DumpRenderTree/mac/DumpRenderTree.mm:
1121         (createWebViewAndOffscreenWindow):
1122         (setDefaultsToConsistentValuesForTesting):
1123
1124 2007-12-21  Dan Bernstein  <mitz@apple.com>
1125
1126         Reviewed by Mark Rowe.
1127
1128         - disable the back/forward cache in Windows DumpRenderTree. It is
1129           already disabled in Mac DumpRenderTree.
1130
1131         * DumpRenderTree/win/DumpRenderTree.cpp:
1132         (initializePreferences):
1133
1134 2007-12-13  Antti Koivisto  <antti@apple.com>
1135
1136         Reviewed by Darin and Steve.
1137         
1138         - check for QuickTime SDK on Windows.
1139         - build media support on Windows by default
1140
1141         * Scripts/build-webkit:
1142         * Scripts/webkitdirs.pm:
1143
1144 2007-12-21  Kevin Ollivier  <kevino@theolliviers.com>
1145
1146         Build script fix for buildbot.
1147
1148         * wx/build-wxwebkit:
1149
1150 2007-12-20  Eric Seidel  <eric@webkit.org>
1151
1152         Reviewed by mjs.
1153
1154         * Scripts/run-sunspider: change --runs default to 10 for better accuracy
1155
1156 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
1157
1158         Reviewed by Steve.
1159
1160         - <rdar://5656485> Drosera: Win: Nightly does not reliably connect to
1161         WebKit.
1162
1163         - Drosera and Safari need to use the same ProgIDs in order for
1164         CoCreateInstance to work properly.  The most robust way to do this is
1165         for WebKit to dynamically publish those ProgIDs.
1166
1167         * Drosera/win/DebuggerClient.cpp: Use the published ProgIDs
1168         (DebuggerClient::createWebViewWithRequest):
1169         * Drosera/win/Drosera.cpp: Use the published ProgIDs and rename some
1170         statics.
1171         (Drosera::initUI):
1172         (Drosera::attach):
1173         (Drosera::attemptToCreateServerConnection):
1174         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Fix a runtime failure.
1175         * Drosera/win/ServerConnection.cpp: Reformat the connection function and
1176         make use of the published ProgIDs.
1177         (ServerConnection::attemptToCreateServerConnection):
1178
1179 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
1180
1181         - <rdar://problem/5658317> REGRESSION: 20+ leaks seen on buildbots.
1182         - Build bot and leak fix.
1183
1184         * DumpRenderTree/LayoutTestController.cpp:
1185         (pathToLocalResourceCallback):
1186
1187 2007-12-19  David Kilzer  <ddkilzer@apple.com>
1188
1189         Make svn-apply/svn-unapply work with patches from git-format-patch.
1190
1191         Reviewed by Darin.
1192
1193         * Scripts/svn-apply:
1194         (patch): If 'Index:' can't be found in the text passed in, print it
1195         out with a warning and return early.
1196         * Scripts/svn-unapply:
1197         (patch): Ditto.
1198
1199 2007-12-18  Kevin Ollivier  <kevino@theolliviers.com>
1200
1201         Reviewed by Alp Toker.
1202
1203         Build related fixes.
1204
1205         * wx/build-wxwebkit:
1206         - Check to make sure the user is running a supported wx port
1207         - More robust checks for Cygwin
1208         - Only run install-unix-extras on Mac, it's not the right solution
1209           for Linux distros.
1210         - Remove outdated Linux instructions after successful build
1211         - Clean Bakefile-generated files during a clean operation
1212
1213 2007-12-18  Darin Adler  <darin@apple.com>
1214
1215         * Scripts/make-js-test-wrappers: Don't generate a wrapper for select-options-remove.js.
1216
1217 2007-12-18  Steve Falkenburg  <sfalken@apple.com>
1218
1219         Add script to run Drosera as part of the nightly.
1220         
1221         Reviewed by Kevin M.
1222
1223         * Scripts/run-drosera.cmd: Added.
1224
1225 2007-12-18  Darin Adler  <darin@apple.com>
1226
1227         * Scripts/do-webcore-rename: Remove a stray K.
1228
1229 2007-12-18  Darin Adler  <darin@apple.com>
1230
1231         * Scripts/do-webcore-rename: Plan more renaming.
1232
1233 2007-12-14  Juan A. Suarez Romero  <jasuarez@igalia.com>
1234
1235         Reviewed by Alp Toker.
1236
1237         http://bugs.webkit.org/show_bug.cgi?id=16042
1238         [GTK] Eliminate webkit_init()
1239
1240         Moving webkit initialization to WebView class init.
1241
1242         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1243         (main):
1244         * GtkLauncher/main.c:
1245         (main):
1246
1247 2007-12-17  Luca Bruno  <lethalman88@gmail.com>
1248
1249         Reviewed by Alp Toker.
1250
1251         http://bugs.webkit.org/show_bug.cgi?id=13542
1252         gdklauncher doesnt change URL in adress GTKEntry.
1253
1254         * GtkLauncher/main.c:
1255         (load_commit_cb): added
1256         (title_change_cb):
1257         (create_browser):
1258
1259 2007-12-16  Dimitri Glazkov  <dimitri@glazkov.com>
1260
1261         Reviewed by Adam Roben.
1262
1263         Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.
1264
1265         * FindSafari/FindSafari.cpp:
1266         (_tmain):
1267
1268 2007-12-16  Brent Fulgham  <bfulgham@gmail.com>
1269
1270         Reviewed by Adam Roben.
1271
1272         http://bugs.webkit.org/show_bug.cgi?id=16315
1273         FindSafari needs a path-only option.
1274
1275         * FindSafari/FindSafari.cpp:
1276         (_tmain):
1277
1278 2007-12-16  Alexey Proskuryakov  <ap@webkit.org>
1279
1280         Reviewed by Darin.
1281
1282         http://bugs.webkit.org/show_bug.cgi?id=16462
1283         REGRESSION: access keys broken on Windows
1284
1285         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Send system key events
1286         if Alt is pressed.
1287
1288 2007-12-15  Sam Weinig  <sam@webkit.org>
1289
1290         Reviewed by Mark Rowe.
1291
1292         Fix urlSuitableForTestResult to correctly identify wstring::npos as
1293         the case when wstring.find doesn't find anything.
1294
1295         * DumpRenderTree/win/DumpRenderTree.cpp:
1296         (urlSuitableForTestResult):
1297
1298 2007-12-15  Alp Toker  <alp@atoker.com>
1299
1300         GTK+ DRT build fix for GLib < 2.14.
1301
1302         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1303         (LayoutTestController::setWaitToDump):
1304
1305 2007-12-05  Mark Rowe  <mrowe@apple.com>
1306
1307         Reviewed by Alp Toker.
1308
1309         Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.  This prevents
1310         many layout tests from hanging while waiting on user responses to dialogs.
1311
1312         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1313         (invalidateAnyPreviousWaitToDumpWatchdog):
1314         (webViewScriptAlert):
1315         (webViewScriptPrompt):
1316         (webViewScriptConfirm):
1317         (main):
1318         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
1319         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1320         (waitToDumpWatchdogFired):
1321         (LayoutTestController::setWaitToDump):
1322
1323 2007-12-05  Mark Rowe  <mrowe@apple.com>
1324
1325         Reviewed by Alp Toker.
1326
1327         Flesh out DumpRenderTree for Gtk.  After these changes, the majority of the tests in fast/js pass.
1328
1329         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1330         (dumpFramesAsText): Don't print the frame name when dumping the main frame as text.
1331         (dump):
1332         (runTest):
1333         (webViewLoadStarted): Store the top frame when it starts loading so we can use it to determine when to dump.
1334         (webViewLoadFinished): Dump when the top frame load completes if we're not waiting for a JS callback and the
1335         work queue is empty.
1336         (webViewWindowObjectCleared): Set up window.layoutTestController.
1337         (webViewConsoleMessage): Match the console message format expected by the layout test results.
1338         (main): Hook up the new signals.
1339         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
1340         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Only notify done if the top frame has completed loading to avoid
1341         dumping multiple times.
1342         * Scripts/build-dumprendertree: Ensure build-dumprendertree is a no-op for Gtk too.
1343         * Scripts/run-webkit-tests: Teach run-webkit-tests that Gtk is like Qt in many ways.  Use run-launcher to open test results.
1344
1345 2007-12-14  Anders Carlsson  <andersca@apple.com>
1346
1347         Reviewed by Brady.
1348
1349         Assert that a web frame that's loading a resource always has either a data source or 
1350         a provisional data source.
1351         
1352         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1353         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1354
1355 2007-12-14  Darin Adler  <darin@apple.com>
1356
1357         - fix mistake causing nearly all tests to fail on Windows
1358
1359         * DumpRenderTree/win/UIDelegate.cpp:
1360         (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with
1361         npos, not 0. Also pass URL in to URL function rather than passing the entire message.
1362
1363         * DumpRenderTree/mac/UIDelegate.mm:
1364         (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather
1365         than passing the entire message.
1366
1367 2007-12-14  Darin Adler  <darin@apple.com>
1368
1369         - fix Tiger build
1370
1371         * DumpRenderTree/mac/UIDelegate.mm:
1372         (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any
1373         new-to-Leopard methods.
1374
1375 2007-12-14  Darin Adler  <darin@apple.com>
1376
1377         * DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method
1378         since it now triggers unwanted icon loading. We only had it because we implemented "all"
1379         delegate methods here.
1380
1381 2007-12-14  Anders Carlsson  <andersca@apple.com>
1382
1383         Reviewed by Darin and Geoff.
1384
1385         <rdar://problem/5619295> 
1386         REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
1387         
1388         Add property getting methods to the plug-in.
1389         
1390         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1391         (pluginInvoke):
1392
1393 2007-12-14  Kevin McCullough  <kmccullough@apple.com>
1394
1395         Reviewed by Darin.
1396
1397         - Layout test fix for mac. When dumped to the console local file paths
1398         now only show the name of the resource not the whole path.  This is to
1399         make the results machine and OS independent.
1400
1401         * DumpRenderTree/mac/UIDelegate.mm:
1402         (-[UIDelegate webView:addMessageToConsole:]):
1403
1404 2007-12-13  Kevin McCullough  <kmccullough@apple.com>
1405
1406         Reviewed by Adam.
1407
1408         - Layout tests fix.  We need a way to remove machine-dependent
1409         information from paths in layout test results. The UIDelegate now does
1410         this.
1411
1412         * DumpRenderTree/DumpRenderTree.h:
1413         * DumpRenderTree/win/DumpRenderTree.cpp:
1414         (urlSuitableForTestResult):
1415         * DumpRenderTree/win/DumpRenderTreeWin.h:
1416         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1417         * DumpRenderTree/win/UIDelegate.cpp:
1418         (UIDelegate::webViewAddMessageToConsole):
1419
1420 2007-12-13  Alp Toker  <alp@atoker.com>
1421
1422         Build fix for DRT breakage introduced in r28690.
1423
1424         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1425         (LayoutTestController::pathToLocalResource):
1426
1427 2007-12-12  Kevin McCullough  <kmccullough@apple.com>
1428
1429         Reviewed by Alice and Sam.
1430
1431         - <rdar://5621435> Need a way to specify local resources (being loaded
1432         from HTTP tests) on Windows.
1433         - Implemented pathToLocalResource which exposes the functionality of
1434         converting a given unix path to the correct location on Windows.
1435
1436         * DumpRenderTree/LayoutTestController.cpp:
1437         (pathToLocalResourceCallback):
1438         (LayoutTestController::staticFunctions):
1439         * DumpRenderTree/LayoutTestController.h:
1440         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1441         (LayoutTestController::pathToLocalResource):
1442         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1443         (LayoutTestController::pathToLocalResource):
1444
1445 2007-12-12  Anders Carlsson  <andersca@apple.com>
1446
1447         Reviewed by Sam.
1448
1449         <rdar://problem/5132003>
1450         dumpResourceLoadCallbacks is not implemented in DRT on Windows.
1451
1452         * DumpRenderTree/win/DumpRenderTree.cpp:
1453         (main):
1454         Set the resource load delegate.
1455         
1456         * DumpRenderTree/win/DumpRenderTree.vcproj:
1457         
1458         * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
1459         * DumpRenderTree/win/ResourceLoadDelegate.h: Added.
1460
1461 2007-12-12  Alexey Proskuryakov  <ap@webkit.org>
1462
1463         Reviewed by Adam Roben.
1464
1465         Fix conversion from double to LPARAM in dispatchMessage().
1466
1467         * DumpRenderTree/win/EventSender.cpp:
1468         (dispatchMessageCallback):
1469
1470 2007-12-11  Dan Bernstein  <mitz@apple.com>
1471
1472         Reviewed by Mark Rowe and Sam Weinig too!
1473
1474         - added Helvetica Oblique and Helvetica Bold Oblique to the list of
1475           fonts DumpRenderTree registers.
1476
1477         * DumpRenderTree/win/DumpRenderTree.cpp:
1478         (initialize):
1479
1480 2007-12-11  Brady Eidson  <beidson@apple.com>
1481
1482         Reviewed by Anders
1483
1484         Make DumpRenderTree on mac use its own path for Databases testing
1485
1486         * DumpRenderTree/mac/DumpRenderTree.mm:
1487         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree 
1488           for future DRT-only use, then use it to construct the Databases path and set that default
1489
1490 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
1491
1492         Reviewed by Darin.
1493
1494         <rdar://problem/5535636>
1495         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
1496
1497         http://bugs.webkit.org/show_bug.cgi?id=13916
1498         JavaScript detects Tab as a character input on a textfield validation
1499
1500         * DumpRenderTree/mac/EventSendingController.mm:
1501         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
1502         Dispatch a keyup to better match what happens when a key is physically pressed.
1503
1504         * DumpRenderTree/win/EventSender.cpp:
1505         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
1506         returning from keyDown().
1507         (getConstantCallback): Fixed a couple copy/paste mistakes.
1508
1509 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
1510
1511         Reviewed by Oliver.
1512
1513         - <rdar://5599845> Drosera: Does not show loal files in the file list
1514         on the left side.
1515
1516         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
1517         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
1518         so the open source community can build.
1519
1520 2007-12-10  Brady Eidson  <beidson@apple.com>
1521
1522         Rubberstamped by Sam Weinig
1523
1524         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
1525
1526         * DumpRenderTree/mac/UIDelegate.mm:
1527         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
1528         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
1529
1530 2007-12-08  Oliver Hunt  <oliver@apple.com>
1531
1532         Reviewed by Sam W.
1533
1534         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
1535         
1536         Fixes <rdar://problem/5620249> Must disable SVG animation
1537         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
1538         
1539         In order to allow finer grained control over the set of SVG features
1540         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
1541         distinct flags:
1542         ENABLE_SVG_ANIMATION
1543         ENABLE_SVG_FILTERS
1544         ENABLE_SVG_FONTS
1545         ENABLE_SVG_AS_IMAGE
1546         ENABLE_SVG_USE
1547         
1548         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
1549         
1550         Script handles all the new build flags, and allows --svg-experimental
1551         to automatically enable all features.
1552
1553         * Scripts/build-webkit:
1554
1555 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
1556
1557         Fix version parsing.
1558
1559         Rubber-stamped by Oliver.
1560
1561         * Drosera/win/Drosera.vcproj/auto-version.sh:
1562
1563 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
1564
1565         Build modifications for Drosera.
1566
1567         Reviewed by Adam.
1568
1569         * Drosera/DroseraWin.make: Added.
1570         * Drosera/win/Drosera.vcproj/Drosera.rc:
1571         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1572         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
1573         * Drosera/win/Drosera.vcproj/VERSION: Added.
1574         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
1575
1576 2007-12-06  Adam Roben  <aroben@apple.com>
1577
1578         Explicitly turn on the Mac font ascent hack on Windows
1579
1580         This keeps our font metrics matching those from Mac.
1581
1582         Reviewed by Hyatt.
1583
1584         * DumpRenderTree/win/DumpRenderTree.cpp:
1585         (main):
1586
1587 2007-12-06  Anders Carlsson  <andersca@apple.com>
1588
1589         Rename main.c to main.cpp here too.
1590         
1591         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
1592
1593 2007-12-06  Sam Weinig  <sam@webkit.org>
1594
1595         Rubber stamped by Geoff.
1596
1597         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
1598
1599 2007-12-06  Darin Adler  <darin@apple.com>
1600
1601         * Scripts/do-webcore-rename: Some more renaming plans.
1602
1603 2007-12-06  Anders Carlsson  <andersca@apple.com>
1604
1605         Restore implementation of testGetIntIdentifier that was accidentally
1606         removed somehow (possibly when I made PluginObject be a cpp file).
1607         
1608         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1609         (pluginInvoke):
1610
1611 2007-12-05  Anders Carlsson  <andersca@apple.com>
1612
1613         Make the entry points extern "C".
1614         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1615         
1616 2007-12-05  Anders Carlsson  <andersca@apple.com>
1617
1618         C++ warning fixes.
1619         
1620         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1621         (NPP_New):
1622         (NPP_Destroy):
1623         (NPP_SetWindow):
1624         (NPP_NewStream):
1625         (NPP_HandleEvent):
1626         (NPP_URLNotify):
1627         (NPP_GetValue):
1628
1629 2007-12-05  Anders Carlsson  <andersca@apple.com>
1630
1631         Add the .cpp files to the TestNetscapePlugIn target.
1632
1633         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1634
1635 2007-12-05  Anders Carlsson  <andersca@apple.com>
1636
1637         Reviewed by Geoff.
1638         
1639         Rename the TestNetscapePlugIn .c files to be .cpp.
1640
1641         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1642         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
1643         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
1644         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
1645         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
1646         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
1647         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
1648         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1649
1650 2007-12-05  Adam Roben  <aroben@apple.com>
1651
1652         Fix case of keypresses from the Windows implementation of eventSender.keyDown
1653
1654         This fixes several regression tests.
1655
1656         Reviewed by Alice.
1657
1658         * DumpRenderTree/win/EventSender.cpp:
1659         (keyDownCallback): Virtual keycodes for ASCII characters are always
1660         uppercase, so we need to check the case of the original character
1661         passed in to eventSender.keyDown.
1662
1663 2007-12-05  Adam Roben  <aroben@apple.com>
1664
1665         Learn from Tim's mistakes
1666
1667         * DumpRenderTree/win/DumpRenderTree.cpp:
1668         (runTest): Reset the authorAndUserStylesEnabled preference for each
1669         test.
1670
1671 2007-12-05  Alp Toker  <alp@atoker.com>
1672
1673         Reviewed by Mark Rowe.
1674
1675         Initialize GTK+ and WebKit so the tests can run.
1676
1677         Reorganize the headers a little.
1678
1679         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1680         (main):
1681
1682 2007-12-04  Anders Carlsson  <andersca@apple.com>
1683
1684         Remove IWebScriptScope include.
1685         
1686         * Drosera/win/DebuggerDocumentPlatform.cpp:
1687
1688 2007-12-04  Sam Weinig  <sam@webkit.org>
1689
1690         Rubber stamped by Mark Rowe.
1691
1692         Define CF as platform for mac and revert r28409
1693
1694         * DumpRenderTree/DumpRenderTree.h:
1695         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1696
1697 2007-12-04  Sam Weinig  <sam@webkit.org>
1698
1699         Define CF as platform for windows.
1700
1701         Reviewed by Adam Roben.
1702
1703         * DumpRenderTree/win/DumpRenderTreeWin.h:
1704
1705 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
1706
1707         Reviewed by Adam and Darin.
1708
1709         - Removed a needless BSTR cleanup.
1710
1711         * Drosera/win/DebuggerDocumentPlatform.cpp:
1712         (DebuggerDocument::getPlatformCurrentFunctionStack):
1713
1714 2007-11-27  Adam Roben  <aroben@apple.com>
1715
1716         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
1717
1718         Reviewed by Maciej.
1719
1720         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1721         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
1722
1723 2007-12-04  Alp Toker  <alp@atoker.com>
1724
1725         Prospective Win DRT build fix.
1726
1727         * DumpRenderTree/DumpRenderTree.h:
1728
1729 2007-12-04  Alp Toker  <alp@atoker.com>
1730
1731         Fix a clobbered copyright header.
1732
1733         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1734
1735 2007-12-04  Xan Lopez  <xan@gnome.org>
1736
1737         Reviewed by Alp Toker.
1738
1739         http://bugs.webkit.org/show_bug.cgi?id=15561
1740         GTK port needs DumpRenderTree implementation
1741
1742         Start work on the GTK+ DRT.
1743
1744         This does not work yet, and there are a few lingering style issues
1745         (nothing major) but this patch has been stuck in the bug tracker for
1746         too long already.
1747
1748         * DumpRenderTree/DumpRenderTree.h:
1749         * DumpRenderTree/gtk: Added.
1750         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
1751         (autocorrectURL):
1752         (shouldLogFrameLoadDelegates):
1753         (dumpFrameScrollPosition):
1754         (displayWebView):
1755         (appendString):
1756         (dumpFramesAsText):
1757         (dumpRenderTreeAsText):
1758         (dump):
1759         (runTest):
1760         (main):
1761         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
1762         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
1763         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
1764         (GCController::collect):
1765         (GCController::collectOnAlternateThread):
1766         (GCController::getJSObjectCount):
1767         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
1768         (LayoutTestController::~LayoutTestController):
1769         (LayoutTestController::addDisallowedURL):
1770         (LayoutTestController::clearBackForwardList):
1771         (LayoutTestController::copyDecodedHostName):
1772         (LayoutTestController::copyEncodedHostName):
1773         (LayoutTestController::display):
1774         (LayoutTestController::keepWebHistory):
1775         (LayoutTestController::notifyDone):
1776         (LayoutTestController::queueBackNavigation):
1777         (LayoutTestController::queueForwardNavigation):
1778         (LayoutTestController::queueLoad):
1779         (LayoutTestController::queueReload):
1780         (LayoutTestController::queueScript):
1781         (LayoutTestController::setAcceptsEditing):
1782         (LayoutTestController::setCustomPolicyDelegate):
1783         (LayoutTestController::setMainFrameIsFirstResponder):
1784         (LayoutTestController::setTabKeyCyclesThroughElements):
1785         (LayoutTestController::setUseDashboardCompatibilityMode):
1786         (LayoutTestController::setUserStyleSheetEnabled):
1787         (LayoutTestController::setUserStyleSheetLocation):
1788         (LayoutTestController::setWindowIsKey):
1789         (LayoutTestController::setWaitToDump):
1790         (LayoutTestController::windowCount):
1791         (LayoutTestController::setPrivateBrowsingEnabled):
1792         (LayoutTestController::setAuthorAndUserStylesEnabled):
1793         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
1794         (JSStringCopyUTF8CString):
1795         (LoadItem::invoke):
1796         (ReloadItem::invoke):
1797         (ScriptItem::invoke):
1798         (BackForwardItem::invoke):
1799
1800 2007-12-03  Sam Weinig  <sam@webkit.org>
1801
1802         Move JavaScriptCore thread testing code to pthread specific directory
1803         and remove the dependance on CoreFoundation by using WTF::HashSet.
1804
1805         Reviewed by Geoff and Oliver.
1806
1807         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1808         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
1809         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
1810         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
1811         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
1812         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
1813         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
1814         * DumpRenderTree/pthreads: Added.
1815         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
1816         (javaScriptThreads):
1817         (runJavaScriptThread):
1818         (startJavaScriptThreads):
1819         (stopJavaScriptThreads):
1820
1821 2007-12-03  Andrew Bonventre  <andybons@google.com>
1822
1823         Reviewed by Darin Adler.
1824
1825         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
1826         Symbol lookup menu broken in debugger view
1827
1828         * Drosera/debugger.js: Fixed javascript error where document property
1829         should have been used instead of contentDocument in switchFunction that
1830         was breaking the select symbol dropdown menu.  This is because
1831         window.frames will return a Window object and not a frame object like
1832         the author was originally expecting.
1833
1834 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
1835
1836         Reviewed by Adam.
1837
1838         - <rdar://5618942> Drosera: Console window does not process everything
1839         correctly.
1840         - <rdar://5619005> Drosera: could be sped up by moving the 
1841         WebScriptScope stuff into the WebScriptCallFrame.
1842         - Now the console can correctly process objects and does not receive
1843         notifications from JavaScriptCore about the JavaScript in Drosera's
1844         own process.
1845
1846         * Drosera/win/DebuggerDocumentPlatform.cpp:
1847         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1848         (DebuggerDocument::platformValueForScopeVariableNamed):
1849
1850 2007-12-03  Stephanie  <slewis@apple.com>
1851
1852         Reviewed by Darin.
1853
1854         Check to see if we are building a debug root
1855
1856         * Scripts/check-for-global-initializers: 
1857
1858 2007-12-03  Dan Bernstein  <mitz@apple.com>
1859
1860         Reviewed by Darin Adler.
1861
1862         - added a testGetIntIdentifier() method to TestNetscapePlugIn
1863
1864         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
1865         (pluginInvoke):
1866
1867 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
1868
1869         Reviewed by Oliver.
1870
1871         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
1872         in a more fine-grained manner than eventSender.keyDown().
1873
1874         * DumpRenderTree/win/EventSender.cpp:
1875         (getConstantCallback):
1876         (dispatchMessageCallback):
1877
1878 2007-12-02  Darin Adler  <darin@apple.com>
1879
1880         * Scripts/do-webcore-rename: More planned renaming.
1881
1882 2007-12-02  Sam Weinig  <sam@webkit.org>
1883
1884         Rubber stamped by Anders.
1885
1886         Use [NSURL absoluteString] instead of [NSURL description] in order to get
1887         more uniform results cross platform.
1888
1889         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1890         (-[NSURL _drt_descriptionSuitableForTestResult]):
1891
1892 2007-12-02  Sam Weinig  <sam@webkit.org>
1893
1894         Rubber stamped by Niko.
1895
1896         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
1897
1898         * DumpRenderTree/win/DumpRenderTree.cpp:
1899         * DumpRenderTree/win/DumpRenderTree.vcproj:
1900         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
1901         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
1902         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
1903         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
1904
1905 2007-12-01  Alp Toker  <alp@atoker.com>
1906
1907         Reviewed by Adam Roben.
1908
1909         Make use of the newly introduced webkit.h convenience header.
1910
1911         * GtkLauncher/main.c:
1912
1913 2007-12-01  Adam Treat  <treat@kde.org>
1914
1915         Reviewed by Simon.
1916
1917         * Check to see if the directory exists and exit if not.
1918
1919         * DumpRenderTree/qt/main.cpp:
1920         (main):
1921
1922 2007-12-01  Adam Treat  <treat@kde.org>
1923
1924         Reviewed by Simon.
1925
1926         * Don't hide symbols when in Debug mode
1927         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
1928
1929
1930         * DumpRenderTree/qt/main.cpp:
1931         (messageHandler):
1932
1933 2007-11-30  Alp Toker  <alp@atoker.com>
1934
1935         Reviewed by Adam Roben.
1936
1937         http://bugs.webkit.org/show_bug.cgi?id=15691
1938         [GTK] Public API does not follow GTK+ conventions
1939
1940         Refactor the WebKit/GTK+ public API. Changes:
1941           WebKitPage -> WebKitWebView
1942           WebKitFrame -> WebKitWebFrame
1943
1944         Public API source and header names have been updated to mirror the API
1945         changes.
1946
1947         The API is now kept in WebKit/gtk/WebView to match other ports in the
1948         same class such as Mac and Win.
1949
1950         * GtkLauncher/main.c:
1951         (activate_uri_entry_cb):
1952         (link_hover_cb):
1953         (title_change_cb):
1954         (progress_change_cb):
1955         (go_back_cb):
1956         (go_forward_cb):
1957         (create_browser):
1958         (main):
1959
1960 2007-11-30  Adam Roben  <aroben@apple.com>
1961
1962         Hopefully the final build fix
1963
1964         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
1965         pull in WTF's assertion/logging functions.
1966
1967 2007-11-30  Adam Roben  <aroben@apple.com>
1968
1969         Another build fix
1970
1971         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
1972         WebKit.lib.
1973
1974 2007-11-30  Adam Roben  <aroben@apple.com>
1975
1976         Debug build fix
1977
1978         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
1979         configuration.
1980         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
1981         projects.
1982         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
1983         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
1984         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
1985
1986 2007-11-30  Sam Weinig  <sam@webkit.org>
1987
1988         Reviewed by Adam Roben.
1989
1990         Fix drawSelectionRect to actually draw the selection rect.
1991
1992         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1993         (drawSelectionRect):
1994
1995 2007-11-30  Darin Adler  <darin@apple.com>
1996
1997         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
1998
1999 2007-11-30  Darin Adler  <darin@apple.com>
2000
2001         * Scripts/do-webcore-rename: Get ready for some future renaming.
2002
2003 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
2004
2005         Reviewed by Adam.
2006
2007         - Removed some unnecessary functions and changed an unused return type. 
2008
2009         * Drosera/win/DebuggerClient.cpp:
2010         (registerConsoleClass):
2011         * Drosera/win/DebuggerClient.h:
2012         * Drosera/win/Drosera.cpp:
2013         (registerDroseraClass):
2014
2015 2007-11-28  Alp Toker  <alp@atoker.com>
2016
2017         Reviewed by Timothy Hatcher.
2018
2019         http://bugs.webkit.org/show_bug.cgi?id=16174
2020         [GTK] Use "URI" not "URL" in public API
2021
2022         Replace use of the term "URL" with "URI" in public headers,
2023         documentation and some internal code to match GLib/GTK+ convention.
2024
2025         This is now mentioned in the API guidelines:
2026           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
2027
2028         * GtkLauncher/main.c:
2029         (activate_uri_entry_cb):
2030         (title_change_cb):
2031         (create_toolbar):
2032         (main):
2033
2034 2007-11-29  Anders Carlsson  <andersca@apple.com>
2035
2036         Reviewed by Sam.
2037
2038         <rdar://problem/5230478>
2039         FrameLoadDelegate callbacks are not dumped in DRT.
2040         
2041         * DumpRenderTree/win/DumpRenderTree.cpp:
2042         (shouldLogFrameLoadDelegates):
2043         (runTest):
2044         (main):
2045         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
2046         (BSTRtoString):
2047         (descriptionSuitableForTestResult):
2048         (FrameLoadDelegate::QueryInterface):
2049         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
2050         (FrameLoadDelegate::didFailProvisionalLoadWithError):
2051         (FrameLoadDelegate::didCommitLoadForFrame):
2052         (FrameLoadDelegate::didFinishLoadForFrame):
2053         (FrameLoadDelegate::willCloseFrame):
2054         (FrameLoadDelegate::didClearWindowObject):
2055         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
2056         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
2057         * DumpRenderTree/win/FrameLoaderDelegate.h:
2058         (FrameLoadDelegate::windowScriptObjectAvailable):
2059         (FrameLoadDelegate::didFirstLayoutInFrame):
2060
2061 2007-11-29  Sam Weinig  <sam@webkit.org>
2062
2063         Reviewed by Anders.
2064
2065         Add database quota UIDelegates methods to DRT UIDelegate.
2066
2067         * DumpRenderTree/mac/UIDelegate.mm:
2068         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
2069         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
2070
2071 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
2072
2073         Reviewed by Sam.
2074
2075         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
2076         dying and vice versa.
2077         - This fix will allow Drosera and Safari to reconnect if either of them
2078         closes correctly, but does not fix the case where one of them dies
2079         silently.
2080
2081         * Drosera/win/ServerConnection.cpp:
2082         (ServerConnection::attemptToCreateServerConnection): Added a safety
2083         check, because it's possilbe to try to connect to a server that's dying.
2084         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
2085         the server has died.
2086         * Drosera/win/ServerConnection.h: Added the new function and removed
2087         an unnecessary member.
2088
2089 2007-11-29  Anders Carlsson  <andersca@apple.com>
2090
2091         * DumpRenderTree/win/DumpRenderTree.vcproj:
2092         Add shlwapi.lib to all configurations.
2093
2094 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
2095
2096         - Build fix.  Added additional includes for VS Express to the Release
2097         project.
2098
2099         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2100
2101 2007-11-29  Anders Carlsson  <andersca@apple.com>
2102
2103         Reviewed by Adam.
2104
2105         <rdar://problem/5132005>
2106         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
2107         
2108         * DumpRenderTree/win/DumpRenderTree.vcproj:
2109         Add shlwapi.lib
2110         
2111         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2112         (LayoutTestController::setUserStyleSheetEnabled):
2113         Implement this.
2114         
2115         (appendComponentToPath):
2116         New method which wraps the Win32 API PathAppend.
2117         
2118         (followShortcuts):
2119         New method which checks if a file points to a shortcut and
2120         follows the shortcut.
2121         
2122         (resolveCygwinPath):
2123         New method that takes a cygwin unix-style path and returns the Win32 path.
2124         
2125         (cfStringRefToWString):
2126         
2127         (LayoutTestController::setUserStyleSheetLocation):
2128         Implement this.
2129
2130 2007-11-29  Alice Liu  <alice.liu@apple.com>
2131
2132         Reviewed by Adam.
2133
2134         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
2135
2136         * DumpRenderTree/win/EventSender.cpp:
2137         (keyDownCallback):
2138         uppercase letters were being sent as lowercase letters without the shift key down.
2139
2140 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
2141
2142         - Windows build fix. VS express needs some love.
2143
2144         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2145
2146 2007-11-28  Darin Adler  <darin@apple.com>
2147
2148         Reviewed by Adam Roben.
2149
2150         * DumpRenderTree/mac/EventSendingController.mm:
2151         (-[EventSendingController keyDown:withModifiers:]):
2152         Send capital letters through as lowercase letters with the shift key down
2153         rather than sending them as if they were highly unusual "capital letter keys".
2154
2155         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
2156         where you need to update results and more tests are failing than before.
2157
2158 2007-11-28  Anders Carlsson  <andersca@apple.com>
2159
2160         Reviewed by Darin.
2161
2162         <rdar://problem/5132001>
2163         contextClick is not implemented in DRT on Windows.
2164         
2165         * DumpRenderTree/win/EventSender.cpp:
2166         (contextClickCallback):
2167         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
2168         by a WM_RBUTTONUP message.
2169         
2170         * DumpRenderTree/win/UIDelegate.cpp:
2171         (UIDelegate::hasCustomMenuImplementation):
2172         (UIDelegate::trackCustomPopupMenu):
2173         * DumpRenderTree/win/UIDelegate.h:
2174         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
2175         menu from being shown (and causing the DRT to hang).
2176
2177 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
2178
2179         Reviewed by Darin.
2180
2181         Fix DumpRenderTree ObjC bug comparing strings.
2182
2183         * DumpRenderTree/mac/ObjCController.m:
2184         (-[ObjCController identityIsEqual::]): Compare strings with string
2185         equality instead of identiy equality.
2186
2187 2007-11-27  Timothy Hatcher  <timothy@apple.com>
2188
2189         Reviewed by Sam.
2190
2191         Reset the authorAndUserStylesEnabled preference
2192         back to YES for each test. Fixes the broken tests.
2193
2194         * DumpRenderTree/mac/DumpRenderTree.mm:
2195         (resetWebViewToConsistentStateBeforeTesting):
2196
2197 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
2198
2199         Reviewed by Adam.
2200
2201         - Drosera now displays the console window, although it cannot currently
2202         process JavaScript.
2203
2204         * Drosera/win/DebuggerClient.cpp: Shows the console window.
2205         (registerConsoleClass): Implemented.
2206         (consoleWndProc): Implemented.
2207         (DebuggerClient::onSize): Implemented.
2208         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
2209         new window.
2210         * Drosera/win/DebuggerClient.h: Added needed method and members for 
2211         creating and maintaining a new window.
2212         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
2213         lines of code to more appropriate places.
2214         (Drosera::handleCommand):
2215         (Drosera::initUI):
2216         (Drosera::onSize):
2217         (Drosera::attach):
2218
2219 2007-11-27  Timothy Hatcher  <timothy@apple.com>
2220
2221         Reviewed by Dave Hyatt.
2222
2223         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
2224         
2225         Add support for disabling author and user styles for testing.
2226
2227         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2228         * DumpRenderTree/LayoutTestController.cpp:
2229         (setAuthorAndUserStylesEnabledCallback):
2230         (LayoutTestController::staticFunctions):
2231         * DumpRenderTree/LayoutTestController.h:
2232         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2233         (LayoutTestController::setAuthorAndUserStylesEnabled):
2234         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2235         (LayoutTestController::setAuthorAndUserStylesEnabled):
2236
2237 2007-11-26  Dan Bernstein  <mitz@apple.com>
2238
2239         - Tiger build fix.
2240
2241         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2242
2243 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
2244
2245         Reviewed by Maciej.
2246
2247         - Implemented displaying variables for Drosera on Win.
2248
2249         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
2250         that retrieve variables to not hold onto the return value since it's
2251         not returned.  Also changed to use the new signatures of the retrieval
2252         functions.
2253         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2254         (DebuggerDocument::platformValueForScopeVariableNamed):
2255         * Drosera/win/Drosera.cpp: Removed a needless TODO.
2256         (droseraWndProc):
2257
2258 2007-11-26  Sam Weinig  <sam@webkit.org>
2259
2260         Cleanup names of painting and repainting functions.
2261
2262         Reviewed by Adam Roben.
2263
2264         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2265         (drawSelectionRect): was drawSelectionRectIntoContext.
2266         (dumpWebViewAsPixelsAndCompareWithExpected):
2267         * DumpRenderTree/cg/PixelDumpSupportCG.h:
2268         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2269         (paintWebView): was drawWebViewIntoContext.
2270         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
2271
2272 2007-11-26  Sam Weinig  <sam@webkit.org>
2273
2274         Reviewed by Dan Bernstein.
2275
2276         - Leopard build fix
2277
2278         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2279
2280 2007-11-26  Sam Weinig  <sam@webkit.org>
2281
2282         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
2283         Use shared PixelDumpSupport for Mac DRT
2284
2285         Reviewed by Adam Roben.
2286
2287         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2288         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
2289         * DumpRenderTree/cg/ImageDiffCG.cpp:
2290         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2291         (drawSelectionRectIntoContext):
2292         (dumpWebViewAsPixelsAndCompareWithExpected):
2293         * DumpRenderTree/cg/PixelDumpSupportCG.h:
2294         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2295         * DumpRenderTree/mac/DumpRenderTree.mm:
2296         (dump):
2297         * DumpRenderTree/mac/ImageDiff.m: Removed.
2298         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
2299         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
2300         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
2301         (setDefaultColorProfileToRGB):
2302         (getBitmapContextFromWebView):
2303         (drawWebViewIntoContext):
2304         (repaintWithVerticalSweep):
2305         (repaintWithHorizontalSweep):
2306         (getSelectionRect):
2307         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
2308
2309 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
2310
2311         Bug 16052: prepare-ChangeLog doesn't report deleted files
2312         <http://bugs.webkit.org/show_bug.cgi?id=16052>
2313
2314         Reviewed by Sam.
2315
2316         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
2317
2318 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
2319
2320         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
2321         <http://bugs.webkit.org/show_bug.cgi?id=15864>
2322
2323         Reviewed by Adam.
2324
2325         Roll functionality of merge-changelog into resolve-ChangeLogs
2326         script.  The script now checks for ChangeLog.rej and
2327         ChangeLog.orig files first.  If it finds them, it uses the
2328         ChangeLog.rej file as a patch (in old contextual diff format) to
2329         apply with --fuzz=3.
2330
2331         * Scripts/merge-changelog: Removed.
2332         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
2333
2334 2007-11-25  Sam Weinig  <sam@webkit.org>
2335
2336         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
2337
2338         Reviewed by Mark Rowe.
2339
2340         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2341         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2342         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2343         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
2344         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
2345
2346 2007-11-25  Sam Weinig  <sam@webkit.org>
2347
2348         Convert DumpRenderTree to ues .xcconfig files.
2349
2350         Reviewed by Mark Rowe.
2351
2352         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2353         * DumpRenderTree/mac/Configurations: Added.
2354         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
2355         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
2356         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
2357
2358 2007-11-25  Sam Weinig  <sam@webkit.org>
2359
2360         Add ForwardingHeaders to wtf for DumpRenderTree.
2361
2362         Reviewed by Mark Rowe.
2363
2364         * DumpRenderTree/DumpRenderTree.h:
2365         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2366         * DumpRenderTree/ForwardingHeaders: Added.
2367         * DumpRenderTree/ForwardingHeaders/wtf: Added.
2368         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
2369         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
2370         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
2371         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
2372         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
2373         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
2374         * DumpRenderTree/LayoutTestController.cpp:
2375         * DumpRenderTree/WorkQueue.cpp:
2376         * DumpRenderTree/mac/DumpRenderTree.mm:
2377         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2378         * DumpRenderTree/mac/JavaScriptThreading.cpp:
2379         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2380         * DumpRenderTree/mac/ObjCController.m:
2381         * DumpRenderTree/mac/UIDelegate.mm:
2382         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2383
2384 2007-11-25  Adam Roben  <aroben@apple.com>
2385
2386         Fix some test failures caused by r28019
2387
2388         Now that stdout is in binary mode, we need to always use printf
2389         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
2390         the output.
2391
2392         Reviewed by Sam.
2393
2394         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
2395         printf.
2396         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2397         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2398         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2399         (UIDelegate::webViewAddMessageToConsole):
2400
2401 2007-11-25  Adam Roben  <aroben@apple.com>
2402
2403         Set the font smoothing preference in DRT
2404
2405         This makes the pixel results on Windows closer to the Mac results.
2406
2407         Reviewed by Mitz.
2408
2409         * DumpRenderTree/win/DumpRenderTree.cpp:
2410         (initializePreferences):
2411
2412 2007-11-25  Adam Roben  <aroben@apple.com>
2413
2414         Port ImageDiff to CG and C++
2415
2416         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
2417         <rdar://5071708>
2418
2419         Reviewed by Sam.
2420
2421         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
2422         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
2423         (main):
2424         (createImageFromStdin):
2425         (compareImages):
2426         (getDifferenceBitmap):
2427         (computePercentageDifferent):
2428         * DumpRenderTree/win/ImageDiff.vcproj: Added.
2429
2430 2007-11-25  Adam Roben  <aroben@apple.com>
2431
2432         Fix image diff link generation on Windows
2433
2434         Reviewed by Sam.
2435
2436         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
2437         to toURL.
2438
2439 2007-11-25  Adam Roben  <aroben@apple.com>
2440
2441         Implement pixel dumping in Windows DRT
2442
2443         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
2444         <rdar://5071708>
2445
2446         Reviewed by Sam.
2447
2448         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
2449         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
2450         Content-Length header.
2451         (getMD5HashStringForBitmap):
2452         (dumpWebViewAsPixelsAndCompareWithExpected):
2453         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
2454         * DumpRenderTree/win/DumpRenderTree.cpp:
2455         (dump): Do a pixel dump if requested.
2456         (main): Parse pixel test options.
2457         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
2458         the cg/ subdirectory to the include path.
2459         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
2460         available in a header or import library, so we have to go through this
2461         LoadLibrary/GetProcAddress dance to use them.
2462         (cryptDLL):
2463         (init):
2464         (update):
2465         (final):
2466         (MD5_Init):
2467         (MD5_Update):
2468         (MD5_Final):
2469         * DumpRenderTree/win/MD5.h: Added.
2470         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
2471         moved up to the top level to share it with Mac eventually.
2472         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
2473         (getBitmapContextFromWebView): Forces the WebView to paint using a
2474         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
2475
2476 2007-11-25  Adam Roben  <aroben@apple.com>
2477
2478         Clean up Windows DRT's option parsing a little bit
2479
2480         Reviewed by Sam.
2481
2482         * DumpRenderTree/win/DumpRenderTree.cpp:
2483         (main): Put non-option arguments into a Vector.
2484
2485 2007-11-25  Adam Roben  <aroben@apple.com>
2486
2487         Make Windows DRT stop changing LF into CRLF
2488
2489         Reviewed by Sam.
2490
2491         * DumpRenderTree/win/DumpRenderTree.cpp:
2492         (main): Put stdout in binary mode.
2493         * Scripts/run-webkit-tests: Remove the CRLF hack.
2494
2495 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
2496
2497         Removed empty directory.
2498
2499         * Scripts/resources: Removed.
2500
2501 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
2502
2503         Fix bisect-builds to work with recent WebKit nightly builds.
2504
2505         Reviewed by Dan.
2506
2507         * Scripts/bisect-builds: Check for the 
2508         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
2509         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
2510         to WebKit.app/Contents/Resources.
2511
2512 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
2513
2514         Reviewed by Maciej.
2515
2516         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
2517         not closed (affects digg.com)
2518
2519         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
2520         one after finishing with a test to avoid having its delayed onload handler firing when
2521         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
2522         but it helps somewhat.
2523
2524 2007-11-22  Mark Rowe  <mrowe@apple.com>
2525
2526         Reviewed by Alp Toker.
2527
2528         Fix build-webkit to propagate make's exit status if it fails.
2529
2530         * Scripts/webkitdirs.pm:
2531
2532 2007-11-22  Dan Bernstein  <mitz@apple.com>
2533
2534         Reviewed by Mark Rowe.
2535
2536         - fix crash when running pixel tests
2537
2538         * DumpRenderTree/mac/DumpRenderTree.mm:
2539         (dumpRenderTree): Parse the command line options before setting up the
2540         environment so that we know if we need to set up the pixel dump
2541         machinery.
2542
2543 2007-11-21  Eric Seidel  <eric@webkit.org>
2544
2545         Speculative build fix for Tiger.
2546
2547         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
2548
2549 2007-11-21  Eric Seidel  <eric@webkit.org>
2550
2551         Reviewed by Tim Hatcher.
2552
2553         Break out more of DumpRenderTree.mm into individual files
2554
2555         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2556         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
2557         (checkedMalloc):
2558         (checkedRealloc):
2559         (makeLargeMallocFailSilently):
2560         * DumpRenderTree/mac/CheckedMalloc.h: Added.
2561         * DumpRenderTree/mac/DumpRenderTree.mm:
2562         (crashHandler):
2563         (dump):
2564         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2565         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
2566         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
2567         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2568         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2569         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
2570         (javaScriptThreads):
2571         (runJavaScriptThread):
2572         (startJavaScriptThreads):
2573         (stopJavaScriptThreads):
2574         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
2575         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
2576         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
2577         (restoreColorSpace):
2578         (setDefaultColorProfileToRGB):
2579         (initializeColorSpaceAndScreeBufferForPixelTests):
2580         (md5HashStringForBitmap):
2581         (dumpWebViewAsPixelsAndCompareWithExpected):
2582
2583 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
2584
2585         Move install-unix-extras to wx directory as it seems only to be used by that 
2586         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
2587         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
2588         have install-unix-extras install into WebKitLibraries as per
2589         convention.
2590         
2591         Reviewed by Mark Rowe.
2592
2593         * Scripts/install-unix-extras: Removed.
2594         * wx/build-wxwebkit:
2595         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
2596
2597 2007-11-21  Eric Seidel  <eric@webkit.org>
2598
2599         Reviewed by Adam.
2600
2601         More refactoring for greater code readability
2602
2603         * DumpRenderTree/mac/DumpRenderTree.mm:
2604         (initializeGlobalsFromCommandLineOptions):
2605         (initializeColorSpaceAndScreeBufferForPixelTests):
2606         (addTestPluginsToPluginSearchPath):
2607         (useLongRunningServerMode):
2608         (runTestingServerLoop):
2609         (prepareConsistentTestingEnvironment):
2610         (dumpRenderTree):
2611         (main):
2612         (dumpFramesAsText):
2613         (dumpBackForwardListForWebView):
2614         (sizeWebViewForCurrentTest):
2615         (methodNameStringForFailedTest):
2616         (dumpBackForwardListForAllWindows):
2617         (dumpWebViewAsPixelsAndCompareWithExpected):
2618         (invalidateAnyPreviousWaitToDumpWatchdog):
2619         (dump):
2620         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2621         * DumpRenderTree/mac/UIDelegate.mm:
2622         (-[UIDelegate webView:createWebViewWithRequest:]):
2623
2624 2007-11-21  Eric Seidel  <eric@webkit.org>
2625
2626         Reviewed by Tim Hatcher.
2627
2628         Abstract more of DRT into static methods
2629
2630         * DumpRenderTree/mac/DumpRenderTree.mm:
2631         (setDefaultsToConsistentValuesForTesting):
2632         (setupSignalHandlers):
2633         (allocateGlobalControllers):
2634         (releaseAndZero):
2635         (releaseGlobalControllers):
2636         (dumpRenderTree):
2637         (shouldLogFrameLoadDelegates):
2638         (createCFURLFromPathOrURL):
2639         (resetWebViewToConsistentStateBeforeTesting):
2640         (runTest):
2641
2642 2007-11-21  Eric Seidel  <eric@webkit.org>
2643
2644         Reviewed by Tim Hatcher.
2645
2646         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
2647
2648         * DumpRenderTree/DumpRenderTree.h:
2649         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2650         * DumpRenderTree/mac/DumpRenderTree.mm:
2651         (dumpRenderTree):
2652         (dump):
2653         (runTest):
2654         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
2655         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
2656         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
2657         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
2658         (-[DumpRenderTreePasteboard declareType:owner:]):
2659         (+[LocalPasteboard alloc]):
2660         (-[LocalPasteboard init]):
2661         (-[LocalPasteboard dealloc]):
2662         (-[LocalPasteboard name]):
2663         (-[LocalPasteboard releaseGlobally]):
2664         (-[LocalPasteboard declareTypes:owner:]):
2665         (-[LocalPasteboard addTypes:owner:]):
2666         (-[LocalPasteboard changeCount]):
2667         (-[LocalPasteboard types]):
2668         (-[LocalPasteboard availableTypeFromArray:]):
2669         (-[LocalPasteboard setData:forType:]):
2670         (-[LocalPasteboard dataForType:]):
2671         (-[LocalPasteboard setPropertyList:forType:]):
2672         (-[LocalPasteboard setString:forType:]):
2673         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
2674         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
2675         (+[DumpRenderTreeWindow allWindows]):
2676         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
2677         (-[DumpRenderTreeWindow dealloc]):
2678         (-[DumpRenderTreeWindow isKeyWindow]):
2679         (-[DumpRenderTreeWindow keyDown:]):
2680
2681 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
2682
2683         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
2684         it indiscriminately copies any headers inside JavaScriptCore,
2685         which includes Tiger ICU headers. 
2686
2687         * wx/build-wxwebkit:
2688         Don't run WebCore/move-js-headers.sh any longer.
2689
2690 2007-11-20  Adam Treat  <treat@kde.org>
2691
2692         Reviewed by David Kilzer.
2693
2694         * Prepend git branch name to $baseProductDir
2695
2696         * Scripts/VCSUtils.pm:
2697         * Scripts/webkitdirs.pm:
2698
2699 2007-11-20  Mark Rowe  <mrowe@apple.com>
2700
2701         Reviewed by Simon Hausmann.
2702
2703         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
2704         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
2705         Have it trigger a "make distclean" rather than "make clean" to ensure that the
2706         built product and generated Makefile's are removed.
2707
2708 2007-11-19  Alp Toker  <alp@atoker.com>
2709
2710         Reviewed by Mark Rowe.
2711
2712         http://bugs.webkit.org/show_bug.cgi?id=16040
2713         [GTK] GtkLauncher should be written in C
2714
2715         Port GtkLauncher to plain C.
2716
2717         Use a more conventional GTK+ coding style.
2718
2719         Use a toolbar instead of menus.
2720
2721         Various signature fixes and cleanups.
2722
2723         Add a license header. Assume all previous modifications were copyright
2724         assigned to Apple Inc. by default.
2725
2726         * GtkLauncher/GtkLauncher.pro:
2727         * GtkLauncher/main.c: Added.
2728         (activate_url_entry_cb):
2729         (update_title):
2730         (link_hover_cb):
2731         (title_change_cb):
2732         (progress_change_cb):
2733         (destroy_cb):
2734         (go_back_cb):
2735         (go_forward_cb):
2736         (create_browser):
2737         (create_statusbar):
2738         (create_toolbar):
2739         (create_window):
2740         (main):
2741         * GtkLauncher/main.cpp: Removed.
2742
2743 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
2744
2745         Build script fixes to ensure they do the right thing for the 
2746         wx port, and update build-wxwebkit to reflect the way the
2747         build scripts now work.
2748
2749         Reviewed by Adam.
2750
2751         * Scripts/build-testkjs:
2752         * Scripts/build-webkit:
2753         * Scripts/run-javascriptcore-tests:
2754         * Scripts/webkitdirs.pm:
2755         * wx/build-wxwebkit:
2756
2757 2007-11-18  Eric Seidel  <eric@webkit.org>
2758
2759         Reviewed by Anders.
2760
2761         Make run-javascriptcore-tests report failures on exit (to support git bisect)
2762
2763         * Scripts/run-javascriptcore-tests:
2764
2765 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
2766
2767         Reviewed by Adam Roben.
2768
2769         Make run-webkit-tests work with Windows debug build.
2770
2771         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
2772         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
2773         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
2774         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
2775         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
2776
2777 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
2778
2779         Add wxWebKit sample and build script, and integrate it with 
2780         build-webkit. Also make build-webkit --clean work for all
2781         ports.
2782
2783         Reviewed by Darin Adler.
2784
2785         * Scripts/build-webkit:
2786         * Scripts/webkitdirs.pm:
2787         * wx: Added.
2788         * wx/browser: Added.
2789         * wx/browser/browser.bkl: Added.
2790         * wx/browser/browser.cpp: Added.
2791         * wx/build-wxwebkit: Added.
2792
2793 2007-11-17  Adam Roben  <aroben@apple.com>
2794
2795         Make it easy to run Safari in the debugger on Windows
2796
2797         I've added a new script, debug-safari, which launches Safari in the
2798         debugger. On OS X it just calls gdb-safari.
2799
2800         Reviewed by Mark Rowe.
2801
2802         * FindSafari/FindSafari.cpp:
2803         (_tmain): Added a /debugger flag, which in combination with
2804         /printSafariLauncher will print a script that launches Safari in the
2805         debugger.
2806         * Scripts/debug-safari: Added.
2807         * Scripts/run-safari: Changed to call runSafari().
2808         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
2809         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
2810         first argument along to FindSafari.
2811         * Scripts/webkitdirs.pm:
2812         (sub runSafari): Added.
2813
2814 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
2815
2816         Reviewed by Adam Roben.
2817
2818         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
2819
2820 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
2821
2822         Reviewed by David Kilzer.
2823
2824         The git config command was renamed to repo-config at some point. This
2825         change tries git config and then git repo-config if the first fails.
2826
2827         * Scripts/prepare-ChangeLog:
2828         (gitConfig):
2829
2830 2007-11-16  Dan Bernstein  <mitz@apple.com>
2831
2832         Reviewed by Darin Adler and Sam Weinig.
2833
2834         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
2835
2836         * DumpRenderTree/win/EventSender.cpp:
2837         (keyDownCallback): For characters that cannot be entered on the active
2838         keyboard layout, send a WM_CHAR message with the character along with
2839         a WM_KEYDOWN message with a virtual key code of 255.
2840
2841 2007-11-16  Mark Rowe  <mrowe@apple.com>
2842
2843         Reviewed by Tim Hatcher.
2844
2845         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
2846
2847         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2848         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2849
2850 2007-11-15  Adam Roben  <aroben@apple.com>
2851
2852         Make run-safari actually work on Windows
2853
2854         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
2855         chdir call.
2856
2857 2007-11-14  Adam Roben  <aroben@apple.com>
2858
2859         Updates to Safari launching now that 3.0.4 is released
2860
2861         Reviewed by Sam.
2862
2863         * FindSafari/FindSafari.cpp:
2864         (getWebViewCLSID): Use version-independent ProgID.
2865         * Scripts/run-safari: Use run-webkit-nightly.cmd.
2866
2867 2007-11-14  Anders Carlsson  <andersca@apple.com>
2868
2869         Reviewed by Adam.
2870
2871         <rdar://problem/5309081>
2872         In DRT, "plugin.logDestroy = true" not working on Windows.
2873         
2874         * DumpRenderTree/win/TestNetscapePlugin/main.c:
2875         (NPP_Destroy):
2876
2877 2007-11-14  Eric Seidel  <eric@webkit.org>
2878
2879         Reviewed by Sam.
2880
2881         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
2882
2883 2007-11-14  Anders Carlsson  <andersca@apple.com>
2884
2885         Reviewed by Adam.
2886
2887         <rdar://problem/5141186>
2888         window.layoutTestController.setWindowIsKey is not implemented in DRT.
2889         
2890         Implement setWindowIsKey.
2891         
2892         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2893         (LayoutTestController::setWindowIsKey):
2894
2895 2007-11-13  Sam Weinig  <sam@webkit.org>
2896
2897         Reviewed by Adam Roben.
2898
2899         Fix for <rdar://problem/5382579>
2900         http/tests/security/cross-frame-access-put.html reports large 
2901         negative numbers for screenLeft and screenTop (Mac reports "0")
2902
2903         * DumpRenderTree/win/UIDelegate.cpp:
2904         (UIDelegate::UIDelegate): Initialize the RECT.
2905         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
2906         (UIDelegate::webViewFrame): ditto.
2907         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
2908
2909 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
2910
2911         Reviewed by Adam.
2912
2913         - Make Drosera show source, source URLs, and function stack on Windows,
2914         and some minor fixes.
2915
2916         * Drosera/DebuggerDocument.cpp: Force source to always update display.
2917         (DebuggerDocument::updateFileSource):
2918         * Drosera/debugger.js: Force source to always update display.
2919         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
2920         menu controls.
2921         (DebuggerClient::resume):
2922         (DebuggerClient::pause):
2923         (DebuggerClient::stepInto):
2924         (DebuggerClient::stepOver):
2925         (DebuggerClient::stepOut):
2926         (DebuggerClient::showConsole):
2927         (DebuggerClient::closeCurrentFile):
2928         * Drosera/win/DebuggerClient.h: Ditto.
2929         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
2930         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
2931         removed two bugs.  1) caller could be in a bad state when asked to
2932         assign into it. 2) BSTRs were not created correctly.
2933         (DebuggerDocument::getPlatformCurrentFunctionStack):
2934         * Drosera/win/Drosera.cpp: Hook up the menu controls.
2935         (droseraWndProc):
2936         (handleCommand):
2937         (Drosera::resume):
2938         (Drosera::pause):
2939         (Drosera::stepInto):
2940         (Drosera::stepOver):
2941         (Drosera::stepOut):
2942         (Drosera::showConsole):
2943         (Drosera::closeCurrentFile):
2944         * Drosera/win/Drosera.h: Hook up the menu controls.
2945         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
2946         functions, added a null check, and fixed another bug where caller could
2947         be in a bad state when asked to assign into it.
2948         (ServerConnection::didLoadMainResourceForDataSource):
2949         (ServerConnection::getCallerFrame):
2950         * Drosera/win/ServerConnection.h: Safety first.
2951
2952 2007-11-13  Dan Bernstein  <mitz@apple.com>
2953
2954         Reviewed by Darin Adler.
2955
2956         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
2957           DumpRenderTree --pixel-tests renders each test twice
2958
2959         * DumpRenderTree/mac/DumpRenderTree.mm:
2960         (dumpRenderTree): Removed the --paint option because the painting code
2961         is always exercised as a result of
2962         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
2963         calling -displayIfNeeded.
2964         (dump): Changed to always grab the image from the window since the view
2965         is always displayed.
2966         (runTest):
2967         (displayWebView):
2968         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
2969         because it always paints.
2970
2971 2007-11-12  Antti Koivisto  <antti@apple.com>
2972
2973         Reviewed by Adele.
2974         
2975         Add support for http media tests
2976
2977         * Scripts/run-webkit-tests:
2978
2979 2007-11-12  Sam Weinig  <sam@webkit.org>
2980
2981         Reviewed by Adam Roben.
2982
2983         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
2984
2985         * DumpRenderTree/win/DumpRenderTree.cpp:
2986         (runTest):
2987         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2988         (LayoutTestController::setPrivateBrowsingEnabled):
2989
2990 2007-11-12  Adam Roben  <aroben@apple.com>
2991
2992         * Scripts/update-webkit-localizable-strings: Changed to only scan the
2993         mac and win subdirectories.
2994
2995 2007-11-11  Adam Roben  <aroben@apple.com>
2996
2997         Fix <rdar://5133816> keepWebHistory is not implemented
2998
2999         Fixes fast/history/clicked-link-is-visited.html.
3000
3001         Reviewed by Darin.
3002
3003         * DumpRenderTree/win/DumpRenderTree.cpp:
3004         (runTest): Clear the optionalSharedHistory.
3005         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3006         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
3007
3008 2007-11-10  Sam Weinig  <sam@webkit.org>
3009
3010         Reviewed by Tim Hatcher.
3011
3012         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
3013         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
3014         is turned on)
3015
3016         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
3017
3018         Added test: http/tests/security/cross-frame-access-private-browsing.html
3019
3020         * DumpRenderTree/LayoutTestController.cpp:
3021         (setPrivateBrowsingEnabledCallback):
3022         (LayoutTestController::staticFunctions):
3023         * DumpRenderTree/LayoutTestController.h:
3024         * DumpRenderTree/mac/DumpRenderTree.mm:
3025         (runTest): Default to private browsing disabled.
3026         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3027         (LayoutTestController::setPrivateBrowsingEnabled):
3028         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3029         (LayoutTestController::setPrivateBrowsingEnabled):
3030
3031 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
3032
3033         Reviewed by Adam.
3034
3035         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
3036         WebCore's!
3037
3038         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
3039         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
3040         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
3041         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
3042         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
3043         * Drosera/win/Drosera.cpp:
3044         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
3045
3046 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
3047
3048         Reviewed by Sam.
3049
3050         - Use the new IWebFrame [local] function signature and get the shared
3051         server correctly.
3052
3053         * Drosera/win/DebuggerClient.cpp:
3054         (DebuggerClient::didFinishLoadForFrame):
3055         * Drosera/win/ServerConnection.cpp:
3056         (ServerConnection::attemptToCreateServerConnection):
3057
3058 2007-11-07  Dan Bernstein  <mitz@apple.com>
3059
3060         Reviewed by Darin Adler.
3061
3062         - add an option to run-webkit-tests to ignore pixel test failures where
3063           all pixels differ by no more than a specified threshold
3064
3065         * DumpRenderTree/mac/ImageDiff.m:
3066         (main):
3067         (compareImages):
3068         (computePercentageDifferent):
3069         * Scripts/run-webkit-tests:
3070
3071 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3072
3073         Reviewed by Lars.
3074
3075         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
3076
3077         * DumpRenderTree/qt/DumpRenderTree.cpp:
3078
3079 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3080
3081         Reviewed by Lars.
3082
3083         Reworked the QWebSettings API.
3084         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
3085
3086         * DumpRenderTree/qt/DumpRenderTree.cpp:
3087
3088 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3089
3090         Reviewed by Lars.
3091
3092         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
3093
3094         * DumpRenderTree/qt/jsobjects.cpp:
3095
3096 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3097
3098         Reviewed by Lars Knoll <lars@trolltech.com>.
3099
3100         Add a QWebPage::frameCreated() signal and fix DRT
3101         
3102         The removal of createFrame in QWebPage broke the re-implementation
3103         in DumpRenderTree. Instead emit a frameCreated() signal and
3104         connect to it in DumpRenderTree.
3105         
3106
3107         * DumpRenderTree/qt/DumpRenderTree.cpp:
3108         (WebCore::WebPage::WebPage):
3109         (WebCore::DumpRenderTree::dump):
3110         (WebCore::DumpRenderTree::connectFrame):
3111         * DumpRenderTree/qt/DumpRenderTree.h:
3112
3113 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3114
3115         Reviewed by Lars Knoll <lars@trolltech.com>.
3116
3117         Moved all the event handlers from QWebFrame into QWebPage.
3118         
3119         This cleans up the public API and allows us to remove the
3120         HackWebFrame hack in DumpRenderTree.
3121         
3122
3123         * DumpRenderTree/qt/jsobjects.cpp:
3124         (EventSender::mouseDown):
3125         (EventSender::mouseUp):
3126         (EventSender::mouseMoveTo):
3127
3128 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3129
3130         Reviewed by Mark.
3131
3132         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
3133         to prevent the default implementation from popping up messageboxes.
3134
3135         * DumpRenderTree/qt/DumpRenderTree.cpp:
3136         (WebCore::WebPage::javaScriptConfirm):
3137         (WebCore::WebPage::javaScriptPrompt):
3138
3139 2007-11-06  Eric Seidel  <eric@webkit.org>
3140
3141         * Scripts/build-testkjs: build fix... too many $$
3142
3143 2007-11-06  Eric Seidel  <eric@webkit.org>
3144
3145         Reviewed by Mark Rowe.
3146
3147         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
3148
3149 2007-11-05  Adam Roben  <aroben@apple.com>
3150
3151         Add support on Windows for WEBKIT_TESTFONTS
3152
3153         This environment variable lets you specify where the fonts to be used
3154         by DumpRenderTree reside. The Qt port is already using this, so I'm
3155         just following their lead.
3156
3157         Reviewed by Darin.
3158
3159         * DumpRenderTree/win/DumpRenderTree.cpp:
3160         (exePath): Refactored code out of initialize().
3161         (fontsPath): Returns either $WEBKIT_TESTFONTS or
3162         DumpRenderTree.resources.
3163         (initialize): Use the new fontsPath function.
3164         (main): Use the new exePath function.
3165         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
3166         variable to DRT, like Qt does.
3167
3168 2007-11-05  Mark Rowe  <mrowe@apple.com>
3169
3170         Rubber-stamped by Alp Toker.
3171
3172         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
3173
3174         * GtkLauncher/main.cpp:
3175         (goToURLBarText):
3176         (main):
3177
3178 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
3179
3180         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
3181         <http://bugs.webkit.org/show_bug.cgi?id=15830>
3182
3183         Reviewed by Timothy.
3184
3185         Restrict the range of nightly builds used by the bisect-builds script
3186         based on the version of Safari and the version of Mac OS X being used.
3187
3188         Mac OS X 10.4: Safari 2.0: r11976 or newer
3189         Mac OS X 10.4: Safari 3.0: r19992 or newer
3190
3191         Mac OS X 10.5: Safari 2.0: r19594 or newer
3192         Mac OS X 10.5: Safari 3.0: r25124 or newer
3193
3194         * Scripts/bisect-builds:
3195         (findMacOSXVersion): Added.
3196         (makeNightlyList): Added argument to provide version of Mac OS X.
3197         Restrict range of nightly builds based on Safari and Mac OS X versions.
3198
3199 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
3200
3201         Reviewed by Maciej.
3202
3203         - This patch involves several changes, all of them were noticed that
3204         they were needed by the work being done in WebKit to get Drosera and
3205         WebKit working together on Windows.
3206         - The changes are:
3207         1) Added a debugger console for output messages.
3208         2) Drosera now listens for the WebKit server (before, the server would
3209         have to be running before Drosera was started.)
3210         3) Fixed a bug where the WebView started out as 0x0 pixels.
3211         4) Fixed a bug when there is no scope.
3212         5) Added the HTML, JS, and CSS to the project file to make them easy to
3213         find.
3214         6) Made the ServerConnection functions virtual.
3215
3216         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
3217         for the WebKit server.
3218         (DebuggerClient::DebuggerClient):
3219         (DebuggerClient::~DebuggerClient):
3220         (DebuggerClient::didFinishLoadForFrame):
3221         (DebuggerClient::serverConnected):
3222         (DebuggerClient::attemptToCreateServerConnection):
3223         * Drosera/win/DebuggerClient.h: Ditto.
3224         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
3225         scope.
3226         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3227         (DebuggerDocument::platformValueForScopeVariableNamed):
3228         * Drosera/win/Drosera.cpp:
3229         (_tWinMain): Added a console in debug for output messages.
3230         (Drosera::Drosera): Listen for server.
3231         (Drosera::initUI): The server now Initializes COM.
3232         (Drosera::serverConnected): Part of the listening for the server.
3233         (Drosera::attemptToCreateServerConnection): Ditto.
3234         * Drosera/win/Drosera.h: New interface for listening for the server.
3235         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
3236         files to the VS project.
3237         * Drosera/win/ServerConnection.cpp: Part of listening for the server
3238         connection.
3239         (ServerConnection::ServerConnection):
3240         (ServerConnection::attemptToCreateServerConnection):
3241         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
3242         methods.
3243         (ServerConnection::serverConnected):
3244
3245 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
3246
3247         Reviewed by Maciej.
3248
3249         http://bugs.webkit.org/show_bug.cgi?id=15832
3250         fast/dom/gc-10.html crashes when run alone
3251
3252         Check for !done before using objects that can be already deallocated.
3253
3254         * DumpRenderTree/mac/EditingDelegate.mm:
3255         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
3256         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
3257         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
3258         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
3259         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
3260         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
3261         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
3262         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
3263         (-[EditingDelegate webViewDidBeginEditing:]):
3264         (-[EditingDelegate webViewDidChange:]):
3265         (-[EditingDelegate webViewDidEndEditing:]):
3266         (-[EditingDelegate webViewDidChangeTypingStyle:]):
3267         (-[EditingDelegate webViewDidChangeSelection:]):
3268         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3269         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
3270         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
3271         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3272         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
3273         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
3274         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
3275         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3276         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
3277         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
3278         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
3279         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
3280         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
3281         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
3282         (-[FrameLoadDelegate webView:willCloseFrame:]):
3283         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
3284         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
3285         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3286         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
3287         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3288         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
3289         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
3290         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
3291         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
3292
3293 2007-11-04  Mark Rowe  <mrowe@apple.com>
3294
3295         Build fix.  Don't use Carbon.h as the prefix header as it triggers
3296         warnings that would otherwise be suppressed due to it being a system header.
3297
3298         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3299
3300 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
3301
3302         Rubber stamped by Adam.
3303         
3304         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
3305
3306         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3307
3308 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
3309
3310         Sort files(...); sections of Xcode project files.
3311
3312         Rubber-stamped by Darin.
3313
3314         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
3315         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3316         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3317         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
3318
3319 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
3320
3321         Script to sort "files(...);" sections in Xcode project.pbxproj files.
3322
3323         Reviewed by Darin.
3324
3325         * Scripts/sort-Xcode-project-file: Added.
3326
3327 2007-11-02  Darin Adler  <darin@apple.com>
3328
3329         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
3330
3331 2007-11-02  Darin Adler  <darin@apple.com>
3332
3333         Reviewed by Maciej.
3334
3335         * Scripts/run-sunspider: Pass the "--base" option through.
3336
3337         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
3338         the real script do that. Default configuration to Release to match run-sunspider
3339         so we don't end up building Debug just to compare results.
3340
3341 2007-11-01  Adam Roben  <aroben@apple.com>
3342
3343         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
3344
3345         Reviewed by Sam.
3346
3347         * Scripts/commit-log-editor: Show all the directories beneath the
3348         source root, instead of just the last one.
3349
3350 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
3351
3352         Reviewed by Adam Roben.
3353
3354         Print out an error message when the Windows build fails
3355         and provide guidance on how to find out what went wrong.
3356
3357         * Scripts/build-webkit:
3358         * Scripts/webkitdirs.pm:
3359
3360 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
3361
3362         Rubber-stamped by Adam Roben.
3363
3364         Rolled out r27326 - debug CRT seems to cause no problems after all.
3365
3366         * DumpRenderTree/win/DumpRenderTree.vcproj:
3367
3368 2007-10-31  Adam Roben  <aroben@apple.com>
3369
3370         Switch the Debug configuration to using the non-debug CRT
3371
3372         This matches WebKit.
3373
3374         Reviewed by Steve.
3375
3376         * DumpRenderTree/win/DumpRenderTree.vcproj:
3377
3378 2007-10-31  Antti Koivisto  <antti@apple.com>
3379
3380         Reviewed by bdash.
3381         
3382         Disable media tests when doing leak checking on Tiger.
3383         They crash in QuickTime (rdar://problem/5537157).
3384
3385         * Scripts/run-webkit-tests:
3386
3387 2007-10-29  Antti Koivisto  <antti@apple.com>
3388
3389         Reviewed by Maciej.
3390         
3391         Build media support by default on OSX only.
3392
3393         * Scripts/build-webkit:
3394
3395 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3396
3397         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
3398         get caught by the pre-commit hooks.
3399
3400 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3401
3402         Reviewed by Adam.
3403
3404         - This is a collection of relatively unrelated changes and cleanups
3405         to Drosera to prepare it for interacting with WebKit.  A lot of these
3406         changes are just correcting mistakes, for example removing included
3407         headers that are no longer needed.
3408
3409         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
3410         this will be needed by the DebuggerClient.
3411         (DebuggerDocument::server):
3412         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
3413         * Drosera/win/DebuggerClient.cpp: 
3414         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
3415         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
3416         (DebuggerClient::createWebViewWithRequest): Added comment about its
3417         purpose. 
3418         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
3419         declarations.
3420         (DebuggerClient::webViewLoaded): Moved.
3421         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
3422         file, since this was the only place it was used.
3423         (cfStringToBSTR):
3424         * Drosera/win/Drosera.h: Cleaned up the includes.
3425         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
3426         * Drosera/win/HelperFunctions.h: Removed.
3427
3428 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3429
3430         Reviewed by Adam.
3431
3432         - Small cleanup in the ServerConnection class.
3433
3434         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
3435         and added an include.
3436         (ServerConnection::currentFrame):
3437         (ServerConnection::getCallerFrame):
3438         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
3439         made a pointer into a COMPtr, and cleaned up the includes.
3440
3441 2007-10-29  Timothy Hatcher  <timothy@apple.com>
3442
3443         Reviewed by John Sullivan.
3444         
3445         - Place the Localizable.strings file in mac or win directories
3446           if that location exists.
3447         - Also look for UI_STRING in .c files.
3448
3449         * Scripts/extract-localizable-strings:
3450
3451 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3452
3453         Reviewed by Adam.
3454
3455         - Set the eol-style to native and made all the line endings the same
3456         so that I avoid messy diffs that show eol changes.
3457
3458         * Drosera/win/ServerConnection.cpp:
3459         (ServerConnection::didParseSource):
3460         (ServerConnection::didEnterCallFrame):
3461         (ServerConnection::willExecuteStatement):
3462         (ServerConnection::willLeaveCallFrame):
3463         (ServerConnection::exceptionWasRaised):
3464
3465 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3466
3467         Reviewed by Adam.
3468
3469         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
3470         functionality that could not have existed previously without the new
3471         interfaces.
3472         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
3473         from a BSTR to a JSValueRef.
3474         (DebuggerDocument::platformEvaluateScript): Implemented.
3475         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
3476         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3477         Implemented.
3478         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
3479         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
3480         * Drosera/win/ServerConnection.cpp: Added a helper function.
3481         (ServerConnection::getCallerFrame):
3482         * Drosera/win/ServerConnection.h: Added a helper function.
3483
3484 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
3485
3486         updated reviewers for my previous changelog.
3487
3488 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
3489         Reviewed by Maciej and Adam and Geoff.
3490
3491         - Minor mac-side improvements including moving a function to a more
3492         appropriate location, fixing a warning, and correctly checking
3493         exceptions.
3494
3495         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
3496         (DebuggerDocument::willExecuteStatement):
3497         (DebuggerDocument::didEnterCallFrame):
3498         (DebuggerDocument::willLeaveCallFrame):
3499         (DebuggerDocument::windowScriptObjectAvailable):
3500         (DebuggerDocument::callFunctionOnObject):
3501         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
3502         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
3503         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
3504         because it doesn't require the ServerConnection at all.
3505         (NSStringCreateWithJSStringRef): Made an argument const.
3506         (JSValueRefCreateWithNSString): Made an argument const.
3507         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
3508         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3509         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
3510         * Drosera/mac/ServerConnection.mm: Ditto.
3511         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
3512
3513 2007-10-29  Sam Weinig  <sam@webkit.org>
3514
3515         Reviewed by Adam Roben.
3516
3517         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
3518
3519         * DumpRenderTree/LayoutTestController.cpp:
3520         (LayoutTestController::LayoutTestController):
3521         (getGlobalFlagCallback):
3522         (setGlobalFlagCallback):
3523         (LayoutTestController::getJSClass):
3524         (LayoutTestController::staticValues):
3525         * DumpRenderTree/LayoutTestController.h:
3526         (LayoutTestController::globalFlag):
3527         (LayoutTestController::setGlobalFlag):
3528
3529 2007-10-29  Darin Adler  <darin@apple.com>
3530
3531         Reviewed by Maciej.
3532
3533         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
3534         resolution instead of its default.
3535
3536 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
3537
3538         Fixed showStatus() to print status for successfully resolved conflicts when using git.
3539
3540         Reviewed by Mark Rowe.
3541
3542         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
3543         was successfully resolved, but this would not show any status because the change had
3544         already been cached in the index using "git add".  The solution is to add an optional
3545         second argument to showStatus() which adds the "--cached" switch to the command.
3546
3547         * Scripts/resolve-ChangeLogs:
3548         (showStatus):
3549
3550 2007-10-28  Eric Seidel  <eric@webkit.org>
3551
3552         Reviewed by Maciej and Geoff, in unison.
3553
3554         * Scripts/run-webkit-tests: remove broken --svg option
3555
3556 2007-10-28  Darin Adler  <darin@apple.com>
3557
3558         Reviewed by Adam.
3559
3560         * Scripts/run-sunspider: Default to "Release" configuration rather than
3561         defaulting to the last configuration used as other scripts do. This can
3562         still be overriden on the command line with "--debug" if there's some
3563         reason to do so. Also fix a typo.
3564
3565         * Scripts/sunspider-compare-results: Fix a typo.
3566
3567 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
3568
3569         Reviewed by Adam.
3570
3571         - Implemented the WebScriptDebugListener functions now that the
3572         WebScriptDebugServer exists
3573
3574         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
3575         functions.
3576         (ServerConnection::currentFrame):
3577         (ServerConnection::didLoadMainResourceForDataSource):
3578         (ServerConnection::didParseSource):
3579         (ServerConnection::failedToParseSource):
3580         (ServerConnection::didEnterCallFrame):
3581         (ServerConnection::willExecuteStatement):
3582         (ServerConnection::willLeaveCallFrame):
3583         (ServerConnection::exceptionWasRaised):
3584         * Drosera/win/ServerConnection.h: Removed unused arguments from the
3585         members arguments list.
3586
3587 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
3588
3589         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
3590         <http://bugs.webkit.org/show_bug.cgi?id=15600>
3591
3592         Reviewed by Darin.
3593
3594         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
3595         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
3596         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
3597         file.  Note that it may also be used as a stand-alone script.
3598
3599         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
3600         * Scripts/resolve-ChangeLogs: Added.
3601         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
3602
3603 2007-10-26  Mark Rowe  <mrowe@apple.com>
3604
3605         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
3606         to the Qt port on the assumption that it was an implementation of the cross-platform
3607         LayoutTestController class.  It is not, so it did not need to be changed.
3608
3609         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
3610
3611 2007-10-25  Mark Rowe  <mrowe@apple.com>
3612
3613         Reviewed by Maciej.
3614
3615         Fix builds with code coverage enabled.
3616
3617         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
3618
3619 2007-10-25  Darin Adler  <darin@apple.com>
3620
3621         Reviewed by Mark Rowe.
3622
3623         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
3624         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
3625
3626 2007-10-25  Stephanie  <slewis@apple.com>
3627
3628         build Fix
3629
3630         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3631
3632 2007-10-25  Stephanie  <slewis@apple.com>
3633
3634         Reviewed by Mark Rowe, Adam Roben.
3635
3636         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
3637
3638         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
3639
3640 2007-10-25  Alice Liu  <alice.liu@apple.com>
3641
3642         Reviewed by Adam.
3643
3644         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
3645
3646         Moving destructor into platform-specific files
3647         * DumpRenderTree/LayoutTestController.cpp:
3648         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3649         (LayoutTestController::~LayoutTestController):
3650         * DumpRenderTree/qt/jsobjects.cpp:
3651         (LayoutTestController::~LayoutTestController):
3652
3653         LayoutTestController wasn't being destroyed
3654         * DumpRenderTree/win/DumpRenderTree.cpp:
3655         (runTest):
3656
3657         Added declspec
3658         * DumpRenderTree/win/EditingDelegate.h:
3659
3660         Reset certain values on the webview (or related delegate) that might 
3661         have changed while running a test
3662         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3663         (LayoutTestController::~LayoutTestController):
3664
3665 2007-10-25  Adam Roben  <aroben@apple.com>
3666
3667         Make sunspider-compare-results work with relative paths
3668
3669         Reviewed by Sam.
3670
3671         * Scripts/sunspider-compare-results: Convert arguments to absolute
3672         paths before we chdir.
3673
3674 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
3675
3676         Reviewed by Sam.
3677
3678         - Implemented server calls now the WebScriptDebugServer exists.
3679         - Also removed no longer needed call to initialize CG.
3680
3681         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
3682         automatically now.
3683         (_tWinMain):
3684         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
3685         (ServerConnection::ServerConnection):
3686         (ServerConnection::~ServerConnection):
3687         (ServerConnection::pause):
3688         (ServerConnection::resume):
3689         (ServerConnection::stepInto):
3690         (ServerConnection::applicationTerminating):
3691         (ServerConnection::serverConnectionDidDie):
3692         * Drosera/win/ServerConnection.h: Now uses the COM class.
3693
3694 2007-10-24  George Staikos  <staikos@kde.org>
3695
3696         Unbreak Qt build.
3697
3698         * Scripts/build-webkit:
3699
3700 2007-10-24  Adam Roben  <aroben@apple.com>
3701
3702         Remove now-unnecessary call to InitializeCoreGraphics
3703
3704         WebKit takes care of this now.
3705
3706         Reviewed by Ada.
3707
3708         * DumpRenderTree/win/DumpRenderTree.cpp:
3709         (initialize):
3710
3711 2007-10-24  Adam Roben  <aroben@apple.com>
3712
3713         Use WebTextRenderer in DRT
3714
3715         Reviewed by Ada.
3716
3717         * DumpRenderTree/win/DumpRenderTree.cpp:
3718         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
3719
3720 2007-10-24  Sven Herzberg  <sven@imendio.com>
3721
3722         Reviewed by Mark Rowe.
3723
3724         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
3725         Bug 15614: [GTK] qmake based backends don't build on OS X
3726
3727         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
3728         GTK backend on a Mac
3729         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
3730         isDarwin() to make it reusable in other places (like the workaround-
3731         for-prebuilt-qmake in build-webkit)
3732
3733 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
3734
3735         Refurbish update-webkit script.
3736
3737         Reviewed by Adam.
3738
3739         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
3740         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
3741         multi-argument version of system() for flexibility and security.  Check for existence
3742         of Internal directory using -d test instead of -x.
3743
3744 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
3745
3746         Minor clean-up of prepare-ChangeLog script.
3747
3748         Reviewed by Adam.
3749
3750         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
3751         of a string.  Use multi-argument versions of open() and system() for flexibility and
3752         security.
3753
3754 2007-10-24  Alice Liu  <alice.liu@apple.com>
3755
3756         Reviewed by Oliver.
3757
3758         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
3759
3760         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
3761         replay the saved events when we're still processing the mousedown that starts the drag
3762         * DumpRenderTree/win/EventSender.cpp:
3763         (doMouseMove):
3764         * DumpRenderTree/win/UIDelegate.cpp:
3765         (UIDelegate::doDragDrop):
3766
3767 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
3768
3769         Reviewed by Sam, Steve and Darin.
3770
3771         - Stubbed out the WebScriptDebugListener functionality in the Server
3772         Connection class to prepare it for receiving those callbacks.
3773         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
3774         and the ServerConnection to not need to be initialized with a server
3775         name, since that is not the way we connect to the WebKit server. 
3776
3777         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
3778         no exception.  Now it only loggs when there is an exception
3779         (DebuggerDocument::willExecuteStatement):
3780         (DebuggerDocument::didEnterCallFrame):
3781         (DebuggerDocument::willLeaveCallFrame):
3782         (DebuggerDocument::windowScriptObjectAvailable):
3783         (DebuggerDocument::callFunctionOnObject):
3784         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
3785         to be instantiated with a server's name.
3786         (DebuggerClient::DebuggerClient):
3787         (DebuggerClient::didFinishLoadForFrame):
3788         * Drosera/win/DebuggerClient.h: Removed unsued variable.
3789         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
3790         a server name.
3791         (Drosera::init):
3792         (Drosera::initServer):
3793         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
3794         instantiated with a server's name.
3795         * Drosera/win/ServerConnection.cpp: 
3796         (ServerConnection::ServerConnection): No longer needs a server name
3797         (ServerConnection::~ServerConnection): Only release the global context
3798         if there is one.
3799         (ServerConnection::serverConnectionDidDie): Stub for
3800         IWebScriptDebugListener
3801         (ServerConnection::QueryInterface): ditto
3802         (ServerConnection::AddRef): ditto
3803         (ServerConnection::Release): ditto
3804         (ServerConnection::didLoadMainResourceForDataSource): ditto
3805         (ServerConnection::didParseSource): ditto
3806         (ServerConnection::failedToParseSource): ditto
3807         (ServerConnection::didEnterCallFrame): ditto
3808         (ServerConnection::willExecuteStatement): ditto
3809         (ServerConnection::willLeaveCallFrame): ditto
3810         (ServerConnection::exceptionWasRaised): ditto
3811         * Drosera/win/ServerConnection.h: Stubbed out the
3812         IWebScriptDebugListener functions, and this class no longer needs to be
3813         instantiated with a server name.
3814
3815 2007-10-24  Lars Knoll  <lars@trolltech.com>
3816
3817         Reviewed by Simon.
3818
3819         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
3820
3821         * DumpRenderTree/qt/jsobjects.h:
3822
3823 2007-10-24  Lars Knoll  <lars@trolltech.com>
3824
3825         Reviewed by Simon.
3826
3827         add another command.
3828
3829         * DumpRenderTree/qt/jsobjects.cpp:
3830         (TextInputController::doCommand):
3831
3832 2007-10-24  Lars Knoll  <lars@trolltech.com>
3833
3834         Reviewed by Simon.
3835
3836         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
3837
3838         * DumpRenderTree/qt/jsobjects.cpp:
3839         (EventSender::keyDown):
3840         * DumpRenderTree/qt/jsobjects.h:
3841
3842 2007-10-24  Lars Knoll  <lars@trolltech.com>
3843
3844         Reviewed by Simon.
3845
3846         implement eventSender.keyDown().
3847
3848         * DumpRenderTree/qt/jsobjects.cpp:
3849         (EventSender::keyDown):
3850
3851 2007-10-24  Lars Knoll  <lars@trolltech.com>
3852
3853         Reviewed by Simon.
3854
3855         some smaller fixes to the editing support in DRT. Makes another few tests pass.
3856
3857         * DumpRenderTree/qt/DumpRenderTree.cpp:
3858         (WebCore::DumpRenderTree::DumpRenderTree):
3859         (WebCore::DumpRenderTree::initJSObjects):
3860         * DumpRenderTree/qt/jsobjects.cpp:
3861         (TextInputController::doCommand):
3862
3863 2007-10-24  Lars Knoll  <lars@trolltech.com>
3864
3865         Reviewed by Simon.
3866
3867         first bit of implementation for the textinputcontroller.
3868
3869         * DumpRenderTree/qt/DumpRenderTree.cpp:
3870         (WebCore::DumpRenderTree::DumpRenderTree):
3871         * DumpRenderTree/qt/DumpRenderTree.h:
3872         * DumpRenderTree/qt/jsobjects.cpp:
3873         (TextInputController::TextInputController):
3874         (TextInputController::doCommand):
3875         * DumpRenderTree/qt/jsobjects.h:
3876
3877 2007-10-24  Lars Knoll  <lars@trolltech.com>
3878
3879         Reviewed by Simon.
3880
3881         make the man webpage believe it has focus, so the editing tests work correctly.
3882
3883         * DumpRenderTree/qt/DumpRenderTree.cpp:
3884         (WebCore::DumpRenderTree::DumpRenderTree):
3885
3886 2007-10-24  Lars Knoll  <lars@trolltech.com>
3887
3888         Reviewed by Simon.
3889
3890         implement layoutTestController.dumpEditingCallbacks() correctly.
3891
3892         * DumpRenderTree/qt/DumpRenderTree.cpp:
3893         (WebCore::DumpRenderTree::DumpRenderTree):
3894         * DumpRenderTree/qt/jsobjects.cpp:
3895         (LayoutTestController::reset):
3896         (LayoutTestController::dumpEditingCallbacks):
3897
3898 2007-10-24  Lars Knoll  <lars@trolltech.com>
3899
3900         Reviewed by Simon.
3901
3902         Implement support for testing editing.
3903
3904         * DumpRenderTree/qt/DumpRenderTree.cpp:
3905         (WebCore::DumpRenderTree::DumpRenderTree):
3906
3907 2007-10-23  Sam Weinig  <sam@webkit.org>
3908
3909         Check for null BSTR that can be passed to the UIDelegate methods
3910         from javascript null and undefined.  Fixes a failing test case on
3911         Windows (fast/dom/Window/alert-undefined.html)
3912
3913         Reviewed by Eric Seidel.
3914
3915         * DumpRenderTree/win/UIDelegate.cpp:
3916         (UIDelegate::runJavaScriptAlertPanelWithMessage):
3917         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
3918         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
3919         (UIDelegate::webViewAddMessageToConsole):
3920
3921 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
3922
3923         Reviewed by Darin.
3924         
3925         Don't print a massive pile of setenvs from tools that automatically build testkjs.
3926
3927         * Scripts/build-testkjs:
3928
3929 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
3930
3931         Reviewed by Darin.
3932
3933         - add wrapper that finds the right copy of testkjs
3934         
3935         * Scripts/sunspider-compare-results: Added.
3936
3937 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
3938
3939         Reviewed by Sam.
3940
3941         - After talking with Steve I now see that the WebKit server must be
3942         running for DCOM to create the distributed objects, which makes sense
3943         and currently WebKit only allows one instance to be running at a time
3944         which avoids accidentally connecting to the wrong server
3945         - In light of this I have removed the code for the attach box and
3946         NotificationServer and known server names, since they are all extranious
3947         now.
3948
3949         * Drosera/win/Drosera.cpp: Removed notification classes and known server
3950         names.
3951         (_tWinMain): Uses init instead of initUI.
3952         (droseraWndProc): No longer creats an attach dialog box.
3953         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
3954         it's not manditory to call init before doing COM stuff.
3955         (Drosera::init): calls initUI and will call attach when the
3956         functionality exists. 
3957         (Drosera::initUI): Has changed very little.
3958         (Drosera::attach): Changed the signature to reflect that we no longer
3959         need the dictionary of known server names.
3960         * Drosera/win/Drosera.h: Removed notification classes and known server
3961         names.  Also renamed and moved some functions.
3962         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
3963         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
3964         headers to the resources folder. 
3965         * Drosera/win/resource.h: Removed the Attach box.
3966
3967 2007-10-22  Adam Roben  <aroben@apple.com>
3968
3969         Windows build fix
3970
3971         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
3972
3973 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
3974
3975         - Removed a leak that was fixed.
3976
3977         * Scripts/run-webkit-tests:
3978
3979 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3980
3981         Reviewed by Darin.
3982
3983         - Changed the Client so that the DebuggerDocument now own the
3984         ServerConnection.  This simplifies ownership and cleanup. 
3985
3986         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
3987         ServerConnection.
3988         (DebuggerClient::initWithServerName):
3989         (DebuggerClient::didFinishLoadForFrame):
3990         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
3991         ServerConnection.
3992         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
3993         until after we have a server which we are attached to.
3994         (Drosera::initUI):
3995         (Drosera::attach):
3996         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
3997         out previously.
3998
3999 2007-10-22  Simon Hausmann  <hausmann@kde.org>
4000
4001         Reviewed by Nikolas.
4002
4003         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
4004
4005         * Scripts/run-javascriptcore-tests:
4006
4007 2007-10-22  Simon Hausmann  <hausmann@kde.org>
4008
4009         Reviewed by Nikolas.
4010
4011         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
4012
4013         * Scripts/build-drosera:
4014         * Scripts/build-dumprendertree:
4015         * Scripts/build-testkjs:
4016         * Scripts/build-webkit:
4017         * Scripts/run-javascriptcore-tests:
4018         * Scripts/run-sunspider:
4019         * Scripts/run-webkit-tests:
4020         * Scripts/webkitdirs.pm:
4021
4022 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
4023
4024         Reviewed by Mark Rowe.
4025         
4026         Fix for local database support after r26879
4027         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
4028
4029         * Scripts/build-webkit:
4030
4031 2007-10-22  Holger Freyther  <zecke@selfish.org>
4032
4033         Reviewed by Simon Hausmann <hausmann@kde.org>.
4034
4035         - Do not build testkjs as an application bundle. This is
4036         needed for run-javascriptcore-tests on OSX.
4037         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
4038         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
4039         as we do not have -rpath on OSX.
4040
4041         * DumpRenderTree/qt/DumpRenderTree.pro:
4042         * Scripts/run-webkit-tests:
4043
4044 2007-10-22  Simon Hausmann  <hausmann@kde.org>
4045
4046         Reviewed by aroben.
4047
4048         Fix support for Signed-off-by detection in prepare-ChangeLog
4049         --git-commit. The Signed-off-by tag does not appear in the header
4050         but usually at the end.
4051
4052         * Scripts/prepare-ChangeLog:
4053
4054 2007-10-21  Mark Rowe  <mrowe@apple.com>
4055
4056         Reviewed by Eric.
4057
4058         Fix run-javascriptcore-tests for Gtk.
4059
4060         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
4061
4062 2007-10-20  Eric Seidel  <eric@webkit.org>
4063
4064         Reviewed by aroben.
4065
4066         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
4067
4068 2007-10-20  Eric Seidel  <eric@webkit.org>
4069
4070         Reviewed by darin.
4071         
4072         Add improved argument handling to run-sunspider, including
4073         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
4074         Also re-factor code into subroutines
4075
4076         * Scripts/build-dumprendertree: removed bogus comments
4077         * Scripts/build-testkjs: Added.
4078         * Scripts/run-javascriptcore-tests: use build-testkjs
4079         * Scripts/run-sunspider: improved argument handling, abstraction
4080         * Scripts/run-webkit-tests: improved abstraction
4081
4082 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
4083
4084         Not reviewed, Windows build fix.
4085
4086         * DumpRenderTree/win/EventSender.cpp:
4087         (keyDownCallback):
4088
4089 2007-10-20  Darin Adler  <darin@apple.com>
4090
4091         Reviewed by Tim Hatcher.
4092
4093         - http://bugs.webkit.org/show_bug.cgi?id=15544
4094           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
4095           not rely on Apple-specific key codes
4096
4097         * DumpRenderTree/mac/EventSendingController.mm:
4098         (-[EventSendingController keyDown:withModifiers:]):
4099         Added named key "rightArrow". Later we could have a whole table of these.
4100         Also tweaked modifiers code a little.
4101
4102         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
4103
4104 2007-10-19  Darin Adler  <darin@apple.com>
4105
4106         Reviewed by Eric.
4107
4108         - http://bugs.webkit.org/show_bug.cgi?id=15566
4109           possible fix for leak seen in DumpRenderTree
4110
4111         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
4112         Delete the item if it's not put on the queue, since the caller has
4113         no way of knowing that. Would be better to have the parameter type
4114         be auto_ptr to express the fact that we take ownership.
4115
4116         - unrelated change
4117
4118         * Drosera/mac/main.m: Add missing include.
4119
4120 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
4121
4122         Reviewed by Adam.
4123
4124         - This change should be identical but for some reason was not working
4125         on my machine.
4126
4127         * Scripts/prepare-ChangeLog:
4128
4129 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
4130
4131         Reviewed by Oliver and Tim.
4132
4133         - Made use of RetainPtr to avoid retain and release issues and moved the
4134         log function to DebuggerDocumentPlatform, which seems to be a more
4135         logical place for it to live.
4136         - Also moved knownServers from the ServerConnection to
4137         DebuggerApplication to match the Windows code and because it makes sense
4138         that a connection knows its own server but not all of them.
4139
4140         * Drosera/mac/DebuggerClient.h: Moved the log function to
4141           DebuggerDocumentPlatform.
4142         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
4143           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
4144           call for the server name up from the ServerConnection class.
4145         (-[DebuggerClient dealloc]):
4146         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
4147           for the server name up from the ServerConnection.
4148         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
4149         (DebuggerDocument::platformPause):
4150         (DebuggerDocument::platformResume):
4151         (DebuggerDocument::platformStepInto):
4152         (DebuggerDocument::platformEvaluateScript):
4153         (DebuggerDocument::getPlatformCurrentFunctionStack):
4154         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
4155         (DebuggerDocument::platformValueForScopeVariableNamed):
4156         (DebuggerDocument::platformLog): Log directly from here. No need to call
4157           DebuggerClient.
4158         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
4159           way I see it, a ServerConnection should only know about its connection
4160           and the group of all possible servers should be kept by the
4161           application.
4162         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
4163           currentServerName, it makes sense that the connection should know that
4164           name.
4165         (-[ServerConnection currentServerName]):
4166
4167 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
4168
4169         Reviewed by Adam.
4170
4171         - Integrated changes from mac drosera.  Recently I've encapsulated
4172         out the server connection object from the rest of Drosera because
4173         it is very platform dependent right now and RPC is not implemented on
4174         windows.  This functionality, of communicating with the WebKit server
4175         is the next area I will be focusing on in Windows.
4176
4177         - Other changes and cleanup were made to organize the code and add notes
4178         on which parts still need work.  Also some mac code is added and
4179         commented out, to act as pseudocode for the logic of those parts.
4180
4181         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
4182           pointer.
4183         * Drosera/config.h: Added whitespace.
4184         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
4185           these files got moved into Drosera.h/cpp
4186         * Drosera/win/DebuggerApplication.h: Removed.
4187         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
4188           happened here to better match the logic flow of the same code on the 
4189           mac side and to use the new ServerConnection class.
4190         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
4191         (DebuggerClient::initWithServerName): Initializer that will set up the
4192           class to use a ServerConnection object.  This was necessary so I could
4193           create a DebuggerClient without having to initilaize it at
4194           construction.
4195         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
4196           will be the UIDelegate and FrameLoadDelegate.
4197         (DebuggerClient::AddRef): For IUnknown.
4198         (DebuggerClient::Release): For IUnknown.
4199         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
4200           this still needs to set the global context of the server, but
4201           IWebFrame does not have an accessor for the global context yet. 
4202         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
4203           this is a pass through for the same function in the document.
4204         (DebuggerClient::didReceiveTitle): Unimplemented part of
4205           FrameLoadDelegate this would change the title of the window.
4206         (DebuggerClient::createWebViewWithRequest): Part of the
4207           FrameLoadDelegate.  This is about new windows via Window.open() and
4208           how their delegates are set.
4209         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
4210           UIDelegate.  Just a debug function for printing messages.
4211         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
4212           because the Client should be the UIDelegate and FrameLoadDelegate
4213           to match the delegates on mac.
4214         (DebuggerClient::webViewLoaded): Added accessor method.
4215         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
4216           forgotten to add this file before.  This is where the platform
4217           dependent versions of the Documents functions live. Most of these are
4218           unimplemented because some piece of functionality does not exist on
4219           Windows yet.
4220         (DebuggerDocument::platformPause):
4221         (DebuggerDocument::platformResume):
4222         (DebuggerDocument::platformStepInto):
4223         (DebuggerDocument::platformEvaluateScript):
4224         (DebuggerDocument::getPlatformCurrentFunctionStack):
4225         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
4226         (DebuggerDocument::platformValueForScopeVariableNamed):
4227         (DebuggerDocument::platformLog):
4228         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
4229           responsibilities becaue they belong in the Client. Also I laid the
4230           groundwork for attaching Drosera to a WebKit process
4231         (attachWndProc): Now if a server is selected the Client becomes it's
4232           delegate.
4233         (Drosera::Drosera): Added the construction of the Client and dictionary
4234           of server names. 
4235         (Drosera::initUI): This is no longer the delegates, the Client is.
4236         (Drosera::webViewLoaded): Now asks the Client instead of holding local
4237           state. 
4238         (Drosera::applicationDidFinishLaunching): Placeholder for needed
4239           notification registration when it's possible to implement.
4240         (Drosera::serverLoaded): Ditto
4241         (Drosera::serverUnloaded): Ditto
4242         (Drosera::attach): Attach Drosera to the WebKit server.
4243         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
4244         (Drosera::getInst): 
4245         (Drosera::setInst):
4246         (Drosera::knownServers):
4247         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
4248           and added the ServerConnection.
4249         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
4250         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
4251           Most of the functions are completely unimlemented because they cannot
4252           connect with the WebKit server, because one does not exist on Windows
4253           yet.
4254         (ServerConnection::initWithServerName): 
4255         (ServerConnection::~ServerConnection):
4256         (ServerConnection::setGlobalContext):
4257         (ServerConnection::pause):
4258         (ServerConnection::resume):
4259         (ServerConnection::stepInto):
4260         (ServerConnection::switchToServerNamed):
4261         (ServerConnection::applicationTerminating):
4262         (ServerConnection::serverConnectionDidDie):
4263         (ServerConnection::currentFrame):
4264         * Drosera/win/ServerConnection.h: Added. Ditto.
4265         (ServerConnection::ServerConnection):
4266
4267 2007-10-19  Alice Liu  <alice.liu@apple.com>
4268
4269         Reviewed by Darin.
4270
4271         Fix for these broken layout tests on Windows:
4272         
4273         fast/forms/focus-selection-input.html
4274         fast/forms/focus-selection-textarea.html
4275         fast/forms/select-accesskey.html
4276         
4277         * DumpRenderTree/win/EventSender.cpp:
4278         (keyDownCallback):
4279         correct the VK code for alt key.
4280         
4281 2007-10-19  Eric Seidel  <eric@webkit.org>
4282
4283         Reviewed by Mark Rowe.
4284         
4285         Make the GtkLauncher code slightly more readable.
4286
4287         * GtkLauncher/main.cpp:
4288         (setupMainMenu): Added.
4289         (setupMainWindowUI): Added.
4290         (main):
4291
4292 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
4293
4294         Rubber stamped by Adam.
4295         
4296         - don't delay-load WebKit in DumpRenderTree.
4297
4298         * DumpRenderTree/wi