<http://webkit.org/b/48184> build-webkit: reformat support variables for better maint...
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-10-24  David Kilzer  <ddkilzer@apple.com>
2
3         <http://webkit.org/b/48184> build-webkit: reformat support variables for better maintainability
4
5         Reviewed by Daniel Bates.
6
7         * Scripts/build-webkit: Alphabetized the @features array based
8         on the name of the feature.  Reformatted the list of support
9         variables so that they match the order of @features, and so that
10         each has its own line.  This makes it easy to add new variables
11         in the correct order.
12
13 2010-10-23  Eric Seidel  <eric@webkit.org>
14
15         Reviewed by Adam Barth.
16
17         EWS never removes invalid patch ids
18         https://bugs.webkit.org/show_bug.cgi?id=48173
19
20         This is just sticking another finger in the dam.
21         However this adds more unit testing which will help
22         us make sure we're always releasing patches once we
23         redesign the release_patch API and call these from
24         a more central place.
25
26         * Scripts/webkitpy/tool/commands/queues.py:
27         * Scripts/webkitpy/tool/commands/queues_unittest.py:
28         * Scripts/webkitpy/tool/mocktool.py:
29          - Added the ability to request invalid patches.
30            Log a warning message to make sure we don't ever have
31            tests use invalid patch fetches by mistake.
32
33 2010-10-23  Dan Bernstein  <mitz@apple.com>
34
35         Build fix. Add stub implementations for required NSDraggingInfo methods.
36
37         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
38         (-[DumpRenderTreeDraggingInfo draggingFormation]):
39         (-[DumpRenderTreeDraggingInfo setDraggingFormation:]):
40         (-[DumpRenderTreeDraggingInfo animatesToDestination]):
41         (-[DumpRenderTreeDraggingInfo setAnimatesToDestination:]):
42         (-[DumpRenderTreeDraggingInfo numberOfValidItemsForDrop]):
43         (-[DumpRenderTreeDraggingInfo setNumberOfValidItemsForDrop:]):
44         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
45
46 2010-10-23  David Kilzer  <ddkilzer@apple.com>
47
48         <http://webkit.org/b/48186> Remove unneeded WebHTMLRepresentationInternal.h header
49
50         Reviewed by Sam Weinig.
51
52         The only method defined in WebHTMLRepresentationInternal.h is
53         also defined in WebHTMLRepresentation.h, so use that instead.
54
55         * DumpRenderTree/mac/InternalHeaders/WebKit/WebHTMLRepresentationInternal.h: Removed.
56         * DumpRenderTree/mac/WebArchiveDumpSupport.mm: Switched to use
57         WebHTMLRepresentation.h.
58
59 2010-10-23  Sheriff Bot  <webkit.review.bot@gmail.com>
60
61         Unreviewed, rolling out r70367.
62         http://trac.webkit.org/changeset/70367
63         https://bugs.webkit.org/show_bug.cgi?id=48176
64
65         It made 8-10 tests crash on Qt bot (Requested by Ossy on
66         #webkit).
67
68         * DumpRenderTree/LayoutTestController.cpp:
69         (setCustomPolicyDelegateCallback):
70         * DumpRenderTree/LayoutTestController.h:
71         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
72         (LayoutTestController::setCustomPolicyDelegate):
73         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
74         (LayoutTestController::setCustomPolicyDelegate):
75         * DumpRenderTree/mac/PolicyDelegate.h:
76         * DumpRenderTree/mac/PolicyDelegate.mm:
77         (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
78         (-[PolicyDelegate setPermissive:]):
79         (-[PolicyDelegate setControllerToNotifyDone:]):
80         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
81         (LayoutTestController::setCustomPolicyDelegate):
82         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
83         (LayoutTestController::setCustomPolicyDelegate):
84
85 2010-10-22  Eric Seidel  <eric@webkit.org>
86
87         Reviewed by Adam Barth.
88
89         EWS never releases patches which fail to apply
90         https://bugs.webkit.org/show_bug.cgi?id=48171
91
92         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
93         * Scripts/webkitpy/tool/commands/queues.py:
94
95 2010-10-22  Eric Seidel  <eric@webkit.org>
96
97         Unreviewed.
98
99         Make the EWS queues restart themselves more often.
100         This matches the commit-queue.
101
102         * EWSTools/start-queue.sh:
103
104 2010-10-22  Eric Seidel  <eric@webkit.org>
105
106         Reviewed by Adam Barth.
107
108         commit-queue should not pass --quiet to subcommands now that the parent command does the reporting
109         https://bugs.webkit.org/show_bug.cgi?id=48165
110
111         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
112         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
113         * Scripts/webkitpy/tool/commands/queues_unittest.py:
114
115 2010-10-22  Mario Sanchez Prada  <msanchez@igalia.com>
116
117         Adding myself as a committer.
118
119         * Scripts/webkitpy/common/config/committers.py:
120
121 2010-10-20  Anders Carlsson  <andersca@apple.com>
122
123         Reviewed by Adam Barth and Darin Adler.
124
125         Using the decidePolicyForMIMEType delegate message in an asynchronous manner does not work
126         https://bugs.webkit.org/show_bug.cgi?id=48014
127         <rdar://problem/8202716>
128         
129         * DumpRenderTree/LayoutTestController.cpp:
130         (setCustomPolicyDelegateCallback):
131         Add callIgnoreInDecidePolicyForMIMETypeAfterOneSecond argument.
132
133         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
134         (LayoutTestController::setCustomPolicyDelegate):
135         Add callIgnoreInDecidePolicyForMIMETypeAfterOneSecond argument.
136
137         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
138         (LayoutTestController::setCustomPolicyDelegate):
139         Add callIgnoreInDecidePolicyForMIMETypeAfterOneSecond argument.
140
141         * DumpRenderTree/mac/PolicyDelegate.h:
142         * DumpRenderTree/mac/PolicyDelegate.mm:
143         (-[PolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
144         If _callIgnoreInDecidePolicyForMIMETypeAfterOneSecond is true, call [listener ignore] after one second.
145
146         (-[PolicyDelegate setCallIgnoreInDecidePolicyForMIMETypeAfterOneSecond:]):
147         Update _callIgnoreInDecidePolicyForMIMETypeAfterOneSecond.
148         
149         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
150         (LayoutTestController::setCustomPolicyDelegate):
151         Add callIgnoreInDecidePolicyForMIMETypeAfterOneSecond argument.
152
153         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
154         (LayoutTestController::setCustomPolicyDelegate):
155         Add callIgnoreInDecidePolicyForMIMETypeAfterOneSecond argument.
156
157 2010-10-22  Sam Weinig  <sam@webkit.org>
158
159         Reviewed by Anders Carlsson.
160
161         Rename the InjectedBundle for TestWebKitAPI to InjectedBundleTestWebKitAPI.bundle
162
163         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
164         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
165         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
166         (TestWebKitAPI::Util::createInjectedBundlePath):
167
168 2010-10-22  Dirk Pranke  <dpranke@chromium.org>
169
170         Reviewed by Eric Seidel.
171
172         test-webkitpy fails when passed -v (or any other option)
173
174         Fix port/base_unittest to pass an explicit list of arguments
175         rather than accidentally picking up sys.argv.
176
177         https://bugs.webkit.org/show_bug.cgi?id=48071
178
179         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
180
181 2010-10-22  Brian Weinstein  <bweinstein@apple.com>
182
183         Windows build fix. Update the createNewPage callback to account for the new
184         arguments.
185
186         * MiniBrowser/win/BrowserView.cpp:
187         (createNewPage):
188
189 2010-10-22  Sam Weinig  <sam@webkit.org>
190
191         Reviewed by Anders Carlsson.
192
193         WebKit2 needs to pass the current event modifier flags when requesting a new window
194         https://bugs.webkit.org/show_bug.cgi?id=48140
195
196         * MiniBrowser/mac/BrowserWindowController.m:
197         (createNewPage):
198         * WebKitTestRunner/TestController.cpp:
199         (WTR::createOtherPage):
200         Update for new signature for the WKPageCreateNewPageCallback.
201
202 2010-10-22  Eric Seidel  <eric@webkit.org>
203
204         Unreviewed.  Just adding a test case.
205
206         The style-queue was not recognizing new patches.  It turns
207         out I had fixed this in an earlier change, but just not
208         deployed to queues.webkit.org.  As part of investigating why it
209         was broken, I wrote a test for my previous change which I'm now landing.
210
211         * QueueStatusServer/model/queues_unittest.py:
212
213 2010-10-22  Eric Seidel  <eric@webkit.org>
214
215         Reviewed by Adam Barth.
216
217         EWS does not need to process obsolete patches
218         https://bugs.webkit.org/show_bug.cgi?id=48093
219
220         This was an easy change, but to test it I had to pipe
221         real Attachment objects into the queue testing system.
222         Doing so revealed a whole bunch of bugs in our unit tests,
223         which I fixed as part of this patch.
224
225         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
226          - This is the actual code change.  This will not reduce the
227            backlog in the EWS queues much, but it will make rejections
228            much quicker for obsolete patches or closed bugs.
229         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
230          - Test my new code.
231          - Used a real attachment object and got rid of MockPatch
232          - Shared code between the mac-ews and cr-mac-ews tests.
233         * Scripts/webkitpy/tool/commands/queues_unittest.py:
234          - Can't use MockPatch anymore.
235          - Removing MockPatch found more bugs here!
236         * Scripts/webkitpy/tool/commands/queuestest.py:
237         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
238         * Scripts/webkitpy/tool/mocktool.py:
239          - MockBugzilla should not be a "Mock" object.  Right now tool.bugs()
240            is allowed, but wrong.  Making it not a Mock will make tool.bugs() correctly fail.
241
242 2010-10-22  Sheriff Bot  <webkit.review.bot@gmail.com>
243
244         Unreviewed, rolling out r70301.
245         http://trac.webkit.org/changeset/70301
246         https://bugs.webkit.org/show_bug.cgi?id=48126
247
248         "Lang attribute layout tests failing" (Requested by satish on
249         #webkit).
250
251         * DumpRenderTree/LayoutTestController.cpp:
252         (setMockSpeechInputResultCallback):
253         * DumpRenderTree/LayoutTestController.h:
254         * DumpRenderTree/chromium/LayoutTestController.cpp:
255         (LayoutTestController::setMockSpeechInputResult):
256         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
257         (LayoutTestController::setMockSpeechInputResult):
258         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
259         (LayoutTestController::setMockSpeechInputResult):
260         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
261         (LayoutTestController::setMockSpeechInputResult):
262         * DumpRenderTree/qt/LayoutTestControllerQt.h:
263         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
264         (LayoutTestController::setMockSpeechInputResult):
265         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
266         (LayoutTestController::setMockSpeechInputResult):
267
268 2010-10-22  Leandro Gracia Gil  <leandrogracia@google.com>
269
270         Reviewed by Jeremy Orlow.
271
272         Added a second parameter to setMockSpeechInputResult for
273         the language used in speech input.
274         https://bugs.webkit.org/show_bug.cgi?id=47089
275
276         * DumpRenderTree/LayoutTestController.cpp:
277         (setMockSpeechInputResultCallback):
278         * DumpRenderTree/LayoutTestController.h:
279         * DumpRenderTree/chromium/LayoutTestController.cpp:
280         (LayoutTestController::setMockSpeechInputResult):
281         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
282         (LayoutTestController::setMockSpeechInputResult):
283         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
284         (LayoutTestController::setMockSpeechInputResult):
285         * DumpRenderTree/qt/LayoutTestControllerQt.h:
286         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
287         (LayoutTestController::setMockSpeechInputResult):
288         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
289         (LayoutTestController::setMockSpeechInputResult):
290         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
291         (LayoutTestController::setMockSpeechInputResult):
292
293 2010-10-21  MORITA Hajime  <morrita@google.com>
294
295         Reviewed by Kent Tamura.
296
297         [Win][DRT] should have LayoutTestController.hasSpellingMarker()
298         https://bugs.webkit.org/show_bug.cgi?id=47885
299
300         - Implemented LayoutTestController.hasSpellingMarker(),
301         - Added fake spellcheck implementation.
302
303         * DumpRenderTree/win/DumpRenderTree.cpp:
304         (main):
305         * DumpRenderTree/win/EditingDelegate.cpp:
306         (indexOfFirstWordCharacter):
307         (wordLength):
308         (EditingDelegate::checkSpellingOfString):
309         * DumpRenderTree/win/EditingDelegate.h:
310         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
311         (LayoutTestController::hasSpellingMarker):
312
313 2010-10-21  Mihai Parparita  <mihaip@chromium.org>
314
315         Unreviewed. Re-enable test that was mistakenly disabled by r67974.
316
317         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
318
319 2010-10-21  Mihai Parparita  <mihaip@chromium.org>
320
321         Unreviewed fix for rebaseline-chromium-webkit-tests.
322
323         Port.diff_image no longer has a tolerance parameter. Also, use
324         get_option('tolerance') which is safer if the options object doesn't
325         define a tolerance attribute (it doesn't for the one used in
326         rebaseline_chromium_webkit_tests).
327
328         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
329         * Scripts/webkitpy/layout_tests/port/webkit.py:
330         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
331
332 2010-10-21  Mihai Parparita  <mihaip@chromium.org>
333
334         Reviewed by Ojan Vafai.
335
336         Add support for --tolerance in NRWT
337         https://bugs.webkit.org/show_bug.cgi?id=47959
338         
339         Add support for the --tolerance flag in NRWT. The Port.diff_image
340         signature shouldn't need a tolerance parameter (it's not set per test),
341         just have ports that use it (currently only WebKitPort) read it from 
342         the options object.
343
344         * Scripts/webkitpy/layout_tests/port/chromium.py:
345         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
346         * Scripts/webkitpy/layout_tests/port/test.py:
347         * Scripts/webkitpy/layout_tests/port/webkit.py:
348         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
349         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
350
351 2010-10-21  Eric Seidel  <eric@webkit.org>
352
353         Reviewed by Adam Barth.
354
355         Add --suggest-reviewers option to upload to auto-suggest reviewers for your patch
356         https://bugs.webkit.org/show_bug.cgi?id=48088
357
358         This is a first-pass.  Works, but we'll eventually
359         turn this on by default, refine the suggestion algorithm
360         and possibly move it to a different place in the upload step order.
361
362         * Scripts/webkitpy/common/checkout/api.py:
363         * Scripts/webkitpy/tool/commands/download_unittest.py:
364         * Scripts/webkitpy/tool/commands/upload.py:
365         * Scripts/webkitpy/tool/commands/upload_unittest.py:
366         * Scripts/webkitpy/tool/mocktool.py:
367         * Scripts/webkitpy/tool/steps/__init__.py:
368         * Scripts/webkitpy/tool/steps/options.py:
369
370 2010-10-21  Mario Sanchez Prada  <msanchez@igalia.com>
371
372         Reviewed by Chris Fleizach.
373
374         [GTK] Segfault while testing accessibility/iframe-bastardization.html
375         https://bugs.webkit.org/show_bug.cgi?id=30123
376
377         Check m_element before actually using it to get the parent.
378
379         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
380         (AccessibilityUIElement::parentElement): Add an extra check to
381         make sure m_element points to a valid value before actually using
382         it to get the parent. Also, assert ATK_IS_OBJECT(m_element).
383
384 2010-10-21  Anders Carlsson  <andersca@apple.com>
385
386         Reviewed by Adam Roben.
387
388         Crash evaluating JavaScript string that throws an exception
389         https://bugs.webkit.org/show_bug.cgi?id=48092
390         <rdar://problem/8487657>
391
392         Add a test that evaluates a JavaScript string that throws an exception and check that 
393         the callback is called.
394
395         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
396         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp: Added.
397         (TestWebKitAPI::didRunJavaScript):
398         (TestWebKitAPI::WebKit2_EvaluateJavaScript):
399         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
400
401 2010-10-21  Adam Roben  <aroben@apple.com>
402
403         Test that the plugin's HWND is invalidated when NPN_InvalidateRect is
404         called
405
406         Test for <http://webkit.org/b/48086> <rdar://problem/8482944>
407         Silverlight doesn't repaint in WebKit2
408
409         Reviewed by Anders Carlsson.
410
411         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
412         (PluginTest::NPN_InvalidateRect): Added. Calls through to the browser.
413         (executeScript): Added. Asks the browser to evaluate the script.
414
415         (PluginTest::waitUntilDone):
416         (PluginTest::notifyDone):
417         Added. Calls through to layoutTestController.
418
419         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added
420         * NPN_InvalidateRect and waitUntilDone/notifyDone.
421
422         * DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp: Added.
423         (TemporaryWindowMover::moveSucceeded):
424         (TemporaryWindowMover::TemporaryWindowMover):
425         (TemporaryWindowMover::~TemporaryWindowMover):
426         This class moves a window on-screen and shows it, then moves it back and hides it.
427
428         (NPNInvalidateRectInvalidatesWindow::NPNInvalidateRectInvalidatesWindow):
429         Initialize our members.
430         (NPNInvalidateRectInvalidatesWindow::~NPNInvalidateRectInvalidatesWindow):
431         Delete our window mover if it hasn't been deleted already.
432         (NPNInvalidateRectInvalidatesWindow::NPP_SetWindow): Subclass the
433         plugin HWND and move the test harness window on screen.
434         (NPNInvalidateRectInvalidatesWindow::wndProc): Call through to onPaint
435         when we get a WM_PAINT message.
436         (NPNInvalidateRectInvalidatesWindow::onPaint): Do the test and tell
437         LayoutTestController we're done.
438         (NPNInvalidateRectInvalidatesWindow::testInvalidateRect): Validate
439         ourselves, invalidate our lower-right quadrant via NPN_InvalidateRect,
440         then check that our HWND's invalid region is the rect that we
441         invalidated.
442
443         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
444         * Added NPNInvalidateRectInvalidatesWindow.
445
446 2010-10-21  Daniel Bates  <dbates@rim.com>
447
448         Add Git-support to do-file-rename
449         https://bugs.webkit.org/show_bug.cgi?id=48015
450
451         Fix tools. Export function scmMoveOrRenameFile so that it can be called from
452         do-file-rename and do-webcore-rename. I inadvertently left this out of the patch.
453
454         * Scripts/VCSUtils.pm:
455
456 2010-10-21  Eric Seidel  <eric@webkit.org>
457
458         Reviewed by Adam Barth.
459
460         mac-ews is not properly releasing patches
461         https://bugs.webkit.org/show_bug.cgi?id=48076
462
463         mac-ews overrides process_work_item, so it was not calling
464         release_work_item like the default process_work_item would.
465         To fix this I made all the status-reporting methods just
466         release the patch.  I expect we'll iterate on this design further.
467
468         * Scripts/webkitpy/common/net/statusserver.py:
469         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
470         * Scripts/webkitpy/tool/commands/queues.py:
471         * Scripts/webkitpy/tool/commands/queues_unittest.py:
472
473 2010-10-18  Martin Robinson  <mrobinson@igalia.com>
474
475         Reviewed by Gustavo Noronha Silva.
476
477         [GTK] mathml flaky tests after adding SystemFonts to the theme
478         https://bugs.webkit.org/show_bug.cgi?id=47727
479
480         The Fontconfig setup in the GTK+ now specifically checks for and
481         loads the STIX fonts for MathML tests.
482
483         * DumpRenderTree/gtk/DumpRenderTree.cpp:
484         (initializeFonts): Add hooks for loading the STIX fonts specifically.
485
486 2010-10-20  Adam Roben  <aroben@apple.com>
487
488         Test that the UI client gets notified when WKView receives a WM_CLOSE
489         message
490
491         Test for <http://webkit.org/b/48044> <rdar://problem/8488446> Pressing
492         Ctrl+W when viewing a full-page PDF destroys the WKView but doesn't
493         close its parent window
494
495         Reviewed by Jon Honeycutt.
496
497         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp: Added.
498         (TestWebKitAPI::close): Record that this function was called.
499         (TestWebKitAPI::WebKit2_WMCloseCallsUIClientClose): Create a WKView,
500         send it a WM_CLOSE message, and test that the UI client's close
501         callback got called. Note that this will hang if the bug is
502         reintroduced; <http://webkit.org/b/48043> covers making TestWebKitAPI
503         able to handle hangs.
504
505         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added the new test.
506
507 2010-10-20  Adam Roben  <aroben@apple.com>
508
509         Make prepare-ChangeLog much faster when using git
510
511         This change also seems to make it detect renames better in some cases.
512
513         Fixes <http://webkit.org/b/48040> prepare-ChangeLog is slow when using
514         git
515
516         Reviewed by David Kilzer.
517
518         * Scripts/prepare-ChangeLog:
519         (statusCommand):
520         (createPatchCommand):
521         Use "-M -C" instead of "-C -C -M" to tell git-diff to detect renames
522         and copies. The two "-C"s were making it read many more files than were
523         necessary.
524
525 2010-10-21  Sam Weinig  <sam@webkit.org>
526
527         Reviewed by Adam Roben.
528
529         Null frame passed when running alert from UserScript run at document start
530         <rdar://problem/8573809>
531         https://bugs.webkit.org/show_bug.cgi?id=48036
532
533         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
534         * TestWebKitAPI/InjectedBundleController.cpp:
535         (TestWebKitAPI::InjectedBundleController::didReceiveMessage):
536         (TestWebKitAPI::InjectedBundleController::initializeTestNamed):
537         * TestWebKitAPI/InjectedBundleController.h:
538         * TestWebKitAPI/InjectedBundleTest.h:
539         (TestWebKitAPI::InjectedBundleTest::initialize):
540         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
541         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp: Added.
542         (TestWebKitAPI::runJavaScriptAlert):
543         (TestWebKitAPI::TEST):
544         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp: Added.
545         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::DocumentStartUserScriptAlertCrashTest):
546         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
547         Add test for invoking an alert during a UserScript run at document start.
548
549 2010-10-21  Andreas Kling  <kling@webkit.org>
550
551         Reviewed by Adam Roben.
552
553         TestNetscapePlugIn: Actually call NPP_SetWindow on Unix
554
555         We were just returning NPERR_NO_ERROR previously.
556
557         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
558         (webkit_test_plugin_set_window):
559
560 2010-10-21  David Kilzer  <ddkilzer@apple.com>
561
562         <http://webkit.org/b/48051> Move macros from DumpRenderTreeMac.h to config.h
563
564         Reviewed by Adam Roben.
565
566         * DumpRenderTree/config.h: Moved macros to here...
567         * DumpRenderTree/mac/DumpRenderTreeMac.h: ...from here.
568         Addresses a FIXME comment from r28419.
569
570 2010-10-21  David Kilzer  <ddkilzer@apple.com>
571
572         <http://webkit.org/b/48047> Fix warnings found by check-Xcode-source-file-types
573
574         Reviewed by Adam Roben.
575
576         Fixes the following warnings:
577
578             WARNING: Incorrect file type 'sourcecode.cpp.objcpp' for file 'PixelDumpSupport.cpp'.
579             WARNING: Incorrect file type 'sourcecode.cpp.objcpp' for file 'LayoutTestController.cpp'.
580             WARNING: Incorrect file type 'sourcecode.cpp.objcpp' for file 'WorkQueue.cpp'.
581             WARNING: Incorrect file type 'sourcecode.cpp.objcpp' for file 'cg/PixelDumpSupportCG.cpp'.
582             WARNING: Incorrect file type 'sourcecode.cpp.objcpp' for file 'GCController.cpp'.
583             5 issues found for WebKitTools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj.
584
585         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
586         Removed explicit file type for *.cpp files above to make them
587         match other C++ source files.  This exposed the fact that
588         DumpRenderTreeMac.h was not safe to include in C++ source, which
589         caused PixelDumpSupport.cpp and PixelDumpSupportCG.cpp to fail
590         to build.
591         * DumpRenderTree/PixelDumpSupport.cpp: Adjusted header order.
592         * DumpRenderTree/mac/DumpRenderTreeMac.h: Made safe to include
593         in C++ source files.  Included CoreFoundation/CoreFoundation.h
594         to make sure all CF types were defined.  Removed CFStringRef
595         typedef.
596
597 2010-10-21  Adam Roben  <aroben@apple.com>
598
599         Attempt to fix plugins/pass-different-npp-struct.html on GTK.
600
601         See <http://webkit.org/b/47690>.
602
603         * GNUmakefile.am: Added PassDifferentNPPStruct.cpp.
604
605 2010-10-21  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
606
607         Reviewed by Csaba Osztrogonác.
608
609         [NRWT] Set ImageDiff path on Qt port
610         https://bugs.webkit.org/show_bug.cgi?id=48052
611
612         * Scripts/webkitpy/layout_tests/port/qt.py:
613
614 2010-10-21  Adam Barth  <abarth@webkit.org>
615
616         Reviewed by Eric Seidel.
617
618         Don't CC authors of flaky tests
619         https://bugs.webkit.org/show_bug.cgi?id=48038
620
621         Some authors found this too annoying.  We'll look for another way to
622         close the flaky test loop.
623
624         * Scripts/webkitpy/tool/commands/queues.py:
625         * Scripts/webkitpy/tool/commands/queues_unittest.py:
626
627 2010-10-21  Eric Seidel  <eric@webkit.org>
628
629         Reviewed by Adam Barth.
630
631         commit-queue should run run-webkit-tests with --no-new-test-results
632         https://bugs.webkit.org/show_bug.cgi?id=47998
633
634         * Scripts/webkitpy/tool/steps/runtests.py:
635         * Scripts/webkitpy/tool/steps/steps_unittest.py:
636
637 2010-10-21  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
638
639         Reviewed by Ojan Vafai.
640
641         [NRWT] Get child process number from an environment variable
642         https://bugs.webkit.org/show_bug.cgi?id=47981
643
644         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
645
646 2010-10-20  David Kilzer  <ddkilzer@apple.com>
647
648         <http://webkit.org/b/47754> New script to verify explicit source file types in Xcode project files
649
650         Reviewed by Darin Adler.
651
652         The script parses an Xcode project file and makes sure the file
653         extension matches the explicit file type set for all source
654         files.  Note that the majority of source files will have their
655         type set by Xcode, so the script doesn't check them since there
656         is no need to second-guess Xcode.
657
658         * Scripts/check-Xcode-source-file-types: Added.  Code borrowed
659         heavily from sort-Xcode-project-file.
660
661 2010-10-20  Adam Roben  <aroben@apple.com>
662         
663         Windows build fix
664
665         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Added missing #include.
666
667 2010-10-20  Adam Roben  <aroben@apple.com>
668
669         Qt test fix
670
671         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Added
672         PassDifferentNPPStruct.cpp.
673
674 2010-10-20  Sam Weinig  <sam@webkit.org>
675
676         Reviewed by Adam Roben.
677
678         Add ability to test injected bundle API using TestWebKitAPI
679         https://bugs.webkit.org/show_bug.cgi?id=48027
680
681         * TestWebKitAPI/InjectedBundleController.cpp: Added.
682         * TestWebKitAPI/InjectedBundleController.h: Added.
683         Shared main object for bundle functionality.
684
685         * TestWebKitAPI/InjectedBundleMain.cpp: Added.
686         Bundle entry point.
687
688         * TestWebKitAPI/InjectedBundleTest.h: Added.
689         Base class for which the bundle portion of a test derives from. 
690
691         * TestWebKitAPI/PlatformUtilities.h:
692         * TestWebKitAPI/PlatformUtilities.cpp: Added.
693         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
694         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
695         (TestWebKitAPI::Util::createInjectedBundlePath):
696         (TestWebKitAPI::Util::createURLForResource):
697         (TestWebKitAPI::Util::URLForNonExistentResource):
698         Add helper to create a context with the shared injected bundle,
699         and send the initial message to set up the test.
700
701         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig: Added.
702         * TestWebKitAPI/InjectedBundle-Info.plist: Added.
703         Add mac configuration files.
704
705         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
706         Add the new files.
707
708         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp: Added.
709         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp: Added.
710         Add a simple initial bundle test.
711
712 2010-10-20  Eric Seidel  <eric@webkit.org>
713
714         Unreviewed.  Fixing /release-patch url used by the EWS bots.
715
716         EWS should test patches with r+
717         https://bugs.webkit.org/show_bug.cgi?id=35460
718
719         * Scripts/webkitpy/common/net/statusserver.py:
720          - I changed the URL during development, and 404s are
721          intentionally silenced during release_patch.
722
723 2010-10-14  Adam Roben  <aroben@apple.com>
724
725         Test that passing a different NPP struct back to the browser doesn't
726         cause an assertion failure
727
728         Test for <http://webkit.org/b/47690> <rdar://problem/8553020>
729         Assertion failure in NetscapePlugin::fromNPP when using Shockwave in
730         WebKit2
731
732         Reviewed by John Sullivan.
733
734         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp: Copied from WebKitTools/DumpRenderTree/TestNetscapePlugIn/Tests/win/GetValueNetscapeWindow.cpp.
735         (PassDifferentNPPStruct::PassDifferentNPPStruct): Initialize our
736         members.
737         (PassDifferentNPPStruct::NPP_SetWindow): Pass a different NPP to the
738         browser than the one it gave us in NPP_New and see if it works.
739
740         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
741         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
742         Added PassDifferentNPPStruct.
743
744 2010-10-19  Adam Roben  <aroben@apple.com>
745
746         Gently nudge old-run-webkit-tests toward working with Win32 Perl
747
748         This makes old-run-webkit-tests able to build DRT and find all the
749         tests to run. It even invokes DRT and passes it the list of tests. But
750         DRT ends up hung blocking on I/O.
751
752         Fixes <http://webkit.org/b/47961> Get old-run-webkit-tests mostly
753         working with Win32 Perl
754
755         Reviewed by David Kilzer.
756
757         * Scripts/old-run-webkit-tests:
758           - Use File::Spec instead of manually concatenating paths
759           - Use dirname instead of manually stripping off the base name
760           - Use isCygwin/isWindows/isAppleWinWebKit more judiciously
761           - Explicitly invoke Perl when running Perl scripts
762           - Quote paths when using them in regular expressions to allow them
763             to include characters that have special meanings in regular
764             expressions
765
766         * Scripts/run-webkit-tests: Use File::Spec instead of manually
767         concatenating paths.
768
769         * Scripts/webkitdirs.pm:
770           - Remove the unused $windowsTmpPath variable
771           - Use isCygwin/isWindows/isAppleWinWebKit more judiciously
772           - Only pass paths to cygpath when using Cygwin Perl
773           - Only use pdevenv when using Cygwin Perl, for now
774
775 2010-10-20  Daniel Bates  <dbates@rim.com>
776
777         Reviewed by Martin Robinson.
778
779         Add Git-support to do-file-rename
780         https://bugs.webkit.org/show_bug.cgi?id=48015
781
782         Also, abstracts the SCM move/rename functionality in do-file-rename and
783         do-webcore-rename into a common function VCSUtils::scmMoveOrRenameFile().
784
785         Currently, do-file-rename is hard coded to assume the SCM is Subversion.
786         Instead, we should abstract the rename logic to be SCM-independent. This
787         will allow us to add Git support as well move such functionality into
788         our SCM library VCSUtils, where it can be shared by do-webcore-rename.
789
790         * Scripts/VCSUtils.pm:
791           - Added function scmMoveOrRenameFile.
792         * Scripts/do-file-rename: Modified to call VCSUtils::scmMoveOrRenameFile().
793         * Scripts/do-webcore-rename: Ditto.
794
795 2010-10-20  Adam Roben  <aroben@apple.com>
796
797         Fix old-run-webkit-tests when there's a space in the path to DRT
798
799         Reviewed by Jon Honeycutt.
800
801         * Scripts/old-run-webkit-tests: Quote the path to DRT before executing
802         it.
803
804 2010-10-20  Kenneth Russell  <kbr@google.com>
805
806         Reviewed by Dimitri Glazkov.
807
808         Regression in chromium_gpu_unittests after r70175
809         https://bugs.webkit.org/show_bug.cgi?id=48008
810
811         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
812
813 2010-10-20  Kenneth Russell  <kbr@google.com>
814
815         Reviewed by James Robinson.
816
817         chromium_gpu port of new-run-webkit-tests must do Linux -> Win expectations fallback
818         https://bugs.webkit.org/show_bug.cgi?id=48005
819
820         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
821
822 2010-10-20  Adam Barth  <abarth@webkit.org>
823
824         Reviewed by Eric Seidel.
825
826         webkit-patch doesn't get along with git rm
827         https://bugs.webkit.org/show_bug.cgi?id=47940
828
829         Turns out we need to pass "--" to tell git this is a path.
830
831         * Scripts/webkitpy/common/checkout/scm.py:
832
833 2010-10-20  Robert Hogan  <robert@webkit.org>
834
835         Reviewed by Antonio Gomes.
836
837         [Qt] Fix layoutTestController.getJsObjectCount
838
839         Qt Bridge doesn't know size_t so pass result as unsigned int.
840
841         Unskip fast/dom/gc-10.html
842
843         https://bugs.webkit.org/show_bug.cgi?id=47931
844
845         * DumpRenderTree/qt/GCControllerQt.cpp:
846         (GCController::getJSObjectCount):
847         * DumpRenderTree/qt/GCControllerQt.h:
848
849 2010-10-20  Sheriff Bot  <webkit.review.bot@gmail.com>
850
851         Unreviewed, rolling out r70149.
852         http://trac.webkit.org/changeset/70149
853         https://bugs.webkit.org/show_bug.cgi?id=47989
854
855         "Build breaks in mac and win" (Requested by satish on
856         #webkit).
857
858         * DumpRenderTree/LayoutTestController.cpp:
859         (setMockSpeechInputResultCallback):
860         * DumpRenderTree/LayoutTestController.h:
861         * DumpRenderTree/chromium/LayoutTestController.cpp:
862         (LayoutTestController::setMockSpeechInputResult):
863         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
864         (LayoutTestController::setMockSpeechInputResult):
865
866 2010-10-19  Adam Roben  <aroben@apple.com>
867
868         Teach update-webkit-support-libs about the new versioning of
869         WebKitSupportLibrary
870
871         Fixes <http://webkit.org/b/47915> update-webkit-support-libs should
872         check version numbers instead of modification times
873
874         Reviewed by Sam Weinig.
875
876         * Scripts/update-webkit-support-libs: Fetch the expected version
877         number from developer.apple.com, then compare with the version number
878         of the extracted library and of the zipped library to see if anything
879         needs to be done. Removed code that tracked the modified timestamp of
880         the library, as it is no longer needed.
881
882 2010-10-19  Eric Seidel  <eric@webkit.org>
883
884         Reviewed by Adam Barth.
885
886         EWS should test patches with r+
887         https://bugs.webkit.org/show_bug.cgi?id=35460
888
889         * QueueStatusServer/handlers/submittoews.py:
890         * QueueStatusServer/model/queues.py:
891         * Scripts/webkitpy/tool/bot/patchcollection.py: Removed.
892         * Scripts/webkitpy/tool/bot/patchcollection_unittest.py: Removed.
893         * Scripts/webkitpy/tool/commands/queues.py:
894
895 2010-10-19  Eric Seidel  <eric@webkit.org>
896
897         Reviewed by Adam Barth.
898
899         Teach feeder-queue how to feed the EWS bots
900         https://bugs.webkit.org/show_bug.cgi?id=47943
901
902         queues.webkit.org already knew how to accept EWS submissions
903         via /submit-to-ews.  This teaches the feeder queue how to post
904         to that page with any new r? patches it sees.
905
906         * QueueStatusServer/model/activeworkitems_unitest.py: Added.
907          - More unit testing is always a good thing.
908         * Scripts/webkitpy/common/net/bugzilla.py:
909         * Scripts/webkitpy/common/net/statusserver.py:
910         * Scripts/webkitpy/tool/bot/feeders.py:
911         * Scripts/webkitpy/tool/commands/queues.py:
912         * Scripts/webkitpy/tool/commands/queues_unittest.py:
913         * Scripts/webkitpy/tool/mocktool.py:
914
915 2010-10-19  Eric Seidel  <eric@webkit.org>
916
917         Unreviewed, just fixing test-webkitpy.  I'm really on a roll today.
918
919         commit-queue gets stuck when release-patch returns 404
920         https://bugs.webkit.org/show_bug.cgi?id=47935
921
922         Fix test-webkitpy and unittest NetworkTransaction.
923
924         * Scripts/webkitpy/common/net/networktransaction.py:
925         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
926
927 2010-10-19  Eric Seidel  <eric@webkit.org>
928
929         Unreviewed.
930
931         commit-queue gets stuck when release-patch returns 404
932         https://bugs.webkit.org/show_bug.cgi?id=47935
933
934         Turns out ClientForm gets upset if passed an int() instead of a string type.
935         Yay for untestable code.
936
937         * Scripts/webkitpy/common/net/statusserver.py:
938
939 2010-10-19  Eric Seidel  <eric@webkit.org>
940
941         Unreviewed.  Will get Adam's commentary after his meeting
942         for now this gets the commit-cluster back running.
943
944         commit-queue gets stuck when release-patch returns 404
945         https://bugs.webkit.org/show_bug.cgi?id=47935
946
947         I taught NetworkTransaction the basics of 404 handling.
948         We'll want to go back and teach it how to handle urllib2 404's too
949         and then deploy it to the places that want it.
950
951         * QueueStatusServer/handlers/releasepatch.py:
952         * Scripts/webkitpy/common/net/buildbot.py:
953         * Scripts/webkitpy/common/net/networktransaction.py:
954         * Scripts/webkitpy/common/net/statusserver.py:
955
956 2010-10-19  Eric Seidel  <eric@webkit.org>
957
958         Unreviewed.  Fixing typos in my previous commit.
959
960         Make patch release explicit and not a magic part of "retry" status
961         https://bugs.webkit.org/show_bug.cgi?id=47909
962
963         All of these typos again due to our inability to unit
964         test much of this code.  I added one unit test where
965         possible.  activeworkitems_unittest.py will be in a separate patch.
966
967         * QueueStatusServer/handlers/releasepatch.py:
968         * QueueStatusServer/main.py:
969         * QueueStatusServer/model/activeworkitems.py:
970         * QueueStatusServer/model/workitems.py:
971         * QueueStatusServer/model/workitems_unittest.py:
972         * QueueStatusServer/templates/releasepatch.html:
973         * Scripts/webkitpy/common/net/statusserver.py:
974
975 2010-10-19  Tony Chang  <tony@chromium.org>
976
977         Reviewed by Kent Tamura.
978
979         [chromium] Use webkit's TestNetscapePlugIn in DRT mac
980         https://bugs.webkit.org/show_bug.cgi?id=47850
981
982         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Added. Forked
983             because we're going to name our plugin WebKitTestNetscapePlugIn
984             temporarily until the chromium forked plugin goes away.
985
986 2010-10-19  Eric Seidel  <eric@webkit.org>
987
988         Reviewed by Adam Barth.
989
990         Make patch release explicit and not a magic part of "retry" status
991         https://bugs.webkit.org/show_bug.cgi?id=47909
992
993         This moves us another step closer to running r+ patches on the EWS bots.
994         Currently all bots just spam /update-work-items with their list of current
995         work items.  queues.webkit.org uses that data for display.  As part of making
996         the EWS run r+ patches, we're moving the official list of patches-to-process
997         into the server, and feeding them out to bots one at a time.  We need to be
998         able to remove patches from the queues one at a time instead of just spamming
999         /update-work-items with a new complete list.  That's what this patch adds.
1000
1001         * QueueStatusServer/handlers/nextpatch.py:
1002         * QueueStatusServer/handlers/queuestatus.py:
1003         * QueueStatusServer/handlers/releasepatch.py: Added.
1004         * QueueStatusServer/handlers/statusbubble_unittest.py:
1005          - Fix a typo causing test failure.  This was not caught by the bots
1006            because they don't have AppEngineLauncher installed and thus don't run
1007            the QueueStatusServer tests.
1008         * QueueStatusServer/handlers/updatestatus.py:
1009         * QueueStatusServer/model/activeworkitems.py:
1010         * QueueStatusServer/templates/releasepatch.html: Added.
1011         * Scripts/webkitpy/common/net/statusserver.py:
1012         * Scripts/webkitpy/tool/commands/queues.py:
1013         * Scripts/webkitpy/tool/mocktool.py:
1014
1015 2010-10-19  Eric Seidel  <eric@webkit.org>
1016
1017         Reviewed by Adam Barth.
1018
1019         cr-mac bubble has caused status bubbles to wrap
1020         https://bugs.webkit.org/show_bug.cgi?id=47928
1021
1022         We now have too many EWSes to fit in the bugs.webkit.org
1023         status-bubble iframe when more than a couple EWS builds are pending.
1024         To fix this I've reduced the space taken up by queue position,
1025         and also moved cr-mac to the end of the list (since it's going to be
1026         triple-digits for a while).
1027
1028         * QueueStatusServer/model/queues.py:
1029         * QueueStatusServer/templates/statusbubble.html:
1030
1031 2010-10-19  Kenneth Russell  <kbr@google.com>
1032
1033         Reviewed by David Levin.
1034
1035         chromium_gpu port of new-run-webkit-tests must search chromium-gpu directory for expectations
1036         https://bugs.webkit.org/show_bug.cgi?id=47874
1037
1038         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1039         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1040
1041 2010-10-19  Tony Chang  <tony@chromium.org>
1042
1043         Reviewed by Kent Tamura.
1044
1045         [chromium] DumpRenderTree shouldn't put '.' in include path
1046         https://bugs.webkit.org/show_bug.cgi?id=47877
1047
1048         Fix include paths.
1049
1050         * DumpRenderTree/chromium/AccessibilityController.cpp:
1051         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
1052         * DumpRenderTree/chromium/AccessibilityUIElement.h:
1053         * DumpRenderTree/chromium/CppBoundClass.cpp:
1054         * DumpRenderTree/chromium/CppVariant.cpp:
1055         * DumpRenderTree/chromium/CppVariant.h:
1056         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1057         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1058         * DumpRenderTree/chromium/DRTDevToolsCallArgs.h:
1059         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1060         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1061         * DumpRenderTree/chromium/EventSender.cpp:
1062         * DumpRenderTree/chromium/EventSender.h:
1063         * DumpRenderTree/chromium/LayoutTestController.cpp:
1064         * DumpRenderTree/chromium/LayoutTestController.h:
1065         * DumpRenderTree/chromium/MockSpellCheck.cpp:
1066         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1067         * DumpRenderTree/chromium/NotificationPresenter.h:
1068         * DumpRenderTree/chromium/PlainTextController.cpp:
1069         * DumpRenderTree/chromium/Task.cpp:
1070         * DumpRenderTree/chromium/TestNavigationController.h:
1071         * DumpRenderTree/chromium/TestShell.cpp:
1072         * DumpRenderTree/chromium/TestWebWorker.h:
1073         * DumpRenderTree/chromium/TextInputController.cpp:
1074         * DumpRenderTree/chromium/WebPreferences.cpp:
1075         * DumpRenderTree/chromium/WebPreferences.h:
1076         * DumpRenderTree/chromium/WebThemeEngineDRT.cpp:
1077         * DumpRenderTree/chromium/WebThemeEngineDRT.h:
1078         * DumpRenderTree/chromium/WebViewHost.cpp:
1079         * DumpRenderTree/chromium/WebViewHost.h:
1080
1081 2010-10-19  Sam Weinig  <sam@webkit.org>
1082
1083         Reviewed by Dan Bernstein.
1084
1085         Need to include WKErrorRef in the WKPageDidFail... functions
1086         https://bugs.webkit.org/show_bug.cgi?id=47871
1087
1088         Update tools for new parameter in failure callbacks.
1089
1090         * MiniBrowser/mac/BrowserWindowController.m:
1091         (didFailProvisionalLoadWithErrorForFrame):
1092         (didFailLoadWithErrorForFrame):
1093         (-[BrowserWindowController updateProvisionalURLForFrame:]):
1094         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
1095         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
1096         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1097         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
1098         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1099         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1100
1101 2010-10-19  Luiz Agostini  <luiz.agostini@openbossa.org>
1102
1103         Reviewed by Antti Koivisto.
1104
1105         [Qt] WebKit2 MacOS build fix
1106         https://bugs.webkit.org/show_bug.cgi?id=47897
1107
1108         Qt WebKit2 MacOS build fix.
1109
1110         * WebKitTestRunner/PlatformWebView.h:
1111         * WebKitTestRunner/qt/TestControllerQt.cpp:
1112
1113 2010-10-19  Adam Barth  <abarth@webkit.org>
1114
1115         Reviewed by Eric Seidel.
1116
1117         webkit-patch stats the filesystem too many times
1118         https://bugs.webkit.org/show_bug.cgi?id=47883
1119
1120         This patch attempts to cache the list of changed files more agressively
1121         and to use that list to compute the diff instead of stating the file
1122         system again.
1123
1124         * Scripts/webkitpy/common/checkout/api.py:
1125         * Scripts/webkitpy/common/checkout/scm.py:
1126         * Scripts/webkitpy/tool/mocktool.py:
1127         * Scripts/webkitpy/tool/steps/abstractstep.py:
1128         * Scripts/webkitpy/tool/steps/editchangelog.py:
1129         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1130
1131 2010-10-19  David Kilzer  <ddkilzer@apple.com>
1132
1133         <http://webkit.org/b/47741> Make sort-Xcode-project-file a little more friendly
1134
1135         Reviewed by Darin Adler.
1136
1137         * Scripts/sort-Xcode-project-file:
1138         - Don't print an error message about missing arguments when
1139           -h|--help is used.
1140         - Allow Xcode project files to be specified as Project.xcodeproj
1141           instead of Project.xcodeproj/project.pbxproj.
1142
1143 2010-10-18  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1144
1145         Reviewed by Andreas Kling.
1146
1147         [Qt] QtTestBrowser: Prevent calling load() directly from loadFinished() in robot mode.
1148         https://bugs.webkit.org/show_bug.cgi?id=47809
1149
1150         Connecting a call to load from the loadFinished signal can cause
1151         re-entrance crashes in WebCore. This patch uses a timer to do so,
1152         also giving some time to subsequent frames to finish loading.
1153
1154         * QtTestBrowser/urlloader.cpp:
1155         (UrlLoader::UrlLoader):
1156         (UrlLoader::loadNext):
1157         (UrlLoader::checkIfFinished):
1158         (UrlLoader::frameLoadStarted):
1159         (UrlLoader::frameLoadFinished):
1160         * QtTestBrowser/urlloader.h:
1161
1162 2010-10-19  Sergio Villar Senín  <svillar@igalia.com>
1163
1164         Reviewed by Xan Lopez.
1165
1166         [GTK] http/history tests are failing
1167         https://bugs.webkit.org/show_bug.cgi?id=36173
1168
1169         Clear the history each time a test is run. Return the actual
1170         history item count when calling
1171         LayoutTestController::webHistoryItemCount
1172
1173         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1174         (resetDefaultsToConsistentValues):
1175         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1176         (LayoutTestController::webHistoryItemCount):
1177
1178 2010-10-18  Eric Seidel  <eric@webkit.org>
1179
1180         Reviewed by Adam Barth.
1181
1182         Add Chromium Mac EWS to the list of queues at queues.webkit.org
1183         https://bugs.webkit.org/show_bug.cgi?id=47878
1184
1185         * QueueStatusServer/model/queues.py:
1186
1187 2010-10-18  Eric Seidel  <eric@webkit.org>
1188
1189         Reviewed by Adam Barth.
1190
1191         queues.webkit.org/next_patch is always 404
1192         https://bugs.webkit.org/show_bug.cgi?id=47881
1193
1194         With the addition of the Queue class, I changed most of the
1195         code to lookup WorkItems using get_or_insert with a key_name
1196         instead of WorkItems.all().filter(queue_name=).
1197         Because the new get_or_insert code uses an explicit key_name
1198         (which is obviously different from the previously autogenerated
1199         ones), there were new WorkItem records created for each queue.
1200         However, some parts of the code still use WorkItems.all().filter,
1201         thus some parts were getting the new record and some parts the old record.
1202
1203         The same basic bug was occurring with ActiveWorkItems, because I
1204         changed the key_name for that class as well.
1205
1206         To fix this I've moved more of the code over to using Queue.*work_items.
1207         I've also enabled the datastore_admin (new in GAE 1.3.8) so that
1208         we can go delete the old WorkItems records.
1209         I also changed remote_api to use the new builtin: syntax (also added in GAE 1.3.8).
1210
1211         * QueueStatusServer/app.yaml:
1212         * QueueStatusServer/handlers/queuestatus.py:
1213         * QueueStatusServer/handlers/recentstatus.py:
1214         * QueueStatusServer/handlers/updatestatus.py:
1215         * QueueStatusServer/handlers/updateworkitems.py:
1216
1217 2010-10-18  Eric Seidel  <eric@webkit.org>
1218
1219         Reviewed by Adam Barth.
1220
1221         Correct a bunch of typos in QueueStatusServer
1222         https://bugs.webkit.org/show_bug.cgi?id=47880
1223
1224         These are all due to our complete lack of unit testing in QueueStatusServer.
1225         I added a couple unit tests to cover a few of these fixes, but most of these
1226         are still only caught by actually running the application.
1227
1228         * QueueStatusServer/handlers/nextpatch.py:
1229         * QueueStatusServer/handlers/statusbubble.py:
1230         * QueueStatusServer/handlers/statusbubble_unittest.py: Added.
1231         * QueueStatusServer/handlers/updateworkitems.py:
1232         * QueueStatusServer/model/attachment.py:
1233         * QueueStatusServer/model/queuepropertymixin.py:
1234         * QueueStatusServer/model/queuepropertymixin_unittest.py:
1235         * QueueStatusServer/model/workitems.py:
1236         * QueueStatusServer/model/workitems_unittest.py: Added.
1237
1238 2010-10-18  Adam Barth  <abarth@webkit.org>
1239
1240         Disable this test because it's failing on the bots and the authors
1241         aren't around to fix it.
1242
1243         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1244
1245 2010-10-18  Adam Barth  <abarth@webkit.org>
1246
1247         Reviewed by Eric Seidel.
1248
1249         CC authors of flaky tests when the commit-queue hits a flaky test
1250         https://bugs.webkit.org/show_bug.cgi?id=47872
1251
1252         * Scripts/webkitpy/common/checkout/api.py:
1253         * Scripts/webkitpy/common/net/layouttestresults.py:
1254         * Scripts/webkitpy/tool/commands/queues.py:
1255         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1256         * Scripts/webkitpy/tool/mocktool.py:
1257
1258 2010-10-18  Eric Seidel  <eric@webkit.org>
1259
1260         Reviewed by Adam Barth.
1261
1262         Make it possible to run a chromium-mac-ews builder
1263         https://bugs.webkit.org/show_bug.cgi?id=47876
1264
1265         Since we can't run Mac OS X in a VM, we need to only run committer patches.
1266         There was a multiple inheritance problem which was holding this patch back,
1267         but I decided to just ignore the problem and go with a functional hack for now.
1268
1269         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1270         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1271
1272 2010-10-18  Kenneth Russell  <kbr@google.com>
1273
1274         Reviewed by Tony Chang.
1275
1276         Regression in run_webkit_tests_unittest from r70017
1277         https://bugs.webkit.org/show_bug.cgi?id=47875
1278
1279         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1280
1281 2010-10-18  Adam Barth  <abarth@webkit.org>
1282
1283         Reviewed by Eric Seidel.
1284
1285         Implement webkit-patch suggest-reviewers
1286         https://bugs.webkit.org/show_bug.cgi?id=47866
1287
1288         * Scripts/webkitpy/common/checkout/api.py:
1289             - The main logic.  We look at the last five changes to each
1290               modified (non-ChangeLog) file and collect up the reviewers of
1291               those changes as well as the authors of those changes who are
1292               reviewers.
1293         * Scripts/webkitpy/common/checkout/api_unittest.py:
1294             - Test the logic with some fun mocks.
1295         * Scripts/webkitpy/common/checkout/scm.py:
1296             - Fix a bug when you have local git commits.
1297         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1298             - Test that the bug is fixed.
1299         * Scripts/webkitpy/tool/commands/queries.py:
1300             - Add the query.
1301
1302 2010-10-18  Kenneth Russell  <kbr@google.com>
1303
1304         Reviewed by Eric Seidel.
1305
1306         new-run-webkit-tests produces corrupt PNG baselines on Windows
1307         https://bugs.webkit.org/show_bug.cgi?id=47867
1308
1309         * Scripts/webkitpy/layout_tests/port/base.py:
1310
1311 2010-10-18  Eric Seidel  <eric@webkit.org>
1312
1313         Reviewed by Adam Barth.
1314
1315         Make it possible to submit patches to the EWS bots
1316         https://bugs.webkit.org/show_bug.cgi?id=47869
1317
1318         * QueueStatusServer/handlers/nextpatch.py:
1319          - Move more logic into Queue, so that it can be shared with SubmitToEWS.
1320         * QueueStatusServer/handlers/queuestatus.py:
1321          - Fix two typos from a previous commit.
1322         * QueueStatusServer/handlers/submittoews.py: Added.
1323         * QueueStatusServer/handlers/updatestatus.py:
1324          - Use the new is_retry_request method to share this (hacky) code with SubmitToEWS
1325         * QueueStatusServer/main.py:
1326          - Add /submit-to-ews
1327         * QueueStatusServer/model/queuepropertymixin.py:
1328          - Fix circular imports caused by adding Queue.work_items()
1329         * QueueStatusServer/model/queues.py:
1330          - Add work_items() and active_work_items()
1331         * QueueStatusServer/model/queuestatus.py:
1332         * QueueStatusServer/model/workitems.py:
1333          - Add transaction-safe add/remove methods.
1334         * QueueStatusServer/templates/submittoews.html: Added.
1335
1336 2010-10-18  Eric Seidel  <eric@webkit.org>
1337
1338         Reviewed by Adam Barth.
1339
1340         Deploy Queue class in more places throughout QueueStatusServer
1341         https://bugs.webkit.org/show_bug.cgi?id=47855
1342
1343         I also caught two typos from the previous change.  Unfortunately
1344         I don't yet know how to unittest request handlers yet.
1345
1346         * QueueStatusServer/handlers/dashboard.py:
1347         * QueueStatusServer/handlers/statusbubble.py:
1348         * QueueStatusServer/handlers/updateworkitems.py:
1349         * QueueStatusServer/model/activeworkitems.py:
1350         * QueueStatusServer/model/attachment.py:
1351         * QueueStatusServer/model/queuepropertymixin.py: Added.
1352         * QueueStatusServer/model/queuepropertymixin_unittest.py: Added.
1353         * QueueStatusServer/model/queuestatus.py:
1354         * QueueStatusServer/model/workitems.py:
1355
1356 2010-10-18  Adam Barth  <abarth@webkit.org>
1357
1358         Reviewed by Eric Seidel.
1359
1360         scm.py should be able tell us what revisions made changes to a given file
1361         https://bugs.webkit.org/show_bug.cgi?id=47863
1362
1363         Look again, your SCM.py can now log files.
1364
1365         * Scripts/webkitpy/common/checkout/scm.py:
1366         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1367
1368 2010-10-18  Dirk Pranke  <dpranke@chromium.org>
1369
1370         Reviewed by Eric Siedel.
1371
1372         new-run-webkit-tests: clean up the options-parsing code in the port
1373         classes.
1374         
1375         This change modifies the Port interface to have a get_option() and
1376         set_option_default() method for accessing the options argument
1377         passed to the constructor. If the constructor is not passed an
1378         options argument, we default to a MockOptions() argument from
1379         mocktool, which has the same semantics we want.
1380
1381         Note that there is a disadvantage to port.get_option('foo') over
1382         port._options.foo, which is that you lose some of the checking
1383         for whether 'foo' is set (typos result in the default value, not
1384         an exception being raised. This is desired in this case, since the
1385         Port class is not allowed to assume that options does have any
1386         particular values set, and so this change ensures that all of
1387         the subclasses are following the same, intended, logic.
1388
1389         Arguably this is the wrong semantics to have, and the Port
1390         classes should be able to assume a default set of
1391         attributes/arguments, but that change will need to wait for a
1392         different CL where we can modify new-run-webkit-tests to pull a
1393         list of arguments from the port factory routines.
1394
1395         Also, add unit tests for webkitpy.tool.mocktool.MockOptions .
1396
1397         https://bugs.webkit.org/show_bug.cgi?id=47510
1398
1399         * Scripts/webkitpy/layout_tests/port/base.py:
1400         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1401         * Scripts/webkitpy/layout_tests/port/chromium.py:
1402         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1403         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1404         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1405         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1406         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1407         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1408         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1409         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1410         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1411         * Scripts/webkitpy/layout_tests/port/test.py:
1412         * Scripts/webkitpy/layout_tests/port/webkit.py:
1413         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1414         * Scripts/webkitpy/tool/mocktool_unittest.py: Added.
1415
1416 2010-10-18  Dirk Pranke  <dpranke@chromium.org>
1417
1418         Reviewed by Eric Seidel.
1419
1420         Re-submit a revised version of r69638 - enabling new-run-webkit-tests
1421         under cygwin. The initial version had a bug in base:uri_to_test_name
1422         that was causing tests to fail. This version corrects that bug, but
1423         also makes the code safer by calling cygpath more reliably, and
1424         leaving a long-running cygpath process open.
1425
1426         This patch also corrects a couple of minor bugs in http_lock_unittest,
1427         chromium_unittest, and dedpulicate_tests_unittest that showed up
1428         while testing this.
1429
1430         https://bugs.webkit.org/show_bug.cgi?id=47220
1431
1432         * Scripts/webkitpy/common/system/path.py:
1433         * Scripts/webkitpy/common/system/path_unittest.py:
1434         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1435         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1436         * Scripts/webkitpy/layout_tests/port/base.py:
1437         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1438         * Scripts/webkitpy/layout_tests/port/chromium.py:
1439         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1440         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
1441         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1442
1443 2010-10-18  Eric Seidel  <eric@webkit.org>
1444
1445         Reviewed by Adam Barth.
1446
1447         Add Queue class and add minimal unittesting of QueueStatusServer code
1448         https://bugs.webkit.org/show_bug.cgi?id=47847
1449
1450         * QueueStatusServer/handlers/dashboard.py:
1451         * QueueStatusServer/handlers/queuestatus.py:
1452         * QueueStatusServer/handlers/recentstatus.py:
1453         * QueueStatusServer/handlers/statusbubble.py:
1454         * QueueStatusServer/handlers/updateworkitems.py:
1455         * QueueStatusServer/model/attachment.py:
1456         * QueueStatusServer/model/queues.py:
1457         * QueueStatusServer/model/queues_unittest.py: Added.
1458         * QueueStatusServer/model/svnrevision.py:
1459         * Scripts/test-webkitpy:
1460         * Scripts/webkitpy/test/main.py:
1461
1462 2010-10-18  Anders Carlsson  <andersca@apple.com>
1463
1464         Fix build.
1465
1466         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1467         (handleEventCarbon):
1468
1469 2010-10-18  Stuart Morgan  <stuartmorgan@chromium.org>
1470
1471         Reviewed by Eric Seidel.
1472
1473         Switch to using the new Carbon NPAPI event declarations, and remove
1474         the old ones.
1475
1476         https://bugs.webkit.org/show_bug.cgi?id=40784
1477
1478         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1479         (handleEventCarbon):
1480
1481 2010-10-18  David Levin  <levin@chromium.org>
1482
1483         Reviewed by Adam Barth.
1484
1485         check-webkit-style should treat the GObject binding directory like other GTK directories.
1486         https://bugs.webkit.org/show_bug.cgi?id=47796
1487
1488         * Scripts/webkitpy/style/checker.py: Added the GObject binding directory
1489         with the other gtk directories (and fixed typo).
1490
1491 2010-10-18  David Levin  <levin@chromium.org>
1492
1493         Reviewed by Oliver Hunt.
1494
1495         check-webkit-style needs to ignore underscores in opcode names and vm_throw
1496         https://bugs.webkit.org/show_bug.cgi?id=47789
1497
1498         * Scripts/webkitpy/style/checker.py: Added the exception for the assembler directory.
1499         * Scripts/webkitpy/style/checkers/cpp.py: Added special cased names.
1500         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added unit tests for the special cases.
1501
1502 2010-10-18  MORITA Hajime  <morrita@google.com>
1503
1504         Reviewed by Kent Tamura.
1505
1506         TextInputController.hasSpellingMarkers() should be owned by LayoutTestController
1507         https://bugs.webkit.org/show_bug.cgi?id=47659
1508         
1509         Moved hasSpellingMarkers() from TextInputController to
1510         LayoutTestController.  Currently the implementation is available
1511         only for Mac and for Chromium.
1512
1513         * DumpRenderTree/LayoutTestController.cpp:
1514         (hasSpellingMarkerCallback):
1515         (LayoutTestController::staticFunctions):
1516         * DumpRenderTree/LayoutTestController.h:
1517         * DumpRenderTree/chromium/LayoutTestController.cpp:
1518         (LayoutTestController::LayoutTestController):
1519         (LayoutTestController::hasSpellingMarker):
1520         * DumpRenderTree/chromium/LayoutTestController.h:
1521         * DumpRenderTree/chromium/TextInputController.cpp:
1522         (TextInputController::TextInputController):
1523         (TextInputController::makeAttributedString):
1524         * DumpRenderTree/chromium/TextInputController.h:
1525         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1526         (LayoutTestController::hasSpellingMarker):
1527         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1528         (LayoutTestController::hasSpellingMarker):
1529         * DumpRenderTree/mac/TextInputController.m:
1530         (+[TextInputController isSelectorExcludedFromWebScript:]):
1531         (+[TextInputController webScriptNameForSelector:]):
1532         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1533         (LayoutTestController::hasSpellingMarker):
1534         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1535         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1536         (LayoutTestController::hasSpellingMarker):
1537         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1538         (LayoutTestController::hasSpellingMarker):
1539
1540 2010-10-18  Adam Barth  <abarth@webkit.org>
1541
1542         Reviewed by David Levin.
1543
1544         commit-queue's flaky test notice is very Pythony
1545         https://bugs.webkit.org/show_bug.cgi?id=47790
1546
1547         This patch make the list of tests delimted by \n instead of just
1548         converting the array to a string.
1549
1550         * Scripts/webkitpy/tool/commands/queues.py:
1551         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1552
1553 2010-10-14  Antonio Gomes  <agomes@rim.com>
1554
1555         Reviewed by Martin Robinson and Xan Lopez.
1556
1557         [Gtk]: DRT does not support frame flattening testing
1558         https://bugs.webkit.org/show_bug.cgi?id=38650
1559
1560         Implement DRT's support for toggling on/off frame flattening
1561         support.
1562
1563         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1564         (resetDefaultsToConsistentValues):
1565         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1566         (LayoutTestController::setFrameFlatteningEnabled):
1567
1568 2010-10-15  Dirk Pranke  <dpranke@chromium.org>
1569
1570         Reviewed by Eric Siedel.
1571
1572         mocktool.MockOptions is inheriting from Mock, which has the side
1573         effect of defaulting any attribute to another MockObject. So,
1574         MockOptions().foo would always evaluate to true. This was
1575         covering over bugs in the unit tests, and is probably the wrong
1576         default behavior for anything attempting to mock out the options
1577         argument returned from optparse.parse_args().
1578
1579         This patch changes the default behavior. The new MockOptions()
1580         class takes an optional list of keyword parameters to set; this
1581         patch doesn't use that feature but the fix for bug 47510 will.
1582
1583         Also, this patch just fills in the default values necessary to
1584         get all of the tests to pass; I didn't stare at each test by
1585         hand to determine the "right" values. We can either fix that in
1586         subsequent patches or let me know if we want to do that now (and
1587         give me some guidance on what those values might want to be).
1588
1589         https://bugs.webkit.org/show_bug.cgi?id=47709
1590
1591         * Scripts/webkitpy/tool/commands/commandtest.py:
1592         * Scripts/webkitpy/tool/commands/download_unittest.py:
1593         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1594         * Scripts/webkitpy/tool/mocktool.py:
1595         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1596         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
1597
1598 2010-10-15  Simon Fraser  <simon.fraser@apple.com>
1599
1600         Fix the build; need to add new slot to PageUIClient callbacks.
1601
1602         * MiniBrowser/mac/BrowserWindowController.m:
1603         (-[BrowserWindowController awakeFromNib]):
1604         * WebKitTestRunner/TestController.cpp:
1605         (WTR::createOtherPage):
1606         (WTR::TestController::initialize):
1607
1608 2010-10-15  Simon Fraser  <simon.fraser@apple.com>
1609
1610         Add Matt Delaney to committers.py.
1611
1612         * Scripts/webkitpy/common/config/committers.py:
1613
1614 2010-10-15  Tony Chang  <tony@chromium.org>
1615
1616         Reviewed by Kent Tamura.
1617
1618         [chromium] compile TestNetscapePlugIn on Chromium mac
1619         https://bugs.webkit.org/show_bug.cgi?id=47633
1620
1621         * DumpRenderTree/DumpRenderTree.gypi: files to compile
1622         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Use ifdef because gcc was complaining
1623         (NP_GetEntryPoints):
1624         (NPP_New):
1625         (NPP_Destroy):
1626         (NPP_HandleEvent):
1627         (NPP_GetValue):
1628         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Added.
1629         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Added.
1630         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Added.
1631
1632 2010-10-15  Leandro Pereira  <leandro@profusion.mobi>
1633
1634         Reviewed by Gustavo Noronha Silva.
1635
1636         build-webkit: Should die when make fails when build a CMake project
1637         https://bugs.webkit.org/show_bug.cgi?id=47726
1638
1639         * Scripts/webkitdirs.pm: If make fails, die immediately.
1640
1641 2010-10-15  Sheriff Bot  <webkit.review.bot@gmail.com>
1642
1643         Unreviewed, rolling out r69809.
1644         http://trac.webkit.org/changeset/69809
1645         https://bugs.webkit.org/show_bug.cgi?id=47725
1646
1647         Broke chromium mac compile (Requested by japhet on #webkit).
1648
1649         * DumpRenderTree/DumpRenderTree.gypi:
1650         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1651         (NP_GetEntryPoints):
1652         (NPP_New):
1653         (NPP_Destroy):
1654         (NPP_HandleEvent):
1655         (NPP_GetValue):
1656         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
1657         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
1658         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
1659
1660 2010-10-15  Adam Barth  <abarth@webkit.org>
1661
1662         Reviewed by Adam Barth.
1663
1664         test-webkitpy fails on Linux
1665         https://bugs.webkit.org/show_bug.cgi?id=47713
1666
1667         The old code failed on Linux because the MacPort tries to read
1668         something out of platform that doesn't make sense on Linux.
1669
1670         * Scripts/webkitpy/tool/mocktool.py:
1671
1672 2010-10-14  Balazs Kelemen  <kbalazs@webkit.org>
1673
1674         Reviewed by Kenneth Rohde Christiansen.
1675
1676         [Qt] WTR is sloooow
1677         https://bugs.webkit.org/show_bug.cgi?id=47695
1678
1679         * WebKitTestRunner/qt/TestControllerQt.cpp:
1680         Change the timer interval of RunUntilConditionLoop from
1681         50 milliseconds to 1 to avoid wasting time after the 
1682         test had been finished.
1683
1684 2010-10-14  Eric Seidel  <eric@webkit.org>
1685
1686         Unreviewed, just fixing an exception seen on the commit-queue.
1687
1688         I should have unit tested this function before.
1689
1690         * Scripts/webkitpy/tool/commands/queues.py:
1691         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1692
1693 2010-10-14  Eric Seidel  <eric@webkit.org>
1694
1695         Reviewed by Adam Barth.
1696
1697         commit-queue should not fail patches due to flaky tests
1698         https://bugs.webkit.org/show_bug.cgi?id=47647
1699
1700         This patch makes it so that the *same* flaky test has to fail
1701         twice in a row to have a false negative from a flaky test.
1702
1703         If different flaky tests fail (or if a test fails and then passes
1704         in a second run) then we will warn in the bug that we encountered
1705         a flaky test.
1706
1707         This patch grew to include moving port off of steps onto tool
1708         (which Adam wrote and then I integrated), as well as removing the
1709         use of tool from CommitQueueTask.
1710
1711         * Scripts/webkitpy/common/config/ports.py:
1712          - Added a layout_test_results_path method.  This covers old-run-webkit-tests
1713            but doesn't cover NRWT.  This is probably not the long term solution, but
1714            putting this knowledge on port makes more sense than in LayoutTestResults.
1715         * Scripts/webkitpy/common/net/buildbot.py:
1716          - LayoutTestResults shouldn't know how to fetch from the network, make
1717            the Build code do that instead.
1718         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1719          - Code style fix.
1720         * Scripts/webkitpy/common/net/layouttestresults.py:
1721          - Remove code for reading from the network.
1722         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1723          - Test the new entrypoint.
1724         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1725          - Make the delegate interface explicit.
1726          - Remove the _tool member, since using the delegate for
1727            everything is cleaner.
1728          - Teach the testing logic how to deal with flaky tests.
1729         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1730          - Update to match the CommitQueueTask changes.
1731         * Scripts/webkitpy/tool/commands/queues.py:
1732          - Use the new CommitQueueTaskDelegate interface.
1733         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1734          - Fix the SecondThoughtsCommitQueue test which was broken.
1735          - Add a new test to make sure the flaky test reporting works.
1736         * Scripts/webkitpy/tool/main.py:
1737          - Store the port on the tool object.
1738         * Scripts/webkitpy/tool/mocktool.py:
1739          - Add a port() accessor to MockTool
1740         * Scripts/webkitpy/tool/steps/abstractstep.py:
1741          - Move port() off of Step and onto Tool.
1742         * Scripts/webkitpy/tool/steps/build.py:
1743         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1744         * Scripts/webkitpy/tool/steps/runtests.py:
1745         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1746          - Two tests with the same name!  only the latter was being run.
1747         * Scripts/webkitpy/tool/steps/update.py:
1748
1749 2010-10-14  Dirk Pranke  <dpranke@chromium.org>
1750
1751         Reviewed by Eric Seidel.
1752
1753         new-run-webkit-tests will now handle missing Ruby installs (or
1754         missing PrettyPatch scripts) more cleanly - previously this
1755         would be detected when we actually tried to create the diff, and
1756         the error message was obscure. Now we'll log a warning up front
1757         and otherwise be silent.
1758
1759         This change also refactors some global variables to be class or
1760         instance variables to be slightly more testable and more
1761         modular. There are no cases where we create lots of port objects
1762         and can't afford to test for configurations repeatedly, so
1763         there's no performance concern here.
1764
1765         https://bugs.webkit.org/show_bug.cgi?id=47466
1766
1767         * Scripts/webkitpy/layout_tests/port/base.py:
1768         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1769         * Scripts/webkitpy/layout_tests/port/chromium.py:
1770
1771 2010-10-08  Martin Robinson  <mrobinson@igalia.com>
1772
1773         Reviewed by Xan Lopez.
1774
1775         [GTK] Form controls do not respect GTK+ font size
1776         https://bugs.webkit.org/show_bug.cgi?id=47134
1777
1778         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1779         (initializeGtkFontSettings): Initialize the font control size when running
1780         DumpRenderTree to a standard value.
1781
1782 2010-10-14  Tony Chang  <tony@chromium.org>
1783
1784         Reviewed by Kent Tamura.
1785
1786         [chromium] compile TestNetscapePlugIn on Chromium mac
1787         https://bugs.webkit.org/show_bug.cgi?id=47633
1788
1789         * DumpRenderTree/DumpRenderTree.gypi: files to compile
1790         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Use ifdef because gcc was complaining
1791         (NP_GetEntryPoints):
1792         (NPP_New):
1793         (NPP_Destroy):
1794         (NPP_HandleEvent):
1795         (NPP_GetValue):
1796         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Added.
1797         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Added.
1798         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Added.
1799
1800 2010-10-14  Victor Wang  <victorw@chromium.org>
1801
1802         Reviewed by Nate Chapin.
1803
1804         [Chromium] Fix rebaseline_chromium_webkit_tests to use 0 tolerance image diff.
1805
1806         https://bugs.webkit.org/show_bug.cgi?id=47686
1807
1808         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1809
1810 2010-10-14  Eric Seidel  <eric@webkit.org>
1811
1812         Reviewed by Adam Barth.
1813
1814         test-webkitpy spews Delegate terminated queue messages
1815         https://bugs.webkit.org/show_bug.cgi?id=47678
1816
1817         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1818
1819 2010-10-14  Adam Roben  <aroben@apple.com>
1820
1821         Test that pressing the Alt key generates a WM_SYSCOMMAND message
1822
1823         Test for <http://webkit.org/b/47671> <rdar://problem/8435594> Pressing
1824         the Alt key when MiniBrowser's WKView is focused doesn't send focus to
1825         the menu bar
1826
1827         Reviewed by Steve Falkenburg.
1828
1829         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added
1830         TestWebKitAPI/win to the include path so that WindowMessageObserver
1831         can be found.
1832
1833         * TestWebKitAPI/PlatformWebView.h: Added simulateAltKeyPress and
1834         Windows-specific members.
1835         (TestWebKitAPI::PlatformWebView::setParentWindowMessageObserver):
1836         Added this simple setter.
1837
1838         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp: Added.
1839         (TestWebKitAPI::WMSysCommandObserver::WMSysCommandObserver):
1840         Initialize our lone data member.
1841         (TestWebKitAPI::WMSysCommandObserver::windowDidReceiveWMSysCommand):
1842         Simple getter.
1843         (TestWebKitAPI::WMSysCommandObserver::windowReceivedMessage): Record
1844         when a WM_SYSCOMMAND message is received.
1845         (TestWebKitAPI::didNotHandleKeyEventCallback): Record when a
1846         WM_SYSKEYUP message is not handled.
1847         (TestWebKitAPI::WebKit2_AltKeyGeneratesWMSysCommand): Simulate
1848         pressing the Alt key and check that a WM_SYSCOMMAND message got sent
1849         to the WKView's parent window.
1850
1851         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
1852         (TestWebKitAPI::PlatformWebView::registerWindowClass): Made this a
1853         member function so it could access PlatformWebView::wndProc. Use
1854         PlatformWebView::wndProc as the WNDPROC.
1855         (TestWebKitAPI::PlatformWebView::PlatformWebView): Initialize our new
1856         data member and pass the this pointer to CreateWindowEx so we can
1857         store it on the HWND.
1858         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Moved some
1859         constants from here to the top of the file.
1860         (TestWebKitAPI::PlatformWebView::simulateAltKeyPress): Added. Sends
1861         the same messages that Notepad receives when you press the Alt key.
1862         (TestWebKitAPI::PlatformWebView::wndProc): Added.
1863           - When WM_CREATE is received, we set the PlatformWebView instance
1864             pointer as a property on the HWND so we can access it later.
1865           - For other messages, we try to get the PlatformWebView instance
1866             pointer from the HWND property.
1867           - When WM_NCDESTROY is received (which is the last message we will
1868             receive), we remove the PlatformWebView instance property.
1869           - Pass messages to the parent window's message observer, if there is
1870             one.
1871           - Pass all messages through to ::DefWindowProcW.
1872
1873         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added WindowMessageObserver
1874         and AltKeyGeneratesWMSysCommand.
1875
1876         * TestWebKitAPI/win/WindowMessageObserver.h: Added. This class can be
1877         used to observe messages sent to one or more windows.
1878
1879 2010-10-01  Martin Robinson  <mrobinson@igalia.com>
1880
1881         Reviewed by Holger Freyther.
1882
1883         [GTK] REGRESSION: FreeType backend does not respect XSettings font settings after r68558
1884         https://bugs.webkit.org/show_bug.cgi?id=47033
1885
1886         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1887         (initializeGtkFontSettings): Added this method which initializes XSettings
1888         font settings to consistent values before running a test. For the one test
1889         in which we need subpixel aliasing turned on, do that.
1890         (initializeFonts): Accepts a testURL parameter now and delegates to initializeGtkFontSettings.
1891         (runTest): Pass the testURL to initializeFonts.
1892
1893 2010-10-14  Adam Barth  <abarth@webkit.org>
1894
1895         Reviewed by Eric Seidel.
1896
1897         ChromiumXVFBPort.run_webkit_tests_command has infinite recursion
1898         https://bugs.webkit.org/show_bug.cgi?id=47655
1899
1900         * Scripts/webkitpy/common/config/ports.py:
1901         * Scripts/webkitpy/common/config/ports_unittest.py:
1902
1903 2010-10-13  Eric Seidel  <eric@webkit.org>
1904
1905         Reviewed by Adam Barth.
1906
1907         beat diff_parser with the ugly stick
1908         https://bugs.webkit.org/show_bug.cgi?id=47626
1909
1910         * Scripts/webkitpy/common/checkout/diff_parser.py:
1911         * Scripts/webkitpy/style/patchreader.py:
1912         * Scripts/webkitpy/style/patchreader_unittest.py:
1913
1914 2010-10-13  Eric Seidel  <eric@webkit.org>
1915
1916         Reviewed by Adam Barth.
1917
1918         Break LayoutTestResults out into its own file
1919         https://bugs.webkit.org/show_bug.cgi?id=47637
1920
1921         * Scripts/webkitpy/common/net/buildbot.py:
1922         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1923         * Scripts/webkitpy/common/net/layouttestresults.py: Added.
1924         * Scripts/webkitpy/common/net/layouttestresults_unittest.py: Added.
1925
1926 2010-10-13  Adam Barth  <abarth@webkit.org>
1927
1928         Unreviewed.
1929
1930         Chromium port can't run JavaScriptCore tests
1931         https://bugs.webkit.org/show_bug.cgi?id=47654
1932
1933         This lets webkit-patch build-and-test work on Chromium.
1934
1935         * Scripts/webkitpy/common/config/ports.py:
1936         * Scripts/webkitpy/tool/steps/runtests.py:
1937
1938 2010-10-13  Adam Barth  <abarth@webkit.org>
1939
1940         Reviewed by Eric Seidel.
1941
1942         Make --port a global option and pass the port information to the commit-queue subprocess
1943         https://bugs.webkit.org/show_bug.cgi?id=47650
1944
1945         This patch paves the way to run the commit-queue on a non-Mac port.
1946
1947         * Scripts/webkitpy/tool/commands/queues.py:
1948         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1949         * Scripts/webkitpy/tool/commands/queuestest.py:
1950         * Scripts/webkitpy/tool/main.py:
1951         * Scripts/webkitpy/tool/steps/options.py:
1952         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1953         * Scripts/webkitpy/tool/steps/runtests.py:
1954         * Scripts/webkitpy/tool/steps/update.py:
1955
1956 2010-10-13  Adam Barth  <abarth@webkit.org>
1957
1958         Reviewed by Eric Seidel.
1959
1960         Introduce the ChromiumXVFBPort for running commit-queue on EC2
1961         https://bugs.webkit.org/show_bug.cgi?id=47653
1962
1963         I'm not entirely sure this is the best way to do this, but we need to
1964         run the tests under XVFB on EC2 because the EC2 instances don't have a
1965         real monitor hooked up.  This patch adds a ChromiumXVFBPort that runs
1966         that way.  The idea is that XVFB is like a platform for the Chromium
1967         port, but we don't have a real notion of platform separate from port.
1968
1969         * Scripts/webkitpy/common/config/ports.py:
1970
1971 2010-10-13  Sergio Villar Senin  <svillar@igalia.com>
1972
1973         Reviewed by Martin Robinson.
1974
1975         [GTK] Add HTTP caching support
1976         https://bugs.webkit.org/show_bug.cgi?id=44261
1977
1978         Add include paths for the new soup HTTP cache code.
1979
1980         * GNUmakefile.am: Add paths for the new soup HTTP cache code.
1981
1982 2010-10-13  Yi Shen  <yi.4.shen@nokia.com>
1983
1984         Reviewed by Antonio Gomes.
1985
1986         [Qt] QtTestBrowser shows two Url input fields
1987         https://bugs.webkit.org/show_bug.cgi?id=47613
1988
1989         * QtTestBrowser/mainwindow.cpp:
1990         (MainWindow::MainWindow):
1991         (MainWindow::buildUI):
1992
1993 2010-10-13  Yi Shen  <yi.4.shen@nokia.com>
1994
1995         Reviewed by Tony Chang.
1996
1997         [gdb] Add pretty-print supports for UString, Identifier and JSString
1998         https://bugs.webkit.org/show_bug.cgi?id=47601
1999
2000         * gdb/webkit.py:
2001
2002 2010-10-13  Adam Barth  <abarth@webkit.org>
2003
2004         Reviewed by Eric Seidel.
2005
2006         Add list of Ubuntu packages needed by the EWS bots
2007         https://bugs.webkit.org/show_bug.cgi?id=47628
2008
2009         I've been copy/pasting this list between bots, but it's better to have
2010         this checked in.
2011
2012         * EWSTools/ubuntu-ews-packages: Added.
2013
2014 2010-10-13  Leandro Pereira  <leandro@profusion.mobi>
2015
2016         Reviewed by Csaba Osztrogonác.
2017
2018         [EFL] Adds a build slave.
2019         https://bugs.webkit.org/show_bug.cgi?id=47290
2020
2021         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
2022         entry for a release build of the EFL port.
2023         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
2024         flag to build the EFL port.
2025
2026 2010-10-13  Adam Barth  <abarth@webkit.org>
2027
2028         Reviewed by Csaba Osztrogonác.
2029
2030         webkit-patch build shouldn't need --build to actually build!
2031         https://bugs.webkit.org/show_bug.cgi?id=47438
2032
2033         Yeah, requiring --build for the build command is really dumb.  We did
2034         this originally because the build step is usually optional in other
2035         commands.  We don't have a good way of reversing the default for an
2036         option in one command.  This approach is slightly hacky since --build
2037         still shows up as an option on the help page, but at least it makes
2038         progress.  Passing --build is harmless, so the EWS bots shouldn't
2039         explode because of this change.
2040
2041         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2042         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2043         * Scripts/webkitpy/tool/commands/download.py:
2044         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2045         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2046
2047 2010-10-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2048
2049         Unreviewed, rolling out r69638.
2050         http://trac.webkit.org/changeset/69638
2051         https://bugs.webkit.org/show_bug.cgi?id=47595
2052
2053         "Broke win and chromium-win bots" (Requested by dglazkov on
2054         #webkit).
2055
2056         * Scripts/webkitpy/common/system/path.py:
2057         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2058         * Scripts/webkitpy/layout_tests/port/base.py:
2059         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2060         * Scripts/webkitpy/layout_tests/port/chromium.py:
2061         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2062
2063 2010-10-13  John Knottenbelt  <jknotten@chromium.org>
2064
2065         Reviewed by Steve Block.
2066
2067         First step towards client-based Geolocation in Chromium. Build
2068         fixes for CLIENT_BASED_GEOLOCATION preprocessor feature define.
2069         https://bugs.webkit.org/show_bug.cgi?id=47586
2070
2071         * DumpRenderTree/chromium/WebViewHost.cpp:
2072         * DumpRenderTree/chromium/WebViewHost.h:
2073
2074 2010-10-13  Adam Roben  <aroben@apple.com>
2075
2076         Test that pressing the spacebar in a text field does not scroll the
2077         document
2078
2079         Test for <http://webkit.org/b/47544> <rdar://problem/8540645>
2080         REGRESSION: Pressing spacebar in a text field in WebKit2 does not
2081         insert a space, scrolls the page instead
2082
2083         Reviewed by Sam Weinig.
2084
2085         * TestWebKitAPI/PlatformUtilities.h: Added isKeyDown.
2086
2087         * TestWebKitAPI/PlatformWebView.h: Added simulateSpacebarKeyPress.
2088
2089         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2090         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2091         * TestWebKitAPI/win/copy-resources.cmd:
2092         Added new files.
2093
2094         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: Added.
2095         (TestWebKitAPI::JavaScriptCallbackContext::JavaScriptCallbackContext):
2096         We use this to track what the result of calling into JavaScript was.
2097         (TestWebKitAPI::didFinishLoadForFrame): Records when the page
2098         finishes loading.
2099         (TestWebKitAPI::didNotHandleKeyEventCallback): Records when a key down
2100         event is not handled.
2101         (TestWebKitAPI::javaScriptCallback): Records that JavaScript finished
2102         executing and whether the result matched our expectation.
2103         (TestWebKitAPI::wk): Turns a UTF-8 C string into a WKStringRef.
2104         (TestWebKitAPI::runJSTest): Calls into JS, waits for the call to
2105         complete, and returns whether we got back the expected result.
2106         (TestWebKitAPI::WebKit2_SpacebarScrolling): Tests that pressing
2107         spacebar inside a text field does not scroll the document and that
2108         pressing it outside the text field does scroll the document.
2109
2110         * TestWebKitAPI/Tests/WebKit2/spacebar-scrolling.html: Added.
2111
2112         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2113         (TestWebKitAPI::Util::isKeyDown): Checks the event's type.
2114
2115         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2116         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Copied
2117         code from DRT's EventSendingController.
2118
2119         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2120         (TestWebKitAPI::Util::isKeyDown): Checks the message's type.
2121
2122         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2123         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Send the
2124         same messages that get sent when you press spacebar in Notepad.
2125
2126 2010-10-13  Adam Roben  <aroben@apple.com>
2127
2128         Fix a couple of issues with the TestWebKitAPI build
2129
2130         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops:
2131         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops:
2132         Fixed a typo.
2133
2134         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Use common.vsprops
2135         to set our output and intermediate directories so that we don't spew
2136         files into the source tree.
2137
2138 2010-10-13  Balazs Kelemen  <kbalazs@webkit.org>
2139
2140         Reviewed by Csaba Osztrogonác.
2141
2142         WTR should accept relative paths
2143         https://bugs.webkit.org/show_bug.cgi?id=47486
2144
2145         * WebKitTestRunner/StringFunctions.h:
2146         * WebKitTestRunner/TestInvocation.cpp:
2147         (WTR::createWKURL): Moved from StringFunctions.h since it is
2148         used only here. Extend relative paths to absolute.
2149
2150 2010-10-12  Adam Roben  <aroben@apple.com>
2151
2152         Make TestWebKitAPI work on Windows
2153
2154         Fixes <http://webkit.org/b/47552> <rdar://problem/8541708>.
2155
2156         Reviewed by Sam Weinig.
2157
2158         * Scripts/build-api-tests: Build TestWebKitAPI.sln on Windows.
2159
2160         * Scripts/run-api-tests: Fix the PATH so that TestWebKitAPI can be
2161         run on Windows.
2162         (runTest): Added code to run TestWebKitAPI.exe on Windows and to die
2163         on unsupported platforms.
2164         (populateTests): Added code to run TestWebKitAPI.exe on Windows and to
2165         die on other platforms. Extracted some formerly-Mac-specific code to
2166         be cross-platform and made it handle any style of line-endings.
2167
2168         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added.
2169         Links against CFLite.
2170
2171         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added.
2172         Contains most properties for the project.
2173
2174         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops:
2175         Added. Links against CoreFoundation.
2176
2177         * TestWebKitAPI/TestWebKitAPIPrefix.h: Added a Windows-specific
2178         section and moved the cross-platform section after the
2179         platform-specific parts.
2180
2181         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Added.
2182         (TestWebKitAPI::Util::run): Runs a normal message pump until we're
2183         done.
2184         (TestWebKitAPI::Util::cf): Turns a UTF-8 C string into a CFString.
2185         (TestWebKitAPI::Util::createURLForResource): Uses CFBundle to get the
2186         resource path.
2187         (TestWebKitAPI::Util::URLForNonExistentResource): Creates a bogus
2188         WKURL.
2189
2190         * TestWebKitAPI/win/PlatformWebViewWin.cpp: Added.
2191         (TestWebKitAPI::registerWindowClass):
2192         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2193         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2194         (TestWebKitAPI::PlatformWebView::page):
2195         This was mostly copied from WebKitTestRunner's PlatformWebView.
2196
2197         * TestWebKitAPI/win/TestWebKitAPI.sln: Added. Builds both
2198         TestWebKitAPI and TestWebKitAPIGeneratd. This is used by the
2199         build-api-tests script.
2200
2201         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added. Builds
2202         TestWebKitAPI.exe.
2203
2204         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added. Just calls
2205         through to copy-resources.cmd.
2206
2207         * TestWebKitAPI/win/copy-resources.cmd: Added. Copies resources into
2208         or deletes resources from TestWebKitAPI.resources.
2209
2210         * TestWebKitAPI/win/main.cpp: Added.
2211         (main): Calls through to TestsController.
2212
2213 2010-10-13  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2214
2215         Reviewed by Kenneth Rohde Christiansen.
2216
2217         [EFL] Support viewport configuration and add new arguments for WebKit EFL
2218         https://bugs.webkit.org/show_bug.cgi?id=47084
2219
2220         Opera spec regarding to viewport meta tag was adjusted to WebCore. So, EFL port
2221         needs to be modified according to the changes.
2222
2223         * EWebLauncher/main.c:
2224         (on_viewport_changed):
2225
2226 2010-10-12  Dirk Pranke  <dpranke@chromium.org>
2227
2228         Reviewed by Eric Seidel.
2229
2230         This patch enables new-run-webkit-tests (in particular the
2231         chromium-win port) to run under Cygwin as well as Win32. Mostly
2232         this just required some conversions from cygwin paths to Win32
2233         paths when we spawn off Win32 binaries like test_shell.
2234
2235         https://bugs.webkit.org/show_bug.cgi?id=47220
2236
2237         * Scripts/webkitpy/common/system/path.py:
2238         - Expose the cygpath() function for path conversion
2239
2240         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2241         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2242         - shift filename->uri conversion in the TestInfo objects to the
2243           dump_render_tree thread
2244
2245         * Scripts/webkitpy/layout_tests/port/base.py:
2246         * Scripts/webkitpy/layout_tests/port/chromium.py:
2247         - use cygpath()
2248
2249 2010-10-12  Yuta Kitamura  <yutak@chromium.org>
2250
2251         Unreviewed. Add Yuta Kitamura (yutak) to the committers list.
2252
2253         * Scripts/webkitpy/common/config/committers.py:
2254
2255 2010-10-12  Sam Weinig  <sam@webkit.org>
2256
2257         Reviewed by Dan Bernstein.
2258
2259         When a provisional load fails, the provisional URL returned
2260         from WKFrameCopyProvisionalURL should be empty
2261         <rdar://problem/8540878>
2262         https://bugs.webkit.org/show_bug.cgi?id=47546
2263
2264         Add test.
2265
2266         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
2267         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
2268
2269 2010-10-12  Anders Carlsson  <andersca@apple.com>
2270
2271         Reviewed by Sam Weinig.
2272
2273         Start fleshing out find page overlays
2274         https://bugs.webkit.org/show_bug.cgi?id=47559
2275
2276         * MiniBrowser/mac/BrowserWindowController.m:
2277         (-[BrowserWindowController find:]):
2278         Pass kWKFindOptionsShowOverlay to WKPageFindString.
2279
2280 2010-10-12  Robert Hogan  <robert@webkit.org>
2281
2282         Reviewed by Antonio Gomes.
2283
2284         [Qt] editing/input/emacs-ctrl-o.html
2285
2286         ctrl-o is bound to a sequence of commands on Mac, namely:
2287         insertParagraphSeparator then moveLeft. In the DRT, we just interpret
2288         ctrl-o in EventSenderQt as '\n', i.e. insertParagraphSeparator. As a
2289         result we only issue one command, so don't generate the change in caret
2290         position that results in the extra editing delegate messages.
2291
2292         So for the sake of not managing suspicious-looking differences, just
2293         make DRT issue the appropriate edit commands to pass the test.
2294
2295         https://bugs.webkit.org/show_bug.cgi?id=47548
2296
2297         * DumpRenderTree/qt/EventSenderQt.cpp:
2298         (EventSender::keyDown):
2299
2300 2010-10-12  Anders Carlsson  <andersca@apple.com>
2301
2302         Reviewed by Sam Weinig.
2303
2304         Add a simple Find UI to MiniBrowser
2305         https://bugs.webkit.org/show_bug.cgi?id=47553
2306
2307         * MiniBrowser/mac/BrowserWindow.xib:
2308         Add Find panel.
2309
2310         * MiniBrowser/mac/BrowserWindowController.h:
2311         * MiniBrowser/mac/BrowserWindowController.m:
2312         (-[BrowserWindowController performFindPanelAction:]):
2313         Show the find panel.
2314
2315         (-[BrowserWindowController find:]):
2316         Tell the WKPageRef to find the given string.
2317
2318 2010-10-12  Tony Chang  <tony@chromium.org>
2319
2320         Unreviewed, fixing DRT compile on Windows after r69586.
2321
2322         * DumpRenderTree/chromium/WebThemeEngineDRT.h:
2323
2324 2010-10-12  Tony Chang  <tony@chromium.org>
2325
2326         Unreviewed, trying to fix NRWT on Windows.
2327
2328         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2329
2330 2010-10-12  Balazs Kelemen  <kbalazs@webkit.org>
2331
2332         Reviewed by Kenneth Rohde Christiansen.
2333
2334         [Qt][WTR] Checking the path of the injected bundle is bogus
2335         https://bugs.webkit.org/show_bug.cgi?id=47541
2336
2337         * WebKitTestRunner/qt/TestControllerQt.cpp:
2338         (WTR::isExistingLibrary): Added (static helper).
2339         Extend the path with the appropriate suffix(es) on the
2340         platform and check that the file exists.
2341         (WTR::TestController::initializeInjectedBundlePath):
2342         There were two bugs with the path checking:
2343             - the condition should have been inverted
2344             - QLibrary::fileName does not give back the filename
2345               with the library suffix so we cannot check
2346               that existance of the file this way.
2347
2348 2010-10-12  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2349
2350         Reviewed by Tony Chang.
2351
2352         Implement http locking in NRWT.
2353         https://bugs.webkit.org/show_bug.cgi?id=47072
2354
2355         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2356         * Scripts/webkitpy/layout_tests/port/base.py:
2357         * Scripts/webkitpy/layout_tests/port/http_lock.py: Added.
2358         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py: Added.
2359         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2360
2361 2010-10-12  Mark Rowe  <mrowe@apple.com>
2362
2363         Fix the 32-bit WebKit2 build.
2364
2365         * MiniBrowser/mac/BrowserWindowController.m:
2366         (getWindowFrame): Use NSRect rather than CGRect since that's what -frame returns.
2367         (setWindowFrame): Use NSMakeRect rather than CGRectMake since that's what -setFrame:display: expects.
2368
2369 2010-10-11  Tony Chang  <tony@chromium.org>
2370
2371         Reviewed by Adam Barth.
2372
2373         change the order of mrobinson's email addresses so bugs.webkit.org suggests the right one
2374         https://bugs.webkit.org/show_bug.cgi?id=47513
2375
2376         bugs.webkit.org suggests mrobinson@igalia.com as an autocomplete,
2377         which doesn't actually work.
2378
2379         * Scripts/webkitpy/common/config/committers.py:
2380
2381 2010-10-11  Prasad Tammana  <prasadt@chromium.org>
2382
2383         Reviewed by Dmitry Titov.
2384
2385         Added support for showModalDialog on chromium port.
2386
2387         Implement showModalDialog for Layout tests for chromium port
2388         https://bugs.webkit.org/show_bug.cgi?id=46759
2389
2390         * DumpRenderTree/chromium/WebViewHost.cpp:
2391         (WebViewHost::closeWidgetSoon): Quit current message loop if in a modal loop.
2392         (WebViewHost::runModal):  Start a nested message loop and remember that.
2393         (WebViewHost::WebViewHost):  Initialize m_inModalLoop.
2394         * DumpRenderTree/chromium/WebViewHost.h:  Add m_inModalLoop.
2395
2396 2010-10-11  Martin Robinson  <mrobinson@igalia.com>
2397
2398         Reviewed by Gustavo Noronha Silva.
2399
2400         [GTK] Cleanup font selection code for the Freetype backend
2401         https://bugs.webkit.org/show_bug.cgi?id=47503
2402
2403         Update DRT to set values for the cursive and fantasy font families, so
2404         that we can generate consistent results for tests that use these families.
2405         Add some missing information to fonts.conf.
2406
2407         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2408         (resetDefaultsToConsistentValues): Always set the fantasy and cursive font
2409         family names.
2410         * DumpRenderTree/gtk/fonts/fonts.conf: Add aliases for cursive and fantasy fonts
2411         to our default serif font. Eventually we may want to import or require some "real"
2412         fonts, but this should at least ensure consistent rendering during test runs. Also
2413         add aliases for some other commonly used fonts in tests (Arial and Lucida Grande).
2414         Finally, add a missing oblique specification for DejaVu Serif, which was resulting
2415         in some incorrect baselines for the synthetic oblique test.
2416
2417 2010-10-11  Adam Barth  <abarth@webkit.org>
2418
2419         Unreviewed.
2420
2421         Fix sheriffbot not to crash when there are failing tests.  It turns out
2422         Python sets don't support the + operator.  We need to use union
2423         instead.  There's a more elegant way to do this in Python 2.6, but we
2424         need this code to work in 2.5.
2425
2426         * Scripts/webkitpy/common/net/failuremap.py:
2427         * Scripts/webkitpy/common/net/failuremap_unittest.py:
2428
2429 2010-10-10  Robert Hogan  <robert@webkit.org>
2430
2431         Unreviewed, fix failing test from r69468.
2432
2433         [Qt] Put all DRT-created pages in a page group
2434
2435         Fix on r69468.
2436
2437         Because we don't delete closed pages immediately in DRT we need
2438         to remove them from the page group explicitly instead.
2439
2440         Fixes failure of fast/events/popup-blocked-from-fake-user-gesture.html
2441
2442         https://bugs.webkit.org/show_bug.cgi?id=47469
2443
2444         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2445         (WebCore::DumpRenderTree::windowCloseRequested):
2446
2447 2010-10-10  Leandro Pereira  <leandro@profusion.mobi>
2448
2449         Reviewed by Adam Barth.
2450
2451         commit-queue: Add EFL-EWS status bubble to Bugzilla, now that the
2452         EFL-EWS bot is up and running.
2453         https://bugs.webkit.org/show_bug.cgi?id=47277
2454
2455         * QueueStatusServer/handlers/statusbubble.py:
2456
2457 2010-10-10  Robert Hogan  <robert@webkit.org>
2458
2459         Reviewed by Antonio Gomes.
2460
2461         [Qt] Put all DRT-created pages in a page group
2462
2463         https://bugs.webkit.org/show_bug.cgi?id=47469
2464
2465         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2466         (WebCore::DumpRenderTree::DumpRenderTree):
2467         (WebCore::DumpRenderTree::createWindow):
2468
2469 2010-10-09  Sam Weinig  <sam@webkit.org>
2470
2471         Reviewed by Dan Bernstein.
2472
2473         WKFrameGetFrameLoadState() returns kWKFrameLoadStateCommitted after the load has been stopped
2474         <rdar://problem/8173667>
2475         https://bugs.webkit.org/show_bug.cgi?id=47461
2476
2477         * TestWebKitAPI/PlatformUtilities.h:
2478         * TestWebKitAPI/Test.h:
2479         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2480         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp: Added.
2481         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
2482         (TestWebKitAPI::TEST):
2483         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2484         (TestWebKitAPI::Util::URLForNonExistentResource):
2485         Adds a test for the frame load state after a failed provisional load. I wanted to test
2486         the frame load state after a committed load failed, but I don't believe that is possible
2487         to do without hooking up the http server to serve a long loading page.
2488
2489 2010-10-09  Sam Weinig  <sam@webkit.org>
2490
2491         Reviewed by Dan Bernstein.
2492
2493         Add WebKit2 version of runBeforeUnloadConfirmPanelWithMessage
2494         <rdar://problem/8447690>
2495         https://bugs.webkit.org/show_bug.cgi?id=47459
2496
2497         * MiniBrowser/mac/BrowserWindowController.m:
2498         (runBeforeUnloadConfirmPanel):
2499         (-[BrowserWindowController awakeFromNib]):
2500         * WebKitTestRunner/TestController.cpp:
2501         (WTR::createOtherPage):
2502         (WTR::TestController::initialize):
2503
2504 2010-10-09  Sam Weinig  <sam@webkit.org>
2505
2506         Reviewed by Dan Bernstein.
2507
2508         Need implementation of ChromeClient windowRect related functions.
2509         <rdar://problem/8469476>
2510         https://bugs.webkit.org/show_bug.cgi?id=47386
2511
2512         * MiniBrowser/mac/BrowserWindowController.m:
2513         (getWindowFrame):
2514         (setWindowFrame):
2515         (-[BrowserWindowController awakeFromNib]):
2516         * WebKitTestRunner/PlatformWebView.h:
2517         * WebKitTestRunner/TestController.cpp:
2518         (WTR::TestController::initialize):
2519         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2520         (WTR::PlatformWebView::windowFrame):
2521         (WTR::PlatformWebView::setWindowFrame):
2522         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2523         (WTR::PlatformWebView::windowFrame):
2524         (WTR::PlatformWebView::setWindowFrame):
2525         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2526         (WTR::PlatformWebView::windowFrame):
2527         (WTR::PlatformWebView::setWindowFrame):
2528
2529 2010-10-08  Adam Barth  <abarth@webkit.org>
2530
2531         Unreviewed (Eric is on vacation in this change is trivial).
2532
2533         Add a "clean" command to webkit-patch to clean the working directory
2534         https://bugs.webkit.org/show_bug.cgi?id=47436
2535
2536         This command is useful when using SVN because "svn revert" leaves
2537         unversioned files behind.
2538
2539         * Scripts/webkitpy/tool/commands/download.py:
2540
2541 2010-10-08  Andras Becsi  <abecsi@webkit.org>
2542
2543         Unreviewed build fix.
2544
2545         [Qt] Add missing limits.h include since the Qt version currently
2546         ran on the bot does need that.
2547
2548         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2549
2550 2010-10-08  Balazs Kelemen  <kbalazs@webkit.org>
2551
2552         Reviewed by Csaba Osztrogonác.
2553
2554         [Qt] Turn on building WTR
2555         https://bugs.webkit.org/show_bug.cgi?id=47349
2556
2557         * Scripts/webkitdirs.pm:
2558
2559 2010-10-08  Balazs Kelemen  <kbalazs@webkit.org>
2560
2561         Reviewed by Andreas Kling.
2562
2563         [Qt] TestController needs its platform dependent methods
2564         https://bugs.webkit.org/show_bug.cgi?id=47413
2565
2566         * WebKitTestRunner/qt/TestControllerQt.cpp:
2567         (WTR::TestController::initializeInjectedBundlePath):
2568         If the WTR_INJECTEDBUNDLE_PATH environmental variable is
2569         set then use that otherwise use the path where the bundle
2570         lives in a normal trunk build.
2571         (WTR::TestController::initializeTestPluginDirectory):
2572         Set the bundle's value. It is not used currently.
2573         (WTR::TestController::platformInitializeContext):
2574         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2575
2576 2010-10-08  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2577
2578         Reviewed by Kenneth Rohde Christiansen.
2579
2580         WTR: Prevent sending the Done message twice on test timeout.
2581         https://bugs.webkit.org/show_bug.cgi?id=47410
2582
2583         When InjectedBundle::done() calls stopLoading, this may trigger
2584         InjectedBundlePage::didFailLoadWithErrorForFrame which calls
2585         InjectedBundle::done() itself later in the stack.
2586         This would output the timeout failure message twice and confuse
2587         the run-webkit-tests script.
2588
2589         This patch adds a third state, Stopping, which prevents WebCore
2590         errors to trigger done() when testing is over.
2591
2592         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2593         (WTR::InjectedBundle::done):
2594         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2595
2596 2010-10-08  Andras Becsi  <abecsi@webkit.org>
2597
2598         Reviewed by Kenneth Rohde Christiansen.
2599
2600         [Qt] Add an activateFonts() implementation similar to DRT's initializeFonts().
2601         Original code by Simon Hausmann.
2602         https://bugs.webkit.org/show_bug.cgi?id=47402
2603
2604         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: Added.
2605         (WTR::activateFonts):
2606
2607 2010-10-08  Andras Becsi  <abecsi@webkit.org>
2608
2609         Reviewed by Csaba Osztrogonác.
2610
2611         [Qt] Add support for Qt's WebKitTestRunner to old-run-webkit-tests.
2612         https://bugs.webkit.org/show_bug.cgi?id=47401
2613
2614         * Scripts/build-webkittestrunner:
2615         * Scripts/old-run-webkit-tests:
2616
2617 2010-10-07  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2618
2619         Reviewed by Kenneth Rohde Christiansen.
2620
2621         [Qt] WTR first compile: fix compile issues.
2622         https://bugs.webkit.org/show_bug.cgi?id=47343
2623
2624         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
2625         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2626         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2627         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2628         * WebKitTestRunner/TestController.cpp:
2629         * WebKitTestRunner/TestInvocation.cpp:
2630
2631 2010-10-07  Antonio Gomes  <agomes@rim.com>
2632
2633         Reviewed by Simon Fraser.
2634
2635         [Mac] [DRT] implement setSpatialNavigationEnabled
2636         https://bugs.webkit.org/show_bug.cgi?id=47291
2637
2638         Implemented LayoutTestController::setSpatialNavigationEnabled for Mac's DRT
2639         so it can track regression on the existing implementation and future improvements
2640         we are making.
2641
2642         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2643         (LayoutTestController::setSpatialNavigationEnabled):
2644
2645 2010-10-07  Dirk Pranke  <dpranke@chromium.org>
2646
2647         Reviewed by Adam Barth.
2648
2649         rebaseline-chromium-webkit-tests relied on the filename_to_uri()
2650         hook in the Port infrastructure to generate URIs for the files
2651         in its summary HTML report; however, that method is supposed to only
2652         be used for test files (and should really be renamed), so this would
2653         crash.
2654
2655         This change adds a new "path" module to the system package with a
2656         routine called abspath_to_uri() that handles converting paths to
2657         file: URIs independently of anything in the layout_tests package,
2658         and changes the code to use this. At some point in the near future
2659         the layout_tests/port/* code should use this as well.
2660
2661         This change also deletes a bunch of unused code and fixes some
2662         comments in rebaseline_chromium_webkit_tests.py.
2663
2664         https://bugs.webkit.org/show_bug.cgi?id=47319
2665
2666         * Scripts/webkitpy/common/system/path.py: Added.
2667         * Scripts/webkitpy/common/system/path_unittest.py: Added.
2668         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2669         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2670
2671 2010-10-07  Martin Robinson  <mrobinson@igalia.com>
2672
2673         Reviewed by Gustavo Noronha Silva.
2674
2675         [GTK] The FreeType backend does not respect the FC_EMBOLDEN property
2676         https://bugs.webkit.org/show_bug.cgi?id=46216
2677
2678         Fix my latest commit, as it contained some bad changes from a merge gone wrong.
2679
2680         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2681         (initializeFonts): Also initialize the DevaVu Sans font.
2682
2683 2010-10-07  Daniel Cheng  <dcheng@chromium.org>
2684
2685         Reviewed by Tony Chang.
2686
2687         [chromium] Minor naming cleanup in WebDragData, part 2
2688         https://bugs.webkit.org/show_bug.cgi?id=47227
2689
2690         Update DRT to use the renamed methods.
2691
2692         * DumpRenderTree/chromium/EventSender.cpp:
2693         (EventSender::beginDragWithFiles):
2694         * DumpRenderTree/chromium/WebViewHost.cpp:
2695         (addDRTFakeFileToDataObject):
2696
2697 2010-10-07  Anders Carlsson  <andersca@apple.com>
2698
2699         Reviewed by Sam Weinig.
2700
2701         Add a WKPageFindClient, hook up WKPageCountStringMatches
2702         https://bugs.webkit.org/show_bug.cgi?id=47373
2703
2704         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2705         Remove hard coded paths.
2706
2707         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
2708         (TestWebKitAPI::TEST):
2709         Fix expected result.
2710
2711         * TestWebKitAPI/Tests/WebKit2/Find.cpp: Added.
2712         (TestWebKitAPI::didFinishLoadForFrame):
2713         (TestWebKitAPI::didCountStringMatches):
2714         (TestWebKitAPI::TEST):
2715         * TestWebKitAPI/Tests/WebKit2/find.html: Added.
2716         Add test for WKPageCountStringMatches.
2717
2718 2010-09-21  Martin Robinson  <mrobinson@igalia.com>
2719
2720         Reviewed by Chris Fleizach.
2721
2722         [GTK] The FreeType backend does not respect the FC_EMBOLDEN property
2723         https://bugs.webkit.org/show_bug.cgi?id=46216
2724
2725         * DumpRenderTree/gtk/fonts/fonts.conf: Add a setting which enables FC_EMBOLDEN
2726         for DejaVu Serif when there is no bold version available. This is necessary to
2727         properly test the property in layout tests.
2728
2729 2010-10-07  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>, Andras Becsi  <abecsi@webkit.org>, Balazs Kelemen  <kbalazs@webkit.org>
2730
2731         Reviewed by Kenneth Rohde Christiansen.
2732
2733         [Qt] Add WTR's InjectedBundle build files.
2734         https://bugs.webkit.org/show_bug.cgi?id=47333
2735
2736         * Scripts/webkitdirs.pm:
2737         * WebKitTestRunner/DerivedSources.pro: Added.
2738         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Added.
2739         * WebKitTestRunner/WebKitTestRunner.pro: Added.
2740         * WebKitTestRunner/qt/DerivedSources.pro: Removed.
2741         Content merged in ../DerivedSources.pro
2742
2743 2010-10-07  Sheriff Bot  <webkit.review.bot@gmail.com>
2744
2745         Unreviewed, rolling out r69315.
2746         http://trac.webkit.org/changeset/69315
2747         https://bugs.webkit.org/show_bug.cgi?id=47363
2748
2749         Forgot to add the new files (Requested by kbalazs on #webkit).
2750
2751         * Scripts/webkitdirs.pm:
2752         * WebKitTestRunner/qt/DerivedSources.pro: Added.
2753
2754 2010-10-07  Sam Weinig  <sam@webkit.org>
2755
2756         Reviewed by Anders Carlsson.
2757
2758         Change API tester to ask the executable for the list of all
2759         tests instead of relying on the directory structure.
2760         https://bugs.webkit.org/show_bug.cgi?id=47359
2761
2762         * Scripts/run-test-webkit-api: Added.
2763         * Scripts/webkitdirs.pm:
2764         Add additional script to just launch the api tester with the correct settings.
2765
2766         * Scripts/run-api-tests:
2767         Change to use the new --dump-tests options to build the list of tests and change
2768         output to reflect a (suite, testcase) tuple for each test. Also adds some color.
2769
2770         * TestWebKitAPI/Test.h:
2771         (TestWebKitAPI::Test::Register::Register):
2772         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
2773         (TestWebKitAPI::TEST):
2774         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
2775         (TestWebKitAPI::TEST):
2776         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
2777         (TestWebKitAPI::TEST):
2778         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2779         (TestWebKitAPI::TEST):
2780         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
2781         (TestWebKitAPI::TEST):
2782         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
2783         (TestWebKitAPI::TEST):
2784         Give each test a suite name in addition to the test name.
2785
2786         * TestWebKitAPI/TestsController.cpp:
2787         (TestWebKitAPI::TestsController::dumpTestNames):
2788         (TestWebKitAPI::TestsController::runTestNamed):
2789         * TestWebKitAPI/TestsController.h:
2790         * TestWebKitAPI/mac/main.mm:
2791         (main):
2792         Add option to print all registered tests.
2793
2794 2010-10-07  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>, Andras Becsi  <abecsi@webkit.org>, Balazs Kelemen  <kbalazs@webkit.org>
2795
2796         Reviewed by Kenneth Rohde Christiansen.
2797
2798         [Qt] Add WTR's InjectedBundle build files.
2799         https://bugs.webkit.org/show_bug.cgi?id=47333
2800
2801         * Scripts/webkitdirs.pm:
2802         * WebKitTestRunner/DerivedSources.pro: Added.
2803         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Added.
2804         * WebKitTestRunner/WebKitTestRunner.pro: Added.
2805         * WebKitTestRunner/qt/DerivedSources.pro: Removed.
2806         Content merged in ../DerivedSources.pro
2807
2808 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
2809
2810         Unreviewed. Do a renaming that was recommended by the reviewer
2811         (Kenneth) but I forgot to do before landing (http://trac.webkit.org/changeset/69253)
2812
2813         * WebKitTestRunner/qt/TestControllerQt.cpp:
2814         (WTR::RunUntilConditionLoop::start):
2815         (WTR::RunUntilConditionLoop::RunUntilConditionLoop):
2816         (WTR::TestController::runUntil):
2817
2818 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
2819
2820         Reviewed by Kenneth Rohde Christiansen.
2821
2822         [Qt] Watchdog timer implementation for WTR
2823         https://bugs.webkit.org/show_bug.cgi?id=47337
2824
2825         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Factor out
2826         the definition of the timer type to a typedef.
2827         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp: Added.
2828         Timer implementation with QTimer and a helper QObject class.
2829         (WTR::WatchdogTimerHelper::instance):
2830         (WTR::WatchdogTimerHelper::timerFired):
2831         (WTR::WatchdogTimerHelper::WatchdogTimerHelper):
2832         (WTR::LayoutTestController::platformInitialize):
2833         (WTR::LayoutTestController::invalidateWaitToDumpWatchdogTimer):
2834         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
2835
2836 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
2837
2838         Unreviewed buildfix for 69297 again
2839
2840         * WebKitTestRunner/TestController.cpp:
2841         (WTR::blankURL):
2842
2843 2010-10-07  Balazs Kelemen  <Balazs Kelemen>
2844
2845         Unreviewed trivial build fix for r69297
2846
2847         * WebKitTestRunner/TestController.cpp:
2848         (WTR::blankURL):
2849
2850 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
2851
2852         Reviewed by Kenneth Rohde Christiansen.
2853
2854         WebKitTestRunner should be portable
2855         https://bugs.webkit.org/show_bug.cgi?id=45393
2856
2857         Use only the WebKit API for working with urls.
2858         * WebKitTestRunner/StringFunctions.h:
2859         (WTR::createWKURL):
2860         * WebKitTestRunner/TestController.cpp:
2861         (WTR::blankURL):
2862         (WTR::TestController::resetStateToConsistentValues):
2863         (WTR::TestController::didFinishLoadForFrame):
2864
2865 2010-10-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2866
2867         Reviewed by Xan Lopez.
2868
2869         [GTK] Use gtk_widget_draw() instead of gtk_widget_get_snapshot() in PixelDumpSupportGtk when building with gtk3
2870         https://bugs.webkit.org/show_bug.cgi?id=47332
2871
2872         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
2873         (createBitmapContextFromWebView):
2874
2875 2010-10-06  Chris Guillory  <chris.guillory@google.com>
2876
2877         Reviewed by Chris Fleizach.
2878
2879         Remove unused accessibility functions from webkit.
2880         https://bugs.webkit.org/attachment.cgi?bugid=46707
2881
2882         * DumpRenderTree/chromium/WebViewHost.cpp:
2883         (WebViewHost::postAccessibilityNotification):
2884         * DumpRenderTree/chromium/WebViewHost.h:
2885
2886 2010-10-06  Lucas Forschler  <lforschler@apple.com>
2887
2888         Reviewed by Adam Roben.
2889
2890         Fix the sunspider-compare-results to actually use the passed in value for $root.
2891
2892         * Scripts/sunspider-compare-results:
2893
2894 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
2895
2896         Reviewed by Kenneth Rohde Christiansen.
2897
2898         [Qt] Runloop implementation for WTR
2899         https://bugs.webkit.org/show_bug.cgi?id=47280
2900
2901         * WebKitTestRunner/qt/TestControllerQt.cpp:
2902         Implemented TestController::runUntil by a timerEvent
2903         and a QEventLoop. We step into the event loop from runUntil.
2904         While we are waiting in the loop a timerEvent is periodically
2905         checking the value of the condition. Once the condition has
2906         becoming true the timerEvent wakes us up.
2907         (WTR::RunUntilLoop::start):
2908         (WTR::RunUntilLoop::RunUntilLoop):
2909         (WTR::RunUntilLoop::run):
2910         (WTR::RunUntilLoop::timerEvent):
2911         (WTR::TestController::platformInitialize):
2912         (WTR::TestController::runUntil):
2913         * WebKitTestRunner/qt/main.cpp:
2914         Start the main event loop first and creating the TestController later.
2915         (Launcher::Launcher):
2916         (Launcher::~Launcher):
2917         (Launcher::launch): Creating the TestController.
2918         (main): Setting up a timer for calling Launcher::launch from
2919         the main event loop.
2920
2921 2010-10-06  Dirk Pranke  <dpranke@chromium.org>
2922
2923         Reviewed by Kenneth Russell.
2924
2925         new-run-webkit-tests: fix typo in chromium-gpu that was trying to
2926         enable 'accelerated-composting' instead of 'accelerated-compositing'.
2927
2928         https://bugs.webkit.org/show_bug.cgi?id=47312
2929
2930         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2931         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2932
2933 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
2934
2935         Reviewed by Kenneth Rohde Christiansen.
2936
2937         [Qt] PlatformWebView implementation for WebKitTestRunner
2938         https://bugs.webkit.org/show_bug.cgi?id=47276
2939
2940         The implementation follows the way how
2941         we use the API in MiniBrowser.
2942         * WebKitTestRunner/PlatformWebView.h:
2943         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2944         (WTR::WebView::wkView):
2945         (WTR::WebView::~WebView):
2946         (WTR::WebView::WebView):
2947         (WTR::PlatformWebView::PlatformWebView):
2948         (WTR::PlatformWebView::~PlatformWebView):
2949         (WTR::PlatformWebView::resizeTo):
2950         (WTR::PlatformWebView::page):
2951         (WTR::PlatformWebView::focus):
2952         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2953
2954 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
2955
2956         Reviewed by Kenneth Rohde Christiansen.
2957
2958         [Qt] Add WebKitTestRunner's build files
2959         https://bugs.webkit.org/show_bug.cgi?id=44155
2960
2961         Parts was taken by Zoltan Horvath's patch.
2962
2963         * Scripts/generate-forwarding-headers.pl: Moved from WebKit2.
2964         * Scripts/webkitdirs.pm: Make the generated files needed by WTR.
2965         * WebKitTestRunner/PlatformWebView.h: Addeed typedefs for
2966         PlatformWKView and PlatformWindow (void* for now).
2967         Buildfix the case when __APPLE__ is not defined.
2968         * WebKitTestRunner/qt/DerivedSources.pro: Added.
2969         * WebKitTestRunner/qt/PlatformWebViewQt.cpp: Added.
2970         Empty stub implementation.
2971         (WTR::registerWindowClass):
2972         (WTR::PlatformWebView::PlatformWebView):
2973         (WTR::PlatformWebView::~PlatformWebView):
2974         (WTR::PlatformWebView::resizeTo):
2975         (WTR::PlatformWebView::page):
2976         (WTR::PlatformWebView::focus):
2977         * WebKitTestRunner/qt/TestControllerQt.cpp: Added.
2978         Empty stub implementation.
2979         (WTR::registerWindowClass):
2980         (WTR::TestController::runUntil):
2981         (WTR::TestController::platformInitialize):
2982         (WTR::TestController::initializeInjectedBundlePath):
2983         (WTR::TestController::initializeTestPluginDirectory):
2984         (WTR::TestController::platformInitializeContext):
2985         * WebKitTestRunner/qt/WebKitTestRunner.pro: Added.
2986         * WebKitTestRunner/qt/main.cpp: Added.
2987         (main):
2988
2989 2010-10-06  Tony Chang  <tony@chromium.org>
2990
2991         Unreviewed, rolling out r69202.
2992         http://trac.webkit.org/changeset/69202
2993         https://bugs.webkit.org/show_bug.cgi?id=46937
2994
2995         Broke compile of test_shell
2996
2997         * DumpRenderTree/chromium/EventSender.cpp:
2998         (EventSender::beginDragWithFiles):
2999         * DumpRenderTree/chromium/WebViewHost.cpp:
3000         (addDRTFakeFileToDataObject):
3001
3002 2010-10-06  Daniel Cheng  <dcheng@chromium.org>
3003
3004         Reviewed by Tony Chang.
3005
3006         [chromium] Minor naming cleanup in WebDragData, part 2
3007         https://bugs.webkit.org/show_bug.cgi?id=46937
3008
3009         Update DRT to use the renamed methods.
3010
3011         * DumpRenderTree/chromium/EventSender.cpp:
3012         (EventSender::beginDragWithFiles):
3013         * DumpRenderTree/chromium/WebViewHost.cpp:
3014         (addDRTFakeFileToDataObject):
3015
3016 2010-10-06  David Kilzer  <ddkilzer@apple.com>
3017
3018         <http://webkit.org/b/47270> Move WebArchive serialization code into its own file
3019
3020         Reviewed by Adam Roben.
3021
3022         This is the first step in making webarchive tests work on
3023         Windows.
3024
3025         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added
3026         new files to the project.
3027         * DumpRenderTree/mac/DumpRenderTree.mm: Removed code that moved
3028         to WebArchiveDumpSupport.mm.
3029         * DumpRenderTree/mac/WebArchiveDumpSupport.h: Added.
3030         * DumpRenderTree/mac/WebArchiveDumpSupport.mm: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm.
3031         (serializeWebArchiveToXML):
3032
3033 2010-10-05  Daniel Bates  <dbates@rim.com>
3034
3035         Reviewed by David Kilzer.
3036
3037         Add infrastructure to towards detecting change log diffs that aren't at the top of the ChangeLog
3038         https://bugs.webkit.org/show_bug.cgi?id=46058
3039
3040         Make VCSUtils::fixChangeLogPatch() return a reference to a hash
3041         structure so as to support returning additional information
3042         about a change log diff.
3043
3044         Currently, VCSUtils::fixChangeLogPatch() returns a string that
3045         represents the change log diff. Towards supporting the return
3046         of additional information, such as whether the change log diff
3047         inserts an entry at the top of the ChangeLog file, we need to
3048         make VCSUtils::fixChangeLogPatch() return a reference to hash
3049         structure.
3050
3051         * Scripts/VCSUtils.pm:
3052           - Modified fixChangeLogPatch() to return a reference to a
3053             hash structure.
3054           - Added documentation to fixChangeLogPatch().
3055           - Modified call site in mergeChangeLogs() as necessary.
3056         * Scripts/svn-apply:
3057           - Modified call site in patch() as necessary.
3058         * Scripts/svn-create-patch:
3059           - Modified call site in generateDiff() as necessary.
3060         * Scripts/svn-unapply:
3061           - Modified call site in patch() as necessary.
3062         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
3063           - Modified the unit tests as necessary.
3064
3065 2010-10-05  Tony Chang  <tony@chromium.org>
3066
3067         Reviewed by Darin Adler.
3068
3069         fix the link to the expected image on windows
3070         https://bugs.webkit.org/show_bug.cgi?id=47228
3071
3072         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: On
3073             windows, the file must be opened in binary mode when writing
3074             binary data.
3075
3076 2010-10-05  Adam Barth  <abarth@webkit.org>
3077
3078         Update expected result of unittest to match Tony's change below.
3079
3080         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3081
3082 2010-10-05  Tony Chang  <tony@chromium.org>
3083
3084         Reviewed by Ojan Vafai (over the shoulder).
3085
3086         Paper over errors in image_diff so we don't crash the whole test run.
3087
3088         * Scripts/webkitpy/layout_tests/port/chromium.py:
3089
3090 2010-10-05  Tony Chang  <tony@chromium.org>
3091
3092         Unreviewed, make shutil.rmtree more resiliant to errors
3093         since windows was raising WindowsError: The process cannot access the file because it
3094         is being used by another process.
3095
3096         * Scripts/webkitpy/layout_tests/port/chromium.py:
3097
3098 2010-10-05  Tony Chang  <tony@chromium.org>
3099
3100         Reviewed by Ojan Vafai.
3101
3102         [chromium] fix image diffing in NRWT
3103         https://bugs.webkit.org/show_bug.cgi?id=47128
3104
3105         * Scripts/webkitpy/layout_tests/port/chromium.py: Stop using
3106             NamedTemporaryFile since it doesn't work on Windows.
3107         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3108
3109 2010-10-05  Kenneth Russell  <kbr@google.com>
3110
3111         Reviewed by Tony Chang.
3112
3113         [chromium] Implement layerTreeAsText in DumpRenderTree
3114         https://bugs.webkit.org/show_bug.cgi?id=47216
3115
3116         Plumbed Frame::layerTreeAsText through Chromium's WebKit API to
3117         make it callable from DumpRenderTree.
3118
3119         No new tests; verified with existing compositor layout tests.
3120
3121         * DumpRenderTree/chromium/LayoutTestController.cpp:
3122         (LayoutTestController::LayoutTestController):
3123         (LayoutTestController::layerTreeAsText):
3124         * DumpRenderTree/chromium/LayoutTestController.h:
3125
3126 2010-10-05  Brent Fulgham  <bfulgham@webkit.org>
3127
3128         Unreviewed build correction.
3129
3130         * DumpRenderTree/win/ImageDiff.vcproj: Use WinCairo debug
3131         property sheet so proper libraries are linked.
3132
3133 2010-10-05  Robert Hogan  <robert@webkit.org>
3134
3135         Reviewed by Andreas Kling.
3136
3137         [Qt] Fix url conversion in QWebHistory
3138
3139         Converting from KURL to WFT::String to QUrl does not
3140         permit proper percent encoding later.
3141
3142         https://bugs.webkit.org/show_bug.cgi?id=47048
3143
3144         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3145         (WebCore::dumpHistoryItem):
3146
3147 2010-10-05  Anders Carlsson  <andersca@apple.com>
3148
3149         Reviewed by Sam Weinig.
3150
3151         REGRESSION (r68966?): All dumpAsText test fail on WebKit2
3152         https://bugs.webkit.org/show_bug.cgi?id=47188
3153         <rdar://problem/8514104>
3154
3155         When constructing the std::string, use the real string length instead of the maximum buffer size.
3156
3157         * TestWebKitAPI/PlatformUtilities.h:
3158         (TestWebKitAPI::Util::toSTD):
3159         * WebKitTestRunner/StringFunctions.h:
3160         (WTR::toSTD):
3161
3162 2010-10-04  Sam Weinig  <sam@webkit.org>
3163
3164         Reviewed by Mark Rowe.
3165
3166         Add MIMEType accessor to WKFrame
3167         <rdar://problem/8347683>
3168         https://bugs.webkit.org/show_bug.cgi?id=47138
3169
3170         * TestWebKitAPI/PlatformUtilities.h:
3171         (TestWebKitAPI::Util::toSTD):
3172         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3173         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp: Added.
3174         (TestWebKitAPI::didStartProvisionalLoadForFrame):
3175         (TestWebKitAPI::didCommitLoadForFrame):
3176         (TestWebKitAPI::didFinishLoadForFrame):
3177         (TestWebKitAPI::TEST):
3178         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp: Added.
3179         (TestWebKitAPI::didStartProvisionalLoadForFrame):
3180         (TestWebKitAPI::didCommitLoadForFrame):
3181         (TestWebKitAPI::didFinishLoadForFrame):
3182         (TestWebKitAPI::TEST):
3183         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3184         (TestWebKitAPI::TEST):
3185         * TestWebKitAPI/Tests/WebKit2/basic-1.html: Removed.
3186         * TestWebKitAPI/Tests/WebKit2/icon.png: Added.
3187         * TestWebKitAPI/Tests/WebKit2/simple.html: Added.
3188         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3189         (TestWebKitAPI::Util::createURLForResource):
3190
3191 2010-10-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3192
3193         Reviewed by Ojan Vafai.
3194
3195         [NRWT] Rename current_dir to current_group because it's not a directory
3196         https://bugs.webkit.org/show_bug.cgi?id=47169
3197
3198         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3199         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3200
3201 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
3202
3203         Unreviewed, build fix.
3204
3205         r69065 broke test-webkitpy by trying to create a '/tmp-X' directory,
3206         which can't always be done. This test uses tempfile.mkdtemp(), which
3207         should be safe.
3208
3209         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3210
3211 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
3212
3213         Unreviewed, build fix.
3214
3215         Add missing "from __future__ import with_statement" that was
3216         breaking test-webkitpy on the Leopard bots (broke in r69040).
3217
3218         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3219
3220 2010-10-04  Sheriff Bot  <webkit.review.bot@gmail.com>
3221
3222         Unreviewed, rolling out r69066.
3223         http://trac.webkit.org/changeset/69066
3224         https://bugs.webkit.org/show_bug.cgi?id=47163
3225
3226         Made NRWT reliability worse. (Requested by tkent on #webkit).
3227
3228         * Scripts/webkitpy/layout_tests/port/chromium.py:
3229         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3230
3231 2010-10-04  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3232
3233         Reviewed by Tony Chang.
3234
3235         [NRWT] Reverse the http tests to alphabetical order.
3236         https://bugs.webkit.org/show_bug.cgi?id=47075
3237
3238         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3239
3240 2010-10-04  Robert Hogan  <robert@webkit.org>
3241
3242         Reviewed by Andreas Kling.
3243
3244         [Qt] Fix timeout on http/tests/navigation/post-goback2.html and postredirect-goback2.html
3245
3246         We need to queue back and forward navigations in the DRT from the
3247         LayoutTestController so that maybeDump() knows about them.
3248
3249         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3250         (LayoutTestController::queueBackNavigation):
3251         (LayoutTestController::queueForwardNavigation):
3252
3253 2010-10-04  Tony Chang  <tony@chromium.org>
3254
3255         Reviewed by Kent Tamura.
3256
3257         [chromium] fix image diffing in NRWT
3258         https://bugs.webkit.org/show_bug.cgi?id=47128
3259
3260         * Scripts/webkitpy/layout_tests/port/chromium.py: Flush data to the
3261               temp file and check the image_diff error code more carefully
3262         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3263
3264 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
3265
3266         Reviewed by Adam Barth.
3267
3268         aroben's change in r68792 actually broke new-run-webkit-tests when
3269         running the DRT code path. His change was intended to fix the
3270         way we were converting windows paths to URIs when running under
3271         Cygwin (the paths were getting one too many "/" on the front).
3272         However, the change ended up breaking the chromium_win port, which
3273         had slightly different logic.
3274
3275         This patch removes the port-specific code and adds tests to make
3276         sure we're getting the behavior we expect. The Port object no longer
3277         exposes a get_absolute_path() method that can be used outside of
3278         of converting test filenames, because it's unreliable otherwise
3279         (we don't have the right context to know which conversion is intended).
3280
3281         https://bugs.webkit.org/show_bug.cgi?id=47140
3282
3283         * Scripts/webkitpy/layout_tests/port/base.py:
3284         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3285         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3286         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3287         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3288
3289 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
3290
3291         Unreviewed, build fix.
3292
3293         Handle crash introduced in r69040 if we are not running in a
3294         Chromium checkout.
3295
3296         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3297
3298 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
3299
3300         Reviewed by Tony Chang.
3301
3302         Add a way for us to have test expectations that are specific to the
3303         official builds of Google Chrome (as opposed to Chromium). This change
3304         looks for an additional "test_expectations_chrome.txt" file in
3305         Chromium's repository (webkit/tools/layout_tests), and uses the
3306         concatenation of that file and the regular test_expectations.txt
3307         file for test overrides.
3308
3309         https://bugs.webkit.org/show_bug.cgi?id=46854
3310
3311         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3312         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3313
3314 2010-10-04  Simon Fraser  <simon.fraser@apple.com>
3315
3316         Color tests in the list based on existing pass/fail result.
3317         
3318         Fix the summary data to account for htmlOnly and nonHTML tests.
3319
3320         * CSSTestSuiteHarness/harness/harness.css:
3321         (#test-list > option.pass):
3322         (#test-list > option.fail):
3323         (#test-list > option.skipped):
3324         * CSSTestSuiteHarness/harness/harness.js:
3325         (Test):
3326         (Test.prototype.statusForFormat):
3327         (TestSuite.prototype.fillTestList):
3328         (TestSuite.prototype.updateTestList):
3329         (TestSuite.prototype.recordResult):
3330         (TestSuite.prototype.markTestCompleted):
3331         (TestSuite.prototype.countTestsWithFlag):
3332         (TestSuite.prototype.queryDatabaseForSummary.this.db.transaction):
3333         (TestSuite.prototype.queryDatabaseForSummary):
3334
3335 2010-10-04  Chris Fleizach  <cfleizach@apple.com>
3336
3337         Reviewed by Beth Dakin.
3338
3339         AX: doAXRangeForLine does not work
3340         https://bugs.webkit.org/show_bug.cgi?id=47101
3341
3342         DRT support to handle NSAccessibilityRangeForLineParameterizedAttribute.
3343
3344         * DumpRenderTree/AccessibilityUIElement.cpp:
3345         (rangeForLineCallback):
3346         (AccessibilityUIElement::rangeForLine):
3347         (AccessibilityUIElement::getJSClass):
3348         * DumpRenderTree/AccessibilityUIElement.h:
3349         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3350         (AccessibilityUIElement::rangeForLine):
3351
3352 2010-10-04  Andrey Kosyakov  <caseq@chromium.org>
3353
3354         Unreviewed. Adding myself to the committers list.
3355
3356         * Scripts/webkitpy/common/config/committers.py:
3357
3358 2010-10-04  Sam Weinig  <sam@webkit.org>
3359
3360         Reviewed by Anders Carlsson.
3361
3362         Add ability to set the CacheModel in Webkit2
3363         https://bugs.webkit.org/show_bug.cgi?id=47066
3364
3365         * MiniBrowser/mac/AppDelegate.m:
3366         (-[BrowserAppDelegate init]): Opt minibrowser into
3367         a PrimaryWebBrowser cache model.
3368
3369 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
3370
3371         Make sure to enter all tests when creating the database
3372         for the first time.
3373         
3374         When migrating to a new version of the suite, be sure to
3375         sync up the database and testinfo.data by removing old
3376         tests, and inserting new ones.
3377
3378         * CSSTestSuiteHarness/harness/harness.js:
3379         (TestSuite.prototype.openDatabase.creation):
3380         (TestSuite.prototype.databaseCreated):
3381         (TestSuite.prototype.populateDatabaseFromTestInfoData):
3382         (TestSuite.prototype.insertTest):
3383
3384 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
3385
3386         More work on treating HTML4 and XHTML1 independently; when 
3387         changing the format, rebuild the test list, and update the 
3388         numbers in the chapter popup.
3389
3390         * CSSTestSuiteHarness/harness/harness.js:
3391         (Test):
3392         (Test.prototype.runForFormat):
3393         (Test.prototype.completedForFormat):
3394         (ChapterSection):
3395         (ChapterSection.prototype.countTests):
3396         (Chapter):
3397         (Chapter.prototype.description):
3398         (Chapter.prototype.countTests):
3399         (Chapter.prototype.testCount):
3400         (Chapter.prototype.untestedCount):
3401         (TestSuite.prototype.buildChapters):
3402         (TestSuite.prototype.loadCurrentTest):
3403         (TestSuite.prototype.updateProgressLabel):
3404         (TestSuite.prototype.processFlags):
3405         (TestSuite.prototype.formatChanged):
3406
3407 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
3408
3409         Update test suite version 20101001.
3410         
3411         Handle database migration, and delete tests from the db that are
3412         not present in testinfo.data.
3413         
3414         Load about:blank into the test frame before the test url, to make
3415         missing tests more obvious.
3416         
3417         * CSSTestSuiteHarness/harness/harness.js:
3418         (TestSuite.prototype.loadTest):
3419         (TestSuite.prototype.openDatabase.creation):
3420         (TestSuite.prototype.openDatabase.migration1_0To1_1):
3421         (TestSuite.prototype.openDatabase.if.return):
3422         (TestSuite.prototype.databaseReady):
3423         (TestSuite.prototype.populateDatabaseFromTestInfoData):
3424         (TestSuite.prototype.syncDatabaseWithTestInfoData.this.db.transaction):
3425         (TestSuite.prototype.syncDatabaseWithTestInfoData):
3426
3427 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
3428
3429         Add the ability to jump to a specific test.
3430
3431         * CSSTestSuiteHarness/harness/harness.html:
3432         * CSSTestSuiteHarness/harness/harness.js:
3433         (TestSuite.prototype.goToTestByName):
3434         (TestSuite.prototype.switchToFormat):
3435
3436 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
3437
3438         For a ref test, load the ref in the same format (HTML4 vs XHTML1)
3439         as the test.
3440
3441         * CSSTestSuiteHarness/harness/harness.js:
3442         (TestSuite.prototype.loadRef):
3443
3444 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
3445
3446         Update the UI to reflect the fact that each test needs to be tested
3447         in both HTML4 and XHTML1 format.
3448         
3449         * CSSTestSuiteHarness/harness/harness.js:
3450         (Test):
3451         (Chapter.prototype.description):
3452         (Chapter.prototype.untestedCount):
3453         (TestSuite.prototype.fillChapterPopup):
3454         (TestSuite.prototype.updateChapterPopup):
3455         (TestSuite.prototype.fillTestList):
3456         (TestSuite.prototype.updateTestList):
3457         (TestSuite.prototype.goToNextIncompleteTest):
3458         (TestSuite.prototype.firstIncompleteTestIndex):
3459         (TestSuite.prototype.recordResult):
3460         (TestSuite.prototype.formatChanged):
3461         (TestSuite.prototype.markTestCompleted):
3462         (TestSuite.prototype.resetTestStatus):
3463
3464 2010-10-01  Simon Fraser  <simon.fraser@apple.com>
3465
3466         Add the ability to remove results for re-testing, and
3467         to import results.
3468
3469         * CSSTestSuiteHarness/harness/harness.css:
3470         (.custom button):
3471         (#overlay):
3472         (#overlay.visible):
3473         (.overlay-contents):
3474         (.overlay-contents textarea):
3475         (.overlay-contents .buttons):
3476         (.overlay-contents .note):
3477         (.overlay-contents .buttons button):
3478         * CSSTestSuiteHarness/harness/harness.html:
3479         * CSSTestSuiteHarness/harness/harness.js:
3480         (TestSuite.prototype.importResults):
3481         (TestSuite.prototype.clearResults):
3482         (TestSuite.prototype.markTestCompleted):
3483         (TestSuite.prototype.resetTestStatus):
3484         (TestSuite.prototype.storeTestResult):
3485         (TestSuite.prototype.importTestResults):
3486         (TestSuite.prototype.clearTestResults):
3487
3488 2010-10-01  Sam Weinig  <sam@webkit.org>
3489
3490         Reviewed by Jon Honeycutt.
3491
3492         Deploy the new WKString functions to remove most uses of CF from
3493         the WebKitTestRunner.
3494
3495         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3496         (WTR::InjectedBundle::didReceiveMessage):
3497         (WTR::InjectedBundle::done):
3498         * WebKitTestRunner/StringFunctions.h:
3499         (WTR::toWK):
3500         (WTR::toJS):
3501         (WTR::toSTD):
3502         (WTR::operator<<):
3503         (WTR::copyURLString):
3504         * WebKitTestRunner/TestController.cpp:
3505         (WTR::TestController::resetStateToConsistentValues):
3506         (WTR::TestController::didFinishLoadForFrame):
3507         * WebKitTestRunner/TestInvocation.cpp:
3508         (WTR::TestInvocation::invoke):
3509         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3510
3511 2010-10-01  Mihai Parparita  <mihaip@chromium.org>
3512
3513         Unreviewed TestResultsServer change.
3514
3515         Add files introduced by http://crrev.com/61273 to the list of dashboard 
3516         files to update.
3517
3518         * TestResultServer/handlers/dashboardhandler.py:
3519
3520 2010-10-01  Brian Weinstein  <bweinstein@apple.com>
3521
3522         Build Fix for Windows.
3523
3524         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Don't copy ForwardingHeaders from
3525             WebKitTestRunner/ForwardingHeaders, instead, add $(WebKitOutputDir)/include/WebCore/
3526             ForwardingHeaders to the include path.
3527
3528 2010-10-01  Sam Weinig  <sam@webkit.org>
3529
3530         Reviewed by Anders Carlsson.
3531
3532         Add SPI to convert a WKStringRef to a JSStringRef and vice-versa.
3533
3534         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3535         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
3536         (TestWebKitAPI::TEST):
3537         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp: Added.
3538         (TestWebKitAPI::TEST):
3539
3540 2010-10-01  Sam Weinig  <sam@webkit.org>
3541
3542         Reviewed by Kenneth Rohde Christiansen.
3543
3544         Add additional WKString API
3545         https://bugs.webkit.org/show_bug.cgi?id=46958
3546
3547         Add basic WKStringRef tests.
3548
3549         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3550         * TestWebKitAPI/Tests/WebKit2/WKString.cpp: Added.
3551
3552 2010-10-01  Sam Weinig  <sam@webkit.org>
3553
3554         Reviewed by Dan Bernstein.
3555
3556         Add makefile for TestWebKitAPI and call it from the base makefile.
3557
3558         * Makefile:
3559         * TestWebKitAPI/Makefile: Added.
3560
3561 2010-10-01  Sam Weinig  <sam@webkit.org>
3562
3563         Reviewed by Adam Roben.
3564
3565         Remove unnecessary ForwardingHeaders from test runners.
3566         https://bugs.webkit.org/show_bug.cgi?id=47010
3567
3568         * TestWebKitAPI/Configurations/Base.xcconfig:
3569         * TestWebKitAPI/ForwardingHeaders: Removed.
3570         * WebKitTestRunner/Configurations/Base.xcconfig:
3571         * WebKitTestRunner/ForwardingHeaders: Removed.
3572
3573 2010-09-30  Adam Barth  <abarth@webkit.org>
3574
3575         Reviewed by Eric Seidel.
3576
3577         WebSocket tests are flaky
3578         https://bugs.webkit.org/show_bug.cgi?id=46956
3579
3580         Update these tools to understand how to run the WebSocket tests off the
3581         Apache server.
3582
3583         * Scripts/old-run-webkit-tests:
3584        &n