Reviewed by Eric. Older parts reviewed by Dan.
[WebKit-https.git] / WebKitTools / ChangeLog
1 2008-01-21  Darin Adler  <darin@apple.com>
2
3         Reviewed by Mitz and Adam.
4
5         * Scripts/svn-create-patch: Sort ChangeLog files first. Also slightly improved the
6         sorting speed by doing all sort criteria in a single pass instead of three sorts.
7
8 2008-01-21  Simon Hausmann  <hausmann@webkit.org>
9
10         Reviewed by Holger.
11
12         Fix focus chain handling and cycling through focusable objects (links) using tab/backtab.
13         
14         * Fix GraphicsContext::drawFocusRing to also draw single focus rects.
15         * Implemented QWebPage::focusNextPrevChild by sending fake tab/shift-tab events
16         and make the return value depend on whether we successfully determined a focusable
17         node or not.
18         * Changed QWebView::focusNextPrevChild() to call the base QWidget implementation correctly
19         if we could not handle the focus chain ourselves.
20         * Changed the focus policy of QWebView to correctly use WheelFocus instead of ClickFocus.
21         * Made ChromeClientQt::canTakeFocus() and takeFocus() dummy method since they are only
22         used to control the situation of stepping out of the focus chain inside the page.
23         * Made inclusion of links in the focus chain configurable through QWebSettings::LinksIncludedInFocusChain.
24         The layout tests expect this to be disabled but for the user it seems sensible to have it
25         on by default, hence the default in qwebsettings.cpp
26         
27
28         * DumpRenderTree/qt/DumpRenderTree.cpp:
29         (WebCore::WebPage::WebPage):
30
31 2008-01-19  Mark Rowe  <mrowe@apple.com>
32
33         Reviewed by Alp Toker.
34
35         Allow the --http flag to run-webkit-tests to override
36         the default behaviour of disabling HTTP tests for Qt,
37         Gtk and Wx.
38
39         * Scripts/run-webkit-tests:
40
41 2008-01-19  David Kilzer  <ddkilzer@apple.com>
42
43         <rdar://problem/5695344> check-for-global-initializers script never checks any object files
44
45         Reviewed by Darin.
46
47         We now touch a check-for-global-initializers.timestamp file in
48         the TARGET_TEMP_DIR directory to determine when new object files
49         have been compiled and thus need to be checked.  If the timestamp
50         file doesn't exist, all object files will be checked.
51
52         Previously the modification time of the "executable" (the
53         framework binary, e.g., WebKit.framework/WebKit) was used, but
54         since this was the last file modified at the end of the compile
55         phase, no object files would ever get checked!
56
57         Also added JSCustomSQLTransactionCallback.o to the list of files
58         since it has static initializers in Debug builds of WebCore.
59
60         * Scripts/check-for-global-initializers:
61
62 2008-01-18  Adam Roben  <aroben@apple.com>
63
64         Build fix
65
66         * Scripts/build-webkit:
67
68 2008-01-18  Beth Dakin  <bdakin@apple.com>
69
70         Reviewed by Oliver.
71
72         Update build-webkit to account for foreign-object being disabled by 
73         default.
74
75         * Scripts/build-webkit:
76
77 2008-01-18  Adam Roben  <aroben@apple.com>
78
79         Updated for method renames
80
81         Reviewed by Adele.
82
83         * DumpRenderTree/mac/FrameLoadDelegate.mm:
84         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
85         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
86         (LayoutTestController::setMainFrameIsFirstResponder):
87         (LayoutTestController::setWindowIsKey):
88         * DumpRenderTree/mac/UIDelegate.mm:
89         (-[UIDelegate webViewFocus:]):
90         * DumpRenderTree/win/FrameLoadDelegate.cpp:
91         (FrameLoadDelegate::didCommitLoadForFrame):
92
93 2008-01-18  Alexey Proskuryakov  <ap@webkit.org>
94
95         Reviewed by Adam Roben.
96
97         Fix plugin-related tests in Debug_Internal configuration, which are failing because of CRT version mismatch
98         between DRT and TestNetscapePlugin.
99
100         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Added a Debug_Internal configuration.
101         * DumpRenderTree/DumpRenderTree.sln: Use this configuration.
102
103 2008-01-18  Simon Hausmann  <hausmann@webkit.org>
104
105         Reviewed by Holger.
106
107         Fix fast/dom/Window/window-resize.html
108         
109         In DRT connect the page's geometryChangeRequest signal to a slot that
110         sets the geometry of the view widget.
111         
112
113         * DumpRenderTree/qt/DumpRenderTree.cpp:
114         (WebCore::WebPage::setViewGeometry):
115         (WebCore::WebPage::WebPage):
116
117 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
118
119         Build fix.
120
121         * Drosera/DroseraWin.make:
122
123 2008-01-17  Darin Adler  <darin@apple.com>
124
125         * Scripts/run-webkit-tests: Fixed a bug number.
126
127 2008-01-17  Alexey Proskuryakov  <ap@webkit.org>
128
129         Reviewed by Adam Roben.
130
131         http://bugs.webkit.org/show_bug.cgi?id=16908
132         run-webkit-tests complains about missing FindSafari.exe
133
134         * Scripts/webkitdirs.pm: Append _debug as appropriate.
135
136 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
137
138         Re-add DEBUG_WEBKIT_HAS_SUFFIX.
139         
140         Rubber-stamped by Jon Honeycutt.
141
142         * DumpRenderTree/win/DumpRenderTree.vcproj:
143
144 2008-01-16  Alp Toker  <alp@atoker.com>
145
146         Reviewed by Mark Rowe.
147
148         http://bugs.webkit.org/show_bug.cgi?id=16218
149         [GTK] API: Should this entry point be called go_back rather than go_backward?
150
151         Track back/forward API changes in the tools.
152
153         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
154         (BackForwardItem::invoke):
155         * GtkLauncher/main.c:
156         (go_back_cb):
157
158 2008-01-16  Adam Roben  <aroben@apple.com>
159
160         Windows build fix after r29488
161
162         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
163         Build into a subdirectory of $WebKitOutputDir\bin to match where DRT
164         expects to find the plugin.
165
166 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
167
168         Reviewed by Sam Weinig.
169         
170         Fixed the waitUntilDone watchdog timer -- the old code never added the
171         timer to the run loop, so it didn't do anything.
172
173         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
174         (LayoutTestController::setWaitToDump):
175         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
176         (LayoutTestController::setWaitToDump):
177
178 2008-01-14  Steve Falkenburg  <sfalken@apple.com>
179
180         Use shared vsprops for most vcproj properties.
181         
182         Reviewed by Darin.
183
184         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
185         * DumpRenderTree/win/DumpRenderTree.vcproj:
186         * DumpRenderTree/win/ImageDiff.vcproj:
187         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
188         * FindSafari/FindSafari.vcproj:
189
190 2008-01-14  Stephanie  <slewis@apple.com>
191
192        Reviewed by NOBODY.
193   
194        revert accidental character.
195
196        * Scripts/run-webkit-tests:
197
198 2008-01-14  Stephanie  <slewis@apple.com>
199
200         RS=Oliver
201
202         add Quicktime PPC only leaks to Leopard exclude list. See <rdar://problem/5667132>
203
204         * Scripts/run-webkit-tests:
205
206 2008-01-14  Darin Adler  <darin@apple.com>
207
208         * Scripts/do-webcore-rename: Queue up another rename.
209
210 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
211
212         Reviewed by Darin.
213
214         * Allow to run the tests in reverse order to spot test cases where the result depends on the order
215         the tests were ran.
216         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
217
218         * Scripts/run-webkit-tests:
219
220 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
221
222         Reviewed by Darin.
223
224         * Randomize tests array to spot test cases where the results depends on the order
225         the tests are ran.
226         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
227
228         * Scripts/run-webkit-tests:
229
230 2008-01-14  Darin Adler  <darin@apple.com>
231
232         * Scripts/run-webkit-tests: More ignore list tweaking.
233
234 2008-01-14  Darin Adler  <darin@apple.com>
235
236         * Scripts/run-webkit-tests: Add another leak to the ignore list.
237
238 2008-01-14  Dan Bernstein  <mitz@apple.com>
239
240         Reviewed by Adam Roben.
241
242         - try to fix failure in fast/dom/Window/window-onFocus.html seen on the
243           build bots
244
245         * DumpRenderTree/win/DumpRenderTree.cpp:
246         (resetWebViewToConsistentStateBeforeTesting): Focus the web view.
247
248 2008-01-13  Steve Falkenburg  <sfalken@apple.com>
249
250         Share common files across projects.
251         
252         Unify vsprops files
253         Debug:          common.vsprops, debug.vsprops
254         Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
255         Release:        common.vsprops, release.vsprops
256         
257         Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
258         debug_internal.vsprops will be mostly empty except for file path prefix modifiers.
259
260         Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.
261
262         Reviewed by Adam Roben.
263
264         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
265         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Removed.
266         * Drosera/win/Drosera.vcproj/VERSION: Removed.
267         * Drosera/win/Drosera.vcproj/auto-version.sh: Removed.
268         * Drosera/win/Drosera.vcproj/debug.vsprops: Removed.
269         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Removed.
270         * Drosera/win/Drosera.vcproj/release.vsprops: Removed.
271         * DumpRenderTree/win/DumpRenderTree.vcproj:
272         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
273         * DumpRenderTree/win/debug.vsprops: Removed.
274         * DumpRenderTree/win/debug_internal.vsprops: Removed.
275         * DumpRenderTree/win/release.vsprops: Removed.
276
277 2008-01-13  Brent Fulgham  <bfulgham@gmail.com>
278
279         Reviewed by Maciej.
280
281         - http://bugs.webkit.org/show_bug.cgi?id=16314
282           Script to launch Drosera
283
284         * Scripts/gdb-drosera: Added.
285         * Scripts/run-drosera: Added.
286         * Scripts/run-drosera-nightly.cmd: Added.
287         * Scripts/webkitdirs.pm: Added runDrosera function.
288
289 2008-01-13  Dan Bernstein  <mitz@apple.com>
290
291         - fix breakage due to last-minute change
292
293         * DumpRenderTree/win/DumpRenderTree.cpp:
294         (runTest): Declare the loop variable.
295
296 2008-01-13  Dan Bernstein  <mitz@apple.com>
297
298         Reviewed by Adam Roben.
299
300         - fix <rdar://problem/5132009> Windows DRT does not support multiple windows
301
302         * DumpRenderTree/win/DumpRenderTree.cpp:
303         (DumpRenderTreeWndProc):
304         (initialize):
305         (dumpBackForwardList):
306         (dumpBackForwardListForAllWindows):
307         (dump):
308         (resetWebViewToConsistentStateBeforeTesting): Factored out of
309         runTest().
310         (runTest):
311         (allWindows): Added. Returns a vector of all open windows.
312         (windowToWebViewMap): Added. Returns a map from open windows to their
313         WebViews.
314         (createWebViewAndOffscreenWindow): Factored out of main() to be
315         reusable for creating extra windows.
316         (main):
317         * DumpRenderTree/win/DumpRenderTreeWin.h:
318         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
319         (LayoutTestController::windowCount): Implemented.
320         * DumpRenderTree/win/UIDelegate.cpp:
321         (UIDelegate::createWebViewWithRequest): Implemented.
322         (UIDelegate::webViewClose): Implemented.
323         * DumpRenderTree/win/UIDelegate.h:
324
325 2008-01-12  Alp Toker  <alp@atoker.com>
326
327         Reviewed by Mark Rowe.
328
329         Hide non-public symbols in GTK+/autotools release builds.
330
331         * GNUmakefile.am:
332
333 2008-01-12  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
334
335         Reviewed by Ap.
336
337         * Make launching of the WebKit httpd work on GNU/Debian/Linux
338         
339         The configuration of Apache2 and installation does not depend on
340         the kernel but on the distribution policy. Make launching of httpd
341         work for Debian derived distributions.
342
343         * Scripts/run-webkit-httpd:
344         * Scripts/run-webkit-tests:
345         * Scripts/webkitdirs.pm:
346
347 2008-01-12  Mark Rowe  <mrowe@apple.com>
348
349         Reviewed by Maciej Stachowiak.
350
351         Fix crash in http/tests/security/local-JavaScript-from-remote.html under guard malloc.
352
353         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Retain string before returning it to
354         match the callers expectations that it can take ownership of the string.
355
356 2008-01-11  Alexey Proskuryakov  <ap@webkit.org>
357
358         Reviewed by Adam Roben.
359
360         <rdar://problem/5667275> fast/dynamic/layer-hit-test-crash.html is failing
361
362         * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ignore WM_MOUSELEAVE events,
363         as these are only posted because the test window is not a normal visible one, and
364         they confuse drag&drop machinery.
365
366 2008-01-11  Adam Roben  <aroben@apple.com>
367
368         Fix a crash when pathToLocalResource fails and a leak
369
370         Reviewed by Darin.
371
372         * DumpRenderTree/LayoutTestController.cpp:
373         (pathToLocalResourceCallback): Dont leak the JSStringRef, and make
374         sure not to pass null to JSValueMakeString.
375         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
376         (LayoutTestController::pathToLocalResource): Print an error message if
377         the conversion fails so it's clear what happened.
378
379 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
380
381         Reviewed by John Sullivan.
382
383         * DumpRenderTree/mac/GCControllerMac.mm:
384         (GCController::collectOnAlternateThread): Updated for name change.
385
386 2008-01-10  Kevin Ollivier  <kevino@theolliviers.com>
387
388         wx build fix. Don't build dftables any longer since it's now a Perl
389         script.
390
391         * wx/build-wxwebkit:
392
393 2008-01-10  Sam Weinig  <sam@webkit.org>
394
395         Reviewed by Anders Carlsson.
396
397         Make DRT track open windows instead of allocated windows so that
398         we can avoid ASSERTION due to late deallocs out of our control.
399
400         * DumpRenderTree/mac/DumpRenderTree.mm:
401         (dumpBackForwardListForAllWindows):
402         (runTest):
403         * DumpRenderTree/mac/DumpRenderTreeMac.h:
404         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
405         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
406         (+[DumpRenderTreeWindow openWindows]):
407         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
408         (-[DumpRenderTreeWindow close]):
409         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
410         (LayoutTestController::windowCount):
411
412 2008-01-10  Ada Chan  <adachan@apple.com>
413
414         Meta key is not the same as Alt key on windows.
415
416         Reviewed by Darin.
417
418         * DumpRenderTree/win/EventSender.cpp:
419         (keyDownCallback):
420
421 2008-01-09  Kevin McCullough  <kmccullough@apple.com>
422
423         Reviewed by Darin, Sam and Adam.
424
425         -<rdar://problem/5654486> REGRESSION (Safari 3.0.4-TOT): clicking on
426         link in gmail message displays JavaScript alert falsely complaining
427         about pop-up blocking.
428         - Added the ability to enable the pop-up blocker via the
429         LayoutTestController.
430
431         * DumpRenderTree/LayoutTestController.cpp:
432         (setPopupBlockingEnabledCallback):
433         (LayoutTestController::staticFunctions):
434         * DumpRenderTree/LayoutTestController.h:
435         * DumpRenderTree/mac/DumpRenderTree.mm:
436         (setDefaultsToConsistentValuesForTesting):
437         (resetWebViewToConsistentStateBeforeTesting):
438         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
439         (LayoutTestController::setPopupBlockingEnabled):
440
441 2008-01-10  Lars Knoll  <lars@trolltech.com>
442
443         Reviewed by Simon.
444
445         rename QWebPageHistory to QWebHistory.
446         
447
448         * DumpRenderTree/qt/jsobjects.cpp:
449
450 2008-01-09  Maciej Stachowiak  <mjs@apple.com>
451
452         Reviewed by Darin.
453         
454         - add some more renames, adjust some
455
456         * Scripts/do-webcore-rename:
457
458 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
459
460         Reviewed by Oliver.
461
462         Enable SVG Fonts support by default.
463
464         * Scripts/build-webkit:
465
466 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
467
468         Reviewed by Adam.
469
470         Fixes: http://bugs.webkit.org/show_bug.cgi?id=16244
471         DRT doesn't handle platform specific pixel test results correctly.
472
473         <test>-expected.txt files and <test>-expected.png files may now live
474         in different directories (ie. a cross-platform <test>-expected.txt file
475         and a platform-specific <test>-expected.png file).
476
477         * Scripts/run-webkit-tests:
478
479 2008-01-04  Kevin McCullough  <kmccullough@apple.com>
480
481         Reviewed by Darin.
482
483         - <rdar://problem/5666914> fast/regex/test{1,4}.html are failing
484         DRT did not correctly handle printing the '\0' char.  Now it does.
485
486         * DumpRenderTree/win/DumpRenderTree.cpp:
487         (dumpFramesAsText):
488         (dump):
489
490 2008-01-07  Simon Hausmann  <hausmann@webkit.org>
491
492         Reviewed by Lars.
493
494         Ported of the network backend of the Qt platform to Qt 4.4's new networking API.
495         
496
497         * DumpRenderTree/qt/main.cpp:
498         * DumpRenderTree/qt/testplugin.cpp:
499         * DumpRenderTree/qt/testplugin.h:
500
501 2008-01-05  Mark Rowe  <mrowe@apple.com>
502
503         Reviewed by Alp Toker.
504
505         Fix hang in fast/frames/frame-display-none-focus.html during Gtk layout tests.
506
507         * DumpRenderTree/gtk/DumpRenderTree.cpp:
508         (processWork): Process pending work.
509         (webViewLoadFinished): Schedule processing of pending work.
510         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Use webkit_web_frame_reload.
511
512 2008-01-05  Darin Adler  <darin@apple.com>
513
514         * Scripts/do-webcore-rename: Some more renaming plans.
515
516 2008-01-04  Alice Liu  <alice.liu@apple.com>
517
518         Reviewed by Alexey and Darin.
519
520         Adding "home" and "end" to DRT's keydown since
521         DOM key events can't handle keyIdentifiers at this point. 
522
523         * DumpRenderTree/mac/EventSendingController.mm:
524         (-[EventSendingController keyDown:withModifiers:]):
525         * DumpRenderTree/win/EventSender.cpp:
526         (keyDownCallback):
527
528 2008-01-04  Lars Knoll  <lars@trolltech.com>
529
530         Reviewed by Simon.
531
532         fix DRT after the changes to QWebPage.
533         
534         The great thing is that we actually don't have
535         any regressions from the QWebPage change :)
536         
537
538         * DumpRenderTree/qt/DumpRenderTree.cpp:
539         (WebCore::DumpRenderTree::DumpRenderTree):
540
541 2008-01-04  Lars Knoll  <lars@trolltech.com>
542
543         Reviewed by Simon.
544
545         make QWebPage a QObject and get things to compile.
546         
547         Nothing works currently though.
548         
549
550         * DumpRenderTree/qt/DumpRenderTree.cpp:
551         (WebCore::DumpRenderTree::DumpRenderTree):
552
553 2008-01-04  Lars Knoll  <lars@trolltech.com>
554
555         Reviewed by Simon.
556
557         take a QString as identifier in QWebFrame::addToJSWindowObject.
558
559         * DumpRenderTree/qt/DumpRenderTree.cpp:
560         (WebCore::DumpRenderTree::initJSObjects):
561
562 2008-01-04  Alp Toker  <alp@atoker.com>
563
564         GTK+ DRT build fix for breakage introduced in r29149.
565
566         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
567         (LayoutTestController::execCommand):
568
569 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
570
571         Reviewed by Darin.
572
573         <rdar://problem/5463489> A number of layout tests should be using execCommand instead of textInputController
574
575         Added layoutTestController.execCommand to access editor commands that are not available
576         via document.execCommand.
577
578         * DumpRenderTree/LayoutTestController.cpp:
579         (execCommandCallback):
580         (LayoutTestController::staticFunctions):
581         * DumpRenderTree/LayoutTestController.h:
582         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
583         (LayoutTestController::execCommand):
584         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
585         (LayoutTestController::queueLoad):
586         (LayoutTestController::execCommand):
587
588 2008-01-03  Alice Liu  <alice.liu@apple.com>
589
590         Reviewed by Darin, Mitz.
591
592         fixed <rdar://5130762> mousedowns in different locations increase the clickcount incorrectly
593
594         the clickcount should not increase if the last click was at a different location.  it's a new click.
595
596         * DumpRenderTree/mac/DumpRenderTree.mm:
597         (runTest):
598         * DumpRenderTree/mac/EventSendingController.h:
599         * DumpRenderTree/mac/EventSendingController.mm:
600         (-[EventSendingController mouseDown]):
601         (-[EventSendingController mouseUp]):
602
603 2008-01-03  Darin Adler  <darin@apple.com>
604
605         Reviewed by Adam.
606
607         * Scripts/update-webkit: Make this work a little better for the people at Apple
608         who have a directory named Internal.
609
610 2008-01-03  Adam Roben  <aroben@apple.com>
611
612         Use HTTP::Date instead of Date::Parse because it's installed by Cygwin by default
613
614         Rubberstamped by Mark.
615
616         * Scripts/update-webkit-auxiliary-libs:
617
618 2008-01-03  Adam Roben  <aroben@apple.com>
619
620         Fix Bug 15663: update-webkit re-downloads WebKitAuxiliaryLibrary unnecessarily
621
622         http://bugs.webkit.org/show_bug.cgi?id=15663
623
624         Added a fuzz factor into the Last-Modified comparison for downloading
625         WebKitAuxiliaryLibrary.zip.
626
627         The zip file is served from a set of mirrors who give Last-Modified
628         times that are off by 1-3 seconds from each other. This was causing
629         the build bots to redownload WebKitAuxiliaryLibrary for every build,
630         which would then cause all of WebCore to rebuild each time.
631
632         Reviewed by Mark.
633
634         * Scripts/update-webkit-auxiliary-libs: Check if the new zip file is
635         at least 30 seconds newer than the old one -- otherwise we assume that
636         the difference in time is due to the mirrors being slightly offset
637         from each other.
638         (sub lastModifiedToUnixTime): Added.
639
640 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
641
642         Windows build fix.
643
644         * DumpRenderTree/ForwardingHeaders/wtf/HashTraits.h: Added (needed by COMPtr.h).
645
646 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
647
648         Reviewed by Lars.
649
650         Moved QWebPage::open to QWebFrame::load and added setHtml.
651         
652
653         * DumpRenderTree/qt/DumpRenderTree.cpp:
654         (WebCore::DumpRenderTree::open):
655
656 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
657
658         Reviewed by Lars.
659
660         Added the first revision of QWebView and started moving functionality from QWebPave over to QWebView and QWebFrame.
661         
662
663         * DumpRenderTree/qt/DumpRenderTree.cpp:
664         (WebCore::DumpRenderTree::DumpRenderTree):
665
666 2008-01-02  Sam Weinig  <sam@webkit.org>
667
668         * Scripts/do-webcore-rename: Yet more renaming ideas.
669
670 2008-01-02  Darin Adler  <darin@apple.com>
671
672         * Scripts/do-webcore-rename: More renaming ideas. (Maciej, please merge yours with mine.)
673
674 2008-01-02  Alice Liu  <alice.liu@apple.com>
675
676         Reviewed by Sam Weinig.
677
678         fixing assertion hit with editing/selection/move-begin-end.html
679
680         * DumpRenderTree/ForwardingHeaders/wtf/ASCIICType.h: Added.
681         * DumpRenderTree/win/DumpRenderTree.vcproj:
682         * DumpRenderTree/win/EventSender.cpp:
683         (keyDownCallback):
684         using isupper will cause an assertion for inputs outside of ascii range. use isASCIIUpper instead.
685
686 2008-01-02  Darin Adler  <darin@apple.com>
687
688         * Scripts/do-webcore-rename: Some more name change plans.
689
690 2008-01-02  Alice Liu  <alice.liu@apple.com>
691
692         Reviewed by Maciej.
693
694         Added handling for page up and page down in EventSender
695
696         * DumpRenderTree/mac/EventSendingController.mm:
697         (-[EventSendingController keyDown:withModifiers:]):
698         * DumpRenderTree/win/EventSender.cpp:
699         (keyDownCallback):
700
701 2008-01-02  Alexey Proskuryakov  <ap@webkit.org>
702
703         Reviewed by Darin.
704
705         Fix fast/events/arrow-keys-on-body.html for real.
706
707         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Pass proper keyData for WM_KEYUP, too.
708
709 2008-01-02  Luca Bruno  <lethalman88@gmail.com>
710
711         Reviewed by Darin.
712
713         http://bugs.webkit.org/show_bug.cgi?id=16674
714         [GTK] run-launcher sets wrong LD_LIBRARY_PATH
715
716         * Scripts/run-launcher:
717
718 2007-12-31  Darin Adler  <darin@apple.com>
719
720         Suggested by Antti.
721
722         * Scripts/webkitdirs.pm: Turned off the QuickTime requirement for Windows until
723         we get it installed on the build bots.
724
725 2007-12-30  Eric Seidel  <eric@webkit.org>
726
727         Reviewed by Sam.
728
729         * Scripts/do-webcore-rename: Add a few more planned renames s/(\w+)Imp/\1/
730
731 2007-12-29  Darin Adler  <darin@apple.com>
732
733         Reviewed by Oliver.
734
735         - fix http://bugs.webkit.org/show_bug.cgi?id=16663
736           leak bot shows createCStringFromNPVariant result leaking
737
738         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
739         (pluginInvoke): Added a missing free.
740
741 2007-12-26  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
742
743         Reviewed by Alp Toker.
744
745         http://bugs.webkit.org/show_bug.cgi?id=16390
746         Use autotools or GNU make as the build system for the GTK port
747
748         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: include glib.h
749         * GNUmakefile.am: Added.
750
751 2007-12-24  Alexey Proskuryakov  <ap@webkit.org>
752
753         Reviewed by Oliver.
754
755         Fix fast/events/arrow-keys-on-body.html, failing on Windows.
756
757         * DumpRenderTree/win/EventSender.cpp:
758         (keyDownCallback): Add KF_EXTENDED flag to arrow keys. Also add a count
759         of 1, even though WebKit currently ignores it.
760
761 2007-12-23  Kevin Ollivier  <kevino@theolliviers.com>
762
763         wx buildbot fix. Update libpng dl script to the latest version.
764
765         * wx/install-unix-extras:
766
767 2007-12-22  Antti Koivisto  <antti@apple.com>
768
769         Fix a typo.
770
771         * Scripts/webkitdirs.pm:
772
773 2007-12-21  Sam Weinig  <sam@webkit.org>
774
775         Reviewed by Mark Rowe.
776
777         - Disable the back/forward cache using the new WebPreferences API
778           instead of through the BackForwardList.  This makes us match what
779           we do on Windows.
780
781         * DumpRenderTree/mac/DumpRenderTree.mm:
782         (createWebViewAndOffscreenWindow):
783         (setDefaultsToConsistentValuesForTesting):
784
785 2007-12-21  Dan Bernstein  <mitz@apple.com>
786
787         Reviewed by Mark Rowe.
788
789         - disable the back/forward cache in Windows DumpRenderTree. It is
790           already disabled in Mac DumpRenderTree.
791
792         * DumpRenderTree/win/DumpRenderTree.cpp:
793         (initializePreferences):
794
795 2007-12-13  Antti Koivisto  <antti@apple.com>
796
797         Reviewed by Darin and Steve.
798         
799         - check for QuickTime SDK on Windows.
800         - build media support on Windows by default
801
802         * Scripts/build-webkit:
803         * Scripts/webkitdirs.pm:
804
805 2007-12-21  Kevin Ollivier  <kevino@theolliviers.com>
806
807         Build script fix for buildbot.
808
809         * wx/build-wxwebkit:
810
811 2007-12-20  Eric Seidel  <eric@webkit.org>
812
813         Reviewed by mjs.
814
815         * Scripts/run-sunspider: change --runs default to 10 for better accuracy
816
817 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
818
819         Reviewed by Steve.
820
821         - <rdar://5656485> Drosera: Win: Nightly does not reliably connect to
822         WebKit.
823
824         - Drosera and Safari need to use the same ProgIDs in order for
825         CoCreateInstance to work properly.  The most robust way to do this is
826         for WebKit to dynamically publish those ProgIDs.
827
828         * Drosera/win/DebuggerClient.cpp: Use the published ProgIDs
829         (DebuggerClient::createWebViewWithRequest):
830         * Drosera/win/Drosera.cpp: Use the published ProgIDs and rename some
831         statics.
832         (Drosera::initUI):
833         (Drosera::attach):
834         (Drosera::attemptToCreateServerConnection):
835         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Fix a runtime failure.
836         * Drosera/win/ServerConnection.cpp: Reformat the connection function and
837         make use of the published ProgIDs.
838         (ServerConnection::attemptToCreateServerConnection):
839
840 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
841
842         - <rdar://problem/5658317> REGRESSION: 20+ leaks seen on buildbots.
843         - Build bot and leak fix.
844
845         * DumpRenderTree/LayoutTestController.cpp:
846         (pathToLocalResourceCallback):
847
848 2007-12-19  David Kilzer  <ddkilzer@apple.com>
849
850         Make svn-apply/svn-unapply work with patches from git-format-patch.
851
852         Reviewed by Darin.
853
854         * Scripts/svn-apply:
855         (patch): If 'Index:' can't be found in the text passed in, print it
856         out with a warning and return early.
857         * Scripts/svn-unapply:
858         (patch): Ditto.
859
860 2007-12-18  Kevin Ollivier  <kevino@theolliviers.com>
861
862         Reviewed by Alp Toker.
863
864         Build related fixes.
865
866         * wx/build-wxwebkit:
867         - Check to make sure the user is running a supported wx port
868         - More robust checks for Cygwin
869         - Only run install-unix-extras on Mac, it's not the right solution
870           for Linux distros.
871         - Remove outdated Linux instructions after successful build
872         - Clean Bakefile-generated files during a clean operation
873
874 2007-12-18  Darin Adler  <darin@apple.com>
875
876         * Scripts/make-js-test-wrappers: Don't generate a wrapper for select-options-remove.js.
877
878 2007-12-18  Steve Falkenburg  <sfalken@apple.com>
879
880         Add script to run Drosera as part of the nightly.
881         
882         Reviewed by Kevin M.
883
884         * Scripts/run-drosera.cmd: Added.
885
886 2007-12-18  Darin Adler  <darin@apple.com>
887
888         * Scripts/do-webcore-rename: Remove a stray K.
889
890 2007-12-18  Darin Adler  <darin@apple.com>
891
892         * Scripts/do-webcore-rename: Plan more renaming.
893
894 2007-12-14  Juan A. Suarez Romero  <jasuarez@igalia.com>
895
896         Reviewed by Alp Toker.
897
898         http://bugs.webkit.org/show_bug.cgi?id=16042
899         [GTK] Eliminate webkit_init()
900
901         Moving webkit initialization to WebView class init.
902
903         * DumpRenderTree/gtk/DumpRenderTree.cpp:
904         (main):
905         * GtkLauncher/main.c:
906         (main):
907
908 2007-12-17  Luca Bruno  <lethalman88@gmail.com>
909
910         Reviewed by Alp Toker.
911
912         http://bugs.webkit.org/show_bug.cgi?id=13542
913         gdklauncher doesnt change URL in adress GTKEntry.
914
915         * GtkLauncher/main.c:
916         (load_commit_cb): added
917         (title_change_cb):
918         (create_browser):
919
920 2007-12-16  Dimitri Glazkov  <dimitri@glazkov.com>
921
922         Reviewed by Adam Roben.
923
924         Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.
925
926         * FindSafari/FindSafari.cpp:
927         (_tmain):
928
929 2007-12-16  Brent Fulgham  <bfulgham@gmail.com>
930
931         Reviewed by Adam Roben.
932
933         http://bugs.webkit.org/show_bug.cgi?id=16315
934         FindSafari needs a path-only option.
935
936         * FindSafari/FindSafari.cpp:
937         (_tmain):
938
939 2007-12-16  Alexey Proskuryakov  <ap@webkit.org>
940
941         Reviewed by Darin.
942
943         http://bugs.webkit.org/show_bug.cgi?id=16462
944         REGRESSION: access keys broken on Windows
945
946         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Send system key events
947         if Alt is pressed.
948
949 2007-12-15  Sam Weinig  <sam@webkit.org>
950
951         Reviewed by Mark Rowe.
952
953         Fix urlSuitableForTestResult to correctly identify wstring::npos as
954         the case when wstring.find doesn't find anything.
955
956         * DumpRenderTree/win/DumpRenderTree.cpp:
957         (urlSuitableForTestResult):
958
959 2007-12-15  Alp Toker  <alp@atoker.com>
960
961         GTK+ DRT build fix for GLib < 2.14.
962
963         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
964         (LayoutTestController::setWaitToDump):
965
966 2007-12-05  Mark Rowe  <mrowe@apple.com>
967
968         Reviewed by Alp Toker.
969
970         Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.  This prevents
971         many layout tests from hanging while waiting on user responses to dialogs.
972
973         * DumpRenderTree/gtk/DumpRenderTree.cpp:
974         (invalidateAnyPreviousWaitToDumpWatchdog):
975         (webViewScriptAlert):
976         (webViewScriptPrompt):
977         (webViewScriptConfirm):
978         (main):
979         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
980         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
981         (waitToDumpWatchdogFired):
982         (LayoutTestController::setWaitToDump):
983
984 2007-12-05  Mark Rowe  <mrowe@apple.com>
985
986         Reviewed by Alp Toker.
987
988         Flesh out DumpRenderTree for Gtk.  After these changes, the majority of the tests in fast/js pass.
989
990         * DumpRenderTree/gtk/DumpRenderTree.cpp:
991         (dumpFramesAsText): Don't print the frame name when dumping the main frame as text.
992         (dump):
993         (runTest):
994         (webViewLoadStarted): Store the top frame when it starts loading so we can use it to determine when to dump.
995         (webViewLoadFinished): Dump when the top frame load completes if we're not waiting for a JS callback and the
996         work queue is empty.
997         (webViewWindowObjectCleared): Set up window.layoutTestController.
998         (webViewConsoleMessage): Match the console message format expected by the layout test results.
999         (main): Hook up the new signals.
1000         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
1001         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Only notify done if the top frame has completed loading to avoid
1002         dumping multiple times.
1003         * Scripts/build-dumprendertree: Ensure build-dumprendertree is a no-op for Gtk too.
1004         * Scripts/run-webkit-tests: Teach run-webkit-tests that Gtk is like Qt in many ways.  Use run-launcher to open test results.
1005
1006 2007-12-14  Anders Carlsson  <andersca@apple.com>
1007
1008         Reviewed by Brady.
1009
1010         Assert that a web frame that's loading a resource always has either a data source or 
1011         a provisional data source.
1012         
1013         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1014         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1015
1016 2007-12-14  Darin Adler  <darin@apple.com>
1017
1018         - fix mistake causing nearly all tests to fail on Windows
1019
1020         * DumpRenderTree/win/UIDelegate.cpp:
1021         (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with
1022         npos, not 0. Also pass URL in to URL function rather than passing the entire message.
1023
1024         * DumpRenderTree/mac/UIDelegate.mm:
1025         (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather
1026         than passing the entire message.
1027
1028 2007-12-14  Darin Adler  <darin@apple.com>
1029
1030         - fix Tiger build
1031
1032         * DumpRenderTree/mac/UIDelegate.mm:
1033         (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any
1034         new-to-Leopard methods.
1035
1036 2007-12-14  Darin Adler  <darin@apple.com>
1037
1038         * DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method
1039         since it now triggers unwanted icon loading. We only had it because we implemented "all"
1040         delegate methods here.
1041
1042 2007-12-14  Anders Carlsson  <andersca@apple.com>
1043
1044         Reviewed by Darin and Geoff.
1045
1046         <rdar://problem/5619295> 
1047         REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
1048         
1049         Add property getting methods to the plug-in.
1050         
1051         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1052         (pluginInvoke):
1053
1054 2007-12-14  Kevin McCullough  <kmccullough@apple.com>
1055
1056         Reviewed by Darin.
1057
1058         - Layout test fix for mac. When dumped to the console local file paths
1059         now only show the name of the resource not the whole path.  This is to
1060         make the results machine and OS independent.
1061
1062         * DumpRenderTree/mac/UIDelegate.mm:
1063         (-[UIDelegate webView:addMessageToConsole:]):
1064
1065 2007-12-13  Kevin McCullough  <kmccullough@apple.com>
1066
1067         Reviewed by Adam.
1068
1069         - Layout tests fix.  We need a way to remove machine-dependent
1070         information from paths in layout test results. The UIDelegate now does
1071         this.
1072
1073         * DumpRenderTree/DumpRenderTree.h:
1074         * DumpRenderTree/win/DumpRenderTree.cpp:
1075         (urlSuitableForTestResult):
1076         * DumpRenderTree/win/DumpRenderTreeWin.h:
1077         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1078         * DumpRenderTree/win/UIDelegate.cpp:
1079         (UIDelegate::webViewAddMessageToConsole):
1080
1081 2007-12-13  Alp Toker  <alp@atoker.com>
1082
1083         Build fix for DRT breakage introduced in r28690.
1084
1085         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1086         (LayoutTestController::pathToLocalResource):
1087
1088 2007-12-12  Kevin McCullough  <kmccullough@apple.com>
1089
1090         Reviewed by Alice and Sam.
1091
1092         - <rdar://5621435> Need a way to specify local resources (being loaded
1093         from HTTP tests) on Windows.
1094         - Implemented pathToLocalResource which exposes the functionality of
1095         converting a given unix path to the correct location on Windows.
1096
1097         * DumpRenderTree/LayoutTestController.cpp:
1098         (pathToLocalResourceCallback):
1099         (LayoutTestController::staticFunctions):
1100         * DumpRenderTree/LayoutTestController.h:
1101         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1102         (LayoutTestController::pathToLocalResource):
1103         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1104         (LayoutTestController::pathToLocalResource):
1105
1106 2007-12-12  Anders Carlsson  <andersca@apple.com>
1107
1108         Reviewed by Sam.
1109
1110         <rdar://problem/5132003>
1111         dumpResourceLoadCallbacks is not implemented in DRT on Windows.
1112
1113         * DumpRenderTree/win/DumpRenderTree.cpp:
1114         (main):
1115         Set the resource load delegate.
1116         
1117         * DumpRenderTree/win/DumpRenderTree.vcproj:
1118         
1119         * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
1120         * DumpRenderTree/win/ResourceLoadDelegate.h: Added.
1121
1122 2007-12-12  Alexey Proskuryakov  <ap@webkit.org>
1123
1124         Reviewed by Adam Roben.
1125
1126         Fix conversion from double to LPARAM in dispatchMessage().
1127
1128         * DumpRenderTree/win/EventSender.cpp:
1129         (dispatchMessageCallback):
1130
1131 2007-12-11  Dan Bernstein  <mitz@apple.com>
1132
1133         Reviewed by Mark Rowe and Sam Weinig too!
1134
1135         - added Helvetica Oblique and Helvetica Bold Oblique to the list of
1136           fonts DumpRenderTree registers.
1137
1138         * DumpRenderTree/win/DumpRenderTree.cpp:
1139         (initialize):
1140
1141 2007-12-11  Brady Eidson  <beidson@apple.com>
1142
1143         Reviewed by Anders
1144
1145         Make DumpRenderTree on mac use its own path for Databases testing
1146
1147         * DumpRenderTree/mac/DumpRenderTree.mm:
1148         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree 
1149           for future DRT-only use, then use it to construct the Databases path and set that default
1150
1151 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
1152
1153         Reviewed by Darin.
1154
1155         <rdar://problem/5535636>
1156         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
1157
1158         http://bugs.webkit.org/show_bug.cgi?id=13916
1159         JavaScript detects Tab as a character input on a textfield validation
1160
1161         * DumpRenderTree/mac/EventSendingController.mm:
1162         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
1163         Dispatch a keyup to better match what happens when a key is physically pressed.
1164
1165         * DumpRenderTree/win/EventSender.cpp:
1166         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
1167         returning from keyDown().
1168         (getConstantCallback): Fixed a couple copy/paste mistakes.
1169
1170 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
1171
1172         Reviewed by Oliver.
1173
1174         - <rdar://5599845> Drosera: Does not show loal files in the file list
1175         on the left side.
1176
1177         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
1178         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
1179         so the open source community can build.
1180
1181 2007-12-10  Brady Eidson  <beidson@apple.com>
1182
1183         Rubberstamped by Sam Weinig
1184
1185         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
1186
1187         * DumpRenderTree/mac/UIDelegate.mm:
1188         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
1189         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
1190
1191 2007-12-08  Oliver Hunt  <oliver@apple.com>
1192
1193         Reviewed by Sam W.
1194
1195         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
1196         
1197         Fixes <rdar://problem/5620249> Must disable SVG animation
1198         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
1199         
1200         In order to allow finer grained control over the set of SVG features
1201         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
1202         distinct flags:
1203         ENABLE_SVG_ANIMATION
1204         ENABLE_SVG_FILTERS
1205         ENABLE_SVG_FONTS
1206         ENABLE_SVG_AS_IMAGE
1207         ENABLE_SVG_USE
1208         
1209         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
1210         
1211         Script handles all the new build flags, and allows --svg-experimental
1212         to automatically enable all features.
1213
1214         * Scripts/build-webkit:
1215
1216 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
1217
1218         Fix version parsing.
1219
1220         Rubber-stamped by Oliver.
1221
1222         * Drosera/win/Drosera.vcproj/auto-version.sh:
1223
1224 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
1225
1226         Build modifications for Drosera.
1227
1228         Reviewed by Adam.
1229
1230         * Drosera/DroseraWin.make: Added.
1231         * Drosera/win/Drosera.vcproj/Drosera.rc:
1232         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1233         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
1234         * Drosera/win/Drosera.vcproj/VERSION: Added.
1235         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
1236
1237 2007-12-06  Adam Roben  <aroben@apple.com>
1238
1239         Explicitly turn on the Mac font ascent hack on Windows
1240
1241         This keeps our font metrics matching those from Mac.
1242
1243         Reviewed by Hyatt.
1244
1245         * DumpRenderTree/win/DumpRenderTree.cpp:
1246         (main):
1247
1248 2007-12-06  Anders Carlsson  <andersca@apple.com>
1249
1250         Rename main.c to main.cpp here too.
1251         
1252         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
1253
1254 2007-12-06  Sam Weinig  <sam@webkit.org>
1255
1256         Rubber stamped by Geoff.
1257
1258         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
1259
1260 2007-12-06  Darin Adler  <darin@apple.com>
1261
1262         * Scripts/do-webcore-rename: Some more renaming plans.
1263
1264 2007-12-06  Anders Carlsson  <andersca@apple.com>
1265
1266         Restore implementation of testGetIntIdentifier that was accidentally
1267         removed somehow (possibly when I made PluginObject be a cpp file).
1268         
1269         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1270         (pluginInvoke):
1271
1272 2007-12-05  Anders Carlsson  <andersca@apple.com>
1273
1274         Make the entry points extern "C".
1275         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1276         
1277 2007-12-05  Anders Carlsson  <andersca@apple.com>
1278
1279         C++ warning fixes.
1280         
1281         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1282         (NPP_New):
1283         (NPP_Destroy):
1284         (NPP_SetWindow):
1285         (NPP_NewStream):
1286         (NPP_HandleEvent):
1287         (NPP_URLNotify):
1288         (NPP_GetValue):
1289
1290 2007-12-05  Anders Carlsson  <andersca@apple.com>
1291
1292         Add the .cpp files to the TestNetscapePlugIn target.
1293
1294         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1295
1296 2007-12-05  Anders Carlsson  <andersca@apple.com>
1297
1298         Reviewed by Geoff.
1299         
1300         Rename the TestNetscapePlugIn .c files to be .cpp.
1301
1302         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1303         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
1304         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
1305         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
1306         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
1307         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
1308         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
1309         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1310
1311 2007-12-05  Adam Roben  <aroben@apple.com>
1312
1313         Fix case of keypresses from the Windows implementation of eventSender.keyDown
1314
1315         This fixes several regression tests.
1316
1317         Reviewed by Alice.
1318
1319         * DumpRenderTree/win/EventSender.cpp:
1320         (keyDownCallback): Virtual keycodes for ASCII characters are always
1321         uppercase, so we need to check the case of the original character
1322         passed in to eventSender.keyDown.
1323
1324 2007-12-05  Adam Roben  <aroben@apple.com>
1325
1326         Learn from Tim's mistakes
1327
1328         * DumpRenderTree/win/DumpRenderTree.cpp:
1329         (runTest): Reset the authorAndUserStylesEnabled preference for each
1330         test.
1331
1332 2007-12-05  Alp Toker  <alp@atoker.com>
1333
1334         Reviewed by Mark Rowe.
1335
1336         Initialize GTK+ and WebKit so the tests can run.
1337
1338         Reorganize the headers a little.
1339
1340         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1341         (main):
1342
1343 2007-12-04  Anders Carlsson  <andersca@apple.com>
1344
1345         Remove IWebScriptScope include.
1346         
1347         * Drosera/win/DebuggerDocumentPlatform.cpp:
1348
1349 2007-12-04  Sam Weinig  <sam@webkit.org>
1350
1351         Rubber stamped by Mark Rowe.
1352
1353         Define CF as platform for mac and revert r28409
1354
1355         * DumpRenderTree/DumpRenderTree.h:
1356         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1357
1358 2007-12-04  Sam Weinig  <sam@webkit.org>
1359
1360         Define CF as platform for windows.
1361
1362         Reviewed by Adam Roben.
1363
1364         * DumpRenderTree/win/DumpRenderTreeWin.h:
1365
1366 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
1367
1368         Reviewed by Adam and Darin.
1369
1370         - Removed a needless BSTR cleanup.
1371
1372         * Drosera/win/DebuggerDocumentPlatform.cpp:
1373         (DebuggerDocument::getPlatformCurrentFunctionStack):
1374
1375 2007-11-27  Adam Roben  <aroben@apple.com>
1376
1377         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
1378
1379         Reviewed by Maciej.
1380
1381         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1382         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
1383
1384 2007-12-04  Alp Toker  <alp@atoker.com>
1385
1386         Prospective Win DRT build fix.
1387
1388         * DumpRenderTree/DumpRenderTree.h:
1389
1390 2007-12-04  Alp Toker  <alp@atoker.com>
1391
1392         Fix a clobbered copyright header.
1393
1394         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1395
1396 2007-12-04  Xan Lopez  <xan@gnome.org>
1397
1398         Reviewed by Alp Toker.
1399
1400         http://bugs.webkit.org/show_bug.cgi?id=15561
1401         GTK port needs DumpRenderTree implementation
1402
1403         Start work on the GTK+ DRT.
1404
1405         This does not work yet, and there are a few lingering style issues
1406         (nothing major) but this patch has been stuck in the bug tracker for
1407         too long already.
1408
1409         * DumpRenderTree/DumpRenderTree.h:
1410         * DumpRenderTree/gtk: Added.
1411         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
1412         (autocorrectURL):
1413         (shouldLogFrameLoadDelegates):
1414         (dumpFrameScrollPosition):
1415         (displayWebView):
1416         (appendString):
1417         (dumpFramesAsText):
1418         (dumpRenderTreeAsText):
1419         (dump):
1420         (runTest):
1421         (main):
1422         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
1423         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
1424         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
1425         (GCController::collect):
1426         (GCController::collectOnAlternateThread):
1427         (GCController::getJSObjectCount):
1428         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
1429         (LayoutTestController::~LayoutTestController):
1430         (LayoutTestController::addDisallowedURL):
1431         (LayoutTestController::clearBackForwardList):
1432         (LayoutTestController::copyDecodedHostName):
1433         (LayoutTestController::copyEncodedHostName):
1434         (LayoutTestController::display):
1435         (LayoutTestController::keepWebHistory):
1436         (LayoutTestController::notifyDone):
1437         (LayoutTestController::queueBackNavigation):
1438         (LayoutTestController::queueForwardNavigation):
1439         (LayoutTestController::queueLoad):
1440         (LayoutTestController::queueReload):
1441         (LayoutTestController::queueScript):
1442         (LayoutTestController::setAcceptsEditing):
1443         (LayoutTestController::setCustomPolicyDelegate):
1444         (LayoutTestController::setMainFrameIsFirstResponder):
1445         (LayoutTestController::setTabKeyCyclesThroughElements):
1446         (LayoutTestController::setUseDashboardCompatibilityMode):
1447         (LayoutTestController::setUserStyleSheetEnabled):
1448         (LayoutTestController::setUserStyleSheetLocation):
1449         (LayoutTestController::setWindowIsKey):
1450         (LayoutTestController::setWaitToDump):
1451         (LayoutTestController::windowCount):
1452         (LayoutTestController::setPrivateBrowsingEnabled):
1453         (LayoutTestController::setAuthorAndUserStylesEnabled):
1454         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
1455         (JSStringCopyUTF8CString):
1456         (LoadItem::invoke):
1457         (ReloadItem::invoke):
1458         (ScriptItem::invoke):
1459         (BackForwardItem::invoke):
1460
1461 2007-12-03  Sam Weinig  <sam@webkit.org>
1462
1463         Move JavaScriptCore thread testing code to pthread specific directory
1464         and remove the dependance on CoreFoundation by using WTF::HashSet.
1465
1466         Reviewed by Geoff and Oliver.
1467
1468         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1469         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
1470         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
1471         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
1472         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
1473         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
1474         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
1475         * DumpRenderTree/pthreads: Added.
1476         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
1477         (javaScriptThreads):
1478         (runJavaScriptThread):
1479         (startJavaScriptThreads):
1480         (stopJavaScriptThreads):
1481
1482 2007-12-03  Andrew Bonventre  <andybons@google.com>
1483
1484         Reviewed by Darin Adler.
1485
1486         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
1487         Symbol lookup menu broken in debugger view
1488
1489         * Drosera/debugger.js: Fixed javascript error where document property
1490         should have been used instead of contentDocument in switchFunction that
1491         was breaking the select symbol dropdown menu.  This is because
1492         window.frames will return a Window object and not a frame object like
1493         the author was originally expecting.
1494
1495 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
1496
1497         Reviewed by Adam.
1498
1499         - <rdar://5618942> Drosera: Console window does not process everything
1500         correctly.
1501         - <rdar://5619005> Drosera: could be sped up by moving the 
1502         WebScriptScope stuff into the WebScriptCallFrame.
1503         - Now the console can correctly process objects and does not receive
1504         notifications from JavaScriptCore about the JavaScript in Drosera's
1505         own process.
1506
1507         * Drosera/win/DebuggerDocumentPlatform.cpp:
1508         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1509         (DebuggerDocument::platformValueForScopeVariableNamed):
1510
1511 2007-12-03  Stephanie  <slewis@apple.com>
1512
1513         Reviewed by Darin.
1514
1515         Check to see if we are building a debug root
1516
1517         * Scripts/check-for-global-initializers: 
1518
1519 2007-12-03  Dan Bernstein  <mitz@apple.com>
1520
1521         Reviewed by Darin Adler.
1522
1523         - added a testGetIntIdentifier() method to TestNetscapePlugIn
1524
1525         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
1526         (pluginInvoke):
1527
1528 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
1529
1530         Reviewed by Oliver.
1531
1532         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
1533         in a more fine-grained manner than eventSender.keyDown().
1534
1535         * DumpRenderTree/win/EventSender.cpp:
1536         (getConstantCallback):
1537         (dispatchMessageCallback):
1538
1539 2007-12-02  Darin Adler  <darin@apple.com>
1540
1541         * Scripts/do-webcore-rename: More planned renaming.
1542
1543 2007-12-02  Sam Weinig  <sam@webkit.org>
1544
1545         Rubber stamped by Anders.
1546
1547         Use [NSURL absoluteString] instead of [NSURL description] in order to get
1548         more uniform results cross platform.
1549
1550         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1551         (-[NSURL _drt_descriptionSuitableForTestResult]):
1552
1553 2007-12-02  Sam Weinig  <sam@webkit.org>
1554
1555         Rubber stamped by Niko.
1556
1557         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
1558
1559         * DumpRenderTree/win/DumpRenderTree.cpp:
1560         * DumpRenderTree/win/DumpRenderTree.vcproj:
1561         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
1562         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
1563         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
1564         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
1565
1566 2007-12-01  Alp Toker  <alp@atoker.com>
1567
1568         Reviewed by Adam Roben.
1569
1570         Make use of the newly introduced webkit.h convenience header.
1571
1572         * GtkLauncher/main.c:
1573
1574 2007-12-01  Adam Treat  <treat@kde.org>
1575
1576         Reviewed by Simon.
1577
1578         * Check to see if the directory exists and exit if not.
1579
1580         * DumpRenderTree/qt/main.cpp:
1581         (main):
1582
1583 2007-12-01  Adam Treat  <treat@kde.org>
1584
1585         Reviewed by Simon.
1586
1587         * Don't hide symbols when in Debug mode
1588         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
1589
1590
1591         * DumpRenderTree/qt/main.cpp:
1592         (messageHandler):
1593
1594 2007-11-30  Alp Toker  <alp@atoker.com>
1595
1596         Reviewed by Adam Roben.
1597
1598         http://bugs.webkit.org/show_bug.cgi?id=15691
1599         [GTK] Public API does not follow GTK+ conventions
1600
1601         Refactor the WebKit/GTK+ public API. Changes:
1602           WebKitPage -> WebKitWebView
1603           WebKitFrame -> WebKitWebFrame
1604
1605         Public API source and header names have been updated to mirror the API
1606         changes.
1607
1608         The API is now kept in WebKit/gtk/WebView to match other ports in the
1609         same class such as Mac and Win.
1610
1611         * GtkLauncher/main.c:
1612         (activate_uri_entry_cb):
1613         (link_hover_cb):
1614         (title_change_cb):
1615         (progress_change_cb):
1616         (go_back_cb):
1617         (go_forward_cb):
1618         (create_browser):
1619         (main):
1620
1621 2007-11-30  Adam Roben  <aroben@apple.com>
1622
1623         Hopefully the final build fix
1624
1625         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
1626         pull in WTF's assertion/logging functions.
1627
1628 2007-11-30  Adam Roben  <aroben@apple.com>
1629
1630         Another build fix
1631
1632         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
1633         WebKit.lib.
1634
1635 2007-11-30  Adam Roben  <aroben@apple.com>
1636
1637         Debug build fix
1638
1639         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
1640         configuration.
1641         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
1642         projects.
1643         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
1644         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
1645         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
1646
1647 2007-11-30  Sam Weinig  <sam@webkit.org>
1648
1649         Reviewed by Adam Roben.
1650
1651         Fix drawSelectionRect to actually draw the selection rect.
1652
1653         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1654         (drawSelectionRect):
1655
1656 2007-11-30  Darin Adler  <darin@apple.com>
1657
1658         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
1659
1660 2007-11-30  Darin Adler  <darin@apple.com>
1661
1662         * Scripts/do-webcore-rename: Get ready for some future renaming.
1663
1664 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1665
1666         Reviewed by Adam.
1667
1668         - Removed some unnecessary functions and changed an unused return type. 
1669
1670         * Drosera/win/DebuggerClient.cpp:
1671         (registerConsoleClass):
1672         * Drosera/win/DebuggerClient.h:
1673         * Drosera/win/Drosera.cpp:
1674         (registerDroseraClass):
1675
1676 2007-11-28  Alp Toker  <alp@atoker.com>
1677
1678         Reviewed by Timothy Hatcher.
1679
1680         http://bugs.webkit.org/show_bug.cgi?id=16174
1681         [GTK] Use "URI" not "URL" in public API
1682
1683         Replace use of the term "URL" with "URI" in public headers,
1684         documentation and some internal code to match GLib/GTK+ convention.
1685
1686         This is now mentioned in the API guidelines:
1687           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
1688
1689         * GtkLauncher/main.c:
1690         (activate_uri_entry_cb):
1691         (title_change_cb):
1692         (create_toolbar):
1693         (main):
1694
1695 2007-11-29  Anders Carlsson  <andersca@apple.com>
1696
1697         Reviewed by Sam.
1698
1699         <rdar://problem/5230478>
1700         FrameLoadDelegate callbacks are not dumped in DRT.
1701         
1702         * DumpRenderTree/win/DumpRenderTree.cpp:
1703         (shouldLogFrameLoadDelegates):
1704         (runTest):
1705         (main):
1706         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
1707         (BSTRtoString):
1708         (descriptionSuitableForTestResult):
1709         (FrameLoadDelegate::QueryInterface):
1710         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
1711         (FrameLoadDelegate::didFailProvisionalLoadWithError):
1712         (FrameLoadDelegate::didCommitLoadForFrame):
1713         (FrameLoadDelegate::didFinishLoadForFrame):
1714         (FrameLoadDelegate::willCloseFrame):
1715         (FrameLoadDelegate::didClearWindowObject):
1716         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
1717         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
1718         * DumpRenderTree/win/FrameLoaderDelegate.h:
1719         (FrameLoadDelegate::windowScriptObjectAvailable):
1720         (FrameLoadDelegate::didFirstLayoutInFrame):
1721
1722 2007-11-29  Sam Weinig  <sam@webkit.org>
1723
1724         Reviewed by Anders.
1725
1726         Add database quota UIDelegates methods to DRT UIDelegate.
1727
1728         * DumpRenderTree/mac/UIDelegate.mm:
1729         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
1730         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
1731
1732 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1733
1734         Reviewed by Sam.
1735
1736         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
1737         dying and vice versa.
1738         - This fix will allow Drosera and Safari to reconnect if either of them
1739         closes correctly, but does not fix the case where one of them dies
1740         silently.
1741
1742         * Drosera/win/ServerConnection.cpp:
1743         (ServerConnection::attemptToCreateServerConnection): Added a safety
1744         check, because it's possilbe to try to connect to a server that's dying.
1745         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
1746         the server has died.
1747         * Drosera/win/ServerConnection.h: Added the new function and removed
1748         an unnecessary member.
1749
1750 2007-11-29  Anders Carlsson  <andersca@apple.com>
1751
1752         * DumpRenderTree/win/DumpRenderTree.vcproj:
1753         Add shlwapi.lib to all configurations.
1754
1755 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1756
1757         - Build fix.  Added additional includes for VS Express to the Release
1758         project.
1759
1760         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1761
1762 2007-11-29  Anders Carlsson  <andersca@apple.com>
1763
1764         Reviewed by Adam.
1765
1766         <rdar://problem/5132005>
1767         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
1768         
1769         * DumpRenderTree/win/DumpRenderTree.vcproj:
1770         Add shlwapi.lib
1771         
1772         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1773         (LayoutTestController::setUserStyleSheetEnabled):
1774         Implement this.
1775         
1776         (appendComponentToPath):
1777         New method which wraps the Win32 API PathAppend.
1778         
1779         (followShortcuts):
1780         New method which checks if a file points to a shortcut and
1781         follows the shortcut.
1782         
1783         (resolveCygwinPath):
1784         New method that takes a cygwin unix-style path and returns the Win32 path.
1785         
1786         (cfStringRefToWString):
1787         
1788         (LayoutTestController::setUserStyleSheetLocation):
1789         Implement this.
1790
1791 2007-11-29  Alice Liu  <alice.liu@apple.com>
1792
1793         Reviewed by Adam.
1794
1795         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
1796
1797         * DumpRenderTree/win/EventSender.cpp:
1798         (keyDownCallback):
1799         uppercase letters were being sent as lowercase letters without the shift key down.
1800
1801 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1802
1803         - Windows build fix. VS express needs some love.
1804
1805         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1806
1807 2007-11-28  Darin Adler  <darin@apple.com>
1808
1809         Reviewed by Adam Roben.
1810
1811         * DumpRenderTree/mac/EventSendingController.mm:
1812         (-[EventSendingController keyDown:withModifiers:]):
1813         Send capital letters through as lowercase letters with the shift key down
1814         rather than sending them as if they were highly unusual "capital letter keys".
1815
1816         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
1817         where you need to update results and more tests are failing than before.
1818
1819 2007-11-28  Anders Carlsson  <andersca@apple.com>
1820
1821         Reviewed by Darin.
1822
1823         <rdar://problem/5132001>
1824         contextClick is not implemented in DRT on Windows.
1825         
1826         * DumpRenderTree/win/EventSender.cpp:
1827         (contextClickCallback):
1828         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
1829         by a WM_RBUTTONUP message.
1830         
1831         * DumpRenderTree/win/UIDelegate.cpp:
1832         (UIDelegate::hasCustomMenuImplementation):
1833         (UIDelegate::trackCustomPopupMenu):
1834         * DumpRenderTree/win/UIDelegate.h:
1835         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
1836         menu from being shown (and causing the DRT to hang).
1837
1838 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
1839
1840         Reviewed by Darin.
1841
1842         Fix DumpRenderTree ObjC bug comparing strings.
1843
1844         * DumpRenderTree/mac/ObjCController.m:
1845         (-[ObjCController identityIsEqual::]): Compare strings with string
1846         equality instead of identiy equality.
1847
1848 2007-11-27  Timothy Hatcher  <timothy@apple.com>
1849
1850         Reviewed by Sam.
1851
1852         Reset the authorAndUserStylesEnabled preference
1853         back to YES for each test. Fixes the broken tests.
1854
1855         * DumpRenderTree/mac/DumpRenderTree.mm:
1856         (resetWebViewToConsistentStateBeforeTesting):
1857
1858 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
1859
1860         Reviewed by Adam.
1861
1862         - Drosera now displays the console window, although it cannot currently
1863         process JavaScript.
1864
1865         * Drosera/win/DebuggerClient.cpp: Shows the console window.
1866         (registerConsoleClass): Implemented.
1867         (consoleWndProc): Implemented.
1868         (DebuggerClient::onSize): Implemented.
1869         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
1870         new window.
1871         * Drosera/win/DebuggerClient.h: Added needed method and members for 
1872         creating and maintaining a new window.
1873         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
1874         lines of code to more appropriate places.
1875         (Drosera::handleCommand):
1876         (Drosera::initUI):
1877         (Drosera::onSize):
1878         (Drosera::attach):
1879
1880 2007-11-27  Timothy Hatcher  <timothy@apple.com>
1881
1882         Reviewed by Dave Hyatt.
1883
1884         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
1885         
1886         Add support for disabling author and user styles for testing.
1887
1888         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1889         * DumpRenderTree/LayoutTestController.cpp:
1890         (setAuthorAndUserStylesEnabledCallback):
1891         (LayoutTestController::staticFunctions):
1892         * DumpRenderTree/LayoutTestController.h:
1893         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1894         (LayoutTestController::setAuthorAndUserStylesEnabled):
1895         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1896         (LayoutTestController::setAuthorAndUserStylesEnabled):
1897
1898 2007-11-26  Dan Bernstein  <mitz@apple.com>
1899
1900         - Tiger build fix.
1901
1902         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1903
1904 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
1905
1906         Reviewed by Maciej.
1907
1908         - Implemented displaying variables for Drosera on Win.
1909
1910         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
1911         that retrieve variables to not hold onto the return value since it's
1912         not returned.  Also changed to use the new signatures of the retrieval
1913         functions.
1914         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1915         (DebuggerDocument::platformValueForScopeVariableNamed):
1916         * Drosera/win/Drosera.cpp: Removed a needless TODO.
1917         (droseraWndProc):
1918
1919 2007-11-26  Sam Weinig  <sam@webkit.org>
1920
1921         Cleanup names of painting and repainting functions.
1922
1923         Reviewed by Adam Roben.
1924
1925         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1926         (drawSelectionRect): was drawSelectionRectIntoContext.
1927         (dumpWebViewAsPixelsAndCompareWithExpected):
1928         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1929         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1930         (paintWebView): was drawWebViewIntoContext.
1931         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
1932
1933 2007-11-26  Sam Weinig  <sam@webkit.org>
1934
1935         Reviewed by Dan Bernstein.
1936
1937         - Leopard build fix
1938
1939         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1940
1941 2007-11-26  Sam Weinig  <sam@webkit.org>
1942
1943         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
1944         Use shared PixelDumpSupport for Mac DRT
1945
1946         Reviewed by Adam Roben.
1947
1948         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1949         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
1950         * DumpRenderTree/cg/ImageDiffCG.cpp:
1951         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1952         (drawSelectionRectIntoContext):
1953         (dumpWebViewAsPixelsAndCompareWithExpected):
1954         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1955         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1956         * DumpRenderTree/mac/DumpRenderTree.mm:
1957         (dump):
1958         * DumpRenderTree/mac/ImageDiff.m: Removed.
1959         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
1960         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
1961         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
1962         (setDefaultColorProfileToRGB):
1963         (getBitmapContextFromWebView):
1964         (drawWebViewIntoContext):
1965         (repaintWithVerticalSweep):
1966         (repaintWithHorizontalSweep):
1967         (getSelectionRect):
1968         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
1969
1970 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
1971
1972         Bug 16052: prepare-ChangeLog doesn't report deleted files
1973         <http://bugs.webkit.org/show_bug.cgi?id=16052>
1974
1975         Reviewed by Sam.
1976
1977         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
1978
1979 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
1980
1981         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
1982         <http://bugs.webkit.org/show_bug.cgi?id=15864>
1983
1984         Reviewed by Adam.
1985
1986         Roll functionality of merge-changelog into resolve-ChangeLogs
1987         script.  The script now checks for ChangeLog.rej and
1988         ChangeLog.orig files first.  If it finds them, it uses the
1989         ChangeLog.rej file as a patch (in old contextual diff format) to
1990         apply with --fuzz=3.
1991
1992         * Scripts/merge-changelog: Removed.
1993         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
1994
1995 2007-11-25  Sam Weinig  <sam@webkit.org>
1996
1997         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
1998
1999         Reviewed by Mark Rowe.
2000
2001         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2002         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2003         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2004         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
2005         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
2006
2007 2007-11-25  Sam Weinig  <sam@webkit.org>
2008
2009         Convert DumpRenderTree to ues .xcconfig files.
2010
2011         Reviewed by Mark Rowe.
2012
2013         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2014         * DumpRenderTree/mac/Configurations: Added.
2015         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
2016         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
2017         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
2018
2019 2007-11-25  Sam Weinig  <sam@webkit.org>
2020
2021         Add ForwardingHeaders to wtf for DumpRenderTree.
2022
2023         Reviewed by Mark Rowe.
2024
2025         * DumpRenderTree/DumpRenderTree.h:
2026         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2027         * DumpRenderTree/ForwardingHeaders: Added.
2028         * DumpRenderTree/ForwardingHeaders/wtf: Added.
2029         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
2030         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
2031         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
2032         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
2033         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
2034         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
2035         * DumpRenderTree/LayoutTestController.cpp:
2036         * DumpRenderTree/WorkQueue.cpp:
2037         * DumpRenderTree/mac/DumpRenderTree.mm:
2038         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2039         * DumpRenderTree/mac/JavaScriptThreading.cpp:
2040         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2041         * DumpRenderTree/mac/ObjCController.m:
2042         * DumpRenderTree/mac/UIDelegate.mm:
2043         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2044
2045 2007-11-25  Adam Roben  <aroben@apple.com>
2046
2047         Fix some test failures caused by r28019
2048
2049         Now that stdout is in binary mode, we need to always use printf
2050         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
2051         the output.
2052
2053         Reviewed by Sam.
2054
2055         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
2056         printf.
2057         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2058         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2059         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2060         (UIDelegate::webViewAddMessageToConsole):
2061
2062 2007-11-25  Adam Roben  <aroben@apple.com>
2063
2064         Set the font smoothing preference in DRT
2065
2066         This makes the pixel results on Windows closer to the Mac results.
2067
2068         Reviewed by Mitz.
2069
2070         * DumpRenderTree/win/DumpRenderTree.cpp:
2071         (initializePreferences):
2072
2073 2007-11-25  Adam Roben  <aroben@apple.com>
2074
2075         Port ImageDiff to CG and C++
2076
2077         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
2078         <rdar://5071708>
2079
2080         Reviewed by Sam.
2081
2082         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
2083         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
2084         (main):
2085         (createImageFromStdin):
2086         (compareImages):
2087         (getDifferenceBitmap):
2088         (computePercentageDifferent):
2089         * DumpRenderTree/win/ImageDiff.vcproj: Added.
2090
2091 2007-11-25  Adam Roben  <aroben@apple.com>
2092
2093         Fix image diff link generation on Windows
2094
2095         Reviewed by Sam.
2096
2097         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
2098         to toURL.
2099
2100 2007-11-25  Adam Roben  <aroben@apple.com>
2101
2102         Implement pixel dumping in Windows DRT
2103
2104         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
2105         <rdar://5071708>
2106
2107         Reviewed by Sam.
2108
2109         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
2110         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
2111         Content-Length header.
2112         (getMD5HashStringForBitmap):
2113         (dumpWebViewAsPixelsAndCompareWithExpected):
2114         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
2115         * DumpRenderTree/win/DumpRenderTree.cpp:
2116         (dump): Do a pixel dump if requested.
2117         (main): Parse pixel test options.
2118         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
2119         the cg/ subdirectory to the include path.
2120         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
2121         available in a header or import library, so we have to go through this
2122         LoadLibrary/GetProcAddress dance to use them.
2123         (cryptDLL):
2124         (init):
2125         (update):
2126         (final):
2127         (MD5_Init):
2128         (MD5_Update):
2129         (MD5_Final):
2130         * DumpRenderTree/win/MD5.h: Added.
2131         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
2132         moved up to the top level to share it with Mac eventually.
2133         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
2134         (getBitmapContextFromWebView): Forces the WebView to paint using a
2135         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
2136
2137 2007-11-25  Adam Roben  <aroben@apple.com>
2138
2139         Clean up Windows DRT's option parsing a little bit
2140
2141         Reviewed by Sam.
2142
2143         * DumpRenderTree/win/DumpRenderTree.cpp:
2144         (main): Put non-option arguments into a Vector.
2145
2146 2007-11-25  Adam Roben  <aroben@apple.com>
2147
2148         Make Windows DRT stop changing LF into CRLF
2149
2150         Reviewed by Sam.
2151
2152         * DumpRenderTree/win/DumpRenderTree.cpp:
2153         (main): Put stdout in binary mode.
2154         * Scripts/run-webkit-tests: Remove the CRLF hack.
2155
2156 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
2157
2158         Removed empty directory.
2159
2160         * Scripts/resources: Removed.
2161
2162 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
2163
2164         Fix bisect-builds to work with recent WebKit nightly builds.
2165
2166         Reviewed by Dan.
2167
2168         * Scripts/bisect-builds: Check for the 
2169         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
2170         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
2171         to WebKit.app/Contents/Resources.
2172
2173 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
2174
2175         Reviewed by Maciej.
2176
2177         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
2178         not closed (affects digg.com)
2179
2180         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
2181         one after finishing with a test to avoid having its delayed onload handler firing when
2182         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
2183         but it helps somewhat.
2184
2185 2007-11-22  Mark Rowe  <mrowe@apple.com>
2186
2187         Reviewed by Alp Toker.
2188
2189         Fix build-webkit to propagate make's exit status if it fails.
2190
2191         * Scripts/webkitdirs.pm:
2192
2193 2007-11-22  Dan Bernstein  <mitz@apple.com>
2194
2195         Reviewed by Mark Rowe.
2196
2197         - fix crash when running pixel tests
2198
2199         * DumpRenderTree/mac/DumpRenderTree.mm:
2200         (dumpRenderTree): Parse the command line options before setting up the
2201         environment so that we know if we need to set up the pixel dump
2202         machinery.
2203
2204 2007-11-21  Eric Seidel  <eric@webkit.org>
2205
2206         Speculative build fix for Tiger.
2207
2208         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
2209
2210 2007-11-21  Eric Seidel  <eric@webkit.org>
2211
2212         Reviewed by Tim Hatcher.
2213
2214         Break out more of DumpRenderTree.mm into individual files
2215
2216         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2217         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
2218         (checkedMalloc):
2219         (checkedRealloc):
2220         (makeLargeMallocFailSilently):
2221         * DumpRenderTree/mac/CheckedMalloc.h: Added.
2222         * DumpRenderTree/mac/DumpRenderTree.mm:
2223         (crashHandler):
2224         (dump):
2225         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2226         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
2227         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
2228         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2229         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2230         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
2231         (javaScriptThreads):
2232         (runJavaScriptThread):
2233         (startJavaScriptThreads):
2234         (stopJavaScriptThreads):
2235         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
2236         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
2237         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
2238         (restoreColorSpace):
2239         (setDefaultColorProfileToRGB):
2240         (initializeColorSpaceAndScreeBufferForPixelTests):
2241         (md5HashStringForBitmap):
2242         (dumpWebViewAsPixelsAndCompareWithExpected):
2243
2244 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
2245
2246         Move install-unix-extras to wx directory as it seems only to be used by that 
2247         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
2248         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
2249         have install-unix-extras install into WebKitLibraries as per
2250         convention.
2251         
2252         Reviewed by Mark Rowe.
2253
2254         * Scripts/install-unix-extras: Removed.
2255         * wx/build-wxwebkit:
2256         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
2257
2258 2007-11-21  Eric Seidel  <eric@webkit.org>
2259
2260         Reviewed by Adam.
2261
2262         More refactoring for greater code readability
2263
2264         * DumpRenderTree/mac/DumpRenderTree.mm:
2265         (initializeGlobalsFromCommandLineOptions):
2266         (initializeColorSpaceAndScreeBufferForPixelTests):
2267         (addTestPluginsToPluginSearchPath):
2268         (useLongRunningServerMode):
2269         (runTestingServerLoop):
2270         (prepareConsistentTestingEnvironment):
2271         (dumpRenderTree):
2272         (main):
2273         (dumpFramesAsText):
2274         (dumpBackForwardListForWebView):
2275         (sizeWebViewForCurrentTest):
2276         (methodNameStringForFailedTest):
2277         (dumpBackForwardListForAllWindows):
2278         (dumpWebViewAsPixelsAndCompareWithExpected):
2279         (invalidateAnyPreviousWaitToDumpWatchdog):
2280         (dump):
2281         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2282         * DumpRenderTree/mac/UIDelegate.mm:
2283         (-[UIDelegate webView:createWebViewWithRequest:]):
2284
2285 2007-11-21  Eric Seidel  <eric@webkit.org>
2286
2287         Reviewed by Tim Hatcher.
2288
2289         Abstract more of DRT into static methods
2290
2291         * DumpRenderTree/mac/DumpRenderTree.mm:
2292         (setDefaultsToConsistentValuesForTesting):
2293         (setupSignalHandlers):
2294         (allocateGlobalControllers):
2295         (releaseAndZero):
2296         (releaseGlobalControllers):
2297         (dumpRenderTree):
2298         (shouldLogFrameLoadDelegates):
2299         (createCFURLFromPathOrURL):
2300         (resetWebViewToConsistentStateBeforeTesting):
2301         (runTest):
2302
2303 2007-11-21  Eric Seidel  <eric@webkit.org>
2304
2305         Reviewed by Tim Hatcher.
2306
2307         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
2308
2309         * DumpRenderTree/DumpRenderTree.h:
2310         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2311         * DumpRenderTree/mac/DumpRenderTree.mm:
2312         (dumpRenderTree):
2313         (dump):
2314         (runTest):
2315         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
2316         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
2317         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
2318         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
2319         (-[DumpRenderTreePasteboard declareType:owner:]):
2320         (+[LocalPasteboard alloc]):
2321         (-[LocalPasteboard init]):
2322         (-[LocalPasteboard dealloc]):
2323         (-[LocalPasteboard name]):
2324         (-[LocalPasteboard releaseGlobally]):
2325         (-[LocalPasteboard declareTypes:owner:]):
2326         (-[LocalPasteboard addTypes:owner:]):
2327         (-[LocalPasteboard changeCount]):
2328         (-[LocalPasteboard types]):
2329         (-[LocalPasteboard availableTypeFromArray:]):
2330         (-[LocalPasteboard setData:forType:]):
2331         (-[LocalPasteboard dataForType:]):
2332         (-[LocalPasteboard setPropertyList:forType:]):
2333         (-[LocalPasteboard setString:forType:]):
2334         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
2335         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
2336         (+[DumpRenderTreeWindow allWindows]):
2337         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
2338         (-[DumpRenderTreeWindow dealloc]):
2339         (-[DumpRenderTreeWindow isKeyWindow]):
2340         (-[DumpRenderTreeWindow keyDown:]):
2341
2342 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
2343
2344         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
2345         it indiscriminately copies any headers inside JavaScriptCore,
2346         which includes Tiger ICU headers. 
2347
2348         * wx/build-wxwebkit:
2349         Don't run WebCore/move-js-headers.sh any longer.
2350
2351 2007-11-20  Adam Treat  <treat@kde.org>
2352
2353         Reviewed by David Kilzer.
2354
2355         * Prepend git branch name to $baseProductDir
2356
2357         * Scripts/VCSUtils.pm:
2358         * Scripts/webkitdirs.pm:
2359
2360 2007-11-20  Mark Rowe  <mrowe@apple.com>
2361
2362         Reviewed by Simon Hausmann.
2363
2364         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
2365         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
2366         Have it trigger a "make distclean" rather than "make clean" to ensure that the
2367         built product and generated Makefile's are removed.
2368
2369 2007-11-19  Alp Toker  <alp@atoker.com>
2370
2371         Reviewed by Mark Rowe.
2372
2373         http://bugs.webkit.org/show_bug.cgi?id=16040
2374         [GTK] GtkLauncher should be written in C
2375
2376         Port GtkLauncher to plain C.
2377
2378         Use a more conventional GTK+ coding style.
2379
2380         Use a toolbar instead of menus.
2381
2382         Various signature fixes and cleanups.
2383
2384         Add a license header. Assume all previous modifications were copyright
2385         assigned to Apple Inc. by default.
2386
2387         * GtkLauncher/GtkLauncher.pro:
2388         * GtkLauncher/main.c: Added.
2389         (activate_url_entry_cb):
2390         (update_title):
2391         (link_hover_cb):
2392         (title_change_cb):
2393         (progress_change_cb):
2394         (destroy_cb):
2395         (go_back_cb):
2396         (go_forward_cb):
2397         (create_browser):
2398         (create_statusbar):
2399         (create_toolbar):
2400         (create_window):
2401         (main):
2402         * GtkLauncher/main.cpp: Removed.
2403
2404 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
2405
2406         Build script fixes to ensure they do the right thing for the 
2407         wx port, and update build-wxwebkit to reflect the way the
2408         build scripts now work.
2409
2410         Reviewed by Adam.
2411
2412         * Scripts/build-testkjs:
2413         * Scripts/build-webkit:
2414         * Scripts/run-javascriptcore-tests:
2415         * Scripts/webkitdirs.pm:
2416         * wx/build-wxwebkit:
2417
2418 2007-11-18  Eric Seidel  <eric@webkit.org>
2419
2420         Reviewed by Anders.
2421
2422         Make run-javascriptcore-tests report failures on exit (to support git bisect)
2423
2424         * Scripts/run-javascriptcore-tests:
2425
2426 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
2427
2428         Reviewed by Adam Roben.
2429
2430         Make run-webkit-tests work with Windows debug build.
2431
2432         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
2433         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
2434         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
2435         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
2436         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
2437
2438 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
2439
2440         Add wxWebKit sample and build script, and integrate it with 
2441         build-webkit. Also make build-webkit --clean work for all
2442         ports.
2443
2444         Reviewed by Darin Adler.
2445
2446         * Scripts/build-webkit:
2447         * Scripts/webkitdirs.pm:
2448         * wx: Added.
2449         * wx/browser: Added.
2450         * wx/browser/browser.bkl: Added.
2451         * wx/browser/browser.cpp: Added.
2452         * wx/build-wxwebkit: Added.
2453
2454 2007-11-17  Adam Roben  <aroben@apple.com>
2455
2456         Make it easy to run Safari in the debugger on Windows
2457
2458         I've added a new script, debug-safari, which launches Safari in the
2459         debugger. On OS X it just calls gdb-safari.
2460
2461         Reviewed by Mark Rowe.
2462
2463         * FindSafari/FindSafari.cpp:
2464         (_tmain): Added a /debugger flag, which in combination with
2465         /printSafariLauncher will print a script that launches Safari in the
2466         debugger.
2467         * Scripts/debug-safari: Added.
2468         * Scripts/run-safari: Changed to call runSafari().
2469         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
2470         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
2471         first argument along to FindSafari.
2472         * Scripts/webkitdirs.pm:
2473         (sub runSafari): Added.
2474
2475 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
2476
2477         Reviewed by Adam Roben.
2478
2479         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
2480
2481 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
2482
2483         Reviewed by David Kilzer.
2484
2485         The git config command was renamed to repo-config at some point. This
2486         change tries git config and then git repo-config if the first fails.
2487
2488         * Scripts/prepare-ChangeLog:
2489         (gitConfig):
2490
2491 2007-11-16  Dan Bernstein  <mitz@apple.com>
2492
2493         Reviewed by Darin Adler and Sam Weinig.
2494
2495         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
2496
2497         * DumpRenderTree/win/EventSender.cpp:
2498         (keyDownCallback): For characters that cannot be entered on the active
2499         keyboard layout, send a WM_CHAR message with the character along with
2500         a WM_KEYDOWN message with a virtual key code of 255.
2501
2502 2007-11-16  Mark Rowe  <mrowe@apple.com>
2503
2504         Reviewed by Tim Hatcher.
2505
2506         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
2507
2508         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2509         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2510
2511 2007-11-15  Adam Roben  <aroben@apple.com>
2512
2513         Make run-safari actually work on Windows
2514
2515         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
2516         chdir call.
2517
2518 2007-11-14  Adam Roben  <aroben@apple.com>
2519
2520         Updates to Safari launching now that 3.0.4 is released
2521
2522         Reviewed by Sam.
2523
2524         * FindSafari/FindSafari.cpp:
2525         (getWebViewCLSID): Use version-independent ProgID.
2526         * Scripts/run-safari: Use run-webkit-nightly.cmd.
2527
2528 2007-11-14  Anders Carlsson  <andersca@apple.com>
2529
2530         Reviewed by Adam.
2531
2532         <rdar://problem/5309081>
2533         In DRT, "plugin.logDestroy = true" not working on Windows.
2534         
2535         * DumpRenderTree/win/TestNetscapePlugin/main.c:
2536         (NPP_Destroy):
2537
2538 2007-11-14  Eric Seidel  <eric@webkit.org>
2539
2540         Reviewed by Sam.
2541
2542         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
2543
2544 2007-11-14  Anders Carlsson  <andersca@apple.com>
2545
2546         Reviewed by Adam.
2547
2548         <rdar://problem/5141186>
2549         window.layoutTestController.setWindowIsKey is not implemented in DRT.
2550         
2551         Implement setWindowIsKey.
2552         
2553         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2554         (LayoutTestController::setWindowIsKey):
2555
2556 2007-11-13  Sam Weinig  <sam@webkit.org>
2557
2558         Reviewed by Adam Roben.
2559
2560         Fix for <rdar://problem/5382579>
2561         http/tests/security/cross-frame-access-put.html reports large 
2562         negative numbers for screenLeft and screenTop (Mac reports "0")
2563
2564         * DumpRenderTree/win/UIDelegate.cpp:
2565         (UIDelegate::UIDelegate): Initialize the RECT.
2566         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
2567         (UIDelegate::webViewFrame): ditto.
2568         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
2569
2570 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
2571
2572         Reviewed by Adam.
2573
2574         - Make Drosera show source, source URLs, and function stack on Windows,
2575         and some minor fixes.
2576
2577         * Drosera/DebuggerDocument.cpp: Force source to always update display.
2578         (DebuggerDocument::updateFileSource):
2579         * Drosera/debugger.js: Force source to always update display.
2580         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
2581         menu controls.
2582         (DebuggerClient::resume):
2583         (DebuggerClient::pause):
2584         (DebuggerClient::stepInto):
2585         (DebuggerClient::stepOver):
2586         (DebuggerClient::stepOut):
2587         (DebuggerClient::showConsole):
2588         (DebuggerClient::closeCurrentFile):
2589         * Drosera/win/DebuggerClient.h: Ditto.
2590         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
2591         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
2592         removed two bugs.  1) caller could be in a bad state when asked to
2593         assign into it. 2) BSTRs were not created correctly.
2594         (DebuggerDocument::getPlatformCurrentFunctionStack):
2595         * Drosera/win/Drosera.cpp: Hook up the menu controls.
2596         (droseraWndProc):
2597         (handleCommand):
2598         (Drosera::resume):
2599         (Drosera::pause):
2600         (Drosera::stepInto):
2601         (Drosera::stepOver):
2602         (Drosera::stepOut):
2603         (Drosera::showConsole):
2604         (Drosera::closeCurrentFile):
2605         * Drosera/win/Drosera.h: Hook up the menu controls.
2606         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
2607         functions, added a null check, and fixed another bug where caller could
2608         be in a bad state when asked to assign into it.
2609         (ServerConnection::didLoadMainResourceForDataSource):
2610         (ServerConnection::getCallerFrame):
2611         * Drosera/win/ServerConnection.h: Safety first.
2612
2613 2007-11-13  Dan Bernstein  <mitz@apple.com>
2614
2615         Reviewed by Darin Adler.
2616
2617         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
2618           DumpRenderTree --pixel-tests renders each test twice
2619
2620         * DumpRenderTree/mac/DumpRenderTree.mm:
2621         (dumpRenderTree): Removed the --paint option because the painting code
2622         is always exercised as a result of
2623         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
2624         calling -displayIfNeeded.
2625         (dump): Changed to always grab the image from the window since the view
2626         is always displayed.
2627         (runTest):
2628         (displayWebView):
2629         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
2630         because it always paints.
2631
2632 2007-11-12  Antti Koivisto  <antti@apple.com>
2633
2634         Reviewed by Adele.
2635         
2636         Add support for http media tests
2637
2638         * Scripts/run-webkit-tests:
2639
2640 2007-11-12  Sam Weinig  <sam@webkit.org>
2641
2642         Reviewed by Adam Roben.
2643
2644         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
2645
2646         * DumpRenderTree/win/DumpRenderTree.cpp:
2647         (runTest):
2648         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2649         (LayoutTestController::setPrivateBrowsingEnabled):
2650
2651 2007-11-12  Adam Roben  <aroben@apple.com>
2652
2653         * Scripts/update-webkit-localizable-strings: Changed to only scan the
2654         mac and win subdirectories.
2655
2656 2007-11-11  Adam Roben  <aroben@apple.com>
2657
2658         Fix <rdar://5133816> keepWebHistory is not implemented
2659
2660         Fixes fast/history/clicked-link-is-visited.html.
2661
2662         Reviewed by Darin.
2663
2664         * DumpRenderTree/win/DumpRenderTree.cpp:
2665         (runTest): Clear the optionalSharedHistory.
2666         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2667         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
2668
2669 2007-11-10  Sam Weinig  <sam@webkit.org>
2670
2671         Reviewed by Tim Hatcher.
2672
2673         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
2674         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
2675         is turned on)
2676
2677         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
2678
2679         Added test: http/tests/security/cross-frame-access-private-browsing.html
2680
2681         * DumpRenderTree/LayoutTestController.cpp:
2682         (setPrivateBrowsingEnabledCallback):
2683         (LayoutTestController::staticFunctions):
2684         * DumpRenderTree/LayoutTestController.h:
2685         * DumpRenderTree/mac/DumpRenderTree.mm:
2686         (runTest): Default to private browsing disabled.
2687         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2688         (LayoutTestController::setPrivateBrowsingEnabled):
2689         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2690         (LayoutTestController::setPrivateBrowsingEnabled):
2691
2692 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
2693
2694         Reviewed by Adam.
2695
2696         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
2697         WebCore's!
2698
2699         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
2700         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
2701         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
2702         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
2703         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
2704         * Drosera/win/Drosera.cpp:
2705         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2706
2707 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
2708
2709         Reviewed by Sam.
2710
2711         - Use the new IWebFrame [local] function signature and get the shared
2712         server correctly.
2713
2714         * Drosera/win/DebuggerClient.cpp:
2715         (DebuggerClient::didFinishLoadForFrame):
2716         * Drosera/win/ServerConnection.cpp:
2717         (ServerConnection::attemptToCreateServerConnection):
2718
2719 2007-11-07  Dan Bernstein  <mitz@apple.com>
2720
2721         Reviewed by Darin Adler.
2722
2723         - add an option to run-webkit-tests to ignore pixel test failures where
2724           all pixels differ by no more than a specified threshold
2725
2726         * DumpRenderTree/mac/ImageDiff.m:
2727         (main):
2728         (compareImages):
2729         (computePercentageDifferent):
2730         * Scripts/run-webkit-tests:
2731
2732 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2733
2734         Reviewed by Lars.
2735
2736         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
2737
2738         * DumpRenderTree/qt/DumpRenderTree.cpp:
2739
2740 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2741
2742         Reviewed by Lars.
2743
2744         Reworked the QWebSettings API.
2745         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
2746
2747         * DumpRenderTree/qt/DumpRenderTree.cpp:
2748
2749 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2750
2751         Reviewed by Lars.
2752
2753         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
2754
2755         * DumpRenderTree/qt/jsobjects.cpp:
2756
2757 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2758
2759         Reviewed by Lars Knoll <lars@trolltech.com>.
2760
2761         Add a QWebPage::frameCreated() signal and fix DRT
2762         
2763         The removal of createFrame in QWebPage broke the re-implementation
2764         in DumpRenderTree. Instead emit a frameCreated() signal and
2765         connect to it in DumpRenderTree.
2766         
2767
2768         * DumpRenderTree/qt/DumpRenderTree.cpp:
2769         (WebCore::WebPage::WebPage):
2770         (WebCore::DumpRenderTree::dump):
2771         (WebCore::DumpRenderTree::connectFrame):
2772         * DumpRenderTree/qt/DumpRenderTree.h:
2773
2774 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2775
2776         Reviewed by Lars Knoll <lars@trolltech.com>.
2777
2778         Moved all the event handlers from QWebFrame into QWebPage.
2779         
2780         This cleans up the public API and allows us to remove the
2781         HackWebFrame hack in DumpRenderTree.
2782         
2783
2784         * DumpRenderTree/qt/jsobjects.cpp:
2785         (EventSender::mouseDown):
2786         (EventSender::mouseUp):
2787         (EventSender::mouseMoveTo):
2788
2789 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2790
2791         Reviewed by Mark.
2792
2793         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
2794         to prevent the default implementation from popping up messageboxes.
2795
2796         * DumpRenderTree/qt/DumpRenderTree.cpp:
2797         (WebCore::WebPage::javaScriptConfirm):
2798         (WebCore::WebPage::javaScriptPrompt):
2799
2800 2007-11-06  Eric Seidel  <eric@webkit.org>
2801
2802         * Scripts/build-testkjs: build fix... too many $$
2803
2804 2007-11-06  Eric Seidel  <eric@webkit.org>
2805
2806         Reviewed by Mark Rowe.
2807
2808         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
2809
2810 2007-11-05  Adam Roben  <aroben@apple.com>
2811
2812         Add support on Windows for WEBKIT_TESTFONTS
2813
2814         This environment variable lets you specify where the fonts to be used
2815         by DumpRenderTree reside. The Qt port is already using this, so I'm
2816         just following their lead.
2817
2818         Reviewed by Darin.
2819
2820         * DumpRenderTree/win/DumpRenderTree.cpp:
2821         (exePath): Refactored code out of initialize().
2822         (fontsPath): Returns either $WEBKIT_TESTFONTS or
2823         DumpRenderTree.resources.
2824         (initialize): Use the new fontsPath function.
2825         (main): Use the new exePath function.
2826         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
2827         variable to DRT, like Qt does.
2828
2829 2007-11-05  Mark Rowe  <mrowe@apple.com>
2830
2831         Rubber-stamped by Alp Toker.
2832
2833         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
2834
2835         * GtkLauncher/main.cpp:
2836         (goToURLBarText):
2837         (main):
2838
2839 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
2840
2841         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
2842         <http://bugs.webkit.org/show_bug.cgi?id=15830>
2843
2844         Reviewed by Timothy.
2845
2846         Restrict the range of nightly builds used by the bisect-builds script
2847         based on the version of Safari and the version of Mac OS X being used.
2848
2849         Mac OS X 10.4: Safari 2.0: r11976 or newer
2850         Mac OS X 10.4: Safari 3.0: r19992 or newer
2851
2852         Mac OS X 10.5: Safari 2.0: r19594 or newer
2853         Mac OS X 10.5: Safari 3.0: r25124 or newer
2854
2855         * Scripts/bisect-builds:
2856         (findMacOSXVersion): Added.
2857         (makeNightlyList): Added argument to provide version of Mac OS X.
2858         Restrict range of nightly builds based on Safari and Mac OS X versions.
2859
2860 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
2861
2862         Reviewed by Maciej.
2863
2864         - This patch involves several changes, all of them were noticed that
2865         they were needed by the work being done in WebKit to get Drosera and
2866         WebKit working together on Windows.
2867         - The changes are:
2868         1) Added a debugger console for output messages.
2869         2) Drosera now listens for the WebKit server (before, the server would
2870         have to be running before Drosera was started.)
2871         3) Fixed a bug where the WebView started out as 0x0 pixels.
2872         4) Fixed a bug when there is no scope.
2873         5) Added the HTML, JS, and CSS to the project file to make them easy to
2874         find.
2875         6) Made the ServerConnection functions virtual.
2876
2877         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
2878         for the WebKit server.
2879         (DebuggerClient::DebuggerClient):
2880         (DebuggerClient::~DebuggerClient):
2881         (DebuggerClient::didFinishLoadForFrame):
2882         (DebuggerClient::serverConnected):
2883         (DebuggerClient::attemptToCreateServerConnection):
2884         * Drosera/win/DebuggerClient.h: Ditto.
2885         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
2886         scope.
2887         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2888         (DebuggerDocument::platformValueForScopeVariableNamed):
2889         * Drosera/win/Drosera.cpp:
2890         (_tWinMain): Added a console in debug for output messages.
2891         (Drosera::Drosera): Listen for server.
2892         (Drosera::initUI): The server now Initializes COM.
2893         (Drosera::serverConnected): Part of the listening for the server.
2894         (Drosera::attemptToCreateServerConnection): Ditto.
2895         * Drosera/win/Drosera.h: New interface for listening for the server.
2896         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
2897         files to the VS project.
2898         * Drosera/win/ServerConnection.cpp: Part of listening for the server
2899         connection.
2900         (ServerConnection::ServerConnection):
2901         (ServerConnection::attemptToCreateServerConnection):
2902         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
2903         methods.
2904         (ServerConnection::serverConnected):
2905
2906 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
2907
2908         Reviewed by Maciej.
2909
2910         http://bugs.webkit.org/show_bug.cgi?id=15832
2911         fast/dom/gc-10.html crashes when run alone
2912
2913         Check for !done before using objects that can be already deallocated.
2914
2915         * DumpRenderTree/mac/EditingDelegate.mm:
2916         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
2917         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
2918         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
2919         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
2920         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
2921         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2922         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
2923         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
2924         (-[EditingDelegate webViewDidBeginEditing:]):
2925         (-[EditingDelegate webViewDidChange:]):
2926         (-[EditingDelegate webViewDidEndEditing:]):
2927         (-[EditingDelegate webViewDidChangeTypingStyle:]):
2928         (-[EditingDelegate webViewDidChangeSelection:]):
2929         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2930         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2931         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2932         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2933         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
2934         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
2935         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
2936         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2937         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
2938         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
2939         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2940         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
2941         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
2942         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
2943         (-[FrameLoadDelegate webView:willCloseFrame:]):
2944         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
2945         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
2946         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2947         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2948         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2949         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
2950         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
2951         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
2952         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
2953
2954 2007-11-04  Mark Rowe  <mrowe@apple.com>
2955
2956         Build fix.  Don't use Carbon.h as the prefix header as it triggers
2957         warnings that would otherwise be suppressed due to it being a system header.
2958
2959         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2960
2961 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
2962
2963         Rubber stamped by Adam.
2964         
2965         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
2966
2967         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2968
2969 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2970
2971         Sort files(...); sections of Xcode project files.
2972
2973         Rubber-stamped by Darin.
2974
2975         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
2976         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2977         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2978         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2979
2980 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2981
2982         Script to sort "files(...);" sections in Xcode project.pbxproj files.
2983
2984         Reviewed by Darin.
2985
2986         * Scripts/sort-Xcode-project-file: Added.
2987
2988 2007-11-02  Darin Adler  <darin@apple.com>
2989
2990         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
2991
2992 2007-11-02  Darin Adler  <darin@apple.com>
2993
2994         Reviewed by Maciej.
2995
2996         * Scripts/run-sunspider: Pass the "--base" option through.
2997
2998         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
2999         the real script do that. Default configuration to Release to match run-sunspider
3000         so we don't end up building Debug just to compare results.
3001
3002 2007-11-01  Adam Roben  <aroben@apple.com>
3003
3004         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
3005
3006         Reviewed by Sam.
3007
3008         * Scripts/commit-log-editor: Show all the directories beneath the
3009         source root, instead of just the last one.
3010
3011 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
3012
3013         Reviewed by Adam Roben.
3014
3015         Print out an error message when the Windows build fails
3016         and provide guidance on how to find out what went wrong.
3017
3018         * Scripts/build-webkit:
3019         * Scripts/webkitdirs.pm:
3020
3021 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
3022
3023         Rubber-stamped by Adam Roben.
3024
3025         Rolled out r27326 - debug CRT seems to cause no problems after all.
3026
3027         * DumpRenderTree/win/DumpRenderTree.vcproj:
3028
3029 2007-10-31  Adam Roben  <aroben@apple.com>
3030
3031         Switch the Debug configuration to using the non-debug CRT
3032
3033         This matches WebKit.
3034
3035         Reviewed by Steve.
3036
3037         * DumpRenderTree/win/DumpRenderTree.vcproj:
3038
3039 2007-10-31  Antti Koivisto  <antti@apple.com>
3040
3041         Reviewed by bdash.
3042         
3043         Disable media tests when doing leak checking on Tiger.
3044         They crash in QuickTime (rdar://problem/5537157).
3045
3046         * Scripts/run-webkit-tests:
3047
3048 2007-10-29  Antti Koivisto  <antti@apple.com>
3049
3050         Reviewed by Maciej.
3051         
3052         Build media support by default on OSX only.
3053
3054         * Scripts/build-webkit:
3055
3056 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3057
3058         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
3059         get caught by the pre-commit hooks.
3060
3061 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3062
3063         Reviewed by Adam.
3064
3065         - This is a collection of relatively unrelated changes and cleanups
3066         to Drosera to prepare it for interacting with WebKit.  A lot of these
3067         changes are just correcting mistakes, for example removing included
3068         headers that are no longer needed.
3069
3070         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
3071         this will be needed by the DebuggerClient.
3072         (DebuggerDocument::server):
3073         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
3074         * Drosera/win/DebuggerClient.cpp: 
3075         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
3076         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
3077         (DebuggerClient::createWebViewWithRequest): Added comment about its
3078         purpose. 
3079         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
3080         declarations.
3081         (DebuggerClient::webViewLoaded): Moved.
3082         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
3083         file, since this was the only place it was used.
3084         (cfStringToBSTR):
3085         * Drosera/win/Drosera.h: Cleaned up the includes.
3086         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
3087         * Drosera/win/HelperFunctions.h: Removed.
3088
3089 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3090
3091         Reviewed by Adam.
3092
3093         - Small cleanup in the ServerConnection class.
3094
3095         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
3096         and added an include.
3097         (ServerConnection::currentFrame):
3098         (ServerConnection::getCallerFrame):
3099         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
3100         made a pointer into a COMPtr, and cleaned up the includes.
3101
3102 2007-10-29  Timothy Hatcher  <timothy@apple.com>
3103
3104         Reviewed by John Sullivan.
3105         
3106         - Place the Localizable.strings file in mac or win directories
3107           if that location exists.
3108         - Also look for UI_STRING in .c files.
3109
3110         * Scripts/extract-localizable-strings:
3111
3112 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3113
3114         Reviewed by Adam.
3115
3116         - Set the eol-style to native and made all the line endings the same
3117         so that I avoid messy diffs that show eol changes.
3118
3119         * Drosera/win/ServerConnection.cpp:
3120         (ServerConnection::didParseSource):
3121         (ServerConnection::didEnterCallFrame):
3122         (ServerConnection::willExecuteStatement):
3123         (ServerConnection::willLeaveCallFrame):
3124         (ServerConnection::exceptionWasRaised):
3125
3126 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3127
3128         Reviewed by Adam.
3129
3130         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
3131         functionality that could not have existed previously without the new
3132         interfaces.
3133         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
3134         from a BSTR to a JSValueRef.
3135         (DebuggerDocument::platformEvaluateScript): Implemented.
3136         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
3137         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3138         Implemented.
3139         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
3140         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
3141         * Drosera/win/ServerConnection.cpp: Added a helper function.
3142         (ServerConnection::getCallerFrame):
3143         * Drosera/win/ServerConnection.h: Added a helper function.
3144
3145 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
3146
3147         updated reviewers for my previous changelog.
3148
3149 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
3150         Reviewed by Maciej and Adam and Geoff.
3151
3152         - Minor mac-side improvements including moving a function to a more
3153         appropriate location, fixing a warning, and correctly checking
3154         exceptions.
3155
3156         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
3157         (DebuggerDocument::willExecuteStatement):
3158         (DebuggerDocument::didEnterCallFrame):
3159         (DebuggerDocument::willLeaveCallFrame):
3160         (DebuggerDocument::windowScriptObjectAvailable):
3161         (DebuggerDocument::callFunctionOnObject):
3162         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
3163         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
3164         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
3165         because it doesn't require the ServerConnection at all.
3166         (NSStringCreateWithJSStringRef): Made an argument const.
3167         (JSValueRefCreateWithNSString): Made an argument const.
3168         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
3169         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3170         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
3171         * Drosera/mac/ServerConnection.mm: Ditto.
3172         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
3173
3174 2007-10-29  Sam Weinig  <sam@webkit.org>
3175
3176         Reviewed by Adam Roben.
3177
3178         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
3179
3180         * DumpRenderTree/LayoutTestController.cpp:
3181         (LayoutTestController::LayoutTestController):
3182         (getGlobalFlagCallback):
3183         (setGlobalFlagCallback):
3184         (LayoutTestController::getJSClass):
3185         (LayoutTestController::staticValues):
3186         * DumpRenderTree/LayoutTestController.h:
3187         (LayoutTestController::globalFlag):
3188         (LayoutTestController::setGlobalFlag):
3189
3190 2007-10-29  Darin Adler  <darin@apple.com>
3191
3192         Reviewed by Maciej.
3193
3194         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
3195         resolution instead of its default.
3196
3197 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
3198
3199         Fixed showStatus() to print status for successfully resolved conflicts when using git.
3200
3201         Reviewed by Mark Rowe.
3202
3203         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
3204         was successfully resolved, but this would not show any status because the change had
3205         already been cached in the index using "git add".  The solution is to add an optional
3206         second argument to showStatus() which adds the "--cached" switch to the command.
3207
3208         * Scripts/resolve-ChangeLogs:
3209         (showStatus):
3210
3211 2007-10-28  Eric Seidel  <eric@webkit.org>
3212
3213         Reviewed by Maciej and Geoff, in unison.
3214
3215         * Scripts/run-webkit-tests: remove broken --svg option
3216
3217 2007-10-28  Darin Adler  <darin@apple.com>
3218
3219         Reviewed by Adam.
3220
3221         * Scripts/run-sunspider: Default to "Release" configuration rather than
3222         defaulting to the last configuration used as other scripts do. This can
3223         still be overriden on the command line with "--debug" if there's some
3224         reason to do so. Also fix a typo.
3225
3226         * Scripts/sunspider-compare-results: Fix a typo.
3227
3228 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
3229
3230         Reviewed by Adam.
3231
3232         - Implemented the WebScriptDebugListener functions now that the
3233         WebScriptDebugServer exists
3234
3235         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
3236         functions.
3237         (ServerConnection::currentFrame):
3238         (ServerConnection::didLoadMainResourceForDataSource):
3239         (ServerConnection::didParseSource):
3240         (ServerConnection::failedToParseSource):
3241         (ServerConnection::didEnterCallFrame):
3242         (ServerConnection::willExecuteStatement):
3243         (ServerConnection::willLeaveCallFrame):
3244         (ServerConnection::exceptionWasRaised):
3245         * Drosera/win/ServerConnection.h: Removed unused arguments from the
3246         members arguments list.
3247
3248 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
3249
3250         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
3251         <http://bugs.webkit.org/show_bug.cgi?id=15600>
3252
3253         Reviewed by Darin.
3254
3255         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
3256         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
3257         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
3258         file.  Note that it may also be used as a stand-alone script.
3259
3260         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
3261         * Scripts/resolve-ChangeLogs: Added.
3262         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
3263
3264 2007-10-26  Mark Rowe  <mrowe@apple.com>
3265
3266         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
3267         to the Qt port on the assumption that it was an implementation of the cross-platform
3268         LayoutTestController class.  It is not, so it did not need to be changed.
3269
3270         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
3271
3272 2007-10-25  Mark Rowe  <mrowe@apple.com>
3273
3274         Reviewed by Maciej.
3275
3276         Fix builds with code coverage enabled.
3277
3278         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
3279
3280 2007-10-25  Darin Adler  <darin@apple.com>
3281
3282         Reviewed by Mark Rowe.
3283
3284         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
3285         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
3286
3287 2007-10-25  Stephanie  <slewis@apple.com>
3288
3289         build Fix
3290
3291         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3292
3293 2007-10-25  Stephanie  <slewis@apple.com>
3294
3295         Reviewed by Mark Rowe, Adam Roben.
3296
3297         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
3298
3299         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
3300
3301 2007-10-25  Alice Liu  <alice.liu@apple.com>
3302
3303         Reviewed by Adam.
3304
3305         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
3306
3307         Moving destructor into platform-specific files
3308         * DumpRenderTree/LayoutTestController.cpp:
3309         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3310         (LayoutTestController::~LayoutTestController):
3311         * DumpRenderTree/qt/jsobjects.cpp:
3312         (LayoutTestController::~LayoutTestController):
3313
3314         LayoutTestController wasn't being destroyed
3315         * DumpRenderTree/win/DumpRenderTree.cpp:
3316         (runTest):
3317
3318         Added declspec
3319         * DumpRenderTree/win/EditingDelegate.h:
3320
3321         Reset certain values on the webview (or related delegate) that might 
3322         have changed while running a test
3323         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3324         (LayoutTestController::~LayoutTestController):
3325
3326 2007-10-25  Adam Roben  <aroben@apple.com>
3327
3328         Make sunspider-compare-results work with relative paths
3329
3330         Reviewed by Sam.
3331
3332         * Scripts/sunspider-compare-results: Convert arguments to absolute
3333         paths before we chdir.
3334
3335 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
3336
3337         Reviewed by Sam.
3338
3339         - Implemented server calls now the WebScriptDebugServer exists.
3340         - Also removed no longer needed call to initialize CG.
3341
3342         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
3343         automatically now.
3344         (_tWinMain):
3345         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
3346         (ServerConnection::ServerConnection):
3347         (ServerConnection::~ServerConnection):
3348         (ServerConnection::pause):
3349         (ServerConnection::resume):
3350         (ServerConnection::stepInto):
3351         (ServerConnection::applicationTerminating):
3352         (ServerConnection::serverConnectionDidDie):
3353         * Drosera/win/ServerConnection.h: Now uses the COM class.
3354
3355 2007-10-24  George Staikos  <staikos@kde.org>
3356
3357         Unbreak Qt build.
3358
3359         * Scripts/build-webkit:
3360
3361 2007-10-24  Adam Roben  <aroben@apple.com>
3362
3363         Remove now-unnecessary call to InitializeCoreGraphics
3364
3365         WebKit takes care of this now.
3366
3367         Reviewed by Ada.
3368
3369         * DumpRenderTree/win/DumpRenderTree.cpp:
3370         (initialize):
3371
3372 2007-10-24  Adam Roben  <aroben@apple.com>
3373
3374         Use WebTextRenderer in DRT
3375
3376         Reviewed by Ada.
3377
3378         * DumpRenderTree/win/DumpRenderTree.cpp:
3379         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
3380
3381 2007-10-24  Sven Herzberg  <sven@imendio.com>
3382
3383         Reviewed by Mark Rowe.
3384
3385         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
3386         Bug 15614: [GTK] qmake based backends don't build on OS X
3387
3388         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
3389         GTK backend on a Mac
3390         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
3391         isDarwin() to make it reusable in other places (like the workaround-
3392         for-prebuilt-qmake in build-webkit)
3393
3394 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
3395
3396         Refurbish update-webkit script.
3397
3398         Reviewed by Adam.
3399
3400         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
3401         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
3402         multi-argument version of system() for flexibility and security.  Check for existence
3403         of Internal directory using -d test instead of -x.
3404
3405 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
3406
3407         Minor clean-up of prepare-ChangeLog script.
3408
3409         Reviewed by Adam.
3410
3411         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
3412         of a string.  Use multi-argument versions of open() and system() for flexibility and
3413         security.
3414
3415 2007-10-24  Alice Liu  <alice.liu@apple.com>
3416
3417         Reviewed by Oliver.
3418
3419         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
3420
3421         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
3422         replay the saved events when we're still processing the mousedown that starts the drag
3423         * DumpRenderTree/win/EventSender.cpp:
3424         (doMouseMove):
3425         * DumpRenderTree/win/UIDelegate.cpp:
3426         (UIDelegate::doDragDrop):
3427
3428 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
3429
3430         Reviewed by Sam, Steve and Darin.
3431
3432         - Stubbed out the WebScriptDebugListener functionality in the Server
3433         Connection class to prepare it for receiving those callbacks.
3434         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
3435         and the ServerConnection to not need to be initialized with a server
3436         name, since that is not the way we connect to the WebKit server. 
3437
3438         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
3439         no exception.  Now it only loggs when there is an exception
3440         (DebuggerDocument::willExecuteStatement):
3441         (DebuggerDocument::didEnterCallFrame):
3442         (DebuggerDocument::willLeaveCallFrame):
3443         (DebuggerDocument::windowScriptObjectAvailable):
3444         (DebuggerDocument::callFunctionOnObject):
3445         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
3446         to be instantiated with a server's name.
3447         (DebuggerClient::DebuggerClient):
3448         (DebuggerClient::didFinishLoadForFrame):
3449         * Drosera/win/DebuggerClient.h: Removed unsued variable.
3450         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
3451         a server name.
3452         (Drosera::init):
3453         (Drosera::initServer):
3454         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
3455         instantiated with a server's name.
3456         * Drosera/win/ServerConnection.cpp: 
3457         (ServerConnection::ServerConnection): No longer needs a server name
3458         (ServerConnection::~ServerConnection): Only release the global context
3459         if there is one.
3460         (ServerConnection::serverConnectionDidDie): Stub for
3461         IWebScriptDebugListener
3462         (ServerConnection::QueryInterface): ditto
3463         (ServerConnection::AddRef): ditto
3464         (ServerConnection::Release): ditto
3465         (ServerConnection::didLoadMainResourceForDataSource): ditto
3466         (ServerConnection::didParseSource): ditto
3467         (ServerConnection::failedToParseSource): ditto
3468         (ServerConnection::didEnterCallFrame): ditto
3469         (ServerConnection::willExecuteStatement): ditto
3470         (ServerConnection::willLeaveCallFrame): ditto
3471         (ServerConnection::exceptionWasRaised): ditto
3472         * Drosera/win/ServerConnection.h: Stubbed out the
3473         IWebScriptDebugListener functions, and this class no longer needs to be
3474         instantiated with a server name.
3475
3476 2007-10-24  Lars Knoll  <lars@trolltech.com>
3477
3478         Reviewed by Simon.
3479
3480         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
3481
3482         * DumpRenderTree/qt/jsobjects.h:
3483
3484 2007-10-24  Lars Knoll  <lars@trolltech.com>
3485
3486         Reviewed by Simon.
3487
3488         add another command.
3489
3490         * DumpRenderTree/qt/jsobjects.cpp:
3491         (TextInputController::doCommand):
3492
3493 2007-10-24  Lars Knoll  <lars@trolltech.com>
3494
3495         Reviewed by Simon.
3496
3497         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
3498
3499         * DumpRenderTree/qt/jsobjects.cpp:
3500         (EventSender::keyDown):
3501         * DumpRenderTree/qt/jsobjects.h:
3502
3503 2007-10-24  Lars Knoll  <lars@trolltech.com>
3504
3505         Reviewed by Simon.
3506
3507         implement eventSender.keyDown().
3508
3509         * DumpRenderTree/qt/jsobjects.cpp:
3510         (EventSender::keyDown):
3511
3512 2007-10-24  Lars Knoll  <lars@trolltech.com>
3513
3514         Reviewed by Simon.
3515
3516         some smaller fixes to the editing support in DRT. Makes another few tests pass.
3517
3518         * DumpRenderTree/qt/DumpRenderTree.cpp:
3519         (WebCore::DumpRenderTree::DumpRenderTree):
3520         (WebCore::DumpRenderTree::initJSObjects):
3521         * DumpRenderTree/qt/jsobjects.cpp:
3522         (TextInputController::doCommand):
3523
3524 2007-10-24  Lars Knoll  <lars@trolltech.com>
3525
3526         Reviewed by Simon.
3527
3528         first bit of implementation for the textinputcontroller.
3529
3530         * DumpRenderTree/qt/DumpRenderTree.cpp:
3531         (WebCore::DumpRenderTree::DumpRenderTree):
3532         * DumpRenderTree/qt/DumpRenderTree.h:
3533         * DumpRenderTree/qt/jsobjects.cpp:
3534         (TextInputController::TextInputController):
3535         (TextInputController::doCommand):
3536         * DumpRenderTree/qt/jsobjects.h:
3537
3538 2007-10-24  Lars Knoll  <lars@trolltech.com>
3539
3540         Reviewed by Simon.
3541
3542         make the man webpage believe it has focus, so the editing tests work correctly.
3543
3544         * DumpRenderTree/qt/DumpRenderTree.cpp:
3545         (WebCore::DumpRenderTree::DumpRenderTree):
3546
3547 2007-10-24  Lars Knoll  <lars@trolltech.com>
3548
3549         Reviewed by Simon.
3550
3551         implement layoutTestController.dumpEditingCallbacks() correctly.
3552
3553         * DumpRenderTree/qt/DumpRenderTree.cpp:
3554         (WebCore::DumpRenderTree::DumpRenderTree):
3555         * DumpRenderTree/qt/jsobjects.cpp:
3556         (LayoutTestController::reset):
3557         (LayoutTestController::dumpEditingCallbacks):
3558
3559 2007-10-24  Lars Knoll  <lars@trolltech.com>
3560
3561         Reviewed by Simon.
3562
3563         Implement support for testing editing.
3564
3565         * DumpRenderTree/qt/DumpRenderTree.cpp:
3566         (WebCore::DumpRenderTree::DumpRenderTree):
3567
3568 2007-10-23  Sam Weinig  <sam@webkit.org>
3569
3570         Check for null BSTR that can be passed to the UIDelegate methods
3571         from javascript null and undefined.  Fixes a failing test case on
3572         Windows (fast/dom/Window/alert-undefined.html)
3573
3574         Reviewed by Eric Seidel.
3575
3576         * DumpRenderTree/win/UIDelegate.cpp:
3577         (UIDelegate::runJavaScriptAlertPanelWithMessage):
3578         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
3579         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
3580         (UIDelegate::webViewAddMessageToConsole):
3581
3582 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
3583
3584         Reviewed by Darin.
3585         
3586         Don't print a massive pile of setenvs from tools that automatically build testkjs.
3587
3588         * Scripts/build-testkjs:
3589
3590 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
3591
3592         Reviewed by Darin.
3593
3594         - add wrapper that finds the right copy of testkjs
3595         
3596         * Scripts/sunspider-compare-results: Added.
3597
3598 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
3599
3600         Reviewed by Sam.
3601
3602         - After talking with Steve I now see that the WebKit server must be
3603         running for DCOM to create the distributed objects, which makes sense
3604         and currently WebKit only allows one instance to be running at a time
3605         which avoids accidentally connecting to the wrong server
3606         - In light of this I have removed the code for the attach box and
3607         NotificationServer and known server names, since they are all extranious
3608         now.
3609
3610         * Drosera/win/Drosera.cpp: Removed notification classes and known server
3611         names.
3612         (_tWinMain): Uses init instead of initUI.
3613         (droseraWndProc): No longer creats an attach dialog box.
3614         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
3615         it's not manditory to call init before doing COM stuff.
3616         (Drosera::init): calls initUI and will call attach when the
3617         functionality exists. 
3618         (Drosera::initUI): Has changed very little.
3619         (Drosera::attach): Changed the signature to reflect that we no longer
3620         need the dictionary of known server names.
3621         * Drosera/win/Drosera.h: Removed notification classes and known server
3622         names.  Also renamed and moved some functions.
3623         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
3624         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
3625         headers to the resources folder. 
3626         * Drosera/win/resource.h: Removed the Attach box.
3627
3628 2007-10-22  Adam Roben  <aroben@apple.com>
3629
3630         Windows build fix
3631
3632         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
3633
3634 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
3635
3636         - Removed a leak that was fixed.
3637
3638         * Scripts/run-webkit-tests:
3639
3640 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3641
3642         Reviewed by Darin.
3643
3644         - Changed the Client so that the DebuggerDocument now own the
3645         ServerConnection.  This simplifies ownership and cleanup. 
3646
3647         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
3648         ServerConnection.
3649         (DebuggerClient::initWithServerName):
3650         (DebuggerClient::didFinishLoadForFrame):
3651         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
3652         ServerConnection.
3653         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
3654         until after we have a server which we are attached to.
3655         (Drosera::initUI):
3656         (Drosera::attach):
3657         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
3658