61ffce1948dcb4294bfeb6e48318135556198a1c
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-10-22  Sam Weinig  <sam@webkit.org>
2
3         Reviewed by Anders Carlsson.
4
5         WebKit2 needs to pass the current event modifier flags when requesting a new window
6         https://bugs.webkit.org/show_bug.cgi?id=48140
7
8         * MiniBrowser/mac/BrowserWindowController.m:
9         (createNewPage):
10         * WebKitTestRunner/TestController.cpp:
11         (WTR::createOtherPage):
12         Update for new signature for the WKPageCreateNewPageCallback.
13
14 2010-10-22  Eric Seidel  <eric@webkit.org>
15
16         Unreviewed.  Just adding a test case.
17
18         The style-queue was not recognizing new patches.  It turns
19         out I had fixed this in an earlier change, but just not
20         deployed to queues.webkit.org.  As part of investigating why it
21         was broken, I wrote a test for my previous change which I'm now landing.
22
23         * QueueStatusServer/model/queues_unittest.py:
24
25 2010-10-22  Eric Seidel  <eric@webkit.org>
26
27         Reviewed by Adam Barth.
28
29         EWS does not need to process obsolete patches
30         https://bugs.webkit.org/show_bug.cgi?id=48093
31
32         This was an easy change, but to test it I had to pipe
33         real Attachment objects into the queue testing system.
34         Doing so revealed a whole bunch of bugs in our unit tests,
35         which I fixed as part of this patch.
36
37         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
38          - This is the actual code change.  This will not reduce the
39            backlog in the EWS queues much, but it will make rejections
40            much quicker for obsolete patches or closed bugs.
41         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
42          - Test my new code.
43          - Used a real attachment object and got rid of MockPatch
44          - Shared code between the mac-ews and cr-mac-ews tests.
45         * Scripts/webkitpy/tool/commands/queues_unittest.py:
46          - Can't use MockPatch anymore.
47          - Removing MockPatch found more bugs here!
48         * Scripts/webkitpy/tool/commands/queuestest.py:
49         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
50         * Scripts/webkitpy/tool/mocktool.py:
51          - MockBugzilla should not be a "Mock" object.  Right now tool.bugs()
52            is allowed, but wrong.  Making it not a Mock will make tool.bugs() correctly fail.
53
54 2010-10-22  Sheriff Bot  <webkit.review.bot@gmail.com>
55
56         Unreviewed, rolling out r70301.
57         http://trac.webkit.org/changeset/70301
58         https://bugs.webkit.org/show_bug.cgi?id=48126
59
60         "Lang attribute layout tests failing" (Requested by satish on
61         #webkit).
62
63         * DumpRenderTree/LayoutTestController.cpp:
64         (setMockSpeechInputResultCallback):
65         * DumpRenderTree/LayoutTestController.h:
66         * DumpRenderTree/chromium/LayoutTestController.cpp:
67         (LayoutTestController::setMockSpeechInputResult):
68         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
69         (LayoutTestController::setMockSpeechInputResult):
70         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
71         (LayoutTestController::setMockSpeechInputResult):
72         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
73         (LayoutTestController::setMockSpeechInputResult):
74         * DumpRenderTree/qt/LayoutTestControllerQt.h:
75         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
76         (LayoutTestController::setMockSpeechInputResult):
77         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
78         (LayoutTestController::setMockSpeechInputResult):
79
80 2010-10-22  Leandro Gracia Gil  <leandrogracia@google.com>
81
82         Reviewed by Jeremy Orlow.
83
84         Added a second parameter to setMockSpeechInputResult for
85         the language used in speech input.
86         https://bugs.webkit.org/show_bug.cgi?id=47089
87
88         * DumpRenderTree/LayoutTestController.cpp:
89         (setMockSpeechInputResultCallback):
90         * DumpRenderTree/LayoutTestController.h:
91         * DumpRenderTree/chromium/LayoutTestController.cpp:
92         (LayoutTestController::setMockSpeechInputResult):
93         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
94         (LayoutTestController::setMockSpeechInputResult):
95         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
96         (LayoutTestController::setMockSpeechInputResult):
97         * DumpRenderTree/qt/LayoutTestControllerQt.h:
98         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
99         (LayoutTestController::setMockSpeechInputResult):
100         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
101         (LayoutTestController::setMockSpeechInputResult):
102         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
103         (LayoutTestController::setMockSpeechInputResult):
104
105 2010-10-21  MORITA Hajime  <morrita@google.com>
106
107         Reviewed by Kent Tamura.
108
109         [Win][DRT] should have LayoutTestController.hasSpellingMarker()
110         https://bugs.webkit.org/show_bug.cgi?id=47885
111
112         - Implemented LayoutTestController.hasSpellingMarker(),
113         - Added fake spellcheck implementation.
114
115         * DumpRenderTree/win/DumpRenderTree.cpp:
116         (main):
117         * DumpRenderTree/win/EditingDelegate.cpp:
118         (indexOfFirstWordCharacter):
119         (wordLength):
120         (EditingDelegate::checkSpellingOfString):
121         * DumpRenderTree/win/EditingDelegate.h:
122         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
123         (LayoutTestController::hasSpellingMarker):
124
125 2010-10-21  Mihai Parparita  <mihaip@chromium.org>
126
127         Unreviewed. Re-enable test that was mistakenly disabled by r67974.
128
129         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
130
131 2010-10-21  Mihai Parparita  <mihaip@chromium.org>
132
133         Unreviewed fix for rebaseline-chromium-webkit-tests.
134
135         Port.diff_image no longer has a tolerance parameter. Also, use
136         get_option('tolerance') which is safer if the options object doesn't
137         define a tolerance attribute (it doesn't for the one used in
138         rebaseline_chromium_webkit_tests).
139
140         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
141         * Scripts/webkitpy/layout_tests/port/webkit.py:
142         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
143
144 2010-10-21  Mihai Parparita  <mihaip@chromium.org>
145
146         Reviewed by Ojan Vafai.
147
148         Add support for --tolerance in NRWT
149         https://bugs.webkit.org/show_bug.cgi?id=47959
150         
151         Add support for the --tolerance flag in NRWT. The Port.diff_image
152         signature shouldn't need a tolerance parameter (it's not set per test),
153         just have ports that use it (currently only WebKitPort) read it from 
154         the options object.
155
156         * Scripts/webkitpy/layout_tests/port/chromium.py:
157         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
158         * Scripts/webkitpy/layout_tests/port/test.py:
159         * Scripts/webkitpy/layout_tests/port/webkit.py:
160         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
161         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
162
163 2010-10-21  Eric Seidel  <eric@webkit.org>
164
165         Reviewed by Adam Barth.
166
167         Add --suggest-reviewers option to upload to auto-suggest reviewers for your patch
168         https://bugs.webkit.org/show_bug.cgi?id=48088
169
170         This is a first-pass.  Works, but we'll eventually
171         turn this on by default, refine the suggestion algorithm
172         and possibly move it to a different place in the upload step order.
173
174         * Scripts/webkitpy/common/checkout/api.py:
175         * Scripts/webkitpy/tool/commands/download_unittest.py:
176         * Scripts/webkitpy/tool/commands/upload.py:
177         * Scripts/webkitpy/tool/commands/upload_unittest.py:
178         * Scripts/webkitpy/tool/mocktool.py:
179         * Scripts/webkitpy/tool/steps/__init__.py:
180         * Scripts/webkitpy/tool/steps/options.py:
181
182 2010-10-21  Mario Sanchez Prada  <msanchez@igalia.com>
183
184         Reviewed by Chris Fleizach.
185
186         [GTK] Segfault while testing accessibility/iframe-bastardization.html
187         https://bugs.webkit.org/show_bug.cgi?id=30123
188
189         Check m_element before actually using it to get the parent.
190
191         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
192         (AccessibilityUIElement::parentElement): Add an extra check to
193         make sure m_element points to a valid value before actually using
194         it to get the parent. Also, assert ATK_IS_OBJECT(m_element).
195
196 2010-10-21  Anders Carlsson  <andersca@apple.com>
197
198         Reviewed by Adam Roben.
199
200         Crash evaluating JavaScript string that throws an exception
201         https://bugs.webkit.org/show_bug.cgi?id=48092
202         <rdar://problem/8487657>
203
204         Add a test that evaluates a JavaScript string that throws an exception and check that 
205         the callback is called.
206
207         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
208         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp: Added.
209         (TestWebKitAPI::didRunJavaScript):
210         (TestWebKitAPI::WebKit2_EvaluateJavaScript):
211         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
212
213 2010-10-21  Adam Roben  <aroben@apple.com>
214
215         Test that the plugin's HWND is invalidated when NPN_InvalidateRect is
216         called
217
218         Test for <http://webkit.org/b/48086> <rdar://problem/8482944>
219         Silverlight doesn't repaint in WebKit2
220
221         Reviewed by Anders Carlsson.
222
223         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
224         (PluginTest::NPN_InvalidateRect): Added. Calls through to the browser.
225         (executeScript): Added. Asks the browser to evaluate the script.
226
227         (PluginTest::waitUntilDone):
228         (PluginTest::notifyDone):
229         Added. Calls through to layoutTestController.
230
231         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added
232         * NPN_InvalidateRect and waitUntilDone/notifyDone.
233
234         * DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp: Added.
235         (TemporaryWindowMover::moveSucceeded):
236         (TemporaryWindowMover::TemporaryWindowMover):
237         (TemporaryWindowMover::~TemporaryWindowMover):
238         This class moves a window on-screen and shows it, then moves it back and hides it.
239
240         (NPNInvalidateRectInvalidatesWindow::NPNInvalidateRectInvalidatesWindow):
241         Initialize our members.
242         (NPNInvalidateRectInvalidatesWindow::~NPNInvalidateRectInvalidatesWindow):
243         Delete our window mover if it hasn't been deleted already.
244         (NPNInvalidateRectInvalidatesWindow::NPP_SetWindow): Subclass the
245         plugin HWND and move the test harness window on screen.
246         (NPNInvalidateRectInvalidatesWindow::wndProc): Call through to onPaint
247         when we get a WM_PAINT message.
248         (NPNInvalidateRectInvalidatesWindow::onPaint): Do the test and tell
249         LayoutTestController we're done.
250         (NPNInvalidateRectInvalidatesWindow::testInvalidateRect): Validate
251         ourselves, invalidate our lower-right quadrant via NPN_InvalidateRect,
252         then check that our HWND's invalid region is the rect that we
253         invalidated.
254
255         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
256         * Added NPNInvalidateRectInvalidatesWindow.
257
258 2010-10-21  Daniel Bates  <dbates@rim.com>
259
260         Add Git-support to do-file-rename
261         https://bugs.webkit.org/show_bug.cgi?id=48015
262
263         Fix tools. Export function scmMoveOrRenameFile so that it can be called from
264         do-file-rename and do-webcore-rename. I inadvertently left this out of the patch.
265
266         * Scripts/VCSUtils.pm:
267
268 2010-10-21  Eric Seidel  <eric@webkit.org>
269
270         Reviewed by Adam Barth.
271
272         mac-ews is not properly releasing patches
273         https://bugs.webkit.org/show_bug.cgi?id=48076
274
275         mac-ews overrides process_work_item, so it was not calling
276         release_work_item like the default process_work_item would.
277         To fix this I made all the status-reporting methods just
278         release the patch.  I expect we'll iterate on this design further.
279
280         * Scripts/webkitpy/common/net/statusserver.py:
281         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
282         * Scripts/webkitpy/tool/commands/queues.py:
283         * Scripts/webkitpy/tool/commands/queues_unittest.py:
284
285 2010-10-18  Martin Robinson  <mrobinson@igalia.com>
286
287         Reviewed by Gustavo Noronha Silva.
288
289         [GTK] mathml flaky tests after adding SystemFonts to the theme
290         https://bugs.webkit.org/show_bug.cgi?id=47727
291
292         The Fontconfig setup in the GTK+ now specifically checks for and
293         loads the STIX fonts for MathML tests.
294
295         * DumpRenderTree/gtk/DumpRenderTree.cpp:
296         (initializeFonts): Add hooks for loading the STIX fonts specifically.
297
298 2010-10-20  Adam Roben  <aroben@apple.com>
299
300         Test that the UI client gets notified when WKView receives a WM_CLOSE
301         message
302
303         Test for <http://webkit.org/b/48044> <rdar://problem/8488446> Pressing
304         Ctrl+W when viewing a full-page PDF destroys the WKView but doesn't
305         close its parent window
306
307         Reviewed by Jon Honeycutt.
308
309         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp: Added.
310         (TestWebKitAPI::close): Record that this function was called.
311         (TestWebKitAPI::WebKit2_WMCloseCallsUIClientClose): Create a WKView,
312         send it a WM_CLOSE message, and test that the UI client's close
313         callback got called. Note that this will hang if the bug is
314         reintroduced; <http://webkit.org/b/48043> covers making TestWebKitAPI
315         able to handle hangs.
316
317         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added the new test.
318
319 2010-10-20  Adam Roben  <aroben@apple.com>
320
321         Make prepare-ChangeLog much faster when using git
322
323         This change also seems to make it detect renames better in some cases.
324
325         Fixes <http://webkit.org/b/48040> prepare-ChangeLog is slow when using
326         git
327
328         Reviewed by David Kilzer.
329
330         * Scripts/prepare-ChangeLog:
331         (statusCommand):
332         (createPatchCommand):
333         Use "-M -C" instead of "-C -C -M" to tell git-diff to detect renames
334         and copies. The two "-C"s were making it read many more files than were
335         necessary.
336
337 2010-10-21  Sam Weinig  <sam@webkit.org>
338
339         Reviewed by Adam Roben.
340
341         Null frame passed when running alert from UserScript run at document start
342         <rdar://problem/8573809>
343         https://bugs.webkit.org/show_bug.cgi?id=48036
344
345         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
346         * TestWebKitAPI/InjectedBundleController.cpp:
347         (TestWebKitAPI::InjectedBundleController::didReceiveMessage):
348         (TestWebKitAPI::InjectedBundleController::initializeTestNamed):
349         * TestWebKitAPI/InjectedBundleController.h:
350         * TestWebKitAPI/InjectedBundleTest.h:
351         (TestWebKitAPI::InjectedBundleTest::initialize):
352         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
353         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp: Added.
354         (TestWebKitAPI::runJavaScriptAlert):
355         (TestWebKitAPI::TEST):
356         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp: Added.
357         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::DocumentStartUserScriptAlertCrashTest):
358         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
359         Add test for invoking an alert during a UserScript run at document start.
360
361 2010-10-21  Andreas Kling  <kling@webkit.org>
362
363         Reviewed by Adam Roben.
364
365         TestNetscapePlugIn: Actually call NPP_SetWindow on Unix
366
367         We were just returning NPERR_NO_ERROR previously.
368
369         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
370         (webkit_test_plugin_set_window):
371
372 2010-10-21  David Kilzer  <ddkilzer@apple.com>
373
374         <http://webkit.org/b/48051> Move macros from DumpRenderTreeMac.h to config.h
375
376         Reviewed by Adam Roben.
377
378         * DumpRenderTree/config.h: Moved macros to here...
379         * DumpRenderTree/mac/DumpRenderTreeMac.h: ...from here.
380         Addresses a FIXME comment from r28419.
381
382 2010-10-21  David Kilzer  <ddkilzer@apple.com>
383
384         <http://webkit.org/b/48047> Fix warnings found by check-Xcode-source-file-types
385
386         Reviewed by Adam Roben.
387
388         Fixes the following warnings:
389
390             WARNING: Incorrect file type 'sourcecode.cpp.objcpp' for file 'PixelDumpSupport.cpp'.
391             WARNING: Incorrect file type 'sourcecode.cpp.objcpp' for file 'LayoutTestController.cpp'.
392             WARNING: Incorrect file type 'sourcecode.cpp.objcpp' for file 'WorkQueue.cpp'.
393             WARNING: Incorrect file type 'sourcecode.cpp.objcpp' for file 'cg/PixelDumpSupportCG.cpp'.
394             WARNING: Incorrect file type 'sourcecode.cpp.objcpp' for file 'GCController.cpp'.
395             5 issues found for WebKitTools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj.
396
397         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
398         Removed explicit file type for *.cpp files above to make them
399         match other C++ source files.  This exposed the fact that
400         DumpRenderTreeMac.h was not safe to include in C++ source, which
401         caused PixelDumpSupport.cpp and PixelDumpSupportCG.cpp to fail
402         to build.
403         * DumpRenderTree/PixelDumpSupport.cpp: Adjusted header order.
404         * DumpRenderTree/mac/DumpRenderTreeMac.h: Made safe to include
405         in C++ source files.  Included CoreFoundation/CoreFoundation.h
406         to make sure all CF types were defined.  Removed CFStringRef
407         typedef.
408
409 2010-10-21  Adam Roben  <aroben@apple.com>
410
411         Attempt to fix plugins/pass-different-npp-struct.html on GTK.
412
413         See <http://webkit.org/b/47690>.
414
415         * GNUmakefile.am: Added PassDifferentNPPStruct.cpp.
416
417 2010-10-21  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
418
419         Reviewed by Csaba Osztrogonác.
420
421         [NRWT] Set ImageDiff path on Qt port
422         https://bugs.webkit.org/show_bug.cgi?id=48052
423
424         * Scripts/webkitpy/layout_tests/port/qt.py:
425
426 2010-10-21  Adam Barth  <abarth@webkit.org>
427
428         Reviewed by Eric Seidel.
429
430         Don't CC authors of flaky tests
431         https://bugs.webkit.org/show_bug.cgi?id=48038
432
433         Some authors found this too annoying.  We'll look for another way to
434         close the flaky test loop.
435
436         * Scripts/webkitpy/tool/commands/queues.py:
437         * Scripts/webkitpy/tool/commands/queues_unittest.py:
438
439 2010-10-21  Eric Seidel  <eric@webkit.org>
440
441         Reviewed by Adam Barth.
442
443         commit-queue should run run-webkit-tests with --no-new-test-results
444         https://bugs.webkit.org/show_bug.cgi?id=47998
445
446         * Scripts/webkitpy/tool/steps/runtests.py:
447         * Scripts/webkitpy/tool/steps/steps_unittest.py:
448
449 2010-10-21  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
450
451         Reviewed by Ojan Vafai.
452
453         [NRWT] Get child process number from an environment variable
454         https://bugs.webkit.org/show_bug.cgi?id=47981
455
456         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
457
458 2010-10-20  David Kilzer  <ddkilzer@apple.com>
459
460         <http://webkit.org/b/47754> New script to verify explicit source file types in Xcode project files
461
462         Reviewed by Darin Adler.
463
464         The script parses an Xcode project file and makes sure the file
465         extension matches the explicit file type set for all source
466         files.  Note that the majority of source files will have their
467         type set by Xcode, so the script doesn't check them since there
468         is no need to second-guess Xcode.
469
470         * Scripts/check-Xcode-source-file-types: Added.  Code borrowed
471         heavily from sort-Xcode-project-file.
472
473 2010-10-20  Adam Roben  <aroben@apple.com>
474         
475         Windows build fix
476
477         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Added missing #include.
478
479 2010-10-20  Adam Roben  <aroben@apple.com>
480
481         Qt test fix
482
483         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Added
484         PassDifferentNPPStruct.cpp.
485
486 2010-10-20  Sam Weinig  <sam@webkit.org>
487
488         Reviewed by Adam Roben.
489
490         Add ability to test injected bundle API using TestWebKitAPI
491         https://bugs.webkit.org/show_bug.cgi?id=48027
492
493         * TestWebKitAPI/InjectedBundleController.cpp: Added.
494         * TestWebKitAPI/InjectedBundleController.h: Added.
495         Shared main object for bundle functionality.
496
497         * TestWebKitAPI/InjectedBundleMain.cpp: Added.
498         Bundle entry point.
499
500         * TestWebKitAPI/InjectedBundleTest.h: Added.
501         Base class for which the bundle portion of a test derives from. 
502
503         * TestWebKitAPI/PlatformUtilities.h:
504         * TestWebKitAPI/PlatformUtilities.cpp: Added.
505         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
506         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
507         (TestWebKitAPI::Util::createInjectedBundlePath):
508         (TestWebKitAPI::Util::createURLForResource):
509         (TestWebKitAPI::Util::URLForNonExistentResource):
510         Add helper to create a context with the shared injected bundle,
511         and send the initial message to set up the test.
512
513         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig: Added.
514         * TestWebKitAPI/InjectedBundle-Info.plist: Added.
515         Add mac configuration files.
516
517         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
518         Add the new files.
519
520         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp: Added.
521         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp: Added.
522         Add a simple initial bundle test.
523
524 2010-10-20  Eric Seidel  <eric@webkit.org>
525
526         Unreviewed.  Fixing /release-patch url used by the EWS bots.
527
528         EWS should test patches with r+
529         https://bugs.webkit.org/show_bug.cgi?id=35460
530
531         * Scripts/webkitpy/common/net/statusserver.py:
532          - I changed the URL during development, and 404s are
533          intentionally silenced during release_patch.
534
535 2010-10-14  Adam Roben  <aroben@apple.com>
536
537         Test that passing a different NPP struct back to the browser doesn't
538         cause an assertion failure
539
540         Test for <http://webkit.org/b/47690> <rdar://problem/8553020>
541         Assertion failure in NetscapePlugin::fromNPP when using Shockwave in
542         WebKit2
543
544         Reviewed by John Sullivan.
545
546         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp: Copied from WebKitTools/DumpRenderTree/TestNetscapePlugIn/Tests/win/GetValueNetscapeWindow.cpp.
547         (PassDifferentNPPStruct::PassDifferentNPPStruct): Initialize our
548         members.
549         (PassDifferentNPPStruct::NPP_SetWindow): Pass a different NPP to the
550         browser than the one it gave us in NPP_New and see if it works.
551
552         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
553         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
554         Added PassDifferentNPPStruct.
555
556 2010-10-19  Adam Roben  <aroben@apple.com>
557
558         Gently nudge old-run-webkit-tests toward working with Win32 Perl
559
560         This makes old-run-webkit-tests able to build DRT and find all the
561         tests to run. It even invokes DRT and passes it the list of tests. But
562         DRT ends up hung blocking on I/O.
563
564         Fixes <http://webkit.org/b/47961> Get old-run-webkit-tests mostly
565         working with Win32 Perl
566
567         Reviewed by David Kilzer.
568
569         * Scripts/old-run-webkit-tests:
570           - Use File::Spec instead of manually concatenating paths
571           - Use dirname instead of manually stripping off the base name
572           - Use isCygwin/isWindows/isAppleWinWebKit more judiciously
573           - Explicitly invoke Perl when running Perl scripts
574           - Quote paths when using them in regular expressions to allow them
575             to include characters that have special meanings in regular
576             expressions
577
578         * Scripts/run-webkit-tests: Use File::Spec instead of manually
579         concatenating paths.
580
581         * Scripts/webkitdirs.pm:
582           - Remove the unused $windowsTmpPath variable
583           - Use isCygwin/isWindows/isAppleWinWebKit more judiciously
584           - Only pass paths to cygpath when using Cygwin Perl
585           - Only use pdevenv when using Cygwin Perl, for now
586
587 2010-10-20  Daniel Bates  <dbates@rim.com>
588
589         Reviewed by Martin Robinson.
590
591         Add Git-support to do-file-rename
592         https://bugs.webkit.org/show_bug.cgi?id=48015
593
594         Also, abstracts the SCM move/rename functionality in do-file-rename and
595         do-webcore-rename into a common function VCSUtils::scmMoveOrRenameFile().
596
597         Currently, do-file-rename is hard coded to assume the SCM is Subversion.
598         Instead, we should abstract the rename logic to be SCM-independent. This
599         will allow us to add Git support as well move such functionality into
600         our SCM library VCSUtils, where it can be shared by do-webcore-rename.
601
602         * Scripts/VCSUtils.pm:
603           - Added function scmMoveOrRenameFile.
604         * Scripts/do-file-rename: Modified to call VCSUtils::scmMoveOrRenameFile().
605         * Scripts/do-webcore-rename: Ditto.
606
607 2010-10-20  Adam Roben  <aroben@apple.com>
608
609         Fix old-run-webkit-tests when there's a space in the path to DRT
610
611         Reviewed by Jon Honeycutt.
612
613         * Scripts/old-run-webkit-tests: Quote the path to DRT before executing
614         it.
615
616 2010-10-20  Kenneth Russell  <kbr@google.com>
617
618         Reviewed by Dimitri Glazkov.
619
620         Regression in chromium_gpu_unittests after r70175
621         https://bugs.webkit.org/show_bug.cgi?id=48008
622
623         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
624
625 2010-10-20  Kenneth Russell  <kbr@google.com>
626
627         Reviewed by James Robinson.
628
629         chromium_gpu port of new-run-webkit-tests must do Linux -> Win expectations fallback
630         https://bugs.webkit.org/show_bug.cgi?id=48005
631
632         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
633
634 2010-10-20  Adam Barth  <abarth@webkit.org>
635
636         Reviewed by Eric Seidel.
637
638         webkit-patch doesn't get along with git rm
639         https://bugs.webkit.org/show_bug.cgi?id=47940
640
641         Turns out we need to pass "--" to tell git this is a path.
642
643         * Scripts/webkitpy/common/checkout/scm.py:
644
645 2010-10-20  Robert Hogan  <robert@webkit.org>
646
647         Reviewed by Antonio Gomes.
648
649         [Qt] Fix layoutTestController.getJsObjectCount
650
651         Qt Bridge doesn't know size_t so pass result as unsigned int.
652
653         Unskip fast/dom/gc-10.html
654
655         https://bugs.webkit.org/show_bug.cgi?id=47931
656
657         * DumpRenderTree/qt/GCControllerQt.cpp:
658         (GCController::getJSObjectCount):
659         * DumpRenderTree/qt/GCControllerQt.h:
660
661 2010-10-20  Sheriff Bot  <webkit.review.bot@gmail.com>
662
663         Unreviewed, rolling out r70149.
664         http://trac.webkit.org/changeset/70149
665         https://bugs.webkit.org/show_bug.cgi?id=47989
666
667         "Build breaks in mac and win" (Requested by satish on
668         #webkit).
669
670         * DumpRenderTree/LayoutTestController.cpp:
671         (setMockSpeechInputResultCallback):
672         * DumpRenderTree/LayoutTestController.h:
673         * DumpRenderTree/chromium/LayoutTestController.cpp:
674         (LayoutTestController::setMockSpeechInputResult):
675         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
676         (LayoutTestController::setMockSpeechInputResult):
677
678 2010-10-19  Adam Roben  <aroben@apple.com>
679
680         Teach update-webkit-support-libs about the new versioning of
681         WebKitSupportLibrary
682
683         Fixes <http://webkit.org/b/47915> update-webkit-support-libs should
684         check version numbers instead of modification times
685
686         Reviewed by Sam Weinig.
687
688         * Scripts/update-webkit-support-libs: Fetch the expected version
689         number from developer.apple.com, then compare with the version number
690         of the extracted library and of the zipped library to see if anything
691         needs to be done. Removed code that tracked the modified timestamp of
692         the library, as it is no longer needed.
693
694 2010-10-19  Eric Seidel  <eric@webkit.org>
695
696         Reviewed by Adam Barth.
697
698         EWS should test patches with r+
699         https://bugs.webkit.org/show_bug.cgi?id=35460
700
701         * QueueStatusServer/handlers/submittoews.py:
702         * QueueStatusServer/model/queues.py:
703         * Scripts/webkitpy/tool/bot/patchcollection.py: Removed.
704         * Scripts/webkitpy/tool/bot/patchcollection_unittest.py: Removed.
705         * Scripts/webkitpy/tool/commands/queues.py:
706
707 2010-10-19  Eric Seidel  <eric@webkit.org>
708
709         Reviewed by Adam Barth.
710
711         Teach feeder-queue how to feed the EWS bots
712         https://bugs.webkit.org/show_bug.cgi?id=47943
713
714         queues.webkit.org already knew how to accept EWS submissions
715         via /submit-to-ews.  This teaches the feeder queue how to post
716         to that page with any new r? patches it sees.
717
718         * QueueStatusServer/model/activeworkitems_unitest.py: Added.
719          - More unit testing is always a good thing.
720         * Scripts/webkitpy/common/net/bugzilla.py:
721         * Scripts/webkitpy/common/net/statusserver.py:
722         * Scripts/webkitpy/tool/bot/feeders.py:
723         * Scripts/webkitpy/tool/commands/queues.py:
724         * Scripts/webkitpy/tool/commands/queues_unittest.py:
725         * Scripts/webkitpy/tool/mocktool.py:
726
727 2010-10-19  Eric Seidel  <eric@webkit.org>
728
729         Unreviewed, just fixing test-webkitpy.  I'm really on a roll today.
730
731         commit-queue gets stuck when release-patch returns 404
732         https://bugs.webkit.org/show_bug.cgi?id=47935
733
734         Fix test-webkitpy and unittest NetworkTransaction.
735
736         * Scripts/webkitpy/common/net/networktransaction.py:
737         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
738
739 2010-10-19  Eric Seidel  <eric@webkit.org>
740
741         Unreviewed.
742
743         commit-queue gets stuck when release-patch returns 404
744         https://bugs.webkit.org/show_bug.cgi?id=47935
745
746         Turns out ClientForm gets upset if passed an int() instead of a string type.
747         Yay for untestable code.
748
749         * Scripts/webkitpy/common/net/statusserver.py:
750
751 2010-10-19  Eric Seidel  <eric@webkit.org>
752
753         Unreviewed.  Will get Adam's commentary after his meeting
754         for now this gets the commit-cluster back running.
755
756         commit-queue gets stuck when release-patch returns 404
757         https://bugs.webkit.org/show_bug.cgi?id=47935
758
759         I taught NetworkTransaction the basics of 404 handling.
760         We'll want to go back and teach it how to handle urllib2 404's too
761         and then deploy it to the places that want it.
762
763         * QueueStatusServer/handlers/releasepatch.py:
764         * Scripts/webkitpy/common/net/buildbot.py:
765         * Scripts/webkitpy/common/net/networktransaction.py:
766         * Scripts/webkitpy/common/net/statusserver.py:
767
768 2010-10-19  Eric Seidel  <eric@webkit.org>
769
770         Unreviewed.  Fixing typos in my previous commit.
771
772         Make patch release explicit and not a magic part of "retry" status
773         https://bugs.webkit.org/show_bug.cgi?id=47909
774
775         All of these typos again due to our inability to unit
776         test much of this code.  I added one unit test where
777         possible.  activeworkitems_unittest.py will be in a separate patch.
778
779         * QueueStatusServer/handlers/releasepatch.py:
780         * QueueStatusServer/main.py:
781         * QueueStatusServer/model/activeworkitems.py:
782         * QueueStatusServer/model/workitems.py:
783         * QueueStatusServer/model/workitems_unittest.py:
784         * QueueStatusServer/templates/releasepatch.html:
785         * Scripts/webkitpy/common/net/statusserver.py:
786
787 2010-10-19  Tony Chang  <tony@chromium.org>
788
789         Reviewed by Kent Tamura.
790
791         [chromium] Use webkit's TestNetscapePlugIn in DRT mac
792         https://bugs.webkit.org/show_bug.cgi?id=47850
793
794         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Added. Forked
795             because we're going to name our plugin WebKitTestNetscapePlugIn
796             temporarily until the chromium forked plugin goes away.
797
798 2010-10-19  Eric Seidel  <eric@webkit.org>
799
800         Reviewed by Adam Barth.
801
802         Make patch release explicit and not a magic part of "retry" status
803         https://bugs.webkit.org/show_bug.cgi?id=47909
804
805         This moves us another step closer to running r+ patches on the EWS bots.
806         Currently all bots just spam /update-work-items with their list of current
807         work items.  queues.webkit.org uses that data for display.  As part of making
808         the EWS run r+ patches, we're moving the official list of patches-to-process
809         into the server, and feeding them out to bots one at a time.  We need to be
810         able to remove patches from the queues one at a time instead of just spamming
811         /update-work-items with a new complete list.  That's what this patch adds.
812
813         * QueueStatusServer/handlers/nextpatch.py:
814         * QueueStatusServer/handlers/queuestatus.py:
815         * QueueStatusServer/handlers/releasepatch.py: Added.
816         * QueueStatusServer/handlers/statusbubble_unittest.py:
817          - Fix a typo causing test failure.  This was not caught by the bots
818            because they don't have AppEngineLauncher installed and thus don't run
819            the QueueStatusServer tests.
820         * QueueStatusServer/handlers/updatestatus.py:
821         * QueueStatusServer/model/activeworkitems.py:
822         * QueueStatusServer/templates/releasepatch.html: Added.
823         * Scripts/webkitpy/common/net/statusserver.py:
824         * Scripts/webkitpy/tool/commands/queues.py:
825         * Scripts/webkitpy/tool/mocktool.py:
826
827 2010-10-19  Eric Seidel  <eric@webkit.org>
828
829         Reviewed by Adam Barth.
830
831         cr-mac bubble has caused status bubbles to wrap
832         https://bugs.webkit.org/show_bug.cgi?id=47928
833
834         We now have too many EWSes to fit in the bugs.webkit.org
835         status-bubble iframe when more than a couple EWS builds are pending.
836         To fix this I've reduced the space taken up by queue position,
837         and also moved cr-mac to the end of the list (since it's going to be
838         triple-digits for a while).
839
840         * QueueStatusServer/model/queues.py:
841         * QueueStatusServer/templates/statusbubble.html:
842
843 2010-10-19  Kenneth Russell  <kbr@google.com>
844
845         Reviewed by David Levin.
846
847         chromium_gpu port of new-run-webkit-tests must search chromium-gpu directory for expectations
848         https://bugs.webkit.org/show_bug.cgi?id=47874
849
850         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
851         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
852
853 2010-10-19  Tony Chang  <tony@chromium.org>
854
855         Reviewed by Kent Tamura.
856
857         [chromium] DumpRenderTree shouldn't put '.' in include path
858         https://bugs.webkit.org/show_bug.cgi?id=47877
859
860         Fix include paths.
861
862         * DumpRenderTree/chromium/AccessibilityController.cpp:
863         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
864         * DumpRenderTree/chromium/AccessibilityUIElement.h:
865         * DumpRenderTree/chromium/CppBoundClass.cpp:
866         * DumpRenderTree/chromium/CppVariant.cpp:
867         * DumpRenderTree/chromium/CppVariant.h:
868         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
869         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
870         * DumpRenderTree/chromium/DRTDevToolsCallArgs.h:
871         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
872         * DumpRenderTree/chromium/DRTDevToolsClient.h:
873         * DumpRenderTree/chromium/EventSender.cpp:
874         * DumpRenderTree/chromium/EventSender.h:
875         * DumpRenderTree/chromium/LayoutTestController.cpp:
876         * DumpRenderTree/chromium/LayoutTestController.h:
877         * DumpRenderTree/chromium/MockSpellCheck.cpp:
878         * DumpRenderTree/chromium/NotificationPresenter.cpp:
879         * DumpRenderTree/chromium/NotificationPresenter.h:
880         * DumpRenderTree/chromium/PlainTextController.cpp:
881         * DumpRenderTree/chromium/Task.cpp:
882         * DumpRenderTree/chromium/TestNavigationController.h:
883         * DumpRenderTree/chromium/TestShell.cpp:
884         * DumpRenderTree/chromium/TestWebWorker.h:
885         * DumpRenderTree/chromium/TextInputController.cpp:
886         * DumpRenderTree/chromium/WebPreferences.cpp:
887         * DumpRenderTree/chromium/WebPreferences.h:
888         * DumpRenderTree/chromium/WebThemeEngineDRT.cpp:
889         * DumpRenderTree/chromium/WebThemeEngineDRT.h:
890         * DumpRenderTree/chromium/WebViewHost.cpp:
891         * DumpRenderTree/chromium/WebViewHost.h:
892
893 2010-10-19  Sam Weinig  <sam@webkit.org>
894
895         Reviewed by Dan Bernstein.
896
897         Need to include WKErrorRef in the WKPageDidFail... functions
898         https://bugs.webkit.org/show_bug.cgi?id=47871
899
900         Update tools for new parameter in failure callbacks.
901
902         * MiniBrowser/mac/BrowserWindowController.m:
903         (didFailProvisionalLoadWithErrorForFrame):
904         (didFailLoadWithErrorForFrame):
905         (-[BrowserWindowController updateProvisionalURLForFrame:]):
906         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
907         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
908         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
909         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
910         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
911         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
912
913 2010-10-19  Luiz Agostini  <luiz.agostini@openbossa.org>
914
915         Reviewed by Antti Koivisto.
916
917         [Qt] WebKit2 MacOS build fix
918         https://bugs.webkit.org/show_bug.cgi?id=47897
919
920         Qt WebKit2 MacOS build fix.
921
922         * WebKitTestRunner/PlatformWebView.h:
923         * WebKitTestRunner/qt/TestControllerQt.cpp:
924
925 2010-10-19  Adam Barth  <abarth@webkit.org>
926
927         Reviewed by Eric Seidel.
928
929         webkit-patch stats the filesystem too many times
930         https://bugs.webkit.org/show_bug.cgi?id=47883
931
932         This patch attempts to cache the list of changed files more agressively
933         and to use that list to compute the diff instead of stating the file
934         system again.
935
936         * Scripts/webkitpy/common/checkout/api.py:
937         * Scripts/webkitpy/common/checkout/scm.py:
938         * Scripts/webkitpy/tool/mocktool.py:
939         * Scripts/webkitpy/tool/steps/abstractstep.py:
940         * Scripts/webkitpy/tool/steps/editchangelog.py:
941         * Scripts/webkitpy/tool/steps/preparechangelog.py:
942
943 2010-10-19  David Kilzer  <ddkilzer@apple.com>
944
945         <http://webkit.org/b/47741> Make sort-Xcode-project-file a little more friendly
946
947         Reviewed by Darin Adler.
948
949         * Scripts/sort-Xcode-project-file:
950         - Don't print an error message about missing arguments when
951           -h|--help is used.
952         - Allow Xcode project files to be specified as Project.xcodeproj
953           instead of Project.xcodeproj/project.pbxproj.
954
955 2010-10-18  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
956
957         Reviewed by Andreas Kling.
958
959         [Qt] QtTestBrowser: Prevent calling load() directly from loadFinished() in robot mode.
960         https://bugs.webkit.org/show_bug.cgi?id=47809
961
962         Connecting a call to load from the loadFinished signal can cause
963         re-entrance crashes in WebCore. This patch uses a timer to do so,
964         also giving some time to subsequent frames to finish loading.
965
966         * QtTestBrowser/urlloader.cpp:
967         (UrlLoader::UrlLoader):
968         (UrlLoader::loadNext):
969         (UrlLoader::checkIfFinished):
970         (UrlLoader::frameLoadStarted):
971         (UrlLoader::frameLoadFinished):
972         * QtTestBrowser/urlloader.h:
973
974 2010-10-19  Sergio Villar Senín  <svillar@igalia.com>
975
976         Reviewed by Xan Lopez.
977
978         [GTK] http/history tests are failing
979         https://bugs.webkit.org/show_bug.cgi?id=36173
980
981         Clear the history each time a test is run. Return the actual
982         history item count when calling
983         LayoutTestController::webHistoryItemCount
984
985         * DumpRenderTree/gtk/DumpRenderTree.cpp:
986         (resetDefaultsToConsistentValues):
987         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
988         (LayoutTestController::webHistoryItemCount):
989
990 2010-10-18  Eric Seidel  <eric@webkit.org>
991
992         Reviewed by Adam Barth.
993
994         Add Chromium Mac EWS to the list of queues at queues.webkit.org
995         https://bugs.webkit.org/show_bug.cgi?id=47878
996
997         * QueueStatusServer/model/queues.py:
998
999 2010-10-18  Eric Seidel  <eric@webkit.org>
1000
1001         Reviewed by Adam Barth.
1002
1003         queues.webkit.org/next_patch is always 404
1004         https://bugs.webkit.org/show_bug.cgi?id=47881
1005
1006         With the addition of the Queue class, I changed most of the
1007         code to lookup WorkItems using get_or_insert with a key_name
1008         instead of WorkItems.all().filter(queue_name=).
1009         Because the new get_or_insert code uses an explicit key_name
1010         (which is obviously different from the previously autogenerated
1011         ones), there were new WorkItem records created for each queue.
1012         However, some parts of the code still use WorkItems.all().filter,
1013         thus some parts were getting the new record and some parts the old record.
1014
1015         The same basic bug was occurring with ActiveWorkItems, because I
1016         changed the key_name for that class as well.
1017
1018         To fix this I've moved more of the code over to using Queue.*work_items.
1019         I've also enabled the datastore_admin (new in GAE 1.3.8) so that
1020         we can go delete the old WorkItems records.
1021         I also changed remote_api to use the new builtin: syntax (also added in GAE 1.3.8).
1022
1023         * QueueStatusServer/app.yaml:
1024         * QueueStatusServer/handlers/queuestatus.py:
1025         * QueueStatusServer/handlers/recentstatus.py:
1026         * QueueStatusServer/handlers/updatestatus.py:
1027         * QueueStatusServer/handlers/updateworkitems.py:
1028
1029 2010-10-18  Eric Seidel  <eric@webkit.org>
1030
1031         Reviewed by Adam Barth.
1032
1033         Correct a bunch of typos in QueueStatusServer
1034         https://bugs.webkit.org/show_bug.cgi?id=47880
1035
1036         These are all due to our complete lack of unit testing in QueueStatusServer.
1037         I added a couple unit tests to cover a few of these fixes, but most of these
1038         are still only caught by actually running the application.
1039
1040         * QueueStatusServer/handlers/nextpatch.py:
1041         * QueueStatusServer/handlers/statusbubble.py:
1042         * QueueStatusServer/handlers/statusbubble_unittest.py: Added.
1043         * QueueStatusServer/handlers/updateworkitems.py:
1044         * QueueStatusServer/model/attachment.py:
1045         * QueueStatusServer/model/queuepropertymixin.py:
1046         * QueueStatusServer/model/queuepropertymixin_unittest.py:
1047         * QueueStatusServer/model/workitems.py:
1048         * QueueStatusServer/model/workitems_unittest.py: Added.
1049
1050 2010-10-18  Adam Barth  <abarth@webkit.org>
1051
1052         Disable this test because it's failing on the bots and the authors
1053         aren't around to fix it.
1054
1055         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1056
1057 2010-10-18  Adam Barth  <abarth@webkit.org>
1058
1059         Reviewed by Eric Seidel.
1060
1061         CC authors of flaky tests when the commit-queue hits a flaky test
1062         https://bugs.webkit.org/show_bug.cgi?id=47872
1063
1064         * Scripts/webkitpy/common/checkout/api.py:
1065         * Scripts/webkitpy/common/net/layouttestresults.py:
1066         * Scripts/webkitpy/tool/commands/queues.py:
1067         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1068         * Scripts/webkitpy/tool/mocktool.py:
1069
1070 2010-10-18  Eric Seidel  <eric@webkit.org>
1071
1072         Reviewed by Adam Barth.
1073
1074         Make it possible to run a chromium-mac-ews builder
1075         https://bugs.webkit.org/show_bug.cgi?id=47876
1076
1077         Since we can't run Mac OS X in a VM, we need to only run committer patches.
1078         There was a multiple inheritance problem which was holding this patch back,
1079         but I decided to just ignore the problem and go with a functional hack for now.
1080
1081         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1082         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1083
1084 2010-10-18  Kenneth Russell  <kbr@google.com>
1085
1086         Reviewed by Tony Chang.
1087
1088         Regression in run_webkit_tests_unittest from r70017
1089         https://bugs.webkit.org/show_bug.cgi?id=47875
1090
1091         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1092
1093 2010-10-18  Adam Barth  <abarth@webkit.org>
1094
1095         Reviewed by Eric Seidel.
1096
1097         Implement webkit-patch suggest-reviewers
1098         https://bugs.webkit.org/show_bug.cgi?id=47866
1099
1100         * Scripts/webkitpy/common/checkout/api.py:
1101             - The main logic.  We look at the last five changes to each
1102               modified (non-ChangeLog) file and collect up the reviewers of
1103               those changes as well as the authors of those changes who are
1104               reviewers.
1105         * Scripts/webkitpy/common/checkout/api_unittest.py:
1106             - Test the logic with some fun mocks.
1107         * Scripts/webkitpy/common/checkout/scm.py:
1108             - Fix a bug when you have local git commits.
1109         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1110             - Test that the bug is fixed.
1111         * Scripts/webkitpy/tool/commands/queries.py:
1112             - Add the query.
1113
1114 2010-10-18  Kenneth Russell  <kbr@google.com>
1115
1116         Reviewed by Eric Seidel.
1117
1118         new-run-webkit-tests produces corrupt PNG baselines on Windows
1119         https://bugs.webkit.org/show_bug.cgi?id=47867
1120
1121         * Scripts/webkitpy/layout_tests/port/base.py:
1122
1123 2010-10-18  Eric Seidel  <eric@webkit.org>
1124
1125         Reviewed by Adam Barth.
1126
1127         Make it possible to submit patches to the EWS bots
1128         https://bugs.webkit.org/show_bug.cgi?id=47869
1129
1130         * QueueStatusServer/handlers/nextpatch.py:
1131          - Move more logic into Queue, so that it can be shared with SubmitToEWS.
1132         * QueueStatusServer/handlers/queuestatus.py:
1133          - Fix two typos from a previous commit.
1134         * QueueStatusServer/handlers/submittoews.py: Added.
1135         * QueueStatusServer/handlers/updatestatus.py:
1136          - Use the new is_retry_request method to share this (hacky) code with SubmitToEWS
1137         * QueueStatusServer/main.py:
1138          - Add /submit-to-ews
1139         * QueueStatusServer/model/queuepropertymixin.py:
1140          - Fix circular imports caused by adding Queue.work_items()
1141         * QueueStatusServer/model/queues.py:
1142          - Add work_items() and active_work_items()
1143         * QueueStatusServer/model/queuestatus.py:
1144         * QueueStatusServer/model/workitems.py:
1145          - Add transaction-safe add/remove methods.
1146         * QueueStatusServer/templates/submittoews.html: Added.
1147
1148 2010-10-18  Eric Seidel  <eric@webkit.org>
1149
1150         Reviewed by Adam Barth.
1151
1152         Deploy Queue class in more places throughout QueueStatusServer
1153         https://bugs.webkit.org/show_bug.cgi?id=47855
1154
1155         I also caught two typos from the previous change.  Unfortunately
1156         I don't yet know how to unittest request handlers yet.
1157
1158         * QueueStatusServer/handlers/dashboard.py:
1159         * QueueStatusServer/handlers/statusbubble.py:
1160         * QueueStatusServer/handlers/updateworkitems.py:
1161         * QueueStatusServer/model/activeworkitems.py:
1162         * QueueStatusServer/model/attachment.py:
1163         * QueueStatusServer/model/queuepropertymixin.py: Added.
1164         * QueueStatusServer/model/queuepropertymixin_unittest.py: Added.
1165         * QueueStatusServer/model/queuestatus.py:
1166         * QueueStatusServer/model/workitems.py:
1167
1168 2010-10-18  Adam Barth  <abarth@webkit.org>
1169
1170         Reviewed by Eric Seidel.
1171
1172         scm.py should be able tell us what revisions made changes to a given file
1173         https://bugs.webkit.org/show_bug.cgi?id=47863
1174
1175         Look again, your SCM.py can now log files.
1176
1177         * Scripts/webkitpy/common/checkout/scm.py:
1178         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1179
1180 2010-10-18  Dirk Pranke  <dpranke@chromium.org>
1181
1182         Reviewed by Eric Siedel.
1183
1184         new-run-webkit-tests: clean up the options-parsing code in the port
1185         classes.
1186         
1187         This change modifies the Port interface to have a get_option() and
1188         set_option_default() method for accessing the options argument
1189         passed to the constructor. If the constructor is not passed an
1190         options argument, we default to a MockOptions() argument from
1191         mocktool, which has the same semantics we want.
1192
1193         Note that there is a disadvantage to port.get_option('foo') over
1194         port._options.foo, which is that you lose some of the checking
1195         for whether 'foo' is set (typos result in the default value, not
1196         an exception being raised. This is desired in this case, since the
1197         Port class is not allowed to assume that options does have any
1198         particular values set, and so this change ensures that all of
1199         the subclasses are following the same, intended, logic.
1200
1201         Arguably this is the wrong semantics to have, and the Port
1202         classes should be able to assume a default set of
1203         attributes/arguments, but that change will need to wait for a
1204         different CL where we can modify new-run-webkit-tests to pull a
1205         list of arguments from the port factory routines.
1206
1207         Also, add unit tests for webkitpy.tool.mocktool.MockOptions .
1208
1209         https://bugs.webkit.org/show_bug.cgi?id=47510
1210
1211         * Scripts/webkitpy/layout_tests/port/base.py:
1212         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1213         * Scripts/webkitpy/layout_tests/port/chromium.py:
1214         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1215         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1216         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1217         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1218         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1219         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1220         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1221         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1222         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1223         * Scripts/webkitpy/layout_tests/port/test.py:
1224         * Scripts/webkitpy/layout_tests/port/webkit.py:
1225         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1226         * Scripts/webkitpy/tool/mocktool_unittest.py: Added.
1227
1228 2010-10-18  Dirk Pranke  <dpranke@chromium.org>
1229
1230         Reviewed by Eric Seidel.
1231
1232         Re-submit a revised version of r69638 - enabling new-run-webkit-tests
1233         under cygwin. The initial version had a bug in base:uri_to_test_name
1234         that was causing tests to fail. This version corrects that bug, but
1235         also makes the code safer by calling cygpath more reliably, and
1236         leaving a long-running cygpath process open.
1237
1238         This patch also corrects a couple of minor bugs in http_lock_unittest,
1239         chromium_unittest, and dedpulicate_tests_unittest that showed up
1240         while testing this.
1241
1242         https://bugs.webkit.org/show_bug.cgi?id=47220
1243
1244         * Scripts/webkitpy/common/system/path.py:
1245         * Scripts/webkitpy/common/system/path_unittest.py:
1246         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1247         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1248         * Scripts/webkitpy/layout_tests/port/base.py:
1249         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1250         * Scripts/webkitpy/layout_tests/port/chromium.py:
1251         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1252         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
1253         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1254
1255 2010-10-18  Eric Seidel  <eric@webkit.org>
1256
1257         Reviewed by Adam Barth.
1258
1259         Add Queue class and add minimal unittesting of QueueStatusServer code
1260         https://bugs.webkit.org/show_bug.cgi?id=47847
1261
1262         * QueueStatusServer/handlers/dashboard.py:
1263         * QueueStatusServer/handlers/queuestatus.py:
1264         * QueueStatusServer/handlers/recentstatus.py:
1265         * QueueStatusServer/handlers/statusbubble.py:
1266         * QueueStatusServer/handlers/updateworkitems.py:
1267         * QueueStatusServer/model/attachment.py:
1268         * QueueStatusServer/model/queues.py:
1269         * QueueStatusServer/model/queues_unittest.py: Added.
1270         * QueueStatusServer/model/svnrevision.py:
1271         * Scripts/test-webkitpy:
1272         * Scripts/webkitpy/test/main.py:
1273
1274 2010-10-18  Anders Carlsson  <andersca@apple.com>
1275
1276         Fix build.
1277
1278         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1279         (handleEventCarbon):
1280
1281 2010-10-18  Stuart Morgan  <stuartmorgan@chromium.org>
1282
1283         Reviewed by Eric Seidel.
1284
1285         Switch to using the new Carbon NPAPI event declarations, and remove
1286         the old ones.
1287
1288         https://bugs.webkit.org/show_bug.cgi?id=40784
1289
1290         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1291         (handleEventCarbon):
1292
1293 2010-10-18  David Levin  <levin@chromium.org>
1294
1295         Reviewed by Adam Barth.
1296
1297         check-webkit-style should treat the GObject binding directory like other GTK directories.
1298         https://bugs.webkit.org/show_bug.cgi?id=47796
1299
1300         * Scripts/webkitpy/style/checker.py: Added the GObject binding directory
1301         with the other gtk directories (and fixed typo).
1302
1303 2010-10-18  David Levin  <levin@chromium.org>
1304
1305         Reviewed by Oliver Hunt.
1306
1307         check-webkit-style needs to ignore underscores in opcode names and vm_throw
1308         https://bugs.webkit.org/show_bug.cgi?id=47789
1309
1310         * Scripts/webkitpy/style/checker.py: Added the exception for the assembler directory.
1311         * Scripts/webkitpy/style/checkers/cpp.py: Added special cased names.
1312         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added unit tests for the special cases.
1313
1314 2010-10-18  MORITA Hajime  <morrita@google.com>
1315
1316         Reviewed by Kent Tamura.
1317
1318         TextInputController.hasSpellingMarkers() should be owned by LayoutTestController
1319         https://bugs.webkit.org/show_bug.cgi?id=47659
1320         
1321         Moved hasSpellingMarkers() from TextInputController to
1322         LayoutTestController.  Currently the implementation is available
1323         only for Mac and for Chromium.
1324
1325         * DumpRenderTree/LayoutTestController.cpp:
1326         (hasSpellingMarkerCallback):
1327         (LayoutTestController::staticFunctions):
1328         * DumpRenderTree/LayoutTestController.h:
1329         * DumpRenderTree/chromium/LayoutTestController.cpp:
1330         (LayoutTestController::LayoutTestController):
1331         (LayoutTestController::hasSpellingMarker):
1332         * DumpRenderTree/chromium/LayoutTestController.h:
1333         * DumpRenderTree/chromium/TextInputController.cpp:
1334         (TextInputController::TextInputController):
1335         (TextInputController::makeAttributedString):
1336         * DumpRenderTree/chromium/TextInputController.h:
1337         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1338         (LayoutTestController::hasSpellingMarker):
1339         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1340         (LayoutTestController::hasSpellingMarker):
1341         * DumpRenderTree/mac/TextInputController.m:
1342         (+[TextInputController isSelectorExcludedFromWebScript:]):
1343         (+[TextInputController webScriptNameForSelector:]):
1344         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1345         (LayoutTestController::hasSpellingMarker):
1346         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1347         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1348         (LayoutTestController::hasSpellingMarker):
1349         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1350         (LayoutTestController::hasSpellingMarker):
1351
1352 2010-10-18  Adam Barth  <abarth@webkit.org>
1353
1354         Reviewed by David Levin.
1355
1356         commit-queue's flaky test notice is very Pythony
1357         https://bugs.webkit.org/show_bug.cgi?id=47790
1358
1359         This patch make the list of tests delimted by \n instead of just
1360         converting the array to a string.
1361
1362         * Scripts/webkitpy/tool/commands/queues.py:
1363         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1364
1365 2010-10-14  Antonio Gomes  <agomes@rim.com>
1366
1367         Reviewed by Martin Robinson and Xan Lopez.
1368
1369         [Gtk]: DRT does not support frame flattening testing
1370         https://bugs.webkit.org/show_bug.cgi?id=38650
1371
1372         Implement DRT's support for toggling on/off frame flattening
1373         support.
1374
1375         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1376         (resetDefaultsToConsistentValues):
1377         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1378         (LayoutTestController::setFrameFlatteningEnabled):
1379
1380 2010-10-15  Dirk Pranke  <dpranke@chromium.org>
1381
1382         Reviewed by Eric Siedel.
1383
1384         mocktool.MockOptions is inheriting from Mock, which has the side
1385         effect of defaulting any attribute to another MockObject. So,
1386         MockOptions().foo would always evaluate to true. This was
1387         covering over bugs in the unit tests, and is probably the wrong
1388         default behavior for anything attempting to mock out the options
1389         argument returned from optparse.parse_args().
1390
1391         This patch changes the default behavior. The new MockOptions()
1392         class takes an optional list of keyword parameters to set; this
1393         patch doesn't use that feature but the fix for bug 47510 will.
1394
1395         Also, this patch just fills in the default values necessary to
1396         get all of the tests to pass; I didn't stare at each test by
1397         hand to determine the "right" values. We can either fix that in
1398         subsequent patches or let me know if we want to do that now (and
1399         give me some guidance on what those values might want to be).
1400
1401         https://bugs.webkit.org/show_bug.cgi?id=47709
1402
1403         * Scripts/webkitpy/tool/commands/commandtest.py:
1404         * Scripts/webkitpy/tool/commands/download_unittest.py:
1405         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1406         * Scripts/webkitpy/tool/mocktool.py:
1407         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1408         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
1409
1410 2010-10-15  Simon Fraser  <simon.fraser@apple.com>
1411
1412         Fix the build; need to add new slot to PageUIClient callbacks.
1413
1414         * MiniBrowser/mac/BrowserWindowController.m:
1415         (-[BrowserWindowController awakeFromNib]):
1416         * WebKitTestRunner/TestController.cpp:
1417         (WTR::createOtherPage):
1418         (WTR::TestController::initialize):
1419
1420 2010-10-15  Simon Fraser  <simon.fraser@apple.com>
1421
1422         Add Matt Delaney to committers.py.
1423
1424         * Scripts/webkitpy/common/config/committers.py:
1425
1426 2010-10-15  Tony Chang  <tony@chromium.org>
1427
1428         Reviewed by Kent Tamura.
1429
1430         [chromium] compile TestNetscapePlugIn on Chromium mac
1431         https://bugs.webkit.org/show_bug.cgi?id=47633
1432
1433         * DumpRenderTree/DumpRenderTree.gypi: files to compile
1434         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Use ifdef because gcc was complaining
1435         (NP_GetEntryPoints):
1436         (NPP_New):
1437         (NPP_Destroy):
1438         (NPP_HandleEvent):
1439         (NPP_GetValue):
1440         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Added.
1441         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Added.
1442         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Added.
1443
1444 2010-10-15  Leandro Pereira  <leandro@profusion.mobi>
1445
1446         Reviewed by Gustavo Noronha Silva.
1447
1448         build-webkit: Should die when make fails when build a CMake project
1449         https://bugs.webkit.org/show_bug.cgi?id=47726
1450
1451         * Scripts/webkitdirs.pm: If make fails, die immediately.
1452
1453 2010-10-15  Sheriff Bot  <webkit.review.bot@gmail.com>
1454
1455         Unreviewed, rolling out r69809.
1456         http://trac.webkit.org/changeset/69809
1457         https://bugs.webkit.org/show_bug.cgi?id=47725
1458
1459         Broke chromium mac compile (Requested by japhet on #webkit).
1460
1461         * DumpRenderTree/DumpRenderTree.gypi:
1462         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1463         (NP_GetEntryPoints):
1464         (NPP_New):
1465         (NPP_Destroy):
1466         (NPP_HandleEvent):
1467         (NPP_GetValue):
1468         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
1469         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
1470         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
1471
1472 2010-10-15  Adam Barth  <abarth@webkit.org>
1473
1474         Reviewed by Adam Barth.
1475
1476         test-webkitpy fails on Linux
1477         https://bugs.webkit.org/show_bug.cgi?id=47713
1478
1479         The old code failed on Linux because the MacPort tries to read
1480         something out of platform that doesn't make sense on Linux.
1481
1482         * Scripts/webkitpy/tool/mocktool.py:
1483
1484 2010-10-14  Balazs Kelemen  <kbalazs@webkit.org>
1485
1486         Reviewed by Kenneth Rohde Christiansen.
1487
1488         [Qt] WTR is sloooow
1489         https://bugs.webkit.org/show_bug.cgi?id=47695
1490
1491         * WebKitTestRunner/qt/TestControllerQt.cpp:
1492         Change the timer interval of RunUntilConditionLoop from
1493         50 milliseconds to 1 to avoid wasting time after the 
1494         test had been finished.
1495
1496 2010-10-14  Eric Seidel  <eric@webkit.org>
1497
1498         Unreviewed, just fixing an exception seen on the commit-queue.
1499
1500         I should have unit tested this function before.
1501
1502         * Scripts/webkitpy/tool/commands/queues.py:
1503         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1504
1505 2010-10-14  Eric Seidel  <eric@webkit.org>
1506
1507         Reviewed by Adam Barth.
1508
1509         commit-queue should not fail patches due to flaky tests
1510         https://bugs.webkit.org/show_bug.cgi?id=47647
1511
1512         This patch makes it so that the *same* flaky test has to fail
1513         twice in a row to have a false negative from a flaky test.
1514
1515         If different flaky tests fail (or if a test fails and then passes
1516         in a second run) then we will warn in the bug that we encountered
1517         a flaky test.
1518
1519         This patch grew to include moving port off of steps onto tool
1520         (which Adam wrote and then I integrated), as well as removing the
1521         use of tool from CommitQueueTask.
1522
1523         * Scripts/webkitpy/common/config/ports.py:
1524          - Added a layout_test_results_path method.  This covers old-run-webkit-tests
1525            but doesn't cover NRWT.  This is probably not the long term solution, but
1526            putting this knowledge on port makes more sense than in LayoutTestResults.
1527         * Scripts/webkitpy/common/net/buildbot.py:
1528          - LayoutTestResults shouldn't know how to fetch from the network, make
1529            the Build code do that instead.
1530         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1531          - Code style fix.
1532         * Scripts/webkitpy/common/net/layouttestresults.py:
1533          - Remove code for reading from the network.
1534         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1535          - Test the new entrypoint.
1536         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1537          - Make the delegate interface explicit.
1538          - Remove the _tool member, since using the delegate for
1539            everything is cleaner.
1540          - Teach the testing logic how to deal with flaky tests.
1541         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1542          - Update to match the CommitQueueTask changes.
1543         * Scripts/webkitpy/tool/commands/queues.py:
1544          - Use the new CommitQueueTaskDelegate interface.
1545         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1546          - Fix the SecondThoughtsCommitQueue test which was broken.
1547          - Add a new test to make sure the flaky test reporting works.
1548         * Scripts/webkitpy/tool/main.py:
1549          - Store the port on the tool object.
1550         * Scripts/webkitpy/tool/mocktool.py:
1551          - Add a port() accessor to MockTool
1552         * Scripts/webkitpy/tool/steps/abstractstep.py:
1553          - Move port() off of Step and onto Tool.
1554         * Scripts/webkitpy/tool/steps/build.py:
1555         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1556         * Scripts/webkitpy/tool/steps/runtests.py:
1557         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1558          - Two tests with the same name!  only the latter was being run.
1559         * Scripts/webkitpy/tool/steps/update.py:
1560
1561 2010-10-14  Dirk Pranke  <dpranke@chromium.org>
1562
1563         Reviewed by Eric Seidel.
1564
1565         new-run-webkit-tests will now handle missing Ruby installs (or
1566         missing PrettyPatch scripts) more cleanly - previously this
1567         would be detected when we actually tried to create the diff, and
1568         the error message was obscure. Now we'll log a warning up front
1569         and otherwise be silent.
1570
1571         This change also refactors some global variables to be class or
1572         instance variables to be slightly more testable and more
1573         modular. There are no cases where we create lots of port objects
1574         and can't afford to test for configurations repeatedly, so
1575         there's no performance concern here.
1576
1577         https://bugs.webkit.org/show_bug.cgi?id=47466
1578
1579         * Scripts/webkitpy/layout_tests/port/base.py:
1580         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1581         * Scripts/webkitpy/layout_tests/port/chromium.py:
1582
1583 2010-10-08  Martin Robinson  <mrobinson@igalia.com>
1584
1585         Reviewed by Xan Lopez.
1586
1587         [GTK] Form controls do not respect GTK+ font size
1588         https://bugs.webkit.org/show_bug.cgi?id=47134
1589
1590         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1591         (initializeGtkFontSettings): Initialize the font control size when running
1592         DumpRenderTree to a standard value.
1593
1594 2010-10-14  Tony Chang  <tony@chromium.org>
1595
1596         Reviewed by Kent Tamura.
1597
1598         [chromium] compile TestNetscapePlugIn on Chromium mac
1599         https://bugs.webkit.org/show_bug.cgi?id=47633
1600
1601         * DumpRenderTree/DumpRenderTree.gypi: files to compile
1602         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Use ifdef because gcc was complaining
1603         (NP_GetEntryPoints):
1604         (NPP_New):
1605         (NPP_Destroy):
1606         (NPP_HandleEvent):
1607         (NPP_GetValue):
1608         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Added.
1609         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Added.
1610         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Added.
1611
1612 2010-10-14  Victor Wang  <victorw@chromium.org>
1613
1614         Reviewed by Nate Chapin.
1615
1616         [Chromium] Fix rebaseline_chromium_webkit_tests to use 0 tolerance image diff.
1617
1618         https://bugs.webkit.org/show_bug.cgi?id=47686
1619
1620         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1621
1622 2010-10-14  Eric Seidel  <eric@webkit.org>
1623
1624         Reviewed by Adam Barth.
1625
1626         test-webkitpy spews Delegate terminated queue messages
1627         https://bugs.webkit.org/show_bug.cgi?id=47678
1628
1629         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1630
1631 2010-10-14  Adam Roben  <aroben@apple.com>
1632
1633         Test that pressing the Alt key generates a WM_SYSCOMMAND message
1634
1635         Test for <http://webkit.org/b/47671> <rdar://problem/8435594> Pressing
1636         the Alt key when MiniBrowser's WKView is focused doesn't send focus to
1637         the menu bar
1638
1639         Reviewed by Steve Falkenburg.
1640
1641         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added
1642         TestWebKitAPI/win to the include path so that WindowMessageObserver
1643         can be found.
1644
1645         * TestWebKitAPI/PlatformWebView.h: Added simulateAltKeyPress and
1646         Windows-specific members.
1647         (TestWebKitAPI::PlatformWebView::setParentWindowMessageObserver):
1648         Added this simple setter.
1649
1650         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp: Added.
1651         (TestWebKitAPI::WMSysCommandObserver::WMSysCommandObserver):
1652         Initialize our lone data member.
1653         (TestWebKitAPI::WMSysCommandObserver::windowDidReceiveWMSysCommand):
1654         Simple getter.
1655         (TestWebKitAPI::WMSysCommandObserver::windowReceivedMessage): Record
1656         when a WM_SYSCOMMAND message is received.
1657         (TestWebKitAPI::didNotHandleKeyEventCallback): Record when a
1658         WM_SYSKEYUP message is not handled.
1659         (TestWebKitAPI::WebKit2_AltKeyGeneratesWMSysCommand): Simulate
1660         pressing the Alt key and check that a WM_SYSCOMMAND message got sent
1661         to the WKView's parent window.
1662
1663         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
1664         (TestWebKitAPI::PlatformWebView::registerWindowClass): Made this a
1665         member function so it could access PlatformWebView::wndProc. Use
1666         PlatformWebView::wndProc as the WNDPROC.
1667         (TestWebKitAPI::PlatformWebView::PlatformWebView): Initialize our new
1668         data member and pass the this pointer to CreateWindowEx so we can
1669         store it on the HWND.
1670         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Moved some
1671         constants from here to the top of the file.
1672         (TestWebKitAPI::PlatformWebView::simulateAltKeyPress): Added. Sends
1673         the same messages that Notepad receives when you press the Alt key.
1674         (TestWebKitAPI::PlatformWebView::wndProc): Added.
1675           - When WM_CREATE is received, we set the PlatformWebView instance
1676             pointer as a property on the HWND so we can access it later.
1677           - For other messages, we try to get the PlatformWebView instance
1678             pointer from the HWND property.
1679           - When WM_NCDESTROY is received (which is the last message we will
1680             receive), we remove the PlatformWebView instance property.
1681           - Pass messages to the parent window's message observer, if there is
1682             one.
1683           - Pass all messages through to ::DefWindowProcW.
1684
1685         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added WindowMessageObserver
1686         and AltKeyGeneratesWMSysCommand.
1687
1688         * TestWebKitAPI/win/WindowMessageObserver.h: Added. This class can be
1689         used to observe messages sent to one or more windows.
1690
1691 2010-10-01  Martin Robinson  <mrobinson@igalia.com>
1692
1693         Reviewed by Holger Freyther.
1694
1695         [GTK] REGRESSION: FreeType backend does not respect XSettings font settings after r68558
1696         https://bugs.webkit.org/show_bug.cgi?id=47033
1697
1698         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1699         (initializeGtkFontSettings): Added this method which initializes XSettings
1700         font settings to consistent values before running a test. For the one test
1701         in which we need subpixel aliasing turned on, do that.
1702         (initializeFonts): Accepts a testURL parameter now and delegates to initializeGtkFontSettings.
1703         (runTest): Pass the testURL to initializeFonts.
1704
1705 2010-10-14  Adam Barth  <abarth@webkit.org>
1706
1707         Reviewed by Eric Seidel.
1708
1709         ChromiumXVFBPort.run_webkit_tests_command has infinite recursion
1710         https://bugs.webkit.org/show_bug.cgi?id=47655
1711
1712         * Scripts/webkitpy/common/config/ports.py:
1713         * Scripts/webkitpy/common/config/ports_unittest.py:
1714
1715 2010-10-13  Eric Seidel  <eric@webkit.org>
1716
1717         Reviewed by Adam Barth.
1718
1719         beat diff_parser with the ugly stick
1720         https://bugs.webkit.org/show_bug.cgi?id=47626
1721
1722         * Scripts/webkitpy/common/checkout/diff_parser.py:
1723         * Scripts/webkitpy/style/patchreader.py:
1724         * Scripts/webkitpy/style/patchreader_unittest.py:
1725
1726 2010-10-13  Eric Seidel  <eric@webkit.org>
1727
1728         Reviewed by Adam Barth.
1729
1730         Break LayoutTestResults out into its own file
1731         https://bugs.webkit.org/show_bug.cgi?id=47637
1732
1733         * Scripts/webkitpy/common/net/buildbot.py:
1734         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1735         * Scripts/webkitpy/common/net/layouttestresults.py: Added.
1736         * Scripts/webkitpy/common/net/layouttestresults_unittest.py: Added.
1737
1738 2010-10-13  Adam Barth  <abarth@webkit.org>
1739
1740         Unreviewed.
1741
1742         Chromium port can't run JavaScriptCore tests
1743         https://bugs.webkit.org/show_bug.cgi?id=47654
1744
1745         This lets webkit-patch build-and-test work on Chromium.
1746
1747         * Scripts/webkitpy/common/config/ports.py:
1748         * Scripts/webkitpy/tool/steps/runtests.py:
1749
1750 2010-10-13  Adam Barth  <abarth@webkit.org>
1751
1752         Reviewed by Eric Seidel.
1753
1754         Make --port a global option and pass the port information to the commit-queue subprocess
1755         https://bugs.webkit.org/show_bug.cgi?id=47650
1756
1757         This patch paves the way to run the commit-queue on a non-Mac port.
1758
1759         * Scripts/webkitpy/tool/commands/queues.py:
1760         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1761         * Scripts/webkitpy/tool/commands/queuestest.py:
1762         * Scripts/webkitpy/tool/main.py:
1763         * Scripts/webkitpy/tool/steps/options.py:
1764         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1765         * Scripts/webkitpy/tool/steps/runtests.py:
1766         * Scripts/webkitpy/tool/steps/update.py:
1767
1768 2010-10-13  Adam Barth  <abarth@webkit.org>
1769
1770         Reviewed by Eric Seidel.
1771
1772         Introduce the ChromiumXVFBPort for running commit-queue on EC2
1773         https://bugs.webkit.org/show_bug.cgi?id=47653
1774
1775         I'm not entirely sure this is the best way to do this, but we need to
1776         run the tests under XVFB on EC2 because the EC2 instances don't have a
1777         real monitor hooked up.  This patch adds a ChromiumXVFBPort that runs
1778         that way.  The idea is that XVFB is like a platform for the Chromium
1779         port, but we don't have a real notion of platform separate from port.
1780
1781         * Scripts/webkitpy/common/config/ports.py:
1782
1783 2010-10-13  Sergio Villar Senin  <svillar@igalia.com>
1784
1785         Reviewed by Martin Robinson.
1786
1787         [GTK] Add HTTP caching support
1788         https://bugs.webkit.org/show_bug.cgi?id=44261
1789
1790         Add include paths for the new soup HTTP cache code.
1791
1792         * GNUmakefile.am: Add paths for the new soup HTTP cache code.
1793
1794 2010-10-13  Yi Shen  <yi.4.shen@nokia.com>
1795
1796         Reviewed by Antonio Gomes.
1797
1798         [Qt] QtTestBrowser shows two Url input fields
1799         https://bugs.webkit.org/show_bug.cgi?id=47613
1800
1801         * QtTestBrowser/mainwindow.cpp:
1802         (MainWindow::MainWindow):
1803         (MainWindow::buildUI):
1804
1805 2010-10-13  Yi Shen  <yi.4.shen@nokia.com>
1806
1807         Reviewed by Tony Chang.
1808
1809         [gdb] Add pretty-print supports for UString, Identifier and JSString
1810         https://bugs.webkit.org/show_bug.cgi?id=47601
1811
1812         * gdb/webkit.py:
1813
1814 2010-10-13  Adam Barth  <abarth@webkit.org>
1815
1816         Reviewed by Eric Seidel.
1817
1818         Add list of Ubuntu packages needed by the EWS bots
1819         https://bugs.webkit.org/show_bug.cgi?id=47628
1820
1821         I've been copy/pasting this list between bots, but it's better to have
1822         this checked in.
1823
1824         * EWSTools/ubuntu-ews-packages: Added.
1825
1826 2010-10-13  Leandro Pereira  <leandro@profusion.mobi>
1827
1828         Reviewed by Csaba Osztrogonác.
1829
1830         [EFL] Adds a build slave.
1831         https://bugs.webkit.org/show_bug.cgi?id=47290
1832
1833         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
1834         entry for a release build of the EFL port.
1835         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
1836         flag to build the EFL port.
1837
1838 2010-10-13  Adam Barth  <abarth@webkit.org>
1839
1840         Reviewed by Csaba Osztrogonác.
1841
1842         webkit-patch build shouldn't need --build to actually build!
1843         https://bugs.webkit.org/show_bug.cgi?id=47438
1844
1845         Yeah, requiring --build for the build command is really dumb.  We did
1846         this originally because the build step is usually optional in other
1847         commands.  We don't have a good way of reversing the default for an
1848         option in one command.  This approach is slightly hacky since --build
1849         still shows up as an option on the help page, but at least it makes
1850         progress.  Passing --build is harmless, so the EWS bots shouldn't
1851         explode because of this change.
1852
1853         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1854         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1855         * Scripts/webkitpy/tool/commands/download.py:
1856         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1857         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1858
1859 2010-10-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1860
1861         Unreviewed, rolling out r69638.
1862         http://trac.webkit.org/changeset/69638
1863         https://bugs.webkit.org/show_bug.cgi?id=47595
1864
1865         "Broke win and chromium-win bots" (Requested by dglazkov on
1866         #webkit).
1867
1868         * Scripts/webkitpy/common/system/path.py:
1869         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1870         * Scripts/webkitpy/layout_tests/port/base.py:
1871         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1872         * Scripts/webkitpy/layout_tests/port/chromium.py:
1873         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1874
1875 2010-10-13  John Knottenbelt  <jknotten@chromium.org>
1876
1877         Reviewed by Steve Block.
1878
1879         First step towards client-based Geolocation in Chromium. Build
1880         fixes for CLIENT_BASED_GEOLOCATION preprocessor feature define.
1881         https://bugs.webkit.org/show_bug.cgi?id=47586
1882
1883         * DumpRenderTree/chromium/WebViewHost.cpp:
1884         * DumpRenderTree/chromium/WebViewHost.h:
1885
1886 2010-10-13  Adam Roben  <aroben@apple.com>
1887
1888         Test that pressing the spacebar in a text field does not scroll the
1889         document
1890
1891         Test for <http://webkit.org/b/47544> <rdar://problem/8540645>
1892         REGRESSION: Pressing spacebar in a text field in WebKit2 does not
1893         insert a space, scrolls the page instead
1894
1895         Reviewed by Sam Weinig.
1896
1897         * TestWebKitAPI/PlatformUtilities.h: Added isKeyDown.
1898
1899         * TestWebKitAPI/PlatformWebView.h: Added simulateSpacebarKeyPress.
1900
1901         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1902         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1903         * TestWebKitAPI/win/copy-resources.cmd:
1904         Added new files.
1905
1906         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: Added.
1907         (TestWebKitAPI::JavaScriptCallbackContext::JavaScriptCallbackContext):
1908         We use this to track what the result of calling into JavaScript was.
1909         (TestWebKitAPI::didFinishLoadForFrame): Records when the page
1910         finishes loading.
1911         (TestWebKitAPI::didNotHandleKeyEventCallback): Records when a key down
1912         event is not handled.
1913         (TestWebKitAPI::javaScriptCallback): Records that JavaScript finished
1914         executing and whether the result matched our expectation.
1915         (TestWebKitAPI::wk): Turns a UTF-8 C string into a WKStringRef.
1916         (TestWebKitAPI::runJSTest): Calls into JS, waits for the call to
1917         complete, and returns whether we got back the expected result.
1918         (TestWebKitAPI::WebKit2_SpacebarScrolling): Tests that pressing
1919         spacebar inside a text field does not scroll the document and that
1920         pressing it outside the text field does scroll the document.
1921
1922         * TestWebKitAPI/Tests/WebKit2/spacebar-scrolling.html: Added.
1923
1924         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1925         (TestWebKitAPI::Util::isKeyDown): Checks the event's type.
1926
1927         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1928         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Copied
1929         code from DRT's EventSendingController.
1930
1931         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1932         (TestWebKitAPI::Util::isKeyDown): Checks the message's type.
1933
1934         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
1935         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Send the
1936         same messages that get sent when you press spacebar in Notepad.
1937
1938 2010-10-13  Adam Roben  <aroben@apple.com>
1939
1940         Fix a couple of issues with the TestWebKitAPI build
1941
1942         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops:
1943         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops:
1944         Fixed a typo.
1945
1946         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Use common.vsprops
1947         to set our output and intermediate directories so that we don't spew
1948         files into the source tree.
1949
1950 2010-10-13  Balazs Kelemen  <kbalazs@webkit.org>
1951
1952         Reviewed by Csaba Osztrogonác.
1953
1954         WTR should accept relative paths
1955         https://bugs.webkit.org/show_bug.cgi?id=47486
1956
1957         * WebKitTestRunner/StringFunctions.h:
1958         * WebKitTestRunner/TestInvocation.cpp:
1959         (WTR::createWKURL): Moved from StringFunctions.h since it is
1960         used only here. Extend relative paths to absolute.
1961
1962 2010-10-12  Adam Roben  <aroben@apple.com>
1963
1964         Make TestWebKitAPI work on Windows
1965
1966         Fixes <http://webkit.org/b/47552> <rdar://problem/8541708>.
1967
1968         Reviewed by Sam Weinig.
1969
1970         * Scripts/build-api-tests: Build TestWebKitAPI.sln on Windows.
1971
1972         * Scripts/run-api-tests: Fix the PATH so that TestWebKitAPI can be
1973         run on Windows.
1974         (runTest): Added code to run TestWebKitAPI.exe on Windows and to die
1975         on unsupported platforms.
1976         (populateTests): Added code to run TestWebKitAPI.exe on Windows and to
1977         die on other platforms. Extracted some formerly-Mac-specific code to
1978         be cross-platform and made it handle any style of line-endings.
1979
1980         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added.
1981         Links against CFLite.
1982
1983         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added.
1984         Contains most properties for the project.
1985
1986         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops:
1987         Added. Links against CoreFoundation.
1988
1989         * TestWebKitAPI/TestWebKitAPIPrefix.h: Added a Windows-specific
1990         section and moved the cross-platform section after the
1991         platform-specific parts.
1992
1993         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Added.
1994         (TestWebKitAPI::Util::run): Runs a normal message pump until we're
1995         done.
1996         (TestWebKitAPI::Util::cf): Turns a UTF-8 C string into a CFString.
1997         (TestWebKitAPI::Util::createURLForResource): Uses CFBundle to get the
1998         resource path.
1999         (TestWebKitAPI::Util::URLForNonExistentResource): Creates a bogus
2000         WKURL.
2001
2002         * TestWebKitAPI/win/PlatformWebViewWin.cpp: Added.
2003         (TestWebKitAPI::registerWindowClass):
2004         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2005         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2006         (TestWebKitAPI::PlatformWebView::page):
2007         This was mostly copied from WebKitTestRunner's PlatformWebView.
2008
2009         * TestWebKitAPI/win/TestWebKitAPI.sln: Added. Builds both
2010         TestWebKitAPI and TestWebKitAPIGeneratd. This is used by the
2011         build-api-tests script.
2012
2013         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added. Builds
2014         TestWebKitAPI.exe.
2015
2016         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added. Just calls
2017         through to copy-resources.cmd.
2018
2019         * TestWebKitAPI/win/copy-resources.cmd: Added. Copies resources into
2020         or deletes resources from TestWebKitAPI.resources.
2021
2022         * TestWebKitAPI/win/main.cpp: Added.
2023         (main): Calls through to TestsController.
2024
2025 2010-10-13  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2026
2027         Reviewed by Kenneth Rohde Christiansen.
2028
2029         [EFL] Support viewport configuration and add new arguments for WebKit EFL
2030         https://bugs.webkit.org/show_bug.cgi?id=47084
2031
2032         Opera spec regarding to viewport meta tag was adjusted to WebCore. So, EFL port
2033         needs to be modified according to the changes.
2034
2035         * EWebLauncher/main.c:
2036         (on_viewport_changed):
2037
2038 2010-10-12  Dirk Pranke  <dpranke@chromium.org>
2039
2040         Reviewed by Eric Seidel.
2041
2042         This patch enables new-run-webkit-tests (in particular the
2043         chromium-win port) to run under Cygwin as well as Win32. Mostly
2044         this just required some conversions from cygwin paths to Win32
2045         paths when we spawn off Win32 binaries like test_shell.
2046
2047         https://bugs.webkit.org/show_bug.cgi?id=47220
2048
2049         * Scripts/webkitpy/common/system/path.py:
2050         - Expose the cygpath() function for path conversion
2051
2052         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2053         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2054         - shift filename->uri conversion in the TestInfo objects to the
2055           dump_render_tree thread
2056
2057         * Scripts/webkitpy/layout_tests/port/base.py:
2058         * Scripts/webkitpy/layout_tests/port/chromium.py:
2059         - use cygpath()
2060
2061 2010-10-12  Yuta Kitamura  <yutak@chromium.org>
2062
2063         Unreviewed. Add Yuta Kitamura (yutak) to the committers list.
2064
2065         * Scripts/webkitpy/common/config/committers.py:
2066
2067 2010-10-12  Sam Weinig  <sam@webkit.org>
2068
2069         Reviewed by Dan Bernstein.
2070
2071         When a provisional load fails, the provisional URL returned
2072         from WKFrameCopyProvisionalURL should be empty
2073         <rdar://problem/8540878>
2074         https://bugs.webkit.org/show_bug.cgi?id=47546
2075
2076         Add test.
2077
2078         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
2079         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
2080
2081 2010-10-12  Anders Carlsson  <andersca@apple.com>
2082
2083         Reviewed by Sam Weinig.
2084
2085         Start fleshing out find page overlays
2086         https://bugs.webkit.org/show_bug.cgi?id=47559
2087
2088         * MiniBrowser/mac/BrowserWindowController.m:
2089         (-[BrowserWindowController find:]):
2090         Pass kWKFindOptionsShowOverlay to WKPageFindString.
2091
2092 2010-10-12  Robert Hogan  <robert@webkit.org>
2093
2094         Reviewed by Antonio Gomes.
2095
2096         [Qt] editing/input/emacs-ctrl-o.html
2097
2098         ctrl-o is bound to a sequence of commands on Mac, namely:
2099         insertParagraphSeparator then moveLeft. In the DRT, we just interpret
2100         ctrl-o in EventSenderQt as '\n', i.e. insertParagraphSeparator. As a
2101         result we only issue one command, so don't generate the change in caret
2102         position that results in the extra editing delegate messages.
2103
2104         So for the sake of not managing suspicious-looking differences, just
2105         make DRT issue the appropriate edit commands to pass the test.
2106
2107         https://bugs.webkit.org/show_bug.cgi?id=47548
2108
2109         * DumpRenderTree/qt/EventSenderQt.cpp:
2110         (EventSender::keyDown):
2111
2112 2010-10-12  Anders Carlsson  <andersca@apple.com>
2113
2114         Reviewed by Sam Weinig.
2115
2116         Add a simple Find UI to MiniBrowser
2117         https://bugs.webkit.org/show_bug.cgi?id=47553
2118
2119         * MiniBrowser/mac/BrowserWindow.xib:
2120         Add Find panel.
2121
2122         * MiniBrowser/mac/BrowserWindowController.h:
2123         * MiniBrowser/mac/BrowserWindowController.m:
2124         (-[BrowserWindowController performFindPanelAction:]):
2125         Show the find panel.
2126
2127         (-[BrowserWindowController find:]):
2128         Tell the WKPageRef to find the given string.
2129
2130 2010-10-12  Tony Chang  <tony@chromium.org>
2131
2132         Unreviewed, fixing DRT compile on Windows after r69586.
2133
2134         * DumpRenderTree/chromium/WebThemeEngineDRT.h:
2135
2136 2010-10-12  Tony Chang  <tony@chromium.org>
2137
2138         Unreviewed, trying to fix NRWT on Windows.
2139
2140         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2141
2142 2010-10-12  Balazs Kelemen  <kbalazs@webkit.org>
2143
2144         Reviewed by Kenneth Rohde Christiansen.
2145
2146         [Qt][WTR] Checking the path of the injected bundle is bogus
2147         https://bugs.webkit.org/show_bug.cgi?id=47541
2148
2149         * WebKitTestRunner/qt/TestControllerQt.cpp:
2150         (WTR::isExistingLibrary): Added (static helper).
2151         Extend the path with the appropriate suffix(es) on the
2152         platform and check that the file exists.
2153         (WTR::TestController::initializeInjectedBundlePath):
2154         There were two bugs with the path checking:
2155             - the condition should have been inverted
2156             - QLibrary::fileName does not give back the filename
2157               with the library suffix so we cannot check
2158               that existance of the file this way.
2159
2160 2010-10-12  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2161
2162         Reviewed by Tony Chang.
2163
2164         Implement http locking in NRWT.
2165         https://bugs.webkit.org/show_bug.cgi?id=47072
2166
2167         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2168         * Scripts/webkitpy/layout_tests/port/base.py:
2169         * Scripts/webkitpy/layout_tests/port/http_lock.py: Added.
2170         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py: Added.
2171         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2172
2173 2010-10-12  Mark Rowe  <mrowe@apple.com>
2174
2175         Fix the 32-bit WebKit2 build.
2176
2177         * MiniBrowser/mac/BrowserWindowController.m:
2178         (getWindowFrame): Use NSRect rather than CGRect since that's what -frame returns.
2179         (setWindowFrame): Use NSMakeRect rather than CGRectMake since that's what -setFrame:display: expects.
2180
2181 2010-10-11  Tony Chang  <tony@chromium.org>
2182
2183         Reviewed by Adam Barth.
2184
2185         change the order of mrobinson's email addresses so bugs.webkit.org suggests the right one
2186         https://bugs.webkit.org/show_bug.cgi?id=47513
2187
2188         bugs.webkit.org suggests mrobinson@igalia.com as an autocomplete,
2189         which doesn't actually work.
2190
2191         * Scripts/webkitpy/common/config/committers.py:
2192
2193 2010-10-11  Prasad Tammana  <prasadt@chromium.org>
2194
2195         Reviewed by Dmitry Titov.
2196
2197         Added support for showModalDialog on chromium port.
2198
2199         Implement showModalDialog for Layout tests for chromium port
2200         https://bugs.webkit.org/show_bug.cgi?id=46759
2201
2202         * DumpRenderTree/chromium/WebViewHost.cpp:
2203         (WebViewHost::closeWidgetSoon): Quit current message loop if in a modal loop.
2204         (WebViewHost::runModal):  Start a nested message loop and remember that.
2205         (WebViewHost::WebViewHost):  Initialize m_inModalLoop.
2206         * DumpRenderTree/chromium/WebViewHost.h:  Add m_inModalLoop.
2207
2208 2010-10-11  Martin Robinson  <mrobinson@igalia.com>
2209
2210         Reviewed by Gustavo Noronha Silva.
2211
2212         [GTK] Cleanup font selection code for the Freetype backend
2213         https://bugs.webkit.org/show_bug.cgi?id=47503
2214
2215         Update DRT to set values for the cursive and fantasy font families, so
2216         that we can generate consistent results for tests that use these families.
2217         Add some missing information to fonts.conf.
2218
2219         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2220         (resetDefaultsToConsistentValues): Always set the fantasy and cursive font
2221         family names.
2222         * DumpRenderTree/gtk/fonts/fonts.conf: Add aliases for cursive and fantasy fonts
2223         to our default serif font. Eventually we may want to import or require some "real"
2224         fonts, but this should at least ensure consistent rendering during test runs. Also
2225         add aliases for some other commonly used fonts in tests (Arial and Lucida Grande).
2226         Finally, add a missing oblique specification for DejaVu Serif, which was resulting
2227         in some incorrect baselines for the synthetic oblique test.
2228
2229 2010-10-11  Adam Barth  <abarth@webkit.org>
2230
2231         Unreviewed.
2232
2233         Fix sheriffbot not to crash when there are failing tests.  It turns out
2234         Python sets don't support the + operator.  We need to use union
2235         instead.  There's a more elegant way to do this in Python 2.6, but we
2236         need this code to work in 2.5.
2237
2238         * Scripts/webkitpy/common/net/failuremap.py:
2239         * Scripts/webkitpy/common/net/failuremap_unittest.py:
2240
2241 2010-10-10  Robert Hogan  <robert@webkit.org>
2242
2243         Unreviewed, fix failing test from r69468.
2244
2245         [Qt] Put all DRT-created pages in a page group
2246
2247         Fix on r69468.
2248
2249         Because we don't delete closed pages immediately in DRT we need
2250         to remove them from the page group explicitly instead.
2251
2252         Fixes failure of fast/events/popup-blocked-from-fake-user-gesture.html
2253
2254         https://bugs.webkit.org/show_bug.cgi?id=47469
2255
2256         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2257         (WebCore::DumpRenderTree::windowCloseRequested):
2258
2259 2010-10-10  Leandro Pereira  <leandro@profusion.mobi>
2260
2261         Reviewed by Adam Barth.
2262
2263         commit-queue: Add EFL-EWS status bubble to Bugzilla, now that the
2264         EFL-EWS bot is up and running.
2265         https://bugs.webkit.org/show_bug.cgi?id=47277
2266
2267         * QueueStatusServer/handlers/statusbubble.py:
2268
2269 2010-10-10  Robert Hogan  <robert@webkit.org>
2270
2271         Reviewed by Antonio Gomes.
2272
2273         [Qt] Put all DRT-created pages in a page group
2274
2275         https://bugs.webkit.org/show_bug.cgi?id=47469
2276
2277         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2278         (WebCore::DumpRenderTree::DumpRenderTree):
2279         (WebCore::DumpRenderTree::createWindow):
2280
2281 2010-10-09  Sam Weinig  <sam@webkit.org>
2282
2283         Reviewed by Dan Bernstein.
2284
2285         WKFrameGetFrameLoadState() returns kWKFrameLoadStateCommitted after the load has been stopped
2286         <rdar://problem/8173667>
2287         https://bugs.webkit.org/show_bug.cgi?id=47461
2288
2289         * TestWebKitAPI/PlatformUtilities.h:
2290         * TestWebKitAPI/Test.h:
2291         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2292         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp: Added.
2293         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
2294         (TestWebKitAPI::TEST):
2295         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2296         (TestWebKitAPI::Util::URLForNonExistentResource):
2297         Adds a test for the frame load state after a failed provisional load. I wanted to test
2298         the frame load state after a committed load failed, but I don't believe that is possible
2299         to do without hooking up the http server to serve a long loading page.
2300
2301 2010-10-09  Sam Weinig  <sam@webkit.org>
2302
2303         Reviewed by Dan Bernstein.
2304
2305         Add WebKit2 version of runBeforeUnloadConfirmPanelWithMessage
2306         <rdar://problem/8447690>
2307         https://bugs.webkit.org/show_bug.cgi?id=47459
2308
2309         * MiniBrowser/mac/BrowserWindowController.m:
2310         (runBeforeUnloadConfirmPanel):
2311         (-[BrowserWindowController awakeFromNib]):
2312         * WebKitTestRunner/TestController.cpp:
2313         (WTR::createOtherPage):
2314         (WTR::TestController::initialize):
2315
2316 2010-10-09  Sam Weinig  <sam@webkit.org>
2317
2318         Reviewed by Dan Bernstein.
2319
2320         Need implementation of ChromeClient windowRect related functions.
2321         <rdar://problem/8469476>
2322         https://bugs.webkit.org/show_bug.cgi?id=47386
2323
2324         * MiniBrowser/mac/BrowserWindowController.m:
2325         (getWindowFrame):
2326         (setWindowFrame):
2327         (-[BrowserWindowController awakeFromNib]):
2328         * WebKitTestRunner/PlatformWebView.h:
2329         * WebKitTestRunner/TestController.cpp:
2330         (WTR::TestController::initialize):
2331         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2332         (WTR::PlatformWebView::windowFrame):
2333         (WTR::PlatformWebView::setWindowFrame):
2334         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2335         (WTR::PlatformWebView::windowFrame):
2336         (WTR::PlatformWebView::setWindowFrame):
2337         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2338         (WTR::PlatformWebView::windowFrame):
2339         (WTR::PlatformWebView::setWindowFrame):
2340
2341 2010-10-08  Adam Barth  <abarth@webkit.org>
2342
2343         Unreviewed (Eric is on vacation in this change is trivial).
2344
2345         Add a "clean" command to webkit-patch to clean the working directory
2346         https://bugs.webkit.org/show_bug.cgi?id=47436
2347
2348         This command is useful when using SVN because "svn revert" leaves
2349         unversioned files behind.
2350
2351         * Scripts/webkitpy/tool/commands/download.py:
2352
2353 2010-10-08  Andras Becsi  <abecsi@webkit.org>
2354
2355         Unreviewed build fix.
2356
2357         [Qt] Add missing limits.h include since the Qt version currently
2358         ran on the bot does need that.
2359
2360         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2361
2362 2010-10-08  Balazs Kelemen  <kbalazs@webkit.org>
2363
2364         Reviewed by Csaba Osztrogonác.
2365
2366         [Qt] Turn on building WTR
2367         https://bugs.webkit.org/show_bug.cgi?id=47349
2368
2369         * Scripts/webkitdirs.pm:
2370
2371 2010-10-08  Balazs Kelemen  <kbalazs@webkit.org>
2372
2373         Reviewed by Andreas Kling.
2374
2375         [Qt] TestController needs its platform dependent methods
2376         https://bugs.webkit.org/show_bug.cgi?id=47413
2377
2378         * WebKitTestRunner/qt/TestControllerQt.cpp:
2379         (WTR::TestController::initializeInjectedBundlePath):
2380         If the WTR_INJECTEDBUNDLE_PATH environmental variable is
2381         set then use that otherwise use the path where the bundle
2382         lives in a normal trunk build.
2383         (WTR::TestController::initializeTestPluginDirectory):
2384         Set the bundle's value. It is not used currently.
2385         (WTR::TestController::platformInitializeContext):
2386         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2387
2388 2010-10-08  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2389
2390         Reviewed by Kenneth Rohde Christiansen.
2391
2392         WTR: Prevent sending the Done message twice on test timeout.
2393         https://bugs.webkit.org/show_bug.cgi?id=47410
2394
2395         When InjectedBundle::done() calls stopLoading, this may trigger
2396         InjectedBundlePage::didFailLoadWithErrorForFrame which calls
2397         InjectedBundle::done() itself later in the stack.
2398         This would output the timeout failure message twice and confuse
2399         the run-webkit-tests script.
2400
2401         This patch adds a third state, Stopping, which prevents WebCore
2402         errors to trigger done() when testing is over.
2403
2404         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2405         (WTR::InjectedBundle::done):
2406         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2407
2408 2010-10-08  Andras Becsi  <abecsi@webkit.org>
2409
2410         Reviewed by Kenneth Rohde Christiansen.
2411
2412         [Qt] Add an activateFonts() implementation similar to DRT's initializeFonts().
2413         Original code by Simon Hausmann.
2414         https://bugs.webkit.org/show_bug.cgi?id=47402
2415
2416         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: Added.
2417         (WTR::activateFonts):
2418
2419 2010-10-08  Andras Becsi  <abecsi@webkit.org>
2420
2421         Reviewed by Csaba Osztrogonác.
2422
2423         [Qt] Add support for Qt's WebKitTestRunner to old-run-webkit-tests.
2424         https://bugs.webkit.org/show_bug.cgi?id=47401
2425
2426         * Scripts/build-webkittestrunner:
2427         * Scripts/old-run-webkit-tests:
2428
2429 2010-10-07  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2430
2431         Reviewed by Kenneth Rohde Christiansen.
2432
2433         [Qt] WTR first compile: fix compile issues.
2434         https://bugs.webkit.org/show_bug.cgi?id=47343
2435
2436         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
2437         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2438         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2439         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2440         * WebKitTestRunner/TestController.cpp:
2441         * WebKitTestRunner/TestInvocation.cpp:
2442
2443 2010-10-07  Antonio Gomes  <agomes@rim.com>
2444
2445         Reviewed by Simon Fraser.
2446
2447         [Mac] [DRT] implement setSpatialNavigationEnabled
2448         https://bugs.webkit.org/show_bug.cgi?id=47291
2449
2450         Implemented LayoutTestController::setSpatialNavigationEnabled for Mac's DRT
2451         so it can track regression on the existing implementation and future improvements
2452         we are making.
2453
2454         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2455         (LayoutTestController::setSpatialNavigationEnabled):
2456
2457 2010-10-07  Dirk Pranke  <dpranke@chromium.org>
2458
2459         Reviewed by Adam Barth.
2460
2461         rebaseline-chromium-webkit-tests relied on the filename_to_uri()
2462         hook in the Port infrastructure to generate URIs for the files
2463         in its summary HTML report; however, that method is supposed to only
2464         be used for test files (and should really be renamed), so this would
2465         crash.
2466
2467         This change adds a new "path" module to the system package with a
2468         routine called abspath_to_uri() that handles converting paths to
2469         file: URIs independently of anything in the layout_tests package,
2470         and changes the code to use this. At some point in the near future
2471         the layout_tests/port/* code should use this as well.
2472
2473         This change also deletes a bunch of unused code and fixes some
2474         comments in rebaseline_chromium_webkit_tests.py.
2475
2476         https://bugs.webkit.org/show_bug.cgi?id=47319
2477
2478         * Scripts/webkitpy/common/system/path.py: Added.
2479         * Scripts/webkitpy/common/system/path_unittest.py: Added.
2480         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2481         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2482
2483 2010-10-07  Martin Robinson  <mrobinson@igalia.com>
2484
2485         Reviewed by Gustavo Noronha Silva.
2486
2487         [GTK] The FreeType backend does not respect the FC_EMBOLDEN property
2488         https://bugs.webkit.org/show_bug.cgi?id=46216
2489
2490         Fix my latest commit, as it contained some bad changes from a merge gone wrong.
2491
2492         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2493         (initializeFonts): Also initialize the DevaVu Sans font.
2494
2495 2010-10-07  Daniel Cheng  <dcheng@chromium.org>
2496
2497         Reviewed by Tony Chang.
2498
2499         [chromium] Minor naming cleanup in WebDragData, part 2
2500         https://bugs.webkit.org/show_bug.cgi?id=47227
2501
2502         Update DRT to use the renamed methods.
2503
2504         * DumpRenderTree/chromium/EventSender.cpp:
2505         (EventSender::beginDragWithFiles):
2506         * DumpRenderTree/chromium/WebViewHost.cpp:
2507         (addDRTFakeFileToDataObject):
2508
2509 2010-10-07  Anders Carlsson  <andersca@apple.com>
2510
2511         Reviewed by Sam Weinig.
2512
2513         Add a WKPageFindClient, hook up WKPageCountStringMatches
2514         https://bugs.webkit.org/show_bug.cgi?id=47373
2515
2516         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2517         Remove hard coded paths.
2518
2519         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
2520         (TestWebKitAPI::TEST):
2521         Fix expected result.
2522
2523         * TestWebKitAPI/Tests/WebKit2/Find.cpp: Added.
2524         (TestWebKitAPI::didFinishLoadForFrame):
2525         (TestWebKitAPI::didCountStringMatches):
2526         (TestWebKitAPI::TEST):
2527         * TestWebKitAPI/Tests/WebKit2/find.html: Added.
2528         Add test for WKPageCountStringMatches.
2529
2530 2010-09-21  Martin Robinson  <mrobinson@igalia.com>
2531
2532         Reviewed by Chris Fleizach.
2533
2534         [GTK] The FreeType backend does not respect the FC_EMBOLDEN property
2535         https://bugs.webkit.org/show_bug.cgi?id=46216
2536
2537         * DumpRenderTree/gtk/fonts/fonts.conf: Add a setting which enables FC_EMBOLDEN
2538         for DejaVu Serif when there is no bold version available. This is necessary to
2539         properly test the property in layout tests.
2540
2541 2010-10-07  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>, Andras Becsi  <abecsi@webkit.org>, Balazs Kelemen  <kbalazs@webkit.org>
2542
2543         Reviewed by Kenneth Rohde Christiansen.
2544
2545         [Qt] Add WTR's InjectedBundle build files.
2546         https://bugs.webkit.org/show_bug.cgi?id=47333
2547
2548         * Scripts/webkitdirs.pm:
2549         * WebKitTestRunner/DerivedSources.pro: Added.
2550         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Added.
2551         * WebKitTestRunner/WebKitTestRunner.pro: Added.
2552         * WebKitTestRunner/qt/DerivedSources.pro: Removed.
2553         Content merged in ../DerivedSources.pro
2554
2555 2010-10-07  Sheriff Bot  <webkit.review.bot@gmail.com>
2556
2557         Unreviewed, rolling out r69315.
2558         http://trac.webkit.org/changeset/69315
2559         https://bugs.webkit.org/show_bug.cgi?id=47363
2560
2561         Forgot to add the new files (Requested by kbalazs on #webkit).
2562
2563         * Scripts/webkitdirs.pm:
2564         * WebKitTestRunner/qt/DerivedSources.pro: Added.
2565
2566 2010-10-07  Sam Weinig  <sam@webkit.org>
2567
2568         Reviewed by Anders Carlsson.
2569
2570         Change API tester to ask the executable for the list of all
2571         tests instead of relying on the directory structure.
2572         https://bugs.webkit.org/show_bug.cgi?id=47359
2573
2574         * Scripts/run-test-webkit-api: Added.
2575         * Scripts/webkitdirs.pm:
2576         Add additional script to just launch the api tester with the correct settings.
2577
2578         * Scripts/run-api-tests:
2579         Change to use the new --dump-tests options to build the list of tests and change
2580         output to reflect a (suite, testcase) tuple for each test. Also adds some color.
2581
2582         * TestWebKitAPI/Test.h:
2583         (TestWebKitAPI::Test::Register::Register):
2584         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
2585         (TestWebKitAPI::TEST):
2586         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
2587         (TestWebKitAPI::TEST):
2588         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
2589         (TestWebKitAPI::TEST):
2590         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2591         (TestWebKitAPI::TEST):
2592         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
2593         (TestWebKitAPI::TEST):
2594         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
2595         (TestWebKitAPI::TEST):
2596         Give each test a suite name in addition to the test name.
2597
2598         * TestWebKitAPI/TestsController.cpp:
2599         (TestWebKitAPI::TestsController::dumpTestNames):
2600         (TestWebKitAPI::TestsController::runTestNamed):
2601         * TestWebKitAPI/TestsController.h:
2602         * TestWebKitAPI/mac/main.mm:
2603         (main):
2604         Add option to print all registered tests.
2605
2606 2010-10-07  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>, Andras Becsi  <abecsi@webkit.org>, Balazs Kelemen  <kbalazs@webkit.org>
2607
2608         Reviewed by Kenneth Rohde Christiansen.
2609
2610         [Qt] Add WTR's InjectedBundle build files.
2611         https://bugs.webkit.org/show_bug.cgi?id=47333
2612
2613         * Scripts/webkitdirs.pm:
2614         * WebKitTestRunner/DerivedSources.pro: Added.
2615         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Added.
2616         * WebKitTestRunner/WebKitTestRunner.pro: Added.
2617         * WebKitTestRunner/qt/DerivedSources.pro: Removed.
2618         Content merged in ../DerivedSources.pro
2619
2620 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
2621
2622         Unreviewed. Do a renaming that was recommended by the reviewer
2623         (Kenneth) but I forgot to do before landing (http://trac.webkit.org/changeset/69253)
2624
2625         * WebKitTestRunner/qt/TestControllerQt.cpp:
2626         (WTR::RunUntilConditionLoop::start):
2627         (WTR::RunUntilConditionLoop::RunUntilConditionLoop):
2628         (WTR::TestController::runUntil):
2629
2630 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
2631
2632         Reviewed by Kenneth Rohde Christiansen.
2633
2634         [Qt] Watchdog timer implementation for WTR
2635         https://bugs.webkit.org/show_bug.cgi?id=47337
2636
2637         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Factor out
2638         the definition of the timer type to a typedef.
2639         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp: Added.
2640         Timer implementation with QTimer and a helper QObject class.
2641         (WTR::WatchdogTimerHelper::instance):
2642         (WTR::WatchdogTimerHelper::timerFired):
2643         (WTR::WatchdogTimerHelper::WatchdogTimerHelper):
2644         (WTR::LayoutTestController::platformInitialize):
2645         (WTR::LayoutTestController::invalidateWaitToDumpWatchdogTimer):
2646         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
2647
2648 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
2649
2650         Unreviewed buildfix for 69297 again
2651
2652         * WebKitTestRunner/TestController.cpp:
2653         (WTR::blankURL):
2654
2655 2010-10-07  Balazs Kelemen  <Balazs Kelemen>
2656
2657         Unreviewed trivial build fix for r69297
2658
2659         * WebKitTestRunner/TestController.cpp:
2660         (WTR::blankURL):
2661
2662 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
2663
2664         Reviewed by Kenneth Rohde Christiansen.
2665
2666         WebKitTestRunner should be portable
2667         https://bugs.webkit.org/show_bug.cgi?id=45393
2668
2669         Use only the WebKit API for working with urls.
2670         * WebKitTestRunner/StringFunctions.h:
2671         (WTR::createWKURL):
2672         * WebKitTestRunner/TestController.cpp:
2673         (WTR::blankURL):
2674         (WTR::TestController::resetStateToConsistentValues):
2675         (WTR::TestController::didFinishLoadForFrame):
2676
2677 2010-10-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2678
2679         Reviewed by Xan Lopez.
2680
2681         [GTK] Use gtk_widget_draw() instead of gtk_widget_get_snapshot() in PixelDumpSupportGtk when building with gtk3
2682         https://bugs.webkit.org/show_bug.cgi?id=47332
2683
2684         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
2685         (createBitmapContextFromWebView):
2686
2687 2010-10-06  Chris Guillory  <chris.guillory@google.com>
2688
2689         Reviewed by Chris Fleizach.
2690
2691         Remove unused accessibility functions from webkit.
2692         https://bugs.webkit.org/attachment.cgi?bugid=46707
2693
2694         * DumpRenderTree/chromium/WebViewHost.cpp:
2695         (WebViewHost::postAccessibilityNotification):
2696         * DumpRenderTree/chromium/WebViewHost.h:
2697
2698 2010-10-06  Lucas Forschler  <lforschler@apple.com>
2699
2700         Reviewed by Adam Roben.
2701
2702         Fix the sunspider-compare-results to actually use the passed in value for $root.
2703
2704         * Scripts/sunspider-compare-results:
2705
2706 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
2707
2708         Reviewed by Kenneth Rohde Christiansen.
2709
2710         [Qt] Runloop implementation for WTR
2711         https://bugs.webkit.org/show_bug.cgi?id=47280
2712
2713         * WebKitTestRunner/qt/TestControllerQt.cpp:
2714         Implemented TestController::runUntil by a timerEvent
2715         and a QEventLoop. We step into the event loop from runUntil.
2716         While we are waiting in the loop a timerEvent is periodically
2717         checking the value of the condition. Once the condition has
2718         becoming true the timerEvent wakes us up.
2719         (WTR::RunUntilLoop::start):
2720         (WTR::RunUntilLoop::RunUntilLoop):
2721         (WTR::RunUntilLoop::run):
2722         (WTR::RunUntilLoop::timerEvent):
2723         (WTR::TestController::platformInitialize):
2724         (WTR::TestController::runUntil):
2725         * WebKitTestRunner/qt/main.cpp:
2726         Start the main event loop first and creating the TestController later.
2727         (Launcher::Launcher):
2728         (Launcher::~Launcher):
2729         (Launcher::launch): Creating the TestController.
2730         (main): Setting up a timer for calling Launcher::launch from
2731         the main event loop.
2732
2733 2010-10-06  Dirk Pranke  <dpranke@chromium.org>
2734
2735         Reviewed by Kenneth Russell.
2736
2737         new-run-webkit-tests: fix typo in chromium-gpu that was trying to
2738         enable 'accelerated-composting' instead of 'accelerated-compositing'.
2739
2740         https://bugs.webkit.org/show_bug.cgi?id=47312
2741
2742         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2743         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2744
2745 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
2746
2747         Reviewed by Kenneth Rohde Christiansen.
2748
2749         [Qt] PlatformWebView implementation for WebKitTestRunner
2750         https://bugs.webkit.org/show_bug.cgi?id=47276
2751
2752         The implementation follows the way how
2753         we use the API in MiniBrowser.
2754         * WebKitTestRunner/PlatformWebView.h:
2755         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2756         (WTR::WebView::wkView):
2757         (WTR::WebView::~WebView):
2758         (WTR::WebView::WebView):
2759         (WTR::PlatformWebView::PlatformWebView):
2760         (WTR::PlatformWebView::~PlatformWebView):
2761         (WTR::PlatformWebView::resizeTo):
2762         (WTR::PlatformWebView::page):
2763         (WTR::PlatformWebView::focus):
2764         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2765
2766 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
2767
2768         Reviewed by Kenneth Rohde Christiansen.
2769
2770         [Qt] Add WebKitTestRunner's build files
2771         https://bugs.webkit.org/show_bug.cgi?id=44155
2772
2773         Parts was taken by Zoltan Horvath's patch.
2774
2775         * Scripts/generate-forwarding-headers.pl: Moved from WebKit2.
2776         * Scripts/webkitdirs.pm: Make the generated files needed by WTR.
2777         * WebKitTestRunner/PlatformWebView.h: Addeed typedefs for
2778         PlatformWKView and PlatformWindow (void* for now).
2779         Buildfix the case when __APPLE__ is not defined.
2780         * WebKitTestRunner/qt/DerivedSources.pro: Added.
2781         * WebKitTestRunner/qt/PlatformWebViewQt.cpp: Added.
2782         Empty stub implementation.
2783         (WTR::registerWindowClass):
2784         (WTR::PlatformWebView::PlatformWebView):
2785         (WTR::PlatformWebView::~PlatformWebView):
2786         (WTR::PlatformWebView::resizeTo):
2787         (WTR::PlatformWebView::page):
2788         (WTR::PlatformWebView::focus):
2789         * WebKitTestRunner/qt/TestControllerQt.cpp: Added.
2790         Empty stub implementation.
2791         (WTR::registerWindowClass):
2792         (WTR::TestController::runUntil):
2793         (WTR::TestController::platformInitialize):
2794         (WTR::TestController::initializeInjectedBundlePath):
2795         (WTR::TestController::initializeTestPluginDirectory):
2796         (WTR::TestController::platformInitializeContext):
2797         * WebKitTestRunner/qt/WebKitTestRunner.pro: Added.
2798         * WebKitTestRunner/qt/main.cpp: Added.
2799         (main):
2800
2801 2010-10-06  Tony Chang  <tony@chromium.org>
2802
2803         Unreviewed, rolling out r69202.
2804         http://trac.webkit.org/changeset/69202
2805         https://bugs.webkit.org/show_bug.cgi?id=46937
2806
2807         Broke compile of test_shell
2808
2809         * DumpRenderTree/chromium/EventSender.cpp:
2810         (EventSender::beginDragWithFiles):
2811         * DumpRenderTree/chromium/WebViewHost.cpp:
2812         (addDRTFakeFileToDataObject):
2813
2814 2010-10-06  Daniel Cheng  <dcheng@chromium.org>
2815
2816         Reviewed by Tony Chang.
2817
2818         [chromium] Minor naming cleanup in WebDragData, part 2
2819         https://bugs.webkit.org/show_bug.cgi?id=46937
2820
2821         Update DRT to use the renamed methods.
2822
2823         * DumpRenderTree/chromium/EventSender.cpp:
2824         (EventSender::beginDragWithFiles):
2825         * DumpRenderTree/chromium/WebViewHost.cpp:
2826         (addDRTFakeFileToDataObject):
2827
2828 2010-10-06  David Kilzer  <ddkilzer@apple.com>
2829
2830         <http://webkit.org/b/47270> Move WebArchive serialization code into its own file
2831
2832         Reviewed by Adam Roben.
2833
2834         This is the first step in making webarchive tests work on
2835         Windows.
2836
2837         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added
2838         new files to the project.
2839         * DumpRenderTree/mac/DumpRenderTree.mm: Removed code that moved
2840         to WebArchiveDumpSupport.mm.
2841         * DumpRenderTree/mac/WebArchiveDumpSupport.h: Added.
2842         * DumpRenderTree/mac/WebArchiveDumpSupport.mm: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm.
2843         (serializeWebArchiveToXML):
2844
2845 2010-10-05  Daniel Bates  <dbates@rim.com>
2846
2847         Reviewed by David Kilzer.
2848
2849         Add infrastructure to towards detecting change log diffs that aren't at the top of the ChangeLog
2850         https://bugs.webkit.org/show_bug.cgi?id=46058
2851
2852         Make VCSUtils::fixChangeLogPatch() return a reference to a hash
2853         structure so as to support returning additional information
2854         about a change log diff.
2855
2856         Currently, VCSUtils::fixChangeLogPatch() returns a string that
2857         represents the change log diff. Towards supporting the return
2858         of additional information, such as whether the change log diff
2859         inserts an entry at the top of the ChangeLog file, we need to
2860         make VCSUtils::fixChangeLogPatch() return a reference to hash
2861         structure.
2862
2863         * Scripts/VCSUtils.pm:
2864           - Modified fixChangeLogPatch() to return a reference to a
2865             hash structure.
2866           - Added documentation to fixChangeLogPatch().
2867           - Modified call site in mergeChangeLogs() as necessary.
2868         * Scripts/svn-apply:
2869           - Modified call site in patch() as necessary.
2870         * Scripts/svn-create-patch:
2871           - Modified call site in generateDiff() as necessary.
2872         * Scripts/svn-unapply:
2873           - Modified call site in patch() as necessary.
2874         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
2875           - Modified the unit tests as necessary.
2876
2877 2010-10-05  Tony Chang  <tony@chromium.org>
2878
2879         Reviewed by Darin Adler.
2880
2881         fix the link to the expected image on windows
2882         https://bugs.webkit.org/show_bug.cgi?id=47228
2883
2884         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: On
2885             windows, the file must be opened in binary mode when writing
2886             binary data.
2887
2888 2010-10-05  Adam Barth  <abarth@webkit.org>
2889
2890         Update expected result of unittest to match Tony's change below.
2891
2892         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2893
2894 2010-10-05  Tony Chang  <tony@chromium.org>
2895
2896         Reviewed by Ojan Vafai (over the shoulder).
2897
2898         Paper over errors in image_diff so we don't crash the whole test run.
2899
2900         * Scripts/webkitpy/layout_tests/port/chromium.py:
2901
2902 2010-10-05  Tony Chang  <tony@chromium.org>
2903
2904         Unreviewed, make shutil.rmtree more resiliant to errors
2905         since windows was raising WindowsError: The process cannot access the file because it
2906         is being used by another process.
2907
2908         * Scripts/webkitpy/layout_tests/port/chromium.py:
2909
2910 2010-10-05  Tony Chang  <tony@chromium.org>
2911
2912         Reviewed by Ojan Vafai.
2913
2914         [chromium] fix image diffing in NRWT
2915         https://bugs.webkit.org/show_bug.cgi?id=47128
2916
2917         * Scripts/webkitpy/layout_tests/port/chromium.py: Stop using
2918             NamedTemporaryFile since it doesn't work on Windows.
2919         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2920
2921 2010-10-05  Kenneth Russell  <kbr@google.com>
2922
2923         Reviewed by Tony Chang.
2924
2925         [chromium] Implement layerTreeAsText in DumpRenderTree
2926         https://bugs.webkit.org/show_bug.cgi?id=47216
2927
2928         Plumbed Frame::layerTreeAsText through Chromium's WebKit API to
2929         make it callable from DumpRenderTree.
2930
2931         No new tests; verified with existing compositor layout tests.
2932
2933         * DumpRenderTree/chromium/LayoutTestController.cpp:
2934         (LayoutTestController::LayoutTestController):
2935         (LayoutTestController::layerTreeAsText):
2936         * DumpRenderTree/chromium/LayoutTestController.h:
2937
2938 2010-10-05  Brent Fulgham  <bfulgham@webkit.org>
2939
2940         Unreviewed build correction.
2941
2942         * DumpRenderTree/win/ImageDiff.vcproj: Use WinCairo debug
2943         property sheet so proper libraries are linked.
2944
2945 2010-10-05  Robert Hogan  <robert@webkit.org>
2946
2947         Reviewed by Andreas Kling.
2948
2949         [Qt] Fix url conversion in QWebHistory
2950
2951         Converting from KURL to WFT::String to QUrl does not
2952         permit proper percent encoding later.
2953
2954         https://bugs.webkit.org/show_bug.cgi?id=47048
2955
2956         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2957         (WebCore::dumpHistoryItem):
2958
2959 2010-10-05  Anders Carlsson  <andersca@apple.com>
2960
2961         Reviewed by Sam Weinig.
2962
2963         REGRESSION (r68966?): All dumpAsText test fail on WebKit2
2964         https://bugs.webkit.org/show_bug.cgi?id=47188
2965         <rdar://problem/8514104>
2966
2967         When constructing the std::string, use the real string length instead of the maximum buffer size.
2968
2969         * TestWebKitAPI/PlatformUtilities.h:
2970         (TestWebKitAPI::Util::toSTD):
2971         * WebKitTestRunner/StringFunctions.h:
2972         (WTR::toSTD):
2973
2974 2010-10-04  Sam Weinig  <sam@webkit.org>
2975
2976         Reviewed by Mark Rowe.
2977
2978         Add MIMEType accessor to WKFrame
2979         <rdar://problem/8347683>
2980         https://bugs.webkit.org/show_bug.cgi?id=47138
2981
2982         * TestWebKitAPI/PlatformUtilities.h:
2983         (TestWebKitAPI::Util::toSTD):
2984         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2985         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp: Added.
2986         (TestWebKitAPI::didStartProvisionalLoadForFrame):
2987         (TestWebKitAPI::didCommitLoadForFrame):
2988         (TestWebKitAPI::didFinishLoadForFrame):
2989         (TestWebKitAPI::TEST):
2990         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp: Added.
2991         (TestWebKitAPI::didStartProvisionalLoadForFrame):
2992         (TestWebKitAPI::didCommitLoadForFrame):
2993         (TestWebKitAPI::didFinishLoadForFrame):
2994         (TestWebKitAPI::TEST):
2995         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2996         (TestWebKitAPI::TEST):
2997         * TestWebKitAPI/Tests/WebKit2/basic-1.html: Removed.
2998         * TestWebKitAPI/Tests/WebKit2/icon.png: Added.
2999         * TestWebKitAPI/Tests/WebKit2/simple.html: Added.
3000         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3001         (TestWebKitAPI::Util::createURLForResource):
3002
3003 2010-10-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3004
3005         Reviewed by Ojan Vafai.
3006
3007         [NRWT] Rename current_dir to current_group because it's not a directory
3008         https://bugs.webkit.org/show_bug.cgi?id=47169
3009
3010         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3011         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3012
3013 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
3014
3015         Unreviewed, build fix.
3016
3017         r69065 broke test-webkitpy by trying to create a '/tmp-X' directory,
3018         which can't always be done. This test uses tempfile.mkdtemp(), which
3019         should be safe.
3020
3021         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3022
3023 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
3024
3025         Unreviewed, build fix.
3026
3027         Add missing "from __future__ import with_statement" that was
3028         breaking test-webkitpy on the Leopard bots (broke in r69040).
3029
3030         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3031
3032 2010-10-04  Sheriff Bot  <webkit.review.bot@gmail.com>
3033
3034         Unreviewed, rolling out r69066.
3035         http://trac.webkit.org/changeset/69066
3036         https://bugs.webkit.org/show_bug.cgi?id=47163
3037
3038         Made NRWT reliability worse. (Requested by tkent on #webkit).
3039
3040         * Scripts/webkitpy/layout_tests/port/chromium.py:
3041         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3042
3043 2010-10-04  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3044
3045         Reviewed by Tony Chang.
3046
3047         [NRWT] Reverse the http tests to alphabetical order.
3048         https://bugs.webkit.org/show_bug.cgi?id=47075
3049
3050         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3051
3052 2010-10-04  Robert Hogan  <robert@webkit.org>
3053
3054         Reviewed by Andreas Kling.
3055
3056         [Qt] Fix timeout on http/tests/navigation/post-goback2.html and postredirect-goback2.html
3057
3058         We need to queue back and forward navigations in the DRT from the
3059         LayoutTestController so that maybeDump() knows about them.
3060
3061         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3062         (LayoutTestController::queueBackNavigation):
3063         (LayoutTestController::queueForwardNavigation):
3064
3065 2010-10-04  Tony Chang  <tony@chromium.org>
3066
3067         Reviewed by Kent Tamura.
3068
3069         [chromium] fix image diffing in NRWT
3070         https://bugs.webkit.org/show_bug.cgi?id=47128
3071
3072         * Scripts/webkitpy/layout_tests/port/chromium.py: Flush data to the
3073               temp file and check the image_diff error code more carefully
3074         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3075
3076 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
3077
3078         Reviewed by Adam Barth.
3079
3080         aroben's change in r68792 actually broke new-run-webkit-tests when
3081         running the DRT code path. His change was intended to fix the
3082         way we were converting windows paths to URIs when running under
3083         Cygwin (the paths were getting one too many "/" on the front).
3084         However, the change ended up breaking the chromium_win port, which
3085         had slightly different logic.
3086
3087         This patch removes the port-specific code and adds tests to make
3088         sure we're getting the behavior we expect. The Port object no longer
3089         exposes a get_absolute_path() method that can be used outside of
3090         of converting test filenames, because it's unreliable otherwise
3091         (we don't have the right context to know which conversion is intended).
3092
3093         https://bugs.webkit.org/show_bug.cgi?id=47140
3094
3095         * Scripts/webkitpy/layout_tests/port/base.py:
3096         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3097         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3098         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3099         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3100
3101 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
3102
3103         Unreviewed, build fix.
3104
3105         Handle crash introduced in r69040 if we are not running in a
3106         Chromium checkout.
3107
3108         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3109
3110 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
3111
3112         Reviewed by Tony Chang.
3113
3114         Add a way for us to have test expectations that are specific to the
3115         official builds of Google Chrome (as opposed to Chromium). This change
3116         looks for an additional "test_expectations_chrome.txt" file in
3117         Chromium's repository (webkit/tools/layout_tests), and uses the
3118         concatenation of that file and the regular test_expectations.txt
3119         file for test overrides.
3120
3121         https://bugs.webkit.org/show_bug.cgi?id=46854
3122
3123         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3124         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3125
3126 2010-10-04  Simon Fraser  <simon.fraser@apple.com>
3127
3128         Color tests in the list based on existing pass/fail result.
3129         
3130         Fix the summary data to account for htmlOnly and nonHTML tests.
3131
3132         * CSSTestSuiteHarness/harness/harness.css:
3133         (#test-list > option.pass):
3134         (#test-list > option.fail):
3135         (#test-list > option.skipped):
3136         * CSSTestSuiteHarness/harness/harness.js:
3137         (Test):
3138         (Test.prototype.statusForFormat):
3139         (TestSuite.prototype.fillTestList):
3140         (TestSuite.prototype.updateTestList):
3141         (TestSuite.prototype.recordResult):
3142         (TestSuite.prototype.markTestCompleted):
3143         (TestSuite.prototype.countTestsWithFlag):
3144         (TestSuite.prototype.queryDatabaseForSummary.this.db.transaction):
3145         (TestSuite.prototype.queryDatabaseForSummary):
3146
3147 2010-10-04  Chris Fleizach  <cfleizach@apple.com>
3148
3149         Reviewed by Beth Dakin.
3150
3151         AX: doAXRangeForLine does not work
3152         https://bugs.webkit.org/show_bug.cgi?id=47101
3153
3154         DRT support to handle NSAccessibilityRangeForLineParameterizedAttribute.
3155
3156         * DumpRenderTree/AccessibilityUIElement.cpp:
3157         (rangeForLineCallback):
3158         (AccessibilityUIElement::rangeForLine):
3159         (AccessibilityUIElement::getJSClass):
3160         * DumpRenderTree/AccessibilityUIElement.h:
3161         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3162         (AccessibilityUIElement::rangeForLine):
3163
3164 2010-10-04  Andrey Kosyakov  <caseq@chromium.org>
3165
3166         Unreviewed. Adding myself to the committers list.
3167
3168         * Scripts/webkitpy/common/config/committers.py:
3169
3170 2010-10-04  Sam Weinig  <sam@webkit.org>
3171
3172         Reviewed by Anders Carlsson.
3173
3174         Add ability to set the CacheModel in Webkit2
3175         https://bugs.webkit.org/show_bug.cgi?id=47066
3176
3177         * MiniBrowser/mac/AppDelegate.m:
3178         (-[BrowserAppDelegate init]): Opt minibrowser into
3179         a PrimaryWebBrowser cache model.
3180
3181 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
3182
3183         Make sure to enter all tests when creating the database
3184         for the first time.
3185         
3186         When migrating to a new version of the suite, be sure to
3187         sync up the database and testinfo.data by removing old
3188         tests, and inserting new ones.
3189
3190         * CSSTestSuiteHarness/harness/harness.js:
3191         (TestSuite.prototype.openDatabase.creation):
3192         (TestSuite.prototype.databaseCreated):
3193         (TestSuite.prototype.populateDatabaseFromTestInfoData):
3194         (TestSuite.prototype.insertTest):
3195
3196 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
3197
3198         More work on treating HTML4 and XHTML1 independently; when 
3199         changing the format, rebuild the test list, and update the 
3200         numbers in the chapter popup.
3201
3202         * CSSTestSuiteHarness/harness/harness.js:
3203         (Test):
3204         (Test.prototype.runForFormat):
3205         (Test.prototype.completedForFormat):
3206         (ChapterSection):
3207         (ChapterSection.prototype.countTests):
3208         (Chapter):
3209         (Chapter.prototype.description):
3210         (Chapter.prototype.countTests):
3211         (Chapter.prototype.testCount):
3212         (Chapter.prototype.untestedCount):
3213         (TestSuite.prototype.buildChapters):
3214         (TestSuite.prototype.loadCurrentTest):
3215         (TestSuite.prototype.updateProgressLabel):
3216         (TestSuite.prototype.processFlags):
3217         (TestSuite.prototype.formatChanged):
3218
3219 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
3220
3221         Update test suite version 20101001.
3222         
3223         Handle database migration, and delete tests from the db that are
3224         not present in testinfo.data.
3225         
3226         Load about:blank into the test frame before the test url, to make
3227         missing tests more obvious.
3228         
3229         * CSSTestSuiteHarness/harness/harness.js:
3230         (TestSuite.prototype.loadTest):
3231         (TestSuite.prototype.openDatabase.creation):
3232         (TestSuite.prototype.openDatabase.migration1_0To1_1):
3233         (TestSuite.prototype.openDatabase.if.return):
3234         (TestSuite.prototype.databaseReady):
3235         (TestSuite.prototype.populateDatabaseFromTestInfoData):
3236         (TestSuite.prototype.syncDatabaseWithTestInfoData.this.db.transaction):
3237         (TestSuite.prototype.syncDatabaseWithTestInfoData):
3238
3239 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
3240
3241         Add the ability to jump to a specific test.
3242
3243         * CSSTestSuiteHarness/harness/harness.html:
3244         * CSSTestSuiteHarness/harness/harness.js:
3245         (TestSuite.prototype.goToTestByName):
3246         (TestSuite.prototype.switchToFormat):
3247
3248 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
3249
3250         For a ref test, load the ref in the same format (HTML4 vs XHTML1)
3251         as the test.
3252
3253         * CSSTestSuiteHarness/harness/harness.js:
3254         (TestSuite.prototype.loadRef):
3255
3256 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
3257
3258         Update the UI to reflect the fact that each test needs to be tested
3259         in both HTML4 and XHTML1 format.
3260         
3261         * CSSTestSuiteHarness/harness/harness.js:
3262         (Test):
3263         (Chapter.prototype.description):
3264         (Chapter.prototype.untestedCount):
3265         (TestSuite.prototype.fillChapterPopup):
3266         (TestSuite.prototype.updateChapterPopup):
3267         (TestSuite.prototype.fillTestList):
3268         (TestSuite.prototype.updateTestList):
3269         (TestSuite.prototype.goToNextIncompleteTest):
3270         (TestSuite.prototype.firstIncompleteTestIndex):
3271         (TestSuite.prototype.recordResult):
3272         (TestSuite.prototype.formatChanged):
3273         (TestSuite.prototype.markTestCompleted):
3274         (TestSuite.prototype.resetTestStatus):
3275
3276 2010-10-01  Simon Fraser  <simon.fraser@apple.com>
3277
3278         Add the ability to remove results for re-testing, and
3279         to import results.
3280
3281         * CSSTestSuiteHarness/harness/harness.css:
3282         (.custom button):
3283         (#overlay):
3284         (#overlay.visible):
3285         (.overlay-contents):
3286         (.overlay-contents textarea):
3287         (.overlay-contents .buttons):
3288         (.overlay-contents .note):
3289         (.overlay-contents .buttons button):
3290         * CSSTestSuiteHarness/harness/harness.html:
3291         * CSSTestSuiteHarness/harness/harness.js:
3292         (TestSuite.prototype.importResults):
3293         (TestSuite.prototype.clearResults):
3294         (TestSuite.prototype.markTestCompleted):
3295         (TestSuite.prototype.resetTestStatus):
3296         (TestSuite.prototype.storeTestResult):
3297         (TestSuite.prototype.importTestResults):
3298         (TestSuite.prototype.clearTestResults):
3299
3300 2010-10-01  Sam Weinig  <sam@webkit.org>
3301
3302         Reviewed by Jon Honeycutt.
3303
3304         Deploy the new WKString functions to remove most uses of CF from
3305         the WebKitTestRunner.
3306
3307         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3308         (WTR::InjectedBundle::didReceiveMessage):
3309         (WTR::InjectedBundle::done):
3310         * WebKitTestRunner/StringFunctions.h:
3311         (WTR::toWK):
3312         (WTR::toJS):
3313         (WTR::toSTD):
3314         (WTR::operator<<):
3315         (WTR::copyURLString):
3316         * WebKitTestRunner/TestController.cpp:
3317         (WTR::TestController::resetStateToConsistentValues):
3318         (WTR::TestController::didFinishLoadForFrame):
3319         * WebKitTestRunner/TestInvocation.cpp:
3320         (WTR::TestInvocation::invoke):
3321         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3322
3323 2010-10-01  Mihai Parparita  <mihaip@chromium.org>
3324
3325         Unreviewed TestResultsServer change.
3326
3327         Add files introduced by http://crrev.com/61273 to the list of dashboard 
3328         files to update.
3329
3330         * TestResultServer/handlers/dashboardhandler.py:
3331
3332 2010-10-01  Brian Weinstein  <bweinstein@apple.com>
3333
3334         Build Fix for Windows.
3335
3336         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Don't copy ForwardingHeaders from
3337             WebKitTestRunner/ForwardingHeaders, instead, add $(WebKitOutputDir)/include/WebCore/
3338             ForwardingHeaders to the include path.
3339
3340 2010-10-01  Sam Weinig  <sam@webkit.org>
3341
3342         Reviewed by Anders Carlsson.
3343
3344         Add SPI to convert a WKStringRef to a JSStringRef and vice-versa.
3345
3346         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3347         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
3348         (TestWebKitAPI::TEST):
3349         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp: Added.
3350         (TestWebKitAPI::TEST):
3351
3352 2010-10-01  Sam Weinig  <sam@webkit.org>
3353
3354         Reviewed by Kenneth Rohde Christiansen.
3355
3356         Add additional WKString API
3357         https://bugs.webkit.org/show_bug.cgi?id=46958
3358
3359         Add basic WKStringRef tests.
3360
3361         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3362         * TestWebKitAPI/Tests/WebKit2/WKString.cpp: Added.
3363
3364 2010-10-01  Sam Weinig  <sam@webkit.org>
3365
3366         Reviewed by Dan Bernstein.
3367
3368         Add makefile for TestWebKitAPI and call it from the base makefile.
3369
3370         * Makefile:
3371         * TestWebKitAPI/Makefile: Added.
3372
3373 2010-10-01  Sam Weinig  <sam@webkit.org>
3374
3375         Reviewed by Adam Roben.
3376
3377         Remove unnecessary ForwardingHeaders from test runners.
3378         https://bugs.webkit.org/show_bug.cgi?id=47010
3379
3380         * TestWebKitAPI/Configurations/Base.xcconfig:
3381         * TestWebKitAPI/ForwardingHeaders: Removed.
3382         * WebKitTestRunner/Configurations/Base.xcconfig:
3383         * WebKitTestRunner/ForwardingHeaders: Removed.
3384
3385 2010-09-30  Adam Barth  <abarth@webkit.org>
3386
3387         Reviewed by Eric Seidel.
3388
3389         WebSocket tests are flaky
3390         https://bugs.webkit.org/show_bug.cgi?id=46956
3391
3392         Update these tools to understand how to run the WebSocket tests off the
3393         Apache server.
3394
3395         * Scripts/old-run-webkit-tests:
3396         * Scripts/webkitpy/layout_tests/port/base.py:
3397         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
3398         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3399
3400 2010-10-01  Adam Roben  <aroben@apple.com>
3401
3402         Encode Executive command arguments using UTF-8 on Cygwin
3403
3404         Cygwin's Python's os.execv doesn't support unicode command arguments.
3405         Cygwin's execv expects arguments to be encoded using the current code
3406         page. But code pages are limited in what characters they can handle,
3407         and our tests include characters that the English code page can't
3408         handle.  So for now we'll just encode everything in UTF-8 on Cygwin,
3409         which can handle all characters but might confuse some commands, for
3410         expediency's sake. I'm sure we'll run into cases where UTF-8 isn't
3411         good enough, but we can deal with that when the problem arises.
3412
3413         Reviewed by Adam Barth.
3414
3415         Fixes <http://webkit.org/b/46892> <rdar://problem/8496639>
3416         webkitpy.common.system.executive_unittest.ExecutiveTest.test_run_command_with_unicode
3417         fails on Windows
3418
3419         * Scripts/webkitpy/common/system/executive.py:
3420         (Executive._run_command_with_teed_output):
3421         (Executive.run_command):
3422         On Cygwin, encode arguments using UTF-8.
3423
3424 2010-10-01  Sam Weinig  <sam@webkit.org>
3425
3426         Reviewed by Adam Roben.
3427
3428         Add simple API tester for WebKit2
3429         https://bugs.webkit.org/show_bug.cgi?id=46953
3430
3431         This adds a very simple testing infrastructure for testing APIs exposed
3432         through the WebKit project. It consists of two parts: 1) a project that
3433         builds the all the tests 2) a script that searches the tests directory and
3434         calls the tester once for each test.
3435
3436         This adds the infrastructure and two tests:
3437         - Tests/WTF/Vector1.cpp - A proof of concept test of WTF data-structures.
3438         - Tests/WebKit2/BasicTest1.cpp - A proof of concept test of WebKit2 API.
3439
3440         This currently only works on the mac, but is designed to be easily ported 
3441         to any platform.
3442
3443         * Scripts/run-api-tests: Added.
3444         * Scripts/build-api-tests: Added.
3445         Scripts to build/run the tests.
3446
3447         * TestWebKitAPI: Added.
3448         * TestWebKitAPI/Configurations: Added.
3449         * TestWebKitAPI/Configurations/Base.xcconfig: Added.
3450         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Added.
3451         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Added.
3452         * TestWebKitAPI/ForwardingHeaders: Added.
3453         * TestWebKitAPI/ForwardingHeaders/wtf: Added.
3454         * TestWebKitAPI/PlatformUtilities.h: Added.
3455         * TestWebKitAPI/PlatformWebView.h: Added.
3456         (TestWebKitAPI::PlatformWebView::platformView):
3457         * TestWebKitAPI/StringFunctions.h: Added.
3458         * TestWebKitAPI/Test.h: Added.
3459         (TestWebKitAPI::Test::~Test):
3460         (TestWebKitAPI::Test::name):
3461         (TestWebKitAPI::Test::Register::Register):
3462         (TestWebKitAPI::Test::Register::create):
3463         (TestWebKitAPI::Test::Test):
3464         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Added.
3465         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added.
3466         * TestWebKitAPI/TestWebKitAPIPrefix.h: Added.
3467         * TestWebKitAPI/TestsController.cpp: Added.
3468         (TestWebKitAPI::TestsController::shared):
3469         (TestWebKitAPI::TestsController::TestsController):
3470         (TestWebKitAPI::TestsController::runTestNamed):
3471         (TestWebKitAPI::TestsController::testFailed):
3472         (TestWebKitAPI::TestsController::registerCreateTestFunction):
3473         * TestWebKitAPI/TestsController.h: Added.
3474         * TestWebKitAPI/mac: Added.
3475         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm: Added.
3476         (TestWebKitAPI::Util::run):
3477         (TestWebKitAPI::Util::createURLForResource):
3478         * TestWebKitAPI/mac/PlatformWebViewMac.mm: Added.
3479         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3480         (TestWebKitAPI::PlatformWebView::resizeTo):
3481         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
3482         (TestWebKitAPI::PlatformWebView::page):
3483         (TestWebKitAPI::PlatformWebView::focus):
3484         * TestWebKitAPI/mac/main.mm: Added.
3485         Infrastructure.
3486
3487         * TestWebKitAPI/Tests: Added.
3488         * TestWebKitAPI/Tests/WTF: Added.
3489         * TestWebKitAPI/Tests/WTF/Vector1.cpp: Added.
3490         * TestWebKitAPI/Tests/WebKit2: Added.
3491         * TestWebKitAPI/Tests/WebKit2/BasicTest1.cpp: Added.
3492         (TestWebKitAPI::State::State):
3493         * TestWebKitAPI/Tests/WebKit2/basic-1.html: Added.
3494         Proof of concept tests.
3495
3496 2010-10-01  Adam Roben  <aroben@apple.com>
3497
3498         Don't assume AccessibleObjectFromEvent succeeds
3499
3500         Fixes <http://webkit.org/b/44136> <rdar://problem/8321684> Crash in
3501         DumpRenderTree!notificationListenerProc when running
3502         plugins/access-after-page-destroyed.html
3503
3504         Reviewed by Sam Weinig.
3505
3506         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3507         (notificationListenerProc): Check both the return value of
3508         AccessibleObjectFromEvent and the object it returns, as MSDN
3509         recommends.
3510
3511 2010-10-01  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3512
3513         Reviewed by Tony Chang.
3514
3515         [NRWT] Put the http and websocket tests first in the test list.
3516         https://bugs.webkit.org/show_bug.cgi?id=46453
3517
3518         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3519         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3520
3521 2010-10-01  Fady Samuel  <fsamuel@chromium.org>
3522
3523         Unreviewed, adding myself to the committer list.
3524
3525         * Scripts/webkitpy/common/config/committers.py:
3526
3527 2010-10-01  Adam Roben  <aroben@apple.com>
3528
3529         Test NPN_GetValue(NPNVnetscapeWindow)
3530
3531         Test for <http://webkit.org/b/46726> <rdar://problem/8486319>
3532         Right-clicking on windowless Flash plugin in WebKit2 makes a context
3533         menu appear in the bottom-right corner of the screen
3534
3535         Reviewed by Anders Carlsson.
3536
3537         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3538         (PluginTest::NPN_GetValue): Added. Calls through to the browser.
3539
3540         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added NPN_GetValue.
3541
3542         * DumpRenderTree/TestNetscapePlugIn/Tests/win/GetValueNetscapeWindow.cpp: Added.
3543         (GetValueNetscapeWindow::GetValueNetscapeWindow): Initialize members.
3544         (GetValueNetscapeWindow::NPP_SetWindow): Test that
3545         NPN_GetValue(NPNVnetscapeWindow) returns a valid HWND and that it
3546         isn't our HWND.
3547
3548         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3549         Added GetValueNetscapeWindow.
3550
3551 2010-10-01  Andreas Kling  <andreas.kling@nokia.com>
3552
3553         Unreviewed, adding my webkit.org identity to reviewer list.
3554
3555         * Scripts/webkitpy/common/config/committers.py:
3556
3557 2010-09-30  Adam Barth  <abarth@webkit.org>
3558
3559         Reviewed by Eric Seidel.
3560
3561         The WebSocket server should flush its logs
3562         https://bugs.webkit.org/show_bug.cgi?id=46946
3563
3564         The WebSocket server logs are truncated because the driver just
3565         terminates the child.  It should run Python without buffering so we can
3566         see the end of the log.
3567
3568         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
3569
3570 2010-09-30  Simon Fraser  <simon.fraser@apple.com>
3571
3572         Add a button to jump to the next untested test.
3573         
3574         * CSSTestSuiteHarness/harness/harness.css:
3575         (.test-type):
3576         (.name > button):
3577         * CSSTestSuiteHarness/harness/harness.html:
3578         * CSSTestSuiteHarness/harness/harness.js:
3579         (Chapter.prototype.description):
3580         (Chapter.prototype.untestedCount):
3581         (TestSuite.prototype.testInfoDataLoaded):
3582         (TestSuite.prototype.fillChapterPopup):
3583         (TestSuite.prototype.updateChapterPopup):
3584         (TestSuite.prototype.buildTestListForChapter):
3585         (TestSuite.prototype.goToNextIncompleteTest):
3586         (TestSuite.prototype.firstIncompleteTestIndex):
3587         (TestSuite.prototype.testCompletionStateChanged):
3588
3589 2010-09-29  Jon Honeycutt  <jhoneycutt@apple.com>
3590
3591         WebKit2 on Windows should use Windows fonts for the various standard
3592         font families
3593         https://bugs.webkit.org/show_bug.cgi?id=43499
3594         <rdar://problem/8272758>
3595
3596         Reviewed by Adam Roben.
3597
3598         * WebKitTestRunner/TestController.cpp:
3599         (WTR::TestController::resetStateToConsistentValues):
3600         Use the Mac fonts for running tests. This matches DRT behavior.
3601
3602 2010-09-30  Adam Barth  <abarth@webkit.org>
3603
3604         Third attempt.  We need a better integration test environment.
3605
3606         * Scripts/webkitpy/common/net/failuremap.py:
3607         * Scripts/webkitpy/common/net/failuremap_unittest.py:
3608
3609 2010-09-30  Robert Hogan  <robert@webkit.org>
3610
3611         Reviewed by Andreas Kling.
3612
3613         [Qt] Support for PlainTextController
3614
3615         Unskip editing/text-iterator/basic-iteration.html
3616
3617         https://bugs.webkit.org/show_bug.cgi?id=38805
3618
3619         * DumpRenderTree/qt/DumpRenderTree.pro:
3620         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3621         (WebCore::DumpRenderTree::DumpRenderTree):
3622         (WebCore::DumpRenderTree::initJSObjects):
3623         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3624         * DumpRenderTree/qt/PlainTextControllerQt.cpp: Added.
3625         (PlainTextController::PlainTextController):
3626         (PlainTextController::plainText):
3627         * DumpRenderTree/qt/PlainTextControllerQt.h: Added.
3628
3629 2010-09-30  Adam Barth  <abarth@webkit.org>
3630
3631         Unreviewed.  Second attempt to fix sheriffbot.
3632
3633         * Scripts/webkitpy/common/net/buildbot.py:
3634
3635 2010-09-30  Adam Barth  <abarth@webkit.org>
3636
3637         Unreviewed.
3638
3639         This patch should stop the sheriffbot from throwing an exception.
3640
3641         * Scripts/webkitpy/common/net/buildbot.py:
3642
3643 2010-09-30  Brian Weinstein  <bweinstein@apple.com>
3644
3645         Reviewed by Adam Roben.
3646
3647         The same bots shouldn't run both Windows Debug Tests and Windows Release Tests.
3648         https://bugs.webkit.org/show_bug.cgi?id=46926
3649
3650         * BuildSlaveSupport/build.webkit.org-config/config.json: Have two bots running Windows 
3651             Release Tests, and two bots running Windows Debug Tests, instead of four running both.
3652
3653 2010-09-30  Adam Barth  <abarth@webkit.org>
3654
3655         Reviewed by Eric Seidel.
3656
3657         webkit-patch find-flaky-tests should print results URLs
3658         https://bugs.webkit.org/show_bug.cgi?id=46917
3659
3660         Printing out the results URL makes find-flaky-tests more actionable
3661         because you can see what happens when a test fails.  The output from
3662         the script is still pretty noisy, but it seems useful.
3663
3664         * Scripts/webkitpy/tool/commands/queries.py:
3665
3666 2010-09-30  Chris Marrin  <cmarrin@apple.com>
3667
3668         Reviewed by Simon Fraser.
3669
3670         Make 2D accelerated canvas rendering build on Mac
3671         https://bugs.webkit.org/show_bug.cgi?id=46007
3672         
3673         Added ACCELERATED_2D_CANVAS to build-webkit
3674
3675         * Scripts/build-webkit:
3676
3677 2010-09-29  Kenneth Russell  <kbr@google.com>
3678
3679         Reviewed by Dimitri Glazkov.
3680
3681         [chromium] Add accelerated compositing support to DumpRenderTree and test_shell
3682         https://bugs.webkit.org/show_bug.cgi?id=46849
3683
3684         Added offscreen code path for WebGraphicsContext3DDefaultImpl which
3685         works with the compositor integration in both DumpRenderTree and
3686         test_shell, since both pass a non-null WebCanvas* to WebViewImpl::paint
3687         and thereby trigger the compositor's readback code path. Added support
3688         for --enable-accelerated-compositing to DumpRenderTree.
3689
3690         Tested in both test_shell and DumpRenderTree on Linux, the latter by
3691         modifying a compositing layout test, dumping the pixels and verifying
3692         that they matched the output when the compositor was active.
3693
3694         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3695         (main):
3696         * DumpRenderTree/chromium/TestShell.cpp:
3697         (TestShell::TestShell):
3698         (TestShell::resetWebSettings):
3699         * DumpRenderTree/chromium/TestShell.h:
3700         (TestShell::setAcceleratedCompositingEnabled):
3701         * DumpRenderTree/chromium/WebPreferences.cpp:
3702         (WebPreferences::reset):
3703         (WebPreferences::applyTo):
3704         * DumpRenderTree/chromium/WebPreferences.h:
3705         * DumpRenderTree/chromium/WebViewHost.cpp:
3706         (WebViewHost::scheduleComposite):
3707         * DumpRenderTree/chromium/WebViewHost.h:
3708
3709 2010-09-30  Adam Roben  <aroben@apple.com>
3710
3711         Ensure that QueueEngine cleans up its log files when its delegate
3712         tells it to stop processing work
3713
3714         Reviewed by Adam Barth.
3715
3716         Fixes <http://webkit.org/b/46891> <rdar://problem/8496638> Many tests
3717         in webkitpy.tool.bot.queueengine_unittest.QueueEngineTest crash on
3718         Windows
3719
3720         * Scripts/webkitpy/tool/bot/queueengine.py:
3721         (QueueEngine.run): Stop ourselves normally (including cleaning up log
3722         files) when the delegate tells us to stop processing work.
3723
3724         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
3725         (LoggingDelegate.__init__): Moved code here from
3726         RaisingDelegate.__init__.
3727         (LoggingDelegate.expeced_callbacks): Added the stop_work_queue
3728         callback.
3729         (LoggingDelegate.stop_work_queue): Moved here from RaisingDelegate.
3730         (RaisingDelegate.__init__): Removed code that LoggingDelegate takes
3731         care of for us now.
3732         (QueueEngineTest.test_trivial): Make sure we got the expected stop
3733         message.
3734         (QueueEngineTest.test_not_safe_to_proceed): Changed to explicitly
3735         remove the callbacks that are related to processing a single work
3736         item, rather than removing all callbacks after a certain point, as
3737         there are now more callbacks we expect to receive at the end.
3738
3739 2010-09-30  Adam Roben  <aroben@apple.com>
3740
3741         Fix path -> URL conversion on Cygwin
3742
3743         Reviewed by Adam Barth.
3744
3745         Fixes <http://webkit.org/b/46890> <rdar://problem/8496637> Many tests
3746         in webkitpy.layout_tests.run_webkit_tests_unittest assert on Windows
3747
3748         * Scripts/webkitpy/layout_tests/port/base.py:
3749         (Port.filename_to_uri): Treat Cygwin like other UNIX-y platforms by
3750         assuming paths already have a leading slash.
3751
3752 2010-09-30  Adam Roben  <aroben@apple.com>
3753
3754         Teach WindowGeometryInitializedBeforeSetWindow that NPP_SetWindow can
3755         be called more than once
3756
3757         The NPP_SetWindow call made when the plugin is torn down was confusing
3758         us, and was causing us to spew an error into the next test.
3759
3760         Fixes <http://webkit.org/b/46900> <rdar://problem/8496888> REGRESSION
3761         (r68520): plugins/access-after-page-destroyed.html failing on Windows
3762
3763         Reviewed by Anders Carlsson.
3764
3765         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:
3766         (WindowGeometryInitializedBeforeSetWindow::WindowGeometryInitializedBeforeSetWindow):
3767         Initialize member.
3768         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Bail if
3769         this isn't the first time this is called.
3770
3771 2010-09-30  Eric Seidel  <eric@webkit.org>
3772
3773         Reviewed by Adam Barth.
3774
3775         webkit-patch upload warns that I'm using Xcode when I'm not
3776         https://bugs.webkit.org/show_bug.cgi?id=46869
3777
3778         String.find returns -1 when not found, so switched to "in".
3779
3780         * Scripts/webkitpy/common/system/user.py:
3781         * Scripts/webkitpy/common/system/user_unittest.py:
3782
3783 2010-09-30  Eric Seidel  <eric@webkit.org>
3784
3785         Reviewed by Adam Barth.
3786
3787         webkit-patch failure-reason dies if non-trunk commits are in the blame range
3788         https://bugs.webkit.org/show_bug.cgi?id=46866
3789
3790         I also made failure-reason use RegressionWindow in a cleaner way.
3791
3792         * Scripts/webkitpy/tool/commands/queries.py:
3793
3794 2010-09-29  Adam Barth  <abarth@webkit.org>
3795
3796         Reviewed by Eric Seidel.
3797
3798         webkit-patch find-flaky-tests
3799         https://bugs.webkit.org/show_bug.cgi?id=46876
3800
3801         This command helps us find flaky tests so we can squash them.
3802
3803         * Scripts/webkitpy/tool/commands/queries.py:
3804
3805 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
3806
3807         Fix export to use '?' instead of 'null' for
3808         tests with no results.
3809         
3810         * CSSTestSuiteHarness/harness/harness.js:
3811
3812 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
3813
3814         Add a warning when a test requires special steps.
3815         Add a Print Preview button for 'paged' tests that
3816         brings up the print dialog, allowing the user to 
3817         judge paged media tests.
3818
3819         * CSSTestSuiteHarness/harness/harness.css:
3820         * CSSTestSuiteHarness/harness/harness.html:
3821         * CSSTestSuiteHarness/harness/harness.js:
3822         (TestSuite.prototype.loadTest):
3823         (TestSuite.prototype.processFlags):
3824
3825 2010-09-29  Adam Barth  <abarth@webkit.org>
3826
3827         Reviewed by Eric Seidel.
3828
3829         Remove revisions_casuing_failures
3830         https://bugs.webkit.org/show_bug.cgi?id=46872
3831
3832         This function exists only to be unit tested.
3833
3834         * Scripts/webkitpy/common/net/failuremap.py:
3835         * Scripts/webkitpy/common/net/failuremap_unittest.py:
3836         * Scripts/webkitpy/tool/mocktool.py:
3837
3838 2010-09-29  Adam Barth  <abarth@webkit.org>
3839
3840         Reviewed by Eric Seidel.
3841
3842         SheriffBot should post the list of failing tests to bugs
3843         https://bugs.webkit.org/show_bug.cgi?id=46871
3844
3845         * Scripts/webkitpy/common/net/buildbot.py:
3846         * Scripts/webkitpy/common/net/failuremap.py:
3847         * Scripts/webkitpy/common/net/regressionwindow.py:
3848         * Scripts/webkitpy/tool/bot/sheriff.py:
3849         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
3850         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3851         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3852         * Scripts/webkitpy/tool/commands/sheriffbot.py:
3853         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
3854         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3855         * Scripts/webkitpy/tool/mocktool.py:
3856
3857 2010-09-29  Brent Fulgham  <bfulgham@webkit.org>
3858
3859         Reviewed by Martin Robinson, Eric Seidel, and Mark Rowe.
3860
3861         [WinCairo] Adds a build slave.
3862         https://bugs.webkit.org/show_bug.cgi?id=46360
3863
3864         * BuildSlaveSupport/build.webkit.org-config/config.json: Add
3865         entries for a debug build of the WinCairo port.
3866         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add
3867         platform flag to configuration for wincairo (like gtk, chromium, etc.)
3868         * Scripts/build-webkit: Change 'cairo-win32' labeling to 'wincairo'
3869         * Scripts/webkitdirs.pm: Change 'cairo-win32' labeling to 'wincairo'
3870
3871 2010-09-29  Adam Barth  <abarth@webkit.org>
3872
3873         Reviewed by Eric Seidel.
3874
3875         Move more SheriffBot smarts into FailureMap
3876         https://bugs.webkit.org/show_bug.cgi?id=46703
3877
3878         This patch pushes the FailureMap model object further into the
3879         SheriffBot machine.  In addition, it moves a couple operations on this
3880         object from SheriffBot itself to the model.
3881
3882         Eventually, FailureMap will be the canonical context object for
3883         SheriffBot operations.  FailureMap represents a map of the current
3884         failures on the bots that might require remediation.
3885
3886         * Scripts/webkitpy/common/net/failuremap.py:
3887         * Scripts/webkitpy/common/net/regressionwindow.py:
3888         * Scripts/webkitpy/tool/commands/queries.py:
3889         * Scripts/webkitpy/tool/commands/sheriffbot.py:
3890         * Scripts/webkitpy/tool/mocktool.py:
3891
3892 2010-09-29  Tony Chang  <tony@chromium.org>
3893
3894         Reviewed by James Robinson.
3895
3896         [chromium] enable -Werror for DRT and webkit_unit_tests on Linux
3897         https://bugs.webkit.org/show_bug.cgi?id=46829
3898
3899         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
3900         (DRTDevToolsClient::DRTDevToolsClient):
3901         * DumpRenderTree/chromium/TestShell.cpp:
3902         (TestShell::TestShell):
3903         * DumpRenderTree/chromium/WebViewHost.cpp:
3904         (WebViewHost::postAccessibilityNotification):
3905         (WebViewHost::WebViewHost):
3906
3907 2010-09-29  Chris Fleizach  <cfleizach@apple.com>
3908
3909         Reviewed by Darin Adler.
3910
3911         AX: implement CSS3 Speech "speak"
3912         https://bugs.webkit.org/show_bug.cgi?id=46827
3913
3914         * DumpRenderTree/AccessibilityUIElement.cpp:
3915         (speakCallback):
3916         (AccessibilityUIElement::speak):
3917         (AccessibilityUIElement::getJSClass):
3918         * DumpRenderTree/AccessibilityUIElement.h:
3919         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3920         (AccessibilityUIElement::speak):
3921
3922 2010-09-29  Mihai Parparita  <mihaip@chromium.org>
3923
3924         Reviewed by Adam Barth.
3925
3926         Record bot ID when updating queue status
3927         https://bugs.webkit.org/show_bug.cgi?id=46764
3928         
3929         Since we now have multiple bots handling patches from the commit queue,
3930         we need to differentiate status updates from them, so that we can group
3931         the queue status page in a less confusing way.
3932
3933         * QueueStatusServer/handlers/updatestatus.py: Accept bot_id as input
3934         * QueueStatusServer/model/queuestatus.py: Add bot_id property
3935         * QueueStatusServer/templates/updatestatus.html: Add bot_id input
3936         * Scripts/webkitpy/common/net/bugzilla_unittest.py: Extract MockBrowser
3937         * Scripts/webkitpy/common/net/statusserver.py: Add bot_id
3938         * Scripts/webkitpy/common/net/statusserver_unittest.py: Added.
3939         * Scripts/webkitpy/tool/main.py: Add --bot-id
3940         * Scripts/webkitpy/tool/mocktool.py: Add MockBrowser
3941
3942 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
3943
3944         No review.
3945         
3946         References always refert to a file in .xht format, even
3947         for HTML tests, so fix their loading.
3948
3949         * CSSTestSuiteHarness/harness/harness.js:
3950         (TestSuite.prototype.loadRef):
3951
3952 2010-09-28  Johnny Ding  <jnd@chromium.org>
3953
3954         Reviewed by Adam Barth.
3955
3956         https://bugs.webkit.org/show_bug.cgi?id=41292
3957         Add a new parameter to the test plugin to allow specifying a script 
3958         and a mouse/keyboard event. The specified script will be evaluated
3959         in the browser when the specified event is received by the plugin.
3960
3961         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3962         (pluginAllocate):
3963         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
3964         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3965         (NPP_New):
3966         (handleEventCarbon):
3967         (handleEventCocoa):
3968
3969 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
3970
3971         Fix export by adding missing argument.
3972
3973         * CSSTestSuiteHarness/harness/harness.js:
3974         (TestSuite.prototype.showResultsForAllTests):
3975
3976 2010-09-28  Kevin Ollivier  <kevino@theolliviers.com>
3977
3978         [wx] Build fix, add missing import.
3979
3980         * wx/packaging/build-win-installer.py:
3981
3982 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
3983
3984         No review
3985         
3986         Show which tests have been run by dimming them out in the test list.
3987         
3988         Adjust some element sizes.
3989         
3990         * CSSTestSuiteHarness/harness/harness.css:
3991         (#test-list > option.untested):
3992         (#test-list > option.completed):
3993         (#output):
3994         (.output-options):
3995         * CSSTestSuiteHarness/harness/harness.js:
3996         (Test):
3997         (TestSuite.prototype.fillTestList):
3998         (TestSuite.prototype.updateTestList):
3999         (TestSuite.prototype.setSelectedChapter):
4000         (TestSuite.prototype.recordResult):
4001         (TestSuite.prototype.markTestCompleted):
4002         (TestSuite.prototype.testCompletionStateChanged):
4003         (TestSuite.prototype.loadTestStatus):
4004
4005 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
4006
4007         No review.
4008         
4009         Implement export of various queries on the test database, sharing
4010         code with that which displays results inline.
4011
4012         * CSSTestSuiteHarness/harness/harness.js:
4013         ():
4014         (TestSuite.prototype.exportResultsCompletion.var):
4015         (TestSuite.prototype.exportResultsCompletion):
4016         (TestSuite.prototype.showResultsForCompletedTests):
4017         (TestSuite.prototype.exportResultsForCompletedTests):
4018         (TestSuite.prototype.showResultsForAllTests):
4019         (TestSuite.prototype.exportResultsForAllTests):
4020         (TestSuite.prototype.exportResultsForTestsNotRun):
4021         (TestSuite.prototype.exportResultsForTestsWithStatus):
4022         (TestSuite.prototype.exportResultsForTestsWithMismatchedResults):
4023
4024 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
4025
4026         No review.
4027
4028         Work around uncertainty about the order of database
4029         transactions when creating the database, so that we don't
4030         try to query the table before it has been created.
4031
4032         * CSSTestSuiteHarness/harness/harness.js:
4033         (TestSuite):
4034         (TestSuite.prototype.databaseCreated):
4035         (TestSuite.prototype.storeTestResult):
4036         (TestSuite.prototype.populateDatabaseFromTestInfoData):
4037         (TestSuite.prototype.queryDatabaseForTestsWithStatus):
4038         (TestSuite.prototype.queryDatabaseForTestsWithMixedStatus):
4039         (TestSuite.prototype.queryDatabaseForCompletedTests):
4040         (TestSuite.prototype.queryDatabaseForTestsNotRun):
4041
4042 2010-09-28  Tony Chang  <tony@chromium.org>
4043
4044         Reviewed by Eric Seidel.
4045
4046         add python keyring support to webkit-patch
4047         https://bugs.webkit.org/show_bug.cgi?id=41269
4048
4049         * Scripts/webkitpy/common/net/credentials.py: Add the ability to read passwords using
4050             the python keyring module
4051         * Scripts/webkitpy/common/net/credentials_unittest.py:
4052         * Scripts/webkitpy/common/system/user.py: Allow confirm() to default to no and add testing params.
4053         * Scripts/webkitpy/common/system/user_unittest.py:
4054         * Scripts/webkitpy/tool/mocktool.py:
4055
4056 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
4057
4058         Reviewed by Gustavo Noronha Silva.
4059
4060         [Cairo] FreeType fonts should obey FontConfig hinting/anti-aliasing settings
4061         https://bugs.webkit.org/show_bug.cgi?id=46740
4062
4063         * DumpRenderTree/gtk/fonts/fonts.conf: Add specialized variants of common
4064         fonts which can be used to fully test FontConfig rendering settings.
4065
4066 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
4067
4068         Reviewed by Gustavo Noronha Silva.
4069
4070         [gtk] Fedora has a different path for the liberation fonts
4071         https://bugs.webkit.org/show_bug.cgi?id=46709
4072
4073         When searching for DRT fonts, also look in the path where those fonts
4074         are commonly found on Fedora systems.
4075
4076         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4077         (initializeFonts): Include logic for looking for Fedora-style font paths.
4078
4079 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
4080
4081         Reviewed by Andreas Kling.
4082
4083         run-webkit-tests needs an updated list of directories with webgl tests
4084         https://bugs.webkit.org/show_bug.cgi?id=46747
4085
4086         Update the list of directories containing WebGL tests and a unit test
4087         which depends on this list.
4088
4089         * Scripts/old-run-webkit-tests: Update the list of directories.
4090         * Scripts/webkitpy/layout_tests/port/webkit.py: Ditto.
4091         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Update the expected result.
4092
4093 2010-09-28  Adam Barth  <abarth@webkit.org>
4094
4095         Reviewed by Eric Seidel.
4096
4097         Introduce FailureMap to summaries the failures status of all the bots
4098         https://bugs.webkit.org/show_bug.cgi?id=46700
4099
4100         This patch gives the SheriffBot a handle on the list of failing tests.
4101
4102         * Scripts/webkitpy/common/net/buildbot.py:
4103         * Scripts/webkitpy/common/net/failuremap.py: Added.
4104         * Scripts/webkitpy/tool/commands/queries.py:
4105         * Scripts/webkitpy/tool/commands/sheriffbot.py:
4106         * Scripts/webkitpy/tool/mocktool.py:
4107
4108 2010-09-28  Adam Roben  <aroben@apple.com>
4109
4110         Update for the addition of WKPageUIClient::didNotHandleKeyEvent
4111
4112         Fixes <http://webkit.org/b/46660> <rdar://problem/8483465> Need API to
4113         tell a WebKit2 client application that a key event was not handled
4114
4115         Reviewed by Kenneth Rohde Christiansen and Sam Weinig.
4116
4117         * MiniBrowser/mac/BrowserWindowController.m:
4118         (-[BrowserWindowController awakeFromNib]):
4119         * MiniBrowser/win/BrowserView.cpp:
4120         (BrowserView::create):
4121         * WebKitTestRunner/TestController.cpp:
4122         (WTR::createOtherPage):
4123         (WTR::TestController::initialize):
4124
4125 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
4126
4127         Unreviewed.
4128
4129         Update the CSSTestSuiteHarness to not scrape the XHTML chapter files
4130         for the test order, but instead use information from testinfo.data.
4131         
4132         * CSSTestSuiteHarness/harness/harness.html:
4133         * CSSTestSuiteHarness/harness/harness.js:
4134
4135 2010-09-28  Kevin Ollivier  <kevino@theolliviers.com>
4136
4137         [wx] Build fix, don't try to get the svn revision from the git repo when packaging,
4138         it causes the process to hang on the gitorious repo.
4139
4140         * wx/packaging/build-mac-installer.py:
4141         * wx/packaging/build-win-installer.py:
4142
4143 2010-09-28  Adam Roben  <aroben@apple.com>
4144
4145         Test that a plugin's HWND is sized/positioned before NPP_SetWindow is
4146         called
4147
4148         Reviewed by Anders Carlsson.
4149
4150         Test for <http://webkit.org/b/46716> <rdar://problem/8482014>
4151         Full-page Adobe Reader does not paint until window is resized
4152
4153         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
4154         (PluginTest::NPP_SetWindow): Added. Just returns NPERR_NO_ERROR at
4155         this level.
4156
4157         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Declared
4158         NPP_SetWindow.
4159
4160         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp: Added.
4161         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Checks that
4162         the plugin's HWND has a non-zero size and that its size/position
4163         matches that specified in the NPWindow.
4164
4165         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
4166         (NPP_SetWindow): Call through to the PluginTest.
4167
4168         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
4169         Added WindowGeometryInitializedBeforeSetWindow.cpp, and let VS reorder
4170         the files as it saw fit.
4171
4172 2010-09-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
4173
4174         Reviewed by Andreas Kling.
4175
4176         [Qt] Remove support for Qt 4.5
4177         https://bugs.webkit.org/show_bug.cgi?id=46718
4178
4179         Remove the code for versions of Qt prior to 4.6.
4180
4181         * DumpRenderTree/qt/EventSenderQt.cpp:
4182         (EventSender::addTouchPoint):
4183         (EventSender::updateTouchPoint):
4184         (EventSender::setTouchModifier):
4185         (EventSender::touchStart):
4186         (EventSender::touchMove):
4187         (EventSender::touchEnd):
4188         (EventSender::clearTouchPoints):
4189         (EventSender::releaseTouchPoint):
4190         (EventSender::sendTouchEvent):
4191         * DumpRenderTree/qt/EventSenderQt.h:
4192         * DumpRenderTree/qt/TextInputControllerQt.cpp:
4193         (TextInputController::setMarkedText):
4194         * QtTestBrowser/launcherwindow.cpp:
4195         (LauncherWindow::LauncherWindow):
4196         (LauncherWindow::initializeView):
4197         (LauncherWindow::createChrome):
4198         (LauncherWindow::sendTouchEvent):
4199         (LauncherWindow::eventFilter):
4200         (LauncherWindow::applyZoom):
4201         (LauncherWindow::setTouchMocking):
4202         * QtTestBrowser/launcherwindow.h:
4203         * QtTestBrowser/utils.cpp:
4204         (urlFromUserInput):
4205         * QtTestBrowser/webview.cpp:
4206         (WebViewGraphicsBased::animatedFlip):
4207         (WebViewGraphicsBased::animatedYFlip):
4208         * QtTestBrowser/webview.h:
4209         (WebViewGraphicsBased::setYRotation):
4210
4211 2010-09-28  İsmail Dönmez  <ismail@namtrac.org>
4212
4213         Reviewed by Andreas Kling.
4214
4215         Fix DRT compilation on WinCE. Introduce a WCECOMPAT variable
4216         which should point to wcecompat installation. Needs wcecompat
4217         library from http://github.com/mauricek/wcecompat .
4218
4219         * DumpRenderTree/qt/DumpRenderTree.pro:
4220         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4221         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
4222
4223 2010-09-28  Daniel Bates  <dbates@rim.com>
4224
4225         Rollout changeset 68493 <http://trac.webkit.org/changeset/68493>
4226         <https://bugs.webkit.org/show_bug.cgi?id=39136>
4227