5f67e8c93e594c7096b15a35157020d9a5f51851
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-08-13  Dirk Pranke  <dpranke@chromium.org>
2
3         Reviewed by Eric Seidel.
4
5         Rewrite new-run-webkit-test's wait_for_threads_to_finish loop to
6         check for exceptions on all threads, not just the first thread.
7         
8         This change also changes the logging behavior for wedged threads
9         to only dump the stacks of threads that are actually wedged.
10
11         Refactor the thread classes in the dump_render_tree_thread module
12         to make the contract between TestRunner and TestShellThread clearer.
13
14         Added a bunch of unit tests.
15         https://bugs.webkit.org/show_bug.cgi?id=38561
16
17         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
18         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
19         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
20
21 2010-08-13  Kenichi Ishibashi  <bashi@google.com>
22
23         Reviewed by Shinichiro Hamaji.
24
25         Add test_expectations.txt syntax checker to check-webkit-style.
26         https://bugs.webkit.org/show_bug.cgi?id=43899
27
28         Just utilizing layout_tests/layout_package/test_expectations.py for checking
29         the syntax of test_expectations.txt.
30         This change also moves tab checking class from style/checkers/text.py to
31         style/checkers/common.py for sharing code.
32
33         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
34         * Scripts/webkitpy/style/checker.py:
35         * Scripts/webkitpy/style/checkers/common.py:
36         * Scripts/webkitpy/style/checkers/common_unittest.py:
37         * Scripts/webkitpy/style/checkers/test_expectations.py: Added.
38         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Added.
39         * Scripts/webkitpy/style/checkers/text.py:
40         * Scripts/webkitpy/style_references.py:
41
42 2010-08-12  Jon Honeycutt  <jhoneycutt@apple.com>
43
44         WebKitTestRunner does not correctly resize WebView for W3C SVG tests
45         https://bugs.webkit.org/show_bug.cgi?id=43945
46
47         Reviewed by Sam Weinig.
48
49         * WebKitTestRunner/TestInvocation.cpp:
50         (WTR::sizeWebViewForCurrentTest):
51         Allow for a Windows-style path.
52
53         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
54         (WTR::PlatformWebView::resizeTo):
55         Call SetWindowPos to resize the view window.
56
57 2010-08-12  David Levin  <levin@chromium.org>
58
59         Build break fix.
60
61         * WebKitTestRunner/TestController.cpp:
62         (WTR::TestController::resetStateToConsistentValues): Removed usage
63         of a variable that doesn't exist in the class.
64
65 2010-08-12  Jon Honeycutt  <jhoneycutt@apple.com>
66
67         WebKitTestRunner needs to run tests without using native controls
68         https://bugs.webkit.org/show_bug.cgi?id=43772
69
70         Reviewed by Sam Weinig.
71
72         * WebKitTestRunner/TestController.cpp:
73         (WTR::TestController::initialize):
74         Call platformInitializeContext().
75
76         * WebKitTestRunner/TestController.h:
77         Declare platformInitializeContext().
78
79         * WebKitTestRunner/mac/TestControllerMac.mm:
80         (WTR::TestController::platformInitializeContext):
81         Stubbed.
82
83         * WebKitTestRunner/win/TestControllerWin.cpp:
84         (WTR::TestController::platformInitializeContext):
85         Call WKContextSetShouldPaintNativeControls() to disable native control
86         drawing.
87
88 2010-08-12  Sam Weinig  <sam@webkit.org>
89
90         Reviewed by Alexey Proskuryakov.
91
92         WebKitTestRunner should be more aggressive about ensuring consistent state between tests
93         https://bugs.webkit.org/show_bug.cgi?id=43653
94
95         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
96         (WTR::InjectedBundle::InjectedBundle):
97         (WTR::InjectedBundle::didReceiveMessage):
98         (WTR::InjectedBundle::beginTesting):
99         (WTR::InjectedBundle::done):
100         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
101         (WTR::InjectedBundle::isTestRunning):
102         (WTR::InjectedBundle::):
103         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
104         (WTR::InjectedBundlePage::stopLoading):
105         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
106         (WTR::InjectedBundlePage::dump):
107         (WTR::InjectedBundlePage::didFinishLoadForFrame):
108         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
109         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
110         (WTR::InjectedBundlePage::didClearWindowForFrame):
111         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
112         (WTR::InjectedBundlePage::willAddMessageToConsole):
113         (WTR::InjectedBundlePage::willSetStatusbarText):
114         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
115         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
116         (WTR::InjectedBundlePage::shouldBeginEditing):
117         (WTR::InjectedBundlePage::shouldEndEditing):
118         (WTR::InjectedBundlePage::shouldInsertNode):
119         (WTR::InjectedBundlePage::shouldInsertText):
120         (WTR::InjectedBundlePage::shouldDeleteRange):
121         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
122         (WTR::InjectedBundlePage::shouldApplyStyle):
123         (WTR::InjectedBundlePage::didBeginEditing):
124         (WTR::InjectedBundlePage::didEndEditing):
125         (WTR::InjectedBundlePage::didChange):
126         (WTR::InjectedBundlePage::didChangeSelection):
127         Don't do any work if we are not currently running a test.
128
129         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
130         * WebKitTestRunner/StringFunctions.h:
131         (WTR::toCF):
132         Add conversion function for WKURLRef -> CFURLRef
133
134         * WebKitTestRunner/TestController.cpp:
135         (WTR::TestController::TestController):
136         (WTR::TestController::initialize):
137         (WTR::TestController::resetStateToConsistentValues):
138         (WTR::TestController::runTest):
139         (WTR::TestController::didFinishLoadForFrame):
140         * WebKitTestRunner/TestController.h:
141         (WTR::TestController::):
142         * WebKitTestRunner/TestInvocation.cpp:
143         (WTR::TestInvocation::invoke):
144         * WebKitTestRunner/TestInvocation.h:
145         Move resetting code to TestController.
146
147         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
148         * WebKitTestRunner/mac/TestControllerMac.mm:
149         (WTR::TestController::runUntil):
150         * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
151         * WebKitTestRunner/win/TestControllerWin.cpp:
152         (WTR::TestController::runUntil):
153         * WebKitTestRunner/win/TestInvocationWin.cpp: Removed.
154         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
155         Move runUntil to TestController.
156
157 2010-08-12  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
158
159         Unreviewed.
160
161         Adding myself to the committers list.
162
163         * Scripts/webkitpy/common/config/committers.py:
164
165 2010-08-12  Hayato Ito  <hayato@chromium.org>
166
167         Reviewed by Tony Chang.
168
169         Merge pretty printers for gdb.
170         https://bugs.webkit.org/show_bug.cgi?id=43850
171
172         We need to update webcore.py because basic string classes have moved to WTF from WebCore.
173         It is good timing to merge webcore.py and wtf.py and name it 'webkit.py'.
174         webcore.py is left for backward compatibility.
175
176         * gdb/webcore.py:
177         * gdb/webkit.py: Added.
178         * gdb/wtf.py: Removed.
179
180 2010-08-11  Tony Chang  <tony@chromium.org>
181
182         Reviewed by David Levin.
183
184         [chromium] add google-chrome layout test result directories
185         https://bugs.webkit.org/show_bug.cgi?id=43889
186
187         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
188         * Scripts/webkitpy/layout_tests/port/factory.py:
189         * Scripts/webkitpy/layout_tests/port/google_chrome.py: Added.
190         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
191
192 2010-08-11  Kent Tamura  <tkent@chromium.org>
193
194         Reviewed by Dimitri Glazkov.
195
196         [DRT/Chromium] Disable accelerated compositing
197         https://bugs.webkit.org/show_bug.cgi?id=43894
198
199         Disable accelerated compositing because DRT is not ready for
200         it. This change fixes hundreds of test crashes on Windows and
201         Linux.
202
203         * DumpRenderTree/chromium/TestShell.cpp:
204         (TestShell::resetWebSettings):
205
206 2010-08-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
207
208         Unreviewed. Adding my Collabora personality to the list.
209
210         * Scripts/webkitpy/common/config/committers.py:
211
212 2010-08-11  Martin Robinson  <mrobinson@igalia.com>
213
214         Adding myself as a reviewer.
215
216         * Scripts/webkitpy/common/config/committers.py:
217
218 2010-08-11  Daniel Bates  <dbates@rim.com>
219
220         Reviewed by Darin Adler.
221
222         Perl warnings when running commit-log-editor
223         https://bugs.webkit.org/show_bug.cgi?id=43856
224
225         Fixes Perl warnings introduced by the patch for Bug #40548.
226
227         Perl doesn't have symbolic names for True/False. Instead, we
228         should use boolean values. Moreover, the variable installedEditorApplication
229         is not be used and should be renamed builtEditorApplication so that it
230         uses the existing machinery to set the commit log editor application.
231
232         * Scripts/commit-log-editor:
233
234 2010-08-11  Adam Barth  <abarth@webkit.org>
235
236         Reviewed by Eric Seidel.
237
238         Trying waiting for httpd lock in the EWS
239         https://bugs.webkit.org/show_bug.cgi?id=43833
240
241         If this works, we can probably run the tests on the mac-ews, which
242         would be very exciting.  :)
243
244         * Scripts/webkitpy/tool/steps/runtests.py:
245
246 2010-08-11  Marcus Bulach  <bulach@chromium.org>
247
248         Reviewed by Eric Seidel.
249
250         Check in a script to list redundant test outputs.
251         https://bugs.webkit.org/show_bug.cgi?id=37630
252
253         If e.g. platform/mac-leopard is missing an expected test output, we
254         fall back on platform/mac.  This means it's possible to grow redundant
255         test outputs, where we have the same expected data in both a platform
256         directory and another platform it falls back on.
257         (original patch by Evan Marting <evan@chromium.org> https://bugs.webkit.org/attachment.cgi?id=53398)
258
259         * Scripts/deduplicate-tests: Added.
260         * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Added.
261         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: Added.
262
263 2010-08-11  Antonio Gomes  <tonikitoo@webkit.org>
264
265         Reviewed by Ariya Hidayat.
266
267         [Qt] QtTestBrowser: after switching between QWebView and QGraphicsWebView, rotation actions get broken
268         https://bugs.webkit.org/show_bug.cgi?id=43853
269
270         LauncherWindow::createChrome is connecting menu itens to WebViewGraphicsBased's slots directly.
271         It behaviors badly when user launches the QtTestBrowser in QWebView mode, since then switching to
272         QGraphicsWebView mode, createChrome is not called again, and menu items end up not getting connected
273         to slots at all.
274
275         * QtTestBrowser/launcherwindow.cpp:
276         (LauncherWindow::createChrome):
277         (LauncherWindow::animatedFlip):
278         (LauncherWindow::animatedYFlip):
279         * QtTestBrowser/launcherwindow.h:
280
281 2010-08-11  Antonio Gomes  <tonikitoo@webkit.org>
282
283         Reviewed by Simon Hausmann.
284
285         [Qt] QtTestBrowser: switching between QWebView and QGraphicsWebView modes is broken
286         https://bugs.webkit.org/show_bug.cgi?id=43851
287
288         All window options data (including the bool holding if the view is either QWebView or
289         QGraphicsWebView based) is stored in m_windowOptions, a class member of LauncherWindow.
290         When toggle the view from QWebView to QGraphicsWebView based (and vice-versa), we were
291         not updating LauncherWindow::WindowOptions::m_useGraphicsView bit, and then things were
292         getting broken.
293
294         Patch addresses this issue.
295
296         * QtTestBrowser/launcherwindow.cpp:
297         (LauncherWindow::createChrome):
298         (LauncherWindow::toggleWebView):
299         (LauncherWindow::toggleAcceleratedCompositing):
300
301 2010-08-10  Antonio Gomes  <tonikitoo@webkit.org>
302
303         Reviewed by Ariya Hidayat.
304
305         [Qt] QtTestBrowser: lazy instantiate "YRotation" state machine and related objects
306         https://bugs.webkit.org/show_bug.cgi?id=43831
307
308         Only instantiate QStateMachine and friends associated to the YRotation action on demand.
309
310         * QtTestBrowser/webview.cpp:
311         (WebViewGraphicsBased::WebViewGraphicsBased):
312         (WebViewGraphicsBased::animatedYFlip):
313
314 2010-08-11  Darin Adler  <darin@apple.com>
315
316         Reviewed by John Sullivan.
317
318         Improved editor options for prepare-ChangeLog and commit-log-editor
319         https://bugs.webkit.org/show_bug.cgi?id=40548
320
321         * Scripts/commit-log-editor: Split editor strings on spaces so EDITOR
322         values like "xed --launch --wait" work properly.
323
324         * Scripts/prepare-ChangeLog: Added a new CHANGE_LOG_EDITOR so we can
325         use a command line tool with the $openChangeLogs feature.
326
327 2010-08-11  Yury Semikhatsky  <yurys@chromium.org>
328
329         Reviewed by Pavel Feldman.
330
331         Web Inspector: remove InjectDispatch.js
332         https://bugs.webkit.org/show_bug.cgi?id=43835
333
334         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
335         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
336
337 2010-08-10  Dirk Pranke  <dpranke@chromium.org>
338
339         Reviewed by Eric Seidel.
340
341         webkit-patch should refuse to run under Win32 Python
342         https://bugs.webkit.org/show_bug.cgi?id=40962
343
344         Given that there are lots of places in webkit-patch's code that
345         assume unix-style filenames (forward slashes), webkit-patch fails
346         with weird file-not-found errors when run under a native windows
347         Python. It would be nice if we just trapped this and errored out
348         at the beginning, rather than producing unpredictable errors.
349
350         * Scripts/webkit-patch:
351
352 2010-08-10  Kent Tamura  <tkent@chromium.org>
353
354         Unreviewed, build fix.
355         
356         Chromium build fix for r65107.
357
358         * DumpRenderTree/chromium/LayoutTestController.cpp:
359         (LayoutTestController::suspendAnimations):
360         (LayoutTestController::resumeAnimations):
361
362 2010-08-10  Sergio Villar Senin  <svillar@igalia.com>
363
364         Reviewed by Xan Lopez.
365
366         [GTK] http/tests/media/video-cookie.html fails
367         https://bugs.webkit.org/show_bug.cgi?id=42240
368
369         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
370         (LayoutTestController::setAlwaysAcceptCookies): create the
371         SoupCookieJar if it does not exist. Otherwise the accept policy
372         won't be set.
373
374 2010-08-10  Chris Marrin  <cmarrin@apple.com>
375
376         Reviewed by Oliver Hunt.
377
378         Add suspendAnimations/resumeAnimation API to DRT
379         https://bugs.webkit.org/show_bug.cgi?id=43733
380         
381         Adds suspendAnimations() and resumeAnimations() to LayoutTestController.
382         Calls functions with the same names on AnimationController for the 
383         mainFrame.
384
385         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
386         * DumpRenderTree/LayoutTestController.cpp:
387         (suspendAnimationsCallback):
388         (resumeAnimationsCallback):
389         (LayoutTestController::staticFunctions):
390         * DumpRenderTree/LayoutTestController.h:
391         * DumpRenderTree/chromium/LayoutTestController.cpp:
392         (LayoutTestController::LayoutTestController):
393         (LayoutTestController::suspendAnimations):
394         (LayoutTestController::resumeAnimations):
395         * DumpRenderTree/chromium/LayoutTestController.h:
396         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
397         (LayoutTestController::suspendAnimations):
398         (LayoutTestController::resumeAnimations):
399         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
400         (LayoutTestController::suspendAnimations):
401         (LayoutTestController::resumeAnimations):
402         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
403         (LayoutTestController::suspendAnimations):
404         (LayoutTestController::resumeAnimations):
405         * DumpRenderTree/qt/LayoutTestControllerQt.h:
406         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
407         (LayoutTestController::suspendAnimations):
408         (LayoutTestController::resumeAnimations):
409         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
410         (LayoutTestController::suspendAnimations):
411         (LayoutTestController::resumeAnimations):
412
413 2010-08-10  Dimitri Glazkov  <dglazkov@chromium.org>
414
415         Reviewed by Ojan Vafai.
416
417         [Chromium/DRT] Enable saving layout test results.
418         https://bugs.webkit.org/show_bug.cgi?id=43796
419
420         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added more
421             parameters to the new-run-webkit-tests, including the name
422             of the test results server.
423
424 2010-08-10  Jian Li  <jianli@chromium.org>
425
426         More chromium build fix.
427
428         * DumpRenderTree/chromium/MockSpellCheck.cpp:
429         (MockSpellCheck::spellCheckWord):
430         (MockSpellCheck::initializeIfNeeded):
431         * DumpRenderTree/chromium/NotificationPresenter.cpp:
432         (NotificationPresenter::grantPermission):
433         (NotificationPresenter::show):
434         (NotificationPresenter::checkPermission):
435
436 2010-08-10  Jian Li  <jianli@chromium.org>
437
438         Chromium build fix.
439
440         * DumpRenderTree/chromium/MockSpellCheck.cpp:
441         * DumpRenderTree/chromium/NotificationPresenter.cpp:
442
443 2010-08-10  Victor Wang  <victorw@chromium.org>
444
445         Reviewed by Ojan Vafai.
446
447         Update test results server merge logic so the aggregated
448         results and times are updated for tests that are
449         in aggragated json but not in incremental json.
450
451         Also update unittest to test this case.
452
453         https://bugs.webkit.org/show_bug.cgi?id=43769
454
455         * TestResultServer/model/jsonresults.py:
456         * TestResultServer/model/jsonresults_unittest.py:
457
458 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
459
460         Reviewed by Ariya Hidayat.
461
462         [Qt] QtTestBrowser: proper set scene rect
463
464         When resizesToContents is ON scene's rect is set to the boundary of
465         the mainFrame. However, navigating to other web page should keep resizing
466         scene's rect according to the new document loaded. Patch addresses this issue.
467
468         Now resizesToContents and scrolling properly work on QtTestBrowser.
469
470         * QtTestBrowser/webview.cpp:
471         (WebViewGraphicsBased::setPage):
472         (WebViewGraphicsBased::contentsSizeChanged):
473         (WebViewGraphicsBased::setResizesToContents):
474         (WebViewGraphicsBased::resizeEvent):
475         * QtTestBrowser/webview.h:
476
477 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
478
479         Reviewed by Ariya Hidayat.
480
481         [Qt] QtTestBrowser: Clean up LauncherWindow code.
482
483         * QtTestBrowser/launcherwindow.cpp:
484         (LauncherWindow::LauncherWindow): Moves applyPrefs methods call from the constructor to init().
485         (LauncherWindow::init): Fixed comments.
486         (LauncherWindow::applyPrefs): Move the method around.
487         (LauncherWindow::createChrome): Move more code of this method around, for grouping, and fixing up comments.
488
489 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
490
491         Reviewed by Ariya Hidayat.
492
493         [Qt] QtTestBrowser: make reset-zooming to animate when tiled backing store is on.
494
495         It gets control+0 the same visual effect as control++ or control-.
496
497         * QtTestBrowser/launcherwindow.cpp:
498         (LauncherWindow::toggleZoomTextOnly):
499
500 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
501
502         Reviewed by Ariya Hidayat.
503
504         [Qt] QtTestBrowser:: make m_zoomLevels a static member.
505
506         Not all instances of LauncherWindow need its own m_zoomLevel.
507
508         * QtTestBrowser/launcherwindow.cpp:
509         * QtTestBrowser/launcherwindow.h:
510
511 2010-08-09  Sam Weinig  <sam@webkit.org>
512
513         Reviewed by Geoffrey Garen.
514
515         Add zoom support for injected bundle
516         https://bugs.webkit.org/show_bug.cgi?id=43759
517
518         Use zoom factor SPI to implement zoom related eventSender functions.
519
520         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
521         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
522         (WTR::EventSendingController::textZoomIn):
523         (WTR::EventSendingController::textZoomOut):
524         (WTR::EventSendingController::zoomPageIn):
525         (WTR::EventSendingController::zoomPageOut):
526         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
527         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
528         (WTR::InjectedBundlePage::reset): Reset zoom mode and level for each test.
529
530 2010-08-09  Gavin Barraclough  <barraclough@apple.com>
531
532         Speculative chromium build fix III.
533
534         * DumpRenderTree/chromium/MockSpellCheck.h:
535         * DumpRenderTree/chromium/NotificationPresenter.h:
536         * DumpRenderTree/chromium/WebViewHost.h:
537         (WebViewHost::addClearHeader):
538         (WebViewHost::clearHeaders):
539
540 2010-08-09  Ojan Vafai  <ojan@chromium.org>
541
542         Reviewed by Tony Chang.
543
544         increase the number of test results that we save
545         https://bugs.webkit.org/show_bug.cgi?id=43763
546
547         Now that we do incremental uploads, we can increase the number of
548         results that we save for http://test-results.appspot.com/dashboards/flakiness_dashboard.html.
549
550         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
551
552 2010-08-09  Evan Martin  <evan@chromium.org>
553
554         Reviewed by Tony Chang.
555
556         [chromium] DRT error print statement incorrectly tries to print a FILE*
557         https://bugs.webkit.org/show_bug.cgi?id=43747
558
559         * DumpRenderTree/chromium/ImageDiff.cpp:
560         (writeFile): pass the correct pointer.
561
562 2010-08-09  Victor Wang  <victorw@chromium.org>
563
564         Reviewed by Ojan Vafai.
565
566         Upload incremental test results json to server by default.
567
568         https://bugs.webkit.org/show_bug.cgi?id=43743
569
570         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
571
572 2010-08-09  Eric Seidel  <eric@webkit.org>
573
574         Reviewed by Adam Barth.
575
576         EWS bots wait 2 minutes between patches
577         https://bugs.webkit.org/show_bug.cgi?id=43731
578
579         * Scripts/webkitpy/tool/bot/queueengine.py:
580          - Don't sleep after failures.  This was a hold-over from
581            an earlier design.
582         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
583          - EWS bots were not properly reporting true/false from process_work_item.
584            They were always returning None, thus false, thus always logging
585            as a failure and sleeping 2 minutes after each patch.
586
587 2010-08-09  Sam Weinig  <sam@webkit.org>
588
589         Reviewed by Anders Carlsson.
590
591         Stub out EventSender for WebKitTestRunner
592         https://bugs.webkit.org/show_bug.cgi?id=43703
593
594         * WebKitTestRunner/DerivedSources.make:
595         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
596         Add ability to pass javascript arguments to the wrapped object.
597
598         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added.
599         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: Added.
600         (WTR::EventSendingController::create):
601         (WTR::EventSendingController::EventSendingController):
602         (WTR::EventSendingController::~EventSendingController):
603         (WTR::EventSendingController::wrapperClass):
604         (WTR::setExceptionForString):
605         (WTR::EventSendingController::mouseDown):
606         (WTR::EventSendingController::mouseUp):
607         (WTR::EventSendingController::mouseMoveTo):
608         (WTR::EventSendingController::keyDown):
609         (WTR::EventSendingController::contextClick):
610         (WTR::EventSendingController::leapForward):
611         (WTR::EventSendingController::textZoomIn):
612         (WTR::EventSendingController::textZoomOut):
613         (WTR::EventSendingController::zoomPageIn):
614         (WTR::EventSendingController::zoomPageOut):
615         (WTR::EventSendingController::makeWindowObject):
616         * WebKitTestRunner/InjectedBundle/EventSendingController.h: Added.
617         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
618         (WTR::InjectedBundle::reset):
619         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
620         (WTR::InjectedBundle::eventSendingController):
621         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
622         (WTR::InjectedBundlePage::didClearWindowForFrame):
623         Add stubbed out EventSenderController.
624
625         * WebKitTestRunner/InjectedBundle/GCController.h:
626         Remove incorrect comment.
627
628         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
629         * WebKitTestRunner/win/InjectedBundle.vcproj:
630         Add new files.
631
632 2010-08-08  Kent Tamura  <tkent@chromium.org>
633
634         Unreviewed, trivial fix.
635
636         Fix "WindowsError: [Error 32] The process cannot access the file
637         because it is being used by another process" introduced by r64959.
638
639         * BuildSlaveSupport/test-result-archive:
640
641 2010-08-08  Kent Tamura  <tkent@chromium.org>
642
643         Reviewed by Tony Chang.
644
645         Chromium buildbot: Avoid "zip" command dependency
646         https://bugs.webkit.org/show_bug.cgi?id=43470
647
648         * BuildSlaveSupport/test-result-archive:
649          For Chromium port, creates a zip archive with zipfile package of Python
650          instead of external "zip" command. We'd like to avoid additional
651          command installation.
652
653 2010-08-08  Jon Honeycutt  <jhoneycutt@apple.com>
654
655         WebKitTestRunner should add the QuickTime dir to the PATH environment
656         variable
657         https://bugs.webkit.org/show_bug.cgi?id=43686
658
659         Reviewed by Dan Bernstein.
660
661         * WebKitTestRunner/win/TestControllerWin.cpp:
662         (WTR::addQTDirToPATH):
663         Copied from DRT.
664         (WTR::TestController::platformInitialize):
665         Call addQTDirToPath().
666         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
667         Link to shlwapi.lib for SHGetValue.
668
669 2010-08-07  Sam Weinig  <sam@webkit.org>
670
671         Reviewed by Maciej Stachowiak.
672
673         WebKitTestRunner needs layoutTestController.dumpTitleChanges
674         <rdar://problem/8213861>
675         https://bugs.webkit.org/show_bug.cgi?id=42683
676
677         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
678         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
679         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
680         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
681         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
682         (WTR::LayoutTestController::LayoutTestController):
683         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
684         (WTR::LayoutTestController::dumpTitleChanges):
685         (WTR::LayoutTestController::shouldDumpTitleChanges):
686
687 2010-08-07  Sam Weinig  <sam@webkit.org>
688
689         Reviewed by Anders Carlsson.
690
691         WebKitTestRunner needs to print onunload handler information
692         <rdar://problem/8213831>
693         https://bugs.webkit.org/show_bug.cgi?id=42703
694
695         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
696         (WTR::operator<<):
697         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
698
699 2010-08-07  Sam Weinig  <sam@webkit.org>
700
701         Reviewed by Anders Carlsson.
702
703         Add additional loader client functions need to complete WebKitTestRunner
704         https://bugs.webkit.org/show_bug.cgi?id=43684
705
706         Remove unnecessary and jarring underscores as well.
707
708         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
709         (didClearWindowObjectForFrame):
710         (didCreatePage):
711         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
712         (WTR::InjectedBundlePage::InjectedBundlePage):
713         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
714         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
715         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
716         (WTR::InjectedBundlePage::didCommitLoadForFrame):
717         (WTR::InjectedBundlePage::didFinishLoadForFrame):
718         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
719         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
720         (WTR::InjectedBundlePage::didClearWindowForFrame):
721         (WTR::InjectedBundlePage::didCancelClientRedirectForFrame):
722         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
723         (WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
724         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
725         (WTR::InjectedBundlePage::didHandleOnloadEventsForFrame):
726         (WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
727         (WTR::InjectedBundlePage::didRunInsecureContentForFrame):
728         (WTR::InjectedBundlePage::willAddMessageToConsole):
729         (WTR::InjectedBundlePage::willSetStatusbarText):
730         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
731         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
732         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
733         (WTR::InjectedBundlePage::shouldBeginEditing):
734         (WTR::InjectedBundlePage::shouldEndEditing):
735         (WTR::InjectedBundlePage::shouldInsertNode):
736         (WTR::InjectedBundlePage::shouldInsertText):
737         (WTR::InjectedBundlePage::shouldDeleteRange):
738         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
739         (WTR::InjectedBundlePage::shouldApplyStyle):
740         (WTR::InjectedBundlePage::didBeginEditing):
741         (WTR::InjectedBundlePage::didEndEditing):
742         (WTR::InjectedBundlePage::didChange):
743         (WTR::InjectedBundlePage::didChangeSelection):
744         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
745
746 2010-08-07  Dan Bernstein  <mitz@apple.com>
747
748         Build fix.
749
750         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Made the references
751         to JSGCController.{cpp,h} relative to the build root.
752
753 2010-08-07  Sam Weinig  <sam@webkit.org>
754
755         Reviewed by Anders Carlsson.
756
757         WebKitTestRunner needs GCController
758         <rdar://problem/8213834>
759         https://bugs.webkit.org/show_bug.cgi?id=42701
760
761         * WebKitTestRunner/DerivedSources.make:
762         * WebKitTestRunner/InjectedBundle/Bindings/GCController.idl: Added.
763         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h:
764         (WTR::setProperty):
765         * WebKitTestRunner/InjectedBundle/GCController.cpp: Added.
766         (WTR::GCController::create):
767         (WTR::GCController::GCController):
768         (WTR::GCController::~GCController):
769         (WTR::GCController::wrapperClass):
770         (WTR::GCController::collect):
771         (WTR::GCController::collectOnAlternateThread):
772         (WTR::GCController::getJSObjectCount):
773         (WTR::GCController::makeWindowObject):
774         * WebKitTestRunner/InjectedBundle/GCController.h: Added.
775         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
776         (WTR::InjectedBundle::reset):
777         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
778         (WTR::InjectedBundle::bundle):
779         (WTR::InjectedBundle::gcController):
780         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
781         (WTR::InjectedBundlePage::didClearWindowForFrame):
782         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
783         (WTR::LayoutTestController::keepWebHistory):
784         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
785         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
786         * WebKitTestRunner/win/InjectedBundle.vcproj:
787
788 2010-08-05  Jon Honeycutt  <jhoneycutt@apple.com>
789
790         WebKitTestRunner needs to be able to set the font smoothing type
791         https://bugs.webkit.org/show_bug.cgi?id=43406
792
793         Reviewed by Adam Roben.
794
795         * WebKitTestRunner/TestInvocation.cpp:
796         (WTR::TestInvocation::resetPreferencesToConsistentValues):
797         Set the font smoothing level to
798         kWKFontSmoothingLevelNoSubpixelAntiAliasing to match DRT.
799
800 2010-08-06  Jon Honeycutt  <jhoneycutt@apple.com>
801
802         Fix a missed variable rename.
803
804         Unreviewed.
805
806         * Scripts/old-run-webkit-tests:
807
808 2010-08-06  Jon Honeycutt  <jhoneycutt@apple.com>
809
810         mac-wk2/Skipped should be used on Windows when running regression tests
811         https://bugs.webkit.org/show_bug.cgi?id=43494
812
813         Reviewed by Adam Roben.
814
815         * Scripts/old-run-webkit-tests:
816         If the platform is win-wk2, also read the mac-wk2 skipped list.
817
818 2010-08-06  Kent Tamura  <tkent@chromium.org>
819
820         Reviewed by Dimitri Glazkov.
821
822         [DRT/Chromium] Should revoke scheduled tasks
823         https://bugs.webkit.org/show_bug.cgi?id=43560
824
825         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
826         (DRTDevToolsAgent::reset): Calls RevokeAll().
827         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
828         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
829         (DRTDevToolsClient::reset): Calls RevokeAll().
830         * DumpRenderTree/chromium/DRTDevToolsClient.h:
831         * DumpRenderTree/chromium/EventSender.cpp:
832         (EventSender::reset): Calls RevokeAll().
833         * DumpRenderTree/chromium/LayoutTestController.cpp:
834         (LayoutTestController::reset): Calls RevokeAll().
835         * DumpRenderTree/chromium/TestShell.cpp:
836         (TestShell::resetTestController): Calls DRTDevToolsAgent::reset() and DRTDevToolsClient::reset().
837
838 2010-08-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
839
840         Reviewed by Antonio Gomes.
841
842         [Qt] Fix the DRT build on Mac OS X
843
844         * DumpRenderTree/qt/DumpRenderTree.pro:
845
846 2010-08-06  Jochen Eisinger  <jochen@chromium.org>
847
848         Reviewed by Pavel Feldman.
849
850         Rietvield's upload.py moved to a different location.
851         https://bugs.webkit.org/show_bug.cgi?id=43613
852
853         * Scripts/webkitpy/thirdparty/__init__.py:
854
855 2010-05-23  Eric Seidel  <eric@webkit.org>
856
857         Reviewed by Adam Barth.
858
859         QueueStatusServer needs better queue-status pages
860         https://bugs.webkit.org/show_bug.cgi?id=39562
861
862         The primary goal of this patch is to display queue
863         positions somewhere on the site so that it's easier
864         for commit-queue users to know when their pach will
865         be landed.  I also tried to improve the root page
866         to be more useful than the previous wall of status text.
867
868         * QueueStatusServer/handlers/recentstatus.py:
869         * QueueStatusServer/main.py:
870         * QueueStatusServer/model/queues.py:
871         * QueueStatusServer/templates/recentstatus.html:
872
873 2010-08-05  Victor Wang  <victorw@chromium.org>
874
875         Reviewed by Ojan Vafai.
876
877         Add option to generate/upload incremental json results to test result server.
878         Also refactor the json results generator unittest code to test
879         incremental and aggregated json results.
880
881         https://bugs.webkit.org/show_bug.cgi?id=43519
882
883         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
884         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
885         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
886         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
887
888 2010-08-05  Jian Li  <jianli@chromium.org>
889
890         Reviewed by David Levin.
891
892         Unify blob related feature defines to ENABLE(BLOB).
893         https://bugs.webkit.org/show_bug.cgi?id=43081
894
895         * Scripts/build-webkit:
896
897 2010-08-05  Satish Sampath  <satish@chromium.org>
898
899         Reviewed by Jeremy Orlow.
900
901         Add speech input controller mock in WebKit and a layout test.
902         https://bugs.webkit.org/show_bug.cgi?id=43477
903
904         Added LayoutTestController::setMockSpeechInputResultCallback method.
905
906         * DumpRenderTree/LayoutTestController.cpp:
907         (setMockSpeechInputResultCallback): Wrapper invoking the member function.
908         (LayoutTestController::staticFunctions):
909         * DumpRenderTree/LayoutTestController.h:
910         * DumpRenderTree/chromium/LayoutTestController.cpp:
911         (LayoutTestController::LayoutTestController):
912         (LayoutTestController::setMockSpeechInputResult): Sets the mock result.
913         (LayoutTestController::speechInputController): Creates the mock controller.
914         * DumpRenderTree/chromium/LayoutTestController.h:
915         * DumpRenderTree/chromium/WebViewHost.cpp:
916         (WebViewHost::speechInputController): Creates the mock controller.
917         * DumpRenderTree/chromium/WebViewHost.h:
918         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
919         (LayoutTestController::setMockSpeechInputResult): dummy method.
920         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
921         (LayoutTestController::setMockSpeechInputResult): dummy method.
922         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
923         (LayoutTestController::setMockSpeechInputResult): dummy method.
924         * DumpRenderTree/qt/LayoutTestControllerQt.h:
925         * DumpRenderTree/win/LayoutTestControllerWin.cpp: dummy method.
926         (LayoutTestController::setMockSpeechInputResult):
927         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: dummy method.
928         (LayoutTestController::setMockSpeechInputResult):
929
930 2010-08-04  Adam Roben  <aroben@apple.com>
931
932         Fix the path to TestNetscapePlugin's directory on Windows
933
934         Fixes <http://webkit.org/b/43513> WebKitTestRunner on Windows fails to
935         load TestNetscapePlugin
936
937         Reviewed by Jon Honeycutt.
938
939         * WebKitTestRunner/win/TestControllerWin.cpp:
940         (WTR::TestController::initializeTestPluginDirectory):
941         TestNetscapePlugin is in a TestNetscapePlugin[_Debug] directory that's
942         next to WebKitTestRunner.exe. Previously we were passing the directory
943         that contains WebKitTestRunner.exe. Also fixed some leaks.
944
945 2010-08-05  Kenichi Ishibashi  <bashi@google.com>
946
947         Reviewed by Shinichiro Hamaji.
948
949         check-webkit-style returns non-zero when patch is entirely minus lines.
950         https://bugs.webkit.org/show_bug.cgi?id=38169
951
952         * Scripts/check-webkit-style:
953         Check whether a patch contains modified files that are entirely minus lines.
954         * Scripts/webkitpy/style/filereader.py:
955         Add a variable that holds number of files that contain only deleted lines.
956         * Scripts/webkitpy/style/patchreader.py:
957         Count up modified files that contain only deleted lines.
958
959 2010-08-05  Pavel Feldman  <pfeldman@chromium.org>
960
961         Reviewed by Yury Semikhatsky.
962
963         DevTools: get rid of delayed command dispatching on front-end side.
964
965         https://bugs.webkit.org/show_bug.cgi?id=43479
966
967         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
968         (DRTDevToolsAgent::detach):
969         (DRTDevToolsAgent::frontendLoaded):
970         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
971         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
972         (DRTDevToolsClient::~DRTDevToolsClient):
973         (DRTDevToolsClient::sendFrontendLoaded):
974         * DumpRenderTree/chromium/DRTDevToolsClient.h:
975
976 2010-08-04  Kenichi Ishibashi  <bashi@google.com>
977
978         Reviewed by Shinichiro Hamaji.
979
980         Fixes check-webkit-style false positive on "new uint32_t."
981         https://bugs.webkit.org/show_bug.cgi?id=43077
982
983         * Scripts/webkitpy/style/checkers/cpp.py:
984         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
985
986 2010-08-04  Kent Tamura  <tkent@chromium.org>
987
988         Reviewed by Dimitri Glazkov.
989
990         [DRT/Chromium] Remove base/linked_ptr.h dependency
991         https://bugs.webkit.org/show_bug.cgi?id=43472
992
993         Replace linked_ptr<TestNavigationEntry> with RefPtr<TestNavigationEntry>.
994         We need to use RefPtr<> because m_pendingEntry points an object in
995         m_entries or not in m_entries.
996
997         * DumpRenderTree/chromium/TestNavigationController.cpp:
998         (TestNavigationEntry::create): Added.
999         (TestNavigationController::activeEntry):
1000         (TestNavigationController::didNavigateToEntry):
1001         (TestNavigationController::discardPendingEntry):
1002         (TestNavigationController::insertEntry):
1003         (TestNavigationController::navigateToPendingEntry):
1004         * DumpRenderTree/chromium/TestNavigationController.h:
1005         * DumpRenderTree/chromium/WebViewHost.cpp:
1006         (WebViewHost::loadURLForFrame):
1007          Use TestNavigationEntry::create().
1008         (WebViewHost::updateURL):
1009          Use RefPtr<>.
1010         (WebViewHost::updateSessionHistory):
1011          Remove unnecessary static_cast<>.
1012
1013 2010-08-04  Kent Tamura  <tkent@chromium.org>
1014
1015         Reviewed by Dimitri Glazkov.
1016
1017         Fix a problem that "archived test results" step doesn't work on Chromium buildbots
1018         https://bugs.webkit.org/show_bug.cgi?id=43333
1019
1020         * BuildSlaveSupport/test-result-archive:
1021           - Make layoutTestResultsDir local and pass it to archiveTestResults()
1022           - Adjust layoutTestResultsDir for Chromium
1023
1024 2010-08-04  Kent Tamura  <tkent@chromium.org>
1025
1026         Reviewed by Dimitri Glazkov.
1027
1028         NRWT: websocket_server startup detection failure
1029         https://bugs.webkit.org/show_bug.cgi?id=43466
1030
1031         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1032          Increase timeout value: 5 second -> 10 second
1033
1034 2010-08-04  Victor Wang  <victorw@chromium.org>
1035
1036         Reviewed by Ojan Vafai.
1037
1038         -. Add result.json incremental merging functionality to test results app engine.
1039         -. blobstore is not suitable for AE data merging and there is no API to
1040            programatically edit existing blob or write a new one yet, so replace blobstore
1041            with datastore. If file is oversize (>1000*1000 bytes), store file data in
1042            multiple datastore entries.
1043         -. Fix styles.
1044
1045         Test: jsonresults_unittest to test merging logics.
1046
1047         https://bugs.webkit.org/show_bug.cgi?id=38599
1048
1049         * TestResultServer/handlers/dashboardhandler.py:
1050         * TestResultServer/handlers/menu.py:
1051         * TestResultServer/handlers/testfilehandler.py:
1052         * TestResultServer/main.py:
1053         * TestResultServer/model/dashboardfile.py:
1054         * TestResultServer/model/datastorefile.py: Added.
1055         * TestResultServer/model/jsonresults.py: Added.
1056         * TestResultServer/model/jsonresults_unittest.py: Added.
1057         * TestResultServer/model/testfile.py:
1058         * TestResultServer/templates/uploadform.html:
1059
1060 2010-08-04  Antonio Gomes  <tonikitoo@webkit.org>
1061
1062         Reviewed by Kenneth Christiansen.
1063
1064         [Qt] [QtTestBrowser] Remove unneeded QAction class members
1065         https://bugs.webkit.org/show_bug.cgi?id=43518
1066
1067         LauncherWindow class has two totally unneeded class members: m_flopAnimated and
1068         m_flipYAnimated. Also, in initializeView method there are some dead code block
1069         trying to connect them at the wrong time, when they have not been instanciated.
1070
1071         This patch:
1072
1073         - removes the two cited class members in favor of local variables in createChrome method;
1074         - removes the dead code block.
1075
1076         * QtTestBrowser/launcherwindow.cpp:
1077         (LauncherWindow::LauncherWindow):
1078         (LauncherWindow::initializeView):
1079         (LauncherWindow::createChrome):
1080         * QtTestBrowser/launcherwindow.h:
1081
1082 2010-08-04  Antonio Gomes  <tonikitoo@webkit.org>
1083
1084         Reviewed by Simon Hausmann and Kenneth Christiansen.
1085
1086         [Qt] [QtTestBrowser] Clean up static and global menu state controls
1087         https://bugs.webkit.org/show_bug.cgi?id=43448
1088
1089         After LauncherWindow class was refactored out of from main.cpp, all global variables that
1090         were hanging in main.cpp became temporarily public static class members of newly added
1091         LauncherWindow class. This design was not properly handling the initial purpose of the
1092         global variables: newly created launcher windows should inherit the settings of the originating
1093         one.
1094
1095         In order to properly fix the problem, this patch introduces a WindowOptions class, as a POD. It
1096         comprises all data needed to handling the goal described above.
1097
1098         * QtTestBrowser/launcherwindow.cpp:
1099         (LauncherWindow::LauncherWindow): The class now receives an optional WindowOptions pointer object
1100                                           holding all user settings configured in the menus and command line.
1101                                           It also receices an optional QGraphicsScene points in case we are doing
1102                                           a "Clone Window".
1103         (LauncherWindow::init): Removed the usesGraphics parameter because the class member m_userData holds its
1104                                 value.
1105         (LauncherWindow::initializeView): Ditto.
1106         (LauncherWindow::createChrome): Changed all references to gXXX to m_userData.XXX
1107         (LauncherWindow::applyPrefs): Removed the "LauncherWindow* source" parameter. All data needed to properly
1108                                       apply the preferences is provided by m_userData.
1109         (LauncherWindow::toggleAcceleratedCompositing): Change gXXX by m_userData.XXX
1110         (LauncherWindow::toggleResizesToContents): Ditto.
1111         (LauncherWindow::toggleWebGL): Ditto.
1112         (LauncherWindow::toggleFrameFlattening): Ditto.
1113         (LauncherWindow::toggleQGLWidgetViewport): Ditto.
1114         (LauncherWindow::changeViewportUpdateMode): Ditto.
1115         (LauncherWindow::showFPS): Ditto.
1116         (LauncherWindow::newWindow): Changed to pass the userData.
1117         (LauncherWindow::cloneWindow): Ditto.
1118         * QtTestBrowser/launcherwindow.h:
1119         (WindowOptions::WindowOptions):
1120         * QtTestBrowser/main.cpp:
1121         (requiresGraphicsView):
1122         (LauncherApplication::handleUserOptions):
1123         (main):
1124
1125 2010-08-04  Kevin Ollivier  <kevino@theolliviers.com>
1126
1127         [wx] Build fix for gcc not importing all symbols from convenience libraries.
1128         Works on 10.6 only for Mac until the build system is reworked. 
1129
1130         * wx/build/settings.py:
1131
1132 2010-08-04  Markus Goetz  <Markus.Goetz@nokia.com>
1133
1134         Reviewed by Simon Hausmann.
1135
1136         [Qt] Change wording in QtTestBrowser
1137         https://bugs.webkit.org/show_bug.cgi?id=43241
1138
1139         * QtTestBrowser/launcherwindow.cpp:
1140         (LauncherWindow::createChrome):
1141
1142 2010-08-04  Aaron Boodman  <aa@chromium.org>
1143
1144         Reviewed by Eric Seidel.
1145
1146         prepare-ChangeLog fails mysteriously if curl doesn't support ssl
1147         https://bugs.webkit.org/show_bug.cgi?id=43460
1148
1149         * Scripts/prepare-ChangeLog:
1150
1151 2010-08-03  MORITA Hajime  <morrita@google.com>
1152
1153         Reviewed by Tony Chang.
1154
1155         [DRT] Assertion failed when drag and move a draggable element.
1156         https://bugs.webkit.org/show_bug.cgi?id=41695
1157
1158         mouseMoveToX() did call [WebHTMLView mouseDragged] even if dragging started.
1159         But Cocoa doesn't call mouseDragged() until dragging is done.
1160         Other part of DumpRenderTree also assumes Cocoa behavior and an assertion
1161         on UIDelegate failed when mouseDragged() is called during dragging.
1162         This change eliminated the mouseDragged() call when dragging begins,
1163         which is implicated by draggingInfo instance.
1164         
1165         * DumpRenderTree/mac/EventSendingController.mm:
1166         (-[EventSendingController mouseMoveToX:Y:]):
1167
1168         Test: fast/events/dragging-mouse-moves.html
1169         
1170 2010-08-02  Steve Block  <steveblock@google.com>
1171
1172         Reviewed by Alexey Proskuryakov.
1173
1174         Adds Geolocation LayoutTests for the case where permission is not granted or denied immediately
1175         https://bugs.webkit.org/show_bug.cgi?id=40002
1176
1177         The code in LayoutTestController::setGeolocationPermission() was moved to
1178         setGeolocationPermissionCommon() to allow each port to provide its own
1179         implementation of setGeolocationPermission().
1180
1181         For the Mac port, setGeolocationPermission() notifies the UIDelegate of the
1182         new permission, so it can call back to WebCore if permission requests are in
1183         progress and are waiting for a response. A minor fix to the Mac
1184         MockGeolocationProvider was also required to make sure that the mock provider
1185         calls back to WebCore when it is first started.
1186
1187         For other ports, LayoutTestController::setGeolocationPermission() is not
1188         implemented.
1189
1190         * DumpRenderTree/LayoutTestController.cpp:
1191         (LayoutTestController::setGeolocationPermissionCommon):
1192         * DumpRenderTree/LayoutTestController.h:
1193         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1194         (LayoutTestController::setGeolocationPermission):
1195         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1196         (LayoutTestController::setGeolocationPermission):
1197         * DumpRenderTree/mac/MockGeolocationProvider.mm:
1198         (-[MockGeolocationProvider registerWebView:]):
1199         * DumpRenderTree/mac/UIDelegate.h:
1200         * DumpRenderTree/mac/UIDelegate.mm:
1201         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
1202         (-[UIDelegate setGeolocationPermission:]):
1203         (-[UIDelegate dealloc]):
1204         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1205         (LayoutTestController::setGeolocationPermission):
1206         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1207         (LayoutTestController::setGeolocationPermission):
1208
1209 2010-08-03  Kent Tamura  <tkent@chromium.org>
1210
1211         Reviewed by Dimitri Glazkov.
1212
1213         [DRT/Chromium] Implement --testshell-startup-dialog
1214         https://bugs.webkit.org/show_bug.cgi?id=40616
1215
1216         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1217         (main): Check --testshell-startup-dialog, and call openStartUpDialog()
1218         if it is specfied.
1219         * DumpRenderTree/chromium/TestShell.h:
1220           Declare openStartUpDialog().
1221         * DumpRenderTree/chromium/TestShellGtk.cpp:
1222         (openStartupDialog):
1223         * DumpRenderTree/chromium/TestShellMac.mm:
1224         (openStartupDialog):
1225         * DumpRenderTree/chromium/TestShellWin.cpp:
1226         (openStartupDialog):
1227
1228 2010-08-03  Kent Tamura  <tkent@chromium.org>
1229
1230         Reviewed by Dimitri Glazkov.
1231
1232         [DRT/Chromium] Remove dependency of base/md5.h
1233         https://bugs.webkit.org/show_bug.cgi?id=43403
1234
1235         * DumpRenderTree/chromium/TestShell.cpp:
1236         (TestShell::dumpImage): Use wtf/MD5.h
1237
1238 2010-08-03  Joseph Pecoraro  <joepeck@webkit.org>
1239
1240         Reviewed by David Kilzer.
1241
1242         Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
1243         https://bugs.webkit.org/show_bug.cgi?id=40627
1244
1245         Part 6 - LayoutTest and Cleanup
1246
1247           Allow tests to delete application caches and set application cache
1248           origin quotas, so they can be tested.
1249
1250         * DumpRenderTree/LayoutTestController.cpp:
1251         (LayoutTestController::LayoutTestController):
1252         (dumpApplicationCacheDelegateCallbacksCallback): JavaScript callback, delegates to the controller.
1253         (clearAllApplicationCachesCallback): should delete all application caches.
1254         (setApplicationCacheOriginQuotaCallback): should set the origin quota for the localhost tests.
1255         (LayoutTestController::staticFunctions):
1256         * DumpRenderTree/LayoutTestController.h:
1257         (LayoutTestController::dumpApplicationCacheDelegateCallbacks): accessor to see if application cache callbacks should be output.
1258         (LayoutTestController::setDumpApplicationCacheDelegateCallbacks): enable or disable debug output when the application cache quota is reached.
1259
1260           Mac implementation.
1261
1262         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1263         (LayoutTestController::clearAllApplicationCaches): delete application caches.
1264         (LayoutTestController::setApplicationCacheOriginQuota): set the quota for localhost.
1265         * DumpRenderTree/mac/UIDelegate.mm:
1266         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): style fix.
1267         (-[UIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:]): reset the quota.
1268
1269           Stub implementations for other platforms.
1270
1271         * DumpRenderTree/chromium/LayoutTestController.cpp:
1272         (LayoutTestController::LayoutTestController):
1273         (LayoutTestController::clearAllApplicationCaches):
1274         (LayoutTestController::setApplicationCacheOriginQuota):
1275         * DumpRenderTree/chromium/LayoutTestController.h:
1276         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1277         (LayoutTestController::clearAllApplicationCaches):
1278         (LayoutTestController::setApplicationCacheOriginQuota):
1279         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1280         (LayoutTestController::clearAllApplicationCaches):
1281         (LayoutTestController::setApplicationCacheOriginQuota):
1282         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1283         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1284         (LayoutTestController::clearAllApplicationCaches):
1285         (LayoutTestController::setApplicationCacheOriginQuota):
1286         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1287         (LayoutTestController::clearAllApplicationCaches):
1288         (LayoutTestController::setApplicationCacheOriginQuota):
1289
1290 2010-08-03  Joseph Pecoraro  <joepeck@webkit.org>
1291
1292         Reviewed by David Kilzer.
1293
1294         Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
1295         https://bugs.webkit.org/show_bug.cgi?id=40627
1296
1297         Part 5 - Refactor Quota Management in WebSecurityOrigin into Managers
1298
1299           Change old style calls to make use of the managers.
1300
1301         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1302         (LayoutTestController::setDatabaseQuota):
1303         * DumpRenderTree/mac/UIDelegate.mm:
1304         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]):
1305
1306 2010-08-03  Mark Rowe  <mrowe@apple.com>
1307
1308         Add a new Leopard build slave to run the release tests.
1309
1310         * BuildSlaveSupport/build.webkit.org-config/config.json:
1311
1312 2010-08-03  Jon Honeycutt  <jhoneycutt@apple.com>
1313
1314         WebKitTestRunner needs to activate the Mac font ascent hack
1315         https://bugs.webkit.org/show_bug.cgi?id=43404
1316
1317         Reviewed by Darin Adler.
1318
1319         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1320         (WTR::InjectedBundle::initialize):
1321         Call WKBundleActivateMacFontAscentHack().
1322
1323 2010-08-03  Alex Milowski  <alex@milowski.com>
1324
1325         Reviewed by Beth Dakin.
1326
1327         Changed the default for MathML support so that is is enabled by default.
1328
1329         * Scripts/build-webkit:
1330
1331 2010-08-03  Sam Weinig  <sam@webkit.org>
1332
1333         Roll r64566 back in this time with all the overloads in place..
1334
1335         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1336         (WTR::InjectedBundlePage::shouldInsertNode):
1337         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1338         * WebKitTestRunner/StringFunctions.h:
1339         * WebKitTestRunner/TestInvocation.cpp:
1340         (WTR::TestInvocation::resetPreferencesToConsistentValues):
1341         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1342         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1343
1344 2010-08-03  Sam Weinig  <sam@webkit.org>
1345
1346         Rollout r64566. It broke all the WebKit2 tests.
1347
1348         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1349         (WTR::operator<<):
1350         (WTR::InjectedBundlePage::shouldInsertNode):
1351         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1352         * WebKitTestRunner/StringFunctions.h: Removed.
1353         * WebKitTestRunner/TestInvocation.cpp:
1354         (WTR::createWKURL):
1355         (WTR::WKStringToUTF8):
1356         (WTR::TestInvocation::resetPreferencesToConsistentValues):
1357         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1358         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1359
1360 2010-08-03  Sam Weinig  <sam@webkit.org>
1361
1362         Reviewed by Anders Carlsson.
1363
1364         WTR: Move all the utility functions for working with strings to a shared header.
1365         https://bugs.webkit.org/show_bug.cgi?id=43386
1366
1367         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1368         (WTR::InjectedBundlePage::shouldInsertNode):
1369         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1370         * WebKitTestRunner/StringFunctions.h: Added.
1371         * WebKitTestRunner/TestInvocation.cpp:
1372         (WTR::TestInvocation::resetPreferencesToConsistentValues):
1373         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1374         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1375
1376 2010-08-02  Antonio Gomes  <tonikitoo@webkit.org>
1377
1378         Reviewed by Kenneth Christiansen.
1379
1380         [Qt] QtTestBrowser not setting preferredContentsSize for resizesToContents
1381         https://bugs.webkit.org/show_bug.cgi?id=43168
1382
1383         QGraphicsWebView resizesToContents property has to work together with QWebPage's
1384         setPreferredContentsSize as stated by the docs. Patch addresses that for QtTestBrowser.
1385
1386         * QtTestBrowser/launcherwindow.cpp:
1387         (LauncherWindow::applyPrefs):
1388         * QtTestBrowser/webview.cpp:
1389         (WebViewGraphicsBased::setResizesToContents): Properly handle scene, webview and viewport sizes
1390                                                       needed when toggle resizesToContents on/off.
1391         (WebViewGraphicsBased::resizeEvent):
1392         * QtTestBrowser/webview.h:
1393         (WebViewGraphicsBased::setCustomLayoutSize): Setter helper.
1394         (WebViewGraphicsBased::customLayoutSize): Getter helper.
1395
1396 2010-08-03  Jochen Eisinger  <jochen@chromium.org>
1397
1398         Unreviewed. Adding myself as committer.
1399
1400         * Scripts/webkitpy/common/config/committers.py:
1401
1402 2010-08-02  Pavel Feldman  <pfeldman@chromium.org>
1403
1404         Reviewed by Yury Semikhatsky.
1405
1406         Chromium DevTools: Get rid of DevTools RPC.
1407
1408         https://bugs.webkit.org/show_bug.cgi?id=43335
1409
1410         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1411         (DRTDevToolsAgent::sendMessageToInspectorFrontend):
1412         (DRTDevToolsAgent::call):
1413         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1414         * DumpRenderTree/chromium/DRTDevToolsCallArgs.h:
1415         (DRTDevToolsCallArgs::DRTDevToolsCallArgs):
1416         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1417         (DRTDevToolsClient::sendMessageToBackend):
1418         (DRTDevToolsClient::call):
1419         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1420
1421 2010-08-02  Kent Tamura  <tkent@chromium.org>
1422
1423         Reviewed by Dimitri Glazkov.
1424
1425         [DRT/Chromium] Remove dependencies to some Chromium headers
1426         https://bugs.webkit.org/show_bug.cgi?id=43396
1427
1428         * DumpRenderTree/chromium/CppVariant.h:
1429          Remove base/basictypes.h because webkit_support.h contains it.
1430         * DumpRenderTree/chromium/EventSender.cpp:
1431         (getCurrentEventTimeSec): Use new wrapper function.
1432         * DumpRenderTree/chromium/TestNavigationController.h:
1433          Remove base/basictypes.h because webkit_support.h contains it.
1434         * DumpRenderTree/chromium/TestShell.cpp:
1435         (dumpHistoryItem): Use new wrapper function.
1436         * DumpRenderTree/chromium/WebViewHost.cpp:
1437         (WebViewHost::cancelledError): Use new wrapper function.
1438         (WebViewHost::didFailResourceLoad): Use new wrapper function.
1439
1440 2010-08-02  Martin Robinson  <mrobinson@igalia.com>
1441
1442         Reviewed by Xan Lopez.
1443
1444         [GTK] DRT implement execCommand()
1445         https://bugs.webkit.org/show_bug.cgi?id=35351
1446
1447         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1448         (LayoutTestController::execCommand): Implement using webkit_web_view_execute_core_command_by_name.
1449         (LayoutTestController::isCommandEnabled): Implement using webkit_web_view_is_command_enabled.
1450         (LayoutTestController::setCacheModel): Move below LayoutTestController::isCommandEnabled.
1451
1452 2010-08-02  Sam Weinig  <sam@webkit.org>
1453
1454         Reviewed by Anders Carlsson.
1455
1456         Add alias for run-webkit-tests --webkit-test-runner (run-webkit-tests -2).
1457
1458         * Scripts/old-run-webkit-tests:
1459
1460 2010-08-02  Jon Honeycutt  <jhoneycutt@apple.com>
1461
1462         WebKitTestRunner needs to support loading custom fonts (via the
1463         WEBKIT_TESTFONTS environment variable)
1464         https://bugs.webkit.org/show_bug.cgi?id=42782
1465
1466         Reviewed by Adam Roben.
1467
1468         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:
1469         (WTR::fontsPath):
1470         Copied from DRT code. Removed the fallback to DumpRenderTree.resources/,
1471         as this directory doesn't appear to be created anymore.
1472         (WTR::activateFonts):
1473         Loop through the fonts, and call AddFontResourceExW() for each.
1474
1475 2010-08-02  Jon Honeycutt  <jhoneycutt@apple.com>
1476
1477         Restore the WebKitTestRunner.sln that was removed, and remove the
1478         correct one.
1479
1480         Rubber-stamped by Sam Weinig.
1481
1482         * WebKitTestRunner/WebKitTestRunner.sln: Added.
1483         * WebKitTestRunner/win/WebKitTestRunner.sln: Removed.
1484
1485 2010-08-02  Jon Honeycutt  <jhoneycutt@apple.com>
1486
1487         Move InjectedBundle.vcproj to where the other WebKitTestRunner vcprojs live.
1488
1489         Remove the unused WebKitTestRunner.sln.
1490
1491         Reviewed by Sam Weinig.
1492
1493         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
1494         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: Removed.
1495         * WebKitTestRunner/WebKitTestRunner.sln: Removed.
1496         * WebKitTestRunner/win/InjectedBundle.vcproj: Added.
1497         * WebKitTestRunner/win/WebKitTestRunner.sln:
1498
1499 2010-08-02  Sam Weinig  <sam@webkit.org>
1500
1501         Fix the windows build.
1502
1503         * WebKitTestRunner/win/main.cpp:
1504
1505 2010-07-29  Jon Honeycutt  <jhoneycutt@apple.com>
1506
1507         Add a Skipped list on Windows, and have run-webkit-tests respect it.
1508
1509         Part of <rdar://problem/8233237> Fill WebKit2 Windows skipped list so
1510         there are zero tests failing
1511         https://bugs.webkit.org/show_bug.cgi?id=43374
1512
1513         Reviewed by Adam Roben.
1514
1515         * Scripts/old-run-webkit-tests:
1516         If using WebKitTestRunner and Apple Windows WebKit, set the platform to
1517         win-wk2. When building the result hierarchy, if the platform is win-wk2,
1518         add it first to the list of platforms.
1519
1520 2010-08-02  Darin Adler  <darin@apple.com>
1521
1522         Reviewed by Sam Weinig.
1523
1524         WebKitTestRunner needs layoutTestController.setCanOpenWindows
1525         https://bugs.webkit.org/show_bug.cgi?id=42321
1526
1527         WebKitTestRunner needs layoutTestController.setCloseRemainingWindowsWhenComplete
1528         https://bugs.webkit.org/show_bug.cgi?id=42779
1529
1530         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added
1531         setCanOpenWindows, setCloseRemainingWindowsWhenComplete, and windowCount
1532
1533         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1534         (WTR::InjectedBundle::InjectedBundle): Initialize m_mainPage to 0 instead of
1535         waiting for the first call to didCreatePage.
1536         (WTR::InjectedBundle::didCreatePage): Set m_mainPage only when the first page
1537         is created. Put other pages into a map.
1538         (WTR::InjectedBundle::willDestroyPage): Added code to handle the destruction
1539         of the main page.
1540         (WTR::InjectedBundle::closeOtherPages): Added. Closes all the pages other than
1541         the main page.
1542         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Added pageCount and
1543         closeOtherPages functions.
1544
1545         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1546         (WTR::InjectedBundlePage::didFinishLoadForFrame): Don't let pages other than
1547         the main page affect dumping.
1548         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): Ditto.
1549
1550         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1551         (WTR::LayoutTestController::LayoutTestController): Initialize the new
1552         m_shouldCloseExtraWindows member.
1553         (WTR::LayoutTestController::setCanOpenWindows): Added. Empty for now.
1554         (WTR::LayoutTestController::windowCount): Added.
1555
1556         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1557         Added setCanOpenWindows, setCloseRemainingWindowsWhenComplete,
1558         windowCount, shouldCloseExtraWindowsAfterRunningTest, and
1559         m_shouldCloseExtraWindows.
1560
1561         * WebKitTestRunner/TestController.cpp:
1562         (WTR::TestController::shared): Return a pointer to the shared copy, but
1563         don't allocate and leak it. This seemed cleaner than adding an explicit
1564         finalize call to go along with the explicit initialize call.
1565         (WTR::TestController::TestController): Added calls to the initialize and
1566         run function, which are now done automatically.
1567         (WTR::TestController::~TestController): Added, since it's called now.
1568         (WTR::closeOtherPage): Added. Used to close pages other than the main page.
1569         (WTR::createOtherPage): Added. Used to create pages other than the main page.
1570         (WTR::TestController::initialize): Added code to set up createOtherPage.
1571         (WTR::TestController::run): Removed unused return value.
1572         * WebKitTestRunner/TestController.h: Made constructor and destructor public,
1573         and initialize and run private. Changed m_mainWebView to be an OwnPtr.
1574
1575         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1576         (WTR::PlatformWebView::PlatformWebView): Added a call to setReleasedWhenClosed
1577         to avoid releasing the window twice. Another way to handle it would be to
1578         remove the release, but this approach is slightly more robust because it works
1579         even if some other code calls the close method an extra time.
1580
1581         * WebKitTestRunner/mac/main.mm:
1582         (main): Use a stack-allocated TestController object instead of calling
1583         initalize and run on a globally allocated one.
1584
1585 2010-08-02  Tony Chang  <tony@chromium.org>
1586
1587         Reviewed by David Levin.
1588
1589         add myself to the reviewers list
1590         https://bugs.webkit.org/show_bug.cgi?id=43366
1591
1592         * Scripts/webkitpy/common/config/committers.py:
1593
1594 2010-08-02  Anders Carlsson  <andersca@apple.com>
1595
1596         Reviewed by Sam Weinig.
1597
1598         Cache JSNPObjects and fix bugs in the object map
1599         https://bugs.webkit.org/show_bug.cgi?id=43368
1600
1601         Test that we correctly throw exceptions when trying to do things to a JSObject that used to
1602         wrap an NPObject that came from a plug-in that is now destroyed.
1603
1604         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1605         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1606         (PluginTest::Object::getProperty):
1607         (PluginTest::Object::NP_GetProperty):
1608         (PluginTest::Object::npClass):
1609         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp: Added.
1610         (NPRuntimeObjectFromDestroyedPlugin::NPRuntimeObjectFromDestroyedPlugin):
1611         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasProperty):
1612         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::getProperty):
1613         (NPRuntimeObjectFromDestroyedPlugin::NPP_GetValue):
1614         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1615         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1616         * GNUmakefile.am:
1617
1618 2010-08-02  Martin Robinson  <mrobinson@igalia.com>
1619
1620         Reviewed by Xan Lopez.
1621
1622         [Gtk] DOM listeners get wrong keycodes for some keys
1623         https://bugs.webkit.org/show_bug.cgi?id=35170
1624
1625         Add support to all event senders for simulating keypad insert
1626         and print screen keys.
1627
1628         * DumpRenderTree/chromium/EventSender.cpp:
1629         (EventSender::keyDown): Add support for generating keypad insert and print screen.
1630         * DumpRenderTree/gtk/EventSender.cpp:
1631         (keyDownCallback): Ditto.
1632         * DumpRenderTree/mac/EventSendingController.mm:
1633         (-[EventSendingController keyDown:withModifiers:withLocation:]): Ditto.
1634         * DumpRenderTree/qt/EventSenderQt.cpp:
1635         (EventSender::keyDown): Ditto.
1636         * DumpRenderTree/win/EventSender.cpp:
1637         (keyDownCallback): Ditto.
1638
1639 2010-08-02  Martin Robinson  <mrobinson@igalia.com>
1640
1641         Build fix for building against development versions of GTK+. GTK 2.22
1642         has not yet been released, so these function definitions must be conditionalized
1643         on the development version.
1644
1645         * DumpRenderTree/gtk/EventSender.cpp: Fix GTK+ 2.21 build.
1646
1647 2010-08-02  Tony Chang  <tony@chromium.org>
1648
1649         Reviewed by Kent Tamura.
1650
1651         [chromium] use ChromiumDriver on Linux when running webkit tests
1652         https://bugs.webkit.org/show_bug.cgi?id=43273
1653
1654         * Scripts/webkitpy/layout_tests/port/chromium.py:
1655
1656 2010-08-02  Kent Tamura  <tkent@chromium.org>
1657
1658         Reviewed by Dimitri Glazkov.
1659
1660         [DRT/Chromium] Always initialize GTK
1661         https://bugs.webkit.org/show_bug.cgi?id=43327
1662
1663         Call gtk_init() in order to fix plugin test crash.
1664
1665         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1666         (main): Pass argc/argv to platformInit().
1667         * DumpRenderTree/chromium/TestShell.h:
1668         * DumpRenderTree/chromium/TestShellGtk.cpp:
1669         (platformInit): Update parameters, call gtk_init().
1670         * DumpRenderTree/chromium/TestShellMac.mm:
1671         (platformInit): Update parameters.
1672         * DumpRenderTree/chromium/TestShellWin.cpp:
1673         (platformInit): Update parameters.
1674
1675 2010-08-02  Balazs Kelemen  <kb@inf.u-szeged.hu>
1676
1677         Reviewed by Simon Hausmann.
1678
1679         [Qt] Generate forwarding headers for WebKit2
1680
1681         https://bugs.webkit.org/show_bug.cgi?id=43336
1682
1683         * Scripts/webkitdirs.pm: Call make on WebKit2/Makefile.DerivedSources.
1684
1685 2010-08-02  Fumitoshi Ukai  <ukai@chromium.org>
1686
1687         Reviewed by Kent Tamura.
1688
1689         WebSocket server should start with SO_REUSEADDR
1690         https://bugs.webkit.org/show_bug.cgi?id=43329
1691
1692         Pulls in pywebsocket-0.5.2.
1693         pywebsocket-0.5.2 includes a small fix to start server with SO_REUSE_ADDR.
1694         http://code.google.com/p/pywebsocket/source/detail?r=273
1695
1696         * Scripts/webkitpy/thirdparty/__init__.py: Bump pywebsocket version
1697
1698 2010-08-01  Kent Tamura  <tkent@chromium.org>
1699
1700         Reviewed by Dimitri Glazkov.
1701
1702         [DRT/Chromium] Remove string_util.h dependency
1703         https://bugs.webkit.org/show_bug.cgi?id=43312
1704
1705         * DumpRenderTree/chromium/LayoutTestController.cpp:
1706         (LayoutTestController::pathToLocalResource):
1707          Use string::find() instead of StartsWithASCII().
1708         (LayoutTestController::cppVariantToInt32):
1709          Use strtol() instead of StringToNumber().
1710
1711 2010-08-01  Sam Weinig  <sam@webkit.org>
1712
1713         Reviewed by Anders Carlsson.
1714
1715         Add ability to reset frame names for WebKitTestRunner
1716         https://bugs.webkit.org/show_bug.cgi?id=43316
1717
1718         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1719         (WTR::InjectedBundle::reset):
1720         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1721         (WTR::InjectedBundlePage::reset):
1722         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1723
1724 2010-08-01  Anders Carlsson  <andersca@apple.com>
1725
1726         Reviewed by Sam Weinig.
1727
1728         Implement NPN_RemoveProperty
1729         https://bugs.webkit.org/show_bug.cgi?id=43315
1730
1731         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1732         Add NPRuntimeRemoveProperty.cpp
1733         
1734         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1735         (PluginTest::NPN_GetStringIdentifier):
1736         (PluginTest::NPN_GetIntIdentifier):
1737         (PluginTest::NPN_RemoveProperty):
1738         Add NPN_ helpers.
1739
1740         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1741         Support more NPClass functions.
1742
1743         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp: Added.
1744         (NPRuntimeRemoveProperty::NPRuntimeRemoveProperty):
1745         Test for NPN_RemoveProperty.
1746
1747         (NPRuntimeRemoveProperty::TestObject::hasMethod):        
1748         (NPRuntimeRemoveProperty::TestObject::invoke):
1749         Add a testRemoveProperty method.
1750
1751         (NPRuntimeRemoveProperty::NPP_GetValue):
1752         Return the test object.
1753
1754         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1755         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1756         * GNUmakefile.am:
1757         Add NPRuntimeRemoveProperty.cpp
1758
1759 2010-07-30  Anders Carlsson  <andersca@apple.com>
1760
1761         Reviewed by Sam Weinig.
1762
1763         Add an NPObject class template helper to TestNetscapePlugin
1764         https://bugs.webkit.org/show_bug.cgi?id=43288
1765
1766         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1767         Add some template magic to be able to figure out if a class has a member function of a given type.
1768
1769         (PluginTest::Object::create):
1770         Create an object.
1771
1772         (PluginTest::Object::invokeDefault):
1773         Add dummy function, this should never be called.
1774
1775         (PluginTest::Object::Object):
1776         Initialize m_pluginTest to 0.
1777
1778         (PluginTest::Object::~Object):
1779         Add virtual destructor.
1780
1781         (PluginTest::Object::NP_Allocate):
1782         Create a new object.
1783
1784         (PluginTest::Object::NP_Deallocate):
1785         Delete the object.
1786
1787         (PluginTest::Object::NP_InvokeDefault):
1788         Call invokeDefault.
1789
1790         (PluginTest::Object::npClass):
1791         Initialize the NPClass struct.
1792
1793         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
1794         (DocumentOpenInDestroyStream::NPP_DestroyStream):
1795         Move this inline.
1796
1797         * DumpRenderTree/TestNetscapePlugIn/Tests/PluginScriptableNPObjectInvokeDefault.cpp:
1798         (PluginScriptableNPObjectInvokeDefault::NPObjectWithInvokeDefault::invokeDefault):
1799         (PluginScriptableNPObjectInvokeDefault::NPP_GetValue):
1800         Use the PluginTest::Object class template.
1801
1802 2010-07-31  Sam Weinig  <sam@webkit.org>
1803
1804         Reviewed by Dan Bernstein.
1805
1806         Patch for https://bugs.webkit.org/show_bug.cgi?id=43305
1807         Add back WKBundleFrameCopyInnerText to fix ~50 test failures
1808         due to SVGElements not having the innerText function.
1809
1810         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1811         (WTR::dumpFrameText):
1812
1813 2010-07-30  Sam Weinig  <sam@webkit.org>
1814
1815         Reviewed by Maciej Stachowiak.
1816
1817         Patch for https://bugs.webkit.org/show_bug.cgi?id=43290
1818         Add structured message passing from the injected bundle to UIProcess
1819
1820         * MiniBrowser/mac/AppDelegate.m:
1821         (didRecieveMessageFromInjectedBundle):
1822         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1823         (didClearWindowForFrame):
1824         (didRecieveMessage):
1825         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1826         (WTR::InjectedBundle::done):
1827         (WTR::InjectedBundle::didReceiveMessage):
1828         * WebKitTestRunner/TestController.cpp:
1829         (WTR::TestController::initialize):
1830         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1831         * WebKitTestRunner/TestController.h:
1832         * WebKitTestRunner/TestInvocation.cpp:
1833         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1834         * WebKitTestRunner/TestInvocation.h:
1835         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1836
1837 2010-07-30  Sam Weinig  <sam@webkit.org>
1838
1839         Reviewed by Anders Carlsson.
1840
1841         Patch for https://bugs.webkit.org/show_bug.cgi?id=43275
1842         Make WKArrayRef more usable.
1843
1844         Remove now unnecessary const_casts.
1845
1846         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1847         (WTR::dumpDescendantFrameScrollPositions):
1848         (WTR::dumpDescendantFramesText):
1849
1850 2010-07-30  Sam Weinig  <sam@webkit.org>
1851
1852         Reviewed by Anders Carlsson.
1853
1854         Patch for https://bugs.webkit.org/show_bug.cgi?id=43274
1855         Add first pass of structured message passing.
1856
1857         Update Minibrowser and WebKitTestRunner to work with the new post message
1858         function.
1859
1860         * MiniBrowser/mac/AppDelegate.m:
1861         (didRecieveMessageFromInjectedBundle):
1862         (-[BrowserAppDelegate init]):
1863         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
1864         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1865         (didStartProvisionalLoadForFrame):
1866         (didReceiveServerRedirectForProvisionalLoadForFrame):
1867         (didFailProvisionalLoadWithErrorForFrame):
1868         (didCommitLoadForFrame):
1869         (didFinishLoadForFrame):
1870         (didFailLoadWithErrorForFrame):
1871         (didReceiveTitleForFrame):
1872         (didClearWindowForFrame):
1873         (didCreatePage):
1874         (willDestroyPage):
1875         (didRecieveMessage):
1876         (WKBundleInitialize):
1877         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1878         (WTR::InjectedBundle::_didReceiveMessage):
1879         (WTR::InjectedBundle::didReceiveMessage):
1880         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1881         * WebKitTestRunner/TestInvocation.cpp:
1882         (WTR::TestInvocation::invoke):
1883         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1884
1885 2010-07-30  Anders Carlsson  <andersca@apple.com>
1886
1887         Try to fix the layout test failures.
1888
1889         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1890         (webkit_test_plugin_get_value):
1891
1892 2010-07-29  Anders Carlsson  <andersca@apple.com>
1893
1894         Reviewed by Adam Roben.
1895
1896         Replace plugins/npruntime/bindings-test.html with a more sophisticated test
1897         https://bugs.webkit.org/show_bug.cgi?id=43232
1898
1899         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1900         Add PluginScriptableNPObjectInvokeDefault.cpp.
1901
1902         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1903         Remove invokeDefault callback function.
1904
1905         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1906         (PluginTest::create):
1907         Move this to the top of the file.
1908
1909         (PluginTest::NPP_GetValue):
1910         Add default implementation.
1911
1912         (PluginTest::NPN_CreateObject):
1913         Add NPN_ wrapper.
1914
1915         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1916         (PluginTest::identifier):
1917         Add identifier getter.
1918
1919         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
1920         (DocumentOpenInDestroyStream::DocumentOpenInDestroyStream):
1921         Add "using namespace std".
1922
1923         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1924         (NPP_GetValue):
1925         Give PluginTest a chance to return a value.
1926
1927         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1928         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1929         * GNUmakefile.am:
1930         Add PluginScriptableNPObjectInvokeDefault.cpp.
1931         
1932         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1933         (webkit_test_plugin_get_value):
1934         Give PluginTest a chance to return a value.
1935
1936 2010-07-30  Steve Block  <steveblock@google.com>
1937
1938         Reviewed by Steve Block.
1939
1940         Add LayoutTestController methods to test DeviceOrientation
1941         https://bugs.webkit.org/show_bug.cgi?id=39589
1942
1943         * DumpRenderTree/LayoutTestController.cpp:
1944         (setMockDeviceOrientationCallback):
1945         (LayoutTestController::staticFunctions):
1946         * DumpRenderTree/LayoutTestController.h:
1947         * DumpRenderTree/chromium/LayoutTestController.cpp:
1948         (LayoutTestController::LayoutTestController):
1949         (LayoutTestController::setMockDeviceOrientation):
1950         * DumpRenderTree/chromium/LayoutTestController.h:
1951         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1952         (LayoutTestController::setMockDeviceOrientation):
1953         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1954         (LayoutTestController::setMockDeviceOrientation):
1955         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1956         (LayoutTestController::setMockDeviceOrientation):
1957         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1958         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1959         (LayoutTestController::setMockDeviceOrientation):
1960         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1961         (LayoutTestController::setMockDeviceOrientation):
1962         * Scripts/build-webkit:
1963
1964 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
1965
1966         Reviewed by Kenneth Christiansen.
1967
1968         [Qt] QtTestBrowser: -resizes-to-contents command line parameter is broken
1969         https://bugs.webkit.org/show_bug.cgi?id=43209
1970
1971         When -resizes-to-content was being passed as a command line parameter it was simply
1972         not being set (although the corresponding menu item was marked as ON).
1973         User had to toggle the menu OFF and then ON again for it to take place.
1974
1975         Reason: LauncherWindow::applyPrefs method sets many user options passed in from
1976         the command line, but not resizesToContents. Patch addresses that.
1977
1978         * QtTestBrowser/launcherwindow.cpp:
1979         (LauncherWindow::createChrome):
1980         (LauncherWindow::applyPrefs):
1981         (LauncherWindow::toggleResizesToContents):
1982         * QtTestBrowser/webview.h:
1983         (WebViewGraphicsBased::resizesToContents):
1984
1985 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
1986
1987         Rubber-stamped by Simon Fraser.
1988
1989         [Qt] QtTestBrowser: more method grouping and clean ups.
1990
1991         Moving blocks of code around. Basically grouping related methods close to each.
1992
1993         * QtTestBrowser/launcherwindow.cpp:
1994         (LauncherWindow::initializeView):
1995         (LauncherWindow::createChrome):
1996         (LauncherWindow::changeViewportUpdateMode):
1997         (LauncherWindow::showFPS):
1998         (LauncherWindow::newWindow):
1999         (LauncherWindow::cloneWindow):
2000         * QtTestBrowser/launcherwindow.h:
2001
2002 2010-07-30  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2003
2004         Reviewed by Tor Arne Vestbø.
2005
2006         [QT][Symbian] QtTestBrowser missing location capabilities
2007         https://bugs.webkit.org/show_bug.cgi?id=43235
2008
2009         QtTestBrowser missing capabilities to use QtMobility::QLocation. 
2010
2011         * QtTestBrowser/QtTestBrowser.pro:
2012
2013 2010-07-29  Anders Carlsson  <andersca@apple.com>
2014
2015         Add PluginTest.cpp
2016
2017         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2018
2019 2010-07-29  Dirk Pranke  <dpranke@chromium.org>
2020
2021         Reviewed by Eric Seidel.
2022
2023         Update download URLs for python irclib package; the old URLs 
2024         pointed at a specific mirror host and not the general sourceforge
2025         URLs.
2026
2027         https://bugs.webkit.org/show_bug.cgi?id=43228
2028
2029         * Scripts/webkitpy/thirdparty/__init__.py:
2030
2031 2010-07-29  Anders Carlsson  <andersca@apple.com>
2032
2033         Fix typo.
2034
2035         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2036
2037 2010-07-29  Anders Carlsson  <andersca@apple.com>
2038
2039         Another attempt at fixing the Qt and GTK+ build.
2040
2041         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2042         (webkit_test_plugin_new_instance):
2043         (webkit_test_plugin_destroy_stream):
2044
2045 2010-07-29  Anders Carlsson  <andersca@apple.com>
2046
2047         Another build fix attempt.
2048
2049         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2050         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2051         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2052         (webkit_test_plugin_new_instance):
2053         * GNUmakefile.am:
2054
2055 2010-07-29  Anders Carlsson  <andersca@apple.com>
2056
2057         Try to fix Windows and Unix builds.
2058
2059         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2060         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2061         (webkit_test_plugin_new_instance):
2062         (webkit_test_plugin_destroy_stream):
2063
2064 2010-07-29  Anders Carlsson  <andersca@apple.com>
2065
2066         Reviewed by Sam Weinig.
2067
2068         Refactor TestNetscapePlugin so tests can be split in separate files
2069         https://bugs.webkit.org/show_bug.cgi?id=43220
2070
2071         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2072         Add PluginTest.cpp, PluginTest.h and Tests/DocumentOpenInDestroyStream.cpp.
2073
2074         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2075         (pluginAllocate):
2076         Initialize pluginTest to 0. Remove testDocumentOpenInDestroyStream.
2077
2078         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
2079         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: Added.
2080         (PluginTest::PluginTest):
2081         Initialize m_npp and the test identifier.
2082         
2083         (PluginTest::createTestFunctions):
2084         Return the map from identifiers to createTest functions.
2085
2086         (PluginTest::registerCreateTestFunction):
2087         Insert the identifier and create function pair in the map.
2088
2089         (PluginTest::create):
2090         Look for a createTest function. If one is found, call it. Otherwise create a vanilla PluginTest object.
2091
2092         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added.
2093         (PluginTest::Register::Register):
2094         Helper class template for registering plug-in tests.
2095         
2096         (PluginTest::Register::create):
2097         Create a new test of the given type.
2098
2099         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp: Added.
2100         (DocumentOpenInDestroyStream::DocumentOpenInDestroyStream):
2101         Add a test that calls testDocumentOpen from its NPP_DestroyStream callback.
2102
2103         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2104         (NPP_New):
2105         Create a PluginTest given the identifier. Remove the check for "testdocumentopenindestroystream".
2106
2107         (NPP_DestroyStream):
2108         Call the plug-in test NPP_DestroyStream member function.
2109
2110         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2111         Add PluginTest.cpp, PluginTest.h and Tests/DocumentOpenInDestroyStream.cpp.
2112
2113 2010-07-29  Martin Robinson  <mrobinson@igalia.com>
2114
2115         Unreviewed build fix.
2116
2117         Add missing second argument to assert_lint in new style checker tests.
2118
2119         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2120
2121 2010-07-29  Anders Carlsson  <andersca@apple.com>
2122
2123         Reviewed by Adam Roben.
2124
2125         check-webkit-style shouldn't complain about NPAPI functions
2126         https://bugs.webkit.org/show_bug.cgi?id=43211
2127
2128         Allow underscores in functions that start with NPN_, NPP_ or NP_.
2129
2130         * Scripts/webkitpy/style/checkers/cpp.py:
2131         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2132
2133 2010-07-29  Victor Wang  <victorw@chromium.org>
2134
2135         Unreviewed, rolling out r64270.
2136         http://trac.webkit.org/changeset/64270
2137         https://bugs.webkit.org/show_bug.cgi?id=39589
2138
2139         The patch breaks chromium webkit unittest
2140
2141         * DumpRenderTree/LayoutTestController.cpp:
2142         (LayoutTestController::staticFunctions):
2143         * DumpRenderTree/LayoutTestController.h:
2144         * DumpRenderTree/chromium/LayoutTestController.cpp:
2145         (LayoutTestController::LayoutTestController):
2146         * DumpRenderTree/chromium/LayoutTestController.h:
2147         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2148         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2149         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2150         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2151         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2152         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2153         * Scripts/build-webkit:
2154
2155 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
2156
2157         Reviewed by Kenneth Christiansen.
2158
2159         [Qt] QtTestBrowser: Move WebPage class methods definitions from main.cpp to webpage.cpp
2160         https://bugs.webkit.org/show_bug.cgi?id=43199
2161
2162         There is no sense in keeping WebPage method definitions in main.cpp once
2163         webpage.cpp already exists.
2164
2165         No behavior change.
2166
2167         * QtTestBrowser/main.cpp:
2168         * QtTestBrowser/webpage.cpp:
2169         (WebPage::createWindow):
2170         (WebPage::createPlugin):
2171
2172 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
2173
2174         Reviewed by Kenneth Christiansen.
2175
2176         [Qt] Factor out LauncherWindow class out of main.cpp (QtTestBrowser)
2177         https://bugs.webkit.org/show_bug.cgi?id=43170
2178
2179         Moving LauncherWindow class out of main.cpp to its own .cpp and .h files:
2180         launcherwindow.{cpp|h}
2181
2182         No behavior change.
2183
2184         Also changed all global static variables (named "gXXX") from main.cpp to
2185         static public variables of the LauncherWindow class.
2186
2187         * QtTestBrowser/QtTestBrowser.pro:
2188         * QtTestBrowser/launcherwindow.cpp: Added.
2189         * QtTestBrowser/launcherwindow.h: Added.
2190         * QtTestBrowser/main.cpp:
2191         (LauncherApplication::handleUserOptions):
2192         (main):
2193
2194 2010-07-29  Martin Robinson  <mrobinson@igalia.com>
2195
2196         Reviewed by Xan Lopez.
2197
2198         Build fix for building against GTK+ 3.x. GSEAL requires that we
2199         access internals of the GdkDragContext via methods. For older versions
2200         of GTK+, define those methods.
2201
2202         * DumpRenderTree/gtk/EventSender.cpp:
2203         (gdk_drag_context_get_selected_action): Added.
2204         (gdk_drag_context_get_actions): Added.
2205         (dispatchEvent): Use the two new accessor methods.
2206
2207 2010-07-29  Adam Roben  <aroben@apple.com>
2208
2209         Always say "plugins directory" when referring to a directory
2210         containing one or more plugins
2211
2212         Fixes <http://webkit.org/b/43197> WebKit2 often says "plugin
2213         directory" when it means "plugins directory"
2214
2215         Reviewed by John Sullivan.
2216
2217         * WebKitTestRunner/TestController.cpp:
2218         (WTR::TestController::initialize): Updated for rename.
2219
2220 2010-07-29  Adam Roben  <aroben@apple.com>
2221
2222         Always say "directory" when referring to a plugin directory
2223
2224         Fixes <http://webkit.org/b/43195> WebKit2 often says "plugin path"
2225         when it means "plugin directory"
2226
2227         Reviewed by John Sullivan.
2228
2229         * WebKitTestRunner/TestController.cpp:
2230         (WTR::TestController::initialize): Updated for renames.
2231
2232         * WebKitTestRunner/TestController.h: Renamed m_testPluginPath to
2233         m_testPluginDirectory.
2234         (WTR::TestController::testPluginDirectory): Renamed from
2235         testPluginPath.
2236
2237         * WebKitTestRunner/mac/TestControllerMac.mm:
2238         (WTR::TestController::initializeTestPluginDirectory):
2239         * WebKitTestRunner/win/TestControllerWin.cpp:
2240         (WTR::TestController::initializeTestPluginDirectory):
2241         Renamed from initializeTestPluginPath and updated for rename.
2242
2243 2010-07-29  Csaba Osztrogonác  <ossy@webkit.org>
2244
2245          Reviewed by Antonio Gomes.
2246
2247          Initialize all members of NPClass struct.
2248          https://bugs.webkit.org/show_bug.cgi?id=43193
2249
2250          * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2251
2252 2010-07-29  Csaba Osztrogonác  <ossy@webkit.org>
2253
2254         Reviewed by Antonio Gomes.
2255
2256         Warning fix on platforms where XP_MACOSX is undefined.
2257         https://bugs.webkit.org/show_bug.cgi?id=43192
2258
2259         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
2260         Use #if defined(XP_MACOSX) instead of #if XP_MACOSX .
2261
2262 2010-07-29  Adam Roben  <aroben@apple.com>
2263
2264         Give find-included-framework-headers our standard license
2265
2266         * Scripts/find-included-framework-headers: Used the license from
2267         WebCore/LICENSE-APPLE.
2268
2269 2010-07-29  Adam Roben  <aroben@apple.com>
2270
2271         Speed up find-included-framework-headers
2272
2273         We only do one invocation of find now, no longer pipe to grep, and
2274         replace uniq with sort -u.
2275
2276         Also added a license header.
2277
2278         * Scripts/find-included-framework-headers:
2279
2280 2010-07-29  Steve Block  <steveblock@google.com>
2281
2282         Reviewed by Jeremy Orlow.
2283
2284         Add LayoutTestController methods to test DeviceOrientation
2285         https://bugs.webkit.org/show_bug.cgi?id=39589
2286
2287         * DumpRenderTree/LayoutTestController.cpp:
2288         (setMockDeviceOrientationCallback):
2289         (LayoutTestController::staticFunctions):
2290         * DumpRenderTree/LayoutTestController.h:
2291         * DumpRenderTree/chromium/LayoutTestController.cpp:
2292         * DumpRenderTree/chromium/LayoutTestController.h:
2293         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2294         (LayoutTestController::setMockDeviceOrientation):
2295         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2296         (LayoutTestController::setMockDeviceOrientation):
2297         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2298         (LayoutTestController::setMockDeviceOrientation):
2299         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2300         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2301         (LayoutTestController::setMockDeviceOrientation):
2302         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2303         (LayoutTestController::setMockDeviceOrientation):
2304         * Scripts/build-webkit:
2305
2306 2010-07-28  Kenichi Ishibashi  <bashi@google.com>
2307
2308         Reviewed by Shinichiro Hamaji.
2309
2310         Fixed <https://bugs.webkit.org/show_bug.cgi?id=33814>
2311         check-webkit-style gives false positives in single-line functions.
2312
2313         * Scripts/webkitpy/style/checkers/cpp.py:
2314         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2315
2316 2010-07-28  Darin Adler  <darin@apple.com>
2317
2318         Reviewed by Sam Weinig.
2319
2320         WebKitTestRunner needs to support layoutTestController.execCommand
2321         <https://bugs.webkit.org/show_bug.cgi?id=42538>
2322
2323         WebKitTestRunner needs layoutTestController.isCommandEnabled
2324         <https://bugs.webkit.org/show_bug.cgi?id=42671>
2325
2326         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2327         Added execCommand and isCommandEnabled.
2328         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2329         (WTR::LayoutTestController::execCommand): Added.
2330         (WTR::LayoutTestController::isCommandEnabled): Added.
2331         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
2332
2333 2010-07-28  Kent Tamura  <tkent@chromium.org>
2334
2335         Reviewed by Dimitri Glazkov.
2336
2337         [DRT/Chromium] Introduce drt_expectations.txt for NRWT
2338         https://bugs.webkit.org/show_bug.cgi?id=43123
2339
2340         Introduce LayoutTests/platform/chromium/drt_expectations.txt,
2341         which overrides test expectations only for DumpRenderTree, in
2342         order to manage what problems are investigated.
2343         This change will be reverted when we switch to DRT completely.
2344
2345         * Scripts/webkitpy/layout_tests/port/chromium.py:
2346          Add drt_expectations.txt content to the result of
2347          test_expectations_overrides() if --use-drt is specified.
2348
2349 2010-07-28  Brady Eidson  <beidson@apple.com>
2350
2351         Reviewed by Darin Adler.
2352
2353         First pass at visited link support for WK2
2354         https://bugs.webkit.org/show_bug.cgi?id=43157
2355
2356         * MiniBrowser/mac/AppDelegate.m:
2357         (didNavigateWithNavigationData):
2358         (didPerformClientRedirect):
2359         (didPerformServerRedirect):
2360         (didUpdateHistoryTitle):
2361         (populateVisitedLinks): Added for the new version of the HistoryClient.
2362         (-[BrowserAppDelegate init]): Set the HistoryClient right after creating the context(s)
2363         
2364         * MiniBrowser/mac/BrowserWindowController.m:
2365         (-[BrowserWindowController awakeFromNib]):
2366
2367 2010-07-28  Robin Dunn  <robin@alldunn.com>
2368
2369         Reviewed by Kevin Ollivier.
2370
2371         Add DOM bindings support for wx port.
2372
2373         * DumpRenderTree/wscript:
2374         * wx/browser/wscript:
2375         * wx/build/settings.py:
2376
2377 2010-07-28  Tony Chang  <tony@chromium.org>
2378
2379         Reviewed by Kent Tamura.
2380
2381         [chromium] cleanup temp files left by Linux DRT
2382         https://bugs.webkit.org/show_bug.cgi?id=43062
2383
2384         * BuildSlaveSupport/build.webkit.org-config/config.json: Rename the chromium bots to include the OS
2385         * BuildSlaveSupport/build.webkit.org-config/master.cfg: add a step on chromium-linux to delete temp files left
2386             by crashed DRTs
2387
2388 2010-07-28  Antonio Gomes  <tonikitoo@webkit.org>
2389
2390         Rubber-stamped by Kenneth Christiansen.
2391
2392         More Developer menu items reordering.
2393
2394         Grouping related menu items together, visually and logically (in the code).
2395
2396         No behavior change.
2397
2398         * QtTestBrowser/main.cpp:
2399         (LauncherWindow::createChrome):
2400
2401 2010-07-27  Kinuko Yasuda  <kinuko@chromium.org>
2402
2403         Reviewed by Ojan Vafai.
2404
2405         Add FILE_SYSTEM build flag for FileSystem API
2406         https://bugs.webkit.org/show_bug.cgi?id=42915
2407
2408         * Scripts/build-webkit:
2409
2410 2010-07-27  Martin Robinson  <mrobinson@igalia.com>
2411
2412         Reviewed by David Levin.
2413
2414         Stylebot should not complain about NULL usage in calls to gdk_pixbuf_save_to
2415         https://bugs.webkit.org/show_bug.cgi?id=43090
2416
2417         * Scripts/webkitpy/style/checkers/cpp.py: Add exemption for some GdkPixbuf methods.
2418         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added some tests for this behavior.
2419
2420 2010-07-27  Kent Tamura  <tkent@chromium.org>
2421
2422         Unreviewed, trivial typo fix.
2423
2424         * Scripts/webkitpy/layout_tests/port/chromium.py:
2425           Fix a wrong method name committed by r64109.
2426
2427 2010-07-27  Sam Weinig  <sam@webkit.org>
2428
2429         Reviewed by Anders Carlsson.
2430
2431         Patch for https://bugs.webkit.org/show_bug.cgi?id=43087
2432         Clean up handling of strings at the WebKit2 API layer.
2433
2434         * MiniBrowser/mac/BrowserWindowController.m:
2435         (runJavaScriptAlert):
2436         (runJavaScriptConfirm):
2437         (runJavaScriptPrompt):
2438         (didNavigateWithNavigationData):
2439         (-[BrowserWindowController updateProvisionalURLForFrame:]):
2440         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2441         (_didClearWindowForFrame):
2442
2443 2010-07-27  Ojan Vafai  <ojan@chromium.org>
2444
2445         Reviewed by Eric Seidel.
2446
2447         webkit-patch post-commits is broken: AttributeError: Values instance has no attribute 'no_squash'
2448         https://bugs.webkit.org/show_bug.cgi?id=42984
2449
2450         squash and no_squash have been intentionally erroring for a couple weeks now.
2451         But post-commits was just broken. Just remove squash/no_squash.
2452
2453         * Scripts/webkitpy/tool/steps/abstractstep.py:
2454         * Scripts/webkitpy/tool/steps/options.py:
2455
2456 2010-07-27  Kevin Ollivier  <kevino@theolliviers.com>
2457
2458         [wx] Build fix after introduction of EXECUTABLE_ALLOCATOR_DEMAND.
2459
2460         * wx/build/settings.py:
2461
2462 2010-07-27  Adam Roben  <aroben@apple.com>
2463
2464         Mac build fix
2465
2466         * MiniBrowser/mac/BrowserWindowController.m:
2467         (processDidExit):
2468         (-[BrowserWindowController awakeFromNib]):
2469         Added processDidExit support.
2470
2471 2010-07-26  Antonio Gomes  <tonikitoo@webkit.org>
2472
2473         Rubber-stamped by Simon Hausmann.
2474
2475         [Qt] Reorder some items in Developers' menu so QGraphicsView one is easier accessible.
2476
2477         Move some less useful menu items on Developers menu from the top to the bottom, so
2478         QGraphicsView menu goes to the top, and becomes more quickly accessible.
2479
2480         * QtTestBrowser/main.cpp:
2481         (LauncherWindow::createChrome):
2482
2483 2010-07-26  Adam Roben  <aroben@apple.com>
2484
2485         Fix the path to InjectedBundle.dll in Debug_Internal builds
2486
2487         Fixes <http://webkit.org/b/42994> WebKitTestRunner fails to load
2488         InjectedBundle.dll in the Debug_Internal configuration
2489
2490         Reviewed by Anders Carlsson.
2491
2492         * WebKitTestRunner/win/TestControllerWin.cpp:
2493         (WTR::TestController::initializeInjectedBundlePath): Add the _debug
2494         suffix only in Debug_All builds.
2495
2496 2010-07-25  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2497
2498         Reviewed by Darin Adler.
2499
2500         https://bugs.webkit.org/show_bug.cgi?id=42947
2501         Check for WEBKIT_TESTFONTS for qt, gtk and windows port and throw 
2502         error. Without which dumpRenderTree crashes.
2503
2504         * Scripts/old-run-webkit-tests:
2505
2506 2010-07-27  Kent Tamura  <tkent@chromium.org>
2507
2508         Reviewed by Dimitri Glazkov.
2509
2510         https://bugs.webkit.org/show_bug.cgi?id=42956
2511         [DRT/Chromium] Fix "out of sync" assertion error
2512
2513         Fix an assertion error on Windows like the following:
2514         100721 20:16:46 chromium.py:386  CRITICAL Test got out of sync:
2515         |file:///c:/WebKitBuildSlave2/chromium-win-release-tests/build/LayoutTests/http/tests/local/blob/send-data-blob.html|
2516         |file:///C:/WebKitBuildSlave2/chromium-win-release-tests/build/LayoutTests/http/tests/local/blob/send-data-blob.html|
2517
2518         * Scripts/webkitpy/layout_tests/port/chromium.py:
2519         If the url matches with "file:///[a-z]:", does case-ignore comparison.
2520         GURL capitalize the driver letter of a file: URL.
2521
2522 2010-07-26  Darin Adler  <darin@apple.com>
2523
2524         Reviewed by Sam Weinig.
2525
2526         WebKitTestRunner needs to support layoutTestController.counterValueForElementById
2527         https://bugs.webkit.org/show_bug.cgi?id=42537
2528
2529         WebKitTestRunner needs layoutTestController.markerTextForListItem
2530         https://bugs.webkit.org/show_bug.cgi?id=42549
2531
2532         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2533         Fixed _paramterExpression typo. Improved support for string type as a
2534         return value, so we don't try to include DOMString.h and we can convert
2535         the string to a JSValue by calling JSValueMakeStringOrNull.
2536
2537         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
2538         Added JSValueMakeStringOrNull, used by the code generator.
2539
2540         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2541         Added counterValueForElementById and markerTextForListItem.
2542
2543         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2544         Moved constant to the top of the file.
2545         (WTR::toCF): Added. Converts strings to CFStringRef.
2546         (WTR::toWK): Added. Converts strings to WKStringRef.
2547         (WTR::toJS): Added. Converts strings to JSStringRef.
2548         (WTR::setProperty): Moved this function to the top of the file
2549         rather than having it down where it's used inside the class. Also
2550         renamed it so it's a separate function rather than an overload of
2551         JSObjectSetProperty.
2552         (WTR::propertyValue): Copied this here from InjectedBundlePage.cpp.
2553         Should move it somewhere we can share it.
2554         (WTR::propertyObject): Ditto.
2555         (WTR::getElementById): Added. Calls getElementById through the magic
2556         of JavaScript.
2557         (WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId):
2558         Chagned to use toWK instead of four local variables.
2559         (WTR::LayoutTestController::counterValueForElementById): Added.
2560         Calls WKBundleFrameCopyCounterValue.
2561         (WTR::LayoutTestController::markerTextForListItem): Added.
2562         Calls WKBundleFrameCopyMarkerText.
2563
2564         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2565         Added counterValueForElementById and markerTextForListItem.
2566
2567 2010-07-26  Martin Robinson  <mrobinson@igalia.com>
2568
2569         Reviewed by Gustavo Noronha Silva.
2570
2571         [GTK] The EventSender should support simulating drop events
2572         https://bugs.webkit.org/show_bug.cgi?id=39844
2573
2574         Add initial dropping support to the GTK+ EventSender.
2575
2576         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2577         (createWebView): Listen for some new drag-and-drop signals.
2578         * DumpRenderTree/gtk/EventSender.cpp: Add currentDragSourceContext.
2579         (dispatchEvent):
2580         Detect situations where a drag is either starting or ending and massage
2581         GTK+ into sending the appropriate signals to the WebView.
2582         (replaySavedEvents): Remove comment.
2583         (makeEventSender): Clear the currentDragSourceContext when creating a new EventSender.
2584         (dragBeginCallback): Capture the new currentDragSourceContext when a drag begins.
2585         (dragEndCallback): Clear the currentDragSourceContext when a drag ends.
2586         (dragFailedCallback): Disable the GTK+ drag failed animation.
2587         * DumpRenderTree/gtk/EventSender.h: Add declarations for new signal callbacks.
2588
2589 2010-07-26  Daniel Bates  <dbates@rim.com>
2590
2591         Reviewed by Darin Adler.
2592
2593         svn-unapply warns of uninitialized variable when unapplying
2594         a patch that describes an svn move operation
2595         https://bugs.webkit.org/show_bug.cgi?id=42036
2596
2597         Fixes Perl uninitialized variable warnings when un-applying
2598         a patch that moves a file.
2599
2600         * Scripts/svn-unapply:
2601           - Modified patch() so that it initializes $patch to the empty
2602             string when we don't have svnConvertedText (such as when
2603             reversing a diff that represents a svn copy/move operation).
2604
2605 2010-07-26  Sam Weinig  <sam@webkit.org>
2606
2607         Reviewed by Anders Carlsson.
2608
2609         Move some non-APIish functions into private headers.
2610
2611         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2612         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2613
2614 2010-07-26  Sam Weinig  <sam@webkit.org>
2615
2616         Reviewed by Anders Carlsson.
2617
2618         Fix for https://bugs.webkit.org/show_bug.cgi?id=42986
2619         Add prompt and confirm client functions to WebKit2
2620
2621         * MiniBrowser/mac/BrowserWindowController.m:
2622         (-[BrowserWindowController awakeFromNib]):
2623
2624 2010-07-26  Adam Roben  <aroben@apple.com>
2625
2626         Windows build fix
2627
2628         * MiniBrowser/MiniBrowser.vcproj:
2629         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
2630         Removed empty attributes so the values will be picked up from the
2631         vsprops files. (Also removed a couple of attributes that accidentally
2632         duplicated values from the vsprops files.)
2633
2634 2010-07-26  Brian Weinstein  <bweinstein@apple.com>
2635
2636         Rubber-stamped by Adam Roben.
2637         
2638         Touch MiniBrowser's stdafx to fix the build.
2639
2640         * MiniBrowser/win/stdafx.h:
2641
2642 2010-07-26  Hayato Ito  <hayato@chromium.org>
2643
2644         Reviewed by Shinichiro Hamaji.
2645
2646         Add pretty printer of WTF::Vector for GDB 7.
2647
2648         https://bugs.webkit.org/show_bug.cgi?id=40909
2649
2650         * gdb/wtf.py: Added.
2651
2652 2010-07-26  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2653
2654         Reviewed by Simon Hausmann.
2655
2656         [Qt] Fix feature detection regexp
2657
2658         We were missing the last feature
2659
2660         * Scripts/webkitdirs.pm:
2661
2662 2010-07-25  Darin Adler  <darin@apple.com>
2663
2664         Reviewed by Dan Bernstein.
2665
2666         WebKitTestRunner needs to support layoutTestController.dumpSelectionRect
2667         https://bugs.webkit.org/show_bug.cgi?id=42326
2668
2669         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2670         Added dumpSelectionRect.
2671
2672         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2673         (WTR::LayoutTestController::dumpSelectionRect): Added. For now, this
2674         does nothing because its purpose is to change pixel test output and
2675         we do not have pixel tests implemented yet.
2676
2677 2010-07-25  Darin Adler  <darin@apple.com>
2678
2679         Reviewed by Maciej Stachowiak.
2680
2681         WebKitTestRunner needs to support layoutTestController.keepWebHistory
2682         https://bugs.webkit.org/show_bug.cgi?id=42323
2683
2684         Added keepWebHistory and computedStyleIncludingVisitedInfo.
2685
2686         Also fixed misspellings of the word "receive".
2687
2688         Also tweaked the names of some of the LayoutTestController members.
2689
2690         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2691         Added support for a type named "object" that is passed and returns as
2692         a JSValueRef.
2693
2694         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2695         Added keepWebHistory and computedStyleIncludingVisitedInfo. Also
2696         put setAcceptsEditing up nearer the top.
2697
2698         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2699         (WTR::InjectedBundle::_didReceiveMessage): Fixed mispellings of receive.
2700         (WTR::InjectedBundle::initialize): Ditto.
2701         (WTR::InjectedBundle::didReceiveMessage): Ditto.
2702         (WTR::InjectedBundle::reset): Reset the state of visited links between
2703         tests. Also eliminated the unused argument to the LayoutTestController
2704         create function.
2705         (WTR::InjectedBundle::setShouldTrackVisitedLinks): Added.
2706         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Ditto.
2707
2708         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2709         (WTR::InjectedBundlePage::shouldBeginEditing): Call shouldAllowEditing
2710         instead of acceptsEditing.
2711         (WTR::InjectedBundlePage::shouldEndEditing): Ditto.
2712         (WTR::InjectedBundlePage::shouldInsertNode): Ditto.
2713         (WTR::InjectedBundlePage::shouldInsertText): Ditto.
2714         (WTR::InjectedBundlePage::shouldDeleteRange): Ditto.
2715         (WTR::InjectedBundlePage::shouldChangeSelectedRange): Ditto.
2716         (WTR::InjectedBundlePage::shouldApplyStyle): Ditto.
2717
2718         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2719         (WTR::LayoutTestController::create): Removed uneeded argument.
2720         (WTR::LayoutTestController::LayoutTestController): Removed unneeded
2721         argument. Updated for rename of m_acceptsEditing to m_shouldAllowEditing.
2722         (WTR::LayoutTestController::numberOfActiveAnimations): Added some FIXMEs
2723         about the fact that this works on the main frame.
2724         (WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId): Ditto.
2725         (WTR::LayoutTestController::keepWebHistory): Added.
2726         (WTR::LayoutTestController::computedStyleIncludingVisitedInfo): Added.
2727         (WTR::JSObjectSetProperty): Added. Helper to make the function below
2728         cleaner.
2729         (WTR::LayoutTestController::makeWindowObject): Changed to use the
2730         overload of JSObjectSetProperty above.
2731
2732         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Changes to
2733         match above.
2734
2735         * WebKitTestRunner/TestController.cpp:
2736         (WTR::TestController::initialize): Fixed mispellings of receive.
2737         (WTR::TestController::_didReceiveMessageFromInjectedBundle): Ditto.
2738         (WTR::TestController::didReceiveMessageFromInjectedBundle): Ditto.
2739         * WebKitTestRunner/TestController.h: Ditto.
2740         * WebKitTestRunner/TestInvocation.cpp:
2741         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Ditto.
2742         * WebKitTestRunner/TestInvocation.h: Ditto.
2743
2744 2010-07-25  Alexey Proskuryakov  <ap@apple.com>
2745
2746         Reviewed by Sam Weinig.
2747
2748         https://bugs.webkit.org/show_bug.cgi?id=42193
2749         Support layoutTestController.dumpEditingDelegates in WebKitTestRunner
2750
2751         Step 2 - add the rest of editing delegates.
2752
2753         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2754         (WTR::operator<<): Fixed to not crash when range is null.
2755         (WTR::InjectedBundlePage::InjectedBundlePage):
2756         (WTR::InjectedBundlePage::_shouldEndEditing):
2757         (WTR::InjectedBundlePage::_shouldInsertNode):
2758         (WTR::InjectedBundlePage::_shouldInsertText):
2759         (WTR::InjectedBundlePage::_shouldDeleteRange):
2760         (WTR::InjectedBundlePage::_shouldChangeSelectedRange):
2761         (WTR::InjectedBundlePage::_shouldApplyStyle):
2762         (WTR::InjectedBundlePage::_didBeginEditing):
2763         (WTR::InjectedBundlePage::_didEndEditing):
2764         (WTR::InjectedBundlePage::_didChange):
2765         (WTR::InjectedBundlePage::_didChangeSelection):
2766         (WTR::InjectedBundlePage::shouldEndEditing):
2767         (WTR::InjectedBundlePage::shouldInsertNode):
2768         (WTR::InjectedBundlePage::shouldInsertText):
2769         (WTR::InjectedBundlePage::shouldDeleteRange):
2770         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
2771         (WTR::InjectedBundlePage::shouldApplyStyle):
2772         (WTR::InjectedBundlePage::didBeginEditing):
2773         (WTR::InjectedBundlePage::didEndEditing):
2774         (WTR::InjectedBundlePage::didChange):
2775         (WTR::InjectedBundlePage::didChangeSelection):
2776         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2777
2778 2010-07-24  Chris Fleizach  <cfleizach@apple.com>
2779
2780         Reviewed by David Kilzer.
2781
2782         AX: need a layout test testing misspelled words in attributed strings
2783         https://bugs.webkit.org/show_bug.cgi?id=42899
2784
2785         * DumpRenderTree/AccessibilityUIElement.cpp:
2786         (attributedStringForRangeCallback):
2787         (attributedStringRangeIsMisspelledCallback):
2788         (AccessibilityUIElement::getJSClass):
2789         * DumpRenderTree/AccessibilityUIElement.h:
2790         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2791         (AccessibilityUIElement::attributedStringForRange):
2792         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
2793         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2794         (AccessibilityUIElement::attributedStringForRange):
2795         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
2796         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2797         (AccessibilityUIElement::attributedStringForRange):
2798         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
2799
2800 2010-07-23  David Kilzer  <ddkilzer@apple.com>
2801
2802         <http://webkit.org/b/42911> Update ruby tools to work with shallow framework bundles
2803
2804         Reviewed by Mark Rowe.
2805
2806         * Scripts/check-for-inappropriate-files-in-framework: Added
2807         check for the SHALLOW_BUNDLE environment variable so that the
2808         script will work with iOS WebKit builds.
2809         * Scripts/check-for-webkit-framework-include-consistency: Ditto.
2810
2811 2010-07-22  Darin Adler  <darin@apple.com>
2812
2813         Reviewed by Sam Weinig.
2814
2815         Eliminate unneeded WKBundleFrameCopyInnerText function from WebKit2
2816         https://bugs.webkit.org/show_bug.cgi?id=42847
2817
2818         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2819         (WTR::operator<<): Replaced the WKStringToUTF8 function with
2820         a set of overloaded stream operators.
2821         (WTR::dumpPath): Changed to use ostringstream and return a string.
2822         (WTR::propertyValue): Added.
2823         (WTR::propertyObject): Added.
2824         (WTR::propertyString): Added.
2825         (WTR::numericWindowPropertyValue): Changed to call propertyValue.
2826         (WTR::dumpFrameScrollPosition): Removed now unneeded WKStringToUTF8 sequence
2827         since we now have suitable streaming functions.
2828         (WTR::dumpFrameText): Use propertyObject and propertyString instead of
2829         WKBundleFrameCopyInnerText.
2830         (WTR::dumpDescendantFramesText): Removed now unneeded WKStringToUTF8 sequence
2831         since we now have suitable streaming functions.
2832         (WTR::InjectedBundlePage::dump): Ditto.
2833         (WTR::InjectedBundlePage::willAddMessageToConsole): Ditto.
2834         (WTR::InjectedBundlePage::willSetStatusbarText): Ditto.
2835         (WTR::InjectedBundlePage::willRunJavaScriptAlert): Ditto.
2836         (WTR::InjectedBundlePage::willRunJavaScriptConfirm): Ditto.
2837         (WTR::InjectedBundlePage::willRunJavaScriptPrompt): Ditto.
2838
2839 2010-07-22  Alexey Proskuryakov  <ap@apple.com>
2840
2841         Reviewed by Sam Weinig and Darin Adler.
2842
2843         https://bugs.webkit.org/show_bug.cgi?id=42193
2844         Support layoutTestController.dumpEditingDelegates in WebKitTestRunner
2845
2846         Step 1: Add the method, and implement one actual delegate call as proof of concept. No tests
2847         fixed, but this makes difference one line smaller on many editing tests.
2848
2849         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2850         Added dumpEditingCallbacks() and setAcceptsEditing().
2851
2852         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2853         (WTR::dumpPath): Dump path to a node in a format that's compatible with DumpRenderTree.
2854         (WTR::operator<<): Print a range.
2855         (WTR::InjectedBundlePage::InjectedBundlePage): Set editor client in addition to existing
2856         clients.
2857         (WTR::InjectedBundlePage::_shouldBeginEditing): The only client method implemented so far.
2858         (WTR::InjectedBundlePage::shouldBeginEditing): Ditto.
2859         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added a section for editor client
2860         calls.
2861
2862         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2863         (WTR::LayoutTestController::LayoutTestController):
2864         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2865         (WTR::LayoutTestController::dumpEditingCallbacks):
2866         (WTR::LayoutTestController::setAcceptsEditing):
2867         (WTR::LayoutTestController::acceptsEditing):
2868         (WTR::LayoutTestController::shouldDumpEditingCallbacks):
2869         Store m_acceptsEditing and m_dumpEditingCallbacks.
2870
2871 2010-07-22  Yael Aharon  <yael.aharon@nokia.com>
2872
2873         Reviewed by Laszlo Gombos.
2874
2875         [Qt] QtWebKit needs public API for Notifications.
2876         https://bugs.webkit.org/show_bug.cgi?id=41413
2877
2878         Update DumpRenderTree and QtTestBrowser to use the new API.
2879         Add new DRT API to flag that notifications permission requests should be ignored.
2880
2881         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2882         (WebCore::WebPage::WebPage):
2883         (WebCore::WebPage::requestPermission):
2884         (WebCore::WebPage::checkPermission):
2885         (WebCore::WebPage::cancelRequestsForPermission):
2886         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2887         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2888         (LayoutTestController::reset):
2889         (LayoutTestController::ignoreDesktopNotificationPermissionRequests):
2890         (LayoutTestController::checkDesktopNotificationPermission):
2891         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2892         (LayoutTestController::ignoreReqestForPermission):
2893         * QtTestBrowser/main.cpp:
2894         (LauncherWindow::LauncherWindow):
2895         * QtTestBrowser/webpage.cpp:
2896         (WebPage::WebPage):
2897         (WebPage::requestPermission):
2898         (WebPage::checkPermission):
2899         (WebPage::cancelRequestsForPermission):
2900         * QtTestBrowser/webpage.h:
2901
2902 2010-07-22  Darin Adler  <darin@apple.com>
2903
2904         Reviewed by Sam Weinig.
2905
2906         WebKitTestRunner needs to support layoutTestController.dumpChildFramesAsText
2907         https://bugs.webkit.org/show_bug.cgi?id=42325
2908
2909         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2910         Added dumpChildFramesAsText.
2911
2912         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2913         (WTR::dumpFrameText): Added.
2914         (WTR::dumpDescendantFramesText): Added.
2915         (WTR::InjectedBundlePage::dumpAllFramesText): Added.
2916         (WTR::InjectedBundlePage::dump): Changed to use the new whatToDump function
2917         instead of the shouldDumpAsText function, and added a case for AllFramesText.
2918
2919         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added dumpAllFramesText.
2920
2921         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2922         (WTR::LayoutTestController::LayoutTestController): Replaced m_dumpAsText with
2923         m_whatToDump.
2924
2925         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added
2926         dumpChildFramesAsText. Removed shouldDumpAsText, shouldDumpDOMAsWebArchive,
2927         and shouldDumpSourceAsWebArchive. Added whatToDump.
2928
2929 2010-07-22  Adam Roben  <aroben@apple.com>
2930
2931         Windows build fix
2932
2933         Inspired by r63881.
2934
2935         * MiniBrowser/MiniBrowser.vcproj:
2936         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
2937         Removed pre- and post-build events so they will be inherited from the
2938         vsprops files.
2939
2940 2010-07-21  Darin Adler  <darin@apple.com>
2941
2942         Reviewed by Sam Weinig.
2943
2944         WebKitTestRunner needs layoutTestController.dumpChildFrameScrollPositions
2945         https://bugs.webkit.org/show_bug.cgi?id=42548
2946
2947         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2948         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2949         (WTR::numericWindowPropertyValue): Renamed this and moved it up higher in the file.
2950         (WTR::dumpFrameScrollPosition): Added argument telling whether to dump the frame name.
2951         Changed to a file-internal function instead of a member function.
2952         (WTR::dumpDescendantFrameScrollPositions): Added.
2953         (WTR::InjectedBundlePage::dumpAllFrameScrollPositions): Added.
2954         (WTR::InjectedBundlePage::dump): Changed to call dumpAllFrameScrollPositions when
2955         appropriate. Also streamlined all the WKStringToUTF8 call sites.
2956         (WTR::InjectedBundlePage::willAddMessageToConsole): Streamlined use of WKStringToUTF8.
2957         (WTR::InjectedBundlePage::willSetStatusbarText): Ditto.
2958         (WTR::InjectedBundlePage::willRunJavaScriptAlert): Ditto.
2959         (WTR::InjectedBundlePage::willRunJavaScriptConfirm): Ditto.
2960         (WTR::InjectedBundlePage::willRunJavaScriptPrompt): Ditto.
2961
2962         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Updated for above changes.
2963
2964         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2965         (WTR::LayoutTestController::LayoutTestController): Initialize
2966         m_shouldDumpAllFrameScrollPositions.
2967         (WTR::LayoutTestController::shouldDumpMainFrameScrollPosition): Renamed from
2968         shouldDumpFrameScrollPositions.
2969
2970         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Reorganized the file a
2971         bit, added dumpChildFrameScrollPositions and shouldDumpAllFrameScrollPositions,
2972         and renamed shouldDumpFrameScrollPositions to shouldDumpMainFrameScrollPosition.
2973
2974 2010-07-21  Darin Adler  <darin@apple.com>
2975
2976         Reviewed by Sam Weinig.
2977
2978         WebKitTestRunner needs to support dumping of scroll position
2979         https://bugs.webkit.org/show_bug.cgi?id=42514
2980
2981         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2982         (_didClearWindowForFrame): Use JSGlobalContextRef instead of JSContextRef.
2983
2984         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2985         (WTR::InjectedBundlePage::_didClearWindowForFrame): Use JSGlobalContextRef
2986         instead of JSContextRef.
2987         (WTR::InjectedBundlePage::dump): Call dumpFrameScrollPosition when appropriate.
2988         (WTR::numericWindowProperty): Added. Helper for dumpFrameScrollPosition.
2989         (WTR::InjectedBundlePage::dumpFrameScrollPosition): Added.
2990         (WTR::InjectedBundlePage::didClearWindowForFrame): Use JSGlobalContextRef
2991         instead of JSContextRef.
2992
2993         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Removed names from
2994         arguments that simply repeat the argument type. Added dumpFrameScrollPosition.
2995
2996         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2997         (WTR::LayoutTestController::shouldDumpDOMAsWebArchive): Added. Currently
2998         returns false.
2999         (WTR::LayoutTestController::shouldDumpSourceAsWebArchive): Added. Currently
3000         returns false.
3001         (WTR::LayoutTestController::shouldDumpFrameScrollPositions): Added. Matches
3002         the logic in DumpRenderTree.
3003
3004         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Updated for above changes.
3005
3006         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Added property svn:ignore.
3007
3008 2010-07-21  Kevin Ollivier  <kevino@theolliviers.com>
3009
3010         [wx] Build fix, adding the WebCore/bindings/generic dir to the list of build dirs.
3011
3012         * wx/build/settings.py:
3013
3014 2010-07-21  Sam Weinig  <sam@webkit.org>
3015
3016         Reviewed by Anders Carlsson.
3017
3018         Patch for https://bugs.webkit.org/show_bug.cgi?id=42539
3019         WebKitTestRunner needs to support printing ALERT, PROMPT and CONFIRM messages
3020
3021         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3022         (WTR::InjectedBundlePage::InjectedBundlePage):
3023         (WTR::InjectedBundlePage::_willAddMessageToConsole):
3024         (WTR::InjectedBundlePage::_willSetStatusbarText):
3025         (WTR::InjectedBundlePage::_willRunJavaScriptAlert):
3026         (WTR::InjectedBundlePage::_willRunJavaScriptConfirm):
3027         (WTR::InjectedBundlePage::_willRunJavaScriptPrompt):
3028         (WTR::InjectedBundlePage::willAddMessageToConsole):
3029         (WTR::InjectedBundlePage::willSetStatusbarText):
3030         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
3031         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
3032         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
3033         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3034
3035 2010-07-21  Adam Roben  <aroben@apple.com>
3036
3037         Give InjectedBundle our standard set of configurations (minus the
3038         *_Cairo variants)
3039
3040         InjectedBundle's Debug_All configuration was the same as is Debug
3041         configuration, and it was missing a Debug_Internal configuration.
3042
3043         Fixes <http://webkit.org/b/42749> InjectedBundle's build
3044         configurations are screwy
3045
3046         Reviewed by Darin Adler.
3047
3048         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: Added
3049         debug_internal.vsprops and debug_all.vsprops to the Debug_All
3050         configuration. Added a Debug_Internal configuration.
3051
3052         * WebKitTestRunner/WebKitTestRunner.sln: Build the Debug_Internal
3053         variant of InjectedBundle when we're using the Debug_Internal solution
3054         configuration.
3055
3056 2010-07-21  Adam Roben  <aroben@apple.com>
3057
3058         Move InjectedBundle's settings to a vsprops file
3059
3060         This will make it easier to change settings for all configurations,
3061         and to add new configurations.
3062
3063         Fixes <http://webkit.org/b/42748> InjectedBundle should use vsprops
3064         files
3065
3066         Reviewed by Darin Adler.
3067
3068         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added.
3069         Moved settings here...
3070         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: ...from
3071         here.
3072
3073 2010-07-21  Adam Roben  <aroben@apple.com>
3074
3075         Give MiniBrowser our standard set of configurations (minus the *_Cairo
3076         variants)
3077
3078         MiniBrowser already had a configuration called "Release", but it was
3079         using mostly the same settings as Debug. And its Debug configuration
3080         was using the settings that Debug_Internal should be using.
3081
3082         Fixes <http://webkit.org/b/42746> MiniBrowser's build configurations
3083         are screwy
3084
3085         Reviewed by Darin Adler.
3086
3087         * MiniBrowser/MiniBrowser.vcproj: Removed debug_internal.vsprops from
3088         the Debug configuration. Remove debug.vsprops and
3089         debug_internal.vsprops from the Release configuration and replace them
3090         with release.vsprops. Added Debug_Internal and Debug_All
3091         configurations.
3092
3093 2010-07-21  Adam Roben  <aroben@apple.com>
3094
3095         Move MiniBrowser's settings to a vsprops file
3096
3097         This will make it easier to change settings for all configurations,
3098         and to add new configurations.
3099
3100         MiniBrowser should use vsprops files
3101         https://bugs.webkit.org/show_bug.cgi?id=42745
3102
3103         Reviewed by Darin Adler.
3104
3105         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added. Moved
3106         settings here...
3107         * MiniBrowser/MiniBrowser.vcproj: ...from here.
3108
3109 2010-07-21  Adam Roben  <aroben@apple.com>
3110
3111         Fix compiler warnings when building MiniBrowser
3112
3113         Also cleaned up the .vcproj a bit.
3114
3115         Fixes <http://webkit.org/b/42743>.
3116
3117         Reviewed by Darin Adler.
3118
3119         * MiniBrowser/MiniBrowser.vcproj: Removed all settings that are
3120         already defined in .vsprops files. This also fixes a warning about
3121         /EDITANDCONTINUE being incompatible with /SAFESEH.
3122
3123         * MiniBrowser/win/MiniBrowser.rc: Replaced afxres.h with winresrc.h so
3124         that we stop getting warnings about ID_FILE_OPEN and ID_FILE_CLOSE
3125         being redefined. (I think this will also get us closer to building
3126         with VC++ Express.)
3127
3128 2010-07-20  Sam Weinig  <sam@webkit.org>
3129
3130         Reviewed by Jon Honeycutt.
3131
3132         Fix obvious typo.
3133
3134         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3135         (WTR::InjectedBundlePage::setStatusbarText): Need to call ->data() to actually get the string value.
3136
3137 2010-07-20  Tony Chang  <tony@chromium.org>
3138
3139         Reviewed by Kent Tamura.
3140
3141         [chromium] by default, dumpAsText should disable pixel results
3142         https://bugs.webkit.org/show_bug.cgi?id=42715
3143
3144         * DumpRenderTree/chromium/LayoutTestController.cpp:
3145         (LayoutTestController::dumpAsText): disable pixel results, but allow JS to override
3146
3147 2010-07-20  Adam Roben  <aroben@apple.com>
3148
3149         Windows build fix
3150
3151         * MiniBrowser/MiniBrowser.vcproj: Link against the new, shiny
3152         WebKit.lib instead of the old, dusty WebKit2.lib.
3153
3154 2010-07-20  Adam Roben  <aroben@apple.com>
3155
3156         Stop linking WebKitTestRunner against getopt
3157
3158         Use of getopt was removed in r63700.
3159
3160         Fixes <http://webkit.org/b/42714> WebKitTestRunner links against
3161         getopt, but doesn't need to
3162
3163         Reviewed by Sam Weinig.
3164
3165         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Removed getopt.lib
3166         from all configurations.
3167
3168 2010-07-20  Adam Roben  <aroben@apple.com>
3169
3170         Make run-webkit-tests --webkit-test-runner "work" on Windows
3171
3172         WebKitTestRunner crashes on launch, but at least the scripts build and
3173         launch it!
3174
3175         Fixes <http://webkit.org/b/42709> run-webkit-tests
3176         --webkit-test-runner bails with an error on Windows
3177
3178         Reviewed by Anders Carlsson.
3179
3180         * Scripts/build-webkittestrunner: Build WebKitTestRunner.sln on
3181         Windows.
3182         * WebKitTestRunner/WebKitTestRunner.sln: Added. Contains the following
3183         projects (from first-built to last-built): FindSafari, ImageDiff,
3184         InjectedBundleGenerated, InjectedBundle, WebKitTestRunner.
3185
3186 2010-07-20  Adam Roben  <aroben@apple.com>
3187
3188         Change build-webkit back to building WebKit.sln on Windows
3189
3190         WebKit.sln builds all the same projects as WebKit2.sln, and the latter
3191         is being removed.
3192
3193         Rubber-stamped in advance by Steve Falkenburg.
3194
3195         * Scripts/build-webkit:
3196
3197 2010-07-20  Adam Roben  <aroben@apple.com>
3198
3199         Windows build fix
3200
3201         * MiniBrowser/win/BrowserWindow.cpp: Added missing #include.
3202
3203 2010-07-20  Joseph Pecoraro  <joepeck@webkit.org>
3204
3205         Reviewed by Geoffrey Garen.
3206
3207         WebScriptObject Should Allow Safely Checking For Key Existence
3208         https://bugs.webkit.org/show_bug.cgi?id=42613
3209
3210         Normal ObjCController workflow for a WebScriptObject test.
3211
3212         * DumpRenderTree/mac/ObjCController.m:
3213         (+[ObjCController isSelectorExcludedFromWebScript:]):
3214         (+[ObjCController webScriptNameForSelector:]):
3215         (-[ObjCController testHasWebScriptKey:]):
3216
3217 2010-07-20  Chris Marrin  <cmarrin@apple.com>
3218
3219         Reviewed by Simon Fraser.
3220
3221         https://bugs.webkit.org/show_bug.cgi?id=42118
3222         Disable compositing/webgl tests if WebGL is not enabled
3223
3224         * Scripts/old-run-webkit-tests:
3225
3226 2010-07-20  Anton Muhin  <antonm@chromium.org>
3227
3228         Reviewed by Darin Adler.
3229
3230         Print additional information about exception if failed to connect to apache (in verbose mode).
3231         https://bugs.webkit.org/show_bug.cgi?id=42627
3232
3233         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
3234
3235 2010-07-20  Tony Chang  <tony@chromium.org>
3236
3237         Reviewed by David Levin.
3238
3239         [chromium] only pass --force to gclient sync if explicitly stated
3240         https://bugs.webkit.org/show_bug.cgi?id=42581
3241
3242         * BuildSlaveSupport/build.webkit.org-config/master.cfg: bots should
3243               always pass --force since it's hard to do manual cleanups
3244         * Scripts/update-webkit-chromium: only pass --force if --force is
3245               passed in
3246
3247 2010-07-19  Anders Carlsson  <andersca@apple.com>
3248
3249         Fix build.
3250
3251         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3252         Paths of generated files should be relative to the build product.
3253
3254 2010-07-19  Daniel Bates  <dbates@rim.com>
3255
3256         Reviewed by Adam Roben.
3257
3258         [Win] Implement LayoutTestController::markerTextForListItem()
3259         https://bugs.webkit.org/show_bug.cgi?id=37930
3260
3261         Implements DRT support for markerTextForListItem in the Windows port.
3262
3263         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3264         (LayoutTestController::markerTextForListItem): Implemented.
3265
3266 2010-07-19  Jessie Berlin  <jberlin@apple.com>
3267
3268         Windows build fix. Unreviewed.
3269
3270         * WebKitTestRunner/win/TestControllerWin.cpp:
3271         (WTR::TestController::initializeTestPluginPath):
3272
3273 2010-07-19  Sam Weinig  <sam@webkit.org>
3274
3275         Reviewed by Jon Honeycutt.
3276
3277         Remove dependency on getopt from WebKitTestRunner.
3278
3279         - Simplify options parsing and eliminate unused options.
3280
3281         * WebKitTestRunner/TestController.cpp:
3282         (WTR::TestController::TestController):
3283         (WTR::TestController::initialize):
3284         * WebKitTestRunner/TestController.h:
3285         (WTR::TestController::testPluginPath):
3286         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3287         * WebKitTestRunner/mac/TestControllerMac.mm:
3288         (WTR::TestController::platformInitialize):
3289         (WTR::TestController::initializeTestPluginPath):
3290         * WebKitTestRunner/win/TestControllerWin.cpp:
3291         (WTR::TestController::platformInitialize):
3292         (WTR::TestController::initializeTestPluginPath):
3293
3294 2010-07-19  Diego Gonzalez  <diegohcg@webkit.org>
3295
3296         Reviewed by Antonio Gomes.
3297
3298         [Qt] MiniBrowser: Progress indication at address bar
3299         https://bugs.webkit.org/show_bug.cgi?id=42565
3300
3301         Make possible to see load progress at address bar based on
3302         QtTestBrowser solution
3303
3304         * MiniBrowser/qt/BrowserWindow.cpp:
3305         (BrowserWindow::BrowserWindow):
3306         (BrowserWindow::loadProgress):
3307         * MiniBrowser/qt/BrowserWindow.h:
3308
3309 2010-07-19  Diego Gonzalez  <diegohcg@webkit.org>
3310
3311         Reviewed by Antonio Gomes.
3312
3313         [Qt] Add MiniBrowser features: urlChanged, titleChanged and from user input load
3314         https://bugs.webkit.org/show_bug.cgi?id=42564
3315
3316         * MiniBrowser/qt/BrowserWindow.cpp:
3317         (BrowserView::load):
3318         (BrowserWindow::BrowserWindow):
3319         (BrowserWindow::titleChanged):
3320         (BrowserWindow::urlChanged):
3321         * MiniBrowser/qt/BrowserWindow.h:
3322
3323 2010-07-19  Sam Weinig  <weinig@apple.com>
3324
3325         Reviewed by Adam Roben.
3326
3327         Patch for https://bugs.webkit.org/show_bug.cgi?id=42532
3328         Auto-generate the JS bindings for WebKitTestRunner's script objects.
3329
3330         * WebKitTestRunner/Configurations/Base.xcconfig:
3331         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3332         * WebKitTestRunner/DerivedSources.make: Added.
3333         * WebKitTestRunner/ForwardingHeaders/wtf/GetPtr.h: Added.
3334         * WebKitTestRunner/InjectedBundle/Bindings: Added.
3335         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Added.
3336         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h: Added.
3337         (WTR::JSWrappable::~JSWrappable):
3338         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp: Added.
3339         (WTR::JSWrapper::wrap):
3340         (WTR::JSWrapper::unwrap):
3341         (WTR::unwrapObject):
3342         (WTR::JSWrapper::initialize):
3343         (WTR::JSWrapper::finalize):
3344         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h: Added.
3345         (WTR::toJS):
3346         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added.
3347         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3348         (WTR::InjectedBundlePage::dump):
3349         (WTR::InjectedBundlePage::setStatusbarText):
3350         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3351         (WTR::LayoutTestController::wrapperClass):
3352         (WTR::LayoutTestController::waitUntilDone):
3353         (WTR::LayoutTestController::makeWindowObject):
3354         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3355         (WTR::LayoutTestController::shouldDumpAsText):
3356         (WTR::LayoutTestController::dumpAsText):
3357         (WTR::LayoutTestController::shouldDumpStatusCallbacks):
3358         (WTR::LayoutTestController::dumpStatusCallbacks):
3359         (WTR::LayoutTestController::waitToDump):
3360         (WTR::LayoutTestController::testRepaint):
3361         (WTR::LayoutTestController::repaintSweepHorizontally):
3362         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
3363         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3364         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added.
3365         * WebKitTestRunner/win/build-generated-files.sh: Added.
3366
3367 2010-07-19  Mark Rowe  <mrowe@apple.com>
3368
3369         Clean up the buildbot configuration a little.
3370
3371         * BuildSlaveSupport/build.webkit.org-config/config.json:
3372
3373 2010-07-19  Chris Marrin  <cmarrin@apple.com>
3374
3375         Reviewed by Darin Adler.
3376
3377         https://bugs.webkit.org/show_bug.cgi?id=42118
3378         Disable WebGL on Leopard for now. 
3379
3380         LayoutTests fail on some graphics hardware on Leopard because one of the features we use,
3381         GL_ARB_framebuffer_object, is not universally available in Leopard like it is in
3382         SnowLeopard. This will allow LayoutTests to pass on Leopard until we add logic to use a
3383         software OpenGL driver on machines without this support.
3384
3385         * Scripts/build-webkit:
3386
3387 2010-07-19  Simon Fraser  <simon.fraser@apple.com>
3388
3389         Reviewed by Brady Eidson.
3390
3391         Fix MiniBrowser to update URL as you browse
3392         https://bugs.webkit.org/show_bug.cgi?id=42591
3393         
3394         Hook up various loading notifications to update the URL bar in MiniBrowser.
3395
3396         * MiniBrowser/mac/BrowserWindowController.m:
3397         (_didStartProvisionalLoadForFrame):
3398         (_didReceiveServerRedirectForProvisionalLoadForFrame):
3399         (_didFailProvisionalLoadWithErrorForFrame):
3400         (_didCommitLoadForFrame):
3401         (_didFailLoadWithErrorForFrame):
3402         (-[BrowserWindowController updateProvisionalURLForFrame:]):
3403         (-[BrowserWindowController didStartProvisionalLoadForFrame:]):
3404         (-[BrowserWindowController didReceiveServerRedirectForProvisionalLoadForFrame:]):
3405         (-[BrowserWindowController didFailProvisionalLoadWithErrorForFrame:]):
3406         (-[BrowserWindowController didFailLoadWithErrorForFrame:]):
3407         (-[BrowserWindowController didCommitLoadForFrame:]):
3408
3409 2010-07-19  Alexey Proskuryakov  <ap@apple.com>
3410
3411         Reviewed by Darin Adler.
3412
3413         https://bugs.webkit.org/show_bug.cgi?id=42586
3414         Log all canceled authentication attempts in DumpRenderTree
3415
3416         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3417         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
3418         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3419         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
3420         It's important to know whether an auth sheet appeared. Added logging to "no preset credentials"
3421         case.
3422
3423 2010-07-19  Sheriff Bot  <webkit.review.bot@gmail.com>
3424
3425         Unreviewed, rolling out r63671.
3426         http://trac.webkit.org/changeset/63671
3427         https://bugs.webkit.org/show_bug.cgi?id=42575
3428
3429         broke windows (Requested by weinig on #webkit).
3430
3431         * WebKitTestRunner/Configurations/Base.xcconfig:
3432         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3433         * WebKitTestRunner/DerivedSources.make: Removed.
3434         * WebKitTestRunner/ForwardingHeaders/wtf/GetPtr.h: Removed.
3435         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Removed.
3436         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h: Removed.
3437         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp: Removed.
3438         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h: Removed.
3439         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Removed.
3440         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3441         (WTR::InjectedBundlePage::dump):
3442         (WTR::InjectedBundlePage::setStatusbarText):
3443         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3444         (WTR::LayoutTestController::setWaitToDump):
3445         (WTR::displayCallback):
3446         (WTR::dumpAsTextCallback):
3447         (WTR::dumpStatusCallbacksCallback):
3448         (WTR::waitUntilDoneCallback):
3449         (WTR::notifyDoneCallback):
3450         (WTR::numberOfActiveAnimationsCallback):
3451         (WTR::pauseAnimationAtTimeOnElementWithIdCallback):
3452         (WTR::repaintSweepHorizontallyCallback):
3453         (WTR::testRepaintCallback):
3454         (WTR::layoutTestControllerObjectFinalize):
3455         (WTR::LayoutTestController::makeWindowObject):
3456         (WTR::LayoutTestController::getJSClass):
3457         (WTR::LayoutTestController::staticFunctions):
3458         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3459         (WTR::LayoutTestController::dumpAsText):
3460         (WTR::LayoutTestController::setDumpAsText):
3461         (WTR::LayoutTestController::dumpStatusCallbacks):
3462         (WTR::LayoutTestController::setDumpStatusCallbacks):
3463         (WTR::LayoutTestController::setTestRepaint):
3464         (WTR::LayoutTestController::setTestRepaintSweepHorizontally):
3465         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3466
3467 2010-07-19  Sam Weinig  <sam@webkit.org>
3468
3469         Reviewed by Adam Roben.
3470
3471         Patch for https://bugs.webkit.org/show_bug.cgi?id=42532
3472         Auto-generate the JS bindings for WebKitTestRunner's script objects.
3473
3474         * WebKitTestRunner/Configurations/Base.xcconfig:
3475         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3476         * WebKitTestRunner/DerivedSources.make: Added.
3477         * WebKitTestRunner/ForwardingHeaders/wtf/GetPtr.h: Added.
3478         * WebKitTestRunner/InjectedBundle/Bindings: Added.
3479         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Added.
3480         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h: Added.
3481         (WTR::JSWrappable::~JSWrappable):
3482         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp: Added.
3483         (WTR::JSWrapper::wrap):
3484         (WTR::JSWrapper::unwrap):
3485         (WTR::unwrapObject):
3486         (WTR::JSWrapper::initialize):
3487         (WTR::JSWrapper::finalize):
3488         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h: Added.
3489         (WTR::toJS):
3490         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added.
3491         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3492         (WTR::InjectedBundlePage::dump):
3493         (WTR::InjectedBundlePage::setStatusbarText):
3494         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3495         (WTR::LayoutTestController::wrapperClass):
3496         (WTR::LayoutTestController::waitUntilDone):
3497         (WTR::LayoutTestController::makeWindowObject):
3498         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3499         (WTR::LayoutTestController::shouldDumpAsText):
3500         (WTR::LayoutTestController::dumpAsText):
3501         (WTR::LayoutTestController::shouldDumpStatusCallbacks):
3502         (WTR::LayoutTestController::dumpStatusCallbacks):
3503         (WTR::LayoutTestController::waitToDump):
3504         (WTR::LayoutTestController::testRepaint):
3505         (WTR::LayoutTestController::repaintSweepHorizontally):
3506         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3507
3508 2010-07-19  Tony Chang  <tony@chromium.org>
3509
3510         Reviewed by David Levin.
3511
3512         fix chromium linux compile on ubuntu maverick
3513         https://bugs.webkit.org/show_bug.cgi?id=42528
3514
3515         * Scripts/webkitdirs.pm: add a chomp to eat a newline that breaks the make command line
3516
3517 2010-07-19  Adam Roben  <aroben@apple.com>
3518
3519         When dumping a response's MIME type, print its URL's last path
3520         component rather than its suitable-for-test-result form
3521
3522         This matches the Mac behavior.
3523
3524         Fixes <http://webkit.org/b/42276>
3525         http/tests/loading/preload-slow-loading.php and
3526         http/tests/mime/uppercase-mime-type.html fail on Windows
3527
3528         Reviewed by Anders Carlsson.
3529
3530         * DumpRenderTree/win/DumpRenderTree.cpp:
3531         (urlSuitableForTestResult): Moved code to actually extract the last
3532         path component from here...
3533         (lastPathComponent): ...to here.
3534
3535         * DumpRenderTree/win/DumpRenderTreeWin.h: Added lastPathComponent.
3536
3537         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3538         (ResourceLoadDelegate::didReceiveResponse): Use the URL's last path
3539         component, rather than its suitable-for-test-result form, to match
3540         Mac.
3541
3542 2010-07-19  Anders carlsson  <andersca@apple.com>
3543
3544         Reviewed by Adam Roben.
3545
3546         WebKit2 does not have application cache
3547         https://bugs.webkit.org/show_bug.cgi?id=42552
3548
3549         * WebKitTestRunner/TestInvocation.cpp:
3550         (WTR::TestInvocation::resetPreferencesToConsistentValues):
3551         Set up default preferences. Right now just enables the web application cache.
3552
3553         (WTR::TestInvocation::invoke):
3554         Call resetPreferencesToConsistentValues.
3555
3556         * WebKitTestRunner/TestInvocation.h:
3557
3558 2010-07-19  Kent Tamura  <tkent@chromium.org>
3559
3560         Reviewed by Adam Roben.
3561
3562         Fix NewRunWebKitTests to work on Windows.
3563         https://bugs.webkit.org/show_bug.cgi?id=41180
3564
3565         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3566           Specifying python explicitly.
3567
3568 2010-07-18  Anders Carlsson  <andersca@apple.com>
3569
3570         Reviewed by Dan Bernstein.
3571
3572         Add dumping of statusbar text to WebKitTestRunner
3573         https://bugs.webkit.org/show_bug.cgi?id=42516
3574
3575         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3576         (WTR::InjectedBundlePage::InjectedBundlePage):
3577         (WTR::InjectedBundlePage::_setStatusbarText):
3578         (WTR::InjectedBundlePage::setStatusbarText):
3579         Dump the statusbar text.
3580
3581         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3582         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3583         (WTR::LayoutTestController::LayoutTestController):
3584         Initialize m_dumpStatusCallbacks to false.
3585
3586         (WTR::dumpStatusCallbacksCallback):
3587         Implement JSC callback.
3588
3589         (WTR::LayoutTestController::staticFunctions):
3590         Add dumpStatusCallbacks.
3591
3592         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3593         (WTR::LayoutTestController::dumpStatusCallbacks):
3594         (WTR::LayoutTestController::setDumpStatusCallbacks):
3595         Add setter and getter for m_dumpStatusCallbacks.
3596
3597 2010-07-17  Anders Carlsson  <andersca@apple.com>
3598
3599         Reviewed by Maciej Stachowiak.
3600
3601         * WebKitTestRunner/TestController.cpp:
3602         (WTR::TestController::initialize):
3603         Get the test plug-in path and set it on the context.
3604
3605         * WebKitTestRunner/TestController.h:
3606         * WebKitTestRunner/mac/TestControllerMac.mm:
3607         (WTR::TestController::initializeInjectedBundlePath):
3608         Simplify this code by using NSBundle.
3609
3610         (WTR::TestController::testPluginPath):
3611         Return the test plug-in path.
3612
3613         * WebKitTestRunner/win/TestControllerWin.cpp:
3614         (WTR::TestController::testPluginPath):
3615         Ditto.
3616
3617 2010-07-16  Adam Barth  <abarth@webkit.org>
3618
3619         Reviewed by Eric Seidel.
3620
3621         Teach webkitpy about queues.webkit.org
3622         https://bugs.webkit.org/show_bug.cgi?id=42492
3623
3624         * Scripts/webkitpy/common/net/statusserver.py:
3625
3626 2010-07-16  Ada Chan  <adachan@apple.com>
3627
3628         Reviewed by Alice Liu.
3629
3630         Fix Windows build.
3631
3632         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
3633
3634 2010-07-16  Sam Weinig  <sam@webkit.org>
3635
3636         Reviewed by Anders Carlsson.
3637
3638         Fix for https://bugs.webkit.org/show_bug.cgi?id=42482
3639         <rdar://problem/8197701>
3640         Add notification of when the BackForwardList changes
3641         to aid invalidation of Back/Forward related UI elements.
3642
3643         * MiniBrowser/mac/BrowserWindowController.m:
3644         (_didStartProvisionalLoadForFrame):
3645         (_didCommitLoadForFrame):
3646         (_didFailLoadWithErrorForFrame):
3647         (_didChangeBackForwardList):
3648         (-[BrowserWindowController awakeFromNib]):
3649         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3650
3651 2010-07-16  Kent Tamura  <tkent@chromium.org>
3652
3653         Reviewed by Darin Fisher.
3654
3655         [Chromium] <input type=number> UI implementation for Windows
3656         https://bugs.webkit.org/show_bug.cgi?id=42259
3657
3658         * DumpRenderTree/chromium/WebThemeEngineDRT.cpp:
3659         (WebThemeEngineDRT::paintSpinButton):
3660          Added. Check state consistency and use existing arrow painting code.
3661         * DumpRenderTree/chromium/WebThemeEngineDRT.h:
3662
3663 2010-07-16  Alice Liu  <alice.liu@apple.com>
3664
3665         Reviewed by Sam Weinig.
3666
3667         https://bugs.webkit.org/show_bug.cgi?id=42430
3668         Make WebKitTestRunner on Windows actually load and run a test
3669
3670         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp: Export WKBundleInitialize.
3671         (WKBundleInitialize):
3672         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: Added.  Output is a dll.
3673         * WebKitTestRunner/TestInvocation.cpp: Create a Windows-style path on Windows
3674         (WTR::createWKURL):
3675         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Change check for Windows platform to match
3676         other existing checks, and avoid including Platform.h
3677         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3678         (WTR::registerWindowClass): Added.
3679         (WTR::PlatformWebView::PlatformWebView): Implemented.
3680         (WTR::PlatformWebView::~PlatformWebView): Implemented.
3681         (WTR::PlatformWebView::page): Implemented.
3682         * WebKitTestRunner/win/TestControllerWin.cpp:
3683         (WTR::TestController::initializeInjectedBundlePath): Implemented. Provide build 
3684         configuration specific path to InjectedBundle.dll.
3685         * WebKitTestRunner/win/TestInvocationWin.cpp:
3686         (WTR::TestInvocation::runUntil): Implemented.
3687         * WebKitTestRunner/win/WebKitTestRunner.sln: Added InjectedBundle project.
3688         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Cleaned up unnecessary dependencies.
3689
3690 2010-07-16  Brady Eidson  <beidson@apple.com>
3691
3692         Reviewed by Sam Weinig.
3693
3694         Make revalidation of back/forward work a little better with page loads
3695         https://bugs.webkit.org/show_bug.cgi?id=42470
3696
3697         * MiniBrowser/mac/BrowserWindow.xib:
3698         * MiniBrowser/mac/BrowserWindowController.h:
3699         * MiniBrowser/mac/BrowserWindowController.m:
3700         (-[BrowserWindowController validateToolbar]):
3701         (_didStartProvisionalLoadForFrame):
3702         (_didCommitLoadForFrame):
3703         (_didFailLoadWithErrorForFrame):
3704
3705 2010-07-16  Nikolas Zimmermann  <nzimmermann@rim.com>
3706
3707         Reviewed by Dirk Schulze.
3708
3709         Add possibility to dumpAsText and generate a pixel test result
3710         https://bugs.webkit.org/show_bug.cgi?id=42374
3711
3712         Add optional parameter to setDumpAsText() to allow generating a pixel test result even if dumpAsText mode.
3713         setDumpAsText(true) will also generate a pixel test result now, when running run-webkit-tests --pixel-tests.
3714
3715         This is needed for the svg/dynamic-updates tests, which don't want render tree dumps but text dumps + a pixel test result.
3716         At some point DRT changed to not generate pixel test results when using dumpAsText - which makes sense, but breaks the svg/dynamic-updates test.
3717
3718         Implemented for all DRT platforms, except Qt, as it's not clear how arguments to functions like "setDumpAsText" are handled.
3719         (Qt always dumps pixel tests when using --pixel-tests mode, so it does not break anything)
3720
3721         * DumpRenderTree/LayoutTestController.cpp:
3722         (LayoutTestController::LayoutTestController):
3723         (dumpAsTextAndPixelsCallback):
3724         (LayoutTestController::staticFunctions):
3725         * DumpRenderTree/LayoutTestController.h:
3726         (LayoutTestController::dumpAsTextAndPixels):
3727         (LayoutTestController::setDumpAsTextAndPixels):
3728         * DumpRenderTree/chromium/LayoutTestController.cpp:
3729         (LayoutTestController::LayoutTestController):
3730         (LayoutTestController::dumpAsTextAndPixels):
3731         (LayoutTestController::reset):
3732         * DumpRenderTree/chromium/LayoutTestController.h:
3733         (LayoutTestController::shouldDumpAsTextAndPixels):
3734         * DumpRenderTree/chromium/TestShell.cpp:
3735         (TestShell::dump):
3736         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3737         (dump):
3738         * DumpRenderTree/mac/DumpRenderTree.mm:
3739         (dump):
3740         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3741         (WebCore::DumpRenderTree::dump):
3742         * DumpRenderTree/win/DumpRenderTree.cpp:
3743         (dump):
3744         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
3745         (dump):
3746
3747 2010-07-16  Kent Hansen  <kent.hansen@nokia.com>
3748
3749         Unreviewed. Adding myself as committer.
3750
3751         * Scripts/webkitpy/common/config/committers.py:
3752
3753 2010-07-16  Shinichiro Hamaji  <hamaji@chromium.org>
3754
3755         Another uneviewed attempt to fix build.
3756
3757         Printing test results differ between machines, we should use ImageDiff instead
3758         https://bugs.webkit.org/show_bug.cgi?id=20011
3759
3760         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3761         (createPagedBitmapContext):
3762
3763 2010-07-16  Shinichiro Hamaji  <hamaji@chromium.org>
3764
3765         Unreviewed tiger build fix.
3766
3767         Printing test results differ between machines, we should use ImageDiff instead
3768         https://bugs.webkit.org/show_bug.cgi?id=20011
3769
3770         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3771         (createBitmapContext):
3772         (createBitmapContextFromWebView):
3773
3774 2010-07-15  Shinichiro Hamaji  <hamaji@chromium.org>
3775
3776         Unreviewed build fix.
3777
3778         Printing test results differ between machines, we should use ImageDiff instead
3779         https://bugs.webkit.org/show_bug.cgi?id=20011
3780
3781         * DumpRenderTree/PixelDumpSupport.cpp:
3782         (dumpWebViewAsPixelsAndCompareWithExpected):
3783
3784 2010-07-15  Shinichiro Hamaji  <hamaji@chromium.org>
3785
3786         Reviewed by Darin Adler.
3787
3788         Printing test results differ between machines, we should use ImageDiff instead
3789         https://bugs.webkit.org/show_bug.cgi?id=20011
3790
3791         * DumpRenderTree/PixelDumpSupport.cpp:
3792         (dumpWebViewAsPixelsAndCompareWithExpected):
3793         * DumpRenderTree/PixelDumpSupport.h:
3794         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3795         (createBitmapContext): This function was added to share bitmap context creation code.
3796         (createBitmapContextFromWebView):
3797         (createPagedBitmapContext):
3798
3799 2010-07-15  Yuta Kitamura  <yutak@chromium.org>
3800
3801         Reviewed by Kent Tamura.
3802
3803         Pull in pywebsocket-0.5.1
3804         https://bugs.webkit.org/show_bug.cgi?id=42353
3805
3806         pywebsocket-0.5.1 contains a small bug fix (*) that should fix a worker test
3807         in Chromium. There is no other functional change.
3808
3809         (*) http://code.google.com/p/pywebsocket/source/detail?r=265
3810
3811         * Scripts/webkitpy/thirdparty/__init__.py: Bump pywebsocket version to 0.5.1.
3812
3813 2010-07-15  Brady Eidson  <beidson@apple.com>
3814
3815         Reviewed by Sam Weinig.
3816
3817         Add toolbar and toolbar item validation for MiniBrowser
3818         https://bugs.webkit.org/show_bug.cgi?id=42422
3819
3820         * MiniBrowser/MBToolbarItem.h: Added.
3821         * MiniBrowser/MBToolbarItem.m: Added.
3822         (-[MBToolbarItem validate]):
3823
3824         * MiniBrowser/mac/BrowserWindowController.m:
3825         (-[BrowserWindowController validateUserInterfaceItem:]):
3826
3827         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3828         * MiniBrowser/mac/BrowserWindow.xib:
3829
3830 2010-07-15  Victor Wang  <victorw@chromium.org>
3831
3832         Unreviewed, add victorw irc nickname to committer list.
3833
3834         * Scripts/webkitpy/common/config/committers.py:
3835
3836 2010-07-15  Adam Roben  <aroben@apple.com>
3837
3838         Make killing Apache more reliable (on both Mac and Windows)
3839
3840         We previously had two ways of determining whether we had succeeded in
3841         killing Apache:
3842           1) checking the return value of kill(0, $apachePID)
3843           2) checking whether Apache's PID file still exists
3844
3845         On Cygwin, Apache doesn't always delete its PID file when it exits,
3846         making (2) unreliable. We unfortunately misdiagnosed this as an
3847         impotency of Perl's kill function, which led to r63177 and r63355.
3848
3849         Now that we know that the real problem is that Apache doesn't always
3850         delete its PID file on Windows, we can make a much better fix: always
3851         use method (1) to determine whether we've killed Apache.
3852
3853         Fixes <http://webkit.org/b/42415> Killing Apache is unreliable,
3854         leading to regression test failures (and general annoyance).
3855
3856         Reviewed by Anders Carlsson.
3857
3858         * Scripts/webkitperl/httpd.pm:
3859         (openHTTPD): Moved killing code from here to killHTTPD. Added a call
3860         to delete the PID file in case Apache doesn't do this itself when
3861         killed. Our later logic relies on the PID file being deleted after
3862         this point.
3863         (closeHTTPD): Removed killing logic and changed to just call killHTTPD
3864         instead. killHTTPD's logic is a bit different from the logic we had
3865         here, for the reasons stated above.
3866         (killHTTPD): Added. Code came from openHTTPD.
3867         (handleInterrupt): Bonus fix for Mac: don't hang when pressing Ctrl-C!
3868         On Mac, don't try to kill Apache when we receive a signal, as Apache
3869         will already have been killed by this point (though for some reason
3870         this isn't detected by our killing logic in killHTTPD). On Cygwin, we
3871         still need to kill Apache manually.
3872
3873 2010-07-15  Sam Weinig  <sam@webkit.org>
3874
3875         Reviewed by Anders Carlsson.
3876
3877         Patch for https://bugs.webkit.org/show_bug.cgi?id=42399
3878         Update MiniBrowser for WKFrameNavigationType 
3879
3880         * MiniBrowser/mac/BrowserWindowController.m:
3881         (_decidePolicyForNavigationAction):
3882         (_decidePolicyForNewWindowAction):
3883
3884 2010-07-15  Stephanie Lewis  <slewis@apple.com>
3885
3886         Reviewed by Geoff Garen.
3887
3888         http://bugs.webkit.org/show_bug.cgi?id=42406
3889         Make SunSpider work better with roots.
3890
3891         * Scripts/sunspider-compare-results: fix argument bug
3892         * Scripts/webkitdirs.pm: look inside JavaScriptCore if jsc isn't top-level.
3893
3894 2010-07-15  Brady Eidson  <beidson@apple.com>
3895
3896         Reviewed by Sam Weinig.
3897
3898         Hook up back/forward in MiniBrowser
3899         https://bugs.webkit.org/show_bug.cgi?id=42397
3900
3901         * MiniBrowser/mac/BrowserWindow.xib:
3902         * MiniBrowser/mac/BrowserWindowController.h:
3903         * MiniBrowser/mac/BrowserWindowController.m:
3904         (-[BrowserWindowController goBack:]):
3905         (-[BrowserWindowController goForward:]):
3906
3907 2010-07-15  Daniel Bates  <dbates@rim.com>
3908
3909         Reviewed by Darin Adler.
3910
3911         [Mac] Implement LayoutTestController::markerTextForListItem()
3912         https://bugs.webkit.org/show_bug.cgi?id=37929
3913
3914         Implements DRT support for markerTextForListItem in the Mac port.
3915
3916         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3917         (LayoutTestController::markerTextForListItem): Implemented.
3918
3919 2010-07-15  Adam Barth  <abarth@webkit.org>
3920
3921         Unreviewed.
3922
3923         Update the port names to be more specific.  Before this patch,
3924         port-specific results for Mac would end up in the wrong place.
3925
3926         * Scripts/webkitpy/tool/commands/rebaseline.py:
3927         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3928
3929 2010-07-14  Eric Seidel  <eric@webkit.org>
3930
3931         Reviewed by Adam Barth.
3932
3933         WebKit needs a rebaselining tool (finally)
3934         https://bugs.webkit.org/show_bug.cgi?id=42339
3935
3936         This is a very basic rebaselining tool.  It's not
3937         quite as fancy as chromium's as it will only handle
3938         updating failing results.  It cannot yet handle adding new
3939         results, or updating results where the results should not
3940         replace existing results.
3941
3942         * Scripts/webkitpy/layout_tests/port/base.py:
3943         * Scripts/webkitpy/tool/commands/__init__.py:
3944         * Scripts/webkitpy/tool/commands/queries.py:
3945         * Scripts/webkitpy/tool/commands/rebaseline.py: Added.
3946         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Added.
3947
3948 2010-07-14  Sheriff Bot  <webkit.review.bot@gmail.com>
3949
3950         Unreviewed, rolling out r63352.
3951         http://trac.webkit.org/changeset/63352
3952         https://bugs.webkit.org/show_bug.cgi?id=42341
3953
3954         Broke plugin-initiate-popup-window.html and plugin-javascript-
3955         access.html on snow leopard (Requested by abarth on #webkit).
3956
3957         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3958         (pluginAllocate):
3959         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
3960         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3961         (NPP_New):
3962         (handleEventCarbon):
3963         (handleEventCocoa):
3964
3965 2010-07-14  Maciej Stachowiak  <mjs@apple.com>
3966
3967         Reviewed by Mark Rowe.
3968
3969         Lower WebKitTestRunner notifyDone timeout to 6.0 for now, to make it easier to grind through the failures.
3970
3971         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3972
3973 2010-07-14  Sheriff Bot  <webkit.review.bot@gmail.com>
3974
3975         Unreviewed, rolling out r63346.
3976         http://trac.webkit.org/changeset/63346
3977         https://bugs.webkit.org/show_bug.cgi?id=42295
3978
3979         Broke lots of tests, some of which probably just need new
3980         results (Requested by aroben on #webkit).
3981
3982         * DumpRenderTree/win/DumpRenderTree.cpp:
3983         (urlSuitableForTestResult):
3984
3985 2010-07-14  Adam Roben  <aroben@apple.com>
3986
3987         Speed up killing of Apache on Windows
3988
3989         Fixes <http://webkit.org/b/42289> Killing Apache (and thus quitting
3990         run-webkit-tests) takes a long time on Windows
3991
3992         Reviewed by Darin Adler and Jon Honeycutt.
3993
3994         * Scripts/webkitperl/httpd.pm:
3995         (closeHTTPD): Use taskkill to kill Apache and its child processes.
3996         Perl's kill seems ineffectual. We were already using taskkill, but
3997         only after trying kill 20 times. Since kill never works, let's just
3998         skip it entirely.
3999
4000 2010-07-14  Johnny Ding  <jnd@chromium.org>
4001
4002         Reviewed by Adam Barth.
4003
4004         https://bugs.webkit.org/show_bug.cgi?id=41292
4005         Add a new parameter to the test plugin to allow to specify a script and a
4006         mouse/keyboard event. The specified script will be evaluated in the browser
4007         when the specified event is received by the plugin.
4008
4009         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
4010         (pluginAllocate):
4011         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
4012         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
4013         (NPP_New):
4014         (handleEventCarbon):
4015         (handleEventCocoa):
4016
4017 2010-07-14  Adam Roben  <aroben@apple.com>
4018
4019         Make urlSuitableForTestResult work for http: URLs, too
4020
4021         Fixes <http://webkit.org/b/42276>
4022         http/tests/loading/preload-slow-loading.php and
4023         http/tests/mime/uppercase-mime-type.html fail on Windows.
4024
4025         Reviewed by Darin Adler.
4026
4027         * DumpRenderTree/win/DumpRenderTree.cpp:
4028         (urlSuitableForTestResult): Don't bail if the URL starts with http://.
4029         We want this function to work for those URLs, too!
4030
4031 2010-07-13  Maciej Stachowiak  <mjs@apple.com>
4032
4033         Reviewed by Oliver Hunt.
4034
4035         Add placebo versions of some repaint test functions to WebKitTestRunner - good enough for non-pixel tests
4036         https://bugs.webkit.org/show_bug.cgi?id=42227
4037
4038         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
4039         (WTR::LayoutTestController::LayoutTestController): Initialize new bool
4040         members.
4041         (WTR::LayoutTestController::display): Dummy method.
4042         (WTR::displayCallback): Call the dummy.
4043         (WTR::repaintSweepHorizontallyCallback): ditto
4044         (WTR::testRepaintCallback): ditto
4045         (WTR::LayoutTestController::staticFunctions): Expose new methods.
4046         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
4047         (WTR::LayoutTestController::setTestRepaint): Set the flag (which currently does
4048         nothing).
4049         (WTR::LayoutTestController::setTestRepaintSweepHorizontally): ditto
4050
4051 2010-07-13  Andreas Kling  <andreas.kling@nokia.com>
4052
4053         Unreviewed. Adding myself as committer.
4054
4055         * Scripts/webkitpy/common/config/committers.py:
4056
4057 2010-07-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4058
4059         Reviewed by Darin Adler.
4060
4061         Prevent assertion/duplicate loads for non-deferred subtitute-data loads
4062
4063         https://bugs.webkit.org/show_bug.cgi?id=30879
4064
4065         MainResourceLoader uses the member m_initialRequest to store requests for future
4066         deferred loads. When doing the actual load in handleDataLoadNow(), we therefore
4067         have to clear this request so that subsequent entries into the loader will not
4068         start yet another load.
4069
4070         This can happen as a result of a PageGroupLoadDeferrer going out of scope when
4071         returning from Chrome::runJavaScriptAlert(), which calls setDeferredLoading(false),
4072         but only in the case of using both substitute-data and non-deferred main resource
4073         load together. That's why two new DRT functions were added:
4074
4075          * queueLoadHTMLString()
4076          * setDeferMainResourceLoad()
4077
4078         The change adds DRT hooks for Mac, Win and Qt for these two functions. For Mac
4079         and Win the hook uses new SPI in WebDataSource. For Qt a new static member was
4080         added to the FrameLoaderClientQt and accessed though DumpRenderTreeSupportQt.
4081
4082         * DumpRenderTree/LayoutTestController.cpp:
4083         (LayoutTestController::LayoutTestController):
4084         (queueLoadHTMLStringCallback):
4085         (setDeferMainResourceDataLoadCallback):
4086         (LayoutTestController::staticFunctions):
4087         (LayoutTestController::queueLoadHTMLString):
4088         * DumpRenderTree/LayoutTestController.h:
4089         (LayoutTestController::deferMainResourceDataLoad):
4090         (LayoutTestController::setDeferMainResourceDataLoad):
4091         * DumpRenderTree/WorkQueueItem.h:
4092         (LoadHTMLStringItem::LoadHTMLStringItem):
4093         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
4094         (LoadHTMLStringItem::invoke):
4095         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
4096         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
4097         * DumpRenderTree/mac/WorkQueueItemMac.mm:
4098         (LoadHTMLStringItem::invoke):
4099         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4100         (LayoutTestController::reset):
4101         (LayoutTestController::setDeferMainResourceDataLoad):
4102         (LayoutTestController::queueLoadHTMLString):
4103         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4104         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
4105         (LoadHTMLStringItem::invoke):
4106         * DumpRenderTree/qt/WorkQueueItemQt.h:
4107         (LoadHTMLStringItem::LoadHTMLStringItem):
4108         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
4109         (ResourceLoadDelegate::willSendRequest):
4110         * DumpRenderTree/win/WorkQueueItemWin.cpp:
4111         (LoadHTMLStringItem::invoke):
4112         * DumpRenderTree/wx/WorkQueueItemWx.cpp:
4113         (LoadHTMLStringItem::invoke):
4114
4115 2010-07-13  Maciej Stachowiak  <mjs@apple.com>
4116
4117         Reviewed by Nikolas Zimmermann.
4118
4119         Activate test fonts for layout tests in WebKitTestRunner (on Mac)
4120         https://bugs.webkit.org/show_bug.cgi?id=42153
4121
4122         * WebKitTestRunner/InjectedBundle/ActivateFonts.h: Added.
4123         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4124         (WTR::InjectedBundle::initialize): Activate fonts on startup.
4125         * WebKitTestRunner/InjectedBundle/mac: Added.
4126         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm: Added.
4127         (WTR::activateFonts): Activate our fonts.
4128         * WebKitTestRunner/InjectedBundle/win: Added.
4129         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp: Added.
4130         (WTR::activateFonts): Dummy version.
4131         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Copy fonts to bundle;
4132         add more files.
4133         * WebKitTestRunner/fonts: Added.
4134         * WebKitTestRunner/fonts/AHEM____.TTF: Added.
4135         * WebKitTestRunner/fonts/ColorBits-A.png: Added.
4136         * WebKitTestRunner/fonts/ColorBits.ttf: Added.
4137         * WebKitTestRunner/fonts/WebKit Layout Tests 2.ttf: Added.
4138         * WebKitTestRunner/fonts/WebKit Layout Tests.ttf: Added.
4139         * WebKitTestRunner/fonts/WebKitWeightWatcher100.ttf: Added.
4140         * WebKitTestRunner/fonts/WebKitWeightWatcher200.ttf: Added.
4141         * WebKitTestRunner/fonts/WebKitWeightWatcher300.ttf: Added.
4142         * WebKitTestRunner/fonts/WebKitWeightWatcher400.ttf: Added.
4143         * WebKitTestRunner/fonts/WebKitWeightWatcher500.ttf: Added.
4144         * WebKitTestRunner/fonts/WebKitWeightWatcher600.ttf: Added.
4145         * WebKitTestRunner/fonts/WebKitWeightWatcher700.ttf: Added.
4146         * WebKitTestRunner/fonts/WebKitWeightWatcher800.ttf: Added.
4147         * WebKitTestRunner/fonts/WebKitWeightWatcher900.ttf: Added.
4148
4149 2010-07-13  Dumitru Daniliuc  <dumi@chromium.org>
4150
4151         Reviewed by Eric Seidel.
4152
4153         Remove check-header-includes, as it didn't turn out to be very useful.
4154         https://bugs.webkit.org/show_bug.cgi?id=41970
4155
4156         * Scripts/check-header-includes: Removed.
4157
4158 2010-07-12  Steve Falkenburg  <sfalken@apple.com>
4159
4160         Reviewed by Maciej Stachowiak.
4161
4162         Make WebKit2 be built by build-webkit (so it will be built by build.webkit.org bots)
4163         https://bugs.webkit.org/show_bug.cgi?id=40922
4164         
4165         Always build WebKit2 on Windows. Necessary since our WebKit build on
4166         Windows is packaged into a DLL with WebKit2.
4167
4168         * Scripts/build-webkit: Always build WebKit2 on Windows.
4169
4170 2010-07-12  Brian Weinstein  <bweinstein@apple.com>
4171
4172         Reviewed by Steve Falkenburg.
4173
4174         One http test timing out on Windows can cause all future tests to time out
4175         https://bugs.webkit.org/show_bug.cgi?id=42146
4176         
4177         There have been multiple times on the Windows bots where one http test timing out causes all future
4178         http tests to time out. This is because the httpd process becomes unresponsive. When an http test
4179         times out, we should restart httpd on Cygwin to prevent this.
4180
4181         * Scripts/old-run-webkit-tests: If an http test timed out on Cygwin, close httpd and restart it.
4182         * Scripts/webkitperl/httpd.pm: Add additional logic to closeHTTPD to teach it about taskkill if
4183             using kill fails.
4184
4185 2010-07-12  Maciej Stachowiak  <mjs@apple.com>
4186
4187         Reviewed by Dan Bernstein.
4188
4189         Remove use of auto_ptr in WebKitTestRunner
4190         https://bugs.webkit.org/show_bug.cgi?id=42134
4191         
4192         Replaced auto_ptr with PassOwnPtr / OwnPtr.
4193
4194         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4195         (WTR::WKStringToUTF8):
4196         (WTR::InjectedBundlePage::dump):
4197         (WTR::InjectedBundlePage::addMessageToConsole):
4198         * WebKitTestRunner/TestInvocation.cpp:
4199         (WTR::WKStringToUTF8):
4200         (WTR::TestInvocation::didRecieveMessageFromInjectedBundle):
4201
4202 2010-07-12  Maciej Stachowiak  <mjs@apple.com>
4203
4204         Reviewed by Sam Weinig.
4205
4206         Need support for a WebKit2-specific Skipped list (and initially add accessibility tests to it)
4207         https://bugs.webkit.org/show_bug.cgi?id=42132
4208
4209         * Scripts/old-run-webkit-tests: In --webkit-test-runner mode, add mac-wk2 to list of
4210         platform directories.
4211
4212 2010-07-12  Maciej Stachowiak  <mjs@apple.com>
4213
4214         Reviewed by Anders Carlsson.
4215
4216         Make WebKitTestRunner resize the view specially for the W3C SVG tests.
4217         https://bugs.webkit.org/show_bug.cgi?id=42126
4218
4219         * WebKitTestRunner/PlatformWebView.h:
4220         * WebKitTestRunner/TestInvocation.cpp:
4221         (WTR::TestInvocation::TestInvocation): Store the path as a C
4222         string for later use.
4223         (WTR::TestInvocation::~TestInvocation):
4224         (WTR::sizeWebViewForCurrentTest): Resize the WebView to the proper
4225         size, depending on whether this is a W3C SVG test.
4226         (WTR::TestInvocation::invoke): Call the size function.
4227         * WebKitTestRunner/TestInvocation.h:
4228         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4229         (WTR::PlatformWebView::resizeTo): Implement.
4230         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
4231         (WTR::PlatformWebView::resizeTo): Placeholder.
4232
4233 2010-07-12  Mario Sanchez Prada  <msanchez@igalia.com>
4234
4235         Reviewed by Xan Lopez.
4236
4237         Ensure DRT loads GAIL (Gtk+ module), for a11y tests
4238         https://bugs.webkit.org/show_bug.cgi?id=38648